{"action":"created","comment":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments/48020380","id":48020380,"diff_hunk":"@@ -64,7 +67,7 @@ public function buildForm(FormBuilderInterface $builder, array $options)\n             'label' => $this->translator->trans('File', [], 'AdminProducts'),\n             'constraints' => array(\n                 new Assert\\NotNull(array('message' => $this->translator->trans('Please select a file', [], 'AdminProducts'))),\n-                new Assert\\File(array('maxSize' => '8M')),\n+                new Assert\\File(array('maxSize' => $this->configuration->get('PS_ATTACHMENT_MAXIMUM_SIZE').'M')),","path":"src/PrestaShopBundle/Form/Admin/Product/ProductAttachement.php","position":29,"original_position":29,"commit_id":"9b6efd1f653e02c4f32e7d9ac5967f7d6779b53c","original_commit_id":"9b6efd1f653e02c4f32e7d9ac5967f7d6779b53c","user":{"login":"mickaelandrieu","id":1247388,"avatar_url":"https://avatars.githubusercontent.com/u/1247388?v=3","gravatar_id":"","url":"https://api.github.com/users/mickaelandrieu","html_url":"https://github.com/mickaelandrieu","followers_url":"https://api.github.com/users/mickaelandrieu/followers","following_url":"https://api.github.com/users/mickaelandrieu/following{/other_user}","gists_url":"https://api.github.com/users/mickaelandrieu/gists{/gist_id}","starred_url":"https://api.github.com/users/mickaelandrieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mickaelandrieu/subscriptions","organizations_url":"https://api.github.com/users/mickaelandrieu/orgs","repos_url":"https://api.github.com/users/mickaelandrieu/repos","events_url":"https://api.github.com/users/mickaelandrieu/events{/privacy}","received_events_url":"https://api.github.com/users/mickaelandrieu/received_events","type":"User","site_admin":false},"body":"only one question: why not put \"8M\" in configuration file instead of \"8\" ?","created_at":"2015-12-18T12:27:16Z","updated_at":"2015-12-18T12:27:16Z","html_url":"https://github.com/PrestaShop/PrestaShop/pull/4606#discussion_r48020380","pull_request_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/4606","_links":{"self":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments/48020380"},"html":{"href":"https://github.com/PrestaShop/PrestaShop/pull/4606#discussion_r48020380"},"pull_request":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/4606"}}},"pull_request":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/4606","id":54097076,"html_url":"https://github.com/PrestaShop/PrestaShop/pull/4606","diff_url":"https://github.com/PrestaShop/PrestaShop/pull/4606.diff","patch_url":"https://github.com/PrestaShop/PrestaShop/pull/4606.patch","issue_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/4606","number":4606,"state":"open","locked":false,"title":"// refacto configuration acces (controller/form/twig)","user":{"login":"kelu95","id":359050,"avatar_url":"https://avatars.githubusercontent.com/u/359050?v=3","gravatar_id":"","url":"https://api.github.com/users/kelu95","html_url":"https://github.com/kelu95","followers_url":"https://api.github.com/users/kelu95/followers","following_url":"https://api.github.com/users/kelu95/following{/other_user}","gists_url":"https://api.github.com/users/kelu95/gists{/gist_id}","starred_url":"https://api.github.com/users/kelu95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kelu95/subscriptions","organizations_url":"https://api.github.com/users/kelu95/orgs","repos_url":"https://api.github.com/users/kelu95/repos","events_url":"https://api.github.com/users/kelu95/events{/privacy}","received_events_url":"https://api.github.com/users/kelu95/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-12-18T12:25:08Z","updated_at":"2015-12-18T12:27:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cebc1f3a4380d2595e8d4eeb629fd98cfbb8dcec","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/4606/commits","review_comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/4606/comments","review_comment_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/4606/comments","statuses_url":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/9b6efd1f653e02c4f32e7d9ac5967f7d6779b53c","head":{"label":"kelu95:refacto-configuration-adapter","ref":"refacto-configuration-adapter","sha":"9b6efd1f653e02c4f32e7d9ac5967f7d6779b53c","user":{"login":"kelu95","id":359050,"avatar_url":"https://avatars.githubusercontent.com/u/359050?v=3","gravatar_id":"","url":"https://api.github.com/users/kelu95","html_url":"https://github.com/kelu95","followers_url":"https://api.github.com/users/kelu95/followers","following_url":"https://api.github.com/users/kelu95/following{/other_user}","gists_url":"https://api.github.com/users/kelu95/gists{/gist_id}","starred_url":"https://api.github.com/users/kelu95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kelu95/subscriptions","organizations_url":"https://api.github.com/users/kelu95/orgs","repos_url":"https://api.github.com/users/kelu95/repos","events_url":"https://api.github.com/users/kelu95/events{/privacy}","received_events_url":"https://api.github.com/users/kelu95/received_events","type":"User","site_admin":false},"repo":{"id":35110848,"name":"PrestaShop","full_name":"kelu95/PrestaShop","owner":{"login":"kelu95","id":359050,"avatar_url":"https://avatars.githubusercontent.com/u/359050?v=3","gravatar_id":"","url":"https://api.github.com/users/kelu95","html_url":"https://github.com/kelu95","followers_url":"https://api.github.com/users/kelu95/followers","following_url":"https://api.github.com/users/kelu95/following{/other_user}","gists_url":"https://api.github.com/users/kelu95/gists{/gist_id}","starred_url":"https://api.github.com/users/kelu95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kelu95/subscriptions","organizations_url":"https://api.github.com/users/kelu95/orgs","repos_url":"https://api.github.com/users/kelu95/repos","events_url":"https://api.github.com/users/kelu95/events{/privacy}","received_events_url":"https://api.github.com/users/kelu95/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kelu95/PrestaShop","description":"PrestaShop offers a free, fully scalable, Open-source e-commerce solution.","fork":true,"url":"https://api.github.com/repos/kelu95/PrestaShop","forks_url":"https://api.github.com/repos/kelu95/PrestaShop/forks","keys_url":"https://api.github.com/repos/kelu95/PrestaShop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kelu95/PrestaShop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kelu95/PrestaShop/teams","hooks_url":"https://api.github.com/repos/kelu95/PrestaShop/hooks","issue_events_url":"https://api.github.com/repos/kelu95/PrestaShop/issues/events{/number}","events_url":"https://api.github.com/repos/kelu95/PrestaShop/events","assignees_url":"https://api.github.com/repos/kelu95/PrestaShop/assignees{/user}","branches_url":"https://api.github.com/repos/kelu95/PrestaShop/branches{/branch}","tags_url":"https://api.github.com/repos/kelu95/PrestaShop/tags","blobs_url":"https://api.github.com/repos/kelu95/PrestaShop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kelu95/PrestaShop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kelu95/PrestaShop/git/refs{/sha}","trees_url":"https://api.github.com/repos/kelu95/PrestaShop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kelu95/PrestaShop/statuses/{sha}","languages_url":"https://api.github.com/repos/kelu95/PrestaShop/languages","stargazers_url":"https://api.github.com/repos/kelu95/PrestaShop/stargazers","contributors_url":"https://api.github.com/repos/kelu95/PrestaShop/contributors","subscribers_url":"https://api.github.com/repos/kelu95/PrestaShop/subscribers","subscription_url":"https://api.github.com/repos/kelu95/PrestaShop/subscription","commits_url":"https://api.github.com/repos/kelu95/PrestaShop/commits{/sha}","git_commits_url":"https://api.github.com/repos/kelu95/PrestaShop/git/commits{/sha}","comments_url":"https://api.github.com/repos/kelu95/PrestaShop/comments{/number}","issue_comment_url":"https://api.github.com/repos/kelu95/PrestaShop/issues/comments{/number}","contents_url":"https://api.github.com/repos/kelu95/PrestaShop/contents/{+path}","compare_url":"https://api.github.com/repos/kelu95/PrestaShop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kelu95/PrestaShop/merges","archive_url":"https://api.github.com/repos/kelu95/PrestaShop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kelu95/PrestaShop/downloads","issues_url":"https://api.github.com/repos/kelu95/PrestaShop/issues{/number}","pulls_url":"https://api.github.com/repos/kelu95/PrestaShop/pulls{/number}","milestones_url":"https://api.github.com/repos/kelu95/PrestaShop/milestones{/number}","notifications_url":"https://api.github.com/repos/kelu95/PrestaShop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kelu95/PrestaShop/labels{/name}","releases_url":"https://api.github.com/repos/kelu95/PrestaShop/releases{/id}","created_at":"2015-05-05T16:24:22Z","updated_at":"2015-05-05T16:24:31Z","pushed_at":"2015-12-18T12:24:51Z","git_url":"git://github.com/kelu95/PrestaShop.git","ssh_url":"git@github.com:kelu95/PrestaShop.git","clone_url":"https://github.com/kelu95/PrestaShop.git","svn_url":"https://github.com/kelu95/PrestaShop","homepage":"http://www.prestashop.com/","size":218292,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"PrestaShop:develop","ref":"develop","sha":"0693d03c8ad754f89c039f253e9459db119c0150","user":{"login":"PrestaShop","id":2815696,"avatar_url":"https://avatars.githubusercontent.com/u/2815696?v=3","gravatar_id":"","url":"https://api.github.com/users/PrestaShop","html_url":"https://github.com/PrestaShop","followers_url":"https://api.github.com/users/PrestaShop/followers","following_url":"https://api.github.com/users/PrestaShop/following{/other_user}","gists_url":"https://api.github.com/users/PrestaShop/gists{/gist_id}","starred_url":"https://api.github.com/users/PrestaShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrestaShop/subscriptions","organizations_url":"https://api.github.com/users/PrestaShop/orgs","repos_url":"https://api.github.com/users/PrestaShop/repos","events_url":"https://api.github.com/users/PrestaShop/events{/privacy}","received_events_url":"https://api.github.com/users/PrestaShop/received_events","type":"Organization","site_admin":false},"repo":{"id":6763587,"name":"PrestaShop","full_name":"PrestaShop/PrestaShop","owner":{"login":"PrestaShop","id":2815696,"avatar_url":"https://avatars.githubusercontent.com/u/2815696?v=3","gravatar_id":"","url":"https://api.github.com/users/PrestaShop","html_url":"https://github.com/PrestaShop","followers_url":"https://api.github.com/users/PrestaShop/followers","following_url":"https://api.github.com/users/PrestaShop/following{/other_user}","gists_url":"https://api.github.com/users/PrestaShop/gists{/gist_id}","starred_url":"https://api.github.com/users/PrestaShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrestaShop/subscriptions","organizations_url":"https://api.github.com/users/PrestaShop/orgs","repos_url":"https://api.github.com/users/PrestaShop/repos","events_url":"https://api.github.com/users/PrestaShop/events{/privacy}","received_events_url":"https://api.github.com/users/PrestaShop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PrestaShop/PrestaShop","description":"PrestaShop offers a free, fully scalable, Open-source e-commerce solution.","fork":false,"url":"https://api.github.com/repos/PrestaShop/PrestaShop","forks_url":"https://api.github.com/repos/PrestaShop/PrestaShop/forks","keys_url":"https://api.github.com/repos/PrestaShop/PrestaShop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PrestaShop/PrestaShop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PrestaShop/PrestaShop/teams","hooks_url":"https://api.github.com/repos/PrestaShop/PrestaShop/hooks","issue_events_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/events{/number}","events_url":"https://api.github.com/repos/PrestaShop/PrestaShop/events","assignees_url":"https://api.github.com/repos/PrestaShop/PrestaShop/assignees{/user}","branches_url":"https://api.github.com/repos/PrestaShop/PrestaShop/branches{/branch}","tags_url":"https://api.github.com/repos/PrestaShop/PrestaShop/tags","blobs_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/refs{/sha}","trees_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/{sha}","languages_url":"https://api.github.com/repos/PrestaShop/PrestaShop/languages","stargazers_url":"https://api.github.com/repos/PrestaShop/PrestaShop/stargazers","contributors_url":"https://api.github.com/repos/PrestaShop/PrestaShop/contributors","subscribers_url":"https://api.github.com/repos/PrestaShop/PrestaShop/subscribers","subscription_url":"https://api.github.com/repos/PrestaShop/PrestaShop/subscription","commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/commits{/sha}","git_commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/commits{/sha}","comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/comments{/number}","issue_comment_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/comments{/number}","contents_url":"https://api.github.com/repos/PrestaShop/PrestaShop/contents/{+path}","compare_url":"https://api.github.com/repos/PrestaShop/PrestaShop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PrestaShop/PrestaShop/merges","archive_url":"https://api.github.com/repos/PrestaShop/PrestaShop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PrestaShop/PrestaShop/downloads","issues_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues{/number}","pulls_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls{/number}","milestones_url":"https://api.github.com/repos/PrestaShop/PrestaShop/milestones{/number}","notifications_url":"https://api.github.com/repos/PrestaShop/PrestaShop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels{/name}","releases_url":"https://api.github.com/repos/PrestaShop/PrestaShop/releases{/id}","created_at":"2012-11-19T16:41:31Z","updated_at":"2015-12-18T04:23:40Z","pushed_at":"2015-12-18T12:25:08Z","git_url":"git://github.com/PrestaShop/PrestaShop.git","ssh_url":"git@github.com:PrestaShop/PrestaShop.git","clone_url":"https://github.com/PrestaShop/PrestaShop.git","svn_url":"https://github.com/PrestaShop/PrestaShop","homepage":"http://www.prestashop.com/","size":241988,"stargazers_count":1554,"watchers_count":1554,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1707,"mirror_url":null,"open_issues_count":399,"forks":1707,"open_issues":399,"watchers":1554,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/4606"},"html":{"href":"https://github.com/PrestaShop/PrestaShop/pull/4606"},"issue":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/4606"},"comments":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/4606/comments"},"review_comments":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/4606/comments"},"review_comment":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/4606/commits"},"statuses":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/9b6efd1f653e02c4f32e7d9ac5967f7d6779b53c"}}}}