{"action":"created","comment":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/comments/32654952","id":32654952,"diff_hunk":"@@ -290,6 +298,40 @@ static void IsBusyConversion(Service::Interface* self) {\n     LOG_DEBUG(Service_Y2R, \"called\");\n }\n \n+/**\n+ * Y2R_U::SetConversionParams service function\n+ */\n+static void SetConversionParams(Service::Interface* self) {\n+    u32* cmd_buff = Kernel::GetCommandBuffer();\n+\n+    auto params = reinterpret_cast<const ConversionParameters*>(&cmd_buff[1]);\n+    LOG_DEBUG(Service_Y2R,\n+        \"called input_format=%hhu output_format=%hhu rotation=%hhu block_alignment=%hhu \"\n+        \"input_line_width=%hu input_lines=%hu standard_coefficient=%hhu \"\n+        \"reserved=%hhu alpha=%hX\",\n+        params->input_format, params->output_format, params->rotation, params->block_alignment,\n+        params->input_line_width, params->input_lines, params->standard_coefficient,\n+        params->reserved, params->alpha);\n+\n+    ResultCode result = RESULT_SUCCESS;\n+\n+    conversion.input_format = params->input_format;\n+    conversion.output_format = params->output_format;\n+    conversion.rotation = params->rotation;\n+    conversion.block_alignment = params->block_alignment;\n+    result = conversion.SetInputLineWidth(params->input_line_width);\n+    if (result.IsError()) goto error;","path":"src/core/hle/service/y2r_u.cpp","position":474,"original_position":474,"commit_id":"072628785b4e2c6bd39db0d933ef34478a067cc9","original_commit_id":"072628785b4e2c6bd39db0d933ef34478a067cc9","user":{"login":"bunnei","id":6956688,"avatar_url":"https://avatars.githubusercontent.com/u/6956688?v=3","gravatar_id":"","url":"https://api.github.com/users/bunnei","html_url":"https://github.com/bunnei","followers_url":"https://api.github.com/users/bunnei/followers","following_url":"https://api.github.com/users/bunnei/following{/other_user}","gists_url":"https://api.github.com/users/bunnei/gists{/gist_id}","starred_url":"https://api.github.com/users/bunnei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bunnei/subscriptions","organizations_url":"https://api.github.com/users/bunnei/orgs","repos_url":"https://api.github.com/users/bunnei/repos","events_url":"https://api.github.com/users/bunnei/events{/privacy}","received_events_url":"https://api.github.com/users/bunnei/received_events","type":"User","site_admin":false},"body":"But but but... I thought we said \"absolutely no goto blah blah blah\"","created_at":"2015-06-17T17:55:29Z","updated_at":"2015-06-17T17:55:29Z","html_url":"https://github.com/citra-emu/citra/pull/860#discussion_r32654952","pull_request_url":"https://api.github.com/repos/citra-emu/citra/pulls/860","_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments/32654952"},"html":{"href":"https://github.com/citra-emu/citra/pull/860#discussion_r32654952"},"pull_request":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/860"}}},"pull_request":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/860","id":37634970,"html_url":"https://github.com/citra-emu/citra/pull/860","diff_url":"https://github.com/citra-emu/citra/pull/860.diff","patch_url":"https://github.com/citra-emu/citra/pull/860.patch","issue_url":"https://api.github.com/repos/citra-emu/citra/issues/860","number":860,"state":"open","locked":false,"title":"Color support for Y2R","user":{"login":"yuriks","id":341401,"avatar_url":"https://avatars.githubusercontent.com/u/341401?v=3","gravatar_id":"","url":"https://api.github.com/users/yuriks","html_url":"https://github.com/yuriks","followers_url":"https://api.github.com/users/yuriks/followers","following_url":"https://api.github.com/users/yuriks/following{/other_user}","gists_url":"https://api.github.com/users/yuriks/gists{/gist_id}","starred_url":"https://api.github.com/users/yuriks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuriks/subscriptions","organizations_url":"https://api.github.com/users/yuriks/orgs","repos_url":"https://api.github.com/users/yuriks/repos","events_url":"https://api.github.com/users/yuriks/events{/privacy}","received_events_url":"https://api.github.com/users/yuriks/received_events","type":"User","site_admin":false},"body":"This implements support for all combinations of conversion formats to the y2r implementation. There are still some unknown hardware that haven't been RE'd, but they don't seem to affect the output on my tests.","created_at":"2015-06-14T02:22:52Z","updated_at":"2015-06-17T17:55:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"caccae27c582ceef37df4ae91ecdc54e1af34e9c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/citra-emu/citra/pulls/860/commits","review_comments_url":"https://api.github.com/repos/citra-emu/citra/pulls/860/comments","review_comment_url":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/citra-emu/citra/issues/860/comments","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/072628785b4e2c6bd39db0d933ef34478a067cc9","head":{"label":"yuriks:y2r-color","ref":"y2r-color","sha":"072628785b4e2c6bd39db0d933ef34478a067cc9","user":{"login":"yuriks","id":341401,"avatar_url":"https://avatars.githubusercontent.com/u/341401?v=3","gravatar_id":"","url":"https://api.github.com/users/yuriks","html_url":"https://github.com/yuriks","followers_url":"https://api.github.com/users/yuriks/followers","following_url":"https://api.github.com/users/yuriks/following{/other_user}","gists_url":"https://api.github.com/users/yuriks/gists{/gist_id}","starred_url":"https://api.github.com/users/yuriks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuriks/subscriptions","organizations_url":"https://api.github.com/users/yuriks/orgs","repos_url":"https://api.github.com/users/yuriks/repos","events_url":"https://api.github.com/users/yuriks/events{/privacy}","received_events_url":"https://api.github.com/users/yuriks/received_events","type":"User","site_admin":false},"repo":{"id":22018631,"name":"citra","full_name":"yuriks/citra","owner":{"login":"yuriks","id":341401,"avatar_url":"https://avatars.githubusercontent.com/u/341401?v=3","gravatar_id":"","url":"https://api.github.com/users/yuriks","html_url":"https://github.com/yuriks","followers_url":"https://api.github.com/users/yuriks/followers","following_url":"https://api.github.com/users/yuriks/following{/other_user}","gists_url":"https://api.github.com/users/yuriks/gists{/gist_id}","starred_url":"https://api.github.com/users/yuriks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuriks/subscriptions","organizations_url":"https://api.github.com/users/yuriks/orgs","repos_url":"https://api.github.com/users/yuriks/repos","events_url":"https://api.github.com/users/yuriks/events{/privacy}","received_events_url":"https://api.github.com/users/yuriks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yuriks/citra","description":"Nintendo 3DS emulator/debugger","fork":true,"url":"https://api.github.com/repos/yuriks/citra","forks_url":"https://api.github.com/repos/yuriks/citra/forks","keys_url":"https://api.github.com/repos/yuriks/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yuriks/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yuriks/citra/teams","hooks_url":"https://api.github.com/repos/yuriks/citra/hooks","issue_events_url":"https://api.github.com/repos/yuriks/citra/issues/events{/number}","events_url":"https://api.github.com/repos/yuriks/citra/events","assignees_url":"https://api.github.com/repos/yuriks/citra/assignees{/user}","branches_url":"https://api.github.com/repos/yuriks/citra/branches{/branch}","tags_url":"https://api.github.com/repos/yuriks/citra/tags","blobs_url":"https://api.github.com/repos/yuriks/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yuriks/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yuriks/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/yuriks/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yuriks/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/yuriks/citra/languages","stargazers_url":"https://api.github.com/repos/yuriks/citra/stargazers","contributors_url":"https://api.github.com/repos/yuriks/citra/contributors","subscribers_url":"https://api.github.com/repos/yuriks/citra/subscribers","subscription_url":"https://api.github.com/repos/yuriks/citra/subscription","commits_url":"https://api.github.com/repos/yuriks/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/yuriks/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/yuriks/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/yuriks/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/yuriks/citra/contents/{+path}","compare_url":"https://api.github.com/repos/yuriks/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yuriks/citra/merges","archive_url":"https://api.github.com/repos/yuriks/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yuriks/citra/downloads","issues_url":"https://api.github.com/repos/yuriks/citra/issues{/number}","pulls_url":"https://api.github.com/repos/yuriks/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/yuriks/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/yuriks/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yuriks/citra/labels{/name}","releases_url":"https://api.github.com/repos/yuriks/citra/releases{/id}","created_at":"2014-07-19T20:23:37Z","updated_at":"2015-02-28T02:10:18Z","pushed_at":"2015-06-14T22:22:31Z","git_url":"git://github.com/yuriks/citra.git","ssh_url":"git@github.com:yuriks/citra.git","clone_url":"https://github.com/yuriks/citra.git","svn_url":"https://github.com/yuriks/citra","homepage":null,"size":9880,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"citra-emu:master","ref":"master","sha":"bd5c943c658f0fa74531e845242f7b00c504b9dc","user":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=3","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":19866730,"name":"citra","full_name":"citra-emu/citra","owner":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=3","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/citra-emu/citra","description":"Nintendo 3DS emulator/debugger","fork":false,"url":"https://api.github.com/repos/citra-emu/citra","forks_url":"https://api.github.com/repos/citra-emu/citra/forks","keys_url":"https://api.github.com/repos/citra-emu/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/citra-emu/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/citra-emu/citra/teams","hooks_url":"https://api.github.com/repos/citra-emu/citra/hooks","issue_events_url":"https://api.github.com/repos/citra-emu/citra/issues/events{/number}","events_url":"https://api.github.com/repos/citra-emu/citra/events","assignees_url":"https://api.github.com/repos/citra-emu/citra/assignees{/user}","branches_url":"https://api.github.com/repos/citra-emu/citra/branches{/branch}","tags_url":"https://api.github.com/repos/citra-emu/citra/tags","blobs_url":"https://api.github.com/repos/citra-emu/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/citra-emu/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/citra-emu/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/citra-emu/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/citra-emu/citra/languages","stargazers_url":"https://api.github.com/repos/citra-emu/citra/stargazers","contributors_url":"https://api.github.com/repos/citra-emu/citra/contributors","subscribers_url":"https://api.github.com/repos/citra-emu/citra/subscribers","subscription_url":"https://api.github.com/repos/citra-emu/citra/subscription","commits_url":"https://api.github.com/repos/citra-emu/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/citra-emu/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/citra-emu/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/citra-emu/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/citra-emu/citra/contents/{+path}","compare_url":"https://api.github.com/repos/citra-emu/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/citra-emu/citra/merges","archive_url":"https://api.github.com/repos/citra-emu/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/citra-emu/citra/downloads","issues_url":"https://api.github.com/repos/citra-emu/citra/issues{/number}","pulls_url":"https://api.github.com/repos/citra-emu/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/citra-emu/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/citra-emu/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/citra-emu/citra/labels{/name}","releases_url":"https://api.github.com/repos/citra-emu/citra/releases{/id}","created_at":"2014-05-16T18:33:15Z","updated_at":"2015-06-15T22:50:59Z","pushed_at":"2015-06-17T16:56:39Z","git_url":"git://github.com/citra-emu/citra.git","ssh_url":"git@github.com:citra-emu/citra.git","clone_url":"https://github.com/citra-emu/citra.git","svn_url":"https://github.com/citra-emu/citra","homepage":null,"size":20769,"stargazers_count":905,"watchers_count":905,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":227,"mirror_url":null,"open_issues_count":77,"forks":227,"open_issues":77,"watchers":905,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/860"},"html":{"href":"https://github.com/citra-emu/citra/pull/860"},"issue":{"href":"https://api.github.com/repos/citra-emu/citra/issues/860"},"comments":{"href":"https://api.github.com/repos/citra-emu/citra/issues/860/comments"},"review_comments":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/860/comments"},"review_comment":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/860/commits"},"statuses":{"href":"https://api.github.com/repos/citra-emu/citra/statuses/072628785b4e2c6bd39db0d933ef34478a067cc9"}}}}