{"action":"created","comment":{"url":"https://api.github.com/repos/yoshdog/battle-ships/pulls/comments/25157087","id":25157087,"diff_hunk":"@@ -3,27 +3,26 @@\n require 'battleships/ship_placer'\n require 'battleships/shot_placer'\n \n-module Battleships\n+module BattleShips\n   class Game\n-    attr_reader :finished\n-\n-    def initialize(players:)\n-      @finished = false\n+    def initialize(players)\n       @players = players\n-      @grids = @players.each_with_object({}) { |player, memo| memo[player] = Grid.new(player) }\n+      @grids = @players.each_with_object({}) do |player, memo|\n+        memo[player] = Grid.new(player: player)\n+      end\n     end\n \n     def display\n-      @grids.values.map { |grid| GridRenderer.new(grid).render }\n+      @grids.values.map { |grid| GridRenderer.new(grid).render }.join(\"\\n\")\n     end\n \n-    def place_ship(player:, ship_length: 3, coordinates:)\n-      ShipPlacer.place(grid: @grids[player], ship_length: ship_length, coordinates: coordinates)\n+    def place_ship(player:, coordinate:, ship_length: 3)","path":"lib/battleships/game.rb","position":26,"original_position":26,"commit_id":"3f635d296217d96eb8d08ec07eec25c1df0f88bc","original_commit_id":"3f635d296217d96eb8d08ec07eec25c1df0f88bc","user":{"login":"vonconrad","id":148582,"avatar_url":"https://avatars.githubusercontent.com/u/148582?v=3","gravatar_id":"","url":"https://api.github.com/users/vonconrad","html_url":"https://github.com/vonconrad","followers_url":"https://api.github.com/users/vonconrad/followers","following_url":"https://api.github.com/users/vonconrad/following{/other_user}","gists_url":"https://api.github.com/users/vonconrad/gists{/gist_id}","starred_url":"https://api.github.com/users/vonconrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vonconrad/subscriptions","organizations_url":"https://api.github.com/users/vonconrad/orgs","repos_url":"https://api.github.com/users/vonconrad/repos","events_url":"https://api.github.com/users/vonconrad/events{/privacy}","received_events_url":"https://api.github.com/users/vonconrad/received_events","type":"User","site_admin":false},"body":"I'm seeing `coordinate` being used over `coordinates` in several places in this PR. I'm not sure that's accurate. In a coordinate system, each number (e.g. `a` or `1`) is a coordinate, and a point on the map is comprised of a pair of coordinates. So I actually think `coordinates` is a better name.","created_at":"2015-02-23T11:25:21Z","updated_at":"2015-02-23T11:25:21Z","html_url":"https://github.com/yoshdog/battle-ships/pull/1#discussion_r25157087","pull_request_url":"https://api.github.com/repos/yoshdog/battle-ships/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/yoshdog/battle-ships/pulls/comments/25157087"},"html":{"href":"https://github.com/yoshdog/battle-ships/pull/1#discussion_r25157087"},"pull_request":{"href":"https://api.github.com/repos/yoshdog/battle-ships/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/yoshdog/battle-ships/pulls/1","id":29800662,"html_url":"https://github.com/yoshdog/battle-ships/pull/1","diff_url":"https://github.com/yoshdog/battle-ships/pull/1.diff","patch_url":"https://github.com/yoshdog/battle-ships/pull/1.patch","issue_url":"https://api.github.com/repos/yoshdog/battle-ships/issues/1","number":1,"state":"closed","locked":false,"title":"Redo but with TDD","user":{"login":"yoshdog","id":5410975,"avatar_url":"https://avatars.githubusercontent.com/u/5410975?v=3","gravatar_id":"","url":"https://api.github.com/users/yoshdog","html_url":"https://github.com/yoshdog","followers_url":"https://api.github.com/users/yoshdog/followers","following_url":"https://api.github.com/users/yoshdog/following{/other_user}","gists_url":"https://api.github.com/users/yoshdog/gists{/gist_id}","starred_url":"https://api.github.com/users/yoshdog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoshdog/subscriptions","organizations_url":"https://api.github.com/users/yoshdog/orgs","repos_url":"https://api.github.com/users/yoshdog/repos","events_url":"https://api.github.com/users/yoshdog/events{/privacy}","received_events_url":"https://api.github.com/users/yoshdog/received_events","type":"User","site_admin":false},"body":"with integration and unit tests.","created_at":"2015-02-23T11:11:11Z","updated_at":"2015-02-23T11:25:21Z","closed_at":"2015-02-23T11:11:18Z","merged_at":"2015-02-23T11:11:18Z","merge_commit_sha":"5d0f0ae63464fddbc1431e2be2db716e652b34ce","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yoshdog/battle-ships/pulls/1/commits","review_comments_url":"https://api.github.com/repos/yoshdog/battle-ships/pulls/1/comments","review_comment_url":"https://api.github.com/repos/yoshdog/battle-ships/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yoshdog/battle-ships/issues/1/comments","statuses_url":"https://api.github.com/repos/yoshdog/battle-ships/statuses/3f635d296217d96eb8d08ec07eec25c1df0f88bc","head":{"label":"yoshdog:tdd","ref":"tdd","sha":"3f635d296217d96eb8d08ec07eec25c1df0f88bc","user":{"login":"yoshdog","id":5410975,"avatar_url":"https://avatars.githubusercontent.com/u/5410975?v=3","gravatar_id":"","url":"https://api.github.com/users/yoshdog","html_url":"https://github.com/yoshdog","followers_url":"https://api.github.com/users/yoshdog/followers","following_url":"https://api.github.com/users/yoshdog/following{/other_user}","gists_url":"https://api.github.com/users/yoshdog/gists{/gist_id}","starred_url":"https://api.github.com/users/yoshdog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoshdog/subscriptions","organizations_url":"https://api.github.com/users/yoshdog/orgs","repos_url":"https://api.github.com/users/yoshdog/repos","events_url":"https://api.github.com/users/yoshdog/events{/privacy}","received_events_url":"https://api.github.com/users/yoshdog/received_events","type":"User","site_admin":false},"repo":{"id":31008997,"name":"battle-ships","full_name":"yoshdog/battle-ships","owner":{"login":"yoshdog","id":5410975,"avatar_url":"https://avatars.githubusercontent.com/u/5410975?v=3","gravatar_id":"","url":"https://api.github.com/users/yoshdog","html_url":"https://github.com/yoshdog","followers_url":"https://api.github.com/users/yoshdog/followers","following_url":"https://api.github.com/users/yoshdog/following{/other_user}","gists_url":"https://api.github.com/users/yoshdog/gists{/gist_id}","starred_url":"https://api.github.com/users/yoshdog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoshdog/subscriptions","organizations_url":"https://api.github.com/users/yoshdog/orgs","repos_url":"https://api.github.com/users/yoshdog/repos","events_url":"https://api.github.com/users/yoshdog/events{/privacy}","received_events_url":"https://api.github.com/users/yoshdog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yoshdog/battle-ships","description":"","fork":false,"url":"https://api.github.com/repos/yoshdog/battle-ships","forks_url":"https://api.github.com/repos/yoshdog/battle-ships/forks","keys_url":"https://api.github.com/repos/yoshdog/battle-ships/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yoshdog/battle-ships/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yoshdog/battle-ships/teams","hooks_url":"https://api.github.com/repos/yoshdog/battle-ships/hooks","issue_events_url":"https://api.github.com/repos/yoshdog/battle-ships/issues/events{/number}","events_url":"https://api.github.com/repos/yoshdog/battle-ships/events","assignees_url":"https://api.github.com/repos/yoshdog/battle-ships/assignees{/user}","branches_url":"https://api.github.com/repos/yoshdog/battle-ships/branches{/branch}","tags_url":"https://api.github.com/repos/yoshdog/battle-ships/tags","blobs_url":"https://api.github.com/repos/yoshdog/battle-ships/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yoshdog/battle-ships/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yoshdog/battle-ships/git/refs{/sha}","trees_url":"https://api.github.com/repos/yoshdog/battle-ships/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yoshdog/battle-ships/statuses/{sha}","languages_url":"https://api.github.com/repos/yoshdog/battle-ships/languages","stargazers_url":"https://api.github.com/repos/yoshdog/battle-ships/stargazers","contributors_url":"https://api.github.com/repos/yoshdog/battle-ships/contributors","subscribers_url":"https://api.github.com/repos/yoshdog/battle-ships/subscribers","subscription_url":"https://api.github.com/repos/yoshdog/battle-ships/subscription","commits_url":"https://api.github.com/repos/yoshdog/battle-ships/commits{/sha}","git_commits_url":"https://api.github.com/repos/yoshdog/battle-ships/git/commits{/sha}","comments_url":"https://api.github.com/repos/yoshdog/battle-ships/comments{/number}","issue_comment_url":"https://api.github.com/repos/yoshdog/battle-ships/issues/comments{/number}","contents_url":"https://api.github.com/repos/yoshdog/battle-ships/contents/{+path}","compare_url":"https://api.github.com/repos/yoshdog/battle-ships/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yoshdog/battle-ships/merges","archive_url":"https://api.github.com/repos/yoshdog/battle-ships/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yoshdog/battle-ships/downloads","issues_url":"https://api.github.com/repos/yoshdog/battle-ships/issues{/number}","pulls_url":"https://api.github.com/repos/yoshdog/battle-ships/pulls{/number}","milestones_url":"https://api.github.com/repos/yoshdog/battle-ships/milestones{/number}","notifications_url":"https://api.github.com/repos/yoshdog/battle-ships/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yoshdog/battle-ships/labels{/name}","releases_url":"https://api.github.com/repos/yoshdog/battle-ships/releases{/id}","created_at":"2015-02-19T09:45:29Z","updated_at":"2015-02-23T11:11:18Z","pushed_at":"2015-02-23T11:11:28Z","git_url":"git://github.com/yoshdog/battle-ships.git","ssh_url":"git@github.com:yoshdog/battle-ships.git","clone_url":"https://github.com/yoshdog/battle-ships.git","svn_url":"https://github.com/yoshdog/battle-ships","homepage":null,"size":0,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"yoshdog:master","ref":"master","sha":"d9d934032b626e9f4e3e44b3049ab3c243d345f1","user":{"login":"yoshdog","id":5410975,"avatar_url":"https://avatars.githubusercontent.com/u/5410975?v=3","gravatar_id":"","url":"https://api.github.com/users/yoshdog","html_url":"https://github.com/yoshdog","followers_url":"https://api.github.com/users/yoshdog/followers","following_url":"https://api.github.com/users/yoshdog/following{/other_user}","gists_url":"https://api.github.com/users/yoshdog/gists{/gist_id}","starred_url":"https://api.github.com/users/yoshdog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoshdog/subscriptions","organizations_url":"https://api.github.com/users/yoshdog/orgs","repos_url":"https://api.github.com/users/yoshdog/repos","events_url":"https://api.github.com/users/yoshdog/events{/privacy}","received_events_url":"https://api.github.com/users/yoshdog/received_events","type":"User","site_admin":false},"repo":{"id":31008997,"name":"battle-ships","full_name":"yoshdog/battle-ships","owner":{"login":"yoshdog","id":5410975,"avatar_url":"https://avatars.githubusercontent.com/u/5410975?v=3","gravatar_id":"","url":"https://api.github.com/users/yoshdog","html_url":"https://github.com/yoshdog","followers_url":"https://api.github.com/users/yoshdog/followers","following_url":"https://api.github.com/users/yoshdog/following{/other_user}","gists_url":"https://api.github.com/users/yoshdog/gists{/gist_id}","starred_url":"https://api.github.com/users/yoshdog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoshdog/subscriptions","organizations_url":"https://api.github.com/users/yoshdog/orgs","repos_url":"https://api.github.com/users/yoshdog/repos","events_url":"https://api.github.com/users/yoshdog/events{/privacy}","received_events_url":"https://api.github.com/users/yoshdog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yoshdog/battle-ships","description":"","fork":false,"url":"https://api.github.com/repos/yoshdog/battle-ships","forks_url":"https://api.github.com/repos/yoshdog/battle-ships/forks","keys_url":"https://api.github.com/repos/yoshdog/battle-ships/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yoshdog/battle-ships/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yoshdog/battle-ships/teams","hooks_url":"https://api.github.com/repos/yoshdog/battle-ships/hooks","issue_events_url":"https://api.github.com/repos/yoshdog/battle-ships/issues/events{/number}","events_url":"https://api.github.com/repos/yoshdog/battle-ships/events","assignees_url":"https://api.github.com/repos/yoshdog/battle-ships/assignees{/user}","branches_url":"https://api.github.com/repos/yoshdog/battle-ships/branches{/branch}","tags_url":"https://api.github.com/repos/yoshdog/battle-ships/tags","blobs_url":"https://api.github.com/repos/yoshdog/battle-ships/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yoshdog/battle-ships/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yoshdog/battle-ships/git/refs{/sha}","trees_url":"https://api.github.com/repos/yoshdog/battle-ships/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yoshdog/battle-ships/statuses/{sha}","languages_url":"https://api.github.com/repos/yoshdog/battle-ships/languages","stargazers_url":"https://api.github.com/repos/yoshdog/battle-ships/stargazers","contributors_url":"https://api.github.com/repos/yoshdog/battle-ships/contributors","subscribers_url":"https://api.github.com/repos/yoshdog/battle-ships/subscribers","subscription_url":"https://api.github.com/repos/yoshdog/battle-ships/subscription","commits_url":"https://api.github.com/repos/yoshdog/battle-ships/commits{/sha}","git_commits_url":"https://api.github.com/repos/yoshdog/battle-ships/git/commits{/sha}","comments_url":"https://api.github.com/repos/yoshdog/battle-ships/comments{/number}","issue_comment_url":"https://api.github.com/repos/yoshdog/battle-ships/issues/comments{/number}","contents_url":"https://api.github.com/repos/yoshdog/battle-ships/contents/{+path}","compare_url":"https://api.github.com/repos/yoshdog/battle-ships/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yoshdog/battle-ships/merges","archive_url":"https://api.github.com/repos/yoshdog/battle-ships/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yoshdog/battle-ships/downloads","issues_url":"https://api.github.com/repos/yoshdog/battle-ships/issues{/number}","pulls_url":"https://api.github.com/repos/yoshdog/battle-ships/pulls{/number}","milestones_url":"https://api.github.com/repos/yoshdog/battle-ships/milestones{/number}","notifications_url":"https://api.github.com/repos/yoshdog/battle-ships/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yoshdog/battle-ships/labels{/name}","releases_url":"https://api.github.com/repos/yoshdog/battle-ships/releases{/id}","created_at":"2015-02-19T09:45:29Z","updated_at":"2015-02-23T11:11:18Z","pushed_at":"2015-02-23T11:11:28Z","git_url":"git://github.com/yoshdog/battle-ships.git","ssh_url":"git@github.com:yoshdog/battle-ships.git","clone_url":"https://github.com/yoshdog/battle-ships.git","svn_url":"https://github.com/yoshdog/battle-ships","homepage":null,"size":0,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yoshdog/battle-ships/pulls/1"},"html":{"href":"https://github.com/yoshdog/battle-ships/pull/1"},"issue":{"href":"https://api.github.com/repos/yoshdog/battle-ships/issues/1"},"comments":{"href":"https://api.github.com/repos/yoshdog/battle-ships/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/yoshdog/battle-ships/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/yoshdog/battle-ships/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yoshdog/battle-ships/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/yoshdog/battle-ships/statuses/3f635d296217d96eb8d08ec07eec25c1df0f88bc"}}}}