{"action":"created","comment":{"url":"https://api.github.com/repos/suitcss/components-grid/pulls/comments/43469240","id":43469240,"diff_hunk":"@@ -5,11 +5,12 @@\n <link rel=\"stylesheet\" href=\"../build/test.css\">\n <style>\n   .fixture-Box {\n-    background: rgb(100, 150, 50);\n-    background: rgb(100, 150, 50);\n-    border: 1px solid black;\n+    background: rgba(100, 150, 50, .75);\n+    border: 1px solid #888;\n+    font-family: sans-serif;\n     margin-bottom: 10px;","path":"test/index.html","position":10,"original_position":10,"commit_id":"fa2462d0dabe76084bd31b8269f1b0557bc4fb2f","original_commit_id":"fa2462d0dabe76084bd31b8269f1b0557bc4fb2f","user":{"login":"simonsmith","id":360703,"avatar_url":"https://avatars.githubusercontent.com/u/360703?v=3","gravatar_id":"","url":"https://api.github.com/users/simonsmith","html_url":"https://github.com/simonsmith","followers_url":"https://api.github.com/users/simonsmith/followers","following_url":"https://api.github.com/users/simonsmith/following{/other_user}","gists_url":"https://api.github.com/users/simonsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/simonsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonsmith/subscriptions","organizations_url":"https://api.github.com/users/simonsmith/orgs","repos_url":"https://api.github.com/users/simonsmith/repos","events_url":"https://api.github.com/users/simonsmith/events{/privacy}","received_events_url":"https://api.github.com/users/simonsmith/received_events","type":"User","site_admin":false},"body":"Yeah not sure on spacing as part of the grid. How do other ones handle this?\r\n\r\nI think this raises a wider issue I faced which is lack of a proper demo page for users. Like http://flexboxgrid.com/","created_at":"2015-10-30T03:36:35Z","updated_at":"2015-10-30T03:36:35Z","html_url":"https://github.com/suitcss/components-grid/pull/39#discussion_r43469240","pull_request_url":"https://api.github.com/repos/suitcss/components-grid/pulls/39","_links":{"self":{"href":"https://api.github.com/repos/suitcss/components-grid/pulls/comments/43469240"},"html":{"href":"https://github.com/suitcss/components-grid/pull/39#discussion_r43469240"},"pull_request":{"href":"https://api.github.com/repos/suitcss/components-grid/pulls/39"}}},"pull_request":{"url":"https://api.github.com/repos/suitcss/components-grid/pulls/39","id":49214547,"html_url":"https://github.com/suitcss/components-grid/pull/39","diff_url":"https://github.com/suitcss/components-grid/pull/39.diff","patch_url":"https://github.com/suitcss/components-grid/pull/39.patch","issue_url":"https://api.github.com/repos/suitcss/components-grid/issues/39","number":39,"state":"open","locked":false,"title":"Switch to flexbox","user":{"login":"simonsmith","id":360703,"avatar_url":"https://avatars.githubusercontent.com/u/360703?v=3","gravatar_id":"","url":"https://api.github.com/users/simonsmith","html_url":"https://github.com/simonsmith","followers_url":"https://api.github.com/users/simonsmith/followers","following_url":"https://api.github.com/users/simonsmith/following{/other_user}","gists_url":"https://api.github.com/users/simonsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/simonsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonsmith/subscriptions","organizations_url":"https://api.github.com/users/simonsmith/orgs","repos_url":"https://api.github.com/users/simonsmith/repos","events_url":"https://api.github.com/users/simonsmith/events{/privacy}","received_events_url":"https://api.github.com/users/simonsmith/received_events","type":"User","site_admin":false},"body":"This refactors the grid to use flexbox. The goal here was to keep the API the same so that it could be dropped into an existing site with the SUIT grid and everything work. This includes working with the other utilities where possible.\r\n\r\nHere are the tests with the flexbox version - https://dl.dropboxusercontent.com/u/1709558/suitcss-grid/index.html I've also added a couple new bits like `fix` and `equalHeight`. I was able to get the existing tests to match without making any changes to the markup, which was a plus. \r\n\r\nThis does depend on some changes that I've [made to utils-size](https://github.com/simonsmith/utils-size) as well. Namely losing the various `sizeFit` and `sizeFill` utils and adding `flex-basis` alongside `width`. The offset utils seem to work with no changes required.\r\n\r\nA further enhancement to this will be to create a utils-flexbox (https://github.com/suitcss/suit/issues/113) which would allow even more control over the grid with things like `order` and `align-content` etc.\r\n\r\nI'd suggest that this finally makes grid `1.0.0` and once users are ready to support flexbox they should be able to update their package and expect everything to work as normal.\r\n\r\n**Note:** This requires my utils-size changes to be merged as well. If everyone is happy with this route I will PR those as well. I forked both the repos because I need this Grid for my own project :)\r\n\r\n@timkelty @giuseppeg ","created_at":"2015-10-29T23:31:50Z","updated_at":"2015-10-30T03:36:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d970d8bbd5d182dd61bf0036727789f09f2f5bcc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/suitcss/components-grid/pulls/39/commits","review_comments_url":"https://api.github.com/repos/suitcss/components-grid/pulls/39/comments","review_comment_url":"https://api.github.com/repos/suitcss/components-grid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/suitcss/components-grid/issues/39/comments","statuses_url":"https://api.github.com/repos/suitcss/components-grid/statuses/fa2462d0dabe76084bd31b8269f1b0557bc4fb2f","head":{"label":"simonsmith:master","ref":"master","sha":"fa2462d0dabe76084bd31b8269f1b0557bc4fb2f","user":{"login":"simonsmith","id":360703,"avatar_url":"https://avatars.githubusercontent.com/u/360703?v=3","gravatar_id":"","url":"https://api.github.com/users/simonsmith","html_url":"https://github.com/simonsmith","followers_url":"https://api.github.com/users/simonsmith/followers","following_url":"https://api.github.com/users/simonsmith/following{/other_user}","gists_url":"https://api.github.com/users/simonsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/simonsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonsmith/subscriptions","organizations_url":"https://api.github.com/users/simonsmith/orgs","repos_url":"https://api.github.com/users/simonsmith/repos","events_url":"https://api.github.com/users/simonsmith/events{/privacy}","received_events_url":"https://api.github.com/users/simonsmith/received_events","type":"User","site_admin":false},"repo":{"id":45203731,"name":"components-grid","full_name":"simonsmith/components-grid","owner":{"login":"simonsmith","id":360703,"avatar_url":"https://avatars.githubusercontent.com/u/360703?v=3","gravatar_id":"","url":"https://api.github.com/users/simonsmith","html_url":"https://github.com/simonsmith","followers_url":"https://api.github.com/users/simonsmith/followers","following_url":"https://api.github.com/users/simonsmith/following{/other_user}","gists_url":"https://api.github.com/users/simonsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/simonsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonsmith/subscriptions","organizations_url":"https://api.github.com/users/simonsmith/orgs","repos_url":"https://api.github.com/users/simonsmith/repos","events_url":"https://api.github.com/users/simonsmith/events{/privacy}","received_events_url":"https://api.github.com/users/simonsmith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/simonsmith/components-grid","description":"Component CSS for grids","fork":true,"url":"https://api.github.com/repos/simonsmith/components-grid","forks_url":"https://api.github.com/repos/simonsmith/components-grid/forks","keys_url":"https://api.github.com/repos/simonsmith/components-grid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simonsmith/components-grid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simonsmith/components-grid/teams","hooks_url":"https://api.github.com/repos/simonsmith/components-grid/hooks","issue_events_url":"https://api.github.com/repos/simonsmith/components-grid/issues/events{/number}","events_url":"https://api.github.com/repos/simonsmith/components-grid/events","assignees_url":"https://api.github.com/repos/simonsmith/components-grid/assignees{/user}","branches_url":"https://api.github.com/repos/simonsmith/components-grid/branches{/branch}","tags_url":"https://api.github.com/repos/simonsmith/components-grid/tags","blobs_url":"https://api.github.com/repos/simonsmith/components-grid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simonsmith/components-grid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simonsmith/components-grid/git/refs{/sha}","trees_url":"https://api.github.com/repos/simonsmith/components-grid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simonsmith/components-grid/statuses/{sha}","languages_url":"https://api.github.com/repos/simonsmith/components-grid/languages","stargazers_url":"https://api.github.com/repos/simonsmith/components-grid/stargazers","contributors_url":"https://api.github.com/repos/simonsmith/components-grid/contributors","subscribers_url":"https://api.github.com/repos/simonsmith/components-grid/subscribers","subscription_url":"https://api.github.com/repos/simonsmith/components-grid/subscription","commits_url":"https://api.github.com/repos/simonsmith/components-grid/commits{/sha}","git_commits_url":"https://api.github.com/repos/simonsmith/components-grid/git/commits{/sha}","comments_url":"https://api.github.com/repos/simonsmith/components-grid/comments{/number}","issue_comment_url":"https://api.github.com/repos/simonsmith/components-grid/issues/comments{/number}","contents_url":"https://api.github.com/repos/simonsmith/components-grid/contents/{+path}","compare_url":"https://api.github.com/repos/simonsmith/components-grid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simonsmith/components-grid/merges","archive_url":"https://api.github.com/repos/simonsmith/components-grid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simonsmith/components-grid/downloads","issues_url":"https://api.github.com/repos/simonsmith/components-grid/issues{/number}","pulls_url":"https://api.github.com/repos/simonsmith/components-grid/pulls{/number}","milestones_url":"https://api.github.com/repos/simonsmith/components-grid/milestones{/number}","notifications_url":"https://api.github.com/repos/simonsmith/components-grid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simonsmith/components-grid/labels{/name}","releases_url":"https://api.github.com/repos/simonsmith/components-grid/releases{/id}","created_at":"2015-10-29T18:49:03Z","updated_at":"2015-10-29T18:49:05Z","pushed_at":"2015-10-29T23:45:40Z","git_url":"git://github.com/simonsmith/components-grid.git","ssh_url":"git@github.com:simonsmith/components-grid.git","clone_url":"https://github.com/simonsmith/components-grid.git","svn_url":"https://github.com/simonsmith/components-grid","homepage":"http://suitcss.github.io/components-grid/test/","size":152,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"suitcss:master","ref":"master","sha":"e34eddf0c608a8113f5e2e40bee24f4bd97e88ce","user":{"login":"suitcss","id":4564613,"avatar_url":"https://avatars.githubusercontent.com/u/4564613?v=3","gravatar_id":"","url":"https://api.github.com/users/suitcss","html_url":"https://github.com/suitcss","followers_url":"https://api.github.com/users/suitcss/followers","following_url":"https://api.github.com/users/suitcss/following{/other_user}","gists_url":"https://api.github.com/users/suitcss/gists{/gist_id}","starred_url":"https://api.github.com/users/suitcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suitcss/subscriptions","organizations_url":"https://api.github.com/users/suitcss/orgs","repos_url":"https://api.github.com/users/suitcss/repos","events_url":"https://api.github.com/users/suitcss/events{/privacy}","received_events_url":"https://api.github.com/users/suitcss/received_events","type":"Organization","site_admin":false},"repo":{"id":7767198,"name":"components-grid","full_name":"suitcss/components-grid","owner":{"login":"suitcss","id":4564613,"avatar_url":"https://avatars.githubusercontent.com/u/4564613?v=3","gravatar_id":"","url":"https://api.github.com/users/suitcss","html_url":"https://github.com/suitcss","followers_url":"https://api.github.com/users/suitcss/followers","following_url":"https://api.github.com/users/suitcss/following{/other_user}","gists_url":"https://api.github.com/users/suitcss/gists{/gist_id}","starred_url":"https://api.github.com/users/suitcss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suitcss/subscriptions","organizations_url":"https://api.github.com/users/suitcss/orgs","repos_url":"https://api.github.com/users/suitcss/repos","events_url":"https://api.github.com/users/suitcss/events{/privacy}","received_events_url":"https://api.github.com/users/suitcss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/suitcss/components-grid","description":"Component CSS for grids","fork":false,"url":"https://api.github.com/repos/suitcss/components-grid","forks_url":"https://api.github.com/repos/suitcss/components-grid/forks","keys_url":"https://api.github.com/repos/suitcss/components-grid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/suitcss/components-grid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/suitcss/components-grid/teams","hooks_url":"https://api.github.com/repos/suitcss/components-grid/hooks","issue_events_url":"https://api.github.com/repos/suitcss/components-grid/issues/events{/number}","events_url":"https://api.github.com/repos/suitcss/components-grid/events","assignees_url":"https://api.github.com/repos/suitcss/components-grid/assignees{/user}","branches_url":"https://api.github.com/repos/suitcss/components-grid/branches{/branch}","tags_url":"https://api.github.com/repos/suitcss/components-grid/tags","blobs_url":"https://api.github.com/repos/suitcss/components-grid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/suitcss/components-grid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/suitcss/components-grid/git/refs{/sha}","trees_url":"https://api.github.com/repos/suitcss/components-grid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/suitcss/components-grid/statuses/{sha}","languages_url":"https://api.github.com/repos/suitcss/components-grid/languages","stargazers_url":"https://api.github.com/repos/suitcss/components-grid/stargazers","contributors_url":"https://api.github.com/repos/suitcss/components-grid/contributors","subscribers_url":"https://api.github.com/repos/suitcss/components-grid/subscribers","subscription_url":"https://api.github.com/repos/suitcss/components-grid/subscription","commits_url":"https://api.github.com/repos/suitcss/components-grid/commits{/sha}","git_commits_url":"https://api.github.com/repos/suitcss/components-grid/git/commits{/sha}","comments_url":"https://api.github.com/repos/suitcss/components-grid/comments{/number}","issue_comment_url":"https://api.github.com/repos/suitcss/components-grid/issues/comments{/number}","contents_url":"https://api.github.com/repos/suitcss/components-grid/contents/{+path}","compare_url":"https://api.github.com/repos/suitcss/components-grid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/suitcss/components-grid/merges","archive_url":"https://api.github.com/repos/suitcss/components-grid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/suitcss/components-grid/downloads","issues_url":"https://api.github.com/repos/suitcss/components-grid/issues{/number}","pulls_url":"https://api.github.com/repos/suitcss/components-grid/pulls{/number}","milestones_url":"https://api.github.com/repos/suitcss/components-grid/milestones{/number}","notifications_url":"https://api.github.com/repos/suitcss/components-grid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/suitcss/components-grid/labels{/name}","releases_url":"https://api.github.com/repos/suitcss/components-grid/releases{/id}","created_at":"2013-01-23T03:46:41Z","updated_at":"2015-10-29T13:49:27Z","pushed_at":"2015-10-29T23:45:40Z","git_url":"git://github.com/suitcss/components-grid.git","ssh_url":"git@github.com:suitcss/components-grid.git","clone_url":"https://github.com/suitcss/components-grid.git","svn_url":"https://github.com/suitcss/components-grid","homepage":"http://suitcss.github.io/components-grid/test/","size":411,"stargazers_count":111,"watchers_count":111,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":20,"mirror_url":null,"open_issues_count":7,"forks":20,"open_issues":7,"watchers":111,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/suitcss/components-grid/pulls/39"},"html":{"href":"https://github.com/suitcss/components-grid/pull/39"},"issue":{"href":"https://api.github.com/repos/suitcss/components-grid/issues/39"},"comments":{"href":"https://api.github.com/repos/suitcss/components-grid/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/suitcss/components-grid/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/suitcss/components-grid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/suitcss/components-grid/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/suitcss/components-grid/statuses/fa2462d0dabe76084bd31b8269f1b0557bc4fb2f"}}}}