{"action":"created","issue":{"url":"https://api.github.com/repos/netty/netty/issues/4320","labels_url":"https://api.github.com/repos/netty/netty/issues/4320/labels{/name}","comments_url":"https://api.github.com/repos/netty/netty/issues/4320/comments","events_url":"https://api.github.com/repos/netty/netty/issues/4320/events","html_url":"https://github.com/netty/netty/pull/4320","id":110066739,"number":4320,"title":"Remove encoderEnforceMaxConcurrentStreams(...) as it ignored argument…","user":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars.githubusercontent.com/u/439362?v=3","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/netty/netty/labels/defect","name":"defect","color":"e11d21"}],"state":"open","locked":false,"assignee":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars.githubusercontent.com/u/439362?v=3","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/netty/netty/milestones/126","html_url":"https://github.com/netty/netty/milestones/4.1.0.RC1","labels_url":"https://api.github.com/repos/netty/netty/milestones/126/labels","id":1286123,"number":126,"title":"4.1.0.RC1","description":"","creator":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars.githubusercontent.com/u/439362?v=3","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"open_issues":67,"closed_issues":5,"state":"open","created_at":"2015-09-02T12:42:53Z","updated_at":"2015-10-06T18:08:08Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2015-10-06T18:08:03Z","updated_at":"2015-10-06T18:08:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/netty/netty/pulls/4320","html_url":"https://github.com/netty/netty/pull/4320","diff_url":"https://github.com/netty/netty/pull/4320.diff","patch_url":"https://github.com/netty/netty/pull/4320.patch"},"body":"… and is redundant.\r\n\r\nMotivation:\r\n\r\nRemove encoderEnforceMaxConcurrentStreams(...) as it ignored the argument and always disabled the enforcing. Beside this it is redundant with encoderMaxConcurrentStreams(...) which we can just adjust to let the user specifiy -1 to disable the enforcement.\r\n\r\nModifications:\r\n\r\n- Remove encoderEnforceMaxConcurrentStreams(...) method\r\n- Change encoderMaxConcurrentStreams(...) so the user can use -1 to disable it.\r\n\r\nResult:\r\n\r\nCorrectly behaving builder and less confusing."},"comment":{"url":"https://api.github.com/repos/netty/netty/issues/comments/145949248","html_url":"https://github.com/netty/netty/pull/4320#issuecomment-145949248","issue_url":"https://api.github.com/repos/netty/netty/issues/4320","id":145949248,"user":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars.githubusercontent.com/u/439362?v=3","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"created_at":"2015-10-06T18:08:19Z","updated_at":"2015-10-06T18:08:19Z","body":"@nmittler @Scottmitch PTAL"}}