{"action":"created","comment":{"url":"https://api.github.com/repos/ros-industrial-consortium/godel/pulls/comments/25021209","id":25021209,"diff_hunk":"@@ -11,7 +11,7 @@ find_package(catkin REQUIRED COMPONENTS\n )\n \n # c++11\n-ADD_DEFINITIONS(\"-std=c++0x\")\n+#ADD_DEFINITIONS(\"-std=c++0x\")","path":"godel_plugins/CMakeLists.txt","position":5,"original_position":5,"commit_id":"3e3919a9cc64142a76b438931d9e6e5dc73f9ac9","original_commit_id":"3e3919a9cc64142a76b438931d9e6e5dc73f9ac9","user":{"login":"jrgnicho","id":3279718,"avatar_url":"https://avatars.githubusercontent.com/u/3279718?v=3","gravatar_id":"","url":"https://api.github.com/users/jrgnicho","html_url":"https://github.com/jrgnicho","followers_url":"https://api.github.com/users/jrgnicho/followers","following_url":"https://api.github.com/users/jrgnicho/following{/other_user}","gists_url":"https://api.github.com/users/jrgnicho/gists{/gist_id}","starred_url":"https://api.github.com/users/jrgnicho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrgnicho/subscriptions","organizations_url":"https://api.github.com/users/jrgnicho/orgs","repos_url":"https://api.github.com/users/jrgnicho/repos","events_url":"https://api.github.com/users/jrgnicho/events{/privacy}","received_events_url":"https://api.github.com/users/jrgnicho/received_events","type":"User","site_admin":false},"body":"I don't see why keep it there then.  Let's remove it for now.","created_at":"2015-02-19T20:16:39Z","updated_at":"2015-02-19T20:16:39Z","html_url":"https://github.com/ros-industrial-consortium/godel/pull/40#discussion_r25021209","pull_request_url":"https://api.github.com/repos/ros-industrial-consortium/godel/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/ros-industrial-consortium/godel/pulls/comments/25021209"},"html":{"href":"https://github.com/ros-industrial-consortium/godel/pull/40#discussion_r25021209"},"pull_request":{"href":"https://api.github.com/repos/ros-industrial-consortium/godel/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/ros-industrial-consortium/godel/pulls/40","id":29230761,"html_url":"https://github.com/ros-industrial-consortium/godel/pull/40","diff_url":"https://github.com/ros-industrial-consortium/godel/pull/40.diff","patch_url":"https://github.com/ros-industrial-consortium/godel/pull/40.patch","issue_url":"https://api.github.com/repos/ros-industrial-consortium/godel/issues/40","number":40,"state":"open","locked":false,"title":"Surface Meshing Simplification","user":{"login":"Jmeyer1292","id":4960180,"avatar_url":"https://avatars.githubusercontent.com/u/4960180?v=3","gravatar_id":"","url":"https://api.github.com/users/Jmeyer1292","html_url":"https://github.com/Jmeyer1292","followers_url":"https://api.github.com/users/Jmeyer1292/followers","following_url":"https://api.github.com/users/Jmeyer1292/following{/other_user}","gists_url":"https://api.github.com/users/Jmeyer1292/gists{/gist_id}","starred_url":"https://api.github.com/users/Jmeyer1292/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jmeyer1292/subscriptions","organizations_url":"https://api.github.com/users/Jmeyer1292/orgs","repos_url":"https://api.github.com/users/Jmeyer1292/repos","events_url":"https://api.github.com/users/Jmeyer1292/events{/privacy}","received_events_url":"https://api.github.com/users/Jmeyer1292/received_events","type":"User","site_admin":false},"body":"This pull request is under active development. Please do not merge. I just want it out there for review.\r\n\r\nThis pull request changes the method of (mesh) triangulation used for surfaces. Once planes of interest are identified, points belonging to them are reprojected onto the plane, the concave hull of all of them is taken, and that is meshed using the ear clipping algorithm. \r\n\r\nThis appears to screw up something with normal calculations stored inside the mesh point cloud, so I (dangerously) disabled the check. For the test cases, I've used it still seems to function fine and the plane normals are re-calculated anyway.\r\n\r\nThanks for your patience. ","created_at":"2015-02-13T00:35:22Z","updated_at":"2015-02-19T20:16:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"553a1fd76458b15417a3e621b81d06fdc7d3c76d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ros-industrial-consortium/godel/pulls/40/commits","review_comments_url":"https://api.github.com/repos/ros-industrial-consortium/godel/pulls/40/comments","review_comment_url":"https://api.github.com/repos/ros-industrial-consortium/godel/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ros-industrial-consortium/godel/issues/40/comments","statuses_url":"https://api.github.com/repos/ros-industrial-consortium/godel/statuses/3e3919a9cc64142a76b438931d9e6e5dc73f9ac9","head":{"label":"Jmeyer1292:surface_mesh_issue","ref":"surface_mesh_issue","sha":"3e3919a9cc64142a76b438931d9e6e5dc73f9ac9","user":{"login":"Jmeyer1292","id":4960180,"avatar_url":"https://avatars.githubusercontent.com/u/4960180?v=3","gravatar_id":"","url":"https://api.github.com/users/Jmeyer1292","html_url":"https://github.com/Jmeyer1292","followers_url":"https://api.github.com/users/Jmeyer1292/followers","following_url":"https://api.github.com/users/Jmeyer1292/following{/other_user}","gists_url":"https://api.github.com/users/Jmeyer1292/gists{/gist_id}","starred_url":"https://api.github.com/users/Jmeyer1292/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jmeyer1292/subscriptions","organizations_url":"https://api.github.com/users/Jmeyer1292/orgs","repos_url":"https://api.github.com/users/Jmeyer1292/repos","events_url":"https://api.github.com/users/Jmeyer1292/events{/privacy}","received_events_url":"https://api.github.com/users/Jmeyer1292/received_events","type":"User","site_admin":false},"repo":{"id":30308164,"name":"godel","full_name":"Jmeyer1292/godel","owner":{"login":"Jmeyer1292","id":4960180,"avatar_url":"https://avatars.githubusercontent.com/u/4960180?v=3","gravatar_id":"","url":"https://api.github.com/users/Jmeyer1292","html_url":"https://github.com/Jmeyer1292","followers_url":"https://api.github.com/users/Jmeyer1292/followers","following_url":"https://api.github.com/users/Jmeyer1292/following{/other_user}","gists_url":"https://api.github.com/users/Jmeyer1292/gists{/gist_id}","starred_url":"https://api.github.com/users/Jmeyer1292/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jmeyer1292/subscriptions","organizations_url":"https://api.github.com/users/Jmeyer1292/orgs","repos_url":"https://api.github.com/users/Jmeyer1292/repos","events_url":"https://api.github.com/users/Jmeyer1292/events{/privacy}","received_events_url":"https://api.github.com/users/Jmeyer1292/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Jmeyer1292/godel","description":"ROS-Industrial Focused Technical Project: Robotic Blending","fork":true,"url":"https://api.github.com/repos/Jmeyer1292/godel","forks_url":"https://api.github.com/repos/Jmeyer1292/godel/forks","keys_url":"https://api.github.com/repos/Jmeyer1292/godel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jmeyer1292/godel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jmeyer1292/godel/teams","hooks_url":"https://api.github.com/repos/Jmeyer1292/godel/hooks","issue_events_url":"https://api.github.com/repos/Jmeyer1292/godel/issues/events{/number}","events_url":"https://api.github.com/repos/Jmeyer1292/godel/events","assignees_url":"https://api.github.com/repos/Jmeyer1292/godel/assignees{/user}","branches_url":"https://api.github.com/repos/Jmeyer1292/godel/branches{/branch}","tags_url":"https://api.github.com/repos/Jmeyer1292/godel/tags","blobs_url":"https://api.github.com/repos/Jmeyer1292/godel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jmeyer1292/godel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jmeyer1292/godel/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jmeyer1292/godel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jmeyer1292/godel/statuses/{sha}","languages_url":"https://api.github.com/repos/Jmeyer1292/godel/languages","stargazers_url":"https://api.github.com/repos/Jmeyer1292/godel/stargazers","contributors_url":"https://api.github.com/repos/Jmeyer1292/godel/contributors","subscribers_url":"https://api.github.com/repos/Jmeyer1292/godel/subscribers","subscription_url":"https://api.github.com/repos/Jmeyer1292/godel/subscription","commits_url":"https://api.github.com/repos/Jmeyer1292/godel/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jmeyer1292/godel/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jmeyer1292/godel/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jmeyer1292/godel/issues/comments/{number}","contents_url":"https://api.github.com/repos/Jmeyer1292/godel/contents/{+path}","compare_url":"https://api.github.com/repos/Jmeyer1292/godel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jmeyer1292/godel/merges","archive_url":"https://api.github.com/repos/Jmeyer1292/godel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jmeyer1292/godel/downloads","issues_url":"https://api.github.com/repos/Jmeyer1292/godel/issues{/number}","pulls_url":"https://api.github.com/repos/Jmeyer1292/godel/pulls{/number}","milestones_url":"https://api.github.com/repos/Jmeyer1292/godel/milestones{/number}","notifications_url":"https://api.github.com/repos/Jmeyer1292/godel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jmeyer1292/godel/labels{/name}","releases_url":"https://api.github.com/repos/Jmeyer1292/godel/releases{/id}","created_at":"2015-02-04T16:20:33Z","updated_at":"2015-02-04T16:20:34Z","pushed_at":"2015-02-19T17:21:09Z","git_url":"git://github.com/Jmeyer1292/godel.git","ssh_url":"git@github.com:Jmeyer1292/godel.git","clone_url":"https://github.com/Jmeyer1292/godel.git","svn_url":"https://github.com/Jmeyer1292/godel","homepage":"","size":14559,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"hydro-devel"}},"base":{"label":"ros-industrial-consortium:hydro-devel","ref":"hydro-devel","sha":"ffa694e2caa15c870c98cdc34c9668cea914521e","user":{"login":"ros-industrial-consortium","id":6336074,"avatar_url":"https://avatars.githubusercontent.com/u/6336074?v=3","gravatar_id":"","url":"https://api.github.com/users/ros-industrial-consortium","html_url":"https://github.com/ros-industrial-consortium","followers_url":"https://api.github.com/users/ros-industrial-consortium/followers","following_url":"https://api.github.com/users/ros-industrial-consortium/following{/other_user}","gists_url":"https://api.github.com/users/ros-industrial-consortium/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-industrial-consortium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-industrial-consortium/subscriptions","organizations_url":"https://api.github.com/users/ros-industrial-consortium/orgs","repos_url":"https://api.github.com/users/ros-industrial-consortium/repos","events_url":"https://api.github.com/users/ros-industrial-consortium/events{/privacy}","received_events_url":"https://api.github.com/users/ros-industrial-consortium/received_events","type":"Organization","site_admin":false},"repo":{"id":17028696,"name":"godel","full_name":"ros-industrial-consortium/godel","owner":{"login":"ros-industrial-consortium","id":6336074,"avatar_url":"https://avatars.githubusercontent.com/u/6336074?v=3","gravatar_id":"","url":"https://api.github.com/users/ros-industrial-consortium","html_url":"https://github.com/ros-industrial-consortium","followers_url":"https://api.github.com/users/ros-industrial-consortium/followers","following_url":"https://api.github.com/users/ros-industrial-consortium/following{/other_user}","gists_url":"https://api.github.com/users/ros-industrial-consortium/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-industrial-consortium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-industrial-consortium/subscriptions","organizations_url":"https://api.github.com/users/ros-industrial-consortium/orgs","repos_url":"https://api.github.com/users/ros-industrial-consortium/repos","events_url":"https://api.github.com/users/ros-industrial-consortium/events{/privacy}","received_events_url":"https://api.github.com/users/ros-industrial-consortium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros-industrial-consortium/godel","description":"ROS-Industrial Focused Technical Project: Robotic Blending","fork":false,"url":"https://api.github.com/repos/ros-industrial-consortium/godel","forks_url":"https://api.github.com/repos/ros-industrial-consortium/godel/forks","keys_url":"https://api.github.com/repos/ros-industrial-consortium/godel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros-industrial-consortium/godel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros-industrial-consortium/godel/teams","hooks_url":"https://api.github.com/repos/ros-industrial-consortium/godel/hooks","issue_events_url":"https://api.github.com/repos/ros-industrial-consortium/godel/issues/events{/number}","events_url":"https://api.github.com/repos/ros-industrial-consortium/godel/events","assignees_url":"https://api.github.com/repos/ros-industrial-consortium/godel/assignees{/user}","branches_url":"https://api.github.com/repos/ros-industrial-consortium/godel/branches{/branch}","tags_url":"https://api.github.com/repos/ros-industrial-consortium/godel/tags","blobs_url":"https://api.github.com/repos/ros-industrial-consortium/godel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros-industrial-consortium/godel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros-industrial-consortium/godel/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros-industrial-consortium/godel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros-industrial-consortium/godel/statuses/{sha}","languages_url":"https://api.github.com/repos/ros-industrial-consortium/godel/languages","stargazers_url":"https://api.github.com/repos/ros-industrial-consortium/godel/stargazers","contributors_url":"https://api.github.com/repos/ros-industrial-consortium/godel/contributors","subscribers_url":"https://api.github.com/repos/ros-industrial-consortium/godel/subscribers","subscription_url":"https://api.github.com/repos/ros-industrial-consortium/godel/subscription","commits_url":"https://api.github.com/repos/ros-industrial-consortium/godel/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros-industrial-consortium/godel/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros-industrial-consortium/godel/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros-industrial-consortium/godel/issues/comments/{number}","contents_url":"https://api.github.com/repos/ros-industrial-consortium/godel/contents/{+path}","compare_url":"https://api.github.com/repos/ros-industrial-consortium/godel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros-industrial-consortium/godel/merges","archive_url":"https://api.github.com/repos/ros-industrial-consortium/godel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros-industrial-consortium/godel/downloads","issues_url":"https://api.github.com/repos/ros-industrial-consortium/godel/issues{/number}","pulls_url":"https://api.github.com/repos/ros-industrial-consortium/godel/pulls{/number}","milestones_url":"https://api.github.com/repos/ros-industrial-consortium/godel/milestones{/number}","notifications_url":"https://api.github.com/repos/ros-industrial-consortium/godel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros-industrial-consortium/godel/labels{/name}","releases_url":"https://api.github.com/repos/ros-industrial-consortium/godel/releases{/id}","created_at":"2014-02-20T17:20:25Z","updated_at":"2015-02-19T00:27:50Z","pushed_at":"2015-02-19T00:27:50Z","git_url":"git://github.com/ros-industrial-consortium/godel.git","ssh_url":"git@github.com:ros-industrial-consortium/godel.git","clone_url":"https://github.com/ros-industrial-consortium/godel.git","svn_url":"https://github.com/ros-industrial-consortium/godel","homepage":"","size":14792,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":9,"forks":7,"open_issues":9,"watchers":0,"default_branch":"hydro-devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ros-industrial-consortium/godel/pulls/40"},"html":{"href":"https://github.com/ros-industrial-consortium/godel/pull/40"},"issue":{"href":"https://api.github.com/repos/ros-industrial-consortium/godel/issues/40"},"comments":{"href":"https://api.github.com/repos/ros-industrial-consortium/godel/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/ros-industrial-consortium/godel/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/ros-industrial-consortium/godel/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ros-industrial-consortium/godel/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/ros-industrial-consortium/godel/statuses/3e3919a9cc64142a76b438931d9e6e5dc73f9ac9"}}}}