{"action":"created","comment":{"url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/pulls/comments/43935232","id":43935232,"diff_hunk":"@@ -3,7 +3,7 @@\n var BufferStreams = require('bufferstreams');\n var htmlmin = require('html-minifier');\n var gutil = require('gulp-util');\n-var objectAssign = require('object-assign');","path":"index.js","position":4,"original_position":4,"commit_id":"1681ac0c885f3dfb5e71dca2f0c9cb985c57c433","original_commit_id":"1681ac0c885f3dfb5e71dca2f0c9cb985c57c433","user":{"login":"jonschlinkert","id":383994,"avatar_url":"https://avatars.githubusercontent.com/u/383994?v=3","gravatar_id":"","url":"https://api.github.com/users/jonschlinkert","html_url":"https://github.com/jonschlinkert","followers_url":"https://api.github.com/users/jonschlinkert/followers","following_url":"https://api.github.com/users/jonschlinkert/following{/other_user}","gists_url":"https://api.github.com/users/jonschlinkert/gists{/gist_id}","starred_url":"https://api.github.com/users/jonschlinkert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonschlinkert/subscriptions","organizations_url":"https://api.github.com/users/jonschlinkert/orgs","repos_url":"https://api.github.com/users/jonschlinkert/repos","events_url":"https://api.github.com/users/jonschlinkert/events{/privacy}","received_events_url":"https://api.github.com/users/jonschlinkert/received_events","type":"User","site_admin":false},"body":"> I'd like to ask you when you use gulp-html without gulp, or even vinyl-fs.\r\n\r\nI've never actually used this with gulp. I use gulp for linting and tests, but I use this plugin with assemble, which uses vinyl since we'd like to be supportive of common APIs and plugin signatures. Assemble's community also uses this plugin. I use this plugin, and in the majority of cases extend-shallow will be in my dependency tree when using this. \r\n\r\n> No. As its name suggests\r\n\r\nSounds like you misunderstood, so I'll try to clarify. Seems like you're perspective is based on your gulp toolchain, my isn't. There is no case in which gulp is not a `devDependency` in my projects. My decisions regarding dependencies are entirely predicated on what makes sense for the actual application. I don't waste any time over trying to optimize the `devDependency` tree. \r\n\r\nregarding your point about npm optimizing deps: \r\n\r\n- for object-assign specifically to provide any negligible advantage to support what you're saying, the user would need to be using both npm 3 and gulp 4.\r\n- if different versions of object-assign are in different deps, then both versions will be installed. same result as if it was two completely different libs.\r\n","created_at":"2015-11-04T20:31:48Z","updated_at":"2015-11-04T20:31:48Z","html_url":"https://github.com/jonschlinkert/gulp-htmlmin/pull/27#discussion_r43935232","pull_request_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/pulls/comments/43935232"},"html":{"href":"https://github.com/jonschlinkert/gulp-htmlmin/pull/27#discussion_r43935232"},"pull_request":{"href":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/pulls/27","id":49355488,"html_url":"https://github.com/jonschlinkert/gulp-htmlmin/pull/27","diff_url":"https://github.com/jonschlinkert/gulp-htmlmin/pull/27.diff","patch_url":"https://github.com/jonschlinkert/gulp-htmlmin/pull/27.patch","issue_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/issues/27","number":27,"state":"open","locked":false,"title":"mostly a \"housekeeping\" patch. ","user":{"login":"jonschlinkert","id":383994,"avatar_url":"https://avatars.githubusercontent.com/u/383994?v=3","gravatar_id":"","url":"https://api.github.com/users/jonschlinkert","html_url":"https://github.com/jonschlinkert","followers_url":"https://api.github.com/users/jonschlinkert/followers","following_url":"https://api.github.com/users/jonschlinkert/following{/other_user}","gists_url":"https://api.github.com/users/jonschlinkert/gists{/gist_id}","starred_url":"https://api.github.com/users/jonschlinkert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonschlinkert/subscriptions","organizations_url":"https://api.github.com/users/jonschlinkert/orgs","repos_url":"https://api.github.com/users/jonschlinkert/repos","events_url":"https://api.github.com/users/jonschlinkert/events{/privacy}","received_events_url":"https://api.github.com/users/jonschlinkert/received_events","type":"User","site_admin":false},"body":"@shinnn these are mostly cosmetic, sorry about the big metadata changes, getting ready for end-of-year :)\r\n\r\nfwiw I'm use a linting/updater tool that does all of the formatting automatically based on my settings. this should only need to happen once ideally. if you're okay with these changes feel free to merge/publish or I can if you want.","created_at":"2015-10-31T18:28:11Z","updated_at":"2015-11-04T20:31:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5094a12627a945c340b2c04c58631f630eb85308","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/pulls/27/commits","review_comments_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/pulls/27/comments","review_comment_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/issues/27/comments","statuses_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/statuses/1681ac0c885f3dfb5e71dca2f0c9cb985c57c433","head":{"label":"jonschlinkert:1.3.1","ref":"1.3.1","sha":"1681ac0c885f3dfb5e71dca2f0c9cb985c57c433","user":{"login":"jonschlinkert","id":383994,"avatar_url":"https://avatars.githubusercontent.com/u/383994?v=3","gravatar_id":"","url":"https://api.github.com/users/jonschlinkert","html_url":"https://github.com/jonschlinkert","followers_url":"https://api.github.com/users/jonschlinkert/followers","following_url":"https://api.github.com/users/jonschlinkert/following{/other_user}","gists_url":"https://api.github.com/users/jonschlinkert/gists{/gist_id}","starred_url":"https://api.github.com/users/jonschlinkert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonschlinkert/subscriptions","organizations_url":"https://api.github.com/users/jonschlinkert/orgs","repos_url":"https://api.github.com/users/jonschlinkert/repos","events_url":"https://api.github.com/users/jonschlinkert/events{/privacy}","received_events_url":"https://api.github.com/users/jonschlinkert/received_events","type":"User","site_admin":false},"repo":{"id":15343567,"name":"gulp-htmlmin","full_name":"jonschlinkert/gulp-htmlmin","owner":{"login":"jonschlinkert","id":383994,"avatar_url":"https://avatars.githubusercontent.com/u/383994?v=3","gravatar_id":"","url":"https://api.github.com/users/jonschlinkert","html_url":"https://github.com/jonschlinkert","followers_url":"https://api.github.com/users/jonschlinkert/followers","following_url":"https://api.github.com/users/jonschlinkert/following{/other_user}","gists_url":"https://api.github.com/users/jonschlinkert/gists{/gist_id}","starred_url":"https://api.github.com/users/jonschlinkert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonschlinkert/subscriptions","organizations_url":"https://api.github.com/users/jonschlinkert/orgs","repos_url":"https://api.github.com/users/jonschlinkert/repos","events_url":"https://api.github.com/users/jonschlinkert/events{/privacy}","received_events_url":"https://api.github.com/users/jonschlinkert/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonschlinkert/gulp-htmlmin","description":"Minify HTML","fork":false,"url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin","forks_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/forks","keys_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/teams","hooks_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/hooks","issue_events_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/issues/events{/number}","events_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/events","assignees_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/assignees{/user}","branches_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/branches{/branch}","tags_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/tags","blobs_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/statuses/{sha}","languages_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/languages","stargazers_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/stargazers","contributors_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/contributors","subscribers_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/subscribers","subscription_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/subscription","commits_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/contents/{+path}","compare_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/merges","archive_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/downloads","issues_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/issues{/number}","pulls_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/pulls{/number}","milestones_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/milestones{/number}","notifications_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/labels{/name}","releases_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/releases{/id}","created_at":"2013-12-20T16:55:23Z","updated_at":"2015-11-04T01:56:44Z","pushed_at":"2015-10-31T18:28:11Z","git_url":"git://github.com/jonschlinkert/gulp-htmlmin.git","ssh_url":"git@github.com:jonschlinkert/gulp-htmlmin.git","clone_url":"https://github.com/jonschlinkert/gulp-htmlmin.git","svn_url":"https://github.com/jonschlinkert/gulp-htmlmin","homepage":"https://github.com/jonschlinkert","size":295,"stargazers_count":167,"watchers_count":167,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":2,"forks":15,"open_issues":2,"watchers":167,"default_branch":"master"}},"base":{"label":"jonschlinkert:master","ref":"master","sha":"69891209c91682beb8a2a05231103ef031c36792","user":{"login":"jonschlinkert","id":383994,"avatar_url":"https://avatars.githubusercontent.com/u/383994?v=3","gravatar_id":"","url":"https://api.github.com/users/jonschlinkert","html_url":"https://github.com/jonschlinkert","followers_url":"https://api.github.com/users/jonschlinkert/followers","following_url":"https://api.github.com/users/jonschlinkert/following{/other_user}","gists_url":"https://api.github.com/users/jonschlinkert/gists{/gist_id}","starred_url":"https://api.github.com/users/jonschlinkert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonschlinkert/subscriptions","organizations_url":"https://api.github.com/users/jonschlinkert/orgs","repos_url":"https://api.github.com/users/jonschlinkert/repos","events_url":"https://api.github.com/users/jonschlinkert/events{/privacy}","received_events_url":"https://api.github.com/users/jonschlinkert/received_events","type":"User","site_admin":false},"repo":{"id":15343567,"name":"gulp-htmlmin","full_name":"jonschlinkert/gulp-htmlmin","owner":{"login":"jonschlinkert","id":383994,"avatar_url":"https://avatars.githubusercontent.com/u/383994?v=3","gravatar_id":"","url":"https://api.github.com/users/jonschlinkert","html_url":"https://github.com/jonschlinkert","followers_url":"https://api.github.com/users/jonschlinkert/followers","following_url":"https://api.github.com/users/jonschlinkert/following{/other_user}","gists_url":"https://api.github.com/users/jonschlinkert/gists{/gist_id}","starred_url":"https://api.github.com/users/jonschlinkert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonschlinkert/subscriptions","organizations_url":"https://api.github.com/users/jonschlinkert/orgs","repos_url":"https://api.github.com/users/jonschlinkert/repos","events_url":"https://api.github.com/users/jonschlinkert/events{/privacy}","received_events_url":"https://api.github.com/users/jonschlinkert/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonschlinkert/gulp-htmlmin","description":"Minify HTML","fork":false,"url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin","forks_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/forks","keys_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/teams","hooks_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/hooks","issue_events_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/issues/events{/number}","events_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/events","assignees_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/assignees{/user}","branches_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/branches{/branch}","tags_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/tags","blobs_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/statuses/{sha}","languages_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/languages","stargazers_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/stargazers","contributors_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/contributors","subscribers_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/subscribers","subscription_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/subscription","commits_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/contents/{+path}","compare_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/merges","archive_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/downloads","issues_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/issues{/number}","pulls_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/pulls{/number}","milestones_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/milestones{/number}","notifications_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/labels{/name}","releases_url":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/releases{/id}","created_at":"2013-12-20T16:55:23Z","updated_at":"2015-11-04T01:56:44Z","pushed_at":"2015-10-31T18:28:11Z","git_url":"git://github.com/jonschlinkert/gulp-htmlmin.git","ssh_url":"git@github.com:jonschlinkert/gulp-htmlmin.git","clone_url":"https://github.com/jonschlinkert/gulp-htmlmin.git","svn_url":"https://github.com/jonschlinkert/gulp-htmlmin","homepage":"https://github.com/jonschlinkert","size":295,"stargazers_count":167,"watchers_count":167,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":2,"forks":15,"open_issues":2,"watchers":167,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/pulls/27"},"html":{"href":"https://github.com/jonschlinkert/gulp-htmlmin/pull/27"},"issue":{"href":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/issues/27"},"comments":{"href":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/jonschlinkert/gulp-htmlmin/statuses/1681ac0c885f3dfb5e71dca2f0c9cb985c57c433"}}}}