{"action":"closed","number":385,"pull_request":{"url":"https://api.github.com/repos/apache/trafficserver/pulls/385","id":53936917,"html_url":"https://github.com/apache/trafficserver/pull/385","diff_url":"https://github.com/apache/trafficserver/pull/385.diff","patch_url":"https://github.com/apache/trafficserver/pull/385.patch","issue_url":"https://api.github.com/repos/apache/trafficserver/issues/385","number":385,"state":"closed","locked":false,"title":"TS-3944: Add documentation for TSHttpTxnServerAddrSet to clarify when it can be called.","user":{"login":"SolidWallOfCode","id":1545753,"avatar_url":"https://avatars.githubusercontent.com/u/1545753?v=3","gravatar_id":"","url":"https://api.github.com/users/SolidWallOfCode","html_url":"https://github.com/SolidWallOfCode","followers_url":"https://api.github.com/users/SolidWallOfCode/followers","following_url":"https://api.github.com/users/SolidWallOfCode/following{/other_user}","gists_url":"https://api.github.com/users/SolidWallOfCode/gists{/gist_id}","starred_url":"https://api.github.com/users/SolidWallOfCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SolidWallOfCode/subscriptions","organizations_url":"https://api.github.com/users/SolidWallOfCode/orgs","repos_url":"https://api.github.com/users/SolidWallOfCode/repos","events_url":"https://api.github.com/users/SolidWallOfCode/events{/privacy}","received_events_url":"https://api.github.com/users/SolidWallOfCode/received_events","type":"User","site_admin":false},"body":"I cannot find any current documentation on this function and so the use is unclear. Documenting it means we can make clear that it must be called sufficiently early in the transaction to be effective.","created_at":"2015-12-17T05:42:39Z","updated_at":"2015-12-17T23:02:36Z","closed_at":"2015-12-17T23:02:36Z","merged_at":null,"merge_commit_sha":"2f7cceac46a6ae19a991b15e09fa7d65742a5494","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/trafficserver/pulls/385/commits","review_comments_url":"https://api.github.com/repos/apache/trafficserver/pulls/385/comments","review_comment_url":"https://api.github.com/repos/apache/trafficserver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/trafficserver/issues/385/comments","statuses_url":"https://api.github.com/repos/apache/trafficserver/statuses/120ec90d16637b6867206c0a151be25fcbe466fe","head":{"label":"SolidWallOfCode:TS-3944","ref":"TS-3944","sha":"120ec90d16637b6867206c0a151be25fcbe466fe","user":{"login":"SolidWallOfCode","id":1545753,"avatar_url":"https://avatars.githubusercontent.com/u/1545753?v=3","gravatar_id":"","url":"https://api.github.com/users/SolidWallOfCode","html_url":"https://github.com/SolidWallOfCode","followers_url":"https://api.github.com/users/SolidWallOfCode/followers","following_url":"https://api.github.com/users/SolidWallOfCode/following{/other_user}","gists_url":"https://api.github.com/users/SolidWallOfCode/gists{/gist_id}","starred_url":"https://api.github.com/users/SolidWallOfCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SolidWallOfCode/subscriptions","organizations_url":"https://api.github.com/users/SolidWallOfCode/orgs","repos_url":"https://api.github.com/users/SolidWallOfCode/repos","events_url":"https://api.github.com/users/SolidWallOfCode/events{/privacy}","received_events_url":"https://api.github.com/users/SolidWallOfCode/received_events","type":"User","site_admin":false},"repo":{"id":3744058,"name":"trafficserver","full_name":"SolidWallOfCode/trafficserver","owner":{"login":"SolidWallOfCode","id":1545753,"avatar_url":"https://avatars.githubusercontent.com/u/1545753?v=3","gravatar_id":"","url":"https://api.github.com/users/SolidWallOfCode","html_url":"https://github.com/SolidWallOfCode","followers_url":"https://api.github.com/users/SolidWallOfCode/followers","following_url":"https://api.github.com/users/SolidWallOfCode/following{/other_user}","gists_url":"https://api.github.com/users/SolidWallOfCode/gists{/gist_id}","starred_url":"https://api.github.com/users/SolidWallOfCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SolidWallOfCode/subscriptions","organizations_url":"https://api.github.com/users/SolidWallOfCode/orgs","repos_url":"https://api.github.com/users/SolidWallOfCode/repos","events_url":"https://api.github.com/users/SolidWallOfCode/events{/privacy}","received_events_url":"https://api.github.com/users/SolidWallOfCode/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SolidWallOfCode/trafficserver","description":"Mirror of Apache Traffic Server","fork":true,"url":"https://api.github.com/repos/SolidWallOfCode/trafficserver","forks_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/forks","keys_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/teams","hooks_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/hooks","issue_events_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/issues/events{/number}","events_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/events","assignees_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/assignees{/user}","branches_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/branches{/branch}","tags_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/tags","blobs_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/statuses/{sha}","languages_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/languages","stargazers_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/stargazers","contributors_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/contributors","subscribers_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/subscribers","subscription_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/subscription","commits_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/contents/{+path}","compare_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/merges","archive_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/downloads","issues_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/issues{/number}","pulls_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/pulls{/number}","milestones_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/milestones{/number}","notifications_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/labels{/name}","releases_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/releases{/id}","created_at":"2012-03-16T23:25:24Z","updated_at":"2015-05-06T19:22:33Z","pushed_at":"2015-12-17T05:41:03Z","git_url":"git://github.com/SolidWallOfCode/trafficserver.git","ssh_url":"git@github.com:SolidWallOfCode/trafficserver.git","clone_url":"https://github.com/SolidWallOfCode/trafficserver.git","svn_url":"https://github.com/SolidWallOfCode/trafficserver","homepage":null,"size":51112,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"9fe75036e069f191ed18fb8ac4fd749a49635d87","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":356066,"name":"trafficserver","full_name":"apache/trafficserver","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/trafficserver","description":"Mirror of Apache Traffic Server","fork":false,"url":"https://api.github.com/repos/apache/trafficserver","forks_url":"https://api.github.com/repos/apache/trafficserver/forks","keys_url":"https://api.github.com/repos/apache/trafficserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/trafficserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/trafficserver/teams","hooks_url":"https://api.github.com/repos/apache/trafficserver/hooks","issue_events_url":"https://api.github.com/repos/apache/trafficserver/issues/events{/number}","events_url":"https://api.github.com/repos/apache/trafficserver/events","assignees_url":"https://api.github.com/repos/apache/trafficserver/assignees{/user}","branches_url":"https://api.github.com/repos/apache/trafficserver/branches{/branch}","tags_url":"https://api.github.com/repos/apache/trafficserver/tags","blobs_url":"https://api.github.com/repos/apache/trafficserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/trafficserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/trafficserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/trafficserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/trafficserver/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/trafficserver/languages","stargazers_url":"https://api.github.com/repos/apache/trafficserver/stargazers","contributors_url":"https://api.github.com/repos/apache/trafficserver/contributors","subscribers_url":"https://api.github.com/repos/apache/trafficserver/subscribers","subscription_url":"https://api.github.com/repos/apache/trafficserver/subscription","commits_url":"https://api.github.com/repos/apache/trafficserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/trafficserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/trafficserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/trafficserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/trafficserver/contents/{+path}","compare_url":"https://api.github.com/repos/apache/trafficserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/trafficserver/merges","archive_url":"https://api.github.com/repos/apache/trafficserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/trafficserver/downloads","issues_url":"https://api.github.com/repos/apache/trafficserver/issues{/number}","pulls_url":"https://api.github.com/repos/apache/trafficserver/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/trafficserver/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/trafficserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/trafficserver/labels{/name}","releases_url":"https://api.github.com/repos/apache/trafficserver/releases{/id}","created_at":"2009-10-31T08:00:10Z","updated_at":"2015-12-17T22:37:55Z","pushed_at":"2015-12-17T23:02:34Z","git_url":"git://github.com/apache/trafficserver.git","ssh_url":"git@github.com:apache/trafficserver.git","clone_url":"https://github.com/apache/trafficserver.git","svn_url":"https://github.com/apache/trafficserver","homepage":null,"size":54274,"stargazers_count":349,"watchers_count":349,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":261,"mirror_url":"git://git.apache.org/trafficserver.git","open_issues_count":33,"forks":261,"open_issues":33,"watchers":349,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/385"},"html":{"href":"https://github.com/apache/trafficserver/pull/385"},"issue":{"href":"https://api.github.com/repos/apache/trafficserver/issues/385"},"comments":{"href":"https://api.github.com/repos/apache/trafficserver/issues/385/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/385/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/385/commits"},"statuses":{"href":"https://api.github.com/repos/apache/trafficserver/statuses/120ec90d16637b6867206c0a151be25fcbe466fe"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":2,"commits":1,"additions":44,"deletions":0,"changed_files":2}}