{"action":"created","issue":{"url":"https://api.github.com/repos/hammerlab/cycledash/issues/800","labels_url":"https://api.github.com/repos/hammerlab/cycledash/issues/800/labels{/name}","comments_url":"https://api.github.com/repos/hammerlab/cycledash/issues/800/comments","events_url":"https://api.github.com/repos/hammerlab/cycledash/issues/800/events","html_url":"https://github.com/hammerlab/cycledash/pull/800","id":98204533,"number":800,"title":"Use floatThead for sticky VCF header","user":{"login":"jaclynperrone","id":5685044,"avatar_url":"https://avatars.githubusercontent.com/u/5685044?v=3","gravatar_id":"","url":"https://api.github.com/users/jaclynperrone","html_url":"https://github.com/jaclynperrone","followers_url":"https://api.github.com/users/jaclynperrone/followers","following_url":"https://api.github.com/users/jaclynperrone/following{/other_user}","gists_url":"https://api.github.com/users/jaclynperrone/gists{/gist_id}","starred_url":"https://api.github.com/users/jaclynperrone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaclynperrone/subscriptions","organizations_url":"https://api.github.com/users/jaclynperrone/orgs","repos_url":"https://api.github.com/users/jaclynperrone/repos","events_url":"https://api.github.com/users/jaclynperrone/events{/privacy}","received_events_url":"https://api.github.com/users/jaclynperrone/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"danvk","id":98301,"avatar_url":"https://avatars.githubusercontent.com/u/98301?v=3","gravatar_id":"","url":"https://api.github.com/users/danvk","html_url":"https://github.com/danvk","followers_url":"https://api.github.com/users/danvk/followers","following_url":"https://api.github.com/users/danvk/following{/other_user}","gists_url":"https://api.github.com/users/danvk/gists{/gist_id}","starred_url":"https://api.github.com/users/danvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danvk/subscriptions","organizations_url":"https://api.github.com/users/danvk/orgs","repos_url":"https://api.github.com/users/danvk/repos","events_url":"https://api.github.com/users/danvk/events{/privacy}","received_events_url":"https://api.github.com/users/danvk/received_events","type":"User","site_admin":false},"milestone":null,"comments":8,"created_at":"2015-07-30T15:59:25Z","updated_at":"2015-08-21T20:31:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hammerlab/cycledash/pulls/800","html_url":"https://github.com/hammerlab/cycledash/pull/800","diff_url":"https://github.com/hammerlab/cycledash/pull/800.diff","patch_url":"https://github.com/hammerlab/cycledash/pull/800.patch"},"body":"Here's the first attempt at adding the [floatThead](http://mkoryak.github.io/floatThead/) plugin to make the VCF table header sticky. It's looking pretty good! And the implementation was simple. There are a few known issues though, that I would love some feedback on. It would be great if you can check it out on your local machine, and play around with it/break it:\r\n- It looks like the floadThead function fires before the table data has finished loading. This causes the calculation of the thead width to be a little off, and therefore a little jumpy: http://screencast.com/t/neajQI4qJ . But only sometimes! I find this happens on a super long table that loads as you scroll. \r\n- 3 JS tests for comments are broken. I get the \"$ is not defined\" error for each. Looks like removing jQuery from `VCFTable.js` threw things off a bit (?). I added the jQuery reference to `CommentBox.js`, but no dice.\r\n\r\nThings to be done:\r\n- Update pdiff screenshots\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/hammerlab/cycledash/800)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/hammerlab/cycledash/issues/comments/133551738","html_url":"https://github.com/hammerlab/cycledash/pull/800#issuecomment-133551738","issue_url":"https://api.github.com/repos/hammerlab/cycledash/issues/800","id":133551738,"user":{"login":"jaclynperrone","id":5685044,"avatar_url":"https://avatars.githubusercontent.com/u/5685044?v=3","gravatar_id":"","url":"https://api.github.com/users/jaclynperrone","html_url":"https://github.com/jaclynperrone","followers_url":"https://api.github.com/users/jaclynperrone/followers","following_url":"https://api.github.com/users/jaclynperrone/following{/other_user}","gists_url":"https://api.github.com/users/jaclynperrone/gists{/gist_id}","starred_url":"https://api.github.com/users/jaclynperrone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaclynperrone/subscriptions","organizations_url":"https://api.github.com/users/jaclynperrone/orgs","repos_url":"https://api.github.com/users/jaclynperrone/repos","events_url":"https://api.github.com/users/jaclynperrone/events{/privacy}","received_events_url":"https://api.github.com/users/jaclynperrone/received_events","type":"User","site_admin":false},"created_at":"2015-08-21T20:31:58Z","updated_at":"2015-08-21T20:31:58Z","body":"@armish That's the same kind of jumpiness that I get on my laptop, too. It only happens for me with tables that are super long, with 10,000+ records.\r\n \r\nThanks for the advice, @mkoryak! Making the thead position:fixed causes the columns inside of it to lose their widths and collapse: http://screencast.com/t/MOLYETxdJCuu. Thankfully this plugin accounts for that by calculating and maintaining the widths for you, but the real issue is when the table has overflow-x. Position:fixed takes the thead out of flow and locks it into place, separating it from the horizontally scrolling table. So we went with this solution that avoids position:fixed to account for tables with a ton of columns. If you know of any other work arounds, feel free to send them our way!  \r\n\r\nThanks!\r\n\r\n"}}