{"action":"created","comment":{"url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/comments/24163655","id":24163655,"diff_hunk":"@@ -142,14 +166,14 @@ private MimeType resolveContentType(String type, Module module) throws ClassNotF\n \t\treturn MimeType.valueOf(type);\n \t}\n \n-\tprivate Class<?> resolveJavaType(String type, Module module) throws ClassNotFoundException, LinkageError {\n+\tprivate static Class<?> resolveJavaType(String type, Module module) throws ClassNotFoundException, LinkageError {\n \t\tSimpleModule sm = (SimpleModule) module;\n \t\treturn ClassUtils.forName(type, sm.getApplicationContext().getClassLoader());\n \t}\n \n \t@Override\n \tpublic boolean supports(Module module) {\n-\t\treturn true;\n+\t\treturn module.shouldBind();","path":"spring-xd-dirt/src/main/java/org/springframework/xd/dirt/plugins/stream/ModuleTypeConversionPlugin.java","position":80,"original_position":80,"commit_id":"62190a75a1df396e645d2979235dcab115cfb095","original_commit_id":"62190a75a1df396e645d2979235dcab115cfb095","user":{"login":"dturanski","id":886859,"avatar_url":"https://avatars.githubusercontent.com/u/886859?v=3","gravatar_id":"","url":"https://api.github.com/users/dturanski","html_url":"https://github.com/dturanski","followers_url":"https://api.github.com/users/dturanski/followers","following_url":"https://api.github.com/users/dturanski/following{/other_user}","gists_url":"https://api.github.com/users/dturanski/gists{/gist_id}","starred_url":"https://api.github.com/users/dturanski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dturanski/subscriptions","organizations_url":"https://api.github.com/users/dturanski/orgs","repos_url":"https://api.github.com/users/dturanski/repos","events_url":"https://api.github.com/users/dturanski/events{/privacy}","received_events_url":"https://api.github.com/users/dturanski/received_events","type":"User","site_admin":false},"body":"agree","created_at":"2015-02-05T13:50:15Z","updated_at":"2015-02-05T13:50:15Z","html_url":"https://github.com/spring-projects/spring-xd/pull/1438#discussion_r24163655","pull_request_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1438","_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/comments/24163655"},"html":{"href":"https://github.com/spring-projects/spring-xd/pull/1438#discussion_r24163655"},"pull_request":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1438"}}},"pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1438","id":28682673,"html_url":"https://github.com/spring-projects/spring-xd/pull/1438","diff_url":"https://github.com/spring-projects/spring-xd/pull/1438.diff","patch_url":"https://github.com/spring-projects/spring-xd/pull/1438.patch","issue_url":"https://api.github.com/repos/spring-projects/spring-xd/issues/1438","number":1438,"state":"open","locked":false,"title":"XD-2683 Spark streaming module type conversion","user":{"login":"ilayaperumalg","id":151690,"avatar_url":"https://avatars.githubusercontent.com/u/151690?v=3","gravatar_id":"","url":"https://api.github.com/users/ilayaperumalg","html_url":"https://github.com/ilayaperumalg","followers_url":"https://api.github.com/users/ilayaperumalg/followers","following_url":"https://api.github.com/users/ilayaperumalg/following{/other_user}","gists_url":"https://api.github.com/users/ilayaperumalg/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayaperumalg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayaperumalg/subscriptions","organizations_url":"https://api.github.com/users/ilayaperumalg/orgs","repos_url":"https://api.github.com/users/ilayaperumalg/repos","events_url":"https://api.github.com/users/ilayaperumalg/events{/privacy}","received_events_url":"https://api.github.com/users/ilayaperumalg/received_events","type":"User","site_admin":false},"body":"  - Set beanName for MessageBusReceiver's message storing channel as \"input\"\r\n  - Configure the corresponding message converters in MessageBusReceiver's `onStart`\r\nso that the dataType and converters are set and created at spark executor\r\n  - Set beanName for MessageBusSender as \"output\"\r\n  - Configure message converters inside the MessageBusSender's `start` so that\r\nthe dataType and converters are set and created at spark executor\r\n  - Refactored `ModuleTypeConversionPlugin` configurations and made some of the\r\nmethods static so that they can be accessed by MessageBusSender/Receiver\r\n  - Add tests","created_at":"2015-02-04T22:45:17Z","updated_at":"2015-02-05T13:50:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9cc8b14ad4b4911ec1062a670140790154eea653","assignee":{"login":"markfisher","id":140784,"avatar_url":"https://avatars.githubusercontent.com/u/140784?v=3","gravatar_id":"","url":"https://api.github.com/users/markfisher","html_url":"https://github.com/markfisher","followers_url":"https://api.github.com/users/markfisher/followers","following_url":"https://api.github.com/users/markfisher/following{/other_user}","gists_url":"https://api.github.com/users/markfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/markfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markfisher/subscriptions","organizations_url":"https://api.github.com/users/markfisher/orgs","repos_url":"https://api.github.com/users/markfisher/repos","events_url":"https://api.github.com/users/markfisher/events{/privacy}","received_events_url":"https://api.github.com/users/markfisher/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1438/commits","review_comments_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1438/comments","review_comment_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/comments/{number}","comments_url":"https://api.github.com/repos/spring-projects/spring-xd/issues/1438/comments","statuses_url":"https://api.github.com/repos/spring-projects/spring-xd/statuses/62190a75a1df396e645d2979235dcab115cfb095","head":{"label":"ilayaperumalg:XD-2683-type-conversion","ref":"XD-2683-type-conversion","sha":"62190a75a1df396e645d2979235dcab115cfb095","user":{"login":"ilayaperumalg","id":151690,"avatar_url":"https://avatars.githubusercontent.com/u/151690?v=3","gravatar_id":"","url":"https://api.github.com/users/ilayaperumalg","html_url":"https://github.com/ilayaperumalg","followers_url":"https://api.github.com/users/ilayaperumalg/followers","following_url":"https://api.github.com/users/ilayaperumalg/following{/other_user}","gists_url":"https://api.github.com/users/ilayaperumalg/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayaperumalg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayaperumalg/subscriptions","organizations_url":"https://api.github.com/users/ilayaperumalg/orgs","repos_url":"https://api.github.com/users/ilayaperumalg/repos","events_url":"https://api.github.com/users/ilayaperumalg/events{/privacy}","received_events_url":"https://api.github.com/users/ilayaperumalg/received_events","type":"User","site_admin":false},"repo":{"id":9632331,"name":"spring-xd","full_name":"ilayaperumalg/spring-xd","owner":{"login":"ilayaperumalg","id":151690,"avatar_url":"https://avatars.githubusercontent.com/u/151690?v=3","gravatar_id":"","url":"https://api.github.com/users/ilayaperumalg","html_url":"https://github.com/ilayaperumalg","followers_url":"https://api.github.com/users/ilayaperumalg/followers","following_url":"https://api.github.com/users/ilayaperumalg/following{/other_user}","gists_url":"https://api.github.com/users/ilayaperumalg/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayaperumalg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayaperumalg/subscriptions","organizations_url":"https://api.github.com/users/ilayaperumalg/orgs","repos_url":"https://api.github.com/users/ilayaperumalg/repos","events_url":"https://api.github.com/users/ilayaperumalg/events{/privacy}","received_events_url":"https://api.github.com/users/ilayaperumalg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ilayaperumalg/spring-xd","description":"Spring XD makes it easy to solve common big data problems such as data ingestion and export, real-time analytics, and batch workflow orchestration","fork":true,"url":"https://api.github.com/repos/ilayaperumalg/spring-xd","forks_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/forks","keys_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/teams","hooks_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/hooks","issue_events_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/issues/events{/number}","events_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/events","assignees_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/assignees{/user}","branches_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/branches{/branch}","tags_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/tags","blobs_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/git/refs{/sha}","trees_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/statuses/{sha}","languages_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/languages","stargazers_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/stargazers","contributors_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/contributors","subscribers_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/subscribers","subscription_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/subscription","commits_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/commits{/sha}","git_commits_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/git/commits{/sha}","comments_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/comments{/number}","issue_comment_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/issues/comments/{number}","contents_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/contents/{+path}","compare_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/merges","archive_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/downloads","issues_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/issues{/number}","pulls_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/pulls{/number}","milestones_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/milestones{/number}","notifications_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/labels{/name}","releases_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/releases{/id}","created_at":"2013-04-23T20:13:28Z","updated_at":"2014-11-17T20:36:21Z","pushed_at":"2015-02-04T22:44:40Z","git_url":"git://github.com/ilayaperumalg/spring-xd.git","ssh_url":"git@github.com:ilayaperumalg/spring-xd.git","clone_url":"https://github.com/ilayaperumalg/spring-xd.git","svn_url":"https://github.com/ilayaperumalg/spring-xd","homepage":null,"size":22523,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-projects:master","ref":"master","sha":"77bb4cb81b4ee6184696b8c68536e1a22759620c","user":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":9349347,"name":"spring-xd","full_name":"spring-projects/spring-xd","owner":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-projects/spring-xd","description":"Spring XD makes it easy to solve common big data problems such as data ingestion and export, real-time analytics, and batch workflow orchestration","fork":false,"url":"https://api.github.com/repos/spring-projects/spring-xd","forks_url":"https://api.github.com/repos/spring-projects/spring-xd/forks","keys_url":"https://api.github.com/repos/spring-projects/spring-xd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-projects/spring-xd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-projects/spring-xd/teams","hooks_url":"https://api.github.com/repos/spring-projects/spring-xd/hooks","issue_events_url":"https://api.github.com/repos/spring-projects/spring-xd/issues/events{/number}","events_url":"https://api.github.com/repos/spring-projects/spring-xd/events","assignees_url":"https://api.github.com/repos/spring-projects/spring-xd/assignees{/user}","branches_url":"https://api.github.com/repos/spring-projects/spring-xd/branches{/branch}","tags_url":"https://api.github.com/repos/spring-projects/spring-xd/tags","blobs_url":"https://api.github.com/repos/spring-projects/spring-xd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-projects/spring-xd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-projects/spring-xd/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-projects/spring-xd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-projects/spring-xd/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-projects/spring-xd/languages","stargazers_url":"https://api.github.com/repos/spring-projects/spring-xd/stargazers","contributors_url":"https://api.github.com/repos/spring-projects/spring-xd/contributors","subscribers_url":"https://api.github.com/repos/spring-projects/spring-xd/subscribers","subscription_url":"https://api.github.com/repos/spring-projects/spring-xd/subscription","commits_url":"https://api.github.com/repos/spring-projects/spring-xd/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-projects/spring-xd/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-projects/spring-xd/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-projects/spring-xd/issues/comments/{number}","contents_url":"https://api.github.com/repos/spring-projects/spring-xd/contents/{+path}","compare_url":"https://api.github.com/repos/spring-projects/spring-xd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-projects/spring-xd/merges","archive_url":"https://api.github.com/repos/spring-projects/spring-xd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-projects/spring-xd/downloads","issues_url":"https://api.github.com/repos/spring-projects/spring-xd/issues{/number}","pulls_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-projects/spring-xd/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-projects/spring-xd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-projects/spring-xd/labels{/name}","releases_url":"https://api.github.com/repos/spring-projects/spring-xd/releases{/id}","created_at":"2013-04-10T15:31:44Z","updated_at":"2015-02-04T22:30:52Z","pushed_at":"2015-02-04T20:10:46Z","git_url":"git://github.com/spring-projects/spring-xd.git","ssh_url":"git@github.com:spring-projects/spring-xd.git","clone_url":"https://github.com/spring-projects/spring-xd.git","svn_url":"https://github.com/spring-projects/spring-xd","homepage":"http://projects.spring.io/spring-xd","size":51471,"stargazers_count":222,"watchers_count":222,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":175,"mirror_url":null,"open_issues_count":31,"forks":175,"open_issues":31,"watchers":222,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1438"},"html":{"href":"https://github.com/spring-projects/spring-xd/pull/1438"},"issue":{"href":"https://api.github.com/repos/spring-projects/spring-xd/issues/1438"},"comments":{"href":"https://api.github.com/repos/spring-projects/spring-xd/issues/1438/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1438/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1438/commits"},"statuses":{"href":"https://api.github.com/repos/spring-projects/spring-xd/statuses/62190a75a1df396e645d2979235dcab115cfb095"}}}}