{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/39306986","id":39306986,"diff_hunk":"@@ -207,6 +207,11 @@ func (oi *OsdnRegistryInterface) WriteNetworkConfig(network string, subnetLength\n \tif err == nil {\n \t\tif cn.Network == network && cn.HostSubnetLength == int(subnetLength) && cn.ServiceNetwork == serviceNetwork {\n \t\t\treturn nil\n+\t\t} else if cn.Network == network && cn.HostSubnetLength == int(subnetLength) && cn.ServiceNetwork == \"\" {\n+\t\t\t// Upgrade from 3.0.0\n+\t\t\tcn.ServiceNetwork = serviceNetwork\n+\t\t\t_, err = oi.oClient.ClusterNetwork().Update(cn)","path":"plugins/osdn/osdn.go","position":7,"original_position":7,"commit_id":"35afd0869bc8338edc1d21a053eaab7589cc1f54","original_commit_id":"6227bedf4af94451c1337a3e6ba278dabb41b188","user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"body":"@pravisankar feel free to open a follow up issue for moving to conversion if we can figure out how","created_at":"2015-09-11T19:18:36Z","updated_at":"2015-09-11T19:18:36Z","html_url":"https://github.com/openshift/origin/pull/4615#discussion_r39306986","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/4615","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/39306986"},"html":{"href":"https://github.com/openshift/origin/pull/4615#discussion_r39306986"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/4615"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/4615","id":44690415,"html_url":"https://github.com/openshift/origin/pull/4615","diff_url":"https://github.com/openshift/origin/pull/4615.diff","patch_url":"https://github.com/openshift/origin/pull/4615.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/4615","number":4615,"state":"closed","locked":false,"title":"Update ClusterNetwork record when upgrading from 3.0.0","user":{"login":"danwinship","id":96040,"avatar_url":"https://avatars.githubusercontent.com/u/96040?v=3","gravatar_id":"","url":"https://api.github.com/users/danwinship","html_url":"https://github.com/danwinship","followers_url":"https://api.github.com/users/danwinship/followers","following_url":"https://api.github.com/users/danwinship/following{/other_user}","gists_url":"https://api.github.com/users/danwinship/gists{/gist_id}","starred_url":"https://api.github.com/users/danwinship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danwinship/subscriptions","organizations_url":"https://api.github.com/users/danwinship/orgs","repos_url":"https://api.github.com/users/danwinship/repos","events_url":"https://api.github.com/users/danwinship/events{/privacy}","received_events_url":"https://api.github.com/users/danwinship/received_events","type":"User","site_admin":false},"body":"Closes #4605\r\n","created_at":"2015-09-10T16:37:49Z","updated_at":"2015-09-11T19:18:36Z","closed_at":"2015-09-11T19:15:20Z","merged_at":"2015-09-11T19:15:20Z","merge_commit_sha":"d9c4ae1ff529512f7e5cb1d45aa5dff631ffdce3","assignee":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/4615/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/4615/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/4615/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/35afd0869bc8338edc1d21a053eaab7589cc1f54","head":{"label":"danwinship:servicenetwork-upgrade","ref":"servicenetwork-upgrade","sha":"35afd0869bc8338edc1d21a053eaab7589cc1f54","user":{"login":"danwinship","id":96040,"avatar_url":"https://avatars.githubusercontent.com/u/96040?v=3","gravatar_id":"","url":"https://api.github.com/users/danwinship","html_url":"https://github.com/danwinship","followers_url":"https://api.github.com/users/danwinship/followers","following_url":"https://api.github.com/users/danwinship/following{/other_user}","gists_url":"https://api.github.com/users/danwinship/gists{/gist_id}","starred_url":"https://api.github.com/users/danwinship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danwinship/subscriptions","organizations_url":"https://api.github.com/users/danwinship/orgs","repos_url":"https://api.github.com/users/danwinship/repos","events_url":"https://api.github.com/users/danwinship/events{/privacy}","received_events_url":"https://api.github.com/users/danwinship/received_events","type":"User","site_admin":false},"repo":{"id":36016405,"name":"origin","full_name":"danwinship/origin","owner":{"login":"danwinship","id":96040,"avatar_url":"https://avatars.githubusercontent.com/u/96040?v=3","gravatar_id":"","url":"https://api.github.com/users/danwinship","html_url":"https://github.com/danwinship","followers_url":"https://api.github.com/users/danwinship/followers","following_url":"https://api.github.com/users/danwinship/following{/other_user}","gists_url":"https://api.github.com/users/danwinship/gists{/gist_id}","starred_url":"https://api.github.com/users/danwinship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danwinship/subscriptions","organizations_url":"https://api.github.com/users/danwinship/orgs","repos_url":"https://api.github.com/users/danwinship/repos","events_url":"https://api.github.com/users/danwinship/events{/privacy}","received_events_url":"https://api.github.com/users/danwinship/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danwinship/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/danwinship/origin","forks_url":"https://api.github.com/repos/danwinship/origin/forks","keys_url":"https://api.github.com/repos/danwinship/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danwinship/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danwinship/origin/teams","hooks_url":"https://api.github.com/repos/danwinship/origin/hooks","issue_events_url":"https://api.github.com/repos/danwinship/origin/issues/events{/number}","events_url":"https://api.github.com/repos/danwinship/origin/events","assignees_url":"https://api.github.com/repos/danwinship/origin/assignees{/user}","branches_url":"https://api.github.com/repos/danwinship/origin/branches{/branch}","tags_url":"https://api.github.com/repos/danwinship/origin/tags","blobs_url":"https://api.github.com/repos/danwinship/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danwinship/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danwinship/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/danwinship/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danwinship/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/danwinship/origin/languages","stargazers_url":"https://api.github.com/repos/danwinship/origin/stargazers","contributors_url":"https://api.github.com/repos/danwinship/origin/contributors","subscribers_url":"https://api.github.com/repos/danwinship/origin/subscribers","subscription_url":"https://api.github.com/repos/danwinship/origin/subscription","commits_url":"https://api.github.com/repos/danwinship/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/danwinship/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/danwinship/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/danwinship/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/danwinship/origin/contents/{+path}","compare_url":"https://api.github.com/repos/danwinship/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danwinship/origin/merges","archive_url":"https://api.github.com/repos/danwinship/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danwinship/origin/downloads","issues_url":"https://api.github.com/repos/danwinship/origin/issues{/number}","pulls_url":"https://api.github.com/repos/danwinship/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/danwinship/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/danwinship/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danwinship/origin/labels{/name}","releases_url":"https://api.github.com/repos/danwinship/origin/releases{/id}","created_at":"2015-05-21T14:09:10Z","updated_at":"2015-05-21T14:09:13Z","pushed_at":"2015-09-10T18:11:58Z","git_url":"git://github.com/danwinship/origin.git","ssh_url":"git@github.com:danwinship/origin.git","clone_url":"https://github.com/danwinship/origin.git","svn_url":"https://github.com/danwinship/origin","homepage":"http://www.openshift.org","size":136521,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"6b0989ffc2f4c0a1a6f4d0730174eec7eb696e93","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2015-09-10T14:38:36Z","pushed_at":"2015-09-11T19:15:22Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":227143,"stargazers_count":673,"watchers_count":673,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":402,"mirror_url":null,"open_issues_count":535,"forks":402,"open_issues":535,"watchers":673,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/4615"},"html":{"href":"https://github.com/openshift/origin/pull/4615"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/4615"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/4615/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/4615/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/4615/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/35afd0869bc8338edc1d21a053eaab7589cc1f54"}}}}