{"action":"created","comment":{"url":"https://api.github.com/repos/codevise/pageflow/pulls/comments/38937841","id":38937841,"diff_hunk":"@@ -188,6 +188,19 @@ class Configuration\n     # @since 0.7\n     attr_accessor :available_locales\n \n+    # How to handle https requests for URLs which will have assets in the page.\n+    # If you wish to serve all assets over http and prevent mixed-content warnings,\n+    # you can force a redirect to http. The inverse is also true: you can force\n+    # a redirect to https for all http requests.\n+    #\n+    # @example\n+    #\n+    #     config.public_https_mode = :prevent (default) # => redirects https to http","path":"lib/pageflow/configuration.rb","position":11,"original_position":11,"commit_id":"093e20352511d250665340e5843860f5a517ca22","original_commit_id":"093e20352511d250665340e5843860f5a517ca22","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Line is too long. [84/80]","created_at":"2015-09-08T15:14:10Z","updated_at":"2015-09-08T15:14:10Z","html_url":"https://github.com/codevise/pageflow/pull/403#discussion_r38937841","pull_request_url":"https://api.github.com/repos/codevise/pageflow/pulls/403","_links":{"self":{"href":"https://api.github.com/repos/codevise/pageflow/pulls/comments/38937841"},"html":{"href":"https://github.com/codevise/pageflow/pull/403#discussion_r38937841"},"pull_request":{"href":"https://api.github.com/repos/codevise/pageflow/pulls/403"}}},"pull_request":{"url":"https://api.github.com/repos/codevise/pageflow/pulls/403","id":44424757,"html_url":"https://github.com/codevise/pageflow/pull/403","diff_url":"https://github.com/codevise/pageflow/pull/403.diff","patch_url":"https://github.com/codevise/pageflow/pull/403.patch","issue_url":"https://api.github.com/repos/codevise/pageflow/issues/403","number":403,"state":"open","locked":false,"title":"make https mode configurable","user":{"login":"tilsammans","id":14680,"avatar_url":"https://avatars.githubusercontent.com/u/14680?v=3","gravatar_id":"","url":"https://api.github.com/users/tilsammans","html_url":"https://github.com/tilsammans","followers_url":"https://api.github.com/users/tilsammans/followers","following_url":"https://api.github.com/users/tilsammans/following{/other_user}","gists_url":"https://api.github.com/users/tilsammans/gists{/gist_id}","starred_url":"https://api.github.com/users/tilsammans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tilsammans/subscriptions","organizations_url":"https://api.github.com/users/tilsammans/orgs","repos_url":"https://api.github.com/users/tilsammans/repos","events_url":"https://api.github.com/users/tilsammans/events{/privacy}","received_events_url":"https://api.github.com/users/tilsammans/received_events","type":"User","site_admin":false},"body":"Pageflow has always been serving assets over a CDN without https\r\nendpoint. The prevent_ssl filter made sure to redirect to a non-https\r\nmethod when assets are involved. This change makes that setting\r\nconfigurable. You can now ignore, enforce or prevent https.\r\n\r\nThe default is to prevent https, like how Pageflow < 1.0 behaved.\r\nHowever in new initializers the generated value is :ignore. This should\r\nmake the setting compatible with most applications out of the box.\r\n\r\nfixes codevise/pageflow#388","created_at":"2015-09-08T12:15:36Z","updated_at":"2015-09-08T15:14:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c61fbb0f2eb7c2253b978a097a81b97d6e6c76a8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/codevise/pageflow/pulls/403/commits","review_comments_url":"https://api.github.com/repos/codevise/pageflow/pulls/403/comments","review_comment_url":"https://api.github.com/repos/codevise/pageflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codevise/pageflow/issues/403/comments","statuses_url":"https://api.github.com/repos/codevise/pageflow/statuses/093e20352511d250665340e5843860f5a517ca22","head":{"label":"tilsammans:ssl_mode","ref":"ssl_mode","sha":"093e20352511d250665340e5843860f5a517ca22","user":{"login":"tilsammans","id":14680,"avatar_url":"https://avatars.githubusercontent.com/u/14680?v=3","gravatar_id":"","url":"https://api.github.com/users/tilsammans","html_url":"https://github.com/tilsammans","followers_url":"https://api.github.com/users/tilsammans/followers","following_url":"https://api.github.com/users/tilsammans/following{/other_user}","gists_url":"https://api.github.com/users/tilsammans/gists{/gist_id}","starred_url":"https://api.github.com/users/tilsammans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tilsammans/subscriptions","organizations_url":"https://api.github.com/users/tilsammans/orgs","repos_url":"https://api.github.com/users/tilsammans/repos","events_url":"https://api.github.com/users/tilsammans/events{/privacy}","received_events_url":"https://api.github.com/users/tilsammans/received_events","type":"User","site_admin":false},"repo":{"id":34409646,"name":"pageflow","full_name":"tilsammans/pageflow","owner":{"login":"tilsammans","id":14680,"avatar_url":"https://avatars.githubusercontent.com/u/14680?v=3","gravatar_id":"","url":"https://api.github.com/users/tilsammans","html_url":"https://github.com/tilsammans","followers_url":"https://api.github.com/users/tilsammans/followers","following_url":"https://api.github.com/users/tilsammans/following{/other_user}","gists_url":"https://api.github.com/users/tilsammans/gists{/gist_id}","starred_url":"https://api.github.com/users/tilsammans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tilsammans/subscriptions","organizations_url":"https://api.github.com/users/tilsammans/orgs","repos_url":"https://api.github.com/users/tilsammans/repos","events_url":"https://api.github.com/users/tilsammans/events{/privacy}","received_events_url":"https://api.github.com/users/tilsammans/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tilsammans/pageflow","description":"Multimedia story telling for the web.","fork":true,"url":"https://api.github.com/repos/tilsammans/pageflow","forks_url":"https://api.github.com/repos/tilsammans/pageflow/forks","keys_url":"https://api.github.com/repos/tilsammans/pageflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tilsammans/pageflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tilsammans/pageflow/teams","hooks_url":"https://api.github.com/repos/tilsammans/pageflow/hooks","issue_events_url":"https://api.github.com/repos/tilsammans/pageflow/issues/events{/number}","events_url":"https://api.github.com/repos/tilsammans/pageflow/events","assignees_url":"https://api.github.com/repos/tilsammans/pageflow/assignees{/user}","branches_url":"https://api.github.com/repos/tilsammans/pageflow/branches{/branch}","tags_url":"https://api.github.com/repos/tilsammans/pageflow/tags","blobs_url":"https://api.github.com/repos/tilsammans/pageflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tilsammans/pageflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tilsammans/pageflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/tilsammans/pageflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tilsammans/pageflow/statuses/{sha}","languages_url":"https://api.github.com/repos/tilsammans/pageflow/languages","stargazers_url":"https://api.github.com/repos/tilsammans/pageflow/stargazers","contributors_url":"https://api.github.com/repos/tilsammans/pageflow/contributors","subscribers_url":"https://api.github.com/repos/tilsammans/pageflow/subscribers","subscription_url":"https://api.github.com/repos/tilsammans/pageflow/subscription","commits_url":"https://api.github.com/repos/tilsammans/pageflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/tilsammans/pageflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/tilsammans/pageflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/tilsammans/pageflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/tilsammans/pageflow/contents/{+path}","compare_url":"https://api.github.com/repos/tilsammans/pageflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tilsammans/pageflow/merges","archive_url":"https://api.github.com/repos/tilsammans/pageflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tilsammans/pageflow/downloads","issues_url":"https://api.github.com/repos/tilsammans/pageflow/issues{/number}","pulls_url":"https://api.github.com/repos/tilsammans/pageflow/pulls{/number}","milestones_url":"https://api.github.com/repos/tilsammans/pageflow/milestones{/number}","notifications_url":"https://api.github.com/repos/tilsammans/pageflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tilsammans/pageflow/labels{/name}","releases_url":"https://api.github.com/repos/tilsammans/pageflow/releases{/id}","created_at":"2015-04-22T18:57:29Z","updated_at":"2015-04-22T18:57:30Z","pushed_at":"2015-09-08T15:13:59Z","git_url":"git://github.com/tilsammans/pageflow.git","ssh_url":"git@github.com:tilsammans/pageflow.git","clone_url":"https://github.com/tilsammans/pageflow.git","svn_url":"https://github.com/tilsammans/pageflow","homepage":"http://pageflow.io","size":9034,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codevise:master","ref":"master","sha":"228e2281beea3df6a97b44ebdc25470c06f2cc06","user":{"login":"codevise","id":537804,"avatar_url":"https://avatars.githubusercontent.com/u/537804?v=3","gravatar_id":"","url":"https://api.github.com/users/codevise","html_url":"https://github.com/codevise","followers_url":"https://api.github.com/users/codevise/followers","following_url":"https://api.github.com/users/codevise/following{/other_user}","gists_url":"https://api.github.com/users/codevise/gists{/gist_id}","starred_url":"https://api.github.com/users/codevise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codevise/subscriptions","organizations_url":"https://api.github.com/users/codevise/orgs","repos_url":"https://api.github.com/users/codevise/repos","events_url":"https://api.github.com/users/codevise/events{/privacy}","received_events_url":"https://api.github.com/users/codevise/received_events","type":"Organization","site_admin":false},"repo":{"id":19446839,"name":"pageflow","full_name":"codevise/pageflow","owner":{"login":"codevise","id":537804,"avatar_url":"https://avatars.githubusercontent.com/u/537804?v=3","gravatar_id":"","url":"https://api.github.com/users/codevise","html_url":"https://github.com/codevise","followers_url":"https://api.github.com/users/codevise/followers","following_url":"https://api.github.com/users/codevise/following{/other_user}","gists_url":"https://api.github.com/users/codevise/gists{/gist_id}","starred_url":"https://api.github.com/users/codevise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codevise/subscriptions","organizations_url":"https://api.github.com/users/codevise/orgs","repos_url":"https://api.github.com/users/codevise/repos","events_url":"https://api.github.com/users/codevise/events{/privacy}","received_events_url":"https://api.github.com/users/codevise/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codevise/pageflow","description":"Multimedia story telling for the web.","fork":false,"url":"https://api.github.com/repos/codevise/pageflow","forks_url":"https://api.github.com/repos/codevise/pageflow/forks","keys_url":"https://api.github.com/repos/codevise/pageflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codevise/pageflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codevise/pageflow/teams","hooks_url":"https://api.github.com/repos/codevise/pageflow/hooks","issue_events_url":"https://api.github.com/repos/codevise/pageflow/issues/events{/number}","events_url":"https://api.github.com/repos/codevise/pageflow/events","assignees_url":"https://api.github.com/repos/codevise/pageflow/assignees{/user}","branches_url":"https://api.github.com/repos/codevise/pageflow/branches{/branch}","tags_url":"https://api.github.com/repos/codevise/pageflow/tags","blobs_url":"https://api.github.com/repos/codevise/pageflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codevise/pageflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codevise/pageflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/codevise/pageflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codevise/pageflow/statuses/{sha}","languages_url":"https://api.github.com/repos/codevise/pageflow/languages","stargazers_url":"https://api.github.com/repos/codevise/pageflow/stargazers","contributors_url":"https://api.github.com/repos/codevise/pageflow/contributors","subscribers_url":"https://api.github.com/repos/codevise/pageflow/subscribers","subscription_url":"https://api.github.com/repos/codevise/pageflow/subscription","commits_url":"https://api.github.com/repos/codevise/pageflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/codevise/pageflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/codevise/pageflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/codevise/pageflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/codevise/pageflow/contents/{+path}","compare_url":"https://api.github.com/repos/codevise/pageflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codevise/pageflow/merges","archive_url":"https://api.github.com/repos/codevise/pageflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codevise/pageflow/downloads","issues_url":"https://api.github.com/repos/codevise/pageflow/issues{/number}","pulls_url":"https://api.github.com/repos/codevise/pageflow/pulls{/number}","milestones_url":"https://api.github.com/repos/codevise/pageflow/milestones{/number}","notifications_url":"https://api.github.com/repos/codevise/pageflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codevise/pageflow/labels{/name}","releases_url":"https://api.github.com/repos/codevise/pageflow/releases{/id}","created_at":"2014-05-05T06:50:13Z","updated_at":"2015-08-25T06:49:37Z","pushed_at":"2015-09-08T15:14:00Z","git_url":"git://github.com/codevise/pageflow.git","ssh_url":"git@github.com:codevise/pageflow.git","clone_url":"https://github.com/codevise/pageflow.git","svn_url":"https://github.com/codevise/pageflow","homepage":"http://pageflow.io","size":12049,"stargazers_count":246,"watchers_count":246,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"open_issues_count":16,"forks":58,"open_issues":16,"watchers":246,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codevise/pageflow/pulls/403"},"html":{"href":"https://github.com/codevise/pageflow/pull/403"},"issue":{"href":"https://api.github.com/repos/codevise/pageflow/issues/403"},"comments":{"href":"https://api.github.com/repos/codevise/pageflow/issues/403/comments"},"review_comments":{"href":"https://api.github.com/repos/codevise/pageflow/pulls/403/comments"},"review_comment":{"href":"https://api.github.com/repos/codevise/pageflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codevise/pageflow/pulls/403/commits"},"statuses":{"href":"https://api.github.com/repos/codevise/pageflow/statuses/093e20352511d250665340e5843860f5a517ca22"}}}}