{"action":"created","comment":{"url":"https://api.github.com/repos/owncloud/documentation/pulls/comments/47703911","id":47703911,"diff_hunk":"@@ -402,12 +402,16 @@ Email Field:\n \n User Home Folder Naming Rule:\n   By default, the ownCloud server creates the user directory in your ownCloud \n-  data directory. You may want to override this setting and name it after an \n-  attribute value. The attribute given can also return an absolute path, e.g. \n+  data directory and gives it the ownCloud username, .e.g ``/var/www/owncloud/data/alice``. You may want to override this setting and name it after an LDAP\n+  attribute value. The attribute can also return an absolute path, e.g. \n   ``/mnt/storage43/alice``. Leave it empty for default behavior.\n \n   * Example: *cn*\n \n+In new ownCloud installations the home folder rule is enforced. This means that once you set a home folder naming rule (get a home folder from an LDAP attribute), it must be available for all users. If it isn't available for a user, then that user will not be able to login. In existing ownCloud installations the old behavior still applies; which is using the ownCloud username as the home folder when an LDAP attribute is not set. You may change this to enforcing the home folder rule with this entry in ``config.php``::","path":"admin_manual/configuration_user/user_auth_ldap.rst","position":12,"original_position":12,"commit_id":"2a1d1212d6577e8b11d9b6f88ef033c585d7cd27","original_commit_id":"2a1d1212d6577e8b11d9b6f88ef033c585d7cd27","user":{"login":"MorrisJobke","id":245432,"avatar_url":"https://avatars.githubusercontent.com/u/245432?v=3","gravatar_id":"","url":"https://api.github.com/users/MorrisJobke","html_url":"https://github.com/MorrisJobke","followers_url":"https://api.github.com/users/MorrisJobke/followers","following_url":"https://api.github.com/users/MorrisJobke/following{/other_user}","gists_url":"https://api.github.com/users/MorrisJobke/gists{/gist_id}","starred_url":"https://api.github.com/users/MorrisJobke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MorrisJobke/subscriptions","organizations_url":"https://api.github.com/users/MorrisJobke/orgs","repos_url":"https://api.github.com/users/MorrisJobke/repos","events_url":"https://api.github.com/users/MorrisJobke/events{/privacy}","received_events_url":"https://api.github.com/users/MorrisJobke/received_events","type":"User","site_admin":false},"body":"Yep. And Alice still can log in (but the share of Bob is gone)","created_at":"2015-12-15T21:48:30Z","updated_at":"2015-12-15T21:48:30Z","html_url":"https://github.com/owncloud/documentation/pull/1955#discussion_r47703911","pull_request_url":"https://api.github.com/repos/owncloud/documentation/pulls/1955","_links":{"self":{"href":"https://api.github.com/repos/owncloud/documentation/pulls/comments/47703911"},"html":{"href":"https://github.com/owncloud/documentation/pull/1955#discussion_r47703911"},"pull_request":{"href":"https://api.github.com/repos/owncloud/documentation/pulls/1955"}}},"pull_request":{"url":"https://api.github.com/repos/owncloud/documentation/pulls/1955","id":53761063,"html_url":"https://github.com/owncloud/documentation/pull/1955","diff_url":"https://github.com/owncloud/documentation/pull/1955.diff","patch_url":"https://github.com/owncloud/documentation/pull/1955.patch","issue_url":"https://api.github.com/repos/owncloud/documentation/issues/1955","number":1955,"state":"open","locked":false,"title":"ldap home folder rule now enforced","user":{"login":"carlaschroder","id":8388387,"avatar_url":"https://avatars.githubusercontent.com/u/8388387?v=3","gravatar_id":"","url":"https://api.github.com/users/carlaschroder","html_url":"https://github.com/carlaschroder","followers_url":"https://api.github.com/users/carlaschroder/followers","following_url":"https://api.github.com/users/carlaschroder/following{/other_user}","gists_url":"https://api.github.com/users/carlaschroder/gists{/gist_id}","starred_url":"https://api.github.com/users/carlaschroder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlaschroder/subscriptions","organizations_url":"https://api.github.com/users/carlaschroder/orgs","repos_url":"https://api.github.com/users/carlaschroder/repos","events_url":"https://api.github.com/users/carlaschroder/events{/privacy}","received_events_url":"https://api.github.com/users/carlaschroder/received_events","type":"User","site_admin":false},"body":"re: https://github.com/owncloud/core/pull/16961 \"Hardening home folder retrieval in user_ldap\"\r\n\r\nPlease review @blizzz @MorrisJobke @butonic ","created_at":"2015-12-15T20:58:40Z","updated_at":"2015-12-15T21:48:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b93f98069eaa382a7f68362e140dc91da338b344","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/owncloud/documentation/pulls/1955/commits","review_comments_url":"https://api.github.com/repos/owncloud/documentation/pulls/1955/comments","review_comment_url":"https://api.github.com/repos/owncloud/documentation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/owncloud/documentation/issues/1955/comments","statuses_url":"https://api.github.com/repos/owncloud/documentation/statuses/2a1d1212d6577e8b11d9b6f88ef033c585d7cd27","head":{"label":"owncloud:homerule","ref":"homerule","sha":"2a1d1212d6577e8b11d9b6f88ef033c585d7cd27","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":6405172,"name":"documentation","full_name":"owncloud/documentation","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/documentation","description":"Documentation and manual","fork":false,"url":"https://api.github.com/repos/owncloud/documentation","forks_url":"https://api.github.com/repos/owncloud/documentation/forks","keys_url":"https://api.github.com/repos/owncloud/documentation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/documentation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/documentation/teams","hooks_url":"https://api.github.com/repos/owncloud/documentation/hooks","issue_events_url":"https://api.github.com/repos/owncloud/documentation/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/documentation/events","assignees_url":"https://api.github.com/repos/owncloud/documentation/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/documentation/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/documentation/tags","blobs_url":"https://api.github.com/repos/owncloud/documentation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/documentation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/documentation/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/documentation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/documentation/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/documentation/languages","stargazers_url":"https://api.github.com/repos/owncloud/documentation/stargazers","contributors_url":"https://api.github.com/repos/owncloud/documentation/contributors","subscribers_url":"https://api.github.com/repos/owncloud/documentation/subscribers","subscription_url":"https://api.github.com/repos/owncloud/documentation/subscription","commits_url":"https://api.github.com/repos/owncloud/documentation/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/documentation/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/documentation/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/documentation/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/documentation/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/documentation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/documentation/merges","archive_url":"https://api.github.com/repos/owncloud/documentation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/documentation/downloads","issues_url":"https://api.github.com/repos/owncloud/documentation/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/documentation/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/documentation/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/documentation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/documentation/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/documentation/releases{/id}","created_at":"2012-10-26T14:36:00Z","updated_at":"2015-12-14T17:34:21Z","pushed_at":"2015-12-15T21:23:36Z","git_url":"git://github.com/owncloud/documentation.git","ssh_url":"git@github.com:owncloud/documentation.git","clone_url":"https://github.com/owncloud/documentation.git","svn_url":"https://github.com/owncloud/documentation","homepage":null,"size":47331,"stargazers_count":122,"watchers_count":122,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":175,"mirror_url":null,"open_issues_count":108,"forks":175,"open_issues":108,"watchers":122,"default_branch":"master"}},"base":{"label":"owncloud:master","ref":"master","sha":"c5b680ce57ed9b2119e7c7e796ff34315dd07175","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":6405172,"name":"documentation","full_name":"owncloud/documentation","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/documentation","description":"Documentation and manual","fork":false,"url":"https://api.github.com/repos/owncloud/documentation","forks_url":"https://api.github.com/repos/owncloud/documentation/forks","keys_url":"https://api.github.com/repos/owncloud/documentation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/documentation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/documentation/teams","hooks_url":"https://api.github.com/repos/owncloud/documentation/hooks","issue_events_url":"https://api.github.com/repos/owncloud/documentation/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/documentation/events","assignees_url":"https://api.github.com/repos/owncloud/documentation/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/documentation/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/documentation/tags","blobs_url":"https://api.github.com/repos/owncloud/documentation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/documentation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/documentation/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/documentation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/documentation/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/documentation/languages","stargazers_url":"https://api.github.com/repos/owncloud/documentation/stargazers","contributors_url":"https://api.github.com/repos/owncloud/documentation/contributors","subscribers_url":"https://api.github.com/repos/owncloud/documentation/subscribers","subscription_url":"https://api.github.com/repos/owncloud/documentation/subscription","commits_url":"https://api.github.com/repos/owncloud/documentation/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/documentation/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/documentation/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/documentation/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/documentation/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/documentation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/documentation/merges","archive_url":"https://api.github.com/repos/owncloud/documentation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/documentation/downloads","issues_url":"https://api.github.com/repos/owncloud/documentation/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/documentation/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/documentation/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/documentation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/documentation/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/documentation/releases{/id}","created_at":"2012-10-26T14:36:00Z","updated_at":"2015-12-14T17:34:21Z","pushed_at":"2015-12-15T21:23:36Z","git_url":"git://github.com/owncloud/documentation.git","ssh_url":"git@github.com:owncloud/documentation.git","clone_url":"https://github.com/owncloud/documentation.git","svn_url":"https://github.com/owncloud/documentation","homepage":null,"size":47331,"stargazers_count":122,"watchers_count":122,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":175,"mirror_url":null,"open_issues_count":108,"forks":175,"open_issues":108,"watchers":122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/owncloud/documentation/pulls/1955"},"html":{"href":"https://github.com/owncloud/documentation/pull/1955"},"issue":{"href":"https://api.github.com/repos/owncloud/documentation/issues/1955"},"comments":{"href":"https://api.github.com/repos/owncloud/documentation/issues/1955/comments"},"review_comments":{"href":"https://api.github.com/repos/owncloud/documentation/pulls/1955/comments"},"review_comment":{"href":"https://api.github.com/repos/owncloud/documentation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/owncloud/documentation/pulls/1955/commits"},"statuses":{"href":"https://api.github.com/repos/owncloud/documentation/statuses/2a1d1212d6577e8b11d9b6f88ef033c585d7cd27"}}}}