{"action":"created","comment":{"url":"https://api.github.com/repos/wpengine/hgv/pulls/comments/30444215","id":30444215,"diff_hunk":"@@ -0,0 +1,5 @@\n+---","path":"conf.d/default-sites.yml","position":1,"original_position":1,"commit_id":"c1f26dd755bb71fdc180afb0c2d9751b0a8bfc04","original_commit_id":"c1f26dd755bb71fdc180afb0c2d9751b0a8bfc04","user":{"login":"markkelnar","id":749603,"avatar_url":"https://avatars.githubusercontent.com/u/749603?v=3","gravatar_id":"","url":"https://api.github.com/users/markkelnar","html_url":"https://github.com/markkelnar","followers_url":"https://api.github.com/users/markkelnar/followers","following_url":"https://api.github.com/users/markkelnar/following{/other_user}","gists_url":"https://api.github.com/users/markkelnar/gists{/gist_id}","starred_url":"https://api.github.com/users/markkelnar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markkelnar/subscriptions","organizations_url":"https://api.github.com/users/markkelnar/orgs","repos_url":"https://api.github.com/users/markkelnar/repos","events_url":"https://api.github.com/users/markkelnar/events{/privacy}","received_events_url":"https://api.github.com/users/markkelnar/received_events","type":"User","site_admin":false},"body":"Move this file to something like provisioning/default-wp.yml (or something like that)","created_at":"2015-05-15T20:41:20Z","updated_at":"2015-05-15T20:41:20Z","html_url":"https://github.com/wpengine/hgv/pull/154#discussion_r30444215","pull_request_url":"https://api.github.com/repos/wpengine/hgv/pulls/154","_links":{"self":{"href":"https://api.github.com/repos/wpengine/hgv/pulls/comments/30444215"},"html":{"href":"https://github.com/wpengine/hgv/pull/154#discussion_r30444215"},"pull_request":{"href":"https://api.github.com/repos/wpengine/hgv/pulls/154"}}},"pull_request":{"url":"https://api.github.com/repos/wpengine/hgv/pulls/154","id":35270695,"html_url":"https://github.com/wpengine/hgv/pull/154","diff_url":"https://github.com/wpengine/hgv/pull/154.diff","patch_url":"https://github.com/wpengine/hgv/pull/154.patch","issue_url":"https://api.github.com/repos/wpengine/hgv/issues/154","number":154,"state":"open","locked":false,"title":"Conf.d custom-sites.yml","user":{"login":"markkelnar","id":749603,"avatar_url":"https://avatars.githubusercontent.com/u/749603?v=3","gravatar_id":"","url":"https://api.github.com/users/markkelnar","html_url":"https://github.com/markkelnar","followers_url":"https://api.github.com/users/markkelnar/followers","following_url":"https://api.github.com/users/markkelnar/following{/other_user}","gists_url":"https://api.github.com/users/markkelnar/gists{/gist_id}","starred_url":"https://api.github.com/users/markkelnar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markkelnar/subscriptions","organizations_url":"https://api.github.com/users/markkelnar/orgs","repos_url":"https://api.github.com/users/markkelnar/repos","events_url":"https://api.github.com/users/markkelnar/events{/privacy}","received_events_url":"https://api.github.com/users/markkelnar/received_events","type":"User","site_admin":false},"body":"* [ ] @zamoose\r\n* [ ] @markkelnar \r\n\r\nCode to work on custom YML files directory and format and triggered by the bash init script.  This was branched from my domains-by-variables branch (https://github.com/wpengine/hgv/pull/153).\r\n\r\nAgain, explored some ideas to see what it would look like and even possible with variables and yml files in a conf.d/.  One change I did make here was the move of php.hgv.dev to point to the 'hhvm' WP install on disk.  That change doesn't have to happen with all these other changes, that's fairly easy to support.\r\n\r\nNow that I look at it a few days later, I think we'll want to change the variable name to not be 'wp' in the config file. \r\n\r\nYou can see at the bottom of the bin/hgv-init.sh script where the wordpress.yml is invoked.  This is where we could a glob and for/while loop over any conf.d/custom-sites*.yml files provided by the user. \r\n\r\nI also think we can follow this with a rename of the 'enviro' variable to something more meaningful and accurate like 'docroot'.\r\n\r\nHere's an example conf.d/custom-sites.yml I tested with\r\n\r\n```\r\n---\r\nwp:\r\n  enviro: mark\r\n  hhvm_domains: [ 'mark.local', 'www.mark.local' ]\r\n  php_domains: [ 'php.mark.local' ]","created_at":"2015-05-12T21:07:30Z","updated_at":"2015-05-15T20:41:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5264058570d5f84ee9e56b97abfddd7c728f314f","assignee":null,"milestone":{"url":"https://api.github.com/repos/wpengine/hgv/milestones/4","html_url":"https://github.com/wpengine/hgv/milestones/HGV%201.3","labels_url":"https://api.github.com/repos/wpengine/hgv/milestones/4/labels","id":1049404,"number":4,"title":"HGV 1.3","description":"","creator":{"login":"stephen-lin","id":10426567,"avatar_url":"https://avatars.githubusercontent.com/u/10426567?v=3","gravatar_id":"","url":"https://api.github.com/users/stephen-lin","html_url":"https://github.com/stephen-lin","followers_url":"https://api.github.com/users/stephen-lin/followers","following_url":"https://api.github.com/users/stephen-lin/following{/other_user}","gists_url":"https://api.github.com/users/stephen-lin/gists{/gist_id}","starred_url":"https://api.github.com/users/stephen-lin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephen-lin/subscriptions","organizations_url":"https://api.github.com/users/stephen-lin/orgs","repos_url":"https://api.github.com/users/stephen-lin/repos","events_url":"https://api.github.com/users/stephen-lin/events{/privacy}","received_events_url":"https://api.github.com/users/stephen-lin/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":7,"state":"open","created_at":"2015-04-01T20:28:43Z","updated_at":"2015-05-14T21:22:26Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/wpengine/hgv/pulls/154/commits","review_comments_url":"https://api.github.com/repos/wpengine/hgv/pulls/154/comments","review_comment_url":"https://api.github.com/repos/wpengine/hgv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wpengine/hgv/issues/154/comments","statuses_url":"https://api.github.com/repos/wpengine/hgv/statuses/c1f26dd755bb71fdc180afb0c2d9751b0a8bfc04","head":{"label":"markkelnar:conf-d-custom-yml","ref":"conf-d-custom-yml","sha":"c1f26dd755bb71fdc180afb0c2d9751b0a8bfc04","user":{"login":"markkelnar","id":749603,"avatar_url":"https://avatars.githubusercontent.com/u/749603?v=3","gravatar_id":"","url":"https://api.github.com/users/markkelnar","html_url":"https://github.com/markkelnar","followers_url":"https://api.github.com/users/markkelnar/followers","following_url":"https://api.github.com/users/markkelnar/following{/other_user}","gists_url":"https://api.github.com/users/markkelnar/gists{/gist_id}","starred_url":"https://api.github.com/users/markkelnar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markkelnar/subscriptions","organizations_url":"https://api.github.com/users/markkelnar/orgs","repos_url":"https://api.github.com/users/markkelnar/repos","events_url":"https://api.github.com/users/markkelnar/events{/privacy}","received_events_url":"https://api.github.com/users/markkelnar/received_events","type":"User","site_admin":false},"repo":{"id":29260509,"name":"hgv","full_name":"markkelnar/hgv","owner":{"login":"markkelnar","id":749603,"avatar_url":"https://avatars.githubusercontent.com/u/749603?v=3","gravatar_id":"","url":"https://api.github.com/users/markkelnar","html_url":"https://github.com/markkelnar","followers_url":"https://api.github.com/users/markkelnar/followers","following_url":"https://api.github.com/users/markkelnar/following{/other_user}","gists_url":"https://api.github.com/users/markkelnar/gists{/gist_id}","starred_url":"https://api.github.com/users/markkelnar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markkelnar/subscriptions","organizations_url":"https://api.github.com/users/markkelnar/orgs","repos_url":"https://api.github.com/users/markkelnar/repos","events_url":"https://api.github.com/users/markkelnar/events{/privacy}","received_events_url":"https://api.github.com/users/markkelnar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/markkelnar/hgv","description":"WP Engine's Mercury vagrant environment","fork":true,"url":"https://api.github.com/repos/markkelnar/hgv","forks_url":"https://api.github.com/repos/markkelnar/hgv/forks","keys_url":"https://api.github.com/repos/markkelnar/hgv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markkelnar/hgv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markkelnar/hgv/teams","hooks_url":"https://api.github.com/repos/markkelnar/hgv/hooks","issue_events_url":"https://api.github.com/repos/markkelnar/hgv/issues/events{/number}","events_url":"https://api.github.com/repos/markkelnar/hgv/events","assignees_url":"https://api.github.com/repos/markkelnar/hgv/assignees{/user}","branches_url":"https://api.github.com/repos/markkelnar/hgv/branches{/branch}","tags_url":"https://api.github.com/repos/markkelnar/hgv/tags","blobs_url":"https://api.github.com/repos/markkelnar/hgv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markkelnar/hgv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markkelnar/hgv/git/refs{/sha}","trees_url":"https://api.github.com/repos/markkelnar/hgv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markkelnar/hgv/statuses/{sha}","languages_url":"https://api.github.com/repos/markkelnar/hgv/languages","stargazers_url":"https://api.github.com/repos/markkelnar/hgv/stargazers","contributors_url":"https://api.github.com/repos/markkelnar/hgv/contributors","subscribers_url":"https://api.github.com/repos/markkelnar/hgv/subscribers","subscription_url":"https://api.github.com/repos/markkelnar/hgv/subscription","commits_url":"https://api.github.com/repos/markkelnar/hgv/commits{/sha}","git_commits_url":"https://api.github.com/repos/markkelnar/hgv/git/commits{/sha}","comments_url":"https://api.github.com/repos/markkelnar/hgv/comments{/number}","issue_comment_url":"https://api.github.com/repos/markkelnar/hgv/issues/comments{/number}","contents_url":"https://api.github.com/repos/markkelnar/hgv/contents/{+path}","compare_url":"https://api.github.com/repos/markkelnar/hgv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markkelnar/hgv/merges","archive_url":"https://api.github.com/repos/markkelnar/hgv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markkelnar/hgv/downloads","issues_url":"https://api.github.com/repos/markkelnar/hgv/issues{/number}","pulls_url":"https://api.github.com/repos/markkelnar/hgv/pulls{/number}","milestones_url":"https://api.github.com/repos/markkelnar/hgv/milestones{/number}","notifications_url":"https://api.github.com/repos/markkelnar/hgv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markkelnar/hgv/labels{/name}","releases_url":"https://api.github.com/repos/markkelnar/hgv/releases{/id}","created_at":"2015-01-14T19:02:59Z","updated_at":"2015-01-15T02:31:08Z","pushed_at":"2015-05-15T17:19:25Z","git_url":"git://github.com/markkelnar/hgv.git","ssh_url":"git@github.com:markkelnar/hgv.git","clone_url":"https://github.com/markkelnar/hgv.git","svn_url":"https://github.com/markkelnar/hgv","homepage":"http://merc.wpengine.com","size":790,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wpengine:master","ref":"master","sha":"23c32673aa74fc86c96fe8a5db1cb5c44c057142","user":{"login":"wpengine","id":749191,"avatar_url":"https://avatars.githubusercontent.com/u/749191?v=3","gravatar_id":"","url":"https://api.github.com/users/wpengine","html_url":"https://github.com/wpengine","followers_url":"https://api.github.com/users/wpengine/followers","following_url":"https://api.github.com/users/wpengine/following{/other_user}","gists_url":"https://api.github.com/users/wpengine/gists{/gist_id}","starred_url":"https://api.github.com/users/wpengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wpengine/subscriptions","organizations_url":"https://api.github.com/users/wpengine/orgs","repos_url":"https://api.github.com/users/wpengine/repos","events_url":"https://api.github.com/users/wpengine/events{/privacy}","received_events_url":"https://api.github.com/users/wpengine/received_events","type":"Organization","site_admin":false},"repo":{"id":28054492,"name":"hgv","full_name":"wpengine/hgv","owner":{"login":"wpengine","id":749191,"avatar_url":"https://avatars.githubusercontent.com/u/749191?v=3","gravatar_id":"","url":"https://api.github.com/users/wpengine","html_url":"https://github.com/wpengine","followers_url":"https://api.github.com/users/wpengine/followers","following_url":"https://api.github.com/users/wpengine/following{/other_user}","gists_url":"https://api.github.com/users/wpengine/gists{/gist_id}","starred_url":"https://api.github.com/users/wpengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wpengine/subscriptions","organizations_url":"https://api.github.com/users/wpengine/orgs","repos_url":"https://api.github.com/users/wpengine/repos","events_url":"https://api.github.com/users/wpengine/events{/privacy}","received_events_url":"https://api.github.com/users/wpengine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wpengine/hgv","description":"WP Engine's Mercury vagrant environment","fork":false,"url":"https://api.github.com/repos/wpengine/hgv","forks_url":"https://api.github.com/repos/wpengine/hgv/forks","keys_url":"https://api.github.com/repos/wpengine/hgv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wpengine/hgv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wpengine/hgv/teams","hooks_url":"https://api.github.com/repos/wpengine/hgv/hooks","issue_events_url":"https://api.github.com/repos/wpengine/hgv/issues/events{/number}","events_url":"https://api.github.com/repos/wpengine/hgv/events","assignees_url":"https://api.github.com/repos/wpengine/hgv/assignees{/user}","branches_url":"https://api.github.com/repos/wpengine/hgv/branches{/branch}","tags_url":"https://api.github.com/repos/wpengine/hgv/tags","blobs_url":"https://api.github.com/repos/wpengine/hgv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wpengine/hgv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wpengine/hgv/git/refs{/sha}","trees_url":"https://api.github.com/repos/wpengine/hgv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wpengine/hgv/statuses/{sha}","languages_url":"https://api.github.com/repos/wpengine/hgv/languages","stargazers_url":"https://api.github.com/repos/wpengine/hgv/stargazers","contributors_url":"https://api.github.com/repos/wpengine/hgv/contributors","subscribers_url":"https://api.github.com/repos/wpengine/hgv/subscribers","subscription_url":"https://api.github.com/repos/wpengine/hgv/subscription","commits_url":"https://api.github.com/repos/wpengine/hgv/commits{/sha}","git_commits_url":"https://api.github.com/repos/wpengine/hgv/git/commits{/sha}","comments_url":"https://api.github.com/repos/wpengine/hgv/comments{/number}","issue_comment_url":"https://api.github.com/repos/wpengine/hgv/issues/comments{/number}","contents_url":"https://api.github.com/repos/wpengine/hgv/contents/{+path}","compare_url":"https://api.github.com/repos/wpengine/hgv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wpengine/hgv/merges","archive_url":"https://api.github.com/repos/wpengine/hgv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wpengine/hgv/downloads","issues_url":"https://api.github.com/repos/wpengine/hgv/issues{/number}","pulls_url":"https://api.github.com/repos/wpengine/hgv/pulls{/number}","milestones_url":"https://api.github.com/repos/wpengine/hgv/milestones{/number}","notifications_url":"https://api.github.com/repos/wpengine/hgv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wpengine/hgv/labels{/name}","releases_url":"https://api.github.com/repos/wpengine/hgv/releases{/id}","created_at":"2014-12-15T20:22:40Z","updated_at":"2015-05-14T12:57:46Z","pushed_at":"2015-05-15T17:19:26Z","git_url":"git://github.com/wpengine/hgv.git","ssh_url":"git@github.com:wpengine/hgv.git","clone_url":"https://github.com/wpengine/hgv.git","svn_url":"https://github.com/wpengine/hgv","homepage":"http://wpengine.com/mercury","size":1876,"stargazers_count":170,"watchers_count":170,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":38,"forks":23,"open_issues":38,"watchers":170,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wpengine/hgv/pulls/154"},"html":{"href":"https://github.com/wpengine/hgv/pull/154"},"issue":{"href":"https://api.github.com/repos/wpengine/hgv/issues/154"},"comments":{"href":"https://api.github.com/repos/wpengine/hgv/issues/154/comments"},"review_comments":{"href":"https://api.github.com/repos/wpengine/hgv/pulls/154/comments"},"review_comment":{"href":"https://api.github.com/repos/wpengine/hgv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wpengine/hgv/pulls/154/commits"},"statuses":{"href":"https://api.github.com/repos/wpengine/hgv/statuses/c1f26dd755bb71fdc180afb0c2d9751b0a8bfc04"}}}}