{"action":"closed","number":3,"pull_request":{"url":"https://api.github.com/repos/glue-viz/qt-helpers/pulls/3","id":37601761,"html_url":"https://github.com/glue-viz/qt-helpers/pull/3","diff_url":"https://github.com/glue-viz/qt-helpers/pull/3.diff","patch_url":"https://github.com/glue-viz/qt-helpers/pull/3.patch","issue_url":"https://api.github.com/repos/glue-viz/qt-helpers/issues/3","number":3,"state":"closed","locked":false,"title":"Started adding support for PyQt5","user":{"login":"astrofrog","id":314716,"avatar_url":"https://avatars.githubusercontent.com/u/314716?v=3","gravatar_id":"","url":"https://api.github.com/users/astrofrog","html_url":"https://github.com/astrofrog","followers_url":"https://api.github.com/users/astrofrog/followers","following_url":"https://api.github.com/users/astrofrog/following{/other_user}","gists_url":"https://api.github.com/users/astrofrog/gists{/gist_id}","starred_url":"https://api.github.com/users/astrofrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astrofrog/subscriptions","organizations_url":"https://api.github.com/users/astrofrog/orgs","repos_url":"https://api.github.com/users/astrofrog/repos","events_url":"https://api.github.com/users/astrofrog/events{/privacy}","received_events_url":"https://api.github.com/users/astrofrog/received_events","type":"User","site_admin":false},"body":"This starts to add support and tests for PyQt5. There is a subtlety however, which is that even conda doesn't complain if I install PyQt5 and PyQt4/Pyside in a same environment, PyQt5 is unable to create a QApplication in this case because the environment contains both the Qt4 and Qt5 libraries and it gets confused.\r\n\r\nIn addition, I found that some strange behaviors were due to the use of reload in tests, which doesn't actually clean up ``sys.meta_path`` which ends up containing many ImportDenier instances (because when it reloads the module it adds a new hook without removing the old one, and worse, all old instances are instances of a different class since it redefines the ImportDenier class every time). Anyway, because this is complex, I've tidied it up so that we don't actually call ``reload`` but intead have a ``reload_qt`` that ensures everything is clean and avoids this kind of issue.","created_at":"2015-06-12T20:35:21Z","updated_at":"2015-06-19T16:07:03Z","closed_at":"2015-06-19T16:07:03Z","merged_at":"2015-06-19T16:07:03Z","merge_commit_sha":"12f8ed441eb62242912d3f12ddf773a304adc335","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/glue-viz/qt-helpers/pulls/3/commits","review_comments_url":"https://api.github.com/repos/glue-viz/qt-helpers/pulls/3/comments","review_comment_url":"https://api.github.com/repos/glue-viz/qt-helpers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/glue-viz/qt-helpers/issues/3/comments","statuses_url":"https://api.github.com/repos/glue-viz/qt-helpers/statuses/a6074f5e7f956122e75f2a7500c9a14ab2871e8e","head":{"label":"astrofrog:pyqt5","ref":"pyqt5","sha":"a6074f5e7f956122e75f2a7500c9a14ab2871e8e","user":{"login":"astrofrog","id":314716,"avatar_url":"https://avatars.githubusercontent.com/u/314716?v=3","gravatar_id":"","url":"https://api.github.com/users/astrofrog","html_url":"https://github.com/astrofrog","followers_url":"https://api.github.com/users/astrofrog/followers","following_url":"https://api.github.com/users/astrofrog/following{/other_user}","gists_url":"https://api.github.com/users/astrofrog/gists{/gist_id}","starred_url":"https://api.github.com/users/astrofrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astrofrog/subscriptions","organizations_url":"https://api.github.com/users/astrofrog/orgs","repos_url":"https://api.github.com/users/astrofrog/repos","events_url":"https://api.github.com/users/astrofrog/events{/privacy}","received_events_url":"https://api.github.com/users/astrofrog/received_events","type":"User","site_admin":false},"repo":{"id":37343171,"name":"qt-helpers","full_name":"astrofrog/qt-helpers","owner":{"login":"astrofrog","id":314716,"avatar_url":"https://avatars.githubusercontent.com/u/314716?v=3","gravatar_id":"","url":"https://api.github.com/users/astrofrog","html_url":"https://github.com/astrofrog","followers_url":"https://api.github.com/users/astrofrog/followers","following_url":"https://api.github.com/users/astrofrog/following{/other_user}","gists_url":"https://api.github.com/users/astrofrog/gists{/gist_id}","starred_url":"https://api.github.com/users/astrofrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astrofrog/subscriptions","organizations_url":"https://api.github.com/users/astrofrog/orgs","repos_url":"https://api.github.com/users/astrofrog/repos","events_url":"https://api.github.com/users/astrofrog/events{/privacy}","received_events_url":"https://api.github.com/users/astrofrog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/astrofrog/qt-helpers","description":"A common front-end to PySide, PyQt4, and PyQt5 (experimental)","fork":true,"url":"https://api.github.com/repos/astrofrog/qt-helpers","forks_url":"https://api.github.com/repos/astrofrog/qt-helpers/forks","keys_url":"https://api.github.com/repos/astrofrog/qt-helpers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astrofrog/qt-helpers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astrofrog/qt-helpers/teams","hooks_url":"https://api.github.com/repos/astrofrog/qt-helpers/hooks","issue_events_url":"https://api.github.com/repos/astrofrog/qt-helpers/issues/events{/number}","events_url":"https://api.github.com/repos/astrofrog/qt-helpers/events","assignees_url":"https://api.github.com/repos/astrofrog/qt-helpers/assignees{/user}","branches_url":"https://api.github.com/repos/astrofrog/qt-helpers/branches{/branch}","tags_url":"https://api.github.com/repos/astrofrog/qt-helpers/tags","blobs_url":"https://api.github.com/repos/astrofrog/qt-helpers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astrofrog/qt-helpers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astrofrog/qt-helpers/git/refs{/sha}","trees_url":"https://api.github.com/repos/astrofrog/qt-helpers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astrofrog/qt-helpers/statuses/{sha}","languages_url":"https://api.github.com/repos/astrofrog/qt-helpers/languages","stargazers_url":"https://api.github.com/repos/astrofrog/qt-helpers/stargazers","contributors_url":"https://api.github.com/repos/astrofrog/qt-helpers/contributors","subscribers_url":"https://api.github.com/repos/astrofrog/qt-helpers/subscribers","subscription_url":"https://api.github.com/repos/astrofrog/qt-helpers/subscription","commits_url":"https://api.github.com/repos/astrofrog/qt-helpers/commits{/sha}","git_commits_url":"https://api.github.com/repos/astrofrog/qt-helpers/git/commits{/sha}","comments_url":"https://api.github.com/repos/astrofrog/qt-helpers/comments{/number}","issue_comment_url":"https://api.github.com/repos/astrofrog/qt-helpers/issues/comments{/number}","contents_url":"https://api.github.com/repos/astrofrog/qt-helpers/contents/{+path}","compare_url":"https://api.github.com/repos/astrofrog/qt-helpers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astrofrog/qt-helpers/merges","archive_url":"https://api.github.com/repos/astrofrog/qt-helpers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astrofrog/qt-helpers/downloads","issues_url":"https://api.github.com/repos/astrofrog/qt-helpers/issues{/number}","pulls_url":"https://api.github.com/repos/astrofrog/qt-helpers/pulls{/number}","milestones_url":"https://api.github.com/repos/astrofrog/qt-helpers/milestones{/number}","notifications_url":"https://api.github.com/repos/astrofrog/qt-helpers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astrofrog/qt-helpers/labels{/name}","releases_url":"https://api.github.com/repos/astrofrog/qt-helpers/releases{/id}","created_at":"2015-06-12T20:31:40Z","updated_at":"2015-06-12T20:31:40Z","pushed_at":"2015-06-16T21:54:24Z","git_url":"git://github.com/astrofrog/qt-helpers.git","ssh_url":"git@github.com:astrofrog/qt-helpers.git","clone_url":"https://github.com/astrofrog/qt-helpers.git","svn_url":"https://github.com/astrofrog/qt-helpers","homepage":null,"size":96,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"glue-viz:master","ref":"master","sha":"d25899f3ca839fadc33905adc011fd51b5e2d4c6","user":{"login":"glue-viz","id":1926209,"avatar_url":"https://avatars.githubusercontent.com/u/1926209?v=3","gravatar_id":"","url":"https://api.github.com/users/glue-viz","html_url":"https://github.com/glue-viz","followers_url":"https://api.github.com/users/glue-viz/followers","following_url":"https://api.github.com/users/glue-viz/following{/other_user}","gists_url":"https://api.github.com/users/glue-viz/gists{/gist_id}","starred_url":"https://api.github.com/users/glue-viz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glue-viz/subscriptions","organizations_url":"https://api.github.com/users/glue-viz/orgs","repos_url":"https://api.github.com/users/glue-viz/repos","events_url":"https://api.github.com/users/glue-viz/events{/privacy}","received_events_url":"https://api.github.com/users/glue-viz/received_events","type":"Organization","site_admin":false},"repo":{"id":35585760,"name":"qt-helpers","full_name":"glue-viz/qt-helpers","owner":{"login":"glue-viz","id":1926209,"avatar_url":"https://avatars.githubusercontent.com/u/1926209?v=3","gravatar_id":"","url":"https://api.github.com/users/glue-viz","html_url":"https://github.com/glue-viz","followers_url":"https://api.github.com/users/glue-viz/followers","following_url":"https://api.github.com/users/glue-viz/following{/other_user}","gists_url":"https://api.github.com/users/glue-viz/gists{/gist_id}","starred_url":"https://api.github.com/users/glue-viz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glue-viz/subscriptions","organizations_url":"https://api.github.com/users/glue-viz/orgs","repos_url":"https://api.github.com/users/glue-viz/repos","events_url":"https://api.github.com/users/glue-viz/events{/privacy}","received_events_url":"https://api.github.com/users/glue-viz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/glue-viz/qt-helpers","description":"A common front-end to PySide, PyQt4, and PyQt5 (experimental)","fork":false,"url":"https://api.github.com/repos/glue-viz/qt-helpers","forks_url":"https://api.github.com/repos/glue-viz/qt-helpers/forks","keys_url":"https://api.github.com/repos/glue-viz/qt-helpers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/glue-viz/qt-helpers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/glue-viz/qt-helpers/teams","hooks_url":"https://api.github.com/repos/glue-viz/qt-helpers/hooks","issue_events_url":"https://api.github.com/repos/glue-viz/qt-helpers/issues/events{/number}","events_url":"https://api.github.com/repos/glue-viz/qt-helpers/events","assignees_url":"https://api.github.com/repos/glue-viz/qt-helpers/assignees{/user}","branches_url":"https://api.github.com/repos/glue-viz/qt-helpers/branches{/branch}","tags_url":"https://api.github.com/repos/glue-viz/qt-helpers/tags","blobs_url":"https://api.github.com/repos/glue-viz/qt-helpers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/glue-viz/qt-helpers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/glue-viz/qt-helpers/git/refs{/sha}","trees_url":"https://api.github.com/repos/glue-viz/qt-helpers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/glue-viz/qt-helpers/statuses/{sha}","languages_url":"https://api.github.com/repos/glue-viz/qt-helpers/languages","stargazers_url":"https://api.github.com/repos/glue-viz/qt-helpers/stargazers","contributors_url":"https://api.github.com/repos/glue-viz/qt-helpers/contributors","subscribers_url":"https://api.github.com/repos/glue-viz/qt-helpers/subscribers","subscription_url":"https://api.github.com/repos/glue-viz/qt-helpers/subscription","commits_url":"https://api.github.com/repos/glue-viz/qt-helpers/commits{/sha}","git_commits_url":"https://api.github.com/repos/glue-viz/qt-helpers/git/commits{/sha}","comments_url":"https://api.github.com/repos/glue-viz/qt-helpers/comments{/number}","issue_comment_url":"https://api.github.com/repos/glue-viz/qt-helpers/issues/comments{/number}","contents_url":"https://api.github.com/repos/glue-viz/qt-helpers/contents/{+path}","compare_url":"https://api.github.com/repos/glue-viz/qt-helpers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/glue-viz/qt-helpers/merges","archive_url":"https://api.github.com/repos/glue-viz/qt-helpers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/glue-viz/qt-helpers/downloads","issues_url":"https://api.github.com/repos/glue-viz/qt-helpers/issues{/number}","pulls_url":"https://api.github.com/repos/glue-viz/qt-helpers/pulls{/number}","milestones_url":"https://api.github.com/repos/glue-viz/qt-helpers/milestones{/number}","notifications_url":"https://api.github.com/repos/glue-viz/qt-helpers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/glue-viz/qt-helpers/labels{/name}","releases_url":"https://api.github.com/repos/glue-viz/qt-helpers/releases{/id}","created_at":"2015-05-14T02:16:38Z","updated_at":"2015-05-14T02:41:21Z","pushed_at":"2015-06-19T16:07:03Z","git_url":"git://github.com/glue-viz/qt-helpers.git","ssh_url":"git@github.com:glue-viz/qt-helpers.git","clone_url":"https://github.com/glue-viz/qt-helpers.git","svn_url":"https://github.com/glue-viz/qt-helpers","homepage":null,"size":172,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/glue-viz/qt-helpers/pulls/3"},"html":{"href":"https://github.com/glue-viz/qt-helpers/pull/3"},"issue":{"href":"https://api.github.com/repos/glue-viz/qt-helpers/issues/3"},"comments":{"href":"https://api.github.com/repos/glue-viz/qt-helpers/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/glue-viz/qt-helpers/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/glue-viz/qt-helpers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/glue-viz/qt-helpers/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/glue-viz/qt-helpers/statuses/a6074f5e7f956122e75f2a7500c9a14ab2871e8e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"astrofrog","id":314716,"avatar_url":"https://avatars.githubusercontent.com/u/314716?v=3","gravatar_id":"","url":"https://api.github.com/users/astrofrog","html_url":"https://github.com/astrofrog","followers_url":"https://api.github.com/users/astrofrog/followers","following_url":"https://api.github.com/users/astrofrog/following{/other_user}","gists_url":"https://api.github.com/users/astrofrog/gists{/gist_id}","starred_url":"https://api.github.com/users/astrofrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astrofrog/subscriptions","organizations_url":"https://api.github.com/users/astrofrog/orgs","repos_url":"https://api.github.com/users/astrofrog/repos","events_url":"https://api.github.com/users/astrofrog/events{/privacy}","received_events_url":"https://api.github.com/users/astrofrog/received_events","type":"User","site_admin":false},"comments":8,"review_comments":4,"commits":13,"additions":315,"deletions":61,"changed_files":6}}