{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/27093274","id":27093274,"diff_hunk":"@@ -254,25 +250,27 @@ public GeoPointFieldMapper build(BuilderContext context) {\n                     }\n                     iterator.remove();\n                 } else if (fieldName.equals(\"validate\")) {\n-                    builder.validateLat = XContentMapValues.nodeBooleanValue(fieldNode);\n-                    builder.validateLon = XContentMapValues.nodeBooleanValue(fieldNode);\n+                    builder.validate = XContentMapValues.nodeBooleanValue(fieldNode);\n                     iterator.remove();\n                 } else if (fieldName.equals(\"validate_lon\")) {\n-                    builder.validateLon = XContentMapValues.nodeBooleanValue(fieldNode);\n-                    iterator.remove();\n+                    if (parserContext.indexVersionCreated().onOrAfter(Version.V_1_6_0)) {","path":"src/main/java/org/elasticsearch/index/mapper/geo/GeoPointFieldMapper.java","position":55,"original_position":55,"commit_id":"9062f68ee7f447ffbae6a491ddb65ca28a69e35b","original_commit_id":"9062f68ee7f447ffbae6a491ddb65ca28a69e35b","user":{"login":"rjernst","id":289412,"avatar_url":"https://avatars.githubusercontent.com/u/289412?v=3","gravatar_id":"","url":"https://api.github.com/users/rjernst","html_url":"https://github.com/rjernst","followers_url":"https://api.github.com/users/rjernst/followers","following_url":"https://api.github.com/users/rjernst/following{/other_user}","gists_url":"https://api.github.com/users/rjernst/gists{/gist_id}","starred_url":"https://api.github.com/users/rjernst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjernst/subscriptions","organizations_url":"https://api.github.com/users/rjernst/orgs","repos_url":"https://api.github.com/users/rjernst/repos","events_url":"https://api.github.com/users/rjernst/events{/privacy}","received_events_url":"https://api.github.com/users/rjernst/received_events","type":"User","site_admin":false},"body":"Given how we've done other deprecations and removals, I think we need to maintain backcompat for at least reading and ignoring these settings in 2.0? Also, I think it is better to add move the version check to the `else if` and invert, then have a comment like `// ignore legacy setting` inside the block.  For newer indexes, the setting would fall through and show up as an unknown setting.","created_at":"2015-03-25T03:44:08Z","updated_at":"2015-03-25T03:44:08Z","html_url":"https://github.com/elastic/elasticsearch/pull/10248#discussion_r27093274","pull_request_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/10248","_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/27093274"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/10248#discussion_r27093274"},"pull_request":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/10248"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/10248","id":31888736,"html_url":"https://github.com/elastic/elasticsearch/pull/10248","diff_url":"https://github.com/elastic/elasticsearch/pull/10248.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/10248.patch","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/10248","number":10248,"state":"open","locked":false,"title":"[GEO] Deprecate validate_* and normalize_*","user":{"login":"nknize","id":830187,"avatar_url":"https://avatars.githubusercontent.com/u/830187?v=3","gravatar_id":"","url":"https://api.github.com/users/nknize","html_url":"https://github.com/nknize","followers_url":"https://api.github.com/users/nknize/followers","following_url":"https://api.github.com/users/nknize/following{/other_user}","gists_url":"https://api.github.com/users/nknize/gists{/gist_id}","starred_url":"https://api.github.com/users/nknize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nknize/subscriptions","organizations_url":"https://api.github.com/users/nknize/orgs","repos_url":"https://api.github.com/users/nknize/repos","events_url":"https://api.github.com/users/nknize/events{/privacy}","received_events_url":"https://api.github.com/users/nknize/received_events","type":"User","site_admin":false},"body":"No need to carry 3 validate and 3 normalize options in GeoPointFieldMapping. This is just causing confusion. This change deprecates the validate_lat, validate_lon, normalize_lat, and normalize_lon options on the ```geo_point``` field mapping and simplifies the options by using just ```validate``` and ```normalize```, respectively. Geo filters have been updated to include a ```validate``` and ```normalize``` option to provide consistency with the field mapping defaults. Unit tests and documentation have also been updated.\r\n\r\ncloses #10170","created_at":"2015-03-25T02:38:10Z","updated_at":"2015-03-25T03:44:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"29485226f5985fe27fa33b57d9eed0b54143853d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/10248/commits","review_comments_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/10248/comments","review_comment_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/10248/comments","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/9062f68ee7f447ffbae6a491ddb65ca28a69e35b","head":{"label":"nknize:deprecation/10170","ref":"deprecation/10170","sha":"9062f68ee7f447ffbae6a491ddb65ca28a69e35b","user":{"login":"nknize","id":830187,"avatar_url":"https://avatars.githubusercontent.com/u/830187?v=3","gravatar_id":"","url":"https://api.github.com/users/nknize","html_url":"https://github.com/nknize","followers_url":"https://api.github.com/users/nknize/followers","following_url":"https://api.github.com/users/nknize/following{/other_user}","gists_url":"https://api.github.com/users/nknize/gists{/gist_id}","starred_url":"https://api.github.com/users/nknize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nknize/subscriptions","organizations_url":"https://api.github.com/users/nknize/orgs","repos_url":"https://api.github.com/users/nknize/repos","events_url":"https://api.github.com/users/nknize/events{/privacy}","received_events_url":"https://api.github.com/users/nknize/received_events","type":"User","site_admin":false},"repo":{"id":25872473,"name":"elasticsearch","full_name":"nknize/elasticsearch","owner":{"login":"nknize","id":830187,"avatar_url":"https://avatars.githubusercontent.com/u/830187?v=3","gravatar_id":"","url":"https://api.github.com/users/nknize","html_url":"https://github.com/nknize","followers_url":"https://api.github.com/users/nknize/followers","following_url":"https://api.github.com/users/nknize/following{/other_user}","gists_url":"https://api.github.com/users/nknize/gists{/gist_id}","starred_url":"https://api.github.com/users/nknize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nknize/subscriptions","organizations_url":"https://api.github.com/users/nknize/orgs","repos_url":"https://api.github.com/users/nknize/repos","events_url":"https://api.github.com/users/nknize/events{/privacy}","received_events_url":"https://api.github.com/users/nknize/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nknize/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/nknize/elasticsearch","forks_url":"https://api.github.com/repos/nknize/elasticsearch/forks","keys_url":"https://api.github.com/repos/nknize/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nknize/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nknize/elasticsearch/teams","hooks_url":"https://api.github.com/repos/nknize/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/nknize/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/nknize/elasticsearch/events","assignees_url":"https://api.github.com/repos/nknize/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/nknize/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/nknize/elasticsearch/tags","blobs_url":"https://api.github.com/repos/nknize/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nknize/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nknize/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/nknize/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nknize/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/nknize/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/nknize/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/nknize/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/nknize/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/nknize/elasticsearch/subscription","commits_url":"https://api.github.com/repos/nknize/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/nknize/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/nknize/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/nknize/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/nknize/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/nknize/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nknize/elasticsearch/merges","archive_url":"https://api.github.com/repos/nknize/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nknize/elasticsearch/downloads","issues_url":"https://api.github.com/repos/nknize/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/nknize/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/nknize/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/nknize/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nknize/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/nknize/elasticsearch/releases{/id}","created_at":"2014-10-28T14:11:03Z","updated_at":"2015-01-23T17:50:14Z","pushed_at":"2015-03-25T02:32:50Z","git_url":"git://github.com/nknize/elasticsearch.git","ssh_url":"git@github.com:nknize/elasticsearch.git","clone_url":"https://github.com/nknize/elasticsearch.git","svn_url":"https://github.com/nknize/elasticsearch","homepage":"http://elasticsearch.org","size":91881,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"90dfd78267e1a04a427ba51b75c44a5fb041c568","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"name":"elasticsearch","full_name":"elastic/elasticsearch","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elastic/elasticsearch","forks_url":"https://api.github.com/repos/elastic/elasticsearch/forks","keys_url":"https://api.github.com/repos/elastic/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elastic/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/elasticsearch/events","assignees_url":"https://api.github.com/repos/elastic/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elastic/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elastic/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elastic/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elastic/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elastic/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elastic/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/elasticsearch/merges","archive_url":"https://api.github.com/repos/elastic/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elastic/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elastic/elasticsearch/releases{/id}","created_at":"2010-02-08T13:20:56Z","updated_at":"2015-03-25T02:50:08Z","pushed_at":"2015-03-25T03:23:30Z","git_url":"git://github.com/elastic/elasticsearch.git","ssh_url":"git@github.com:elastic/elasticsearch.git","clone_url":"https://github.com/elastic/elasticsearch.git","svn_url":"https://github.com/elastic/elasticsearch","homepage":"http://elasticsearch.org","size":297803,"stargazers_count":10475,"watchers_count":10475,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3250,"mirror_url":null,"open_issues_count":1053,"forks":3250,"open_issues":1053,"watchers":10475,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/10248"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/10248"},"issue":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/10248"},"comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/10248/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/10248/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/10248/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/elasticsearch/statuses/9062f68ee7f447ffbae6a491ddb65ca28a69e35b"}}}}