{"action":"created","issue":{"url":"https://api.github.com/repos/git-for-windows/git/issues/27","labels_url":"https://api.github.com/repos/git-for-windows/git/issues/27/labels{/name}","comments_url":"https://api.github.com/repos/git-for-windows/git/issues/27/comments","events_url":"https://api.github.com/repos/git-for-windows/git/issues/27/events","html_url":"https://github.com/git-for-windows/git/pull/27","id":58606145,"number":27,"title":"Update to 2.3.0","user":{"login":"dscho","id":127790,"avatar_url":"https://avatars.githubusercontent.com/u/127790?v=3","gravatar_id":"","url":"https://api.github.com/users/dscho","html_url":"https://github.com/dscho","followers_url":"https://api.github.com/users/dscho/followers","following_url":"https://api.github.com/users/dscho/following{/other_user}","gists_url":"https://api.github.com/users/dscho/gists{/gist_id}","starred_url":"https://api.github.com/users/dscho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dscho/subscriptions","organizations_url":"https://api.github.com/users/dscho/orgs","repos_url":"https://api.github.com/users/dscho/repos","events_url":"https://api.github.com/users/dscho/events{/privacy}","received_events_url":"https://api.github.com/users/dscho/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":45,"created_at":"2015-02-23T16:02:31Z","updated_at":"2015-03-05T06:45:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/git-for-windows/git/pulls/27","html_url":"https://github.com/git-for-windows/git/pull/27","diff_url":"https://github.com/git-for-windows/git/pull/27.diff","patch_url":"https://github.com/git-for-windows/git/pull/27.patch"},"body":"This updates our code base to Git 2.3.0."},"comment":{"url":"https://api.github.com/repos/git-for-windows/git/issues/comments/77315307","html_url":"https://github.com/git-for-windows/git/pull/27#issuecomment-77315307","issue_url":"https://api.github.com/repos/git-for-windows/git/issues/27","id":77315307,"user":{"login":"nalla","id":688191,"avatar_url":"https://avatars.githubusercontent.com/u/688191?v=3","gravatar_id":"","url":"https://api.github.com/users/nalla","html_url":"https://github.com/nalla","followers_url":"https://api.github.com/users/nalla/followers","following_url":"https://api.github.com/users/nalla/following{/other_user}","gists_url":"https://api.github.com/users/nalla/gists{/gist_id}","starred_url":"https://api.github.com/users/nalla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nalla/subscriptions","organizations_url":"https://api.github.com/users/nalla/orgs","repos_url":"https://api.github.com/users/nalla/repos","events_url":"https://api.github.com/users/nalla/events{/privacy}","received_events_url":"https://api.github.com/users/nalla/received_events","type":"User","site_admin":false},"created_at":"2015-03-05T06:45:40Z","updated_at":"2015-03-05T06:45:40Z","body":"> Could you mark the respective test case with a prereq !MINGW\r\n\r\nSince the test cases seems to depend on each other. I could not remove the first test (repo setup) without breaking the rest. The following patch archived a green test.\r\n```patch\r\ndiff --git a/t/t9118-git-svn-funky-branch-names.sh b/t/t9118-git-svn-funky-branch-names.sh\r\nindex ed4d136..29a3dc3 100755\r\n--- a/t/t9118-git-svn-funky-branch-names.sh\r\n+++ b/t/t9118-git-svn-funky-branch-names.sh\r\n@@ -23,8 +23,6 @@ test_expect_success 'setup svnrepo' '\r\n                      \"$svnrepo/pr ject/branches/$scary_uri\" &&\r\n        svn_cmd cp -m \"leading dot\" \"$svnrepo/pr ject/trunk\" \\\r\n                        \"$svnrepo/pr ject/branches/.leading_dot\" &&\r\n-       svn_cmd cp -m \"trailing dot\" \"$svnrepo/pr ject/trunk\" \\\r\n-                       \"$svnrepo/pr ject/branches/trailing_dot.\" &&\r\n        svn_cmd cp -m \"trailing .lock\" \"$svnrepo/pr ject/trunk\" \\\r\n                        \"$svnrepo/pr ject/branches/trailing_dotlock.lock\" &&\r\n        svn_cmd cp -m \"reflog\" \"$svnrepo/pr ject/trunk\" \\\r\n@@ -45,7 +43,6 @@ test_expect_success 'test clone with funky branch names' '\r\n                git rev-parse \"refs/remotes/origin/more%20fun%20plugin!\" &&\r\n                git rev-parse \"refs/remotes/origin/$scary_ref\" &&\r\n                git rev-parse \"refs/remotes/origin/%2Eleading_dot\" &&\r\n-               git rev-parse \"refs/remotes/origin/trailing_dot%2E\" &&\r\n                git rev-parse \"refs/remotes/origin/trailing_dotlock%2Elock\" &&\r\n                git rev-parse \"refs/remotes/origin/$non_reflog\"\r\n        )\r\n```\r\n> or by un-overriding pwd on MinGW as I did it...\r\n\r\nThat did not work, the `pwd` seems not to be used (`test x\"$HOME\"/svn-authors = x\"$(git config svn.authorsfile)\"`). I went with `!MINGW`.\r\n```patch\r\ndiff --git a/t/t9130-git-svn-authors-file.sh b/t/t9130-git-svn-authors-file.sh\r\nindex c44de26..0a9cd87 100755\r\n--- a/t/t9130-git-svn-authors-file.sh\r\n+++ b/t/t9130-git-svn-authors-file.sh\r\n@@ -91,7 +91,7 @@ test_expect_success 'fetch continues after authors-file is fixed' '\r\n        )\r\n        '\r\n\r\n-test_expect_success 'fresh clone with svn.authors-file in config' '\r\n+test_expect_success !MINGW 'fresh clone with svn.authors-file in config' '\r\n        (\r\n                rm -r \"$GIT_DIR\" &&\r\n                test x = x\"$(git config svn.authorsfile)\" &&\r\n```\r\n> It might be better to make the `chmod` itself conditional on `test_have_prereq POSIXPERM`\r\n\r\nSince the test cases are once again dependent on each other, I modified the test itself again.\r\n```patch\r\ndiff --git a/t/t9124-git-svn-dcommit-auto-props.sh b/t/t9124-git-svn-dcommit-auto-props.sh\r\nindex aa841e1..411a225 100755\r\n--- a/t/t9124-git-svn-dcommit-auto-props.sh\r\n+++ b/t/t9124-git-svn-dcommit-auto-props.sh\r\n@@ -35,7 +35,6 @@ test_expect_success 'enable auto-props config' '\r\n\r\n test_expect_success 'add files matching auto-props' '\r\n        echo \"#!$SHELL_PATH\" >exec1.sh &&\r\n-       chmod +x exec1.sh &&\r\n        echo \"hello\" >hello.txt &&\r\n        echo bar >bar &&\r\n        git add exec1.sh hello.txt bar &&\r\n@@ -49,7 +48,6 @@ test_expect_success 'disable auto-props config' '\r\n\r\n test_expect_success 'add files matching disabled auto-props' '\r\n        echo \"#$SHELL_PATH\" >exec2.sh &&\r\n-       chmod +x exec2.sh &&\r\n        echo \"world\" >world.txt &&\r\n        echo zot >zot &&\r\n        git add exec2.sh world.txt zot &&\r\n@@ -65,7 +63,6 @@ test_expect_success 'check resulting svn repository' '\r\n        cd svnrepo &&\r\n\r\n        # Check properties from first commit.\r\n-       test \"x$(svn_cmd propget svn:executable exec1.sh)\" = \"x*\" &&\r\n        test \"x$(svn_cmd propget svn:mime-type exec1.sh)\" = \\\r\n             \"xapplication/x-shellscript\" &&\r\n        test \"x$(svn_cmd propget svn:mime-type hello.txt)\" = \"xtext/plain\" &&\r\n@@ -73,7 +70,6 @@ test_expect_success 'check resulting svn repository' '\r\n        test \"x$(svn_cmd propget svn:mime-type bar)\" = \"x\" &&\r\n\r\n        # Check properties from second commit.\r\n-       test \"x$(svn_cmd propget svn:executable exec2.sh)\" = \"x*\" &&\r\n        test \"x$(svn_cmd propget svn:mime-type exec2.sh)\" = \"x\" &&\r\n        test \"x$(svn_cmd propget svn:mime-type world.txt)\" = \"x\" &&\r\n        test \"x$(svn_cmd propget svn:eol-style world.txt)\" = \"x\" &&\r\n```\r\n\r\nWith `t9100` I still have issues. Everything is depending on each other :unamused:.\r\n\r\nIn general, what are the guidelines for this? Should a test be altered? How? Or add another one side by side? one with `!MINGW` and one with `MINGW`?"}}