{"action":"created","issue":{"url":"https://api.github.com/repos/CGAL/cgal/issues/152","labels_url":"https://api.github.com/repos/CGAL/cgal/issues/152/labels{/name}","comments_url":"https://api.github.com/repos/CGAL/cgal/issues/152/comments","events_url":"https://api.github.com/repos/CGAL/cgal/issues/152/events","html_url":"https://github.com/CGAL/cgal/issues/152","id":92369602,"number":152,"title":"CMP0043 with CMake>=3.0.2 when Qt5 is used","user":{"login":"lrineau","id":5746675,"avatar_url":"https://avatars.githubusercontent.com/u/5746675?v=3","gravatar_id":"","url":"https://api.github.com/users/lrineau","html_url":"https://github.com/lrineau","followers_url":"https://api.github.com/users/lrineau/followers","following_url":"https://api.github.com/users/lrineau/following{/other_user}","gists_url":"https://api.github.com/users/lrineau/gists{/gist_id}","starred_url":"https://api.github.com/users/lrineau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrineau/subscriptions","organizations_url":"https://api.github.com/users/lrineau/orgs","repos_url":"https://api.github.com/users/lrineau/repos","events_url":"https://api.github.com/users/lrineau/events{/privacy}","received_events_url":"https://api.github.com/users/lrineau/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/CGAL/cgal/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/CGAL/cgal/labels/CMake%20scripts","name":"CMake scripts","color":"bfe5bf"}],"state":"open","locked":false,"assignee":{"login":"lrineau","id":5746675,"avatar_url":"https://avatars.githubusercontent.com/u/5746675?v=3","gravatar_id":"","url":"https://api.github.com/users/lrineau","html_url":"https://github.com/lrineau","followers_url":"https://api.github.com/users/lrineau/followers","following_url":"https://api.github.com/users/lrineau/following{/other_user}","gists_url":"https://api.github.com/users/lrineau/gists{/gist_id}","starred_url":"https://api.github.com/users/lrineau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrineau/subscriptions","organizations_url":"https://api.github.com/users/lrineau/orgs","repos_url":"https://api.github.com/users/lrineau/repos","events_url":"https://api.github.com/users/lrineau/events{/privacy}","received_events_url":"https://api.github.com/users/lrineau/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/CGAL/cgal/milestones/2","html_url":"https://github.com/CGAL/cgal/milestones/4.7-beta","labels_url":"https://api.github.com/repos/CGAL/cgal/milestones/2/labels","id":1012212,"number":2,"title":"4.7-beta","description":"First beta of CGAL version 4.7\r\n\r\nhttps://cgal.geometryfactory.com/CGAL/Members/wiki/Releases/4.7\r\n\r\nInitial schedule:\r\n2015-05-01 \tFeature freeze\r\n2015-07-01 \tCode freeze\r\n2015-07-20 \tBeta release\r\n2015-09-15 \tFinal release \r\n","creator":{"login":"lrineau","id":5746675,"avatar_url":"https://avatars.githubusercontent.com/u/5746675?v=3","gravatar_id":"","url":"https://api.github.com/users/lrineau","html_url":"https://github.com/lrineau","followers_url":"https://api.github.com/users/lrineau/followers","following_url":"https://api.github.com/users/lrineau/following{/other_user}","gists_url":"https://api.github.com/users/lrineau/gists{/gist_id}","starred_url":"https://api.github.com/users/lrineau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrineau/subscriptions","organizations_url":"https://api.github.com/users/lrineau/orgs","repos_url":"https://api.github.com/users/lrineau/repos","events_url":"https://api.github.com/users/lrineau/events{/privacy}","received_events_url":"https://api.github.com/users/lrineau/received_events","type":"User","site_admin":false},"open_issues":26,"closed_issues":44,"state":"open","created_at":"2015-03-09T11:19:24Z","updated_at":"2015-07-06T07:57:48Z","due_on":"2015-07-19T22:00:00Z","closed_at":null},"comments":9,"created_at":"2015-07-01T12:28:53Z","updated_at":"2015-07-07T12:19:51Z","closed_at":null,"body":"http://www.cmake.org/cmake/help/v3.0/policy/CMP0043.html\r\n\r\nIn the macro `macro(qt5_use_modules _target _link_type)` from `/usr/lib64/cmake/Qt5Core/Qt5CoreMacros.cmake` on Fedora 21, with the RPM `qt5-qtbase-devel-5.4.2-1.fc21.x86_64`, line 281:\r\n```\r\n            set_property(TARGET ${_target} APPEND PROPERTY COMPILE_DEFINITIONS_RELEASE QT_NO_DEBUG)\r\n            set_property(TARGET ${_target} APPEND PROPERTY COMPILE_DEFINITIONS_RELWITHDEBINFO QT_NO_DEBUG)\r\n            set_property(TARGET ${_target} APPEND PROPERTY COMPILE_DEFINITIONS_MINSIZEREL QT_NO_DEBUG)\r\n\r\n```\r\nI think all `CMakeLists.txt` of all Qt5 demos should specify:\r\n```\r\nif(POLICY CMP0043)\r\n  # Do not ignore `COMPILE_DEFINITIONS_<Config>` properties\r\n  #   defined by `qt5_use_modules`, in Qt5CoreMacros.cmake\r\n  # http://www.cmake.org/cmake/help/v3.0/policy/CMP0043.html\r\n  cmake_policy(SET CMP0043 OLD)\r\nendif()\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/CGAL/cgal/issues/comments/119188136","html_url":"https://github.com/CGAL/cgal/issues/152#issuecomment-119188136","issue_url":"https://api.github.com/repos/CGAL/cgal/issues/152","id":119188136,"user":{"login":"bo0ts","id":76102,"avatar_url":"https://avatars.githubusercontent.com/u/76102?v=3","gravatar_id":"","url":"https://api.github.com/users/bo0ts","html_url":"https://github.com/bo0ts","followers_url":"https://api.github.com/users/bo0ts/followers","following_url":"https://api.github.com/users/bo0ts/following{/other_user}","gists_url":"https://api.github.com/users/bo0ts/gists{/gist_id}","starred_url":"https://api.github.com/users/bo0ts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bo0ts/subscriptions","organizations_url":"https://api.github.com/users/bo0ts/orgs","repos_url":"https://api.github.com/users/bo0ts/repos","events_url":"https://api.github.com/users/bo0ts/events{/privacy}","received_events_url":"https://api.github.com/users/bo0ts/received_events","type":"User","site_admin":false},"created_at":"2015-07-07T12:19:51Z","updated_at":"2015-07-07T12:19:51Z","body":":+1: "}}