{"action":"created","comment":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/37276141","id":37276141,"diff_hunk":"@@ -43,26 +41,56 @@\n     boolean booleanValue();\n \n     /**\n+     * @return the long value of the current property\n+     * @throws IllegalStateException if current property is not a long number\n+     */\n+    byte byteValue();\n+\n+    /**\n+     * @return the long value of the current property\n+     * @throws IllegalStateException if current property is not a long number\n+     */\n+    short shortValue();\n+\n+    /**\n      * @return the integer value of the current property\n-     * @throws IllegalStateException if current property is not an integer number\n+     * @throws IllegalStateException if current property is not a integer number\n+     */\n+    int intValue();\n+\n+    /**\n+     * @return the long value of the current property\n+     * @throws IllegalStateException if current property is not a long number\n      */\n     long longValue();\n \n     /**\n-     * @return the real value of the current property\n-     * @throws IllegalStateException if current property is not a real number\n+     * @return the float value of the current property\n+     * @throws IllegalStateException if current property is not a float number\n+     */\n+    float floatValue();\n+\n+    /**\n+     * @return the double value of the current property\n+     * @throws IllegalStateException if current property is not a double number\n      */\n     double doubleValue();\n \n     /**\n+     * @return the char value of the current property\n+     * @throws IllegalStateException if current property is not a char\n+     */\n+    char charValue();\n+\n+    /**\n      * @return the string value of the current property\n+     * @throws IllegalStateException if current property is not a string\n      */\n     String stringValue();\n \n     /**\n-     * The byte array data of the current value.\n-     *\n-     * @param channel to write the data into\n+     * @return the array value of the current property\n+     * @throws IllegalStateException if current property is not an array\n      */\n-    void byteArray( WritableByteChannel channel );\n+    Object arrayValue();","path":"community/kernel/src/main/java/org/neo4j/kernel/api/cursor/PropertyItem.java","position":71,"original_position":71,"commit_id":"8097fbba8d4041ee207d35ad160f5e449a712dc0","original_commit_id":"8097fbba8d4041ee207d35ad160f5e449a712dc0","user":{"login":"lutovich","id":1638145,"avatar_url":"https://avatars.githubusercontent.com/u/1638145?v=3","gravatar_id":"","url":"https://api.github.com/users/lutovich","html_url":"https://github.com/lutovich","followers_url":"https://api.github.com/users/lutovich/followers","following_url":"https://api.github.com/users/lutovich/following{/other_user}","gists_url":"https://api.github.com/users/lutovich/gists{/gist_id}","starred_url":"https://api.github.com/users/lutovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lutovich/subscriptions","organizations_url":"https://api.github.com/users/lutovich/orgs","repos_url":"https://api.github.com/users/lutovich/repos","events_url":"https://api.github.com/users/lutovich/events{/privacy}","received_events_url":"https://api.github.com/users/lutovich/received_events","type":"User","site_admin":false},"body":"Would it be valuable to have specialized methods for different array types?\r\nE.g. `int[] intArrayValue()`, `long[] longArrayValue()`","created_at":"2015-08-18T08:42:45Z","updated_at":"2015-08-18T08:42:45Z","html_url":"https://github.com/neo4j/neo4j/pull/5164#discussion_r37276141","pull_request_url":"https://api.github.com/repos/neo4j/neo4j/pulls/5164","_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/37276141"},"html":{"href":"https://github.com/neo4j/neo4j/pull/5164#discussion_r37276141"},"pull_request":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/5164"}}},"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/5164","id":42601401,"html_url":"https://github.com/neo4j/neo4j/pull/5164","diff_url":"https://github.com/neo4j/neo4j/pull/5164.diff","patch_url":"https://github.com/neo4j/neo4j/pull/5164.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/5164","number":5164,"state":"open","locked":false,"title":"Make StorePropertyCursor work","user":{"login":"davidegrohmann","id":6573166,"avatar_url":"https://avatars.githubusercontent.com/u/6573166?v=3","gravatar_id":"","url":"https://api.github.com/users/davidegrohmann","html_url":"https://github.com/davidegrohmann","followers_url":"https://api.github.com/users/davidegrohmann/followers","following_url":"https://api.github.com/users/davidegrohmann/following{/other_user}","gists_url":"https://api.github.com/users/davidegrohmann/gists{/gist_id}","starred_url":"https://api.github.com/users/davidegrohmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidegrohmann/subscriptions","organizations_url":"https://api.github.com/users/davidegrohmann/orgs","repos_url":"https://api.github.com/users/davidegrohmann/repos","events_url":"https://api.github.com/users/davidegrohmann/events{/privacy}","received_events_url":"https://api.github.com/users/davidegrohmann/received_events","type":"User","site_admin":false},"body":"Bug fixed:\r\n- verify shouldRetry when reading from a cursor\r\n- avoid buffer overflow when reading long string\r\n- should throw NotFoundException when there are no\r\n  blocks in the record, i.e. the record is not in use\r\n- read values multiple times from the PropertyItem\r\n- do not leak big ByteBuffer before cursor usages\r\n\r\nSimplify code by removing never used API for writing bytes directly\r\ninto a WritableChannel.\r\n\r\nAdded unit tests","created_at":"2015-08-17T15:35:04Z","updated_at":"2015-08-18T08:42:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"64643fc66ae3bcb61d72849e7a52ec582a926c5d","assignee":{"login":"rickardoberg","id":461300,"avatar_url":"https://avatars.githubusercontent.com/u/461300?v=3","gravatar_id":"","url":"https://api.github.com/users/rickardoberg","html_url":"https://github.com/rickardoberg","followers_url":"https://api.github.com/users/rickardoberg/followers","following_url":"https://api.github.com/users/rickardoberg/following{/other_user}","gists_url":"https://api.github.com/users/rickardoberg/gists{/gist_id}","starred_url":"https://api.github.com/users/rickardoberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rickardoberg/subscriptions","organizations_url":"https://api.github.com/users/rickardoberg/orgs","repos_url":"https://api.github.com/users/rickardoberg/repos","events_url":"https://api.github.com/users/rickardoberg/events{/privacy}","received_events_url":"https://api.github.com/users/rickardoberg/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j/pulls/5164/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j/pulls/5164/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/5164/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/8097fbba8d4041ee207d35ad160f5e449a712dc0","head":{"label":"davidegrohmann:2.3-fix-store-property-cursor","ref":"2.3-fix-store-property-cursor","sha":"8097fbba8d4041ee207d35ad160f5e449a712dc0","user":{"login":"davidegrohmann","id":6573166,"avatar_url":"https://avatars.githubusercontent.com/u/6573166?v=3","gravatar_id":"","url":"https://api.github.com/users/davidegrohmann","html_url":"https://github.com/davidegrohmann","followers_url":"https://api.github.com/users/davidegrohmann/followers","following_url":"https://api.github.com/users/davidegrohmann/following{/other_user}","gists_url":"https://api.github.com/users/davidegrohmann/gists{/gist_id}","starred_url":"https://api.github.com/users/davidegrohmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidegrohmann/subscriptions","organizations_url":"https://api.github.com/users/davidegrohmann/orgs","repos_url":"https://api.github.com/users/davidegrohmann/repos","events_url":"https://api.github.com/users/davidegrohmann/events{/privacy}","received_events_url":"https://api.github.com/users/davidegrohmann/received_events","type":"User","site_admin":false},"repo":{"id":16693960,"name":"neo4j","full_name":"davidegrohmann/neo4j","owner":{"login":"davidegrohmann","id":6573166,"avatar_url":"https://avatars.githubusercontent.com/u/6573166?v=3","gravatar_id":"","url":"https://api.github.com/users/davidegrohmann","html_url":"https://github.com/davidegrohmann","followers_url":"https://api.github.com/users/davidegrohmann/followers","following_url":"https://api.github.com/users/davidegrohmann/following{/other_user}","gists_url":"https://api.github.com/users/davidegrohmann/gists{/gist_id}","starred_url":"https://api.github.com/users/davidegrohmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidegrohmann/subscriptions","organizations_url":"https://api.github.com/users/davidegrohmann/orgs","repos_url":"https://api.github.com/users/davidegrohmann/repos","events_url":"https://api.github.com/users/davidegrohmann/events{/privacy}","received_events_url":"https://api.github.com/users/davidegrohmann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidegrohmann/neo4j","description":"The World's Leading Graph Database","fork":true,"url":"https://api.github.com/repos/davidegrohmann/neo4j","forks_url":"https://api.github.com/repos/davidegrohmann/neo4j/forks","keys_url":"https://api.github.com/repos/davidegrohmann/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidegrohmann/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidegrohmann/neo4j/teams","hooks_url":"https://api.github.com/repos/davidegrohmann/neo4j/hooks","issue_events_url":"https://api.github.com/repos/davidegrohmann/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/davidegrohmann/neo4j/events","assignees_url":"https://api.github.com/repos/davidegrohmann/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/davidegrohmann/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/davidegrohmann/neo4j/tags","blobs_url":"https://api.github.com/repos/davidegrohmann/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidegrohmann/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidegrohmann/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidegrohmann/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidegrohmann/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/davidegrohmann/neo4j/languages","stargazers_url":"https://api.github.com/repos/davidegrohmann/neo4j/stargazers","contributors_url":"https://api.github.com/repos/davidegrohmann/neo4j/contributors","subscribers_url":"https://api.github.com/repos/davidegrohmann/neo4j/subscribers","subscription_url":"https://api.github.com/repos/davidegrohmann/neo4j/subscription","commits_url":"https://api.github.com/repos/davidegrohmann/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidegrohmann/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidegrohmann/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidegrohmann/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidegrohmann/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/davidegrohmann/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidegrohmann/neo4j/merges","archive_url":"https://api.github.com/repos/davidegrohmann/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidegrohmann/neo4j/downloads","issues_url":"https://api.github.com/repos/davidegrohmann/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/davidegrohmann/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/davidegrohmann/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/davidegrohmann/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidegrohmann/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/davidegrohmann/neo4j/releases{/id}","created_at":"2014-02-10T11:59:43Z","updated_at":"2014-06-19T09:04:32Z","pushed_at":"2015-08-17T15:34:12Z","git_url":"git://github.com/davidegrohmann/neo4j.git","ssh_url":"git@github.com:davidegrohmann/neo4j.git","clone_url":"https://github.com/davidegrohmann/neo4j.git","svn_url":"https://github.com/davidegrohmann/neo4j","homepage":"http://neo4j.org","size":205491,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neo4j:2.3","ref":"2.3","sha":"2ec98c33918c3eef4f14a9b72de17e838e47b849","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":6650539,"name":"neo4j","full_name":"neo4j/neo4j","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j","description":"Graphs for Everyone","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j","forks_url":"https://api.github.com/repos/neo4j/neo4j/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j/releases{/id}","created_at":"2012-11-12T08:46:15Z","updated_at":"2015-08-18T05:54:25Z","pushed_at":"2015-08-18T08:23:19Z","git_url":"git://github.com/neo4j/neo4j.git","ssh_url":"git@github.com:neo4j/neo4j.git","clone_url":"https://github.com/neo4j/neo4j.git","svn_url":"https://github.com/neo4j/neo4j","homepage":"http://neo4j.com","size":481425,"stargazers_count":1885,"watchers_count":1885,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":729,"mirror_url":null,"open_issues_count":466,"forks":729,"open_issues":466,"watchers":1885,"default_branch":"2.3"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/5164"},"html":{"href":"https://github.com/neo4j/neo4j/pull/5164"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/5164"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/5164/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/5164/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/5164/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j/statuses/8097fbba8d4041ee207d35ad160f5e449a712dc0"}}}}