{"action":"created","comment":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/38663781","id":38663781,"diff_hunk":"@@ -18986,17 +18991,28 @@ bool Player::CheckInstanceLoginValid()\n     {\n         // cannot be in raid instance without a group\n         if (!GetGroup())\n-            return false;\n+            return IsInstanceLoginGameMasterException();","path":"src/server/game/Entities/Player/Player.cpp","position":17,"original_position":17,"commit_id":"7d757d15e68ecbf9bc787d453ddd3ff8cabee412","original_commit_id":"7d757d15e68ecbf9bc787d453ddd3ff8cabee412","user":{"login":"joschiwald","id":736792,"avatar_url":"https://avatars.githubusercontent.com/u/736792?v=3","gravatar_id":"","url":"https://api.github.com/users/joschiwald","html_url":"https://github.com/joschiwald","followers_url":"https://api.github.com/users/joschiwald/followers","following_url":"https://api.github.com/users/joschiwald/following{/other_user}","gists_url":"https://api.github.com/users/joschiwald/gists{/gist_id}","starred_url":"https://api.github.com/users/joschiwald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joschiwald/subscriptions","organizations_url":"https://api.github.com/users/joschiwald/orgs","repos_url":"https://api.github.com/users/joschiwald/repos","events_url":"https://api.github.com/users/joschiwald/events{/privacy}","received_events_url":"https://api.github.com/users/joschiwald/received_events","type":"User","site_admin":false},"body":"if player has gm command you will bypass all other checks, so i don't think this is not the right way to go\r\n\r\ni guess you just need to adjust the gm level check which allows the player to enter in gm mode","created_at":"2015-09-03T16:08:25Z","updated_at":"2015-09-03T16:08:25Z","html_url":"https://github.com/TrinityCore/TrinityCore/pull/15408#discussion_r38663781","pull_request_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15408","_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/38663781"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/15408#discussion_r38663781"},"pull_request":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15408"}}},"pull_request":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15408","id":44042554,"html_url":"https://github.com/TrinityCore/TrinityCore/pull/15408","diff_url":"https://github.com/TrinityCore/TrinityCore/pull/15408.diff","patch_url":"https://github.com/TrinityCore/TrinityCore/pull/15408.patch","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/15408","number":15408,"state":"open","locked":false,"title":"Core/Player: Always allow accounts with RBAC_PERM_COMMAND_GM to enter…","user":{"login":"jackpoz","id":1153754,"avatar_url":"https://avatars.githubusercontent.com/u/1153754?v=3","gravatar_id":"","url":"https://api.github.com/users/jackpoz","html_url":"https://github.com/jackpoz","followers_url":"https://api.github.com/users/jackpoz/followers","following_url":"https://api.github.com/users/jackpoz/following{/other_user}","gists_url":"https://api.github.com/users/jackpoz/gists{/gist_id}","starred_url":"https://api.github.com/users/jackpoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackpoz/subscriptions","organizations_url":"https://api.github.com/users/jackpoz/orgs","repos_url":"https://api.github.com/users/jackpoz/repos","events_url":"https://api.github.com/users/jackpoz/events{/privacy}","received_events_url":"https://api.github.com/users/jackpoz/received_events","type":"User","site_admin":false},"body":"Core/Player: Always allow accounts with RBAC_PERM_COMMAND_GM to enter instances on login\r\n\r\nAlways allow accounts with RBAC_PERM_COMMAND_GM to enter instances on login even if player had .gm off .\r\nSend an ingame message to notify the user about the avoided kick.\r\n\r\nThe text should be moved to SQL.\r\nTested with a GM account and a normal user account in Black Temple, the GM received the ingame message without getting kicked and the user got teleported out.\r\n\r\nCloses https://github.com/TrinityCore/TrinityCore/issues/15406","created_at":"2015-09-02T21:06:52Z","updated_at":"2015-09-03T16:08:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68aaa372e47e2fd297724d55fc7409b6fe70814f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15408/commits","review_comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15408/comments","review_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/15408/comments","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/7d757d15e68ecbf9bc787d453ddd3ff8cabee412","head":{"label":"jackpoz:gm_kicked_out_of_instance_fix","ref":"gm_kicked_out_of_instance_fix","sha":"7d757d15e68ecbf9bc787d453ddd3ff8cabee412","user":{"login":"jackpoz","id":1153754,"avatar_url":"https://avatars.githubusercontent.com/u/1153754?v=3","gravatar_id":"","url":"https://api.github.com/users/jackpoz","html_url":"https://github.com/jackpoz","followers_url":"https://api.github.com/users/jackpoz/followers","following_url":"https://api.github.com/users/jackpoz/following{/other_user}","gists_url":"https://api.github.com/users/jackpoz/gists{/gist_id}","starred_url":"https://api.github.com/users/jackpoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackpoz/subscriptions","organizations_url":"https://api.github.com/users/jackpoz/orgs","repos_url":"https://api.github.com/users/jackpoz/repos","events_url":"https://api.github.com/users/jackpoz/events{/privacy}","received_events_url":"https://api.github.com/users/jackpoz/received_events","type":"User","site_admin":false},"repo":{"id":12344947,"name":"TrinityCore","full_name":"jackpoz/TrinityCore","owner":{"login":"jackpoz","id":1153754,"avatar_url":"https://avatars.githubusercontent.com/u/1153754?v=3","gravatar_id":"","url":"https://api.github.com/users/jackpoz","html_url":"https://github.com/jackpoz","followers_url":"https://api.github.com/users/jackpoz/followers","following_url":"https://api.github.com/users/jackpoz/following{/other_user}","gists_url":"https://api.github.com/users/jackpoz/gists{/gist_id}","starred_url":"https://api.github.com/users/jackpoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackpoz/subscriptions","organizations_url":"https://api.github.com/users/jackpoz/orgs","repos_url":"https://api.github.com/users/jackpoz/repos","events_url":"https://api.github.com/users/jackpoz/events{/privacy}","received_events_url":"https://api.github.com/users/jackpoz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jackpoz/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":true,"url":"https://api.github.com/repos/jackpoz/TrinityCore","forks_url":"https://api.github.com/repos/jackpoz/TrinityCore/forks","keys_url":"https://api.github.com/repos/jackpoz/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jackpoz/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jackpoz/TrinityCore/teams","hooks_url":"https://api.github.com/repos/jackpoz/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/jackpoz/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/jackpoz/TrinityCore/events","assignees_url":"https://api.github.com/repos/jackpoz/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/jackpoz/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/jackpoz/TrinityCore/tags","blobs_url":"https://api.github.com/repos/jackpoz/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jackpoz/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jackpoz/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/jackpoz/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jackpoz/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/jackpoz/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/jackpoz/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/jackpoz/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/jackpoz/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/jackpoz/TrinityCore/subscription","commits_url":"https://api.github.com/repos/jackpoz/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/jackpoz/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/jackpoz/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/jackpoz/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/jackpoz/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/jackpoz/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jackpoz/TrinityCore/merges","archive_url":"https://api.github.com/repos/jackpoz/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jackpoz/TrinityCore/downloads","issues_url":"https://api.github.com/repos/jackpoz/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/jackpoz/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/jackpoz/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/jackpoz/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jackpoz/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/jackpoz/TrinityCore/releases{/id}","created_at":"2013-08-24T15:02:20Z","updated_at":"2015-05-22T21:36:19Z","pushed_at":"2015-09-02T20:58:49Z","git_url":"git://github.com/jackpoz/TrinityCore.git","ssh_url":"git@github.com:jackpoz/TrinityCore.git","clone_url":"https://github.com/jackpoz/TrinityCore.git","svn_url":"https://github.com/jackpoz/TrinityCore","homepage":"http://www.trinitycore.org","size":375156,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":9,"forks":0,"open_issues":9,"watchers":2,"default_branch":"3.3.5"}},"base":{"label":"TrinityCore:3.3.5","ref":"3.3.5","sha":"24a624b38c5d436341a4b87eef6fbe66afc4bfb6","user":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"repo":{"id":1204412,"name":"TrinityCore","full_name":"TrinityCore/TrinityCore","owner":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TrinityCore/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":false,"url":"https://api.github.com/repos/TrinityCore/TrinityCore","forks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/forks","keys_url":"https://api.github.com/repos/TrinityCore/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrinityCore/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrinityCore/TrinityCore/teams","hooks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/events","assignees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/TrinityCore/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/tags","blobs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/TrinityCore/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscription","commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/TrinityCore/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrinityCore/TrinityCore/merges","archive_url":"https://api.github.com/repos/TrinityCore/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrinityCore/TrinityCore/downloads","issues_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/TrinityCore/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/TrinityCore/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/TrinityCore/TrinityCore/releases{/id}","created_at":"2010-12-28T23:40:07Z","updated_at":"2015-09-03T03:52:43Z","pushed_at":"2015-09-03T15:20:41Z","git_url":"git://github.com/TrinityCore/TrinityCore.git","ssh_url":"git@github.com:TrinityCore/TrinityCore.git","clone_url":"https://github.com/TrinityCore/TrinityCore.git","svn_url":"https://github.com/TrinityCore/TrinityCore","homepage":"http://www.trinitycore.org","size":856347,"stargazers_count":2948,"watchers_count":2948,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3087,"mirror_url":null,"open_issues_count":1133,"forks":3087,"open_issues":1133,"watchers":2948,"default_branch":"6.x"}},"_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15408"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/15408"},"issue":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/15408"},"comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/15408/comments"},"review_comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15408/comments"},"review_comment":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15408/commits"},"statuses":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/7d757d15e68ecbf9bc787d453ddd3ff8cabee412"}}}}