{"action":"created","comment":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/comments/28387556","id":28387556,"diff_hunk":"@@ -198,20 +198,33 @@ ResultStatus AppLoader_NCCH::Load() {\n     if (file->ReadBytes(&exheader_header, sizeof(ExHeader_Header)) != sizeof(ExHeader_Header))\n         return ResultStatus::Error;\n \n-    is_compressed = (exheader_header.codeset_info.flags.flag & 1) == 1;\n-    entry_point = exheader_header.codeset_info.text.address;\n-\n-    LOG_INFO(Loader, \"Name:            %s\", exheader_header.codeset_info.name);\n-    LOG_DEBUG(Loader, \"Code compressed: %s\", is_compressed ? \"yes\" : \"no\");\n-    LOG_DEBUG(Loader, \"Entry point:     0x%08X\", entry_point);\n+    is_compressed              = (exheader_header.codeset_info.flags.flag & 1) == 1;\n+    entry_point                = exheader_header.codeset_info.text.address;\n+    u32 code_size              = exheader_header.codeset_info.text.code_size;\n+    u32 stack_size             = exheader_header.codeset_info.stack_size;\n+    u32 bss_size               = exheader_header.codeset_info.bss_size;\n+    u32 core_version           = exheader_header.arm11_system_local_caps.core_version;\n+    u8 priority                = exheader_header.arm11_system_local_caps.priority;\n+    u8 resource_limit_category = exheader_header.arm11_system_local_caps.resource_limit_category;\n+\n+    LOG_INFO(Loader,  \"Name:                            %s\", exheader_header.codeset_info.name);\n+    LOG_DEBUG(Loader, \"Code compressed:                 %s\", is_compressed ? \"yes\" : \"no\");\n+    LOG_DEBUG(Loader, \"Code size:                   0x%08X\", code_size);\n+    LOG_DEBUG(Loader, \"Stack size:                  0x%08X\", stack_size);\n+    LOG_DEBUG(Loader, \"Bss size:                    0x%08X\", bss_size);\n+    LOG_DEBUG(Loader, \"Entry point:                 0x%08X\", entry_point);\n+    LOG_DEBUG(Loader, \"Core version:                    %d\", core_version);\n+    LOG_DEBUG(Loader, \"Thread priority:             0x%08X\", priority);\n+    LOG_DEBUG(Loader, \"Resource limit descriptor:   0x%08X\", exheader_header.arm11_system_local_caps.resource_limit_descriptor);\n+    LOG_DEBUG(Loader, \"Resource limit category:         %d\", resource_limit_category);","path":"src/core/loader/ncch.cpp","position":28,"original_position":28,"commit_id":"149f940715e71dda014349036891b2535abe4349","original_commit_id":"149f940715e71dda014349036891b2535abe4349","user":{"login":"purpasmart96","id":8182590,"avatar_url":"https://avatars.githubusercontent.com/u/8182590?v=3","gravatar_id":"","url":"https://api.github.com/users/purpasmart96","html_url":"https://github.com/purpasmart96","followers_url":"https://api.github.com/users/purpasmart96/followers","following_url":"https://api.github.com/users/purpasmart96/following{/other_user}","gists_url":"https://api.github.com/users/purpasmart96/gists{/gist_id}","starred_url":"https://api.github.com/users/purpasmart96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purpasmart96/subscriptions","organizations_url":"https://api.github.com/users/purpasmart96/orgs","repos_url":"https://api.github.com/users/purpasmart96/repos","events_url":"https://api.github.com/users/purpasmart96/events{/privacy}","received_events_url":"https://api.github.com/users/purpasmart96/received_events","type":"User","site_admin":false},"body":"No, they are not jumbled , I tested it, the are perfectly aligned","created_at":"2015-04-15T01:34:19Z","updated_at":"2015-04-15T01:34:19Z","html_url":"https://github.com/citra-emu/citra/pull/692#discussion_r28387556","pull_request_url":"https://api.github.com/repos/citra-emu/citra/pulls/692","_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments/28387556"},"html":{"href":"https://github.com/citra-emu/citra/pull/692#discussion_r28387556"},"pull_request":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/692"}}},"pull_request":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/692","id":32930921,"html_url":"https://github.com/citra-emu/citra/pull/692","diff_url":"https://github.com/citra-emu/citra/pull/692.diff","patch_url":"https://github.com/citra-emu/citra/pull/692.patch","issue_url":"https://api.github.com/repos/citra-emu/citra/issues/692","number":692,"state":"open","locked":false,"title":"Services/Loader: Use more sensible log formats for certain functions along with more info being logged.","user":{"login":"purpasmart96","id":8182590,"avatar_url":"https://avatars.githubusercontent.com/u/8182590?v=3","gravatar_id":"","url":"https://api.github.com/users/purpasmart96","html_url":"https://github.com/purpasmart96","followers_url":"https://api.github.com/users/purpasmart96/followers","following_url":"https://api.github.com/users/purpasmart96/following{/other_user}","gists_url":"https://api.github.com/users/purpasmart96/gists{/gist_id}","starred_url":"https://api.github.com/users/purpasmart96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purpasmart96/subscriptions","organizations_url":"https://api.github.com/users/purpasmart96/orgs","repos_url":"https://api.github.com/users/purpasmart96/repos","events_url":"https://api.github.com/users/purpasmart96/events{/privacy}","received_events_url":"https://api.github.com/users/purpasmart96/received_events","type":"User","site_admin":false},"body":"Also fixed a  bug in the exheader, since some values on 3dbrew were using the  decimal format for some of the types instead of hex resulting in a invalid size for the exheader, to make sure this doesn't happen again I added a static assert for the exheader and for the ncch header, I also decided that logging some of the exheader values(like the stack size, bss size, etc.) would provide somewhat useful debug info.","created_at":"2015-04-09T07:24:47Z","updated_at":"2015-04-15T01:34:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43878084d95bb8ef829d457d71ae115c76c54b25","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/citra-emu/citra/pulls/692/commits","review_comments_url":"https://api.github.com/repos/citra-emu/citra/pulls/692/comments","review_comment_url":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/citra-emu/citra/issues/692/comments","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/149f940715e71dda014349036891b2535abe4349","head":{"label":"purpasmart96:log_improvements","ref":"log_improvements","sha":"149f940715e71dda014349036891b2535abe4349","user":{"login":"purpasmart96","id":8182590,"avatar_url":"https://avatars.githubusercontent.com/u/8182590?v=3","gravatar_id":"","url":"https://api.github.com/users/purpasmart96","html_url":"https://github.com/purpasmart96","followers_url":"https://api.github.com/users/purpasmart96/followers","following_url":"https://api.github.com/users/purpasmart96/following{/other_user}","gists_url":"https://api.github.com/users/purpasmart96/gists{/gist_id}","starred_url":"https://api.github.com/users/purpasmart96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purpasmart96/subscriptions","organizations_url":"https://api.github.com/users/purpasmart96/orgs","repos_url":"https://api.github.com/users/purpasmart96/repos","events_url":"https://api.github.com/users/purpasmart96/events{/privacy}","received_events_url":"https://api.github.com/users/purpasmart96/received_events","type":"User","site_admin":false},"repo":{"id":30088656,"name":"citra","full_name":"purpasmart96/citra","owner":{"login":"purpasmart96","id":8182590,"avatar_url":"https://avatars.githubusercontent.com/u/8182590?v=3","gravatar_id":"","url":"https://api.github.com/users/purpasmart96","html_url":"https://github.com/purpasmart96","followers_url":"https://api.github.com/users/purpasmart96/followers","following_url":"https://api.github.com/users/purpasmart96/following{/other_user}","gists_url":"https://api.github.com/users/purpasmart96/gists{/gist_id}","starred_url":"https://api.github.com/users/purpasmart96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purpasmart96/subscriptions","organizations_url":"https://api.github.com/users/purpasmart96/orgs","repos_url":"https://api.github.com/users/purpasmart96/repos","events_url":"https://api.github.com/users/purpasmart96/events{/privacy}","received_events_url":"https://api.github.com/users/purpasmart96/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/purpasmart96/citra","description":"Nintendo 3DS emulator/debugger","fork":true,"url":"https://api.github.com/repos/purpasmart96/citra","forks_url":"https://api.github.com/repos/purpasmart96/citra/forks","keys_url":"https://api.github.com/repos/purpasmart96/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/purpasmart96/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/purpasmart96/citra/teams","hooks_url":"https://api.github.com/repos/purpasmart96/citra/hooks","issue_events_url":"https://api.github.com/repos/purpasmart96/citra/issues/events{/number}","events_url":"https://api.github.com/repos/purpasmart96/citra/events","assignees_url":"https://api.github.com/repos/purpasmart96/citra/assignees{/user}","branches_url":"https://api.github.com/repos/purpasmart96/citra/branches{/branch}","tags_url":"https://api.github.com/repos/purpasmart96/citra/tags","blobs_url":"https://api.github.com/repos/purpasmart96/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/purpasmart96/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/purpasmart96/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/purpasmart96/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/purpasmart96/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/purpasmart96/citra/languages","stargazers_url":"https://api.github.com/repos/purpasmart96/citra/stargazers","contributors_url":"https://api.github.com/repos/purpasmart96/citra/contributors","subscribers_url":"https://api.github.com/repos/purpasmart96/citra/subscribers","subscription_url":"https://api.github.com/repos/purpasmart96/citra/subscription","commits_url":"https://api.github.com/repos/purpasmart96/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/purpasmart96/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/purpasmart96/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/purpasmart96/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/purpasmart96/citra/contents/{+path}","compare_url":"https://api.github.com/repos/purpasmart96/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/purpasmart96/citra/merges","archive_url":"https://api.github.com/repos/purpasmart96/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/purpasmart96/citra/downloads","issues_url":"https://api.github.com/repos/purpasmart96/citra/issues{/number}","pulls_url":"https://api.github.com/repos/purpasmart96/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/purpasmart96/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/purpasmart96/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/purpasmart96/citra/labels{/name}","releases_url":"https://api.github.com/repos/purpasmart96/citra/releases{/id}","created_at":"2015-01-30T20:07:01Z","updated_at":"2015-04-11T08:08:24Z","pushed_at":"2015-04-09T07:53:16Z","git_url":"git://github.com/purpasmart96/citra.git","ssh_url":"git@github.com:purpasmart96/citra.git","clone_url":"https://github.com/purpasmart96/citra.git","svn_url":"https://github.com/purpasmart96/citra","homepage":null,"size":8473,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"service_stubs"}},"base":{"label":"citra-emu:master","ref":"master","sha":"8af5753da52d0ddf9487c94c6138469246399c62","user":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=3","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":19866730,"name":"citra","full_name":"citra-emu/citra","owner":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=3","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/citra-emu/citra","description":"Nintendo 3DS emulator/debugger","fork":false,"url":"https://api.github.com/repos/citra-emu/citra","forks_url":"https://api.github.com/repos/citra-emu/citra/forks","keys_url":"https://api.github.com/repos/citra-emu/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/citra-emu/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/citra-emu/citra/teams","hooks_url":"https://api.github.com/repos/citra-emu/citra/hooks","issue_events_url":"https://api.github.com/repos/citra-emu/citra/issues/events{/number}","events_url":"https://api.github.com/repos/citra-emu/citra/events","assignees_url":"https://api.github.com/repos/citra-emu/citra/assignees{/user}","branches_url":"https://api.github.com/repos/citra-emu/citra/branches{/branch}","tags_url":"https://api.github.com/repos/citra-emu/citra/tags","blobs_url":"https://api.github.com/repos/citra-emu/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/citra-emu/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/citra-emu/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/citra-emu/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/citra-emu/citra/languages","stargazers_url":"https://api.github.com/repos/citra-emu/citra/stargazers","contributors_url":"https://api.github.com/repos/citra-emu/citra/contributors","subscribers_url":"https://api.github.com/repos/citra-emu/citra/subscribers","subscription_url":"https://api.github.com/repos/citra-emu/citra/subscription","commits_url":"https://api.github.com/repos/citra-emu/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/citra-emu/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/citra-emu/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/citra-emu/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/citra-emu/citra/contents/{+path}","compare_url":"https://api.github.com/repos/citra-emu/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/citra-emu/citra/merges","archive_url":"https://api.github.com/repos/citra-emu/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/citra-emu/citra/downloads","issues_url":"https://api.github.com/repos/citra-emu/citra/issues{/number}","pulls_url":"https://api.github.com/repos/citra-emu/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/citra-emu/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/citra-emu/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/citra-emu/citra/labels{/name}","releases_url":"https://api.github.com/repos/citra-emu/citra/releases{/id}","created_at":"2014-05-16T18:33:15Z","updated_at":"2015-04-14T23:14:27Z","pushed_at":"2015-04-14T23:14:27Z","git_url":"git://github.com/citra-emu/citra.git","ssh_url":"git@github.com:citra-emu/citra.git","clone_url":"https://github.com/citra-emu/citra.git","svn_url":"https://github.com/citra-emu/citra","homepage":null,"size":21977,"stargazers_count":747,"watchers_count":747,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":191,"mirror_url":null,"open_issues_count":41,"forks":191,"open_issues":41,"watchers":747,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/692"},"html":{"href":"https://github.com/citra-emu/citra/pull/692"},"issue":{"href":"https://api.github.com/repos/citra-emu/citra/issues/692"},"comments":{"href":"https://api.github.com/repos/citra-emu/citra/issues/692/comments"},"review_comments":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/692/comments"},"review_comment":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/692/commits"},"statuses":{"href":"https://api.github.com/repos/citra-emu/citra/statuses/149f940715e71dda014349036891b2535abe4349"}}}}