{"action":"created","comment":{"url":"https://api.github.com/repos/nengo/nengo_viz/pulls/comments/31370977","id":31370977,"diff_hunk":"@@ -114,7 +114,9 @@ VIZ.NetGraph = function(parent, args) {\n             var x = (event.clientX / $(self.svg).width())\n             var y = (event.clientY / $(self.svg).height());\n \n+            self.normalize_mousewheel(event);\n             var delta = event.wheelDeltaY || -event.deltaY\n+            VIZ.scale.step_size = 1.05\n             var scale = delta > 0 ? VIZ.scale.step_size : 1.0 / VIZ.scale.step_size; // will either be 1.1 or ~0.9","path":"nengo_viz/static/viz_netgraph.js","position":101,"original_position":101,"commit_id":"d8d016039dd3a58ae74cf0acb9443ff0bf4a8b3d","original_commit_id":"d8d016039dd3a58ae74cf0acb9443ff0bf4a8b3d","user":{"login":"tcstewar","id":2380772,"avatar_url":"https://avatars.githubusercontent.com/u/2380772?v=3","gravatar_id":"","url":"https://api.github.com/users/tcstewar","html_url":"https://github.com/tcstewar","followers_url":"https://api.github.com/users/tcstewar/followers","following_url":"https://api.github.com/users/tcstewar/following{/other_user}","gists_url":"https://api.github.com/users/tcstewar/gists{/gist_id}","starred_url":"https://api.github.com/users/tcstewar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcstewar/subscriptions","organizations_url":"https://api.github.com/users/tcstewar/orgs","repos_url":"https://api.github.com/users/tcstewar/repos","events_url":"https://api.github.com/users/tcstewar/events{/privacy}","received_events_url":"https://api.github.com/users/tcstewar/received_events","type":"User","site_admin":false},"body":"I'm confused...  it looks to me like ```normalize_mousewheel``` does some wacky math in order to compute a nice ```event.delta```, which we then throw away because this ```scale``` calculation completely ignores it.","created_at":"2015-05-29T22:38:49Z","updated_at":"2015-05-29T22:38:49Z","html_url":"https://github.com/nengo/nengo_viz/pull/226#discussion_r31370977","pull_request_url":"https://api.github.com/repos/nengo/nengo_viz/pulls/226","_links":{"self":{"href":"https://api.github.com/repos/nengo/nengo_viz/pulls/comments/31370977"},"html":{"href":"https://github.com/nengo/nengo_viz/pull/226#discussion_r31370977"},"pull_request":{"href":"https://api.github.com/repos/nengo/nengo_viz/pulls/226"}}},"pull_request":{"url":"https://api.github.com/repos/nengo/nengo_viz/pulls/226","id":36453866,"html_url":"https://github.com/nengo/nengo_viz/pull/226","diff_url":"https://github.com/nengo/nengo_viz/pull/226.diff","patch_url":"https://github.com/nengo/nengo_viz/pull/226.patch","issue_url":"https://api.github.com/repos/nengo/nengo_viz/issues/226","number":226,"state":"open","locked":false,"title":"Normalize mouse scroll speeds across browsers","user":{"login":"celiasmith","id":1984851,"avatar_url":"https://avatars.githubusercontent.com/u/1984851?v=3","gravatar_id":"","url":"https://api.github.com/users/celiasmith","html_url":"https://github.com/celiasmith","followers_url":"https://api.github.com/users/celiasmith/followers","following_url":"https://api.github.com/users/celiasmith/following{/other_user}","gists_url":"https://api.github.com/users/celiasmith/gists{/gist_id}","starred_url":"https://api.github.com/users/celiasmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/celiasmith/subscriptions","organizations_url":"https://api.github.com/users/celiasmith/orgs","repos_url":"https://api.github.com/users/celiasmith/repos","events_url":"https://api.github.com/users/celiasmith/events{/privacy}","received_events_url":"https://api.github.com/users/celiasmith/received_events","type":"User","site_admin":false},"body":"It’d be nice to have the scroll speed set in config.  \r\n\r\nThis commit definitely makes the mac sensitivity issue better.  It makes scrolling consistent on firefox, safari, and chrome from what I can tell.\r\n\r\nSolution from: http://stackoverflow.com/questions/5527601/normalizing-mousewheel-speed-across-browsers","created_at":"2015-05-28T21:39:51Z","updated_at":"2015-05-29T22:38:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79c3d6aae0ce268a91c90a2f56019b5119aff57d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nengo/nengo_viz/pulls/226/commits","review_comments_url":"https://api.github.com/repos/nengo/nengo_viz/pulls/226/comments","review_comment_url":"https://api.github.com/repos/nengo/nengo_viz/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nengo/nengo_viz/issues/226/comments","statuses_url":"https://api.github.com/repos/nengo/nengo_viz/statuses/d8d016039dd3a58ae74cf0acb9443ff0bf4a8b3d","head":{"label":"nengo:mousewheel","ref":"mousewheel","sha":"d8d016039dd3a58ae74cf0acb9443ff0bf4a8b3d","user":{"login":"nengo","id":9197486,"avatar_url":"https://avatars.githubusercontent.com/u/9197486?v=3","gravatar_id":"","url":"https://api.github.com/users/nengo","html_url":"https://github.com/nengo","followers_url":"https://api.github.com/users/nengo/followers","following_url":"https://api.github.com/users/nengo/following{/other_user}","gists_url":"https://api.github.com/users/nengo/gists{/gist_id}","starred_url":"https://api.github.com/users/nengo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nengo/subscriptions","organizations_url":"https://api.github.com/users/nengo/orgs","repos_url":"https://api.github.com/users/nengo/repos","events_url":"https://api.github.com/users/nengo/events{/privacy}","received_events_url":"https://api.github.com/users/nengo/received_events","type":"Organization","site_admin":false},"repo":{"id":28949681,"name":"nengo_viz","full_name":"nengo/nengo_viz","owner":{"login":"nengo","id":9197486,"avatar_url":"https://avatars.githubusercontent.com/u/9197486?v=3","gravatar_id":"","url":"https://api.github.com/users/nengo","html_url":"https://github.com/nengo","followers_url":"https://api.github.com/users/nengo/followers","following_url":"https://api.github.com/users/nengo/following{/other_user}","gists_url":"https://api.github.com/users/nengo/gists{/gist_id}","starred_url":"https://api.github.com/users/nengo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nengo/subscriptions","organizations_url":"https://api.github.com/users/nengo/orgs","repos_url":"https://api.github.com/users/nengo/repos","events_url":"https://api.github.com/users/nengo/events{/privacy}","received_events_url":"https://api.github.com/users/nengo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nengo/nengo_viz","description":"Nengo interactive visualizer","fork":false,"url":"https://api.github.com/repos/nengo/nengo_viz","forks_url":"https://api.github.com/repos/nengo/nengo_viz/forks","keys_url":"https://api.github.com/repos/nengo/nengo_viz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nengo/nengo_viz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nengo/nengo_viz/teams","hooks_url":"https://api.github.com/repos/nengo/nengo_viz/hooks","issue_events_url":"https://api.github.com/repos/nengo/nengo_viz/issues/events{/number}","events_url":"https://api.github.com/repos/nengo/nengo_viz/events","assignees_url":"https://api.github.com/repos/nengo/nengo_viz/assignees{/user}","branches_url":"https://api.github.com/repos/nengo/nengo_viz/branches{/branch}","tags_url":"https://api.github.com/repos/nengo/nengo_viz/tags","blobs_url":"https://api.github.com/repos/nengo/nengo_viz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nengo/nengo_viz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nengo/nengo_viz/git/refs{/sha}","trees_url":"https://api.github.com/repos/nengo/nengo_viz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nengo/nengo_viz/statuses/{sha}","languages_url":"https://api.github.com/repos/nengo/nengo_viz/languages","stargazers_url":"https://api.github.com/repos/nengo/nengo_viz/stargazers","contributors_url":"https://api.github.com/repos/nengo/nengo_viz/contributors","subscribers_url":"https://api.github.com/repos/nengo/nengo_viz/subscribers","subscription_url":"https://api.github.com/repos/nengo/nengo_viz/subscription","commits_url":"https://api.github.com/repos/nengo/nengo_viz/commits{/sha}","git_commits_url":"https://api.github.com/repos/nengo/nengo_viz/git/commits{/sha}","comments_url":"https://api.github.com/repos/nengo/nengo_viz/comments{/number}","issue_comment_url":"https://api.github.com/repos/nengo/nengo_viz/issues/comments{/number}","contents_url":"https://api.github.com/repos/nengo/nengo_viz/contents/{+path}","compare_url":"https://api.github.com/repos/nengo/nengo_viz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nengo/nengo_viz/merges","archive_url":"https://api.github.com/repos/nengo/nengo_viz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nengo/nengo_viz/downloads","issues_url":"https://api.github.com/repos/nengo/nengo_viz/issues{/number}","pulls_url":"https://api.github.com/repos/nengo/nengo_viz/pulls{/number}","milestones_url":"https://api.github.com/repos/nengo/nengo_viz/milestones{/number}","notifications_url":"https://api.github.com/repos/nengo/nengo_viz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nengo/nengo_viz/labels{/name}","releases_url":"https://api.github.com/repos/nengo/nengo_viz/releases{/id}","created_at":"2015-01-08T05:00:06Z","updated_at":"2015-05-13T17:58:58Z","pushed_at":"2015-05-29T22:25:26Z","git_url":"git://github.com/nengo/nengo_viz.git","ssh_url":"git@github.com:nengo/nengo_viz.git","clone_url":"https://github.com/nengo/nengo_viz.git","svn_url":"https://github.com/nengo/nengo_viz","homepage":"","size":7248,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":84,"forks":1,"open_issues":84,"watchers":4,"default_branch":"master"}},"base":{"label":"nengo:master","ref":"master","sha":"8e4c533a96ddbb06599aad46b3247d81aa9eebd9","user":{"login":"nengo","id":9197486,"avatar_url":"https://avatars.githubusercontent.com/u/9197486?v=3","gravatar_id":"","url":"https://api.github.com/users/nengo","html_url":"https://github.com/nengo","followers_url":"https://api.github.com/users/nengo/followers","following_url":"https://api.github.com/users/nengo/following{/other_user}","gists_url":"https://api.github.com/users/nengo/gists{/gist_id}","starred_url":"https://api.github.com/users/nengo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nengo/subscriptions","organizations_url":"https://api.github.com/users/nengo/orgs","repos_url":"https://api.github.com/users/nengo/repos","events_url":"https://api.github.com/users/nengo/events{/privacy}","received_events_url":"https://api.github.com/users/nengo/received_events","type":"Organization","site_admin":false},"repo":{"id":28949681,"name":"nengo_viz","full_name":"nengo/nengo_viz","owner":{"login":"nengo","id":9197486,"avatar_url":"https://avatars.githubusercontent.com/u/9197486?v=3","gravatar_id":"","url":"https://api.github.com/users/nengo","html_url":"https://github.com/nengo","followers_url":"https://api.github.com/users/nengo/followers","following_url":"https://api.github.com/users/nengo/following{/other_user}","gists_url":"https://api.github.com/users/nengo/gists{/gist_id}","starred_url":"https://api.github.com/users/nengo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nengo/subscriptions","organizations_url":"https://api.github.com/users/nengo/orgs","repos_url":"https://api.github.com/users/nengo/repos","events_url":"https://api.github.com/users/nengo/events{/privacy}","received_events_url":"https://api.github.com/users/nengo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nengo/nengo_viz","description":"Nengo interactive visualizer","fork":false,"url":"https://api.github.com/repos/nengo/nengo_viz","forks_url":"https://api.github.com/repos/nengo/nengo_viz/forks","keys_url":"https://api.github.com/repos/nengo/nengo_viz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nengo/nengo_viz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nengo/nengo_viz/teams","hooks_url":"https://api.github.com/repos/nengo/nengo_viz/hooks","issue_events_url":"https://api.github.com/repos/nengo/nengo_viz/issues/events{/number}","events_url":"https://api.github.com/repos/nengo/nengo_viz/events","assignees_url":"https://api.github.com/repos/nengo/nengo_viz/assignees{/user}","branches_url":"https://api.github.com/repos/nengo/nengo_viz/branches{/branch}","tags_url":"https://api.github.com/repos/nengo/nengo_viz/tags","blobs_url":"https://api.github.com/repos/nengo/nengo_viz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nengo/nengo_viz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nengo/nengo_viz/git/refs{/sha}","trees_url":"https://api.github.com/repos/nengo/nengo_viz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nengo/nengo_viz/statuses/{sha}","languages_url":"https://api.github.com/repos/nengo/nengo_viz/languages","stargazers_url":"https://api.github.com/repos/nengo/nengo_viz/stargazers","contributors_url":"https://api.github.com/repos/nengo/nengo_viz/contributors","subscribers_url":"https://api.github.com/repos/nengo/nengo_viz/subscribers","subscription_url":"https://api.github.com/repos/nengo/nengo_viz/subscription","commits_url":"https://api.github.com/repos/nengo/nengo_viz/commits{/sha}","git_commits_url":"https://api.github.com/repos/nengo/nengo_viz/git/commits{/sha}","comments_url":"https://api.github.com/repos/nengo/nengo_viz/comments{/number}","issue_comment_url":"https://api.github.com/repos/nengo/nengo_viz/issues/comments{/number}","contents_url":"https://api.github.com/repos/nengo/nengo_viz/contents/{+path}","compare_url":"https://api.github.com/repos/nengo/nengo_viz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nengo/nengo_viz/merges","archive_url":"https://api.github.com/repos/nengo/nengo_viz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nengo/nengo_viz/downloads","issues_url":"https://api.github.com/repos/nengo/nengo_viz/issues{/number}","pulls_url":"https://api.github.com/repos/nengo/nengo_viz/pulls{/number}","milestones_url":"https://api.github.com/repos/nengo/nengo_viz/milestones{/number}","notifications_url":"https://api.github.com/repos/nengo/nengo_viz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nengo/nengo_viz/labels{/name}","releases_url":"https://api.github.com/repos/nengo/nengo_viz/releases{/id}","created_at":"2015-01-08T05:00:06Z","updated_at":"2015-05-13T17:58:58Z","pushed_at":"2015-05-29T22:25:26Z","git_url":"git://github.com/nengo/nengo_viz.git","ssh_url":"git@github.com:nengo/nengo_viz.git","clone_url":"https://github.com/nengo/nengo_viz.git","svn_url":"https://github.com/nengo/nengo_viz","homepage":"","size":7248,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":84,"forks":1,"open_issues":84,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nengo/nengo_viz/pulls/226"},"html":{"href":"https://github.com/nengo/nengo_viz/pull/226"},"issue":{"href":"https://api.github.com/repos/nengo/nengo_viz/issues/226"},"comments":{"href":"https://api.github.com/repos/nengo/nengo_viz/issues/226/comments"},"review_comments":{"href":"https://api.github.com/repos/nengo/nengo_viz/pulls/226/comments"},"review_comment":{"href":"https://api.github.com/repos/nengo/nengo_viz/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nengo/nengo_viz/pulls/226/commits"},"statuses":{"href":"https://api.github.com/repos/nengo/nengo_viz/statuses/d8d016039dd3a58ae74cf0acb9443ff0bf4a8b3d"}}}}