{"action":"created","comment":{"url":"https://api.github.com/repos/onelogin/ruby-saml/pulls/comments/26787642","id":26787642,"diff_hunk":"@@ -84,5 +84,42 @@ def setup\n       assert_equal \"Friendly Name\", req_attr.attribute(\"FriendlyName\").value\n       assert_equal \"Attribute Value\", REXML::XPath.first(xml_doc, \"//md:AttributeValue\").text.strip\n     end\n+","path":"test/metadata_test.rb","position":4,"original_position":4,"commit_id":"d06b8649415a0baf53e925f0754e1ddbb7b2e119","original_commit_id":"d06b8649415a0baf53e925f0754e1ddbb7b2e119","user":{"login":"Umofomia","id":480318,"avatar_url":"https://avatars.githubusercontent.com/u/480318?v=3","gravatar_id":"","url":"https://api.github.com/users/Umofomia","html_url":"https://github.com/Umofomia","followers_url":"https://api.github.com/users/Umofomia/followers","following_url":"https://api.github.com/users/Umofomia/following{/other_user}","gists_url":"https://api.github.com/users/Umofomia/gists{/gist_id}","starred_url":"https://api.github.com/users/Umofomia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Umofomia/subscriptions","organizations_url":"https://api.github.com/users/Umofomia/orgs","repos_url":"https://api.github.com/users/Umofomia/repos","events_url":"https://api.github.com/users/Umofomia/events{/privacy}","received_events_url":"https://api.github.com/users/Umofomia/received_events","type":"User","site_admin":false},"body":"I was following the convention of the other tests in this file, but I can refactor this with the cleaner format. Should I refactor the existing tests as well?","created_at":"2015-03-19T19:11:25Z","updated_at":"2015-03-19T19:11:25Z","html_url":"https://github.com/onelogin/ruby-saml/pull/207#discussion_r26787642","pull_request_url":"https://api.github.com/repos/onelogin/ruby-saml/pulls/207","_links":{"self":{"href":"https://api.github.com/repos/onelogin/ruby-saml/pulls/comments/26787642"},"html":{"href":"https://github.com/onelogin/ruby-saml/pull/207#discussion_r26787642"},"pull_request":{"href":"https://api.github.com/repos/onelogin/ruby-saml/pulls/207"}}},"pull_request":{"url":"https://api.github.com/repos/onelogin/ruby-saml/pulls/207","id":31457316,"html_url":"https://github.com/onelogin/ruby-saml/pull/207","diff_url":"https://github.com/onelogin/ruby-saml/pull/207.diff","patch_url":"https://github.com/onelogin/ruby-saml/pull/207.patch","issue_url":"https://api.github.com/repos/onelogin/ruby-saml/issues/207","number":207,"state":"open","locked":false,"title":"Add ability to sign metadata.","user":{"login":"Umofomia","id":480318,"avatar_url":"https://avatars.githubusercontent.com/u/480318?v=3","gravatar_id":"","url":"https://api.github.com/users/Umofomia","html_url":"https://github.com/Umofomia","followers_url":"https://api.github.com/users/Umofomia/followers","following_url":"https://api.github.com/users/Umofomia/following{/other_user}","gists_url":"https://api.github.com/users/Umofomia/gists{/gist_id}","starred_url":"https://api.github.com/users/Umofomia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Umofomia/subscriptions","organizations_url":"https://api.github.com/users/Umofomia/orgs","repos_url":"https://api.github.com/users/Umofomia/repos","events_url":"https://api.github.com/users/Umofomia/events{/privacy}","received_events_url":"https://api.github.com/users/Umofomia/received_events","type":"User","site_admin":false},"body":"I also fixed the \"embebed\" typo that was copy-pasted across many of the comments.","created_at":"2015-03-18T18:20:18Z","updated_at":"2015-03-19T19:11:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21f95f57f4c30971068ecbd6b2f4a078268ca3c5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/onelogin/ruby-saml/pulls/207/commits","review_comments_url":"https://api.github.com/repos/onelogin/ruby-saml/pulls/207/comments","review_comment_url":"https://api.github.com/repos/onelogin/ruby-saml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/onelogin/ruby-saml/issues/207/comments","statuses_url":"https://api.github.com/repos/onelogin/ruby-saml/statuses/d06b8649415a0baf53e925f0754e1ddbb7b2e119","head":{"label":"Umofomia:sign-metadata","ref":"sign-metadata","sha":"d06b8649415a0baf53e925f0754e1ddbb7b2e119","user":{"login":"Umofomia","id":480318,"avatar_url":"https://avatars.githubusercontent.com/u/480318?v=3","gravatar_id":"","url":"https://api.github.com/users/Umofomia","html_url":"https://github.com/Umofomia","followers_url":"https://api.github.com/users/Umofomia/followers","following_url":"https://api.github.com/users/Umofomia/following{/other_user}","gists_url":"https://api.github.com/users/Umofomia/gists{/gist_id}","starred_url":"https://api.github.com/users/Umofomia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Umofomia/subscriptions","organizations_url":"https://api.github.com/users/Umofomia/orgs","repos_url":"https://api.github.com/users/Umofomia/repos","events_url":"https://api.github.com/users/Umofomia/events{/privacy}","received_events_url":"https://api.github.com/users/Umofomia/received_events","type":"User","site_admin":false},"repo":{"id":31739887,"name":"ruby-saml","full_name":"Umofomia/ruby-saml","owner":{"login":"Umofomia","id":480318,"avatar_url":"https://avatars.githubusercontent.com/u/480318?v=3","gravatar_id":"","url":"https://api.github.com/users/Umofomia","html_url":"https://github.com/Umofomia","followers_url":"https://api.github.com/users/Umofomia/followers","following_url":"https://api.github.com/users/Umofomia/following{/other_user}","gists_url":"https://api.github.com/users/Umofomia/gists{/gist_id}","starred_url":"https://api.github.com/users/Umofomia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Umofomia/subscriptions","organizations_url":"https://api.github.com/users/Umofomia/orgs","repos_url":"https://api.github.com/users/Umofomia/repos","events_url":"https://api.github.com/users/Umofomia/events{/privacy}","received_events_url":"https://api.github.com/users/Umofomia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Umofomia/ruby-saml","description":"SAML SSO for Ruby","fork":true,"url":"https://api.github.com/repos/Umofomia/ruby-saml","forks_url":"https://api.github.com/repos/Umofomia/ruby-saml/forks","keys_url":"https://api.github.com/repos/Umofomia/ruby-saml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Umofomia/ruby-saml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Umofomia/ruby-saml/teams","hooks_url":"https://api.github.com/repos/Umofomia/ruby-saml/hooks","issue_events_url":"https://api.github.com/repos/Umofomia/ruby-saml/issues/events{/number}","events_url":"https://api.github.com/repos/Umofomia/ruby-saml/events","assignees_url":"https://api.github.com/repos/Umofomia/ruby-saml/assignees{/user}","branches_url":"https://api.github.com/repos/Umofomia/ruby-saml/branches{/branch}","tags_url":"https://api.github.com/repos/Umofomia/ruby-saml/tags","blobs_url":"https://api.github.com/repos/Umofomia/ruby-saml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Umofomia/ruby-saml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Umofomia/ruby-saml/git/refs{/sha}","trees_url":"https://api.github.com/repos/Umofomia/ruby-saml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Umofomia/ruby-saml/statuses/{sha}","languages_url":"https://api.github.com/repos/Umofomia/ruby-saml/languages","stargazers_url":"https://api.github.com/repos/Umofomia/ruby-saml/stargazers","contributors_url":"https://api.github.com/repos/Umofomia/ruby-saml/contributors","subscribers_url":"https://api.github.com/repos/Umofomia/ruby-saml/subscribers","subscription_url":"https://api.github.com/repos/Umofomia/ruby-saml/subscription","commits_url":"https://api.github.com/repos/Umofomia/ruby-saml/commits{/sha}","git_commits_url":"https://api.github.com/repos/Umofomia/ruby-saml/git/commits{/sha}","comments_url":"https://api.github.com/repos/Umofomia/ruby-saml/comments{/number}","issue_comment_url":"https://api.github.com/repos/Umofomia/ruby-saml/issues/comments{/number}","contents_url":"https://api.github.com/repos/Umofomia/ruby-saml/contents/{+path}","compare_url":"https://api.github.com/repos/Umofomia/ruby-saml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Umofomia/ruby-saml/merges","archive_url":"https://api.github.com/repos/Umofomia/ruby-saml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Umofomia/ruby-saml/downloads","issues_url":"https://api.github.com/repos/Umofomia/ruby-saml/issues{/number}","pulls_url":"https://api.github.com/repos/Umofomia/ruby-saml/pulls{/number}","milestones_url":"https://api.github.com/repos/Umofomia/ruby-saml/milestones{/number}","notifications_url":"https://api.github.com/repos/Umofomia/ruby-saml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Umofomia/ruby-saml/labels{/name}","releases_url":"https://api.github.com/repos/Umofomia/ruby-saml/releases{/id}","created_at":"2015-03-05T22:22:24Z","updated_at":"2015-03-18T17:55:47Z","pushed_at":"2015-03-18T19:28:04Z","git_url":"git://github.com/Umofomia/ruby-saml.git","ssh_url":"git@github.com:Umofomia/ruby-saml.git","clone_url":"https://github.com/Umofomia/ruby-saml.git","svn_url":"https://github.com/Umofomia/ruby-saml","homepage":"http://support.onelogin.com/entries/165434-saml-toolkit-for-ruby-on-rails","size":930,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"onelogin:master","ref":"master","sha":"d1364717ec865e988eaec2f9d202d6da60f160ff","user":{"login":"onelogin","id":263373,"avatar_url":"https://avatars.githubusercontent.com/u/263373?v=3","gravatar_id":"","url":"https://api.github.com/users/onelogin","html_url":"https://github.com/onelogin","followers_url":"https://api.github.com/users/onelogin/followers","following_url":"https://api.github.com/users/onelogin/following{/other_user}","gists_url":"https://api.github.com/users/onelogin/gists{/gist_id}","starred_url":"https://api.github.com/users/onelogin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onelogin/subscriptions","organizations_url":"https://api.github.com/users/onelogin/orgs","repos_url":"https://api.github.com/users/onelogin/repos","events_url":"https://api.github.com/users/onelogin/events{/privacy}","received_events_url":"https://api.github.com/users/onelogin/received_events","type":"Organization","site_admin":false},"repo":{"id":644899,"name":"ruby-saml","full_name":"onelogin/ruby-saml","owner":{"login":"onelogin","id":263373,"avatar_url":"https://avatars.githubusercontent.com/u/263373?v=3","gravatar_id":"","url":"https://api.github.com/users/onelogin","html_url":"https://github.com/onelogin","followers_url":"https://api.github.com/users/onelogin/followers","following_url":"https://api.github.com/users/onelogin/following{/other_user}","gists_url":"https://api.github.com/users/onelogin/gists{/gist_id}","starred_url":"https://api.github.com/users/onelogin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onelogin/subscriptions","organizations_url":"https://api.github.com/users/onelogin/orgs","repos_url":"https://api.github.com/users/onelogin/repos","events_url":"https://api.github.com/users/onelogin/events{/privacy}","received_events_url":"https://api.github.com/users/onelogin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/onelogin/ruby-saml","description":"SAML SSO for Ruby","fork":false,"url":"https://api.github.com/repos/onelogin/ruby-saml","forks_url":"https://api.github.com/repos/onelogin/ruby-saml/forks","keys_url":"https://api.github.com/repos/onelogin/ruby-saml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onelogin/ruby-saml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onelogin/ruby-saml/teams","hooks_url":"https://api.github.com/repos/onelogin/ruby-saml/hooks","issue_events_url":"https://api.github.com/repos/onelogin/ruby-saml/issues/events{/number}","events_url":"https://api.github.com/repos/onelogin/ruby-saml/events","assignees_url":"https://api.github.com/repos/onelogin/ruby-saml/assignees{/user}","branches_url":"https://api.github.com/repos/onelogin/ruby-saml/branches{/branch}","tags_url":"https://api.github.com/repos/onelogin/ruby-saml/tags","blobs_url":"https://api.github.com/repos/onelogin/ruby-saml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onelogin/ruby-saml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onelogin/ruby-saml/git/refs{/sha}","trees_url":"https://api.github.com/repos/onelogin/ruby-saml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onelogin/ruby-saml/statuses/{sha}","languages_url":"https://api.github.com/repos/onelogin/ruby-saml/languages","stargazers_url":"https://api.github.com/repos/onelogin/ruby-saml/stargazers","contributors_url":"https://api.github.com/repos/onelogin/ruby-saml/contributors","subscribers_url":"https://api.github.com/repos/onelogin/ruby-saml/subscribers","subscription_url":"https://api.github.com/repos/onelogin/ruby-saml/subscription","commits_url":"https://api.github.com/repos/onelogin/ruby-saml/commits{/sha}","git_commits_url":"https://api.github.com/repos/onelogin/ruby-saml/git/commits{/sha}","comments_url":"https://api.github.com/repos/onelogin/ruby-saml/comments{/number}","issue_comment_url":"https://api.github.com/repos/onelogin/ruby-saml/issues/comments{/number}","contents_url":"https://api.github.com/repos/onelogin/ruby-saml/contents/{+path}","compare_url":"https://api.github.com/repos/onelogin/ruby-saml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onelogin/ruby-saml/merges","archive_url":"https://api.github.com/repos/onelogin/ruby-saml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onelogin/ruby-saml/downloads","issues_url":"https://api.github.com/repos/onelogin/ruby-saml/issues{/number}","pulls_url":"https://api.github.com/repos/onelogin/ruby-saml/pulls{/number}","milestones_url":"https://api.github.com/repos/onelogin/ruby-saml/milestones{/number}","notifications_url":"https://api.github.com/repos/onelogin/ruby-saml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onelogin/ruby-saml/labels{/name}","releases_url":"https://api.github.com/repos/onelogin/ruby-saml/releases{/id}","created_at":"2010-05-03T18:39:04Z","updated_at":"2015-03-18T17:59:34Z","pushed_at":"2015-03-19T18:22:51Z","git_url":"git://github.com/onelogin/ruby-saml.git","ssh_url":"git@github.com:onelogin/ruby-saml.git","clone_url":"https://github.com/onelogin/ruby-saml.git","svn_url":"https://github.com/onelogin/ruby-saml","homepage":"http://support.onelogin.com/entries/165434-saml-toolkit-for-ruby-on-rails","size":3737,"stargazers_count":291,"watchers_count":291,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":249,"mirror_url":null,"open_issues_count":20,"forks":249,"open_issues":20,"watchers":291,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/onelogin/ruby-saml/pulls/207"},"html":{"href":"https://github.com/onelogin/ruby-saml/pull/207"},"issue":{"href":"https://api.github.com/repos/onelogin/ruby-saml/issues/207"},"comments":{"href":"https://api.github.com/repos/onelogin/ruby-saml/issues/207/comments"},"review_comments":{"href":"https://api.github.com/repos/onelogin/ruby-saml/pulls/207/comments"},"review_comment":{"href":"https://api.github.com/repos/onelogin/ruby-saml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/onelogin/ruby-saml/pulls/207/commits"},"statuses":{"href":"https://api.github.com/repos/onelogin/ruby-saml/statuses/d06b8649415a0baf53e925f0754e1ddbb7b2e119"}}}}