{"action":"created","issue":{"url":"https://api.github.com/repos/OPM/opm-autodiff/issues/445","labels_url":"https://api.github.com/repos/OPM/opm-autodiff/issues/445/labels{/name}","comments_url":"https://api.github.com/repos/OPM/opm-autodiff/issues/445/comments","events_url":"https://api.github.com/repos/OPM/opm-autodiff/issues/445/events","html_url":"https://github.com/OPM/opm-autodiff/pull/445","id":103537241,"number":445,"title":"update scaling factors for mass balance equations.","user":{"login":"GitPaean","id":6847941,"avatar_url":"https://avatars.githubusercontent.com/u/6847941?v=3","gravatar_id":"","url":"https://api.github.com/users/GitPaean","html_url":"https://github.com/GitPaean","followers_url":"https://api.github.com/users/GitPaean/followers","following_url":"https://api.github.com/users/GitPaean/following{/other_user}","gists_url":"https://api.github.com/users/GitPaean/gists{/gist_id}","starred_url":"https://api.github.com/users/GitPaean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GitPaean/subscriptions","organizations_url":"https://api.github.com/users/GitPaean/orgs","repos_url":"https://api.github.com/users/GitPaean/repos","events_url":"https://api.github.com/users/GitPaean/events{/privacy}","received_events_url":"https://api.github.com/users/GitPaean/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-08-27T15:36:50Z","updated_at":"2015-09-08T09:22:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OPM/opm-autodiff/pulls/445","html_url":"https://github.com/OPM/opm-autodiff/pull/445","diff_url":"https://github.com/OPM/opm-autodiff/pull/445.diff","patch_url":"https://github.com/OPM/opm-autodiff/pull/445.patch"},"body":"Updating the scaling factors based on average formation volume factors during each time step instead of the hard-coded scaling factors. \r\n\r\nThe hard-coded scaling factors are based on SPE9, while it has been working surprisingly well. \r\n\r\nThe performance tests are little not stable though, which is still dominated by the general iteration process. \r\nFor some input parameters, such as `solve_welleq_initially` and `use_interleaved` set true, with this PR, it can be faster for about 8%, while it still depends largely on whether some certain solution failures happens. \r\n\r\nFor some other parameters, it can be slightly slower.\r\n\r\nFor SPE9, it can be slower, while for SPE9, the fast solution from my side is that no scaling for the mass balance equations with `use_interleaved`. \r\n\r\nWith this PR, another `bool` command line option `update_equations_scaling` is added, which by default is set to be `false`. "},"comment":{"url":"https://api.github.com/repos/OPM/opm-autodiff/issues/comments/138493315","html_url":"https://github.com/OPM/opm-autodiff/pull/445#issuecomment-138493315","issue_url":"https://api.github.com/repos/OPM/opm-autodiff/issues/445","id":138493315,"user":{"login":"atgeirr","id":1876621,"avatar_url":"https://avatars.githubusercontent.com/u/1876621?v=3","gravatar_id":"","url":"https://api.github.com/users/atgeirr","html_url":"https://github.com/atgeirr","followers_url":"https://api.github.com/users/atgeirr/followers","following_url":"https://api.github.com/users/atgeirr/following{/other_user}","gists_url":"https://api.github.com/users/atgeirr/gists{/gist_id}","starred_url":"https://api.github.com/users/atgeirr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atgeirr/subscriptions","organizations_url":"https://api.github.com/users/atgeirr/orgs","repos_url":"https://api.github.com/users/atgeirr/repos","events_url":"https://api.github.com/users/atgeirr/events{/privacy}","received_events_url":"https://api.github.com/users/atgeirr/received_events","type":"User","site_admin":false},"created_at":"2015-09-08T09:22:56Z","updated_at":"2015-09-08T09:22:56Z","body":"Thanks for the update, will merge."}}