{"action":"closed","number":1187,"pull_request":{"url":"https://api.github.com/repos/bitovi/canjs/pulls/1187","id":19200880,"html_url":"https://github.com/bitovi/canjs/pull/1187","diff_url":"https://github.com/bitovi/canjs/pull/1187.diff","patch_url":"https://github.com/bitovi/canjs/pull/1187.patch","issue_url":"https://api.github.com/repos/bitovi/canjs/issues/1187","number":1187,"state":"closed","locked":false,"title":"Prevent empty routes from firing twice after can.route.ready","user":{"login":"moschel","id":22180,"avatar_url":"https://avatars.githubusercontent.com/u/22180?v=3","gravatar_id":"","url":"https://api.github.com/users/moschel","html_url":"https://github.com/moschel","followers_url":"https://api.github.com/users/moschel/followers","following_url":"https://api.github.com/users/moschel/following{/other_user}","gists_url":"https://api.github.com/users/moschel/gists{/gist_id}","starred_url":"https://api.github.com/users/moschel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moschel/subscriptions","organizations_url":"https://api.github.com/users/moschel/orgs","repos_url":"https://api.github.com/users/moschel/repos","events_url":"https://api.github.com/users/moschel/events{/privacy}","received_events_url":"https://api.github.com/users/moschel/received_events","type":"User","site_admin":false},"body":"Addresses #1185 with a test and a fix.\r\n\r\nThe problem was a check to see if a value that used to be there was no longer there, and calls removeAttr on that property. This check was lazy and checked for falsiness rather than the true absence of a property, so it was trying to remove a property on the \"route\" property, which in the case of an empty route, is an empty string, and thus falsey.","created_at":"2014-08-01T09:29:53Z","updated_at":"2015-02-10T20:59:15Z","closed_at":"2015-02-10T20:59:15Z","merged_at":"2015-02-10T20:59:15Z","merge_commit_sha":"3b60b121aec6dddea4b9c0ebaa86102c1b57e704","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bitovi/canjs/pulls/1187/commits","review_comments_url":"https://api.github.com/repos/bitovi/canjs/pulls/1187/comments","review_comment_url":"https://api.github.com/repos/bitovi/canjs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/bitovi/canjs/issues/1187/comments","statuses_url":"https://api.github.com/repos/bitovi/canjs/statuses/aa2040a922de6326ff55d0a050c844e7d417c2d5","head":{"label":"bitovi:1185-double-empty-route-fire","ref":"1185-double-empty-route-fire","sha":"aa2040a922de6326ff55d0a050c844e7d417c2d5","user":{"login":"bitovi","id":2782656,"avatar_url":"https://avatars.githubusercontent.com/u/2782656?v=3","gravatar_id":"","url":"https://api.github.com/users/bitovi","html_url":"https://github.com/bitovi","followers_url":"https://api.github.com/users/bitovi/followers","following_url":"https://api.github.com/users/bitovi/following{/other_user}","gists_url":"https://api.github.com/users/bitovi/gists{/gist_id}","starred_url":"https://api.github.com/users/bitovi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitovi/subscriptions","organizations_url":"https://api.github.com/users/bitovi/orgs","repos_url":"https://api.github.com/users/bitovi/repos","events_url":"https://api.github.com/users/bitovi/events{/privacy}","received_events_url":"https://api.github.com/users/bitovi/received_events","type":"Organization","site_admin":false},"repo":{"id":3228363,"name":"canjs","full_name":"bitovi/canjs","owner":{"login":"bitovi","id":2782656,"avatar_url":"https://avatars.githubusercontent.com/u/2782656?v=3","gravatar_id":"","url":"https://api.github.com/users/bitovi","html_url":"https://github.com/bitovi","followers_url":"https://api.github.com/users/bitovi/followers","following_url":"https://api.github.com/users/bitovi/following{/other_user}","gists_url":"https://api.github.com/users/bitovi/gists{/gist_id}","starred_url":"https://api.github.com/users/bitovi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitovi/subscriptions","organizations_url":"https://api.github.com/users/bitovi/orgs","repos_url":"https://api.github.com/users/bitovi/repos","events_url":"https://api.github.com/users/bitovi/events{/privacy}","received_events_url":"https://api.github.com/users/bitovi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitovi/canjs","description":"Can do JS, better, faster, easier.","fork":false,"url":"https://api.github.com/repos/bitovi/canjs","forks_url":"https://api.github.com/repos/bitovi/canjs/forks","keys_url":"https://api.github.com/repos/bitovi/canjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitovi/canjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitovi/canjs/teams","hooks_url":"https://api.github.com/repos/bitovi/canjs/hooks","issue_events_url":"https://api.github.com/repos/bitovi/canjs/issues/events{/number}","events_url":"https://api.github.com/repos/bitovi/canjs/events","assignees_url":"https://api.github.com/repos/bitovi/canjs/assignees{/user}","branches_url":"https://api.github.com/repos/bitovi/canjs/branches{/branch}","tags_url":"https://api.github.com/repos/bitovi/canjs/tags","blobs_url":"https://api.github.com/repos/bitovi/canjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitovi/canjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitovi/canjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitovi/canjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitovi/canjs/statuses/{sha}","languages_url":"https://api.github.com/repos/bitovi/canjs/languages","stargazers_url":"https://api.github.com/repos/bitovi/canjs/stargazers","contributors_url":"https://api.github.com/repos/bitovi/canjs/contributors","subscribers_url":"https://api.github.com/repos/bitovi/canjs/subscribers","subscription_url":"https://api.github.com/repos/bitovi/canjs/subscription","commits_url":"https://api.github.com/repos/bitovi/canjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitovi/canjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitovi/canjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitovi/canjs/issues/comments/{number}","contents_url":"https://api.github.com/repos/bitovi/canjs/contents/{+path}","compare_url":"https://api.github.com/repos/bitovi/canjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitovi/canjs/merges","archive_url":"https://api.github.com/repos/bitovi/canjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitovi/canjs/downloads","issues_url":"https://api.github.com/repos/bitovi/canjs/issues{/number}","pulls_url":"https://api.github.com/repos/bitovi/canjs/pulls{/number}","milestones_url":"https://api.github.com/repos/bitovi/canjs/milestones{/number}","notifications_url":"https://api.github.com/repos/bitovi/canjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitovi/canjs/labels{/name}","releases_url":"https://api.github.com/repos/bitovi/canjs/releases{/id}","created_at":"2012-01-20T17:57:21Z","updated_at":"2015-02-10T09:49:07Z","pushed_at":"2015-02-10T20:59:15Z","git_url":"git://github.com/bitovi/canjs.git","ssh_url":"git@github.com:bitovi/canjs.git","clone_url":"https://github.com/bitovi/canjs.git","svn_url":"https://github.com/bitovi/canjs","homepage":"canjs.com","size":43083,"stargazers_count":1084,"watchers_count":1084,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":302,"mirror_url":null,"open_issues_count":270,"forks":302,"open_issues":270,"watchers":1084,"default_branch":"master"}},"base":{"label":"bitovi:master","ref":"master","sha":"6c05d77bce12202928a93141282941070ecd76a3","user":{"login":"bitovi","id":2782656,"avatar_url":"https://avatars.githubusercontent.com/u/2782656?v=3","gravatar_id":"","url":"https://api.github.com/users/bitovi","html_url":"https://github.com/bitovi","followers_url":"https://api.github.com/users/bitovi/followers","following_url":"https://api.github.com/users/bitovi/following{/other_user}","gists_url":"https://api.github.com/users/bitovi/gists{/gist_id}","starred_url":"https://api.github.com/users/bitovi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitovi/subscriptions","organizations_url":"https://api.github.com/users/bitovi/orgs","repos_url":"https://api.github.com/users/bitovi/repos","events_url":"https://api.github.com/users/bitovi/events{/privacy}","received_events_url":"https://api.github.com/users/bitovi/received_events","type":"Organization","site_admin":false},"repo":{"id":3228363,"name":"canjs","full_name":"bitovi/canjs","owner":{"login":"bitovi","id":2782656,"avatar_url":"https://avatars.githubusercontent.com/u/2782656?v=3","gravatar_id":"","url":"https://api.github.com/users/bitovi","html_url":"https://github.com/bitovi","followers_url":"https://api.github.com/users/bitovi/followers","following_url":"https://api.github.com/users/bitovi/following{/other_user}","gists_url":"https://api.github.com/users/bitovi/gists{/gist_id}","starred_url":"https://api.github.com/users/bitovi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitovi/subscriptions","organizations_url":"https://api.github.com/users/bitovi/orgs","repos_url":"https://api.github.com/users/bitovi/repos","events_url":"https://api.github.com/users/bitovi/events{/privacy}","received_events_url":"https://api.github.com/users/bitovi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitovi/canjs","description":"Can do JS, better, faster, easier.","fork":false,"url":"https://api.github.com/repos/bitovi/canjs","forks_url":"https://api.github.com/repos/bitovi/canjs/forks","keys_url":"https://api.github.com/repos/bitovi/canjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitovi/canjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitovi/canjs/teams","hooks_url":"https://api.github.com/repos/bitovi/canjs/hooks","issue_events_url":"https://api.github.com/repos/bitovi/canjs/issues/events{/number}","events_url":"https://api.github.com/repos/bitovi/canjs/events","assignees_url":"https://api.github.com/repos/bitovi/canjs/assignees{/user}","branches_url":"https://api.github.com/repos/bitovi/canjs/branches{/branch}","tags_url":"https://api.github.com/repos/bitovi/canjs/tags","blobs_url":"https://api.github.com/repos/bitovi/canjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitovi/canjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitovi/canjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitovi/canjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitovi/canjs/statuses/{sha}","languages_url":"https://api.github.com/repos/bitovi/canjs/languages","stargazers_url":"https://api.github.com/repos/bitovi/canjs/stargazers","contributors_url":"https://api.github.com/repos/bitovi/canjs/contributors","subscribers_url":"https://api.github.com/repos/bitovi/canjs/subscribers","subscription_url":"https://api.github.com/repos/bitovi/canjs/subscription","commits_url":"https://api.github.com/repos/bitovi/canjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitovi/canjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitovi/canjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitovi/canjs/issues/comments/{number}","contents_url":"https://api.github.com/repos/bitovi/canjs/contents/{+path}","compare_url":"https://api.github.com/repos/bitovi/canjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitovi/canjs/merges","archive_url":"https://api.github.com/repos/bitovi/canjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitovi/canjs/downloads","issues_url":"https://api.github.com/repos/bitovi/canjs/issues{/number}","pulls_url":"https://api.github.com/repos/bitovi/canjs/pulls{/number}","milestones_url":"https://api.github.com/repos/bitovi/canjs/milestones{/number}","notifications_url":"https://api.github.com/repos/bitovi/canjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitovi/canjs/labels{/name}","releases_url":"https://api.github.com/repos/bitovi/canjs/releases{/id}","created_at":"2012-01-20T17:57:21Z","updated_at":"2015-02-10T09:49:07Z","pushed_at":"2015-02-10T20:59:15Z","git_url":"git://github.com/bitovi/canjs.git","ssh_url":"git@github.com:bitovi/canjs.git","clone_url":"https://github.com/bitovi/canjs.git","svn_url":"https://github.com/bitovi/canjs","homepage":"canjs.com","size":43083,"stargazers_count":1084,"watchers_count":1084,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":302,"mirror_url":null,"open_issues_count":270,"forks":302,"open_issues":270,"watchers":1084,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitovi/canjs/pulls/1187"},"html":{"href":"https://github.com/bitovi/canjs/pull/1187"},"issue":{"href":"https://api.github.com/repos/bitovi/canjs/issues/1187"},"comments":{"href":"https://api.github.com/repos/bitovi/canjs/issues/1187/comments"},"review_comments":{"href":"https://api.github.com/repos/bitovi/canjs/pulls/1187/comments"},"review_comment":{"href":"https://api.github.com/repos/bitovi/canjs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/bitovi/canjs/pulls/1187/commits"},"statuses":{"href":"https://api.github.com/repos/bitovi/canjs/statuses/aa2040a922de6326ff55d0a050c844e7d417c2d5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"daffl","id":338316,"avatar_url":"https://avatars.githubusercontent.com/u/338316?v=3","gravatar_id":"","url":"https://api.github.com/users/daffl","html_url":"https://github.com/daffl","followers_url":"https://api.github.com/users/daffl/followers","following_url":"https://api.github.com/users/daffl/following{/other_user}","gists_url":"https://api.github.com/users/daffl/gists{/gist_id}","starred_url":"https://api.github.com/users/daffl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daffl/subscriptions","organizations_url":"https://api.github.com/users/daffl/orgs","repos_url":"https://api.github.com/users/daffl/repos","events_url":"https://api.github.com/users/daffl/events{/privacy}","received_events_url":"https://api.github.com/users/daffl/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":17,"deletions":1,"changed_files":2}}