{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/12538","labels_url":"https://api.github.com/repos/elastic/elasticsearch/issues/12538/labels{/name}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/12538/comments","events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/12538/events","html_url":"https://github.com/elastic/elasticsearch/pull/12538","id":97983340,"number":12538,"title":"Updating default position_offset_gap to 10.","user":{"login":"mute","id":730349,"avatar_url":"https://avatars.githubusercontent.com/u/730349?v=3","gravatar_id":"","url":"https://api.github.com/users/mute","html_url":"https://github.com/mute","followers_url":"https://api.github.com/users/mute/followers","following_url":"https://api.github.com/users/mute/following{/other_user}","gists_url":"https://api.github.com/users/mute/gists{/gist_id}","starred_url":"https://api.github.com/users/mute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mute/subscriptions","organizations_url":"https://api.github.com/users/mute/orgs","repos_url":"https://api.github.com/users/mute/repos","events_url":"https://api.github.com/users/mute/events{/privacy}","received_events_url":"https://api.github.com/users/mute/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/:Mapping","name":":Mapping","color":"009800"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/review","name":"review","color":"0052cc"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/v2.0.0","name":"v2.0.0","color":"dddddd"}],"state":"open","locked":false,"assignee":{"login":"nik9000","id":215970,"avatar_url":"https://avatars.githubusercontent.com/u/215970?v=3","gravatar_id":"","url":"https://api.github.com/users/nik9000","html_url":"https://github.com/nik9000","followers_url":"https://api.github.com/users/nik9000/followers","following_url":"https://api.github.com/users/nik9000/following{/other_user}","gists_url":"https://api.github.com/users/nik9000/gists{/gist_id}","starred_url":"https://api.github.com/users/nik9000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nik9000/subscriptions","organizations_url":"https://api.github.com/users/nik9000/orgs","repos_url":"https://api.github.com/users/nik9000/repos","events_url":"https://api.github.com/users/nik9000/events{/privacy}","received_events_url":"https://api.github.com/users/nik9000/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-07-29T17:09:24Z","updated_at":"2015-07-29T18:13:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/12538","html_url":"https://github.com/elastic/elasticsearch/pull/12538","diff_url":"https://github.com/elastic/elasticsearch/pull/12538.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/12538.patch"},"body":"Addresses #7268.\r\n\r\nThis commit includes the suggestion to update the default in CustomAnalyzerProvider as well. It looks like the position_offset_gap setting was added there first and then the default was added subsequently in StringFieldMapper (#1812 and #1813), so there might have just been an oversight in sharing the default between them."},"comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments/126046334","html_url":"https://github.com/elastic/elasticsearch/pull/12538#issuecomment-126046334","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/12538","id":126046334,"user":{"login":"nik9000","id":215970,"avatar_url":"https://avatars.githubusercontent.com/u/215970?v=3","gravatar_id":"","url":"https://api.github.com/users/nik9000","html_url":"https://github.com/nik9000","followers_url":"https://api.github.com/users/nik9000/followers","following_url":"https://api.github.com/users/nik9000/following{/other_user}","gists_url":"https://api.github.com/users/nik9000/gists{/gist_id}","starred_url":"https://api.github.com/users/nik9000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nik9000/subscriptions","organizations_url":"https://api.github.com/users/nik9000/orgs","repos_url":"https://api.github.com/users/nik9000/repos","events_url":"https://api.github.com/users/nik9000/events{/privacy}","received_events_url":"https://api.github.com/users/nik9000/received_events","type":"User","site_admin":false},"created_at":"2015-07-29T18:13:39Z","updated_at":"2015-07-29T18:13:39Z","body":"Ok - I did a little digging into the CustomAnalyzer bit. So far as I can tell the values set in that don't get used - the values used in the mapping do.\r\n\r\nSo, in that case, this LGTM.\r\n\r\nI'd love it if you could add a test case that shows the default has changed.\r\n\r\nI'l pull this locally and verify that the tests pass."}}