{"action":"created","comment":{"url":"https://api.github.com/repos/openlayers/ol3/pulls/comments/40880157","id":40880157,"diff_hunk":"@@ -1166,7 +1166,7 @@ ol.Map.prototype.isDef = function() {\n  * @return {boolean} Is rendered.\n  */\n ol.Map.prototype.isRendered = function() {\n-  return !goog.isNull(this.frameState_);\n+  return this.frameState_ !== null;","path":"src/ol/map.js","position":135,"original_position":135,"commit_id":"66209b7dc83dd77b44dcd117e3b5e9ead047e55b","original_commit_id":"66209b7dc83dd77b44dcd117e3b5e9ead047e55b","user":{"login":"tschaub","id":41094,"avatar_url":"https://avatars.githubusercontent.com/u/41094?v=3","gravatar_id":"","url":"https://api.github.com/users/tschaub","html_url":"https://github.com/tschaub","followers_url":"https://api.github.com/users/tschaub/followers","following_url":"https://api.github.com/users/tschaub/following{/other_user}","gists_url":"https://api.github.com/users/tschaub/gists{/gist_id}","starred_url":"https://api.github.com/users/tschaub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschaub/subscriptions","organizations_url":"https://api.github.com/users/tschaub/orgs","repos_url":"https://api.github.com/users/tschaub/repos","events_url":"https://api.github.com/users/tschaub/events{/privacy}","received_events_url":"https://api.github.com/users/tschaub/received_events","type":"User","site_admin":false},"body":"Very minor byte savings with `return !!this.frameState_;`.","created_at":"2015-10-01T05:27:23Z","updated_at":"2015-10-01T05:27:23Z","html_url":"https://github.com/openlayers/ol3/pull/4192#discussion_r40880157","pull_request_url":"https://api.github.com/repos/openlayers/ol3/pulls/4192","_links":{"self":{"href":"https://api.github.com/repos/openlayers/ol3/pulls/comments/40880157"},"html":{"href":"https://github.com/openlayers/ol3/pull/4192#discussion_r40880157"},"pull_request":{"href":"https://api.github.com/repos/openlayers/ol3/pulls/4192"}}},"pull_request":{"url":"https://api.github.com/repos/openlayers/ol3/pulls/4192","id":46314256,"html_url":"https://github.com/openlayers/ol3/pull/4192","diff_url":"https://github.com/openlayers/ol3/pull/4192.diff","patch_url":"https://github.com/openlayers/ol3/pull/4192.patch","issue_url":"https://api.github.com/repos/openlayers/ol3/issues/4192","number":4192,"state":"open","locked":false,"title":"Remove use of goog.isNull in favor of simple truthy checks","user":{"login":"marcjansen","id":227934,"avatar_url":"https://avatars.githubusercontent.com/u/227934?v=3","gravatar_id":"","url":"https://api.github.com/users/marcjansen","html_url":"https://github.com/marcjansen","followers_url":"https://api.github.com/users/marcjansen/followers","following_url":"https://api.github.com/users/marcjansen/following{/other_user}","gists_url":"https://api.github.com/users/marcjansen/gists{/gist_id}","starred_url":"https://api.github.com/users/marcjansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcjansen/subscriptions","organizations_url":"https://api.github.com/users/marcjansen/orgs","repos_url":"https://api.github.com/users/marcjansen/repos","events_url":"https://api.github.com/users/marcjansen/events{/privacy}","received_events_url":"https://api.github.com/users/marcjansen/received_events","type":"User","site_admin":false},"body":"This PR contains commits that use simple truthy/falsy checks instead of `goog.isNull` or `foo !== null` and friends. I have double checked every change herein, but would really like a thorough review.\r\n\r\nOne change has been made to the previous logic, which I consider a bug in the original code: https://github.com/openlayers/ol3/pull/4192/files#diff-f6fd0d8a60d56e0391a62ade939c9719L106 \r\n\r\nPreviousy the lines read\r\n\r\n```javascript\r\n// …\r\n} else if (goog.isNull(this.lastFeature_)) {\r\n  var geom = this.lastFeature_.getGeometry();\r\n  // …\r\n}\r\n```\r\n\r\nnow these lines read\r\n\r\n```javascript\r\n// …\r\n} else if (this.lastFeature_) {\r\n  var geom = this.lastFeature_.getGeometry();\r\n  // …\r\n}\r\n```\r\n\r\nwhich makes a lot more sense.\r\n\r\nThanks for any review.\r\n\r\nThis PR supersedes #4178.\r\n\r\n See #4128\r\n\r\n/cc @tschaub \r\n","created_at":"2015-09-29T18:33:02Z","updated_at":"2015-10-01T05:27:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea286bd9eb93ffda8a579c8a319f9369e27940cf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openlayers/ol3/pulls/4192/commits","review_comments_url":"https://api.github.com/repos/openlayers/ol3/pulls/4192/comments","review_comment_url":"https://api.github.com/repos/openlayers/ol3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openlayers/ol3/issues/4192/comments","statuses_url":"https://api.github.com/repos/openlayers/ol3/statuses/66209b7dc83dd77b44dcd117e3b5e9ead047e55b","head":{"label":"marcjansen:simpler-no-is-null","ref":"simpler-no-is-null","sha":"66209b7dc83dd77b44dcd117e3b5e9ead047e55b","user":{"login":"marcjansen","id":227934,"avatar_url":"https://avatars.githubusercontent.com/u/227934?v=3","gravatar_id":"","url":"https://api.github.com/users/marcjansen","html_url":"https://github.com/marcjansen","followers_url":"https://api.github.com/users/marcjansen/followers","following_url":"https://api.github.com/users/marcjansen/following{/other_user}","gists_url":"https://api.github.com/users/marcjansen/gists{/gist_id}","starred_url":"https://api.github.com/users/marcjansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcjansen/subscriptions","organizations_url":"https://api.github.com/users/marcjansen/orgs","repos_url":"https://api.github.com/users/marcjansen/repos","events_url":"https://api.github.com/users/marcjansen/events{/privacy}","received_events_url":"https://api.github.com/users/marcjansen/received_events","type":"User","site_admin":false},"repo":{"id":5977547,"name":"ol3","full_name":"marcjansen/ol3","owner":{"login":"marcjansen","id":227934,"avatar_url":"https://avatars.githubusercontent.com/u/227934?v=3","gravatar_id":"","url":"https://api.github.com/users/marcjansen","html_url":"https://github.com/marcjansen","followers_url":"https://api.github.com/users/marcjansen/followers","following_url":"https://api.github.com/users/marcjansen/following{/other_user}","gists_url":"https://api.github.com/users/marcjansen/gists{/gist_id}","starred_url":"https://api.github.com/users/marcjansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcjansen/subscriptions","organizations_url":"https://api.github.com/users/marcjansen/orgs","repos_url":"https://api.github.com/users/marcjansen/repos","events_url":"https://api.github.com/users/marcjansen/events{/privacy}","received_events_url":"https://api.github.com/users/marcjansen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marcjansen/ol3","description":"OpenLayers 3","fork":true,"url":"https://api.github.com/repos/marcjansen/ol3","forks_url":"https://api.github.com/repos/marcjansen/ol3/forks","keys_url":"https://api.github.com/repos/marcjansen/ol3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marcjansen/ol3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marcjansen/ol3/teams","hooks_url":"https://api.github.com/repos/marcjansen/ol3/hooks","issue_events_url":"https://api.github.com/repos/marcjansen/ol3/issues/events{/number}","events_url":"https://api.github.com/repos/marcjansen/ol3/events","assignees_url":"https://api.github.com/repos/marcjansen/ol3/assignees{/user}","branches_url":"https://api.github.com/repos/marcjansen/ol3/branches{/branch}","tags_url":"https://api.github.com/repos/marcjansen/ol3/tags","blobs_url":"https://api.github.com/repos/marcjansen/ol3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marcjansen/ol3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marcjansen/ol3/git/refs{/sha}","trees_url":"https://api.github.com/repos/marcjansen/ol3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marcjansen/ol3/statuses/{sha}","languages_url":"https://api.github.com/repos/marcjansen/ol3/languages","stargazers_url":"https://api.github.com/repos/marcjansen/ol3/stargazers","contributors_url":"https://api.github.com/repos/marcjansen/ol3/contributors","subscribers_url":"https://api.github.com/repos/marcjansen/ol3/subscribers","subscription_url":"https://api.github.com/repos/marcjansen/ol3/subscription","commits_url":"https://api.github.com/repos/marcjansen/ol3/commits{/sha}","git_commits_url":"https://api.github.com/repos/marcjansen/ol3/git/commits{/sha}","comments_url":"https://api.github.com/repos/marcjansen/ol3/comments{/number}","issue_comment_url":"https://api.github.com/repos/marcjansen/ol3/issues/comments{/number}","contents_url":"https://api.github.com/repos/marcjansen/ol3/contents/{+path}","compare_url":"https://api.github.com/repos/marcjansen/ol3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marcjansen/ol3/merges","archive_url":"https://api.github.com/repos/marcjansen/ol3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marcjansen/ol3/downloads","issues_url":"https://api.github.com/repos/marcjansen/ol3/issues{/number}","pulls_url":"https://api.github.com/repos/marcjansen/ol3/pulls{/number}","milestones_url":"https://api.github.com/repos/marcjansen/ol3/milestones{/number}","notifications_url":"https://api.github.com/repos/marcjansen/ol3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marcjansen/ol3/labels{/name}","releases_url":"https://api.github.com/repos/marcjansen/ol3/releases{/id}","created_at":"2012-09-27T05:32:07Z","updated_at":"2015-05-08T07:36:51Z","pushed_at":"2015-10-01T05:11:17Z","git_url":"git://github.com/marcjansen/ol3.git","ssh_url":"git@github.com:marcjansen/ol3.git","clone_url":"https://github.com/marcjansen/ol3.git","svn_url":"https://github.com/marcjansen/ol3","homepage":null,"size":42159,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openlayers:master","ref":"master","sha":"e6c5fa9cd7438302b1a13224346314111cc8cd62","user":{"login":"openlayers","id":240579,"avatar_url":"https://avatars.githubusercontent.com/u/240579?v=3","gravatar_id":"","url":"https://api.github.com/users/openlayers","html_url":"https://github.com/openlayers","followers_url":"https://api.github.com/users/openlayers/followers","following_url":"https://api.github.com/users/openlayers/following{/other_user}","gists_url":"https://api.github.com/users/openlayers/gists{/gist_id}","starred_url":"https://api.github.com/users/openlayers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openlayers/subscriptions","organizations_url":"https://api.github.com/users/openlayers/orgs","repos_url":"https://api.github.com/users/openlayers/repos","events_url":"https://api.github.com/users/openlayers/events{/privacy}","received_events_url":"https://api.github.com/users/openlayers/received_events","type":"Organization","site_admin":false},"repo":{"id":4723248,"name":"ol3","full_name":"openlayers/ol3","owner":{"login":"openlayers","id":240579,"avatar_url":"https://avatars.githubusercontent.com/u/240579?v=3","gravatar_id":"","url":"https://api.github.com/users/openlayers","html_url":"https://github.com/openlayers","followers_url":"https://api.github.com/users/openlayers/followers","following_url":"https://api.github.com/users/openlayers/following{/other_user}","gists_url":"https://api.github.com/users/openlayers/gists{/gist_id}","starred_url":"https://api.github.com/users/openlayers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openlayers/subscriptions","organizations_url":"https://api.github.com/users/openlayers/orgs","repos_url":"https://api.github.com/users/openlayers/repos","events_url":"https://api.github.com/users/openlayers/events{/privacy}","received_events_url":"https://api.github.com/users/openlayers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openlayers/ol3","description":"OpenLayers 3","fork":false,"url":"https://api.github.com/repos/openlayers/ol3","forks_url":"https://api.github.com/repos/openlayers/ol3/forks","keys_url":"https://api.github.com/repos/openlayers/ol3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openlayers/ol3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openlayers/ol3/teams","hooks_url":"https://api.github.com/repos/openlayers/ol3/hooks","issue_events_url":"https://api.github.com/repos/openlayers/ol3/issues/events{/number}","events_url":"https://api.github.com/repos/openlayers/ol3/events","assignees_url":"https://api.github.com/repos/openlayers/ol3/assignees{/user}","branches_url":"https://api.github.com/repos/openlayers/ol3/branches{/branch}","tags_url":"https://api.github.com/repos/openlayers/ol3/tags","blobs_url":"https://api.github.com/repos/openlayers/ol3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openlayers/ol3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openlayers/ol3/git/refs{/sha}","trees_url":"https://api.github.com/repos/openlayers/ol3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openlayers/ol3/statuses/{sha}","languages_url":"https://api.github.com/repos/openlayers/ol3/languages","stargazers_url":"https://api.github.com/repos/openlayers/ol3/stargazers","contributors_url":"https://api.github.com/repos/openlayers/ol3/contributors","subscribers_url":"https://api.github.com/repos/openlayers/ol3/subscribers","subscription_url":"https://api.github.com/repos/openlayers/ol3/subscription","commits_url":"https://api.github.com/repos/openlayers/ol3/commits{/sha}","git_commits_url":"https://api.github.com/repos/openlayers/ol3/git/commits{/sha}","comments_url":"https://api.github.com/repos/openlayers/ol3/comments{/number}","issue_comment_url":"https://api.github.com/repos/openlayers/ol3/issues/comments{/number}","contents_url":"https://api.github.com/repos/openlayers/ol3/contents/{+path}","compare_url":"https://api.github.com/repos/openlayers/ol3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openlayers/ol3/merges","archive_url":"https://api.github.com/repos/openlayers/ol3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openlayers/ol3/downloads","issues_url":"https://api.github.com/repos/openlayers/ol3/issues{/number}","pulls_url":"https://api.github.com/repos/openlayers/ol3/pulls{/number}","milestones_url":"https://api.github.com/repos/openlayers/ol3/milestones{/number}","notifications_url":"https://api.github.com/repos/openlayers/ol3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openlayers/ol3/labels{/name}","releases_url":"https://api.github.com/repos/openlayers/ol3/releases{/id}","created_at":"2012-06-20T06:53:59Z","updated_at":"2015-09-30T14:23:31Z","pushed_at":"2015-10-01T05:09:57Z","git_url":"git://github.com/openlayers/ol3.git","ssh_url":"git@github.com:openlayers/ol3.git","clone_url":"https://github.com/openlayers/ol3.git","svn_url":"https://github.com/openlayers/ol3","homepage":"http://openlayers.org","size":101689,"stargazers_count":1401,"watchers_count":1401,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":803,"mirror_url":null,"open_issues_count":408,"forks":803,"open_issues":408,"watchers":1401,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openlayers/ol3/pulls/4192"},"html":{"href":"https://github.com/openlayers/ol3/pull/4192"},"issue":{"href":"https://api.github.com/repos/openlayers/ol3/issues/4192"},"comments":{"href":"https://api.github.com/repos/openlayers/ol3/issues/4192/comments"},"review_comments":{"href":"https://api.github.com/repos/openlayers/ol3/pulls/4192/comments"},"review_comment":{"href":"https://api.github.com/repos/openlayers/ol3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openlayers/ol3/pulls/4192/commits"},"statuses":{"href":"https://api.github.com/repos/openlayers/ol3/statuses/66209b7dc83dd77b44dcd117e3b5e9ead047e55b"}}}}