{"action":"created","issue":{"url":"https://api.github.com/repos/OPM/opm-common/issues/59","labels_url":"https://api.github.com/repos/OPM/opm-common/issues/59/labels{/name}","comments_url":"https://api.github.com/repos/OPM/opm-common/issues/59/comments","events_url":"https://api.github.com/repos/OPM/opm-common/issues/59/events","html_url":"https://github.com/OPM/opm-common/pull/59","id":112668810,"number":59,"title":"Do not use REALPATH for OPM_DATA_ROOT.","user":{"login":"atgeirr","id":1876621,"avatar_url":"https://avatars.githubusercontent.com/u/1876621?v=3","gravatar_id":"","url":"https://api.github.com/users/atgeirr","html_url":"https://github.com/atgeirr","followers_url":"https://api.github.com/users/atgeirr/followers","following_url":"https://api.github.com/users/atgeirr/following{/other_user}","gists_url":"https://api.github.com/users/atgeirr/gists{/gist_id}","starred_url":"https://api.github.com/users/atgeirr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atgeirr/subscriptions","organizations_url":"https://api.github.com/users/atgeirr/orgs","repos_url":"https://api.github.com/users/atgeirr/repos","events_url":"https://api.github.com/users/atgeirr/events{/privacy}","received_events_url":"https://api.github.com/users/atgeirr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-10-21T20:07:20Z","updated_at":"2015-10-22T05:02:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OPM/opm-common/pulls/59","html_url":"https://github.com/OPM/opm-common/pull/59","diff_url":"https://github.com/OPM/opm-common/pull/59.diff","patch_url":"https://github.com/OPM/opm-common/pull/59.patch"},"body":"This caused trouble when the PROJECT_SOURCE_DIR is a symlink. When 'b' is a symlink, 'a/b/../' is not the same as 'a', but that is exactly what REALPATH does. In this case, it means that the opm-data is found (at ../ relative to the symlink), but the path that is set does not point to it.\r\n\r\nThis resulted in opm-data-dependent tests being run that then failed since the path was wrong.\r\n\r\nThis is the first time I have successfully debugged a cmake problem (message() is my new friend), so bear with me if the solution is rough... In order to get a release out soon, I'd appreciate a quick review (and merge if ok) by @andlaus, @bska, @joakim-hove, @blattms, @akva2 or @dr-robertk."},"comment":{"url":"https://api.github.com/repos/OPM/opm-common/issues/comments/150106495","html_url":"https://github.com/OPM/opm-common/pull/59#issuecomment-150106495","issue_url":"https://api.github.com/repos/OPM/opm-common/issues/59","id":150106495,"user":{"login":"atgeirr","id":1876621,"avatar_url":"https://avatars.githubusercontent.com/u/1876621?v=3","gravatar_id":"","url":"https://api.github.com/users/atgeirr","html_url":"https://github.com/atgeirr","followers_url":"https://api.github.com/users/atgeirr/followers","following_url":"https://api.github.com/users/atgeirr/following{/other_user}","gists_url":"https://api.github.com/users/atgeirr/gists{/gist_id}","starred_url":"https://api.github.com/users/atgeirr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atgeirr/subscriptions","organizations_url":"https://api.github.com/users/atgeirr/orgs","repos_url":"https://api.github.com/users/atgeirr/repos","events_url":"https://api.github.com/users/atgeirr/events{/privacy}","received_events_url":"https://api.github.com/users/atgeirr/received_events","type":"User","site_admin":false},"created_at":"2015-10-22T05:02:01Z","updated_at":"2015-10-22T05:02:01Z","body":"> So unless cmake is using a buggy homemade version of realpath()?? - whatever.\r\n\r\nIndeed that is the case, or at least the behaviour is different from the C function. It has been reported as an issue with CMake two years ago or so, and I did not see any fix coming. I am not 100% sure if that is what I was bitten by though -- it could also be since REALPATH was used for the final path but not for the file check."}}