{"action":"created","comment":{"url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/comments/22891503","id":22891503,"diff_hunk":"@@ -412,7 +411,7 @@ void cTelnet::setDisplayDimensions()\n \n void cTelnet::sendTelnetOption( char type, char option )\n {\n-#ifdef DEBUG_TELNET\n+#if defined( DEBUG_TELNET ) && ( DEBUG_TELNET & 0x1 )","path":"src/ctelnet.cpp","position":51,"original_position":51,"commit_id":"aa86c307af6f601d4fcf9cfe884d666ce5e47d61","original_commit_id":"aa86c307af6f601d4fcf9cfe884d666ce5e47d61","user":{"login":"Chris7","id":963909,"avatar_url":"https://avatars.githubusercontent.com/u/963909?v=3","gravatar_id":"","url":"https://api.github.com/users/Chris7","html_url":"https://github.com/Chris7","followers_url":"https://api.github.com/users/Chris7/followers","following_url":"https://api.github.com/users/Chris7/following{/other_user}","gists_url":"https://api.github.com/users/Chris7/gists{/gist_id}","starred_url":"https://api.github.com/users/Chris7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chris7/subscriptions","organizations_url":"https://api.github.com/users/Chris7/orgs","repos_url":"https://api.github.com/users/Chris7/repos","events_url":"https://api.github.com/users/Chris7/events{/privacy}","received_events_url":"https://api.github.com/users/Chris7/received_events","type":"User","site_admin":false},"body":"again...why are these bundled?","created_at":"2015-01-13T20:22:40Z","updated_at":"2015-01-13T20:22:40Z","html_url":"https://github.com/Mudlet/Mudlet/pull/214#discussion_r22891503","pull_request_url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/214","_links":{"self":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/comments/22891503"},"html":{"href":"https://github.com/Mudlet/Mudlet/pull/214#discussion_r22891503"},"pull_request":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/214"}}},"pull_request":{"url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/214","id":22618122,"html_url":"https://github.com/Mudlet/Mudlet/pull/214","diff_url":"https://github.com/Mudlet/Mudlet/pull/214.diff","patch_url":"https://github.com/Mudlet/Mudlet/pull/214.patch","issue_url":"https://api.github.com/repos/Mudlet/Mudlet/issues/214","number":214,"state":"open","locked":false,"title":"Rebased4 fix replay","user":{"login":"SlySven","id":6163092,"avatar_url":"https://avatars.githubusercontent.com/u/6163092?v=3","gravatar_id":"","url":"https://api.github.com/users/SlySven","html_url":"https://github.com/SlySven","followers_url":"https://api.github.com/users/SlySven/followers","following_url":"https://api.github.com/users/SlySven/following{/other_user}","gists_url":"https://api.github.com/users/SlySven/gists{/gist_id}","starred_url":"https://api.github.com/users/SlySven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SlySven/subscriptions","organizations_url":"https://api.github.com/users/SlySven/orgs","repos_url":"https://api.github.com/users/SlySven/repos","events_url":"https://api.github.com/users/SlySven/events{/privacy}","received_events_url":"https://api.github.com/users/SlySven/received_events","type":"User","site_admin":false},"body":"Right, hopefully I've taken on-board all the points raised about #200 others have made with the exception of:\r\n* Not not renaming some variables/members: _I felt that the names I changed were justified despite the fact that it might make it harder to trace the other changes.  In one case the convention of prefixing class members with an 'm' (and pointers with 'p') pointed out to me where a method's local variable (which erroneously had an 'm' prefix) was masking a class member with the same name which would cause issue when the member was used when it had not been set to the wanted value._\r\n\r\n~~* For a method that returned messages about the action it did or the error that prevented it from doing so that required two different style of message depending on the caller, _returning both types and allowing the caller to choose which to use_ was not the optimum solution because it also had to configure whether another method would send a further message or not when _that_ had finished. In other circumstances it might have been worth considering but not this time!~~","created_at":"2014-10-12T17:44:01Z","updated_at":"2015-01-13T20:22:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"99c96d6ca62c2c84c144074c6b55727fbb546897","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/214/commits","review_comments_url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/214/comments","review_comment_url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Mudlet/Mudlet/issues/214/comments","statuses_url":"https://api.github.com/repos/Mudlet/Mudlet/statuses/aa86c307af6f601d4fcf9cfe884d666ce5e47d61","head":{"label":"SlySven:rebased4_fixReplay","ref":"rebased4_fixReplay","sha":"aa86c307af6f601d4fcf9cfe884d666ce5e47d61","user":{"login":"SlySven","id":6163092,"avatar_url":"https://avatars.githubusercontent.com/u/6163092?v=3","gravatar_id":"","url":"https://api.github.com/users/SlySven","html_url":"https://github.com/SlySven","followers_url":"https://api.github.com/users/SlySven/followers","following_url":"https://api.github.com/users/SlySven/following{/other_user}","gists_url":"https://api.github.com/users/SlySven/gists{/gist_id}","starred_url":"https://api.github.com/users/SlySven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SlySven/subscriptions","organizations_url":"https://api.github.com/users/SlySven/orgs","repos_url":"https://api.github.com/users/SlySven/repos","events_url":"https://api.github.com/users/SlySven/events{/privacy}","received_events_url":"https://api.github.com/users/SlySven/received_events","type":"User","site_admin":false},"repo":{"id":22490921,"name":"Mudlet","full_name":"SlySven/Mudlet","owner":{"login":"SlySven","id":6163092,"avatar_url":"https://avatars.githubusercontent.com/u/6163092?v=3","gravatar_id":"","url":"https://api.github.com/users/SlySven","html_url":"https://github.com/SlySven","followers_url":"https://api.github.com/users/SlySven/followers","following_url":"https://api.github.com/users/SlySven/following{/other_user}","gists_url":"https://api.github.com/users/SlySven/gists{/gist_id}","starred_url":"https://api.github.com/users/SlySven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SlySven/subscriptions","organizations_url":"https://api.github.com/users/SlySven/orgs","repos_url":"https://api.github.com/users/SlySven/repos","events_url":"https://api.github.com/users/SlySven/events{/privacy}","received_events_url":"https://api.github.com/users/SlySven/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SlySven/Mudlet","description":"A modern open source MUD client with a graphical user inteface and full built in Lua scripting support for all major platforms.","fork":true,"url":"https://api.github.com/repos/SlySven/Mudlet","forks_url":"https://api.github.com/repos/SlySven/Mudlet/forks","keys_url":"https://api.github.com/repos/SlySven/Mudlet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SlySven/Mudlet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SlySven/Mudlet/teams","hooks_url":"https://api.github.com/repos/SlySven/Mudlet/hooks","issue_events_url":"https://api.github.com/repos/SlySven/Mudlet/issues/events{/number}","events_url":"https://api.github.com/repos/SlySven/Mudlet/events","assignees_url":"https://api.github.com/repos/SlySven/Mudlet/assignees{/user}","branches_url":"https://api.github.com/repos/SlySven/Mudlet/branches{/branch}","tags_url":"https://api.github.com/repos/SlySven/Mudlet/tags","blobs_url":"https://api.github.com/repos/SlySven/Mudlet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SlySven/Mudlet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SlySven/Mudlet/git/refs{/sha}","trees_url":"https://api.github.com/repos/SlySven/Mudlet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SlySven/Mudlet/statuses/{sha}","languages_url":"https://api.github.com/repos/SlySven/Mudlet/languages","stargazers_url":"https://api.github.com/repos/SlySven/Mudlet/stargazers","contributors_url":"https://api.github.com/repos/SlySven/Mudlet/contributors","subscribers_url":"https://api.github.com/repos/SlySven/Mudlet/subscribers","subscription_url":"https://api.github.com/repos/SlySven/Mudlet/subscription","commits_url":"https://api.github.com/repos/SlySven/Mudlet/commits{/sha}","git_commits_url":"https://api.github.com/repos/SlySven/Mudlet/git/commits{/sha}","comments_url":"https://api.github.com/repos/SlySven/Mudlet/comments{/number}","issue_comment_url":"https://api.github.com/repos/SlySven/Mudlet/issues/comments/{number}","contents_url":"https://api.github.com/repos/SlySven/Mudlet/contents/{+path}","compare_url":"https://api.github.com/repos/SlySven/Mudlet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SlySven/Mudlet/merges","archive_url":"https://api.github.com/repos/SlySven/Mudlet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SlySven/Mudlet/downloads","issues_url":"https://api.github.com/repos/SlySven/Mudlet/issues{/number}","pulls_url":"https://api.github.com/repos/SlySven/Mudlet/pulls{/number}","milestones_url":"https://api.github.com/repos/SlySven/Mudlet/milestones{/number}","notifications_url":"https://api.github.com/repos/SlySven/Mudlet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SlySven/Mudlet/labels{/name}","releases_url":"https://api.github.com/repos/SlySven/Mudlet/releases{/id}","created_at":"2014-08-01T01:05:26Z","updated_at":"2015-01-08T03:57:15Z","pushed_at":"2015-01-10T18:47:02Z","git_url":"git://github.com/SlySven/Mudlet.git","ssh_url":"git@github.com:SlySven/Mudlet.git","clone_url":"https://github.com/SlySven/Mudlet.git","svn_url":"https://github.com/SlySven/Mudlet","homepage":null,"size":20102,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"development"}},"base":{"label":"Mudlet:development","ref":"development","sha":"b0e447d8b16b816f9fb02cc176bf91ff44aa8b8a","user":{"login":"Mudlet","id":6158612,"avatar_url":"https://avatars.githubusercontent.com/u/6158612?v=3","gravatar_id":"","url":"https://api.github.com/users/Mudlet","html_url":"https://github.com/Mudlet","followers_url":"https://api.github.com/users/Mudlet/followers","following_url":"https://api.github.com/users/Mudlet/following{/other_user}","gists_url":"https://api.github.com/users/Mudlet/gists{/gist_id}","starred_url":"https://api.github.com/users/Mudlet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mudlet/subscriptions","organizations_url":"https://api.github.com/users/Mudlet/orgs","repos_url":"https://api.github.com/users/Mudlet/repos","events_url":"https://api.github.com/users/Mudlet/events{/privacy}","received_events_url":"https://api.github.com/users/Mudlet/received_events","type":"Organization","site_admin":false},"repo":{"id":15108812,"name":"Mudlet","full_name":"Mudlet/Mudlet","owner":{"login":"Mudlet","id":6158612,"avatar_url":"https://avatars.githubusercontent.com/u/6158612?v=3","gravatar_id":"","url":"https://api.github.com/users/Mudlet","html_url":"https://github.com/Mudlet","followers_url":"https://api.github.com/users/Mudlet/followers","following_url":"https://api.github.com/users/Mudlet/following{/other_user}","gists_url":"https://api.github.com/users/Mudlet/gists{/gist_id}","starred_url":"https://api.github.com/users/Mudlet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mudlet/subscriptions","organizations_url":"https://api.github.com/users/Mudlet/orgs","repos_url":"https://api.github.com/users/Mudlet/repos","events_url":"https://api.github.com/users/Mudlet/events{/privacy}","received_events_url":"https://api.github.com/users/Mudlet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Mudlet/Mudlet","description":"A modern open source MUD client with a graphical user inteface and full built in Lua scripting support for all major platforms.","fork":false,"url":"https://api.github.com/repos/Mudlet/Mudlet","forks_url":"https://api.github.com/repos/Mudlet/Mudlet/forks","keys_url":"https://api.github.com/repos/Mudlet/Mudlet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mudlet/Mudlet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mudlet/Mudlet/teams","hooks_url":"https://api.github.com/repos/Mudlet/Mudlet/hooks","issue_events_url":"https://api.github.com/repos/Mudlet/Mudlet/issues/events{/number}","events_url":"https://api.github.com/repos/Mudlet/Mudlet/events","assignees_url":"https://api.github.com/repos/Mudlet/Mudlet/assignees{/user}","branches_url":"https://api.github.com/repos/Mudlet/Mudlet/branches{/branch}","tags_url":"https://api.github.com/repos/Mudlet/Mudlet/tags","blobs_url":"https://api.github.com/repos/Mudlet/Mudlet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mudlet/Mudlet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mudlet/Mudlet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mudlet/Mudlet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mudlet/Mudlet/statuses/{sha}","languages_url":"https://api.github.com/repos/Mudlet/Mudlet/languages","stargazers_url":"https://api.github.com/repos/Mudlet/Mudlet/stargazers","contributors_url":"https://api.github.com/repos/Mudlet/Mudlet/contributors","subscribers_url":"https://api.github.com/repos/Mudlet/Mudlet/subscribers","subscription_url":"https://api.github.com/repos/Mudlet/Mudlet/subscription","commits_url":"https://api.github.com/repos/Mudlet/Mudlet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mudlet/Mudlet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mudlet/Mudlet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mudlet/Mudlet/issues/comments/{number}","contents_url":"https://api.github.com/repos/Mudlet/Mudlet/contents/{+path}","compare_url":"https://api.github.com/repos/Mudlet/Mudlet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mudlet/Mudlet/merges","archive_url":"https://api.github.com/repos/Mudlet/Mudlet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mudlet/Mudlet/downloads","issues_url":"https://api.github.com/repos/Mudlet/Mudlet/issues{/number}","pulls_url":"https://api.github.com/repos/Mudlet/Mudlet/pulls{/number}","milestones_url":"https://api.github.com/repos/Mudlet/Mudlet/milestones{/number}","notifications_url":"https://api.github.com/repos/Mudlet/Mudlet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mudlet/Mudlet/labels{/name}","releases_url":"https://api.github.com/repos/Mudlet/Mudlet/releases{/id}","created_at":"2013-12-11T14:04:21Z","updated_at":"2015-01-12T17:28:02Z","pushed_at":"2015-01-12T20:18:19Z","git_url":"git://github.com/Mudlet/Mudlet.git","ssh_url":"git@github.com:Mudlet/Mudlet.git","clone_url":"https://github.com/Mudlet/Mudlet.git","svn_url":"https://github.com/Mudlet/Mudlet","homepage":null,"size":22422,"stargazers_count":22,"watchers_count":22,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":17,"forks":19,"open_issues":17,"watchers":22,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/214"},"html":{"href":"https://github.com/Mudlet/Mudlet/pull/214"},"issue":{"href":"https://api.github.com/repos/Mudlet/Mudlet/issues/214"},"comments":{"href":"https://api.github.com/repos/Mudlet/Mudlet/issues/214/comments"},"review_comments":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/214/comments"},"review_comment":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/214/commits"},"statuses":{"href":"https://api.github.com/repos/Mudlet/Mudlet/statuses/aa86c307af6f601d4fcf9cfe884d666ce5e47d61"}}}}