{"push_id":603558660,"size":680,"distinct_size":680,"ref":"refs/heads/master","head":"9e8d08c3aaa213089d69c1d8ebd7b014118dc201","before":"5e7542998d51152aa9929b9191f0046740eedf9d","commits":[{"sha":"93bf2360045e8fcbc9753887274d2ca91fe28859","author":{"email":"bb1f132dcb86bfc59bf4a043a3139a9ac7c0b658@gmail.com","name":"Stu Hood"},"message":"Add support for doing remote publishes with an explicit snapshot name\n\nThis patch initially contributed by Ian O`Connell allows for local or remote publishing of \"named snapshots\". Named snapshots skip semantic versioning, and  record a \"named_version\" in the pushdb.\n\nTesting Done:\nadditional publishing smoketest\n\n$ yes | PANTS_DEV=1 ./pants goal publish \\\n  --publish-local=blah \\\n  --no-publish-dryrun \\\n  --publish-force \\\n  --publish-named-snapshot=436ae2dee0e2fc15a6ccfd2fcec5231b8e127a8d \\\n  examples/src/java/com/pants/examples/hello/greet\n...\n\n$ ls -lR blah\ntotal 0\ndrwxrwx---  3 stuhood  admin  102 Aug 21 18:20 com\n\nblah/com:\ntotal 0\ndrwxrwx---  3 stuhood  admin  102 Aug 21 18:20 pants\n\nblah/com/pants:\ntotal 0\ndrwxrwx---  3 stuhood  admin  102 Aug 21 18:20 examples\n\nblah/com/pants/examples:\ntotal 0\ndrwxrwx---  3 stuhood  admin  102 Aug 21 18:20 hello-greet\n\nblah/com/pants/examples/hello-greet:\ntotal 0\ndrwxrwx---  17 stuhood  admin  578 Aug 21 18:20 436ae2dee0e2fc15a6ccfd2fcec5231b8e127a8d\n\nblah/com/pants/examples/hello-greet/436ae2dee0e2fc15a6ccfd2fcec5231b8e127a8d:\ntotal 184\n-rw-rw----  1 stuhood  admin  34462 Aug 21 18:20 hello-greet-436ae2dee0e2fc15a6ccfd2fcec5231b8e127a8d-javadoc.jar\n-rw-rw----  1 stuhood  admin     32 Aug 21 18:20 hello-greet-436ae2dee0e2fc15a6ccfd2fcec5231b8e127a8d-javadoc.jar.md5\n-rw-rw----  1 stuhood  admin     40 Aug 21 18:20 hello-greet-436ae2dee0e2fc15a6ccfd2fcec5231b8e127a8d-javadoc.jar.sha1\n-rw-rw----  1 stuhood  admin   1635 Aug 21 18:20 hello-greet-436ae2dee0e2fc15a6ccfd2fcec5231b8e127a8d-sources.jar\n-rw-rw----  1 stuhood  admin     32 Aug 21 18:20 hello-greet-436ae2dee0e2fc15a6ccfd2fcec5231b8e127a8d-sources.jar.md5\n-rw-rw----  1 stuhood  admin     40 Aug 21 18:20 hello-greet-436ae2dee0e2fc15a6ccfd2fcec5231b8e127a8d-sources.jar.sha1\n-rw-rw----  1 stuhood  admin   2046 Aug 21 18:20 hello-greet-436ae2dee0e2fc15a6ccfd2fcec5231b8e127a8d.jar\n-rw-rw----  1 stuhood  admin     32 Aug 21 18:20 hello-greet-436ae2dee0e2fc15a6ccfd2fcec5231b8e127a8d.jar.md5\n-rw-rw----  1 stuhood  admin     40 Aug 21 18:20 hello-greet-436ae2dee0e2fc15a6ccfd2fcec5231b8e127a8d.jar.sha1\n-rw-rw----  1 stuhood  admin    867 Aug 21 18:20 hello-greet-436ae2dee0e2fc15a6ccfd2fcec5231b8e127a8d.pom\n-rw-rw----  1 stuhood  admin     32 Aug 21 18:20 hello-greet-436ae2dee0e2fc15a6ccfd2fcec5231b8e127a8d.pom.md5\n-rw-rw----  1 stuhood  admin     40 Aug 21 18:20 hello-greet-436ae2dee0e2fc15a6ccfd2fcec5231b8e127a8d.pom.sha1\n-rw-rw----  1 stuhood  admin   1009 Aug 21 18:20 ivy-436ae2dee0e2fc15a6ccfd2fcec5231b8e127a8d.xml\n-rw-rw----  1 stuhood  admin     32 Aug 21 18:20 ivy-436ae2dee0e2fc15a6ccfd2fcec5231b8e127a8d.xml.md5\n-rw-rw----  1 stuhood  admin     40 Aug 21 18:20 ivy-436ae2dee0e2fc15a6ccfd2fcec5231b8e127a8d.xml.sha1\n\nReviewed at https://rbcommons.com/s/twitter/r/923/","distinct":true,"url":"https://api.github.com/repos/WamBamBoozle/pants/commits/93bf2360045e8fcbc9753887274d2ca91fe28859"},{"sha":"bc0a924ddadf8a0f93776ca42d41cde979d95d26","author":{"email":"265b11d407c862ea192a8410d23f331de8c26758@lahosken.san-francisco.ca.us","name":"larry hosken (Twitter)"},"message":"doc: don't recommend python_test(entry_point=).\n\nIt's cruel to recommend no-longer-existing params\n\nReviewed at https://rbcommons.com/s/twitter/r/965/","distinct":true,"url":"https://api.github.com/repos/WamBamBoozle/pants/commits/bc0a924ddadf8a0f93776ca42d41cde979d95d26"},{"sha":"bd9daeff7ba8ba8de6b85a77a5fda31cb3d99c62","author":{"email":"265b11d407c862ea192a8410d23f331de8c26758@lahosken.san-francisco.ca.us","name":"larry hosken (Twitter)"},"message":"howto_contribute: changing UX? then add to CHANGELOG.rst. and maybe docs\n\nI've been forgetting to update the CHANGELOG.rst file. Maybe I'll remember it if I add a mention to the docs... either because it's doc'd or because of memories of this public confession.\n\nBugs closed: 397\n\nReviewed at https://rbcommons.com/s/twitter/r/992/","distinct":true,"url":"https://api.github.com/repos/WamBamBoozle/pants/commits/bd9daeff7ba8ba8de6b85a77a5fda31cb3d99c62"},{"sha":"540d17e2cfe44c465842466e59ba2de17cf7f2c8","author":{"email":"265b11d407c862ea192a8410d23f331de8c26758@lahosken.san-francisco.ca.us","name":"larry hosken (Twitter)"},"message":"remember to update the CHANGELOG\n\nReviewed at https://rbcommons.com/s/twitter/r/993/","distinct":true,"url":"https://api.github.com/repos/WamBamBoozle/pants/commits/540d17e2cfe44c465842466e59ba2de17cf7f2c8"},{"sha":"47f3d03a8c2f28b4b167ed5883639ec232971c28","author":{"email":"695d76d5a2f51dc9340d65ccd0d72ad7560773f9@squareup.com","name":"Eric Ayers"},"message":"When a directory contains both a java_library and junit_test def, make sure the IDE understands this is a test pth, not a lib path\n\nIn our repo we have projects with BUILD files with 2 targets like:\n\n```\njava_libary(name='lib', ...)\njunit_test(name='test', ...)\n```\n\nSometimes, the ide_gen code saw the 'java_library' target first and considered that a regular source path, not a test source path, which causes tests to break in the IDE if they depend on libraries only defined in another test source path.  In project.iml, we would see the path defined with is_test=\"False\"\n\nThis is just a workaround, as ide_gen still might not always add test folders properly:  If there is a java_library defined in a BUILD file under /src/test/java but no  junit_test, ide_gen mistakenly thinks this is plain source path, not a test source path.\n\nTesting Done:\nRe-ran goal idea on our test targets, the folders containing both tests and libraries that were previously 'blue' (regular source paths) are now green as they should be.\n\nBugs closed: 551\n\nReviewed at https://rbcommons.com/s/twitter/r/996/","distinct":true,"url":"https://api.github.com/repos/WamBamBoozle/pants/commits/47f3d03a8c2f28b4b167ed5883639ec232971c28"},{"sha":"a9068406693f6621cb87d005deb76e30c03cb58b","author":{"email":"b4756a3093a14f002c9a92f87d0d8cef89f9f5fb@outlook.com","name":"Jin Feng"},"message":"initial draft of publishing a pants test infra package to facilitate external pants plugin testing\n\nBugs closed: 539\n\nReviewed at https://rbcommons.com/s/twitter/r/997/","distinct":true,"url":"https://api.github.com/repos/WamBamBoozle/pants/commits/a9068406693f6621cb87d005deb76e30c03cb58b"},{"sha":"ec7e13377b3018100163393201539b6f8e94da03","author":{"email":"695d76d5a2f51dc9340d65ccd0d72ad7560773f9@squareup.com","name":"Eric Ayers"},"message":"Added source root tests, updated the internal data structure to include a tree.\n\nAdded source root tests, updated the internal data structure to include a tree to speed up the find() operation.\n\nWith 1000+ source roots in our environment, this appears to shave about 5 seconds off of a no-op build.\n\nTesting Done:\nRetrofitted tests for SourceRoot.\nAdded new unit tests for SourceRootTree data structure\n\nCI passed at: https://travis-ci.org/pantsbuild/pants/builds/34713735\n\nBugs closed: 556\n\nReviewed at https://rbcommons.com/s/twitter/r/1003/","distinct":true,"url":"https://api.github.com/repos/WamBamBoozle/pants/commits/ec7e13377b3018100163393201539b6f8e94da03"},{"sha":"c76c1fecdce768bed099674da66847d09f5aa939","author":{"email":"e6790d662e1019ca6c466f6e9c1c2294cd870ba9@gmail.com","name":"Tejal Desai"},"message":"Add flag to dump project info output to file.\n\nThis file option will be used in intellij plugin.\n\nTesting Done:\nhttps://travis-ci.org/pantsbuild/pants/builds/34542731\n\nThis is OS Pants review for https://github.com/pantsbuild/intellij-pants-plugin/issues/5\n\nBugs closed: https://github.com/pantsbuild/intellij-pants-plugin/issues/5\n\nReviewed at https://rbcommons.com/s/twitter/r/998/","distinct":true,"url":"https://api.github.com/repos/WamBamBoozle/pants/commits/c76c1fecdce768bed099674da66847d09f5aa939"},{"sha":"a470f1332ad507c5fbcdddfeedcf41b49e58634e","author":{"email":"265b11d407c862ea192a8410d23f331de8c26758@lahosken.san-francisco.ca.us","name":"larry hosken (Twitter)"},"message":"doc: update 3rdparty_py to mention requirements.txt and python_requirements\n\npython_requirement() is nice, too, but it's not your only choice\n\nReviewed at https://rbcommons.com/s/twitter/r/995/","distinct":true,"url":"https://api.github.com/repos/WamBamBoozle/pants/commits/a470f1332ad507c5fbcdddfeedcf41b49e58634e"},{"sha":"08bd14589ed0f7f31424189fa2990b146cefef6a","author":{"email":"2700019cef58b76c97a994f3ec46da1e3309f52a@gmail.com","name":"Fedor Korotkov"},"message":"fixed --depmap-project-info for scala sources with the same package_prefix\n\nthe problem was that we were using same current_target  for all collected source roots. not the proper target this root is part of.\n\nTesting Done:\ntests are passing\n\nReviewed at https://rbcommons.com/s/twitter/r/990/","distinct":true,"url":"https://api.github.com/repos/WamBamBoozle/pants/commits/08bd14589ed0f7f31424189fa2990b146cefef6a"},{"sha":"6041b945c70d68304d7a5fd3bdda893da8fd77b7","author":{"email":"b4756a3093a14f002c9a92f87d0d8cef89f9f5fb@outlook.com","name":"Jin Feng"},"message":"update release.sh and release.rst to include pantsbuild.pants.testinfra\n\nMoving on, we'll publish two packages at the same time: pantsbuild.pants\nand pantsbuild.pants.testinfra to PyPi. While they're sim-released, users\nof pants can choose to install pants only if they don't have any\ncustomization to pants thus avoiding the need of writing additional test\ncases to which the pantsbuild.pants.testinfra would be helpful.\n\nTesting Done:\nI'm not the owner of pantsbuild.pants package on PyPi, so all my testing are local:\n\nbuild-support/bin/release.sh -t\nbuild-support/bin/release.sh -n\n\ntested both. For the '-n' dry-run, I've also manually injected some failures at pants, pants_testinfra build stages, as well some failures in their testing commands, to have verified the proper command chaining behavior of the bash script.\n\nBugs closed: 539\n\nReviewed at https://rbcommons.com/s/twitter/r/1004/","distinct":true,"url":"https://api.github.com/repos/WamBamBoozle/pants/commits/6041b945c70d68304d7a5fd3bdda893da8fd77b7"},{"sha":"eba81ffa3639fc6278015dd8e99e42c3f0b710c6","author":{"email":"695d76d5a2f51dc9340d65ccd0d72ad7560773f9@squareup.com","name":"Eric Ayers"},"message":"Adds the --<goal>-use-source-root for IDE project generation tasks.\n\nThe option will put one entry for each source_root registered that has an active path in the project.\nThis is useful for Maven style layouts.\n\nTesting Done:\nAdded unit test and integration test.\n\nManually tested with:\n\n  pants goal idea testprojects/maven_layout:: --idea-use-source-root\n\nCI is running.\n\nBugs closed: 558\n\nReviewed at https://rbcommons.com/s/twitter/r/1006/","distinct":true,"url":"https://api.github.com/repos/WamBamBoozle/pants/commits/eba81ffa3639fc6278015dd8e99e42c3f0b710c6"},{"sha":"f9caf9f75364467426e51dae940912de2c04d20e","author":{"email":"bb1f132dcb86bfc59bf4a043a3139a9ac7c0b658@gmail.com","name":"Stu Hood"},"message":"Skipping a doc phase should result in transitive deps being skipped as well.\n\nWhen `--doc-javadoc-skip` or `--doc-scaladoc-skip` are passed to a transitive publish, products generated by those goals will not be available, and should not be depended on in the Ivy javadoc configuration that JarPublish generates. Otherwise, Ivy will fail to resolve the transitive `javadoc` configuration during publishing.\n\n* Expand existing targets to test transitive publishing of java/scala\n* Simplify to-string for jar_coordinate of pushdb entries\n* Don`t request docs unless they are available for all transitive targets\n\nTesting Done:\nnew test, and manual publishing with --doc-scaladoc-skip and --doc-javadoc-skip\n\nReviewed at https://rbcommons.com/s/twitter/r/1011/","distinct":true,"url":"https://api.github.com/repos/WamBamBoozle/pants/commits/f9caf9f75364467426e51dae940912de2c04d20e"},{"sha":"df4a168b2ce4b1b928b5f47a59599e55ac50c870","author":{"email":"2700019cef58b76c97a994f3ec46da1e3309f52a@gmail.com","name":"Fedor Korotkov"},"message":"depmap KeyError fix\n\nTesting Done:\nci\n\nReviewed at https://rbcommons.com/s/twitter/r/1015/","distinct":true,"url":"https://api.github.com/repos/WamBamBoozle/pants/commits/df4a168b2ce4b1b928b5f47a59599e55ac50c870"},{"sha":"ef909e2edb62b80e0aa6b678a3fa1b1e73f36dde","author":{"email":"265b11d407c862ea192a8410d23f331de8c26758@lahosken.san-francisco.ca.us","name":"larry hosken (Twitter)"},"message":"update and narrow down our \"setting up Pants is hard\" message\n\npantsbuild.pants is is a thing. So stop saying it's not installable.\n\nWe had commented out stuff about how to install it. Un-comment it.\n\nFor a venv-y example, see twitter/commons; not pants' repo, that was only true for a brief time.\n\nBUT, setting up Pants in your code workspace still requires a PhD in Pants-ology. So shift our scary warning over to the setup_repo page.\n\nReviewed at https://rbcommons.com/s/twitter/r/1007/","distinct":true,"url":"https://api.github.com/repos/WamBamBoozle/pants/commits/ef909e2edb62b80e0aa6b678a3fa1b1e73f36dde"},{"sha":"bd07c0a8d6790200ca51379089aa889cb1485013","author":{"email":"86f39098c3d6e8fa24cceea9f4753c2782977b2d@gmail.com","name":"John Sirois"},"message":"Fixup test deps\n\nThese were revealed broken by running in non-fast mode.\n\nTesting Done:\n$ rm -rf pants.pex dist/ && ./pants build tests/python/pants_test:all\n\nCI is went green here: https://travis-ci.org/pantsbuild/pants/builds/34972075\n\nBugs closed: 369, 569\n\nReviewed at https://rbcommons.com/s/twitter/r/1016/","distinct":true,"url":"https://api.github.com/repos/WamBamBoozle/pants/commits/bd07c0a8d6790200ca51379089aa889cb1485013"},{"sha":"ba650cc07292465e7c48077b4c915f31c164549a","author":{"email":"695d76d5a2f51dc9340d65ccd0d72ad7560773f9@squareup.com","name":"Eric Ayers"},"message":"Changes the behavior of goal idea to create a subdirectory named for the project name.\n\nIntelliJ will fail to load the first time if you change the name and try to write the project into\nthe same directory as an existing project.\n\nAlso, enhanced the integration check to examine the contents of the project file when launching \"hello\"\n\nTesting Done:\nManually confirmed the error \"Cannot load module file '/Users/zundel/Development/java/squarepants/idea/foo4568.iml':\nFile /Users/zundel/Development/java/squarepants/idea/foo4568.iml does not exist\nWould you like to remove module 'foo4568' from the project?\"\n\ndoes not occur any more when you change the project name.\n\nBugs closed: 564, 571\n\nReviewed at https://rbcommons.com/s/twitter/r/1019/","distinct":true,"url":"https://api.github.com/repos/WamBamBoozle/pants/commits/ba650cc07292465e7c48077b4c915f31c164549a"},{"sha":"263c8dff7af651524f78845f79f51591359177d5","author":{"email":"265b11d407c862ea192a8410d23f331de8c26758@lahosken.san-francisco.ca.us","name":"larry hosken (Twitter)"},"message":"doc: top page linked to 404/broken pages. so remove those links\n\nIndex had links to BUILD dictionary entries, but nothing else.\nModule Index is 404.\nSearch page is empty\n\nReviewed at https://rbcommons.com/s/twitter/r/1020/","distinct":true,"url":"https://api.github.com/repos/WamBamBoozle/pants/commits/263c8dff7af651524f78845f79f51591359177d5"},{"sha":"7d1f81228f5acf438a0d10d3b7450ab155ecc3b2","author":{"email":"695d76d5a2f51dc9340d65ccd0d72ad7560773f9@squareup.com","name":"Eric Ayers"},"message":"Added unit tests for registering a source root path with no targets\n\nTesting Done:\nAdded a unit test requested by Patrick.   Passed CI @ https://travis-ci.org/pantsbuild/pants/builds/35208443\n\nBugs closed: 573\n\nReviewed at https://rbcommons.com/s/twitter/r/1027/","distinct":true,"url":"https://api.github.com/repos/WamBamBoozle/pants/commits/7d1f81228f5acf438a0d10d3b7450ab155ecc3b2"},{"sha":"657106c463bae226cae608d5703b74ed09c7dd2b","author":{"email":"265b11d407c862ea192a8410d23f331de8c26758@lahosken.san-francisco.ca.us","name":"larry hosken (Twitter)"},"message":"'goal builddict' Target classes \"inherit\" docstrings, signatures\n\nNowadays, our BUILD target implementations use class inheritance + some constructor idioms. But the BUILD Dictionary hasn't kept up. Thus, we have boilerplate docstrings and documented signatures like android_binary(build_type=None, *args, **kwargs)\n\nThis change...\n\nSpecial-cases target handling in src/python/pants/backend/core/tasks/builddictionary.py to go up the inheritence tree, pull apart and re-assemble signatures and docstrings. Also, special-cases leaving out implementation-params we don't want in the user-facing doc (address, build_graph, payload). It doesn't have a general mechanism for leaving stuff out, though. E.g., python_binary's entry thinks it has a sources param (inherited from PythonTarget); mitigated by having a docstring for it saying \"overridden: use source instead\".\n\nRemoves many many redundant docstring fragments. My search wasn't scientific. Probably other removal-worthy pieces lurk.\n\nAdds some docstrings. E.g. python_binary's \"sources: overridden\". Move some docstrings to superclass for easier inheriting.\n\nTesting Done:\nhttps://travis-ci.org/pantsbuild/pants/builds/35162328\n\nReviewed at https://rbcommons.com/s/twitter/r/1018/","distinct":true,"url":"https://api.github.com/repos/WamBamBoozle/pants/commits/657106c463bae226cae608d5703b74ed09c7dd2b"}]}