{"action":"created","issue":{"url":"https://api.github.com/repos/learningequality/ka-lite/issues/2897","labels_url":"https://api.github.com/repos/learningequality/ka-lite/issues/2897/labels{/name}","comments_url":"https://api.github.com/repos/learningequality/ka-lite/issues/2897/comments","events_url":"https://api.github.com/repos/learningequality/ka-lite/issues/2897/events","html_url":"https://github.com/learningequality/ka-lite/pull/2897","id":55587097,"number":2897,"title":"Fixed issue #2888: 'Show keypad' button floating around","user":{"login":"Antrikshy","id":6601788,"avatar_url":"https://avatars.githubusercontent.com/u/6601788?v=3","gravatar_id":"","url":"https://api.github.com/users/Antrikshy","html_url":"https://github.com/Antrikshy","followers_url":"https://api.github.com/users/Antrikshy/followers","following_url":"https://api.github.com/users/Antrikshy/following{/other_user}","gists_url":"https://api.github.com/users/Antrikshy/gists{/gist_id}","starred_url":"https://api.github.com/users/Antrikshy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Antrikshy/subscriptions","organizations_url":"https://api.github.com/users/Antrikshy/orgs","repos_url":"https://api.github.com/users/Antrikshy/repos","events_url":"https://api.github.com/users/Antrikshy/events{/privacy}","received_events_url":"https://api.github.com/users/Antrikshy/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/learningequality/ka-lite/labels/has%20PR","name":"has PR","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-01-27T08:03:35Z","updated_at":"2015-01-27T17:40:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/learningequality/ka-lite/pulls/2897","html_url":"https://github.com/learningequality/ka-lite/pull/2897","diff_url":"https://github.com/learningequality/ka-lite/pull/2897.diff","patch_url":"https://github.com/learningequality/ka-lite/pull/2897.patch"},"body":"This should fix issue #2888. The 'show keypad' button now sits where it should and matches the hint and scratchpad buttons. Software keyboard has been tweaked slightly. The buttons are now `simple-button`s instead of the weird `green_button` class (which had no CSS styling anywhere LOL).\r\n\r\n![screen shot 2015-01-26 at 11 48 43 pm](https://cloud.githubusercontent.com/assets/6601788/5915207/a9e4e868-a5b7-11e4-89ad-f59a1f164778.png)\r\n\r\nThings are now pixel-perfect!\r\n\r\nI have also improved the coloring on the main green buttons that I edited with the recent overhaul. They match the orange buttons better.\r\n\r\n> I had some trouble with my local clone and had to fiddle around a bit. Ignore the \"changes\" to `models.js` and `views.js`. Unless I'm missing something, the changes it shows for both those files match the current versions of those files in the develop branch. Nothing should change. Sorry if it causes any trouble."},"comment":{"url":"https://api.github.com/repos/learningequality/ka-lite/issues/comments/71691702","html_url":"https://github.com/learningequality/ka-lite/pull/2897#issuecomment-71691702","issue_url":"https://api.github.com/repos/learningequality/ka-lite/issues/2897","id":71691702,"user":{"login":"rtibbles","id":1680573,"avatar_url":"https://avatars.githubusercontent.com/u/1680573?v=3","gravatar_id":"","url":"https://api.github.com/users/rtibbles","html_url":"https://github.com/rtibbles","followers_url":"https://api.github.com/users/rtibbles/followers","following_url":"https://api.github.com/users/rtibbles/following{/other_user}","gists_url":"https://api.github.com/users/rtibbles/gists{/gist_id}","starred_url":"https://api.github.com/users/rtibbles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtibbles/subscriptions","organizations_url":"https://api.github.com/users/rtibbles/orgs","repos_url":"https://api.github.com/users/rtibbles/repos","events_url":"https://api.github.com/users/rtibbles/events{/privacy}","received_events_url":"https://api.github.com/users/rtibbles/received_events","type":"User","site_admin":false},"created_at":"2015-01-27T17:40:55Z","updated_at":"2015-01-27T17:40:55Z","body":"In khan-lite.css there is a class called .key-bs that is being applied to the \"Del\" key. I think just deleting this definition (and then deleting its application in the line I annotated) should make this align properly."}}