{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/30784142","id":30784142,"diff_hunk":"@@ -36,19 +36,20 @@ import org.apache.flink.ml.optimization.Solver._\n   * At the moment, the whole partition is used for SGD, making it effectively a batch gradient\n   * descent. Once a sampling operator has been introduced, the algorithm can be optimized\n   *\n-  * @param runParameters The parameters to tune the algorithm. Currently these include:\n-  *                      [[Solver.LossFunction]] for the loss function to be used,\n-  *                      [[Solver.RegularizationType]] for the type of regularization,\n-  *                      [[Solver.RegularizationParameter]] for the regularization parameter,\n+  *  The parameters to tune the algorithm are:\n+  *                      [[Solver.LossFunctionParameter]] for the loss function to be used,\n+  *                      [[Solver.RegularizationTypeParameter]] for the type of regularization,\n+  *                      [[Solver.RegularizationValueParameter]] for the regularization parameter,","path":"flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/GradientDescent.scala","position":20,"original_position":20,"commit_id":"b0a462046a2db7b7d524c5bbaf55ca5f79cc6a7f","original_commit_id":"b0a462046a2db7b7d524c5bbaf55ca5f79cc6a7f","user":{"login":"thvasilo","id":9048995,"avatar_url":"https://avatars.githubusercontent.com/u/9048995?v=3","gravatar_id":"","url":"https://api.github.com/users/thvasilo","html_url":"https://github.com/thvasilo","followers_url":"https://api.github.com/users/thvasilo/followers","following_url":"https://api.github.com/users/thvasilo/following{/other_user}","gists_url":"https://api.github.com/users/thvasilo/gists{/gist_id}","starred_url":"https://api.github.com/users/thvasilo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thvasilo/subscriptions","organizations_url":"https://api.github.com/users/thvasilo/orgs","repos_url":"https://api.github.com/users/thvasilo/repos","events_url":"https://api.github.com/users/thvasilo/events{/privacy}","received_events_url":"https://api.github.com/users/thvasilo/received_events","type":"User","site_admin":false},"body":"I'm doing this to avoid confusion between the LossFunction class and the parameter setting here. Having the same name I think creates some confusion, especially when auto-completing stuff in Intellij. However the names are starting to get pretty long.\r\n\r\nYou think we should remove this?","created_at":"2015-05-21T08:59:20Z","updated_at":"2015-05-21T08:59:20Z","html_url":"https://github.com/apache/flink/pull/692#discussion_r30784142","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/692","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/30784142"},"html":{"href":"https://github.com/apache/flink/pull/692#discussion_r30784142"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/692"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/692","id":35650941,"html_url":"https://github.com/apache/flink/pull/692","diff_url":"https://github.com/apache/flink/pull/692.diff","patch_url":"https://github.com/apache/flink/pull/692.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/692","number":692,"state":"open","locked":false,"title":"[FLINK-1992] [ml]  Add convergence criterion to SGD optimizer","user":{"login":"thvasilo","id":9048995,"avatar_url":"https://avatars.githubusercontent.com/u/9048995?v=3","gravatar_id":"","url":"https://api.github.com/users/thvasilo","html_url":"https://github.com/thvasilo","followers_url":"https://api.github.com/users/thvasilo/followers","following_url":"https://api.github.com/users/thvasilo/following{/other_user}","gists_url":"https://api.github.com/users/thvasilo/gists{/gist_id}","starred_url":"https://api.github.com/users/thvasilo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thvasilo/subscriptions","organizations_url":"https://api.github.com/users/thvasilo/orgs","repos_url":"https://api.github.com/users/thvasilo/repos","events_url":"https://api.github.com/users/thvasilo/events{/privacy}","received_events_url":"https://api.github.com/users/thvasilo/received_events","type":"User","site_admin":false},"body":"This a WIP PR in order to add convergence critertion to SGD. This will also allow us to replace the custom SGD used in Multiple Linear Regression (FLINK-1993)","created_at":"2015-05-18T16:34:49Z","updated_at":"2015-05-21T08:59:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c5192599e40bac1f39d8bc16b1f6ee50974f690","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/692/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/692/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/692/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/b0a462046a2db7b7d524c5bbaf55ca5f79cc6a7f","head":{"label":"thvasilo:sgd-convegrence","ref":"sgd-convegrence","sha":"b0a462046a2db7b7d524c5bbaf55ca5f79cc6a7f","user":{"login":"thvasilo","id":9048995,"avatar_url":"https://avatars.githubusercontent.com/u/9048995?v=3","gravatar_id":"","url":"https://api.github.com/users/thvasilo","html_url":"https://github.com/thvasilo","followers_url":"https://api.github.com/users/thvasilo/followers","following_url":"https://api.github.com/users/thvasilo/following{/other_user}","gists_url":"https://api.github.com/users/thvasilo/gists{/gist_id}","starred_url":"https://api.github.com/users/thvasilo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thvasilo/subscriptions","organizations_url":"https://api.github.com/users/thvasilo/orgs","repos_url":"https://api.github.com/users/thvasilo/repos","events_url":"https://api.github.com/users/thvasilo/events{/privacy}","received_events_url":"https://api.github.com/users/thvasilo/received_events","type":"User","site_admin":false},"repo":{"id":31908956,"name":"flink","full_name":"thvasilo/flink","owner":{"login":"thvasilo","id":9048995,"avatar_url":"https://avatars.githubusercontent.com/u/9048995?v=3","gravatar_id":"","url":"https://api.github.com/users/thvasilo","html_url":"https://github.com/thvasilo","followers_url":"https://api.github.com/users/thvasilo/followers","following_url":"https://api.github.com/users/thvasilo/following{/other_user}","gists_url":"https://api.github.com/users/thvasilo/gists{/gist_id}","starred_url":"https://api.github.com/users/thvasilo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thvasilo/subscriptions","organizations_url":"https://api.github.com/users/thvasilo/orgs","repos_url":"https://api.github.com/users/thvasilo/repos","events_url":"https://api.github.com/users/thvasilo/events{/privacy}","received_events_url":"https://api.github.com/users/thvasilo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thvasilo/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/thvasilo/flink","forks_url":"https://api.github.com/repos/thvasilo/flink/forks","keys_url":"https://api.github.com/repos/thvasilo/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thvasilo/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thvasilo/flink/teams","hooks_url":"https://api.github.com/repos/thvasilo/flink/hooks","issue_events_url":"https://api.github.com/repos/thvasilo/flink/issues/events{/number}","events_url":"https://api.github.com/repos/thvasilo/flink/events","assignees_url":"https://api.github.com/repos/thvasilo/flink/assignees{/user}","branches_url":"https://api.github.com/repos/thvasilo/flink/branches{/branch}","tags_url":"https://api.github.com/repos/thvasilo/flink/tags","blobs_url":"https://api.github.com/repos/thvasilo/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thvasilo/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thvasilo/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/thvasilo/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thvasilo/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/thvasilo/flink/languages","stargazers_url":"https://api.github.com/repos/thvasilo/flink/stargazers","contributors_url":"https://api.github.com/repos/thvasilo/flink/contributors","subscribers_url":"https://api.github.com/repos/thvasilo/flink/subscribers","subscription_url":"https://api.github.com/repos/thvasilo/flink/subscription","commits_url":"https://api.github.com/repos/thvasilo/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/thvasilo/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/thvasilo/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/thvasilo/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/thvasilo/flink/contents/{+path}","compare_url":"https://api.github.com/repos/thvasilo/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thvasilo/flink/merges","archive_url":"https://api.github.com/repos/thvasilo/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thvasilo/flink/downloads","issues_url":"https://api.github.com/repos/thvasilo/flink/issues{/number}","pulls_url":"https://api.github.com/repos/thvasilo/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/thvasilo/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/thvasilo/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thvasilo/flink/labels{/name}","releases_url":"https://api.github.com/repos/thvasilo/flink/releases{/id}","created_at":"2015-03-09T16:14:55Z","updated_at":"2015-04-24T12:16:55Z","pushed_at":"2015-05-20T16:40:04Z","git_url":"git://github.com/thvasilo/flink.git","ssh_url":"git@github.com:thvasilo/flink.git","clone_url":"https://github.com/thvasilo/flink.git","svn_url":"https://github.com/thvasilo/flink","homepage":null,"size":48541,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"a6f6a6777860a1b66840aafc53c28fc9c9bf9eef","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"name":"flink","full_name":"apache/flink","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/flink","description":"Mirror of Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","created_at":"2014-06-07T07:00:10Z","updated_at":"2015-05-21T07:37:47Z","pushed_at":"2015-05-21T08:59:10Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":null,"size":3142740,"stargazers_count":418,"watchers_count":418,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":261,"mirror_url":"git://git.apache.org/incubator-flink.git","open_issues_count":47,"forks":261,"open_issues":47,"watchers":418,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/692"},"html":{"href":"https://github.com/apache/flink/pull/692"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/692"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/692/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/692/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/692/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/b0a462046a2db7b7d524c5bbaf55ca5f79cc6a7f"}}}}