{"action":"created","comment":{"url":"https://api.github.com/repos/opencontainers/runc/pulls/comments/37692817","id":37692817,"diff_hunk":"@@ -20,7 +25,12 @@ test: runctestimage\n \tdocker run -e TESTFLAGS --privileged --rm -v $(CURDIR):/go/src/$(PROJECT) $(RUNC_TEST_IMAGE) make localtest\n \n localtest:\n+ifdef BUILD_TAGS\n+\tgo test -tags $(BUILD_TAGS) ${TESTFLAGS} -v ./...","path":"Makefile","position":21,"original_position":21,"commit_id":"2f270db8f5bbf432cc262f512fa1807edbb135ca","original_commit_id":"2f270db8f5bbf432cc262f512fa1807edbb135ca","user":{"login":"LK4D4","id":101445,"avatar_url":"https://avatars.githubusercontent.com/u/101445?v=3","gravatar_id":"","url":"https://api.github.com/users/LK4D4","html_url":"https://github.com/LK4D4","followers_url":"https://api.github.com/users/LK4D4/followers","following_url":"https://api.github.com/users/LK4D4/following{/other_user}","gists_url":"https://api.github.com/users/LK4D4/gists{/gist_id}","starred_url":"https://api.github.com/users/LK4D4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LK4D4/subscriptions","organizations_url":"https://api.github.com/users/LK4D4/orgs","repos_url":"https://api.github.com/users/LK4D4/repos","events_url":"https://api.github.com/users/LK4D4/events{/privacy}","received_events_url":"https://api.github.com/users/LK4D4/received_events","type":"User","site_admin":false},"body":"I think it's simpler to use just `\"$(BUILD_TAGS)\"`, `-tags \"\"` is valid syntax.","created_at":"2015-08-22T05:22:28Z","updated_at":"2015-08-22T05:22:28Z","html_url":"https://github.com/opencontainers/runc/pull/220#discussion_r37692817","pull_request_url":"https://api.github.com/repos/opencontainers/runc/pulls/220","_links":{"self":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/comments/37692817"},"html":{"href":"https://github.com/opencontainers/runc/pull/220#discussion_r37692817"},"pull_request":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/220"}}},"pull_request":{"url":"https://api.github.com/repos/opencontainers/runc/pulls/220","id":43087221,"html_url":"https://github.com/opencontainers/runc/pull/220","diff_url":"https://github.com/opencontainers/runc/pull/220.diff","patch_url":"https://github.com/opencontainers/runc/pull/220.patch","issue_url":"https://api.github.com/repos/opencontainers/runc/issues/220","number":220,"state":"open","locked":false,"title":"Add seccomp build tag","user":{"login":"crosbymichael","id":749551,"avatar_url":"https://avatars.githubusercontent.com/u/749551?v=3","gravatar_id":"","url":"https://api.github.com/users/crosbymichael","html_url":"https://github.com/crosbymichael","followers_url":"https://api.github.com/users/crosbymichael/followers","following_url":"https://api.github.com/users/crosbymichael/following{/other_user}","gists_url":"https://api.github.com/users/crosbymichael/gists{/gist_id}","starred_url":"https://api.github.com/users/crosbymichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosbymichael/subscriptions","organizations_url":"https://api.github.com/users/crosbymichael/orgs","repos_url":"https://api.github.com/users/crosbymichael/repos","events_url":"https://api.github.com/users/crosbymichael/events{/privacy}","received_events_url":"https://api.github.com/users/crosbymichael/received_events","type":"User","site_admin":false},"body":"Add a seccomp build tag and also support in the Makefile to add or\r\nremove build tags.\r\n\r\nSigned-off-by: Michael Crosby <crosbymichael@gmail.com>","created_at":"2015-08-21T22:26:05Z","updated_at":"2015-08-22T05:22:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79ed2441be005bc4c4702010caa04d38f145ce0c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opencontainers/runc/pulls/220/commits","review_comments_url":"https://api.github.com/repos/opencontainers/runc/pulls/220/comments","review_comment_url":"https://api.github.com/repos/opencontainers/runc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencontainers/runc/issues/220/comments","statuses_url":"https://api.github.com/repos/opencontainers/runc/statuses/2f270db8f5bbf432cc262f512fa1807edbb135ca","head":{"label":"crosbymichael:build-tags","ref":"build-tags","sha":"2f270db8f5bbf432cc262f512fa1807edbb135ca","user":{"login":"crosbymichael","id":749551,"avatar_url":"https://avatars.githubusercontent.com/u/749551?v=3","gravatar_id":"","url":"https://api.github.com/users/crosbymichael","html_url":"https://github.com/crosbymichael","followers_url":"https://api.github.com/users/crosbymichael/followers","following_url":"https://api.github.com/users/crosbymichael/following{/other_user}","gists_url":"https://api.github.com/users/crosbymichael/gists{/gist_id}","starred_url":"https://api.github.com/users/crosbymichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosbymichael/subscriptions","organizations_url":"https://api.github.com/users/crosbymichael/orgs","repos_url":"https://api.github.com/users/crosbymichael/repos","events_url":"https://api.github.com/users/crosbymichael/events{/privacy}","received_events_url":"https://api.github.com/users/crosbymichael/received_events","type":"User","site_admin":false},"repo":{"id":38062262,"name":"runc","full_name":"crosbymichael/runc","owner":{"login":"crosbymichael","id":749551,"avatar_url":"https://avatars.githubusercontent.com/u/749551?v=3","gravatar_id":"","url":"https://api.github.com/users/crosbymichael","html_url":"https://github.com/crosbymichael","followers_url":"https://api.github.com/users/crosbymichael/followers","following_url":"https://api.github.com/users/crosbymichael/following{/other_user}","gists_url":"https://api.github.com/users/crosbymichael/gists{/gist_id}","starred_url":"https://api.github.com/users/crosbymichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosbymichael/subscriptions","organizations_url":"https://api.github.com/users/crosbymichael/orgs","repos_url":"https://api.github.com/users/crosbymichael/repos","events_url":"https://api.github.com/users/crosbymichael/events{/privacy}","received_events_url":"https://api.github.com/users/crosbymichael/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/crosbymichael/runc","description":"runc container cli tools","fork":true,"url":"https://api.github.com/repos/crosbymichael/runc","forks_url":"https://api.github.com/repos/crosbymichael/runc/forks","keys_url":"https://api.github.com/repos/crosbymichael/runc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crosbymichael/runc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crosbymichael/runc/teams","hooks_url":"https://api.github.com/repos/crosbymichael/runc/hooks","issue_events_url":"https://api.github.com/repos/crosbymichael/runc/issues/events{/number}","events_url":"https://api.github.com/repos/crosbymichael/runc/events","assignees_url":"https://api.github.com/repos/crosbymichael/runc/assignees{/user}","branches_url":"https://api.github.com/repos/crosbymichael/runc/branches{/branch}","tags_url":"https://api.github.com/repos/crosbymichael/runc/tags","blobs_url":"https://api.github.com/repos/crosbymichael/runc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crosbymichael/runc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crosbymichael/runc/git/refs{/sha}","trees_url":"https://api.github.com/repos/crosbymichael/runc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crosbymichael/runc/statuses/{sha}","languages_url":"https://api.github.com/repos/crosbymichael/runc/languages","stargazers_url":"https://api.github.com/repos/crosbymichael/runc/stargazers","contributors_url":"https://api.github.com/repos/crosbymichael/runc/contributors","subscribers_url":"https://api.github.com/repos/crosbymichael/runc/subscribers","subscription_url":"https://api.github.com/repos/crosbymichael/runc/subscription","commits_url":"https://api.github.com/repos/crosbymichael/runc/commits{/sha}","git_commits_url":"https://api.github.com/repos/crosbymichael/runc/git/commits{/sha}","comments_url":"https://api.github.com/repos/crosbymichael/runc/comments{/number}","issue_comment_url":"https://api.github.com/repos/crosbymichael/runc/issues/comments{/number}","contents_url":"https://api.github.com/repos/crosbymichael/runc/contents/{+path}","compare_url":"https://api.github.com/repos/crosbymichael/runc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crosbymichael/runc/merges","archive_url":"https://api.github.com/repos/crosbymichael/runc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crosbymichael/runc/downloads","issues_url":"https://api.github.com/repos/crosbymichael/runc/issues{/number}","pulls_url":"https://api.github.com/repos/crosbymichael/runc/pulls{/number}","milestones_url":"https://api.github.com/repos/crosbymichael/runc/milestones{/number}","notifications_url":"https://api.github.com/repos/crosbymichael/runc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crosbymichael/runc/labels{/name}","releases_url":"https://api.github.com/repos/crosbymichael/runc/releases{/id}","created_at":"2015-06-25T16:59:57Z","updated_at":"2015-06-25T16:59:58Z","pushed_at":"2015-08-21T23:00:04Z","git_url":"git://github.com/crosbymichael/runc.git","ssh_url":"git@github.com:crosbymichael/runc.git","clone_url":"https://github.com/crosbymichael/runc.git","svn_url":"https://github.com/crosbymichael/runc","homepage":"","size":1891,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opencontainers:master","ref":"master","sha":"e7663a673efe0da696ea87eaa7695ec2e604dd76","user":{"login":"opencontainers","id":12563465,"avatar_url":"https://avatars.githubusercontent.com/u/12563465?v=3","gravatar_id":"","url":"https://api.github.com/users/opencontainers","html_url":"https://github.com/opencontainers","followers_url":"https://api.github.com/users/opencontainers/followers","following_url":"https://api.github.com/users/opencontainers/following{/other_user}","gists_url":"https://api.github.com/users/opencontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/opencontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencontainers/subscriptions","organizations_url":"https://api.github.com/users/opencontainers/orgs","repos_url":"https://api.github.com/users/opencontainers/repos","events_url":"https://api.github.com/users/opencontainers/events{/privacy}","received_events_url":"https://api.github.com/users/opencontainers/received_events","type":"Organization","site_admin":false},"repo":{"id":36960321,"name":"runc","full_name":"opencontainers/runc","owner":{"login":"opencontainers","id":12563465,"avatar_url":"https://avatars.githubusercontent.com/u/12563465?v=3","gravatar_id":"","url":"https://api.github.com/users/opencontainers","html_url":"https://github.com/opencontainers","followers_url":"https://api.github.com/users/opencontainers/followers","following_url":"https://api.github.com/users/opencontainers/following{/other_user}","gists_url":"https://api.github.com/users/opencontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/opencontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencontainers/subscriptions","organizations_url":"https://api.github.com/users/opencontainers/orgs","repos_url":"https://api.github.com/users/opencontainers/repos","events_url":"https://api.github.com/users/opencontainers/events{/privacy}","received_events_url":"https://api.github.com/users/opencontainers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opencontainers/runc","description":"runc container cli tools","fork":false,"url":"https://api.github.com/repos/opencontainers/runc","forks_url":"https://api.github.com/repos/opencontainers/runc/forks","keys_url":"https://api.github.com/repos/opencontainers/runc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencontainers/runc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencontainers/runc/teams","hooks_url":"https://api.github.com/repos/opencontainers/runc/hooks","issue_events_url":"https://api.github.com/repos/opencontainers/runc/issues/events{/number}","events_url":"https://api.github.com/repos/opencontainers/runc/events","assignees_url":"https://api.github.com/repos/opencontainers/runc/assignees{/user}","branches_url":"https://api.github.com/repos/opencontainers/runc/branches{/branch}","tags_url":"https://api.github.com/repos/opencontainers/runc/tags","blobs_url":"https://api.github.com/repos/opencontainers/runc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencontainers/runc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencontainers/runc/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencontainers/runc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencontainers/runc/statuses/{sha}","languages_url":"https://api.github.com/repos/opencontainers/runc/languages","stargazers_url":"https://api.github.com/repos/opencontainers/runc/stargazers","contributors_url":"https://api.github.com/repos/opencontainers/runc/contributors","subscribers_url":"https://api.github.com/repos/opencontainers/runc/subscribers","subscription_url":"https://api.github.com/repos/opencontainers/runc/subscription","commits_url":"https://api.github.com/repos/opencontainers/runc/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencontainers/runc/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencontainers/runc/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencontainers/runc/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencontainers/runc/contents/{+path}","compare_url":"https://api.github.com/repos/opencontainers/runc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencontainers/runc/merges","archive_url":"https://api.github.com/repos/opencontainers/runc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencontainers/runc/downloads","issues_url":"https://api.github.com/repos/opencontainers/runc/issues{/number}","pulls_url":"https://api.github.com/repos/opencontainers/runc/pulls{/number}","milestones_url":"https://api.github.com/repos/opencontainers/runc/milestones{/number}","notifications_url":"https://api.github.com/repos/opencontainers/runc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencontainers/runc/labels{/name}","releases_url":"https://api.github.com/repos/opencontainers/runc/releases{/id}","created_at":"2015-06-05T23:30:45Z","updated_at":"2015-08-21T21:15:09Z","pushed_at":"2015-08-22T01:41:41Z","git_url":"git://github.com/opencontainers/runc.git","ssh_url":"git@github.com:opencontainers/runc.git","clone_url":"https://github.com/opencontainers/runc.git","svn_url":"https://github.com/opencontainers/runc","homepage":"","size":5404,"stargazers_count":1926,"watchers_count":1926,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":178,"mirror_url":null,"open_issues_count":44,"forks":178,"open_issues":44,"watchers":1926,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/220"},"html":{"href":"https://github.com/opencontainers/runc/pull/220"},"issue":{"href":"https://api.github.com/repos/opencontainers/runc/issues/220"},"comments":{"href":"https://api.github.com/repos/opencontainers/runc/issues/220/comments"},"review_comments":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/220/comments"},"review_comment":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/220/commits"},"statuses":{"href":"https://api.github.com/repos/opencontainers/runc/statuses/2f270db8f5bbf432cc262f512fa1807edbb135ca"}}}}