{"action":"reopened","number":180,"pull_request":{"url":"https://api.github.com/repos/RWOverdijk/AssetManager/pulls/180","id":42524003,"html_url":"https://github.com/RWOverdijk/AssetManager/pull/180","diff_url":"https://github.com/RWOverdijk/AssetManager/pull/180.diff","patch_url":"https://github.com/RWOverdijk/AssetManager/pull/180.patch","issue_url":"https://api.github.com/repos/RWOverdijk/AssetManager/issues/180","number":180,"state":"open","locked":false,"title":"Asset ViewHelper","user":{"login":"pensiero","id":2010696,"avatar_url":"https://avatars.githubusercontent.com/u/2010696?v=3","gravatar_id":"","url":"https://api.github.com/users/pensiero","html_url":"https://github.com/pensiero","followers_url":"https://api.github.com/users/pensiero/followers","following_url":"https://api.github.com/users/pensiero/following{/other_user}","gists_url":"https://api.github.com/users/pensiero/gists{/gist_id}","starred_url":"https://api.github.com/users/pensiero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pensiero/subscriptions","organizations_url":"https://api.github.com/users/pensiero/orgs","repos_url":"https://api.github.com/users/pensiero/repos","events_url":"https://api.github.com/users/pensiero/events{/privacy}","received_events_url":"https://api.github.com/users/pensiero/received_events","type":"User","site_admin":false},"body":"The `Asset` view helper give the possibility refresh browser cache when assets files change.\r\n`Asset` append a query param to the filename passed during the invocation of the view helper.\r\n\r\nThe query param appended is `u=[UNIX_TIMESTAMP]` where `[UNIX_TIMESTAMP]` is the last modification date of the file passed.\r\n\r\nThis PR is not completed and I need help:\r\n\r\n1. Is it ok to use a [factory](https://github.com/pensiero/AssetManager/blob/feature/asset-view-helper/src/AssetManager/Module.php#L91-L95) in the `Module`?\r\n2. This helper works only if the file is written in the fs, so I need the `dir` option specified in the `asset_manager/caching` config array... now it's [hardcoded](https://github.com/pensiero/AssetManager/blob/feature/asset-view-helper/src/AssetManager/View/Helper/Asset.php#L18-L20), but I think that there is a better way.. or it's ok this way?\r\n3. I wrote a [test](https://github.com/pensiero/AssetManager/blob/feature/asset-view-helper/tests/AssetManagerTest/View/Helper/AssetTest.php), obviously it fails.. any suggest is really well accepted to know how to procede.\r\n\r\nThanks everybody!\r\n\r\nFixes #177 ","created_at":"2015-08-15T18:57:20Z","updated_at":"2015-08-23T11:18:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"010542dcaeae82d1ac0acc81d4c0c4247a08f031","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/RWOverdijk/AssetManager/pulls/180/commits","review_comments_url":"https://api.github.com/repos/RWOverdijk/AssetManager/pulls/180/comments","review_comment_url":"https://api.github.com/repos/RWOverdijk/AssetManager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RWOverdijk/AssetManager/issues/180/comments","statuses_url":"https://api.github.com/repos/RWOverdijk/AssetManager/statuses/260fe704719c4968e8de9fb42d3b1a5581e0390e","head":{"label":"pensiero:feature/asset-view-helper","ref":"feature/asset-view-helper","sha":"260fe704719c4968e8de9fb42d3b1a5581e0390e","user":{"login":"pensiero","id":2010696,"avatar_url":"https://avatars.githubusercontent.com/u/2010696?v=3","gravatar_id":"","url":"https://api.github.com/users/pensiero","html_url":"https://github.com/pensiero","followers_url":"https://api.github.com/users/pensiero/followers","following_url":"https://api.github.com/users/pensiero/following{/other_user}","gists_url":"https://api.github.com/users/pensiero/gists{/gist_id}","starred_url":"https://api.github.com/users/pensiero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pensiero/subscriptions","organizations_url":"https://api.github.com/users/pensiero/orgs","repos_url":"https://api.github.com/users/pensiero/repos","events_url":"https://api.github.com/users/pensiero/events{/privacy}","received_events_url":"https://api.github.com/users/pensiero/received_events","type":"User","site_admin":false},"repo":{"id":40777424,"name":"AssetManager","full_name":"pensiero/AssetManager","owner":{"login":"pensiero","id":2010696,"avatar_url":"https://avatars.githubusercontent.com/u/2010696?v=3","gravatar_id":"","url":"https://api.github.com/users/pensiero","html_url":"https://github.com/pensiero","followers_url":"https://api.github.com/users/pensiero/followers","following_url":"https://api.github.com/users/pensiero/following{/other_user}","gists_url":"https://api.github.com/users/pensiero/gists{/gist_id}","starred_url":"https://api.github.com/users/pensiero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pensiero/subscriptions","organizations_url":"https://api.github.com/users/pensiero/orgs","repos_url":"https://api.github.com/users/pensiero/repos","events_url":"https://api.github.com/users/pensiero/events{/privacy}","received_events_url":"https://api.github.com/users/pensiero/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pensiero/AssetManager","description":"AssetManager written for zf2. Managing assets for zend framework 2","fork":true,"url":"https://api.github.com/repos/pensiero/AssetManager","forks_url":"https://api.github.com/repos/pensiero/AssetManager/forks","keys_url":"https://api.github.com/repos/pensiero/AssetManager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pensiero/AssetManager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pensiero/AssetManager/teams","hooks_url":"https://api.github.com/repos/pensiero/AssetManager/hooks","issue_events_url":"https://api.github.com/repos/pensiero/AssetManager/issues/events{/number}","events_url":"https://api.github.com/repos/pensiero/AssetManager/events","assignees_url":"https://api.github.com/repos/pensiero/AssetManager/assignees{/user}","branches_url":"https://api.github.com/repos/pensiero/AssetManager/branches{/branch}","tags_url":"https://api.github.com/repos/pensiero/AssetManager/tags","blobs_url":"https://api.github.com/repos/pensiero/AssetManager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pensiero/AssetManager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pensiero/AssetManager/git/refs{/sha}","trees_url":"https://api.github.com/repos/pensiero/AssetManager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pensiero/AssetManager/statuses/{sha}","languages_url":"https://api.github.com/repos/pensiero/AssetManager/languages","stargazers_url":"https://api.github.com/repos/pensiero/AssetManager/stargazers","contributors_url":"https://api.github.com/repos/pensiero/AssetManager/contributors","subscribers_url":"https://api.github.com/repos/pensiero/AssetManager/subscribers","subscription_url":"https://api.github.com/repos/pensiero/AssetManager/subscription","commits_url":"https://api.github.com/repos/pensiero/AssetManager/commits{/sha}","git_commits_url":"https://api.github.com/repos/pensiero/AssetManager/git/commits{/sha}","comments_url":"https://api.github.com/repos/pensiero/AssetManager/comments{/number}","issue_comment_url":"https://api.github.com/repos/pensiero/AssetManager/issues/comments{/number}","contents_url":"https://api.github.com/repos/pensiero/AssetManager/contents/{+path}","compare_url":"https://api.github.com/repos/pensiero/AssetManager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pensiero/AssetManager/merges","archive_url":"https://api.github.com/repos/pensiero/AssetManager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pensiero/AssetManager/downloads","issues_url":"https://api.github.com/repos/pensiero/AssetManager/issues{/number}","pulls_url":"https://api.github.com/repos/pensiero/AssetManager/pulls{/number}","milestones_url":"https://api.github.com/repos/pensiero/AssetManager/milestones{/number}","notifications_url":"https://api.github.com/repos/pensiero/AssetManager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pensiero/AssetManager/labels{/name}","releases_url":"https://api.github.com/repos/pensiero/AssetManager/releases{/id}","created_at":"2015-08-15T18:29:59Z","updated_at":"2015-08-15T18:30:00Z","pushed_at":"2015-08-17T08:41:09Z","git_url":"git://github.com/pensiero/AssetManager.git","ssh_url":"git@github.com:pensiero/AssetManager.git","clone_url":"https://github.com/pensiero/AssetManager.git","svn_url":"https://github.com/pensiero/AssetManager","homepage":"","size":459,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RWOverdijk:master","ref":"master","sha":"fed0e5cc6799a595627c79c41da4492f6e857cc0","user":{"login":"RWOverdijk","id":781745,"avatar_url":"https://avatars.githubusercontent.com/u/781745?v=3","gravatar_id":"","url":"https://api.github.com/users/RWOverdijk","html_url":"https://github.com/RWOverdijk","followers_url":"https://api.github.com/users/RWOverdijk/followers","following_url":"https://api.github.com/users/RWOverdijk/following{/other_user}","gists_url":"https://api.github.com/users/RWOverdijk/gists{/gist_id}","starred_url":"https://api.github.com/users/RWOverdijk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RWOverdijk/subscriptions","organizations_url":"https://api.github.com/users/RWOverdijk/orgs","repos_url":"https://api.github.com/users/RWOverdijk/repos","events_url":"https://api.github.com/users/RWOverdijk/events{/privacy}","received_events_url":"https://api.github.com/users/RWOverdijk/received_events","type":"User","site_admin":false},"repo":{"id":5399788,"name":"AssetManager","full_name":"RWOverdijk/AssetManager","owner":{"login":"RWOverdijk","id":781745,"avatar_url":"https://avatars.githubusercontent.com/u/781745?v=3","gravatar_id":"","url":"https://api.github.com/users/RWOverdijk","html_url":"https://github.com/RWOverdijk","followers_url":"https://api.github.com/users/RWOverdijk/followers","following_url":"https://api.github.com/users/RWOverdijk/following{/other_user}","gists_url":"https://api.github.com/users/RWOverdijk/gists{/gist_id}","starred_url":"https://api.github.com/users/RWOverdijk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RWOverdijk/subscriptions","organizations_url":"https://api.github.com/users/RWOverdijk/orgs","repos_url":"https://api.github.com/users/RWOverdijk/repos","events_url":"https://api.github.com/users/RWOverdijk/events{/privacy}","received_events_url":"https://api.github.com/users/RWOverdijk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RWOverdijk/AssetManager","description":"AssetManager written for zf2. Managing assets for zend framework 2","fork":false,"url":"https://api.github.com/repos/RWOverdijk/AssetManager","forks_url":"https://api.github.com/repos/RWOverdijk/AssetManager/forks","keys_url":"https://api.github.com/repos/RWOverdijk/AssetManager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RWOverdijk/AssetManager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RWOverdijk/AssetManager/teams","hooks_url":"https://api.github.com/repos/RWOverdijk/AssetManager/hooks","issue_events_url":"https://api.github.com/repos/RWOverdijk/AssetManager/issues/events{/number}","events_url":"https://api.github.com/repos/RWOverdijk/AssetManager/events","assignees_url":"https://api.github.com/repos/RWOverdijk/AssetManager/assignees{/user}","branches_url":"https://api.github.com/repos/RWOverdijk/AssetManager/branches{/branch}","tags_url":"https://api.github.com/repos/RWOverdijk/AssetManager/tags","blobs_url":"https://api.github.com/repos/RWOverdijk/AssetManager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RWOverdijk/AssetManager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RWOverdijk/AssetManager/git/refs{/sha}","trees_url":"https://api.github.com/repos/RWOverdijk/AssetManager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RWOverdijk/AssetManager/statuses/{sha}","languages_url":"https://api.github.com/repos/RWOverdijk/AssetManager/languages","stargazers_url":"https://api.github.com/repos/RWOverdijk/AssetManager/stargazers","contributors_url":"https://api.github.com/repos/RWOverdijk/AssetManager/contributors","subscribers_url":"https://api.github.com/repos/RWOverdijk/AssetManager/subscribers","subscription_url":"https://api.github.com/repos/RWOverdijk/AssetManager/subscription","commits_url":"https://api.github.com/repos/RWOverdijk/AssetManager/commits{/sha}","git_commits_url":"https://api.github.com/repos/RWOverdijk/AssetManager/git/commits{/sha}","comments_url":"https://api.github.com/repos/RWOverdijk/AssetManager/comments{/number}","issue_comment_url":"https://api.github.com/repos/RWOverdijk/AssetManager/issues/comments{/number}","contents_url":"https://api.github.com/repos/RWOverdijk/AssetManager/contents/{+path}","compare_url":"https://api.github.com/repos/RWOverdijk/AssetManager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RWOverdijk/AssetManager/merges","archive_url":"https://api.github.com/repos/RWOverdijk/AssetManager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RWOverdijk/AssetManager/downloads","issues_url":"https://api.github.com/repos/RWOverdijk/AssetManager/issues{/number}","pulls_url":"https://api.github.com/repos/RWOverdijk/AssetManager/pulls{/number}","milestones_url":"https://api.github.com/repos/RWOverdijk/AssetManager/milestones{/number}","notifications_url":"https://api.github.com/repos/RWOverdijk/AssetManager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RWOverdijk/AssetManager/labels{/name}","releases_url":"https://api.github.com/repos/RWOverdijk/AssetManager/releases{/id}","created_at":"2012-08-13T14:12:13Z","updated_at":"2015-08-02T16:37:45Z","pushed_at":"2015-08-17T08:41:10Z","git_url":"git://github.com/RWOverdijk/AssetManager.git","ssh_url":"git@github.com:RWOverdijk/AssetManager.git","clone_url":"https://github.com/RWOverdijk/AssetManager.git","svn_url":"https://github.com/RWOverdijk/AssetManager","homepage":"","size":1305,"stargazers_count":179,"watchers_count":179,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"open_issues_count":18,"forks":60,"open_issues":18,"watchers":179,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RWOverdijk/AssetManager/pulls/180"},"html":{"href":"https://github.com/RWOverdijk/AssetManager/pull/180"},"issue":{"href":"https://api.github.com/repos/RWOverdijk/AssetManager/issues/180"},"comments":{"href":"https://api.github.com/repos/RWOverdijk/AssetManager/issues/180/comments"},"review_comments":{"href":"https://api.github.com/repos/RWOverdijk/AssetManager/pulls/180/comments"},"review_comment":{"href":"https://api.github.com/repos/RWOverdijk/AssetManager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RWOverdijk/AssetManager/pulls/180/commits"},"statuses":{"href":"https://api.github.com/repos/RWOverdijk/AssetManager/statuses/260fe704719c4968e8de9fb42d3b1a5581e0390e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":3,"review_comments":6,"commits":3,"additions":68,"deletions":1,"changed_files":3}}