{"action":"created","issue":{"url":"https://api.github.com/repos/philc/vimium/issues/1734","labels_url":"https://api.github.com/repos/philc/vimium/issues/1734/labels{/name}","comments_url":"https://api.github.com/repos/philc/vimium/issues/1734/comments","events_url":"https://api.github.com/repos/philc/vimium/issues/1734/events","html_url":"https://github.com/philc/vimium/pull/1734","id":88245098,"number":1734,"title":"Sync localStorage to chrome.storage.local and bump version to 1.52","user":{"login":"mrmr1993","id":1847343,"avatar_url":"https://avatars.githubusercontent.com/u/1847343?v=3","gravatar_id":"","url":"https://api.github.com/users/mrmr1993","html_url":"https://github.com/mrmr1993","followers_url":"https://api.github.com/users/mrmr1993/followers","following_url":"https://api.github.com/users/mrmr1993/following{/other_user}","gists_url":"https://api.github.com/users/mrmr1993/gists{/gist_id}","starred_url":"https://api.github.com/users/mrmr1993/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrmr1993/subscriptions","organizations_url":"https://api.github.com/users/mrmr1993/orgs","repos_url":"https://api.github.com/users/mrmr1993/repos","events_url":"https://api.github.com/users/mrmr1993/events{/privacy}","received_events_url":"https://api.github.com/users/mrmr1993/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-06-14T20:37:58Z","updated_at":"2015-06-16T22:58:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/philc/vimium/pulls/1734","html_url":"https://github.com/philc/vimium/pull/1734","diff_url":"https://github.com/philc/vimium/pull/1734.diff","patch_url":"https://github.com/philc/vimium/pull/1734.patch"},"body":"This PR ensures that any setting available from `localStorage` in the background page is also available to content scripts, via `chrome.storage.local`. This fixes the issue:\r\n* any setting set before Vimium 1.45 (and unchanged since) hadn't been propagated to `chrome.storage`, and so is unavailable to content scripts.\r\n\r\n@smblott-github this also makes your statement from PR #1733 true, namely:\r\n\r\n> the behaviour in a particular chrome instance doesn't change unless the user actively does something."},"comment":{"url":"https://api.github.com/repos/philc/vimium/issues/comments/112596999","html_url":"https://github.com/philc/vimium/pull/1734#issuecomment-112596999","issue_url":"https://api.github.com/repos/philc/vimium/issues/1734","id":112596999,"user":{"login":"ron813c","id":3113433,"avatar_url":"https://avatars.githubusercontent.com/u/3113433?v=3","gravatar_id":"","url":"https://api.github.com/users/ron813c","html_url":"https://github.com/ron813c","followers_url":"https://api.github.com/users/ron813c/followers","following_url":"https://api.github.com/users/ron813c/following{/other_user}","gists_url":"https://api.github.com/users/ron813c/gists{/gist_id}","starred_url":"https://api.github.com/users/ron813c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ron813c/subscriptions","organizations_url":"https://api.github.com/users/ron813c/orgs","repos_url":"https://api.github.com/users/ron813c/repos","events_url":"https://api.github.com/users/ron813c/events{/privacy}","received_events_url":"https://api.github.com/users/ron813c/received_events","type":"User","site_admin":false},"created_at":"2015-06-16T22:58:52Z","updated_at":"2015-06-16T22:58:52Z","body":"On Jun 16, 2015 10:06 AM, \"Matthew Ryan\" <notifications@github.com> wrote:\n>\n> @smblott-github I've pushed an update to this that fixes the issues that\nyou pointed out.\n>\n> Having a look at your alternative\n>\n> I like the change to postUpdateHook.\n> it uses chrome.storage.sync.get repeatedly on individual keys when we've\nalready got the full contents.\n> it keeps trying to migrate at every startup, forever.\n> 11 levels of indentation at one point?!?!\n> The ugly hack is ugly.\n>\n> I prefer how this PR does it to your e0b50c6, but I really only made this\nPR to illustrate that this approach will make a mess of the settings code.\n>\n> —\n> Reply to this email directly or view it on GitHub.\n"}}