{"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/data/pulls/comments/22597082","id":22597082,"diff_hunk":"@@ -261,7 +261,7 @@ export default Ember.Object.extend({\n   willDestroy: function(){\n     this._super();\n \n-    forEach(flatten(values(this.filteredRecordArrays.values)), destroy);\n+    forEach(flatten(values(this.filteredRecordArrays._values)), destroy);","path":"packages/ember-data/lib/system/record_array_manager.js","position":5,"original_position":5,"commit_id":"eb7214d7f295ce88a66dc383c3e73a23ed9519d8","original_commit_id":"eb7214d7f295ce88a66dc383c3e73a23ed9519d8","user":{"login":"kimroen","id":520420,"avatar_url":"https://avatars.githubusercontent.com/u/520420?v=3","gravatar_id":"","url":"https://api.github.com/users/kimroen","html_url":"https://github.com/kimroen","followers_url":"https://api.github.com/users/kimroen/followers","following_url":"https://api.github.com/users/kimroen/following{/other_user}","gists_url":"https://api.github.com/users/kimroen/gists{/gist_id}","starred_url":"https://api.github.com/users/kimroen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kimroen/subscriptions","organizations_url":"https://api.github.com/users/kimroen/orgs","repos_url":"https://api.github.com/users/kimroen/repos","events_url":"https://api.github.com/users/kimroen/events{/privacy}","received_events_url":"https://api.github.com/users/kimroen/received_events","type":"User","site_admin":false},"body":"Fair question! That would probably render this polyfill unnecessary, correct?\r\n\r\nI'm sure there's a reason why that's not used here, but maybe it could be rewritten to do so?","created_at":"2015-01-07T16:36:36Z","updated_at":"2015-01-07T16:36:36Z","html_url":"https://github.com/emberjs/data/pull/2672#discussion_r22597082","pull_request_url":"https://api.github.com/repos/emberjs/data/pulls/2672","_links":{"self":{"href":"https://api.github.com/repos/emberjs/data/pulls/comments/22597082"},"html":{"href":"https://github.com/emberjs/data/pull/2672#discussion_r22597082"},"pull_request":{"href":"https://api.github.com/repos/emberjs/data/pulls/2672"}}},"pull_request":{"url":"https://api.github.com/repos/emberjs/data/pulls/2672","id":26927705,"html_url":"https://github.com/emberjs/data/pull/2672","diff_url":"https://github.com/emberjs/data/pull/2672.diff","patch_url":"https://github.com/emberjs/data/pull/2672.patch","issue_url":"https://api.github.com/repos/emberjs/data/issues/2672","number":2672,"state":"open","locked":false,"title":"Polyfill Ember.Map and friends and use _values","user":{"login":"kimroen","id":520420,"avatar_url":"https://avatars.githubusercontent.com/u/520420?v=3","gravatar_id":"","url":"https://api.github.com/users/kimroen","html_url":"https://github.com/kimroen","followers_url":"https://api.github.com/users/kimroen/followers","following_url":"https://api.github.com/users/kimroen/following{/other_user}","gists_url":"https://api.github.com/users/kimroen/gists{/gist_id}","starred_url":"https://api.github.com/users/kimroen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kimroen/subscriptions","organizations_url":"https://api.github.com/users/kimroen/orgs","repos_url":"https://api.github.com/users/kimroen/repos","events_url":"https://api.github.com/users/kimroen/events{/privacy}","received_events_url":"https://api.github.com/users/kimroen/received_events","type":"User","site_admin":false},"body":"Fixes #2661 \r\n\r\nThis works, but we have a failing test that I'm not sure what's all about.","created_at":"2015-01-06T23:48:35Z","updated_at":"2015-01-07T16:36:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15d87296e22303b6fa1488cad32a558ff55b9fe8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/data/pulls/2672/commits","review_comments_url":"https://api.github.com/repos/emberjs/data/pulls/2672/comments","review_comment_url":"https://api.github.com/repos/emberjs/data/pulls/comments/{number}","comments_url":"https://api.github.com/repos/emberjs/data/issues/2672/comments","statuses_url":"https://api.github.com/repos/emberjs/data/statuses/eb7214d7f295ce88a66dc383c3e73a23ed9519d8","head":{"label":"kimroen:polyfill-ember-map","ref":"polyfill-ember-map","sha":"eb7214d7f295ce88a66dc383c3e73a23ed9519d8","user":{"login":"kimroen","id":520420,"avatar_url":"https://avatars.githubusercontent.com/u/520420?v=3","gravatar_id":"","url":"https://api.github.com/users/kimroen","html_url":"https://github.com/kimroen","followers_url":"https://api.github.com/users/kimroen/followers","following_url":"https://api.github.com/users/kimroen/following{/other_user}","gists_url":"https://api.github.com/users/kimroen/gists{/gist_id}","starred_url":"https://api.github.com/users/kimroen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kimroen/subscriptions","organizations_url":"https://api.github.com/users/kimroen/orgs","repos_url":"https://api.github.com/users/kimroen/repos","events_url":"https://api.github.com/users/kimroen/events{/privacy}","received_events_url":"https://api.github.com/users/kimroen/received_events","type":"User","site_admin":false},"repo":{"id":28812516,"name":"data","full_name":"kimroen/data","owner":{"login":"kimroen","id":520420,"avatar_url":"https://avatars.githubusercontent.com/u/520420?v=3","gravatar_id":"","url":"https://api.github.com/users/kimroen","html_url":"https://github.com/kimroen","followers_url":"https://api.github.com/users/kimroen/followers","following_url":"https://api.github.com/users/kimroen/following{/other_user}","gists_url":"https://api.github.com/users/kimroen/gists{/gist_id}","starred_url":"https://api.github.com/users/kimroen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kimroen/subscriptions","organizations_url":"https://api.github.com/users/kimroen/orgs","repos_url":"https://api.github.com/users/kimroen/repos","events_url":"https://api.github.com/users/kimroen/events{/privacy}","received_events_url":"https://api.github.com/users/kimroen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kimroen/data","description":"A data persistence library for Ember.js.","fork":true,"url":"https://api.github.com/repos/kimroen/data","forks_url":"https://api.github.com/repos/kimroen/data/forks","keys_url":"https://api.github.com/repos/kimroen/data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kimroen/data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kimroen/data/teams","hooks_url":"https://api.github.com/repos/kimroen/data/hooks","issue_events_url":"https://api.github.com/repos/kimroen/data/issues/events{/number}","events_url":"https://api.github.com/repos/kimroen/data/events","assignees_url":"https://api.github.com/repos/kimroen/data/assignees{/user}","branches_url":"https://api.github.com/repos/kimroen/data/branches{/branch}","tags_url":"https://api.github.com/repos/kimroen/data/tags","blobs_url":"https://api.github.com/repos/kimroen/data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kimroen/data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kimroen/data/git/refs{/sha}","trees_url":"https://api.github.com/repos/kimroen/data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kimroen/data/statuses/{sha}","languages_url":"https://api.github.com/repos/kimroen/data/languages","stargazers_url":"https://api.github.com/repos/kimroen/data/stargazers","contributors_url":"https://api.github.com/repos/kimroen/data/contributors","subscribers_url":"https://api.github.com/repos/kimroen/data/subscribers","subscription_url":"https://api.github.com/repos/kimroen/data/subscription","commits_url":"https://api.github.com/repos/kimroen/data/commits{/sha}","git_commits_url":"https://api.github.com/repos/kimroen/data/git/commits{/sha}","comments_url":"https://api.github.com/repos/kimroen/data/comments{/number}","issue_comment_url":"https://api.github.com/repos/kimroen/data/issues/comments/{number}","contents_url":"https://api.github.com/repos/kimroen/data/contents/{+path}","compare_url":"https://api.github.com/repos/kimroen/data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kimroen/data/merges","archive_url":"https://api.github.com/repos/kimroen/data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kimroen/data/downloads","issues_url":"https://api.github.com/repos/kimroen/data/issues{/number}","pulls_url":"https://api.github.com/repos/kimroen/data/pulls{/number}","milestones_url":"https://api.github.com/repos/kimroen/data/milestones{/number}","notifications_url":"https://api.github.com/repos/kimroen/data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kimroen/data/labels{/name}","releases_url":"https://api.github.com/repos/kimroen/data/releases{/id}","created_at":"2015-01-05T12:56:54Z","updated_at":"2015-01-05T12:56:55Z","pushed_at":"2015-01-07T11:20:58Z","git_url":"git://github.com/kimroen/data.git","ssh_url":"git@github.com:kimroen/data.git","clone_url":"https://github.com/kimroen/data.git","svn_url":"https://github.com/kimroen/data","homepage":"","size":7255,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"586eea8a76db637423c27c8a6a084c6f9777250c","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":3016562,"name":"data","full_name":"emberjs/data","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/data","description":"A data persistence library for Ember.js.","fork":false,"url":"https://api.github.com/repos/emberjs/data","forks_url":"https://api.github.com/repos/emberjs/data/forks","keys_url":"https://api.github.com/repos/emberjs/data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/data/teams","hooks_url":"https://api.github.com/repos/emberjs/data/hooks","issue_events_url":"https://api.github.com/repos/emberjs/data/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/data/events","assignees_url":"https://api.github.com/repos/emberjs/data/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/data/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/data/tags","blobs_url":"https://api.github.com/repos/emberjs/data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/data/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/data/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/data/languages","stargazers_url":"https://api.github.com/repos/emberjs/data/stargazers","contributors_url":"https://api.github.com/repos/emberjs/data/contributors","subscribers_url":"https://api.github.com/repos/emberjs/data/subscribers","subscription_url":"https://api.github.com/repos/emberjs/data/subscription","commits_url":"https://api.github.com/repos/emberjs/data/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/data/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/data/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/data/issues/comments/{number}","contents_url":"https://api.github.com/repos/emberjs/data/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/data/merges","archive_url":"https://api.github.com/repos/emberjs/data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/data/downloads","issues_url":"https://api.github.com/repos/emberjs/data/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/data/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/data/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/data/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/data/releases{/id}","created_at":"2011-12-20T01:50:40Z","updated_at":"2015-01-07T09:58:28Z","pushed_at":"2015-01-07T09:58:28Z","git_url":"git://github.com/emberjs/data.git","ssh_url":"git@github.com:emberjs/data.git","clone_url":"https://github.com/emberjs/data.git","svn_url":"https://github.com/emberjs/data","homepage":"","size":20766,"stargazers_count":2189,"watchers_count":2189,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":813,"mirror_url":null,"open_issues_count":235,"forks":813,"open_issues":235,"watchers":2189,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/data/pulls/2672"},"html":{"href":"https://github.com/emberjs/data/pull/2672"},"issue":{"href":"https://api.github.com/repos/emberjs/data/issues/2672"},"comments":{"href":"https://api.github.com/repos/emberjs/data/issues/2672/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/data/pulls/2672/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/data/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/emberjs/data/pulls/2672/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/data/statuses/eb7214d7f295ce88a66dc383c3e73a23ed9519d8"}}}}