{"action":"created","comment":{"url":"https://api.github.com/repos/spring-projects/spring-reactive/pulls/comments/45366399","id":45366399,"diff_hunk":"@@ -0,0 +1,48 @@\n+/*\n+ * Copyright 2002-2015 the original author or authors.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *      http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.springframework.reactive.web.client.reactor;\n+\n+import reactor.rx.Stream;\n+\n+import org.springframework.core.convert.support.GenericConversionService;\n+import org.springframework.core.convert.support.ReactiveStreamsToReactorConverter;\n+import org.springframework.reactive.web.client.AbstractRestClient;\n+import org.springframework.reactive.web.client.ReactiveClientHttpRequestFactory;\n+import org.springframework.reactive.web.client.TypedRequestBuilder;\n+\n+/**\n+ * @author Brian Clozel\n+ */\n+public class ReactorRestClient<T> extends AbstractRestClient<T> {","path":"src/main/java/org/springframework/reactive/web/client/reactor/ReactorRestClient.java","position":30,"original_position":30,"commit_id":"0939838c6579f720b1afaf0bae7a8c927b4306a4","original_commit_id":"0939838c6579f720b1afaf0bae7a8c927b4306a4","user":{"login":"sdeleuze","id":141109,"avatar_url":"https://avatars.githubusercontent.com/u/141109?v=3","gravatar_id":"","url":"https://api.github.com/users/sdeleuze","html_url":"https://github.com/sdeleuze","followers_url":"https://api.github.com/users/sdeleuze/followers","following_url":"https://api.github.com/users/sdeleuze/following{/other_user}","gists_url":"https://api.github.com/users/sdeleuze/gists{/gist_id}","starred_url":"https://api.github.com/users/sdeleuze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdeleuze/subscriptions","organizations_url":"https://api.github.com/users/sdeleuze/orgs","repos_url":"https://api.github.com/users/sdeleuze/repos","events_url":"https://api.github.com/users/sdeleuze/events{/privacy}","received_events_url":"https://api.github.com/users/sdeleuze/received_events","type":"User","site_admin":false},"body":"Just an idea, maybe `ReactorRestClient` could use an encapsulated `ReactiveRestClient` field instead of extending `AbstractRestClient` (composition instead of inheritance).","created_at":"2015-11-19T16:47:39Z","updated_at":"2015-11-19T16:47:39Z","html_url":"https://github.com/spring-projects/spring-reactive/pull/40#discussion_r45366399","pull_request_url":"https://api.github.com/repos/spring-projects/spring-reactive/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-reactive/pulls/comments/45366399"},"html":{"href":"https://github.com/spring-projects/spring-reactive/pull/40#discussion_r45366399"},"pull_request":{"href":"https://api.github.com/repos/spring-projects/spring-reactive/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-reactive/pulls/40","id":50004277,"html_url":"https://github.com/spring-projects/spring-reactive/pull/40","diff_url":"https://github.com/spring-projects/spring-reactive/pull/40.diff","patch_url":"https://github.com/spring-projects/spring-reactive/pull/40.patch","issue_url":"https://api.github.com/repos/spring-projects/spring-reactive/issues/40","number":40,"state":"open","locked":false,"title":"Start reactive REST client implementation","user":{"login":"bclozel","id":103264,"avatar_url":"https://avatars.githubusercontent.com/u/103264?v=3","gravatar_id":"","url":"https://api.github.com/users/bclozel","html_url":"https://github.com/bclozel","followers_url":"https://api.github.com/users/bclozel/followers","following_url":"https://api.github.com/users/bclozel/following{/other_user}","gists_url":"https://api.github.com/users/bclozel/gists{/gist_id}","starred_url":"https://api.github.com/users/bclozel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bclozel/subscriptions","organizations_url":"https://api.github.com/users/bclozel/orgs","repos_url":"https://api.github.com/users/bclozel/repos","events_url":"https://api.github.com/users/bclozel/events{/privacy}","received_events_url":"https://api.github.com/users/bclozel/received_events","type":"User","site_admin":false},"body":"This PR is currently work in progress, but the [\"Add reactive REST client base contracts\"](https://github.com/bclozel/spring-reactive/commit/3bb886dd203ad75ca2cc5e4fd9f8f463852387d3) commit  can already be discussed and is illustrated by the [next one](https://github.com/bclozel/spring-reactive/commit/0939838c6579f720b1afaf0bae7a8c927b4306a4) with a reactor client draft implementation.\r\n\r\nMany parts are still missing, but I believe some feedback is required at this point.","created_at":"2015-11-06T21:02:53Z","updated_at":"2015-11-19T16:47:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"33c5c3692a14c39e481bb5b31e0ee63d0f5105c4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spring-projects/spring-reactive/pulls/40/commits","review_comments_url":"https://api.github.com/repos/spring-projects/spring-reactive/pulls/40/comments","review_comment_url":"https://api.github.com/repos/spring-projects/spring-reactive/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-projects/spring-reactive/issues/40/comments","statuses_url":"https://api.github.com/repos/spring-projects/spring-reactive/statuses/0939838c6579f720b1afaf0bae7a8c927b4306a4","head":{"label":"bclozel:client","ref":"client","sha":"0939838c6579f720b1afaf0bae7a8c927b4306a4","user":{"login":"bclozel","id":103264,"avatar_url":"https://avatars.githubusercontent.com/u/103264?v=3","gravatar_id":"","url":"https://api.github.com/users/bclozel","html_url":"https://github.com/bclozel","followers_url":"https://api.github.com/users/bclozel/followers","following_url":"https://api.github.com/users/bclozel/following{/other_user}","gists_url":"https://api.github.com/users/bclozel/gists{/gist_id}","starred_url":"https://api.github.com/users/bclozel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bclozel/subscriptions","organizations_url":"https://api.github.com/users/bclozel/orgs","repos_url":"https://api.github.com/users/bclozel/repos","events_url":"https://api.github.com/users/bclozel/events{/privacy}","received_events_url":"https://api.github.com/users/bclozel/received_events","type":"User","site_admin":false},"repo":{"id":39893871,"name":"spring-reactive","full_name":"bclozel/spring-reactive","owner":{"login":"bclozel","id":103264,"avatar_url":"https://avatars.githubusercontent.com/u/103264?v=3","gravatar_id":"","url":"https://api.github.com/users/bclozel","html_url":"https://github.com/bclozel","followers_url":"https://api.github.com/users/bclozel/followers","following_url":"https://api.github.com/users/bclozel/following{/other_user}","gists_url":"https://api.github.com/users/bclozel/gists{/gist_id}","starred_url":"https://api.github.com/users/bclozel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bclozel/subscriptions","organizations_url":"https://api.github.com/users/bclozel/orgs","repos_url":"https://api.github.com/users/bclozel/repos","events_url":"https://api.github.com/users/bclozel/events{/privacy}","received_events_url":"https://api.github.com/users/bclozel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bclozel/spring-reactive","description":"","fork":true,"url":"https://api.github.com/repos/bclozel/spring-reactive","forks_url":"https://api.github.com/repos/bclozel/spring-reactive/forks","keys_url":"https://api.github.com/repos/bclozel/spring-reactive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bclozel/spring-reactive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bclozel/spring-reactive/teams","hooks_url":"https://api.github.com/repos/bclozel/spring-reactive/hooks","issue_events_url":"https://api.github.com/repos/bclozel/spring-reactive/issues/events{/number}","events_url":"https://api.github.com/repos/bclozel/spring-reactive/events","assignees_url":"https://api.github.com/repos/bclozel/spring-reactive/assignees{/user}","branches_url":"https://api.github.com/repos/bclozel/spring-reactive/branches{/branch}","tags_url":"https://api.github.com/repos/bclozel/spring-reactive/tags","blobs_url":"https://api.github.com/repos/bclozel/spring-reactive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bclozel/spring-reactive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bclozel/spring-reactive/git/refs{/sha}","trees_url":"https://api.github.com/repos/bclozel/spring-reactive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bclozel/spring-reactive/statuses/{sha}","languages_url":"https://api.github.com/repos/bclozel/spring-reactive/languages","stargazers_url":"https://api.github.com/repos/bclozel/spring-reactive/stargazers","contributors_url":"https://api.github.com/repos/bclozel/spring-reactive/contributors","subscribers_url":"https://api.github.com/repos/bclozel/spring-reactive/subscribers","subscription_url":"https://api.github.com/repos/bclozel/spring-reactive/subscription","commits_url":"https://api.github.com/repos/bclozel/spring-reactive/commits{/sha}","git_commits_url":"https://api.github.com/repos/bclozel/spring-reactive/git/commits{/sha}","comments_url":"https://api.github.com/repos/bclozel/spring-reactive/comments{/number}","issue_comment_url":"https://api.github.com/repos/bclozel/spring-reactive/issues/comments{/number}","contents_url":"https://api.github.com/repos/bclozel/spring-reactive/contents/{+path}","compare_url":"https://api.github.com/repos/bclozel/spring-reactive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bclozel/spring-reactive/merges","archive_url":"https://api.github.com/repos/bclozel/spring-reactive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bclozel/spring-reactive/downloads","issues_url":"https://api.github.com/repos/bclozel/spring-reactive/issues{/number}","pulls_url":"https://api.github.com/repos/bclozel/spring-reactive/pulls{/number}","milestones_url":"https://api.github.com/repos/bclozel/spring-reactive/milestones{/number}","notifications_url":"https://api.github.com/repos/bclozel/spring-reactive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bclozel/spring-reactive/labels{/name}","releases_url":"https://api.github.com/repos/bclozel/spring-reactive/releases{/id}","created_at":"2015-07-29T13:08:19Z","updated_at":"2015-08-25T13:44:02Z","pushed_at":"2015-11-06T20:56:58Z","git_url":"git://github.com/bclozel/spring-reactive.git","ssh_url":"git@github.com:bclozel/spring-reactive.git","clone_url":"https://github.com/bclozel/spring-reactive.git","svn_url":"https://github.com/bclozel/spring-reactive","homepage":null,"size":445,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"spring-projects:master","ref":"master","sha":"8267ac38bec04882a4b1db54ceaa747b492c423a","user":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":38815999,"name":"spring-reactive","full_name":"spring-projects/spring-reactive","owner":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-projects/spring-reactive","description":"Sandbox for experimenting on Spring 5 reactive programming support","fork":false,"url":"https://api.github.com/repos/spring-projects/spring-reactive","forks_url":"https://api.github.com/repos/spring-projects/spring-reactive/forks","keys_url":"https://api.github.com/repos/spring-projects/spring-reactive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-projects/spring-reactive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-projects/spring-reactive/teams","hooks_url":"https://api.github.com/repos/spring-projects/spring-reactive/hooks","issue_events_url":"https://api.github.com/repos/spring-projects/spring-reactive/issues/events{/number}","events_url":"https://api.github.com/repos/spring-projects/spring-reactive/events","assignees_url":"https://api.github.com/repos/spring-projects/spring-reactive/assignees{/user}","branches_url":"https://api.github.com/repos/spring-projects/spring-reactive/branches{/branch}","tags_url":"https://api.github.com/repos/spring-projects/spring-reactive/tags","blobs_url":"https://api.github.com/repos/spring-projects/spring-reactive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-projects/spring-reactive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-projects/spring-reactive/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-projects/spring-reactive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-projects/spring-reactive/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-projects/spring-reactive/languages","stargazers_url":"https://api.github.com/repos/spring-projects/spring-reactive/stargazers","contributors_url":"https://api.github.com/repos/spring-projects/spring-reactive/contributors","subscribers_url":"https://api.github.com/repos/spring-projects/spring-reactive/subscribers","subscription_url":"https://api.github.com/repos/spring-projects/spring-reactive/subscription","commits_url":"https://api.github.com/repos/spring-projects/spring-reactive/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-projects/spring-reactive/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-projects/spring-reactive/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-projects/spring-reactive/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-projects/spring-reactive/contents/{+path}","compare_url":"https://api.github.com/repos/spring-projects/spring-reactive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-projects/spring-reactive/merges","archive_url":"https://api.github.com/repos/spring-projects/spring-reactive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-projects/spring-reactive/downloads","issues_url":"https://api.github.com/repos/spring-projects/spring-reactive/issues{/number}","pulls_url":"https://api.github.com/repos/spring-projects/spring-reactive/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-projects/spring-reactive/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-projects/spring-reactive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-projects/spring-reactive/labels{/name}","releases_url":"https://api.github.com/repos/spring-projects/spring-reactive/releases{/id}","created_at":"2015-07-09T11:18:53Z","updated_at":"2015-11-11T18:12:14Z","pushed_at":"2015-11-17T16:41:50Z","git_url":"git://github.com/spring-projects/spring-reactive.git","ssh_url":"git@github.com:spring-projects/spring-reactive.git","clone_url":"https://github.com/spring-projects/spring-reactive.git","svn_url":"https://github.com/spring-projects/spring-reactive","homepage":"","size":886,"stargazers_count":62,"watchers_count":62,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":19,"forks":19,"open_issues":19,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-reactive/pulls/40"},"html":{"href":"https://github.com/spring-projects/spring-reactive/pull/40"},"issue":{"href":"https://api.github.com/repos/spring-projects/spring-reactive/issues/40"},"comments":{"href":"https://api.github.com/repos/spring-projects/spring-reactive/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-projects/spring-reactive/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-projects/spring-reactive/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-projects/spring-reactive/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/spring-projects/spring-reactive/statuses/0939838c6579f720b1afaf0bae7a8c927b4306a4"}}}}