{"action":"created","issue":{"url":"https://api.github.com/repos/mitsuhiko/flask/issues/1643","labels_url":"https://api.github.com/repos/mitsuhiko/flask/issues/1643/labels{/name}","comments_url":"https://api.github.com/repos/mitsuhiko/flask/issues/1643/comments","events_url":"https://api.github.com/repos/mitsuhiko/flask/issues/1643/events","html_url":"https://github.com/mitsuhiko/flask/pull/1643","id":120739756,"number":1643,"title":"Issue Regarding to instance path in testsuite directory","user":{"login":"yashlodha","id":12555379,"avatar_url":"https://avatars.githubusercontent.com/u/12555379?v=3","gravatar_id":"","url":"https://api.github.com/users/yashlodha","html_url":"https://github.com/yashlodha","followers_url":"https://api.github.com/users/yashlodha/followers","following_url":"https://api.github.com/users/yashlodha/following{/other_user}","gists_url":"https://api.github.com/users/yashlodha/gists{/gist_id}","starred_url":"https://api.github.com/users/yashlodha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yashlodha/subscriptions","organizations_url":"https://api.github.com/users/yashlodha/orgs","repos_url":"https://api.github.com/users/yashlodha/repos","events_url":"https://api.github.com/users/yashlodha/events{/privacy}","received_events_url":"https://api.github.com/users/yashlodha/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-12-07T10:13:31Z","updated_at":"2015-12-07T14:01:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mitsuhiko/flask/pulls/1643","html_url":"https://github.com/mitsuhiko/flask/pull/1643","diff_url":"https://github.com/mitsuhiko/flask/pull/1643.diff","patch_url":"https://github.com/mitsuhiko/flask/pull/1643.patch"},"body":"Made changes regarding to instance path of files in flask/testsuite/test_apps\r\n-------------------------------------------------------------------------------------------------------\r\n\r\nWhile running test case by run-test.py module it causes Error for instance path.\r\n```sh\r\nFAIL: test_main_module_paths (flask.testsuite.config.InstanceTestCase)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"../flaskenv/flask/flask/testsuite/config.py\", line 157, in test_main_module_paths\r\n    self.assert_equal(app.instance_path, os.path.join(here, 'instance'))\r\n\r\n  File \"../flaskenv/flask/flask/testsuite/__init__.py\", line 141, in assert_equal\r\n    return self.assertEqual(x, y)\r\n\r\nAssertionError: '../flaskenv/var/run-tests-instance' != '../flaskenv/flask/instance'\r\n- ../flaskenv/var/run-tests-instance\r\n?             ^ ^ ----------\r\n+ ../flaskenv/flask/instance\r\n?             ^^ ^^\r\n```\r\n\r\n```sh\r\nFAIL: test_uninstalled_module_paths (flask.testsuite.config.InstanceTestCase)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"../flaskenv/flask/flask/testsuite/config.py\", line 164, in test_uninstalled_module_paths\r\n    self.assert_equal(app.instance_path, os.path.join(here, 'test_apps', 'instance'))\r\n\r\n  File \"../flaskenv/flask/flask/testsuite/__init__.py\", line 141, in assert_equal\r\n    return self.assertEqual(x, y)\r\n\r\nAssertionError: '/hom[23 chars]ang-py3-test/flaskenv/var/config_module_app-instance' != '/hom[23 chars]ang-py3-test/flaskenv/flask/flask/testsuite/test_apps/instance'\r\n- ../flaskenv/var/config_module_app-instance\r\n?             ^ ^ ---  ^^^^^^^     ^\r\n+ ../flaskenv/flask/flask/testsuite/test_apps/instance\r\n?             ^^ ^^  +++++++++++ ^ +++++    ^^\r\n```\r\n\r\n```sh\r\nFAIL: test_uninstalled_package_paths (flask.testsuite.config.InstanceTestCase)\r\n\\----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"../flaskenv/flask/flask/testsuite/config.py\", line 169, in test_uninstalled_package_paths\r\n    self.assert_equal(app.instance_path, os.path.join(here, 'test_apps', 'instance'))\r\n\r\n  File \"../flaskenv/flask/flask/testsuite/__init__.py\", line 141, in assert_equal\r\n    return self.assertEqual(x, y)\r\n\r\nAssertionError: '/hom[23 chars]ang-py3-test/flaskenv/var/config_package_app-instance' != '/hom[23 chars]ang-py3-test/flaskenv/flask/flask/testsuite/test_apps/instance'\r\n- ../flaskenv/var/config_package_app-instance\r\n?             ^ ^ ---  ^^^^^^^^     ^\r\n+ ../flaskenv/flask/flask/testsuite/test_apps/instance\r\n?             ^^ ^^  +++++++++++ ^ +++++    ^^\r\n\r\n----------------------------------------------------------------------\r\nRan 226 tests in 4.574s\r\n\r\nFAILED (failures=3)\r\n```\r\n\r\nChanges In the following files remove this instance path Error from the Test case:\r\n\r\n- flask/testsuite/test_apps/config_module_app.py.\r\n\r\n```sh\r\napp = flask.Flask(__name__, instance_path=os.path.join(\r\n               os.path.abspath(os.path.dirname(__file__)),'instance')\r\n              )\r\n```\r\n\r\n- flask/testsuite/test_apps/config_package_app/__init__.py.\r\n\r\n```sh\r\napp = flask.Flask(__name__, instance_path=os.path.join(os.path.abspath(\r\n                os.path.dirname(os.path.dirname(__file__))),'instance')\r\n              )\r\n```\r\n- flask/testsuite/test_apps/main_app.py\r\n```sh\r\nimport os\r\n\r\napp = flask.Flask('__main__', instance_path=os.path.join(\r\n                os.path.abspath(os.path.dirname('__main__')),'instance')\r\n              )\r\n```"},"comment":{"url":"https://api.github.com/repos/mitsuhiko/flask/issues/comments/162531276","html_url":"https://github.com/mitsuhiko/flask/pull/1643#issuecomment-162531276","issue_url":"https://api.github.com/repos/mitsuhiko/flask/issues/1643","id":162531276,"user":{"login":"davidism","id":1242887,"avatar_url":"https://avatars.githubusercontent.com/u/1242887?v=3","gravatar_id":"","url":"https://api.github.com/users/davidism","html_url":"https://github.com/davidism","followers_url":"https://api.github.com/users/davidism/followers","following_url":"https://api.github.com/users/davidism/following{/other_user}","gists_url":"https://api.github.com/users/davidism/gists{/gist_id}","starred_url":"https://api.github.com/users/davidism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidism/subscriptions","organizations_url":"https://api.github.com/users/davidism/orgs","repos_url":"https://api.github.com/users/davidism/repos","events_url":"https://api.github.com/users/davidism/events{/privacy}","received_events_url":"https://api.github.com/users/davidism/received_events","type":"User","site_admin":false},"created_at":"2015-12-07T14:01:02Z","updated_at":"2015-12-07T14:01:02Z","body":"What's with that entry in CHANGES?\r\n\r\nIf the instance path is getting set incorrectly, are we sure we just want to be manually setting it in the tests rather than fixing why it's getting set incorrectly?  Also, I don't get these errors when running `py.test` or `tox`."}}