{"action":"created","issue":{"url":"https://api.github.com/repos/logicmonitor/logicmonitor-puppet/issues/16","labels_url":"https://api.github.com/repos/logicmonitor/logicmonitor-puppet/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/logicmonitor/logicmonitor-puppet/issues/16/comments","events_url":"https://api.github.com/repos/logicmonitor/logicmonitor-puppet/issues/16/events","html_url":"https://github.com/logicmonitor/logicmonitor-puppet/pull/16","id":52301678,"number":16,"title":"Modify module to more closely follow puppetlabs standards","user":{"login":"brdude","id":410764,"avatar_url":"https://avatars.githubusercontent.com/u/410764?v=3","gravatar_id":"","url":"https://api.github.com/users/brdude","html_url":"https://github.com/brdude","followers_url":"https://api.github.com/users/brdude/followers","following_url":"https://api.github.com/users/brdude/following{/other_user}","gists_url":"https://api.github.com/users/brdude/gists{/gist_id}","starred_url":"https://api.github.com/users/brdude/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brdude/subscriptions","organizations_url":"https://api.github.com/users/brdude/orgs","repos_url":"https://api.github.com/users/brdude/repos","events_url":"https://api.github.com/users/brdude/events{/privacy}","received_events_url":"https://api.github.com/users/brdude/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2014-12-17T22:37:39Z","updated_at":"2015-08-10T22:38:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/logicmonitor/logicmonitor-puppet/pulls/16","html_url":"https://github.com/logicmonitor/logicmonitor-puppet/pull/16","diff_url":"https://github.com/logicmonitor/logicmonitor-puppet/pull/16.diff","patch_url":"https://github.com/logicmonitor/logicmonitor-puppet/pull/16.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/logicmonitor/logicmonitor-puppet/issues/comments/129635764","html_url":"https://github.com/logicmonitor/logicmonitor-puppet/pull/16#issuecomment-129635764","issue_url":"https://api.github.com/repos/logicmonitor/logicmonitor-puppet/issues/16","id":129635764,"user":{"login":"brdude","id":410764,"avatar_url":"https://avatars.githubusercontent.com/u/410764?v=3","gravatar_id":"","url":"https://api.github.com/users/brdude","html_url":"https://github.com/brdude","followers_url":"https://api.github.com/users/brdude/followers","following_url":"https://api.github.com/users/brdude/following{/other_user}","gists_url":"https://api.github.com/users/brdude/gists{/gist_id}","starred_url":"https://api.github.com/users/brdude/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brdude/subscriptions","organizations_url":"https://api.github.com/users/brdude/orgs","repos_url":"https://api.github.com/users/brdude/repos","events_url":"https://api.github.com/users/brdude/events{/privacy}","received_events_url":"https://api.github.com/users/brdude/received_events","type":"User","site_admin":false},"created_at":"2015-08-10T22:38:59Z","updated_at":"2015-08-10T22:38:59Z","body":"Sorry for the delay in getting back to this but I could not spare the time earlier.\r\n\r\n::logicmonitor::master inheriting from ::logicmonitor was a mistake that has now been fixed and one should no longer be reliant on the other.\r\n\r\n::logicmonitor::host and ::logicmonitor::hostgroup should now only inherit the appropriate parameters from ::logicmonitor which in turn inherits them from params.pp. This lets a user also edit params.pp to add their user creds if they so whish to do. But I would have to advise against this last case as this would make the creds available to anyone that has access to the \"edited\" version of the module. This is the exact case scenario that puppetlabs created hiera to be used for.\r\n\r\nI'm using the puppetlabs/stdlib as it is a very widely used module which was created for this particular use and has been used in a variety of community available puppet modules. You are right that the functionality could be replicated but I'd rather not duplicate the effort that the folks at puppetlabs have put forward for this. If anything I'd rather just remove it from the module and let the user validate it them selves."}}