{"action":"created","issue":{"url":"https://api.github.com/repos/projectatomic/atomicapp/issues/331","labels_url":"https://api.github.com/repos/projectatomic/atomicapp/issues/331/labels{/name}","comments_url":"https://api.github.com/repos/projectatomic/atomicapp/issues/331/comments","events_url":"https://api.github.com/repos/projectatomic/atomicapp/issues/331/events","html_url":"https://github.com/projectatomic/atomicapp/issues/331","id":111844188,"number":331,"title":"Different set of config data passed from NuleculeBase config to providers.","user":{"login":"charliedrage","id":6422176,"avatar_url":"https://avatars.githubusercontent.com/u/6422176?v=3","gravatar_id":"","url":"https://api.github.com/users/charliedrage","html_url":"https://github.com/charliedrage","followers_url":"https://api.github.com/users/charliedrage/followers","following_url":"https://api.github.com/users/charliedrage/following{/other_user}","gists_url":"https://api.github.com/users/charliedrage/gists{/gist_id}","starred_url":"https://api.github.com/users/charliedrage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charliedrage/subscriptions","organizations_url":"https://api.github.com/users/charliedrage/orgs","repos_url":"https://api.github.com/users/charliedrage/repos","events_url":"https://api.github.com/users/charliedrage/events{/privacy}","received_events_url":"https://api.github.com/users/charliedrage/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-10-16T14:32:34Z","updated_at":"2015-10-16T15:33:18Z","closed_at":null,"body":"atomicapp master:\r\n````\r\n2015-10-16 10:23:21,606 - atomicapp.nulecule_base - DEBUG - Data given {'general': {'namespace': 'test', 'provider': 'docker'}}\r\n2015-10-16 10:23:21,606 - atomicapp.plugin - DEBUG - Found provider <class 'docker.DockerProvider'>\r\n2015-10-16 10:23:21,607 - atomicapp.plugin - WARNING - Configuration option 'providerconfig' not found\r\n2015-10-16 10:23:21,607 - docker - DEBUG - Given config: {'namespace': 'test', 'provider': 'docker'}\r\n```\r\n\r\ncdk2-beta3-rc1:\r\n```\r\n- WARNING - Configuration option 'providerconfig' not found\r\n2015-10-16 10:32:10,396 - atomicapp.providers.docker - DEBUG - Given config: {'general': {'namespace': 'test', 'provider': 'docker'}}\r\n2015-10-16 10:32:10,396 - atomicapp.providers.docker - DEBUG - Namespace: default\r\n```\r\n\r\nSee `Given config:` line.\r\n\r\nNow... for future integration and more information, I believe we should pass the __entire__ config (including \"general\"), which is what cdk2-beta3-rc1 is doing right now. If we perhaps happen to include more variables in the future, we wouldn't want to do another PR to fix and perhaps break integration.\r\n\r\nThis will however change the: \r\n`self.namespace = self.config.get(\"namespace\")`\r\nto\r\n`self.namespace = self.config[\"general\"][\"namespace\"]`\r\n\r\nIn all providers.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/projectatomic/atomicapp/issues/comments/148748088","html_url":"https://github.com/projectatomic/atomicapp/issues/331#issuecomment-148748088","issue_url":"https://api.github.com/repos/projectatomic/atomicapp/issues/331","id":148748088,"user":{"login":"charliedrage","id":6422176,"avatar_url":"https://avatars.githubusercontent.com/u/6422176?v=3","gravatar_id":"","url":"https://api.github.com/users/charliedrage","html_url":"https://github.com/charliedrage","followers_url":"https://api.github.com/users/charliedrage/followers","following_url":"https://api.github.com/users/charliedrage/following{/other_user}","gists_url":"https://api.github.com/users/charliedrage/gists{/gist_id}","starred_url":"https://api.github.com/users/charliedrage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charliedrage/subscriptions","organizations_url":"https://api.github.com/users/charliedrage/orgs","repos_url":"https://api.github.com/users/charliedrage/repos","events_url":"https://api.github.com/users/charliedrage/events{/privacy}","received_events_url":"https://api.github.com/users/charliedrage/received_events","type":"User","site_admin":false},"created_at":"2015-10-16T15:33:18Z","updated_at":"2015-10-16T15:33:18Z","body":"@rtnpro Yup, that will.\r\n\r\nWe will however have to change the Nulecule spec to conform to this. We should label this issue for **after** GA / Beta-3."}}