{"action":"created","issue":{"url":"https://api.github.com/repos/twosigma/goll-e/issues/32","labels_url":"https://api.github.com/repos/twosigma/goll-e/issues/32/labels{/name}","comments_url":"https://api.github.com/repos/twosigma/goll-e/issues/32/comments","events_url":"https://api.github.com/repos/twosigma/goll-e/issues/32/events","html_url":"https://github.com/twosigma/goll-e/pull/32","id":61913850,"number":32,"title":"Full screen container opening (Checkpoint) (BLOCKED) [GOL-33]","user":{"login":"jboolean","id":406931,"avatar_url":"https://avatars.githubusercontent.com/u/406931?v=3","gravatar_id":"","url":"https://api.github.com/users/jboolean","html_url":"https://github.com/jboolean","followers_url":"https://api.github.com/users/jboolean/followers","following_url":"https://api.github.com/users/jboolean/following{/other_user}","gists_url":"https://api.github.com/users/jboolean/gists{/gist_id}","starred_url":"https://api.github.com/users/jboolean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jboolean/subscriptions","organizations_url":"https://api.github.com/users/jboolean/orgs","repos_url":"https://api.github.com/users/jboolean/repos","events_url":"https://api.github.com/users/jboolean/events{/privacy}","received_events_url":"https://api.github.com/users/jboolean/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"jboolean","id":406931,"avatar_url":"https://avatars.githubusercontent.com/u/406931?v=3","gravatar_id":"","url":"https://api.github.com/users/jboolean","html_url":"https://github.com/jboolean","followers_url":"https://api.github.com/users/jboolean/followers","following_url":"https://api.github.com/users/jboolean/following{/other_user}","gists_url":"https://api.github.com/users/jboolean/gists{/gist_id}","starred_url":"https://api.github.com/users/jboolean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jboolean/subscriptions","organizations_url":"https://api.github.com/users/jboolean/orgs","repos_url":"https://api.github.com/users/jboolean/repos","events_url":"https://api.github.com/users/jboolean/events{/privacy}","received_events_url":"https://api.github.com/users/jboolean/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2015-03-15T22:41:43Z","updated_at":"2015-03-20T16:31:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/twosigma/goll-e/pulls/32","html_url":"https://github.com/twosigma/goll-e/pull/32","diff_url":"https://github.com/twosigma/goll-e/pull/32.diff","patch_url":"https://github.com/twosigma/goll-e/pull/32.patch"},"body":"This PR adds support for viewing sub-graphs (containers). They can be opened by double-clicking a node with sharp corners and navigated using breadcrumbs at the top. Styled using styles and ideas proposed in my photoshop comp.\r\n\r\n**Note:** This PR is **not to be merged**. It is branched off of **#30 zoom** as I needed GraphCanvas from there, and thus is **blocked** by the approval of #30. A new PR will be created once those changes are in and discussion here is finished.\r\n\r\nThere are a few things I don't like in this PR, and I'd like some feedback:\r\n* Passing the opening function as a prop. I tried to think about how to make some kind of global event bus, or implementation of the Command Pattern that would help decouple future event generators from receivers. Future events may include selection of an object, which would interest editor panels; grouping, which would interest the data models and may be generated via a button or a keyboard shortcut; or other such events with multiple generators or receivers. \r\n* The parallel array of container vertices in graphCanvas. Yuck. Better idea?\r\n* Making my own doubleclick. \r\n* Saving pan and zoom like that seems inelegant, but I don't know a better way. I mean, you could leave the graphs in the DOM, hidden, but then it would be rendering potentially large graphs you can't see.\r\n* I'd like to add an animation where the vertex zooms in to indicate traversing into it. I tried this with CSS animations, but could only get it to zoom to the corner; I couldn't figure out how to animate a scale about the center."},"comment":{"url":"https://api.github.com/repos/twosigma/goll-e/issues/comments/84062420","html_url":"https://github.com/twosigma/goll-e/pull/32#issuecomment-84062420","issue_url":"https://api.github.com/repos/twosigma/goll-e/issues/32","id":84062420,"user":{"login":"jboolean","id":406931,"avatar_url":"https://avatars.githubusercontent.com/u/406931?v=3","gravatar_id":"","url":"https://api.github.com/users/jboolean","html_url":"https://github.com/jboolean","followers_url":"https://api.github.com/users/jboolean/followers","following_url":"https://api.github.com/users/jboolean/following{/other_user}","gists_url":"https://api.github.com/users/jboolean/gists{/gist_id}","starred_url":"https://api.github.com/users/jboolean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jboolean/subscriptions","organizations_url":"https://api.github.com/users/jboolean/orgs","repos_url":"https://api.github.com/users/jboolean/repos","events_url":"https://api.github.com/users/jboolean/events{/privacy}","received_events_url":"https://api.github.com/users/jboolean/received_events","type":"User","site_admin":false},"created_at":"2015-03-20T16:31:40Z","updated_at":"2015-03-20T16:31:40Z","body":"Silence is consent. "}}