{"action":"created","comment":{"url":"https://api.github.com/repos/gaye/confidant/pulls/comments/35714180","id":35714180,"diff_hunk":"@@ -5,26 +5,23 @@\n   \"bin\": \"./bin/confidant\",\n   \"license\": \"MPL-2.0\",\n   \"main\": \"./build/main\",\n-","path":"package.json","position":4,"original_position":4,"commit_id":"72926a96c8c812b7e24654bca51f4d70d531ca4b","original_commit_id":"92edd0da75beac11a6e33b25d6ff224bed9bc1c0","user":{"login":"gaye","id":535859,"avatar_url":"https://avatars.githubusercontent.com/u/535859?v=3","gravatar_id":"","url":"https://api.github.com/users/gaye","html_url":"https://github.com/gaye","followers_url":"https://api.github.com/users/gaye/followers","following_url":"https://api.github.com/users/gaye/following{/other_user}","gists_url":"https://api.github.com/users/gaye/gists{/gist_id}","starred_url":"https://api.github.com/users/gaye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaye/subscriptions","organizations_url":"https://api.github.com/users/gaye/orgs","repos_url":"https://api.github.com/users/gaye/repos","events_url":"https://api.github.com/users/gaye/events{/privacy}","received_events_url":"https://api.github.com/users/gaye/received_events","type":"User","site_admin":false},"body":"Okay fair enough","created_at":"2015-07-28T23:30:15Z","updated_at":"2015-07-28T23:30:15Z","html_url":"https://github.com/gaye/confidant/pull/31#discussion_r35714180","pull_request_url":"https://api.github.com/repos/gaye/confidant/pulls/31","_links":{"self":{"href":"https://api.github.com/repos/gaye/confidant/pulls/comments/35714180"},"html":{"href":"https://github.com/gaye/confidant/pull/31#discussion_r35714180"},"pull_request":{"href":"https://api.github.com/repos/gaye/confidant/pulls/31"}}},"pull_request":{"url":"https://api.github.com/repos/gaye/confidant/pulls/31","id":40758273,"html_url":"https://github.com/gaye/confidant/pull/31","diff_url":"https://github.com/gaye/confidant/pull/31.diff","patch_url":"https://github.com/gaye/confidant/pull/31.patch","issue_url":"https://api.github.com/repos/gaye/confidant/issues/31","number":31,"state":"open","locked":false,"title":"Support config.json and pass environment variables into ninja.build","user":{"login":"rickychien","id":958165,"avatar_url":"https://avatars.githubusercontent.com/u/958165?v=3","gravatar_id":"","url":"https://api.github.com/users/rickychien","html_url":"https://github.com/rickychien","followers_url":"https://api.github.com/users/rickychien/followers","following_url":"https://api.github.com/users/rickychien/following{/other_user}","gists_url":"https://api.github.com/users/rickychien/gists{/gist_id}","starred_url":"https://api.github.com/users/rickychien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rickychien/subscriptions","organizations_url":"https://api.github.com/users/rickychien/orgs","repos_url":"https://api.github.com/users/rickychien/repos","events_url":"https://api.github.com/users/rickychien/events{/privacy}","received_events_url":"https://api.github.com/users/rickychien/received_events","type":"User","site_admin":false},"body":"According issue #31.\r\n\r\nA scenario comes out of my mind to build Gaia would be:\r\n```\r\nDEBUG=1 MYPATH=path/to/somewhere bin/confidant . --config ./build-config.json\r\n```\r\nThis patch is able to merge given variables such as DEBUG=1 MYPATH=path/to/somewhere and config variables inside build-config.json as a string of variables in order to pass them into build.ninja.\r\n\r\nThe idea of build-config.json can treat as a build config interface which should contain all build variables / flags and override by input / exports environment variables.\r\n\r\nA build-config.json\r\n```json\r\n{\r\n  \"DEBUG\": 1,\r\n  \"MYPATH\": \"path/to/somewhere\"\r\n}\r\n```\r\n\r\nIf user inputs variables that are inexistent in build-config.json that will not pass into build.ninja because they should be defined in build-config interface.","created_at":"2015-07-24T09:40:30Z","updated_at":"2015-07-28T23:30:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da7dcfb8092bab5f72abfc2454969d317c77d271","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gaye/confidant/pulls/31/commits","review_comments_url":"https://api.github.com/repos/gaye/confidant/pulls/31/comments","review_comment_url":"https://api.github.com/repos/gaye/confidant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gaye/confidant/issues/31/comments","statuses_url":"https://api.github.com/repos/gaye/confidant/statuses/72926a96c8c812b7e24654bca51f4d70d531ca4b","head":{"label":"rickychien:support-passing-envs","ref":"support-passing-envs","sha":"72926a96c8c812b7e24654bca51f4d70d531ca4b","user":{"login":"rickychien","id":958165,"avatar_url":"https://avatars.githubusercontent.com/u/958165?v=3","gravatar_id":"","url":"https://api.github.com/users/rickychien","html_url":"https://github.com/rickychien","followers_url":"https://api.github.com/users/rickychien/followers","following_url":"https://api.github.com/users/rickychien/following{/other_user}","gists_url":"https://api.github.com/users/rickychien/gists{/gist_id}","starred_url":"https://api.github.com/users/rickychien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rickychien/subscriptions","organizations_url":"https://api.github.com/users/rickychien/orgs","repos_url":"https://api.github.com/users/rickychien/repos","events_url":"https://api.github.com/users/rickychien/events{/privacy}","received_events_url":"https://api.github.com/users/rickychien/received_events","type":"User","site_admin":false},"repo":{"id":39240983,"name":"confidant","full_name":"rickychien/confidant","owner":{"login":"rickychien","id":958165,"avatar_url":"https://avatars.githubusercontent.com/u/958165?v=3","gravatar_id":"","url":"https://api.github.com/users/rickychien","html_url":"https://github.com/rickychien","followers_url":"https://api.github.com/users/rickychien/followers","following_url":"https://api.github.com/users/rickychien/following{/other_user}","gists_url":"https://api.github.com/users/rickychien/gists{/gist_id}","starred_url":"https://api.github.com/users/rickychien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rickychien/subscriptions","organizations_url":"https://api.github.com/users/rickychien/orgs","repos_url":"https://api.github.com/users/rickychien/repos","events_url":"https://api.github.com/users/rickychien/events{/privacy}","received_events_url":"https://api.github.com/users/rickychien/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rickychien/confidant","description":"Configure your project for ninja's parallel and incremental builds with pure js","fork":true,"url":"https://api.github.com/repos/rickychien/confidant","forks_url":"https://api.github.com/repos/rickychien/confidant/forks","keys_url":"https://api.github.com/repos/rickychien/confidant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rickychien/confidant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rickychien/confidant/teams","hooks_url":"https://api.github.com/repos/rickychien/confidant/hooks","issue_events_url":"https://api.github.com/repos/rickychien/confidant/issues/events{/number}","events_url":"https://api.github.com/repos/rickychien/confidant/events","assignees_url":"https://api.github.com/repos/rickychien/confidant/assignees{/user}","branches_url":"https://api.github.com/repos/rickychien/confidant/branches{/branch}","tags_url":"https://api.github.com/repos/rickychien/confidant/tags","blobs_url":"https://api.github.com/repos/rickychien/confidant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rickychien/confidant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rickychien/confidant/git/refs{/sha}","trees_url":"https://api.github.com/repos/rickychien/confidant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rickychien/confidant/statuses/{sha}","languages_url":"https://api.github.com/repos/rickychien/confidant/languages","stargazers_url":"https://api.github.com/repos/rickychien/confidant/stargazers","contributors_url":"https://api.github.com/repos/rickychien/confidant/contributors","subscribers_url":"https://api.github.com/repos/rickychien/confidant/subscribers","subscription_url":"https://api.github.com/repos/rickychien/confidant/subscription","commits_url":"https://api.github.com/repos/rickychien/confidant/commits{/sha}","git_commits_url":"https://api.github.com/repos/rickychien/confidant/git/commits{/sha}","comments_url":"https://api.github.com/repos/rickychien/confidant/comments{/number}","issue_comment_url":"https://api.github.com/repos/rickychien/confidant/issues/comments{/number}","contents_url":"https://api.github.com/repos/rickychien/confidant/contents/{+path}","compare_url":"https://api.github.com/repos/rickychien/confidant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rickychien/confidant/merges","archive_url":"https://api.github.com/repos/rickychien/confidant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rickychien/confidant/downloads","issues_url":"https://api.github.com/repos/rickychien/confidant/issues{/number}","pulls_url":"https://api.github.com/repos/rickychien/confidant/pulls{/number}","milestones_url":"https://api.github.com/repos/rickychien/confidant/milestones{/number}","notifications_url":"https://api.github.com/repos/rickychien/confidant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rickychien/confidant/labels{/name}","releases_url":"https://api.github.com/repos/rickychien/confidant/releases{/id}","created_at":"2015-07-17T07:29:45Z","updated_at":"2015-07-17T07:29:45Z","pushed_at":"2015-07-28T16:11:28Z","git_url":"git://github.com/rickychien/confidant.git","ssh_url":"git@github.com:rickychien/confidant.git","clone_url":"https://github.com/rickychien/confidant.git","svn_url":"https://github.com/rickychien/confidant","homepage":null,"size":120,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gaye:master","ref":"master","sha":"089392518e151ac9444814abda1fa75f6c17ff69","user":{"login":"gaye","id":535859,"avatar_url":"https://avatars.githubusercontent.com/u/535859?v=3","gravatar_id":"","url":"https://api.github.com/users/gaye","html_url":"https://github.com/gaye","followers_url":"https://api.github.com/users/gaye/followers","following_url":"https://api.github.com/users/gaye/following{/other_user}","gists_url":"https://api.github.com/users/gaye/gists{/gist_id}","starred_url":"https://api.github.com/users/gaye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaye/subscriptions","organizations_url":"https://api.github.com/users/gaye/orgs","repos_url":"https://api.github.com/users/gaye/repos","events_url":"https://api.github.com/users/gaye/events{/privacy}","received_events_url":"https://api.github.com/users/gaye/received_events","type":"User","site_admin":false},"repo":{"id":38180388,"name":"confidant","full_name":"gaye/confidant","owner":{"login":"gaye","id":535859,"avatar_url":"https://avatars.githubusercontent.com/u/535859?v=3","gravatar_id":"","url":"https://api.github.com/users/gaye","html_url":"https://github.com/gaye","followers_url":"https://api.github.com/users/gaye/followers","following_url":"https://api.github.com/users/gaye/following{/other_user}","gists_url":"https://api.github.com/users/gaye/gists{/gist_id}","starred_url":"https://api.github.com/users/gaye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaye/subscriptions","organizations_url":"https://api.github.com/users/gaye/orgs","repos_url":"https://api.github.com/users/gaye/repos","events_url":"https://api.github.com/users/gaye/events{/privacy}","received_events_url":"https://api.github.com/users/gaye/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gaye/confidant","description":"Configure your project for ninja's parallel and incremental builds with pure js","fork":false,"url":"https://api.github.com/repos/gaye/confidant","forks_url":"https://api.github.com/repos/gaye/confidant/forks","keys_url":"https://api.github.com/repos/gaye/confidant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gaye/confidant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gaye/confidant/teams","hooks_url":"https://api.github.com/repos/gaye/confidant/hooks","issue_events_url":"https://api.github.com/repos/gaye/confidant/issues/events{/number}","events_url":"https://api.github.com/repos/gaye/confidant/events","assignees_url":"https://api.github.com/repos/gaye/confidant/assignees{/user}","branches_url":"https://api.github.com/repos/gaye/confidant/branches{/branch}","tags_url":"https://api.github.com/repos/gaye/confidant/tags","blobs_url":"https://api.github.com/repos/gaye/confidant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gaye/confidant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gaye/confidant/git/refs{/sha}","trees_url":"https://api.github.com/repos/gaye/confidant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gaye/confidant/statuses/{sha}","languages_url":"https://api.github.com/repos/gaye/confidant/languages","stargazers_url":"https://api.github.com/repos/gaye/confidant/stargazers","contributors_url":"https://api.github.com/repos/gaye/confidant/contributors","subscribers_url":"https://api.github.com/repos/gaye/confidant/subscribers","subscription_url":"https://api.github.com/repos/gaye/confidant/subscription","commits_url":"https://api.github.com/repos/gaye/confidant/commits{/sha}","git_commits_url":"https://api.github.com/repos/gaye/confidant/git/commits{/sha}","comments_url":"https://api.github.com/repos/gaye/confidant/comments{/number}","issue_comment_url":"https://api.github.com/repos/gaye/confidant/issues/comments{/number}","contents_url":"https://api.github.com/repos/gaye/confidant/contents/{+path}","compare_url":"https://api.github.com/repos/gaye/confidant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gaye/confidant/merges","archive_url":"https://api.github.com/repos/gaye/confidant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gaye/confidant/downloads","issues_url":"https://api.github.com/repos/gaye/confidant/issues{/number}","pulls_url":"https://api.github.com/repos/gaye/confidant/pulls{/number}","milestones_url":"https://api.github.com/repos/gaye/confidant/milestones{/number}","notifications_url":"https://api.github.com/repos/gaye/confidant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gaye/confidant/labels{/name}","releases_url":"https://api.github.com/repos/gaye/confidant/releases{/id}","created_at":"2015-06-28T00:16:57Z","updated_at":"2015-06-28T20:48:19Z","pushed_at":"2015-07-28T16:11:29Z","git_url":"git://github.com/gaye/confidant.git","ssh_url":"git@github.com:gaye/confidant.git","clone_url":"https://github.com/gaye/confidant.git","svn_url":"https://github.com/gaye/confidant","homepage":null,"size":504,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gaye/confidant/pulls/31"},"html":{"href":"https://github.com/gaye/confidant/pull/31"},"issue":{"href":"https://api.github.com/repos/gaye/confidant/issues/31"},"comments":{"href":"https://api.github.com/repos/gaye/confidant/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/gaye/confidant/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/gaye/confidant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gaye/confidant/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/gaye/confidant/statuses/72926a96c8c812b7e24654bca51f4d70d531ca4b"}}}}