{"action":"created","issue":{"url":"https://api.github.com/repos/guardian/scribe/issues/346","labels_url":"https://api.github.com/repos/guardian/scribe/issues/346/labels{/name}","comments_url":"https://api.github.com/repos/guardian/scribe/issues/346/comments","events_url":"https://api.github.com/repos/guardian/scribe/issues/346/events","html_url":"https://github.com/guardian/scribe/pull/346","id":59864663,"number":346,"title":"UndoManager Improvements","user":{"login":"aaalsaleh","id":2429074,"avatar_url":"https://avatars.githubusercontent.com/u/2429074?v=3","gravatar_id":"","url":"https://api.github.com/users/aaalsaleh","html_url":"https://github.com/aaalsaleh","followers_url":"https://api.github.com/users/aaalsaleh/followers","following_url":"https://api.github.com/users/aaalsaleh/following{/other_user}","gists_url":"https://api.github.com/users/aaalsaleh/gists{/gist_id}","starred_url":"https://api.github.com/users/aaalsaleh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaalsaleh/subscriptions","organizations_url":"https://api.github.com/users/aaalsaleh/orgs","repos_url":"https://api.github.com/users/aaalsaleh/repos","events_url":"https://api.github.com/users/aaalsaleh/events{/privacy}","received_events_url":"https://api.github.com/users/aaalsaleh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-03-04T21:26:28Z","updated_at":"2015-03-05T11:43:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/guardian/scribe/pulls/346","html_url":"https://github.com/guardian/scribe/pull/346","diff_url":"https://github.com/guardian/scribe/pull/346.diff","patch_url":"https://github.com/guardian/scribe/pull/346.patch"},"body":"This pull request implements #334, and provides a form of improvement for the undo manager behavior as suggested in #335:\r\n\r\n1. Replaces the current undo manager with a new undo manager. The new undo manager follows the W3C UndoManager specifications, and is more flexible than the current one. See: https://github.com/aaalsaleh/undo-manager\r\n2. Updates the way transactions are pushed into the new undo manager.\r\n3. Adds an `interval` option for the undo manager. Now, consecutive transactions within `interval` will be merged as a single transaction (#335).\r\n4. Adds a new `setUndoManager` API for replacing the internal undo manager with external undo manager (#334).\r\n5. Several other tiny updates over the undo/redo core commands, and core/patch events. These are needed for the new undo manager.\r\n\r\nPlease note that point 2 and 3 can be further improved and optimized specifically for Scribe. For example, transactions content can be replaced instead of merged to save space. Also, merging condition can be improved to take other factors into account.\r\n"},"comment":{"url":"https://api.github.com/repos/guardian/scribe/issues/comments/77350369","html_url":"https://github.com/guardian/scribe/pull/346#issuecomment-77350369","issue_url":"https://api.github.com/repos/guardian/scribe/issues/346","id":77350369,"user":{"login":"cutandpastey","id":1975139,"avatar_url":"https://avatars.githubusercontent.com/u/1975139?v=3","gravatar_id":"","url":"https://api.github.com/users/cutandpastey","html_url":"https://github.com/cutandpastey","followers_url":"https://api.github.com/users/cutandpastey/followers","following_url":"https://api.github.com/users/cutandpastey/following{/other_user}","gists_url":"https://api.github.com/users/cutandpastey/gists{/gist_id}","starred_url":"https://api.github.com/users/cutandpastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cutandpastey/subscriptions","organizations_url":"https://api.github.com/users/cutandpastey/orgs","repos_url":"https://api.github.com/users/cutandpastey/repos","events_url":"https://api.github.com/users/cutandpastey/events{/privacy}","received_events_url":"https://api.github.com/users/cutandpastey/received_events","type":"User","site_admin":false},"created_at":"2015-03-05T11:43:20Z","updated_at":"2015-03-05T11:43:20Z","body":"@aaalsaleh `undoManager.stack` was public before your amends so I don't think you need to worry about that being private and I can't see the value of hiding the check either."}}