{"comment":{"url":"https://api.github.com/repos/jenswi-linaro/optee_os/comments/13986621","html_url":"https://github.com/jenswi-linaro/optee_os/commit/0252d0dfee64a29ebee578d64786fa58f255639e#commitcomment-13986621","id":13986621,"user":{"login":"jforissier","id":8288195,"avatar_url":"https://avatars.githubusercontent.com/u/8288195?v=3","gravatar_id":"","url":"https://api.github.com/users/jforissier","html_url":"https://github.com/jforissier","followers_url":"https://api.github.com/users/jforissier/followers","following_url":"https://api.github.com/users/jforissier/following{/other_user}","gists_url":"https://api.github.com/users/jforissier/gists{/gist_id}","starred_url":"https://api.github.com/users/jforissier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jforissier/subscriptions","organizations_url":"https://api.github.com/users/jforissier/orgs","repos_url":"https://api.github.com/users/jforissier/repos","events_url":"https://api.github.com/users/jforissier/events{/privacy}","received_events_url":"https://api.github.com/users/jforissier/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"0252d0dfee64a29ebee578d64786fa58f255639e","created_at":"2015-10-26T15:03:32Z","updated_at":"2015-10-26T15:03:32Z","body":"This is indeed nice for debugging, but by doing this we are deviating from the GP specification, which defines `TEE_Panic()` as a function, not a macro.\r\nCould we make this conditional? For instance, do not rename the function, add a function `__TEE_Panic()` which would call `TEE_Panic()`, and do the `#define` as above only if some debug config variable is set."}}