{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/33900196","id":33900196,"diff_hunk":"@@ -334,7 +322,7 @@ void MultiHitGeneratorFromChi2::hitSets(const TrackingRegion& region,\n     for(int il = 0; (il < size) & (!usePair); il++) {\n \n       if (debugPair) \n-\tcout << \"cosider layer: \" << theLayers[il].name() << \" for this pair. Location: \" << theLayers[il].detLayer()->location() << endl;\n+\tcout << \"cosider layer: \" << thirdLayers[il].name() << \" for this pair. Location: \" << thirdLayers[il].detLayer()->location() << endl;","path":"RecoTracker/TkSeedGenerator/plugins/MultiHitGeneratorFromChi2.cc","position":108,"original_position":108,"commit_id":"52de51aeb3b89e08d79f7564ca6cd2393753f42c","original_commit_id":"52de51aeb3b89e08d79f7564ca6cd2393753f42c","user":{"login":"cvuosalo","id":5736159,"avatar_url":"https://avatars.githubusercontent.com/u/5736159?v=3","gravatar_id":"","url":"https://api.github.com/users/cvuosalo","html_url":"https://github.com/cvuosalo","followers_url":"https://api.github.com/users/cvuosalo/followers","following_url":"https://api.github.com/users/cvuosalo/following{/other_user}","gists_url":"https://api.github.com/users/cvuosalo/gists{/gist_id}","starred_url":"https://api.github.com/users/cvuosalo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvuosalo/subscriptions","organizations_url":"https://api.github.com/users/cvuosalo/orgs","repos_url":"https://api.github.com/users/cvuosalo/repos","events_url":"https://api.github.com/users/cvuosalo/events{/privacy}","received_events_url":"https://api.github.com/users/cvuosalo/received_events","type":"User","site_admin":false},"body":"@makortel: OK. Please clean up the cout statements in a later PR.","created_at":"2015-07-05T23:18:11Z","updated_at":"2015-07-05T23:18:11Z","html_url":"https://github.com/cms-sw/cmssw/pull/10016#discussion_r33900196","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/10016","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/33900196"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/10016#discussion_r33900196"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/10016"}}},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/10016","id":39076063,"html_url":"https://github.com/cms-sw/cmssw/pull/10016","diff_url":"https://github.com/cms-sw/cmssw/pull/10016.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/10016.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/10016","number":10016,"state":"open","locked":false,"title":"Simplify class stucture of hit generators","user":{"login":"makortel","id":33993,"avatar_url":"https://avatars.githubusercontent.com/u/33993?v=3","gravatar_id":"","url":"https://api.github.com/users/makortel","html_url":"https://github.com/makortel","followers_url":"https://api.github.com/users/makortel/followers","following_url":"https://api.github.com/users/makortel/following{/other_user}","gists_url":"https://api.github.com/users/makortel/gists{/gist_id}","starred_url":"https://api.github.com/users/makortel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makortel/subscriptions","organizations_url":"https://api.github.com/users/makortel/orgs","repos_url":"https://api.github.com/users/makortel/repos","events_url":"https://api.github.com/users/makortel/events{/privacy}","received_events_url":"https://api.github.com/users/makortel/received_events","type":"User","site_admin":false},"body":"Current inheritance chain of the hit generators is somewhat messy, and in some parts does not serve the current usage of the classes. This PR removes unnecessary inheritances and does some further cleanup allowed by the removal.\r\n\r\nEssentially, the inheritance from HitPairGenerator is removed from\r\n* HitPairGeneratorFromLayerPair\r\n* CombinedHitQuadrupletGeneratorForPhotonConversion\r\n* HitQuadrupletGeneratorFromLayerPairForPhotonConversion\r\n* CosmicHitPairGenerator\r\n* CosmicHitPairGeneratorFromLayerPair,\r\n\r\nthe inheritance from HitTripletGenerator from\r\n* HitTripletGeneratorFromPairAndLayers\r\n* CosmicHitTripletGenerator\r\n* CosmicHitTripletGeneratorFromLayerTriplet,\r\n\r\nand the inheritance from MultiHitGenerator from\r\n* MultiHitGeneratorFromPairAndLayers.\r\n\r\n(Most of the developments were actually done already more than a year ago, but for some reason I didn't push them for integration and they got buried under other stuff)\r\n\r\nTested in 750pre5, no changes expected in results.\r\n\r\n@rovere @VinInn ","created_at":"2015-07-02T12:13:37Z","updated_at":"2015-07-05T23:18:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90a2d10adb6ba1324e88cba74256fe26f4005d8e","assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/55","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_7_6_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/55/labels","id":1176788,"number":55,"title":"Next CMSSW_7_6_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":67,"closed_issues":89,"state":"open","created_at":"2015-06-23T07:27:04Z","updated_at":"2015-07-05T05:51:14Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/10016/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/10016/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/10016/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/52de51aeb3b89e08d79f7564ca6cd2393753f42c","head":{"label":"makortel:simplify_hitgenerators_v3","ref":"simplify_hitgenerators_v3","sha":"52de51aeb3b89e08d79f7564ca6cd2393753f42c","user":{"login":"makortel","id":33993,"avatar_url":"https://avatars.githubusercontent.com/u/33993?v=3","gravatar_id":"","url":"https://api.github.com/users/makortel","html_url":"https://github.com/makortel","followers_url":"https://api.github.com/users/makortel/followers","following_url":"https://api.github.com/users/makortel/following{/other_user}","gists_url":"https://api.github.com/users/makortel/gists{/gist_id}","starred_url":"https://api.github.com/users/makortel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makortel/subscriptions","organizations_url":"https://api.github.com/users/makortel/orgs","repos_url":"https://api.github.com/users/makortel/repos","events_url":"https://api.github.com/users/makortel/events{/privacy}","received_events_url":"https://api.github.com/users/makortel/received_events","type":"User","site_admin":false},"repo":{"id":11017982,"name":"cmssw","full_name":"makortel/cmssw","owner":{"login":"makortel","id":33993,"avatar_url":"https://avatars.githubusercontent.com/u/33993?v=3","gravatar_id":"","url":"https://api.github.com/users/makortel","html_url":"https://github.com/makortel","followers_url":"https://api.github.com/users/makortel/followers","following_url":"https://api.github.com/users/makortel/following{/other_user}","gists_url":"https://api.github.com/users/makortel/gists{/gist_id}","starred_url":"https://api.github.com/users/makortel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makortel/subscriptions","organizations_url":"https://api.github.com/users/makortel/orgs","repos_url":"https://api.github.com/users/makortel/repos","events_url":"https://api.github.com/users/makortel/events{/privacy}","received_events_url":"https://api.github.com/users/makortel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/makortel/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/makortel/cmssw","forks_url":"https://api.github.com/repos/makortel/cmssw/forks","keys_url":"https://api.github.com/repos/makortel/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/makortel/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/makortel/cmssw/teams","hooks_url":"https://api.github.com/repos/makortel/cmssw/hooks","issue_events_url":"https://api.github.com/repos/makortel/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/makortel/cmssw/events","assignees_url":"https://api.github.com/repos/makortel/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/makortel/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/makortel/cmssw/tags","blobs_url":"https://api.github.com/repos/makortel/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/makortel/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/makortel/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/makortel/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/makortel/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/makortel/cmssw/languages","stargazers_url":"https://api.github.com/repos/makortel/cmssw/stargazers","contributors_url":"https://api.github.com/repos/makortel/cmssw/contributors","subscribers_url":"https://api.github.com/repos/makortel/cmssw/subscribers","subscription_url":"https://api.github.com/repos/makortel/cmssw/subscription","commits_url":"https://api.github.com/repos/makortel/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/makortel/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/makortel/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/makortel/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/makortel/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/makortel/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/makortel/cmssw/merges","archive_url":"https://api.github.com/repos/makortel/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/makortel/cmssw/downloads","issues_url":"https://api.github.com/repos/makortel/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/makortel/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/makortel/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/makortel/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/makortel/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/makortel/cmssw/releases{/id}","created_at":"2013-06-28T06:39:15Z","updated_at":"2014-06-24T14:24:59Z","pushed_at":"2015-07-03T13:35:51Z","git_url":"git://github.com/makortel/cmssw.git","ssh_url":"git@github.com:makortel/cmssw.git","clone_url":"https://github.com/makortel/cmssw.git","svn_url":"https://github.com/makortel/cmssw","homepage":null,"size":743161,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CMSSW_7_0_X"}},"base":{"label":"cms-sw:CMSSW_7_6_X","ref":"CMSSW_7_6_X","sha":"d454a1acfee4d01becbd18bf0feaf51233918ffb","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","created_at":"2013-06-26T14:09:07Z","updated_at":"2015-07-03T06:12:35Z","pushed_at":"2015-07-05T22:51:41Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":1184472,"stargazers_count":244,"watchers_count":244,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1479,"mirror_url":null,"open_issues_count":207,"forks":1479,"open_issues":207,"watchers":244,"default_branch":"CMSSW_7_6_X"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/10016"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/10016"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/10016"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/10016/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/10016/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/10016/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/52de51aeb3b89e08d79f7564ca6cd2393753f42c"}}}}