{"action":"created","issue":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/3542","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/3542/labels{/name}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/3542/comments","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/3542/events","html_url":"https://github.com/RIOT-OS/RIOT/pull/3542","id":98691245,"number":3542,"title":"sys/trickle: Makefile and include guards cleanup","user":{"login":"cgundogan","id":739129,"avatar_url":"https://avatars.githubusercontent.com/u/739129?v=3","gravatar_id":"","url":"https://api.github.com/users/cgundogan","html_url":"https://github.com/cgundogan","followers_url":"https://api.github.com/users/cgundogan/followers","following_url":"https://api.github.com/users/cgundogan/following{/other_user}","gists_url":"https://api.github.com/users/cgundogan/gists{/gist_id}","starred_url":"https://api.github.com/users/cgundogan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgundogan/subscriptions","organizations_url":"https://api.github.com/users/cgundogan/orgs","repos_url":"https://api.github.com/users/cgundogan/repos","events_url":"https://api.github.com/users/cgundogan/events{/privacy}","received_events_url":"https://api.github.com/users/cgundogan/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/cleanup","name":"cleanup","color":"FF7c7c"},{"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/enhancement","name":"enhancement","color":"f17070"},{"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/Ready%20for%20CI%20build","name":"Ready for CI build","color":"bfdadc"}],"state":"open","locked":false,"assignee":{"login":"OlegHahm","id":1590423,"avatar_url":"https://avatars.githubusercontent.com/u/1590423?v=3","gravatar_id":"","url":"https://api.github.com/users/OlegHahm","html_url":"https://github.com/OlegHahm","followers_url":"https://api.github.com/users/OlegHahm/followers","following_url":"https://api.github.com/users/OlegHahm/following{/other_user}","gists_url":"https://api.github.com/users/OlegHahm/gists{/gist_id}","starred_url":"https://api.github.com/users/OlegHahm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OlegHahm/subscriptions","organizations_url":"https://api.github.com/users/OlegHahm/orgs","repos_url":"https://api.github.com/users/OlegHahm/repos","events_url":"https://api.github.com/users/OlegHahm/events{/privacy}","received_events_url":"https://api.github.com/users/OlegHahm/received_events","type":"User","site_admin":false},"milestone":null,"comments":5,"created_at":"2015-08-03T07:57:48Z","updated_at":"2015-08-03T08:42:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3542","html_url":"https://github.com/RIOT-OS/RIOT/pull/3542","diff_url":"https://github.com/RIOT-OS/RIOT/pull/3542.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/3542.patch"},"body":"1. The first commit removes unneeded lines in Makefiles for `trickle`\r\n  * `sys/trickle/Makefile`\r\n  * `sys/Makefile`\r\n2. The second commit removes the leading underline for the include guard in `sys/include/trickle.h`\r\n\r\nI am not sure about the first commit, but trickle still builds without mentioning it in these Makefiles. I assuming you only need entries there if the module name differ from the folder name or has a more complex path?"},"comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments/127164975","html_url":"https://github.com/RIOT-OS/RIOT/pull/3542#issuecomment-127164975","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/3542","id":127164975,"user":{"login":"cgundogan","id":739129,"avatar_url":"https://avatars.githubusercontent.com/u/739129?v=3","gravatar_id":"","url":"https://api.github.com/users/cgundogan","html_url":"https://github.com/cgundogan","followers_url":"https://api.github.com/users/cgundogan/followers","following_url":"https://api.github.com/users/cgundogan/following{/other_user}","gists_url":"https://api.github.com/users/cgundogan/gists{/gist_id}","starred_url":"https://api.github.com/users/cgundogan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgundogan/subscriptions","organizations_url":"https://api.github.com/users/cgundogan/orgs","repos_url":"https://api.github.com/users/cgundogan/repos","events_url":"https://api.github.com/users/cgundogan/events{/privacy}","received_events_url":"https://api.github.com/users/cgundogan/received_events","type":"User","site_admin":false},"created_at":"2015-08-03T08:42:06Z","updated_at":"2015-08-03T08:42:06Z","body":">nice, then lets wait for the dynamic duo\r\n\r\nyou mean tom and jerry .. I always have the impression they work against each other instead of completing each other (:"}}