{"action":"created","comment":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/comments/39390690","id":39390690,"diff_hunk":"@@ -1971,7 +1971,7 @@ protected void finalizeNetworkRulesForNetwork(final Commands cmds, final DomainR\n     }\n \n     private void createDefaultEgressFirewallRule(final List<FirewallRule> rules, final long networkId) {\n-        String systemRule = null;\n+        // String systemRule = null;","path":"server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java","position":16,"original_position":16,"commit_id":"088eb45fcd1618624b72af3c3eba0b19acb77aac","original_commit_id":"088eb45fcd1618624b72af3c3eba0b19acb77aac","user":{"login":"mike-tutkowski","id":3019295,"avatar_url":"https://avatars.githubusercontent.com/u/3019295?v=3","gravatar_id":"","url":"https://api.github.com/users/mike-tutkowski","html_url":"https://github.com/mike-tutkowski","followers_url":"https://api.github.com/users/mike-tutkowski/followers","following_url":"https://api.github.com/users/mike-tutkowski/following{/other_user}","gists_url":"https://api.github.com/users/mike-tutkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/mike-tutkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike-tutkowski/subscriptions","organizations_url":"https://api.github.com/users/mike-tutkowski/orgs","repos_url":"https://api.github.com/users/mike-tutkowski/repos","events_url":"https://api.github.com/users/mike-tutkowski/events{/privacy}","received_events_url":"https://api.github.com/users/mike-tutkowski/received_events","type":"User","site_admin":false},"body":"While making changes in this file, I noticed that Eclipse was pointing out that the variable systemRule was only written to (never read from). Instead of removing the entire line, I just commented it out in case someone later wanted to easily resume making use of this variable.","created_at":"2015-09-14T13:07:40Z","updated_at":"2015-09-14T13:07:40Z","html_url":"https://github.com/apache/cloudstack/pull/816#discussion_r39390690","pull_request_url":"https://api.github.com/repos/apache/cloudstack/pulls/816","_links":{"self":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/comments/39390690"},"html":{"href":"https://github.com/apache/cloudstack/pull/816#discussion_r39390690"},"pull_request":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/816"}}},"pull_request":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/816","id":44897577,"html_url":"https://github.com/apache/cloudstack/pull/816","diff_url":"https://github.com/apache/cloudstack/pull/816.diff","patch_url":"https://github.com/apache/cloudstack/pull/816.patch","issue_url":"https://api.github.com/repos/apache/cloudstack/issues/816","number":816,"state":"open","locked":false,"title":"Notify listeners when a host has been added to a cluster, is about to…","user":{"login":"mike-tutkowski","id":3019295,"avatar_url":"https://avatars.githubusercontent.com/u/3019295?v=3","gravatar_id":"","url":"https://api.github.com/users/mike-tutkowski","html_url":"https://github.com/mike-tutkowski","followers_url":"https://api.github.com/users/mike-tutkowski/followers","following_url":"https://api.github.com/users/mike-tutkowski/following{/other_user}","gists_url":"https://api.github.com/users/mike-tutkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/mike-tutkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike-tutkowski/subscriptions","organizations_url":"https://api.github.com/users/mike-tutkowski/orgs","repos_url":"https://api.github.com/users/mike-tutkowski/repos","events_url":"https://api.github.com/users/mike-tutkowski/events{/privacy}","received_events_url":"https://api.github.com/users/mike-tutkowski/received_events","type":"User","site_admin":false},"body":"… be removed from a cluster, or has been removed from a cluster\r\n\r\nThis PR addresses the following JIRA ticket:\r\n\r\nhttps://issues.apache.org/jira/browse/CLOUDSTACK-8813\r\n\r\nThe problem is that there needs to be notifications sent when a host is added to, about to be removed from, and removed from a cluster.\r\n\r\nSuch notifications can be used for many purposes. For example, it can allow storage plug-ins to update ACLs on their storage systems. Also, it can allow us to clean up IQNs from ESXi hosts that are no longer needed.","created_at":"2015-09-14T06:46:49Z","updated_at":"2015-09-14T13:07:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"979440cf4ee7a6121e3db3688a842339cc3f6467","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/cloudstack/pulls/816/commits","review_comments_url":"https://api.github.com/repos/apache/cloudstack/pulls/816/comments","review_comment_url":"https://api.github.com/repos/apache/cloudstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/cloudstack/issues/816/comments","statuses_url":"https://api.github.com/repos/apache/cloudstack/statuses/088eb45fcd1618624b72af3c3eba0b19acb77aac","head":{"label":"mike-tutkowski:addremovehosts2","ref":"addremovehosts2","sha":"088eb45fcd1618624b72af3c3eba0b19acb77aac","user":{"login":"mike-tutkowski","id":3019295,"avatar_url":"https://avatars.githubusercontent.com/u/3019295?v=3","gravatar_id":"","url":"https://api.github.com/users/mike-tutkowski","html_url":"https://github.com/mike-tutkowski","followers_url":"https://api.github.com/users/mike-tutkowski/followers","following_url":"https://api.github.com/users/mike-tutkowski/following{/other_user}","gists_url":"https://api.github.com/users/mike-tutkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/mike-tutkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike-tutkowski/subscriptions","organizations_url":"https://api.github.com/users/mike-tutkowski/orgs","repos_url":"https://api.github.com/users/mike-tutkowski/repos","events_url":"https://api.github.com/users/mike-tutkowski/events{/privacy}","received_events_url":"https://api.github.com/users/mike-tutkowski/received_events","type":"User","site_admin":false},"repo":{"id":15264574,"name":"cloudstack","full_name":"mike-tutkowski/cloudstack","owner":{"login":"mike-tutkowski","id":3019295,"avatar_url":"https://avatars.githubusercontent.com/u/3019295?v=3","gravatar_id":"","url":"https://api.github.com/users/mike-tutkowski","html_url":"https://github.com/mike-tutkowski","followers_url":"https://api.github.com/users/mike-tutkowski/followers","following_url":"https://api.github.com/users/mike-tutkowski/following{/other_user}","gists_url":"https://api.github.com/users/mike-tutkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/mike-tutkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike-tutkowski/subscriptions","organizations_url":"https://api.github.com/users/mike-tutkowski/orgs","repos_url":"https://api.github.com/users/mike-tutkowski/repos","events_url":"https://api.github.com/users/mike-tutkowski/events{/privacy}","received_events_url":"https://api.github.com/users/mike-tutkowski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mike-tutkowski/cloudstack","description":"Mirror of Apache Cloudstack","fork":true,"url":"https://api.github.com/repos/mike-tutkowski/cloudstack","forks_url":"https://api.github.com/repos/mike-tutkowski/cloudstack/forks","keys_url":"https://api.github.com/repos/mike-tutkowski/cloudstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mike-tutkowski/cloudstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mike-tutkowski/cloudstack/teams","hooks_url":"https://api.github.com/repos/mike-tutkowski/cloudstack/hooks","issue_events_url":"https://api.github.com/repos/mike-tutkowski/cloudstack/issues/events{/number}","events_url":"https://api.github.com/repos/mike-tutkowski/cloudstack/events","assignees_url":"https://api.github.com/repos/mike-tutkowski/cloudstack/assignees{/user}","branches_url":"https://api.github.com/repos/mike-tutkowski/cloudstack/branches{/branch}","tags_url":"https://api.github.com/repos/mike-tutkowski/cloudstack/tags","blobs_url":"https://api.github.com/repos/mike-tutkowski/cloudstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mike-tutkowski/cloudstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mike-tutkowski/cloudstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/mike-tutkowski/cloudstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mike-tutkowski/cloudstack/statuses/{sha}","languages_url":"https://api.github.com/repos/mike-tutkowski/cloudstack/languages","stargazers_url":"https://api.github.com/repos/mike-tutkowski/cloudstack/stargazers","contributors_url":"https://api.github.com/repos/mike-tutkowski/cloudstack/contributors","subscribers_url":"https://api.github.com/repos/mike-tutkowski/cloudstack/subscribers","subscription_url":"https://api.github.com/repos/mike-tutkowski/cloudstack/subscription","commits_url":"https://api.github.com/repos/mike-tutkowski/cloudstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/mike-tutkowski/cloudstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/mike-tutkowski/cloudstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/mike-tutkowski/cloudstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/mike-tutkowski/cloudstack/contents/{+path}","compare_url":"https://api.github.com/repos/mike-tutkowski/cloudstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mike-tutkowski/cloudstack/merges","archive_url":"https://api.github.com/repos/mike-tutkowski/cloudstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mike-tutkowski/cloudstack/downloads","issues_url":"https://api.github.com/repos/mike-tutkowski/cloudstack/issues{/number}","pulls_url":"https://api.github.com/repos/mike-tutkowski/cloudstack/pulls{/number}","milestones_url":"https://api.github.com/repos/mike-tutkowski/cloudstack/milestones{/number}","notifications_url":"https://api.github.com/repos/mike-tutkowski/cloudstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mike-tutkowski/cloudstack/labels{/name}","releases_url":"https://api.github.com/repos/mike-tutkowski/cloudstack/releases{/id}","created_at":"2013-12-17T20:02:36Z","updated_at":"2015-05-02T04:30:32Z","pushed_at":"2015-09-14T06:42:47Z","git_url":"git://github.com/mike-tutkowski/cloudstack.git","ssh_url":"git@github.com:mike-tutkowski/cloudstack.git","clone_url":"https://github.com/mike-tutkowski/cloudstack.git","svn_url":"https://github.com/mike-tutkowski/cloudstack","homepage":null,"size":463408,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"0b73d193684723fca2b936625f3df3dee60de273","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":9759448,"name":"cloudstack","full_name":"apache/cloudstack","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/cloudstack","description":"Mirror of Apache Cloudstack","fork":false,"url":"https://api.github.com/repos/apache/cloudstack","forks_url":"https://api.github.com/repos/apache/cloudstack/forks","keys_url":"https://api.github.com/repos/apache/cloudstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/cloudstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/cloudstack/teams","hooks_url":"https://api.github.com/repos/apache/cloudstack/hooks","issue_events_url":"https://api.github.com/repos/apache/cloudstack/issues/events{/number}","events_url":"https://api.github.com/repos/apache/cloudstack/events","assignees_url":"https://api.github.com/repos/apache/cloudstack/assignees{/user}","branches_url":"https://api.github.com/repos/apache/cloudstack/branches{/branch}","tags_url":"https://api.github.com/repos/apache/cloudstack/tags","blobs_url":"https://api.github.com/repos/apache/cloudstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/cloudstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/cloudstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/cloudstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/cloudstack/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/cloudstack/languages","stargazers_url":"https://api.github.com/repos/apache/cloudstack/stargazers","contributors_url":"https://api.github.com/repos/apache/cloudstack/contributors","subscribers_url":"https://api.github.com/repos/apache/cloudstack/subscribers","subscription_url":"https://api.github.com/repos/apache/cloudstack/subscription","commits_url":"https://api.github.com/repos/apache/cloudstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/cloudstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/cloudstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/cloudstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/cloudstack/contents/{+path}","compare_url":"https://api.github.com/repos/apache/cloudstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/cloudstack/merges","archive_url":"https://api.github.com/repos/apache/cloudstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/cloudstack/downloads","issues_url":"https://api.github.com/repos/apache/cloudstack/issues{/number}","pulls_url":"https://api.github.com/repos/apache/cloudstack/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/cloudstack/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/cloudstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/cloudstack/labels{/name}","releases_url":"https://api.github.com/repos/apache/cloudstack/releases{/id}","created_at":"2013-04-29T22:27:12Z","updated_at":"2015-09-12T23:24:20Z","pushed_at":"2015-09-14T12:28:12Z","git_url":"git://github.com/apache/cloudstack.git","ssh_url":"git@github.com:apache/cloudstack.git","clone_url":"https://github.com/apache/cloudstack.git","svn_url":"https://github.com/apache/cloudstack","homepage":null,"size":757001,"stargazers_count":284,"watchers_count":284,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":370,"mirror_url":"git://git.apache.org/cloudstack.git","open_issues_count":49,"forks":370,"open_issues":49,"watchers":284,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/816"},"html":{"href":"https://github.com/apache/cloudstack/pull/816"},"issue":{"href":"https://api.github.com/repos/apache/cloudstack/issues/816"},"comments":{"href":"https://api.github.com/repos/apache/cloudstack/issues/816/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/816/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/816/commits"},"statuses":{"href":"https://api.github.com/repos/apache/cloudstack/statuses/088eb45fcd1618624b72af3c3eba0b19acb77aac"}}}}