{"action":"opened","number":1442,"pull_request":{"url":"https://api.github.com/repos/collectd/collectd/pulls/1442","id":52781212,"html_url":"https://github.com/collectd/collectd/pull/1442","diff_url":"https://github.com/collectd/collectd/pull/1442.diff","patch_url":"https://github.com/collectd/collectd/pull/1442.patch","issue_url":"https://api.github.com/repos/collectd/collectd/issues/1442","number":1442,"state":"open","locked":false,"title":"Fix make check on OmniOS","user":{"login":"rubenk","id":47338,"avatar_url":"https://avatars.githubusercontent.com/u/47338?v=3","gravatar_id":"","url":"https://api.github.com/users/rubenk","html_url":"https://github.com/rubenk","followers_url":"https://api.github.com/users/rubenk/followers","following_url":"https://api.github.com/users/rubenk/following{/other_user}","gists_url":"https://api.github.com/users/rubenk/gists{/gist_id}","starred_url":"https://api.github.com/users/rubenk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubenk/subscriptions","organizations_url":"https://api.github.com/users/rubenk/orgs","repos_url":"https://api.github.com/users/rubenk/repos","events_url":"https://api.github.com/users/rubenk/events{/privacy}","received_events_url":"https://api.github.com/users/rubenk/received_events","type":"User","site_admin":false},"body":"We need the defines from config.h before\r\nwe include <testing.h>, or we get the following error on OmniOS:\r\n\r\nmake  test_common test_meta_data  test_utils_avltree test_utils_heap  test_utils_time test_utils_subst\r\ngcc -DHAVE_CONFIG_H -I. -I../../src  -I../../src -DPREFIX='\"/opt/collectd\"'  -DCONFIGFILE='\"/opt/collectd/etc/collectd.conf\"'  -DLOCALSTATEDIR='\"/opt/collectd/var\"'  -DPKGLOCALSTATEDIR='\"/opt/collectd/var/lib/collectd\"'  -DPIDFILE='\"/opt/collectd/var/run/collectd.pid\"' -DPLUGINDIR='\"/opt/collectd/lib/collectd\"'  -DPKGDATADIR='\"/opt/collectd/share/collectd\"'   -Wall -Werror -g -O2 -c -o common_test.o common_test.c\r\nIn file included from collectd.h:31:0,\r\n                 from common.h:31,\r\n                 from common_test.c:28:\r\n../../src/config.h:1631:0: error: \"_FILE_OFFSET_BITS\" redefined [-Werror]\r\n #define _FILE_OFFSET_BITS 64\r\n ^\r\nIn file included from /usr/include/inttypes.h:41:0,\r\n                 from ../../src/testing.h:30,\r\n                 from common_test.c:27:\r\n/opt/gcc-5.1.0/lib/gcc/i386-pc-solaris2.11/5.1.0/include-fixed/sys/feature_tests.h:231:0: note: this is the location of the previous definition\r\n #define _FILE_OFFSET_BITS 32\r\n ^\r\ncc1: all warnings being treated as errors\r\n*** Error code 1\r\nmake: Fatal error: Command failed for target `common_test.o'","created_at":"2015-12-06T14:32:02Z","updated_at":"2015-12-06T14:32:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/collectd/collectd/pulls/1442/commits","review_comments_url":"https://api.github.com/repos/collectd/collectd/pulls/1442/comments","review_comment_url":"https://api.github.com/repos/collectd/collectd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/collectd/collectd/issues/1442/comments","statuses_url":"https://api.github.com/repos/collectd/collectd/statuses/59ade6a1f9b5ba13a3a6a6a78102957c78835bd5","head":{"label":"rubenk:omnios-fix-make-check","ref":"omnios-fix-make-check","sha":"59ade6a1f9b5ba13a3a6a6a78102957c78835bd5","user":{"login":"rubenk","id":47338,"avatar_url":"https://avatars.githubusercontent.com/u/47338?v=3","gravatar_id":"","url":"https://api.github.com/users/rubenk","html_url":"https://github.com/rubenk","followers_url":"https://api.github.com/users/rubenk/followers","following_url":"https://api.github.com/users/rubenk/following{/other_user}","gists_url":"https://api.github.com/users/rubenk/gists{/gist_id}","starred_url":"https://api.github.com/users/rubenk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubenk/subscriptions","organizations_url":"https://api.github.com/users/rubenk/orgs","repos_url":"https://api.github.com/users/rubenk/repos","events_url":"https://api.github.com/users/rubenk/events{/privacy}","received_events_url":"https://api.github.com/users/rubenk/received_events","type":"User","site_admin":false},"repo":{"id":693859,"name":"collectd","full_name":"rubenk/collectd","owner":{"login":"rubenk","id":47338,"avatar_url":"https://avatars.githubusercontent.com/u/47338?v=3","gravatar_id":"","url":"https://api.github.com/users/rubenk","html_url":"https://github.com/rubenk","followers_url":"https://api.github.com/users/rubenk/followers","following_url":"https://api.github.com/users/rubenk/following{/other_user}","gists_url":"https://api.github.com/users/rubenk/gists{/gist_id}","starred_url":"https://api.github.com/users/rubenk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubenk/subscriptions","organizations_url":"https://api.github.com/users/rubenk/orgs","repos_url":"https://api.github.com/users/rubenk/repos","events_url":"https://api.github.com/users/rubenk/events{/privacy}","received_events_url":"https://api.github.com/users/rubenk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rubenk/collectd","description":"Mirror of the official repository.","fork":true,"url":"https://api.github.com/repos/rubenk/collectd","forks_url":"https://api.github.com/repos/rubenk/collectd/forks","keys_url":"https://api.github.com/repos/rubenk/collectd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubenk/collectd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubenk/collectd/teams","hooks_url":"https://api.github.com/repos/rubenk/collectd/hooks","issue_events_url":"https://api.github.com/repos/rubenk/collectd/issues/events{/number}","events_url":"https://api.github.com/repos/rubenk/collectd/events","assignees_url":"https://api.github.com/repos/rubenk/collectd/assignees{/user}","branches_url":"https://api.github.com/repos/rubenk/collectd/branches{/branch}","tags_url":"https://api.github.com/repos/rubenk/collectd/tags","blobs_url":"https://api.github.com/repos/rubenk/collectd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubenk/collectd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubenk/collectd/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubenk/collectd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubenk/collectd/statuses/{sha}","languages_url":"https://api.github.com/repos/rubenk/collectd/languages","stargazers_url":"https://api.github.com/repos/rubenk/collectd/stargazers","contributors_url":"https://api.github.com/repos/rubenk/collectd/contributors","subscribers_url":"https://api.github.com/repos/rubenk/collectd/subscribers","subscription_url":"https://api.github.com/repos/rubenk/collectd/subscription","commits_url":"https://api.github.com/repos/rubenk/collectd/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubenk/collectd/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubenk/collectd/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubenk/collectd/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubenk/collectd/contents/{+path}","compare_url":"https://api.github.com/repos/rubenk/collectd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubenk/collectd/merges","archive_url":"https://api.github.com/repos/rubenk/collectd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubenk/collectd/downloads","issues_url":"https://api.github.com/repos/rubenk/collectd/issues{/number}","pulls_url":"https://api.github.com/repos/rubenk/collectd/pulls{/number}","milestones_url":"https://api.github.com/repos/rubenk/collectd/milestones{/number}","notifications_url":"https://api.github.com/repos/rubenk/collectd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubenk/collectd/labels{/name}","releases_url":"https://api.github.com/repos/rubenk/collectd/releases{/id}","created_at":"2010-05-30T11:53:05Z","updated_at":"2015-11-27T16:02:21Z","pushed_at":"2015-12-06T14:31:18Z","git_url":"git://github.com/rubenk/collectd.git","ssh_url":"git@github.com:rubenk/collectd.git","clone_url":"https://github.com/rubenk/collectd.git","svn_url":"https://github.com/rubenk/collectd","homepage":"https://collectd.org/","size":12485,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"collectd:master","ref":"master","sha":"090e054043f6d93b374dee20d766c4f906acd43a","user":{"login":"collectd","id":1027481,"avatar_url":"https://avatars.githubusercontent.com/u/1027481?v=3","gravatar_id":"","url":"https://api.github.com/users/collectd","html_url":"https://github.com/collectd","followers_url":"https://api.github.com/users/collectd/followers","following_url":"https://api.github.com/users/collectd/following{/other_user}","gists_url":"https://api.github.com/users/collectd/gists{/gist_id}","starred_url":"https://api.github.com/users/collectd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/collectd/subscriptions","organizations_url":"https://api.github.com/users/collectd/orgs","repos_url":"https://api.github.com/users/collectd/repos","events_url":"https://api.github.com/users/collectd/events{/privacy}","received_events_url":"https://api.github.com/users/collectd/received_events","type":"Organization","site_admin":false},"repo":{"id":3208640,"name":"collectd","full_name":"collectd/collectd","owner":{"login":"collectd","id":1027481,"avatar_url":"https://avatars.githubusercontent.com/u/1027481?v=3","gravatar_id":"","url":"https://api.github.com/users/collectd","html_url":"https://github.com/collectd","followers_url":"https://api.github.com/users/collectd/followers","following_url":"https://api.github.com/users/collectd/following{/other_user}","gists_url":"https://api.github.com/users/collectd/gists{/gist_id}","starred_url":"https://api.github.com/users/collectd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/collectd/subscriptions","organizations_url":"https://api.github.com/users/collectd/orgs","repos_url":"https://api.github.com/users/collectd/repos","events_url":"https://api.github.com/users/collectd/events{/privacy}","received_events_url":"https://api.github.com/users/collectd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/collectd/collectd","description":"The system statistics collection daemon. Mirror of the canonical repository (updated automatically). Please send Pull Requests here!","fork":false,"url":"https://api.github.com/repos/collectd/collectd","forks_url":"https://api.github.com/repos/collectd/collectd/forks","keys_url":"https://api.github.com/repos/collectd/collectd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/collectd/collectd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/collectd/collectd/teams","hooks_url":"https://api.github.com/repos/collectd/collectd/hooks","issue_events_url":"https://api.github.com/repos/collectd/collectd/issues/events{/number}","events_url":"https://api.github.com/repos/collectd/collectd/events","assignees_url":"https://api.github.com/repos/collectd/collectd/assignees{/user}","branches_url":"https://api.github.com/repos/collectd/collectd/branches{/branch}","tags_url":"https://api.github.com/repos/collectd/collectd/tags","blobs_url":"https://api.github.com/repos/collectd/collectd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/collectd/collectd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/collectd/collectd/git/refs{/sha}","trees_url":"https://api.github.com/repos/collectd/collectd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/collectd/collectd/statuses/{sha}","languages_url":"https://api.github.com/repos/collectd/collectd/languages","stargazers_url":"https://api.github.com/repos/collectd/collectd/stargazers","contributors_url":"https://api.github.com/repos/collectd/collectd/contributors","subscribers_url":"https://api.github.com/repos/collectd/collectd/subscribers","subscription_url":"https://api.github.com/repos/collectd/collectd/subscription","commits_url":"https://api.github.com/repos/collectd/collectd/commits{/sha}","git_commits_url":"https://api.github.com/repos/collectd/collectd/git/commits{/sha}","comments_url":"https://api.github.com/repos/collectd/collectd/comments{/number}","issue_comment_url":"https://api.github.com/repos/collectd/collectd/issues/comments{/number}","contents_url":"https://api.github.com/repos/collectd/collectd/contents/{+path}","compare_url":"https://api.github.com/repos/collectd/collectd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/collectd/collectd/merges","archive_url":"https://api.github.com/repos/collectd/collectd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/collectd/collectd/downloads","issues_url":"https://api.github.com/repos/collectd/collectd/issues{/number}","pulls_url":"https://api.github.com/repos/collectd/collectd/pulls{/number}","milestones_url":"https://api.github.com/repos/collectd/collectd/milestones{/number}","notifications_url":"https://api.github.com/repos/collectd/collectd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/collectd/collectd/labels{/name}","releases_url":"https://api.github.com/repos/collectd/collectd/releases{/id}","created_at":"2012-01-18T13:07:51Z","updated_at":"2015-12-05T15:18:16Z","pushed_at":"2015-12-06T14:32:02Z","git_url":"git://github.com/collectd/collectd.git","ssh_url":"git@github.com:collectd/collectd.git","clone_url":"https://github.com/collectd/collectd.git","svn_url":"https://github.com/collectd/collectd","homepage":"http://collectd.org/","size":23560,"stargazers_count":933,"watchers_count":933,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":592,"mirror_url":null,"open_issues_count":332,"forks":592,"open_issues":332,"watchers":933,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/collectd/collectd/pulls/1442"},"html":{"href":"https://github.com/collectd/collectd/pull/1442"},"issue":{"href":"https://api.github.com/repos/collectd/collectd/issues/1442"},"comments":{"href":"https://api.github.com/repos/collectd/collectd/issues/1442/comments"},"review_comments":{"href":"https://api.github.com/repos/collectd/collectd/pulls/1442/comments"},"review_comment":{"href":"https://api.github.com/repos/collectd/collectd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/collectd/collectd/pulls/1442/commits"},"statuses":{"href":"https://api.github.com/repos/collectd/collectd/statuses/59ade6a1f9b5ba13a3a6a6a78102957c78835bd5"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":9,"deletions":9,"changed_files":6}}