{"action":"created","issue":{"url":"https://api.github.com/repos/jspm/jspm-cli/issues/554","labels_url":"https://api.github.com/repos/jspm/jspm-cli/issues/554/labels{/name}","comments_url":"https://api.github.com/repos/jspm/jspm-cli/issues/554/comments","events_url":"https://api.github.com/repos/jspm/jspm-cli/issues/554/events","html_url":"https://github.com/jspm/jspm-cli/pull/554","id":59335568,"number":554,"title":"added jshint linter and editorconfig","user":{"login":"subesokun","id":6920421,"avatar_url":"https://avatars.githubusercontent.com/u/6920421?v=3","gravatar_id":"","url":"https://api.github.com/users/subesokun","html_url":"https://github.com/subesokun","followers_url":"https://api.github.com/users/subesokun/followers","following_url":"https://api.github.com/users/subesokun/following{/other_user}","gists_url":"https://api.github.com/users/subesokun/gists{/gist_id}","starred_url":"https://api.github.com/users/subesokun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/subesokun/subscriptions","organizations_url":"https://api.github.com/users/subesokun/orgs","repos_url":"https://api.github.com/users/subesokun/repos","events_url":"https://api.github.com/users/subesokun/events{/privacy}","received_events_url":"https://api.github.com/users/subesokun/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-02-28T09:58:51Z","updated_at":"2015-03-05T09:56:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jspm/jspm-cli/pulls/554","html_url":"https://github.com/jspm/jspm-cli/pull/554","diff_url":"https://github.com/jspm/jspm-cli/pull/554.diff","patch_url":"https://github.com/jspm/jspm-cli/pull/554.patch"},"body":"- Added jshint linter to `npm test`\r\n- Added editorconfig\r\n- Minor code refactoring as discussed in https://github.com/jspm/jspm-cli/commit/3d3fb0b47c6f8850c6cad3834e274cc2a51364a9#commitcomment-9734519\r\n \r\nSo far everything works as expected and I hope that I didn't introduce due to the many changes some unwanted bugs. Most of the linter warnings have been of type `==` vs `===` or missing `;` at the end of the lines. The diff shows also many modified lines due to trimming of trailing whitespaces.\r\n\r\nFuthermore I'd recommend to active `qurly` so that each block or scope requires `{}` to avoid easy to overlook typos like:\r\n\r\n```javascript\r\nif (Error)\r\n  console.log('Error');\r\nreturn Error;\r\n// If no error continue here ...\r\n```\r\n\r\nTo avoid annoying build errors after pusing your code to the upstream because of some linter errors there are helpfull plugins/packages for Sublime and Atom to give you direct feedback while typing. It has only very little impact on the performance of the Editor so I'm always using it. For Atom I've installed `linter`and `linter-jshint`. Also I've installed the `editorconfig`package. \r\n\r\nAs next step I wanted to test also [ESLint](http://eslint.org/) once as it uses an AST for linting which gives better results compared to JSHint which analyzes line for line though ESLint is x2-x3 times slower."},"comment":{"url":"https://api.github.com/repos/jspm/jspm-cli/issues/comments/77336317","html_url":"https://github.com/jspm/jspm-cli/pull/554#issuecomment-77336317","issue_url":"https://api.github.com/repos/jspm/jspm-cli/issues/554","id":77336317,"user":{"login":"floatdrop","id":365089,"avatar_url":"https://avatars.githubusercontent.com/u/365089?v=3","gravatar_id":"","url":"https://api.github.com/users/floatdrop","html_url":"https://github.com/floatdrop","followers_url":"https://api.github.com/users/floatdrop/followers","following_url":"https://api.github.com/users/floatdrop/following{/other_user}","gists_url":"https://api.github.com/users/floatdrop/gists{/gist_id}","starred_url":"https://api.github.com/users/floatdrop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floatdrop/subscriptions","organizations_url":"https://api.github.com/users/floatdrop/orgs","repos_url":"https://api.github.com/users/floatdrop/repos","events_url":"https://api.github.com/users/floatdrop/events{/privacy}","received_events_url":"https://api.github.com/users/floatdrop/received_events","type":"User","site_admin":false},"created_at":"2015-03-05T09:56:25Z","updated_at":"2015-03-05T09:56:25Z","body":"@subesokun bump. Any news on this?"}}