{"action":"created","issue":{"url":"https://api.github.com/repos/onsip/SIP.js/issues/207","labels_url":"https://api.github.com/repos/onsip/SIP.js/issues/207/labels{/name}","comments_url":"https://api.github.com/repos/onsip/SIP.js/issues/207/comments","events_url":"https://api.github.com/repos/onsip/SIP.js/issues/207/events","html_url":"https://github.com/onsip/SIP.js/pull/207","id":100854596,"number":207,"title":"Allow setting additional Supported option tags","user":{"login":"markandrus","id":359154,"avatar_url":"https://avatars.githubusercontent.com/u/359154?v=3","gravatar_id":"","url":"https://api.github.com/users/markandrus","html_url":"https://github.com/markandrus","followers_url":"https://api.github.com/users/markandrus/followers","following_url":"https://api.github.com/users/markandrus/following{/other_user}","gists_url":"https://api.github.com/users/markandrus/gists{/gist_id}","starred_url":"https://api.github.com/users/markandrus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markandrus/subscriptions","organizations_url":"https://api.github.com/users/markandrus/orgs","repos_url":"https://api.github.com/users/markandrus/repos","events_url":"https://api.github.com/users/markandrus/events{/privacy}","received_events_url":"https://api.github.com/users/markandrus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-08-13T19:54:45Z","updated_at":"2015-08-14T20:18:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/onsip/SIP.js/pulls/207","html_url":"https://github.com/onsip/SIP.js/pull/207","diff_url":"https://github.com/onsip/SIP.js/pull/207.diff","patch_url":"https://github.com/onsip/SIP.js/pull/207.patch"},"body":"It would be nice to be able to add Supported option tags in addition to those already set by SIP.js. This PR adds a new configuration option, `supported`, taking an array of option tags to append to the Supported header.\r\n\r\nOpen questions:\r\n- This is as simple as possible—just concat the Arrays—but it also means that you could duplicate option tags, including those that SIP.js already sets (path, gruu, 100rel, replaces, outbound). Is this something that should be protected against (e.g., by using a Set)?\r\n- The name `supported` might suggest the configuration option overwrites all the option tags that _would be_ set in the Supported header. Would it be more appropriate to name it, e.g., `extraSupportedOptionTags`?"},"comment":{"url":"https://api.github.com/repos/onsip/SIP.js/issues/comments/131229181","html_url":"https://github.com/onsip/SIP.js/pull/207#issuecomment-131229181","issue_url":"https://api.github.com/repos/onsip/SIP.js/issues/207","id":131229181,"user":{"login":"wakamoleguy","id":3210372,"avatar_url":"https://avatars.githubusercontent.com/u/3210372?v=3","gravatar_id":"","url":"https://api.github.com/users/wakamoleguy","html_url":"https://github.com/wakamoleguy","followers_url":"https://api.github.com/users/wakamoleguy/followers","following_url":"https://api.github.com/users/wakamoleguy/following{/other_user}","gists_url":"https://api.github.com/users/wakamoleguy/gists{/gist_id}","starred_url":"https://api.github.com/users/wakamoleguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wakamoleguy/subscriptions","organizations_url":"https://api.github.com/users/wakamoleguy/orgs","repos_url":"https://api.github.com/users/wakamoleguy/repos","events_url":"https://api.github.com/users/wakamoleguy/events{/privacy}","received_events_url":"https://api.github.com/users/wakamoleguy/received_events","type":"User","site_admin":false},"created_at":"2015-08-14T20:18:17Z","updated_at":"2015-08-14T20:18:17Z","body":"Hmm.  I may come around eventually, but I would definitely accept James's idea of restricting it to just RFC defined options.  We could validate them when passed in, and if we *really* wanted to, we could have a flag to disable the check (probably prefixed with `hack`).\r\n\r\nThe list of standard option tags is tracked by IANA: http://www.iana.org/assignments/sip-parameters/sip-parameters.xhtml#sip-parameters-4\r\n\r\nIn other news, I agree that `extraSupported` sounds good, because it matches `extraHeaders`.  Speaking of which, why not use a custom header for custom behavior? :-)"}}