{"action":"created","issue":{"url":"https://api.github.com/repos/poisa/JVIntelHex/issues/1","labels_url":"https://api.github.com/repos/poisa/JVIntelHex/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/poisa/JVIntelHex/issues/1/comments","events_url":"https://api.github.com/repos/poisa/JVIntelHex/issues/1/events","html_url":"https://github.com/poisa/JVIntelHex/pull/1","id":59277224,"number":1,"title":"fix checksum issue","user":{"login":"durkie","id":3200608,"avatar_url":"https://avatars.githubusercontent.com/u/3200608?v=3","gravatar_id":"","url":"https://api.github.com/users/durkie","html_url":"https://github.com/durkie","followers_url":"https://api.github.com/users/durkie/followers","following_url":"https://api.github.com/users/durkie/following{/other_user}","gists_url":"https://api.github.com/users/durkie/gists{/gist_id}","starred_url":"https://api.github.com/users/durkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/durkie/subscriptions","organizations_url":"https://api.github.com/users/durkie/orgs","repos_url":"https://api.github.com/users/durkie/repos","events_url":"https://api.github.com/users/durkie/events{/privacy}","received_events_url":"https://api.github.com/users/durkie/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-02-27T18:46:27Z","updated_at":"2015-02-27T22:11:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/poisa/JVIntelHex/pulls/1","html_url":"https://github.com/poisa/JVIntelHex/pull/1","diff_url":"https://github.com/poisa/JVIntelHex/pull/1.diff","patch_url":"https://github.com/poisa/JVIntelHex/pull/1.patch"},"body":"okay, so I know this is super old, but this code works well and just has one issue.\r\n\r\nthe entire address was being added to sum for checksum calculation, rather than each byte individually: i.e., address 0x1000 should add 16 to the sum (0x10 + 0x00), just like address 0x0010 (0x00 + 0x10)"},"comment":{"url":"https://api.github.com/repos/poisa/JVIntelHex/issues/comments/76482060","html_url":"https://github.com/poisa/JVIntelHex/pull/1#issuecomment-76482060","issue_url":"https://api.github.com/repos/poisa/JVIntelHex/issues/1","id":76482060,"user":{"login":"poisa","id":348248,"avatar_url":"https://avatars.githubusercontent.com/u/348248?v=3","gravatar_id":"","url":"https://api.github.com/users/poisa","html_url":"https://github.com/poisa","followers_url":"https://api.github.com/users/poisa/followers","following_url":"https://api.github.com/users/poisa/following{/other_user}","gists_url":"https://api.github.com/users/poisa/gists{/gist_id}","starred_url":"https://api.github.com/users/poisa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poisa/subscriptions","organizations_url":"https://api.github.com/users/poisa/orgs","repos_url":"https://api.github.com/users/poisa/repos","events_url":"https://api.github.com/users/poisa/events{/privacy}","received_events_url":"https://api.github.com/users/poisa/received_events","type":"User","site_admin":false},"created_at":"2015-02-27T22:11:31Z","updated_at":"2015-02-27T22:11:31Z","body":"Hey, that's great! Thanks for contributing. Let me make one suggestion before merging this in. \r\nCould you remove the last line please?\r\n```javascript\r\n+exports.JVIntelHEX = JVIntelHEX;\r\n```\r\nThis is Node.js only code and will throw an error in the included example. "}}