{"action":"created","issue":{"url":"https://api.github.com/repos/toranb/ember-cli-simple-store/issues/9","labels_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/issues/9/comments","events_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/issues/9/events","html_url":"https://github.com/toranb/ember-cli-simple-store/pull/9","id":68545116,"number":9,"title":"[DEPRECATION]: adding a deprecation for store.push without data.id","user":{"login":"williamsbdev","id":2402655,"avatar_url":"https://avatars.githubusercontent.com/u/2402655?v=3","gravatar_id":"","url":"https://api.github.com/users/williamsbdev","html_url":"https://github.com/williamsbdev","followers_url":"https://api.github.com/users/williamsbdev/followers","following_url":"https://api.github.com/users/williamsbdev/following{/other_user}","gists_url":"https://api.github.com/users/williamsbdev/gists{/gist_id}","starred_url":"https://api.github.com/users/williamsbdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williamsbdev/subscriptions","organizations_url":"https://api.github.com/users/williamsbdev/orgs","repos_url":"https://api.github.com/users/williamsbdev/repos","events_url":"https://api.github.com/users/williamsbdev/events{/privacy}","received_events_url":"https://api.github.com/users/williamsbdev/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-15T01:36:39Z","updated_at":"2015-04-17T04:21:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/toranb/ember-cli-simple-store/pulls/9","html_url":"https://github.com/toranb/ember-cli-simple-store/pull/9","diff_url":"https://github.com/toranb/ember-cli-simple-store/pull/9.diff","patch_url":"https://github.com/toranb/ember-cli-simple-store/pull/9.patch"},"body":"Prior to merging this in, I have an [issue](https://github.com/ember-cli/ember-cli/issues/3905) open with ember-cli to learn the best practices for deprecating something in an addon and how to test it. I've used the API that Ember uses for deprecations but I'm not sure this is the best way to do it. I'd also like to know how/if this is testable."},"comment":{"url":"https://api.github.com/repos/toranb/ember-cli-simple-store/issues/comments/93890618","html_url":"https://github.com/toranb/ember-cli-simple-store/pull/9#issuecomment-93890618","issue_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/issues/9","id":93890618,"user":{"login":"toranb","id":147411,"avatar_url":"https://avatars.githubusercontent.com/u/147411?v=3","gravatar_id":"","url":"https://api.github.com/users/toranb","html_url":"https://github.com/toranb","followers_url":"https://api.github.com/users/toranb/followers","following_url":"https://api.github.com/users/toranb/following{/other_user}","gists_url":"https://api.github.com/users/toranb/gists{/gist_id}","starred_url":"https://api.github.com/users/toranb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toranb/subscriptions","organizations_url":"https://api.github.com/users/toranb/orgs","repos_url":"https://api.github.com/users/toranb/repos","events_url":"https://api.github.com/users/toranb/events{/privacy}","received_events_url":"https://api.github.com/users/toranb/received_events","type":"User","site_admin":false},"created_at":"2015-04-17T04:21:49Z","updated_at":"2015-04-17T04:21:49Z","body":"@williamsbdev I think we might hold off on this for the moment. I wanted to give it a little more thought before making a true deprecation like this\r\n\r\nOne scenario I'm thinking of \r\n\r\n```\r\n1) user model is across 5 views\r\n2) first page I return a new model instead of pushing into the store\r\n3) second page - a peer to the first (not nested) needs to get the model previously pushed ... but we don't have it in the store so we can't easily grab it :(\r\n```\r\n\r\nThis offers up some other \"how-to\"\r\n\r\n1) why not just push an id into that step 2 above -then when the xhr finishes you can simply do a setProperties on it to \"update the id value\"\r\n\r\nNot terrible but might cause a possible conflict if 2 ids collide for whatever reason (unlikely but possible).\r\n\r\n2) rewrite the routes or do an inject to \"require\" in the peer model "}}