{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/27142664","id":27142664,"diff_hunk":"@@ -478,6 +478,35 @@ public class InlineConstraintTests\n             Assert.Equal(HttpStatusCode.NotFound, response.StatusCode);\n         }\n \n+        [Theory]\n+        // Testing custom inline constraint configured via MapRoute\n+        [InlineData(\"software\", HttpStatusCode.OK, \"software From Software Controller Index\")]\n+        // Testing custom inline constraint updated in ConstraintMap\n+        [InlineData(\"hardware\", HttpStatusCode.NotFound, null)]\n+        [InlineData(\"HARDWARE\", HttpStatusCode.OK, \"HARDWARE From Hardware Controller Index\")]\n+        // Testing custom inline constraint configured with Attribute Routing\n+        [InlineData(\"consumable\", HttpStatusCode.OK, \"consumable From Consumable Controller Index\")]\n+        public async Task CustomInlineConstraint_Add_Update(\n+            string type,\n+            HttpStatusCode expectedResult,\n+            string expectedBody)\n+        {\n+            // Arrange\n+            var server = TestHelper.CreateServer(_app, SiteName, _configureServices);\n+            var client = server.CreateClient();\n+\n+            // Act\n+            var response = await client.GetAsync(\"http://localhost/producttype/index/\" + type);\n+            var body = await response.Content.ReadAsStringAsync();\n+\n+            // Assert\n+            Assert.Equal(expectedResult, response.StatusCode);\n+            if(expectedResult == HttpStatusCode.OK)","path":"test/Microsoft.AspNet.Mvc.FunctionalTests/InlineConstraintTests.cs","position":27,"original_position":27,"commit_id":"b50dc1450b53f624fcd16ef5c1bb1a130db38cab","original_commit_id":"b50dc1450b53f624fcd16ef5c1bb1a130db38cab","user":{"login":"ianhong","id":2746184,"avatar_url":"https://avatars.githubusercontent.com/u/2746184?v=3","gravatar_id":"","url":"https://api.github.com/users/ianhong","html_url":"https://github.com/ianhong","followers_url":"https://api.github.com/users/ianhong/followers","following_url":"https://api.github.com/users/ianhong/following{/other_user}","gists_url":"https://api.github.com/users/ianhong/gists{/gist_id}","starred_url":"https://api.github.com/users/ianhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianhong/subscriptions","organizations_url":"https://api.github.com/users/ianhong/orgs","repos_url":"https://api.github.com/users/ianhong/repos","events_url":"https://api.github.com/users/ianhong/events{/privacy}","received_events_url":"https://api.github.com/users/ianhong/received_events","type":"User","site_admin":false},"body":"I already had a test data matching the unpdated inline constraint, so 404 is not necessary, but I still addded that to show or test it more explicitly. Let me know if you still don't like this. ","created_at":"2015-03-25T17:10:28Z","updated_at":"2015-03-25T17:10:28Z","html_url":"https://github.com/aspnet/Mvc/pull/2253#discussion_r27142664","pull_request_url":"https://api.github.com/repos/aspnet/Mvc/pulls/2253","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/27142664"},"html":{"href":"https://github.com/aspnet/Mvc/pull/2253#discussion_r27142664"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/2253"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Mvc/pulls/2253","id":31872120,"html_url":"https://github.com/aspnet/Mvc/pull/2253","diff_url":"https://github.com/aspnet/Mvc/pull/2253.diff","patch_url":"https://github.com/aspnet/Mvc/pull/2253.patch","issue_url":"https://api.github.com/repos/aspnet/Mvc/issues/2253","number":2253,"state":"open","locked":false,"title":"Add sample and functional test for custom inline constraints","user":{"login":"ianhong","id":2746184,"avatar_url":"https://avatars.githubusercontent.com/u/2746184?v=3","gravatar_id":"","url":"https://api.github.com/users/ianhong","html_url":"https://github.com/ianhong","followers_url":"https://api.github.com/users/ianhong/followers","following_url":"https://api.github.com/users/ianhong/following{/other_user}","gists_url":"https://api.github.com/users/ianhong/gists{/gist_id}","starred_url":"https://api.github.com/users/ianhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianhong/subscriptions","organizations_url":"https://api.github.com/users/ianhong/orgs","repos_url":"https://api.github.com/users/ianhong/repos","events_url":"https://api.github.com/users/ianhong/events{/privacy}","received_events_url":"https://api.github.com/users/ianhong/received_events","type":"User","site_admin":false},"body":"@harshgMSFT and @rynowak \r\n\r\nI added these tests. Please review them and let me know if you want to see any more tests. \r\n\r\nThanks,\r\n","created_at":"2015-03-24T21:31:13Z","updated_at":"2015-03-25T17:10:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd6e693b3e1712a2deb40c92ba91f2abf8e98237","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Mvc/pulls/2253/commits","review_comments_url":"https://api.github.com/repos/aspnet/Mvc/pulls/2253/comments","review_comment_url":"https://api.github.com/repos/aspnet/Mvc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Mvc/issues/2253/comments","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/b50dc1450b53f624fcd16ef5c1bb1a130db38cab","head":{"label":"aspnet:fix1687","ref":"fix1687","sha":"b50dc1450b53f624fcd16ef5c1bb1a130db38cab","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15126429,"name":"Mvc","full_name":"aspnet/Mvc","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Mvc","description":"Model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor.","fork":false,"url":"https://api.github.com/repos/aspnet/Mvc","forks_url":"https://api.github.com/repos/aspnet/Mvc/forks","keys_url":"https://api.github.com/repos/aspnet/Mvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Mvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Mvc/teams","hooks_url":"https://api.github.com/repos/aspnet/Mvc/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Mvc/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Mvc/events","assignees_url":"https://api.github.com/repos/aspnet/Mvc/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Mvc/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Mvc/tags","blobs_url":"https://api.github.com/repos/aspnet/Mvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Mvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Mvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Mvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Mvc/languages","stargazers_url":"https://api.github.com/repos/aspnet/Mvc/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Mvc/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Mvc/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Mvc/subscription","commits_url":"https://api.github.com/repos/aspnet/Mvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Mvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Mvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Mvc/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Mvc/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Mvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Mvc/merges","archive_url":"https://api.github.com/repos/aspnet/Mvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Mvc/downloads","issues_url":"https://api.github.com/repos/aspnet/Mvc/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Mvc/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Mvc/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Mvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Mvc/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Mvc/releases{/id}","created_at":"2013-12-12T03:54:00Z","updated_at":"2015-03-25T17:04:29Z","pushed_at":"2015-03-25T17:04:36Z","git_url":"git://github.com/aspnet/Mvc.git","ssh_url":"git@github.com:aspnet/Mvc.git","clone_url":"https://github.com/aspnet/Mvc.git","svn_url":"https://github.com/aspnet/Mvc","homepage":"","size":96118,"stargazers_count":1545,"watchers_count":1545,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":480,"mirror_url":null,"open_issues_count":206,"forks":480,"open_issues":206,"watchers":1545,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"1dafff4fb9e775861b247c0e5b227c27f5f7404a","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15126429,"name":"Mvc","full_name":"aspnet/Mvc","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Mvc","description":"Model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor.","fork":false,"url":"https://api.github.com/repos/aspnet/Mvc","forks_url":"https://api.github.com/repos/aspnet/Mvc/forks","keys_url":"https://api.github.com/repos/aspnet/Mvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Mvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Mvc/teams","hooks_url":"https://api.github.com/repos/aspnet/Mvc/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Mvc/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Mvc/events","assignees_url":"https://api.github.com/repos/aspnet/Mvc/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Mvc/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Mvc/tags","blobs_url":"https://api.github.com/repos/aspnet/Mvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Mvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Mvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Mvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Mvc/languages","stargazers_url":"https://api.github.com/repos/aspnet/Mvc/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Mvc/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Mvc/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Mvc/subscription","commits_url":"https://api.github.com/repos/aspnet/Mvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Mvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Mvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Mvc/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Mvc/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Mvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Mvc/merges","archive_url":"https://api.github.com/repos/aspnet/Mvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Mvc/downloads","issues_url":"https://api.github.com/repos/aspnet/Mvc/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Mvc/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Mvc/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Mvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Mvc/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Mvc/releases{/id}","created_at":"2013-12-12T03:54:00Z","updated_at":"2015-03-25T17:04:29Z","pushed_at":"2015-03-25T17:04:36Z","git_url":"git://github.com/aspnet/Mvc.git","ssh_url":"git@github.com:aspnet/Mvc.git","clone_url":"https://github.com/aspnet/Mvc.git","svn_url":"https://github.com/aspnet/Mvc","homepage":"","size":96118,"stargazers_count":1545,"watchers_count":1545,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":480,"mirror_url":null,"open_issues_count":206,"forks":480,"open_issues":206,"watchers":1545,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/2253"},"html":{"href":"https://github.com/aspnet/Mvc/pull/2253"},"issue":{"href":"https://api.github.com/repos/aspnet/Mvc/issues/2253"},"comments":{"href":"https://api.github.com/repos/aspnet/Mvc/issues/2253/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/2253/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/2253/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Mvc/statuses/b50dc1450b53f624fcd16ef5c1bb1a130db38cab"}}}}