{"comment":{"url":"https://api.github.com/repos/CartoDB/cartodb.js/comments/15122093","html_url":"https://github.com/CartoDB/cartodb.js/commit/916a20005c178c6a47bfa5b662e4185e31d06d64#commitcomment-15122093","id":15122093,"user":{"login":"alonsogarciapablo","id":390398,"avatar_url":"https://avatars.githubusercontent.com/u/390398?v=3","gravatar_id":"","url":"https://api.github.com/users/alonsogarciapablo","html_url":"https://github.com/alonsogarciapablo","followers_url":"https://api.github.com/users/alonsogarciapablo/followers","following_url":"https://api.github.com/users/alonsogarciapablo/following{/other_user}","gists_url":"https://api.github.com/users/alonsogarciapablo/gists{/gist_id}","starred_url":"https://api.github.com/users/alonsogarciapablo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alonsogarciapablo/subscriptions","organizations_url":"https://api.github.com/users/alonsogarciapablo/orgs","repos_url":"https://api.github.com/users/alonsogarciapablo/repos","events_url":"https://api.github.com/users/alonsogarciapablo/events{/privacy}","received_events_url":"https://api.github.com/users/alonsogarciapablo/received_events","type":"User","site_admin":false},"position":47,"line":54,"path":"test/spec/geo/ui/attribution.spec.js","commit_id":"916a20005c178c6a47bfa5b662e4185e31d06d64","created_at":"2015-12-22T16:18:38Z","updated_at":"2015-12-22T16:18:38Z","body":"If we renamed the `is-active` class, this test would still pass, cause we're not ensuring the `is-active` class was there in the first place. To make it :star2: I would do:\r\n\r\n```\r\nexpect(this.viewHasClass('is-active')).toBeTruthy();\r\nthis.$button.click();\r\nexpect(this.viewHasClass('is-active')).toBeFalsy();\r\n```"}}