{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/7653","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/7653/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/7653/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/7653/events","html_url":"https://github.com/joomla/joomla-cms/pull/7653","id":99730492,"number":7653,"title":"added full parameters for codemirror plugin to install sql for mysql,…","user":{"login":"jneubauer","id":871073,"avatar_url":"https://avatars.githubusercontent.com/u/871073?v=3","gravatar_id":"","url":"https://api.github.com/users/jneubauer","html_url":"https://github.com/jneubauer","followers_url":"https://api.github.com/users/jneubauer/followers","following_url":"https://api.github.com/users/jneubauer/following{/other_user}","gists_url":"https://api.github.com/users/jneubauer/gists{/gist_id}","starred_url":"https://api.github.com/users/jneubauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jneubauer/subscriptions","organizations_url":"https://api.github.com/users/jneubauer/orgs","repos_url":"https://api.github.com/users/jneubauer/repos","events_url":"https://api.github.com/users/jneubauer/events{/privacy}","received_events_url":"https://api.github.com/users/jneubauer/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":16,"created_at":"2015-08-07T21:06:15Z","updated_at":"2015-08-08T20:40:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/7653","html_url":"https://github.com/joomla/joomla-cms/pull/7653","diff_url":"https://github.com/joomla/joomla-cms/pull/7653.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/7653.patch"},"body":"added full parameters for codemirror plugin to install sql for mysql, postgres, and azure\r\n\r\ncurrently not all parameters are set on install - this fixes the problem in #6695 \r\n\r\n#### Steps to reproduce the issue\r\n* Install Joomla 3.4\r\n* Enable CodeMirror as the editor\r\n* Open any content - notice the \"active line\" or html element your cursor is in (e.g. a paragraph, h3, etc.) is highlighted in blue - a confusing highlight since it's the same color the browser highlights _selected_ text in. screenshot: http://monosnap.com/image/1VKZ0zawTBTdohBCXpTn1G1j1WXUJr\r\n\r\n#### Test instructions\r\nAs this is something created during the installation you can not use the patchtester.\r\nThe easiest way is to download the full Joomla package with this fix from https://github.com/jneubauer/joomla-cms/archive/codemirrorsql.zip\r\n* Install Joomla as normal.\r\n* Enable CodeMirror as the editor\r\n* Open any content - notice the \"active line\" or html element your cursor is in (e.g. a paragraph, h3, etc.) is NOT highlighted in blue \r\n"},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/129043278","html_url":"https://github.com/joomla/joomla-cms/pull/7653#issuecomment-129043278","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/7653","id":129043278,"user":{"login":"Bakual","id":1018684,"avatar_url":"https://avatars.githubusercontent.com/u/1018684?v=3","gravatar_id":"","url":"https://api.github.com/users/Bakual","html_url":"https://github.com/Bakual","followers_url":"https://api.github.com/users/Bakual/followers","following_url":"https://api.github.com/users/Bakual/following{/other_user}","gists_url":"https://api.github.com/users/Bakual/gists{/gist_id}","starred_url":"https://api.github.com/users/Bakual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bakual/subscriptions","organizations_url":"https://api.github.com/users/Bakual/orgs","repos_url":"https://api.github.com/users/Bakual/repos","events_url":"https://api.github.com/users/Bakual/events{/privacy}","received_events_url":"https://api.github.com/users/Bakual/received_events","type":"User","site_admin":false},"created_at":"2015-08-08T20:40:49Z","updated_at":"2015-08-08T20:40:49Z","body":"Actually, the parameters in the install SQL are imho useless if they are the same as the default values (which they should), but that's me :smile: \r\n\r\nThe defaults in code MUST be the same as the ones defined in the XML. Otherwise you get that funny effect that something acts different after you just open and soaved the parameters without changing anything. And this is the reason why it has to be changed in code or xml anyway. Because currently it will highlight the line until you save the params and then suddenly stops without the user actually changing a param.\r\nYour PR wouldn't solve that for existing users, only for new ones.\r\n\r\nPersonally I would change the XML file to have `default=\"1\"` (because that's actually what the behavior is currently) and also change the PHP code from `$this->params->get('activeLine', true);` to `$this->params->get('activeLine', 1);` because the default value actually is `1` and not `true`.\r\n\r\nYou can add the params to the SQL files, but it isn't really needed. All 3rd party extensions work fine without this anyway :smile: "}}