{"action":"created","issue":{"url":"https://api.github.com/repos/NYULibraries/findingaids/issues/57","labels_url":"https://api.github.com/repos/NYULibraries/findingaids/issues/57/labels{/name}","comments_url":"https://api.github.com/repos/NYULibraries/findingaids/issues/57/comments","events_url":"https://api.github.com/repos/NYULibraries/findingaids/issues/57/events","html_url":"https://github.com/NYULibraries/findingaids/pull/57","id":66180588,"number":57,"title":"Feature/bookmark export","user":{"login":"eshadatta","id":1337128,"avatar_url":"https://avatars.githubusercontent.com/u/1337128?v=3","gravatar_id":"","url":"https://api.github.com/users/eshadatta","html_url":"https://github.com/eshadatta","followers_url":"https://api.github.com/users/eshadatta/followers","following_url":"https://api.github.com/users/eshadatta/following{/other_user}","gists_url":"https://api.github.com/users/eshadatta/gists{/gist_id}","starred_url":"https://api.github.com/users/eshadatta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eshadatta/subscriptions","organizations_url":"https://api.github.com/users/eshadatta/orgs","repos_url":"https://api.github.com/users/eshadatta/repos","events_url":"https://api.github.com/users/eshadatta/events{/privacy}","received_events_url":"https://api.github.com/users/eshadatta/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":22,"created_at":"2015-04-03T16:31:37Z","updated_at":"2015-04-13T14:24:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NYULibraries/findingaids/pulls/57","html_url":"https://github.com/NYULibraries/findingaids/pull/57","diff_url":"https://github.com/NYULibraries/findingaids/pull/57.diff","patch_url":"https://github.com/NYULibraries/findingaids/pull/57.patch"},"body":"@barnabyalter ,\r\n\r\nThanks for your comments on the previous branch. I messed up some commits and so deleted that branch. I incorporated your feedback into my changes. However, I'm running into a cuke issue. When I test to see if the user has checked the bookmark, there's some ajax action happening, where we get a brief message saying \"Saving\" until the bookmark shows that it is checked and the label changes to \"In Bookmarks\". In capybara, the test hangs because it's waiting for something. When I did a save_and_open_page on that, I saw that the label has changed to \"Saving...\". I was wondering if you had any tips on how to go forward? I tried following [these steps](https://robots.thoughtbot.com/automatically-wait-for-ajax-with-capybara) and got a little further but not too far. I got other errors and instead of disappearing into another rabbit hole, I figured I'd ask you how to go forward. Thanks."},"comment":{"url":"https://api.github.com/repos/NYULibraries/findingaids/issues/comments/92376410","html_url":"https://github.com/NYULibraries/findingaids/pull/57#issuecomment-92376410","issue_url":"https://api.github.com/repos/NYULibraries/findingaids/issues/57","id":92376410,"user":{"login":"eshadatta","id":1337128,"avatar_url":"https://avatars.githubusercontent.com/u/1337128?v=3","gravatar_id":"","url":"https://api.github.com/users/eshadatta","html_url":"https://github.com/eshadatta","followers_url":"https://api.github.com/users/eshadatta/followers","following_url":"https://api.github.com/users/eshadatta/following{/other_user}","gists_url":"https://api.github.com/users/eshadatta/gists{/gist_id}","starred_url":"https://api.github.com/users/eshadatta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eshadatta/subscriptions","organizations_url":"https://api.github.com/users/eshadatta/orgs","repos_url":"https://api.github.com/users/eshadatta/repos","events_url":"https://api.github.com/users/eshadatta/events{/privacy}","received_events_url":"https://api.github.com/users/eshadatta/received_events","type":"User","site_admin":false},"created_at":"2015-04-13T14:24:14Z","updated_at":"2015-04-13T14:24:14Z","body":"@barnabyalter , @NYULibraries/finding-aids \r\nI have fixed the rspec per @jgpawletko 's suggestion. I still have remaining questions about cuke tests.\r\n\r\nAs mentioned earlier(I'm copying from an earlier comment)\r\n\r\n1. I changed the cuke test to reflect the steps Barnaby had outlined above in this PR. When I look at the test log, I see an insert statement to see that the bookmark is saved. Also, I notice that the user id is persisting in that step definition. However, I don't see the bookmarks when I visit that path. On closer inspection of the views in the blacklight gem, it seems that in cucumber, the @documentlist var isn't being populated in the test which means that the saved bookmark isn't shown on that page. I tried doing a bookmark factory and I see that is being created too but it doesn't populate the bookmark.\r\n2. I have been working on this test for over a week. This functionality has already been tested within blacklight. I basically just turned it on. It works on my dev machine. Do I need to test the \"email\" and \"cite\" functionality especially since no matter what I have done, I can not get the saved bookmark to show up. I do show that I can \"save\" the bookmark.\r\n3. I have a citation helper function for which I have a rspec test. I can add other fields to it to make it match the acceptance criteria. Right now, it gets the correct format for the citation with the fields that are present in the solr doc. Please let me know about the direction of the cucumber tests.\r\n\r\nThanks.\r\n\r\nEsha\r\n"}}