{"action":"created","comment":{"url":"https://api.github.com/repos/triplea-game/triplea/pulls/comments/36047114","id":36047114,"diff_hunk":"@@ -314,37 +293,24 @@ private void resetDefaultGame() {\n   }\n \n   public void loadDefaultGame(final Component ui) {\n-    // clear out dynamix's properties (this ended up being the best place to put it, as we have definitely left a game at this point)\n+    // clear out dynamix's properties (this ended up being the best place to put it, as we have\n+    // definitely left a game at this point)\n     Dynamix_AI.gameOverClearCachedGameDataAll();\n     ProAI.gameOverClearCache();\n-    loadDefaultGame(ui, false);\n-  }\n \n-  /**\n-   * @param ui\n-   * @param forceFactoryDefault\n-   *        - False is default behavior and causes the new game chooser model to be cleared (and refreshed if needed).\n-   *        True causes the default game preference to be reset, but the model does not get cleared/refreshed (because we only call with\n-   *        'true' if loading the user preferred map failed).\n-   */\n-  private void loadDefaultGame(final Component ui, final boolean forceFactoryDefault) {\n-    // load the previously saved value\n     final Preferences prefs = Preferences.userNodeForPackage(this.getClass());\n-    if (forceFactoryDefault) {\n-      // we don't refresh the game chooser model because we have just removed a bad map from it\n-      resetDefaultGame();\n-    }\n+    final String userPreferredDefaultGameURI = prefs.get(DEFAULT_GAME_URI_PREF, DEFAULT_GAME_URI);\n     NewGameChooserEntry selectedGame = null;","path":"src/games/strategy/engine/framework/startup/mc/GameSelectorModel.java","position":252,"original_position":252,"commit_id":"f4a56d200f25e12e93b4009748ae0d8da557e991","original_commit_id":"f4a56d200f25e12e93b4009748ae0d8da557e991","user":{"login":"DanVanAtta","id":12397753,"avatar_url":"https://avatars.githubusercontent.com/u/12397753?v=3","gravatar_id":"","url":"https://api.github.com/users/DanVanAtta","html_url":"https://github.com/DanVanAtta","followers_url":"https://api.github.com/users/DanVanAtta/followers","following_url":"https://api.github.com/users/DanVanAtta/following{/other_user}","gists_url":"https://api.github.com/users/DanVanAtta/gists{/gist_id}","starred_url":"https://api.github.com/users/DanVanAtta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanVanAtta/subscriptions","organizations_url":"https://api.github.com/users/DanVanAtta/orgs","repos_url":"https://api.github.com/users/DanVanAtta/repos","events_url":"https://api.github.com/users/DanVanAtta/events{/privacy}","received_events_url":"https://api.github.com/users/DanVanAtta/received_events","type":"User","site_admin":false},"body":"Paths of code where forceFactoryDefault is false are removed. This method was changed from loadDefaultGame(Component , boolean ) to be instead loadDefaultGame( Component) and the boolean parameter is always false (and so is removed). Clients that called this method before with a \"true\" value now instead call loadFactoryDefaultGame. There you should see \"resetDefaultGame()\" game code.","created_at":"2015-08-02T20:09:09Z","updated_at":"2015-08-02T20:09:09Z","html_url":"https://github.com/triplea-game/triplea/pull/28#discussion_r36047114","pull_request_url":"https://api.github.com/repos/triplea-game/triplea/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/triplea-game/triplea/pulls/comments/36047114"},"html":{"href":"https://github.com/triplea-game/triplea/pull/28#discussion_r36047114"},"pull_request":{"href":"https://api.github.com/repos/triplea-game/triplea/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/triplea-game/triplea/pulls/28","id":41397931,"html_url":"https://github.com/triplea-game/triplea/pull/28","diff_url":"https://github.com/triplea-game/triplea/pull/28.diff","patch_url":"https://github.com/triplea-game/triplea/pull/28.patch","issue_url":"https://api.github.com/repos/triplea-game/triplea/issues/28","number":28,"state":"open","locked":false,"title":"Fix for ErrorHandler and some refactoring to GameSelectorModel pre-unit test","user":{"login":"DanVanAtta","id":12397753,"avatar_url":"https://avatars.githubusercontent.com/u/12397753?v=3","gravatar_id":"","url":"https://api.github.com/users/DanVanAtta","html_url":"https://github.com/DanVanAtta","followers_url":"https://api.github.com/users/DanVanAtta/followers","following_url":"https://api.github.com/users/DanVanAtta/following{/other_user}","gists_url":"https://api.github.com/users/DanVanAtta/gists{/gist_id}","starred_url":"https://api.github.com/users/DanVanAtta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanVanAtta/subscriptions","organizations_url":"https://api.github.com/users/DanVanAtta/orgs","repos_url":"https://api.github.com/users/DanVanAtta/repos","events_url":"https://api.github.com/users/DanVanAtta/events{/privacy}","received_events_url":"https://api.github.com/users/DanVanAtta/received_events","type":"User","site_admin":false},"body":"I'm going to expand on this branch some more with some tests. There are number of changes building up to the first test, they are pretty atomic too so a person can get started reviewing them and they can merged. The commits I tried to make pretty fine grained, you should get a pretty good sense of everything in the commits from the commit message alone hopefully.\r\n\r\nCHANGE NUMBER ONE - GameSelectorModel refactor\r\nWhile building a unit test for GameSelectorModel there were a number of fixes / changes possible and some needed. I have the test created, and many of these changes were driven by working with that test. The test is not yet included. It needs some more work, and due to the format change I'm still bringing in old changes.\r\n\r\nCurrently though I have a releasable unit worth of work. The unit test passes, and manually testing things look good.\r\n\r\nCHANGE NUMBER TWO - Fix for ErrorHandler.java\r\nWhile building other tests I found that ErrorHandler does nothing. Throwing exceptions explicitly and it catches nada. But it is not so hard to convert it so it would. Instead of settting to a system property you set Thread.setUncaughtExceptionHandler, and have ErrorHandler implement that interface. Then it starts catching exceptions. For now users won't notice the difference since Error Handler will quietly print the errors. Also I removed the prior functionality beyond logging of ErrorHandler (game over flag). It was questionable, and since the feature was broken, was never used anyways (so we lose no value  by it being removed now).","created_at":"2015-08-01T07:13:11Z","updated_at":"2015-08-02T20:09:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab50322f4fdc954888189367f117d484d38a795c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/triplea-game/triplea/pulls/28/commits","review_comments_url":"https://api.github.com/repos/triplea-game/triplea/pulls/28/comments","review_comment_url":"https://api.github.com/repos/triplea-game/triplea/pulls/comments{/number}","comments_url":"https://api.github.com/repos/triplea-game/triplea/issues/28/comments","statuses_url":"https://api.github.com/repos/triplea-game/triplea/statuses/f4a56d200f25e12e93b4009748ae0d8da557e991","head":{"label":"DanVanAtta:better_tests","ref":"better_tests","sha":"f4a56d200f25e12e93b4009748ae0d8da557e991","user":{"login":"DanVanAtta","id":12397753,"avatar_url":"https://avatars.githubusercontent.com/u/12397753?v=3","gravatar_id":"","url":"https://api.github.com/users/DanVanAtta","html_url":"https://github.com/DanVanAtta","followers_url":"https://api.github.com/users/DanVanAtta/followers","following_url":"https://api.github.com/users/DanVanAtta/following{/other_user}","gists_url":"https://api.github.com/users/DanVanAtta/gists{/gist_id}","starred_url":"https://api.github.com/users/DanVanAtta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanVanAtta/subscriptions","organizations_url":"https://api.github.com/users/DanVanAtta/orgs","repos_url":"https://api.github.com/users/DanVanAtta/repos","events_url":"https://api.github.com/users/DanVanAtta/events{/privacy}","received_events_url":"https://api.github.com/users/DanVanAtta/received_events","type":"User","site_admin":false},"repo":{"id":39811826,"name":"triplea","full_name":"DanVanAtta/triplea","owner":{"login":"DanVanAtta","id":12397753,"avatar_url":"https://avatars.githubusercontent.com/u/12397753?v=3","gravatar_id":"","url":"https://api.github.com/users/DanVanAtta","html_url":"https://github.com/DanVanAtta","followers_url":"https://api.github.com/users/DanVanAtta/followers","following_url":"https://api.github.com/users/DanVanAtta/following{/other_user}","gists_url":"https://api.github.com/users/DanVanAtta/gists{/gist_id}","starred_url":"https://api.github.com/users/DanVanAtta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanVanAtta/subscriptions","organizations_url":"https://api.github.com/users/DanVanAtta/orgs","repos_url":"https://api.github.com/users/DanVanAtta/repos","events_url":"https://api.github.com/users/DanVanAtta/events{/privacy}","received_events_url":"https://api.github.com/users/DanVanAtta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DanVanAtta/triplea","description":"TripleA is a turn based strategy game and board game engine, similar to Axis & Allies or Risk.","fork":true,"url":"https://api.github.com/repos/DanVanAtta/triplea","forks_url":"https://api.github.com/repos/DanVanAtta/triplea/forks","keys_url":"https://api.github.com/repos/DanVanAtta/triplea/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DanVanAtta/triplea/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DanVanAtta/triplea/teams","hooks_url":"https://api.github.com/repos/DanVanAtta/triplea/hooks","issue_events_url":"https://api.github.com/repos/DanVanAtta/triplea/issues/events{/number}","events_url":"https://api.github.com/repos/DanVanAtta/triplea/events","assignees_url":"https://api.github.com/repos/DanVanAtta/triplea/assignees{/user}","branches_url":"https://api.github.com/repos/DanVanAtta/triplea/branches{/branch}","tags_url":"https://api.github.com/repos/DanVanAtta/triplea/tags","blobs_url":"https://api.github.com/repos/DanVanAtta/triplea/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DanVanAtta/triplea/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DanVanAtta/triplea/git/refs{/sha}","trees_url":"https://api.github.com/repos/DanVanAtta/triplea/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DanVanAtta/triplea/statuses/{sha}","languages_url":"https://api.github.com/repos/DanVanAtta/triplea/languages","stargazers_url":"https://api.github.com/repos/DanVanAtta/triplea/stargazers","contributors_url":"https://api.github.com/repos/DanVanAtta/triplea/contributors","subscribers_url":"https://api.github.com/repos/DanVanAtta/triplea/subscribers","subscription_url":"https://api.github.com/repos/DanVanAtta/triplea/subscription","commits_url":"https://api.github.com/repos/DanVanAtta/triplea/commits{/sha}","git_commits_url":"https://api.github.com/repos/DanVanAtta/triplea/git/commits{/sha}","comments_url":"https://api.github.com/repos/DanVanAtta/triplea/comments{/number}","issue_comment_url":"https://api.github.com/repos/DanVanAtta/triplea/issues/comments{/number}","contents_url":"https://api.github.com/repos/DanVanAtta/triplea/contents/{+path}","compare_url":"https://api.github.com/repos/DanVanAtta/triplea/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DanVanAtta/triplea/merges","archive_url":"https://api.github.com/repos/DanVanAtta/triplea/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DanVanAtta/triplea/downloads","issues_url":"https://api.github.com/repos/DanVanAtta/triplea/issues{/number}","pulls_url":"https://api.github.com/repos/DanVanAtta/triplea/pulls{/number}","milestones_url":"https://api.github.com/repos/DanVanAtta/triplea/milestones{/number}","notifications_url":"https://api.github.com/repos/DanVanAtta/triplea/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DanVanAtta/triplea/labels{/name}","releases_url":"https://api.github.com/repos/DanVanAtta/triplea/releases{/id}","created_at":"2015-07-28T03:48:44Z","updated_at":"2015-07-28T03:49:05Z","pushed_at":"2015-08-02T00:49:29Z","git_url":"git://github.com/DanVanAtta/triplea.git","ssh_url":"git@github.com:DanVanAtta/triplea.git","clone_url":"https://github.com/DanVanAtta/triplea.git","svn_url":"https://github.com/DanVanAtta/triplea","homepage":null,"size":611216,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"triplea-game:master","ref":"master","sha":"868d1da2d179dc0bc5fb30ac8db7e83cfefd4dc4","user":{"login":"triplea-game","id":13318615,"avatar_url":"https://avatars.githubusercontent.com/u/13318615?v=3","gravatar_id":"","url":"https://api.github.com/users/triplea-game","html_url":"https://github.com/triplea-game","followers_url":"https://api.github.com/users/triplea-game/followers","following_url":"https://api.github.com/users/triplea-game/following{/other_user}","gists_url":"https://api.github.com/users/triplea-game/gists{/gist_id}","starred_url":"https://api.github.com/users/triplea-game/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/triplea-game/subscriptions","organizations_url":"https://api.github.com/users/triplea-game/orgs","repos_url":"https://api.github.com/users/triplea-game/repos","events_url":"https://api.github.com/users/triplea-game/events{/privacy}","received_events_url":"https://api.github.com/users/triplea-game/received_events","type":"Organization","site_admin":false},"repo":{"id":39766308,"name":"triplea","full_name":"triplea-game/triplea","owner":{"login":"triplea-game","id":13318615,"avatar_url":"https://avatars.githubusercontent.com/u/13318615?v=3","gravatar_id":"","url":"https://api.github.com/users/triplea-game","html_url":"https://github.com/triplea-game","followers_url":"https://api.github.com/users/triplea-game/followers","following_url":"https://api.github.com/users/triplea-game/following{/other_user}","gists_url":"https://api.github.com/users/triplea-game/gists{/gist_id}","starred_url":"https://api.github.com/users/triplea-game/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/triplea-game/subscriptions","organizations_url":"https://api.github.com/users/triplea-game/orgs","repos_url":"https://api.github.com/users/triplea-game/repos","events_url":"https://api.github.com/users/triplea-game/events{/privacy}","received_events_url":"https://api.github.com/users/triplea-game/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/triplea-game/triplea","description":"TripleA is a turn based strategy game and board game engine, similar to Axis & Allies or Risk.","fork":false,"url":"https://api.github.com/repos/triplea-game/triplea","forks_url":"https://api.github.com/repos/triplea-game/triplea/forks","keys_url":"https://api.github.com/repos/triplea-game/triplea/keys{/key_id}","collaborators_url":"https://api.github.com/repos/triplea-game/triplea/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/triplea-game/triplea/teams","hooks_url":"https://api.github.com/repos/triplea-game/triplea/hooks","issue_events_url":"https://api.github.com/repos/triplea-game/triplea/issues/events{/number}","events_url":"https://api.github.com/repos/triplea-game/triplea/events","assignees_url":"https://api.github.com/repos/triplea-game/triplea/assignees{/user}","branches_url":"https://api.github.com/repos/triplea-game/triplea/branches{/branch}","tags_url":"https://api.github.com/repos/triplea-game/triplea/tags","blobs_url":"https://api.github.com/repos/triplea-game/triplea/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/triplea-game/triplea/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/triplea-game/triplea/git/refs{/sha}","trees_url":"https://api.github.com/repos/triplea-game/triplea/git/trees{/sha}","statuses_url":"https://api.github.com/repos/triplea-game/triplea/statuses/{sha}","languages_url":"https://api.github.com/repos/triplea-game/triplea/languages","stargazers_url":"https://api.github.com/repos/triplea-game/triplea/stargazers","contributors_url":"https://api.github.com/repos/triplea-game/triplea/contributors","subscribers_url":"https://api.github.com/repos/triplea-game/triplea/subscribers","subscription_url":"https://api.github.com/repos/triplea-game/triplea/subscription","commits_url":"https://api.github.com/repos/triplea-game/triplea/commits{/sha}","git_commits_url":"https://api.github.com/repos/triplea-game/triplea/git/commits{/sha}","comments_url":"https://api.github.com/repos/triplea-game/triplea/comments{/number}","issue_comment_url":"https://api.github.com/repos/triplea-game/triplea/issues/comments{/number}","contents_url":"https://api.github.com/repos/triplea-game/triplea/contents/{+path}","compare_url":"https://api.github.com/repos/triplea-game/triplea/compare/{base}...{head}","merges_url":"https://api.github.com/repos/triplea-game/triplea/merges","archive_url":"https://api.github.com/repos/triplea-game/triplea/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/triplea-game/triplea/downloads","issues_url":"https://api.github.com/repos/triplea-game/triplea/issues{/number}","pulls_url":"https://api.github.com/repos/triplea-game/triplea/pulls{/number}","milestones_url":"https://api.github.com/repos/triplea-game/triplea/milestones{/number}","notifications_url":"https://api.github.com/repos/triplea-game/triplea/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/triplea-game/triplea/labels{/name}","releases_url":"https://api.github.com/repos/triplea-game/triplea/releases{/id}","created_at":"2015-07-27T09:32:58Z","updated_at":"2015-08-02T06:47:16Z","pushed_at":"2015-08-02T06:11:04Z","git_url":"git://github.com/triplea-game/triplea.git","ssh_url":"git@github.com:triplea-game/triplea.git","clone_url":"https://github.com/triplea-game/triplea.git","svn_url":"https://github.com/triplea-game/triplea","homepage":null,"size":611216,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":12,"forks":2,"open_issues":12,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/triplea-game/triplea/pulls/28"},"html":{"href":"https://github.com/triplea-game/triplea/pull/28"},"issue":{"href":"https://api.github.com/repos/triplea-game/triplea/issues/28"},"comments":{"href":"https://api.github.com/repos/triplea-game/triplea/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/triplea-game/triplea/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/triplea-game/triplea/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/triplea-game/triplea/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/triplea-game/triplea/statuses/f4a56d200f25e12e93b4009748ae0d8da557e991"}}}}