{"action":"opened","number":14,"pull_request":{"url":"https://api.github.com/repos/google/UIforETW/pulls/14","id":33929752,"html_url":"https://github.com/google/UIforETW/pull/14","diff_url":"https://github.com/google/UIforETW/pull/14.diff","patch_url":"https://github.com/google/UIforETW/pull/14.patch","issue_url":"https://api.github.com/repos/google/UIforETW/issues/14","number":14,"state":"open","locked":false,"title":"\"partial\" Python 3 support for StripChromeSymbols.py/fix `#include afxwin.h`","user":{"login":"ariccio","id":2142308,"avatar_url":"https://avatars.githubusercontent.com/u/2142308?v=3","gravatar_id":"","url":"https://api.github.com/users/ariccio","html_url":"https://github.com/ariccio","followers_url":"https://api.github.com/users/ariccio/followers","following_url":"https://api.github.com/users/ariccio/following{/other_user}","gists_url":"https://api.github.com/users/ariccio/gists{/gist_id}","starred_url":"https://api.github.com/users/ariccio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariccio/subscriptions","organizations_url":"https://api.github.com/users/ariccio/orgs","repos_url":"https://api.github.com/users/ariccio/repos","events_url":"https://api.github.com/users/ariccio/events{/privacy}","received_events_url":"https://api.github.com/users/ariccio/received_events","type":"User","site_admin":false},"body":"This is actually a rather small PR, but because I moved the code in StripChromeSymbols.py into a `main` function, there are ~100 \"additions\" that aren't.\r\n\r\nThere are two components to this PR:\r\n\r\n1. Python 3 support for StripChromeSymbols.py\r\n2. A workaround for issue #13 - so that I can use UIforETW in the meantime.\r\n\r\n\r\nThe branch is called \"switch-to-subprocess\" because I originally thought that `os.popen` was the problem, and tried to solve it in [86cd03c299b70c521da2c534a5b3acc882de7bd8](https://github.com/ariccio/UIforETW/commit/86cd03c299b70c521da2c534a5b3acc882de7bd8)\r\n\r\n\r\n[I also moved](https://github.com/ariccio/UIforETW/commit/eda1724b68fb1b2069a7258410316f989bd233a8) `#include <afxwin.h>` to the top of stdafx.h, because some people (like me) can't compile MFC programs if it isn't the first include. I think it has something to do with Voodoo.\r\n\r\nI've gotten used to it, but it is CRAZY HARD to actually figure out (that not including afxwin.h first) is generating 400 errors.\r\n\r\n\r\nStrangely, GitHub converted `eda1724b68fb1b2069a7258410316f989bd233a8`, to link to `https://github.com/google/UIforETW/commit/eda1724b68fb1b2069a7258410316f989bd233a8`, and the same for `86cd03c299b70c521da2c534a5b3acc882de7bd8`??!? What the hell?","created_at":"2015-04-23T07:15:50Z","updated_at":"2015-04-23T07:15:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/UIforETW/pulls/14/commits","review_comments_url":"https://api.github.com/repos/google/UIforETW/pulls/14/comments","review_comment_url":"https://api.github.com/repos/google/UIforETW/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/UIforETW/issues/14/comments","statuses_url":"https://api.github.com/repos/google/UIforETW/statuses/486470bd028abcbbe5b0441a7735fd5abaceea71","head":{"label":"ariccio:switch-to-subprocess","ref":"switch-to-subprocess","sha":"486470bd028abcbbe5b0441a7735fd5abaceea71","user":{"login":"ariccio","id":2142308,"avatar_url":"https://avatars.githubusercontent.com/u/2142308?v=3","gravatar_id":"","url":"https://api.github.com/users/ariccio","html_url":"https://github.com/ariccio","followers_url":"https://api.github.com/users/ariccio/followers","following_url":"https://api.github.com/users/ariccio/following{/other_user}","gists_url":"https://api.github.com/users/ariccio/gists{/gist_id}","starred_url":"https://api.github.com/users/ariccio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariccio/subscriptions","organizations_url":"https://api.github.com/users/ariccio/orgs","repos_url":"https://api.github.com/users/ariccio/repos","events_url":"https://api.github.com/users/ariccio/events{/privacy}","received_events_url":"https://api.github.com/users/ariccio/received_events","type":"User","site_admin":false},"repo":{"id":33953307,"name":"UIforETW","full_name":"ariccio/UIforETW","owner":{"login":"ariccio","id":2142308,"avatar_url":"https://avatars.githubusercontent.com/u/2142308?v=3","gravatar_id":"","url":"https://api.github.com/users/ariccio","html_url":"https://github.com/ariccio","followers_url":"https://api.github.com/users/ariccio/followers","following_url":"https://api.github.com/users/ariccio/following{/other_user}","gists_url":"https://api.github.com/users/ariccio/gists{/gist_id}","starred_url":"https://api.github.com/users/ariccio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariccio/subscriptions","organizations_url":"https://api.github.com/users/ariccio/orgs","repos_url":"https://api.github.com/users/ariccio/repos","events_url":"https://api.github.com/users/ariccio/events{/privacy}","received_events_url":"https://api.github.com/users/ariccio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ariccio/UIforETW","description":"User interface for recording and managing ETW traces","fork":true,"url":"https://api.github.com/repos/ariccio/UIforETW","forks_url":"https://api.github.com/repos/ariccio/UIforETW/forks","keys_url":"https://api.github.com/repos/ariccio/UIforETW/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ariccio/UIforETW/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ariccio/UIforETW/teams","hooks_url":"https://api.github.com/repos/ariccio/UIforETW/hooks","issue_events_url":"https://api.github.com/repos/ariccio/UIforETW/issues/events{/number}","events_url":"https://api.github.com/repos/ariccio/UIforETW/events","assignees_url":"https://api.github.com/repos/ariccio/UIforETW/assignees{/user}","branches_url":"https://api.github.com/repos/ariccio/UIforETW/branches{/branch}","tags_url":"https://api.github.com/repos/ariccio/UIforETW/tags","blobs_url":"https://api.github.com/repos/ariccio/UIforETW/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ariccio/UIforETW/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ariccio/UIforETW/git/refs{/sha}","trees_url":"https://api.github.com/repos/ariccio/UIforETW/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ariccio/UIforETW/statuses/{sha}","languages_url":"https://api.github.com/repos/ariccio/UIforETW/languages","stargazers_url":"https://api.github.com/repos/ariccio/UIforETW/stargazers","contributors_url":"https://api.github.com/repos/ariccio/UIforETW/contributors","subscribers_url":"https://api.github.com/repos/ariccio/UIforETW/subscribers","subscription_url":"https://api.github.com/repos/ariccio/UIforETW/subscription","commits_url":"https://api.github.com/repos/ariccio/UIforETW/commits{/sha}","git_commits_url":"https://api.github.com/repos/ariccio/UIforETW/git/commits{/sha}","comments_url":"https://api.github.com/repos/ariccio/UIforETW/comments{/number}","issue_comment_url":"https://api.github.com/repos/ariccio/UIforETW/issues/comments{/number}","contents_url":"https://api.github.com/repos/ariccio/UIforETW/contents/{+path}","compare_url":"https://api.github.com/repos/ariccio/UIforETW/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ariccio/UIforETW/merges","archive_url":"https://api.github.com/repos/ariccio/UIforETW/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ariccio/UIforETW/downloads","issues_url":"https://api.github.com/repos/ariccio/UIforETW/issues{/number}","pulls_url":"https://api.github.com/repos/ariccio/UIforETW/pulls{/number}","milestones_url":"https://api.github.com/repos/ariccio/UIforETW/milestones{/number}","notifications_url":"https://api.github.com/repos/ariccio/UIforETW/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ariccio/UIforETW/labels{/name}","releases_url":"https://api.github.com/repos/ariccio/UIforETW/releases{/id}","created_at":"2015-04-14T19:47:38Z","updated_at":"2015-04-20T06:38:37Z","pushed_at":"2015-04-23T06:45:52Z","git_url":"git://github.com/ariccio/UIforETW.git","ssh_url":"git@github.com:ariccio/UIforETW.git","clone_url":"https://github.com/ariccio/UIforETW.git","svn_url":"https://github.com/ariccio/UIforETW","homepage":"","size":2134,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"d20a0fbcff11988dadd3ca9604e69503e3c08f18","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":33694418,"name":"UIforETW","full_name":"google/UIforETW","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/UIforETW","description":"User interface for recording and managing ETW traces","fork":false,"url":"https://api.github.com/repos/google/UIforETW","forks_url":"https://api.github.com/repos/google/UIforETW/forks","keys_url":"https://api.github.com/repos/google/UIforETW/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/UIforETW/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/UIforETW/teams","hooks_url":"https://api.github.com/repos/google/UIforETW/hooks","issue_events_url":"https://api.github.com/repos/google/UIforETW/issues/events{/number}","events_url":"https://api.github.com/repos/google/UIforETW/events","assignees_url":"https://api.github.com/repos/google/UIforETW/assignees{/user}","branches_url":"https://api.github.com/repos/google/UIforETW/branches{/branch}","tags_url":"https://api.github.com/repos/google/UIforETW/tags","blobs_url":"https://api.github.com/repos/google/UIforETW/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/UIforETW/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/UIforETW/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/UIforETW/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/UIforETW/statuses/{sha}","languages_url":"https://api.github.com/repos/google/UIforETW/languages","stargazers_url":"https://api.github.com/repos/google/UIforETW/stargazers","contributors_url":"https://api.github.com/repos/google/UIforETW/contributors","subscribers_url":"https://api.github.com/repos/google/UIforETW/subscribers","subscription_url":"https://api.github.com/repos/google/UIforETW/subscription","commits_url":"https://api.github.com/repos/google/UIforETW/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/UIforETW/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/UIforETW/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/UIforETW/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/UIforETW/contents/{+path}","compare_url":"https://api.github.com/repos/google/UIforETW/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/UIforETW/merges","archive_url":"https://api.github.com/repos/google/UIforETW/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/UIforETW/downloads","issues_url":"https://api.github.com/repos/google/UIforETW/issues{/number}","pulls_url":"https://api.github.com/repos/google/UIforETW/pulls{/number}","milestones_url":"https://api.github.com/repos/google/UIforETW/milestones{/number}","notifications_url":"https://api.github.com/repos/google/UIforETW/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/UIforETW/labels{/name}","releases_url":"https://api.github.com/repos/google/UIforETW/releases{/id}","created_at":"2015-04-09T21:46:04Z","updated_at":"2015-04-22T15:14:47Z","pushed_at":"2015-04-20T06:40:37Z","git_url":"git://github.com/google/UIforETW.git","ssh_url":"git@github.com:google/UIforETW.git","clone_url":"https://github.com/google/UIforETW.git","svn_url":"https://github.com/google/UIforETW","homepage":"https://randomascii.wordpress.com/2015/04/14/uiforetw-windows-performance-made-easier/","size":2203,"stargazers_count":44,"watchers_count":44,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":7,"forks":5,"open_issues":7,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/UIforETW/pulls/14"},"html":{"href":"https://github.com/google/UIforETW/pull/14"},"issue":{"href":"https://api.github.com/repos/google/UIforETW/issues/14"},"comments":{"href":"https://api.github.com/repos/google/UIforETW/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/google/UIforETW/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/google/UIforETW/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/UIforETW/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/google/UIforETW/statuses/486470bd028abcbbe5b0441a7735fd5abaceea71"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":8,"additions":140,"deletions":120,"changed_files":3}}