{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/orleans/issues/441","labels_url":"https://api.github.com/repos/dotnet/orleans/issues/441/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/orleans/issues/441/comments","events_url":"https://api.github.com/repos/dotnet/orleans/issues/441/events","html_url":"https://github.com/dotnet/orleans/pull/441","id":80264893,"number":441,"title":"Refactoring tests to async-await","user":{"login":"veikkoeeva","id":5158694,"avatar_url":"https://avatars.githubusercontent.com/u/5158694?v=3","gravatar_id":"","url":"https://api.github.com/users/veikkoeeva","html_url":"https://github.com/veikkoeeva","followers_url":"https://api.github.com/users/veikkoeeva/followers","following_url":"https://api.github.com/users/veikkoeeva/following{/other_user}","gists_url":"https://api.github.com/users/veikkoeeva/gists{/gist_id}","starred_url":"https://api.github.com/users/veikkoeeva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/veikkoeeva/subscriptions","organizations_url":"https://api.github.com/users/veikkoeeva/orgs","repos_url":"https://api.github.com/users/veikkoeeva/repos","events_url":"https://api.github.com/users/veikkoeeva/events{/privacy}","received_events_url":"https://api.github.com/users/veikkoeeva/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/orleans/labels/cla-already-signed","name":"cla-already-signed","color":"009800"},{"url":"https://api.github.com/repos/dotnet/orleans/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-05-24T20:38:02Z","updated_at":"2015-05-26T17:02:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/orleans/pulls/441","html_url":"https://github.com/dotnet/orleans/pull/441","diff_url":"https://github.com/dotnet/orleans/pull/441.diff","patch_url":"https://github.com/dotnet/orleans/pull/441.patch"},"body":"It would make sense to refactor all the code to be async-await too. Some of the testing code arguably is as it returns ``TaskDone.Done``, though using .Result and Wait() on the caller side making it more difficult to detect and pushes one into investigating in more detail. But not all code is asynchronous."},"comment":{"url":"https://api.github.com/repos/dotnet/orleans/issues/comments/105603478","html_url":"https://github.com/dotnet/orleans/pull/441#issuecomment-105603478","issue_url":"https://api.github.com/repos/dotnet/orleans/issues/441","id":105603478,"user":{"login":"gabikliot","id":10171207,"avatar_url":"https://avatars.githubusercontent.com/u/10171207?v=3","gravatar_id":"","url":"https://api.github.com/users/gabikliot","html_url":"https://github.com/gabikliot","followers_url":"https://api.github.com/users/gabikliot/followers","following_url":"https://api.github.com/users/gabikliot/following{/other_user}","gists_url":"https://api.github.com/users/gabikliot/gists{/gist_id}","starred_url":"https://api.github.com/users/gabikliot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabikliot/subscriptions","organizations_url":"https://api.github.com/users/gabikliot/orgs","repos_url":"https://api.github.com/users/gabikliot/repos","events_url":"https://api.github.com/users/gabikliot/events{/privacy}","received_events_url":"https://api.github.com/users/gabikliot/received_events","type":"User","site_admin":false},"created_at":"2015-05-26T17:02:04Z","updated_at":"2015-05-26T17:02:04Z","body":"@veikkoeeva, by we I mean the us: me and you and all the rest of the open source Orleans Community. https://github.com/dotnet/orleans/blob/master/src/Orleans/Async/TaskExtensions.cs#L113\r\n\r\nIt is now inside internal class. The reason we (no we refers to me, @sergeybykov  and @jthelin) kept it internal and not public, is that in general we don't want to be in the business of writing (public) Task extensions. But this particular one seems indeed very useful and we use it a lot inside the runtime. \r\nSo feel free to suggest a PR with making it public and we will let others weigh in their opinion.\r\n"}}