{"action":"created","issue":{"url":"https://api.github.com/repos/shiva-spampot/shiva/issues/7","labels_url":"https://api.github.com/repos/shiva-spampot/shiva/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/shiva-spampot/shiva/issues/7/comments","events_url":"https://api.github.com/repos/shiva-spampot/shiva/issues/7/events","html_url":"https://github.com/shiva-spampot/shiva/issues/7","id":52120014,"number":7,"title":"Bugs in authentication procedure in smtpd.py","user":{"login":"standa4","id":9959805,"avatar_url":"https://avatars.githubusercontent.com/u/9959805?v=3","gravatar_id":"","url":"https://api.github.com/users/standa4","html_url":"https://github.com/standa4","followers_url":"https://api.github.com/users/standa4/followers","following_url":"https://api.github.com/users/standa4/following{/other_user}","gists_url":"https://api.github.com/users/standa4/gists{/gist_id}","starred_url":"https://api.github.com/users/standa4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/standa4/subscriptions","organizations_url":"https://api.github.com/users/standa4/orgs","repos_url":"https://api.github.com/users/standa4/repos","events_url":"https://api.github.com/users/standa4/events{/privacy}","received_events_url":"https://api.github.com/users/standa4/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2014-12-16T14:42:32Z","updated_at":"2015-04-07T11:05:21Z","closed_at":null,"body":"Hi,\r\nI found some bugs in smtpd.py file.\r\n\r\n1. on line with code if 'LOGIN' == split_args[0]: is a bug in comparison.\r\nThere is incorrectly compared uppercase 'LOGIN' although some clients can send this string in lowercase.\r\n\r\n2. there is a bug in validate function.\r\nSpecifically on line with code while i < len(password):\r\nThere should by comparison with count of stored passwords (or usernames) not with length of actual password.\r\n\r\n3. there is a bug in smtp_EHLO function (and maybe on other places)\r\nThere are three push() calls in a row. It can cause error, if client receive these informations in more than one message. Some clients process only firts one and terminate with failure."},"comment":{"url":"https://api.github.com/repos/shiva-spampot/shiva/issues/comments/90507959","html_url":"https://github.com/shiva-spampot/shiva/issues/7#issuecomment-90507959","issue_url":"https://api.github.com/repos/shiva-spampot/shiva/issues/7","id":90507959,"user":{"login":"ameygat","id":10447458,"avatar_url":"https://avatars.githubusercontent.com/u/10447458?v=3","gravatar_id":"","url":"https://api.github.com/users/ameygat","html_url":"https://github.com/ameygat","followers_url":"https://api.github.com/users/ameygat/followers","following_url":"https://api.github.com/users/ameygat/following{/other_user}","gists_url":"https://api.github.com/users/ameygat/gists{/gist_id}","starred_url":"https://api.github.com/users/ameygat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ameygat/subscriptions","organizations_url":"https://api.github.com/users/ameygat/orgs","repos_url":"https://api.github.com/users/ameygat/repos","events_url":"https://api.github.com/users/ameygat/events{/privacy}","received_events_url":"https://api.github.com/users/ameygat/received_events","type":"User","site_admin":false},"created_at":"2015-04-07T11:05:21Z","updated_at":"2015-04-07T11:05:21Z","body":"If you are able to submit a patch for these bug it would be great."}}