{"action":"created","issue":{"url":"https://api.github.com/repos/rthalley/dnspython/issues/41","labels_url":"https://api.github.com/repos/rthalley/dnspython/issues/41/labels{/name}","comments_url":"https://api.github.com/repos/rthalley/dnspython/issues/41/comments","events_url":"https://api.github.com/repos/rthalley/dnspython/issues/41/events","html_url":"https://github.com/rthalley/dnspython/issues/41","id":20268551,"number":41,"title":"unicode crashes ","user":{"login":"ThomasWaldmann","id":356103,"avatar_url":"https://avatars.githubusercontent.com/u/356103?v=3","gravatar_id":"","url":"https://api.github.com/users/ThomasWaldmann","html_url":"https://github.com/ThomasWaldmann","followers_url":"https://api.github.com/users/ThomasWaldmann/followers","following_url":"https://api.github.com/users/ThomasWaldmann/following{/other_user}","gists_url":"https://api.github.com/users/ThomasWaldmann/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasWaldmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasWaldmann/subscriptions","organizations_url":"https://api.github.com/users/ThomasWaldmann/orgs","repos_url":"https://api.github.com/users/ThomasWaldmann/repos","events_url":"https://api.github.com/users/ThomasWaldmann/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasWaldmann/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/rthalley/dnspython/milestones/1","labels_url":"https://api.github.com/repos/rthalley/dnspython/milestones/1/labels","id":697598,"number":1,"title":"1.12","description":"","creator":{"login":"rthalley","id":78507,"avatar_url":"https://avatars.githubusercontent.com/u/78507?v=3","gravatar_id":"","url":"https://api.github.com/users/rthalley","html_url":"https://github.com/rthalley","followers_url":"https://api.github.com/users/rthalley/followers","following_url":"https://api.github.com/users/rthalley/following{/other_user}","gists_url":"https://api.github.com/users/rthalley/gists{/gist_id}","starred_url":"https://api.github.com/users/rthalley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rthalley/subscriptions","organizations_url":"https://api.github.com/users/rthalley/orgs","repos_url":"https://api.github.com/users/rthalley/repos","events_url":"https://api.github.com/users/rthalley/events{/privacy}","received_events_url":"https://api.github.com/users/rthalley/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":0,"state":"open","created_at":"2014-06-21T16:29:45Z","updated_at":"2014-06-21T16:33:22Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2013-09-30T15:06:47Z","updated_at":"2015-02-17T16:33:02Z","closed_at":null,"body":"See XXX in line 199 (_update function):\r\n\r\nhttps://github.com/asmaps/nsupdate.info/blob/master/nsupdate/api/views.py#L199\r\n\r\nIn line 210, it calls dnstools.update:\r\n\r\nhttps://github.com/asmaps/nsupdate.info/blob/master/nsupdate/main/dnstools.py#L82\r\n\r\nThat calls misc dnspython functions and one of them crashes if it gets unicode because of some wrong isinstance(x, str) [not: isinstance(x, (str, unicode))] that just checks for str (we use 2.7).\r\n\r\nI was in a hurry and didn't save the traceback or other infos and currently I am not allowed to change the production system where it happened nor could I reproduce locally easily. :( So, sorry if I can't give more infos right now.\r\n\r\nBut maybe you want to check these isinstance(str) in general, that bug might be at multiple places.\r\n"},"comment":{"url":"https://api.github.com/repos/rthalley/dnspython/issues/comments/74698493","html_url":"https://github.com/rthalley/dnspython/issues/41#issuecomment-74698493","issue_url":"https://api.github.com/repos/rthalley/dnspython/issues/41","id":74698493,"user":{"login":"ThomasWaldmann","id":356103,"avatar_url":"https://avatars.githubusercontent.com/u/356103?v=3","gravatar_id":"","url":"https://api.github.com/users/ThomasWaldmann","html_url":"https://github.com/ThomasWaldmann","followers_url":"https://api.github.com/users/ThomasWaldmann/followers","following_url":"https://api.github.com/users/ThomasWaldmann/following{/other_user}","gists_url":"https://api.github.com/users/ThomasWaldmann/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasWaldmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasWaldmann/subscriptions","organizations_url":"https://api.github.com/users/ThomasWaldmann/orgs","repos_url":"https://api.github.com/users/ThomasWaldmann/repos","events_url":"https://api.github.com/users/ThomasWaldmann/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasWaldmann/received_events","type":"User","site_admin":false},"created_at":"2015-02-17T16:33:02Z","updated_at":"2015-02-17T16:33:02Z","body":"was there any work on this or shall I try to get more information?"}}