{"action":"created","issue":{"url":"https://api.github.com/repos/nodegit/nodegit/issues/788","labels_url":"https://api.github.com/repos/nodegit/nodegit/issues/788/labels{/name}","comments_url":"https://api.github.com/repos/nodegit/nodegit/issues/788/comments","events_url":"https://api.github.com/repos/nodegit/nodegit/issues/788/events","html_url":"https://github.com/nodegit/nodegit/issues/788","id":117553534,"number":788,"title":"Cherrypick.cherrypick() requires options parameter","user":{"login":"Turbo87","id":141300,"avatar_url":"https://avatars.githubusercontent.com/u/141300?v=3","gravatar_id":"","url":"https://api.github.com/users/Turbo87","html_url":"https://github.com/Turbo87","followers_url":"https://api.github.com/users/Turbo87/followers","following_url":"https://api.github.com/users/Turbo87/following{/other_user}","gists_url":"https://api.github.com/users/Turbo87/gists{/gist_id}","starred_url":"https://api.github.com/users/Turbo87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Turbo87/subscriptions","organizations_url":"https://api.github.com/users/Turbo87/orgs","repos_url":"https://api.github.com/users/Turbo87/repos","events_url":"https://api.github.com/users/Turbo87/events{/privacy}","received_events_url":"https://api.github.com/users/Turbo87/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-11-18T10:07:09Z","updated_at":"2015-11-18T17:10:18Z","closed_at":null,"body":"It seems that the `options` parameter of the `Cherrypick.cherrypick()` function is actually required. If I call that function without it, the returned `Promise` is rejected with:\r\n\r\n```\r\nError: CherrypickOptions cherrypick_options is required.\r\n at Error (native)\r\n at Promise.denodeify (.../node_modules/nodegit/node_modules/nodegit-promise/lib/node-extensions.js:24:20)\r\n at tryCallTwo (.../node_modules/nodegit/node_modules/nodegit-promise/lib/core.js:45:5)\r\n at doResolve (.../node_modules/nodegit/node_modules/nodegit-promise/lib/core.js:173:13)\r\n at new Promise (.../node_modules/nodegit/node_modules/nodegit-promise/lib/core.js:65:3)\r\n at Object.Promise.denodeify (.../node_modules/nodegit/node_modules/nodegit-promise/lib/node-extensions.js:19:12)\r\n at Object.Cherrypick.cherrypick (.../node_modules/nodegit/lib/cherrypick.js:42:22)\r\n```"},"comment":{"url":"https://api.github.com/repos/nodegit/nodegit/issues/comments/157781213","html_url":"https://github.com/nodegit/nodegit/issues/788#issuecomment-157781213","issue_url":"https://api.github.com/repos/nodegit/nodegit/issues/788","id":157781213,"user":{"login":"maxkorp","id":1302526,"avatar_url":"https://avatars.githubusercontent.com/u/1302526?v=3","gravatar_id":"","url":"https://api.github.com/users/maxkorp","html_url":"https://github.com/maxkorp","followers_url":"https://api.github.com/users/maxkorp/followers","following_url":"https://api.github.com/users/maxkorp/following{/other_user}","gists_url":"https://api.github.com/users/maxkorp/gists{/gist_id}","starred_url":"https://api.github.com/users/maxkorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxkorp/subscriptions","organizations_url":"https://api.github.com/users/maxkorp/orgs","repos_url":"https://api.github.com/users/maxkorp/repos","events_url":"https://api.github.com/users/maxkorp/events{/privacy}","received_events_url":"https://api.github.com/users/maxkorp/received_events","type":"User","site_admin":false},"created_at":"2015-11-18T17:10:18Z","updated_at":"2015-11-18T17:10:18Z","body":"Well that's disconcerting. It IS normalizing, so it should automatically ensure that an options object is passed in with defaults if you don't pass one in. We'll have to take al ook at this. Can you try passing in an empty object? "}}