{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react-native/issues/991","labels_url":"https://api.github.com/repos/facebook/react-native/issues/991/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/991/comments","events_url":"https://api.github.com/repos/facebook/react-native/issues/991/events","html_url":"https://github.com/facebook/react-native/pull/991","id":70559216,"number":991,"title":"Add support for multiline TextInput via UITextView","user":{"login":"brentvatne","id":90494,"avatar_url":"https://avatars.githubusercontent.com/u/90494?v=3","gravatar_id":"","url":"https://api.github.com/users/brentvatne","html_url":"https://github.com/brentvatne","followers_url":"https://api.github.com/users/brentvatne/followers","following_url":"https://api.github.com/users/brentvatne/following{/other_user}","gists_url":"https://api.github.com/users/brentvatne/gists{/gist_id}","starred_url":"https://api.github.com/users/brentvatne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brentvatne/subscriptions","organizations_url":"https://api.github.com/users/brentvatne/orgs","repos_url":"https://api.github.com/users/brentvatne/repos","events_url":"https://api.github.com/users/brentvatne/events{/privacy}","received_events_url":"https://api.github.com/users/brentvatne/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7"},{"url":"https://api.github.com/repos/facebook/react-native/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-04-24T01:40:26Z","updated_at":"2015-04-25T02:06:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/991","html_url":"https://github.com/facebook/react-native/pull/991","diff_url":"https://github.com/facebook/react-native/pull/991.diff","patch_url":"https://github.com/facebook/react-native/pull/991.patch"},"body":"@nicklockwood - Could I get a review of this?\r\n\r\nJust took `RCTTextField` and ported it from `UITextField` to `UITextView` as you mentioned in another discussion, and removed any `UITextField` specific attributes.\r\n\r\n- How do you think this should behave when there are subviews?\r\n- Do you know how we can respond to the `UIControlEventEditingDidEndOnExit` event to respond to submit? Because `UITextView` isn't a `UIControl` we can't just use `addTarget` with `UIControlEventEditingDidEndOnExit`.\r\n- Any other feedback?\r\n\r\nStill going to look over the `UITextView` docs in more detail and make sure we expose all important options, and add it to the UIExplorer example, just putting this out here for feedback.\r\n\r\n![multiline](https://cloud.githubusercontent.com/assets/90494/7310854/32174d6a-e9e8-11e4-919e-71e54cf3c739.gif)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/facebook/react-native/issues/comments/96121350","html_url":"https://github.com/facebook/react-native/pull/991#issuecomment-96121350","issue_url":"https://api.github.com/repos/facebook/react-native/issues/991","id":96121350,"user":{"login":"brentvatne","id":90494,"avatar_url":"https://avatars.githubusercontent.com/u/90494?v=3","gravatar_id":"","url":"https://api.github.com/users/brentvatne","html_url":"https://github.com/brentvatne","followers_url":"https://api.github.com/users/brentvatne/followers","following_url":"https://api.github.com/users/brentvatne/following{/other_user}","gists_url":"https://api.github.com/users/brentvatne/gists{/gist_id}","starred_url":"https://api.github.com/users/brentvatne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brentvatne/subscriptions","organizations_url":"https://api.github.com/users/brentvatne/orgs","repos_url":"https://api.github.com/users/brentvatne/repos","events_url":"https://api.github.com/users/brentvatne/events{/privacy}","received_events_url":"https://api.github.com/users/brentvatne/received_events","type":"User","site_admin":false},"created_at":"2015-04-25T02:06:23Z","updated_at":"2015-04-25T02:06:23Z","body":"@nicklockwood - having a few issues with getting it to respect padding, both on the placeholder (UILabel as you suggested) and the UITextView.\r\n\r\nOn the UITextView, padding works as expected only when there is text, otherwise it goes a bit nuts:\r\n![placeholder](https://cloud.githubusercontent.com/assets/90494/7331049/d5b40bb2-eab4-11e4-94ad-a1b7e7e3053d.gif)\r\n\r\nOn UILabel, I think all we need to do is have it factor in the contentInsets of the the UITextView, of course UILabel doesn't support and I was wondering what your approach would be.\r\n\r\nThanks!"}}