{"action":"created","comment":{"url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/pulls/comments/32514434","id":32514434,"diff_hunk":"@@ -59,19 +59,23 @@ object created by the ``createMainMenu`` method:\n \n         app.main_menu:\n             class: Knp\\Menu\\MenuItem # the service definition requires setting the class\n-            factory_service: app.menu_builder\n-            factory_method: createMainMenu\n+            factory: [\"@app.menu_builder\", createMainMenu]\n             arguments: [\"@request_stack\"]\n             tags:\n                 - { name: knp_menu.menu, alias: main } # The alias is what is used to retrieve the menu\n \n         # ...\n \n+> \n+\n .. note::\n \n     The menu service must be public as it will be retrieved at runtime to keep\n     it lazy-loaded.\n \n+    If you are using Symfony `2.5` or older version please check the `Using a Factory to Create Services`_","path":"Resources/doc/menu_service.rst","position":20,"original_position":20,"commit_id":"19cb1c24aa7c3a2a867921b97503b85f0990065d","original_commit_id":"19cb1c24aa7c3a2a867921b97503b85f0990065d","user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?v=3","gravatar_id":"","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"body":"this should be a second note, not something in the same note","created_at":"2015-06-16T12:13:38Z","updated_at":"2015-06-16T12:13:38Z","html_url":"https://github.com/KnpLabs/KnpMenuBundle/pull/270#discussion_r32514434","pull_request_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/pulls/270","_links":{"self":{"href":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/pulls/comments/32514434"},"html":{"href":"https://github.com/KnpLabs/KnpMenuBundle/pull/270#discussion_r32514434"},"pull_request":{"href":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/pulls/270"}}},"pull_request":{"url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/pulls/270","id":37165363,"html_url":"https://github.com/KnpLabs/KnpMenuBundle/pull/270","diff_url":"https://github.com/KnpLabs/KnpMenuBundle/pull/270.diff","patch_url":"https://github.com/KnpLabs/KnpMenuBundle/pull/270.patch","issue_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/issues/270","number":270,"state":"open","locked":false,"title":"Fix deprecated errors of dependency injection","user":{"login":"bocharsky-bw","id":3317635,"avatar_url":"https://avatars.githubusercontent.com/u/3317635?v=3","gravatar_id":"","url":"https://api.github.com/users/bocharsky-bw","html_url":"https://github.com/bocharsky-bw","followers_url":"https://api.github.com/users/bocharsky-bw/followers","following_url":"https://api.github.com/users/bocharsky-bw/following{/other_user}","gists_url":"https://api.github.com/users/bocharsky-bw/gists{/gist_id}","starred_url":"https://api.github.com/users/bocharsky-bw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bocharsky-bw/subscriptions","organizations_url":"https://api.github.com/users/bocharsky-bw/orgs","repos_url":"https://api.github.com/users/bocharsky-bw/repos","events_url":"https://api.github.com/users/bocharsky-bw/events{/privacy}","received_events_url":"https://api.github.com/users/bocharsky-bw/received_events","type":"User","site_admin":false},"body":"Fix deprecated errors of dependency injection [using a factory to create services](http://symfony.com/doc/current/components/dependency_injection/factories.html)","created_at":"2015-06-08T15:29:28Z","updated_at":"2015-06-16T12:13:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1e8f70da84f9053a206edf3a39ede04c7b22d8a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/pulls/270/commits","review_comments_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/pulls/270/comments","review_comment_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/issues/270/comments","statuses_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/statuses/19cb1c24aa7c3a2a867921b97503b85f0990065d","head":{"label":"bocharsky-bw:patch-3","ref":"patch-3","sha":"19cb1c24aa7c3a2a867921b97503b85f0990065d","user":{"login":"bocharsky-bw","id":3317635,"avatar_url":"https://avatars.githubusercontent.com/u/3317635?v=3","gravatar_id":"","url":"https://api.github.com/users/bocharsky-bw","html_url":"https://github.com/bocharsky-bw","followers_url":"https://api.github.com/users/bocharsky-bw/followers","following_url":"https://api.github.com/users/bocharsky-bw/following{/other_user}","gists_url":"https://api.github.com/users/bocharsky-bw/gists{/gist_id}","starred_url":"https://api.github.com/users/bocharsky-bw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bocharsky-bw/subscriptions","organizations_url":"https://api.github.com/users/bocharsky-bw/orgs","repos_url":"https://api.github.com/users/bocharsky-bw/repos","events_url":"https://api.github.com/users/bocharsky-bw/events{/privacy}","received_events_url":"https://api.github.com/users/bocharsky-bw/received_events","type":"User","site_admin":false},"repo":{"id":29916226,"name":"KnpMenuBundle","full_name":"bocharsky-bw/KnpMenuBundle","owner":{"login":"bocharsky-bw","id":3317635,"avatar_url":"https://avatars.githubusercontent.com/u/3317635?v=3","gravatar_id":"","url":"https://api.github.com/users/bocharsky-bw","html_url":"https://github.com/bocharsky-bw","followers_url":"https://api.github.com/users/bocharsky-bw/followers","following_url":"https://api.github.com/users/bocharsky-bw/following{/other_user}","gists_url":"https://api.github.com/users/bocharsky-bw/gists{/gist_id}","starred_url":"https://api.github.com/users/bocharsky-bw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bocharsky-bw/subscriptions","organizations_url":"https://api.github.com/users/bocharsky-bw/orgs","repos_url":"https://api.github.com/users/bocharsky-bw/repos","events_url":"https://api.github.com/users/bocharsky-bw/events{/privacy}","received_events_url":"https://api.github.com/users/bocharsky-bw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bocharsky-bw/KnpMenuBundle","description":"Object Oriented menus for your Symfony2 project.","fork":true,"url":"https://api.github.com/repos/bocharsky-bw/KnpMenuBundle","forks_url":"https://api.github.com/repos/bocharsky-bw/KnpMenuBundle/forks","keys_url":"https://api.github.com/repos/bocharsky-bw/KnpMenuBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bocharsky-bw/KnpMenuBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bocharsky-bw/KnpMenuBundle/teams","hooks_url":"https://api.github.com/repos/bocharsky-bw/KnpMenuBundle/hooks","issue_events_url":"https://api.github.com/repos/bocharsky-bw/KnpMenuBundle/issues/events{/number}","events_url":"https://api.github.com/repos/bocharsky-bw/KnpMenuBundle/events","assignees_url":"https://api.github.com/repos/bocharsky-bw/KnpMenuBundle/assignees{/user}","branches_url":"https://api.github.com/repos/bocharsky-bw/KnpMenuBundle/branches{/branch}","tags_url":"https://api.github.com/repos/bocharsky-bw/KnpMenuBundle/tags","blobs_url":"https://api.github.com/repos/bocharsky-bw/KnpMenuBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bocharsky-bw/KnpMenuBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bocharsky-bw/KnpMenuBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/bocharsky-bw/KnpMenuBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bocharsky-bw/KnpMenuBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/bocharsky-bw/KnpMenuBundle/languages","stargazers_url":"https://api.github.com/repos/bocharsky-bw/KnpMenuBundle/stargazers","contributors_url":"https://api.github.com/repos/bocharsky-bw/KnpMenuBundle/contributors","subscribers_url":"https://api.github.com/repos/bocharsky-bw/KnpMenuBundle/subscribers","subscription_url":"https://api.github.com/repos/bocharsky-bw/KnpMenuBundle/subscription","commits_url":"https://api.github.com/repos/bocharsky-bw/KnpMenuBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/bocharsky-bw/KnpMenuBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/bocharsky-bw/KnpMenuBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/bocharsky-bw/KnpMenuBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/bocharsky-bw/KnpMenuBundle/contents/{+path}","compare_url":"https://api.github.com/repos/bocharsky-bw/KnpMenuBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bocharsky-bw/KnpMenuBundle/merges","archive_url":"https://api.github.com/repos/bocharsky-bw/KnpMenuBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bocharsky-bw/KnpMenuBundle/downloads","issues_url":"https://api.github.com/repos/bocharsky-bw/KnpMenuBundle/issues{/number}","pulls_url":"https://api.github.com/repos/bocharsky-bw/KnpMenuBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/bocharsky-bw/KnpMenuBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/bocharsky-bw/KnpMenuBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bocharsky-bw/KnpMenuBundle/labels{/name}","releases_url":"https://api.github.com/repos/bocharsky-bw/KnpMenuBundle/releases{/id}","created_at":"2015-01-27T13:53:23Z","updated_at":"2015-01-27T13:53:24Z","pushed_at":"2015-06-09T14:00:31Z","git_url":"git://github.com/bocharsky-bw/KnpMenuBundle.git","ssh_url":"git@github.com:bocharsky-bw/KnpMenuBundle.git","clone_url":"https://github.com/bocharsky-bw/KnpMenuBundle.git","svn_url":"https://github.com/bocharsky-bw/KnpMenuBundle","homepage":"KnpLabs.com","size":506,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KnpLabs:master","ref":"master","sha":"802e7f67fa3ea6cdaa40bffb96fc5cc83c7c2826","user":{"login":"KnpLabs","id":202732,"avatar_url":"https://avatars.githubusercontent.com/u/202732?v=3","gravatar_id":"","url":"https://api.github.com/users/KnpLabs","html_url":"https://github.com/KnpLabs","followers_url":"https://api.github.com/users/KnpLabs/followers","following_url":"https://api.github.com/users/KnpLabs/following{/other_user}","gists_url":"https://api.github.com/users/KnpLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/KnpLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KnpLabs/subscriptions","organizations_url":"https://api.github.com/users/KnpLabs/orgs","repos_url":"https://api.github.com/users/KnpLabs/repos","events_url":"https://api.github.com/users/KnpLabs/events{/privacy}","received_events_url":"https://api.github.com/users/KnpLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":828595,"name":"KnpMenuBundle","full_name":"KnpLabs/KnpMenuBundle","owner":{"login":"KnpLabs","id":202732,"avatar_url":"https://avatars.githubusercontent.com/u/202732?v=3","gravatar_id":"","url":"https://api.github.com/users/KnpLabs","html_url":"https://github.com/KnpLabs","followers_url":"https://api.github.com/users/KnpLabs/followers","following_url":"https://api.github.com/users/KnpLabs/following{/other_user}","gists_url":"https://api.github.com/users/KnpLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/KnpLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KnpLabs/subscriptions","organizations_url":"https://api.github.com/users/KnpLabs/orgs","repos_url":"https://api.github.com/users/KnpLabs/repos","events_url":"https://api.github.com/users/KnpLabs/events{/privacy}","received_events_url":"https://api.github.com/users/KnpLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KnpLabs/KnpMenuBundle","description":"Object Oriented menus for your Symfony2 project.","fork":false,"url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle","forks_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/forks","keys_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/teams","hooks_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/hooks","issue_events_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/issues/events{/number}","events_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/events","assignees_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/assignees{/user}","branches_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/branches{/branch}","tags_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/tags","blobs_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/languages","stargazers_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/stargazers","contributors_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/contributors","subscribers_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/subscribers","subscription_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/subscription","commits_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/contents/{+path}","compare_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/merges","archive_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/downloads","issues_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/issues{/number}","pulls_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/labels{/name}","releases_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/releases{/id}","created_at":"2010-08-10T12:46:57Z","updated_at":"2015-06-16T07:50:54Z","pushed_at":"2015-06-16T10:10:47Z","git_url":"git://github.com/KnpLabs/KnpMenuBundle.git","ssh_url":"git@github.com:KnpLabs/KnpMenuBundle.git","clone_url":"https://github.com/KnpLabs/KnpMenuBundle.git","svn_url":"https://github.com/KnpLabs/KnpMenuBundle","homepage":"KnpLabs.com","size":1211,"stargazers_count":474,"watchers_count":474,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":176,"mirror_url":null,"open_issues_count":17,"forks":176,"open_issues":17,"watchers":474,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/pulls/270"},"html":{"href":"https://github.com/KnpLabs/KnpMenuBundle/pull/270"},"issue":{"href":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/issues/270"},"comments":{"href":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/issues/270/comments"},"review_comments":{"href":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/pulls/270/comments"},"review_comment":{"href":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/pulls/270/commits"},"statuses":{"href":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/statuses/19cb1c24aa7c3a2a867921b97503b85f0990065d"}}}}