{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/hhvm/issues/6068","labels_url":"https://api.github.com/repos/facebook/hhvm/issues/6068/labels{/name}","comments_url":"https://api.github.com/repos/facebook/hhvm/issues/6068/comments","events_url":"https://api.github.com/repos/facebook/hhvm/issues/6068/events","html_url":"https://github.com/facebook/hhvm/pull/6068","id":101893379,"number":6068,"title":"Adding DNS cache feature (disabled by default)","user":{"login":"dpaneda","id":715979,"avatar_url":"https://avatars.githubusercontent.com/u/715979?v=3","gravatar_id":"","url":"https://api.github.com/users/dpaneda","html_url":"https://github.com/dpaneda","followers_url":"https://api.github.com/users/dpaneda/followers","following_url":"https://api.github.com/users/dpaneda/following{/other_user}","gists_url":"https://api.github.com/users/dpaneda/gists{/gist_id}","starred_url":"https://api.github.com/users/dpaneda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpaneda/subscriptions","organizations_url":"https://api.github.com/users/dpaneda/orgs","repos_url":"https://api.github.com/users/dpaneda/repos","events_url":"https://api.github.com/users/dpaneda/events{/privacy}","received_events_url":"https://api.github.com/users/dpaneda/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/hhvm/labels/CLA%20Signed","name":"CLA Signed","color":"009900"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-19T13:26:59Z","updated_at":"2015-08-19T13:29:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/hhvm/pulls/6068","html_url":"https://github.com/facebook/hhvm/pull/6068","diff_url":"https://github.com/facebook/hhvm/pull/6068.diff","patch_url":"https://github.com/facebook/hhvm/pull/6068.patch"},"body":"This fix #5927\r\n\r\nThe change is a little intrusive, but it leads to cleaner code.\r\nThe calls to safe_gethostbyname are now changed to cached_gethostbyname.\r\nThe cache is implemented with a thread-local map and this map is accessed every\r\ntime a DNS resolution is issued.\r\nIf the cache is deactivated, the map is cleared before each DNS resolution\r\n(effectively negating the cache).\r\n\r\nIf the cache is enabled, the entries are considered stale after TTL seconds and\r\nthe next DNS resolution triggers a reload.\r\n\r\nRelated config entries (already on the documentation):\r\n  * hhvm.server.dns_cache.enable (default: false)\r\n  * hhvm.server.dns_cache.ttl (default: 60)"},"comment":{"url":"https://api.github.com/repos/facebook/hhvm/issues/comments/132597178","html_url":"https://github.com/facebook/hhvm/pull/6068#issuecomment-132597178","issue_url":"https://api.github.com/repos/facebook/hhvm/issues/6068","id":132597178,"user":{"login":"facebook-github-bot","id":6422482,"avatar_url":"https://avatars.githubusercontent.com/u/6422482?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook-github-bot","html_url":"https://github.com/facebook-github-bot","followers_url":"https://api.github.com/users/facebook-github-bot/followers","following_url":"https://api.github.com/users/facebook-github-bot/following{/other_user}","gists_url":"https://api.github.com/users/facebook-github-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook-github-bot/subscriptions","organizations_url":"https://api.github.com/users/facebook-github-bot/orgs","repos_url":"https://api.github.com/users/facebook-github-bot/repos","events_url":"https://api.github.com/users/facebook-github-bot/events{/privacy}","received_events_url":"https://api.github.com/users/facebook-github-bot/received_events","type":"User","site_admin":false},"created_at":"2015-08-19T13:29:13Z","updated_at":"2015-08-19T13:29:13Z","body":"This pull request has been imported into Phabricator, and discussion and review of the diff will take place at https://reviews.facebook.net/D44931"}}