{"action":"closed","number":150,"pull_request":{"url":"https://api.github.com/repos/papyros/papyros-shell/pulls/150","id":43105865,"html_url":"https://github.com/papyros/papyros-shell/pull/150","diff_url":"https://github.com/papyros/papyros-shell/pull/150.diff","patch_url":"https://github.com/papyros/papyros-shell/pull/150.patch","issue_url":"https://api.github.com/repos/papyros/papyros-shell/issues/150","number":150,"state":"closed","locked":false,"title":"Fix rounding error when getting the sound volume from QML","user":{"login":"29jm","id":6154077,"avatar_url":"https://avatars.githubusercontent.com/u/6154077?v=3","gravatar_id":"","url":"https://api.github.com/users/29jm","html_url":"https://github.com/29jm","followers_url":"https://api.github.com/users/29jm/followers","following_url":"https://api.github.com/users/29jm/following{/other_user}","gists_url":"https://api.github.com/users/29jm/gists{/gist_id}","starred_url":"https://api.github.com/users/29jm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/29jm/subscriptions","organizations_url":"https://api.github.com/users/29jm/orgs","repos_url":"https://api.github.com/users/29jm/repos","events_url":"https://api.github.com/users/29jm/events{/privacy}","received_events_url":"https://api.github.com/users/29jm/received_events","type":"User","site_admin":false},"body":"This fixes a bug appearing with PR #134 : the getter for sound.master was returning an off by one value. It also changes the types used in the calculation from float to double for consistency with the Sound::setMaster() method.","created_at":"2015-08-22T16:20:39Z","updated_at":"2015-08-28T01:10:17Z","closed_at":"2015-08-28T01:10:17Z","merged_at":null,"merge_commit_sha":"288a1d121971010d87ebb0935ca99024dae0bfc0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/papyros/papyros-shell/pulls/150/commits","review_comments_url":"https://api.github.com/repos/papyros/papyros-shell/pulls/150/comments","review_comment_url":"https://api.github.com/repos/papyros/papyros-shell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/papyros/papyros-shell/issues/150/comments","statuses_url":"https://api.github.com/repos/papyros/papyros-shell/statuses/27710427036d0c92b039da9cb86c175ef26c9d4d","head":{"label":"29jm:fix/sound","ref":"fix/sound","sha":"27710427036d0c92b039da9cb86c175ef26c9d4d","user":{"login":"29jm","id":6154077,"avatar_url":"https://avatars.githubusercontent.com/u/6154077?v=3","gravatar_id":"","url":"https://api.github.com/users/29jm","html_url":"https://github.com/29jm","followers_url":"https://api.github.com/users/29jm/followers","following_url":"https://api.github.com/users/29jm/following{/other_user}","gists_url":"https://api.github.com/users/29jm/gists{/gist_id}","starred_url":"https://api.github.com/users/29jm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/29jm/subscriptions","organizations_url":"https://api.github.com/users/29jm/orgs","repos_url":"https://api.github.com/users/29jm/repos","events_url":"https://api.github.com/users/29jm/events{/privacy}","received_events_url":"https://api.github.com/users/29jm/received_events","type":"User","site_admin":false},"repo":{"id":40989788,"name":"papyros-shell","full_name":"29jm/papyros-shell","owner":{"login":"29jm","id":6154077,"avatar_url":"https://avatars.githubusercontent.com/u/6154077?v=3","gravatar_id":"","url":"https://api.github.com/users/29jm","html_url":"https://github.com/29jm","followers_url":"https://api.github.com/users/29jm/followers","following_url":"https://api.github.com/users/29jm/following{/other_user}","gists_url":"https://api.github.com/users/29jm/gists{/gist_id}","starred_url":"https://api.github.com/users/29jm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/29jm/subscriptions","organizations_url":"https://api.github.com/users/29jm/orgs","repos_url":"https://api.github.com/users/29jm/repos","events_url":"https://api.github.com/users/29jm/events{/privacy}","received_events_url":"https://api.github.com/users/29jm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/29jm/papyros-shell","description":"The desktop shell for Papyros, built using QtQuick and QtCompositor as a compositor for Wayland.","fork":true,"url":"https://api.github.com/repos/29jm/papyros-shell","forks_url":"https://api.github.com/repos/29jm/papyros-shell/forks","keys_url":"https://api.github.com/repos/29jm/papyros-shell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/29jm/papyros-shell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/29jm/papyros-shell/teams","hooks_url":"https://api.github.com/repos/29jm/papyros-shell/hooks","issue_events_url":"https://api.github.com/repos/29jm/papyros-shell/issues/events{/number}","events_url":"https://api.github.com/repos/29jm/papyros-shell/events","assignees_url":"https://api.github.com/repos/29jm/papyros-shell/assignees{/user}","branches_url":"https://api.github.com/repos/29jm/papyros-shell/branches{/branch}","tags_url":"https://api.github.com/repos/29jm/papyros-shell/tags","blobs_url":"https://api.github.com/repos/29jm/papyros-shell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/29jm/papyros-shell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/29jm/papyros-shell/git/refs{/sha}","trees_url":"https://api.github.com/repos/29jm/papyros-shell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/29jm/papyros-shell/statuses/{sha}","languages_url":"https://api.github.com/repos/29jm/papyros-shell/languages","stargazers_url":"https://api.github.com/repos/29jm/papyros-shell/stargazers","contributors_url":"https://api.github.com/repos/29jm/papyros-shell/contributors","subscribers_url":"https://api.github.com/repos/29jm/papyros-shell/subscribers","subscription_url":"https://api.github.com/repos/29jm/papyros-shell/subscription","commits_url":"https://api.github.com/repos/29jm/papyros-shell/commits{/sha}","git_commits_url":"https://api.github.com/repos/29jm/papyros-shell/git/commits{/sha}","comments_url":"https://api.github.com/repos/29jm/papyros-shell/comments{/number}","issue_comment_url":"https://api.github.com/repos/29jm/papyros-shell/issues/comments{/number}","contents_url":"https://api.github.com/repos/29jm/papyros-shell/contents/{+path}","compare_url":"https://api.github.com/repos/29jm/papyros-shell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/29jm/papyros-shell/merges","archive_url":"https://api.github.com/repos/29jm/papyros-shell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/29jm/papyros-shell/downloads","issues_url":"https://api.github.com/repos/29jm/papyros-shell/issues{/number}","pulls_url":"https://api.github.com/repos/29jm/papyros-shell/pulls{/number}","milestones_url":"https://api.github.com/repos/29jm/papyros-shell/milestones{/number}","notifications_url":"https://api.github.com/repos/29jm/papyros-shell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/29jm/papyros-shell/labels{/name}","releases_url":"https://api.github.com/repos/29jm/papyros-shell/releases{/id}","created_at":"2015-08-18T18:20:12Z","updated_at":"2015-08-18T18:20:13Z","pushed_at":"2015-08-22T16:13:33Z","git_url":"git://github.com/29jm/papyros-shell.git","ssh_url":"git@github.com:29jm/papyros-shell.git","clone_url":"https://github.com/29jm/papyros-shell.git","svn_url":"https://github.com/29jm/papyros-shell","homepage":"http://papyros.io","size":8283,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"papyros:develop","ref":"develop","sha":"d0f9aaed0facc7afd7379ac4c8f1925f87659d05","user":{"login":"papyros","id":9846794,"avatar_url":"https://avatars.githubusercontent.com/u/9846794?v=3","gravatar_id":"","url":"https://api.github.com/users/papyros","html_url":"https://github.com/papyros","followers_url":"https://api.github.com/users/papyros/followers","following_url":"https://api.github.com/users/papyros/following{/other_user}","gists_url":"https://api.github.com/users/papyros/gists{/gist_id}","starred_url":"https://api.github.com/users/papyros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/papyros/subscriptions","organizations_url":"https://api.github.com/users/papyros/orgs","repos_url":"https://api.github.com/users/papyros/repos","events_url":"https://api.github.com/users/papyros/events{/privacy}","received_events_url":"https://api.github.com/users/papyros/received_events","type":"Organization","site_admin":false},"repo":{"id":26883938,"name":"papyros-shell","full_name":"papyros/papyros-shell","owner":{"login":"papyros","id":9846794,"avatar_url":"https://avatars.githubusercontent.com/u/9846794?v=3","gravatar_id":"","url":"https://api.github.com/users/papyros","html_url":"https://github.com/papyros","followers_url":"https://api.github.com/users/papyros/followers","following_url":"https://api.github.com/users/papyros/following{/other_user}","gists_url":"https://api.github.com/users/papyros/gists{/gist_id}","starred_url":"https://api.github.com/users/papyros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/papyros/subscriptions","organizations_url":"https://api.github.com/users/papyros/orgs","repos_url":"https://api.github.com/users/papyros/repos","events_url":"https://api.github.com/users/papyros/events{/privacy}","received_events_url":"https://api.github.com/users/papyros/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/papyros/papyros-shell","description":"The desktop shell for Papyros, built using QtQuick and QtCompositor as a compositor for Wayland.","fork":false,"url":"https://api.github.com/repos/papyros/papyros-shell","forks_url":"https://api.github.com/repos/papyros/papyros-shell/forks","keys_url":"https://api.github.com/repos/papyros/papyros-shell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/papyros/papyros-shell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/papyros/papyros-shell/teams","hooks_url":"https://api.github.com/repos/papyros/papyros-shell/hooks","issue_events_url":"https://api.github.com/repos/papyros/papyros-shell/issues/events{/number}","events_url":"https://api.github.com/repos/papyros/papyros-shell/events","assignees_url":"https://api.github.com/repos/papyros/papyros-shell/assignees{/user}","branches_url":"https://api.github.com/repos/papyros/papyros-shell/branches{/branch}","tags_url":"https://api.github.com/repos/papyros/papyros-shell/tags","blobs_url":"https://api.github.com/repos/papyros/papyros-shell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/papyros/papyros-shell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/papyros/papyros-shell/git/refs{/sha}","trees_url":"https://api.github.com/repos/papyros/papyros-shell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/papyros/papyros-shell/statuses/{sha}","languages_url":"https://api.github.com/repos/papyros/papyros-shell/languages","stargazers_url":"https://api.github.com/repos/papyros/papyros-shell/stargazers","contributors_url":"https://api.github.com/repos/papyros/papyros-shell/contributors","subscribers_url":"https://api.github.com/repos/papyros/papyros-shell/subscribers","subscription_url":"https://api.github.com/repos/papyros/papyros-shell/subscription","commits_url":"https://api.github.com/repos/papyros/papyros-shell/commits{/sha}","git_commits_url":"https://api.github.com/repos/papyros/papyros-shell/git/commits{/sha}","comments_url":"https://api.github.com/repos/papyros/papyros-shell/comments{/number}","issue_comment_url":"https://api.github.com/repos/papyros/papyros-shell/issues/comments{/number}","contents_url":"https://api.github.com/repos/papyros/papyros-shell/contents/{+path}","compare_url":"https://api.github.com/repos/papyros/papyros-shell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/papyros/papyros-shell/merges","archive_url":"https://api.github.com/repos/papyros/papyros-shell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/papyros/papyros-shell/downloads","issues_url":"https://api.github.com/repos/papyros/papyros-shell/issues{/number}","pulls_url":"https://api.github.com/repos/papyros/papyros-shell/pulls{/number}","milestones_url":"https://api.github.com/repos/papyros/papyros-shell/milestones{/number}","notifications_url":"https://api.github.com/repos/papyros/papyros-shell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/papyros/papyros-shell/labels{/name}","releases_url":"https://api.github.com/repos/papyros/papyros-shell/releases{/id}","created_at":"2014-11-19T22:07:13Z","updated_at":"2015-08-27T06:19:05Z","pushed_at":"2015-08-28T01:10:16Z","git_url":"git://github.com/papyros/papyros-shell.git","ssh_url":"git@github.com:papyros/papyros-shell.git","clone_url":"https://github.com/papyros/papyros-shell.git","svn_url":"https://github.com/papyros/papyros-shell","homepage":"http://papyros.io","size":9215,"stargazers_count":798,"watchers_count":798,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":51,"forks":42,"open_issues":51,"watchers":798,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/papyros/papyros-shell/pulls/150"},"html":{"href":"https://github.com/papyros/papyros-shell/pull/150"},"issue":{"href":"https://api.github.com/repos/papyros/papyros-shell/issues/150"},"comments":{"href":"https://api.github.com/repos/papyros/papyros-shell/issues/150/comments"},"review_comments":{"href":"https://api.github.com/repos/papyros/papyros-shell/pulls/150/comments"},"review_comment":{"href":"https://api.github.com/repos/papyros/papyros-shell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/papyros/papyros-shell/pulls/150/commits"},"statuses":{"href":"https://api.github.com/repos/papyros/papyros-shell/statuses/27710427036d0c92b039da9cb86c175ef26c9d4d"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}