{"action":"closed","number":5,"pull_request":{"url":"https://api.github.com/repos/martinjw/Holiday/pulls/5","id":39074696,"html_url":"https://github.com/martinjw/Holiday/pull/5","diff_url":"https://github.com/martinjw/Holiday/pull/5.diff","patch_url":"https://github.com/martinjw/Holiday/pull/5.patch","issue_url":"https://api.github.com/repos/martinjw/Holiday/issues/5","number":5,"state":"closed","locked":false,"title":"Add previous working day method","user":{"login":"jcdekoning","id":3295687,"avatar_url":"https://avatars.githubusercontent.com/u/3295687?v=3","gravatar_id":"","url":"https://api.github.com/users/jcdekoning","html_url":"https://github.com/jcdekoning","followers_url":"https://api.github.com/users/jcdekoning/followers","following_url":"https://api.github.com/users/jcdekoning/following{/other_user}","gists_url":"https://api.github.com/users/jcdekoning/gists{/gist_id}","starred_url":"https://api.github.com/users/jcdekoning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcdekoning/subscriptions","organizations_url":"https://api.github.com/users/jcdekoning/orgs","repos_url":"https://api.github.com/users/jcdekoning/repos","events_url":"https://api.github.com/users/jcdekoning/events{/privacy}","received_events_url":"https://api.github.com/users/jcdekoning/received_events","type":"User","site_admin":false},"body":"@martinjw: Found out that we actually needed to calculate the previous working day before a holiday. So I added this method to the library. You can decide yourself if this is useful functionality. \r\n\r\nTwo additional comments: when only looking a the name NextWorkingDay you expect that it does not return the same date if that day is a working day. So maybe there should be some kind of overload or two seperate methods?\r\n\r\nThe NextWorkingDay and PreviousWorkingDay methods needs to be copied over to each implementation. Maybe a PublicHoliday abstract base class can be useful to avoid these kind of code copies. ","created_at":"2015-07-02T11:54:56Z","updated_at":"2015-07-03T08:26:54Z","closed_at":"2015-07-03T08:26:54Z","merged_at":"2015-07-03T08:26:54Z","merge_commit_sha":"5aca0aad87915c3101d1964154f163c6c9935130","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/martinjw/Holiday/pulls/5/commits","review_comments_url":"https://api.github.com/repos/martinjw/Holiday/pulls/5/comments","review_comment_url":"https://api.github.com/repos/martinjw/Holiday/pulls/comments{/number}","comments_url":"https://api.github.com/repos/martinjw/Holiday/issues/5/comments","statuses_url":"https://api.github.com/repos/martinjw/Holiday/statuses/c3ce8cacb418e0a9241b1174bb707ec8b0ab126c","head":{"label":"jcdekoning:master","ref":"master","sha":"c3ce8cacb418e0a9241b1174bb707ec8b0ab126c","user":{"login":"jcdekoning","id":3295687,"avatar_url":"https://avatars.githubusercontent.com/u/3295687?v=3","gravatar_id":"","url":"https://api.github.com/users/jcdekoning","html_url":"https://github.com/jcdekoning","followers_url":"https://api.github.com/users/jcdekoning/followers","following_url":"https://api.github.com/users/jcdekoning/following{/other_user}","gists_url":"https://api.github.com/users/jcdekoning/gists{/gist_id}","starred_url":"https://api.github.com/users/jcdekoning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcdekoning/subscriptions","organizations_url":"https://api.github.com/users/jcdekoning/orgs","repos_url":"https://api.github.com/users/jcdekoning/repos","events_url":"https://api.github.com/users/jcdekoning/events{/privacy}","received_events_url":"https://api.github.com/users/jcdekoning/received_events","type":"User","site_admin":false},"repo":{"id":38365232,"name":"Holiday","full_name":"jcdekoning/Holiday","owner":{"login":"jcdekoning","id":3295687,"avatar_url":"https://avatars.githubusercontent.com/u/3295687?v=3","gravatar_id":"","url":"https://api.github.com/users/jcdekoning","html_url":"https://github.com/jcdekoning","followers_url":"https://api.github.com/users/jcdekoning/followers","following_url":"https://api.github.com/users/jcdekoning/following{/other_user}","gists_url":"https://api.github.com/users/jcdekoning/gists{/gist_id}","starred_url":"https://api.github.com/users/jcdekoning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcdekoning/subscriptions","organizations_url":"https://api.github.com/users/jcdekoning/orgs","repos_url":"https://api.github.com/users/jcdekoning/repos","events_url":"https://api.github.com/users/jcdekoning/events{/privacy}","received_events_url":"https://api.github.com/users/jcdekoning/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jcdekoning/Holiday","description":"Calculate Public Holidays","fork":true,"url":"https://api.github.com/repos/jcdekoning/Holiday","forks_url":"https://api.github.com/repos/jcdekoning/Holiday/forks","keys_url":"https://api.github.com/repos/jcdekoning/Holiday/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcdekoning/Holiday/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcdekoning/Holiday/teams","hooks_url":"https://api.github.com/repos/jcdekoning/Holiday/hooks","issue_events_url":"https://api.github.com/repos/jcdekoning/Holiday/issues/events{/number}","events_url":"https://api.github.com/repos/jcdekoning/Holiday/events","assignees_url":"https://api.github.com/repos/jcdekoning/Holiday/assignees{/user}","branches_url":"https://api.github.com/repos/jcdekoning/Holiday/branches{/branch}","tags_url":"https://api.github.com/repos/jcdekoning/Holiday/tags","blobs_url":"https://api.github.com/repos/jcdekoning/Holiday/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcdekoning/Holiday/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcdekoning/Holiday/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcdekoning/Holiday/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcdekoning/Holiday/statuses/{sha}","languages_url":"https://api.github.com/repos/jcdekoning/Holiday/languages","stargazers_url":"https://api.github.com/repos/jcdekoning/Holiday/stargazers","contributors_url":"https://api.github.com/repos/jcdekoning/Holiday/contributors","subscribers_url":"https://api.github.com/repos/jcdekoning/Holiday/subscribers","subscription_url":"https://api.github.com/repos/jcdekoning/Holiday/subscription","commits_url":"https://api.github.com/repos/jcdekoning/Holiday/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcdekoning/Holiday/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcdekoning/Holiday/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcdekoning/Holiday/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcdekoning/Holiday/contents/{+path}","compare_url":"https://api.github.com/repos/jcdekoning/Holiday/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcdekoning/Holiday/merges","archive_url":"https://api.github.com/repos/jcdekoning/Holiday/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcdekoning/Holiday/downloads","issues_url":"https://api.github.com/repos/jcdekoning/Holiday/issues{/number}","pulls_url":"https://api.github.com/repos/jcdekoning/Holiday/pulls{/number}","milestones_url":"https://api.github.com/repos/jcdekoning/Holiday/milestones{/number}","notifications_url":"https://api.github.com/repos/jcdekoning/Holiday/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcdekoning/Holiday/labels{/name}","releases_url":"https://api.github.com/repos/jcdekoning/Holiday/releases{/id}","created_at":"2015-07-01T10:31:35Z","updated_at":"2015-07-01T10:31:35Z","pushed_at":"2015-07-02T11:50:31Z","git_url":"git://github.com/jcdekoning/Holiday.git","ssh_url":"git@github.com:jcdekoning/Holiday.git","clone_url":"https://github.com/jcdekoning/Holiday.git","svn_url":"https://github.com/jcdekoning/Holiday","homepage":null,"size":115,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"martinjw:master","ref":"master","sha":"9c24bc2ee8ae025c7b3a5897c61e54f8f8c25295","user":{"login":"martinjw","id":2040281,"avatar_url":"https://avatars.githubusercontent.com/u/2040281?v=3","gravatar_id":"","url":"https://api.github.com/users/martinjw","html_url":"https://github.com/martinjw","followers_url":"https://api.github.com/users/martinjw/followers","following_url":"https://api.github.com/users/martinjw/following{/other_user}","gists_url":"https://api.github.com/users/martinjw/gists{/gist_id}","starred_url":"https://api.github.com/users/martinjw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinjw/subscriptions","organizations_url":"https://api.github.com/users/martinjw/orgs","repos_url":"https://api.github.com/users/martinjw/repos","events_url":"https://api.github.com/users/martinjw/events{/privacy}","received_events_url":"https://api.github.com/users/martinjw/received_events","type":"User","site_admin":false},"repo":{"id":10883937,"name":"Holiday","full_name":"martinjw/Holiday","owner":{"login":"martinjw","id":2040281,"avatar_url":"https://avatars.githubusercontent.com/u/2040281?v=3","gravatar_id":"","url":"https://api.github.com/users/martinjw","html_url":"https://github.com/martinjw","followers_url":"https://api.github.com/users/martinjw/followers","following_url":"https://api.github.com/users/martinjw/following{/other_user}","gists_url":"https://api.github.com/users/martinjw/gists{/gist_id}","starred_url":"https://api.github.com/users/martinjw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinjw/subscriptions","organizations_url":"https://api.github.com/users/martinjw/orgs","repos_url":"https://api.github.com/users/martinjw/repos","events_url":"https://api.github.com/users/martinjw/events{/privacy}","received_events_url":"https://api.github.com/users/martinjw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/martinjw/Holiday","description":"Calculate Public Holidays","fork":false,"url":"https://api.github.com/repos/martinjw/Holiday","forks_url":"https://api.github.com/repos/martinjw/Holiday/forks","keys_url":"https://api.github.com/repos/martinjw/Holiday/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martinjw/Holiday/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martinjw/Holiday/teams","hooks_url":"https://api.github.com/repos/martinjw/Holiday/hooks","issue_events_url":"https://api.github.com/repos/martinjw/Holiday/issues/events{/number}","events_url":"https://api.github.com/repos/martinjw/Holiday/events","assignees_url":"https://api.github.com/repos/martinjw/Holiday/assignees{/user}","branches_url":"https://api.github.com/repos/martinjw/Holiday/branches{/branch}","tags_url":"https://api.github.com/repos/martinjw/Holiday/tags","blobs_url":"https://api.github.com/repos/martinjw/Holiday/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martinjw/Holiday/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martinjw/Holiday/git/refs{/sha}","trees_url":"https://api.github.com/repos/martinjw/Holiday/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martinjw/Holiday/statuses/{sha}","languages_url":"https://api.github.com/repos/martinjw/Holiday/languages","stargazers_url":"https://api.github.com/repos/martinjw/Holiday/stargazers","contributors_url":"https://api.github.com/repos/martinjw/Holiday/contributors","subscribers_url":"https://api.github.com/repos/martinjw/Holiday/subscribers","subscription_url":"https://api.github.com/repos/martinjw/Holiday/subscription","commits_url":"https://api.github.com/repos/martinjw/Holiday/commits{/sha}","git_commits_url":"https://api.github.com/repos/martinjw/Holiday/git/commits{/sha}","comments_url":"https://api.github.com/repos/martinjw/Holiday/comments{/number}","issue_comment_url":"https://api.github.com/repos/martinjw/Holiday/issues/comments{/number}","contents_url":"https://api.github.com/repos/martinjw/Holiday/contents/{+path}","compare_url":"https://api.github.com/repos/martinjw/Holiday/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martinjw/Holiday/merges","archive_url":"https://api.github.com/repos/martinjw/Holiday/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martinjw/Holiday/downloads","issues_url":"https://api.github.com/repos/martinjw/Holiday/issues{/number}","pulls_url":"https://api.github.com/repos/martinjw/Holiday/pulls{/number}","milestones_url":"https://api.github.com/repos/martinjw/Holiday/milestones{/number}","notifications_url":"https://api.github.com/repos/martinjw/Holiday/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martinjw/Holiday/labels{/name}","releases_url":"https://api.github.com/repos/martinjw/Holiday/releases{/id}","created_at":"2013-06-23T12:21:41Z","updated_at":"2015-01-16T20:26:14Z","pushed_at":"2015-07-03T08:26:55Z","git_url":"git://github.com/martinjw/Holiday.git","ssh_url":"git@github.com:martinjw/Holiday.git","clone_url":"https://github.com/martinjw/Holiday.git","svn_url":"https://github.com/martinjw/Holiday","homepage":null,"size":208,"stargazers_count":4,"watchers_count":4,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/martinjw/Holiday/pulls/5"},"html":{"href":"https://github.com/martinjw/Holiday/pull/5"},"issue":{"href":"https://api.github.com/repos/martinjw/Holiday/issues/5"},"comments":{"href":"https://api.github.com/repos/martinjw/Holiday/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/martinjw/Holiday/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/martinjw/Holiday/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/martinjw/Holiday/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/martinjw/Holiday/statuses/c3ce8cacb418e0a9241b1174bb707ec8b0ab126c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"martinjw","id":2040281,"avatar_url":"https://avatars.githubusercontent.com/u/2040281?v=3","gravatar_id":"","url":"https://api.github.com/users/martinjw","html_url":"https://github.com/martinjw","followers_url":"https://api.github.com/users/martinjw/followers","following_url":"https://api.github.com/users/martinjw/following{/other_user}","gists_url":"https://api.github.com/users/martinjw/gists{/gist_id}","starred_url":"https://api.github.com/users/martinjw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinjw/subscriptions","organizations_url":"https://api.github.com/users/martinjw/orgs","repos_url":"https://api.github.com/users/martinjw/repos","events_url":"https://api.github.com/users/martinjw/events{/privacy}","received_events_url":"https://api.github.com/users/martinjw/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":130,"deletions":2,"changed_files":10}}