{"action":"closed","number":4996,"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/4996","id":40306318,"html_url":"https://github.com/neo4j/neo4j/pull/4996","diff_url":"https://github.com/neo4j/neo4j/pull/4996.diff","patch_url":"https://github.com/neo4j/neo4j/pull/4996.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/4996","number":4996,"state":"closed","locked":false,"title":"Removes post commit check for uniqueness constraint","user":{"login":"digitalstain","id":408167,"avatar_url":"https://avatars.githubusercontent.com/u/408167?v=3","gravatar_id":"","url":"https://api.github.com/users/digitalstain","html_url":"https://github.com/digitalstain","followers_url":"https://api.github.com/users/digitalstain/followers","following_url":"https://api.github.com/users/digitalstain/following{/other_user}","gists_url":"https://api.github.com/users/digitalstain/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalstain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalstain/subscriptions","organizations_url":"https://api.github.com/users/digitalstain/orgs","repos_url":"https://api.github.com/users/digitalstain/repos","events_url":"https://api.github.com/users/digitalstain/events{/privacy}","received_events_url":"https://api.github.com/users/digitalstain/received_events","type":"User","site_admin":false},"body":"This commit removes a check that happened on uniqueness indexes\r\n after commit had already occured. This check would ensure that\r\n values added to an index were indeed unique. Given that\r\n locks ensure this invariant before commit begins, it is\r\n not clear why it would be necessary to do so. Moreover,\r\n having exceptions interrupt the transaction application\r\n process can lead to unexpected behaviour.\r\nThe commit also adds a test cases that reproduces the scenario\r\n which made this problem obvious. Since lucene indexes\r\n store only double values, there are some rounding errors\r\n that we have to deal with when storing long values. The\r\n check that was removed would not deal properly with this\r\n case and would lead to exceptions during transaction\r\n application while no constraint was actually being\r\n violated.\r\n\r\nUndoes part of 2b7c813f71e901e8fc7ec3290211ceaecdba75f9","created_at":"2015-07-19T10:34:15Z","updated_at":"2015-07-23T07:05:36Z","closed_at":"2015-07-23T07:05:36Z","merged_at":"2015-07-23T07:05:36Z","merge_commit_sha":"d9759ae0458a266c1fa2310508a5fffc411adc5b","assignee":{"login":"tinwelint","id":187292,"avatar_url":"https://avatars.githubusercontent.com/u/187292?v=3","gravatar_id":"","url":"https://api.github.com/users/tinwelint","html_url":"https://github.com/tinwelint","followers_url":"https://api.github.com/users/tinwelint/followers","following_url":"https://api.github.com/users/tinwelint/following{/other_user}","gists_url":"https://api.github.com/users/tinwelint/gists{/gist_id}","starred_url":"https://api.github.com/users/tinwelint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinwelint/subscriptions","organizations_url":"https://api.github.com/users/tinwelint/orgs","repos_url":"https://api.github.com/users/tinwelint/repos","events_url":"https://api.github.com/users/tinwelint/events{/privacy}","received_events_url":"https://api.github.com/users/tinwelint/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j/pulls/4996/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j/pulls/4996/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/4996/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/bd4ed82dea5e920b66ddd9c974ca8e36e97dff92","head":{"label":"digitalstain:2.2-undo-post-commit-checks","ref":"2.2-undo-post-commit-checks","sha":"bd4ed82dea5e920b66ddd9c974ca8e36e97dff92","user":{"login":"digitalstain","id":408167,"avatar_url":"https://avatars.githubusercontent.com/u/408167?v=3","gravatar_id":"","url":"https://api.github.com/users/digitalstain","html_url":"https://github.com/digitalstain","followers_url":"https://api.github.com/users/digitalstain/followers","following_url":"https://api.github.com/users/digitalstain/following{/other_user}","gists_url":"https://api.github.com/users/digitalstain/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalstain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalstain/subscriptions","organizations_url":"https://api.github.com/users/digitalstain/orgs","repos_url":"https://api.github.com/users/digitalstain/repos","events_url":"https://api.github.com/users/digitalstain/events{/privacy}","received_events_url":"https://api.github.com/users/digitalstain/received_events","type":"User","site_admin":false},"repo":{"id":6756791,"name":"neo4j","full_name":"digitalstain/neo4j","owner":{"login":"digitalstain","id":408167,"avatar_url":"https://avatars.githubusercontent.com/u/408167?v=3","gravatar_id":"","url":"https://api.github.com/users/digitalstain","html_url":"https://github.com/digitalstain","followers_url":"https://api.github.com/users/digitalstain/followers","following_url":"https://api.github.com/users/digitalstain/following{/other_user}","gists_url":"https://api.github.com/users/digitalstain/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalstain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalstain/subscriptions","organizations_url":"https://api.github.com/users/digitalstain/orgs","repos_url":"https://api.github.com/users/digitalstain/repos","events_url":"https://api.github.com/users/digitalstain/events{/privacy}","received_events_url":"https://api.github.com/users/digitalstain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/digitalstain/neo4j","description":"","fork":true,"url":"https://api.github.com/repos/digitalstain/neo4j","forks_url":"https://api.github.com/repos/digitalstain/neo4j/forks","keys_url":"https://api.github.com/repos/digitalstain/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/digitalstain/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/digitalstain/neo4j/teams","hooks_url":"https://api.github.com/repos/digitalstain/neo4j/hooks","issue_events_url":"https://api.github.com/repos/digitalstain/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/digitalstain/neo4j/events","assignees_url":"https://api.github.com/repos/digitalstain/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/digitalstain/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/digitalstain/neo4j/tags","blobs_url":"https://api.github.com/repos/digitalstain/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/digitalstain/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/digitalstain/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/digitalstain/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/digitalstain/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/digitalstain/neo4j/languages","stargazers_url":"https://api.github.com/repos/digitalstain/neo4j/stargazers","contributors_url":"https://api.github.com/repos/digitalstain/neo4j/contributors","subscribers_url":"https://api.github.com/repos/digitalstain/neo4j/subscribers","subscription_url":"https://api.github.com/repos/digitalstain/neo4j/subscription","commits_url":"https://api.github.com/repos/digitalstain/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/digitalstain/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/digitalstain/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/digitalstain/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/digitalstain/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/digitalstain/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/digitalstain/neo4j/merges","archive_url":"https://api.github.com/repos/digitalstain/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/digitalstain/neo4j/downloads","issues_url":"https://api.github.com/repos/digitalstain/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/digitalstain/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/digitalstain/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/digitalstain/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/digitalstain/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/digitalstain/neo4j/releases{/id}","created_at":"2012-11-19T07:58:53Z","updated_at":"2015-03-29T11:13:29Z","pushed_at":"2015-07-19T15:18:30Z","git_url":"git://github.com/digitalstain/neo4j.git","ssh_url":"git@github.com:digitalstain/neo4j.git","clone_url":"https://github.com/digitalstain/neo4j.git","svn_url":"https://github.com/digitalstain/neo4j","homepage":null,"size":196859,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neo4j:2.2","ref":"2.2","sha":"bad5852aadadc8cdbd29c78a5d322750679ba167","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":6650539,"name":"neo4j","full_name":"neo4j/neo4j","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j","description":"Graphs for Everyone","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j","forks_url":"https://api.github.com/repos/neo4j/neo4j/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j/releases{/id}","created_at":"2012-11-12T08:46:15Z","updated_at":"2015-07-22T23:08:43Z","pushed_at":"2015-07-23T07:05:36Z","git_url":"git://github.com/neo4j/neo4j.git","ssh_url":"git@github.com:neo4j/neo4j.git","clone_url":"https://github.com/neo4j/neo4j.git","svn_url":"https://github.com/neo4j/neo4j","homepage":"http://neo4j.com","size":478628,"stargazers_count":1837,"watchers_count":1837,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":717,"mirror_url":null,"open_issues_count":470,"forks":717,"open_issues":470,"watchers":1837,"default_branch":"2.3"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/4996"},"html":{"href":"https://github.com/neo4j/neo4j/pull/4996"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/4996"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/4996/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/4996/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/4996/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j/statuses/bd4ed82dea5e920b66ddd9c974ca8e36e97dff92"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tinwelint","id":187292,"avatar_url":"https://avatars.githubusercontent.com/u/187292?v=3","gravatar_id":"","url":"https://api.github.com/users/tinwelint","html_url":"https://github.com/tinwelint","followers_url":"https://api.github.com/users/tinwelint/followers","following_url":"https://api.github.com/users/tinwelint/following{/other_user}","gists_url":"https://api.github.com/users/tinwelint/gists{/gist_id}","starred_url":"https://api.github.com/users/tinwelint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinwelint/subscriptions","organizations_url":"https://api.github.com/users/tinwelint/orgs","repos_url":"https://api.github.com/users/tinwelint/repos","events_url":"https://api.github.com/users/tinwelint/events{/privacy}","received_events_url":"https://api.github.com/users/tinwelint/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"commits":1,"additions":29,"deletions":71,"changed_files":4}}