{"action":"created","issue":{"url":"https://api.github.com/repos/brianium/paratest/issues/154","labels_url":"https://api.github.com/repos/brianium/paratest/issues/154/labels{/name}","comments_url":"https://api.github.com/repos/brianium/paratest/issues/154/comments","events_url":"https://api.github.com/repos/brianium/paratest/issues/154/events","html_url":"https://github.com/brianium/paratest/pull/154","id":57558477,"number":154,"title":"@dataProvider tests parallelization in functional mode","user":{"login":"sormy","id":7675583,"avatar_url":"https://avatars.githubusercontent.com/u/7675583?v=3","gravatar_id":"","url":"https://api.github.com/users/sormy","html_url":"https://github.com/sormy","followers_url":"https://api.github.com/users/sormy/followers","following_url":"https://api.github.com/users/sormy/following{/other_user}","gists_url":"https://api.github.com/users/sormy/gists{/gist_id}","starred_url":"https://api.github.com/users/sormy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sormy/subscriptions","organizations_url":"https://api.github.com/users/sormy/orgs","repos_url":"https://api.github.com/users/sormy/repos","events_url":"https://api.github.com/users/sormy/events{/privacy}","received_events_url":"https://api.github.com/users/sormy/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/brianium/paratest/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/brianium/paratest/labels/PR","name":"PR","color":"000000"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2015-02-13T04:35:41Z","updated_at":"2015-02-19T23:28:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/brianium/paratest/pulls/154","html_url":"https://github.com/brianium/paratest/pull/154","diff_url":"https://github.com/brianium/paratest/pull/154.diff","patch_url":"https://github.com/brianium/paratest/pull/154.patch"},"body":"  * @dataProvider support\r\n  * --filter support (functional mode only)\r\n  * --max-batch-size support (functional mode only)\r\n  * print progress as vanilla phpunit\r\n  * print progress without blank lines on windows default console\r\n  * dump process command line for debug purposes if process do not return any results\r\n  * one failed vanilla test: PHPUnitTest::testStopOnFailurePreventsStartingFurtherTestsAfterFailure\r\n  * no auto tests for new features for now"},"comment":{"url":"https://api.github.com/repos/brianium/paratest/issues/comments/75161283","html_url":"https://github.com/brianium/paratest/pull/154#issuecomment-75161283","issue_url":"https://api.github.com/repos/brianium/paratest/issues/154","id":75161283,"user":{"login":"julianseeger","id":3258762,"avatar_url":"https://avatars.githubusercontent.com/u/3258762?v=3","gravatar_id":"","url":"https://api.github.com/users/julianseeger","html_url":"https://github.com/julianseeger","followers_url":"https://api.github.com/users/julianseeger/followers","following_url":"https://api.github.com/users/julianseeger/following{/other_user}","gists_url":"https://api.github.com/users/julianseeger/gists{/gist_id}","starred_url":"https://api.github.com/users/julianseeger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianseeger/subscriptions","organizations_url":"https://api.github.com/users/julianseeger/orgs","repos_url":"https://api.github.com/users/julianseeger/repos","events_url":"https://api.github.com/users/julianseeger/events{/privacy}","received_events_url":"https://api.github.com/users/julianseeger/received_events","type":"User","site_admin":false},"created_at":"2015-02-19T23:28:20Z","updated_at":"2015-02-19T23:28:20Z","body":"**note on scrutinizer:**\r\nOn #157 , scrutinizer was disabled temporarily, so further commits should pass on scrutinizer and give more senseful feedback.\r\n\r\n**feedback:**\r\nOverall, it looks fine with the tests. Maybe you should consider writing more test on unit level, but this is easier with tdd then when writing them afterwards and especially hard on this project. But it is generally worth it because tests on unit level are more stable.\r\n\r\n**stuff that should be fixed:**\r\n* re-enable the skipped tests in the PHPUnitTest.php\r\n* remove the total count from the ResultPrinter.php (not possible without reported skipped/incompletes)\r\n* and of course refactoring is needed. Especially on SuiteLoader::getMethodBatches\r\n\r\n**stuff to be discussed:**\r\n* probably the default for max-batch-size should be 1. This is the closest to the current behavior.\r\nIt is not even guaranteed that a batch-size>1 is faster because the slow tests are not distributed equally between the batches, so a big batch full of slow tests may be slower than a couple of small, slow batches.\r\n\r\nAgain, thanks for your effort! This a much appreciated and often requested feature. But this process is neccessary to keep some quality standard for the project. And if you think what I'm saying is bs, I'm always to constructive feedback ;)"}}