{"action":"created","comment":{"url":"https://api.github.com/repos/globalize/globalize/pulls/comments/24725549","id":24725549,"diff_hunk":"@@ -73,7 +76,7 @@ def set_fallbacks(locales)\n         fallback_hash[key] = value.presence || [key]\n       end if locales.present?\n \n-      @fallbacks = fallback_hash\n+      Thread.current[:globalize_fallbacks] = fallback_hash","path":"lib/globalize.rb","position":39,"original_position":39,"commit_id":"ebca14b479e4f5eaf101f1f7d02ac2a395b3a154","original_commit_id":"ebca14b479e4f5eaf101f1f7d02ac2a395b3a154","user":{"login":"parndt","id":10128,"avatar_url":"https://avatars.githubusercontent.com/u/10128?v=3","gravatar_id":"","url":"https://api.github.com/users/parndt","html_url":"https://github.com/parndt","followers_url":"https://api.github.com/users/parndt/followers","following_url":"https://api.github.com/users/parndt/following{/other_user}","gists_url":"https://api.github.com/users/parndt/gists{/gist_id}","starred_url":"https://api.github.com/users/parndt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parndt/subscriptions","organizations_url":"https://api.github.com/users/parndt/orgs","repos_url":"https://api.github.com/users/parndt/repos","events_url":"https://api.github.com/users/parndt/events{/privacy}","received_events_url":"https://api.github.com/users/parndt/received_events","type":"User","site_admin":false},"body":"This can't use storage?","created_at":"2015-02-15T20:08:29Z","updated_at":"2015-02-15T20:08:29Z","html_url":"https://github.com/globalize/globalize/pull/413#discussion_r24725549","pull_request_url":"https://api.github.com/repos/globalize/globalize/pulls/413","_links":{"self":{"href":"https://api.github.com/repos/globalize/globalize/pulls/comments/24725549"},"html":{"href":"https://github.com/globalize/globalize/pull/413#discussion_r24725549"},"pull_request":{"href":"https://api.github.com/repos/globalize/globalize/pulls/413"}}},"pull_request":{"url":"https://api.github.com/repos/globalize/globalize/pulls/413","id":29336295,"html_url":"https://github.com/globalize/globalize/pull/413","diff_url":"https://github.com/globalize/globalize/pull/413.diff","patch_url":"https://github.com/globalize/globalize/pull/413.patch","issue_url":"https://api.github.com/repos/globalize/globalize/issues/413","number":413,"state":"open","locked":false,"title":"Make Globalize thread safe by default again.","user":{"login":"simi","id":193936,"avatar_url":"https://avatars.githubusercontent.com/u/193936?v=3","gravatar_id":"","url":"https://api.github.com/users/simi","html_url":"https://github.com/simi","followers_url":"https://api.github.com/users/simi/followers","following_url":"https://api.github.com/users/simi/following{/other_user}","gists_url":"https://api.github.com/users/simi/gists{/gist_id}","starred_url":"https://api.github.com/users/simi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simi/subscriptions","organizations_url":"https://api.github.com/users/simi/orgs","repos_url":"https://api.github.com/users/simi/repos","events_url":"https://api.github.com/users/simi/events{/privacy}","received_events_url":"https://api.github.com/users/simi/received_events","type":"User","site_admin":false},"body":"I think it is easy enough to use custom storage just by overriding storage method on Globalize. I was thinking about getter and setter for that, but proc will be needed there probably and it looks ugly in config.\r\n\r\nhttps://github.com/globalize/globalize/commit/37c19b5f8b19ba14bc89f7237064857d46ad815d :red_circle: fails without https://github.com/globalize/globalize/commit/ebca14b479e4f5eaf101f1f7d02ac2a395b3a154 :green_heart: \r\n\r\nrelated to #390 #374 \r\n\r\nping @mtparet @hube @parndt @Dschee","created_at":"2015-02-15T15:42:22Z","updated_at":"2015-02-15T20:08:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e6a809b35f30869fef4e25e1e796e0caa47a9d6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/globalize/globalize/pulls/413/commits","review_comments_url":"https://api.github.com/repos/globalize/globalize/pulls/413/comments","review_comment_url":"https://api.github.com/repos/globalize/globalize/pulls/comments/{number}","comments_url":"https://api.github.com/repos/globalize/globalize/issues/413/comments","statuses_url":"https://api.github.com/repos/globalize/globalize/statuses/ebca14b479e4f5eaf101f1f7d02ac2a395b3a154","head":{"label":"globalize:multithread","ref":"multithread","sha":"ebca14b479e4f5eaf101f1f7d02ac2a395b3a154","user":{"login":"globalize","id":5650452,"avatar_url":"https://avatars.githubusercontent.com/u/5650452?v=3","gravatar_id":"","url":"https://api.github.com/users/globalize","html_url":"https://github.com/globalize","followers_url":"https://api.github.com/users/globalize/followers","following_url":"https://api.github.com/users/globalize/following{/other_user}","gists_url":"https://api.github.com/users/globalize/gists{/gist_id}","starred_url":"https://api.github.com/users/globalize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/globalize/subscriptions","organizations_url":"https://api.github.com/users/globalize/orgs","repos_url":"https://api.github.com/users/globalize/repos","events_url":"https://api.github.com/users/globalize/events{/privacy}","received_events_url":"https://api.github.com/users/globalize/received_events","type":"Organization","site_admin":false},"repo":{"id":807517,"name":"globalize","full_name":"globalize/globalize","owner":{"login":"globalize","id":5650452,"avatar_url":"https://avatars.githubusercontent.com/u/5650452?v=3","gravatar_id":"","url":"https://api.github.com/users/globalize","html_url":"https://github.com/globalize","followers_url":"https://api.github.com/users/globalize/followers","following_url":"https://api.github.com/users/globalize/following{/other_user}","gists_url":"https://api.github.com/users/globalize/gists{/gist_id}","starred_url":"https://api.github.com/users/globalize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/globalize/subscriptions","organizations_url":"https://api.github.com/users/globalize/orgs","repos_url":"https://api.github.com/users/globalize/repos","events_url":"https://api.github.com/users/globalize/events{/privacy}","received_events_url":"https://api.github.com/users/globalize/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/globalize/globalize","description":"Rails I18n de-facto standard library for ActiveRecord model/data translation.","fork":false,"url":"https://api.github.com/repos/globalize/globalize","forks_url":"https://api.github.com/repos/globalize/globalize/forks","keys_url":"https://api.github.com/repos/globalize/globalize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/globalize/globalize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/globalize/globalize/teams","hooks_url":"https://api.github.com/repos/globalize/globalize/hooks","issue_events_url":"https://api.github.com/repos/globalize/globalize/issues/events{/number}","events_url":"https://api.github.com/repos/globalize/globalize/events","assignees_url":"https://api.github.com/repos/globalize/globalize/assignees{/user}","branches_url":"https://api.github.com/repos/globalize/globalize/branches{/branch}","tags_url":"https://api.github.com/repos/globalize/globalize/tags","blobs_url":"https://api.github.com/repos/globalize/globalize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/globalize/globalize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/globalize/globalize/git/refs{/sha}","trees_url":"https://api.github.com/repos/globalize/globalize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/globalize/globalize/statuses/{sha}","languages_url":"https://api.github.com/repos/globalize/globalize/languages","stargazers_url":"https://api.github.com/repos/globalize/globalize/stargazers","contributors_url":"https://api.github.com/repos/globalize/globalize/contributors","subscribers_url":"https://api.github.com/repos/globalize/globalize/subscribers","subscription_url":"https://api.github.com/repos/globalize/globalize/subscription","commits_url":"https://api.github.com/repos/globalize/globalize/commits{/sha}","git_commits_url":"https://api.github.com/repos/globalize/globalize/git/commits{/sha}","comments_url":"https://api.github.com/repos/globalize/globalize/comments{/number}","issue_comment_url":"https://api.github.com/repos/globalize/globalize/issues/comments/{number}","contents_url":"https://api.github.com/repos/globalize/globalize/contents/{+path}","compare_url":"https://api.github.com/repos/globalize/globalize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/globalize/globalize/merges","archive_url":"https://api.github.com/repos/globalize/globalize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/globalize/globalize/downloads","issues_url":"https://api.github.com/repos/globalize/globalize/issues{/number}","pulls_url":"https://api.github.com/repos/globalize/globalize/pulls{/number}","milestones_url":"https://api.github.com/repos/globalize/globalize/milestones{/number}","notifications_url":"https://api.github.com/repos/globalize/globalize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/globalize/globalize/labels{/name}","releases_url":"https://api.github.com/repos/globalize/globalize/releases{/id}","created_at":"2010-07-30T14:30:27Z","updated_at":"2015-02-15T20:06:58Z","pushed_at":"2015-02-15T20:07:43Z","git_url":"git://github.com/globalize/globalize.git","ssh_url":"git@github.com:globalize/globalize.git","clone_url":"https://github.com/globalize/globalize.git","svn_url":"https://github.com/globalize/globalize","homepage":"","size":3316,"stargazers_count":951,"watchers_count":951,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":230,"mirror_url":null,"open_issues_count":52,"forks":230,"open_issues":52,"watchers":951,"default_branch":"master"}},"base":{"label":"globalize:master","ref":"master","sha":"dfa9fc2f565805dda2294cdb1f8d2401aab14199","user":{"login":"globalize","id":5650452,"avatar_url":"https://avatars.githubusercontent.com/u/5650452?v=3","gravatar_id":"","url":"https://api.github.com/users/globalize","html_url":"https://github.com/globalize","followers_url":"https://api.github.com/users/globalize/followers","following_url":"https://api.github.com/users/globalize/following{/other_user}","gists_url":"https://api.github.com/users/globalize/gists{/gist_id}","starred_url":"https://api.github.com/users/globalize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/globalize/subscriptions","organizations_url":"https://api.github.com/users/globalize/orgs","repos_url":"https://api.github.com/users/globalize/repos","events_url":"https://api.github.com/users/globalize/events{/privacy}","received_events_url":"https://api.github.com/users/globalize/received_events","type":"Organization","site_admin":false},"repo":{"id":807517,"name":"globalize","full_name":"globalize/globalize","owner":{"login":"globalize","id":5650452,"avatar_url":"https://avatars.githubusercontent.com/u/5650452?v=3","gravatar_id":"","url":"https://api.github.com/users/globalize","html_url":"https://github.com/globalize","followers_url":"https://api.github.com/users/globalize/followers","following_url":"https://api.github.com/users/globalize/following{/other_user}","gists_url":"https://api.github.com/users/globalize/gists{/gist_id}","starred_url":"https://api.github.com/users/globalize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/globalize/subscriptions","organizations_url":"https://api.github.com/users/globalize/orgs","repos_url":"https://api.github.com/users/globalize/repos","events_url":"https://api.github.com/users/globalize/events{/privacy}","received_events_url":"https://api.github.com/users/globalize/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/globalize/globalize","description":"Rails I18n de-facto standard library for ActiveRecord model/data translation.","fork":false,"url":"https://api.github.com/repos/globalize/globalize","forks_url":"https://api.github.com/repos/globalize/globalize/forks","keys_url":"https://api.github.com/repos/globalize/globalize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/globalize/globalize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/globalize/globalize/teams","hooks_url":"https://api.github.com/repos/globalize/globalize/hooks","issue_events_url":"https://api.github.com/repos/globalize/globalize/issues/events{/number}","events_url":"https://api.github.com/repos/globalize/globalize/events","assignees_url":"https://api.github.com/repos/globalize/globalize/assignees{/user}","branches_url":"https://api.github.com/repos/globalize/globalize/branches{/branch}","tags_url":"https://api.github.com/repos/globalize/globalize/tags","blobs_url":"https://api.github.com/repos/globalize/globalize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/globalize/globalize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/globalize/globalize/git/refs{/sha}","trees_url":"https://api.github.com/repos/globalize/globalize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/globalize/globalize/statuses/{sha}","languages_url":"https://api.github.com/repos/globalize/globalize/languages","stargazers_url":"https://api.github.com/repos/globalize/globalize/stargazers","contributors_url":"https://api.github.com/repos/globalize/globalize/contributors","subscribers_url":"https://api.github.com/repos/globalize/globalize/subscribers","subscription_url":"https://api.github.com/repos/globalize/globalize/subscription","commits_url":"https://api.github.com/repos/globalize/globalize/commits{/sha}","git_commits_url":"https://api.github.com/repos/globalize/globalize/git/commits{/sha}","comments_url":"https://api.github.com/repos/globalize/globalize/comments{/number}","issue_comment_url":"https://api.github.com/repos/globalize/globalize/issues/comments/{number}","contents_url":"https://api.github.com/repos/globalize/globalize/contents/{+path}","compare_url":"https://api.github.com/repos/globalize/globalize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/globalize/globalize/merges","archive_url":"https://api.github.com/repos/globalize/globalize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/globalize/globalize/downloads","issues_url":"https://api.github.com/repos/globalize/globalize/issues{/number}","pulls_url":"https://api.github.com/repos/globalize/globalize/pulls{/number}","milestones_url":"https://api.github.com/repos/globalize/globalize/milestones{/number}","notifications_url":"https://api.github.com/repos/globalize/globalize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/globalize/globalize/labels{/name}","releases_url":"https://api.github.com/repos/globalize/globalize/releases{/id}","created_at":"2010-07-30T14:30:27Z","updated_at":"2015-02-15T20:06:58Z","pushed_at":"2015-02-15T20:07:43Z","git_url":"git://github.com/globalize/globalize.git","ssh_url":"git@github.com:globalize/globalize.git","clone_url":"https://github.com/globalize/globalize.git","svn_url":"https://github.com/globalize/globalize","homepage":"","size":3316,"stargazers_count":951,"watchers_count":951,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":230,"mirror_url":null,"open_issues_count":52,"forks":230,"open_issues":52,"watchers":951,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/globalize/globalize/pulls/413"},"html":{"href":"https://github.com/globalize/globalize/pull/413"},"issue":{"href":"https://api.github.com/repos/globalize/globalize/issues/413"},"comments":{"href":"https://api.github.com/repos/globalize/globalize/issues/413/comments"},"review_comments":{"href":"https://api.github.com/repos/globalize/globalize/pulls/413/comments"},"review_comment":{"href":"https://api.github.com/repos/globalize/globalize/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/globalize/globalize/pulls/413/commits"},"statuses":{"href":"https://api.github.com/repos/globalize/globalize/statuses/ebca14b479e4f5eaf101f1f7d02ac2a395b3a154"}}}}