{"action":"created","comment":{"url":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments/42881323","id":42881323,"diff_hunk":"@@ -53,13 +53,15 @@ class get_item : public find_data\n \t// for immutable itms\n \tget_item(node& dht_node\n \t\t, node_id target\n-\t\t, data_callback const& dcallback);\n+\t\t, data_callback const& dcallback\n+\t\t, nodes_callback const& ncallback);","path":"include/libtorrent/kademlia/get_item.hpp","position":15,"original_position":15,"commit_id":"1d741e5782676abd418204c260004b4cb8316c93","original_commit_id":"1d741e5782676abd418204c260004b4cb8316c93","user":{"login":"thomas-yuan","id":13663657,"avatar_url":"https://avatars.githubusercontent.com/u/13663657?v=3","gravatar_id":"","url":"https://api.github.com/users/thomas-yuan","html_url":"https://github.com/thomas-yuan","followers_url":"https://api.github.com/users/thomas-yuan/followers","following_url":"https://api.github.com/users/thomas-yuan/following{/other_user}","gists_url":"https://api.github.com/users/thomas-yuan/gists{/gist_id}","starred_url":"https://api.github.com/users/thomas-yuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomas-yuan/subscriptions","organizations_url":"https://api.github.com/users/thomas-yuan/orgs","repos_url":"https://api.github.com/users/thomas-yuan/repos","events_url":"https://api.github.com/users/thomas-yuan/events{/privacy}","received_events_url":"https://api.github.com/users/thomas-yuan/received_events","type":"User","site_admin":false},"body":"yes, same as announce/get_peers.","created_at":"2015-10-23T15:52:53Z","updated_at":"2015-10-23T15:52:53Z","html_url":"https://github.com/arvidn/libtorrent/pull/178#discussion_r42881323","pull_request_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/178","_links":{"self":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments/42881323"},"html":{"href":"https://github.com/arvidn/libtorrent/pull/178#discussion_r42881323"},"pull_request":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/178"}}},"pull_request":{"url":"https://api.github.com/repos/arvidn/libtorrent/pulls/178","id":45700463,"html_url":"https://github.com/arvidn/libtorrent/pull/178","diff_url":"https://github.com/arvidn/libtorrent/pull/178.diff","patch_url":"https://github.com/arvidn/libtorrent/pull/178.patch","issue_url":"https://api.github.com/repos/arvidn/libtorrent/issues/178","number":178,"state":"open","locked":false,"title":"Make dht_put_alert more accurate.","user":{"login":"thomas-yuan","id":13663657,"avatar_url":"https://avatars.githubusercontent.com/u/13663657?v=3","gravatar_id":"","url":"https://api.github.com/users/thomas-yuan","html_url":"https://github.com/thomas-yuan","followers_url":"https://api.github.com/users/thomas-yuan/followers","following_url":"https://api.github.com/users/thomas-yuan/following{/other_user}","gists_url":"https://api.github.com/users/thomas-yuan/gists{/gist_id}","starred_url":"https://api.github.com/users/thomas-yuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomas-yuan/subscriptions","organizations_url":"https://api.github.com/users/thomas-yuan/orgs","repos_url":"https://api.github.com/users/thomas-yuan/repos","events_url":"https://api.github.com/users/thomas-yuan/events{/privacy}","received_events_url":"https://api.github.com/users/thomas-yuan/received_events","type":"User","site_admin":false},"body":"When I start using libtorrent DHT at beginning,  I didn't know there is a dht_put.cpp in tools. My colleague found a similar code and we using it as our test app. But seems like 'mput' doesn't work properly. After investigating for a while, I found the reason: the sign_mutable_item used a incorrect private key to sign the data, so actually DHT always get \"invalid signature\" error, but since the dht_put_alert was sent before 'put' and there is no indicator to say the 'put' is success or failed, so as a user, I wouldn't know the put actually was failed. instead, I always get dht_put_alert which seems like the 'put' is done successfully. \r\n\r\nThat's why I created this PR.\r\nTested with dht_put.cpp, and seems work fine for me.\r\n","created_at":"2015-09-22T18:39:04Z","updated_at":"2015-10-23T15:52:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c5e4f9d90f810d43b3b49da485e9868bf1af847","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/178/commits","review_comments_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/178/comments","review_comment_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/arvidn/libtorrent/issues/178/comments","statuses_url":"https://api.github.com/repos/arvidn/libtorrent/statuses/1d741e5782676abd418204c260004b4cb8316c93","head":{"label":"thomas-yuan:put","ref":"put","sha":"1d741e5782676abd418204c260004b4cb8316c93","user":{"login":"thomas-yuan","id":13663657,"avatar_url":"https://avatars.githubusercontent.com/u/13663657?v=3","gravatar_id":"","url":"https://api.github.com/users/thomas-yuan","html_url":"https://github.com/thomas-yuan","followers_url":"https://api.github.com/users/thomas-yuan/followers","following_url":"https://api.github.com/users/thomas-yuan/following{/other_user}","gists_url":"https://api.github.com/users/thomas-yuan/gists{/gist_id}","starred_url":"https://api.github.com/users/thomas-yuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomas-yuan/subscriptions","organizations_url":"https://api.github.com/users/thomas-yuan/orgs","repos_url":"https://api.github.com/users/thomas-yuan/repos","events_url":"https://api.github.com/users/thomas-yuan/events{/privacy}","received_events_url":"https://api.github.com/users/thomas-yuan/received_events","type":"User","site_admin":false},"repo":{"id":41522631,"name":"libtorrent","full_name":"thomas-yuan/libtorrent","owner":{"login":"thomas-yuan","id":13663657,"avatar_url":"https://avatars.githubusercontent.com/u/13663657?v=3","gravatar_id":"","url":"https://api.github.com/users/thomas-yuan","html_url":"https://github.com/thomas-yuan","followers_url":"https://api.github.com/users/thomas-yuan/followers","following_url":"https://api.github.com/users/thomas-yuan/following{/other_user}","gists_url":"https://api.github.com/users/thomas-yuan/gists{/gist_id}","starred_url":"https://api.github.com/users/thomas-yuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomas-yuan/subscriptions","organizations_url":"https://api.github.com/users/thomas-yuan/orgs","repos_url":"https://api.github.com/users/thomas-yuan/repos","events_url":"https://api.github.com/users/thomas-yuan/events{/privacy}","received_events_url":"https://api.github.com/users/thomas-yuan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thomas-yuan/libtorrent","description":"an efficient feature complete C++ bittorrent implementation","fork":true,"url":"https://api.github.com/repos/thomas-yuan/libtorrent","forks_url":"https://api.github.com/repos/thomas-yuan/libtorrent/forks","keys_url":"https://api.github.com/repos/thomas-yuan/libtorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thomas-yuan/libtorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thomas-yuan/libtorrent/teams","hooks_url":"https://api.github.com/repos/thomas-yuan/libtorrent/hooks","issue_events_url":"https://api.github.com/repos/thomas-yuan/libtorrent/issues/events{/number}","events_url":"https://api.github.com/repos/thomas-yuan/libtorrent/events","assignees_url":"https://api.github.com/repos/thomas-yuan/libtorrent/assignees{/user}","branches_url":"https://api.github.com/repos/thomas-yuan/libtorrent/branches{/branch}","tags_url":"https://api.github.com/repos/thomas-yuan/libtorrent/tags","blobs_url":"https://api.github.com/repos/thomas-yuan/libtorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thomas-yuan/libtorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thomas-yuan/libtorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/thomas-yuan/libtorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thomas-yuan/libtorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/thomas-yuan/libtorrent/languages","stargazers_url":"https://api.github.com/repos/thomas-yuan/libtorrent/stargazers","contributors_url":"https://api.github.com/repos/thomas-yuan/libtorrent/contributors","subscribers_url":"https://api.github.com/repos/thomas-yuan/libtorrent/subscribers","subscription_url":"https://api.github.com/repos/thomas-yuan/libtorrent/subscription","commits_url":"https://api.github.com/repos/thomas-yuan/libtorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/thomas-yuan/libtorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/thomas-yuan/libtorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/thomas-yuan/libtorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/thomas-yuan/libtorrent/contents/{+path}","compare_url":"https://api.github.com/repos/thomas-yuan/libtorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thomas-yuan/libtorrent/merges","archive_url":"https://api.github.com/repos/thomas-yuan/libtorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thomas-yuan/libtorrent/downloads","issues_url":"https://api.github.com/repos/thomas-yuan/libtorrent/issues{/number}","pulls_url":"https://api.github.com/repos/thomas-yuan/libtorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/thomas-yuan/libtorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/thomas-yuan/libtorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thomas-yuan/libtorrent/labels{/name}","releases_url":"https://api.github.com/repos/thomas-yuan/libtorrent/releases{/id}","created_at":"2015-08-28T02:33:51Z","updated_at":"2015-09-22T18:45:30Z","pushed_at":"2015-10-20T16:43:22Z","git_url":"git://github.com/thomas-yuan/libtorrent.git","ssh_url":"git@github.com:thomas-yuan/libtorrent.git","clone_url":"https://github.com/thomas-yuan/libtorrent.git","svn_url":"https://github.com/thomas-yuan/libtorrent","homepage":"http://libtorrent.org","size":46859,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"arvidn:master","ref":"master","sha":"b87995fd3e13df09891c0be0d4224c395d6671f7","user":{"login":"arvidn","id":661450,"avatar_url":"https://avatars.githubusercontent.com/u/661450?v=3","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"repo":{"id":36781769,"name":"libtorrent","full_name":"arvidn/libtorrent","owner":{"login":"arvidn","id":661450,"avatar_url":"https://avatars.githubusercontent.com/u/661450?v=3","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arvidn/libtorrent","description":"an efficient feature complete C++ bittorrent implementation","fork":false,"url":"https://api.github.com/repos/arvidn/libtorrent","forks_url":"https://api.github.com/repos/arvidn/libtorrent/forks","keys_url":"https://api.github.com/repos/arvidn/libtorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arvidn/libtorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arvidn/libtorrent/teams","hooks_url":"https://api.github.com/repos/arvidn/libtorrent/hooks","issue_events_url":"https://api.github.com/repos/arvidn/libtorrent/issues/events{/number}","events_url":"https://api.github.com/repos/arvidn/libtorrent/events","assignees_url":"https://api.github.com/repos/arvidn/libtorrent/assignees{/user}","branches_url":"https://api.github.com/repos/arvidn/libtorrent/branches{/branch}","tags_url":"https://api.github.com/repos/arvidn/libtorrent/tags","blobs_url":"https://api.github.com/repos/arvidn/libtorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arvidn/libtorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arvidn/libtorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/arvidn/libtorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arvidn/libtorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/arvidn/libtorrent/languages","stargazers_url":"https://api.github.com/repos/arvidn/libtorrent/stargazers","contributors_url":"https://api.github.com/repos/arvidn/libtorrent/contributors","subscribers_url":"https://api.github.com/repos/arvidn/libtorrent/subscribers","subscription_url":"https://api.github.com/repos/arvidn/libtorrent/subscription","commits_url":"https://api.github.com/repos/arvidn/libtorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/arvidn/libtorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/arvidn/libtorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/arvidn/libtorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/arvidn/libtorrent/contents/{+path}","compare_url":"https://api.github.com/repos/arvidn/libtorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arvidn/libtorrent/merges","archive_url":"https://api.github.com/repos/arvidn/libtorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arvidn/libtorrent/downloads","issues_url":"https://api.github.com/repos/arvidn/libtorrent/issues{/number}","pulls_url":"https://api.github.com/repos/arvidn/libtorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/arvidn/libtorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/arvidn/libtorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arvidn/libtorrent/labels{/name}","releases_url":"https://api.github.com/repos/arvidn/libtorrent/releases{/id}","created_at":"2015-06-03T05:22:03Z","updated_at":"2015-10-20T12:53:17Z","pushed_at":"2015-10-22T03:33:49Z","git_url":"git://github.com/arvidn/libtorrent.git","ssh_url":"git@github.com:arvidn/libtorrent.git","clone_url":"https://github.com/arvidn/libtorrent.git","svn_url":"https://github.com/arvidn/libtorrent","homepage":"http://libtorrent.org","size":68667,"stargazers_count":185,"watchers_count":185,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"open_issues_count":32,"forks":52,"open_issues":32,"watchers":185,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/178"},"html":{"href":"https://github.com/arvidn/libtorrent/pull/178"},"issue":{"href":"https://api.github.com/repos/arvidn/libtorrent/issues/178"},"comments":{"href":"https://api.github.com/repos/arvidn/libtorrent/issues/178/comments"},"review_comments":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/178/comments"},"review_comment":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/178/commits"},"statuses":{"href":"https://api.github.com/repos/arvidn/libtorrent/statuses/1d741e5782676abd418204c260004b4cb8316c93"}}}}