{"action":"created","issue":{"url":"https://api.github.com/repos/adhearsion/has-guarded-handlers/issues/2","labels_url":"https://api.github.com/repos/adhearsion/has-guarded-handlers/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/adhearsion/has-guarded-handlers/issues/2/comments","events_url":"https://api.github.com/repos/adhearsion/has-guarded-handlers/issues/2/events","html_url":"https://github.com/adhearsion/has-guarded-handlers/pull/2","id":30923250,"number":2,"title":"[BUGFIX] Always delete tmp handlers when called regardless of return value","user":{"login":"christophersansone","id":686233,"avatar_url":"https://avatars.githubusercontent.com/u/686233?v=3","gravatar_id":"","url":"https://api.github.com/users/christophersansone","html_url":"https://github.com/christophersansone","followers_url":"https://api.github.com/users/christophersansone/followers","following_url":"https://api.github.com/users/christophersansone/following{/other_user}","gists_url":"https://api.github.com/users/christophersansone/gists{/gist_id}","starred_url":"https://api.github.com/users/christophersansone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christophersansone/subscriptions","organizations_url":"https://api.github.com/users/christophersansone/orgs","repos_url":"https://api.github.com/users/christophersansone/repos","events_url":"https://api.github.com/users/christophersansone/events{/privacy}","received_events_url":"https://api.github.com/users/christophersansone/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2014-04-05T20:25:02Z","updated_at":"2015-02-20T17:37:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/adhearsion/has-guarded-handlers/pulls/2","html_url":"https://github.com/adhearsion/has-guarded-handlers/pull/2","diff_url":"https://github.com/adhearsion/has-guarded-handlers/pull/2.diff","patch_url":"https://github.com/adhearsion/has-guarded-handlers/pull/2.patch"},"body":"I noticed a problem with #register_tmp_handler sometimes firing the same handler multiple times.  The issue had to do with the return value: if falsy, it would re-execute.  This also made it difficult to throw :pass, because it would then only remove the handler if subsequent handler was registered.\r\n\r\nAlso, presumably, the handler may have been deleted even if it was not actually called.\r\n\r\nI simply changed the logic to delete the handler if it was marked as temporary and if it had been called, regardless of its return value."},"comment":{"url":"https://api.github.com/repos/adhearsion/has-guarded-handlers/issues/comments/75284301","html_url":"https://github.com/adhearsion/has-guarded-handlers/pull/2#issuecomment-75284301","issue_url":"https://api.github.com/repos/adhearsion/has-guarded-handlers/issues/2","id":75284301,"user":{"login":"christophersansone","id":686233,"avatar_url":"https://avatars.githubusercontent.com/u/686233?v=3","gravatar_id":"","url":"https://api.github.com/users/christophersansone","html_url":"https://github.com/christophersansone","followers_url":"https://api.github.com/users/christophersansone/followers","following_url":"https://api.github.com/users/christophersansone/following{/other_user}","gists_url":"https://api.github.com/users/christophersansone/gists{/gist_id}","starred_url":"https://api.github.com/users/christophersansone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christophersansone/subscriptions","organizations_url":"https://api.github.com/users/christophersansone/orgs","repos_url":"https://api.github.com/users/christophersansone/repos","events_url":"https://api.github.com/users/christophersansone/events{/privacy}","received_events_url":"https://api.github.com/users/christophersansone/received_events","type":"User","site_admin":false},"created_at":"2015-02-20T17:37:45Z","updated_at":"2015-02-20T17:37:45Z","body":"Okay, should be good to go.  Thanks Ben!"}}