{"action":"created","comment":{"url":"https://api.github.com/repos/n1k0/casperjs/pulls/comments/38520156","id":38520156,"diff_hunk":"@@ -15,11 +15,15 @@ casper.test.begin('Javascript module loading', 1, function(test) {\n \n casper.test.begin('CoffeeScript module loading', 1, function(test) {\n     var csmod;\n-    try {\n-        csmod = require(fs.pathJoin(modroot, 'csmodule'));\n-        test.assertTrue(csmod.ok, 'require() patched version can load a coffeescript module');\n-    } catch (e) {\n-        test.fail('require() patched version can load a coffeescript module');\n+    if (Object.keys(require.extensions).indexOf('.coffee') !== -1) {","path":"tests/suites/require.js","position":9,"original_position":9,"commit_id":"e405c197ab8caa2fb6ddd4a1ee33e87d9608eae2","original_commit_id":"e405c197ab8caa2fb6ddd4a1ee33e87d9608eae2","user":{"login":"n1k0","id":41547,"avatar_url":"https://avatars.githubusercontent.com/u/41547?v=3","gravatar_id":"","url":"https://api.github.com/users/n1k0","html_url":"https://github.com/n1k0","followers_url":"https://api.github.com/users/n1k0/followers","following_url":"https://api.github.com/users/n1k0/following{/other_user}","gists_url":"https://api.github.com/users/n1k0/gists{/gist_id}","starred_url":"https://api.github.com/users/n1k0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n1k0/subscriptions","organizations_url":"https://api.github.com/users/n1k0/orgs","repos_url":"https://api.github.com/users/n1k0/repos","events_url":"https://api.github.com/users/n1k0/events{/privacy}","received_events_url":"https://api.github.com/users/n1k0/received_events","type":"User","site_admin":false},"body":"Also, as there's a single specific test here it's probably worth moving that if statement around the `casper.test` call itself, as it's been done elsewhere already. Adding a comment to explain why we're excluding coffee files might be worthwhile too.","created_at":"2015-09-02T11:02:22Z","updated_at":"2015-09-02T11:02:22Z","html_url":"https://github.com/n1k0/casperjs/pull/1310#discussion_r38520156","pull_request_url":"https://api.github.com/repos/n1k0/casperjs/pulls/1310","_links":{"self":{"href":"https://api.github.com/repos/n1k0/casperjs/pulls/comments/38520156"},"html":{"href":"https://github.com/n1k0/casperjs/pull/1310#discussion_r38520156"},"pull_request":{"href":"https://api.github.com/repos/n1k0/casperjs/pulls/1310"}}},"pull_request":{"url":"https://api.github.com/repos/n1k0/casperjs/pulls/1310","id":43950519,"html_url":"https://github.com/n1k0/casperjs/pull/1310","diff_url":"https://github.com/n1k0/casperjs/pull/1310.diff","patch_url":"https://github.com/n1k0/casperjs/pull/1310.patch","issue_url":"https://api.github.com/repos/n1k0/casperjs/issues/1310","number":1310,"state":"open","locked":false,"title":"PhantomJS v2.x support (maintaining backwards-compatibility)","user":{"login":"hexid","id":141195,"avatar_url":"https://avatars.githubusercontent.com/u/141195?v=3","gravatar_id":"","url":"https://api.github.com/users/hexid","html_url":"https://github.com/hexid","followers_url":"https://api.github.com/users/hexid/followers","following_url":"https://api.github.com/users/hexid/following{/other_user}","gists_url":"https://api.github.com/users/hexid/gists{/gist_id}","starred_url":"https://api.github.com/users/hexid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hexid/subscriptions","organizations_url":"https://api.github.com/users/hexid/orgs","repos_url":"https://api.github.com/users/hexid/repos","events_url":"https://api.github.com/users/hexid/events{/privacy}","received_events_url":"https://api.github.com/users/hexid/received_events","type":"User","site_admin":false},"body":"This PR should allow PhantomJS v2.x to pass most of the selftests.\r\nThere are still some failures that appear to be caused by [regressions](https://github.com/ariya/phantomjs/issues/12506) that should be fixed with [PhantomJS v2.0.1](https://github.com/ariya/phantomjs/issues/12902).\r\n\r\nThis also fixes a few issues that I found while working around failing tests.\r\n\r\nA few points still need to be addressed before this can be considered ready:\r\n\r\n - [ ] Travis needs to be setup for PhantomJS v2.0.0\r\n - [ ] SlimerJS appears to be stalling on the CoffeeScript tests (preexisting?)\r\n - [ ] Laucher needs to be fixed so SlimerJS actually gets tested on Travis\r\n\r\nIf anyone has any comments or concerns, please let me know.\r\n\r\n/cc @n1k0 @mickaelandrieu ","created_at":"2015-09-02T03:27:28Z","updated_at":"2015-09-02T11:02:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1614cef87b75ba6b1df287424f32a436e1f25dbc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/n1k0/casperjs/pulls/1310/commits","review_comments_url":"https://api.github.com/repos/n1k0/casperjs/pulls/1310/comments","review_comment_url":"https://api.github.com/repos/n1k0/casperjs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/n1k0/casperjs/issues/1310/comments","statuses_url":"https://api.github.com/repos/n1k0/casperjs/statuses/e405c197ab8caa2fb6ddd4a1ee33e87d9608eae2","head":{"label":"hexid:phantomjs2-bc","ref":"phantomjs2-bc","sha":"e405c197ab8caa2fb6ddd4a1ee33e87d9608eae2","user":{"login":"hexid","id":141195,"avatar_url":"https://avatars.githubusercontent.com/u/141195?v=3","gravatar_id":"","url":"https://api.github.com/users/hexid","html_url":"https://github.com/hexid","followers_url":"https://api.github.com/users/hexid/followers","following_url":"https://api.github.com/users/hexid/following{/other_user}","gists_url":"https://api.github.com/users/hexid/gists{/gist_id}","starred_url":"https://api.github.com/users/hexid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hexid/subscriptions","organizations_url":"https://api.github.com/users/hexid/orgs","repos_url":"https://api.github.com/users/hexid/repos","events_url":"https://api.github.com/users/hexid/events{/privacy}","received_events_url":"https://api.github.com/users/hexid/received_events","type":"User","site_admin":false},"repo":{"id":12221338,"name":"casperjs","full_name":"hexid/casperjs","owner":{"login":"hexid","id":141195,"avatar_url":"https://avatars.githubusercontent.com/u/141195?v=3","gravatar_id":"","url":"https://api.github.com/users/hexid","html_url":"https://github.com/hexid","followers_url":"https://api.github.com/users/hexid/followers","following_url":"https://api.github.com/users/hexid/following{/other_user}","gists_url":"https://api.github.com/users/hexid/gists{/gist_id}","starred_url":"https://api.github.com/users/hexid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hexid/subscriptions","organizations_url":"https://api.github.com/users/hexid/orgs","repos_url":"https://api.github.com/users/hexid/repos","events_url":"https://api.github.com/users/hexid/events{/privacy}","received_events_url":"https://api.github.com/users/hexid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hexid/casperjs","description":"Navigation scripting & testing utility for PhantomJS and SlimerJS","fork":true,"url":"https://api.github.com/repos/hexid/casperjs","forks_url":"https://api.github.com/repos/hexid/casperjs/forks","keys_url":"https://api.github.com/repos/hexid/casperjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hexid/casperjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hexid/casperjs/teams","hooks_url":"https://api.github.com/repos/hexid/casperjs/hooks","issue_events_url":"https://api.github.com/repos/hexid/casperjs/issues/events{/number}","events_url":"https://api.github.com/repos/hexid/casperjs/events","assignees_url":"https://api.github.com/repos/hexid/casperjs/assignees{/user}","branches_url":"https://api.github.com/repos/hexid/casperjs/branches{/branch}","tags_url":"https://api.github.com/repos/hexid/casperjs/tags","blobs_url":"https://api.github.com/repos/hexid/casperjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hexid/casperjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hexid/casperjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/hexid/casperjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hexid/casperjs/statuses/{sha}","languages_url":"https://api.github.com/repos/hexid/casperjs/languages","stargazers_url":"https://api.github.com/repos/hexid/casperjs/stargazers","contributors_url":"https://api.github.com/repos/hexid/casperjs/contributors","subscribers_url":"https://api.github.com/repos/hexid/casperjs/subscribers","subscription_url":"https://api.github.com/repos/hexid/casperjs/subscription","commits_url":"https://api.github.com/repos/hexid/casperjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/hexid/casperjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/hexid/casperjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/hexid/casperjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/hexid/casperjs/contents/{+path}","compare_url":"https://api.github.com/repos/hexid/casperjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hexid/casperjs/merges","archive_url":"https://api.github.com/repos/hexid/casperjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hexid/casperjs/downloads","issues_url":"https://api.github.com/repos/hexid/casperjs/issues{/number}","pulls_url":"https://api.github.com/repos/hexid/casperjs/pulls{/number}","milestones_url":"https://api.github.com/repos/hexid/casperjs/milestones{/number}","notifications_url":"https://api.github.com/repos/hexid/casperjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hexid/casperjs/labels{/name}","releases_url":"https://api.github.com/repos/hexid/casperjs/releases{/id}","created_at":"2013-08-19T16:16:52Z","updated_at":"2015-08-30T21:07:26Z","pushed_at":"2015-09-02T03:00:26Z","git_url":"git://github.com/hexid/casperjs.git","ssh_url":"git@github.com:hexid/casperjs.git","clone_url":"https://github.com/hexid/casperjs.git","svn_url":"https://github.com/hexid/casperjs","homepage":"http://casperjs.org/","size":8636,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"n1k0:master","ref":"master","sha":"ce871ed966bd9f3c926cda589ef03d52f900db0d","user":{"login":"n1k0","id":41547,"avatar_url":"https://avatars.githubusercontent.com/u/41547?v=3","gravatar_id":"","url":"https://api.github.com/users/n1k0","html_url":"https://github.com/n1k0","followers_url":"https://api.github.com/users/n1k0/followers","following_url":"https://api.github.com/users/n1k0/following{/other_user}","gists_url":"https://api.github.com/users/n1k0/gists{/gist_id}","starred_url":"https://api.github.com/users/n1k0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n1k0/subscriptions","organizations_url":"https://api.github.com/users/n1k0/orgs","repos_url":"https://api.github.com/users/n1k0/repos","events_url":"https://api.github.com/users/n1k0/events{/privacy}","received_events_url":"https://api.github.com/users/n1k0/received_events","type":"User","site_admin":false},"repo":{"id":2328523,"name":"casperjs","full_name":"n1k0/casperjs","owner":{"login":"n1k0","id":41547,"avatar_url":"https://avatars.githubusercontent.com/u/41547?v=3","gravatar_id":"","url":"https://api.github.com/users/n1k0","html_url":"https://github.com/n1k0","followers_url":"https://api.github.com/users/n1k0/followers","following_url":"https://api.github.com/users/n1k0/following{/other_user}","gists_url":"https://api.github.com/users/n1k0/gists{/gist_id}","starred_url":"https://api.github.com/users/n1k0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n1k0/subscriptions","organizations_url":"https://api.github.com/users/n1k0/orgs","repos_url":"https://api.github.com/users/n1k0/repos","events_url":"https://api.github.com/users/n1k0/events{/privacy}","received_events_url":"https://api.github.com/users/n1k0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/n1k0/casperjs","description":"Navigation scripting & testing utility for PhantomJS and SlimerJS","fork":false,"url":"https://api.github.com/repos/n1k0/casperjs","forks_url":"https://api.github.com/repos/n1k0/casperjs/forks","keys_url":"https://api.github.com/repos/n1k0/casperjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/n1k0/casperjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/n1k0/casperjs/teams","hooks_url":"https://api.github.com/repos/n1k0/casperjs/hooks","issue_events_url":"https://api.github.com/repos/n1k0/casperjs/issues/events{/number}","events_url":"https://api.github.com/repos/n1k0/casperjs/events","assignees_url":"https://api.github.com/repos/n1k0/casperjs/assignees{/user}","branches_url":"https://api.github.com/repos/n1k0/casperjs/branches{/branch}","tags_url":"https://api.github.com/repos/n1k0/casperjs/tags","blobs_url":"https://api.github.com/repos/n1k0/casperjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/n1k0/casperjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/n1k0/casperjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/n1k0/casperjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/n1k0/casperjs/statuses/{sha}","languages_url":"https://api.github.com/repos/n1k0/casperjs/languages","stargazers_url":"https://api.github.com/repos/n1k0/casperjs/stargazers","contributors_url":"https://api.github.com/repos/n1k0/casperjs/contributors","subscribers_url":"https://api.github.com/repos/n1k0/casperjs/subscribers","subscription_url":"https://api.github.com/repos/n1k0/casperjs/subscription","commits_url":"https://api.github.com/repos/n1k0/casperjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/n1k0/casperjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/n1k0/casperjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/n1k0/casperjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/n1k0/casperjs/contents/{+path}","compare_url":"https://api.github.com/repos/n1k0/casperjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/n1k0/casperjs/merges","archive_url":"https://api.github.com/repos/n1k0/casperjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/n1k0/casperjs/downloads","issues_url":"https://api.github.com/repos/n1k0/casperjs/issues{/number}","pulls_url":"https://api.github.com/repos/n1k0/casperjs/pulls{/number}","milestones_url":"https://api.github.com/repos/n1k0/casperjs/milestones{/number}","notifications_url":"https://api.github.com/repos/n1k0/casperjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/n1k0/casperjs/labels{/name}","releases_url":"https://api.github.com/repos/n1k0/casperjs/releases{/id}","created_at":"2011-09-05T14:01:40Z","updated_at":"2015-09-02T08:48:02Z","pushed_at":"2015-09-02T03:27:28Z","git_url":"git://github.com/n1k0/casperjs.git","ssh_url":"git@github.com:n1k0/casperjs.git","clone_url":"https://github.com/n1k0/casperjs.git","svn_url":"https://github.com/n1k0/casperjs","homepage":"http://casperjs.org/","size":13653,"stargazers_count":4671,"watchers_count":4671,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":784,"mirror_url":null,"open_issues_count":338,"forks":784,"open_issues":338,"watchers":4671,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/n1k0/casperjs/pulls/1310"},"html":{"href":"https://github.com/n1k0/casperjs/pull/1310"},"issue":{"href":"https://api.github.com/repos/n1k0/casperjs/issues/1310"},"comments":{"href":"https://api.github.com/repos/n1k0/casperjs/issues/1310/comments"},"review_comments":{"href":"https://api.github.com/repos/n1k0/casperjs/pulls/1310/comments"},"review_comment":{"href":"https://api.github.com/repos/n1k0/casperjs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/n1k0/casperjs/pulls/1310/commits"},"statuses":{"href":"https://api.github.com/repos/n1k0/casperjs/statuses/e405c197ab8caa2fb6ddd4a1ee33e87d9608eae2"}}}}