{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/componentkit/issues/386","labels_url":"https://api.github.com/repos/facebook/componentkit/issues/386/labels{/name}","comments_url":"https://api.github.com/repos/facebook/componentkit/issues/386/comments","events_url":"https://api.github.com/repos/facebook/componentkit/issues/386/events","html_url":"https://github.com/facebook/componentkit/pull/386","id":108199212,"number":386,"title":"Fix CKNetworkImageComponent flash when defaultImage changes","user":{"login":"mcohnen","id":524210,"avatar_url":"https://avatars.githubusercontent.com/u/524210?v=3","gravatar_id":"","url":"https://api.github.com/users/mcohnen","html_url":"https://github.com/mcohnen","followers_url":"https://api.github.com/users/mcohnen/followers","following_url":"https://api.github.com/users/mcohnen/following{/other_user}","gists_url":"https://api.github.com/users/mcohnen/gists{/gist_id}","starred_url":"https://api.github.com/users/mcohnen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcohnen/subscriptions","organizations_url":"https://api.github.com/users/mcohnen/orgs","repos_url":"https://api.github.com/users/mcohnen/repos","events_url":"https://api.github.com/users/mcohnen/events{/privacy}","received_events_url":"https://api.github.com/users/mcohnen/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/componentkit/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-24T19:38:25Z","updated_at":"2015-09-24T19:41:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/componentkit/pulls/386","html_url":"https://github.com/facebook/componentkit/pull/386","diff_url":"https://github.com/facebook/componentkit/pull/386.diff","patch_url":"https://github.com/facebook/componentkit/pull/386.patch"},"body":"If we already showed the image in CKNetworkImageComponent, if we download the same URL but the defaultImage is the same, the current code will assume it is a different image and set the defaultImage again and redownload the URL again.\r\nThere is no need to do that if the image is already downloaded. All we have to do is update the specifier to make sure if we need to show the defaultImage, we will use the new one when needed.\r\n\r\nIt is hard to snapshot test this since this is behavior inside CKNetworkComponentView. Since this will require create a new 2nd component and make it use the same view. Happy to create a unit test if this is possible."},"comment":{"url":"https://api.github.com/repos/facebook/componentkit/issues/comments/143029253","html_url":"https://github.com/facebook/componentkit/pull/386#issuecomment-143029253","issue_url":"https://api.github.com/repos/facebook/componentkit/issues/386","id":143029253,"user":{"login":"facebook-github-bot","id":6422482,"avatar_url":"https://avatars.githubusercontent.com/u/6422482?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook-github-bot","html_url":"https://github.com/facebook-github-bot","followers_url":"https://api.github.com/users/facebook-github-bot/followers","following_url":"https://api.github.com/users/facebook-github-bot/following{/other_user}","gists_url":"https://api.github.com/users/facebook-github-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook-github-bot/subscriptions","organizations_url":"https://api.github.com/users/facebook-github-bot/orgs","repos_url":"https://api.github.com/users/facebook-github-bot/repos","events_url":"https://api.github.com/users/facebook-github-bot/events{/privacy}","received_events_url":"https://api.github.com/users/facebook-github-bot/received_events","type":"User","site_admin":false},"created_at":"2015-09-24T19:41:31Z","updated_at":"2015-09-24T19:41:31Z","body":"Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!"}}