{"action":"created","issue":{"url":"https://api.github.com/repos/edx/edx-platform/issues/8358","labels_url":"https://api.github.com/repos/edx/edx-platform/issues/8358/labels{/name}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/8358/comments","events_url":"https://api.github.com/repos/edx/edx-platform/issues/8358/events","html_url":"https://github.com/edx/edx-platform/pull/8358","id":84964950,"number":8358,"title":"Bug - Unicode character in tab number shouldn't return 500 #TNL-2055","user":{"login":"mushtaqak","id":6991154,"avatar_url":"https://avatars.githubusercontent.com/u/6991154?v=3","gravatar_id":"","url":"https://api.github.com/users/mushtaqak","html_url":"https://github.com/mushtaqak","followers_url":"https://api.github.com/users/mushtaqak/followers","following_url":"https://api.github.com/users/mushtaqak/following{/other_user}","gists_url":"https://api.github.com/users/mushtaqak/gists{/gist_id}","starred_url":"https://api.github.com/users/mushtaqak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mushtaqak/subscriptions","organizations_url":"https://api.github.com/users/mushtaqak/orgs","repos_url":"https://api.github.com/users/mushtaqak/repos","events_url":"https://api.github.com/users/mushtaqak/events{/privacy}","received_events_url":"https://api.github.com/users/mushtaqak/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/edx/edx-platform/labels/needs%20triage","name":"needs triage","color":"e11d21"},{"url":"https://api.github.com/repos/edx/edx-platform/labels/open-source-contribution","name":"open-source-contribution","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-04T07:43:56Z","updated_at":"2015-06-04T07:43:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/8358","html_url":"https://github.com/edx/edx-platform/pull/8358","diff_url":"https://github.com/edx/edx-platform/pull/8358.diff","patch_url":"https://github.com/edx/edx-platform/pull/8358.patch"},"body":"For edX pages that have multiple tabs (like [this one|https://courses.edx.org/courses/edX/DemoX.1/2014/courseware/0af8db2309474971bfa70cda98668a30/9c1aacbb2795470e8473b059b59c3344/]), you can add a number to the end of the url to specify which tab the page should open on. Otherwise the last tab you saw will show up, or if you haven't seen the page before, the first tab will show up.\r\n\r\nSo if you go to https://courses.edx.org/courses/edX/DemoX.1/2014/courseware/0af8db2309474971bfa70cda98668a30/9c1aacbb2795470e8473b059b59c3344/2, you'll go to the second tab.\r\n\r\nHowever the bug emerges when you add a special unicode character ( ex : \"%E2%80%9C\" ) to the end of a url instead of a number.\r\n\r\nThe bug emerged due to formatting string with special unicode character outside range(128). So we should use u\\ unicode string instead of normal string in \"Http404('Position {} is not an integer!'.format(position)) \" message"},"comment":{"url":"https://api.github.com/repos/edx/edx-platform/issues/comments/108767924","html_url":"https://github.com/edx/edx-platform/pull/8358#issuecomment-108767924","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/8358","id":108767924,"user":{"login":"edx-webhook","id":8964148,"avatar_url":"https://avatars.githubusercontent.com/u/8964148?v=3","gravatar_id":"","url":"https://api.github.com/users/edx-webhook","html_url":"https://github.com/edx-webhook","followers_url":"https://api.github.com/users/edx-webhook/followers","following_url":"https://api.github.com/users/edx-webhook/following{/other_user}","gists_url":"https://api.github.com/users/edx-webhook/gists{/gist_id}","starred_url":"https://api.github.com/users/edx-webhook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx-webhook/subscriptions","organizations_url":"https://api.github.com/users/edx-webhook/orgs","repos_url":"https://api.github.com/users/edx-webhook/repos","events_url":"https://api.github.com/users/edx-webhook/events{/privacy}","received_events_url":"https://api.github.com/users/edx-webhook/received_events","type":"User","site_admin":false},"created_at":"2015-06-04T07:43:58Z","updated_at":"2015-06-04T07:43:58Z","body":"Thanks for the pull request, @mushtaqak! I've created [OSPR-630](https://openedx.atlassian.net/browse/OSPR-630) to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams. \n\nFeel free to add as much of the following information to the ticket:\n- supporting documentation\n- edx-code email threads\n- timeline information ('this must be merged by XX date', and why that is)\n- partner information ('this is a course on edx.org')\n- any other information that can help Product understand the context for the PR\n\nAll technical communication about the code itself will still be done via the Github pull request interface. As a reminder, [our process documentation is here](http://edx-developer-guide.readthedocs.org/en/latest/process/overview.html).\n\nWe can't start reviewing your pull request until you've submitted a [signed contributor agreement](http://open.edx.org/sites/default/files/wysiwyg/individual-contributor-agreement.pdf) or indicated your institutional affiliation and added yourself to the [AUTHORS](https://github.com/edx/edx-platform/blob/master/AUTHORS) file. Please see the [CONTRIBUTING](https://github.com/edx/edx-platform/blob/master/CONTRIBUTING.rst) file for more information."}}