{"action":"created","comment":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/33915268","id":33915268,"diff_hunk":"@@ -288,10 +288,18 @@ int  ecc_decrypt_key(const unsigned char *in,  unsigned long  inlen,\n                            unsigned char *out, unsigned long *outlen, \n                            ecc_key *key);\n \n+int ecc_sign_hash_raw(const unsigned char *in,  unsigned long inlen,\n+                            void   *r,   void *s,\n+                            prng_state *prng, int wprng, ecc_key *key);\n+","path":"core/lib/libtomcrypt/include/tomcrypt_pk.h","position":7,"original_position":7,"commit_id":"ba7b6811e102df3454142d94de1c15d1ef50c770","original_commit_id":"ba7b6811e102df3454142d94de1c15d1ef50c770","user":{"login":"pascal-brand-st-dev","id":6542303,"avatar_url":"https://avatars.githubusercontent.com/u/6542303?v=3","gravatar_id":"","url":"https://api.github.com/users/pascal-brand-st-dev","html_url":"https://github.com/pascal-brand-st-dev","followers_url":"https://api.github.com/users/pascal-brand-st-dev/followers","following_url":"https://api.github.com/users/pascal-brand-st-dev/following{/other_user}","gists_url":"https://api.github.com/users/pascal-brand-st-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pascal-brand-st-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pascal-brand-st-dev/subscriptions","organizations_url":"https://api.github.com/users/pascal-brand-st-dev/orgs","repos_url":"https://api.github.com/users/pascal-brand-st-dev/repos","events_url":"https://api.github.com/users/pascal-brand-st-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pascal-brand-st-dev/received_events","type":"User","site_admin":false},"body":"Yes, I know. I tried to keep the spacing rules (if any) there is on Libtomcrypt, such as dsa_sign_hash_raw(). Let me know if I should use the OPTEE coding rules for this and below remark.\r\n","created_at":"2015-07-06T08:47:56Z","updated_at":"2015-07-06T08:47:56Z","html_url":"https://github.com/OP-TEE/optee_os/pull/371#discussion_r33915268","pull_request_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/371","_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/33915268"},"html":{"href":"https://github.com/OP-TEE/optee_os/pull/371#discussion_r33915268"},"pull_request":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/371"}}},"pull_request":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/371","id":38874803,"html_url":"https://github.com/OP-TEE/optee_os/pull/371","diff_url":"https://github.com/OP-TEE/optee_os/pull/371.diff","patch_url":"https://github.com/OP-TEE/optee_os/pull/371.patch","issue_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/371","number":371,"state":"open","locked":false,"title":"ECC: sign and self tests, at crypto_ops level","user":{"login":"pascal-brand-st-dev","id":6542303,"avatar_url":"https://avatars.githubusercontent.com/u/6542303?v=3","gravatar_id":"","url":"https://api.github.com/users/pascal-brand-st-dev","html_url":"https://github.com/pascal-brand-st-dev","followers_url":"https://api.github.com/users/pascal-brand-st-dev/followers","following_url":"https://api.github.com/users/pascal-brand-st-dev/following{/other_user}","gists_url":"https://api.github.com/users/pascal-brand-st-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pascal-brand-st-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pascal-brand-st-dev/subscriptions","organizations_url":"https://api.github.com/users/pascal-brand-st-dev/orgs","repos_url":"https://api.github.com/users/pascal-brand-st-dev/repos","events_url":"https://api.github.com/users/pascal-brand-st-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pascal-brand-st-dev/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Pascal Brand <pascal.brand@st.com>","created_at":"2015-06-30T13:01:14Z","updated_at":"2015-07-06T08:47:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b966494339a52163d2ec7a500fe8c8556ad77a37","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/371/commits","review_comments_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/371/comments","review_comment_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/371/comments","statuses_url":"https://api.github.com/repos/OP-TEE/optee_os/statuses/ba7b6811e102df3454142d94de1c15d1ef50c770","head":{"label":"pascal-brand-st-dev:ecc_sign","ref":"ecc_sign","sha":"ba7b6811e102df3454142d94de1c15d1ef50c770","user":{"login":"pascal-brand-st-dev","id":6542303,"avatar_url":"https://avatars.githubusercontent.com/u/6542303?v=3","gravatar_id":"","url":"https://api.github.com/users/pascal-brand-st-dev","html_url":"https://github.com/pascal-brand-st-dev","followers_url":"https://api.github.com/users/pascal-brand-st-dev/followers","following_url":"https://api.github.com/users/pascal-brand-st-dev/following{/other_user}","gists_url":"https://api.github.com/users/pascal-brand-st-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pascal-brand-st-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pascal-brand-st-dev/subscriptions","organizations_url":"https://api.github.com/users/pascal-brand-st-dev/orgs","repos_url":"https://api.github.com/users/pascal-brand-st-dev/repos","events_url":"https://api.github.com/users/pascal-brand-st-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pascal-brand-st-dev/received_events","type":"User","site_admin":false},"repo":{"id":20769654,"name":"optee_os","full_name":"pascal-brand-st-dev/optee_os","owner":{"login":"pascal-brand-st-dev","id":6542303,"avatar_url":"https://avatars.githubusercontent.com/u/6542303?v=3","gravatar_id":"","url":"https://api.github.com/users/pascal-brand-st-dev","html_url":"https://github.com/pascal-brand-st-dev","followers_url":"https://api.github.com/users/pascal-brand-st-dev/followers","following_url":"https://api.github.com/users/pascal-brand-st-dev/following{/other_user}","gists_url":"https://api.github.com/users/pascal-brand-st-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pascal-brand-st-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pascal-brand-st-dev/subscriptions","organizations_url":"https://api.github.com/users/pascal-brand-st-dev/orgs","repos_url":"https://api.github.com/users/pascal-brand-st-dev/repos","events_url":"https://api.github.com/users/pascal-brand-st-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pascal-brand-st-dev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pascal-brand-st-dev/optee_os","description":"Trusted side of the TEE","fork":true,"url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os","forks_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/forks","keys_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/teams","hooks_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/hooks","issue_events_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/issues/events{/number}","events_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/events","assignees_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/assignees{/user}","branches_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/branches{/branch}","tags_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/tags","blobs_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/git/refs{/sha}","trees_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/statuses/{sha}","languages_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/languages","stargazers_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/stargazers","contributors_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/contributors","subscribers_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/subscribers","subscription_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/subscription","commits_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/commits{/sha}","git_commits_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/git/commits{/sha}","comments_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/comments{/number}","issue_comment_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/issues/comments{/number}","contents_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/contents/{+path}","compare_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/merges","archive_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/downloads","issues_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/issues{/number}","pulls_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/pulls{/number}","milestones_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/milestones{/number}","notifications_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/labels{/name}","releases_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/releases{/id}","created_at":"2014-06-12T14:09:53Z","updated_at":"2015-04-28T06:00:43Z","pushed_at":"2015-06-30T12:58:23Z","git_url":"git://github.com/pascal-brand-st-dev/optee_os.git","ssh_url":"git@github.com:pascal-brand-st-dev/optee_os.git","clone_url":"https://github.com/pascal-brand-st-dev/optee_os.git","svn_url":"https://github.com/pascal-brand-st-dev/optee_os","homepage":null,"size":3801,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OP-TEE:master","ref":"master","sha":"bf80076a55706e0359e64d478bc120c726131fb6","user":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars.githubusercontent.com/u/7488961?v=3","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"repo":{"id":20193261,"name":"optee_os","full_name":"OP-TEE/optee_os","owner":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars.githubusercontent.com/u/7488961?v=3","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OP-TEE/optee_os","description":"Trusted side of the TEE","fork":false,"url":"https://api.github.com/repos/OP-TEE/optee_os","forks_url":"https://api.github.com/repos/OP-TEE/optee_os/forks","keys_url":"https://api.github.com/repos/OP-TEE/optee_os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OP-TEE/optee_os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OP-TEE/optee_os/teams","hooks_url":"https://api.github.com/repos/OP-TEE/optee_os/hooks","issue_events_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/events{/number}","events_url":"https://api.github.com/repos/OP-TEE/optee_os/events","assignees_url":"https://api.github.com/repos/OP-TEE/optee_os/assignees{/user}","branches_url":"https://api.github.com/repos/OP-TEE/optee_os/branches{/branch}","tags_url":"https://api.github.com/repos/OP-TEE/optee_os/tags","blobs_url":"https://api.github.com/repos/OP-TEE/optee_os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OP-TEE/optee_os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OP-TEE/optee_os/git/refs{/sha}","trees_url":"https://api.github.com/repos/OP-TEE/optee_os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OP-TEE/optee_os/statuses/{sha}","languages_url":"https://api.github.com/repos/OP-TEE/optee_os/languages","stargazers_url":"https://api.github.com/repos/OP-TEE/optee_os/stargazers","contributors_url":"https://api.github.com/repos/OP-TEE/optee_os/contributors","subscribers_url":"https://api.github.com/repos/OP-TEE/optee_os/subscribers","subscription_url":"https://api.github.com/repos/OP-TEE/optee_os/subscription","commits_url":"https://api.github.com/repos/OP-TEE/optee_os/commits{/sha}","git_commits_url":"https://api.github.com/repos/OP-TEE/optee_os/git/commits{/sha}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/comments{/number}","issue_comment_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/comments{/number}","contents_url":"https://api.github.com/repos/OP-TEE/optee_os/contents/{+path}","compare_url":"https://api.github.com/repos/OP-TEE/optee_os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OP-TEE/optee_os/merges","archive_url":"https://api.github.com/repos/OP-TEE/optee_os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OP-TEE/optee_os/downloads","issues_url":"https://api.github.com/repos/OP-TEE/optee_os/issues{/number}","pulls_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls{/number}","milestones_url":"https://api.github.com/repos/OP-TEE/optee_os/milestones{/number}","notifications_url":"https://api.github.com/repos/OP-TEE/optee_os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OP-TEE/optee_os/labels{/name}","releases_url":"https://api.github.com/repos/OP-TEE/optee_os/releases{/id}","created_at":"2014-05-26T17:18:57Z","updated_at":"2015-07-01T07:05:42Z","pushed_at":"2015-07-06T08:42:32Z","git_url":"git://github.com/OP-TEE/optee_os.git","ssh_url":"git@github.com:OP-TEE/optee_os.git","clone_url":"https://github.com/OP-TEE/optee_os.git","svn_url":"https://github.com/OP-TEE/optee_os","homepage":null,"size":9514,"stargazers_count":54,"watchers_count":54,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"open_issues_count":26,"forks":52,"open_issues":26,"watchers":54,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/371"},"html":{"href":"https://github.com/OP-TEE/optee_os/pull/371"},"issue":{"href":"https://api.github.com/repos/OP-TEE/optee_os/issues/371"},"comments":{"href":"https://api.github.com/repos/OP-TEE/optee_os/issues/371/comments"},"review_comments":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/371/comments"},"review_comment":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/371/commits"},"statuses":{"href":"https://api.github.com/repos/OP-TEE/optee_os/statuses/ba7b6811e102df3454142d94de1c15d1ef50c770"}}}}