{"action":"created","issue":{"url":"https://api.github.com/repos/phpseclib/phpseclib/issues/770","labels_url":"https://api.github.com/repos/phpseclib/phpseclib/issues/770/labels{/name}","comments_url":"https://api.github.com/repos/phpseclib/phpseclib/issues/770/comments","events_url":"https://api.github.com/repos/phpseclib/phpseclib/issues/770/events","html_url":"https://github.com/phpseclib/phpseclib/issues/770","id":100774685,"number":770,"title":"Add more OID's to X509 signature algorithm","user":{"login":"dol","id":41777,"avatar_url":"https://avatars.githubusercontent.com/u/41777?v=3","gravatar_id":"","url":"https://api.github.com/users/dol","html_url":"https://github.com/dol","followers_url":"https://api.github.com/users/dol/followers","following_url":"https://api.github.com/users/dol/following{/other_user}","gists_url":"https://api.github.com/users/dol/gists{/gist_id}","starred_url":"https://api.github.com/users/dol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dol/subscriptions","organizations_url":"https://api.github.com/users/dol/orgs","repos_url":"https://api.github.com/users/dol/repos","events_url":"https://api.github.com/users/dol/events{/privacy}","received_events_url":"https://api.github.com/users/dol/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-08-13T13:53:47Z","updated_at":"2015-08-30T03:25:02Z","closed_at":null,"body":"The x509 parser is missing some OID for the mapping of the signature algorithm.\r\n\r\nA list of OID's can be found in the following project:\r\nhttps://golang.org/src/crypto/x509/x509.go (Line 232)\r\nhttps://cryptography.io/en/latest/x509/reference/#cryptography.x509.oid.SignatureAlgorithmOID\r\n\r\nAn other problem is, that OID are replaced with the NOID mapping. If no NOID was found, the signature algorithm will contain the OID. This makes it very hard to identify the used algorithm.\r\nIt would be nice to have separation of the NOID and the OID.\r\n"},"comment":{"url":"https://api.github.com/repos/phpseclib/phpseclib/issues/comments/136081782","html_url":"https://github.com/phpseclib/phpseclib/issues/770#issuecomment-136081782","issue_url":"https://api.github.com/repos/phpseclib/phpseclib/issues/770","id":136081782,"user":{"login":"terrafrost","id":214474,"avatar_url":"https://avatars.githubusercontent.com/u/214474?v=3","gravatar_id":"","url":"https://api.github.com/users/terrafrost","html_url":"https://github.com/terrafrost","followers_url":"https://api.github.com/users/terrafrost/followers","following_url":"https://api.github.com/users/terrafrost/following{/other_user}","gists_url":"https://api.github.com/users/terrafrost/gists{/gist_id}","starred_url":"https://api.github.com/users/terrafrost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terrafrost/subscriptions","organizations_url":"https://api.github.com/users/terrafrost/orgs","repos_url":"https://api.github.com/users/terrafrost/repos","events_url":"https://api.github.com/users/terrafrost/events{/privacy}","received_events_url":"https://api.github.com/users/terrafrost/received_events","type":"User","site_admin":false},"created_at":"2015-08-30T03:25:02Z","updated_at":"2015-08-30T03:25:02Z","body":"#789 addresses this. I changed how I did it. Trying to do `$x509->setOIDMode(FILE_X509_NAME_OID);` would have just been too problematic. Let's say you set the OID mode and then load the X509 cert. X509.php is looking for OID's by name - not by OID. I guess you could reload the X509 cert - reparse it - depending on the mode but that just seems like overkill.\r\n\r\nI think the getOID() method works just fine.\r\n\r\nIn the future I'll probably make it static but there are a couple other methods I want to make static as well. I'll just do that when I do those."}}