{"action":"created","comment":{"url":"https://api.github.com/repos/edx/ecommerce/pulls/comments/35530131","id":35530131,"diff_hunk":"@@ -0,0 +1,68 @@\n+define([\n+        'jquery',\n+        'underscore',\n+        'backbone'\n+    ],\n+    function( $, _, Backbone ) {\n+        return Backbone.View.extend({\n+\n+            initialize: function() {\n+                this.template = _.template($('#provider-details-tpl').text());\n+                this.getProviders();\n+                this.checkEligibility();\n+            },\n+\n+            getProviders: function () {\n+                var providersIds = this.$el[0].dataset.providersIds;\n+                var url = lmsRootUrl + '/api/credit/v1/providers/?provider_id=' + providersIds;\n+                var self = this;","path":"ecommerce/static/js/views/provider_view.js","position":18,"original_position":18,"commit_id":"9983b3a7bf302fa25f56d7877e8b4ec55c7f1e17","original_commit_id":"9983b3a7bf302fa25f56d7877e8b4ec55c7f1e17","user":{"login":"AlasdairSwan","id":2052185,"avatar_url":"https://avatars.githubusercontent.com/u/2052185?v=3","gravatar_id":"","url":"https://api.github.com/users/AlasdairSwan","html_url":"https://github.com/AlasdairSwan","followers_url":"https://api.github.com/users/AlasdairSwan/followers","following_url":"https://api.github.com/users/AlasdairSwan/following{/other_user}","gists_url":"https://api.github.com/users/AlasdairSwan/gists{/gist_id}","starred_url":"https://api.github.com/users/AlasdairSwan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlasdairSwan/subscriptions","organizations_url":"https://api.github.com/users/AlasdairSwan/orgs","repos_url":"https://api.github.com/users/AlasdairSwan/repos","events_url":"https://api.github.com/users/AlasdairSwan/events{/privacy}","received_events_url":"https://api.github.com/users/AlasdairSwan/received_events","type":"User","site_admin":false},"body":"There should only be 1 var declaration per function, so it should be\r\n```\r\nvar providersIds = this.$el[0].dataset.providersIds,\r\n      url = lmsRootUrl + '/api/credit/v1/providers/?provider_id=' + providersIds,\r\n      self = this;\r\n```","created_at":"2015-07-27T12:30:55Z","updated_at":"2015-07-27T12:30:55Z","html_url":"https://github.com/edx/ecommerce/pull/202#discussion_r35530131","pull_request_url":"https://api.github.com/repos/edx/ecommerce/pulls/202","_links":{"self":{"href":"https://api.github.com/repos/edx/ecommerce/pulls/comments/35530131"},"html":{"href":"https://github.com/edx/ecommerce/pull/202#discussion_r35530131"},"pull_request":{"href":"https://api.github.com/repos/edx/ecommerce/pulls/202"}}},"pull_request":{"url":"https://api.github.com/repos/edx/ecommerce/pulls/202","id":40020452,"html_url":"https://github.com/edx/ecommerce/pull/202","diff_url":"https://github.com/edx/ecommerce/pull/202.diff","patch_url":"https://github.com/edx/ecommerce/pull/202.patch","issue_url":"https://api.github.com/repos/edx/ecommerce/issues/202","number":202,"state":"closed","locked":false,"title":"ECOM-1881 backbone view added for showing provider details on checkout page.","user":{"login":"tasawernawaz","id":4245618,"avatar_url":"https://avatars.githubusercontent.com/u/4245618?v=3","gravatar_id":"","url":"https://api.github.com/users/tasawernawaz","html_url":"https://github.com/tasawernawaz","followers_url":"https://api.github.com/users/tasawernawaz/followers","following_url":"https://api.github.com/users/tasawernawaz/following{/other_user}","gists_url":"https://api.github.com/users/tasawernawaz/gists{/gist_id}","starred_url":"https://api.github.com/users/tasawernawaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tasawernawaz/subscriptions","organizations_url":"https://api.github.com/users/tasawernawaz/orgs","repos_url":"https://api.github.com/users/tasawernawaz/repos","events_url":"https://api.github.com/users/tasawernawaz/events{/privacy}","received_events_url":"https://api.github.com/users/tasawernawaz/received_events","type":"User","site_admin":false},"body":"New backbone view added for showing provider details on checkout page. Cross domain ajax requests added for getting data from LMS.\r\n\r\n@awais786 @zubair-arbi @ahsan-ul-haq @aamir-khan \r\n\r\nWork in progress on design issues.","created_at":"2015-07-15T13:10:26Z","updated_at":"2015-07-27T12:30:55Z","closed_at":"2015-07-24T14:58:23Z","merged_at":"2015-07-24T14:58:23Z","merge_commit_sha":"4182fb32d62d4283cfdc9e94e4247e11c89dc8c1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/ecommerce/pulls/202/commits","review_comments_url":"https://api.github.com/repos/edx/ecommerce/pulls/202/comments","review_comment_url":"https://api.github.com/repos/edx/ecommerce/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/ecommerce/issues/202/comments","statuses_url":"https://api.github.com/repos/edx/ecommerce/statuses/9983b3a7bf302fa25f56d7877e8b4ec55c7f1e17","head":{"label":"edx:tasawer/story/ecom-1881-update-design-of-checkout-page","ref":"tasawer/story/ecom-1881-update-design-of-checkout-page","sha":"9983b3a7bf302fa25f56d7877e8b4ec55c7f1e17","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":30175039,"name":"ecommerce","full_name":"edx/ecommerce","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/ecommerce","description":"Django application used to manage edX's product catalog and handle orders for those products","fork":false,"url":"https://api.github.com/repos/edx/ecommerce","forks_url":"https://api.github.com/repos/edx/ecommerce/forks","keys_url":"https://api.github.com/repos/edx/ecommerce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/ecommerce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/ecommerce/teams","hooks_url":"https://api.github.com/repos/edx/ecommerce/hooks","issue_events_url":"https://api.github.com/repos/edx/ecommerce/issues/events{/number}","events_url":"https://api.github.com/repos/edx/ecommerce/events","assignees_url":"https://api.github.com/repos/edx/ecommerce/assignees{/user}","branches_url":"https://api.github.com/repos/edx/ecommerce/branches{/branch}","tags_url":"https://api.github.com/repos/edx/ecommerce/tags","blobs_url":"https://api.github.com/repos/edx/ecommerce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/ecommerce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/ecommerce/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/ecommerce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/ecommerce/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/ecommerce/languages","stargazers_url":"https://api.github.com/repos/edx/ecommerce/stargazers","contributors_url":"https://api.github.com/repos/edx/ecommerce/contributors","subscribers_url":"https://api.github.com/repos/edx/ecommerce/subscribers","subscription_url":"https://api.github.com/repos/edx/ecommerce/subscription","commits_url":"https://api.github.com/repos/edx/ecommerce/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/ecommerce/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/ecommerce/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/ecommerce/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/ecommerce/contents/{+path}","compare_url":"https://api.github.com/repos/edx/ecommerce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/ecommerce/merges","archive_url":"https://api.github.com/repos/edx/ecommerce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/ecommerce/downloads","issues_url":"https://api.github.com/repos/edx/ecommerce/issues{/number}","pulls_url":"https://api.github.com/repos/edx/ecommerce/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/ecommerce/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/ecommerce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/ecommerce/labels{/name}","releases_url":"https://api.github.com/repos/edx/ecommerce/releases{/id}","created_at":"2015-02-02T06:55:15Z","updated_at":"2015-07-16T01:51:08Z","pushed_at":"2015-07-27T11:50:58Z","git_url":"git://github.com/edx/ecommerce.git","ssh_url":"git@github.com:edx/ecommerce.git","clone_url":"https://github.com/edx/ecommerce.git","svn_url":"https://github.com/edx/ecommerce","homepage":"","size":4839,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":7,"forks":7,"open_issues":7,"watchers":7,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"96e2f77d73224cc5469e13a836eba4fd8ed15a81","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":30175039,"name":"ecommerce","full_name":"edx/ecommerce","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/ecommerce","description":"Django application used to manage edX's product catalog and handle orders for those products","fork":false,"url":"https://api.github.com/repos/edx/ecommerce","forks_url":"https://api.github.com/repos/edx/ecommerce/forks","keys_url":"https://api.github.com/repos/edx/ecommerce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/ecommerce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/ecommerce/teams","hooks_url":"https://api.github.com/repos/edx/ecommerce/hooks","issue_events_url":"https://api.github.com/repos/edx/ecommerce/issues/events{/number}","events_url":"https://api.github.com/repos/edx/ecommerce/events","assignees_url":"https://api.github.com/repos/edx/ecommerce/assignees{/user}","branches_url":"https://api.github.com/repos/edx/ecommerce/branches{/branch}","tags_url":"https://api.github.com/repos/edx/ecommerce/tags","blobs_url":"https://api.github.com/repos/edx/ecommerce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/ecommerce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/ecommerce/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/ecommerce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/ecommerce/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/ecommerce/languages","stargazers_url":"https://api.github.com/repos/edx/ecommerce/stargazers","contributors_url":"https://api.github.com/repos/edx/ecommerce/contributors","subscribers_url":"https://api.github.com/repos/edx/ecommerce/subscribers","subscription_url":"https://api.github.com/repos/edx/ecommerce/subscription","commits_url":"https://api.github.com/repos/edx/ecommerce/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/ecommerce/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/ecommerce/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/ecommerce/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/ecommerce/contents/{+path}","compare_url":"https://api.github.com/repos/edx/ecommerce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/ecommerce/merges","archive_url":"https://api.github.com/repos/edx/ecommerce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/ecommerce/downloads","issues_url":"https://api.github.com/repos/edx/ecommerce/issues{/number}","pulls_url":"https://api.github.com/repos/edx/ecommerce/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/ecommerce/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/ecommerce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/ecommerce/labels{/name}","releases_url":"https://api.github.com/repos/edx/ecommerce/releases{/id}","created_at":"2015-02-02T06:55:15Z","updated_at":"2015-07-16T01:51:08Z","pushed_at":"2015-07-27T11:50:58Z","git_url":"git://github.com/edx/ecommerce.git","ssh_url":"git@github.com:edx/ecommerce.git","clone_url":"https://github.com/edx/ecommerce.git","svn_url":"https://github.com/edx/ecommerce","homepage":"","size":4839,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":7,"forks":7,"open_issues":7,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/ecommerce/pulls/202"},"html":{"href":"https://github.com/edx/ecommerce/pull/202"},"issue":{"href":"https://api.github.com/repos/edx/ecommerce/issues/202"},"comments":{"href":"https://api.github.com/repos/edx/ecommerce/issues/202/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/ecommerce/pulls/202/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/ecommerce/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/ecommerce/pulls/202/commits"},"statuses":{"href":"https://api.github.com/repos/edx/ecommerce/statuses/9983b3a7bf302fa25f56d7877e8b4ec55c7f1e17"}}}}