{"action":"created","issue":{"url":"https://api.github.com/repos/eduardoboucas/include-media/issues/45","labels_url":"https://api.github.com/repos/eduardoboucas/include-media/issues/45/labels{/name}","comments_url":"https://api.github.com/repos/eduardoboucas/include-media/issues/45/comments","events_url":"https://api.github.com/repos/eduardoboucas/include-media/issues/45/events","html_url":"https://github.com/eduardoboucas/include-media/pull/45","id":84215974,"number":45,"title":"[RFR] Rewrote the whole library... :x","user":{"login":"HugoGiraudel","id":1889710,"avatar_url":"https://avatars.githubusercontent.com/u/1889710?v=3","gravatar_id":"","url":"https://api.github.com/users/HugoGiraudel","html_url":"https://github.com/HugoGiraudel","followers_url":"https://api.github.com/users/HugoGiraudel/followers","following_url":"https://api.github.com/users/HugoGiraudel/following{/other_user}","gists_url":"https://api.github.com/users/HugoGiraudel/gists{/gist_id}","starred_url":"https://api.github.com/users/HugoGiraudel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HugoGiraudel/subscriptions","organizations_url":"https://api.github.com/users/HugoGiraudel/orgs","repos_url":"https://api.github.com/users/HugoGiraudel/repos","events_url":"https://api.github.com/users/HugoGiraudel/events{/privacy}","received_events_url":"https://api.github.com/users/HugoGiraudel/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-06-02T21:19:52Z","updated_at":"2015-06-02T23:05:39Z","closed_at":"2015-06-02T22:41:03Z","pull_request":{"url":"https://api.github.com/repos/eduardoboucas/include-media/pulls/45","html_url":"https://github.com/eduardoboucas/include-media/pull/45","diff_url":"https://github.com/eduardoboucas/include-media/pull/45.diff","patch_url":"https://github.com/eduardoboucas/include-media/pull/45.patch"},"body":"At first I wanted to make the expression parser a bit more flexible. Then I wanted to make the media inclusion a bit less hacky. One thing after another, I believe I have rewritten most of the library... If you don't like it @eduardoboucas, feel free to decline the PR. \r\n\r\n## Changes\r\n\r\n* More elegant and flexible expression parser (found in `./src/helpers/_parser.scss`)\r\n* Recursive mixin approach relying on Sass media merging rather than complex Sass logic (found in `./src/helpers/_outputter.scss`)\r\n* Use of `@error` while still supporting Sass 3.3 with a custom logger switching between `@error` and `@warn` (found in `./src/helpers/_logger.scss`)\r\n* Changed some tabs to spaces\r\n\r\n## Breaking changes\r\n\r\nAs far as I can tell, there is none. The API still works like before, it's only about the technical implementation."},"comment":{"url":"https://api.github.com/repos/eduardoboucas/include-media/issues/comments/108124490","html_url":"https://github.com/eduardoboucas/include-media/pull/45#issuecomment-108124490","issue_url":"https://api.github.com/repos/eduardoboucas/include-media/issues/45","id":108124490,"user":{"login":"eduardoboucas","id":4162329,"avatar_url":"https://avatars.githubusercontent.com/u/4162329?v=3","gravatar_id":"","url":"https://api.github.com/users/eduardoboucas","html_url":"https://github.com/eduardoboucas","followers_url":"https://api.github.com/users/eduardoboucas/followers","following_url":"https://api.github.com/users/eduardoboucas/following{/other_user}","gists_url":"https://api.github.com/users/eduardoboucas/gists{/gist_id}","starred_url":"https://api.github.com/users/eduardoboucas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eduardoboucas/subscriptions","organizations_url":"https://api.github.com/users/eduardoboucas/orgs","repos_url":"https://api.github.com/users/eduardoboucas/repos","events_url":"https://api.github.com/users/eduardoboucas/events{/privacy}","received_events_url":"https://api.github.com/users/eduardoboucas/received_events","type":"User","site_admin":false},"created_at":"2015-06-02T23:05:39Z","updated_at":"2015-06-02T23:05:39Z","body":"I found another issue.\r\n\r\nSCSS:\r\n```scss\r\n@include media('landscape', '>phone', '<tablet') {\r\n  color: tomato;\r\n}\r\n```\r\n\r\nError:\r\n```\r\nInvalid CSS after \"\": expected media query list, was \"\"(orientation: ...\"\r\n```\r\n\r\nUsing Ruby Sass 3.4.13 and 3.4.5."}}