{"action":"created","comment":{"url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/pulls/comments/26816338","id":26816338,"diff_hunk":"@@ -59,51 +53,41 @@ def available?(package)\n \n   # computes in USD\n   def compute_package(package)\n-    if (package.order.item_count > 1 and preferences[:promotional_shipping_discount]) and (package.order.completed_at.nil? or package.order.completed_at >= Date.parse('2014-11-23'))\n+    if (package.order.item_count > 1 && preferences[:promotional_shipping_discount]) and (package.order.completed_at.nil? or package.order.completed_at >= Date.parse('2014-11-23'))","path":"lib/spree/calculator/shipping/ohmyzip_shipping_calculator.rb","position":63,"original_position":63,"commit_id":"32e4e8b281f8f5fad4f75b733e620424a8d7436d","original_commit_id":"32e4e8b281f8f5fad4f75b733e620424a8d7436d","user":{"login":"vinayr","id":1189859,"avatar_url":"https://avatars.githubusercontent.com/u/1189859?v=3","gravatar_id":"","url":"https://api.github.com/users/vinayr","html_url":"https://github.com/vinayr","followers_url":"https://api.github.com/users/vinayr/followers","following_url":"https://api.github.com/users/vinayr/following{/other_user}","gists_url":"https://api.github.com/users/vinayr/gists{/gist_id}","starred_url":"https://api.github.com/users/vinayr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinayr/subscriptions","organizations_url":"https://api.github.com/users/vinayr/orgs","repos_url":"https://api.github.com/users/vinayr/repos","events_url":"https://api.github.com/users/vinayr/events{/privacy}","received_events_url":"https://api.github.com/users/vinayr/received_events","type":"User","site_admin":false},"body":"replace all occurences of `and`, `or` with `&&`,`||` ??","created_at":"2015-03-20T03:15:54Z","updated_at":"2015-03-20T03:15:54Z","html_url":"https://github.com/casualsteps/spree_ohmyzip_shipping_calculator/pull/10#discussion_r26816338","pull_request_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/pulls/comments/26816338"},"html":{"href":"https://github.com/casualsteps/spree_ohmyzip_shipping_calculator/pull/10#discussion_r26816338"},"pull_request":{"href":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/pulls/10","id":31584652,"html_url":"https://github.com/casualsteps/spree_ohmyzip_shipping_calculator/pull/10","diff_url":"https://github.com/casualsteps/spree_ohmyzip_shipping_calculator/pull/10.diff","patch_url":"https://github.com/casualsteps/spree_ohmyzip_shipping_calculator/pull/10.patch","issue_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/issues/10","number":10,"state":"open","locked":false,"title":"First refactoring pass.","user":{"login":"archSeer","id":1372918,"avatar_url":"https://avatars.githubusercontent.com/u/1372918?v=3","gravatar_id":"","url":"https://api.github.com/users/archSeer","html_url":"https://github.com/archSeer","followers_url":"https://api.github.com/users/archSeer/followers","following_url":"https://api.github.com/users/archSeer/following{/other_user}","gists_url":"https://api.github.com/users/archSeer/gists{/gist_id}","starred_url":"https://api.github.com/users/archSeer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/archSeer/subscriptions","organizations_url":"https://api.github.com/users/archSeer/orgs","repos_url":"https://api.github.com/users/archSeer/repos","events_url":"https://api.github.com/users/archSeer/events{/privacy}","received_events_url":"https://api.github.com/users/archSeer/received_events","type":"User","site_admin":false},"body":"@casualsteps/devs review time\r\n\r\nOne more pass to be done after I get the currency rate refactor merged.","created_at":"2015-03-20T02:54:27Z","updated_at":"2015-03-20T03:15:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ab122e74221e69a03d3bf797be6b8d66dc644c5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/pulls/10/commits","review_comments_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/pulls/10/comments","review_comment_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/issues/10/comments","statuses_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/statuses/32e4e8b281f8f5fad4f75b733e620424a8d7436d","head":{"label":"casualsteps:first-pass-refactor","ref":"first-pass-refactor","sha":"32e4e8b281f8f5fad4f75b733e620424a8d7436d","user":{"login":"casualsteps","id":6834914,"avatar_url":"https://avatars.githubusercontent.com/u/6834914?v=3","gravatar_id":"","url":"https://api.github.com/users/casualsteps","html_url":"https://github.com/casualsteps","followers_url":"https://api.github.com/users/casualsteps/followers","following_url":"https://api.github.com/users/casualsteps/following{/other_user}","gists_url":"https://api.github.com/users/casualsteps/gists{/gist_id}","starred_url":"https://api.github.com/users/casualsteps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/casualsteps/subscriptions","organizations_url":"https://api.github.com/users/casualsteps/orgs","repos_url":"https://api.github.com/users/casualsteps/repos","events_url":"https://api.github.com/users/casualsteps/events{/privacy}","received_events_url":"https://api.github.com/users/casualsteps/received_events","type":"Organization","site_admin":false},"repo":{"id":19846078,"name":"spree_ohmyzip_shipping_calculator","full_name":"casualsteps/spree_ohmyzip_shipping_calculator","owner":{"login":"casualsteps","id":6834914,"avatar_url":"https://avatars.githubusercontent.com/u/6834914?v=3","gravatar_id":"","url":"https://api.github.com/users/casualsteps","html_url":"https://github.com/casualsteps","followers_url":"https://api.github.com/users/casualsteps/followers","following_url":"https://api.github.com/users/casualsteps/following{/other_user}","gists_url":"https://api.github.com/users/casualsteps/gists{/gist_id}","starred_url":"https://api.github.com/users/casualsteps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/casualsteps/subscriptions","organizations_url":"https://api.github.com/users/casualsteps/orgs","repos_url":"https://api.github.com/users/casualsteps/repos","events_url":"https://api.github.com/users/casualsteps/events{/privacy}","received_events_url":"https://api.github.com/users/casualsteps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/casualsteps/spree_ohmyzip_shipping_calculator","description":"A calculator for the Korean package-forwarding company Ohmyzip","fork":false,"url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator","forks_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/forks","keys_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/teams","hooks_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/hooks","issue_events_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/issues/events{/number}","events_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/events","assignees_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/assignees{/user}","branches_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/branches{/branch}","tags_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/tags","blobs_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/git/refs{/sha}","trees_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/statuses/{sha}","languages_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/languages","stargazers_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/stargazers","contributors_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/contributors","subscribers_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/subscribers","subscription_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/subscription","commits_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/commits{/sha}","git_commits_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/git/commits{/sha}","comments_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/comments{/number}","issue_comment_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/issues/comments{/number}","contents_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/contents/{+path}","compare_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/merges","archive_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/downloads","issues_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/issues{/number}","pulls_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/pulls{/number}","milestones_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/milestones{/number}","notifications_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/labels{/name}","releases_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/releases{/id}","created_at":"2014-05-16T05:53:35Z","updated_at":"2015-02-23T10:13:45Z","pushed_at":"2015-03-20T02:54:29Z","git_url":"git://github.com/casualsteps/spree_ohmyzip_shipping_calculator.git","ssh_url":"git@github.com:casualsteps/spree_ohmyzip_shipping_calculator.git","clone_url":"https://github.com/casualsteps/spree_ohmyzip_shipping_calculator.git","svn_url":"https://github.com/casualsteps/spree_ohmyzip_shipping_calculator","homepage":"","size":552,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"casualsteps:master","ref":"master","sha":"79c4300e61d58381e14b7b1a305b10d8c1b1da39","user":{"login":"casualsteps","id":6834914,"avatar_url":"https://avatars.githubusercontent.com/u/6834914?v=3","gravatar_id":"","url":"https://api.github.com/users/casualsteps","html_url":"https://github.com/casualsteps","followers_url":"https://api.github.com/users/casualsteps/followers","following_url":"https://api.github.com/users/casualsteps/following{/other_user}","gists_url":"https://api.github.com/users/casualsteps/gists{/gist_id}","starred_url":"https://api.github.com/users/casualsteps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/casualsteps/subscriptions","organizations_url":"https://api.github.com/users/casualsteps/orgs","repos_url":"https://api.github.com/users/casualsteps/repos","events_url":"https://api.github.com/users/casualsteps/events{/privacy}","received_events_url":"https://api.github.com/users/casualsteps/received_events","type":"Organization","site_admin":false},"repo":{"id":19846078,"name":"spree_ohmyzip_shipping_calculator","full_name":"casualsteps/spree_ohmyzip_shipping_calculator","owner":{"login":"casualsteps","id":6834914,"avatar_url":"https://avatars.githubusercontent.com/u/6834914?v=3","gravatar_id":"","url":"https://api.github.com/users/casualsteps","html_url":"https://github.com/casualsteps","followers_url":"https://api.github.com/users/casualsteps/followers","following_url":"https://api.github.com/users/casualsteps/following{/other_user}","gists_url":"https://api.github.com/users/casualsteps/gists{/gist_id}","starred_url":"https://api.github.com/users/casualsteps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/casualsteps/subscriptions","organizations_url":"https://api.github.com/users/casualsteps/orgs","repos_url":"https://api.github.com/users/casualsteps/repos","events_url":"https://api.github.com/users/casualsteps/events{/privacy}","received_events_url":"https://api.github.com/users/casualsteps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/casualsteps/spree_ohmyzip_shipping_calculator","description":"A calculator for the Korean package-forwarding company Ohmyzip","fork":false,"url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator","forks_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/forks","keys_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/teams","hooks_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/hooks","issue_events_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/issues/events{/number}","events_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/events","assignees_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/assignees{/user}","branches_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/branches{/branch}","tags_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/tags","blobs_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/git/refs{/sha}","trees_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/statuses/{sha}","languages_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/languages","stargazers_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/stargazers","contributors_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/contributors","subscribers_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/subscribers","subscription_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/subscription","commits_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/commits{/sha}","git_commits_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/git/commits{/sha}","comments_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/comments{/number}","issue_comment_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/issues/comments{/number}","contents_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/contents/{+path}","compare_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/merges","archive_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/downloads","issues_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/issues{/number}","pulls_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/pulls{/number}","milestones_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/milestones{/number}","notifications_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/labels{/name}","releases_url":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/releases{/id}","created_at":"2014-05-16T05:53:35Z","updated_at":"2015-02-23T10:13:45Z","pushed_at":"2015-03-20T02:54:29Z","git_url":"git://github.com/casualsteps/spree_ohmyzip_shipping_calculator.git","ssh_url":"git@github.com:casualsteps/spree_ohmyzip_shipping_calculator.git","clone_url":"https://github.com/casualsteps/spree_ohmyzip_shipping_calculator.git","svn_url":"https://github.com/casualsteps/spree_ohmyzip_shipping_calculator","homepage":"","size":552,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/pulls/10"},"html":{"href":"https://github.com/casualsteps/spree_ohmyzip_shipping_calculator/pull/10"},"issue":{"href":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/issues/10"},"comments":{"href":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/casualsteps/spree_ohmyzip_shipping_calculator/statuses/32e4e8b281f8f5fad4f75b733e620424a8d7436d"}}}}