{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/ctxis/wsuspect-proxy/pulls/2","id":53468165,"html_url":"https://github.com/ctxis/wsuspect-proxy/pull/2","diff_url":"https://github.com/ctxis/wsuspect-proxy/pull/2.diff","patch_url":"https://github.com/ctxis/wsuspect-proxy/pull/2.patch","issue_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/issues/2","number":2,"state":"closed","locked":false,"title":"Added timeout and connection termination checks for use in proxychains","user":{"login":"sixdub","id":1566315,"avatar_url":"https://avatars.githubusercontent.com/u/1566315?v=3","gravatar_id":"","url":"https://api.github.com/users/sixdub","html_url":"https://github.com/sixdub","followers_url":"https://api.github.com/users/sixdub/followers","following_url":"https://api.github.com/users/sixdub/following{/other_user}","gists_url":"https://api.github.com/users/sixdub/gists{/gist_id}","starred_url":"https://api.github.com/users/sixdub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sixdub/subscriptions","organizations_url":"https://api.github.com/users/sixdub/orgs","repos_url":"https://api.github.com/users/sixdub/repos","events_url":"https://api.github.com/users/sixdub/events{/privacy}","received_events_url":"https://api.github.com/users/sixdub/received_events","type":"User","site_admin":false},"body":"Hi! GREAT tool and research. I was using this tool through a semi-complicated series of network tunneling to achieve remote use but ran into some problems. Specifically, I used the tool with Proxychains but the SOCKS server was not properly notifying the ProxyClient that the connection was terminated (during the initial HEAD request in the WSUS exchange) which resulted in a hung connection. By adding the timeout values and looking for properly terminated connections, the exchange now completes. Likely needs additional testing to ensure standard functionality was not modified. ","created_at":"2015-12-12T04:26:18Z","updated_at":"2015-12-14T15:36:19Z","closed_at":"2015-12-14T15:36:19Z","merged_at":"2015-12-14T15:36:19Z","merge_commit_sha":"90e2bcd2e613739708ae9f9223433e27250b900f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/pulls/2/commits","review_comments_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/pulls/2/comments","review_comment_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/issues/2/comments","statuses_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/statuses/9726a85b2fc8c2180b920d2a8cecb16aeda7bb94","head":{"label":"sixdub:master","ref":"master","sha":"9726a85b2fc8c2180b920d2a8cecb16aeda7bb94","user":{"login":"sixdub","id":1566315,"avatar_url":"https://avatars.githubusercontent.com/u/1566315?v=3","gravatar_id":"","url":"https://api.github.com/users/sixdub","html_url":"https://github.com/sixdub","followers_url":"https://api.github.com/users/sixdub/followers","following_url":"https://api.github.com/users/sixdub/following{/other_user}","gists_url":"https://api.github.com/users/sixdub/gists{/gist_id}","starred_url":"https://api.github.com/users/sixdub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sixdub/subscriptions","organizations_url":"https://api.github.com/users/sixdub/orgs","repos_url":"https://api.github.com/users/sixdub/repos","events_url":"https://api.github.com/users/sixdub/events{/privacy}","received_events_url":"https://api.github.com/users/sixdub/received_events","type":"User","site_admin":false},"repo":{"id":47863905,"name":"wsuspect-proxy","full_name":"sixdub/wsuspect-proxy","owner":{"login":"sixdub","id":1566315,"avatar_url":"https://avatars.githubusercontent.com/u/1566315?v=3","gravatar_id":"","url":"https://api.github.com/users/sixdub","html_url":"https://github.com/sixdub","followers_url":"https://api.github.com/users/sixdub/followers","following_url":"https://api.github.com/users/sixdub/following{/other_user}","gists_url":"https://api.github.com/users/sixdub/gists{/gist_id}","starred_url":"https://api.github.com/users/sixdub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sixdub/subscriptions","organizations_url":"https://api.github.com/users/sixdub/orgs","repos_url":"https://api.github.com/users/sixdub/repos","events_url":"https://api.github.com/users/sixdub/events{/privacy}","received_events_url":"https://api.github.com/users/sixdub/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sixdub/wsuspect-proxy","description":"WSUSpect Proxy - a tool for MITM'ing insecure WSUS connections","fork":true,"url":"https://api.github.com/repos/sixdub/wsuspect-proxy","forks_url":"https://api.github.com/repos/sixdub/wsuspect-proxy/forks","keys_url":"https://api.github.com/repos/sixdub/wsuspect-proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sixdub/wsuspect-proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sixdub/wsuspect-proxy/teams","hooks_url":"https://api.github.com/repos/sixdub/wsuspect-proxy/hooks","issue_events_url":"https://api.github.com/repos/sixdub/wsuspect-proxy/issues/events{/number}","events_url":"https://api.github.com/repos/sixdub/wsuspect-proxy/events","assignees_url":"https://api.github.com/repos/sixdub/wsuspect-proxy/assignees{/user}","branches_url":"https://api.github.com/repos/sixdub/wsuspect-proxy/branches{/branch}","tags_url":"https://api.github.com/repos/sixdub/wsuspect-proxy/tags","blobs_url":"https://api.github.com/repos/sixdub/wsuspect-proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sixdub/wsuspect-proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sixdub/wsuspect-proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sixdub/wsuspect-proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sixdub/wsuspect-proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/sixdub/wsuspect-proxy/languages","stargazers_url":"https://api.github.com/repos/sixdub/wsuspect-proxy/stargazers","contributors_url":"https://api.github.com/repos/sixdub/wsuspect-proxy/contributors","subscribers_url":"https://api.github.com/repos/sixdub/wsuspect-proxy/subscribers","subscription_url":"https://api.github.com/repos/sixdub/wsuspect-proxy/subscription","commits_url":"https://api.github.com/repos/sixdub/wsuspect-proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sixdub/wsuspect-proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sixdub/wsuspect-proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sixdub/wsuspect-proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sixdub/wsuspect-proxy/contents/{+path}","compare_url":"https://api.github.com/repos/sixdub/wsuspect-proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sixdub/wsuspect-proxy/merges","archive_url":"https://api.github.com/repos/sixdub/wsuspect-proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sixdub/wsuspect-proxy/downloads","issues_url":"https://api.github.com/repos/sixdub/wsuspect-proxy/issues{/number}","pulls_url":"https://api.github.com/repos/sixdub/wsuspect-proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/sixdub/wsuspect-proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/sixdub/wsuspect-proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sixdub/wsuspect-proxy/labels{/name}","releases_url":"https://api.github.com/repos/sixdub/wsuspect-proxy/releases{/id}","created_at":"2015-12-12T04:19:08Z","updated_at":"2015-12-12T04:19:09Z","pushed_at":"2015-12-12T04:21:28Z","git_url":"git://github.com/sixdub/wsuspect-proxy.git","ssh_url":"git@github.com:sixdub/wsuspect-proxy.git","clone_url":"https://github.com/sixdub/wsuspect-proxy.git","svn_url":"https://github.com/sixdub/wsuspect-proxy","homepage":"","size":125,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ctxis:master","ref":"master","sha":"ae16707f15a3fc70b4473f90cd0049a99d5078c1","user":{"login":"ctxis","id":4638567,"avatar_url":"https://avatars.githubusercontent.com/u/4638567?v=3","gravatar_id":"","url":"https://api.github.com/users/ctxis","html_url":"https://github.com/ctxis","followers_url":"https://api.github.com/users/ctxis/followers","following_url":"https://api.github.com/users/ctxis/following{/other_user}","gists_url":"https://api.github.com/users/ctxis/gists{/gist_id}","starred_url":"https://api.github.com/users/ctxis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctxis/subscriptions","organizations_url":"https://api.github.com/users/ctxis/orgs","repos_url":"https://api.github.com/users/ctxis/repos","events_url":"https://api.github.com/users/ctxis/events{/privacy}","received_events_url":"https://api.github.com/users/ctxis/received_events","type":"Organization","site_admin":false},"repo":{"id":44734047,"name":"wsuspect-proxy","full_name":"ctxis/wsuspect-proxy","owner":{"login":"ctxis","id":4638567,"avatar_url":"https://avatars.githubusercontent.com/u/4638567?v=3","gravatar_id":"","url":"https://api.github.com/users/ctxis","html_url":"https://github.com/ctxis","followers_url":"https://api.github.com/users/ctxis/followers","following_url":"https://api.github.com/users/ctxis/following{/other_user}","gists_url":"https://api.github.com/users/ctxis/gists{/gist_id}","starred_url":"https://api.github.com/users/ctxis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctxis/subscriptions","organizations_url":"https://api.github.com/users/ctxis/orgs","repos_url":"https://api.github.com/users/ctxis/repos","events_url":"https://api.github.com/users/ctxis/events{/privacy}","received_events_url":"https://api.github.com/users/ctxis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ctxis/wsuspect-proxy","description":"WSUSpect Proxy - a tool for MITM'ing insecure WSUS connections","fork":true,"url":"https://api.github.com/repos/ctxis/wsuspect-proxy","forks_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/forks","keys_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/teams","hooks_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/hooks","issue_events_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/issues/events{/number}","events_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/events","assignees_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/assignees{/user}","branches_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/branches{/branch}","tags_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/tags","blobs_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/languages","stargazers_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/stargazers","contributors_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/contributors","subscribers_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/subscribers","subscription_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/subscription","commits_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/contents/{+path}","compare_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/merges","archive_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/downloads","issues_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/issues{/number}","pulls_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/labels{/name}","releases_url":"https://api.github.com/repos/ctxis/wsuspect-proxy/releases{/id}","created_at":"2015-10-22T09:03:16Z","updated_at":"2015-11-29T20:36:02Z","pushed_at":"2015-12-14T15:36:19Z","git_url":"git://github.com/ctxis/wsuspect-proxy.git","ssh_url":"git@github.com:ctxis/wsuspect-proxy.git","clone_url":"https://github.com/ctxis/wsuspect-proxy.git","svn_url":"https://github.com/ctxis/wsuspect-proxy","homepage":"","size":126,"stargazers_count":72,"watchers_count":72,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":0,"forks":13,"open_issues":0,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ctxis/wsuspect-proxy/pulls/2"},"html":{"href":"https://github.com/ctxis/wsuspect-proxy/pull/2"},"issue":{"href":"https://api.github.com/repos/ctxis/wsuspect-proxy/issues/2"},"comments":{"href":"https://api.github.com/repos/ctxis/wsuspect-proxy/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/ctxis/wsuspect-proxy/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/ctxis/wsuspect-proxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ctxis/wsuspect-proxy/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/ctxis/wsuspect-proxy/statuses/9726a85b2fc8c2180b920d2a8cecb16aeda7bb94"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"pdjstone","id":2699275,"avatar_url":"https://avatars.githubusercontent.com/u/2699275?v=3","gravatar_id":"","url":"https://api.github.com/users/pdjstone","html_url":"https://github.com/pdjstone","followers_url":"https://api.github.com/users/pdjstone/followers","following_url":"https://api.github.com/users/pdjstone/following{/other_user}","gists_url":"https://api.github.com/users/pdjstone/gists{/gist_id}","starred_url":"https://api.github.com/users/pdjstone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdjstone/subscriptions","organizations_url":"https://api.github.com/users/pdjstone/orgs","repos_url":"https://api.github.com/users/pdjstone/repos","events_url":"https://api.github.com/users/pdjstone/events{/privacy}","received_events_url":"https://api.github.com/users/pdjstone/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":38,"deletions":2,"changed_files":1}}