{"action":"closed","number":13833,"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/13833","id":49313074,"html_url":"https://github.com/JuliaLang/julia/pull/13833","diff_url":"https://github.com/JuliaLang/julia/pull/13833.diff","patch_url":"https://github.com/JuliaLang/julia/pull/13833.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/13833","number":13833,"state":"closed","locked":false,"title":"fix range bugs for matrix multiply/solve","user":{"login":"artkuo","id":2893800,"avatar_url":"https://avatars.githubusercontent.com/u/2893800?v=3","gravatar_id":"","url":"https://api.github.com/users/artkuo","html_url":"https://github.com/artkuo","followers_url":"https://api.github.com/users/artkuo/followers","following_url":"https://api.github.com/users/artkuo/following{/other_user}","gists_url":"https://api.github.com/users/artkuo/gists{/gist_id}","starred_url":"https://api.github.com/users/artkuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artkuo/subscriptions","organizations_url":"https://api.github.com/users/artkuo/orgs","repos_url":"https://api.github.com/users/artkuo/repos","events_url":"https://api.github.com/users/artkuo/events{/privacy}","received_events_url":"https://api.github.com/users/artkuo/received_events","type":"User","site_admin":false},"body":"This is a combined bug fix and workaround for ranges not behaving properly when pre-multiplied by a matrix. In the [user forum](https://groups.google.com/d/msg/julia-users/fVXAF0RP2MM/knKTy8oIBgAJ) an error was reported for `A*r` where `A` is a matrix and `r` is a range, which should just like a vector. The fix is to define matrix multiplication by a `Range` as including a `collect` first.\r\n\r\nA second problem is that `A\\r` can fail, with the workaround also being to do a `collect` on `r`. I call this a workaround as opposed to a bug fix, because the problem may come from intricacies of `convert`, and not necessarily a failure to `collect`, as `A\\r` doesn't fail universally but only for some/most combinations of types for `A` and `r`. I didn't trace down far enough to figure that out, and someone more knowledgeable might know whether there is a deeper bug lurking somewhere. Nevertheless this PR seems to work and pass all tests including the added ones.\r\n\r\nFinally, I left the definitions very broad here with `AbstractArray`. I would appreciate advice if these should be something more specific such as `AbstractMatrix` or such. My thinking was that the details on types get figured out by matmul.jl so there's no need to deal with it beforehand, but I'm not sure if this could potentially slow things down.","created_at":"2015-10-30T19:33:59Z","updated_at":"2015-11-12T19:04:48Z","closed_at":"2015-11-12T19:04:48Z","merged_at":"2015-11-12T19:04:48Z","merge_commit_sha":"ac0e1ebbcc75d10442f4e7b3ba32008d80515bc0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/13833/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/13833/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/13833/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/392b1a3a47b14b5ca35c83dddedf00e2cbfb16cb","head":{"label":"artkuo:rangemulsol","ref":"rangemulsol","sha":"392b1a3a47b14b5ca35c83dddedf00e2cbfb16cb","user":{"login":"artkuo","id":2893800,"avatar_url":"https://avatars.githubusercontent.com/u/2893800?v=3","gravatar_id":"","url":"https://api.github.com/users/artkuo","html_url":"https://github.com/artkuo","followers_url":"https://api.github.com/users/artkuo/followers","following_url":"https://api.github.com/users/artkuo/following{/other_user}","gists_url":"https://api.github.com/users/artkuo/gists{/gist_id}","starred_url":"https://api.github.com/users/artkuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artkuo/subscriptions","organizations_url":"https://api.github.com/users/artkuo/orgs","repos_url":"https://api.github.com/users/artkuo/repos","events_url":"https://api.github.com/users/artkuo/events{/privacy}","received_events_url":"https://api.github.com/users/artkuo/received_events","type":"User","site_admin":false},"repo":{"id":24970883,"name":"julia","full_name":"artkuo/julia","owner":{"login":"artkuo","id":2893800,"avatar_url":"https://avatars.githubusercontent.com/u/2893800?v=3","gravatar_id":"","url":"https://api.github.com/users/artkuo","html_url":"https://github.com/artkuo","followers_url":"https://api.github.com/users/artkuo/followers","following_url":"https://api.github.com/users/artkuo/following{/other_user}","gists_url":"https://api.github.com/users/artkuo/gists{/gist_id}","starred_url":"https://api.github.com/users/artkuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artkuo/subscriptions","organizations_url":"https://api.github.com/users/artkuo/orgs","repos_url":"https://api.github.com/users/artkuo/repos","events_url":"https://api.github.com/users/artkuo/events{/privacy}","received_events_url":"https://api.github.com/users/artkuo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/artkuo/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":true,"url":"https://api.github.com/repos/artkuo/julia","forks_url":"https://api.github.com/repos/artkuo/julia/forks","keys_url":"https://api.github.com/repos/artkuo/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artkuo/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artkuo/julia/teams","hooks_url":"https://api.github.com/repos/artkuo/julia/hooks","issue_events_url":"https://api.github.com/repos/artkuo/julia/issues/events{/number}","events_url":"https://api.github.com/repos/artkuo/julia/events","assignees_url":"https://api.github.com/repos/artkuo/julia/assignees{/user}","branches_url":"https://api.github.com/repos/artkuo/julia/branches{/branch}","tags_url":"https://api.github.com/repos/artkuo/julia/tags","blobs_url":"https://api.github.com/repos/artkuo/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artkuo/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artkuo/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/artkuo/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artkuo/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/artkuo/julia/languages","stargazers_url":"https://api.github.com/repos/artkuo/julia/stargazers","contributors_url":"https://api.github.com/repos/artkuo/julia/contributors","subscribers_url":"https://api.github.com/repos/artkuo/julia/subscribers","subscription_url":"https://api.github.com/repos/artkuo/julia/subscription","commits_url":"https://api.github.com/repos/artkuo/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/artkuo/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/artkuo/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/artkuo/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/artkuo/julia/contents/{+path}","compare_url":"https://api.github.com/repos/artkuo/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artkuo/julia/merges","archive_url":"https://api.github.com/repos/artkuo/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artkuo/julia/downloads","issues_url":"https://api.github.com/repos/artkuo/julia/issues{/number}","pulls_url":"https://api.github.com/repos/artkuo/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/artkuo/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/artkuo/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artkuo/julia/labels{/name}","releases_url":"https://api.github.com/repos/artkuo/julia/releases{/id}","created_at":"2014-10-09T02:48:59Z","updated_at":"2014-10-13T03:13:08Z","pushed_at":"2015-11-11T02:08:42Z","git_url":"git://github.com/artkuo/julia.git","ssh_url":"git@github.com:artkuo/julia.git","clone_url":"https://github.com/artkuo/julia.git","svn_url":"https://github.com/artkuo/julia","homepage":"http://julialang.org/","size":87816,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"d0f9e12a5fac33561b99c12393e0d415bc152bab","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","created_at":"2011-04-21T07:01:50Z","updated_at":"2015-11-12T18:52:11Z","pushed_at":"2015-11-12T19:04:49Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"http://julialang.org/","size":244391,"stargazers_count":6251,"watchers_count":6251,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1396,"mirror_url":null,"open_issues_count":1472,"forks":1396,"open_issues":1472,"watchers":6251,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/13833"},"html":{"href":"https://github.com/JuliaLang/julia/pull/13833"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/13833"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/13833/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/13833/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/13833/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/392b1a3a47b14b5ca35c83dddedf00e2cbfb16cb"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"andreasnoack","id":505001,"avatar_url":"https://avatars.githubusercontent.com/u/505001?v=3","gravatar_id":"","url":"https://api.github.com/users/andreasnoack","html_url":"https://github.com/andreasnoack","followers_url":"https://api.github.com/users/andreasnoack/followers","following_url":"https://api.github.com/users/andreasnoack/following{/other_user}","gists_url":"https://api.github.com/users/andreasnoack/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasnoack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasnoack/subscriptions","organizations_url":"https://api.github.com/users/andreasnoack/orgs","repos_url":"https://api.github.com/users/andreasnoack/repos","events_url":"https://api.github.com/users/andreasnoack/events{/privacy}","received_events_url":"https://api.github.com/users/andreasnoack/received_events","type":"User","site_admin":false},"comments":9,"review_comments":2,"commits":1,"additions":10,"deletions":1,"changed_files":3}}