{"action":"created","comment":{"url":"https://api.github.com/repos/forio/flow.js/pulls/comments/33329823","id":33329823,"diff_hunk":"@@ -51,16 +62,40 @@ var converterManager = {\n \n     list: [],\n     /**\n-     * Add a new attribute converter\n-     * @param  {string|function|regex} alias formatter name\n-     * @param  {function|object} converter    converter can either be a function, which will be called with the value, or an object with {alias: '', parse: $.noop, convert: $.noop}\n-     * @param {Boolean} acceptList decides if the converter is a 'list' converter or not; list converters take in arrays as inputs, others expect single values.\n+     * Add a new attribute converter to this instance of Flow.js.\n+     *\n+     * **Example**\n+     *\n+     *      Flow.dom.converters.register('max', function (value) {","path":"src/converters/converter-manager.js","position":27,"original_position":27,"commit_id":"0b4bfda14c6346f110dc9abbad109f7cc7d792e0","original_commit_id":"0b4bfda14c6346f110dc9abbad109f7cc7d792e0","user":{"login":"narenranjit","id":830274,"avatar_url":"https://avatars.githubusercontent.com/u/830274?v=3","gravatar_id":"","url":"https://api.github.com/users/narenranjit","html_url":"https://github.com/narenranjit","followers_url":"https://api.github.com/users/narenranjit/followers","following_url":"https://api.github.com/users/narenranjit/following{/other_user}","gists_url":"https://api.github.com/users/narenranjit/gists{/gist_id}","starred_url":"https://api.github.com/users/narenranjit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/narenranjit/subscriptions","organizations_url":"https://api.github.com/users/narenranjit/orgs","repos_url":"https://api.github.com/users/narenranjit/repos","events_url":"https://api.github.com/users/narenranjit/events{/privacy}","received_events_url":"https://api.github.com/users/narenranjit/received_events","type":"User","site_admin":false},"body":"this example should have a \"True\" at the end since you're registering this to take in arrays","created_at":"2015-06-26T05:38:25Z","updated_at":"2015-06-26T05:38:25Z","html_url":"https://github.com/forio/flow.js/pull/31#discussion_r33329823","pull_request_url":"https://api.github.com/repos/forio/flow.js/pulls/31","_links":{"self":{"href":"https://api.github.com/repos/forio/flow.js/pulls/comments/33329823"},"html":{"href":"https://github.com/forio/flow.js/pull/31#discussion_r33329823"},"pull_request":{"href":"https://api.github.com/repos/forio/flow.js/pulls/31"}}},"pull_request":{"url":"https://api.github.com/repos/forio/flow.js/pulls/31","id":37926825,"html_url":"https://github.com/forio/flow.js/pull/31","diff_url":"https://github.com/forio/flow.js/pull/31.diff","patch_url":"https://github.com/forio/flow.js/pull/31.patch","issue_url":"https://api.github.com/repos/forio/flow.js/issues/31","number":31,"state":"open","locked":false,"title":"Epicenter 346 docs breakup","user":{"login":"mmrj","id":1653043,"avatar_url":"https://avatars.githubusercontent.com/u/1653043?v=3","gravatar_id":"","url":"https://api.github.com/users/mmrj","html_url":"https://github.com/mmrj","followers_url":"https://api.github.com/users/mmrj/followers","following_url":"https://api.github.com/users/mmrj/following{/other_user}","gists_url":"https://api.github.com/users/mmrj/gists{/gist_id}","starred_url":"https://api.github.com/users/mmrj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmrj/subscriptions","organizations_url":"https://api.github.com/users/mmrj/orgs","repos_url":"https://api.github.com/users/mmrj/repos","events_url":"https://api.github.com/users/mmrj/events{/privacy}","received_events_url":"https://api.github.com/users/mmrj/received_events","type":"User","site_admin":false},"body":"these are the docs for story https://issues.forio.com/browse/EPICENTER-346\r\n\r\nmy thought is that (after review) we can merge into Flow.js 0.9.0, which will give people who look at Flow in GitHub a lot of docs ... but we will wait on future (hopefully next platform sprint) ticket https://issues.forio.com/browse/EPICENTER-928 before this will be available on forio.com/epicenter/docs/public, because of some additional docpad infrastructure work that needs to happen.\r\n\r\nin the mean time, however -- and if it helps with review -- you can see how these changes will eventually look in the docpad-ified version at http://qa.forio.com/epicenter/docs/public/data_binding_flow_js/\r\n\r\n(disclaimer: i'm not sure how long i'll have these up on the qa server, e.g. i may start using that for testing other branches in a couple of days. if you don't see the flow.js-specific toc, let me know and i'll redeploy to qa for your review.)","created_at":"2015-06-17T17:37:45Z","updated_at":"2015-06-26T05:38:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0256990334772541816ab2b515ab21fb42ff7df","assignee":{"login":"narenranjit","id":830274,"avatar_url":"https://avatars.githubusercontent.com/u/830274?v=3","gravatar_id":"","url":"https://api.github.com/users/narenranjit","html_url":"https://github.com/narenranjit","followers_url":"https://api.github.com/users/narenranjit/followers","following_url":"https://api.github.com/users/narenranjit/following{/other_user}","gists_url":"https://api.github.com/users/narenranjit/gists{/gist_id}","starred_url":"https://api.github.com/users/narenranjit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/narenranjit/subscriptions","organizations_url":"https://api.github.com/users/narenranjit/orgs","repos_url":"https://api.github.com/users/narenranjit/repos","events_url":"https://api.github.com/users/narenranjit/events{/privacy}","received_events_url":"https://api.github.com/users/narenranjit/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/forio/flow.js/pulls/31/commits","review_comments_url":"https://api.github.com/repos/forio/flow.js/pulls/31/comments","review_comment_url":"https://api.github.com/repos/forio/flow.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/forio/flow.js/issues/31/comments","statuses_url":"https://api.github.com/repos/forio/flow.js/statuses/0b4bfda14c6346f110dc9abbad109f7cc7d792e0","head":{"label":"forio:epicenter-346-docs-breakup","ref":"epicenter-346-docs-breakup","sha":"0b4bfda14c6346f110dc9abbad109f7cc7d792e0","user":{"login":"forio","id":1878641,"avatar_url":"https://avatars.githubusercontent.com/u/1878641?v=3","gravatar_id":"","url":"https://api.github.com/users/forio","html_url":"https://github.com/forio","followers_url":"https://api.github.com/users/forio/followers","following_url":"https://api.github.com/users/forio/following{/other_user}","gists_url":"https://api.github.com/users/forio/gists{/gist_id}","starred_url":"https://api.github.com/users/forio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forio/subscriptions","organizations_url":"https://api.github.com/users/forio/orgs","repos_url":"https://api.github.com/users/forio/repos","events_url":"https://api.github.com/users/forio/events{/privacy}","received_events_url":"https://api.github.com/users/forio/received_events","type":"Organization","site_admin":false},"repo":{"id":21434079,"name":"flow.js","full_name":"forio/flow.js","owner":{"login":"forio","id":1878641,"avatar_url":"https://avatars.githubusercontent.com/u/1878641?v=3","gravatar_id":"","url":"https://api.github.com/users/forio","html_url":"https://github.com/forio","followers_url":"https://api.github.com/users/forio/followers","following_url":"https://api.github.com/users/forio/following{/other_user}","gists_url":"https://api.github.com/users/forio/gists{/gist_id}","starred_url":"https://api.github.com/users/forio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forio/subscriptions","organizations_url":"https://api.github.com/users/forio/orgs","repos_url":"https://api.github.com/users/forio/repos","events_url":"https://api.github.com/users/forio/events{/privacy}","received_events_url":"https://api.github.com/users/forio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/forio/flow.js","description":"Forio's Data-Binding Library","fork":false,"url":"https://api.github.com/repos/forio/flow.js","forks_url":"https://api.github.com/repos/forio/flow.js/forks","keys_url":"https://api.github.com/repos/forio/flow.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/forio/flow.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/forio/flow.js/teams","hooks_url":"https://api.github.com/repos/forio/flow.js/hooks","issue_events_url":"https://api.github.com/repos/forio/flow.js/issues/events{/number}","events_url":"https://api.github.com/repos/forio/flow.js/events","assignees_url":"https://api.github.com/repos/forio/flow.js/assignees{/user}","branches_url":"https://api.github.com/repos/forio/flow.js/branches{/branch}","tags_url":"https://api.github.com/repos/forio/flow.js/tags","blobs_url":"https://api.github.com/repos/forio/flow.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/forio/flow.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/forio/flow.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/forio/flow.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/forio/flow.js/statuses/{sha}","languages_url":"https://api.github.com/repos/forio/flow.js/languages","stargazers_url":"https://api.github.com/repos/forio/flow.js/stargazers","contributors_url":"https://api.github.com/repos/forio/flow.js/contributors","subscribers_url":"https://api.github.com/repos/forio/flow.js/subscribers","subscription_url":"https://api.github.com/repos/forio/flow.js/subscription","commits_url":"https://api.github.com/repos/forio/flow.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/forio/flow.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/forio/flow.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/forio/flow.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/forio/flow.js/contents/{+path}","compare_url":"https://api.github.com/repos/forio/flow.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/forio/flow.js/merges","archive_url":"https://api.github.com/repos/forio/flow.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/forio/flow.js/downloads","issues_url":"https://api.github.com/repos/forio/flow.js/issues{/number}","pulls_url":"https://api.github.com/repos/forio/flow.js/pulls{/number}","milestones_url":"https://api.github.com/repos/forio/flow.js/milestones{/number}","notifications_url":"https://api.github.com/repos/forio/flow.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/forio/flow.js/labels{/name}","releases_url":"https://api.github.com/repos/forio/flow.js/releases{/id}","created_at":"2014-07-02T17:47:18Z","updated_at":"2015-04-23T00:37:24Z","pushed_at":"2015-06-26T00:29:02Z","git_url":"git://github.com/forio/flow.js.git","ssh_url":"git@github.com:forio/flow.js.git","clone_url":"https://github.com/forio/flow.js.git","svn_url":"https://github.com/forio/flow.js","homepage":"https://forio.com/epicenter/docs/public/data_binding_flow_js/","size":2207,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":10,"forks":0,"open_issues":10,"watchers":3,"default_branch":"master"}},"base":{"label":"forio:master","ref":"master","sha":"8abb27befcc86c1a43da1e2ce13277b5a561b726","user":{"login":"forio","id":1878641,"avatar_url":"https://avatars.githubusercontent.com/u/1878641?v=3","gravatar_id":"","url":"https://api.github.com/users/forio","html_url":"https://github.com/forio","followers_url":"https://api.github.com/users/forio/followers","following_url":"https://api.github.com/users/forio/following{/other_user}","gists_url":"https://api.github.com/users/forio/gists{/gist_id}","starred_url":"https://api.github.com/users/forio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forio/subscriptions","organizations_url":"https://api.github.com/users/forio/orgs","repos_url":"https://api.github.com/users/forio/repos","events_url":"https://api.github.com/users/forio/events{/privacy}","received_events_url":"https://api.github.com/users/forio/received_events","type":"Organization","site_admin":false},"repo":{"id":21434079,"name":"flow.js","full_name":"forio/flow.js","owner":{"login":"forio","id":1878641,"avatar_url":"https://avatars.githubusercontent.com/u/1878641?v=3","gravatar_id":"","url":"https://api.github.com/users/forio","html_url":"https://github.com/forio","followers_url":"https://api.github.com/users/forio/followers","following_url":"https://api.github.com/users/forio/following{/other_user}","gists_url":"https://api.github.com/users/forio/gists{/gist_id}","starred_url":"https://api.github.com/users/forio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forio/subscriptions","organizations_url":"https://api.github.com/users/forio/orgs","repos_url":"https://api.github.com/users/forio/repos","events_url":"https://api.github.com/users/forio/events{/privacy}","received_events_url":"https://api.github.com/users/forio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/forio/flow.js","description":"Forio's Data-Binding Library","fork":false,"url":"https://api.github.com/repos/forio/flow.js","forks_url":"https://api.github.com/repos/forio/flow.js/forks","keys_url":"https://api.github.com/repos/forio/flow.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/forio/flow.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/forio/flow.js/teams","hooks_url":"https://api.github.com/repos/forio/flow.js/hooks","issue_events_url":"https://api.github.com/repos/forio/flow.js/issues/events{/number}","events_url":"https://api.github.com/repos/forio/flow.js/events","assignees_url":"https://api.github.com/repos/forio/flow.js/assignees{/user}","branches_url":"https://api.github.com/repos/forio/flow.js/branches{/branch}","tags_url":"https://api.github.com/repos/forio/flow.js/tags","blobs_url":"https://api.github.com/repos/forio/flow.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/forio/flow.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/forio/flow.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/forio/flow.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/forio/flow.js/statuses/{sha}","languages_url":"https://api.github.com/repos/forio/flow.js/languages","stargazers_url":"https://api.github.com/repos/forio/flow.js/stargazers","contributors_url":"https://api.github.com/repos/forio/flow.js/contributors","subscribers_url":"https://api.github.com/repos/forio/flow.js/subscribers","subscription_url":"https://api.github.com/repos/forio/flow.js/subscription","commits_url":"https://api.github.com/repos/forio/flow.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/forio/flow.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/forio/flow.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/forio/flow.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/forio/flow.js/contents/{+path}","compare_url":"https://api.github.com/repos/forio/flow.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/forio/flow.js/merges","archive_url":"https://api.github.com/repos/forio/flow.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/forio/flow.js/downloads","issues_url":"https://api.github.com/repos/forio/flow.js/issues{/number}","pulls_url":"https://api.github.com/repos/forio/flow.js/pulls{/number}","milestones_url":"https://api.github.com/repos/forio/flow.js/milestones{/number}","notifications_url":"https://api.github.com/repos/forio/flow.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/forio/flow.js/labels{/name}","releases_url":"https://api.github.com/repos/forio/flow.js/releases{/id}","created_at":"2014-07-02T17:47:18Z","updated_at":"2015-04-23T00:37:24Z","pushed_at":"2015-06-26T00:29:02Z","git_url":"git://github.com/forio/flow.js.git","ssh_url":"git@github.com:forio/flow.js.git","clone_url":"https://github.com/forio/flow.js.git","svn_url":"https://github.com/forio/flow.js","homepage":"https://forio.com/epicenter/docs/public/data_binding_flow_js/","size":2207,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":10,"forks":0,"open_issues":10,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/forio/flow.js/pulls/31"},"html":{"href":"https://github.com/forio/flow.js/pull/31"},"issue":{"href":"https://api.github.com/repos/forio/flow.js/issues/31"},"comments":{"href":"https://api.github.com/repos/forio/flow.js/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/forio/flow.js/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/forio/flow.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/forio/flow.js/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/forio/flow.js/statuses/0b4bfda14c6346f110dc9abbad109f7cc7d792e0"}}}}