{"action":"closed","number":6,"pull_request":{"url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/pulls/6","id":28811568,"html_url":"https://github.com/newrelic/puppet-nrsysmond/pull/6","diff_url":"https://github.com/newrelic/puppet-nrsysmond/pull/6.diff","patch_url":"https://github.com/newrelic/puppet-nrsysmond/pull/6.patch","issue_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/issues/6","number":6,"state":"closed","locked":false,"title":"rake, spec and CentOS 7 fixes","user":{"login":"jantman","id":273454,"avatar_url":"https://avatars.githubusercontent.com/u/273454?v=3","gravatar_id":"","url":"https://api.github.com/users/jantman","html_url":"https://github.com/jantman","followers_url":"https://api.github.com/users/jantman/followers","following_url":"https://api.github.com/users/jantman/following{/other_user}","gists_url":"https://api.github.com/users/jantman/gists{/gist_id}","starred_url":"https://api.github.com/users/jantman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jantman/subscriptions","organizations_url":"https://api.github.com/users/jantman/orgs","repos_url":"https://api.github.com/users/jantman/repos","events_url":"https://api.github.com/users/jantman/events{/privacy}","received_events_url":"https://api.github.com/users/jantman/received_events","type":"User","site_admin":false},"body":"(1) Fix a number of Rake and spec issues so the tests actually __work__.\r\n\r\n(2) Per https://support.newrelic.com/requests/130089, have Puppet manage the group and user on RedHat 7. This is because of a broken useradd command in the RPM that fails on distros using shadow-utils >= 4.1.5. I strongly disagree with fixing a broken RPM in a Puppet module, but this is what Support told me to do.\r\n\r\nOn a side note:\r\n(1) This module is way out of date in terms of Puppet module standards. It uses a number of deprecated patterns and the spec tests are woefully incomplete. When Puppet4 comes out (which is going to be soon), this module will no longer be functional.\r\n(2) There are a number of places for improvement, such as the exec used to install the Yum repository, when there's a native type for this.","created_at":"2015-02-06T14:22:44Z","updated_at":"2015-03-16T15:45:26Z","closed_at":"2015-03-16T15:45:26Z","merged_at":null,"merge_commit_sha":"3327482b1749c719a215c99adf2afd22a224c0f6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/pulls/6/commits","review_comments_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/pulls/6/comments","review_comment_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/pulls/comments{/number}","comments_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/issues/6/comments","statuses_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/statuses/233676cecf0102d8585c5ac4950918296e18831b","head":{"label":"coxmediagroup:centos7","ref":"centos7","sha":"233676cecf0102d8585c5ac4950918296e18831b","user":{"login":"coxmediagroup","id":370145,"avatar_url":"https://avatars.githubusercontent.com/u/370145?v=3","gravatar_id":"","url":"https://api.github.com/users/coxmediagroup","html_url":"https://github.com/coxmediagroup","followers_url":"https://api.github.com/users/coxmediagroup/followers","following_url":"https://api.github.com/users/coxmediagroup/following{/other_user}","gists_url":"https://api.github.com/users/coxmediagroup/gists{/gist_id}","starred_url":"https://api.github.com/users/coxmediagroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coxmediagroup/subscriptions","organizations_url":"https://api.github.com/users/coxmediagroup/orgs","repos_url":"https://api.github.com/users/coxmediagroup/repos","events_url":"https://api.github.com/users/coxmediagroup/events{/privacy}","received_events_url":"https://api.github.com/users/coxmediagroup/received_events","type":"Organization","site_admin":false},"repo":{"id":30408762,"name":"puppet-nrsysmond","full_name":"coxmediagroup/puppet-nrsysmond","owner":{"login":"coxmediagroup","id":370145,"avatar_url":"https://avatars.githubusercontent.com/u/370145?v=3","gravatar_id":"","url":"https://api.github.com/users/coxmediagroup","html_url":"https://github.com/coxmediagroup","followers_url":"https://api.github.com/users/coxmediagroup/followers","following_url":"https://api.github.com/users/coxmediagroup/following{/other_user}","gists_url":"https://api.github.com/users/coxmediagroup/gists{/gist_id}","starred_url":"https://api.github.com/users/coxmediagroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coxmediagroup/subscriptions","organizations_url":"https://api.github.com/users/coxmediagroup/orgs","repos_url":"https://api.github.com/users/coxmediagroup/repos","events_url":"https://api.github.com/users/coxmediagroup/events{/privacy}","received_events_url":"https://api.github.com/users/coxmediagroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coxmediagroup/puppet-nrsysmond","description":"Puppet module to install the New Relic Server Monitor","fork":true,"url":"https://api.github.com/repos/coxmediagroup/puppet-nrsysmond","forks_url":"https://api.github.com/repos/coxmediagroup/puppet-nrsysmond/forks","keys_url":"https://api.github.com/repos/coxmediagroup/puppet-nrsysmond/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coxmediagroup/puppet-nrsysmond/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coxmediagroup/puppet-nrsysmond/teams","hooks_url":"https://api.github.com/repos/coxmediagroup/puppet-nrsysmond/hooks","issue_events_url":"https://api.github.com/repos/coxmediagroup/puppet-nrsysmond/issues/events{/number}","events_url":"https://api.github.com/repos/coxmediagroup/puppet-nrsysmond/events","assignees_url":"https://api.github.com/repos/coxmediagroup/puppet-nrsysmond/assignees{/user}","branches_url":"https://api.github.com/repos/coxmediagroup/puppet-nrsysmond/branches{/branch}","tags_url":"https://api.github.com/repos/coxmediagroup/puppet-nrsysmond/tags","blobs_url":"https://api.github.com/repos/coxmediagroup/puppet-nrsysmond/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coxmediagroup/puppet-nrsysmond/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coxmediagroup/puppet-nrsysmond/git/refs{/sha}","trees_url":"https://api.github.com/repos/coxmediagroup/puppet-nrsysmond/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coxmediagroup/puppet-nrsysmond/statuses/{sha}","languages_url":"https://api.github.com/repos/coxmediagroup/puppet-nrsysmond/languages","stargazers_url":"https://api.github.com/repos/coxmediagroup/puppet-nrsysmond/stargazers","contributors_url":"https://api.github.com/repos/coxmediagroup/puppet-nrsysmond/contributors","subscribers_url":"https://api.github.com/repos/coxmediagroup/puppet-nrsysmond/subscribers","subscription_url":"https://api.github.com/repos/coxmediagroup/puppet-nrsysmond/subscription","commits_url":"https://api.github.com/repos/coxmediagroup/puppet-nrsysmond/commits{/sha}","git_commits_url":"https://api.github.com/repos/coxmediagroup/puppet-nrsysmond/git/commits{/sha}","comments_url":"https://api.github.com/repos/coxmediagroup/puppet-nrsysmond/comments{/number}","issue_comment_url":"https://api.github.com/repos/coxmediagroup/puppet-nrsysmond/issues/comments{/number}","contents_url":"https://api.github.com/repos/coxmediagroup/puppet-nrsysmond/contents/{+path}","compare_url":"https://api.github.com/repos/coxmediagroup/puppet-nrsysmond/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coxmediagroup/puppet-nrsysmond/merges","archive_url":"https://api.github.com/repos/coxmediagroup/puppet-nrsysmond/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coxmediagroup/puppet-nrsysmond/downloads","issues_url":"https://api.github.com/repos/coxmediagroup/puppet-nrsysmond/issues{/number}","pulls_url":"https://api.github.com/repos/coxmediagroup/puppet-nrsysmond/pulls{/number}","milestones_url":"https://api.github.com/repos/coxmediagroup/puppet-nrsysmond/milestones{/number}","notifications_url":"https://api.github.com/repos/coxmediagroup/puppet-nrsysmond/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coxmediagroup/puppet-nrsysmond/labels{/name}","releases_url":"https://api.github.com/repos/coxmediagroup/puppet-nrsysmond/releases{/id}","created_at":"2015-02-06T11:14:37Z","updated_at":"2015-02-06T11:14:38Z","pushed_at":"2015-03-16T15:43:31Z","git_url":"git://github.com/coxmediagroup/puppet-nrsysmond.git","ssh_url":"git@github.com:coxmediagroup/puppet-nrsysmond.git","clone_url":"https://github.com/coxmediagroup/puppet-nrsysmond.git","svn_url":"https://github.com/coxmediagroup/puppet-nrsysmond","homepage":null,"size":143,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"newrelic:master","ref":"master","sha":"4e59d20002a58a0ef6a66bea2455d3133729446a","user":{"login":"newrelic","id":31739,"avatar_url":"https://avatars.githubusercontent.com/u/31739?v=3","gravatar_id":"","url":"https://api.github.com/users/newrelic","html_url":"https://github.com/newrelic","followers_url":"https://api.github.com/users/newrelic/followers","following_url":"https://api.github.com/users/newrelic/following{/other_user}","gists_url":"https://api.github.com/users/newrelic/gists{/gist_id}","starred_url":"https://api.github.com/users/newrelic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newrelic/subscriptions","organizations_url":"https://api.github.com/users/newrelic/orgs","repos_url":"https://api.github.com/users/newrelic/repos","events_url":"https://api.github.com/users/newrelic/events{/privacy}","received_events_url":"https://api.github.com/users/newrelic/received_events","type":"Organization","site_admin":false},"repo":{"id":6587070,"name":"puppet-nrsysmond","full_name":"newrelic/puppet-nrsysmond","owner":{"login":"newrelic","id":31739,"avatar_url":"https://avatars.githubusercontent.com/u/31739?v=3","gravatar_id":"","url":"https://api.github.com/users/newrelic","html_url":"https://github.com/newrelic","followers_url":"https://api.github.com/users/newrelic/followers","following_url":"https://api.github.com/users/newrelic/following{/other_user}","gists_url":"https://api.github.com/users/newrelic/gists{/gist_id}","starred_url":"https://api.github.com/users/newrelic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newrelic/subscriptions","organizations_url":"https://api.github.com/users/newrelic/orgs","repos_url":"https://api.github.com/users/newrelic/repos","events_url":"https://api.github.com/users/newrelic/events{/privacy}","received_events_url":"https://api.github.com/users/newrelic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/newrelic/puppet-nrsysmond","description":"Puppet module to install the New Relic Server Monitor","fork":false,"url":"https://api.github.com/repos/newrelic/puppet-nrsysmond","forks_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/forks","keys_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/keys{/key_id}","collaborators_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/teams","hooks_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/hooks","issue_events_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/issues/events{/number}","events_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/events","assignees_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/assignees{/user}","branches_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/branches{/branch}","tags_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/tags","blobs_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/git/refs{/sha}","trees_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/git/trees{/sha}","statuses_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/statuses/{sha}","languages_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/languages","stargazers_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/stargazers","contributors_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/contributors","subscribers_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/subscribers","subscription_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/subscription","commits_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/commits{/sha}","git_commits_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/git/commits{/sha}","comments_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/comments{/number}","issue_comment_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/issues/comments{/number}","contents_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/contents/{+path}","compare_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/compare/{base}...{head}","merges_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/merges","archive_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/downloads","issues_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/issues{/number}","pulls_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/pulls{/number}","milestones_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/milestones{/number}","notifications_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/labels{/name}","releases_url":"https://api.github.com/repos/newrelic/puppet-nrsysmond/releases{/id}","created_at":"2012-11-07T22:01:18Z","updated_at":"2015-01-03T00:29:07Z","pushed_at":"2014-03-19T00:08:20Z","git_url":"git://github.com/newrelic/puppet-nrsysmond.git","ssh_url":"git@github.com:newrelic/puppet-nrsysmond.git","clone_url":"https://github.com/newrelic/puppet-nrsysmond.git","svn_url":"https://github.com/newrelic/puppet-nrsysmond","homepage":null,"size":241,"stargazers_count":7,"watchers_count":7,"language":"Puppet","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":3,"forks":7,"open_issues":3,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/newrelic/puppet-nrsysmond/pulls/6"},"html":{"href":"https://github.com/newrelic/puppet-nrsysmond/pull/6"},"issue":{"href":"https://api.github.com/repos/newrelic/puppet-nrsysmond/issues/6"},"comments":{"href":"https://api.github.com/repos/newrelic/puppet-nrsysmond/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/newrelic/puppet-nrsysmond/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/newrelic/puppet-nrsysmond/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/newrelic/puppet-nrsysmond/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/newrelic/puppet-nrsysmond/statuses/233676cecf0102d8585c5ac4950918296e18831b"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":6,"review_comments":1,"commits":7,"additions":161,"deletions":25,"changed_files":9}}