{"action":"created","issue":{"url":"https://api.github.com/repos/dariomanesku/cmft/issues/13","labels_url":"https://api.github.com/repos/dariomanesku/cmft/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/dariomanesku/cmft/issues/13/comments","events_url":"https://api.github.com/repos/dariomanesku/cmft/issues/13/events","html_url":"https://github.com/dariomanesku/cmft/pull/13","id":106733267,"number":13,"title":"incorrect AABB in determineFilterArea - fix filterSize value","user":{"login":"plepers","id":1036540,"avatar_url":"https://avatars.githubusercontent.com/u/1036540?v=3","gravatar_id":"","url":"https://api.github.com/users/plepers","html_url":"https://github.com/plepers","followers_url":"https://api.github.com/users/plepers/followers","following_url":"https://api.github.com/users/plepers/following{/other_user}","gists_url":"https://api.github.com/users/plepers/gists{/gist_id}","starred_url":"https://api.github.com/users/plepers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plepers/subscriptions","organizations_url":"https://api.github.com/users/plepers/orgs","repos_url":"https://api.github.com/users/plepers/repos","events_url":"https://api.github.com/users/plepers/events{/privacy}","received_events_url":"https://api.github.com/users/plepers/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-09-16T09:17:40Z","updated_at":"2015-09-23T23:58:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dariomanesku/cmft/pulls/13","html_url":"https://github.com/dariomanesku/cmft/pull/13","diff_url":"https://github.com/dariomanesku/cmft/pull/13.diff","patch_url":"https://github.com/dariomanesku/cmft/pull/13.patch"},"body":"Hi,\r\n\r\nRadiance filter create some artifact when gloss become low ( ~< 3 ). \r\n\r\n![aabb_issue](https://cloud.githubusercontent.com/assets/1036540/9900601/25b6a75e-5c62-11e5-92cd-cc3ff013ace8.png)\r\n\r\nIt seem to come from incorrect `filterSize` and thus incorrect filter areas (aabb).\r\nI'm not 100% confident about fix i've done, but, `filterAngle` is already half the filter cone angle so `filterSize` should just be :\r\n\r\n```\r\nfilterSize = filterAngle / ( texelAngle * facesize )\r\n```\r\n\r\nMoreover, changing `filterSize`here can have some side effects I didn't noticed. Maybe we should just double filterSize, locally, in `determineFilterArea`function.\r\n\r\nPierre"},"comment":{"url":"https://api.github.com/repos/dariomanesku/cmft/issues/comments/142763957","html_url":"https://github.com/dariomanesku/cmft/pull/13#issuecomment-142763957","issue_url":"https://api.github.com/repos/dariomanesku/cmft/issues/13","id":142763957,"user":{"login":"dariomanesku","id":1139260,"avatar_url":"https://avatars.githubusercontent.com/u/1139260?v=3","gravatar_id":"","url":"https://api.github.com/users/dariomanesku","html_url":"https://github.com/dariomanesku","followers_url":"https://api.github.com/users/dariomanesku/followers","following_url":"https://api.github.com/users/dariomanesku/following{/other_user}","gists_url":"https://api.github.com/users/dariomanesku/gists{/gist_id}","starred_url":"https://api.github.com/users/dariomanesku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dariomanesku/subscriptions","organizations_url":"https://api.github.com/users/dariomanesku/orgs","repos_url":"https://api.github.com/users/dariomanesku/repos","events_url":"https://api.github.com/users/dariomanesku/events{/privacy}","received_events_url":"https://api.github.com/users/dariomanesku/received_events","type":"User","site_admin":false},"created_at":"2015-09-23T23:58:17Z","updated_at":"2015-09-23T23:58:17Z","body":"Yup, you're right. Thanks for the report. `filterSize` is there to speed things up, but it seems that it has a wrong value for small gloss parameters. Using a bigger value for it fixes the problem with the results, but at a performance cost.\r\n\r\nI'll have a look over it on first occasion."}}