{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/pulls/comments/24778141","id":24778141,"diff_hunk":"@@ -78,8 +78,15 @@ func (self *kubeNodes) List() (*NodeList, error) {\n \t\t\tnodeList.Items[Host(node.Name)] = Info{PublicIP: node.Status.HostIP, InternalIP: addrs[0].String()}\n \t\t\tgoodNodes = append(goodNodes, node.Name)\n \t\t} else {\n-\t\t\tglog.Errorf(\"Skipping host %s since looking up its IP failed - %s\", node.Name, err)\n-\t\t\tself.recordNodeError(node.Name)\n+\t\t\tip := net.ParseIP(node.Name)","path":"sources/nodes/kube.go","position":6,"original_position":6,"commit_id":"3b3ee5bbc01c0b4fab125c72df24cbd243403bb9","original_commit_id":"3b3ee5bbc01c0b4fab125c72df24cbd243403bb9","user":{"login":"cedbossneo","id":2912737,"avatar_url":"https://avatars.githubusercontent.com/u/2912737?v=3","gravatar_id":"","url":"https://api.github.com/users/cedbossneo","html_url":"https://github.com/cedbossneo","followers_url":"https://api.github.com/users/cedbossneo/followers","following_url":"https://api.github.com/users/cedbossneo/following{/other_user}","gists_url":"https://api.github.com/users/cedbossneo/gists{/gist_id}","starred_url":"https://api.github.com/users/cedbossneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cedbossneo/subscriptions","organizations_url":"https://api.github.com/users/cedbossneo/orgs","repos_url":"https://api.github.com/users/cedbossneo/repos","events_url":"https://api.github.com/users/cedbossneo/events{/privacy}","received_events_url":"https://api.github.com/users/cedbossneo/received_events","type":"User","site_admin":false},"body":"We can, some systems use IP instead to avoid hostname resolution issues.\n\nLe Mon Feb 16 2015 at 19:03:03, Vish Kannan <notifications@github.com> a\nécrit :\n\n> In sources/nodes/kube.go\n> <https://github.com/GoogleCloudPlatform/heapster/pull/105#discussion_r24766205>\n> :\n>\n> > @@ -78,8 +78,15 @@ func (self *kubeNodes) List() (*NodeList, error) {\n> >  \t\t\tnodeList.Items[Host(node.Name)] = Info{PublicIP: node.Status.HostIP, InternalIP: addrs[0].String()}\n> >  \t\t\tgoodNodes = append(goodNodes, node.Name)\n> >  \t\t} else {\n> > -\t\t\tglog.Errorf(\"Skipping host %s since looking up its IP failed - %s\", node.Name, err)\n> > -\t\t\tself.recordNodeError(node.Name)\n> > +\t\t\tip := net.ParseIP(node.Name)\n>\n> Is this a custom cluster setup where the node name is its IP? Why so? Why\n> not give the node an unique hostname that can be resolves to an IP?\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/GoogleCloudPlatform/heapster/pull/105/files#r24766205>\n> .\n>\n","created_at":"2015-02-16T21:48:46Z","updated_at":"2015-02-16T21:48:46Z","html_url":"https://github.com/GoogleCloudPlatform/heapster/pull/105#discussion_r24778141","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/pulls/105","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/heapster/pulls/comments/24778141"},"html":{"href":"https://github.com/GoogleCloudPlatform/heapster/pull/105#discussion_r24778141"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/heapster/pulls/105"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/pulls/105","id":29365183,"html_url":"https://github.com/GoogleCloudPlatform/heapster/pull/105","diff_url":"https://github.com/GoogleCloudPlatform/heapster/pull/105.diff","patch_url":"https://github.com/GoogleCloudPlatform/heapster/pull/105.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/issues/105","number":105,"state":"open","locked":false,"title":"Fix Pod with Namespace, fix Minion with IP as Name","user":{"login":"cedbossneo","id":2912737,"avatar_url":"https://avatars.githubusercontent.com/u/2912737?v=3","gravatar_id":"","url":"https://api.github.com/users/cedbossneo","html_url":"https://github.com/cedbossneo","followers_url":"https://api.github.com/users/cedbossneo/followers","following_url":"https://api.github.com/users/cedbossneo/following{/other_user}","gists_url":"https://api.github.com/users/cedbossneo/gists{/gist_id}","starred_url":"https://api.github.com/users/cedbossneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cedbossneo/subscriptions","organizations_url":"https://api.github.com/users/cedbossneo/orgs","repos_url":"https://api.github.com/users/cedbossneo/repos","events_url":"https://api.github.com/users/cedbossneo/events{/privacy}","received_events_url":"https://api.github.com/users/cedbossneo/received_events","type":"User","site_admin":false},"body":"- Fix Pod with Namespace\r\n- Fix Minion with IP as Name instead of Hostname","created_at":"2015-02-16T11:10:14Z","updated_at":"2015-02-16T21:48:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"412bd7712e6cc706a6de6579fb0f7124a56f6207","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/pulls/105/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/pulls/105/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/pulls/comments/{number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/issues/105/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/statuses/3b3ee5bbc01c0b4fab125c72df24cbd243403bb9","head":{"label":"cedbossneo:master","ref":"master","sha":"3b3ee5bbc01c0b4fab125c72df24cbd243403bb9","user":{"login":"cedbossneo","id":2912737,"avatar_url":"https://avatars.githubusercontent.com/u/2912737?v=3","gravatar_id":"","url":"https://api.github.com/users/cedbossneo","html_url":"https://github.com/cedbossneo","followers_url":"https://api.github.com/users/cedbossneo/followers","following_url":"https://api.github.com/users/cedbossneo/following{/other_user}","gists_url":"https://api.github.com/users/cedbossneo/gists{/gist_id}","starred_url":"https://api.github.com/users/cedbossneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cedbossneo/subscriptions","organizations_url":"https://api.github.com/users/cedbossneo/orgs","repos_url":"https://api.github.com/users/cedbossneo/repos","events_url":"https://api.github.com/users/cedbossneo/events{/privacy}","received_events_url":"https://api.github.com/users/cedbossneo/received_events","type":"User","site_admin":false},"repo":{"id":30864751,"name":"heapster","full_name":"cedbossneo/heapster","owner":{"login":"cedbossneo","id":2912737,"avatar_url":"https://avatars.githubusercontent.com/u/2912737?v=3","gravatar_id":"","url":"https://api.github.com/users/cedbossneo","html_url":"https://github.com/cedbossneo","followers_url":"https://api.github.com/users/cedbossneo/followers","following_url":"https://api.github.com/users/cedbossneo/following{/other_user}","gists_url":"https://api.github.com/users/cedbossneo/gists{/gist_id}","starred_url":"https://api.github.com/users/cedbossneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cedbossneo/subscriptions","organizations_url":"https://api.github.com/users/cedbossneo/orgs","repos_url":"https://api.github.com/users/cedbossneo/repos","events_url":"https://api.github.com/users/cedbossneo/events{/privacy}","received_events_url":"https://api.github.com/users/cedbossneo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cedbossneo/heapster","description":"Monitor container resource usage of a Kubernetes cluster","fork":true,"url":"https://api.github.com/repos/cedbossneo/heapster","forks_url":"https://api.github.com/repos/cedbossneo/heapster/forks","keys_url":"https://api.github.com/repos/cedbossneo/heapster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cedbossneo/heapster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cedbossneo/heapster/teams","hooks_url":"https://api.github.com/repos/cedbossneo/heapster/hooks","issue_events_url":"https://api.github.com/repos/cedbossneo/heapster/issues/events{/number}","events_url":"https://api.github.com/repos/cedbossneo/heapster/events","assignees_url":"https://api.github.com/repos/cedbossneo/heapster/assignees{/user}","branches_url":"https://api.github.com/repos/cedbossneo/heapster/branches{/branch}","tags_url":"https://api.github.com/repos/cedbossneo/heapster/tags","blobs_url":"https://api.github.com/repos/cedbossneo/heapster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cedbossneo/heapster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cedbossneo/heapster/git/refs{/sha}","trees_url":"https://api.github.com/repos/cedbossneo/heapster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cedbossneo/heapster/statuses/{sha}","languages_url":"https://api.github.com/repos/cedbossneo/heapster/languages","stargazers_url":"https://api.github.com/repos/cedbossneo/heapster/stargazers","contributors_url":"https://api.github.com/repos/cedbossneo/heapster/contributors","subscribers_url":"https://api.github.com/repos/cedbossneo/heapster/subscribers","subscription_url":"https://api.github.com/repos/cedbossneo/heapster/subscription","commits_url":"https://api.github.com/repos/cedbossneo/heapster/commits{/sha}","git_commits_url":"https://api.github.com/repos/cedbossneo/heapster/git/commits{/sha}","comments_url":"https://api.github.com/repos/cedbossneo/heapster/comments{/number}","issue_comment_url":"https://api.github.com/repos/cedbossneo/heapster/issues/comments/{number}","contents_url":"https://api.github.com/repos/cedbossneo/heapster/contents/{+path}","compare_url":"https://api.github.com/repos/cedbossneo/heapster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cedbossneo/heapster/merges","archive_url":"https://api.github.com/repos/cedbossneo/heapster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cedbossneo/heapster/downloads","issues_url":"https://api.github.com/repos/cedbossneo/heapster/issues{/number}","pulls_url":"https://api.github.com/repos/cedbossneo/heapster/pulls{/number}","milestones_url":"https://api.github.com/repos/cedbossneo/heapster/milestones{/number}","notifications_url":"https://api.github.com/repos/cedbossneo/heapster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cedbossneo/heapster/labels{/name}","releases_url":"https://api.github.com/repos/cedbossneo/heapster/releases{/id}","created_at":"2015-02-16T11:08:58Z","updated_at":"2015-02-16T11:09:25Z","pushed_at":"2015-02-16T11:09:25Z","git_url":"git://github.com/cedbossneo/heapster.git","ssh_url":"git@github.com:cedbossneo/heapster.git","clone_url":"https://github.com/cedbossneo/heapster.git","svn_url":"https://github.com/cedbossneo/heapster","homepage":"","size":18790,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"bdf556031ba87c1daf7494a66c95575e990d3478","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":23272510,"name":"heapster","full_name":"GoogleCloudPlatform/heapster","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/heapster","description":"Monitor container resource usage of a Kubernetes cluster","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/heapster","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/issues/comments/{number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/heapster/releases{/id}","created_at":"2014-08-24T03:50:18Z","updated_at":"2015-02-15T05:56:22Z","pushed_at":"2015-02-15T05:56:22Z","git_url":"git://github.com/GoogleCloudPlatform/heapster.git","ssh_url":"git@github.com:GoogleCloudPlatform/heapster.git","clone_url":"https://github.com/GoogleCloudPlatform/heapster.git","svn_url":"https://github.com/GoogleCloudPlatform/heapster","homepage":"","size":18790,"stargazers_count":197,"watchers_count":197,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":16,"forks":27,"open_issues":16,"watchers":197,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/heapster/pulls/105"},"html":{"href":"https://github.com/GoogleCloudPlatform/heapster/pull/105"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/heapster/issues/105"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/heapster/issues/105/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/heapster/pulls/105/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/heapster/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/heapster/pulls/105/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/heapster/statuses/3b3ee5bbc01c0b4fab125c72df24cbd243403bb9"}}}}