{"action":"created","issue":{"url":"https://api.github.com/repos/GoldenCheetah/GoldenCheetah/issues/1231","labels_url":"https://api.github.com/repos/GoldenCheetah/GoldenCheetah/issues/1231/labels{/name}","comments_url":"https://api.github.com/repos/GoldenCheetah/GoldenCheetah/issues/1231/comments","events_url":"https://api.github.com/repos/GoldenCheetah/GoldenCheetah/issues/1231/events","html_url":"https://github.com/GoldenCheetah/GoldenCheetah/issues/1231","id":53971568,"number":1231,"title":"Average TE wrongly calculated in GC 3.1 for OS X (Build ID 3100)","user":{"login":"WillerZ","id":509064,"avatar_url":"https://avatars.githubusercontent.com/u/509064?v=3","gravatar_id":"","url":"https://api.github.com/users/WillerZ","html_url":"https://github.com/WillerZ","followers_url":"https://api.github.com/users/WillerZ/followers","following_url":"https://api.github.com/users/WillerZ/following{/other_user}","gists_url":"https://api.github.com/users/WillerZ/gists{/gist_id}","starred_url":"https://api.github.com/users/WillerZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WillerZ/subscriptions","organizations_url":"https://api.github.com/users/WillerZ/orgs","repos_url":"https://api.github.com/users/WillerZ/repos","events_url":"https://api.github.com/users/WillerZ/events{/privacy}","received_events_url":"https://api.github.com/users/WillerZ/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-01-10T21:14:20Z","updated_at":"2015-01-10T21:28:04Z","closed_at":null,"body":"I was surprised to see my average TE reported as 32.3% when looking at a turbo trainer FTP test ride. The normal range is 60-100%, and if my result of 32.3% were accurate it would mean I could double my FTP from a lowly 242W merely by improving to the *bottom* of the normal range, transforming me from Cat 4 into a world class athlete. The top of the normal range would make me a shoe-in for the hour record.\r\n\r\nSadly my dreams of signing for Team Sky later this year were dashed when I found that my actual average TE is 76%; so while I should get to 321W with perfect technique I will need to spend some time in the gym before the men in black come calling.\r\n\r\nThe bug appears to be that Golden Cheetah is including (as zero) data points for which there was no TE recorded when calculating the average TE.\r\n\r\nThere are of course two other possibilities: my O_Synce Navi2Coach head unit could be putting zero data points for TE into the .fit file when it shouldn't; or my Stages power meter is sending zero data points for TE when it shouldn't.\r\n\r\nTo try and eliminate these possibilities I uploaded the file to cyclinganalytics.com to see what they calculated as the average TE: they calculated 76%."},"comment":{"url":"https://api.github.com/repos/GoldenCheetah/GoldenCheetah/issues/comments/69472717","html_url":"https://github.com/GoldenCheetah/GoldenCheetah/issues/1231#issuecomment-69472717","issue_url":"https://api.github.com/repos/GoldenCheetah/GoldenCheetah/issues/1231","id":69472717,"user":{"login":"WillerZ","id":509064,"avatar_url":"https://avatars.githubusercontent.com/u/509064?v=3","gravatar_id":"","url":"https://api.github.com/users/WillerZ","html_url":"https://github.com/WillerZ","followers_url":"https://api.github.com/users/WillerZ/followers","following_url":"https://api.github.com/users/WillerZ/following{/other_user}","gists_url":"https://api.github.com/users/WillerZ/gists{/gist_id}","starred_url":"https://api.github.com/users/WillerZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WillerZ/subscriptions","organizations_url":"https://api.github.com/users/WillerZ/orgs","repos_url":"https://api.github.com/users/WillerZ/repos","events_url":"https://api.github.com/users/WillerZ/events{/privacy}","received_events_url":"https://api.github.com/users/WillerZ/received_events","type":"User","site_admin":false},"created_at":"2015-01-10T21:28:04Z","updated_at":"2015-01-10T21:28:04Z","body":"I had a cursory look through the code and it looks like the data model requires that all fields which exist at any time are populated at all times; if this impression is correct the fix is to copy the previous existing TE value forwards over the subsequent missing periods.\r\n\r\nThe same problem seems to exist for pedalling smoothness (PS) and the corresponding solution seems appropriate."}}