{"action":"created","issue":{"url":"https://api.github.com/repos/msloth/lgtv.js/issues/14","labels_url":"https://api.github.com/repos/msloth/lgtv.js/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/msloth/lgtv.js/issues/14/comments","events_url":"https://api.github.com/repos/msloth/lgtv.js/issues/14/events","html_url":"https://github.com/msloth/lgtv.js/issues/14","id":121785474,"number":14,"title":"Fork, Suggestion","user":{"login":"hobbyquaker","id":2503307,"avatar_url":"https://avatars.githubusercontent.com/u/2503307?v=3","gravatar_id":"","url":"https://api.github.com/users/hobbyquaker","html_url":"https://github.com/hobbyquaker","followers_url":"https://api.github.com/users/hobbyquaker/followers","following_url":"https://api.github.com/users/hobbyquaker/following{/other_user}","gists_url":"https://api.github.com/users/hobbyquaker/gists{/gist_id}","starred_url":"https://api.github.com/users/hobbyquaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hobbyquaker/subscriptions","organizations_url":"https://api.github.com/users/hobbyquaker/orgs","repos_url":"https://api.github.com/users/hobbyquaker/repos","events_url":"https://api.github.com/users/hobbyquaker/events{/privacy}","received_events_url":"https://api.github.com/users/hobbyquaker/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-11T20:26:19Z","updated_at":"2015-12-15T10:50:33Z","closed_at":null,"body":"Hello Marcus,\r\n\r\nI published a rewrite of your lib here: https://github.com/hobbyquaker/lgtv2\r\n\r\nI removed discovery and command wrappers and made a basic lib that just encapsulates the websocket connection handling, the pairing process and the callback handling. Further Improvements are:\r\n* exports a constructor, so you can connect to multiple TVs\r\n* Auto-reconnects to the TV\r\n* Is an EventEmitter, so you get events for connect/discconect/prompt/error \r\n* Callback handling without EventEmitter, Callback timeouts\r\n\r\nMy Intention for doing this rewrite was [lgtv2mqtt](https://github.com/hobbyquaker/lgtv2mqtt), a tool I'm using in my MQTT based home automation and that depends on lgtv2.\r\n\r\nIf you like the changes I made I would suggest to rebuild your lib including your command wrappers that depends on lgtv2 and another lib that handles lg webos auto-discovery, so everything is modular. \r\n\r\nWould be glad to hear your opinion on that,\r\nall the best,\r\nSebastian\r\n"},"comment":{"url":"https://api.github.com/repos/msloth/lgtv.js/issues/comments/164724771","html_url":"https://github.com/msloth/lgtv.js/issues/14#issuecomment-164724771","issue_url":"https://api.github.com/repos/msloth/lgtv.js/issues/14","id":164724771,"user":{"login":"msloth","id":636324,"avatar_url":"https://avatars.githubusercontent.com/u/636324?v=3","gravatar_id":"","url":"https://api.github.com/users/msloth","html_url":"https://github.com/msloth","followers_url":"https://api.github.com/users/msloth/followers","following_url":"https://api.github.com/users/msloth/following{/other_user}","gists_url":"https://api.github.com/users/msloth/gists{/gist_id}","starred_url":"https://api.github.com/users/msloth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msloth/subscriptions","organizations_url":"https://api.github.com/users/msloth/orgs","repos_url":"https://api.github.com/users/msloth/repos","events_url":"https://api.github.com/users/msloth/events{/privacy}","received_events_url":"https://api.github.com/users/msloth/received_events","type":"User","site_admin":false},"created_at":"2015-12-15T10:50:33Z","updated_at":"2015-12-15T10:50:33Z","body":"Hey, thanks! Great! I'm new to more complex sw in node.js/js so I'm still learning. This will be a great learning experience for me, so thanks a lot!\r\n\r\nI don't really know what I'll do with this lib though. I have a lack of time and motivation to keep it up to date and going forward.... :sake: "}}