{"action":"created","comment":{"url":"https://api.github.com/repos/phpseclib/phpseclib/pulls/comments/35163893","id":35163893,"diff_hunk":"@@ -4407,7 +4402,7 @@ function unrevoke($serial)\n      */\n     function getRevoked($serial)\n     {\n-        if (is_array($rclist = $this->_subArray($this->currentCert, 'tbsCertList/revokedCertificates'))) {\n+        if (is_array($rclist = &$this->_subArray($this->currentCert, 'tbsCertList/revokedCertificates'))) {","path":"phpseclib/File/X509.php","position":82,"original_position":82,"commit_id":"49538764d06b6e44d159f229e29061e5bb491a55","original_commit_id":"49538764d06b6e44d159f229e29061e5bb491a55","user":{"login":"bantu","id":189375,"avatar_url":"https://avatars.githubusercontent.com/u/189375?v=3","gravatar_id":"","url":"https://api.github.com/users/bantu","html_url":"https://github.com/bantu","followers_url":"https://api.github.com/users/bantu/followers","following_url":"https://api.github.com/users/bantu/following{/other_user}","gists_url":"https://api.github.com/users/bantu/gists{/gist_id}","starred_url":"https://api.github.com/users/bantu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bantu/subscriptions","organizations_url":"https://api.github.com/users/bantu/orgs","repos_url":"https://api.github.com/users/bantu/repos","events_url":"https://api.github.com/users/bantu/events{/privacy}","received_events_url":"https://api.github.com/users/bantu/received_events","type":"User","site_admin":false},"body":"These changes will probably need looking at more closely. I have those inline statements, btw. They can probably be easily removed too.","created_at":"2015-07-21T22:48:10Z","updated_at":"2015-07-21T22:48:10Z","html_url":"https://github.com/phpseclib/phpseclib/pull/752#discussion_r35163893","pull_request_url":"https://api.github.com/repos/phpseclib/phpseclib/pulls/752","_links":{"self":{"href":"https://api.github.com/repos/phpseclib/phpseclib/pulls/comments/35163893"},"html":{"href":"https://github.com/phpseclib/phpseclib/pull/752#discussion_r35163893"},"pull_request":{"href":"https://api.github.com/repos/phpseclib/phpseclib/pulls/752"}}},"pull_request":{"url":"https://api.github.com/repos/phpseclib/phpseclib/pulls/752","id":40510354,"html_url":"https://github.com/phpseclib/phpseclib/pull/752","diff_url":"https://github.com/phpseclib/phpseclib/pull/752.diff","patch_url":"https://github.com/phpseclib/phpseclib/pull/752.patch","issue_url":"https://api.github.com/repos/phpseclib/phpseclib/issues/752","number":752,"state":"open","locked":false,"title":"Static Code Analysis with Php Inspections (EA Extended)","user":{"login":"kalessil","id":1577185,"avatar_url":"https://avatars.githubusercontent.com/u/1577185?v=3","gravatar_id":"","url":"https://api.github.com/users/kalessil","html_url":"https://github.com/kalessil","followers_url":"https://api.github.com/users/kalessil/followers","following_url":"https://api.github.com/users/kalessil/following{/other_user}","gists_url":"https://api.github.com/users/kalessil/gists{/gist_id}","starred_url":"https://api.github.com/users/kalessil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalessil/subscriptions","organizations_url":"https://api.github.com/users/kalessil/orgs","repos_url":"https://api.github.com/users/kalessil/repos","events_url":"https://api.github.com/users/kalessil/events{/privacy}","received_events_url":"https://api.github.com/users/kalessil/received_events","type":"User","site_admin":false},"body":"Non-functional changes, fixed bunch of memory mismatches, modernized code (PHP 5.3 compatible)","created_at":"2015-07-21T22:05:27Z","updated_at":"2015-07-21T22:48:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03be306a13c4074ba81d9174c3ab45325907aaca","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/phpseclib/phpseclib/pulls/752/commits","review_comments_url":"https://api.github.com/repos/phpseclib/phpseclib/pulls/752/comments","review_comment_url":"https://api.github.com/repos/phpseclib/phpseclib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phpseclib/phpseclib/issues/752/comments","statuses_url":"https://api.github.com/repos/phpseclib/phpseclib/statuses/49538764d06b6e44d159f229e29061e5bb491a55","head":{"label":"kalessil:fb-sca","ref":"fb-sca","sha":"49538764d06b6e44d159f229e29061e5bb491a55","user":{"login":"kalessil","id":1577185,"avatar_url":"https://avatars.githubusercontent.com/u/1577185?v=3","gravatar_id":"","url":"https://api.github.com/users/kalessil","html_url":"https://github.com/kalessil","followers_url":"https://api.github.com/users/kalessil/followers","following_url":"https://api.github.com/users/kalessil/following{/other_user}","gists_url":"https://api.github.com/users/kalessil/gists{/gist_id}","starred_url":"https://api.github.com/users/kalessil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalessil/subscriptions","organizations_url":"https://api.github.com/users/kalessil/orgs","repos_url":"https://api.github.com/users/kalessil/repos","events_url":"https://api.github.com/users/kalessil/events{/privacy}","received_events_url":"https://api.github.com/users/kalessil/received_events","type":"User","site_admin":false},"repo":{"id":39469865,"name":"phpseclib","full_name":"kalessil/phpseclib","owner":{"login":"kalessil","id":1577185,"avatar_url":"https://avatars.githubusercontent.com/u/1577185?v=3","gravatar_id":"","url":"https://api.github.com/users/kalessil","html_url":"https://github.com/kalessil","followers_url":"https://api.github.com/users/kalessil/followers","following_url":"https://api.github.com/users/kalessil/following{/other_user}","gists_url":"https://api.github.com/users/kalessil/gists{/gist_id}","starred_url":"https://api.github.com/users/kalessil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalessil/subscriptions","organizations_url":"https://api.github.com/users/kalessil/orgs","repos_url":"https://api.github.com/users/kalessil/repos","events_url":"https://api.github.com/users/kalessil/events{/privacy}","received_events_url":"https://api.github.com/users/kalessil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kalessil/phpseclib","description":"PHP Secure Communications Library","fork":true,"url":"https://api.github.com/repos/kalessil/phpseclib","forks_url":"https://api.github.com/repos/kalessil/phpseclib/forks","keys_url":"https://api.github.com/repos/kalessil/phpseclib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kalessil/phpseclib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kalessil/phpseclib/teams","hooks_url":"https://api.github.com/repos/kalessil/phpseclib/hooks","issue_events_url":"https://api.github.com/repos/kalessil/phpseclib/issues/events{/number}","events_url":"https://api.github.com/repos/kalessil/phpseclib/events","assignees_url":"https://api.github.com/repos/kalessil/phpseclib/assignees{/user}","branches_url":"https://api.github.com/repos/kalessil/phpseclib/branches{/branch}","tags_url":"https://api.github.com/repos/kalessil/phpseclib/tags","blobs_url":"https://api.github.com/repos/kalessil/phpseclib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kalessil/phpseclib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kalessil/phpseclib/git/refs{/sha}","trees_url":"https://api.github.com/repos/kalessil/phpseclib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kalessil/phpseclib/statuses/{sha}","languages_url":"https://api.github.com/repos/kalessil/phpseclib/languages","stargazers_url":"https://api.github.com/repos/kalessil/phpseclib/stargazers","contributors_url":"https://api.github.com/repos/kalessil/phpseclib/contributors","subscribers_url":"https://api.github.com/repos/kalessil/phpseclib/subscribers","subscription_url":"https://api.github.com/repos/kalessil/phpseclib/subscription","commits_url":"https://api.github.com/repos/kalessil/phpseclib/commits{/sha}","git_commits_url":"https://api.github.com/repos/kalessil/phpseclib/git/commits{/sha}","comments_url":"https://api.github.com/repos/kalessil/phpseclib/comments{/number}","issue_comment_url":"https://api.github.com/repos/kalessil/phpseclib/issues/comments{/number}","contents_url":"https://api.github.com/repos/kalessil/phpseclib/contents/{+path}","compare_url":"https://api.github.com/repos/kalessil/phpseclib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kalessil/phpseclib/merges","archive_url":"https://api.github.com/repos/kalessil/phpseclib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kalessil/phpseclib/downloads","issues_url":"https://api.github.com/repos/kalessil/phpseclib/issues{/number}","pulls_url":"https://api.github.com/repos/kalessil/phpseclib/pulls{/number}","milestones_url":"https://api.github.com/repos/kalessil/phpseclib/milestones{/number}","notifications_url":"https://api.github.com/repos/kalessil/phpseclib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kalessil/phpseclib/labels{/name}","releases_url":"https://api.github.com/repos/kalessil/phpseclib/releases{/id}","created_at":"2015-07-21T21:05:23Z","updated_at":"2015-07-21T21:05:24Z","pushed_at":"2015-07-21T22:03:35Z","git_url":"git://github.com/kalessil/phpseclib.git","ssh_url":"git@github.com:kalessil/phpseclib.git","clone_url":"https://github.com/kalessil/phpseclib.git","svn_url":"https://github.com/kalessil/phpseclib","homepage":"http://phpseclib.sourceforge.net","size":10482,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"phpseclib:master","ref":"master","sha":"34b572129eea5b107422063d220905dc3d318b61","user":{"login":"phpseclib","id":1820952,"avatar_url":"https://avatars.githubusercontent.com/u/1820952?v=3","gravatar_id":"","url":"https://api.github.com/users/phpseclib","html_url":"https://github.com/phpseclib","followers_url":"https://api.github.com/users/phpseclib/followers","following_url":"https://api.github.com/users/phpseclib/following{/other_user}","gists_url":"https://api.github.com/users/phpseclib/gists{/gist_id}","starred_url":"https://api.github.com/users/phpseclib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpseclib/subscriptions","organizations_url":"https://api.github.com/users/phpseclib/orgs","repos_url":"https://api.github.com/users/phpseclib/repos","events_url":"https://api.github.com/users/phpseclib/events{/privacy}","received_events_url":"https://api.github.com/users/phpseclib/received_events","type":"Organization","site_admin":false},"repo":{"id":4565995,"name":"phpseclib","full_name":"phpseclib/phpseclib","owner":{"login":"phpseclib","id":1820952,"avatar_url":"https://avatars.githubusercontent.com/u/1820952?v=3","gravatar_id":"","url":"https://api.github.com/users/phpseclib","html_url":"https://github.com/phpseclib","followers_url":"https://api.github.com/users/phpseclib/followers","following_url":"https://api.github.com/users/phpseclib/following{/other_user}","gists_url":"https://api.github.com/users/phpseclib/gists{/gist_id}","starred_url":"https://api.github.com/users/phpseclib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpseclib/subscriptions","organizations_url":"https://api.github.com/users/phpseclib/orgs","repos_url":"https://api.github.com/users/phpseclib/repos","events_url":"https://api.github.com/users/phpseclib/events{/privacy}","received_events_url":"https://api.github.com/users/phpseclib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phpseclib/phpseclib","description":"PHP Secure Communications Library","fork":false,"url":"https://api.github.com/repos/phpseclib/phpseclib","forks_url":"https://api.github.com/repos/phpseclib/phpseclib/forks","keys_url":"https://api.github.com/repos/phpseclib/phpseclib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phpseclib/phpseclib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phpseclib/phpseclib/teams","hooks_url":"https://api.github.com/repos/phpseclib/phpseclib/hooks","issue_events_url":"https://api.github.com/repos/phpseclib/phpseclib/issues/events{/number}","events_url":"https://api.github.com/repos/phpseclib/phpseclib/events","assignees_url":"https://api.github.com/repos/phpseclib/phpseclib/assignees{/user}","branches_url":"https://api.github.com/repos/phpseclib/phpseclib/branches{/branch}","tags_url":"https://api.github.com/repos/phpseclib/phpseclib/tags","blobs_url":"https://api.github.com/repos/phpseclib/phpseclib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phpseclib/phpseclib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phpseclib/phpseclib/git/refs{/sha}","trees_url":"https://api.github.com/repos/phpseclib/phpseclib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phpseclib/phpseclib/statuses/{sha}","languages_url":"https://api.github.com/repos/phpseclib/phpseclib/languages","stargazers_url":"https://api.github.com/repos/phpseclib/phpseclib/stargazers","contributors_url":"https://api.github.com/repos/phpseclib/phpseclib/contributors","subscribers_url":"https://api.github.com/repos/phpseclib/phpseclib/subscribers","subscription_url":"https://api.github.com/repos/phpseclib/phpseclib/subscription","commits_url":"https://api.github.com/repos/phpseclib/phpseclib/commits{/sha}","git_commits_url":"https://api.github.com/repos/phpseclib/phpseclib/git/commits{/sha}","comments_url":"https://api.github.com/repos/phpseclib/phpseclib/comments{/number}","issue_comment_url":"https://api.github.com/repos/phpseclib/phpseclib/issues/comments{/number}","contents_url":"https://api.github.com/repos/phpseclib/phpseclib/contents/{+path}","compare_url":"https://api.github.com/repos/phpseclib/phpseclib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phpseclib/phpseclib/merges","archive_url":"https://api.github.com/repos/phpseclib/phpseclib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phpseclib/phpseclib/downloads","issues_url":"https://api.github.com/repos/phpseclib/phpseclib/issues{/number}","pulls_url":"https://api.github.com/repos/phpseclib/phpseclib/pulls{/number}","milestones_url":"https://api.github.com/repos/phpseclib/phpseclib/milestones{/number}","notifications_url":"https://api.github.com/repos/phpseclib/phpseclib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phpseclib/phpseclib/labels{/name}","releases_url":"https://api.github.com/repos/phpseclib/phpseclib/releases{/id}","created_at":"2012-06-05T21:55:28Z","updated_at":"2015-07-21T21:05:19Z","pushed_at":"2015-07-21T22:05:27Z","git_url":"git://github.com/phpseclib/phpseclib.git","ssh_url":"git@github.com:phpseclib/phpseclib.git","clone_url":"https://github.com/phpseclib/phpseclib.git","svn_url":"https://github.com/phpseclib/phpseclib","homepage":"http://phpseclib.sourceforge.net","size":10482,"stargazers_count":757,"watchers_count":757,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":220,"mirror_url":null,"open_issues_count":86,"forks":220,"open_issues":86,"watchers":757,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phpseclib/phpseclib/pulls/752"},"html":{"href":"https://github.com/phpseclib/phpseclib/pull/752"},"issue":{"href":"https://api.github.com/repos/phpseclib/phpseclib/issues/752"},"comments":{"href":"https://api.github.com/repos/phpseclib/phpseclib/issues/752/comments"},"review_comments":{"href":"https://api.github.com/repos/phpseclib/phpseclib/pulls/752/comments"},"review_comment":{"href":"https://api.github.com/repos/phpseclib/phpseclib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phpseclib/phpseclib/pulls/752/commits"},"statuses":{"href":"https://api.github.com/repos/phpseclib/phpseclib/statuses/49538764d06b6e44d159f229e29061e5bb491a55"}}}}