{"action":"closed","number":28,"pull_request":{"url":"https://api.github.com/repos/edsu/microdata/pulls/28","id":43204110,"html_url":"https://github.com/edsu/microdata/pull/28","diff_url":"https://github.com/edsu/microdata/pull/28.diff","patch_url":"https://github.com/edsu/microdata/pull/28.patch","issue_url":"https://api.github.com/repos/edsu/microdata/issues/28","number":28,"state":"closed","locked":false,"title":"Minor get_items improvements","user":{"login":"jesuslosada","id":5754422,"avatar_url":"https://avatars.githubusercontent.com/u/5754422?v=3","gravatar_id":"","url":"https://api.github.com/users/jesuslosada","html_url":"https://github.com/jesuslosada","followers_url":"https://api.github.com/users/jesuslosada/followers","following_url":"https://api.github.com/users/jesuslosada/following{/other_user}","gists_url":"https://api.github.com/users/jesuslosada/gists{/gist_id}","starred_url":"https://api.github.com/users/jesuslosada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jesuslosada/subscriptions","organizations_url":"https://api.github.com/users/jesuslosada/orgs","repos_url":"https://api.github.com/users/jesuslosada/repos","events_url":"https://api.github.com/users/jesuslosada/events{/privacy}","received_events_url":"https://api.github.com/users/jesuslosada/received_events","type":"User","site_admin":false},"body":"Function's documentation has been fixed to specify that it accepts strings and file-like objects.\r\n\r\nThe current version fails when using `unicode` strings with Python 2 (unless you explicitly use `encoding=None`), because of this check that html5lib performs: https://github.com/html5lib/html5lib-python/blob/master/html5lib/inputstream.py#L143\r\nThis pull request fixes that problem and it also allows to pass a encoding value when using Python 3 (there are some cases when you need to do this, as mentioned here: https://github.com/html5lib/html5lib-python/blob/master/README.rst#usage).\r\n\r\nI'd like to suggest renaming the `location` parameter too, since it isn't a location or URL. It's an actual HTML document, so something like `stream` or `document` would fit better in my opinion.","created_at":"2015-08-24T18:12:36Z","updated_at":"2015-08-24T18:31:44Z","closed_at":"2015-08-24T18:31:44Z","merged_at":"2015-08-24T18:31:44Z","merge_commit_sha":"db24db2117d8ba09a21cfa3c88db8accebd837d4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edsu/microdata/pulls/28/commits","review_comments_url":"https://api.github.com/repos/edsu/microdata/pulls/28/comments","review_comment_url":"https://api.github.com/repos/edsu/microdata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edsu/microdata/issues/28/comments","statuses_url":"https://api.github.com/repos/edsu/microdata/statuses/ae65cd6ea175a466a0ae98f56e8e15d8ce9bef0d","head":{"label":"jesuslosada:master","ref":"master","sha":"ae65cd6ea175a466a0ae98f56e8e15d8ce9bef0d","user":{"login":"jesuslosada","id":5754422,"avatar_url":"https://avatars.githubusercontent.com/u/5754422?v=3","gravatar_id":"","url":"https://api.github.com/users/jesuslosada","html_url":"https://github.com/jesuslosada","followers_url":"https://api.github.com/users/jesuslosada/followers","following_url":"https://api.github.com/users/jesuslosada/following{/other_user}","gists_url":"https://api.github.com/users/jesuslosada/gists{/gist_id}","starred_url":"https://api.github.com/users/jesuslosada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jesuslosada/subscriptions","organizations_url":"https://api.github.com/users/jesuslosada/orgs","repos_url":"https://api.github.com/users/jesuslosada/repos","events_url":"https://api.github.com/users/jesuslosada/events{/privacy}","received_events_url":"https://api.github.com/users/jesuslosada/received_events","type":"User","site_admin":false},"repo":{"id":41316734,"name":"microdata","full_name":"jesuslosada/microdata","owner":{"login":"jesuslosada","id":5754422,"avatar_url":"https://avatars.githubusercontent.com/u/5754422?v=3","gravatar_id":"","url":"https://api.github.com/users/jesuslosada","html_url":"https://github.com/jesuslosada","followers_url":"https://api.github.com/users/jesuslosada/followers","following_url":"https://api.github.com/users/jesuslosada/following{/other_user}","gists_url":"https://api.github.com/users/jesuslosada/gists{/gist_id}","starred_url":"https://api.github.com/users/jesuslosada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jesuslosada/subscriptions","organizations_url":"https://api.github.com/users/jesuslosada/orgs","repos_url":"https://api.github.com/users/jesuslosada/repos","events_url":"https://api.github.com/users/jesuslosada/events{/privacy}","received_events_url":"https://api.github.com/users/jesuslosada/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jesuslosada/microdata","description":"python library for extracting html5 microdata","fork":true,"url":"https://api.github.com/repos/jesuslosada/microdata","forks_url":"https://api.github.com/repos/jesuslosada/microdata/forks","keys_url":"https://api.github.com/repos/jesuslosada/microdata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jesuslosada/microdata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jesuslosada/microdata/teams","hooks_url":"https://api.github.com/repos/jesuslosada/microdata/hooks","issue_events_url":"https://api.github.com/repos/jesuslosada/microdata/issues/events{/number}","events_url":"https://api.github.com/repos/jesuslosada/microdata/events","assignees_url":"https://api.github.com/repos/jesuslosada/microdata/assignees{/user}","branches_url":"https://api.github.com/repos/jesuslosada/microdata/branches{/branch}","tags_url":"https://api.github.com/repos/jesuslosada/microdata/tags","blobs_url":"https://api.github.com/repos/jesuslosada/microdata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jesuslosada/microdata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jesuslosada/microdata/git/refs{/sha}","trees_url":"https://api.github.com/repos/jesuslosada/microdata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jesuslosada/microdata/statuses/{sha}","languages_url":"https://api.github.com/repos/jesuslosada/microdata/languages","stargazers_url":"https://api.github.com/repos/jesuslosada/microdata/stargazers","contributors_url":"https://api.github.com/repos/jesuslosada/microdata/contributors","subscribers_url":"https://api.github.com/repos/jesuslosada/microdata/subscribers","subscription_url":"https://api.github.com/repos/jesuslosada/microdata/subscription","commits_url":"https://api.github.com/repos/jesuslosada/microdata/commits{/sha}","git_commits_url":"https://api.github.com/repos/jesuslosada/microdata/git/commits{/sha}","comments_url":"https://api.github.com/repos/jesuslosada/microdata/comments{/number}","issue_comment_url":"https://api.github.com/repos/jesuslosada/microdata/issues/comments{/number}","contents_url":"https://api.github.com/repos/jesuslosada/microdata/contents/{+path}","compare_url":"https://api.github.com/repos/jesuslosada/microdata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jesuslosada/microdata/merges","archive_url":"https://api.github.com/repos/jesuslosada/microdata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jesuslosada/microdata/downloads","issues_url":"https://api.github.com/repos/jesuslosada/microdata/issues{/number}","pulls_url":"https://api.github.com/repos/jesuslosada/microdata/pulls{/number}","milestones_url":"https://api.github.com/repos/jesuslosada/microdata/milestones{/number}","notifications_url":"https://api.github.com/repos/jesuslosada/microdata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jesuslosada/microdata/labels{/name}","releases_url":"https://api.github.com/repos/jesuslosada/microdata/releases{/id}","created_at":"2015-08-24T17:18:30Z","updated_at":"2015-08-24T17:18:30Z","pushed_at":"2015-08-24T17:53:03Z","git_url":"git://github.com/jesuslosada/microdata.git","ssh_url":"git@github.com:jesuslosada/microdata.git","clone_url":"https://github.com/jesuslosada/microdata.git","svn_url":"https://github.com/jesuslosada/microdata","homepage":"","size":120,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"edsu:master","ref":"master","sha":"f03464c215f757a2e4420d2f1f1af8051be2a8fc","user":{"login":"edsu","id":33829,"avatar_url":"https://avatars.githubusercontent.com/u/33829?v=3","gravatar_id":"","url":"https://api.github.com/users/edsu","html_url":"https://github.com/edsu","followers_url":"https://api.github.com/users/edsu/followers","following_url":"https://api.github.com/users/edsu/following{/other_user}","gists_url":"https://api.github.com/users/edsu/gists{/gist_id}","starred_url":"https://api.github.com/users/edsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edsu/subscriptions","organizations_url":"https://api.github.com/users/edsu/orgs","repos_url":"https://api.github.com/users/edsu/repos","events_url":"https://api.github.com/users/edsu/events{/privacy}","received_events_url":"https://api.github.com/users/edsu/received_events","type":"User","site_admin":false},"repo":{"id":1863359,"name":"microdata","full_name":"edsu/microdata","owner":{"login":"edsu","id":33829,"avatar_url":"https://avatars.githubusercontent.com/u/33829?v=3","gravatar_id":"","url":"https://api.github.com/users/edsu","html_url":"https://github.com/edsu","followers_url":"https://api.github.com/users/edsu/followers","following_url":"https://api.github.com/users/edsu/following{/other_user}","gists_url":"https://api.github.com/users/edsu/gists{/gist_id}","starred_url":"https://api.github.com/users/edsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edsu/subscriptions","organizations_url":"https://api.github.com/users/edsu/orgs","repos_url":"https://api.github.com/users/edsu/repos","events_url":"https://api.github.com/users/edsu/events{/privacy}","received_events_url":"https://api.github.com/users/edsu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edsu/microdata","description":"python library for extracting html5 microdata","fork":false,"url":"https://api.github.com/repos/edsu/microdata","forks_url":"https://api.github.com/repos/edsu/microdata/forks","keys_url":"https://api.github.com/repos/edsu/microdata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edsu/microdata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edsu/microdata/teams","hooks_url":"https://api.github.com/repos/edsu/microdata/hooks","issue_events_url":"https://api.github.com/repos/edsu/microdata/issues/events{/number}","events_url":"https://api.github.com/repos/edsu/microdata/events","assignees_url":"https://api.github.com/repos/edsu/microdata/assignees{/user}","branches_url":"https://api.github.com/repos/edsu/microdata/branches{/branch}","tags_url":"https://api.github.com/repos/edsu/microdata/tags","blobs_url":"https://api.github.com/repos/edsu/microdata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edsu/microdata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edsu/microdata/git/refs{/sha}","trees_url":"https://api.github.com/repos/edsu/microdata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edsu/microdata/statuses/{sha}","languages_url":"https://api.github.com/repos/edsu/microdata/languages","stargazers_url":"https://api.github.com/repos/edsu/microdata/stargazers","contributors_url":"https://api.github.com/repos/edsu/microdata/contributors","subscribers_url":"https://api.github.com/repos/edsu/microdata/subscribers","subscription_url":"https://api.github.com/repos/edsu/microdata/subscription","commits_url":"https://api.github.com/repos/edsu/microdata/commits{/sha}","git_commits_url":"https://api.github.com/repos/edsu/microdata/git/commits{/sha}","comments_url":"https://api.github.com/repos/edsu/microdata/comments{/number}","issue_comment_url":"https://api.github.com/repos/edsu/microdata/issues/comments{/number}","contents_url":"https://api.github.com/repos/edsu/microdata/contents/{+path}","compare_url":"https://api.github.com/repos/edsu/microdata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edsu/microdata/merges","archive_url":"https://api.github.com/repos/edsu/microdata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edsu/microdata/downloads","issues_url":"https://api.github.com/repos/edsu/microdata/issues{/number}","pulls_url":"https://api.github.com/repos/edsu/microdata/pulls{/number}","milestones_url":"https://api.github.com/repos/edsu/microdata/milestones{/number}","notifications_url":"https://api.github.com/repos/edsu/microdata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edsu/microdata/labels{/name}","releases_url":"https://api.github.com/repos/edsu/microdata/releases{/id}","created_at":"2011-06-08T03:15:14Z","updated_at":"2015-07-21T01:56:09Z","pushed_at":"2015-08-24T18:31:44Z","git_url":"git://github.com/edsu/microdata.git","ssh_url":"git@github.com:edsu/microdata.git","clone_url":"https://github.com/edsu/microdata.git","svn_url":"https://github.com/edsu/microdata","homepage":"","size":273,"stargazers_count":68,"watchers_count":68,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":5,"forks":18,"open_issues":5,"watchers":68,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edsu/microdata/pulls/28"},"html":{"href":"https://github.com/edsu/microdata/pull/28"},"issue":{"href":"https://api.github.com/repos/edsu/microdata/issues/28"},"comments":{"href":"https://api.github.com/repos/edsu/microdata/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/edsu/microdata/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/edsu/microdata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edsu/microdata/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/edsu/microdata/statuses/ae65cd6ea175a466a0ae98f56e8e15d8ce9bef0d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"edsu","id":33829,"avatar_url":"https://avatars.githubusercontent.com/u/33829?v=3","gravatar_id":"","url":"https://api.github.com/users/edsu","html_url":"https://github.com/edsu","followers_url":"https://api.github.com/users/edsu/followers","following_url":"https://api.github.com/users/edsu/following{/other_user}","gists_url":"https://api.github.com/users/edsu/gists{/gist_id}","starred_url":"https://api.github.com/users/edsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edsu/subscriptions","organizations_url":"https://api.github.com/users/edsu/orgs","repos_url":"https://api.github.com/users/edsu/repos","events_url":"https://api.github.com/users/edsu/events{/privacy}","received_events_url":"https://api.github.com/users/edsu/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":3,"deletions":8,"changed_files":1}}