{"action":"closed","number":1145,"pull_request":{"url":"https://api.github.com/repos/n1k0/casperjs/pulls/1145","id":28312245,"html_url":"https://github.com/n1k0/casperjs/pull/1145","diff_url":"https://github.com/n1k0/casperjs/pull/1145.diff","patch_url":"https://github.com/n1k0/casperjs/pull/1145.patch","issue_url":"https://api.github.com/repos/n1k0/casperjs/issues/1145","number":1145,"state":"closed","locked":false,"title":"WIP: Switching over to ESLint from JSHint","user":{"login":"paazmaya","id":369881,"avatar_url":"https://avatars.githubusercontent.com/u/369881?v=3","gravatar_id":"","url":"https://api.github.com/users/paazmaya","html_url":"https://github.com/paazmaya","followers_url":"https://api.github.com/users/paazmaya/followers","following_url":"https://api.github.com/users/paazmaya/following{/other_user}","gists_url":"https://api.github.com/users/paazmaya/gists{/gist_id}","starred_url":"https://api.github.com/users/paazmaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paazmaya/subscriptions","organizations_url":"https://api.github.com/users/paazmaya/orgs","repos_url":"https://api.github.com/users/paazmaya/repos","events_url":"https://api.github.com/users/paazmaya/events{/privacy}","received_events_url":"https://api.github.com/users/paazmaya/received_events","type":"User","site_admin":false},"body":"Related to #1133.\r\n\r\nSo far the ESLint configuration has been made so that the rules found from earlier JSHint configuration are matched and set to trigger an error (2).\r\nAll the rest are set to trigger warning (1) and need further discussion of how the configure them.\r\n\r\nThere are plenty of inline configurations in the JS files, specifically in the tests, which could be possibly reduced.\r\n\r\nPlease comment.","created_at":"2015-01-29T20:34:14Z","updated_at":"2015-04-13T09:35:34Z","closed_at":"2015-04-13T09:35:34Z","merged_at":"2015-04-13T09:35:34Z","merge_commit_sha":"2406478102c242e214ef3dc7fbec6b21f1c29ad2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/n1k0/casperjs/pulls/1145/commits","review_comments_url":"https://api.github.com/repos/n1k0/casperjs/pulls/1145/comments","review_comment_url":"https://api.github.com/repos/n1k0/casperjs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/n1k0/casperjs/issues/1145/comments","statuses_url":"https://api.github.com/repos/n1k0/casperjs/statuses/019659c6ddbd0ae3df0966bf262b3d02db43b5d7","head":{"label":"paazmaya:1133-switch-using-eslint","ref":"1133-switch-using-eslint","sha":"019659c6ddbd0ae3df0966bf262b3d02db43b5d7","user":{"login":"paazmaya","id":369881,"avatar_url":"https://avatars.githubusercontent.com/u/369881?v=3","gravatar_id":"","url":"https://api.github.com/users/paazmaya","html_url":"https://github.com/paazmaya","followers_url":"https://api.github.com/users/paazmaya/followers","following_url":"https://api.github.com/users/paazmaya/following{/other_user}","gists_url":"https://api.github.com/users/paazmaya/gists{/gist_id}","starred_url":"https://api.github.com/users/paazmaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paazmaya/subscriptions","organizations_url":"https://api.github.com/users/paazmaya/orgs","repos_url":"https://api.github.com/users/paazmaya/repos","events_url":"https://api.github.com/users/paazmaya/events{/privacy}","received_events_url":"https://api.github.com/users/paazmaya/received_events","type":"User","site_admin":false},"repo":{"id":29133118,"name":"casperjs","full_name":"paazmaya/casperjs","owner":{"login":"paazmaya","id":369881,"avatar_url":"https://avatars.githubusercontent.com/u/369881?v=3","gravatar_id":"","url":"https://api.github.com/users/paazmaya","html_url":"https://github.com/paazmaya","followers_url":"https://api.github.com/users/paazmaya/followers","following_url":"https://api.github.com/users/paazmaya/following{/other_user}","gists_url":"https://api.github.com/users/paazmaya/gists{/gist_id}","starred_url":"https://api.github.com/users/paazmaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paazmaya/subscriptions","organizations_url":"https://api.github.com/users/paazmaya/orgs","repos_url":"https://api.github.com/users/paazmaya/repos","events_url":"https://api.github.com/users/paazmaya/events{/privacy}","received_events_url":"https://api.github.com/users/paazmaya/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paazmaya/casperjs","description":"Navigation scripting & testing utility for PhantomJS and SlimerJS","fork":true,"url":"https://api.github.com/repos/paazmaya/casperjs","forks_url":"https://api.github.com/repos/paazmaya/casperjs/forks","keys_url":"https://api.github.com/repos/paazmaya/casperjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paazmaya/casperjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paazmaya/casperjs/teams","hooks_url":"https://api.github.com/repos/paazmaya/casperjs/hooks","issue_events_url":"https://api.github.com/repos/paazmaya/casperjs/issues/events{/number}","events_url":"https://api.github.com/repos/paazmaya/casperjs/events","assignees_url":"https://api.github.com/repos/paazmaya/casperjs/assignees{/user}","branches_url":"https://api.github.com/repos/paazmaya/casperjs/branches{/branch}","tags_url":"https://api.github.com/repos/paazmaya/casperjs/tags","blobs_url":"https://api.github.com/repos/paazmaya/casperjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paazmaya/casperjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paazmaya/casperjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/paazmaya/casperjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paazmaya/casperjs/statuses/{sha}","languages_url":"https://api.github.com/repos/paazmaya/casperjs/languages","stargazers_url":"https://api.github.com/repos/paazmaya/casperjs/stargazers","contributors_url":"https://api.github.com/repos/paazmaya/casperjs/contributors","subscribers_url":"https://api.github.com/repos/paazmaya/casperjs/subscribers","subscription_url":"https://api.github.com/repos/paazmaya/casperjs/subscription","commits_url":"https://api.github.com/repos/paazmaya/casperjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/paazmaya/casperjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/paazmaya/casperjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/paazmaya/casperjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/paazmaya/casperjs/contents/{+path}","compare_url":"https://api.github.com/repos/paazmaya/casperjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paazmaya/casperjs/merges","archive_url":"https://api.github.com/repos/paazmaya/casperjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paazmaya/casperjs/downloads","issues_url":"https://api.github.com/repos/paazmaya/casperjs/issues{/number}","pulls_url":"https://api.github.com/repos/paazmaya/casperjs/pulls{/number}","milestones_url":"https://api.github.com/repos/paazmaya/casperjs/milestones{/number}","notifications_url":"https://api.github.com/repos/paazmaya/casperjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paazmaya/casperjs/labels{/name}","releases_url":"https://api.github.com/repos/paazmaya/casperjs/releases{/id}","created_at":"2015-01-12T11:49:46Z","updated_at":"2015-01-30T09:17:58Z","pushed_at":"2015-04-12T22:07:45Z","git_url":"git://github.com/paazmaya/casperjs.git","ssh_url":"git@github.com:paazmaya/casperjs.git","clone_url":"https://github.com/paazmaya/casperjs.git","svn_url":"https://github.com/paazmaya/casperjs","homepage":"http://casperjs.org/","size":9225,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"n1k0:master","ref":"master","sha":"ccb91ca930fea9d9c44a61b8f17041c87b54358f","user":{"login":"n1k0","id":41547,"avatar_url":"https://avatars.githubusercontent.com/u/41547?v=3","gravatar_id":"","url":"https://api.github.com/users/n1k0","html_url":"https://github.com/n1k0","followers_url":"https://api.github.com/users/n1k0/followers","following_url":"https://api.github.com/users/n1k0/following{/other_user}","gists_url":"https://api.github.com/users/n1k0/gists{/gist_id}","starred_url":"https://api.github.com/users/n1k0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n1k0/subscriptions","organizations_url":"https://api.github.com/users/n1k0/orgs","repos_url":"https://api.github.com/users/n1k0/repos","events_url":"https://api.github.com/users/n1k0/events{/privacy}","received_events_url":"https://api.github.com/users/n1k0/received_events","type":"User","site_admin":false},"repo":{"id":2328523,"name":"casperjs","full_name":"n1k0/casperjs","owner":{"login":"n1k0","id":41547,"avatar_url":"https://avatars.githubusercontent.com/u/41547?v=3","gravatar_id":"","url":"https://api.github.com/users/n1k0","html_url":"https://github.com/n1k0","followers_url":"https://api.github.com/users/n1k0/followers","following_url":"https://api.github.com/users/n1k0/following{/other_user}","gists_url":"https://api.github.com/users/n1k0/gists{/gist_id}","starred_url":"https://api.github.com/users/n1k0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n1k0/subscriptions","organizations_url":"https://api.github.com/users/n1k0/orgs","repos_url":"https://api.github.com/users/n1k0/repos","events_url":"https://api.github.com/users/n1k0/events{/privacy}","received_events_url":"https://api.github.com/users/n1k0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/n1k0/casperjs","description":"Navigation scripting & testing utility for PhantomJS and SlimerJS","fork":false,"url":"https://api.github.com/repos/n1k0/casperjs","forks_url":"https://api.github.com/repos/n1k0/casperjs/forks","keys_url":"https://api.github.com/repos/n1k0/casperjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/n1k0/casperjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/n1k0/casperjs/teams","hooks_url":"https://api.github.com/repos/n1k0/casperjs/hooks","issue_events_url":"https://api.github.com/repos/n1k0/casperjs/issues/events{/number}","events_url":"https://api.github.com/repos/n1k0/casperjs/events","assignees_url":"https://api.github.com/repos/n1k0/casperjs/assignees{/user}","branches_url":"https://api.github.com/repos/n1k0/casperjs/branches{/branch}","tags_url":"https://api.github.com/repos/n1k0/casperjs/tags","blobs_url":"https://api.github.com/repos/n1k0/casperjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/n1k0/casperjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/n1k0/casperjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/n1k0/casperjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/n1k0/casperjs/statuses/{sha}","languages_url":"https://api.github.com/repos/n1k0/casperjs/languages","stargazers_url":"https://api.github.com/repos/n1k0/casperjs/stargazers","contributors_url":"https://api.github.com/repos/n1k0/casperjs/contributors","subscribers_url":"https://api.github.com/repos/n1k0/casperjs/subscribers","subscription_url":"https://api.github.com/repos/n1k0/casperjs/subscription","commits_url":"https://api.github.com/repos/n1k0/casperjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/n1k0/casperjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/n1k0/casperjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/n1k0/casperjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/n1k0/casperjs/contents/{+path}","compare_url":"https://api.github.com/repos/n1k0/casperjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/n1k0/casperjs/merges","archive_url":"https://api.github.com/repos/n1k0/casperjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/n1k0/casperjs/downloads","issues_url":"https://api.github.com/repos/n1k0/casperjs/issues{/number}","pulls_url":"https://api.github.com/repos/n1k0/casperjs/pulls{/number}","milestones_url":"https://api.github.com/repos/n1k0/casperjs/milestones{/number}","notifications_url":"https://api.github.com/repos/n1k0/casperjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/n1k0/casperjs/labels{/name}","releases_url":"https://api.github.com/repos/n1k0/casperjs/releases{/id}","created_at":"2011-09-05T14:01:40Z","updated_at":"2015-04-12T21:26:41Z","pushed_at":"2015-04-13T09:35:34Z","git_url":"git://github.com/n1k0/casperjs.git","ssh_url":"git@github.com:n1k0/casperjs.git","clone_url":"https://github.com/n1k0/casperjs.git","svn_url":"https://github.com/n1k0/casperjs","homepage":"http://casperjs.org/","size":13957,"stargazers_count":4201,"watchers_count":4201,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":690,"mirror_url":null,"open_issues_count":264,"forks":690,"open_issues":264,"watchers":4201,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/n1k0/casperjs/pulls/1145"},"html":{"href":"https://github.com/n1k0/casperjs/pull/1145"},"issue":{"href":"https://api.github.com/repos/n1k0/casperjs/issues/1145"},"comments":{"href":"https://api.github.com/repos/n1k0/casperjs/issues/1145/comments"},"review_comments":{"href":"https://api.github.com/repos/n1k0/casperjs/pulls/1145/comments"},"review_comment":{"href":"https://api.github.com/repos/n1k0/casperjs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/n1k0/casperjs/pulls/1145/commits"},"statuses":{"href":"https://api.github.com/repos/n1k0/casperjs/statuses/019659c6ddbd0ae3df0966bf262b3d02db43b5d7"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mickaelandrieu","id":1247388,"avatar_url":"https://avatars.githubusercontent.com/u/1247388?v=3","gravatar_id":"","url":"https://api.github.com/users/mickaelandrieu","html_url":"https://github.com/mickaelandrieu","followers_url":"https://api.github.com/users/mickaelandrieu/followers","following_url":"https://api.github.com/users/mickaelandrieu/following{/other_user}","gists_url":"https://api.github.com/users/mickaelandrieu/gists{/gist_id}","starred_url":"https://api.github.com/users/mickaelandrieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mickaelandrieu/subscriptions","organizations_url":"https://api.github.com/users/mickaelandrieu/orgs","repos_url":"https://api.github.com/users/mickaelandrieu/repos","events_url":"https://api.github.com/users/mickaelandrieu/events{/privacy}","received_events_url":"https://api.github.com/users/mickaelandrieu/received_events","type":"User","site_admin":false},"comments":8,"review_comments":0,"commits":1,"additions":478,"deletions":279,"changed_files":113}}