{"action":"created","issue":{"url":"https://api.github.com/repos/Civcraft/AFK-Player-GC/issues/10","labels_url":"https://api.github.com/repos/Civcraft/AFK-Player-GC/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/Civcraft/AFK-Player-GC/issues/10/comments","events_url":"https://api.github.com/repos/Civcraft/AFK-Player-GC/issues/10/events","html_url":"https://github.com/Civcraft/AFK-Player-GC/issues/10","id":99249241,"number":10,"title":"Ban handling","user":{"login":"erocs","id":700680,"avatar_url":"https://avatars.githubusercontent.com/u/700680?v=3","gravatar_id":"","url":"https://api.github.com/users/erocs","html_url":"https://github.com/erocs","followers_url":"https://api.github.com/users/erocs/followers","following_url":"https://api.github.com/users/erocs/following{/other_user}","gists_url":"https://api.github.com/users/erocs/gists{/gist_id}","starred_url":"https://api.github.com/users/erocs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erocs/subscriptions","organizations_url":"https://api.github.com/users/erocs/orgs","repos_url":"https://api.github.com/users/erocs/repos","events_url":"https://api.github.com/users/erocs/events{/privacy}","received_events_url":"https://api.github.com/users/erocs/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Civcraft/AFK-Player-GC/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/Civcraft/AFK-Player-GC/labels/P3%20-%20Nice%20to%20have","name":"P3 - Nice to have","color":"006b75"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-08-05T16:50:48Z","updated_at":"2015-08-05T22:55:31Z","closed_at":null,"body":"Per https://www.reddit.com/r/Civcraft/comments/3fv5sw/the_new_lag_detecting_auto_banning_afkpgc_is/ctsgvrt\r\n\r\ngetBanList states \"Bans by name are no longer supported and this method will return null when trying to request them\" yet that is the banlist type being retrieved. Someday it will break.\r\n\r\nDoes getBanList return the MC global ban manager? It looks like we should be able to differentiate this ban from others via the reason. It is also saving out a list of banned players though, so why not use a copy of PrisonPearl's ban manager? Alternatively, these bans shouldn't persist across reboots so just keep a list of UUIDs and block players at the async pre-login event."},"comment":{"url":"https://api.github.com/repos/Civcraft/AFK-Player-GC/issues/comments/128174751","html_url":"https://github.com/Civcraft/AFK-Player-GC/issues/10#issuecomment-128174751","issue_url":"https://api.github.com/repos/Civcraft/AFK-Player-GC/issues/10","id":128174751,"user":{"login":"erocs","id":700680,"avatar_url":"https://avatars.githubusercontent.com/u/700680?v=3","gravatar_id":"","url":"https://api.github.com/users/erocs","html_url":"https://github.com/erocs","followers_url":"https://api.github.com/users/erocs/followers","following_url":"https://api.github.com/users/erocs/following{/other_user}","gists_url":"https://api.github.com/users/erocs/gists{/gist_id}","starred_url":"https://api.github.com/users/erocs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erocs/subscriptions","organizations_url":"https://api.github.com/users/erocs/orgs","repos_url":"https://api.github.com/users/erocs/repos","events_url":"https://api.github.com/users/erocs/events{/privacy}","received_events_url":"https://api.github.com/users/erocs/received_events","type":"User","site_admin":false},"created_at":"2015-08-05T22:55:31Z","updated_at":"2015-08-05T22:55:31Z","body":"No, it has a separate ban list to better manage alt-bans."}}