{"action":"created","comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/30062277","id":30062277,"diff_hunk":"@@ -198,50 +193,27 @@ def _set_stimchannels(self, stim='<'):\n             chan_info['coil_type'] = FIFF.FIFFV_COIL_NONE\n             chan_info['loc'] = np.zeros(12)\n             chan_info['kind'] = FIFF.FIFFV_STIM_CH\n-            self.info['chs'].append(chan_info)\n-            self.info['ch_names'].append(ch_name)\n+            info['chs'].append(chan_info)\n+            info['ch_names'].append(ch_name)\n         if self.preload:\n             err = \"Can't change stim channel after preloading data\"\n             raise NotImplementedError(err)\n \n         self._kit_info['stim'] = stim\n \n-    def _read_segment(self, start=0, stop=None, sel=None, verbose=None,\n-                      projector=None):\n-        \"\"\"Read a chunk of raw data\n-\n-        Parameters\n-        ----------\n-        start : int, (optional)\n-            first sample to include (first is 0). If omitted, defaults to the\n-            first sample in data.\n-        stop : int, (optional)\n-            First sample to not include.\n-            If omitted, data is included to the end.\n-        sel : array, optional\n-            Indices of channels to select.\n-        projector : array\n-            SSP operator to apply to the data.\n-        verbose : bool, str, int, or None\n-            If not None, override default verbose level (see mne.verbose).\n-\n-        Returns\n-        -------\n-        data : array, [channels x samples]\n-           the data matrix (channels x samples).\n-        times : array, [samples]\n-            returns the time values corresponding to the samples.\n-        \"\"\"\n+    @verbose\n+    def _read_segment(self, start=0, stop=None, sel=None, data_buffer=None,\n+                      projector=None, verbose=None):\n+        \"\"\"Read a chunk of raw data\"\"\"\n         if sel is None:\n-            sel = list(range(self.info['nchan']))\n-        elif len(sel) == 1 and sel[0] == 0 and start == 0 and stop == 1:\n-            return (666, 666)","path":"mne/io/kit/kit.py","position":147,"original_position":147,"commit_id":"1e09614248be933d39a4ae064684b04c8d22a5aa","original_commit_id":"1e09614248be933d39a4ae064684b04c8d22a5aa","user":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?v=3","gravatar_id":"","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"body":"FYI @teonlamont I got rid of this weird exception","created_at":"2015-05-11T17:38:41Z","updated_at":"2015-05-11T17:38:41Z","html_url":"https://github.com/mne-tools/mne-python/pull/2080#discussion_r30062277","pull_request_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/2080","_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/30062277"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/2080#discussion_r30062277"},"pull_request":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/2080"}}},"pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/2080","id":35087750,"html_url":"https://github.com/mne-tools/mne-python/pull/2080","diff_url":"https://github.com/mne-tools/mne-python/pull/2080.diff","patch_url":"https://github.com/mne-tools/mne-python/pull/2080.patch","issue_url":"https://api.github.com/repos/mne-tools/mne-python/issues/2080","number":2080,"state":"open","locked":false,"title":"ENH: Preload data","user":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?v=3","gravatar_id":"","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"body":"Closes #2040.\r\n\r\nWe'll see if Travis is happy. Still some optimizations to do, but the architecture is there.","created_at":"2015-05-10T19:50:29Z","updated_at":"2015-05-11T17:38:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"02e825faf057ccd8c5a4f57d00d56325d8f0cae8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/2080/commits","review_comments_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/2080/comments","review_comment_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/issues/2080/comments","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/1e09614248be933d39a4ae064684b04c8d22a5aa","head":{"label":"Eric89GXL:preload-data","ref":"preload-data","sha":"1e09614248be933d39a4ae064684b04c8d22a5aa","user":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?v=3","gravatar_id":"","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"repo":{"id":5848067,"name":"mne-python","full_name":"Eric89GXL/mne-python","owner":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?v=3","gravatar_id":"","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Eric89GXL/mne-python","description":"MNE scripting with Python","fork":true,"url":"https://api.github.com/repos/Eric89GXL/mne-python","forks_url":"https://api.github.com/repos/Eric89GXL/mne-python/forks","keys_url":"https://api.github.com/repos/Eric89GXL/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Eric89GXL/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Eric89GXL/mne-python/teams","hooks_url":"https://api.github.com/repos/Eric89GXL/mne-python/hooks","issue_events_url":"https://api.github.com/repos/Eric89GXL/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/Eric89GXL/mne-python/events","assignees_url":"https://api.github.com/repos/Eric89GXL/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/Eric89GXL/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/Eric89GXL/mne-python/tags","blobs_url":"https://api.github.com/repos/Eric89GXL/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Eric89GXL/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Eric89GXL/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/Eric89GXL/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Eric89GXL/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/Eric89GXL/mne-python/languages","stargazers_url":"https://api.github.com/repos/Eric89GXL/mne-python/stargazers","contributors_url":"https://api.github.com/repos/Eric89GXL/mne-python/contributors","subscribers_url":"https://api.github.com/repos/Eric89GXL/mne-python/subscribers","subscription_url":"https://api.github.com/repos/Eric89GXL/mne-python/subscription","commits_url":"https://api.github.com/repos/Eric89GXL/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/Eric89GXL/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/Eric89GXL/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/Eric89GXL/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/Eric89GXL/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/Eric89GXL/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Eric89GXL/mne-python/merges","archive_url":"https://api.github.com/repos/Eric89GXL/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Eric89GXL/mne-python/downloads","issues_url":"https://api.github.com/repos/Eric89GXL/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/Eric89GXL/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/Eric89GXL/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/Eric89GXL/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Eric89GXL/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/Eric89GXL/mne-python/releases{/id}","created_at":"2012-09-17T22:08:11Z","updated_at":"2015-05-07T15:05:01Z","pushed_at":"2015-05-11T17:38:23Z","git_url":"git://github.com/Eric89GXL/mne-python.git","ssh_url":"git@github.com:Eric89GXL/mne-python.git","clone_url":"https://github.com/Eric89GXL/mne-python.git","svn_url":"https://github.com/Eric89GXL/mne-python","homepage":"http://martinos.org/mne/","size":81117,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mne-tools:master","ref":"master","sha":"f2ab0641f087c63beab715ff5fdaa9399c0807fe","user":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?v=3","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"repo":{"id":1301584,"name":"mne-python","full_name":"mne-tools/mne-python","owner":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?v=3","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mne-tools/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":false,"url":"https://api.github.com/repos/mne-tools/mne-python","forks_url":"https://api.github.com/repos/mne-tools/mne-python/forks","keys_url":"https://api.github.com/repos/mne-tools/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mne-tools/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mne-tools/mne-python/teams","hooks_url":"https://api.github.com/repos/mne-tools/mne-python/hooks","issue_events_url":"https://api.github.com/repos/mne-tools/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/mne-tools/mne-python/events","assignees_url":"https://api.github.com/repos/mne-tools/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/mne-tools/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/mne-tools/mne-python/tags","blobs_url":"https://api.github.com/repos/mne-tools/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mne-tools/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mne-tools/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/mne-tools/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/mne-tools/mne-python/languages","stargazers_url":"https://api.github.com/repos/mne-tools/mne-python/stargazers","contributors_url":"https://api.github.com/repos/mne-tools/mne-python/contributors","subscribers_url":"https://api.github.com/repos/mne-tools/mne-python/subscribers","subscription_url":"https://api.github.com/repos/mne-tools/mne-python/subscription","commits_url":"https://api.github.com/repos/mne-tools/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/mne-tools/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/mne-tools/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/mne-tools/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/mne-tools/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mne-tools/mne-python/merges","archive_url":"https://api.github.com/repos/mne-tools/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mne-tools/mne-python/downloads","issues_url":"https://api.github.com/repos/mne-tools/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/mne-tools/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/mne-tools/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/mne-tools/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mne-tools/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/mne-tools/mne-python/releases{/id}","created_at":"2011-01-28T03:31:13Z","updated_at":"2015-05-08T07:28:10Z","pushed_at":"2015-05-11T17:38:24Z","git_url":"git://github.com/mne-tools/mne-python.git","ssh_url":"git@github.com:mne-tools/mne-python.git","clone_url":"https://github.com/mne-tools/mne-python.git","svn_url":"https://github.com/mne-tools/mne-python","homepage":"http://martinos.org/mne/","size":168983,"stargazers_count":128,"watchers_count":128,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":114,"mirror_url":null,"open_issues_count":130,"forks":114,"open_issues":130,"watchers":128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/2080"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/2080"},"issue":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/2080"},"comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/2080/comments"},"review_comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/2080/comments"},"review_comment":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/2080/commits"},"statuses":{"href":"https://api.github.com/repos/mne-tools/mne-python/statuses/1e09614248be933d39a4ae064684b04c8d22a5aa"}}}}