{"action":"created","comment":{"url":"https://api.github.com/repos/biolab/orange3/pulls/comments/24824310","id":24824310,"diff_hunk":"@@ -99,16 +121,23 @@ def test_adjust_decimals(self):\n         a.val_from_str_add(\"5.1234\")\n         self.assertEqual(a.str_val(4.654321), \"4.6543\")\n \n+    def dont_pickle_anonymous_variables(self):","path":"Orange/tests/test_variable.py","position":null,"original_position":61,"commit_id":"d845ae72981649e770dcc245af08eb06af43c8a8","original_commit_id":"c15ec3747b7a86af32320582ef3ec0e1cf914af4","user":{"login":"janezd","id":2387315,"avatar_url":"https://avatars.githubusercontent.com/u/2387315?v=3","gravatar_id":"","url":"https://api.github.com/users/janezd","html_url":"https://github.com/janezd","followers_url":"https://api.github.com/users/janezd/followers","following_url":"https://api.github.com/users/janezd/following{/other_user}","gists_url":"https://api.github.com/users/janezd/gists{/gist_id}","starred_url":"https://api.github.com/users/janezd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janezd/subscriptions","organizations_url":"https://api.github.com/users/janezd/orgs","repos_url":"https://api.github.com/users/janezd/repos","events_url":"https://api.github.com/users/janezd/events{/privacy}","received_events_url":"https://api.github.com/users/janezd/received_events","type":"User","site_admin":false},"body":"Sorry, I overlooked it. Fixed.","created_at":"2015-02-17T15:43:25Z","updated_at":"2015-02-17T15:43:25Z","html_url":"https://github.com/biolab/orange3/pull/320#discussion_r24824310","pull_request_url":"https://api.github.com/repos/biolab/orange3/pulls/320","_links":{"self":{"href":"https://api.github.com/repos/biolab/orange3/pulls/comments/24824310"},"html":{"href":"https://github.com/biolab/orange3/pull/320#discussion_r24824310"},"pull_request":{"href":"https://api.github.com/repos/biolab/orange3/pulls/320"}}},"pull_request":{"url":"https://api.github.com/repos/biolab/orange3/pulls/320","id":29388970,"html_url":"https://github.com/biolab/orange3/pull/320","diff_url":"https://github.com/biolab/orange3/pull/320.diff","patch_url":"https://github.com/biolab/orange3/pull/320.patch","issue_url":"https://api.github.com/repos/biolab/orange3/issues/320","number":320,"state":"open","locked":false,"title":"Variable unpickler uses make; anonymous variables are no longer stored","user":{"login":"janezd","id":2387315,"avatar_url":"https://avatars.githubusercontent.com/u/2387315?v=3","gravatar_id":"","url":"https://api.github.com/users/janezd","html_url":"https://github.com/janezd","followers_url":"https://api.github.com/users/janezd/followers","following_url":"https://api.github.com/users/janezd/following{/other_user}","gists_url":"https://api.github.com/users/janezd/gists{/gist_id}","starred_url":"https://api.github.com/users/janezd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janezd/subscriptions","organizations_url":"https://api.github.com/users/janezd/orgs","repos_url":"https://api.github.com/users/janezd/repos","events_url":"https://api.github.com/users/janezd/events{/privacy}","received_events_url":"https://api.github.com/users/janezd/received_events","type":"User","site_admin":false},"body":"@astaric Almost there. The tests that fails is test_SimpleTree_classification_pickle, yet the problem is general. The test uses data with domain with variables that have no names (e.g. empty strings) and have values [0, 1]. Variable unpickler cannot distinguish between them and thus cannot unpickle them correctly. We can't solve this: this test will never pass.\r\n\r\nSolutions:\r\n- anonymous variables cannot be pickled (`Variable.__reduce__` raises an exception if `not self.name`),\r\n- anonymous variables are not allowed at all (`Variable.__init__` raises an exception if the name is empty).\r\n\r\nI vote for the former. Let us allows \"quick variables\", but they are temporary in nature, so they cannot be pickled.\r\n\r\nPerhaps we should go further: anonymous variables should not be stored in `all_vars` and `Variable.make` should raise en exception if the name is empty. Anonymous variables are \"unmakable\".","created_at":"2015-02-16T17:24:34Z","updated_at":"2015-02-17T15:43:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9964a0386937064ffddbb14a30e4b72605eacc98","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/biolab/orange3/pulls/320/commits","review_comments_url":"https://api.github.com/repos/biolab/orange3/pulls/320/comments","review_comment_url":"https://api.github.com/repos/biolab/orange3/pulls/comments/{number}","comments_url":"https://api.github.com/repos/biolab/orange3/issues/320/comments","statuses_url":"https://api.github.com/repos/biolab/orange3/statuses/d845ae72981649e770dcc245af08eb06af43c8a8","head":{"label":"janezd:variable-pickle","ref":"variable-pickle","sha":"d845ae72981649e770dcc245af08eb06af43c8a8","user":{"login":"janezd","id":2387315,"avatar_url":"https://avatars.githubusercontent.com/u/2387315?v=3","gravatar_id":"","url":"https://api.github.com/users/janezd","html_url":"https://github.com/janezd","followers_url":"https://api.github.com/users/janezd/followers","following_url":"https://api.github.com/users/janezd/following{/other_user}","gists_url":"https://api.github.com/users/janezd/gists{/gist_id}","starred_url":"https://api.github.com/users/janezd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janezd/subscriptions","organizations_url":"https://api.github.com/users/janezd/orgs","repos_url":"https://api.github.com/users/janezd/repos","events_url":"https://api.github.com/users/janezd/events{/privacy}","received_events_url":"https://api.github.com/users/janezd/received_events","type":"User","site_admin":false},"repo":{"id":22688172,"name":"orange3","full_name":"janezd/orange3","owner":{"login":"janezd","id":2387315,"avatar_url":"https://avatars.githubusercontent.com/u/2387315?v=3","gravatar_id":"","url":"https://api.github.com/users/janezd","html_url":"https://github.com/janezd","followers_url":"https://api.github.com/users/janezd/followers","following_url":"https://api.github.com/users/janezd/following{/other_user}","gists_url":"https://api.github.com/users/janezd/gists{/gist_id}","starred_url":"https://api.github.com/users/janezd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janezd/subscriptions","organizations_url":"https://api.github.com/users/janezd/orgs","repos_url":"https://api.github.com/users/janezd/repos","events_url":"https://api.github.com/users/janezd/events{/privacy}","received_events_url":"https://api.github.com/users/janezd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/janezd/orange3","description":"","fork":true,"url":"https://api.github.com/repos/janezd/orange3","forks_url":"https://api.github.com/repos/janezd/orange3/forks","keys_url":"https://api.github.com/repos/janezd/orange3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/janezd/orange3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/janezd/orange3/teams","hooks_url":"https://api.github.com/repos/janezd/orange3/hooks","issue_events_url":"https://api.github.com/repos/janezd/orange3/issues/events{/number}","events_url":"https://api.github.com/repos/janezd/orange3/events","assignees_url":"https://api.github.com/repos/janezd/orange3/assignees{/user}","branches_url":"https://api.github.com/repos/janezd/orange3/branches{/branch}","tags_url":"https://api.github.com/repos/janezd/orange3/tags","blobs_url":"https://api.github.com/repos/janezd/orange3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/janezd/orange3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/janezd/orange3/git/refs{/sha}","trees_url":"https://api.github.com/repos/janezd/orange3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/janezd/orange3/statuses/{sha}","languages_url":"https://api.github.com/repos/janezd/orange3/languages","stargazers_url":"https://api.github.com/repos/janezd/orange3/stargazers","contributors_url":"https://api.github.com/repos/janezd/orange3/contributors","subscribers_url":"https://api.github.com/repos/janezd/orange3/subscribers","subscription_url":"https://api.github.com/repos/janezd/orange3/subscription","commits_url":"https://api.github.com/repos/janezd/orange3/commits{/sha}","git_commits_url":"https://api.github.com/repos/janezd/orange3/git/commits{/sha}","comments_url":"https://api.github.com/repos/janezd/orange3/comments{/number}","issue_comment_url":"https://api.github.com/repos/janezd/orange3/issues/comments/{number}","contents_url":"https://api.github.com/repos/janezd/orange3/contents/{+path}","compare_url":"https://api.github.com/repos/janezd/orange3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/janezd/orange3/merges","archive_url":"https://api.github.com/repos/janezd/orange3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/janezd/orange3/downloads","issues_url":"https://api.github.com/repos/janezd/orange3/issues{/number}","pulls_url":"https://api.github.com/repos/janezd/orange3/pulls{/number}","milestones_url":"https://api.github.com/repos/janezd/orange3/milestones{/number}","notifications_url":"https://api.github.com/repos/janezd/orange3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/janezd/orange3/labels{/name}","releases_url":"https://api.github.com/repos/janezd/orange3/releases{/id}","created_at":"2014-08-06T15:40:07Z","updated_at":"2014-09-05T08:19:49Z","pushed_at":"2015-02-17T15:43:02Z","git_url":"git://github.com/janezd/orange3.git","ssh_url":"git@github.com:janezd/orange3.git","clone_url":"https://github.com/janezd/orange3.git","svn_url":"https://github.com/janezd/orange3","homepage":null,"size":7657,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"biolab:master","ref":"master","sha":"145e988208f263190ef1443cca896c539c906fc9","user":{"login":"biolab","id":555189,"avatar_url":"https://avatars.githubusercontent.com/u/555189?v=3","gravatar_id":"","url":"https://api.github.com/users/biolab","html_url":"https://github.com/biolab","followers_url":"https://api.github.com/users/biolab/followers","following_url":"https://api.github.com/users/biolab/following{/other_user}","gists_url":"https://api.github.com/users/biolab/gists{/gist_id}","starred_url":"https://api.github.com/users/biolab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biolab/subscriptions","organizations_url":"https://api.github.com/users/biolab/orgs","repos_url":"https://api.github.com/users/biolab/repos","events_url":"https://api.github.com/users/biolab/events{/privacy}","received_events_url":"https://api.github.com/users/biolab/received_events","type":"Organization","site_admin":false},"repo":{"id":8357227,"name":"orange3","full_name":"biolab/orange3","owner":{"login":"biolab","id":555189,"avatar_url":"https://avatars.githubusercontent.com/u/555189?v=3","gravatar_id":"","url":"https://api.github.com/users/biolab","html_url":"https://github.com/biolab","followers_url":"https://api.github.com/users/biolab/followers","following_url":"https://api.github.com/users/biolab/following{/other_user}","gists_url":"https://api.github.com/users/biolab/gists{/gist_id}","starred_url":"https://api.github.com/users/biolab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biolab/subscriptions","organizations_url":"https://api.github.com/users/biolab/orgs","repos_url":"https://api.github.com/users/biolab/repos","events_url":"https://api.github.com/users/biolab/events{/privacy}","received_events_url":"https://api.github.com/users/biolab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/biolab/orange3","description":"","fork":false,"url":"https://api.github.com/repos/biolab/orange3","forks_url":"https://api.github.com/repos/biolab/orange3/forks","keys_url":"https://api.github.com/repos/biolab/orange3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/biolab/orange3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/biolab/orange3/teams","hooks_url":"https://api.github.com/repos/biolab/orange3/hooks","issue_events_url":"https://api.github.com/repos/biolab/orange3/issues/events{/number}","events_url":"https://api.github.com/repos/biolab/orange3/events","assignees_url":"https://api.github.com/repos/biolab/orange3/assignees{/user}","branches_url":"https://api.github.com/repos/biolab/orange3/branches{/branch}","tags_url":"https://api.github.com/repos/biolab/orange3/tags","blobs_url":"https://api.github.com/repos/biolab/orange3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/biolab/orange3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/biolab/orange3/git/refs{/sha}","trees_url":"https://api.github.com/repos/biolab/orange3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/biolab/orange3/statuses/{sha}","languages_url":"https://api.github.com/repos/biolab/orange3/languages","stargazers_url":"https://api.github.com/repos/biolab/orange3/stargazers","contributors_url":"https://api.github.com/repos/biolab/orange3/contributors","subscribers_url":"https://api.github.com/repos/biolab/orange3/subscribers","subscription_url":"https://api.github.com/repos/biolab/orange3/subscription","commits_url":"https://api.github.com/repos/biolab/orange3/commits{/sha}","git_commits_url":"https://api.github.com/repos/biolab/orange3/git/commits{/sha}","comments_url":"https://api.github.com/repos/biolab/orange3/comments{/number}","issue_comment_url":"https://api.github.com/repos/biolab/orange3/issues/comments/{number}","contents_url":"https://api.github.com/repos/biolab/orange3/contents/{+path}","compare_url":"https://api.github.com/repos/biolab/orange3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/biolab/orange3/merges","archive_url":"https://api.github.com/repos/biolab/orange3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/biolab/orange3/downloads","issues_url":"https://api.github.com/repos/biolab/orange3/issues{/number}","pulls_url":"https://api.github.com/repos/biolab/orange3/pulls{/number}","milestones_url":"https://api.github.com/repos/biolab/orange3/milestones{/number}","notifications_url":"https://api.github.com/repos/biolab/orange3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/biolab/orange3/labels{/name}","releases_url":"https://api.github.com/repos/biolab/orange3/releases{/id}","created_at":"2013-02-22T12:52:56Z","updated_at":"2015-02-17T09:00:26Z","pushed_at":"2015-02-17T09:00:26Z","git_url":"git://github.com/biolab/orange3.git","ssh_url":"git@github.com:biolab/orange3.git","clone_url":"https://github.com/biolab/orange3.git","svn_url":"https://github.com/biolab/orange3","homepage":null,"size":12557,"stargazers_count":76,"watchers_count":76,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":22,"forks":45,"open_issues":22,"watchers":76,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/biolab/orange3/pulls/320"},"html":{"href":"https://github.com/biolab/orange3/pull/320"},"issue":{"href":"https://api.github.com/repos/biolab/orange3/issues/320"},"comments":{"href":"https://api.github.com/repos/biolab/orange3/issues/320/comments"},"review_comments":{"href":"https://api.github.com/repos/biolab/orange3/pulls/320/comments"},"review_comment":{"href":"https://api.github.com/repos/biolab/orange3/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/biolab/orange3/pulls/320/commits"},"statuses":{"href":"https://api.github.com/repos/biolab/orange3/statuses/d845ae72981649e770dcc245af08eb06af43c8a8"}}}}