{"action":"created","issue":{"url":"https://api.github.com/repos/wikimedia/restbase/issues/298","labels_url":"https://api.github.com/repos/wikimedia/restbase/issues/298/labels{/name}","comments_url":"https://api.github.com/repos/wikimedia/restbase/issues/298/comments","events_url":"https://api.github.com/repos/wikimedia/restbase/issues/298/events","html_url":"https://github.com/wikimedia/restbase/pull/298","id":99177592,"number":298,"title":"Enforce code style","user":{"login":"Pchelolo","id":814754,"avatar_url":"https://avatars.githubusercontent.com/u/814754?v=3","gravatar_id":"","url":"https://api.github.com/users/Pchelolo","html_url":"https://github.com/Pchelolo","followers_url":"https://api.github.com/users/Pchelolo/followers","following_url":"https://api.github.com/users/Pchelolo/following{/other_user}","gists_url":"https://api.github.com/users/Pchelolo/gists{/gist_id}","starred_url":"https://api.github.com/users/Pchelolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pchelolo/subscriptions","organizations_url":"https://api.github.com/users/Pchelolo/orgs","repos_url":"https://api.github.com/users/Pchelolo/repos","events_url":"https://api.github.com/users/Pchelolo/events{/privacy}","received_events_url":"https://api.github.com/users/Pchelolo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2015-08-05T10:51:10Z","updated_at":"2015-08-05T16:47:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/wikimedia/restbase/pulls/298","html_url":"https://github.com/wikimedia/restbase/pull/298","diff_url":"https://github.com/wikimedia/restbase/pull/298.diff","patch_url":"https://github.com/wikimedia/restbase/pull/298.patch"},"body":"Most of the stuff fixed automatically, then I've looked over the changes and all seems to be fine.\r\nThe jscs config is the same as in parsoid, but we don't verify that comments are starting with an upper-case letter, because we have several places with commented-out code that could be useful for debugging.\r\n\r\nBug: https://phabricator.wikimedia.org/T107950"},"comment":{"url":"https://api.github.com/repos/wikimedia/restbase/issues/comments/128067429","html_url":"https://github.com/wikimedia/restbase/pull/298#issuecomment-128067429","issue_url":"https://api.github.com/repos/wikimedia/restbase/issues/298","id":128067429,"user":{"login":"eevans","id":64348,"avatar_url":"https://avatars.githubusercontent.com/u/64348?v=3","gravatar_id":"","url":"https://api.github.com/users/eevans","html_url":"https://github.com/eevans","followers_url":"https://api.github.com/users/eevans/followers","following_url":"https://api.github.com/users/eevans/following{/other_user}","gists_url":"https://api.github.com/users/eevans/gists{/gist_id}","starred_url":"https://api.github.com/users/eevans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eevans/subscriptions","organizations_url":"https://api.github.com/users/eevans/orgs","repos_url":"https://api.github.com/users/eevans/repos","events_url":"https://api.github.com/users/eevans/events{/privacy}","received_events_url":"https://api.github.com/users/eevans/received_events","type":"User","site_admin":false},"created_at":"2015-08-05T16:47:01Z","updated_at":"2015-08-05T16:47:01Z","body":"> not sure what's the reason for comment capitalisation. We could switch off that check.\r\n\r\nPersonally, I think you *should* use capitalization (and punctuation) when formatting comments (for the same reasons that you would in documentation, correspondence, etc).  And I say this with the full knowledge that if we audited my changesets, it'd likely paint me a hypocrite. :)\r\n\r\nThat said, I can't see myself pushing back on a change during code-review because of this, so I agree that the code checker should ignore it.\r\n\r\nBut I'd leave in place the capitalization changes that are already in this PR, because they make the code better."}}