{"action":"created","issue":{"url":"https://api.github.com/repos/gentoo/gentoo/issues/139","labels_url":"https://api.github.com/repos/gentoo/gentoo/issues/139/labels{/name}","comments_url":"https://api.github.com/repos/gentoo/gentoo/issues/139/comments","events_url":"https://api.github.com/repos/gentoo/gentoo/issues/139/events","html_url":"https://github.com/gentoo/gentoo/pull/139","id":108706852,"number":139,"title":"sys-apps/irqbalance: misc. improvements to service unit","user":{"login":"marcecj","id":978454,"avatar_url":"https://avatars.githubusercontent.com/u/978454?v=3","gravatar_id":"","url":"https://api.github.com/users/marcecj","html_url":"https://github.com/marcecj","followers_url":"https://api.github.com/users/marcecj/followers","following_url":"https://api.github.com/users/marcecj/following{/other_user}","gists_url":"https://api.github.com/users/marcecj/gists{/gist_id}","starred_url":"https://api.github.com/users/marcecj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcecj/subscriptions","organizations_url":"https://api.github.com/users/marcecj/orgs","repos_url":"https://api.github.com/users/marcecj/repos","events_url":"https://api.github.com/users/marcecj/events{/privacy}","received_events_url":"https://api.github.com/users/marcecj/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/gentoo/gentoo/labels/assigned","name":"assigned","color":"5319e7"},{"url":"https://api.github.com/repos/gentoo/gentoo/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-09-28T17:31:17Z","updated_at":"2015-10-08T17:36:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gentoo/gentoo/pulls/139","html_url":"https://github.com/gentoo/gentoo/pull/139","diff_url":"https://github.com/gentoo/gentoo/pull/139.diff","patch_url":"https://github.com/gentoo/gentoo/pull/139.patch"},"body":"This series of commits improve the sys-apps/irqbalance service unit in the following ways:\r\n\r\n- Use `--foreground` instead of `--debug` for daemonization.  This option was added in https://github.com/Irqbalance/irqbalance/commit/827c08f289065df5db980a8c0fcd4bc31638172f waaay back in late 2011, and all versions in Gentoo that use the systemd service file support it.\r\n- Use the file /etc/irqbalance.env as an `EnvironmentFile` if it exists, and use its `$IRQBALANCE_ARGS` variable in `ExecStart`.  This works whether the file exists or not.\r\n- Create a revbump to sys-apps/irqbalance-1.0.9 that installs the upstream file `misc/irqbalance.env` into `/etc`.\r\n\r\nNote that I haven't tested the revbump outside of running `ebuild install` and checking the contents of the `image/` directory. I did test the service unit changes with version 1.0.6, though (by applying them to my `irqbalance.service.d/` override).\r\n\r\nFeel free to mention anything I might have overlooked, since I couldn't find any documentation on creating pull-requests (https://wiki.gentoo.org/wiki/Gentoo_git_workflow seems to be exclusively targeted at Gentoo developers).  I do have two concrete questions, though:\r\n\r\n- Should I have used `repoman commit`?  I had already made my commits before thinking of it. I did run `repoman full .` before every commit, though.\r\n- Should I sign the commits with my GPG key, or is that reserved for Gentoo developers?  The Gentoo git workflow mentions \"user signatures\" at one point, but that's it."},"comment":{"url":"https://api.github.com/repos/gentoo/gentoo/issues/comments/146632949","html_url":"https://github.com/gentoo/gentoo/pull/139#issuecomment-146632949","issue_url":"https://api.github.com/repos/gentoo/gentoo/issues/139","id":146632949,"user":{"login":"marcecj","id":978454,"avatar_url":"https://avatars.githubusercontent.com/u/978454?v=3","gravatar_id":"","url":"https://api.github.com/users/marcecj","html_url":"https://github.com/marcecj","followers_url":"https://api.github.com/users/marcecj/followers","following_url":"https://api.github.com/users/marcecj/following{/other_user}","gists_url":"https://api.github.com/users/marcecj/gists{/gist_id}","starred_url":"https://api.github.com/users/marcecj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcecj/subscriptions","organizations_url":"https://api.github.com/users/marcecj/orgs","repos_url":"https://api.github.com/users/marcecj/repos","events_url":"https://api.github.com/users/marcecj/events{/privacy}","received_events_url":"https://api.github.com/users/marcecj/received_events","type":"User","site_admin":false},"created_at":"2015-10-08T17:36:40Z","updated_at":"2015-10-08T17:36:40Z","body":"Alright, I finally updated the pull request.\r\n\r\nFrom @mgorny's comments I gathered that the only acceptable way forward was to ditch the latter two commits, so I did exactly that.  I also took the opportunity to sign the commit with my GPG key."}}