{"action":"created","comment":{"url":"https://api.github.com/repos/hawkular/hawkular-alerts/pulls/comments/46184840","id":46184840,"diff_hunk":"@@ -169,15 +187,84 @@\n \n   <profiles>\n \n+    <!-- Profiles to compile with specific clustering libraries -->\n     <profile>\n-      <id>default</id>\n+      <id>clustering-wildfly</id>\n       <activation>\n-        <activeByDefault>true</activeByDefault>\n+        <property>\n+          <name>!env</name>\n+        </property>\n       </activation>\n+      <dependencies>\n+        <dependency>\n+          <groupId>org.infinispan</groupId>\n+          <artifactId>infinispan-core</artifactId>\n+          <scope>provided</scope>\n+          <version>${version.org.infinispan.wildfly}</version>\n+        </dependency>\n+      </dependencies>\n       <build>\n         <plugins>\n           <plugin>\n             <groupId>org.apache.maven.plugins</groupId>\n+            <artifactId>maven-compiler-plugin</artifactId>\n+            <executions>\n+              <execution>\n+                <id>default-compile</id>\n+                <phase>compile</phase>\n+                <goals>\n+                  <goal>compile</goal>\n+                </goals>\n+                <configuration>\n+                  <excludes>\n+                    <exclude>org/hawkular/alerts/engine/impl/PartitionManagerEapImpl.java</exclude>","path":"hawkular-alerts-engine/pom.xml","position":72,"original_position":72,"commit_id":"a85a4c9bc5e3b0baa3746b68f98493081d9938b2","original_commit_id":"a85a4c9bc5e3b0baa3746b68f98493081d9938b2","user":{"login":"jshaughn","id":2104052,"avatar_url":"https://avatars.githubusercontent.com/u/2104052?v=3","gravatar_id":"","url":"https://api.github.com/users/jshaughn","html_url":"https://github.com/jshaughn","followers_url":"https://api.github.com/users/jshaughn/followers","following_url":"https://api.github.com/users/jshaughn/following{/other_user}","gists_url":"https://api.github.com/users/jshaughn/gists{/gist_id}","starred_url":"https://api.github.com/users/jshaughn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jshaughn/subscriptions","organizations_url":"https://api.github.com/users/jshaughn/orgs","repos_url":"https://api.github.com/users/jshaughn/repos","events_url":"https://api.github.com/users/jshaughn/events{/privacy}","received_events_url":"https://api.github.com/users/jshaughn/received_events","type":"User","site_admin":false},"body":"Is this going to be true for all EAP versions or maybe this class should be PartitionManagerEap6Impl.java ?","created_at":"2015-11-30T18:50:39Z","updated_at":"2015-11-30T18:50:39Z","html_url":"https://github.com/hawkular/hawkular-alerts/pull/126#discussion_r46184840","pull_request_url":"https://api.github.com/repos/hawkular/hawkular-alerts/pulls/126","_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-alerts/pulls/comments/46184840"},"html":{"href":"https://github.com/hawkular/hawkular-alerts/pull/126#discussion_r46184840"},"pull_request":{"href":"https://api.github.com/repos/hawkular/hawkular-alerts/pulls/126"}}},"pull_request":{"url":"https://api.github.com/repos/hawkular/hawkular-alerts/pulls/126","id":52060266,"html_url":"https://github.com/hawkular/hawkular-alerts/pull/126","diff_url":"https://github.com/hawkular/hawkular-alerts/pull/126.diff","patch_url":"https://github.com/hawkular/hawkular-alerts/pull/126.patch","issue_url":"https://api.github.com/repos/hawkular/hawkular-alerts/issues/126","number":126,"state":"open","locked":false,"title":"Clustering","user":{"login":"lucasponce","id":1662329,"avatar_url":"https://avatars.githubusercontent.com/u/1662329?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasponce","html_url":"https://github.com/lucasponce","followers_url":"https://api.github.com/users/lucasponce/followers","following_url":"https://api.github.com/users/lucasponce/following{/other_user}","gists_url":"https://api.github.com/users/lucasponce/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasponce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasponce/subscriptions","organizations_url":"https://api.github.com/users/lucasponce/orgs","repos_url":"https://api.github.com/users/lucasponce/repos","events_url":"https://api.github.com/users/lucasponce/events{/privacy}","received_events_url":"https://api.github.com/users/lucasponce/received_events","type":"User","site_admin":false},"body":"WIP, not to merge but start review.\r\nIt implements main scalability design discussed on F2F.\r\nIt is not finished but main design is mostly implemented.\r\n\r\nMain goal is to partition triggers on AlertsEngine in a explicit way having fine granularity but without adding complexity. \r\nThis design minimize the data that is shared and the calls between nodes trying to offer a lightweight state transfer.\r\n\r\nI hope to finish the work soon, but comments are welcome @jshaughn .\r\n\r\nThanks","created_at":"2015-11-29T11:51:59Z","updated_at":"2015-11-30T18:50:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c2fdb15368bc24f116c6cdda493857036824558a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hawkular/hawkular-alerts/pulls/126/commits","review_comments_url":"https://api.github.com/repos/hawkular/hawkular-alerts/pulls/126/comments","review_comment_url":"https://api.github.com/repos/hawkular/hawkular-alerts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hawkular/hawkular-alerts/issues/126/comments","statuses_url":"https://api.github.com/repos/hawkular/hawkular-alerts/statuses/a85a4c9bc5e3b0baa3746b68f98493081d9938b2","head":{"label":"lucasponce:Clustering","ref":"Clustering","sha":"a85a4c9bc5e3b0baa3746b68f98493081d9938b2","user":{"login":"lucasponce","id":1662329,"avatar_url":"https://avatars.githubusercontent.com/u/1662329?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasponce","html_url":"https://github.com/lucasponce","followers_url":"https://api.github.com/users/lucasponce/followers","following_url":"https://api.github.com/users/lucasponce/following{/other_user}","gists_url":"https://api.github.com/users/lucasponce/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasponce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasponce/subscriptions","organizations_url":"https://api.github.com/users/lucasponce/orgs","repos_url":"https://api.github.com/users/lucasponce/repos","events_url":"https://api.github.com/users/lucasponce/events{/privacy}","received_events_url":"https://api.github.com/users/lucasponce/received_events","type":"User","site_admin":false},"repo":{"id":29670224,"name":"hawkular-alerts","full_name":"lucasponce/hawkular-alerts","owner":{"login":"lucasponce","id":1662329,"avatar_url":"https://avatars.githubusercontent.com/u/1662329?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasponce","html_url":"https://github.com/lucasponce","followers_url":"https://api.github.com/users/lucasponce/followers","following_url":"https://api.github.com/users/lucasponce/following{/other_user}","gists_url":"https://api.github.com/users/lucasponce/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasponce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasponce/subscriptions","organizations_url":"https://api.github.com/users/lucasponce/orgs","repos_url":"https://api.github.com/users/lucasponce/repos","events_url":"https://api.github.com/users/lucasponce/events{/privacy}","received_events_url":"https://api.github.com/users/lucasponce/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lucasponce/hawkular-alerts","description":"Alerting subsystem for Hawkular","fork":true,"url":"https://api.github.com/repos/lucasponce/hawkular-alerts","forks_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/forks","keys_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/teams","hooks_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/hooks","issue_events_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/issues/events{/number}","events_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/events","assignees_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/assignees{/user}","branches_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/branches{/branch}","tags_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/tags","blobs_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/git/refs{/sha}","trees_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/statuses/{sha}","languages_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/languages","stargazers_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/stargazers","contributors_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/contributors","subscribers_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/subscribers","subscription_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/subscription","commits_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/commits{/sha}","git_commits_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/git/commits{/sha}","comments_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/comments{/number}","issue_comment_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/issues/comments{/number}","contents_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/contents/{+path}","compare_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/merges","archive_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/downloads","issues_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/issues{/number}","pulls_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/pulls{/number}","milestones_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/milestones{/number}","notifications_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/labels{/name}","releases_url":"https://api.github.com/repos/lucasponce/hawkular-alerts/releases{/id}","created_at":"2015-01-22T09:03:07Z","updated_at":"2015-05-08T10:16:36Z","pushed_at":"2015-11-30T17:28:45Z","git_url":"git://github.com/lucasponce/hawkular-alerts.git","ssh_url":"git@github.com:lucasponce/hawkular-alerts.git","clone_url":"https://github.com/lucasponce/hawkular-alerts.git","svn_url":"https://github.com/lucasponce/hawkular-alerts","homepage":null,"size":2425,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hawkular:master","ref":"master","sha":"1c9319ef8d0e45032ed662f1cdc033c9c5cba5ef","user":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"repo":{"id":29608496,"name":"hawkular-alerts","full_name":"hawkular/hawkular-alerts","owner":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hawkular/hawkular-alerts","description":"Alerting subsystem for Hawkular","fork":false,"url":"https://api.github.com/repos/hawkular/hawkular-alerts","forks_url":"https://api.github.com/repos/hawkular/hawkular-alerts/forks","keys_url":"https://api.github.com/repos/hawkular/hawkular-alerts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hawkular/hawkular-alerts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hawkular/hawkular-alerts/teams","hooks_url":"https://api.github.com/repos/hawkular/hawkular-alerts/hooks","issue_events_url":"https://api.github.com/repos/hawkular/hawkular-alerts/issues/events{/number}","events_url":"https://api.github.com/repos/hawkular/hawkular-alerts/events","assignees_url":"https://api.github.com/repos/hawkular/hawkular-alerts/assignees{/user}","branches_url":"https://api.github.com/repos/hawkular/hawkular-alerts/branches{/branch}","tags_url":"https://api.github.com/repos/hawkular/hawkular-alerts/tags","blobs_url":"https://api.github.com/repos/hawkular/hawkular-alerts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hawkular/hawkular-alerts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hawkular/hawkular-alerts/git/refs{/sha}","trees_url":"https://api.github.com/repos/hawkular/hawkular-alerts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hawkular/hawkular-alerts/statuses/{sha}","languages_url":"https://api.github.com/repos/hawkular/hawkular-alerts/languages","stargazers_url":"https://api.github.com/repos/hawkular/hawkular-alerts/stargazers","contributors_url":"https://api.github.com/repos/hawkular/hawkular-alerts/contributors","subscribers_url":"https://api.github.com/repos/hawkular/hawkular-alerts/subscribers","subscription_url":"https://api.github.com/repos/hawkular/hawkular-alerts/subscription","commits_url":"https://api.github.com/repos/hawkular/hawkular-alerts/commits{/sha}","git_commits_url":"https://api.github.com/repos/hawkular/hawkular-alerts/git/commits{/sha}","comments_url":"https://api.github.com/repos/hawkular/hawkular-alerts/comments{/number}","issue_comment_url":"https://api.github.com/repos/hawkular/hawkular-alerts/issues/comments{/number}","contents_url":"https://api.github.com/repos/hawkular/hawkular-alerts/contents/{+path}","compare_url":"https://api.github.com/repos/hawkular/hawkular-alerts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hawkular/hawkular-alerts/merges","archive_url":"https://api.github.com/repos/hawkular/hawkular-alerts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hawkular/hawkular-alerts/downloads","issues_url":"https://api.github.com/repos/hawkular/hawkular-alerts/issues{/number}","pulls_url":"https://api.github.com/repos/hawkular/hawkular-alerts/pulls{/number}","milestones_url":"https://api.github.com/repos/hawkular/hawkular-alerts/milestones{/number}","notifications_url":"https://api.github.com/repos/hawkular/hawkular-alerts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hawkular/hawkular-alerts/labels{/name}","releases_url":"https://api.github.com/repos/hawkular/hawkular-alerts/releases{/id}","created_at":"2015-01-21T19:59:08Z","updated_at":"2015-11-04T16:59:10Z","pushed_at":"2015-11-30T17:28:45Z","git_url":"git://github.com/hawkular/hawkular-alerts.git","ssh_url":"git@github.com:hawkular/hawkular-alerts.git","clone_url":"https://github.com/hawkular/hawkular-alerts.git","svn_url":"https://github.com/hawkular/hawkular-alerts","homepage":null,"size":2426,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":2,"forks":11,"open_issues":2,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-alerts/pulls/126"},"html":{"href":"https://github.com/hawkular/hawkular-alerts/pull/126"},"issue":{"href":"https://api.github.com/repos/hawkular/hawkular-alerts/issues/126"},"comments":{"href":"https://api.github.com/repos/hawkular/hawkular-alerts/issues/126/comments"},"review_comments":{"href":"https://api.github.com/repos/hawkular/hawkular-alerts/pulls/126/comments"},"review_comment":{"href":"https://api.github.com/repos/hawkular/hawkular-alerts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hawkular/hawkular-alerts/pulls/126/commits"},"statuses":{"href":"https://api.github.com/repos/hawkular/hawkular-alerts/statuses/a85a4c9bc5e3b0baa3746b68f98493081d9938b2"}}}}