{"action":"created","issue":{"url":"https://api.github.com/repos/coreos/etcd/issues/3137","labels_url":"https://api.github.com/repos/coreos/etcd/issues/3137/labels{/name}","comments_url":"https://api.github.com/repos/coreos/etcd/issues/3137/comments","events_url":"https://api.github.com/repos/coreos/etcd/issues/3137/events","html_url":"https://github.com/coreos/etcd/pull/3137","id":95246497,"number":3137,"title":"Move discovery client into client package","user":{"login":"yichengq","id":2976232,"avatar_url":"https://avatars.githubusercontent.com/u/2976232?v=3","gravatar_id":"","url":"https://api.github.com/users/yichengq","html_url":"https://github.com/yichengq","followers_url":"https://api.github.com/users/yichengq/followers","following_url":"https://api.github.com/users/yichengq/following{/other_user}","gists_url":"https://api.github.com/users/yichengq/gists{/gist_id}","starred_url":"https://api.github.com/users/yichengq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yichengq/subscriptions","organizations_url":"https://api.github.com/users/yichengq/orgs","repos_url":"https://api.github.com/users/yichengq/repos","events_url":"https://api.github.com/users/yichengq/events{/privacy}","received_events_url":"https://api.github.com/users/yichengq/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-07-15T17:23:51Z","updated_at":"2015-07-15T22:07:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/coreos/etcd/pulls/3137","html_url":"https://github.com/coreos/etcd/pull/3137","diff_url":"https://github.com/coreos/etcd/pull/3137.diff","patch_url":"https://github.com/coreos/etcd/pull/3137.patch"},"body":"There exists a client in the etcd/discovery pkg that wraps a\r\netcd/client.Client and adds logic specifically for interacting with an\r\netcd discovery service. Move it into client package because it is a\r\ngeneral client logic.\r\n\r\n@barakmich I removed plog in the client logic because:\r\n1. capnslog intercepts standard log output. When client package is used\r\nin other projects, it could be rather unfriendly.\r\n2. client package should use as less dependency as possible.\r\n\r\nIt introduces dependency `github.com/jonboulle/clockwork` into client package. The package exists mainly for better testing. @bcwaldon Any opinion?\r\n\r\nfixes #2256 \r\n\r\n/cc @bcwaldon "},"comment":{"url":"https://api.github.com/repos/coreos/etcd/issues/comments/121764113","html_url":"https://github.com/coreos/etcd/pull/3137#issuecomment-121764113","issue_url":"https://api.github.com/repos/coreos/etcd/issues/3137","id":121764113,"user":{"login":"xiang90","id":4479947,"avatar_url":"https://avatars.githubusercontent.com/u/4479947?v=3","gravatar_id":"","url":"https://api.github.com/users/xiang90","html_url":"https://github.com/xiang90","followers_url":"https://api.github.com/users/xiang90/followers","following_url":"https://api.github.com/users/xiang90/following{/other_user}","gists_url":"https://api.github.com/users/xiang90/gists{/gist_id}","starred_url":"https://api.github.com/users/xiang90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiang90/subscriptions","organizations_url":"https://api.github.com/users/xiang90/orgs","repos_url":"https://api.github.com/users/xiang90/repos","events_url":"https://api.github.com/users/xiang90/events{/privacy}","received_events_url":"https://api.github.com/users/xiang90/received_events","type":"User","site_admin":false},"created_at":"2015-07-15T22:07:50Z","updated_at":"2015-07-15T22:07:50Z","body":"@yichengq I strongly suggest that we need to keep the logging logic. We need to create logger interface if it is necessary."}}