{"action":"created","comment":{"url":"https://api.github.com/repos/Financial-Times/origami-build-tools/pulls/comments/33042509","id":33042509,"diff_hunk":"@@ -96,6 +96,8 @@ if (tasks.isValid(argument)) {\n \t\t\t\ttaskResult\n \t\t\t\t\t.on('error', reportTaskError)\n \t\t\t\t\t.on('end', reportFinished);\n+\t\t\t\t// Make sure it reaches 'end'\n+\t\t\t\ttaskResult.resume();","path":"lib/origami-build-tools-cli.js","position":5,"original_position":5,"commit_id":"53e08d269a2918ffba1aa433afbf33ce1f7907ff","original_commit_id":"53e08d269a2918ffba1aa433afbf33ce1f7907ff","user":{"login":"AlbertoElias","id":913117,"avatar_url":"https://avatars.githubusercontent.com/u/913117?v=3","gravatar_id":"","url":"https://api.github.com/users/AlbertoElias","html_url":"https://github.com/AlbertoElias","followers_url":"https://api.github.com/users/AlbertoElias/followers","following_url":"https://api.github.com/users/AlbertoElias/following{/other_user}","gists_url":"https://api.github.com/users/AlbertoElias/gists{/gist_id}","starred_url":"https://api.github.com/users/AlbertoElias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlbertoElias/subscriptions","organizations_url":"https://api.github.com/users/AlbertoElias/orgs","repos_url":"https://api.github.com/users/AlbertoElias/repos","events_url":"https://api.github.com/users/AlbertoElias/events{/privacy}","received_events_url":"https://api.github.com/users/AlbertoElias/received_events","type":"User","site_admin":false},"body":"The only one we don't understand is version, and we don't need to do anything, and if we don't understand the returned value we shouldn't do anything, right? I also think all tasks should return a promise or a stream and I would rather make version return a promise (though it's probably an overkill)","created_at":"2015-06-23T13:52:38Z","updated_at":"2015-06-23T13:52:38Z","html_url":"https://github.com/Financial-Times/origami-build-tools/pull/276#discussion_r33042509","pull_request_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/pulls/276","_links":{"self":{"href":"https://api.github.com/repos/Financial-Times/origami-build-tools/pulls/comments/33042509"},"html":{"href":"https://github.com/Financial-Times/origami-build-tools/pull/276#discussion_r33042509"},"pull_request":{"href":"https://api.github.com/repos/Financial-Times/origami-build-tools/pulls/276"}}},"pull_request":{"url":"https://api.github.com/repos/Financial-Times/origami-build-tools/pulls/276","id":38333521,"html_url":"https://github.com/Financial-Times/origami-build-tools/pull/276","diff_url":"https://github.com/Financial-Times/origami-build-tools/pull/276.diff","patch_url":"https://github.com/Financial-Times/origami-build-tools/pull/276.patch","issue_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/issues/276","number":276,"state":"open","locked":false,"title":"Show message after stream tasks and cleans up code","user":{"login":"AlbertoElias","id":913117,"avatar_url":"https://avatars.githubusercontent.com/u/913117?v=3","gravatar_id":"","url":"https://api.github.com/users/AlbertoElias","html_url":"https://github.com/AlbertoElias","followers_url":"https://api.github.com/users/AlbertoElias/followers","following_url":"https://api.github.com/users/AlbertoElias/following{/other_user}","gists_url":"https://api.github.com/users/AlbertoElias/gists{/gist_id}","starred_url":"https://api.github.com/users/AlbertoElias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlbertoElias/subscriptions","organizations_url":"https://api.github.com/users/AlbertoElias/orgs","repos_url":"https://api.github.com/users/AlbertoElias/repos","events_url":"https://api.github.com/users/AlbertoElias/events{/privacy}","received_events_url":"https://api.github.com/users/AlbertoElias/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-06-23T13:01:41Z","updated_at":"2015-06-23T13:52:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ddbf29fe5572085fcd37cb51c457876df5a54978","assignee":{"login":"samgiles","id":840334,"avatar_url":"https://avatars.githubusercontent.com/u/840334?v=3","gravatar_id":"","url":"https://api.github.com/users/samgiles","html_url":"https://github.com/samgiles","followers_url":"https://api.github.com/users/samgiles/followers","following_url":"https://api.github.com/users/samgiles/following{/other_user}","gists_url":"https://api.github.com/users/samgiles/gists{/gist_id}","starred_url":"https://api.github.com/users/samgiles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samgiles/subscriptions","organizations_url":"https://api.github.com/users/samgiles/orgs","repos_url":"https://api.github.com/users/samgiles/repos","events_url":"https://api.github.com/users/samgiles/events{/privacy}","received_events_url":"https://api.github.com/users/samgiles/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/pulls/276/commits","review_comments_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/pulls/276/comments","review_comment_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/issues/276/comments","statuses_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/statuses/53e08d269a2918ffba1aa433afbf33ce1f7907ff","head":{"label":"Financial-Times:cli-msg","ref":"cli-msg","sha":"53e08d269a2918ffba1aa433afbf33ce1f7907ff","user":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"repo":{"id":17434992,"name":"origami-build-tools","full_name":"Financial-Times/origami-build-tools","owner":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Financial-Times/origami-build-tools","description":"Standard Origami component development tools.","fork":false,"url":"https://api.github.com/repos/Financial-Times/origami-build-tools","forks_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/forks","keys_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/teams","hooks_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/hooks","issue_events_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/issues/events{/number}","events_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/events","assignees_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/assignees{/user}","branches_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/branches{/branch}","tags_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/tags","blobs_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/languages","stargazers_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/stargazers","contributors_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/contributors","subscribers_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/subscribers","subscription_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/subscription","commits_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/contents/{+path}","compare_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/merges","archive_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/downloads","issues_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/issues{/number}","pulls_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/labels{/name}","releases_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/releases{/id}","created_at":"2014-03-05T09:34:19Z","updated_at":"2015-05-10T00:20:24Z","pushed_at":"2015-06-23T13:01:42Z","git_url":"git://github.com/Financial-Times/origami-build-tools.git","ssh_url":"git@github.com:Financial-Times/origami-build-tools.git","clone_url":"https://github.com/Financial-Times/origami-build-tools.git","svn_url":"https://github.com/Financial-Times/origami-build-tools","homepage":null,"size":2438,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":18,"forks":4,"open_issues":18,"watchers":13,"default_branch":"master"}},"base":{"label":"Financial-Times:master","ref":"master","sha":"ec85a8f36cddbc3288294360f6a5747f625b8c71","user":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"repo":{"id":17434992,"name":"origami-build-tools","full_name":"Financial-Times/origami-build-tools","owner":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Financial-Times/origami-build-tools","description":"Standard Origami component development tools.","fork":false,"url":"https://api.github.com/repos/Financial-Times/origami-build-tools","forks_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/forks","keys_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/teams","hooks_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/hooks","issue_events_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/issues/events{/number}","events_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/events","assignees_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/assignees{/user}","branches_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/branches{/branch}","tags_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/tags","blobs_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/languages","stargazers_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/stargazers","contributors_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/contributors","subscribers_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/subscribers","subscription_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/subscription","commits_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/contents/{+path}","compare_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/merges","archive_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/downloads","issues_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/issues{/number}","pulls_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/labels{/name}","releases_url":"https://api.github.com/repos/Financial-Times/origami-build-tools/releases{/id}","created_at":"2014-03-05T09:34:19Z","updated_at":"2015-05-10T00:20:24Z","pushed_at":"2015-06-23T13:01:42Z","git_url":"git://github.com/Financial-Times/origami-build-tools.git","ssh_url":"git@github.com:Financial-Times/origami-build-tools.git","clone_url":"https://github.com/Financial-Times/origami-build-tools.git","svn_url":"https://github.com/Financial-Times/origami-build-tools","homepage":null,"size":2438,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":18,"forks":4,"open_issues":18,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Financial-Times/origami-build-tools/pulls/276"},"html":{"href":"https://github.com/Financial-Times/origami-build-tools/pull/276"},"issue":{"href":"https://api.github.com/repos/Financial-Times/origami-build-tools/issues/276"},"comments":{"href":"https://api.github.com/repos/Financial-Times/origami-build-tools/issues/276/comments"},"review_comments":{"href":"https://api.github.com/repos/Financial-Times/origami-build-tools/pulls/276/comments"},"review_comment":{"href":"https://api.github.com/repos/Financial-Times/origami-build-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Financial-Times/origami-build-tools/pulls/276/commits"},"statuses":{"href":"https://api.github.com/repos/Financial-Times/origami-build-tools/statuses/53e08d269a2918ffba1aa433afbf33ce1f7907ff"}}}}