{"action":"created","comment":{"url":"https://api.github.com/repos/divio/django-cms/pulls/comments/46555301","id":46555301,"diff_hunk":"@@ -2,4 +2,16 @@\n universal=1\n \n [flake8]\n+exclude=*migrations*","path":"setup.cfg","position":4,"original_position":4,"commit_id":"f937f4023550ac355e7601bc5d0b122b43349c23","original_commit_id":"f937f4023550ac355e7601bc5d0b122b43349c23","user":{"login":"timgraham","id":411869,"avatar_url":"https://avatars.githubusercontent.com/u/411869?v=3","gravatar_id":"","url":"https://api.github.com/users/timgraham","html_url":"https://github.com/timgraham","followers_url":"https://api.github.com/users/timgraham/followers","following_url":"https://api.github.com/users/timgraham/following{/other_user}","gists_url":"https://api.github.com/users/timgraham/gists{/gist_id}","starred_url":"https://api.github.com/users/timgraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timgraham/subscriptions","organizations_url":"https://api.github.com/users/timgraham/orgs","repos_url":"https://api.github.com/users/timgraham/repos","events_url":"https://api.github.com/users/timgraham/events{/privacy}","received_events_url":"https://api.github.com/users/timgraham/received_events","type":"User","site_admin":false},"body":"Yes, the main issue you might see is long line lengths. We manually format them or use autopep8.","created_at":"2015-12-03T14:17:18Z","updated_at":"2015-12-03T14:17:18Z","html_url":"https://github.com/divio/django-cms/pull/4809#discussion_r46555301","pull_request_url":"https://api.github.com/repos/divio/django-cms/pulls/4809","_links":{"self":{"href":"https://api.github.com/repos/divio/django-cms/pulls/comments/46555301"},"html":{"href":"https://github.com/divio/django-cms/pull/4809#discussion_r46555301"},"pull_request":{"href":"https://api.github.com/repos/divio/django-cms/pulls/4809"}}},"pull_request":{"url":"https://api.github.com/repos/divio/django-cms/pulls/4809","id":52503436,"html_url":"https://github.com/divio/django-cms/pull/4809","diff_url":"https://github.com/divio/django-cms/pull/4809.diff","patch_url":"https://github.com/divio/django-cms/pull/4809.patch","issue_url":"https://api.github.com/repos/divio/django-cms/issues/4809","number":4809,"state":"open","locked":false,"title":"Propose flake8 / isort configuration","user":{"login":"yakky","id":714711,"avatar_url":"https://avatars.githubusercontent.com/u/714711?v=3","gravatar_id":"","url":"https://api.github.com/users/yakky","html_url":"https://github.com/yakky","followers_url":"https://api.github.com/users/yakky/followers","following_url":"https://api.github.com/users/yakky/following{/other_user}","gists_url":"https://api.github.com/users/yakky/gists{/gist_id}","starred_url":"https://api.github.com/users/yakky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yakky/subscriptions","organizations_url":"https://api.github.com/users/yakky/orgs","repos_url":"https://api.github.com/users/yakky/repos","events_url":"https://api.github.com/users/yakky/events{/privacy}","received_events_url":"https://api.github.com/users/yakky/received_events","type":"User","site_admin":false},"body":"This is a proposed configuration for flake8, isort configuration\r\nisort it's not tested ATM waiting to be able to port the code to compliance\r\nSkipping migrations folder from flake8 tests","created_at":"2015-12-03T08:15:27Z","updated_at":"2015-12-03T14:17:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2698153daf4e3eb73b03679111cc675818e0ad7b","assignee":null,"milestone":{"url":"https://api.github.com/repos/divio/django-cms/milestones/40","html_url":"https://github.com/divio/django-cms/milestones/3.3","labels_url":"https://api.github.com/repos/divio/django-cms/milestones/40/labels","id":1333248,"number":40,"title":"3.3","description":"Rethinking menus and improving the UX of the pagetree.","creator":{"login":"mkoistinen","id":615759,"avatar_url":"https://avatars.githubusercontent.com/u/615759?v=3","gravatar_id":"","url":"https://api.github.com/users/mkoistinen","html_url":"https://github.com/mkoistinen","followers_url":"https://api.github.com/users/mkoistinen/followers","following_url":"https://api.github.com/users/mkoistinen/following{/other_user}","gists_url":"https://api.github.com/users/mkoistinen/gists{/gist_id}","starred_url":"https://api.github.com/users/mkoistinen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkoistinen/subscriptions","organizations_url":"https://api.github.com/users/mkoistinen/orgs","repos_url":"https://api.github.com/users/mkoistinen/repos","events_url":"https://api.github.com/users/mkoistinen/events{/privacy}","received_events_url":"https://api.github.com/users/mkoistinen/received_events","type":"User","site_admin":false},"open_issues":37,"closed_issues":12,"state":"open","created_at":"2015-10-01T14:26:39Z","updated_at":"2015-12-03T08:37:34Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/divio/django-cms/pulls/4809/commits","review_comments_url":"https://api.github.com/repos/divio/django-cms/pulls/4809/comments","review_comment_url":"https://api.github.com/repos/divio/django-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/divio/django-cms/issues/4809/comments","statuses_url":"https://api.github.com/repos/divio/django-cms/statuses/f937f4023550ac355e7601bc5d0b122b43349c23","head":{"label":"yakky:feature/setupcfg","ref":"feature/setupcfg","sha":"f937f4023550ac355e7601bc5d0b122b43349c23","user":{"login":"yakky","id":714711,"avatar_url":"https://avatars.githubusercontent.com/u/714711?v=3","gravatar_id":"","url":"https://api.github.com/users/yakky","html_url":"https://github.com/yakky","followers_url":"https://api.github.com/users/yakky/followers","following_url":"https://api.github.com/users/yakky/following{/other_user}","gists_url":"https://api.github.com/users/yakky/gists{/gist_id}","starred_url":"https://api.github.com/users/yakky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yakky/subscriptions","organizations_url":"https://api.github.com/users/yakky/orgs","repos_url":"https://api.github.com/users/yakky/repos","events_url":"https://api.github.com/users/yakky/events{/privacy}","received_events_url":"https://api.github.com/users/yakky/received_events","type":"User","site_admin":false},"repo":{"id":4582845,"name":"django-cms","full_name":"yakky/django-cms","owner":{"login":"yakky","id":714711,"avatar_url":"https://avatars.githubusercontent.com/u/714711?v=3","gravatar_id":"","url":"https://api.github.com/users/yakky","html_url":"https://github.com/yakky","followers_url":"https://api.github.com/users/yakky/followers","following_url":"https://api.github.com/users/yakky/following{/other_user}","gists_url":"https://api.github.com/users/yakky/gists{/gist_id}","starred_url":"https://api.github.com/users/yakky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yakky/subscriptions","organizations_url":"https://api.github.com/users/yakky/orgs","repos_url":"https://api.github.com/users/yakky/repos","events_url":"https://api.github.com/users/yakky/events{/privacy}","received_events_url":"https://api.github.com/users/yakky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yakky/django-cms","description":"An Advanced Django CMS.","fork":true,"url":"https://api.github.com/repos/yakky/django-cms","forks_url":"https://api.github.com/repos/yakky/django-cms/forks","keys_url":"https://api.github.com/repos/yakky/django-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yakky/django-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yakky/django-cms/teams","hooks_url":"https://api.github.com/repos/yakky/django-cms/hooks","issue_events_url":"https://api.github.com/repos/yakky/django-cms/issues/events{/number}","events_url":"https://api.github.com/repos/yakky/django-cms/events","assignees_url":"https://api.github.com/repos/yakky/django-cms/assignees{/user}","branches_url":"https://api.github.com/repos/yakky/django-cms/branches{/branch}","tags_url":"https://api.github.com/repos/yakky/django-cms/tags","blobs_url":"https://api.github.com/repos/yakky/django-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yakky/django-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yakky/django-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/yakky/django-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yakky/django-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/yakky/django-cms/languages","stargazers_url":"https://api.github.com/repos/yakky/django-cms/stargazers","contributors_url":"https://api.github.com/repos/yakky/django-cms/contributors","subscribers_url":"https://api.github.com/repos/yakky/django-cms/subscribers","subscription_url":"https://api.github.com/repos/yakky/django-cms/subscription","commits_url":"https://api.github.com/repos/yakky/django-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/yakky/django-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/yakky/django-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/yakky/django-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/yakky/django-cms/contents/{+path}","compare_url":"https://api.github.com/repos/yakky/django-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yakky/django-cms/merges","archive_url":"https://api.github.com/repos/yakky/django-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yakky/django-cms/downloads","issues_url":"https://api.github.com/repos/yakky/django-cms/issues{/number}","pulls_url":"https://api.github.com/repos/yakky/django-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/yakky/django-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/yakky/django-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yakky/django-cms/labels{/name}","releases_url":"https://api.github.com/repos/yakky/django-cms/releases{/id}","created_at":"2012-06-07T08:20:50Z","updated_at":"2015-10-05T19:13:24Z","pushed_at":"2015-12-03T09:09:40Z","git_url":"git://github.com/yakky/django-cms.git","ssh_url":"git@github.com:yakky/django-cms.git","clone_url":"https://github.com/yakky/django-cms.git","svn_url":"https://github.com/yakky/django-cms","homepage":"http://www.django-cms.org","size":58436,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":3,"default_branch":"develop"}},"base":{"label":"divio:develop","ref":"develop","sha":"4f46462754279a4ddb0e29667d569c5843037356","user":{"login":"divio","id":117904,"avatar_url":"https://avatars.githubusercontent.com/u/117904?v=3","gravatar_id":"","url":"https://api.github.com/users/divio","html_url":"https://github.com/divio","followers_url":"https://api.github.com/users/divio/followers","following_url":"https://api.github.com/users/divio/following{/other_user}","gists_url":"https://api.github.com/users/divio/gists{/gist_id}","starred_url":"https://api.github.com/users/divio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divio/subscriptions","organizations_url":"https://api.github.com/users/divio/orgs","repos_url":"https://api.github.com/users/divio/repos","events_url":"https://api.github.com/users/divio/events{/privacy}","received_events_url":"https://api.github.com/users/divio/received_events","type":"Organization","site_admin":false},"repo":{"id":143580,"name":"django-cms","full_name":"divio/django-cms","owner":{"login":"divio","id":117904,"avatar_url":"https://avatars.githubusercontent.com/u/117904?v=3","gravatar_id":"","url":"https://api.github.com/users/divio","html_url":"https://github.com/divio","followers_url":"https://api.github.com/users/divio/followers","following_url":"https://api.github.com/users/divio/following{/other_user}","gists_url":"https://api.github.com/users/divio/gists{/gist_id}","starred_url":"https://api.github.com/users/divio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divio/subscriptions","organizations_url":"https://api.github.com/users/divio/orgs","repos_url":"https://api.github.com/users/divio/repos","events_url":"https://api.github.com/users/divio/events{/privacy}","received_events_url":"https://api.github.com/users/divio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/divio/django-cms","description":"The easy-to-use and developer-friendly CMS","fork":false,"url":"https://api.github.com/repos/divio/django-cms","forks_url":"https://api.github.com/repos/divio/django-cms/forks","keys_url":"https://api.github.com/repos/divio/django-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/divio/django-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/divio/django-cms/teams","hooks_url":"https://api.github.com/repos/divio/django-cms/hooks","issue_events_url":"https://api.github.com/repos/divio/django-cms/issues/events{/number}","events_url":"https://api.github.com/repos/divio/django-cms/events","assignees_url":"https://api.github.com/repos/divio/django-cms/assignees{/user}","branches_url":"https://api.github.com/repos/divio/django-cms/branches{/branch}","tags_url":"https://api.github.com/repos/divio/django-cms/tags","blobs_url":"https://api.github.com/repos/divio/django-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/divio/django-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/divio/django-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/divio/django-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/divio/django-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/divio/django-cms/languages","stargazers_url":"https://api.github.com/repos/divio/django-cms/stargazers","contributors_url":"https://api.github.com/repos/divio/django-cms/contributors","subscribers_url":"https://api.github.com/repos/divio/django-cms/subscribers","subscription_url":"https://api.github.com/repos/divio/django-cms/subscription","commits_url":"https://api.github.com/repos/divio/django-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/divio/django-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/divio/django-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/divio/django-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/divio/django-cms/contents/{+path}","compare_url":"https://api.github.com/repos/divio/django-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/divio/django-cms/merges","archive_url":"https://api.github.com/repos/divio/django-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/divio/django-cms/downloads","issues_url":"https://api.github.com/repos/divio/django-cms/issues{/number}","pulls_url":"https://api.github.com/repos/divio/django-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/divio/django-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/divio/django-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/divio/django-cms/labels{/name}","releases_url":"https://api.github.com/repos/divio/django-cms/releases{/id}","created_at":"2009-03-05T10:14:18Z","updated_at":"2015-12-02T21:57:59Z","pushed_at":"2015-12-03T14:07:03Z","git_url":"git://github.com/divio/django-cms.git","ssh_url":"git@github.com:divio/django-cms.git","clone_url":"https://github.com/divio/django-cms.git","svn_url":"https://github.com/divio/django-cms","homepage":"http://www.django-cms.org","size":66793,"stargazers_count":3791,"watchers_count":3791,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1459,"mirror_url":null,"open_issues_count":205,"forks":1459,"open_issues":205,"watchers":3791,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/divio/django-cms/pulls/4809"},"html":{"href":"https://github.com/divio/django-cms/pull/4809"},"issue":{"href":"https://api.github.com/repos/divio/django-cms/issues/4809"},"comments":{"href":"https://api.github.com/repos/divio/django-cms/issues/4809/comments"},"review_comments":{"href":"https://api.github.com/repos/divio/django-cms/pulls/4809/comments"},"review_comment":{"href":"https://api.github.com/repos/divio/django-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/divio/django-cms/pulls/4809/commits"},"statuses":{"href":"https://api.github.com/repos/divio/django-cms/statuses/f937f4023550ac355e7601bc5d0b122b43349c23"}}}}