{"action":"closed","number":927,"pull_request":{"url":"https://api.github.com/repos/contiki-os/contiki/pulls/927","id":26402800,"html_url":"https://github.com/contiki-os/contiki/pull/927","diff_url":"https://github.com/contiki-os/contiki/pull/927.diff","patch_url":"https://github.com/contiki-os/contiki/pull/927.patch","issue_url":"https://api.github.com/repos/contiki-os/contiki/issues/927","number":927,"state":"closed","locked":false,"title":"Fix: set uip_ext_len to 0 after dropping packet","user":{"login":"siskin","id":630525,"avatar_url":"https://avatars.githubusercontent.com/u/630525?v=3","gravatar_id":"","url":"https://api.github.com/users/siskin","html_url":"https://github.com/siskin","followers_url":"https://api.github.com/users/siskin/followers","following_url":"https://api.github.com/users/siskin/following{/other_user}","gists_url":"https://api.github.com/users/siskin/gists{/gist_id}","starred_url":"https://api.github.com/users/siskin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siskin/subscriptions","organizations_url":"https://api.github.com/users/siskin/orgs","repos_url":"https://api.github.com/users/siskin/repos","events_url":"https://api.github.com/users/siskin/events{/privacy}","received_events_url":"https://api.github.com/users/siskin/received_events","type":"User","site_admin":false},"body":"###### Bug description:\r\nIf outgoing packet with hop-by-hop header is dropped in `tcpip_ipv6_output()` function, uip_ext_len is not set to 0. It causes next packet with no hop-by-hop header (for example ICMP) to become corrupt. Bug can be easily observed with ipv6/rpl-udp example client. If client looses connection with parrent, some outgoing DIO messages become corrupt (depending on the frequency of outgoing UDP messages). \r\n\r\n###### Fix description:\r\nIssue can be solved by adding:\r\n```\r\nuip_ext_len = 0;\r\n```\r\nbefore every return statement in `tcpip_ipv6_output()`. \r\n\r\nAfter comment on mailing list from Laurent Deru, `uip_ext_len = 0` is also added in other places where packet is discarded.","created_at":"2014-12-19T22:14:17Z","updated_at":"2015-08-28T21:40:26Z","closed_at":"2015-08-28T21:40:26Z","merged_at":null,"merge_commit_sha":"b02eebe227536e228a91e31100541896a02e9613","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/contiki-os/contiki/pulls/927/commits","review_comments_url":"https://api.github.com/repos/contiki-os/contiki/pulls/927/comments","review_comment_url":"https://api.github.com/repos/contiki-os/contiki/pulls/comments{/number}","comments_url":"https://api.github.com/repos/contiki-os/contiki/issues/927/comments","statuses_url":"https://api.github.com/repos/contiki-os/contiki/statuses/0c52940d5f6cf9c4ab469752176ef497a01e4629","head":{"label":"siskin:master","ref":"master","sha":"0c52940d5f6cf9c4ab469752176ef497a01e4629","user":{"login":"siskin","id":630525,"avatar_url":"https://avatars.githubusercontent.com/u/630525?v=3","gravatar_id":"","url":"https://api.github.com/users/siskin","html_url":"https://github.com/siskin","followers_url":"https://api.github.com/users/siskin/followers","following_url":"https://api.github.com/users/siskin/following{/other_user}","gists_url":"https://api.github.com/users/siskin/gists{/gist_id}","starred_url":"https://api.github.com/users/siskin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siskin/subscriptions","organizations_url":"https://api.github.com/users/siskin/orgs","repos_url":"https://api.github.com/users/siskin/repos","events_url":"https://api.github.com/users/siskin/events{/privacy}","received_events_url":"https://api.github.com/users/siskin/received_events","type":"User","site_admin":false},"repo":{"id":14835636,"name":"contiki","full_name":"siskin/contiki","owner":{"login":"siskin","id":630525,"avatar_url":"https://avatars.githubusercontent.com/u/630525?v=3","gravatar_id":"","url":"https://api.github.com/users/siskin","html_url":"https://github.com/siskin","followers_url":"https://api.github.com/users/siskin/followers","following_url":"https://api.github.com/users/siskin/following{/other_user}","gists_url":"https://api.github.com/users/siskin/gists{/gist_id}","starred_url":"https://api.github.com/users/siskin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siskin/subscriptions","organizations_url":"https://api.github.com/users/siskin/orgs","repos_url":"https://api.github.com/users/siskin/repos","events_url":"https://api.github.com/users/siskin/events{/privacy}","received_events_url":"https://api.github.com/users/siskin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/siskin/contiki","description":"The official git repository for Contiki, the open source OS for the Internet of Things","fork":true,"url":"https://api.github.com/repos/siskin/contiki","forks_url":"https://api.github.com/repos/siskin/contiki/forks","keys_url":"https://api.github.com/repos/siskin/contiki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/siskin/contiki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/siskin/contiki/teams","hooks_url":"https://api.github.com/repos/siskin/contiki/hooks","issue_events_url":"https://api.github.com/repos/siskin/contiki/issues/events{/number}","events_url":"https://api.github.com/repos/siskin/contiki/events","assignees_url":"https://api.github.com/repos/siskin/contiki/assignees{/user}","branches_url":"https://api.github.com/repos/siskin/contiki/branches{/branch}","tags_url":"https://api.github.com/repos/siskin/contiki/tags","blobs_url":"https://api.github.com/repos/siskin/contiki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/siskin/contiki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/siskin/contiki/git/refs{/sha}","trees_url":"https://api.github.com/repos/siskin/contiki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/siskin/contiki/statuses/{sha}","languages_url":"https://api.github.com/repos/siskin/contiki/languages","stargazers_url":"https://api.github.com/repos/siskin/contiki/stargazers","contributors_url":"https://api.github.com/repos/siskin/contiki/contributors","subscribers_url":"https://api.github.com/repos/siskin/contiki/subscribers","subscription_url":"https://api.github.com/repos/siskin/contiki/subscription","commits_url":"https://api.github.com/repos/siskin/contiki/commits{/sha}","git_commits_url":"https://api.github.com/repos/siskin/contiki/git/commits{/sha}","comments_url":"https://api.github.com/repos/siskin/contiki/comments{/number}","issue_comment_url":"https://api.github.com/repos/siskin/contiki/issues/comments{/number}","contents_url":"https://api.github.com/repos/siskin/contiki/contents/{+path}","compare_url":"https://api.github.com/repos/siskin/contiki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/siskin/contiki/merges","archive_url":"https://api.github.com/repos/siskin/contiki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/siskin/contiki/downloads","issues_url":"https://api.github.com/repos/siskin/contiki/issues{/number}","pulls_url":"https://api.github.com/repos/siskin/contiki/pulls{/number}","milestones_url":"https://api.github.com/repos/siskin/contiki/milestones{/number}","notifications_url":"https://api.github.com/repos/siskin/contiki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/siskin/contiki/labels{/name}","releases_url":"https://api.github.com/repos/siskin/contiki/releases{/id}","created_at":"2013-12-01T08:16:53Z","updated_at":"2014-12-19T22:01:51Z","pushed_at":"2014-12-19T22:01:51Z","git_url":"git://github.com/siskin/contiki.git","ssh_url":"git@github.com:siskin/contiki.git","clone_url":"https://github.com/siskin/contiki.git","svn_url":"https://github.com/siskin/contiki","homepage":"http://www.contiki-os.org/","size":60679,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"contiki-os:master","ref":"master","sha":"1f13be10fc5b06b8442da04ab37334d4c5a22283","user":{"login":"contiki-os","id":2511296,"avatar_url":"https://avatars.githubusercontent.com/u/2511296?v=3","gravatar_id":"","url":"https://api.github.com/users/contiki-os","html_url":"https://github.com/contiki-os","followers_url":"https://api.github.com/users/contiki-os/followers","following_url":"https://api.github.com/users/contiki-os/following{/other_user}","gists_url":"https://api.github.com/users/contiki-os/gists{/gist_id}","starred_url":"https://api.github.com/users/contiki-os/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiki-os/subscriptions","organizations_url":"https://api.github.com/users/contiki-os/orgs","repos_url":"https://api.github.com/users/contiki-os/repos","events_url":"https://api.github.com/users/contiki-os/events{/privacy}","received_events_url":"https://api.github.com/users/contiki-os/received_events","type":"Organization","site_admin":false},"repo":{"id":6365284,"name":"contiki","full_name":"contiki-os/contiki","owner":{"login":"contiki-os","id":2511296,"avatar_url":"https://avatars.githubusercontent.com/u/2511296?v=3","gravatar_id":"","url":"https://api.github.com/users/contiki-os","html_url":"https://github.com/contiki-os","followers_url":"https://api.github.com/users/contiki-os/followers","following_url":"https://api.github.com/users/contiki-os/following{/other_user}","gists_url":"https://api.github.com/users/contiki-os/gists{/gist_id}","starred_url":"https://api.github.com/users/contiki-os/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiki-os/subscriptions","organizations_url":"https://api.github.com/users/contiki-os/orgs","repos_url":"https://api.github.com/users/contiki-os/repos","events_url":"https://api.github.com/users/contiki-os/events{/privacy}","received_events_url":"https://api.github.com/users/contiki-os/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/contiki-os/contiki","description":"The official git repository for Contiki, the open source OS for the Internet of Things","fork":false,"url":"https://api.github.com/repos/contiki-os/contiki","forks_url":"https://api.github.com/repos/contiki-os/contiki/forks","keys_url":"https://api.github.com/repos/contiki-os/contiki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/contiki-os/contiki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/contiki-os/contiki/teams","hooks_url":"https://api.github.com/repos/contiki-os/contiki/hooks","issue_events_url":"https://api.github.com/repos/contiki-os/contiki/issues/events{/number}","events_url":"https://api.github.com/repos/contiki-os/contiki/events","assignees_url":"https://api.github.com/repos/contiki-os/contiki/assignees{/user}","branches_url":"https://api.github.com/repos/contiki-os/contiki/branches{/branch}","tags_url":"https://api.github.com/repos/contiki-os/contiki/tags","blobs_url":"https://api.github.com/repos/contiki-os/contiki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/contiki-os/contiki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/contiki-os/contiki/git/refs{/sha}","trees_url":"https://api.github.com/repos/contiki-os/contiki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/contiki-os/contiki/statuses/{sha}","languages_url":"https://api.github.com/repos/contiki-os/contiki/languages","stargazers_url":"https://api.github.com/repos/contiki-os/contiki/stargazers","contributors_url":"https://api.github.com/repos/contiki-os/contiki/contributors","subscribers_url":"https://api.github.com/repos/contiki-os/contiki/subscribers","subscription_url":"https://api.github.com/repos/contiki-os/contiki/subscription","commits_url":"https://api.github.com/repos/contiki-os/contiki/commits{/sha}","git_commits_url":"https://api.github.com/repos/contiki-os/contiki/git/commits{/sha}","comments_url":"https://api.github.com/repos/contiki-os/contiki/comments{/number}","issue_comment_url":"https://api.github.com/repos/contiki-os/contiki/issues/comments{/number}","contents_url":"https://api.github.com/repos/contiki-os/contiki/contents/{+path}","compare_url":"https://api.github.com/repos/contiki-os/contiki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/contiki-os/contiki/merges","archive_url":"https://api.github.com/repos/contiki-os/contiki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/contiki-os/contiki/downloads","issues_url":"https://api.github.com/repos/contiki-os/contiki/issues{/number}","pulls_url":"https://api.github.com/repos/contiki-os/contiki/pulls{/number}","milestones_url":"https://api.github.com/repos/contiki-os/contiki/milestones{/number}","notifications_url":"https://api.github.com/repos/contiki-os/contiki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/contiki-os/contiki/labels{/name}","releases_url":"https://api.github.com/repos/contiki-os/contiki/releases{/id}","created_at":"2012-10-24T05:59:36Z","updated_at":"2015-08-28T19:31:13Z","pushed_at":"2015-08-28T18:09:52Z","git_url":"git://github.com/contiki-os/contiki.git","ssh_url":"git@github.com:contiki-os/contiki.git","clone_url":"https://github.com/contiki-os/contiki.git","svn_url":"https://github.com/contiki-os/contiki","homepage":"http://www.contiki-os.org/","size":89559,"stargazers_count":1499,"watchers_count":1499,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1064,"mirror_url":null,"open_issues_count":193,"forks":1064,"open_issues":193,"watchers":1499,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/contiki-os/contiki/pulls/927"},"html":{"href":"https://github.com/contiki-os/contiki/pull/927"},"issue":{"href":"https://api.github.com/repos/contiki-os/contiki/issues/927"},"comments":{"href":"https://api.github.com/repos/contiki-os/contiki/issues/927/comments"},"review_comments":{"href":"https://api.github.com/repos/contiki-os/contiki/pulls/927/comments"},"review_comment":{"href":"https://api.github.com/repos/contiki-os/contiki/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/contiki-os/contiki/pulls/927/commits"},"statuses":{"href":"https://api.github.com/repos/contiki-os/contiki/statuses/0c52940d5f6cf9c4ab469752176ef497a01e4629"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":13,"review_comments":2,"commits":1,"additions":14,"deletions":0,"changed_files":3}}