{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/MozStumbler/issues/1556","labels_url":"https://api.github.com/repos/mozilla/MozStumbler/issues/1556/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/MozStumbler/issues/1556/comments","events_url":"https://api.github.com/repos/mozilla/MozStumbler/issues/1556/events","html_url":"https://github.com/mozilla/MozStumbler/issues/1556","id":60524801,"number":1556,"title":"Geolocate JSON request is inconsistent with API specification","user":{"login":"sshvetsov","id":2501176,"avatar_url":"https://avatars.githubusercontent.com/u/2501176?v=3","gravatar_id":"","url":"https://api.github.com/users/sshvetsov","html_url":"https://github.com/sshvetsov","followers_url":"https://api.github.com/users/sshvetsov/followers","following_url":"https://api.github.com/users/sshvetsov/following{/other_user}","gists_url":"https://api.github.com/users/sshvetsov/gists{/gist_id}","starred_url":"https://api.github.com/users/sshvetsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sshvetsov/subscriptions","organizations_url":"https://api.github.com/users/sshvetsov/orgs","repos_url":"https://api.github.com/users/sshvetsov/repos","events_url":"https://api.github.com/users/sshvetsov/events{/privacy}","received_events_url":"https://api.github.com/users/sshvetsov/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/mozilla/MozStumbler/milestones/2","html_url":"https://github.com/mozilla/MozStumbler/milestones/P2","labels_url":"https://api.github.com/repos/mozilla/MozStumbler/milestones/2/labels","id":1025443,"number":2,"title":"P2","description":"","creator":{"login":"crankycoder","id":4829,"avatar_url":"https://avatars.githubusercontent.com/u/4829?v=3","gravatar_id":"","url":"https://api.github.com/users/crankycoder","html_url":"https://github.com/crankycoder","followers_url":"https://api.github.com/users/crankycoder/followers","following_url":"https://api.github.com/users/crankycoder/following{/other_user}","gists_url":"https://api.github.com/users/crankycoder/gists{/gist_id}","starred_url":"https://api.github.com/users/crankycoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crankycoder/subscriptions","organizations_url":"https://api.github.com/users/crankycoder/orgs","repos_url":"https://api.github.com/users/crankycoder/repos","events_url":"https://api.github.com/users/crankycoder/events{/privacy}","received_events_url":"https://api.github.com/users/crankycoder/received_events","type":"User","site_admin":false},"open_issues":57,"closed_issues":2,"state":"open","created_at":"2015-03-17T13:55:05Z","updated_at":"2015-03-20T09:44:44Z","due_on":null,"closed_at":null},"comments":7,"created_at":"2015-03-10T16:10:30Z","updated_at":"2015-03-20T09:44:44Z","closed_at":"2015-03-20T09:44:44Z","body":"StumblerBundle.toMLSGeolocate() generates JSON that is not consistent with geolocate request format specified in https://mozilla-ichnaea.readthedocs.org/en/latest/api/index.html#geolocate (which points to https://developers.google.com/maps/documentation/business/geolocation/#requests)\r\n\r\nJSON specified by the geolocate API document looks like this:\r\n```\r\n{\r\n  \"homeMobileCountryCode\": 310,\r\n  \"homeMobileNetworkCode\": 410,\r\n  \"radioType\": \"gsm\",\r\n  \"carrier\": \"Vodafone\",\r\n  \"cellTowers\": [\r\n    \"cellId\": 42,\r\n    \"locationAreaCode\": 415,\r\n    \"mobileCountryCode\": 310,\r\n    \"mobileNetworkCode\": 410,\r\n    \"age\": 0,\r\n    \"signalStrength\": -60,\r\n    \"timingAdvance\": 15\r\n  ],\r\n  \"wifiAccessPoints\": [\r\n    \"macAddress\": ...,\r\n    \"signalStrength\": ...,\r\n    \"age\": 0,\r\n    \"channel\": 11,\r\n    \"signalToNoiseRatio\": 40\r\n  ]\r\n}\r\n```\r\n\r\nJSON generated by toMLSGeolocate() looks like this:\r\n```\r\n{\r\n  \"latitude\": ...,\r\n  \"longitude\": ...,\r\n  \"timestamp\": ...,\r\n  \"cellTowers\": [\r\n    \"cellId\": 42,\r\n    \"locationAreaCode\": 415,\r\n    \"mobileCountryCode\": 310,\r\n    \"mobileNetworkCode\": 410,\r\n    \"radioType\": \"gsm\",\r\n    \"signalStrength\": -60,\r\n    \"timingAdvance\": 15,\r\n    \"psc\": ...,\r\n    \"asu\": ...\r\n  ]\r\n  \"wifiAccessPoints\": [\r\n    \"macAddress\": ...,\r\n    \"frequency\": ...,\r\n    \"signalStrength\": ...\r\n  ]\r\n}\r\n```\r\n\r\nEither Ichnea API description needs to be updated to reflect the actual request format, or MozStumbler generates incorrect geolocate request to MLS."},"comment":{"url":"https://api.github.com/repos/mozilla/MozStumbler/issues/comments/83969951","html_url":"https://github.com/mozilla/MozStumbler/issues/1556#issuecomment-83969951","issue_url":"https://api.github.com/repos/mozilla/MozStumbler/issues/1556","id":83969951,"user":{"login":"hannosch","id":483109,"avatar_url":"https://avatars.githubusercontent.com/u/483109?v=3","gravatar_id":"","url":"https://api.github.com/users/hannosch","html_url":"https://github.com/hannosch","followers_url":"https://api.github.com/users/hannosch/followers","following_url":"https://api.github.com/users/hannosch/following{/other_user}","gists_url":"https://api.github.com/users/hannosch/gists{/gist_id}","starred_url":"https://api.github.com/users/hannosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hannosch/subscriptions","organizations_url":"https://api.github.com/users/hannosch/orgs","repos_url":"https://api.github.com/users/hannosch/repos","events_url":"https://api.github.com/users/hannosch/events{/privacy}","received_events_url":"https://api.github.com/users/hannosch/received_events","type":"User","site_admin":false},"created_at":"2015-03-20T09:44:44Z","updated_at":"2015-03-20T09:44:44Z","body":"Thx!"}}