{"action":"created","comment":{"url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/pulls/comments/35790218","id":35790218,"diff_hunk":"@@ -372,6 +681,194 @@ - (void)configureTodaysStatsCell:(InsightsTodaysStatsTableViewCell *)cell\n }\n \n \n+- (void)configureSectionGroupHeaderCell:(StatsStandardBorderedTableViewCell *)cell withStatsSection:(StatsSection)statsSection\n+{\n+    StatsGroup *statsGroup = [self statsDataForStatsSection:statsSection];\n+    NSString *headerText = statsGroup.groupTitle;\n+    \n+    UILabel *label = (UILabel *)[cell.contentView viewWithTag:100];","path":"WordPressCom-Stats-iOS/InsightsTableViewController.m","position":434,"original_position":434,"commit_id":"3097a373e21f13152b30b3754906880b493f8b50","original_commit_id":"3097a373e21f13152b30b3754906880b493f8b50","user":{"login":"aerych","id":1435271,"avatar_url":"https://avatars.githubusercontent.com/u/1435271?v=3","gravatar_id":"","url":"https://api.github.com/users/aerych","html_url":"https://github.com/aerych","followers_url":"https://api.github.com/users/aerych/followers","following_url":"https://api.github.com/users/aerych/following{/other_user}","gists_url":"https://api.github.com/users/aerych/gists{/gist_id}","starred_url":"https://api.github.com/users/aerych/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerych/subscriptions","organizations_url":"https://api.github.com/users/aerych/orgs","repos_url":"https://api.github.com/users/aerych/repos","events_url":"https://api.github.com/users/aerych/events{/privacy}","received_events_url":"https://api.github.com/users/aerych/received_events","type":"User","site_admin":false},"body":"Const for tag? ","created_at":"2015-07-29T17:55:32Z","updated_at":"2015-07-29T17:55:32Z","html_url":"https://github.com/wordpress-mobile/WordPressCom-Stats-iOS/pull/291#discussion_r35790218","pull_request_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/pulls/291","_links":{"self":{"href":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/pulls/comments/35790218"},"html":{"href":"https://github.com/wordpress-mobile/WordPressCom-Stats-iOS/pull/291#discussion_r35790218"},"pull_request":{"href":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/pulls/291"}}},"pull_request":{"url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/pulls/291","id":41126002,"html_url":"https://github.com/wordpress-mobile/WordPressCom-Stats-iOS/pull/291","diff_url":"https://github.com/wordpress-mobile/WordPressCom-Stats-iOS/pull/291.diff","patch_url":"https://github.com/wordpress-mobile/WordPressCom-Stats-iOS/pull/291.patch","issue_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/issues/291","number":291,"state":"open","locked":false,"title":"Move non-periodic sections to Insights","user":{"login":"astralbodies","id":373903,"avatar_url":"https://avatars.githubusercontent.com/u/373903?v=3","gravatar_id":"","url":"https://api.github.com/users/astralbodies","html_url":"https://github.com/astralbodies","followers_url":"https://api.github.com/users/astralbodies/followers","following_url":"https://api.github.com/users/astralbodies/following{/other_user}","gists_url":"https://api.github.com/users/astralbodies/gists{/gist_id}","starred_url":"https://api.github.com/users/astralbodies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astralbodies/subscriptions","organizations_url":"https://api.github.com/users/astralbodies/orgs","repos_url":"https://api.github.com/users/astralbodies/repos","events_url":"https://api.github.com/users/astralbodies/events{/privacy}","received_events_url":"https://api.github.com/users/astralbodies/received_events","type":"User","site_admin":false},"body":"Closes #257 \r\n\r\nMoved all of the non-periodic sections from the Days/Weeks/Months/Years screens to the Insights screen. This includes comments, tags/categories, followers and publicize.\r\n\r\nI also had to change the services for batching to move the calls for those sections into the batched call for Insights. While doing this I realized that the calls for these sections don't really need/use data or period type parameters so those got removed as well.\r\n\r\nThere is still quite a bit of duplicated logic between all of the view controllers and #223 will eventually address that.\r\n\r\n__Things To Test:__\r\n* Make sure tapping on the rows works properly - expanding nested rows, View All on sections that have it, launching out to Safari on a tag or post.\r\n* Pull to refresh to make sure data is consistent.\r\n* Rotation.\r\n* iPad and iPhone consistency.\r\n* Make sure data matches (quick check) to web stats.\r\n\r\n__How To Test:__\r\n* Check out the project and launch StatsDemo after filling in an OAuth2 token, site ID and time zone in `WPSViewController`. or\r\n* Ask Aaron nicely to deploy a new StatsDemo internal build based upon this branch/PR. :smile: \r\n\r\nNeeds Review: @isaackeyet, @jancavan, @aerych, @jleandroperez ","created_at":"2015-07-29T13:58:47Z","updated_at":"2015-07-29T17:55:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63440d7f907905e7b31d06961f68cdf668bbf71b","assignee":null,"milestone":{"url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/milestones/9","html_url":"https://github.com/wordpress-mobile/WordPressCom-Stats-iOS/milestones/Release%205","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/milestones/9/labels","id":1181853,"number":9,"title":"Release 5","description":"Aimed at WPiOS 5.6","creator":{"login":"astralbodies","id":373903,"avatar_url":"https://avatars.githubusercontent.com/u/373903?v=3","gravatar_id":"","url":"https://api.github.com/users/astralbodies","html_url":"https://github.com/astralbodies","followers_url":"https://api.github.com/users/astralbodies/followers","following_url":"https://api.github.com/users/astralbodies/following{/other_user}","gists_url":"https://api.github.com/users/astralbodies/gists{/gist_id}","starred_url":"https://api.github.com/users/astralbodies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astralbodies/subscriptions","organizations_url":"https://api.github.com/users/astralbodies/orgs","repos_url":"https://api.github.com/users/astralbodies/repos","events_url":"https://api.github.com/users/astralbodies/events{/privacy}","received_events_url":"https://api.github.com/users/astralbodies/received_events","type":"User","site_admin":false},"open_issues":26,"closed_issues":0,"state":"open","created_at":"2015-06-25T23:01:06Z","updated_at":"2015-07-29T13:58:47Z","due_on":"2015-08-14T05:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/pulls/291/commits","review_comments_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/pulls/291/comments","review_comment_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/issues/291/comments","statuses_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/statuses/3097a373e21f13152b30b3754906880b493f8b50","head":{"label":"wordpress-mobile:issue/257-nonperiodic-sections","ref":"issue/257-nonperiodic-sections","sha":"3097a373e21f13152b30b3754906880b493f8b50","user":{"login":"wordpress-mobile","id":1306301,"avatar_url":"https://avatars.githubusercontent.com/u/1306301?v=3","gravatar_id":"","url":"https://api.github.com/users/wordpress-mobile","html_url":"https://github.com/wordpress-mobile","followers_url":"https://api.github.com/users/wordpress-mobile/followers","following_url":"https://api.github.com/users/wordpress-mobile/following{/other_user}","gists_url":"https://api.github.com/users/wordpress-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/wordpress-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wordpress-mobile/subscriptions","organizations_url":"https://api.github.com/users/wordpress-mobile/orgs","repos_url":"https://api.github.com/users/wordpress-mobile/repos","events_url":"https://api.github.com/users/wordpress-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/wordpress-mobile/received_events","type":"Organization","site_admin":false},"repo":{"id":19698391,"name":"WordPressCom-Stats-iOS","full_name":"wordpress-mobile/WordPressCom-Stats-iOS","owner":{"login":"wordpress-mobile","id":1306301,"avatar_url":"https://avatars.githubusercontent.com/u/1306301?v=3","gravatar_id":"","url":"https://api.github.com/users/wordpress-mobile","html_url":"https://github.com/wordpress-mobile","followers_url":"https://api.github.com/users/wordpress-mobile/followers","following_url":"https://api.github.com/users/wordpress-mobile/following{/other_user}","gists_url":"https://api.github.com/users/wordpress-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/wordpress-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wordpress-mobile/subscriptions","organizations_url":"https://api.github.com/users/wordpress-mobile/orgs","repos_url":"https://api.github.com/users/wordpress-mobile/repos","events_url":"https://api.github.com/users/wordpress-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/wordpress-mobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wordpress-mobile/WordPressCom-Stats-iOS","description":"Reusable component for displaying WordPress.com site stats in an iOS application","fork":false,"url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS","forks_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/forks","keys_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/teams","hooks_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/hooks","issue_events_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/events","assignees_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/tags","blobs_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/languages","stargazers_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/stargazers","contributors_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/contributors","subscribers_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/subscribers","subscription_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/subscription","commits_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/merges","archive_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/downloads","issues_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/labels{/name}","releases_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/releases{/id}","created_at":"2014-05-12T12:48:07Z","updated_at":"2015-05-06T23:00:07Z","pushed_at":"2015-07-29T13:58:47Z","git_url":"git://github.com/wordpress-mobile/WordPressCom-Stats-iOS.git","ssh_url":"git@github.com:wordpress-mobile/WordPressCom-Stats-iOS.git","clone_url":"https://github.com/wordpress-mobile/WordPressCom-Stats-iOS.git","svn_url":"https://github.com/wordpress-mobile/WordPressCom-Stats-iOS","homepage":null,"size":3675,"stargazers_count":7,"watchers_count":7,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":31,"forks":5,"open_issues":31,"watchers":7,"default_branch":"develop"}},"base":{"label":"wordpress-mobile:develop","ref":"develop","sha":"060ef18d38c1e157ee00812fc3f69331c634b20e","user":{"login":"wordpress-mobile","id":1306301,"avatar_url":"https://avatars.githubusercontent.com/u/1306301?v=3","gravatar_id":"","url":"https://api.github.com/users/wordpress-mobile","html_url":"https://github.com/wordpress-mobile","followers_url":"https://api.github.com/users/wordpress-mobile/followers","following_url":"https://api.github.com/users/wordpress-mobile/following{/other_user}","gists_url":"https://api.github.com/users/wordpress-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/wordpress-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wordpress-mobile/subscriptions","organizations_url":"https://api.github.com/users/wordpress-mobile/orgs","repos_url":"https://api.github.com/users/wordpress-mobile/repos","events_url":"https://api.github.com/users/wordpress-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/wordpress-mobile/received_events","type":"Organization","site_admin":false},"repo":{"id":19698391,"name":"WordPressCom-Stats-iOS","full_name":"wordpress-mobile/WordPressCom-Stats-iOS","owner":{"login":"wordpress-mobile","id":1306301,"avatar_url":"https://avatars.githubusercontent.com/u/1306301?v=3","gravatar_id":"","url":"https://api.github.com/users/wordpress-mobile","html_url":"https://github.com/wordpress-mobile","followers_url":"https://api.github.com/users/wordpress-mobile/followers","following_url":"https://api.github.com/users/wordpress-mobile/following{/other_user}","gists_url":"https://api.github.com/users/wordpress-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/wordpress-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wordpress-mobile/subscriptions","organizations_url":"https://api.github.com/users/wordpress-mobile/orgs","repos_url":"https://api.github.com/users/wordpress-mobile/repos","events_url":"https://api.github.com/users/wordpress-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/wordpress-mobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wordpress-mobile/WordPressCom-Stats-iOS","description":"Reusable component for displaying WordPress.com site stats in an iOS application","fork":false,"url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS","forks_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/forks","keys_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/teams","hooks_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/hooks","issue_events_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/events","assignees_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/tags","blobs_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/languages","stargazers_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/stargazers","contributors_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/contributors","subscribers_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/subscribers","subscription_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/subscription","commits_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/merges","archive_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/downloads","issues_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/labels{/name}","releases_url":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/releases{/id}","created_at":"2014-05-12T12:48:07Z","updated_at":"2015-05-06T23:00:07Z","pushed_at":"2015-07-29T13:58:47Z","git_url":"git://github.com/wordpress-mobile/WordPressCom-Stats-iOS.git","ssh_url":"git@github.com:wordpress-mobile/WordPressCom-Stats-iOS.git","clone_url":"https://github.com/wordpress-mobile/WordPressCom-Stats-iOS.git","svn_url":"https://github.com/wordpress-mobile/WordPressCom-Stats-iOS","homepage":null,"size":3675,"stargazers_count":7,"watchers_count":7,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":31,"forks":5,"open_issues":31,"watchers":7,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/pulls/291"},"html":{"href":"https://github.com/wordpress-mobile/WordPressCom-Stats-iOS/pull/291"},"issue":{"href":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/issues/291"},"comments":{"href":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/issues/291/comments"},"review_comments":{"href":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/pulls/291/comments"},"review_comment":{"href":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/pulls/291/commits"},"statuses":{"href":"https://api.github.com/repos/wordpress-mobile/WordPressCom-Stats-iOS/statuses/3097a373e21f13152b30b3754906880b493f8b50"}}}}