{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/29","labels_url":"https://api.github.com/repos/nodejs/node/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/29/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/29/events","html_url":"https://github.com/nodejs/node/issues/29","id":79548493,"number":29,"title":"[Converge] src: fix builtin modules failing with --use-strict","user":{"login":"jasnell","id":439929,"avatar_url":"https://avatars.githubusercontent.com/u/439929?v=3","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/pull-from-joyent-node","name":"pull-from-joyent-node","color":"fef2c0"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-05-22T17:55:22Z","updated_at":"2015-06-02T17:31:18Z","closed_at":"2015-05-22T18:01:05Z","body":"See: https://github.com/joyent/node/commit/b233131901dea47132b0748d8e4d6bfcbba28abe\r\n\r\nOriginal commit message:\r\n```\r\nCurrently, lib/_tls_legacy.js and lib/crypto.js cannot be loaded when\r\n--use-strict is passed to node. In addition to that, console.trace\r\nthrows because it uses arguments.callee.\r\n\r\nThis change fixes these issues and adds a test that makes sure\r\nevery external built-in module can be loaded with require when\r\n--use-strict is enabled.\r\n\r\nPlease note that this change does not fix all issues with built-in\r\nmodules' code running with --use-strict. It is very likely that some\r\ncode in the built-in modules still fails when passing this flag.\r\n\r\nHowever, fixing all code would require us to enable strict mode by\r\ndefault in all builtins modules, which would certainly break existing\r\napplications.\r\n```\r\n\r\nFairly certain this is no longer necessary given the `use strict` changes already in io.js. Need confirmation, however. @piscisaureus @misterdjules @cjihrig @trevnorris "},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/108024538","html_url":"https://github.com/nodejs/node/issues/29#issuecomment-108024538","issue_url":"https://api.github.com/repos/nodejs/node/issues/29","id":108024538,"user":{"login":"misterdjules","id":811047,"avatar_url":"https://avatars.githubusercontent.com/u/811047?v=3","gravatar_id":"","url":"https://api.github.com/users/misterdjules","html_url":"https://github.com/misterdjules","followers_url":"https://api.github.com/users/misterdjules/followers","following_url":"https://api.github.com/users/misterdjules/following{/other_user}","gists_url":"https://api.github.com/users/misterdjules/gists{/gist_id}","starred_url":"https://api.github.com/users/misterdjules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misterdjules/subscriptions","organizations_url":"https://api.github.com/users/misterdjules/orgs","repos_url":"https://api.github.com/users/misterdjules/repos","events_url":"https://api.github.com/users/misterdjules/events{/privacy}","received_events_url":"https://api.github.com/users/misterdjules/received_events","type":"User","site_admin":false},"created_at":"2015-06-02T17:31:18Z","updated_at":"2015-06-02T17:31:18Z","body":"Sorry for catching up with that today, I'm just back from vacation.\r\n\r\nDid io.js get any github issue created because of breakage introduced by enabling strict mode in every built-in module? I would be surprised if no user had experienced any regression, since I expect the code coverage of the io.js' (and joyent/node) tests suite to not be 100%.\r\n\r\nI think that could be a good candidate to at least document in the list of changes between node v0.12 and the next LTS version of the converged node repo.\r\n\r\nThoughts?"}}