{"action":"created","issue":{"url":"https://api.github.com/repos/jimweirich/rspec-given/issues/43","labels_url":"https://api.github.com/repos/jimweirich/rspec-given/issues/43/labels{/name}","comments_url":"https://api.github.com/repos/jimweirich/rspec-given/issues/43/comments","events_url":"https://api.github.com/repos/jimweirich/rspec-given/issues/43/events","html_url":"https://github.com/jimweirich/rspec-given/pull/43","id":35108864,"number":43,"title":"Bug fix for `have_failed` with RSpec 3.0.0","user":{"login":"ronen","id":125620,"avatar_url":"https://avatars.githubusercontent.com/u/125620?v=3","gravatar_id":"","url":"https://api.github.com/users/ronen","html_url":"https://github.com/ronen","followers_url":"https://api.github.com/users/ronen/followers","following_url":"https://api.github.com/users/ronen/following{/other_user}","gists_url":"https://api.github.com/users/ronen/gists{/gist_id}","starred_url":"https://api.github.com/users/ronen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronen/subscriptions","organizations_url":"https://api.github.com/users/ronen/orgs","repos_url":"https://api.github.com/users/ronen/repos","events_url":"https://api.github.com/users/ronen/events{/privacy}","received_events_url":"https://api.github.com/users/ronen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2014-06-05T23:58:48Z","updated_at":"2015-01-09T14:51:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jimweirich/rspec-given/pulls/43","html_url":"https://github.com/jimweirich/rspec-given/pull/43","diff_url":"https://github.com/jimweirich/rspec-given/pull/43.diff","patch_url":"https://github.com/jimweirich/rspec-given/pull/43.patch"},"body":"With Mr. Weirich sadly no longer with us, I don't know who if anyone wil be maintaing this, but I figure I may as well at least post the issue/PR in case anybody else comes across the same issue.\r\n\r\nWith the release of RSpec 3.0.0, the `have_failed` mechanism no longer works.  Attempting:\r\n\r\n      When(:result) { stack.pop }\r\n      Then { expect(result).to have_failed(UnderflowError, /empty/) }\r\n\r\nResults in an error like:\r\n\r\n     Failure/Error: Then { expect(credentials).to have_failed UnderflowError }\r\n        expected UnderFlowError but was not given a block\r\n\r\nThis PR should fix that.\r\n\r\n(The specific RSpec change that caused this to break was rspec/rspec-expections@79582c2, which cleaned up the delineation between blocks and values for expect { } vs expect() as per rspec/rspec-expectations#526 ; unfortunately rspec-given was relying on the previous looseness to be able to use a value that quacked like a Proc.)\r\n"},"comment":{"url":"https://api.github.com/repos/jimweirich/rspec-given/issues/comments/69343444","html_url":"https://github.com/jimweirich/rspec-given/pull/43#issuecomment-69343444","issue_url":"https://api.github.com/repos/jimweirich/rspec-given/issues/43","id":69343444,"user":{"login":"ronen","id":125620,"avatar_url":"https://avatars.githubusercontent.com/u/125620?v=3","gravatar_id":"","url":"https://api.github.com/users/ronen","html_url":"https://github.com/ronen","followers_url":"https://api.github.com/users/ronen/followers","following_url":"https://api.github.com/users/ronen/following{/other_user}","gists_url":"https://api.github.com/users/ronen/gists{/gist_id}","starred_url":"https://api.github.com/users/ronen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronen/subscriptions","organizations_url":"https://api.github.com/users/ronen/orgs","repos_url":"https://api.github.com/users/ronen/repos","events_url":"https://api.github.com/users/ronen/events{/privacy}","received_events_url":"https://api.github.com/users/ronen/received_events","type":"User","site_admin":false},"created_at":"2015-01-09T14:51:29Z","updated_at":"2015-01-09T14:51:29Z","body":"hey justin -- glad to see you've taken on this gem!\r\n\r\n> Do you think it's ready to merge into rspec-given's new repo? https://github.com/rspec-given/rspec-given\r\n\r\nhmm....  no idea...   i haven't thought about this issue or looked at any of the repos since i submitted the PR..."}}