{"action":"created","issue":{"url":"https://api.github.com/repos/TyMaszWeb/django-template-finder/issues/6","labels_url":"https://api.github.com/repos/TyMaszWeb/django-template-finder/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/TyMaszWeb/django-template-finder/issues/6/comments","events_url":"https://api.github.com/repos/TyMaszWeb/django-template-finder/issues/6/events","html_url":"https://github.com/TyMaszWeb/django-template-finder/pull/6","id":55036543,"number":6,"title":"Updated utils to prevent errors on Django master","user":{"login":"kezabelle","id":118377,"avatar_url":"https://avatars.githubusercontent.com/u/118377?v=3","gravatar_id":"","url":"https://api.github.com/users/kezabelle","html_url":"https://github.com/kezabelle","followers_url":"https://api.github.com/users/kezabelle/followers","following_url":"https://api.github.com/users/kezabelle/following{/other_user}","gists_url":"https://api.github.com/users/kezabelle/gists{/gist_id}","starred_url":"https://api.github.com/users/kezabelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kezabelle/subscriptions","organizations_url":"https://api.github.com/users/kezabelle/orgs","repos_url":"https://api.github.com/users/kezabelle/repos","events_url":"https://api.github.com/users/kezabelle/events{/privacy}","received_events_url":"https://api.github.com/users/kezabelle/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-01-21T15:51:55Z","updated_at":"2015-01-26T10:58:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/TyMaszWeb/django-template-finder/pulls/6","html_url":"https://github.com/TyMaszWeb/django-template-finder/pull/6","diff_url":"https://github.com/TyMaszWeb/django-template-finder/pull/6.diff","patch_url":"https://github.com/TyMaszWeb/django-template-finder/pull/6.patch"},"body":"- Django 1.9 will drop `django.utils.importlib` in favour of the stdlib's version.\r\n- Django 1.8 changes the way the standard loaders work, because of the multiple-template engine changes. The change to instantiating the loader should work for DjangoTemplates, though I have no idea if it'd work for others."},"comment":{"url":"https://api.github.com/repos/TyMaszWeb/django-template-finder/issues/comments/71444242","html_url":"https://github.com/TyMaszWeb/django-template-finder/pull/6#issuecomment-71444242","issue_url":"https://api.github.com/repos/TyMaszWeb/django-template-finder/issues/6","id":71444242,"user":{"login":"centralniak","id":365324,"avatar_url":"https://avatars.githubusercontent.com/u/365324?v=3","gravatar_id":"","url":"https://api.github.com/users/centralniak","html_url":"https://github.com/centralniak","followers_url":"https://api.github.com/users/centralniak/followers","following_url":"https://api.github.com/users/centralniak/following{/other_user}","gists_url":"https://api.github.com/users/centralniak/gists{/gist_id}","starred_url":"https://api.github.com/users/centralniak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/centralniak/subscriptions","organizations_url":"https://api.github.com/users/centralniak/orgs","repos_url":"https://api.github.com/users/centralniak/repos","events_url":"https://api.github.com/users/centralniak/events{/privacy}","received_events_url":"https://api.github.com/users/centralniak/received_events","type":"User","site_admin":false},"created_at":"2015-01-26T10:58:17Z","updated_at":"2015-01-26T10:58:17Z","body":"Right, so I've run the test suite and got following results:\r\n\r\n```\r\n________________________________________________ summary ________________________________________________\r\nERROR:   py3.4-django1.7: commands failed\r\nERROR:   py3.3-django1.7: commands failed\r\nERROR:   py2.7-django1.7: commands failed\r\n  py3.4-django1.6: commands succeeded\r\n  py3.3-django1.6: commands succeeded\r\n  py2.7-django1.6: commands succeeded\r\n  py2.6-django1.6: commands succeeded\r\n  py3.3-django1.5: commands succeeded\r\n  py2.7-django1.5: commands succeeded\r\n  py2.6-django1.5: commands succeeded\r\n  py2.7-django1.4: commands succeeded\r\n  py2.6-django1.4: commands succeeded\r\n  py2.7-django1.3: commands succeeded\r\n  py2.6-django1.3: commands succeeded\r\n```\r\n\r\nI guess we might want to address the Django 1.7 issues?\r\n\r\nHere is a stack trace from Django 1.7 / Python 3.4 run:\r\n\r\n```\r\n======================================================================\r\nERROR: test_explicit_name (templatefinder.tests.AppDirectoriesLoaderTest)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/home/piotr/Opensource/django-template-finder/templatefinder/tests.py\", line 10, in test_explicit_name\r\n    self.assertEqual(['404.html'], find_all_templates('404.html'))\r\n  File \"/home/piotr/Opensource/django-template-finder/templatefinder/utils.py\", line 64, in find_all_templates\r\n    loader_class = getattr(import_module(module), klass)\r\n  File \"/home/piotr/.virtualenvs/django-template-finder/lib/python3.4/importlib/__init__.py\", line 109, in import_module\r\n    return _bootstrap._gcd_import(name[level:], package, level)\r\n  File \"<frozen importlib._bootstrap>\", line 2254, in _gcd_import\r\n  File \"<frozen importlib._bootstrap>\", line 2237, in _find_and_load\r\n  File \"<frozen importlib._bootstrap>\", line 2226, in _find_and_load_unlocked\r\n  File \"<frozen importlib._bootstrap>\", line 1200, in _load_unlocked\r\n  File \"<frozen importlib._bootstrap>\", line 1129, in _exec\r\n  File \"<frozen importlib._bootstrap>\", line 1471, in exec_module\r\n  File \"<frozen importlib._bootstrap>\", line 321, in _call_with_frames_removed\r\n  File \"/home/piotr/.virtualenvs/django-template-finder/lib/python3.4/site-packages/django/template/loaders/app_directories.py\", line 33, in <module>\r\n    app_template_dirs = calculate_app_template_dirs()\r\n  File \"/home/piotr/.virtualenvs/django-template-finder/lib/python3.4/site-packages/django/template/loaders/app_directories.py\", line 21, in calculate_app_template_dirs\r\n    for app_config in apps.get_app_configs():\r\n  File \"/home/piotr/.virtualenvs/django-template-finder/lib/python3.4/site-packages/django/apps/registry.py\", line 137, in get_app_configs\r\n    self.check_apps_ready()\r\n  File \"/home/piotr/.virtualenvs/django-template-finder/lib/python3.4/site-packages/django/apps/registry.py\", line 124, in check_apps_ready\r\n    raise AppRegistryNotReady(\"Apps aren't loaded yet.\")\r\ndjango.core.exceptions.AppRegistryNotReady: Apps aren't loaded yet.\r\n```\r\n\r\nDo you have any idea how to address this? Perhaps we need to adjust `runtests.py`? If not I should be able to help with this."}}