{"push_id":843988031,"size":526,"distinct_size":526,"ref":"refs/heads/master","head":"7b7886b8cb62f93df5d8820da90e700487b77fe3","before":"d9b54dc2312172c0556d7bfef662a89c96e011cc","commits":[{"sha":"471c663372b41adb0f54be93d729303ae90855c2","author":{"email":"53b8cfe4a97d546341cbef717c58a56a55287c83@twitter.com","name":"Neuman Vong"},"message":"[finagle-http] Increase test coverage\n\nProblem\n\nTest coverage is thin in some parts of finagle-http.\n\nSolution\n\nMore tests to increase coverage.\n\nResult\n\nIncreased line and branch coverage in finagle-http.\n\n                   line         branch\nc.t.f.http         75% => 86%   29% => 35%\nc.t.f.http.codec   76% => 94%   53% => 72%\nc.t.f.http.filter  84% => 95%   (no change)\nc.t.f.http.path    62% => 89%   16% => 40%\nc.t.f.http.service 97% => 100%  (no change)\n\nRB_ID=539092","distinct":true,"url":"https://api.github.com/repos/jbripley/finagle/commits/471c663372b41adb0f54be93d729303ae90855c2"},{"sha":"01bec841152e528dfce03d9aecaea02bdeb37a74","author":{"email":"53b8cfe4a97d546341cbef717c58a56a55287c83@twitter.com","name":"Neuman Vong"},"message":"[finagle-httpx] Remove deprecated code, shrink access\n\nProblem\n\nDeprecated code in http was copied over when we created httpx.\nThis is a good time to get rid of it (i.e. before people start\nusing httpx directly), and also shrink the access scope of\nthings that should be private to httpx/finagle.\n\nSolution\n\nRemove deprecated code and shrink access to internals.\n\nResult\n\nLeaner meaner httpx.\n\nRB_ID=539076","distinct":true,"url":"https://api.github.com/repos/jbripley/finagle/commits/01bec841152e528dfce03d9aecaea02bdeb37a74"},{"sha":"52d739db5b044149eddd7ce926935e708019018e","author":{"email":"772fe1f374d46bda4e68867185977c963227ef8e@twitter.com","name":"Ruben Oanta"},"message":"finagle-mux/thriftmux: Remove socket close race / Drain downgraded sessions correctly\n\nProblem\n\nWhen a ThriftMux server downgrades a connection to thrift, we fail\nto drain gracefully. There were two problems that contributed to this.\nFirst, the downgrade pipeline didn't respond with an Rdrain so the mux\nserver dispatcher never moved into a draining state. Secondly, the transport\nclose raced against the server's final writes.\n\nSolution\n\nSynthesize Rdrain in thriftmux and serialize the close with the final write.\n\nRB_ID=539596","distinct":true,"url":"https://api.github.com/repos/jbripley/finagle/commits/52d739db5b044149eddd7ce926935e708019018e"},{"sha":"9bec4aa866b2b1776093f9470b38cde10ca0086e","author":{"email":"ccc9d04961e5acc3041df4c85091b0af91b6102c@twitter.com","name":"Bing Wei"},"message":"finagle-core: deprecate InetAddressUtil.Loopback\n\nProblem:\n\nInetAddress.getByAddress(Array[Byte](127,0,0,1)) is outdated. Java 7 provides\njava.net.InetAddress.getLoopbackAddress for loopback address.\n\nSolution:\n\nDeprecate InetAddressUtil.Loopback, use java.net.InetAddress.getLoopbackAddress\neverywhere.\n\nRB_ID=535601","distinct":true,"url":"https://api.github.com/repos/jbripley/finagle/commits/9bec4aa866b2b1776093f9470b38cde10ca0086e"},{"sha":"bce3e9c8f8a3e633403c2873b4ed4e5215dd84d9","author":{"email":"759412786bc533369b22377bf83fb9056c5b25b2@twitter.com","name":"Johan Oskarsson"},"message":"3rdparty/BUILD: split up into package dirs - part 12\n\nRB_ID=540490\nTBR=true","distinct":true,"url":"https://api.github.com/repos/jbripley/finagle/commits/bce3e9c8f8a3e633403c2873b4ed4e5215dd84d9"},{"sha":"1a81e06698fdc4c2f880c4521a2ebeb2809cd815","author":{"email":"772fe1f374d46bda4e68867185977c963227ef8e@twitter.com","name":"Ruben Oanta"},"message":"finagle-thriftmux: properly scope downgrade pipeline\n\nRB_ID=540672","distinct":true,"url":"https://api.github.com/repos/jbripley/finagle/commits/1a81e06698fdc4c2f880c4521a2ebeb2809cd815"},{"sha":"50a5f8b00234648b4904dd77be18e98b62edad73","author":{"email":"af0275d08f4e2ea8b921f35617a75ec1f17960d4@twitter.com","name":"Steve Gury"},"message":"finagle-branchmark: use `status` instead of `isOpen`\n\nProblem\n\nfinagle-benchmark is not compiling because it used `transport.isOpen`\nwhich is now removed in favor of `transport.status`\n\nSolution\n\nReplace the calls to isOpen with their new equivalent.\n\nRB_ID=541720","distinct":true,"url":"https://api.github.com/repos/jbripley/finagle/commits/50a5f8b00234648b4904dd77be18e98b62edad73"},{"sha":"23f359a9218803d01897c6581ff6a3ac611149f5","author":{"email":"759412786bc533369b22377bf83fb9056c5b25b2@twitter.com","name":"Johan Oskarsson"},"message":"3rdparty/BUILD: split up into package dirs - part 14\n\nRB_ID=540856\nTBR=true","distinct":true,"url":"https://api.github.com/repos/jbripley/finagle/commits/23f359a9218803d01897c6581ff6a3ac611149f5"},{"sha":"8b96c58b1f6ee85eb84020fb62bced8eb79fd6f2","author":{"email":"c10410d0be39783d9bf58e785118de016f40dcdd@twitter.com","name":"Travis Brown"},"message":"Enable Scala 2.11 SBT builds for util-eval, ostrich, and finagle-ostrich4\n\nProblem\n\nWe want to publish 2.11 releases of Finagle subprojects that depend on Ostrich,\nwhich we have not previously built for 2.11 (because it has specs tests, and\nbecause it depends on scala-json and util-eval, neither of which previously\nworked on 2.11).\n\nSolution\n\nutil-eval previously didn't work on 2.11 because `scala.ScalaObject` has been\nremoved since 2.10. This is fixed here. The bulk of this commit is Rodrigo\nLazoti's migration of Ostrich's tests from specs to ScalaTest (I'm not using his\npull request since the PR also replaces scala-json with Jackson, which we don't\nwant to do at this time to avoid breaking public APIs). This commit also\nreinstates util-eval and the Finagle subprojects that depend on Ostrich in their\nprojects' cross-builds.\n\nResult\n\nutil-eval, ostrich, finagle-ostrich4, finagle-example, and finagle-stress all\nbuild and pass tests on 2.11 (from SBT) for the first time.\n\nRB_ID=534127","distinct":true,"url":"https://api.github.com/repos/jbripley/finagle/commits/8b96c58b1f6ee85eb84020fb62bced8eb79fd6f2"},{"sha":"1784b4fdb041efa964bbd393c486150120ac4470","author":{"email":"afc5e40f7e0ce50d0caf1701580b337509dfc04f@twitter.com","name":"Daniel Schobel"},"message":"finagle-sbt: exclude kestrelx from unidoc task\n\nthis is a temporary fix until the kestrel-x package\nis removed after the netty4 migration is complete.\n\nRB_ID=542284","distinct":true,"url":"https://api.github.com/repos/jbripley/finagle/commits/1784b4fdb041efa964bbd393c486150120ac4470"},{"sha":"06707b993fe05adfa035b3719d699faacca98d85","author":{"email":"24a54edd064a4908b8cc046e2ca1a8dcab73c61c@twitter.com","name":"Kevin Oliver"},"message":"finagle-thriftmux: Add test for ThriftMux client, Thrift server\n\nProblem\n\nNo test coverage for the behavior of a ThriftMux client\ntalking to a Thrift server.\n\nSolution\n\nAdd a test case that exhibits the expected, unsupported\nbehavior.\n\nRB_ID=541776","distinct":true,"url":"https://api.github.com/repos/jbripley/finagle/commits/06707b993fe05adfa035b3719d699faacca98d85"},{"sha":"1933e94771b6cc0b273b4235e3036562ee3c25fe","author":{"email":"53b8cfe4a97d546341cbef717c58a56a55287c83@twitter.com","name":"Neuman Vong"},"message":"[finagle-httpx] Increase test coverage\n\nProblem\n\nTest coverage is thin in some parts of finagle-httpx.\n\nSolution\n\nMore tests to increase coverage.\n\nResult\n\n                    line         branch\nc.t.f.httpx         76% => 83%   30% => 33%\nc.t.f.httpx.codec   75% => 93%   52% => 70%\nc.t.f.httpx.filter  84% => 95%   46% => 46%\nc.t.f.httpx.netty   78% => 90%   44% => 44%\nc.t.f.httpx.path    62% => 89%   16% => 40%\nc.t.f.httpx.service 97% => 100%  50% => 50%\n\nRB_ID=541474","distinct":true,"url":"https://api.github.com/repos/jbripley/finagle/commits/1933e94771b6cc0b273b4235e3036562ee3c25fe"},{"sha":"9c27b6b316e52113e15180902406b8c34d930a47","author":{"email":"f90be01014338abbfcdf1af3e138fe252c30d5a3@twitter.com","name":"Yuri Schimke"},"message":"finagle-core: Make MaskCancelFilter.Param public so it can be configured\n\nProblem\n\nMaskCancelFilter.Param is private to finagle and so can't be configured for servers\n\nRB_ID=542728","distinct":true,"url":"https://api.github.com/repos/jbripley/finagle/commits/9c27b6b316e52113e15180902406b8c34d930a47"},{"sha":"bf370bf199f07df459e06fe8a0392192983ec14c","author":{"email":"53b8cfe4a97d546341cbef717c58a56a55287c83@twitter.com","name":"Neuman Vong"},"message":"[finagle-http/x] Fix flaky streaming tests\n\nProblem\n\nSome streaming tests are flaky because of a race between\ndiscarding a Writable and writing to it. The test assumes\nthat discard happens before the write, causing the write to\nexpectedly fail. However, sometimes the write happens\nbefore.\n\nSolution\n\nWrite repeatedly so that even if we write early, subsequent\nwrites will come after the discard. This is likely because\nsubsequent writes wait for antecedent writes to complete.\n\nResult\n\nPasses on 1000 test runs.\n\nRB_ID=541456","distinct":true,"url":"https://api.github.com/repos/jbripley/finagle/commits/bf370bf199f07df459e06fe8a0392192983ec14c"},{"sha":"10d15b0a71437a461cd0c0fd4e62f2ab612f8194","author":{"email":"53b8cfe4a97d546341cbef717c58a56a55287c83@twitter.com","name":"Neuman Vong"},"message":"[trivial] Fix example client configuration in FAQ\n\nProblem\n\nWe don't yet support HTTPS with the fetchUrl API, but the examples in\nour documentation suggests we do.\n\nSolution\n\nUpdate the docs.\n\nRB_ID=541476","distinct":true,"url":"https://api.github.com/repos/jbripley/finagle/commits/10d15b0a71437a461cd0c0fd4e62f2ab612f8194"},{"sha":"44ecb096335eeb9f2cb880ac683a338eb6ecf5d5","author":{"email":"772fe1f374d46bda4e68867185977c963227ef8e@twitter.com","name":"Ruben Oanta"},"message":"finagle-mux: mock network in discard test\n\nProblem\n\nOur CI seems to have an issue with this particular test.\nI couldn't see any issues other than environment specific\nnetwork issues.\n\nSolution\n\nMock the network via AsyncQueues. This omits some of the modules\nin between, but I think it still tests the behavior in question.\n\nRB_ID=532115","distinct":true,"url":"https://api.github.com/repos/jbripley/finagle/commits/44ecb096335eeb9f2cb880ac683a338eb6ecf5d5"},{"sha":"eb8d55d8542b5c5201c5b55a662bae09fd23185a","author":{"email":"38edb439dbcce85f0f597d90d338db16e5438073@twitter.com","name":"marius a. eriksen"},"message":"finagle-core: remove Context.letEnv; add shadowing Context.let\n\nProblem\n\nContext.letEnv had the wrong semantics: the previous environment\nshould not be discarded (except intentionally through Context.letEnv).\nThis caused a bug where Client Ids were no longer propagated from\nlegacy clients.\n\nSolution\n\nIntroduce Context.let, with proper shadowing semantics.\n\nRB_ID=543118","distinct":true,"url":"https://api.github.com/repos/jbripley/finagle/commits/eb8d55d8542b5c5201c5b55a662bae09fd23185a"},{"sha":"6f8f023a5a73bbedb4b45c58c1ca30632ca3f2c5","author":{"email":"38edb439dbcce85f0f597d90d338db16e5438073@twitter.com","name":"marius a. eriksen"},"message":"Revert \"finagle-core: remove Context.letEnv; add shadowing Context.let\"\n\nThis reverts commit 4ed8aeeae69675ec6ac8ceb5803184a59745ff7d.\n\nRB_ID=543664\nTBR=true","distinct":true,"url":"https://api.github.com/repos/jbripley/finagle/commits/6f8f023a5a73bbedb4b45c58c1ca30632ca3f2c5"},{"sha":"50ad22c689faa0ad25a9919cad74f9d384b3d0f2","author":{"email":"08ba87d1bc41a8ba67db2e97262ce09841c2f246@twitter.com","name":"Antoine Tollenaere"},"message":"finagle-core: Properly pass parameters through in serveAndAnnounce\n\nProblem\n\nserveAndAnnounce(name: String, addr: String, Service[Req, Rep]) tries to\nserve on name and announce at addr, which is the opposite of what it\nsays it does.\n\nSolution\n\nFix the order of parameters.\n\nResult\n\nParameters are taken in the right order.\n\nRB_ID=542566","distinct":true,"url":"https://api.github.com/repos/jbripley/finagle/commits/50ad22c689faa0ad25a9919cad74f9d384b3d0f2"},{"sha":"ff1ef126bdd22c0164571a71ea5862f4472f05e5","author":{"email":"38edb439dbcce85f0f597d90d338db16e5438073@twitter.com","name":"marius a. eriksen"},"message":"finagle-core: remove Context.letEnv; add shadowing Context.let\n\nProblem\n\nContext.letEnv had the wrong semantics: the previous environment\nshould not be discarded (except intentionally through Context.letEnv).\nThis caused a bug where Client Ids were no longer propagated from\nlegacy clients.\n\nSolution\n\nIntroduce Context.let, with proper shadowing semantics.\n\nRB_ID=543820","distinct":true,"url":"https://api.github.com/repos/jbripley/finagle/commits/ff1ef126bdd22c0164571a71ea5862f4472f05e5"}]}