{"action":"created","issue":{"url":"https://api.github.com/repos/DataDog/dd-agent/issues/1904","labels_url":"https://api.github.com/repos/DataDog/dd-agent/issues/1904/labels{/name}","comments_url":"https://api.github.com/repos/DataDog/dd-agent/issues/1904/comments","events_url":"https://api.github.com/repos/DataDog/dd-agent/issues/1904/events","html_url":"https://github.com/DataDog/dd-agent/pull/1904","id":105771077,"number":1904,"title":"Added metrics from Linux /proc stats as sockstat and others","user":{"login":"maatthc","id":1077319,"avatar_url":"https://avatars.githubusercontent.com/u/1077319?v=3","gravatar_id":"","url":"https://api.github.com/users/maatthc","html_url":"https://github.com/maatthc","followers_url":"https://api.github.com/users/maatthc/followers","following_url":"https://api.github.com/users/maatthc/following{/other_user}","gists_url":"https://api.github.com/users/maatthc/gists{/gist_id}","starred_url":"https://api.github.com/users/maatthc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maatthc/subscriptions","organizations_url":"https://api.github.com/users/maatthc/orgs","repos_url":"https://api.github.com/users/maatthc/repos","events_url":"https://api.github.com/users/maatthc/events{/privacy}","received_events_url":"https://api.github.com/users/maatthc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/DataDog/dd-agent/milestones/54","html_url":"https://github.com/DataDog/dd-agent/milestones/5.7.0","labels_url":"https://api.github.com/repos/DataDog/dd-agent/milestones/54/labels","id":1360063,"number":54,"title":"5.7.0","description":null,"creator":{"login":"remh","id":1311477,"avatar_url":"https://avatars.githubusercontent.com/u/1311477?v=3","gravatar_id":"","url":"https://api.github.com/users/remh","html_url":"https://github.com/remh","followers_url":"https://api.github.com/users/remh/followers","following_url":"https://api.github.com/users/remh/following{/other_user}","gists_url":"https://api.github.com/users/remh/gists{/gist_id}","starred_url":"https://api.github.com/users/remh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remh/subscriptions","organizations_url":"https://api.github.com/users/remh/orgs","repos_url":"https://api.github.com/users/remh/repos","events_url":"https://api.github.com/users/remh/events{/privacy}","received_events_url":"https://api.github.com/users/remh/received_events","type":"User","site_admin":false},"open_issues":39,"closed_issues":0,"state":"open","created_at":"2015-10-16T19:06:06Z","updated_at":"2015-11-04T22:35:06Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2015-09-10T09:42:49Z","updated_at":"2015-11-05T09:50:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/DataDog/dd-agent/pulls/1904","html_url":"https://github.com/DataDog/dd-agent/pull/1904","diff_url":"https://github.com/DataDog/dd-agent/pull/1904.diff","patch_url":"https://github.com/DataDog/dd-agent/pull/1904.patch"},"body":"- /proc/net/sockstat\r\n- /proc/sys/net/ipv4/tcp_mem\r\n- /proc/sys/net/ipv4/tcp_max_orphans\r\n- /proc/sys/net/ipv4/netfilter/ip_conntrack_count\r\n- /proc/sys/net/ipv4/ip_conntrack_max\r\nAlso from the command :\r\n /usr/bin/getconf PAGESIZE\r\nThose are critical metrics for high performance applications."},"comment":{"url":"https://api.github.com/repos/DataDog/dd-agent/issues/comments/154009667","html_url":"https://github.com/DataDog/dd-agent/pull/1904#issuecomment-154009667","issue_url":"https://api.github.com/repos/DataDog/dd-agent/issues/1904","id":154009667,"user":{"login":"irabinovitch","id":289654,"avatar_url":"https://avatars.githubusercontent.com/u/289654?v=3","gravatar_id":"","url":"https://api.github.com/users/irabinovitch","html_url":"https://github.com/irabinovitch","followers_url":"https://api.github.com/users/irabinovitch/followers","following_url":"https://api.github.com/users/irabinovitch/following{/other_user}","gists_url":"https://api.github.com/users/irabinovitch/gists{/gist_id}","starred_url":"https://api.github.com/users/irabinovitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irabinovitch/subscriptions","organizations_url":"https://api.github.com/users/irabinovitch/orgs","repos_url":"https://api.github.com/users/irabinovitch/repos","events_url":"https://api.github.com/users/irabinovitch/events{/privacy}","received_events_url":"https://api.github.com/users/irabinovitch/received_events","type":"User","site_admin":false},"created_at":"2015-11-05T09:50:45Z","updated_at":"2015-11-05T09:50:45Z","body":"@maatthc  Thank you for your work on this and for being a part of the Datadog community.  We'd like to include in this in an upcoming release, but at the moment it looks to be failing tests. Would you mind taking a look at getting them passing? Happy to help if you need any assistance.\r\n\r\nMost of the failures look to be simple style issues raised by flake8. You can validate these by running flake8 locally.  However there also seems to be an issue with the new imports added on line 7.\r\n\r\nflake8\r\n./checks.d/network.py:226:1: W293 blank line contains whitespace\r\n./checks.d/network.py:230:1: W293 blank line contains whitespace\r\n./checks.d/network.py:340:37: E127 continuation line over-indented for visual indent\r\n./checks.d/network.py:341:37: E127 continuation line over-indented for visual indent\r\n./checks.d/network.py:449:1: W293 blank line contains whitespace\r\n./checks.d/network.py:462:1: W293 blank line contains whitespace\r\n./checks.d/network.py:475:1: W293 blank line contains whitespace\r\n./checks.d/network.py:487:13: F821 undefined name 'self'\r\n./checks.d/network.py:487:50: E225 missing whitespace around operator\r\n./checks.d/network.py:488:1: W293 blank line contains whitespace\r\n./checks.d/network.py:489:18: W291 trailing whitespace\r\n./checks.d/network.py:492:1: W293 blank line contains whitespace\r\n./checks.d/network.py:495:71: W291 trailing whitespace\r\n./checks.d/network.py:496:54: W291 trailing whitespace\r\n./checks.d/network.py:503:1: W293 blank line contains whitespace\r\n./checks.d/network.py:505:13: F821 undefined name 'self'\r\n./checks.d/network.py:505:50: E225 missing whitespace around operator\r\n./checks.d/network.py:506:39: E703 statement ends with a semicolon\r\n./checks.d/network.py:506:40: W291 trailing whitespace\r\n./checks.d/network.py:507:61: E703 statement ends with a semicolon\r\n./checks.d/network.py:507:62: W291 trailing whitespace\r\n./checks.d/network.py:508:38: E703 statement ends with a semicolon\r\n./checks.d/network.py:509:1: W293 blank line contains whitespace\r\n./checks.d/network.py:531:17: F821 undefined name 'self'\r\n./checks.d/network.py:531:55: E225 missing whitespace around operator\r\n./checks.d/network.py:533:1: W293 blank line contains whitespace\r\n./checks.d/network.py:551:117: E225 missing whitespace around operator\r\n./checks.d/network.py:551:118: E202 whitespace before ')'\r\n./checks.d/network.py:551:120: E225 missing whitespace around operator\r\n./checks.d/network.py:557:13: F821 undefined name 'self'\r\n./checks.d/network.py:557:50: E225 missing whitespace around operator\r\n./checks.d/network.py:559:1: W293 blank line contains whitespace\r\n./checks.d/network.py:562:30: W292 no newline at end of file\r\n"}}