{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/17350","labels_url":"https://api.github.com/repos/docker/docker/issues/17350/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/17350/comments","events_url":"https://api.github.com/repos/docker/docker/issues/17350/events","html_url":"https://github.com/docker/docker/pull/17350","id":113239288,"number":17350,"title":"dockerversion placeholder for library-import","user":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars.githubusercontent.com/u/6508?v=3","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/status/1-design-review","name":"status/1-design-review","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-10-25T17:47:50Z","updated_at":"2015-10-26T18:32:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/17350","html_url":"https://github.com/docker/docker/pull/17350","diff_url":"https://github.com/docker/docker/pull/17350.diff","patch_url":"https://github.com/docker/docker/pull/17350.patch"},"body":"Little bit scared to do this PR 😱 but here we go. This is *implementing* the idea of @erikh from #11699. Kinda want **some thoughts and opinions** on this and ideas to move forward, that's why the PR 🎅.\r\n\r\n> what about doing this, instead, as a placeholder? https://gist.github.com/erikh/e6f0c5e4b7b6c2483d52\r\n> \r\n> you could leave this in the repository so it's still go-gettable, but then overwrite it during the build. how does this sound?\r\n\r\nTo add to the discussion, quotation from @ibuildthecloud \r\n\r\n> I know people shouldn't import non-pkg code but I don't like that effectively docker makes it not possible. If people want to import stuff at their own risk, just let them.\r\n\r\n/ping @tianon @jfrazelle @docker/maintainers \r\n\r\n🐸\r\n\r\nSigned-off-by: Vincent Demeester <vincent@sbr.pm>"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/151240325","html_url":"https://github.com/docker/docker/pull/17350#issuecomment-151240325","issue_url":"https://api.github.com/repos/docker/docker/issues/17350","id":151240325,"user":{"login":"erikh","id":18923,"avatar_url":"https://avatars.githubusercontent.com/u/18923?v=3","gravatar_id":"","url":"https://api.github.com/users/erikh","html_url":"https://github.com/erikh","followers_url":"https://api.github.com/users/erikh/followers","following_url":"https://api.github.com/users/erikh/following{/other_user}","gists_url":"https://api.github.com/users/erikh/gists{/gist_id}","starred_url":"https://api.github.com/users/erikh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikh/subscriptions","organizations_url":"https://api.github.com/users/erikh/orgs","repos_url":"https://api.github.com/users/erikh/repos","events_url":"https://api.github.com/users/erikh/events{/privacy}","received_events_url":"https://api.github.com/users/erikh/received_events","type":"User","site_admin":false},"created_at":"2015-10-26T18:32:01Z","updated_at":"2015-10-26T18:32:01Z","body":"Seems legit as far as solutions go.\n\nGlad to see this is moving forward. Thanks all.\n\nOn 26 Oct 2015, at 10:55, Tianon Gravi wrote:\n\n> I'm not opposed to something like this, but I think we definitely need \n> to make sure that we don't have our build process modifying \n> Git-tracked files unless it can revert the changes it makes.  I think \n> we can combat this by using build tags -- ie, have `hack/make.sh` \n> include a build tag of `autogen` or something like that, and have the \n> checked in file ignored if that tag is specified, but the actual \n> autogenerated file is only used with the tag.  That way, I think we'd \n> get the best of both worlds as much as possible.\n>\n> ---\n> Reply to this email directly or view it on GitHub:\n> https://github.com/docker/docker/pull/17350#issuecomment-151226691\n"}}