{"action":"created","issue":{"url":"https://api.github.com/repos/Bit-Wasp/bitcoin-lib-php/issues/49","labels_url":"https://api.github.com/repos/Bit-Wasp/bitcoin-lib-php/issues/49/labels{/name}","comments_url":"https://api.github.com/repos/Bit-Wasp/bitcoin-lib-php/issues/49/comments","events_url":"https://api.github.com/repos/Bit-Wasp/bitcoin-lib-php/issues/49/events","html_url":"https://github.com/Bit-Wasp/bitcoin-lib-php/pull/49","id":54649495,"number":49,"title":"Fix check canonical signature","user":{"login":"afk11","id":5617245,"avatar_url":"https://avatars.githubusercontent.com/u/5617245?v=3","gravatar_id":"","url":"https://api.github.com/users/afk11","html_url":"https://github.com/afk11","followers_url":"https://api.github.com/users/afk11/followers","following_url":"https://api.github.com/users/afk11/following{/other_user}","gists_url":"https://api.github.com/users/afk11/gists{/gist_id}","starred_url":"https://api.github.com/users/afk11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afk11/subscriptions","organizations_url":"https://api.github.com/users/afk11/orgs","repos_url":"https://api.github.com/users/afk11/repos","events_url":"https://api.github.com/users/afk11/events{/privacy}","received_events_url":"https://api.github.com/users/afk11/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-01-17T03:49:27Z","updated_at":"2015-01-19T10:12:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Bit-Wasp/bitcoin-lib-php/pulls/49","html_url":"https://github.com/Bit-Wasp/bitcoin-lib-php/pull/49","diff_url":"https://github.com/Bit-Wasp/bitcoin-lib-php/pull/49.diff","patch_url":"https://github.com/Bit-Wasp/bitcoin-lib-php/pull/49.patch"},"body":"Rewrote encode_signature() and is_canonical_signature(). These are tested against vectors from the Satoshi client."},"comment":{"url":"https://api.github.com/repos/Bit-Wasp/bitcoin-lib-php/issues/comments/70471019","html_url":"https://github.com/Bit-Wasp/bitcoin-lib-php/pull/49#issuecomment-70471019","issue_url":"https://api.github.com/repos/Bit-Wasp/bitcoin-lib-php/issues/49","id":70471019,"user":{"login":"rubensayshi","id":649160,"avatar_url":"https://avatars.githubusercontent.com/u/649160?v=3","gravatar_id":"","url":"https://api.github.com/users/rubensayshi","html_url":"https://github.com/rubensayshi","followers_url":"https://api.github.com/users/rubensayshi/followers","following_url":"https://api.github.com/users/rubensayshi/following{/other_user}","gists_url":"https://api.github.com/users/rubensayshi/gists{/gist_id}","starred_url":"https://api.github.com/users/rubensayshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubensayshi/subscriptions","organizations_url":"https://api.github.com/users/rubensayshi/orgs","repos_url":"https://api.github.com/users/rubensayshi/repos","events_url":"https://api.github.com/users/rubensayshi/events{/privacy}","received_events_url":"https://api.github.com/users/rubensayshi/received_events","type":"User","site_admin":false},"created_at":"2015-01-19T10:12:49Z","updated_at":"2015-01-19T10:12:49Z","body":"looks good.\r\n\r\n - I think we should start throwing exceptions more often instead of silently failing and returning FALSE.\r\n - should we still do an `is_canonical_signature` after signing a TX? or are we going to asume it's always correct?"}}