{"action":"created","comment":{"url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments/28934496","id":28934496,"diff_hunk":"@@ -1,333 +1,264 @@\n-//= depend_on_asset \"active_admin/datepicker/datepicker-input-icon.png\"\n-// -------------------------------------- Active Admin Forms\n-form {\n-  /* Reset margins & Padding */\n-  ul, ol, li, fieldset, legend, input, textarea, select, p { margin:0; padding:0; }\n-  ol, ul { list-style: none }\n+input[type=text],\n+input[type=password],\n+input[type=email],\n+input[type=number],\n+input[type=url],\n+input[type=tel],\n+textarea {\n+  background-color: $input-background-color;\n+  border: 1px solid $input-border-color;\n+  border-radius: $input-border-radius;\n+  color: $input-color;\n+  display: inline-block;\n+  outline: none;\n+  padding: $padding-base-vertical $padding-base-horizontal;\n+  transition: border-color ease-in-out .15s, box-shadow ease-in-out .15s;\n+  width: calc(80% - #{($padding-base-horizontal * 2) + 2px});\n+\n+  &:focus {\n+    border: 1px solid $input-border-focus-color;\n+    box-shadow: 0 0 4px $input-border-focus-color;\n+  }\n+}\n+\n+.formtastic {\n+  ol, ul {\n+    list-style: none;\n+    margin: 0;\n+    padding: 0;\n+  }\n+\n+  .hidden {\n+    display: none;\n+  }\n+\n+  .input {\n+    margin-bottom: 15px;\n+  }\n+\n+  .label {\n+    display: block;\n+    float: left;\n+    font-weight: $font-weight-bold;\n+    width: 20%;\n+\n+    abbr {\n+      border: none;\n+      color:  $required-field-marker-color;\n+      margin-left: 0.3em;\n+    }\n+  }\n+\n+  .inputs {\n+    background-color: $panel-background-color;\n+    border-radius: $panel-border-radius;\n+\n+    > ol {\n+      padding: 15px;\n+    }\n+  }\n \n   fieldset {\n     border: 0;\n-    padding: 10px 0;\n-    margin-bottom: 20px;\n-\n-    &.inputs { @include section-background; }\n+    margin: 0 0 20px 0;\n+    padding: 0;\n+    position: relative; // for abosolute positioning sub fieldset legends for choices/fragments\n \n     legend {\n       width: 100%;\n-      span { display: block; @include section-header; }\n-    }\n \n-    ol > li {\n-      padding: 10px;\n-      label {\n+      span {\n+        background-color: $panel-heading-background-color;\n+        border-radius: $panel-border-radius $panel-border-radius 0 0;\n         display: block;\n-        width: 20%;\n-        float: left;\n-        font-size: 1.0em;\n-        font-weight: bold;\n-        color: $form-label-color;\n-        abbr {\n-          border: none;\n-          color:  $required-field-marker-color;\n-        }\n+        font-weight: $font-weight-bold;\n+        padding: $panel-heading-padding;\n       }\n     }\n \n-    ol > li.has_many_container {\n-      padding: 20px 10px;\n+    .has_many_container {\n       h3 {\n-        font-size: 12px;\n-        font-weight: bold;\n-      }\n-      .has_many_fields { margin: 10px 0 }\n-    }\n-\n-    ol > li > li label {\n-      line-height:100%;\n-      padding-top:0;\n-      input {\n-        line-height:100%;\n-        vertical-align:middle;\n-        margin-top:-0.1em;\n+        border-bottom: 1px solid #e8e8e8;\n+        margin-bottom: 20px;\n       }\n     }\n   }\n \n   // relative so the absolutely-positioned handle will fit\n-  .has_many_fields { position: relative }\n-\n-  .has_many_container {\n-    .handle {\n-      position: absolute;\n-      top: calc(50% - 3em / 2);\n-      right: 2px;\n-      padding: 0;\n-      cursor: move;\n-    }\n+  .has_many_fields {\n+    border-bottom: 1px solid #e8e8e8;\n+    margin-bottom: 15px;\n \n-    // If a sortable is nested in a sortable, give the parent handle space!\n-    &.ui-sortable .has_many_container {\n-      margin-right: 2em;\n+    ol {\n+      padding: 0 15px;\n+      position: relative;\n     }\n-  }\n \n-  .ui-sortable {\n-    // give the handle space!\n-    input[type=text], input[type=password], input[type=email], input[type=number], input[type=url], input[type=tel], textarea {\n-      width: calc(80% - #{$text-input-total-padding} - 2em - 1px);\n+    .handle {\n+      bottom: 0;\n+      cursor: move;\n+      position: absolute;\n+      right: 0;\n+      top: 0;\n+      width: 20px;\n+\n+      &:before {\n+        content: '\\1801\\1801\\1801\\1801';\n+        font-size: 1.8em;\n+        position: absolute;\n+      }\n     }\n   }\n \n-  /* Nested Fieldsets and Legends */\n-\n-  fieldset > ol > li {\n-    fieldset {\n-      position:relative;\n-      padding: 0;\n-      margin-bottom: 0;\n-\n-      legend {\n-        position:absolute;\n-        width:95%;\n-        padding-top:0.1em;\n-        left: 0px;\n-        font-size: 100%;\n-        font-weight: normal;\n-        span { position:absolute; }\n-        &.label label { position:absolute; }\n-      }\n-\n-      &:not(.has_many_fields) ol {\n-        float: left;\n-        width: 74%;\n-        margin: 0;\n-        padding: 0 0 0 20%;\n-\n-        li {\n-          padding: 0;\n-          border: 0;\n-        }\n-      }\n+  // Nested Fieldsets and Legends (radio, check boxes and date/time inputs use nested fieldsets)\n \n-      &.has_many_fields ol {\n-        float: left;\n-        width: 100%;\n-        margin: 0;\n-      }\n-    }\n+  legend.label {","path":"app/assets/stylesheets/active_admin/_forms.scss","position":208,"original_position":208,"commit_id":"e61e299709f566a99ae00ea3bf425e00b7f8cd9e","original_commit_id":"e61e299709f566a99ae00ea3bf425e00b7f8cd9e","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Avoid qualifying class selectors with an element.","created_at":"2015-04-23T03:31:34Z","updated_at":"2015-04-23T03:31:34Z","html_url":"https://github.com/activeadmin/activeadmin/pull/3907#discussion_r28934496","pull_request_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3907","_links":{"self":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments/28934496"},"html":{"href":"https://github.com/activeadmin/activeadmin/pull/3907#discussion_r28934496"},"pull_request":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3907"}}},"pull_request":{"url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3907","id":33921521,"html_url":"https://github.com/activeadmin/activeadmin/pull/3907","diff_url":"https://github.com/activeadmin/activeadmin/pull/3907.diff","patch_url":"https://github.com/activeadmin/activeadmin/pull/3907.patch","issue_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/3907","number":3907,"state":"open","locked":false,"title":"Major CSS overhaul","user":{"login":"javierjulio","id":198547,"avatar_url":"https://avatars.githubusercontent.com/u/198547?v=3","gravatar_id":"","url":"https://api.github.com/users/javierjulio","html_url":"https://github.com/javierjulio","followers_url":"https://api.github.com/users/javierjulio/followers","following_url":"https://api.github.com/users/javierjulio/following{/other_user}","gists_url":"https://api.github.com/users/javierjulio/gists{/gist_id}","starred_url":"https://api.github.com/users/javierjulio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierjulio/subscriptions","organizations_url":"https://api.github.com/users/javierjulio/orgs","repos_url":"https://api.github.com/users/javierjulio/repos","events_url":"https://api.github.com/users/javierjulio/events{/privacy}","received_events_url":"https://api.github.com/users/javierjulio/received_events","type":"User","site_admin":false},"body":"@timoschilling this new branch corrects my faulty rebase in PR #3862. Mid way through I did something very wrong and the amount of conflicts is simply too much. From that point on I noticed that my commits were duplicated (minus the 3 you had cherry picked into master early on) so from after that commit where I rebased master I cherry picked everything into a new clean branch. Sorry for the trouble! Let me know if you prefer I bring over the TODOs here or instead force push this back into #3862.","created_at":"2015-04-23T03:31:13Z","updated_at":"2015-04-23T03:31:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2498a0db0494f9a30ae0d4690f38ab09a3beb8af","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3907/commits","review_comments_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3907/comments","review_comment_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/3907/comments","statuses_url":"https://api.github.com/repos/activeadmin/activeadmin/statuses/e61e299709f566a99ae00ea3bf425e00b7f8cd9e","head":{"label":"javierjulio:major-css-overhaul","ref":"major-css-overhaul","sha":"e61e299709f566a99ae00ea3bf425e00b7f8cd9e","user":{"login":"javierjulio","id":198547,"avatar_url":"https://avatars.githubusercontent.com/u/198547?v=3","gravatar_id":"","url":"https://api.github.com/users/javierjulio","html_url":"https://github.com/javierjulio","followers_url":"https://api.github.com/users/javierjulio/followers","following_url":"https://api.github.com/users/javierjulio/following{/other_user}","gists_url":"https://api.github.com/users/javierjulio/gists{/gist_id}","starred_url":"https://api.github.com/users/javierjulio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierjulio/subscriptions","organizations_url":"https://api.github.com/users/javierjulio/orgs","repos_url":"https://api.github.com/users/javierjulio/repos","events_url":"https://api.github.com/users/javierjulio/events{/privacy}","received_events_url":"https://api.github.com/users/javierjulio/received_events","type":"User","site_admin":false},"repo":{"id":32771575,"name":"activeadmin","full_name":"javierjulio/activeadmin","owner":{"login":"javierjulio","id":198547,"avatar_url":"https://avatars.githubusercontent.com/u/198547?v=3","gravatar_id":"","url":"https://api.github.com/users/javierjulio","html_url":"https://github.com/javierjulio","followers_url":"https://api.github.com/users/javierjulio/followers","following_url":"https://api.github.com/users/javierjulio/following{/other_user}","gists_url":"https://api.github.com/users/javierjulio/gists{/gist_id}","starred_url":"https://api.github.com/users/javierjulio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierjulio/subscriptions","organizations_url":"https://api.github.com/users/javierjulio/orgs","repos_url":"https://api.github.com/users/javierjulio/repos","events_url":"https://api.github.com/users/javierjulio/events{/privacy}","received_events_url":"https://api.github.com/users/javierjulio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/javierjulio/activeadmin","description":"The administration framework for Ruby on Rails applications.","fork":true,"url":"https://api.github.com/repos/javierjulio/activeadmin","forks_url":"https://api.github.com/repos/javierjulio/activeadmin/forks","keys_url":"https://api.github.com/repos/javierjulio/activeadmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/javierjulio/activeadmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/javierjulio/activeadmin/teams","hooks_url":"https://api.github.com/repos/javierjulio/activeadmin/hooks","issue_events_url":"https://api.github.com/repos/javierjulio/activeadmin/issues/events{/number}","events_url":"https://api.github.com/repos/javierjulio/activeadmin/events","assignees_url":"https://api.github.com/repos/javierjulio/activeadmin/assignees{/user}","branches_url":"https://api.github.com/repos/javierjulio/activeadmin/branches{/branch}","tags_url":"https://api.github.com/repos/javierjulio/activeadmin/tags","blobs_url":"https://api.github.com/repos/javierjulio/activeadmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/javierjulio/activeadmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/javierjulio/activeadmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/javierjulio/activeadmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/javierjulio/activeadmin/statuses/{sha}","languages_url":"https://api.github.com/repos/javierjulio/activeadmin/languages","stargazers_url":"https://api.github.com/repos/javierjulio/activeadmin/stargazers","contributors_url":"https://api.github.com/repos/javierjulio/activeadmin/contributors","subscribers_url":"https://api.github.com/repos/javierjulio/activeadmin/subscribers","subscription_url":"https://api.github.com/repos/javierjulio/activeadmin/subscription","commits_url":"https://api.github.com/repos/javierjulio/activeadmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/javierjulio/activeadmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/javierjulio/activeadmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/javierjulio/activeadmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/javierjulio/activeadmin/contents/{+path}","compare_url":"https://api.github.com/repos/javierjulio/activeadmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/javierjulio/activeadmin/merges","archive_url":"https://api.github.com/repos/javierjulio/activeadmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/javierjulio/activeadmin/downloads","issues_url":"https://api.github.com/repos/javierjulio/activeadmin/issues{/number}","pulls_url":"https://api.github.com/repos/javierjulio/activeadmin/pulls{/number}","milestones_url":"https://api.github.com/repos/javierjulio/activeadmin/milestones{/number}","notifications_url":"https://api.github.com/repos/javierjulio/activeadmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/javierjulio/activeadmin/labels{/name}","releases_url":"https://api.github.com/repos/javierjulio/activeadmin/releases{/id}","created_at":"2015-03-24T02:32:35Z","updated_at":"2015-04-22T19:41:12Z","pushed_at":"2015-04-23T03:26:51Z","git_url":"git://github.com/javierjulio/activeadmin.git","ssh_url":"git@github.com:javierjulio/activeadmin.git","clone_url":"https://github.com/javierjulio/activeadmin.git","svn_url":"https://github.com/javierjulio/activeadmin","homepage":"activeadmin.info","size":7561,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"activeadmin:master","ref":"master","sha":"c6347ea2429d0f052e167ba472a35f1d1061124e","user":{"login":"activeadmin","id":814570,"avatar_url":"https://avatars.githubusercontent.com/u/814570?v=3","gravatar_id":"","url":"https://api.github.com/users/activeadmin","html_url":"https://github.com/activeadmin","followers_url":"https://api.github.com/users/activeadmin/followers","following_url":"https://api.github.com/users/activeadmin/following{/other_user}","gists_url":"https://api.github.com/users/activeadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/activeadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activeadmin/subscriptions","organizations_url":"https://api.github.com/users/activeadmin/orgs","repos_url":"https://api.github.com/users/activeadmin/repos","events_url":"https://api.github.com/users/activeadmin/events{/privacy}","received_events_url":"https://api.github.com/users/activeadmin/received_events","type":"Organization","site_admin":false},"repo":{"id":611921,"name":"activeadmin","full_name":"activeadmin/activeadmin","owner":{"login":"activeadmin","id":814570,"avatar_url":"https://avatars.githubusercontent.com/u/814570?v=3","gravatar_id":"","url":"https://api.github.com/users/activeadmin","html_url":"https://github.com/activeadmin","followers_url":"https://api.github.com/users/activeadmin/followers","following_url":"https://api.github.com/users/activeadmin/following{/other_user}","gists_url":"https://api.github.com/users/activeadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/activeadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activeadmin/subscriptions","organizations_url":"https://api.github.com/users/activeadmin/orgs","repos_url":"https://api.github.com/users/activeadmin/repos","events_url":"https://api.github.com/users/activeadmin/events{/privacy}","received_events_url":"https://api.github.com/users/activeadmin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/activeadmin/activeadmin","description":"The administration framework for Ruby on Rails applications.","fork":false,"url":"https://api.github.com/repos/activeadmin/activeadmin","forks_url":"https://api.github.com/repos/activeadmin/activeadmin/forks","keys_url":"https://api.github.com/repos/activeadmin/activeadmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/activeadmin/activeadmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/activeadmin/activeadmin/teams","hooks_url":"https://api.github.com/repos/activeadmin/activeadmin/hooks","issue_events_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/events{/number}","events_url":"https://api.github.com/repos/activeadmin/activeadmin/events","assignees_url":"https://api.github.com/repos/activeadmin/activeadmin/assignees{/user}","branches_url":"https://api.github.com/repos/activeadmin/activeadmin/branches{/branch}","tags_url":"https://api.github.com/repos/activeadmin/activeadmin/tags","blobs_url":"https://api.github.com/repos/activeadmin/activeadmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/activeadmin/activeadmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/activeadmin/activeadmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/activeadmin/activeadmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/activeadmin/activeadmin/statuses/{sha}","languages_url":"https://api.github.com/repos/activeadmin/activeadmin/languages","stargazers_url":"https://api.github.com/repos/activeadmin/activeadmin/stargazers","contributors_url":"https://api.github.com/repos/activeadmin/activeadmin/contributors","subscribers_url":"https://api.github.com/repos/activeadmin/activeadmin/subscribers","subscription_url":"https://api.github.com/repos/activeadmin/activeadmin/subscription","commits_url":"https://api.github.com/repos/activeadmin/activeadmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/activeadmin/activeadmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/activeadmin/activeadmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/activeadmin/activeadmin/contents/{+path}","compare_url":"https://api.github.com/repos/activeadmin/activeadmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/activeadmin/activeadmin/merges","archive_url":"https://api.github.com/repos/activeadmin/activeadmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/activeadmin/activeadmin/downloads","issues_url":"https://api.github.com/repos/activeadmin/activeadmin/issues{/number}","pulls_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls{/number}","milestones_url":"https://api.github.com/repos/activeadmin/activeadmin/milestones{/number}","notifications_url":"https://api.github.com/repos/activeadmin/activeadmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/activeadmin/activeadmin/labels{/name}","releases_url":"https://api.github.com/repos/activeadmin/activeadmin/releases{/id}","created_at":"2010-04-15T14:26:03Z","updated_at":"2015-04-23T01:21:26Z","pushed_at":"2015-04-23T03:31:13Z","git_url":"git://github.com/activeadmin/activeadmin.git","ssh_url":"git@github.com:activeadmin/activeadmin.git","clone_url":"https://github.com/activeadmin/activeadmin.git","svn_url":"https://github.com/activeadmin/activeadmin","homepage":"activeadmin.info","size":18935,"stargazers_count":5879,"watchers_count":5879,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2081,"mirror_url":null,"open_issues_count":179,"forks":2081,"open_issues":179,"watchers":5879,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3907"},"html":{"href":"https://github.com/activeadmin/activeadmin/pull/3907"},"issue":{"href":"https://api.github.com/repos/activeadmin/activeadmin/issues/3907"},"comments":{"href":"https://api.github.com/repos/activeadmin/activeadmin/issues/3907/comments"},"review_comments":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3907/comments"},"review_comment":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3907/commits"},"statuses":{"href":"https://api.github.com/repos/activeadmin/activeadmin/statuses/e61e299709f566a99ae00ea3bf425e00b7f8cd9e"}}}}