{"action":"created","issue":{"url":"https://api.github.com/repos/edx/edx-analytics-dashboard/issues/335","labels_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/issues/335/labels{/name}","comments_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/issues/335/comments","events_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/issues/335/events","html_url":"https://github.com/edx/edx-analytics-dashboard/pull/335","id":97267833,"number":335,"title":"Optional feature to show engagement as percent of enrollment","user":{"login":"bradenmacdonald","id":945577,"avatar_url":"https://avatars.githubusercontent.com/u/945577?v=3","gravatar_id":"","url":"https://api.github.com/users/bradenmacdonald","html_url":"https://github.com/bradenmacdonald","followers_url":"https://api.github.com/users/bradenmacdonald/followers","following_url":"https://api.github.com/users/bradenmacdonald/following{/other_user}","gists_url":"https://api.github.com/users/bradenmacdonald/gists{/gist_id}","starred_url":"https://api.github.com/users/bradenmacdonald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradenmacdonald/subscriptions","organizations_url":"https://api.github.com/users/bradenmacdonald/orgs","repos_url":"https://api.github.com/users/bradenmacdonald/repos","events_url":"https://api.github.com/users/bradenmacdonald/events{/privacy}","received_events_url":"https://api.github.com/users/bradenmacdonald/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/edx/edx-analytics-dashboard/labels/engineering%20review","name":"engineering review","color":"c7def8"},{"url":"https://api.github.com/repos/edx/edx-analytics-dashboard/labels/open-source-contribution","name":"open-source-contribution","color":"bfe5bf"},{"url":"https://api.github.com/repos/edx/edx-analytics-dashboard/labels/waiting%20on%20author","name":"waiting on author","color":"0052cc"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2015-07-25T23:57:24Z","updated_at":"2015-10-28T04:27:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/edx/edx-analytics-dashboard/pulls/335","html_url":"https://github.com/edx/edx-analytics-dashboard/pull/335","diff_url":"https://github.com/edx/edx-analytics-dashboard/pull/335.diff","patch_url":"https://github.com/edx/edx-analytics-dashboard/pull/335.patch"},"body":"**Description**: This PR adds a little bit more information to the course engagement summary screen in the dashboard: When enabled, it displays the weekly active student count as a percentage, in addition to the absolute number.\r\n\r\nThe percentage of active students for a week is approximated as ([# of active students that week] ÷ [# of enrolled students on the last day of the week] × 100).\r\n\r\nIn order to keep the code change simple for now, the new data is only displayed in the tables and summaries, and is not shown on the chart.\r\n\r\n**JIRA**: [OSPR-720](https://openedx.atlassian.net/browse/OSPR-720)\r\n\r\n**Partner Info**: 3rd party Open edX instance. Submitting to minimize code drift but no merge requirement.\r\n\r\n**Merge deadline**: Not an edX partner, so best effort.\r\n\r\n**Screenshots**:\r\n1. With the new feature enabled:\r\n   ![engagement percentages](https://cloud.githubusercontent.com/assets/945577/8891835/c00e0c78-32ed-11e5-826e-d4d1276d2ac0.png)\r\n2. With the new feature disabled:\r\n   ![engagement percentages disabled](https://cloud.githubusercontent.com/assets/945577/8891833/baf9f7c4-32ed-11e5-9955-5a501eea0803.png)\r\n\r\n\r\n**Configuration**:\r\nThe percentage/enrollment data is only computed and shown if the waffle switch `show_stats_vs_enrollment` is active.\r\n\r\n**Test Instructions**:\r\n1. Get a running copy of the dashboard.\r\n2. Import at least a few weeks' worth of engagement and enrollment data from an LMS instance such as your own devstack (for instructions on steps 1 and 2 see [here](https://github.com/open-craft/edx-analytics-devstack#running-the-pipeline))\r\n3. Go to {dashboard url}/admin/waffle/switch/ and enable `show_stats_vs_enrollment`.\r\n4. View a course's engagement summary in the dashboard\r\n\r\n**Reviewers**: @mtyaka and TBD"},"comment":{"url":"https://api.github.com/repos/edx/edx-analytics-dashboard/issues/comments/151718290","html_url":"https://github.com/edx/edx-analytics-dashboard/pull/335#issuecomment-151718290","issue_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/issues/335","id":151718290,"user":{"login":"bradenmacdonald","id":945577,"avatar_url":"https://avatars.githubusercontent.com/u/945577?v=3","gravatar_id":"","url":"https://api.github.com/users/bradenmacdonald","html_url":"https://github.com/bradenmacdonald","followers_url":"https://api.github.com/users/bradenmacdonald/followers","following_url":"https://api.github.com/users/bradenmacdonald/following{/other_user}","gists_url":"https://api.github.com/users/bradenmacdonald/gists{/gist_id}","starred_url":"https://api.github.com/users/bradenmacdonald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradenmacdonald/subscriptions","organizations_url":"https://api.github.com/users/bradenmacdonald/orgs","repos_url":"https://api.github.com/users/bradenmacdonald/repos","events_url":"https://api.github.com/users/bradenmacdonald/events{/privacy}","received_events_url":"https://api.github.com/users/bradenmacdonald/received_events","type":"User","site_admin":false},"created_at":"2015-10-28T04:27:28Z","updated_at":"2015-10-28T04:27:28Z","body":"@dsjen I've pushed a commit to address all your comments. \r\n\r\nHere's an updated screenshot:\r\n![screen shot 2015-10-27 at 9 25 01 pm](https://cloud.githubusercontent.com/assets/945577/10779687/7d922016-7cf1-11e5-9452-72dc78d3b758.png)\r\n"}}