{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments/39987897","id":39987897,"diff_hunk":"@@ -1284,6 +1344,19 @@\n                    :state (cond-> state column-validation-message (conj column-validation-message))\n                    :cut true})\n \n+                [[\"subquery\" relationship expr]]\n+                (let [subquery-expr (push-down-context\n+                                     (user-query->logical-obj (str \"select_\" relationship))\n+                                     expr)\n+                      nested-qc (:query-context (meta subquery-expr))]\n+\n+                  {:node (vary-meta [\"subquery\" relationship\n+                                     (vary-meta expr\n+                                                assoc :query-context nested-qc)]\n+                                    assoc :query-context context)\n+                   :state state\n+                   :cut true})","path":"src/puppetlabs/puppetdb/query_eng/engine.clj","position":144,"original_position":144,"commit_id":"f5c61598f2ea79285789a7f588fda8bb9c8e2832","original_commit_id":"f5c61598f2ea79285789a7f588fda8bb9c8e2832","user":{"login":"wkalt","id":4952091,"avatar_url":"https://avatars.githubusercontent.com/u/4952091?v=3","gravatar_id":"","url":"https://api.github.com/users/wkalt","html_url":"https://github.com/wkalt","followers_url":"https://api.github.com/users/wkalt/followers","following_url":"https://api.github.com/users/wkalt/following{/other_user}","gists_url":"https://api.github.com/users/wkalt/gists{/gist_id}","starred_url":"https://api.github.com/users/wkalt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkalt/subscriptions","organizations_url":"https://api.github.com/users/wkalt/orgs","repos_url":"https://api.github.com/users/wkalt/repos","events_url":"https://api.github.com/users/wkalt/events{/privacy}","received_events_url":"https://api.github.com/users/wkalt/received_events","type":"User","site_admin":false},"body":"I meant the :cut key","created_at":"2015-09-21T15:54:44Z","updated_at":"2015-09-21T15:54:44Z","html_url":"https://github.com/puppetlabs/puppetdb/pull/1643#discussion_r39987897","pull_request_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1643","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments/39987897"},"html":{"href":"https://github.com/puppetlabs/puppetdb/pull/1643#discussion_r39987897"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1643"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1643","id":45054965,"html_url":"https://github.com/puppetlabs/puppetdb/pull/1643","diff_url":"https://github.com/puppetlabs/puppetdb/pull/1643.diff","patch_url":"https://github.com/puppetlabs/puppetdb/pull/1643.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1643","number":1643,"state":"open","locked":false,"title":"(PDB-1924) Implicit subqueries","user":{"login":"kbarber","id":80595,"avatar_url":"https://avatars.githubusercontent.com/u/80595?v=3","gravatar_id":"","url":"https://api.github.com/users/kbarber","html_url":"https://github.com/kbarber","followers_url":"https://api.github.com/users/kbarber/followers","following_url":"https://api.github.com/users/kbarber/following{/other_user}","gists_url":"https://api.github.com/users/kbarber/gists{/gist_id}","starred_url":"https://api.github.com/users/kbarber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbarber/subscriptions","organizations_url":"https://api.github.com/users/kbarber/orgs","repos_url":"https://api.github.com/users/kbarber/repos","events_url":"https://api.github.com/users/kbarber/events{/privacy}","received_events_url":"https://api.github.com/users/kbarber/received_events","type":"User","site_admin":false},"body":"This patch adds the new functionality for implicit subqueries, rather subqueries\r\nthat require no explicit column names to be specified.\r\n\r\nSigned-off-by: Ken Barber <ken@bob.sh>","created_at":"2015-09-15T14:19:08Z","updated_at":"2015-09-21T15:54:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2eb006e7998a5a948b5f97156467fb05958ecc7","assignee":null,"milestone":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/milestones/8","html_url":"https://github.com/puppetlabs/puppetdb/milestones/3.2.0%20(master)","labels_url":"https://api.github.com/repos/puppetlabs/puppetdb/milestones/8/labels","id":1256027,"number":8,"title":"3.2.0 (master)","description":"","creator":{"login":"ajroetker","id":3198124,"avatar_url":"https://avatars.githubusercontent.com/u/3198124?v=3","gravatar_id":"","url":"https://api.github.com/users/ajroetker","html_url":"https://github.com/ajroetker","followers_url":"https://api.github.com/users/ajroetker/followers","following_url":"https://api.github.com/users/ajroetker/following{/other_user}","gists_url":"https://api.github.com/users/ajroetker/gists{/gist_id}","starred_url":"https://api.github.com/users/ajroetker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajroetker/subscriptions","organizations_url":"https://api.github.com/users/ajroetker/orgs","repos_url":"https://api.github.com/users/ajroetker/repos","events_url":"https://api.github.com/users/ajroetker/events{/privacy}","received_events_url":"https://api.github.com/users/ajroetker/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":24,"state":"open","created_at":"2015-08-14T23:38:34Z","updated_at":"2015-09-18T18:49:33Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1643/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1643/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1643/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/f5c61598f2ea79285789a7f588fda8bb9c8e2832","head":{"label":"kbarber:ticket/master/pdb-1924-implicit-subqueries","ref":"ticket/master/pdb-1924-implicit-subqueries","sha":"f5c61598f2ea79285789a7f588fda8bb9c8e2832","user":{"login":"kbarber","id":80595,"avatar_url":"https://avatars.githubusercontent.com/u/80595?v=3","gravatar_id":"","url":"https://api.github.com/users/kbarber","html_url":"https://github.com/kbarber","followers_url":"https://api.github.com/users/kbarber/followers","following_url":"https://api.github.com/users/kbarber/following{/other_user}","gists_url":"https://api.github.com/users/kbarber/gists{/gist_id}","starred_url":"https://api.github.com/users/kbarber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbarber/subscriptions","organizations_url":"https://api.github.com/users/kbarber/orgs","repos_url":"https://api.github.com/users/kbarber/repos","events_url":"https://api.github.com/users/kbarber/events{/privacy}","received_events_url":"https://api.github.com/users/kbarber/received_events","type":"User","site_admin":false},"repo":{"id":4444970,"name":"puppetdb","full_name":"kbarber/puppetdb","owner":{"login":"kbarber","id":80595,"avatar_url":"https://avatars.githubusercontent.com/u/80595?v=3","gravatar_id":"","url":"https://api.github.com/users/kbarber","html_url":"https://github.com/kbarber","followers_url":"https://api.github.com/users/kbarber/followers","following_url":"https://api.github.com/users/kbarber/following{/other_user}","gists_url":"https://api.github.com/users/kbarber/gists{/gist_id}","starred_url":"https://api.github.com/users/kbarber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbarber/subscriptions","organizations_url":"https://api.github.com/users/kbarber/orgs","repos_url":"https://api.github.com/users/kbarber/repos","events_url":"https://api.github.com/users/kbarber/events{/privacy}","received_events_url":"https://api.github.com/users/kbarber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kbarber/puppetdb","description":"Centralized Puppet Storage","fork":true,"url":"https://api.github.com/repos/kbarber/puppetdb","forks_url":"https://api.github.com/repos/kbarber/puppetdb/forks","keys_url":"https://api.github.com/repos/kbarber/puppetdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kbarber/puppetdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kbarber/puppetdb/teams","hooks_url":"https://api.github.com/repos/kbarber/puppetdb/hooks","issue_events_url":"https://api.github.com/repos/kbarber/puppetdb/issues/events{/number}","events_url":"https://api.github.com/repos/kbarber/puppetdb/events","assignees_url":"https://api.github.com/repos/kbarber/puppetdb/assignees{/user}","branches_url":"https://api.github.com/repos/kbarber/puppetdb/branches{/branch}","tags_url":"https://api.github.com/repos/kbarber/puppetdb/tags","blobs_url":"https://api.github.com/repos/kbarber/puppetdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kbarber/puppetdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kbarber/puppetdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/kbarber/puppetdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kbarber/puppetdb/statuses/{sha}","languages_url":"https://api.github.com/repos/kbarber/puppetdb/languages","stargazers_url":"https://api.github.com/repos/kbarber/puppetdb/stargazers","contributors_url":"https://api.github.com/repos/kbarber/puppetdb/contributors","subscribers_url":"https://api.github.com/repos/kbarber/puppetdb/subscribers","subscription_url":"https://api.github.com/repos/kbarber/puppetdb/subscription","commits_url":"https://api.github.com/repos/kbarber/puppetdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/kbarber/puppetdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/kbarber/puppetdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/kbarber/puppetdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/kbarber/puppetdb/contents/{+path}","compare_url":"https://api.github.com/repos/kbarber/puppetdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kbarber/puppetdb/merges","archive_url":"https://api.github.com/repos/kbarber/puppetdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kbarber/puppetdb/downloads","issues_url":"https://api.github.com/repos/kbarber/puppetdb/issues{/number}","pulls_url":"https://api.github.com/repos/kbarber/puppetdb/pulls{/number}","milestones_url":"https://api.github.com/repos/kbarber/puppetdb/milestones{/number}","notifications_url":"https://api.github.com/repos/kbarber/puppetdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kbarber/puppetdb/labels{/name}","releases_url":"https://api.github.com/repos/kbarber/puppetdb/releases{/id}","created_at":"2012-05-25T12:17:05Z","updated_at":"2015-05-05T11:09:30Z","pushed_at":"2015-09-17T12:32:46Z","git_url":"git://github.com/kbarber/puppetdb.git","ssh_url":"git@github.com:kbarber/puppetdb.git","clone_url":"https://github.com/kbarber/puppetdb.git","svn_url":"https://github.com/kbarber/puppetdb","homepage":"http://docs.puppetlabs.com/puppetdb","size":18379,"stargazers_count":1,"watchers_count":1,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"030a3fca92e5af811c13c2b4e447c74569f68033","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":2193032,"name":"puppetdb","full_name":"puppetlabs/puppetdb","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetdb","description":"Centralized Puppet Storage","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetdb","forks_url":"https://api.github.com/repos/puppetlabs/puppetdb/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetdb/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetdb/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetdb/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetdb/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetdb/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetdb/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetdb/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetdb/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetdb/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetdb/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetdb/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetdb/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetdb/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetdb/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetdb/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetdb/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetdb/releases{/id}","created_at":"2011-08-11T18:54:46Z","updated_at":"2015-08-30T00:21:01Z","pushed_at":"2015-09-21T15:06:11Z","git_url":"git://github.com/puppetlabs/puppetdb.git","ssh_url":"git@github.com:puppetlabs/puppetdb.git","clone_url":"https://github.com/puppetlabs/puppetdb.git","svn_url":"https://github.com/puppetlabs/puppetdb","homepage":"http://docs.puppetlabs.com/puppetdb","size":23228,"stargazers_count":173,"watchers_count":173,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":135,"mirror_url":null,"open_issues_count":6,"forks":135,"open_issues":6,"watchers":173,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1643"},"html":{"href":"https://github.com/puppetlabs/puppetdb/pull/1643"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1643"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1643/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1643/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1643/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/f5c61598f2ea79285789a7f588fda8bb9c8e2832"}}}}