{"push_id":806342658,"size":1,"distinct_size":1,"ref":"refs/heads/wmf/1.26wmf24","head":"6d7b9963859ac0b698baccd2435b2e246a78ff79","before":"37c6972f9438c6363b4c83baba6215737644cf02","commits":[{"sha":"6d7b9963859ac0b698baccd2435b2e246a78ff79","author":{"email":"6c720b6ece72a4972cc39d6436cb370514e267ec@wikimedia.org","name":"Ori Livneh"},"message":"Tidy up ResourceLoader to make ResourceLoaderEditToolbarModule simpler\n\n* Remove ResourceLoaderFileModule::getLessCompiler(). There is no reason for a\n  module to need to get a compiler in a different manner than\n  ResourceLoader::getLessCompiler().\n* Add ResourceLoaderModule::getLessVars(). This method provides a means for\n  subclasses to easily inject custom LESS variables. The default implementation\n  simply returns an empty array.\n* Make the $context parameter for ResourceLoaderFileModule::readStyleFiles()\n  non-optional (via graceful deprecation). The only callers I found were either\n  already calling it with a ResourceLoader context, or had a perfectly usable\n  ResourceLoaderContext in local scope.\n* Make ResourceLoaderFileModule::{readStyleFile,getLessCompiler} require a\n  context. These methods are protected, so I didn't bother with a deprecation.\n* Call ksort() on the LESS variables array in the only place it matters -- when\n  hashing its serialized representation to construct a cache lookup key. This\n  relieves getLessVars() subclasses from having to remember to re-sort the\n  variables array if they modify it.\n* These changes make it possible to substantially simplify\n  ResourceLoaderEditToolbarModule, because the only thing it needs to do now is\n  implement its own getLessVars() method.\n* This also allows it to be versioned like any other ResourceLoaderFileModule,\n  rather than having to `enableModuleContentVersion()`.\n\nChange-Id: Ic3eab71691e502bfe19bdf4eb6f82cc679a7782f","distinct":true,"url":"https://api.github.com/repos/wikimedia/mediawiki/commits/6d7b9963859ac0b698baccd2435b2e246a78ff79"}]}