{"action":"created","issue":{"url":"https://api.github.com/repos/rockabox/rbx_ui_components/issues/180","labels_url":"https://api.github.com/repos/rockabox/rbx_ui_components/issues/180/labels{/name}","comments_url":"https://api.github.com/repos/rockabox/rbx_ui_components/issues/180/comments","events_url":"https://api.github.com/repos/rockabox/rbx_ui_components/issues/180/events","html_url":"https://github.com/rockabox/rbx_ui_components/pull/180","id":83626768,"number":180,"title":"Use `angular-scroll` for `rb-scrollspy`","user":{"login":"chrisvxd","id":985961,"avatar_url":"https://avatars.githubusercontent.com/u/985961?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisvxd","html_url":"https://github.com/chrisvxd","followers_url":"https://api.github.com/users/chrisvxd/followers","following_url":"https://api.github.com/users/chrisvxd/following{/other_user}","gists_url":"https://api.github.com/users/chrisvxd/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisvxd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisvxd/subscriptions","organizations_url":"https://api.github.com/users/chrisvxd/orgs","repos_url":"https://api.github.com/users/chrisvxd/repos","events_url":"https://api.github.com/users/chrisvxd/events{/privacy}","received_events_url":"https://api.github.com/users/chrisvxd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-01T18:06:37Z","updated_at":"2015-06-01T18:35:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rockabox/rbx_ui_components/pulls/180","html_url":"https://github.com/rockabox/rbx_ui_components/pull/180","diff_url":"https://github.com/rockabox/rbx_ui_components/pull/180.diff","patch_url":"https://github.com/rockabox/rbx_ui_components/pull/180.patch"},"body":"The scrollspy provided by `angular-strap` did not allow for custom elements for scroll observation, and only allowed for observation on `window/document`, making it unusable in modals or overlays.\r\n\r\n- Gutted out angular-strap and replaced with angular-scroll\r\n- Pass in the `id` of the element to observe scrolling via `scroll-id` attr.\r\n- Scroll-spy now animates. Sexy.\r\n- Tests fixed\r\n- Demos fixed\r\n\r\nSee `angular-scroll` here https://github.com/oblador/angular-scroll.\r\n\r\n@ohskylab wasn't sure if I should put the base as `2.0.0` or `master` but feel free to edit it. I would like to see this in the next release!\r\n\r\nTP https://rockabox.tpondemand.com/entity/9618"},"comment":{"url":"https://api.github.com/repos/rockabox/rbx_ui_components/issues/comments/107665694","html_url":"https://github.com/rockabox/rbx_ui_components/pull/180#issuecomment-107665694","issue_url":"https://api.github.com/repos/rockabox/rbx_ui_components/issues/180","id":107665694,"user":{"login":"ohskylab","id":41568,"avatar_url":"https://avatars.githubusercontent.com/u/41568?v=3","gravatar_id":"","url":"https://api.github.com/users/ohskylab","html_url":"https://github.com/ohskylab","followers_url":"https://api.github.com/users/ohskylab/followers","following_url":"https://api.github.com/users/ohskylab/following{/other_user}","gists_url":"https://api.github.com/users/ohskylab/gists{/gist_id}","starred_url":"https://api.github.com/users/ohskylab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ohskylab/subscriptions","organizations_url":"https://api.github.com/users/ohskylab/orgs","repos_url":"https://api.github.com/users/ohskylab/repos","events_url":"https://api.github.com/users/ohskylab/events{/privacy}","received_events_url":"https://api.github.com/users/ohskylab/received_events","type":"User","site_admin":false},"created_at":"2015-06-01T18:35:14Z","updated_at":"2015-06-01T18:35:14Z","body":"@chrisvxd Excellent, fast work! Yes to `2.0.0`, but the base should be `master` so will need to re-do this as a new PR."}}