{"action":"created","comment":{"url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/pulls/comments/34759952","id":34759952,"diff_hunk":"@@ -24,23 +23,15 @@ public NHibernateSubscriptionStorage()\n         /// Called when the feature should perform its initialization. This call will only happen if the feature is enabled.\n         /// </summary>\n         protected override void Setup(FeatureConfigurationContext context)\n-        {            \n-            var configuration = context.Settings.GetOrDefault<Configuration>(\"NHibernate.Subscriptions.Configuration\") ?? context.Settings.GetOrDefault<Configuration>(\"StorageConfiguration\");\n-\n-            if (configuration == null)\n-            {\n-                var properties = new ConfigureNHibernate(context.Settings).SubscriptionStorageProperties;\n-                configuration = new Configuration().SetProperties(properties);\n-            }\n-            ConfigureNHibernate.ThrowIfRequiredPropertiesAreMissing(configuration.Properties);\n-\n-            ConfigureNHibernate.AddMappings<SubscriptionMap>(configuration);\n+        {\n+            var configure = new ConfigureNHibernate(context.Settings, \"Subscription\", \"NHibernate.Subscriptions.Configuration\", \"StorageConfiguration\");\n+            configure.AddMappings<SubscriptionMap>();\n \n             context.Container.ConfigureComponent<Unicast.Subscriptions.NHibernate.Installer.Installer>(DependencyLifecycle.SingleInstance)\n-                .ConfigureProperty(x => x.Configuration, configuration)\n+                .ConfigureProperty(x => x.Configuration, configure.Configuration)","path":"src/NServiceBus.NHibernate/Subscriptions/NHibernateSubscriptionStorage.cs","position":29,"original_position":29,"commit_id":"7d85997d0b38bac3918749090a675791b7e6da2f","original_commit_id":"7d85997d0b38bac3918749090a675791b7e6da2f","user":{"login":"danielmarbach","id":174258,"avatar_url":"https://avatars.githubusercontent.com/u/174258?v=3","gravatar_id":"","url":"https://api.github.com/users/danielmarbach","html_url":"https://github.com/danielmarbach","followers_url":"https://api.github.com/users/danielmarbach/followers","following_url":"https://api.github.com/users/danielmarbach/following{/other_user}","gists_url":"https://api.github.com/users/danielmarbach/gists{/gist_id}","starred_url":"https://api.github.com/users/danielmarbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielmarbach/subscriptions","organizations_url":"https://api.github.com/users/danielmarbach/orgs","repos_url":"https://api.github.com/users/danielmarbach/repos","events_url":"https://api.github.com/users/danielmarbach/events{/privacy}","received_events_url":"https://api.github.com/users/danielmarbach/received_events","type":"User","site_admin":false},"body":"`configure.Configuration` bind it to a local variable?","created_at":"2015-07-16T06:50:20Z","updated_at":"2015-07-16T06:50:20Z","html_url":"https://github.com/Particular/NServiceBus.NHibernate/pull/111#discussion_r34759952","pull_request_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/pulls/111","_links":{"self":{"href":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/pulls/comments/34759952"},"html":{"href":"https://github.com/Particular/NServiceBus.NHibernate/pull/111#discussion_r34759952"},"pull_request":{"href":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/pulls/111"}}},"pull_request":{"url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/pulls/111","id":39986774,"html_url":"https://github.com/Particular/NServiceBus.NHibernate/pull/111","diff_url":"https://github.com/Particular/NServiceBus.NHibernate/pull/111.diff","patch_url":"https://github.com/Particular/NServiceBus.NHibernate/pull/111.patch","issue_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/issues/111","number":111,"state":"open","locked":false,"title":"Refactor config loading","user":{"login":"SzymonPobiega","id":163318,"avatar_url":"https://avatars.githubusercontent.com/u/163318?v=3","gravatar_id":"","url":"https://api.github.com/users/SzymonPobiega","html_url":"https://github.com/SzymonPobiega","followers_url":"https://api.github.com/users/SzymonPobiega/followers","following_url":"https://api.github.com/users/SzymonPobiega/following{/other_user}","gists_url":"https://api.github.com/users/SzymonPobiega/gists{/gist_id}","starred_url":"https://api.github.com/users/SzymonPobiega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SzymonPobiega/subscriptions","organizations_url":"https://api.github.com/users/SzymonPobiega/orgs","repos_url":"https://api.github.com/users/SzymonPobiega/repos","events_url":"https://api.github.com/users/SzymonPobiega/events{/privacy}","received_events_url":"https://api.github.com/users/SzymonPobiega/received_events","type":"User","site_admin":false},"body":"Clean up the code for loading NH configuration in order to prepare for API changes in future","created_at":"2015-07-15T04:13:53Z","updated_at":"2015-07-16T06:50:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b1bf5b05c2d8cce9a90a9e8591be73c065a215f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/pulls/111/commits","review_comments_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/pulls/111/comments","review_comment_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/issues/111/comments","statuses_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/statuses/7d85997d0b38bac3918749090a675791b7e6da2f","head":{"label":"Particular:refactor-config-loading","ref":"refactor-config-loading","sha":"7d85997d0b38bac3918749090a675791b7e6da2f","user":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":14360139,"name":"NServiceBus.NHibernate","full_name":"Particular/NServiceBus.NHibernate","owner":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/NServiceBus.NHibernate","description":"Persistence support for NServiceBus using NHibernate","fork":false,"url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate","forks_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/forks","keys_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/teams","hooks_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/hooks","issue_events_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/events","assignees_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/tags","blobs_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/languages","stargazers_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/stargazers","contributors_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/contributors","subscribers_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/subscribers","subscription_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/subscription","commits_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/merges","archive_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/downloads","issues_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/labels{/name}","releases_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/releases{/id}","created_at":"2013-11-13T09:47:27Z","updated_at":"2015-06-23T14:07:25Z","pushed_at":"2015-07-15T04:13:53Z","git_url":"git://github.com/Particular/NServiceBus.NHibernate.git","ssh_url":"git@github.com:Particular/NServiceBus.NHibernate.git","clone_url":"https://github.com/Particular/NServiceBus.NHibernate.git","svn_url":"https://github.com/Particular/NServiceBus.NHibernate","homepage":"","size":9666,"stargazers_count":4,"watchers_count":4,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":17,"forks":14,"open_issues":17,"watchers":4,"default_branch":"develop"}},"base":{"label":"Particular:develop","ref":"develop","sha":"b5ee66d35fcd5a33480a8ec1475c39940de57b42","user":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":14360139,"name":"NServiceBus.NHibernate","full_name":"Particular/NServiceBus.NHibernate","owner":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/NServiceBus.NHibernate","description":"Persistence support for NServiceBus using NHibernate","fork":false,"url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate","forks_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/forks","keys_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/teams","hooks_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/hooks","issue_events_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/events","assignees_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/tags","blobs_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/languages","stargazers_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/stargazers","contributors_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/contributors","subscribers_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/subscribers","subscription_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/subscription","commits_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/merges","archive_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/downloads","issues_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/labels{/name}","releases_url":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/releases{/id}","created_at":"2013-11-13T09:47:27Z","updated_at":"2015-06-23T14:07:25Z","pushed_at":"2015-07-15T04:13:53Z","git_url":"git://github.com/Particular/NServiceBus.NHibernate.git","ssh_url":"git@github.com:Particular/NServiceBus.NHibernate.git","clone_url":"https://github.com/Particular/NServiceBus.NHibernate.git","svn_url":"https://github.com/Particular/NServiceBus.NHibernate","homepage":"","size":9666,"stargazers_count":4,"watchers_count":4,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":17,"forks":14,"open_issues":17,"watchers":4,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/pulls/111"},"html":{"href":"https://github.com/Particular/NServiceBus.NHibernate/pull/111"},"issue":{"href":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/issues/111"},"comments":{"href":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/issues/111/comments"},"review_comments":{"href":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/pulls/111/comments"},"review_comment":{"href":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/pulls/111/commits"},"statuses":{"href":"https://api.github.com/repos/Particular/NServiceBus.NHibernate/statuses/7d85997d0b38bac3918749090a675791b7e6da2f"}}}}