{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3106","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3106/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3106/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3106/events","html_url":"https://github.com/cockroachdb/cockroach/pull/3106","id":116408022,"number":3106,"title":"Proper r/w operations during the addition or deletion of an index","user":{"login":"vivekmenezes","id":11774212,"avatar_url":"https://avatars.githubusercontent.com/u/11774212?v=3","gravatar_id":"","url":"https://api.github.com/users/vivekmenezes","html_url":"https://github.com/vivekmenezes","followers_url":"https://api.github.com/users/vivekmenezes/followers","following_url":"https://api.github.com/users/vivekmenezes/following{/other_user}","gists_url":"https://api.github.com/users/vivekmenezes/gists{/gist_id}","starred_url":"https://api.github.com/users/vivekmenezes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivekmenezes/subscriptions","organizations_url":"https://api.github.com/users/vivekmenezes/orgs","repos_url":"https://api.github.com/users/vivekmenezes/repos","events_url":"https://api.github.com/users/vivekmenezes/events{/privacy}","received_events_url":"https://api.github.com/users/vivekmenezes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-11-11T19:48:07Z","updated_at":"2015-11-16T21:25:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/3106","html_url":"https://github.com/cockroachdb/cockroach/pull/3106","diff_url":"https://github.com/cockroachdb/cockroach/pull/3106.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/3106.patch"},"body":"\r\nhttps://github.com/cockroachdb/cockroach/issues/2845\r\n\r\n<!-- Reviewable:start -->\r\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/3106)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/157175480","html_url":"https://github.com/cockroachdb/cockroach/pull/3106#issuecomment-157175480","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3106","id":157175480,"user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"created_at":"2015-11-16T21:25:30Z","updated_at":"2015-11-16T21:25:30Z","body":"\n\n\n\nReview status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion.\n\n---\n\n<sup>**[sql/update.go, line 200 \\[r1\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/3106#-K3GyyAJe2sxUCJzSUec)** ([raw file](https://github.com/cockroachdb/cockroach/blob/3ac1fdb6be843b99e442035a758f4aaa5d2b71fb/sql/update.go#L200)):</sup>\nI don't follow. Not touching indexes unless they've changed would be more efficient, and the added complexity is effectively nothing (slight rearrangement in the iteration over `tableDesc.Mutations`\n<!-- Reviewable comment -K3HAlU1oUslS1Lpw7LD:-841313556 -->\n\n---\n\n\nComments from the [review on Reviewable.io](https://reviewable.io:443/reviews/cockroachdb/cockroach/3106)\n<!-- Sent from Reviewable.io -->\n"}}