{"action":"created","issue":{"url":"https://api.github.com/repos/PowerShell/xNetworking/issues/29","labels_url":"https://api.github.com/repos/PowerShell/xNetworking/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/PowerShell/xNetworking/issues/29/comments","events_url":"https://api.github.com/repos/PowerShell/xNetworking/issues/29/events","html_url":"https://github.com/PowerShell/xNetworking/pull/29","id":108771387,"number":29,"title":"Rearchitect xIPAddress, xDNSServerAddress and xDefaultGatewayAddress","user":{"login":"PlagueHO","id":7589164,"avatar_url":"https://avatars.githubusercontent.com/u/7589164?v=3","gravatar_id":"","url":"https://api.github.com/users/PlagueHO","html_url":"https://github.com/PlagueHO","followers_url":"https://api.github.com/users/PlagueHO/followers","following_url":"https://api.github.com/users/PlagueHO/following{/other_user}","gists_url":"https://api.github.com/users/PlagueHO/gists{/gist_id}","starred_url":"https://api.github.com/users/PlagueHO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PlagueHO/subscriptions","organizations_url":"https://api.github.com/users/PlagueHO/orgs","repos_url":"https://api.github.com/users/PlagueHO/repos","events_url":"https://api.github.com/users/PlagueHO/events{/privacy}","received_events_url":"https://api.github.com/users/PlagueHO/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/PowerShell/xNetworking/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-09-29T00:16:21Z","updated_at":"2015-10-02T04:38:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PowerShell/xNetworking/pulls/29","html_url":"https://github.com/PowerShell/xNetworking/pull/29","diff_url":"https://github.com/PowerShell/xNetworking/pull/29.diff","patch_url":"https://github.com/PowerShell/xNetworking/pull/29.patch"},"body":"The resources were modified in the following ways:\r\n1. Test-Properties function removed and logic moved into Test-TargetResource and/or Set-TargetResource so that code to test state is not called twice. As per recommendation from @tysonjhayes in #22.\r\n2. Parameter test logic removed into Test-ResourceProperties function with additional checking for IPv6 parameters.\r\n3. Additional Pester tests added to each resource - including some IPv6 specific tests.\r\n4. \"Lightbulb\" changes suggested by ISESteroids interface.\r\n5. Attempt to mimic code style of new xFirewall resource.\r\nCode reviews gratefully accepted :)\r\n"},"comment":{"url":"https://api.github.com/repos/PowerShell/xNetworking/issues/comments/144915920","html_url":"https://github.com/PowerShell/xNetworking/pull/29#issuecomment-144915920","issue_url":"https://api.github.com/repos/PowerShell/xNetworking/issues/29","id":144915920,"user":{"login":"tysonjhayes","id":651851,"avatar_url":"https://avatars.githubusercontent.com/u/651851?v=3","gravatar_id":"","url":"https://api.github.com/users/tysonjhayes","html_url":"https://github.com/tysonjhayes","followers_url":"https://api.github.com/users/tysonjhayes/followers","following_url":"https://api.github.com/users/tysonjhayes/following{/other_user}","gists_url":"https://api.github.com/users/tysonjhayes/gists{/gist_id}","starred_url":"https://api.github.com/users/tysonjhayes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tysonjhayes/subscriptions","organizations_url":"https://api.github.com/users/tysonjhayes/orgs","repos_url":"https://api.github.com/users/tysonjhayes/repos","events_url":"https://api.github.com/users/tysonjhayes/events{/privacy}","received_events_url":"https://api.github.com/users/tysonjhayes/received_events","type":"User","site_admin":false},"created_at":"2015-10-02T04:38:03Z","updated_at":"2015-10-02T04:38:03Z","body":"Forgive me as I'm going over Gateway with a fine tooth comb, currently this only returns Address if it finds a value, given null is an acceptable value of a Default Gateway (in this case it would be no gateway defined) wouldn't it make sense to return null as the value in Get-TargetResource? Just a thought. :+1: "}}