{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/25841708","id":25841708,"diff_hunk":"@@ -565,6 +565,12 @@ type Service struct {\n \tSessionAffinity AffinityType `json:\"sessionAffinity,omitempty\" description:\"enable client IP based session affinity; must be ClientIP or None; defaults to None\"`\n }\n \n+// EndpointObjectReference is a reference to an object exposing the endpoint\n+type EndpointObjectReference struct {\n+\tEndpoint string `json:\"endpoint\" description:\"endpoint exposed by the referenced object\"`\n+\tObjectReference","path":"pkg/api/v1beta2/types.go","position":7,"original_position":7,"commit_id":"1bba8bf62fcf1cc2db76567686daf9a142a07336","original_commit_id":"1bba8bf62fcf1cc2db76567686daf9a142a07336","user":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"body":"Needs json tag and description.","created_at":"2015-03-05T06:18:49Z","updated_at":"2015-03-05T06:18:49Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/4482#discussion_r25841708","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/4482","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/25841708"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/4482#discussion_r25841708"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/4482"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/4482","id":29441950,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/4482","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/4482.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/4482.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/4482","number":4482,"state":"open","locked":false,"title":"api: return endpoints pod identifiers","user":{"login":"simon3z","id":130393,"avatar_url":"https://avatars.githubusercontent.com/u/130393?v=3","gravatar_id":"","url":"https://api.github.com/users/simon3z","html_url":"https://github.com/simon3z","followers_url":"https://api.github.com/users/simon3z/followers","following_url":"https://api.github.com/users/simon3z/following{/other_user}","gists_url":"https://api.github.com/users/simon3z/gists{/gist_id}","starred_url":"https://api.github.com/users/simon3z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simon3z/subscriptions","organizations_url":"https://api.github.com/users/simon3z/orgs","repos_url":"https://api.github.com/users/simon3z/repos","events_url":"https://api.github.com/users/simon3z/events{/privacy}","received_events_url":"https://api.github.com/users/simon3z/received_events","type":"User","site_admin":false},"body":"This patch is work in progress and proposed as proof of concept. The idea is to connect more reliably endpoints to pods (and maybe nodes as well).\r\n\r\nExample of the proposed api:\r\n\r\n    {\r\n      \"metadata\": {\r\n        \"name\": \"example\",\r\n        ...\r\n      },\r\n      \"endpoints\": [\r\n        {\r\n          \"podID\": \"php1\",\r\n          \"endpointIP\": \"172.17.0.61:80\"\r\n        },\r\n        {\r\n          \"podID\": \"php2\",\r\n          \"endpointIP\": \"172.17.0.62:80\"\r\n        }\r\n      ]\r\n    },\r\n    ...\r\n    {\r\n      \"metadata\": {\r\n        \"name\": \"kubernetes\",\r\n        ...\r\n      },\r\n      \"endpoints\": [\r\n        {\r\n          \"endpointIP\": \"192.168.122.4:6443\"\r\n        }\r\n      ]\r\n    },\r\n\r\nNames (especially EndpointIP) and structures are open for debate. If generally accepted I'll polish the patch (comments, descriptions, names, checks, refactoring, etc.).","created_at":"2015-02-17T13:34:00Z","updated_at":"2015-03-05T06:18:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76a2d2832f63ce0621c7c41666d146280b1fdfa4","assignee":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/4482/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/4482/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/4482/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/1bba8bf62fcf1cc2db76567686daf9a142a07336","head":{"label":"simon3z:endpoints-podid","ref":"endpoints-podid","sha":"1bba8bf62fcf1cc2db76567686daf9a142a07336","user":{"login":"simon3z","id":130393,"avatar_url":"https://avatars.githubusercontent.com/u/130393?v=3","gravatar_id":"","url":"https://api.github.com/users/simon3z","html_url":"https://github.com/simon3z","followers_url":"https://api.github.com/users/simon3z/followers","following_url":"https://api.github.com/users/simon3z/following{/other_user}","gists_url":"https://api.github.com/users/simon3z/gists{/gist_id}","starred_url":"https://api.github.com/users/simon3z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simon3z/subscriptions","organizations_url":"https://api.github.com/users/simon3z/orgs","repos_url":"https://api.github.com/users/simon3z/repos","events_url":"https://api.github.com/users/simon3z/events{/privacy}","received_events_url":"https://api.github.com/users/simon3z/received_events","type":"User","site_admin":false},"repo":{"id":23426377,"name":"kubernetes","full_name":"simon3z/kubernetes","owner":{"login":"simon3z","id":130393,"avatar_url":"https://avatars.githubusercontent.com/u/130393?v=3","gravatar_id":"","url":"https://api.github.com/users/simon3z","html_url":"https://github.com/simon3z","followers_url":"https://api.github.com/users/simon3z/followers","following_url":"https://api.github.com/users/simon3z/following{/other_user}","gists_url":"https://api.github.com/users/simon3z/gists{/gist_id}","starred_url":"https://api.github.com/users/simon3z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simon3z/subscriptions","organizations_url":"https://api.github.com/users/simon3z/orgs","repos_url":"https://api.github.com/users/simon3z/repos","events_url":"https://api.github.com/users/simon3z/events{/privacy}","received_events_url":"https://api.github.com/users/simon3z/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/simon3z/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/simon3z/kubernetes","forks_url":"https://api.github.com/repos/simon3z/kubernetes/forks","keys_url":"https://api.github.com/repos/simon3z/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simon3z/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simon3z/kubernetes/teams","hooks_url":"https://api.github.com/repos/simon3z/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/simon3z/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/simon3z/kubernetes/events","assignees_url":"https://api.github.com/repos/simon3z/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/simon3z/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/simon3z/kubernetes/tags","blobs_url":"https://api.github.com/repos/simon3z/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simon3z/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simon3z/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/simon3z/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simon3z/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/simon3z/kubernetes/languages","stargazers_url":"https://api.github.com/repos/simon3z/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/simon3z/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/simon3z/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/simon3z/kubernetes/subscription","commits_url":"https://api.github.com/repos/simon3z/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/simon3z/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/simon3z/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/simon3z/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/simon3z/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/simon3z/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simon3z/kubernetes/merges","archive_url":"https://api.github.com/repos/simon3z/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simon3z/kubernetes/downloads","issues_url":"https://api.github.com/repos/simon3z/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/simon3z/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/simon3z/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/simon3z/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simon3z/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/simon3z/kubernetes/releases{/id}","created_at":"2014-08-28T12:05:55Z","updated_at":"2015-02-11T22:47:51Z","pushed_at":"2015-03-04T16:55:10Z","git_url":"git://github.com/simon3z/kubernetes.git","ssh_url":"git@github.com:simon3z/kubernetes.git","clone_url":"https://github.com/simon3z/kubernetes.git","svn_url":"https://github.com/simon3z/kubernetes","homepage":null,"size":31522,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"6c5b390160856cd8334043344ef6e08568b0a5c9","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-03-05T06:05:52Z","pushed_at":"2015-03-05T05:37:15Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":"http://kubernetes.io","size":91970,"stargazers_count":6443,"watchers_count":6443,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1148,"mirror_url":null,"open_issues_count":784,"forks":1148,"open_issues":784,"watchers":6443,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/4482"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/4482"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/4482"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/4482/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/4482/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/4482/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/1bba8bf62fcf1cc2db76567686daf9a142a07336"}}}}