{"action":"created","issue":{"url":"https://api.github.com/repos/axsh/wakame-vdc/issues/644","labels_url":"https://api.github.com/repos/axsh/wakame-vdc/issues/644/labels{/name}","comments_url":"https://api.github.com/repos/axsh/wakame-vdc/issues/644/comments","events_url":"https://api.github.com/repos/axsh/wakame-vdc/issues/644/events","html_url":"https://github.com/axsh/wakame-vdc/pull/644","id":93255866,"number":644,"title":"fix unclosed erb.","user":{"login":"hansode","id":76867,"avatar_url":"https://avatars.githubusercontent.com/u/76867?v=3","gravatar_id":"","url":"https://api.github.com/users/hansode","html_url":"https://github.com/hansode","followers_url":"https://api.github.com/users/hansode/followers","following_url":"https://api.github.com/users/hansode/following{/other_user}","gists_url":"https://api.github.com/users/hansode/gists{/gist_id}","starred_url":"https://api.github.com/users/hansode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hansode/subscriptions","organizations_url":"https://api.github.com/users/hansode/orgs","repos_url":"https://api.github.com/users/hansode/repos","events_url":"https://api.github.com/users/hansode/events{/privacy}","received_events_url":"https://api.github.com/users/hansode/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/axsh/wakame-vdc/labels/Type%20:%20Bug","name":"Type : Bug","color":"fc2929"}],"state":"open","locked":false,"assignee":{"login":"hansode","id":76867,"avatar_url":"https://avatars.githubusercontent.com/u/76867?v=3","gravatar_id":"","url":"https://api.github.com/users/hansode","html_url":"https://github.com/hansode","followers_url":"https://api.github.com/users/hansode/followers","following_url":"https://api.github.com/users/hansode/following{/other_user}","gists_url":"https://api.github.com/users/hansode/gists{/gist_id}","starred_url":"https://api.github.com/users/hansode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hansode/subscriptions","organizations_url":"https://api.github.com/users/hansode/orgs","repos_url":"https://api.github.com/users/hansode/repos","events_url":"https://api.github.com/users/hansode/events{/privacy}","received_events_url":"https://api.github.com/users/hansode/received_events","type":"User","site_admin":false},"milestone":null,"comments":46,"created_at":"2015-07-06T11:27:00Z","updated_at":"2015-07-08T07:55:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/axsh/wakame-vdc/pulls/644","html_url":"https://github.com/axsh/wakame-vdc/pull/644","diff_url":"https://github.com/axsh/wakame-vdc/pull/644.diff","patch_url":"https://github.com/axsh/wakame-vdc/pull/644.patch"},"body":"### Problem\r\n\r\nUnclosed erb.\r\n\r\n### Possible solusion\r\n\r\nAdd `%>`\r\n\r\n### Solution report\r\n\r\n```\r\n$ /opt/axsh/wakame-vdc/dcmgr/bin/vdc-manage network dhcp show nw-glo\r\n/opt/axsh/wakame-vdc/ruby/lib/ruby/2.0.0/erb.rb:849:in `eval': (erb):7: syntax error, unexpected end-of-input, expecting '}' (SyntaxError)\r\n; _erbout.force_encoding(__ENCODING__)\r\n                                      ^\r\n        from /opt/axsh/wakame-vdc/ruby/lib/ruby/2.0.0/erb.rb:849:in `result'\r\n        from /opt/axsh/wakame-vdc/dcmgr/lib/dcmgr/cli/network.rb:833:in `show'\r\n        from /opt/axsh/wakame-vdc/dcmgr/vendor/bundle/ruby/2.0.0/gems/thor-0.18.1/lib/thor/command.rb:27:in `run'\r\n        from /opt/axsh/wakame-vdc/dcmgr/vendor/bundle/ruby/2.0.0/gems/thor-0.18.1/lib/thor/invocation.rb:120:in `invoke_command'\r\n        from /opt/axsh/wakame-vdc/dcmgr/vendor/bundle/ruby/2.0.0/gems/thor-0.18.1/lib/thor.rb:363:in `dispatch'\r\n        from /opt/axsh/wakame-vdc/dcmgr/vendor/bundle/ruby/2.0.0/gems/thor-0.18.1/lib/thor/invocation.rb:109:in `invoke'\r\n        from /opt/axsh/wakame-vdc/dcmgr/vendor/bundle/ruby/2.0.0/gems/thor-0.18.1/lib/thor.rb:232:in `block in subcommand'\r\n        from /opt/axsh/wakame-vdc/dcmgr/vendor/bundle/ruby/2.0.0/gems/thor-0.18.1/lib/thor/command.rb:27:in `run'\r\n        from /opt/axsh/wakame-vdc/dcmgr/vendor/bundle/ruby/2.0.0/gems/thor-0.18.1/lib/thor/invocation.rb:120:in `invoke_command'\r\n        from /opt/axsh/wakame-vdc/dcmgr/vendor/bundle/ruby/2.0.0/gems/thor-0.18.1/lib/thor.rb:363:in `dispatch'\r\n        from /opt/axsh/wakame-vdc/dcmgr/vendor/bundle/ruby/2.0.0/gems/thor-0.18.1/lib/thor/invocation.rb:109:in `invoke'\r\n        from /opt/axsh/wakame-vdc/dcmgr/vendor/bundle/ruby/2.0.0/gems/thor-0.18.1/lib/thor.rb:232:in `block in subcommand'\r\n        from /opt/axsh/wakame-vdc/dcmgr/vendor/bundle/ruby/2.0.0/gems/thor-0.18.1/lib/thor/command.rb:27:in `run'\r\n        from /opt/axsh/wakame-vdc/dcmgr/vendor/bundle/ruby/2.0.0/gems/thor-0.18.1/lib/thor/invocation.rb:120:in `invoke_command'\r\n        from /opt/axsh/wakame-vdc/dcmgr/vendor/bundle/ruby/2.0.0/gems/thor-0.18.1/lib/thor.rb:363:in `dispatch'\r\n        from /opt/axsh/wakame-vdc/dcmgr/vendor/bundle/ruby/2.0.0/gems/thor-0.18.1/lib/thor/base.rb:439:in `start'\r\n        from /opt/axsh/wakame-vdc/dcmgr/bin/vdc-manage:171:in `block in <main>'\r\n        from /opt/axsh/wakame-vdc/dcmgr/vendor/bundle/ruby/2.0.0/gems/sequel-3.47.0/lib/sequel/database/transactions.rb:127:in `_transaction'\r\n        from /opt/axsh/wakame-vdc/dcmgr/vendor/bundle/ruby/2.0.0/gems/sequel-3.47.0/lib/sequel/database/transactions.rb:102:in `block in transaction'\r\n        from /opt/axsh/wakame-vdc/dcmgr/vendor/bundle/ruby/2.0.0/gems/sequel-3.47.0/lib/sequel/database/connecting.rb:236:in `block in synchronize'\r\n        from /opt/axsh/wakame-vdc/dcmgr/vendor/bundle/ruby/2.0.0/gems/sequel-3.47.0/lib/sequel/connection_pool/threaded.rb:104:in `hold'\r\n        from /opt/axsh/wakame-vdc/dcmgr/vendor/bundle/ruby/2.0.0/gems/sequel-3.47.0/lib/sequel/database/connecting.rb:236:in `synchronize'\r\n        from /opt/axsh/wakame-vdc/dcmgr/vendor/bundle/ruby/2.0.0/gems/sequel-3.47.0/lib/sequel/database/transactions.rb:95:in `transaction'\r\n        from /opt/axsh/wakame-vdc/dcmgr/bin/vdc-manage:170:in `<main>'\r\n```\r\n\r\n```\r\n$ sudo cp -pi /opt/axsh/wakame-vdc/dcmgr/lib/dcmgr/cli/network.rb /opt/axsh/wakame-vdc/dcmgr/lib/dcmgr/cli/network.rb.0\r\n$ sudo vi /opt/axsh/wakame-vdc/dcmgr/lib/dcmgr/cli/network.rb\r\n```\r\n\r\n```\r\n$ diff -u /opt/axsh/wakame-vdc/dcmgr/lib/dcmgr/cli/network.rb.0 /opt/axsh/wakame-vdc/dcmgr/lib/dcmgr/cli/network.rb\r\n--- /opt/axsh/wakame-vdc/dcmgr/lib/dcmgr/cli/network.rb.0       2015-07-06 20:17:01.997254001 +0900\r\n+++ /opt/axsh/wakame-vdc/dcmgr/lib/dcmgr/cli/network.rb 2015-07-06 20:21:13.993263203 +0900\r\n@@ -836,7 +836,7 @@\r\n Dynamic IP Address Range:\r\n <%- nw.dhcp_range_dataset.each { |r| -%>\r\n   <%= r.range_begin.to_s %> - <%= r.range_end.to_s %>\r\n-<%- }\r\n+<%- } %>\r\n __END\r\n       else\r\n         cond = {}\r\n```\r\n\r\n```\r\n$ /opt/axsh/wakame-vdc/dcmgr/bin/vdc-manage network dhcp show nw-glo\r\nNetwork UUID:\r\n  nw-glo\r\nDynamic IP Address Range:\r\n  192.0.2.53 - 192.0.2.56\r\n\r\n```\r\n\r\n### after fixed\r\n\r\n#### with argument\r\n\r\n```\r\n$ /opt/axsh/wakame-vdc/dcmgr/bin/vdc-manage network dhcp show nw-glo\r\nNetwork UUID:\r\n  nw-glo\r\nDynamic IP Address Range:\r\n  192.0.2.53 - 192.0.2.53\r\n  192.0.2.54 - 192.0.2.54\r\n  192.0.2.55 - 192.0.2.55\r\n  192.0.2.56 - 192.0.2.56\r\n```\r\n\r\n#### without argument\r\n\r\n```\r\n$ /opt/axsh/wakame-vdc/dcmgr/bin/vdc-manage network dhcp show\r\nnw-glo  4\r\nnw-wkm  1\r\nnw-mng  1\r\nnw-pub  1\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/axsh/wakame-vdc/issues/comments/119477605","html_url":"https://github.com/axsh/wakame-vdc/pull/644#issuecomment-119477605","issue_url":"https://api.github.com/repos/axsh/wakame-vdc/issues/644","id":119477605,"user":{"login":"Metallion","id":629110,"avatar_url":"https://avatars.githubusercontent.com/u/629110?v=3","gravatar_id":"","url":"https://api.github.com/users/Metallion","html_url":"https://github.com/Metallion","followers_url":"https://api.github.com/users/Metallion/followers","following_url":"https://api.github.com/users/Metallion/following{/other_user}","gists_url":"https://api.github.com/users/Metallion/gists{/gist_id}","starred_url":"https://api.github.com/users/Metallion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metallion/subscriptions","organizations_url":"https://api.github.com/users/Metallion/orgs","repos_url":"https://api.github.com/users/Metallion/repos","events_url":"https://api.github.com/users/Metallion/events{/privacy}","received_events_url":"https://api.github.com/users/Metallion/received_events","type":"User","site_admin":false},"created_at":"2015-07-08T07:55:06Z","updated_at":"2015-07-08T07:55:06Z","body":"Looks good. :+1:  Will merge once the CI finishes."}}