{"action":"created","issue":{"url":"https://api.github.com/repos/kamailio/kamailio/issues/439","labels_url":"https://api.github.com/repos/kamailio/kamailio/issues/439/labels{/name}","comments_url":"https://api.github.com/repos/kamailio/kamailio/issues/439/comments","events_url":"https://api.github.com/repos/kamailio/kamailio/issues/439/events","html_url":"https://github.com/kamailio/kamailio/pull/439","id":121879303,"number":439,"title":"modules/websocket: ensure linkage to libcrypto","user":{"login":"andrey-utkin","id":15657784,"avatar_url":"https://avatars.githubusercontent.com/u/15657784?v=3","gravatar_id":"","url":"https://api.github.com/users/andrey-utkin","html_url":"https://github.com/andrey-utkin","followers_url":"https://api.github.com/users/andrey-utkin/followers","following_url":"https://api.github.com/users/andrey-utkin/following{/other_user}","gists_url":"https://api.github.com/users/andrey-utkin/gists{/gist_id}","starred_url":"https://api.github.com/users/andrey-utkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrey-utkin/subscriptions","organizations_url":"https://api.github.com/users/andrey-utkin/orgs","repos_url":"https://api.github.com/users/andrey-utkin/repos","events_url":"https://api.github.com/users/andrey-utkin/events{/privacy}","received_events_url":"https://api.github.com/users/andrey-utkin/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-12-12T20:50:08Z","updated_at":"2015-12-15T10:59:00Z","closed_at":"2015-12-14T14:09:23Z","pull_request":{"url":"https://api.github.com/repos/kamailio/kamailio/pulls/439","html_url":"https://github.com/kamailio/kamailio/pull/439","diff_url":"https://github.com/kamailio/kamailio/pull/439.diff","patch_url":"https://github.com/kamailio/kamailio/pull/439.patch"},"body":"Fixes linkage for Ubuntu Wily (15.10).\r\nThe issue manifests itself as \"undefined symbol: SHA1\" error at module loading.\r\n\r\nIn Ubuntu 14 LTS (Trusty), ```pkg-config --libs libssl``` returns ```-lssl -lcrypto```, but in Ubuntu 15.10 (Wily) it returns only ```-lssl```. In the end, websocket.so gets SHA1 symbol (and some more) unresolved.\r\n\r\nFor unclear reason, this change is not needed for tls.so - it gets linked to libcrypto automatically, despite it is linked only with ```-lssl``` flag. Maybe it is something symbol-specific, or something I am completely unaware of.\r\n\r\nSSL_BUILDER stuff in Makefile seems to become even more mostruous with the proposed change. Keep in mind that there is ~5 more modules with identical construction in their Makefiles. Rejection of this patch in favor of cleaner solution is appreciated."},"comment":{"url":"https://api.github.com/repos/kamailio/kamailio/issues/comments/164727934","html_url":"https://github.com/kamailio/kamailio/pull/439#issuecomment-164727934","issue_url":"https://api.github.com/repos/kamailio/kamailio/issues/439","id":164727934,"user":{"login":"andrey-utkin","id":15657784,"avatar_url":"https://avatars.githubusercontent.com/u/15657784?v=3","gravatar_id":"","url":"https://api.github.com/users/andrey-utkin","html_url":"https://github.com/andrey-utkin","followers_url":"https://api.github.com/users/andrey-utkin/followers","following_url":"https://api.github.com/users/andrey-utkin/following{/other_user}","gists_url":"https://api.github.com/users/andrey-utkin/gists{/gist_id}","starred_url":"https://api.github.com/users/andrey-utkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrey-utkin/subscriptions","organizations_url":"https://api.github.com/users/andrey-utkin/orgs","repos_url":"https://api.github.com/users/andrey-utkin/repos","events_url":"https://api.github.com/users/andrey-utkin/events{/privacy}","received_events_url":"https://api.github.com/users/andrey-utkin/received_events","type":"User","site_admin":false},"created_at":"2015-12-15T10:59:00Z","updated_at":"2015-12-15T10:59:00Z","body":"Actually, this line is not required.\r\nIf we assume that libssl is installed, then we can drop it (and its endif) entirely.\r\nIf we don't add such assumption, we can still drop those lines and replace ```echo 'libcrypto'``` with ```echo 'pkg-config libcrypto';```"}}