{"action":"opened","number":162,"pull_request":{"url":"https://api.github.com/repos/rails/web-console/pulls/162","id":44373524,"html_url":"https://github.com/rails/web-console/pull/162","diff_url":"https://github.com/rails/web-console/pull/162.diff","patch_url":"https://github.com/rails/web-console/pull/162.patch","issue_url":"https://api.github.com/repos/rails/web-console/issues/162","number":162,"state":"open","locked":false,"title":"Render the console inside the body tag","user":{"login":"gsamokovarov","id":604618,"avatar_url":"https://avatars.githubusercontent.com/u/604618?v=3","gravatar_id":"","url":"https://api.github.com/users/gsamokovarov","html_url":"https://github.com/gsamokovarov","followers_url":"https://api.github.com/users/gsamokovarov/followers","following_url":"https://api.github.com/users/gsamokovarov/following{/other_user}","gists_url":"https://api.github.com/users/gsamokovarov/gists{/gist_id}","starred_url":"https://api.github.com/users/gsamokovarov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsamokovarov/subscriptions","organizations_url":"https://api.github.com/users/gsamokovarov/orgs","repos_url":"https://api.github.com/users/gsamokovarov/repos","events_url":"https://api.github.com/users/gsamokovarov/events{/privacy}","received_events_url":"https://api.github.com/users/gsamokovarov/received_events","type":"User","site_admin":false},"body":"Before this commit, the console was rendered straight after the closing\r\n</html> tag, which made the page HTML invalid. However, browsers are\r\nused to be molested and they are really good at displaying whatever you\r\nthrow at them, so that wasn't big problem anyway. Still it was something\r\nthat bug me quite a bit. I'm trying to redeem myself here.\r\n\r\nBecause I had to change the newly introduce `WebConsole::Response` class\r\nI had cleaned the workspace a bit:\r\n\r\n* `WebConsole::Response` no longer depends on a logger. The detection\r\n  should be better now, so we don't need to couple the query check in\r\n  it.\r\n\r\n* `WebConsole::Response` does one thing only. It used to check the\r\n  acceptance of a given `Content-Type`. I moved this to the middleware\r\n  class.\r\n\r\n* I have reverted the `WebConsole::WhinyRequest` to keep the logging out\r\n  of the logic in the request class. We no longer need to log in two\r\n  separate classes, so no need to break `Liskov` or introduce logging\r\n  into simple query methods.\r\n\r\n@sh19910711 do you wanna review this?","created_at":"2015-09-07T17:56:26Z","updated_at":"2015-09-07T17:56:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rails/web-console/pulls/162/commits","review_comments_url":"https://api.github.com/repos/rails/web-console/pulls/162/comments","review_comment_url":"https://api.github.com/repos/rails/web-console/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/web-console/issues/162/comments","statuses_url":"https://api.github.com/repos/rails/web-console/statuses/6401a95c56510e57f42d36c8874ccad500c9eaf2","head":{"label":"gsamokovarov:content-inside-of-body","ref":"content-inside-of-body","sha":"6401a95c56510e57f42d36c8874ccad500c9eaf2","user":{"login":"gsamokovarov","id":604618,"avatar_url":"https://avatars.githubusercontent.com/u/604618?v=3","gravatar_id":"","url":"https://api.github.com/users/gsamokovarov","html_url":"https://github.com/gsamokovarov","followers_url":"https://api.github.com/users/gsamokovarov/followers","following_url":"https://api.github.com/users/gsamokovarov/following{/other_user}","gists_url":"https://api.github.com/users/gsamokovarov/gists{/gist_id}","starred_url":"https://api.github.com/users/gsamokovarov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsamokovarov/subscriptions","organizations_url":"https://api.github.com/users/gsamokovarov/orgs","repos_url":"https://api.github.com/users/gsamokovarov/repos","events_url":"https://api.github.com/users/gsamokovarov/events{/privacy}","received_events_url":"https://api.github.com/users/gsamokovarov/received_events","type":"User","site_admin":false},"repo":{"id":10462492,"name":"web-console","full_name":"gsamokovarov/web-console","owner":{"login":"gsamokovarov","id":604618,"avatar_url":"https://avatars.githubusercontent.com/u/604618?v=3","gravatar_id":"","url":"https://api.github.com/users/gsamokovarov","html_url":"https://github.com/gsamokovarov","followers_url":"https://api.github.com/users/gsamokovarov/followers","following_url":"https://api.github.com/users/gsamokovarov/following{/other_user}","gists_url":"https://api.github.com/users/gsamokovarov/gists{/gist_id}","starred_url":"https://api.github.com/users/gsamokovarov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsamokovarov/subscriptions","organizations_url":"https://api.github.com/users/gsamokovarov/orgs","repos_url":"https://api.github.com/users/gsamokovarov/repos","events_url":"https://api.github.com/users/gsamokovarov/events{/privacy}","received_events_url":"https://api.github.com/users/gsamokovarov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gsamokovarov/web-console","description":"MOVED TO https://github.com/rails/web-console","fork":false,"url":"https://api.github.com/repos/gsamokovarov/web-console","forks_url":"https://api.github.com/repos/gsamokovarov/web-console/forks","keys_url":"https://api.github.com/repos/gsamokovarov/web-console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gsamokovarov/web-console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gsamokovarov/web-console/teams","hooks_url":"https://api.github.com/repos/gsamokovarov/web-console/hooks","issue_events_url":"https://api.github.com/repos/gsamokovarov/web-console/issues/events{/number}","events_url":"https://api.github.com/repos/gsamokovarov/web-console/events","assignees_url":"https://api.github.com/repos/gsamokovarov/web-console/assignees{/user}","branches_url":"https://api.github.com/repos/gsamokovarov/web-console/branches{/branch}","tags_url":"https://api.github.com/repos/gsamokovarov/web-console/tags","blobs_url":"https://api.github.com/repos/gsamokovarov/web-console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gsamokovarov/web-console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gsamokovarov/web-console/git/refs{/sha}","trees_url":"https://api.github.com/repos/gsamokovarov/web-console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gsamokovarov/web-console/statuses/{sha}","languages_url":"https://api.github.com/repos/gsamokovarov/web-console/languages","stargazers_url":"https://api.github.com/repos/gsamokovarov/web-console/stargazers","contributors_url":"https://api.github.com/repos/gsamokovarov/web-console/contributors","subscribers_url":"https://api.github.com/repos/gsamokovarov/web-console/subscribers","subscription_url":"https://api.github.com/repos/gsamokovarov/web-console/subscription","commits_url":"https://api.github.com/repos/gsamokovarov/web-console/commits{/sha}","git_commits_url":"https://api.github.com/repos/gsamokovarov/web-console/git/commits{/sha}","comments_url":"https://api.github.com/repos/gsamokovarov/web-console/comments{/number}","issue_comment_url":"https://api.github.com/repos/gsamokovarov/web-console/issues/comments{/number}","contents_url":"https://api.github.com/repos/gsamokovarov/web-console/contents/{+path}","compare_url":"https://api.github.com/repos/gsamokovarov/web-console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gsamokovarov/web-console/merges","archive_url":"https://api.github.com/repos/gsamokovarov/web-console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gsamokovarov/web-console/downloads","issues_url":"https://api.github.com/repos/gsamokovarov/web-console/issues{/number}","pulls_url":"https://api.github.com/repos/gsamokovarov/web-console/pulls{/number}","milestones_url":"https://api.github.com/repos/gsamokovarov/web-console/milestones{/number}","notifications_url":"https://api.github.com/repos/gsamokovarov/web-console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gsamokovarov/web-console/labels{/name}","releases_url":"https://api.github.com/repos/gsamokovarov/web-console/releases{/id}","created_at":"2013-06-03T19:18:56Z","updated_at":"2015-09-05T22:23:36Z","pushed_at":"2015-09-07T17:54:35Z","git_url":"git://github.com/gsamokovarov/web-console.git","ssh_url":"git@github.com:gsamokovarov/web-console.git","clone_url":"https://github.com/gsamokovarov/web-console.git","svn_url":"https://github.com/gsamokovarov/web-console","homepage":"","size":1868,"stargazers_count":25,"watchers_count":25,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":78,"mirror_url":null,"open_issues_count":0,"forks":78,"open_issues":0,"watchers":25,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"b9ce945c860849bd89c3fa278f62ddc6183f53fc","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":12496351,"name":"web-console","full_name":"rails/web-console","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/web-console","description":"Rails Console on the Browser.","fork":true,"url":"https://api.github.com/repos/rails/web-console","forks_url":"https://api.github.com/repos/rails/web-console/forks","keys_url":"https://api.github.com/repos/rails/web-console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/web-console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/web-console/teams","hooks_url":"https://api.github.com/repos/rails/web-console/hooks","issue_events_url":"https://api.github.com/repos/rails/web-console/issues/events{/number}","events_url":"https://api.github.com/repos/rails/web-console/events","assignees_url":"https://api.github.com/repos/rails/web-console/assignees{/user}","branches_url":"https://api.github.com/repos/rails/web-console/branches{/branch}","tags_url":"https://api.github.com/repos/rails/web-console/tags","blobs_url":"https://api.github.com/repos/rails/web-console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/web-console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/web-console/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/web-console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/web-console/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/web-console/languages","stargazers_url":"https://api.github.com/repos/rails/web-console/stargazers","contributors_url":"https://api.github.com/repos/rails/web-console/contributors","subscribers_url":"https://api.github.com/repos/rails/web-console/subscribers","subscription_url":"https://api.github.com/repos/rails/web-console/subscription","commits_url":"https://api.github.com/repos/rails/web-console/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/web-console/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/web-console/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/web-console/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/web-console/contents/{+path}","compare_url":"https://api.github.com/repos/rails/web-console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/web-console/merges","archive_url":"https://api.github.com/repos/rails/web-console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/web-console/downloads","issues_url":"https://api.github.com/repos/rails/web-console/issues{/number}","pulls_url":"https://api.github.com/repos/rails/web-console/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/web-console/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/web-console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/web-console/labels{/name}","releases_url":"https://api.github.com/repos/rails/web-console/releases{/id}","created_at":"2013-08-30T21:57:37Z","updated_at":"2015-09-05T22:23:22Z","pushed_at":"2015-08-18T08:41:13Z","git_url":"git://github.com/rails/web-console.git","ssh_url":"git@github.com:rails/web-console.git","clone_url":"https://github.com/rails/web-console.git","svn_url":"https://github.com/rails/web-console","homepage":"","size":2078,"stargazers_count":843,"watchers_count":843,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":75,"mirror_url":null,"open_issues_count":12,"forks":75,"open_issues":12,"watchers":843,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/web-console/pulls/162"},"html":{"href":"https://github.com/rails/web-console/pull/162"},"issue":{"href":"https://api.github.com/repos/rails/web-console/issues/162"},"comments":{"href":"https://api.github.com/repos/rails/web-console/issues/162/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/web-console/pulls/162/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/web-console/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/web-console/pulls/162/commits"},"statuses":{"href":"https://api.github.com/repos/rails/web-console/statuses/6401a95c56510e57f42d36c8874ccad500c9eaf2"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":119,"deletions":142,"changed_files":10}}