{"action":"created","comment":{"url":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/comments/27023424","id":27023424,"diff_hunk":"@@ -46,9 +46,12 @@ script(type='text/ng-template', id='modals/private-message.html')\n   .modal-header\n     h4=env.t('pmHeading', {name: \"{{profile.profile.name}}\"})\n   .modal-body\n-    textarea.form-control(type='text',rows='5',ui-keydown='{\"meta-enter\":\"sendPrivateMessage(profile._id, _message)\"}',ng-model='_message')\n+    textarea.form-control(type='text',rows='5',ui-keydown='{\"meta-enter\":\"sendPrivateMessage(profile._id, _message)\"}',placeholder=env.t('needsTextPlaceholder'),ng-model='_message')\n   .modal-footer\n-    button.btn.btn-primary(ng-click='sendPrivateMessage(profile._id, _message)')=env.t(\"send\")\n+    //- Due to a quirk in Bootstrap UI, we need to wrap this so the tooltip can\n+    //- appear when disabled.\n+    div(style='display:inline-block',tooltip=\"{{_message ? '' : env.t('needsText')}}\")","path":"website/views/shared/modals/members.jade","position":10,"original_position":10,"commit_id":"d537a7fee4a24dc8b38fbbd58741bfef74ee2472","original_commit_id":"d537a7fee4a24dc8b38fbbd58741bfef74ee2472","user":{"login":"crookedneighbor","id":2916945,"avatar_url":"https://avatars.githubusercontent.com/u/2916945?v=3","gravatar_id":"","url":"https://api.github.com/users/crookedneighbor","html_url":"https://github.com/crookedneighbor","followers_url":"https://api.github.com/users/crookedneighbor/followers","following_url":"https://api.github.com/users/crookedneighbor/following{/other_user}","gists_url":"https://api.github.com/users/crookedneighbor/gists{/gist_id}","starred_url":"https://api.github.com/users/crookedneighbor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crookedneighbor/subscriptions","organizations_url":"https://api.github.com/users/crookedneighbor/orgs","repos_url":"https://api.github.com/users/crookedneighbor/repos","events_url":"https://api.github.com/users/crookedneighbor/events{/privacy}","received_events_url":"https://api.github.com/users/crookedneighbor/received_events","type":"User","site_admin":false},"body":"I'm going to trust you on the need to wrap it. Is there a reason it needs to be `display: inline-block` instead of `inline`? If it can just be inline, you could change it to a span and remove the inline style. If it must be `inline-block`, I'd rather you [use the bootstrap class](http://getbootstrap.com/css/#responsive-utilities-classes) for doing inline styles:\r\n\r\n```\r\n.visible-xs-inline-block(tooltip=\"{{_message ? '' : env.t('needsText')}}\")\r\n```","created_at":"2015-03-24T12:45:16Z","updated_at":"2015-03-24T12:45:16Z","html_url":"https://github.com/HabitRPG/habitrpg/pull/4910#discussion_r27023424","pull_request_url":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/4910","_links":{"self":{"href":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/comments/27023424"},"html":{"href":"https://github.com/HabitRPG/habitrpg/pull/4910#discussion_r27023424"},"pull_request":{"href":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/4910"}}},"pull_request":{"url":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/4910","id":31796234,"html_url":"https://github.com/HabitRPG/habitrpg/pull/4910","diff_url":"https://github.com/HabitRPG/habitrpg/pull/4910.diff","patch_url":"https://github.com/HabitRPG/habitrpg/pull/4910.patch","issue_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/4910","number":4910,"state":"open","locked":false,"title":"Prevent User from Sending Blank PMs","user":{"login":"rdhammond","id":801522,"avatar_url":"https://avatars.githubusercontent.com/u/801522?v=3","gravatar_id":"","url":"https://api.github.com/users/rdhammond","html_url":"https://github.com/rdhammond","followers_url":"https://api.github.com/users/rdhammond/followers","following_url":"https://api.github.com/users/rdhammond/following{/other_user}","gists_url":"https://api.github.com/users/rdhammond/gists{/gist_id}","starred_url":"https://api.github.com/users/rdhammond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdhammond/subscriptions","organizations_url":"https://api.github.com/users/rdhammond/orgs","repos_url":"https://api.github.com/users/rdhammond/repos","events_url":"https://api.github.com/users/rdhammond/events{/privacy}","received_events_url":"https://api.github.com/users/rdhammond/received_events","type":"User","site_admin":false},"body":"Addressing issue #4872. Website will disable \"Send\" button when private message box is empty. In addition, a tooltip will appear on mouseover to make it clear why the button is disabled.\r\n\r\nIn addition, placeholder text will prompt the user to enter a message when the private message text box is empty.","created_at":"2015-03-24T04:16:43Z","updated_at":"2015-03-24T12:45:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14b7341483280977280cdf34081388d08b1fc8d6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/4910/commits","review_comments_url":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/4910/comments","review_comment_url":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/4910/comments","statuses_url":"https://api.github.com/repos/HabitRPG/habitrpg/statuses/d537a7fee4a24dc8b38fbbd58741bfef74ee2472","head":{"label":"rdhammond:CancelSendOnBlankPM","ref":"CancelSendOnBlankPM","sha":"d537a7fee4a24dc8b38fbbd58741bfef74ee2472","user":{"login":"rdhammond","id":801522,"avatar_url":"https://avatars.githubusercontent.com/u/801522?v=3","gravatar_id":"","url":"https://api.github.com/users/rdhammond","html_url":"https://github.com/rdhammond","followers_url":"https://api.github.com/users/rdhammond/followers","following_url":"https://api.github.com/users/rdhammond/following{/other_user}","gists_url":"https://api.github.com/users/rdhammond/gists{/gist_id}","starred_url":"https://api.github.com/users/rdhammond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdhammond/subscriptions","organizations_url":"https://api.github.com/users/rdhammond/orgs","repos_url":"https://api.github.com/users/rdhammond/repos","events_url":"https://api.github.com/users/rdhammond/events{/privacy}","received_events_url":"https://api.github.com/users/rdhammond/received_events","type":"User","site_admin":false},"repo":{"id":32122150,"name":"habitrpg","full_name":"rdhammond/habitrpg","owner":{"login":"rdhammond","id":801522,"avatar_url":"https://avatars.githubusercontent.com/u/801522?v=3","gravatar_id":"","url":"https://api.github.com/users/rdhammond","html_url":"https://github.com/rdhammond","followers_url":"https://api.github.com/users/rdhammond/followers","following_url":"https://api.github.com/users/rdhammond/following{/other_user}","gists_url":"https://api.github.com/users/rdhammond/gists{/gist_id}","starred_url":"https://api.github.com/users/rdhammond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdhammond/subscriptions","organizations_url":"https://api.github.com/users/rdhammond/orgs","repos_url":"https://api.github.com/users/rdhammond/repos","events_url":"https://api.github.com/users/rdhammond/events{/privacy}","received_events_url":"https://api.github.com/users/rdhammond/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rdhammond/habitrpg","description":"A habit tracker app which treats your goals like a Role Playing Game.","fork":true,"url":"https://api.github.com/repos/rdhammond/habitrpg","forks_url":"https://api.github.com/repos/rdhammond/habitrpg/forks","keys_url":"https://api.github.com/repos/rdhammond/habitrpg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rdhammond/habitrpg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rdhammond/habitrpg/teams","hooks_url":"https://api.github.com/repos/rdhammond/habitrpg/hooks","issue_events_url":"https://api.github.com/repos/rdhammond/habitrpg/issues/events{/number}","events_url":"https://api.github.com/repos/rdhammond/habitrpg/events","assignees_url":"https://api.github.com/repos/rdhammond/habitrpg/assignees{/user}","branches_url":"https://api.github.com/repos/rdhammond/habitrpg/branches{/branch}","tags_url":"https://api.github.com/repos/rdhammond/habitrpg/tags","blobs_url":"https://api.github.com/repos/rdhammond/habitrpg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rdhammond/habitrpg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rdhammond/habitrpg/git/refs{/sha}","trees_url":"https://api.github.com/repos/rdhammond/habitrpg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rdhammond/habitrpg/statuses/{sha}","languages_url":"https://api.github.com/repos/rdhammond/habitrpg/languages","stargazers_url":"https://api.github.com/repos/rdhammond/habitrpg/stargazers","contributors_url":"https://api.github.com/repos/rdhammond/habitrpg/contributors","subscribers_url":"https://api.github.com/repos/rdhammond/habitrpg/subscribers","subscription_url":"https://api.github.com/repos/rdhammond/habitrpg/subscription","commits_url":"https://api.github.com/repos/rdhammond/habitrpg/commits{/sha}","git_commits_url":"https://api.github.com/repos/rdhammond/habitrpg/git/commits{/sha}","comments_url":"https://api.github.com/repos/rdhammond/habitrpg/comments{/number}","issue_comment_url":"https://api.github.com/repos/rdhammond/habitrpg/issues/comments{/number}","contents_url":"https://api.github.com/repos/rdhammond/habitrpg/contents/{+path}","compare_url":"https://api.github.com/repos/rdhammond/habitrpg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rdhammond/habitrpg/merges","archive_url":"https://api.github.com/repos/rdhammond/habitrpg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rdhammond/habitrpg/downloads","issues_url":"https://api.github.com/repos/rdhammond/habitrpg/issues{/number}","pulls_url":"https://api.github.com/repos/rdhammond/habitrpg/pulls{/number}","milestones_url":"https://api.github.com/repos/rdhammond/habitrpg/milestones{/number}","notifications_url":"https://api.github.com/repos/rdhammond/habitrpg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rdhammond/habitrpg/labels{/name}","releases_url":"https://api.github.com/repos/rdhammond/habitrpg/releases{/id}","created_at":"2015-03-13T02:42:16Z","updated_at":"2015-03-22T02:39:22Z","pushed_at":"2015-03-24T04:12:58Z","git_url":"git://github.com/rdhammond/habitrpg.git","ssh_url":"git@github.com:rdhammond/habitrpg.git","clone_url":"https://github.com/rdhammond/habitrpg.git","svn_url":"https://github.com/rdhammond/habitrpg","homepage":"habitrpg.com","size":153215,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"HabitRPG:develop","ref":"develop","sha":"98220ed0e51344de157a6f23985e42711f0e20b8","user":{"login":"HabitRPG","id":3834775,"avatar_url":"https://avatars.githubusercontent.com/u/3834775?v=3","gravatar_id":"","url":"https://api.github.com/users/HabitRPG","html_url":"https://github.com/HabitRPG","followers_url":"https://api.github.com/users/HabitRPG/followers","following_url":"https://api.github.com/users/HabitRPG/following{/other_user}","gists_url":"https://api.github.com/users/HabitRPG/gists{/gist_id}","starred_url":"https://api.github.com/users/HabitRPG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HabitRPG/subscriptions","organizations_url":"https://api.github.com/users/HabitRPG/orgs","repos_url":"https://api.github.com/users/HabitRPG/repos","events_url":"https://api.github.com/users/HabitRPG/events{/privacy}","received_events_url":"https://api.github.com/users/HabitRPG/received_events","type":"Organization","site_admin":false},"repo":{"id":4578898,"name":"habitrpg","full_name":"HabitRPG/habitrpg","owner":{"login":"HabitRPG","id":3834775,"avatar_url":"https://avatars.githubusercontent.com/u/3834775?v=3","gravatar_id":"","url":"https://api.github.com/users/HabitRPG","html_url":"https://github.com/HabitRPG","followers_url":"https://api.github.com/users/HabitRPG/followers","following_url":"https://api.github.com/users/HabitRPG/following{/other_user}","gists_url":"https://api.github.com/users/HabitRPG/gists{/gist_id}","starred_url":"https://api.github.com/users/HabitRPG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HabitRPG/subscriptions","organizations_url":"https://api.github.com/users/HabitRPG/orgs","repos_url":"https://api.github.com/users/HabitRPG/repos","events_url":"https://api.github.com/users/HabitRPG/events{/privacy}","received_events_url":"https://api.github.com/users/HabitRPG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HabitRPG/habitrpg","description":"A habit tracker app which treats your goals like a Role Playing Game.","fork":false,"url":"https://api.github.com/repos/HabitRPG/habitrpg","forks_url":"https://api.github.com/repos/HabitRPG/habitrpg/forks","keys_url":"https://api.github.com/repos/HabitRPG/habitrpg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HabitRPG/habitrpg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HabitRPG/habitrpg/teams","hooks_url":"https://api.github.com/repos/HabitRPG/habitrpg/hooks","issue_events_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/events{/number}","events_url":"https://api.github.com/repos/HabitRPG/habitrpg/events","assignees_url":"https://api.github.com/repos/HabitRPG/habitrpg/assignees{/user}","branches_url":"https://api.github.com/repos/HabitRPG/habitrpg/branches{/branch}","tags_url":"https://api.github.com/repos/HabitRPG/habitrpg/tags","blobs_url":"https://api.github.com/repos/HabitRPG/habitrpg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HabitRPG/habitrpg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HabitRPG/habitrpg/git/refs{/sha}","trees_url":"https://api.github.com/repos/HabitRPG/habitrpg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HabitRPG/habitrpg/statuses/{sha}","languages_url":"https://api.github.com/repos/HabitRPG/habitrpg/languages","stargazers_url":"https://api.github.com/repos/HabitRPG/habitrpg/stargazers","contributors_url":"https://api.github.com/repos/HabitRPG/habitrpg/contributors","subscribers_url":"https://api.github.com/repos/HabitRPG/habitrpg/subscribers","subscription_url":"https://api.github.com/repos/HabitRPG/habitrpg/subscription","commits_url":"https://api.github.com/repos/HabitRPG/habitrpg/commits{/sha}","git_commits_url":"https://api.github.com/repos/HabitRPG/habitrpg/git/commits{/sha}","comments_url":"https://api.github.com/repos/HabitRPG/habitrpg/comments{/number}","issue_comment_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/comments{/number}","contents_url":"https://api.github.com/repos/HabitRPG/habitrpg/contents/{+path}","compare_url":"https://api.github.com/repos/HabitRPG/habitrpg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HabitRPG/habitrpg/merges","archive_url":"https://api.github.com/repos/HabitRPG/habitrpg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HabitRPG/habitrpg/downloads","issues_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues{/number}","pulls_url":"https://api.github.com/repos/HabitRPG/habitrpg/pulls{/number}","milestones_url":"https://api.github.com/repos/HabitRPG/habitrpg/milestones{/number}","notifications_url":"https://api.github.com/repos/HabitRPG/habitrpg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HabitRPG/habitrpg/labels{/name}","releases_url":"https://api.github.com/repos/HabitRPG/habitrpg/releases{/id}","created_at":"2012-06-06T22:49:48Z","updated_at":"2015-03-24T06:24:29Z","pushed_at":"2015-03-24T04:16:43Z","git_url":"git://github.com/HabitRPG/habitrpg.git","ssh_url":"git@github.com:HabitRPG/habitrpg.git","clone_url":"https://github.com/HabitRPG/habitrpg.git","svn_url":"https://github.com/HabitRPG/habitrpg","homepage":"habitrpg.com","size":177084,"stargazers_count":2618,"watchers_count":2618,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1005,"mirror_url":null,"open_issues_count":684,"forks":1005,"open_issues":684,"watchers":2618,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/4910"},"html":{"href":"https://github.com/HabitRPG/habitrpg/pull/4910"},"issue":{"href":"https://api.github.com/repos/HabitRPG/habitrpg/issues/4910"},"comments":{"href":"https://api.github.com/repos/HabitRPG/habitrpg/issues/4910/comments"},"review_comments":{"href":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/4910/comments"},"review_comment":{"href":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/4910/commits"},"statuses":{"href":"https://api.github.com/repos/HabitRPG/habitrpg/statuses/d537a7fee4a24dc8b38fbbd58741bfef74ee2472"}}}}