{"action":"created","comment":{"url":"https://api.github.com/repos/pyca/cryptography/pulls/comments/36046994","id":36046994,"diff_hunk":"@@ -478,6 +480,41 @@ def test_unsupported_ec_keys(self):\n             backend.create_x509_csr(object(), private_key, hashes.SHA1())\n \n \n+class TestOpenSSLSignX509Certificate(object):\n+    def test_requires_certificate_builder(self):\n+        private_key = RSA_KEY_2048.private_key(backend)\n+\n+        with pytest.raises(TypeError):\n+            backend.sign_x509_certificate(object(), private_key, DummyHash())\n+\n+    def test_checks_for_unsupported_extensions(self):\n+        private_key = RSA_KEY_2048.private_key(backend)\n+        builder = x509.CertificateBuilder().subject_name(x509.Name([\n+            x509.NameAttribute(x509.OID_COUNTRY_NAME, u'US'),","path":"tests/hazmat/backends/test_openssl.py","position":30,"original_position":30,"commit_id":"47e9408311768cfdae8199bb2572ad0bcacbbb2b","original_commit_id":"8690effbb812f944ea4d730e73dc60e9d77dae17","user":{"login":"alex","id":772,"avatar_url":"https://avatars.githubusercontent.com/u/772?v=3","gravatar_id":"","url":"https://api.github.com/users/alex","html_url":"https://github.com/alex","followers_url":"https://api.github.com/users/alex/followers","following_url":"https://api.github.com/users/alex/following{/other_user}","gists_url":"https://api.github.com/users/alex/gists{/gist_id}","starred_url":"https://api.github.com/users/alex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex/subscriptions","organizations_url":"https://api.github.com/users/alex/orgs","repos_url":"https://api.github.com/users/alex/repos","events_url":"https://api.github.com/users/alex/events{/privacy}","received_events_url":"https://api.github.com/users/alex/received_events","type":"User","site_admin":false},"body":"This is still the case.","created_at":"2015-08-02T19:56:56Z","updated_at":"2015-08-02T19:56:56Z","html_url":"https://github.com/pyca/cryptography/pull/2098#discussion_r36046994","pull_request_url":"https://api.github.com/repos/pyca/cryptography/pulls/2098","_links":{"self":{"href":"https://api.github.com/repos/pyca/cryptography/pulls/comments/36046994"},"html":{"href":"https://github.com/pyca/cryptography/pull/2098#discussion_r36046994"},"pull_request":{"href":"https://api.github.com/repos/pyca/cryptography/pulls/2098"}}},"pull_request":{"url":"https://api.github.com/repos/pyca/cryptography/pulls/2098","id":39043415,"html_url":"https://github.com/pyca/cryptography/pull/2098","diff_url":"https://github.com/pyca/cryptography/pull/2098.diff","patch_url":"https://github.com/pyca/cryptography/pull/2098.patch","issue_url":"https://api.github.com/repos/pyca/cryptography/issues/2098","number":2098,"state":"open","locked":false,"title":"Adds certificate builder.","user":{"login":"sigmavirus24","id":240830,"avatar_url":"https://avatars.githubusercontent.com/u/240830?v=3","gravatar_id":"","url":"https://api.github.com/users/sigmavirus24","html_url":"https://github.com/sigmavirus24","followers_url":"https://api.github.com/users/sigmavirus24/followers","following_url":"https://api.github.com/users/sigmavirus24/following{/other_user}","gists_url":"https://api.github.com/users/sigmavirus24/gists{/gist_id}","starred_url":"https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sigmavirus24/subscriptions","organizations_url":"https://api.github.com/users/sigmavirus24/orgs","repos_url":"https://api.github.com/users/sigmavirus24/repos","events_url":"https://api.github.com/users/sigmavirus24/events{/privacy}","received_events_url":"https://api.github.com/users/sigmavirus24/received_events","type":"User","site_admin":false},"body":"This is a rebased version of #1980 and will be used to finish up the work in that PR.","created_at":"2015-07-02T02:33:02Z","updated_at":"2015-08-02T19:56:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f70a64d2f503140757f678349274e35260847274","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pyca/cryptography/pulls/2098/commits","review_comments_url":"https://api.github.com/repos/pyca/cryptography/pulls/2098/comments","review_comment_url":"https://api.github.com/repos/pyca/cryptography/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pyca/cryptography/issues/2098/comments","statuses_url":"https://api.github.com/repos/pyca/cryptography/statuses/47e9408311768cfdae8199bb2572ad0bcacbbb2b","head":{"label":"sigmavirus24:cert-builder","ref":"cert-builder","sha":"47e9408311768cfdae8199bb2572ad0bcacbbb2b","user":{"login":"sigmavirus24","id":240830,"avatar_url":"https://avatars.githubusercontent.com/u/240830?v=3","gravatar_id":"","url":"https://api.github.com/users/sigmavirus24","html_url":"https://github.com/sigmavirus24","followers_url":"https://api.github.com/users/sigmavirus24/followers","following_url":"https://api.github.com/users/sigmavirus24/following{/other_user}","gists_url":"https://api.github.com/users/sigmavirus24/gists{/gist_id}","starred_url":"https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sigmavirus24/subscriptions","organizations_url":"https://api.github.com/users/sigmavirus24/orgs","repos_url":"https://api.github.com/users/sigmavirus24/repos","events_url":"https://api.github.com/users/sigmavirus24/events{/privacy}","received_events_url":"https://api.github.com/users/sigmavirus24/received_events","type":"User","site_admin":false},"repo":{"id":37558857,"name":"cryptography","full_name":"sigmavirus24/cryptography","owner":{"login":"sigmavirus24","id":240830,"avatar_url":"https://avatars.githubusercontent.com/u/240830?v=3","gravatar_id":"","url":"https://api.github.com/users/sigmavirus24","html_url":"https://github.com/sigmavirus24","followers_url":"https://api.github.com/users/sigmavirus24/followers","following_url":"https://api.github.com/users/sigmavirus24/following{/other_user}","gists_url":"https://api.github.com/users/sigmavirus24/gists{/gist_id}","starred_url":"https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sigmavirus24/subscriptions","organizations_url":"https://api.github.com/users/sigmavirus24/orgs","repos_url":"https://api.github.com/users/sigmavirus24/repos","events_url":"https://api.github.com/users/sigmavirus24/events{/privacy}","received_events_url":"https://api.github.com/users/sigmavirus24/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sigmavirus24/cryptography","description":"cryptography is a package designed to expose cryptographic primitives and recipes to Python developers.","fork":true,"url":"https://api.github.com/repos/sigmavirus24/cryptography","forks_url":"https://api.github.com/repos/sigmavirus24/cryptography/forks","keys_url":"https://api.github.com/repos/sigmavirus24/cryptography/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sigmavirus24/cryptography/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sigmavirus24/cryptography/teams","hooks_url":"https://api.github.com/repos/sigmavirus24/cryptography/hooks","issue_events_url":"https://api.github.com/repos/sigmavirus24/cryptography/issues/events{/number}","events_url":"https://api.github.com/repos/sigmavirus24/cryptography/events","assignees_url":"https://api.github.com/repos/sigmavirus24/cryptography/assignees{/user}","branches_url":"https://api.github.com/repos/sigmavirus24/cryptography/branches{/branch}","tags_url":"https://api.github.com/repos/sigmavirus24/cryptography/tags","blobs_url":"https://api.github.com/repos/sigmavirus24/cryptography/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sigmavirus24/cryptography/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sigmavirus24/cryptography/git/refs{/sha}","trees_url":"https://api.github.com/repos/sigmavirus24/cryptography/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sigmavirus24/cryptography/statuses/{sha}","languages_url":"https://api.github.com/repos/sigmavirus24/cryptography/languages","stargazers_url":"https://api.github.com/repos/sigmavirus24/cryptography/stargazers","contributors_url":"https://api.github.com/repos/sigmavirus24/cryptography/contributors","subscribers_url":"https://api.github.com/repos/sigmavirus24/cryptography/subscribers","subscription_url":"https://api.github.com/repos/sigmavirus24/cryptography/subscription","commits_url":"https://api.github.com/repos/sigmavirus24/cryptography/commits{/sha}","git_commits_url":"https://api.github.com/repos/sigmavirus24/cryptography/git/commits{/sha}","comments_url":"https://api.github.com/repos/sigmavirus24/cryptography/comments{/number}","issue_comment_url":"https://api.github.com/repos/sigmavirus24/cryptography/issues/comments{/number}","contents_url":"https://api.github.com/repos/sigmavirus24/cryptography/contents/{+path}","compare_url":"https://api.github.com/repos/sigmavirus24/cryptography/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sigmavirus24/cryptography/merges","archive_url":"https://api.github.com/repos/sigmavirus24/cryptography/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sigmavirus24/cryptography/downloads","issues_url":"https://api.github.com/repos/sigmavirus24/cryptography/issues{/number}","pulls_url":"https://api.github.com/repos/sigmavirus24/cryptography/pulls{/number}","milestones_url":"https://api.github.com/repos/sigmavirus24/cryptography/milestones{/number}","notifications_url":"https://api.github.com/repos/sigmavirus24/cryptography/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sigmavirus24/cryptography/labels{/name}","releases_url":"https://api.github.com/repos/sigmavirus24/cryptography/releases{/id}","created_at":"2015-06-16T22:13:47Z","updated_at":"2015-06-16T22:13:54Z","pushed_at":"2015-08-02T19:00:40Z","git_url":"git://github.com/sigmavirus24/cryptography.git","ssh_url":"git@github.com:sigmavirus24/cryptography.git","clone_url":"https://github.com/sigmavirus24/cryptography.git","svn_url":"https://github.com/sigmavirus24/cryptography","homepage":"https://cryptography.io/","size":30612,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pyca:master","ref":"master","sha":"93b5e3efab0337c51c84c27208d9034b607f09e2","user":{"login":"pyca","id":5615737,"avatar_url":"https://avatars.githubusercontent.com/u/5615737?v=3","gravatar_id":"","url":"https://api.github.com/users/pyca","html_url":"https://github.com/pyca","followers_url":"https://api.github.com/users/pyca/followers","following_url":"https://api.github.com/users/pyca/following{/other_user}","gists_url":"https://api.github.com/users/pyca/gists{/gist_id}","starred_url":"https://api.github.com/users/pyca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyca/subscriptions","organizations_url":"https://api.github.com/users/pyca/orgs","repos_url":"https://api.github.com/users/pyca/repos","events_url":"https://api.github.com/users/pyca/events{/privacy}","received_events_url":"https://api.github.com/users/pyca/received_events","type":"Organization","site_admin":false},"repo":{"id":11939484,"name":"cryptography","full_name":"pyca/cryptography","owner":{"login":"pyca","id":5615737,"avatar_url":"https://avatars.githubusercontent.com/u/5615737?v=3","gravatar_id":"","url":"https://api.github.com/users/pyca","html_url":"https://github.com/pyca","followers_url":"https://api.github.com/users/pyca/followers","following_url":"https://api.github.com/users/pyca/following{/other_user}","gists_url":"https://api.github.com/users/pyca/gists{/gist_id}","starred_url":"https://api.github.com/users/pyca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyca/subscriptions","organizations_url":"https://api.github.com/users/pyca/orgs","repos_url":"https://api.github.com/users/pyca/repos","events_url":"https://api.github.com/users/pyca/events{/privacy}","received_events_url":"https://api.github.com/users/pyca/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pyca/cryptography","description":"cryptography is a package designed to expose cryptographic primitives and recipes to Python developers.","fork":false,"url":"https://api.github.com/repos/pyca/cryptography","forks_url":"https://api.github.com/repos/pyca/cryptography/forks","keys_url":"https://api.github.com/repos/pyca/cryptography/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pyca/cryptography/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pyca/cryptography/teams","hooks_url":"https://api.github.com/repos/pyca/cryptography/hooks","issue_events_url":"https://api.github.com/repos/pyca/cryptography/issues/events{/number}","events_url":"https://api.github.com/repos/pyca/cryptography/events","assignees_url":"https://api.github.com/repos/pyca/cryptography/assignees{/user}","branches_url":"https://api.github.com/repos/pyca/cryptography/branches{/branch}","tags_url":"https://api.github.com/repos/pyca/cryptography/tags","blobs_url":"https://api.github.com/repos/pyca/cryptography/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pyca/cryptography/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pyca/cryptography/git/refs{/sha}","trees_url":"https://api.github.com/repos/pyca/cryptography/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pyca/cryptography/statuses/{sha}","languages_url":"https://api.github.com/repos/pyca/cryptography/languages","stargazers_url":"https://api.github.com/repos/pyca/cryptography/stargazers","contributors_url":"https://api.github.com/repos/pyca/cryptography/contributors","subscribers_url":"https://api.github.com/repos/pyca/cryptography/subscribers","subscription_url":"https://api.github.com/repos/pyca/cryptography/subscription","commits_url":"https://api.github.com/repos/pyca/cryptography/commits{/sha}","git_commits_url":"https://api.github.com/repos/pyca/cryptography/git/commits{/sha}","comments_url":"https://api.github.com/repos/pyca/cryptography/comments{/number}","issue_comment_url":"https://api.github.com/repos/pyca/cryptography/issues/comments{/number}","contents_url":"https://api.github.com/repos/pyca/cryptography/contents/{+path}","compare_url":"https://api.github.com/repos/pyca/cryptography/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pyca/cryptography/merges","archive_url":"https://api.github.com/repos/pyca/cryptography/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pyca/cryptography/downloads","issues_url":"https://api.github.com/repos/pyca/cryptography/issues{/number}","pulls_url":"https://api.github.com/repos/pyca/cryptography/pulls{/number}","milestones_url":"https://api.github.com/repos/pyca/cryptography/milestones{/number}","notifications_url":"https://api.github.com/repos/pyca/cryptography/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pyca/cryptography/labels{/name}","releases_url":"https://api.github.com/repos/pyca/cryptography/releases{/id}","created_at":"2013-08-07T02:23:38Z","updated_at":"2015-07-29T04:21:39Z","pushed_at":"2015-08-02T19:00:41Z","git_url":"git://github.com/pyca/cryptography.git","ssh_url":"git@github.com:pyca/cryptography.git","clone_url":"https://github.com/pyca/cryptography.git","svn_url":"https://github.com/pyca/cryptography","homepage":"https://cryptography.io/","size":45238,"stargazers_count":739,"watchers_count":739,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":173,"mirror_url":null,"open_issues_count":79,"forks":173,"open_issues":79,"watchers":739,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pyca/cryptography/pulls/2098"},"html":{"href":"https://github.com/pyca/cryptography/pull/2098"},"issue":{"href":"https://api.github.com/repos/pyca/cryptography/issues/2098"},"comments":{"href":"https://api.github.com/repos/pyca/cryptography/issues/2098/comments"},"review_comments":{"href":"https://api.github.com/repos/pyca/cryptography/pulls/2098/comments"},"review_comment":{"href":"https://api.github.com/repos/pyca/cryptography/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pyca/cryptography/pulls/2098/commits"},"statuses":{"href":"https://api.github.com/repos/pyca/cryptography/statuses/47e9408311768cfdae8199bb2572ad0bcacbbb2b"}}}}