{"action":"created","comment":{"url":"https://api.github.com/repos/vispy/vispy/pulls/comments/26024531","id":26024531,"diff_hunk":"@@ -38,6 +37,8 @@\n # Add a 3D axis to keep us oriented\n scene.visuals.XYZAxis(parent=view.scene)\n \n+view.camera = scene.TurntableCamera()","path":"examples/basics/scene/isocurve_for_trisurface.py","position":12,"original_position":12,"commit_id":"77f623136463a9383c7e9bea3538445b6b33e3c3","original_commit_id":"77f623136463a9383c7e9bea3538445b6b33e3c3","user":{"login":"campagnola","id":940580,"avatar_url":"https://avatars.githubusercontent.com/u/940580?v=3","gravatar_id":"","url":"https://api.github.com/users/campagnola","html_url":"https://github.com/campagnola","followers_url":"https://api.github.com/users/campagnola/followers","following_url":"https://api.github.com/users/campagnola/following{/other_user}","gists_url":"https://api.github.com/users/campagnola/gists{/gist_id}","starred_url":"https://api.github.com/users/campagnola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/campagnola/subscriptions","organizations_url":"https://api.github.com/users/campagnola/orgs","repos_url":"https://api.github.com/users/campagnola/repos","events_url":"https://api.github.com/users/campagnola/events{/privacy}","received_events_url":"https://api.github.com/users/campagnola/received_events","type":"User","site_admin":false},"body":"I love the xy/z scaling in this example, but I overlooked it at first because I thought the scene was 2d / flat. Start with elevation=30 or so?","created_at":"2015-03-09T10:10:49Z","updated_at":"2015-03-09T10:10:49Z","html_url":"https://github.com/vispy/vispy/pull/612#discussion_r26024531","pull_request_url":"https://api.github.com/repos/vispy/vispy/pulls/612","_links":{"self":{"href":"https://api.github.com/repos/vispy/vispy/pulls/comments/26024531"},"html":{"href":"https://github.com/vispy/vispy/pull/612#discussion_r26024531"},"pull_request":{"href":"https://api.github.com/repos/vispy/vispy/pulls/612"}}},"pull_request":{"url":"https://api.github.com/repos/vispy/vispy/pulls/612","id":24098398,"html_url":"https://github.com/vispy/vispy/pull/612","diff_url":"https://github.com/vispy/vispy/pull/612.diff","patch_url":"https://github.com/vispy/vispy/pull/612.patch","issue_url":"https://api.github.com/repos/vispy/vispy/issues/612","number":612,"state":"open","locked":false,"title":"WIP: Volume rendering","user":{"login":"almarklein","id":3015475,"avatar_url":"https://avatars.githubusercontent.com/u/3015475?v=3","gravatar_id":"","url":"https://api.github.com/users/almarklein","html_url":"https://github.com/almarklein","followers_url":"https://api.github.com/users/almarklein/followers","following_url":"https://api.github.com/users/almarklein/following{/other_user}","gists_url":"https://api.github.com/users/almarklein/gists{/gist_id}","starred_url":"https://api.github.com/users/almarklein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/almarklein/subscriptions","organizations_url":"https://api.github.com/users/almarklein/orgs","repos_url":"https://api.github.com/users/almarklein/repos","events_url":"https://api.github.com/users/almarklein/events{/privacy}","received_events_url":"https://api.github.com/users/almarklein/received_events","type":"User","site_admin":false},"body":"This PR implements volume rendering. It's basically a port of the technique that I use in Visvis.\r\n\r\n* New Volume visual with two rendering styles (iso and mip). \r\n* Volume example in examples/scene/volume.py Try it, and use the keys to switch cameras etc.\r\n* Refactored cameras a bit in general\r\n* Refactored TurnTableCamera: no more mode and distance. You can just change the fov while getting the same zoom level. Setting fov to 0 means orthographic. Zooming is done by moving camera backward.\r\n* New FlyCamera to fly around your data. \r\n\r\nThis is about ready. There are more things to do, but that can be picked up in another PR. (I added todo items for this in volume.py)\r\n\r\nI wish to do more with the camera's, but we should probably discuss this first. Will make a new issue for this.\r\n\r\ntodo:\r\n\r\n* [x] avoid warning when swithching render styles\r\n* [x] camera's\r\n\r\ncloses issue #725\r\n\r\n\r\n\r\n![volume](https://cloud.githubusercontent.com/assets/1942359/5230818/8495b5ec-772c-11e4-8560-d2ac7f393b22.png)\r\n\r\nCloses #725","created_at":"2014-11-08T07:23:46Z","updated_at":"2015-03-09T10:10:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f328b173853e65f13e9e341ecfa3e45feeabb9c1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/vispy/vispy/pulls/612/commits","review_comments_url":"https://api.github.com/repos/vispy/vispy/pulls/612/comments","review_comment_url":"https://api.github.com/repos/vispy/vispy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vispy/vispy/issues/612/comments","statuses_url":"https://api.github.com/repos/vispy/vispy/statuses/77f623136463a9383c7e9bea3538445b6b33e3c3","head":{"label":"almarklein:volume","ref":"volume","sha":"77f623136463a9383c7e9bea3538445b6b33e3c3","user":{"login":"almarklein","id":3015475,"avatar_url":"https://avatars.githubusercontent.com/u/3015475?v=3","gravatar_id":"","url":"https://api.github.com/users/almarklein","html_url":"https://github.com/almarklein","followers_url":"https://api.github.com/users/almarklein/followers","following_url":"https://api.github.com/users/almarklein/following{/other_user}","gists_url":"https://api.github.com/users/almarklein/gists{/gist_id}","starred_url":"https://api.github.com/users/almarklein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/almarklein/subscriptions","organizations_url":"https://api.github.com/users/almarklein/orgs","repos_url":"https://api.github.com/users/almarklein/repos","events_url":"https://api.github.com/users/almarklein/events{/privacy}","received_events_url":"https://api.github.com/users/almarklein/received_events","type":"User","site_admin":false},"repo":{"id":12317009,"name":"vispy","full_name":"almarklein/vispy","owner":{"login":"almarklein","id":3015475,"avatar_url":"https://avatars.githubusercontent.com/u/3015475?v=3","gravatar_id":"","url":"https://api.github.com/users/almarklein","html_url":"https://github.com/almarklein","followers_url":"https://api.github.com/users/almarklein/followers","following_url":"https://api.github.com/users/almarklein/following{/other_user}","gists_url":"https://api.github.com/users/almarklein/gists{/gist_id}","starred_url":"https://api.github.com/users/almarklein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/almarklein/subscriptions","organizations_url":"https://api.github.com/users/almarklein/orgs","repos_url":"https://api.github.com/users/almarklein/repos","events_url":"https://api.github.com/users/almarklein/events{/privacy}","received_events_url":"https://api.github.com/users/almarklein/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/almarklein/vispy","description":"Main repository for Vispy","fork":true,"url":"https://api.github.com/repos/almarklein/vispy","forks_url":"https://api.github.com/repos/almarklein/vispy/forks","keys_url":"https://api.github.com/repos/almarklein/vispy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/almarklein/vispy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/almarklein/vispy/teams","hooks_url":"https://api.github.com/repos/almarklein/vispy/hooks","issue_events_url":"https://api.github.com/repos/almarklein/vispy/issues/events{/number}","events_url":"https://api.github.com/repos/almarklein/vispy/events","assignees_url":"https://api.github.com/repos/almarklein/vispy/assignees{/user}","branches_url":"https://api.github.com/repos/almarklein/vispy/branches{/branch}","tags_url":"https://api.github.com/repos/almarklein/vispy/tags","blobs_url":"https://api.github.com/repos/almarklein/vispy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/almarklein/vispy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/almarklein/vispy/git/refs{/sha}","trees_url":"https://api.github.com/repos/almarklein/vispy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/almarklein/vispy/statuses/{sha}","languages_url":"https://api.github.com/repos/almarklein/vispy/languages","stargazers_url":"https://api.github.com/repos/almarklein/vispy/stargazers","contributors_url":"https://api.github.com/repos/almarklein/vispy/contributors","subscribers_url":"https://api.github.com/repos/almarklein/vispy/subscribers","subscription_url":"https://api.github.com/repos/almarklein/vispy/subscription","commits_url":"https://api.github.com/repos/almarklein/vispy/commits{/sha}","git_commits_url":"https://api.github.com/repos/almarklein/vispy/git/commits{/sha}","comments_url":"https://api.github.com/repos/almarklein/vispy/comments{/number}","issue_comment_url":"https://api.github.com/repos/almarklein/vispy/issues/comments{/number}","contents_url":"https://api.github.com/repos/almarklein/vispy/contents/{+path}","compare_url":"https://api.github.com/repos/almarklein/vispy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/almarklein/vispy/merges","archive_url":"https://api.github.com/repos/almarklein/vispy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/almarklein/vispy/downloads","issues_url":"https://api.github.com/repos/almarklein/vispy/issues{/number}","pulls_url":"https://api.github.com/repos/almarklein/vispy/pulls{/number}","milestones_url":"https://api.github.com/repos/almarklein/vispy/milestones{/number}","notifications_url":"https://api.github.com/repos/almarklein/vispy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/almarklein/vispy/labels{/name}","releases_url":"https://api.github.com/repos/almarklein/vispy/releases{/id}","created_at":"2013-08-23T07:16:26Z","updated_at":"2015-01-28T09:54:38Z","pushed_at":"2015-02-24T12:28:34Z","git_url":"git://github.com/almarklein/vispy.git","ssh_url":"git@github.com:almarklein/vispy.git","clone_url":"https://github.com/almarklein/vispy.git","svn_url":"https://github.com/almarklein/vispy","homepage":"","size":8046,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"vispy:master","ref":"master","sha":"609af805bc184d694d80d98263cd2da867e30020","user":{"login":"vispy","id":3934254,"avatar_url":"https://avatars.githubusercontent.com/u/3934254?v=3","gravatar_id":"","url":"https://api.github.com/users/vispy","html_url":"https://github.com/vispy","followers_url":"https://api.github.com/users/vispy/followers","following_url":"https://api.github.com/users/vispy/following{/other_user}","gists_url":"https://api.github.com/users/vispy/gists{/gist_id}","starred_url":"https://api.github.com/users/vispy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vispy/subscriptions","organizations_url":"https://api.github.com/users/vispy/orgs","repos_url":"https://api.github.com/users/vispy/repos","events_url":"https://api.github.com/users/vispy/events{/privacy}","received_events_url":"https://api.github.com/users/vispy/received_events","type":"Organization","site_admin":false},"repo":{"id":8935948,"name":"vispy","full_name":"vispy/vispy","owner":{"login":"vispy","id":3934254,"avatar_url":"https://avatars.githubusercontent.com/u/3934254?v=3","gravatar_id":"","url":"https://api.github.com/users/vispy","html_url":"https://github.com/vispy","followers_url":"https://api.github.com/users/vispy/followers","following_url":"https://api.github.com/users/vispy/following{/other_user}","gists_url":"https://api.github.com/users/vispy/gists{/gist_id}","starred_url":"https://api.github.com/users/vispy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vispy/subscriptions","organizations_url":"https://api.github.com/users/vispy/orgs","repos_url":"https://api.github.com/users/vispy/repos","events_url":"https://api.github.com/users/vispy/events{/privacy}","received_events_url":"https://api.github.com/users/vispy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vispy/vispy","description":"Main repository for Vispy","fork":false,"url":"https://api.github.com/repos/vispy/vispy","forks_url":"https://api.github.com/repos/vispy/vispy/forks","keys_url":"https://api.github.com/repos/vispy/vispy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vispy/vispy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vispy/vispy/teams","hooks_url":"https://api.github.com/repos/vispy/vispy/hooks","issue_events_url":"https://api.github.com/repos/vispy/vispy/issues/events{/number}","events_url":"https://api.github.com/repos/vispy/vispy/events","assignees_url":"https://api.github.com/repos/vispy/vispy/assignees{/user}","branches_url":"https://api.github.com/repos/vispy/vispy/branches{/branch}","tags_url":"https://api.github.com/repos/vispy/vispy/tags","blobs_url":"https://api.github.com/repos/vispy/vispy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vispy/vispy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vispy/vispy/git/refs{/sha}","trees_url":"https://api.github.com/repos/vispy/vispy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vispy/vispy/statuses/{sha}","languages_url":"https://api.github.com/repos/vispy/vispy/languages","stargazers_url":"https://api.github.com/repos/vispy/vispy/stargazers","contributors_url":"https://api.github.com/repos/vispy/vispy/contributors","subscribers_url":"https://api.github.com/repos/vispy/vispy/subscribers","subscription_url":"https://api.github.com/repos/vispy/vispy/subscription","commits_url":"https://api.github.com/repos/vispy/vispy/commits{/sha}","git_commits_url":"https://api.github.com/repos/vispy/vispy/git/commits{/sha}","comments_url":"https://api.github.com/repos/vispy/vispy/comments{/number}","issue_comment_url":"https://api.github.com/repos/vispy/vispy/issues/comments{/number}","contents_url":"https://api.github.com/repos/vispy/vispy/contents/{+path}","compare_url":"https://api.github.com/repos/vispy/vispy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vispy/vispy/merges","archive_url":"https://api.github.com/repos/vispy/vispy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vispy/vispy/downloads","issues_url":"https://api.github.com/repos/vispy/vispy/issues{/number}","pulls_url":"https://api.github.com/repos/vispy/vispy/pulls{/number}","milestones_url":"https://api.github.com/repos/vispy/vispy/milestones{/number}","notifications_url":"https://api.github.com/repos/vispy/vispy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vispy/vispy/labels{/name}","releases_url":"https://api.github.com/repos/vispy/vispy/releases{/id}","created_at":"2013-03-21T18:43:22Z","updated_at":"2015-03-08T16:25:37Z","pushed_at":"2015-03-03T19:40:45Z","git_url":"git://github.com/vispy/vispy.git","ssh_url":"git@github.com:vispy/vispy.git","clone_url":"https://github.com/vispy/vispy.git","svn_url":"https://github.com/vispy/vispy","homepage":"http://vispy.org","size":14990,"stargazers_count":501,"watchers_count":501,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":80,"mirror_url":null,"open_issues_count":152,"forks":80,"open_issues":152,"watchers":501,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vispy/vispy/pulls/612"},"html":{"href":"https://github.com/vispy/vispy/pull/612"},"issue":{"href":"https://api.github.com/repos/vispy/vispy/issues/612"},"comments":{"href":"https://api.github.com/repos/vispy/vispy/issues/612/comments"},"review_comments":{"href":"https://api.github.com/repos/vispy/vispy/pulls/612/comments"},"review_comment":{"href":"https://api.github.com/repos/vispy/vispy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vispy/vispy/pulls/612/commits"},"statuses":{"href":"https://api.github.com/repos/vispy/vispy/statuses/77f623136463a9383c7e9bea3538445b6b33e3c3"}}}}