{"comment":{"url":"https://api.github.com/repos/biplovbhandari/eden/comments/13488564","html_url":"https://github.com/biplovbhandari/eden/commit/526cffa36f0055ecb9a57d893fc34bbd82bedb01#commitcomment-13488564","id":13488564,"user":{"login":"nursix","id":1257183,"avatar_url":"https://avatars.githubusercontent.com/u/1257183?v=3","gravatar_id":"","url":"https://api.github.com/users/nursix","html_url":"https://github.com/nursix","followers_url":"https://api.github.com/users/nursix/followers","following_url":"https://api.github.com/users/nursix/following{/other_user}","gists_url":"https://api.github.com/users/nursix/gists{/gist_id}","starred_url":"https://api.github.com/users/nursix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nursix/subscriptions","organizations_url":"https://api.github.com/users/nursix/orgs","repos_url":"https://api.github.com/users/nursix/repos","events_url":"https://api.github.com/users/nursix/events{/privacy}","received_events_url":"https://api.github.com/users/nursix/received_events","type":"User","site_admin":false},"position":518,"line":905,"path":"modules/templates/SAMBRO/controllers.py","commit_id":"526cffa36f0055ecb9a57d893fc34bbd82bedb01","created_at":"2015-09-29T09:59:34Z","updated_at":"2015-09-29T09:59:34Z","body":"You're returning a string. The caller stores it as \"sync_model_ids\". And actually just checks whether it is True-ish.\r\n\r\nWhy not just return True or False - and have the caller call it \"success\"?\r\n\r\nAnd why return anything at all - there is only one exit in this function, no way it would return anything else. It doesn't check failure, so it wouldn't ever indicate failure."}}