{"action":"created","issue":{"url":"https://api.github.com/repos/vokal/VOKMockUrlProtocol/issues/27","labels_url":"https://api.github.com/repos/vokal/VOKMockUrlProtocol/issues/27/labels{/name}","comments_url":"https://api.github.com/repos/vokal/VOKMockUrlProtocol/issues/27/comments","events_url":"https://api.github.com/repos/vokal/VOKMockUrlProtocol/issues/27/events","html_url":"https://github.com/vokal/VOKMockUrlProtocol/pull/27","id":95056627,"number":27,"title":"Modifies VOKMockUrlProtocol to allow for custom directory names","user":{"login":"caleb-lee","id":11948335,"avatar_url":"https://avatars.githubusercontent.com/u/11948335?v=3","gravatar_id":"","url":"https://api.github.com/users/caleb-lee","html_url":"https://github.com/caleb-lee","followers_url":"https://api.github.com/users/caleb-lee/followers","following_url":"https://api.github.com/users/caleb-lee/following{/other_user}","gists_url":"https://api.github.com/users/caleb-lee/gists{/gist_id}","starred_url":"https://api.github.com/users/caleb-lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caleb-lee/subscriptions","organizations_url":"https://api.github.com/users/caleb-lee/orgs","repos_url":"https://api.github.com/users/caleb-lee/repos","events_url":"https://api.github.com/users/caleb-lee/events{/privacy}","received_events_url":"https://api.github.com/users/caleb-lee/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-07-14T22:24:50Z","updated_at":"2015-07-15T15:12:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vokal/VOKMockUrlProtocol/pulls/27","html_url":"https://github.com/vokal/VOKMockUrlProtocol/pull/27","diff_url":"https://github.com/vokal/VOKMockUrlProtocol/pull/27.diff","patch_url":"https://github.com/vokal/VOKMockUrlProtocol/pull/27.patch"},"body":"This PR modifies VOKMockUrlProtocol to allow for custom directory names for mock data.\r\n\r\nIt sets the default directory name to the forced name from before. You can easily change the directory name by subclassing VOKMockUrlProtocol and overriding -initWithRequest:cachedResponse:client and setting the directory name in that method. This offers the advantage of being able to change mocked server responses based on conditions.\r\n\r\n@vokal/ios-developers code review please :)"},"comment":{"url":"https://api.github.com/repos/vokal/VOKMockUrlProtocol/issues/comments/121647138","html_url":"https://github.com/vokal/VOKMockUrlProtocol/pull/27#issuecomment-121647138","issue_url":"https://api.github.com/repos/vokal/VOKMockUrlProtocol/issues/27","id":121647138,"user":{"login":"caleb-lee","id":11948335,"avatar_url":"https://avatars.githubusercontent.com/u/11948335?v=3","gravatar_id":"","url":"https://api.github.com/users/caleb-lee","html_url":"https://github.com/caleb-lee","followers_url":"https://api.github.com/users/caleb-lee/followers","following_url":"https://api.github.com/users/caleb-lee/following{/other_user}","gists_url":"https://api.github.com/users/caleb-lee/gists{/gist_id}","starred_url":"https://api.github.com/users/caleb-lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caleb-lee/subscriptions","organizations_url":"https://api.github.com/users/caleb-lee/orgs","repos_url":"https://api.github.com/users/caleb-lee/repos","events_url":"https://api.github.com/users/caleb-lee/events{/privacy}","received_events_url":"https://api.github.com/users/caleb-lee/received_events","type":"User","site_admin":false},"created_at":"2015-07-15T15:12:40Z","updated_at":"2015-07-15T15:12:40Z","body":"@vokal-isaac: the consumer of the class can subclass and set the property in initWithRequest:cachedResponse:client. This functionality is tested working.\r\n\r\nAs far as I know, without subclassing, there isn't any way to set the property."}}