{"action":"created","issue":{"url":"https://api.github.com/repos/naver/yobi/issues/858","labels_url":"https://api.github.com/repos/naver/yobi/issues/858/labels{/name}","comments_url":"https://api.github.com/repos/naver/yobi/issues/858/comments","events_url":"https://api.github.com/repos/naver/yobi/issues/858/events","html_url":"https://github.com/naver/yobi/pull/858","id":57034916,"number":858,"title":"Ssh기능 추가","user":{"login":"oh4851","id":9246985,"avatar_url":"https://avatars.githubusercontent.com/u/9246985?v=3","gravatar_id":"","url":"https://api.github.com/users/oh4851","html_url":"https://github.com/oh4851","followers_url":"https://api.github.com/users/oh4851/followers","following_url":"https://api.github.com/users/oh4851/following{/other_user}","gists_url":"https://api.github.com/users/oh4851/gists{/gist_id}","starred_url":"https://api.github.com/users/oh4851/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oh4851/subscriptions","organizations_url":"https://api.github.com/users/oh4851/orgs","repos_url":"https://api.github.com/users/oh4851/repos","events_url":"https://api.github.com/users/oh4851/events{/privacy}","received_events_url":"https://api.github.com/users/oh4851/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-02-09T14:09:41Z","updated_at":"2015-02-12T14:51:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/naver/yobi/pulls/858","html_url":"https://github.com/naver/yobi/pull/858","diff_url":"https://github.com/naver/yobi/pull/858.diff","patch_url":"https://github.com/naver/yobi/pull/858.patch"},"body":"@npcode @doortts 다시 보냅니다.\r\n@KOR-Believer\r\n\r\n리뷰해주신 내용 반영한 부분입니다.\r\n- Diagnostic에 sshdaemon을 등록했습니다.\r\n- app/models/ssh에서 ebean.Model을 상속받지 않은 것은 app/sshs로 이동했습니다.\r\n- \"yobi\", 22 -> 상수 처리했습니다.\r\n- exist()메서드 이름 변경 -> findByKey()\r\n- publicKeyAuth의 불필요한 result변수 제거\r\n- 조건문에 포함 한 주석 변경 (if public key exists)\r\n\r\n현재 수정중인 부분입니다.\r\n- DaemonClient, SshServerSession, SshServerSessionFactory에서 실제 필요한 부분은 제한적이어서 새로 작성할 수 있을 것 같습니다.\r\n- SshKey.java를 수정 중입니다.\r\n\r\n__ssh url복사__\r\n![프로젝트 내 ssh url 복사](https://raw.githubusercontent.com/oh4851/myImages/master/images/projectPage_url.png?token=AI0ZCfwnw51ks2M-vAEdlh_eUZcZAxOgks5U3Y6DwA%3D%3D)\r\n__sshkey관리__\r\n![설정창 내 sshkey관리](https://raw.githubusercontent.com/oh4851/myImages/master/images/settingSsh_manage.PNG?token=AI0ZCeJS-6rwUW9iKS1pQFeC2poTklXyks5U3Y7swA%3D%3D)"},"comment":{"url":"https://api.github.com/repos/naver/yobi/issues/comments/74082672","html_url":"https://github.com/naver/yobi/pull/858#issuecomment-74082672","issue_url":"https://api.github.com/repos/naver/yobi/issues/858","id":74082672,"user":{"login":"oh4851","id":9246985,"avatar_url":"https://avatars.githubusercontent.com/u/9246985?v=3","gravatar_id":"","url":"https://api.github.com/users/oh4851","html_url":"https://github.com/oh4851","followers_url":"https://api.github.com/users/oh4851/followers","following_url":"https://api.github.com/users/oh4851/following{/other_user}","gists_url":"https://api.github.com/users/oh4851/gists{/gist_id}","starred_url":"https://api.github.com/users/oh4851/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oh4851/subscriptions","organizations_url":"https://api.github.com/users/oh4851/orgs","repos_url":"https://api.github.com/users/oh4851/repos","events_url":"https://api.github.com/users/oh4851/events{/privacy}","received_events_url":"https://api.github.com/users/oh4851/received_events","type":"User","site_admin":false},"created_at":"2015-02-12T14:51:22Z","updated_at":"2015-02-12T14:51:22Z","body":"- ssh.port에 대한 예외처리 추가했습니다.\r\n - 숫자가 아닌 경우\r\n - 포트 번호가 out of range인 경우 (0 ~ 65535가 아닌 경우)\r\n- docs/ko/technical/ssh-daemon.md 문서 수정했습니다.\r\n- 그 외 자잘한 수정사항(빈줄, 변수명, 패키지명 등) 반영했습니다.\r\n\r\n**TODO**\r\n- ssh-daemon.md의 도입부에 ssh서버 데몬이 무엇을 하는지 간략히 적는 작업\r\n- next브랜치랑 merge가능하도록 수정 `6657785` 이후에 non-fast foward로 브랜치 작업이 이루어 져서 merge시도할 경우 conflict가 나는데 이를 수정할 계획\r\n- 위의 merge작업을 진행하고 findbugs로 잠재적 결함 찾는 작업 진행"}}