{"action":"opened","number":792,"pull_request":{"url":"https://api.github.com/repos/nylas/N1/pulls/792","id":54247100,"html_url":"https://github.com/nylas/N1/pull/792","diff_url":"https://github.com/nylas/N1/pull/792.diff","patch_url":"https://github.com/nylas/N1/pull/792.patch","issue_url":"https://api.github.com/repos/nylas/N1/issues/792","number":792,"state":"open","locked":false,"title":"Names with @ are included in the contact name.","user":{"login":"Sumukh","id":882381,"avatar_url":"https://avatars.githubusercontent.com/u/882381?v=3","gravatar_id":"","url":"https://api.github.com/users/Sumukh","html_url":"https://github.com/Sumukh","followers_url":"https://api.github.com/users/Sumukh/followers","following_url":"https://api.github.com/users/Sumukh/following{/other_user}","gists_url":"https://api.github.com/users/Sumukh/gists{/gist_id}","starred_url":"https://api.github.com/users/Sumukh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sumukh/subscriptions","organizations_url":"https://api.github.com/users/Sumukh/orgs","repos_url":"https://api.github.com/users/Sumukh/repos","events_url":"https://api.github.com/users/Sumukh/events{/privacy}","received_events_url":"https://api.github.com/users/Sumukh/received_events","type":"User","site_admin":false},"body":"This resolves #713. \r\n\r\nThe regression here is that a contact with the name \"ev@nylas.com\" would be parsed as Ev@nylas.com\r\nPreviously this would have parsed to a firstName of \"Ev\". \r\n\r\nThe only way around this is to introduce a email format check against names. I'm not sure how common it is to have a name field be a valid email address - but it might be more common than normal names that contain `@`. \r\n","created_at":"2015-12-21T11:39:19Z","updated_at":"2015-12-21T11:39:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nylas/N1/pulls/792/commits","review_comments_url":"https://api.github.com/repos/nylas/N1/pulls/792/comments","review_comment_url":"https://api.github.com/repos/nylas/N1/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nylas/N1/issues/792/comments","statuses_url":"https://api.github.com/repos/nylas/N1/statuses/78d8a1a24582399199d39e5d616e2fc3c141b096","head":{"label":"Sumukh:at-character-parse","ref":"at-character-parse","sha":"78d8a1a24582399199d39e5d616e2fc3c141b096","user":{"login":"Sumukh","id":882381,"avatar_url":"https://avatars.githubusercontent.com/u/882381?v=3","gravatar_id":"","url":"https://api.github.com/users/Sumukh","html_url":"https://github.com/Sumukh","followers_url":"https://api.github.com/users/Sumukh/followers","following_url":"https://api.github.com/users/Sumukh/following{/other_user}","gists_url":"https://api.github.com/users/Sumukh/gists{/gist_id}","starred_url":"https://api.github.com/users/Sumukh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sumukh/subscriptions","organizations_url":"https://api.github.com/users/Sumukh/orgs","repos_url":"https://api.github.com/users/Sumukh/repos","events_url":"https://api.github.com/users/Sumukh/events{/privacy}","received_events_url":"https://api.github.com/users/Sumukh/received_events","type":"User","site_admin":false},"repo":{"id":48068244,"name":"N1","full_name":"Sumukh/N1","owner":{"login":"Sumukh","id":882381,"avatar_url":"https://avatars.githubusercontent.com/u/882381?v=3","gravatar_id":"","url":"https://api.github.com/users/Sumukh","html_url":"https://github.com/Sumukh","followers_url":"https://api.github.com/users/Sumukh/followers","following_url":"https://api.github.com/users/Sumukh/following{/other_user}","gists_url":"https://api.github.com/users/Sumukh/gists{/gist_id}","starred_url":"https://api.github.com/users/Sumukh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sumukh/subscriptions","organizations_url":"https://api.github.com/users/Sumukh/orgs","repos_url":"https://api.github.com/users/Sumukh/repos","events_url":"https://api.github.com/users/Sumukh/events{/privacy}","received_events_url":"https://api.github.com/users/Sumukh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Sumukh/N1","description":"An extensible mail client built on the modern web.","fork":true,"url":"https://api.github.com/repos/Sumukh/N1","forks_url":"https://api.github.com/repos/Sumukh/N1/forks","keys_url":"https://api.github.com/repos/Sumukh/N1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sumukh/N1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sumukh/N1/teams","hooks_url":"https://api.github.com/repos/Sumukh/N1/hooks","issue_events_url":"https://api.github.com/repos/Sumukh/N1/issues/events{/number}","events_url":"https://api.github.com/repos/Sumukh/N1/events","assignees_url":"https://api.github.com/repos/Sumukh/N1/assignees{/user}","branches_url":"https://api.github.com/repos/Sumukh/N1/branches{/branch}","tags_url":"https://api.github.com/repos/Sumukh/N1/tags","blobs_url":"https://api.github.com/repos/Sumukh/N1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sumukh/N1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sumukh/N1/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sumukh/N1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sumukh/N1/statuses/{sha}","languages_url":"https://api.github.com/repos/Sumukh/N1/languages","stargazers_url":"https://api.github.com/repos/Sumukh/N1/stargazers","contributors_url":"https://api.github.com/repos/Sumukh/N1/contributors","subscribers_url":"https://api.github.com/repos/Sumukh/N1/subscribers","subscription_url":"https://api.github.com/repos/Sumukh/N1/subscription","commits_url":"https://api.github.com/repos/Sumukh/N1/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sumukh/N1/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sumukh/N1/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sumukh/N1/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sumukh/N1/contents/{+path}","compare_url":"https://api.github.com/repos/Sumukh/N1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sumukh/N1/merges","archive_url":"https://api.github.com/repos/Sumukh/N1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sumukh/N1/downloads","issues_url":"https://api.github.com/repos/Sumukh/N1/issues{/number}","pulls_url":"https://api.github.com/repos/Sumukh/N1/pulls{/number}","milestones_url":"https://api.github.com/repos/Sumukh/N1/milestones{/number}","notifications_url":"https://api.github.com/repos/Sumukh/N1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sumukh/N1/labels{/name}","releases_url":"https://api.github.com/repos/Sumukh/N1/releases{/id}","created_at":"2015-12-15T20:50:01Z","updated_at":"2015-12-15T20:50:03Z","pushed_at":"2015-12-21T11:34:00Z","git_url":"git://github.com/Sumukh/N1.git","ssh_url":"git@github.com:Sumukh/N1.git","clone_url":"https://github.com/Sumukh/N1.git","svn_url":"https://github.com/Sumukh/N1","homepage":"https://nylas.com/N1","size":43596,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nylas:master","ref":"master","sha":"de1f8d24d0a6cefc19f0a7b5481274ab7d358041","user":{"login":"nylas","id":4219865,"avatar_url":"https://avatars.githubusercontent.com/u/4219865?v=3","gravatar_id":"","url":"https://api.github.com/users/nylas","html_url":"https://github.com/nylas","followers_url":"https://api.github.com/users/nylas/followers","following_url":"https://api.github.com/users/nylas/following{/other_user}","gists_url":"https://api.github.com/users/nylas/gists{/gist_id}","starred_url":"https://api.github.com/users/nylas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nylas/subscriptions","organizations_url":"https://api.github.com/users/nylas/orgs","repos_url":"https://api.github.com/users/nylas/repos","events_url":"https://api.github.com/users/nylas/events{/privacy}","received_events_url":"https://api.github.com/users/nylas/received_events","type":"Organization","site_admin":false},"repo":{"id":25315643,"name":"N1","full_name":"nylas/N1","owner":{"login":"nylas","id":4219865,"avatar_url":"https://avatars.githubusercontent.com/u/4219865?v=3","gravatar_id":"","url":"https://api.github.com/users/nylas","html_url":"https://github.com/nylas","followers_url":"https://api.github.com/users/nylas/followers","following_url":"https://api.github.com/users/nylas/following{/other_user}","gists_url":"https://api.github.com/users/nylas/gists{/gist_id}","starred_url":"https://api.github.com/users/nylas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nylas/subscriptions","organizations_url":"https://api.github.com/users/nylas/orgs","repos_url":"https://api.github.com/users/nylas/repos","events_url":"https://api.github.com/users/nylas/events{/privacy}","received_events_url":"https://api.github.com/users/nylas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nylas/N1","description":"An extensible mail client built on the modern web.","fork":false,"url":"https://api.github.com/repos/nylas/N1","forks_url":"https://api.github.com/repos/nylas/N1/forks","keys_url":"https://api.github.com/repos/nylas/N1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nylas/N1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nylas/N1/teams","hooks_url":"https://api.github.com/repos/nylas/N1/hooks","issue_events_url":"https://api.github.com/repos/nylas/N1/issues/events{/number}","events_url":"https://api.github.com/repos/nylas/N1/events","assignees_url":"https://api.github.com/repos/nylas/N1/assignees{/user}","branches_url":"https://api.github.com/repos/nylas/N1/branches{/branch}","tags_url":"https://api.github.com/repos/nylas/N1/tags","blobs_url":"https://api.github.com/repos/nylas/N1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nylas/N1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nylas/N1/git/refs{/sha}","trees_url":"https://api.github.com/repos/nylas/N1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nylas/N1/statuses/{sha}","languages_url":"https://api.github.com/repos/nylas/N1/languages","stargazers_url":"https://api.github.com/repos/nylas/N1/stargazers","contributors_url":"https://api.github.com/repos/nylas/N1/contributors","subscribers_url":"https://api.github.com/repos/nylas/N1/subscribers","subscription_url":"https://api.github.com/repos/nylas/N1/subscription","commits_url":"https://api.github.com/repos/nylas/N1/commits{/sha}","git_commits_url":"https://api.github.com/repos/nylas/N1/git/commits{/sha}","comments_url":"https://api.github.com/repos/nylas/N1/comments{/number}","issue_comment_url":"https://api.github.com/repos/nylas/N1/issues/comments{/number}","contents_url":"https://api.github.com/repos/nylas/N1/contents/{+path}","compare_url":"https://api.github.com/repos/nylas/N1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nylas/N1/merges","archive_url":"https://api.github.com/repos/nylas/N1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nylas/N1/downloads","issues_url":"https://api.github.com/repos/nylas/N1/issues{/number}","pulls_url":"https://api.github.com/repos/nylas/N1/pulls{/number}","milestones_url":"https://api.github.com/repos/nylas/N1/milestones{/number}","notifications_url":"https://api.github.com/repos/nylas/N1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nylas/N1/labels{/name}","releases_url":"https://api.github.com/repos/nylas/N1/releases{/id}","created_at":"2014-10-16T18:29:12Z","updated_at":"2015-12-21T10:55:33Z","pushed_at":"2015-12-21T05:33:05Z","git_url":"git://github.com/nylas/N1.git","ssh_url":"git@github.com:nylas/N1.git","clone_url":"https://github.com/nylas/N1.git","svn_url":"https://github.com/nylas/N1","homepage":"https://nylas.com/N1","size":44355,"stargazers_count":13954,"watchers_count":13954,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":400,"mirror_url":null,"open_issues_count":275,"forks":400,"open_issues":275,"watchers":13954,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nylas/N1/pulls/792"},"html":{"href":"https://github.com/nylas/N1/pull/792"},"issue":{"href":"https://api.github.com/repos/nylas/N1/issues/792"},"comments":{"href":"https://api.github.com/repos/nylas/N1/issues/792/comments"},"review_comments":{"href":"https://api.github.com/repos/nylas/N1/pulls/792/comments"},"review_comment":{"href":"https://api.github.com/repos/nylas/N1/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nylas/N1/pulls/792/commits"},"statuses":{"href":"https://api.github.com/repos/nylas/N1/statuses/78d8a1a24582399199d39e5d616e2fc3c141b096"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":45,"deletions":5,"changed_files":2}}