{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/fjord/pulls/comments/29892713","id":29892713,"diff_hunk":"@@ -115,68 +117,60 @@ def test_valid_sad(self):\n         eq_(u'14.0.1', feedback.version)\n \n     @with_waffle('thankyou', True)\n-    def test_use_thank_you_sad(self):\n-        \"\"\"Thanks_sad template is used when appropriate\"\"\"\n+    def test_thankyou_flag_active(self):\n+        \"\"\"Verify response and suggestions when thankyou flag is active\"\"\"\n         url = reverse('feedback', args=(u'firefox',), locale='en-US')\n         r = self.client.post(url, {\n             'happy': 0,\n-            'description': u\"I want to know why Firefox doesn't make me sandwiches!\",\n+            'description': u'Why Firefox not make me sandwiches!',\n         }, follow=True)\n \n         feedback = models.Response.objects.latest(field_name='id')\n-        eq_(u\"I want to know why Firefox doesn't make me sandwiches!\", feedback.description)\n-        eq_(u'', feedback.url)\n-        eq_(False, feedback.happy)\n-        eq_(u'en-US', feedback.locale)\n         eq_(r.status_code, 200)\n-        self.assertTemplateUsed(r, 'feedback/thanks_sad.html')\n+        eq_(r.context['response'].id, feedback.id)","path":"fjord/feedback/tests/test_views.py","position":70,"original_position":70,"commit_id":"958502919fbd8872ecb9b1408f210a75653e6bde","original_commit_id":"958502919fbd8872ecb9b1408f210a75653e6bde","user":{"login":"mythmon","id":305049,"avatar_url":"https://avatars.githubusercontent.com/u/305049?v=3","gravatar_id":"","url":"https://api.github.com/users/mythmon","html_url":"https://github.com/mythmon","followers_url":"https://api.github.com/users/mythmon/followers","following_url":"https://api.github.com/users/mythmon/following{/other_user}","gists_url":"https://api.github.com/users/mythmon/gists{/gist_id}","starred_url":"https://api.github.com/users/mythmon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mythmon/subscriptions","organizations_url":"https://api.github.com/users/mythmon/orgs","repos_url":"https://api.github.com/users/mythmon/repos","events_url":"https://api.github.com/users/mythmon/events{/privacy}","received_events_url":"https://api.github.com/users/mythmon/received_events","type":"User","site_admin":false},"body":"This is checking the context that was passed to render the template? I didn't know you could do that. Awesome!","created_at":"2015-05-07T20:30:45Z","updated_at":"2015-05-07T20:30:45Z","html_url":"https://github.com/mozilla/fjord/pull/570#discussion_r29892713","pull_request_url":"https://api.github.com/repos/mozilla/fjord/pulls/570","_links":{"self":{"href":"https://api.github.com/repos/mozilla/fjord/pulls/comments/29892713"},"html":{"href":"https://github.com/mozilla/fjord/pull/570#discussion_r29892713"},"pull_request":{"href":"https://api.github.com/repos/mozilla/fjord/pulls/570"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/fjord/pulls/570","id":34924028,"html_url":"https://github.com/mozilla/fjord/pull/570","diff_url":"https://github.com/mozilla/fjord/pull/570.diff","patch_url":"https://github.com/mozilla/fjord/pull/570.patch","issue_url":"https://api.github.com/repos/mozilla/fjord/issues/570","number":570,"state":"open","locked":false,"title":"[bug 1133771] Rework thank you page view","user":{"login":"willkg","id":820826,"avatar_url":"https://avatars.githubusercontent.com/u/820826?v=3","gravatar_id":"","url":"https://api.github.com/users/willkg","html_url":"https://github.com/willkg","followers_url":"https://api.github.com/users/willkg/followers","following_url":"https://api.github.com/users/willkg/following{/other_user}","gists_url":"https://api.github.com/users/willkg/gists{/gist_id}","starred_url":"https://api.github.com/users/willkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willkg/subscriptions","organizations_url":"https://api.github.com/users/willkg/orgs","repos_url":"https://api.github.com/users/willkg/repos","events_url":"https://api.github.com/users/willkg/events{/privacy}","received_events_url":"https://api.github.com/users/willkg/received_events","type":"User","site_admin":false},"body":"This reworks the Thank You page view and tests. We continue to use the\r\nthankyou page flag, but this allows us to specify a response_id in the\r\nquerystring to make it easier to examine and debug behavior in\r\nproduction.\r\n\r\nPlus it gets rid of the thanks_sad.html template.\r\n\r\nr?","created_at":"2015-05-07T14:57:14Z","updated_at":"2015-05-07T20:30:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de01b69bfd4d5a79c3d15627c7c75d65a4fbe1fc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/fjord/pulls/570/commits","review_comments_url":"https://api.github.com/repos/mozilla/fjord/pulls/570/comments","review_comment_url":"https://api.github.com/repos/mozilla/fjord/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/fjord/issues/570/comments","statuses_url":"https://api.github.com/repos/mozilla/fjord/statuses/958502919fbd8872ecb9b1408f210a75653e6bde","head":{"label":"willkg:1133771-rework-typ","ref":"1133771-rework-typ","sha":"958502919fbd8872ecb9b1408f210a75653e6bde","user":{"login":"willkg","id":820826,"avatar_url":"https://avatars.githubusercontent.com/u/820826?v=3","gravatar_id":"","url":"https://api.github.com/users/willkg","html_url":"https://github.com/willkg","followers_url":"https://api.github.com/users/willkg/followers","following_url":"https://api.github.com/users/willkg/following{/other_user}","gists_url":"https://api.github.com/users/willkg/gists{/gist_id}","starred_url":"https://api.github.com/users/willkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willkg/subscriptions","organizations_url":"https://api.github.com/users/willkg/orgs","repos_url":"https://api.github.com/users/willkg/repos","events_url":"https://api.github.com/users/willkg/events{/privacy}","received_events_url":"https://api.github.com/users/willkg/received_events","type":"User","site_admin":false},"repo":{"id":5204498,"name":"fjord","full_name":"willkg/fjord","owner":{"login":"willkg","id":820826,"avatar_url":"https://avatars.githubusercontent.com/u/820826?v=3","gravatar_id":"","url":"https://api.github.com/users/willkg","html_url":"https://github.com/willkg","followers_url":"https://api.github.com/users/willkg/followers","following_url":"https://api.github.com/users/willkg/following{/other_user}","gists_url":"https://api.github.com/users/willkg/gists{/gist_id}","starred_url":"https://api.github.com/users/willkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willkg/subscriptions","organizations_url":"https://api.github.com/users/willkg/orgs","repos_url":"https://api.github.com/users/willkg/repos","events_url":"https://api.github.com/users/willkg/events{/privacy}","received_events_url":"https://api.github.com/users/willkg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/willkg/fjord","description":"Software that runs the new input.mozilla.org","fork":true,"url":"https://api.github.com/repos/willkg/fjord","forks_url":"https://api.github.com/repos/willkg/fjord/forks","keys_url":"https://api.github.com/repos/willkg/fjord/keys{/key_id}","collaborators_url":"https://api.github.com/repos/willkg/fjord/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/willkg/fjord/teams","hooks_url":"https://api.github.com/repos/willkg/fjord/hooks","issue_events_url":"https://api.github.com/repos/willkg/fjord/issues/events{/number}","events_url":"https://api.github.com/repos/willkg/fjord/events","assignees_url":"https://api.github.com/repos/willkg/fjord/assignees{/user}","branches_url":"https://api.github.com/repos/willkg/fjord/branches{/branch}","tags_url":"https://api.github.com/repos/willkg/fjord/tags","blobs_url":"https://api.github.com/repos/willkg/fjord/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/willkg/fjord/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/willkg/fjord/git/refs{/sha}","trees_url":"https://api.github.com/repos/willkg/fjord/git/trees{/sha}","statuses_url":"https://api.github.com/repos/willkg/fjord/statuses/{sha}","languages_url":"https://api.github.com/repos/willkg/fjord/languages","stargazers_url":"https://api.github.com/repos/willkg/fjord/stargazers","contributors_url":"https://api.github.com/repos/willkg/fjord/contributors","subscribers_url":"https://api.github.com/repos/willkg/fjord/subscribers","subscription_url":"https://api.github.com/repos/willkg/fjord/subscription","commits_url":"https://api.github.com/repos/willkg/fjord/commits{/sha}","git_commits_url":"https://api.github.com/repos/willkg/fjord/git/commits{/sha}","comments_url":"https://api.github.com/repos/willkg/fjord/comments{/number}","issue_comment_url":"https://api.github.com/repos/willkg/fjord/issues/comments{/number}","contents_url":"https://api.github.com/repos/willkg/fjord/contents/{+path}","compare_url":"https://api.github.com/repos/willkg/fjord/compare/{base}...{head}","merges_url":"https://api.github.com/repos/willkg/fjord/merges","archive_url":"https://api.github.com/repos/willkg/fjord/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/willkg/fjord/downloads","issues_url":"https://api.github.com/repos/willkg/fjord/issues{/number}","pulls_url":"https://api.github.com/repos/willkg/fjord/pulls{/number}","milestones_url":"https://api.github.com/repos/willkg/fjord/milestones{/number}","notifications_url":"https://api.github.com/repos/willkg/fjord/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/willkg/fjord/labels{/name}","releases_url":"https://api.github.com/repos/willkg/fjord/releases{/id}","created_at":"2012-07-27T12:53:19Z","updated_at":"2015-04-27T14:46:28Z","pushed_at":"2015-05-07T14:59:19Z","git_url":"git://github.com/willkg/fjord.git","ssh_url":"git@github.com:willkg/fjord.git","clone_url":"https://github.com/willkg/fjord.git","svn_url":"https://github.com/willkg/fjord","homepage":null,"size":70526,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"77c2ec508625a36aa9095d7432146335ba6494aa","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":5197539,"name":"fjord","full_name":"mozilla/fjord","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fjord","description":"Software that runs the new input.mozilla.org","fork":false,"url":"https://api.github.com/repos/mozilla/fjord","forks_url":"https://api.github.com/repos/mozilla/fjord/forks","keys_url":"https://api.github.com/repos/mozilla/fjord/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fjord/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fjord/teams","hooks_url":"https://api.github.com/repos/mozilla/fjord/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fjord/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fjord/events","assignees_url":"https://api.github.com/repos/mozilla/fjord/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fjord/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fjord/tags","blobs_url":"https://api.github.com/repos/mozilla/fjord/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fjord/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fjord/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fjord/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fjord/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fjord/languages","stargazers_url":"https://api.github.com/repos/mozilla/fjord/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fjord/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fjord/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fjord/subscription","commits_url":"https://api.github.com/repos/mozilla/fjord/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fjord/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fjord/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fjord/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/fjord/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fjord/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fjord/merges","archive_url":"https://api.github.com/repos/mozilla/fjord/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fjord/downloads","issues_url":"https://api.github.com/repos/mozilla/fjord/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fjord/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fjord/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fjord/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fjord/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fjord/releases{/id}","created_at":"2012-07-26T21:25:00Z","updated_at":"2015-05-06T19:33:58Z","pushed_at":"2015-05-07T14:57:15Z","git_url":"git://github.com/mozilla/fjord.git","ssh_url":"git@github.com:mozilla/fjord.git","clone_url":"https://github.com/mozilla/fjord.git","svn_url":"https://github.com/mozilla/fjord","homepage":null,"size":75895,"stargazers_count":20,"watchers_count":20,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":1,"forks":41,"open_issues":1,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/fjord/pulls/570"},"html":{"href":"https://github.com/mozilla/fjord/pull/570"},"issue":{"href":"https://api.github.com/repos/mozilla/fjord/issues/570"},"comments":{"href":"https://api.github.com/repos/mozilla/fjord/issues/570/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/fjord/pulls/570/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/fjord/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/fjord/pulls/570/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/fjord/statuses/958502919fbd8872ecb9b1408f210a75653e6bde"}}}}