{"action":"created","issue":{"url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5107","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5107/labels{/name}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5107/comments","events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5107/events","html_url":"https://github.com/NREL/EnergyPlus/pull/5107","id":101071711,"number":5107,"title":"97215920   fill gaps in hvac components   initial code","user":{"login":"rraustad","id":5778156,"avatar_url":"https://avatars.githubusercontent.com/u/5778156?v=3","gravatar_id":"","url":"https://api.github.com/users/rraustad","html_url":"https://github.com/rraustad","followers_url":"https://api.github.com/users/rraustad/followers","following_url":"https://api.github.com/users/rraustad/following{/other_user}","gists_url":"https://api.github.com/users/rraustad/gists{/gist_id}","starred_url":"https://api.github.com/users/rraustad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rraustad/subscriptions","organizations_url":"https://api.github.com/users/rraustad/orgs","repos_url":"https://api.github.com/users/rraustad/repos","events_url":"https://api.github.com/users/rraustad/events{/privacy}","received_events_url":"https://api.github.com/users/rraustad/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-08-14T18:20:52Z","updated_at":"2015-08-24T17:55:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5107","html_url":"https://github.com/NREL/EnergyPlus/pull/5107","diff_url":"https://github.com/NREL/EnergyPlus/pull/5107.diff","patch_url":"https://github.com/NREL/EnergyPlus/pull/5107.patch"},"body":"Ready for review.\r\n\r\n- added Coil:Cooling:DX:SingleSpeed:ThermalStorage and Coil:UserDefined to UnitarySystems\r\n- added Coil:Heating:Electric to fan coil units\r\n- added Fan:ComponentModel to UnitarySystems\r\n- added unit test to call SimUnitarySystem and compare system output to RemainingOutputRequired.\r\n- fixed DataHVACGlobals coil type numbering. WaterCoils had a hard-coded coil type (e.g., cAllCoilTypes(15)). After fixing this, renumbering worked as expected. This will cause merge conflicts in Rongpeng and Bereket's branch.\r\n- fixed one unit test that fails now when it ran before (yet I don't see how it ran before)\r\n- one unit test runs in debugger yet fails in release version (ConfirmUnitarySystemSizingTest). Check if this is the case on CI.\r\n- IO Ref and Eng Ref docs updated\r\n- IDD updated\r\n"},"comment":{"url":"https://api.github.com/repos/NREL/EnergyPlus/issues/comments/134316489","html_url":"https://github.com/NREL/EnergyPlus/pull/5107#issuecomment-134316489","issue_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5107","id":134316489,"user":{"login":"mjwitte","id":4991075,"avatar_url":"https://avatars.githubusercontent.com/u/4991075?v=3","gravatar_id":"","url":"https://api.github.com/users/mjwitte","html_url":"https://github.com/mjwitte","followers_url":"https://api.github.com/users/mjwitte/followers","following_url":"https://api.github.com/users/mjwitte/following{/other_user}","gists_url":"https://api.github.com/users/mjwitte/gists{/gist_id}","starred_url":"https://api.github.com/users/mjwitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjwitte/subscriptions","organizations_url":"https://api.github.com/users/mjwitte/orgs","repos_url":"https://api.github.com/users/mjwitte/repos","events_url":"https://api.github.com/users/mjwitte/events{/privacy}","received_events_url":"https://api.github.com/users/mjwitte/received_events","type":"User","site_admin":false},"created_at":"2015-08-24T17:55:03Z","updated_at":"2015-08-24T17:55:03Z","body":"@rraustad Do you have any pending code to push up?  Or is this ready for testing and final review?"}}