{"action":"created","comment":{"url":"https://api.github.com/repos/marklogic/slush-marklogic-node/pulls/comments/38866412","id":38866412,"diff_hunk":"@@ -9,9 +9,10 @@\n   function LoginService($http, $modal, $q, $rootScope, $state, $stateParams, messageBoardService) {\n     var _loginMode = 'full'; // 'modal', 'top-right', or 'full'\n     var _loginError;\n-    var _isAuthenticated = false;\n     var _toStateName;\n     var _toStateParams;\n+    var _isAuthenticated = isLoggedIn();","path":"app/templates/ui/app/login/login.service.js","position":7,"original_position":7,"commit_id":"95731097841e55e3b211aab936d920d41b0c054b","original_commit_id":"95731097841e55e3b211aab936d920d41b0c054b","user":{"login":"hunterwilliams","id":1759942,"avatar_url":"https://avatars.githubusercontent.com/u/1759942?v=3","gravatar_id":"","url":"https://api.github.com/users/hunterwilliams","html_url":"https://github.com/hunterwilliams","followers_url":"https://api.github.com/users/hunterwilliams/followers","following_url":"https://api.github.com/users/hunterwilliams/following{/other_user}","gists_url":"https://api.github.com/users/hunterwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/hunterwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hunterwilliams/subscriptions","organizations_url":"https://api.github.com/users/hunterwilliams/orgs","repos_url":"https://api.github.com/users/hunterwilliams/repos","events_url":"https://api.github.com/users/hunterwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/hunterwilliams/received_events","type":"User","site_admin":false},"body":"It's currently returning the promise I think. At least the value isn't there in time for the bottom. Ideally I don't want to wait for a promise.","created_at":"2015-09-07T14:38:18Z","updated_at":"2015-09-07T14:38:18Z","html_url":"https://github.com/marklogic/slush-marklogic-node/pull/168#discussion_r38866412","pull_request_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/pulls/168","_links":{"self":{"href":"https://api.github.com/repos/marklogic/slush-marklogic-node/pulls/comments/38866412"},"html":{"href":"https://github.com/marklogic/slush-marklogic-node/pull/168#discussion_r38866412"},"pull_request":{"href":"https://api.github.com/repos/marklogic/slush-marklogic-node/pulls/168"}}},"pull_request":{"url":"https://api.github.com/repos/marklogic/slush-marklogic-node/pulls/168","id":44358864,"html_url":"https://github.com/marklogic/slush-marklogic-node/pull/168","diff_url":"https://github.com/marklogic/slush-marklogic-node/pull/168.diff","patch_url":"https://github.com/marklogic/slush-marklogic-node/pull/168.patch","issue_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/issues/168","number":168,"state":"open","locked":false,"title":"#141 PR - Login Service Changes/Fix","user":{"login":"hunterwilliams","id":1759942,"avatar_url":"https://avatars.githubusercontent.com/u/1759942?v=3","gravatar_id":"","url":"https://api.github.com/users/hunterwilliams","html_url":"https://github.com/hunterwilliams","followers_url":"https://api.github.com/users/hunterwilliams/followers","following_url":"https://api.github.com/users/hunterwilliams/following{/other_user}","gists_url":"https://api.github.com/users/hunterwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/hunterwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hunterwilliams/subscriptions","organizations_url":"https://api.github.com/users/hunterwilliams/orgs","repos_url":"https://api.github.com/users/hunterwilliams/repos","events_url":"https://api.github.com/users/hunterwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/hunterwilliams/received_events","type":"User","site_admin":false},"body":"#141 targeted\r\n#143 also fixed when adding search to routes.js\r\n\r\n\r\nLet's discuss what I've got so far... It's going to require possibly some design changes further than what I've done so far","created_at":"2015-09-07T14:09:46Z","updated_at":"2015-09-07T14:38:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6703f4f94adbe675d935fd809cd993e8bf5bc52e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/pulls/168/commits","review_comments_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/pulls/168/comments","review_comment_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/issues/168/comments","statuses_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/statuses/95731097841e55e3b211aab936d920d41b0c054b","head":{"label":"hunterwilliams:login-status-fix","ref":"login-status-fix","sha":"95731097841e55e3b211aab936d920d41b0c054b","user":{"login":"hunterwilliams","id":1759942,"avatar_url":"https://avatars.githubusercontent.com/u/1759942?v=3","gravatar_id":"","url":"https://api.github.com/users/hunterwilliams","html_url":"https://github.com/hunterwilliams","followers_url":"https://api.github.com/users/hunterwilliams/followers","following_url":"https://api.github.com/users/hunterwilliams/following{/other_user}","gists_url":"https://api.github.com/users/hunterwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/hunterwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hunterwilliams/subscriptions","organizations_url":"https://api.github.com/users/hunterwilliams/orgs","repos_url":"https://api.github.com/users/hunterwilliams/repos","events_url":"https://api.github.com/users/hunterwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/hunterwilliams/received_events","type":"User","site_admin":false},"repo":{"id":40276760,"name":"slush-marklogic-node","full_name":"hunterwilliams/slush-marklogic-node","owner":{"login":"hunterwilliams","id":1759942,"avatar_url":"https://avatars.githubusercontent.com/u/1759942?v=3","gravatar_id":"","url":"https://api.github.com/users/hunterwilliams","html_url":"https://github.com/hunterwilliams","followers_url":"https://api.github.com/users/hunterwilliams/followers","following_url":"https://api.github.com/users/hunterwilliams/following{/other_user}","gists_url":"https://api.github.com/users/hunterwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/hunterwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hunterwilliams/subscriptions","organizations_url":"https://api.github.com/users/hunterwilliams/orgs","repos_url":"https://api.github.com/users/hunterwilliams/repos","events_url":"https://api.github.com/users/hunterwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/hunterwilliams/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hunterwilliams/slush-marklogic-node","description":"Slush generator for a MarkLogic/node project","fork":true,"url":"https://api.github.com/repos/hunterwilliams/slush-marklogic-node","forks_url":"https://api.github.com/repos/hunterwilliams/slush-marklogic-node/forks","keys_url":"https://api.github.com/repos/hunterwilliams/slush-marklogic-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hunterwilliams/slush-marklogic-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hunterwilliams/slush-marklogic-node/teams","hooks_url":"https://api.github.com/repos/hunterwilliams/slush-marklogic-node/hooks","issue_events_url":"https://api.github.com/repos/hunterwilliams/slush-marklogic-node/issues/events{/number}","events_url":"https://api.github.com/repos/hunterwilliams/slush-marklogic-node/events","assignees_url":"https://api.github.com/repos/hunterwilliams/slush-marklogic-node/assignees{/user}","branches_url":"https://api.github.com/repos/hunterwilliams/slush-marklogic-node/branches{/branch}","tags_url":"https://api.github.com/repos/hunterwilliams/slush-marklogic-node/tags","blobs_url":"https://api.github.com/repos/hunterwilliams/slush-marklogic-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hunterwilliams/slush-marklogic-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hunterwilliams/slush-marklogic-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/hunterwilliams/slush-marklogic-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hunterwilliams/slush-marklogic-node/statuses/{sha}","languages_url":"https://api.github.com/repos/hunterwilliams/slush-marklogic-node/languages","stargazers_url":"https://api.github.com/repos/hunterwilliams/slush-marklogic-node/stargazers","contributors_url":"https://api.github.com/repos/hunterwilliams/slush-marklogic-node/contributors","subscribers_url":"https://api.github.com/repos/hunterwilliams/slush-marklogic-node/subscribers","subscription_url":"https://api.github.com/repos/hunterwilliams/slush-marklogic-node/subscription","commits_url":"https://api.github.com/repos/hunterwilliams/slush-marklogic-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/hunterwilliams/slush-marklogic-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/hunterwilliams/slush-marklogic-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/hunterwilliams/slush-marklogic-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/hunterwilliams/slush-marklogic-node/contents/{+path}","compare_url":"https://api.github.com/repos/hunterwilliams/slush-marklogic-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hunterwilliams/slush-marklogic-node/merges","archive_url":"https://api.github.com/repos/hunterwilliams/slush-marklogic-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hunterwilliams/slush-marklogic-node/downloads","issues_url":"https://api.github.com/repos/hunterwilliams/slush-marklogic-node/issues{/number}","pulls_url":"https://api.github.com/repos/hunterwilliams/slush-marklogic-node/pulls{/number}","milestones_url":"https://api.github.com/repos/hunterwilliams/slush-marklogic-node/milestones{/number}","notifications_url":"https://api.github.com/repos/hunterwilliams/slush-marklogic-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hunterwilliams/slush-marklogic-node/labels{/name}","releases_url":"https://api.github.com/repos/hunterwilliams/slush-marklogic-node/releases{/id}","created_at":"2015-08-06T01:07:44Z","updated_at":"2015-08-06T01:07:44Z","pushed_at":"2015-09-07T14:22:55Z","git_url":"git://github.com/hunterwilliams/slush-marklogic-node.git","ssh_url":"git@github.com:hunterwilliams/slush-marklogic-node.git","clone_url":"https://github.com/hunterwilliams/slush-marklogic-node.git","svn_url":"https://github.com/hunterwilliams/slush-marklogic-node","homepage":null,"size":1149,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"marklogic:master","ref":"master","sha":"a4702d5ff494dfb0ca13912685db835de732bbd0","user":{"login":"marklogic","id":189902,"avatar_url":"https://avatars.githubusercontent.com/u/189902?v=3","gravatar_id":"","url":"https://api.github.com/users/marklogic","html_url":"https://github.com/marklogic","followers_url":"https://api.github.com/users/marklogic/followers","following_url":"https://api.github.com/users/marklogic/following{/other_user}","gists_url":"https://api.github.com/users/marklogic/gists{/gist_id}","starred_url":"https://api.github.com/users/marklogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marklogic/subscriptions","organizations_url":"https://api.github.com/users/marklogic/orgs","repos_url":"https://api.github.com/users/marklogic/repos","events_url":"https://api.github.com/users/marklogic/events{/privacy}","received_events_url":"https://api.github.com/users/marklogic/received_events","type":"Organization","site_admin":false},"repo":{"id":19721399,"name":"slush-marklogic-node","full_name":"marklogic/slush-marklogic-node","owner":{"login":"marklogic","id":189902,"avatar_url":"https://avatars.githubusercontent.com/u/189902?v=3","gravatar_id":"","url":"https://api.github.com/users/marklogic","html_url":"https://github.com/marklogic","followers_url":"https://api.github.com/users/marklogic/followers","following_url":"https://api.github.com/users/marklogic/following{/other_user}","gists_url":"https://api.github.com/users/marklogic/gists{/gist_id}","starred_url":"https://api.github.com/users/marklogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marklogic/subscriptions","organizations_url":"https://api.github.com/users/marklogic/orgs","repos_url":"https://api.github.com/users/marklogic/repos","events_url":"https://api.github.com/users/marklogic/events{/privacy}","received_events_url":"https://api.github.com/users/marklogic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/marklogic/slush-marklogic-node","description":"Slush generator for a MarkLogic/node project","fork":false,"url":"https://api.github.com/repos/marklogic/slush-marklogic-node","forks_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/forks","keys_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/teams","hooks_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/hooks","issue_events_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/issues/events{/number}","events_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/events","assignees_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/assignees{/user}","branches_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/branches{/branch}","tags_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/tags","blobs_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/statuses/{sha}","languages_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/languages","stargazers_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/stargazers","contributors_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/contributors","subscribers_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/subscribers","subscription_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/subscription","commits_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/contents/{+path}","compare_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/merges","archive_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/downloads","issues_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/issues{/number}","pulls_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/pulls{/number}","milestones_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/milestones{/number}","notifications_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/labels{/name}","releases_url":"https://api.github.com/repos/marklogic/slush-marklogic-node/releases{/id}","created_at":"2014-05-13T01:17:26Z","updated_at":"2015-08-31T14:57:36Z","pushed_at":"2015-09-07T14:22:55Z","git_url":"git://github.com/marklogic/slush-marklogic-node.git","ssh_url":"git@github.com:marklogic/slush-marklogic-node.git","clone_url":"https://github.com/marklogic/slush-marklogic-node.git","svn_url":"https://github.com/marklogic/slush-marklogic-node","homepage":null,"size":2108,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":54,"forks":20,"open_issues":54,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/marklogic/slush-marklogic-node/pulls/168"},"html":{"href":"https://github.com/marklogic/slush-marklogic-node/pull/168"},"issue":{"href":"https://api.github.com/repos/marklogic/slush-marklogic-node/issues/168"},"comments":{"href":"https://api.github.com/repos/marklogic/slush-marklogic-node/issues/168/comments"},"review_comments":{"href":"https://api.github.com/repos/marklogic/slush-marklogic-node/pulls/168/comments"},"review_comment":{"href":"https://api.github.com/repos/marklogic/slush-marklogic-node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/marklogic/slush-marklogic-node/pulls/168/commits"},"statuses":{"href":"https://api.github.com/repos/marklogic/slush-marklogic-node/statuses/95731097841e55e3b211aab936d920d41b0c054b"}}}}