{"action":"created","comment":{"url":"https://api.github.com/repos/matteofigus/api-benchmark/pulls/comments/32075839","id":32075839,"diff_hunk":"@@ -8,27 +8,29 @@ module.exports = {\n   make: function(req, suite, suiteName, requestAgent, callback){\n     requestAgent.make(req, function(err, response){\n \n+      var res = {","path":"lib/request-handler.js","position":4,"original_position":4,"commit_id":"053503b3c7cdcb615d5c8ef67d2b59872787d752","original_commit_id":"053503b3c7cdcb615d5c8ef67d2b59872787d752","user":{"login":"matteofigus","id":1789893,"avatar_url":"https://avatars.githubusercontent.com/u/1789893?v=3","gravatar_id":"","url":"https://api.github.com/users/matteofigus","html_url":"https://github.com/matteofigus","followers_url":"https://api.github.com/users/matteofigus/followers","following_url":"https://api.github.com/users/matteofigus/following{/other_user}","gists_url":"https://api.github.com/users/matteofigus/gists{/gist_id}","starred_url":"https://api.github.com/users/matteofigus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matteofigus/subscriptions","organizations_url":"https://api.github.com/users/matteofigus/orgs","repos_url":"https://api.github.com/users/matteofigus/repos","events_url":"https://api.github.com/users/matteofigus/events{/privacy}","received_events_url":"https://api.github.com/users/matteofigus/received_events","type":"User","site_admin":false},"body":"I would check if response is null here.\r\n```js\r\nvar res = !!response ? { ...} : false;\r\n```","created_at":"2015-06-09T23:27:46Z","updated_at":"2015-06-09T23:27:46Z","html_url":"https://github.com/matteofigus/api-benchmark/pull/21#discussion_r32075839","pull_request_url":"https://api.github.com/repos/matteofigus/api-benchmark/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/matteofigus/api-benchmark/pulls/comments/32075839"},"html":{"href":"https://github.com/matteofigus/api-benchmark/pull/21#discussion_r32075839"},"pull_request":{"href":"https://api.github.com/repos/matteofigus/api-benchmark/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/matteofigus/api-benchmark/pulls/21","id":37310298,"html_url":"https://github.com/matteofigus/api-benchmark/pull/21","diff_url":"https://github.com/matteofigus/api-benchmark/pull/21.diff","patch_url":"https://github.com/matteofigus/api-benchmark/pull/21.patch","issue_url":"https://api.github.com/repos/matteofigus/api-benchmark/issues/21","number":21,"state":"open","locked":false,"title":"Fixed responses for request errors in benchmarks","user":{"login":"dmyers","id":207171,"avatar_url":"https://avatars.githubusercontent.com/u/207171?v=3","gravatar_id":"","url":"https://api.github.com/users/dmyers","html_url":"https://github.com/dmyers","followers_url":"https://api.github.com/users/dmyers/followers","following_url":"https://api.github.com/users/dmyers/following{/other_user}","gists_url":"https://api.github.com/users/dmyers/gists{/gist_id}","starred_url":"https://api.github.com/users/dmyers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmyers/subscriptions","organizations_url":"https://api.github.com/users/dmyers/orgs","repos_url":"https://api.github.com/users/dmyers/repos","events_url":"https://api.github.com/users/dmyers/events{/privacy}","received_events_url":"https://api.github.com/users/dmyers/received_events","type":"User","site_admin":false},"body":"Played around with this today. This fixes #20 with any error with requests like status code or mean times.\r\n\r\nDoes this look good @matteofigus?","created_at":"2015-06-09T23:13:28Z","updated_at":"2015-06-09T23:27:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"505552d3536fc3074c06d4aef66cc44c38d89c55","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/matteofigus/api-benchmark/pulls/21/commits","review_comments_url":"https://api.github.com/repos/matteofigus/api-benchmark/pulls/21/comments","review_comment_url":"https://api.github.com/repos/matteofigus/api-benchmark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matteofigus/api-benchmark/issues/21/comments","statuses_url":"https://api.github.com/repos/matteofigus/api-benchmark/statuses/053503b3c7cdcb615d5c8ef67d2b59872787d752","head":{"label":"dmyers:error-response","ref":"error-response","sha":"053503b3c7cdcb615d5c8ef67d2b59872787d752","user":{"login":"dmyers","id":207171,"avatar_url":"https://avatars.githubusercontent.com/u/207171?v=3","gravatar_id":"","url":"https://api.github.com/users/dmyers","html_url":"https://github.com/dmyers","followers_url":"https://api.github.com/users/dmyers/followers","following_url":"https://api.github.com/users/dmyers/following{/other_user}","gists_url":"https://api.github.com/users/dmyers/gists{/gist_id}","starred_url":"https://api.github.com/users/dmyers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmyers/subscriptions","organizations_url":"https://api.github.com/users/dmyers/orgs","repos_url":"https://api.github.com/users/dmyers/repos","events_url":"https://api.github.com/users/dmyers/events{/privacy}","received_events_url":"https://api.github.com/users/dmyers/received_events","type":"User","site_admin":false},"repo":{"id":34816898,"name":"api-benchmark","full_name":"dmyers/api-benchmark","owner":{"login":"dmyers","id":207171,"avatar_url":"https://avatars.githubusercontent.com/u/207171?v=3","gravatar_id":"","url":"https://api.github.com/users/dmyers","html_url":"https://github.com/dmyers","followers_url":"https://api.github.com/users/dmyers/followers","following_url":"https://api.github.com/users/dmyers/following{/other_user}","gists_url":"https://api.github.com/users/dmyers/gists{/gist_id}","starred_url":"https://api.github.com/users/dmyers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmyers/subscriptions","organizations_url":"https://api.github.com/users/dmyers/orgs","repos_url":"https://api.github.com/users/dmyers/repos","events_url":"https://api.github.com/users/dmyers/events{/privacy}","received_events_url":"https://api.github.com/users/dmyers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmyers/api-benchmark","description":"A simple node.js tool to measure and compare performances of api services","fork":true,"url":"https://api.github.com/repos/dmyers/api-benchmark","forks_url":"https://api.github.com/repos/dmyers/api-benchmark/forks","keys_url":"https://api.github.com/repos/dmyers/api-benchmark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmyers/api-benchmark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmyers/api-benchmark/teams","hooks_url":"https://api.github.com/repos/dmyers/api-benchmark/hooks","issue_events_url":"https://api.github.com/repos/dmyers/api-benchmark/issues/events{/number}","events_url":"https://api.github.com/repos/dmyers/api-benchmark/events","assignees_url":"https://api.github.com/repos/dmyers/api-benchmark/assignees{/user}","branches_url":"https://api.github.com/repos/dmyers/api-benchmark/branches{/branch}","tags_url":"https://api.github.com/repos/dmyers/api-benchmark/tags","blobs_url":"https://api.github.com/repos/dmyers/api-benchmark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmyers/api-benchmark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmyers/api-benchmark/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmyers/api-benchmark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmyers/api-benchmark/statuses/{sha}","languages_url":"https://api.github.com/repos/dmyers/api-benchmark/languages","stargazers_url":"https://api.github.com/repos/dmyers/api-benchmark/stargazers","contributors_url":"https://api.github.com/repos/dmyers/api-benchmark/contributors","subscribers_url":"https://api.github.com/repos/dmyers/api-benchmark/subscribers","subscription_url":"https://api.github.com/repos/dmyers/api-benchmark/subscription","commits_url":"https://api.github.com/repos/dmyers/api-benchmark/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmyers/api-benchmark/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmyers/api-benchmark/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmyers/api-benchmark/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmyers/api-benchmark/contents/{+path}","compare_url":"https://api.github.com/repos/dmyers/api-benchmark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmyers/api-benchmark/merges","archive_url":"https://api.github.com/repos/dmyers/api-benchmark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmyers/api-benchmark/downloads","issues_url":"https://api.github.com/repos/dmyers/api-benchmark/issues{/number}","pulls_url":"https://api.github.com/repos/dmyers/api-benchmark/pulls{/number}","milestones_url":"https://api.github.com/repos/dmyers/api-benchmark/milestones{/number}","notifications_url":"https://api.github.com/repos/dmyers/api-benchmark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmyers/api-benchmark/labels{/name}","releases_url":"https://api.github.com/repos/dmyers/api-benchmark/releases{/id}","created_at":"2015-04-29T20:34:27Z","updated_at":"2015-04-29T20:34:28Z","pushed_at":"2015-06-09T23:16:52Z","git_url":"git://github.com/dmyers/api-benchmark.git","ssh_url":"git@github.com:dmyers/api-benchmark.git","clone_url":"https://github.com/dmyers/api-benchmark.git","svn_url":"https://github.com/dmyers/api-benchmark","homepage":"http://www.api-benchmark.com","size":277,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"matteofigus:master","ref":"master","sha":"4339a72c769c89d73c3df1c0335fc8842e8702c6","user":{"login":"matteofigus","id":1789893,"avatar_url":"https://avatars.githubusercontent.com/u/1789893?v=3","gravatar_id":"","url":"https://api.github.com/users/matteofigus","html_url":"https://github.com/matteofigus","followers_url":"https://api.github.com/users/matteofigus/followers","following_url":"https://api.github.com/users/matteofigus/following{/other_user}","gists_url":"https://api.github.com/users/matteofigus/gists{/gist_id}","starred_url":"https://api.github.com/users/matteofigus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matteofigus/subscriptions","organizations_url":"https://api.github.com/users/matteofigus/orgs","repos_url":"https://api.github.com/users/matteofigus/repos","events_url":"https://api.github.com/users/matteofigus/events{/privacy}","received_events_url":"https://api.github.com/users/matteofigus/received_events","type":"User","site_admin":false},"repo":{"id":12362873,"name":"api-benchmark","full_name":"matteofigus/api-benchmark","owner":{"login":"matteofigus","id":1789893,"avatar_url":"https://avatars.githubusercontent.com/u/1789893?v=3","gravatar_id":"","url":"https://api.github.com/users/matteofigus","html_url":"https://github.com/matteofigus","followers_url":"https://api.github.com/users/matteofigus/followers","following_url":"https://api.github.com/users/matteofigus/following{/other_user}","gists_url":"https://api.github.com/users/matteofigus/gists{/gist_id}","starred_url":"https://api.github.com/users/matteofigus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matteofigus/subscriptions","organizations_url":"https://api.github.com/users/matteofigus/orgs","repos_url":"https://api.github.com/users/matteofigus/repos","events_url":"https://api.github.com/users/matteofigus/events{/privacy}","received_events_url":"https://api.github.com/users/matteofigus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matteofigus/api-benchmark","description":"A simple node.js tool to measure and compare performances of api services","fork":false,"url":"https://api.github.com/repos/matteofigus/api-benchmark","forks_url":"https://api.github.com/repos/matteofigus/api-benchmark/forks","keys_url":"https://api.github.com/repos/matteofigus/api-benchmark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matteofigus/api-benchmark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matteofigus/api-benchmark/teams","hooks_url":"https://api.github.com/repos/matteofigus/api-benchmark/hooks","issue_events_url":"https://api.github.com/repos/matteofigus/api-benchmark/issues/events{/number}","events_url":"https://api.github.com/repos/matteofigus/api-benchmark/events","assignees_url":"https://api.github.com/repos/matteofigus/api-benchmark/assignees{/user}","branches_url":"https://api.github.com/repos/matteofigus/api-benchmark/branches{/branch}","tags_url":"https://api.github.com/repos/matteofigus/api-benchmark/tags","blobs_url":"https://api.github.com/repos/matteofigus/api-benchmark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matteofigus/api-benchmark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matteofigus/api-benchmark/git/refs{/sha}","trees_url":"https://api.github.com/repos/matteofigus/api-benchmark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matteofigus/api-benchmark/statuses/{sha}","languages_url":"https://api.github.com/repos/matteofigus/api-benchmark/languages","stargazers_url":"https://api.github.com/repos/matteofigus/api-benchmark/stargazers","contributors_url":"https://api.github.com/repos/matteofigus/api-benchmark/contributors","subscribers_url":"https://api.github.com/repos/matteofigus/api-benchmark/subscribers","subscription_url":"https://api.github.com/repos/matteofigus/api-benchmark/subscription","commits_url":"https://api.github.com/repos/matteofigus/api-benchmark/commits{/sha}","git_commits_url":"https://api.github.com/repos/matteofigus/api-benchmark/git/commits{/sha}","comments_url":"https://api.github.com/repos/matteofigus/api-benchmark/comments{/number}","issue_comment_url":"https://api.github.com/repos/matteofigus/api-benchmark/issues/comments{/number}","contents_url":"https://api.github.com/repos/matteofigus/api-benchmark/contents/{+path}","compare_url":"https://api.github.com/repos/matteofigus/api-benchmark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matteofigus/api-benchmark/merges","archive_url":"https://api.github.com/repos/matteofigus/api-benchmark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matteofigus/api-benchmark/downloads","issues_url":"https://api.github.com/repos/matteofigus/api-benchmark/issues{/number}","pulls_url":"https://api.github.com/repos/matteofigus/api-benchmark/pulls{/number}","milestones_url":"https://api.github.com/repos/matteofigus/api-benchmark/milestones{/number}","notifications_url":"https://api.github.com/repos/matteofigus/api-benchmark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matteofigus/api-benchmark/labels{/name}","releases_url":"https://api.github.com/repos/matteofigus/api-benchmark/releases{/id}","created_at":"2013-08-25T17:39:05Z","updated_at":"2015-05-12T19:13:40Z","pushed_at":"2015-06-09T23:16:53Z","git_url":"git://github.com/matteofigus/api-benchmark.git","ssh_url":"git@github.com:matteofigus/api-benchmark.git","clone_url":"https://github.com/matteofigus/api-benchmark.git","svn_url":"https://github.com/matteofigus/api-benchmark","homepage":"http://www.api-benchmark.com","size":906,"stargazers_count":88,"watchers_count":88,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":7,"forks":11,"open_issues":7,"watchers":88,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matteofigus/api-benchmark/pulls/21"},"html":{"href":"https://github.com/matteofigus/api-benchmark/pull/21"},"issue":{"href":"https://api.github.com/repos/matteofigus/api-benchmark/issues/21"},"comments":{"href":"https://api.github.com/repos/matteofigus/api-benchmark/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/matteofigus/api-benchmark/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/matteofigus/api-benchmark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matteofigus/api-benchmark/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/matteofigus/api-benchmark/statuses/053503b3c7cdcb615d5c8ef67d2b59872787d752"}}}}