{"action":"created","issue":{"url":"https://api.github.com/repos/Open-Future-Belgium/PostgreSQL/issues/41","labels_url":"https://api.github.com/repos/Open-Future-Belgium/PostgreSQL/issues/41/labels{/name}","comments_url":"https://api.github.com/repos/Open-Future-Belgium/PostgreSQL/issues/41/comments","events_url":"https://api.github.com/repos/Open-Future-Belgium/PostgreSQL/issues/41/events","html_url":"https://github.com/Open-Future-Belgium/PostgreSQL/issues/41","id":115033209,"number":41,"title":"[feature] Avoid unnecessary restart when postgresql.conf changes","user":{"login":"willthames","id":391807,"avatar_url":"https://avatars.githubusercontent.com/u/391807?v=3","gravatar_id":"","url":"https://api.github.com/users/willthames","html_url":"https://github.com/willthames","followers_url":"https://api.github.com/users/willthames/followers","following_url":"https://api.github.com/users/willthames/following{/other_user}","gists_url":"https://api.github.com/users/willthames/gists{/gist_id}","starred_url":"https://api.github.com/users/willthames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willthames/subscriptions","organizations_url":"https://api.github.com/users/willthames/orgs","repos_url":"https://api.github.com/users/willthames/repos","events_url":"https://api.github.com/users/willthames/events{/privacy}","received_events_url":"https://api.github.com/users/willthames/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-04T11:30:23Z","updated_at":"2015-11-06T14:36:55Z","closed_at":null,"body":"Most postgresql.conf changes don't need a restart, just a reload. And a reload is much safer.\r\n\r\nTo avoid a restart except where essential, there are a few approaches.\r\nOne is documented at http://www.postgresql.org/message-id/80920AC4-56A3-4E4F-9AF2-7E7A8635F0D2@redzonesoftware.com\r\n\r\nMy thought was to have postgresql.conf only include postgresql_needs_restart.conf and postgresql_needs_reload.conf. postgresql_needs_restart.conf would include the parameters mentioned in the above email thread.\r\n\r\nIf postgresql.conf or postgresql_needs_restart.conf changes, the restart postgresql handler is fired as now. But if postgresql_needs_reload.conf changes, a new reload postgresql handler is fired. \r\n\r\nI'm happy to implement this but thought I'd see what your thoughts were first on whether it's a sensible approach or if there's anything I've missed."},"comment":{"url":"https://api.github.com/repos/Open-Future-Belgium/PostgreSQL/issues/comments/154425205","html_url":"https://github.com/Open-Future-Belgium/PostgreSQL/issues/41#issuecomment-154425205","issue_url":"https://api.github.com/repos/Open-Future-Belgium/PostgreSQL/issues/41","id":154425205,"user":{"login":"Trikke76","id":5861107,"avatar_url":"https://avatars.githubusercontent.com/u/5861107?v=3","gravatar_id":"","url":"https://api.github.com/users/Trikke76","html_url":"https://github.com/Trikke76","followers_url":"https://api.github.com/users/Trikke76/followers","following_url":"https://api.github.com/users/Trikke76/following{/other_user}","gists_url":"https://api.github.com/users/Trikke76/gists{/gist_id}","starred_url":"https://api.github.com/users/Trikke76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trikke76/subscriptions","organizations_url":"https://api.github.com/users/Trikke76/orgs","repos_url":"https://api.github.com/users/Trikke76/repos","events_url":"https://api.github.com/users/Trikke76/events{/privacy}","received_events_url":"https://api.github.com/users/Trikke76/received_events","type":"User","site_admin":false},"created_at":"2015-11-06T14:36:55Z","updated_at":"2015-11-06T14:36:55Z","body":"It will ask a bit of implementation but would indeed be a great addition to the rule imho.\r\nI don't know what others are thinking about this but for me it looks awesome\r\nnext week i'm rather busy but after that i could probably help implementing this rule if you want some help on this.\r\n\r\nAnyone else any toughts ? maybe on negative impacts it might have that i am missing ?"}}