{"action":"created","comment":{"url":"https://api.github.com/repos/yesodweb/authenticate/pulls/comments/24309447","id":24309447,"diff_hunk":"@@ -355,12 +375,21 @@ injectOAuthToCred oa cred =\n             ] cred\n \n \n+-- Note that prefix is used for realm in addAuthHeader, so should fix that up,\n+-- but may need an API break for that.\n+addAuthBody :: BS.ByteString -> Credential -> Request -> Request\n+addAuthBody _ (Credential cred) req = urlEncodedBody (filterCreds cred) req","path":"authenticate-oauth/Web/Authenticate/OAuth.hs","position":83,"original_position":83,"commit_id":"fbb89bbbfa1784366e2c32197efc99804b5c404f","original_commit_id":"fbb89bbbfa1784366e2c32197efc99804b5c404f","user":{"login":"snoyberg","id":49415,"avatar_url":"https://avatars.githubusercontent.com/u/49415?v=3","gravatar_id":"","url":"https://api.github.com/users/snoyberg","html_url":"https://github.com/snoyberg","followers_url":"https://api.github.com/users/snoyberg/followers","following_url":"https://api.github.com/users/snoyberg/following{/other_user}","gists_url":"https://api.github.com/users/snoyberg/gists{/gist_id}","starred_url":"https://api.github.com/users/snoyberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snoyberg/subscriptions","organizations_url":"https://api.github.com/users/snoyberg/orgs","repos_url":"https://api.github.com/users/snoyberg/repos","events_url":"https://api.github.com/users/snoyberg/events{/privacy}","received_events_url":"https://api.github.com/users/snoyberg/received_events","type":"User","site_admin":false},"body":"I'm still not following what the motivation is, or what the question is. Why not just leave off that parameter if it's not used?","created_at":"2015-02-09T05:20:41Z","updated_at":"2015-02-09T05:20:41Z","html_url":"https://github.com/yesodweb/authenticate/pull/42#discussion_r24309447","pull_request_url":"https://api.github.com/repos/yesodweb/authenticate/pulls/42","_links":{"self":{"href":"https://api.github.com/repos/yesodweb/authenticate/pulls/comments/24309447"},"html":{"href":"https://github.com/yesodweb/authenticate/pull/42#discussion_r24309447"},"pull_request":{"href":"https://api.github.com/repos/yesodweb/authenticate/pulls/42"}}},"pull_request":{"url":"https://api.github.com/repos/yesodweb/authenticate/pulls/42","id":28607845,"html_url":"https://github.com/yesodweb/authenticate/pull/42","diff_url":"https://github.com/yesodweb/authenticate/pull/42.diff","patch_url":"https://github.com/yesodweb/authenticate/pull/42.patch","issue_url":"https://api.github.com/repos/yesodweb/authenticate/issues/42","number":42,"state":"open","locked":false,"title":"Permit different ways of signing token requests","user":{"login":"rbtcollins","id":499678,"avatar_url":"https://avatars.githubusercontent.com/u/499678?v=3","gravatar_id":"","url":"https://api.github.com/users/rbtcollins","html_url":"https://github.com/rbtcollins","followers_url":"https://api.github.com/users/rbtcollins/followers","following_url":"https://api.github.com/users/rbtcollins/following{/other_user}","gists_url":"https://api.github.com/users/rbtcollins/gists{/gist_id}","starred_url":"https://api.github.com/users/rbtcollins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbtcollins/subscriptions","organizations_url":"https://api.github.com/users/rbtcollins/orgs","repos_url":"https://api.github.com/users/rbtcollins/repos","events_url":"https://api.github.com/users/rbtcollins/events{/privacy}","received_events_url":"https://api.github.com/users/rbtcollins/received_events","type":"User","site_admin":false},"body":"Some sites (e.g. https://launchpad.net) don't accept access token\r\nrequests with Authorization headers, instead requiring that request to\r\nbe submitted via a URL encoded body.","created_at":"2015-02-04T02:08:52Z","updated_at":"2015-02-09T05:20:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4901d351a5c86175621a09a880116e9551e732d4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yesodweb/authenticate/pulls/42/commits","review_comments_url":"https://api.github.com/repos/yesodweb/authenticate/pulls/42/comments","review_comment_url":"https://api.github.com/repos/yesodweb/authenticate/pulls/comments/{number}","comments_url":"https://api.github.com/repos/yesodweb/authenticate/issues/42/comments","statuses_url":"https://api.github.com/repos/yesodweb/authenticate/statuses/fbb89bbbfa1784366e2c32197efc99804b5c404f","head":{"label":"rbtcollins:master","ref":"master","sha":"fbb89bbbfa1784366e2c32197efc99804b5c404f","user":{"login":"rbtcollins","id":499678,"avatar_url":"https://avatars.githubusercontent.com/u/499678?v=3","gravatar_id":"","url":"https://api.github.com/users/rbtcollins","html_url":"https://github.com/rbtcollins","followers_url":"https://api.github.com/users/rbtcollins/followers","following_url":"https://api.github.com/users/rbtcollins/following{/other_user}","gists_url":"https://api.github.com/users/rbtcollins/gists{/gist_id}","starred_url":"https://api.github.com/users/rbtcollins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbtcollins/subscriptions","organizations_url":"https://api.github.com/users/rbtcollins/orgs","repos_url":"https://api.github.com/users/rbtcollins/repos","events_url":"https://api.github.com/users/rbtcollins/events{/privacy}","received_events_url":"https://api.github.com/users/rbtcollins/received_events","type":"User","site_admin":false},"repo":{"id":30162388,"name":"authenticate","full_name":"rbtcollins/authenticate","owner":{"login":"rbtcollins","id":499678,"avatar_url":"https://avatars.githubusercontent.com/u/499678?v=3","gravatar_id":"","url":"https://api.github.com/users/rbtcollins","html_url":"https://github.com/rbtcollins","followers_url":"https://api.github.com/users/rbtcollins/followers","following_url":"https://api.github.com/users/rbtcollins/following{/other_user}","gists_url":"https://api.github.com/users/rbtcollins/gists{/gist_id}","starred_url":"https://api.github.com/users/rbtcollins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbtcollins/subscriptions","organizations_url":"https://api.github.com/users/rbtcollins/orgs","repos_url":"https://api.github.com/users/rbtcollins/repos","events_url":"https://api.github.com/users/rbtcollins/events{/privacy}","received_events_url":"https://api.github.com/users/rbtcollins/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rbtcollins/authenticate","description":"Authentication methods for Haskell web applications.","fork":true,"url":"https://api.github.com/repos/rbtcollins/authenticate","forks_url":"https://api.github.com/repos/rbtcollins/authenticate/forks","keys_url":"https://api.github.com/repos/rbtcollins/authenticate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rbtcollins/authenticate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rbtcollins/authenticate/teams","hooks_url":"https://api.github.com/repos/rbtcollins/authenticate/hooks","issue_events_url":"https://api.github.com/repos/rbtcollins/authenticate/issues/events{/number}","events_url":"https://api.github.com/repos/rbtcollins/authenticate/events","assignees_url":"https://api.github.com/repos/rbtcollins/authenticate/assignees{/user}","branches_url":"https://api.github.com/repos/rbtcollins/authenticate/branches{/branch}","tags_url":"https://api.github.com/repos/rbtcollins/authenticate/tags","blobs_url":"https://api.github.com/repos/rbtcollins/authenticate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rbtcollins/authenticate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rbtcollins/authenticate/git/refs{/sha}","trees_url":"https://api.github.com/repos/rbtcollins/authenticate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rbtcollins/authenticate/statuses/{sha}","languages_url":"https://api.github.com/repos/rbtcollins/authenticate/languages","stargazers_url":"https://api.github.com/repos/rbtcollins/authenticate/stargazers","contributors_url":"https://api.github.com/repos/rbtcollins/authenticate/contributors","subscribers_url":"https://api.github.com/repos/rbtcollins/authenticate/subscribers","subscription_url":"https://api.github.com/repos/rbtcollins/authenticate/subscription","commits_url":"https://api.github.com/repos/rbtcollins/authenticate/commits{/sha}","git_commits_url":"https://api.github.com/repos/rbtcollins/authenticate/git/commits{/sha}","comments_url":"https://api.github.com/repos/rbtcollins/authenticate/comments{/number}","issue_comment_url":"https://api.github.com/repos/rbtcollins/authenticate/issues/comments/{number}","contents_url":"https://api.github.com/repos/rbtcollins/authenticate/contents/{+path}","compare_url":"https://api.github.com/repos/rbtcollins/authenticate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rbtcollins/authenticate/merges","archive_url":"https://api.github.com/repos/rbtcollins/authenticate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rbtcollins/authenticate/downloads","issues_url":"https://api.github.com/repos/rbtcollins/authenticate/issues{/number}","pulls_url":"https://api.github.com/repos/rbtcollins/authenticate/pulls{/number}","milestones_url":"https://api.github.com/repos/rbtcollins/authenticate/milestones{/number}","notifications_url":"https://api.github.com/repos/rbtcollins/authenticate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rbtcollins/authenticate/labels{/name}","releases_url":"https://api.github.com/repos/rbtcollins/authenticate/releases{/id}","created_at":"2015-02-01T22:34:40Z","updated_at":"2015-02-04T02:38:56Z","pushed_at":"2015-02-04T02:38:56Z","git_url":"git://github.com/rbtcollins/authenticate.git","ssh_url":"git@github.com:rbtcollins/authenticate.git","clone_url":"https://github.com/rbtcollins/authenticate.git","svn_url":"https://github.com/rbtcollins/authenticate","homepage":"","size":303,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yesodweb:master","ref":"master","sha":"c9c783c1a134c40116adc8514e588e868bbda09d","user":{"login":"yesodweb","id":930379,"avatar_url":"https://avatars.githubusercontent.com/u/930379?v=3","gravatar_id":"","url":"https://api.github.com/users/yesodweb","html_url":"https://github.com/yesodweb","followers_url":"https://api.github.com/users/yesodweb/followers","following_url":"https://api.github.com/users/yesodweb/following{/other_user}","gists_url":"https://api.github.com/users/yesodweb/gists{/gist_id}","starred_url":"https://api.github.com/users/yesodweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yesodweb/subscriptions","organizations_url":"https://api.github.com/users/yesodweb/orgs","repos_url":"https://api.github.com/users/yesodweb/repos","events_url":"https://api.github.com/users/yesodweb/events{/privacy}","received_events_url":"https://api.github.com/users/yesodweb/received_events","type":"Organization","site_admin":false},"repo":{"id":2861387,"name":"authenticate","full_name":"yesodweb/authenticate","owner":{"login":"yesodweb","id":930379,"avatar_url":"https://avatars.githubusercontent.com/u/930379?v=3","gravatar_id":"","url":"https://api.github.com/users/yesodweb","html_url":"https://github.com/yesodweb","followers_url":"https://api.github.com/users/yesodweb/followers","following_url":"https://api.github.com/users/yesodweb/following{/other_user}","gists_url":"https://api.github.com/users/yesodweb/gists{/gist_id}","starred_url":"https://api.github.com/users/yesodweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yesodweb/subscriptions","organizations_url":"https://api.github.com/users/yesodweb/orgs","repos_url":"https://api.github.com/users/yesodweb/repos","events_url":"https://api.github.com/users/yesodweb/events{/privacy}","received_events_url":"https://api.github.com/users/yesodweb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yesodweb/authenticate","description":"Authentication methods for Haskell web applications.","fork":true,"url":"https://api.github.com/repos/yesodweb/authenticate","forks_url":"https://api.github.com/repos/yesodweb/authenticate/forks","keys_url":"https://api.github.com/repos/yesodweb/authenticate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yesodweb/authenticate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yesodweb/authenticate/teams","hooks_url":"https://api.github.com/repos/yesodweb/authenticate/hooks","issue_events_url":"https://api.github.com/repos/yesodweb/authenticate/issues/events{/number}","events_url":"https://api.github.com/repos/yesodweb/authenticate/events","assignees_url":"https://api.github.com/repos/yesodweb/authenticate/assignees{/user}","branches_url":"https://api.github.com/repos/yesodweb/authenticate/branches{/branch}","tags_url":"https://api.github.com/repos/yesodweb/authenticate/tags","blobs_url":"https://api.github.com/repos/yesodweb/authenticate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yesodweb/authenticate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yesodweb/authenticate/git/refs{/sha}","trees_url":"https://api.github.com/repos/yesodweb/authenticate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yesodweb/authenticate/statuses/{sha}","languages_url":"https://api.github.com/repos/yesodweb/authenticate/languages","stargazers_url":"https://api.github.com/repos/yesodweb/authenticate/stargazers","contributors_url":"https://api.github.com/repos/yesodweb/authenticate/contributors","subscribers_url":"https://api.github.com/repos/yesodweb/authenticate/subscribers","subscription_url":"https://api.github.com/repos/yesodweb/authenticate/subscription","commits_url":"https://api.github.com/repos/yesodweb/authenticate/commits{/sha}","git_commits_url":"https://api.github.com/repos/yesodweb/authenticate/git/commits{/sha}","comments_url":"https://api.github.com/repos/yesodweb/authenticate/comments{/number}","issue_comment_url":"https://api.github.com/repos/yesodweb/authenticate/issues/comments/{number}","contents_url":"https://api.github.com/repos/yesodweb/authenticate/contents/{+path}","compare_url":"https://api.github.com/repos/yesodweb/authenticate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yesodweb/authenticate/merges","archive_url":"https://api.github.com/repos/yesodweb/authenticate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yesodweb/authenticate/downloads","issues_url":"https://api.github.com/repos/yesodweb/authenticate/issues{/number}","pulls_url":"https://api.github.com/repos/yesodweb/authenticate/pulls{/number}","milestones_url":"https://api.github.com/repos/yesodweb/authenticate/milestones{/number}","notifications_url":"https://api.github.com/repos/yesodweb/authenticate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yesodweb/authenticate/labels{/name}","releases_url":"https://api.github.com/repos/yesodweb/authenticate/releases{/id}","created_at":"2011-11-27T15:23:57Z","updated_at":"2015-02-07T10:22:51Z","pushed_at":"2015-01-21T21:53:03Z","git_url":"git://github.com/yesodweb/authenticate.git","ssh_url":"git@github.com:yesodweb/authenticate.git","clone_url":"https://github.com/yesodweb/authenticate.git","svn_url":"https://github.com/yesodweb/authenticate","homepage":"","size":512,"stargazers_count":20,"watchers_count":20,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":6,"forks":20,"open_issues":6,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yesodweb/authenticate/pulls/42"},"html":{"href":"https://github.com/yesodweb/authenticate/pull/42"},"issue":{"href":"https://api.github.com/repos/yesodweb/authenticate/issues/42"},"comments":{"href":"https://api.github.com/repos/yesodweb/authenticate/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/yesodweb/authenticate/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/yesodweb/authenticate/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/yesodweb/authenticate/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/yesodweb/authenticate/statuses/fbb89bbbfa1784366e2c32197efc99804b5c404f"}}}}