{"action":"closed","number":11,"pull_request":{"url":"https://api.github.com/repos/hmrc/domain/pulls/11","id":44095312,"html_url":"https://github.com/hmrc/domain/pull/11","diff_url":"https://github.com/hmrc/domain/pull/11.diff","patch_url":"https://github.com/hmrc/domain/pull/11.patch","issue_url":"https://api.github.com/repos/hmrc/domain/issues/11","number":11,"state":"closed","locked":false,"title":"Support suffix-less NINOs","user":{"login":"howyp","id":4593903,"avatar_url":"https://avatars.githubusercontent.com/u/4593903?v=3","gravatar_id":"","url":"https://api.github.com/users/howyp","html_url":"https://github.com/howyp","followers_url":"https://api.github.com/users/howyp/followers","following_url":"https://api.github.com/users/howyp/following{/other_user}","gists_url":"https://api.github.com/users/howyp/gists{/gist_id}","starred_url":"https://api.github.com/users/howyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howyp/subscriptions","organizations_url":"https://api.github.com/users/howyp/orgs","repos_url":"https://api.github.com/users/howyp/repos","events_url":"https://api.github.com/users/howyp/events{/privacy}","received_events_url":"https://api.github.com/users/howyp/received_events","type":"User","site_admin":false},"body":"This PR adds support for handling of suffix-less NINOs (those missing the last character). \r\n\r\nThe `Nino` class has been replaced with `SuffixedNino`, and `ShortNino` has been added to cater for the situation where the suffix is not present. \r\n\r\n`ShortOrSuffixedNino` is a type which represents a NINO with or without a suffix.","created_at":"2015-09-03T11:24:15Z","updated_at":"2015-09-04T11:06:50Z","closed_at":"2015-09-04T11:06:50Z","merged_at":null,"merge_commit_sha":"53d01ac804bdd088fe52df05813ece70c5958291","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hmrc/domain/pulls/11/commits","review_comments_url":"https://api.github.com/repos/hmrc/domain/pulls/11/comments","review_comment_url":"https://api.github.com/repos/hmrc/domain/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmrc/domain/issues/11/comments","statuses_url":"https://api.github.com/repos/hmrc/domain/statuses/d212c9576df21e1dd2dbb0e8c3a466b707d39d27","head":{"label":"howyp:nino-v2","ref":"nino-v2","sha":"d212c9576df21e1dd2dbb0e8c3a466b707d39d27","user":{"login":"howyp","id":4593903,"avatar_url":"https://avatars.githubusercontent.com/u/4593903?v=3","gravatar_id":"","url":"https://api.github.com/users/howyp","html_url":"https://github.com/howyp","followers_url":"https://api.github.com/users/howyp/followers","following_url":"https://api.github.com/users/howyp/following{/other_user}","gists_url":"https://api.github.com/users/howyp/gists{/gist_id}","starred_url":"https://api.github.com/users/howyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howyp/subscriptions","organizations_url":"https://api.github.com/users/howyp/orgs","repos_url":"https://api.github.com/users/howyp/repos","events_url":"https://api.github.com/users/howyp/events{/privacy}","received_events_url":"https://api.github.com/users/howyp/received_events","type":"User","site_admin":false},"repo":{"id":41810209,"name":"domain","full_name":"howyp/domain","owner":{"login":"howyp","id":4593903,"avatar_url":"https://avatars.githubusercontent.com/u/4593903?v=3","gravatar_id":"","url":"https://api.github.com/users/howyp","html_url":"https://github.com/howyp","followers_url":"https://api.github.com/users/howyp/followers","following_url":"https://api.github.com/users/howyp/following{/other_user}","gists_url":"https://api.github.com/users/howyp/gists{/gist_id}","starred_url":"https://api.github.com/users/howyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howyp/subscriptions","organizations_url":"https://api.github.com/users/howyp/orgs","repos_url":"https://api.github.com/users/howyp/repos","events_url":"https://api.github.com/users/howyp/events{/privacy}","received_events_url":"https://api.github.com/users/howyp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/howyp/domain","description":"Micro-library for typing and validating UK tax identifiers","fork":true,"url":"https://api.github.com/repos/howyp/domain","forks_url":"https://api.github.com/repos/howyp/domain/forks","keys_url":"https://api.github.com/repos/howyp/domain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/howyp/domain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/howyp/domain/teams","hooks_url":"https://api.github.com/repos/howyp/domain/hooks","issue_events_url":"https://api.github.com/repos/howyp/domain/issues/events{/number}","events_url":"https://api.github.com/repos/howyp/domain/events","assignees_url":"https://api.github.com/repos/howyp/domain/assignees{/user}","branches_url":"https://api.github.com/repos/howyp/domain/branches{/branch}","tags_url":"https://api.github.com/repos/howyp/domain/tags","blobs_url":"https://api.github.com/repos/howyp/domain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/howyp/domain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/howyp/domain/git/refs{/sha}","trees_url":"https://api.github.com/repos/howyp/domain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/howyp/domain/statuses/{sha}","languages_url":"https://api.github.com/repos/howyp/domain/languages","stargazers_url":"https://api.github.com/repos/howyp/domain/stargazers","contributors_url":"https://api.github.com/repos/howyp/domain/contributors","subscribers_url":"https://api.github.com/repos/howyp/domain/subscribers","subscription_url":"https://api.github.com/repos/howyp/domain/subscription","commits_url":"https://api.github.com/repos/howyp/domain/commits{/sha}","git_commits_url":"https://api.github.com/repos/howyp/domain/git/commits{/sha}","comments_url":"https://api.github.com/repos/howyp/domain/comments{/number}","issue_comment_url":"https://api.github.com/repos/howyp/domain/issues/comments{/number}","contents_url":"https://api.github.com/repos/howyp/domain/contents/{+path}","compare_url":"https://api.github.com/repos/howyp/domain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/howyp/domain/merges","archive_url":"https://api.github.com/repos/howyp/domain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/howyp/domain/downloads","issues_url":"https://api.github.com/repos/howyp/domain/issues{/number}","pulls_url":"https://api.github.com/repos/howyp/domain/pulls{/number}","milestones_url":"https://api.github.com/repos/howyp/domain/milestones{/number}","notifications_url":"https://api.github.com/repos/howyp/domain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/howyp/domain/labels{/name}","releases_url":"https://api.github.com/repos/howyp/domain/releases{/id}","created_at":"2015-09-02T15:41:45Z","updated_at":"2015-09-02T15:41:45Z","pushed_at":"2015-09-03T15:09:41Z","git_url":"git://github.com/howyp/domain.git","ssh_url":"git@github.com:howyp/domain.git","clone_url":"https://github.com/howyp/domain.git","svn_url":"https://github.com/howyp/domain","homepage":"","size":149,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hmrc:master","ref":"master","sha":"93b65678350a40eabf4af95ae03091846bffcaa9","user":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars.githubusercontent.com/u/5755339?v=3","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":31957990,"name":"domain","full_name":"hmrc/domain","owner":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars.githubusercontent.com/u/5755339?v=3","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/domain","description":"Micro-library for typing and validating UK tax identifiers","fork":false,"url":"https://api.github.com/repos/hmrc/domain","forks_url":"https://api.github.com/repos/hmrc/domain/forks","keys_url":"https://api.github.com/repos/hmrc/domain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/domain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/domain/teams","hooks_url":"https://api.github.com/repos/hmrc/domain/hooks","issue_events_url":"https://api.github.com/repos/hmrc/domain/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/domain/events","assignees_url":"https://api.github.com/repos/hmrc/domain/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/domain/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/domain/tags","blobs_url":"https://api.github.com/repos/hmrc/domain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/domain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/domain/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/domain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/domain/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/domain/languages","stargazers_url":"https://api.github.com/repos/hmrc/domain/stargazers","contributors_url":"https://api.github.com/repos/hmrc/domain/contributors","subscribers_url":"https://api.github.com/repos/hmrc/domain/subscribers","subscription_url":"https://api.github.com/repos/hmrc/domain/subscription","commits_url":"https://api.github.com/repos/hmrc/domain/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/domain/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/domain/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/domain/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/domain/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/domain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/domain/merges","archive_url":"https://api.github.com/repos/hmrc/domain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/domain/downloads","issues_url":"https://api.github.com/repos/hmrc/domain/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/domain/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/domain/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/domain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/domain/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/domain/releases{/id}","created_at":"2015-03-10T13:08:56Z","updated_at":"2015-04-07T05:35:47Z","pushed_at":"2015-09-03T15:09:41Z","git_url":"git://github.com/hmrc/domain.git","ssh_url":"git@github.com:hmrc/domain.git","clone_url":"https://github.com/hmrc/domain.git","svn_url":"https://github.com/hmrc/domain","homepage":"","size":304,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":2,"forks":7,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmrc/domain/pulls/11"},"html":{"href":"https://github.com/hmrc/domain/pull/11"},"issue":{"href":"https://api.github.com/repos/hmrc/domain/issues/11"},"comments":{"href":"https://api.github.com/repos/hmrc/domain/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/hmrc/domain/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/hmrc/domain/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmrc/domain/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/hmrc/domain/statuses/d212c9576df21e1dd2dbb0e8c3a466b707d39d27"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":9,"commits":7,"additions":379,"deletions":84,"changed_files":5}}