{"action":"created","comment":{"url":"https://api.github.com/repos/overcastde/python-overcast/pulls/comments/28365587","id":28365587,"diff_hunk":"@@ -413,16 +457,35 @@ def provision_step(self, details):\n         for base_node_name, node_info in stack['nodes'].items():\n             def _create_node(base_name):\n                 node_name = self.add_prefix(base_name)\n-                self.nodes[base_name] = self.create_node(node_name, node_info,\n-                                                         keypair=keypair_name,\n-                                                         userdata=userdata)\n+                self.nodes[base_name] = node(node_name, node_info,\n+                                                        keypair=keypair_name,\n+                                                        userdata=userdata,\n+                                                        mappings=load_mappings(args.mappings))\n+                self.nodes[base_name].build()\n \n             if 'number' in node_info:\n                 count = node_info.pop('number')\n                 for idx in range(1, count+1):\n-                    _create_node('%s%d' % (base_node_name, idx))\n+                    node_name = '%s%d' % (base_node_name, idx)\n+                    _create_node(node_name)\n+                    node_names.add(node_name)\n             else:\n                 _create_node(base_node_name)\n+                node_names.add(base_node_name)\n+\n+        while node_names:\n+            time.sleep(5)\n+            for name in node_names:\n+                if self.nodes[name].poll() == 'ACTIVE':\n+                    node_names.discard(name)\n+                if self.nodes[name].poll() == 'ERROR':\n+                    if details.get('retry-if-fails', False):","path":"overcast/runner/__init__.py","position":195,"original_position":195,"commit_id":"e42b20acbf4a2a1b417895213fcb27e589f4311a","original_commit_id":"e42b20acbf4a2a1b417895213fcb27e589f4311a","user":{"login":"sorenh","id":160090,"avatar_url":"https://avatars.githubusercontent.com/u/160090?v=3","gravatar_id":"","url":"https://api.github.com/users/sorenh","html_url":"https://github.com/sorenh","followers_url":"https://api.github.com/users/sorenh/followers","following_url":"https://api.github.com/users/sorenh/following{/other_user}","gists_url":"https://api.github.com/users/sorenh/gists{/gist_id}","starred_url":"https://api.github.com/users/sorenh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sorenh/subscriptions","organizations_url":"https://api.github.com/users/sorenh/orgs","repos_url":"https://api.github.com/users/sorenh/repos","events_url":"https://api.github.com/users/sorenh/events{/privacy}","received_events_url":"https://api.github.com/users/sorenh/received_events","type":"User","site_admin":false},"body":"Hm.. I hadn't thought of this. Do you think these settings (retry-if-fails, timeout, etc) would be a per-node setting?","created_at":"2015-04-14T20:13:47Z","updated_at":"2015-04-14T20:13:47Z","html_url":"https://github.com/overcastde/python-overcast/pull/2#discussion_r28365587","pull_request_url":"https://api.github.com/repos/overcastde/python-overcast/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/overcastde/python-overcast/pulls/comments/28365587"},"html":{"href":"https://github.com/overcastde/python-overcast/pull/2#discussion_r28365587"},"pull_request":{"href":"https://api.github.com/repos/overcastde/python-overcast/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/overcastde/python-overcast/pulls/2","id":33294152,"html_url":"https://github.com/overcastde/python-overcast/pull/2","diff_url":"https://github.com/overcastde/python-overcast/pull/2.diff","patch_url":"https://github.com/overcastde/python-overcast/pull/2.patch","issue_url":"https://api.github.com/repos/overcastde/python-overcast/issues/2","number":2,"state":"open","locked":false,"title":"WIP for retry and wait till vms active","user":{"login":"hkumarmk","id":6316902,"avatar_url":"https://avatars.githubusercontent.com/u/6316902?v=3","gravatar_id":"","url":"https://api.github.com/users/hkumarmk","html_url":"https://github.com/hkumarmk","followers_url":"https://api.github.com/users/hkumarmk/followers","following_url":"https://api.github.com/users/hkumarmk/following{/other_user}","gists_url":"https://api.github.com/users/hkumarmk/gists{/gist_id}","starred_url":"https://api.github.com/users/hkumarmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkumarmk/subscriptions","organizations_url":"https://api.github.com/users/hkumarmk/orgs","repos_url":"https://api.github.com/users/hkumarmk/repos","events_url":"https://api.github.com/users/hkumarmk/events{/privacy}","received_events_url":"https://api.github.com/users/hkumarmk/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-04-14T20:02:05Z","updated_at":"2015-04-14T20:13:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31b28f076ca2ca7c08e7e093effe8126e8cde82e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/overcastde/python-overcast/pulls/2/commits","review_comments_url":"https://api.github.com/repos/overcastde/python-overcast/pulls/2/comments","review_comment_url":"https://api.github.com/repos/overcastde/python-overcast/pulls/comments{/number}","comments_url":"https://api.github.com/repos/overcastde/python-overcast/issues/2/comments","statuses_url":"https://api.github.com/repos/overcastde/python-overcast/statuses/e42b20acbf4a2a1b417895213fcb27e589f4311a","head":{"label":"hkumarmk:retry_vm","ref":"retry_vm","sha":"e42b20acbf4a2a1b417895213fcb27e589f4311a","user":{"login":"hkumarmk","id":6316902,"avatar_url":"https://avatars.githubusercontent.com/u/6316902?v=3","gravatar_id":"","url":"https://api.github.com/users/hkumarmk","html_url":"https://github.com/hkumarmk","followers_url":"https://api.github.com/users/hkumarmk/followers","following_url":"https://api.github.com/users/hkumarmk/following{/other_user}","gists_url":"https://api.github.com/users/hkumarmk/gists{/gist_id}","starred_url":"https://api.github.com/users/hkumarmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkumarmk/subscriptions","organizations_url":"https://api.github.com/users/hkumarmk/orgs","repos_url":"https://api.github.com/users/hkumarmk/repos","events_url":"https://api.github.com/users/hkumarmk/events{/privacy}","received_events_url":"https://api.github.com/users/hkumarmk/received_events","type":"User","site_admin":false},"repo":{"id":33879331,"name":"python-overcast","full_name":"hkumarmk/python-overcast","owner":{"login":"hkumarmk","id":6316902,"avatar_url":"https://avatars.githubusercontent.com/u/6316902?v=3","gravatar_id":"","url":"https://api.github.com/users/hkumarmk","html_url":"https://github.com/hkumarmk","followers_url":"https://api.github.com/users/hkumarmk/followers","following_url":"https://api.github.com/users/hkumarmk/following{/other_user}","gists_url":"https://api.github.com/users/hkumarmk/gists{/gist_id}","starred_url":"https://api.github.com/users/hkumarmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkumarmk/subscriptions","organizations_url":"https://api.github.com/users/hkumarmk/orgs","repos_url":"https://api.github.com/users/hkumarmk/repos","events_url":"https://api.github.com/users/hkumarmk/events{/privacy}","received_events_url":"https://api.github.com/users/hkumarmk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hkumarmk/python-overcast","description":"","fork":true,"url":"https://api.github.com/repos/hkumarmk/python-overcast","forks_url":"https://api.github.com/repos/hkumarmk/python-overcast/forks","keys_url":"https://api.github.com/repos/hkumarmk/python-overcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hkumarmk/python-overcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hkumarmk/python-overcast/teams","hooks_url":"https://api.github.com/repos/hkumarmk/python-overcast/hooks","issue_events_url":"https://api.github.com/repos/hkumarmk/python-overcast/issues/events{/number}","events_url":"https://api.github.com/repos/hkumarmk/python-overcast/events","assignees_url":"https://api.github.com/repos/hkumarmk/python-overcast/assignees{/user}","branches_url":"https://api.github.com/repos/hkumarmk/python-overcast/branches{/branch}","tags_url":"https://api.github.com/repos/hkumarmk/python-overcast/tags","blobs_url":"https://api.github.com/repos/hkumarmk/python-overcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hkumarmk/python-overcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hkumarmk/python-overcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/hkumarmk/python-overcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hkumarmk/python-overcast/statuses/{sha}","languages_url":"https://api.github.com/repos/hkumarmk/python-overcast/languages","stargazers_url":"https://api.github.com/repos/hkumarmk/python-overcast/stargazers","contributors_url":"https://api.github.com/repos/hkumarmk/python-overcast/contributors","subscribers_url":"https://api.github.com/repos/hkumarmk/python-overcast/subscribers","subscription_url":"https://api.github.com/repos/hkumarmk/python-overcast/subscription","commits_url":"https://api.github.com/repos/hkumarmk/python-overcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/hkumarmk/python-overcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/hkumarmk/python-overcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/hkumarmk/python-overcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/hkumarmk/python-overcast/contents/{+path}","compare_url":"https://api.github.com/repos/hkumarmk/python-overcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hkumarmk/python-overcast/merges","archive_url":"https://api.github.com/repos/hkumarmk/python-overcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hkumarmk/python-overcast/downloads","issues_url":"https://api.github.com/repos/hkumarmk/python-overcast/issues{/number}","pulls_url":"https://api.github.com/repos/hkumarmk/python-overcast/pulls{/number}","milestones_url":"https://api.github.com/repos/hkumarmk/python-overcast/milestones{/number}","notifications_url":"https://api.github.com/repos/hkumarmk/python-overcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hkumarmk/python-overcast/labels{/name}","releases_url":"https://api.github.com/repos/hkumarmk/python-overcast/releases{/id}","created_at":"2015-04-13T16:15:59Z","updated_at":"2015-04-13T16:15:59Z","pushed_at":"2015-04-14T19:59:47Z","git_url":"git://github.com/hkumarmk/python-overcast.git","ssh_url":"git@github.com:hkumarmk/python-overcast.git","clone_url":"https://github.com/hkumarmk/python-overcast.git","svn_url":"https://github.com/hkumarmk/python-overcast","homepage":null,"size":132,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"overcastde:master","ref":"master","sha":"d1d70f646375552080b9ed219a4f7b6cbf346cf4","user":{"login":"overcastde","id":11595717,"avatar_url":"https://avatars.githubusercontent.com/u/11595717?v=3","gravatar_id":"","url":"https://api.github.com/users/overcastde","html_url":"https://github.com/overcastde","followers_url":"https://api.github.com/users/overcastde/followers","following_url":"https://api.github.com/users/overcastde/following{/other_user}","gists_url":"https://api.github.com/users/overcastde/gists{/gist_id}","starred_url":"https://api.github.com/users/overcastde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/overcastde/subscriptions","organizations_url":"https://api.github.com/users/overcastde/orgs","repos_url":"https://api.github.com/users/overcastde/repos","events_url":"https://api.github.com/users/overcastde/events{/privacy}","received_events_url":"https://api.github.com/users/overcastde/received_events","type":"Organization","site_admin":false},"repo":{"id":32794027,"name":"python-overcast","full_name":"overcastde/python-overcast","owner":{"login":"overcastde","id":11595717,"avatar_url":"https://avatars.githubusercontent.com/u/11595717?v=3","gravatar_id":"","url":"https://api.github.com/users/overcastde","html_url":"https://github.com/overcastde","followers_url":"https://api.github.com/users/overcastde/followers","following_url":"https://api.github.com/users/overcastde/following{/other_user}","gists_url":"https://api.github.com/users/overcastde/gists{/gist_id}","starred_url":"https://api.github.com/users/overcastde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/overcastde/subscriptions","organizations_url":"https://api.github.com/users/overcastde/orgs","repos_url":"https://api.github.com/users/overcastde/repos","events_url":"https://api.github.com/users/overcastde/events{/privacy}","received_events_url":"https://api.github.com/users/overcastde/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/overcastde/python-overcast","description":"","fork":false,"url":"https://api.github.com/repos/overcastde/python-overcast","forks_url":"https://api.github.com/repos/overcastde/python-overcast/forks","keys_url":"https://api.github.com/repos/overcastde/python-overcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/overcastde/python-overcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/overcastde/python-overcast/teams","hooks_url":"https://api.github.com/repos/overcastde/python-overcast/hooks","issue_events_url":"https://api.github.com/repos/overcastde/python-overcast/issues/events{/number}","events_url":"https://api.github.com/repos/overcastde/python-overcast/events","assignees_url":"https://api.github.com/repos/overcastde/python-overcast/assignees{/user}","branches_url":"https://api.github.com/repos/overcastde/python-overcast/branches{/branch}","tags_url":"https://api.github.com/repos/overcastde/python-overcast/tags","blobs_url":"https://api.github.com/repos/overcastde/python-overcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/overcastde/python-overcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/overcastde/python-overcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/overcastde/python-overcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/overcastde/python-overcast/statuses/{sha}","languages_url":"https://api.github.com/repos/overcastde/python-overcast/languages","stargazers_url":"https://api.github.com/repos/overcastde/python-overcast/stargazers","contributors_url":"https://api.github.com/repos/overcastde/python-overcast/contributors","subscribers_url":"https://api.github.com/repos/overcastde/python-overcast/subscribers","subscription_url":"https://api.github.com/repos/overcastde/python-overcast/subscription","commits_url":"https://api.github.com/repos/overcastde/python-overcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/overcastde/python-overcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/overcastde/python-overcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/overcastde/python-overcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/overcastde/python-overcast/contents/{+path}","compare_url":"https://api.github.com/repos/overcastde/python-overcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/overcastde/python-overcast/merges","archive_url":"https://api.github.com/repos/overcastde/python-overcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/overcastde/python-overcast/downloads","issues_url":"https://api.github.com/repos/overcastde/python-overcast/issues{/number}","pulls_url":"https://api.github.com/repos/overcastde/python-overcast/pulls{/number}","milestones_url":"https://api.github.com/repos/overcastde/python-overcast/milestones{/number}","notifications_url":"https://api.github.com/repos/overcastde/python-overcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/overcastde/python-overcast/labels{/name}","releases_url":"https://api.github.com/repos/overcastde/python-overcast/releases{/id}","created_at":"2015-03-24T11:19:06Z","updated_at":"2015-04-14T12:19:13Z","pushed_at":"2015-04-14T20:02:06Z","git_url":"git://github.com/overcastde/python-overcast.git","ssh_url":"git@github.com:overcastde/python-overcast.git","clone_url":"https://github.com/overcastde/python-overcast.git","svn_url":"https://github.com/overcastde/python-overcast","homepage":null,"size":132,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/overcastde/python-overcast/pulls/2"},"html":{"href":"https://github.com/overcastde/python-overcast/pull/2"},"issue":{"href":"https://api.github.com/repos/overcastde/python-overcast/issues/2"},"comments":{"href":"https://api.github.com/repos/overcastde/python-overcast/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/overcastde/python-overcast/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/overcastde/python-overcast/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/overcastde/python-overcast/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/overcastde/python-overcast/statuses/e42b20acbf4a2a1b417895213fcb27e589f4311a"}}}}