{"action":"closed","number":634,"pull_request":{"url":"https://api.github.com/repos/nicolargo/glances/pulls/634","id":40161933,"html_url":"https://github.com/nicolargo/glances/pull/634","diff_url":"https://github.com/nicolargo/glances/pull/634.diff","patch_url":"https://github.com/nicolargo/glances/pull/634.patch","issue_url":"https://api.github.com/repos/nicolargo/glances/issues/634","number":634,"state":"closed","locked":false,"title":"Fix UTF-8 characters being output on latin1 terminals","user":{"login":"h3xx","id":615684,"avatar_url":"https://avatars.githubusercontent.com/u/615684?v=3","gravatar_id":"","url":"https://api.github.com/users/h3xx","html_url":"https://github.com/h3xx","followers_url":"https://api.github.com/users/h3xx/followers","following_url":"https://api.github.com/users/h3xx/following{/other_user}","gists_url":"https://api.github.com/users/h3xx/gists{/gist_id}","starred_url":"https://api.github.com/users/h3xx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h3xx/subscriptions","organizations_url":"https://api.github.com/users/h3xx/orgs","repos_url":"https://api.github.com/users/h3xx/repos","events_url":"https://api.github.com/users/h3xx/events{/privacy}","received_events_url":"https://api.github.com/users/h3xx/received_events","type":"User","site_admin":false},"body":"This fix translates the characters to an appropriate encoding for the\r\nterminal. \"Â°C\" (A-caret, degrees, C) was being output on latin1 terminals, which is a bug\r\nsince the LC_CTYPE locale setting should tell the program whether it's\r\nokay to output Unicode.\r\n\r\nThis follows the recommendation from the official curses library\r\ndocumentation: https://docs.python.org/2/library/curses.html\r\n\r\nSteps to reproduce the issue:\r\n\r\n1. Install pysensors, enable any kernel modules necessary to support it\r\n2. Run `LANG=en_US rxvt -e glances`\r\n3. Look in SENSORS section\r\n\r\nThe corrupt Unicode character sequence will appear.","created_at":"2015-07-16T18:44:28Z","updated_at":"2015-07-19T00:51:59Z","closed_at":"2015-07-19T00:51:58Z","merged_at":null,"merge_commit_sha":"16e4a2d030c337cc6eaa379a9a25bb442d06cf89","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nicolargo/glances/pulls/634/commits","review_comments_url":"https://api.github.com/repos/nicolargo/glances/pulls/634/comments","review_comment_url":"https://api.github.com/repos/nicolargo/glances/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nicolargo/glances/issues/634/comments","statuses_url":"https://api.github.com/repos/nicolargo/glances/statuses/4de7bbc85180ebb315d7ba587741bc1e745231e1","head":{"label":"h3xx:master","ref":"master","sha":"4de7bbc85180ebb315d7ba587741bc1e745231e1","user":{"login":"h3xx","id":615684,"avatar_url":"https://avatars.githubusercontent.com/u/615684?v=3","gravatar_id":"","url":"https://api.github.com/users/h3xx","html_url":"https://github.com/h3xx","followers_url":"https://api.github.com/users/h3xx/followers","following_url":"https://api.github.com/users/h3xx/following{/other_user}","gists_url":"https://api.github.com/users/h3xx/gists{/gist_id}","starred_url":"https://api.github.com/users/h3xx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h3xx/subscriptions","organizations_url":"https://api.github.com/users/h3xx/orgs","repos_url":"https://api.github.com/users/h3xx/repos","events_url":"https://api.github.com/users/h3xx/events{/privacy}","received_events_url":"https://api.github.com/users/h3xx/received_events","type":"User","site_admin":false},"repo":{"id":39212029,"name":"glances","full_name":"h3xx/glances","owner":{"login":"h3xx","id":615684,"avatar_url":"https://avatars.githubusercontent.com/u/615684?v=3","gravatar_id":"","url":"https://api.github.com/users/h3xx","html_url":"https://github.com/h3xx","followers_url":"https://api.github.com/users/h3xx/followers","following_url":"https://api.github.com/users/h3xx/following{/other_user}","gists_url":"https://api.github.com/users/h3xx/gists{/gist_id}","starred_url":"https://api.github.com/users/h3xx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h3xx/subscriptions","organizations_url":"https://api.github.com/users/h3xx/orgs","repos_url":"https://api.github.com/users/h3xx/repos","events_url":"https://api.github.com/users/h3xx/events{/privacy}","received_events_url":"https://api.github.com/users/h3xx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/h3xx/glances","description":"Glances an Eye on your system","fork":true,"url":"https://api.github.com/repos/h3xx/glances","forks_url":"https://api.github.com/repos/h3xx/glances/forks","keys_url":"https://api.github.com/repos/h3xx/glances/keys{/key_id}","collaborators_url":"https://api.github.com/repos/h3xx/glances/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/h3xx/glances/teams","hooks_url":"https://api.github.com/repos/h3xx/glances/hooks","issue_events_url":"https://api.github.com/repos/h3xx/glances/issues/events{/number}","events_url":"https://api.github.com/repos/h3xx/glances/events","assignees_url":"https://api.github.com/repos/h3xx/glances/assignees{/user}","branches_url":"https://api.github.com/repos/h3xx/glances/branches{/branch}","tags_url":"https://api.github.com/repos/h3xx/glances/tags","blobs_url":"https://api.github.com/repos/h3xx/glances/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/h3xx/glances/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/h3xx/glances/git/refs{/sha}","trees_url":"https://api.github.com/repos/h3xx/glances/git/trees{/sha}","statuses_url":"https://api.github.com/repos/h3xx/glances/statuses/{sha}","languages_url":"https://api.github.com/repos/h3xx/glances/languages","stargazers_url":"https://api.github.com/repos/h3xx/glances/stargazers","contributors_url":"https://api.github.com/repos/h3xx/glances/contributors","subscribers_url":"https://api.github.com/repos/h3xx/glances/subscribers","subscription_url":"https://api.github.com/repos/h3xx/glances/subscription","commits_url":"https://api.github.com/repos/h3xx/glances/commits{/sha}","git_commits_url":"https://api.github.com/repos/h3xx/glances/git/commits{/sha}","comments_url":"https://api.github.com/repos/h3xx/glances/comments{/number}","issue_comment_url":"https://api.github.com/repos/h3xx/glances/issues/comments{/number}","contents_url":"https://api.github.com/repos/h3xx/glances/contents/{+path}","compare_url":"https://api.github.com/repos/h3xx/glances/compare/{base}...{head}","merges_url":"https://api.github.com/repos/h3xx/glances/merges","archive_url":"https://api.github.com/repos/h3xx/glances/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/h3xx/glances/downloads","issues_url":"https://api.github.com/repos/h3xx/glances/issues{/number}","pulls_url":"https://api.github.com/repos/h3xx/glances/pulls{/number}","milestones_url":"https://api.github.com/repos/h3xx/glances/milestones{/number}","notifications_url":"https://api.github.com/repos/h3xx/glances/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/h3xx/glances/labels{/name}","releases_url":"https://api.github.com/repos/h3xx/glances/releases{/id}","created_at":"2015-07-16T17:54:33Z","updated_at":"2015-07-16T17:54:34Z","pushed_at":"2015-07-16T18:43:15Z","git_url":"git://github.com/h3xx/glances.git","ssh_url":"git@github.com:h3xx/glances.git","clone_url":"https://github.com/h3xx/glances.git","svn_url":"https://github.com/h3xx/glances","homepage":"http://nicolargo.github.io/glances/","size":16865,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nicolargo:master","ref":"master","sha":"481ddd9d9f751a3b86dd08183b1a69bb556215e7","user":{"login":"nicolargo","id":776747,"avatar_url":"https://avatars.githubusercontent.com/u/776747?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolargo","html_url":"https://github.com/nicolargo","followers_url":"https://api.github.com/users/nicolargo/followers","following_url":"https://api.github.com/users/nicolargo/following{/other_user}","gists_url":"https://api.github.com/users/nicolargo/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolargo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolargo/subscriptions","organizations_url":"https://api.github.com/users/nicolargo/orgs","repos_url":"https://api.github.com/users/nicolargo/repos","events_url":"https://api.github.com/users/nicolargo/events{/privacy}","received_events_url":"https://api.github.com/users/nicolargo/received_events","type":"User","site_admin":false},"repo":{"id":2909429,"name":"glances","full_name":"nicolargo/glances","owner":{"login":"nicolargo","id":776747,"avatar_url":"https://avatars.githubusercontent.com/u/776747?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolargo","html_url":"https://github.com/nicolargo","followers_url":"https://api.github.com/users/nicolargo/followers","following_url":"https://api.github.com/users/nicolargo/following{/other_user}","gists_url":"https://api.github.com/users/nicolargo/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolargo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolargo/subscriptions","organizations_url":"https://api.github.com/users/nicolargo/orgs","repos_url":"https://api.github.com/users/nicolargo/repos","events_url":"https://api.github.com/users/nicolargo/events{/privacy}","received_events_url":"https://api.github.com/users/nicolargo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nicolargo/glances","description":"Glances an Eye on your system","fork":false,"url":"https://api.github.com/repos/nicolargo/glances","forks_url":"https://api.github.com/repos/nicolargo/glances/forks","keys_url":"https://api.github.com/repos/nicolargo/glances/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nicolargo/glances/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nicolargo/glances/teams","hooks_url":"https://api.github.com/repos/nicolargo/glances/hooks","issue_events_url":"https://api.github.com/repos/nicolargo/glances/issues/events{/number}","events_url":"https://api.github.com/repos/nicolargo/glances/events","assignees_url":"https://api.github.com/repos/nicolargo/glances/assignees{/user}","branches_url":"https://api.github.com/repos/nicolargo/glances/branches{/branch}","tags_url":"https://api.github.com/repos/nicolargo/glances/tags","blobs_url":"https://api.github.com/repos/nicolargo/glances/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nicolargo/glances/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nicolargo/glances/git/refs{/sha}","trees_url":"https://api.github.com/repos/nicolargo/glances/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nicolargo/glances/statuses/{sha}","languages_url":"https://api.github.com/repos/nicolargo/glances/languages","stargazers_url":"https://api.github.com/repos/nicolargo/glances/stargazers","contributors_url":"https://api.github.com/repos/nicolargo/glances/contributors","subscribers_url":"https://api.github.com/repos/nicolargo/glances/subscribers","subscription_url":"https://api.github.com/repos/nicolargo/glances/subscription","commits_url":"https://api.github.com/repos/nicolargo/glances/commits{/sha}","git_commits_url":"https://api.github.com/repos/nicolargo/glances/git/commits{/sha}","comments_url":"https://api.github.com/repos/nicolargo/glances/comments{/number}","issue_comment_url":"https://api.github.com/repos/nicolargo/glances/issues/comments{/number}","contents_url":"https://api.github.com/repos/nicolargo/glances/contents/{+path}","compare_url":"https://api.github.com/repos/nicolargo/glances/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nicolargo/glances/merges","archive_url":"https://api.github.com/repos/nicolargo/glances/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nicolargo/glances/downloads","issues_url":"https://api.github.com/repos/nicolargo/glances/issues{/number}","pulls_url":"https://api.github.com/repos/nicolargo/glances/pulls{/number}","milestones_url":"https://api.github.com/repos/nicolargo/glances/milestones{/number}","notifications_url":"https://api.github.com/repos/nicolargo/glances/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nicolargo/glances/labels{/name}","releases_url":"https://api.github.com/repos/nicolargo/glances/releases{/id}","created_at":"2011-12-04T08:49:15Z","updated_at":"2015-07-18T02:22:22Z","pushed_at":"2015-07-18T17:24:44Z","git_url":"git://github.com/nicolargo/glances.git","ssh_url":"git@github.com:nicolargo/glances.git","clone_url":"https://github.com/nicolargo/glances.git","svn_url":"https://github.com/nicolargo/glances","homepage":"http://nicolargo.github.io/glances/","size":16865,"stargazers_count":3363,"watchers_count":3363,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":261,"mirror_url":null,"open_issues_count":35,"forks":261,"open_issues":35,"watchers":3363,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nicolargo/glances/pulls/634"},"html":{"href":"https://github.com/nicolargo/glances/pull/634"},"issue":{"href":"https://api.github.com/repos/nicolargo/glances/issues/634"},"comments":{"href":"https://api.github.com/repos/nicolargo/glances/issues/634/comments"},"review_comments":{"href":"https://api.github.com/repos/nicolargo/glances/pulls/634/comments"},"review_comment":{"href":"https://api.github.com/repos/nicolargo/glances/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nicolargo/glances/pulls/634/commits"},"statuses":{"href":"https://api.github.com/repos/nicolargo/glances/statuses/4de7bbc85180ebb315d7ba587741bc1e745231e1"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":3,"deletions":1,"changed_files":1}}