{"action":"closed","issue":{"url":"https://api.github.com/repos/tajo/react-portal/issues/35","labels_url":"https://api.github.com/repos/tajo/react-portal/issues/35/labels{/name}","comments_url":"https://api.github.com/repos/tajo/react-portal/issues/35/comments","events_url":"https://api.github.com/repos/tajo/react-portal/issues/35/events","html_url":"https://github.com/tajo/react-portal/issues/35","id":123213906,"number":35,"title":"Portal.onOpen() bug","user":{"login":"john-osullivan","id":3820981,"avatar_url":"https://avatars.githubusercontent.com/u/3820981?v=3","gravatar_id":"","url":"https://api.github.com/users/john-osullivan","html_url":"https://github.com/john-osullivan","followers_url":"https://api.github.com/users/john-osullivan/followers","following_url":"https://api.github.com/users/john-osullivan/following{/other_user}","gists_url":"https://api.github.com/users/john-osullivan/gists{/gist_id}","starred_url":"https://api.github.com/users/john-osullivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/john-osullivan/subscriptions","organizations_url":"https://api.github.com/users/john-osullivan/orgs","repos_url":"https://api.github.com/users/john-osullivan/repos","events_url":"https://api.github.com/users/john-osullivan/events{/privacy}","received_events_url":"https://api.github.com/users/john-osullivan/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-21T05:29:44Z","updated_at":"2015-12-21T06:39:21Z","closed_at":"2015-12-21T06:39:21Z","body":"Hey, this seems like a pretty straightforward bug, although I'm not sure the best way to fix it.  Currently, the onOpen callback isn't firing.  When I looked into it further, I found that while the `openPortal` method in `lib/portal.js` calls `this.props.onOpen`, the same method in the main `portal.js` file does not.  The lines are simply missing.  According to the commits the main file hasn't changed in two months, so maybe the source was updated but the project wasn't rebuilt.  \r\n\r\nWhatever it was, I fixed it on my local copy by manually adding:\r\n```\r\n      if (this.props.onOpen){\r\n        this.props.onOpen(this.node);\r\n      }\r\n```\r\nto the end of the `openPortal` method in the top-level `portal.js`.  Thought I'd let you know the issue was there, even if I'm not certain of the right way to fix it with a PR."}}