{"action":"created","comment":{"url":"https://api.github.com/repos/Eyescale/Equalizer/pulls/comments/41501172","id":41501172,"diff_hunk":"@@ -315,19 +315,23 @@ bool Resources::discover( ServerPtr server, Config* config,\n         std::stringstream name;\n         if( info.device == LB_UNDEFINED_UINT32 &&\n             // VirtualGL display redirects to local GPU (see continue above)\n-            !(info.flags & hwsd::GPUInfo::FLAG_VIRTUALGL) )\n+            !(info.flags & hwsd::GPUInfo::FLAG_VIRTUALGL ))\n         {\n             name << \"display\";\n         }\n         else\n         {\n             name << \"GPU\" << ++gpuCounter;\n-            if( info.flags & hwsd::GPUInfo::FLAG_VIRTUALGL &&\n+            if( // When running under VirtualGL, GPUs that are not VNC virtual\n+                // devices mustn't be interposed.\n+                ( info.flags & ( hwsd::GPUInfo::FLAG_VIRTUALGL |\n+                                 hwsd::GPUInfo::FLAG_VNC )) ==\n+                    hwsd::GPUInfo::FLAG_VIRTUALGL &&","path":"eq/server/config/resources.cpp","position":17,"original_position":17,"commit_id":"dc8de9c870d36f90b41fd6da2aa26d2ff0a49129","original_commit_id":"dc8de9c870d36f90b41fd6da2aa26d2ff0a49129","user":{"login":"eile","id":354947,"avatar_url":"https://avatars.githubusercontent.com/u/354947?v=3","gravatar_id":"","url":"https://api.github.com/users/eile","html_url":"https://github.com/eile","followers_url":"https://api.github.com/users/eile/followers","following_url":"https://api.github.com/users/eile/following{/other_user}","gists_url":"https://api.github.com/users/eile/gists{/gist_id}","starred_url":"https://api.github.com/users/eile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eile/subscriptions","organizations_url":"https://api.github.com/users/eile/orgs","repos_url":"https://api.github.com/users/eile/repos","events_url":"https://api.github.com/users/eile/events{/privacy}","received_events_url":"https://api.github.com/users/eile/received_events","type":"User","site_admin":false},"body":"So you are ignoring vnc servers since they are not glx capable?","created_at":"2015-10-08T11:13:44Z","updated_at":"2015-10-08T11:13:44Z","html_url":"https://github.com/Eyescale/Equalizer/pull/499#discussion_r41501172","pull_request_url":"https://api.github.com/repos/Eyescale/Equalizer/pulls/499","_links":{"self":{"href":"https://api.github.com/repos/Eyescale/Equalizer/pulls/comments/41501172"},"html":{"href":"https://github.com/Eyescale/Equalizer/pull/499#discussion_r41501172"},"pull_request":{"href":"https://api.github.com/repos/Eyescale/Equalizer/pulls/499"}}},"pull_request":{"url":"https://api.github.com/repos/Eyescale/Equalizer/pulls/499","id":47134901,"html_url":"https://github.com/Eyescale/Equalizer/pull/499","diff_url":"https://github.com/Eyescale/Equalizer/pull/499.diff","patch_url":"https://github.com/Eyescale/Equalizer/pull/499.patch","issue_url":"https://api.github.com/repos/Eyescale/Equalizer/issues/499","number":499,"state":"open","locked":false,"title":"Fixes for VirtuaGL.","user":{"login":"hernando","id":791427,"avatar_url":"https://avatars.githubusercontent.com/u/791427?v=3","gravatar_id":"","url":"https://api.github.com/users/hernando","html_url":"https://github.com/hernando","followers_url":"https://api.github.com/users/hernando/followers","following_url":"https://api.github.com/users/hernando/following{/other_user}","gists_url":"https://api.github.com/users/hernando/gists{/gist_id}","starred_url":"https://api.github.com/users/hernando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hernando/subscriptions","organizations_url":"https://api.github.com/users/hernando/orgs","repos_url":"https://api.github.com/users/hernando/repos","events_url":"https://api.github.com/users/hernando/events{/privacy}","received_events_url":"https://api.github.com/users/hernando/received_events","type":"User","site_admin":false},"body":"Correction of VGL_EXCLUDE variable generation to use , instead of ;. This\r\nis the separator finally adopted by the upstream version 2.4.80.\r\n\r\nVNC displays must be interposed when running under vglrun, but hwsd was not\r\nproviding enough information to detect a VNC display. This is also fixed\r\nin this commit.","created_at":"2015-10-08T10:19:07Z","updated_at":"2015-10-08T11:13:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97ed35d874c68ad671bd134f28e2b5542a3cbf94","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Eyescale/Equalizer/pulls/499/commits","review_comments_url":"https://api.github.com/repos/Eyescale/Equalizer/pulls/499/comments","review_comment_url":"https://api.github.com/repos/Eyescale/Equalizer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Eyescale/Equalizer/issues/499/comments","statuses_url":"https://api.github.com/repos/Eyescale/Equalizer/statuses/dc8de9c870d36f90b41fd6da2aa26d2ff0a49129","head":{"label":"hernando:master","ref":"master","sha":"dc8de9c870d36f90b41fd6da2aa26d2ff0a49129","user":{"login":"hernando","id":791427,"avatar_url":"https://avatars.githubusercontent.com/u/791427?v=3","gravatar_id":"","url":"https://api.github.com/users/hernando","html_url":"https://github.com/hernando","followers_url":"https://api.github.com/users/hernando/followers","following_url":"https://api.github.com/users/hernando/following{/other_user}","gists_url":"https://api.github.com/users/hernando/gists{/gist_id}","starred_url":"https://api.github.com/users/hernando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hernando/subscriptions","organizations_url":"https://api.github.com/users/hernando/orgs","repos_url":"https://api.github.com/users/hernando/repos","events_url":"https://api.github.com/users/hernando/events{/privacy}","received_events_url":"https://api.github.com/users/hernando/received_events","type":"User","site_admin":false},"repo":{"id":1760298,"name":"Equalizer","full_name":"hernando/Equalizer","owner":{"login":"hernando","id":791427,"avatar_url":"https://avatars.githubusercontent.com/u/791427?v=3","gravatar_id":"","url":"https://api.github.com/users/hernando","html_url":"https://github.com/hernando","followers_url":"https://api.github.com/users/hernando/followers","following_url":"https://api.github.com/users/hernando/following{/other_user}","gists_url":"https://api.github.com/users/hernando/gists{/gist_id}","starred_url":"https://api.github.com/users/hernando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hernando/subscriptions","organizations_url":"https://api.github.com/users/hernando/orgs","repos_url":"https://api.github.com/users/hernando/repos","events_url":"https://api.github.com/users/hernando/events{/privacy}","received_events_url":"https://api.github.com/users/hernando/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hernando/Equalizer","description":"Equalizer is the standard middleware to create and deploy parallel OpenGL-based applications. It enables applications to benefit from multiple graphics cards, processors and computers to scale the rendering performance, visual quality and display size. An Equalizer application runs unmodified on any visualization system, from a simple workstation to large scale graphics clusters, multi-GPU workstations and Virtual Reality installations.  ","fork":true,"url":"https://api.github.com/repos/hernando/Equalizer","forks_url":"https://api.github.com/repos/hernando/Equalizer/forks","keys_url":"https://api.github.com/repos/hernando/Equalizer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hernando/Equalizer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hernando/Equalizer/teams","hooks_url":"https://api.github.com/repos/hernando/Equalizer/hooks","issue_events_url":"https://api.github.com/repos/hernando/Equalizer/issues/events{/number}","events_url":"https://api.github.com/repos/hernando/Equalizer/events","assignees_url":"https://api.github.com/repos/hernando/Equalizer/assignees{/user}","branches_url":"https://api.github.com/repos/hernando/Equalizer/branches{/branch}","tags_url":"https://api.github.com/repos/hernando/Equalizer/tags","blobs_url":"https://api.github.com/repos/hernando/Equalizer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hernando/Equalizer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hernando/Equalizer/git/refs{/sha}","trees_url":"https://api.github.com/repos/hernando/Equalizer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hernando/Equalizer/statuses/{sha}","languages_url":"https://api.github.com/repos/hernando/Equalizer/languages","stargazers_url":"https://api.github.com/repos/hernando/Equalizer/stargazers","contributors_url":"https://api.github.com/repos/hernando/Equalizer/contributors","subscribers_url":"https://api.github.com/repos/hernando/Equalizer/subscribers","subscription_url":"https://api.github.com/repos/hernando/Equalizer/subscription","commits_url":"https://api.github.com/repos/hernando/Equalizer/commits{/sha}","git_commits_url":"https://api.github.com/repos/hernando/Equalizer/git/commits{/sha}","comments_url":"https://api.github.com/repos/hernando/Equalizer/comments{/number}","issue_comment_url":"https://api.github.com/repos/hernando/Equalizer/issues/comments{/number}","contents_url":"https://api.github.com/repos/hernando/Equalizer/contents/{+path}","compare_url":"https://api.github.com/repos/hernando/Equalizer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hernando/Equalizer/merges","archive_url":"https://api.github.com/repos/hernando/Equalizer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hernando/Equalizer/downloads","issues_url":"https://api.github.com/repos/hernando/Equalizer/issues{/number}","pulls_url":"https://api.github.com/repos/hernando/Equalizer/pulls{/number}","milestones_url":"https://api.github.com/repos/hernando/Equalizer/milestones{/number}","notifications_url":"https://api.github.com/repos/hernando/Equalizer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hernando/Equalizer/labels{/name}","releases_url":"https://api.github.com/repos/hernando/Equalizer/releases{/id}","created_at":"2011-05-17T10:53:04Z","updated_at":"2015-05-27T10:06:44Z","pushed_at":"2015-10-08T10:18:50Z","git_url":"git://github.com/hernando/Equalizer.git","ssh_url":"git@github.com:hernando/Equalizer.git","clone_url":"https://github.com/hernando/Equalizer.git","svn_url":"https://github.com/hernando/Equalizer","homepage":"http://www.equalizergraphics.com","size":65800,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Eyescale:master","ref":"master","sha":"82d8d4434159f2f4fedf00f0e8536fbda2752caf","user":{"login":"Eyescale","id":354955,"avatar_url":"https://avatars.githubusercontent.com/u/354955?v=3","gravatar_id":"","url":"https://api.github.com/users/Eyescale","html_url":"https://github.com/Eyescale","followers_url":"https://api.github.com/users/Eyescale/followers","following_url":"https://api.github.com/users/Eyescale/following{/other_user}","gists_url":"https://api.github.com/users/Eyescale/gists{/gist_id}","starred_url":"https://api.github.com/users/Eyescale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eyescale/subscriptions","organizations_url":"https://api.github.com/users/Eyescale/orgs","repos_url":"https://api.github.com/users/Eyescale/repos","events_url":"https://api.github.com/users/Eyescale/events{/privacy}","received_events_url":"https://api.github.com/users/Eyescale/received_events","type":"Organization","site_admin":false},"repo":{"id":1536948,"name":"Equalizer","full_name":"Eyescale/Equalizer","owner":{"login":"Eyescale","id":354955,"avatar_url":"https://avatars.githubusercontent.com/u/354955?v=3","gravatar_id":"","url":"https://api.github.com/users/Eyescale","html_url":"https://github.com/Eyescale","followers_url":"https://api.github.com/users/Eyescale/followers","following_url":"https://api.github.com/users/Eyescale/following{/other_user}","gists_url":"https://api.github.com/users/Eyescale/gists{/gist_id}","starred_url":"https://api.github.com/users/Eyescale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eyescale/subscriptions","organizations_url":"https://api.github.com/users/Eyescale/orgs","repos_url":"https://api.github.com/users/Eyescale/repos","events_url":"https://api.github.com/users/Eyescale/events{/privacy}","received_events_url":"https://api.github.com/users/Eyescale/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Eyescale/Equalizer","description":"Equalizer is the standard middleware to create and deploy parallel OpenGL-based applications. It enables applications to benefit from multiple graphics cards, processors and computers to scale the rendering performance, visual quality and display size. An Equalizer application runs unmodified on any visualization system, from a simple workstation to large scale graphics clusters, multi-GPU workstations and Virtual Reality installations.  ","fork":false,"url":"https://api.github.com/repos/Eyescale/Equalizer","forks_url":"https://api.github.com/repos/Eyescale/Equalizer/forks","keys_url":"https://api.github.com/repos/Eyescale/Equalizer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Eyescale/Equalizer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Eyescale/Equalizer/teams","hooks_url":"https://api.github.com/repos/Eyescale/Equalizer/hooks","issue_events_url":"https://api.github.com/repos/Eyescale/Equalizer/issues/events{/number}","events_url":"https://api.github.com/repos/Eyescale/Equalizer/events","assignees_url":"https://api.github.com/repos/Eyescale/Equalizer/assignees{/user}","branches_url":"https://api.github.com/repos/Eyescale/Equalizer/branches{/branch}","tags_url":"https://api.github.com/repos/Eyescale/Equalizer/tags","blobs_url":"https://api.github.com/repos/Eyescale/Equalizer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Eyescale/Equalizer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Eyescale/Equalizer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Eyescale/Equalizer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Eyescale/Equalizer/statuses/{sha}","languages_url":"https://api.github.com/repos/Eyescale/Equalizer/languages","stargazers_url":"https://api.github.com/repos/Eyescale/Equalizer/stargazers","contributors_url":"https://api.github.com/repos/Eyescale/Equalizer/contributors","subscribers_url":"https://api.github.com/repos/Eyescale/Equalizer/subscribers","subscription_url":"https://api.github.com/repos/Eyescale/Equalizer/subscription","commits_url":"https://api.github.com/repos/Eyescale/Equalizer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Eyescale/Equalizer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Eyescale/Equalizer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Eyescale/Equalizer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Eyescale/Equalizer/contents/{+path}","compare_url":"https://api.github.com/repos/Eyescale/Equalizer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Eyescale/Equalizer/merges","archive_url":"https://api.github.com/repos/Eyescale/Equalizer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Eyescale/Equalizer/downloads","issues_url":"https://api.github.com/repos/Eyescale/Equalizer/issues{/number}","pulls_url":"https://api.github.com/repos/Eyescale/Equalizer/pulls{/number}","milestones_url":"https://api.github.com/repos/Eyescale/Equalizer/milestones{/number}","notifications_url":"https://api.github.com/repos/Eyescale/Equalizer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Eyescale/Equalizer/labels{/name}","releases_url":"https://api.github.com/repos/Eyescale/Equalizer/releases{/id}","created_at":"2011-03-28T14:41:53Z","updated_at":"2015-09-30T10:25:18Z","pushed_at":"2015-10-08T10:19:07Z","git_url":"git://github.com/Eyescale/Equalizer.git","ssh_url":"git@github.com:Eyescale/Equalizer.git","clone_url":"https://github.com/Eyescale/Equalizer.git","svn_url":"https://github.com/Eyescale/Equalizer","homepage":"http://www.equalizergraphics.com","size":77883,"stargazers_count":98,"watchers_count":98,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"open_issues_count":53,"forks":63,"open_issues":53,"watchers":98,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Eyescale/Equalizer/pulls/499"},"html":{"href":"https://github.com/Eyescale/Equalizer/pull/499"},"issue":{"href":"https://api.github.com/repos/Eyescale/Equalizer/issues/499"},"comments":{"href":"https://api.github.com/repos/Eyescale/Equalizer/issues/499/comments"},"review_comments":{"href":"https://api.github.com/repos/Eyescale/Equalizer/pulls/499/comments"},"review_comment":{"href":"https://api.github.com/repos/Eyescale/Equalizer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Eyescale/Equalizer/pulls/499/commits"},"statuses":{"href":"https://api.github.com/repos/Eyescale/Equalizer/statuses/dc8de9c870d36f90b41fd6da2aa26d2ff0a49129"}}}}