{"action":"created","comment":{"url":"https://api.github.com/repos/groupon/shared-store/pulls/comments/27791533","id":27791533,"diff_hunk":"@@ -98,7 +98,7 @@ dirContent = (dir, {watch, statFiles} = {}) ->\n         props\n \n   initial = fromPromiseFunction(statDir)\n-    .flatMap(Observable.fromArray)\n+    .flatMap(Observable.from)","path":"src/dir-content.coffee","position":5,"original_position":5,"commit_id":"bb79e12f63fa90fbfbb0cb36d1308481667142fa","original_commit_id":"bb79e12f63fa90fbfbb0cb36d1308481667142fa","user":{"login":"johan","id":2459,"avatar_url":"https://avatars.githubusercontent.com/u/2459?v=3","gravatar_id":"","url":"https://api.github.com/users/johan","html_url":"https://github.com/johan","followers_url":"https://api.github.com/users/johan/followers","following_url":"https://api.github.com/users/johan/following{/other_user}","gists_url":"https://api.github.com/users/johan/gists{/gist_id}","starred_url":"https://api.github.com/users/johan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johan/subscriptions","organizations_url":"https://api.github.com/users/johan/orgs","repos_url":"https://api.github.com/users/johan/repos","events_url":"https://api.github.com/users/johan/events{/privacy}","received_events_url":"https://api.github.com/users/johan/received_events","type":"User","site_admin":false},"body":"Maybe this change is still worth doing, even if the original idea fell a little short of its intent?","created_at":"2015-04-06T10:16:50Z","updated_at":"2015-04-06T10:16:50Z","html_url":"https://github.com/groupon/shared-store/pull/15#discussion_r27791533","pull_request_url":"https://api.github.com/repos/groupon/shared-store/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/groupon/shared-store/pulls/comments/27791533"},"html":{"href":"https://github.com/groupon/shared-store/pull/15#discussion_r27791533"},"pull_request":{"href":"https://api.github.com/repos/groupon/shared-store/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/groupon/shared-store/pulls/15","id":32626682,"html_url":"https://github.com/groupon/shared-store/pull/15","diff_url":"https://github.com/groupon/shared-store/pull/15.diff","patch_url":"https://github.com/groupon/shared-store/pull/15.patch","issue_url":"https://api.github.com/repos/groupon/shared-store/issues/15","number":15,"state":"closed","locked":false,"title":"fix getaddrinfo ENOTFOUND","user":{"login":"khoomeister","id":681288,"avatar_url":"https://avatars.githubusercontent.com/u/681288?v=3","gravatar_id":"","url":"https://api.github.com/users/khoomeister","html_url":"https://github.com/khoomeister","followers_url":"https://api.github.com/users/khoomeister/followers","following_url":"https://api.github.com/users/khoomeister/following{/other_user}","gists_url":"https://api.github.com/users/khoomeister/gists{/gist_id}","starred_url":"https://api.github.com/users/khoomeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khoomeister/subscriptions","organizations_url":"https://api.github.com/users/khoomeister/orgs","repos_url":"https://api.github.com/users/khoomeister/repos","events_url":"https://api.github.com/users/khoomeister/events{/privacy}","received_events_url":"https://api.github.com/users/khoomeister/received_events","type":"User","site_admin":false},"body":"There's a non-deterministic error where if the hostname can't even resolve for a fetch operation, the promise might throw instead of being caught.\r\n\r\nI've been digging around trying to work out root cause, but I haven't been able to.\r\n\r\nIn lieu of this, the initial http rejection isn't really needed since it'll bubble up and return the last valid cache anyhow.","created_at":"2015-04-04T01:28:07Z","updated_at":"2015-04-06T10:16:50Z","closed_at":"2015-04-04T17:35:07Z","merged_at":null,"merge_commit_sha":"b1e26920a8e4520a52e6d1c9d9646075f72c253b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/groupon/shared-store/pulls/15/commits","review_comments_url":"https://api.github.com/repos/groupon/shared-store/pulls/15/comments","review_comment_url":"https://api.github.com/repos/groupon/shared-store/pulls/comments{/number}","comments_url":"https://api.github.com/repos/groupon/shared-store/issues/15/comments","statuses_url":"https://api.github.com/repos/groupon/shared-store/statuses/bb79e12f63fa90fbfbb0cb36d1308481667142fa","head":{"label":"groupon:ck-fix-getaddrinfo-ENOTFOUND","ref":"ck-fix-getaddrinfo-ENOTFOUND","sha":"bb79e12f63fa90fbfbb0cb36d1308481667142fa","user":{"login":"groupon","id":206233,"avatar_url":"https://avatars.githubusercontent.com/u/206233?v=3","gravatar_id":"","url":"https://api.github.com/users/groupon","html_url":"https://github.com/groupon","followers_url":"https://api.github.com/users/groupon/followers","following_url":"https://api.github.com/users/groupon/following{/other_user}","gists_url":"https://api.github.com/users/groupon/gists{/gist_id}","starred_url":"https://api.github.com/users/groupon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/groupon/subscriptions","organizations_url":"https://api.github.com/users/groupon/orgs","repos_url":"https://api.github.com/users/groupon/repos","events_url":"https://api.github.com/users/groupon/events{/privacy}","received_events_url":"https://api.github.com/users/groupon/received_events","type":"Organization","site_admin":false},"repo":{"id":31744923,"name":"shared-store","full_name":"groupon/shared-store","owner":{"login":"groupon","id":206233,"avatar_url":"https://avatars.githubusercontent.com/u/206233?v=3","gravatar_id":"","url":"https://api.github.com/users/groupon","html_url":"https://github.com/groupon","followers_url":"https://api.github.com/users/groupon/followers","following_url":"https://api.github.com/users/groupon/following{/other_user}","gists_url":"https://api.github.com/users/groupon/gists{/gist_id}","starred_url":"https://api.github.com/users/groupon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/groupon/subscriptions","organizations_url":"https://api.github.com/users/groupon/orgs","repos_url":"https://api.github.com/users/groupon/repos","events_url":"https://api.github.com/users/groupon/events{/privacy}","received_events_url":"https://api.github.com/users/groupon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/groupon/shared-store","description":"Keeping config data in sync","fork":false,"url":"https://api.github.com/repos/groupon/shared-store","forks_url":"https://api.github.com/repos/groupon/shared-store/forks","keys_url":"https://api.github.com/repos/groupon/shared-store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/groupon/shared-store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/groupon/shared-store/teams","hooks_url":"https://api.github.com/repos/groupon/shared-store/hooks","issue_events_url":"https://api.github.com/repos/groupon/shared-store/issues/events{/number}","events_url":"https://api.github.com/repos/groupon/shared-store/events","assignees_url":"https://api.github.com/repos/groupon/shared-store/assignees{/user}","branches_url":"https://api.github.com/repos/groupon/shared-store/branches{/branch}","tags_url":"https://api.github.com/repos/groupon/shared-store/tags","blobs_url":"https://api.github.com/repos/groupon/shared-store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/groupon/shared-store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/groupon/shared-store/git/refs{/sha}","trees_url":"https://api.github.com/repos/groupon/shared-store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/groupon/shared-store/statuses/{sha}","languages_url":"https://api.github.com/repos/groupon/shared-store/languages","stargazers_url":"https://api.github.com/repos/groupon/shared-store/stargazers","contributors_url":"https://api.github.com/repos/groupon/shared-store/contributors","subscribers_url":"https://api.github.com/repos/groupon/shared-store/subscribers","subscription_url":"https://api.github.com/repos/groupon/shared-store/subscription","commits_url":"https://api.github.com/repos/groupon/shared-store/commits{/sha}","git_commits_url":"https://api.github.com/repos/groupon/shared-store/git/commits{/sha}","comments_url":"https://api.github.com/repos/groupon/shared-store/comments{/number}","issue_comment_url":"https://api.github.com/repos/groupon/shared-store/issues/comments{/number}","contents_url":"https://api.github.com/repos/groupon/shared-store/contents/{+path}","compare_url":"https://api.github.com/repos/groupon/shared-store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/groupon/shared-store/merges","archive_url":"https://api.github.com/repos/groupon/shared-store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/groupon/shared-store/downloads","issues_url":"https://api.github.com/repos/groupon/shared-store/issues{/number}","pulls_url":"https://api.github.com/repos/groupon/shared-store/pulls{/number}","milestones_url":"https://api.github.com/repos/groupon/shared-store/milestones{/number}","notifications_url":"https://api.github.com/repos/groupon/shared-store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/groupon/shared-store/labels{/name}","releases_url":"https://api.github.com/repos/groupon/shared-store/releases{/id}","created_at":"2015-03-06T00:46:47Z","updated_at":"2015-04-03T17:50:08Z","pushed_at":"2015-04-04T01:28:07Z","git_url":"git://github.com/groupon/shared-store.git","ssh_url":"git@github.com:groupon/shared-store.git","clone_url":"https://github.com/groupon/shared-store.git","svn_url":"https://github.com/groupon/shared-store","homepage":null,"size":360,"stargazers_count":2,"watchers_count":2,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"groupon:master","ref":"master","sha":"d908237d4e76d3edeccafd708626b7b1c13a7912","user":{"login":"groupon","id":206233,"avatar_url":"https://avatars.githubusercontent.com/u/206233?v=3","gravatar_id":"","url":"https://api.github.com/users/groupon","html_url":"https://github.com/groupon","followers_url":"https://api.github.com/users/groupon/followers","following_url":"https://api.github.com/users/groupon/following{/other_user}","gists_url":"https://api.github.com/users/groupon/gists{/gist_id}","starred_url":"https://api.github.com/users/groupon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/groupon/subscriptions","organizations_url":"https://api.github.com/users/groupon/orgs","repos_url":"https://api.github.com/users/groupon/repos","events_url":"https://api.github.com/users/groupon/events{/privacy}","received_events_url":"https://api.github.com/users/groupon/received_events","type":"Organization","site_admin":false},"repo":{"id":31744923,"name":"shared-store","full_name":"groupon/shared-store","owner":{"login":"groupon","id":206233,"avatar_url":"https://avatars.githubusercontent.com/u/206233?v=3","gravatar_id":"","url":"https://api.github.com/users/groupon","html_url":"https://github.com/groupon","followers_url":"https://api.github.com/users/groupon/followers","following_url":"https://api.github.com/users/groupon/following{/other_user}","gists_url":"https://api.github.com/users/groupon/gists{/gist_id}","starred_url":"https://api.github.com/users/groupon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/groupon/subscriptions","organizations_url":"https://api.github.com/users/groupon/orgs","repos_url":"https://api.github.com/users/groupon/repos","events_url":"https://api.github.com/users/groupon/events{/privacy}","received_events_url":"https://api.github.com/users/groupon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/groupon/shared-store","description":"Keeping config data in sync","fork":false,"url":"https://api.github.com/repos/groupon/shared-store","forks_url":"https://api.github.com/repos/groupon/shared-store/forks","keys_url":"https://api.github.com/repos/groupon/shared-store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/groupon/shared-store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/groupon/shared-store/teams","hooks_url":"https://api.github.com/repos/groupon/shared-store/hooks","issue_events_url":"https://api.github.com/repos/groupon/shared-store/issues/events{/number}","events_url":"https://api.github.com/repos/groupon/shared-store/events","assignees_url":"https://api.github.com/repos/groupon/shared-store/assignees{/user}","branches_url":"https://api.github.com/repos/groupon/shared-store/branches{/branch}","tags_url":"https://api.github.com/repos/groupon/shared-store/tags","blobs_url":"https://api.github.com/repos/groupon/shared-store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/groupon/shared-store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/groupon/shared-store/git/refs{/sha}","trees_url":"https://api.github.com/repos/groupon/shared-store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/groupon/shared-store/statuses/{sha}","languages_url":"https://api.github.com/repos/groupon/shared-store/languages","stargazers_url":"https://api.github.com/repos/groupon/shared-store/stargazers","contributors_url":"https://api.github.com/repos/groupon/shared-store/contributors","subscribers_url":"https://api.github.com/repos/groupon/shared-store/subscribers","subscription_url":"https://api.github.com/repos/groupon/shared-store/subscription","commits_url":"https://api.github.com/repos/groupon/shared-store/commits{/sha}","git_commits_url":"https://api.github.com/repos/groupon/shared-store/git/commits{/sha}","comments_url":"https://api.github.com/repos/groupon/shared-store/comments{/number}","issue_comment_url":"https://api.github.com/repos/groupon/shared-store/issues/comments{/number}","contents_url":"https://api.github.com/repos/groupon/shared-store/contents/{+path}","compare_url":"https://api.github.com/repos/groupon/shared-store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/groupon/shared-store/merges","archive_url":"https://api.github.com/repos/groupon/shared-store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/groupon/shared-store/downloads","issues_url":"https://api.github.com/repos/groupon/shared-store/issues{/number}","pulls_url":"https://api.github.com/repos/groupon/shared-store/pulls{/number}","milestones_url":"https://api.github.com/repos/groupon/shared-store/milestones{/number}","notifications_url":"https://api.github.com/repos/groupon/shared-store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/groupon/shared-store/labels{/name}","releases_url":"https://api.github.com/repos/groupon/shared-store/releases{/id}","created_at":"2015-03-06T00:46:47Z","updated_at":"2015-04-03T17:50:08Z","pushed_at":"2015-04-04T01:28:07Z","git_url":"git://github.com/groupon/shared-store.git","ssh_url":"git@github.com:groupon/shared-store.git","clone_url":"https://github.com/groupon/shared-store.git","svn_url":"https://github.com/groupon/shared-store","homepage":null,"size":360,"stargazers_count":2,"watchers_count":2,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/groupon/shared-store/pulls/15"},"html":{"href":"https://github.com/groupon/shared-store/pull/15"},"issue":{"href":"https://api.github.com/repos/groupon/shared-store/issues/15"},"comments":{"href":"https://api.github.com/repos/groupon/shared-store/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/groupon/shared-store/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/groupon/shared-store/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/groupon/shared-store/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/groupon/shared-store/statuses/bb79e12f63fa90fbfbb0cb36d1308481667142fa"}}}}