{"action":"created","comment":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/comments/41537936","id":41537936,"diff_hunk":"@@ -116,17 +114,17 @@ tachyon.user.heartbeat.interval.ms=1000\n tachyon.user.file.writetype.default=CACHE_THROUGH\n tachyon.user.file.tachyonstoragetype.default=STORE\n tachyon.user.file.understoragetype.default=SYNC_PERSIST\n-tachyon.user.default.block.size.byte=512MB\n+tachyon.user.block.size.bytes.default=512MB\n tachyon.user.quota.unit.bytes=8MB\n tachyon.user.file.buffer.bytes=1MB\n-tachyon.user.remote.block.reader.class=tachyon.client.netty.NettyRemoteBlockReader\n-tachyon.user.remote.block.writer.class=tachyon.client.netty.NettyRemoteBlockWriter\n-tachyon.user.remote.read.buffer.size.byte=8MB\n+tachyon.user.block.remote.reader.class=tachyon.client.netty.NettyRemoteBlockReader\n+tachyon.user.block.remote.writer.class=tachyon.client.netty.NettyRemoteBlockWriter\n+tachyon.user.block.remote.read.buffer.size.bytes=8MB\n tachyon.user.network.netty.worker.threads=0\n tachyon.user.network.netty.timeout.ms=3000\n-tachyon.user.remote.block.worker.client.threads=10\n-tachyon.user.local.block.worker.client.threads=10000\n+tachyon.user.block.remote.worker.client.threads=10","path":"common/src/main/resources/tachyon-default.properties","position":107,"original_position":107,"commit_id":"2b648bea00ffdd38ce098fdc4f91e11706241363","original_commit_id":"2b648bea00ffdd38ce098fdc4f91e11706241363","user":{"login":"apc999","id":1413748,"avatar_url":"https://avatars.githubusercontent.com/u/1413748?v=3","gravatar_id":"","url":"https://api.github.com/users/apc999","html_url":"https://github.com/apc999","followers_url":"https://api.github.com/users/apc999/followers","following_url":"https://api.github.com/users/apc999/following{/other_user}","gists_url":"https://api.github.com/users/apc999/gists{/gist_id}","starred_url":"https://api.github.com/users/apc999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apc999/subscriptions","organizations_url":"https://api.github.com/users/apc999/orgs","repos_url":"https://api.github.com/users/apc999/repos","events_url":"https://api.github.com/users/apc999/events{/privacy}","received_events_url":"https://api.github.com/users/apc999/received_events","type":"User","site_admin":false},"body":"I slightly prefer `tachyon.remote.worker` and `tachyn.local.worker` as first, we have already been using prefix `tachyon.remote.worker` in properties like `tachyon.user.block.remote.reader.class` and `tachyon.user.block.remote.writer.class`, and they are related. Also `worker.client.threads` is really the identity of this property, I thought they make sense to be put together. \r\n","created_at":"2015-10-08T16:47:42Z","updated_at":"2015-10-08T16:47:42Z","html_url":"https://github.com/amplab/tachyon/pull/1733#discussion_r41537936","pull_request_url":"https://api.github.com/repos/amplab/tachyon/pulls/1733","_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments/41537936"},"html":{"href":"https://github.com/amplab/tachyon/pull/1733#discussion_r41537936"},"pull_request":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/1733"}}},"pull_request":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/1733","id":47116245,"html_url":"https://github.com/amplab/tachyon/pull/1733","diff_url":"https://github.com/amplab/tachyon/pull/1733.diff","patch_url":"https://github.com/amplab/tachyon/pull/1733.patch","issue_url":"https://api.github.com/repos/amplab/tachyon/issues/1733","number":1733,"state":"open","locked":false,"title":"[TACHYON-1106] Property name cleanup","user":{"login":"apc999","id":1413748,"avatar_url":"https://avatars.githubusercontent.com/u/1413748?v=3","gravatar_id":"","url":"https://api.github.com/users/apc999","html_url":"https://github.com/apc999","followers_url":"https://api.github.com/users/apc999/followers","following_url":"https://api.github.com/users/apc999/following{/other_user}","gists_url":"https://api.github.com/users/apc999/gists{/gist_id}","starred_url":"https://api.github.com/users/apc999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apc999/subscriptions","organizations_url":"https://api.github.com/users/apc999/orgs","repos_url":"https://api.github.com/users/apc999/repos","events_url":"https://api.github.com/users/apc999/events{/privacy}","received_events_url":"https://api.github.com/users/apc999/received_events","type":"User","site_admin":false},"body":"https://tachyon.atlassian.net/browse/TACHYON-1106\r\n\r\nThis PR only renames the properties. If this PR is good and merged, I will submit a followup PR to update `tachyon.Constants` \r\n\r\nReal changes are in `common/src/main/resources/tachyon-default.properties` --- other changes are done by IDE automatically. ","created_at":"2015-10-08T06:35:01Z","updated_at":"2015-10-08T16:47:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"72e486b63e6af2351ad2e0bad5848f8bcd624787","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/amplab/tachyon/pulls/1733/commits","review_comments_url":"https://api.github.com/repos/amplab/tachyon/pulls/1733/comments","review_comment_url":"https://api.github.com/repos/amplab/tachyon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/amplab/tachyon/issues/1733/comments","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/2b648bea00ffdd38ce098fdc4f91e11706241363","head":{"label":"apc999:TACHYON-1106","ref":"TACHYON-1106","sha":"2b648bea00ffdd38ce098fdc4f91e11706241363","user":{"login":"apc999","id":1413748,"avatar_url":"https://avatars.githubusercontent.com/u/1413748?v=3","gravatar_id":"","url":"https://api.github.com/users/apc999","html_url":"https://github.com/apc999","followers_url":"https://api.github.com/users/apc999/followers","following_url":"https://api.github.com/users/apc999/following{/other_user}","gists_url":"https://api.github.com/users/apc999/gists{/gist_id}","starred_url":"https://api.github.com/users/apc999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apc999/subscriptions","organizations_url":"https://api.github.com/users/apc999/orgs","repos_url":"https://api.github.com/users/apc999/repos","events_url":"https://api.github.com/users/apc999/events{/privacy}","received_events_url":"https://api.github.com/users/apc999/received_events","type":"User","site_admin":false},"repo":{"id":32042306,"name":"tachyon","full_name":"apc999/tachyon","owner":{"login":"apc999","id":1413748,"avatar_url":"https://avatars.githubusercontent.com/u/1413748?v=3","gravatar_id":"","url":"https://api.github.com/users/apc999","html_url":"https://github.com/apc999","followers_url":"https://api.github.com/users/apc999/followers","following_url":"https://api.github.com/users/apc999/following{/other_user}","gists_url":"https://api.github.com/users/apc999/gists{/gist_id}","starred_url":"https://api.github.com/users/apc999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apc999/subscriptions","organizations_url":"https://api.github.com/users/apc999/orgs","repos_url":"https://api.github.com/users/apc999/repos","events_url":"https://api.github.com/users/apc999/events{/privacy}","received_events_url":"https://api.github.com/users/apc999/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/apc999/tachyon","description":" A Reliable Memory Centric Distributed Storage System","fork":true,"url":"https://api.github.com/repos/apc999/tachyon","forks_url":"https://api.github.com/repos/apc999/tachyon/forks","keys_url":"https://api.github.com/repos/apc999/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apc999/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apc999/tachyon/teams","hooks_url":"https://api.github.com/repos/apc999/tachyon/hooks","issue_events_url":"https://api.github.com/repos/apc999/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/apc999/tachyon/events","assignees_url":"https://api.github.com/repos/apc999/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/apc999/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/apc999/tachyon/tags","blobs_url":"https://api.github.com/repos/apc999/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apc999/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apc999/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/apc999/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apc999/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/apc999/tachyon/languages","stargazers_url":"https://api.github.com/repos/apc999/tachyon/stargazers","contributors_url":"https://api.github.com/repos/apc999/tachyon/contributors","subscribers_url":"https://api.github.com/repos/apc999/tachyon/subscribers","subscription_url":"https://api.github.com/repos/apc999/tachyon/subscription","commits_url":"https://api.github.com/repos/apc999/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/apc999/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/apc999/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/apc999/tachyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/apc999/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/apc999/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apc999/tachyon/merges","archive_url":"https://api.github.com/repos/apc999/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apc999/tachyon/downloads","issues_url":"https://api.github.com/repos/apc999/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/apc999/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/apc999/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/apc999/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apc999/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/apc999/tachyon/releases{/id}","created_at":"2015-03-11T21:31:13Z","updated_at":"2015-05-12T21:15:01Z","pushed_at":"2015-10-08T08:00:22Z","git_url":"git://github.com/apc999/tachyon.git","ssh_url":"git@github.com:apc999/tachyon.git","clone_url":"https://github.com/apc999/tachyon.git","svn_url":"https://github.com/apc999/tachyon","homepage":"http://tachyon-project.org","size":25573,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"amplab:master","ref":"master","sha":"2e967920f2d9d372ad573872c1fcacd1dd4b08de","user":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=3","gravatar_id":"","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"name":"tachyon","full_name":"amplab/tachyon","owner":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=3","gravatar_id":"","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/amplab/tachyon","description":"Memory Centric Reliable Distributed Storage","fork":false,"url":"https://api.github.com/repos/amplab/tachyon","forks_url":"https://api.github.com/repos/amplab/tachyon/forks","keys_url":"https://api.github.com/repos/amplab/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amplab/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amplab/tachyon/teams","hooks_url":"https://api.github.com/repos/amplab/tachyon/hooks","issue_events_url":"https://api.github.com/repos/amplab/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/amplab/tachyon/events","assignees_url":"https://api.github.com/repos/amplab/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/amplab/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/amplab/tachyon/tags","blobs_url":"https://api.github.com/repos/amplab/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amplab/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amplab/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/amplab/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/amplab/tachyon/languages","stargazers_url":"https://api.github.com/repos/amplab/tachyon/stargazers","contributors_url":"https://api.github.com/repos/amplab/tachyon/contributors","subscribers_url":"https://api.github.com/repos/amplab/tachyon/subscribers","subscription_url":"https://api.github.com/repos/amplab/tachyon/subscription","commits_url":"https://api.github.com/repos/amplab/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/amplab/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/amplab/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/amplab/tachyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/amplab/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/amplab/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amplab/tachyon/merges","archive_url":"https://api.github.com/repos/amplab/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amplab/tachyon/downloads","issues_url":"https://api.github.com/repos/amplab/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/amplab/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/amplab/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/amplab/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amplab/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/amplab/tachyon/releases{/id}","created_at":"2012-12-21T17:43:46Z","updated_at":"2015-10-08T07:45:44Z","pushed_at":"2015-10-08T16:34:13Z","git_url":"git://github.com/amplab/tachyon.git","ssh_url":"git@github.com:amplab/tachyon.git","clone_url":"https://github.com/amplab/tachyon.git","svn_url":"https://github.com/amplab/tachyon","homepage":"http://tachyon-project.org","size":53252,"stargazers_count":1613,"watchers_count":1613,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":649,"mirror_url":null,"open_issues_count":33,"forks":649,"open_issues":33,"watchers":1613,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/1733"},"html":{"href":"https://github.com/amplab/tachyon/pull/1733"},"issue":{"href":"https://api.github.com/repos/amplab/tachyon/issues/1733"},"comments":{"href":"https://api.github.com/repos/amplab/tachyon/issues/1733/comments"},"review_comments":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/1733/comments"},"review_comment":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/1733/commits"},"statuses":{"href":"https://api.github.com/repos/amplab/tachyon/statuses/2b648bea00ffdd38ce098fdc4f91e11706241363"}}}}