{"action":"created","comment":{"url":"https://api.github.com/repos/rotundasoftware/cartero/pulls/comments/43075325","id":43075325,"diff_hunk":"@@ -22,11 +22,17 @@ module.exports = function( file, options ) {\n \t\t\tvar url = pathMapper( assetSrcAbsPath, function( srcDir ) {\n \t\t\t\treturn options.packagePathsToIds[ srcDir ] ? '/' + options.packagePathsToIds[ srcDir ] : null; // return val of outputDirPath needs to be absolute path\n \t\t\t} );\n-\t\t\n+\n \t\t\t// all assets urls should be different than their paths.. otherwise we have a problem\n \t\t\tif( url === assetSrcAbsPath )\n \t\t\t\treturn _this.emit( 'error', new Error( 'The file \"' + assetSrcAbsPath + '\" referenced from ##asset_url( \"' + assetSrcPath + '\" ) in file \"' + file + '\" is not an asset.' ) );\n \n+\t\t\t// TODO: shall we fix path-mapper instead of doing this?\n+\t\t\tvar filename = path.basename(assetSrcAbsPath);","path":"transforms/asset_url.js","position":11,"original_position":11,"commit_id":"cee9fed6482f434858f8ffa781b36c490a92d59c","original_commit_id":"786588afed572ae185aec07f9e4f4281b367a861","user":{"login":"dgbeck","id":1483694,"avatar_url":"https://avatars.githubusercontent.com/u/1483694?v=3","gravatar_id":"","url":"https://api.github.com/users/dgbeck","html_url":"https://github.com/dgbeck","followers_url":"https://api.github.com/users/dgbeck/followers","following_url":"https://api.github.com/users/dgbeck/following{/other_user}","gists_url":"https://api.github.com/users/dgbeck/gists{/gist_id}","starred_url":"https://api.github.com/users/dgbeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgbeck/subscriptions","organizations_url":"https://api.github.com/users/dgbeck/orgs","repos_url":"https://api.github.com/users/dgbeck/repos","events_url":"https://api.github.com/users/dgbeck/events{/privacy}","received_events_url":"https://api.github.com/users/dgbeck/received_events","type":"User","site_admin":false},"body":"suppose filename == `'chorizo'`, and url == `'/i/eat/chorizo/and/then/another/chorizo'`","created_at":"2015-10-27T01:18:40Z","updated_at":"2015-10-27T01:18:40Z","html_url":"https://github.com/rotundasoftware/cartero/pull/45#discussion_r43075325","pull_request_url":"https://api.github.com/repos/rotundasoftware/cartero/pulls/45","_links":{"self":{"href":"https://api.github.com/repos/rotundasoftware/cartero/pulls/comments/43075325"},"html":{"href":"https://github.com/rotundasoftware/cartero/pull/45#discussion_r43075325"},"pull_request":{"href":"https://api.github.com/repos/rotundasoftware/cartero/pulls/45"}}},"pull_request":{"url":"https://api.github.com/repos/rotundasoftware/cartero/pulls/45","id":48670029,"html_url":"https://github.com/rotundasoftware/cartero/pull/45","diff_url":"https://github.com/rotundasoftware/cartero/pull/45.diff","patch_url":"https://github.com/rotundasoftware/cartero/pull/45.patch","issue_url":"https://api.github.com/repos/rotundasoftware/cartero/issues/45","number":45,"state":"open","locked":false,"title":"Add support for cache busting assets - sync version","user":{"login":"ferlores","id":972699,"avatar_url":"https://avatars.githubusercontent.com/u/972699?v=3","gravatar_id":"","url":"https://api.github.com/users/ferlores","html_url":"https://github.com/ferlores","followers_url":"https://api.github.com/users/ferlores/followers","following_url":"https://api.github.com/users/ferlores/following{/other_user}","gists_url":"https://api.github.com/users/ferlores/gists{/gist_id}","starred_url":"https://api.github.com/users/ferlores/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferlores/subscriptions","organizations_url":"https://api.github.com/users/ferlores/orgs","repos_url":"https://api.github.com/users/ferlores/repos","events_url":"https://api.github.com/users/ferlores/events{/privacy}","received_events_url":"https://api.github.com/users/ferlores/received_events","type":"User","site_admin":false},"body":"@dgbeck Here is the PR where I calculate the shasum in a sync way so it doesn't need changes in parcelify. I think it makes sense so far. Please let me know what you think.\r\n\r\nRelated to #43 ","created_at":"2015-10-25T02:16:37Z","updated_at":"2015-10-27T01:18:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5eceab26c9cbc9666092f1c291509d95de78359","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rotundasoftware/cartero/pulls/45/commits","review_comments_url":"https://api.github.com/repos/rotundasoftware/cartero/pulls/45/comments","review_comment_url":"https://api.github.com/repos/rotundasoftware/cartero/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rotundasoftware/cartero/issues/45/comments","statuses_url":"https://api.github.com/repos/rotundasoftware/cartero/statuses/cee9fed6482f434858f8ffa781b36c490a92d59c","head":{"label":"ferlores:assets","ref":"assets","sha":"cee9fed6482f434858f8ffa781b36c490a92d59c","user":{"login":"ferlores","id":972699,"avatar_url":"https://avatars.githubusercontent.com/u/972699?v=3","gravatar_id":"","url":"https://api.github.com/users/ferlores","html_url":"https://github.com/ferlores","followers_url":"https://api.github.com/users/ferlores/followers","following_url":"https://api.github.com/users/ferlores/following{/other_user}","gists_url":"https://api.github.com/users/ferlores/gists{/gist_id}","starred_url":"https://api.github.com/users/ferlores/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferlores/subscriptions","organizations_url":"https://api.github.com/users/ferlores/orgs","repos_url":"https://api.github.com/users/ferlores/repos","events_url":"https://api.github.com/users/ferlores/events{/privacy}","received_events_url":"https://api.github.com/users/ferlores/received_events","type":"User","site_admin":false},"repo":{"id":24378804,"name":"cartero","full_name":"ferlores/cartero","owner":{"login":"ferlores","id":972699,"avatar_url":"https://avatars.githubusercontent.com/u/972699?v=3","gravatar_id":"","url":"https://api.github.com/users/ferlores","html_url":"https://github.com/ferlores","followers_url":"https://api.github.com/users/ferlores/followers","following_url":"https://api.github.com/users/ferlores/following{/other_user}","gists_url":"https://api.github.com/users/ferlores/gists{/gist_id}","starred_url":"https://api.github.com/users/ferlores/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferlores/subscriptions","organizations_url":"https://api.github.com/users/ferlores/orgs","repos_url":"https://api.github.com/users/ferlores/repos","events_url":"https://api.github.com/users/ferlores/events{/privacy}","received_events_url":"https://api.github.com/users/ferlores/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ferlores/cartero","description":"Modular front end development for the masses. Built on npm and browserify.","fork":true,"url":"https://api.github.com/repos/ferlores/cartero","forks_url":"https://api.github.com/repos/ferlores/cartero/forks","keys_url":"https://api.github.com/repos/ferlores/cartero/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ferlores/cartero/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ferlores/cartero/teams","hooks_url":"https://api.github.com/repos/ferlores/cartero/hooks","issue_events_url":"https://api.github.com/repos/ferlores/cartero/issues/events{/number}","events_url":"https://api.github.com/repos/ferlores/cartero/events","assignees_url":"https://api.github.com/repos/ferlores/cartero/assignees{/user}","branches_url":"https://api.github.com/repos/ferlores/cartero/branches{/branch}","tags_url":"https://api.github.com/repos/ferlores/cartero/tags","blobs_url":"https://api.github.com/repos/ferlores/cartero/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ferlores/cartero/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ferlores/cartero/git/refs{/sha}","trees_url":"https://api.github.com/repos/ferlores/cartero/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ferlores/cartero/statuses/{sha}","languages_url":"https://api.github.com/repos/ferlores/cartero/languages","stargazers_url":"https://api.github.com/repos/ferlores/cartero/stargazers","contributors_url":"https://api.github.com/repos/ferlores/cartero/contributors","subscribers_url":"https://api.github.com/repos/ferlores/cartero/subscribers","subscription_url":"https://api.github.com/repos/ferlores/cartero/subscription","commits_url":"https://api.github.com/repos/ferlores/cartero/commits{/sha}","git_commits_url":"https://api.github.com/repos/ferlores/cartero/git/commits{/sha}","comments_url":"https://api.github.com/repos/ferlores/cartero/comments{/number}","issue_comment_url":"https://api.github.com/repos/ferlores/cartero/issues/comments{/number}","contents_url":"https://api.github.com/repos/ferlores/cartero/contents/{+path}","compare_url":"https://api.github.com/repos/ferlores/cartero/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ferlores/cartero/merges","archive_url":"https://api.github.com/repos/ferlores/cartero/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ferlores/cartero/downloads","issues_url":"https://api.github.com/repos/ferlores/cartero/issues{/number}","pulls_url":"https://api.github.com/repos/ferlores/cartero/pulls{/number}","milestones_url":"https://api.github.com/repos/ferlores/cartero/milestones{/number}","notifications_url":"https://api.github.com/repos/ferlores/cartero/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ferlores/cartero/labels{/name}","releases_url":"https://api.github.com/repos/ferlores/cartero/releases{/id}","created_at":"2014-09-23T16:07:22Z","updated_at":"2014-09-23T16:18:50Z","pushed_at":"2015-10-26T22:45:35Z","git_url":"git://github.com/ferlores/cartero.git","ssh_url":"git@github.com:ferlores/cartero.git","clone_url":"https://github.com/ferlores/cartero.git","svn_url":"https://github.com/ferlores/cartero","homepage":"","size":17929,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rotundasoftware:master","ref":"master","sha":"e8d3a72eed399368105f41fa94991c17cf2c13fd","user":{"login":"rotundasoftware","id":3394374,"avatar_url":"https://avatars.githubusercontent.com/u/3394374?v=3","gravatar_id":"","url":"https://api.github.com/users/rotundasoftware","html_url":"https://github.com/rotundasoftware","followers_url":"https://api.github.com/users/rotundasoftware/followers","following_url":"https://api.github.com/users/rotundasoftware/following{/other_user}","gists_url":"https://api.github.com/users/rotundasoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/rotundasoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rotundasoftware/subscriptions","organizations_url":"https://api.github.com/users/rotundasoftware/orgs","repos_url":"https://api.github.com/users/rotundasoftware/repos","events_url":"https://api.github.com/users/rotundasoftware/events{/privacy}","received_events_url":"https://api.github.com/users/rotundasoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":9752933,"name":"cartero","full_name":"rotundasoftware/cartero","owner":{"login":"rotundasoftware","id":3394374,"avatar_url":"https://avatars.githubusercontent.com/u/3394374?v=3","gravatar_id":"","url":"https://api.github.com/users/rotundasoftware","html_url":"https://github.com/rotundasoftware","followers_url":"https://api.github.com/users/rotundasoftware/followers","following_url":"https://api.github.com/users/rotundasoftware/following{/other_user}","gists_url":"https://api.github.com/users/rotundasoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/rotundasoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rotundasoftware/subscriptions","organizations_url":"https://api.github.com/users/rotundasoftware/orgs","repos_url":"https://api.github.com/users/rotundasoftware/repos","events_url":"https://api.github.com/users/rotundasoftware/events{/privacy}","received_events_url":"https://api.github.com/users/rotundasoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rotundasoftware/cartero","description":"Modular front end development for multi-page web applications.","fork":false,"url":"https://api.github.com/repos/rotundasoftware/cartero","forks_url":"https://api.github.com/repos/rotundasoftware/cartero/forks","keys_url":"https://api.github.com/repos/rotundasoftware/cartero/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rotundasoftware/cartero/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rotundasoftware/cartero/teams","hooks_url":"https://api.github.com/repos/rotundasoftware/cartero/hooks","issue_events_url":"https://api.github.com/repos/rotundasoftware/cartero/issues/events{/number}","events_url":"https://api.github.com/repos/rotundasoftware/cartero/events","assignees_url":"https://api.github.com/repos/rotundasoftware/cartero/assignees{/user}","branches_url":"https://api.github.com/repos/rotundasoftware/cartero/branches{/branch}","tags_url":"https://api.github.com/repos/rotundasoftware/cartero/tags","blobs_url":"https://api.github.com/repos/rotundasoftware/cartero/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rotundasoftware/cartero/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rotundasoftware/cartero/git/refs{/sha}","trees_url":"https://api.github.com/repos/rotundasoftware/cartero/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rotundasoftware/cartero/statuses/{sha}","languages_url":"https://api.github.com/repos/rotundasoftware/cartero/languages","stargazers_url":"https://api.github.com/repos/rotundasoftware/cartero/stargazers","contributors_url":"https://api.github.com/repos/rotundasoftware/cartero/contributors","subscribers_url":"https://api.github.com/repos/rotundasoftware/cartero/subscribers","subscription_url":"https://api.github.com/repos/rotundasoftware/cartero/subscription","commits_url":"https://api.github.com/repos/rotundasoftware/cartero/commits{/sha}","git_commits_url":"https://api.github.com/repos/rotundasoftware/cartero/git/commits{/sha}","comments_url":"https://api.github.com/repos/rotundasoftware/cartero/comments{/number}","issue_comment_url":"https://api.github.com/repos/rotundasoftware/cartero/issues/comments{/number}","contents_url":"https://api.github.com/repos/rotundasoftware/cartero/contents/{+path}","compare_url":"https://api.github.com/repos/rotundasoftware/cartero/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rotundasoftware/cartero/merges","archive_url":"https://api.github.com/repos/rotundasoftware/cartero/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rotundasoftware/cartero/downloads","issues_url":"https://api.github.com/repos/rotundasoftware/cartero/issues{/number}","pulls_url":"https://api.github.com/repos/rotundasoftware/cartero/pulls{/number}","milestones_url":"https://api.github.com/repos/rotundasoftware/cartero/milestones{/number}","notifications_url":"https://api.github.com/repos/rotundasoftware/cartero/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rotundasoftware/cartero/labels{/name}","releases_url":"https://api.github.com/repos/rotundasoftware/cartero/releases{/id}","created_at":"2013-04-29T16:46:34Z","updated_at":"2015-09-24T15:47:04Z","pushed_at":"2015-10-26T22:45:35Z","git_url":"git://github.com/rotundasoftware/cartero.git","ssh_url":"git@github.com:rotundasoftware/cartero.git","clone_url":"https://github.com/rotundasoftware/cartero.git","svn_url":"https://github.com/rotundasoftware/cartero","homepage":"","size":19524,"stargazers_count":193,"watchers_count":193,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":16,"mirror_url":null,"open_issues_count":2,"forks":16,"open_issues":2,"watchers":193,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rotundasoftware/cartero/pulls/45"},"html":{"href":"https://github.com/rotundasoftware/cartero/pull/45"},"issue":{"href":"https://api.github.com/repos/rotundasoftware/cartero/issues/45"},"comments":{"href":"https://api.github.com/repos/rotundasoftware/cartero/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/rotundasoftware/cartero/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/rotundasoftware/cartero/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rotundasoftware/cartero/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/rotundasoftware/cartero/statuses/cee9fed6482f434858f8ffa781b36c490a92d59c"}}}}