{"action":"created","issue":{"url":"https://api.github.com/repos/opower/jpile/issues/34","labels_url":"https://api.github.com/repos/opower/jpile/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/opower/jpile/issues/34/comments","events_url":"https://api.github.com/repos/opower/jpile/issues/34/events","html_url":"https://github.com/opower/jpile/pull/34","id":56856459,"number":34,"title":"Field converters and field annotations","user":{"login":"aldenquimby","id":2145098,"avatar_url":"https://avatars.githubusercontent.com/u/2145098?v=3","gravatar_id":"","url":"https://api.github.com/users/aldenquimby","html_url":"https://github.com/aldenquimby","followers_url":"https://api.github.com/users/aldenquimby/followers","following_url":"https://api.github.com/users/aldenquimby/following{/other_user}","gists_url":"https://api.github.com/users/aldenquimby/gists{/gist_id}","starred_url":"https://api.github.com/users/aldenquimby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aldenquimby/subscriptions","organizations_url":"https://api.github.com/users/aldenquimby/orgs","repos_url":"https://api.github.com/users/aldenquimby/repos","events_url":"https://api.github.com/users/aldenquimby/events{/privacy}","received_events_url":"https://api.github.com/users/aldenquimby/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-02-06T19:29:47Z","updated_at":"2015-02-07T17:36:16Z","closed_at":"2015-02-07T17:29:07Z","pull_request":{"url":"https://api.github.com/repos/opower/jpile/pulls/34","html_url":"https://github.com/opower/jpile/pull/34","diff_url":"https://github.com/opower/jpile/pull/34.diff","patch_url":"https://github.com/opower/jpile/pull/34.patch"},"body":"#### Summary\r\n1. Adds `FieldConverter`s to object loaders, which lets users specify conversions of certain types before appending each field to an infile row\r\n  - my use case was mostly joda time and enums\r\n  - generic solution allows anyone to plug in additional types\r\n2. Update annotation inspector to allow JPA annotations to be on fields instead of getters\r\n\r\n#### Task list\r\n- [x] add field converters\r\n- [x] support field annotations\r\n- [x] add tests for field converters\r\n- [x] add tests for field annotation support\r\n- [ ] clean commit logs"},"comment":{"url":"https://api.github.com/repos/opower/jpile/issues/comments/73373932","html_url":"https://github.com/opower/jpile/pull/34#issuecomment-73373932","issue_url":"https://api.github.com/repos/opower/jpile/issues/34","id":73373932,"user":{"login":"aldenquimby","id":2145098,"avatar_url":"https://avatars.githubusercontent.com/u/2145098?v=3","gravatar_id":"","url":"https://api.github.com/users/aldenquimby","html_url":"https://github.com/aldenquimby","followers_url":"https://api.github.com/users/aldenquimby/followers","following_url":"https://api.github.com/users/aldenquimby/following{/other_user}","gists_url":"https://api.github.com/users/aldenquimby/gists{/gist_id}","starred_url":"https://api.github.com/users/aldenquimby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aldenquimby/subscriptions","organizations_url":"https://api.github.com/users/aldenquimby/orgs","repos_url":"https://api.github.com/users/aldenquimby/repos","events_url":"https://api.github.com/users/aldenquimby/events{/privacy}","received_events_url":"https://api.github.com/users/aldenquimby/received_events","type":"User","site_admin":false},"created_at":"2015-02-07T17:36:16Z","updated_at":"2015-02-07T17:36:16Z","body":"I accidentally borked my git history while trying to rebase and this PR auto-closed itself. I made a new one with the commits properly squashed: https://github.com/opower/jpile/pull/35"}}