{"action":"closed","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/issues/366","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/issues/366/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/issues/366/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/issues/366/events","html_url":"https://github.com/GoogleCloudPlatform/cloud-bigtable-client/issues/366","id":96205671,"number":366,"title":"Shouldn't Cluster.hdd_bytes and Cluster.ssd_bytes be in a oneof block?","user":{"login":"dhermes","id":520669,"avatar_url":"https://avatars.githubusercontent.com/u/520669?v=3","gravatar_id":"","url":"https://api.github.com/users/dhermes","html_url":"https://github.com/dhermes","followers_url":"https://api.github.com/users/dhermes/followers","following_url":"https://api.github.com/users/dhermes/following{/other_user}","gists_url":"https://api.github.com/users/dhermes/gists{/gist_id}","starred_url":"https://api.github.com/users/dhermes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhermes/subscriptions","organizations_url":"https://api.github.com/users/dhermes/orgs","repos_url":"https://api.github.com/users/dhermes/repos","events_url":"https://api.github.com/users/dhermes/events{/privacy}","received_events_url":"https://api.github.com/users/dhermes/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/labels/question","name":"question","color":"cc317c"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-07-21T01:34:04Z","updated_at":"2015-09-02T18:38:05Z","closed_at":"2015-09-02T18:38:05Z","body":"I'm implementing the Python library for the API and noticed that both `hdd_bytes` and `ssd_bytes` can be set on a `CreateCluster` call (and they persist when calling `GetCluster`).\r\n\r\nShouldn't the values (in the `Cluster` [message class][1]) be in a [`oneof` block][2]:\r\n\r\n```\r\n  // The maximum HDD storage usage allowed in this cluster, in bytes.\r\n  int64 hdd_bytes = 6;\r\n\r\n  // The maximum SSD storage usage allowed in this cluster, in bytes.\r\n  int64 ssd_bytes = 7;\r\n```\r\n\r\n[1]: https://github.com/GoogleCloudPlatform/cloud-bigtable-client/blob/abe13c41f6df8e3659edffc86ea2feee678b8363/bigtable-protos/src/main/proto/google/bigtable/admin/cluster/v1/bigtable_cluster_data.proto#L82-L86\r\n[2]: https://developers.google.com/protocol-buffers/docs/proto#oneof"}}