{"action":"created","comment":{"url":"https://api.github.com/repos/contiki-os/contiki/pulls/comments/30330649","id":30330649,"diff_hunk":"@@ -30,22 +30,23 @@\n  *  OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n  */\n /**\n- * \\addtogroup cc2538dk\n+ * \\addtogroup cc2538\n  * @{\n  *\n  * \\file\n- * Startup code for the cc2538dk platform, to be used when building with gcc\n+ * Startup code for the cc2538 chip, to be used when building with gcc\n  */\n #include \"contiki.h\"\n #include \"reg.h\"\n #include \"flash-cca.h\"\n #include \"sys-ctrl.h\"\n-#include \"uart.h\"\n \n #include <stdint.h>\n /*---------------------------------------------------------------------------*/\n extern int main(void);\n /*---------------------------------------------------------------------------*/\n+#define WEAK_ALIAS(x) __attribute__ ((weak, alias(#x)))","path":"cpu/cc2538/startup-gcc.c","position":22,"original_position":22,"commit_id":"f7baf5aba2cb2916eb6e44c8ed40bcc70e145cd3","original_commit_id":"f7baf5aba2cb2916eb6e44c8ed40bcc70e145cd3","user":{"login":"adamdunkels","id":589970,"avatar_url":"https://avatars.githubusercontent.com/u/589970?v=3","gravatar_id":"","url":"https://api.github.com/users/adamdunkels","html_url":"https://github.com/adamdunkels","followers_url":"https://api.github.com/users/adamdunkels/followers","following_url":"https://api.github.com/users/adamdunkels/following{/other_user}","gists_url":"https://api.github.com/users/adamdunkels/gists{/gist_id}","starred_url":"https://api.github.com/users/adamdunkels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamdunkels/subscriptions","organizations_url":"https://api.github.com/users/adamdunkels/orgs","repos_url":"https://api.github.com/users/adamdunkels/repos","events_url":"https://api.github.com/users/adamdunkels/events{/privacy}","received_events_url":"https://api.github.com/users/adamdunkels/received_events","type":"User","site_admin":false},"body":"How many? And where in the tree are they located?","created_at":"2015-05-14T15:30:02Z","updated_at":"2015-05-14T15:30:02Z","html_url":"https://github.com/contiki-os/contiki/pull/966#discussion_r30330649","pull_request_url":"https://api.github.com/repos/contiki-os/contiki/pulls/966","_links":{"self":{"href":"https://api.github.com/repos/contiki-os/contiki/pulls/comments/30330649"},"html":{"href":"https://github.com/contiki-os/contiki/pull/966#discussion_r30330649"},"pull_request":{"href":"https://api.github.com/repos/contiki-os/contiki/pulls/966"}}},"pull_request":{"url":"https://api.github.com/repos/contiki-os/contiki/pulls/966","id":29508432,"html_url":"https://github.com/contiki-os/contiki/pull/966","diff_url":"https://github.com/contiki-os/contiki/pull/966.diff","patch_url":"https://github.com/contiki-os/contiki/pull/966.patch","issue_url":"https://api.github.com/repos/contiki-os/contiki/issues/966","number":966,"state":"open","locked":false,"title":"Move cc2538 startup-gcc.c to the CPU dir","user":{"login":"g-oikonomou","id":705207,"avatar_url":"https://avatars.githubusercontent.com/u/705207?v=3","gravatar_id":"","url":"https://api.github.com/users/g-oikonomou","html_url":"https://github.com/g-oikonomou","followers_url":"https://api.github.com/users/g-oikonomou/followers","following_url":"https://api.github.com/users/g-oikonomou/following{/other_user}","gists_url":"https://api.github.com/users/g-oikonomou/gists{/gist_id}","starred_url":"https://api.github.com/users/g-oikonomou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/g-oikonomou/subscriptions","organizations_url":"https://api.github.com/users/g-oikonomou/orgs","repos_url":"https://api.github.com/users/g-oikonomou/repos","events_url":"https://api.github.com/users/g-oikonomou/events{/privacy}","received_events_url":"https://api.github.com/users/g-oikonomou/received_events","type":"User","site_admin":false},"body":"This pull proposes moving CC2538's `startup-gcc.c` to the CPU dir. This file contains startup code and initialises the vector table.\r\n\r\n@adamdunkels suggested this move a few months ago, but I had some concerns about the various `#if` statements used to manage some of the interrupt handlers. Looks like they were unfounded, but please take a look if you will.\r\n\r\nIn the longer term, I think we should use weak symbols here for handlers. It should help get rid of those `#if`s altogether.\r\n\r\nThis pull also sneaks in a minor code style fix.","created_at":"2015-02-18T08:33:36Z","updated_at":"2015-05-14T15:30:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4f28854d5f386f573ce602bad620b9f89db1832","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/contiki-os/contiki/pulls/966/commits","review_comments_url":"https://api.github.com/repos/contiki-os/contiki/pulls/966/comments","review_comment_url":"https://api.github.com/repos/contiki-os/contiki/pulls/comments{/number}","comments_url":"https://api.github.com/repos/contiki-os/contiki/issues/966/comments","statuses_url":"https://api.github.com/repos/contiki-os/contiki/statuses/f7baf5aba2cb2916eb6e44c8ed40bcc70e145cd3","head":{"label":"g-oikonomou:cc2538-startup-to-cpu-dir","ref":"cc2538-startup-to-cpu-dir","sha":"f7baf5aba2cb2916eb6e44c8ed40bcc70e145cd3","user":{"login":"g-oikonomou","id":705207,"avatar_url":"https://avatars.githubusercontent.com/u/705207?v=3","gravatar_id":"","url":"https://api.github.com/users/g-oikonomou","html_url":"https://github.com/g-oikonomou","followers_url":"https://api.github.com/users/g-oikonomou/followers","following_url":"https://api.github.com/users/g-oikonomou/following{/other_user}","gists_url":"https://api.github.com/users/g-oikonomou/gists{/gist_id}","starred_url":"https://api.github.com/users/g-oikonomou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/g-oikonomou/subscriptions","organizations_url":"https://api.github.com/users/g-oikonomou/orgs","repos_url":"https://api.github.com/users/g-oikonomou/repos","events_url":"https://api.github.com/users/g-oikonomou/events{/privacy}","received_events_url":"https://api.github.com/users/g-oikonomou/received_events","type":"User","site_admin":false},"repo":{"id":6429829,"name":"contiki","full_name":"g-oikonomou/contiki","owner":{"login":"g-oikonomou","id":705207,"avatar_url":"https://avatars.githubusercontent.com/u/705207?v=3","gravatar_id":"","url":"https://api.github.com/users/g-oikonomou","html_url":"https://github.com/g-oikonomou","followers_url":"https://api.github.com/users/g-oikonomou/followers","following_url":"https://api.github.com/users/g-oikonomou/following{/other_user}","gists_url":"https://api.github.com/users/g-oikonomou/gists{/gist_id}","starred_url":"https://api.github.com/users/g-oikonomou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/g-oikonomou/subscriptions","organizations_url":"https://api.github.com/users/g-oikonomou/orgs","repos_url":"https://api.github.com/users/g-oikonomou/repos","events_url":"https://api.github.com/users/g-oikonomou/events{/privacy}","received_events_url":"https://api.github.com/users/g-oikonomou/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/g-oikonomou/contiki","description":"George's development repo for the Contiki embedded operating system for the Internet of Things. This repo will only ever host development branches. master will always mirror master on https://github.com/contiki-os/contiki","fork":true,"url":"https://api.github.com/repos/g-oikonomou/contiki","forks_url":"https://api.github.com/repos/g-oikonomou/contiki/forks","keys_url":"https://api.github.com/repos/g-oikonomou/contiki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/g-oikonomou/contiki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/g-oikonomou/contiki/teams","hooks_url":"https://api.github.com/repos/g-oikonomou/contiki/hooks","issue_events_url":"https://api.github.com/repos/g-oikonomou/contiki/issues/events{/number}","events_url":"https://api.github.com/repos/g-oikonomou/contiki/events","assignees_url":"https://api.github.com/repos/g-oikonomou/contiki/assignees{/user}","branches_url":"https://api.github.com/repos/g-oikonomou/contiki/branches{/branch}","tags_url":"https://api.github.com/repos/g-oikonomou/contiki/tags","blobs_url":"https://api.github.com/repos/g-oikonomou/contiki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/g-oikonomou/contiki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/g-oikonomou/contiki/git/refs{/sha}","trees_url":"https://api.github.com/repos/g-oikonomou/contiki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/g-oikonomou/contiki/statuses/{sha}","languages_url":"https://api.github.com/repos/g-oikonomou/contiki/languages","stargazers_url":"https://api.github.com/repos/g-oikonomou/contiki/stargazers","contributors_url":"https://api.github.com/repos/g-oikonomou/contiki/contributors","subscribers_url":"https://api.github.com/repos/g-oikonomou/contiki/subscribers","subscription_url":"https://api.github.com/repos/g-oikonomou/contiki/subscription","commits_url":"https://api.github.com/repos/g-oikonomou/contiki/commits{/sha}","git_commits_url":"https://api.github.com/repos/g-oikonomou/contiki/git/commits{/sha}","comments_url":"https://api.github.com/repos/g-oikonomou/contiki/comments{/number}","issue_comment_url":"https://api.github.com/repos/g-oikonomou/contiki/issues/comments{/number}","contents_url":"https://api.github.com/repos/g-oikonomou/contiki/contents/{+path}","compare_url":"https://api.github.com/repos/g-oikonomou/contiki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/g-oikonomou/contiki/merges","archive_url":"https://api.github.com/repos/g-oikonomou/contiki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/g-oikonomou/contiki/downloads","issues_url":"https://api.github.com/repos/g-oikonomou/contiki/issues{/number}","pulls_url":"https://api.github.com/repos/g-oikonomou/contiki/pulls{/number}","milestones_url":"https://api.github.com/repos/g-oikonomou/contiki/milestones{/number}","notifications_url":"https://api.github.com/repos/g-oikonomou/contiki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/g-oikonomou/contiki/labels{/name}","releases_url":"https://api.github.com/repos/g-oikonomou/contiki/releases{/id}","created_at":"2012-10-28T17:16:05Z","updated_at":"2015-05-03T16:38:33Z","pushed_at":"2015-05-14T15:22:37Z","git_url":"git://github.com/g-oikonomou/contiki.git","ssh_url":"git@github.com:g-oikonomou/contiki.git","clone_url":"https://github.com/g-oikonomou/contiki.git","svn_url":"https://github.com/g-oikonomou/contiki","homepage":"","size":63202,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"contiki-os:master","ref":"master","sha":"540838be948af66796f035a6e553da0ea3849069","user":{"login":"contiki-os","id":2511296,"avatar_url":"https://avatars.githubusercontent.com/u/2511296?v=3","gravatar_id":"","url":"https://api.github.com/users/contiki-os","html_url":"https://github.com/contiki-os","followers_url":"https://api.github.com/users/contiki-os/followers","following_url":"https://api.github.com/users/contiki-os/following{/other_user}","gists_url":"https://api.github.com/users/contiki-os/gists{/gist_id}","starred_url":"https://api.github.com/users/contiki-os/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiki-os/subscriptions","organizations_url":"https://api.github.com/users/contiki-os/orgs","repos_url":"https://api.github.com/users/contiki-os/repos","events_url":"https://api.github.com/users/contiki-os/events{/privacy}","received_events_url":"https://api.github.com/users/contiki-os/received_events","type":"Organization","site_admin":false},"repo":{"id":6365284,"name":"contiki","full_name":"contiki-os/contiki","owner":{"login":"contiki-os","id":2511296,"avatar_url":"https://avatars.githubusercontent.com/u/2511296?v=3","gravatar_id":"","url":"https://api.github.com/users/contiki-os","html_url":"https://github.com/contiki-os","followers_url":"https://api.github.com/users/contiki-os/followers","following_url":"https://api.github.com/users/contiki-os/following{/other_user}","gists_url":"https://api.github.com/users/contiki-os/gists{/gist_id}","starred_url":"https://api.github.com/users/contiki-os/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiki-os/subscriptions","organizations_url":"https://api.github.com/users/contiki-os/orgs","repos_url":"https://api.github.com/users/contiki-os/repos","events_url":"https://api.github.com/users/contiki-os/events{/privacy}","received_events_url":"https://api.github.com/users/contiki-os/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/contiki-os/contiki","description":"The official git repository for Contiki, the open source OS for the Internet of Things","fork":false,"url":"https://api.github.com/repos/contiki-os/contiki","forks_url":"https://api.github.com/repos/contiki-os/contiki/forks","keys_url":"https://api.github.com/repos/contiki-os/contiki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/contiki-os/contiki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/contiki-os/contiki/teams","hooks_url":"https://api.github.com/repos/contiki-os/contiki/hooks","issue_events_url":"https://api.github.com/repos/contiki-os/contiki/issues/events{/number}","events_url":"https://api.github.com/repos/contiki-os/contiki/events","assignees_url":"https://api.github.com/repos/contiki-os/contiki/assignees{/user}","branches_url":"https://api.github.com/repos/contiki-os/contiki/branches{/branch}","tags_url":"https://api.github.com/repos/contiki-os/contiki/tags","blobs_url":"https://api.github.com/repos/contiki-os/contiki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/contiki-os/contiki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/contiki-os/contiki/git/refs{/sha}","trees_url":"https://api.github.com/repos/contiki-os/contiki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/contiki-os/contiki/statuses/{sha}","languages_url":"https://api.github.com/repos/contiki-os/contiki/languages","stargazers_url":"https://api.github.com/repos/contiki-os/contiki/stargazers","contributors_url":"https://api.github.com/repos/contiki-os/contiki/contributors","subscribers_url":"https://api.github.com/repos/contiki-os/contiki/subscribers","subscription_url":"https://api.github.com/repos/contiki-os/contiki/subscription","commits_url":"https://api.github.com/repos/contiki-os/contiki/commits{/sha}","git_commits_url":"https://api.github.com/repos/contiki-os/contiki/git/commits{/sha}","comments_url":"https://api.github.com/repos/contiki-os/contiki/comments{/number}","issue_comment_url":"https://api.github.com/repos/contiki-os/contiki/issues/comments{/number}","contents_url":"https://api.github.com/repos/contiki-os/contiki/contents/{+path}","compare_url":"https://api.github.com/repos/contiki-os/contiki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/contiki-os/contiki/merges","archive_url":"https://api.github.com/repos/contiki-os/contiki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/contiki-os/contiki/downloads","issues_url":"https://api.github.com/repos/contiki-os/contiki/issues{/number}","pulls_url":"https://api.github.com/repos/contiki-os/contiki/pulls{/number}","milestones_url":"https://api.github.com/repos/contiki-os/contiki/milestones{/number}","notifications_url":"https://api.github.com/repos/contiki-os/contiki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/contiki-os/contiki/labels{/name}","releases_url":"https://api.github.com/repos/contiki-os/contiki/releases{/id}","created_at":"2012-10-24T05:59:36Z","updated_at":"2015-05-13T16:33:24Z","pushed_at":"2015-05-14T15:22:38Z","git_url":"git://github.com/contiki-os/contiki.git","ssh_url":"git@github.com:contiki-os/contiki.git","clone_url":"https://github.com/contiki-os/contiki.git","svn_url":"https://github.com/contiki-os/contiki","homepage":"http://www.contiki-os.org/","size":86145,"stargazers_count":1341,"watchers_count":1341,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":939,"mirror_url":null,"open_issues_count":164,"forks":939,"open_issues":164,"watchers":1341,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/contiki-os/contiki/pulls/966"},"html":{"href":"https://github.com/contiki-os/contiki/pull/966"},"issue":{"href":"https://api.github.com/repos/contiki-os/contiki/issues/966"},"comments":{"href":"https://api.github.com/repos/contiki-os/contiki/issues/966/comments"},"review_comments":{"href":"https://api.github.com/repos/contiki-os/contiki/pulls/966/comments"},"review_comment":{"href":"https://api.github.com/repos/contiki-os/contiki/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/contiki-os/contiki/pulls/966/commits"},"statuses":{"href":"https://api.github.com/repos/contiki-os/contiki/statuses/f7baf5aba2cb2916eb6e44c8ed40bcc70e145cd3"}}}}