{"action":"created","comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/25121674","id":25121674,"diff_hunk":"@@ -23,7 +23,43 @@\n \n static void cc2420_gen_pkt(uint8_t *buf, cc2420_packet_t *packet);\n static uint8_t sequence_nr;\n-static bool wait_for_ack;\n+static volatile bool wait_for_ack;\n+static volatile bool got_ack;\n+\n+/* the two checksum bytes are NOT transmitted to this layer */\n+#define ACK_LENGTH  3\n+/* that delay should be enough, neither too short nor too long */\n+#define CC2420_ACK_WAIT_DELAY_uS   1000","path":"drivers/cc2420/cc2420_tx.c","position":11,"original_position":11,"commit_id":"7c94a3998934744a4c501ad4315f7146d16b310c","original_commit_id":"7c94a3998934744a4c501ad4315f7146d16b310c","user":{"login":"OlegHahm","id":1590423,"avatar_url":"https://avatars.githubusercontent.com/u/1590423?v=3","gravatar_id":"","url":"https://api.github.com/users/OlegHahm","html_url":"https://github.com/OlegHahm","followers_url":"https://api.github.com/users/OlegHahm/followers","following_url":"https://api.github.com/users/OlegHahm/following{/other_user}","gists_url":"https://api.github.com/users/OlegHahm/gists{/gist_id}","starred_url":"https://api.github.com/users/OlegHahm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OlegHahm/subscriptions","organizations_url":"https://api.github.com/users/OlegHahm/orgs","repos_url":"https://api.github.com/users/OlegHahm/repos","events_url":"https://api.github.com/users/OlegHahm/events{/privacy}","received_events_url":"https://api.github.com/users/OlegHahm/received_events","type":"User","site_admin":false},"body":"Please put parens around the numbers.","created_at":"2015-02-21T11:47:23Z","updated_at":"2015-02-21T11:47:23Z","html_url":"https://github.com/RIOT-OS/RIOT/pull/2251#discussion_r25121674","pull_request_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/2251","_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/25121674"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/2251#discussion_r25121674"},"pull_request":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/2251"}}},"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/2251","id":26883241,"html_url":"https://github.com/RIOT-OS/RIOT/pull/2251","diff_url":"https://github.com/RIOT-OS/RIOT/pull/2251.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/2251.patch","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/2251","number":2251,"state":"open","locked":false,"title":"Automatic management of returning ACKs for TXed packets","user":{"login":"rousselk","id":3785169,"avatar_url":"https://avatars.githubusercontent.com/u/3785169?v=3","gravatar_id":"","url":"https://api.github.com/users/rousselk","html_url":"https://github.com/rousselk","followers_url":"https://api.github.com/users/rousselk/followers","following_url":"https://api.github.com/users/rousselk/following{/other_user}","gists_url":"https://api.github.com/users/rousselk/gists{/gist_id}","starred_url":"https://api.github.com/users/rousselk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rousselk/subscriptions","organizations_url":"https://api.github.com/users/rousselk/orgs","repos_url":"https://api.github.com/users/rousselk/repos","events_url":"https://api.github.com/users/rousselk/events{/privacy}","received_events_url":"https://api.github.com/users/rousselk/received_events","type":"User","site_admin":false},"body":"Everything is in the title: using <code>send</code> now allows correct detection of returning ACK packets when the <code>wants_ack</code> is set to true.\r\n\r\nFollow-up to #1633 (from my new personal repository).","created_at":"2015-01-06T11:22:55Z","updated_at":"2015-02-21T11:47:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1868b0d2e11b6267e887e92163398a14c835d739","assignee":{"login":"OlegHahm","id":1590423,"avatar_url":"https://avatars.githubusercontent.com/u/1590423?v=3","gravatar_id":"","url":"https://api.github.com/users/OlegHahm","html_url":"https://github.com/OlegHahm","followers_url":"https://api.github.com/users/OlegHahm/followers","following_url":"https://api.github.com/users/OlegHahm/following{/other_user}","gists_url":"https://api.github.com/users/OlegHahm/gists{/gist_id}","starred_url":"https://api.github.com/users/OlegHahm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OlegHahm/subscriptions","organizations_url":"https://api.github.com/users/OlegHahm/orgs","repos_url":"https://api.github.com/users/OlegHahm/repos","events_url":"https://api.github.com/users/OlegHahm/events{/privacy}","received_events_url":"https://api.github.com/users/OlegHahm/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones/10","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones/10/labels","id":871004,"number":10,"title":"Release NEXT MAJOR","description":"This is the next major milestone. It gets a valid name if we know the next date to release on.","creator":{"login":"OlegHahm","id":1590423,"avatar_url":"https://avatars.githubusercontent.com/u/1590423?v=3","gravatar_id":"","url":"https://api.github.com/users/OlegHahm","html_url":"https://github.com/OlegHahm","followers_url":"https://api.github.com/users/OlegHahm/followers","following_url":"https://api.github.com/users/OlegHahm/following{/other_user}","gists_url":"https://api.github.com/users/OlegHahm/gists{/gist_id}","starred_url":"https://api.github.com/users/OlegHahm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OlegHahm/subscriptions","organizations_url":"https://api.github.com/users/OlegHahm/orgs","repos_url":"https://api.github.com/users/OlegHahm/repos","events_url":"https://api.github.com/users/OlegHahm/events{/privacy}","received_events_url":"https://api.github.com/users/OlegHahm/received_events","type":"User","site_admin":false},"open_issues":46,"closed_issues":39,"state":"open","created_at":"2014-11-18T10:51:58Z","updated_at":"2015-02-20T13:46:02Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/2251/commits","review_comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/2251/comments","review_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/{number}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/2251/comments","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/7c94a3998934744a4c501ad4315f7146d16b310c","head":{"label":"rousselk:cc2420-manage-callbacks","ref":"cc2420-manage-callbacks","sha":"7c94a3998934744a4c501ad4315f7146d16b310c","user":{"login":"rousselk","id":3785169,"avatar_url":"https://avatars.githubusercontent.com/u/3785169?v=3","gravatar_id":"","url":"https://api.github.com/users/rousselk","html_url":"https://github.com/rousselk","followers_url":"https://api.github.com/users/rousselk/followers","following_url":"https://api.github.com/users/rousselk/following{/other_user}","gists_url":"https://api.github.com/users/rousselk/gists{/gist_id}","starred_url":"https://api.github.com/users/rousselk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rousselk/subscriptions","organizations_url":"https://api.github.com/users/rousselk/orgs","repos_url":"https://api.github.com/users/rousselk/repos","events_url":"https://api.github.com/users/rousselk/events{/privacy}","received_events_url":"https://api.github.com/users/rousselk/received_events","type":"User","site_admin":false},"repo":{"id":28859740,"name":"RIOT","full_name":"rousselk/RIOT","owner":{"login":"rousselk","id":3785169,"avatar_url":"https://avatars.githubusercontent.com/u/3785169?v=3","gravatar_id":"","url":"https://api.github.com/users/rousselk","html_url":"https://github.com/rousselk","followers_url":"https://api.github.com/users/rousselk/followers","following_url":"https://api.github.com/users/rousselk/following{/other_user}","gists_url":"https://api.github.com/users/rousselk/gists{/gist_id}","starred_url":"https://api.github.com/users/rousselk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rousselk/subscriptions","organizations_url":"https://api.github.com/users/rousselk/orgs","repos_url":"https://api.github.com/users/rousselk/repos","events_url":"https://api.github.com/users/rousselk/events{/privacy}","received_events_url":"https://api.github.com/users/rousselk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rousselk/RIOT","description":"RIOT -  The friendly OS for IoT","fork":true,"url":"https://api.github.com/repos/rousselk/RIOT","forks_url":"https://api.github.com/repos/rousselk/RIOT/forks","keys_url":"https://api.github.com/repos/rousselk/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rousselk/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rousselk/RIOT/teams","hooks_url":"https://api.github.com/repos/rousselk/RIOT/hooks","issue_events_url":"https://api.github.com/repos/rousselk/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/rousselk/RIOT/events","assignees_url":"https://api.github.com/repos/rousselk/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/rousselk/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/rousselk/RIOT/tags","blobs_url":"https://api.github.com/repos/rousselk/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rousselk/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rousselk/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/rousselk/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rousselk/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/rousselk/RIOT/languages","stargazers_url":"https://api.github.com/repos/rousselk/RIOT/stargazers","contributors_url":"https://api.github.com/repos/rousselk/RIOT/contributors","subscribers_url":"https://api.github.com/repos/rousselk/RIOT/subscribers","subscription_url":"https://api.github.com/repos/rousselk/RIOT/subscription","commits_url":"https://api.github.com/repos/rousselk/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/rousselk/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/rousselk/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/rousselk/RIOT/issues/comments/{number}","contents_url":"https://api.github.com/repos/rousselk/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/rousselk/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rousselk/RIOT/merges","archive_url":"https://api.github.com/repos/rousselk/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rousselk/RIOT/downloads","issues_url":"https://api.github.com/repos/rousselk/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/rousselk/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/rousselk/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/rousselk/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rousselk/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/rousselk/RIOT/releases{/id}","created_at":"2015-01-06T11:11:40Z","updated_at":"2015-01-06T11:11:47Z","pushed_at":"2015-01-19T16:15:35Z","git_url":"git://github.com/rousselk/RIOT.git","ssh_url":"git@github.com:rousselk/RIOT.git","clone_url":"https://github.com/rousselk/RIOT.git","svn_url":"https://github.com/rousselk/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":13328,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RIOT-OS:master","ref":"master","sha":"b0045b21df1fc6eae291569814a77cc117b8e061","user":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars.githubusercontent.com/u/3079480?v=3","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"repo":{"id":7370241,"name":"RIOT","full_name":"RIOT-OS/RIOT","owner":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars.githubusercontent.com/u/3079480?v=3","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RIOT-OS/RIOT","description":"RIOT -  The friendly OS for IoT","fork":false,"url":"https://api.github.com/repos/RIOT-OS/RIOT","forks_url":"https://api.github.com/repos/RIOT-OS/RIOT/forks","keys_url":"https://api.github.com/repos/RIOT-OS/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIOT-OS/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIOT-OS/RIOT/teams","hooks_url":"https://api.github.com/repos/RIOT-OS/RIOT/hooks","issue_events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/events","assignees_url":"https://api.github.com/repos/RIOT-OS/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/RIOT-OS/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/tags","blobs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/RIOT-OS/RIOT/languages","stargazers_url":"https://api.github.com/repos/RIOT-OS/RIOT/stargazers","contributors_url":"https://api.github.com/repos/RIOT-OS/RIOT/contributors","subscribers_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscribers","subscription_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscription","commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments/{number}","contents_url":"https://api.github.com/repos/RIOT-OS/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/RIOT-OS/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIOT-OS/RIOT/merges","archive_url":"https://api.github.com/repos/RIOT-OS/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIOT-OS/RIOT/downloads","issues_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/RIOT-OS/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/RIOT-OS/RIOT/releases{/id}","created_at":"2012-12-29T20:38:40Z","updated_at":"2015-02-21T10:18:20Z","pushed_at":"2015-02-21T10:18:12Z","git_url":"git://github.com/RIOT-OS/RIOT.git","ssh_url":"git@github.com:RIOT-OS/RIOT.git","clone_url":"https://github.com/RIOT-OS/RIOT.git","svn_url":"https://github.com/RIOT-OS/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":84692,"stargazers_count":261,"watchers_count":261,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":210,"mirror_url":null,"open_issues_count":282,"forks":210,"open_issues":282,"watchers":261,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/2251"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/2251"},"issue":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/2251"},"comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/2251/comments"},"review_comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/2251/comments"},"review_comment":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/2251/commits"},"statuses":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/7c94a3998934744a4c501ad4315f7146d16b310c"}}}}