{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/42012721","id":42012721,"diff_hunk":"@@ -487,117 +551,99 @@ div.video {\n             }\n \n             .value {\n-              float: left;\n+              @include padding(0, lh(0.5), 0, 0);\n+              color: rgb(231, 236, 238); // UXPL grayscale-cool x-light\n               font-weight: bold;\n-              margin-bottom: 0;\n-              padding: 0 lh(0.5) 0 0;\n \n               @media (max-width: 1120px) {\n-                padding: 0 lh(0.5) 0 lh(0.5);\n+                padding: 0 lh(0.5);\n               }\n+            }\n+          }\n+        }\n+\n+        .lang {\n+\n+          .language-menu {\n+            width: $baseline;\n+            padding: ($baseline / 2) 0;\n+          }\n \n-              line-height: 46px;\n-              color: $white;\n+          &.is-opened {\n+\n+            .control {\n+\n+              .icon {\n+                @include transform(rotate(90deg));\n+              }\n             }\n           }\n         }\n \n-        div.volume {\n-          float: left;\n+        .volume {\n+          display: inline-block;\n           position: relative;\n \n           &.is-opened {\n+\n             .volume-slider-container {\n               display: block;\n               opacity: 1;\n             }\n           }\n \n-          &.is-muted {\n-            & > a {\n-              background-image: url('#{$static-path}/images/mute.png');\n-            }\n-          }\n-\n-          & > a {\n-            @extend %video-button;\n-            @include clearfix();\n-            background-image: url('#{$static-path}/images/volume.png');\n-            background-position: 10px center;\n-            background-repeat: no-repeat;\n-            width: 30px;\n-            height: 46px;\n-          }\n-\n           &:not(:first-child) > a {\n-            border-left: none;\n+            @include border-left(none);\n           }\n \n           .volume-slider-container {\n             @include transition(none);\n             @extend %ui-depth1;\n-            box-shadow: inset 1px 0 0 #555, 0 3px 0 #444;\n-            background-color: #444;\n-            border: 1px solid $black;\n-            bottom: 46px;\n             display: none;\n-            opacity: 0;\n             position: absolute;\n-            width: 45px;\n+            bottom: ($baseline * 1.5); // 30","path":"common/lib/xmodule/xmodule/css/video/display.scss","position":731,"original_position":731,"commit_id":"bb7f45e9270219e305d9ad12e858b03dba4d7369","original_commit_id":"bb7f45e9270219e305d9ad12e858b03dba4d7369","user":{"login":"frrrances","id":4327102,"avatar_url":"https://avatars.githubusercontent.com/u/4327102?v=3","gravatar_id":"","url":"https://api.github.com/users/frrrances","html_url":"https://github.com/frrrances","followers_url":"https://api.github.com/users/frrrances/followers","following_url":"https://api.github.com/users/frrrances/following{/other_user}","gists_url":"https://api.github.com/users/frrrances/gists{/gist_id}","starred_url":"https://api.github.com/users/frrrances/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frrrances/subscriptions","organizations_url":"https://api.github.com/users/frrrances/orgs","repos_url":"https://api.github.com/users/frrrances/repos","events_url":"https://api.github.com/users/frrrances/events{/privacy}","received_events_url":"https://api.github.com/users/frrrances/received_events","type":"User","site_admin":false},"body":"remove comment","created_at":"2015-10-14T15:55:29Z","updated_at":"2015-10-14T15:55:29Z","html_url":"https://github.com/edx/edx-platform/pull/9974#discussion_r42012721","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/9974","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/42012721"},"html":{"href":"https://github.com/edx/edx-platform/pull/9974#discussion_r42012721"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/9974"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/9974","id":46405934,"html_url":"https://github.com/edx/edx-platform/pull/9974","diff_url":"https://github.com/edx/edx-platform/pull/9974.diff","patch_url":"https://github.com/edx/edx-platform/pull/9974.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/9974","number":9974,"state":"open","locked":false,"title":"Video player (1 of 2): refreshing the UI","user":{"login":"clrux","id":2112024,"avatar_url":"https://avatars.githubusercontent.com/u/2112024?v=3","gravatar_id":"","url":"https://api.github.com/users/clrux","html_url":"https://github.com/clrux","followers_url":"https://api.github.com/users/clrux/followers","following_url":"https://api.github.com/users/clrux/following{/other_user}","gists_url":"https://api.github.com/users/clrux/gists{/gist_id}","starred_url":"https://api.github.com/users/clrux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clrux/subscriptions","organizations_url":"https://api.github.com/users/clrux/orgs","repos_url":"https://api.github.com/users/clrux/repos","events_url":"https://api.github.com/users/clrux/events{/privacy}","received_events_url":"https://api.github.com/users/clrux/received_events","type":"User","site_admin":false},"body":"This pull request is one part of two and provides visual and semantic updates to our video player. It is part of [AC-187](https://openedx.atlassian.net/browse/AC-187).\r\n\r\n## Notable changes\r\n\r\n* included a custom [Modernizr](http://modernizr.com) and [A Font Garde](https://github.com/filamentgroup/a-font-garde) for fully accessible icon fonts\r\n* converted the player controls from `a` to `button` for better semantics\r\n* updated the icon font markup to utilize required markup from A Font Garde\r\n* refreshed the overall UI to utilize palettes and practices from our [Pattern Library](http://ux.edx.org)\r\n* added a new grouped control, added a language `button` (which now controls the language menu, if available), and moved the transcripts control into it\r\n* provided keyboard behaviors for the newly added language menu control\r\n* many of the Sass changes are RTL-ing, removing specific elements, and other various cleanup\r\n\r\n### Implications on tests\r\n\r\nMany tests were looking for specific ARIA roles on the `a` controls, such as `role=\"button\"` and `title`. Since I've converted these \"buttons\" to real buttons, both of these attributes are invalid and have been removed.\r\n\r\n## Browsers\r\n\r\nThis has been tested in the following browsers:\r\n\r\n| Platform | Browser | Version | Passed |\r\n|----------|---------|---------|--------|\r\n| Mac  | Chrome | 45  | Yes  |\r\n|          | Safari | 8  | Yes |\r\n|          | Firefox | 40 | Yes |\r\n| Windows | Chrome  | 45 | Yes |\r\n|          | Firefox | 40 | Yes |\r\n|          | IE | 10 | Yes |\r\n|          | IE | 11 | Yes |\r\n\r\n## Sandbox\r\n\r\nhttp://clrux-ac-187.sandbox.edx.org/\r\n\r\n## Reviewers\r\n\r\n- [ ] @frrrances (FED and Sass)\r\n- [ ] @cptvitamin (Accessibility)\r\n- [ ] @clytwynec (Tests)","created_at":"2015-09-30T14:06:49Z","updated_at":"2015-10-14T15:55:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22ca71c6d67c7f35160acdcdfc4430f0b7c37d50","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/9974/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/9974/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/9974/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/bb7f45e9270219e305d9ad12e858b03dba4d7369","head":{"label":"edx:clrux/ac-187","ref":"clrux/ac-187","sha":"bb7f45e9270219e305d9ad12e858b03dba4d7369","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2015-10-13T22:20:08Z","pushed_at":"2015-10-14T15:44:49Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":2188474,"stargazers_count":2170,"watchers_count":2170,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1313,"mirror_url":null,"open_issues_count":136,"forks":1313,"open_issues":136,"watchers":2170,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"82a1989a4b1c206dfd0c24b5bb188c52d317ea95","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2015-10-13T22:20:08Z","pushed_at":"2015-10-14T15:44:49Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":2188474,"stargazers_count":2170,"watchers_count":2170,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1313,"mirror_url":null,"open_issues_count":136,"forks":1313,"open_issues":136,"watchers":2170,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/9974"},"html":{"href":"https://github.com/edx/edx-platform/pull/9974"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/9974"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/9974/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/9974/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/9974/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/bb7f45e9270219e305d9ad12e858b03dba4d7369"}}}}