{"action":"created","comment":{"url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls/comments/42419171","id":42419171,"diff_hunk":"@@ -246,8 +247,7 @@ void loggerTaskEx(void *params)\n                 }\n \n                 /* send the sample on to the telemetry task(s) */\n-                if (sampledRate >= telemetrySampleRate ||\n-                    currentTicks % telemetrySampleRate == 0)\n+                if (!isHigherSampleRate(sampledRate, telemetrySampleRate))","path":"src/logger/loggerTaskEx.c","position":28,"original_position":28,"commit_id":"40c3da28b8d9284179e2d15b1a8e4404cc9ebe40","original_commit_id":"40c3da28b8d9284179e2d15b1a8e4404cc9ebe40","user":{"login":"brentpicasso","id":3267533,"avatar_url":"https://avatars.githubusercontent.com/u/3267533?v=3","gravatar_id":"","url":"https://api.github.com/users/brentpicasso","html_url":"https://github.com/brentpicasso","followers_url":"https://api.github.com/users/brentpicasso/followers","following_url":"https://api.github.com/users/brentpicasso/following{/other_user}","gists_url":"https://api.github.com/users/brentpicasso/gists{/gist_id}","starred_url":"https://api.github.com/users/brentpicasso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brentpicasso/subscriptions","organizations_url":"https://api.github.com/users/brentpicasso/orgs","repos_url":"https://api.github.com/users/brentpicasso/repos","events_url":"https://api.github.com/users/brentpicasso/events{/privacy}","received_events_url":"https://api.github.com/users/brentpicasso/received_events","type":"User","site_admin":false},"body":"Did you test this for regressions under varying conditions?","created_at":"2015-10-19T20:08:22Z","updated_at":"2015-10-19T20:08:22Z","html_url":"https://github.com/autosportlabs/RaceCapture-Pro_firmware/pull/98#discussion_r42419171","pull_request_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls/98","_links":{"self":{"href":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls/comments/42419171"},"html":{"href":"https://github.com/autosportlabs/RaceCapture-Pro_firmware/pull/98#discussion_r42419171"},"pull_request":{"href":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls/98"}}},"pull_request":{"url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls/98","id":48103436,"html_url":"https://github.com/autosportlabs/RaceCapture-Pro_firmware/pull/98","diff_url":"https://github.com/autosportlabs/RaceCapture-Pro_firmware/pull/98.diff","patch_url":"https://github.com/autosportlabs/RaceCapture-Pro_firmware/pull/98.patch","issue_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/issues/98","number":98,"state":"open","locked":false,"title":"P/stieg/code cleanup","user":{"login":"stieg","id":141519,"avatar_url":"https://avatars.githubusercontent.com/u/141519?v=3","gravatar_id":"","url":"https://api.github.com/users/stieg","html_url":"https://github.com/stieg","followers_url":"https://api.github.com/users/stieg/followers","following_url":"https://api.github.com/users/stieg/following{/other_user}","gists_url":"https://api.github.com/users/stieg/gists{/gist_id}","starred_url":"https://api.github.com/users/stieg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stieg/subscriptions","organizations_url":"https://api.github.com/users/stieg/orgs","repos_url":"https://api.github.com/users/stieg/repos","events_url":"https://api.github.com/users/stieg/events{/privacy}","received_events_url":"https://api.github.com/users/stieg/received_events","type":"User","site_admin":false},"body":"Some code cleanup that was deferred from the 2.8.5 release.  Of note the change that is in loggerTasxEx.c.  @brentpicasso seems to be concerned about it but I was unable to figure out the reason based on the code.  The second conditional was redundant in my investigation.  Hence why I made the change.","created_at":"2015-10-19T17:48:16Z","updated_at":"2015-10-19T20:08:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59af01f802e56fd479bf321bc17917a9e6575650","assignee":{"login":"brentpicasso","id":3267533,"avatar_url":"https://avatars.githubusercontent.com/u/3267533?v=3","gravatar_id":"","url":"https://api.github.com/users/brentpicasso","html_url":"https://github.com/brentpicasso","followers_url":"https://api.github.com/users/brentpicasso/followers","following_url":"https://api.github.com/users/brentpicasso/following{/other_user}","gists_url":"https://api.github.com/users/brentpicasso/gists{/gist_id}","starred_url":"https://api.github.com/users/brentpicasso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brentpicasso/subscriptions","organizations_url":"https://api.github.com/users/brentpicasso/orgs","repos_url":"https://api.github.com/users/brentpicasso/repos","events_url":"https://api.github.com/users/brentpicasso/events{/privacy}","received_events_url":"https://api.github.com/users/brentpicasso/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/milestones/5","html_url":"https://github.com/autosportlabs/RaceCapture-Pro_firmware/milestones/2.8.6","labels_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/milestones/5/labels","id":1364454,"number":5,"title":"2.8.6","description":null,"creator":{"login":"stieg","id":141519,"avatar_url":"https://avatars.githubusercontent.com/u/141519?v=3","gravatar_id":"","url":"https://api.github.com/users/stieg","html_url":"https://github.com/stieg","followers_url":"https://api.github.com/users/stieg/followers","following_url":"https://api.github.com/users/stieg/following{/other_user}","gists_url":"https://api.github.com/users/stieg/gists{/gist_id}","starred_url":"https://api.github.com/users/stieg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stieg/subscriptions","organizations_url":"https://api.github.com/users/stieg/orgs","repos_url":"https://api.github.com/users/stieg/repos","events_url":"https://api.github.com/users/stieg/events{/privacy}","received_events_url":"https://api.github.com/users/stieg/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2015-10-19T17:24:49Z","updated_at":"2015-10-19T17:48:16Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls/98/commits","review_comments_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls/98/comments","review_comment_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/issues/98/comments","statuses_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/statuses/40c3da28b8d9284179e2d15b1a8e4404cc9ebe40","head":{"label":"autosportlabs:p/stieg/code_cleanup","ref":"p/stieg/code_cleanup","sha":"40c3da28b8d9284179e2d15b1a8e4404cc9ebe40","user":{"login":"autosportlabs","id":1274125,"avatar_url":"https://avatars.githubusercontent.com/u/1274125?v=3","gravatar_id":"","url":"https://api.github.com/users/autosportlabs","html_url":"https://github.com/autosportlabs","followers_url":"https://api.github.com/users/autosportlabs/followers","following_url":"https://api.github.com/users/autosportlabs/following{/other_user}","gists_url":"https://api.github.com/users/autosportlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/autosportlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autosportlabs/subscriptions","organizations_url":"https://api.github.com/users/autosportlabs/orgs","repos_url":"https://api.github.com/users/autosportlabs/repos","events_url":"https://api.github.com/users/autosportlabs/events{/privacy}","received_events_url":"https://api.github.com/users/autosportlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":10069490,"name":"RaceCapture-Pro_firmware","full_name":"autosportlabs/RaceCapture-Pro_firmware","owner":{"login":"autosportlabs","id":1274125,"avatar_url":"https://avatars.githubusercontent.com/u/1274125?v=3","gravatar_id":"","url":"https://api.github.com/users/autosportlabs","html_url":"https://github.com/autosportlabs","followers_url":"https://api.github.com/users/autosportlabs/followers","following_url":"https://api.github.com/users/autosportlabs/following{/other_user}","gists_url":"https://api.github.com/users/autosportlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/autosportlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autosportlabs/subscriptions","organizations_url":"https://api.github.com/users/autosportlabs/orgs","repos_url":"https://api.github.com/users/autosportlabs/repos","events_url":"https://api.github.com/users/autosportlabs/events{/privacy}","received_events_url":"https://api.github.com/users/autosportlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/autosportlabs/RaceCapture-Pro_firmware","description":"Firmware for RaceCapture-Pro Data Acquisition, control and Telemetry system for motorsports","fork":false,"url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware","forks_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/forks","keys_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/teams","hooks_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/hooks","issue_events_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/issues/events{/number}","events_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/events","assignees_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/assignees{/user}","branches_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/branches{/branch}","tags_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/tags","blobs_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/languages","stargazers_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/stargazers","contributors_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/contributors","subscribers_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/subscribers","subscription_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/subscription","commits_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/contents/{+path}","compare_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/merges","archive_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/downloads","issues_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/issues{/number}","pulls_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/labels{/name}","releases_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/releases{/id}","created_at":"2013-05-15T02:30:10Z","updated_at":"2015-10-13T16:03:42Z","pushed_at":"2015-10-19T18:11:17Z","git_url":"git://github.com/autosportlabs/RaceCapture-Pro_firmware.git","ssh_url":"git@github.com:autosportlabs/RaceCapture-Pro_firmware.git","clone_url":"https://github.com/autosportlabs/RaceCapture-Pro_firmware.git","svn_url":"https://github.com/autosportlabs/RaceCapture-Pro_firmware","homepage":null,"size":38194,"stargazers_count":8,"watchers_count":8,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":2,"forks":9,"open_issues":2,"watchers":8,"default_branch":"master"}},"base":{"label":"autosportlabs:r/2.8.6","ref":"r/2.8.6","sha":"aef0769b5539f0647a76b3a00b1774ba29a8c343","user":{"login":"autosportlabs","id":1274125,"avatar_url":"https://avatars.githubusercontent.com/u/1274125?v=3","gravatar_id":"","url":"https://api.github.com/users/autosportlabs","html_url":"https://github.com/autosportlabs","followers_url":"https://api.github.com/users/autosportlabs/followers","following_url":"https://api.github.com/users/autosportlabs/following{/other_user}","gists_url":"https://api.github.com/users/autosportlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/autosportlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autosportlabs/subscriptions","organizations_url":"https://api.github.com/users/autosportlabs/orgs","repos_url":"https://api.github.com/users/autosportlabs/repos","events_url":"https://api.github.com/users/autosportlabs/events{/privacy}","received_events_url":"https://api.github.com/users/autosportlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":10069490,"name":"RaceCapture-Pro_firmware","full_name":"autosportlabs/RaceCapture-Pro_firmware","owner":{"login":"autosportlabs","id":1274125,"avatar_url":"https://avatars.githubusercontent.com/u/1274125?v=3","gravatar_id":"","url":"https://api.github.com/users/autosportlabs","html_url":"https://github.com/autosportlabs","followers_url":"https://api.github.com/users/autosportlabs/followers","following_url":"https://api.github.com/users/autosportlabs/following{/other_user}","gists_url":"https://api.github.com/users/autosportlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/autosportlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autosportlabs/subscriptions","organizations_url":"https://api.github.com/users/autosportlabs/orgs","repos_url":"https://api.github.com/users/autosportlabs/repos","events_url":"https://api.github.com/users/autosportlabs/events{/privacy}","received_events_url":"https://api.github.com/users/autosportlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/autosportlabs/RaceCapture-Pro_firmware","description":"Firmware for RaceCapture-Pro Data Acquisition, control and Telemetry system for motorsports","fork":false,"url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware","forks_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/forks","keys_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/teams","hooks_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/hooks","issue_events_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/issues/events{/number}","events_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/events","assignees_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/assignees{/user}","branches_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/branches{/branch}","tags_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/tags","blobs_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/languages","stargazers_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/stargazers","contributors_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/contributors","subscribers_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/subscribers","subscription_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/subscription","commits_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/contents/{+path}","compare_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/merges","archive_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/downloads","issues_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/issues{/number}","pulls_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/labels{/name}","releases_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/releases{/id}","created_at":"2013-05-15T02:30:10Z","updated_at":"2015-10-13T16:03:42Z","pushed_at":"2015-10-19T18:11:17Z","git_url":"git://github.com/autosportlabs/RaceCapture-Pro_firmware.git","ssh_url":"git@github.com:autosportlabs/RaceCapture-Pro_firmware.git","clone_url":"https://github.com/autosportlabs/RaceCapture-Pro_firmware.git","svn_url":"https://github.com/autosportlabs/RaceCapture-Pro_firmware","homepage":null,"size":38194,"stargazers_count":8,"watchers_count":8,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":2,"forks":9,"open_issues":2,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls/98"},"html":{"href":"https://github.com/autosportlabs/RaceCapture-Pro_firmware/pull/98"},"issue":{"href":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/issues/98"},"comments":{"href":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/issues/98/comments"},"review_comments":{"href":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls/98/comments"},"review_comment":{"href":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls/98/commits"},"statuses":{"href":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/statuses/40c3da28b8d9284179e2d15b1a8e4404cc9ebe40"}}}}