{"action":"opened","number":854,"pull_request":{"url":"https://api.github.com/repos/dotnet/llilc/pulls/854","id":45363022,"html_url":"https://github.com/dotnet/llilc/pull/854","diff_url":"https://github.com/dotnet/llilc/pull/854.diff","patch_url":"https://github.com/dotnet/llilc/pull/854.patch","issue_url":"https://api.github.com/repos/dotnet/llilc/issues/854","number":854,"state":"open","locked":false,"title":"Translate filters to catches in reader","user":{"login":"JosephTremoulet","id":10655216,"avatar_url":"https://avatars.githubusercontent.com/u/10655216?v=3","gravatar_id":"","url":"https://api.github.com/users/JosephTremoulet","html_url":"https://github.com/JosephTremoulet","followers_url":"https://api.github.com/users/JosephTremoulet/followers","following_url":"https://api.github.com/users/JosephTremoulet/following{/other_user}","gists_url":"https://api.github.com/users/JosephTremoulet/gists{/gist_id}","starred_url":"https://api.github.com/users/JosephTremoulet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosephTremoulet/subscriptions","organizations_url":"https://api.github.com/users/JosephTremoulet/orgs","repos_url":"https://api.github.com/users/JosephTremoulet/repos","events_url":"https://api.github.com/users/JosephTremoulet/events{/privacy}","received_events_url":"https://api.github.com/users/JosephTremoulet/received_events","type":"User","site_admin":false},"body":"Note: this is a PR for a change to go into the EH branch.\r\n\r\nLowering for filters (as filters) is going to lag behind lowering for the other handler types.  This is a change to have filters masquerade as catches in the meantime -- the catch encompasses both the filter and the filter-handler, with an explicit rethrows if the `filter portion returns 0.  This is not fully \"as-is\", because it effectively delays the evaluation of filter expressions from the first pass of unwinding to the second.  Aside from that, however, it is a faithful representation of filter semantics.\r\n\r\nI've created a [gist](https://gist.github.com/JosephTremoulet/bd635de873e90de9b710) to show the effect of the transform.  It includes a [C# input](https://gist.github.com/JosephTremoulet/bd635de873e90de9b710#file-input-cs), the [IR generated with filter outlining](https://gist.github.com/JosephTremoulet/bd635de873e90de9b710#file-outputwithfilteroutlining-ll) (as before this change), and the [IR generated with filters translated to catches](https://gist.github.com/JosephTremoulet/bd635de873e90de9b710#file-outputwithfiltertransform-ll) (as with this change).\r\n\r\nThe change is split into four commits:\r\n - the first two (97fe976 and f7316c0) are actually small bugfixes to the filter outlining that were needed to create the 'before' part of the gist\r\n - the next (7fa22f5) is the meat of the change to produce catches instead of outlining when encountering a filter\r\n - the last (d7cdeb3)  is a rote change almost entirely composed by reverting chunks to match master, renaming `RootFunction` back to `Function` and the like.","created_at":"2015-09-18T02:21:32Z","updated_at":"2015-09-18T02:21:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/llilc/pulls/854/commits","review_comments_url":"https://api.github.com/repos/dotnet/llilc/pulls/854/comments","review_comment_url":"https://api.github.com/repos/dotnet/llilc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/llilc/issues/854/comments","statuses_url":"https://api.github.com/repos/dotnet/llilc/statuses/d7cdeb3b779c500da942b26eaffd69232b564e2b","head":{"label":"JosephTremoulet:FilterTransform","ref":"FilterTransform","sha":"d7cdeb3b779c500da942b26eaffd69232b564e2b","user":{"login":"JosephTremoulet","id":10655216,"avatar_url":"https://avatars.githubusercontent.com/u/10655216?v=3","gravatar_id":"","url":"https://api.github.com/users/JosephTremoulet","html_url":"https://github.com/JosephTremoulet","followers_url":"https://api.github.com/users/JosephTremoulet/followers","following_url":"https://api.github.com/users/JosephTremoulet/following{/other_user}","gists_url":"https://api.github.com/users/JosephTremoulet/gists{/gist_id}","starred_url":"https://api.github.com/users/JosephTremoulet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosephTremoulet/subscriptions","organizations_url":"https://api.github.com/users/JosephTremoulet/orgs","repos_url":"https://api.github.com/users/JosephTremoulet/repos","events_url":"https://api.github.com/users/JosephTremoulet/events{/privacy}","received_events_url":"https://api.github.com/users/JosephTremoulet/received_events","type":"User","site_admin":false},"repo":{"id":33910143,"name":"llilc","full_name":"JosephTremoulet/llilc","owner":{"login":"JosephTremoulet","id":10655216,"avatar_url":"https://avatars.githubusercontent.com/u/10655216?v=3","gravatar_id":"","url":"https://api.github.com/users/JosephTremoulet","html_url":"https://github.com/JosephTremoulet","followers_url":"https://api.github.com/users/JosephTremoulet/followers","following_url":"https://api.github.com/users/JosephTremoulet/following{/other_user}","gists_url":"https://api.github.com/users/JosephTremoulet/gists{/gist_id}","starred_url":"https://api.github.com/users/JosephTremoulet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosephTremoulet/subscriptions","organizations_url":"https://api.github.com/users/JosephTremoulet/orgs","repos_url":"https://api.github.com/users/JosephTremoulet/repos","events_url":"https://api.github.com/users/JosephTremoulet/events{/privacy}","received_events_url":"https://api.github.com/users/JosephTremoulet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JosephTremoulet/llilc","description":"This repo contains LLILC, an LLVM based compiler for .NET Core. It includes a set of cross-platform .NET code generation tools that enables compilation of MSIL byte code to LLVM supported platforms.","fork":true,"url":"https://api.github.com/repos/JosephTremoulet/llilc","forks_url":"https://api.github.com/repos/JosephTremoulet/llilc/forks","keys_url":"https://api.github.com/repos/JosephTremoulet/llilc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JosephTremoulet/llilc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JosephTremoulet/llilc/teams","hooks_url":"https://api.github.com/repos/JosephTremoulet/llilc/hooks","issue_events_url":"https://api.github.com/repos/JosephTremoulet/llilc/issues/events{/number}","events_url":"https://api.github.com/repos/JosephTremoulet/llilc/events","assignees_url":"https://api.github.com/repos/JosephTremoulet/llilc/assignees{/user}","branches_url":"https://api.github.com/repos/JosephTremoulet/llilc/branches{/branch}","tags_url":"https://api.github.com/repos/JosephTremoulet/llilc/tags","blobs_url":"https://api.github.com/repos/JosephTremoulet/llilc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JosephTremoulet/llilc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JosephTremoulet/llilc/git/refs{/sha}","trees_url":"https://api.github.com/repos/JosephTremoulet/llilc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JosephTremoulet/llilc/statuses/{sha}","languages_url":"https://api.github.com/repos/JosephTremoulet/llilc/languages","stargazers_url":"https://api.github.com/repos/JosephTremoulet/llilc/stargazers","contributors_url":"https://api.github.com/repos/JosephTremoulet/llilc/contributors","subscribers_url":"https://api.github.com/repos/JosephTremoulet/llilc/subscribers","subscription_url":"https://api.github.com/repos/JosephTremoulet/llilc/subscription","commits_url":"https://api.github.com/repos/JosephTremoulet/llilc/commits{/sha}","git_commits_url":"https://api.github.com/repos/JosephTremoulet/llilc/git/commits{/sha}","comments_url":"https://api.github.com/repos/JosephTremoulet/llilc/comments{/number}","issue_comment_url":"https://api.github.com/repos/JosephTremoulet/llilc/issues/comments{/number}","contents_url":"https://api.github.com/repos/JosephTremoulet/llilc/contents/{+path}","compare_url":"https://api.github.com/repos/JosephTremoulet/llilc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JosephTremoulet/llilc/merges","archive_url":"https://api.github.com/repos/JosephTremoulet/llilc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JosephTremoulet/llilc/downloads","issues_url":"https://api.github.com/repos/JosephTremoulet/llilc/issues{/number}","pulls_url":"https://api.github.com/repos/JosephTremoulet/llilc/pulls{/number}","milestones_url":"https://api.github.com/repos/JosephTremoulet/llilc/milestones{/number}","notifications_url":"https://api.github.com/repos/JosephTremoulet/llilc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JosephTremoulet/llilc/labels{/name}","releases_url":"https://api.github.com/repos/JosephTremoulet/llilc/releases{/id}","created_at":"2015-04-14T04:09:25Z","updated_at":"2015-05-05T17:17:33Z","pushed_at":"2015-09-18T01:50:41Z","git_url":"git://github.com/JosephTremoulet/llilc.git","ssh_url":"git@github.com:JosephTremoulet/llilc.git","clone_url":"https://github.com/JosephTremoulet/llilc.git","svn_url":"https://github.com/JosephTremoulet/llilc","homepage":"","size":6722,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:EH","ref":"EH","sha":"bb9a9a4616d0e57e42a5d7f66de8b5599713c7c7","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30043131,"name":"llilc","full_name":"dotnet/llilc","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/llilc","description":"This repo contains LLILC, an LLVM based compiler for .NET Core. It includes a set of cross-platform .NET code generation tools that enables compilation of MSIL byte code to LLVM supported platforms.","fork":false,"url":"https://api.github.com/repos/dotnet/llilc","forks_url":"https://api.github.com/repos/dotnet/llilc/forks","keys_url":"https://api.github.com/repos/dotnet/llilc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/llilc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/llilc/teams","hooks_url":"https://api.github.com/repos/dotnet/llilc/hooks","issue_events_url":"https://api.github.com/repos/dotnet/llilc/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/llilc/events","assignees_url":"https://api.github.com/repos/dotnet/llilc/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/llilc/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/llilc/tags","blobs_url":"https://api.github.com/repos/dotnet/llilc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/llilc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/llilc/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/llilc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/llilc/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/llilc/languages","stargazers_url":"https://api.github.com/repos/dotnet/llilc/stargazers","contributors_url":"https://api.github.com/repos/dotnet/llilc/contributors","subscribers_url":"https://api.github.com/repos/dotnet/llilc/subscribers","subscription_url":"https://api.github.com/repos/dotnet/llilc/subscription","commits_url":"https://api.github.com/repos/dotnet/llilc/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/llilc/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/llilc/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/llilc/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/llilc/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/llilc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/llilc/merges","archive_url":"https://api.github.com/repos/dotnet/llilc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/llilc/downloads","issues_url":"https://api.github.com/repos/dotnet/llilc/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/llilc/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/llilc/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/llilc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/llilc/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/llilc/releases{/id}","created_at":"2015-01-29T21:52:01Z","updated_at":"2015-09-17T16:12:56Z","pushed_at":"2015-09-18T01:17:20Z","git_url":"git://github.com/dotnet/llilc.git","ssh_url":"git@github.com:dotnet/llilc.git","clone_url":"https://github.com/dotnet/llilc.git","svn_url":"https://github.com/dotnet/llilc","homepage":"","size":11836,"stargazers_count":830,"watchers_count":830,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":71,"mirror_url":null,"open_issues_count":140,"forks":71,"open_issues":140,"watchers":830,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/llilc/pulls/854"},"html":{"href":"https://github.com/dotnet/llilc/pull/854"},"issue":{"href":"https://api.github.com/repos/dotnet/llilc/issues/854"},"comments":{"href":"https://api.github.com/repos/dotnet/llilc/issues/854/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/llilc/pulls/854/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/llilc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/llilc/pulls/854/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/llilc/statuses/d7cdeb3b779c500da942b26eaffd69232b564e2b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":120,"deletions":493,"changed_files":4}}