{"action":"created","issue":{"url":"https://api.github.com/repos/vaadin/vaadin/issues/23","labels_url":"https://api.github.com/repos/vaadin/vaadin/issues/23/labels{/name}","comments_url":"https://api.github.com/repos/vaadin/vaadin/issues/23/comments","events_url":"https://api.github.com/repos/vaadin/vaadin/issues/23/events","html_url":"https://github.com/vaadin/vaadin/pull/23","id":55524796,"number":23,"title":"Fix issue #16499: UI.getPushConfiguration().getTransport() *always* returns null","user":{"login":"wodencafe","id":9727493,"avatar_url":"https://avatars.githubusercontent.com/u/9727493?v=3","gravatar_id":"","url":"https://api.github.com/users/wodencafe","html_url":"https://github.com/wodencafe","followers_url":"https://api.github.com/users/wodencafe/followers","following_url":"https://api.github.com/users/wodencafe/following{/other_user}","gists_url":"https://api.github.com/users/wodencafe/gists{/gist_id}","starred_url":"https://api.github.com/users/wodencafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wodencafe/subscriptions","organizations_url":"https://api.github.com/users/wodencafe/orgs","repos_url":"https://api.github.com/users/wodencafe/repos","events_url":"https://api.github.com/users/wodencafe/events{/privacy}","received_events_url":"https://api.github.com/users/wodencafe/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-01-26T19:20:37Z","updated_at":"2015-01-28T17:54:19Z","closed_at":"2015-01-28T17:54:19Z","pull_request":{"url":"https://api.github.com/repos/vaadin/vaadin/pulls/23","html_url":"https://github.com/vaadin/vaadin/pull/23","diff_url":"https://github.com/vaadin/vaadin/pull/23.diff","patch_url":"https://github.com/vaadin/vaadin/pull/23.patch"},"body":"Hello Vaadin team,\r\n\r\nI stumbled upon this in the lastest Vaadin 7.3.9, Tomcat 8 and 7, etc.\r\n\r\nUI.getPushConfiguration().getTransport() will always return null.\r\n\r\nThe problem has to do with using \"Transport.valueOf\" in the getTransport() method that is trying to look up the Transport enum based on it's identifier \"websocket\" rather than it's string equivalent name \"WEBSOCKET\". This applies to all of the transports.\r\n\r\nHere is the relevant Vaadin ticket created in response to this issue: http://dev.vaadin.com/ticket/16499\r\n\r\nPlease try in your own project with Vaadin, any version, call UI.getPushConfiguration().getTransport() and see for yourself that it is always null.\r\n\r\nThe problem is caused by PushConfigurationImpl.getTransport() falling into the catch (IllegalArgumentException) that is then swallowed silently, and null is returned."},"comment":{"url":"https://api.github.com/repos/vaadin/vaadin/issues/comments/71881868","html_url":"https://github.com/vaadin/vaadin/pull/23#issuecomment-71881868","issue_url":"https://api.github.com/repos/vaadin/vaadin/issues/23","id":71881868,"user":{"login":"Artur-","id":260340,"avatar_url":"https://avatars.githubusercontent.com/u/260340?v=3","gravatar_id":"","url":"https://api.github.com/users/Artur-","html_url":"https://github.com/Artur-","followers_url":"https://api.github.com/users/Artur-/followers","following_url":"https://api.github.com/users/Artur-/following{/other_user}","gists_url":"https://api.github.com/users/Artur-/gists{/gist_id}","starred_url":"https://api.github.com/users/Artur-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Artur-/subscriptions","organizations_url":"https://api.github.com/users/Artur-/orgs","repos_url":"https://api.github.com/users/Artur-/repos","events_url":"https://api.github.com/users/Artur-/events{/privacy}","received_events_url":"https://api.github.com/users/Artur-/received_events","type":"User","site_admin":false},"created_at":"2015-01-28T17:54:19Z","updated_at":"2015-01-28T17:54:19Z","body":"Thanks, merged it!"}}