{"action":"created","comment":{"url":"https://api.github.com/repos/samsonjs/strftime/pulls/comments/27352549","id":27352549,"diff_hunk":"@@ -595,10 +595,8 @@\n             else\n                 weekday--;\n         }\n-\n-        var firstDayOfYearUtc = Date.UTC(date.getFullYear(), 0, 1),\n-            dateUtc = Date.UTC(date.getFullYear(), date.getMonth(), date.getDate()),\n-            yday = Math.floor((dateUtc - firstDayOfYearUtc) / 86400000),\n+        var firstDayOfYear = new Date(date.getFullYear(), 0, 1),","path":"strftime.js","position":8,"original_position":8,"commit_id":"ab3d4a052ea48363e5c1684f5aff9d90f3ce2a30","original_commit_id":"ab3d4a052ea48363e5c1684f5aff9d90f3ce2a30","user":{"login":"alexandrnikitin","id":1798438,"avatar_url":"https://avatars.githubusercontent.com/u/1798438?v=3","gravatar_id":"","url":"https://api.github.com/users/alexandrnikitin","html_url":"https://github.com/alexandrnikitin","followers_url":"https://api.github.com/users/alexandrnikitin/followers","following_url":"https://api.github.com/users/alexandrnikitin/following{/other_user}","gists_url":"https://api.github.com/users/alexandrnikitin/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandrnikitin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandrnikitin/subscriptions","organizations_url":"https://api.github.com/users/alexandrnikitin/orgs","repos_url":"https://api.github.com/users/alexandrnikitin/repos","events_url":"https://api.github.com/users/alexandrnikitin/events{/privacy}","received_events_url":"https://api.github.com/users/alexandrnikitin/received_events","type":"User","site_admin":false},"body":"The intention was to compare date without taking DST into account. `date.getDate()` returns proper day with DST. But the difference calculated without DST. \r\n\r\nCould you point when the bug could appear here please. I'm not sure I get you.","created_at":"2015-03-29T08:31:59Z","updated_at":"2015-03-29T08:31:59Z","html_url":"https://github.com/samsonjs/strftime/pull/58#discussion_r27352549","pull_request_url":"https://api.github.com/repos/samsonjs/strftime/pulls/58","_links":{"self":{"href":"https://api.github.com/repos/samsonjs/strftime/pulls/comments/27352549"},"html":{"href":"https://github.com/samsonjs/strftime/pull/58#discussion_r27352549"},"pull_request":{"href":"https://api.github.com/repos/samsonjs/strftime/pulls/58"}}},"pull_request":{"url":"https://api.github.com/repos/samsonjs/strftime/pulls/58","id":32065423,"html_url":"https://github.com/samsonjs/strftime/pull/58","diff_url":"https://github.com/samsonjs/strftime/pull/58.diff","patch_url":"https://github.com/samsonjs/strftime/pull/58.patch","issue_url":"https://api.github.com/repos/samsonjs/strftime/issues/58","number":58,"state":"closed","locked":false,"title":"Revert \"Fixes #56 (Bug in %U)\"","user":{"login":"samsonjs","id":32487,"avatar_url":"https://avatars.githubusercontent.com/u/32487?v=3","gravatar_id":"","url":"https://api.github.com/users/samsonjs","html_url":"https://github.com/samsonjs","followers_url":"https://api.github.com/users/samsonjs/followers","following_url":"https://api.github.com/users/samsonjs/following{/other_user}","gists_url":"https://api.github.com/users/samsonjs/gists{/gist_id}","starred_url":"https://api.github.com/users/samsonjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samsonjs/subscriptions","organizations_url":"https://api.github.com/users/samsonjs/orgs","repos_url":"https://api.github.com/users/samsonjs/repos","events_url":"https://api.github.com/users/samsonjs/events{/privacy}","received_events_url":"https://api.github.com/users/samsonjs/received_events","type":"User","site_admin":false},"body":"Sorry, premature merge ... the tests fail.","created_at":"2015-03-26T21:56:26Z","updated_at":"2015-03-29T08:31:59Z","closed_at":"2015-03-26T21:56:35Z","merged_at":"2015-03-26T21:56:35Z","merge_commit_sha":"33a3f01fab309905c15880e991ca891410a8ff08","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/samsonjs/strftime/pulls/58/commits","review_comments_url":"https://api.github.com/repos/samsonjs/strftime/pulls/58/comments","review_comment_url":"https://api.github.com/repos/samsonjs/strftime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/samsonjs/strftime/issues/58/comments","statuses_url":"https://api.github.com/repos/samsonjs/strftime/statuses/ab3d4a052ea48363e5c1684f5aff9d90f3ce2a30","head":{"label":"samsonjs:revert-57-Issue56_BugInWeekNumber","ref":"revert-57-Issue56_BugInWeekNumber","sha":"ab3d4a052ea48363e5c1684f5aff9d90f3ce2a30","user":{"login":"samsonjs","id":32487,"avatar_url":"https://avatars.githubusercontent.com/u/32487?v=3","gravatar_id":"","url":"https://api.github.com/users/samsonjs","html_url":"https://github.com/samsonjs","followers_url":"https://api.github.com/users/samsonjs/followers","following_url":"https://api.github.com/users/samsonjs/following{/other_user}","gists_url":"https://api.github.com/users/samsonjs/gists{/gist_id}","starred_url":"https://api.github.com/users/samsonjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samsonjs/subscriptions","organizations_url":"https://api.github.com/users/samsonjs/orgs","repos_url":"https://api.github.com/users/samsonjs/repos","events_url":"https://api.github.com/users/samsonjs/events{/privacy}","received_events_url":"https://api.github.com/users/samsonjs/received_events","type":"User","site_admin":false},"repo":{"id":1072788,"name":"strftime","full_name":"samsonjs/strftime","owner":{"login":"samsonjs","id":32487,"avatar_url":"https://avatars.githubusercontent.com/u/32487?v=3","gravatar_id":"","url":"https://api.github.com/users/samsonjs","html_url":"https://github.com/samsonjs","followers_url":"https://api.github.com/users/samsonjs/followers","following_url":"https://api.github.com/users/samsonjs/following{/other_user}","gists_url":"https://api.github.com/users/samsonjs/gists{/gist_id}","starred_url":"https://api.github.com/users/samsonjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samsonjs/subscriptions","organizations_url":"https://api.github.com/users/samsonjs/orgs","repos_url":"https://api.github.com/users/samsonjs/repos","events_url":"https://api.github.com/users/samsonjs/events{/privacy}","received_events_url":"https://api.github.com/users/samsonjs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samsonjs/strftime","description":"strftime for JavaScript","fork":false,"url":"https://api.github.com/repos/samsonjs/strftime","forks_url":"https://api.github.com/repos/samsonjs/strftime/forks","keys_url":"https://api.github.com/repos/samsonjs/strftime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samsonjs/strftime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samsonjs/strftime/teams","hooks_url":"https://api.github.com/repos/samsonjs/strftime/hooks","issue_events_url":"https://api.github.com/repos/samsonjs/strftime/issues/events{/number}","events_url":"https://api.github.com/repos/samsonjs/strftime/events","assignees_url":"https://api.github.com/repos/samsonjs/strftime/assignees{/user}","branches_url":"https://api.github.com/repos/samsonjs/strftime/branches{/branch}","tags_url":"https://api.github.com/repos/samsonjs/strftime/tags","blobs_url":"https://api.github.com/repos/samsonjs/strftime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samsonjs/strftime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samsonjs/strftime/git/refs{/sha}","trees_url":"https://api.github.com/repos/samsonjs/strftime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samsonjs/strftime/statuses/{sha}","languages_url":"https://api.github.com/repos/samsonjs/strftime/languages","stargazers_url":"https://api.github.com/repos/samsonjs/strftime/stargazers","contributors_url":"https://api.github.com/repos/samsonjs/strftime/contributors","subscribers_url":"https://api.github.com/repos/samsonjs/strftime/subscribers","subscription_url":"https://api.github.com/repos/samsonjs/strftime/subscription","commits_url":"https://api.github.com/repos/samsonjs/strftime/commits{/sha}","git_commits_url":"https://api.github.com/repos/samsonjs/strftime/git/commits{/sha}","comments_url":"https://api.github.com/repos/samsonjs/strftime/comments{/number}","issue_comment_url":"https://api.github.com/repos/samsonjs/strftime/issues/comments{/number}","contents_url":"https://api.github.com/repos/samsonjs/strftime/contents/{+path}","compare_url":"https://api.github.com/repos/samsonjs/strftime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samsonjs/strftime/merges","archive_url":"https://api.github.com/repos/samsonjs/strftime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samsonjs/strftime/downloads","issues_url":"https://api.github.com/repos/samsonjs/strftime/issues{/number}","pulls_url":"https://api.github.com/repos/samsonjs/strftime/pulls{/number}","milestones_url":"https://api.github.com/repos/samsonjs/strftime/milestones{/number}","notifications_url":"https://api.github.com/repos/samsonjs/strftime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samsonjs/strftime/labels{/name}","releases_url":"https://api.github.com/repos/samsonjs/strftime/releases{/id}","created_at":"2010-11-11T21:17:25Z","updated_at":"2015-03-27T03:03:53Z","pushed_at":"2015-03-26T21:56:42Z","git_url":"git://github.com/samsonjs/strftime.git","ssh_url":"git@github.com:samsonjs/strftime.git","clone_url":"https://github.com/samsonjs/strftime.git","svn_url":"https://github.com/samsonjs/strftime","homepage":"http://samhuri.net/projects/strftime","size":602,"stargazers_count":234,"watchers_count":234,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":6,"forks":70,"open_issues":6,"watchers":234,"default_branch":"master"}},"base":{"label":"samsonjs:master","ref":"master","sha":"603a716bf89beeb892dbaf79c779311aaa15ee55","user":{"login":"samsonjs","id":32487,"avatar_url":"https://avatars.githubusercontent.com/u/32487?v=3","gravatar_id":"","url":"https://api.github.com/users/samsonjs","html_url":"https://github.com/samsonjs","followers_url":"https://api.github.com/users/samsonjs/followers","following_url":"https://api.github.com/users/samsonjs/following{/other_user}","gists_url":"https://api.github.com/users/samsonjs/gists{/gist_id}","starred_url":"https://api.github.com/users/samsonjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samsonjs/subscriptions","organizations_url":"https://api.github.com/users/samsonjs/orgs","repos_url":"https://api.github.com/users/samsonjs/repos","events_url":"https://api.github.com/users/samsonjs/events{/privacy}","received_events_url":"https://api.github.com/users/samsonjs/received_events","type":"User","site_admin":false},"repo":{"id":1072788,"name":"strftime","full_name":"samsonjs/strftime","owner":{"login":"samsonjs","id":32487,"avatar_url":"https://avatars.githubusercontent.com/u/32487?v=3","gravatar_id":"","url":"https://api.github.com/users/samsonjs","html_url":"https://github.com/samsonjs","followers_url":"https://api.github.com/users/samsonjs/followers","following_url":"https://api.github.com/users/samsonjs/following{/other_user}","gists_url":"https://api.github.com/users/samsonjs/gists{/gist_id}","starred_url":"https://api.github.com/users/samsonjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samsonjs/subscriptions","organizations_url":"https://api.github.com/users/samsonjs/orgs","repos_url":"https://api.github.com/users/samsonjs/repos","events_url":"https://api.github.com/users/samsonjs/events{/privacy}","received_events_url":"https://api.github.com/users/samsonjs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samsonjs/strftime","description":"strftime for JavaScript","fork":false,"url":"https://api.github.com/repos/samsonjs/strftime","forks_url":"https://api.github.com/repos/samsonjs/strftime/forks","keys_url":"https://api.github.com/repos/samsonjs/strftime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samsonjs/strftime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samsonjs/strftime/teams","hooks_url":"https://api.github.com/repos/samsonjs/strftime/hooks","issue_events_url":"https://api.github.com/repos/samsonjs/strftime/issues/events{/number}","events_url":"https://api.github.com/repos/samsonjs/strftime/events","assignees_url":"https://api.github.com/repos/samsonjs/strftime/assignees{/user}","branches_url":"https://api.github.com/repos/samsonjs/strftime/branches{/branch}","tags_url":"https://api.github.com/repos/samsonjs/strftime/tags","blobs_url":"https://api.github.com/repos/samsonjs/strftime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samsonjs/strftime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samsonjs/strftime/git/refs{/sha}","trees_url":"https://api.github.com/repos/samsonjs/strftime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samsonjs/strftime/statuses/{sha}","languages_url":"https://api.github.com/repos/samsonjs/strftime/languages","stargazers_url":"https://api.github.com/repos/samsonjs/strftime/stargazers","contributors_url":"https://api.github.com/repos/samsonjs/strftime/contributors","subscribers_url":"https://api.github.com/repos/samsonjs/strftime/subscribers","subscription_url":"https://api.github.com/repos/samsonjs/strftime/subscription","commits_url":"https://api.github.com/repos/samsonjs/strftime/commits{/sha}","git_commits_url":"https://api.github.com/repos/samsonjs/strftime/git/commits{/sha}","comments_url":"https://api.github.com/repos/samsonjs/strftime/comments{/number}","issue_comment_url":"https://api.github.com/repos/samsonjs/strftime/issues/comments{/number}","contents_url":"https://api.github.com/repos/samsonjs/strftime/contents/{+path}","compare_url":"https://api.github.com/repos/samsonjs/strftime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samsonjs/strftime/merges","archive_url":"https://api.github.com/repos/samsonjs/strftime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samsonjs/strftime/downloads","issues_url":"https://api.github.com/repos/samsonjs/strftime/issues{/number}","pulls_url":"https://api.github.com/repos/samsonjs/strftime/pulls{/number}","milestones_url":"https://api.github.com/repos/samsonjs/strftime/milestones{/number}","notifications_url":"https://api.github.com/repos/samsonjs/strftime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samsonjs/strftime/labels{/name}","releases_url":"https://api.github.com/repos/samsonjs/strftime/releases{/id}","created_at":"2010-11-11T21:17:25Z","updated_at":"2015-03-27T03:03:53Z","pushed_at":"2015-03-26T21:56:42Z","git_url":"git://github.com/samsonjs/strftime.git","ssh_url":"git@github.com:samsonjs/strftime.git","clone_url":"https://github.com/samsonjs/strftime.git","svn_url":"https://github.com/samsonjs/strftime","homepage":"http://samhuri.net/projects/strftime","size":602,"stargazers_count":234,"watchers_count":234,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":6,"forks":70,"open_issues":6,"watchers":234,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/samsonjs/strftime/pulls/58"},"html":{"href":"https://github.com/samsonjs/strftime/pull/58"},"issue":{"href":"https://api.github.com/repos/samsonjs/strftime/issues/58"},"comments":{"href":"https://api.github.com/repos/samsonjs/strftime/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/samsonjs/strftime/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/samsonjs/strftime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/samsonjs/strftime/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/samsonjs/strftime/statuses/ab3d4a052ea48363e5c1684f5aff9d90f3ce2a30"}}}}