{"action":"created","comment":{"url":"https://api.github.com/repos/gilt/ubar/pulls/comments/25789131","id":25789131,"diff_hunk":"@@ -16,29 +16,21 @@\n \n     'use strict';\n \n-    /**\n-    * Expiration Time:\n-    *\n-    * Disabled sets the amount of time the banner will\n-    * not appear to the user. It's essentially the same\n-    * as if the user said \"ignore.\"\n-    *\n-    * Enabled sets the amount of time the redirection\n-    * will take place. This exists once a user elects\n-    * to participate in ubar.\n-    *\n-    * Redirected sets the amount of time the user has\n-    * on the web before being redirected again. Imagine\n-    * the user is redirected but wants to manager her\n-    * settings. She has this amount of time do so before\n-    * being redirected again. \n-    *\n-    */\n-    var expiration_time = {\n-        disabled: moment.duration(2, 'weeks'),\n-        enabled: moment.duration(1, 'year'),\n-        redirected: moment.duration(60, 'seconds')\n-      },\n+    var defaultConfig = {","path":"js/ubar/config.js","position":43,"original_position":43,"commit_id":"59bb50975797fcf5518e89e7a01468ec079bec71","original_commit_id":"59bb50975797fcf5518e89e7a01468ec079bec71","user":{"login":"archanks","id":1166493,"avatar_url":"https://avatars.githubusercontent.com/u/1166493?v=3","gravatar_id":"","url":"https://api.github.com/users/archanks","html_url":"https://github.com/archanks","followers_url":"https://api.github.com/users/archanks/followers","following_url":"https://api.github.com/users/archanks/following{/other_user}","gists_url":"https://api.github.com/users/archanks/gists{/gist_id}","starred_url":"https://api.github.com/users/archanks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/archanks/subscriptions","organizations_url":"https://api.github.com/users/archanks/orgs","repos_url":"https://api.github.com/users/archanks/repos","events_url":"https://api.github.com/users/archanks/events{/privacy}","received_events_url":"https://api.github.com/users/archanks/received_events","type":"User","site_admin":false},"body":"I agree. Not sure where would be best to explain this. \r\nHowe about if we explained all the values in the defaultConfig inside the config file ?","created_at":"2015-03-04T16:37:56Z","updated_at":"2015-03-04T16:37:56Z","html_url":"https://github.com/gilt/ubar/pull/1#discussion_r25789131","pull_request_url":"https://api.github.com/repos/gilt/ubar/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/gilt/ubar/pulls/comments/25789131"},"html":{"href":"https://github.com/gilt/ubar/pull/1#discussion_r25789131"},"pull_request":{"href":"https://api.github.com/repos/gilt/ubar/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/gilt/ubar/pulls/1","id":30410664,"html_url":"https://github.com/gilt/ubar/pull/1","diff_url":"https://github.com/gilt/ubar/pull/1.diff","patch_url":"https://github.com/gilt/ubar/pull/1.patch","issue_url":"https://api.github.com/repos/gilt/ubar/issues/1","number":1,"state":"open","locked":false,"title":"Refactoring for user config","user":{"login":"archanks","id":1166493,"avatar_url":"https://avatars.githubusercontent.com/u/1166493?v=3","gravatar_id":"","url":"https://api.github.com/users/archanks","html_url":"https://github.com/archanks","followers_url":"https://api.github.com/users/archanks/followers","following_url":"https://api.github.com/users/archanks/following{/other_user}","gists_url":"https://api.github.com/users/archanks/gists{/gist_id}","starred_url":"https://api.github.com/users/archanks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/archanks/subscriptions","organizations_url":"https://api.github.com/users/archanks/orgs","repos_url":"https://api.github.com/users/archanks/repos","events_url":"https://api.github.com/users/archanks/events{/privacy}","received_events_url":"https://api.github.com/users/archanks/received_events","type":"User","site_admin":false},"body":"thoughts?","created_at":"2015-03-03T20:43:11Z","updated_at":"2015-03-04T16:37:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d6ea24916c0d121a3d4255b5cf7225638c0c6e3","assignee":{"login":"archanks","id":1166493,"avatar_url":"https://avatars.githubusercontent.com/u/1166493?v=3","gravatar_id":"","url":"https://api.github.com/users/archanks","html_url":"https://github.com/archanks","followers_url":"https://api.github.com/users/archanks/followers","following_url":"https://api.github.com/users/archanks/following{/other_user}","gists_url":"https://api.github.com/users/archanks/gists{/gist_id}","starred_url":"https://api.github.com/users/archanks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/archanks/subscriptions","organizations_url":"https://api.github.com/users/archanks/orgs","repos_url":"https://api.github.com/users/archanks/repos","events_url":"https://api.github.com/users/archanks/events{/privacy}","received_events_url":"https://api.github.com/users/archanks/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/gilt/ubar/pulls/1/commits","review_comments_url":"https://api.github.com/repos/gilt/ubar/pulls/1/comments","review_comment_url":"https://api.github.com/repos/gilt/ubar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gilt/ubar/issues/1/comments","statuses_url":"https://api.github.com/repos/gilt/ubar/statuses/59bb50975797fcf5518e89e7a01468ec079bec71","head":{"label":"gilt:refactoring_for_user_config","ref":"refactoring_for_user_config","sha":"59bb50975797fcf5518e89e7a01468ec079bec71","user":{"login":"gilt","id":160415,"avatar_url":"https://avatars.githubusercontent.com/u/160415?v=3","gravatar_id":"","url":"https://api.github.com/users/gilt","html_url":"https://github.com/gilt","followers_url":"https://api.github.com/users/gilt/followers","following_url":"https://api.github.com/users/gilt/following{/other_user}","gists_url":"https://api.github.com/users/gilt/gists{/gist_id}","starred_url":"https://api.github.com/users/gilt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gilt/subscriptions","organizations_url":"https://api.github.com/users/gilt/orgs","repos_url":"https://api.github.com/users/gilt/repos","events_url":"https://api.github.com/users/gilt/events{/privacy}","received_events_url":"https://api.github.com/users/gilt/received_events","type":"Organization","site_admin":false},"repo":{"id":31337329,"name":"ubar","full_name":"gilt/ubar","owner":{"login":"gilt","id":160415,"avatar_url":"https://avatars.githubusercontent.com/u/160415?v=3","gravatar_id":"","url":"https://api.github.com/users/gilt","html_url":"https://github.com/gilt","followers_url":"https://api.github.com/users/gilt/followers","following_url":"https://api.github.com/users/gilt/following{/other_user}","gists_url":"https://api.github.com/users/gilt/gists{/gist_id}","starred_url":"https://api.github.com/users/gilt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gilt/subscriptions","organizations_url":"https://api.github.com/users/gilt/orgs","repos_url":"https://api.github.com/users/gilt/repos","events_url":"https://api.github.com/users/gilt/events{/privacy}","received_events_url":"https://api.github.com/users/gilt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gilt/ubar","description":"UBAR: Unidirectional Browser App Resolver. A front-end library that shepherds users into native apps from the browser and handles users returning to the browser.","fork":false,"url":"https://api.github.com/repos/gilt/ubar","forks_url":"https://api.github.com/repos/gilt/ubar/forks","keys_url":"https://api.github.com/repos/gilt/ubar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gilt/ubar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gilt/ubar/teams","hooks_url":"https://api.github.com/repos/gilt/ubar/hooks","issue_events_url":"https://api.github.com/repos/gilt/ubar/issues/events{/number}","events_url":"https://api.github.com/repos/gilt/ubar/events","assignees_url":"https://api.github.com/repos/gilt/ubar/assignees{/user}","branches_url":"https://api.github.com/repos/gilt/ubar/branches{/branch}","tags_url":"https://api.github.com/repos/gilt/ubar/tags","blobs_url":"https://api.github.com/repos/gilt/ubar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gilt/ubar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gilt/ubar/git/refs{/sha}","trees_url":"https://api.github.com/repos/gilt/ubar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gilt/ubar/statuses/{sha}","languages_url":"https://api.github.com/repos/gilt/ubar/languages","stargazers_url":"https://api.github.com/repos/gilt/ubar/stargazers","contributors_url":"https://api.github.com/repos/gilt/ubar/contributors","subscribers_url":"https://api.github.com/repos/gilt/ubar/subscribers","subscription_url":"https://api.github.com/repos/gilt/ubar/subscription","commits_url":"https://api.github.com/repos/gilt/ubar/commits{/sha}","git_commits_url":"https://api.github.com/repos/gilt/ubar/git/commits{/sha}","comments_url":"https://api.github.com/repos/gilt/ubar/comments{/number}","issue_comment_url":"https://api.github.com/repos/gilt/ubar/issues/comments{/number}","contents_url":"https://api.github.com/repos/gilt/ubar/contents/{+path}","compare_url":"https://api.github.com/repos/gilt/ubar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gilt/ubar/merges","archive_url":"https://api.github.com/repos/gilt/ubar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gilt/ubar/downloads","issues_url":"https://api.github.com/repos/gilt/ubar/issues{/number}","pulls_url":"https://api.github.com/repos/gilt/ubar/pulls{/number}","milestones_url":"https://api.github.com/repos/gilt/ubar/milestones{/number}","notifications_url":"https://api.github.com/repos/gilt/ubar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gilt/ubar/labels{/name}","releases_url":"https://api.github.com/repos/gilt/ubar/releases{/id}","created_at":"2015-02-25T21:44:42Z","updated_at":"2015-03-02T22:48:28Z","pushed_at":"2015-03-03T20:41:13Z","git_url":"git://github.com/gilt/ubar.git","ssh_url":"git@github.com:gilt/ubar.git","clone_url":"https://github.com/gilt/ubar.git","svn_url":"https://github.com/gilt/ubar","homepage":null,"size":0,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"gilt:master","ref":"master","sha":"be49688fc12ca495e9493c7bd9f60faaf588298f","user":{"login":"gilt","id":160415,"avatar_url":"https://avatars.githubusercontent.com/u/160415?v=3","gravatar_id":"","url":"https://api.github.com/users/gilt","html_url":"https://github.com/gilt","followers_url":"https://api.github.com/users/gilt/followers","following_url":"https://api.github.com/users/gilt/following{/other_user}","gists_url":"https://api.github.com/users/gilt/gists{/gist_id}","starred_url":"https://api.github.com/users/gilt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gilt/subscriptions","organizations_url":"https://api.github.com/users/gilt/orgs","repos_url":"https://api.github.com/users/gilt/repos","events_url":"https://api.github.com/users/gilt/events{/privacy}","received_events_url":"https://api.github.com/users/gilt/received_events","type":"Organization","site_admin":false},"repo":{"id":31337329,"name":"ubar","full_name":"gilt/ubar","owner":{"login":"gilt","id":160415,"avatar_url":"https://avatars.githubusercontent.com/u/160415?v=3","gravatar_id":"","url":"https://api.github.com/users/gilt","html_url":"https://github.com/gilt","followers_url":"https://api.github.com/users/gilt/followers","following_url":"https://api.github.com/users/gilt/following{/other_user}","gists_url":"https://api.github.com/users/gilt/gists{/gist_id}","starred_url":"https://api.github.com/users/gilt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gilt/subscriptions","organizations_url":"https://api.github.com/users/gilt/orgs","repos_url":"https://api.github.com/users/gilt/repos","events_url":"https://api.github.com/users/gilt/events{/privacy}","received_events_url":"https://api.github.com/users/gilt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gilt/ubar","description":"UBAR: Unidirectional Browser App Resolver. A front-end library that shepherds users into native apps from the browser and handles users returning to the browser.","fork":false,"url":"https://api.github.com/repos/gilt/ubar","forks_url":"https://api.github.com/repos/gilt/ubar/forks","keys_url":"https://api.github.com/repos/gilt/ubar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gilt/ubar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gilt/ubar/teams","hooks_url":"https://api.github.com/repos/gilt/ubar/hooks","issue_events_url":"https://api.github.com/repos/gilt/ubar/issues/events{/number}","events_url":"https://api.github.com/repos/gilt/ubar/events","assignees_url":"https://api.github.com/repos/gilt/ubar/assignees{/user}","branches_url":"https://api.github.com/repos/gilt/ubar/branches{/branch}","tags_url":"https://api.github.com/repos/gilt/ubar/tags","blobs_url":"https://api.github.com/repos/gilt/ubar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gilt/ubar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gilt/ubar/git/refs{/sha}","trees_url":"https://api.github.com/repos/gilt/ubar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gilt/ubar/statuses/{sha}","languages_url":"https://api.github.com/repos/gilt/ubar/languages","stargazers_url":"https://api.github.com/repos/gilt/ubar/stargazers","contributors_url":"https://api.github.com/repos/gilt/ubar/contributors","subscribers_url":"https://api.github.com/repos/gilt/ubar/subscribers","subscription_url":"https://api.github.com/repos/gilt/ubar/subscription","commits_url":"https://api.github.com/repos/gilt/ubar/commits{/sha}","git_commits_url":"https://api.github.com/repos/gilt/ubar/git/commits{/sha}","comments_url":"https://api.github.com/repos/gilt/ubar/comments{/number}","issue_comment_url":"https://api.github.com/repos/gilt/ubar/issues/comments{/number}","contents_url":"https://api.github.com/repos/gilt/ubar/contents/{+path}","compare_url":"https://api.github.com/repos/gilt/ubar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gilt/ubar/merges","archive_url":"https://api.github.com/repos/gilt/ubar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gilt/ubar/downloads","issues_url":"https://api.github.com/repos/gilt/ubar/issues{/number}","pulls_url":"https://api.github.com/repos/gilt/ubar/pulls{/number}","milestones_url":"https://api.github.com/repos/gilt/ubar/milestones{/number}","notifications_url":"https://api.github.com/repos/gilt/ubar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gilt/ubar/labels{/name}","releases_url":"https://api.github.com/repos/gilt/ubar/releases{/id}","created_at":"2015-02-25T21:44:42Z","updated_at":"2015-03-02T22:48:28Z","pushed_at":"2015-03-03T20:41:13Z","git_url":"git://github.com/gilt/ubar.git","ssh_url":"git@github.com:gilt/ubar.git","clone_url":"https://github.com/gilt/ubar.git","svn_url":"https://github.com/gilt/ubar","homepage":null,"size":0,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gilt/ubar/pulls/1"},"html":{"href":"https://github.com/gilt/ubar/pull/1"},"issue":{"href":"https://api.github.com/repos/gilt/ubar/issues/1"},"comments":{"href":"https://api.github.com/repos/gilt/ubar/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/gilt/ubar/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/gilt/ubar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gilt/ubar/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/gilt/ubar/statuses/59bb50975797fcf5518e89e7a01468ec079bec71"}}}}