{"action":"created","comment":{"url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/comments/23486434","id":23486434,"diff_hunk":"@@ -94,8 +94,12 @@ def configure_step(self):\n         try:\n             for line in fileinput.input(fp, inplace=1, backup='.orig'):\n                 for (k, v) in cfgvars.items():","path":"easybuild/easyblocks/s/suitesparse.py","position":3,"original_position":3,"commit_id":"bcb78b66dd19ccc7c455873167e2484068fd4636","original_commit_id":"bcb78b66dd19ccc7c455873167e2484068fd4636","user":{"login":"boegel","id":620876,"avatar_url":"https://avatars.githubusercontent.com/u/620876?v=3","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"body":"replace `k` and `v` by non-single-letter variable names (`key` and `val` will do, but more meaningful (yet still short) would be even better)","created_at":"2015-01-23T22:49:28Z","updated_at":"2015-01-23T22:49:28Z","html_url":"https://github.com/hpcugent/easybuild-easyblocks/pull/541#discussion_r23486434","pull_request_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/541","_links":{"self":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/comments/23486434"},"html":{"href":"https://github.com/hpcugent/easybuild-easyblocks/pull/541#discussion_r23486434"},"pull_request":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/541"}}},"pull_request":{"url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/541","id":27924591,"html_url":"https://github.com/hpcugent/easybuild-easyblocks/pull/541","diff_url":"https://github.com/hpcugent/easybuild-easyblocks/pull/541.diff","patch_url":"https://github.com/hpcugent/easybuild-easyblocks/pull/541.patch","issue_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/541","number":541,"state":"open","locked":false,"title":"Fix/suitesparse","user":{"login":"gjbex","id":4801336,"avatar_url":"https://avatars.githubusercontent.com/u/4801336?v=3","gravatar_id":"","url":"https://api.github.com/users/gjbex","html_url":"https://github.com/gjbex","followers_url":"https://api.github.com/users/gjbex/followers","following_url":"https://api.github.com/users/gjbex/following{/other_user}","gists_url":"https://api.github.com/users/gjbex/gists{/gist_id}","starred_url":"https://api.github.com/users/gjbex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gjbex/subscriptions","organizations_url":"https://api.github.com/users/gjbex/orgs","repos_url":"https://api.github.com/users/gjbex/repos","events_url":"https://api.github.com/users/gjbex/events{/privacy}","received_events_url":"https://api.github.com/users/gjbex/received_events","type":"User","site_admin":false},"body":"Fixed two problems with this easyblock:\r\n1) it assumes variable definitions in the .mk file will not have leading whitespace (assumption doesn't hold for SuiteSparse 4.4.3),\r\n2) the mechanism for ensuring that all variables not replaced in the .mk file are appended works only if the variable name does not occur in any line (e.g., comment) prior to its definition (definitely not the case in SuiteSparse 4.4.3).\r\n\r\nAlthough the current code works, it is not future proof.  In Python 2, the items() method returns a list of key/value tuples, hence it is save to apply the pop() method to the cfgvars dictionary.  In Python 3, the items() method will return an iterator, and removing items from a data structure one is iterating over is not a good idea.\r\nI've only added a comment, since I assume that this pattern will be quite pervasive given the list of authors of this block, so it should probably be addressed more systematically.","created_at":"2015-01-23T13:50:47Z","updated_at":"2015-01-23T22:49:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea319ccb1aacf1d22cf2f1d6d49bf63356b6bf61","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/541/commits","review_comments_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/541/comments","review_comment_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/comments/{number}","comments_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/541/comments","statuses_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/statuses/bcb78b66dd19ccc7c455873167e2484068fd4636","head":{"label":"hpcleuven:fix/suitesparse","ref":"fix/suitesparse","sha":"bcb78b66dd19ccc7c455873167e2484068fd4636","user":{"login":"hpcleuven","id":4800983,"avatar_url":"https://avatars.githubusercontent.com/u/4800983?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcleuven","html_url":"https://github.com/hpcleuven","followers_url":"https://api.github.com/users/hpcleuven/followers","following_url":"https://api.github.com/users/hpcleuven/following{/other_user}","gists_url":"https://api.github.com/users/hpcleuven/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcleuven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcleuven/subscriptions","organizations_url":"https://api.github.com/users/hpcleuven/orgs","repos_url":"https://api.github.com/users/hpcleuven/repos","events_url":"https://api.github.com/users/hpcleuven/events{/privacy}","received_events_url":"https://api.github.com/users/hpcleuven/received_events","type":"Organization","site_admin":false},"repo":{"id":10910040,"name":"easybuild-easyblocks","full_name":"hpcleuven/easybuild-easyblocks","owner":{"login":"hpcleuven","id":4800983,"avatar_url":"https://avatars.githubusercontent.com/u/4800983?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcleuven","html_url":"https://github.com/hpcleuven","followers_url":"https://api.github.com/users/hpcleuven/followers","following_url":"https://api.github.com/users/hpcleuven/following{/other_user}","gists_url":"https://api.github.com/users/hpcleuven/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcleuven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcleuven/subscriptions","organizations_url":"https://api.github.com/users/hpcleuven/orgs","repos_url":"https://api.github.com/users/hpcleuven/repos","events_url":"https://api.github.com/users/hpcleuven/events{/privacy}","received_events_url":"https://api.github.com/users/hpcleuven/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcleuven/easybuild-easyblocks","description":"Collection of easyblock that implement support for building and installing software with EasyBuild.","fork":true,"url":"https://api.github.com/repos/hpcleuven/easybuild-easyblocks","forks_url":"https://api.github.com/repos/hpcleuven/easybuild-easyblocks/forks","keys_url":"https://api.github.com/repos/hpcleuven/easybuild-easyblocks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcleuven/easybuild-easyblocks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcleuven/easybuild-easyblocks/teams","hooks_url":"https://api.github.com/repos/hpcleuven/easybuild-easyblocks/hooks","issue_events_url":"https://api.github.com/repos/hpcleuven/easybuild-easyblocks/issues/events{/number}","events_url":"https://api.github.com/repos/hpcleuven/easybuild-easyblocks/events","assignees_url":"https://api.github.com/repos/hpcleuven/easybuild-easyblocks/assignees{/user}","branches_url":"https://api.github.com/repos/hpcleuven/easybuild-easyblocks/branches{/branch}","tags_url":"https://api.github.com/repos/hpcleuven/easybuild-easyblocks/tags","blobs_url":"https://api.github.com/repos/hpcleuven/easybuild-easyblocks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcleuven/easybuild-easyblocks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcleuven/easybuild-easyblocks/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcleuven/easybuild-easyblocks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcleuven/easybuild-easyblocks/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcleuven/easybuild-easyblocks/languages","stargazers_url":"https://api.github.com/repos/hpcleuven/easybuild-easyblocks/stargazers","contributors_url":"https://api.github.com/repos/hpcleuven/easybuild-easyblocks/contributors","subscribers_url":"https://api.github.com/repos/hpcleuven/easybuild-easyblocks/subscribers","subscription_url":"https://api.github.com/repos/hpcleuven/easybuild-easyblocks/subscription","commits_url":"https://api.github.com/repos/hpcleuven/easybuild-easyblocks/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcleuven/easybuild-easyblocks/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcleuven/easybuild-easyblocks/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcleuven/easybuild-easyblocks/issues/comments/{number}","contents_url":"https://api.github.com/repos/hpcleuven/easybuild-easyblocks/contents/{+path}","compare_url":"https://api.github.com/repos/hpcleuven/easybuild-easyblocks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcleuven/easybuild-easyblocks/merges","archive_url":"https://api.github.com/repos/hpcleuven/easybuild-easyblocks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcleuven/easybuild-easyblocks/downloads","issues_url":"https://api.github.com/repos/hpcleuven/easybuild-easyblocks/issues{/number}","pulls_url":"https://api.github.com/repos/hpcleuven/easybuild-easyblocks/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcleuven/easybuild-easyblocks/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcleuven/easybuild-easyblocks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcleuven/easybuild-easyblocks/labels{/name}","releases_url":"https://api.github.com/repos/hpcleuven/easybuild-easyblocks/releases{/id}","created_at":"2013-06-24T14:11:49Z","updated_at":"2015-01-07T13:10:38Z","pushed_at":"2015-01-23T13:40:11Z","git_url":"git://github.com/hpcleuven/easybuild-easyblocks.git","ssh_url":"git@github.com:hpcleuven/easybuild-easyblocks.git","clone_url":"https://github.com/hpcleuven/easybuild-easyblocks.git","svn_url":"https://github.com/hpcleuven/easybuild-easyblocks","homepage":"http://hpcugent.github.com/easybuild/","size":7737,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"hpcugent:develop","ref":"develop","sha":"5986380d5903163300bf1512f259148ba56cfe7b","user":{"login":"hpcugent","id":1515263,"avatar_url":"https://avatars.githubusercontent.com/u/1515263?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcugent","html_url":"https://github.com/hpcugent","followers_url":"https://api.github.com/users/hpcugent/followers","following_url":"https://api.github.com/users/hpcugent/following{/other_user}","gists_url":"https://api.github.com/users/hpcugent/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcugent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcugent/subscriptions","organizations_url":"https://api.github.com/users/hpcugent/orgs","repos_url":"https://api.github.com/users/hpcugent/repos","events_url":"https://api.github.com/users/hpcugent/events{/privacy}","received_events_url":"https://api.github.com/users/hpcugent/received_events","type":"Organization","site_admin":false},"repo":{"id":6228378,"name":"easybuild-easyblocks","full_name":"hpcugent/easybuild-easyblocks","owner":{"login":"hpcugent","id":1515263,"avatar_url":"https://avatars.githubusercontent.com/u/1515263?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcugent","html_url":"https://github.com/hpcugent","followers_url":"https://api.github.com/users/hpcugent/followers","following_url":"https://api.github.com/users/hpcugent/following{/other_user}","gists_url":"https://api.github.com/users/hpcugent/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcugent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcugent/subscriptions","organizations_url":"https://api.github.com/users/hpcugent/orgs","repos_url":"https://api.github.com/users/hpcugent/repos","events_url":"https://api.github.com/users/hpcugent/events{/privacy}","received_events_url":"https://api.github.com/users/hpcugent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcugent/easybuild-easyblocks","description":"Collection of easyblocks that implement support for building and installing software with EasyBuild.","fork":false,"url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks","forks_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/forks","keys_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/teams","hooks_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/hooks","issue_events_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/events{/number}","events_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/events","assignees_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/assignees{/user}","branches_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/branches{/branch}","tags_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/tags","blobs_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/languages","stargazers_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/stargazers","contributors_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/contributors","subscribers_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/subscribers","subscription_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/subscription","commits_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/comments/{number}","contents_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/contents/{+path}","compare_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/merges","archive_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/downloads","issues_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues{/number}","pulls_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/labels{/name}","releases_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/releases{/id}","created_at":"2012-10-15T14:31:19Z","updated_at":"2014-12-19T13:10:52Z","pushed_at":"2015-01-16T16:38:36Z","git_url":"git://github.com/hpcugent/easybuild-easyblocks.git","ssh_url":"git@github.com:hpcugent/easybuild-easyblocks.git","clone_url":"https://github.com/hpcugent/easybuild-easyblocks.git","svn_url":"https://github.com/hpcugent/easybuild-easyblocks","homepage":"http://hpcugent.github.com/easybuild/","size":10560,"stargazers_count":18,"watchers_count":18,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":57,"mirror_url":null,"open_issues_count":87,"forks":57,"open_issues":87,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/541"},"html":{"href":"https://github.com/hpcugent/easybuild-easyblocks/pull/541"},"issue":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/541"},"comments":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/541/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/541/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/541/commits"},"statuses":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/statuses/bcb78b66dd19ccc7c455873167e2484068fd4636"}}}}