{"action":"created","comment":{"url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/pulls/comments/38979544","id":38979544,"diff_hunk":"@@ -19,7 +19,10 @@ peterpiper += \"Where's the peck of pickled peppers Peter Piper picked?\";\n \n var counter = 0;\n \n-// TODO: Count the number of times an uppercase P or lowercase p character\n-//       occurs in the `peterpiper` string.\n+for (var i = 0; i < peterpiper.length; i++) {\n+  if(peterpiper.charAt(i) == 'p') {","path":"peter-piper.js","position":7,"original_position":7,"commit_id":"34d477fad850f3787c7f4126a14db7496921a6b2","original_commit_id":"34d477fad850f3787c7f4126a14db7496921a6b2","user":{"login":"barberboy","id":371332,"avatar_url":"https://avatars.githubusercontent.com/u/371332?v=3","gravatar_id":"","url":"https://api.github.com/users/barberboy","html_url":"https://github.com/barberboy","followers_url":"https://api.github.com/users/barberboy/followers","following_url":"https://api.github.com/users/barberboy/following{/other_user}","gists_url":"https://api.github.com/users/barberboy/gists{/gist_id}","starred_url":"https://api.github.com/users/barberboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barberboy/subscriptions","organizations_url":"https://api.github.com/users/barberboy/orgs","repos_url":"https://api.github.com/users/barberboy/repos","events_url":"https://api.github.com/users/barberboy/events{/privacy}","received_events_url":"https://api.github.com/users/barberboy/received_events","type":"User","site_admin":false},"body":"It looks like you are only checking for lowercase 'p's. You should either convert peterpiper to lowercase before looping through the characters, OR add an \"logical OR\" check, and check for the uppercase 'P' character also.","created_at":"2015-09-08T21:00:14Z","updated_at":"2015-09-08T21:00:14Z","html_url":"https://github.com/unioncollege-webtech/peter-piper/pull/16#discussion_r38979544","pull_request_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/unioncollege-webtech/peter-piper/pulls/comments/38979544"},"html":{"href":"https://github.com/unioncollege-webtech/peter-piper/pull/16#discussion_r38979544"},"pull_request":{"href":"https://api.github.com/repos/unioncollege-webtech/peter-piper/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/pulls/16","id":44482073,"html_url":"https://github.com/unioncollege-webtech/peter-piper/pull/16","diff_url":"https://github.com/unioncollege-webtech/peter-piper/pull/16.diff","patch_url":"https://github.com/unioncollege-webtech/peter-piper/pull/16.patch","issue_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/issues/16","number":16,"state":"open","locked":false,"title":"Submitting assignment","user":{"login":"barberboy","id":371332,"avatar_url":"https://avatars.githubusercontent.com/u/371332?v=3","gravatar_id":"","url":"https://api.github.com/users/barberboy","html_url":"https://github.com/barberboy","followers_url":"https://api.github.com/users/barberboy/followers","following_url":"https://api.github.com/users/barberboy/following{/other_user}","gists_url":"https://api.github.com/users/barberboy/gists{/gist_id}","starred_url":"https://api.github.com/users/barberboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barberboy/subscriptions","organizations_url":"https://api.github.com/users/barberboy/orgs","repos_url":"https://api.github.com/users/barberboy/repos","events_url":"https://api.github.com/users/barberboy/events{/privacy}","received_events_url":"https://api.github.com/users/barberboy/received_events","type":"User","site_admin":false},"body":"@barberboy I think is correct, but it says that I'm not counting enough 'p's. Can you help?","created_at":"2015-09-08T20:57:32Z","updated_at":"2015-09-08T21:00:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eac921ded31a9bd490f19963eecdd7a068540029","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/pulls/16/commits","review_comments_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/pulls/16/comments","review_comment_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/issues/16/comments","statuses_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/statuses/34d477fad850f3787c7f4126a14db7496921a6b2","head":{"label":"barberboy:master","ref":"master","sha":"34d477fad850f3787c7f4126a14db7496921a6b2","user":{"login":"barberboy","id":371332,"avatar_url":"https://avatars.githubusercontent.com/u/371332?v=3","gravatar_id":"","url":"https://api.github.com/users/barberboy","html_url":"https://github.com/barberboy","followers_url":"https://api.github.com/users/barberboy/followers","following_url":"https://api.github.com/users/barberboy/following{/other_user}","gists_url":"https://api.github.com/users/barberboy/gists{/gist_id}","starred_url":"https://api.github.com/users/barberboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barberboy/subscriptions","organizations_url":"https://api.github.com/users/barberboy/orgs","repos_url":"https://api.github.com/users/barberboy/repos","events_url":"https://api.github.com/users/barberboy/events{/privacy}","received_events_url":"https://api.github.com/users/barberboy/received_events","type":"User","site_admin":false},"repo":{"id":42137949,"name":"peter-piper","full_name":"barberboy/peter-piper","owner":{"login":"barberboy","id":371332,"avatar_url":"https://avatars.githubusercontent.com/u/371332?v=3","gravatar_id":"","url":"https://api.github.com/users/barberboy","html_url":"https://github.com/barberboy","followers_url":"https://api.github.com/users/barberboy/followers","following_url":"https://api.github.com/users/barberboy/following{/other_user}","gists_url":"https://api.github.com/users/barberboy/gists{/gist_id}","starred_url":"https://api.github.com/users/barberboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barberboy/subscriptions","organizations_url":"https://api.github.com/users/barberboy/orgs","repos_url":"https://api.github.com/users/barberboy/repos","events_url":"https://api.github.com/users/barberboy/events{/privacy}","received_events_url":"https://api.github.com/users/barberboy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/barberboy/peter-piper","description":"An exercise for inspecting strings using .length and .charAt()","fork":true,"url":"https://api.github.com/repos/barberboy/peter-piper","forks_url":"https://api.github.com/repos/barberboy/peter-piper/forks","keys_url":"https://api.github.com/repos/barberboy/peter-piper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/barberboy/peter-piper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/barberboy/peter-piper/teams","hooks_url":"https://api.github.com/repos/barberboy/peter-piper/hooks","issue_events_url":"https://api.github.com/repos/barberboy/peter-piper/issues/events{/number}","events_url":"https://api.github.com/repos/barberboy/peter-piper/events","assignees_url":"https://api.github.com/repos/barberboy/peter-piper/assignees{/user}","branches_url":"https://api.github.com/repos/barberboy/peter-piper/branches{/branch}","tags_url":"https://api.github.com/repos/barberboy/peter-piper/tags","blobs_url":"https://api.github.com/repos/barberboy/peter-piper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/barberboy/peter-piper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/barberboy/peter-piper/git/refs{/sha}","trees_url":"https://api.github.com/repos/barberboy/peter-piper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/barberboy/peter-piper/statuses/{sha}","languages_url":"https://api.github.com/repos/barberboy/peter-piper/languages","stargazers_url":"https://api.github.com/repos/barberboy/peter-piper/stargazers","contributors_url":"https://api.github.com/repos/barberboy/peter-piper/contributors","subscribers_url":"https://api.github.com/repos/barberboy/peter-piper/subscribers","subscription_url":"https://api.github.com/repos/barberboy/peter-piper/subscription","commits_url":"https://api.github.com/repos/barberboy/peter-piper/commits{/sha}","git_commits_url":"https://api.github.com/repos/barberboy/peter-piper/git/commits{/sha}","comments_url":"https://api.github.com/repos/barberboy/peter-piper/comments{/number}","issue_comment_url":"https://api.github.com/repos/barberboy/peter-piper/issues/comments{/number}","contents_url":"https://api.github.com/repos/barberboy/peter-piper/contents/{+path}","compare_url":"https://api.github.com/repos/barberboy/peter-piper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/barberboy/peter-piper/merges","archive_url":"https://api.github.com/repos/barberboy/peter-piper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/barberboy/peter-piper/downloads","issues_url":"https://api.github.com/repos/barberboy/peter-piper/issues{/number}","pulls_url":"https://api.github.com/repos/barberboy/peter-piper/pulls{/number}","milestones_url":"https://api.github.com/repos/barberboy/peter-piper/milestones{/number}","notifications_url":"https://api.github.com/repos/barberboy/peter-piper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/barberboy/peter-piper/labels{/name}","releases_url":"https://api.github.com/repos/barberboy/peter-piper/releases{/id}","created_at":"2015-09-08T20:42:31Z","updated_at":"2015-09-08T20:42:32Z","pushed_at":"2015-09-08T20:53:06Z","git_url":"git://github.com/barberboy/peter-piper.git","ssh_url":"git@github.com:barberboy/peter-piper.git","clone_url":"https://github.com/barberboy/peter-piper.git","svn_url":"https://github.com/barberboy/peter-piper","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"unioncollege-webtech:master","ref":"master","sha":"5fd2abccab999f1bcda1c22efc3a4637d141dd2e","user":{"login":"unioncollege-webtech","id":4185215,"avatar_url":"https://avatars.githubusercontent.com/u/4185215?v=3","gravatar_id":"","url":"https://api.github.com/users/unioncollege-webtech","html_url":"https://github.com/unioncollege-webtech","followers_url":"https://api.github.com/users/unioncollege-webtech/followers","following_url":"https://api.github.com/users/unioncollege-webtech/following{/other_user}","gists_url":"https://api.github.com/users/unioncollege-webtech/gists{/gist_id}","starred_url":"https://api.github.com/users/unioncollege-webtech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unioncollege-webtech/subscriptions","organizations_url":"https://api.github.com/users/unioncollege-webtech/orgs","repos_url":"https://api.github.com/users/unioncollege-webtech/repos","events_url":"https://api.github.com/users/unioncollege-webtech/events{/privacy}","received_events_url":"https://api.github.com/users/unioncollege-webtech/received_events","type":"Organization","site_admin":false},"repo":{"id":41886584,"name":"peter-piper","full_name":"unioncollege-webtech/peter-piper","owner":{"login":"unioncollege-webtech","id":4185215,"avatar_url":"https://avatars.githubusercontent.com/u/4185215?v=3","gravatar_id":"","url":"https://api.github.com/users/unioncollege-webtech","html_url":"https://github.com/unioncollege-webtech","followers_url":"https://api.github.com/users/unioncollege-webtech/followers","following_url":"https://api.github.com/users/unioncollege-webtech/following{/other_user}","gists_url":"https://api.github.com/users/unioncollege-webtech/gists{/gist_id}","starred_url":"https://api.github.com/users/unioncollege-webtech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unioncollege-webtech/subscriptions","organizations_url":"https://api.github.com/users/unioncollege-webtech/orgs","repos_url":"https://api.github.com/users/unioncollege-webtech/repos","events_url":"https://api.github.com/users/unioncollege-webtech/events{/privacy}","received_events_url":"https://api.github.com/users/unioncollege-webtech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/unioncollege-webtech/peter-piper","description":"An exercise for inspecting strings using .length and .charAt()","fork":false,"url":"https://api.github.com/repos/unioncollege-webtech/peter-piper","forks_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/forks","keys_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/teams","hooks_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/hooks","issue_events_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/issues/events{/number}","events_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/events","assignees_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/assignees{/user}","branches_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/branches{/branch}","tags_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/tags","blobs_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/git/refs{/sha}","trees_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/statuses/{sha}","languages_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/languages","stargazers_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/stargazers","contributors_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/contributors","subscribers_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/subscribers","subscription_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/subscription","commits_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/commits{/sha}","git_commits_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/git/commits{/sha}","comments_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/comments{/number}","issue_comment_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/issues/comments{/number}","contents_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/contents/{+path}","compare_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/merges","archive_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/downloads","issues_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/issues{/number}","pulls_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/pulls{/number}","milestones_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/milestones{/number}","notifications_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/labels{/name}","releases_url":"https://api.github.com/repos/unioncollege-webtech/peter-piper/releases{/id}","created_at":"2015-09-03T22:20:56Z","updated_at":"2015-09-03T22:24:54Z","pushed_at":"2015-09-08T20:59:42Z","git_url":"git://github.com/unioncollege-webtech/peter-piper.git","ssh_url":"git@github.com:unioncollege-webtech/peter-piper.git","clone_url":"https://github.com/unioncollege-webtech/peter-piper.git","svn_url":"https://github.com/unioncollege-webtech/peter-piper","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":7,"forks":12,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/unioncollege-webtech/peter-piper/pulls/16"},"html":{"href":"https://github.com/unioncollege-webtech/peter-piper/pull/16"},"issue":{"href":"https://api.github.com/repos/unioncollege-webtech/peter-piper/issues/16"},"comments":{"href":"https://api.github.com/repos/unioncollege-webtech/peter-piper/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/unioncollege-webtech/peter-piper/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/unioncollege-webtech/peter-piper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/unioncollege-webtech/peter-piper/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/unioncollege-webtech/peter-piper/statuses/34d477fad850f3787c7f4126a14db7496921a6b2"}}}}