{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/11177","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/11177/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/11177/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/11177/events","html_url":"https://github.com/cms-sw/cmssw/pull/11177","id":105262918,"number":11177,"title":"cleanup of uninitialized reads reported by valgrind (backport of #11173 )","user":{"login":"slava77","id":4676718,"avatar_url":"https://avatars.githubusercontent.com/u/4676718?v=3","gravatar_id":"","url":"https://api.github.com/users/slava77","html_url":"https://github.com/slava77","followers_url":"https://api.github.com/users/slava77/followers","following_url":"https://api.github.com/users/slava77/following{/other_user}","gists_url":"https://api.github.com/users/slava77/gists{/gist_id}","starred_url":"https://api.github.com/users/slava77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slava77/subscriptions","organizations_url":"https://api.github.com/users/slava77/orgs","repos_url":"https://api.github.com/users/slava77/repos","events_url":"https://api.github.com/users/slava77/events{/privacy}","received_events_url":"https://api.github.com/users/slava77/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/50","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_7_4_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/50/labels","id":875803,"number":50,"title":"Next CMSSW_7_4_X","description":"","creator":{"login":"nclopezo","id":1944922,"avatar_url":"https://avatars.githubusercontent.com/u/1944922?v=3","gravatar_id":"","url":"https://api.github.com/users/nclopezo","html_url":"https://github.com/nclopezo","followers_url":"https://api.github.com/users/nclopezo/followers","following_url":"https://api.github.com/users/nclopezo/following{/other_user}","gists_url":"https://api.github.com/users/nclopezo/gists{/gist_id}","starred_url":"https://api.github.com/users/nclopezo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nclopezo/subscriptions","organizations_url":"https://api.github.com/users/nclopezo/orgs","repos_url":"https://api.github.com/users/nclopezo/repos","events_url":"https://api.github.com/users/nclopezo/events{/privacy}","received_events_url":"https://api.github.com/users/nclopezo/received_events","type":"User","site_admin":false},"open_issues":48,"closed_issues":1518,"state":"open","created_at":"2014-11-21T15:23:58Z","updated_at":"2015-09-07T20:11:08Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2015-09-07T20:07:13Z","updated_at":"2015-09-07T20:11:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/11177","html_url":"https://github.com/cms-sw/cmssw/pull/11177","diff_url":"https://github.com/cms-sw/cmssw/pull/11177.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/11177.patch"},"body":"fixing up what was supposed to be in #11176 \r\n\r\nA fraction of uninitialized value reads reported by valgrind in wflow 4.53 step3 is cleaned up.\r\nThe following summary is based on tests in 76X  with #11173 (there is no ZDC monitor change in 74X; otherwise it's the same change as in #11173 )\r\n- PileupJetIdAlgo is buggy and will need to be fixed by JME developers (I will start a separate thread for this). I have just gotten rid of uninitialized reads.\r\n    - confirmed with valgrind as fixed\r\n- B2GDQM was missing initialization of semiE_LepJetPtCut (the default uninitialized value was between zero and any other value; it now becomes 30 GeV as desired in the config). Corresponding plots will change.\r\n    - confirmed with valgrind as fixed\r\n- EcalClusterLazyToolsBase had reads beyond vector size (should be harmless from the logic)\r\n    - confirmed with valgrind as fixed\r\n- patPFMETCorrections changes appear to be cosmetic\r\n    - the invalid read in SmearedJetProducerT calling StringCutObjectSelector still remains\r\n- changes in cscdqm::StripClusterFinder are towards cleaning of uninitialized values in StripClusterFitData::height_\r\n    - cleanup is not confirmed by valgrind\r\n\r\nTested in CMSSW_7_4_X_2015-09-07-1100 /test area sign584/: \r\n    - short matrix test comparisons show changes in affected plots in DQM\r\n    - reco products monitored with fwlite script are not affected\r\n"},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/138369499","html_url":"https://github.com/cms-sw/cmssw/pull/11177#issuecomment-138369499","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/11177","id":138369499,"user":{"login":"cmsbuild","id":4170616,"avatar_url":"https://avatars.githubusercontent.com/u/4170616?v=3","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"created_at":"2015-09-07T20:11:10Z","updated_at":"2015-09-07T20:11:10Z","body":"The tests are being triggered in jenkins."}}