{"action":"created","issue":{"url":"https://api.github.com/repos/drkjam/netaddr/issues/85","labels_url":"https://api.github.com/repos/drkjam/netaddr/issues/85/labels{/name}","comments_url":"https://api.github.com/repos/drkjam/netaddr/issues/85/comments","events_url":"https://api.github.com/repos/drkjam/netaddr/issues/85/events","html_url":"https://github.com/drkjam/netaddr/issues/85","id":57920245,"number":85,"title":"IPSet missing method add(IPSet)","user":{"login":"perw07","id":7655277,"avatar_url":"https://avatars.githubusercontent.com/u/7655277?v=3","gravatar_id":"","url":"https://api.github.com/users/perw07","html_url":"https://github.com/perw07","followers_url":"https://api.github.com/users/perw07/followers","following_url":"https://api.github.com/users/perw07/following{/other_user}","gists_url":"https://api.github.com/users/perw07/gists{/gist_id}","starred_url":"https://api.github.com/users/perw07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perw07/subscriptions","organizations_url":"https://api.github.com/users/perw07/orgs","repos_url":"https://api.github.com/users/perw07/repos","events_url":"https://api.github.com/users/perw07/events{/privacy}","received_events_url":"https://api.github.com/users/perw07/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-02-17T12:50:57Z","updated_at":"2015-02-17T13:04:10Z","closed_at":null,"body":"It is possible to add objects of type IPRange as well as networks as IPNetwork or strings, but it is not possible to add objects of type IPSet to an IPSet.\r\n\r\nI think this is a lack of symmetry, I cannot use 'ipset.add(object)' for all netaddr objects.\r\n\r\nAdding support for IPSet objects to the method add() probably has no drawbacks, and helps in some cases."},"comment":{"url":"https://api.github.com/repos/drkjam/netaddr/issues/comments/74664376","html_url":"https://github.com/drkjam/netaddr/issues/85#issuecomment-74664376","issue_url":"https://api.github.com/repos/drkjam/netaddr/issues/85","id":74664376,"user":{"login":"snordhausen","id":1327310,"avatar_url":"https://avatars.githubusercontent.com/u/1327310?v=3","gravatar_id":"","url":"https://api.github.com/users/snordhausen","html_url":"https://github.com/snordhausen","followers_url":"https://api.github.com/users/snordhausen/followers","following_url":"https://api.github.com/users/snordhausen/following{/other_user}","gists_url":"https://api.github.com/users/snordhausen/gists{/gist_id}","starred_url":"https://api.github.com/users/snordhausen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snordhausen/subscriptions","organizations_url":"https://api.github.com/users/snordhausen/orgs","repos_url":"https://api.github.com/users/snordhausen/repos","events_url":"https://api.github.com/users/snordhausen/events{/privacy}","received_events_url":"https://api.github.com/users/snordhausen/received_events","type":"User","site_admin":false},"created_at":"2015-02-17T13:04:10Z","updated_at":"2015-02-17T13:04:10Z","body":"The current behavior is in line with Python's \"set\" objects:\r\n\r\n>>> a = set([1,2,3])\r\n>>> b = set([3,4,5])\r\n>>> a.add(b)\r\nTraceback (most recent call last):\r\n  File \"<stdin>\", line 1, in <module>\r\nTypeError: unhashable type: 'set'\r\n\r\nHowever, you do have a point that it is annoying to use add() for almost everything, except for IPSets where you need to use update(). I think we should implement this."}}