{"push_id":737616992,"size":212,"distinct_size":212,"ref":"refs/heads/master","head":"59efb564a6a3f9a247ae00360f8fac96c1445f52","before":"a6c61136833ecc8c6b8df00f9905df9596c2c699","commits":[{"sha":"e66911b80621bf2b53f7b33e170ad18b3741426c","author":{"email":"7ad46df05a100d2857c6f464b254895052d6c792@gmail.com","name":"Maxwe11"},"message":"Remove unnecessary IAsyncResult implementation\nRemove IAsyncResult implementation from classes which used with new Overlapped API.\nNew API doesn't require implementation of IAsyncResult.","distinct":true,"url":"https://api.github.com/repos/ekicyou/corefx/commits/e66911b80621bf2b53f7b33e170ad18b3741426c"},{"sha":"b5982a3580e171b5f1fa086b93e7862a739dac4d","author":{"email":"130698713b9cfd76dea22a554baa3074f87c0665@microsoft.com","name":"Jeremy Kuhne"},"message":"Move helper methods into common.\n\nThis facilitates further IO work around long paths.","distinct":true,"url":"https://api.github.com/repos/ekicyou/corefx/commits/b5982a3580e171b5f1fa086b93e7862a739dac4d"},{"sha":"921ca4450c1215a141f785f25206667a388a9719","author":{"email":"03c4cb6107ae99956a7681f2c97ff7104809a2bd@microsoft.com","name":"dotnet-bot"},"message":"updated changes for system.globalization","distinct":true,"url":"https://api.github.com/repos/ekicyou/corefx/commits/921ca4450c1215a141f785f25206667a388a9719"},{"sha":"4dd373d04d60b40f647cd79515f2360244c5df39","author":{"email":"cf2abec62b9a49d9713098e3d00951d2d03a804e@outlook.com","name":"Clockwork-Muse"},"message":"Add preemptive cancellation check for ToArray.","distinct":true,"url":"https://api.github.com/repos/ekicyou/corefx/commits/4dd373d04d60b40f647cd79515f2360244c5df39"},{"sha":"18ff2b087092435238b1ed4b0638b8e0348864e5","author":{"email":"94274d0b635748ad8df96c0fc4f19e1ecd3f67e2@microsoft.com","name":"Stephen Toub"},"message":"Merge pull request #2307 from Clockwork-Muse/PLINQ_ArrayCancelImmediate\n\nPLINQ - immediate cancellation of ToArray","distinct":true,"url":"https://api.github.com/repos/ekicyou/corefx/commits/18ff2b087092435238b1ed4b0638b8e0348864e5"},{"sha":"83a7a9de6da6ae09c7bbe5166606668fb01a7fa1","author":{"email":"d205a01d5cfbad634ebfb638cd9ad08a931e4fce@microsoft.com","name":"Andrew Arnott"},"message":"Add tests for bulk removal from empty collections\n\nImmutable set and list collections have distinct behaviors in their batch remove methods. These tests describe these differences and ensure that these publicly visible behaviors do not change unknowingly.","distinct":true,"url":"https://api.github.com/repos/ekicyou/corefx/commits/83a7a9de6da6ae09c7bbe5166606668fb01a7fa1"},{"sha":"ea80b29f5c312435853a27cbc20b8e3c31f5210b","author":{"email":"44f878afe53efc66b76772bd845eb65944ed8232@hackcraft.net","name":"Jon Hanna"},"message":"More informative failure from Queryable_Tests.MatchSequencePattern()\n\nWhen experimenting with #2322 for a while I hit a snag with\nQueryable_Tests.MatchSequencePattern. While this does Console.Write()\nthe error cases, that's not helpful if you don't hit the problem\nlocally, but do on the CI build.\n\nThis change makes the failure message more directly informative. It\nleaves the old assertion in place, so no flaw in this change should\nhide a bug that the test would previously have caught.","distinct":true,"url":"https://api.github.com/repos/ekicyou/corefx/commits/ea80b29f5c312435853a27cbc20b8e3c31f5210b"},{"sha":"e6fd2902cc33ee61ecd0f98768043c1b178421a4","author":{"email":"94274d0b635748ad8df96c0fc4f19e1ecd3f67e2@microsoft.com","name":"Stephen Toub"},"message":"Merge pull request #2325 from AArnott/AddBulkRemovalFromEmptyTests\n\nAdd tests for bulk removal from empty collections","distinct":true,"url":"https://api.github.com/repos/ekicyou/corefx/commits/e6fd2902cc33ee61ecd0f98768043c1b178421a4"},{"sha":"de84b99acddc7f9bd67b55dadbb3b1c61f8cdf84","author":{"email":"cf2abec62b9a49d9713098e3d00951d2d03a804e@outlook.com","name":"Clockwork-Muse"},"message":"Correct type used in constructor.","distinct":true,"url":"https://api.github.com/repos/ekicyou/corefx/commits/de84b99acddc7f9bd67b55dadbb3b1c61f8cdf84"},{"sha":"e382c23e2bfb99fef5e2889c1965e0d8835ad59f","author":{"email":"94274d0b635748ad8df96c0fc4f19e1ecd3f67e2@microsoft.com","name":"Stephen Toub"},"message":"Merge pull request #2328 from hackcraft/more_informative_match_sequence_test\n\nMore informative failure from Queryable_Tests.MatchSequencePattern()","distinct":true,"url":"https://api.github.com/repos/ekicyou/corefx/commits/e382c23e2bfb99fef5e2889c1965e0d8835ad59f"},{"sha":"ecffbeb9144ff276ec82998c24f0c44f78a251be","author":{"email":"be2a797f6c0922ce6485fe7bca291bb611f8ecd7@microsoft.com","name":"Atsushi Kanamori"},"message":"Fix System.Security.Cryptography.RSA handle leaks\n\nIssue 2229. Internal SafeHandles inside System.Security.Cryptography.RSA were ported\nfrom closed source with their ReleaseHandle() implementations commented out\nand never finished. This delta finishes them.","distinct":true,"url":"https://api.github.com/repos/ekicyou/corefx/commits/ecffbeb9144ff276ec82998c24f0c44f78a251be"},{"sha":"efff1ebc1d20283d482c99c7b1f2649ddc15a6e6","author":{"email":"94274d0b635748ad8df96c0fc4f19e1ecd3f67e2@microsoft.com","name":"stephentoub"},"message":"Update Interop.PlatformDetection.cs with FreeBSD\n\nIt's needed to avoid breaking tests for FreeBSD in one place where we do runtime detection to determine the right value to pass to sysconf to get the current page size.","distinct":true,"url":"https://api.github.com/repos/ekicyou/corefx/commits/efff1ebc1d20283d482c99c7b1f2649ddc15a6e6"},{"sha":"6f1a32cc4d969df6fa461e4507447f3ecb30f4fb","author":{"email":"94274d0b635748ad8df96c0fc4f19e1ecd3f67e2@microsoft.com","name":"stephentoub"},"message":"Add Common test helper classes for file cleanup\n\nLater one we can consolidate to these with the ones used in other test projects (and have additional test projects use these to avoid leaving straggling test files behind).","distinct":true,"url":"https://api.github.com/repos/ekicyou/corefx/commits/6f1a32cc4d969df6fa461e4507447f3ecb30f4fb"},{"sha":"42e940f6c3b57e94bf98d8b453a486f565327535","author":{"email":"94274d0b635748ad8df96c0fc4f19e1ecd3f67e2@microsoft.com","name":"stephentoub"},"message":"Fix three bugs in Unix MemoryMappedFiles implementation\n\n- When a map is created with CreateFromFile and a capacity is specified to CreateFromFile that's larger than the file using to back the map, the file's length is increased to match.  If the capacity is too large to successfully increase the length of the file, on Windows an IOException results, but on Unix we were throwing an ArgumentException.  The fix just catches the ArgumentException and translates it to an IOException.  This should be a very rare occurence, even for an exception case, and the additional overheads involved in the catch and throw-new should be immaterial.\n\n- It's possible to create a map view with a size of zero (over a map with a non-zero size).  In some of these cases, we were passing invalid data to the underlying SafeBuffer that gets created, resulting in exceptions for what should be valid cases.  The fix is to reset some values appropriately to reflect the 0-size special case (there's already a special case for this in the code, we just weren't configuring everything that needed to be configured).\n\n- When we create the backing stores for anonymous maps, we first create the object (memory or file) and then attempt to resize it.  In the case of an extremely large capacity, it's possible the resize could fail.  We weren't deterministically then cleaning up the handle that had just been recreated, instead waiting for finalization to do so.  This commit fixes that.","distinct":true,"url":"https://api.github.com/repos/ekicyou/corefx/commits/42e940f6c3b57e94bf98d8b453a486f565327535"},{"sha":"c2558f1e8da27219631e7d4f153fe2947436674d","author":{"email":"94274d0b635748ad8df96c0fc4f19e1ecd3f67e2@microsoft.com","name":"stephentoub"},"message":"Remove dead code from MemoryMappedFiles implementation\n\n- Resources that are no longer used\n- Null checks for things that can never be null\n- Code built into the Windows implementation but only used in the Unix implementation\n- Branches that can't be hit with a valid implementation","distinct":true,"url":"https://api.github.com/repos/ekicyou/corefx/commits/c2558f1e8da27219631e7d4f153fe2947436674d"},{"sha":"803180f35b82bd1cc22f0bd6b30fe54b1d171c76","author":{"email":"94274d0b635748ad8df96c0fc4f19e1ecd3f67e2@microsoft.com","name":"stephentoub"},"message":"Rewrite the MemoryMappedFiles tests\n\nThe old System.IO.MemoryMappedFiles tests had decent coverage, but were lacking in a variety of ways:\n- They were written in a legacy style that didn't take advantage of xunit capabilities, that made them difficult to augment, and that made them difficult to understand\n- They were spread out across several projects in a seemingly haphazard manner.\n- They left behind lots of temporary files\n- They caused random test failures due to conflicting map names and file names.\n- Their code coverage could have been a bit better, and they were missing coverage of some corner cases\n\nThis commit completely rewrites the tests, covering all of the old scenarios tested and more while removing 2/3rds of the code, increasing code coverage, avoiding race conditions on map and file names, cleaning up temporary files used, switching to using xunit features, and hopefully making the tests more understandable and augmentable in the future.","distinct":true,"url":"https://api.github.com/repos/ekicyou/corefx/commits/803180f35b82bd1cc22f0bd6b30fe54b1d171c76"},{"sha":"df7beee2c59aeb50fd53b1290ba81172d4b62c7b","author":{"email":"94274d0b635748ad8df96c0fc4f19e1ecd3f67e2@microsoft.com","name":"Stephen Toub"},"message":"Merge pull request #2330 from Clockwork-Muse/PLINQ_Zip\n\nPLINQ - Correct type used in constructor.","distinct":true,"url":"https://api.github.com/repos/ekicyou/corefx/commits/df7beee2c59aeb50fd53b1290ba81172d4b62c7b"},{"sha":"20dd42cc8a9291bf7506d046af8f9c7b99e39dd3","author":{"email":"be2a797f6c0922ce6485fe7bca291bb611f8ecd7@microsoft.com","name":"Atsushi Kanamori"},"message":"Return the proper success result from SafeHandle.ReleaseHandle()","distinct":true,"url":"https://api.github.com/repos/ekicyou/corefx/commits/20dd42cc8a9291bf7506d046af8f9c7b99e39dd3"},{"sha":"63f0953e9bccabc264776661851b2b754a1fccc9","author":{"email":"6242743bf193fa31dea1f035f257bb87b07dab25@microsoft.com","name":"Venkatraman Mahalingam"},"message":"Marking tests failing on Unix","distinct":true,"url":"https://api.github.com/repos/ekicyou/corefx/commits/63f0953e9bccabc264776661851b2b754a1fccc9"},{"sha":"d21ce06332afe7aba0a52491187983744c10b4a4","author":{"email":"6edc878b3eff2120a537c51f5b39d2d5264b84de@microsoft.com","name":"Ian Hays"},"message":"-System.IO.UnixFileSystem has an issue with the \"overwrite\" being interpreted backwards. I simply reversed the conditional statement to be correct. There were previously no tests to cover this possibility. Resolves #2276\n-Updated over a dozen test files to use the modern Xunit syntax.\n-Solved file-in-use concurrency issues in the altered tests. Resolves #1313, #2227\n-Tests will no longer intermittently fail.\n-Slightly improved code coverage for the FileSystem files whose tests I altered (Directory, DirectoryInfo, File, FileInfo)\n-Most tests altered now inherit from similar tests to consolidate the testing robustness into as few locations as possible. For example, Directory_GetFiles_str now inherits from Directory_GetFileSystemEntries_str since the tests for Directory_GetFiles_str were the exact same ones as in Directory_GetFileSystemEntries_str anyways.\n-All altered tests now use the System.IO.FileSystem.Tests namespace\n-Renamed the File_WriteAll_all class name/file name to File_WriteAllText.\n-I tested my changes on Windows overnight to verify that there is no more intermittent test failures. I didn't have to modify all of the files listed in #2227 to get them to pass; this concerns me but I found no way to replicate the errors I was receiving before. My guess would be that the tests in the files I didn't alter (e.g. File_WriteAll and File_ReadAll) used the same names as the tests I did alter but now that the tests I altered are changed they no longer share test file names and no longer fail as a result.","distinct":true,"url":"https://api.github.com/repos/ekicyou/corefx/commits/d21ce06332afe7aba0a52491187983744c10b4a4"}]}