{"action":"closed","number":35,"pull_request":{"url":"https://api.github.com/repos/bloomberg/blpapi-http/pulls/35","id":28126488,"html_url":"https://github.com/bloomberg/blpapi-http/pull/35","diff_url":"https://github.com/bloomberg/blpapi-http/pull/35.diff","patch_url":"https://github.com/bloomberg/blpapi-http/pull/35.patch","issue_url":"https://api.github.com/repos/bloomberg/blpapi-http/issues/35","number":35,"state":"closed","locked":false,"title":"restructure type definition files and directories","user":{"login":"ericvw","id":1284017,"avatar_url":"https://avatars.githubusercontent.com/u/1284017?v=3","gravatar_id":"","url":"https://api.github.com/users/ericvw","html_url":"https://github.com/ericvw","followers_url":"https://api.github.com/users/ericvw/followers","following_url":"https://api.github.com/users/ericvw/following{/other_user}","gists_url":"https://api.github.com/users/ericvw/gists{/gist_id}","starred_url":"https://api.github.com/users/ericvw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericvw/subscriptions","organizations_url":"https://api.github.com/users/ericvw/orgs","repos_url":"https://api.github.com/users/ericvw/repos","events_url":"https://api.github.com/users/ericvw/events{/privacy}","received_events_url":"https://api.github.com/users/ericvw/received_events","type":"User","site_admin":false},"body":"This change introduces a level of indirection for referencing type\r\ndefinitions and a convention for extending/overriding definitions\r\nprovided by the [DefinitelyTyped](http://http://definitelytyped.org/)\r\nproject.\r\n\r\nThe primary motiviations for introducing another level of indirection\r\nfor referencing type definitions are:\r\n\r\n1. Provide each `.ts` file stability for the `.d.ts` file it references.\r\n2. The subdirectory `typings`, where the stable `.d.ts` reference is\r\n   located, also serves as the directortory to place\r\n   extensions/overrides to third-party type definitions.\r\n\r\nThe consequence is that each `.ts` files only needs to reference\r\n`typings/definitions.d.ts`, which will remain stable in event of file\r\nmoves.\r\n\r\nAdditionally, overrides may be placed in the `typings` subdirectory and\r\nneed only to be referenced by `typings/definitions.d.ts`.","created_at":"2015-01-27T17:14:53Z","updated_at":"2015-02-03T22:33:56Z","closed_at":"2015-02-03T22:33:56Z","merged_at":null,"merge_commit_sha":"23c8d3d0697fcff573bc75601cce0529f62cecc6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bloomberg/blpapi-http/pulls/35/commits","review_comments_url":"https://api.github.com/repos/bloomberg/blpapi-http/pulls/35/comments","review_comment_url":"https://api.github.com/repos/bloomberg/blpapi-http/pulls/comments/{number}","comments_url":"https://api.github.com/repos/bloomberg/blpapi-http/issues/35/comments","statuses_url":"https://api.github.com/repos/bloomberg/blpapi-http/statuses/c22d8ac446e2914b52ac16d0d530bff660024438","head":{"label":"ericvw:typing-overrides","ref":"typing-overrides","sha":"c22d8ac446e2914b52ac16d0d530bff660024438","user":{"login":"ericvw","id":1284017,"avatar_url":"https://avatars.githubusercontent.com/u/1284017?v=3","gravatar_id":"","url":"https://api.github.com/users/ericvw","html_url":"https://github.com/ericvw","followers_url":"https://api.github.com/users/ericvw/followers","following_url":"https://api.github.com/users/ericvw/following{/other_user}","gists_url":"https://api.github.com/users/ericvw/gists{/gist_id}","starred_url":"https://api.github.com/users/ericvw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericvw/subscriptions","organizations_url":"https://api.github.com/users/ericvw/orgs","repos_url":"https://api.github.com/users/ericvw/repos","events_url":"https://api.github.com/users/ericvw/events{/privacy}","received_events_url":"https://api.github.com/users/ericvw/received_events","type":"User","site_admin":false},"repo":{"id":25044482,"name":"blpapi-http","full_name":"ericvw/blpapi-http","owner":{"login":"ericvw","id":1284017,"avatar_url":"https://avatars.githubusercontent.com/u/1284017?v=3","gravatar_id":"","url":"https://api.github.com/users/ericvw","html_url":"https://github.com/ericvw","followers_url":"https://api.github.com/users/ericvw/followers","following_url":"https://api.github.com/users/ericvw/following{/other_user}","gists_url":"https://api.github.com/users/ericvw/gists{/gist_id}","starred_url":"https://api.github.com/users/ericvw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericvw/subscriptions","organizations_url":"https://api.github.com/users/ericvw/orgs","repos_url":"https://api.github.com/users/ericvw/repos","events_url":"https://api.github.com/users/ericvw/events{/privacy}","received_events_url":"https://api.github.com/users/ericvw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericvw/blpapi-http","description":"HTTP wrapper for Bloomberg Open API","fork":true,"url":"https://api.github.com/repos/ericvw/blpapi-http","forks_url":"https://api.github.com/repos/ericvw/blpapi-http/forks","keys_url":"https://api.github.com/repos/ericvw/blpapi-http/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericvw/blpapi-http/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericvw/blpapi-http/teams","hooks_url":"https://api.github.com/repos/ericvw/blpapi-http/hooks","issue_events_url":"https://api.github.com/repos/ericvw/blpapi-http/issues/events{/number}","events_url":"https://api.github.com/repos/ericvw/blpapi-http/events","assignees_url":"https://api.github.com/repos/ericvw/blpapi-http/assignees{/user}","branches_url":"https://api.github.com/repos/ericvw/blpapi-http/branches{/branch}","tags_url":"https://api.github.com/repos/ericvw/blpapi-http/tags","blobs_url":"https://api.github.com/repos/ericvw/blpapi-http/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericvw/blpapi-http/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericvw/blpapi-http/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericvw/blpapi-http/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericvw/blpapi-http/statuses/{sha}","languages_url":"https://api.github.com/repos/ericvw/blpapi-http/languages","stargazers_url":"https://api.github.com/repos/ericvw/blpapi-http/stargazers","contributors_url":"https://api.github.com/repos/ericvw/blpapi-http/contributors","subscribers_url":"https://api.github.com/repos/ericvw/blpapi-http/subscribers","subscription_url":"https://api.github.com/repos/ericvw/blpapi-http/subscription","commits_url":"https://api.github.com/repos/ericvw/blpapi-http/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericvw/blpapi-http/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericvw/blpapi-http/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericvw/blpapi-http/issues/comments/{number}","contents_url":"https://api.github.com/repos/ericvw/blpapi-http/contents/{+path}","compare_url":"https://api.github.com/repos/ericvw/blpapi-http/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericvw/blpapi-http/merges","archive_url":"https://api.github.com/repos/ericvw/blpapi-http/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericvw/blpapi-http/downloads","issues_url":"https://api.github.com/repos/ericvw/blpapi-http/issues{/number}","pulls_url":"https://api.github.com/repos/ericvw/blpapi-http/pulls{/number}","milestones_url":"https://api.github.com/repos/ericvw/blpapi-http/milestones{/number}","notifications_url":"https://api.github.com/repos/ericvw/blpapi-http/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericvw/blpapi-http/labels{/name}","releases_url":"https://api.github.com/repos/ericvw/blpapi-http/releases{/id}","created_at":"2014-10-10T16:50:04Z","updated_at":"2015-01-27T04:42:15Z","pushed_at":"2015-02-03T22:33:56Z","git_url":"git://github.com/ericvw/blpapi-http.git","ssh_url":"git@github.com:ericvw/blpapi-http.git","clone_url":"https://github.com/ericvw/blpapi-http.git","svn_url":"https://github.com/ericvw/blpapi-http","homepage":null,"size":655,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"bloomberg:develop","ref":"develop","sha":"132cd354a11d45a9987011fe0c47ac13271fee0a","user":{"login":"bloomberg","id":1416818,"avatar_url":"https://avatars.githubusercontent.com/u/1416818?v=3","gravatar_id":"","url":"https://api.github.com/users/bloomberg","html_url":"https://github.com/bloomberg","followers_url":"https://api.github.com/users/bloomberg/followers","following_url":"https://api.github.com/users/bloomberg/following{/other_user}","gists_url":"https://api.github.com/users/bloomberg/gists{/gist_id}","starred_url":"https://api.github.com/users/bloomberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bloomberg/subscriptions","organizations_url":"https://api.github.com/users/bloomberg/orgs","repos_url":"https://api.github.com/users/bloomberg/repos","events_url":"https://api.github.com/users/bloomberg/events{/privacy}","received_events_url":"https://api.github.com/users/bloomberg/received_events","type":"Organization","site_admin":false},"repo":{"id":25042195,"name":"blpapi-http","full_name":"bloomberg/blpapi-http","owner":{"login":"bloomberg","id":1416818,"avatar_url":"https://avatars.githubusercontent.com/u/1416818?v=3","gravatar_id":"","url":"https://api.github.com/users/bloomberg","html_url":"https://github.com/bloomberg","followers_url":"https://api.github.com/users/bloomberg/followers","following_url":"https://api.github.com/users/bloomberg/following{/other_user}","gists_url":"https://api.github.com/users/bloomberg/gists{/gist_id}","starred_url":"https://api.github.com/users/bloomberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bloomberg/subscriptions","organizations_url":"https://api.github.com/users/bloomberg/orgs","repos_url":"https://api.github.com/users/bloomberg/repos","events_url":"https://api.github.com/users/bloomberg/events{/privacy}","received_events_url":"https://api.github.com/users/bloomberg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bloomberg/blpapi-http","description":"HTTP wrapper for Bloomberg Open API","fork":false,"url":"https://api.github.com/repos/bloomberg/blpapi-http","forks_url":"https://api.github.com/repos/bloomberg/blpapi-http/forks","keys_url":"https://api.github.com/repos/bloomberg/blpapi-http/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bloomberg/blpapi-http/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bloomberg/blpapi-http/teams","hooks_url":"https://api.github.com/repos/bloomberg/blpapi-http/hooks","issue_events_url":"https://api.github.com/repos/bloomberg/blpapi-http/issues/events{/number}","events_url":"https://api.github.com/repos/bloomberg/blpapi-http/events","assignees_url":"https://api.github.com/repos/bloomberg/blpapi-http/assignees{/user}","branches_url":"https://api.github.com/repos/bloomberg/blpapi-http/branches{/branch}","tags_url":"https://api.github.com/repos/bloomberg/blpapi-http/tags","blobs_url":"https://api.github.com/repos/bloomberg/blpapi-http/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bloomberg/blpapi-http/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bloomberg/blpapi-http/git/refs{/sha}","trees_url":"https://api.github.com/repos/bloomberg/blpapi-http/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bloomberg/blpapi-http/statuses/{sha}","languages_url":"https://api.github.com/repos/bloomberg/blpapi-http/languages","stargazers_url":"https://api.github.com/repos/bloomberg/blpapi-http/stargazers","contributors_url":"https://api.github.com/repos/bloomberg/blpapi-http/contributors","subscribers_url":"https://api.github.com/repos/bloomberg/blpapi-http/subscribers","subscription_url":"https://api.github.com/repos/bloomberg/blpapi-http/subscription","commits_url":"https://api.github.com/repos/bloomberg/blpapi-http/commits{/sha}","git_commits_url":"https://api.github.com/repos/bloomberg/blpapi-http/git/commits{/sha}","comments_url":"https://api.github.com/repos/bloomberg/blpapi-http/comments{/number}","issue_comment_url":"https://api.github.com/repos/bloomberg/blpapi-http/issues/comments/{number}","contents_url":"https://api.github.com/repos/bloomberg/blpapi-http/contents/{+path}","compare_url":"https://api.github.com/repos/bloomberg/blpapi-http/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bloomberg/blpapi-http/merges","archive_url":"https://api.github.com/repos/bloomberg/blpapi-http/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bloomberg/blpapi-http/downloads","issues_url":"https://api.github.com/repos/bloomberg/blpapi-http/issues{/number}","pulls_url":"https://api.github.com/repos/bloomberg/blpapi-http/pulls{/number}","milestones_url":"https://api.github.com/repos/bloomberg/blpapi-http/milestones{/number}","notifications_url":"https://api.github.com/repos/bloomberg/blpapi-http/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bloomberg/blpapi-http/labels{/name}","releases_url":"https://api.github.com/repos/bloomberg/blpapi-http/releases{/id}","created_at":"2014-10-10T15:45:55Z","updated_at":"2015-02-03T01:35:03Z","pushed_at":"2015-02-03T00:46:45Z","git_url":"git://github.com/bloomberg/blpapi-http.git","ssh_url":"git@github.com:bloomberg/blpapi-http.git","clone_url":"https://github.com/bloomberg/blpapi-http.git","svn_url":"https://github.com/bloomberg/blpapi-http","homepage":null,"size":972,"stargazers_count":9,"watchers_count":9,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":21,"forks":10,"open_issues":21,"watchers":9,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/bloomberg/blpapi-http/pulls/35"},"html":{"href":"https://github.com/bloomberg/blpapi-http/pull/35"},"issue":{"href":"https://api.github.com/repos/bloomberg/blpapi-http/issues/35"},"comments":{"href":"https://api.github.com/repos/bloomberg/blpapi-http/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/bloomberg/blpapi-http/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/bloomberg/blpapi-http/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/bloomberg/blpapi-http/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/bloomberg/blpapi-http/statuses/c22d8ac446e2914b52ac16d0d530bff660024438"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":8,"review_comments":10,"commits":1,"additions":26,"deletions":16,"changed_files":13}}