{"action":"closed","number":30,"pull_request":{"url":"https://api.github.com/repos/puli/manager/pulls/30","id":53945723,"html_url":"https://github.com/puli/manager/pull/30","diff_url":"https://github.com/puli/manager/pull/30.diff","patch_url":"https://github.com/puli/manager/pull/30.patch","issue_url":"https://api.github.com/repos/puli/manager/issues/30","number":30,"state":"closed","locked":false,"title":"Fixed JSON schema and schema testing","user":{"login":"webmozart","id":176399,"avatar_url":"https://avatars.githubusercontent.com/u/176399?v=3","gravatar_id":"","url":"https://api.github.com/users/webmozart","html_url":"https://github.com/webmozart","followers_url":"https://api.github.com/users/webmozart/followers","following_url":"https://api.github.com/users/webmozart/following{/other_user}","gists_url":"https://api.github.com/users/webmozart/gists{/gist_id}","starred_url":"https://api.github.com/users/webmozart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webmozart/subscriptions","organizations_url":"https://api.github.com/users/webmozart/orgs","repos_url":"https://api.github.com/users/webmozart/repos","events_url":"https://api.github.com/users/webmozart/events{/privacy}","received_events_url":"https://api.github.com/users/webmozart/received_events","type":"User","site_admin":false},"body":"The JSON schema wasn't actually used for validation in the tests of the package file serializer. The serializer currently created some invalid JSON (according to the schema), but that went undetected.\r\n\r\nThis PR fixes both validation of the schema during tests as well as inconsistencies in the serializer and the schema.","created_at":"2015-12-17T08:11:21Z","updated_at":"2015-12-17T11:02:16Z","closed_at":"2015-12-17T11:02:16Z","merged_at":"2015-12-17T11:02:16Z","merge_commit_sha":"e672dd17ff64f099c5493c8afb4b80cad52a3611","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puli/manager/pulls/30/commits","review_comments_url":"https://api.github.com/repos/puli/manager/pulls/30/comments","review_comment_url":"https://api.github.com/repos/puli/manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puli/manager/issues/30/comments","statuses_url":"https://api.github.com/repos/puli/manager/statuses/8c475b73f61932a813e9107f3adf643df3e637d3","head":{"label":"webmozart:bug-parameters","ref":"bug-parameters","sha":"8c475b73f61932a813e9107f3adf643df3e637d3","user":{"login":"webmozart","id":176399,"avatar_url":"https://avatars.githubusercontent.com/u/176399?v=3","gravatar_id":"","url":"https://api.github.com/users/webmozart","html_url":"https://github.com/webmozart","followers_url":"https://api.github.com/users/webmozart/followers","following_url":"https://api.github.com/users/webmozart/following{/other_user}","gists_url":"https://api.github.com/users/webmozart/gists{/gist_id}","starred_url":"https://api.github.com/users/webmozart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webmozart/subscriptions","organizations_url":"https://api.github.com/users/webmozart/orgs","repos_url":"https://api.github.com/users/webmozart/repos","events_url":"https://api.github.com/users/webmozart/events{/privacy}","received_events_url":"https://api.github.com/users/webmozart/received_events","type":"User","site_admin":false},"repo":{"id":45347004,"name":"manager","full_name":"webmozart/manager","owner":{"login":"webmozart","id":176399,"avatar_url":"https://avatars.githubusercontent.com/u/176399?v=3","gravatar_id":"","url":"https://api.github.com/users/webmozart","html_url":"https://github.com/webmozart","followers_url":"https://api.github.com/users/webmozart/followers","following_url":"https://api.github.com/users/webmozart/following{/other_user}","gists_url":"https://api.github.com/users/webmozart/gists{/gist_id}","starred_url":"https://api.github.com/users/webmozart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webmozart/subscriptions","organizations_url":"https://api.github.com/users/webmozart/orgs","repos_url":"https://api.github.com/users/webmozart/repos","events_url":"https://api.github.com/users/webmozart/events{/privacy}","received_events_url":"https://api.github.com/users/webmozart/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/webmozart/manager","description":"Generates Puli repositories from configured packages.","fork":true,"url":"https://api.github.com/repos/webmozart/manager","forks_url":"https://api.github.com/repos/webmozart/manager/forks","keys_url":"https://api.github.com/repos/webmozart/manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webmozart/manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webmozart/manager/teams","hooks_url":"https://api.github.com/repos/webmozart/manager/hooks","issue_events_url":"https://api.github.com/repos/webmozart/manager/issues/events{/number}","events_url":"https://api.github.com/repos/webmozart/manager/events","assignees_url":"https://api.github.com/repos/webmozart/manager/assignees{/user}","branches_url":"https://api.github.com/repos/webmozart/manager/branches{/branch}","tags_url":"https://api.github.com/repos/webmozart/manager/tags","blobs_url":"https://api.github.com/repos/webmozart/manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webmozart/manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webmozart/manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/webmozart/manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webmozart/manager/statuses/{sha}","languages_url":"https://api.github.com/repos/webmozart/manager/languages","stargazers_url":"https://api.github.com/repos/webmozart/manager/stargazers","contributors_url":"https://api.github.com/repos/webmozart/manager/contributors","subscribers_url":"https://api.github.com/repos/webmozart/manager/subscribers","subscription_url":"https://api.github.com/repos/webmozart/manager/subscription","commits_url":"https://api.github.com/repos/webmozart/manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/webmozart/manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/webmozart/manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/webmozart/manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/webmozart/manager/contents/{+path}","compare_url":"https://api.github.com/repos/webmozart/manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webmozart/manager/merges","archive_url":"https://api.github.com/repos/webmozart/manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webmozart/manager/downloads","issues_url":"https://api.github.com/repos/webmozart/manager/issues{/number}","pulls_url":"https://api.github.com/repos/webmozart/manager/pulls{/number}","milestones_url":"https://api.github.com/repos/webmozart/manager/milestones{/number}","notifications_url":"https://api.github.com/repos/webmozart/manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webmozart/manager/labels{/name}","releases_url":"https://api.github.com/repos/webmozart/manager/releases{/id}","created_at":"2015-11-01T16:01:35Z","updated_at":"2015-11-01T16:01:37Z","pushed_at":"2015-12-17T11:01:07Z","git_url":"git://github.com/webmozart/manager.git","ssh_url":"git@github.com:webmozart/manager.git","clone_url":"https://github.com/webmozart/manager.git","svn_url":"https://github.com/webmozart/manager","homepage":"http://puli.io","size":1811,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puli:master","ref":"master","sha":"812335d16628c57a1436d38075dc03c1f7f28331","user":{"login":"puli","id":9706065,"avatar_url":"https://avatars.githubusercontent.com/u/9706065?v=3","gravatar_id":"","url":"https://api.github.com/users/puli","html_url":"https://github.com/puli","followers_url":"https://api.github.com/users/puli/followers","following_url":"https://api.github.com/users/puli/following{/other_user}","gists_url":"https://api.github.com/users/puli/gists{/gist_id}","starred_url":"https://api.github.com/users/puli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puli/subscriptions","organizations_url":"https://api.github.com/users/puli/orgs","repos_url":"https://api.github.com/users/puli/repos","events_url":"https://api.github.com/users/puli/events{/privacy}","received_events_url":"https://api.github.com/users/puli/received_events","type":"Organization","site_admin":false},"repo":{"id":26802185,"name":"manager","full_name":"puli/manager","owner":{"login":"puli","id":9706065,"avatar_url":"https://avatars.githubusercontent.com/u/9706065?v=3","gravatar_id":"","url":"https://api.github.com/users/puli","html_url":"https://github.com/puli","followers_url":"https://api.github.com/users/puli/followers","following_url":"https://api.github.com/users/puli/following{/other_user}","gists_url":"https://api.github.com/users/puli/gists{/gist_id}","starred_url":"https://api.github.com/users/puli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puli/subscriptions","organizations_url":"https://api.github.com/users/puli/orgs","repos_url":"https://api.github.com/users/puli/repos","events_url":"https://api.github.com/users/puli/events{/privacy}","received_events_url":"https://api.github.com/users/puli/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puli/manager","description":"Generates Puli repositories from configured packages.","fork":false,"url":"https://api.github.com/repos/puli/manager","forks_url":"https://api.github.com/repos/puli/manager/forks","keys_url":"https://api.github.com/repos/puli/manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puli/manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puli/manager/teams","hooks_url":"https://api.github.com/repos/puli/manager/hooks","issue_events_url":"https://api.github.com/repos/puli/manager/issues/events{/number}","events_url":"https://api.github.com/repos/puli/manager/events","assignees_url":"https://api.github.com/repos/puli/manager/assignees{/user}","branches_url":"https://api.github.com/repos/puli/manager/branches{/branch}","tags_url":"https://api.github.com/repos/puli/manager/tags","blobs_url":"https://api.github.com/repos/puli/manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puli/manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puli/manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/puli/manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puli/manager/statuses/{sha}","languages_url":"https://api.github.com/repos/puli/manager/languages","stargazers_url":"https://api.github.com/repos/puli/manager/stargazers","contributors_url":"https://api.github.com/repos/puli/manager/contributors","subscribers_url":"https://api.github.com/repos/puli/manager/subscribers","subscription_url":"https://api.github.com/repos/puli/manager/subscription","commits_url":"https://api.github.com/repos/puli/manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/puli/manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/puli/manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/puli/manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/puli/manager/contents/{+path}","compare_url":"https://api.github.com/repos/puli/manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puli/manager/merges","archive_url":"https://api.github.com/repos/puli/manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puli/manager/downloads","issues_url":"https://api.github.com/repos/puli/manager/issues{/number}","pulls_url":"https://api.github.com/repos/puli/manager/pulls{/number}","milestones_url":"https://api.github.com/repos/puli/manager/milestones{/number}","notifications_url":"https://api.github.com/repos/puli/manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puli/manager/labels{/name}","releases_url":"https://api.github.com/repos/puli/manager/releases{/id}","created_at":"2014-11-18T09:42:31Z","updated_at":"2015-11-08T11:09:39Z","pushed_at":"2015-12-17T11:02:16Z","git_url":"git://github.com/puli/manager.git","ssh_url":"git@github.com:puli/manager.git","clone_url":"https://github.com/puli/manager.git","svn_url":"https://github.com/puli/manager","homepage":"http://puli.io","size":1818,"stargazers_count":54,"watchers_count":54,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":2,"forks":13,"open_issues":2,"watchers":54,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puli/manager/pulls/30"},"html":{"href":"https://github.com/puli/manager/pull/30"},"issue":{"href":"https://api.github.com/repos/puli/manager/issues/30"},"comments":{"href":"https://api.github.com/repos/puli/manager/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/puli/manager/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/puli/manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puli/manager/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/puli/manager/statuses/8c475b73f61932a813e9107f3adf643df3e637d3"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"webmozart","id":176399,"avatar_url":"https://avatars.githubusercontent.com/u/176399?v=3","gravatar_id":"","url":"https://api.github.com/users/webmozart","html_url":"https://github.com/webmozart","followers_url":"https://api.github.com/users/webmozart/followers","following_url":"https://api.github.com/users/webmozart/following{/other_user}","gists_url":"https://api.github.com/users/webmozart/gists{/gist_id}","starred_url":"https://api.github.com/users/webmozart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webmozart/subscriptions","organizations_url":"https://api.github.com/users/webmozart/orgs","repos_url":"https://api.github.com/users/webmozart/repos","events_url":"https://api.github.com/users/webmozart/events{/privacy}","received_events_url":"https://api.github.com/users/webmozart/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":44,"deletions":11,"changed_files":3}}