{"action":"created","issue":{"url":"https://api.github.com/repos/rossPatton/stylint/issues/135","labels_url":"https://api.github.com/repos/rossPatton/stylint/issues/135/labels{/name}","comments_url":"https://api.github.com/repos/rossPatton/stylint/issues/135/comments","events_url":"https://api.github.com/repos/rossPatton/stylint/issues/135/events","html_url":"https://github.com/rossPatton/stylint/issues/135","id":94339011,"number":135,"title":"Check method spec ambiguity","user":{"login":"xdissent","id":99367,"avatar_url":"https://avatars.githubusercontent.com/u/99367?v=3","gravatar_id":"","url":"https://api.github.com/users/xdissent","html_url":"https://github.com/xdissent","followers_url":"https://api.github.com/users/xdissent/followers","following_url":"https://api.github.com/users/xdissent/following{/other_user}","gists_url":"https://api.github.com/users/xdissent/gists{/gist_id}","starred_url":"https://api.github.com/users/xdissent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xdissent/subscriptions","organizations_url":"https://api.github.com/users/xdissent/orgs","repos_url":"https://api.github.com/users/xdissent/repos","events_url":"https://api.github.com/users/xdissent/events{/privacy}","received_events_url":"https://api.github.com/users/xdissent/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rossPatton/stylint/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-10T16:18:13Z","updated_at":"2015-07-15T15:46:46Z","closed_at":null,"body":"The contribution docs say checks should return `true|false` to indicate pass/fail, but in reality they must call `this.msg()` to actually add a failure. It looks like the return value is only used in tests at this point.\r\n\r\nMy question is, given a check like `none()`, should the return value be `true` if `border: none` is found **regardless of the config** (`always|never` etc)? In other words, should the config only affect error messages and *not* return value for checks that accept a config?\r\n\r\nMany of the tests manipulate `app.state.conf`, but never actually check for error messages (only return value), rendering them pretty ineffective (there's a bug in `none()` right now when config is `always` for example). If you can clear that up, I'll gladly take a pass at improving the tests and/or docs!"},"comment":{"url":"https://api.github.com/repos/rossPatton/stylint/issues/comments/121657771","html_url":"https://github.com/rossPatton/stylint/issues/135#issuecomment-121657771","issue_url":"https://api.github.com/repos/rossPatton/stylint/issues/135","id":121657771,"user":{"login":"rossPatton","id":2379901,"avatar_url":"https://avatars.githubusercontent.com/u/2379901?v=3","gravatar_id":"","url":"https://api.github.com/users/rossPatton","html_url":"https://github.com/rossPatton","followers_url":"https://api.github.com/users/rossPatton/followers","following_url":"https://api.github.com/users/rossPatton/following{/other_user}","gists_url":"https://api.github.com/users/rossPatton/gists{/gist_id}","starred_url":"https://api.github.com/users/rossPatton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rossPatton/subscriptions","organizations_url":"https://api.github.com/users/rossPatton/orgs","repos_url":"https://api.github.com/users/rossPatton/repos","events_url":"https://api.github.com/users/rossPatton/events{/privacy}","received_events_url":"https://api.github.com/users/rossPatton/received_events","type":"User","site_admin":false},"created_at":"2015-07-15T15:46:46Z","updated_at":"2015-07-15T15:46:46Z","body":"@xdissent Lemme know if you have some work on this already, I was going to just go ahead and starting adding in the error message tests"}}