{"action":"created","comment":{"url":"https://api.github.com/repos/composer/semver/pulls/comments/36241891","id":36241891,"diff_hunk":"@@ -94,28 +94,18 @@ public static function notEqualTo($version1, $version2)\n     }\n \n     /**\n-     * Evaluate $version1 $operator $version2.\n+     * Evaluates the expression: $version1 $operator $version2.\n      *\n      * @param string $version1\n-     * @param string $operator Comparison operator like \">\" or \"<=\", etc.","path":"src/Comparator.php","position":68,"original_position":68,"commit_id":"08f7e94ca5ba38cb2da11d83e1422311e175aa04","original_commit_id":"8b6d9fad239c13c55fe39148a8bcb4def9d4adf6","user":{"login":"alcohol","id":21414,"avatar_url":"https://avatars.githubusercontent.com/u/21414?v=3","gravatar_id":"","url":"https://api.github.com/users/alcohol","html_url":"https://github.com/alcohol","followers_url":"https://api.github.com/users/alcohol/followers","following_url":"https://api.github.com/users/alcohol/following{/other_user}","gists_url":"https://api.github.com/users/alcohol/gists{/gist_id}","starred_url":"https://api.github.com/users/alcohol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alcohol/subscriptions","organizations_url":"https://api.github.com/users/alcohol/orgs","repos_url":"https://api.github.com/users/alcohol/repos","events_url":"https://api.github.com/users/alcohol/events{/privacy}","received_events_url":"https://api.github.com/users/alcohol/received_events","type":"User","site_admin":false},"body":"Because it should either list all operators possible then. I would prefer to just assume the user knows what a valid operator is. Though in most cases I suspect they will use the methods that actually call `compare()` and not call `compare()` directly. The operators can be derived from the function description of all other methods.","created_at":"2015-08-04T21:06:12Z","updated_at":"2015-08-04T21:06:12Z","html_url":"https://github.com/composer/semver/pull/13#discussion_r36241891","pull_request_url":"https://api.github.com/repos/composer/semver/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/composer/semver/pulls/comments/36241891"},"html":{"href":"https://github.com/composer/semver/pull/13#discussion_r36241891"},"pull_request":{"href":"https://api.github.com/repos/composer/semver/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/composer/semver/pulls/13","id":41460680,"html_url":"https://github.com/composer/semver/pull/13","diff_url":"https://github.com/composer/semver/pull/13.diff","patch_url":"https://github.com/composer/semver/pull/13.patch","issue_url":"https://api.github.com/repos/composer/semver/issues/13","number":13,"state":"open","locked":false,"title":"WIP - Refactoring","user":{"login":"alcohol","id":21414,"avatar_url":"https://avatars.githubusercontent.com/u/21414?v=3","gravatar_id":"","url":"https://api.github.com/users/alcohol","html_url":"https://github.com/alcohol","followers_url":"https://api.github.com/users/alcohol/followers","following_url":"https://api.github.com/users/alcohol/following{/other_user}","gists_url":"https://api.github.com/users/alcohol/gists{/gist_id}","starred_url":"https://api.github.com/users/alcohol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alcohol/subscriptions","organizations_url":"https://api.github.com/users/alcohol/orgs","repos_url":"https://api.github.com/users/alcohol/repos","events_url":"https://api.github.com/users/alcohol/events{/privacy}","received_events_url":"https://api.github.com/users/alcohol/received_events","type":"User","site_admin":false},"body":"Aims to:\r\n\r\n* [x] expand code coverage\r\n* [x] clean up version parser\r\n* [x] clean up constraint classes\r\n\r\nFor the `Semver::satisfies` test I looked at [npm/node-semver](/npm/node-semver/blob/master/test/index.js). I uncommented the ones we (currently?) do not support.","created_at":"2015-08-03T12:11:32Z","updated_at":"2015-08-04T21:06:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ee9235c9718315e9395975c076bba1827f18293","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/composer/semver/pulls/13/commits","review_comments_url":"https://api.github.com/repos/composer/semver/pulls/13/comments","review_comment_url":"https://api.github.com/repos/composer/semver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/composer/semver/issues/13/comments","statuses_url":"https://api.github.com/repos/composer/semver/statuses/08f7e94ca5ba38cb2da11d83e1422311e175aa04","head":{"label":"alcohol:refactoring","ref":"refactoring","sha":"08f7e94ca5ba38cb2da11d83e1422311e175aa04","user":{"login":"alcohol","id":21414,"avatar_url":"https://avatars.githubusercontent.com/u/21414?v=3","gravatar_id":"","url":"https://api.github.com/users/alcohol","html_url":"https://github.com/alcohol","followers_url":"https://api.github.com/users/alcohol/followers","following_url":"https://api.github.com/users/alcohol/following{/other_user}","gists_url":"https://api.github.com/users/alcohol/gists{/gist_id}","starred_url":"https://api.github.com/users/alcohol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alcohol/subscriptions","organizations_url":"https://api.github.com/users/alcohol/orgs","repos_url":"https://api.github.com/users/alcohol/repos","events_url":"https://api.github.com/users/alcohol/events{/privacy}","received_events_url":"https://api.github.com/users/alcohol/received_events","type":"User","site_admin":false},"repo":{"id":39150276,"name":"semver","full_name":"alcohol/semver","owner":{"login":"alcohol","id":21414,"avatar_url":"https://avatars.githubusercontent.com/u/21414?v=3","gravatar_id":"","url":"https://api.github.com/users/alcohol","html_url":"https://github.com/alcohol","followers_url":"https://api.github.com/users/alcohol/followers","following_url":"https://api.github.com/users/alcohol/following{/other_user}","gists_url":"https://api.github.com/users/alcohol/gists{/gist_id}","starred_url":"https://api.github.com/users/alcohol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alcohol/subscriptions","organizations_url":"https://api.github.com/users/alcohol/orgs","repos_url":"https://api.github.com/users/alcohol/repos","events_url":"https://api.github.com/users/alcohol/events{/privacy}","received_events_url":"https://api.github.com/users/alcohol/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alcohol/semver","description":"Semantic versioning utilities with the addition of version constraints parsing and checking.","fork":true,"url":"https://api.github.com/repos/alcohol/semver","forks_url":"https://api.github.com/repos/alcohol/semver/forks","keys_url":"https://api.github.com/repos/alcohol/semver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alcohol/semver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alcohol/semver/teams","hooks_url":"https://api.github.com/repos/alcohol/semver/hooks","issue_events_url":"https://api.github.com/repos/alcohol/semver/issues/events{/number}","events_url":"https://api.github.com/repos/alcohol/semver/events","assignees_url":"https://api.github.com/repos/alcohol/semver/assignees{/user}","branches_url":"https://api.github.com/repos/alcohol/semver/branches{/branch}","tags_url":"https://api.github.com/repos/alcohol/semver/tags","blobs_url":"https://api.github.com/repos/alcohol/semver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alcohol/semver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alcohol/semver/git/refs{/sha}","trees_url":"https://api.github.com/repos/alcohol/semver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alcohol/semver/statuses/{sha}","languages_url":"https://api.github.com/repos/alcohol/semver/languages","stargazers_url":"https://api.github.com/repos/alcohol/semver/stargazers","contributors_url":"https://api.github.com/repos/alcohol/semver/contributors","subscribers_url":"https://api.github.com/repos/alcohol/semver/subscribers","subscription_url":"https://api.github.com/repos/alcohol/semver/subscription","commits_url":"https://api.github.com/repos/alcohol/semver/commits{/sha}","git_commits_url":"https://api.github.com/repos/alcohol/semver/git/commits{/sha}","comments_url":"https://api.github.com/repos/alcohol/semver/comments{/number}","issue_comment_url":"https://api.github.com/repos/alcohol/semver/issues/comments{/number}","contents_url":"https://api.github.com/repos/alcohol/semver/contents/{+path}","compare_url":"https://api.github.com/repos/alcohol/semver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alcohol/semver/merges","archive_url":"https://api.github.com/repos/alcohol/semver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alcohol/semver/downloads","issues_url":"https://api.github.com/repos/alcohol/semver/issues{/number}","pulls_url":"https://api.github.com/repos/alcohol/semver/pulls{/number}","milestones_url":"https://api.github.com/repos/alcohol/semver/milestones{/number}","notifications_url":"https://api.github.com/repos/alcohol/semver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alcohol/semver/labels{/name}","releases_url":"https://api.github.com/repos/alcohol/semver/releases{/id}","created_at":"2015-07-15T17:17:47Z","updated_at":"2015-07-15T17:17:48Z","pushed_at":"2015-08-04T21:03:58Z","git_url":"git://github.com/alcohol/semver.git","ssh_url":"git@github.com:alcohol/semver.git","clone_url":"https://github.com/alcohol/semver.git","svn_url":"https://github.com/alcohol/semver","homepage":null,"size":242,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"composer:master","ref":"master","sha":"f6469477aa1952f2fcbd0ab52fcc7662f1dd0173","user":{"login":"composer","id":837015,"avatar_url":"https://avatars.githubusercontent.com/u/837015?v=3","gravatar_id":"","url":"https://api.github.com/users/composer","html_url":"https://github.com/composer","followers_url":"https://api.github.com/users/composer/followers","following_url":"https://api.github.com/users/composer/following{/other_user}","gists_url":"https://api.github.com/users/composer/gists{/gist_id}","starred_url":"https://api.github.com/users/composer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/composer/subscriptions","organizations_url":"https://api.github.com/users/composer/orgs","repos_url":"https://api.github.com/users/composer/repos","events_url":"https://api.github.com/users/composer/events{/privacy}","received_events_url":"https://api.github.com/users/composer/received_events","type":"Organization","site_admin":false},"repo":{"id":39149689,"name":"semver","full_name":"composer/semver","owner":{"login":"composer","id":837015,"avatar_url":"https://avatars.githubusercontent.com/u/837015?v=3","gravatar_id":"","url":"https://api.github.com/users/composer","html_url":"https://github.com/composer","followers_url":"https://api.github.com/users/composer/followers","following_url":"https://api.github.com/users/composer/following{/other_user}","gists_url":"https://api.github.com/users/composer/gists{/gist_id}","starred_url":"https://api.github.com/users/composer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/composer/subscriptions","organizations_url":"https://api.github.com/users/composer/orgs","repos_url":"https://api.github.com/users/composer/repos","events_url":"https://api.github.com/users/composer/events{/privacy}","received_events_url":"https://api.github.com/users/composer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/composer/semver","description":"Semantic versioning utilities with the addition of version constraints parsing and checking.","fork":false,"url":"https://api.github.com/repos/composer/semver","forks_url":"https://api.github.com/repos/composer/semver/forks","keys_url":"https://api.github.com/repos/composer/semver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/composer/semver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/composer/semver/teams","hooks_url":"https://api.github.com/repos/composer/semver/hooks","issue_events_url":"https://api.github.com/repos/composer/semver/issues/events{/number}","events_url":"https://api.github.com/repos/composer/semver/events","assignees_url":"https://api.github.com/repos/composer/semver/assignees{/user}","branches_url":"https://api.github.com/repos/composer/semver/branches{/branch}","tags_url":"https://api.github.com/repos/composer/semver/tags","blobs_url":"https://api.github.com/repos/composer/semver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/composer/semver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/composer/semver/git/refs{/sha}","trees_url":"https://api.github.com/repos/composer/semver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/composer/semver/statuses/{sha}","languages_url":"https://api.github.com/repos/composer/semver/languages","stargazers_url":"https://api.github.com/repos/composer/semver/stargazers","contributors_url":"https://api.github.com/repos/composer/semver/contributors","subscribers_url":"https://api.github.com/repos/composer/semver/subscribers","subscription_url":"https://api.github.com/repos/composer/semver/subscription","commits_url":"https://api.github.com/repos/composer/semver/commits{/sha}","git_commits_url":"https://api.github.com/repos/composer/semver/git/commits{/sha}","comments_url":"https://api.github.com/repos/composer/semver/comments{/number}","issue_comment_url":"https://api.github.com/repos/composer/semver/issues/comments{/number}","contents_url":"https://api.github.com/repos/composer/semver/contents/{+path}","compare_url":"https://api.github.com/repos/composer/semver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/composer/semver/merges","archive_url":"https://api.github.com/repos/composer/semver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/composer/semver/downloads","issues_url":"https://api.github.com/repos/composer/semver/issues{/number}","pulls_url":"https://api.github.com/repos/composer/semver/pulls{/number}","milestones_url":"https://api.github.com/repos/composer/semver/milestones{/number}","notifications_url":"https://api.github.com/repos/composer/semver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/composer/semver/labels{/name}","releases_url":"https://api.github.com/repos/composer/semver/releases{/id}","created_at":"2015-07-15T17:05:25Z","updated_at":"2015-08-02T22:05:28Z","pushed_at":"2015-08-04T21:03:58Z","git_url":"git://github.com/composer/semver.git","ssh_url":"git@github.com:composer/semver.git","clone_url":"https://github.com/composer/semver.git","svn_url":"https://github.com/composer/semver","homepage":null,"size":325,"stargazers_count":66,"watchers_count":66,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":66,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/composer/semver/pulls/13"},"html":{"href":"https://github.com/composer/semver/pull/13"},"issue":{"href":"https://api.github.com/repos/composer/semver/issues/13"},"comments":{"href":"https://api.github.com/repos/composer/semver/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/composer/semver/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/composer/semver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/composer/semver/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/composer/semver/statuses/08f7e94ca5ba38cb2da11d83e1422311e175aa04"}}}}