{"action":"created","comment":{"url":"https://api.github.com/repos/simphony/simphony-framework/pulls/comments/32631410","id":32631410,"diff_hunk":"@@ -87,15 +89,18 @@ lammps:\n \tgit clone --branch r12824 --depth 1 git://git.lammps.org/lammps-ro.git src/lammps\n \t$(MAKE) -C src/lammps/src ubuntu_simple -j 2\n \tcp src/lammps/src/lmp_ubuntu_simple $(SIMPHONYENV)/bin/lammps\n+\t$(MAKE) -C src/lammps/src makeshlib -j 2\n+\t$(MAKE) -C src/lammps/src ubuntu_simple -f Makefile.shlib -j 2\n+\t(mkdir lib; cd src/lammps/python; python install.py ../../../lib $(SIMPHONYENV)/lib/python2.7/site-packages/)\n \trm -Rf src/lammps\n \t@echo\n \t@echo \"Lammps solver installed\"\n \n jyu-lb:\n \trm -Rf src/JYU-LB\n-\tgit clone --branch 0.1.0 https://github.com/simphony/JYU-LB.git src/JYU-LB\n+\tgit clone --branch master https://github.com/simphony/JYU-LB.git src/JYU-LB","path":"Makefile","position":23,"original_position":23,"commit_id":"0012609afd52230cf2551c7dd5e49a8bf85765f5","original_commit_id":"0012609afd52230cf2551c7dd5e49a8bf85765f5","user":{"login":"nathanfranklin","id":8287580,"avatar_url":"https://avatars.githubusercontent.com/u/8287580?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanfranklin","html_url":"https://github.com/nathanfranklin","followers_url":"https://api.github.com/users/nathanfranklin/followers","following_url":"https://api.github.com/users/nathanfranklin/following{/other_user}","gists_url":"https://api.github.com/users/nathanfranklin/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanfranklin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanfranklin/subscriptions","organizations_url":"https://api.github.com/users/nathanfranklin/orgs","repos_url":"https://api.github.com/users/nathanfranklin/repos","events_url":"https://api.github.com/users/nathanfranklin/events{/privacy}","received_events_url":"https://api.github.com/users/nathanfranklin/received_events","type":"User","site_admin":false},"body":"Yeah, agree.  simphony-jyulb 0.1.2 fails with JYU-LB 0.1.0.  I have created an issue at simphony/simphony-jyulb#22","created_at":"2015-06-17T14:22:26Z","updated_at":"2015-06-17T14:22:26Z","html_url":"https://github.com/simphony/simphony-framework/pull/32#discussion_r32631410","pull_request_url":"https://api.github.com/repos/simphony/simphony-framework/pulls/32","_links":{"self":{"href":"https://api.github.com/repos/simphony/simphony-framework/pulls/comments/32631410"},"html":{"href":"https://github.com/simphony/simphony-framework/pull/32#discussion_r32631410"},"pull_request":{"href":"https://api.github.com/repos/simphony/simphony-framework/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/simphony/simphony-framework/pulls/32","id":37905325,"html_url":"https://github.com/simphony/simphony-framework/pull/32","diff_url":"https://github.com/simphony/simphony-framework/pull/32.diff","patch_url":"https://github.com/simphony/simphony-framework/pull/32.patch","issue_url":"https://api.github.com/repos/simphony/simphony-framework/issues/32","number":32,"state":"open","locked":false,"title":"WIP: Add internal wrappers","user":{"login":"nathanfranklin","id":8287580,"avatar_url":"https://avatars.githubusercontent.com/u/8287580?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanfranklin","html_url":"https://github.com/nathanfranklin","followers_url":"https://api.github.com/users/nathanfranklin/followers","following_url":"https://api.github.com/users/nathanfranklin/following{/other_user}","gists_url":"https://api.github.com/users/nathanfranklin/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanfranklin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanfranklin/subscriptions","organizations_url":"https://api.github.com/users/nathanfranklin/orgs","repos_url":"https://api.github.com/users/nathanfranklin/repos","events_url":"https://api.github.com/users/nathanfranklin/events{/privacy}","received_events_url":"https://api.github.com/users/nathanfranklin/received_events","type":"User","site_admin":false},"body":"This PR adds the released INTERNAL wrappers to modeling engines.\r\n\r\n | Wrapper | Comments\r\n--- | --- | ---\r\n :heavy_check_mark:   | jyu-lb |  workaround some of the issues in simphony/simphony-jyulb#21. See commit message of 0012609afd52230cf2551c7dd5e49a8bf85765f5\r\n :heavy_check_mark:  | lammps-md |  had to alter LD_LIBRARY_PATH when running tests to that lammps.py could find the lammps library\r\n  | kratos | waiting for simphony/simphony-kratos#9\r\n   | numerrin | \r\n   | openfoam | waiting for simphony/simphony-openfoam#23\r\n","created_at":"2015-06-17T14:16:25Z","updated_at":"2015-06-17T14:22:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"077ace5ad0c99bc95aacfb49f4c7c8bc972ded34","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/simphony/simphony-framework/pulls/32/commits","review_comments_url":"https://api.github.com/repos/simphony/simphony-framework/pulls/32/comments","review_comment_url":"https://api.github.com/repos/simphony/simphony-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/simphony/simphony-framework/issues/32/comments","statuses_url":"https://api.github.com/repos/simphony/simphony-framework/statuses/0012609afd52230cf2551c7dd5e49a8bf85765f5","head":{"label":"simphony:add-internal-wrappers","ref":"add-internal-wrappers","sha":"0012609afd52230cf2551c7dd5e49a8bf85765f5","user":{"login":"simphony","id":8048249,"avatar_url":"https://avatars.githubusercontent.com/u/8048249?v=3","gravatar_id":"","url":"https://api.github.com/users/simphony","html_url":"https://github.com/simphony","followers_url":"https://api.github.com/users/simphony/followers","following_url":"https://api.github.com/users/simphony/following{/other_user}","gists_url":"https://api.github.com/users/simphony/gists{/gist_id}","starred_url":"https://api.github.com/users/simphony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simphony/subscriptions","organizations_url":"https://api.github.com/users/simphony/orgs","repos_url":"https://api.github.com/users/simphony/repos","events_url":"https://api.github.com/users/simphony/events{/privacy}","received_events_url":"https://api.github.com/users/simphony/received_events","type":"Organization","site_admin":false},"repo":{"id":31427011,"name":"simphony-framework","full_name":"simphony/simphony-framework","owner":{"login":"simphony","id":8048249,"avatar_url":"https://avatars.githubusercontent.com/u/8048249?v=3","gravatar_id":"","url":"https://api.github.com/users/simphony","html_url":"https://github.com/simphony","followers_url":"https://api.github.com/users/simphony/followers","following_url":"https://api.github.com/users/simphony/following{/other_user}","gists_url":"https://api.github.com/users/simphony/gists{/gist_id}","starred_url":"https://api.github.com/users/simphony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simphony/subscriptions","organizations_url":"https://api.github.com/users/simphony/orgs","repos_url":"https://api.github.com/users/simphony/repos","events_url":"https://api.github.com/users/simphony/events{/privacy}","received_events_url":"https://api.github.com/users/simphony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/simphony/simphony-framework","description":"A meta-repository to simplify setup of the SimPhoNy toolset.","fork":false,"url":"https://api.github.com/repos/simphony/simphony-framework","forks_url":"https://api.github.com/repos/simphony/simphony-framework/forks","keys_url":"https://api.github.com/repos/simphony/simphony-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simphony/simphony-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simphony/simphony-framework/teams","hooks_url":"https://api.github.com/repos/simphony/simphony-framework/hooks","issue_events_url":"https://api.github.com/repos/simphony/simphony-framework/issues/events{/number}","events_url":"https://api.github.com/repos/simphony/simphony-framework/events","assignees_url":"https://api.github.com/repos/simphony/simphony-framework/assignees{/user}","branches_url":"https://api.github.com/repos/simphony/simphony-framework/branches{/branch}","tags_url":"https://api.github.com/repos/simphony/simphony-framework/tags","blobs_url":"https://api.github.com/repos/simphony/simphony-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simphony/simphony-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simphony/simphony-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/simphony/simphony-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simphony/simphony-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/simphony/simphony-framework/languages","stargazers_url":"https://api.github.com/repos/simphony/simphony-framework/stargazers","contributors_url":"https://api.github.com/repos/simphony/simphony-framework/contributors","subscribers_url":"https://api.github.com/repos/simphony/simphony-framework/subscribers","subscription_url":"https://api.github.com/repos/simphony/simphony-framework/subscription","commits_url":"https://api.github.com/repos/simphony/simphony-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/simphony/simphony-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/simphony/simphony-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/simphony/simphony-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/simphony/simphony-framework/contents/{+path}","compare_url":"https://api.github.com/repos/simphony/simphony-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simphony/simphony-framework/merges","archive_url":"https://api.github.com/repos/simphony/simphony-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simphony/simphony-framework/downloads","issues_url":"https://api.github.com/repos/simphony/simphony-framework/issues{/number}","pulls_url":"https://api.github.com/repos/simphony/simphony-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/simphony/simphony-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/simphony/simphony-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simphony/simphony-framework/labels{/name}","releases_url":"https://api.github.com/repos/simphony/simphony-framework/releases{/id}","created_at":"2015-02-27T15:58:50Z","updated_at":"2015-05-20T22:01:06Z","pushed_at":"2015-06-17T14:16:25Z","git_url":"git://github.com/simphony/simphony-framework.git","ssh_url":"git@github.com:simphony/simphony-framework.git","clone_url":"https://github.com/simphony/simphony-framework.git","svn_url":"https://github.com/simphony/simphony-framework","homepage":"","size":672,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"simphony:update-openfoam-plugin","ref":"update-openfoam-plugin","sha":"ee1aabe826dc67407ae7fbc316e0eb505b20674b","user":{"login":"simphony","id":8048249,"avatar_url":"https://avatars.githubusercontent.com/u/8048249?v=3","gravatar_id":"","url":"https://api.github.com/users/simphony","html_url":"https://github.com/simphony","followers_url":"https://api.github.com/users/simphony/followers","following_url":"https://api.github.com/users/simphony/following{/other_user}","gists_url":"https://api.github.com/users/simphony/gists{/gist_id}","starred_url":"https://api.github.com/users/simphony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simphony/subscriptions","organizations_url":"https://api.github.com/users/simphony/orgs","repos_url":"https://api.github.com/users/simphony/repos","events_url":"https://api.github.com/users/simphony/events{/privacy}","received_events_url":"https://api.github.com/users/simphony/received_events","type":"Organization","site_admin":false},"repo":{"id":31427011,"name":"simphony-framework","full_name":"simphony/simphony-framework","owner":{"login":"simphony","id":8048249,"avatar_url":"https://avatars.githubusercontent.com/u/8048249?v=3","gravatar_id":"","url":"https://api.github.com/users/simphony","html_url":"https://github.com/simphony","followers_url":"https://api.github.com/users/simphony/followers","following_url":"https://api.github.com/users/simphony/following{/other_user}","gists_url":"https://api.github.com/users/simphony/gists{/gist_id}","starred_url":"https://api.github.com/users/simphony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simphony/subscriptions","organizations_url":"https://api.github.com/users/simphony/orgs","repos_url":"https://api.github.com/users/simphony/repos","events_url":"https://api.github.com/users/simphony/events{/privacy}","received_events_url":"https://api.github.com/users/simphony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/simphony/simphony-framework","description":"A meta-repository to simplify setup of the SimPhoNy toolset.","fork":false,"url":"https://api.github.com/repos/simphony/simphony-framework","forks_url":"https://api.github.com/repos/simphony/simphony-framework/forks","keys_url":"https://api.github.com/repos/simphony/simphony-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simphony/simphony-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simphony/simphony-framework/teams","hooks_url":"https://api.github.com/repos/simphony/simphony-framework/hooks","issue_events_url":"https://api.github.com/repos/simphony/simphony-framework/issues/events{/number}","events_url":"https://api.github.com/repos/simphony/simphony-framework/events","assignees_url":"https://api.github.com/repos/simphony/simphony-framework/assignees{/user}","branches_url":"https://api.github.com/repos/simphony/simphony-framework/branches{/branch}","tags_url":"https://api.github.com/repos/simphony/simphony-framework/tags","blobs_url":"https://api.github.com/repos/simphony/simphony-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simphony/simphony-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simphony/simphony-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/simphony/simphony-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simphony/simphony-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/simphony/simphony-framework/languages","stargazers_url":"https://api.github.com/repos/simphony/simphony-framework/stargazers","contributors_url":"https://api.github.com/repos/simphony/simphony-framework/contributors","subscribers_url":"https://api.github.com/repos/simphony/simphony-framework/subscribers","subscription_url":"https://api.github.com/repos/simphony/simphony-framework/subscription","commits_url":"https://api.github.com/repos/simphony/simphony-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/simphony/simphony-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/simphony/simphony-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/simphony/simphony-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/simphony/simphony-framework/contents/{+path}","compare_url":"https://api.github.com/repos/simphony/simphony-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simphony/simphony-framework/merges","archive_url":"https://api.github.com/repos/simphony/simphony-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simphony/simphony-framework/downloads","issues_url":"https://api.github.com/repos/simphony/simphony-framework/issues{/number}","pulls_url":"https://api.github.com/repos/simphony/simphony-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/simphony/simphony-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/simphony/simphony-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simphony/simphony-framework/labels{/name}","releases_url":"https://api.github.com/repos/simphony/simphony-framework/releases{/id}","created_at":"2015-02-27T15:58:50Z","updated_at":"2015-05-20T22:01:06Z","pushed_at":"2015-06-17T14:16:25Z","git_url":"git://github.com/simphony/simphony-framework.git","ssh_url":"git@github.com:simphony/simphony-framework.git","clone_url":"https://github.com/simphony/simphony-framework.git","svn_url":"https://github.com/simphony/simphony-framework","homepage":"","size":672,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/simphony/simphony-framework/pulls/32"},"html":{"href":"https://github.com/simphony/simphony-framework/pull/32"},"issue":{"href":"https://api.github.com/repos/simphony/simphony-framework/issues/32"},"comments":{"href":"https://api.github.com/repos/simphony/simphony-framework/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/simphony/simphony-framework/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/simphony/simphony-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/simphony/simphony-framework/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/simphony/simphony-framework/statuses/0012609afd52230cf2551c7dd5e49a8bf85765f5"}}}}