{"action":"created","comment":{"url":"https://api.github.com/repos/BVLC/caffe/pulls/comments/36476501","id":36476501,"diff_hunk":"@@ -129,6 +129,27 @@ class AdaGradSolver : public SGDSolver<Dtype> {\n };\n \n template <typename Dtype>\n+class AdaDeltaSolver : public SGDSolver<Dtype> {\n+ public:\n+  explicit AdaDeltaSolver(const SolverParameter& param)\n+      : SGDSolver<Dtype>(param) { PreSolve(); constructor_sanity_check(); }\n+  explicit AdaDeltaSolver(const string& param_file)\n+      : SGDSolver<Dtype>(param_file) { PreSolve(); constructor_sanity_check(); }\n+\n+ protected:\n+  virtual void PreSolve();\n+  virtual void ComputeUpdateValue(int param_id, Dtype rate);\n+  void constructor_sanity_check() {\n+    CHECK_EQ(0, this->param_.base_lr())\n+        << \"Learning rate cannot be used with AdaDelta.\";\n+    CHECK_EQ(\"\", this->param_.lr_policy())\n+        << \"Learning rate policy cannot be applied to AdaDelta.\";\n+  }","path":"include/caffe/solver.hpp","position":29,"original_position":29,"commit_id":"ea043e492b91131ca164baf8d2dc7fa3f9083fdc","original_commit_id":"ea043e492b91131ca164baf8d2dc7fa3f9083fdc","user":{"login":"ronghanghu","id":6997335,"avatar_url":"https://avatars.githubusercontent.com/u/6997335?v=3","gravatar_id":"","url":"https://api.github.com/users/ronghanghu","html_url":"https://github.com/ronghanghu","followers_url":"https://api.github.com/users/ronghanghu/followers","following_url":"https://api.github.com/users/ronghanghu/following{/other_user}","gists_url":"https://api.github.com/users/ronghanghu/gists{/gist_id}","starred_url":"https://api.github.com/users/ronghanghu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronghanghu/subscriptions","organizations_url":"https://api.github.com/users/ronghanghu/orgs","repos_url":"https://api.github.com/users/ronghanghu/repos","events_url":"https://api.github.com/users/ronghanghu/events{/privacy}","received_events_url":"https://api.github.com/users/ronghanghu/received_events","type":"User","site_admin":false},"body":"Let's still keep the learning rate policy as discussed.","created_at":"2015-08-06T23:02:00Z","updated_at":"2015-08-06T23:02:00Z","html_url":"https://github.com/BVLC/caffe/pull/2782#discussion_r36476501","pull_request_url":"https://api.github.com/repos/BVLC/caffe/pulls/2782","_links":{"self":{"href":"https://api.github.com/repos/BVLC/caffe/pulls/comments/36476501"},"html":{"href":"https://github.com/BVLC/caffe/pull/2782#discussion_r36476501"},"pull_request":{"href":"https://api.github.com/repos/BVLC/caffe/pulls/2782"}}},"pull_request":{"url":"https://api.github.com/repos/BVLC/caffe/pulls/2782","id":40294984,"html_url":"https://github.com/BVLC/caffe/pull/2782","diff_url":"https://github.com/BVLC/caffe/pull/2782.diff","patch_url":"https://github.com/BVLC/caffe/pull/2782.patch","issue_url":"https://api.github.com/repos/BVLC/caffe/issues/2782","number":2782,"state":"open","locked":false,"title":"AdaDelta Solver (v3)","user":{"login":"matthiasplappert","id":124243,"avatar_url":"https://avatars.githubusercontent.com/u/124243?v=3","gravatar_id":"","url":"https://api.github.com/users/matthiasplappert","html_url":"https://github.com/matthiasplappert","followers_url":"https://api.github.com/users/matthiasplappert/followers","following_url":"https://api.github.com/users/matthiasplappert/following{/other_user}","gists_url":"https://api.github.com/users/matthiasplappert/gists{/gist_id}","starred_url":"https://api.github.com/users/matthiasplappert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthiasplappert/subscriptions","organizations_url":"https://api.github.com/users/matthiasplappert/orgs","repos_url":"https://api.github.com/users/matthiasplappert/repos","events_url":"https://api.github.com/users/matthiasplappert/events{/privacy}","received_events_url":"https://api.github.com/users/matthiasplappert/received_events","type":"User","site_admin":false},"body":"Picked up @kevinbache's branch (https://github.com/BVLC/caffe/pull/2204), merged it with master, resolved merge conflicts and fixed a couple of issues due to API changes. All tests pass.\r\n\r\nHowever, I need input on one change, please see comment directly in the diff.","created_at":"2015-07-18T16:55:29Z","updated_at":"2015-08-06T23:02:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad392b8c03c37365eaf4c97c8a02a10ef20c7fbb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/BVLC/caffe/pulls/2782/commits","review_comments_url":"https://api.github.com/repos/BVLC/caffe/pulls/2782/comments","review_comment_url":"https://api.github.com/repos/BVLC/caffe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BVLC/caffe/issues/2782/comments","statuses_url":"https://api.github.com/repos/BVLC/caffe/statuses/ea043e492b91131ca164baf8d2dc7fa3f9083fdc","head":{"label":"matthiasplappert:adadelta","ref":"adadelta","sha":"ea043e492b91131ca164baf8d2dc7fa3f9083fdc","user":{"login":"matthiasplappert","id":124243,"avatar_url":"https://avatars.githubusercontent.com/u/124243?v=3","gravatar_id":"","url":"https://api.github.com/users/matthiasplappert","html_url":"https://github.com/matthiasplappert","followers_url":"https://api.github.com/users/matthiasplappert/followers","following_url":"https://api.github.com/users/matthiasplappert/following{/other_user}","gists_url":"https://api.github.com/users/matthiasplappert/gists{/gist_id}","starred_url":"https://api.github.com/users/matthiasplappert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthiasplappert/subscriptions","organizations_url":"https://api.github.com/users/matthiasplappert/orgs","repos_url":"https://api.github.com/users/matthiasplappert/repos","events_url":"https://api.github.com/users/matthiasplappert/events{/privacy}","received_events_url":"https://api.github.com/users/matthiasplappert/received_events","type":"User","site_admin":false},"repo":{"id":39304583,"name":"caffe","full_name":"matthiasplappert/caffe","owner":{"login":"matthiasplappert","id":124243,"avatar_url":"https://avatars.githubusercontent.com/u/124243?v=3","gravatar_id":"","url":"https://api.github.com/users/matthiasplappert","html_url":"https://github.com/matthiasplappert","followers_url":"https://api.github.com/users/matthiasplappert/followers","following_url":"https://api.github.com/users/matthiasplappert/following{/other_user}","gists_url":"https://api.github.com/users/matthiasplappert/gists{/gist_id}","starred_url":"https://api.github.com/users/matthiasplappert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthiasplappert/subscriptions","organizations_url":"https://api.github.com/users/matthiasplappert/orgs","repos_url":"https://api.github.com/users/matthiasplappert/repos","events_url":"https://api.github.com/users/matthiasplappert/events{/privacy}","received_events_url":"https://api.github.com/users/matthiasplappert/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matthiasplappert/caffe","description":"Caffe: a fast open framework for deep learning.","fork":true,"url":"https://api.github.com/repos/matthiasplappert/caffe","forks_url":"https://api.github.com/repos/matthiasplappert/caffe/forks","keys_url":"https://api.github.com/repos/matthiasplappert/caffe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthiasplappert/caffe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthiasplappert/caffe/teams","hooks_url":"https://api.github.com/repos/matthiasplappert/caffe/hooks","issue_events_url":"https://api.github.com/repos/matthiasplappert/caffe/issues/events{/number}","events_url":"https://api.github.com/repos/matthiasplappert/caffe/events","assignees_url":"https://api.github.com/repos/matthiasplappert/caffe/assignees{/user}","branches_url":"https://api.github.com/repos/matthiasplappert/caffe/branches{/branch}","tags_url":"https://api.github.com/repos/matthiasplappert/caffe/tags","blobs_url":"https://api.github.com/repos/matthiasplappert/caffe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthiasplappert/caffe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthiasplappert/caffe/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthiasplappert/caffe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthiasplappert/caffe/statuses/{sha}","languages_url":"https://api.github.com/repos/matthiasplappert/caffe/languages","stargazers_url":"https://api.github.com/repos/matthiasplappert/caffe/stargazers","contributors_url":"https://api.github.com/repos/matthiasplappert/caffe/contributors","subscribers_url":"https://api.github.com/repos/matthiasplappert/caffe/subscribers","subscription_url":"https://api.github.com/repos/matthiasplappert/caffe/subscription","commits_url":"https://api.github.com/repos/matthiasplappert/caffe/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthiasplappert/caffe/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthiasplappert/caffe/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthiasplappert/caffe/issues/comments{/number}","contents_url":"https://api.github.com/repos/matthiasplappert/caffe/contents/{+path}","compare_url":"https://api.github.com/repos/matthiasplappert/caffe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthiasplappert/caffe/merges","archive_url":"https://api.github.com/repos/matthiasplappert/caffe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthiasplappert/caffe/downloads","issues_url":"https://api.github.com/repos/matthiasplappert/caffe/issues{/number}","pulls_url":"https://api.github.com/repos/matthiasplappert/caffe/pulls{/number}","milestones_url":"https://api.github.com/repos/matthiasplappert/caffe/milestones{/number}","notifications_url":"https://api.github.com/repos/matthiasplappert/caffe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthiasplappert/caffe/labels{/name}","releases_url":"https://api.github.com/repos/matthiasplappert/caffe/releases{/id}","created_at":"2015-07-18T16:21:50Z","updated_at":"2015-07-18T16:21:52Z","pushed_at":"2015-07-22T16:21:36Z","git_url":"git://github.com/matthiasplappert/caffe.git","ssh_url":"git@github.com:matthiasplappert/caffe.git","clone_url":"https://github.com/matthiasplappert/caffe.git","svn_url":"https://github.com/matthiasplappert/caffe","homepage":"http://caffe.berkeleyvision.org/","size":37499,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BVLC:master","ref":"master","sha":"6d92d8fcfe0eea9495ffbc326256ec5b70c3eed1","user":{"login":"BVLC","id":6182163,"avatar_url":"https://avatars.githubusercontent.com/u/6182163?v=3","gravatar_id":"","url":"https://api.github.com/users/BVLC","html_url":"https://github.com/BVLC","followers_url":"https://api.github.com/users/BVLC/followers","following_url":"https://api.github.com/users/BVLC/following{/other_user}","gists_url":"https://api.github.com/users/BVLC/gists{/gist_id}","starred_url":"https://api.github.com/users/BVLC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BVLC/subscriptions","organizations_url":"https://api.github.com/users/BVLC/orgs","repos_url":"https://api.github.com/users/BVLC/repos","events_url":"https://api.github.com/users/BVLC/events{/privacy}","received_events_url":"https://api.github.com/users/BVLC/received_events","type":"Organization","site_admin":false},"repo":{"id":12791642,"name":"caffe","full_name":"BVLC/caffe","owner":{"login":"BVLC","id":6182163,"avatar_url":"https://avatars.githubusercontent.com/u/6182163?v=3","gravatar_id":"","url":"https://api.github.com/users/BVLC","html_url":"https://github.com/BVLC","followers_url":"https://api.github.com/users/BVLC/followers","following_url":"https://api.github.com/users/BVLC/following{/other_user}","gists_url":"https://api.github.com/users/BVLC/gists{/gist_id}","starred_url":"https://api.github.com/users/BVLC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BVLC/subscriptions","organizations_url":"https://api.github.com/users/BVLC/orgs","repos_url":"https://api.github.com/users/BVLC/repos","events_url":"https://api.github.com/users/BVLC/events{/privacy}","received_events_url":"https://api.github.com/users/BVLC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BVLC/caffe","description":"Caffe: a fast open framework for deep learning.","fork":false,"url":"https://api.github.com/repos/BVLC/caffe","forks_url":"https://api.github.com/repos/BVLC/caffe/forks","keys_url":"https://api.github.com/repos/BVLC/caffe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BVLC/caffe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BVLC/caffe/teams","hooks_url":"https://api.github.com/repos/BVLC/caffe/hooks","issue_events_url":"https://api.github.com/repos/BVLC/caffe/issues/events{/number}","events_url":"https://api.github.com/repos/BVLC/caffe/events","assignees_url":"https://api.github.com/repos/BVLC/caffe/assignees{/user}","branches_url":"https://api.github.com/repos/BVLC/caffe/branches{/branch}","tags_url":"https://api.github.com/repos/BVLC/caffe/tags","blobs_url":"https://api.github.com/repos/BVLC/caffe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BVLC/caffe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BVLC/caffe/git/refs{/sha}","trees_url":"https://api.github.com/repos/BVLC/caffe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BVLC/caffe/statuses/{sha}","languages_url":"https://api.github.com/repos/BVLC/caffe/languages","stargazers_url":"https://api.github.com/repos/BVLC/caffe/stargazers","contributors_url":"https://api.github.com/repos/BVLC/caffe/contributors","subscribers_url":"https://api.github.com/repos/BVLC/caffe/subscribers","subscription_url":"https://api.github.com/repos/BVLC/caffe/subscription","commits_url":"https://api.github.com/repos/BVLC/caffe/commits{/sha}","git_commits_url":"https://api.github.com/repos/BVLC/caffe/git/commits{/sha}","comments_url":"https://api.github.com/repos/BVLC/caffe/comments{/number}","issue_comment_url":"https://api.github.com/repos/BVLC/caffe/issues/comments{/number}","contents_url":"https://api.github.com/repos/BVLC/caffe/contents/{+path}","compare_url":"https://api.github.com/repos/BVLC/caffe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BVLC/caffe/merges","archive_url":"https://api.github.com/repos/BVLC/caffe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BVLC/caffe/downloads","issues_url":"https://api.github.com/repos/BVLC/caffe/issues{/number}","pulls_url":"https://api.github.com/repos/BVLC/caffe/pulls{/number}","milestones_url":"https://api.github.com/repos/BVLC/caffe/milestones{/number}","notifications_url":"https://api.github.com/repos/BVLC/caffe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BVLC/caffe/labels{/name}","releases_url":"https://api.github.com/repos/BVLC/caffe/releases{/id}","created_at":"2013-09-12T18:39:48Z","updated_at":"2015-08-06T21:39:37Z","pushed_at":"2015-08-06T22:23:38Z","git_url":"git://github.com/BVLC/caffe.git","ssh_url":"git@github.com:BVLC/caffe.git","clone_url":"https://github.com/BVLC/caffe.git","svn_url":"https://github.com/BVLC/caffe","homepage":"http://caffe.berkeleyvision.org/","size":66526,"stargazers_count":5445,"watchers_count":5445,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2993,"mirror_url":null,"open_issues_count":363,"forks":2993,"open_issues":363,"watchers":5445,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BVLC/caffe/pulls/2782"},"html":{"href":"https://github.com/BVLC/caffe/pull/2782"},"issue":{"href":"https://api.github.com/repos/BVLC/caffe/issues/2782"},"comments":{"href":"https://api.github.com/repos/BVLC/caffe/issues/2782/comments"},"review_comments":{"href":"https://api.github.com/repos/BVLC/caffe/pulls/2782/comments"},"review_comment":{"href":"https://api.github.com/repos/BVLC/caffe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BVLC/caffe/pulls/2782/commits"},"statuses":{"href":"https://api.github.com/repos/BVLC/caffe/statuses/ea043e492b91131ca164baf8d2dc7fa3f9083fdc"}}}}