{"action":"created","comment":{"url":"https://api.github.com/repos/uber/ringpop-go/pulls/comments/46431455","id":46431455,"diff_hunk":"@@ -0,0 +1,136 @@\n+// Copyright (c) 2015 Uber Technologies, Inc.\n+//\n+// Permission is hereby granted, free of charge, to any person obtaining a copy\n+// of this software and associated documentation files (the \"Software\"), to deal\n+// in the Software without restriction, including without limitation the rights\n+// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell\n+// copies of the Software, and to permit persons to whom the Software is\n+// furnished to do so, subject to the following conditions:\n+//\n+// The above copyright notice and this permission notice shall be included in\n+// all copies or substantial portions of the Software.\n+//\n+// THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\n+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\n+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE\n+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER\n+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,\n+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN\n+// THE SOFTWARE.\n+\n+package ringpop\n+\n+import (\n+\t\"io/ioutil\"\n+\n+\t\"github.com/Sirupsen/logrus\"\n+\tlog \"github.com/uber-common/bark\"\n+\t\"github.com/uber/ringpop-go/shared\"\n+)\n+\n+type Configuration struct {\n+\t// App is the name used to uniquely identify members of the same ring.\n+\t// Members will only talk to other members with the same app name. Note\n+\t// that App is taken as an argument of the Ringpop constructor and not a\n+\t// configuration option. This is to prevent accidental misconfiguration.\n+\tApp string\n+\t// ???","path":"options.go","position":37,"original_position":37,"commit_id":"4b9e64fe4fbc3e46b13277bb5d8829260c4e4551","original_commit_id":"4b9e64fe4fbc3e46b13277bb5d8829260c4e4551","user":{"login":"jwolski","id":16902,"avatar_url":"https://avatars.githubusercontent.com/u/16902?v=3","gravatar_id":"","url":"https://api.github.com/users/jwolski","html_url":"https://github.com/jwolski","followers_url":"https://api.github.com/users/jwolski/followers","following_url":"https://api.github.com/users/jwolski/following{/other_user}","gists_url":"https://api.github.com/users/jwolski/gists{/gist_id}","starred_url":"https://api.github.com/users/jwolski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwolski/subscriptions","organizations_url":"https://api.github.com/users/jwolski/orgs","repos_url":"https://api.github.com/users/jwolski/repos","events_url":"https://api.github.com/users/jwolski/events{/privacy}","received_events_url":"https://api.github.com/users/jwolski/received_events","type":"User","site_admin":false},"body":"??? = The number of times a Ringpop node is hashed and added to the hash ring to given better spread/distribution around the ring.","created_at":"2015-12-02T15:53:48Z","updated_at":"2015-12-02T15:53:48Z","html_url":"https://github.com/uber/ringpop-go/pull/33#discussion_r46431455","pull_request_url":"https://api.github.com/repos/uber/ringpop-go/pulls/33","_links":{"self":{"href":"https://api.github.com/repos/uber/ringpop-go/pulls/comments/46431455"},"html":{"href":"https://github.com/uber/ringpop-go/pull/33#discussion_r46431455"},"pull_request":{"href":"https://api.github.com/repos/uber/ringpop-go/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/uber/ringpop-go/pulls/33","id":52409693,"html_url":"https://github.com/uber/ringpop-go/pull/33","diff_url":"https://github.com/uber/ringpop-go/pull/33.diff","patch_url":"https://github.com/uber/ringpop-go/pull/33.patch","issue_url":"https://api.github.com/repos/uber/ringpop-go/issues/33","number":33,"state":"open","locked":false,"title":"Change options pattern for Ringpop constructor (WIP)","user":{"login":"dansimau","id":203031,"avatar_url":"https://avatars.githubusercontent.com/u/203031?v=3","gravatar_id":"","url":"https://api.github.com/users/dansimau","html_url":"https://github.com/dansimau","followers_url":"https://api.github.com/users/dansimau/followers","following_url":"https://api.github.com/users/dansimau/following{/other_user}","gists_url":"https://api.github.com/users/dansimau/gists{/gist_id}","starred_url":"https://api.github.com/users/dansimau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dansimau/subscriptions","organizations_url":"https://api.github.com/users/dansimau/orgs","repos_url":"https://api.github.com/users/dansimau/repos","events_url":"https://api.github.com/users/dansimau/events{/privacy}","received_events_url":"https://api.github.com/users/dansimau/received_events","type":"User","site_admin":false},"body":"This is a breaking change which makes future options changes easier.\r\n\r\nInstead of taking constructor options as arguments (or in a struct) we\r\nuse a modifier pattern, where each option is a function which modifies\r\nthe object being created.\r\n\r\nThis allows certain options to be ... optional.\r\n\r\nThis change is to support a future change which will make the \"address\"\r\nargument optional in the constructor.\r\n\r\nTests to follow shortly.\r\n\r\n@uber/ringpop","created_at":"2015-12-02T15:26:37Z","updated_at":"2015-12-02T15:53:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9057198429e48556356f112a0ae8beaf607b52a6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/uber/ringpop-go/pulls/33/commits","review_comments_url":"https://api.github.com/repos/uber/ringpop-go/pulls/33/comments","review_comment_url":"https://api.github.com/repos/uber/ringpop-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/ringpop-go/issues/33/comments","statuses_url":"https://api.github.com/repos/uber/ringpop-go/statuses/4b9e64fe4fbc3e46b13277bb5d8829260c4e4551","head":{"label":"uber:options","ref":"options","sha":"4b9e64fe4fbc3e46b13277bb5d8829260c4e4551","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":36959143,"name":"ringpop-go","full_name":"uber/ringpop-go","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/ringpop-go","description":"Scalable, fault-tolerant application-layer sharding for Go applications","fork":false,"url":"https://api.github.com/repos/uber/ringpop-go","forks_url":"https://api.github.com/repos/uber/ringpop-go/forks","keys_url":"https://api.github.com/repos/uber/ringpop-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/ringpop-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/ringpop-go/teams","hooks_url":"https://api.github.com/repos/uber/ringpop-go/hooks","issue_events_url":"https://api.github.com/repos/uber/ringpop-go/issues/events{/number}","events_url":"https://api.github.com/repos/uber/ringpop-go/events","assignees_url":"https://api.github.com/repos/uber/ringpop-go/assignees{/user}","branches_url":"https://api.github.com/repos/uber/ringpop-go/branches{/branch}","tags_url":"https://api.github.com/repos/uber/ringpop-go/tags","blobs_url":"https://api.github.com/repos/uber/ringpop-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/ringpop-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/ringpop-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/ringpop-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/ringpop-go/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/ringpop-go/languages","stargazers_url":"https://api.github.com/repos/uber/ringpop-go/stargazers","contributors_url":"https://api.github.com/repos/uber/ringpop-go/contributors","subscribers_url":"https://api.github.com/repos/uber/ringpop-go/subscribers","subscription_url":"https://api.github.com/repos/uber/ringpop-go/subscription","commits_url":"https://api.github.com/repos/uber/ringpop-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/ringpop-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/ringpop-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/ringpop-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/ringpop-go/contents/{+path}","compare_url":"https://api.github.com/repos/uber/ringpop-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/ringpop-go/merges","archive_url":"https://api.github.com/repos/uber/ringpop-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/ringpop-go/downloads","issues_url":"https://api.github.com/repos/uber/ringpop-go/issues{/number}","pulls_url":"https://api.github.com/repos/uber/ringpop-go/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/ringpop-go/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/ringpop-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/ringpop-go/labels{/name}","releases_url":"https://api.github.com/repos/uber/ringpop-go/releases{/id}","created_at":"2015-06-05T22:48:53Z","updated_at":"2015-11-30T06:02:18Z","pushed_at":"2015-12-02T15:26:37Z","git_url":"git://github.com/uber/ringpop-go.git","ssh_url":"git@github.com:uber/ringpop-go.git","clone_url":"https://github.com/uber/ringpop-go.git","svn_url":"https://github.com/uber/ringpop-go","homepage":"http://www.uber.com","size":1743,"stargazers_count":21,"watchers_count":21,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":21,"default_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"6a888abee5fb4f2d6c10991fb85df7872e7a9c84","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":36959143,"name":"ringpop-go","full_name":"uber/ringpop-go","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/ringpop-go","description":"Scalable, fault-tolerant application-layer sharding for Go applications","fork":false,"url":"https://api.github.com/repos/uber/ringpop-go","forks_url":"https://api.github.com/repos/uber/ringpop-go/forks","keys_url":"https://api.github.com/repos/uber/ringpop-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/ringpop-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/ringpop-go/teams","hooks_url":"https://api.github.com/repos/uber/ringpop-go/hooks","issue_events_url":"https://api.github.com/repos/uber/ringpop-go/issues/events{/number}","events_url":"https://api.github.com/repos/uber/ringpop-go/events","assignees_url":"https://api.github.com/repos/uber/ringpop-go/assignees{/user}","branches_url":"https://api.github.com/repos/uber/ringpop-go/branches{/branch}","tags_url":"https://api.github.com/repos/uber/ringpop-go/tags","blobs_url":"https://api.github.com/repos/uber/ringpop-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/ringpop-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/ringpop-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/ringpop-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/ringpop-go/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/ringpop-go/languages","stargazers_url":"https://api.github.com/repos/uber/ringpop-go/stargazers","contributors_url":"https://api.github.com/repos/uber/ringpop-go/contributors","subscribers_url":"https://api.github.com/repos/uber/ringpop-go/subscribers","subscription_url":"https://api.github.com/repos/uber/ringpop-go/subscription","commits_url":"https://api.github.com/repos/uber/ringpop-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/ringpop-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/ringpop-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/ringpop-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/ringpop-go/contents/{+path}","compare_url":"https://api.github.com/repos/uber/ringpop-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/ringpop-go/merges","archive_url":"https://api.github.com/repos/uber/ringpop-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/ringpop-go/downloads","issues_url":"https://api.github.com/repos/uber/ringpop-go/issues{/number}","pulls_url":"https://api.github.com/repos/uber/ringpop-go/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/ringpop-go/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/ringpop-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/ringpop-go/labels{/name}","releases_url":"https://api.github.com/repos/uber/ringpop-go/releases{/id}","created_at":"2015-06-05T22:48:53Z","updated_at":"2015-11-30T06:02:18Z","pushed_at":"2015-12-02T15:26:37Z","git_url":"git://github.com/uber/ringpop-go.git","ssh_url":"git@github.com:uber/ringpop-go.git","clone_url":"https://github.com/uber/ringpop-go.git","svn_url":"https://github.com/uber/ringpop-go","homepage":"http://www.uber.com","size":1743,"stargazers_count":21,"watchers_count":21,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/ringpop-go/pulls/33"},"html":{"href":"https://github.com/uber/ringpop-go/pull/33"},"issue":{"href":"https://api.github.com/repos/uber/ringpop-go/issues/33"},"comments":{"href":"https://api.github.com/repos/uber/ringpop-go/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/ringpop-go/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/ringpop-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/ringpop-go/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/uber/ringpop-go/statuses/4b9e64fe4fbc3e46b13277bb5d8829260c4e4551"}}}}