{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/presto/pulls/comments/45152525","id":45152525,"diff_hunk":"@@ -115,9 +119,23 @@ protected Void visitQuerySpecification(QuerySpecification node, Integer indentLe\n                 }\n \n                 if (!node.getGroupBy().isEmpty()) {\n-                    print(indentLevel, \"GroupBy\");\n-                    for (Expression expression : node.getGroupBy()) {\n-                        process(expression, indentLevel + 1);\n+                    for (GroupingElement groupBySpecification : node.getGroupBy()) {\n+                        print(indentLevel, \"GroupBy\");\n+                        if (groupBySpecification instanceof SimpleGroupBy) {","path":"presto-parser/src/main/java/com/facebook/presto/sql/TreePrinter.java","position":34,"original_position":34,"commit_id":"907dc6f5b780ea01d98d8bebce21e0ea9dc97297","original_commit_id":"907dc6f5b780ea01d98d8bebce21e0ea9dc97297","user":{"login":"martint","id":14387,"avatar_url":"https://avatars.githubusercontent.com/u/14387?v=3","gravatar_id":"","url":"https://api.github.com/users/martint","html_url":"https://github.com/martint","followers_url":"https://api.github.com/users/martint/followers","following_url":"https://api.github.com/users/martint/following{/other_user}","gists_url":"https://api.github.com/users/martint/gists{/gist_id}","starred_url":"https://api.github.com/users/martint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martint/subscriptions","organizations_url":"https://api.github.com/users/martint/orgs","repos_url":"https://api.github.com/users/martint/repos","events_url":"https://api.github.com/users/martint/events{/privacy}","received_events_url":"https://api.github.com/users/martint/received_events","type":"User","site_admin":false},"body":"Cube and Rollup?","created_at":"2015-11-18T02:24:37Z","updated_at":"2015-11-18T02:24:37Z","html_url":"https://github.com/facebook/presto/pull/3986#discussion_r45152525","pull_request_url":"https://api.github.com/repos/facebook/presto/pulls/3986","_links":{"self":{"href":"https://api.github.com/repos/facebook/presto/pulls/comments/45152525"},"html":{"href":"https://github.com/facebook/presto/pull/3986#discussion_r45152525"},"pull_request":{"href":"https://api.github.com/repos/facebook/presto/pulls/3986"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/presto/pulls/3986","id":51023020,"html_url":"https://github.com/facebook/presto/pull/3986","diff_url":"https://github.com/facebook/presto/pull/3986.diff","patch_url":"https://github.com/facebook/presto/pull/3986.patch","issue_url":"https://api.github.com/repos/facebook/presto/issues/3986","number":3986,"state":"open","locked":false,"title":"Add limited support for cube, rollup and grouping set to grammar","user":{"login":"raghavsethi","id":715788,"avatar_url":"https://avatars.githubusercontent.com/u/715788?v=3","gravatar_id":"","url":"https://api.github.com/users/raghavsethi","html_url":"https://github.com/raghavsethi","followers_url":"https://api.github.com/users/raghavsethi/followers","following_url":"https://api.github.com/users/raghavsethi/following{/other_user}","gists_url":"https://api.github.com/users/raghavsethi/gists{/gist_id}","starred_url":"https://api.github.com/users/raghavsethi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raghavsethi/subscriptions","organizations_url":"https://api.github.com/users/raghavsethi/orgs","repos_url":"https://api.github.com/users/raghavsethi/repos","events_url":"https://api.github.com/users/raghavsethi/events{/privacy}","received_events_url":"https://api.github.com/users/raghavsethi/received_events","type":"User","site_admin":false},"body":"- Add CUBE, ROLLUP and simple GROUPING SETS (i.e. one-level of nesting)\r\nto grammar.\r\n- Add analyzer support for simple grouping sets.\r\n- Add planning and execution support for queries with a single\r\ngrouping set (this is essentially a simple GROUP BY).","created_at":"2015-11-17T23:50:25Z","updated_at":"2015-11-18T02:24:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7376a9f3f174c6b9403947cf770af957ad6eb72d","assignee":{"login":"martint","id":14387,"avatar_url":"https://avatars.githubusercontent.com/u/14387?v=3","gravatar_id":"","url":"https://api.github.com/users/martint","html_url":"https://github.com/martint","followers_url":"https://api.github.com/users/martint/followers","following_url":"https://api.github.com/users/martint/following{/other_user}","gists_url":"https://api.github.com/users/martint/gists{/gist_id}","starred_url":"https://api.github.com/users/martint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martint/subscriptions","organizations_url":"https://api.github.com/users/martint/orgs","repos_url":"https://api.github.com/users/martint/repos","events_url":"https://api.github.com/users/martint/events{/privacy}","received_events_url":"https://api.github.com/users/martint/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/facebook/presto/pulls/3986/commits","review_comments_url":"https://api.github.com/repos/facebook/presto/pulls/3986/comments","review_comment_url":"https://api.github.com/repos/facebook/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/presto/issues/3986/comments","statuses_url":"https://api.github.com/repos/facebook/presto/statuses/907dc6f5b780ea01d98d8bebce21e0ea9dc97297","head":{"label":"raghavsethi:gs2_grammar","ref":"gs2_grammar","sha":"907dc6f5b780ea01d98d8bebce21e0ea9dc97297","user":{"login":"raghavsethi","id":715788,"avatar_url":"https://avatars.githubusercontent.com/u/715788?v=3","gravatar_id":"","url":"https://api.github.com/users/raghavsethi","html_url":"https://github.com/raghavsethi","followers_url":"https://api.github.com/users/raghavsethi/followers","following_url":"https://api.github.com/users/raghavsethi/following{/other_user}","gists_url":"https://api.github.com/users/raghavsethi/gists{/gist_id}","starred_url":"https://api.github.com/users/raghavsethi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raghavsethi/subscriptions","organizations_url":"https://api.github.com/users/raghavsethi/orgs","repos_url":"https://api.github.com/users/raghavsethi/repos","events_url":"https://api.github.com/users/raghavsethi/events{/privacy}","received_events_url":"https://api.github.com/users/raghavsethi/received_events","type":"User","site_admin":false},"repo":{"id":42330619,"name":"presto","full_name":"raghavsethi/presto","owner":{"login":"raghavsethi","id":715788,"avatar_url":"https://avatars.githubusercontent.com/u/715788?v=3","gravatar_id":"","url":"https://api.github.com/users/raghavsethi","html_url":"https://github.com/raghavsethi","followers_url":"https://api.github.com/users/raghavsethi/followers","following_url":"https://api.github.com/users/raghavsethi/following{/other_user}","gists_url":"https://api.github.com/users/raghavsethi/gists{/gist_id}","starred_url":"https://api.github.com/users/raghavsethi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raghavsethi/subscriptions","organizations_url":"https://api.github.com/users/raghavsethi/orgs","repos_url":"https://api.github.com/users/raghavsethi/repos","events_url":"https://api.github.com/users/raghavsethi/events{/privacy}","received_events_url":"https://api.github.com/users/raghavsethi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/raghavsethi/presto","description":"Distributed SQL query engine for running interactive analytic queries against big data sources.","fork":true,"url":"https://api.github.com/repos/raghavsethi/presto","forks_url":"https://api.github.com/repos/raghavsethi/presto/forks","keys_url":"https://api.github.com/repos/raghavsethi/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raghavsethi/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raghavsethi/presto/teams","hooks_url":"https://api.github.com/repos/raghavsethi/presto/hooks","issue_events_url":"https://api.github.com/repos/raghavsethi/presto/issues/events{/number}","events_url":"https://api.github.com/repos/raghavsethi/presto/events","assignees_url":"https://api.github.com/repos/raghavsethi/presto/assignees{/user}","branches_url":"https://api.github.com/repos/raghavsethi/presto/branches{/branch}","tags_url":"https://api.github.com/repos/raghavsethi/presto/tags","blobs_url":"https://api.github.com/repos/raghavsethi/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raghavsethi/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raghavsethi/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/raghavsethi/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raghavsethi/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/raghavsethi/presto/languages","stargazers_url":"https://api.github.com/repos/raghavsethi/presto/stargazers","contributors_url":"https://api.github.com/repos/raghavsethi/presto/contributors","subscribers_url":"https://api.github.com/repos/raghavsethi/presto/subscribers","subscription_url":"https://api.github.com/repos/raghavsethi/presto/subscription","commits_url":"https://api.github.com/repos/raghavsethi/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/raghavsethi/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/raghavsethi/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/raghavsethi/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/raghavsethi/presto/contents/{+path}","compare_url":"https://api.github.com/repos/raghavsethi/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raghavsethi/presto/merges","archive_url":"https://api.github.com/repos/raghavsethi/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raghavsethi/presto/downloads","issues_url":"https://api.github.com/repos/raghavsethi/presto/issues{/number}","pulls_url":"https://api.github.com/repos/raghavsethi/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/raghavsethi/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/raghavsethi/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raghavsethi/presto/labels{/name}","releases_url":"https://api.github.com/repos/raghavsethi/presto/releases{/id}","created_at":"2015-09-11T20:28:31Z","updated_at":"2015-09-11T20:28:39Z","pushed_at":"2015-11-18T01:57:01Z","git_url":"git://github.com/raghavsethi/presto.git","ssh_url":"git@github.com:raghavsethi/presto.git","clone_url":"https://github.com/raghavsethi/presto.git","svn_url":"https://github.com/raghavsethi/presto","homepage":"https://prestodb.io","size":51345,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"633dc4a675df376e23f497dac4312540b5a336a5","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":5349565,"name":"presto","full_name":"facebook/presto","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/presto","description":"Distributed SQL query engine for running interactive analytic queries against big data sources.","fork":false,"url":"https://api.github.com/repos/facebook/presto","forks_url":"https://api.github.com/repos/facebook/presto/forks","keys_url":"https://api.github.com/repos/facebook/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/presto/teams","hooks_url":"https://api.github.com/repos/facebook/presto/hooks","issue_events_url":"https://api.github.com/repos/facebook/presto/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/presto/events","assignees_url":"https://api.github.com/repos/facebook/presto/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/presto/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/presto/tags","blobs_url":"https://api.github.com/repos/facebook/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/presto/languages","stargazers_url":"https://api.github.com/repos/facebook/presto/stargazers","contributors_url":"https://api.github.com/repos/facebook/presto/contributors","subscribers_url":"https://api.github.com/repos/facebook/presto/subscribers","subscription_url":"https://api.github.com/repos/facebook/presto/subscription","commits_url":"https://api.github.com/repos/facebook/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/presto/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/presto/merges","archive_url":"https://api.github.com/repos/facebook/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/presto/downloads","issues_url":"https://api.github.com/repos/facebook/presto/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/presto/labels{/name}","releases_url":"https://api.github.com/repos/facebook/presto/releases{/id}","created_at":"2012-08-09T01:03:37Z","updated_at":"2015-11-18T01:05:26Z","pushed_at":"2015-11-18T02:11:08Z","git_url":"git://github.com/facebook/presto.git","ssh_url":"git@github.com:facebook/presto.git","clone_url":"https://github.com/facebook/presto.git","svn_url":"https://github.com/facebook/presto","homepage":"https://prestodb.io","size":102035,"stargazers_count":4110,"watchers_count":4110,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1081,"mirror_url":null,"open_issues_count":370,"forks":1081,"open_issues":370,"watchers":4110,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/presto/pulls/3986"},"html":{"href":"https://github.com/facebook/presto/pull/3986"},"issue":{"href":"https://api.github.com/repos/facebook/presto/issues/3986"},"comments":{"href":"https://api.github.com/repos/facebook/presto/issues/3986/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/presto/pulls/3986/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/presto/pulls/3986/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/presto/statuses/907dc6f5b780ea01d98d8bebce21e0ea9dc97297"}}}}