{"action":"created","issue":{"url":"https://api.github.com/repos/Jessecar96/SteamBot/issues/729","labels_url":"https://api.github.com/repos/Jessecar96/SteamBot/issues/729/labels{/name}","comments_url":"https://api.github.com/repos/Jessecar96/SteamBot/issues/729/comments","events_url":"https://api.github.com/repos/Jessecar96/SteamBot/issues/729/events","html_url":"https://github.com/Jessecar96/SteamBot/pull/729","id":59277216,"number":729,"title":"Accept offer update","user":{"login":"MadBender","id":4372982,"avatar_url":"https://avatars.githubusercontent.com/u/4372982?v=3","gravatar_id":"","url":"https://api.github.com/users/MadBender","html_url":"https://github.com/MadBender","followers_url":"https://api.github.com/users/MadBender/followers","following_url":"https://api.github.com/users/MadBender/following{/other_user}","gists_url":"https://api.github.com/users/MadBender/gists{/gist_id}","starred_url":"https://api.github.com/users/MadBender/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MadBender/subscriptions","organizations_url":"https://api.github.com/users/MadBender/orgs","repos_url":"https://api.github.com/users/MadBender/repos","events_url":"https://api.github.com/users/MadBender/events{/privacy}","received_events_url":"https://api.github.com/users/MadBender/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-02-27T18:46:24Z","updated_at":"2015-02-27T23:29:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Jessecar96/SteamBot/pulls/729","html_url":"https://github.com/Jessecar96/SteamBot/pull/729","diff_url":"https://github.com/Jessecar96/SteamBot/pull/729.diff","patch_url":"https://github.com/Jessecar96/SteamBot/pull/729.patch"},"body":"Hi\r\nI use your SteamBot for my custom bot aplication and it helps me a lot. Thank you for developing this project\r\nHere are some changes that I had to make. Please review them and merge to master if they are good\r\n\r\n1. I added an optional parameter to SteamWeb.Fetch and Request method that allows them to parse even non-200 HTTP responses (for example, when the trade can't be accepted, the error message is returned in HTTP 500 response, the original function throws WebException and can't get that message). \r\nThis does not break API and preserves original function behavior for existing clients\r\n2. TradeOffer.Accept now returns TradeOfferAcceptResponse which contains success flag, trade ID and error message. This function uses new SteamWeb.Fetch behavior to get error message. Also this is a breaking change, so clients may need to fix their code a bit."},"comment":{"url":"https://api.github.com/repos/Jessecar96/SteamBot/issues/comments/76492381","html_url":"https://github.com/Jessecar96/SteamBot/pull/729#issuecomment-76492381","issue_url":"https://api.github.com/repos/Jessecar96/SteamBot/issues/729","id":76492381,"user":{"login":"MadBender","id":4372982,"avatar_url":"https://avatars.githubusercontent.com/u/4372982?v=3","gravatar_id":"","url":"https://api.github.com/users/MadBender","html_url":"https://github.com/MadBender","followers_url":"https://api.github.com/users/MadBender/followers","following_url":"https://api.github.com/users/MadBender/following{/other_user}","gists_url":"https://api.github.com/users/MadBender/gists{/gist_id}","starred_url":"https://api.github.com/users/MadBender/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MadBender/subscriptions","organizations_url":"https://api.github.com/users/MadBender/orgs","repos_url":"https://api.github.com/users/MadBender/repos","events_url":"https://api.github.com/users/MadBender/events{/privacy}","received_events_url":"https://api.github.com/users/MadBender/received_events","type":"User","site_admin":false},"created_at":"2015-02-27T23:29:59Z","updated_at":"2015-02-27T23:29:59Z","body":"I think, implicit conversion of object to bool will look weird and non-obvious. And I also removed the output parameter (tradeId), it is now returned as one of result's field.\r\nThe change is actually small and can be made easily"}}