{"action":"created","issue":{"url":"https://api.github.com/repos/fidesmo/nordpol/issues/26","labels_url":"https://api.github.com/repos/fidesmo/nordpol/issues/26/labels{/name}","comments_url":"https://api.github.com/repos/fidesmo/nordpol/issues/26/comments","events_url":"https://api.github.com/repos/fidesmo/nordpol/issues/26/events","html_url":"https://github.com/fidesmo/nordpol/issues/26","id":109127786,"number":26,"title":"enableExclusiveNfc() and disableExclusiveNfc() not returning what is expected when NFC is unavailable","user":{"login":"Franzaine","id":537653,"avatar_url":"https://avatars.githubusercontent.com/u/537653?v=3","gravatar_id":"","url":"https://api.github.com/users/Franzaine","html_url":"https://github.com/Franzaine","followers_url":"https://api.github.com/users/Franzaine/followers","following_url":"https://api.github.com/users/Franzaine/following{/other_user}","gists_url":"https://api.github.com/users/Franzaine/gists{/gist_id}","starred_url":"https://api.github.com/users/Franzaine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Franzaine/subscriptions","organizations_url":"https://api.github.com/users/Franzaine/orgs","repos_url":"https://api.github.com/users/Franzaine/repos","events_url":"https://api.github.com/users/Franzaine/events{/privacy}","received_events_url":"https://api.github.com/users/Franzaine/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/fidesmo/nordpol/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":{"login":"Franzaine","id":537653,"avatar_url":"https://avatars.githubusercontent.com/u/537653?v=3","gravatar_id":"","url":"https://api.github.com/users/Franzaine","html_url":"https://github.com/Franzaine","followers_url":"https://api.github.com/users/Franzaine/followers","following_url":"https://api.github.com/users/Franzaine/following{/other_user}","gists_url":"https://api.github.com/users/Franzaine/gists{/gist_id}","starred_url":"https://api.github.com/users/Franzaine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Franzaine/subscriptions","organizations_url":"https://api.github.com/users/Franzaine/orgs","repos_url":"https://api.github.com/users/Franzaine/repos","events_url":"https://api.github.com/users/Franzaine/events{/privacy}","received_events_url":"https://api.github.com/users/Franzaine/received_events","type":"User","site_admin":false},"milestone":null,"comments":6,"created_at":"2015-09-30T16:15:22Z","updated_at":"2015-10-01T08:37:41Z","closed_at":null,"body":"Both [enableExclusiveNfc()](https://github.com/fidesmo/nordpol/blob/master/android/src/main/java/nordpol/TagDispatcher.java#L43) and [disableExclusiveNfc()](https://github.com/fidesmo/nordpol/blob/master/android/src/main/java/nordpol/TagDispatcher.java#L70) are expected to return false when NFC is not available on the device (it is put like this: \"@ returns true if NFC was available and false if no NFC is available on device.\") \r\n\r\nIt should be clarified if this means that NFC is disabled or simply not physically available on the device. From the language used and the very existence of OnNfcDisabledListener I expect that the intended return value is false if, and ONLY if, NFC is actually not physically available on the device. If so [this line](https://github.com/fidesmo/nordpol/blob/master/android/src/main/java/nordpol/TagDispatcher.java#L57) has to be changed to ```return true;```"},"comment":{"url":"https://api.github.com/repos/fidesmo/nordpol/issues/comments/144656669","html_url":"https://github.com/fidesmo/nordpol/issues/26#issuecomment-144656669","issue_url":"https://api.github.com/repos/fidesmo/nordpol/issues/26","id":144656669,"user":{"login":"Franzaine","id":537653,"avatar_url":"https://avatars.githubusercontent.com/u/537653?v=3","gravatar_id":"","url":"https://api.github.com/users/Franzaine","html_url":"https://github.com/Franzaine","followers_url":"https://api.github.com/users/Franzaine/followers","following_url":"https://api.github.com/users/Franzaine/following{/other_user}","gists_url":"https://api.github.com/users/Franzaine/gists{/gist_id}","starred_url":"https://api.github.com/users/Franzaine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Franzaine/subscriptions","organizations_url":"https://api.github.com/users/Franzaine/orgs","repos_url":"https://api.github.com/users/Franzaine/repos","events_url":"https://api.github.com/users/Franzaine/events{/privacy}","received_events_url":"https://api.github.com/users/Franzaine/received_events","type":"User","site_admin":false},"created_at":"2015-10-01T08:37:41Z","updated_at":"2015-10-01T08:37:41Z","body":"@petter-fidesmo yes. That is exactly right. As of now not having NFC at all on the device would fire both, and that sucks."}}