{"action":"created","issue":{"url":"https://api.github.com/repos/mit-crpg/openmc/issues/402","labels_url":"https://api.github.com/repos/mit-crpg/openmc/issues/402/labels{/name}","comments_url":"https://api.github.com/repos/mit-crpg/openmc/issues/402/comments","events_url":"https://api.github.com/repos/mit-crpg/openmc/issues/402/events","html_url":"https://github.com/mit-crpg/openmc/pull/402","id":91359512,"number":402,"title":"Simplified testing system","user":{"login":"smharper","id":4622797,"avatar_url":"https://avatars.githubusercontent.com/u/4622797?v=3","gravatar_id":"","url":"https://api.github.com/users/smharper","html_url":"https://github.com/smharper","followers_url":"https://api.github.com/users/smharper/followers","following_url":"https://api.github.com/users/smharper/following{/other_user}","gists_url":"https://api.github.com/users/smharper/gists{/gist_id}","starred_url":"https://api.github.com/users/smharper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smharper/subscriptions","organizations_url":"https://api.github.com/users/smharper/orgs","repos_url":"https://api.github.com/users/smharper/repos","events_url":"https://api.github.com/users/smharper/events{/privacy}","received_events_url":"https://api.github.com/users/smharper/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mit-crpg/openmc/labels/Test%20Suite","name":"Test Suite","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/mit-crpg/openmc/milestones/11","html_url":"https://github.com/mit-crpg/openmc/milestones/v0.7","labels_url":"https://api.github.com/repos/mit-crpg/openmc/milestones/11/labels","id":769762,"number":11,"title":"v0.7","description":"","creator":{"login":"paulromano","id":743095,"avatar_url":"https://avatars.githubusercontent.com/u/743095?v=3","gravatar_id":"","url":"https://api.github.com/users/paulromano","html_url":"https://github.com/paulromano","followers_url":"https://api.github.com/users/paulromano/followers","following_url":"https://api.github.com/users/paulromano/following{/other_user}","gists_url":"https://api.github.com/users/paulromano/gists{/gist_id}","starred_url":"https://api.github.com/users/paulromano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulromano/subscriptions","organizations_url":"https://api.github.com/users/paulromano/orgs","repos_url":"https://api.github.com/users/paulromano/repos","events_url":"https://api.github.com/users/paulromano/events{/privacy}","received_events_url":"https://api.github.com/users/paulromano/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":22,"state":"open","created_at":"2014-08-28T15:56:37Z","updated_at":"2015-07-03T03:55:32Z","due_on":"2015-03-31T04:00:00Z","closed_at":null},"comments":19,"created_at":"2015-06-26T20:52:21Z","updated_at":"2015-07-05T03:06:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mit-crpg/openmc/pulls/402","html_url":"https://github.com/mit-crpg/openmc/pull/402","diff_url":"https://github.com/mit-crpg/openmc/pull/402.diff","patch_url":"https://github.com/mit-crpg/openmc/pull/402.patch"},"body":"This PR introduces a simpler, object-oriented testing system.  All of the \"results.py\" files are gone.  Most of the \"test_*.py\" files now simply import the new `TestHarness` class, and call it's `execute_test()` method.  The more specialized tests create their own classes that inherit from `TestHarness` to check for different files, create different outputs, run OpenMC multiple times, etc.\r\n\r\nI changed a number of the \"results_true.dat\" files.  Most of them simply replace \"tallies:\" with \"tally 1:\".  A few of them have other cosmetic changes like removing a newline or changing the order of results.  The only test I changed significantly was \"test_filter_distribcell\".  That test now creates three separate \"results_test.dat\" files and checks them all.  The case-3 results are a hash rather than a raw output (it would be > 100,000 lines otherwise)."},"comment":{"url":"https://api.github.com/repos/mit-crpg/openmc/issues/comments/118573188","html_url":"https://github.com/mit-crpg/openmc/pull/402#issuecomment-118573188","issue_url":"https://api.github.com/repos/mit-crpg/openmc/issues/402","id":118573188,"user":{"login":"wbinventor","id":209492,"avatar_url":"https://avatars.githubusercontent.com/u/209492?v=3","gravatar_id":"","url":"https://api.github.com/users/wbinventor","html_url":"https://github.com/wbinventor","followers_url":"https://api.github.com/users/wbinventor/followers","following_url":"https://api.github.com/users/wbinventor/following{/other_user}","gists_url":"https://api.github.com/users/wbinventor/gists{/gist_id}","starred_url":"https://api.github.com/users/wbinventor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wbinventor/subscriptions","organizations_url":"https://api.github.com/users/wbinventor/orgs","repos_url":"https://api.github.com/users/wbinventor/repos","events_url":"https://api.github.com/users/wbinventor/events{/privacy}","received_events_url":"https://api.github.com/users/wbinventor/received_events","type":"User","site_admin":false},"created_at":"2015-07-05T03:06:46Z","updated_at":"2015-07-05T03:06:46Z","body":"It looks good to me!\nOn Jul 4, 2015 6:41 PM, \"Paul Romano\" <notifications@github.com> wrote:\n\n> @wbinventor <https://github.com/wbinventor> Since you were reviewing too,\n> did you have anything else you wanted to see addressed before merging? I'm\n> ready to merge when you are.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/mit-crpg/openmc/pull/402#issuecomment-118569971>.\n>\n"}}