{"action":"created","comment":{"url":"https://api.github.com/repos/reddit/reddit-mobile/pulls/comments/33961753","id":33961753,"diff_hunk":"@@ -72,8 +66,8 @@ class ListingDropdown extends React.Component {\n \n       reportLink = (\n         <li className='Dropdown-li'>\n-          <MobileButton className='Dropdown-button' onClick={ this._onReportClick }>\n-            <FlagIcon/>\n+          <MobileButton touch={ props.touch } className='Dropdown-button' onClick={ this._onReportClick }>","path":"src/views/components/ListingDropdown.jsx","position":28,"original_position":28,"commit_id":"b7c372470e9d0c1ff02842d279c7e3000b8131d7","original_commit_id":"b7c372470e9d0c1ff02842d279c7e3000b8131d7","user":{"login":"ajacksified","id":175515,"avatar_url":"https://avatars.githubusercontent.com/u/175515?v=3","gravatar_id":"","url":"https://api.github.com/users/ajacksified","html_url":"https://github.com/ajacksified","followers_url":"https://api.github.com/users/ajacksified/followers","following_url":"https://api.github.com/users/ajacksified/following{/other_user}","gists_url":"https://api.github.com/users/ajacksified/gists{/gist_id}","starred_url":"https://api.github.com/users/ajacksified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajacksified/subscriptions","organizations_url":"https://api.github.com/users/ajacksified/orgs","repos_url":"https://api.github.com/users/ajacksified/repos","events_url":"https://api.github.com/users/ajacksified/events{/privacy}","received_events_url":"https://api.github.com/users/ajacksified/received_events","type":"User","site_admin":false},"body":"The components were calling out to Utils.touch on mount, which in cases like the icons, was happening several hundred times per page render. This would be a good use for globals.","created_at":"2015-07-06T17:49:45Z","updated_at":"2015-07-06T17:49:45Z","html_url":"https://github.com/reddit/reddit-mobile/pull/249#discussion_r33961753","pull_request_url":"https://api.github.com/repos/reddit/reddit-mobile/pulls/249","_links":{"self":{"href":"https://api.github.com/repos/reddit/reddit-mobile/pulls/comments/33961753"},"html":{"href":"https://github.com/reddit/reddit-mobile/pull/249#discussion_r33961753"},"pull_request":{"href":"https://api.github.com/repos/reddit/reddit-mobile/pulls/249"}}},"pull_request":{"url":"https://api.github.com/repos/reddit/reddit-mobile/pulls/249","id":39239863,"html_url":"https://github.com/reddit/reddit-mobile/pull/249","diff_url":"https://github.com/reddit/reddit-mobile/pull/249.diff","patch_url":"https://github.com/reddit/reddit-mobile/pull/249.patch","issue_url":"https://api.github.com/repos/reddit/reddit-mobile/issues/249","number":249,"state":"open","locked":false,"title":"Performance","user":{"login":"ajacksified","id":175515,"avatar_url":"https://avatars.githubusercontent.com/u/175515?v=3","gravatar_id":"","url":"https://api.github.com/users/ajacksified","html_url":"https://github.com/ajacksified","followers_url":"https://api.github.com/users/ajacksified/followers","following_url":"https://api.github.com/users/ajacksified/following{/other_user}","gists_url":"https://api.github.com/users/ajacksified/gists{/gist_id}","starred_url":"https://api.github.com/users/ajacksified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajacksified/subscriptions","organizations_url":"https://api.github.com/users/ajacksified/orgs","repos_url":"https://api.github.com/users/ajacksified/repos","events_url":"https://api.github.com/users/ajacksified/events{/privacy}","received_events_url":"https://api.github.com/users/ajacksified/received_events","type":"User","site_admin":false},"body":"First pass at performance optimizations; low-hanging-fruit edition. Things are still slow, but they're significantly faster.\r\n\r\n:eyeglasses: @danehansen @curioussavage \r\n\r\nNotes are in the individual commits. highlights:\r\n\r\n* Replaced most of the `snooicon`s with css, and many other icons;\r\n* Fixed some bugs causing re-rendering;\r\n* Not rendering large or common hidden elements until they're made visible;\r\n\r\nBefore and after graph porn:\r\n\r\n<img width=\"801\" alt=\"1\" src=\"https://cloud.githubusercontent.com/assets/175515/8516972/4bed3b9a-2378-11e5-979a-a3edb712f8b4.png\">\r\n\r\n<img width=\"747\" alt=\"5\" src=\"https://cloud.githubusercontent.com/assets/175515/8516973/4bf00910-2378-11e5-9579-4ba3a564ebf1.png\">\r\n","created_at":"2015-07-06T06:47:46Z","updated_at":"2015-07-06T17:49:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b26afd44c90e29fb5403a828ff30db034d46854","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/reddit/reddit-mobile/pulls/249/commits","review_comments_url":"https://api.github.com/repos/reddit/reddit-mobile/pulls/249/comments","review_comment_url":"https://api.github.com/repos/reddit/reddit-mobile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reddit/reddit-mobile/issues/249/comments","statuses_url":"https://api.github.com/repos/reddit/reddit-mobile/statuses/b7c372470e9d0c1ff02842d279c7e3000b8131d7","head":{"label":"ajacksified:performance","ref":"performance","sha":"b7c372470e9d0c1ff02842d279c7e3000b8131d7","user":{"login":"ajacksified","id":175515,"avatar_url":"https://avatars.githubusercontent.com/u/175515?v=3","gravatar_id":"","url":"https://api.github.com/users/ajacksified","html_url":"https://github.com/ajacksified","followers_url":"https://api.github.com/users/ajacksified/followers","following_url":"https://api.github.com/users/ajacksified/following{/other_user}","gists_url":"https://api.github.com/users/ajacksified/gists{/gist_id}","starred_url":"https://api.github.com/users/ajacksified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajacksified/subscriptions","organizations_url":"https://api.github.com/users/ajacksified/orgs","repos_url":"https://api.github.com/users/ajacksified/repos","events_url":"https://api.github.com/users/ajacksified/events{/privacy}","received_events_url":"https://api.github.com/users/ajacksified/received_events","type":"User","site_admin":false},"repo":{"id":23087796,"name":"reddit-mobile","full_name":"ajacksified/reddit-mobile","owner":{"login":"ajacksified","id":175515,"avatar_url":"https://avatars.githubusercontent.com/u/175515?v=3","gravatar_id":"","url":"https://api.github.com/users/ajacksified","html_url":"https://github.com/ajacksified","followers_url":"https://api.github.com/users/ajacksified/followers","following_url":"https://api.github.com/users/ajacksified/following{/other_user}","gists_url":"https://api.github.com/users/ajacksified/gists{/gist_id}","starred_url":"https://api.github.com/users/ajacksified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajacksified/subscriptions","organizations_url":"https://api.github.com/users/ajacksified/orgs","repos_url":"https://api.github.com/users/ajacksified/repos","events_url":"https://api.github.com/users/ajacksified/events{/privacy}","received_events_url":"https://api.github.com/users/ajacksified/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ajacksified/reddit-mobile","description":"","fork":true,"url":"https://api.github.com/repos/ajacksified/reddit-mobile","forks_url":"https://api.github.com/repos/ajacksified/reddit-mobile/forks","keys_url":"https://api.github.com/repos/ajacksified/reddit-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajacksified/reddit-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajacksified/reddit-mobile/teams","hooks_url":"https://api.github.com/repos/ajacksified/reddit-mobile/hooks","issue_events_url":"https://api.github.com/repos/ajacksified/reddit-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/ajacksified/reddit-mobile/events","assignees_url":"https://api.github.com/repos/ajacksified/reddit-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/ajacksified/reddit-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/ajacksified/reddit-mobile/tags","blobs_url":"https://api.github.com/repos/ajacksified/reddit-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajacksified/reddit-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajacksified/reddit-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajacksified/reddit-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajacksified/reddit-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/ajacksified/reddit-mobile/languages","stargazers_url":"https://api.github.com/repos/ajacksified/reddit-mobile/stargazers","contributors_url":"https://api.github.com/repos/ajacksified/reddit-mobile/contributors","subscribers_url":"https://api.github.com/repos/ajacksified/reddit-mobile/subscribers","subscription_url":"https://api.github.com/repos/ajacksified/reddit-mobile/subscription","commits_url":"https://api.github.com/repos/ajacksified/reddit-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajacksified/reddit-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajacksified/reddit-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajacksified/reddit-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajacksified/reddit-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/ajacksified/reddit-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajacksified/reddit-mobile/merges","archive_url":"https://api.github.com/repos/ajacksified/reddit-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajacksified/reddit-mobile/downloads","issues_url":"https://api.github.com/repos/ajacksified/reddit-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/ajacksified/reddit-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/ajacksified/reddit-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/ajacksified/reddit-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajacksified/reddit-mobile/labels{/name}","releases_url":"https://api.github.com/repos/ajacksified/reddit-mobile/releases{/id}","created_at":"2014-08-18T21:51:13Z","updated_at":"2015-05-08T16:49:32Z","pushed_at":"2015-07-06T06:42:51Z","git_url":"git://github.com/ajacksified/reddit-mobile.git","ssh_url":"git@github.com:ajacksified/reddit-mobile.git","clone_url":"https://github.com/ajacksified/reddit-mobile.git","svn_url":"https://github.com/ajacksified/reddit-mobile","homepage":null,"size":7185,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"reddit:master","ref":"master","sha":"c9adaf1d1ae8de08c6532cc15fe11b9bc6d38fed","user":{"login":"reddit","id":14248,"avatar_url":"https://avatars.githubusercontent.com/u/14248?v=3","gravatar_id":"","url":"https://api.github.com/users/reddit","html_url":"https://github.com/reddit","followers_url":"https://api.github.com/users/reddit/followers","following_url":"https://api.github.com/users/reddit/following{/other_user}","gists_url":"https://api.github.com/users/reddit/gists{/gist_id}","starred_url":"https://api.github.com/users/reddit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddit/subscriptions","organizations_url":"https://api.github.com/users/reddit/orgs","repos_url":"https://api.github.com/users/reddit/repos","events_url":"https://api.github.com/users/reddit/events{/privacy}","received_events_url":"https://api.github.com/users/reddit/received_events","type":"Organization","site_admin":false},"repo":{"id":23087554,"name":"reddit-mobile","full_name":"reddit/reddit-mobile","owner":{"login":"reddit","id":14248,"avatar_url":"https://avatars.githubusercontent.com/u/14248?v=3","gravatar_id":"","url":"https://api.github.com/users/reddit","html_url":"https://github.com/reddit","followers_url":"https://api.github.com/users/reddit/followers","following_url":"https://api.github.com/users/reddit/following{/other_user}","gists_url":"https://api.github.com/users/reddit/gists{/gist_id}","starred_url":"https://api.github.com/users/reddit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddit/subscriptions","organizations_url":"https://api.github.com/users/reddit/orgs","repos_url":"https://api.github.com/users/reddit/repos","events_url":"https://api.github.com/users/reddit/events{/privacy}","received_events_url":"https://api.github.com/users/reddit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reddit/reddit-mobile","description":"","fork":false,"url":"https://api.github.com/repos/reddit/reddit-mobile","forks_url":"https://api.github.com/repos/reddit/reddit-mobile/forks","keys_url":"https://api.github.com/repos/reddit/reddit-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reddit/reddit-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reddit/reddit-mobile/teams","hooks_url":"https://api.github.com/repos/reddit/reddit-mobile/hooks","issue_events_url":"https://api.github.com/repos/reddit/reddit-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/reddit/reddit-mobile/events","assignees_url":"https://api.github.com/repos/reddit/reddit-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/reddit/reddit-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/reddit/reddit-mobile/tags","blobs_url":"https://api.github.com/repos/reddit/reddit-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reddit/reddit-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reddit/reddit-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/reddit/reddit-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reddit/reddit-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/reddit/reddit-mobile/languages","stargazers_url":"https://api.github.com/repos/reddit/reddit-mobile/stargazers","contributors_url":"https://api.github.com/repos/reddit/reddit-mobile/contributors","subscribers_url":"https://api.github.com/repos/reddit/reddit-mobile/subscribers","subscription_url":"https://api.github.com/repos/reddit/reddit-mobile/subscription","commits_url":"https://api.github.com/repos/reddit/reddit-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/reddit/reddit-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/reddit/reddit-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/reddit/reddit-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/reddit/reddit-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/reddit/reddit-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reddit/reddit-mobile/merges","archive_url":"https://api.github.com/repos/reddit/reddit-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reddit/reddit-mobile/downloads","issues_url":"https://api.github.com/repos/reddit/reddit-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/reddit/reddit-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/reddit/reddit-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/reddit/reddit-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reddit/reddit-mobile/labels{/name}","releases_url":"https://api.github.com/repos/reddit/reddit-mobile/releases{/id}","created_at":"2014-08-18T21:42:05Z","updated_at":"2015-07-06T17:36:43Z","pushed_at":"2015-07-06T14:34:34Z","git_url":"git://github.com/reddit/reddit-mobile.git","ssh_url":"git@github.com:reddit/reddit-mobile.git","clone_url":"https://github.com/reddit/reddit-mobile.git","svn_url":"https://github.com/reddit/reddit-mobile","homepage":null,"size":7524,"stargazers_count":362,"watchers_count":362,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":61,"mirror_url":null,"open_issues_count":26,"forks":61,"open_issues":26,"watchers":362,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reddit/reddit-mobile/pulls/249"},"html":{"href":"https://github.com/reddit/reddit-mobile/pull/249"},"issue":{"href":"https://api.github.com/repos/reddit/reddit-mobile/issues/249"},"comments":{"href":"https://api.github.com/repos/reddit/reddit-mobile/issues/249/comments"},"review_comments":{"href":"https://api.github.com/repos/reddit/reddit-mobile/pulls/249/comments"},"review_comment":{"href":"https://api.github.com/repos/reddit/reddit-mobile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reddit/reddit-mobile/pulls/249/commits"},"statuses":{"href":"https://api.github.com/repos/reddit/reddit-mobile/statuses/b7c372470e9d0c1ff02842d279c7e3000b8131d7"}}}}