{"action":"created","comment":{"url":"https://api.github.com/repos/endophage/go-tuf/pulls/comments/28635481","id":28635481,"diff_hunk":"@@ -0,0 +1,20 @@\n+package signed\n+\n+import (\n+\t\"github.com/endophage/go-tuf/data\"\n+\t\"github.com/endophage/go-tuf/keys\"\n+)\n+\n+type SigningService interface {\n+\tSign(keyIDs []string, data []byte) ([]data.Signature, error)","path":"signed/interface.go","position":9,"original_position":9,"commit_id":"299f5812245b4c3e45d2be54fffc7ffdd6015be9","original_commit_id":"299f5812245b4c3e45d2be54fffc7ffdd6015be9","user":{"login":"dmcgowan","id":169601,"avatar_url":"https://avatars.githubusercontent.com/u/169601?v=3","gravatar_id":"","url":"https://api.github.com/users/dmcgowan","html_url":"https://github.com/dmcgowan","followers_url":"https://api.github.com/users/dmcgowan/followers","following_url":"https://api.github.com/users/dmcgowan/following{/other_user}","gists_url":"https://api.github.com/users/dmcgowan/gists{/gist_id}","starred_url":"https://api.github.com/users/dmcgowan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmcgowan/subscriptions","organizations_url":"https://api.github.com/users/dmcgowan/orgs","repos_url":"https://api.github.com/users/dmcgowan/repos","events_url":"https://api.github.com/users/dmcgowan/events{/privacy}","received_events_url":"https://api.github.com/users/dmcgowan/received_events","type":"User","site_admin":false},"body":"Is passing in multiple key IDs intended as an optimization when signing data with multiple keys?","created_at":"2015-04-17T22:38:37Z","updated_at":"2015-04-17T22:38:37Z","html_url":"https://github.com/endophage/go-tuf/pull/2#discussion_r28635481","pull_request_url":"https://api.github.com/repos/endophage/go-tuf/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/endophage/go-tuf/pulls/comments/28635481"},"html":{"href":"https://github.com/endophage/go-tuf/pull/2#discussion_r28635481"},"pull_request":{"href":"https://api.github.com/repos/endophage/go-tuf/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/endophage/go-tuf/pulls/2","id":33584764,"html_url":"https://github.com/endophage/go-tuf/pull/2","diff_url":"https://github.com/endophage/go-tuf/pull/2.diff","patch_url":"https://github.com/endophage/go-tuf/pull/2.patch","issue_url":"https://api.github.com/repos/endophage/go-tuf/issues/2","number":2,"state":"open","locked":false,"title":"Stores","user":{"login":"endophage","id":1302091,"avatar_url":"https://avatars.githubusercontent.com/u/1302091?v=3","gravatar_id":"","url":"https://api.github.com/users/endophage","html_url":"https://github.com/endophage","followers_url":"https://api.github.com/users/endophage/followers","following_url":"https://api.github.com/users/endophage/following{/other_user}","gists_url":"https://api.github.com/users/endophage/gists{/gist_id}","starred_url":"https://api.github.com/users/endophage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endophage/subscriptions","organizations_url":"https://api.github.com/users/endophage/orgs","repos_url":"https://api.github.com/users/endophage/repos","events_url":"https://api.github.com/users/endophage/events{/privacy}","received_events_url":"https://api.github.com/users/endophage/received_events","type":"User","site_admin":false},"body":"This branch supersedes the dbstore branch. With some modification the FileSystemStore and InMemoryStores are working again. All (?) tests are passing bar one in repo_test that has been commented out because key persistence is no longer the job of go-tuf (instead a signing service, which may be a local, compiled in lib, is responsible, and should be tested independently against the TrustService interface).","created_at":"2015-04-17T21:38:55Z","updated_at":"2015-04-17T22:38:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14f22dd39a28dc42e53c861f4563986c2cfbca80","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/endophage/go-tuf/pulls/2/commits","review_comments_url":"https://api.github.com/repos/endophage/go-tuf/pulls/2/comments","review_comment_url":"https://api.github.com/repos/endophage/go-tuf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/endophage/go-tuf/issues/2/comments","statuses_url":"https://api.github.com/repos/endophage/go-tuf/statuses/299f5812245b4c3e45d2be54fffc7ffdd6015be9","head":{"label":"endophage:stores","ref":"stores","sha":"299f5812245b4c3e45d2be54fffc7ffdd6015be9","user":{"login":"endophage","id":1302091,"avatar_url":"https://avatars.githubusercontent.com/u/1302091?v=3","gravatar_id":"","url":"https://api.github.com/users/endophage","html_url":"https://github.com/endophage","followers_url":"https://api.github.com/users/endophage/followers","following_url":"https://api.github.com/users/endophage/following{/other_user}","gists_url":"https://api.github.com/users/endophage/gists{/gist_id}","starred_url":"https://api.github.com/users/endophage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endophage/subscriptions","organizations_url":"https://api.github.com/users/endophage/orgs","repos_url":"https://api.github.com/users/endophage/repos","events_url":"https://api.github.com/users/endophage/events{/privacy}","received_events_url":"https://api.github.com/users/endophage/received_events","type":"User","site_admin":false},"repo":{"id":32553143,"name":"go-tuf","full_name":"endophage/go-tuf","owner":{"login":"endophage","id":1302091,"avatar_url":"https://avatars.githubusercontent.com/u/1302091?v=3","gravatar_id":"","url":"https://api.github.com/users/endophage","html_url":"https://github.com/endophage","followers_url":"https://api.github.com/users/endophage/followers","following_url":"https://api.github.com/users/endophage/following{/other_user}","gists_url":"https://api.github.com/users/endophage/gists{/gist_id}","starred_url":"https://api.github.com/users/endophage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endophage/subscriptions","organizations_url":"https://api.github.com/users/endophage/orgs","repos_url":"https://api.github.com/users/endophage/repos","events_url":"https://api.github.com/users/endophage/events{/privacy}","received_events_url":"https://api.github.com/users/endophage/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/endophage/go-tuf","description":"Go implementation of The Update Framework (TUF)","fork":true,"url":"https://api.github.com/repos/endophage/go-tuf","forks_url":"https://api.github.com/repos/endophage/go-tuf/forks","keys_url":"https://api.github.com/repos/endophage/go-tuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endophage/go-tuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endophage/go-tuf/teams","hooks_url":"https://api.github.com/repos/endophage/go-tuf/hooks","issue_events_url":"https://api.github.com/repos/endophage/go-tuf/issues/events{/number}","events_url":"https://api.github.com/repos/endophage/go-tuf/events","assignees_url":"https://api.github.com/repos/endophage/go-tuf/assignees{/user}","branches_url":"https://api.github.com/repos/endophage/go-tuf/branches{/branch}","tags_url":"https://api.github.com/repos/endophage/go-tuf/tags","blobs_url":"https://api.github.com/repos/endophage/go-tuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endophage/go-tuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endophage/go-tuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/endophage/go-tuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endophage/go-tuf/statuses/{sha}","languages_url":"https://api.github.com/repos/endophage/go-tuf/languages","stargazers_url":"https://api.github.com/repos/endophage/go-tuf/stargazers","contributors_url":"https://api.github.com/repos/endophage/go-tuf/contributors","subscribers_url":"https://api.github.com/repos/endophage/go-tuf/subscribers","subscription_url":"https://api.github.com/repos/endophage/go-tuf/subscription","commits_url":"https://api.github.com/repos/endophage/go-tuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/endophage/go-tuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/endophage/go-tuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/endophage/go-tuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/endophage/go-tuf/contents/{+path}","compare_url":"https://api.github.com/repos/endophage/go-tuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endophage/go-tuf/merges","archive_url":"https://api.github.com/repos/endophage/go-tuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endophage/go-tuf/downloads","issues_url":"https://api.github.com/repos/endophage/go-tuf/issues{/number}","pulls_url":"https://api.github.com/repos/endophage/go-tuf/pulls{/number}","milestones_url":"https://api.github.com/repos/endophage/go-tuf/milestones{/number}","notifications_url":"https://api.github.com/repos/endophage/go-tuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endophage/go-tuf/labels{/name}","releases_url":"https://api.github.com/repos/endophage/go-tuf/releases{/id}","created_at":"2015-03-20T00:12:35Z","updated_at":"2015-03-20T00:12:36Z","pushed_at":"2015-04-17T21:38:55Z","git_url":"git://github.com/endophage/go-tuf.git","ssh_url":"git@github.com:endophage/go-tuf.git","clone_url":"https://github.com/endophage/go-tuf.git","svn_url":"https://github.com/endophage/go-tuf","homepage":"http://theupdateframework.com","size":627,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"endophage:master","ref":"master","sha":"8652ae8af61522e0ec526fd1f151d239335cdf1b","user":{"login":"endophage","id":1302091,"avatar_url":"https://avatars.githubusercontent.com/u/1302091?v=3","gravatar_id":"","url":"https://api.github.com/users/endophage","html_url":"https://github.com/endophage","followers_url":"https://api.github.com/users/endophage/followers","following_url":"https://api.github.com/users/endophage/following{/other_user}","gists_url":"https://api.github.com/users/endophage/gists{/gist_id}","starred_url":"https://api.github.com/users/endophage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endophage/subscriptions","organizations_url":"https://api.github.com/users/endophage/orgs","repos_url":"https://api.github.com/users/endophage/repos","events_url":"https://api.github.com/users/endophage/events{/privacy}","received_events_url":"https://api.github.com/users/endophage/received_events","type":"User","site_admin":false},"repo":{"id":32553143,"name":"go-tuf","full_name":"endophage/go-tuf","owner":{"login":"endophage","id":1302091,"avatar_url":"https://avatars.githubusercontent.com/u/1302091?v=3","gravatar_id":"","url":"https://api.github.com/users/endophage","html_url":"https://github.com/endophage","followers_url":"https://api.github.com/users/endophage/followers","following_url":"https://api.github.com/users/endophage/following{/other_user}","gists_url":"https://api.github.com/users/endophage/gists{/gist_id}","starred_url":"https://api.github.com/users/endophage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endophage/subscriptions","organizations_url":"https://api.github.com/users/endophage/orgs","repos_url":"https://api.github.com/users/endophage/repos","events_url":"https://api.github.com/users/endophage/events{/privacy}","received_events_url":"https://api.github.com/users/endophage/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/endophage/go-tuf","description":"Go implementation of The Update Framework (TUF)","fork":true,"url":"https://api.github.com/repos/endophage/go-tuf","forks_url":"https://api.github.com/repos/endophage/go-tuf/forks","keys_url":"https://api.github.com/repos/endophage/go-tuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endophage/go-tuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endophage/go-tuf/teams","hooks_url":"https://api.github.com/repos/endophage/go-tuf/hooks","issue_events_url":"https://api.github.com/repos/endophage/go-tuf/issues/events{/number}","events_url":"https://api.github.com/repos/endophage/go-tuf/events","assignees_url":"https://api.github.com/repos/endophage/go-tuf/assignees{/user}","branches_url":"https://api.github.com/repos/endophage/go-tuf/branches{/branch}","tags_url":"https://api.github.com/repos/endophage/go-tuf/tags","blobs_url":"https://api.github.com/repos/endophage/go-tuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endophage/go-tuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endophage/go-tuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/endophage/go-tuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endophage/go-tuf/statuses/{sha}","languages_url":"https://api.github.com/repos/endophage/go-tuf/languages","stargazers_url":"https://api.github.com/repos/endophage/go-tuf/stargazers","contributors_url":"https://api.github.com/repos/endophage/go-tuf/contributors","subscribers_url":"https://api.github.com/repos/endophage/go-tuf/subscribers","subscription_url":"https://api.github.com/repos/endophage/go-tuf/subscription","commits_url":"https://api.github.com/repos/endophage/go-tuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/endophage/go-tuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/endophage/go-tuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/endophage/go-tuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/endophage/go-tuf/contents/{+path}","compare_url":"https://api.github.com/repos/endophage/go-tuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endophage/go-tuf/merges","archive_url":"https://api.github.com/repos/endophage/go-tuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endophage/go-tuf/downloads","issues_url":"https://api.github.com/repos/endophage/go-tuf/issues{/number}","pulls_url":"https://api.github.com/repos/endophage/go-tuf/pulls{/number}","milestones_url":"https://api.github.com/repos/endophage/go-tuf/milestones{/number}","notifications_url":"https://api.github.com/repos/endophage/go-tuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endophage/go-tuf/labels{/name}","releases_url":"https://api.github.com/repos/endophage/go-tuf/releases{/id}","created_at":"2015-03-20T00:12:35Z","updated_at":"2015-03-20T00:12:36Z","pushed_at":"2015-04-17T21:38:55Z","git_url":"git://github.com/endophage/go-tuf.git","ssh_url":"git@github.com:endophage/go-tuf.git","clone_url":"https://github.com/endophage/go-tuf.git","svn_url":"https://github.com/endophage/go-tuf","homepage":"http://theupdateframework.com","size":627,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/endophage/go-tuf/pulls/2"},"html":{"href":"https://github.com/endophage/go-tuf/pull/2"},"issue":{"href":"https://api.github.com/repos/endophage/go-tuf/issues/2"},"comments":{"href":"https://api.github.com/repos/endophage/go-tuf/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/endophage/go-tuf/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/endophage/go-tuf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/endophage/go-tuf/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/endophage/go-tuf/statuses/299f5812245b4c3e45d2be54fffc7ffdd6015be9"}}}}