{"action":"closed","number":10,"pull_request":{"url":"https://api.github.com/repos/penelopy/bias_impact_project/pulls/10","id":51581790,"html_url":"https://github.com/penelopy/bias_impact_project/pull/10","diff_url":"https://github.com/penelopy/bias_impact_project/pull/10.diff","patch_url":"https://github.com/penelopy/bias_impact_project/pull/10.patch","issue_url":"https://api.github.com/repos/penelopy/bias_impact_project/issues/10","number":10,"state":"closed","locked":false,"title":"Improved approach to promotion producing dramatically different results","user":{"login":"penelopy","id":4615657,"avatar_url":"https://avatars.githubusercontent.com/u/4615657?v=3","gravatar_id":"","url":"https://api.github.com/users/penelopy","html_url":"https://github.com/penelopy","followers_url":"https://api.github.com/users/penelopy/followers","following_url":"https://api.github.com/users/penelopy/following{/other_user}","gists_url":"https://api.github.com/users/penelopy/gists{/gist_id}","starred_url":"https://api.github.com/users/penelopy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/penelopy/subscriptions","organizations_url":"https://api.github.com/users/penelopy/orgs","repos_url":"https://api.github.com/users/penelopy/repos","events_url":"https://api.github.com/users/penelopy/events{/privacy}","received_events_url":"https://api.github.com/users/penelopy/received_events","type":"User","site_admin":false},"body":"Previously the promote method started at level two, filled it's open positions from employees in level one and continued these steps until it reached the top level. \r\nUpon closer review, I realized that starting from the bottom results in creating new openings as you continue to the top. Therefore the method should look at the top level, complete it's promotions and move down to the bottom. At the end of the method only level one should have open positions, which get filled by the hire method.\r\nThe glitch is that this approach returns very different final results then we've come to expect. \r\n(Both versions are viewable in this code)\r\nI think the new version may be correct and that our results up until now we incorrect.  ","created_at":"2015-11-23T21:20:30Z","updated_at":"2015-11-24T02:00:20Z","closed_at":"2015-11-24T02:00:20Z","merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/penelopy/bias_impact_project/pulls/10/commits","review_comments_url":"https://api.github.com/repos/penelopy/bias_impact_project/pulls/10/comments","review_comment_url":"https://api.github.com/repos/penelopy/bias_impact_project/pulls/comments{/number}","comments_url":"https://api.github.com/repos/penelopy/bias_impact_project/issues/10/comments","statuses_url":"https://api.github.com/repos/penelopy/bias_impact_project/statuses/487dd17dfddbd4866e5b7bcfa0102cf23d068b2c","head":{"label":"penelopy:promote_method_needs_review","ref":"promote_method_needs_review","sha":"487dd17dfddbd4866e5b7bcfa0102cf23d068b2c","user":{"login":"penelopy","id":4615657,"avatar_url":"https://avatars.githubusercontent.com/u/4615657?v=3","gravatar_id":"","url":"https://api.github.com/users/penelopy","html_url":"https://github.com/penelopy","followers_url":"https://api.github.com/users/penelopy/followers","following_url":"https://api.github.com/users/penelopy/following{/other_user}","gists_url":"https://api.github.com/users/penelopy/gists{/gist_id}","starred_url":"https://api.github.com/users/penelopy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/penelopy/subscriptions","organizations_url":"https://api.github.com/users/penelopy/orgs","repos_url":"https://api.github.com/users/penelopy/repos","events_url":"https://api.github.com/users/penelopy/events{/privacy}","received_events_url":"https://api.github.com/users/penelopy/received_events","type":"User","site_admin":false},"repo":{"id":46090165,"name":"bias_impact_project","full_name":"penelopy/bias_impact_project","owner":{"login":"penelopy","id":4615657,"avatar_url":"https://avatars.githubusercontent.com/u/4615657?v=3","gravatar_id":"","url":"https://api.github.com/users/penelopy","html_url":"https://github.com/penelopy","followers_url":"https://api.github.com/users/penelopy/followers","following_url":"https://api.github.com/users/penelopy/following{/other_user}","gists_url":"https://api.github.com/users/penelopy/gists{/gist_id}","starred_url":"https://api.github.com/users/penelopy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/penelopy/subscriptions","organizations_url":"https://api.github.com/users/penelopy/orgs","repos_url":"https://api.github.com/users/penelopy/repos","events_url":"https://api.github.com/users/penelopy/events{/privacy}","received_events_url":"https://api.github.com/users/penelopy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/penelopy/bias_impact_project","description":"","fork":false,"url":"https://api.github.com/repos/penelopy/bias_impact_project","forks_url":"https://api.github.com/repos/penelopy/bias_impact_project/forks","keys_url":"https://api.github.com/repos/penelopy/bias_impact_project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/penelopy/bias_impact_project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/penelopy/bias_impact_project/teams","hooks_url":"https://api.github.com/repos/penelopy/bias_impact_project/hooks","issue_events_url":"https://api.github.com/repos/penelopy/bias_impact_project/issues/events{/number}","events_url":"https://api.github.com/repos/penelopy/bias_impact_project/events","assignees_url":"https://api.github.com/repos/penelopy/bias_impact_project/assignees{/user}","branches_url":"https://api.github.com/repos/penelopy/bias_impact_project/branches{/branch}","tags_url":"https://api.github.com/repos/penelopy/bias_impact_project/tags","blobs_url":"https://api.github.com/repos/penelopy/bias_impact_project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/penelopy/bias_impact_project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/penelopy/bias_impact_project/git/refs{/sha}","trees_url":"https://api.github.com/repos/penelopy/bias_impact_project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/penelopy/bias_impact_project/statuses/{sha}","languages_url":"https://api.github.com/repos/penelopy/bias_impact_project/languages","stargazers_url":"https://api.github.com/repos/penelopy/bias_impact_project/stargazers","contributors_url":"https://api.github.com/repos/penelopy/bias_impact_project/contributors","subscribers_url":"https://api.github.com/repos/penelopy/bias_impact_project/subscribers","subscription_url":"https://api.github.com/repos/penelopy/bias_impact_project/subscription","commits_url":"https://api.github.com/repos/penelopy/bias_impact_project/commits{/sha}","git_commits_url":"https://api.github.com/repos/penelopy/bias_impact_project/git/commits{/sha}","comments_url":"https://api.github.com/repos/penelopy/bias_impact_project/comments{/number}","issue_comment_url":"https://api.github.com/repos/penelopy/bias_impact_project/issues/comments{/number}","contents_url":"https://api.github.com/repos/penelopy/bias_impact_project/contents/{+path}","compare_url":"https://api.github.com/repos/penelopy/bias_impact_project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/penelopy/bias_impact_project/merges","archive_url":"https://api.github.com/repos/penelopy/bias_impact_project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/penelopy/bias_impact_project/downloads","issues_url":"https://api.github.com/repos/penelopy/bias_impact_project/issues{/number}","pulls_url":"https://api.github.com/repos/penelopy/bias_impact_project/pulls{/number}","milestones_url":"https://api.github.com/repos/penelopy/bias_impact_project/milestones{/number}","notifications_url":"https://api.github.com/repos/penelopy/bias_impact_project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/penelopy/bias_impact_project/labels{/name}","releases_url":"https://api.github.com/repos/penelopy/bias_impact_project/releases{/id}","created_at":"2015-11-13T00:44:39Z","updated_at":"2015-11-18T19:25:31Z","pushed_at":"2015-11-24T01:59:44Z","git_url":"git://github.com/penelopy/bias_impact_project.git","ssh_url":"git@github.com:penelopy/bias_impact_project.git","clone_url":"https://github.com/penelopy/bias_impact_project.git","svn_url":"https://github.com/penelopy/bias_impact_project","homepage":null,"size":1700,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"penelopy:master","ref":"master","sha":"acf87db015a189c5a9bd9a495b0918057deda9fc","user":{"login":"penelopy","id":4615657,"avatar_url":"https://avatars.githubusercontent.com/u/4615657?v=3","gravatar_id":"","url":"https://api.github.com/users/penelopy","html_url":"https://github.com/penelopy","followers_url":"https://api.github.com/users/penelopy/followers","following_url":"https://api.github.com/users/penelopy/following{/other_user}","gists_url":"https://api.github.com/users/penelopy/gists{/gist_id}","starred_url":"https://api.github.com/users/penelopy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/penelopy/subscriptions","organizations_url":"https://api.github.com/users/penelopy/orgs","repos_url":"https://api.github.com/users/penelopy/repos","events_url":"https://api.github.com/users/penelopy/events{/privacy}","received_events_url":"https://api.github.com/users/penelopy/received_events","type":"User","site_admin":false},"repo":{"id":46090165,"name":"bias_impact_project","full_name":"penelopy/bias_impact_project","owner":{"login":"penelopy","id":4615657,"avatar_url":"https://avatars.githubusercontent.com/u/4615657?v=3","gravatar_id":"","url":"https://api.github.com/users/penelopy","html_url":"https://github.com/penelopy","followers_url":"https://api.github.com/users/penelopy/followers","following_url":"https://api.github.com/users/penelopy/following{/other_user}","gists_url":"https://api.github.com/users/penelopy/gists{/gist_id}","starred_url":"https://api.github.com/users/penelopy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/penelopy/subscriptions","organizations_url":"https://api.github.com/users/penelopy/orgs","repos_url":"https://api.github.com/users/penelopy/repos","events_url":"https://api.github.com/users/penelopy/events{/privacy}","received_events_url":"https://api.github.com/users/penelopy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/penelopy/bias_impact_project","description":"","fork":false,"url":"https://api.github.com/repos/penelopy/bias_impact_project","forks_url":"https://api.github.com/repos/penelopy/bias_impact_project/forks","keys_url":"https://api.github.com/repos/penelopy/bias_impact_project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/penelopy/bias_impact_project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/penelopy/bias_impact_project/teams","hooks_url":"https://api.github.com/repos/penelopy/bias_impact_project/hooks","issue_events_url":"https://api.github.com/repos/penelopy/bias_impact_project/issues/events{/number}","events_url":"https://api.github.com/repos/penelopy/bias_impact_project/events","assignees_url":"https://api.github.com/repos/penelopy/bias_impact_project/assignees{/user}","branches_url":"https://api.github.com/repos/penelopy/bias_impact_project/branches{/branch}","tags_url":"https://api.github.com/repos/penelopy/bias_impact_project/tags","blobs_url":"https://api.github.com/repos/penelopy/bias_impact_project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/penelopy/bias_impact_project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/penelopy/bias_impact_project/git/refs{/sha}","trees_url":"https://api.github.com/repos/penelopy/bias_impact_project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/penelopy/bias_impact_project/statuses/{sha}","languages_url":"https://api.github.com/repos/penelopy/bias_impact_project/languages","stargazers_url":"https://api.github.com/repos/penelopy/bias_impact_project/stargazers","contributors_url":"https://api.github.com/repos/penelopy/bias_impact_project/contributors","subscribers_url":"https://api.github.com/repos/penelopy/bias_impact_project/subscribers","subscription_url":"https://api.github.com/repos/penelopy/bias_impact_project/subscription","commits_url":"https://api.github.com/repos/penelopy/bias_impact_project/commits{/sha}","git_commits_url":"https://api.github.com/repos/penelopy/bias_impact_project/git/commits{/sha}","comments_url":"https://api.github.com/repos/penelopy/bias_impact_project/comments{/number}","issue_comment_url":"https://api.github.com/repos/penelopy/bias_impact_project/issues/comments{/number}","contents_url":"https://api.github.com/repos/penelopy/bias_impact_project/contents/{+path}","compare_url":"https://api.github.com/repos/penelopy/bias_impact_project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/penelopy/bias_impact_project/merges","archive_url":"https://api.github.com/repos/penelopy/bias_impact_project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/penelopy/bias_impact_project/downloads","issues_url":"https://api.github.com/repos/penelopy/bias_impact_project/issues{/number}","pulls_url":"https://api.github.com/repos/penelopy/bias_impact_project/pulls{/number}","milestones_url":"https://api.github.com/repos/penelopy/bias_impact_project/milestones{/number}","notifications_url":"https://api.github.com/repos/penelopy/bias_impact_project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/penelopy/bias_impact_project/labels{/name}","releases_url":"https://api.github.com/repos/penelopy/bias_impact_project/releases{/id}","created_at":"2015-11-13T00:44:39Z","updated_at":"2015-11-18T19:25:31Z","pushed_at":"2015-11-24T01:59:44Z","git_url":"git://github.com/penelopy/bias_impact_project.git","ssh_url":"git@github.com:penelopy/bias_impact_project.git","clone_url":"https://github.com/penelopy/bias_impact_project.git","svn_url":"https://github.com/penelopy/bias_impact_project","homepage":null,"size":1700,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/penelopy/bias_impact_project/pulls/10"},"html":{"href":"https://github.com/penelopy/bias_impact_project/pull/10"},"issue":{"href":"https://api.github.com/repos/penelopy/bias_impact_project/issues/10"},"comments":{"href":"https://api.github.com/repos/penelopy/bias_impact_project/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/penelopy/bias_impact_project/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/penelopy/bias_impact_project/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/penelopy/bias_impact_project/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/penelopy/bias_impact_project/statuses/487dd17dfddbd4866e5b7bcfa0102cf23d068b2c"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":98,"deletions":62,"changed_files":2}}