{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/45365742","id":45365742,"diff_hunk":"@@ -0,0 +1,123 @@\n+<!-- BEGIN MUNGE: UNVERSIONED_WARNING -->\n+\n+<!-- BEGIN STRIP_FOR_RELEASE -->\n+\n+<img src=\"http://kubernetes.io/img/warning.png\" alt=\"WARNING\"\n+     width=\"25\" height=\"25\">\n+<img src=\"http://kubernetes.io/img/warning.png\" alt=\"WARNING\"\n+     width=\"25\" height=\"25\">\n+<img src=\"http://kubernetes.io/img/warning.png\" alt=\"WARNING\"\n+     width=\"25\" height=\"25\">\n+<img src=\"http://kubernetes.io/img/warning.png\" alt=\"WARNING\"\n+     width=\"25\" height=\"25\">\n+<img src=\"http://kubernetes.io/img/warning.png\" alt=\"WARNING\"\n+     width=\"25\" height=\"25\">\n+\n+<h2>PLEASE NOTE: This document applies to the HEAD of the source tree</h2>\n+\n+If you are using a released version of Kubernetes, you should\n+refer to the docs that go with that version.\n+\n+<strong>\n+The latest release of this document can be found\n+[here](http://releases.k8s.io/release-1.1/docs/proposals/custom-metrics.md).\n+\n+Documentation for other releases can be found at\n+[releases.k8s.io](http://releases.k8s.io).\n+</strong>\n+--\n+\n+<!-- END STRIP_FOR_RELEASE -->\n+\n+<!-- END MUNGE: UNVERSIONED_WARNING -->\n+\n+# Custom Metrics in Kubernetes\n+\n+\n+## Preface\n+\n+Our aim is to create a mechanism in Kubernetes that will allow pods to expose custom metrics, collect them, and make them accessible.\n+Custom metrics are needed by:\n+* horizontal pod autoscaler, for autoscaling the number of pods based on them;\n+* scheduler, for using them in a sophisticated scheduling algorithm;\n+* general monitoring of application health by a user (we are not sure yet whether this should be handled separately, by a different,\n+general monitoring solution, see [#665](https://github.com/kubernetes/heapster/issues/665));\n+* ...\n+\n+\n+## Design\n+\n+For the Kubernetes version 1.2, we plan to implement aggregation of pod custom metrics in Prometheus format by pull.\n+\n+Each pod, to expose custom metrics, will expose a set of Prometheus endpoints.\n+(For version 1.2, we assume that custom metrics are not private information and they are accessible by everyone.\n+In future, we may restrict it by making the endpoints accessible only by kubelet/cAdvisor).\n+CAdvisor will collect metrics from such endpoints of all pods on each node by pulling, and expose them to Heapster.\n+Heapster will:\n+* collect custom metrics from all CAdvisors in the cluster, together with pulling system metrics\n+(for version 1.2: we assume pooling period of ~30 seconds),\n+* store them in a metrics backend (influxDB, Prometheus, Hawkular, GCM, …),","path":"docs/proposals/custom-metrics.md","position":59,"original_position":59,"commit_id":"323e304cff38dc79835211e7e1d5a5e86eedc644","original_commit_id":"323e304cff38dc79835211e7e1d5a5e86eedc644","user":{"login":"ncdc","id":354,"avatar_url":"https://avatars.githubusercontent.com/u/354?v=3","gravatar_id":"","url":"https://api.github.com/users/ncdc","html_url":"https://github.com/ncdc","followers_url":"https://api.github.com/users/ncdc/followers","following_url":"https://api.github.com/users/ncdc/following{/other_user}","gists_url":"https://api.github.com/users/ncdc/gists{/gist_id}","starred_url":"https://api.github.com/users/ncdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncdc/subscriptions","organizations_url":"https://api.github.com/users/ncdc/orgs","repos_url":"https://api.github.com/users/ncdc/repos","events_url":"https://api.github.com/users/ncdc/events{/privacy}","received_events_url":"https://api.github.com/users/ncdc/received_events","type":"User","site_admin":false},"body":"Storing them in a backend isn't strictly required for custom metrics to function, is it?","created_at":"2015-11-19T16:43:36Z","updated_at":"2015-11-19T16:43:36Z","html_url":"https://github.com/kubernetes/kubernetes/pull/17431#discussion_r45365742","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17431","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/45365742"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/17431#discussion_r45365742"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17431"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17431","id":51089076,"html_url":"https://github.com/kubernetes/kubernetes/pull/17431","diff_url":"https://github.com/kubernetes/kubernetes/pull/17431.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/17431.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/17431","number":17431,"state":"open","locked":false,"title":"[WIP] Design proposal for custom metrics.","user":{"login":"jszczepkowski","id":10820769,"avatar_url":"https://avatars.githubusercontent.com/u/10820769?v=3","gravatar_id":"","url":"https://api.github.com/users/jszczepkowski","html_url":"https://github.com/jszczepkowski","followers_url":"https://api.github.com/users/jszczepkowski/followers","following_url":"https://api.github.com/users/jszczepkowski/following{/other_user}","gists_url":"https://api.github.com/users/jszczepkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/jszczepkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jszczepkowski/subscriptions","organizations_url":"https://api.github.com/users/jszczepkowski/orgs","repos_url":"https://api.github.com/users/jszczepkowski/repos","events_url":"https://api.github.com/users/jszczepkowski/events{/privacy}","received_events_url":"https://api.github.com/users/jszczepkowski/received_events","type":"User","site_admin":false},"body":"Design proposal for custom metrics.","created_at":"2015-11-18T14:16:34Z","updated_at":"2015-11-19T16:43:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a9e1e39064890401703f65d78e3be8adf97d2d5","assignee":{"login":"DirectXMan12","id":119737,"avatar_url":"https://avatars.githubusercontent.com/u/119737?v=3","gravatar_id":"","url":"https://api.github.com/users/DirectXMan12","html_url":"https://github.com/DirectXMan12","followers_url":"https://api.github.com/users/DirectXMan12/followers","following_url":"https://api.github.com/users/DirectXMan12/following{/other_user}","gists_url":"https://api.github.com/users/DirectXMan12/gists{/gist_id}","starred_url":"https://api.github.com/users/DirectXMan12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DirectXMan12/subscriptions","organizations_url":"https://api.github.com/users/DirectXMan12/orgs","repos_url":"https://api.github.com/users/DirectXMan12/repos","events_url":"https://api.github.com/users/DirectXMan12/events{/privacy}","received_events_url":"https://api.github.com/users/DirectXMan12/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/15","html_url":"https://github.com/kubernetes/kubernetes/milestones/v1.2","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/15/labels","id":1278499,"number":15,"title":"v1.2","description":"https://github.com/kubernetes/kubernetes/wiki/Release-1.2","creator":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"open_issues":24,"closed_issues":4,"state":"open","created_at":"2015-08-29T03:54:16Z","updated_at":"2015-11-19T01:16:20Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17431/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17431/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/17431/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/323e304cff38dc79835211e7e1d5a5e86eedc644","head":{"label":"jszczepkowski:cm-doc","ref":"cm-doc","sha":"323e304cff38dc79835211e7e1d5a5e86eedc644","user":{"login":"jszczepkowski","id":10820769,"avatar_url":"https://avatars.githubusercontent.com/u/10820769?v=3","gravatar_id":"","url":"https://api.github.com/users/jszczepkowski","html_url":"https://github.com/jszczepkowski","followers_url":"https://api.github.com/users/jszczepkowski/followers","following_url":"https://api.github.com/users/jszczepkowski/following{/other_user}","gists_url":"https://api.github.com/users/jszczepkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/jszczepkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jszczepkowski/subscriptions","organizations_url":"https://api.github.com/users/jszczepkowski/orgs","repos_url":"https://api.github.com/users/jszczepkowski/repos","events_url":"https://api.github.com/users/jszczepkowski/events{/privacy}","received_events_url":"https://api.github.com/users/jszczepkowski/received_events","type":"User","site_admin":false},"repo":{"id":30266090,"name":"kubernetes","full_name":"jszczepkowski/kubernetes","owner":{"login":"jszczepkowski","id":10820769,"avatar_url":"https://avatars.githubusercontent.com/u/10820769?v=3","gravatar_id":"","url":"https://api.github.com/users/jszczepkowski","html_url":"https://github.com/jszczepkowski","followers_url":"https://api.github.com/users/jszczepkowski/followers","following_url":"https://api.github.com/users/jszczepkowski/following{/other_user}","gists_url":"https://api.github.com/users/jszczepkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/jszczepkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jszczepkowski/subscriptions","organizations_url":"https://api.github.com/users/jszczepkowski/orgs","repos_url":"https://api.github.com/users/jszczepkowski/repos","events_url":"https://api.github.com/users/jszczepkowski/events{/privacy}","received_events_url":"https://api.github.com/users/jszczepkowski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jszczepkowski/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/jszczepkowski/kubernetes","forks_url":"https://api.github.com/repos/jszczepkowski/kubernetes/forks","keys_url":"https://api.github.com/repos/jszczepkowski/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jszczepkowski/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jszczepkowski/kubernetes/teams","hooks_url":"https://api.github.com/repos/jszczepkowski/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/jszczepkowski/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/jszczepkowski/kubernetes/events","assignees_url":"https://api.github.com/repos/jszczepkowski/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/jszczepkowski/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/jszczepkowski/kubernetes/tags","blobs_url":"https://api.github.com/repos/jszczepkowski/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jszczepkowski/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jszczepkowski/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/jszczepkowski/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jszczepkowski/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/jszczepkowski/kubernetes/languages","stargazers_url":"https://api.github.com/repos/jszczepkowski/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/jszczepkowski/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/jszczepkowski/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/jszczepkowski/kubernetes/subscription","commits_url":"https://api.github.com/repos/jszczepkowski/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/jszczepkowski/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/jszczepkowski/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/jszczepkowski/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/jszczepkowski/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/jszczepkowski/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jszczepkowski/kubernetes/merges","archive_url":"https://api.github.com/repos/jszczepkowski/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jszczepkowski/kubernetes/downloads","issues_url":"https://api.github.com/repos/jszczepkowski/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/jszczepkowski/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/jszczepkowski/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/jszczepkowski/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jszczepkowski/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/jszczepkowski/kubernetes/releases{/id}","created_at":"2015-02-03T21:42:51Z","updated_at":"2015-02-12T20:51:30Z","pushed_at":"2015-11-19T15:18:23Z","git_url":"git://github.com/jszczepkowski/kubernetes.git","ssh_url":"git@github.com:jszczepkowski/kubernetes.git","clone_url":"https://github.com/jszczepkowski/kubernetes.git","svn_url":"https://github.com/jszczepkowski/kubernetes","homepage":"http://kubernetes.io","size":136697,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"94d9a2f63a59fde8e464cd86b03b9da2f652f6fc","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-11-19T11:20:54Z","pushed_at":"2015-11-19T16:41:34Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":288718,"stargazers_count":11335,"watchers_count":11335,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3003,"mirror_url":null,"open_issues_count":2364,"forks":3003,"open_issues":2364,"watchers":11335,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17431"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/17431"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/17431"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/17431/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17431/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17431/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/323e304cff38dc79835211e7e1d5a5e86eedc644"}}}}