{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/24144639","id":24144639,"diff_hunk":"@@ -0,0 +1,124 @@\n+﻿// Copyright (c) Microsoft Open Technologies, Inc. All rights reserved.\n+// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.\n+\n+using System;\n+using System.Globalization;\n+using System.Net;\n+using System.Text;\n+using System.Threading.Tasks;\n+using Microsoft.AspNet.Razor.Runtime.TagHelpers;\n+using Microsoft.Framework.Logging;\n+\n+namespace Microsoft.AspNet.Mvc.TagHelpers\n+{\n+    /// <summary>\n+    /// <see cref=\"ITagHelper\"/> implementation targeting &lt;script&gt; elements that supports fallback src paths.\n+    /// </summary>\n+    public class ScriptTagHelper : TagHelper\n+    {\n+        private const string FallbackSrcAttributeName = \"asp-fallback-src\";\n+        private const string FallbackTestMethodAttributeName = \"asp-fallback-test\";\n+        private const string SrcAttributeName = \"src\";\n+\n+        // NOTE: All attributes are required for the LinkTagHelper to process.\n+        private static readonly string[] RequiredAttributes = new[]\n+        {\n+            FallbackSrcAttributeName,\n+            FallbackTestMethodAttributeName,\n+        };\n+\n+        /// <summary>\n+        /// The URL of a Script tag to fallback to in the case the primary one fails (as specified in the src\n+        /// attribute).\n+        /// </summary>\n+        [HtmlAttributeName(FallbackSrcAttributeName)]\n+        public string FallbackSrc { get; set; }\n+\n+        /// <summary>\n+        /// The script method defined in the primary script to use for the fallback test.\n+        /// </summary>\n+        [HtmlAttributeName(FallbackTestMethodAttributeName)]\n+        public string FallbackTestMethod { get; set; }\n+\n+        // Protected to ensure subclasses are correctly activated. Internal for ease of use when testing.\n+        [Activate]\n+        protected internal ILogger<ScriptTagHelper> Logger { get; set; }\n+\n+        /// <inheritdoc />\n+        public override async Task ProcessAsync(TagHelperContext context, TagHelperOutput output)\n+        {\n+            // TODO: Consider using the RazorStringWriter instead of a StringBuilder, because Script tags may contain large bodies.\n+\n+            if (!context.AllRequiredAttributesArePresent(RequiredAttributes, Logger))\n+            {\n+                if (Logger.IsEnabled(LogLevel.Verbose))\n+                {\n+                    Logger.WriteVerbose(\"Skipping processing for {0} {1}\", nameof(ScriptTagHelper), context.UniqueId);\n+                }\n+\n+                return;\n+            }\n+\n+            var content = new StringBuilder();\n+\n+            // NOTE: Values in TagHelperOutput.Attributes are already HtmlEncoded\n+\n+            // We've taken over rendering here so prevent the element rendering the outer tag\n+            output.TagName = null;\n+\n+            // Rebuild the <script /> tag.\n+            content.Append(\"<script\");\n+            foreach (var attribute in output.Attributes)\n+            {\n+                content.AppendFormat(CultureInfo.InvariantCulture, \" {0}=\\\"{1}\\\"\", attribute.Key, attribute.Value);\n+            }\n+\n+            content.Append(\">\");\n+\n+            var originalContent = await context.GetChildContentAsync();\n+            content.Append(originalContent);\n+            content.AppendLine(\"</script>\");\n+\n+            // Build the <script /> tag that checks the test method and if it fails, renders the extra script.\n+            content.Append(\"<script>(\");\n+            content.Append(FallbackTestMethod);\n+            content.Append(\" || document.write(\\\"<script\");\n+\n+            if (!output.Attributes.ContainsKey(\"src\"))","path":"src/Microsoft.AspNet.Mvc.TagHelpers/ScriptTagHelper.cs","position":87,"original_position":87,"commit_id":"9d24e47ef981c3db47ae7a16a16868436ff40830","original_commit_id":"9d24e47ef981c3db47ae7a16a16868436ff40830","user":{"login":"yishaigalatzer","id":1238711,"avatar_url":"https://avatars.githubusercontent.com/u/1238711?v=3","gravatar_id":"","url":"https://api.github.com/users/yishaigalatzer","html_url":"https://github.com/yishaigalatzer","followers_url":"https://api.github.com/users/yishaigalatzer/followers","following_url":"https://api.github.com/users/yishaigalatzer/following{/other_user}","gists_url":"https://api.github.com/users/yishaigalatzer/gists{/gist_id}","starred_url":"https://api.github.com/users/yishaigalatzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yishaigalatzer/subscriptions","organizations_url":"https://api.github.com/users/yishaigalatzer/orgs","repos_url":"https://api.github.com/users/yishaigalatzer/repos","events_url":"https://api.github.com/users/yishaigalatzer/events{/privacy}","received_events_url":"https://api.github.com/users/yishaigalatzer/received_events","type":"User","site_admin":false},"body":"why would I make a copy? This is pretty simply iterating and doing one if. Your approached forces an unnecessary copy","created_at":"2015-02-05T05:54:28Z","updated_at":"2015-02-05T05:54:28Z","html_url":"https://github.com/aspnet/Mvc/pull/1959#discussion_r24144639","pull_request_url":"https://api.github.com/repos/aspnet/Mvc/pulls/1959","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/24144639"},"html":{"href":"https://github.com/aspnet/Mvc/pull/1959#discussion_r24144639"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/1959"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Mvc/pulls/1959","id":28687446,"html_url":"https://github.com/aspnet/Mvc/pull/1959","diff_url":"https://github.com/aspnet/Mvc/pull/1959.diff","patch_url":"https://github.com/aspnet/Mvc/pull/1959.patch","issue_url":"https://api.github.com/repos/aspnet/Mvc/issues/1959","number":1959,"state":"open","locked":false,"title":"[Design] Script Tag Helper","user":{"login":"yishaigalatzer","id":1238711,"avatar_url":"https://avatars.githubusercontent.com/u/1238711?v=3","gravatar_id":"","url":"https://api.github.com/users/yishaigalatzer","html_url":"https://github.com/yishaigalatzer","followers_url":"https://api.github.com/users/yishaigalatzer/followers","following_url":"https://api.github.com/users/yishaigalatzer/following{/other_user}","gists_url":"https://api.github.com/users/yishaigalatzer/gists{/gist_id}","starred_url":"https://api.github.com/users/yishaigalatzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yishaigalatzer/subscriptions","organizations_url":"https://api.github.com/users/yishaigalatzer/orgs","repos_url":"https://api.github.com/users/yishaigalatzer/repos","events_url":"https://api.github.com/users/yishaigalatzer/events{/privacy}","received_events_url":"https://api.github.com/users/yishaigalatzer/received_events","type":"User","site_admin":false},"body":"This is the implementation suggestion for ScriptTagHelper/Fallback.\r\n\r\nI did yet go and clean it up 100%, but it does include functional and unit tests. \r\nI'm also testing the logging, and it was useful to flush out issues with the code. If you guys want I can make the private Logger class a Logger<T> that can be reused with other tag helpers.\r\n\r\nDidn't yet try it in a browser, but wanted to get it out for a quick review earlier rather than later.\r\n\r\nResolves #1576\r\n\r\nCC @DamianEdwards @NTaylorMullen ","created_at":"2015-02-04T23:56:45Z","updated_at":"2015-02-05T05:54:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80fd835a8d64f9101747cfa22a24e005004c0e83","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Mvc/pulls/1959/commits","review_comments_url":"https://api.github.com/repos/aspnet/Mvc/pulls/1959/comments","review_comment_url":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/{number}","comments_url":"https://api.github.com/repos/aspnet/Mvc/issues/1959/comments","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/9d24e47ef981c3db47ae7a16a16868436ff40830","head":{"label":"aspnet:ScriptTagHelper","ref":"ScriptTagHelper","sha":"9d24e47ef981c3db47ae7a16a16868436ff40830","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15126429,"name":"Mvc","full_name":"aspnet/Mvc","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Mvc","description":"Model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor.","fork":false,"url":"https://api.github.com/repos/aspnet/Mvc","forks_url":"https://api.github.com/repos/aspnet/Mvc/forks","keys_url":"https://api.github.com/repos/aspnet/Mvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Mvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Mvc/teams","hooks_url":"https://api.github.com/repos/aspnet/Mvc/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Mvc/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Mvc/events","assignees_url":"https://api.github.com/repos/aspnet/Mvc/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Mvc/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Mvc/tags","blobs_url":"https://api.github.com/repos/aspnet/Mvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Mvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Mvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Mvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Mvc/languages","stargazers_url":"https://api.github.com/repos/aspnet/Mvc/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Mvc/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Mvc/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Mvc/subscription","commits_url":"https://api.github.com/repos/aspnet/Mvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Mvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Mvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Mvc/issues/comments/{number}","contents_url":"https://api.github.com/repos/aspnet/Mvc/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Mvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Mvc/merges","archive_url":"https://api.github.com/repos/aspnet/Mvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Mvc/downloads","issues_url":"https://api.github.com/repos/aspnet/Mvc/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Mvc/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Mvc/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Mvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Mvc/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Mvc/releases{/id}","created_at":"2013-12-12T03:54:00Z","updated_at":"2015-02-05T00:42:51Z","pushed_at":"2015-02-05T05:48:28Z","git_url":"git://github.com/aspnet/Mvc.git","ssh_url":"git@github.com:aspnet/Mvc.git","clone_url":"https://github.com/aspnet/Mvc.git","svn_url":"https://github.com/aspnet/Mvc","homepage":"","size":68947,"stargazers_count":1322,"watchers_count":1322,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":386,"mirror_url":null,"open_issues_count":261,"forks":386,"open_issues":261,"watchers":1322,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"19ca77ac2db874d396fbe047ae548db7cc57b76c","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15126429,"name":"Mvc","full_name":"aspnet/Mvc","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Mvc","description":"Model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor.","fork":false,"url":"https://api.github.com/repos/aspnet/Mvc","forks_url":"https://api.github.com/repos/aspnet/Mvc/forks","keys_url":"https://api.github.com/repos/aspnet/Mvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Mvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Mvc/teams","hooks_url":"https://api.github.com/repos/aspnet/Mvc/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Mvc/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Mvc/events","assignees_url":"https://api.github.com/repos/aspnet/Mvc/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Mvc/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Mvc/tags","blobs_url":"https://api.github.com/repos/aspnet/Mvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Mvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Mvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Mvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Mvc/languages","stargazers_url":"https://api.github.com/repos/aspnet/Mvc/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Mvc/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Mvc/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Mvc/subscription","commits_url":"https://api.github.com/repos/aspnet/Mvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Mvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Mvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Mvc/issues/comments/{number}","contents_url":"https://api.github.com/repos/aspnet/Mvc/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Mvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Mvc/merges","archive_url":"https://api.github.com/repos/aspnet/Mvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Mvc/downloads","issues_url":"https://api.github.com/repos/aspnet/Mvc/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Mvc/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Mvc/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Mvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Mvc/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Mvc/releases{/id}","created_at":"2013-12-12T03:54:00Z","updated_at":"2015-02-05T00:42:51Z","pushed_at":"2015-02-05T05:48:28Z","git_url":"git://github.com/aspnet/Mvc.git","ssh_url":"git@github.com:aspnet/Mvc.git","clone_url":"https://github.com/aspnet/Mvc.git","svn_url":"https://github.com/aspnet/Mvc","homepage":"","size":68947,"stargazers_count":1322,"watchers_count":1322,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":386,"mirror_url":null,"open_issues_count":261,"forks":386,"open_issues":261,"watchers":1322,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/1959"},"html":{"href":"https://github.com/aspnet/Mvc/pull/1959"},"issue":{"href":"https://api.github.com/repos/aspnet/Mvc/issues/1959"},"comments":{"href":"https://api.github.com/repos/aspnet/Mvc/issues/1959/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/1959/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/1959/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Mvc/statuses/9d24e47ef981c3db47ae7a16a16868436ff40830"}}}}