{"action":"closed","number":627,"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman-packaging/pulls/627","id":33857811,"html_url":"https://github.com/theforeman/foreman-packaging/pull/627","diff_url":"https://github.com/theforeman/foreman-packaging/pull/627.diff","patch_url":"https://github.com/theforeman/foreman-packaging/pull/627.patch","issue_url":"https://api.github.com/repos/theforeman/foreman-packaging/issues/627","number":627,"state":"closed","locked":false,"title":"Better branched builds with Foreman version macro [rpm]","user":{"login":"domcleal","id":482089,"avatar_url":"https://avatars.githubusercontent.com/u/482089?v=3","gravatar_id":"","url":"https://api.github.com/users/domcleal","html_url":"https://github.com/domcleal","followers_url":"https://api.github.com/users/domcleal/followers","following_url":"https://api.github.com/users/domcleal/following{/other_user}","gists_url":"https://api.github.com/users/domcleal/gists{/gist_id}","starred_url":"https://api.github.com/users/domcleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcleal/subscriptions","organizations_url":"https://api.github.com/users/domcleal/orgs","repos_url":"https://api.github.com/users/domcleal/repos","events_url":"https://api.github.com/users/domcleal/events{/privacy}","received_events_url":"https://api.github.com/users/domcleal/received_events","type":"User","site_admin":false},"body":"Packages (plugins) built on foreman output different binary RPMs due to the\r\nversion of Foreman they're built against, as macros change.  The .fm1_9 string\r\nis put into the release field to differentiate the EVRs, since koji and tito\r\nboth rely on its uniqueness - building the same EVR on rpm/1.8 and rpm/1.7 to\r\nget both 1.8 and 1.7 builds would otherwise not be possible.\r\n\r\n(Consider `rubygem-foreman_docker-1.2.4-1.el7` where %post might have\r\ndifferent behaviour between versions, so `-1.fm1_8.el7` allows both to exist.)\r\n\r\nThis adds a %foremandist macro to foreman-release, which is used in plugin\r\nrelease fields to differentiate them.  It will be added to the buildroots in\r\nkoji so it can be expanded.  (`Release: 1%{?foremandist}%{?dist}`)\r\n\r\nFor tito, the tag_suffix configuration is set so the version number is also\r\nincluded in its git tags for uniqueness across branches.\r\n\r\nThis is a pre-req for our own SCL, as rebuilding packages on multiple branches\r\nwill be common when the SCL configuration differs, instead of retagging.  It\r\nwill perhaps allow us to build most plugins on versioned branches easily rather\r\nthan retagging develop builds to older versions.  [In the same way that deb/* works.]\r\n\r\nAll packages using Foreman at build time have the dist tag added to release.","created_at":"2015-04-22T13:29:03Z","updated_at":"2015-04-23T07:01:58Z","closed_at":"2015-04-23T07:01:58Z","merged_at":"2015-04-23T07:01:58Z","merge_commit_sha":"0c6d1e4797acfda67986feb161375bbb967239ea","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman-packaging/pulls/627/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman-packaging/pulls/627/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman-packaging/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/foreman-packaging/issues/627/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman-packaging/statuses/f1375ed812dbcc51cb9a9a4b0926c72ce80134a1","head":{"label":"domcleal:rpm/develop-tagsuffix","ref":"rpm/develop-tagsuffix","sha":"f1375ed812dbcc51cb9a9a4b0926c72ce80134a1","user":{"login":"domcleal","id":482089,"avatar_url":"https://avatars.githubusercontent.com/u/482089?v=3","gravatar_id":"","url":"https://api.github.com/users/domcleal","html_url":"https://github.com/domcleal","followers_url":"https://api.github.com/users/domcleal/followers","following_url":"https://api.github.com/users/domcleal/following{/other_user}","gists_url":"https://api.github.com/users/domcleal/gists{/gist_id}","starred_url":"https://api.github.com/users/domcleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcleal/subscriptions","organizations_url":"https://api.github.com/users/domcleal/orgs","repos_url":"https://api.github.com/users/domcleal/repos","events_url":"https://api.github.com/users/domcleal/events{/privacy}","received_events_url":"https://api.github.com/users/domcleal/received_events","type":"User","site_admin":false},"repo":{"id":6614082,"name":"foreman-packaging","full_name":"domcleal/foreman-packaging","owner":{"login":"domcleal","id":482089,"avatar_url":"https://avatars.githubusercontent.com/u/482089?v=3","gravatar_id":"","url":"https://api.github.com/users/domcleal","html_url":"https://github.com/domcleal","followers_url":"https://api.github.com/users/domcleal/followers","following_url":"https://api.github.com/users/domcleal/following{/other_user}","gists_url":"https://api.github.com/users/domcleal/gists{/gist_id}","starred_url":"https://api.github.com/users/domcleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcleal/subscriptions","organizations_url":"https://api.github.com/users/domcleal/orgs","repos_url":"https://api.github.com/users/domcleal/repos","events_url":"https://api.github.com/users/domcleal/events{/privacy}","received_events_url":"https://api.github.com/users/domcleal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/domcleal/foreman-packaging","description":"","fork":true,"url":"https://api.github.com/repos/domcleal/foreman-packaging","forks_url":"https://api.github.com/repos/domcleal/foreman-packaging/forks","keys_url":"https://api.github.com/repos/domcleal/foreman-packaging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/domcleal/foreman-packaging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/domcleal/foreman-packaging/teams","hooks_url":"https://api.github.com/repos/domcleal/foreman-packaging/hooks","issue_events_url":"https://api.github.com/repos/domcleal/foreman-packaging/issues/events{/number}","events_url":"https://api.github.com/repos/domcleal/foreman-packaging/events","assignees_url":"https://api.github.com/repos/domcleal/foreman-packaging/assignees{/user}","branches_url":"https://api.github.com/repos/domcleal/foreman-packaging/branches{/branch}","tags_url":"https://api.github.com/repos/domcleal/foreman-packaging/tags","blobs_url":"https://api.github.com/repos/domcleal/foreman-packaging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/domcleal/foreman-packaging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/domcleal/foreman-packaging/git/refs{/sha}","trees_url":"https://api.github.com/repos/domcleal/foreman-packaging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/domcleal/foreman-packaging/statuses/{sha}","languages_url":"https://api.github.com/repos/domcleal/foreman-packaging/languages","stargazers_url":"https://api.github.com/repos/domcleal/foreman-packaging/stargazers","contributors_url":"https://api.github.com/repos/domcleal/foreman-packaging/contributors","subscribers_url":"https://api.github.com/repos/domcleal/foreman-packaging/subscribers","subscription_url":"https://api.github.com/repos/domcleal/foreman-packaging/subscription","commits_url":"https://api.github.com/repos/domcleal/foreman-packaging/commits{/sha}","git_commits_url":"https://api.github.com/repos/domcleal/foreman-packaging/git/commits{/sha}","comments_url":"https://api.github.com/repos/domcleal/foreman-packaging/comments{/number}","issue_comment_url":"https://api.github.com/repos/domcleal/foreman-packaging/issues/comments{/number}","contents_url":"https://api.github.com/repos/domcleal/foreman-packaging/contents/{+path}","compare_url":"https://api.github.com/repos/domcleal/foreman-packaging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/domcleal/foreman-packaging/merges","archive_url":"https://api.github.com/repos/domcleal/foreman-packaging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/domcleal/foreman-packaging/downloads","issues_url":"https://api.github.com/repos/domcleal/foreman-packaging/issues{/number}","pulls_url":"https://api.github.com/repos/domcleal/foreman-packaging/pulls{/number}","milestones_url":"https://api.github.com/repos/domcleal/foreman-packaging/milestones{/number}","notifications_url":"https://api.github.com/repos/domcleal/foreman-packaging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/domcleal/foreman-packaging/labels{/name}","releases_url":"https://api.github.com/repos/domcleal/foreman-packaging/releases{/id}","created_at":"2012-11-09T13:51:29Z","updated_at":"2014-06-24T15:16:29Z","pushed_at":"2015-04-22T13:28:10Z","git_url":"git://github.com/domcleal/foreman-packaging.git","ssh_url":"git@github.com:domcleal/foreman-packaging.git","clone_url":"https://github.com/domcleal/foreman-packaging.git","svn_url":"https://github.com/domcleal/foreman-packaging","homepage":null,"size":11476,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"theforeman:rpm/develop","ref":"rpm/develop","sha":"e5f75c73643ba2af5d48eca4054c1ba65a994312","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":4663237,"name":"foreman-packaging","full_name":"theforeman/foreman-packaging","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/foreman-packaging","description":"Packaging files (RPMs, debs) for Foreman and its dependencies","fork":false,"url":"https://api.github.com/repos/theforeman/foreman-packaging","forks_url":"https://api.github.com/repos/theforeman/foreman-packaging/forks","keys_url":"https://api.github.com/repos/theforeman/foreman-packaging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman-packaging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman-packaging/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman-packaging/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman-packaging/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman-packaging/events","assignees_url":"https://api.github.com/repos/theforeman/foreman-packaging/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman-packaging/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman-packaging/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman-packaging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman-packaging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman-packaging/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman-packaging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman-packaging/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman-packaging/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman-packaging/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman-packaging/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman-packaging/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman-packaging/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman-packaging/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman-packaging/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman-packaging/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman-packaging/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/foreman-packaging/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman-packaging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman-packaging/merges","archive_url":"https://api.github.com/repos/theforeman/foreman-packaging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman-packaging/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman-packaging/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman-packaging/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman-packaging/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman-packaging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman-packaging/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman-packaging/releases{/id}","created_at":"2012-06-14T13:01:07Z","updated_at":"2015-02-24T09:16:34Z","pushed_at":"2015-04-23T07:01:57Z","git_url":"git://github.com/theforeman/foreman-packaging.git","ssh_url":"git@github.com:theforeman/foreman-packaging.git","clone_url":"https://github.com/theforeman/foreman-packaging.git","svn_url":"https://github.com/theforeman/foreman-packaging","homepage":"","size":19650,"stargazers_count":16,"watchers_count":16,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":49,"mirror_url":null,"open_issues_count":11,"forks":49,"open_issues":11,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman-packaging/pulls/627"},"html":{"href":"https://github.com/theforeman/foreman-packaging/pull/627"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman-packaging/issues/627"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman-packaging/issues/627/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman-packaging/pulls/627/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman-packaging/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman-packaging/pulls/627/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman-packaging/statuses/f1375ed812dbcc51cb9a9a4b0926c72ce80134a1"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"domcleal","id":482089,"avatar_url":"https://avatars.githubusercontent.com/u/482089?v=3","gravatar_id":"","url":"https://api.github.com/users/domcleal","html_url":"https://github.com/domcleal","followers_url":"https://api.github.com/users/domcleal/followers","following_url":"https://api.github.com/users/domcleal/following{/other_user}","gists_url":"https://api.github.com/users/domcleal/gists{/gist_id}","starred_url":"https://api.github.com/users/domcleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcleal/subscriptions","organizations_url":"https://api.github.com/users/domcleal/orgs","repos_url":"https://api.github.com/users/domcleal/repos","events_url":"https://api.github.com/users/domcleal/events{/privacy}","received_events_url":"https://api.github.com/users/domcleal/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":1,"additions":15,"deletions":7,"changed_files":9}}