{"action":"closed","number":181,"pull_request":{"url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/pulls/181","id":47389319,"html_url":"https://github.com/lexik/LexikFormFilterBundle/pull/181","diff_url":"https://github.com/lexik/LexikFormFilterBundle/pull/181.diff","patch_url":"https://github.com/lexik/LexikFormFilterBundle/pull/181.patch","issue_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/issues/181","number":181,"state":"closed","locked":false,"title":"Handle timezones in a correct way.","user":{"login":"phjedi","id":14072809,"avatar_url":"https://avatars.githubusercontent.com/u/14072809?v=3","gravatar_id":"","url":"https://api.github.com/users/phjedi","html_url":"https://github.com/phjedi","followers_url":"https://api.github.com/users/phjedi/followers","following_url":"https://api.github.com/users/phjedi/following{/other_user}","gists_url":"https://api.github.com/users/phjedi/gists{/gist_id}","starred_url":"https://api.github.com/users/phjedi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phjedi/subscriptions","organizations_url":"https://api.github.com/users/phjedi/orgs","repos_url":"https://api.github.com/users/phjedi/repos","events_url":"https://api.github.com/users/phjedi/events{/privacy}","received_events_url":"https://api.github.com/users/phjedi/received_events","type":"User","site_admin":false},"body":"Hi guys.\r\nIt looks like you omitted Symfony2 form options like 'model_timezone' and 'view_timezone' using the next chunk of code:\r\n\r\n```php\r\n    protected function convertToSqlDate($date, $isMax = false)\r\n    {\r\n        if (! $date instanceof \\DateTime) {\r\n            return;\r\n        }\r\n\r\n        if ($isMax) {\r\n            $date->setTime(23, 59, 59);\r\n        } else {\r\n            $date->setTime(0, 0, 0);\r\n        }\r\n\r\n        return $this->expr()->literal($date->format(self::SQL_DATE_TIME));\r\n    }\r\n```\r\n\r\nWe kindly ask you to replace it with something like this one:\r\n\r\n```php\r\n    protected function convertToSqlDate($date, $isMax = false)\r\n    {\r\n        if (! $date instanceof \\DateTime) {\r\n            return;\r\n        }\r\n\r\n        if ($isMax) {\r\n            $date->modify('+1 day -1 second');\r\n        }\r\n\r\n        return $this->expr()->literal($date->format(self::SQL_DATE_TIME));\r\n    }\r\n```\r\n\r\nIt should handle timezones in a correct way.\r\n","created_at":"2015-10-12T06:47:23Z","updated_at":"2015-10-20T12:46:11Z","closed_at":"2015-10-20T12:46:11Z","merged_at":"2015-10-20T12:46:11Z","merge_commit_sha":"6d98e5702bfd1e364c05b5c36a5ee453b0ec6309","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/pulls/181/commits","review_comments_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/pulls/181/comments","review_comment_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/issues/181/comments","statuses_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/statuses/047b7d39681848a4c311988cfba6758a43dcc548","head":{"label":"phjedi:master","ref":"master","sha":"047b7d39681848a4c311988cfba6758a43dcc548","user":{"login":"phjedi","id":14072809,"avatar_url":"https://avatars.githubusercontent.com/u/14072809?v=3","gravatar_id":"","url":"https://api.github.com/users/phjedi","html_url":"https://github.com/phjedi","followers_url":"https://api.github.com/users/phjedi/followers","following_url":"https://api.github.com/users/phjedi/following{/other_user}","gists_url":"https://api.github.com/users/phjedi/gists{/gist_id}","starred_url":"https://api.github.com/users/phjedi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phjedi/subscriptions","organizations_url":"https://api.github.com/users/phjedi/orgs","repos_url":"https://api.github.com/users/phjedi/repos","events_url":"https://api.github.com/users/phjedi/events{/privacy}","received_events_url":"https://api.github.com/users/phjedi/received_events","type":"User","site_admin":false},"repo":{"id":42102854,"name":"LexikFormFilterBundle","full_name":"phjedi/LexikFormFilterBundle","owner":{"login":"phjedi","id":14072809,"avatar_url":"https://avatars.githubusercontent.com/u/14072809?v=3","gravatar_id":"","url":"https://api.github.com/users/phjedi","html_url":"https://github.com/phjedi","followers_url":"https://api.github.com/users/phjedi/followers","following_url":"https://api.github.com/users/phjedi/following{/other_user}","gists_url":"https://api.github.com/users/phjedi/gists{/gist_id}","starred_url":"https://api.github.com/users/phjedi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phjedi/subscriptions","organizations_url":"https://api.github.com/users/phjedi/orgs","repos_url":"https://api.github.com/users/phjedi/repos","events_url":"https://api.github.com/users/phjedi/events{/privacy}","received_events_url":"https://api.github.com/users/phjedi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/phjedi/LexikFormFilterBundle","description":"This Symfony2 bundle aim to provide classes to build some form filters and then build a doctrine query from this form filter.","fork":true,"url":"https://api.github.com/repos/phjedi/LexikFormFilterBundle","forks_url":"https://api.github.com/repos/phjedi/LexikFormFilterBundle/forks","keys_url":"https://api.github.com/repos/phjedi/LexikFormFilterBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phjedi/LexikFormFilterBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phjedi/LexikFormFilterBundle/teams","hooks_url":"https://api.github.com/repos/phjedi/LexikFormFilterBundle/hooks","issue_events_url":"https://api.github.com/repos/phjedi/LexikFormFilterBundle/issues/events{/number}","events_url":"https://api.github.com/repos/phjedi/LexikFormFilterBundle/events","assignees_url":"https://api.github.com/repos/phjedi/LexikFormFilterBundle/assignees{/user}","branches_url":"https://api.github.com/repos/phjedi/LexikFormFilterBundle/branches{/branch}","tags_url":"https://api.github.com/repos/phjedi/LexikFormFilterBundle/tags","blobs_url":"https://api.github.com/repos/phjedi/LexikFormFilterBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phjedi/LexikFormFilterBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phjedi/LexikFormFilterBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/phjedi/LexikFormFilterBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phjedi/LexikFormFilterBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/phjedi/LexikFormFilterBundle/languages","stargazers_url":"https://api.github.com/repos/phjedi/LexikFormFilterBundle/stargazers","contributors_url":"https://api.github.com/repos/phjedi/LexikFormFilterBundle/contributors","subscribers_url":"https://api.github.com/repos/phjedi/LexikFormFilterBundle/subscribers","subscription_url":"https://api.github.com/repos/phjedi/LexikFormFilterBundle/subscription","commits_url":"https://api.github.com/repos/phjedi/LexikFormFilterBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/phjedi/LexikFormFilterBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/phjedi/LexikFormFilterBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/phjedi/LexikFormFilterBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/phjedi/LexikFormFilterBundle/contents/{+path}","compare_url":"https://api.github.com/repos/phjedi/LexikFormFilterBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phjedi/LexikFormFilterBundle/merges","archive_url":"https://api.github.com/repos/phjedi/LexikFormFilterBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phjedi/LexikFormFilterBundle/downloads","issues_url":"https://api.github.com/repos/phjedi/LexikFormFilterBundle/issues{/number}","pulls_url":"https://api.github.com/repos/phjedi/LexikFormFilterBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/phjedi/LexikFormFilterBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/phjedi/LexikFormFilterBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phjedi/LexikFormFilterBundle/labels{/name}","releases_url":"https://api.github.com/repos/phjedi/LexikFormFilterBundle/releases{/id}","created_at":"2015-09-08T09:28:22Z","updated_at":"2015-09-08T09:28:22Z","pushed_at":"2015-10-20T07:23:01Z","git_url":"git://github.com/phjedi/LexikFormFilterBundle.git","ssh_url":"git@github.com:phjedi/LexikFormFilterBundle.git","clone_url":"https://github.com/phjedi/LexikFormFilterBundle.git","svn_url":"https://github.com/phjedi/LexikFormFilterBundle","homepage":"","size":723,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lexik:master","ref":"master","sha":"8e54a41376eab7890d4deea4088ad5c86df964ee","user":{"login":"lexik","id":568486,"avatar_url":"https://avatars.githubusercontent.com/u/568486?v=3","gravatar_id":"","url":"https://api.github.com/users/lexik","html_url":"https://github.com/lexik","followers_url":"https://api.github.com/users/lexik/followers","following_url":"https://api.github.com/users/lexik/following{/other_user}","gists_url":"https://api.github.com/users/lexik/gists{/gist_id}","starred_url":"https://api.github.com/users/lexik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lexik/subscriptions","organizations_url":"https://api.github.com/users/lexik/orgs","repos_url":"https://api.github.com/users/lexik/repos","events_url":"https://api.github.com/users/lexik/events{/privacy}","received_events_url":"https://api.github.com/users/lexik/received_events","type":"Organization","site_admin":false},"repo":{"id":2898956,"name":"LexikFormFilterBundle","full_name":"lexik/LexikFormFilterBundle","owner":{"login":"lexik","id":568486,"avatar_url":"https://avatars.githubusercontent.com/u/568486?v=3","gravatar_id":"","url":"https://api.github.com/users/lexik","html_url":"https://github.com/lexik","followers_url":"https://api.github.com/users/lexik/followers","following_url":"https://api.github.com/users/lexik/following{/other_user}","gists_url":"https://api.github.com/users/lexik/gists{/gist_id}","starred_url":"https://api.github.com/users/lexik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lexik/subscriptions","organizations_url":"https://api.github.com/users/lexik/orgs","repos_url":"https://api.github.com/users/lexik/repos","events_url":"https://api.github.com/users/lexik/events{/privacy}","received_events_url":"https://api.github.com/users/lexik/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lexik/LexikFormFilterBundle","description":"This Symfony2 bundle aim to provide classes to build some form filters and then build a doctrine query from this form filter.","fork":false,"url":"https://api.github.com/repos/lexik/LexikFormFilterBundle","forks_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/forks","keys_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/teams","hooks_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/hooks","issue_events_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/issues/events{/number}","events_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/events","assignees_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/assignees{/user}","branches_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/branches{/branch}","tags_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/tags","blobs_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/languages","stargazers_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/stargazers","contributors_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/contributors","subscribers_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/subscribers","subscription_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/subscription","commits_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/contents/{+path}","compare_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/merges","archive_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/downloads","issues_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/issues{/number}","pulls_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/labels{/name}","releases_url":"https://api.github.com/repos/lexik/LexikFormFilterBundle/releases{/id}","created_at":"2011-12-02T14:32:00Z","updated_at":"2015-10-16T14:23:20Z","pushed_at":"2015-10-20T12:46:10Z","git_url":"git://github.com/lexik/LexikFormFilterBundle.git","ssh_url":"git@github.com:lexik/LexikFormFilterBundle.git","clone_url":"https://github.com/lexik/LexikFormFilterBundle.git","svn_url":"https://github.com/lexik/LexikFormFilterBundle","homepage":"","size":1390,"stargazers_count":191,"watchers_count":191,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":67,"mirror_url":null,"open_issues_count":23,"forks":67,"open_issues":23,"watchers":191,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lexik/LexikFormFilterBundle/pulls/181"},"html":{"href":"https://github.com/lexik/LexikFormFilterBundle/pull/181"},"issue":{"href":"https://api.github.com/repos/lexik/LexikFormFilterBundle/issues/181"},"comments":{"href":"https://api.github.com/repos/lexik/LexikFormFilterBundle/issues/181/comments"},"review_comments":{"href":"https://api.github.com/repos/lexik/LexikFormFilterBundle/pulls/181/comments"},"review_comment":{"href":"https://api.github.com/repos/lexik/LexikFormFilterBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lexik/LexikFormFilterBundle/pulls/181/commits"},"statuses":{"href":"https://api.github.com/repos/lexik/LexikFormFilterBundle/statuses/047b7d39681848a4c311988cfba6758a43dcc548"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"cedric-g","id":570306,"avatar_url":"https://avatars.githubusercontent.com/u/570306?v=3","gravatar_id":"","url":"https://api.github.com/users/cedric-g","html_url":"https://github.com/cedric-g","followers_url":"https://api.github.com/users/cedric-g/followers","following_url":"https://api.github.com/users/cedric-g/following{/other_user}","gists_url":"https://api.github.com/users/cedric-g/gists{/gist_id}","starred_url":"https://api.github.com/users/cedric-g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cedric-g/subscriptions","organizations_url":"https://api.github.com/users/cedric-g/orgs","repos_url":"https://api.github.com/users/cedric-g/repos","events_url":"https://api.github.com/users/cedric-g/events{/privacy}","received_events_url":"https://api.github.com/users/cedric-g/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":3,"additions":38,"deletions":3,"changed_files":4}}