{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc/pulls/comments/35612731","id":35612731,"diff_hunk":"@@ -64,6 +64,7 @@ struct SslServerCredentialsOptions {\n   };\n   grpc::string pem_root_certs;\n   std::vector<PemKeyCertPair> pem_key_cert_pairs;\n+  bool force_client_auth;","path":"include/grpc++/server_credentials.h","position":12,"original_position":4,"commit_id":"36fab90026e3c5cef3c83e8359c79c4c714a9230","original_commit_id":"5029b30d1ce8509a4b2f7c17e88bddb8a5206f56","user":{"login":"jboeuf","id":6262765,"avatar_url":"https://avatars.githubusercontent.com/u/6262765?v=3","gravatar_id":"","url":"https://api.github.com/users/jboeuf","html_url":"https://github.com/jboeuf","followers_url":"https://api.github.com/users/jboeuf/followers","following_url":"https://api.github.com/users/jboeuf/following{/other_user}","gists_url":"https://api.github.com/users/jboeuf/gists{/gist_id}","starred_url":"https://api.github.com/users/jboeuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jboeuf/subscriptions","organizations_url":"https://api.github.com/users/jboeuf/orgs","repos_url":"https://api.github.com/users/jboeuf/repos","events_url":"https://api.github.com/users/jboeuf/events{/privacy}","received_events_url":"https://api.github.com/users/jboeuf/received_events","type":"User","site_admin":false},"body":"Good catch, thanks! fixed.","created_at":"2015-07-28T04:05:32Z","updated_at":"2015-07-28T04:05:32Z","html_url":"https://github.com/grpc/grpc/pull/2598#discussion_r35612731","pull_request_url":"https://api.github.com/repos/grpc/grpc/pulls/2598","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments/35612731"},"html":{"href":"https://github.com/grpc/grpc/pull/2598#discussion_r35612731"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc/pulls/2598"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/2598","id":40533009,"html_url":"https://github.com/grpc/grpc/pull/2598","diff_url":"https://github.com/grpc/grpc/pull/2598.diff","patch_url":"https://github.com/grpc/grpc/pull/2598.patch","issue_url":"https://api.github.com/repos/grpc/grpc/issues/2598","number":2598,"state":"open","locked":false,"title":" Adding option to force client auth on the server SSL creds.","user":{"login":"jboeuf","id":6262765,"avatar_url":"https://avatars.githubusercontent.com/u/6262765?v=3","gravatar_id":"","url":"https://api.github.com/users/jboeuf","html_url":"https://github.com/jboeuf","followers_url":"https://api.github.com/users/jboeuf/followers","following_url":"https://api.github.com/users/jboeuf/following{/other_user}","gists_url":"https://api.github.com/users/jboeuf/gists{/gist_id}","starred_url":"https://api.github.com/users/jboeuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jboeuf/subscriptions","organizations_url":"https://api.github.com/users/jboeuf/orgs","repos_url":"https://api.github.com/users/jboeuf/repos","events_url":"https://api.github.com/users/jboeuf/events{/privacy}","received_events_url":"https://api.github.com/users/jboeuf/received_events","type":"User","site_admin":false},"body":"Addresses #2527. \r\n@jtattermusch @murgatroid99 @tbetbetbe @nathanielmanistaatgoogle should have a look at how to expose this new options for the wrapped languages.","created_at":"2015-07-22T06:06:43Z","updated_at":"2015-07-28T04:05:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70ab185e0cbe650306b89956386c594ae6d6237c","assignee":{"login":"yang-g","id":10122250,"avatar_url":"https://avatars.githubusercontent.com/u/10122250?v=3","gravatar_id":"","url":"https://api.github.com/users/yang-g","html_url":"https://github.com/yang-g","followers_url":"https://api.github.com/users/yang-g/followers","following_url":"https://api.github.com/users/yang-g/following{/other_user}","gists_url":"https://api.github.com/users/yang-g/gists{/gist_id}","starred_url":"https://api.github.com/users/yang-g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yang-g/subscriptions","organizations_url":"https://api.github.com/users/yang-g/orgs","repos_url":"https://api.github.com/users/yang-g/repos","events_url":"https://api.github.com/users/yang-g/events{/privacy}","received_events_url":"https://api.github.com/users/yang-g/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/grpc/grpc/milestones/25","html_url":"https://github.com/grpc/grpc/milestones/Beta","labels_url":"https://api.github.com/repos/grpc/grpc/milestones/25/labels","id":1134869,"number":25,"title":"Beta","description":"","creator":{"login":"ctiller","id":10120821,"avatar_url":"https://avatars.githubusercontent.com/u/10120821?v=3","gravatar_id":"","url":"https://api.github.com/users/ctiller","html_url":"https://github.com/ctiller","followers_url":"https://api.github.com/users/ctiller/followers","following_url":"https://api.github.com/users/ctiller/following{/other_user}","gists_url":"https://api.github.com/users/ctiller/gists{/gist_id}","starred_url":"https://api.github.com/users/ctiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctiller/subscriptions","organizations_url":"https://api.github.com/users/ctiller/orgs","repos_url":"https://api.github.com/users/ctiller/repos","events_url":"https://api.github.com/users/ctiller/events{/privacy}","received_events_url":"https://api.github.com/users/ctiller/received_events","type":"User","site_admin":false},"open_issues":246,"closed_issues":166,"state":"open","created_at":"2015-05-26T22:29:20Z","updated_at":"2015-07-27T23:46:00Z","due_on":"2015-07-31T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/grpc/grpc/pulls/2598/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc/pulls/2598/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/2598/comments","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/36fab90026e3c5cef3c83e8359c79c4c714a9230","head":{"label":"jboeuf:ssl_force_client_auth","ref":"ssl_force_client_auth","sha":"36fab90026e3c5cef3c83e8359c79c4c714a9230","user":{"login":"jboeuf","id":6262765,"avatar_url":"https://avatars.githubusercontent.com/u/6262765?v=3","gravatar_id":"","url":"https://api.github.com/users/jboeuf","html_url":"https://github.com/jboeuf","followers_url":"https://api.github.com/users/jboeuf/followers","following_url":"https://api.github.com/users/jboeuf/following{/other_user}","gists_url":"https://api.github.com/users/jboeuf/gists{/gist_id}","starred_url":"https://api.github.com/users/jboeuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jboeuf/subscriptions","organizations_url":"https://api.github.com/users/jboeuf/orgs","repos_url":"https://api.github.com/users/jboeuf/repos","events_url":"https://api.github.com/users/jboeuf/events{/privacy}","received_events_url":"https://api.github.com/users/jboeuf/received_events","type":"User","site_admin":false},"repo":{"id":31395432,"name":"grpc","full_name":"jboeuf/grpc","owner":{"login":"jboeuf","id":6262765,"avatar_url":"https://avatars.githubusercontent.com/u/6262765?v=3","gravatar_id":"","url":"https://api.github.com/users/jboeuf","html_url":"https://github.com/jboeuf","followers_url":"https://api.github.com/users/jboeuf/followers","following_url":"https://api.github.com/users/jboeuf/following{/other_user}","gists_url":"https://api.github.com/users/jboeuf/gists{/gist_id}","starred_url":"https://api.github.com/users/jboeuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jboeuf/subscriptions","organizations_url":"https://api.github.com/users/jboeuf/orgs","repos_url":"https://api.github.com/users/jboeuf/repos","events_url":"https://api.github.com/users/jboeuf/events{/privacy}","received_events_url":"https://api.github.com/users/jboeuf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jboeuf/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":true,"url":"https://api.github.com/repos/jboeuf/grpc","forks_url":"https://api.github.com/repos/jboeuf/grpc/forks","keys_url":"https://api.github.com/repos/jboeuf/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jboeuf/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jboeuf/grpc/teams","hooks_url":"https://api.github.com/repos/jboeuf/grpc/hooks","issue_events_url":"https://api.github.com/repos/jboeuf/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/jboeuf/grpc/events","assignees_url":"https://api.github.com/repos/jboeuf/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/jboeuf/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/jboeuf/grpc/tags","blobs_url":"https://api.github.com/repos/jboeuf/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jboeuf/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jboeuf/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/jboeuf/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jboeuf/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/jboeuf/grpc/languages","stargazers_url":"https://api.github.com/repos/jboeuf/grpc/stargazers","contributors_url":"https://api.github.com/repos/jboeuf/grpc/contributors","subscribers_url":"https://api.github.com/repos/jboeuf/grpc/subscribers","subscription_url":"https://api.github.com/repos/jboeuf/grpc/subscription","commits_url":"https://api.github.com/repos/jboeuf/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/jboeuf/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/jboeuf/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/jboeuf/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/jboeuf/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/jboeuf/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jboeuf/grpc/merges","archive_url":"https://api.github.com/repos/jboeuf/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jboeuf/grpc/downloads","issues_url":"https://api.github.com/repos/jboeuf/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/jboeuf/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/jboeuf/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/jboeuf/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jboeuf/grpc/labels{/name}","releases_url":"https://api.github.com/repos/jboeuf/grpc/releases{/id}","created_at":"2015-02-27T00:06:25Z","updated_at":"2015-05-07T17:46:36Z","pushed_at":"2015-07-28T04:02:53Z","git_url":"git://github.com/jboeuf/grpc.git","ssh_url":"git@github.com:jboeuf/grpc.git","clone_url":"https://github.com/jboeuf/grpc.git","svn_url":"https://github.com/jboeuf/grpc","homepage":"","size":37754,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"374f31832a2aef8c78d1fe45d3bfd67d7e3cdeb9","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729880,"name":"grpc","full_name":"grpc/grpc","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":false,"url":"https://api.github.com/repos/grpc/grpc","forks_url":"https://api.github.com/repos/grpc/grpc/forks","keys_url":"https://api.github.com/repos/grpc/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc/teams","hooks_url":"https://api.github.com/repos/grpc/grpc/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc/events","assignees_url":"https://api.github.com/repos/grpc/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc/tags","blobs_url":"https://api.github.com/repos/grpc/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc/subscription","commits_url":"https://api.github.com/repos/grpc/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc/merges","archive_url":"https://api.github.com/repos/grpc/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc/downloads","issues_url":"https://api.github.com/repos/grpc/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc/releases{/id}","created_at":"2014-12-08T18:58:53Z","updated_at":"2015-07-28T02:44:59Z","pushed_at":"2015-07-28T04:02:54Z","git_url":"git://github.com/grpc/grpc.git","ssh_url":"git@github.com:grpc/grpc.git","clone_url":"https://github.com/grpc/grpc.git","svn_url":"https://github.com/grpc/grpc","homepage":"","size":150429,"stargazers_count":2932,"watchers_count":2932,"language":"C","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":427,"mirror_url":null,"open_issues_count":430,"forks":427,"open_issues":430,"watchers":2932,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/2598"},"html":{"href":"https://github.com/grpc/grpc/pull/2598"},"issue":{"href":"https://api.github.com/repos/grpc/grpc/issues/2598"},"comments":{"href":"https://api.github.com/repos/grpc/grpc/issues/2598/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc/pulls/2598/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc/pulls/2598/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc/statuses/36fab90026e3c5cef3c83e8359c79c4c714a9230"}}}}