{"action":"created","comment":{"url":"https://api.github.com/repos/iine/iiname/pulls/comments/42748935","id":42748935,"diff_hunk":"@@ -10,9 +10,14 @@ class NamesControllerTest < ActionController::TestCase\n     assert_response :success\n   end\n \n-  test \"should concat params and return as keyword\" do\n+  # test \"should concat params and return as keyword\" do\n+  #   get :suggestion, @params\n+  #   assert_equal @params[:names].join(\"\"), JSON.parse(response.body)[\"keyword\"]\n+  # end\n+\n+  test \"should search book title and return as keyword\" do\n     get :suggestion, @params\n-    assert_equal @params[:names].join(\"\"), JSON.parse(response.body)[\"keyword\"]\n+    assert_equal \"British Logic in the Nineteenth Century\", JSON.parse(response.body)[\"keyword\"]","path":"test/controllers/names_controller_test.rb","position":13,"original_position":13,"commit_id":"7e41dcf36dbc28106b1659dc215804d611781baf","original_commit_id":"7e41dcf36dbc28106b1659dc215804d611781baf","user":{"login":"chrhsmt","id":33445,"avatar_url":"https://avatars.githubusercontent.com/u/33445?v=3","gravatar_id":"","url":"https://api.github.com/users/chrhsmt","html_url":"https://github.com/chrhsmt","followers_url":"https://api.github.com/users/chrhsmt/followers","following_url":"https://api.github.com/users/chrhsmt/following{/other_user}","gists_url":"https://api.github.com/users/chrhsmt/gists{/gist_id}","starred_url":"https://api.github.com/users/chrhsmt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrhsmt/subscriptions","organizations_url":"https://api.github.com/users/chrhsmt/orgs","repos_url":"https://api.github.com/users/chrhsmt/repos","events_url":"https://api.github.com/users/chrhsmt/events{/privacy}","received_events_url":"https://api.github.com/users/chrhsmt/received_events","type":"User","site_admin":false},"body":"rakuten api にネットワークアクセスしそうな気がするので、ネットワークをスタブ・モック化してテストしたいところですが、難しそうであれば、一旦マージしたあとに別途対応とかしたですね。","created_at":"2015-10-22T13:45:24Z","updated_at":"2015-10-22T13:45:24Z","html_url":"https://github.com/iine/iiname/pull/28#discussion_r42748935","pull_request_url":"https://api.github.com/repos/iine/iiname/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/iine/iiname/pulls/comments/42748935"},"html":{"href":"https://github.com/iine/iiname/pull/28#discussion_r42748935"},"pull_request":{"href":"https://api.github.com/repos/iine/iiname/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/iine/iiname/pulls/28","id":48194450,"html_url":"https://github.com/iine/iiname/pull/28","diff_url":"https://github.com/iine/iiname/pull/28.diff","patch_url":"https://github.com/iine/iiname/pull/28.patch","issue_url":"https://api.github.com/repos/iine/iiname/issues/28","number":28,"state":"open","locked":false,"title":"web apiでの検索","user":{"login":"kinchan33","id":12641064,"avatar_url":"https://avatars.githubusercontent.com/u/12641064?v=3","gravatar_id":"","url":"https://api.github.com/users/kinchan33","html_url":"https://github.com/kinchan33","followers_url":"https://api.github.com/users/kinchan33/followers","following_url":"https://api.github.com/users/kinchan33/following{/other_user}","gists_url":"https://api.github.com/users/kinchan33/gists{/gist_id}","starred_url":"https://api.github.com/users/kinchan33/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinchan33/subscriptions","organizations_url":"https://api.github.com/users/kinchan33/orgs","repos_url":"https://api.github.com/users/kinchan33/repos","events_url":"https://api.github.com/users/kinchan33/events{/privacy}","received_events_url":"https://api.github.com/users/kinchan33/received_events","type":"User","site_admin":false},"body":"テストコードを修正したのと、Travisのトークンを設定しました。\r\nどうでしょう？","created_at":"2015-10-20T12:37:10Z","updated_at":"2015-10-22T13:45:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25282b85a4fce6b50099e1357458be9a4f948f71","assignee":{"login":"kinchan33","id":12641064,"avatar_url":"https://avatars.githubusercontent.com/u/12641064?v=3","gravatar_id":"","url":"https://api.github.com/users/kinchan33","html_url":"https://github.com/kinchan33","followers_url":"https://api.github.com/users/kinchan33/followers","following_url":"https://api.github.com/users/kinchan33/following{/other_user}","gists_url":"https://api.github.com/users/kinchan33/gists{/gist_id}","starred_url":"https://api.github.com/users/kinchan33/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinchan33/subscriptions","organizations_url":"https://api.github.com/users/kinchan33/orgs","repos_url":"https://api.github.com/users/kinchan33/repos","events_url":"https://api.github.com/users/kinchan33/events{/privacy}","received_events_url":"https://api.github.com/users/kinchan33/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/iine/iiname/pulls/28/commits","review_comments_url":"https://api.github.com/repos/iine/iiname/pulls/28/comments","review_comment_url":"https://api.github.com/repos/iine/iiname/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iine/iiname/issues/28/comments","statuses_url":"https://api.github.com/repos/iine/iiname/statuses/7e41dcf36dbc28106b1659dc215804d611781baf","head":{"label":"iine:feature/webapi","ref":"feature/webapi","sha":"7e41dcf36dbc28106b1659dc215804d611781baf","user":{"login":"iine","id":14807746,"avatar_url":"https://avatars.githubusercontent.com/u/14807746?v=3","gravatar_id":"","url":"https://api.github.com/users/iine","html_url":"https://github.com/iine","followers_url":"https://api.github.com/users/iine/followers","following_url":"https://api.github.com/users/iine/following{/other_user}","gists_url":"https://api.github.com/users/iine/gists{/gist_id}","starred_url":"https://api.github.com/users/iine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iine/subscriptions","organizations_url":"https://api.github.com/users/iine/orgs","repos_url":"https://api.github.com/users/iine/repos","events_url":"https://api.github.com/users/iine/events{/privacy}","received_events_url":"https://api.github.com/users/iine/received_events","type":"Organization","site_admin":false},"repo":{"id":43013399,"name":"iiname","full_name":"iine/iiname","owner":{"login":"iine","id":14807746,"avatar_url":"https://avatars.githubusercontent.com/u/14807746?v=3","gravatar_id":"","url":"https://api.github.com/users/iine","html_url":"https://github.com/iine","followers_url":"https://api.github.com/users/iine/followers","following_url":"https://api.github.com/users/iine/following{/other_user}","gists_url":"https://api.github.com/users/iine/gists{/gist_id}","starred_url":"https://api.github.com/users/iine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iine/subscriptions","organizations_url":"https://api.github.com/users/iine/orgs","repos_url":"https://api.github.com/users/iine/repos","events_url":"https://api.github.com/users/iine/events{/privacy}","received_events_url":"https://api.github.com/users/iine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iine/iiname","description":"","fork":false,"url":"https://api.github.com/repos/iine/iiname","forks_url":"https://api.github.com/repos/iine/iiname/forks","keys_url":"https://api.github.com/repos/iine/iiname/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iine/iiname/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iine/iiname/teams","hooks_url":"https://api.github.com/repos/iine/iiname/hooks","issue_events_url":"https://api.github.com/repos/iine/iiname/issues/events{/number}","events_url":"https://api.github.com/repos/iine/iiname/events","assignees_url":"https://api.github.com/repos/iine/iiname/assignees{/user}","branches_url":"https://api.github.com/repos/iine/iiname/branches{/branch}","tags_url":"https://api.github.com/repos/iine/iiname/tags","blobs_url":"https://api.github.com/repos/iine/iiname/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iine/iiname/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iine/iiname/git/refs{/sha}","trees_url":"https://api.github.com/repos/iine/iiname/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iine/iiname/statuses/{sha}","languages_url":"https://api.github.com/repos/iine/iiname/languages","stargazers_url":"https://api.github.com/repos/iine/iiname/stargazers","contributors_url":"https://api.github.com/repos/iine/iiname/contributors","subscribers_url":"https://api.github.com/repos/iine/iiname/subscribers","subscription_url":"https://api.github.com/repos/iine/iiname/subscription","commits_url":"https://api.github.com/repos/iine/iiname/commits{/sha}","git_commits_url":"https://api.github.com/repos/iine/iiname/git/commits{/sha}","comments_url":"https://api.github.com/repos/iine/iiname/comments{/number}","issue_comment_url":"https://api.github.com/repos/iine/iiname/issues/comments{/number}","contents_url":"https://api.github.com/repos/iine/iiname/contents/{+path}","compare_url":"https://api.github.com/repos/iine/iiname/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iine/iiname/merges","archive_url":"https://api.github.com/repos/iine/iiname/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iine/iiname/downloads","issues_url":"https://api.github.com/repos/iine/iiname/issues{/number}","pulls_url":"https://api.github.com/repos/iine/iiname/pulls{/number}","milestones_url":"https://api.github.com/repos/iine/iiname/milestones{/number}","notifications_url":"https://api.github.com/repos/iine/iiname/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iine/iiname/labels{/name}","releases_url":"https://api.github.com/repos/iine/iiname/releases{/id}","created_at":"2015-09-23T16:33:50Z","updated_at":"2015-10-22T08:25:59Z","pushed_at":"2015-10-21T07:05:57Z","git_url":"git://github.com/iine/iiname.git","ssh_url":"git@github.com:iine/iiname.git","clone_url":"https://github.com/iine/iiname.git","svn_url":"https://github.com/iine/iiname","homepage":"","size":1300,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":1,"default_branch":"master"}},"base":{"label":"iine:master","ref":"master","sha":"ca8f607f7910739adcbe9fef7b07a71cdd7fd8f3","user":{"login":"iine","id":14807746,"avatar_url":"https://avatars.githubusercontent.com/u/14807746?v=3","gravatar_id":"","url":"https://api.github.com/users/iine","html_url":"https://github.com/iine","followers_url":"https://api.github.com/users/iine/followers","following_url":"https://api.github.com/users/iine/following{/other_user}","gists_url":"https://api.github.com/users/iine/gists{/gist_id}","starred_url":"https://api.github.com/users/iine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iine/subscriptions","organizations_url":"https://api.github.com/users/iine/orgs","repos_url":"https://api.github.com/users/iine/repos","events_url":"https://api.github.com/users/iine/events{/privacy}","received_events_url":"https://api.github.com/users/iine/received_events","type":"Organization","site_admin":false},"repo":{"id":43013399,"name":"iiname","full_name":"iine/iiname","owner":{"login":"iine","id":14807746,"avatar_url":"https://avatars.githubusercontent.com/u/14807746?v=3","gravatar_id":"","url":"https://api.github.com/users/iine","html_url":"https://github.com/iine","followers_url":"https://api.github.com/users/iine/followers","following_url":"https://api.github.com/users/iine/following{/other_user}","gists_url":"https://api.github.com/users/iine/gists{/gist_id}","starred_url":"https://api.github.com/users/iine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iine/subscriptions","organizations_url":"https://api.github.com/users/iine/orgs","repos_url":"https://api.github.com/users/iine/repos","events_url":"https://api.github.com/users/iine/events{/privacy}","received_events_url":"https://api.github.com/users/iine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iine/iiname","description":"","fork":false,"url":"https://api.github.com/repos/iine/iiname","forks_url":"https://api.github.com/repos/iine/iiname/forks","keys_url":"https://api.github.com/repos/iine/iiname/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iine/iiname/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iine/iiname/teams","hooks_url":"https://api.github.com/repos/iine/iiname/hooks","issue_events_url":"https://api.github.com/repos/iine/iiname/issues/events{/number}","events_url":"https://api.github.com/repos/iine/iiname/events","assignees_url":"https://api.github.com/repos/iine/iiname/assignees{/user}","branches_url":"https://api.github.com/repos/iine/iiname/branches{/branch}","tags_url":"https://api.github.com/repos/iine/iiname/tags","blobs_url":"https://api.github.com/repos/iine/iiname/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iine/iiname/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iine/iiname/git/refs{/sha}","trees_url":"https://api.github.com/repos/iine/iiname/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iine/iiname/statuses/{sha}","languages_url":"https://api.github.com/repos/iine/iiname/languages","stargazers_url":"https://api.github.com/repos/iine/iiname/stargazers","contributors_url":"https://api.github.com/repos/iine/iiname/contributors","subscribers_url":"https://api.github.com/repos/iine/iiname/subscribers","subscription_url":"https://api.github.com/repos/iine/iiname/subscription","commits_url":"https://api.github.com/repos/iine/iiname/commits{/sha}","git_commits_url":"https://api.github.com/repos/iine/iiname/git/commits{/sha}","comments_url":"https://api.github.com/repos/iine/iiname/comments{/number}","issue_comment_url":"https://api.github.com/repos/iine/iiname/issues/comments{/number}","contents_url":"https://api.github.com/repos/iine/iiname/contents/{+path}","compare_url":"https://api.github.com/repos/iine/iiname/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iine/iiname/merges","archive_url":"https://api.github.com/repos/iine/iiname/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iine/iiname/downloads","issues_url":"https://api.github.com/repos/iine/iiname/issues{/number}","pulls_url":"https://api.github.com/repos/iine/iiname/pulls{/number}","milestones_url":"https://api.github.com/repos/iine/iiname/milestones{/number}","notifications_url":"https://api.github.com/repos/iine/iiname/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iine/iiname/labels{/name}","releases_url":"https://api.github.com/repos/iine/iiname/releases{/id}","created_at":"2015-09-23T16:33:50Z","updated_at":"2015-10-22T08:25:59Z","pushed_at":"2015-10-21T07:05:57Z","git_url":"git://github.com/iine/iiname.git","ssh_url":"git@github.com:iine/iiname.git","clone_url":"https://github.com/iine/iiname.git","svn_url":"https://github.com/iine/iiname","homepage":"","size":1300,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iine/iiname/pulls/28"},"html":{"href":"https://github.com/iine/iiname/pull/28"},"issue":{"href":"https://api.github.com/repos/iine/iiname/issues/28"},"comments":{"href":"https://api.github.com/repos/iine/iiname/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/iine/iiname/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/iine/iiname/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iine/iiname/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/iine/iiname/statuses/7e41dcf36dbc28106b1659dc215804d611781baf"}}}}