{"action":"created","comment":{"url":"https://api.github.com/repos/cockroachdb/c-rocksdb/pulls/comments/29161092","id":29161092,"diff_hunk":"@@ -5,8 +5,8 @@ package rocksdb\n \n // #cgo CPPFLAGS: -Iinternal -Iinternal/include -Iinternal/db -Iinternal/util\n // #cgo CPPFLAGS: -Iinternal/utilities/merge_operators/string_append\n-// #cgo CPPFLAGS: -I../c-snappy/internal\n-// #cgo CPPFLAGS: -DROCKSDB_PLATFORM_POSIX -DNDEBUG -DSNAPPY\n+// #cgo CPPFLAGS: -I../c-snappy/internal -I../c-lz4/internal/lib","path":"cgo_flags.go","position":6,"original_position":6,"commit_id":"fea4feba0786cc98eed2fe38cbad3fc04b382c0b","original_commit_id":"fea4feba0786cc98eed2fe38cbad3fc04b382c0b","user":{"login":"bdarnell","id":160562,"avatar_url":"https://avatars.githubusercontent.com/u/160562?v=3","gravatar_id":"","url":"https://api.github.com/users/bdarnell","html_url":"https://github.com/bdarnell","followers_url":"https://api.github.com/users/bdarnell/followers","following_url":"https://api.github.com/users/bdarnell/following{/other_user}","gists_url":"https://api.github.com/users/bdarnell/gists{/gist_id}","starred_url":"https://api.github.com/users/bdarnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdarnell/subscriptions","organizations_url":"https://api.github.com/users/bdarnell/orgs","repos_url":"https://api.github.com/users/bdarnell/repos","events_url":"https://api.github.com/users/bdarnell/events{/privacy}","received_events_url":"https://api.github.com/users/bdarnell/received_events","type":"User","site_admin":false},"body":"Don't we need to add c-lz4 to the glockfile first?","created_at":"2015-04-27T16:07:32Z","updated_at":"2015-04-27T16:07:32Z","html_url":"https://github.com/cockroachdb/c-rocksdb/pull/3#discussion_r29161092","pull_request_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/c-rocksdb/pulls/comments/29161092"},"html":{"href":"https://github.com/cockroachdb/c-rocksdb/pull/3#discussion_r29161092"},"pull_request":{"href":"https://api.github.com/repos/cockroachdb/c-rocksdb/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/cockroachdb/c-rocksdb/pulls/3","id":34183209,"html_url":"https://github.com/cockroachdb/c-rocksdb/pull/3","diff_url":"https://github.com/cockroachdb/c-rocksdb/pull/3.diff","patch_url":"https://github.com/cockroachdb/c-rocksdb/pull/3.patch","issue_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/issues/3","number":3,"state":"open","locked":false,"title":"Enable LZ4 support.","user":{"login":"petermattis","id":6201335,"avatar_url":"https://avatars.githubusercontent.com/u/6201335?v=3","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false},"body":"LZ4 is supposed to be faster than Snappy.","created_at":"2015-04-27T15:59:39Z","updated_at":"2015-04-27T16:07:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ac6edb149a4d80b5fbcfd6e9a520f1ba8d6ac6a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/pulls/3/commits","review_comments_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/pulls/3/comments","review_comment_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/issues/3/comments","statuses_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/statuses/fea4feba0786cc98eed2fe38cbad3fc04b382c0b","head":{"label":"cockroachdb:pmattis/lz4","ref":"pmattis/lz4","sha":"fea4feba0786cc98eed2fe38cbad3fc04b382c0b","user":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":31278623,"name":"c-rocksdb","full_name":"cockroachdb/c-rocksdb","owner":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockroachdb/c-rocksdb","description":"","fork":false,"url":"https://api.github.com/repos/cockroachdb/c-rocksdb","forks_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/forks","keys_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/teams","hooks_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/events","assignees_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/tags","blobs_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/subscription","commits_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/merges","archive_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/downloads","issues_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/releases{/id}","created_at":"2015-02-24T19:51:05Z","updated_at":"2015-04-27T13:31:46Z","pushed_at":"2015-04-27T15:59:39Z","git_url":"git://github.com/cockroachdb/c-rocksdb.git","ssh_url":"git@github.com:cockroachdb/c-rocksdb.git","clone_url":"https://github.com/cockroachdb/c-rocksdb.git","svn_url":"https://github.com/cockroachdb/c-rocksdb","homepage":null,"size":2395,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"cockroachdb:master","ref":"master","sha":"e34a11209d37a442e4e69158e1712e8834f87259","user":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":31278623,"name":"c-rocksdb","full_name":"cockroachdb/c-rocksdb","owner":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockroachdb/c-rocksdb","description":"","fork":false,"url":"https://api.github.com/repos/cockroachdb/c-rocksdb","forks_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/forks","keys_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/teams","hooks_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/events","assignees_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/tags","blobs_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/subscription","commits_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/merges","archive_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/downloads","issues_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/c-rocksdb/releases{/id}","created_at":"2015-02-24T19:51:05Z","updated_at":"2015-04-27T13:31:46Z","pushed_at":"2015-04-27T15:59:39Z","git_url":"git://github.com/cockroachdb/c-rocksdb.git","ssh_url":"git@github.com:cockroachdb/c-rocksdb.git","clone_url":"https://github.com/cockroachdb/c-rocksdb.git","svn_url":"https://github.com/cockroachdb/c-rocksdb","homepage":null,"size":2395,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/c-rocksdb/pulls/3"},"html":{"href":"https://github.com/cockroachdb/c-rocksdb/pull/3"},"issue":{"href":"https://api.github.com/repos/cockroachdb/c-rocksdb/issues/3"},"comments":{"href":"https://api.github.com/repos/cockroachdb/c-rocksdb/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/cockroachdb/c-rocksdb/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/cockroachdb/c-rocksdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockroachdb/c-rocksdb/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/cockroachdb/c-rocksdb/statuses/fea4feba0786cc98eed2fe38cbad3fc04b382c0b"}}}}