{"action":"created","comment":{"url":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/comments/30979104","id":30979104,"diff_hunk":"@@ -166,6 +166,11 @@ trait ItcTable extends Table {\n \n   }\n \n+  // lacking a simple way to decide on the \"closest\" (i.e. \"fastest to reach\") peer we talk to the observing peer\n+  // if defined and GN or GS otherwise, if no site is defined you're out of luck and the ITC tables will stay empty\n+  protected def itcServicePeer: Option[Peer] =\n+    ObservingPeer.get orElse ObservingPeer.peerFor(Site.GN) orElse ObservingPeer.peerFor(Site.GS) orElse None","path":"bundle/jsky.app.ot/src/main/scala/jsky/app/ot/editor/seq/ItcTable.scala","position":16,"original_position":16,"commit_id":"291b4dbf67ed7430e0ace73782e5bd21382762b6","original_commit_id":"fc0aa720fc0dd8822b348771d4c3d4e918198807","user":{"login":"swalker2m","id":4906023,"avatar_url":"https://avatars.githubusercontent.com/u/4906023?v=3","gravatar_id":"","url":"https://api.github.com/users/swalker2m","html_url":"https://github.com/swalker2m","followers_url":"https://api.github.com/users/swalker2m/followers","following_url":"https://api.github.com/users/swalker2m/following{/other_user}","gists_url":"https://api.github.com/users/swalker2m/gists{/gist_id}","starred_url":"https://api.github.com/users/swalker2m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swalker2m/subscriptions","organizations_url":"https://api.github.com/users/swalker2m/orgs","repos_url":"https://api.github.com/users/swalker2m/repos","events_url":"https://api.github.com/users/swalker2m/events{/privacy}","received_events_url":"https://api.github.com/users/swalker2m/received_events","type":"User","site_admin":false},"body":"This seems good to me though ending with `orElse None` is superfluous. That's what you get anyway if none of the others were defined. Should be harmless though. I'll go ahead and merge this one so it can be included in the test release today.","created_at":"2015-05-25T13:14:02Z","updated_at":"2015-05-25T13:14:02Z","html_url":"https://github.com/gemini-hlsw/ocs/pull/423#discussion_r30979104","pull_request_url":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/423","_links":{"self":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/comments/30979104"},"html":{"href":"https://github.com/gemini-hlsw/ocs/pull/423#discussion_r30979104"},"pull_request":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/423"}}},"pull_request":{"url":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/423","id":36096286,"html_url":"https://github.com/gemini-hlsw/ocs/pull/423","diff_url":"https://github.com/gemini-hlsw/ocs/pull/423.diff","patch_url":"https://github.com/gemini-hlsw/ocs/pull/423.patch","issue_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/423","number":423,"state":"open","locked":false,"title":"OCSADV-348: Use observing peer or GN or GS for ITC calls","user":{"login":"fnussber","id":7856060,"avatar_url":"https://avatars.githubusercontent.com/u/7856060?v=3","gravatar_id":"","url":"https://api.github.com/users/fnussber","html_url":"https://github.com/fnussber","followers_url":"https://api.github.com/users/fnussber/followers","following_url":"https://api.github.com/users/fnussber/following{/other_user}","gists_url":"https://api.github.com/users/fnussber/gists{/gist_id}","starred_url":"https://api.github.com/users/fnussber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fnussber/subscriptions","organizations_url":"https://api.github.com/users/fnussber/orgs","repos_url":"https://api.github.com/users/fnussber/repos","events_url":"https://api.github.com/users/fnussber/events{/privacy}","received_events_url":"https://api.github.com/users/fnussber/received_events","type":"User","site_admin":false},"body":"Some users don't have an observing peer defined, for those we fall back to GN or GS (in this order) as the peer to be used for ITC service calls.\r\n\r\nThis is a bit lame, but turns out it is reasonably difficult to check for a \"fastest to reach\" peer in a more or less reliable way. I think this deserves a better and more general solution but for the June release I am afraid this is as good as it gets.\r\n\r\n(I just had a discussion with Andy and we decided to run some load tests against gnodbtest2 on Tuesday to get  a better feel for the CPU load that we're creating with the ITC service calls. Depending on how that works out we might also distribute the calls randomly between GN and GS.)","created_at":"2015-05-24T00:53:24Z","updated_at":"2015-05-25T13:14:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ac35e68ec500f2945838060dec9cef2b511db83","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/423/commits","review_comments_url":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/423/comments","review_comment_url":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/423/comments","statuses_url":"https://api.github.com/repos/gemini-hlsw/ocs/statuses/291b4dbf67ed7430e0ace73782e5bd21382762b6","head":{"label":"fnussber:feature/OCSADV-348","ref":"feature/OCSADV-348","sha":"291b4dbf67ed7430e0ace73782e5bd21382762b6","user":{"login":"fnussber","id":7856060,"avatar_url":"https://avatars.githubusercontent.com/u/7856060?v=3","gravatar_id":"","url":"https://api.github.com/users/fnussber","html_url":"https://github.com/fnussber","followers_url":"https://api.github.com/users/fnussber/followers","following_url":"https://api.github.com/users/fnussber/following{/other_user}","gists_url":"https://api.github.com/users/fnussber/gists{/gist_id}","starred_url":"https://api.github.com/users/fnussber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fnussber/subscriptions","organizations_url":"https://api.github.com/users/fnussber/orgs","repos_url":"https://api.github.com/users/fnussber/repos","events_url":"https://api.github.com/users/fnussber/events{/privacy}","received_events_url":"https://api.github.com/users/fnussber/received_events","type":"User","site_admin":false},"repo":{"id":23975511,"name":"ocs","full_name":"fnussber/ocs","owner":{"login":"fnussber","id":7856060,"avatar_url":"https://avatars.githubusercontent.com/u/7856060?v=3","gravatar_id":"","url":"https://api.github.com/users/fnussber","html_url":"https://github.com/fnussber","followers_url":"https://api.github.com/users/fnussber/followers","following_url":"https://api.github.com/users/fnussber/following{/other_user}","gists_url":"https://api.github.com/users/fnussber/gists{/gist_id}","starred_url":"https://api.github.com/users/fnussber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fnussber/subscriptions","organizations_url":"https://api.github.com/users/fnussber/orgs","repos_url":"https://api.github.com/users/fnussber/repos","events_url":"https://api.github.com/users/fnussber/events{/privacy}","received_events_url":"https://api.github.com/users/fnussber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fnussber/ocs","description":"Gemini's Observatory Control System","fork":true,"url":"https://api.github.com/repos/fnussber/ocs","forks_url":"https://api.github.com/repos/fnussber/ocs/forks","keys_url":"https://api.github.com/repos/fnussber/ocs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fnussber/ocs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fnussber/ocs/teams","hooks_url":"https://api.github.com/repos/fnussber/ocs/hooks","issue_events_url":"https://api.github.com/repos/fnussber/ocs/issues/events{/number}","events_url":"https://api.github.com/repos/fnussber/ocs/events","assignees_url":"https://api.github.com/repos/fnussber/ocs/assignees{/user}","branches_url":"https://api.github.com/repos/fnussber/ocs/branches{/branch}","tags_url":"https://api.github.com/repos/fnussber/ocs/tags","blobs_url":"https://api.github.com/repos/fnussber/ocs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fnussber/ocs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fnussber/ocs/git/refs{/sha}","trees_url":"https://api.github.com/repos/fnussber/ocs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fnussber/ocs/statuses/{sha}","languages_url":"https://api.github.com/repos/fnussber/ocs/languages","stargazers_url":"https://api.github.com/repos/fnussber/ocs/stargazers","contributors_url":"https://api.github.com/repos/fnussber/ocs/contributors","subscribers_url":"https://api.github.com/repos/fnussber/ocs/subscribers","subscription_url":"https://api.github.com/repos/fnussber/ocs/subscription","commits_url":"https://api.github.com/repos/fnussber/ocs/commits{/sha}","git_commits_url":"https://api.github.com/repos/fnussber/ocs/git/commits{/sha}","comments_url":"https://api.github.com/repos/fnussber/ocs/comments{/number}","issue_comment_url":"https://api.github.com/repos/fnussber/ocs/issues/comments{/number}","contents_url":"https://api.github.com/repos/fnussber/ocs/contents/{+path}","compare_url":"https://api.github.com/repos/fnussber/ocs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fnussber/ocs/merges","archive_url":"https://api.github.com/repos/fnussber/ocs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fnussber/ocs/downloads","issues_url":"https://api.github.com/repos/fnussber/ocs/issues{/number}","pulls_url":"https://api.github.com/repos/fnussber/ocs/pulls{/number}","milestones_url":"https://api.github.com/repos/fnussber/ocs/milestones{/number}","notifications_url":"https://api.github.com/repos/fnussber/ocs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fnussber/ocs/labels{/name}","releases_url":"https://api.github.com/repos/fnussber/ocs/releases{/id}","created_at":"2014-09-12T20:20:20Z","updated_at":"2015-05-08T20:15:23Z","pushed_at":"2015-05-24T20:22:19Z","git_url":"git://github.com/fnussber/ocs.git","ssh_url":"git@github.com:fnussber/ocs.git","clone_url":"https://github.com/fnussber/ocs.git","svn_url":"https://github.com/fnussber/ocs","homepage":"","size":264426,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"gemini-hlsw:develop","ref":"develop","sha":"3bea91de61f88c5a37ef017f481d98ed0ab6f533","user":{"login":"gemini-hlsw","id":8593735,"avatar_url":"https://avatars.githubusercontent.com/u/8593735?v=3","gravatar_id":"","url":"https://api.github.com/users/gemini-hlsw","html_url":"https://github.com/gemini-hlsw","followers_url":"https://api.github.com/users/gemini-hlsw/followers","following_url":"https://api.github.com/users/gemini-hlsw/following{/other_user}","gists_url":"https://api.github.com/users/gemini-hlsw/gists{/gist_id}","starred_url":"https://api.github.com/users/gemini-hlsw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemini-hlsw/subscriptions","organizations_url":"https://api.github.com/users/gemini-hlsw/orgs","repos_url":"https://api.github.com/users/gemini-hlsw/repos","events_url":"https://api.github.com/users/gemini-hlsw/events{/privacy}","received_events_url":"https://api.github.com/users/gemini-hlsw/received_events","type":"Organization","site_admin":false},"repo":{"id":23963494,"name":"ocs","full_name":"gemini-hlsw/ocs","owner":{"login":"gemini-hlsw","id":8593735,"avatar_url":"https://avatars.githubusercontent.com/u/8593735?v=3","gravatar_id":"","url":"https://api.github.com/users/gemini-hlsw","html_url":"https://github.com/gemini-hlsw","followers_url":"https://api.github.com/users/gemini-hlsw/followers","following_url":"https://api.github.com/users/gemini-hlsw/following{/other_user}","gists_url":"https://api.github.com/users/gemini-hlsw/gists{/gist_id}","starred_url":"https://api.github.com/users/gemini-hlsw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemini-hlsw/subscriptions","organizations_url":"https://api.github.com/users/gemini-hlsw/orgs","repos_url":"https://api.github.com/users/gemini-hlsw/repos","events_url":"https://api.github.com/users/gemini-hlsw/events{/privacy}","received_events_url":"https://api.github.com/users/gemini-hlsw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gemini-hlsw/ocs","description":"Observatory Control Software","fork":false,"url":"https://api.github.com/repos/gemini-hlsw/ocs","forks_url":"https://api.github.com/repos/gemini-hlsw/ocs/forks","keys_url":"https://api.github.com/repos/gemini-hlsw/ocs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gemini-hlsw/ocs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gemini-hlsw/ocs/teams","hooks_url":"https://api.github.com/repos/gemini-hlsw/ocs/hooks","issue_events_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/events{/number}","events_url":"https://api.github.com/repos/gemini-hlsw/ocs/events","assignees_url":"https://api.github.com/repos/gemini-hlsw/ocs/assignees{/user}","branches_url":"https://api.github.com/repos/gemini-hlsw/ocs/branches{/branch}","tags_url":"https://api.github.com/repos/gemini-hlsw/ocs/tags","blobs_url":"https://api.github.com/repos/gemini-hlsw/ocs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gemini-hlsw/ocs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gemini-hlsw/ocs/git/refs{/sha}","trees_url":"https://api.github.com/repos/gemini-hlsw/ocs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gemini-hlsw/ocs/statuses/{sha}","languages_url":"https://api.github.com/repos/gemini-hlsw/ocs/languages","stargazers_url":"https://api.github.com/repos/gemini-hlsw/ocs/stargazers","contributors_url":"https://api.github.com/repos/gemini-hlsw/ocs/contributors","subscribers_url":"https://api.github.com/repos/gemini-hlsw/ocs/subscribers","subscription_url":"https://api.github.com/repos/gemini-hlsw/ocs/subscription","commits_url":"https://api.github.com/repos/gemini-hlsw/ocs/commits{/sha}","git_commits_url":"https://api.github.com/repos/gemini-hlsw/ocs/git/commits{/sha}","comments_url":"https://api.github.com/repos/gemini-hlsw/ocs/comments{/number}","issue_comment_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/comments{/number}","contents_url":"https://api.github.com/repos/gemini-hlsw/ocs/contents/{+path}","compare_url":"https://api.github.com/repos/gemini-hlsw/ocs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gemini-hlsw/ocs/merges","archive_url":"https://api.github.com/repos/gemini-hlsw/ocs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gemini-hlsw/ocs/downloads","issues_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues{/number}","pulls_url":"https://api.github.com/repos/gemini-hlsw/ocs/pulls{/number}","milestones_url":"https://api.github.com/repos/gemini-hlsw/ocs/milestones{/number}","notifications_url":"https://api.github.com/repos/gemini-hlsw/ocs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gemini-hlsw/ocs/labels{/name}","releases_url":"https://api.github.com/repos/gemini-hlsw/ocs/releases{/id}","created_at":"2014-09-12T14:20:23Z","updated_at":"2015-05-08T19:43:56Z","pushed_at":"2015-05-25T12:56:39Z","git_url":"git://github.com/gemini-hlsw/ocs.git","ssh_url":"git@github.com:gemini-hlsw/ocs.git","clone_url":"https://github.com/gemini-hlsw/ocs.git","svn_url":"https://github.com/gemini-hlsw/ocs","homepage":"","size":272543,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":4,"forks":10,"open_issues":4,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/423"},"html":{"href":"https://github.com/gemini-hlsw/ocs/pull/423"},"issue":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/issues/423"},"comments":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/issues/423/comments"},"review_comments":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/423/comments"},"review_comment":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/423/commits"},"statuses":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/statuses/291b4dbf67ed7430e0ace73782e5bd21382762b6"}}}}