{"action":"created","issue":{"url":"https://api.github.com/repos/pelias/leaflet-geocoder/issues/12","labels_url":"https://api.github.com/repos/pelias/leaflet-geocoder/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/pelias/leaflet-geocoder/issues/12/comments","events_url":"https://api.github.com/repos/pelias/leaflet-geocoder/issues/12/events","html_url":"https://github.com/pelias/leaflet-geocoder/issues/12","id":96636789,"number":12,"title":"Rename/clarify terminology","user":{"login":"riordan","id":227472,"avatar_url":"https://avatars.githubusercontent.com/u/227472?v=3","gravatar_id":"","url":"https://api.github.com/users/riordan","html_url":"https://github.com/riordan","followers_url":"https://api.github.com/users/riordan/followers","following_url":"https://api.github.com/users/riordan/following{/other_user}","gists_url":"https://api.github.com/users/riordan/gists{/gist_id}","starred_url":"https://api.github.com/users/riordan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riordan/subscriptions","organizations_url":"https://api.github.com/users/riordan/orgs","repos_url":"https://api.github.com/users/riordan/repos","events_url":"https://api.github.com/users/riordan/events{/privacy}","received_events_url":"https://api.github.com/users/riordan/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/pelias/leaflet-geocoder/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/pelias/leaflet-geocoder/labels/question","name":"question","color":"cc317c"}],"state":"open","locked":false,"assignee":{"login":"riordan","id":227472,"avatar_url":"https://avatars.githubusercontent.com/u/227472?v=3","gravatar_id":"","url":"https://api.github.com/users/riordan","html_url":"https://github.com/riordan","followers_url":"https://api.github.com/users/riordan/followers","following_url":"https://api.github.com/users/riordan/following{/other_user}","gists_url":"https://api.github.com/users/riordan/gists{/gist_id}","starred_url":"https://api.github.com/users/riordan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riordan/subscriptions","organizations_url":"https://api.github.com/users/riordan/orgs","repos_url":"https://api.github.com/users/riordan/repos","events_url":"https://api.github.com/users/riordan/events{/privacy}","received_events_url":"https://api.github.com/users/riordan/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-07-22T18:43:34Z","updated_at":"2015-08-24T22:42:38Z","closed_at":null,"body":"Lots of colloquial terms\r\n- `drop pin`\r\n-`pan to point`\r\n- `full_width`\r\n- `expanded`\r\n- `hide_other_controls`\r\n\r\nHow might we make these (and other) terms clearer?"},"comment":{"url":"https://api.github.com/repos/pelias/leaflet-geocoder/issues/comments/134402350","html_url":"https://github.com/pelias/leaflet-geocoder/issues/12#issuecomment-134402350","issue_url":"https://api.github.com/repos/pelias/leaflet-geocoder/issues/12","id":134402350,"user":{"login":"louh","id":2553268,"avatar_url":"https://avatars.githubusercontent.com/u/2553268?v=3","gravatar_id":"","url":"https://api.github.com/users/louh","html_url":"https://github.com/louh","followers_url":"https://api.github.com/users/louh/followers","following_url":"https://api.github.com/users/louh/following{/other_user}","gists_url":"https://api.github.com/users/louh/gists{/gist_id}","starred_url":"https://api.github.com/users/louh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louh/subscriptions","organizations_url":"https://api.github.com/users/louh/orgs","repos_url":"https://api.github.com/users/louh/repos","events_url":"https://api.github.com/users/louh/events{/privacy}","received_events_url":"https://api.github.com/users/louh/received_events","type":"User","site_admin":false},"created_at":"2015-08-24T22:42:38Z","updated_at":"2015-08-24T22:42:38Z","body":"I changed some of these in v1\r\n\r\n- `dropPin` is changed to `markers` - for no reason other than to match the terminology Leaflet uses.\r\n- `hide_other_controls` is removed. The more I think about it, the more I think this isn't the purview of the library to force that particular UX opinion on users, especially since it's a blunt force solution: we don't know exactly what we're hiding, only that other controls (from Leaflet or other libraries) might exist and they should all go away, dammit. I think what we ought to do is recognize that whoever is responsible for integrating the plugin needs to make their own decisions (and write their own code) about what controls are visible and what's not, and when to do it.\r\n\r\nOptions still using the same terminology:\r\n- `full_width` is renamed `fullWidth` to correspond with Leaflet standards on using camelCase names, but the words are still the same\r\n- `expanded` is unchanged so far\r\n\r\n\r\n\r\n"}}