{"action":"created","issue":{"url":"https://api.github.com/repos/jwhitlock/web-platform-compat/issues/30","labels_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/issues/30/labels{/name}","comments_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/issues/30/comments","events_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/issues/30/events","html_url":"https://github.com/jwhitlock/web-platform-compat/pull/30","id":58218123,"number":30,"title":"bug 1134587","user":{"login":"trevorhobson","id":1900587,"avatar_url":"https://avatars.githubusercontent.com/u/1900587?v=3","gravatar_id":"","url":"https://api.github.com/users/trevorhobson","html_url":"https://github.com/trevorhobson","followers_url":"https://api.github.com/users/trevorhobson/followers","following_url":"https://api.github.com/users/trevorhobson/following{/other_user}","gists_url":"https://api.github.com/users/trevorhobson/gists{/gist_id}","starred_url":"https://api.github.com/users/trevorhobson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevorhobson/subscriptions","organizations_url":"https://api.github.com/users/trevorhobson/orgs","repos_url":"https://api.github.com/users/trevorhobson/repos","events_url":"https://api.github.com/users/trevorhobson/events{/privacy}","received_events_url":"https://api.github.com/users/trevorhobson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-02-19T14:54:51Z","updated_at":"2015-02-20T00:12:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jwhitlock/web-platform-compat/pulls/30","html_url":"https://github.com/jwhitlock/web-platform-compat/pull/30","diff_url":"https://github.com/jwhitlock/web-platform-compat/pull/30.diff","patch_url":"https://github.com/jwhitlock/web-platform-compat/pull/30.patch"},"body":"- Add support for CompatGeckoFxOS to scraper"},"comment":{"url":"https://api.github.com/repos/jwhitlock/web-platform-compat/issues/comments/75166493","html_url":"https://github.com/jwhitlock/web-platform-compat/pull/30#issuecomment-75166493","issue_url":"https://api.github.com/repos/jwhitlock/web-platform-compat/issues/30","id":75166493,"user":{"login":"trevorhobson","id":1900587,"avatar_url":"https://avatars.githubusercontent.com/u/1900587?v=3","gravatar_id":"","url":"https://api.github.com/users/trevorhobson","html_url":"https://github.com/trevorhobson","followers_url":"https://api.github.com/users/trevorhobson/followers","following_url":"https://api.github.com/users/trevorhobson/following{/other_user}","gists_url":"https://api.github.com/users/trevorhobson/gists{/gist_id}","starred_url":"https://api.github.com/users/trevorhobson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevorhobson/subscriptions","organizations_url":"https://api.github.com/users/trevorhobson/orgs","repos_url":"https://api.github.com/users/trevorhobson/repos","events_url":"https://api.github.com/users/trevorhobson/events{/privacy}","received_events_url":"https://api.github.com/users/trevorhobson/received_events","type":"User","site_admin":false},"created_at":"2015-02-20T00:12:34Z","updated_at":"2015-02-20T00:12:34Z","body":"> There is code here that isn't reflected in CompatGeckoFxOS, such as Gecko versions for 2.0, 2.1. Are you sure about this?\r\n\r\nYes. On the off chance that someone uses this for a recent release before the scrape and replace is done.\r\n\r\n> Should CompatGeckoFxOS be updated?\r\n\r\nPossibly, but I hope no. It should probably be deleted, but like others of its kind it is a time issue to remove. The Gecko version is less relevant now that most product version numbers and Gecko version numbers match and the Firefox OS for developers pages link to the Firefox for developers pages it is easier to determine what features are available that it was when the version numbers did not match.\r\n\r\n> Should it detect non-integer Gecko versions as well?\r\n\r\nI made the assumption that there was a good reason for using a float in the handling of CompatGeckoDesktop, so I copied that. Strictly speaking it should do the same check for low Gecko versions that CompatGeckoDesktop does to make sure that the version is a valid one, but as we do not check against a strict list of valid Gecko versions after 5 in CompatGeckoDesktop and others I don't think the risk is too high here. We have handled incorrect Gecko versions after 5 on MDN by ignoring the decimal, so we treat 5.0.1.4.5.6 as if it was 5."}}