{"action":"created","issue":{"url":"https://api.github.com/repos/PX4/Firmware/issues/2978","labels_url":"https://api.github.com/repos/PX4/Firmware/issues/2978/labels{/name}","comments_url":"https://api.github.com/repos/PX4/Firmware/issues/2978/comments","events_url":"https://api.github.com/repos/PX4/Firmware/issues/2978/events","html_url":"https://github.com/PX4/Firmware/pull/2978","id":110969861,"number":2978,"title":"CMake Windows Fixes","user":{"login":"dagar","id":84712,"avatar_url":"https://avatars.githubusercontent.com/u/84712?v=3","gravatar_id":"","url":"https://api.github.com/users/dagar","html_url":"https://github.com/dagar","followers_url":"https://api.github.com/users/dagar/followers","following_url":"https://api.github.com/users/dagar/following{/other_user}","gists_url":"https://api.github.com/users/dagar/gists{/gist_id}","starred_url":"https://api.github.com/users/dagar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagar/subscriptions","organizations_url":"https://api.github.com/users/dagar/orgs","repos_url":"https://api.github.com/users/dagar/repos","events_url":"https://api.github.com/users/dagar/events{/privacy}","received_events_url":"https://api.github.com/users/dagar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":14,"created_at":"2015-10-12T12:59:32Z","updated_at":"2015-10-13T22:14:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PX4/Firmware/pulls/2978","html_url":"https://github.com/PX4/Firmware/pull/2978","diff_url":"https://github.com/PX4/Firmware/pull/2978.diff","patch_url":"https://github.com/PX4/Firmware/pull/2978.patch"},"body":"@LorenzMeier @jgoppert There are several problems with cmake on windows. So far I've identified the following, but I don't have proper fixes yet.\r\n\r\n - [x] remove rsync again - delete and copy NuttX each time\r\n - [x] change cmake generator to `MSYS Makefiles` (I think), We need some way to detect windows for the toplevel makefile. One hacky way is to check for the SystemRoot env variable that should only be present on windows.\r\n - [x] set PYTHONPATH properly on windows https://github.com/PX4/Firmware/blob/72dfc6b0b6c3a561f5b338677dce112b41bdce83/cmake/common/px4_base.cmake#L333\r\n - [ ] libuavcan problems with windows include paths not being passed properly\r\n - [x] topic_listener path split\r\n - [x] romfs bin_to_obj.py"},"comment":{"url":"https://api.github.com/repos/PX4/Firmware/issues/comments/147869340","html_url":"https://github.com/PX4/Firmware/pull/2978#issuecomment-147869340","issue_url":"https://api.github.com/repos/PX4/Firmware/issues/2978","id":147869340,"user":{"login":"dagar","id":84712,"avatar_url":"https://avatars.githubusercontent.com/u/84712?v=3","gravatar_id":"","url":"https://api.github.com/users/dagar","html_url":"https://github.com/dagar","followers_url":"https://api.github.com/users/dagar/followers","following_url":"https://api.github.com/users/dagar/following{/other_user}","gists_url":"https://api.github.com/users/dagar/gists{/gist_id}","starred_url":"https://api.github.com/users/dagar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagar/subscriptions","organizations_url":"https://api.github.com/users/dagar/orgs","repos_url":"https://api.github.com/users/dagar/repos","events_url":"https://api.github.com/users/dagar/events{/privacy}","received_events_url":"https://api.github.com/users/dagar/received_events","type":"User","site_admin":false},"created_at":"2015-10-13T22:14:10Z","updated_at":"2015-10-13T22:14:10Z","body":"@LorenzMeier with this branch px4fmu-v2_default will build on windows if you remove uavcan from nuttx_px4fmu-v2_default.cmake"}}