{"action":"created","issue":{"url":"https://api.github.com/repos/rendrjs/rendr/issues/432","labels_url":"https://api.github.com/repos/rendrjs/rendr/issues/432/labels{/name}","comments_url":"https://api.github.com/repos/rendrjs/rendr/issues/432/comments","events_url":"https://api.github.com/repos/rendrjs/rendr/issues/432/events","html_url":"https://github.com/rendrjs/rendr/pull/432","id":55841633,"number":432,"title":"Minor Fixes - Found while writing code documentation","user":{"login":"saponifi3d","id":1569818,"avatar_url":"https://avatars.githubusercontent.com/u/1569818?v=3","gravatar_id":"","url":"https://api.github.com/users/saponifi3d","html_url":"https://github.com/saponifi3d","followers_url":"https://api.github.com/users/saponifi3d/followers","following_url":"https://api.github.com/users/saponifi3d/following{/other_user}","gists_url":"https://api.github.com/users/saponifi3d/gists{/gist_id}","starred_url":"https://api.github.com/users/saponifi3d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saponifi3d/subscriptions","organizations_url":"https://api.github.com/users/saponifi3d/orgs","repos_url":"https://api.github.com/users/saponifi3d/repos","events_url":"https://api.github.com/users/saponifi3d/events{/privacy}","received_events_url":"https://api.github.com/users/saponifi3d/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-01-29T01:11:57Z","updated_at":"2015-02-05T17:58:57Z","closed_at":"2015-02-03T00:29:35Z","pull_request":{"url":"https://api.github.com/repos/rendrjs/rendr/pulls/432","html_url":"https://github.com/rendrjs/rendr/pull/432","diff_url":"https://github.com/rendrjs/rendr/pull/432.diff","patch_url":"https://github.com/rendrjs/rendr/pull/432.patch"},"body":"A bunch of small fixes that I found while going through and writing documentation, I'm cutting this PR before the documentation is done in the idea that I'll start developing a bit more correctly and cut a branch per fix.\r\n\r\nSome fixes include:\r\n- initialize object attributes with undefined if they're defined later. this is a V8 runtime optimization.\r\n- removed the definitions of `noop` in favor of using `_.noop`\r\n- added `expireSeconds` to the collection / model store so we can start taking advantage of expiring the cache\r\n- removed all the `postInitialize` functions since they have been deprecated\r\n- minor whitespace issues where tabbing was off\r\n- **biggest change** - removed the `checkFresh` code and all it's surrounding attributes / helper functions. This is because `checkFresh` current doesn't work (it created an infinite loop). This change is to favor the idea of setting an `expireSeconds` rather than invoking `checkFresh` for a specific model."},"comment":{"url":"https://api.github.com/repos/rendrjs/rendr/issues/comments/73093987","html_url":"https://github.com/rendrjs/rendr/pull/432#issuecomment-73093987","issue_url":"https://api.github.com/repos/rendrjs/rendr/issues/432","id":73093987,"user":{"login":"spikebrehm","id":133937,"avatar_url":"https://avatars.githubusercontent.com/u/133937?v=3","gravatar_id":"","url":"https://api.github.com/users/spikebrehm","html_url":"https://github.com/spikebrehm","followers_url":"https://api.github.com/users/spikebrehm/followers","following_url":"https://api.github.com/users/spikebrehm/following{/other_user}","gists_url":"https://api.github.com/users/spikebrehm/gists{/gist_id}","starred_url":"https://api.github.com/users/spikebrehm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spikebrehm/subscriptions","organizations_url":"https://api.github.com/users/spikebrehm/orgs","repos_url":"https://api.github.com/users/spikebrehm/repos","events_url":"https://api.github.com/users/spikebrehm/events{/privacy}","received_events_url":"https://api.github.com/users/spikebrehm/received_events","type":"User","site_admin":false},"created_at":"2015-02-05T17:58:57Z","updated_at":"2015-02-05T17:58:57Z","body":":+1: "}}