{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/46585837","id":46585837,"diff_hunk":"@@ -165,3 +165,13 @@ func (s *DockerSuite) TestVolumeCliNoArgs(c *check.C) {\n \tc.Assert(stderr, checker.Contains, usage)\n \tc.Assert(stderr, checker.Contains, \"flag provided but not defined: --no-such-flag\")\n }\n+\n+func (s *DockerSuite) TestVolumeCliInspectTmplError(c *check.C) {\n+\tout, _ := dockerCmd(c, \"volume\", \"create\")\n+\tname := strings.TrimSpace(out)\n+\n+\tout, exitCode, err := dockerCmdWithError(\"volume\", \"inspect\", \"--format='{{ .FooBar }}'\", name)\n+\tc.Assert(err, checker.NotNil, check.Commentf(\"%s\", exitCode))","path":"integration-cli/docker_cli_volume_test.go","position":10,"original_position":10,"commit_id":"23e4460cf872f4af3dfbc55ec6db071ecfb02f88","original_commit_id":"23e4460cf872f4af3dfbc55ec6db071ecfb02f88","user":{"login":"cpuguy83","id":799078,"avatar_url":"https://avatars.githubusercontent.com/u/799078?v=3","gravatar_id":"","url":"https://api.github.com/users/cpuguy83","html_url":"https://github.com/cpuguy83","followers_url":"https://api.github.com/users/cpuguy83/followers","following_url":"https://api.github.com/users/cpuguy83/following{/other_user}","gists_url":"https://api.github.com/users/cpuguy83/gists{/gist_id}","starred_url":"https://api.github.com/users/cpuguy83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpuguy83/subscriptions","organizations_url":"https://api.github.com/users/cpuguy83/orgs","repos_url":"https://api.github.com/users/cpuguy83/repos","events_url":"https://api.github.com/users/cpuguy83/events{/privacy}","received_events_url":"https://api.github.com/users/cpuguy83/received_events","type":"User","site_admin":false},"body":"Also maybe `out` as well so when there is an error hopefully it will give us some detail.","created_at":"2015-12-03T17:52:30Z","updated_at":"2015-12-03T17:52:30Z","html_url":"https://github.com/docker/docker/pull/18374#discussion_r46585837","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/18374","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/46585837"},"html":{"href":"https://github.com/docker/docker/pull/18374#discussion_r46585837"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/18374"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/18374","id":52449424,"html_url":"https://github.com/docker/docker/pull/18374","diff_url":"https://github.com/docker/docker/pull/18374.diff","patch_url":"https://github.com/docker/docker/pull/18374.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/18374","number":18374,"state":"open","locked":false,"title":"Return error code when `volume inspect` fails with a template.","user":{"login":"calavera","id":1050,"avatar_url":"https://avatars.githubusercontent.com/u/1050?v=3","gravatar_id":"","url":"https://api.github.com/users/calavera","html_url":"https://github.com/calavera","followers_url":"https://api.github.com/users/calavera/followers","following_url":"https://api.github.com/users/calavera/following{/other_user}","gists_url":"https://api.github.com/users/calavera/gists{/gist_id}","starred_url":"https://api.github.com/users/calavera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calavera/subscriptions","organizations_url":"https://api.github.com/users/calavera/orgs","repos_url":"https://api.github.com/users/calavera/repos","events_url":"https://api.github.com/users/calavera/events{/privacy}","received_events_url":"https://api.github.com/users/calavera/received_events","type":"User","site_admin":false},"body":"Following `docker inspect` conventions:\n\n- Keep partial info in a buffer to not print incomplete template outputs.\n- Break execution when template parsing or decoding fail.\n\nFixes #18328\n\nSigned-off-by: David Calavera <david.calavera@gmail.com>","created_at":"2015-12-02T20:26:39Z","updated_at":"2015-12-03T17:52:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"56b1bb55032b4f38ead91306e34cdc12e60fbaa3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/18374/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/18374/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/18374/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/23e4460cf872f4af3dfbc55ec6db071ecfb02f88","head":{"label":"calavera:volume_inspect_exit","ref":"volume_inspect_exit","sha":"23e4460cf872f4af3dfbc55ec6db071ecfb02f88","user":{"login":"calavera","id":1050,"avatar_url":"https://avatars.githubusercontent.com/u/1050?v=3","gravatar_id":"","url":"https://api.github.com/users/calavera","html_url":"https://github.com/calavera","followers_url":"https://api.github.com/users/calavera/followers","following_url":"https://api.github.com/users/calavera/following{/other_user}","gists_url":"https://api.github.com/users/calavera/gists{/gist_id}","starred_url":"https://api.github.com/users/calavera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calavera/subscriptions","organizations_url":"https://api.github.com/users/calavera/orgs","repos_url":"https://api.github.com/users/calavera/repos","events_url":"https://api.github.com/users/calavera/events{/privacy}","received_events_url":"https://api.github.com/users/calavera/received_events","type":"User","site_admin":false},"repo":{"id":11697698,"name":"docker","full_name":"calavera/docker","owner":{"login":"calavera","id":1050,"avatar_url":"https://avatars.githubusercontent.com/u/1050?v=3","gravatar_id":"","url":"https://api.github.com/users/calavera","html_url":"https://github.com/calavera","followers_url":"https://api.github.com/users/calavera/followers","following_url":"https://api.github.com/users/calavera/following{/other_user}","gists_url":"https://api.github.com/users/calavera/gists{/gist_id}","starred_url":"https://api.github.com/users/calavera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calavera/subscriptions","organizations_url":"https://api.github.com/users/calavera/orgs","repos_url":"https://api.github.com/users/calavera/repos","events_url":"https://api.github.com/users/calavera/events{/privacy}","received_events_url":"https://api.github.com/users/calavera/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/calavera/docker","description":"Docker - the Linux container runtime","fork":true,"url":"https://api.github.com/repos/calavera/docker","forks_url":"https://api.github.com/repos/calavera/docker/forks","keys_url":"https://api.github.com/repos/calavera/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/calavera/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/calavera/docker/teams","hooks_url":"https://api.github.com/repos/calavera/docker/hooks","issue_events_url":"https://api.github.com/repos/calavera/docker/issues/events{/number}","events_url":"https://api.github.com/repos/calavera/docker/events","assignees_url":"https://api.github.com/repos/calavera/docker/assignees{/user}","branches_url":"https://api.github.com/repos/calavera/docker/branches{/branch}","tags_url":"https://api.github.com/repos/calavera/docker/tags","blobs_url":"https://api.github.com/repos/calavera/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/calavera/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/calavera/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/calavera/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/calavera/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/calavera/docker/languages","stargazers_url":"https://api.github.com/repos/calavera/docker/stargazers","contributors_url":"https://api.github.com/repos/calavera/docker/contributors","subscribers_url":"https://api.github.com/repos/calavera/docker/subscribers","subscription_url":"https://api.github.com/repos/calavera/docker/subscription","commits_url":"https://api.github.com/repos/calavera/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/calavera/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/calavera/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/calavera/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/calavera/docker/contents/{+path}","compare_url":"https://api.github.com/repos/calavera/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/calavera/docker/merges","archive_url":"https://api.github.com/repos/calavera/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/calavera/docker/downloads","issues_url":"https://api.github.com/repos/calavera/docker/issues{/number}","pulls_url":"https://api.github.com/repos/calavera/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/calavera/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/calavera/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/calavera/docker/labels{/name}","releases_url":"https://api.github.com/repos/calavera/docker/releases{/id}","created_at":"2013-07-27T00:49:52Z","updated_at":"2014-07-24T21:22:23Z","pushed_at":"2015-12-03T16:12:48Z","git_url":"git://github.com/calavera/docker.git","ssh_url":"git@github.com:calavera/docker.git","clone_url":"https://github.com/calavera/docker.git","svn_url":"https://github.com/calavera/docker","homepage":"http://docker.io","size":78403,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"ee3e07d3593f97466df6fc11c19f91c1aee76dd4","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-12-03T16:35:40Z","pushed_at":"2015-12-03T16:44:46Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":117684,"stargazers_count":26755,"watchers_count":26755,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7247,"mirror_url":null,"open_issues_count":1203,"forks":7247,"open_issues":1203,"watchers":26755,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/18374"},"html":{"href":"https://github.com/docker/docker/pull/18374"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/18374"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/18374/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/18374/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/18374/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/23e4460cf872f4af3dfbc55ec6db071ecfb02f88"}}}}