{"action":"created","issue":{"url":"https://api.github.com/repos/guardian/membership-frontend/issues/718","labels_url":"https://api.github.com/repos/guardian/membership-frontend/issues/718/labels{/name}","comments_url":"https://api.github.com/repos/guardian/membership-frontend/issues/718/comments","events_url":"https://api.github.com/repos/guardian/membership-frontend/issues/718/events","html_url":"https://github.com/guardian/membership-frontend/pull/718","id":104672924,"number":718,"title":"Fix the untruth of the `hasUserBeenInvoiced()` method","user":{"login":"rtyley","id":52038,"avatar_url":"https://avatars.githubusercontent.com/u/52038?v=3","gravatar_id":"","url":"https://api.github.com/users/rtyley","html_url":"https://github.com/rtyley","followers_url":"https://api.github.com/users/rtyley/followers","following_url":"https://api.github.com/users/rtyley/following{/other_user}","gists_url":"https://api.github.com/users/rtyley/gists{/gist_id}","starred_url":"https://api.github.com/users/rtyley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtyley/subscriptions","organizations_url":"https://api.github.com/users/rtyley/orgs","repos_url":"https://api.github.com/users/rtyley/repos","events_url":"https://api.github.com/users/rtyley/events{/privacy}","received_events_url":"https://api.github.com/users/rtyley/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-03T11:39:49Z","updated_at":"2015-09-03T12:21:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/guardian/membership-frontend/pulls/718","html_url":"https://github.com/guardian/membership-frontend/pull/718","diff_url":"https://github.com/guardian/membership-frontend/pull/718.diff","patch_url":"https://github.com/guardian/membership-frontend/pull/718.patch"},"body":"We *want* to use a user's invoice to generate their MembershipSummary, but only if they've been invoiced (ie so long as they're not on a 6-month period offer, before 'contractAcceptance'). The `if` statement made it look like the logic was the other way around, but only because the method was misleading named with the inverse of what it actually did. The misleading naming was introduced during the free-offer-period work with commit 73d3b87e in https://github.com/guardian/membership-frontend/pull/454\r\n\r\nWe've double-checked with @jennysivapalan, who had to do all the awful 6-month-free-offer work, and we're confident that this is correct.\r\n\r\ncc @afiore "},"comment":{"url":"https://api.github.com/repos/guardian/membership-frontend/issues/comments/137420389","html_url":"https://github.com/guardian/membership-frontend/pull/718#issuecomment-137420389","issue_url":"https://api.github.com/repos/guardian/membership-frontend/issues/718","id":137420389,"user":{"login":"afiore","id":63361,"avatar_url":"https://avatars.githubusercontent.com/u/63361?v=3","gravatar_id":"","url":"https://api.github.com/users/afiore","html_url":"https://github.com/afiore","followers_url":"https://api.github.com/users/afiore/followers","following_url":"https://api.github.com/users/afiore/following{/other_user}","gists_url":"https://api.github.com/users/afiore/gists{/gist_id}","starred_url":"https://api.github.com/users/afiore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afiore/subscriptions","organizations_url":"https://api.github.com/users/afiore/orgs","repos_url":"https://api.github.com/users/afiore/repos","events_url":"https://api.github.com/users/afiore/events{/privacy}","received_events_url":"https://api.github.com/users/afiore/received_events","type":"User","site_admin":false},"created_at":"2015-09-03T12:21:37Z","updated_at":"2015-09-03T12:21:37Z","body":":+1: "}}