{"action":"created","issue":{"url":"https://api.github.com/repos/ceph/ceph/issues/5347","labels_url":"https://api.github.com/repos/ceph/ceph/issues/5347/labels{/name}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/5347/comments","events_url":"https://api.github.com/repos/ceph/ceph/issues/5347/events","html_url":"https://github.com/ceph/ceph/pull/5347","id":97340816,"number":5347,"title":"log: fix fd locking during reopen_log_file","user":{"login":"liewegas","id":433031,"avatar_url":"https://avatars.githubusercontent.com/u/433031?v=3","gravatar_id":"","url":"https://api.github.com/users/liewegas","html_url":"https://github.com/liewegas","followers_url":"https://api.github.com/users/liewegas/followers","following_url":"https://api.github.com/users/liewegas/following{/other_user}","gists_url":"https://api.github.com/users/liewegas/gists{/gist_id}","starred_url":"https://api.github.com/users/liewegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liewegas/subscriptions","organizations_url":"https://api.github.com/users/liewegas/orgs","repos_url":"https://api.github.com/users/liewegas/repos","events_url":"https://api.github.com/users/liewegas/events{/privacy}","received_events_url":"https://api.github.com/users/liewegas/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ceph/ceph/labels/bug%20fix","name":"bug fix","color":"e11d21"},{"url":"https://api.github.com/repos/ceph/ceph/labels/core","name":"core","color":"0052cc"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-26T18:47:38Z","updated_at":"2015-07-26T19:39:17Z","closed_at":"2015-07-26T18:50:38Z","pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/5347","html_url":"https://github.com/ceph/ceph/pull/5347","diff_url":"https://github.com/ceph/ceph/pull/5347.diff","patch_url":"https://github.com/ceph/ceph/pull/5347.patch"},"body":"We need to ensure there are no users of m_fd while we reopen the file.\nOtherwise, a racing thread may open a new file with the same fd and log\ndata may get erroneously written to that fd instead.  This can cause data\ncorruption if that fd happens to be a user objects and writeable.\n\nFixes: #11586\nBackport: hammer, giant, firefly\nSigned-off-by: Sage Weil <sage@redhat.com>"},"comment":{"url":"https://api.github.com/repos/ceph/ceph/issues/comments/125031732","html_url":"https://github.com/ceph/ceph/pull/5347#issuecomment-125031732","issue_url":"https://api.github.com/repos/ceph/ceph/issues/5347","id":125031732,"user":{"login":"loic-bot","id":9638672,"avatar_url":"https://avatars.githubusercontent.com/u/9638672?v=3","gravatar_id":"","url":"https://api.github.com/users/loic-bot","html_url":"https://github.com/loic-bot","followers_url":"https://api.github.com/users/loic-bot/followers","following_url":"https://api.github.com/users/loic-bot/following{/other_user}","gists_url":"https://api.github.com/users/loic-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/loic-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loic-bot/subscriptions","organizations_url":"https://api.github.com/users/loic-bot/orgs","repos_url":"https://api.github.com/users/loic-bot/repos","events_url":"https://api.github.com/users/loic-bot/events{/privacy}","received_events_url":"https://api.github.com/users/loic-bot/received_events","type":"User","site_admin":false},"created_at":"2015-07-26T19:39:17Z","updated_at":"2015-07-26T19:39:17Z","body":"SUCCESS: http://jenkins.ceph.dachary.org/job/ceph/6654/\n* SUCCESS http://jenkins.ceph.dachary.org/job/ceph/LABELS=centos-7&&x86_64/6654/\n* SUCCESS http://jenkins.ceph.dachary.org/job/ceph/LABELS=ubuntu-14.04&&x86_64/6654/\n"}}