{"action":"closed","number":286,"pull_request":{"url":"https://api.github.com/repos/luisfarzati/angulartics/pulls/286","id":28293785,"html_url":"https://github.com/luisfarzati/angulartics/pull/286","diff_url":"https://github.com/luisfarzati/angulartics/pull/286.diff","patch_url":"https://github.com/luisfarzati/angulartics/pull/286.patch","issue_url":"https://api.github.com/repos/luisfarzati/angulartics/issues/286","number":286,"state":"closed","locked":false,"title":"Add a timeout function around the data layer push for page views.","user":{"login":"hath74","id":10748509,"avatar_url":"https://avatars.githubusercontent.com/u/10748509?v=3","gravatar_id":"","url":"https://api.github.com/users/hath74","html_url":"https://github.com/hath74","followers_url":"https://api.github.com/users/hath74/followers","following_url":"https://api.github.com/users/hath74/following{/other_user}","gists_url":"https://api.github.com/users/hath74/gists{/gist_id}","starred_url":"https://api.github.com/users/hath74/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hath74/subscriptions","organizations_url":"https://api.github.com/users/hath74/orgs","repos_url":"https://api.github.com/users/hath74/repos","events_url":"https://api.github.com/users/hath74/events{/privacy}","received_events_url":"https://api.github.com/users/hath74/received_events","type":"User","site_admin":false},"body":"I ran into a problem when tracking virtual page views with route change success and dynamic page titles. Both the titles and the page views are triggered from route change success but the page view gets triggered before the page titles are set. In Google analytics the title from the previous page is recorded instead of the page title for the active route. Adding the timeout function solves this problem.","created_at":"2015-01-29T16:39:54Z","updated_at":"2015-07-18T03:03:17Z","closed_at":"2015-07-18T03:03:17Z","merged_at":null,"merge_commit_sha":"4453566631e6d98a90ba78706acbbc5ba6c20b18","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/luisfarzati/angulartics/pulls/286/commits","review_comments_url":"https://api.github.com/repos/luisfarzati/angulartics/pulls/286/comments","review_comment_url":"https://api.github.com/repos/luisfarzati/angulartics/pulls/comments{/number}","comments_url":"https://api.github.com/repos/luisfarzati/angulartics/issues/286/comments","statuses_url":"https://api.github.com/repos/luisfarzati/angulartics/statuses/e75985c4d27f88c26c73eb0da466bc863f025558","head":{"label":"hath74:patch-1","ref":"patch-1","sha":"e75985c4d27f88c26c73eb0da466bc863f025558","user":{"login":"hath74","id":10748509,"avatar_url":"https://avatars.githubusercontent.com/u/10748509?v=3","gravatar_id":"","url":"https://api.github.com/users/hath74","html_url":"https://github.com/hath74","followers_url":"https://api.github.com/users/hath74/followers","following_url":"https://api.github.com/users/hath74/following{/other_user}","gists_url":"https://api.github.com/users/hath74/gists{/gist_id}","starred_url":"https://api.github.com/users/hath74/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hath74/subscriptions","organizations_url":"https://api.github.com/users/hath74/orgs","repos_url":"https://api.github.com/users/hath74/repos","events_url":"https://api.github.com/users/hath74/events{/privacy}","received_events_url":"https://api.github.com/users/hath74/received_events","type":"User","site_admin":false},"repo":{"id":29992100,"name":"angulartics","full_name":"hath74/angulartics","owner":{"login":"hath74","id":10748509,"avatar_url":"https://avatars.githubusercontent.com/u/10748509?v=3","gravatar_id":"","url":"https://api.github.com/users/hath74","html_url":"https://github.com/hath74","followers_url":"https://api.github.com/users/hath74/followers","following_url":"https://api.github.com/users/hath74/following{/other_user}","gists_url":"https://api.github.com/users/hath74/gists{/gist_id}","starred_url":"https://api.github.com/users/hath74/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hath74/subscriptions","organizations_url":"https://api.github.com/users/hath74/orgs","repos_url":"https://api.github.com/users/hath74/repos","events_url":"https://api.github.com/users/hath74/events{/privacy}","received_events_url":"https://api.github.com/users/hath74/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hath74/angulartics","description":"Analytics for AngularJS applications.","fork":true,"url":"https://api.github.com/repos/hath74/angulartics","forks_url":"https://api.github.com/repos/hath74/angulartics/forks","keys_url":"https://api.github.com/repos/hath74/angulartics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hath74/angulartics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hath74/angulartics/teams","hooks_url":"https://api.github.com/repos/hath74/angulartics/hooks","issue_events_url":"https://api.github.com/repos/hath74/angulartics/issues/events{/number}","events_url":"https://api.github.com/repos/hath74/angulartics/events","assignees_url":"https://api.github.com/repos/hath74/angulartics/assignees{/user}","branches_url":"https://api.github.com/repos/hath74/angulartics/branches{/branch}","tags_url":"https://api.github.com/repos/hath74/angulartics/tags","blobs_url":"https://api.github.com/repos/hath74/angulartics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hath74/angulartics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hath74/angulartics/git/refs{/sha}","trees_url":"https://api.github.com/repos/hath74/angulartics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hath74/angulartics/statuses/{sha}","languages_url":"https://api.github.com/repos/hath74/angulartics/languages","stargazers_url":"https://api.github.com/repos/hath74/angulartics/stargazers","contributors_url":"https://api.github.com/repos/hath74/angulartics/contributors","subscribers_url":"https://api.github.com/repos/hath74/angulartics/subscribers","subscription_url":"https://api.github.com/repos/hath74/angulartics/subscription","commits_url":"https://api.github.com/repos/hath74/angulartics/commits{/sha}","git_commits_url":"https://api.github.com/repos/hath74/angulartics/git/commits{/sha}","comments_url":"https://api.github.com/repos/hath74/angulartics/comments{/number}","issue_comment_url":"https://api.github.com/repos/hath74/angulartics/issues/comments{/number}","contents_url":"https://api.github.com/repos/hath74/angulartics/contents/{+path}","compare_url":"https://api.github.com/repos/hath74/angulartics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hath74/angulartics/merges","archive_url":"https://api.github.com/repos/hath74/angulartics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hath74/angulartics/downloads","issues_url":"https://api.github.com/repos/hath74/angulartics/issues{/number}","pulls_url":"https://api.github.com/repos/hath74/angulartics/pulls{/number}","milestones_url":"https://api.github.com/repos/hath74/angulartics/milestones{/number}","notifications_url":"https://api.github.com/repos/hath74/angulartics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hath74/angulartics/labels{/name}","releases_url":"https://api.github.com/repos/hath74/angulartics/releases{/id}","created_at":"2015-01-28T22:40:30Z","updated_at":"2015-01-28T22:40:31Z","pushed_at":"2015-01-29T16:29:19Z","git_url":"git://github.com/hath74/angulartics.git","ssh_url":"git@github.com:hath74/angulartics.git","clone_url":"https://github.com/hath74/angulartics.git","svn_url":"https://github.com/hath74/angulartics","homepage":"http://luisfarzati.github.io/angulartics","size":789,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"luisfarzati:master","ref":"master","sha":"1b8bbf0608bec2c23105e2b31e86293e9c0ed5d6","user":{"login":"luisfarzati","id":107509,"avatar_url":"https://avatars.githubusercontent.com/u/107509?v=3","gravatar_id":"","url":"https://api.github.com/users/luisfarzati","html_url":"https://github.com/luisfarzati","followers_url":"https://api.github.com/users/luisfarzati/followers","following_url":"https://api.github.com/users/luisfarzati/following{/other_user}","gists_url":"https://api.github.com/users/luisfarzati/gists{/gist_id}","starred_url":"https://api.github.com/users/luisfarzati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luisfarzati/subscriptions","organizations_url":"https://api.github.com/users/luisfarzati/orgs","repos_url":"https://api.github.com/users/luisfarzati/repos","events_url":"https://api.github.com/users/luisfarzati/events{/privacy}","received_events_url":"https://api.github.com/users/luisfarzati/received_events","type":"User","site_admin":false},"repo":{"id":10418430,"name":"angulartics","full_name":"luisfarzati/angulartics","owner":{"login":"luisfarzati","id":107509,"avatar_url":"https://avatars.githubusercontent.com/u/107509?v=3","gravatar_id":"","url":"https://api.github.com/users/luisfarzati","html_url":"https://github.com/luisfarzati","followers_url":"https://api.github.com/users/luisfarzati/followers","following_url":"https://api.github.com/users/luisfarzati/following{/other_user}","gists_url":"https://api.github.com/users/luisfarzati/gists{/gist_id}","starred_url":"https://api.github.com/users/luisfarzati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luisfarzati/subscriptions","organizations_url":"https://api.github.com/users/luisfarzati/orgs","repos_url":"https://api.github.com/users/luisfarzati/repos","events_url":"https://api.github.com/users/luisfarzati/events{/privacy}","received_events_url":"https://api.github.com/users/luisfarzati/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/luisfarzati/angulartics","description":"Analytics for AngularJS applications.","fork":false,"url":"https://api.github.com/repos/luisfarzati/angulartics","forks_url":"https://api.github.com/repos/luisfarzati/angulartics/forks","keys_url":"https://api.github.com/repos/luisfarzati/angulartics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luisfarzati/angulartics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luisfarzati/angulartics/teams","hooks_url":"https://api.github.com/repos/luisfarzati/angulartics/hooks","issue_events_url":"https://api.github.com/repos/luisfarzati/angulartics/issues/events{/number}","events_url":"https://api.github.com/repos/luisfarzati/angulartics/events","assignees_url":"https://api.github.com/repos/luisfarzati/angulartics/assignees{/user}","branches_url":"https://api.github.com/repos/luisfarzati/angulartics/branches{/branch}","tags_url":"https://api.github.com/repos/luisfarzati/angulartics/tags","blobs_url":"https://api.github.com/repos/luisfarzati/angulartics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luisfarzati/angulartics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luisfarzati/angulartics/git/refs{/sha}","trees_url":"https://api.github.com/repos/luisfarzati/angulartics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luisfarzati/angulartics/statuses/{sha}","languages_url":"https://api.github.com/repos/luisfarzati/angulartics/languages","stargazers_url":"https://api.github.com/repos/luisfarzati/angulartics/stargazers","contributors_url":"https://api.github.com/repos/luisfarzati/angulartics/contributors","subscribers_url":"https://api.github.com/repos/luisfarzati/angulartics/subscribers","subscription_url":"https://api.github.com/repos/luisfarzati/angulartics/subscription","commits_url":"https://api.github.com/repos/luisfarzati/angulartics/commits{/sha}","git_commits_url":"https://api.github.com/repos/luisfarzati/angulartics/git/commits{/sha}","comments_url":"https://api.github.com/repos/luisfarzati/angulartics/comments{/number}","issue_comment_url":"https://api.github.com/repos/luisfarzati/angulartics/issues/comments{/number}","contents_url":"https://api.github.com/repos/luisfarzati/angulartics/contents/{+path}","compare_url":"https://api.github.com/repos/luisfarzati/angulartics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luisfarzati/angulartics/merges","archive_url":"https://api.github.com/repos/luisfarzati/angulartics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luisfarzati/angulartics/downloads","issues_url":"https://api.github.com/repos/luisfarzati/angulartics/issues{/number}","pulls_url":"https://api.github.com/repos/luisfarzati/angulartics/pulls{/number}","milestones_url":"https://api.github.com/repos/luisfarzati/angulartics/milestones{/number}","notifications_url":"https://api.github.com/repos/luisfarzati/angulartics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luisfarzati/angulartics/labels{/name}","releases_url":"https://api.github.com/repos/luisfarzati/angulartics/releases{/id}","created_at":"2013-06-01T05:59:41Z","updated_at":"2015-07-17T18:20:58Z","pushed_at":"2015-07-17T14:48:26Z","git_url":"git://github.com/luisfarzati/angulartics.git","ssh_url":"git@github.com:luisfarzati/angulartics.git","clone_url":"https://github.com/luisfarzati/angulartics.git","svn_url":"https://github.com/luisfarzati/angulartics","homepage":"http://luisfarzati.github.io/angulartics","size":2106,"stargazers_count":1225,"watchers_count":1225,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":301,"mirror_url":null,"open_issues_count":37,"forks":301,"open_issues":37,"watchers":1225,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/luisfarzati/angulartics/pulls/286"},"html":{"href":"https://github.com/luisfarzati/angulartics/pull/286"},"issue":{"href":"https://api.github.com/repos/luisfarzati/angulartics/issues/286"},"comments":{"href":"https://api.github.com/repos/luisfarzati/angulartics/issues/286/comments"},"review_comments":{"href":"https://api.github.com/repos/luisfarzati/angulartics/pulls/286/comments"},"review_comment":{"href":"https://api.github.com/repos/luisfarzati/angulartics/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/luisfarzati/angulartics/pulls/286/commits"},"statuses":{"href":"https://api.github.com/repos/luisfarzati/angulartics/statuses/e75985c4d27f88c26c73eb0da466bc863f025558"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":2,"deletions":0,"changed_files":1}}