{"action":"created","comment":{"url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/pulls/comments/31704707","id":31704707,"diff_hunk":"@@ -0,0 +1,69 @@\n+= Advantages noticed within a week:\n+\n+* fixing JRE across all jobs\n+* relasing target platform without breaking builds\n+* using 9.0 instead of 4.3.mars for stream\n+\n+= Local Jenkins Configuration\n+\n+Things I needed to do to run/test on local Jenkins (not complete yet!)\n+\n+. Add label to have it be recognized as a runnable node. (i.e. RHEL7)\n+. Add jdk jdk1.7 and jdk1.6 to have a server to look up.\n+. Add maven installers\n+. enable safe html under security\n+. Add native_tools / sep (todo)\n+. Install the plugins! (looking into using something like https://github.com/maxandersen/jenkins-ootb)\n+ \n+= Todos\n+\n+Open:\n+. buildpublish to jboss.org does not require name but publisher jenkins does (? new deploy might make this invalid)\n+\n+Done:\n+. support downstream-ext https://wiki.jenkins-ci.org/display/JENKINS/Downstream-Ext+Plugin (done: https://review.openstack.org/#/c/158117/)\n+. be able to turn builder on/off (done: `disabled: true|false`)\n+. handle JAVA17 property so its not a variable. (done: not used anymore in original jenkins)\n+. do tests timeout (done: just using normal build timeout)\n+. check if pattern are correct. (done: using variable to handle difference of the names)\n+. missing AbortOperation for timeout (done: Seems abort is the default so not needed to mimic generated config.xml)\n+. missing xvnc (done: https://review.openstack.org/#/c/156086/)\n+. update via internal server result in cert error (done: https://review.openstack.org/#/c/178794/)\n+. add way to not having to add direct support to jjb for a plugin (done: https://review.openstack.org/#/c/160158/)\n+\n+= Questions\n+\n+Some of these have been answered - just kept here until verified nothing missed yet.\n+\n+why no email notificiaton on version watch ? \n+\n+why no triggers on version watch ? \n+\n+why does versionwatch job define the include/excludes and not in our git repo so versioned/tracable togheter with rest of config ?\n+\n+why does product ignore failures and errors in mvn build step ?\n+\n+what does \"targetPlatformGroup=jbdevstudio\" mean ?\n+\n+why does product not build its updatesites in mvn instead of separate shell ?\n+","path":"buildchow/todo.adoc","position":49,"original_position":49,"commit_id":"2b3a76c45a7f6e767da4fc297f6d83c0d1f3b671","original_commit_id":"2b3a76c45a7f6e767da4fc297f6d83c0d1f3b671","user":{"login":"maxandersen","id":54129,"avatar_url":"https://avatars.githubusercontent.com/u/54129?v=3","gravatar_id":"","url":"https://api.github.com/users/maxandersen","html_url":"https://github.com/maxandersen","followers_url":"https://api.github.com/users/maxandersen/followers","following_url":"https://api.github.com/users/maxandersen/following{/other_user}","gists_url":"https://api.github.com/users/maxandersen/gists{/gist_id}","starred_url":"https://api.github.com/users/maxandersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxandersen/subscriptions","organizations_url":"https://api.github.com/users/maxandersen/orgs","repos_url":"https://api.github.com/users/maxandersen/repos","events_url":"https://api.github.com/users/maxandersen/events{/privacy}","received_events_url":"https://api.github.com/users/maxandersen/received_events","type":"User","site_admin":false},"body":"\r\nyes, I don't grok why it is doing this:\r\n\r\n```\r\n # move the non-pack200 site zip into the temporary folder\r\n               mv ${{WORKSPACE}}/sources/product/site/target/site_assembly.zip* ${{WORKSPACE}}/tmp-target/\r\n               # purge the target folder built w/o pack200\r\n               rm -fr ${{WORKSPACE}}/sources/product/site/target\r\n               # move the temporary folder back to where it should be\r\n               mv ${{WORKSPACE}}/tmp-target ${{WORKSPACE}}/sources/product/site/target\r\n               \r\n               # replace the update-core zip + MD5 with the new one\r\n               cp -f ${{WORKSPACE}}/sources/product/site/target/site_assembly.zip ${{WORKSPACE}}/sources/product/results/target/jboss-devstudio-*updatesite-core.zip\r\n               z=`find ${{WORKSPACE}}/sources/product/results/target/ -name \"jboss-devstudio-*updatesite-core.zip\"`\r\n               for m in $(md5sum ${{z}}); do if [[ $m != ${{z}} ]]; then echo $m &gt; ${{z}}.MD5; fi; done\r\n```\r\nwhat is this doing that tycho build couldn't ? it just seem to be moving the exact same bits/content back and forth,\r\nslightly mutating it and making the result we publish not what maven produces but what jenkins scripts make. which is generally a bad thing.\r\n\r\n","created_at":"2015-06-04T09:16:56Z","updated_at":"2015-06-04T09:16:56Z","html_url":"https://github.com/jbosstools/jbosstools-build-ci/pull/128#discussion_r31704707","pull_request_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/pulls/128","_links":{"self":{"href":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/pulls/comments/31704707"},"html":{"href":"https://github.com/jbosstools/jbosstools-build-ci/pull/128#discussion_r31704707"},"pull_request":{"href":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/pulls/128"}}},"pull_request":{"url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/pulls/128","id":36804350,"html_url":"https://github.com/jbosstools/jbosstools-build-ci/pull/128","diff_url":"https://github.com/jbosstools/jbosstools-build-ci/pull/128.diff","patch_url":"https://github.com/jbosstools/jbosstools-build-ci/pull/128.patch","issue_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/issues/128","number":128,"state":"open","locked":false,"title":" JBIDE-16140 buildchow for templated jenkins jobs","user":{"login":"maxandersen","id":54129,"avatar_url":"https://avatars.githubusercontent.com/u/54129?v=3","gravatar_id":"","url":"https://api.github.com/users/maxandersen","html_url":"https://github.com/maxandersen","followers_url":"https://api.github.com/users/maxandersen/followers","following_url":"https://api.github.com/users/maxandersen/following{/other_user}","gists_url":"https://api.github.com/users/maxandersen/gists{/gist_id}","starred_url":"https://api.github.com/users/maxandersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxandersen/subscriptions","organizations_url":"https://api.github.com/users/maxandersen/orgs","repos_url":"https://api.github.com/users/maxandersen/repos","events_url":"https://api.github.com/users/maxandersen/events{/privacy}","received_events_url":"https://api.github.com/users/maxandersen/received_events","type":"User","site_admin":false},"body":"Initial contribution that provide setup to use jenkins-job-builder\r\nto generate jenkins jobs.\r\n\r\nTried to keep it simple but yet structured to avoid\r\nhaving a very large hard to maintain single yaml file.\r\n\r\nDetailed docs are in the readme.adoc, but the general gist is:\r\n\r\ntemplates - contains job templates.\r\ninis - contain setup for specific hosts `defaults` being default jenkins.\r\n       dockerhost folder works as example to see how to do overrides.\r\n\r\nThe main template is `component-template.yaml` which defines the component jobs.\r\n\r\nTo generate jobs just run:\r\n\r\n   cd inis/defaults\r\n   jenkins-job-builder --config jenkins_jobs.ini test -o generated\r\n\r\nNote: for now the component jobs should match what was in place 2015-06-01\r\nin the original config.xml, but the rest have not been verified yet.","created_at":"2015-06-03T07:16:42Z","updated_at":"2015-06-04T09:16:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c667e8a5ab3aa9b38067d9d335a328a658814c8f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/pulls/128/commits","review_comments_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/pulls/128/comments","review_comment_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/issues/128/comments","statuses_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/statuses/2b3a76c45a7f6e767da4fc297f6d83c0d1f3b671","head":{"label":"maxandersen:buildchow","ref":"buildchow","sha":"2b3a76c45a7f6e767da4fc297f6d83c0d1f3b671","user":{"login":"maxandersen","id":54129,"avatar_url":"https://avatars.githubusercontent.com/u/54129?v=3","gravatar_id":"","url":"https://api.github.com/users/maxandersen","html_url":"https://github.com/maxandersen","followers_url":"https://api.github.com/users/maxandersen/followers","following_url":"https://api.github.com/users/maxandersen/following{/other_user}","gists_url":"https://api.github.com/users/maxandersen/gists{/gist_id}","starred_url":"https://api.github.com/users/maxandersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxandersen/subscriptions","organizations_url":"https://api.github.com/users/maxandersen/orgs","repos_url":"https://api.github.com/users/maxandersen/repos","events_url":"https://api.github.com/users/maxandersen/events{/privacy}","received_events_url":"https://api.github.com/users/maxandersen/received_events","type":"User","site_admin":false},"repo":{"id":6415207,"name":"jbosstools-build-ci","full_name":"maxandersen/jbosstools-build-ci","owner":{"login":"maxandersen","id":54129,"avatar_url":"https://avatars.githubusercontent.com/u/54129?v=3","gravatar_id":"","url":"https://api.github.com/users/maxandersen","html_url":"https://github.com/maxandersen","followers_url":"https://api.github.com/users/maxandersen/followers","following_url":"https://api.github.com/users/maxandersen/following{/other_user}","gists_url":"https://api.github.com/users/maxandersen/gists{/gist_id}","starred_url":"https://api.github.com/users/maxandersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxandersen/subscriptions","organizations_url":"https://api.github.com/users/maxandersen/orgs","repos_url":"https://api.github.com/users/maxandersen/repos","events_url":"https://api.github.com/users/maxandersen/events{/privacy}","received_events_url":"https://api.github.com/users/maxandersen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maxandersen/jbosstools-build-ci","description":"JBoss Tools :: Build-CI { build & utility scripts related to continuous integration, code coverage, server cleanup }","fork":true,"url":"https://api.github.com/repos/maxandersen/jbosstools-build-ci","forks_url":"https://api.github.com/repos/maxandersen/jbosstools-build-ci/forks","keys_url":"https://api.github.com/repos/maxandersen/jbosstools-build-ci/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maxandersen/jbosstools-build-ci/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maxandersen/jbosstools-build-ci/teams","hooks_url":"https://api.github.com/repos/maxandersen/jbosstools-build-ci/hooks","issue_events_url":"https://api.github.com/repos/maxandersen/jbosstools-build-ci/issues/events{/number}","events_url":"https://api.github.com/repos/maxandersen/jbosstools-build-ci/events","assignees_url":"https://api.github.com/repos/maxandersen/jbosstools-build-ci/assignees{/user}","branches_url":"https://api.github.com/repos/maxandersen/jbosstools-build-ci/branches{/branch}","tags_url":"https://api.github.com/repos/maxandersen/jbosstools-build-ci/tags","blobs_url":"https://api.github.com/repos/maxandersen/jbosstools-build-ci/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maxandersen/jbosstools-build-ci/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maxandersen/jbosstools-build-ci/git/refs{/sha}","trees_url":"https://api.github.com/repos/maxandersen/jbosstools-build-ci/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maxandersen/jbosstools-build-ci/statuses/{sha}","languages_url":"https://api.github.com/repos/maxandersen/jbosstools-build-ci/languages","stargazers_url":"https://api.github.com/repos/maxandersen/jbosstools-build-ci/stargazers","contributors_url":"https://api.github.com/repos/maxandersen/jbosstools-build-ci/contributors","subscribers_url":"https://api.github.com/repos/maxandersen/jbosstools-build-ci/subscribers","subscription_url":"https://api.github.com/repos/maxandersen/jbosstools-build-ci/subscription","commits_url":"https://api.github.com/repos/maxandersen/jbosstools-build-ci/commits{/sha}","git_commits_url":"https://api.github.com/repos/maxandersen/jbosstools-build-ci/git/commits{/sha}","comments_url":"https://api.github.com/repos/maxandersen/jbosstools-build-ci/comments{/number}","issue_comment_url":"https://api.github.com/repos/maxandersen/jbosstools-build-ci/issues/comments{/number}","contents_url":"https://api.github.com/repos/maxandersen/jbosstools-build-ci/contents/{+path}","compare_url":"https://api.github.com/repos/maxandersen/jbosstools-build-ci/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maxandersen/jbosstools-build-ci/merges","archive_url":"https://api.github.com/repos/maxandersen/jbosstools-build-ci/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maxandersen/jbosstools-build-ci/downloads","issues_url":"https://api.github.com/repos/maxandersen/jbosstools-build-ci/issues{/number}","pulls_url":"https://api.github.com/repos/maxandersen/jbosstools-build-ci/pulls{/number}","milestones_url":"https://api.github.com/repos/maxandersen/jbosstools-build-ci/milestones{/number}","notifications_url":"https://api.github.com/repos/maxandersen/jbosstools-build-ci/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maxandersen/jbosstools-build-ci/labels{/name}","releases_url":"https://api.github.com/repos/maxandersen/jbosstools-build-ci/releases{/id}","created_at":"2012-10-27T08:41:19Z","updated_at":"2013-01-12T20:47:49Z","pushed_at":"2015-06-03T07:20:58Z","git_url":"git://github.com/maxandersen/jbosstools-build-ci.git","ssh_url":"git@github.com:maxandersen/jbosstools-build-ci.git","clone_url":"https://github.com/maxandersen/jbosstools-build-ci.git","svn_url":"https://github.com/maxandersen/jbosstools-build-ci","homepage":"","size":1760,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jbosstools:jbosstools-4.3.x","ref":"jbosstools-4.3.x","sha":"70ded0d6232aea2a29e4372354fa93f6b980f654","user":{"login":"jbosstools","id":619871,"avatar_url":"https://avatars.githubusercontent.com/u/619871?v=3","gravatar_id":"","url":"https://api.github.com/users/jbosstools","html_url":"https://github.com/jbosstools","followers_url":"https://api.github.com/users/jbosstools/followers","following_url":"https://api.github.com/users/jbosstools/following{/other_user}","gists_url":"https://api.github.com/users/jbosstools/gists{/gist_id}","starred_url":"https://api.github.com/users/jbosstools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbosstools/subscriptions","organizations_url":"https://api.github.com/users/jbosstools/orgs","repos_url":"https://api.github.com/users/jbosstools/repos","events_url":"https://api.github.com/users/jbosstools/events{/privacy}","received_events_url":"https://api.github.com/users/jbosstools/received_events","type":"Organization","site_admin":false},"repo":{"id":6308270,"name":"jbosstools-build-ci","full_name":"jbosstools/jbosstools-build-ci","owner":{"login":"jbosstools","id":619871,"avatar_url":"https://avatars.githubusercontent.com/u/619871?v=3","gravatar_id":"","url":"https://api.github.com/users/jbosstools","html_url":"https://github.com/jbosstools","followers_url":"https://api.github.com/users/jbosstools/followers","following_url":"https://api.github.com/users/jbosstools/following{/other_user}","gists_url":"https://api.github.com/users/jbosstools/gists{/gist_id}","starred_url":"https://api.github.com/users/jbosstools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbosstools/subscriptions","organizations_url":"https://api.github.com/users/jbosstools/orgs","repos_url":"https://api.github.com/users/jbosstools/repos","events_url":"https://api.github.com/users/jbosstools/events{/privacy}","received_events_url":"https://api.github.com/users/jbosstools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jbosstools/jbosstools-build-ci","description":"JBoss Tools :: Build-CI { build & utility scripts related to continuous integration, code coverage, server cleanup }","fork":false,"url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci","forks_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/forks","keys_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/teams","hooks_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/hooks","issue_events_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/issues/events{/number}","events_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/events","assignees_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/assignees{/user}","branches_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/branches{/branch}","tags_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/tags","blobs_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/statuses/{sha}","languages_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/languages","stargazers_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/stargazers","contributors_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/contributors","subscribers_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/subscribers","subscription_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/subscription","commits_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/contents/{+path}","compare_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/merges","archive_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/downloads","issues_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/issues{/number}","pulls_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/pulls{/number}","milestones_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/milestones{/number}","notifications_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/labels{/name}","releases_url":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/releases{/id}","created_at":"2012-10-20T11:22:49Z","updated_at":"2015-05-01T14:34:53Z","pushed_at":"2015-06-03T07:20:58Z","git_url":"git://github.com/jbosstools/jbosstools-build-ci.git","ssh_url":"git@github.com:jbosstools/jbosstools-build-ci.git","clone_url":"https://github.com/jbosstools/jbosstools-build-ci.git","svn_url":"https://github.com/jbosstools/jbosstools-build-ci","homepage":"","size":2783,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":2,"forks":7,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/pulls/128"},"html":{"href":"https://github.com/jbosstools/jbosstools-build-ci/pull/128"},"issue":{"href":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/issues/128"},"comments":{"href":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/issues/128/comments"},"review_comments":{"href":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/pulls/128/comments"},"review_comment":{"href":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/pulls/128/commits"},"statuses":{"href":"https://api.github.com/repos/jbosstools/jbosstools-build-ci/statuses/2b3a76c45a7f6e767da4fc297f6d83c0d1f3b671"}}}}