{"action":"created","issue":{"url":"https://api.github.com/repos/cugos/dropchop/issues/211","labels_url":"https://api.github.com/repos/cugos/dropchop/issues/211/labels{/name}","comments_url":"https://api.github.com/repos/cugos/dropchop/issues/211/comments","events_url":"https://api.github.com/repos/cugos/dropchop/issues/211/events","html_url":"https://github.com/cugos/dropchop/pull/211","id":113268660,"number":211,"title":"Right click layerlist layer","user":{"login":"alukach","id":897290,"avatar_url":"https://avatars.githubusercontent.com/u/897290?v=3","gravatar_id":"","url":"https://api.github.com/users/alukach","html_url":"https://github.com/alukach","followers_url":"https://api.github.com/users/alukach/followers","following_url":"https://api.github.com/users/alukach/following{/other_user}","gists_url":"https://api.github.com/users/alukach/gists{/gist_id}","starred_url":"https://api.github.com/users/alukach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alukach/subscriptions","organizations_url":"https://api.github.com/users/alukach/orgs","repos_url":"https://api.github.com/users/alukach/repos","events_url":"https://api.github.com/users/alukach/events{/privacy}","received_events_url":"https://api.github.com/users/alukach/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cugos/dropchop/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/cugos/dropchop/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-10-26T01:18:55Z","updated_at":"2015-11-04T05:55:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cugos/dropchop/pulls/211","html_url":"https://github.com/cugos/dropchop/pull/211","diff_url":"https://github.com/cugos/dropchop/pull/211.diff","patch_url":"https://github.com/cugos/dropchop/pull/211.patch"},"body":"In response to the comments on #205, here's a first-shot at adding right-click menu support for layers on the layerlist.\r\n\r\nThis entailed a bit of a refactor in the way menus currently worked.  Each menu (left sidebar, operations menu, and right-click context-menu) was separated out into separate files and namespaces (`dc.menus.left`, `dc.menus.geo`, and `dc.menus.layerContextMenu`).  A `'layerlist:added'` signal was created to return newly added layers. \r\n\r\nCurrently, the right-click context menus only work on a single layer.\r\n\r\n![right-click-layer](https://cloud.githubusercontent.com/assets/897290/10719286/a25db600-7b4b-11e5-9a6f-63ad6b60921d.gif)\r\n\r\nThere's still work to be done:\r\n\r\n- [x] Add support for right-click operations on multiple selected layers.  \r\n- [x] Limit context-menu options based on layers selected (eg 'rename' would only apply to single layer selections but 'zoom to extent' could take many layers). \r\n- [ ] Write tests\r\n- [x] Remove redundant operations from left sidebar (likely everything under `'Geo Actions'`). \r\n- [x] Remove icons from layerlist layer item (the 'duplicate' operation should be moved to the right-click menu, the 'remove layer' operation should be removed). _Should this be done?_\r\n- [ ] Add 'right-click' tip to \"Welcome to dropchop!\" text\r\n\r\nI'm opening this up to get feedback.  Is this the right direction for DropChop?"},"comment":{"url":"https://api.github.com/repos/cugos/dropchop/issues/comments/153586002","html_url":"https://github.com/cugos/dropchop/pull/211#issuecomment-153586002","issue_url":"https://api.github.com/repos/cugos/dropchop/issues/211","id":153586002,"user":{"login":"alukach","id":897290,"avatar_url":"https://avatars.githubusercontent.com/u/897290?v=3","gravatar_id":"","url":"https://api.github.com/users/alukach","html_url":"https://github.com/alukach","followers_url":"https://api.github.com/users/alukach/followers","following_url":"https://api.github.com/users/alukach/following{/other_user}","gists_url":"https://api.github.com/users/alukach/gists{/gist_id}","starred_url":"https://api.github.com/users/alukach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alukach/subscriptions","organizations_url":"https://api.github.com/users/alukach/orgs","repos_url":"https://api.github.com/users/alukach/repos","events_url":"https://api.github.com/users/alukach/events{/privacy}","received_events_url":"https://api.github.com/users/alukach/received_events","type":"User","site_admin":false},"created_at":"2015-11-04T05:55:27Z","updated_at":"2015-11-04T05:55:27Z","body":"@mapsam feel free to take a crack on keeping the menu on the screen. I admit that I hadn't really thought about just comparing the `div` size and placement to the window size and to ensure that it stays on screen, that sounds like a solid solution."}}