{"action":"created","issue":{"url":"https://api.github.com/repos/skulpt/skulpt/issues/441","labels_url":"https://api.github.com/repos/skulpt/skulpt/issues/441/labels{/name}","comments_url":"https://api.github.com/repos/skulpt/skulpt/issues/441/comments","events_url":"https://api.github.com/repos/skulpt/skulpt/issues/441/events","html_url":"https://github.com/skulpt/skulpt/pull/441","id":81279134,"number":441,"title":"Check return code on rununits subprocesses","user":{"login":"bnmnetp","id":51115,"avatar_url":"https://avatars.githubusercontent.com/u/51115?v=3","gravatar_id":"","url":"https://api.github.com/users/bnmnetp","html_url":"https://github.com/bnmnetp","followers_url":"https://api.github.com/users/bnmnetp/followers","following_url":"https://api.github.com/users/bnmnetp/following{/other_user}","gists_url":"https://api.github.com/users/bnmnetp/gists{/gist_id}","starred_url":"https://api.github.com/users/bnmnetp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnmnetp/subscriptions","organizations_url":"https://api.github.com/users/bnmnetp/orgs","repos_url":"https://api.github.com/users/bnmnetp/repos","events_url":"https://api.github.com/users/bnmnetp/events{/privacy}","received_events_url":"https://api.github.com/users/bnmnetp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-05-27T05:06:25Z","updated_at":"2015-05-27T05:46:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/skulpt/skulpt/pulls/441","html_url":"https://github.com/skulpt/skulpt/pull/441","diff_url":"https://github.com/skulpt/skulpt/pull/441.diff","patch_url":"https://github.com/skulpt/skulpt/pull/441.patch"},"body":"OK, this is pretty simple, and should be accepted quickly as this plugs a hole in the new unittests.\r\n\r\nBy not checking the returncode of the subprocess we miss out on the fact that sometimes we get an error just loading up the code for a particular unittest which goes uncounted as a failure.  \r\n\r\nIf the test file exists then it better work or should cause the tests to fail.  I caught this in my own code a few days ago, and then I saw the problem again looking at @waywaaard's complex branch:\r\n\r\n```\r\ntest/unit/test_complex.py\r\nsrc/float.js:128: TypeError: a float is required at <unknown>\r\n        throw new Sk.builtin.TypeError(\"a float is required\");\r\n```\r\n\r\nThis did not count as a fail and wrongly made it look like all unittests had passed.\r\n"},"comment":{"url":"https://api.github.com/repos/skulpt/skulpt/issues/comments/105765059","html_url":"https://github.com/skulpt/skulpt/pull/441#issuecomment-105765059","issue_url":"https://api.github.com/repos/skulpt/skulpt/issues/441","id":105765059,"user":{"login":"waywaaard","id":1634468,"avatar_url":"https://avatars.githubusercontent.com/u/1634468?v=3","gravatar_id":"","url":"https://api.github.com/users/waywaaard","html_url":"https://github.com/waywaaard","followers_url":"https://api.github.com/users/waywaaard/followers","following_url":"https://api.github.com/users/waywaaard/following{/other_user}","gists_url":"https://api.github.com/users/waywaaard/gists{/gist_id}","starred_url":"https://api.github.com/users/waywaaard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waywaaard/subscriptions","organizations_url":"https://api.github.com/users/waywaaard/orgs","repos_url":"https://api.github.com/users/waywaaard/repos","events_url":"https://api.github.com/users/waywaaard/events{/privacy}","received_events_url":"https://api.github.com/users/waywaaard/received_events","type":"User","site_admin":false},"created_at":"2015-05-27T05:46:00Z","updated_at":"2015-05-27T05:46:00Z","body":"I am going to merge that and see if there are any unresolved problems."}}