{"action":"created","issue":{"url":"https://api.github.com/repos/zendesk/global_uid/issues/26","labels_url":"https://api.github.com/repos/zendesk/global_uid/issues/26/labels{/name}","comments_url":"https://api.github.com/repos/zendesk/global_uid/issues/26/comments","events_url":"https://api.github.com/repos/zendesk/global_uid/issues/26/events","html_url":"https://github.com/zendesk/global_uid/pull/26","id":58556577,"number":26,"title":"Inherit global_uid_disabled from LHS of HABTM associations on Rails 4.1+","user":{"login":"adammw","id":153219,"avatar_url":"https://avatars.githubusercontent.com/u/153219?v=3","gravatar_id":"","url":"https://api.github.com/users/adammw","html_url":"https://github.com/adammw","followers_url":"https://api.github.com/users/adammw/followers","following_url":"https://api.github.com/users/adammw/following{/other_user}","gists_url":"https://api.github.com/users/adammw/gists{/gist_id}","starred_url":"https://api.github.com/users/adammw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adammw/subscriptions","organizations_url":"https://api.github.com/users/adammw/orgs","repos_url":"https://api.github.com/users/adammw/repos","events_url":"https://api.github.com/users/adammw/events{/privacy}","received_events_url":"https://api.github.com/users/adammw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-02-23T08:29:27Z","updated_at":"2015-02-23T17:17:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zendesk/global_uid/pulls/26","html_url":"https://github.com/zendesk/global_uid/pull/26","diff_url":"https://github.com/zendesk/global_uid/pull/26.diff","patch_url":"https://github.com/zendesk/global_uid/pull/26.patch"},"body":":koala:\r\n\r\nInherit the global_uid_disabled state of models from the left-hand-side of a has_and_belongs_to_many association. Without this patch, any models using has_and_belongs_to_many that also have Global UID disabled will get Global UID errors on the join table association complaining that the corresponding table for that model does not exist.\r\n\r\nConceptually similar to https://github.com/zendesk/active_record_shards/commit/6c740539b3f2a3d9f98148424ae37056ed16b1be\r\n\r\n/cc @zendesk/quokka @bquorning @pschambacher @grosser @osheroff\r\n\r\n### Risks\r\n - Only fixes the problem on Rails 4.1+\r\n - Change in behaviour for has_and_belongs_to_many associations if the previous behaviour was expected"},"comment":{"url":"https://api.github.com/repos/zendesk/global_uid/issues/comments/75587308","html_url":"https://github.com/zendesk/global_uid/pull/26#issuecomment-75587308","issue_url":"https://api.github.com/repos/zendesk/global_uid/issues/26","id":75587308,"user":{"login":"osheroff","id":260084,"avatar_url":"https://avatars.githubusercontent.com/u/260084?v=3","gravatar_id":"","url":"https://api.github.com/users/osheroff","html_url":"https://github.com/osheroff","followers_url":"https://api.github.com/users/osheroff/followers","following_url":"https://api.github.com/users/osheroff/following{/other_user}","gists_url":"https://api.github.com/users/osheroff/gists{/gist_id}","starred_url":"https://api.github.com/users/osheroff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osheroff/subscriptions","organizations_url":"https://api.github.com/users/osheroff/orgs","repos_url":"https://api.github.com/users/osheroff/repos","events_url":"https://api.github.com/users/osheroff/events{/privacy}","received_events_url":"https://api.github.com/users/osheroff/received_events","type":"User","site_admin":false},"created_at":"2015-02-23T17:17:40Z","updated_at":"2015-02-23T17:17:40Z","body":"maybe use `.prepend` for cleanliness. otherwise :+1: "}}