{"action":"created","comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/pulls/comments/34187111","id":34187111,"diff_hunk":"@@ -49,7 +49,7 @@\n  *\n  */\n @Configuration\n-@ImportResource(\"classpath*:/META-INF/spring-xd/bus/codec.xml\")\n+@ImportResource(\"classpath*:/META-INF/spring-bus/codec.xml\")","path":"spring-cloud-streams/src/main/java/org/springframework/cloud/streams/config/ChannelBindingAdapterConfiguration.java","position":5,"original_position":5,"commit_id":"0fe4708170e068f9d7e411d16b8106c1c10ff75b","original_commit_id":"0fe4708170e068f9d7e411d16b8106c1c10ff75b","user":{"login":"dturanski","id":886859,"avatar_url":"https://avatars.githubusercontent.com/u/886859?v=3","gravatar_id":"","url":"https://api.github.com/users/dturanski","html_url":"https://github.com/dturanski","followers_url":"https://api.github.com/users/dturanski/followers","following_url":"https://api.github.com/users/dturanski/following{/other_user}","gists_url":"https://api.github.com/users/dturanski/gists{/gist_id}","starred_url":"https://api.github.com/users/dturanski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dturanski/subscriptions","organizations_url":"https://api.github.com/users/dturanski/orgs","repos_url":"https://api.github.com/users/dturanski/repos","events_url":"https://api.github.com/users/dturanski/events{/privacy}","received_events_url":"https://api.github.com/users/dturanski/received_events","type":"User","site_admin":false},"body":"I think the XML config goes away. It's been removed from XD already.  The Rabbit and Redis MB configurations are XML that have <constructor-arg ref=\"codec\"/>  I would like to get rid of the magic bean name and Autowire by type instead. Then it should be a matter of adding a jar that provides an implementation of MultitypeCodec.","created_at":"2015-07-08T19:15:52Z","updated_at":"2015-07-08T19:15:52Z","html_url":"https://github.com/spring-cloud/spring-cloud-streams/pull/1#discussion_r34187111","pull_request_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/pulls/comments/34187111"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-streams/pull/1#discussion_r34187111"},"pull_request":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/pulls/1","id":39509340,"html_url":"https://github.com/spring-cloud/spring-cloud-streams/pull/1","diff_url":"https://github.com/spring-cloud/spring-cloud-streams/pull/1.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-streams/pull/1.patch","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/issues/1","number":1,"state":"open","locked":false,"title":"removed spring-xd-dirt dependencies","user":{"login":"dturanski","id":886859,"avatar_url":"https://avatars.githubusercontent.com/u/886859?v=3","gravatar_id":"","url":"https://api.github.com/users/dturanski","html_url":"https://github.com/dturanski","followers_url":"https://api.github.com/users/dturanski/followers","following_url":"https://api.github.com/users/dturanski/following{/other_user}","gists_url":"https://api.github.com/users/dturanski/gists{/gist_id}","starred_url":"https://api.github.com/users/dturanski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dturanski/subscriptions","organizations_url":"https://api.github.com/users/dturanski/orgs","repos_url":"https://api.github.com/users/dturanski/repos","events_url":"https://api.github.com/users/dturanski/events{/privacy}","received_events_url":"https://api.github.com/users/dturanski/received_events","type":"User","site_admin":false},"body":"This removes direct dependencies on spring-xd-dirt and provides the minimum classses needed for the tests to pass. Classes copied from dirt are kept in o.s.xd.dirt... to be easily identified. Most of these are in spring-xd-runner. A couple are in spring-cloud-streams to avoid circular dependencies.  A modified codec.xml is provided which removes the TupleCodec. This could be added back to support Tuple payloads, currently not used in the tests. This would require a dependency on spring-xd-tuple. Codec config will need to be redone soon anyway. Also, dirt provides a number of ModuleOptionsMetadata classes needed to use common modules that are now missing. Module options is another area to revisit.","created_at":"2015-07-08T18:42:52Z","updated_at":"2015-07-08T19:15:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b07443f2bfa46a9b4792bc9b1c70f0e2fe128f0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/pulls/1/commits","review_comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/pulls/1/comments","review_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/issues/1/comments","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/statuses/0fe4708170e068f9d7e411d16b8106c1c10ff75b","head":{"label":"dturanski:remove-dirt-deps","ref":"remove-dirt-deps","sha":"0fe4708170e068f9d7e411d16b8106c1c10ff75b","user":{"login":"dturanski","id":886859,"avatar_url":"https://avatars.githubusercontent.com/u/886859?v=3","gravatar_id":"","url":"https://api.github.com/users/dturanski","html_url":"https://github.com/dturanski","followers_url":"https://api.github.com/users/dturanski/followers","following_url":"https://api.github.com/users/dturanski/following{/other_user}","gists_url":"https://api.github.com/users/dturanski/gists{/gist_id}","starred_url":"https://api.github.com/users/dturanski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dturanski/subscriptions","organizations_url":"https://api.github.com/users/dturanski/orgs","repos_url":"https://api.github.com/users/dturanski/repos","events_url":"https://api.github.com/users/dturanski/events{/privacy}","received_events_url":"https://api.github.com/users/dturanski/received_events","type":"User","site_admin":false},"repo":{"id":38768790,"name":"spring-cloud-streams","full_name":"dturanski/spring-cloud-streams","owner":{"login":"dturanski","id":886859,"avatar_url":"https://avatars.githubusercontent.com/u/886859?v=3","gravatar_id":"","url":"https://api.github.com/users/dturanski","html_url":"https://github.com/dturanski","followers_url":"https://api.github.com/users/dturanski/followers","following_url":"https://api.github.com/users/dturanski/following{/other_user}","gists_url":"https://api.github.com/users/dturanski/gists{/gist_id}","starred_url":"https://api.github.com/users/dturanski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dturanski/subscriptions","organizations_url":"https://api.github.com/users/dturanski/orgs","repos_url":"https://api.github.com/users/dturanski/repos","events_url":"https://api.github.com/users/dturanski/events{/privacy}","received_events_url":"https://api.github.com/users/dturanski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dturanski/spring-cloud-streams","description":"Messaging Microservices with Spring Integration","fork":true,"url":"https://api.github.com/repos/dturanski/spring-cloud-streams","forks_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/forks","keys_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/teams","hooks_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/hooks","issue_events_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/issues/events{/number}","events_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/events","assignees_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/assignees{/user}","branches_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/branches{/branch}","tags_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/tags","blobs_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/git/refs{/sha}","trees_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/statuses/{sha}","languages_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/languages","stargazers_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/stargazers","contributors_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/contributors","subscribers_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/subscribers","subscription_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/subscription","commits_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/commits{/sha}","git_commits_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/git/commits{/sha}","comments_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/comments{/number}","issue_comment_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/issues/comments{/number}","contents_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/contents/{+path}","compare_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/merges","archive_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/downloads","issues_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/issues{/number}","pulls_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/pulls{/number}","milestones_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/milestones{/number}","notifications_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/labels{/name}","releases_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/releases{/id}","created_at":"2015-07-08T17:21:32Z","updated_at":"2015-07-08T17:21:32Z","pushed_at":"2015-07-08T18:45:13Z","git_url":"git://github.com/dturanski/spring-cloud-streams.git","ssh_url":"git@github.com:dturanski/spring-cloud-streams.git","clone_url":"https://github.com/dturanski/spring-cloud-streams.git","svn_url":"https://github.com/dturanski/spring-cloud-streams","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-cloud:master","ref":"master","sha":"498d9f5c64d143d45046906e804f7686ee28d7aa","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":38764029,"name":"spring-cloud-streams","full_name":"spring-cloud/spring-cloud-streams","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-streams","description":"Messaging Microservices with Spring Integration","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/releases{/id}","created_at":"2015-07-08T15:51:38Z","updated_at":"2015-07-08T17:10:35Z","pushed_at":"2015-07-08T18:45:14Z","git_url":"git://github.com/spring-cloud/spring-cloud-streams.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-streams.git","clone_url":"https://github.com/spring-cloud/spring-cloud-streams.git","svn_url":"https://github.com/spring-cloud/spring-cloud-streams","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/pulls/1"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-streams/pull/1"},"issue":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/issues/1"},"comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-streams/statuses/0fe4708170e068f9d7e411d16b8106c1c10ff75b"}}}}