{"action":"created","comment":{"url":"https://api.github.com/repos/Chorus/chorus/pulls/comments/34740458","id":34740458,"diff_hunk":"@@ -1,13 +1,25 @@\n class MilestonePresenter < Presenter\n \n   def to_hash\n-    {\n+    milestone = {\n       :id => model.id,\n       :workspace => present(model.workspace, options.merge(:succinct => options[:succinct] || options[:list_view])),\n       :name => model.name,\n       :target_date => model.target_date,\n       :state => model.state\n     }\n+\n+    unless rendering_activities? || succinct?\n+      milestone.merge!({\n+                         :name => model.name\n+                       })\n+    end\n+\n+    milestone\n+  end\n+\n+  def complete_json?\n+    !rendering_activities? && !succinct?","path":"app/presenters/milestone_presenter.rb","position":23,"original_position":23,"commit_id":"c7997312d69a6f0b3d275cb8949caf5b37dd0feb","original_commit_id":"c7997312d69a6f0b3d275cb8949caf5b37dd0feb","user":{"login":"kevin-alpine","id":12001313,"avatar_url":"https://avatars.githubusercontent.com/u/12001313?v=3","gravatar_id":"","url":"https://api.github.com/users/kevin-alpine","html_url":"https://github.com/kevin-alpine","followers_url":"https://api.github.com/users/kevin-alpine/followers","following_url":"https://api.github.com/users/kevin-alpine/following{/other_user}","gists_url":"https://api.github.com/users/kevin-alpine/gists{/gist_id}","starred_url":"https://api.github.com/users/kevin-alpine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevin-alpine/subscriptions","organizations_url":"https://api.github.com/users/kevin-alpine/orgs","repos_url":"https://api.github.com/users/kevin-alpine/repos","events_url":"https://api.github.com/users/kevin-alpine/events{/privacy}","received_events_url":"https://api.github.com/users/kevin-alpine/received_events","type":"User","site_admin":false},"body":"I don't understand the changes to this file: you conditionally merge in `:name => model.name` ... but this is already present in the hash from line 7.  I suspect these changes might be left over from development.\r\n\r\nI commented these changes out and tried running the specs and exercising the UI, and the behavior remained the same.","created_at":"2015-07-15T23:10:28Z","updated_at":"2015-07-15T23:10:28Z","html_url":"https://github.com/Chorus/chorus/pull/80#discussion_r34740458","pull_request_url":"https://api.github.com/repos/Chorus/chorus/pulls/80","_links":{"self":{"href":"https://api.github.com/repos/Chorus/chorus/pulls/comments/34740458"},"html":{"href":"https://github.com/Chorus/chorus/pull/80#discussion_r34740458"},"pull_request":{"href":"https://api.github.com/repos/Chorus/chorus/pulls/80"}}},"pull_request":{"url":"https://api.github.com/repos/Chorus/chorus/pulls/80","id":39875829,"html_url":"https://github.com/Chorus/chorus/pull/80","diff_url":"https://github.com/Chorus/chorus/pull/80.diff","patch_url":"https://github.com/Chorus/chorus/pull/80.patch","issue_url":"https://api.github.com/repos/Chorus/chorus/issues/80","number":80,"state":"open","locked":false,"title":"DEV-9258: Display milestone completion in activity stream","user":{"login":"kevin-alpine","id":12001313,"avatar_url":"https://avatars.githubusercontent.com/u/12001313?v=3","gravatar_id":"","url":"https://api.github.com/users/kevin-alpine","html_url":"https://github.com/kevin-alpine","followers_url":"https://api.github.com/users/kevin-alpine/followers","following_url":"https://api.github.com/users/kevin-alpine/following{/other_user}","gists_url":"https://api.github.com/users/kevin-alpine/gists{/gist_id}","starred_url":"https://api.github.com/users/kevin-alpine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevin-alpine/subscriptions","organizations_url":"https://api.github.com/users/kevin-alpine/orgs","repos_url":"https://api.github.com/users/kevin-alpine/repos","events_url":"https://api.github.com/users/kevin-alpine/events{/privacy}","received_events_url":"https://api.github.com/users/kevin-alpine/received_events","type":"User","site_admin":false},"body":"This is a medium feature, it touches the entire stack, but it is very vertically specialized.\r\n\r\nIt's very similar to #79. \r\n\r\nSee original ticket here: https://alpine.atlassian.net/browse/DEV-9258","created_at":"2015-07-14T02:13:23Z","updated_at":"2015-07-15T23:10:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea6edc7caaab57cd0b18a0a4c8964f5fdcf07967","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Chorus/chorus/pulls/80/commits","review_comments_url":"https://api.github.com/repos/Chorus/chorus/pulls/80/comments","review_comment_url":"https://api.github.com/repos/Chorus/chorus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Chorus/chorus/issues/80/comments","statuses_url":"https://api.github.com/repos/Chorus/chorus/statuses/c7997312d69a6f0b3d275cb8949caf5b37dd0feb","head":{"label":"Chorus:9258-milestone-completion-in-activity-stream","ref":"9258-milestone-completion-in-activity-stream","sha":"c7997312d69a6f0b3d275cb8949caf5b37dd0feb","user":{"login":"Chorus","id":5614676,"avatar_url":"https://avatars.githubusercontent.com/u/5614676?v=3","gravatar_id":"","url":"https://api.github.com/users/Chorus","html_url":"https://github.com/Chorus","followers_url":"https://api.github.com/users/Chorus/followers","following_url":"https://api.github.com/users/Chorus/following{/other_user}","gists_url":"https://api.github.com/users/Chorus/gists{/gist_id}","starred_url":"https://api.github.com/users/Chorus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chorus/subscriptions","organizations_url":"https://api.github.com/users/Chorus/orgs","repos_url":"https://api.github.com/users/Chorus/repos","events_url":"https://api.github.com/users/Chorus/events{/privacy}","received_events_url":"https://api.github.com/users/Chorus/received_events","type":"Organization","site_admin":false},"repo":{"id":2751440,"name":"chorus","full_name":"Chorus/chorus","owner":{"login":"Chorus","id":5614676,"avatar_url":"https://avatars.githubusercontent.com/u/5614676?v=3","gravatar_id":"","url":"https://api.github.com/users/Chorus","html_url":"https://github.com/Chorus","followers_url":"https://api.github.com/users/Chorus/followers","following_url":"https://api.github.com/users/Chorus/following{/other_user}","gists_url":"https://api.github.com/users/Chorus/gists{/gist_id}","starred_url":"https://api.github.com/users/Chorus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chorus/subscriptions","organizations_url":"https://api.github.com/users/Chorus/orgs","repos_url":"https://api.github.com/users/Chorus/repos","events_url":"https://api.github.com/users/Chorus/events{/privacy}","received_events_url":"https://api.github.com/users/Chorus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Chorus/chorus","description":"Chorus allows customers, partners, developers, and data scientists to collaboratively realize the potential of Big Data.","fork":false,"url":"https://api.github.com/repos/Chorus/chorus","forks_url":"https://api.github.com/repos/Chorus/chorus/forks","keys_url":"https://api.github.com/repos/Chorus/chorus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Chorus/chorus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Chorus/chorus/teams","hooks_url":"https://api.github.com/repos/Chorus/chorus/hooks","issue_events_url":"https://api.github.com/repos/Chorus/chorus/issues/events{/number}","events_url":"https://api.github.com/repos/Chorus/chorus/events","assignees_url":"https://api.github.com/repos/Chorus/chorus/assignees{/user}","branches_url":"https://api.github.com/repos/Chorus/chorus/branches{/branch}","tags_url":"https://api.github.com/repos/Chorus/chorus/tags","blobs_url":"https://api.github.com/repos/Chorus/chorus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Chorus/chorus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Chorus/chorus/git/refs{/sha}","trees_url":"https://api.github.com/repos/Chorus/chorus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Chorus/chorus/statuses/{sha}","languages_url":"https://api.github.com/repos/Chorus/chorus/languages","stargazers_url":"https://api.github.com/repos/Chorus/chorus/stargazers","contributors_url":"https://api.github.com/repos/Chorus/chorus/contributors","subscribers_url":"https://api.github.com/repos/Chorus/chorus/subscribers","subscription_url":"https://api.github.com/repos/Chorus/chorus/subscription","commits_url":"https://api.github.com/repos/Chorus/chorus/commits{/sha}","git_commits_url":"https://api.github.com/repos/Chorus/chorus/git/commits{/sha}","comments_url":"https://api.github.com/repos/Chorus/chorus/comments{/number}","issue_comment_url":"https://api.github.com/repos/Chorus/chorus/issues/comments{/number}","contents_url":"https://api.github.com/repos/Chorus/chorus/contents/{+path}","compare_url":"https://api.github.com/repos/Chorus/chorus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Chorus/chorus/merges","archive_url":"https://api.github.com/repos/Chorus/chorus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Chorus/chorus/downloads","issues_url":"https://api.github.com/repos/Chorus/chorus/issues{/number}","pulls_url":"https://api.github.com/repos/Chorus/chorus/pulls{/number}","milestones_url":"https://api.github.com/repos/Chorus/chorus/milestones{/number}","notifications_url":"https://api.github.com/repos/Chorus/chorus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Chorus/chorus/labels{/name}","releases_url":"https://api.github.com/repos/Chorus/chorus/releases{/id}","created_at":"2011-11-10T20:30:13Z","updated_at":"2015-07-15T14:19:42Z","pushed_at":"2015-07-15T22:57:27Z","git_url":"git://github.com/Chorus/chorus.git","ssh_url":"git@github.com:Chorus/chorus.git","clone_url":"https://github.com/Chorus/chorus.git","svn_url":"https://github.com/Chorus/chorus","homepage":"","size":728981,"stargazers_count":156,"watchers_count":156,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":65,"mirror_url":null,"open_issues_count":9,"forks":65,"open_issues":9,"watchers":156,"default_branch":"master"}},"base":{"label":"Chorus:master","ref":"master","sha":"f7939de71b6f7c449499def292513aa5294e9e34","user":{"login":"Chorus","id":5614676,"avatar_url":"https://avatars.githubusercontent.com/u/5614676?v=3","gravatar_id":"","url":"https://api.github.com/users/Chorus","html_url":"https://github.com/Chorus","followers_url":"https://api.github.com/users/Chorus/followers","following_url":"https://api.github.com/users/Chorus/following{/other_user}","gists_url":"https://api.github.com/users/Chorus/gists{/gist_id}","starred_url":"https://api.github.com/users/Chorus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chorus/subscriptions","organizations_url":"https://api.github.com/users/Chorus/orgs","repos_url":"https://api.github.com/users/Chorus/repos","events_url":"https://api.github.com/users/Chorus/events{/privacy}","received_events_url":"https://api.github.com/users/Chorus/received_events","type":"Organization","site_admin":false},"repo":{"id":2751440,"name":"chorus","full_name":"Chorus/chorus","owner":{"login":"Chorus","id":5614676,"avatar_url":"https://avatars.githubusercontent.com/u/5614676?v=3","gravatar_id":"","url":"https://api.github.com/users/Chorus","html_url":"https://github.com/Chorus","followers_url":"https://api.github.com/users/Chorus/followers","following_url":"https://api.github.com/users/Chorus/following{/other_user}","gists_url":"https://api.github.com/users/Chorus/gists{/gist_id}","starred_url":"https://api.github.com/users/Chorus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chorus/subscriptions","organizations_url":"https://api.github.com/users/Chorus/orgs","repos_url":"https://api.github.com/users/Chorus/repos","events_url":"https://api.github.com/users/Chorus/events{/privacy}","received_events_url":"https://api.github.com/users/Chorus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Chorus/chorus","description":"Chorus allows customers, partners, developers, and data scientists to collaboratively realize the potential of Big Data.","fork":false,"url":"https://api.github.com/repos/Chorus/chorus","forks_url":"https://api.github.com/repos/Chorus/chorus/forks","keys_url":"https://api.github.com/repos/Chorus/chorus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Chorus/chorus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Chorus/chorus/teams","hooks_url":"https://api.github.com/repos/Chorus/chorus/hooks","issue_events_url":"https://api.github.com/repos/Chorus/chorus/issues/events{/number}","events_url":"https://api.github.com/repos/Chorus/chorus/events","assignees_url":"https://api.github.com/repos/Chorus/chorus/assignees{/user}","branches_url":"https://api.github.com/repos/Chorus/chorus/branches{/branch}","tags_url":"https://api.github.com/repos/Chorus/chorus/tags","blobs_url":"https://api.github.com/repos/Chorus/chorus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Chorus/chorus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Chorus/chorus/git/refs{/sha}","trees_url":"https://api.github.com/repos/Chorus/chorus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Chorus/chorus/statuses/{sha}","languages_url":"https://api.github.com/repos/Chorus/chorus/languages","stargazers_url":"https://api.github.com/repos/Chorus/chorus/stargazers","contributors_url":"https://api.github.com/repos/Chorus/chorus/contributors","subscribers_url":"https://api.github.com/repos/Chorus/chorus/subscribers","subscription_url":"https://api.github.com/repos/Chorus/chorus/subscription","commits_url":"https://api.github.com/repos/Chorus/chorus/commits{/sha}","git_commits_url":"https://api.github.com/repos/Chorus/chorus/git/commits{/sha}","comments_url":"https://api.github.com/repos/Chorus/chorus/comments{/number}","issue_comment_url":"https://api.github.com/repos/Chorus/chorus/issues/comments{/number}","contents_url":"https://api.github.com/repos/Chorus/chorus/contents/{+path}","compare_url":"https://api.github.com/repos/Chorus/chorus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Chorus/chorus/merges","archive_url":"https://api.github.com/repos/Chorus/chorus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Chorus/chorus/downloads","issues_url":"https://api.github.com/repos/Chorus/chorus/issues{/number}","pulls_url":"https://api.github.com/repos/Chorus/chorus/pulls{/number}","milestones_url":"https://api.github.com/repos/Chorus/chorus/milestones{/number}","notifications_url":"https://api.github.com/repos/Chorus/chorus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Chorus/chorus/labels{/name}","releases_url":"https://api.github.com/repos/Chorus/chorus/releases{/id}","created_at":"2011-11-10T20:30:13Z","updated_at":"2015-07-15T14:19:42Z","pushed_at":"2015-07-15T22:57:27Z","git_url":"git://github.com/Chorus/chorus.git","ssh_url":"git@github.com:Chorus/chorus.git","clone_url":"https://github.com/Chorus/chorus.git","svn_url":"https://github.com/Chorus/chorus","homepage":"","size":728981,"stargazers_count":156,"watchers_count":156,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":65,"mirror_url":null,"open_issues_count":9,"forks":65,"open_issues":9,"watchers":156,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Chorus/chorus/pulls/80"},"html":{"href":"https://github.com/Chorus/chorus/pull/80"},"issue":{"href":"https://api.github.com/repos/Chorus/chorus/issues/80"},"comments":{"href":"https://api.github.com/repos/Chorus/chorus/issues/80/comments"},"review_comments":{"href":"https://api.github.com/repos/Chorus/chorus/pulls/80/comments"},"review_comment":{"href":"https://api.github.com/repos/Chorus/chorus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Chorus/chorus/pulls/80/commits"},"statuses":{"href":"https://api.github.com/repos/Chorus/chorus/statuses/c7997312d69a6f0b3d275cb8949caf5b37dd0feb"}}}}