{"action":"created","comment":{"url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/34354941","id":34354941,"diff_hunk":"@@ -2464,23 +2502,77 @@ public:\n \n \n     /++\n+        Converts from unix time (i.e. seconds from midnight, January 1st, 1970\n+        in UTC) to a $(LREF SysTime).\n+\n+        On most systems, unix time is equivalent to time_t, but that depends on\n+        the C implementation as the exact representation of time_t is\n+        implementation-defined (e.g. it does not appear that the Digital Mars C\n+        runtime uses unix time for time_t; it appears to apply the local DST to\n+        time_t).","path":"std/datetime.d","position":121,"original_position":121,"commit_id":"ba3eeac601128e618a91320046d9619b37326dab","original_commit_id":"ba3eeac601128e618a91320046d9619b37326dab","user":{"login":"schveiguy","id":580778,"avatar_url":"https://avatars.githubusercontent.com/u/580778?v=3","gravatar_id":"","url":"https://api.github.com/users/schveiguy","html_url":"https://github.com/schveiguy","followers_url":"https://api.github.com/users/schveiguy/followers","following_url":"https://api.github.com/users/schveiguy/following{/other_user}","gists_url":"https://api.github.com/users/schveiguy/gists{/gist_id}","starred_url":"https://api.github.com/users/schveiguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schveiguy/subscriptions","organizations_url":"https://api.github.com/users/schveiguy/orgs","repos_url":"https://api.github.com/users/schveiguy/repos","events_url":"https://api.github.com/users/schveiguy/events{/privacy}","received_events_url":"https://api.github.com/users/schveiguy/received_events","type":"User","site_admin":false},"body":"I think this explanation can be shorter (and less committed to a specific behavior):\r\n\r\n```\r\nNote: unix time is not necessarily equivalent to time_t resolution or origin on non-unix systems. Keep this in mind when mixing with C calls.\r\n```","created_at":"2015-07-10T13:36:12Z","updated_at":"2015-07-10T13:36:12Z","html_url":"https://github.com/D-Programming-Language/phobos/pull/3481#discussion_r34354941","pull_request_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/3481","_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/34354941"},"html":{"href":"https://github.com/D-Programming-Language/phobos/pull/3481#discussion_r34354941"},"pull_request":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/3481"}}},"pull_request":{"url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/3481","id":39637947,"html_url":"https://github.com/D-Programming-Language/phobos/pull/3481","diff_url":"https://github.com/D-Programming-Language/phobos/pull/3481.diff","patch_url":"https://github.com/D-Programming-Language/phobos/pull/3481.patch","issue_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/3481","number":3481,"state":"open","locked":false,"title":"Implement issue# 14792: Add SysTime.fromUnixTime.","user":{"login":"jmdavis","id":579956,"avatar_url":"https://avatars.githubusercontent.com/u/579956?v=3","gravatar_id":"","url":"https://api.github.com/users/jmdavis","html_url":"https://github.com/jmdavis","followers_url":"https://api.github.com/users/jmdavis/followers","following_url":"https://api.github.com/users/jmdavis/following{/other_user}","gists_url":"https://api.github.com/users/jmdavis/gists{/gist_id}","starred_url":"https://api.github.com/users/jmdavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmdavis/subscriptions","organizations_url":"https://api.github.com/users/jmdavis/orgs","repos_url":"https://api.github.com/users/jmdavis/repos","events_url":"https://api.github.com/users/jmdavis/events{/privacy}","received_events_url":"https://api.github.com/users/jmdavis/received_events","type":"User","site_admin":false},"body":"https://issues.dlang.org/show_bug.cgi?id=14792\r\n\r\nWe've had the ability to convert from unix time to SysTime, but it has\r\nbeen more unwieldy than it should be. This adds fromUnixTime to go with\r\ntoUnixTime.\r\n\r\nIn addition, these changes solve the problem where you sometimes need a\r\nvalue for unix time that doesn't fit in time_t (e.g. a 64-bit value on a\r\n32-bit system), or you're dealing with a 64-bit time_t on a 32-bit\r\nsystem (which Windows sometimes does). So, toUnixTime and\r\nstdTimeToUnixTime now take an optional template argument which indicates\r\nhow many bits the result should be (defaulting to match the size of\r\ntime_t), and fromUnixTime and unixTimeToStdTime now take long rather\r\nthan time_t so that they can accept 64-bit values on 32-bit systems.","created_at":"2015-07-09T23:07:14Z","updated_at":"2015-07-10T13:36:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"58369805695e81c26b25ece8ea4679b99f19d5d8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/3481/commits","review_comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/3481/comments","review_comment_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/3481/comments","statuses_url":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/ba3eeac601128e618a91320046d9619b37326dab","head":{"label":"jmdavis:issue14792","ref":"issue14792","sha":"ba3eeac601128e618a91320046d9619b37326dab","user":{"login":"jmdavis","id":579956,"avatar_url":"https://avatars.githubusercontent.com/u/579956?v=3","gravatar_id":"","url":"https://api.github.com/users/jmdavis","html_url":"https://github.com/jmdavis","followers_url":"https://api.github.com/users/jmdavis/followers","following_url":"https://api.github.com/users/jmdavis/following{/other_user}","gists_url":"https://api.github.com/users/jmdavis/gists{/gist_id}","starred_url":"https://api.github.com/users/jmdavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmdavis/subscriptions","organizations_url":"https://api.github.com/users/jmdavis/orgs","repos_url":"https://api.github.com/users/jmdavis/repos","events_url":"https://api.github.com/users/jmdavis/events{/privacy}","received_events_url":"https://api.github.com/users/jmdavis/received_events","type":"User","site_admin":false},"repo":{"id":1344978,"name":"phobos","full_name":"jmdavis/phobos","owner":{"login":"jmdavis","id":579956,"avatar_url":"https://avatars.githubusercontent.com/u/579956?v=3","gravatar_id":"","url":"https://api.github.com/users/jmdavis","html_url":"https://github.com/jmdavis","followers_url":"https://api.github.com/users/jmdavis/followers","following_url":"https://api.github.com/users/jmdavis/following{/other_user}","gists_url":"https://api.github.com/users/jmdavis/gists{/gist_id}","starred_url":"https://api.github.com/users/jmdavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmdavis/subscriptions","organizations_url":"https://api.github.com/users/jmdavis/orgs","repos_url":"https://api.github.com/users/jmdavis/repos","events_url":"https://api.github.com/users/jmdavis/events{/privacy}","received_events_url":"https://api.github.com/users/jmdavis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmdavis/phobos","description":"Runtime library for the D programming language","fork":true,"url":"https://api.github.com/repos/jmdavis/phobos","forks_url":"https://api.github.com/repos/jmdavis/phobos/forks","keys_url":"https://api.github.com/repos/jmdavis/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmdavis/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmdavis/phobos/teams","hooks_url":"https://api.github.com/repos/jmdavis/phobos/hooks","issue_events_url":"https://api.github.com/repos/jmdavis/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/jmdavis/phobos/events","assignees_url":"https://api.github.com/repos/jmdavis/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/jmdavis/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/jmdavis/phobos/tags","blobs_url":"https://api.github.com/repos/jmdavis/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmdavis/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmdavis/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmdavis/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmdavis/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/jmdavis/phobos/languages","stargazers_url":"https://api.github.com/repos/jmdavis/phobos/stargazers","contributors_url":"https://api.github.com/repos/jmdavis/phobos/contributors","subscribers_url":"https://api.github.com/repos/jmdavis/phobos/subscribers","subscription_url":"https://api.github.com/repos/jmdavis/phobos/subscription","commits_url":"https://api.github.com/repos/jmdavis/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmdavis/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmdavis/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmdavis/phobos/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmdavis/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/jmdavis/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmdavis/phobos/merges","archive_url":"https://api.github.com/repos/jmdavis/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmdavis/phobos/downloads","issues_url":"https://api.github.com/repos/jmdavis/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/jmdavis/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/jmdavis/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/jmdavis/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmdavis/phobos/labels{/name}","releases_url":"https://api.github.com/repos/jmdavis/phobos/releases{/id}","created_at":"2011-02-09T04:09:04Z","updated_at":"2015-05-07T22:37:56Z","pushed_at":"2015-07-10T04:56:08Z","git_url":"git://github.com/jmdavis/phobos.git","ssh_url":"git@github.com:jmdavis/phobos.git","clone_url":"https://github.com/jmdavis/phobos.git","svn_url":"https://github.com/jmdavis/phobos","homepage":"d-programming-language.org","size":43354,"stargazers_count":2,"watchers_count":2,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"D-Programming-Language:master","ref":"master","sha":"255070aac0c9c0d774aa7b65cb07e357263bc608","user":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"repo":{"id":1257084,"name":"phobos","full_name":"D-Programming-Language/phobos","owner":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/D-Programming-Language/phobos","description":"The standard library of the D programming language","fork":false,"url":"https://api.github.com/repos/D-Programming-Language/phobos","forks_url":"https://api.github.com/repos/D-Programming-Language/phobos/forks","keys_url":"https://api.github.com/repos/D-Programming-Language/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/D-Programming-Language/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/D-Programming-Language/phobos/teams","hooks_url":"https://api.github.com/repos/D-Programming-Language/phobos/hooks","issue_events_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/D-Programming-Language/phobos/events","assignees_url":"https://api.github.com/repos/D-Programming-Language/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/D-Programming-Language/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/D-Programming-Language/phobos/tags","blobs_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/D-Programming-Language/phobos/languages","stargazers_url":"https://api.github.com/repos/D-Programming-Language/phobos/stargazers","contributors_url":"https://api.github.com/repos/D-Programming-Language/phobos/contributors","subscribers_url":"https://api.github.com/repos/D-Programming-Language/phobos/subscribers","subscription_url":"https://api.github.com/repos/D-Programming-Language/phobos/subscription","commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/comments{/number}","contents_url":"https://api.github.com/repos/D-Programming-Language/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/D-Programming-Language/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/D-Programming-Language/phobos/merges","archive_url":"https://api.github.com/repos/D-Programming-Language/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/D-Programming-Language/phobos/downloads","issues_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/D-Programming-Language/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/D-Programming-Language/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/D-Programming-Language/phobos/labels{/name}","releases_url":"https://api.github.com/repos/D-Programming-Language/phobos/releases{/id}","created_at":"2011-01-15T07:00:06Z","updated_at":"2015-07-06T19:57:48Z","pushed_at":"2015-07-10T09:52:21Z","git_url":"git://github.com/D-Programming-Language/phobos.git","ssh_url":"git@github.com:D-Programming-Language/phobos.git","clone_url":"https://github.com/D-Programming-Language/phobos.git","svn_url":"https://github.com/D-Programming-Language/phobos","homepage":"dlang.org/phobos","size":86689,"stargazers_count":611,"watchers_count":611,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":410,"mirror_url":null,"open_issues_count":72,"forks":410,"open_issues":72,"watchers":611,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/3481"},"html":{"href":"https://github.com/D-Programming-Language/phobos/pull/3481"},"issue":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/issues/3481"},"comments":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/issues/3481/comments"},"review_comments":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/3481/comments"},"review_comment":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/3481/commits"},"statuses":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/ba3eeac601128e618a91320046d9619b37326dab"}}}}