{"action":"created","issue":{"url":"https://api.github.com/repos/supercollider/supercollider/issues/1473","labels_url":"https://api.github.com/repos/supercollider/supercollider/issues/1473/labels{/name}","comments_url":"https://api.github.com/repos/supercollider/supercollider/issues/1473/comments","events_url":"https://api.github.com/repos/supercollider/supercollider/issues/1473/events","html_url":"https://github.com/supercollider/supercollider/issues/1473","id":77666093,"number":1473,"title":"How to complete unload plugins PR?","user":{"login":"sonoro1234","id":1795930,"avatar_url":"https://avatars.githubusercontent.com/u/1795930?v=3","gravatar_id":"","url":"https://api.github.com/users/sonoro1234","html_url":"https://github.com/sonoro1234","followers_url":"https://api.github.com/users/sonoro1234/followers","following_url":"https://api.github.com/users/sonoro1234/following{/other_user}","gists_url":"https://api.github.com/users/sonoro1234/gists{/gist_id}","starred_url":"https://api.github.com/users/sonoro1234/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonoro1234/subscriptions","organizations_url":"https://api.github.com/users/sonoro1234/orgs","repos_url":"https://api.github.com/users/sonoro1234/repos","events_url":"https://api.github.com/users/sonoro1234/events{/privacy}","received_events_url":"https://api.github.com/users/sonoro1234/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-05-18T13:54:47Z","updated_at":"2015-05-23T12:54:36Z","closed_at":null,"body":"commit https://github.com/supercollider/supercollider/commit/87e26cd75c6c7d4cfba40985cb38b113a38a0821\r\nwas merged before work was completed, so it introduced problems on scsynth quit. Now it must be solved someway\r\n\r\nthe work now has two possible PR\r\n\r\nhttps://github.com/supercollider/supercollider/pull/1467\r\nor\r\nhttps://github.com/supercollider/supercollider/pull/1472\r\n\r\n\r\nboth of them solve program hangs and crash on win32, linux and macosx\r\n\r\nthe first one does plugin unload on scsynth and leave prepared for supernova\r\nthe second one reverts all the unloading plugins stuff and only does a minimal DiskIO_UGens modification\r\n\r\nonly one should be choosen and the opinion of everybody is important\r\n\r\nBest\r\nvictor\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/supercollider/supercollider/issues/comments/104889664","html_url":"https://github.com/supercollider/supercollider/issues/1473#issuecomment-104889664","issue_url":"https://api.github.com/repos/supercollider/supercollider/issues/1473","id":104889664,"user":{"login":"sonoro1234","id":1795930,"avatar_url":"https://avatars.githubusercontent.com/u/1795930?v=3","gravatar_id":"","url":"https://api.github.com/users/sonoro1234","html_url":"https://github.com/sonoro1234","followers_url":"https://api.github.com/users/sonoro1234/followers","following_url":"https://api.github.com/users/sonoro1234/following{/other_user}","gists_url":"https://api.github.com/users/sonoro1234/gists{/gist_id}","starred_url":"https://api.github.com/users/sonoro1234/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonoro1234/subscriptions","organizations_url":"https://api.github.com/users/sonoro1234/orgs","repos_url":"https://api.github.com/users/sonoro1234/repos","events_url":"https://api.github.com/users/sonoro1234/events{/privacy}","received_events_url":"https://api.github.com/users/sonoro1234/received_events","type":"User","site_admin":false},"created_at":"2015-05-23T12:54:36Z","updated_at":"2015-05-23T12:54:36Z","body":"In case 1 you can declare an unload function (if you need it to deinitialize your pluging) or dont declare unload and behaviour is as ever has been.\r\nCase 2 is just a DiskIOUGens modification that solves the hang and nothing else"}}