{"action":"created","comment":{"url":"https://api.github.com/repos/inverse-inc/fingerbank/pulls/comments/43031311","id":43031311,"diff_hunk":"@@ -35,3 +35,28 @@ options=enabled|disabled\n description=<<EOT\n Should the local instance of Fingerbank record unmatched parameters so that it will be possible to submit thoses unmatched parameters to the upstream Fingerbank project for contribution\n EOT\n+\n+[query.use_tcp_fingerprinting]\n+type=toggle\n+options=enabled|disabled\n+description=<<EOT\n+Should the TCP fingerprinting be part of the discovery process to match a device ?\n+EOT\n+\n+[tcp_fingerprinting.p0f_socket_path]\n+type=test\n+description=<<EOT\n+The path to the p0f socket\n+EOT\n+\n+[tcp_fingerprinting.p0f_socket_map]\n+type=test\n+description=<<EOT\n+The path to the p0f map\n+EOT\n+\n+[tcp_fingerprinting.p0f_map_url]\n+type=test","path":"remote/perl/conf/fingerbank.conf.doc","position":25,"original_position":25,"commit_id":"96dfb5032b4541e2a5144b74e1ccc84dcdc4a197","original_commit_id":"96dfb5032b4541e2a5144b74e1ccc84dcdc4a197","user":{"login":"dwlfrth","id":633234,"avatar_url":"https://avatars.githubusercontent.com/u/633234?v=3","gravatar_id":"","url":"https://api.github.com/users/dwlfrth","html_url":"https://github.com/dwlfrth","followers_url":"https://api.github.com/users/dwlfrth/followers","following_url":"https://api.github.com/users/dwlfrth/following{/other_user}","gists_url":"https://api.github.com/users/dwlfrth/gists{/gist_id}","starred_url":"https://api.github.com/users/dwlfrth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwlfrth/subscriptions","organizations_url":"https://api.github.com/users/dwlfrth/orgs","repos_url":"https://api.github.com/users/dwlfrth/repos","events_url":"https://api.github.com/users/dwlfrth/events{/privacy}","received_events_url":"https://api.github.com/users/dwlfrth/received_events","type":"User","site_admin":false},"body":"What about text ?","created_at":"2015-10-26T18:16:51Z","updated_at":"2015-10-26T18:16:51Z","html_url":"https://github.com/inverse-inc/fingerbank/pull/24#discussion_r43031311","pull_request_url":"https://api.github.com/repos/inverse-inc/fingerbank/pulls/24","_links":{"self":{"href":"https://api.github.com/repos/inverse-inc/fingerbank/pulls/comments/43031311"},"html":{"href":"https://github.com/inverse-inc/fingerbank/pull/24#discussion_r43031311"},"pull_request":{"href":"https://api.github.com/repos/inverse-inc/fingerbank/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/inverse-inc/fingerbank/pulls/24","id":46655559,"html_url":"https://github.com/inverse-inc/fingerbank/pull/24","diff_url":"https://github.com/inverse-inc/fingerbank/pull/24.diff","patch_url":"https://github.com/inverse-inc/fingerbank/pull/24.patch","issue_url":"https://api.github.com/repos/inverse-inc/fingerbank/issues/24","number":24,"state":"open","locked":false,"title":"Feature/tcp fingerprints","user":{"login":"julsemaan","id":3857942,"avatar_url":"https://avatars.githubusercontent.com/u/3857942?v=3","gravatar_id":"","url":"https://api.github.com/users/julsemaan","html_url":"https://github.com/julsemaan","followers_url":"https://api.github.com/users/julsemaan/followers","following_url":"https://api.github.com/users/julsemaan/following{/other_user}","gists_url":"https://api.github.com/users/julsemaan/gists{/gist_id}","starred_url":"https://api.github.com/users/julsemaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julsemaan/subscriptions","organizations_url":"https://api.github.com/users/julsemaan/orgs","repos_url":"https://api.github.com/users/julsemaan/repos","events_url":"https://api.github.com/users/julsemaan/events{/privacy}","received_events_url":"https://api.github.com/users/julsemaan/received_events","type":"User","site_admin":false},"body":"# Description\r\nRefactored local lib so it can use multiple sources of detection\r\nAdded TCP fingerprinting through a p0f socket in the local lib\r\nAdded p0f map generation to upstream code\r\nAdded p0f map API call for download\r\n\r\n# Impacts\r\nlocal library device detection","created_at":"2015-10-02T16:37:39Z","updated_at":"2015-10-26T18:16:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"735cf505be7004a622affe4c5f21f9e9cf4b71ab","assignee":{"login":"dwlfrth","id":633234,"avatar_url":"https://avatars.githubusercontent.com/u/633234?v=3","gravatar_id":"","url":"https://api.github.com/users/dwlfrth","html_url":"https://github.com/dwlfrth","followers_url":"https://api.github.com/users/dwlfrth/followers","following_url":"https://api.github.com/users/dwlfrth/following{/other_user}","gists_url":"https://api.github.com/users/dwlfrth/gists{/gist_id}","starred_url":"https://api.github.com/users/dwlfrth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwlfrth/subscriptions","organizations_url":"https://api.github.com/users/dwlfrth/orgs","repos_url":"https://api.github.com/users/dwlfrth/repos","events_url":"https://api.github.com/users/dwlfrth/events{/privacy}","received_events_url":"https://api.github.com/users/dwlfrth/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/inverse-inc/fingerbank/pulls/24/commits","review_comments_url":"https://api.github.com/repos/inverse-inc/fingerbank/pulls/24/comments","review_comment_url":"https://api.github.com/repos/inverse-inc/fingerbank/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inverse-inc/fingerbank/issues/24/comments","statuses_url":"https://api.github.com/repos/inverse-inc/fingerbank/statuses/96dfb5032b4541e2a5144b74e1ccc84dcdc4a197","head":{"label":"inverse-inc:feature/tcp-fingerprints","ref":"feature/tcp-fingerprints","sha":"96dfb5032b4541e2a5144b74e1ccc84dcdc4a197","user":{"login":"inverse-inc","id":1203154,"avatar_url":"https://avatars.githubusercontent.com/u/1203154?v=3","gravatar_id":"","url":"https://api.github.com/users/inverse-inc","html_url":"https://github.com/inverse-inc","followers_url":"https://api.github.com/users/inverse-inc/followers","following_url":"https://api.github.com/users/inverse-inc/following{/other_user}","gists_url":"https://api.github.com/users/inverse-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/inverse-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inverse-inc/subscriptions","organizations_url":"https://api.github.com/users/inverse-inc/orgs","repos_url":"https://api.github.com/users/inverse-inc/repos","events_url":"https://api.github.com/users/inverse-inc/events{/privacy}","received_events_url":"https://api.github.com/users/inverse-inc/received_events","type":"Organization","site_admin":false},"repo":{"id":2516565,"name":"fingerbank","full_name":"inverse-inc/fingerbank","owner":{"login":"inverse-inc","id":1203154,"avatar_url":"https://avatars.githubusercontent.com/u/1203154?v=3","gravatar_id":"","url":"https://api.github.com/users/inverse-inc","html_url":"https://github.com/inverse-inc","followers_url":"https://api.github.com/users/inverse-inc/followers","following_url":"https://api.github.com/users/inverse-inc/following{/other_user}","gists_url":"https://api.github.com/users/inverse-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/inverse-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inverse-inc/subscriptions","organizations_url":"https://api.github.com/users/inverse-inc/orgs","repos_url":"https://api.github.com/users/inverse-inc/repos","events_url":"https://api.github.com/users/inverse-inc/events{/privacy}","received_events_url":"https://api.github.com/users/inverse-inc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inverse-inc/fingerbank","description":"Device fingerprints database and related tools","fork":false,"url":"https://api.github.com/repos/inverse-inc/fingerbank","forks_url":"https://api.github.com/repos/inverse-inc/fingerbank/forks","keys_url":"https://api.github.com/repos/inverse-inc/fingerbank/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inverse-inc/fingerbank/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inverse-inc/fingerbank/teams","hooks_url":"https://api.github.com/repos/inverse-inc/fingerbank/hooks","issue_events_url":"https://api.github.com/repos/inverse-inc/fingerbank/issues/events{/number}","events_url":"https://api.github.com/repos/inverse-inc/fingerbank/events","assignees_url":"https://api.github.com/repos/inverse-inc/fingerbank/assignees{/user}","branches_url":"https://api.github.com/repos/inverse-inc/fingerbank/branches{/branch}","tags_url":"https://api.github.com/repos/inverse-inc/fingerbank/tags","blobs_url":"https://api.github.com/repos/inverse-inc/fingerbank/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inverse-inc/fingerbank/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inverse-inc/fingerbank/git/refs{/sha}","trees_url":"https://api.github.com/repos/inverse-inc/fingerbank/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inverse-inc/fingerbank/statuses/{sha}","languages_url":"https://api.github.com/repos/inverse-inc/fingerbank/languages","stargazers_url":"https://api.github.com/repos/inverse-inc/fingerbank/stargazers","contributors_url":"https://api.github.com/repos/inverse-inc/fingerbank/contributors","subscribers_url":"https://api.github.com/repos/inverse-inc/fingerbank/subscribers","subscription_url":"https://api.github.com/repos/inverse-inc/fingerbank/subscription","commits_url":"https://api.github.com/repos/inverse-inc/fingerbank/commits{/sha}","git_commits_url":"https://api.github.com/repos/inverse-inc/fingerbank/git/commits{/sha}","comments_url":"https://api.github.com/repos/inverse-inc/fingerbank/comments{/number}","issue_comment_url":"https://api.github.com/repos/inverse-inc/fingerbank/issues/comments{/number}","contents_url":"https://api.github.com/repos/inverse-inc/fingerbank/contents/{+path}","compare_url":"https://api.github.com/repos/inverse-inc/fingerbank/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inverse-inc/fingerbank/merges","archive_url":"https://api.github.com/repos/inverse-inc/fingerbank/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inverse-inc/fingerbank/downloads","issues_url":"https://api.github.com/repos/inverse-inc/fingerbank/issues{/number}","pulls_url":"https://api.github.com/repos/inverse-inc/fingerbank/pulls{/number}","milestones_url":"https://api.github.com/repos/inverse-inc/fingerbank/milestones{/number}","notifications_url":"https://api.github.com/repos/inverse-inc/fingerbank/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inverse-inc/fingerbank/labels{/name}","releases_url":"https://api.github.com/repos/inverse-inc/fingerbank/releases{/id}","created_at":"2011-10-05T03:23:01Z","updated_at":"2015-05-22T06:27:55Z","pushed_at":"2015-10-26T17:45:30Z","git_url":"git://github.com/inverse-inc/fingerbank.git","ssh_url":"git@github.com:inverse-inc/fingerbank.git","clone_url":"https://github.com/inverse-inc/fingerbank.git","svn_url":"https://github.com/inverse-inc/fingerbank","homepage":"http://www.fingerbank.org","size":4398,"stargazers_count":27,"watchers_count":27,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":5,"forks":13,"open_issues":5,"watchers":27,"default_branch":"master"}},"base":{"label":"inverse-inc:master","ref":"master","sha":"5744def0daf47bd0300ed976eb1fcf48df044d3f","user":{"login":"inverse-inc","id":1203154,"avatar_url":"https://avatars.githubusercontent.com/u/1203154?v=3","gravatar_id":"","url":"https://api.github.com/users/inverse-inc","html_url":"https://github.com/inverse-inc","followers_url":"https://api.github.com/users/inverse-inc/followers","following_url":"https://api.github.com/users/inverse-inc/following{/other_user}","gists_url":"https://api.github.com/users/inverse-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/inverse-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inverse-inc/subscriptions","organizations_url":"https://api.github.com/users/inverse-inc/orgs","repos_url":"https://api.github.com/users/inverse-inc/repos","events_url":"https://api.github.com/users/inverse-inc/events{/privacy}","received_events_url":"https://api.github.com/users/inverse-inc/received_events","type":"Organization","site_admin":false},"repo":{"id":2516565,"name":"fingerbank","full_name":"inverse-inc/fingerbank","owner":{"login":"inverse-inc","id":1203154,"avatar_url":"https://avatars.githubusercontent.com/u/1203154?v=3","gravatar_id":"","url":"https://api.github.com/users/inverse-inc","html_url":"https://github.com/inverse-inc","followers_url":"https://api.github.com/users/inverse-inc/followers","following_url":"https://api.github.com/users/inverse-inc/following{/other_user}","gists_url":"https://api.github.com/users/inverse-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/inverse-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inverse-inc/subscriptions","organizations_url":"https://api.github.com/users/inverse-inc/orgs","repos_url":"https://api.github.com/users/inverse-inc/repos","events_url":"https://api.github.com/users/inverse-inc/events{/privacy}","received_events_url":"https://api.github.com/users/inverse-inc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inverse-inc/fingerbank","description":"Device fingerprints database and related tools","fork":false,"url":"https://api.github.com/repos/inverse-inc/fingerbank","forks_url":"https://api.github.com/repos/inverse-inc/fingerbank/forks","keys_url":"https://api.github.com/repos/inverse-inc/fingerbank/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inverse-inc/fingerbank/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inverse-inc/fingerbank/teams","hooks_url":"https://api.github.com/repos/inverse-inc/fingerbank/hooks","issue_events_url":"https://api.github.com/repos/inverse-inc/fingerbank/issues/events{/number}","events_url":"https://api.github.com/repos/inverse-inc/fingerbank/events","assignees_url":"https://api.github.com/repos/inverse-inc/fingerbank/assignees{/user}","branches_url":"https://api.github.com/repos/inverse-inc/fingerbank/branches{/branch}","tags_url":"https://api.github.com/repos/inverse-inc/fingerbank/tags","blobs_url":"https://api.github.com/repos/inverse-inc/fingerbank/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inverse-inc/fingerbank/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inverse-inc/fingerbank/git/refs{/sha}","trees_url":"https://api.github.com/repos/inverse-inc/fingerbank/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inverse-inc/fingerbank/statuses/{sha}","languages_url":"https://api.github.com/repos/inverse-inc/fingerbank/languages","stargazers_url":"https://api.github.com/repos/inverse-inc/fingerbank/stargazers","contributors_url":"https://api.github.com/repos/inverse-inc/fingerbank/contributors","subscribers_url":"https://api.github.com/repos/inverse-inc/fingerbank/subscribers","subscription_url":"https://api.github.com/repos/inverse-inc/fingerbank/subscription","commits_url":"https://api.github.com/repos/inverse-inc/fingerbank/commits{/sha}","git_commits_url":"https://api.github.com/repos/inverse-inc/fingerbank/git/commits{/sha}","comments_url":"https://api.github.com/repos/inverse-inc/fingerbank/comments{/number}","issue_comment_url":"https://api.github.com/repos/inverse-inc/fingerbank/issues/comments{/number}","contents_url":"https://api.github.com/repos/inverse-inc/fingerbank/contents/{+path}","compare_url":"https://api.github.com/repos/inverse-inc/fingerbank/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inverse-inc/fingerbank/merges","archive_url":"https://api.github.com/repos/inverse-inc/fingerbank/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inverse-inc/fingerbank/downloads","issues_url":"https://api.github.com/repos/inverse-inc/fingerbank/issues{/number}","pulls_url":"https://api.github.com/repos/inverse-inc/fingerbank/pulls{/number}","milestones_url":"https://api.github.com/repos/inverse-inc/fingerbank/milestones{/number}","notifications_url":"https://api.github.com/repos/inverse-inc/fingerbank/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inverse-inc/fingerbank/labels{/name}","releases_url":"https://api.github.com/repos/inverse-inc/fingerbank/releases{/id}","created_at":"2011-10-05T03:23:01Z","updated_at":"2015-05-22T06:27:55Z","pushed_at":"2015-10-26T17:45:30Z","git_url":"git://github.com/inverse-inc/fingerbank.git","ssh_url":"git@github.com:inverse-inc/fingerbank.git","clone_url":"https://github.com/inverse-inc/fingerbank.git","svn_url":"https://github.com/inverse-inc/fingerbank","homepage":"http://www.fingerbank.org","size":4398,"stargazers_count":27,"watchers_count":27,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":5,"forks":13,"open_issues":5,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inverse-inc/fingerbank/pulls/24"},"html":{"href":"https://github.com/inverse-inc/fingerbank/pull/24"},"issue":{"href":"https://api.github.com/repos/inverse-inc/fingerbank/issues/24"},"comments":{"href":"https://api.github.com/repos/inverse-inc/fingerbank/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/inverse-inc/fingerbank/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/inverse-inc/fingerbank/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inverse-inc/fingerbank/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/inverse-inc/fingerbank/statuses/96dfb5032b4541e2a5144b74e1ccc84dcdc4a197"}}}}