{"action":"created","comment":{"url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/pulls/comments/29368374","id":29368374,"diff_hunk":"@@ -66,4 +90,117 @@ private boolean hasEncounterTypeTag(String xml) throws Exception {\n \t\tNode formNode = HtmlFormEntryUtil.findChild(doc, \"htmlform\");\n \t\treturn HtmlFormEntryUtil.findChild(formNode, \"encounterType\") != null;\n \t}\n+    \n+\tprivate void setHtmlFormWarnings(String warning) {\n+\t\thtmlFormWarnings.add(warning);\n+\t}\n+\t\n+\tprivate void traverseNode(Node currentNode, Node parentObsGroupNode, Errors errors) {","path":"api/src/main/java/org/openmrs/module/htmlformentry/HtmlFormValidator.java","position":77,"original_position":77,"commit_id":"0ae7a3ac4b2357569a25ed3f59c7ea3ec19f430b","original_commit_id":"0ae7a3ac4b2357569a25ed3f59c7ea3ec19f430b","user":{"login":"djazayeri","id":1165236,"avatar_url":"https://avatars.githubusercontent.com/u/1165236?v=3","gravatar_id":"","url":"https://api.github.com/users/djazayeri","html_url":"https://github.com/djazayeri","followers_url":"https://api.github.com/users/djazayeri/followers","following_url":"https://api.github.com/users/djazayeri/following{/other_user}","gists_url":"https://api.github.com/users/djazayeri/gists{/gist_id}","starred_url":"https://api.github.com/users/djazayeri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djazayeri/subscriptions","organizations_url":"https://api.github.com/users/djazayeri/orgs","repos_url":"https://api.github.com/users/djazayeri/repos","events_url":"https://api.github.com/users/djazayeri/events{/privacy}","received_events_url":"https://api.github.com/users/djazayeri/received_events","type":"User","site_admin":false},"body":"Offhand I'm not sure. I didn't look closely when saying HtmlGeneratorElement.","created_at":"2015-04-29T18:57:19Z","updated_at":"2015-04-29T18:57:19Z","html_url":"https://github.com/openmrs/openmrs-module-htmlformentry/pull/84#discussion_r29368374","pull_request_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/pulls/84","_links":{"self":{"href":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/pulls/comments/29368374"},"html":{"href":"https://github.com/openmrs/openmrs-module-htmlformentry/pull/84#discussion_r29368374"},"pull_request":{"href":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/pulls/84"}}},"pull_request":{"url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/pulls/84","id":33767267,"html_url":"https://github.com/openmrs/openmrs-module-htmlformentry/pull/84","diff_url":"https://github.com/openmrs/openmrs-module-htmlformentry/pull/84.diff","patch_url":"https://github.com/openmrs/openmrs-module-htmlformentry/pull/84.patch","issue_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/issues/84","number":84,"state":"open","locked":false,"title":"HTML-381: Added validation while processing obs and obsgroup","user":{"login":"geoff-wasilwa","id":6013054,"avatar_url":"https://avatars.githubusercontent.com/u/6013054?v=3","gravatar_id":"","url":"https://api.github.com/users/geoff-wasilwa","html_url":"https://github.com/geoff-wasilwa","followers_url":"https://api.github.com/users/geoff-wasilwa/followers","following_url":"https://api.github.com/users/geoff-wasilwa/following{/other_user}","gists_url":"https://api.github.com/users/geoff-wasilwa/gists{/gist_id}","starred_url":"https://api.github.com/users/geoff-wasilwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoff-wasilwa/subscriptions","organizations_url":"https://api.github.com/users/geoff-wasilwa/orgs","repos_url":"https://api.github.com/users/geoff-wasilwa/repos","events_url":"https://api.github.com/users/geoff-wasilwa/events{/privacy}","received_events_url":"https://api.github.com/users/geoff-wasilwa/received_events","type":"User","site_admin":false},"body":"HFE did not provide checks for obs used as set members and obsgroup (if the obsgroup concept was a set).\r\nAdded a mechanism to validate this and store concept ids violating this rule to FormEntryContext from where\r\nthey can be displayed on the HTML Form edit page.","created_at":"2015-04-21T14:34:07Z","updated_at":"2015-04-29T18:57:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"073457fced90ecc955fbcc3e33b0ffa522d64e82","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/pulls/84/commits","review_comments_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/pulls/84/comments","review_comment_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/issues/84/comments","statuses_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/statuses/0ae7a3ac4b2357569a25ed3f59c7ea3ec19f430b","head":{"label":"geoff-wasilwa:HTML-381","ref":"HTML-381","sha":"0ae7a3ac4b2357569a25ed3f59c7ea3ec19f430b","user":{"login":"geoff-wasilwa","id":6013054,"avatar_url":"https://avatars.githubusercontent.com/u/6013054?v=3","gravatar_id":"","url":"https://api.github.com/users/geoff-wasilwa","html_url":"https://github.com/geoff-wasilwa","followers_url":"https://api.github.com/users/geoff-wasilwa/followers","following_url":"https://api.github.com/users/geoff-wasilwa/following{/other_user}","gists_url":"https://api.github.com/users/geoff-wasilwa/gists{/gist_id}","starred_url":"https://api.github.com/users/geoff-wasilwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoff-wasilwa/subscriptions","organizations_url":"https://api.github.com/users/geoff-wasilwa/orgs","repos_url":"https://api.github.com/users/geoff-wasilwa/repos","events_url":"https://api.github.com/users/geoff-wasilwa/events{/privacy}","received_events_url":"https://api.github.com/users/geoff-wasilwa/received_events","type":"User","site_admin":false},"repo":{"id":21286031,"name":"openmrs-module-htmlformentry","full_name":"geoff-wasilwa/openmrs-module-htmlformentry","owner":{"login":"geoff-wasilwa","id":6013054,"avatar_url":"https://avatars.githubusercontent.com/u/6013054?v=3","gravatar_id":"","url":"https://api.github.com/users/geoff-wasilwa","html_url":"https://github.com/geoff-wasilwa","followers_url":"https://api.github.com/users/geoff-wasilwa/followers","following_url":"https://api.github.com/users/geoff-wasilwa/following{/other_user}","gists_url":"https://api.github.com/users/geoff-wasilwa/gists{/gist_id}","starred_url":"https://api.github.com/users/geoff-wasilwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoff-wasilwa/subscriptions","organizations_url":"https://api.github.com/users/geoff-wasilwa/orgs","repos_url":"https://api.github.com/users/geoff-wasilwa/repos","events_url":"https://api.github.com/users/geoff-wasilwa/events{/privacy}","received_events_url":"https://api.github.com/users/geoff-wasilwa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/geoff-wasilwa/openmrs-module-htmlformentry","description":"HTML Form Entry module","fork":true,"url":"https://api.github.com/repos/geoff-wasilwa/openmrs-module-htmlformentry","forks_url":"https://api.github.com/repos/geoff-wasilwa/openmrs-module-htmlformentry/forks","keys_url":"https://api.github.com/repos/geoff-wasilwa/openmrs-module-htmlformentry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geoff-wasilwa/openmrs-module-htmlformentry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geoff-wasilwa/openmrs-module-htmlformentry/teams","hooks_url":"https://api.github.com/repos/geoff-wasilwa/openmrs-module-htmlformentry/hooks","issue_events_url":"https://api.github.com/repos/geoff-wasilwa/openmrs-module-htmlformentry/issues/events{/number}","events_url":"https://api.github.com/repos/geoff-wasilwa/openmrs-module-htmlformentry/events","assignees_url":"https://api.github.com/repos/geoff-wasilwa/openmrs-module-htmlformentry/assignees{/user}","branches_url":"https://api.github.com/repos/geoff-wasilwa/openmrs-module-htmlformentry/branches{/branch}","tags_url":"https://api.github.com/repos/geoff-wasilwa/openmrs-module-htmlformentry/tags","blobs_url":"https://api.github.com/repos/geoff-wasilwa/openmrs-module-htmlformentry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geoff-wasilwa/openmrs-module-htmlformentry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geoff-wasilwa/openmrs-module-htmlformentry/git/refs{/sha}","trees_url":"https://api.github.com/repos/geoff-wasilwa/openmrs-module-htmlformentry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geoff-wasilwa/openmrs-module-htmlformentry/statuses/{sha}","languages_url":"https://api.github.com/repos/geoff-wasilwa/openmrs-module-htmlformentry/languages","stargazers_url":"https://api.github.com/repos/geoff-wasilwa/openmrs-module-htmlformentry/stargazers","contributors_url":"https://api.github.com/repos/geoff-wasilwa/openmrs-module-htmlformentry/contributors","subscribers_url":"https://api.github.com/repos/geoff-wasilwa/openmrs-module-htmlformentry/subscribers","subscription_url":"https://api.github.com/repos/geoff-wasilwa/openmrs-module-htmlformentry/subscription","commits_url":"https://api.github.com/repos/geoff-wasilwa/openmrs-module-htmlformentry/commits{/sha}","git_commits_url":"https://api.github.com/repos/geoff-wasilwa/openmrs-module-htmlformentry/git/commits{/sha}","comments_url":"https://api.github.com/repos/geoff-wasilwa/openmrs-module-htmlformentry/comments{/number}","issue_comment_url":"https://api.github.com/repos/geoff-wasilwa/openmrs-module-htmlformentry/issues/comments{/number}","contents_url":"https://api.github.com/repos/geoff-wasilwa/openmrs-module-htmlformentry/contents/{+path}","compare_url":"https://api.github.com/repos/geoff-wasilwa/openmrs-module-htmlformentry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geoff-wasilwa/openmrs-module-htmlformentry/merges","archive_url":"https://api.github.com/repos/geoff-wasilwa/openmrs-module-htmlformentry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geoff-wasilwa/openmrs-module-htmlformentry/downloads","issues_url":"https://api.github.com/repos/geoff-wasilwa/openmrs-module-htmlformentry/issues{/number}","pulls_url":"https://api.github.com/repos/geoff-wasilwa/openmrs-module-htmlformentry/pulls{/number}","milestones_url":"https://api.github.com/repos/geoff-wasilwa/openmrs-module-htmlformentry/milestones{/number}","notifications_url":"https://api.github.com/repos/geoff-wasilwa/openmrs-module-htmlformentry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geoff-wasilwa/openmrs-module-htmlformentry/labels{/name}","releases_url":"https://api.github.com/repos/geoff-wasilwa/openmrs-module-htmlformentry/releases{/id}","created_at":"2014-06-27T18:58:04Z","updated_at":"2014-06-23T17:00:25Z","pushed_at":"2015-04-28T09:11:48Z","git_url":"git://github.com/geoff-wasilwa/openmrs-module-htmlformentry.git","ssh_url":"git@github.com:geoff-wasilwa/openmrs-module-htmlformentry.git","clone_url":"https://github.com/geoff-wasilwa/openmrs-module-htmlformentry.git","svn_url":"https://github.com/geoff-wasilwa/openmrs-module-htmlformentry","homepage":"https://wiki.openmrs.org/display/docs/HTML+Form+Entry+Module","size":25269,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openmrs:master","ref":"master","sha":"1950d12af75caff9974ed8ddc0533220d1ab4ed2","user":{"login":"openmrs","id":860776,"avatar_url":"https://avatars.githubusercontent.com/u/860776?v=3","gravatar_id":"","url":"https://api.github.com/users/openmrs","html_url":"https://github.com/openmrs","followers_url":"https://api.github.com/users/openmrs/followers","following_url":"https://api.github.com/users/openmrs/following{/other_user}","gists_url":"https://api.github.com/users/openmrs/gists{/gist_id}","starred_url":"https://api.github.com/users/openmrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmrs/subscriptions","organizations_url":"https://api.github.com/users/openmrs/orgs","repos_url":"https://api.github.com/users/openmrs/repos","events_url":"https://api.github.com/users/openmrs/events{/privacy}","received_events_url":"https://api.github.com/users/openmrs/received_events","type":"Organization","site_admin":false},"repo":{"id":2680621,"name":"openmrs-module-htmlformentry","full_name":"openmrs/openmrs-module-htmlformentry","owner":{"login":"openmrs","id":860776,"avatar_url":"https://avatars.githubusercontent.com/u/860776?v=3","gravatar_id":"","url":"https://api.github.com/users/openmrs","html_url":"https://github.com/openmrs","followers_url":"https://api.github.com/users/openmrs/followers","following_url":"https://api.github.com/users/openmrs/following{/other_user}","gists_url":"https://api.github.com/users/openmrs/gists{/gist_id}","starred_url":"https://api.github.com/users/openmrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmrs/subscriptions","organizations_url":"https://api.github.com/users/openmrs/orgs","repos_url":"https://api.github.com/users/openmrs/repos","events_url":"https://api.github.com/users/openmrs/events{/privacy}","received_events_url":"https://api.github.com/users/openmrs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openmrs/openmrs-module-htmlformentry","description":"HTML Form Entry module","fork":false,"url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry","forks_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/forks","keys_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/teams","hooks_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/hooks","issue_events_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/issues/events{/number}","events_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/events","assignees_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/assignees{/user}","branches_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/branches{/branch}","tags_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/tags","blobs_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/git/refs{/sha}","trees_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/statuses/{sha}","languages_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/languages","stargazers_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/stargazers","contributors_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/contributors","subscribers_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/subscribers","subscription_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/subscription","commits_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/commits{/sha}","git_commits_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/git/commits{/sha}","comments_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/comments{/number}","issue_comment_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/issues/comments{/number}","contents_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/contents/{+path}","compare_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/merges","archive_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/downloads","issues_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/issues{/number}","pulls_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/pulls{/number}","milestones_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/milestones{/number}","notifications_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/labels{/name}","releases_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/releases{/id}","created_at":"2011-10-31T13:06:47Z","updated_at":"2015-04-29T13:58:06Z","pushed_at":"2015-04-29T13:58:06Z","git_url":"git://github.com/openmrs/openmrs-module-htmlformentry.git","ssh_url":"git@github.com:openmrs/openmrs-module-htmlformentry.git","clone_url":"https://github.com/openmrs/openmrs-module-htmlformentry.git","svn_url":"https://github.com/openmrs/openmrs-module-htmlformentry","homepage":"https://wiki.openmrs.org/display/docs/HTML+Form+Entry+Module","size":27073,"stargazers_count":30,"watchers_count":30,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":107,"mirror_url":null,"open_issues_count":6,"forks":107,"open_issues":6,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/pulls/84"},"html":{"href":"https://github.com/openmrs/openmrs-module-htmlformentry/pull/84"},"issue":{"href":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/issues/84"},"comments":{"href":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/statuses/0ae7a3ac4b2357569a25ed3f59c7ea3ec19f430b"}}}}