{"action":"created","comment":{"url":"https://api.github.com/repos/gerbilvis/gerbil/pulls/comments/35984848","id":35984848,"diff_hunk":"@@ -81,20 +81,18 @@ multi_img::Value Compute::curpos(\n \n void Compute::PreprocessBins::operator()(const BinSet::HashMap::range_type &r)\n {\n-\tcv::Vec3f color;\n-\tmulti_img::Pixel pixel(dimensionality);\n \tBinSet::HashMap::iterator it;\n \tfor (it = r.begin(); it != r.end(); it++) {\n \t\tBin &b = it->second;\n \t\tfor (int d = 0; d < dimensionality; ++d) {\n-\t\t\tpixel[d] = b.means[d] / b.weight;\n \t\t\tstd::pair<int, int> &range = ranges[d];\n \t\t\trange.first = std::min<int>(range.first, (int)(it->first)[d]);\n \t\t\trange.second = std::max<int>(range.second, (int)(it->first)[d]);\n \t\t}\n-\t\t// TODO: calculate colors for all pixels BEFORE this step with functor\n-\t\tcolor = multi_img::bgr(pixel, meta, maxval);\n-\t\tb.rgb = QColor(color[2]*255, color[1]*255, color[0]*255);\n+\t\tfor (int i = 0; i<3; i++) {\n+\t\t\tb.colors[i] = b.colors[i] / b.weight;","path":"gui/dist_view/distviewcompute.cpp","position":19,"original_position":19,"commit_id":"84f8a70709e4541247410163f437be3ffc6d47ba","original_commit_id":"84f8a70709e4541247410163f437be3ffc6d47ba","user":{"login":"ypnos","id":8481470,"avatar_url":"https://avatars.githubusercontent.com/u/8481470?v=3","gravatar_id":"","url":"https://api.github.com/users/ypnos","html_url":"https://github.com/ypnos","followers_url":"https://api.github.com/users/ypnos/followers","following_url":"https://api.github.com/users/ypnos/following{/other_user}","gists_url":"https://api.github.com/users/ypnos/gists{/gist_id}","starred_url":"https://api.github.com/users/ypnos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ypnos/subscriptions","organizations_url":"https://api.github.com/users/ypnos/orgs","repos_url":"https://api.github.com/users/ypnos/repos","events_url":"https://api.github.com/users/ypnos/events{/privacy}","received_events_url":"https://api.github.com/users/ypnos/received_events","type":"User","site_admin":false},"body":"changing the variable in the bin at this stage messes up incremental updates later one (e.g. when labeling single pixels in the bandview)!\r\nwhy not set b.rgb = QColor(b.colors[2] / b.weight …  directly?","created_at":"2015-07-31T15:34:00Z","updated_at":"2015-07-31T15:34:00Z","html_url":"https://github.com/gerbilvis/gerbil/pull/7#discussion_r35984848","pull_request_url":"https://api.github.com/repos/gerbilvis/gerbil/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/gerbilvis/gerbil/pulls/comments/35984848"},"html":{"href":"https://github.com/gerbilvis/gerbil/pull/7#discussion_r35984848"},"pull_request":{"href":"https://api.github.com/repos/gerbilvis/gerbil/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/gerbilvis/gerbil/pulls/7","id":41323646,"html_url":"https://github.com/gerbilvis/gerbil/pull/7","diff_url":"https://github.com/gerbilvis/gerbil/pull/7.diff","patch_url":"https://github.com/gerbilvis/gerbil/pull/7.patch","issue_url":"https://api.github.com/repos/gerbilvis/gerbil/issues/7","number":7,"state":"open","locked":false,"title":"Issue #6 solution","user":{"login":"ajaskier","id":8076184,"avatar_url":"https://avatars.githubusercontent.com/u/8076184?v=3","gravatar_id":"","url":"https://api.github.com/users/ajaskier","html_url":"https://github.com/ajaskier","followers_url":"https://api.github.com/users/ajaskier/followers","following_url":"https://api.github.com/users/ajaskier/following{/other_user}","gists_url":"https://api.github.com/users/ajaskier/gists{/gist_id}","starred_url":"https://api.github.com/users/ajaskier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajaskier/subscriptions","organizations_url":"https://api.github.com/users/ajaskier/orgs","repos_url":"https://api.github.com/users/ajaskier/repos","events_url":"https://api.github.com/users/ajaskier/events{/privacy}","received_events_url":"https://api.github.com/users/ajaskier/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-07-31T09:47:57Z","updated_at":"2015-07-31T15:34:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bff839e65dfde09c87ea6d1fedb28230e4705ca8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gerbilvis/gerbil/pulls/7/commits","review_comments_url":"https://api.github.com/repos/gerbilvis/gerbil/pulls/7/comments","review_comment_url":"https://api.github.com/repos/gerbilvis/gerbil/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gerbilvis/gerbil/issues/7/comments","statuses_url":"https://api.github.com/repos/gerbilvis/gerbil/statuses/84f8a70709e4541247410163f437be3ffc6d47ba","head":{"label":"ajaskier:master","ref":"master","sha":"84f8a70709e4541247410163f437be3ffc6d47ba","user":{"login":"ajaskier","id":8076184,"avatar_url":"https://avatars.githubusercontent.com/u/8076184?v=3","gravatar_id":"","url":"https://api.github.com/users/ajaskier","html_url":"https://github.com/ajaskier","followers_url":"https://api.github.com/users/ajaskier/followers","following_url":"https://api.github.com/users/ajaskier/following{/other_user}","gists_url":"https://api.github.com/users/ajaskier/gists{/gist_id}","starred_url":"https://api.github.com/users/ajaskier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajaskier/subscriptions","organizations_url":"https://api.github.com/users/ajaskier/orgs","repos_url":"https://api.github.com/users/ajaskier/repos","events_url":"https://api.github.com/users/ajaskier/events{/privacy}","received_events_url":"https://api.github.com/users/ajaskier/received_events","type":"User","site_admin":false},"repo":{"id":38458067,"name":"gerbil","full_name":"ajaskier/gerbil","owner":{"login":"ajaskier","id":8076184,"avatar_url":"https://avatars.githubusercontent.com/u/8076184?v=3","gravatar_id":"","url":"https://api.github.com/users/ajaskier","html_url":"https://github.com/ajaskier","followers_url":"https://api.github.com/users/ajaskier/followers","following_url":"https://api.github.com/users/ajaskier/following{/other_user}","gists_url":"https://api.github.com/users/ajaskier/gists{/gist_id}","starred_url":"https://api.github.com/users/ajaskier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajaskier/subscriptions","organizations_url":"https://api.github.com/users/ajaskier/orgs","repos_url":"https://api.github.com/users/ajaskier/repos","events_url":"https://api.github.com/users/ajaskier/events{/privacy}","received_events_url":"https://api.github.com/users/ajaskier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ajaskier/gerbil","description":"Gerbil Hyperspectral Visualization and Analysis Framework","fork":true,"url":"https://api.github.com/repos/ajaskier/gerbil","forks_url":"https://api.github.com/repos/ajaskier/gerbil/forks","keys_url":"https://api.github.com/repos/ajaskier/gerbil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajaskier/gerbil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajaskier/gerbil/teams","hooks_url":"https://api.github.com/repos/ajaskier/gerbil/hooks","issue_events_url":"https://api.github.com/repos/ajaskier/gerbil/issues/events{/number}","events_url":"https://api.github.com/repos/ajaskier/gerbil/events","assignees_url":"https://api.github.com/repos/ajaskier/gerbil/assignees{/user}","branches_url":"https://api.github.com/repos/ajaskier/gerbil/branches{/branch}","tags_url":"https://api.github.com/repos/ajaskier/gerbil/tags","blobs_url":"https://api.github.com/repos/ajaskier/gerbil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajaskier/gerbil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajaskier/gerbil/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajaskier/gerbil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajaskier/gerbil/statuses/{sha}","languages_url":"https://api.github.com/repos/ajaskier/gerbil/languages","stargazers_url":"https://api.github.com/repos/ajaskier/gerbil/stargazers","contributors_url":"https://api.github.com/repos/ajaskier/gerbil/contributors","subscribers_url":"https://api.github.com/repos/ajaskier/gerbil/subscribers","subscription_url":"https://api.github.com/repos/ajaskier/gerbil/subscription","commits_url":"https://api.github.com/repos/ajaskier/gerbil/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajaskier/gerbil/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajaskier/gerbil/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajaskier/gerbil/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajaskier/gerbil/contents/{+path}","compare_url":"https://api.github.com/repos/ajaskier/gerbil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajaskier/gerbil/merges","archive_url":"https://api.github.com/repos/ajaskier/gerbil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajaskier/gerbil/downloads","issues_url":"https://api.github.com/repos/ajaskier/gerbil/issues{/number}","pulls_url":"https://api.github.com/repos/ajaskier/gerbil/pulls{/number}","milestones_url":"https://api.github.com/repos/ajaskier/gerbil/milestones{/number}","notifications_url":"https://api.github.com/repos/ajaskier/gerbil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajaskier/gerbil/labels{/name}","releases_url":"https://api.github.com/repos/ajaskier/gerbil/releases{/id}","created_at":"2015-07-02T21:34:22Z","updated_at":"2015-07-02T21:34:24Z","pushed_at":"2015-07-31T09:34:18Z","git_url":"git://github.com/ajaskier/gerbil.git","ssh_url":"git@github.com:ajaskier/gerbil.git","clone_url":"https://github.com/ajaskier/gerbil.git","svn_url":"https://github.com/ajaskier/gerbil","homepage":"http://gerbilvis.org","size":5609,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gerbilvis:master","ref":"master","sha":"1b90b55046e185aa14412447117278899012694d","user":{"login":"gerbilvis","id":13156887,"avatar_url":"https://avatars.githubusercontent.com/u/13156887?v=3","gravatar_id":"","url":"https://api.github.com/users/gerbilvis","html_url":"https://github.com/gerbilvis","followers_url":"https://api.github.com/users/gerbilvis/followers","following_url":"https://api.github.com/users/gerbilvis/following{/other_user}","gists_url":"https://api.github.com/users/gerbilvis/gists{/gist_id}","starred_url":"https://api.github.com/users/gerbilvis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerbilvis/subscriptions","organizations_url":"https://api.github.com/users/gerbilvis/orgs","repos_url":"https://api.github.com/users/gerbilvis/repos","events_url":"https://api.github.com/users/gerbilvis/events{/privacy}","received_events_url":"https://api.github.com/users/gerbilvis/received_events","type":"Organization","site_admin":false},"repo":{"id":38456165,"name":"gerbil","full_name":"gerbilvis/gerbil","owner":{"login":"gerbilvis","id":13156887,"avatar_url":"https://avatars.githubusercontent.com/u/13156887?v=3","gravatar_id":"","url":"https://api.github.com/users/gerbilvis","html_url":"https://github.com/gerbilvis","followers_url":"https://api.github.com/users/gerbilvis/followers","following_url":"https://api.github.com/users/gerbilvis/following{/other_user}","gists_url":"https://api.github.com/users/gerbilvis/gists{/gist_id}","starred_url":"https://api.github.com/users/gerbilvis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerbilvis/subscriptions","organizations_url":"https://api.github.com/users/gerbilvis/orgs","repos_url":"https://api.github.com/users/gerbilvis/repos","events_url":"https://api.github.com/users/gerbilvis/events{/privacy}","received_events_url":"https://api.github.com/users/gerbilvis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gerbilvis/gerbil","description":"Gerbil Hyperspectral Visualization and Analysis Framework","fork":false,"url":"https://api.github.com/repos/gerbilvis/gerbil","forks_url":"https://api.github.com/repos/gerbilvis/gerbil/forks","keys_url":"https://api.github.com/repos/gerbilvis/gerbil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gerbilvis/gerbil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gerbilvis/gerbil/teams","hooks_url":"https://api.github.com/repos/gerbilvis/gerbil/hooks","issue_events_url":"https://api.github.com/repos/gerbilvis/gerbil/issues/events{/number}","events_url":"https://api.github.com/repos/gerbilvis/gerbil/events","assignees_url":"https://api.github.com/repos/gerbilvis/gerbil/assignees{/user}","branches_url":"https://api.github.com/repos/gerbilvis/gerbil/branches{/branch}","tags_url":"https://api.github.com/repos/gerbilvis/gerbil/tags","blobs_url":"https://api.github.com/repos/gerbilvis/gerbil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gerbilvis/gerbil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gerbilvis/gerbil/git/refs{/sha}","trees_url":"https://api.github.com/repos/gerbilvis/gerbil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gerbilvis/gerbil/statuses/{sha}","languages_url":"https://api.github.com/repos/gerbilvis/gerbil/languages","stargazers_url":"https://api.github.com/repos/gerbilvis/gerbil/stargazers","contributors_url":"https://api.github.com/repos/gerbilvis/gerbil/contributors","subscribers_url":"https://api.github.com/repos/gerbilvis/gerbil/subscribers","subscription_url":"https://api.github.com/repos/gerbilvis/gerbil/subscription","commits_url":"https://api.github.com/repos/gerbilvis/gerbil/commits{/sha}","git_commits_url":"https://api.github.com/repos/gerbilvis/gerbil/git/commits{/sha}","comments_url":"https://api.github.com/repos/gerbilvis/gerbil/comments{/number}","issue_comment_url":"https://api.github.com/repos/gerbilvis/gerbil/issues/comments{/number}","contents_url":"https://api.github.com/repos/gerbilvis/gerbil/contents/{+path}","compare_url":"https://api.github.com/repos/gerbilvis/gerbil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gerbilvis/gerbil/merges","archive_url":"https://api.github.com/repos/gerbilvis/gerbil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gerbilvis/gerbil/downloads","issues_url":"https://api.github.com/repos/gerbilvis/gerbil/issues{/number}","pulls_url":"https://api.github.com/repos/gerbilvis/gerbil/pulls{/number}","milestones_url":"https://api.github.com/repos/gerbilvis/gerbil/milestones{/number}","notifications_url":"https://api.github.com/repos/gerbilvis/gerbil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gerbilvis/gerbil/labels{/name}","releases_url":"https://api.github.com/repos/gerbilvis/gerbil/releases{/id}","created_at":"2015-07-02T20:47:18Z","updated_at":"2015-07-21T12:09:55Z","pushed_at":"2015-07-31T09:47:57Z","git_url":"git://github.com/gerbilvis/gerbil.git","ssh_url":"git@github.com:gerbilvis/gerbil.git","clone_url":"https://github.com/gerbilvis/gerbil.git","svn_url":"https://github.com/gerbilvis/gerbil","homepage":"http://gerbilvis.org","size":5519,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gerbilvis/gerbil/pulls/7"},"html":{"href":"https://github.com/gerbilvis/gerbil/pull/7"},"issue":{"href":"https://api.github.com/repos/gerbilvis/gerbil/issues/7"},"comments":{"href":"https://api.github.com/repos/gerbilvis/gerbil/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/gerbilvis/gerbil/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/gerbilvis/gerbil/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gerbilvis/gerbil/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/gerbilvis/gerbil/statuses/84f8a70709e4541247410163f437be3ffc6d47ba"}}}}