{"action":"opened","number":120,"pull_request":{"url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/pulls/120","id":54763809,"html_url":"https://github.com/CenterForOpenScience/OSF-Offline/pull/120","diff_url":"https://github.com/CenterForOpenScience/OSF-Offline/pull/120.diff","patch_url":"https://github.com/CenterForOpenScience/OSF-Offline/pull/120.patch","issue_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/issues/120","number":120,"state":"open","locked":false,"title":"[WIP] Windows sync issues","user":{"login":"abought","id":2957073,"avatar_url":"https://avatars.githubusercontent.com/u/2957073?v=3","gravatar_id":"","url":"https://api.github.com/users/abought","html_url":"https://github.com/abought","followers_url":"https://api.github.com/users/abought/followers","following_url":"https://api.github.com/users/abought/following{/other_user}","gists_url":"https://api.github.com/users/abought/gists{/gist_id}","starred_url":"https://api.github.com/users/abought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abought/subscriptions","organizations_url":"https://api.github.com/users/abought/orgs","repos_url":"https://api.github.com/users/abought/repos","events_url":"https://api.github.com/users/abought/events{/privacy}","received_events_url":"https://api.github.com/users/abought/received_events","type":"User","site_admin":false},"body":"Refs OFF-62\r\n\r\n## Purpose\r\nAddress problems with sync functionality on Windows operating systems.\r\n\r\n\r\n## Summary of changes\r\n- Replace several hardcoded OS-specific path separators with `os.path.sep`.\r\n  - Fixes issue where first sync attempt lead to `parent is None` errors, and subsequent attempts lead to database integrity errors\r\n- Add docstrings to clarify differences between methods.\r\n\r\n## To do\r\nWhile testing, uncovered a secondary issue: on Windows, creating a new file in a folder fired an `Update` event, instead of a `Create` event. Although sync would complete correctly the second time through, this is not ideal. Problem did not occur on Mac OS and appears to be watchdog related.","created_at":"2015-12-29T22:32:02Z","updated_at":"2015-12-29T22:32:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/pulls/120/commits","review_comments_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/pulls/120/comments","review_comment_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/issues/120/comments","statuses_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/statuses/8cec9020c2641fba1bb032042b8500d357f9bfe3","head":{"label":"abought:fix/off62-windows-sync","ref":"fix/off62-windows-sync","sha":"8cec9020c2641fba1bb032042b8500d357f9bfe3","user":{"login":"abought","id":2957073,"avatar_url":"https://avatars.githubusercontent.com/u/2957073?v=3","gravatar_id":"","url":"https://api.github.com/users/abought","html_url":"https://github.com/abought","followers_url":"https://api.github.com/users/abought/followers","following_url":"https://api.github.com/users/abought/following{/other_user}","gists_url":"https://api.github.com/users/abought/gists{/gist_id}","starred_url":"https://api.github.com/users/abought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abought/subscriptions","organizations_url":"https://api.github.com/users/abought/orgs","repos_url":"https://api.github.com/users/abought/repos","events_url":"https://api.github.com/users/abought/events{/privacy}","received_events_url":"https://api.github.com/users/abought/received_events","type":"User","site_admin":false},"repo":{"id":45575056,"name":"OSF-Offline","full_name":"abought/OSF-Offline","owner":{"login":"abought","id":2957073,"avatar_url":"https://avatars.githubusercontent.com/u/2957073?v=3","gravatar_id":"","url":"https://api.github.com/users/abought","html_url":"https://github.com/abought","followers_url":"https://api.github.com/users/abought/followers","following_url":"https://api.github.com/users/abought/following{/other_user}","gists_url":"https://api.github.com/users/abought/gists{/gist_id}","starred_url":"https://api.github.com/users/abought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abought/subscriptions","organizations_url":"https://api.github.com/users/abought/orgs","repos_url":"https://api.github.com/users/abought/repos","events_url":"https://api.github.com/users/abought/events{/privacy}","received_events_url":"https://api.github.com/users/abought/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abought/OSF-Offline","description":"Desktop Synchronization for OSF Projects ","fork":true,"url":"https://api.github.com/repos/abought/OSF-Offline","forks_url":"https://api.github.com/repos/abought/OSF-Offline/forks","keys_url":"https://api.github.com/repos/abought/OSF-Offline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abought/OSF-Offline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abought/OSF-Offline/teams","hooks_url":"https://api.github.com/repos/abought/OSF-Offline/hooks","issue_events_url":"https://api.github.com/repos/abought/OSF-Offline/issues/events{/number}","events_url":"https://api.github.com/repos/abought/OSF-Offline/events","assignees_url":"https://api.github.com/repos/abought/OSF-Offline/assignees{/user}","branches_url":"https://api.github.com/repos/abought/OSF-Offline/branches{/branch}","tags_url":"https://api.github.com/repos/abought/OSF-Offline/tags","blobs_url":"https://api.github.com/repos/abought/OSF-Offline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abought/OSF-Offline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abought/OSF-Offline/git/refs{/sha}","trees_url":"https://api.github.com/repos/abought/OSF-Offline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abought/OSF-Offline/statuses/{sha}","languages_url":"https://api.github.com/repos/abought/OSF-Offline/languages","stargazers_url":"https://api.github.com/repos/abought/OSF-Offline/stargazers","contributors_url":"https://api.github.com/repos/abought/OSF-Offline/contributors","subscribers_url":"https://api.github.com/repos/abought/OSF-Offline/subscribers","subscription_url":"https://api.github.com/repos/abought/OSF-Offline/subscription","commits_url":"https://api.github.com/repos/abought/OSF-Offline/commits{/sha}","git_commits_url":"https://api.github.com/repos/abought/OSF-Offline/git/commits{/sha}","comments_url":"https://api.github.com/repos/abought/OSF-Offline/comments{/number}","issue_comment_url":"https://api.github.com/repos/abought/OSF-Offline/issues/comments{/number}","contents_url":"https://api.github.com/repos/abought/OSF-Offline/contents/{+path}","compare_url":"https://api.github.com/repos/abought/OSF-Offline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abought/OSF-Offline/merges","archive_url":"https://api.github.com/repos/abought/OSF-Offline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abought/OSF-Offline/downloads","issues_url":"https://api.github.com/repos/abought/OSF-Offline/issues{/number}","pulls_url":"https://api.github.com/repos/abought/OSF-Offline/pulls{/number}","milestones_url":"https://api.github.com/repos/abought/OSF-Offline/milestones{/number}","notifications_url":"https://api.github.com/repos/abought/OSF-Offline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abought/OSF-Offline/labels{/name}","releases_url":"https://api.github.com/repos/abought/OSF-Offline/releases{/id}","created_at":"2015-11-04T23:48:21Z","updated_at":"2015-07-10T23:05:38Z","pushed_at":"2015-12-29T21:16:00Z","git_url":"git://github.com/abought/OSF-Offline.git","ssh_url":"git@github.com:abought/OSF-Offline.git","clone_url":"https://github.com/abought/OSF-Offline.git","svn_url":"https://github.com/abought/OSF-Offline","homepage":null,"size":2167,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"CenterForOpenScience:develop","ref":"develop","sha":"5a36833c90394f1631bb74e37ea37656feb36ce5","user":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars.githubusercontent.com/u/3344584?v=3","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"repo":{"id":37069756,"name":"OSF-Offline","full_name":"CenterForOpenScience/OSF-Offline","owner":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars.githubusercontent.com/u/3344584?v=3","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CenterForOpenScience/OSF-Offline","description":"Desktop Synchronization for OSF Projects ","fork":false,"url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline","forks_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/forks","keys_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/teams","hooks_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/hooks","issue_events_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/issues/events{/number}","events_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/events","assignees_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/assignees{/user}","branches_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/branches{/branch}","tags_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/tags","blobs_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/git/refs{/sha}","trees_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/statuses/{sha}","languages_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/languages","stargazers_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/stargazers","contributors_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/contributors","subscribers_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/subscribers","subscription_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/subscription","commits_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/commits{/sha}","git_commits_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/git/commits{/sha}","comments_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/comments{/number}","issue_comment_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/issues/comments{/number}","contents_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/contents/{+path}","compare_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/merges","archive_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/downloads","issues_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/issues{/number}","pulls_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/pulls{/number}","milestones_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/milestones{/number}","notifications_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/labels{/name}","releases_url":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/releases{/id}","created_at":"2015-06-08T13:50:50Z","updated_at":"2015-12-16T23:11:07Z","pushed_at":"2015-12-29T22:15:28Z","git_url":"git://github.com/CenterForOpenScience/OSF-Offline.git","ssh_url":"git@github.com:CenterForOpenScience/OSF-Offline.git","clone_url":"https://github.com/CenterForOpenScience/OSF-Offline.git","svn_url":"https://github.com/CenterForOpenScience/OSF-Offline","homepage":null,"size":2235,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":10,"forks":9,"open_issues":10,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/pulls/120"},"html":{"href":"https://github.com/CenterForOpenScience/OSF-Offline/pull/120"},"issue":{"href":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/issues/120"},"comments":{"href":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/issues/120/comments"},"review_comments":{"href":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/pulls/120/comments"},"review_comment":{"href":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/pulls/120/commits"},"statuses":{"href":"https://api.github.com/repos/CenterForOpenScience/OSF-Offline/statuses/8cec9020c2641fba1bb032042b8500d357f9bfe3"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":19,"deletions":10,"changed_files":5}}