{"action":"created","issue":{"url":"https://api.github.com/repos/nunit/nunit/issues/458","labels_url":"https://api.github.com/repos/nunit/nunit/issues/458/labels{/name}","comments_url":"https://api.github.com/repos/nunit/nunit/issues/458/comments","events_url":"https://api.github.com/repos/nunit/nunit/issues/458/events","html_url":"https://github.com/nunit/nunit/pull/458","id":54208895,"number":458,"title":"Issue 368","user":{"login":"CharliePoole","id":2678661,"avatar_url":"https://avatars.githubusercontent.com/u/2678661?v=3","gravatar_id":"","url":"https://api.github.com/users/CharliePoole","html_url":"https://github.com/CharliePoole","followers_url":"https://api.github.com/users/CharliePoole/followers","following_url":"https://api.github.com/users/CharliePoole/following{/other_user}","gists_url":"https://api.github.com/users/CharliePoole/gists{/gist_id}","starred_url":"https://api.github.com/users/CharliePoole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CharliePoole/subscriptions","organizations_url":"https://api.github.com/users/CharliePoole/orgs","repos_url":"https://api.github.com/users/CharliePoole/repos","events_url":"https://api.github.com/users/CharliePoole/events{/privacy}","received_events_url":"https://api.github.com/users/CharliePoole/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-01-13T15:46:22Z","updated_at":"2015-01-14T20:40:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nunit/nunit/pulls/458","html_url":"https://github.com/nunit/nunit/pull/458","diff_url":"https://github.com/nunit/nunit/pull/458.diff","patch_url":"https://github.com/nunit/nunit/pull/458.patch"},"body":"This fixes #368 by adding our own .NET 2.0 build of mono.addins to the solution and initializing it from the test engine. Three extension points are defined:\r\n  * Framework Drivers\r\n  * Project Loaders\r\n  * Result Writers\r\nMore may be added in the future.\r\n\r\nNo addins are yet looked for or available. Other issues deal with handling addins of the above three types.\r\n\r\nFrom discussions with Lluis, the maintainer of mono.addins, it appears we will eventually want to change the name of the assembly from Mono.Addins to something else in order to permit runners that use addins themselves to make use of NUnit.\r\n\r\nI'm continuing to work on this branch, so don't delete it."},"comment":{"url":"https://api.github.com/repos/nunit/nunit/issues/comments/69987350","html_url":"https://github.com/nunit/nunit/pull/458#issuecomment-69987350","issue_url":"https://api.github.com/repos/nunit/nunit/issues/458","id":69987350,"user":{"login":"CharliePoole","id":2678661,"avatar_url":"https://avatars.githubusercontent.com/u/2678661?v=3","gravatar_id":"","url":"https://api.github.com/users/CharliePoole","html_url":"https://github.com/CharliePoole","followers_url":"https://api.github.com/users/CharliePoole/followers","following_url":"https://api.github.com/users/CharliePoole/following{/other_user}","gists_url":"https://api.github.com/users/CharliePoole/gists{/gist_id}","starred_url":"https://api.github.com/users/CharliePoole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CharliePoole/subscriptions","organizations_url":"https://api.github.com/users/CharliePoole/orgs","repos_url":"https://api.github.com/users/CharliePoole/repos","events_url":"https://api.github.com/users/CharliePoole/events{/privacy}","received_events_url":"https://api.github.com/users/CharliePoole/received_events","type":"User","site_admin":false},"created_at":"2015-01-14T20:40:02Z","updated_at":"2015-01-14T20:40:02Z","body":"I should mention, btw, that the files in the Compatibility folder, with the\r\nexception of Tuple.cs are taken almost asis from mono. I only removed some\r\n#if conditions that would have excluded the code from our 2.0 build.\r\n\r\nI agree about the signing key. I'm holding off on the name change for the\r\nmoment however.\r\n\r\n\r\n\r\nOn Wed, Jan 14, 2015 at 12:36 PM, Rob Prouse <notifications@github.com>\r\nwrote:\r\n\r\n> That was a tough code review. My browser did not like that many files [image:\r\n> :-1:]\r\n>\r\n> Looks good except for the build configuration. If we change the namespace\r\n> to make it our own, we should also change the signing key to ours.\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub\r\n> <https://github.com/nunit/nunit/pull/458#issuecomment-69986818>.\r\n>"}}