{"action":"closed","number":661,"pull_request":{"url":"https://api.github.com/repos/lxc/lxd/pulls/661","id":35446004,"html_url":"https://github.com/lxc/lxd/pull/661","diff_url":"https://github.com/lxc/lxd/pull/661.diff","patch_url":"https://github.com/lxc/lxd/pull/661.patch","issue_url":"https://api.github.com/repos/lxc/lxd/issues/661","number":661,"state":"closed","locked":false,"title":"More data layer fixes","user":{"login":"chrisglass","id":25211,"avatar_url":"https://avatars.githubusercontent.com/u/25211?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisglass","html_url":"https://github.com/chrisglass","followers_url":"https://api.github.com/users/chrisglass/followers","following_url":"https://api.github.com/users/chrisglass/following{/other_user}","gists_url":"https://api.github.com/users/chrisglass/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisglass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisglass/subscriptions","organizations_url":"https://api.github.com/users/chrisglass/orgs","repos_url":"https://api.github.com/users/chrisglass/repos","events_url":"https://api.github.com/users/chrisglass/events{/privacy}","received_events_url":"https://api.github.com/users/chrisglass/received_events","type":"User","site_admin":false},"body":"Mostly focused on decoupling the data layer from the rest by passing in\r\nreferences to the sql.DB instead of the daemon.\r\n\r\nAnother instance of removing a SQL statement (preemtively counting is\r\nnot necessary, just let it fail when doing the actual work).\r\n\r\nRefactored the db_test.go file to be a little more DRY.\r\n\r\nSigned-off-by: Chris Glass <tribaal@gmail.com>","created_at":"2015-05-14T18:09:13Z","updated_at":"2015-05-15T16:16:07Z","closed_at":"2015-05-15T16:16:07Z","merged_at":"2015-05-15T16:16:07Z","merge_commit_sha":"ca517b10579eb34f575d9068ef74e20cd5a7acb8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lxc/lxd/pulls/661/commits","review_comments_url":"https://api.github.com/repos/lxc/lxd/pulls/661/comments","review_comment_url":"https://api.github.com/repos/lxc/lxd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lxc/lxd/issues/661/comments","statuses_url":"https://api.github.com/repos/lxc/lxd/statuses/81c5dd72e336d9a0fbe83b844b68455c6639e3f3","head":{"label":"chrisglass:more-db-fixes","ref":"more-db-fixes","sha":"81c5dd72e336d9a0fbe83b844b68455c6639e3f3","user":{"login":"chrisglass","id":25211,"avatar_url":"https://avatars.githubusercontent.com/u/25211?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisglass","html_url":"https://github.com/chrisglass","followers_url":"https://api.github.com/users/chrisglass/followers","following_url":"https://api.github.com/users/chrisglass/following{/other_user}","gists_url":"https://api.github.com/users/chrisglass/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisglass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisglass/subscriptions","organizations_url":"https://api.github.com/users/chrisglass/orgs","repos_url":"https://api.github.com/users/chrisglass/repos","events_url":"https://api.github.com/users/chrisglass/events{/privacy}","received_events_url":"https://api.github.com/users/chrisglass/received_events","type":"User","site_admin":false},"repo":{"id":26972442,"name":"lxd","full_name":"chrisglass/lxd","owner":{"login":"chrisglass","id":25211,"avatar_url":"https://avatars.githubusercontent.com/u/25211?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisglass","html_url":"https://github.com/chrisglass","followers_url":"https://api.github.com/users/chrisglass/followers","following_url":"https://api.github.com/users/chrisglass/following{/other_user}","gists_url":"https://api.github.com/users/chrisglass/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisglass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisglass/subscriptions","organizations_url":"https://api.github.com/users/chrisglass/orgs","repos_url":"https://api.github.com/users/chrisglass/repos","events_url":"https://api.github.com/users/chrisglass/events{/privacy}","received_events_url":"https://api.github.com/users/chrisglass/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chrisglass/lxd","description":"lxd (pronounced lex-dee) is a REST API, command line tool and OpenStack plugin based on liblxc","fork":true,"url":"https://api.github.com/repos/chrisglass/lxd","forks_url":"https://api.github.com/repos/chrisglass/lxd/forks","keys_url":"https://api.github.com/repos/chrisglass/lxd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chrisglass/lxd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chrisglass/lxd/teams","hooks_url":"https://api.github.com/repos/chrisglass/lxd/hooks","issue_events_url":"https://api.github.com/repos/chrisglass/lxd/issues/events{/number}","events_url":"https://api.github.com/repos/chrisglass/lxd/events","assignees_url":"https://api.github.com/repos/chrisglass/lxd/assignees{/user}","branches_url":"https://api.github.com/repos/chrisglass/lxd/branches{/branch}","tags_url":"https://api.github.com/repos/chrisglass/lxd/tags","blobs_url":"https://api.github.com/repos/chrisglass/lxd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chrisglass/lxd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chrisglass/lxd/git/refs{/sha}","trees_url":"https://api.github.com/repos/chrisglass/lxd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chrisglass/lxd/statuses/{sha}","languages_url":"https://api.github.com/repos/chrisglass/lxd/languages","stargazers_url":"https://api.github.com/repos/chrisglass/lxd/stargazers","contributors_url":"https://api.github.com/repos/chrisglass/lxd/contributors","subscribers_url":"https://api.github.com/repos/chrisglass/lxd/subscribers","subscription_url":"https://api.github.com/repos/chrisglass/lxd/subscription","commits_url":"https://api.github.com/repos/chrisglass/lxd/commits{/sha}","git_commits_url":"https://api.github.com/repos/chrisglass/lxd/git/commits{/sha}","comments_url":"https://api.github.com/repos/chrisglass/lxd/comments{/number}","issue_comment_url":"https://api.github.com/repos/chrisglass/lxd/issues/comments{/number}","contents_url":"https://api.github.com/repos/chrisglass/lxd/contents/{+path}","compare_url":"https://api.github.com/repos/chrisglass/lxd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chrisglass/lxd/merges","archive_url":"https://api.github.com/repos/chrisglass/lxd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chrisglass/lxd/downloads","issues_url":"https://api.github.com/repos/chrisglass/lxd/issues{/number}","pulls_url":"https://api.github.com/repos/chrisglass/lxd/pulls{/number}","milestones_url":"https://api.github.com/repos/chrisglass/lxd/milestones{/number}","notifications_url":"https://api.github.com/repos/chrisglass/lxd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chrisglass/lxd/labels{/name}","releases_url":"https://api.github.com/repos/chrisglass/lxd/releases{/id}","created_at":"2014-11-21T18:26:51Z","updated_at":"2015-05-08T20:14:01Z","pushed_at":"2015-05-15T15:56:00Z","git_url":"git://github.com/chrisglass/lxd.git","ssh_url":"git@github.com:chrisglass/lxd.git","clone_url":"https://github.com/chrisglass/lxd.git","svn_url":"https://github.com/chrisglass/lxd","homepage":"https://linuxcontainers.org","size":1977,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lxc:master","ref":"master","sha":"c9fb309b46b3585cbca86698412df675fc971c67","user":{"login":"lxc","id":2301756,"avatar_url":"https://avatars.githubusercontent.com/u/2301756?v=3","gravatar_id":"","url":"https://api.github.com/users/lxc","html_url":"https://github.com/lxc","followers_url":"https://api.github.com/users/lxc/followers","following_url":"https://api.github.com/users/lxc/following{/other_user}","gists_url":"https://api.github.com/users/lxc/gists{/gist_id}","starred_url":"https://api.github.com/users/lxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxc/subscriptions","organizations_url":"https://api.github.com/users/lxc/orgs","repos_url":"https://api.github.com/users/lxc/repos","events_url":"https://api.github.com/users/lxc/events{/privacy}","received_events_url":"https://api.github.com/users/lxc/received_events","type":"Organization","site_admin":false},"repo":{"id":26192117,"name":"lxd","full_name":"lxc/lxd","owner":{"login":"lxc","id":2301756,"avatar_url":"https://avatars.githubusercontent.com/u/2301756?v=3","gravatar_id":"","url":"https://api.github.com/users/lxc","html_url":"https://github.com/lxc","followers_url":"https://api.github.com/users/lxc/followers","following_url":"https://api.github.com/users/lxc/following{/other_user}","gists_url":"https://api.github.com/users/lxc/gists{/gist_id}","starred_url":"https://api.github.com/users/lxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxc/subscriptions","organizations_url":"https://api.github.com/users/lxc/orgs","repos_url":"https://api.github.com/users/lxc/repos","events_url":"https://api.github.com/users/lxc/events{/privacy}","received_events_url":"https://api.github.com/users/lxc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lxc/lxd","description":"Daemon based on liblxc offering a REST API to manage containers","fork":false,"url":"https://api.github.com/repos/lxc/lxd","forks_url":"https://api.github.com/repos/lxc/lxd/forks","keys_url":"https://api.github.com/repos/lxc/lxd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lxc/lxd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lxc/lxd/teams","hooks_url":"https://api.github.com/repos/lxc/lxd/hooks","issue_events_url":"https://api.github.com/repos/lxc/lxd/issues/events{/number}","events_url":"https://api.github.com/repos/lxc/lxd/events","assignees_url":"https://api.github.com/repos/lxc/lxd/assignees{/user}","branches_url":"https://api.github.com/repos/lxc/lxd/branches{/branch}","tags_url":"https://api.github.com/repos/lxc/lxd/tags","blobs_url":"https://api.github.com/repos/lxc/lxd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lxc/lxd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lxc/lxd/git/refs{/sha}","trees_url":"https://api.github.com/repos/lxc/lxd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lxc/lxd/statuses/{sha}","languages_url":"https://api.github.com/repos/lxc/lxd/languages","stargazers_url":"https://api.github.com/repos/lxc/lxd/stargazers","contributors_url":"https://api.github.com/repos/lxc/lxd/contributors","subscribers_url":"https://api.github.com/repos/lxc/lxd/subscribers","subscription_url":"https://api.github.com/repos/lxc/lxd/subscription","commits_url":"https://api.github.com/repos/lxc/lxd/commits{/sha}","git_commits_url":"https://api.github.com/repos/lxc/lxd/git/commits{/sha}","comments_url":"https://api.github.com/repos/lxc/lxd/comments{/number}","issue_comment_url":"https://api.github.com/repos/lxc/lxd/issues/comments{/number}","contents_url":"https://api.github.com/repos/lxc/lxd/contents/{+path}","compare_url":"https://api.github.com/repos/lxc/lxd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lxc/lxd/merges","archive_url":"https://api.github.com/repos/lxc/lxd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lxc/lxd/downloads","issues_url":"https://api.github.com/repos/lxc/lxd/issues{/number}","pulls_url":"https://api.github.com/repos/lxc/lxd/pulls{/number}","milestones_url":"https://api.github.com/repos/lxc/lxd/milestones{/number}","notifications_url":"https://api.github.com/repos/lxc/lxd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lxc/lxd/labels{/name}","releases_url":"https://api.github.com/repos/lxc/lxd/releases{/id}","created_at":"2014-11-04T22:40:52Z","updated_at":"2015-05-15T09:35:09Z","pushed_at":"2015-05-15T16:16:08Z","git_url":"git://github.com/lxc/lxd.git","ssh_url":"git@github.com:lxc/lxd.git","clone_url":"https://github.com/lxc/lxd.git","svn_url":"https://github.com/lxc/lxd","homepage":"https://linuxcontainers.org","size":6154,"stargazers_count":433,"watchers_count":433,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":53,"mirror_url":null,"open_issues_count":60,"forks":53,"open_issues":60,"watchers":433,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lxc/lxd/pulls/661"},"html":{"href":"https://github.com/lxc/lxd/pull/661"},"issue":{"href":"https://api.github.com/repos/lxc/lxd/issues/661"},"comments":{"href":"https://api.github.com/repos/lxc/lxd/issues/661/comments"},"review_comments":{"href":"https://api.github.com/repos/lxc/lxd/pulls/661/comments"},"review_comment":{"href":"https://api.github.com/repos/lxc/lxd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lxc/lxd/pulls/661/commits"},"statuses":{"href":"https://api.github.com/repos/lxc/lxd/statuses/81c5dd72e336d9a0fbe83b844b68455c6639e3f3"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tych0","id":785111,"avatar_url":"https://avatars.githubusercontent.com/u/785111?v=3","gravatar_id":"","url":"https://api.github.com/users/tych0","html_url":"https://github.com/tych0","followers_url":"https://api.github.com/users/tych0/followers","following_url":"https://api.github.com/users/tych0/following{/other_user}","gists_url":"https://api.github.com/users/tych0/gists{/gist_id}","starred_url":"https://api.github.com/users/tych0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tych0/subscriptions","organizations_url":"https://api.github.com/users/tych0/orgs","repos_url":"https://api.github.com/users/tych0/repos","events_url":"https://api.github.com/users/tych0/events{/privacy}","received_events_url":"https://api.github.com/users/tych0/received_events","type":"User","site_admin":false},"comments":0,"review_comments":5,"commits":2,"additions":251,"deletions":140,"changed_files":5}}