{"action":"created","comment":{"url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/comments/44311815","id":44311815,"diff_hunk":"@@ -44,6 +44,19 @@ def test_include_args_to_hash_from_array_of_hashes\n \n             assert_equal(expected, actual)\n           end\n+\n+          def test_array_of_string\n+            expected = {\n+              comments: { author: {}, attachment: {} }\n+            }\n+            input = [\n+              'comments.author',\n+              'comments.attachment'\n+            ]\n+            actual = Parsing.include_args_to_hash(input)\n+\n+            assert_equal(expected, actual)\n+          end","path":"test/include_tree/include_args_to_hash_test.rb","position":16,"original_position":16,"commit_id":"6407dbeadd675bb538b62469978f84ab4ebbe00d","original_commit_id":"6407dbeadd675bb538b62469978f84ab4ebbe00d","user":{"login":"bf4","id":142914,"avatar_url":"https://avatars.githubusercontent.com/u/142914?v=3","gravatar_id":"","url":"https://api.github.com/users/bf4","html_url":"https://github.com/bf4","followers_url":"https://api.github.com/users/bf4/followers","following_url":"https://api.github.com/users/bf4/following{/other_user}","gists_url":"https://api.github.com/users/bf4/gists{/gist_id}","starred_url":"https://api.github.com/users/bf4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bf4/subscriptions","organizations_url":"https://api.github.com/users/bf4/orgs","repos_url":"https://api.github.com/users/bf4/repos","events_url":"https://api.github.com/users/bf4/events{/privacy}","received_events_url":"https://api.github.com/users/bf4/received_events","type":"User","site_admin":false},"body":"Thanks for the test!","created_at":"2015-11-09T18:38:07Z","updated_at":"2015-11-09T18:38:07Z","html_url":"https://github.com/rails-api/active_model_serializers/pull/1320#discussion_r44311815","pull_request_url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1320","_links":{"self":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/comments/44311815"},"html":{"href":"https://github.com/rails-api/active_model_serializers/pull/1320#discussion_r44311815"},"pull_request":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1320"}}},"pull_request":{"url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1320","id":49975475,"html_url":"https://github.com/rails-api/active_model_serializers/pull/1320","diff_url":"https://github.com/rails-api/active_model_serializers/pull/1320.diff","patch_url":"https://github.com/rails-api/active_model_serializers/pull/1320.patch","issue_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/1320","number":1320,"state":"closed","locked":false,"title":"Add test and bugfix to include an array of string","user":{"login":"barodeur","id":303170,"avatar_url":"https://avatars.githubusercontent.com/u/303170?v=3","gravatar_id":"","url":"https://api.github.com/users/barodeur","html_url":"https://github.com/barodeur","followers_url":"https://api.github.com/users/barodeur/followers","following_url":"https://api.github.com/users/barodeur/following{/other_user}","gists_url":"https://api.github.com/users/barodeur/gists{/gist_id}","starred_url":"https://api.github.com/users/barodeur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barodeur/subscriptions","organizations_url":"https://api.github.com/users/barodeur/orgs","repos_url":"https://api.github.com/users/barodeur/repos","events_url":"https://api.github.com/users/barodeur/events{/privacy}","received_events_url":"https://api.github.com/users/barodeur/received_events","type":"User","site_admin":false},"body":"Hello,\r\n\r\nI ran into an issue yesterday as I was trying to include multiple attributes of a nested object.\r\n\r\nThe following section of the README made me think that I would have the result writing `['comments.author', 'comments.attachment']` or `'comments.author,comments.attachment'` but I didn't.\r\n\r\n```ruby\r\n# IN README\r\n\r\nrender @posts, include: ['author', 'comments', 'comments.author']\r\n# or\r\nrender @posts, include: 'author,comments,comments.author'\r\n```\r\n\r\nThe problem came from \r\n\r\n```ruby\r\ninclude_args_to_hash(['comments.author', `comments.attachment`])\r\n# => { :comments => { :attachment => {} } }\r\n\r\ninclude_args_to_hash('comments.author,comments.attachment')\r\n# => { :comments => { :author => {}, :attachment => {} } }\r\n```\r\n\r\nSo I think I found a bug, and here is the fix. ","created_at":"2015-11-06T16:39:27Z","updated_at":"2015-11-09T18:38:07Z","closed_at":"2015-11-06T16:58:06Z","merged_at":"2015-11-06T16:58:06Z","merge_commit_sha":"5ca4958b46afc894bdfa245bbcd4430f5e02c958","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1320/commits","review_comments_url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1320/comments","review_comment_url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/1320/comments","statuses_url":"https://api.github.com/repos/rails-api/active_model_serializers/statuses/6407dbeadd675bb538b62469978f84ab4ebbe00d","head":{"label":"barodeur:include-array-of-string","ref":"include-array-of-string","sha":"6407dbeadd675bb538b62469978f84ab4ebbe00d","user":{"login":"barodeur","id":303170,"avatar_url":"https://avatars.githubusercontent.com/u/303170?v=3","gravatar_id":"","url":"https://api.github.com/users/barodeur","html_url":"https://github.com/barodeur","followers_url":"https://api.github.com/users/barodeur/followers","following_url":"https://api.github.com/users/barodeur/following{/other_user}","gists_url":"https://api.github.com/users/barodeur/gists{/gist_id}","starred_url":"https://api.github.com/users/barodeur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barodeur/subscriptions","organizations_url":"https://api.github.com/users/barodeur/orgs","repos_url":"https://api.github.com/users/barodeur/repos","events_url":"https://api.github.com/users/barodeur/events{/privacy}","received_events_url":"https://api.github.com/users/barodeur/received_events","type":"User","site_admin":false},"repo":{"id":45691953,"name":"active_model_serializers","full_name":"barodeur/active_model_serializers","owner":{"login":"barodeur","id":303170,"avatar_url":"https://avatars.githubusercontent.com/u/303170?v=3","gravatar_id":"","url":"https://api.github.com/users/barodeur","html_url":"https://github.com/barodeur","followers_url":"https://api.github.com/users/barodeur/followers","following_url":"https://api.github.com/users/barodeur/following{/other_user}","gists_url":"https://api.github.com/users/barodeur/gists{/gist_id}","starred_url":"https://api.github.com/users/barodeur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barodeur/subscriptions","organizations_url":"https://api.github.com/users/barodeur/orgs","repos_url":"https://api.github.com/users/barodeur/repos","events_url":"https://api.github.com/users/barodeur/events{/privacy}","received_events_url":"https://api.github.com/users/barodeur/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/barodeur/active_model_serializers","description":"ActiveModel::Serializer implementation and Rails hooks","fork":true,"url":"https://api.github.com/repos/barodeur/active_model_serializers","forks_url":"https://api.github.com/repos/barodeur/active_model_serializers/forks","keys_url":"https://api.github.com/repos/barodeur/active_model_serializers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/barodeur/active_model_serializers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/barodeur/active_model_serializers/teams","hooks_url":"https://api.github.com/repos/barodeur/active_model_serializers/hooks","issue_events_url":"https://api.github.com/repos/barodeur/active_model_serializers/issues/events{/number}","events_url":"https://api.github.com/repos/barodeur/active_model_serializers/events","assignees_url":"https://api.github.com/repos/barodeur/active_model_serializers/assignees{/user}","branches_url":"https://api.github.com/repos/barodeur/active_model_serializers/branches{/branch}","tags_url":"https://api.github.com/repos/barodeur/active_model_serializers/tags","blobs_url":"https://api.github.com/repos/barodeur/active_model_serializers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/barodeur/active_model_serializers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/barodeur/active_model_serializers/git/refs{/sha}","trees_url":"https://api.github.com/repos/barodeur/active_model_serializers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/barodeur/active_model_serializers/statuses/{sha}","languages_url":"https://api.github.com/repos/barodeur/active_model_serializers/languages","stargazers_url":"https://api.github.com/repos/barodeur/active_model_serializers/stargazers","contributors_url":"https://api.github.com/repos/barodeur/active_model_serializers/contributors","subscribers_url":"https://api.github.com/repos/barodeur/active_model_serializers/subscribers","subscription_url":"https://api.github.com/repos/barodeur/active_model_serializers/subscription","commits_url":"https://api.github.com/repos/barodeur/active_model_serializers/commits{/sha}","git_commits_url":"https://api.github.com/repos/barodeur/active_model_serializers/git/commits{/sha}","comments_url":"https://api.github.com/repos/barodeur/active_model_serializers/comments{/number}","issue_comment_url":"https://api.github.com/repos/barodeur/active_model_serializers/issues/comments{/number}","contents_url":"https://api.github.com/repos/barodeur/active_model_serializers/contents/{+path}","compare_url":"https://api.github.com/repos/barodeur/active_model_serializers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/barodeur/active_model_serializers/merges","archive_url":"https://api.github.com/repos/barodeur/active_model_serializers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/barodeur/active_model_serializers/downloads","issues_url":"https://api.github.com/repos/barodeur/active_model_serializers/issues{/number}","pulls_url":"https://api.github.com/repos/barodeur/active_model_serializers/pulls{/number}","milestones_url":"https://api.github.com/repos/barodeur/active_model_serializers/milestones{/number}","notifications_url":"https://api.github.com/repos/barodeur/active_model_serializers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/barodeur/active_model_serializers/labels{/name}","releases_url":"https://api.github.com/repos/barodeur/active_model_serializers/releases{/id}","created_at":"2015-11-06T16:03:15Z","updated_at":"2015-11-06T16:03:16Z","pushed_at":"2015-11-06T16:26:37Z","git_url":"git://github.com/barodeur/active_model_serializers.git","ssh_url":"git@github.com:barodeur/active_model_serializers.git","clone_url":"https://github.com/barodeur/active_model_serializers.git","svn_url":"https://github.com/barodeur/active_model_serializers","homepage":"","size":7977,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails-api:master","ref":"master","sha":"0200d89da8fdd989ddf6fb6e85c8a9818669c943","user":{"login":"rails-api","id":2820360,"avatar_url":"https://avatars.githubusercontent.com/u/2820360?v=3","gravatar_id":"","url":"https://api.github.com/users/rails-api","html_url":"https://github.com/rails-api","followers_url":"https://api.github.com/users/rails-api/followers","following_url":"https://api.github.com/users/rails-api/following{/other_user}","gists_url":"https://api.github.com/users/rails-api/gists{/gist_id}","starred_url":"https://api.github.com/users/rails-api/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails-api/subscriptions","organizations_url":"https://api.github.com/users/rails-api/orgs","repos_url":"https://api.github.com/users/rails-api/repos","events_url":"https://api.github.com/users/rails-api/events{/privacy}","received_events_url":"https://api.github.com/users/rails-api/received_events","type":"Organization","site_admin":false},"repo":{"id":2889230,"name":"active_model_serializers","full_name":"rails-api/active_model_serializers","owner":{"login":"rails-api","id":2820360,"avatar_url":"https://avatars.githubusercontent.com/u/2820360?v=3","gravatar_id":"","url":"https://api.github.com/users/rails-api","html_url":"https://github.com/rails-api","followers_url":"https://api.github.com/users/rails-api/followers","following_url":"https://api.github.com/users/rails-api/following{/other_user}","gists_url":"https://api.github.com/users/rails-api/gists{/gist_id}","starred_url":"https://api.github.com/users/rails-api/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails-api/subscriptions","organizations_url":"https://api.github.com/users/rails-api/orgs","repos_url":"https://api.github.com/users/rails-api/repos","events_url":"https://api.github.com/users/rails-api/events{/privacy}","received_events_url":"https://api.github.com/users/rails-api/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails-api/active_model_serializers","description":"ActiveModel::Serializer implementation and Rails hooks","fork":false,"url":"https://api.github.com/repos/rails-api/active_model_serializers","forks_url":"https://api.github.com/repos/rails-api/active_model_serializers/forks","keys_url":"https://api.github.com/repos/rails-api/active_model_serializers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails-api/active_model_serializers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails-api/active_model_serializers/teams","hooks_url":"https://api.github.com/repos/rails-api/active_model_serializers/hooks","issue_events_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/events{/number}","events_url":"https://api.github.com/repos/rails-api/active_model_serializers/events","assignees_url":"https://api.github.com/repos/rails-api/active_model_serializers/assignees{/user}","branches_url":"https://api.github.com/repos/rails-api/active_model_serializers/branches{/branch}","tags_url":"https://api.github.com/repos/rails-api/active_model_serializers/tags","blobs_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails-api/active_model_serializers/statuses/{sha}","languages_url":"https://api.github.com/repos/rails-api/active_model_serializers/languages","stargazers_url":"https://api.github.com/repos/rails-api/active_model_serializers/stargazers","contributors_url":"https://api.github.com/repos/rails-api/active_model_serializers/contributors","subscribers_url":"https://api.github.com/repos/rails-api/active_model_serializers/subscribers","subscription_url":"https://api.github.com/repos/rails-api/active_model_serializers/subscription","commits_url":"https://api.github.com/repos/rails-api/active_model_serializers/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails-api/active_model_serializers/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails-api/active_model_serializers/contents/{+path}","compare_url":"https://api.github.com/repos/rails-api/active_model_serializers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails-api/active_model_serializers/merges","archive_url":"https://api.github.com/repos/rails-api/active_model_serializers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails-api/active_model_serializers/downloads","issues_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues{/number}","pulls_url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls{/number}","milestones_url":"https://api.github.com/repos/rails-api/active_model_serializers/milestones{/number}","notifications_url":"https://api.github.com/repos/rails-api/active_model_serializers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails-api/active_model_serializers/labels{/name}","releases_url":"https://api.github.com/repos/rails-api/active_model_serializers/releases{/id}","created_at":"2011-12-01T06:39:26Z","updated_at":"2015-11-09T16:32:17Z","pushed_at":"2015-11-09T06:35:07Z","git_url":"git://github.com/rails-api/active_model_serializers.git","ssh_url":"git@github.com:rails-api/active_model_serializers.git","clone_url":"https://github.com/rails-api/active_model_serializers.git","svn_url":"https://github.com/rails-api/active_model_serializers","homepage":"","size":7977,"stargazers_count":3109,"watchers_count":3109,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":727,"mirror_url":null,"open_issues_count":180,"forks":727,"open_issues":180,"watchers":3109,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1320"},"html":{"href":"https://github.com/rails-api/active_model_serializers/pull/1320"},"issue":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/issues/1320"},"comments":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/issues/1320/comments"},"review_comments":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1320/comments"},"review_comment":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1320/commits"},"statuses":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/statuses/6407dbeadd675bb538b62469978f84ab4ebbe00d"}}}}