{"action":"created","comment":{"url":"https://api.github.com/repos/clojure-emacs/inf-clojure/pulls/comments/23128821","id":23128821,"diff_hunk":"@@ -126,8 +131,9 @@ The following commands are available:\n \\\\{inf-clojure-minor-mode-map}\"\n   :lighter \"\" :keymap inf-clojure-minor-mode-map\n   (make-local-variable 'completion-at-point-functions)\n-  (add-to-list 'completion-at-point-functions\n-               #'inf-clojure-completion-at-point))\n+  (when inf-clojure-minor-mode-completions","path":"inf-clojure.el","position":18,"original_position":18,"commit_id":"d8ce9bbbc55cd3eb6ca538587ec13d6f6d66582c","original_commit_id":"d8ce9bbbc55cd3eb6ca538587ec13d6f6d66582c","user":{"login":"bbatsov","id":103882,"avatar_url":"https://avatars.githubusercontent.com/u/103882?v=3","gravatar_id":"","url":"https://api.github.com/users/bbatsov","html_url":"https://github.com/bbatsov","followers_url":"https://api.github.com/users/bbatsov/followers","following_url":"https://api.github.com/users/bbatsov/following{/other_user}","gists_url":"https://api.github.com/users/bbatsov/gists{/gist_id}","starred_url":"https://api.github.com/users/bbatsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbatsov/subscriptions","organizations_url":"https://api.github.com/users/bbatsov/orgs","repos_url":"https://api.github.com/users/bbatsov/repos","events_url":"https://api.github.com/users/bbatsov/events{/privacy}","received_events_url":"https://api.github.com/users/bbatsov/received_events","type":"User","site_admin":false},"body":"This is not a good solution as it will require the users to set this **before** loading inf-clojure, which will certainly lead to confusion. Generally such config option should be consulted at runtime to avoid such problems. This can also be done much simpler by setting `completion-at-point-functions` to `nil` in the mode's hook.","created_at":"2015-01-17T21:57:18Z","updated_at":"2015-01-17T21:57:18Z","html_url":"https://github.com/clojure-emacs/inf-clojure/pull/10#discussion_r23128821","pull_request_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/clojure-emacs/inf-clojure/pulls/comments/23128821"},"html":{"href":"https://github.com/clojure-emacs/inf-clojure/pull/10#discussion_r23128821"},"pull_request":{"href":"https://api.github.com/repos/clojure-emacs/inf-clojure/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/clojure-emacs/inf-clojure/pulls/10","id":27525641,"html_url":"https://github.com/clojure-emacs/inf-clojure/pull/10","diff_url":"https://github.com/clojure-emacs/inf-clojure/pull/10.diff","patch_url":"https://github.com/clojure-emacs/inf-clojure/pull/10.patch","issue_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/issues/10","number":10,"state":"open","locked":false,"title":"Configuration option for disabling completions in minor mode","user":{"login":"martintrojer","id":1161940,"avatar_url":"https://avatars.githubusercontent.com/u/1161940?v=3","gravatar_id":"","url":"https://api.github.com/users/martintrojer","html_url":"https://github.com/martintrojer","followers_url":"https://api.github.com/users/martintrojer/followers","following_url":"https://api.github.com/users/martintrojer/following{/other_user}","gists_url":"https://api.github.com/users/martintrojer/gists{/gist_id}","starred_url":"https://api.github.com/users/martintrojer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martintrojer/subscriptions","organizations_url":"https://api.github.com/users/martintrojer/orgs","repos_url":"https://api.github.com/users/martintrojer/repos","events_url":"https://api.github.com/users/martintrojer/events{/privacy}","received_events_url":"https://api.github.com/users/martintrojer/received_events","type":"User","site_admin":false},"body":"fixes #5","created_at":"2015-01-16T18:26:07Z","updated_at":"2015-01-17T21:57:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be9f6b79b8d3596ec82b43bc57031592ea3627ce","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/pulls/10/commits","review_comments_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/pulls/10/comments","review_comment_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/pulls/comments/{number}","comments_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/issues/10/comments","statuses_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/statuses/d8ce9bbbc55cd3eb6ca538587ec13d6f6d66582c","head":{"label":"martintrojer:master","ref":"master","sha":"d8ce9bbbc55cd3eb6ca538587ec13d6f6d66582c","user":{"login":"martintrojer","id":1161940,"avatar_url":"https://avatars.githubusercontent.com/u/1161940?v=3","gravatar_id":"","url":"https://api.github.com/users/martintrojer","html_url":"https://github.com/martintrojer","followers_url":"https://api.github.com/users/martintrojer/followers","following_url":"https://api.github.com/users/martintrojer/following{/other_user}","gists_url":"https://api.github.com/users/martintrojer/gists{/gist_id}","starred_url":"https://api.github.com/users/martintrojer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martintrojer/subscriptions","organizations_url":"https://api.github.com/users/martintrojer/orgs","repos_url":"https://api.github.com/users/martintrojer/repos","events_url":"https://api.github.com/users/martintrojer/events{/privacy}","received_events_url":"https://api.github.com/users/martintrojer/received_events","type":"User","site_admin":false},"repo":{"id":29361531,"name":"inf-clojure","full_name":"martintrojer/inf-clojure","owner":{"login":"martintrojer","id":1161940,"avatar_url":"https://avatars.githubusercontent.com/u/1161940?v=3","gravatar_id":"","url":"https://api.github.com/users/martintrojer","html_url":"https://github.com/martintrojer","followers_url":"https://api.github.com/users/martintrojer/followers","following_url":"https://api.github.com/users/martintrojer/following{/other_user}","gists_url":"https://api.github.com/users/martintrojer/gists{/gist_id}","starred_url":"https://api.github.com/users/martintrojer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martintrojer/subscriptions","organizations_url":"https://api.github.com/users/martintrojer/orgs","repos_url":"https://api.github.com/users/martintrojer/repos","events_url":"https://api.github.com/users/martintrojer/events{/privacy}","received_events_url":"https://api.github.com/users/martintrojer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/martintrojer/inf-clojure","description":"Basic interaction with a Clojure subprocess","fork":true,"url":"https://api.github.com/repos/martintrojer/inf-clojure","forks_url":"https://api.github.com/repos/martintrojer/inf-clojure/forks","keys_url":"https://api.github.com/repos/martintrojer/inf-clojure/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martintrojer/inf-clojure/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martintrojer/inf-clojure/teams","hooks_url":"https://api.github.com/repos/martintrojer/inf-clojure/hooks","issue_events_url":"https://api.github.com/repos/martintrojer/inf-clojure/issues/events{/number}","events_url":"https://api.github.com/repos/martintrojer/inf-clojure/events","assignees_url":"https://api.github.com/repos/martintrojer/inf-clojure/assignees{/user}","branches_url":"https://api.github.com/repos/martintrojer/inf-clojure/branches{/branch}","tags_url":"https://api.github.com/repos/martintrojer/inf-clojure/tags","blobs_url":"https://api.github.com/repos/martintrojer/inf-clojure/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martintrojer/inf-clojure/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martintrojer/inf-clojure/git/refs{/sha}","trees_url":"https://api.github.com/repos/martintrojer/inf-clojure/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martintrojer/inf-clojure/statuses/{sha}","languages_url":"https://api.github.com/repos/martintrojer/inf-clojure/languages","stargazers_url":"https://api.github.com/repos/martintrojer/inf-clojure/stargazers","contributors_url":"https://api.github.com/repos/martintrojer/inf-clojure/contributors","subscribers_url":"https://api.github.com/repos/martintrojer/inf-clojure/subscribers","subscription_url":"https://api.github.com/repos/martintrojer/inf-clojure/subscription","commits_url":"https://api.github.com/repos/martintrojer/inf-clojure/commits{/sha}","git_commits_url":"https://api.github.com/repos/martintrojer/inf-clojure/git/commits{/sha}","comments_url":"https://api.github.com/repos/martintrojer/inf-clojure/comments{/number}","issue_comment_url":"https://api.github.com/repos/martintrojer/inf-clojure/issues/comments/{number}","contents_url":"https://api.github.com/repos/martintrojer/inf-clojure/contents/{+path}","compare_url":"https://api.github.com/repos/martintrojer/inf-clojure/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martintrojer/inf-clojure/merges","archive_url":"https://api.github.com/repos/martintrojer/inf-clojure/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martintrojer/inf-clojure/downloads","issues_url":"https://api.github.com/repos/martintrojer/inf-clojure/issues{/number}","pulls_url":"https://api.github.com/repos/martintrojer/inf-clojure/pulls{/number}","milestones_url":"https://api.github.com/repos/martintrojer/inf-clojure/milestones{/number}","notifications_url":"https://api.github.com/repos/martintrojer/inf-clojure/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martintrojer/inf-clojure/labels{/name}","releases_url":"https://api.github.com/repos/martintrojer/inf-clojure/releases{/id}","created_at":"2015-01-16T18:22:21Z","updated_at":"2015-01-16T18:25:29Z","pushed_at":"2015-01-16T18:25:29Z","git_url":"git://github.com/martintrojer/inf-clojure.git","ssh_url":"git@github.com:martintrojer/inf-clojure.git","clone_url":"https://github.com/martintrojer/inf-clojure.git","svn_url":"https://github.com/martintrojer/inf-clojure","homepage":null,"size":292,"stargazers_count":0,"watchers_count":0,"language":"Emacs Lisp","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"clojure-emacs:master","ref":"master","sha":"89035ee12a247d59e78bdbd33fd0db53c3d2a4b2","user":{"login":"clojure-emacs","id":5080083,"avatar_url":"https://avatars.githubusercontent.com/u/5080083?v=3","gravatar_id":"","url":"https://api.github.com/users/clojure-emacs","html_url":"https://github.com/clojure-emacs","followers_url":"https://api.github.com/users/clojure-emacs/followers","following_url":"https://api.github.com/users/clojure-emacs/following{/other_user}","gists_url":"https://api.github.com/users/clojure-emacs/gists{/gist_id}","starred_url":"https://api.github.com/users/clojure-emacs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clojure-emacs/subscriptions","organizations_url":"https://api.github.com/users/clojure-emacs/orgs","repos_url":"https://api.github.com/users/clojure-emacs/repos","events_url":"https://api.github.com/users/clojure-emacs/events{/privacy}","received_events_url":"https://api.github.com/users/clojure-emacs/received_events","type":"Organization","site_admin":false},"repo":{"id":27496578,"name":"inf-clojure","full_name":"clojure-emacs/inf-clojure","owner":{"login":"clojure-emacs","id":5080083,"avatar_url":"https://avatars.githubusercontent.com/u/5080083?v=3","gravatar_id":"","url":"https://api.github.com/users/clojure-emacs","html_url":"https://github.com/clojure-emacs","followers_url":"https://api.github.com/users/clojure-emacs/followers","following_url":"https://api.github.com/users/clojure-emacs/following{/other_user}","gists_url":"https://api.github.com/users/clojure-emacs/gists{/gist_id}","starred_url":"https://api.github.com/users/clojure-emacs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clojure-emacs/subscriptions","organizations_url":"https://api.github.com/users/clojure-emacs/orgs","repos_url":"https://api.github.com/users/clojure-emacs/repos","events_url":"https://api.github.com/users/clojure-emacs/events{/privacy}","received_events_url":"https://api.github.com/users/clojure-emacs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/clojure-emacs/inf-clojure","description":"Basic interaction with a Clojure subprocess","fork":false,"url":"https://api.github.com/repos/clojure-emacs/inf-clojure","forks_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/forks","keys_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/teams","hooks_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/hooks","issue_events_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/issues/events{/number}","events_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/events","assignees_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/assignees{/user}","branches_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/branches{/branch}","tags_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/tags","blobs_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/git/refs{/sha}","trees_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/statuses/{sha}","languages_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/languages","stargazers_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/stargazers","contributors_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/contributors","subscribers_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/subscribers","subscription_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/subscription","commits_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/commits{/sha}","git_commits_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/git/commits{/sha}","comments_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/comments{/number}","issue_comment_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/issues/comments/{number}","contents_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/contents/{+path}","compare_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/merges","archive_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/downloads","issues_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/issues{/number}","pulls_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/pulls{/number}","milestones_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/milestones{/number}","notifications_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/labels{/name}","releases_url":"https://api.github.com/repos/clojure-emacs/inf-clojure/releases{/id}","created_at":"2014-12-03T16:34:56Z","updated_at":"2015-01-15T21:21:51Z","pushed_at":"2015-01-15T20:55:36Z","git_url":"git://github.com/clojure-emacs/inf-clojure.git","ssh_url":"git@github.com:clojure-emacs/inf-clojure.git","clone_url":"https://github.com/clojure-emacs/inf-clojure.git","svn_url":"https://github.com/clojure-emacs/inf-clojure","homepage":null,"size":292,"stargazers_count":18,"watchers_count":18,"language":"Emacs Lisp","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":6,"forks":2,"open_issues":6,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/clojure-emacs/inf-clojure/pulls/10"},"html":{"href":"https://github.com/clojure-emacs/inf-clojure/pull/10"},"issue":{"href":"https://api.github.com/repos/clojure-emacs/inf-clojure/issues/10"},"comments":{"href":"https://api.github.com/repos/clojure-emacs/inf-clojure/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/clojure-emacs/inf-clojure/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/clojure-emacs/inf-clojure/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/clojure-emacs/inf-clojure/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/clojure-emacs/inf-clojure/statuses/d8ce9bbbc55cd3eb6ca538587ec13d6f6d66582c"}}}}