{"action":"created","comment":{"url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/pulls/comments/37569919","id":37569919,"diff_hunk":"@@ -42,6 +59,38 @@ def render_xml()\n         return self.template.result(binding)\n       end\n \n+      def received_date\n+        @received_at.getlocal(\"-05:00\").strftime(\"%Y-%m-%d-05:00\")","path":"src/vbms/requests.rb","position":28,"original_position":28,"commit_id":"734f4d266ec1ecd2c06cea079628620e737ed0b6","original_commit_id":"734f4d266ec1ecd2c06cea079628620e737ed0b6","user":{"login":"amoose","id":1328699,"avatar_url":"https://avatars.githubusercontent.com/u/1328699?v=3","gravatar_id":"","url":"https://api.github.com/users/amoose","html_url":"https://github.com/amoose","followers_url":"https://api.github.com/users/amoose/followers","following_url":"https://api.github.com/users/amoose/following{/other_user}","gists_url":"https://api.github.com/users/amoose/gists{/gist_id}","starred_url":"https://api.github.com/users/amoose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amoose/subscriptions","organizations_url":"https://api.github.com/users/amoose/orgs","repos_url":"https://api.github.com/users/amoose/repos","events_url":"https://api.github.com/users/amoose/events{/privacy}","received_events_url":"https://api.github.com/users/amoose/received_events","type":"User","site_admin":false},"body":"Could this cause issues Mar 8-Nov 1? ","created_at":"2015-08-20T19:18:25Z","updated_at":"2015-08-20T19:18:25Z","html_url":"https://github.com/department-of-veterans-affairs/connect_vbms/pull/13#discussion_r37569919","pull_request_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/pulls/comments/37569919"},"html":{"href":"https://github.com/department-of-veterans-affairs/connect_vbms/pull/13#discussion_r37569919"},"pull_request":{"href":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/pulls/13","id":42836725,"html_url":"https://github.com/department-of-veterans-affairs/connect_vbms/pull/13","diff_url":"https://github.com/department-of-veterans-affairs/connect_vbms/pull/13.diff","patch_url":"https://github.com/department-of-veterans-affairs/connect_vbms/pull/13.patch","issue_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/issues/13","number":13,"state":"open","locked":false,"title":"Add Nokogiri XML builders (Inocmplete: request for review)","user":{"login":"llimllib","id":7150,"avatar_url":"https://avatars.githubusercontent.com/u/7150?v=3","gravatar_id":"","url":"https://api.github.com/users/llimllib","html_url":"https://github.com/llimllib","followers_url":"https://api.github.com/users/llimllib/followers","following_url":"https://api.github.com/users/llimllib/following{/other_user}","gists_url":"https://api.github.com/users/llimllib/gists{/gist_id}","starred_url":"https://api.github.com/users/llimllib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llimllib/subscriptions","organizations_url":"https://api.github.com/users/llimllib/orgs","repos_url":"https://api.github.com/users/llimllib/repos","events_url":"https://api.github.com/users/llimllib/events{/privacy}","received_events_url":"https://api.github.com/users/llimllib/received_events","type":"User","site_admin":false},"body":"I wanted to ensure that the XML returned from the erb and the nokogiri methods was the same, so for now I left both in and wrote tests to verify that it is. If/when this PR gets close to approval, I'll pull the erb code and the tests for equivalence.\n\nSome Qs:\n\n* Is it worth all requests inheriting from a common base class to get the namespaces?\n* I didn't find a good way of composing Nokogiri XML builders, but that doesn't mean one doesn't exist; let me know if you can figure out how\n* Should each request go in its own file?\n\n:eyes: @alex @amoose","created_at":"2015-08-19T16:42:41Z","updated_at":"2015-08-20T19:18:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79d300caee8e1323611e74227b02c01c80a661d2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/pulls/13/commits","review_comments_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/pulls/13/comments","review_comment_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/issues/13/comments","statuses_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/statuses/734f4d266ec1ecd2c06cea079628620e737ed0b6","head":{"label":"department-of-veterans-affairs:remove-erb-xml","ref":"remove-erb-xml","sha":"734f4d266ec1ecd2c06cea079628620e737ed0b6","user":{"login":"department-of-veterans-affairs","id":5421563,"avatar_url":"https://avatars.githubusercontent.com/u/5421563?v=3","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"repo":{"id":40141397,"name":"connect_vbms","full_name":"department-of-veterans-affairs/connect_vbms","owner":{"login":"department-of-veterans-affairs","id":5421563,"avatar_url":"https://avatars.githubusercontent.com/u/5421563?v=3","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/department-of-veterans-affairs/connect_vbms","description":"","fork":false,"url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms","forks_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/forks","keys_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/teams","hooks_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/hooks","issue_events_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/issues/events{/number}","events_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/events","assignees_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/assignees{/user}","branches_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/branches{/branch}","tags_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/tags","blobs_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/git/refs{/sha}","trees_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/statuses/{sha}","languages_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/languages","stargazers_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/stargazers","contributors_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/contributors","subscribers_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/subscribers","subscription_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/subscription","commits_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/commits{/sha}","git_commits_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/git/commits{/sha}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/comments{/number}","issue_comment_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/issues/comments{/number}","contents_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/contents/{+path}","compare_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/merges","archive_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/downloads","issues_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/issues{/number}","pulls_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/pulls{/number}","milestones_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/milestones{/number}","notifications_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/labels{/name}","releases_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/releases{/id}","created_at":"2015-08-03T18:32:25Z","updated_at":"2015-08-03T20:24:47Z","pushed_at":"2015-08-20T15:52:10Z","git_url":"git://github.com/department-of-veterans-affairs/connect_vbms.git","ssh_url":"git@github.com:department-of-veterans-affairs/connect_vbms.git","clone_url":"https://github.com/department-of-veterans-affairs/connect_vbms.git","svn_url":"https://github.com/department-of-veterans-affairs/connect_vbms","homepage":null,"size":3436,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"department-of-veterans-affairs:master","ref":"master","sha":"c328bf44e7bde530992b086aee703c361f2e766f","user":{"login":"department-of-veterans-affairs","id":5421563,"avatar_url":"https://avatars.githubusercontent.com/u/5421563?v=3","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"repo":{"id":40141397,"name":"connect_vbms","full_name":"department-of-veterans-affairs/connect_vbms","owner":{"login":"department-of-veterans-affairs","id":5421563,"avatar_url":"https://avatars.githubusercontent.com/u/5421563?v=3","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/department-of-veterans-affairs/connect_vbms","description":"","fork":false,"url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms","forks_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/forks","keys_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/teams","hooks_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/hooks","issue_events_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/issues/events{/number}","events_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/events","assignees_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/assignees{/user}","branches_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/branches{/branch}","tags_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/tags","blobs_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/git/refs{/sha}","trees_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/statuses/{sha}","languages_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/languages","stargazers_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/stargazers","contributors_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/contributors","subscribers_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/subscribers","subscription_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/subscription","commits_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/commits{/sha}","git_commits_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/git/commits{/sha}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/comments{/number}","issue_comment_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/issues/comments{/number}","contents_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/contents/{+path}","compare_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/merges","archive_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/downloads","issues_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/issues{/number}","pulls_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/pulls{/number}","milestones_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/milestones{/number}","notifications_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/labels{/name}","releases_url":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/releases{/id}","created_at":"2015-08-03T18:32:25Z","updated_at":"2015-08-03T20:24:47Z","pushed_at":"2015-08-20T15:52:10Z","git_url":"git://github.com/department-of-veterans-affairs/connect_vbms.git","ssh_url":"git@github.com:department-of-veterans-affairs/connect_vbms.git","clone_url":"https://github.com/department-of-veterans-affairs/connect_vbms.git","svn_url":"https://github.com/department-of-veterans-affairs/connect_vbms","homepage":null,"size":3436,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/pulls/13"},"html":{"href":"https://github.com/department-of-veterans-affairs/connect_vbms/pull/13"},"issue":{"href":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/issues/13"},"comments":{"href":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/department-of-veterans-affairs/connect_vbms/statuses/734f4d266ec1ecd2c06cea079628620e737ed0b6"}}}}