{"action":"created","comment":{"url":"https://api.github.com/repos/ubergrape/websocket/pulls/comments/24402633","id":24402633,"diff_hunk":"@@ -23,59 +23,63 @@ function WebSocketWrapper(url) {\n \tEmitter.call(this);\n \n \tthis.url = url;\n-\tthis._socket = undefined;\n-\tthis._connect();\n+\tthis._socket = this._connect();\n }\n WebSocketWrapper.prototype = Object.create(Emitter.prototype);\n \n-// wrap the states\n-WebSocketWrapper.prototype.CONNECTING = 0;\n-WebSocketWrapper.prototype.OPEN = 1;\n-WebSocketWrapper.prototype.CLOSING = 2;\n-WebSocketWrapper.prototype.CLOSED = 3;\n+WebSocketWrapper.CONNECTING = 0;","path":"index.js","position":15,"original_position":15,"commit_id":"c1a4570c186c89e271e38e406918cf36ae8460ed","original_commit_id":"ad81110ba7a8ab022846e631199d9b3c7ce6eff4","user":{"login":"federicare","id":1609297,"avatar_url":"https://avatars.githubusercontent.com/u/1609297?v=3","gravatar_id":"","url":"https://api.github.com/users/federicare","html_url":"https://github.com/federicare","followers_url":"https://api.github.com/users/federicare/followers","following_url":"https://api.github.com/users/federicare/following{/other_user}","gists_url":"https://api.github.com/users/federicare/gists{/gist_id}","starred_url":"https://api.github.com/users/federicare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/federicare/subscriptions","organizations_url":"https://api.github.com/users/federicare/orgs","repos_url":"https://api.github.com/users/federicare/repos","events_url":"https://api.github.com/users/federicare/events{/privacy}","received_events_url":"https://api.github.com/users/federicare/received_events","type":"User","site_admin":false},"body":"They are below, I also had the impression they were gone.","created_at":"2015-02-10T10:34:49Z","updated_at":"2015-02-10T10:34:49Z","html_url":"https://github.com/ubergrape/websocket/pull/1#discussion_r24402633","pull_request_url":"https://api.github.com/repos/ubergrape/websocket/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/ubergrape/websocket/pulls/comments/24402633"},"html":{"href":"https://github.com/ubergrape/websocket/pull/1#discussion_r24402633"},"pull_request":{"href":"https://api.github.com/repos/ubergrape/websocket/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/ubergrape/websocket/pulls/1","id":28937795,"html_url":"https://github.com/ubergrape/websocket/pull/1","diff_url":"https://github.com/ubergrape/websocket/pull/1.diff","patch_url":"https://github.com/ubergrape/websocket/pull/1.patch","issue_url":"https://api.github.com/repos/ubergrape/websocket/issues/1","number":1,"state":"closed","locked":false,"title":"fix potential reconnect issues + cleanups","user":{"login":"kof","id":52824,"avatar_url":"https://avatars.githubusercontent.com/u/52824?v=3","gravatar_id":"","url":"https://api.github.com/users/kof","html_url":"https://github.com/kof","followers_url":"https://api.github.com/users/kof/followers","following_url":"https://api.github.com/users/kof/following{/other_user}","gists_url":"https://api.github.com/users/kof/gists{/gist_id}","starred_url":"https://api.github.com/users/kof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kof/subscriptions","organizations_url":"https://api.github.com/users/kof/orgs","repos_url":"https://api.github.com/users/kof/repos","events_url":"https://api.github.com/users/kof/events{/privacy}","received_events_url":"https://api.github.com/users/kof/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-02-09T17:05:58Z","updated_at":"2015-02-10T10:34:49Z","closed_at":"2015-02-10T09:50:28Z","merged_at":"2015-02-10T09:50:28Z","merge_commit_sha":"46412c549dee419d6647152ac5b5e60a7325c5d0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ubergrape/websocket/pulls/1/commits","review_comments_url":"https://api.github.com/repos/ubergrape/websocket/pulls/1/comments","review_comment_url":"https://api.github.com/repos/ubergrape/websocket/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ubergrape/websocket/issues/1/comments","statuses_url":"https://api.github.com/repos/ubergrape/websocket/statuses/c1a4570c186c89e271e38e406918cf36ae8460ed","head":{"label":"ubergrape:1546","ref":"1546","sha":"c1a4570c186c89e271e38e406918cf36ae8460ed","user":{"login":"ubergrape","id":595486,"avatar_url":"https://avatars.githubusercontent.com/u/595486?v=3","gravatar_id":"","url":"https://api.github.com/users/ubergrape","html_url":"https://github.com/ubergrape","followers_url":"https://api.github.com/users/ubergrape/followers","following_url":"https://api.github.com/users/ubergrape/following{/other_user}","gists_url":"https://api.github.com/users/ubergrape/gists{/gist_id}","starred_url":"https://api.github.com/users/ubergrape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubergrape/subscriptions","organizations_url":"https://api.github.com/users/ubergrape/orgs","repos_url":"https://api.github.com/users/ubergrape/repos","events_url":"https://api.github.com/users/ubergrape/events{/privacy}","received_events_url":"https://api.github.com/users/ubergrape/received_events","type":"Organization","site_admin":false},"repo":{"id":21352209,"name":"websocket","full_name":"ubergrape/websocket","owner":{"login":"ubergrape","id":595486,"avatar_url":"https://avatars.githubusercontent.com/u/595486?v=3","gravatar_id":"","url":"https://api.github.com/users/ubergrape","html_url":"https://github.com/ubergrape","followers_url":"https://api.github.com/users/ubergrape/followers","following_url":"https://api.github.com/users/ubergrape/following{/other_user}","gists_url":"https://api.github.com/users/ubergrape/gists{/gist_id}","starred_url":"https://api.github.com/users/ubergrape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubergrape/subscriptions","organizations_url":"https://api.github.com/users/ubergrape/orgs","repos_url":"https://api.github.com/users/ubergrape/repos","events_url":"https://api.github.com/users/ubergrape/events{/privacy}","received_events_url":"https://api.github.com/users/ubergrape/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ubergrape/websocket","description":"thin layer on top of websockets with reconnection","fork":true,"url":"https://api.github.com/repos/ubergrape/websocket","forks_url":"https://api.github.com/repos/ubergrape/websocket/forks","keys_url":"https://api.github.com/repos/ubergrape/websocket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ubergrape/websocket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ubergrape/websocket/teams","hooks_url":"https://api.github.com/repos/ubergrape/websocket/hooks","issue_events_url":"https://api.github.com/repos/ubergrape/websocket/issues/events{/number}","events_url":"https://api.github.com/repos/ubergrape/websocket/events","assignees_url":"https://api.github.com/repos/ubergrape/websocket/assignees{/user}","branches_url":"https://api.github.com/repos/ubergrape/websocket/branches{/branch}","tags_url":"https://api.github.com/repos/ubergrape/websocket/tags","blobs_url":"https://api.github.com/repos/ubergrape/websocket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ubergrape/websocket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ubergrape/websocket/git/refs{/sha}","trees_url":"https://api.github.com/repos/ubergrape/websocket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ubergrape/websocket/statuses/{sha}","languages_url":"https://api.github.com/repos/ubergrape/websocket/languages","stargazers_url":"https://api.github.com/repos/ubergrape/websocket/stargazers","contributors_url":"https://api.github.com/repos/ubergrape/websocket/contributors","subscribers_url":"https://api.github.com/repos/ubergrape/websocket/subscribers","subscription_url":"https://api.github.com/repos/ubergrape/websocket/subscription","commits_url":"https://api.github.com/repos/ubergrape/websocket/commits{/sha}","git_commits_url":"https://api.github.com/repos/ubergrape/websocket/git/commits{/sha}","comments_url":"https://api.github.com/repos/ubergrape/websocket/comments{/number}","issue_comment_url":"https://api.github.com/repos/ubergrape/websocket/issues/comments/{number}","contents_url":"https://api.github.com/repos/ubergrape/websocket/contents/{+path}","compare_url":"https://api.github.com/repos/ubergrape/websocket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ubergrape/websocket/merges","archive_url":"https://api.github.com/repos/ubergrape/websocket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ubergrape/websocket/downloads","issues_url":"https://api.github.com/repos/ubergrape/websocket/issues{/number}","pulls_url":"https://api.github.com/repos/ubergrape/websocket/pulls{/number}","milestones_url":"https://api.github.com/repos/ubergrape/websocket/milestones{/number}","notifications_url":"https://api.github.com/repos/ubergrape/websocket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ubergrape/websocket/labels{/name}","releases_url":"https://api.github.com/repos/ubergrape/websocket/releases{/id}","created_at":"2014-06-30T13:35:20Z","updated_at":"2015-02-10T09:50:28Z","pushed_at":"2015-02-10T09:50:28Z","git_url":"git://github.com/ubergrape/websocket.git","ssh_url":"git@github.com:ubergrape/websocket.git","clone_url":"https://github.com/ubergrape/websocket.git","svn_url":"https://github.com/ubergrape/websocket","homepage":null,"size":170,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ubergrape:master","ref":"master","sha":"9d38c1d59425da7207b5d89361dfa7cdde603a1c","user":{"login":"ubergrape","id":595486,"avatar_url":"https://avatars.githubusercontent.com/u/595486?v=3","gravatar_id":"","url":"https://api.github.com/users/ubergrape","html_url":"https://github.com/ubergrape","followers_url":"https://api.github.com/users/ubergrape/followers","following_url":"https://api.github.com/users/ubergrape/following{/other_user}","gists_url":"https://api.github.com/users/ubergrape/gists{/gist_id}","starred_url":"https://api.github.com/users/ubergrape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubergrape/subscriptions","organizations_url":"https://api.github.com/users/ubergrape/orgs","repos_url":"https://api.github.com/users/ubergrape/repos","events_url":"https://api.github.com/users/ubergrape/events{/privacy}","received_events_url":"https://api.github.com/users/ubergrape/received_events","type":"Organization","site_admin":false},"repo":{"id":21352209,"name":"websocket","full_name":"ubergrape/websocket","owner":{"login":"ubergrape","id":595486,"avatar_url":"https://avatars.githubusercontent.com/u/595486?v=3","gravatar_id":"","url":"https://api.github.com/users/ubergrape","html_url":"https://github.com/ubergrape","followers_url":"https://api.github.com/users/ubergrape/followers","following_url":"https://api.github.com/users/ubergrape/following{/other_user}","gists_url":"https://api.github.com/users/ubergrape/gists{/gist_id}","starred_url":"https://api.github.com/users/ubergrape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubergrape/subscriptions","organizations_url":"https://api.github.com/users/ubergrape/orgs","repos_url":"https://api.github.com/users/ubergrape/repos","events_url":"https://api.github.com/users/ubergrape/events{/privacy}","received_events_url":"https://api.github.com/users/ubergrape/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ubergrape/websocket","description":"thin layer on top of websockets with reconnection","fork":true,"url":"https://api.github.com/repos/ubergrape/websocket","forks_url":"https://api.github.com/repos/ubergrape/websocket/forks","keys_url":"https://api.github.com/repos/ubergrape/websocket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ubergrape/websocket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ubergrape/websocket/teams","hooks_url":"https://api.github.com/repos/ubergrape/websocket/hooks","issue_events_url":"https://api.github.com/repos/ubergrape/websocket/issues/events{/number}","events_url":"https://api.github.com/repos/ubergrape/websocket/events","assignees_url":"https://api.github.com/repos/ubergrape/websocket/assignees{/user}","branches_url":"https://api.github.com/repos/ubergrape/websocket/branches{/branch}","tags_url":"https://api.github.com/repos/ubergrape/websocket/tags","blobs_url":"https://api.github.com/repos/ubergrape/websocket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ubergrape/websocket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ubergrape/websocket/git/refs{/sha}","trees_url":"https://api.github.com/repos/ubergrape/websocket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ubergrape/websocket/statuses/{sha}","languages_url":"https://api.github.com/repos/ubergrape/websocket/languages","stargazers_url":"https://api.github.com/repos/ubergrape/websocket/stargazers","contributors_url":"https://api.github.com/repos/ubergrape/websocket/contributors","subscribers_url":"https://api.github.com/repos/ubergrape/websocket/subscribers","subscription_url":"https://api.github.com/repos/ubergrape/websocket/subscription","commits_url":"https://api.github.com/repos/ubergrape/websocket/commits{/sha}","git_commits_url":"https://api.github.com/repos/ubergrape/websocket/git/commits{/sha}","comments_url":"https://api.github.com/repos/ubergrape/websocket/comments{/number}","issue_comment_url":"https://api.github.com/repos/ubergrape/websocket/issues/comments/{number}","contents_url":"https://api.github.com/repos/ubergrape/websocket/contents/{+path}","compare_url":"https://api.github.com/repos/ubergrape/websocket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ubergrape/websocket/merges","archive_url":"https://api.github.com/repos/ubergrape/websocket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ubergrape/websocket/downloads","issues_url":"https://api.github.com/repos/ubergrape/websocket/issues{/number}","pulls_url":"https://api.github.com/repos/ubergrape/websocket/pulls{/number}","milestones_url":"https://api.github.com/repos/ubergrape/websocket/milestones{/number}","notifications_url":"https://api.github.com/repos/ubergrape/websocket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ubergrape/websocket/labels{/name}","releases_url":"https://api.github.com/repos/ubergrape/websocket/releases{/id}","created_at":"2014-06-30T13:35:20Z","updated_at":"2015-02-10T09:50:28Z","pushed_at":"2015-02-10T09:50:28Z","git_url":"git://github.com/ubergrape/websocket.git","ssh_url":"git@github.com:ubergrape/websocket.git","clone_url":"https://github.com/ubergrape/websocket.git","svn_url":"https://github.com/ubergrape/websocket","homepage":null,"size":170,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ubergrape/websocket/pulls/1"},"html":{"href":"https://github.com/ubergrape/websocket/pull/1"},"issue":{"href":"https://api.github.com/repos/ubergrape/websocket/issues/1"},"comments":{"href":"https://api.github.com/repos/ubergrape/websocket/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/ubergrape/websocket/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/ubergrape/websocket/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ubergrape/websocket/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/ubergrape/websocket/statuses/c1a4570c186c89e271e38e406918cf36ae8460ed"}}}}