{"action":"created","comment":{"url":"https://api.github.com/repos/hashicorp/nomad/pulls/comments/48122764","id":48122764,"diff_hunk":"@@ -149,6 +149,19 @@ func (d *RktDriver) Start(ctx *ExecContext, task *structs.Task) (DriverHandle, e\n \t\tcmd_args = append(cmd_args, fmt.Sprintf(\"--exec=%v\", exec_cmd))\n \t}\n \n+\tif task.Resources.MemoryMB == 0 {","path":"client/driver/rkt.go","position":4,"original_position":4,"commit_id":"19bcf4fce3bf905d306532e20cb5b4b70b6ab17c","original_commit_id":"19bcf4fce3bf905d306532e20cb5b4b70b6ab17c","user":{"login":"jippi","id":22841,"avatar_url":"https://avatars.githubusercontent.com/u/22841?v=3","gravatar_id":"","url":"https://api.github.com/users/jippi","html_url":"https://github.com/jippi","followers_url":"https://api.github.com/users/jippi/followers","following_url":"https://api.github.com/users/jippi/following{/other_user}","gists_url":"https://api.github.com/users/jippi/gists{/gist_id}","starred_url":"https://api.github.com/users/jippi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jippi/subscriptions","organizations_url":"https://api.github.com/users/jippi/orgs","repos_url":"https://api.github.com/users/jippi/repos","events_url":"https://api.github.com/users/jippi/events{/privacy}","received_events_url":"https://api.github.com/users/jippi/received_events","type":"User","site_admin":false},"body":"how do you say \"infinite\" or \"don't care at all\" ?","created_at":"2015-12-21T07:45:53Z","updated_at":"2015-12-21T07:45:53Z","html_url":"https://github.com/hashicorp/nomad/pull/610#discussion_r48122764","pull_request_url":"https://api.github.com/repos/hashicorp/nomad/pulls/610","_links":{"self":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/comments/48122764"},"html":{"href":"https://github.com/hashicorp/nomad/pull/610#discussion_r48122764"},"pull_request":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/610"}}},"pull_request":{"url":"https://api.github.com/repos/hashicorp/nomad/pulls/610","id":54223736,"html_url":"https://github.com/hashicorp/nomad/pull/610","diff_url":"https://github.com/hashicorp/nomad/pull/610.diff","patch_url":"https://github.com/hashicorp/nomad/pull/610.patch","issue_url":"https://api.github.com/repos/hashicorp/nomad/issues/610","number":610,"state":"open","locked":false,"title":"Add support for CPU and memory isolators","user":{"login":"achanda","id":2165463,"avatar_url":"https://avatars.githubusercontent.com/u/2165463?v=3","gravatar_id":"","url":"https://api.github.com/users/achanda","html_url":"https://github.com/achanda","followers_url":"https://api.github.com/users/achanda/followers","following_url":"https://api.github.com/users/achanda/following{/other_user}","gists_url":"https://api.github.com/users/achanda/gists{/gist_id}","starred_url":"https://api.github.com/users/achanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achanda/subscriptions","organizations_url":"https://api.github.com/users/achanda/orgs","repos_url":"https://api.github.com/users/achanda/repos","events_url":"https://api.github.com/users/achanda/events{/privacy}","received_events_url":"https://api.github.com/users/achanda/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-12-21T06:10:28Z","updated_at":"2015-12-21T07:45:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b33b0327b594959a74ea76e491d5d4a1b3de9668","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hashicorp/nomad/pulls/610/commits","review_comments_url":"https://api.github.com/repos/hashicorp/nomad/pulls/610/comments","review_comment_url":"https://api.github.com/repos/hashicorp/nomad/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hashicorp/nomad/issues/610/comments","statuses_url":"https://api.github.com/repos/hashicorp/nomad/statuses/19bcf4fce3bf905d306532e20cb5b4b70b6ab17c","head":{"label":"achanda:isolators","ref":"isolators","sha":"19bcf4fce3bf905d306532e20cb5b4b70b6ab17c","user":{"login":"achanda","id":2165463,"avatar_url":"https://avatars.githubusercontent.com/u/2165463?v=3","gravatar_id":"","url":"https://api.github.com/users/achanda","html_url":"https://github.com/achanda","followers_url":"https://api.github.com/users/achanda/followers","following_url":"https://api.github.com/users/achanda/following{/other_user}","gists_url":"https://api.github.com/users/achanda/gists{/gist_id}","starred_url":"https://api.github.com/users/achanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achanda/subscriptions","organizations_url":"https://api.github.com/users/achanda/orgs","repos_url":"https://api.github.com/users/achanda/repos","events_url":"https://api.github.com/users/achanda/events{/privacy}","received_events_url":"https://api.github.com/users/achanda/received_events","type":"User","site_admin":false},"repo":{"id":43915323,"name":"nomad","full_name":"achanda/nomad","owner":{"login":"achanda","id":2165463,"avatar_url":"https://avatars.githubusercontent.com/u/2165463?v=3","gravatar_id":"","url":"https://api.github.com/users/achanda","html_url":"https://github.com/achanda","followers_url":"https://api.github.com/users/achanda/followers","following_url":"https://api.github.com/users/achanda/following{/other_user}","gists_url":"https://api.github.com/users/achanda/gists{/gist_id}","starred_url":"https://api.github.com/users/achanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achanda/subscriptions","organizations_url":"https://api.github.com/users/achanda/orgs","repos_url":"https://api.github.com/users/achanda/repos","events_url":"https://api.github.com/users/achanda/events{/privacy}","received_events_url":"https://api.github.com/users/achanda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/achanda/nomad","description":"A Distributed, Highly Available, Datacenter-Aware Scheduler","fork":true,"url":"https://api.github.com/repos/achanda/nomad","forks_url":"https://api.github.com/repos/achanda/nomad/forks","keys_url":"https://api.github.com/repos/achanda/nomad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/achanda/nomad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/achanda/nomad/teams","hooks_url":"https://api.github.com/repos/achanda/nomad/hooks","issue_events_url":"https://api.github.com/repos/achanda/nomad/issues/events{/number}","events_url":"https://api.github.com/repos/achanda/nomad/events","assignees_url":"https://api.github.com/repos/achanda/nomad/assignees{/user}","branches_url":"https://api.github.com/repos/achanda/nomad/branches{/branch}","tags_url":"https://api.github.com/repos/achanda/nomad/tags","blobs_url":"https://api.github.com/repos/achanda/nomad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/achanda/nomad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/achanda/nomad/git/refs{/sha}","trees_url":"https://api.github.com/repos/achanda/nomad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/achanda/nomad/statuses/{sha}","languages_url":"https://api.github.com/repos/achanda/nomad/languages","stargazers_url":"https://api.github.com/repos/achanda/nomad/stargazers","contributors_url":"https://api.github.com/repos/achanda/nomad/contributors","subscribers_url":"https://api.github.com/repos/achanda/nomad/subscribers","subscription_url":"https://api.github.com/repos/achanda/nomad/subscription","commits_url":"https://api.github.com/repos/achanda/nomad/commits{/sha}","git_commits_url":"https://api.github.com/repos/achanda/nomad/git/commits{/sha}","comments_url":"https://api.github.com/repos/achanda/nomad/comments{/number}","issue_comment_url":"https://api.github.com/repos/achanda/nomad/issues/comments{/number}","contents_url":"https://api.github.com/repos/achanda/nomad/contents/{+path}","compare_url":"https://api.github.com/repos/achanda/nomad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/achanda/nomad/merges","archive_url":"https://api.github.com/repos/achanda/nomad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/achanda/nomad/downloads","issues_url":"https://api.github.com/repos/achanda/nomad/issues{/number}","pulls_url":"https://api.github.com/repos/achanda/nomad/pulls{/number}","milestones_url":"https://api.github.com/repos/achanda/nomad/milestones{/number}","notifications_url":"https://api.github.com/repos/achanda/nomad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/achanda/nomad/labels{/name}","releases_url":"https://api.github.com/repos/achanda/nomad/releases{/id}","created_at":"2015-10-08T20:44:13Z","updated_at":"2015-10-08T20:44:15Z","pushed_at":"2015-12-21T06:09:44Z","git_url":"git://github.com/achanda/nomad.git","ssh_url":"git@github.com:achanda/nomad.git","clone_url":"https://github.com/achanda/nomad.git","svn_url":"https://github.com/achanda/nomad","homepage":"https://www.nomadproject.io/","size":16938,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hashicorp:master","ref":"master","sha":"8d25368462fd86dff992db523710ac902e6ffcf7","user":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars.githubusercontent.com/u/761456?v=3","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":36653430,"name":"nomad","full_name":"hashicorp/nomad","owner":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars.githubusercontent.com/u/761456?v=3","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hashicorp/nomad","description":"A Distributed, Highly Available, Datacenter-Aware Scheduler","fork":false,"url":"https://api.github.com/repos/hashicorp/nomad","forks_url":"https://api.github.com/repos/hashicorp/nomad/forks","keys_url":"https://api.github.com/repos/hashicorp/nomad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/nomad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/nomad/teams","hooks_url":"https://api.github.com/repos/hashicorp/nomad/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/nomad/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/nomad/events","assignees_url":"https://api.github.com/repos/hashicorp/nomad/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/nomad/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/nomad/tags","blobs_url":"https://api.github.com/repos/hashicorp/nomad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/nomad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/nomad/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/nomad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/nomad/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/nomad/languages","stargazers_url":"https://api.github.com/repos/hashicorp/nomad/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/nomad/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/nomad/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/nomad/subscription","commits_url":"https://api.github.com/repos/hashicorp/nomad/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/nomad/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/nomad/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/nomad/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/nomad/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/nomad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/nomad/merges","archive_url":"https://api.github.com/repos/hashicorp/nomad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/nomad/downloads","issues_url":"https://api.github.com/repos/hashicorp/nomad/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/nomad/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/nomad/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/nomad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/nomad/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/nomad/releases{/id}","created_at":"2015-06-01T10:21:00Z","updated_at":"2015-12-20T10:18:36Z","pushed_at":"2015-12-21T06:10:29Z","git_url":"git://github.com/hashicorp/nomad.git","ssh_url":"git@github.com:hashicorp/nomad.git","clone_url":"https://github.com/hashicorp/nomad.git","svn_url":"https://github.com/hashicorp/nomad","homepage":"https://www.nomadproject.io/","size":18293,"stargazers_count":1170,"watchers_count":1170,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":113,"mirror_url":null,"open_issues_count":96,"forks":113,"open_issues":96,"watchers":1170,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/610"},"html":{"href":"https://github.com/hashicorp/nomad/pull/610"},"issue":{"href":"https://api.github.com/repos/hashicorp/nomad/issues/610"},"comments":{"href":"https://api.github.com/repos/hashicorp/nomad/issues/610/comments"},"review_comments":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/610/comments"},"review_comment":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/610/commits"},"statuses":{"href":"https://api.github.com/repos/hashicorp/nomad/statuses/19bcf4fce3bf905d306532e20cb5b4b70b6ab17c"}}}}