{"comment":{"url":"https://api.github.com/repos/manjaro/manjaro-tools/comments/9432416","html_url":"https://github.com/manjaro/manjaro-tools/commit/d7ab4cd4467dc61f120ef830899a54f6d823c57a#commitcomment-9432416","id":9432416,"user":{"login":"aadityabagga","id":5509426,"avatar_url":"https://avatars.githubusercontent.com/u/5509426?v=3","gravatar_id":"","url":"https://api.github.com/users/aadityabagga","html_url":"https://github.com/aadityabagga","followers_url":"https://api.github.com/users/aadityabagga/followers","following_url":"https://api.github.com/users/aadityabagga/following{/other_user}","gists_url":"https://api.github.com/users/aadityabagga/gists{/gist_id}","starred_url":"https://api.github.com/users/aadityabagga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aadityabagga/subscriptions","organizations_url":"https://api.github.com/users/aadityabagga/orgs","repos_url":"https://api.github.com/users/aadityabagga/repos","events_url":"https://api.github.com/users/aadityabagga/events{/privacy}","received_events_url":"https://api.github.com/users/aadityabagga/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"d7ab4cd4467dc61f120ef830899a54f6d823c57a","created_at":"2015-01-25T17:10:17Z","updated_at":"2015-01-25T17:10:17Z","body":"His earlier commit is wrong in my opinion, firstly he is checking non-empty an array, and then he is assigning an array to a variable, leading to unpredictable result...\r\n~~~~\r\n if [[ -n ${blacklist[@]} ]];then\r\n blacklist=${blacklist[@]}\r\n else\r\n~~~~\r\n\r\nThats why I had the same value repeated twice or thrice in the blacklist output...\r\n~~~~\r\n==> BLACKLIST:\r\n  -> blacklist_trigger: eudev upower-pm-utils eudev-systemdcompat upower-pm-utils eudev-systemdcompat upower-pm-utils eudev-systemdcompat\r\n  -> blacklist: libsystemd\r\n~~~~\r\nI will revert to my [earlier commit](https://github.com/manjaro/manjaro-tools/commit/a333e01c51216afd9a977265a5c3d2c21b6213d3) as it tries to achieve same thing which @udeved was doing earlier\r\n"}}