{"action":"closed","number":95,"pull_request":{"url":"https://api.github.com/repos/oauth-xx/oauth-ruby/pulls/95","id":28286925,"html_url":"https://github.com/oauth-xx/oauth-ruby/pull/95","diff_url":"https://github.com/oauth-xx/oauth-ruby/pull/95.diff","patch_url":"https://github.com/oauth-xx/oauth-ruby/pull/95.patch","issue_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/issues/95","number":95,"state":"closed","locked":false,"title":"Use OpenSSL for all digest and hashing","user":{"login":"kevinhughes27","id":1965489,"avatar_url":"https://avatars.githubusercontent.com/u/1965489?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinhughes27","html_url":"https://github.com/kevinhughes27","followers_url":"https://api.github.com/users/kevinhughes27/followers","following_url":"https://api.github.com/users/kevinhughes27/following{/other_user}","gists_url":"https://api.github.com/users/kevinhughes27/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinhughes27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinhughes27/subscriptions","organizations_url":"https://api.github.com/users/kevinhughes27/orgs","repos_url":"https://api.github.com/users/kevinhughes27/repos","events_url":"https://api.github.com/users/kevinhughes27/events{/privacy}","received_events_url":"https://api.github.com/users/kevinhughes27/received_events","type":"User","site_admin":false},"body":"The original version of this gem used its own HMAC, which was discovered during a code review to add this gem to our PCI environment at Shopify. While we still wanted the convenience of using the gem to sign our OAuth 1.0a requests and use various gems for which this gem is a dependency, the current digest algorithm in use was unacceptable. The system implementation is also not secure - see: http://www.ruby-doc.org/stdlib-2.0/libdoc/digest/rdoc/Digest/HMAC.html\r\n\r\nSee commit history for improvements to code structure as well as use of OpenSSL implementations for all digest and hashing algorithms, and some pruning to implementations not specified in the OAuth 1.0a specification.\r\n\r\ncc @bizla @fw42 @Shopify/payments @Shopify/platform","created_at":"2015-01-29T15:25:06Z","updated_at":"2015-09-16T22:32:44Z","closed_at":"2015-09-16T22:32:44Z","merged_at":"2015-09-16T22:32:44Z","merge_commit_sha":"d667e4686c70a995d2c02f36dc384960e6f30c41","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/pulls/95/commits","review_comments_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/pulls/95/comments","review_comment_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/issues/95/comments","statuses_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/statuses/41ef7c70898a5bddcbb45f018535cb24adcc26d7","head":{"label":"Shopify:master","ref":"master","sha":"41ef7c70898a5bddcbb45f018535cb24adcc26d7","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":29981444,"name":"oauth-ruby","full_name":"Shopify/oauth-ruby","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/oauth-ruby","description":"OAuth for Ruby","fork":true,"url":"https://api.github.com/repos/Shopify/oauth-ruby","forks_url":"https://api.github.com/repos/Shopify/oauth-ruby/forks","keys_url":"https://api.github.com/repos/Shopify/oauth-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/oauth-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/oauth-ruby/teams","hooks_url":"https://api.github.com/repos/Shopify/oauth-ruby/hooks","issue_events_url":"https://api.github.com/repos/Shopify/oauth-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/oauth-ruby/events","assignees_url":"https://api.github.com/repos/Shopify/oauth-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/oauth-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/oauth-ruby/tags","blobs_url":"https://api.github.com/repos/Shopify/oauth-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/oauth-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/oauth-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/oauth-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/oauth-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/oauth-ruby/languages","stargazers_url":"https://api.github.com/repos/Shopify/oauth-ruby/stargazers","contributors_url":"https://api.github.com/repos/Shopify/oauth-ruby/contributors","subscribers_url":"https://api.github.com/repos/Shopify/oauth-ruby/subscribers","subscription_url":"https://api.github.com/repos/Shopify/oauth-ruby/subscription","commits_url":"https://api.github.com/repos/Shopify/oauth-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/oauth-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/oauth-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/oauth-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/oauth-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/oauth-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/oauth-ruby/merges","archive_url":"https://api.github.com/repos/Shopify/oauth-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/oauth-ruby/downloads","issues_url":"https://api.github.com/repos/Shopify/oauth-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/oauth-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/oauth-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/oauth-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/oauth-ruby/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/oauth-ruby/releases{/id}","created_at":"2015-01-28T18:22:54Z","updated_at":"2015-08-27T07:28:39Z","pushed_at":"2015-06-18T15:55:31Z","git_url":"git://github.com/Shopify/oauth-ruby.git","ssh_url":"git@github.com:Shopify/oauth-ruby.git","clone_url":"https://github.com/Shopify/oauth-ruby.git","svn_url":"https://github.com/Shopify/oauth-ruby","homepage":"http://oauth.rubyforge.org/","size":838,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"oauth-xx:master","ref":"master","sha":"0d97069528d9d3be47d683604dd1c8d622cc2a02","user":{"login":"oauth-xx","id":40009,"avatar_url":"https://avatars.githubusercontent.com/u/40009?v=3","gravatar_id":"","url":"https://api.github.com/users/oauth-xx","html_url":"https://github.com/oauth-xx","followers_url":"https://api.github.com/users/oauth-xx/followers","following_url":"https://api.github.com/users/oauth-xx/following{/other_user}","gists_url":"https://api.github.com/users/oauth-xx/gists{/gist_id}","starred_url":"https://api.github.com/users/oauth-xx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oauth-xx/subscriptions","organizations_url":"https://api.github.com/users/oauth-xx/orgs","repos_url":"https://api.github.com/users/oauth-xx/repos","events_url":"https://api.github.com/users/oauth-xx/events{/privacy}","received_events_url":"https://api.github.com/users/oauth-xx/received_events","type":"User","site_admin":false},"repo":{"id":519148,"name":"oauth-ruby","full_name":"oauth-xx/oauth-ruby","owner":{"login":"oauth-xx","id":40009,"avatar_url":"https://avatars.githubusercontent.com/u/40009?v=3","gravatar_id":"","url":"https://api.github.com/users/oauth-xx","html_url":"https://github.com/oauth-xx","followers_url":"https://api.github.com/users/oauth-xx/followers","following_url":"https://api.github.com/users/oauth-xx/following{/other_user}","gists_url":"https://api.github.com/users/oauth-xx/gists{/gist_id}","starred_url":"https://api.github.com/users/oauth-xx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oauth-xx/subscriptions","organizations_url":"https://api.github.com/users/oauth-xx/orgs","repos_url":"https://api.github.com/users/oauth-xx/repos","events_url":"https://api.github.com/users/oauth-xx/events{/privacy}","received_events_url":"https://api.github.com/users/oauth-xx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oauth-xx/oauth-ruby","description":"OAuth for Ruby","fork":false,"url":"https://api.github.com/repos/oauth-xx/oauth-ruby","forks_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/forks","keys_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/teams","hooks_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/hooks","issue_events_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/events","assignees_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/tags","blobs_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/languages","stargazers_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/stargazers","contributors_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/contributors","subscribers_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/subscribers","subscription_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/subscription","commits_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/merges","archive_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/downloads","issues_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/labels{/name}","releases_url":"https://api.github.com/repos/oauth-xx/oauth-ruby/releases{/id}","created_at":"2010-02-15T19:02:52Z","updated_at":"2015-09-15T12:05:57Z","pushed_at":"2015-09-16T22:32:42Z","git_url":"git://github.com/oauth-xx/oauth-ruby.git","ssh_url":"git@github.com:oauth-xx/oauth-ruby.git","clone_url":"https://github.com/oauth-xx/oauth-ruby.git","svn_url":"https://github.com/oauth-xx/oauth-ruby","homepage":"http://oauth.rubyforge.org/","size":1107,"stargazers_count":518,"watchers_count":518,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":203,"mirror_url":null,"open_issues_count":53,"forks":203,"open_issues":53,"watchers":518,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oauth-xx/oauth-ruby/pulls/95"},"html":{"href":"https://github.com/oauth-xx/oauth-ruby/pull/95"},"issue":{"href":"https://api.github.com/repos/oauth-xx/oauth-ruby/issues/95"},"comments":{"href":"https://api.github.com/repos/oauth-xx/oauth-ruby/issues/95/comments"},"review_comments":{"href":"https://api.github.com/repos/oauth-xx/oauth-ruby/pulls/95/comments"},"review_comment":{"href":"https://api.github.com/repos/oauth-xx/oauth-ruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oauth-xx/oauth-ruby/pulls/95/commits"},"statuses":{"href":"https://api.github.com/repos/oauth-xx/oauth-ruby/statuses/41ef7c70898a5bddcbb45f018535cb24adcc26d7"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mpapis","id":48054,"avatar_url":"https://avatars.githubusercontent.com/u/48054?v=3","gravatar_id":"","url":"https://api.github.com/users/mpapis","html_url":"https://github.com/mpapis","followers_url":"https://api.github.com/users/mpapis/followers","following_url":"https://api.github.com/users/mpapis/following{/other_user}","gists_url":"https://api.github.com/users/mpapis/gists{/gist_id}","starred_url":"https://api.github.com/users/mpapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpapis/subscriptions","organizations_url":"https://api.github.com/users/mpapis/orgs","repos_url":"https://api.github.com/users/mpapis/repos","events_url":"https://api.github.com/users/mpapis/events{/privacy}","received_events_url":"https://api.github.com/users/mpapis/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":0,"deletions":0,"changed_files":0}}