{"action":"created","comment":{"url":"https://api.github.com/repos/wagn/wagn/pulls/comments/40954387","id":40954387,"diff_hunk":"@@ -69,48 +68,43 @@ def created_by val\n       end\n \n       def member_of val\n-        interpret :right_plus => [RolesID, {:refer_to=>val}]\n+        interpret right_plus: [RolesID, refer_to: val]\n       end\n \n       def member val\n-        interpret :referred_to_by => {:left=>val, :right=>RolesID }\n+        interpret referred_to_by: { left: val, right: RolesID }\n       end\n \n-\n-      #~~~~~~ PLUS RELATIONAL\n+      # ~~~~~~ PLUS RELATIONAL\n \n       def left_plus val\n-        junction :left, val\n+        junction val, :left, :right_id\n       end\n \n       def right_plus val\n-        junction :right, val\n+        junction val, :right, :left_id\n       end\n \n       def plus val\n-        any( { :left_plus=>val, :right_plus=>val.deep_clone } )\n+        any(left_plus: val, right_plus: val.deep_clone)\n       end\n \n-      def junction side, val\n-        part_clause, junction_clause = val.is_a?(Array) ? val : [ val, {} ]\n-        junction_val = clause_to_hash(junction_clause).merge side=>part_clause\n-        to_field = side == :left ? 'right_id' : 'left_id'\n+      def junction val, side, to_field","path":"card/lib/card/query/attributes.rb","position":86,"original_position":86,"commit_id":"5765f34c748496a45ddae2c72168312437ca5eea","original_commit_id":"5765f34c748496a45ddae2c72168312437ca5eea","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Use def with parentheses when there are parameters.","created_at":"2015-10-01T19:15:38Z","updated_at":"2015-10-01T19:15:38Z","html_url":"https://github.com/wagn/wagn/pull/516#discussion_r40954387","pull_request_url":"https://api.github.com/repos/wagn/wagn/pulls/516","_links":{"self":{"href":"https://api.github.com/repos/wagn/wagn/pulls/comments/40954387"},"html":{"href":"https://github.com/wagn/wagn/pull/516#discussion_r40954387"},"pull_request":{"href":"https://api.github.com/repos/wagn/wagn/pulls/516"}}},"pull_request":{"url":"https://api.github.com/repos/wagn/wagn/pulls/516","id":46564514,"html_url":"https://github.com/wagn/wagn/pull/516","diff_url":"https://github.com/wagn/wagn/pull/516.diff","patch_url":"https://github.com/wagn/wagn/pull/516.patch","issue_url":"https://api.github.com/repos/wagn/wagn/issues/516","number":516,"state":"open","locked":false,"title":"Joinnot","user":{"login":"ethn","id":21904,"avatar_url":"https://avatars.githubusercontent.com/u/21904?v=3","gravatar_id":"","url":"https://api.github.com/users/ethn","html_url":"https://github.com/ethn","followers_url":"https://api.github.com/users/ethn/followers","following_url":"https://api.github.com/users/ethn/following{/other_user}","gists_url":"https://api.github.com/users/ethn/gists{/gist_id}","starred_url":"https://api.github.com/users/ethn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethn/subscriptions","organizations_url":"https://api.github.com/users/ethn/orgs","repos_url":"https://api.github.com/users/ethn/repos","events_url":"https://api.github.com/users/ethn/events{/privacy}","received_events_url":"https://api.github.com/users/ethn/received_events","type":"User","site_admin":false},"body":"\"not\" is now working as a subjoin.","created_at":"2015-10-01T19:15:29Z","updated_at":"2015-10-01T19:15:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f00ebfa736fd98f84e5496bef7a23249e54fb748","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wagn/wagn/pulls/516/commits","review_comments_url":"https://api.github.com/repos/wagn/wagn/pulls/516/comments","review_comment_url":"https://api.github.com/repos/wagn/wagn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wagn/wagn/issues/516/comments","statuses_url":"https://api.github.com/repos/wagn/wagn/statuses/5765f34c748496a45ddae2c72168312437ca5eea","head":{"label":"ethn:joinnot","ref":"joinnot","sha":"5765f34c748496a45ddae2c72168312437ca5eea","user":{"login":"ethn","id":21904,"avatar_url":"https://avatars.githubusercontent.com/u/21904?v=3","gravatar_id":"","url":"https://api.github.com/users/ethn","html_url":"https://github.com/ethn","followers_url":"https://api.github.com/users/ethn/followers","following_url":"https://api.github.com/users/ethn/following{/other_user}","gists_url":"https://api.github.com/users/ethn/gists{/gist_id}","starred_url":"https://api.github.com/users/ethn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethn/subscriptions","organizations_url":"https://api.github.com/users/ethn/orgs","repos_url":"https://api.github.com/users/ethn/repos","events_url":"https://api.github.com/users/ethn/events{/privacy}","received_events_url":"https://api.github.com/users/ethn/received_events","type":"User","site_admin":false},"repo":{"id":379894,"name":"wagn","full_name":"ethn/wagn","owner":{"login":"ethn","id":21904,"avatar_url":"https://avatars.githubusercontent.com/u/21904?v=3","gravatar_id":"","url":"https://api.github.com/users/ethn","html_url":"https://github.com/ethn","followers_url":"https://api.github.com/users/ethn/followers","following_url":"https://api.github.com/users/ethn/following{/other_user}","gists_url":"https://api.github.com/users/ethn/gists{/gist_id}","starred_url":"https://api.github.com/users/ethn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethn/subscriptions","organizations_url":"https://api.github.com/users/ethn/orgs","repos_url":"https://api.github.com/users/ethn/repos","events_url":"https://api.github.com/users/ethn/events{/privacy}","received_events_url":"https://api.github.com/users/ethn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ethn/wagn","description":"the wiki on wheels: a Ruby on Rails app for building dynamic, structured websites out of wiki cards","fork":true,"url":"https://api.github.com/repos/ethn/wagn","forks_url":"https://api.github.com/repos/ethn/wagn/forks","keys_url":"https://api.github.com/repos/ethn/wagn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethn/wagn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethn/wagn/teams","hooks_url":"https://api.github.com/repos/ethn/wagn/hooks","issue_events_url":"https://api.github.com/repos/ethn/wagn/issues/events{/number}","events_url":"https://api.github.com/repos/ethn/wagn/events","assignees_url":"https://api.github.com/repos/ethn/wagn/assignees{/user}","branches_url":"https://api.github.com/repos/ethn/wagn/branches{/branch}","tags_url":"https://api.github.com/repos/ethn/wagn/tags","blobs_url":"https://api.github.com/repos/ethn/wagn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethn/wagn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethn/wagn/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethn/wagn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethn/wagn/statuses/{sha}","languages_url":"https://api.github.com/repos/ethn/wagn/languages","stargazers_url":"https://api.github.com/repos/ethn/wagn/stargazers","contributors_url":"https://api.github.com/repos/ethn/wagn/contributors","subscribers_url":"https://api.github.com/repos/ethn/wagn/subscribers","subscription_url":"https://api.github.com/repos/ethn/wagn/subscription","commits_url":"https://api.github.com/repos/ethn/wagn/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethn/wagn/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethn/wagn/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethn/wagn/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethn/wagn/contents/{+path}","compare_url":"https://api.github.com/repos/ethn/wagn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethn/wagn/merges","archive_url":"https://api.github.com/repos/ethn/wagn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethn/wagn/downloads","issues_url":"https://api.github.com/repos/ethn/wagn/issues{/number}","pulls_url":"https://api.github.com/repos/ethn/wagn/pulls{/number}","milestones_url":"https://api.github.com/repos/ethn/wagn/milestones{/number}","notifications_url":"https://api.github.com/repos/ethn/wagn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethn/wagn/labels{/name}","releases_url":"https://api.github.com/repos/ethn/wagn/releases{/id}","created_at":"2009-11-20T19:39:26Z","updated_at":"2015-05-08T05:27:33Z","pushed_at":"2015-10-01T19:15:12Z","git_url":"git://github.com/ethn/wagn.git","ssh_url":"git@github.com:ethn/wagn.git","clone_url":"https://github.com/ethn/wagn.git","svn_url":"https://github.com/ethn/wagn","homepage":"http://www.wagn.org","size":59503,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"wagn:master","ref":"master","sha":"f28b0ee87f525cc4394e434fad9470d9dcdc6624","user":{"login":"wagn","id":20722,"avatar_url":"https://avatars.githubusercontent.com/u/20722?v=3","gravatar_id":"","url":"https://api.github.com/users/wagn","html_url":"https://github.com/wagn","followers_url":"https://api.github.com/users/wagn/followers","following_url":"https://api.github.com/users/wagn/following{/other_user}","gists_url":"https://api.github.com/users/wagn/gists{/gist_id}","starred_url":"https://api.github.com/users/wagn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wagn/subscriptions","organizations_url":"https://api.github.com/users/wagn/orgs","repos_url":"https://api.github.com/users/wagn/repos","events_url":"https://api.github.com/users/wagn/events{/privacy}","received_events_url":"https://api.github.com/users/wagn/received_events","type":"User","site_admin":false},"repo":{"id":44462,"name":"wagn","full_name":"wagn/wagn","owner":{"login":"wagn","id":20722,"avatar_url":"https://avatars.githubusercontent.com/u/20722?v=3","gravatar_id":"","url":"https://api.github.com/users/wagn","html_url":"https://github.com/wagn","followers_url":"https://api.github.com/users/wagn/followers","following_url":"https://api.github.com/users/wagn/following{/other_user}","gists_url":"https://api.github.com/users/wagn/gists{/gist_id}","starred_url":"https://api.github.com/users/wagn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wagn/subscriptions","organizations_url":"https://api.github.com/users/wagn/orgs","repos_url":"https://api.github.com/users/wagn/repos","events_url":"https://api.github.com/users/wagn/events{/privacy}","received_events_url":"https://api.github.com/users/wagn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wagn/wagn","description":"Ruby on rails wiki platform for collaborating to build custom web systems","fork":false,"url":"https://api.github.com/repos/wagn/wagn","forks_url":"https://api.github.com/repos/wagn/wagn/forks","keys_url":"https://api.github.com/repos/wagn/wagn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wagn/wagn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wagn/wagn/teams","hooks_url":"https://api.github.com/repos/wagn/wagn/hooks","issue_events_url":"https://api.github.com/repos/wagn/wagn/issues/events{/number}","events_url":"https://api.github.com/repos/wagn/wagn/events","assignees_url":"https://api.github.com/repos/wagn/wagn/assignees{/user}","branches_url":"https://api.github.com/repos/wagn/wagn/branches{/branch}","tags_url":"https://api.github.com/repos/wagn/wagn/tags","blobs_url":"https://api.github.com/repos/wagn/wagn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wagn/wagn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wagn/wagn/git/refs{/sha}","trees_url":"https://api.github.com/repos/wagn/wagn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wagn/wagn/statuses/{sha}","languages_url":"https://api.github.com/repos/wagn/wagn/languages","stargazers_url":"https://api.github.com/repos/wagn/wagn/stargazers","contributors_url":"https://api.github.com/repos/wagn/wagn/contributors","subscribers_url":"https://api.github.com/repos/wagn/wagn/subscribers","subscription_url":"https://api.github.com/repos/wagn/wagn/subscription","commits_url":"https://api.github.com/repos/wagn/wagn/commits{/sha}","git_commits_url":"https://api.github.com/repos/wagn/wagn/git/commits{/sha}","comments_url":"https://api.github.com/repos/wagn/wagn/comments{/number}","issue_comment_url":"https://api.github.com/repos/wagn/wagn/issues/comments{/number}","contents_url":"https://api.github.com/repos/wagn/wagn/contents/{+path}","compare_url":"https://api.github.com/repos/wagn/wagn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wagn/wagn/merges","archive_url":"https://api.github.com/repos/wagn/wagn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wagn/wagn/downloads","issues_url":"https://api.github.com/repos/wagn/wagn/issues{/number}","pulls_url":"https://api.github.com/repos/wagn/wagn/pulls{/number}","milestones_url":"https://api.github.com/repos/wagn/wagn/milestones{/number}","notifications_url":"https://api.github.com/repos/wagn/wagn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wagn/wagn/labels{/name}","releases_url":"https://api.github.com/repos/wagn/wagn/releases{/id}","created_at":"2008-08-21T00:36:11Z","updated_at":"2015-09-13T03:55:18Z","pushed_at":"2015-10-01T19:15:30Z","git_url":"git://github.com/wagn/wagn.git","ssh_url":"git@github.com:wagn/wagn.git","clone_url":"https://github.com/wagn/wagn.git","svn_url":"https://github.com/wagn/wagn","homepage":"http://www.wagn.org","size":61882,"stargazers_count":253,"watchers_count":253,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":55,"mirror_url":null,"open_issues_count":9,"forks":55,"open_issues":9,"watchers":253,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wagn/wagn/pulls/516"},"html":{"href":"https://github.com/wagn/wagn/pull/516"},"issue":{"href":"https://api.github.com/repos/wagn/wagn/issues/516"},"comments":{"href":"https://api.github.com/repos/wagn/wagn/issues/516/comments"},"review_comments":{"href":"https://api.github.com/repos/wagn/wagn/pulls/516/comments"},"review_comment":{"href":"https://api.github.com/repos/wagn/wagn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wagn/wagn/pulls/516/commits"},"statuses":{"href":"https://api.github.com/repos/wagn/wagn/statuses/5765f34c748496a45ddae2c72168312437ca5eea"}}}}