{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/19415","labels_url":"https://api.github.com/repos/saltstack/salt/issues/19415/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/19415/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/19415/events","html_url":"https://github.com/saltstack/salt/issues/19415","id":53572067,"number":19415,"title":"pkgrepo.managed not enabling disabled ppas","user":{"login":"cameronsparr","id":7155926,"avatar_url":"https://avatars.githubusercontent.com/u/7155926?v=3","gravatar_id":"","url":"https://api.github.com/users/cameronsparr","html_url":"https://github.com/cameronsparr","followers_url":"https://api.github.com/users/cameronsparr/followers","following_url":"https://api.github.com/users/cameronsparr/following{/other_user}","gists_url":"https://api.github.com/users/cameronsparr/gists{/gist_id}","starred_url":"https://api.github.com/users/cameronsparr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cameronsparr/subscriptions","organizations_url":"https://api.github.com/users/cameronsparr/orgs","repos_url":"https://api.github.com/users/cameronsparr/repos","events_url":"https://api.github.com/users/cameronsparr/events{/privacy}","received_events_url":"https://api.github.com/users/cameronsparr/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/saltstack/salt/labels/Bug","name":"Bug","color":"e11d21"},{"url":"https://api.github.com/repos/saltstack/salt/labels/Medium+Severity","name":"Medium Severity","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/saltstack/salt/milestones/13","labels_url":"https://api.github.com/repos/saltstack/salt/milestones/13/labels","id":9265,"number":13,"title":"Approved","description":"All issues that are ready to be worked on, both bugs and features.","creator":{"login":"thatch45","id":507599,"avatar_url":"https://avatars.githubusercontent.com/u/507599?v=3","gravatar_id":"","url":"https://api.github.com/users/thatch45","html_url":"https://github.com/thatch45","followers_url":"https://api.github.com/users/thatch45/followers","following_url":"https://api.github.com/users/thatch45/following{/other_user}","gists_url":"https://api.github.com/users/thatch45/gists{/gist_id}","starred_url":"https://api.github.com/users/thatch45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thatch45/subscriptions","organizations_url":"https://api.github.com/users/thatch45/orgs","repos_url":"https://api.github.com/users/thatch45/repos","events_url":"https://api.github.com/users/thatch45/events{/privacy}","received_events_url":"https://api.github.com/users/thatch45/received_events","type":"User","site_admin":false},"open_issues":1837,"closed_issues":1422,"state":"open","created_at":"2011-05-14T04:00:56Z","updated_at":"2015-01-21T00:01:37Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2015-01-06T22:29:43Z","updated_at":"2015-01-21T01:29:34Z","closed_at":null,"body":"Salt does not appear to be properly recognizing when there are lines in a sources.list or sources.list.d/* file that have been commented out.\r\n\r\nAfter running do-release-upgrade from Ubuntu 12 to 14, our clients had their Java webupd8 ppas disabled (see output below)\r\n\r\nI assumed that Salt would see that these are disabled and re-add them when executing the following state:\r\n\r\n```\r\npkgrepo.managed:\r\n        - humanname: WebUpd8 Oracle Java PPA repository\r\n        - ppa: webupd8team/java\r\n```\r\n\r\nBut it actually did not recognize that the bolded lines below were commented, and passed through the state without doing anything.\r\n\r\nThen when I went to install java, the package was not found.\r\n\r\n```\r\nroot@vwc-es115:~# grep ^ /etc/apt/sources.list /etc/apt/sources.list.d/* | grep java\r\n/etc/apt/sources.list.d/webupd8team-java-precise.list:**# deb http://ppa.launchpad.net/webupd8team/java/ubuntu trusty main # disabled on upgrade to trusty**\r\n/etc/apt/sources.list.d/webupd8team-java-precise.list:**# deb-src http://ppa.launchpad.net/webupd8team/java/ubuntu trusty main # disabled on upgrade to trusty**\r\n/etc/apt/sources.list.d/webupd8team-java-precise.list.distUpgrade:deb http://ppa.launchpad.net/webupd8team/java/ubuntu precise main\r\n/etc/apt/sources.list.d/webupd8team-java-precise.list.distUpgrade:deb-src http://ppa.launchpad.net/webupd8team/java/ubuntu precise main\r\n/etc/apt/sources.list.d/webupd8team-java-precise.list.save:# deb http://ppa.launchpad.net/webupd8team/java/ubuntu trusty main # disabled on upgrade to trusty\r\n/etc/apt/sources.list.d/webupd8team-java-precise.list.save:# deb-src http://ppa.launchpad.net/webupd8team/java/ubuntu trusty main # disabled on upgrade to trusty\r\n```"},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/70769084","html_url":"https://github.com/saltstack/salt/issues/19415#issuecomment-70769084","issue_url":"https://api.github.com/repos/saltstack/salt/issues/19415","id":70769084,"user":{"login":"colincoghill","id":3960086,"avatar_url":"https://avatars.githubusercontent.com/u/3960086?v=3","gravatar_id":"","url":"https://api.github.com/users/colincoghill","html_url":"https://github.com/colincoghill","followers_url":"https://api.github.com/users/colincoghill/followers","following_url":"https://api.github.com/users/colincoghill/following{/other_user}","gists_url":"https://api.github.com/users/colincoghill/gists{/gist_id}","starred_url":"https://api.github.com/users/colincoghill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colincoghill/subscriptions","organizations_url":"https://api.github.com/users/colincoghill/orgs","repos_url":"https://api.github.com/users/colincoghill/repos","events_url":"https://api.github.com/users/colincoghill/events{/privacy}","received_events_url":"https://api.github.com/users/colincoghill/received_events","type":"User","site_admin":false},"created_at":"2015-01-21T01:29:34Z","updated_at":"2015-01-21T01:29:34Z","body":"I have the same problem. \r\n\r\nAfter a quick look at the apt repo module, it appears to only have the code for \"disabled\". So you can get it to comment out a repo with \"disabled: true\" but not get it to enable it again.\r\n\r\n"}}