{"action":"created","comment":{"url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/pulls/comments/38845774","id":38845774,"diff_hunk":"@@ -64,6 +64,32 @@ class: AppBundle\\Client\n         $this->assertEquals('AppBundle\\Client', $client->getClass());\n     }\n \n+    /**\n+     * @dataProvider clientConfigInstance\n+     * @covers CsaGuzzleExtension::buildGuzzleConfig\n+     */\n+    public function testClientConfigInstanceOverride($instanceKey)\n+    {\n+        $serviceId = 'my.message.factory.id';","path":"src/Tests/DependencyInjection/CsaGuzzleExtensionTest.php","position":10,"original_position":10,"commit_id":"4925f5c858e5451fcc6eecfb945e1938010a0233","original_commit_id":"4925f5c858e5451fcc6eecfb945e1938010a0233","user":{"login":"Khez","id":960736,"avatar_url":"https://avatars.githubusercontent.com/u/960736?v=3","gravatar_id":"","url":"https://api.github.com/users/Khez","html_url":"https://github.com/Khez","followers_url":"https://api.github.com/users/Khez/followers","following_url":"https://api.github.com/users/Khez/following{/other_user}","gists_url":"https://api.github.com/users/Khez/gists{/gist_id}","starred_url":"https://api.github.com/users/Khez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Khez/subscriptions","organizations_url":"https://api.github.com/users/Khez/orgs","repos_url":"https://api.github.com/users/Khez/repos","events_url":"https://api.github.com/users/Khez/events{/privacy}","received_events_url":"https://api.github.com/users/Khez/received_events","type":"User","site_admin":false},"body":"Since we're not actually testing the serviceId in a meaningful way, didn't feel the need :?\r\n\r\nIf it's a deal breaker, I can update the PR :)","created_at":"2015-09-07T09:15:07Z","updated_at":"2015-09-07T09:15:07Z","html_url":"https://github.com/csarrazi/CsaGuzzleBundle/pull/50#discussion_r38845774","pull_request_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/pulls/50","_links":{"self":{"href":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/pulls/comments/38845774"},"html":{"href":"https://github.com/csarrazi/CsaGuzzleBundle/pull/50#discussion_r38845774"},"pull_request":{"href":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/pulls/50"}}},"pull_request":{"url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/pulls/50","id":44328642,"html_url":"https://github.com/csarrazi/CsaGuzzleBundle/pull/50","diff_url":"https://github.com/csarrazi/CsaGuzzleBundle/pull/50.diff","patch_url":"https://github.com/csarrazi/CsaGuzzleBundle/pull/50.patch","issue_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/issues/50","number":50,"state":"open","locked":false,"title":"Fix CsaGuzzleExtension to allow symfony services","user":{"login":"Khez","id":960736,"avatar_url":"https://avatars.githubusercontent.com/u/960736?v=3","gravatar_id":"","url":"https://api.github.com/users/Khez","html_url":"https://github.com/Khez","followers_url":"https://api.github.com/users/Khez/followers","following_url":"https://api.github.com/users/Khez/following{/other_user}","gists_url":"https://api.github.com/users/Khez/gists{/gist_id}","starred_url":"https://api.github.com/users/Khez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Khez/subscriptions","organizations_url":"https://api.github.com/users/Khez/orgs","repos_url":"https://api.github.com/users/Khez/repos","events_url":"https://api.github.com/users/Khez/events{/privacy}","received_events_url":"https://api.github.com/users/Khez/received_events","type":"User","site_admin":false},"body":"Hello,\r\nThis is a fix in CsaGuzzleExtension to allow symfony services where class instances are used directly from config array.\r\n\r\nIn GuzzleHttp/Client::__construct(), four keys are expected to be instances of a class.\r\nNamely *message_factory*, *fsm*, *handler* and *adapter*.\r\n\r\nMy personal use case, required me to extend the _message_factory_ class for some special routines.\r\nThis appears to be an oversight in both 1.3 and 2.0 (where only the handler key remains)\r\n\r\nAlso added some tests for this scenario.\r\n\r\nBest Regards,\r\nKhez","created_at":"2015-09-07T07:55:54Z","updated_at":"2015-09-07T09:15:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b5ac0b0d78f3acdff06a614010bcb966ebeba99","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/pulls/50/commits","review_comments_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/pulls/50/comments","review_comment_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/issues/50/comments","statuses_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/statuses/4925f5c858e5451fcc6eecfb945e1938010a0233","head":{"label":"Khez:1.3","ref":"1.3","sha":"4925f5c858e5451fcc6eecfb945e1938010a0233","user":{"login":"Khez","id":960736,"avatar_url":"https://avatars.githubusercontent.com/u/960736?v=3","gravatar_id":"","url":"https://api.github.com/users/Khez","html_url":"https://github.com/Khez","followers_url":"https://api.github.com/users/Khez/followers","following_url":"https://api.github.com/users/Khez/following{/other_user}","gists_url":"https://api.github.com/users/Khez/gists{/gist_id}","starred_url":"https://api.github.com/users/Khez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Khez/subscriptions","organizations_url":"https://api.github.com/users/Khez/orgs","repos_url":"https://api.github.com/users/Khez/repos","events_url":"https://api.github.com/users/Khez/events{/privacy}","received_events_url":"https://api.github.com/users/Khez/received_events","type":"User","site_admin":false},"repo":{"id":41980119,"name":"CsaGuzzleBundle","full_name":"Khez/CsaGuzzleBundle","owner":{"login":"Khez","id":960736,"avatar_url":"https://avatars.githubusercontent.com/u/960736?v=3","gravatar_id":"","url":"https://api.github.com/users/Khez","html_url":"https://github.com/Khez","followers_url":"https://api.github.com/users/Khez/followers","following_url":"https://api.github.com/users/Khez/following{/other_user}","gists_url":"https://api.github.com/users/Khez/gists{/gist_id}","starred_url":"https://api.github.com/users/Khez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Khez/subscriptions","organizations_url":"https://api.github.com/users/Khez/orgs","repos_url":"https://api.github.com/users/Khez/repos","events_url":"https://api.github.com/users/Khez/events{/privacy}","received_events_url":"https://api.github.com/users/Khez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Khez/CsaGuzzleBundle","description":"A bundle integrating Guzzle >=4.0 in Symfony","fork":true,"url":"https://api.github.com/repos/Khez/CsaGuzzleBundle","forks_url":"https://api.github.com/repos/Khez/CsaGuzzleBundle/forks","keys_url":"https://api.github.com/repos/Khez/CsaGuzzleBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Khez/CsaGuzzleBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Khez/CsaGuzzleBundle/teams","hooks_url":"https://api.github.com/repos/Khez/CsaGuzzleBundle/hooks","issue_events_url":"https://api.github.com/repos/Khez/CsaGuzzleBundle/issues/events{/number}","events_url":"https://api.github.com/repos/Khez/CsaGuzzleBundle/events","assignees_url":"https://api.github.com/repos/Khez/CsaGuzzleBundle/assignees{/user}","branches_url":"https://api.github.com/repos/Khez/CsaGuzzleBundle/branches{/branch}","tags_url":"https://api.github.com/repos/Khez/CsaGuzzleBundle/tags","blobs_url":"https://api.github.com/repos/Khez/CsaGuzzleBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Khez/CsaGuzzleBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Khez/CsaGuzzleBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/Khez/CsaGuzzleBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Khez/CsaGuzzleBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/Khez/CsaGuzzleBundle/languages","stargazers_url":"https://api.github.com/repos/Khez/CsaGuzzleBundle/stargazers","contributors_url":"https://api.github.com/repos/Khez/CsaGuzzleBundle/contributors","subscribers_url":"https://api.github.com/repos/Khez/CsaGuzzleBundle/subscribers","subscription_url":"https://api.github.com/repos/Khez/CsaGuzzleBundle/subscription","commits_url":"https://api.github.com/repos/Khez/CsaGuzzleBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/Khez/CsaGuzzleBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/Khez/CsaGuzzleBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/Khez/CsaGuzzleBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/Khez/CsaGuzzleBundle/contents/{+path}","compare_url":"https://api.github.com/repos/Khez/CsaGuzzleBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Khez/CsaGuzzleBundle/merges","archive_url":"https://api.github.com/repos/Khez/CsaGuzzleBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Khez/CsaGuzzleBundle/downloads","issues_url":"https://api.github.com/repos/Khez/CsaGuzzleBundle/issues{/number}","pulls_url":"https://api.github.com/repos/Khez/CsaGuzzleBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/Khez/CsaGuzzleBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/Khez/CsaGuzzleBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Khez/CsaGuzzleBundle/labels{/name}","releases_url":"https://api.github.com/repos/Khez/CsaGuzzleBundle/releases{/id}","created_at":"2015-09-06T00:02:21Z","updated_at":"2015-09-06T00:02:22Z","pushed_at":"2015-09-07T07:47:59Z","git_url":"git://github.com/Khez/CsaGuzzleBundle.git","ssh_url":"git@github.com:Khez/CsaGuzzleBundle.git","clone_url":"https://github.com/Khez/CsaGuzzleBundle.git","svn_url":"https://github.com/Khez/CsaGuzzleBundle","homepage":"","size":900,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"csarrazi:1.3","ref":"1.3","sha":"187481820acc2c6fd1d1168e25bc1131b0d78fc9","user":{"login":"csarrazi","id":465798,"avatar_url":"https://avatars.githubusercontent.com/u/465798?v=3","gravatar_id":"","url":"https://api.github.com/users/csarrazi","html_url":"https://github.com/csarrazi","followers_url":"https://api.github.com/users/csarrazi/followers","following_url":"https://api.github.com/users/csarrazi/following{/other_user}","gists_url":"https://api.github.com/users/csarrazi/gists{/gist_id}","starred_url":"https://api.github.com/users/csarrazi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csarrazi/subscriptions","organizations_url":"https://api.github.com/users/csarrazi/orgs","repos_url":"https://api.github.com/users/csarrazi/repos","events_url":"https://api.github.com/users/csarrazi/events{/privacy}","received_events_url":"https://api.github.com/users/csarrazi/received_events","type":"User","site_admin":false},"repo":{"id":18691924,"name":"CsaGuzzleBundle","full_name":"csarrazi/CsaGuzzleBundle","owner":{"login":"csarrazi","id":465798,"avatar_url":"https://avatars.githubusercontent.com/u/465798?v=3","gravatar_id":"","url":"https://api.github.com/users/csarrazi","html_url":"https://github.com/csarrazi","followers_url":"https://api.github.com/users/csarrazi/followers","following_url":"https://api.github.com/users/csarrazi/following{/other_user}","gists_url":"https://api.github.com/users/csarrazi/gists{/gist_id}","starred_url":"https://api.github.com/users/csarrazi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csarrazi/subscriptions","organizations_url":"https://api.github.com/users/csarrazi/orgs","repos_url":"https://api.github.com/users/csarrazi/repos","events_url":"https://api.github.com/users/csarrazi/events{/privacy}","received_events_url":"https://api.github.com/users/csarrazi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/csarrazi/CsaGuzzleBundle","description":"A bundle integrating Guzzle >=4.0 in Symfony","fork":false,"url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle","forks_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/forks","keys_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/teams","hooks_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/hooks","issue_events_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/issues/events{/number}","events_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/events","assignees_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/assignees{/user}","branches_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/branches{/branch}","tags_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/tags","blobs_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/languages","stargazers_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/stargazers","contributors_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/contributors","subscribers_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/subscribers","subscription_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/subscription","commits_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/contents/{+path}","compare_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/merges","archive_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/downloads","issues_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/issues{/number}","pulls_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/labels{/name}","releases_url":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/releases{/id}","created_at":"2014-04-11T23:45:04Z","updated_at":"2015-09-03T08:42:02Z","pushed_at":"2015-09-07T07:55:55Z","git_url":"git://github.com/csarrazi/CsaGuzzleBundle.git","ssh_url":"git@github.com:csarrazi/CsaGuzzleBundle.git","clone_url":"https://github.com/csarrazi/CsaGuzzleBundle.git","svn_url":"https://github.com/csarrazi/CsaGuzzleBundle","homepage":"","size":1636,"stargazers_count":45,"watchers_count":45,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":16,"mirror_url":null,"open_issues_count":5,"forks":16,"open_issues":5,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/pulls/50"},"html":{"href":"https://github.com/csarrazi/CsaGuzzleBundle/pull/50"},"issue":{"href":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/issues/50"},"comments":{"href":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/csarrazi/CsaGuzzleBundle/statuses/4925f5c858e5451fcc6eecfb945e1938010a0233"}}}}