{"action":"created","comment":{"url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/comments/47252727","id":47252727,"diff_hunk":"@@ -467,7 +468,8 @@ protected static void addCacheControlHeaders(final HttpServletResponse servletRe\n         final Date date = mutableResource.getLastModifiedDate();\n \n         if (!etag.getValue().isEmpty()) {\n-            servletResponse.addHeader(\"ETag\", etag.toString());\n+            servletResponse.addHeader(\"ETag\", mutableResource.hasType(FEDORA_NON_RDF_SOURCE_DESCRIPTION) ?\n+               etag.toString() : \"W/\" + etag.toString());","path":"fcrepo-http-api/src/main/java/org/fcrepo/http/api/ContentExposingResource.java","position":14,"original_position":14,"commit_id":"ff3cf932b58f8b74a958b5282da790832be82aa8","original_commit_id":"ff3cf932b58f8b74a958b5282da790832be82aa8","user":{"login":"ajs6f","id":110994,"avatar_url":"https://avatars.githubusercontent.com/u/110994?v=3","gravatar_id":"","url":"https://api.github.com/users/ajs6f","html_url":"https://github.com/ajs6f","followers_url":"https://api.github.com/users/ajs6f/followers","following_url":"https://api.github.com/users/ajs6f/following{/other_user}","gists_url":"https://api.github.com/users/ajs6f/gists{/gist_id}","starred_url":"https://api.github.com/users/ajs6f/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajs6f/subscriptions","organizations_url":"https://api.github.com/users/ajs6f/orgs","repos_url":"https://api.github.com/users/ajs6f/repos","events_url":"https://api.github.com/users/ajs6f/events{/privacy}","received_events_url":"https://api.github.com/users/ajs6f/received_events","type":"User","site_admin":false},"body":"No need for `\"W/\" + etag.toString())` because `toString()` is implicit. Just `\"W/\" + etag` is fine. In fact I would prefer:\r\n```\r\nservletResponse.addHeader(\"ETag\", mutableResource.hasType((FEDORA_NON_RDF_SOURCE_DESCRIPTION) ?\r\n+              \"\" : \"W/\" ) + etag);\r\n```","created_at":"2015-12-10T16:58:06Z","updated_at":"2015-12-10T16:58:06Z","html_url":"https://github.com/fcrepo4/fcrepo4/pull/920#discussion_r47252727","pull_request_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/920","_links":{"self":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/comments/47252727"},"html":{"href":"https://github.com/fcrepo4/fcrepo4/pull/920#discussion_r47252727"},"pull_request":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/920"}}},"pull_request":{"url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/920","id":48747491,"html_url":"https://github.com/fcrepo4/fcrepo4/pull/920","diff_url":"https://github.com/fcrepo4/fcrepo4/pull/920.diff","patch_url":"https://github.com/fcrepo4/fcrepo4/pull/920.patch","issue_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/920","number":920,"state":"open","locked":false,"title":"change strong ETags to weak ETags","user":{"login":"nianma","id":10924728,"avatar_url":"https://avatars.githubusercontent.com/u/10924728?v=3","gravatar_id":"","url":"https://api.github.com/users/nianma","html_url":"https://github.com/nianma","followers_url":"https://api.github.com/users/nianma/followers","following_url":"https://api.github.com/users/nianma/following{/other_user}","gists_url":"https://api.github.com/users/nianma/gists{/gist_id}","starred_url":"https://api.github.com/users/nianma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nianma/subscriptions","organizations_url":"https://api.github.com/users/nianma/orgs","repos_url":"https://api.github.com/users/nianma/repos","events_url":"https://api.github.com/users/nianma/events{/privacy}","received_events_url":"https://api.github.com/users/nianma/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-26T14:40:56Z","updated_at":"2015-12-10T16:58:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57e4a5366f22bd136e7aa696ff51c4563e67180b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/920/commits","review_comments_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/920/comments","review_comment_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/920/comments","statuses_url":"https://api.github.com/repos/fcrepo4/fcrepo4/statuses/ff3cf932b58f8b74a958b5282da790832be82aa8","head":{"label":"nianma:fcrepo-1754","ref":"fcrepo-1754","sha":"ff3cf932b58f8b74a958b5282da790832be82aa8","user":{"login":"nianma","id":10924728,"avatar_url":"https://avatars.githubusercontent.com/u/10924728?v=3","gravatar_id":"","url":"https://api.github.com/users/nianma","html_url":"https://github.com/nianma","followers_url":"https://api.github.com/users/nianma/followers","following_url":"https://api.github.com/users/nianma/following{/other_user}","gists_url":"https://api.github.com/users/nianma/gists{/gist_id}","starred_url":"https://api.github.com/users/nianma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nianma/subscriptions","organizations_url":"https://api.github.com/users/nianma/orgs","repos_url":"https://api.github.com/users/nianma/repos","events_url":"https://api.github.com/users/nianma/events{/privacy}","received_events_url":"https://api.github.com/users/nianma/received_events","type":"User","site_admin":false},"repo":{"id":30549193,"name":"fcrepo4","full_name":"nianma/fcrepo4","owner":{"login":"nianma","id":10924728,"avatar_url":"https://avatars.githubusercontent.com/u/10924728?v=3","gravatar_id":"","url":"https://api.github.com/users/nianma","html_url":"https://github.com/nianma","followers_url":"https://api.github.com/users/nianma/followers","following_url":"https://api.github.com/users/nianma/following{/other_user}","gists_url":"https://api.github.com/users/nianma/gists{/gist_id}","starred_url":"https://api.github.com/users/nianma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nianma/subscriptions","organizations_url":"https://api.github.com/users/nianma/orgs","repos_url":"https://api.github.com/users/nianma/repos","events_url":"https://api.github.com/users/nianma/events{/privacy}","received_events_url":"https://api.github.com/users/nianma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nianma/fcrepo4","description":"Fedora 4","fork":true,"url":"https://api.github.com/repos/nianma/fcrepo4","forks_url":"https://api.github.com/repos/nianma/fcrepo4/forks","keys_url":"https://api.github.com/repos/nianma/fcrepo4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nianma/fcrepo4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nianma/fcrepo4/teams","hooks_url":"https://api.github.com/repos/nianma/fcrepo4/hooks","issue_events_url":"https://api.github.com/repos/nianma/fcrepo4/issues/events{/number}","events_url":"https://api.github.com/repos/nianma/fcrepo4/events","assignees_url":"https://api.github.com/repos/nianma/fcrepo4/assignees{/user}","branches_url":"https://api.github.com/repos/nianma/fcrepo4/branches{/branch}","tags_url":"https://api.github.com/repos/nianma/fcrepo4/tags","blobs_url":"https://api.github.com/repos/nianma/fcrepo4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nianma/fcrepo4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nianma/fcrepo4/git/refs{/sha}","trees_url":"https://api.github.com/repos/nianma/fcrepo4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nianma/fcrepo4/statuses/{sha}","languages_url":"https://api.github.com/repos/nianma/fcrepo4/languages","stargazers_url":"https://api.github.com/repos/nianma/fcrepo4/stargazers","contributors_url":"https://api.github.com/repos/nianma/fcrepo4/contributors","subscribers_url":"https://api.github.com/repos/nianma/fcrepo4/subscribers","subscription_url":"https://api.github.com/repos/nianma/fcrepo4/subscription","commits_url":"https://api.github.com/repos/nianma/fcrepo4/commits{/sha}","git_commits_url":"https://api.github.com/repos/nianma/fcrepo4/git/commits{/sha}","comments_url":"https://api.github.com/repos/nianma/fcrepo4/comments{/number}","issue_comment_url":"https://api.github.com/repos/nianma/fcrepo4/issues/comments{/number}","contents_url":"https://api.github.com/repos/nianma/fcrepo4/contents/{+path}","compare_url":"https://api.github.com/repos/nianma/fcrepo4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nianma/fcrepo4/merges","archive_url":"https://api.github.com/repos/nianma/fcrepo4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nianma/fcrepo4/downloads","issues_url":"https://api.github.com/repos/nianma/fcrepo4/issues{/number}","pulls_url":"https://api.github.com/repos/nianma/fcrepo4/pulls{/number}","milestones_url":"https://api.github.com/repos/nianma/fcrepo4/milestones{/number}","notifications_url":"https://api.github.com/repos/nianma/fcrepo4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nianma/fcrepo4/labels{/name}","releases_url":"https://api.github.com/repos/nianma/fcrepo4/releases{/id}","created_at":"2015-02-09T17:44:28Z","updated_at":"2015-03-09T15:48:30Z","pushed_at":"2015-12-04T20:54:09Z","git_url":"git://github.com/nianma/fcrepo4.git","ssh_url":"git@github.com:nianma/fcrepo4.git","clone_url":"https://github.com/nianma/fcrepo4.git","svn_url":"https://github.com/nianma/fcrepo4","homepage":"http://github.com/fcrepo4/fcrepo4","size":66072,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fcrepo4:master","ref":"master","sha":"19639e1998f3187c09640b29ca5a892b61d63010","user":{"login":"fcrepo4","id":3057565,"avatar_url":"https://avatars.githubusercontent.com/u/3057565?v=3","gravatar_id":"","url":"https://api.github.com/users/fcrepo4","html_url":"https://github.com/fcrepo4","followers_url":"https://api.github.com/users/fcrepo4/followers","following_url":"https://api.github.com/users/fcrepo4/following{/other_user}","gists_url":"https://api.github.com/users/fcrepo4/gists{/gist_id}","starred_url":"https://api.github.com/users/fcrepo4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcrepo4/subscriptions","organizations_url":"https://api.github.com/users/fcrepo4/orgs","repos_url":"https://api.github.com/users/fcrepo4/repos","events_url":"https://api.github.com/users/fcrepo4/events{/privacy}","received_events_url":"https://api.github.com/users/fcrepo4/received_events","type":"Organization","site_admin":false},"repo":{"id":7992797,"name":"fcrepo4","full_name":"fcrepo4/fcrepo4","owner":{"login":"fcrepo4","id":3057565,"avatar_url":"https://avatars.githubusercontent.com/u/3057565?v=3","gravatar_id":"","url":"https://api.github.com/users/fcrepo4","html_url":"https://github.com/fcrepo4","followers_url":"https://api.github.com/users/fcrepo4/followers","following_url":"https://api.github.com/users/fcrepo4/following{/other_user}","gists_url":"https://api.github.com/users/fcrepo4/gists{/gist_id}","starred_url":"https://api.github.com/users/fcrepo4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcrepo4/subscriptions","organizations_url":"https://api.github.com/users/fcrepo4/orgs","repos_url":"https://api.github.com/users/fcrepo4/repos","events_url":"https://api.github.com/users/fcrepo4/events{/privacy}","received_events_url":"https://api.github.com/users/fcrepo4/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fcrepo4/fcrepo4","description":"Fedora 4","fork":false,"url":"https://api.github.com/repos/fcrepo4/fcrepo4","forks_url":"https://api.github.com/repos/fcrepo4/fcrepo4/forks","keys_url":"https://api.github.com/repos/fcrepo4/fcrepo4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fcrepo4/fcrepo4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fcrepo4/fcrepo4/teams","hooks_url":"https://api.github.com/repos/fcrepo4/fcrepo4/hooks","issue_events_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/events{/number}","events_url":"https://api.github.com/repos/fcrepo4/fcrepo4/events","assignees_url":"https://api.github.com/repos/fcrepo4/fcrepo4/assignees{/user}","branches_url":"https://api.github.com/repos/fcrepo4/fcrepo4/branches{/branch}","tags_url":"https://api.github.com/repos/fcrepo4/fcrepo4/tags","blobs_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/refs{/sha}","trees_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fcrepo4/fcrepo4/statuses/{sha}","languages_url":"https://api.github.com/repos/fcrepo4/fcrepo4/languages","stargazers_url":"https://api.github.com/repos/fcrepo4/fcrepo4/stargazers","contributors_url":"https://api.github.com/repos/fcrepo4/fcrepo4/contributors","subscribers_url":"https://api.github.com/repos/fcrepo4/fcrepo4/subscribers","subscription_url":"https://api.github.com/repos/fcrepo4/fcrepo4/subscription","commits_url":"https://api.github.com/repos/fcrepo4/fcrepo4/commits{/sha}","git_commits_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/commits{/sha}","comments_url":"https://api.github.com/repos/fcrepo4/fcrepo4/comments{/number}","issue_comment_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/comments{/number}","contents_url":"https://api.github.com/repos/fcrepo4/fcrepo4/contents/{+path}","compare_url":"https://api.github.com/repos/fcrepo4/fcrepo4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fcrepo4/fcrepo4/merges","archive_url":"https://api.github.com/repos/fcrepo4/fcrepo4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fcrepo4/fcrepo4/downloads","issues_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues{/number}","pulls_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls{/number}","milestones_url":"https://api.github.com/repos/fcrepo4/fcrepo4/milestones{/number}","notifications_url":"https://api.github.com/repos/fcrepo4/fcrepo4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fcrepo4/fcrepo4/labels{/name}","releases_url":"https://api.github.com/repos/fcrepo4/fcrepo4/releases{/id}","created_at":"2013-02-03T16:18:55Z","updated_at":"2015-12-07T15:47:29Z","pushed_at":"2015-12-09T23:13:26Z","git_url":"git://github.com/fcrepo4/fcrepo4.git","ssh_url":"git@github.com:fcrepo4/fcrepo4.git","clone_url":"https://github.com/fcrepo4/fcrepo4.git","svn_url":"https://github.com/fcrepo4/fcrepo4","homepage":"http://github.com/fcrepo4/fcrepo4","size":131532,"stargazers_count":56,"watchers_count":56,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":80,"mirror_url":null,"open_issues_count":30,"forks":80,"open_issues":30,"watchers":56,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/920"},"html":{"href":"https://github.com/fcrepo4/fcrepo4/pull/920"},"issue":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/920"},"comments":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/920/comments"},"review_comments":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/920/comments"},"review_comment":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/920/commits"},"statuses":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/statuses/ff3cf932b58f8b74a958b5282da790832be82aa8"}}}}