{"action":"created","issue":{"url":"https://api.github.com/repos/odoo/odoo/issues/6405","labels_url":"https://api.github.com/repos/odoo/odoo/issues/6405/labels{/name}","comments_url":"https://api.github.com/repos/odoo/odoo/issues/6405/comments","events_url":"https://api.github.com/repos/odoo/odoo/issues/6405/events","html_url":"https://github.com/odoo/odoo/pull/6405","id":69810359,"number":6405,"title":"[FIX] Onchange: compare changes using === operator","user":{"login":"andreparames","id":206160,"avatar_url":"https://avatars.githubusercontent.com/u/206160?v=3","gravatar_id":"","url":"https://api.github.com/users/andreparames","html_url":"https://github.com/andreparames","followers_url":"https://api.github.com/users/andreparames/followers","following_url":"https://api.github.com/users/andreparames/following{/other_user}","gists_url":"https://api.github.com/users/andreparames/gists{/gist_id}","starred_url":"https://api.github.com/users/andreparames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreparames/subscriptions","organizations_url":"https://api.github.com/users/andreparames/orgs","repos_url":"https://api.github.com/users/andreparames/repos","events_url":"https://api.github.com/users/andreparames/events{/privacy}","received_events_url":"https://api.github.com/users/andreparames/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-21T10:41:17Z","updated_at":"2015-04-23T13:43:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/odoo/odoo/pulls/6405","html_url":"https://github.com/odoo/odoo/pull/6405","diff_url":"https://github.com/odoo/odoo/pull/6405.diff","patch_url":"https://github.com/odoo/odoo/pull/6405.patch"},"body":"Impacted versions:\r\n - 8.0\r\n\r\nSteps to reproduce:\r\n 1. create an object with a char field\r\n 2. add an onchange method that returns the string \"0000\" as a value of that field\r\n 3. trigger the onchange\r\n\r\nCurrent behavior:\r\n - The field stays empty / null\r\n\r\nExpected behavior:\r\n - The field changes to \"0000\"\r\n\r\nThis patches changes the comparison to use the === operator, therefore treating `\"0000\"` as not equal to `false`, and therefore correctly updating the field value."},"comment":{"url":"https://api.github.com/repos/odoo/odoo/issues/comments/95590646","html_url":"https://github.com/odoo/odoo/pull/6405#issuecomment-95590646","issue_url":"https://api.github.com/repos/odoo/odoo/issues/6405","id":95590646,"user":{"login":"mart-e","id":564822,"avatar_url":"https://avatars.githubusercontent.com/u/564822?v=3","gravatar_id":"","url":"https://api.github.com/users/mart-e","html_url":"https://github.com/mart-e","followers_url":"https://api.github.com/users/mart-e/followers","following_url":"https://api.github.com/users/mart-e/following{/other_user}","gists_url":"https://api.github.com/users/mart-e/gists{/gist_id}","starred_url":"https://api.github.com/users/mart-e/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mart-e/subscriptions","organizations_url":"https://api.github.com/users/mart-e/orgs","repos_url":"https://api.github.com/users/mart-e/repos","events_url":"https://api.github.com/users/mart-e/events{/privacy}","received_events_url":"https://api.github.com/users/mart-e/received_events","type":"User","site_admin":false},"created_at":"2015-04-23T13:43:00Z","updated_at":"2015-04-23T13:43:00Z","body":"Hello,\r\n\r\nThanks for the patch, it looks good. On your CLA signature (thanks for that), you mark it for a `@andreparames.com` email address while that commit was signed with a `@thinkopen.solutions` address (the first one was ok).\r\nAre you using both addresses (so you can sign for both) or is it a mistake ?"}}