{"action":"created","comment":{"url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/pulls/comments/23927541","id":23927541,"diff_hunk":"@@ -0,0 +1,110 @@\n+package com.suse.saltstack.netapi.client;\n+\n+import com.suse.saltstack.netapi.config.SaltStackClientConfig;\n+import com.suse.saltstack.netapi.exception.SaltStackException;\n+import com.suse.saltstack.netapi.utils.SaltStackClientUtils;\n+\n+import com.google.gson.Gson;\n+\n+import java.io.BufferedReader;\n+import java.io.DataOutputStream;\n+import java.io.IOException;\n+import java.io.InputStream;\n+import java.io.InputStreamReader;\n+import java.io.Reader;\n+import java.lang.reflect.Type;\n+import java.net.HttpURLConnection;\n+\n+/**\n+ * Class representation of a connection to SaltStack for issuing API requests using JDK's HttpURLConnection.\n+ */\n+public class SaltStackJdkConnection implements SaltStackConnection {","path":"src/main/java/com/suse/saltstack/netapi/client/SaltStackJdkConnection.java","position":21,"original_position":21,"commit_id":"19555541af47033ef928b2cfc0f2d8cc49ac5e7a","original_commit_id":"19555541af47033ef928b2cfc0f2d8cc49ac5e7a","user":{"login":"renner","id":729454,"avatar_url":"https://avatars.githubusercontent.com/u/729454?v=3","gravatar_id":"","url":"https://api.github.com/users/renner","html_url":"https://github.com/renner","followers_url":"https://api.github.com/users/renner/followers","following_url":"https://api.github.com/users/renner/following{/other_user}","gists_url":"https://api.github.com/users/renner/gists{/gist_id}","starred_url":"https://api.github.com/users/renner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renner/subscriptions","organizations_url":"https://api.github.com/users/renner/orgs","repos_url":"https://api.github.com/users/renner/repos","events_url":"https://api.github.com/users/renner/events{/privacy}","received_events_url":"https://api.github.com/users/renner/received_events","type":"User","site_admin":false},"body":"I know that it doesn't really matter, but for 3 letter acronyms (that cannot be [avoided] (http://www.oracle.com/technetwork/java/codeconventions-135099.html)) I would prefer to put them all uppercase in class names. So consider to rename this class (and related ones accordingly) to `SaltStackJDKConnection` or maybe get rid of JDK in the class names overall.","created_at":"2015-02-02T14:32:27Z","updated_at":"2015-02-02T14:32:27Z","html_url":"https://github.com/SUSE/saltstack-netapi-client-java/pull/1#discussion_r23927541","pull_request_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/pulls/comments/23927541"},"html":{"href":"https://github.com/SUSE/saltstack-netapi-client-java/pull/1#discussion_r23927541"},"pull_request":{"href":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/pulls/1","id":28432572,"html_url":"https://github.com/SUSE/saltstack-netapi-client-java/pull/1","diff_url":"https://github.com/SUSE/saltstack-netapi-client-java/pull/1.diff","patch_url":"https://github.com/SUSE/saltstack-netapi-client-java/pull/1.patch","issue_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/issues/1","number":1,"state":"open","locked":false,"title":"Add testing support","user":{"login":"dgiagio","id":124647,"avatar_url":"https://avatars.githubusercontent.com/u/124647?v=3","gravatar_id":"","url":"https://api.github.com/users/dgiagio","html_url":"https://github.com/dgiagio","followers_url":"https://api.github.com/users/dgiagio/followers","following_url":"https://api.github.com/users/dgiagio/following{/other_user}","gists_url":"https://api.github.com/users/dgiagio/gists{/gist_id}","starred_url":"https://api.github.com/users/dgiagio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgiagio/subscriptions","organizations_url":"https://api.github.com/users/dgiagio/orgs","repos_url":"https://api.github.com/users/dgiagio/repos","events_url":"https://api.github.com/users/dgiagio/events{/privacy}","received_events_url":"https://api.github.com/users/dgiagio/received_events","type":"User","site_admin":false},"body":"- Improved .gitignore entries for IntelliJ IDEA and testing output\r\n- Added/improved ant's support for testing and report generating\r\n- Refactored some classes to allow for pluggable HTTP connection implementation (HttpURLConnection and HttpComponents [TODO])\r\n- Added initial testing via JUnit\r\n- Added support for mocking JSON responses on unit-tests\r\n- Added support for mocking exceptions on unit-tests\r\n","created_at":"2015-02-01T15:39:29Z","updated_at":"2015-02-02T14:32:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7cf6a502afef96a265d249755492483b0c7c4d61","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/pulls/1/commits","review_comments_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/pulls/1/comments","review_comment_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/pulls/comments/{number}","comments_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/issues/1/comments","statuses_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/statuses/19555541af47033ef928b2cfc0f2d8cc49ac5e7a","head":{"label":"dgiagio:add_testing_support","ref":"add_testing_support","sha":"19555541af47033ef928b2cfc0f2d8cc49ac5e7a","user":{"login":"dgiagio","id":124647,"avatar_url":"https://avatars.githubusercontent.com/u/124647?v=3","gravatar_id":"","url":"https://api.github.com/users/dgiagio","html_url":"https://github.com/dgiagio","followers_url":"https://api.github.com/users/dgiagio/followers","following_url":"https://api.github.com/users/dgiagio/following{/other_user}","gists_url":"https://api.github.com/users/dgiagio/gists{/gist_id}","starred_url":"https://api.github.com/users/dgiagio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgiagio/subscriptions","organizations_url":"https://api.github.com/users/dgiagio/orgs","repos_url":"https://api.github.com/users/dgiagio/repos","events_url":"https://api.github.com/users/dgiagio/events{/privacy}","received_events_url":"https://api.github.com/users/dgiagio/received_events","type":"User","site_admin":false},"repo":{"id":30121364,"name":"saltstack-netapi-client-java","full_name":"dgiagio/saltstack-netapi-client-java","owner":{"login":"dgiagio","id":124647,"avatar_url":"https://avatars.githubusercontent.com/u/124647?v=3","gravatar_id":"","url":"https://api.github.com/users/dgiagio","html_url":"https://github.com/dgiagio","followers_url":"https://api.github.com/users/dgiagio/followers","following_url":"https://api.github.com/users/dgiagio/following{/other_user}","gists_url":"https://api.github.com/users/dgiagio/gists{/gist_id}","starred_url":"https://api.github.com/users/dgiagio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgiagio/subscriptions","organizations_url":"https://api.github.com/users/dgiagio/orgs","repos_url":"https://api.github.com/users/dgiagio/repos","events_url":"https://api.github.com/users/dgiagio/events{/privacy}","received_events_url":"https://api.github.com/users/dgiagio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dgiagio/saltstack-netapi-client-java","description":"Java client to access the SaltStack net-api","fork":true,"url":"https://api.github.com/repos/dgiagio/saltstack-netapi-client-java","forks_url":"https://api.github.com/repos/dgiagio/saltstack-netapi-client-java/forks","keys_url":"https://api.github.com/repos/dgiagio/saltstack-netapi-client-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dgiagio/saltstack-netapi-client-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dgiagio/saltstack-netapi-client-java/teams","hooks_url":"https://api.github.com/repos/dgiagio/saltstack-netapi-client-java/hooks","issue_events_url":"https://api.github.com/repos/dgiagio/saltstack-netapi-client-java/issues/events{/number}","events_url":"https://api.github.com/repos/dgiagio/saltstack-netapi-client-java/events","assignees_url":"https://api.github.com/repos/dgiagio/saltstack-netapi-client-java/assignees{/user}","branches_url":"https://api.github.com/repos/dgiagio/saltstack-netapi-client-java/branches{/branch}","tags_url":"https://api.github.com/repos/dgiagio/saltstack-netapi-client-java/tags","blobs_url":"https://api.github.com/repos/dgiagio/saltstack-netapi-client-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dgiagio/saltstack-netapi-client-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dgiagio/saltstack-netapi-client-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/dgiagio/saltstack-netapi-client-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dgiagio/saltstack-netapi-client-java/statuses/{sha}","languages_url":"https://api.github.com/repos/dgiagio/saltstack-netapi-client-java/languages","stargazers_url":"https://api.github.com/repos/dgiagio/saltstack-netapi-client-java/stargazers","contributors_url":"https://api.github.com/repos/dgiagio/saltstack-netapi-client-java/contributors","subscribers_url":"https://api.github.com/repos/dgiagio/saltstack-netapi-client-java/subscribers","subscription_url":"https://api.github.com/repos/dgiagio/saltstack-netapi-client-java/subscription","commits_url":"https://api.github.com/repos/dgiagio/saltstack-netapi-client-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/dgiagio/saltstack-netapi-client-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/dgiagio/saltstack-netapi-client-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/dgiagio/saltstack-netapi-client-java/issues/comments/{number}","contents_url":"https://api.github.com/repos/dgiagio/saltstack-netapi-client-java/contents/{+path}","compare_url":"https://api.github.com/repos/dgiagio/saltstack-netapi-client-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dgiagio/saltstack-netapi-client-java/merges","archive_url":"https://api.github.com/repos/dgiagio/saltstack-netapi-client-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dgiagio/saltstack-netapi-client-java/downloads","issues_url":"https://api.github.com/repos/dgiagio/saltstack-netapi-client-java/issues{/number}","pulls_url":"https://api.github.com/repos/dgiagio/saltstack-netapi-client-java/pulls{/number}","milestones_url":"https://api.github.com/repos/dgiagio/saltstack-netapi-client-java/milestones{/number}","notifications_url":"https://api.github.com/repos/dgiagio/saltstack-netapi-client-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dgiagio/saltstack-netapi-client-java/labels{/name}","releases_url":"https://api.github.com/repos/dgiagio/saltstack-netapi-client-java/releases{/id}","created_at":"2015-01-31T18:17:38Z","updated_at":"2015-02-01T15:43:40Z","pushed_at":"2015-02-01T15:43:39Z","git_url":"git://github.com/dgiagio/saltstack-netapi-client-java.git","ssh_url":"git@github.com:dgiagio/saltstack-netapi-client-java.git","clone_url":"https://github.com/dgiagio/saltstack-netapi-client-java.git","svn_url":"https://github.com/dgiagio/saltstack-netapi-client-java","homepage":null,"size":596,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SUSE:master","ref":"master","sha":"ce8cbd69db253573fd3ffaec60ad13ef96e9067f","user":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":25811020,"name":"saltstack-netapi-client-java","full_name":"SUSE/saltstack-netapi-client-java","owner":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SUSE/saltstack-netapi-client-java","description":"Java client to access the SaltStack net-api","fork":false,"url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java","forks_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/forks","keys_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/teams","hooks_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/hooks","issue_events_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/events","assignees_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/tags","blobs_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/languages","stargazers_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/stargazers","contributors_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/contributors","subscribers_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/subscribers","subscription_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/subscription","commits_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/issues/comments/{number}","contents_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/merges","archive_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/downloads","issues_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/releases{/id}","created_at":"2014-10-27T09:06:51Z","updated_at":"2015-01-29T18:19:51Z","pushed_at":"2014-10-29T07:44:40Z","git_url":"git://github.com/SUSE/saltstack-netapi-client-java.git","ssh_url":"git@github.com:SUSE/saltstack-netapi-client-java.git","clone_url":"https://github.com/SUSE/saltstack-netapi-client-java.git","svn_url":"https://github.com/SUSE/saltstack-netapi-client-java","homepage":null,"size":328,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/pulls/1"},"html":{"href":"https://github.com/SUSE/saltstack-netapi-client-java/pull/1"},"issue":{"href":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/issues/1"},"comments":{"href":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/statuses/19555541af47033ef928b2cfc0f2d8cc49ac5e7a"}}}}