{"action":"created","comment":{"url":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/comments/42423625","id":42423625,"diff_hunk":"@@ -36,36 +35,43 @@\n public interface FurnaceData extends DataManipulator<FurnaceData, ImmutableFurnaceData> {\n \n     /**\n-     * Gets the {@link MutableBoundedValue} for the remaining burn time of the\n-     * {@link Furnace}.\n+     * Gets the {@link MutableBoundedValue} for the already passed burn time of the {@link Furnace}.\n+     * When the {@link #passedBurnTime()} is equals the {@link #maxBurnTime()} the current used fuel\n+     * is depleted.\n      *\n-     * @return The value for the remaining burn time\n+     * @return The value for the already passed burn time\n      */\n-    MutableBoundedValue<Integer> remainingBurnTime();\n+    MutableBoundedValue<Integer> passedBurnTime();\n \n     /**\n-     * Gets the {@link MutableBoundedValue} for the remaining cook time of the\n-     * {@link Furnace}.\n+     * Gets the {@link MutableBoundedValue} for the maximum amount of fuel that can be supplied with\n+     * the used fuel item.\n      *\n-     * <p>The {@link #remainingCookTime()} is the difference of {@link #maxCookTime()} and\n-     * the time the item has already been cooked.</p>\n+     * Its represented by the flame icon in the {@link Furnace}, if the flame is 100% filled the\n+     * value is exact this one. So its the maximum of the {@link #passedBurnTime()}.\n      *\n-     * @return The value for the remaining cook time\n+     * @return The value for the maximum amount of fuel that can be supplied with the used fuel item\n      */\n-    MutableBoundedValue<Integer> remainingCookTime();\n+    MutableBoundedValue<Integer> maxBurnTime();\n \n     /**\n-     * Gets the {@link MutableBoundedValue} for the cook time of the\n-     * {@link Item} that should be cooked.\n+     * Gets the {@link MutableBoundedValue} for the already passed cook time of the {@link\n+     * org.spongepowered.api.item.inventory.ItemStack} in the {@link Furnace}. When the {@link\n+     * #passedCookTime()} is equals the {@link #maxCookTime()} the {@link\n+     * org.spongepowered.api.item.inventory.ItemStack} is cooked.\n      *\n-     * <p>This is called \"maxCookTime\" because the client calculates\n-     * {@link #remainingCookTime()} from the \"maxCookTime\" minus the\n-     * time the item cooked already.</p>\n+     * @return The value for the already passed cook time\n+     */\n+    MutableBoundedValue<Integer> passedCookTime();\n+\n+    /**\n+     * Gets the {@link MutableBoundedValue} for the total time the {@link\n+     * org.spongepowered.api.item.inventory.ItemStack} have to cook until it is cooked.\n      *\n-     * <p>This is the maximum of {@link #remainingCookTime()}.</p>\n+     * Its represented by the arrow icon in the {@link Furnace}, if the arrow is 100% filled the\n+     * value is exact this one. So its the maximum of the {@link #passedCookTime()}.","path":"src/main/java/org/spongepowered/api/data/manipulator/mutable/tileentity/FurnaceData.java","position":61,"original_position":62,"commit_id":"b9b6efb7d99a1a2a119b32ca4c1712751d004bda","original_commit_id":"74e9bab6602741c8cce5d5e97e1059a0a67a91d2","user":{"login":"Feeliiix","id":14966472,"avatar_url":"https://avatars.githubusercontent.com/u/14966472?v=3","gravatar_id":"","url":"https://api.github.com/users/Feeliiix","html_url":"https://github.com/Feeliiix","followers_url":"https://api.github.com/users/Feeliiix/followers","following_url":"https://api.github.com/users/Feeliiix/following{/other_user}","gists_url":"https://api.github.com/users/Feeliiix/gists{/gist_id}","starred_url":"https://api.github.com/users/Feeliiix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Feeliiix/subscriptions","organizations_url":"https://api.github.com/users/Feeliiix/orgs","repos_url":"https://api.github.com/users/Feeliiix/repos","events_url":"https://api.github.com/users/Feeliiix/events{/privacy}","received_events_url":"https://api.github.com/users/Feeliiix/received_events","type":"User","site_admin":false},"body":"Thats nice, will update it @Tzky ","created_at":"2015-10-19T20:46:33Z","updated_at":"2015-10-19T20:46:33Z","html_url":"https://github.com/SpongePowered/SpongeAPI/pull/879#discussion_r42423625","pull_request_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/879","_links":{"self":{"href":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/comments/42423625"},"html":{"href":"https://github.com/SpongePowered/SpongeAPI/pull/879#discussion_r42423625"},"pull_request":{"href":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/879"}}},"pull_request":{"url":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/879","id":48080508,"html_url":"https://github.com/SpongePowered/SpongeAPI/pull/879","diff_url":"https://github.com/SpongePowered/SpongeAPI/pull/879.diff","patch_url":"https://github.com/SpongePowered/SpongeAPI/pull/879.patch","issue_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/issues/879","number":879,"state":"open","locked":false,"title":"Updating to the new architecture of FurnaceData","user":{"login":"Feeliiix","id":14966472,"avatar_url":"https://avatars.githubusercontent.com/u/14966472?v=3","gravatar_id":"","url":"https://api.github.com/users/Feeliiix","html_url":"https://github.com/Feeliiix","followers_url":"https://api.github.com/users/Feeliiix/followers","following_url":"https://api.github.com/users/Feeliiix/following{/other_user}","gists_url":"https://api.github.com/users/Feeliiix/gists{/gist_id}","starred_url":"https://api.github.com/users/Feeliiix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Feeliiix/subscriptions","organizations_url":"https://api.github.com/users/Feeliiix/orgs","repos_url":"https://api.github.com/users/Feeliiix/repos","events_url":"https://api.github.com/users/Feeliiix/events{/privacy}","received_events_url":"https://api.github.com/users/Feeliiix/received_events","type":"User","site_admin":false},"body":"# The FurnaceData gets a full upgrade\r\n\r\n## Why?\r\n- The last code was very unstructured, for the same results many different ways was used.\r\n- The values was picked very unthinkingly\r\n\r\n## But why it would be better than the last version?\r\n#### - Now it has an architecture:\r\nall values correspond to the underlaying values:\r\n\r\nUnderlaying Value | Value for Implementation\r\n------------ | -------------\r\nfurnaceBurnTime | passedBurnTime (Thats not the same but it is calculated out of it)\r\ncurrentItemBurnTime | maxBurnTime\r\ncookTime | passedCookTime\r\ntotalCookTime | maxCookTime\r\n#### - Now im checking the structure and the efficiency before any commit","created_at":"2015-10-19T14:42:05Z","updated_at":"2015-10-19T20:46:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6be9f7f051d937eeb5265fd8d34a98337d4fbb0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/879/commits","review_comments_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/879/comments","review_comment_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/issues/879/comments","statuses_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/statuses/b9b6efb7d99a1a2a119b32ca4c1712751d004bda","head":{"label":"Feeliiix:feature/furnace-data","ref":"feature/furnace-data","sha":"b9b6efb7d99a1a2a119b32ca4c1712751d004bda","user":{"login":"Feeliiix","id":14966472,"avatar_url":"https://avatars.githubusercontent.com/u/14966472?v=3","gravatar_id":"","url":"https://api.github.com/users/Feeliiix","html_url":"https://github.com/Feeliiix","followers_url":"https://api.github.com/users/Feeliiix/followers","following_url":"https://api.github.com/users/Feeliiix/following{/other_user}","gists_url":"https://api.github.com/users/Feeliiix/gists{/gist_id}","starred_url":"https://api.github.com/users/Feeliiix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Feeliiix/subscriptions","organizations_url":"https://api.github.com/users/Feeliiix/orgs","repos_url":"https://api.github.com/users/Feeliiix/repos","events_url":"https://api.github.com/users/Feeliiix/events{/privacy}","received_events_url":"https://api.github.com/users/Feeliiix/received_events","type":"User","site_admin":false},"repo":{"id":44528030,"name":"SpongeAPI","full_name":"Feeliiix/SpongeAPI","owner":{"login":"Feeliiix","id":14966472,"avatar_url":"https://avatars.githubusercontent.com/u/14966472?v=3","gravatar_id":"","url":"https://api.github.com/users/Feeliiix","html_url":"https://github.com/Feeliiix","followers_url":"https://api.github.com/users/Feeliiix/followers","following_url":"https://api.github.com/users/Feeliiix/following{/other_user}","gists_url":"https://api.github.com/users/Feeliiix/gists{/gist_id}","starred_url":"https://api.github.com/users/Feeliiix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Feeliiix/subscriptions","organizations_url":"https://api.github.com/users/Feeliiix/orgs","repos_url":"https://api.github.com/users/Feeliiix/repos","events_url":"https://api.github.com/users/Feeliiix/events{/privacy}","received_events_url":"https://api.github.com/users/Feeliiix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Feeliiix/SpongeAPI","description":"A Minecraft plugin API","fork":true,"url":"https://api.github.com/repos/Feeliiix/SpongeAPI","forks_url":"https://api.github.com/repos/Feeliiix/SpongeAPI/forks","keys_url":"https://api.github.com/repos/Feeliiix/SpongeAPI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Feeliiix/SpongeAPI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Feeliiix/SpongeAPI/teams","hooks_url":"https://api.github.com/repos/Feeliiix/SpongeAPI/hooks","issue_events_url":"https://api.github.com/repos/Feeliiix/SpongeAPI/issues/events{/number}","events_url":"https://api.github.com/repos/Feeliiix/SpongeAPI/events","assignees_url":"https://api.github.com/repos/Feeliiix/SpongeAPI/assignees{/user}","branches_url":"https://api.github.com/repos/Feeliiix/SpongeAPI/branches{/branch}","tags_url":"https://api.github.com/repos/Feeliiix/SpongeAPI/tags","blobs_url":"https://api.github.com/repos/Feeliiix/SpongeAPI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Feeliiix/SpongeAPI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Feeliiix/SpongeAPI/git/refs{/sha}","trees_url":"https://api.github.com/repos/Feeliiix/SpongeAPI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Feeliiix/SpongeAPI/statuses/{sha}","languages_url":"https://api.github.com/repos/Feeliiix/SpongeAPI/languages","stargazers_url":"https://api.github.com/repos/Feeliiix/SpongeAPI/stargazers","contributors_url":"https://api.github.com/repos/Feeliiix/SpongeAPI/contributors","subscribers_url":"https://api.github.com/repos/Feeliiix/SpongeAPI/subscribers","subscription_url":"https://api.github.com/repos/Feeliiix/SpongeAPI/subscription","commits_url":"https://api.github.com/repos/Feeliiix/SpongeAPI/commits{/sha}","git_commits_url":"https://api.github.com/repos/Feeliiix/SpongeAPI/git/commits{/sha}","comments_url":"https://api.github.com/repos/Feeliiix/SpongeAPI/comments{/number}","issue_comment_url":"https://api.github.com/repos/Feeliiix/SpongeAPI/issues/comments{/number}","contents_url":"https://api.github.com/repos/Feeliiix/SpongeAPI/contents/{+path}","compare_url":"https://api.github.com/repos/Feeliiix/SpongeAPI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Feeliiix/SpongeAPI/merges","archive_url":"https://api.github.com/repos/Feeliiix/SpongeAPI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Feeliiix/SpongeAPI/downloads","issues_url":"https://api.github.com/repos/Feeliiix/SpongeAPI/issues{/number}","pulls_url":"https://api.github.com/repos/Feeliiix/SpongeAPI/pulls{/number}","milestones_url":"https://api.github.com/repos/Feeliiix/SpongeAPI/milestones{/number}","notifications_url":"https://api.github.com/repos/Feeliiix/SpongeAPI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Feeliiix/SpongeAPI/labels{/name}","releases_url":"https://api.github.com/repos/Feeliiix/SpongeAPI/releases{/id}","created_at":"2015-10-19T10:42:38Z","updated_at":"2015-10-19T10:42:43Z","pushed_at":"2015-10-19T20:37:42Z","git_url":"git://github.com/Feeliiix/SpongeAPI.git","ssh_url":"git@github.com:Feeliiix/SpongeAPI.git","clone_url":"https://github.com/Feeliiix/SpongeAPI.git","svn_url":"https://github.com/Feeliiix/SpongeAPI","homepage":"http://www.spongepowered.org/","size":28374,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SpongePowered:master","ref":"master","sha":"7cd78e3439e7bfed34f2ed94d13ab6a3bca901c7","user":{"login":"SpongePowered","id":8683473,"avatar_url":"https://avatars.githubusercontent.com/u/8683473?v=3","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"repo":{"id":23770421,"name":"SpongeAPI","full_name":"SpongePowered/SpongeAPI","owner":{"login":"SpongePowered","id":8683473,"avatar_url":"https://avatars.githubusercontent.com/u/8683473?v=3","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpongePowered/SpongeAPI","description":"A Minecraft plugin API","fork":false,"url":"https://api.github.com/repos/SpongePowered/SpongeAPI","forks_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/forks","keys_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/teams","hooks_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/hooks","issue_events_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/issues/events{/number}","events_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/events","assignees_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/assignees{/user}","branches_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/branches{/branch}","tags_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/tags","blobs_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/statuses/{sha}","languages_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/languages","stargazers_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/stargazers","contributors_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/contributors","subscribers_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/subscribers","subscription_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/subscription","commits_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/contents/{+path}","compare_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/merges","archive_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/downloads","issues_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/issues{/number}","pulls_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls{/number}","milestones_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/milestones{/number}","notifications_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/labels{/name}","releases_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/releases{/id}","created_at":"2014-09-07T20:39:25Z","updated_at":"2015-10-18T21:41:55Z","pushed_at":"2015-10-19T20:37:43Z","git_url":"git://github.com/SpongePowered/SpongeAPI.git","ssh_url":"git@github.com:SpongePowered/SpongeAPI.git","clone_url":"https://github.com/SpongePowered/SpongeAPI.git","svn_url":"https://github.com/SpongePowered/SpongeAPI","homepage":"http://www.spongepowered.org/","size":28374,"stargazers_count":806,"watchers_count":806,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":349,"mirror_url":null,"open_issues_count":97,"forks":349,"open_issues":97,"watchers":806,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/879"},"html":{"href":"https://github.com/SpongePowered/SpongeAPI/pull/879"},"issue":{"href":"https://api.github.com/repos/SpongePowered/SpongeAPI/issues/879"},"comments":{"href":"https://api.github.com/repos/SpongePowered/SpongeAPI/issues/879/comments"},"review_comments":{"href":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/879/comments"},"review_comment":{"href":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/879/commits"},"statuses":{"href":"https://api.github.com/repos/SpongePowered/SpongeAPI/statuses/b9b6efb7d99a1a2a119b32ca4c1712751d004bda"}}}}