{"comment":{"url":"https://api.github.com/repos/ComputationalProteomicsUnit/Pbase/comments/9965427","html_url":"https://github.com/ComputationalProteomicsUnit/Pbase/commit/ba06a5166efdbaf7f5e165c98f97049945787430#commitcomment-9965427","id":9965427,"user":{"login":"sgibb","id":1828443,"avatar_url":"https://avatars.githubusercontent.com/u/1828443?v=3","gravatar_id":"","url":"https://api.github.com/users/sgibb","html_url":"https://github.com/sgibb","followers_url":"https://api.github.com/users/sgibb/followers","following_url":"https://api.github.com/users/sgibb/following{/other_user}","gists_url":"https://api.github.com/users/sgibb/gists{/gist_id}","starred_url":"https://api.github.com/users/sgibb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgibb/subscriptions","organizations_url":"https://api.github.com/users/sgibb/orgs","repos_url":"https://api.github.com/users/sgibb/repos","events_url":"https://api.github.com/users/sgibb/events{/privacy}","received_events_url":"https://api.github.com/users/sgibb/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"ba06a5166efdbaf7f5e165c98f97049945787430","created_at":"2015-02-27T21:40:42Z","updated_at":"2015-02-27T21:40:42Z","body":"This commit reminds me that I read the new `makeGroups` function and wonder if it fits for all possible inputs. Is that a valid input? `j <- c(FALSE, TRUE, TRUE, TRUE, FALSE, FALSE, TRUE, TRUE, TRUE)`\r\nIf yes the following groups are not valid anymore:\r\n```r\r\nPbase:::makeGroups(j)\r\n# [1] 1 2 2 3 4 5 5 6 6\r\n# shouldn't it be\r\n# [1] 1 2 2 2 3 4 5 5 5\r\n```"}}