{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/16644","labels_url":"https://api.github.com/repos/docker/docker/issues/16644/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/16644/comments","events_url":"https://api.github.com/repos/docker/docker/issues/16644/events","html_url":"https://github.com/docker/docker/pull/16644","id":108792419,"number":16644,"title":"Add TLS support for discovery backend","user":{"login":"dhiltgen","id":4033016,"avatar_url":"https://avatars.githubusercontent.com/u/4033016?v=3","gravatar_id":"","url":"https://api.github.com/users/dhiltgen","html_url":"https://github.com/dhiltgen","followers_url":"https://api.github.com/users/dhiltgen/followers","following_url":"https://api.github.com/users/dhiltgen/following{/other_user}","gists_url":"https://api.github.com/users/dhiltgen/gists{/gist_id}","starred_url":"https://api.github.com/users/dhiltgen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhiltgen/subscriptions","organizations_url":"https://api.github.com/users/dhiltgen/orgs","repos_url":"https://api.github.com/users/dhiltgen/repos","events_url":"https://api.github.com/users/dhiltgen/events{/privacy}","received_events_url":"https://api.github.com/users/dhiltgen/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/status/2-code-review","name":"status/2-code-review","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":29,"created_at":"2015-09-29T04:29:59Z","updated_at":"2015-10-07T23:42:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/16644","html_url":"https://github.com/docker/docker/pull/16644","diff_url":"https://github.com/docker/docker/pull/16644.diff","patch_url":"https://github.com/docker/docker/pull/16644.patch"},"body":"This leverages recent additions to libkv enabling client\r\nauthentication via TLS so the discovery back-end can be locked\r\ndown with mutual TLS.  Example usage:\r\n\r\n    docker daemon [other args] \\\r\n        --cluster-advertise 192.168.122.168:2376 \\\r\n        --cluster-store etcd://192.168.122.168:2379 \\\r\n        --cluster-store-opt kv.cacertfile=/path/to/ca.pem \\\r\n        --cluster-store-opt kv.certfile=/path/to/cert.pem \\\r\n        --cluster-store-opt kv.keyfile=/path/to/key.pem\r\n\r\nSigned-off-by: Daniel Hiltgen <daniel.hiltgen@docker.com>"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/146368196","html_url":"https://github.com/docker/docker/pull/16644#issuecomment-146368196","issue_url":"https://api.github.com/repos/docker/docker/issues/16644","id":146368196,"user":{"login":"abronan","id":1655859,"avatar_url":"https://avatars.githubusercontent.com/u/1655859?v=3","gravatar_id":"","url":"https://api.github.com/users/abronan","html_url":"https://github.com/abronan","followers_url":"https://api.github.com/users/abronan/followers","following_url":"https://api.github.com/users/abronan/following{/other_user}","gists_url":"https://api.github.com/users/abronan/gists{/gist_id}","starred_url":"https://api.github.com/users/abronan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abronan/subscriptions","organizations_url":"https://api.github.com/users/abronan/orgs","repos_url":"https://api.github.com/users/abronan/repos","events_url":"https://api.github.com/users/abronan/events{/privacy}","received_events_url":"https://api.github.com/users/abronan/received_events","type":"User","site_admin":false},"created_at":"2015-10-07T23:42:51Z","updated_at":"2015-10-07T23:42:51Z","body":"Imho we should still get this in because there may be security and/or stability implications (`go-etcd` clearly lists the fact that it's not thread-safe as a caveat) with keeping the old deprecated client :confused:\r\n\r\nHaving to vendor this is clearly ridiculous but the next `etcd` APIv3 will use `protobuf` instead and we already vendor it so this is going to get rid of this huge dependency.."}}