{"comment":{"url":"https://api.github.com/repos/jsanch2s/at_work_central_factory_hub/comments/13821356","html_url":"https://github.com/jsanch2s/at_work_central_factory_hub/commit/48c82e68cff6d779a5a1e4cba24a914adbffc57b#commitcomment-13821356","id":13821356,"user":{"login":"svenschneider","id":568789,"avatar_url":"https://avatars.githubusercontent.com/u/568789?v=3","gravatar_id":"","url":"https://api.github.com/users/svenschneider","html_url":"https://github.com/svenschneider","followers_url":"https://api.github.com/users/svenschneider/followers","following_url":"https://api.github.com/users/svenschneider/following{/other_user}","gists_url":"https://api.github.com/users/svenschneider/gists{/gist_id}","starred_url":"https://api.github.com/users/svenschneider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svenschneider/subscriptions","organizations_url":"https://api.github.com/users/svenschneider/orgs","repos_url":"https://api.github.com/users/svenschneider/repos","events_url":"https://api.github.com/users/svenschneider/events{/privacy}","received_events_url":"https://api.github.com/users/svenschneider/received_events","type":"User","site_admin":false},"position":232,"line":232,"path":"src/libs/protobuf_comm/client.py","commit_id":"48c82e68cff6d779a5a1e4cba24a914adbffc57b","created_at":"2015-10-16T16:39:12Z","updated_at":"2015-10-16T16:39:12Z","body":"If the read function really does what it is supposed to do (i.e. read exactly the amount of bytes that you specify as argument), then it should not be necessary to extract parts of your buffer (also above and below)?!\r\n\r\nI think, we should discuss if we want to have blocking sockets (in threads) or non-blocking sockets (not in threads), because you seemingly try to mix both approaches here (or in the read function)."}}