{"action":"created","issue":{"url":"https://api.github.com/repos/scisoft/autocmake/issues/49","labels_url":"https://api.github.com/repos/scisoft/autocmake/issues/49/labels{/name}","comments_url":"https://api.github.com/repos/scisoft/autocmake/issues/49/comments","events_url":"https://api.github.com/repos/scisoft/autocmake/issues/49/events","html_url":"https://github.com/scisoft/autocmake/pull/49","id":98605478,"number":49,"title":"added new test, combining lapack and blas routines","user":{"login":"miroi","id":1047336,"avatar_url":"https://avatars.githubusercontent.com/u/1047336?v=3","gravatar_id":"","url":"https://api.github.com/users/miroi","html_url":"https://github.com/miroi","followers_url":"https://api.github.com/users/miroi/followers","following_url":"https://api.github.com/users/miroi/following{/other_user}","gists_url":"https://api.github.com/users/miroi/gists{/gist_id}","starred_url":"https://api.github.com/users/miroi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miroi/subscriptions","organizations_url":"https://api.github.com/users/miroi/orgs","repos_url":"https://api.github.com/users/miroi/repos","events_url":"https://api.github.com/users/miroi/events{/privacy}","received_events_url":"https://api.github.com/users/miroi/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-08-02T12:08:01Z","updated_at":"2015-08-02T13:43:59Z","closed_at":"2015-08-02T13:43:59Z","pull_request":{"url":"https://api.github.com/repos/scisoft/autocmake/pulls/49","html_url":"https://github.com/scisoft/autocmake/pull/49","diff_url":"https://github.com/scisoft/autocmake/pull/49.diff","patch_url":"https://github.com/scisoft/autocmake/pull/49.patch"},"body":"New test, named as fc_lapack. Tests dgesv-dgemv-dnrm2 routines of lapack and blas."},"comment":{"url":"https://api.github.com/repos/scisoft/autocmake/issues/comments/127025222","html_url":"https://github.com/scisoft/autocmake/pull/49#issuecomment-127025222","issue_url":"https://api.github.com/repos/scisoft/autocmake/issues/49","id":127025222,"user":{"login":"bast","id":5120679,"avatar_url":"https://avatars.githubusercontent.com/u/5120679?v=3","gravatar_id":"","url":"https://api.github.com/users/bast","html_url":"https://github.com/bast","followers_url":"https://api.github.com/users/bast/followers","following_url":"https://api.github.com/users/bast/following{/other_user}","gists_url":"https://api.github.com/users/bast/gists{/gist_id}","starred_url":"https://api.github.com/users/bast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bast/subscriptions","organizations_url":"https://api.github.com/users/bast/orgs","repos_url":"https://api.github.com/users/bast/repos","events_url":"https://api.github.com/users/bast/events{/privacy}","received_events_url":"https://api.github.com/users/bast/received_events","type":"User","site_admin":false},"created_at":"2015-08-02T13:43:59Z","updated_at":"2015-08-02T13:43:59Z","body":"I am closing this PR for the moment.\r\nFew advices:\r\n- Don't submit PR which break tests (unless they reveal bugs in previous testing).\r\n- Don't submit several things in one PR (here for instance I am not sure that the -rdynamic stuff has to be here; the CMake modules have to work everywhere but the tests don't have to; I don't mind so much if the tests fail with PGI if I know that math works with PGI; in any case the -rdynamic is a separate issue). If you solve several issues with one PR you risk that the PR cannot be accepted because feature 1 needs more review although feature 2 is perhaps fine.\r\n- Don't submit patches over several commits. Commits have to be cherry-pickable.\r\n- Don't submit PR immediately. Let the code ripe on your fork for few days and see how it behaves. Sleep over it. Submit it later."}}