{"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/ember-collection/pulls/comments/37324286","id":37324286,"diff_hunk":"@@ -27,59 +25,56 @@ function formatStyle(pos, width, height) {\n export default Ember.Component.extend({\n   layout: layout,\n \n-  // Utility to get attribute value which may or may not be wrapped in mut helper.\n-  // returns defaultValue if attribute not defined or defined as null or undefined\n-  _maybeMutAttr(key, defaultValue) {\n-    if (this.attrs == null) { return defaultValue; }\n-    var obj = this.attrs[key];\n-    if (obj == null) { return defaultValue; }\n-    obj = getMutValue(obj);\n-    obj = (obj == null) ? defaultValue : obj;\n-    return obj;\n-  },\n   init() {\n-    this._super();\n+    // State pulled from attrs is prefixed with an underscore\n+    // so that there's no chance of shadowing the attrs proxy.\n+    this._buffer = undefined;\n+    this._cellLayout = undefined;\n+    this._items = undefined;\n+    this._offsetX = undefined;\n+    this._offsetY = undefined;\n+    this._width = undefined;\n+    this._height = undefined;\n+    \n     // this.firstCell = undefined;\n     // this.lastCell = undefined;\n     // this.cellCount = undefined;\n-    this.offsetX = 0;\n-    this.offsetY = 0;\n-    this.width = 0;\n-    this.height = 0;\n     this.contentElement = undefined;\n-    Ember.set(this, 'cells', Ember.A([]));\n-    this.cellMap = Object.create(null);\n+    this._cells = [];\n+    this._cellMap = Object.create(null);\n+\n+    this._super();","path":"addon/components/ember-collection.js","position":48,"original_position":48,"commit_id":"6cd9b8365066935e7a836151676c20beb9032ebf","original_commit_id":"6cd9b8365066935e7a836151676c20beb9032ebf","user":{"login":"stefanpenner","id":1377,"avatar_url":"https://avatars.githubusercontent.com/u/1377?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanpenner","html_url":"https://github.com/stefanpenner","followers_url":"https://api.github.com/users/stefanpenner/followers","following_url":"https://api.github.com/users/stefanpenner/following{/other_user}","gists_url":"https://api.github.com/users/stefanpenner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanpenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanpenner/subscriptions","organizations_url":"https://api.github.com/users/stefanpenner/orgs","repos_url":"https://api.github.com/users/stefanpenner/repos","events_url":"https://api.github.com/users/stefanpenner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanpenner/received_events","type":"User","site_admin":false},"body":"super before touching `this`","created_at":"2015-08-18T17:03:20Z","updated_at":"2015-08-18T17:03:20Z","html_url":"https://github.com/emberjs/ember-collection/pull/9#discussion_r37324286","pull_request_url":"https://api.github.com/repos/emberjs/ember-collection/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember-collection/pulls/comments/37324286"},"html":{"href":"https://github.com/emberjs/ember-collection/pull/9#discussion_r37324286"},"pull_request":{"href":"https://api.github.com/repos/emberjs/ember-collection/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/emberjs/ember-collection/pulls/9","id":42653729,"html_url":"https://github.com/emberjs/ember-collection/pull/9","diff_url":"https://github.com/emberjs/ember-collection/pull/9.diff","patch_url":"https://github.com/emberjs/ember-collection/pull/9.patch","issue_url":"https://api.github.com/repos/emberjs/ember-collection/issues/9","number":9,"state":"open","locked":false,"title":"Cleanup","user":{"login":"mmun","id":1151810,"avatar_url":"https://avatars.githubusercontent.com/u/1151810?v=3","gravatar_id":"","url":"https://api.github.com/users/mmun","html_url":"https://github.com/mmun","followers_url":"https://api.github.com/users/mmun/followers","following_url":"https://api.github.com/users/mmun/following{/other_user}","gists_url":"https://api.github.com/users/mmun/gists{/gist_id}","starred_url":"https://api.github.com/users/mmun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmun/subscriptions","organizations_url":"https://api.github.com/users/mmun/orgs","repos_url":"https://api.github.com/users/mmun/repos","events_url":"https://api.github.com/users/mmun/events{/privacy}","received_events_url":"https://api.github.com/users/mmun/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-08-18T01:47:58Z","updated_at":"2015-08-18T17:03:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"33e0274dd3a29b512b7007c74902741c65815347","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/ember-collection/pulls/9/commits","review_comments_url":"https://api.github.com/repos/emberjs/ember-collection/pulls/9/comments","review_comment_url":"https://api.github.com/repos/emberjs/ember-collection/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/ember-collection/issues/9/comments","statuses_url":"https://api.github.com/repos/emberjs/ember-collection/statuses/6cd9b8365066935e7a836151676c20beb9032ebf","head":{"label":"emberjs:hax","ref":"hax","sha":"6cd9b8365066935e7a836151676c20beb9032ebf","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":40514294,"name":"ember-collection","full_name":"emberjs/ember-collection","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/ember-collection","description":"","fork":false,"url":"https://api.github.com/repos/emberjs/ember-collection","forks_url":"https://api.github.com/repos/emberjs/ember-collection/forks","keys_url":"https://api.github.com/repos/emberjs/ember-collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/ember-collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/ember-collection/teams","hooks_url":"https://api.github.com/repos/emberjs/ember-collection/hooks","issue_events_url":"https://api.github.com/repos/emberjs/ember-collection/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/ember-collection/events","assignees_url":"https://api.github.com/repos/emberjs/ember-collection/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/ember-collection/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/ember-collection/tags","blobs_url":"https://api.github.com/repos/emberjs/ember-collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/ember-collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/ember-collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/ember-collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/ember-collection/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/ember-collection/languages","stargazers_url":"https://api.github.com/repos/emberjs/ember-collection/stargazers","contributors_url":"https://api.github.com/repos/emberjs/ember-collection/contributors","subscribers_url":"https://api.github.com/repos/emberjs/ember-collection/subscribers","subscription_url":"https://api.github.com/repos/emberjs/ember-collection/subscription","commits_url":"https://api.github.com/repos/emberjs/ember-collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/ember-collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/ember-collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/ember-collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/ember-collection/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/ember-collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/ember-collection/merges","archive_url":"https://api.github.com/repos/emberjs/ember-collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/ember-collection/downloads","issues_url":"https://api.github.com/repos/emberjs/ember-collection/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/ember-collection/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/ember-collection/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/ember-collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/ember-collection/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/ember-collection/releases{/id}","created_at":"2015-08-11T01:19:12Z","updated_at":"2015-08-18T11:18:51Z","pushed_at":"2015-08-18T12:32:03Z","git_url":"git://github.com/emberjs/ember-collection.git","ssh_url":"git@github.com:emberjs/ember-collection.git","clone_url":"https://github.com/emberjs/ember-collection.git","svn_url":"https://github.com/emberjs/ember-collection","homepage":null,"size":2944,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":10,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"4b17df2984ffd717522be621ec9bc12320c2b4d9","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":40514294,"name":"ember-collection","full_name":"emberjs/ember-collection","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/ember-collection","description":"","fork":false,"url":"https://api.github.com/repos/emberjs/ember-collection","forks_url":"https://api.github.com/repos/emberjs/ember-collection/forks","keys_url":"https://api.github.com/repos/emberjs/ember-collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/ember-collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/ember-collection/teams","hooks_url":"https://api.github.com/repos/emberjs/ember-collection/hooks","issue_events_url":"https://api.github.com/repos/emberjs/ember-collection/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/ember-collection/events","assignees_url":"https://api.github.com/repos/emberjs/ember-collection/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/ember-collection/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/ember-collection/tags","blobs_url":"https://api.github.com/repos/emberjs/ember-collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/ember-collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/ember-collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/ember-collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/ember-collection/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/ember-collection/languages","stargazers_url":"https://api.github.com/repos/emberjs/ember-collection/stargazers","contributors_url":"https://api.github.com/repos/emberjs/ember-collection/contributors","subscribers_url":"https://api.github.com/repos/emberjs/ember-collection/subscribers","subscription_url":"https://api.github.com/repos/emberjs/ember-collection/subscription","commits_url":"https://api.github.com/repos/emberjs/ember-collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/ember-collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/ember-collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/ember-collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/ember-collection/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/ember-collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/ember-collection/merges","archive_url":"https://api.github.com/repos/emberjs/ember-collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/ember-collection/downloads","issues_url":"https://api.github.com/repos/emberjs/ember-collection/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/ember-collection/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/ember-collection/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/ember-collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/ember-collection/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/ember-collection/releases{/id}","created_at":"2015-08-11T01:19:12Z","updated_at":"2015-08-18T11:18:51Z","pushed_at":"2015-08-18T12:32:03Z","git_url":"git://github.com/emberjs/ember-collection.git","ssh_url":"git@github.com:emberjs/ember-collection.git","clone_url":"https://github.com/emberjs/ember-collection.git","svn_url":"https://github.com/emberjs/ember-collection","homepage":null,"size":2944,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember-collection/pulls/9"},"html":{"href":"https://github.com/emberjs/ember-collection/pull/9"},"issue":{"href":"https://api.github.com/repos/emberjs/ember-collection/issues/9"},"comments":{"href":"https://api.github.com/repos/emberjs/ember-collection/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/ember-collection/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/ember-collection/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/ember-collection/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/ember-collection/statuses/6cd9b8365066935e7a836151676c20beb9032ebf"}}}}