{"action":"closed","number":122,"pull_request":{"url":"https://api.github.com/repos/openstax/accounts/pulls/122","id":28513946,"html_url":"https://github.com/openstax/accounts/pull/122","diff_url":"https://github.com/openstax/accounts/pull/122.diff","patch_url":"https://github.com/openstax/accounts/pull/122.patch","issue_url":"https://api.github.com/repos/openstax/accounts/issues/122","number":122,"state":"closed","locked":false,"title":"Finish fixing double authentication bug; Fixes admin user search bug","user":{"login":"Dantemss","id":1017808,"avatar_url":"https://avatars.githubusercontent.com/u/1017808?v=3","gravatar_id":"","url":"https://api.github.com/users/Dantemss","html_url":"https://github.com/Dantemss","followers_url":"https://api.github.com/users/Dantemss/followers","following_url":"https://api.github.com/users/Dantemss/following{/other_user}","gists_url":"https://api.github.com/users/Dantemss/gists{/gist_id}","starred_url":"https://api.github.com/users/Dantemss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dantemss/subscriptions","organizations_url":"https://api.github.com/users/Dantemss/orgs","repos_url":"https://api.github.com/users/Dantemss/repos","events_url":"https://api.github.com/users/Dantemss/events{/privacy}","received_events_url":"https://api.github.com/users/Dantemss/received_events","type":"User","site_admin":false},"body":"Turns out my first fix was incomplete. The routine still tries to add a duplicate email for Ross and errors out.\r\n\r\nAlso fixed undefined method call when trying to do admin user search.\r\n\r\nImproved the test that was supposed to cover Ross's case (apparently it didn't actually work)\r\n\r\n@edwoodward @reedstrm Maybe Karen could review this since JP is gone? Should be quick, it's pretty small. If not, we could ask LN.\r\n\r\nBtw the reason only Ross found this bug is that he's the only one that has the same email on FB and google (and attempted to login with both)","created_at":"2015-02-02T23:47:40Z","updated_at":"2015-02-17T22:41:39Z","closed_at":"2015-02-17T22:41:39Z","merged_at":"2015-02-17T22:41:39Z","merge_commit_sha":"fb7beb940df288d8d2c84f51eb335d0dde5e572f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openstax/accounts/pulls/122/commits","review_comments_url":"https://api.github.com/repos/openstax/accounts/pulls/122/comments","review_comment_url":"https://api.github.com/repos/openstax/accounts/pulls/comments/{number}","comments_url":"https://api.github.com/repos/openstax/accounts/issues/122/comments","statuses_url":"https://api.github.com/repos/openstax/accounts/statuses/b414fe1763da5553cf0ced26f3b22eb9e7f1b58c","head":{"label":"Dantemss:master","ref":"master","sha":"b414fe1763da5553cf0ced26f3b22eb9e7f1b58c","user":{"login":"Dantemss","id":1017808,"avatar_url":"https://avatars.githubusercontent.com/u/1017808?v=3","gravatar_id":"","url":"https://api.github.com/users/Dantemss","html_url":"https://github.com/Dantemss","followers_url":"https://api.github.com/users/Dantemss/followers","following_url":"https://api.github.com/users/Dantemss/following{/other_user}","gists_url":"https://api.github.com/users/Dantemss/gists{/gist_id}","starred_url":"https://api.github.com/users/Dantemss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dantemss/subscriptions","organizations_url":"https://api.github.com/users/Dantemss/orgs","repos_url":"https://api.github.com/users/Dantemss/repos","events_url":"https://api.github.com/users/Dantemss/events{/privacy}","received_events_url":"https://api.github.com/users/Dantemss/received_events","type":"User","site_admin":false},"repo":{"id":17497595,"name":"accounts","full_name":"Dantemss/accounts","owner":{"login":"Dantemss","id":1017808,"avatar_url":"https://avatars.githubusercontent.com/u/1017808?v=3","gravatar_id":"","url":"https://api.github.com/users/Dantemss","html_url":"https://github.com/Dantemss","followers_url":"https://api.github.com/users/Dantemss/followers","following_url":"https://api.github.com/users/Dantemss/following{/other_user}","gists_url":"https://api.github.com/users/Dantemss/gists{/gist_id}","starred_url":"https://api.github.com/users/Dantemss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dantemss/subscriptions","organizations_url":"https://api.github.com/users/Dantemss/orgs","repos_url":"https://api.github.com/users/Dantemss/repos","events_url":"https://api.github.com/users/Dantemss/events{/privacy}","received_events_url":"https://api.github.com/users/Dantemss/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Dantemss/accounts","description":"OpenStax common services API server","fork":true,"url":"https://api.github.com/repos/Dantemss/accounts","forks_url":"https://api.github.com/repos/Dantemss/accounts/forks","keys_url":"https://api.github.com/repos/Dantemss/accounts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dantemss/accounts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dantemss/accounts/teams","hooks_url":"https://api.github.com/repos/Dantemss/accounts/hooks","issue_events_url":"https://api.github.com/repos/Dantemss/accounts/issues/events{/number}","events_url":"https://api.github.com/repos/Dantemss/accounts/events","assignees_url":"https://api.github.com/repos/Dantemss/accounts/assignees{/user}","branches_url":"https://api.github.com/repos/Dantemss/accounts/branches{/branch}","tags_url":"https://api.github.com/repos/Dantemss/accounts/tags","blobs_url":"https://api.github.com/repos/Dantemss/accounts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dantemss/accounts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dantemss/accounts/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dantemss/accounts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dantemss/accounts/statuses/{sha}","languages_url":"https://api.github.com/repos/Dantemss/accounts/languages","stargazers_url":"https://api.github.com/repos/Dantemss/accounts/stargazers","contributors_url":"https://api.github.com/repos/Dantemss/accounts/contributors","subscribers_url":"https://api.github.com/repos/Dantemss/accounts/subscribers","subscription_url":"https://api.github.com/repos/Dantemss/accounts/subscription","commits_url":"https://api.github.com/repos/Dantemss/accounts/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dantemss/accounts/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dantemss/accounts/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dantemss/accounts/issues/comments/{number}","contents_url":"https://api.github.com/repos/Dantemss/accounts/contents/{+path}","compare_url":"https://api.github.com/repos/Dantemss/accounts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dantemss/accounts/merges","archive_url":"https://api.github.com/repos/Dantemss/accounts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dantemss/accounts/downloads","issues_url":"https://api.github.com/repos/Dantemss/accounts/issues{/number}","pulls_url":"https://api.github.com/repos/Dantemss/accounts/pulls{/number}","milestones_url":"https://api.github.com/repos/Dantemss/accounts/milestones{/number}","notifications_url":"https://api.github.com/repos/Dantemss/accounts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dantemss/accounts/labels{/name}","releases_url":"https://api.github.com/repos/Dantemss/accounts/releases{/id}","created_at":"2014-03-07T00:26:31Z","updated_at":"2015-02-02T23:43:30Z","pushed_at":"2015-02-02T23:43:30Z","git_url":"git://github.com/Dantemss/accounts.git","ssh_url":"git@github.com:Dantemss/accounts.git","clone_url":"https://github.com/Dantemss/accounts.git","svn_url":"https://github.com/Dantemss/accounts","homepage":null,"size":1650,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openstax:master","ref":"master","sha":"cca5066fa17fe59f551a5b06d9cab1a911448665","user":{"login":"openstax","id":3805549,"avatar_url":"https://avatars.githubusercontent.com/u/3805549?v=3","gravatar_id":"","url":"https://api.github.com/users/openstax","html_url":"https://github.com/openstax","followers_url":"https://api.github.com/users/openstax/followers","following_url":"https://api.github.com/users/openstax/following{/other_user}","gists_url":"https://api.github.com/users/openstax/gists{/gist_id}","starred_url":"https://api.github.com/users/openstax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openstax/subscriptions","organizations_url":"https://api.github.com/users/openstax/orgs","repos_url":"https://api.github.com/users/openstax/repos","events_url":"https://api.github.com/users/openstax/events{/privacy}","received_events_url":"https://api.github.com/users/openstax/received_events","type":"Organization","site_admin":false},"repo":{"id":11300066,"name":"accounts","full_name":"openstax/accounts","owner":{"login":"openstax","id":3805549,"avatar_url":"https://avatars.githubusercontent.com/u/3805549?v=3","gravatar_id":"","url":"https://api.github.com/users/openstax","html_url":"https://github.com/openstax","followers_url":"https://api.github.com/users/openstax/followers","following_url":"https://api.github.com/users/openstax/following{/other_user}","gists_url":"https://api.github.com/users/openstax/gists{/gist_id}","starred_url":"https://api.github.com/users/openstax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openstax/subscriptions","organizations_url":"https://api.github.com/users/openstax/orgs","repos_url":"https://api.github.com/users/openstax/repos","events_url":"https://api.github.com/users/openstax/events{/privacy}","received_events_url":"https://api.github.com/users/openstax/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openstax/accounts","description":"OpenStax centralized authentication and accounts service","fork":false,"url":"https://api.github.com/repos/openstax/accounts","forks_url":"https://api.github.com/repos/openstax/accounts/forks","keys_url":"https://api.github.com/repos/openstax/accounts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openstax/accounts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openstax/accounts/teams","hooks_url":"https://api.github.com/repos/openstax/accounts/hooks","issue_events_url":"https://api.github.com/repos/openstax/accounts/issues/events{/number}","events_url":"https://api.github.com/repos/openstax/accounts/events","assignees_url":"https://api.github.com/repos/openstax/accounts/assignees{/user}","branches_url":"https://api.github.com/repos/openstax/accounts/branches{/branch}","tags_url":"https://api.github.com/repos/openstax/accounts/tags","blobs_url":"https://api.github.com/repos/openstax/accounts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openstax/accounts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openstax/accounts/git/refs{/sha}","trees_url":"https://api.github.com/repos/openstax/accounts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openstax/accounts/statuses/{sha}","languages_url":"https://api.github.com/repos/openstax/accounts/languages","stargazers_url":"https://api.github.com/repos/openstax/accounts/stargazers","contributors_url":"https://api.github.com/repos/openstax/accounts/contributors","subscribers_url":"https://api.github.com/repos/openstax/accounts/subscribers","subscription_url":"https://api.github.com/repos/openstax/accounts/subscription","commits_url":"https://api.github.com/repos/openstax/accounts/commits{/sha}","git_commits_url":"https://api.github.com/repos/openstax/accounts/git/commits{/sha}","comments_url":"https://api.github.com/repos/openstax/accounts/comments{/number}","issue_comment_url":"https://api.github.com/repos/openstax/accounts/issues/comments/{number}","contents_url":"https://api.github.com/repos/openstax/accounts/contents/{+path}","compare_url":"https://api.github.com/repos/openstax/accounts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openstax/accounts/merges","archive_url":"https://api.github.com/repos/openstax/accounts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openstax/accounts/downloads","issues_url":"https://api.github.com/repos/openstax/accounts/issues{/number}","pulls_url":"https://api.github.com/repos/openstax/accounts/pulls{/number}","milestones_url":"https://api.github.com/repos/openstax/accounts/milestones{/number}","notifications_url":"https://api.github.com/repos/openstax/accounts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openstax/accounts/labels{/name}","releases_url":"https://api.github.com/repos/openstax/accounts/releases{/id}","created_at":"2013-07-10T02:36:07Z","updated_at":"2015-02-09T18:25:53Z","pushed_at":"2015-02-17T22:41:39Z","git_url":"git://github.com/openstax/accounts.git","ssh_url":"git@github.com:openstax/accounts.git","clone_url":"https://github.com/openstax/accounts.git","svn_url":"https://github.com/openstax/accounts","homepage":"","size":1612,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":22,"forks":5,"open_issues":22,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openstax/accounts/pulls/122"},"html":{"href":"https://github.com/openstax/accounts/pull/122"},"issue":{"href":"https://api.github.com/repos/openstax/accounts/issues/122"},"comments":{"href":"https://api.github.com/repos/openstax/accounts/issues/122/comments"},"review_comments":{"href":"https://api.github.com/repos/openstax/accounts/pulls/122/comments"},"review_comment":{"href":"https://api.github.com/repos/openstax/accounts/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/openstax/accounts/pulls/122/commits"},"statuses":{"href":"https://api.github.com/repos/openstax/accounts/statuses/b414fe1763da5553cf0ced26f3b22eb9e7f1b58c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jpslav","id":1001691,"avatar_url":"https://avatars.githubusercontent.com/u/1001691?v=3","gravatar_id":"","url":"https://api.github.com/users/jpslav","html_url":"https://github.com/jpslav","followers_url":"https://api.github.com/users/jpslav/followers","following_url":"https://api.github.com/users/jpslav/following{/other_user}","gists_url":"https://api.github.com/users/jpslav/gists{/gist_id}","starred_url":"https://api.github.com/users/jpslav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpslav/subscriptions","organizations_url":"https://api.github.com/users/jpslav/orgs","repos_url":"https://api.github.com/users/jpslav/repos","events_url":"https://api.github.com/users/jpslav/events{/privacy}","received_events_url":"https://api.github.com/users/jpslav/received_events","type":"User","site_admin":false},"comments":9,"review_comments":0,"commits":2,"additions":13,"deletions":10,"changed_files":4}}