{"action":"created","comment":{"url":"https://api.github.com/repos/zotero/zotero/pulls/comments/43986636","id":43986636,"diff_hunk":"@@ -381,7 +381,26 @@ Components.utils.import(\"resource://gre/modules/osfile.jsm\");\n \t\t\t\t\treturn false;\n \t\t\t\t}\n \t\t\t}\n-\t\t\t\n+\t\t\tif(Zotero.File.isDropboxDirectory(dataDir.path) && Zotero.Prefs.get('warnDropboxDataDir')){\n+\t\t\t\tlet check = {value: false};\n+\t\t\t\tps = Services.prompt;\n+\t\t\t\tindex = ps.confirmEx(null,","path":"chrome/content/zotero/xpcom/zotero.js","position":8,"original_position":8,"commit_id":"2c00d9d653900e1988e7a32b10eafc264e07bd60","original_commit_id":"2c00d9d653900e1988e7a32b10eafc264e07bd60","user":{"login":"adomasven","id":5899315,"avatar_url":"https://avatars.githubusercontent.com/u/5899315?v=3","gravatar_id":"","url":"https://api.github.com/users/adomasven","html_url":"https://github.com/adomasven","followers_url":"https://api.github.com/users/adomasven/followers","following_url":"https://api.github.com/users/adomasven/following{/other_user}","gists_url":"https://api.github.com/users/adomasven/gists{/gist_id}","starred_url":"https://api.github.com/users/adomasven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adomasven/subscriptions","organizations_url":"https://api.github.com/users/adomasven/orgs","repos_url":"https://api.github.com/users/adomasven/repos","events_url":"https://api.github.com/users/adomasven/events{/privacy}","received_events_url":"https://api.github.com/users/adomasven/received_events","type":"User","site_admin":false},"body":"It is declared above as global for the function with `var`. IDE was complaining about multiple declarations.","created_at":"2015-11-05T08:24:17Z","updated_at":"2015-11-05T08:24:17Z","html_url":"https://github.com/zotero/zotero/pull/867#discussion_r43986636","pull_request_url":"https://api.github.com/repos/zotero/zotero/pulls/867","_links":{"self":{"href":"https://api.github.com/repos/zotero/zotero/pulls/comments/43986636"},"html":{"href":"https://github.com/zotero/zotero/pull/867#discussion_r43986636"},"pull_request":{"href":"https://api.github.com/repos/zotero/zotero/pulls/867"}}},"pull_request":{"url":"https://api.github.com/repos/zotero/zotero/pulls/867","id":49748767,"html_url":"https://github.com/zotero/zotero/pull/867","diff_url":"https://github.com/zotero/zotero/pull/867.diff","patch_url":"https://github.com/zotero/zotero/pull/867.patch","issue_url":"https://api.github.com/repos/zotero/zotero/issues/867","number":867,"state":"open","locked":false,"title":"Detect when data directory is in Dropbox","user":{"login":"adomasven","id":5899315,"avatar_url":"https://avatars.githubusercontent.com/u/5899315?v=3","gravatar_id":"","url":"https://api.github.com/users/adomasven","html_url":"https://github.com/adomasven","followers_url":"https://api.github.com/users/adomasven/followers","following_url":"https://api.github.com/users/adomasven/following{/other_user}","gists_url":"https://api.github.com/users/adomasven/gists{/gist_id}","starred_url":"https://api.github.com/users/adomasven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adomasven/subscriptions","organizations_url":"https://api.github.com/users/adomasven/orgs","repos_url":"https://api.github.com/users/adomasven/repos","events_url":"https://api.github.com/users/adomasven/events{/privacy}","received_events_url":"https://api.github.com/users/adomasven/received_events","type":"User","site_admin":false},"body":"Closes #437","created_at":"2015-11-04T21:33:57Z","updated_at":"2015-11-05T08:24:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d248369e0c76416dfa678883439f4740459481d1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zotero/zotero/pulls/867/commits","review_comments_url":"https://api.github.com/repos/zotero/zotero/pulls/867/comments","review_comment_url":"https://api.github.com/repos/zotero/zotero/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zotero/zotero/issues/867/comments","statuses_url":"https://api.github.com/repos/zotero/zotero/statuses/2c00d9d653900e1988e7a32b10eafc264e07bd60","head":{"label":"adomasven:feature/dropbox-alert","ref":"feature/dropbox-alert","sha":"2c00d9d653900e1988e7a32b10eafc264e07bd60","user":{"login":"adomasven","id":5899315,"avatar_url":"https://avatars.githubusercontent.com/u/5899315?v=3","gravatar_id":"","url":"https://api.github.com/users/adomasven","html_url":"https://github.com/adomasven","followers_url":"https://api.github.com/users/adomasven/followers","following_url":"https://api.github.com/users/adomasven/following{/other_user}","gists_url":"https://api.github.com/users/adomasven/gists{/gist_id}","starred_url":"https://api.github.com/users/adomasven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adomasven/subscriptions","organizations_url":"https://api.github.com/users/adomasven/orgs","repos_url":"https://api.github.com/users/adomasven/repos","events_url":"https://api.github.com/users/adomasven/events{/privacy}","received_events_url":"https://api.github.com/users/adomasven/received_events","type":"User","site_admin":false},"repo":{"id":45567955,"name":"zotero","full_name":"adomasven/zotero","owner":{"login":"adomasven","id":5899315,"avatar_url":"https://avatars.githubusercontent.com/u/5899315?v=3","gravatar_id":"","url":"https://api.github.com/users/adomasven","html_url":"https://github.com/adomasven","followers_url":"https://api.github.com/users/adomasven/followers","following_url":"https://api.github.com/users/adomasven/following{/other_user}","gists_url":"https://api.github.com/users/adomasven/gists{/gist_id}","starred_url":"https://api.github.com/users/adomasven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adomasven/subscriptions","organizations_url":"https://api.github.com/users/adomasven/orgs","repos_url":"https://api.github.com/users/adomasven/repos","events_url":"https://api.github.com/users/adomasven/events{/privacy}","received_events_url":"https://api.github.com/users/adomasven/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adomasven/zotero","description":"Zotero is a free, easy-to-use tool to help you collect, organize, cite, and share your research sources.","fork":true,"url":"https://api.github.com/repos/adomasven/zotero","forks_url":"https://api.github.com/repos/adomasven/zotero/forks","keys_url":"https://api.github.com/repos/adomasven/zotero/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adomasven/zotero/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adomasven/zotero/teams","hooks_url":"https://api.github.com/repos/adomasven/zotero/hooks","issue_events_url":"https://api.github.com/repos/adomasven/zotero/issues/events{/number}","events_url":"https://api.github.com/repos/adomasven/zotero/events","assignees_url":"https://api.github.com/repos/adomasven/zotero/assignees{/user}","branches_url":"https://api.github.com/repos/adomasven/zotero/branches{/branch}","tags_url":"https://api.github.com/repos/adomasven/zotero/tags","blobs_url":"https://api.github.com/repos/adomasven/zotero/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adomasven/zotero/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adomasven/zotero/git/refs{/sha}","trees_url":"https://api.github.com/repos/adomasven/zotero/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adomasven/zotero/statuses/{sha}","languages_url":"https://api.github.com/repos/adomasven/zotero/languages","stargazers_url":"https://api.github.com/repos/adomasven/zotero/stargazers","contributors_url":"https://api.github.com/repos/adomasven/zotero/contributors","subscribers_url":"https://api.github.com/repos/adomasven/zotero/subscribers","subscription_url":"https://api.github.com/repos/adomasven/zotero/subscription","commits_url":"https://api.github.com/repos/adomasven/zotero/commits{/sha}","git_commits_url":"https://api.github.com/repos/adomasven/zotero/git/commits{/sha}","comments_url":"https://api.github.com/repos/adomasven/zotero/comments{/number}","issue_comment_url":"https://api.github.com/repos/adomasven/zotero/issues/comments{/number}","contents_url":"https://api.github.com/repos/adomasven/zotero/contents/{+path}","compare_url":"https://api.github.com/repos/adomasven/zotero/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adomasven/zotero/merges","archive_url":"https://api.github.com/repos/adomasven/zotero/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adomasven/zotero/downloads","issues_url":"https://api.github.com/repos/adomasven/zotero/issues{/number}","pulls_url":"https://api.github.com/repos/adomasven/zotero/pulls{/number}","milestones_url":"https://api.github.com/repos/adomasven/zotero/milestones{/number}","notifications_url":"https://api.github.com/repos/adomasven/zotero/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adomasven/zotero/labels{/name}","releases_url":"https://api.github.com/repos/adomasven/zotero/releases{/id}","created_at":"2015-11-04T21:16:24Z","updated_at":"2015-11-04T21:16:36Z","pushed_at":"2015-11-04T21:31:11Z","git_url":"git://github.com/adomasven/zotero.git","ssh_url":"git@github.com:adomasven/zotero.git","clone_url":"https://github.com/adomasven/zotero.git","svn_url":"https://github.com/adomasven/zotero","homepage":"https://www.zotero.org","size":89820,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"4.0"}},"base":{"label":"zotero:master","ref":"master","sha":"1e6bb44e80e7c0c1c0dda5c43a0a101a2821ea20","user":{"login":"zotero","id":891917,"avatar_url":"https://avatars.githubusercontent.com/u/891917?v=3","gravatar_id":"","url":"https://api.github.com/users/zotero","html_url":"https://github.com/zotero","followers_url":"https://api.github.com/users/zotero/followers","following_url":"https://api.github.com/users/zotero/following{/other_user}","gists_url":"https://api.github.com/users/zotero/gists{/gist_id}","starred_url":"https://api.github.com/users/zotero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zotero/subscriptions","organizations_url":"https://api.github.com/users/zotero/orgs","repos_url":"https://api.github.com/users/zotero/repos","events_url":"https://api.github.com/users/zotero/events{/privacy}","received_events_url":"https://api.github.com/users/zotero/received_events","type":"Organization","site_admin":false},"repo":{"id":2656556,"name":"zotero","full_name":"zotero/zotero","owner":{"login":"zotero","id":891917,"avatar_url":"https://avatars.githubusercontent.com/u/891917?v=3","gravatar_id":"","url":"https://api.github.com/users/zotero","html_url":"https://github.com/zotero","followers_url":"https://api.github.com/users/zotero/followers","following_url":"https://api.github.com/users/zotero/following{/other_user}","gists_url":"https://api.github.com/users/zotero/gists{/gist_id}","starred_url":"https://api.github.com/users/zotero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zotero/subscriptions","organizations_url":"https://api.github.com/users/zotero/orgs","repos_url":"https://api.github.com/users/zotero/repos","events_url":"https://api.github.com/users/zotero/events{/privacy}","received_events_url":"https://api.github.com/users/zotero/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zotero/zotero","description":"Zotero is a free, easy-to-use tool to help you collect, organize, cite, and share your research sources.","fork":false,"url":"https://api.github.com/repos/zotero/zotero","forks_url":"https://api.github.com/repos/zotero/zotero/forks","keys_url":"https://api.github.com/repos/zotero/zotero/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zotero/zotero/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zotero/zotero/teams","hooks_url":"https://api.github.com/repos/zotero/zotero/hooks","issue_events_url":"https://api.github.com/repos/zotero/zotero/issues/events{/number}","events_url":"https://api.github.com/repos/zotero/zotero/events","assignees_url":"https://api.github.com/repos/zotero/zotero/assignees{/user}","branches_url":"https://api.github.com/repos/zotero/zotero/branches{/branch}","tags_url":"https://api.github.com/repos/zotero/zotero/tags","blobs_url":"https://api.github.com/repos/zotero/zotero/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zotero/zotero/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zotero/zotero/git/refs{/sha}","trees_url":"https://api.github.com/repos/zotero/zotero/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zotero/zotero/statuses/{sha}","languages_url":"https://api.github.com/repos/zotero/zotero/languages","stargazers_url":"https://api.github.com/repos/zotero/zotero/stargazers","contributors_url":"https://api.github.com/repos/zotero/zotero/contributors","subscribers_url":"https://api.github.com/repos/zotero/zotero/subscribers","subscription_url":"https://api.github.com/repos/zotero/zotero/subscription","commits_url":"https://api.github.com/repos/zotero/zotero/commits{/sha}","git_commits_url":"https://api.github.com/repos/zotero/zotero/git/commits{/sha}","comments_url":"https://api.github.com/repos/zotero/zotero/comments{/number}","issue_comment_url":"https://api.github.com/repos/zotero/zotero/issues/comments{/number}","contents_url":"https://api.github.com/repos/zotero/zotero/contents/{+path}","compare_url":"https://api.github.com/repos/zotero/zotero/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zotero/zotero/merges","archive_url":"https://api.github.com/repos/zotero/zotero/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zotero/zotero/downloads","issues_url":"https://api.github.com/repos/zotero/zotero/issues{/number}","pulls_url":"https://api.github.com/repos/zotero/zotero/pulls{/number}","milestones_url":"https://api.github.com/repos/zotero/zotero/milestones{/number}","notifications_url":"https://api.github.com/repos/zotero/zotero/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zotero/zotero/labels{/name}","releases_url":"https://api.github.com/repos/zotero/zotero/releases{/id}","created_at":"2011-10-27T07:46:48Z","updated_at":"2015-11-04T13:25:03Z","pushed_at":"2015-11-04T21:33:58Z","git_url":"git://github.com/zotero/zotero.git","ssh_url":"git@github.com:zotero/zotero.git","clone_url":"https://github.com/zotero/zotero.git","svn_url":"https://github.com/zotero/zotero","homepage":"https://www.zotero.org","size":89820,"stargazers_count":367,"watchers_count":367,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":139,"mirror_url":null,"open_issues_count":321,"forks":139,"open_issues":321,"watchers":367,"default_branch":"4.0"}},"_links":{"self":{"href":"https://api.github.com/repos/zotero/zotero/pulls/867"},"html":{"href":"https://github.com/zotero/zotero/pull/867"},"issue":{"href":"https://api.github.com/repos/zotero/zotero/issues/867"},"comments":{"href":"https://api.github.com/repos/zotero/zotero/issues/867/comments"},"review_comments":{"href":"https://api.github.com/repos/zotero/zotero/pulls/867/comments"},"review_comment":{"href":"https://api.github.com/repos/zotero/zotero/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zotero/zotero/pulls/867/commits"},"statuses":{"href":"https://api.github.com/repos/zotero/zotero/statuses/2c00d9d653900e1988e7a32b10eafc264e07bd60"}}}}