{"action":"opened","number":2432,"pull_request":{"url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/2432","id":49081531,"html_url":"https://github.com/ParadiseSS13/Paradise/pull/2432","diff_url":"https://github.com/ParadiseSS13/Paradise/pull/2432.diff","patch_url":"https://github.com/ParadiseSS13/Paradise/pull/2432.patch","issue_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/2432","number":2432,"state":"open","locked":false,"title":"Fixed how things get space cash worth, and richest escapee scoreboard line","user":{"login":"Tastyfish","id":1185434,"avatar_url":"https://avatars.githubusercontent.com/u/1185434?v=3","gravatar_id":"","url":"https://api.github.com/users/Tastyfish","html_url":"https://github.com/Tastyfish","followers_url":"https://api.github.com/users/Tastyfish/followers","following_url":"https://api.github.com/users/Tastyfish/following{/other_user}","gists_url":"https://api.github.com/users/Tastyfish/gists{/gist_id}","starred_url":"https://api.github.com/users/Tastyfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tastyfish/subscriptions","organizations_url":"https://api.github.com/users/Tastyfish/orgs","repos_url":"https://api.github.com/users/Tastyfish/repos","events_url":"https://api.github.com/users/Tastyfish/events{/privacy}","received_events_url":"https://api.github.com/users/Tastyfish/received_events","type":"User","site_admin":false},"body":"This PR in general fixes how things get the credit value of space cash. Many machines, etc previously just used the `cash.worth` var, ignoring that space cash is a stack with an `amount` var as well. In particular, the ATM transaction log and the spacecash object code itself were mixing up the worth and the total value.\r\n* There is now a `get_total()` proc that everything calls instead, abstracting out how the cash stack represents its value. \r\n* The scoreboard code for *richest escapee* has also been changed to actually check the id's associated bank account, rather than the phantom var `id.money`, which was literally only referenced at its definition and the scoreboard code. That var has now been removed. It now also handles containers more than one level and uses `get_total()`.\r\n\r\nFixes #1784","created_at":"2015-10-28T23:30:40Z","updated_at":"2015-10-28T23:30:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/2432/commits","review_comments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/2432/comments","review_comment_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/2432/comments","statuses_url":"https://api.github.com/repos/ParadiseSS13/Paradise/statuses/16cb55af34035fb3be798d6ecd55613c292fee2b","head":{"label":"Tastyfish:master","ref":"master","sha":"16cb55af34035fb3be798d6ecd55613c292fee2b","user":{"login":"Tastyfish","id":1185434,"avatar_url":"https://avatars.githubusercontent.com/u/1185434?v=3","gravatar_id":"","url":"https://api.github.com/users/Tastyfish","html_url":"https://github.com/Tastyfish","followers_url":"https://api.github.com/users/Tastyfish/followers","following_url":"https://api.github.com/users/Tastyfish/following{/other_user}","gists_url":"https://api.github.com/users/Tastyfish/gists{/gist_id}","starred_url":"https://api.github.com/users/Tastyfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tastyfish/subscriptions","organizations_url":"https://api.github.com/users/Tastyfish/orgs","repos_url":"https://api.github.com/users/Tastyfish/repos","events_url":"https://api.github.com/users/Tastyfish/events{/privacy}","received_events_url":"https://api.github.com/users/Tastyfish/received_events","type":"User","site_admin":false},"repo":{"id":44722352,"name":"Paradise","full_name":"Tastyfish/Paradise","owner":{"login":"Tastyfish","id":1185434,"avatar_url":"https://avatars.githubusercontent.com/u/1185434?v=3","gravatar_id":"","url":"https://api.github.com/users/Tastyfish","html_url":"https://github.com/Tastyfish","followers_url":"https://api.github.com/users/Tastyfish/followers","following_url":"https://api.github.com/users/Tastyfish/following{/other_user}","gists_url":"https://api.github.com/users/Tastyfish/gists{/gist_id}","starred_url":"https://api.github.com/users/Tastyfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tastyfish/subscriptions","organizations_url":"https://api.github.com/users/Tastyfish/orgs","repos_url":"https://api.github.com/users/Tastyfish/repos","events_url":"https://api.github.com/users/Tastyfish/events{/privacy}","received_events_url":"https://api.github.com/users/Tastyfish/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Tastyfish/Paradise","description":"Paradise Station's GitHub repository","fork":true,"url":"https://api.github.com/repos/Tastyfish/Paradise","forks_url":"https://api.github.com/repos/Tastyfish/Paradise/forks","keys_url":"https://api.github.com/repos/Tastyfish/Paradise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tastyfish/Paradise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tastyfish/Paradise/teams","hooks_url":"https://api.github.com/repos/Tastyfish/Paradise/hooks","issue_events_url":"https://api.github.com/repos/Tastyfish/Paradise/issues/events{/number}","events_url":"https://api.github.com/repos/Tastyfish/Paradise/events","assignees_url":"https://api.github.com/repos/Tastyfish/Paradise/assignees{/user}","branches_url":"https://api.github.com/repos/Tastyfish/Paradise/branches{/branch}","tags_url":"https://api.github.com/repos/Tastyfish/Paradise/tags","blobs_url":"https://api.github.com/repos/Tastyfish/Paradise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tastyfish/Paradise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tastyfish/Paradise/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tastyfish/Paradise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tastyfish/Paradise/statuses/{sha}","languages_url":"https://api.github.com/repos/Tastyfish/Paradise/languages","stargazers_url":"https://api.github.com/repos/Tastyfish/Paradise/stargazers","contributors_url":"https://api.github.com/repos/Tastyfish/Paradise/contributors","subscribers_url":"https://api.github.com/repos/Tastyfish/Paradise/subscribers","subscription_url":"https://api.github.com/repos/Tastyfish/Paradise/subscription","commits_url":"https://api.github.com/repos/Tastyfish/Paradise/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tastyfish/Paradise/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tastyfish/Paradise/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tastyfish/Paradise/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tastyfish/Paradise/contents/{+path}","compare_url":"https://api.github.com/repos/Tastyfish/Paradise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tastyfish/Paradise/merges","archive_url":"https://api.github.com/repos/Tastyfish/Paradise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tastyfish/Paradise/downloads","issues_url":"https://api.github.com/repos/Tastyfish/Paradise/issues{/number}","pulls_url":"https://api.github.com/repos/Tastyfish/Paradise/pulls{/number}","milestones_url":"https://api.github.com/repos/Tastyfish/Paradise/milestones{/number}","notifications_url":"https://api.github.com/repos/Tastyfish/Paradise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tastyfish/Paradise/labels{/name}","releases_url":"https://api.github.com/repos/Tastyfish/Paradise/releases{/id}","created_at":"2015-10-22T04:36:31Z","updated_at":"2015-10-22T04:37:39Z","pushed_at":"2015-10-28T23:05:07Z","git_url":"git://github.com/Tastyfish/Paradise.git","ssh_url":"git@github.com:Tastyfish/Paradise.git","clone_url":"https://github.com/Tastyfish/Paradise.git","svn_url":"https://github.com/Tastyfish/Paradise","homepage":"http://nanotrasen.se/phpBB3/index.php","size":801008,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ParadiseSS13:master","ref":"master","sha":"f76109ca5c71809f0e7ea94ce47369bf0ba2e32c","user":{"login":"ParadiseSS13","id":9994901,"avatar_url":"https://avatars.githubusercontent.com/u/9994901?v=3","gravatar_id":"","url":"https://api.github.com/users/ParadiseSS13","html_url":"https://github.com/ParadiseSS13","followers_url":"https://api.github.com/users/ParadiseSS13/followers","following_url":"https://api.github.com/users/ParadiseSS13/following{/other_user}","gists_url":"https://api.github.com/users/ParadiseSS13/gists{/gist_id}","starred_url":"https://api.github.com/users/ParadiseSS13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParadiseSS13/subscriptions","organizations_url":"https://api.github.com/users/ParadiseSS13/orgs","repos_url":"https://api.github.com/users/ParadiseSS13/repos","events_url":"https://api.github.com/users/ParadiseSS13/events{/privacy}","received_events_url":"https://api.github.com/users/ParadiseSS13/received_events","type":"User","site_admin":false},"repo":{"id":27286452,"name":"Paradise","full_name":"ParadiseSS13/Paradise","owner":{"login":"ParadiseSS13","id":9994901,"avatar_url":"https://avatars.githubusercontent.com/u/9994901?v=3","gravatar_id":"","url":"https://api.github.com/users/ParadiseSS13","html_url":"https://github.com/ParadiseSS13","followers_url":"https://api.github.com/users/ParadiseSS13/followers","following_url":"https://api.github.com/users/ParadiseSS13/following{/other_user}","gists_url":"https://api.github.com/users/ParadiseSS13/gists{/gist_id}","starred_url":"https://api.github.com/users/ParadiseSS13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParadiseSS13/subscriptions","organizations_url":"https://api.github.com/users/ParadiseSS13/orgs","repos_url":"https://api.github.com/users/ParadiseSS13/repos","events_url":"https://api.github.com/users/ParadiseSS13/events{/privacy}","received_events_url":"https://api.github.com/users/ParadiseSS13/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ParadiseSS13/Paradise","description":"Paradise Station's GitHub repository","fork":false,"url":"https://api.github.com/repos/ParadiseSS13/Paradise","forks_url":"https://api.github.com/repos/ParadiseSS13/Paradise/forks","keys_url":"https://api.github.com/repos/ParadiseSS13/Paradise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ParadiseSS13/Paradise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ParadiseSS13/Paradise/teams","hooks_url":"https://api.github.com/repos/ParadiseSS13/Paradise/hooks","issue_events_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/events{/number}","events_url":"https://api.github.com/repos/ParadiseSS13/Paradise/events","assignees_url":"https://api.github.com/repos/ParadiseSS13/Paradise/assignees{/user}","branches_url":"https://api.github.com/repos/ParadiseSS13/Paradise/branches{/branch}","tags_url":"https://api.github.com/repos/ParadiseSS13/Paradise/tags","blobs_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/refs{/sha}","trees_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ParadiseSS13/Paradise/statuses/{sha}","languages_url":"https://api.github.com/repos/ParadiseSS13/Paradise/languages","stargazers_url":"https://api.github.com/repos/ParadiseSS13/Paradise/stargazers","contributors_url":"https://api.github.com/repos/ParadiseSS13/Paradise/contributors","subscribers_url":"https://api.github.com/repos/ParadiseSS13/Paradise/subscribers","subscription_url":"https://api.github.com/repos/ParadiseSS13/Paradise/subscription","commits_url":"https://api.github.com/repos/ParadiseSS13/Paradise/commits{/sha}","git_commits_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/commits{/sha}","comments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/comments{/number}","issue_comment_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/comments{/number}","contents_url":"https://api.github.com/repos/ParadiseSS13/Paradise/contents/{+path}","compare_url":"https://api.github.com/repos/ParadiseSS13/Paradise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ParadiseSS13/Paradise/merges","archive_url":"https://api.github.com/repos/ParadiseSS13/Paradise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ParadiseSS13/Paradise/downloads","issues_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues{/number}","pulls_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls{/number}","milestones_url":"https://api.github.com/repos/ParadiseSS13/Paradise/milestones{/number}","notifications_url":"https://api.github.com/repos/ParadiseSS13/Paradise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ParadiseSS13/Paradise/labels{/name}","releases_url":"https://api.github.com/repos/ParadiseSS13/Paradise/releases{/id}","created_at":"2014-11-29T00:16:54Z","updated_at":"2015-09-19T01:39:56Z","pushed_at":"2015-10-28T22:44:51Z","git_url":"git://github.com/ParadiseSS13/Paradise.git","ssh_url":"git@github.com:ParadiseSS13/Paradise.git","clone_url":"https://github.com/ParadiseSS13/Paradise.git","svn_url":"https://github.com/ParadiseSS13/Paradise","homepage":"http://nanotrasen.se/phpBB3/index.php","size":827837,"stargazers_count":36,"watchers_count":36,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":107,"mirror_url":null,"open_issues_count":128,"forks":107,"open_issues":128,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/2432"},"html":{"href":"https://github.com/ParadiseSS13/Paradise/pull/2432"},"issue":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/2432"},"comments":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/2432/comments"},"review_comments":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/2432/comments"},"review_comment":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/2432/commits"},"statuses":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/statuses/16cb55af34035fb3be798d6ecd55613c292fee2b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":6,"additions":29,"deletions":35,"changed_files":7}}