{"action":"created","issue":{"url":"https://api.github.com/repos/Windows-XAML/Template10/issues/195","labels_url":"https://api.github.com/repos/Windows-XAML/Template10/issues/195/labels{/name}","comments_url":"https://api.github.com/repos/Windows-XAML/Template10/issues/195/comments","events_url":"https://api.github.com/repos/Windows-XAML/Template10/issues/195/events","html_url":"https://github.com/Windows-XAML/Template10/pull/195","id":109988511,"number":195,"title":"PageHeader theme binding fixed and defaults changed; theme switching …","user":{"login":"dg2k","id":14026786,"avatar_url":"https://avatars.githubusercontent.com/u/14026786?v=3","gravatar_id":"","url":"https://api.github.com/users/dg2k","html_url":"https://github.com/dg2k","followers_url":"https://api.github.com/users/dg2k/followers","following_url":"https://api.github.com/users/dg2k/following{/other_user}","gists_url":"https://api.github.com/users/dg2k/gists{/gist_id}","starred_url":"https://api.github.com/users/dg2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dg2k/subscriptions","organizations_url":"https://api.github.com/users/dg2k/orgs","repos_url":"https://api.github.com/users/dg2k/repos","events_url":"https://api.github.com/users/dg2k/events{/privacy}","received_events_url":"https://api.github.com/users/dg2k/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-10-06T11:32:03Z","updated_at":"2015-10-11T13:29:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Windows-XAML/Template10/pulls/195","html_url":"https://github.com/Windows-XAML/Template10/pull/195","diff_url":"https://github.com/Windows-XAML/Template10/pull/195.diff","patch_url":"https://github.com/Windows-XAML/Template10/pull/195.patch"},"body":"PageHeader theme binding fixed and defaults changed; theme switching enhanced in Minimal template.\r\n\r\nYou'll note that from the outset PageHeader background was defined as Brush rather than SolidColorBrush, which means you have additional options such as LinearGradientBrush, RadialGradientBrush and ImageBrush to play with for more appealing PageHeader backgrounds (haven't thought much about  DrawingBrush and VisualBrush brushes but nothing stops you from trying out by defining in Custom.xaml style file). With this PR, I have included a LinearGradientBrush for Light Theme just to demo a different background brush.\r\n\r\nPageHeader theme switching requires each page to update itself by reading updated background/foreground values in Shell properties (thru binding in respective viewmodel. Is there an automagic way that would force all instances of PageHeader to update globally without each page updating itself? Theme-aware usercontrol? Will PropertyMetadata PropertyChangedCallBack do such a trick? Haven't given much thought here and stopped myself digressing.\r\n\r\nTheme switching (Dark/Light) while for FrameWorkElements is a single line code --  by setting the RequestedTheme property (in this case via Shell instance); for HamburgerMenu or PageHeader, on the other hand, it requires getting user defined values from Custom.xaml and apply to individual items. If there is a more elegant way of parsing user themes (perhaps new to Windows 10 which I've overlooked?) please let me know. An ideal scenario is whereby Windows somehow cooks Custom.xaml resources that leads to an object providing easy access to Dark, Light, Default resources by theme category ... but haven't seen one. (I mean if you can do better than parsing with what XAML provides with ResourceDictionary.ThemeDictionaries)."},"comment":{"url":"https://api.github.com/repos/Windows-XAML/Template10/issues/comments/147192347","html_url":"https://github.com/Windows-XAML/Template10/pull/195#issuecomment-147192347","issue_url":"https://api.github.com/repos/Windows-XAML/Template10/issues/195","id":147192347,"user":{"login":"dg2k","id":14026786,"avatar_url":"https://avatars.githubusercontent.com/u/14026786?v=3","gravatar_id":"","url":"https://api.github.com/users/dg2k","html_url":"https://github.com/dg2k","followers_url":"https://api.github.com/users/dg2k/followers","following_url":"https://api.github.com/users/dg2k/following{/other_user}","gists_url":"https://api.github.com/users/dg2k/gists{/gist_id}","starred_url":"https://api.github.com/users/dg2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dg2k/subscriptions","organizations_url":"https://api.github.com/users/dg2k/orgs","repos_url":"https://api.github.com/users/dg2k/repos","events_url":"https://api.github.com/users/dg2k/events{/privacy}","received_events_url":"https://api.github.com/users/dg2k/received_events","type":"User","site_admin":false},"created_at":"2015-10-11T13:29:41Z","updated_at":"2015-10-11T13:29:41Z","body":"Closing this PR. See my remarks in #202."}}