{"action":"created","comment":{"url":"https://api.github.com/repos/k3po/k3po.java/pulls/comments/24465023","id":24465023,"diff_hunk":"@@ -130,6 +135,18 @@ public void join() throws Exception {\n         latch.awaitFinished();\n     }\n \n+    public void start() {\n+        // script should already be prepared before annotated test can execute\n+        assertTrue(format(\"Did you call join() from outside @%s test?\", Specification.class.getSimpleName()), latch.isPrepared());\n+\n+        // notify script to start\n+        latch.notifyStartable();\n+    }\n+\n+    public void finish() throws Exception {\n+        latch.awaitFinished();\n+    }","path":"junit/src/main/java/org/kaazing/k3po/junit/rules/K3poRule.java","position":26,"original_position":26,"commit_id":"2238d664eba4cc20b9fac52f70a727fcb558f7ec","original_commit_id":"2238d664eba4cc20b9fac52f70a727fcb558f7ec","user":{"login":"jfallows","id":2099911,"avatar_url":"https://avatars.githubusercontent.com/u/2099911?v=3","gravatar_id":"","url":"https://api.github.com/users/jfallows","html_url":"https://github.com/jfallows","followers_url":"https://api.github.com/users/jfallows/followers","following_url":"https://api.github.com/users/jfallows/following{/other_user}","gists_url":"https://api.github.com/users/jfallows/gists{/gist_id}","starred_url":"https://api.github.com/users/jfallows/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfallows/subscriptions","organizations_url":"https://api.github.com/users/jfallows/orgs","repos_url":"https://api.github.com/users/jfallows/repos","events_url":"https://api.github.com/users/jfallows/events{/privacy}","received_events_url":"https://api.github.com/users/jfallows/received_events","type":"User","site_admin":false},"body":"As currently implemented, `k3po.finish()` cannot be used as a direct replacement for `k3po.join()`.  Was that deliberate, or would it be more convenient to let developers be able to call just `k3po.finish()` and let the `k3po.start()` be implicit for that case?","created_at":"2015-02-11T00:24:29Z","updated_at":"2015-02-11T00:24:29Z","html_url":"https://github.com/k3po/k3po.java/pull/12#discussion_r24465023","pull_request_url":"https://api.github.com/repos/k3po/k3po.java/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/k3po/k3po.java/pulls/comments/24465023"},"html":{"href":"https://github.com/k3po/k3po.java/pull/12#discussion_r24465023"},"pull_request":{"href":"https://api.github.com/repos/k3po/k3po.java/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/k3po/k3po.java/pulls/12","id":29056764,"html_url":"https://github.com/k3po/k3po.java/pull/12","diff_url":"https://github.com/k3po/k3po.java/pull/12.diff","patch_url":"https://github.com/k3po/k3po.java/pull/12.patch","issue_url":"https://api.github.com/repos/k3po/k3po.java/issues/12","number":12,"state":"open","locked":false,"title":"Migrated k3po.join to k3po.start and k3po.finish","user":{"login":"dpwspoon","id":2014623,"avatar_url":"https://avatars.githubusercontent.com/u/2014623?v=3","gravatar_id":"","url":"https://api.github.com/users/dpwspoon","html_url":"https://github.com/dpwspoon","followers_url":"https://api.github.com/users/dpwspoon/followers","following_url":"https://api.github.com/users/dpwspoon/following{/other_user}","gists_url":"https://api.github.com/users/dpwspoon/gists{/gist_id}","starred_url":"https://api.github.com/users/dpwspoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpwspoon/subscriptions","organizations_url":"https://api.github.com/users/dpwspoon/orgs","repos_url":"https://api.github.com/users/dpwspoon/repos","events_url":"https://api.github.com/users/dpwspoon/events{/privacy}","received_events_url":"https://api.github.com/users/dpwspoon/received_events","type":"User","site_admin":false},"body":"The start is required so that robot test code can be written in a single thread when the robot is acting as the client.","created_at":"2015-02-10T23:46:20Z","updated_at":"2015-02-11T00:24:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39922a4a438840483ed2f5bdb0fdc90461e12414","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/k3po/k3po.java/pulls/12/commits","review_comments_url":"https://api.github.com/repos/k3po/k3po.java/pulls/12/comments","review_comment_url":"https://api.github.com/repos/k3po/k3po.java/pulls/comments/{number}","comments_url":"https://api.github.com/repos/k3po/k3po.java/issues/12/comments","statuses_url":"https://api.github.com/repos/k3po/k3po.java/statuses/2238d664eba4cc20b9fac52f70a727fcb558f7ec","head":{"label":"dpwspoon:develop","ref":"develop","sha":"2238d664eba4cc20b9fac52f70a727fcb558f7ec","user":{"login":"dpwspoon","id":2014623,"avatar_url":"https://avatars.githubusercontent.com/u/2014623?v=3","gravatar_id":"","url":"https://api.github.com/users/dpwspoon","html_url":"https://github.com/dpwspoon","followers_url":"https://api.github.com/users/dpwspoon/followers","following_url":"https://api.github.com/users/dpwspoon/following{/other_user}","gists_url":"https://api.github.com/users/dpwspoon/gists{/gist_id}","starred_url":"https://api.github.com/users/dpwspoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpwspoon/subscriptions","organizations_url":"https://api.github.com/users/dpwspoon/orgs","repos_url":"https://api.github.com/users/dpwspoon/repos","events_url":"https://api.github.com/users/dpwspoon/events{/privacy}","received_events_url":"https://api.github.com/users/dpwspoon/received_events","type":"User","site_admin":false},"repo":{"id":25721980,"name":"robot.java","full_name":"dpwspoon/robot.java","owner":{"login":"dpwspoon","id":2014623,"avatar_url":"https://avatars.githubusercontent.com/u/2014623?v=3","gravatar_id":"","url":"https://api.github.com/users/dpwspoon","html_url":"https://github.com/dpwspoon","followers_url":"https://api.github.com/users/dpwspoon/followers","following_url":"https://api.github.com/users/dpwspoon/following{/other_user}","gists_url":"https://api.github.com/users/dpwspoon/gists{/gist_id}","starred_url":"https://api.github.com/users/dpwspoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpwspoon/subscriptions","organizations_url":"https://api.github.com/users/dpwspoon/orgs","repos_url":"https://api.github.com/users/dpwspoon/repos","events_url":"https://api.github.com/users/dpwspoon/events{/privacy}","received_events_url":"https://api.github.com/users/dpwspoon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dpwspoon/robot.java","description":"","fork":true,"url":"https://api.github.com/repos/dpwspoon/robot.java","forks_url":"https://api.github.com/repos/dpwspoon/robot.java/forks","keys_url":"https://api.github.com/repos/dpwspoon/robot.java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dpwspoon/robot.java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dpwspoon/robot.java/teams","hooks_url":"https://api.github.com/repos/dpwspoon/robot.java/hooks","issue_events_url":"https://api.github.com/repos/dpwspoon/robot.java/issues/events{/number}","events_url":"https://api.github.com/repos/dpwspoon/robot.java/events","assignees_url":"https://api.github.com/repos/dpwspoon/robot.java/assignees{/user}","branches_url":"https://api.github.com/repos/dpwspoon/robot.java/branches{/branch}","tags_url":"https://api.github.com/repos/dpwspoon/robot.java/tags","blobs_url":"https://api.github.com/repos/dpwspoon/robot.java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dpwspoon/robot.java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dpwspoon/robot.java/git/refs{/sha}","trees_url":"https://api.github.com/repos/dpwspoon/robot.java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dpwspoon/robot.java/statuses/{sha}","languages_url":"https://api.github.com/repos/dpwspoon/robot.java/languages","stargazers_url":"https://api.github.com/repos/dpwspoon/robot.java/stargazers","contributors_url":"https://api.github.com/repos/dpwspoon/robot.java/contributors","subscribers_url":"https://api.github.com/repos/dpwspoon/robot.java/subscribers","subscription_url":"https://api.github.com/repos/dpwspoon/robot.java/subscription","commits_url":"https://api.github.com/repos/dpwspoon/robot.java/commits{/sha}","git_commits_url":"https://api.github.com/repos/dpwspoon/robot.java/git/commits{/sha}","comments_url":"https://api.github.com/repos/dpwspoon/robot.java/comments{/number}","issue_comment_url":"https://api.github.com/repos/dpwspoon/robot.java/issues/comments/{number}","contents_url":"https://api.github.com/repos/dpwspoon/robot.java/contents/{+path}","compare_url":"https://api.github.com/repos/dpwspoon/robot.java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dpwspoon/robot.java/merges","archive_url":"https://api.github.com/repos/dpwspoon/robot.java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dpwspoon/robot.java/downloads","issues_url":"https://api.github.com/repos/dpwspoon/robot.java/issues{/number}","pulls_url":"https://api.github.com/repos/dpwspoon/robot.java/pulls{/number}","milestones_url":"https://api.github.com/repos/dpwspoon/robot.java/milestones{/number}","notifications_url":"https://api.github.com/repos/dpwspoon/robot.java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dpwspoon/robot.java/labels{/name}","releases_url":"https://api.github.com/repos/dpwspoon/robot.java/releases{/id}","created_at":"2014-10-25T06:05:52Z","updated_at":"2015-02-10T23:23:38Z","pushed_at":"2015-02-10T23:23:38Z","git_url":"git://github.com/dpwspoon/robot.java.git","ssh_url":"git@github.com:dpwspoon/robot.java.git","clone_url":"https://github.com/dpwspoon/robot.java.git","svn_url":"https://github.com/dpwspoon/robot.java","homepage":null,"size":1302,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"k3po:develop","ref":"develop","sha":"622e76201c7de568632e9555eaa6dc3009a2c960","user":{"login":"k3po","id":10240063,"avatar_url":"https://avatars.githubusercontent.com/u/10240063?v=3","gravatar_id":"","url":"https://api.github.com/users/k3po","html_url":"https://github.com/k3po","followers_url":"https://api.github.com/users/k3po/followers","following_url":"https://api.github.com/users/k3po/following{/other_user}","gists_url":"https://api.github.com/users/k3po/gists{/gist_id}","starred_url":"https://api.github.com/users/k3po/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k3po/subscriptions","organizations_url":"https://api.github.com/users/k3po/orgs","repos_url":"https://api.github.com/users/k3po/repos","events_url":"https://api.github.com/users/k3po/events{/privacy}","received_events_url":"https://api.github.com/users/k3po/received_events","type":"Organization","site_admin":false},"repo":{"id":24692323,"name":"k3po.java","full_name":"k3po/k3po.java","owner":{"login":"k3po","id":10240063,"avatar_url":"https://avatars.githubusercontent.com/u/10240063?v=3","gravatar_id":"","url":"https://api.github.com/users/k3po","html_url":"https://github.com/k3po","followers_url":"https://api.github.com/users/k3po/followers","following_url":"https://api.github.com/users/k3po/following{/other_user}","gists_url":"https://api.github.com/users/k3po/gists{/gist_id}","starred_url":"https://api.github.com/users/k3po/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k3po/subscriptions","organizations_url":"https://api.github.com/users/k3po/orgs","repos_url":"https://api.github.com/users/k3po/repos","events_url":"https://api.github.com/users/k3po/events{/privacy}","received_events_url":"https://api.github.com/users/k3po/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/k3po/k3po.java","description":"K3PO for Java (JUnit)","fork":false,"url":"https://api.github.com/repos/k3po/k3po.java","forks_url":"https://api.github.com/repos/k3po/k3po.java/forks","keys_url":"https://api.github.com/repos/k3po/k3po.java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/k3po/k3po.java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/k3po/k3po.java/teams","hooks_url":"https://api.github.com/repos/k3po/k3po.java/hooks","issue_events_url":"https://api.github.com/repos/k3po/k3po.java/issues/events{/number}","events_url":"https://api.github.com/repos/k3po/k3po.java/events","assignees_url":"https://api.github.com/repos/k3po/k3po.java/assignees{/user}","branches_url":"https://api.github.com/repos/k3po/k3po.java/branches{/branch}","tags_url":"https://api.github.com/repos/k3po/k3po.java/tags","blobs_url":"https://api.github.com/repos/k3po/k3po.java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/k3po/k3po.java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/k3po/k3po.java/git/refs{/sha}","trees_url":"https://api.github.com/repos/k3po/k3po.java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/k3po/k3po.java/statuses/{sha}","languages_url":"https://api.github.com/repos/k3po/k3po.java/languages","stargazers_url":"https://api.github.com/repos/k3po/k3po.java/stargazers","contributors_url":"https://api.github.com/repos/k3po/k3po.java/contributors","subscribers_url":"https://api.github.com/repos/k3po/k3po.java/subscribers","subscription_url":"https://api.github.com/repos/k3po/k3po.java/subscription","commits_url":"https://api.github.com/repos/k3po/k3po.java/commits{/sha}","git_commits_url":"https://api.github.com/repos/k3po/k3po.java/git/commits{/sha}","comments_url":"https://api.github.com/repos/k3po/k3po.java/comments{/number}","issue_comment_url":"https://api.github.com/repos/k3po/k3po.java/issues/comments/{number}","contents_url":"https://api.github.com/repos/k3po/k3po.java/contents/{+path}","compare_url":"https://api.github.com/repos/k3po/k3po.java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/k3po/k3po.java/merges","archive_url":"https://api.github.com/repos/k3po/k3po.java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/k3po/k3po.java/downloads","issues_url":"https://api.github.com/repos/k3po/k3po.java/issues{/number}","pulls_url":"https://api.github.com/repos/k3po/k3po.java/pulls{/number}","milestones_url":"https://api.github.com/repos/k3po/k3po.java/milestones{/number}","notifications_url":"https://api.github.com/repos/k3po/k3po.java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/k3po/k3po.java/labels{/name}","releases_url":"https://api.github.com/repos/k3po/k3po.java/releases{/id}","created_at":"2014-10-01T19:31:45Z","updated_at":"2015-02-10T03:45:05Z","pushed_at":"2015-02-10T03:45:04Z","git_url":"git://github.com/k3po/k3po.java.git","ssh_url":"git@github.com:k3po/k3po.java.git","clone_url":"https://github.com/k3po/k3po.java.git","svn_url":"https://github.com/k3po/k3po.java","homepage":"","size":1682,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":1,"forks":8,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/k3po/k3po.java/pulls/12"},"html":{"href":"https://github.com/k3po/k3po.java/pull/12"},"issue":{"href":"https://api.github.com/repos/k3po/k3po.java/issues/12"},"comments":{"href":"https://api.github.com/repos/k3po/k3po.java/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/k3po/k3po.java/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/k3po/k3po.java/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/k3po/k3po.java/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/k3po/k3po.java/statuses/2238d664eba4cc20b9fac52f70a727fcb558f7ec"}}}}