{"action":"created","issue":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/3203","labels_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/3203/labels{/name}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/3203/comments","events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/3203/events","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3203","id":116809873,"number":3203,"title":"Added PointGeometry and PointAppearance","user":{"login":"lilleyse","id":915398,"avatar_url":"https://avatars.githubusercontent.com/u/915398?v=3","gravatar_id":"","url":"https://api.github.com/users/lilleyse","html_url":"https://github.com/lilleyse","followers_url":"https://api.github.com/users/lilleyse/followers","following_url":"https://api.github.com/users/lilleyse/following{/other_user}","gists_url":"https://api.github.com/users/lilleyse/gists{/gist_id}","starred_url":"https://api.github.com/users/lilleyse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lilleyse/subscriptions","organizations_url":"https://api.github.com/users/lilleyse/orgs","repos_url":"https://api.github.com/users/lilleyse/repos","events_url":"https://api.github.com/users/lilleyse/events{/privacy}","received_events_url":"https://api.github.com/users/lilleyse/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-11-13T17:11:50Z","updated_at":"2015-11-13T22:26:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3203","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3203","diff_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3203.diff","patch_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3203.patch"},"body":"For #3177 \r\n\r\nAdded `PointGeometry` and `PointAppearance` from `3d-tiles` and added tests.\r\n\r\nIn order to update the bounding spheres correctly for points, I added a function to `Primitive` called `updateBoundingVolumes`. It is specific to `PointAppearance` though, so it seems a little out of place.\r\n\r\nI noticed that a lot of other files were doing the same point size calculations, so I created a common function `Camera.getPixelSize`. Maybe this function belongs in a different file."},"comment":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/comments/156576156","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3203#issuecomment-156576156","issue_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/3203","id":156576156,"user":{"login":"pjcozzi","id":782098,"avatar_url":"https://avatars.githubusercontent.com/u/782098?v=3","gravatar_id":"","url":"https://api.github.com/users/pjcozzi","html_url":"https://github.com/pjcozzi","followers_url":"https://api.github.com/users/pjcozzi/followers","following_url":"https://api.github.com/users/pjcozzi/following{/other_user}","gists_url":"https://api.github.com/users/pjcozzi/gists{/gist_id}","starred_url":"https://api.github.com/users/pjcozzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjcozzi/subscriptions","organizations_url":"https://api.github.com/users/pjcozzi/orgs","repos_url":"https://api.github.com/users/pjcozzi/repos","events_url":"https://api.github.com/users/pjcozzi/events{/privacy}","received_events_url":"https://api.github.com/users/pjcozzi/received_events","type":"User","site_admin":false},"created_at":"2015-11-13T22:26:10Z","updated_at":"2015-11-13T22:26:10Z","body":"> I created a common function Camera.getPixelSize. Maybe this function belongs in a different file.\r\n\r\nThanks, this is useful cleanup.  It is fine where it is, but it can't be public as is since it takes a `Context` parameter, which is a private type.  Instead, it could take `drawingBufferWidth` and `drawingBufferHeight`."}}