{"action":"created","issue":{"url":"https://api.github.com/repos/textmate/textmate/issues/1297","labels_url":"https://api.github.com/repos/textmate/textmate/issues/1297/labels{/name}","comments_url":"https://api.github.com/repos/textmate/textmate/issues/1297/comments","events_url":"https://api.github.com/repos/textmate/textmate/issues/1297/events","html_url":"https://github.com/textmate/textmate/pull/1297","id":74683876,"number":1297,"title":"Inline marks","user":{"login":"jacob-carlborg","id":306980,"avatar_url":"https://avatars.githubusercontent.com/u/306980?v=3","gravatar_id":"","url":"https://api.github.com/users/jacob-carlborg","html_url":"https://github.com/jacob-carlborg","followers_url":"https://api.github.com/users/jacob-carlborg/followers","following_url":"https://api.github.com/users/jacob-carlborg/following{/other_user}","gists_url":"https://api.github.com/users/jacob-carlborg/gists{/gist_id}","starred_url":"https://api.github.com/users/jacob-carlborg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacob-carlborg/subscriptions","organizations_url":"https://api.github.com/users/jacob-carlborg/orgs","repos_url":"https://api.github.com/users/jacob-carlborg/repos","events_url":"https://api.github.com/users/jacob-carlborg/events{/privacy}","received_events_url":"https://api.github.com/users/jacob-carlborg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":29,"created_at":"2015-05-09T14:22:18Z","updated_at":"2015-08-13T12:46:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/textmate/textmate/pulls/1297","html_url":"https://github.com/textmate/textmate/pull/1297","diff_url":"https://github.com/textmate/textmate/pull/1297.diff","patch_url":"https://github.com/textmate/textmate/pull/1297.patch"},"body":"This pull request add supports for inline marks. The attached image shows an example of how it will look like. The implementation uses the existing marks API, meaning calling `mate --set-mark` will show up as an inline mark. Since this is a bit intrusive change it's disabled by default and there's a new preference available to enable it.\r\n\r\nDrawing of the inline mark tries to be a bit cleaver, it will draw the message on the next line if it will hide the code on the current line. If it hides the code on the next line as well, it will fall back to draw on the current line.\r\n\r\nA new theme component, \"lineBackground\". It's used to color the background of a whole line (the lighter red in the attached image). The existing \"background\" is used to color the background only where there is text (the darker red in the attached image).\r\n\r\nWe most likely want to extend the themes with a couple of default marks, like \"error\", \"warning\" and so on.\r\n\r\n![rubocop_inline_marks](https://cloud.githubusercontent.com/assets/306980/7550570/34dd48f2-f667-11e4-9bf4-fe08f42dd22a.png)\r\n\r\n- [ ] Separate out functionality in three commits\r\n  * Ability to highlight lines with marks\r\n  * Ability to store multiple marks per line\r\n  * Rendering of the inline marks (with a preferences setting)\r\n- [ ] Handle when no theme color is set (use default background and foreground color)\r\n- [x] Rename \"lineBackground\" to \"highlight\"\r\n- [ ] Investigate if the width of the view port can be used instead of passing it in\r\n- [ ] Remove split function in `buffer/src/marks.cc`\r\n- [ ] Use `++row` instead of `std::next`\r\n- [ ] Fix coding style\r\n- [ ] Fix indentation after `CGContextSaveGState(context)`\r\n- [ ] Fix line above bookmarks are also drawn"},"comment":{"url":"https://api.github.com/repos/textmate/textmate/issues/comments/130657228","html_url":"https://github.com/textmate/textmate/pull/1297#issuecomment-130657228","issue_url":"https://api.github.com/repos/textmate/textmate/issues/1297","id":130657228,"user":{"login":"sorbits","id":11901,"avatar_url":"https://avatars.githubusercontent.com/u/11901?v=3","gravatar_id":"","url":"https://api.github.com/users/sorbits","html_url":"https://github.com/sorbits","followers_url":"https://api.github.com/users/sorbits/followers","following_url":"https://api.github.com/users/sorbits/following{/other_user}","gists_url":"https://api.github.com/users/sorbits/gists{/gist_id}","starred_url":"https://api.github.com/users/sorbits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sorbits/subscriptions","organizations_url":"https://api.github.com/users/sorbits/orgs","repos_url":"https://api.github.com/users/sorbits/repos","events_url":"https://api.github.com/users/sorbits/events{/privacy}","received_events_url":"https://api.github.com/users/sorbits/received_events","type":"User","site_admin":false},"created_at":"2015-08-13T12:46:39Z","updated_at":"2015-08-13T12:46:39Z","body":"Thanks, I missed that a formula was added (back in December).\n\nI’ve installed it and will see if I can create a config file that \nfollows my style :)\n\nOn 7 Aug 2015, at 12:45, René Schwaiger wrote:\n\n>> Do you know of an easy way to install it?\n>\n> Homebrew includes a formula for \n> [clang-format](https://github.com/Homebrew/homebrew/blob/master/Library/Formula/clang-format.rb). \n> `brew install clang-format` works fine on my current system (OS X \n> 10.11 Beta).\n>\n> By the way, thank you Jacob and Allan for your work. This certainly \n> looks like a very interesting feature.\n>\n> ---\n> Reply to this email directly or view it on GitHub:\n> https://github.com/textmate/textmate/pull/1297#issuecomment-128670511\n\n"}}