{"action":"created","comment":{"url":"https://api.github.com/repos/artefactual/atom/pulls/comments/27434503","id":27434503,"diff_hunk":"@@ -62,8 +63,7 @@ protected function execute($arguments = array(), $options = array())\n       $resource = QubitRepository::get($criteria)->__get(0);\n     }\n \n-    $publicationStatus = QubitTerm::getById($arguments['publicationStatusId']);\n-\n+    $publicationStatus = QubitTerm::getById($this->getPublicationStatusIdByName($arguments));","path":"lib/task/tools/updatePublicationStatusTask.class.php","position":23,"original_position":23,"commit_id":"e4a4c534627ed59bd5632f7e0f951bbca5031826","original_commit_id":"e4a4c534627ed59bd5632f7e0f951bbca5031826","user":{"login":"mcantelon","id":49010,"avatar_url":"https://avatars.githubusercontent.com/u/49010?v=3","gravatar_id":"","url":"https://api.github.com/users/mcantelon","html_url":"https://github.com/mcantelon","followers_url":"https://api.github.com/users/mcantelon/followers","following_url":"https://api.github.com/users/mcantelon/following{/other_user}","gists_url":"https://api.github.com/users/mcantelon/gists{/gist_id}","starred_url":"https://api.github.com/users/mcantelon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcantelon/subscriptions","organizations_url":"https://api.github.com/users/mcantelon/orgs","repos_url":"https://api.github.com/users/mcantelon/repos","events_url":"https://api.github.com/users/mcantelon/events{/privacy}","received_events_url":"https://api.github.com/users/mcantelon/received_events","type":"User","site_admin":false},"body":"Super minor nitpick: only the 'publicStatus' element of $arguments gets used in getPublicationStatusIdByName so you could just pass that. But that's pretty subjective so it doesn't really matter. :)","created_at":"2015-03-30T21:36:29Z","updated_at":"2015-03-30T21:36:29Z","html_url":"https://github.com/artefactual/atom/pull/135#discussion_r27434503","pull_request_url":"https://api.github.com/repos/artefactual/atom/pulls/135","_links":{"self":{"href":"https://api.github.com/repos/artefactual/atom/pulls/comments/27434503"},"html":{"href":"https://github.com/artefactual/atom/pull/135#discussion_r27434503"},"pull_request":{"href":"https://api.github.com/repos/artefactual/atom/pulls/135"}}},"pull_request":{"url":"https://api.github.com/repos/artefactual/atom/pulls/135","id":32259986,"html_url":"https://github.com/artefactual/atom/pull/135","diff_url":"https://github.com/artefactual/atom/pull/135.diff","patch_url":"https://github.com/artefactual/atom/pull/135.patch","issue_url":"https://api.github.com/repos/artefactual/atom/issues/135","number":135,"state":"open","locked":false,"title":"Dev/issue 8164 update pub status improvements","user":{"login":"MikeFE","id":6102546,"avatar_url":"https://avatars.githubusercontent.com/u/6102546?v=3","gravatar_id":"","url":"https://api.github.com/users/MikeFE","html_url":"https://github.com/MikeFE","followers_url":"https://api.github.com/users/MikeFE/followers","following_url":"https://api.github.com/users/MikeFE/following{/other_user}","gists_url":"https://api.github.com/users/MikeFE/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeFE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeFE/subscriptions","organizations_url":"https://api.github.com/users/MikeFE/orgs","repos_url":"https://api.github.com/users/MikeFE/repos","events_url":"https://api.github.com/users/MikeFE/events{/privacy}","received_events_url":"https://api.github.com/users/MikeFE/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-03-30T19:43:42Z","updated_at":"2015-03-30T21:36:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"957c4d055f8f68c724d4d1a6cbcd211ee4174b19","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/artefactual/atom/pulls/135/commits","review_comments_url":"https://api.github.com/repos/artefactual/atom/pulls/135/comments","review_comment_url":"https://api.github.com/repos/artefactual/atom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/artefactual/atom/issues/135/comments","statuses_url":"https://api.github.com/repos/artefactual/atom/statuses/e4a4c534627ed59bd5632f7e0f951bbca5031826","head":{"label":"artefactual:dev/issue-8164-update-pub-status-improvements","ref":"dev/issue-8164-update-pub-status-improvements","sha":"e4a4c534627ed59bd5632f7e0f951bbca5031826","user":{"login":"artefactual","id":1163545,"avatar_url":"https://avatars.githubusercontent.com/u/1163545?v=3","gravatar_id":"","url":"https://api.github.com/users/artefactual","html_url":"https://github.com/artefactual","followers_url":"https://api.github.com/users/artefactual/followers","following_url":"https://api.github.com/users/artefactual/following{/other_user}","gists_url":"https://api.github.com/users/artefactual/gists{/gist_id}","starred_url":"https://api.github.com/users/artefactual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artefactual/subscriptions","organizations_url":"https://api.github.com/users/artefactual/orgs","repos_url":"https://api.github.com/users/artefactual/repos","events_url":"https://api.github.com/users/artefactual/events{/privacy}","received_events_url":"https://api.github.com/users/artefactual/received_events","type":"Organization","site_admin":false},"repo":{"id":5705943,"name":"atom","full_name":"artefactual/atom","owner":{"login":"artefactual","id":1163545,"avatar_url":"https://avatars.githubusercontent.com/u/1163545?v=3","gravatar_id":"","url":"https://api.github.com/users/artefactual","html_url":"https://github.com/artefactual","followers_url":"https://api.github.com/users/artefactual/followers","following_url":"https://api.github.com/users/artefactual/following{/other_user}","gists_url":"https://api.github.com/users/artefactual/gists{/gist_id}","starred_url":"https://api.github.com/users/artefactual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artefactual/subscriptions","organizations_url":"https://api.github.com/users/artefactual/orgs","repos_url":"https://api.github.com/users/artefactual/repos","events_url":"https://api.github.com/users/artefactual/events{/privacy}","received_events_url":"https://api.github.com/users/artefactual/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artefactual/atom","description":"Open-source, web application for archival description and public access.","fork":false,"url":"https://api.github.com/repos/artefactual/atom","forks_url":"https://api.github.com/repos/artefactual/atom/forks","keys_url":"https://api.github.com/repos/artefactual/atom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artefactual/atom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artefactual/atom/teams","hooks_url":"https://api.github.com/repos/artefactual/atom/hooks","issue_events_url":"https://api.github.com/repos/artefactual/atom/issues/events{/number}","events_url":"https://api.github.com/repos/artefactual/atom/events","assignees_url":"https://api.github.com/repos/artefactual/atom/assignees{/user}","branches_url":"https://api.github.com/repos/artefactual/atom/branches{/branch}","tags_url":"https://api.github.com/repos/artefactual/atom/tags","blobs_url":"https://api.github.com/repos/artefactual/atom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artefactual/atom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artefactual/atom/git/refs{/sha}","trees_url":"https://api.github.com/repos/artefactual/atom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artefactual/atom/statuses/{sha}","languages_url":"https://api.github.com/repos/artefactual/atom/languages","stargazers_url":"https://api.github.com/repos/artefactual/atom/stargazers","contributors_url":"https://api.github.com/repos/artefactual/atom/contributors","subscribers_url":"https://api.github.com/repos/artefactual/atom/subscribers","subscription_url":"https://api.github.com/repos/artefactual/atom/subscription","commits_url":"https://api.github.com/repos/artefactual/atom/commits{/sha}","git_commits_url":"https://api.github.com/repos/artefactual/atom/git/commits{/sha}","comments_url":"https://api.github.com/repos/artefactual/atom/comments{/number}","issue_comment_url":"https://api.github.com/repos/artefactual/atom/issues/comments{/number}","contents_url":"https://api.github.com/repos/artefactual/atom/contents/{+path}","compare_url":"https://api.github.com/repos/artefactual/atom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artefactual/atom/merges","archive_url":"https://api.github.com/repos/artefactual/atom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artefactual/atom/downloads","issues_url":"https://api.github.com/repos/artefactual/atom/issues{/number}","pulls_url":"https://api.github.com/repos/artefactual/atom/pulls{/number}","milestones_url":"https://api.github.com/repos/artefactual/atom/milestones{/number}","notifications_url":"https://api.github.com/repos/artefactual/atom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artefactual/atom/labels{/name}","releases_url":"https://api.github.com/repos/artefactual/atom/releases{/id}","created_at":"2012-09-06T17:35:28Z","updated_at":"2015-03-28T22:38:12Z","pushed_at":"2015-03-30T19:58:13Z","git_url":"git://github.com/artefactual/atom.git","ssh_url":"git@github.com:artefactual/atom.git","clone_url":"https://github.com/artefactual/atom.git","svn_url":"https://github.com/artefactual/atom","homepage":"http://www.accesstomemory.org","size":47997,"stargazers_count":28,"watchers_count":28,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":5,"forks":29,"open_issues":5,"watchers":28,"default_branch":"qa/2.2.x"}},"base":{"label":"artefactual:qa/2.2.x","ref":"qa/2.2.x","sha":"1d4200713db1b705598c2d179ac018e1a1eb1f00","user":{"login":"artefactual","id":1163545,"avatar_url":"https://avatars.githubusercontent.com/u/1163545?v=3","gravatar_id":"","url":"https://api.github.com/users/artefactual","html_url":"https://github.com/artefactual","followers_url":"https://api.github.com/users/artefactual/followers","following_url":"https://api.github.com/users/artefactual/following{/other_user}","gists_url":"https://api.github.com/users/artefactual/gists{/gist_id}","starred_url":"https://api.github.com/users/artefactual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artefactual/subscriptions","organizations_url":"https://api.github.com/users/artefactual/orgs","repos_url":"https://api.github.com/users/artefactual/repos","events_url":"https://api.github.com/users/artefactual/events{/privacy}","received_events_url":"https://api.github.com/users/artefactual/received_events","type":"Organization","site_admin":false},"repo":{"id":5705943,"name":"atom","full_name":"artefactual/atom","owner":{"login":"artefactual","id":1163545,"avatar_url":"https://avatars.githubusercontent.com/u/1163545?v=3","gravatar_id":"","url":"https://api.github.com/users/artefactual","html_url":"https://github.com/artefactual","followers_url":"https://api.github.com/users/artefactual/followers","following_url":"https://api.github.com/users/artefactual/following{/other_user}","gists_url":"https://api.github.com/users/artefactual/gists{/gist_id}","starred_url":"https://api.github.com/users/artefactual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artefactual/subscriptions","organizations_url":"https://api.github.com/users/artefactual/orgs","repos_url":"https://api.github.com/users/artefactual/repos","events_url":"https://api.github.com/users/artefactual/events{/privacy}","received_events_url":"https://api.github.com/users/artefactual/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artefactual/atom","description":"Open-source, web application for archival description and public access.","fork":false,"url":"https://api.github.com/repos/artefactual/atom","forks_url":"https://api.github.com/repos/artefactual/atom/forks","keys_url":"https://api.github.com/repos/artefactual/atom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artefactual/atom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artefactual/atom/teams","hooks_url":"https://api.github.com/repos/artefactual/atom/hooks","issue_events_url":"https://api.github.com/repos/artefactual/atom/issues/events{/number}","events_url":"https://api.github.com/repos/artefactual/atom/events","assignees_url":"https://api.github.com/repos/artefactual/atom/assignees{/user}","branches_url":"https://api.github.com/repos/artefactual/atom/branches{/branch}","tags_url":"https://api.github.com/repos/artefactual/atom/tags","blobs_url":"https://api.github.com/repos/artefactual/atom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artefactual/atom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artefactual/atom/git/refs{/sha}","trees_url":"https://api.github.com/repos/artefactual/atom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artefactual/atom/statuses/{sha}","languages_url":"https://api.github.com/repos/artefactual/atom/languages","stargazers_url":"https://api.github.com/repos/artefactual/atom/stargazers","contributors_url":"https://api.github.com/repos/artefactual/atom/contributors","subscribers_url":"https://api.github.com/repos/artefactual/atom/subscribers","subscription_url":"https://api.github.com/repos/artefactual/atom/subscription","commits_url":"https://api.github.com/repos/artefactual/atom/commits{/sha}","git_commits_url":"https://api.github.com/repos/artefactual/atom/git/commits{/sha}","comments_url":"https://api.github.com/repos/artefactual/atom/comments{/number}","issue_comment_url":"https://api.github.com/repos/artefactual/atom/issues/comments{/number}","contents_url":"https://api.github.com/repos/artefactual/atom/contents/{+path}","compare_url":"https://api.github.com/repos/artefactual/atom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artefactual/atom/merges","archive_url":"https://api.github.com/repos/artefactual/atom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artefactual/atom/downloads","issues_url":"https://api.github.com/repos/artefactual/atom/issues{/number}","pulls_url":"https://api.github.com/repos/artefactual/atom/pulls{/number}","milestones_url":"https://api.github.com/repos/artefactual/atom/milestones{/number}","notifications_url":"https://api.github.com/repos/artefactual/atom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artefactual/atom/labels{/name}","releases_url":"https://api.github.com/repos/artefactual/atom/releases{/id}","created_at":"2012-09-06T17:35:28Z","updated_at":"2015-03-28T22:38:12Z","pushed_at":"2015-03-30T19:58:13Z","git_url":"git://github.com/artefactual/atom.git","ssh_url":"git@github.com:artefactual/atom.git","clone_url":"https://github.com/artefactual/atom.git","svn_url":"https://github.com/artefactual/atom","homepage":"http://www.accesstomemory.org","size":47997,"stargazers_count":28,"watchers_count":28,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":5,"forks":29,"open_issues":5,"watchers":28,"default_branch":"qa/2.2.x"}},"_links":{"self":{"href":"https://api.github.com/repos/artefactual/atom/pulls/135"},"html":{"href":"https://github.com/artefactual/atom/pull/135"},"issue":{"href":"https://api.github.com/repos/artefactual/atom/issues/135"},"comments":{"href":"https://api.github.com/repos/artefactual/atom/issues/135/comments"},"review_comments":{"href":"https://api.github.com/repos/artefactual/atom/pulls/135/comments"},"review_comment":{"href":"https://api.github.com/repos/artefactual/atom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/artefactual/atom/pulls/135/commits"},"statuses":{"href":"https://api.github.com/repos/artefactual/atom/statuses/e4a4c534627ed59bd5632f7e0f951bbca5031826"}}}}