{"action":"created","comment":{"url":"https://api.github.com/repos/solnic/virtus/pulls/comments/46142376","id":46142376,"diff_hunk":"@@ -3,7 +3,16 @@\n describe Virtus::Attribute, '#set_default_value' do\n   let(:object) { described_class.build(String, options.merge(:name => name, :default => default)) }\n \n-  let(:model)    { Class.new { def name; 'model'; end; attr_reader :test } }","path":"spec/unit/virtus/attribute/set_default_value_spec.rb","position":4,"original_position":4,"commit_id":"11ed81cd89d44b750a623d9c078a779509eb691b","original_commit_id":"11ed81cd89d44b750a623d9c078a779509eb691b","user":{"login":"envygeeks","id":99763,"avatar_url":"https://avatars.githubusercontent.com/u/99763?v=3","gravatar_id":"","url":"https://api.github.com/users/envygeeks","html_url":"https://github.com/envygeeks","followers_url":"https://api.github.com/users/envygeeks/followers","following_url":"https://api.github.com/users/envygeeks/following{/other_user}","gists_url":"https://api.github.com/users/envygeeks/gists{/gist_id}","starred_url":"https://api.github.com/users/envygeeks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envygeeks/subscriptions","organizations_url":"https://api.github.com/users/envygeeks/orgs","repos_url":"https://api.github.com/users/envygeeks/repos","events_url":"https://api.github.com/users/envygeeks/events{/privacy}","received_events_url":"https://api.github.com/users/envygeeks/received_events","type":"User","site_admin":false},"body":"I agree, that onel iner is pretty hard to read.","created_at":"2015-11-30T13:32:10Z","updated_at":"2015-11-30T13:32:10Z","html_url":"https://github.com/solnic/virtus/pull/349#discussion_r46142376","pull_request_url":"https://api.github.com/repos/solnic/virtus/pulls/349","_links":{"self":{"href":"https://api.github.com/repos/solnic/virtus/pulls/comments/46142376"},"html":{"href":"https://github.com/solnic/virtus/pull/349#discussion_r46142376"},"pull_request":{"href":"https://api.github.com/repos/solnic/virtus/pulls/349"}}},"pull_request":{"url":"https://api.github.com/repos/solnic/virtus/pulls/349","id":50992757,"html_url":"https://github.com/solnic/virtus/pull/349","diff_url":"https://github.com/solnic/virtus/pull/349.diff","patch_url":"https://github.com/solnic/virtus/pull/349.patch","issue_url":"https://api.github.com/repos/solnic/virtus/issues/349","number":349,"state":"open","locked":false,"title":"Integrated RuboCop as part of the build.","user":{"login":"dblock","id":542335,"avatar_url":"https://avatars.githubusercontent.com/u/542335?v=3","gravatar_id":"","url":"https://api.github.com/users/dblock","html_url":"https://github.com/dblock","followers_url":"https://api.github.com/users/dblock/followers","following_url":"https://api.github.com/users/dblock/following{/other_user}","gists_url":"https://api.github.com/users/dblock/gists{/gist_id}","starred_url":"https://api.github.com/users/dblock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dblock/subscriptions","organizations_url":"https://api.github.com/users/dblock/orgs","repos_url":"https://api.github.com/users/dblock/repos","events_url":"https://api.github.com/users/dblock/events{/privacy}","received_events_url":"https://api.github.com/users/dblock/received_events","type":"User","site_admin":false},"body":"Something discussed in https://github.com/solnic/virtus/pull/343. \r\n\r\nFor a contributing developer the build would fail on something like what is being added as part of feedback in #343. This also removes any conversation about style, Rubocop just enforces those automagically. I first ran `rubocop -a`, then `rubocop --auto-gen-config` and reviewed some infrequent violations and fixed them by hand. ","created_at":"2015-11-17T19:32:14Z","updated_at":"2015-11-30T13:32:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"137c3469177385dcf251f31efe6b15f7b077f4f3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/solnic/virtus/pulls/349/commits","review_comments_url":"https://api.github.com/repos/solnic/virtus/pulls/349/comments","review_comment_url":"https://api.github.com/repos/solnic/virtus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/solnic/virtus/issues/349/comments","statuses_url":"https://api.github.com/repos/solnic/virtus/statuses/11ed81cd89d44b750a623d9c078a779509eb691b","head":{"label":"dblock:rubocop","ref":"rubocop","sha":"11ed81cd89d44b750a623d9c078a779509eb691b","user":{"login":"dblock","id":542335,"avatar_url":"https://avatars.githubusercontent.com/u/542335?v=3","gravatar_id":"","url":"https://api.github.com/users/dblock","html_url":"https://github.com/dblock","followers_url":"https://api.github.com/users/dblock/followers","following_url":"https://api.github.com/users/dblock/following{/other_user}","gists_url":"https://api.github.com/users/dblock/gists{/gist_id}","starred_url":"https://api.github.com/users/dblock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dblock/subscriptions","organizations_url":"https://api.github.com/users/dblock/orgs","repos_url":"https://api.github.com/users/dblock/repos","events_url":"https://api.github.com/users/dblock/events{/privacy}","received_events_url":"https://api.github.com/users/dblock/received_events","type":"User","site_admin":false},"repo":{"id":46368986,"name":"virtus","full_name":"dblock/virtus","owner":{"login":"dblock","id":542335,"avatar_url":"https://avatars.githubusercontent.com/u/542335?v=3","gravatar_id":"","url":"https://api.github.com/users/dblock","html_url":"https://github.com/dblock","followers_url":"https://api.github.com/users/dblock/followers","following_url":"https://api.github.com/users/dblock/following{/other_user}","gists_url":"https://api.github.com/users/dblock/gists{/gist_id}","starred_url":"https://api.github.com/users/dblock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dblock/subscriptions","organizations_url":"https://api.github.com/users/dblock/orgs","repos_url":"https://api.github.com/users/dblock/repos","events_url":"https://api.github.com/users/dblock/events{/privacy}","received_events_url":"https://api.github.com/users/dblock/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dblock/virtus","description":"Attributes on Steroids for Plain Old Ruby Objects","fork":true,"url":"https://api.github.com/repos/dblock/virtus","forks_url":"https://api.github.com/repos/dblock/virtus/forks","keys_url":"https://api.github.com/repos/dblock/virtus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dblock/virtus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dblock/virtus/teams","hooks_url":"https://api.github.com/repos/dblock/virtus/hooks","issue_events_url":"https://api.github.com/repos/dblock/virtus/issues/events{/number}","events_url":"https://api.github.com/repos/dblock/virtus/events","assignees_url":"https://api.github.com/repos/dblock/virtus/assignees{/user}","branches_url":"https://api.github.com/repos/dblock/virtus/branches{/branch}","tags_url":"https://api.github.com/repos/dblock/virtus/tags","blobs_url":"https://api.github.com/repos/dblock/virtus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dblock/virtus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dblock/virtus/git/refs{/sha}","trees_url":"https://api.github.com/repos/dblock/virtus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dblock/virtus/statuses/{sha}","languages_url":"https://api.github.com/repos/dblock/virtus/languages","stargazers_url":"https://api.github.com/repos/dblock/virtus/stargazers","contributors_url":"https://api.github.com/repos/dblock/virtus/contributors","subscribers_url":"https://api.github.com/repos/dblock/virtus/subscribers","subscription_url":"https://api.github.com/repos/dblock/virtus/subscription","commits_url":"https://api.github.com/repos/dblock/virtus/commits{/sha}","git_commits_url":"https://api.github.com/repos/dblock/virtus/git/commits{/sha}","comments_url":"https://api.github.com/repos/dblock/virtus/comments{/number}","issue_comment_url":"https://api.github.com/repos/dblock/virtus/issues/comments{/number}","contents_url":"https://api.github.com/repos/dblock/virtus/contents/{+path}","compare_url":"https://api.github.com/repos/dblock/virtus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dblock/virtus/merges","archive_url":"https://api.github.com/repos/dblock/virtus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dblock/virtus/downloads","issues_url":"https://api.github.com/repos/dblock/virtus/issues{/number}","pulls_url":"https://api.github.com/repos/dblock/virtus/pulls{/number}","milestones_url":"https://api.github.com/repos/dblock/virtus/milestones{/number}","notifications_url":"https://api.github.com/repos/dblock/virtus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dblock/virtus/labels{/name}","releases_url":"https://api.github.com/repos/dblock/virtus/releases{/id}","created_at":"2015-11-17T19:07:39Z","updated_at":"2015-11-17T19:07:40Z","pushed_at":"2015-11-18T14:55:32Z","git_url":"git://github.com/dblock/virtus.git","ssh_url":"git@github.com:dblock/virtus.git","clone_url":"https://github.com/dblock/virtus.git","svn_url":"https://github.com/dblock/virtus","homepage":"","size":2116,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"solnic:master","ref":"master","sha":"3248a465643b86d7fcb0c16fe6937293adbd1055","user":{"login":"solnic","id":1066,"avatar_url":"https://avatars.githubusercontent.com/u/1066?v=3","gravatar_id":"","url":"https://api.github.com/users/solnic","html_url":"https://github.com/solnic","followers_url":"https://api.github.com/users/solnic/followers","following_url":"https://api.github.com/users/solnic/following{/other_user}","gists_url":"https://api.github.com/users/solnic/gists{/gist_id}","starred_url":"https://api.github.com/users/solnic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solnic/subscriptions","organizations_url":"https://api.github.com/users/solnic/orgs","repos_url":"https://api.github.com/users/solnic/repos","events_url":"https://api.github.com/users/solnic/events{/privacy}","received_events_url":"https://api.github.com/users/solnic/received_events","type":"User","site_admin":false},"repo":{"id":1559931,"name":"virtus","full_name":"solnic/virtus","owner":{"login":"solnic","id":1066,"avatar_url":"https://avatars.githubusercontent.com/u/1066?v=3","gravatar_id":"","url":"https://api.github.com/users/solnic","html_url":"https://github.com/solnic","followers_url":"https://api.github.com/users/solnic/followers","following_url":"https://api.github.com/users/solnic/following{/other_user}","gists_url":"https://api.github.com/users/solnic/gists{/gist_id}","starred_url":"https://api.github.com/users/solnic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solnic/subscriptions","organizations_url":"https://api.github.com/users/solnic/orgs","repos_url":"https://api.github.com/users/solnic/repos","events_url":"https://api.github.com/users/solnic/events{/privacy}","received_events_url":"https://api.github.com/users/solnic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/solnic/virtus","description":"Attributes on Steroids for Plain Old Ruby Objects","fork":false,"url":"https://api.github.com/repos/solnic/virtus","forks_url":"https://api.github.com/repos/solnic/virtus/forks","keys_url":"https://api.github.com/repos/solnic/virtus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solnic/virtus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solnic/virtus/teams","hooks_url":"https://api.github.com/repos/solnic/virtus/hooks","issue_events_url":"https://api.github.com/repos/solnic/virtus/issues/events{/number}","events_url":"https://api.github.com/repos/solnic/virtus/events","assignees_url":"https://api.github.com/repos/solnic/virtus/assignees{/user}","branches_url":"https://api.github.com/repos/solnic/virtus/branches{/branch}","tags_url":"https://api.github.com/repos/solnic/virtus/tags","blobs_url":"https://api.github.com/repos/solnic/virtus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solnic/virtus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solnic/virtus/git/refs{/sha}","trees_url":"https://api.github.com/repos/solnic/virtus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solnic/virtus/statuses/{sha}","languages_url":"https://api.github.com/repos/solnic/virtus/languages","stargazers_url":"https://api.github.com/repos/solnic/virtus/stargazers","contributors_url":"https://api.github.com/repos/solnic/virtus/contributors","subscribers_url":"https://api.github.com/repos/solnic/virtus/subscribers","subscription_url":"https://api.github.com/repos/solnic/virtus/subscription","commits_url":"https://api.github.com/repos/solnic/virtus/commits{/sha}","git_commits_url":"https://api.github.com/repos/solnic/virtus/git/commits{/sha}","comments_url":"https://api.github.com/repos/solnic/virtus/comments{/number}","issue_comment_url":"https://api.github.com/repos/solnic/virtus/issues/comments{/number}","contents_url":"https://api.github.com/repos/solnic/virtus/contents/{+path}","compare_url":"https://api.github.com/repos/solnic/virtus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solnic/virtus/merges","archive_url":"https://api.github.com/repos/solnic/virtus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solnic/virtus/downloads","issues_url":"https://api.github.com/repos/solnic/virtus/issues{/number}","pulls_url":"https://api.github.com/repos/solnic/virtus/pulls{/number}","milestones_url":"https://api.github.com/repos/solnic/virtus/milestones{/number}","notifications_url":"https://api.github.com/repos/solnic/virtus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solnic/virtus/labels{/name}","releases_url":"https://api.github.com/repos/solnic/virtus/releases{/id}","created_at":"2011-04-02T16:23:50Z","updated_at":"2015-11-29T06:47:29Z","pushed_at":"2015-11-18T14:55:33Z","git_url":"git://github.com/solnic/virtus.git","ssh_url":"git@github.com:solnic/virtus.git","clone_url":"https://github.com/solnic/virtus.git","svn_url":"https://github.com/solnic/virtus","homepage":"","size":3474,"stargazers_count":2904,"watchers_count":2904,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":189,"mirror_url":null,"open_issues_count":46,"forks":189,"open_issues":46,"watchers":2904,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/solnic/virtus/pulls/349"},"html":{"href":"https://github.com/solnic/virtus/pull/349"},"issue":{"href":"https://api.github.com/repos/solnic/virtus/issues/349"},"comments":{"href":"https://api.github.com/repos/solnic/virtus/issues/349/comments"},"review_comments":{"href":"https://api.github.com/repos/solnic/virtus/pulls/349/comments"},"review_comment":{"href":"https://api.github.com/repos/solnic/virtus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/solnic/virtus/pulls/349/commits"},"statuses":{"href":"https://api.github.com/repos/solnic/virtus/statuses/11ed81cd89d44b750a623d9c078a779509eb691b"}}}}