{"action":"created","issue":{"url":"https://api.github.com/repos/wgroeneveld/jasmine-junit-runner/issues/21","labels_url":"https://api.github.com/repos/wgroeneveld/jasmine-junit-runner/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/wgroeneveld/jasmine-junit-runner/issues/21/comments","events_url":"https://api.github.com/repos/wgroeneveld/jasmine-junit-runner/issues/21/events","html_url":"https://github.com/wgroeneveld/jasmine-junit-runner/pull/21","id":65246920,"number":21,"title":"Call RunNotifier's fireTestFinished() method for failed tests","user":{"login":"jdobson","id":4191257,"avatar_url":"https://avatars.githubusercontent.com/u/4191257?v=3","gravatar_id":"","url":"https://api.github.com/users/jdobson","html_url":"https://github.com/jdobson","followers_url":"https://api.github.com/users/jdobson/followers","following_url":"https://api.github.com/users/jdobson/following{/other_user}","gists_url":"https://api.github.com/users/jdobson/gists{/gist_id}","starred_url":"https://api.github.com/users/jdobson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdobson/subscriptions","organizations_url":"https://api.github.com/users/jdobson/orgs","repos_url":"https://api.github.com/users/jdobson/repos","events_url":"https://api.github.com/users/jdobson/events{/privacy}","received_events_url":"https://api.github.com/users/jdobson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-30T16:12:39Z","updated_at":"2015-05-21T09:08:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/wgroeneveld/jasmine-junit-runner/pulls/21","html_url":"https://github.com/wgroeneveld/jasmine-junit-runner/pull/21","diff_url":"https://github.com/wgroeneveld/jasmine-junit-runner/pull/21.diff","patch_url":"https://github.com/wgroeneveld/jasmine-junit-runner/pull/21.patch"},"body":"This is to address problems I had using the plugin with a Gradle build.  My test failures were reported fine by the IDEA test runner, however failed tests would be reported as if they had not run by the Gradle test runner (rather than as failures).  This appears to be due to the expectation of balanced calls to the RunNotifier fireTestStarted() and fireTestFinished() methods, even for failed tests (see RunNotifier javadoc).  Hence the changes below.  This tweak fixed the behaviour in Gradle, and IDEA still happily runs the tests. What do you think?"},"comment":{"url":"https://api.github.com/repos/wgroeneveld/jasmine-junit-runner/issues/comments/104188602","html_url":"https://github.com/wgroeneveld/jasmine-junit-runner/pull/21#issuecomment-104188602","issue_url":"https://api.github.com/repos/wgroeneveld/jasmine-junit-runner/issues/21","id":104188602,"user":{"login":"wgroeneveld","id":304593,"avatar_url":"https://avatars.githubusercontent.com/u/304593?v=3","gravatar_id":"","url":"https://api.github.com/users/wgroeneveld","html_url":"https://github.com/wgroeneveld","followers_url":"https://api.github.com/users/wgroeneveld/followers","following_url":"https://api.github.com/users/wgroeneveld/following{/other_user}","gists_url":"https://api.github.com/users/wgroeneveld/gists{/gist_id}","starred_url":"https://api.github.com/users/wgroeneveld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wgroeneveld/subscriptions","organizations_url":"https://api.github.com/users/wgroeneveld/orgs","repos_url":"https://api.github.com/users/wgroeneveld/repos","events_url":"https://api.github.com/users/wgroeneveld/events{/privacy}","received_events_url":"https://api.github.com/users/wgroeneveld/received_events","type":"User","site_admin":false},"created_at":"2015-05-21T09:08:49Z","updated_at":"2015-05-21T09:08:49Z","body":"thanks for pointing that out! finished should always be called. "}}