{"action":"closed","number":250,"pull_request":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/250","id":46281778,"html_url":"https://github.com/ocaml/ocaml/pull/250","diff_url":"https://github.com/ocaml/ocaml/pull/250.diff","patch_url":"https://github.com/ocaml/ocaml/pull/250.patch","issue_url":"https://api.github.com/repos/ocaml/ocaml/issues/250","number":250,"state":"closed","locked":false,"title":"Check for negative start element in Array.sub","user":{"login":"yallop","id":1736496,"avatar_url":"https://avatars.githubusercontent.com/u/1736496?v=3","gravatar_id":"","url":"https://api.github.com/users/yallop","html_url":"https://github.com/yallop","followers_url":"https://api.github.com/users/yallop/followers","following_url":"https://api.github.com/users/yallop/following{/other_user}","gists_url":"https://api.github.com/users/yallop/gists{/gist_id}","starred_url":"https://api.github.com/users/yallop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yallop/subscriptions","organizations_url":"https://api.github.com/users/yallop/orgs","repos_url":"https://api.github.com/users/yallop/repos","events_url":"https://api.github.com/users/yallop/events{/privacy}","received_events_url":"https://api.github.com/users/yallop/received_events","type":"User","site_admin":false},"body":"Before:\r\n\r\n```ocaml\r\n# Array.sub [|0;1|] (-1) 1;;\r\n- : int array = [|1408|]\r\n# Array.sub [|0;1|] (-1000000) 1000000;;\r\nSegmentation fault\r\n```\r\n\r\nAfter:\r\n\r\n```ocaml\r\n# Array.sub [|0;1|] (-1) 1;;\r\nException: Invalid_argument \"Array.sub\".\r\n# Array.sub [|0;1|] (-1000000) 1000000;;\r\nException: Invalid_argument \"Array.sub\".\r\n```\r\n","created_at":"2015-09-29T14:10:03Z","updated_at":"2015-10-05T09:31:33Z","closed_at":"2015-10-05T09:31:33Z","merged_at":null,"merge_commit_sha":"9d72a1de6259adb47dd3d7f9da451f0621b1096f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ocaml/ocaml/pulls/250/commits","review_comments_url":"https://api.github.com/repos/ocaml/ocaml/pulls/250/comments","review_comment_url":"https://api.github.com/repos/ocaml/ocaml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ocaml/ocaml/issues/250/comments","statuses_url":"https://api.github.com/repos/ocaml/ocaml/statuses/73ad33cce0f545617c97354fd74661a7143cb540","head":{"label":"yallop:array-sub-bounds-check","ref":"array-sub-bounds-check","sha":"73ad33cce0f545617c97354fd74661a7143cb540","user":{"login":"yallop","id":1736496,"avatar_url":"https://avatars.githubusercontent.com/u/1736496?v=3","gravatar_id":"","url":"https://api.github.com/users/yallop","html_url":"https://github.com/yallop","followers_url":"https://api.github.com/users/yallop/followers","following_url":"https://api.github.com/users/yallop/following{/other_user}","gists_url":"https://api.github.com/users/yallop/gists{/gist_id}","starred_url":"https://api.github.com/users/yallop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yallop/subscriptions","organizations_url":"https://api.github.com/users/yallop/orgs","repos_url":"https://api.github.com/users/yallop/repos","events_url":"https://api.github.com/users/yallop/events{/privacy}","received_events_url":"https://api.github.com/users/yallop/received_events","type":"User","site_admin":false},"repo":{"id":7024227,"name":"ocaml","full_name":"yallop/ocaml","owner":{"login":"yallop","id":1736496,"avatar_url":"https://avatars.githubusercontent.com/u/1736496?v=3","gravatar_id":"","url":"https://api.github.com/users/yallop","html_url":"https://github.com/yallop","followers_url":"https://api.github.com/users/yallop/followers","following_url":"https://api.github.com/users/yallop/following{/other_user}","gists_url":"https://api.github.com/users/yallop/gists{/gist_id}","starred_url":"https://api.github.com/users/yallop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yallop/subscriptions","organizations_url":"https://api.github.com/users/yallop/orgs","repos_url":"https://api.github.com/users/yallop/repos","events_url":"https://api.github.com/users/yallop/events{/privacy}","received_events_url":"https://api.github.com/users/yallop/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yallop/ocaml","description":"Read-only mirror of INRIA SVN","fork":true,"url":"https://api.github.com/repos/yallop/ocaml","forks_url":"https://api.github.com/repos/yallop/ocaml/forks","keys_url":"https://api.github.com/repos/yallop/ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yallop/ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yallop/ocaml/teams","hooks_url":"https://api.github.com/repos/yallop/ocaml/hooks","issue_events_url":"https://api.github.com/repos/yallop/ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/yallop/ocaml/events","assignees_url":"https://api.github.com/repos/yallop/ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/yallop/ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/yallop/ocaml/tags","blobs_url":"https://api.github.com/repos/yallop/ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yallop/ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yallop/ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/yallop/ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yallop/ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/yallop/ocaml/languages","stargazers_url":"https://api.github.com/repos/yallop/ocaml/stargazers","contributors_url":"https://api.github.com/repos/yallop/ocaml/contributors","subscribers_url":"https://api.github.com/repos/yallop/ocaml/subscribers","subscription_url":"https://api.github.com/repos/yallop/ocaml/subscription","commits_url":"https://api.github.com/repos/yallop/ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/yallop/ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/yallop/ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/yallop/ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/yallop/ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/yallop/ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yallop/ocaml/merges","archive_url":"https://api.github.com/repos/yallop/ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yallop/ocaml/downloads","issues_url":"https://api.github.com/repos/yallop/ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/yallop/ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/yallop/ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/yallop/ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yallop/ocaml/labels{/name}","releases_url":"https://api.github.com/repos/yallop/ocaml/releases{/id}","created_at":"2012-12-05T20:38:01Z","updated_at":"2015-01-22T22:17:32Z","pushed_at":"2015-10-05T09:22:03Z","git_url":"git://github.com/yallop/ocaml.git","ssh_url":"git@github.com:yallop/ocaml.git","clone_url":"https://github.com/yallop/ocaml.git","svn_url":"https://github.com/yallop/ocaml","homepage":null,"size":103690,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"ocaml:trunk","ref":"trunk","sha":"53fff352723eddd14baac86bc5fd187b4c74223b","user":{"login":"ocaml","id":1841483,"avatar_url":"https://avatars.githubusercontent.com/u/1841483?v=3","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"repo":{"id":6786166,"name":"ocaml","full_name":"ocaml/ocaml","owner":{"login":"ocaml","id":1841483,"avatar_url":"https://avatars.githubusercontent.com/u/1841483?v=3","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocaml/ocaml","description":"Read-only mirror of INRIA SVN","fork":false,"url":"https://api.github.com/repos/ocaml/ocaml","forks_url":"https://api.github.com/repos/ocaml/ocaml/forks","keys_url":"https://api.github.com/repos/ocaml/ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocaml/ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocaml/ocaml/teams","hooks_url":"https://api.github.com/repos/ocaml/ocaml/hooks","issue_events_url":"https://api.github.com/repos/ocaml/ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/ocaml/ocaml/events","assignees_url":"https://api.github.com/repos/ocaml/ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/ocaml/ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/ocaml/ocaml/tags","blobs_url":"https://api.github.com/repos/ocaml/ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocaml/ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocaml/ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocaml/ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocaml/ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/ocaml/ocaml/languages","stargazers_url":"https://api.github.com/repos/ocaml/ocaml/stargazers","contributors_url":"https://api.github.com/repos/ocaml/ocaml/contributors","subscribers_url":"https://api.github.com/repos/ocaml/ocaml/subscribers","subscription_url":"https://api.github.com/repos/ocaml/ocaml/subscription","commits_url":"https://api.github.com/repos/ocaml/ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocaml/ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocaml/ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocaml/ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocaml/ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/ocaml/ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocaml/ocaml/merges","archive_url":"https://api.github.com/repos/ocaml/ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocaml/ocaml/downloads","issues_url":"https://api.github.com/repos/ocaml/ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/ocaml/ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/ocaml/ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/ocaml/ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocaml/ocaml/labels{/name}","releases_url":"https://api.github.com/repos/ocaml/ocaml/releases{/id}","created_at":"2012-11-20T22:18:22Z","updated_at":"2015-10-03T06:02:31Z","pushed_at":"2015-10-05T09:04:16Z","git_url":"git://github.com/ocaml/ocaml.git","ssh_url":"git@github.com:ocaml/ocaml.git","clone_url":"https://github.com/ocaml/ocaml.git","svn_url":"https://github.com/ocaml/ocaml","homepage":null,"size":178101,"stargazers_count":447,"watchers_count":447,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":171,"mirror_url":null,"open_issues_count":78,"forks":171,"open_issues":78,"watchers":447,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/250"},"html":{"href":"https://github.com/ocaml/ocaml/pull/250"},"issue":{"href":"https://api.github.com/repos/ocaml/ocaml/issues/250"},"comments":{"href":"https://api.github.com/repos/ocaml/ocaml/issues/250/comments"},"review_comments":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/250/comments"},"review_comment":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/250/commits"},"statuses":{"href":"https://api.github.com/repos/ocaml/ocaml/statuses/73ad33cce0f545617c97354fd74661a7143cb540"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":16,"review_comments":0,"commits":2,"additions":4,"deletions":1,"changed_files":2}}