{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/32378305","id":32378305,"diff_hunk":"@@ -0,0 +1,51 @@\n+<?php\n+\n+namespace Symfony\\Bundle\\SecurityBundle\\ArgumentResolver;\n+\n+use Symfony\\Component\\HttpFoundation\\Request;\n+use Symfony\\Component\\HttpKernel\\Controller\\ArgumentResolver\\ArgumentResolverInterface;\n+use Symfony\\Component\\Security\\Core\\Authentication\\Token\\Storage\\TokenStorageInterface;\n+\n+/**\n+ * @author Wouter J <wouter@wouterj.nl>\n+ */\n+class UserArgumentResolver implements ArgumentResolverInterface","path":"src/Symfony/Bundle/SecurityBundle/ArgumentResolver/UserArgumentResolver.php","position":12,"original_position":12,"commit_id":"3a1d99cf2e52604c75cf04f9e5796af36b69666e","original_commit_id":"3a1d99cf2e52604c75cf04f9e5796af36b69666e","user":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=3","gravatar_id":"","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"body":"Sorry, I'm not sure I understand what you try to say.","created_at":"2015-06-14T10:51:47Z","updated_at":"2015-06-14T10:51:47Z","html_url":"https://github.com/symfony/symfony/pull/14971#discussion_r32378305","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/14971","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/32378305"},"html":{"href":"https://github.com/symfony/symfony/pull/14971#discussion_r32378305"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/14971"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/14971","id":37626441,"html_url":"https://github.com/symfony/symfony/pull/14971","diff_url":"https://github.com/symfony/symfony/pull/14971.diff","patch_url":"https://github.com/symfony/symfony/pull/14971.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/14971","number":14971,"state":"open","locked":false,"title":"[2.8] Move argument resolving from ControllerResolver","user":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=3","gravatar_id":"","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"body":"Description\r\n---\r\n\r\nThis closes #11457. Changes since that PR:\r\n\r\n * The ControllerResolver has a new method `setArgumentResolver`, too keep BC with people overriding `ControllerResolver#doGetArguments`\r\n * Deprecations instead of removal, so it can be merged into 2.8\r\n * Added 2 new argument resolvers: A Security user resolver (which was the original problem to create this PR) and a PSR Request resolver\r\n\r\nPR Info Table\r\n---\r\n\r\n| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | no\r\n| Deprecations? | yes\r\n| Tests pass?   | yes\r\n| Fixed tickets | #1547, #10710\r\n| License       | MIT\r\n| Doc PR        | tbd\r\n\r\nTodo\r\n---\r\n\r\n * [ ] Add priority (is this actually needed?)\r\n * [ ] Make tests pass\r\n * [ ] Update docs","created_at":"2015-06-13T15:25:47Z","updated_at":"2015-06-14T10:51:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f955f88363fb1fbb4344b4a2ceb4548f79579b76","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/14971/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/14971/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/14971/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/3a1d99cf2e52604c75cf04f9e5796af36b69666e","head":{"label":"WouterJ:pr_11457","ref":"pr_11457","sha":"3a1d99cf2e52604c75cf04f9e5796af36b69666e","user":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=3","gravatar_id":"","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"repo":{"id":5615183,"name":"symfony","full_name":"WouterJ/symfony","owner":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=3","gravatar_id":"","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/WouterJ/symfony","description":"The Symfony2 PHP framework","fork":true,"url":"https://api.github.com/repos/WouterJ/symfony","forks_url":"https://api.github.com/repos/WouterJ/symfony/forks","keys_url":"https://api.github.com/repos/WouterJ/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WouterJ/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WouterJ/symfony/teams","hooks_url":"https://api.github.com/repos/WouterJ/symfony/hooks","issue_events_url":"https://api.github.com/repos/WouterJ/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/WouterJ/symfony/events","assignees_url":"https://api.github.com/repos/WouterJ/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/WouterJ/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/WouterJ/symfony/tags","blobs_url":"https://api.github.com/repos/WouterJ/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WouterJ/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WouterJ/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/WouterJ/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WouterJ/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/WouterJ/symfony/languages","stargazers_url":"https://api.github.com/repos/WouterJ/symfony/stargazers","contributors_url":"https://api.github.com/repos/WouterJ/symfony/contributors","subscribers_url":"https://api.github.com/repos/WouterJ/symfony/subscribers","subscription_url":"https://api.github.com/repos/WouterJ/symfony/subscription","commits_url":"https://api.github.com/repos/WouterJ/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/WouterJ/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/WouterJ/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/WouterJ/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/WouterJ/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/WouterJ/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WouterJ/symfony/merges","archive_url":"https://api.github.com/repos/WouterJ/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WouterJ/symfony/downloads","issues_url":"https://api.github.com/repos/WouterJ/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/WouterJ/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/WouterJ/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/WouterJ/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WouterJ/symfony/labels{/name}","releases_url":"https://api.github.com/repos/WouterJ/symfony/releases{/id}","created_at":"2012-08-30T13:24:57Z","updated_at":"2014-08-16T18:38:32Z","pushed_at":"2015-06-13T22:31:13Z","git_url":"git://github.com/WouterJ/symfony.git","ssh_url":"git@github.com:WouterJ/symfony.git","clone_url":"https://github.com/WouterJ/symfony.git","svn_url":"https://github.com/WouterJ/symfony","homepage":"symfony.com","size":56750,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:2.8","ref":"2.8","sha":"5f36605e0e2264a1f52a8caa4bbe35a6f4ece8b4","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","created_at":"2010-01-04T14:21:21Z","updated_at":"2015-06-14T01:50:46Z","pushed_at":"2015-06-14T05:00:15Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":1192589,"stargazers_count":10331,"watchers_count":10331,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4083,"mirror_url":null,"open_issues_count":856,"forks":4083,"open_issues":856,"watchers":10331,"default_branch":"2.8"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/14971"},"html":{"href":"https://github.com/symfony/symfony/pull/14971"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/14971"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/14971/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/14971/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/14971/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/3a1d99cf2e52604c75cf04f9e5796af36b69666e"}}}}