{"action":"created","comment":{"url":"https://api.github.com/repos/flightjs/flight/pulls/comments/43348245","id":43348245,"diff_hunk":"@@ -221,6 +221,29 @@ define(['lib/component', 'lib/registry', 'lib/dom'], function (defineComponent,\n       expect(spy).toHaveBeenCalled();\n     });\n \n+    it('can be attached to any special element', function () {\n+      var instance1 = (new Component).initialize(window.innerDiv);\n+      var instance2 = (new Component).initialize(window.outerDiv);\n+\n+      var specialElements = [\n+        window,\n+        document,\n+        document.body,\n+        document.documentElement,\n+        'html',\n+        'body'\n+      ];\n+\n+      specialElements.forEach(function (element) {\n+        var spy = jasmine.createSpy(element.toString());\n+        instance2.on(element, 'click', spy);\n+        instance1.trigger('click');\n+        instance2.off(element, 'click');\n+        instance1.trigger('click');\n+        expect(spy.callCount).toBe(1);","path":"test/spec/events_spec.js","position":29,"original_position":29,"commit_id":"bc4b2e3b2a84a31e8b6a6fb7784888f8d035477b","original_commit_id":"bc4b2e3b2a84a31e8b6a6fb7784888f8d035477b","user":{"login":"giuseppeg","id":711311,"avatar_url":"https://avatars.githubusercontent.com/u/711311?v=3","gravatar_id":"","url":"https://api.github.com/users/giuseppeg","html_url":"https://github.com/giuseppeg","followers_url":"https://api.github.com/users/giuseppeg/followers","following_url":"https://api.github.com/users/giuseppeg/following{/other_user}","gists_url":"https://api.github.com/users/giuseppeg/gists{/gist_id}","starred_url":"https://api.github.com/users/giuseppeg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giuseppeg/subscriptions","organizations_url":"https://api.github.com/users/giuseppeg/orgs","repos_url":"https://api.github.com/users/giuseppeg/repos","events_url":"https://api.github.com/users/giuseppeg/events{/privacy}","received_events_url":"https://api.github.com/users/giuseppeg/received_events","type":"User","site_admin":false},"body":"we are using an old version of jasmine :(","created_at":"2015-10-29T04:33:54Z","updated_at":"2015-10-29T04:33:54Z","html_url":"https://github.com/flightjs/flight/pull/371#discussion_r43348245","pull_request_url":"https://api.github.com/repos/flightjs/flight/pulls/371","_links":{"self":{"href":"https://api.github.com/repos/flightjs/flight/pulls/comments/43348245"},"html":{"href":"https://github.com/flightjs/flight/pull/371#discussion_r43348245"},"pull_request":{"href":"https://api.github.com/repos/flightjs/flight/pulls/371"}}},"pull_request":{"url":"https://api.github.com/repos/flightjs/flight/pulls/371","id":49097697,"html_url":"https://github.com/flightjs/flight/pull/371","diff_url":"https://github.com/flightjs/flight/pull/371.diff","patch_url":"https://github.com/flightjs/flight/pull/371.patch","issue_url":"https://api.github.com/repos/flightjs/flight/issues/371","number":371,"state":"open","locked":false,"title":"Fix dom select[All]","user":{"login":"giuseppeg","id":711311,"avatar_url":"https://avatars.githubusercontent.com/u/711311?v=3","gravatar_id":"","url":"https://api.github.com/users/giuseppeg","html_url":"https://github.com/giuseppeg","followers_url":"https://api.github.com/users/giuseppeg/followers","following_url":"https://api.github.com/users/giuseppeg/following{/other_user}","gists_url":"https://api.github.com/users/giuseppeg/gists{/gist_id}","starred_url":"https://api.github.com/users/giuseppeg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giuseppeg/subscriptions","organizations_url":"https://api.github.com/users/giuseppeg/orgs","repos_url":"https://api.github.com/users/giuseppeg/repos","events_url":"https://api.github.com/users/giuseppeg/events{/privacy}","received_events_url":"https://api.github.com/users/giuseppeg/received_events","type":"User","site_admin":false},"body":"Fixes #368","created_at":"2015-10-29T04:29:48Z","updated_at":"2015-10-29T04:33:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3225c4178dca65aa8de3c6266a58aedc5d7d4100","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/flightjs/flight/pulls/371/commits","review_comments_url":"https://api.github.com/repos/flightjs/flight/pulls/371/comments","review_comment_url":"https://api.github.com/repos/flightjs/flight/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flightjs/flight/issues/371/comments","statuses_url":"https://api.github.com/repos/flightjs/flight/statuses/bc4b2e3b2a84a31e8b6a6fb7784888f8d035477b","head":{"label":"giuseppeg:fix-dom-select","ref":"fix-dom-select","sha":"bc4b2e3b2a84a31e8b6a6fb7784888f8d035477b","user":{"login":"giuseppeg","id":711311,"avatar_url":"https://avatars.githubusercontent.com/u/711311?v=3","gravatar_id":"","url":"https://api.github.com/users/giuseppeg","html_url":"https://github.com/giuseppeg","followers_url":"https://api.github.com/users/giuseppeg/followers","following_url":"https://api.github.com/users/giuseppeg/following{/other_user}","gists_url":"https://api.github.com/users/giuseppeg/gists{/gist_id}","starred_url":"https://api.github.com/users/giuseppeg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giuseppeg/subscriptions","organizations_url":"https://api.github.com/users/giuseppeg/orgs","repos_url":"https://api.github.com/users/giuseppeg/repos","events_url":"https://api.github.com/users/giuseppeg/events{/privacy}","received_events_url":"https://api.github.com/users/giuseppeg/received_events","type":"User","site_admin":false},"repo":{"id":16742239,"name":"flight","full_name":"giuseppeg/flight","owner":{"login":"giuseppeg","id":711311,"avatar_url":"https://avatars.githubusercontent.com/u/711311?v=3","gravatar_id":"","url":"https://api.github.com/users/giuseppeg","html_url":"https://github.com/giuseppeg","followers_url":"https://api.github.com/users/giuseppeg/followers","following_url":"https://api.github.com/users/giuseppeg/following{/other_user}","gists_url":"https://api.github.com/users/giuseppeg/gists{/gist_id}","starred_url":"https://api.github.com/users/giuseppeg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giuseppeg/subscriptions","organizations_url":"https://api.github.com/users/giuseppeg/orgs","repos_url":"https://api.github.com/users/giuseppeg/repos","events_url":"https://api.github.com/users/giuseppeg/events{/privacy}","received_events_url":"https://api.github.com/users/giuseppeg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/giuseppeg/flight","description":"A component-based, event-driven JavaScript framework from Twitter","fork":true,"url":"https://api.github.com/repos/giuseppeg/flight","forks_url":"https://api.github.com/repos/giuseppeg/flight/forks","keys_url":"https://api.github.com/repos/giuseppeg/flight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giuseppeg/flight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giuseppeg/flight/teams","hooks_url":"https://api.github.com/repos/giuseppeg/flight/hooks","issue_events_url":"https://api.github.com/repos/giuseppeg/flight/issues/events{/number}","events_url":"https://api.github.com/repos/giuseppeg/flight/events","assignees_url":"https://api.github.com/repos/giuseppeg/flight/assignees{/user}","branches_url":"https://api.github.com/repos/giuseppeg/flight/branches{/branch}","tags_url":"https://api.github.com/repos/giuseppeg/flight/tags","blobs_url":"https://api.github.com/repos/giuseppeg/flight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giuseppeg/flight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giuseppeg/flight/git/refs{/sha}","trees_url":"https://api.github.com/repos/giuseppeg/flight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giuseppeg/flight/statuses/{sha}","languages_url":"https://api.github.com/repos/giuseppeg/flight/languages","stargazers_url":"https://api.github.com/repos/giuseppeg/flight/stargazers","contributors_url":"https://api.github.com/repos/giuseppeg/flight/contributors","subscribers_url":"https://api.github.com/repos/giuseppeg/flight/subscribers","subscription_url":"https://api.github.com/repos/giuseppeg/flight/subscription","commits_url":"https://api.github.com/repos/giuseppeg/flight/commits{/sha}","git_commits_url":"https://api.github.com/repos/giuseppeg/flight/git/commits{/sha}","comments_url":"https://api.github.com/repos/giuseppeg/flight/comments{/number}","issue_comment_url":"https://api.github.com/repos/giuseppeg/flight/issues/comments{/number}","contents_url":"https://api.github.com/repos/giuseppeg/flight/contents/{+path}","compare_url":"https://api.github.com/repos/giuseppeg/flight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giuseppeg/flight/merges","archive_url":"https://api.github.com/repos/giuseppeg/flight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giuseppeg/flight/downloads","issues_url":"https://api.github.com/repos/giuseppeg/flight/issues{/number}","pulls_url":"https://api.github.com/repos/giuseppeg/flight/pulls{/number}","milestones_url":"https://api.github.com/repos/giuseppeg/flight/milestones{/number}","notifications_url":"https://api.github.com/repos/giuseppeg/flight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giuseppeg/flight/labels{/name}","releases_url":"https://api.github.com/repos/giuseppeg/flight/releases{/id}","created_at":"2014-02-11T19:23:09Z","updated_at":"2014-06-29T19:57:21Z","pushed_at":"2015-10-29T04:28:03Z","git_url":"git://github.com/giuseppeg/flight.git","ssh_url":"git@github.com:giuseppeg/flight.git","clone_url":"https://github.com/giuseppeg/flight.git","svn_url":"https://github.com/giuseppeg/flight","homepage":"http://flightjs.github.io/","size":805,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flightjs:master","ref":"master","sha":"be55d949f5dc98d2d162a2fba98854eff754535e","user":{"login":"flightjs","id":4271779,"avatar_url":"https://avatars.githubusercontent.com/u/4271779?v=3","gravatar_id":"","url":"https://api.github.com/users/flightjs","html_url":"https://github.com/flightjs","followers_url":"https://api.github.com/users/flightjs/followers","following_url":"https://api.github.com/users/flightjs/following{/other_user}","gists_url":"https://api.github.com/users/flightjs/gists{/gist_id}","starred_url":"https://api.github.com/users/flightjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flightjs/subscriptions","organizations_url":"https://api.github.com/users/flightjs/orgs","repos_url":"https://api.github.com/users/flightjs/repos","events_url":"https://api.github.com/users/flightjs/events{/privacy}","received_events_url":"https://api.github.com/users/flightjs/received_events","type":"Organization","site_admin":false},"repo":{"id":7922549,"name":"flight","full_name":"flightjs/flight","owner":{"login":"flightjs","id":4271779,"avatar_url":"https://avatars.githubusercontent.com/u/4271779?v=3","gravatar_id":"","url":"https://api.github.com/users/flightjs","html_url":"https://github.com/flightjs","followers_url":"https://api.github.com/users/flightjs/followers","following_url":"https://api.github.com/users/flightjs/following{/other_user}","gists_url":"https://api.github.com/users/flightjs/gists{/gist_id}","starred_url":"https://api.github.com/users/flightjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flightjs/subscriptions","organizations_url":"https://api.github.com/users/flightjs/orgs","repos_url":"https://api.github.com/users/flightjs/repos","events_url":"https://api.github.com/users/flightjs/events{/privacy}","received_events_url":"https://api.github.com/users/flightjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flightjs/flight","description":"A component-based, event-driven JavaScript framework from Twitter","fork":false,"url":"https://api.github.com/repos/flightjs/flight","forks_url":"https://api.github.com/repos/flightjs/flight/forks","keys_url":"https://api.github.com/repos/flightjs/flight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flightjs/flight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flightjs/flight/teams","hooks_url":"https://api.github.com/repos/flightjs/flight/hooks","issue_events_url":"https://api.github.com/repos/flightjs/flight/issues/events{/number}","events_url":"https://api.github.com/repos/flightjs/flight/events","assignees_url":"https://api.github.com/repos/flightjs/flight/assignees{/user}","branches_url":"https://api.github.com/repos/flightjs/flight/branches{/branch}","tags_url":"https://api.github.com/repos/flightjs/flight/tags","blobs_url":"https://api.github.com/repos/flightjs/flight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flightjs/flight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flightjs/flight/git/refs{/sha}","trees_url":"https://api.github.com/repos/flightjs/flight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flightjs/flight/statuses/{sha}","languages_url":"https://api.github.com/repos/flightjs/flight/languages","stargazers_url":"https://api.github.com/repos/flightjs/flight/stargazers","contributors_url":"https://api.github.com/repos/flightjs/flight/contributors","subscribers_url":"https://api.github.com/repos/flightjs/flight/subscribers","subscription_url":"https://api.github.com/repos/flightjs/flight/subscription","commits_url":"https://api.github.com/repos/flightjs/flight/commits{/sha}","git_commits_url":"https://api.github.com/repos/flightjs/flight/git/commits{/sha}","comments_url":"https://api.github.com/repos/flightjs/flight/comments{/number}","issue_comment_url":"https://api.github.com/repos/flightjs/flight/issues/comments{/number}","contents_url":"https://api.github.com/repos/flightjs/flight/contents/{+path}","compare_url":"https://api.github.com/repos/flightjs/flight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flightjs/flight/merges","archive_url":"https://api.github.com/repos/flightjs/flight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flightjs/flight/downloads","issues_url":"https://api.github.com/repos/flightjs/flight/issues{/number}","pulls_url":"https://api.github.com/repos/flightjs/flight/pulls{/number}","milestones_url":"https://api.github.com/repos/flightjs/flight/milestones{/number}","notifications_url":"https://api.github.com/repos/flightjs/flight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flightjs/flight/labels{/name}","releases_url":"https://api.github.com/repos/flightjs/flight/releases{/id}","created_at":"2013-01-30T19:59:30Z","updated_at":"2015-10-29T00:43:05Z","pushed_at":"2015-10-29T04:29:48Z","git_url":"git://github.com/flightjs/flight.git","ssh_url":"git@github.com:flightjs/flight.git","clone_url":"https://github.com/flightjs/flight.git","svn_url":"https://github.com/flightjs/flight","homepage":"http://flightjs.github.io/","size":3473,"stargazers_count":6338,"watchers_count":6338,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":574,"mirror_url":null,"open_issues_count":24,"forks":574,"open_issues":24,"watchers":6338,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flightjs/flight/pulls/371"},"html":{"href":"https://github.com/flightjs/flight/pull/371"},"issue":{"href":"https://api.github.com/repos/flightjs/flight/issues/371"},"comments":{"href":"https://api.github.com/repos/flightjs/flight/issues/371/comments"},"review_comments":{"href":"https://api.github.com/repos/flightjs/flight/pulls/371/comments"},"review_comment":{"href":"https://api.github.com/repos/flightjs/flight/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flightjs/flight/pulls/371/commits"},"statuses":{"href":"https://api.github.com/repos/flightjs/flight/statuses/bc4b2e3b2a84a31e8b6a6fb7784888f8d035477b"}}}}