{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/pulls/comments/35635416","id":35635416,"diff_hunk":"@@ -234,7 +237,18 @@ protected JFreeChart createChart(final GraphConfiguration configuration, final R\n         }\n         return valuesPerBuild;\n     }\n-\n+    private boolean passesFilteringByParameter(final AbstractBuild<?, ?> build, final String parameterName, final String parameterValue){\n+        if (parameterName == null){\n+            return true;\n+        }\n+        Map<String, String> vars = build.getBuildVariables();\n+        if(vars.containsKey(parameterName)){\n+            if (vars.get(parameterName).equals(parameterValue)) {","path":"src/main/java/hudson/plugins/analysis/graph/CategoryBuildResultGraph.java","position":29,"original_position":29,"commit_id":"361aaa612e7953e0bfe3ecab907908417bd62325","original_commit_id":"361aaa612e7953e0bfe3ecab907908417bd62325","user":{"login":"uhafner","id":503338,"avatar_url":"https://avatars.githubusercontent.com/u/503338?v=3","gravatar_id":"","url":"https://api.github.com/users/uhafner","html_url":"https://github.com/uhafner","followers_url":"https://api.github.com/users/uhafner/followers","following_url":"https://api.github.com/users/uhafner/following{/other_user}","gists_url":"https://api.github.com/users/uhafner/gists{/gist_id}","starred_url":"https://api.github.com/users/uhafner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uhafner/subscriptions","organizations_url":"https://api.github.com/users/uhafner/orgs","repos_url":"https://api.github.com/users/uhafner/repos","events_url":"https://api.github.com/users/uhafner/events{/privacy}","received_events_url":"https://api.github.com/users/uhafner/received_events","type":"User","site_admin":false},"body":"No: vars.get(parameterName)\r\nIt this is null then we get a NPE. \r\nCan you check what happens when the parameter or value is not set in the UI. Is it the empty string or null?","created_at":"2015-07-28T10:59:48Z","updated_at":"2015-07-28T10:59:48Z","html_url":"https://github.com/jenkinsci/analysis-core-plugin/pull/30#discussion_r35635416","pull_request_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/pulls/30","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/pulls/comments/35635416"},"html":{"href":"https://github.com/jenkinsci/analysis-core-plugin/pull/30#discussion_r35635416"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/pulls/30","id":36104579,"html_url":"https://github.com/jenkinsci/analysis-core-plugin/pull/30","diff_url":"https://github.com/jenkinsci/analysis-core-plugin/pull/30.diff","patch_url":"https://github.com/jenkinsci/analysis-core-plugin/pull/30.patch","issue_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/issues/30","number":30,"state":"open","locked":false,"title":"Add possibility to configure graph by parameter value.","user":{"login":"J-cztery","id":4555794,"avatar_url":"https://avatars.githubusercontent.com/u/4555794?v=3","gravatar_id":"","url":"https://api.github.com/users/J-cztery","html_url":"https://github.com/J-cztery","followers_url":"https://api.github.com/users/J-cztery/followers","following_url":"https://api.github.com/users/J-cztery/following{/other_user}","gists_url":"https://api.github.com/users/J-cztery/gists{/gist_id}","starred_url":"https://api.github.com/users/J-cztery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/J-cztery/subscriptions","organizations_url":"https://api.github.com/users/J-cztery/orgs","repos_url":"https://api.github.com/users/J-cztery/repos","events_url":"https://api.github.com/users/J-cztery/events{/privacy}","received_events_url":"https://api.github.com/users/J-cztery/received_events","type":"User","site_admin":false},"body":"Useful when incremental and full builds are done as part of the same job. Incremental builds do not have all compile warnings so one want to have them filter out to see the trend more clearly. ","created_at":"2015-05-24T16:11:56Z","updated_at":"2015-07-28T10:59:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f416490d61330a29f8e321e8eaed0424f8f4cf79","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/pulls/30/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/pulls/30/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/issues/30/comments","statuses_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/statuses/361aaa612e7953e0bfe3ecab907908417bd62325","head":{"label":"J-cztery:FILTER_GRAPH_BY_PARAMETER","ref":"FILTER_GRAPH_BY_PARAMETER","sha":"361aaa612e7953e0bfe3ecab907908417bd62325","user":{"login":"J-cztery","id":4555794,"avatar_url":"https://avatars.githubusercontent.com/u/4555794?v=3","gravatar_id":"","url":"https://api.github.com/users/J-cztery","html_url":"https://github.com/J-cztery","followers_url":"https://api.github.com/users/J-cztery/followers","following_url":"https://api.github.com/users/J-cztery/following{/other_user}","gists_url":"https://api.github.com/users/J-cztery/gists{/gist_id}","starred_url":"https://api.github.com/users/J-cztery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/J-cztery/subscriptions","organizations_url":"https://api.github.com/users/J-cztery/orgs","repos_url":"https://api.github.com/users/J-cztery/repos","events_url":"https://api.github.com/users/J-cztery/events{/privacy}","received_events_url":"https://api.github.com/users/J-cztery/received_events","type":"User","site_admin":false},"repo":{"id":35942231,"name":"analysis-core-plugin","full_name":"J-cztery/analysis-core-plugin","owner":{"login":"J-cztery","id":4555794,"avatar_url":"https://avatars.githubusercontent.com/u/4555794?v=3","gravatar_id":"","url":"https://api.github.com/users/J-cztery","html_url":"https://github.com/J-cztery","followers_url":"https://api.github.com/users/J-cztery/followers","following_url":"https://api.github.com/users/J-cztery/following{/other_user}","gists_url":"https://api.github.com/users/J-cztery/gists{/gist_id}","starred_url":"https://api.github.com/users/J-cztery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/J-cztery/subscriptions","organizations_url":"https://api.github.com/users/J-cztery/orgs","repos_url":"https://api.github.com/users/J-cztery/repos","events_url":"https://api.github.com/users/J-cztery/events{/privacy}","received_events_url":"https://api.github.com/users/J-cztery/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/J-cztery/analysis-core-plugin","description":"Jenkins analysis-core plugin","fork":true,"url":"https://api.github.com/repos/J-cztery/analysis-core-plugin","forks_url":"https://api.github.com/repos/J-cztery/analysis-core-plugin/forks","keys_url":"https://api.github.com/repos/J-cztery/analysis-core-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/J-cztery/analysis-core-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/J-cztery/analysis-core-plugin/teams","hooks_url":"https://api.github.com/repos/J-cztery/analysis-core-plugin/hooks","issue_events_url":"https://api.github.com/repos/J-cztery/analysis-core-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/J-cztery/analysis-core-plugin/events","assignees_url":"https://api.github.com/repos/J-cztery/analysis-core-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/J-cztery/analysis-core-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/J-cztery/analysis-core-plugin/tags","blobs_url":"https://api.github.com/repos/J-cztery/analysis-core-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/J-cztery/analysis-core-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/J-cztery/analysis-core-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/J-cztery/analysis-core-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/J-cztery/analysis-core-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/J-cztery/analysis-core-plugin/languages","stargazers_url":"https://api.github.com/repos/J-cztery/analysis-core-plugin/stargazers","contributors_url":"https://api.github.com/repos/J-cztery/analysis-core-plugin/contributors","subscribers_url":"https://api.github.com/repos/J-cztery/analysis-core-plugin/subscribers","subscription_url":"https://api.github.com/repos/J-cztery/analysis-core-plugin/subscription","commits_url":"https://api.github.com/repos/J-cztery/analysis-core-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/J-cztery/analysis-core-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/J-cztery/analysis-core-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/J-cztery/analysis-core-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/J-cztery/analysis-core-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/J-cztery/analysis-core-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/J-cztery/analysis-core-plugin/merges","archive_url":"https://api.github.com/repos/J-cztery/analysis-core-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/J-cztery/analysis-core-plugin/downloads","issues_url":"https://api.github.com/repos/J-cztery/analysis-core-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/J-cztery/analysis-core-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/J-cztery/analysis-core-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/J-cztery/analysis-core-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/J-cztery/analysis-core-plugin/labels{/name}","releases_url":"https://api.github.com/repos/J-cztery/analysis-core-plugin/releases{/id}","created_at":"2015-05-20T10:47:50Z","updated_at":"2015-05-20T10:47:51Z","pushed_at":"2015-05-24T16:26:23Z","git_url":"git://github.com/J-cztery/analysis-core-plugin.git","ssh_url":"git@github.com:J-cztery/analysis-core-plugin.git","clone_url":"https://github.com/J-cztery/analysis-core-plugin.git","svn_url":"https://github.com/J-cztery/analysis-core-plugin","homepage":"http://jenkins-ci.org/","size":2100,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"e7a42b2e48ec27fa0eb4d7d4f743a6f20fd8aaa1","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":1163439,"name":"analysis-core-plugin","full_name":"jenkinsci/analysis-core-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/analysis-core-plugin","description":"Jenkins analysis-core plugin","fork":false,"url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin","forks_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/releases{/id}","created_at":"2010-12-13T05:25:57Z","updated_at":"2015-04-14T11:41:05Z","pushed_at":"2015-07-28T09:54:49Z","git_url":"git://github.com/jenkinsci/analysis-core-plugin.git","ssh_url":"git@github.com:jenkinsci/analysis-core-plugin.git","clone_url":"https://github.com/jenkinsci/analysis-core-plugin.git","svn_url":"https://github.com/jenkinsci/analysis-core-plugin","homepage":"http://jenkins-ci.org/","size":4390,"stargazers_count":19,"watchers_count":19,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":2,"forks":42,"open_issues":2,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/pulls/30"},"html":{"href":"https://github.com/jenkinsci/analysis-core-plugin/pull/30"},"issue":{"href":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/issues/30"},"comments":{"href":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/statuses/361aaa612e7953e0bfe3ecab907908417bd62325"}}}}