{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Razor/pulls/comments/25756190","id":25756190,"diff_hunk":"@@ -171,18 +170,18 @@ public Task ExecuteChildContentAsync()\n         /// <returns>A <see cref=\"Task\"/> that on completion returns the rendered child content.</returns>\n         /// <remarks>\n         /// Child content is only executed once. Successive calls to this method or successive executions of the \n-        /// returned <see cref=\"Task{string}\"/> return a cached result.\n+        /// returned <see cref=\"Task{TagHelperContent}\"/> return a cached result.\n         /// </remarks>\n-        public async Task<string> GetChildContentAsync()\n+        public async Task<TagHelperContent> GetChildContentAsync()\n         {\n             if (_childContent == null)\n             {\n-                _startWritingScope();\n+                _startTagHelperWritingScope();\n                 await _executeChildContentAsync();\n-                _childContent = _endWritingScope().ToString();\n+                _childContent = _endTagHelperWritingScope();\n             }\n \n-            return _childContent;\n+            return new DefaultTagHelperContent().SetContent(_childContent);","path":"src/Microsoft.AspNet.Razor.Runtime/TagHelpers/TagHelperExecutionContext.cs","position":80,"original_position":80,"commit_id":"2ea3cb746017d5099c1bafbcb5bdc1c4490dad43","original_commit_id":"2ea3cb746017d5099c1bafbcb5bdc1c4490dad43","user":{"login":"dougbu","id":6431421,"avatar_url":"https://avatars.githubusercontent.com/u/6431421?v=3","gravatar_id":"","url":"https://api.github.com/users/dougbu","html_url":"https://github.com/dougbu","followers_url":"https://api.github.com/users/dougbu/followers","following_url":"https://api.github.com/users/dougbu/following{/other_user}","gists_url":"https://api.github.com/users/dougbu/gists{/gist_id}","starred_url":"https://api.github.com/users/dougbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dougbu/subscriptions","organizations_url":"https://api.github.com/users/dougbu/orgs","repos_url":"https://api.github.com/users/dougbu/repos","events_url":"https://api.github.com/users/dougbu/events{/privacy}","received_events_url":"https://api.github.com/users/dougbu/received_events","type":"User","site_admin":false},"body":"massive difference in scale @NTaylorMullen.  a `TagHelperContent` is quite small compared to the `string`s allocated when combining content on the page.\r\n\r\nthis is not the last change that will happen in Razor and if we see too many `TagHelperContent` allocations, we can lazy-load some and eliminate a few others.\r\n\r\nside note: nothing about purpose number one is changing in this PR.","created_at":"2015-03-04T07:19:00Z","updated_at":"2015-03-04T07:19:00Z","html_url":"https://github.com/aspnet/Razor/pull/312#discussion_r25756190","pull_request_url":"https://api.github.com/repos/aspnet/Razor/pulls/312","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Razor/pulls/comments/25756190"},"html":{"href":"https://github.com/aspnet/Razor/pull/312#discussion_r25756190"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Razor/pulls/312"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Razor/pulls/312","id":29824514,"html_url":"https://github.com/aspnet/Razor/pull/312","diff_url":"https://github.com/aspnet/Razor/pull/312.diff","patch_url":"https://github.com/aspnet/Razor/pull/312.patch","issue_url":"https://api.github.com/repos/aspnet/Razor/issues/312","number":312,"state":"open","locked":false,"title":"Introducing buffering in TagHelperOutput.PreContent, Content, PostContent","user":{"login":"sornaks","id":6588965,"avatar_url":"https://avatars.githubusercontent.com/u/6588965?v=3","gravatar_id":"","url":"https://api.github.com/users/sornaks","html_url":"https://github.com/sornaks","followers_url":"https://api.github.com/users/sornaks/followers","following_url":"https://api.github.com/users/sornaks/following{/other_user}","gists_url":"https://api.github.com/users/sornaks/gists{/gist_id}","starred_url":"https://api.github.com/users/sornaks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sornaks/subscriptions","organizations_url":"https://api.github.com/users/sornaks/orgs","repos_url":"https://api.github.com/users/sornaks/repos","events_url":"https://api.github.com/users/sornaks/events{/privacy}","received_events_url":"https://api.github.com/users/sornaks/received_events","type":"User","site_admin":false},"body":"#296. Looking for comments around naming.","created_at":"2015-02-23T16:49:38Z","updated_at":"2015-03-04T07:19:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e85a1f53c9653e874e4b8b7ce7c9f48f045fa476","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Razor/pulls/312/commits","review_comments_url":"https://api.github.com/repos/aspnet/Razor/pulls/312/comments","review_comment_url":"https://api.github.com/repos/aspnet/Razor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Razor/issues/312/comments","statuses_url":"https://api.github.com/repos/aspnet/Razor/statuses/2ea3cb746017d5099c1bafbcb5bdc1c4490dad43","head":{"label":"aspnet:Output","ref":"Output","sha":"2ea3cb746017d5099c1bafbcb5bdc1c4490dad43","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15835991,"name":"Razor","full_name":"aspnet/Razor","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Razor","description":"Parser and code generator for CSHTML files used in view pages for MVC web apps.","fork":false,"url":"https://api.github.com/repos/aspnet/Razor","forks_url":"https://api.github.com/repos/aspnet/Razor/forks","keys_url":"https://api.github.com/repos/aspnet/Razor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Razor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Razor/teams","hooks_url":"https://api.github.com/repos/aspnet/Razor/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Razor/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Razor/events","assignees_url":"https://api.github.com/repos/aspnet/Razor/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Razor/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Razor/tags","blobs_url":"https://api.github.com/repos/aspnet/Razor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Razor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Razor/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Razor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Razor/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Razor/languages","stargazers_url":"https://api.github.com/repos/aspnet/Razor/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Razor/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Razor/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Razor/subscription","commits_url":"https://api.github.com/repos/aspnet/Razor/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Razor/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Razor/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Razor/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Razor/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Razor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Razor/merges","archive_url":"https://api.github.com/repos/aspnet/Razor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Razor/downloads","issues_url":"https://api.github.com/repos/aspnet/Razor/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Razor/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Razor/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Razor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Razor/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Razor/releases{/id}","created_at":"2014-01-12T03:52:46Z","updated_at":"2015-03-03T22:02:28Z","pushed_at":"2015-03-04T01:48:42Z","git_url":"git://github.com/aspnet/Razor.git","ssh_url":"git@github.com:aspnet/Razor.git","clone_url":"https://github.com/aspnet/Razor.git","svn_url":"https://github.com/aspnet/Razor","homepage":"","size":7420,"stargazers_count":300,"watchers_count":300,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":67,"mirror_url":null,"open_issues_count":75,"forks":67,"open_issues":75,"watchers":300,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"7ecce1b66618bcbaca8227df652f8d53a7b8b294","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15835991,"name":"Razor","full_name":"aspnet/Razor","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Razor","description":"Parser and code generator for CSHTML files used in view pages for MVC web apps.","fork":false,"url":"https://api.github.com/repos/aspnet/Razor","forks_url":"https://api.github.com/repos/aspnet/Razor/forks","keys_url":"https://api.github.com/repos/aspnet/Razor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Razor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Razor/teams","hooks_url":"https://api.github.com/repos/aspnet/Razor/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Razor/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Razor/events","assignees_url":"https://api.github.com/repos/aspnet/Razor/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Razor/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Razor/tags","blobs_url":"https://api.github.com/repos/aspnet/Razor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Razor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Razor/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Razor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Razor/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Razor/languages","stargazers_url":"https://api.github.com/repos/aspnet/Razor/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Razor/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Razor/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Razor/subscription","commits_url":"https://api.github.com/repos/aspnet/Razor/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Razor/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Razor/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Razor/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Razor/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Razor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Razor/merges","archive_url":"https://api.github.com/repos/aspnet/Razor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Razor/downloads","issues_url":"https://api.github.com/repos/aspnet/Razor/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Razor/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Razor/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Razor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Razor/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Razor/releases{/id}","created_at":"2014-01-12T03:52:46Z","updated_at":"2015-03-03T22:02:28Z","pushed_at":"2015-03-04T01:48:42Z","git_url":"git://github.com/aspnet/Razor.git","ssh_url":"git@github.com:aspnet/Razor.git","clone_url":"https://github.com/aspnet/Razor.git","svn_url":"https://github.com/aspnet/Razor","homepage":"","size":7420,"stargazers_count":300,"watchers_count":300,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":67,"mirror_url":null,"open_issues_count":75,"forks":67,"open_issues":75,"watchers":300,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Razor/pulls/312"},"html":{"href":"https://github.com/aspnet/Razor/pull/312"},"issue":{"href":"https://api.github.com/repos/aspnet/Razor/issues/312"},"comments":{"href":"https://api.github.com/repos/aspnet/Razor/issues/312/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Razor/pulls/312/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Razor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Razor/pulls/312/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Razor/statuses/2ea3cb746017d5099c1bafbcb5bdc1c4490dad43"}}}}