{"action":"closed","number":40,"pull_request":{"url":"https://api.github.com/repos/openSUSE/libzypp/pulls/40","id":27573420,"html_url":"https://github.com/openSUSE/libzypp/pull/40","diff_url":"https://github.com/openSUSE/libzypp/pull/40.diff","patch_url":"https://github.com/openSUSE/libzypp/pull/40.patch","issue_url":"https://api.github.com/repos/openSUSE/libzypp/issues/40","number":40,"state":"closed","locked":false,"title":"PathInfo: rename major/minor to devMajor/devMinor","user":{"login":"pinotree","id":1129322,"avatar_url":"https://avatars.githubusercontent.com/u/1129322?v=3","gravatar_id":"","url":"https://api.github.com/users/pinotree","html_url":"https://github.com/pinotree","followers_url":"https://api.github.com/users/pinotree/followers","following_url":"https://api.github.com/users/pinotree/following{/other_user}","gists_url":"https://api.github.com/users/pinotree/gists{/gist_id}","starred_url":"https://api.github.com/users/pinotree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinotree/subscriptions","organizations_url":"https://api.github.com/users/pinotree/orgs","repos_url":"https://api.github.com/users/pinotree/repos","events_url":"https://api.github.com/users/pinotree/events{/privacy}","received_events_url":"https://api.github.com/users/pinotree/received_events","type":"User","site_admin":false},"body":"`major()` and `minor()` conlict with the GNU libc macros with the same names, so if any system header bringing them (directly or indirectly) is included before PathInfo.h, then PathInfo.h is unusable.\r\n\r\nUnfortunately, the only clean way to solve this conflict is renaming `PathInfo::major()` & `PathInfo::minor()` resp. to `devMajor()` & `devMinor()`.\r\n\r\n--- \r\nlibzypp maintainers: is such kind of API change wanted? Should I bump `LIBZYPP_COMPATMINOR` & `LIBZYPP_MINOR` in VERSION.cmake as well, or will you do that just once before the release?","created_at":"2015-01-18T16:36:33Z","updated_at":"2015-01-21T10:00:12Z","closed_at":"2015-01-21T10:00:12Z","merged_at":null,"merge_commit_sha":"11da8e476f3c50ca06445216852bce5e3ff8783c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openSUSE/libzypp/pulls/40/commits","review_comments_url":"https://api.github.com/repos/openSUSE/libzypp/pulls/40/comments","review_comment_url":"https://api.github.com/repos/openSUSE/libzypp/pulls/comments/{number}","comments_url":"https://api.github.com/repos/openSUSE/libzypp/issues/40/comments","statuses_url":"https://api.github.com/repos/openSUSE/libzypp/statuses/521523f5609a5c43a3c35849d2ab2d116fc21ee1","head":{"label":"pinotree:major-minor-macros","ref":"major-minor-macros","sha":"521523f5609a5c43a3c35849d2ab2d116fc21ee1","user":{"login":"pinotree","id":1129322,"avatar_url":"https://avatars.githubusercontent.com/u/1129322?v=3","gravatar_id":"","url":"https://api.github.com/users/pinotree","html_url":"https://github.com/pinotree","followers_url":"https://api.github.com/users/pinotree/followers","following_url":"https://api.github.com/users/pinotree/following{/other_user}","gists_url":"https://api.github.com/users/pinotree/gists{/gist_id}","starred_url":"https://api.github.com/users/pinotree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinotree/subscriptions","organizations_url":"https://api.github.com/users/pinotree/orgs","repos_url":"https://api.github.com/users/pinotree/repos","events_url":"https://api.github.com/users/pinotree/events{/privacy}","received_events_url":"https://api.github.com/users/pinotree/received_events","type":"User","site_admin":false},"repo":{"id":29410586,"name":"libzypp","full_name":"pinotree/libzypp","owner":{"login":"pinotree","id":1129322,"avatar_url":"https://avatars.githubusercontent.com/u/1129322?v=3","gravatar_id":"","url":"https://api.github.com/users/pinotree","html_url":"https://github.com/pinotree","followers_url":"https://api.github.com/users/pinotree/followers","following_url":"https://api.github.com/users/pinotree/following{/other_user}","gists_url":"https://api.github.com/users/pinotree/gists{/gist_id}","starred_url":"https://api.github.com/users/pinotree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinotree/subscriptions","organizations_url":"https://api.github.com/users/pinotree/orgs","repos_url":"https://api.github.com/users/pinotree/repos","events_url":"https://api.github.com/users/pinotree/events{/privacy}","received_events_url":"https://api.github.com/users/pinotree/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pinotree/libzypp","description":"ZYpp Package Management library","fork":true,"url":"https://api.github.com/repos/pinotree/libzypp","forks_url":"https://api.github.com/repos/pinotree/libzypp/forks","keys_url":"https://api.github.com/repos/pinotree/libzypp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pinotree/libzypp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pinotree/libzypp/teams","hooks_url":"https://api.github.com/repos/pinotree/libzypp/hooks","issue_events_url":"https://api.github.com/repos/pinotree/libzypp/issues/events{/number}","events_url":"https://api.github.com/repos/pinotree/libzypp/events","assignees_url":"https://api.github.com/repos/pinotree/libzypp/assignees{/user}","branches_url":"https://api.github.com/repos/pinotree/libzypp/branches{/branch}","tags_url":"https://api.github.com/repos/pinotree/libzypp/tags","blobs_url":"https://api.github.com/repos/pinotree/libzypp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pinotree/libzypp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pinotree/libzypp/git/refs{/sha}","trees_url":"https://api.github.com/repos/pinotree/libzypp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pinotree/libzypp/statuses/{sha}","languages_url":"https://api.github.com/repos/pinotree/libzypp/languages","stargazers_url":"https://api.github.com/repos/pinotree/libzypp/stargazers","contributors_url":"https://api.github.com/repos/pinotree/libzypp/contributors","subscribers_url":"https://api.github.com/repos/pinotree/libzypp/subscribers","subscription_url":"https://api.github.com/repos/pinotree/libzypp/subscription","commits_url":"https://api.github.com/repos/pinotree/libzypp/commits{/sha}","git_commits_url":"https://api.github.com/repos/pinotree/libzypp/git/commits{/sha}","comments_url":"https://api.github.com/repos/pinotree/libzypp/comments{/number}","issue_comment_url":"https://api.github.com/repos/pinotree/libzypp/issues/comments/{number}","contents_url":"https://api.github.com/repos/pinotree/libzypp/contents/{+path}","compare_url":"https://api.github.com/repos/pinotree/libzypp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pinotree/libzypp/merges","archive_url":"https://api.github.com/repos/pinotree/libzypp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pinotree/libzypp/downloads","issues_url":"https://api.github.com/repos/pinotree/libzypp/issues{/number}","pulls_url":"https://api.github.com/repos/pinotree/libzypp/pulls{/number}","milestones_url":"https://api.github.com/repos/pinotree/libzypp/milestones{/number}","notifications_url":"https://api.github.com/repos/pinotree/libzypp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pinotree/libzypp/labels{/name}","releases_url":"https://api.github.com/repos/pinotree/libzypp/releases{/id}","created_at":"2015-01-18T00:26:16Z","updated_at":"2015-01-20T19:38:59Z","pushed_at":"2015-01-20T19:39:17Z","git_url":"git://github.com/pinotree/libzypp.git","ssh_url":"git@github.com:pinotree/libzypp.git","clone_url":"https://github.com/pinotree/libzypp.git","svn_url":"https://github.com/pinotree/libzypp","homepage":"http://doc.opensuse.org/projects/libzypp/HEAD/","size":224961,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openSUSE:master","ref":"master","sha":"f3c3aa763907399a3a538611e59097a41cfa0e65","user":{"login":"openSUSE","id":623819,"avatar_url":"https://avatars.githubusercontent.com/u/623819?v=3","gravatar_id":"","url":"https://api.github.com/users/openSUSE","html_url":"https://github.com/openSUSE","followers_url":"https://api.github.com/users/openSUSE/followers","following_url":"https://api.github.com/users/openSUSE/following{/other_user}","gists_url":"https://api.github.com/users/openSUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/openSUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openSUSE/subscriptions","organizations_url":"https://api.github.com/users/openSUSE/orgs","repos_url":"https://api.github.com/users/openSUSE/repos","events_url":"https://api.github.com/users/openSUSE/events{/privacy}","received_events_url":"https://api.github.com/users/openSUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":2123336,"name":"libzypp","full_name":"openSUSE/libzypp","owner":{"login":"openSUSE","id":623819,"avatar_url":"https://avatars.githubusercontent.com/u/623819?v=3","gravatar_id":"","url":"https://api.github.com/users/openSUSE","html_url":"https://github.com/openSUSE","followers_url":"https://api.github.com/users/openSUSE/followers","following_url":"https://api.github.com/users/openSUSE/following{/other_user}","gists_url":"https://api.github.com/users/openSUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/openSUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openSUSE/subscriptions","organizations_url":"https://api.github.com/users/openSUSE/orgs","repos_url":"https://api.github.com/users/openSUSE/repos","events_url":"https://api.github.com/users/openSUSE/events{/privacy}","received_events_url":"https://api.github.com/users/openSUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openSUSE/libzypp","description":"ZYpp Package Management library","fork":false,"url":"https://api.github.com/repos/openSUSE/libzypp","forks_url":"https://api.github.com/repos/openSUSE/libzypp/forks","keys_url":"https://api.github.com/repos/openSUSE/libzypp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openSUSE/libzypp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openSUSE/libzypp/teams","hooks_url":"https://api.github.com/repos/openSUSE/libzypp/hooks","issue_events_url":"https://api.github.com/repos/openSUSE/libzypp/issues/events{/number}","events_url":"https://api.github.com/repos/openSUSE/libzypp/events","assignees_url":"https://api.github.com/repos/openSUSE/libzypp/assignees{/user}","branches_url":"https://api.github.com/repos/openSUSE/libzypp/branches{/branch}","tags_url":"https://api.github.com/repos/openSUSE/libzypp/tags","blobs_url":"https://api.github.com/repos/openSUSE/libzypp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openSUSE/libzypp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openSUSE/libzypp/git/refs{/sha}","trees_url":"https://api.github.com/repos/openSUSE/libzypp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openSUSE/libzypp/statuses/{sha}","languages_url":"https://api.github.com/repos/openSUSE/libzypp/languages","stargazers_url":"https://api.github.com/repos/openSUSE/libzypp/stargazers","contributors_url":"https://api.github.com/repos/openSUSE/libzypp/contributors","subscribers_url":"https://api.github.com/repos/openSUSE/libzypp/subscribers","subscription_url":"https://api.github.com/repos/openSUSE/libzypp/subscription","commits_url":"https://api.github.com/repos/openSUSE/libzypp/commits{/sha}","git_commits_url":"https://api.github.com/repos/openSUSE/libzypp/git/commits{/sha}","comments_url":"https://api.github.com/repos/openSUSE/libzypp/comments{/number}","issue_comment_url":"https://api.github.com/repos/openSUSE/libzypp/issues/comments/{number}","contents_url":"https://api.github.com/repos/openSUSE/libzypp/contents/{+path}","compare_url":"https://api.github.com/repos/openSUSE/libzypp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openSUSE/libzypp/merges","archive_url":"https://api.github.com/repos/openSUSE/libzypp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openSUSE/libzypp/downloads","issues_url":"https://api.github.com/repos/openSUSE/libzypp/issues{/number}","pulls_url":"https://api.github.com/repos/openSUSE/libzypp/pulls{/number}","milestones_url":"https://api.github.com/repos/openSUSE/libzypp/milestones{/number}","notifications_url":"https://api.github.com/repos/openSUSE/libzypp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openSUSE/libzypp/labels{/name}","releases_url":"https://api.github.com/repos/openSUSE/libzypp/releases{/id}","created_at":"2011-07-29T10:20:34Z","updated_at":"2015-01-20T15:49:32Z","pushed_at":"2015-01-21T10:00:11Z","git_url":"git://github.com/openSUSE/libzypp.git","ssh_url":"git@github.com:openSUSE/libzypp.git","clone_url":"https://github.com/openSUSE/libzypp.git","svn_url":"https://github.com/openSUSE/libzypp","homepage":"http://doc.opensuse.org/projects/libzypp/HEAD/","size":224961,"stargazers_count":26,"watchers_count":26,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":1,"forks":20,"open_issues":1,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openSUSE/libzypp/pulls/40"},"html":{"href":"https://github.com/openSUSE/libzypp/pull/40"},"issue":{"href":"https://api.github.com/repos/openSUSE/libzypp/issues/40"},"comments":{"href":"https://api.github.com/repos/openSUSE/libzypp/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/openSUSE/libzypp/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/openSUSE/libzypp/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/openSUSE/libzypp/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/openSUSE/libzypp/statuses/521523f5609a5c43a3c35849d2ab2d116fc21ee1"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":4,"review_comments":0,"commits":1,"additions":28,"deletions":28,"changed_files":6}}