{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/47461265","id":47461265,"diff_hunk":"@@ -104,7 +111,11 @@ func (e *etcdMasterElector) extendMaster(path, id string, ttl uint64, res *etcd.\n // returns id, nil if the attempt succeeded\n // returns \"\", err if an error occurred\n func (e *etcdMasterElector) becomeMaster(path, id string, ttl uint64) (string, error) {\n-\t_, err := e.etcd.Create(path, id, ttl)\n+\topts := etcd.SetOptions{\n+\t\tTTL: time.Duration(ttl) * time.Second,\n+\t}","path":"contrib/mesos/pkg/election/etcd_master.go","position":52,"original_position":52,"commit_id":"549ae8386443242a2554e0924452ac6c62437a73","original_commit_id":"549ae8386443242a2554e0924452ac6c62437a73","user":{"login":"jdef","id":2348332,"avatar_url":"https://avatars.githubusercontent.com/u/2348332?v=3","gravatar_id":"","url":"https://api.github.com/users/jdef","html_url":"https://github.com/jdef","followers_url":"https://api.github.com/users/jdef/followers","following_url":"https://api.github.com/users/jdef/following{/other_user}","gists_url":"https://api.github.com/users/jdef/gists{/gist_id}","starred_url":"https://api.github.com/users/jdef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdef/subscriptions","organizations_url":"https://api.github.com/users/jdef/orgs","repos_url":"https://api.github.com/users/jdef/repos","events_url":"https://api.github.com/users/jdef/events{/privacy}","received_events_url":"https://api.github.com/users/jdef/received_events","type":"User","site_admin":false},"body":"missing `PrevExist: etcd.PrevNoExist`?","created_at":"2015-12-14T04:45:19Z","updated_at":"2015-12-14T04:45:19Z","html_url":"https://github.com/kubernetes/kubernetes/pull/18635#discussion_r47461265","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18635","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/47461265"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/18635#discussion_r47461265"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18635"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18635","id":53518529,"html_url":"https://github.com/kubernetes/kubernetes/pull/18635","diff_url":"https://github.com/kubernetes/kubernetes/pull/18635.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/18635.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/18635","number":18635,"state":"open","locked":false,"title":"WIP: Updating to use latest etcd client library","user":{"login":"timothysc","id":169553,"avatar_url":"https://avatars.githubusercontent.com/u/169553?v=3","gravatar_id":"","url":"https://api.github.com/users/timothysc","html_url":"https://github.com/timothysc","followers_url":"https://api.github.com/users/timothysc/followers","following_url":"https://api.github.com/users/timothysc/following{/other_user}","gists_url":"https://api.github.com/users/timothysc/gists{/gist_id}","starred_url":"https://api.github.com/users/timothysc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothysc/subscriptions","organizations_url":"https://api.github.com/users/timothysc/orgs","repos_url":"https://api.github.com/users/timothysc/repos","events_url":"https://api.github.com/users/timothysc/events{/privacy}","received_events_url":"https://api.github.com/users/timothysc/received_events","type":"User","site_admin":false},"body":"This is the update for the new client library after all the storage refactoring.  There is still an error I'm chasing down in the cache, but everything else appears green.  \r\n\r\nFinal implementation for #11962\r\n\r\n@wojtek-t & @jdef for review \r\n\r\n/cc @liggitt ","created_at":"2015-12-14T02:21:53Z","updated_at":"2015-12-14T04:45:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8b4a4cda8eb443f08563f95eb2cfb06dde082e1","assignee":{"login":"dchen1107","id":7740897,"avatar_url":"https://avatars.githubusercontent.com/u/7740897?v=3","gravatar_id":"","url":"https://api.github.com/users/dchen1107","html_url":"https://github.com/dchen1107","followers_url":"https://api.github.com/users/dchen1107/followers","following_url":"https://api.github.com/users/dchen1107/following{/other_user}","gists_url":"https://api.github.com/users/dchen1107/gists{/gist_id}","starred_url":"https://api.github.com/users/dchen1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchen1107/subscriptions","organizations_url":"https://api.github.com/users/dchen1107/orgs","repos_url":"https://api.github.com/users/dchen1107/repos","events_url":"https://api.github.com/users/dchen1107/events{/privacy}","received_events_url":"https://api.github.com/users/dchen1107/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18635/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18635/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/18635/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/549ae8386443242a2554e0924452ac6c62437a73","head":{"label":"timothysc:etcd_client_post_cleanup","ref":"etcd_client_post_cleanup","sha":"549ae8386443242a2554e0924452ac6c62437a73","user":{"login":"timothysc","id":169553,"avatar_url":"https://avatars.githubusercontent.com/u/169553?v=3","gravatar_id":"","url":"https://api.github.com/users/timothysc","html_url":"https://github.com/timothysc","followers_url":"https://api.github.com/users/timothysc/followers","following_url":"https://api.github.com/users/timothysc/following{/other_user}","gists_url":"https://api.github.com/users/timothysc/gists{/gist_id}","starred_url":"https://api.github.com/users/timothysc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothysc/subscriptions","organizations_url":"https://api.github.com/users/timothysc/orgs","repos_url":"https://api.github.com/users/timothysc/repos","events_url":"https://api.github.com/users/timothysc/events{/privacy}","received_events_url":"https://api.github.com/users/timothysc/received_events","type":"User","site_admin":false},"repo":{"id":28345483,"name":"kubernetes","full_name":"timothysc/kubernetes","owner":{"login":"timothysc","id":169553,"avatar_url":"https://avatars.githubusercontent.com/u/169553?v=3","gravatar_id":"","url":"https://api.github.com/users/timothysc","html_url":"https://github.com/timothysc","followers_url":"https://api.github.com/users/timothysc/followers","following_url":"https://api.github.com/users/timothysc/following{/other_user}","gists_url":"https://api.github.com/users/timothysc/gists{/gist_id}","starred_url":"https://api.github.com/users/timothysc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothysc/subscriptions","organizations_url":"https://api.github.com/users/timothysc/orgs","repos_url":"https://api.github.com/users/timothysc/repos","events_url":"https://api.github.com/users/timothysc/events{/privacy}","received_events_url":"https://api.github.com/users/timothysc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/timothysc/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/timothysc/kubernetes","forks_url":"https://api.github.com/repos/timothysc/kubernetes/forks","keys_url":"https://api.github.com/repos/timothysc/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timothysc/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timothysc/kubernetes/teams","hooks_url":"https://api.github.com/repos/timothysc/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/timothysc/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/timothysc/kubernetes/events","assignees_url":"https://api.github.com/repos/timothysc/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/timothysc/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/timothysc/kubernetes/tags","blobs_url":"https://api.github.com/repos/timothysc/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timothysc/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timothysc/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/timothysc/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timothysc/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/timothysc/kubernetes/languages","stargazers_url":"https://api.github.com/repos/timothysc/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/timothysc/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/timothysc/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/timothysc/kubernetes/subscription","commits_url":"https://api.github.com/repos/timothysc/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/timothysc/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/timothysc/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/timothysc/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/timothysc/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/timothysc/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timothysc/kubernetes/merges","archive_url":"https://api.github.com/repos/timothysc/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timothysc/kubernetes/downloads","issues_url":"https://api.github.com/repos/timothysc/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/timothysc/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/timothysc/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/timothysc/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timothysc/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/timothysc/kubernetes/releases{/id}","created_at":"2014-12-22T15:52:58Z","updated_at":"2015-03-06T19:21:46Z","pushed_at":"2015-12-14T02:18:51Z","git_url":"git://github.com/timothysc/kubernetes.git","ssh_url":"git@github.com:timothysc/kubernetes.git","clone_url":"https://github.com/timothysc/kubernetes.git","svn_url":"https://github.com/timothysc/kubernetes","homepage":null,"size":135192,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"c458cd7bb705b330321a17c88c92cebb974747c6","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-12-14T04:13:44Z","pushed_at":"2015-12-14T04:03:51Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":292065,"stargazers_count":11742,"watchers_count":11742,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3198,"mirror_url":null,"open_issues_count":2580,"forks":3198,"open_issues":2580,"watchers":11742,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18635"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/18635"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/18635"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/18635/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18635/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18635/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/549ae8386443242a2554e0924452ac6c62437a73"}}}}