{"action":"created","issue":{"url":"https://api.github.com/repos/jaymedavis/stripe.net/issues/237","labels_url":"https://api.github.com/repos/jaymedavis/stripe.net/issues/237/labels{/name}","comments_url":"https://api.github.com/repos/jaymedavis/stripe.net/issues/237/comments","events_url":"https://api.github.com/repos/jaymedavis/stripe.net/issues/237/events","html_url":"https://github.com/jaymedavis/stripe.net/pull/237","id":50999393,"number":237,"title":"Async support","user":{"login":"paulirwin","id":1874103,"avatar_url":"https://avatars.githubusercontent.com/u/1874103?v=3","gravatar_id":"","url":"https://api.github.com/users/paulirwin","html_url":"https://github.com/paulirwin","followers_url":"https://api.github.com/users/paulirwin/followers","following_url":"https://api.github.com/users/paulirwin/following{/other_user}","gists_url":"https://api.github.com/users/paulirwin/gists{/gist_id}","starred_url":"https://api.github.com/users/paulirwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulirwin/subscriptions","organizations_url":"https://api.github.com/users/paulirwin/orgs","repos_url":"https://api.github.com/users/paulirwin/repos","events_url":"https://api.github.com/users/paulirwin/events{/privacy}","received_events_url":"https://api.github.com/users/paulirwin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":17,"created_at":"2014-12-04T16:53:13Z","updated_at":"2015-01-30T15:26:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jaymedavis/stripe.net/pulls/237","html_url":"https://github.com/jaymedavis/stripe.net/pull/237","diff_url":"https://github.com/jaymedavis/stripe.net/pull/237.diff","patch_url":"https://github.com/jaymedavis/stripe.net/pull/237.patch"},"body":"I modified Requestor to have async methods for all of the operations, and added async versions of all of the service methods. I started work on this before the .NET 3.5 support was merged in, so my second commit merges that in and adds \"#if NET40\" around all the async methods. This uses the Microsoft.Bcl.Async NuGet package so that it works on .NET 4.0 as well as .NET 4.5 and later, while the #if statements allow the 3.5 build to compile.\r\n\r\nOne thing I noticed is that the .NET 4 and .NET 3.5 builds output to the same folder -- we may want to consider putting them in platform-specific output folders."},"comment":{"url":"https://api.github.com/repos/jaymedavis/stripe.net/issues/comments/72217705","html_url":"https://github.com/jaymedavis/stripe.net/pull/237#issuecomment-72217705","issue_url":"https://api.github.com/repos/jaymedavis/stripe.net/issues/237","id":72217705,"user":{"login":"paulirwin","id":1874103,"avatar_url":"https://avatars.githubusercontent.com/u/1874103?v=3","gravatar_id":"","url":"https://api.github.com/users/paulirwin","html_url":"https://github.com/paulirwin","followers_url":"https://api.github.com/users/paulirwin/followers","following_url":"https://api.github.com/users/paulirwin/following{/other_user}","gists_url":"https://api.github.com/users/paulirwin/gists{/gist_id}","starred_url":"https://api.github.com/users/paulirwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulirwin/subscriptions","organizations_url":"https://api.github.com/users/paulirwin/orgs","repos_url":"https://api.github.com/users/paulirwin/repos","events_url":"https://api.github.com/users/paulirwin/events{/privacy}","received_events_url":"https://api.github.com/users/paulirwin/received_events","type":"User","site_admin":false},"created_at":"2015-01-30T15:26:45Z","updated_at":"2015-01-30T15:26:45Z","body":"Most of the \"no changes here\" was from the merge, and I believe that has to do with line endings. This is due to this repository not having a .gitattributes file specifying the line endings. The best option will be to do a one-time commit to clean up the line endings with a .gitattributes file. See here: https://help.github.com/articles/dealing-with-line-endings/\r\n\r\nI'd be happy to add a line endings commit to this PR if you would like, using the default .gitattributes from GitHub for Windows. That will result in a lot of files that look like they've changed, but they haven't. But otherwise, you can feel free to ignore the changes here for now (again, most were from the merge from master, not from me) and do a gitattributes cleanup later."}}