{"action":"created","issue":{"url":"https://api.github.com/repos/backupify/twitter_cassandra/issues/2","labels_url":"https://api.github.com/repos/backupify/twitter_cassandra/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/backupify/twitter_cassandra/issues/2/comments","events_url":"https://api.github.com/repos/backupify/twitter_cassandra/issues/2/events","html_url":"https://github.com/backupify/twitter_cassandra/pull/2","id":61685044,"number":2,"title":"Change how read and write defaults are accessed to allow multiple defaults","user":{"login":"tdg5","id":2316989,"avatar_url":"https://avatars.githubusercontent.com/u/2316989?v=3","gravatar_id":"","url":"https://api.github.com/users/tdg5","html_url":"https://github.com/tdg5","followers_url":"https://api.github.com/users/tdg5/followers","following_url":"https://api.github.com/users/tdg5/following{/other_user}","gists_url":"https://api.github.com/users/tdg5/gists{/gist_id}","starred_url":"https://api.github.com/users/tdg5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdg5/subscriptions","organizations_url":"https://api.github.com/users/tdg5/orgs","repos_url":"https://api.github.com/users/tdg5/repos","events_url":"https://api.github.com/users/tdg5/events{/privacy}","received_events_url":"https://api.github.com/users/tdg5/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-03-14T19:46:27Z","updated_at":"2015-03-14T22:46:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/backupify/twitter_cassandra/pulls/2","html_url":"https://github.com/backupify/twitter_cassandra/pull/2","diff_url":"https://github.com/backupify/twitter_cassandra/pull/2.diff","patch_url":"https://github.com/backupify/twitter_cassandra/pull/2.patch"},"body":"Currently this gem is organized such that read defaults and write defaults are stored as constants on the Cassanda class. These constants are accessed directly whenever those defaults are needed. This pattern makes it impossible to have one client use quorum reads and another client use a read consistency of 1 because both end up changing the same set of default options.\r\n\r\nEven with subclassing, since constants are lexically scoped, it's impossible to override the default options such that two clients could have their own set of defaults.\r\n\r\nThis change restructures access to the defaults such that different client instances can have their own default read and write configuration.\r\n\r\nI was unable to run tests for this repository, however the Backupify test suite is green following this change."},"comment":{"url":"https://api.github.com/repos/backupify/twitter_cassandra/issues/comments/80748629","html_url":"https://github.com/backupify/twitter_cassandra/pull/2#issuecomment-80748629","issue_url":"https://api.github.com/repos/backupify/twitter_cassandra/issues/2","id":80748629,"user":{"login":"jbodah","id":6093002,"avatar_url":"https://avatars.githubusercontent.com/u/6093002?v=3","gravatar_id":"","url":"https://api.github.com/users/jbodah","html_url":"https://github.com/jbodah","followers_url":"https://api.github.com/users/jbodah/followers","following_url":"https://api.github.com/users/jbodah/following{/other_user}","gists_url":"https://api.github.com/users/jbodah/gists{/gist_id}","starred_url":"https://api.github.com/users/jbodah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbodah/subscriptions","organizations_url":"https://api.github.com/users/jbodah/orgs","repos_url":"https://api.github.com/users/jbodah/repos","events_url":"https://api.github.com/users/jbodah/events{/privacy}","received_events_url":"https://api.github.com/users/jbodah/received_events","type":"User","site_admin":false},"created_at":"2015-03-14T22:46:47Z","updated_at":"2015-03-14T22:46:47Z","body":"Yeah it looks like the repo requires pretty intimate knowledge of the cass installation (e.g. Rakefile). This change looks benign enough and if CORE passes then that seems pretty good to me"}}