{"push_id":641186988,"size":42,"distinct_size":42,"ref":"refs/heads/master","head":"10c5151d92470ddcdde07c779ad41556da7dbc74","before":"be40a023b00fecfcc940475c4341b90397866c78","commits":[{"sha":"261c9d18e6a0c35d910ba66fc62a06172b33404a","author":{"email":"9b95ce62b57d299cd99a3d268f375e473aac272b@liferay.com","name":"Iván Zaera Avellón"},"message":"LPS-54010 Pass the itemSelectedCallback function name to ItemSelector. The itemSelectedCallback is the name of the Javascript function that must be called after the user selects the item.\n\nWe need to change ItemSelectorViewRenderers class into LocalizedItemSelectorRendering, too.","distinct":true,"url":"https://api.github.com/repos/natecavanaugh/liferay-portal/commits/261c9d18e6a0c35d910ba66fc62a06172b33404a"},{"sha":"68813942dcf9f3cfad30459d37ce8bdf5984d2ce","author":{"email":"9b95ce62b57d299cd99a3d268f375e473aac272b@liferay.com","name":"Iván Zaera Avellón"},"message":"LPS-54010 Change getHTML() to renderHTML() in ItemSelectorView.\n\nThis is necessary since we need the request and response to be able to use Liferay's taglibs. It would be cleaner to have a getHTML() interface, but for now it is impossible unless we want to penalize our customer by not allowing them to use our taglibs.","distinct":true,"url":"https://api.github.com/repos/natecavanaugh/liferay-portal/commits/68813942dcf9f3cfad30459d37ce8bdf5984d2ce"},{"sha":"f6b3a88bc41349b74115278ecfd2230fc60cf536","author":{"email":"9b95ce62b57d299cd99a3d268f375e473aac272b@liferay.com","name":"Iván Zaera Avellón"},"message":"LPS-54010 Implement the wiki-item-selector to contribute pages for wiki attachments for document-selector.\n\nNote that, after this commit, we have duplicated code for the wiki attachments, but it shouldn't be a big problem as we will finish this soon and will get rid of the old code.","distinct":true,"url":"https://api.github.com/repos/natecavanaugh/liferay-portal/commits/f6b3a88bc41349b74115278ecfd2230fc60cf536"},{"sha":"a93563b0231c6390decfb64bef92a94bab8e7b3c","author":{"email":"9b95ce62b57d299cd99a3d268f375e473aac272b@liferay.com","name":"Iván Zaera Avellón"},"message":"LPS-54010 Convert ItemSelectorRendering into an interface to make API cleaner and easier to maintain.","distinct":true,"url":"https://api.github.com/repos/natecavanaugh/liferay-portal/commits/a93563b0231c6390decfb64bef92a94bab8e7b3c"},{"sha":"6cea4211ccc70d500b39ee9df6da5d46c2b863af","author":{"email":"9b95ce62b57d299cd99a3d268f375e473aac272b@liferay.com","name":"Iván Zaera Avellón"},"message":"LPS-54010 Make ItemSelector receive a whole PortletRequest instead of its parameter map.\n\nThis is done for two reasons:\n1) Coherency: it doesn't make sense to pass a generic map if we are assuming that it can only come from a request.\n2) Because we will need it later to create URLs.","distinct":true,"url":"https://api.github.com/repos/natecavanaugh/liferay-portal/commits/6cea4211ccc70d500b39ee9df6da5d46c2b863af"},{"sha":"7b9b6569b55ca67f917a300feace50c084d3c4e4","author":{"email":"9b95ce62b57d299cd99a3d268f375e473aac272b@liferay.com","name":"Iván Zaera Avellón"},"message":"LPS-54010 Convert ItemSelectorViewRenderer into an interface to make API cleaner and easier to maintain.","distinct":true,"url":"https://api.github.com/repos/natecavanaugh/liferay-portal/commits/7b9b6569b55ca67f917a300feace50c084d3c4e4"},{"sha":"a21c2705ed669eaf5d744fda65625411e2546753","author":{"email":"9b95ce62b57d299cd99a3d268f375e473aac272b@liferay.com","name":"Iván Zaera Avellón"},"message":"LPS-54010 Ungenerify ItemSelectorRendering and ItemSelectorViewRenderer to make code cleaner.\n\nEven if it made sense to generify them, it added no benefit because these objects are reconstructed from the parameters of a request, so it's impossible that people using them can know their types in advance when the code is statically compiled.","distinct":true,"url":"https://api.github.com/repos/natecavanaugh/liferay-portal/commits/a21c2705ed669eaf5d744fda65625411e2546753"},{"sha":"cfe2938b8312c847ca9b8be5b301d44a953d9290","author":{"email":"9b95ce62b57d299cd99a3d268f375e473aac272b@liferay.com","name":"Iván Zaera Avellón"},"message":"LPS-54010 Simplify ItemSelectorViewRenderer interface to avoid passing objects as parameters if they have already been calculated by their ItemSelectorViewRenderer's owner ItemSelectorViewRendering.","distinct":true,"url":"https://api.github.com/repos/natecavanaugh/liferay-portal/commits/cfe2938b8312c847ca9b8be5b301d44a953d9290"},{"sha":"7a4de8df7e3a66fa70ed0927d2d33014ab1d4a33","author":{"email":"9b95ce62b57d299cd99a3d268f375e473aac272b@liferay.com","name":"Iván Zaera Avellón"},"message":"LPS-54010 Pass PortletURL to ItemSelectorViews so that they can call the server back again if they need to re-render the item selector.\n\nThis is needed, for example, to implement pagination.","distinct":true,"url":"https://api.github.com/repos/natecavanaugh/liferay-portal/commits/7a4de8df7e3a66fa70ed0927d2d33014ab1d4a33"},{"sha":"0a7647807f473786d49ead833b97a1da1f60c946","author":{"email":"9b95ce62b57d299cd99a3d268f375e473aac272b@liferay.com","name":"Iván Zaera Avellón"},"message":"LPS-54010 Add a selectedTab parameter to the item selector URL so that it can pre-select a tab.\n\nThis is not made available through the public API, but is instead used to create PortletURLs for views that, when called, restore the state of the selected tab.","distinct":true,"url":"https://api.github.com/repos/natecavanaugh/liferay-portal/commits/0a7647807f473786d49ead833b97a1da1f60c946"},{"sha":"155b642f7feffbf32116250da2ac1f8c35e25112","author":{"email":"9b95ce62b57d299cd99a3d268f375e473aac272b@liferay.com","name":"Iván Zaera Avellón"},"message":"LPS-54010 Simplify","distinct":true,"url":"https://api.github.com/repos/natecavanaugh/liferay-portal/commits/155b642f7feffbf32116250da2ac1f8c35e25112"},{"sha":"fd70180f9d52012dfe87b89cbc4ec60ebaebbf8d","author":{"email":"9b95ce62b57d299cd99a3d268f375e473aac272b@liferay.com","name":"Iván Zaera Avellón"},"message":"LPS-54010 SF","distinct":true,"url":"https://api.github.com/repos/natecavanaugh/liferay-portal/commits/fd70180f9d52012dfe87b89cbc4ec60ebaebbf8d"},{"sha":"524daa00177f0722fefc4da086f2e7e3489dc740","author":{"email":"9b95ce62b57d299cd99a3d268f375e473aac272b@liferay.com","name":"Iván Zaera Avellón"},"message":"LPS-54010 Rename wiki-item-selector to wiki-item-selector-web\n\nThe rationale behind not calling this module wiki-item-selector-web is that it is not a true web module. It has a Web-ContextPath, sure, but it is only used privately by itself to use JSP as templates to generate HTML content, which is made available through an OSGi published interface. All other modules ending in -web have a Web-ContextPath too, but in those cases, it is public and used to serve JSPs directly.\n\nSo, it's up to you, but if we name this -web we are exposing an implementation detail. That would force us, for example, to remove the -web in the future if we decided to render the HTML using Freemarker templates instead of JSPs.\n\nTo finish with, it's important to decide on this issue because we can expect to have more modules like this one, as we need to resort to JSPs whenever we need to render HTML content that uses Liferay's taglibs (which is the usual case when modularizing portal's core).\n</WARNING>\n\nLPS-54010 Rename wiki-item-selector to wiki-item-selector-web","distinct":true,"url":"https://api.github.com/repos/natecavanaugh/liferay-portal/commits/524daa00177f0722fefc4da086f2e7e3489dc740"},{"sha":"93e8f3987dd2c476f33763a2d2c0623332fdd90b","author":{"email":"9b95ce62b57d299cd99a3d268f375e473aac272b@liferay.com","name":"Iván Zaera Avellón"},"message":"LPS-54010 Rename document-selector as item-selector and split item-selector-web into item-selector-web and item-selector-api.\n\nThis way we advance in the modularization of this module and rename it to what it is going to be called in its final state.","distinct":true,"url":"https://api.github.com/repos/natecavanaugh/liferay-portal/commits/93e8f3987dd2c476f33763a2d2c0623332fdd90b"},{"sha":"cc9c7e4bd4033ace1638c1a4a7d092087c4a1def","author":{"email":"9b95ce62b57d299cd99a3d268f375e473aac272b@liferay.com","name":"Iván Zaera Avellón"},"message":"LPS-54010 Adapt portal to item-selector rename and split","distinct":true,"url":"https://api.github.com/repos/natecavanaugh/liferay-portal/commits/cc9c7e4bd4033ace1638c1a4a7d092087c4a1def"},{"sha":"dc3a62204eaaca00c7004cf71a967c23904fe5c6","author":{"email":"9b95ce62b57d299cd99a3d268f375e473aac272b@liferay.com","name":"Iván Zaera Avellón"},"message":"LPS-54010 Adapt wiki to item-selector rename and split","distinct":true,"url":"https://api.github.com/repos/natecavanaugh/liferay-portal/commits/dc3a62204eaaca00c7004cf71a967c23904fe5c6"},{"sha":"c05fb8c77e73d40434cf3c0ae227be8433f5e1dd","author":{"email":"9b95ce62b57d299cd99a3d268f375e473aac272b@liferay.com","name":"Iván Zaera Avellón"},"message":"LPS-54010 Adapt frontend to item-selector rename and split","distinct":true,"url":"https://api.github.com/repos/natecavanaugh/liferay-portal/commits/c05fb8c77e73d40434cf3c0ae227be8433f5e1dd"},{"sha":"ca77ab8659df340c3cafb7209fb952513c11cfcc","author":{"email":"19d87895fd866a870172ad2efba03013e296358f@liferay.com","name":"Brian Chan"},"message":"LPS-54010 Sort, and fix other place too","distinct":true,"url":"https://api.github.com/repos/natecavanaugh/liferay-portal/commits/ca77ab8659df340c3cafb7209fb952513c11cfcc"},{"sha":"a11a83a239e282f4fd1b76e87c0e2ca3432907f4","author":{"email":"19d87895fd866a870172ad2efba03013e296358f@liferay.com","name":"Brian Chan"},"message":"LPS-54010 Regen Eclipse","distinct":true,"url":"https://api.github.com/repos/natecavanaugh/liferay-portal/commits/a11a83a239e282f4fd1b76e87c0e2ca3432907f4"},{"sha":"72154ca3dfaafd78e286280eebe53f473826b066","author":{"email":"19d87895fd866a870172ad2efba03013e296358f@liferay.com","name":"Brian Chan"},"message":"LPS-54010 SF","distinct":true,"url":"https://api.github.com/repos/natecavanaugh/liferay-portal/commits/72154ca3dfaafd78e286280eebe53f473826b066"}]}