{"action":"created","comment":{"url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/pulls/comments/34142706","id":34142706,"diff_hunk":"@@ -131,27 +131,40 @@ public static Datasource getDatasource(final CRConfigUtil requestProcessorConfig\n \t\tDatasource ds = null;\n \t\tProperties dsHandle = requestProcessorConfig.getDatasourceHandleProperties();\n \t\tProperties dsProps = requestProcessorConfig.getDatasourceProperties();\n-\t\tif (dsHandle != null && dsHandle.size() != 0) {\n-\t\t\tif (dsHandle.containsKey(\"portalnodedb\")) {\n-\t\t\t\tString key = (String) dsHandle.get(\"portalnodedb\");\n-\t\t\t\tds = PortalNodeInteractor.getPortalnodeDatasource(key);\n-\t\t\t} else if (dsProps != null && dsProps.size() != 0) {\n-\t\t\t\tboolean mccr = ObjectTransformer.getBoolean(dsProps.get(\"mccr\"), false);\n-\t\t\t\tif (mccr) {\n-\t\t\t\t\tds = PortalConnectorFactory.createWritableMultichannellingDatasource(CRUtil.propertiesToMap(dsHandle), CRUtil.propertiesToMap(dsProps));\n+\t\t\n+\t\t//if a separatly configured datasource is defined for this requestProcessor, just fetch the ds by id\n+\t\tString dsName = requestProcessorConfig.getDatasourceName();\n+\t\tif(dsName != null && dsName != \"\"){\n+\t\t\ttry {\n+\t\t\t\tds = PortalConnectorFactory.createDatasource(dsName.toUpperCase());","path":"contentconnector-core/src/main/java/com/gentics/cr/CRDatabaseFactory.java","position":26,"original_position":26,"commit_id":"05ce9b432fa00c4e23f659b5dd70680453d82b67","original_commit_id":"05ce9b432fa00c4e23f659b5dd70680453d82b67","user":{"login":"npomaroli","id":326709,"avatar_url":"https://avatars.githubusercontent.com/u/326709?v=3","gravatar_id":"","url":"https://api.github.com/users/npomaroli","html_url":"https://github.com/npomaroli","followers_url":"https://api.github.com/users/npomaroli/followers","following_url":"https://api.github.com/users/npomaroli/following{/other_user}","gists_url":"https://api.github.com/users/npomaroli/gists{/gist_id}","starred_url":"https://api.github.com/users/npomaroli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npomaroli/subscriptions","organizations_url":"https://api.github.com/users/npomaroli/orgs","repos_url":"https://api.github.com/users/npomaroli/repos","events_url":"https://api.github.com/users/npomaroli/events{/privacy}","received_events_url":"https://api.github.com/users/npomaroli/received_events","type":"User","site_admin":false},"body":"convert the name with convertKey()","created_at":"2015-07-08T12:45:00Z","updated_at":"2015-07-08T12:45:00Z","html_url":"https://github.com/gtxcontentconnector/contentconnector/pull/46#discussion_r34142706","pull_request_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/gtxcontentconnector/contentconnector/pulls/comments/34142706"},"html":{"href":"https://github.com/gtxcontentconnector/contentconnector/pull/46#discussion_r34142706"},"pull_request":{"href":"https://api.github.com/repos/gtxcontentconnector/contentconnector/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/pulls/46","id":39469924,"html_url":"https://github.com/gtxcontentconnector/contentconnector/pull/46","diff_url":"https://github.com/gtxcontentconnector/contentconnector/pull/46.diff","patch_url":"https://github.com/gtxcontentconnector/contentconnector/pull/46.patch","issue_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/issues/46","number":46,"state":"open","locked":false,"title":"GI-48 Multiple Database Handles for a datasource","user":{"login":"patrickhoefer","id":1941613,"avatar_url":"https://avatars.githubusercontent.com/u/1941613?v=3","gravatar_id":"","url":"https://api.github.com/users/patrickhoefer","html_url":"https://github.com/patrickhoefer","followers_url":"https://api.github.com/users/patrickhoefer/followers","following_url":"https://api.github.com/users/patrickhoefer/following{/other_user}","gists_url":"https://api.github.com/users/patrickhoefer/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickhoefer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickhoefer/subscriptions","organizations_url":"https://api.github.com/users/patrickhoefer/orgs","repos_url":"https://api.github.com/users/patrickhoefer/repos","events_url":"https://api.github.com/users/patrickhoefer/events{/privacy}","received_events_url":"https://api.github.com/users/patrickhoefer/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-07-08T12:10:38Z","updated_at":"2015-07-08T12:45:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"72fec38eabbef1113f991dfe0632e16f5bb609e9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/pulls/46/commits","review_comments_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/pulls/46/comments","review_comment_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/issues/46/comments","statuses_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/statuses/05ce9b432fa00c4e23f659b5dd70680453d82b67","head":{"label":"patrickhoefer:hotfix-2.0.x-GI-48","ref":"hotfix-2.0.x-GI-48","sha":"05ce9b432fa00c4e23f659b5dd70680453d82b67","user":{"login":"patrickhoefer","id":1941613,"avatar_url":"https://avatars.githubusercontent.com/u/1941613?v=3","gravatar_id":"","url":"https://api.github.com/users/patrickhoefer","html_url":"https://github.com/patrickhoefer","followers_url":"https://api.github.com/users/patrickhoefer/followers","following_url":"https://api.github.com/users/patrickhoefer/following{/other_user}","gists_url":"https://api.github.com/users/patrickhoefer/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickhoefer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickhoefer/subscriptions","organizations_url":"https://api.github.com/users/patrickhoefer/orgs","repos_url":"https://api.github.com/users/patrickhoefer/repos","events_url":"https://api.github.com/users/patrickhoefer/events{/privacy}","received_events_url":"https://api.github.com/users/patrickhoefer/received_events","type":"User","site_admin":false},"repo":{"id":25524797,"name":"contentconnector","full_name":"patrickhoefer/contentconnector","owner":{"login":"patrickhoefer","id":1941613,"avatar_url":"https://avatars.githubusercontent.com/u/1941613?v=3","gravatar_id":"","url":"https://api.github.com/users/patrickhoefer","html_url":"https://github.com/patrickhoefer","followers_url":"https://api.github.com/users/patrickhoefer/followers","following_url":"https://api.github.com/users/patrickhoefer/following{/other_user}","gists_url":"https://api.github.com/users/patrickhoefer/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickhoefer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickhoefer/subscriptions","organizations_url":"https://api.github.com/users/patrickhoefer/orgs","repos_url":"https://api.github.com/users/patrickhoefer/repos","events_url":"https://api.github.com/users/patrickhoefer/events{/privacy}","received_events_url":"https://api.github.com/users/patrickhoefer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/patrickhoefer/contentconnector","description":"The Gentics Content Connector provides a simple solution to serve content from a Gentics Content Repository and other Datasources. The Suite is intended (but not limited) to be used for web applications and when used in servlets or portlets it maxes out the benefits of the given environment.","fork":true,"url":"https://api.github.com/repos/patrickhoefer/contentconnector","forks_url":"https://api.github.com/repos/patrickhoefer/contentconnector/forks","keys_url":"https://api.github.com/repos/patrickhoefer/contentconnector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/patrickhoefer/contentconnector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/patrickhoefer/contentconnector/teams","hooks_url":"https://api.github.com/repos/patrickhoefer/contentconnector/hooks","issue_events_url":"https://api.github.com/repos/patrickhoefer/contentconnector/issues/events{/number}","events_url":"https://api.github.com/repos/patrickhoefer/contentconnector/events","assignees_url":"https://api.github.com/repos/patrickhoefer/contentconnector/assignees{/user}","branches_url":"https://api.github.com/repos/patrickhoefer/contentconnector/branches{/branch}","tags_url":"https://api.github.com/repos/patrickhoefer/contentconnector/tags","blobs_url":"https://api.github.com/repos/patrickhoefer/contentconnector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/patrickhoefer/contentconnector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/patrickhoefer/contentconnector/git/refs{/sha}","trees_url":"https://api.github.com/repos/patrickhoefer/contentconnector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/patrickhoefer/contentconnector/statuses/{sha}","languages_url":"https://api.github.com/repos/patrickhoefer/contentconnector/languages","stargazers_url":"https://api.github.com/repos/patrickhoefer/contentconnector/stargazers","contributors_url":"https://api.github.com/repos/patrickhoefer/contentconnector/contributors","subscribers_url":"https://api.github.com/repos/patrickhoefer/contentconnector/subscribers","subscription_url":"https://api.github.com/repos/patrickhoefer/contentconnector/subscription","commits_url":"https://api.github.com/repos/patrickhoefer/contentconnector/commits{/sha}","git_commits_url":"https://api.github.com/repos/patrickhoefer/contentconnector/git/commits{/sha}","comments_url":"https://api.github.com/repos/patrickhoefer/contentconnector/comments{/number}","issue_comment_url":"https://api.github.com/repos/patrickhoefer/contentconnector/issues/comments{/number}","contents_url":"https://api.github.com/repos/patrickhoefer/contentconnector/contents/{+path}","compare_url":"https://api.github.com/repos/patrickhoefer/contentconnector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/patrickhoefer/contentconnector/merges","archive_url":"https://api.github.com/repos/patrickhoefer/contentconnector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/patrickhoefer/contentconnector/downloads","issues_url":"https://api.github.com/repos/patrickhoefer/contentconnector/issues{/number}","pulls_url":"https://api.github.com/repos/patrickhoefer/contentconnector/pulls{/number}","milestones_url":"https://api.github.com/repos/patrickhoefer/contentconnector/milestones{/number}","notifications_url":"https://api.github.com/repos/patrickhoefer/contentconnector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/patrickhoefer/contentconnector/labels{/name}","releases_url":"https://api.github.com/repos/patrickhoefer/contentconnector/releases{/id}","created_at":"2014-10-21T13:46:53Z","updated_at":"2014-09-23T08:51:48Z","pushed_at":"2015-07-08T12:07:56Z","git_url":"git://github.com/patrickhoefer/contentconnector.git","ssh_url":"git@github.com:patrickhoefer/contentconnector.git","clone_url":"https://github.com/patrickhoefer/contentconnector.git","svn_url":"https://github.com/patrickhoefer/contentconnector","homepage":null,"size":55471,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gtxcontentconnector:hotfix-2.0.x","ref":"hotfix-2.0.x","sha":"d73ecfe2ee27530369d8a8a792e8e75be776483e","user":{"login":"gtxcontentconnector","id":3840954,"avatar_url":"https://avatars.githubusercontent.com/u/3840954?v=3","gravatar_id":"","url":"https://api.github.com/users/gtxcontentconnector","html_url":"https://github.com/gtxcontentconnector","followers_url":"https://api.github.com/users/gtxcontentconnector/followers","following_url":"https://api.github.com/users/gtxcontentconnector/following{/other_user}","gists_url":"https://api.github.com/users/gtxcontentconnector/gists{/gist_id}","starred_url":"https://api.github.com/users/gtxcontentconnector/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtxcontentconnector/subscriptions","organizations_url":"https://api.github.com/users/gtxcontentconnector/orgs","repos_url":"https://api.github.com/users/gtxcontentconnector/repos","events_url":"https://api.github.com/users/gtxcontentconnector/events{/privacy}","received_events_url":"https://api.github.com/users/gtxcontentconnector/received_events","type":"Organization","site_admin":false},"repo":{"id":8747691,"name":"contentconnector","full_name":"gtxcontentconnector/contentconnector","owner":{"login":"gtxcontentconnector","id":3840954,"avatar_url":"https://avatars.githubusercontent.com/u/3840954?v=3","gravatar_id":"","url":"https://api.github.com/users/gtxcontentconnector","html_url":"https://github.com/gtxcontentconnector","followers_url":"https://api.github.com/users/gtxcontentconnector/followers","following_url":"https://api.github.com/users/gtxcontentconnector/following{/other_user}","gists_url":"https://api.github.com/users/gtxcontentconnector/gists{/gist_id}","starred_url":"https://api.github.com/users/gtxcontentconnector/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtxcontentconnector/subscriptions","organizations_url":"https://api.github.com/users/gtxcontentconnector/orgs","repos_url":"https://api.github.com/users/gtxcontentconnector/repos","events_url":"https://api.github.com/users/gtxcontentconnector/events{/privacy}","received_events_url":"https://api.github.com/users/gtxcontentconnector/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gtxcontentconnector/contentconnector","description":"The Gentics Content Connector provides a simple solution to serve content from a Gentics Content Repository and other Datasources. The Suite is intended (but not limited) to be used for web applications and when used in servlets or portlets it maxes out the benefits of the given environment.","fork":false,"url":"https://api.github.com/repos/gtxcontentconnector/contentconnector","forks_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/forks","keys_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/teams","hooks_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/hooks","issue_events_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/issues/events{/number}","events_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/events","assignees_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/assignees{/user}","branches_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/branches{/branch}","tags_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/tags","blobs_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/git/refs{/sha}","trees_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/statuses/{sha}","languages_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/languages","stargazers_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/stargazers","contributors_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/contributors","subscribers_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/subscribers","subscription_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/subscription","commits_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/commits{/sha}","git_commits_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/git/commits{/sha}","comments_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/comments{/number}","issue_comment_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/issues/comments{/number}","contents_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/contents/{+path}","compare_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/merges","archive_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/downloads","issues_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/issues{/number}","pulls_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/pulls{/number}","milestones_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/milestones{/number}","notifications_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/labels{/name}","releases_url":"https://api.github.com/repos/gtxcontentconnector/contentconnector/releases{/id}","created_at":"2013-03-13T08:07:38Z","updated_at":"2014-09-23T08:51:48Z","pushed_at":"2015-07-08T12:10:39Z","git_url":"git://github.com/gtxcontentconnector/contentconnector.git","ssh_url":"git@github.com:gtxcontentconnector/contentconnector.git","clone_url":"https://github.com/gtxcontentconnector/contentconnector.git","svn_url":"https://github.com/gtxcontentconnector/contentconnector","homepage":null,"size":56726,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":3,"forks":11,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gtxcontentconnector/contentconnector/pulls/46"},"html":{"href":"https://github.com/gtxcontentconnector/contentconnector/pull/46"},"issue":{"href":"https://api.github.com/repos/gtxcontentconnector/contentconnector/issues/46"},"comments":{"href":"https://api.github.com/repos/gtxcontentconnector/contentconnector/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/gtxcontentconnector/contentconnector/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/gtxcontentconnector/contentconnector/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gtxcontentconnector/contentconnector/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/gtxcontentconnector/contentconnector/statuses/05ce9b432fa00c4e23f659b5dd70680453d82b67"}}}}