{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/24855275","id":24855275,"diff_hunk":"@@ -29,29 +45,41 @@ def get_options_hash(dialog_options)\n     option_key = k.downcase.to_sym\n     if options_regex =~ k\n       sequence_id = Regexp.last_match[2].to_i\n+      next if v.blank?\n \n-      unless v.blank?\n-        $evm.log(\"info\", \"Adding sequence_id:<#{sequence_id}> option_key:<#{option_key.inspect}> v:<#{v.inspect}> to options_hash\")\n-        if options_hash.key?(sequence_id)\n-          options_hash[sequence_id][option_key] = v\n-        else\n-          options_hash[sequence_id] = {option_key => v}\n+      $evm.log(\"info\", \"Adding seq_id:<#{sequence_id}> key:<#{option_key}> value:<#{v}>\")\n+      if options_hash.key?(sequence_id)\n+        options_hash[sequence_id][option_key] = v\n+      else\n+        options_hash[sequence_id] = {option_key => v}","path":"vmdb/db/fixtures/ae_datastore/ManageIQ/Service/Provisioning/StateMachines/Methods.class/__methods__/catalogbundleinitialization.rb","position":47,"original_position":47,"commit_id":"8e5d6c1943cc9a0c5c3727f66eff223e14919862","original_commit_id":"8e5d6c1943cc9a0c5c3727f66eff223e14919862","user":{"login":"Fryguy","id":52120,"avatar_url":"https://avatars.githubusercontent.com/u/52120?v=3","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"body":"Both of these conditions are handled by store_path, so this all simplifies to...\r\n\r\n```ruby\r\noptions_hash.store_path(sequence_id, option_key, v)\r\n```","created_at":"2015-02-17T21:23:20Z","updated_at":"2015-02-17T21:23:20Z","html_url":"https://github.com/ManageIQ/manageiq/pull/1745#discussion_r24855275","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1745","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/24855275"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/1745#discussion_r24855275"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1745"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1745","id":29454332,"html_url":"https://github.com/ManageIQ/manageiq/pull/1745","diff_url":"https://github.com/ManageIQ/manageiq/pull/1745.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/1745.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/1745","number":1745,"state":"open","locked":false,"title":"Changed catalog initialization methods to handle array values.","user":{"login":"tinaafitz","id":109132,"avatar_url":"https://avatars.githubusercontent.com/u/109132?v=3","gravatar_id":"","url":"https://api.github.com/users/tinaafitz","html_url":"https://github.com/tinaafitz","followers_url":"https://api.github.com/users/tinaafitz/followers","following_url":"https://api.github.com/users/tinaafitz/following{/other_user}","gists_url":"https://api.github.com/users/tinaafitz/gists{/gist_id}","starred_url":"https://api.github.com/users/tinaafitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinaafitz/subscriptions","organizations_url":"https://api.github.com/users/tinaafitz/orgs","repos_url":"https://api.github.com/users/tinaafitz/repos","events_url":"https://api.github.com/users/tinaafitz/events{/privacy}","received_events_url":"https://api.github.com/users/tinaafitz/received_events","type":"User","site_admin":false},"body":"Service dialogs tag_control passes array format to methods and need to\r\nbe parsed for tags and options hashes.\r\n\r\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1184267","created_at":"2015-02-17T16:12:47Z","updated_at":"2015-02-17T21:23:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"793895edac592b8798aec6d112736312c919060b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1745/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1745/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/1745/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/8e5d6c1943cc9a0c5c3727f66eff223e14919862","head":{"label":"tinaafitz:automate_service_methods_change","ref":"automate_service_methods_change","sha":"8e5d6c1943cc9a0c5c3727f66eff223e14919862","user":{"login":"tinaafitz","id":109132,"avatar_url":"https://avatars.githubusercontent.com/u/109132?v=3","gravatar_id":"","url":"https://api.github.com/users/tinaafitz","html_url":"https://github.com/tinaafitz","followers_url":"https://api.github.com/users/tinaafitz/followers","following_url":"https://api.github.com/users/tinaafitz/following{/other_user}","gists_url":"https://api.github.com/users/tinaafitz/gists{/gist_id}","starred_url":"https://api.github.com/users/tinaafitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinaafitz/subscriptions","organizations_url":"https://api.github.com/users/tinaafitz/orgs","repos_url":"https://api.github.com/users/tinaafitz/repos","events_url":"https://api.github.com/users/tinaafitz/events{/privacy}","received_events_url":"https://api.github.com/users/tinaafitz/received_events","type":"User","site_admin":false},"repo":{"id":20941192,"name":"manageiq","full_name":"tinaafitz/manageiq","owner":{"login":"tinaafitz","id":109132,"avatar_url":"https://avatars.githubusercontent.com/u/109132?v=3","gravatar_id":"","url":"https://api.github.com/users/tinaafitz","html_url":"https://github.com/tinaafitz","followers_url":"https://api.github.com/users/tinaafitz/followers","following_url":"https://api.github.com/users/tinaafitz/following{/other_user}","gists_url":"https://api.github.com/users/tinaafitz/gists{/gist_id}","starred_url":"https://api.github.com/users/tinaafitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinaafitz/subscriptions","organizations_url":"https://api.github.com/users/tinaafitz/orgs","repos_url":"https://api.github.com/users/tinaafitz/repos","events_url":"https://api.github.com/users/tinaafitz/events{/privacy}","received_events_url":"https://api.github.com/users/tinaafitz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tinaafitz/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/tinaafitz/manageiq","forks_url":"https://api.github.com/repos/tinaafitz/manageiq/forks","keys_url":"https://api.github.com/repos/tinaafitz/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tinaafitz/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tinaafitz/manageiq/teams","hooks_url":"https://api.github.com/repos/tinaafitz/manageiq/hooks","issue_events_url":"https://api.github.com/repos/tinaafitz/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/tinaafitz/manageiq/events","assignees_url":"https://api.github.com/repos/tinaafitz/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/tinaafitz/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/tinaafitz/manageiq/tags","blobs_url":"https://api.github.com/repos/tinaafitz/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tinaafitz/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tinaafitz/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/tinaafitz/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tinaafitz/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/tinaafitz/manageiq/languages","stargazers_url":"https://api.github.com/repos/tinaafitz/manageiq/stargazers","contributors_url":"https://api.github.com/repos/tinaafitz/manageiq/contributors","subscribers_url":"https://api.github.com/repos/tinaafitz/manageiq/subscribers","subscription_url":"https://api.github.com/repos/tinaafitz/manageiq/subscription","commits_url":"https://api.github.com/repos/tinaafitz/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/tinaafitz/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/tinaafitz/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/tinaafitz/manageiq/issues/comments/{number}","contents_url":"https://api.github.com/repos/tinaafitz/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/tinaafitz/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tinaafitz/manageiq/merges","archive_url":"https://api.github.com/repos/tinaafitz/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tinaafitz/manageiq/downloads","issues_url":"https://api.github.com/repos/tinaafitz/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/tinaafitz/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/tinaafitz/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/tinaafitz/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tinaafitz/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/tinaafitz/manageiq/releases{/id}","created_at":"2014-06-17T22:10:42Z","updated_at":"2014-06-23T14:25:51Z","pushed_at":"2015-02-17T21:19:45Z","git_url":"git://github.com/tinaafitz/manageiq.git","ssh_url":"git@github.com:tinaafitz/manageiq.git","clone_url":"https://github.com/tinaafitz/manageiq.git","svn_url":"https://github.com/tinaafitz/manageiq","homepage":null,"size":63989,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"82027846ff1aab1943cad86c97ffc1ff9c065513","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/{number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2015-02-17T20:17:55Z","pushed_at":"2015-02-17T20:17:55Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":97240,"stargazers_count":87,"watchers_count":87,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":87,"mirror_url":null,"open_issues_count":277,"forks":87,"open_issues":277,"watchers":87,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1745"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/1745"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/1745"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/1745/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1745/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1745/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/8e5d6c1943cc9a0c5c3727f66eff223e14919862"}}}}