{"action":"closed","number":4071,"pull_request":{"url":"https://api.github.com/repos/Itseez/opencv/pulls/4071","id":36337888,"html_url":"https://github.com/Itseez/opencv/pull/4071","diff_url":"https://github.com/Itseez/opencv/pull/4071.diff","patch_url":"https://github.com/Itseez/opencv/pull/4071.patch","issue_url":"https://api.github.com/repos/Itseez/opencv/issues/4071","number":4071,"state":"closed","locked":false,"title":"fix isContourConvex","user":{"login":"sergarrido","id":11378576,"avatar_url":"https://avatars.githubusercontent.com/u/11378576?v=3","gravatar_id":"","url":"https://api.github.com/users/sergarrido","html_url":"https://github.com/sergarrido","followers_url":"https://api.github.com/users/sergarrido/followers","following_url":"https://api.github.com/users/sergarrido/following{/other_user}","gists_url":"https://api.github.com/users/sergarrido/gists{/gist_id}","starred_url":"https://api.github.com/users/sergarrido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergarrido/subscriptions","organizations_url":"https://api.github.com/users/sergarrido/orgs","repos_url":"https://api.github.com/users/sergarrido/repos","events_url":"https://api.github.com/users/sergarrido/events{/privacy}","received_events_url":"https://api.github.com/users/sergarrido/received_events","type":"User","site_admin":false},"body":"Correct a bug in isContourConvex function.\r\n\r\nConvexity is checked by analizying the crossproducts of each consecutive pair of vectors in the contour. If the size of the contour is N, there should be N crossproducts.\r\n\r\nThe convexity was not being checked in one of the contour points (the penultimate one). \r\nThe stop condition in the *for* loop was wrong.\r\n\r\nExample of contour that was producing erroneous result:\r\n*(328, 26)*\r\n*(638, 199)*\r\n*(500, 44)*\r\n*(628, 1)*\r\n\r\nIt is a non-convex contour, but the function was returning true.\r\n\r\n","created_at":"2015-05-27T19:09:51Z","updated_at":"2015-05-28T14:44:48Z","closed_at":"2015-05-28T14:44:48Z","merged_at":"2015-05-28T14:44:48Z","merge_commit_sha":"6b9c416cffd7065e0ceecf4fc032cee0bc3ccbc0","assignee":{"login":"vpisarev","id":2110786,"avatar_url":"https://avatars.githubusercontent.com/u/2110786?v=3","gravatar_id":"","url":"https://api.github.com/users/vpisarev","html_url":"https://github.com/vpisarev","followers_url":"https://api.github.com/users/vpisarev/followers","following_url":"https://api.github.com/users/vpisarev/following{/other_user}","gists_url":"https://api.github.com/users/vpisarev/gists{/gist_id}","starred_url":"https://api.github.com/users/vpisarev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vpisarev/subscriptions","organizations_url":"https://api.github.com/users/vpisarev/orgs","repos_url":"https://api.github.com/users/vpisarev/repos","events_url":"https://api.github.com/users/vpisarev/events{/privacy}","received_events_url":"https://api.github.com/users/vpisarev/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Itseez/opencv/pulls/4071/commits","review_comments_url":"https://api.github.com/repos/Itseez/opencv/pulls/4071/comments","review_comment_url":"https://api.github.com/repos/Itseez/opencv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Itseez/opencv/issues/4071/comments","statuses_url":"https://api.github.com/repos/Itseez/opencv/statuses/bd2c2f3bd15bc9458519f8fd52b98e30067e8a6f","head":{"label":"sergarrido:fix_isContourConvex","ref":"fix_isContourConvex","sha":"bd2c2f3bd15bc9458519f8fd52b98e30067e8a6f","user":{"login":"sergarrido","id":11378576,"avatar_url":"https://avatars.githubusercontent.com/u/11378576?v=3","gravatar_id":"","url":"https://api.github.com/users/sergarrido","html_url":"https://github.com/sergarrido","followers_url":"https://api.github.com/users/sergarrido/followers","following_url":"https://api.github.com/users/sergarrido/following{/other_user}","gists_url":"https://api.github.com/users/sergarrido/gists{/gist_id}","starred_url":"https://api.github.com/users/sergarrido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergarrido/subscriptions","organizations_url":"https://api.github.com/users/sergarrido/orgs","repos_url":"https://api.github.com/users/sergarrido/repos","events_url":"https://api.github.com/users/sergarrido/events{/privacy}","received_events_url":"https://api.github.com/users/sergarrido/received_events","type":"User","site_admin":false},"repo":{"id":33782977,"name":"opencv","full_name":"sergarrido/opencv","owner":{"login":"sergarrido","id":11378576,"avatar_url":"https://avatars.githubusercontent.com/u/11378576?v=3","gravatar_id":"","url":"https://api.github.com/users/sergarrido","html_url":"https://github.com/sergarrido","followers_url":"https://api.github.com/users/sergarrido/followers","following_url":"https://api.github.com/users/sergarrido/following{/other_user}","gists_url":"https://api.github.com/users/sergarrido/gists{/gist_id}","starred_url":"https://api.github.com/users/sergarrido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergarrido/subscriptions","organizations_url":"https://api.github.com/users/sergarrido/orgs","repos_url":"https://api.github.com/users/sergarrido/repos","events_url":"https://api.github.com/users/sergarrido/events{/privacy}","received_events_url":"https://api.github.com/users/sergarrido/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sergarrido/opencv","description":"Open Source Computer Vision Library","fork":true,"url":"https://api.github.com/repos/sergarrido/opencv","forks_url":"https://api.github.com/repos/sergarrido/opencv/forks","keys_url":"https://api.github.com/repos/sergarrido/opencv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sergarrido/opencv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sergarrido/opencv/teams","hooks_url":"https://api.github.com/repos/sergarrido/opencv/hooks","issue_events_url":"https://api.github.com/repos/sergarrido/opencv/issues/events{/number}","events_url":"https://api.github.com/repos/sergarrido/opencv/events","assignees_url":"https://api.github.com/repos/sergarrido/opencv/assignees{/user}","branches_url":"https://api.github.com/repos/sergarrido/opencv/branches{/branch}","tags_url":"https://api.github.com/repos/sergarrido/opencv/tags","blobs_url":"https://api.github.com/repos/sergarrido/opencv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sergarrido/opencv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sergarrido/opencv/git/refs{/sha}","trees_url":"https://api.github.com/repos/sergarrido/opencv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sergarrido/opencv/statuses/{sha}","languages_url":"https://api.github.com/repos/sergarrido/opencv/languages","stargazers_url":"https://api.github.com/repos/sergarrido/opencv/stargazers","contributors_url":"https://api.github.com/repos/sergarrido/opencv/contributors","subscribers_url":"https://api.github.com/repos/sergarrido/opencv/subscribers","subscription_url":"https://api.github.com/repos/sergarrido/opencv/subscription","commits_url":"https://api.github.com/repos/sergarrido/opencv/commits{/sha}","git_commits_url":"https://api.github.com/repos/sergarrido/opencv/git/commits{/sha}","comments_url":"https://api.github.com/repos/sergarrido/opencv/comments{/number}","issue_comment_url":"https://api.github.com/repos/sergarrido/opencv/issues/comments{/number}","contents_url":"https://api.github.com/repos/sergarrido/opencv/contents/{+path}","compare_url":"https://api.github.com/repos/sergarrido/opencv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sergarrido/opencv/merges","archive_url":"https://api.github.com/repos/sergarrido/opencv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sergarrido/opencv/downloads","issues_url":"https://api.github.com/repos/sergarrido/opencv/issues{/number}","pulls_url":"https://api.github.com/repos/sergarrido/opencv/pulls{/number}","milestones_url":"https://api.github.com/repos/sergarrido/opencv/milestones{/number}","notifications_url":"https://api.github.com/repos/sergarrido/opencv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sergarrido/opencv/labels{/name}","releases_url":"https://api.github.com/repos/sergarrido/opencv/releases{/id}","created_at":"2015-04-11T16:22:35Z","updated_at":"2015-05-05T16:35:03Z","pushed_at":"2015-05-27T18:52:13Z","git_url":"git://github.com/sergarrido/opencv.git","ssh_url":"git@github.com:sergarrido/opencv.git","clone_url":"https://github.com/sergarrido/opencv.git","svn_url":"https://github.com/sergarrido/opencv","homepage":"opencv.org","size":440226,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Itseez:master","ref":"master","sha":"565d3dde40ee4d8ef0db3c16d35d93cc5c5bc6a5","user":{"login":"Itseez","id":1786446,"avatar_url":"https://avatars.githubusercontent.com/u/1786446?v=3","gravatar_id":"","url":"https://api.github.com/users/Itseez","html_url":"https://github.com/Itseez","followers_url":"https://api.github.com/users/Itseez/followers","following_url":"https://api.github.com/users/Itseez/following{/other_user}","gists_url":"https://api.github.com/users/Itseez/gists{/gist_id}","starred_url":"https://api.github.com/users/Itseez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Itseez/subscriptions","organizations_url":"https://api.github.com/users/Itseez/orgs","repos_url":"https://api.github.com/users/Itseez/repos","events_url":"https://api.github.com/users/Itseez/events{/privacy}","received_events_url":"https://api.github.com/users/Itseez/received_events","type":"Organization","site_admin":false},"repo":{"id":5108051,"name":"opencv","full_name":"Itseez/opencv","owner":{"login":"Itseez","id":1786446,"avatar_url":"https://avatars.githubusercontent.com/u/1786446?v=3","gravatar_id":"","url":"https://api.github.com/users/Itseez","html_url":"https://github.com/Itseez","followers_url":"https://api.github.com/users/Itseez/followers","following_url":"https://api.github.com/users/Itseez/following{/other_user}","gists_url":"https://api.github.com/users/Itseez/gists{/gist_id}","starred_url":"https://api.github.com/users/Itseez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Itseez/subscriptions","organizations_url":"https://api.github.com/users/Itseez/orgs","repos_url":"https://api.github.com/users/Itseez/repos","events_url":"https://api.github.com/users/Itseez/events{/privacy}","received_events_url":"https://api.github.com/users/Itseez/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Itseez/opencv","description":"Open Source Computer Vision Library","fork":false,"url":"https://api.github.com/repos/Itseez/opencv","forks_url":"https://api.github.com/repos/Itseez/opencv/forks","keys_url":"https://api.github.com/repos/Itseez/opencv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Itseez/opencv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Itseez/opencv/teams","hooks_url":"https://api.github.com/repos/Itseez/opencv/hooks","issue_events_url":"https://api.github.com/repos/Itseez/opencv/issues/events{/number}","events_url":"https://api.github.com/repos/Itseez/opencv/events","assignees_url":"https://api.github.com/repos/Itseez/opencv/assignees{/user}","branches_url":"https://api.github.com/repos/Itseez/opencv/branches{/branch}","tags_url":"https://api.github.com/repos/Itseez/opencv/tags","blobs_url":"https://api.github.com/repos/Itseez/opencv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Itseez/opencv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Itseez/opencv/git/refs{/sha}","trees_url":"https://api.github.com/repos/Itseez/opencv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Itseez/opencv/statuses/{sha}","languages_url":"https://api.github.com/repos/Itseez/opencv/languages","stargazers_url":"https://api.github.com/repos/Itseez/opencv/stargazers","contributors_url":"https://api.github.com/repos/Itseez/opencv/contributors","subscribers_url":"https://api.github.com/repos/Itseez/opencv/subscribers","subscription_url":"https://api.github.com/repos/Itseez/opencv/subscription","commits_url":"https://api.github.com/repos/Itseez/opencv/commits{/sha}","git_commits_url":"https://api.github.com/repos/Itseez/opencv/git/commits{/sha}","comments_url":"https://api.github.com/repos/Itseez/opencv/comments{/number}","issue_comment_url":"https://api.github.com/repos/Itseez/opencv/issues/comments{/number}","contents_url":"https://api.github.com/repos/Itseez/opencv/contents/{+path}","compare_url":"https://api.github.com/repos/Itseez/opencv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Itseez/opencv/merges","archive_url":"https://api.github.com/repos/Itseez/opencv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Itseez/opencv/downloads","issues_url":"https://api.github.com/repos/Itseez/opencv/issues{/number}","pulls_url":"https://api.github.com/repos/Itseez/opencv/pulls{/number}","milestones_url":"https://api.github.com/repos/Itseez/opencv/milestones{/number}","notifications_url":"https://api.github.com/repos/Itseez/opencv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Itseez/opencv/labels{/name}","releases_url":"https://api.github.com/repos/Itseez/opencv/releases{/id}","created_at":"2012-07-19T09:40:17Z","updated_at":"2015-05-28T13:48:23Z","pushed_at":"2015-05-28T14:44:40Z","git_url":"git://github.com/Itseez/opencv.git","ssh_url":"git@github.com:Itseez/opencv.git","clone_url":"https://github.com/Itseez/opencv.git","svn_url":"https://github.com/Itseez/opencv","homepage":"opencv.org","size":1457346,"stargazers_count":5458,"watchers_count":5458,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5018,"mirror_url":null,"open_issues_count":28,"forks":5018,"open_issues":28,"watchers":5458,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Itseez/opencv/pulls/4071"},"html":{"href":"https://github.com/Itseez/opencv/pull/4071"},"issue":{"href":"https://api.github.com/repos/Itseez/opencv/issues/4071"},"comments":{"href":"https://api.github.com/repos/Itseez/opencv/issues/4071/comments"},"review_comments":{"href":"https://api.github.com/repos/Itseez/opencv/pulls/4071/comments"},"review_comment":{"href":"https://api.github.com/repos/Itseez/opencv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Itseez/opencv/pulls/4071/commits"},"statuses":{"href":"https://api.github.com/repos/Itseez/opencv/statuses/bd2c2f3bd15bc9458519f8fd52b98e30067e8a6f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"opencv-pushbot","id":2051563,"avatar_url":"https://avatars.githubusercontent.com/u/2051563?v=3","gravatar_id":"","url":"https://api.github.com/users/opencv-pushbot","html_url":"https://github.com/opencv-pushbot","followers_url":"https://api.github.com/users/opencv-pushbot/followers","following_url":"https://api.github.com/users/opencv-pushbot/following{/other_user}","gists_url":"https://api.github.com/users/opencv-pushbot/gists{/gist_id}","starred_url":"https://api.github.com/users/opencv-pushbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencv-pushbot/subscriptions","organizations_url":"https://api.github.com/users/opencv-pushbot/orgs","repos_url":"https://api.github.com/users/opencv-pushbot/repos","events_url":"https://api.github.com/users/opencv-pushbot/events{/privacy}","received_events_url":"https://api.github.com/users/opencv-pushbot/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}