{"action":"created","comment":{"url":"https://api.github.com/repos/tlswg/tls13-spec/pulls/comments/36972954","id":36972954,"diff_hunk":"@@ -3159,37 +3165,41 @@ The exact source of each of these secrets depends on the operational\n mode (DHE, ECDHE, PSK, etc.) and is summarized in the table below:\n \n ~~~\n-    Key Exchange            Static Secret (SS)    Ephemeral Secret (ES)\n-    ------------            ------------------    ---------------------\n-    (EC)DHE                   Client ephemeral         Client ephemeral\n-    (full handshake)       w/ server ephemeral      w/ server ephemeral\n+    Key Exchange     Static Secret (SS)    Ephemeral Secret (ES)\n+    ------------     ------------------    ---------------------\n+    1-RTT (EC)DHE       N/A (SS = ES)        Client Ephemeral\n+                                           + Server Ephemeral\n \n-    (EC)DHE                   Client ephemeral         Client ephemeral\n-    (w/ 0-RTT)                w/ server static      w/ server ephemeral\n+    0-RTT (EC)DHE     Client Ephemeral       Client Ephemeral\n+                      + Server Static      + Server Ephemeral\n \n-    PSK                         Pre-Shared Key           Pre-shared key\n+    PSK                Pre-Shared Key          N/A (ES = SS)\n \n-    PSK + (EC)DHE               Pre-Shared Key         Client ephemeral\n-                                                    w/ server ephemeral\n+    PSK + (EC)DHE      Pre-Shared Key        Client Ephemeral\n+                                           + Server Ephemeral\n ~~~\n \n These shared secret values are used to generate cryptographic keys as\n shown below.\n \n The derivation process is as follows, where L denotes the length of\n-the underlying hash function for HKDF {{RFC5869}}.\n+the underlying hash function for HKDF {{RFC5869}} and SS/ES denotes\n+the sources from the table above. Whilst SS and ES may be the same\n+in some cases, the extracted static_secret and ephemeral_secret\n+will not.\n \n ~~~\n   HKDF-Expand-Label(Secret, Label, HashValue, Length) =\n        HKDF-Expand(Secret, Label + '\\0' + HashValue, Length)\n \n-  1. xSS = HKDF(0, SS, \"extractedSS\", L)\n+  1. static_secret = HKDF(0, SS, \"extracted SS\", L)\n \n-  2. xES = HKDF(0, ES, \"extractedES\", L)\n+  2. ephemeral_secret = HKDF(0, ES, \"extracted ES\", L)","path":"draft-ietf-tls-tls13.md","position":151,"original_position":151,"commit_id":"97536b83e1fd385be08adf049b6ab1af86cd0e1b","original_commit_id":"97536b83e1fd385be08adf049b6ab1af86cd0e1b","user":{"login":"ekr","id":1111457,"avatar_url":"https://avatars.githubusercontent.com/u/1111457?v=3","gravatar_id":"","url":"https://api.github.com/users/ekr","html_url":"https://github.com/ekr","followers_url":"https://api.github.com/users/ekr/followers","following_url":"https://api.github.com/users/ekr/following{/other_user}","gists_url":"https://api.github.com/users/ekr/gists{/gist_id}","starred_url":"https://api.github.com/users/ekr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekr/subscriptions","organizations_url":"https://api.github.com/users/ekr/orgs","repos_url":"https://api.github.com/users/ekr/repos","events_url":"https://api.github.com/users/ekr/events{/privacy}","received_events_url":"https://api.github.com/users/ekr/received_events","type":"User","site_admin":false},"body":"This isn't correct. the static secret is the DH ZZ.\r\n\r\nAlso, the seeds are a technical change, so remove.","created_at":"2015-08-13T13:24:33Z","updated_at":"2015-08-13T13:24:33Z","html_url":"https://github.com/tlswg/tls13-spec/pull/205#discussion_r36972954","pull_request_url":"https://api.github.com/repos/tlswg/tls13-spec/pulls/205","_links":{"self":{"href":"https://api.github.com/repos/tlswg/tls13-spec/pulls/comments/36972954"},"html":{"href":"https://github.com/tlswg/tls13-spec/pull/205#discussion_r36972954"},"pull_request":{"href":"https://api.github.com/repos/tlswg/tls13-spec/pulls/205"}}},"pull_request":{"url":"https://api.github.com/repos/tlswg/tls13-spec/pulls/205","id":40327116,"html_url":"https://github.com/tlswg/tls13-spec/pull/205","diff_url":"https://github.com/tlswg/tls13-spec/pull/205.diff","patch_url":"https://github.com/tlswg/tls13-spec/pull/205.patch","issue_url":"https://api.github.com/repos/tlswg/tls13-spec/issues/205","number":205,"state":"open","locked":false,"title":"tweaks for secrets to improve readability a bit","user":{"login":"davegarrett","id":8292199,"avatar_url":"https://avatars.githubusercontent.com/u/8292199?v=3","gravatar_id":"","url":"https://api.github.com/users/davegarrett","html_url":"https://github.com/davegarrett","followers_url":"https://api.github.com/users/davegarrett/followers","following_url":"https://api.github.com/users/davegarrett/following{/other_user}","gists_url":"https://api.github.com/users/davegarrett/gists{/gist_id}","starred_url":"https://api.github.com/users/davegarrett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davegarrett/subscriptions","organizations_url":"https://api.github.com/users/davegarrett/orgs","repos_url":"https://api.github.com/users/davegarrett/repos","events_url":"https://api.github.com/users/davegarrett/events{/privacy}","received_events_url":"https://api.github.com/users/davegarrett/received_events","type":"User","site_admin":false},"body":"Just a few things I noticed that I think make it a little bit easier to follow.\r\n\r\n* Name resumption_secret consistently when used\r\n* Show full legend for each handshake flow\r\n* Simplify/clarify secret sources table a bit and make text cases consistent\r\n\r\nThe resumption secret naming was also apparently noticed by @martinthomson in issue #191.","created_at":"2015-07-20T07:02:07Z","updated_at":"2015-08-13T13:24:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dce0880ca593978f114b1c5b50e0ac489b00c490","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tlswg/tls13-spec/pulls/205/commits","review_comments_url":"https://api.github.com/repos/tlswg/tls13-spec/pulls/205/comments","review_comment_url":"https://api.github.com/repos/tlswg/tls13-spec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tlswg/tls13-spec/issues/205/comments","statuses_url":"https://api.github.com/repos/tlswg/tls13-spec/statuses/97536b83e1fd385be08adf049b6ab1af86cd0e1b","head":{"label":"davegarrett:secretinfo","ref":"secretinfo","sha":"97536b83e1fd385be08adf049b6ab1af86cd0e1b","user":{"login":"davegarrett","id":8292199,"avatar_url":"https://avatars.githubusercontent.com/u/8292199?v=3","gravatar_id":"","url":"https://api.github.com/users/davegarrett","html_url":"https://github.com/davegarrett","followers_url":"https://api.github.com/users/davegarrett/followers","following_url":"https://api.github.com/users/davegarrett/following{/other_user}","gists_url":"https://api.github.com/users/davegarrett/gists{/gist_id}","starred_url":"https://api.github.com/users/davegarrett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davegarrett/subscriptions","organizations_url":"https://api.github.com/users/davegarrett/orgs","repos_url":"https://api.github.com/users/davegarrett/repos","events_url":"https://api.github.com/users/davegarrett/events{/privacy}","received_events_url":"https://api.github.com/users/davegarrett/received_events","type":"User","site_admin":false},"repo":{"id":28255281,"name":"tls13-spec","full_name":"davegarrett/tls13-spec","owner":{"login":"davegarrett","id":8292199,"avatar_url":"https://avatars.githubusercontent.com/u/8292199?v=3","gravatar_id":"","url":"https://api.github.com/users/davegarrett","html_url":"https://github.com/davegarrett","followers_url":"https://api.github.com/users/davegarrett/followers","following_url":"https://api.github.com/users/davegarrett/following{/other_user}","gists_url":"https://api.github.com/users/davegarrett/gists{/gist_id}","starred_url":"https://api.github.com/users/davegarrett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davegarrett/subscriptions","organizations_url":"https://api.github.com/users/davegarrett/orgs","repos_url":"https://api.github.com/users/davegarrett/repos","events_url":"https://api.github.com/users/davegarrett/events{/privacy}","received_events_url":"https://api.github.com/users/davegarrett/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davegarrett/tls13-spec","description":"TLS 1.3 Specification","fork":true,"url":"https://api.github.com/repos/davegarrett/tls13-spec","forks_url":"https://api.github.com/repos/davegarrett/tls13-spec/forks","keys_url":"https://api.github.com/repos/davegarrett/tls13-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davegarrett/tls13-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davegarrett/tls13-spec/teams","hooks_url":"https://api.github.com/repos/davegarrett/tls13-spec/hooks","issue_events_url":"https://api.github.com/repos/davegarrett/tls13-spec/issues/events{/number}","events_url":"https://api.github.com/repos/davegarrett/tls13-spec/events","assignees_url":"https://api.github.com/repos/davegarrett/tls13-spec/assignees{/user}","branches_url":"https://api.github.com/repos/davegarrett/tls13-spec/branches{/branch}","tags_url":"https://api.github.com/repos/davegarrett/tls13-spec/tags","blobs_url":"https://api.github.com/repos/davegarrett/tls13-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davegarrett/tls13-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davegarrett/tls13-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/davegarrett/tls13-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davegarrett/tls13-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/davegarrett/tls13-spec/languages","stargazers_url":"https://api.github.com/repos/davegarrett/tls13-spec/stargazers","contributors_url":"https://api.github.com/repos/davegarrett/tls13-spec/contributors","subscribers_url":"https://api.github.com/repos/davegarrett/tls13-spec/subscribers","subscription_url":"https://api.github.com/repos/davegarrett/tls13-spec/subscription","commits_url":"https://api.github.com/repos/davegarrett/tls13-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/davegarrett/tls13-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/davegarrett/tls13-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/davegarrett/tls13-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/davegarrett/tls13-spec/contents/{+path}","compare_url":"https://api.github.com/repos/davegarrett/tls13-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davegarrett/tls13-spec/merges","archive_url":"https://api.github.com/repos/davegarrett/tls13-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davegarrett/tls13-spec/downloads","issues_url":"https://api.github.com/repos/davegarrett/tls13-spec/issues{/number}","pulls_url":"https://api.github.com/repos/davegarrett/tls13-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/davegarrett/tls13-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/davegarrett/tls13-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davegarrett/tls13-spec/labels{/name}","releases_url":"https://api.github.com/repos/davegarrett/tls13-spec/releases{/id}","created_at":"2014-12-20T03:19:02Z","updated_at":"2015-05-06T04:39:23Z","pushed_at":"2015-08-13T04:46:54Z","git_url":"git://github.com/davegarrett/tls13-spec.git","ssh_url":"git@github.com:davegarrett/tls13-spec.git","clone_url":"https://github.com/davegarrett/tls13-spec.git","svn_url":"https://github.com/davegarrett/tls13-spec","homepage":null,"size":1854,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tlswg:master","ref":"master","sha":"9671b06d9d99177701a6aa9ce8dcdf20c89f126f","user":{"login":"tlswg","id":6699659,"avatar_url":"https://avatars.githubusercontent.com/u/6699659?v=3","gravatar_id":"","url":"https://api.github.com/users/tlswg","html_url":"https://github.com/tlswg","followers_url":"https://api.github.com/users/tlswg/followers","following_url":"https://api.github.com/users/tlswg/following{/other_user}","gists_url":"https://api.github.com/users/tlswg/gists{/gist_id}","starred_url":"https://api.github.com/users/tlswg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlswg/subscriptions","organizations_url":"https://api.github.com/users/tlswg/orgs","repos_url":"https://api.github.com/users/tlswg/repos","events_url":"https://api.github.com/users/tlswg/events{/privacy}","received_events_url":"https://api.github.com/users/tlswg/received_events","type":"Organization","site_admin":false},"repo":{"id":18887842,"name":"tls13-spec","full_name":"tlswg/tls13-spec","owner":{"login":"tlswg","id":6699659,"avatar_url":"https://avatars.githubusercontent.com/u/6699659?v=3","gravatar_id":"","url":"https://api.github.com/users/tlswg","html_url":"https://github.com/tlswg","followers_url":"https://api.github.com/users/tlswg/followers","following_url":"https://api.github.com/users/tlswg/following{/other_user}","gists_url":"https://api.github.com/users/tlswg/gists{/gist_id}","starred_url":"https://api.github.com/users/tlswg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlswg/subscriptions","organizations_url":"https://api.github.com/users/tlswg/orgs","repos_url":"https://api.github.com/users/tlswg/repos","events_url":"https://api.github.com/users/tlswg/events{/privacy}","received_events_url":"https://api.github.com/users/tlswg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tlswg/tls13-spec","description":"TLS 1.3 Specification","fork":false,"url":"https://api.github.com/repos/tlswg/tls13-spec","forks_url":"https://api.github.com/repos/tlswg/tls13-spec/forks","keys_url":"https://api.github.com/repos/tlswg/tls13-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tlswg/tls13-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tlswg/tls13-spec/teams","hooks_url":"https://api.github.com/repos/tlswg/tls13-spec/hooks","issue_events_url":"https://api.github.com/repos/tlswg/tls13-spec/issues/events{/number}","events_url":"https://api.github.com/repos/tlswg/tls13-spec/events","assignees_url":"https://api.github.com/repos/tlswg/tls13-spec/assignees{/user}","branches_url":"https://api.github.com/repos/tlswg/tls13-spec/branches{/branch}","tags_url":"https://api.github.com/repos/tlswg/tls13-spec/tags","blobs_url":"https://api.github.com/repos/tlswg/tls13-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tlswg/tls13-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tlswg/tls13-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/tlswg/tls13-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tlswg/tls13-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/tlswg/tls13-spec/languages","stargazers_url":"https://api.github.com/repos/tlswg/tls13-spec/stargazers","contributors_url":"https://api.github.com/repos/tlswg/tls13-spec/contributors","subscribers_url":"https://api.github.com/repos/tlswg/tls13-spec/subscribers","subscription_url":"https://api.github.com/repos/tlswg/tls13-spec/subscription","commits_url":"https://api.github.com/repos/tlswg/tls13-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/tlswg/tls13-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/tlswg/tls13-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/tlswg/tls13-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/tlswg/tls13-spec/contents/{+path}","compare_url":"https://api.github.com/repos/tlswg/tls13-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tlswg/tls13-spec/merges","archive_url":"https://api.github.com/repos/tlswg/tls13-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tlswg/tls13-spec/downloads","issues_url":"https://api.github.com/repos/tlswg/tls13-spec/issues{/number}","pulls_url":"https://api.github.com/repos/tlswg/tls13-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/tlswg/tls13-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/tlswg/tls13-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tlswg/tls13-spec/labels{/name}","releases_url":"https://api.github.com/repos/tlswg/tls13-spec/releases{/id}","created_at":"2014-04-17T17:52:32Z","updated_at":"2015-08-04T12:54:12Z","pushed_at":"2015-08-13T04:46:54Z","git_url":"git://github.com/tlswg/tls13-spec.git","ssh_url":"git@github.com:tlswg/tls13-spec.git","clone_url":"https://github.com/tlswg/tls13-spec.git","svn_url":"https://github.com/tlswg/tls13-spec","homepage":null,"size":2856,"stargazers_count":77,"watchers_count":77,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":28,"mirror_url":null,"open_issues_count":76,"forks":28,"open_issues":76,"watchers":77,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tlswg/tls13-spec/pulls/205"},"html":{"href":"https://github.com/tlswg/tls13-spec/pull/205"},"issue":{"href":"https://api.github.com/repos/tlswg/tls13-spec/issues/205"},"comments":{"href":"https://api.github.com/repos/tlswg/tls13-spec/issues/205/comments"},"review_comments":{"href":"https://api.github.com/repos/tlswg/tls13-spec/pulls/205/comments"},"review_comment":{"href":"https://api.github.com/repos/tlswg/tls13-spec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tlswg/tls13-spec/pulls/205/commits"},"statuses":{"href":"https://api.github.com/repos/tlswg/tls13-spec/statuses/97536b83e1fd385be08adf049b6ab1af86cd0e1b"}}}}