{"action":"created","comment":{"url":"https://api.github.com/repos/Flipkart/aesop/pulls/comments/27985496","id":27985496,"diff_hunk":"@@ -45,9 +45,8 @@ public void rejectedExecution(Runnable r, ThreadPoolExecutor e)\n \t{\n \t\ttry\n \t\t{\n-\t\t\twhile (!e.isShutdown())\n+\t\t\twhile (!e.isShutdown() && !e.getQueue().offer(r, _time, _timeUnit))","path":"runtimes/runtime-blocking-bootstrap/src/main/java/com/flipkart/aesop/runtime/bootstrap/consumer/WaitPolicy.java","position":5,"original_position":5,"commit_id":"d562a062e00f49bf3ce3da5dba26e6c0f612bffa","original_commit_id":"d562a062e00f49bf3ce3da5dba26e6c0f612bffa","user":{"login":"zodvik","id":461831,"avatar_url":"https://avatars.githubusercontent.com/u/461831?v=3","gravatar_id":"","url":"https://api.github.com/users/zodvik","html_url":"https://github.com/zodvik","followers_url":"https://api.github.com/users/zodvik/followers","following_url":"https://api.github.com/users/zodvik/following{/other_user}","gists_url":"https://api.github.com/users/zodvik/gists{/gist_id}","starred_url":"https://api.github.com/users/zodvik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zodvik/subscriptions","organizations_url":"https://api.github.com/users/zodvik/orgs","repos_url":"https://api.github.com/users/zodvik/repos","events_url":"https://api.github.com/users/zodvik/events{/privacy}","received_events_url":"https://api.github.com/users/zodvik/received_events","type":"User","site_admin":false},"body":"Context - the idea of WaitPolicy is for a executor submission to \"block\" until it is accepted by the blocking queue.\r\n\r\nThe terminating conditions for the while loop should be either of\r\n- executor is shutdown, or\r\n- the runnable is successfully added to the queue\r\n\r\nThe bug was that previously, the while loop will go on until executor shutdown with every iteration re-adding the runnable to queue.","created_at":"2015-04-08T16:15:06Z","updated_at":"2015-04-08T16:15:06Z","html_url":"https://github.com/Flipkart/aesop/pull/23#discussion_r27985496","pull_request_url":"https://api.github.com/repos/Flipkart/aesop/pulls/23","_links":{"self":{"href":"https://api.github.com/repos/Flipkart/aesop/pulls/comments/27985496"},"html":{"href":"https://github.com/Flipkart/aesop/pull/23#discussion_r27985496"},"pull_request":{"href":"https://api.github.com/repos/Flipkart/aesop/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/Flipkart/aesop/pulls/23","id":32852917,"html_url":"https://github.com/Flipkart/aesop/pull/23","diff_url":"https://github.com/Flipkart/aesop/pull/23.diff","patch_url":"https://github.com/Flipkart/aesop/pull/23.patch","issue_url":"https://api.github.com/repos/Flipkart/aesop/issues/23","number":23,"state":"open","locked":false,"title":"Fixes for Blocking Bootstrap Consumer","user":{"login":"raviknits","id":3739449,"avatar_url":"https://avatars.githubusercontent.com/u/3739449?v=3","gravatar_id":"","url":"https://api.github.com/users/raviknits","html_url":"https://github.com/raviknits","followers_url":"https://api.github.com/users/raviknits/followers","following_url":"https://api.github.com/users/raviknits/following{/other_user}","gists_url":"https://api.github.com/users/raviknits/gists{/gist_id}","starred_url":"https://api.github.com/users/raviknits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raviknits/subscriptions","organizations_url":"https://api.github.com/users/raviknits/orgs","repos_url":"https://api.github.com/users/raviknits/repos","events_url":"https://api.github.com/users/raviknits/events{/privacy}","received_events_url":"https://api.github.com/users/raviknits/received_events","type":"User","site_admin":false},"body":"- Added different queues for different consumers in Blocking bootstrap client.\r\n- Modified WaitPolicy for case when queue is full. ","created_at":"2015-04-08T11:59:38Z","updated_at":"2015-04-08T16:15:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8311df3cfe8940a5426f02fff746d9af764986f6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Flipkart/aesop/pulls/23/commits","review_comments_url":"https://api.github.com/repos/Flipkart/aesop/pulls/23/comments","review_comment_url":"https://api.github.com/repos/Flipkart/aesop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Flipkart/aesop/issues/23/comments","statuses_url":"https://api.github.com/repos/Flipkart/aesop/statuses/d562a062e00f49bf3ce3da5dba26e6c0f612bffa","head":{"label":"Flipkart:blocking-executor-fix","ref":"blocking-executor-fix","sha":"d562a062e00f49bf3ce3da5dba26e6c0f612bffa","user":{"login":"Flipkart","id":1179997,"avatar_url":"https://avatars.githubusercontent.com/u/1179997?v=3","gravatar_id":"","url":"https://api.github.com/users/Flipkart","html_url":"https://github.com/Flipkart","followers_url":"https://api.github.com/users/Flipkart/followers","following_url":"https://api.github.com/users/Flipkart/following{/other_user}","gists_url":"https://api.github.com/users/Flipkart/gists{/gist_id}","starred_url":"https://api.github.com/users/Flipkart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flipkart/subscriptions","organizations_url":"https://api.github.com/users/Flipkart/orgs","repos_url":"https://api.github.com/users/Flipkart/repos","events_url":"https://api.github.com/users/Flipkart/events{/privacy}","received_events_url":"https://api.github.com/users/Flipkart/received_events","type":"Organization","site_admin":false},"repo":{"id":14686390,"name":"aesop","full_name":"Flipkart/aesop","owner":{"login":"Flipkart","id":1179997,"avatar_url":"https://avatars.githubusercontent.com/u/1179997?v=3","gravatar_id":"","url":"https://api.github.com/users/Flipkart","html_url":"https://github.com/Flipkart","followers_url":"https://api.github.com/users/Flipkart/followers","following_url":"https://api.github.com/users/Flipkart/following{/other_user}","gists_url":"https://api.github.com/users/Flipkart/gists{/gist_id}","starred_url":"https://api.github.com/users/Flipkart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flipkart/subscriptions","organizations_url":"https://api.github.com/users/Flipkart/orgs","repos_url":"https://api.github.com/users/Flipkart/repos","events_url":"https://api.github.com/users/Flipkart/events{/privacy}","received_events_url":"https://api.github.com/users/Flipkart/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Flipkart/aesop","description":"A keen Observer of changes that can also relay change events reliably to interested parties. Provides useful infrastructure for building Eventually Consistent data sources and systems.","fork":false,"url":"https://api.github.com/repos/Flipkart/aesop","forks_url":"https://api.github.com/repos/Flipkart/aesop/forks","keys_url":"https://api.github.com/repos/Flipkart/aesop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Flipkart/aesop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Flipkart/aesop/teams","hooks_url":"https://api.github.com/repos/Flipkart/aesop/hooks","issue_events_url":"https://api.github.com/repos/Flipkart/aesop/issues/events{/number}","events_url":"https://api.github.com/repos/Flipkart/aesop/events","assignees_url":"https://api.github.com/repos/Flipkart/aesop/assignees{/user}","branches_url":"https://api.github.com/repos/Flipkart/aesop/branches{/branch}","tags_url":"https://api.github.com/repos/Flipkart/aesop/tags","blobs_url":"https://api.github.com/repos/Flipkart/aesop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Flipkart/aesop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Flipkart/aesop/git/refs{/sha}","trees_url":"https://api.github.com/repos/Flipkart/aesop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Flipkart/aesop/statuses/{sha}","languages_url":"https://api.github.com/repos/Flipkart/aesop/languages","stargazers_url":"https://api.github.com/repos/Flipkart/aesop/stargazers","contributors_url":"https://api.github.com/repos/Flipkart/aesop/contributors","subscribers_url":"https://api.github.com/repos/Flipkart/aesop/subscribers","subscription_url":"https://api.github.com/repos/Flipkart/aesop/subscription","commits_url":"https://api.github.com/repos/Flipkart/aesop/commits{/sha}","git_commits_url":"https://api.github.com/repos/Flipkart/aesop/git/commits{/sha}","comments_url":"https://api.github.com/repos/Flipkart/aesop/comments{/number}","issue_comment_url":"https://api.github.com/repos/Flipkart/aesop/issues/comments{/number}","contents_url":"https://api.github.com/repos/Flipkart/aesop/contents/{+path}","compare_url":"https://api.github.com/repos/Flipkart/aesop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Flipkart/aesop/merges","archive_url":"https://api.github.com/repos/Flipkart/aesop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Flipkart/aesop/downloads","issues_url":"https://api.github.com/repos/Flipkart/aesop/issues{/number}","pulls_url":"https://api.github.com/repos/Flipkart/aesop/pulls{/number}","milestones_url":"https://api.github.com/repos/Flipkart/aesop/milestones{/number}","notifications_url":"https://api.github.com/repos/Flipkart/aesop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Flipkart/aesop/labels{/name}","releases_url":"https://api.github.com/repos/Flipkart/aesop/releases{/id}","created_at":"2013-11-25T13:35:29Z","updated_at":"2015-04-08T15:43:29Z","pushed_at":"2015-04-08T11:59:38Z","git_url":"git://github.com/Flipkart/aesop.git","ssh_url":"git@github.com:Flipkart/aesop.git","clone_url":"https://github.com/Flipkart/aesop.git","svn_url":"https://github.com/Flipkart/aesop","homepage":null,"size":74056,"stargazers_count":35,"watchers_count":35,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":3,"forks":17,"open_issues":3,"watchers":35,"default_branch":"master"}},"base":{"label":"Flipkart:master","ref":"master","sha":"39217c4906174f026cfc9bdfce14c32b37d989fc","user":{"login":"Flipkart","id":1179997,"avatar_url":"https://avatars.githubusercontent.com/u/1179997?v=3","gravatar_id":"","url":"https://api.github.com/users/Flipkart","html_url":"https://github.com/Flipkart","followers_url":"https://api.github.com/users/Flipkart/followers","following_url":"https://api.github.com/users/Flipkart/following{/other_user}","gists_url":"https://api.github.com/users/Flipkart/gists{/gist_id}","starred_url":"https://api.github.com/users/Flipkart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flipkart/subscriptions","organizations_url":"https://api.github.com/users/Flipkart/orgs","repos_url":"https://api.github.com/users/Flipkart/repos","events_url":"https://api.github.com/users/Flipkart/events{/privacy}","received_events_url":"https://api.github.com/users/Flipkart/received_events","type":"Organization","site_admin":false},"repo":{"id":14686390,"name":"aesop","full_name":"Flipkart/aesop","owner":{"login":"Flipkart","id":1179997,"avatar_url":"https://avatars.githubusercontent.com/u/1179997?v=3","gravatar_id":"","url":"https://api.github.com/users/Flipkart","html_url":"https://github.com/Flipkart","followers_url":"https://api.github.com/users/Flipkart/followers","following_url":"https://api.github.com/users/Flipkart/following{/other_user}","gists_url":"https://api.github.com/users/Flipkart/gists{/gist_id}","starred_url":"https://api.github.com/users/Flipkart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flipkart/subscriptions","organizations_url":"https://api.github.com/users/Flipkart/orgs","repos_url":"https://api.github.com/users/Flipkart/repos","events_url":"https://api.github.com/users/Flipkart/events{/privacy}","received_events_url":"https://api.github.com/users/Flipkart/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Flipkart/aesop","description":"A keen Observer of changes that can also relay change events reliably to interested parties. Provides useful infrastructure for building Eventually Consistent data sources and systems.","fork":false,"url":"https://api.github.com/repos/Flipkart/aesop","forks_url":"https://api.github.com/repos/Flipkart/aesop/forks","keys_url":"https://api.github.com/repos/Flipkart/aesop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Flipkart/aesop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Flipkart/aesop/teams","hooks_url":"https://api.github.com/repos/Flipkart/aesop/hooks","issue_events_url":"https://api.github.com/repos/Flipkart/aesop/issues/events{/number}","events_url":"https://api.github.com/repos/Flipkart/aesop/events","assignees_url":"https://api.github.com/repos/Flipkart/aesop/assignees{/user}","branches_url":"https://api.github.com/repos/Flipkart/aesop/branches{/branch}","tags_url":"https://api.github.com/repos/Flipkart/aesop/tags","blobs_url":"https://api.github.com/repos/Flipkart/aesop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Flipkart/aesop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Flipkart/aesop/git/refs{/sha}","trees_url":"https://api.github.com/repos/Flipkart/aesop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Flipkart/aesop/statuses/{sha}","languages_url":"https://api.github.com/repos/Flipkart/aesop/languages","stargazers_url":"https://api.github.com/repos/Flipkart/aesop/stargazers","contributors_url":"https://api.github.com/repos/Flipkart/aesop/contributors","subscribers_url":"https://api.github.com/repos/Flipkart/aesop/subscribers","subscription_url":"https://api.github.com/repos/Flipkart/aesop/subscription","commits_url":"https://api.github.com/repos/Flipkart/aesop/commits{/sha}","git_commits_url":"https://api.github.com/repos/Flipkart/aesop/git/commits{/sha}","comments_url":"https://api.github.com/repos/Flipkart/aesop/comments{/number}","issue_comment_url":"https://api.github.com/repos/Flipkart/aesop/issues/comments{/number}","contents_url":"https://api.github.com/repos/Flipkart/aesop/contents/{+path}","compare_url":"https://api.github.com/repos/Flipkart/aesop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Flipkart/aesop/merges","archive_url":"https://api.github.com/repos/Flipkart/aesop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Flipkart/aesop/downloads","issues_url":"https://api.github.com/repos/Flipkart/aesop/issues{/number}","pulls_url":"https://api.github.com/repos/Flipkart/aesop/pulls{/number}","milestones_url":"https://api.github.com/repos/Flipkart/aesop/milestones{/number}","notifications_url":"https://api.github.com/repos/Flipkart/aesop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Flipkart/aesop/labels{/name}","releases_url":"https://api.github.com/repos/Flipkart/aesop/releases{/id}","created_at":"2013-11-25T13:35:29Z","updated_at":"2015-04-08T15:43:29Z","pushed_at":"2015-04-08T11:59:38Z","git_url":"git://github.com/Flipkart/aesop.git","ssh_url":"git@github.com:Flipkart/aesop.git","clone_url":"https://github.com/Flipkart/aesop.git","svn_url":"https://github.com/Flipkart/aesop","homepage":null,"size":74056,"stargazers_count":35,"watchers_count":35,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":3,"forks":17,"open_issues":3,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Flipkart/aesop/pulls/23"},"html":{"href":"https://github.com/Flipkart/aesop/pull/23"},"issue":{"href":"https://api.github.com/repos/Flipkart/aesop/issues/23"},"comments":{"href":"https://api.github.com/repos/Flipkart/aesop/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/Flipkart/aesop/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/Flipkart/aesop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Flipkart/aesop/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/Flipkart/aesop/statuses/d562a062e00f49bf3ce3da5dba26e6c0f612bffa"}}}}