{"action":"created","comment":{"url":"https://api.github.com/repos/varvet/godmin/pulls/comments/46306146","id":46306146,"diff_hunk":"@@ -4,6 +4,11 @@ module Forms\n       def form_for(record, options = {}, &block)\n         super(record, { builder: FormBuilders::FormBuilder, inline_errors: false }.merge(options), &block)\n       end\n+\n+      def select_tag(name, option_tags = nil, options = {})","path":"lib/godmin/helpers/forms.rb","position":5,"original_position":5,"commit_id":"319bbc719de4284afea3ef325537e158f482dbd5","original_commit_id":"319bbc719de4284afea3ef325537e158f482dbd5","user":{"login":"jensljungblad","id":271354,"avatar_url":"https://avatars.githubusercontent.com/u/271354?v=3","gravatar_id":"","url":"https://api.github.com/users/jensljungblad","html_url":"https://github.com/jensljungblad","followers_url":"https://api.github.com/users/jensljungblad/followers","following_url":"https://api.github.com/users/jensljungblad/following{/other_user}","gists_url":"https://api.github.com/users/jensljungblad/gists{/gist_id}","starred_url":"https://api.github.com/users/jensljungblad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jensljungblad/subscriptions","organizations_url":"https://api.github.com/users/jensljungblad/orgs","repos_url":"https://api.github.com/users/jensljungblad/repos","events_url":"https://api.github.com/users/jensljungblad/events{/privacy}","received_events_url":"https://api.github.com/users/jensljungblad/received_events","type":"User","site_admin":false},"body":"Hm, true that you can't pass a form builder to `form_tag`.. \r\n\r\nThe problem I have with it is that it seems inconsistent. All the bootstrap markup overriding is provided by the form builder, so if you were to do a `text_field_tag` or something it would definitely look out of place. This feels similar to me.","created_at":"2015-12-01T17:06:00Z","updated_at":"2015-12-01T17:06:00Z","html_url":"https://github.com/varvet/godmin/pull/160#discussion_r46306146","pull_request_url":"https://api.github.com/repos/varvet/godmin/pulls/160","_links":{"self":{"href":"https://api.github.com/repos/varvet/godmin/pulls/comments/46306146"},"html":{"href":"https://github.com/varvet/godmin/pull/160#discussion_r46306146"},"pull_request":{"href":"https://api.github.com/repos/varvet/godmin/pulls/160"}}},"pull_request":{"url":"https://api.github.com/repos/varvet/godmin/pulls/160","id":52050384,"html_url":"https://github.com/varvet/godmin/pull/160","diff_url":"https://github.com/varvet/godmin/pull/160.diff","patch_url":"https://github.com/varvet/godmin/pull/160.patch","issue_url":"https://api.github.com/repos/varvet/godmin/issues/160","number":160,"state":"open","locked":false,"title":"Form builder improvements","user":{"login":"benjamin-thomas","id":1557738,"avatar_url":"https://avatars.githubusercontent.com/u/1557738?v=3","gravatar_id":"","url":"https://api.github.com/users/benjamin-thomas","html_url":"https://github.com/benjamin-thomas","followers_url":"https://api.github.com/users/benjamin-thomas/followers","following_url":"https://api.github.com/users/benjamin-thomas/following{/other_user}","gists_url":"https://api.github.com/users/benjamin-thomas/gists{/gist_id}","starred_url":"https://api.github.com/users/benjamin-thomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjamin-thomas/subscriptions","organizations_url":"https://api.github.com/users/benjamin-thomas/orgs","repos_url":"https://api.github.com/users/benjamin-thomas/repos","events_url":"https://api.github.com/users/benjamin-thomas/events{/privacy}","received_events_url":"https://api.github.com/users/benjamin-thomas/received_events","type":"User","site_admin":false},"body":"Some little tweaks to make select tags appear consistent throughout.\r\n\r\nI got confused with the `association` method at first, so added a few notes to the doc as well.","created_at":"2015-11-28T23:01:40Z","updated_at":"2015-12-01T17:06:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c43a0fbd6f0c18924d67cc87bc237860e4f9fbe4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/varvet/godmin/pulls/160/commits","review_comments_url":"https://api.github.com/repos/varvet/godmin/pulls/160/comments","review_comment_url":"https://api.github.com/repos/varvet/godmin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/varvet/godmin/issues/160/comments","statuses_url":"https://api.github.com/repos/varvet/godmin/statuses/319bbc719de4284afea3ef325537e158f482dbd5","head":{"label":"benjamin-thomas:form-builder-override","ref":"form-builder-override","sha":"319bbc719de4284afea3ef325537e158f482dbd5","user":{"login":"benjamin-thomas","id":1557738,"avatar_url":"https://avatars.githubusercontent.com/u/1557738?v=3","gravatar_id":"","url":"https://api.github.com/users/benjamin-thomas","html_url":"https://github.com/benjamin-thomas","followers_url":"https://api.github.com/users/benjamin-thomas/followers","following_url":"https://api.github.com/users/benjamin-thomas/following{/other_user}","gists_url":"https://api.github.com/users/benjamin-thomas/gists{/gist_id}","starred_url":"https://api.github.com/users/benjamin-thomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjamin-thomas/subscriptions","organizations_url":"https://api.github.com/users/benjamin-thomas/orgs","repos_url":"https://api.github.com/users/benjamin-thomas/repos","events_url":"https://api.github.com/users/benjamin-thomas/events{/privacy}","received_events_url":"https://api.github.com/users/benjamin-thomas/received_events","type":"User","site_admin":false},"repo":{"id":46527377,"name":"godmin","full_name":"benjamin-thomas/godmin","owner":{"login":"benjamin-thomas","id":1557738,"avatar_url":"https://avatars.githubusercontent.com/u/1557738?v=3","gravatar_id":"","url":"https://api.github.com/users/benjamin-thomas","html_url":"https://github.com/benjamin-thomas","followers_url":"https://api.github.com/users/benjamin-thomas/followers","following_url":"https://api.github.com/users/benjamin-thomas/following{/other_user}","gists_url":"https://api.github.com/users/benjamin-thomas/gists{/gist_id}","starred_url":"https://api.github.com/users/benjamin-thomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjamin-thomas/subscriptions","organizations_url":"https://api.github.com/users/benjamin-thomas/orgs","repos_url":"https://api.github.com/users/benjamin-thomas/repos","events_url":"https://api.github.com/users/benjamin-thomas/events{/privacy}","received_events_url":"https://api.github.com/users/benjamin-thomas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benjamin-thomas/godmin","description":"Admin framework for Rails 4+","fork":true,"url":"https://api.github.com/repos/benjamin-thomas/godmin","forks_url":"https://api.github.com/repos/benjamin-thomas/godmin/forks","keys_url":"https://api.github.com/repos/benjamin-thomas/godmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benjamin-thomas/godmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benjamin-thomas/godmin/teams","hooks_url":"https://api.github.com/repos/benjamin-thomas/godmin/hooks","issue_events_url":"https://api.github.com/repos/benjamin-thomas/godmin/issues/events{/number}","events_url":"https://api.github.com/repos/benjamin-thomas/godmin/events","assignees_url":"https://api.github.com/repos/benjamin-thomas/godmin/assignees{/user}","branches_url":"https://api.github.com/repos/benjamin-thomas/godmin/branches{/branch}","tags_url":"https://api.github.com/repos/benjamin-thomas/godmin/tags","blobs_url":"https://api.github.com/repos/benjamin-thomas/godmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benjamin-thomas/godmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benjamin-thomas/godmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/benjamin-thomas/godmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benjamin-thomas/godmin/statuses/{sha}","languages_url":"https://api.github.com/repos/benjamin-thomas/godmin/languages","stargazers_url":"https://api.github.com/repos/benjamin-thomas/godmin/stargazers","contributors_url":"https://api.github.com/repos/benjamin-thomas/godmin/contributors","subscribers_url":"https://api.github.com/repos/benjamin-thomas/godmin/subscribers","subscription_url":"https://api.github.com/repos/benjamin-thomas/godmin/subscription","commits_url":"https://api.github.com/repos/benjamin-thomas/godmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/benjamin-thomas/godmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/benjamin-thomas/godmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/benjamin-thomas/godmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/benjamin-thomas/godmin/contents/{+path}","compare_url":"https://api.github.com/repos/benjamin-thomas/godmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benjamin-thomas/godmin/merges","archive_url":"https://api.github.com/repos/benjamin-thomas/godmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benjamin-thomas/godmin/downloads","issues_url":"https://api.github.com/repos/benjamin-thomas/godmin/issues{/number}","pulls_url":"https://api.github.com/repos/benjamin-thomas/godmin/pulls{/number}","milestones_url":"https://api.github.com/repos/benjamin-thomas/godmin/milestones{/number}","notifications_url":"https://api.github.com/repos/benjamin-thomas/godmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benjamin-thomas/godmin/labels{/name}","releases_url":"https://api.github.com/repos/benjamin-thomas/godmin/releases{/id}","created_at":"2015-11-19T23:46:43Z","updated_at":"2015-11-19T23:46:44Z","pushed_at":"2015-12-01T12:33:42Z","git_url":"git://github.com/benjamin-thomas/godmin.git","ssh_url":"git@github.com:benjamin-thomas/godmin.git","clone_url":"https://github.com/benjamin-thomas/godmin.git","svn_url":"https://github.com/benjamin-thomas/godmin","homepage":"http://godmin-sandbox.herokuapp.com","size":1099,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"varvet:master","ref":"master","sha":"af140c79413a6f02ac634aa1864000174d58b839","user":{"login":"varvet","id":3612746,"avatar_url":"https://avatars.githubusercontent.com/u/3612746?v=3","gravatar_id":"","url":"https://api.github.com/users/varvet","html_url":"https://github.com/varvet","followers_url":"https://api.github.com/users/varvet/followers","following_url":"https://api.github.com/users/varvet/following{/other_user}","gists_url":"https://api.github.com/users/varvet/gists{/gist_id}","starred_url":"https://api.github.com/users/varvet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/varvet/subscriptions","organizations_url":"https://api.github.com/users/varvet/orgs","repos_url":"https://api.github.com/users/varvet/repos","events_url":"https://api.github.com/users/varvet/events{/privacy}","received_events_url":"https://api.github.com/users/varvet/received_events","type":"Organization","site_admin":false},"repo":{"id":13380820,"name":"godmin","full_name":"varvet/godmin","owner":{"login":"varvet","id":3612746,"avatar_url":"https://avatars.githubusercontent.com/u/3612746?v=3","gravatar_id":"","url":"https://api.github.com/users/varvet","html_url":"https://github.com/varvet","followers_url":"https://api.github.com/users/varvet/followers","following_url":"https://api.github.com/users/varvet/following{/other_user}","gists_url":"https://api.github.com/users/varvet/gists{/gist_id}","starred_url":"https://api.github.com/users/varvet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/varvet/subscriptions","organizations_url":"https://api.github.com/users/varvet/orgs","repos_url":"https://api.github.com/users/varvet/repos","events_url":"https://api.github.com/users/varvet/events{/privacy}","received_events_url":"https://api.github.com/users/varvet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/varvet/godmin","description":"Admin framework for Rails 4+","fork":false,"url":"https://api.github.com/repos/varvet/godmin","forks_url":"https://api.github.com/repos/varvet/godmin/forks","keys_url":"https://api.github.com/repos/varvet/godmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/varvet/godmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/varvet/godmin/teams","hooks_url":"https://api.github.com/repos/varvet/godmin/hooks","issue_events_url":"https://api.github.com/repos/varvet/godmin/issues/events{/number}","events_url":"https://api.github.com/repos/varvet/godmin/events","assignees_url":"https://api.github.com/repos/varvet/godmin/assignees{/user}","branches_url":"https://api.github.com/repos/varvet/godmin/branches{/branch}","tags_url":"https://api.github.com/repos/varvet/godmin/tags","blobs_url":"https://api.github.com/repos/varvet/godmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/varvet/godmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/varvet/godmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/varvet/godmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/varvet/godmin/statuses/{sha}","languages_url":"https://api.github.com/repos/varvet/godmin/languages","stargazers_url":"https://api.github.com/repos/varvet/godmin/stargazers","contributors_url":"https://api.github.com/repos/varvet/godmin/contributors","subscribers_url":"https://api.github.com/repos/varvet/godmin/subscribers","subscription_url":"https://api.github.com/repos/varvet/godmin/subscription","commits_url":"https://api.github.com/repos/varvet/godmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/varvet/godmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/varvet/godmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/varvet/godmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/varvet/godmin/contents/{+path}","compare_url":"https://api.github.com/repos/varvet/godmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/varvet/godmin/merges","archive_url":"https://api.github.com/repos/varvet/godmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/varvet/godmin/downloads","issues_url":"https://api.github.com/repos/varvet/godmin/issues{/number}","pulls_url":"https://api.github.com/repos/varvet/godmin/pulls{/number}","milestones_url":"https://api.github.com/repos/varvet/godmin/milestones{/number}","notifications_url":"https://api.github.com/repos/varvet/godmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/varvet/godmin/labels{/name}","releases_url":"https://api.github.com/repos/varvet/godmin/releases{/id}","created_at":"2013-10-07T10:23:19Z","updated_at":"2015-12-01T12:51:48Z","pushed_at":"2015-12-01T13:02:06Z","git_url":"git://github.com/varvet/godmin.git","ssh_url":"git@github.com:varvet/godmin.git","clone_url":"https://github.com/varvet/godmin.git","svn_url":"https://github.com/varvet/godmin","homepage":"http://godmin-sandbox.herokuapp.com","size":1136,"stargazers_count":315,"watchers_count":315,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":20,"forks":14,"open_issues":20,"watchers":315,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/varvet/godmin/pulls/160"},"html":{"href":"https://github.com/varvet/godmin/pull/160"},"issue":{"href":"https://api.github.com/repos/varvet/godmin/issues/160"},"comments":{"href":"https://api.github.com/repos/varvet/godmin/issues/160/comments"},"review_comments":{"href":"https://api.github.com/repos/varvet/godmin/pulls/160/comments"},"review_comment":{"href":"https://api.github.com/repos/varvet/godmin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/varvet/godmin/pulls/160/commits"},"statuses":{"href":"https://api.github.com/repos/varvet/godmin/statuses/319bbc719de4284afea3ef325537e158f482dbd5"}}}}