{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/22648753","id":22648753,"diff_hunk":"@@ -15,6 +15,8 @@ class Flex < Formula\n   depends_on \"gettext\"\n \n   def install\n+    # 2.5.38+ build fix adapted from http://patchwork.openembedded.org/patch/68029/\n+    ENV[\"LDFLAGS\"] = \"#{ENV[\"LDFLAGS\"]} -all-static\"","path":"Library/Formula/flex.rb","position":null,"original_position":24,"commit_id":"afc5dc8a65cf62637430091cfb90166ee3d44b58","original_commit_id":"7afadb38ef7c9b22d316de60ebaf809456108be6","user":{"login":"steakknife","id":224304,"avatar_url":"https://avatars.githubusercontent.com/u/224304?v=3","gravatar_id":"","url":"https://api.github.com/users/steakknife","html_url":"https://github.com/steakknife","followers_url":"https://api.github.com/users/steakknife/followers","following_url":"https://api.github.com/users/steakknife/following{/other_user}","gists_url":"https://api.github.com/users/steakknife/gists{/gist_id}","starred_url":"https://api.github.com/users/steakknife/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steakknife/subscriptions","organizations_url":"https://api.github.com/users/steakknife/orgs","repos_url":"https://api.github.com/users/steakknife/repos","events_url":"https://api.github.com/users/steakknife/events{/privacy}","received_events_url":"https://api.github.com/users/steakknife/received_events","type":"User","site_admin":false},"body":"@tdsmith \r\n0. NFI, upstream broken their toolchain for osx and possibly other platforms on 2.5.38.  The patch was from some folks at WindRiver which is proposed as a fix on macports.\r\n1. Nope.  It's not a good idea to have a shared version of `_yylex` floating around to break apps, probably should add a `--disable-shared` too, in which case, the libfl.la issue is moot and it's an artifact that's deleted by brew by default anyhow.  If someone absolutely needs a shared library, they'll append `-all-static` to `LDFLAGS`.\r\n\r\n```\r\n0 ~ ❯❯❯ nm -g /usr/local/Cellar/flex/2.5.39/lib/libfl.a\r\n\r\n/usr/local/Cellar/flex/2.5.39/lib//libfl.a(libmain.o):\r\n0000000000000000 T _main\r\n0000000000000050 S _main.eh\r\n                 U _yylex\r\n\r\n/usr/local/Cellar/flex/2.5.39/lib//libfl.a(libyywrap.o):\r\n0000000000000000 T _yywrap\r\n0000000000000048 S _yywrap.eh\r\n0 ~ ❯❯❯ \r\n```\r\n2. Breaks libfl.la.\r\n\r\n```\r\nUndefined symbols for architecture x86_64:\r\n  \"_yylex\", referenced from:\r\n      _main in libmain.o\r\nld: symbol(s) not found for architecture x86_64\r\nclang: error: linker command failed with exit code 1 (use -v to see invocation)\r\nmake[2]: *** [libfl.la] Error 1\r\nmake[2]: *** Waiting for unfinished jobs....\r\nUndefined symbols for architecture x86_64:\r\n  \"_yylex\", referenced from:\r\n      _main in libmain.o\r\n```\r\n\r\n3. Yup.\r\n","created_at":"2015-01-08T12:24:38Z","updated_at":"2015-01-08T12:24:38Z","html_url":"https://github.com/Homebrew/homebrew/pull/35538#discussion_r22648753","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/35538","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/22648753"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/35538#discussion_r22648753"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/35538"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/35538","id":26793008,"html_url":"https://github.com/Homebrew/homebrew/pull/35538","diff_url":"https://github.com/Homebrew/homebrew/pull/35538.diff","patch_url":"https://github.com/Homebrew/homebrew/pull/35538.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew/issues/35538","number":35538,"state":"open","locked":false,"title":"flex: 2.5.39","user":{"login":"steakknife","id":224304,"avatar_url":"https://avatars.githubusercontent.com/u/224304?v=3","gravatar_id":"","url":"https://api.github.com/users/steakknife","html_url":"https://github.com/steakknife","followers_url":"https://api.github.com/users/steakknife/followers","following_url":"https://api.github.com/users/steakknife/following{/other_user}","gists_url":"https://api.github.com/users/steakknife/gists{/gist_id}","starred_url":"https://api.github.com/users/steakknife/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steakknife/subscriptions","organizations_url":"https://api.github.com/users/steakknife/orgs","repos_url":"https://api.github.com/users/steakknife/repos","events_url":"https://api.github.com/users/steakknife/events{/privacy}","received_events_url":"https://api.github.com/users/steakknife/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Barry Allard <barry.allard@gmail.com>\r\n\r\n```\r\n0 ~ git:master ❯❯❯ brew audit --strict flex                                                 \r\n0 ~ git:master ❯❯❯ brew test flex                                                  \r\nTesting flex\r\n==> /usr/local/Cellar/flex/2.5.39/bin/flex test.flex\r\n==> /usr/bin/clang lex.yy.c -L/usr/local/Cellar/flex/2.5.39/lib -lfl -o test\r\n==> echo \"Hello World\" | ./test\r\n0 ~ git:master ❯❯❯\r\n```","created_at":"2015-01-04T09:20:46Z","updated_at":"2015-01-08T12:24:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30eca2cf5183b5904734aa1553b3bcc960877d36","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/35538/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/35538/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew/issues/35538/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew/statuses/afc5dc8a65cf62637430091cfb90166ee3d44b58","head":{"label":"steakknife:update__flex_2_5_39","ref":"update__flex_2_5_39","sha":"afc5dc8a65cf62637430091cfb90166ee3d44b58","user":{"login":"steakknife","id":224304,"avatar_url":"https://avatars.githubusercontent.com/u/224304?v=3","gravatar_id":"","url":"https://api.github.com/users/steakknife","html_url":"https://github.com/steakknife","followers_url":"https://api.github.com/users/steakknife/followers","following_url":"https://api.github.com/users/steakknife/following{/other_user}","gists_url":"https://api.github.com/users/steakknife/gists{/gist_id}","starred_url":"https://api.github.com/users/steakknife/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steakknife/subscriptions","organizations_url":"https://api.github.com/users/steakknife/orgs","repos_url":"https://api.github.com/users/steakknife/repos","events_url":"https://api.github.com/users/steakknife/events{/privacy}","received_events_url":"https://api.github.com/users/steakknife/received_events","type":"User","site_admin":false},"repo":{"id":15296499,"name":"homebrew","full_name":"steakknife/homebrew","owner":{"login":"steakknife","id":224304,"avatar_url":"https://avatars.githubusercontent.com/u/224304?v=3","gravatar_id":"","url":"https://api.github.com/users/steakknife","html_url":"https://github.com/steakknife","followers_url":"https://api.github.com/users/steakknife/followers","following_url":"https://api.github.com/users/steakknife/following{/other_user}","gists_url":"https://api.github.com/users/steakknife/gists{/gist_id}","starred_url":"https://api.github.com/users/steakknife/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steakknife/subscriptions","organizations_url":"https://api.github.com/users/steakknife/orgs","repos_url":"https://api.github.com/users/steakknife/repos","events_url":"https://api.github.com/users/steakknife/events{/privacy}","received_events_url":"https://api.github.com/users/steakknife/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/steakknife/homebrew","description":"The missing package manager for OS X.","fork":true,"url":"https://api.github.com/repos/steakknife/homebrew","forks_url":"https://api.github.com/repos/steakknife/homebrew/forks","keys_url":"https://api.github.com/repos/steakknife/homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/steakknife/homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/steakknife/homebrew/teams","hooks_url":"https://api.github.com/repos/steakknife/homebrew/hooks","issue_events_url":"https://api.github.com/repos/steakknife/homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/steakknife/homebrew/events","assignees_url":"https://api.github.com/repos/steakknife/homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/steakknife/homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/steakknife/homebrew/tags","blobs_url":"https://api.github.com/repos/steakknife/homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/steakknife/homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/steakknife/homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/steakknife/homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/steakknife/homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/steakknife/homebrew/languages","stargazers_url":"https://api.github.com/repos/steakknife/homebrew/stargazers","contributors_url":"https://api.github.com/repos/steakknife/homebrew/contributors","subscribers_url":"https://api.github.com/repos/steakknife/homebrew/subscribers","subscription_url":"https://api.github.com/repos/steakknife/homebrew/subscription","commits_url":"https://api.github.com/repos/steakknife/homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/steakknife/homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/steakknife/homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/steakknife/homebrew/issues/comments/{number}","contents_url":"https://api.github.com/repos/steakknife/homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/steakknife/homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/steakknife/homebrew/merges","archive_url":"https://api.github.com/repos/steakknife/homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/steakknife/homebrew/downloads","issues_url":"https://api.github.com/repos/steakknife/homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/steakknife/homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/steakknife/homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/steakknife/homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/steakknife/homebrew/labels{/name}","releases_url":"https://api.github.com/repos/steakknife/homebrew/releases{/id}","created_at":"2013-12-18T23:07:13Z","updated_at":"2015-01-04T09:15:57Z","pushed_at":"2015-01-08T12:01:43Z","git_url":"git://github.com/steakknife/homebrew.git","ssh_url":"git@github.com:steakknife/homebrew.git","clone_url":"https://github.com/steakknife/homebrew.git","svn_url":"https://github.com/steakknife/homebrew","homepage":"http://brew.sh","size":53058,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"cb645d9d3fbe235c53657c3701905b6c7f85c7d0","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":206084,"name":"homebrew","full_name":"Homebrew/homebrew","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew","description":"The missing package manager for OS X.","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew","forks_url":"https://api.github.com/repos/Homebrew/homebrew/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew/issues/comments/{number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew/releases{/id}","created_at":"2009-05-20T19:38:37Z","updated_at":"2015-01-08T12:07:02Z","pushed_at":"2015-01-08T10:30:34Z","git_url":"git://github.com/Homebrew/homebrew.git","ssh_url":"git@github.com:Homebrew/homebrew.git","clone_url":"https://github.com/Homebrew/homebrew.git","svn_url":"https://github.com/Homebrew/homebrew","homepage":"http://brew.sh","size":1151591,"stargazers_count":20904,"watchers_count":20904,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":10434,"mirror_url":null,"open_issues_count":234,"forks":10434,"open_issues":234,"watchers":20904,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/35538"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/35538"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew/issues/35538"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew/issues/35538/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/35538/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/35538/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew/statuses/afc5dc8a65cf62637430091cfb90166ee3d44b58"}}}}