{"action":"created","comment":{"url":"https://api.github.com/repos/esbullington/react-d3/pulls/comments/36527709","id":36527709,"diff_hunk":"@@ -36,13 +36,15 @@ module.exports = React.createClass({\n     var xScale = props.xScale;\n     var yScale = props.yScale;\n     var xAccessor = props.xAccessor,\n-        yAccessor = props.yAccessor;\n+        yAccessor = props.yAccessor,\n+\t\t\t\tvaluesAccessor = props.valuesAccessor,","path":"src/linechart/DataSeries.jsx","position":6,"original_position":6,"commit_id":"15f9158b8bca93acee24f98f5029712b17292091","original_commit_id":"15f9158b8bca93acee24f98f5029712b17292091","user":{"login":"yang-wei","id":5494874,"avatar_url":"https://avatars.githubusercontent.com/u/5494874?v=3","gravatar_id":"","url":"https://api.github.com/users/yang-wei","html_url":"https://github.com/yang-wei","followers_url":"https://api.github.com/users/yang-wei/followers","following_url":"https://api.github.com/users/yang-wei/following{/other_user}","gists_url":"https://api.github.com/users/yang-wei/gists{/gist_id}","starred_url":"https://api.github.com/users/yang-wei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yang-wei/subscriptions","organizations_url":"https://api.github.com/users/yang-wei/orgs","repos_url":"https://api.github.com/users/yang-wei/repos","events_url":"https://api.github.com/users/yang-wei/events{/privacy}","received_events_url":"https://api.github.com/users/yang-wei/received_events","type":"User","site_admin":false},"body":"please make the var declaration same too =)","created_at":"2015-08-07T15:05:12Z","updated_at":"2015-08-07T15:05:12Z","html_url":"https://github.com/esbullington/react-d3/pull/246#discussion_r36527709","pull_request_url":"https://api.github.com/repos/esbullington/react-d3/pulls/246","_links":{"self":{"href":"https://api.github.com/repos/esbullington/react-d3/pulls/comments/36527709"},"html":{"href":"https://github.com/esbullington/react-d3/pull/246#discussion_r36527709"},"pull_request":{"href":"https://api.github.com/repos/esbullington/react-d3/pulls/246"}}},"pull_request":{"url":"https://api.github.com/repos/esbullington/react-d3/pulls/246","id":41501960,"html_url":"https://github.com/esbullington/react-d3/pull/246","diff_url":"https://github.com/esbullington/react-d3/pull/246.diff","patch_url":"https://github.com/esbullington/react-d3/pull/246.patch","issue_url":"https://api.github.com/repos/esbullington/react-d3/issues/246","number":246,"state":"open","locked":false,"title":"Optional labelsAccessor and valuesAccessor","user":{"login":"jeans11","id":7700239,"avatar_url":"https://avatars.githubusercontent.com/u/7700239?v=3","gravatar_id":"","url":"https://api.github.com/users/jeans11","html_url":"https://github.com/jeans11","followers_url":"https://api.github.com/users/jeans11/followers","following_url":"https://api.github.com/users/jeans11/following{/other_user}","gists_url":"https://api.github.com/users/jeans11/gists{/gist_id}","starred_url":"https://api.github.com/users/jeans11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeans11/subscriptions","organizations_url":"https://api.github.com/users/jeans11/orgs","repos_url":"https://api.github.com/users/jeans11/repos","events_url":"https://api.github.com/users/jeans11/events{/privacy}","received_events_url":"https://api.github.com/users/jeans11/received_events","type":"User","site_admin":false},"body":"Hi guys !\r\n\r\nSo, it's update for use ```labelsAccessor``` and ```valuesAccessor```.\r\n\r\nJust , I don't update the new stacked bar chat. In fact, for this, the label of each bar is the ```x``` propertie of object in values array, right ?!","created_at":"2015-08-03T19:41:59Z","updated_at":"2015-08-07T15:05:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ac8e45f4cbd4514b5741431a9f01bae6f2f8df0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/esbullington/react-d3/pulls/246/commits","review_comments_url":"https://api.github.com/repos/esbullington/react-d3/pulls/246/comments","review_comment_url":"https://api.github.com/repos/esbullington/react-d3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/esbullington/react-d3/issues/246/comments","statuses_url":"https://api.github.com/repos/esbullington/react-d3/statuses/15f9158b8bca93acee24f98f5029712b17292091","head":{"label":"jeans11:jeans11-optionalProp","ref":"jeans11-optionalProp","sha":"15f9158b8bca93acee24f98f5029712b17292091","user":{"login":"jeans11","id":7700239,"avatar_url":"https://avatars.githubusercontent.com/u/7700239?v=3","gravatar_id":"","url":"https://api.github.com/users/jeans11","html_url":"https://github.com/jeans11","followers_url":"https://api.github.com/users/jeans11/followers","following_url":"https://api.github.com/users/jeans11/following{/other_user}","gists_url":"https://api.github.com/users/jeans11/gists{/gist_id}","starred_url":"https://api.github.com/users/jeans11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeans11/subscriptions","organizations_url":"https://api.github.com/users/jeans11/orgs","repos_url":"https://api.github.com/users/jeans11/repos","events_url":"https://api.github.com/users/jeans11/events{/privacy}","received_events_url":"https://api.github.com/users/jeans11/received_events","type":"User","site_admin":false},"repo":{"id":37278454,"name":"react-d3","full_name":"jeans11/react-d3","owner":{"login":"jeans11","id":7700239,"avatar_url":"https://avatars.githubusercontent.com/u/7700239?v=3","gravatar_id":"","url":"https://api.github.com/users/jeans11","html_url":"https://github.com/jeans11","followers_url":"https://api.github.com/users/jeans11/followers","following_url":"https://api.github.com/users/jeans11/following{/other_user}","gists_url":"https://api.github.com/users/jeans11/gists{/gist_id}","starred_url":"https://api.github.com/users/jeans11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeans11/subscriptions","organizations_url":"https://api.github.com/users/jeans11/orgs","repos_url":"https://api.github.com/users/jeans11/repos","events_url":"https://api.github.com/users/jeans11/events{/privacy}","received_events_url":"https://api.github.com/users/jeans11/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeans11/react-d3","description":"Modular React charts made with d3.js","fork":true,"url":"https://api.github.com/repos/jeans11/react-d3","forks_url":"https://api.github.com/repos/jeans11/react-d3/forks","keys_url":"https://api.github.com/repos/jeans11/react-d3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeans11/react-d3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeans11/react-d3/teams","hooks_url":"https://api.github.com/repos/jeans11/react-d3/hooks","issue_events_url":"https://api.github.com/repos/jeans11/react-d3/issues/events{/number}","events_url":"https://api.github.com/repos/jeans11/react-d3/events","assignees_url":"https://api.github.com/repos/jeans11/react-d3/assignees{/user}","branches_url":"https://api.github.com/repos/jeans11/react-d3/branches{/branch}","tags_url":"https://api.github.com/repos/jeans11/react-d3/tags","blobs_url":"https://api.github.com/repos/jeans11/react-d3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeans11/react-d3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeans11/react-d3/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeans11/react-d3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeans11/react-d3/statuses/{sha}","languages_url":"https://api.github.com/repos/jeans11/react-d3/languages","stargazers_url":"https://api.github.com/repos/jeans11/react-d3/stargazers","contributors_url":"https://api.github.com/repos/jeans11/react-d3/contributors","subscribers_url":"https://api.github.com/repos/jeans11/react-d3/subscribers","subscription_url":"https://api.github.com/repos/jeans11/react-d3/subscription","commits_url":"https://api.github.com/repos/jeans11/react-d3/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeans11/react-d3/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeans11/react-d3/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeans11/react-d3/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeans11/react-d3/contents/{+path}","compare_url":"https://api.github.com/repos/jeans11/react-d3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeans11/react-d3/merges","archive_url":"https://api.github.com/repos/jeans11/react-d3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeans11/react-d3/downloads","issues_url":"https://api.github.com/repos/jeans11/react-d3/issues{/number}","pulls_url":"https://api.github.com/repos/jeans11/react-d3/pulls{/number}","milestones_url":"https://api.github.com/repos/jeans11/react-d3/milestones{/number}","notifications_url":"https://api.github.com/repos/jeans11/react-d3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeans11/react-d3/labels{/name}","releases_url":"https://api.github.com/repos/jeans11/react-d3/releases{/id}","created_at":"2015-06-11T18:28:14Z","updated_at":"2015-06-11T18:28:15Z","pushed_at":"2015-08-03T19:34:17Z","git_url":"git://github.com/jeans11/react-d3.git","ssh_url":"git@github.com:jeans11/react-d3.git","clone_url":"https://github.com/jeans11/react-d3.git","svn_url":"https://github.com/jeans11/react-d3","homepage":"http://esbullington.github.io/react-d3-website/","size":3727,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"esbullington:master","ref":"master","sha":"c06e20d13613786e389df83e8bc30259af57ea3a","user":{"login":"esbullington","id":1138625,"avatar_url":"https://avatars.githubusercontent.com/u/1138625?v=3","gravatar_id":"","url":"https://api.github.com/users/esbullington","html_url":"https://github.com/esbullington","followers_url":"https://api.github.com/users/esbullington/followers","following_url":"https://api.github.com/users/esbullington/following{/other_user}","gists_url":"https://api.github.com/users/esbullington/gists{/gist_id}","starred_url":"https://api.github.com/users/esbullington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esbullington/subscriptions","organizations_url":"https://api.github.com/users/esbullington/orgs","repos_url":"https://api.github.com/users/esbullington/repos","events_url":"https://api.github.com/users/esbullington/events{/privacy}","received_events_url":"https://api.github.com/users/esbullington/received_events","type":"User","site_admin":false},"repo":{"id":25973357,"name":"react-d3","full_name":"esbullington/react-d3","owner":{"login":"esbullington","id":1138625,"avatar_url":"https://avatars.githubusercontent.com/u/1138625?v=3","gravatar_id":"","url":"https://api.github.com/users/esbullington","html_url":"https://github.com/esbullington","followers_url":"https://api.github.com/users/esbullington/followers","following_url":"https://api.github.com/users/esbullington/following{/other_user}","gists_url":"https://api.github.com/users/esbullington/gists{/gist_id}","starred_url":"https://api.github.com/users/esbullington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esbullington/subscriptions","organizations_url":"https://api.github.com/users/esbullington/orgs","repos_url":"https://api.github.com/users/esbullington/repos","events_url":"https://api.github.com/users/esbullington/events{/privacy}","received_events_url":"https://api.github.com/users/esbullington/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/esbullington/react-d3","description":"Modular React charts made with d3.js","fork":false,"url":"https://api.github.com/repos/esbullington/react-d3","forks_url":"https://api.github.com/repos/esbullington/react-d3/forks","keys_url":"https://api.github.com/repos/esbullington/react-d3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/esbullington/react-d3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/esbullington/react-d3/teams","hooks_url":"https://api.github.com/repos/esbullington/react-d3/hooks","issue_events_url":"https://api.github.com/repos/esbullington/react-d3/issues/events{/number}","events_url":"https://api.github.com/repos/esbullington/react-d3/events","assignees_url":"https://api.github.com/repos/esbullington/react-d3/assignees{/user}","branches_url":"https://api.github.com/repos/esbullington/react-d3/branches{/branch}","tags_url":"https://api.github.com/repos/esbullington/react-d3/tags","blobs_url":"https://api.github.com/repos/esbullington/react-d3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/esbullington/react-d3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/esbullington/react-d3/git/refs{/sha}","trees_url":"https://api.github.com/repos/esbullington/react-d3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/esbullington/react-d3/statuses/{sha}","languages_url":"https://api.github.com/repos/esbullington/react-d3/languages","stargazers_url":"https://api.github.com/repos/esbullington/react-d3/stargazers","contributors_url":"https://api.github.com/repos/esbullington/react-d3/contributors","subscribers_url":"https://api.github.com/repos/esbullington/react-d3/subscribers","subscription_url":"https://api.github.com/repos/esbullington/react-d3/subscription","commits_url":"https://api.github.com/repos/esbullington/react-d3/commits{/sha}","git_commits_url":"https://api.github.com/repos/esbullington/react-d3/git/commits{/sha}","comments_url":"https://api.github.com/repos/esbullington/react-d3/comments{/number}","issue_comment_url":"https://api.github.com/repos/esbullington/react-d3/issues/comments{/number}","contents_url":"https://api.github.com/repos/esbullington/react-d3/contents/{+path}","compare_url":"https://api.github.com/repos/esbullington/react-d3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/esbullington/react-d3/merges","archive_url":"https://api.github.com/repos/esbullington/react-d3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/esbullington/react-d3/downloads","issues_url":"https://api.github.com/repos/esbullington/react-d3/issues{/number}","pulls_url":"https://api.github.com/repos/esbullington/react-d3/pulls{/number}","milestones_url":"https://api.github.com/repos/esbullington/react-d3/milestones{/number}","notifications_url":"https://api.github.com/repos/esbullington/react-d3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/esbullington/react-d3/labels{/name}","releases_url":"https://api.github.com/repos/esbullington/react-d3/releases{/id}","created_at":"2014-10-30T14:01:23Z","updated_at":"2015-08-06T02:04:36Z","pushed_at":"2015-08-07T14:47:59Z","git_url":"git://github.com/esbullington/react-d3.git","ssh_url":"git@github.com:esbullington/react-d3.git","clone_url":"https://github.com/esbullington/react-d3.git","svn_url":"https://github.com/esbullington/react-d3","homepage":"http://esbullington.github.io/react-d3-website/","size":5406,"stargazers_count":455,"watchers_count":455,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"open_issues_count":15,"forks":63,"open_issues":15,"watchers":455,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/esbullington/react-d3/pulls/246"},"html":{"href":"https://github.com/esbullington/react-d3/pull/246"},"issue":{"href":"https://api.github.com/repos/esbullington/react-d3/issues/246"},"comments":{"href":"https://api.github.com/repos/esbullington/react-d3/issues/246/comments"},"review_comments":{"href":"https://api.github.com/repos/esbullington/react-d3/pulls/246/comments"},"review_comment":{"href":"https://api.github.com/repos/esbullington/react-d3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/esbullington/react-d3/pulls/246/commits"},"statuses":{"href":"https://api.github.com/repos/esbullington/react-d3/statuses/15f9158b8bca93acee24f98f5029712b17292091"}}}}