{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/45235836","id":45235836,"diff_hunk":"@@ -29,21 +29,12 @@ internal static class RealParser\n         /// <returns>True of the input was converted; false if there was an overflow</returns>\n         public static bool TryParseDouble(string s, out double d)\n         {\n-            try\n-            {\n-                var str = DecimalFloatingPointString.FromSource(s);\n-                var dbl = DoubleFloatingPointType.Instance;\n-                ulong result;\n-                var status = RealParser.ConvertDecimalToFloatingPointBits(str, dbl, out result);\n-                d = BitConverter.Int64BitsToDouble((long)result);\n-                return status != Status.Overflow;\n-            }\n-            catch (System.FormatException)\n-            {\n-                // this can occur when the exponent is empty (e.g. \"0.0e\") or too large to fit in an integer\n-                d = 0.0;\n-                return false;\n-            }\n+            var str = DecimalFloatingPointString.FromSource(s);","path":"src/Compilers/Core/Portable/RealParser.cs","position":19,"original_position":19,"commit_id":"4f522d3b124e37736a84658ae118206eaae0a113","original_commit_id":"4f522d3b124e37736a84658ae118206eaae0a113","user":{"login":"leppie","id":127666,"avatar_url":"https://avatars.githubusercontent.com/u/127666?v=3","gravatar_id":"","url":"https://api.github.com/users/leppie","html_url":"https://github.com/leppie","followers_url":"https://api.github.com/users/leppie/followers","following_url":"https://api.github.com/users/leppie/following{/other_user}","gists_url":"https://api.github.com/users/leppie/gists{/gist_id}","starred_url":"https://api.github.com/users/leppie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leppie/subscriptions","organizations_url":"https://api.github.com/users/leppie/orgs","repos_url":"https://api.github.com/users/leppie/repos","events_url":"https://api.github.com/users/leppie/events{/privacy}","received_events_url":"https://api.github.com/users/leppie/received_events","type":"User","site_admin":false},"body":"This fixes that issue too. Updated PR text.","created_at":"2015-11-18T18:06:16Z","updated_at":"2015-11-18T18:06:16Z","html_url":"https://github.com/dotnet/roslyn/pull/6844#discussion_r45235836","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/6844","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/45235836"},"html":{"href":"https://github.com/dotnet/roslyn/pull/6844#discussion_r45235836"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/6844"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/6844","id":51048724,"html_url":"https://github.com/dotnet/roslyn/pull/6844","diff_url":"https://github.com/dotnet/roslyn/pull/6844.diff","patch_url":"https://github.com/dotnet/roslyn/pull/6844.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/6844","number":6844,"state":"open","locked":false,"title":"Scanner and parser fixes for real literals","user":{"login":"leppie","id":127666,"avatar_url":"https://avatars.githubusercontent.com/u/127666?v=3","gravatar_id":"","url":"https://api.github.com/users/leppie","html_url":"https://github.com/leppie","followers_url":"https://api.github.com/users/leppie/followers","following_url":"https://api.github.com/users/leppie/following{/other_user}","gists_url":"https://api.github.com/users/leppie/gists{/gist_id}","starred_url":"https://api.github.com/users/leppie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leppie/subscriptions","organizations_url":"https://api.github.com/users/leppie/orgs","repos_url":"https://api.github.com/users/leppie/repos","events_url":"https://api.github.com/users/leppie/events{/privacy}","received_events_url":"https://api.github.com/users/leppie/received_events","type":"User","site_admin":false},"body":"Fixes #6817, #6109 and #6079 (correctly this time).\r\n\r\nAs a temporary measure I have added CS0595 (adjacent to CS0594 and not used from what I can see) to indicate an invalid real literal. For now the only case I can see is for missing exponent digits, so the error could possibly be made more specific.\r\n\r\n/cc @gafter ","created_at":"2015-11-18T06:51:49Z","updated_at":"2015-11-18T18:06:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd0d91f291f4affdc8be187fcfab2c2b2ab31dfe","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/6844/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/6844/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/6844/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/4f522d3b124e37736a84658ae118206eaae0a113","head":{"label":"leppie:issue-6817","ref":"issue-6817","sha":"4f522d3b124e37736a84658ae118206eaae0a113","user":{"login":"leppie","id":127666,"avatar_url":"https://avatars.githubusercontent.com/u/127666?v=3","gravatar_id":"","url":"https://api.github.com/users/leppie","html_url":"https://github.com/leppie","followers_url":"https://api.github.com/users/leppie/followers","following_url":"https://api.github.com/users/leppie/following{/other_user}","gists_url":"https://api.github.com/users/leppie/gists{/gist_id}","starred_url":"https://api.github.com/users/leppie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leppie/subscriptions","organizations_url":"https://api.github.com/users/leppie/orgs","repos_url":"https://api.github.com/users/leppie/repos","events_url":"https://api.github.com/users/leppie/events{/privacy}","received_events_url":"https://api.github.com/users/leppie/received_events","type":"User","site_admin":false},"repo":{"id":46135676,"name":"roslyn","full_name":"leppie/roslyn","owner":{"login":"leppie","id":127666,"avatar_url":"https://avatars.githubusercontent.com/u/127666?v=3","gravatar_id":"","url":"https://api.github.com/users/leppie","html_url":"https://github.com/leppie","followers_url":"https://api.github.com/users/leppie/followers","following_url":"https://api.github.com/users/leppie/following{/other_user}","gists_url":"https://api.github.com/users/leppie/gists{/gist_id}","starred_url":"https://api.github.com/users/leppie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leppie/subscriptions","organizations_url":"https://api.github.com/users/leppie/orgs","repos_url":"https://api.github.com/users/leppie/repos","events_url":"https://api.github.com/users/leppie/events{/privacy}","received_events_url":"https://api.github.com/users/leppie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leppie/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/leppie/roslyn","forks_url":"https://api.github.com/repos/leppie/roslyn/forks","keys_url":"https://api.github.com/repos/leppie/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leppie/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leppie/roslyn/teams","hooks_url":"https://api.github.com/repos/leppie/roslyn/hooks","issue_events_url":"https://api.github.com/repos/leppie/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/leppie/roslyn/events","assignees_url":"https://api.github.com/repos/leppie/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/leppie/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/leppie/roslyn/tags","blobs_url":"https://api.github.com/repos/leppie/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leppie/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leppie/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/leppie/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leppie/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/leppie/roslyn/languages","stargazers_url":"https://api.github.com/repos/leppie/roslyn/stargazers","contributors_url":"https://api.github.com/repos/leppie/roslyn/contributors","subscribers_url":"https://api.github.com/repos/leppie/roslyn/subscribers","subscription_url":"https://api.github.com/repos/leppie/roslyn/subscription","commits_url":"https://api.github.com/repos/leppie/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/leppie/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/leppie/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/leppie/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/leppie/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/leppie/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leppie/roslyn/merges","archive_url":"https://api.github.com/repos/leppie/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leppie/roslyn/downloads","issues_url":"https://api.github.com/repos/leppie/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/leppie/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/leppie/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/leppie/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leppie/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/leppie/roslyn/releases{/id}","created_at":"2015-11-13T17:05:35Z","updated_at":"2015-11-13T17:06:20Z","pushed_at":"2015-11-18T06:48:34Z","git_url":"git://github.com/leppie/roslyn.git","ssh_url":"git@github.com:leppie/roslyn.git","clone_url":"https://github.com/leppie/roslyn.git","svn_url":"https://github.com/leppie/roslyn","homepage":"","size":113357,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"f1895d2b53c3c3187f29842ba03be26a28b92184","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","created_at":"2015-01-11T02:39:03Z","updated_at":"2015-11-18T18:03:29Z","pushed_at":"2015-11-18T17:45:22Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":134760,"stargazers_count":3752,"watchers_count":3752,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":901,"mirror_url":null,"open_issues_count":1640,"forks":901,"open_issues":1640,"watchers":3752,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/6844"},"html":{"href":"https://github.com/dotnet/roslyn/pull/6844"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/6844"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/6844/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/6844/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/6844/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/4f522d3b124e37736a84658ae118206eaae0a113"}}}}