{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/41929664","id":41929664,"diff_hunk":"@@ -3,9 +3,24 @@ module Openshift\n     class ContainerManager::Refresher < ManageIQ::Providers::BaseManager::Refresher\n       include ::EmsRefresh::Refreshers::EmsRefresherMixin\n \n+      def self.entities\n+        %w(routes projects)\n+      end\n+\n       def parse_inventory(ems, _targets = nil)\n-        all_entities = ems.with_provider_connection(&:all_entities)\n-        all_entities.merge!(ems.with_provider_connection(:service => ManageIQ::Providers::Kubernetes::ContainerManager.ems_type, &:all_entities))\n+        all_entities = ems.with_provider_connection { |client| fetch_entities(client, self.class.entities) }\n+        fetch = proc do |client|\n+          fetch_entities(\n+            client,\n+            ManageIQ::Providers::Kubernetes::ContainerManager::Refresher.entities\n+          )\n+        end\n+        all_entities.merge!(\n+          ems.with_provider_connection(\n+            :service => ManageIQ::Providers::Kubernetes::ContainerManager.ems_type,\n+            &fetch","path":"app/models/manageiq/providers/openshift/container_manager/refresher.rb","position":21,"original_position":21,"commit_id":"2aa2546cb14e52f49c08bdea2d7647c959a403af","original_commit_id":"2aa2546cb14e52f49c08bdea2d7647c959a403af","user":{"login":"simon3z","id":130393,"avatar_url":"https://avatars.githubusercontent.com/u/130393?v=3","gravatar_id":"","url":"https://api.github.com/users/simon3z","html_url":"https://github.com/simon3z","followers_url":"https://api.github.com/users/simon3z/followers","following_url":"https://api.github.com/users/simon3z/following{/other_user}","gists_url":"https://api.github.com/users/simon3z/gists{/gist_id}","starred_url":"https://api.github.com/users/simon3z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simon3z/subscriptions","organizations_url":"https://api.github.com/users/simon3z/orgs","repos_url":"https://api.github.com/users/simon3z/repos","events_url":"https://api.github.com/users/simon3z/events{/privacy}","received_events_url":"https://api.github.com/users/simon3z/received_events","type":"User","site_admin":false},"body":"    KUBERNETES_EMS_TYPE = ManageIQ::Providers::Kubernetes::ContainerManager.ems_type\r\n    ...\r\n    def parse_inventory(ems, _targets = nil)\r\n      ...\r\n      kubernetes_entitis = ems.with_provider_connection(:service => KUBERNETES_EMS_TYPE) do\r\n        fetch_entities(client, self.class.entities)\r\n      end\r\n      ...","created_at":"2015-10-13T21:41:56Z","updated_at":"2015-10-13T21:41:56Z","html_url":"https://github.com/ManageIQ/manageiq/pull/4726#discussion_r41929664","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4726","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/41929664"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/4726#discussion_r41929664"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4726"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4726","id":47022840,"html_url":"https://github.com/ManageIQ/manageiq/pull/4726","diff_url":"https://github.com/ManageIQ/manageiq/pull/4726.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/4726.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4726","number":4726,"state":"open","locked":false,"title":"kubernetes: whitelist fetch entities","user":{"login":"moolitayer","id":3010449,"avatar_url":"https://avatars.githubusercontent.com/u/3010449?v=3","gravatar_id":"","url":"https://api.github.com/users/moolitayer","html_url":"https://github.com/moolitayer","followers_url":"https://api.github.com/users/moolitayer/followers","following_url":"https://api.github.com/users/moolitayer/following{/other_user}","gists_url":"https://api.github.com/users/moolitayer/gists{/gist_id}","starred_url":"https://api.github.com/users/moolitayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moolitayer/subscriptions","organizations_url":"https://api.github.com/users/moolitayer/orgs","repos_url":"https://api.github.com/users/moolitayer/repos","events_url":"https://api.github.com/users/moolitayer/events{/privacy}","received_events_url":"https://api.github.com/users/moolitayer/received_events","type":"User","site_admin":false},"body":"Currently when kubeclient\\opeshift_client are updated with additional\r\nentities they are automarically fetched by manageiq (e.g secrets)\r\nthat calls all_entities. The purpose of this patch is to prevent this.","created_at":"2015-10-07T12:51:04Z","updated_at":"2015-10-13T21:41:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1829d8487735b31482a4f5845e25427553771a4a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4726/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4726/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4726/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/2aa2546cb14e52f49c08bdea2d7647c959a403af","head":{"label":"moolitayer:whitelist_entities","ref":"whitelist_entities","sha":"2aa2546cb14e52f49c08bdea2d7647c959a403af","user":{"login":"moolitayer","id":3010449,"avatar_url":"https://avatars.githubusercontent.com/u/3010449?v=3","gravatar_id":"","url":"https://api.github.com/users/moolitayer","html_url":"https://github.com/moolitayer","followers_url":"https://api.github.com/users/moolitayer/followers","following_url":"https://api.github.com/users/moolitayer/following{/other_user}","gists_url":"https://api.github.com/users/moolitayer/gists{/gist_id}","starred_url":"https://api.github.com/users/moolitayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moolitayer/subscriptions","organizations_url":"https://api.github.com/users/moolitayer/orgs","repos_url":"https://api.github.com/users/moolitayer/repos","events_url":"https://api.github.com/users/moolitayer/events{/privacy}","received_events_url":"https://api.github.com/users/moolitayer/received_events","type":"User","site_admin":false},"repo":{"id":35763260,"name":"manageiq","full_name":"moolitayer/manageiq","owner":{"login":"moolitayer","id":3010449,"avatar_url":"https://avatars.githubusercontent.com/u/3010449?v=3","gravatar_id":"","url":"https://api.github.com/users/moolitayer","html_url":"https://github.com/moolitayer","followers_url":"https://api.github.com/users/moolitayer/followers","following_url":"https://api.github.com/users/moolitayer/following{/other_user}","gists_url":"https://api.github.com/users/moolitayer/gists{/gist_id}","starred_url":"https://api.github.com/users/moolitayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moolitayer/subscriptions","organizations_url":"https://api.github.com/users/moolitayer/orgs","repos_url":"https://api.github.com/users/moolitayer/repos","events_url":"https://api.github.com/users/moolitayer/events{/privacy}","received_events_url":"https://api.github.com/users/moolitayer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/moolitayer/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/moolitayer/manageiq","forks_url":"https://api.github.com/repos/moolitayer/manageiq/forks","keys_url":"https://api.github.com/repos/moolitayer/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moolitayer/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moolitayer/manageiq/teams","hooks_url":"https://api.github.com/repos/moolitayer/manageiq/hooks","issue_events_url":"https://api.github.com/repos/moolitayer/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/moolitayer/manageiq/events","assignees_url":"https://api.github.com/repos/moolitayer/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/moolitayer/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/moolitayer/manageiq/tags","blobs_url":"https://api.github.com/repos/moolitayer/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moolitayer/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moolitayer/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/moolitayer/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moolitayer/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/moolitayer/manageiq/languages","stargazers_url":"https://api.github.com/repos/moolitayer/manageiq/stargazers","contributors_url":"https://api.github.com/repos/moolitayer/manageiq/contributors","subscribers_url":"https://api.github.com/repos/moolitayer/manageiq/subscribers","subscription_url":"https://api.github.com/repos/moolitayer/manageiq/subscription","commits_url":"https://api.github.com/repos/moolitayer/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/moolitayer/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/moolitayer/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/moolitayer/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/moolitayer/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/moolitayer/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moolitayer/manageiq/merges","archive_url":"https://api.github.com/repos/moolitayer/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moolitayer/manageiq/downloads","issues_url":"https://api.github.com/repos/moolitayer/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/moolitayer/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/moolitayer/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/moolitayer/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moolitayer/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/moolitayer/manageiq/releases{/id}","created_at":"2015-05-17T11:18:34Z","updated_at":"2015-05-17T11:18:51Z","pushed_at":"2015-10-13T16:38:58Z","git_url":"git://github.com/moolitayer/manageiq.git","ssh_url":"git@github.com:moolitayer/manageiq.git","clone_url":"https://github.com/moolitayer/manageiq.git","svn_url":"https://github.com/moolitayer/manageiq","homepage":"manageiq.org","size":89393,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"1fdc13a16cbdefda4233e01a08eb408112ccfa8c","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2015-10-13T21:08:35Z","pushed_at":"2015-10-13T21:19:03Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":172029,"stargazers_count":161,"watchers_count":161,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":165,"mirror_url":null,"open_issues_count":437,"forks":165,"open_issues":437,"watchers":161,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4726"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/4726"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/4726"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/4726/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4726/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4726/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/2aa2546cb14e52f49c08bdea2d7647c959a403af"}}}}