{"action":"opened","number":1807,"pull_request":{"url":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/1807","id":52823937,"html_url":"https://github.com/letsencrypt/letsencrypt/pull/1807","diff_url":"https://github.com/letsencrypt/letsencrypt/pull/1807.diff","patch_url":"https://github.com/letsencrypt/letsencrypt/pull/1807.patch","issue_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/1807","number":1807,"state":"open","locked":false,"title":"Make webroot usable also when running as non-root (GH #1795) - WIP","user":{"login":"lbeltrame","id":25192,"avatar_url":"https://avatars.githubusercontent.com/u/25192?v=3","gravatar_id":"","url":"https://api.github.com/users/lbeltrame","html_url":"https://github.com/lbeltrame","followers_url":"https://api.github.com/users/lbeltrame/followers","following_url":"https://api.github.com/users/lbeltrame/following{/other_user}","gists_url":"https://api.github.com/users/lbeltrame/gists{/gist_id}","starred_url":"https://api.github.com/users/lbeltrame/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbeltrame/subscriptions","organizations_url":"https://api.github.com/users/lbeltrame/orgs","repos_url":"https://api.github.com/users/lbeltrame/repos","events_url":"https://api.github.com/users/lbeltrame/events{/privacy}","received_events_url":"https://api.github.com/users/lbeltrame/received_events","type":"User","site_admin":false},"body":"Thanks to @aburch's suggestions, the logic has been changed:\r\n\r\n- Set umask before creating folders and files\r\n- Leverage os.makedirs' mode option in conjunction with umask\r\n\r\nThe program still tries to change owner / group, but in case of errors\r\nit continues gracefully.\r\n\r\nTests have been updated, and they pass.\r\n\r\nThis does not implement all the suggestions offered, and it's posted for review.","created_at":"2015-12-07T09:53:29Z","updated_at":"2015-12-07T09:53:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/1807/commits","review_comments_url":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/1807/comments","review_comment_url":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/1807/comments","statuses_url":"https://api.github.com/repos/letsencrypt/letsencrypt/statuses/edf3a4ed732e1123cf257bd9c999c7ca6e468fb4","head":{"label":"lbeltrame:webroot-permission-fixes","ref":"webroot-permission-fixes","sha":"edf3a4ed732e1123cf257bd9c999c7ca6e468fb4","user":{"login":"lbeltrame","id":25192,"avatar_url":"https://avatars.githubusercontent.com/u/25192?v=3","gravatar_id":"","url":"https://api.github.com/users/lbeltrame","html_url":"https://github.com/lbeltrame","followers_url":"https://api.github.com/users/lbeltrame/followers","following_url":"https://api.github.com/users/lbeltrame/following{/other_user}","gists_url":"https://api.github.com/users/lbeltrame/gists{/gist_id}","starred_url":"https://api.github.com/users/lbeltrame/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbeltrame/subscriptions","organizations_url":"https://api.github.com/users/lbeltrame/orgs","repos_url":"https://api.github.com/users/lbeltrame/repos","events_url":"https://api.github.com/users/lbeltrame/events{/privacy}","received_events_url":"https://api.github.com/users/lbeltrame/received_events","type":"User","site_admin":false},"repo":{"id":46663561,"name":"letsencrypt","full_name":"lbeltrame/letsencrypt","owner":{"login":"lbeltrame","id":25192,"avatar_url":"https://avatars.githubusercontent.com/u/25192?v=3","gravatar_id":"","url":"https://api.github.com/users/lbeltrame","html_url":"https://github.com/lbeltrame","followers_url":"https://api.github.com/users/lbeltrame/followers","following_url":"https://api.github.com/users/lbeltrame/following{/other_user}","gists_url":"https://api.github.com/users/lbeltrame/gists{/gist_id}","starred_url":"https://api.github.com/users/lbeltrame/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbeltrame/subscriptions","organizations_url":"https://api.github.com/users/lbeltrame/orgs","repos_url":"https://api.github.com/users/lbeltrame/repos","events_url":"https://api.github.com/users/lbeltrame/events{/privacy}","received_events_url":"https://api.github.com/users/lbeltrame/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lbeltrame/letsencrypt","description":"This Let's Encrypt repo is an ACME client that can obtain certs and extensibly update server configurations (currently supports Apache on .deb based systems, nginx support coming soon)","fork":true,"url":"https://api.github.com/repos/lbeltrame/letsencrypt","forks_url":"https://api.github.com/repos/lbeltrame/letsencrypt/forks","keys_url":"https://api.github.com/repos/lbeltrame/letsencrypt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lbeltrame/letsencrypt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lbeltrame/letsencrypt/teams","hooks_url":"https://api.github.com/repos/lbeltrame/letsencrypt/hooks","issue_events_url":"https://api.github.com/repos/lbeltrame/letsencrypt/issues/events{/number}","events_url":"https://api.github.com/repos/lbeltrame/letsencrypt/events","assignees_url":"https://api.github.com/repos/lbeltrame/letsencrypt/assignees{/user}","branches_url":"https://api.github.com/repos/lbeltrame/letsencrypt/branches{/branch}","tags_url":"https://api.github.com/repos/lbeltrame/letsencrypt/tags","blobs_url":"https://api.github.com/repos/lbeltrame/letsencrypt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lbeltrame/letsencrypt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lbeltrame/letsencrypt/git/refs{/sha}","trees_url":"https://api.github.com/repos/lbeltrame/letsencrypt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lbeltrame/letsencrypt/statuses/{sha}","languages_url":"https://api.github.com/repos/lbeltrame/letsencrypt/languages","stargazers_url":"https://api.github.com/repos/lbeltrame/letsencrypt/stargazers","contributors_url":"https://api.github.com/repos/lbeltrame/letsencrypt/contributors","subscribers_url":"https://api.github.com/repos/lbeltrame/letsencrypt/subscribers","subscription_url":"https://api.github.com/repos/lbeltrame/letsencrypt/subscription","commits_url":"https://api.github.com/repos/lbeltrame/letsencrypt/commits{/sha}","git_commits_url":"https://api.github.com/repos/lbeltrame/letsencrypt/git/commits{/sha}","comments_url":"https://api.github.com/repos/lbeltrame/letsencrypt/comments{/number}","issue_comment_url":"https://api.github.com/repos/lbeltrame/letsencrypt/issues/comments{/number}","contents_url":"https://api.github.com/repos/lbeltrame/letsencrypt/contents/{+path}","compare_url":"https://api.github.com/repos/lbeltrame/letsencrypt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lbeltrame/letsencrypt/merges","archive_url":"https://api.github.com/repos/lbeltrame/letsencrypt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lbeltrame/letsencrypt/downloads","issues_url":"https://api.github.com/repos/lbeltrame/letsencrypt/issues{/number}","pulls_url":"https://api.github.com/repos/lbeltrame/letsencrypt/pulls{/number}","milestones_url":"https://api.github.com/repos/lbeltrame/letsencrypt/milestones{/number}","notifications_url":"https://api.github.com/repos/lbeltrame/letsencrypt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lbeltrame/letsencrypt/labels{/name}","releases_url":"https://api.github.com/repos/lbeltrame/letsencrypt/releases{/id}","created_at":"2015-11-22T14:15:44Z","updated_at":"2015-11-22T14:15:46Z","pushed_at":"2015-12-07T09:51:47Z","git_url":"git://github.com/lbeltrame/letsencrypt.git","ssh_url":"git@github.com:lbeltrame/letsencrypt.git","clone_url":"https://github.com/lbeltrame/letsencrypt.git","svn_url":"https://github.com/lbeltrame/letsencrypt","homepage":"","size":6802,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"letsencrypt:master","ref":"master","sha":"ce0ea2b104be7a246d2bfd7960b42146f1b3dbbe","user":{"login":"letsencrypt","id":9289019,"avatar_url":"https://avatars.githubusercontent.com/u/9289019?v=3","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"repo":{"id":26516210,"name":"letsencrypt","full_name":"letsencrypt/letsencrypt","owner":{"login":"letsencrypt","id":9289019,"avatar_url":"https://avatars.githubusercontent.com/u/9289019?v=3","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/letsencrypt/letsencrypt","description":"This Let's Encrypt repo is an ACME client that can obtain certs and extensibly update server configurations (currently supports Apache on .deb based systems, nginx support coming soon)","fork":false,"url":"https://api.github.com/repos/letsencrypt/letsencrypt","forks_url":"https://api.github.com/repos/letsencrypt/letsencrypt/forks","keys_url":"https://api.github.com/repos/letsencrypt/letsencrypt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/letsencrypt/letsencrypt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/letsencrypt/letsencrypt/teams","hooks_url":"https://api.github.com/repos/letsencrypt/letsencrypt/hooks","issue_events_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/events{/number}","events_url":"https://api.github.com/repos/letsencrypt/letsencrypt/events","assignees_url":"https://api.github.com/repos/letsencrypt/letsencrypt/assignees{/user}","branches_url":"https://api.github.com/repos/letsencrypt/letsencrypt/branches{/branch}","tags_url":"https://api.github.com/repos/letsencrypt/letsencrypt/tags","blobs_url":"https://api.github.com/repos/letsencrypt/letsencrypt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/letsencrypt/letsencrypt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/letsencrypt/letsencrypt/git/refs{/sha}","trees_url":"https://api.github.com/repos/letsencrypt/letsencrypt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/letsencrypt/letsencrypt/statuses/{sha}","languages_url":"https://api.github.com/repos/letsencrypt/letsencrypt/languages","stargazers_url":"https://api.github.com/repos/letsencrypt/letsencrypt/stargazers","contributors_url":"https://api.github.com/repos/letsencrypt/letsencrypt/contributors","subscribers_url":"https://api.github.com/repos/letsencrypt/letsencrypt/subscribers","subscription_url":"https://api.github.com/repos/letsencrypt/letsencrypt/subscription","commits_url":"https://api.github.com/repos/letsencrypt/letsencrypt/commits{/sha}","git_commits_url":"https://api.github.com/repos/letsencrypt/letsencrypt/git/commits{/sha}","comments_url":"https://api.github.com/repos/letsencrypt/letsencrypt/comments{/number}","issue_comment_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/comments{/number}","contents_url":"https://api.github.com/repos/letsencrypt/letsencrypt/contents/{+path}","compare_url":"https://api.github.com/repos/letsencrypt/letsencrypt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/letsencrypt/letsencrypt/merges","archive_url":"https://api.github.com/repos/letsencrypt/letsencrypt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/letsencrypt/letsencrypt/downloads","issues_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues{/number}","pulls_url":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls{/number}","milestones_url":"https://api.github.com/repos/letsencrypt/letsencrypt/milestones{/number}","notifications_url":"https://api.github.com/repos/letsencrypt/letsencrypt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/letsencrypt/letsencrypt/labels{/name}","releases_url":"https://api.github.com/repos/letsencrypt/letsencrypt/releases{/id}","created_at":"2014-11-12T02:52:20Z","updated_at":"2015-12-07T09:51:31Z","pushed_at":"2015-12-07T09:15:51Z","git_url":"git://github.com/letsencrypt/letsencrypt.git","ssh_url":"git@github.com:letsencrypt/letsencrypt.git","clone_url":"https://github.com/letsencrypt/letsencrypt.git","svn_url":"https://github.com/letsencrypt/letsencrypt","homepage":"","size":12166,"stargazers_count":8752,"watchers_count":8752,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":630,"mirror_url":null,"open_issues_count":403,"forks":630,"open_issues":403,"watchers":8752,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/1807"},"html":{"href":"https://github.com/letsencrypt/letsencrypt/pull/1807"},"issue":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/1807"},"comments":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/1807/comments"},"review_comments":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/1807/comments"},"review_comment":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/1807/commits"},"statuses":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/statuses/edf3a4ed732e1123cf257bd9c999c7ca6e468fb4"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":43,"deletions":23,"changed_files":2}}