{"action":"created","comment":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/comments/34407856","id":34407856,"diff_hunk":"@@ -76,7 +75,7 @@ size_t IVFCFile::Write(const u64 offset, const u32 length, const u32 flush, cons\n }\n \n size_t IVFCFile::GetSize() const {\n-    return sizeof(u8) * data->size();\n+    return sizeof(u8) * data_size;","path":"src/core/file_sys/ivfc_archive.cpp","position":35,"original_position":35,"commit_id":"3c06e9b8c8e7ecaaa9f0074ea388c7c8dc6277e7","original_commit_id":"3c06e9b8c8e7ecaaa9f0074ea388c7c8dc6277e7","user":{"login":"yuriks","id":341401,"avatar_url":"https://avatars.githubusercontent.com/u/341401?v=3","gravatar_id":"","url":"https://api.github.com/users/yuriks","html_url":"https://github.com/yuriks","followers_url":"https://api.github.com/users/yuriks/followers","following_url":"https://api.github.com/users/yuriks/following{/other_user}","gists_url":"https://api.github.com/users/yuriks/gists{/gist_id}","starred_url":"https://api.github.com/users/yuriks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuriks/subscriptions","organizations_url":"https://api.github.com/users/yuriks/orgs","repos_url":"https://api.github.com/users/yuriks/repos","events_url":"https://api.github.com/users/yuriks/events{/privacy}","received_events_url":"https://api.github.com/users/yuriks/received_events","type":"User","site_admin":false},"body":"Right now, no. It's still wrong. :)","created_at":"2015-07-11T01:14:16Z","updated_at":"2015-07-11T01:14:16Z","html_url":"https://github.com/citra-emu/citra/pull/911#discussion_r34407856","pull_request_url":"https://api.github.com/repos/citra-emu/citra/pulls/911","_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments/34407856"},"html":{"href":"https://github.com/citra-emu/citra/pull/911#discussion_r34407856"},"pull_request":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/911"}}},"pull_request":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/911","id":39633610,"html_url":"https://github.com/citra-emu/citra/pull/911","diff_url":"https://github.com/citra-emu/citra/pull/911.diff","patch_url":"https://github.com/citra-emu/citra/pull/911.patch","issue_url":"https://api.github.com/repos/citra-emu/citra/issues/911","number":911,"state":"open","locked":false,"title":"Do not load entire RomFS to memory, read from the file as needed instead.","user":{"login":"condut","id":13262826,"avatar_url":"https://avatars.githubusercontent.com/u/13262826?v=3","gravatar_id":"","url":"https://api.github.com/users/condut","html_url":"https://github.com/condut","followers_url":"https://api.github.com/users/condut/followers","following_url":"https://api.github.com/users/condut/following{/other_user}","gists_url":"https://api.github.com/users/condut/gists{/gist_id}","starred_url":"https://api.github.com/users/condut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/condut/subscriptions","organizations_url":"https://api.github.com/users/condut/orgs","repos_url":"https://api.github.com/users/condut/repos","events_url":"https://api.github.com/users/condut/events{/privacy}","received_events_url":"https://api.github.com/users/condut/received_events","type":"User","site_admin":false},"body":"Changes the loader/ivfs code to read from the file as needed instead of loading the entire RomFS to memory (which can often take 4+ seconds for large RomFSes)\r\n\r\nFeel free to change the code to be how you like it, if needed.","created_at":"2015-07-09T22:06:02Z","updated_at":"2015-07-11T01:14:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0bf4e7ad396f5b64a4adc3587eafca9d51fc562f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/citra-emu/citra/pulls/911/commits","review_comments_url":"https://api.github.com/repos/citra-emu/citra/pulls/911/comments","review_comment_url":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/citra-emu/citra/issues/911/comments","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/3c06e9b8c8e7ecaaa9f0074ea388c7c8dc6277e7","head":{"label":"condut:master","ref":"master","sha":"3c06e9b8c8e7ecaaa9f0074ea388c7c8dc6277e7","user":{"login":"condut","id":13262826,"avatar_url":"https://avatars.githubusercontent.com/u/13262826?v=3","gravatar_id":"","url":"https://api.github.com/users/condut","html_url":"https://github.com/condut","followers_url":"https://api.github.com/users/condut/followers","following_url":"https://api.github.com/users/condut/following{/other_user}","gists_url":"https://api.github.com/users/condut/gists{/gist_id}","starred_url":"https://api.github.com/users/condut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/condut/subscriptions","organizations_url":"https://api.github.com/users/condut/orgs","repos_url":"https://api.github.com/users/condut/repos","events_url":"https://api.github.com/users/condut/events{/privacy}","received_events_url":"https://api.github.com/users/condut/received_events","type":"User","site_admin":false},"repo":{"id":38846943,"name":"citra","full_name":"condut/citra","owner":{"login":"condut","id":13262826,"avatar_url":"https://avatars.githubusercontent.com/u/13262826?v=3","gravatar_id":"","url":"https://api.github.com/users/condut","html_url":"https://github.com/condut","followers_url":"https://api.github.com/users/condut/followers","following_url":"https://api.github.com/users/condut/following{/other_user}","gists_url":"https://api.github.com/users/condut/gists{/gist_id}","starred_url":"https://api.github.com/users/condut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/condut/subscriptions","organizations_url":"https://api.github.com/users/condut/orgs","repos_url":"https://api.github.com/users/condut/repos","events_url":"https://api.github.com/users/condut/events{/privacy}","received_events_url":"https://api.github.com/users/condut/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/condut/citra","description":"Nintendo 3DS emulator/debugger","fork":true,"url":"https://api.github.com/repos/condut/citra","forks_url":"https://api.github.com/repos/condut/citra/forks","keys_url":"https://api.github.com/repos/condut/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/condut/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/condut/citra/teams","hooks_url":"https://api.github.com/repos/condut/citra/hooks","issue_events_url":"https://api.github.com/repos/condut/citra/issues/events{/number}","events_url":"https://api.github.com/repos/condut/citra/events","assignees_url":"https://api.github.com/repos/condut/citra/assignees{/user}","branches_url":"https://api.github.com/repos/condut/citra/branches{/branch}","tags_url":"https://api.github.com/repos/condut/citra/tags","blobs_url":"https://api.github.com/repos/condut/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/condut/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/condut/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/condut/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/condut/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/condut/citra/languages","stargazers_url":"https://api.github.com/repos/condut/citra/stargazers","contributors_url":"https://api.github.com/repos/condut/citra/contributors","subscribers_url":"https://api.github.com/repos/condut/citra/subscribers","subscription_url":"https://api.github.com/repos/condut/citra/subscription","commits_url":"https://api.github.com/repos/condut/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/condut/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/condut/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/condut/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/condut/citra/contents/{+path}","compare_url":"https://api.github.com/repos/condut/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/condut/citra/merges","archive_url":"https://api.github.com/repos/condut/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/condut/citra/downloads","issues_url":"https://api.github.com/repos/condut/citra/issues{/number}","pulls_url":"https://api.github.com/repos/condut/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/condut/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/condut/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/condut/citra/labels{/name}","releases_url":"https://api.github.com/repos/condut/citra/releases{/id}","created_at":"2015-07-09T21:47:00Z","updated_at":"2015-07-09T21:47:03Z","pushed_at":"2015-07-09T23:33:44Z","git_url":"git://github.com/condut/citra.git","ssh_url":"git@github.com:condut/citra.git","clone_url":"https://github.com/condut/citra.git","svn_url":"https://github.com/condut/citra","homepage":null,"size":9308,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"citra-emu:master","ref":"master","sha":"ac7bc214abe6b8f9eb2c122709ea99a0ca4b4245","user":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=3","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":19866730,"name":"citra","full_name":"citra-emu/citra","owner":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=3","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/citra-emu/citra","description":"Nintendo 3DS emulator/debugger","fork":false,"url":"https://api.github.com/repos/citra-emu/citra","forks_url":"https://api.github.com/repos/citra-emu/citra/forks","keys_url":"https://api.github.com/repos/citra-emu/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/citra-emu/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/citra-emu/citra/teams","hooks_url":"https://api.github.com/repos/citra-emu/citra/hooks","issue_events_url":"https://api.github.com/repos/citra-emu/citra/issues/events{/number}","events_url":"https://api.github.com/repos/citra-emu/citra/events","assignees_url":"https://api.github.com/repos/citra-emu/citra/assignees{/user}","branches_url":"https://api.github.com/repos/citra-emu/citra/branches{/branch}","tags_url":"https://api.github.com/repos/citra-emu/citra/tags","blobs_url":"https://api.github.com/repos/citra-emu/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/citra-emu/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/citra-emu/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/citra-emu/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/citra-emu/citra/languages","stargazers_url":"https://api.github.com/repos/citra-emu/citra/stargazers","contributors_url":"https://api.github.com/repos/citra-emu/citra/contributors","subscribers_url":"https://api.github.com/repos/citra-emu/citra/subscribers","subscription_url":"https://api.github.com/repos/citra-emu/citra/subscription","commits_url":"https://api.github.com/repos/citra-emu/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/citra-emu/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/citra-emu/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/citra-emu/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/citra-emu/citra/contents/{+path}","compare_url":"https://api.github.com/repos/citra-emu/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/citra-emu/citra/merges","archive_url":"https://api.github.com/repos/citra-emu/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/citra-emu/citra/downloads","issues_url":"https://api.github.com/repos/citra-emu/citra/issues{/number}","pulls_url":"https://api.github.com/repos/citra-emu/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/citra-emu/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/citra-emu/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/citra-emu/citra/labels{/name}","releases_url":"https://api.github.com/repos/citra-emu/citra/releases{/id}","created_at":"2014-05-16T18:33:15Z","updated_at":"2015-07-10T08:46:56Z","pushed_at":"2015-07-11T00:13:31Z","git_url":"git://github.com/citra-emu/citra.git","ssh_url":"git@github.com:citra-emu/citra.git","clone_url":"https://github.com/citra-emu/citra.git","svn_url":"https://github.com/citra-emu/citra","homepage":null,"size":21026,"stargazers_count":963,"watchers_count":963,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":247,"mirror_url":null,"open_issues_count":92,"forks":247,"open_issues":92,"watchers":963,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/911"},"html":{"href":"https://github.com/citra-emu/citra/pull/911"},"issue":{"href":"https://api.github.com/repos/citra-emu/citra/issues/911"},"comments":{"href":"https://api.github.com/repos/citra-emu/citra/issues/911/comments"},"review_comments":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/911/comments"},"review_comment":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/911/commits"},"statuses":{"href":"https://api.github.com/repos/citra-emu/citra/statuses/3c06e9b8c8e7ecaaa9f0074ea388c7c8dc6277e7"}}}}