{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/46476334","id":46476334,"diff_hunk":"@@ -83,7 +83,7 @@ kubernetesMasterConfig:\n {% endif %}\n   apiServerArguments: {{ api_server_args if api_server_args is defined else 'null' }}\n   controllerArguments: {{ controller_args if controller_args is defined else 'null' }}\n-  masterCount: {{ openshift.master.master_count }}\n+  masterCount: {{ openshift.master.master_count if not openshift.master.cluster_method is defined or openshift.master.cluster_method == 'native' else 1 }}","path":"roles/openshift_master/templates/master.yaml.v1.j2","position":5,"original_position":5,"commit_id":"df35879202f0ad004a0fa5dff80cc943061bca3e","original_commit_id":"df35879202f0ad004a0fa5dff80cc943061bca3e","user":{"login":"detiber","id":915544,"avatar_url":"https://avatars.githubusercontent.com/u/915544?v=3","gravatar_id":"","url":"https://api.github.com/users/detiber","html_url":"https://github.com/detiber","followers_url":"https://api.github.com/users/detiber/followers","following_url":"https://api.github.com/users/detiber/following{/other_user}","gists_url":"https://api.github.com/users/detiber/gists{/gist_id}","starred_url":"https://api.github.com/users/detiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/detiber/subscriptions","organizations_url":"https://api.github.com/users/detiber/orgs","repos_url":"https://api.github.com/users/detiber/repos","events_url":"https://api.github.com/users/detiber/events{/privacy}","received_events_url":"https://api.github.com/users/detiber/received_events","type":"User","site_admin":false},"body":"This might be a bit cleaner:\r\n```\r\n  masterCount: {{ openshift.master.master_count if openshift.master.cluster_method | default(None) == 'native' else 1 }}\r\n```\r\n\r\nI've started to yank the is defined tests in favor of using the deafult filter for tests like this.","created_at":"2015-12-02T21:16:04Z","updated_at":"2015-12-02T21:16:04Z","html_url":"https://github.com/openshift/openshift-ansible/pull/1010#discussion_r46476334","pull_request_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1010","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/46476334"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/1010#discussion_r46476334"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1010"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1010","id":52446892,"html_url":"https://github.com/openshift/openshift-ansible/pull/1010","diff_url":"https://github.com/openshift/openshift-ansible/pull/1010.diff","patch_url":"https://github.com/openshift/openshift-ansible/pull/1010.patch","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/1010","number":1010,"state":"open","locked":false,"title":"Use masterCount=1 with pacemaker ha","user":{"login":"abutcher","id":47003,"avatar_url":"https://avatars.githubusercontent.com/u/47003?v=3","gravatar_id":"","url":"https://api.github.com/users/abutcher","html_url":"https://github.com/abutcher","followers_url":"https://api.github.com/users/abutcher/followers","following_url":"https://api.github.com/users/abutcher/following{/other_user}","gists_url":"https://api.github.com/users/abutcher/gists{/gist_id}","starred_url":"https://api.github.com/users/abutcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abutcher/subscriptions","organizations_url":"https://api.github.com/users/abutcher/orgs","repos_url":"https://api.github.com/users/abutcher/repos","events_url":"https://api.github.com/users/abutcher/events{/privacy}","received_events_url":"https://api.github.com/users/abutcher/received_events","type":"User","site_admin":false},"body":"Only one master runs at a time using the pacemaker method for ha so this config makes more sense but also has some benefits w/ the controller and kubernetes service/endpoints.\r\n\r\nThe controller will modify the endpoints for the kubernetes service to contain the IP of masters. If we were to fail over, a masterCount of 1 would mean that the new master IP should be added to the endpoint and the old master IP should be removed because IPs start getting removed when the number of addresses is greater than the master count.\r\n\r\nWith a higher master count, the controller will leave all master IPs up to the count in the endpoints which is not good.\r\n\r\nThis change will also stop the controller from updating the endpoints every loop iteration but this behavior will also be fixed incidentally by https://github.com/openshift/origin/pull/6163.\r\n\r\nIf statement in the config is ugly but we rely on this count outside of the template to indicate that we're dealing with HA.\r\n\r\n@detiber @brenton ","created_at":"2015-12-02T20:06:04Z","updated_at":"2015-12-02T21:16:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"572f133b62620e45e3d9fff3bbd91082e39dd0ac","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1010/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1010/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/1010/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/df35879202f0ad004a0fa5dff80cc943061bca3e","head":{"label":"abutcher:pacemaker-count","ref":"pacemaker-count","sha":"df35879202f0ad004a0fa5dff80cc943061bca3e","user":{"login":"abutcher","id":47003,"avatar_url":"https://avatars.githubusercontent.com/u/47003?v=3","gravatar_id":"","url":"https://api.github.com/users/abutcher","html_url":"https://github.com/abutcher","followers_url":"https://api.github.com/users/abutcher/followers","following_url":"https://api.github.com/users/abutcher/following{/other_user}","gists_url":"https://api.github.com/users/abutcher/gists{/gist_id}","starred_url":"https://api.github.com/users/abutcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abutcher/subscriptions","organizations_url":"https://api.github.com/users/abutcher/orgs","repos_url":"https://api.github.com/users/abutcher/repos","events_url":"https://api.github.com/users/abutcher/events{/privacy}","received_events_url":"https://api.github.com/users/abutcher/received_events","type":"User","site_admin":false},"repo":{"id":40020725,"name":"openshift-ansible","full_name":"abutcher/openshift-ansible","owner":{"login":"abutcher","id":47003,"avatar_url":"https://avatars.githubusercontent.com/u/47003?v=3","gravatar_id":"","url":"https://api.github.com/users/abutcher","html_url":"https://github.com/abutcher","followers_url":"https://api.github.com/users/abutcher/followers","following_url":"https://api.github.com/users/abutcher/following{/other_user}","gists_url":"https://api.github.com/users/abutcher/gists{/gist_id}","starred_url":"https://api.github.com/users/abutcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abutcher/subscriptions","organizations_url":"https://api.github.com/users/abutcher/orgs","repos_url":"https://api.github.com/users/abutcher/repos","events_url":"https://api.github.com/users/abutcher/events{/privacy}","received_events_url":"https://api.github.com/users/abutcher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abutcher/openshift-ansible","description":"OpenShift Ansible Code","fork":true,"url":"https://api.github.com/repos/abutcher/openshift-ansible","forks_url":"https://api.github.com/repos/abutcher/openshift-ansible/forks","keys_url":"https://api.github.com/repos/abutcher/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abutcher/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abutcher/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/abutcher/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/abutcher/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/abutcher/openshift-ansible/events","assignees_url":"https://api.github.com/repos/abutcher/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/abutcher/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/abutcher/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/abutcher/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abutcher/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abutcher/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/abutcher/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abutcher/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/abutcher/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/abutcher/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/abutcher/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/abutcher/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/abutcher/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/abutcher/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/abutcher/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/abutcher/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/abutcher/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/abutcher/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/abutcher/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abutcher/openshift-ansible/merges","archive_url":"https://api.github.com/repos/abutcher/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abutcher/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/abutcher/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/abutcher/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/abutcher/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/abutcher/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abutcher/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/abutcher/openshift-ansible/releases{/id}","created_at":"2015-07-31T19:07:31Z","updated_at":"2015-07-31T19:07:33Z","pushed_at":"2015-12-02T21:10:23Z","git_url":"git://github.com/abutcher/openshift-ansible.git","ssh_url":"git@github.com:abutcher/openshift-ansible.git","clone_url":"https://github.com/abutcher/openshift-ansible.git","svn_url":"https://github.com/abutcher/openshift-ansible","homepage":"","size":2223,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"e14da724f79e1fd75aea03bfab2179c7ef42c3e6","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":24109199,"name":"openshift-ansible","full_name":"openshift/openshift-ansible","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-ansible","description":"OpenShift Ansible Code","fork":false,"url":"https://api.github.com/repos/openshift/openshift-ansible","forks_url":"https://api.github.com/repos/openshift/openshift-ansible/forks","keys_url":"https://api.github.com/repos/openshift/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-ansible/events","assignees_url":"https://api.github.com/repos/openshift/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-ansible/merges","archive_url":"https://api.github.com/repos/openshift/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-ansible/releases{/id}","created_at":"2014-09-16T17:07:51Z","updated_at":"2015-12-02T15:08:56Z","pushed_at":"2015-12-02T20:55:39Z","git_url":"git://github.com/openshift/openshift-ansible.git","ssh_url":"git@github.com:openshift/openshift-ansible.git","clone_url":"https://github.com/openshift/openshift-ansible.git","svn_url":"https://github.com/openshift/openshift-ansible","homepage":"install.openshift.com","size":3152,"stargazers_count":93,"watchers_count":93,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":172,"mirror_url":null,"open_issues_count":159,"forks":172,"open_issues":159,"watchers":93,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1010"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/1010"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/1010"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/1010/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1010/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1010/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-ansible/statuses/df35879202f0ad004a0fa5dff80cc943061bca3e"}}}}