{"action":"opened","number":660,"pull_request":{"url":"https://api.github.com/repos/tgriesser/knex/pulls/660","id":28572538,"html_url":"https://github.com/tgriesser/knex/pull/660","diff_url":"https://github.com/tgriesser/knex/pull/660.diff","patch_url":"https://github.com/tgriesser/knex/pull/660.patch","issue_url":"https://api.github.com/repos/tgriesser/knex/issues/660","number":660,"state":"open","locked":false,"title":"Respect union wrap parameter as last argument","user":{"login":"werkt","id":21398,"avatar_url":"https://avatars.githubusercontent.com/u/21398?v=3","gravatar_id":"","url":"https://api.github.com/users/werkt","html_url":"https://github.com/werkt","followers_url":"https://api.github.com/users/werkt/followers","following_url":"https://api.github.com/users/werkt/following{/other_user}","gists_url":"https://api.github.com/users/werkt/gists{/gist_id}","starred_url":"https://api.github.com/users/werkt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/werkt/subscriptions","organizations_url":"https://api.github.com/users/werkt/orgs","repos_url":"https://api.github.com/users/werkt/repos","events_url":"https://api.github.com/users/werkt/events{/privacy}","received_events_url":"https://api.github.com/users/werkt/received_events","type":"User","site_admin":false},"body":"union's wrap parameter was being ignored and misinterpreted when\r\nbuilding statements.  Maintain the spirit of the original implementation\r\n(variable number of callbacks) consistent with other instances of\r\nvariadic-like behavior (select/columns), including handling list of\r\ncallbacks in array, while still processing the wrap parameter.\r\n\r\nUpdated documentation which was missing a reference to wrap, and\r\nprovided a unit test for wrapped unions.","created_at":"2015-02-03T17:40:29Z","updated_at":"2015-02-03T17:40:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tgriesser/knex/pulls/660/commits","review_comments_url":"https://api.github.com/repos/tgriesser/knex/pulls/660/comments","review_comment_url":"https://api.github.com/repos/tgriesser/knex/pulls/comments/{number}","comments_url":"https://api.github.com/repos/tgriesser/knex/issues/660/comments","statuses_url":"https://api.github.com/repos/tgriesser/knex/statuses/f6952c42b5798ea467fc05529eefa54ccdc76b93","head":{"label":"werkt:union_wrap_ignored","ref":"union_wrap_ignored","sha":"f6952c42b5798ea467fc05529eefa54ccdc76b93","user":{"login":"werkt","id":21398,"avatar_url":"https://avatars.githubusercontent.com/u/21398?v=3","gravatar_id":"","url":"https://api.github.com/users/werkt","html_url":"https://github.com/werkt","followers_url":"https://api.github.com/users/werkt/followers","following_url":"https://api.github.com/users/werkt/following{/other_user}","gists_url":"https://api.github.com/users/werkt/gists{/gist_id}","starred_url":"https://api.github.com/users/werkt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/werkt/subscriptions","organizations_url":"https://api.github.com/users/werkt/orgs","repos_url":"https://api.github.com/users/werkt/repos","events_url":"https://api.github.com/users/werkt/events{/privacy}","received_events_url":"https://api.github.com/users/werkt/received_events","type":"User","site_admin":false},"repo":{"id":30255633,"name":"knex","full_name":"werkt/knex","owner":{"login":"werkt","id":21398,"avatar_url":"https://avatars.githubusercontent.com/u/21398?v=3","gravatar_id":"","url":"https://api.github.com/users/werkt","html_url":"https://github.com/werkt","followers_url":"https://api.github.com/users/werkt/followers","following_url":"https://api.github.com/users/werkt/following{/other_user}","gists_url":"https://api.github.com/users/werkt/gists{/gist_id}","starred_url":"https://api.github.com/users/werkt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/werkt/subscriptions","organizations_url":"https://api.github.com/users/werkt/orgs","repos_url":"https://api.github.com/users/werkt/repos","events_url":"https://api.github.com/users/werkt/events{/privacy}","received_events_url":"https://api.github.com/users/werkt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/werkt/knex","description":"A query builder for PostgreSQL, MySQL and SQLite3, designed to be flexible, portable, and fun to use.","fork":true,"url":"https://api.github.com/repos/werkt/knex","forks_url":"https://api.github.com/repos/werkt/knex/forks","keys_url":"https://api.github.com/repos/werkt/knex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/werkt/knex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/werkt/knex/teams","hooks_url":"https://api.github.com/repos/werkt/knex/hooks","issue_events_url":"https://api.github.com/repos/werkt/knex/issues/events{/number}","events_url":"https://api.github.com/repos/werkt/knex/events","assignees_url":"https://api.github.com/repos/werkt/knex/assignees{/user}","branches_url":"https://api.github.com/repos/werkt/knex/branches{/branch}","tags_url":"https://api.github.com/repos/werkt/knex/tags","blobs_url":"https://api.github.com/repos/werkt/knex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/werkt/knex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/werkt/knex/git/refs{/sha}","trees_url":"https://api.github.com/repos/werkt/knex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/werkt/knex/statuses/{sha}","languages_url":"https://api.github.com/repos/werkt/knex/languages","stargazers_url":"https://api.github.com/repos/werkt/knex/stargazers","contributors_url":"https://api.github.com/repos/werkt/knex/contributors","subscribers_url":"https://api.github.com/repos/werkt/knex/subscribers","subscription_url":"https://api.github.com/repos/werkt/knex/subscription","commits_url":"https://api.github.com/repos/werkt/knex/commits{/sha}","git_commits_url":"https://api.github.com/repos/werkt/knex/git/commits{/sha}","comments_url":"https://api.github.com/repos/werkt/knex/comments{/number}","issue_comment_url":"https://api.github.com/repos/werkt/knex/issues/comments/{number}","contents_url":"https://api.github.com/repos/werkt/knex/contents/{+path}","compare_url":"https://api.github.com/repos/werkt/knex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/werkt/knex/merges","archive_url":"https://api.github.com/repos/werkt/knex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/werkt/knex/downloads","issues_url":"https://api.github.com/repos/werkt/knex/issues{/number}","pulls_url":"https://api.github.com/repos/werkt/knex/pulls{/number}","milestones_url":"https://api.github.com/repos/werkt/knex/milestones{/number}","notifications_url":"https://api.github.com/repos/werkt/knex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/werkt/knex/labels{/name}","releases_url":"https://api.github.com/repos/werkt/knex/releases{/id}","created_at":"2015-02-03T17:37:44Z","updated_at":"2015-02-03T17:37:45Z","pushed_at":"2015-02-03T17:39:17Z","git_url":"git://github.com/werkt/knex.git","ssh_url":"git@github.com:werkt/knex.git","clone_url":"https://github.com/werkt/knex.git","svn_url":"https://github.com/werkt/knex","homepage":"knexjs.org","size":7276,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tgriesser:master","ref":"master","sha":"8c8fcb5b293ae6cfc4f587aea200e005693590eb","user":{"login":"tgriesser","id":154748,"avatar_url":"https://avatars.githubusercontent.com/u/154748?v=3","gravatar_id":"","url":"https://api.github.com/users/tgriesser","html_url":"https://github.com/tgriesser","followers_url":"https://api.github.com/users/tgriesser/followers","following_url":"https://api.github.com/users/tgriesser/following{/other_user}","gists_url":"https://api.github.com/users/tgriesser/gists{/gist_id}","starred_url":"https://api.github.com/users/tgriesser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgriesser/subscriptions","organizations_url":"https://api.github.com/users/tgriesser/orgs","repos_url":"https://api.github.com/users/tgriesser/repos","events_url":"https://api.github.com/users/tgriesser/events{/privacy}","received_events_url":"https://api.github.com/users/tgriesser/received_events","type":"User","site_admin":false},"repo":{"id":7363211,"name":"knex","full_name":"tgriesser/knex","owner":{"login":"tgriesser","id":154748,"avatar_url":"https://avatars.githubusercontent.com/u/154748?v=3","gravatar_id":"","url":"https://api.github.com/users/tgriesser","html_url":"https://github.com/tgriesser","followers_url":"https://api.github.com/users/tgriesser/followers","following_url":"https://api.github.com/users/tgriesser/following{/other_user}","gists_url":"https://api.github.com/users/tgriesser/gists{/gist_id}","starred_url":"https://api.github.com/users/tgriesser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgriesser/subscriptions","organizations_url":"https://api.github.com/users/tgriesser/orgs","repos_url":"https://api.github.com/users/tgriesser/repos","events_url":"https://api.github.com/users/tgriesser/events{/privacy}","received_events_url":"https://api.github.com/users/tgriesser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tgriesser/knex","description":"A query builder for PostgreSQL, MySQL and SQLite3, designed to be flexible, portable, and fun to use.","fork":false,"url":"https://api.github.com/repos/tgriesser/knex","forks_url":"https://api.github.com/repos/tgriesser/knex/forks","keys_url":"https://api.github.com/repos/tgriesser/knex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tgriesser/knex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tgriesser/knex/teams","hooks_url":"https://api.github.com/repos/tgriesser/knex/hooks","issue_events_url":"https://api.github.com/repos/tgriesser/knex/issues/events{/number}","events_url":"https://api.github.com/repos/tgriesser/knex/events","assignees_url":"https://api.github.com/repos/tgriesser/knex/assignees{/user}","branches_url":"https://api.github.com/repos/tgriesser/knex/branches{/branch}","tags_url":"https://api.github.com/repos/tgriesser/knex/tags","blobs_url":"https://api.github.com/repos/tgriesser/knex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tgriesser/knex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tgriesser/knex/git/refs{/sha}","trees_url":"https://api.github.com/repos/tgriesser/knex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tgriesser/knex/statuses/{sha}","languages_url":"https://api.github.com/repos/tgriesser/knex/languages","stargazers_url":"https://api.github.com/repos/tgriesser/knex/stargazers","contributors_url":"https://api.github.com/repos/tgriesser/knex/contributors","subscribers_url":"https://api.github.com/repos/tgriesser/knex/subscribers","subscription_url":"https://api.github.com/repos/tgriesser/knex/subscription","commits_url":"https://api.github.com/repos/tgriesser/knex/commits{/sha}","git_commits_url":"https://api.github.com/repos/tgriesser/knex/git/commits{/sha}","comments_url":"https://api.github.com/repos/tgriesser/knex/comments{/number}","issue_comment_url":"https://api.github.com/repos/tgriesser/knex/issues/comments/{number}","contents_url":"https://api.github.com/repos/tgriesser/knex/contents/{+path}","compare_url":"https://api.github.com/repos/tgriesser/knex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tgriesser/knex/merges","archive_url":"https://api.github.com/repos/tgriesser/knex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tgriesser/knex/downloads","issues_url":"https://api.github.com/repos/tgriesser/knex/issues{/number}","pulls_url":"https://api.github.com/repos/tgriesser/knex/pulls{/number}","milestones_url":"https://api.github.com/repos/tgriesser/knex/milestones{/number}","notifications_url":"https://api.github.com/repos/tgriesser/knex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tgriesser/knex/labels{/name}","releases_url":"https://api.github.com/repos/tgriesser/knex/releases{/id}","created_at":"2012-12-29T05:18:25Z","updated_at":"2015-02-03T10:46:37Z","pushed_at":"2015-01-31T00:38:51Z","git_url":"git://github.com/tgriesser/knex.git","ssh_url":"git@github.com:tgriesser/knex.git","clone_url":"https://github.com/tgriesser/knex.git","svn_url":"https://github.com/tgriesser/knex","homepage":"knexjs.org","size":7276,"stargazers_count":1111,"watchers_count":1111,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":163,"mirror_url":null,"open_issues_count":112,"forks":163,"open_issues":112,"watchers":1111,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tgriesser/knex/pulls/660"},"html":{"href":"https://github.com/tgriesser/knex/pull/660"},"issue":{"href":"https://api.github.com/repos/tgriesser/knex/issues/660"},"comments":{"href":"https://api.github.com/repos/tgriesser/knex/issues/660/comments"},"review_comments":{"href":"https://api.github.com/repos/tgriesser/knex/pulls/660/comments"},"review_comment":{"href":"https://api.github.com/repos/tgriesser/knex/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/tgriesser/knex/pulls/660/commits"},"statuses":{"href":"https://api.github.com/repos/tgriesser/knex/statuses/f6952c42b5798ea467fc05529eefa54ccdc76b93"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":42,"deletions":15,"changed_files":3}}