{"action":"created","comment":{"url":"https://api.github.com/repos/akka/akka/pulls/comments/35118806","id":35118806,"diff_hunk":"@@ -66,3 +68,72 @@ private[akka] final class OutputStreamSink(createOutput: () ⇒ OutputStream, va\n   override def withAttributes(attr: Attributes): Module =\n     new OutputStreamSink(createOutput, attr, amendShape(attr))\n }\n+\n+/**\n+ * INTERNAL API\n+ * Creates simple synchronous (Java 6 compatible) Sink which provide all incoming element on read request via\n+ * InputStream.\n+ */\n+private[akka] final class InputStreamSink(val timeout: FiniteDuration, val attributes: Attributes, shape: SinkShape[ByteString])\n+  extends SinkModule[ByteString, (InputStream, Future[Long])](shape) {\n+\n+  override def create(context: MaterializationContext) = {\n+    val mat = ActorMaterializer.downcast(context.materializer)\n+    val settings = mat.effectiveSettings(context.effectiveAttributes)\n+    val bytesWrittenPromise = Promise[Long]()\n+\n+    val props = InputStreamSubscriber.props(bytesWrittenPromise, settings.maxInputBufferSize)\n+\n+    val ref = mat.actorOf(context, props)\n+    (akka.stream.actor.ActorSubscriber[ByteString](ref),\n+      (new InputStreamAdapter(ref, timeout).asInstanceOf[InputStream], bytesWrittenPromise.future))\n+  }\n+\n+  override protected def newInstance(shape: SinkShape[ByteString]): SinkModule[ByteString, (InputStream, Future[Long])] =\n+","path":"akka-stream/src/main/scala/akka/stream/impl/io/IOSinks.scala","position":47,"original_position":47,"commit_id":"e9180f243c514583eacafd2b7b4112aee80f50d5","original_commit_id":"e9180f243c514583eacafd2b7b4112aee80f50d5","user":{"login":"ktoso","id":120979,"avatar_url":"https://avatars.githubusercontent.com/u/120979?v=3","gravatar_id":"","url":"https://api.github.com/users/ktoso","html_url":"https://github.com/ktoso","followers_url":"https://api.github.com/users/ktoso/followers","following_url":"https://api.github.com/users/ktoso/following{/other_user}","gists_url":"https://api.github.com/users/ktoso/gists{/gist_id}","starred_url":"https://api.github.com/users/ktoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktoso/subscriptions","organizations_url":"https://api.github.com/users/ktoso/orgs","repos_url":"https://api.github.com/users/ktoso/repos","events_url":"https://api.github.com/users/ktoso/events{/privacy}","received_events_url":"https://api.github.com/users/ktoso/received_events","type":"User","site_admin":false},"body":"remove this additional newline","created_at":"2015-07-21T15:52:49Z","updated_at":"2015-07-21T15:52:49Z","html_url":"https://github.com/akka/akka/pull/17995#discussion_r35118806","pull_request_url":"https://api.github.com/repos/akka/akka/pulls/17995","_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/comments/35118806"},"html":{"href":"https://github.com/akka/akka/pull/17995#discussion_r35118806"},"pull_request":{"href":"https://api.github.com/repos/akka/akka/pulls/17995"}}},"pull_request":{"url":"https://api.github.com/repos/akka/akka/pulls/17995","id":39984886,"html_url":"https://github.com/akka/akka/pull/17995","diff_url":"https://github.com/akka/akka/pull/17995.diff","patch_url":"https://github.com/akka/akka/pull/17995.patch","issue_url":"https://api.github.com/repos/akka/akka/issues/17995","number":17995,"state":"open","locked":false,"title":"+str #17338 add OutputStreamSource and InputStreamSink ","user":{"login":"agolubev","id":461456,"avatar_url":"https://avatars.githubusercontent.com/u/461456?v=3","gravatar_id":"","url":"https://api.github.com/users/agolubev","html_url":"https://github.com/agolubev","followers_url":"https://api.github.com/users/agolubev/followers","following_url":"https://api.github.com/users/agolubev/following{/other_user}","gists_url":"https://api.github.com/users/agolubev/gists{/gist_id}","starred_url":"https://api.github.com/users/agolubev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agolubev/subscriptions","organizations_url":"https://api.github.com/users/agolubev/orgs","repos_url":"https://api.github.com/users/agolubev/repos","events_url":"https://api.github.com/users/agolubev/events{/privacy}","received_events_url":"https://api.github.com/users/agolubev/received_events","type":"User","site_admin":false},"body":"added OutputStreamSource only so far. Tests show main cases and flush blocking. \r\nLet me know if implementation approach is Ok to proceed with InputStreamSink","created_at":"2015-07-15T03:20:33Z","updated_at":"2015-07-21T15:52:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4ccfee912045a048f3cadeab3c16243fcc6e896","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/akka/akka/pulls/17995/commits","review_comments_url":"https://api.github.com/repos/akka/akka/pulls/17995/comments","review_comment_url":"https://api.github.com/repos/akka/akka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akka/akka/issues/17995/comments","statuses_url":"https://api.github.com/repos/akka/akka/statuses/e9180f243c514583eacafd2b7b4112aee80f50d5","head":{"label":"agolubev:agolubev-#17338_add_OutputStreamSource_and_InputStreamSink","ref":"agolubev-#17338_add_OutputStreamSource_and_InputStreamSink","sha":"e9180f243c514583eacafd2b7b4112aee80f50d5","user":{"login":"agolubev","id":461456,"avatar_url":"https://avatars.githubusercontent.com/u/461456?v=3","gravatar_id":"","url":"https://api.github.com/users/agolubev","html_url":"https://github.com/agolubev","followers_url":"https://api.github.com/users/agolubev/followers","following_url":"https://api.github.com/users/agolubev/following{/other_user}","gists_url":"https://api.github.com/users/agolubev/gists{/gist_id}","starred_url":"https://api.github.com/users/agolubev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agolubev/subscriptions","organizations_url":"https://api.github.com/users/agolubev/orgs","repos_url":"https://api.github.com/users/agolubev/repos","events_url":"https://api.github.com/users/agolubev/events{/privacy}","received_events_url":"https://api.github.com/users/agolubev/received_events","type":"User","site_admin":false},"repo":{"id":35570392,"name":"akka","full_name":"agolubev/akka","owner":{"login":"agolubev","id":461456,"avatar_url":"https://avatars.githubusercontent.com/u/461456?v=3","gravatar_id":"","url":"https://api.github.com/users/agolubev","html_url":"https://github.com/agolubev","followers_url":"https://api.github.com/users/agolubev/followers","following_url":"https://api.github.com/users/agolubev/following{/other_user}","gists_url":"https://api.github.com/users/agolubev/gists{/gist_id}","starred_url":"https://api.github.com/users/agolubev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agolubev/subscriptions","organizations_url":"https://api.github.com/users/agolubev/orgs","repos_url":"https://api.github.com/users/agolubev/repos","events_url":"https://api.github.com/users/agolubev/events{/privacy}","received_events_url":"https://api.github.com/users/agolubev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/agolubev/akka","description":"Akka Project","fork":true,"url":"https://api.github.com/repos/agolubev/akka","forks_url":"https://api.github.com/repos/agolubev/akka/forks","keys_url":"https://api.github.com/repos/agolubev/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agolubev/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agolubev/akka/teams","hooks_url":"https://api.github.com/repos/agolubev/akka/hooks","issue_events_url":"https://api.github.com/repos/agolubev/akka/issues/events{/number}","events_url":"https://api.github.com/repos/agolubev/akka/events","assignees_url":"https://api.github.com/repos/agolubev/akka/assignees{/user}","branches_url":"https://api.github.com/repos/agolubev/akka/branches{/branch}","tags_url":"https://api.github.com/repos/agolubev/akka/tags","blobs_url":"https://api.github.com/repos/agolubev/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agolubev/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agolubev/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/agolubev/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agolubev/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/agolubev/akka/languages","stargazers_url":"https://api.github.com/repos/agolubev/akka/stargazers","contributors_url":"https://api.github.com/repos/agolubev/akka/contributors","subscribers_url":"https://api.github.com/repos/agolubev/akka/subscribers","subscription_url":"https://api.github.com/repos/agolubev/akka/subscription","commits_url":"https://api.github.com/repos/agolubev/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/agolubev/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/agolubev/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/agolubev/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/agolubev/akka/contents/{+path}","compare_url":"https://api.github.com/repos/agolubev/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agolubev/akka/merges","archive_url":"https://api.github.com/repos/agolubev/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agolubev/akka/downloads","issues_url":"https://api.github.com/repos/agolubev/akka/issues{/number}","pulls_url":"https://api.github.com/repos/agolubev/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/agolubev/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/agolubev/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agolubev/akka/labels{/name}","releases_url":"https://api.github.com/repos/agolubev/akka/releases{/id}","created_at":"2015-05-13T19:39:33Z","updated_at":"2015-05-13T19:39:39Z","pushed_at":"2015-07-21T15:09:08Z","git_url":"git://github.com/agolubev/akka.git","ssh_url":"git@github.com:agolubev/akka.git","clone_url":"https://github.com/agolubev/akka.git","svn_url":"https://github.com/agolubev/akka","homepage":"http://akka.io","size":164901,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"akka:release-2.3-dev","ref":"release-2.3-dev","sha":"f7f2de7afe5d758ff2b32319d56a6d6028fb06f4","user":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":130013,"name":"akka","full_name":"akka/akka","owner":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akka/akka","description":"Akka Project","fork":false,"url":"https://api.github.com/repos/akka/akka","forks_url":"https://api.github.com/repos/akka/akka/forks","keys_url":"https://api.github.com/repos/akka/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka/teams","hooks_url":"https://api.github.com/repos/akka/akka/hooks","issue_events_url":"https://api.github.com/repos/akka/akka/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka/events","assignees_url":"https://api.github.com/repos/akka/akka/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka/tags","blobs_url":"https://api.github.com/repos/akka/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka/languages","stargazers_url":"https://api.github.com/repos/akka/akka/stargazers","contributors_url":"https://api.github.com/repos/akka/akka/contributors","subscribers_url":"https://api.github.com/repos/akka/akka/subscribers","subscription_url":"https://api.github.com/repos/akka/akka/subscription","commits_url":"https://api.github.com/repos/akka/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/akka/akka/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka/merges","archive_url":"https://api.github.com/repos/akka/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka/downloads","issues_url":"https://api.github.com/repos/akka/akka/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka/releases{/id}","created_at":"2009-02-16T12:51:54Z","updated_at":"2015-07-21T11:47:15Z","pushed_at":"2015-07-21T12:29:02Z","git_url":"git://github.com/akka/akka.git","ssh_url":"git@github.com:akka/akka.git","clone_url":"https://github.com/akka/akka.git","svn_url":"https://github.com/akka/akka","homepage":"http://akka.io","size":264070,"stargazers_count":4232,"watchers_count":4232,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1240,"mirror_url":null,"open_issues_count":684,"forks":1240,"open_issues":684,"watchers":4232,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/17995"},"html":{"href":"https://github.com/akka/akka/pull/17995"},"issue":{"href":"https://api.github.com/repos/akka/akka/issues/17995"},"comments":{"href":"https://api.github.com/repos/akka/akka/issues/17995/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/akka/pulls/17995/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/akka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akka/akka/pulls/17995/commits"},"statuses":{"href":"https://api.github.com/repos/akka/akka/statuses/e9180f243c514583eacafd2b7b4112aee80f50d5"}}}}