{"action":"created","comment":{"url":"https://api.github.com/repos/enyojs/layout/pulls/comments/38373512","id":38373512,"diff_hunk":"@@ -191,6 +191,7 @@ module.exports = kind(\n \t* @private\n \t*/\n \timageSizingChanged: function () {\n+\t\tthis.$.image.addRemoveClass('enyo-gridlist-imageitem-image', (!this.imageSizing && !!this.placeholder));","path":"lib/GridListImageItem/GridListImageItem.js","position":4,"original_position":4,"commit_id":"2ba26dea2bd214fca47fcb843e122da2bd613e55","original_commit_id":"2ba26dea2bd214fca47fcb843e122da2bd613e55","user":{"login":"aarontam","id":463191,"avatar_url":"https://avatars.githubusercontent.com/u/463191?v=3","gravatar_id":"","url":"https://api.github.com/users/aarontam","html_url":"https://github.com/aarontam","followers_url":"https://api.github.com/users/aarontam/followers","following_url":"https://api.github.com/users/aarontam/following{/other_user}","gists_url":"https://api.github.com/users/aarontam/gists{/gist_id}","starred_url":"https://api.github.com/users/aarontam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aarontam/subscriptions","organizations_url":"https://api.github.com/users/aarontam/orgs","repos_url":"https://api.github.com/users/aarontam/repos","events_url":"https://api.github.com/users/aarontam/events{/privacy}","received_events_url":"https://api.github.com/users/aarontam/received_events","type":"User","site_admin":false},"body":"Hi @rajyavardhanp, if you take a look here, you will see that we were not intending to allow the image to have a natural size: https://github.com/enyojs/layout/blob/2.6.0-dev/src/GridListImageItem/GridListImageItem.css#L13.","created_at":"2015-08-31T23:52:52Z","updated_at":"2015-08-31T23:52:52Z","html_url":"https://github.com/enyojs/layout/pull/137#discussion_r38373512","pull_request_url":"https://api.github.com/repos/enyojs/layout/pulls/137","_links":{"self":{"href":"https://api.github.com/repos/enyojs/layout/pulls/comments/38373512"},"html":{"href":"https://github.com/enyojs/layout/pull/137#discussion_r38373512"},"pull_request":{"href":"https://api.github.com/repos/enyojs/layout/pulls/137"}}},"pull_request":{"url":"https://api.github.com/repos/enyojs/layout/pulls/137","id":42675069,"html_url":"https://github.com/enyojs/layout/pull/137","diff_url":"https://github.com/enyojs/layout/pull/137.diff","patch_url":"https://github.com/enyojs/layout/pull/137.patch","issue_url":"https://api.github.com/repos/enyojs/layout/issues/137","number":137,"state":"closed","locked":false,"title":"ENYO-2313-Place holder is not shown while images are loading in DataG…","user":{"login":"rajyavardhanp","id":5196608,"avatar_url":"https://avatars.githubusercontent.com/u/5196608?v=3","gravatar_id":"","url":"https://api.github.com/users/rajyavardhanp","html_url":"https://github.com/rajyavardhanp","followers_url":"https://api.github.com/users/rajyavardhanp/followers","following_url":"https://api.github.com/users/rajyavardhanp/following{/other_user}","gists_url":"https://api.github.com/users/rajyavardhanp/gists{/gist_id}","starred_url":"https://api.github.com/users/rajyavardhanp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajyavardhanp/subscriptions","organizations_url":"https://api.github.com/users/rajyavardhanp/orgs","repos_url":"https://api.github.com/users/rajyavardhanp/repos","events_url":"https://api.github.com/users/rajyavardhanp/events{/privacy}","received_events_url":"https://api.github.com/users/rajyavardhanp/received_events","type":"User","site_admin":false},"body":"…ridListSample\r\n\r\nIssue: Placeholder is the background of image (in this case) And image\r\ndoesn't have predefined width and height.\r\nIf the image doesn't load there is no way placeholder can have bounds.\r\nFix:  In layout/DatagridListImageItem, a class that has width n height\r\n100% is added on 'image' control on condition (this.sizing) based.\r\nEnyo-DCO-1.1-Signed-off-by:  Rajyavardhan P <rajyavardhan.p@lge.com>","created_at":"2015-08-18T08:54:38Z","updated_at":"2015-08-31T23:52:52Z","closed_at":"2015-08-21T23:11:11Z","merged_at":null,"merge_commit_sha":"6bb6fd1f8cddb20e5b0c738d37a2a8b2e10be81b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/enyojs/layout/pulls/137/commits","review_comments_url":"https://api.github.com/repos/enyojs/layout/pulls/137/comments","review_comment_url":"https://api.github.com/repos/enyojs/layout/pulls/comments{/number}","comments_url":"https://api.github.com/repos/enyojs/layout/issues/137/comments","statuses_url":"https://api.github.com/repos/enyojs/layout/statuses/2ba26dea2bd214fca47fcb843e122da2bd613e55","head":{"label":"enyojs:ENYO-2313-rajyavardhanp","ref":"ENYO-2313-rajyavardhanp","sha":"2ba26dea2bd214fca47fcb843e122da2bd613e55","user":{"login":"enyojs","id":1266337,"avatar_url":"https://avatars.githubusercontent.com/u/1266337?v=3","gravatar_id":"","url":"https://api.github.com/users/enyojs","html_url":"https://github.com/enyojs","followers_url":"https://api.github.com/users/enyojs/followers","following_url":"https://api.github.com/users/enyojs/following{/other_user}","gists_url":"https://api.github.com/users/enyojs/gists{/gist_id}","starred_url":"https://api.github.com/users/enyojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enyojs/subscriptions","organizations_url":"https://api.github.com/users/enyojs/orgs","repos_url":"https://api.github.com/users/enyojs/repos","events_url":"https://api.github.com/users/enyojs/events{/privacy}","received_events_url":"https://api.github.com/users/enyojs/received_events","type":"Organization","site_admin":false},"repo":{"id":8061733,"name":"layout","full_name":"enyojs/layout","owner":{"login":"enyojs","id":1266337,"avatar_url":"https://avatars.githubusercontent.com/u/1266337?v=3","gravatar_id":"","url":"https://api.github.com/users/enyojs","html_url":"https://github.com/enyojs","followers_url":"https://api.github.com/users/enyojs/followers","following_url":"https://api.github.com/users/enyojs/following{/other_user}","gists_url":"https://api.github.com/users/enyojs/gists{/gist_id}","starred_url":"https://api.github.com/users/enyojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enyojs/subscriptions","organizations_url":"https://api.github.com/users/enyojs/orgs","repos_url":"https://api.github.com/users/enyojs/repos","events_url":"https://api.github.com/users/enyojs/events{/privacy}","received_events_url":"https://api.github.com/users/enyojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enyojs/layout","description":"UI infrastructure for Enyo applications","fork":false,"url":"https://api.github.com/repos/enyojs/layout","forks_url":"https://api.github.com/repos/enyojs/layout/forks","keys_url":"https://api.github.com/repos/enyojs/layout/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enyojs/layout/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enyojs/layout/teams","hooks_url":"https://api.github.com/repos/enyojs/layout/hooks","issue_events_url":"https://api.github.com/repos/enyojs/layout/issues/events{/number}","events_url":"https://api.github.com/repos/enyojs/layout/events","assignees_url":"https://api.github.com/repos/enyojs/layout/assignees{/user}","branches_url":"https://api.github.com/repos/enyojs/layout/branches{/branch}","tags_url":"https://api.github.com/repos/enyojs/layout/tags","blobs_url":"https://api.github.com/repos/enyojs/layout/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enyojs/layout/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enyojs/layout/git/refs{/sha}","trees_url":"https://api.github.com/repos/enyojs/layout/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enyojs/layout/statuses/{sha}","languages_url":"https://api.github.com/repos/enyojs/layout/languages","stargazers_url":"https://api.github.com/repos/enyojs/layout/stargazers","contributors_url":"https://api.github.com/repos/enyojs/layout/contributors","subscribers_url":"https://api.github.com/repos/enyojs/layout/subscribers","subscription_url":"https://api.github.com/repos/enyojs/layout/subscription","commits_url":"https://api.github.com/repos/enyojs/layout/commits{/sha}","git_commits_url":"https://api.github.com/repos/enyojs/layout/git/commits{/sha}","comments_url":"https://api.github.com/repos/enyojs/layout/comments{/number}","issue_comment_url":"https://api.github.com/repos/enyojs/layout/issues/comments{/number}","contents_url":"https://api.github.com/repos/enyojs/layout/contents/{+path}","compare_url":"https://api.github.com/repos/enyojs/layout/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enyojs/layout/merges","archive_url":"https://api.github.com/repos/enyojs/layout/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enyojs/layout/downloads","issues_url":"https://api.github.com/repos/enyojs/layout/issues{/number}","pulls_url":"https://api.github.com/repos/enyojs/layout/pulls{/number}","milestones_url":"https://api.github.com/repos/enyojs/layout/milestones{/number}","notifications_url":"https://api.github.com/repos/enyojs/layout/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enyojs/layout/labels{/name}","releases_url":"https://api.github.com/repos/enyojs/layout/releases{/id}","created_at":"2013-02-06T22:34:34Z","updated_at":"2015-06-12T20:08:40Z","pushed_at":"2015-08-31T10:43:24Z","git_url":"git://github.com/enyojs/layout.git","ssh_url":"git@github.com:enyojs/layout.git","clone_url":"https://github.com/enyojs/layout.git","svn_url":"https://github.com/enyojs/layout","homepage":"","size":8998,"stargazers_count":18,"watchers_count":18,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":5,"forks":30,"open_issues":5,"watchers":18,"default_branch":"master"}},"base":{"label":"enyojs:2.6.0-dev","ref":"2.6.0-dev","sha":"f52984f1a29c383636c0c4561d07a29bcdd9d7e8","user":{"login":"enyojs","id":1266337,"avatar_url":"https://avatars.githubusercontent.com/u/1266337?v=3","gravatar_id":"","url":"https://api.github.com/users/enyojs","html_url":"https://github.com/enyojs","followers_url":"https://api.github.com/users/enyojs/followers","following_url":"https://api.github.com/users/enyojs/following{/other_user}","gists_url":"https://api.github.com/users/enyojs/gists{/gist_id}","starred_url":"https://api.github.com/users/enyojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enyojs/subscriptions","organizations_url":"https://api.github.com/users/enyojs/orgs","repos_url":"https://api.github.com/users/enyojs/repos","events_url":"https://api.github.com/users/enyojs/events{/privacy}","received_events_url":"https://api.github.com/users/enyojs/received_events","type":"Organization","site_admin":false},"repo":{"id":8061733,"name":"layout","full_name":"enyojs/layout","owner":{"login":"enyojs","id":1266337,"avatar_url":"https://avatars.githubusercontent.com/u/1266337?v=3","gravatar_id":"","url":"https://api.github.com/users/enyojs","html_url":"https://github.com/enyojs","followers_url":"https://api.github.com/users/enyojs/followers","following_url":"https://api.github.com/users/enyojs/following{/other_user}","gists_url":"https://api.github.com/users/enyojs/gists{/gist_id}","starred_url":"https://api.github.com/users/enyojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enyojs/subscriptions","organizations_url":"https://api.github.com/users/enyojs/orgs","repos_url":"https://api.github.com/users/enyojs/repos","events_url":"https://api.github.com/users/enyojs/events{/privacy}","received_events_url":"https://api.github.com/users/enyojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enyojs/layout","description":"UI infrastructure for Enyo applications","fork":false,"url":"https://api.github.com/repos/enyojs/layout","forks_url":"https://api.github.com/repos/enyojs/layout/forks","keys_url":"https://api.github.com/repos/enyojs/layout/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enyojs/layout/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enyojs/layout/teams","hooks_url":"https://api.github.com/repos/enyojs/layout/hooks","issue_events_url":"https://api.github.com/repos/enyojs/layout/issues/events{/number}","events_url":"https://api.github.com/repos/enyojs/layout/events","assignees_url":"https://api.github.com/repos/enyojs/layout/assignees{/user}","branches_url":"https://api.github.com/repos/enyojs/layout/branches{/branch}","tags_url":"https://api.github.com/repos/enyojs/layout/tags","blobs_url":"https://api.github.com/repos/enyojs/layout/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enyojs/layout/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enyojs/layout/git/refs{/sha}","trees_url":"https://api.github.com/repos/enyojs/layout/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enyojs/layout/statuses/{sha}","languages_url":"https://api.github.com/repos/enyojs/layout/languages","stargazers_url":"https://api.github.com/repos/enyojs/layout/stargazers","contributors_url":"https://api.github.com/repos/enyojs/layout/contributors","subscribers_url":"https://api.github.com/repos/enyojs/layout/subscribers","subscription_url":"https://api.github.com/repos/enyojs/layout/subscription","commits_url":"https://api.github.com/repos/enyojs/layout/commits{/sha}","git_commits_url":"https://api.github.com/repos/enyojs/layout/git/commits{/sha}","comments_url":"https://api.github.com/repos/enyojs/layout/comments{/number}","issue_comment_url":"https://api.github.com/repos/enyojs/layout/issues/comments{/number}","contents_url":"https://api.github.com/repos/enyojs/layout/contents/{+path}","compare_url":"https://api.github.com/repos/enyojs/layout/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enyojs/layout/merges","archive_url":"https://api.github.com/repos/enyojs/layout/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enyojs/layout/downloads","issues_url":"https://api.github.com/repos/enyojs/layout/issues{/number}","pulls_url":"https://api.github.com/repos/enyojs/layout/pulls{/number}","milestones_url":"https://api.github.com/repos/enyojs/layout/milestones{/number}","notifications_url":"https://api.github.com/repos/enyojs/layout/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enyojs/layout/labels{/name}","releases_url":"https://api.github.com/repos/enyojs/layout/releases{/id}","created_at":"2013-02-06T22:34:34Z","updated_at":"2015-06-12T20:08:40Z","pushed_at":"2015-08-31T10:43:24Z","git_url":"git://github.com/enyojs/layout.git","ssh_url":"git@github.com:enyojs/layout.git","clone_url":"https://github.com/enyojs/layout.git","svn_url":"https://github.com/enyojs/layout","homepage":"","size":8998,"stargazers_count":18,"watchers_count":18,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":5,"forks":30,"open_issues":5,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/enyojs/layout/pulls/137"},"html":{"href":"https://github.com/enyojs/layout/pull/137"},"issue":{"href":"https://api.github.com/repos/enyojs/layout/issues/137"},"comments":{"href":"https://api.github.com/repos/enyojs/layout/issues/137/comments"},"review_comments":{"href":"https://api.github.com/repos/enyojs/layout/pulls/137/comments"},"review_comment":{"href":"https://api.github.com/repos/enyojs/layout/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/enyojs/layout/pulls/137/commits"},"statuses":{"href":"https://api.github.com/repos/enyojs/layout/statuses/2ba26dea2bd214fca47fcb843e122da2bd613e55"}}}}