{"action":"created","comment":{"url":"https://api.github.com/repos/projectcalico/libcalico/pulls/comments/40460860","id":40460860,"diff_hunk":"@@ -322,7 +322,7 @@ def _compare_and_swap_handle(self, handle):\n                 _log.debug(\"Handle %s is not empty.\", handle.handle_id)\n                 try:\n                     self.etcd_client.update(handle.update_result())\n-                except ValueError:\n+                except EtcdCompareFailed:\n                     raise CASError(handle.handle_id)\n         else:\n             _log.debug(\"CAS Write new handle %s\", handle.handle_id)","path":"calico_containers/pycalico/ipam.py","position":26,"original_position":26,"commit_id":"22d4d157a293e246e65847ba461956f6ad22f87f","original_commit_id":"22d4d157a293e246e65847ba461956f6ad22f87f","user":{"login":"caseydavenport","id":1944093,"avatar_url":"https://avatars.githubusercontent.com/u/1944093?v=3","gravatar_id":"","url":"https://api.github.com/users/caseydavenport","html_url":"https://github.com/caseydavenport","followers_url":"https://api.github.com/users/caseydavenport/followers","following_url":"https://api.github.com/users/caseydavenport/following{/other_user}","gists_url":"https://api.github.com/users/caseydavenport/gists{/gist_id}","starred_url":"https://api.github.com/users/caseydavenport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caseydavenport/subscriptions","organizations_url":"https://api.github.com/users/caseydavenport/orgs","repos_url":"https://api.github.com/users/caseydavenport/repos","events_url":"https://api.github.com/users/caseydavenport/events{/privacy}","received_events_url":"https://api.github.com/users/caseydavenport/received_events","type":"User","site_admin":false},"body":"Will write(...) throw an EtcdCompareFailed?  Do we need to catch it below?","created_at":"2015-09-25T18:28:13Z","updated_at":"2015-09-25T18:28:13Z","html_url":"https://github.com/projectcalico/libcalico/pull/24#discussion_r40460860","pull_request_url":"https://api.github.com/repos/projectcalico/libcalico/pulls/24","_links":{"self":{"href":"https://api.github.com/repos/projectcalico/libcalico/pulls/comments/40460860"},"html":{"href":"https://github.com/projectcalico/libcalico/pull/24#discussion_r40460860"},"pull_request":{"href":"https://api.github.com/repos/projectcalico/libcalico/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/projectcalico/libcalico/pulls/24","id":46035681,"html_url":"https://github.com/projectcalico/libcalico/pull/24","diff_url":"https://github.com/projectcalico/libcalico/pull/24.diff","patch_url":"https://github.com/projectcalico/libcalico/pull/24.patch","issue_url":"https://api.github.com/repos/projectcalico/libcalico/issues/24","number":24,"state":"open","locked":false,"title":"Raise EtcdValueErrors on CAS errors","user":{"login":"alexhersh","id":3424115,"avatar_url":"https://avatars.githubusercontent.com/u/3424115?v=3","gravatar_id":"","url":"https://api.github.com/users/alexhersh","html_url":"https://github.com/alexhersh","followers_url":"https://api.github.com/users/alexhersh/followers","following_url":"https://api.github.com/users/alexhersh/following{/other_user}","gists_url":"https://api.github.com/users/alexhersh/gists{/gist_id}","starred_url":"https://api.github.com/users/alexhersh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexhersh/subscriptions","organizations_url":"https://api.github.com/users/alexhersh/orgs","repos_url":"https://api.github.com/users/alexhersh/repos","events_url":"https://api.github.com/users/alexhersh/events{/privacy}","received_events_url":"https://api.github.com/users/alexhersh/received_events","type":"User","site_admin":false},"body":"Narrow Exceptions to etcd specific handlers.","created_at":"2015-09-25T17:15:21Z","updated_at":"2015-09-25T18:28:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad753aa49182fbf29f7679d87185a3999d9af44d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/projectcalico/libcalico/pulls/24/commits","review_comments_url":"https://api.github.com/repos/projectcalico/libcalico/pulls/24/comments","review_comment_url":"https://api.github.com/repos/projectcalico/libcalico/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectcalico/libcalico/issues/24/comments","statuses_url":"https://api.github.com/repos/projectcalico/libcalico/statuses/22d4d157a293e246e65847ba461956f6ad22f87f","head":{"label":"alexhersh:CASexcept","ref":"CASexcept","sha":"22d4d157a293e246e65847ba461956f6ad22f87f","user":{"login":"alexhersh","id":3424115,"avatar_url":"https://avatars.githubusercontent.com/u/3424115?v=3","gravatar_id":"","url":"https://api.github.com/users/alexhersh","html_url":"https://github.com/alexhersh","followers_url":"https://api.github.com/users/alexhersh/followers","following_url":"https://api.github.com/users/alexhersh/following{/other_user}","gists_url":"https://api.github.com/users/alexhersh/gists{/gist_id}","starred_url":"https://api.github.com/users/alexhersh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexhersh/subscriptions","organizations_url":"https://api.github.com/users/alexhersh/orgs","repos_url":"https://api.github.com/users/alexhersh/repos","events_url":"https://api.github.com/users/alexhersh/events{/privacy}","received_events_url":"https://api.github.com/users/alexhersh/received_events","type":"User","site_admin":false},"repo":{"id":40984519,"name":"libcalico","full_name":"alexhersh/libcalico","owner":{"login":"alexhersh","id":3424115,"avatar_url":"https://avatars.githubusercontent.com/u/3424115?v=3","gravatar_id":"","url":"https://api.github.com/users/alexhersh","html_url":"https://github.com/alexhersh","followers_url":"https://api.github.com/users/alexhersh/followers","following_url":"https://api.github.com/users/alexhersh/following{/other_user}","gists_url":"https://api.github.com/users/alexhersh/gists{/gist_id}","starred_url":"https://api.github.com/users/alexhersh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexhersh/subscriptions","organizations_url":"https://api.github.com/users/alexhersh/orgs","repos_url":"https://api.github.com/users/alexhersh/repos","events_url":"https://api.github.com/users/alexhersh/events{/privacy}","received_events_url":"https://api.github.com/users/alexhersh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexhersh/libcalico","description":"","fork":true,"url":"https://api.github.com/repos/alexhersh/libcalico","forks_url":"https://api.github.com/repos/alexhersh/libcalico/forks","keys_url":"https://api.github.com/repos/alexhersh/libcalico/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexhersh/libcalico/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexhersh/libcalico/teams","hooks_url":"https://api.github.com/repos/alexhersh/libcalico/hooks","issue_events_url":"https://api.github.com/repos/alexhersh/libcalico/issues/events{/number}","events_url":"https://api.github.com/repos/alexhersh/libcalico/events","assignees_url":"https://api.github.com/repos/alexhersh/libcalico/assignees{/user}","branches_url":"https://api.github.com/repos/alexhersh/libcalico/branches{/branch}","tags_url":"https://api.github.com/repos/alexhersh/libcalico/tags","blobs_url":"https://api.github.com/repos/alexhersh/libcalico/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexhersh/libcalico/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexhersh/libcalico/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexhersh/libcalico/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexhersh/libcalico/statuses/{sha}","languages_url":"https://api.github.com/repos/alexhersh/libcalico/languages","stargazers_url":"https://api.github.com/repos/alexhersh/libcalico/stargazers","contributors_url":"https://api.github.com/repos/alexhersh/libcalico/contributors","subscribers_url":"https://api.github.com/repos/alexhersh/libcalico/subscribers","subscription_url":"https://api.github.com/repos/alexhersh/libcalico/subscription","commits_url":"https://api.github.com/repos/alexhersh/libcalico/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexhersh/libcalico/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexhersh/libcalico/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexhersh/libcalico/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexhersh/libcalico/contents/{+path}","compare_url":"https://api.github.com/repos/alexhersh/libcalico/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexhersh/libcalico/merges","archive_url":"https://api.github.com/repos/alexhersh/libcalico/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexhersh/libcalico/downloads","issues_url":"https://api.github.com/repos/alexhersh/libcalico/issues{/number}","pulls_url":"https://api.github.com/repos/alexhersh/libcalico/pulls{/number}","milestones_url":"https://api.github.com/repos/alexhersh/libcalico/milestones{/number}","notifications_url":"https://api.github.com/repos/alexhersh/libcalico/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexhersh/libcalico/labels{/name}","releases_url":"https://api.github.com/repos/alexhersh/libcalico/releases{/id}","created_at":"2015-08-18T16:46:47Z","updated_at":"2015-08-18T16:46:48Z","pushed_at":"2015-09-25T18:06:44Z","git_url":"git://github.com/alexhersh/libcalico.git","ssh_url":"git@github.com:alexhersh/libcalico.git","clone_url":"https://github.com/alexhersh/libcalico.git","svn_url":"https://github.com/alexhersh/libcalico","homepage":"http://www.projectcalico.org/","size":1731,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projectcalico:master","ref":"master","sha":"9a4a3293a5d9d2b1073c57f8c120c8664f603cba","user":{"login":"projectcalico","id":12304728,"avatar_url":"https://avatars.githubusercontent.com/u/12304728?v=3","gravatar_id":"","url":"https://api.github.com/users/projectcalico","html_url":"https://github.com/projectcalico","followers_url":"https://api.github.com/users/projectcalico/followers","following_url":"https://api.github.com/users/projectcalico/following{/other_user}","gists_url":"https://api.github.com/users/projectcalico/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcalico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcalico/subscriptions","organizations_url":"https://api.github.com/users/projectcalico/orgs","repos_url":"https://api.github.com/users/projectcalico/repos","events_url":"https://api.github.com/users/projectcalico/events{/privacy}","received_events_url":"https://api.github.com/users/projectcalico/received_events","type":"Organization","site_admin":false},"repo":{"id":39856396,"name":"libcalico","full_name":"projectcalico/libcalico","owner":{"login":"projectcalico","id":12304728,"avatar_url":"https://avatars.githubusercontent.com/u/12304728?v=3","gravatar_id":"","url":"https://api.github.com/users/projectcalico","html_url":"https://github.com/projectcalico","followers_url":"https://api.github.com/users/projectcalico/followers","following_url":"https://api.github.com/users/projectcalico/following{/other_user}","gists_url":"https://api.github.com/users/projectcalico/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcalico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcalico/subscriptions","organizations_url":"https://api.github.com/users/projectcalico/orgs","repos_url":"https://api.github.com/users/projectcalico/repos","events_url":"https://api.github.com/users/projectcalico/events{/privacy}","received_events_url":"https://api.github.com/users/projectcalico/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectcalico/libcalico","description":"","fork":false,"url":"https://api.github.com/repos/projectcalico/libcalico","forks_url":"https://api.github.com/repos/projectcalico/libcalico/forks","keys_url":"https://api.github.com/repos/projectcalico/libcalico/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectcalico/libcalico/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectcalico/libcalico/teams","hooks_url":"https://api.github.com/repos/projectcalico/libcalico/hooks","issue_events_url":"https://api.github.com/repos/projectcalico/libcalico/issues/events{/number}","events_url":"https://api.github.com/repos/projectcalico/libcalico/events","assignees_url":"https://api.github.com/repos/projectcalico/libcalico/assignees{/user}","branches_url":"https://api.github.com/repos/projectcalico/libcalico/branches{/branch}","tags_url":"https://api.github.com/repos/projectcalico/libcalico/tags","blobs_url":"https://api.github.com/repos/projectcalico/libcalico/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectcalico/libcalico/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectcalico/libcalico/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectcalico/libcalico/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectcalico/libcalico/statuses/{sha}","languages_url":"https://api.github.com/repos/projectcalico/libcalico/languages","stargazers_url":"https://api.github.com/repos/projectcalico/libcalico/stargazers","contributors_url":"https://api.github.com/repos/projectcalico/libcalico/contributors","subscribers_url":"https://api.github.com/repos/projectcalico/libcalico/subscribers","subscription_url":"https://api.github.com/repos/projectcalico/libcalico/subscription","commits_url":"https://api.github.com/repos/projectcalico/libcalico/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectcalico/libcalico/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectcalico/libcalico/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectcalico/libcalico/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectcalico/libcalico/contents/{+path}","compare_url":"https://api.github.com/repos/projectcalico/libcalico/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectcalico/libcalico/merges","archive_url":"https://api.github.com/repos/projectcalico/libcalico/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectcalico/libcalico/downloads","issues_url":"https://api.github.com/repos/projectcalico/libcalico/issues{/number}","pulls_url":"https://api.github.com/repos/projectcalico/libcalico/pulls{/number}","milestones_url":"https://api.github.com/repos/projectcalico/libcalico/milestones{/number}","notifications_url":"https://api.github.com/repos/projectcalico/libcalico/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectcalico/libcalico/labels{/name}","releases_url":"https://api.github.com/repos/projectcalico/libcalico/releases{/id}","created_at":"2015-07-28T20:33:51Z","updated_at":"2015-09-22T16:40:13Z","pushed_at":"2015-09-25T18:06:44Z","git_url":"git://github.com/projectcalico/libcalico.git","ssh_url":"git@github.com:projectcalico/libcalico.git","clone_url":"https://github.com/projectcalico/libcalico.git","svn_url":"https://github.com/projectcalico/libcalico","homepage":"http://www.projectcalico.org/","size":2017,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":2,"forks":11,"open_issues":2,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectcalico/libcalico/pulls/24"},"html":{"href":"https://github.com/projectcalico/libcalico/pull/24"},"issue":{"href":"https://api.github.com/repos/projectcalico/libcalico/issues/24"},"comments":{"href":"https://api.github.com/repos/projectcalico/libcalico/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/projectcalico/libcalico/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/projectcalico/libcalico/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectcalico/libcalico/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/projectcalico/libcalico/statuses/22d4d157a293e246e65847ba461956f6ad22f87f"}}}}