{"action":"created","issue":{"url":"https://api.github.com/repos/tintinweb/scapy-ssl_tls/issues/13","labels_url":"https://api.github.com/repos/tintinweb/scapy-ssl_tls/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/tintinweb/scapy-ssl_tls/issues/13/comments","events_url":"https://api.github.com/repos/tintinweb/scapy-ssl_tls/issues/13/events","html_url":"https://github.com/tintinweb/scapy-ssl_tls/pull/13","id":76149376,"number":13,"title":"Fixed dissection of stacked TLS records","user":{"login":"alexmgr","id":8157569,"avatar_url":"https://avatars.githubusercontent.com/u/8157569?v=3","gravatar_id":"","url":"https://api.github.com/users/alexmgr","html_url":"https://github.com/alexmgr","followers_url":"https://api.github.com/users/alexmgr/followers","following_url":"https://api.github.com/users/alexmgr/following{/other_user}","gists_url":"https://api.github.com/users/alexmgr/gists{/gist_id}","starred_url":"https://api.github.com/users/alexmgr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexmgr/subscriptions","organizations_url":"https://api.github.com/users/alexmgr/orgs","repos_url":"https://api.github.com/users/alexmgr/repos","events_url":"https://api.github.com/users/alexmgr/events{/privacy}","received_events_url":"https://api.github.com/users/alexmgr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-05-13T22:38:32Z","updated_at":"2015-05-19T00:20:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tintinweb/scapy-ssl_tls/pulls/13","html_url":"https://github.com/tintinweb/scapy-ssl_tls/pull/13","diff_url":"https://github.com/tintinweb/scapy-ssl_tls/pull/13.diff","patch_url":"https://github.com/tintinweb/scapy-ssl_tls/pull/13.patch"},"body":"- Added helper functions to TLSRecord to help navigate records\r\n- Simplified confusing do_dissect() function\r\n- Added unittest coverage\r\n\r\nThis allows handling stacked TLS Records, and proper dissection of them.\r\n\r\nStill need fixing TLSRecord length, so that generated stacked TLS records have proper lengths. Should happen in a later commit."},"comment":{"url":"https://api.github.com/repos/tintinweb/scapy-ssl_tls/issues/comments/103280212","html_url":"https://github.com/tintinweb/scapy-ssl_tls/pull/13#issuecomment-103280212","issue_url":"https://api.github.com/repos/tintinweb/scapy-ssl_tls/issues/13","id":103280212,"user":{"login":"alexmgr","id":8157569,"avatar_url":"https://avatars.githubusercontent.com/u/8157569?v=3","gravatar_id":"","url":"https://api.github.com/users/alexmgr","html_url":"https://github.com/alexmgr","followers_url":"https://api.github.com/users/alexmgr/followers","following_url":"https://api.github.com/users/alexmgr/following{/other_user}","gists_url":"https://api.github.com/users/alexmgr/gists{/gist_id}","starred_url":"https://api.github.com/users/alexmgr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexmgr/subscriptions","organizations_url":"https://api.github.com/users/alexmgr/orgs","repos_url":"https://api.github.com/users/alexmgr/repos","events_url":"https://api.github.com/users/alexmgr/events{/privacy}","received_events_url":"https://api.github.com/users/alexmgr/received_events","type":"User","site_admin":false},"created_at":"2015-05-19T00:20:37Z","updated_at":"2015-05-19T00:20:37Z","body":"Put my comments in the bug notes.\r\nI'm ok either way, but I think people will expect the following to work: TLSRecord()/TLSHandshake()/TLSClientKeyExchange(data=tls_ctx.get_encrypted_pms())/TLSRecord()/TLSChangeCipherSpec()/TLSRecord()/to_raw(TLSFinished(), tls_ctx)\r\nThis makes me realize that this probably doesn't work today ;), since TLSClientKeyExchange length is going to be miscalculated.\r\n\r\nI have no hard feelings, either way works for me, but I find the SSL.records solution less intuitive."}}