{"action":"created","issue":{"url":"https://api.github.com/repos/msgpack/msgpack-ruby/issues/45","labels_url":"https://api.github.com/repos/msgpack/msgpack-ruby/issues/45/labels{/name}","comments_url":"https://api.github.com/repos/msgpack/msgpack-ruby/issues/45/comments","events_url":"https://api.github.com/repos/msgpack/msgpack-ruby/issues/45/events","html_url":"https://github.com/msgpack/msgpack-ruby/pull/45","id":50829182,"number":45,"title":"Bin 8 bit support for Ruby ASCII-8BIT data type","user":{"login":"mattheworiordan","id":43789,"avatar_url":"https://avatars.githubusercontent.com/u/43789?v=3","gravatar_id":"","url":"https://api.github.com/users/mattheworiordan","html_url":"https://github.com/mattheworiordan","followers_url":"https://api.github.com/users/mattheworiordan/followers","following_url":"https://api.github.com/users/mattheworiordan/following{/other_user}","gists_url":"https://api.github.com/users/mattheworiordan/gists{/gist_id}","starred_url":"https://api.github.com/users/mattheworiordan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattheworiordan/subscriptions","organizations_url":"https://api.github.com/users/mattheworiordan/orgs","repos_url":"https://api.github.com/users/mattheworiordan/repos","events_url":"https://api.github.com/users/mattheworiordan/events{/privacy}","received_events_url":"https://api.github.com/users/mattheworiordan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2014-12-03T12:05:24Z","updated_at":"2015-05-17T10:59:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/msgpack/msgpack-ruby/pulls/45","html_url":"https://github.com/msgpack/msgpack-ruby/pull/45","diff_url":"https://github.com/msgpack/msgpack-ruby/pull/45.diff","patch_url":"https://github.com/msgpack/msgpack-ruby/pull/45.patch"},"body":"This Pull Request adds support for the [Msgpack bin](https://github.com/msgpack/msgpack/blob/master/spec.md#bin-format-family) data type.  If you refer to http://yehudakatz.com/2010/05/05/ruby-1-9-encodings-a-primer-and-the-solution-for-rails/, you will see that the convention for Ruby binary data is to use the `ASCII-8BIT` encoding.  The Ruby MsgPack gem will now detect `ASCII-8BIT` when encoding and encode as `bin`, and will return `ASCII-8BIT` strings if the data type is bin.  \r\n\r\nThis PR fixes issue https://github.com/msgpack/msgpack-ruby/issues/44, and also resolves a few small other issues such as adding support for str 8 data type that was missing."},"comment":{"url":"https://api.github.com/repos/msgpack/msgpack-ruby/issues/comments/102783431","html_url":"https://github.com/msgpack/msgpack-ruby/pull/45#issuecomment-102783431","issue_url":"https://api.github.com/repos/msgpack/msgpack-ruby/issues/45","id":102783431,"user":{"login":"mattheworiordan","id":43789,"avatar_url":"https://avatars.githubusercontent.com/u/43789?v=3","gravatar_id":"","url":"https://api.github.com/users/mattheworiordan","html_url":"https://github.com/mattheworiordan","followers_url":"https://api.github.com/users/mattheworiordan/followers","following_url":"https://api.github.com/users/mattheworiordan/following{/other_user}","gists_url":"https://api.github.com/users/mattheworiordan/gists{/gist_id}","starred_url":"https://api.github.com/users/mattheworiordan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattheworiordan/subscriptions","organizations_url":"https://api.github.com/users/mattheworiordan/orgs","repos_url":"https://api.github.com/users/mattheworiordan/repos","events_url":"https://api.github.com/users/mattheworiordan/events{/privacy}","received_events_url":"https://api.github.com/users/mattheworiordan/received_events","type":"User","site_admin":false},"created_at":"2015-05-17T10:59:35Z","updated_at":"2015-05-17T10:59:35Z","body":"@nathany I am probably going to create a MsgPackV5 fork that uses a different namespace as this fork is not ideal as the namespace would conflict if someone used both the old & forked MsgPack gems.  However, if this is not a problem for you (it won't effect most people) then please do use my fork, I hope it helps."}}