{"action":"created","comment":{"url":"https://api.github.com/repos/Wikia/app/pulls/comments/39942960","id":39942960,"diff_hunk":"@@ -4903,19 +4903,15 @@ private function loadAttributes() {\n \t}\n \n \tprivate function compareAttributeValueFromService( $attributeName, $attributeValue ) {\n-\t\tif ( !array_key_exists( $attributeName, $this->mOptions ) ) {\n-\t\t\t$this->logAttributeMissing( $attributeName, $attributeValue );\n-\t\t} elseif ( $this->mOptions[$attributeName] !== $attributeValue  ) {\n-\t\t\t$this->logAttributeMismatch( $attributeName, $attributeValue );\n+\n+\t\t// bio and coverPhoto are not used in MW\n+\t\tif ( $attributeName == \"bio\" || $attributeName == \"coverPhoto\" ) {","path":"includes/User.php","position":10,"original_position":10,"commit_id":"f4f843456673ea1d7c0c8dd9f715c9aedc8e0068","original_commit_id":"170b9cace2bb70ba2fab2bab95662c1239147ba6","user":{"login":"jsutterfield","id":1657792,"avatar_url":"https://avatars.githubusercontent.com/u/1657792?v=3","gravatar_id":"","url":"https://api.github.com/users/jsutterfield","html_url":"https://github.com/jsutterfield","followers_url":"https://api.github.com/users/jsutterfield/followers","following_url":"https://api.github.com/users/jsutterfield/following{/other_user}","gists_url":"https://api.github.com/users/jsutterfield/gists{/gist_id}","starred_url":"https://api.github.com/users/jsutterfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsutterfield/subscriptions","organizations_url":"https://api.github.com/users/jsutterfield/orgs","repos_url":"https://api.github.com/users/jsutterfield/repos","events_url":"https://api.github.com/users/jsutterfield/events{/privacy}","received_events_url":"https://api.github.com/users/jsutterfield/received_events","type":"User","site_admin":false},"body":"Good point. For now we don't expect more attributes like this, and this logging will probably go away in the near future. If we add more attributes to this `if` statement though, we should split them into one place :)","created_at":"2015-09-21T06:04:16Z","updated_at":"2015-09-21T06:04:16Z","html_url":"https://github.com/Wikia/app/pull/8525#discussion_r39942960","pull_request_url":"https://api.github.com/repos/Wikia/app/pulls/8525","_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments/39942960"},"html":{"href":"https://github.com/Wikia/app/pull/8525#discussion_r39942960"},"pull_request":{"href":"https://api.github.com/repos/Wikia/app/pulls/8525"}}},"pull_request":{"url":"https://api.github.com/repos/Wikia/app/pulls/8525","id":45356515,"html_url":"https://github.com/Wikia/app/pull/8525","diff_url":"https://github.com/Wikia/app/pull/8525.diff","patch_url":"https://github.com/Wikia/app/pull/8525.patch","issue_url":"https://api.github.com/repos/Wikia/app/issues/8525","number":8525,"state":"open","locked":false,"title":"SO-1315-2 Set $wgBaseShareKeyPrefix in CommonSettings and fix Attribute Service Logging","user":{"login":"jsutterfield","id":1657792,"avatar_url":"https://avatars.githubusercontent.com/u/1657792?v=3","gravatar_id":"","url":"https://api.github.com/users/jsutterfield","html_url":"https://github.com/jsutterfield","followers_url":"https://api.github.com/users/jsutterfield/followers","following_url":"https://api.github.com/users/jsutterfield/following{/other_user}","gists_url":"https://api.github.com/users/jsutterfield/gists{/gist_id}","starred_url":"https://api.github.com/users/jsutterfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsutterfield/subscriptions","organizations_url":"https://api.github.com/users/jsutterfield/orgs","repos_url":"https://api.github.com/users/jsutterfield/repos","events_url":"https://api.github.com/users/jsutterfield/events{/privacy}","received_events_url":"https://api.github.com/users/jsutterfield/received_events","type":"User","site_admin":false},"body":"Ticket: https://wikia-inc.atlassian.net/browse/SOC-1315","created_at":"2015-09-18T00:04:07Z","updated_at":"2015-09-21T06:04:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"35f66d2d0faaf00070ef90570a45719279131097","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Wikia/app/pulls/8525/commits","review_comments_url":"https://api.github.com/repos/Wikia/app/pulls/8525/comments","review_comment_url":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wikia/app/issues/8525/comments","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/f4f843456673ea1d7c0c8dd9f715c9aedc8e0068","head":{"label":"Wikia:SOC-1315-2","ref":"SOC-1315-2","sha":"f4f843456673ea1d7c0c8dd9f715c9aedc8e0068","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","created_at":"2012-08-23T20:55:58Z","updated_at":"2015-09-18T18:30:30Z","pushed_at":"2015-09-21T02:12:18Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":1486683,"stargazers_count":87,"watchers_count":87,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":69,"mirror_url":null,"open_issues_count":61,"forks":69,"open_issues":61,"watchers":87,"default_branch":"dev"}},"base":{"label":"Wikia:dev","ref":"dev","sha":"2504f8af6321a76fdf5f1d5de89b98979eec0518","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","created_at":"2012-08-23T20:55:58Z","updated_at":"2015-09-18T18:30:30Z","pushed_at":"2015-09-21T02:12:18Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":1486683,"stargazers_count":87,"watchers_count":87,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":69,"mirror_url":null,"open_issues_count":61,"forks":69,"open_issues":61,"watchers":87,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/8525"},"html":{"href":"https://github.com/Wikia/app/pull/8525"},"issue":{"href":"https://api.github.com/repos/Wikia/app/issues/8525"},"comments":{"href":"https://api.github.com/repos/Wikia/app/issues/8525/comments"},"review_comments":{"href":"https://api.github.com/repos/Wikia/app/pulls/8525/comments"},"review_comment":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wikia/app/pulls/8525/commits"},"statuses":{"href":"https://api.github.com/repos/Wikia/app/statuses/f4f843456673ea1d7c0c8dd9f715c9aedc8e0068"}}}}