{"action":"created","comment":{"url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/comments/32742701","id":32742701,"diff_hunk":"@@ -547,6 +547,87 @@ Only files matching this regular expression will be picked up by this adapter.\n         </xsd:attribute>\n     </xsd:complexType>\n \n+\t<xsd:element name=\"splitter\">\n+\t\t<xsd:annotation>\n+\t\t\t<xsd:documentation>\n+\t\t\t\tDefines a Splitter that splits text-based files into lines.\n+\t\t\t</xsd:documentation>\n+\t\t</xsd:annotation>\n+\t\t<xsd:complexType>\n+\t\t\t<xsd:choice minOccurs=\"0\" maxOccurs=\"2\">\n+\t\t\t\t<xsd:element name=\"poller\" type=\"integration:basePollerType\" minOccurs=\"0\" maxOccurs=\"1\" />\n+\t\t\t\t<xsd:element name=\"request-handler-advice-chain\" type=\"integration:handlerAdviceChainType\" minOccurs=\"0\" maxOccurs=\"1\" />\n+\t\t\t</xsd:choice>\n+\t\t\t<xsd:attributeGroup ref=\"integration:inputOutputChannelGroup\" />\n+\t\t\t<xsd:attribute name=\"id\" type=\"xsd:string\">\n+\t\t\t\t<xsd:annotation>\n+\t\t\t\t\t<xsd:documentation><![CDATA[Identifies the underlying Spring bean definition (EventDrivenConsumer)]]></xsd:documentation>\n+\t\t\t\t</xsd:annotation>\n+\t\t\t</xsd:attribute>\n+\t\t\t<xsd:attribute name=\"charset\" type=\"xsd:string\">\n+\t\t\t\t<xsd:annotation>\n+\t\t\t\t\t<xsd:documentation>\n+\t\t\t\t\t\t<![CDATA[Set the charset name to use when reading bytes from the text-based file into String\n+\t\t\t\t\t\tpayloads, e.g. charset=\"UTF-8\". If not set, the default charset of this\n+\t\t\t\t\t\tJava virtual machine is used.\n+\t\t\t\t\t\t]]>\n+\t\t\t\t\t</xsd:documentation>\n+\t\t\t\t</xsd:annotation>\n+\t\t\t</xsd:attribute>\n+\t\t\t<xsd:attribute name=\"requires-reply\" use=\"optional\" default=\"false\">\n+\t\t\t\t<xsd:annotation>\n+\t\t\t\t\t<xsd:documentation>\n+\t\t\t\t\t\tSpecify whether the splitter must return at least one message. This value will be\n+\t\t\t\t\t\t'false' by default, but if set to 'true', a ReplyRequiredException will be thrown when\n+\t\t\t\t\t\tthe file has no data.\n+\t\t\t\t\t</xsd:documentation>\n+\t\t\t\t</xsd:annotation>\n+\t\t\t\t<xsd:simpleType>\n+\t\t\t\t\t<xsd:union memberTypes=\"xsd:boolean xsd:string\"/>\n+\t\t\t\t</xsd:simpleType>\n+\t\t\t</xsd:attribute>\n+\t\t\t<xsd:attribute name=\"apply-sequence\" use=\"optional\">\n+\t\t\t\t<xsd:annotation>\n+\t\t\t\t\t<xsd:documentation>\n+\t\t\t\t\t\tSet this flag to determine whether sequence related headers are added to messages\n+\t\t\t\t\t\tfrom this splitter. When true, existing correlation and sequence related headers\n+\t\t\t\t\t\tare pushed onto a stack; downstream components, such as aggregators may pop\n+\t\t\t\t\t\tthe stack to revert the existing headers after aggregation. Default is 'true'\n+\t\t\t\t\t\tunless 'markers' is 'true'. Also see 'iterator'.\n+\t\t\t\t\t</xsd:documentation>\n+\t\t\t\t</xsd:annotation>\n+\t\t\t\t<xsd:simpleType>\n+\t\t\t\t\t<xsd:union memberTypes=\"xsd:boolean xsd:string\"/>\n+\t\t\t\t</xsd:simpleType>\n+\t\t\t</xsd:attribute>\n+\t\t\t<xsd:attribute name=\"iterator\" use=\"optional\" default=\"true\">\n+\t\t\t\t<xsd:annotation>\n+\t\t\t\t\t<xsd:documentation>\n+\t\t\t\t\t\tSet this flag to determine whether the lines are emitted via an iterator (line at a time)\n+\t\t\t\t\t\tor the whole file is read into memory and then the lines emitted. When true, if\n+\t\t\t\t\t\t'apply-sequence' is 'true', the `sequenceSize` header is set to '0'. Default: 'true'.","path":"spring-integration-file/src/main/resources/org/springframework/integration/file/config/spring-integration-file-4.2.xsd","position":62,"original_position":62,"commit_id":"ec13cfad029f86ccb73cec8a7a62d99059513c48","original_commit_id":"ec13cfad029f86ccb73cec8a7a62d99059513c48","user":{"login":"garyrussell","id":483832,"avatar_url":"https://avatars.githubusercontent.com/u/483832?v=3","gravatar_id":"","url":"https://api.github.com/users/garyrussell","html_url":"https://github.com/garyrussell","followers_url":"https://api.github.com/users/garyrussell/followers","following_url":"https://api.github.com/users/garyrussell/following{/other_user}","gists_url":"https://api.github.com/users/garyrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/garyrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyrussell/subscriptions","organizations_url":"https://api.github.com/users/garyrussell/orgs","repos_url":"https://api.github.com/users/garyrussell/repos","events_url":"https://api.github.com/users/garyrussell/events{/privacy}","received_events_url":"https://api.github.com/users/garyrussell/received_events","type":"User","site_admin":false},"body":"Not sure I understand the complaint here - is this better...\r\n\r\n>When this is 'true', if 'apply-sequence' is also 'true', the 'sequenceSize' header is set to '0'. Default: 'true'.\r\n\r\n","created_at":"2015-06-18T15:29:36Z","updated_at":"2015-06-18T15:29:36Z","html_url":"https://github.com/spring-projects/spring-integration/pull/1464#discussion_r32742701","pull_request_url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1464","_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/comments/32742701"},"html":{"href":"https://github.com/spring-projects/spring-integration/pull/1464#discussion_r32742701"},"pull_request":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1464"}}},"pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1464","id":37591798,"html_url":"https://github.com/spring-projects/spring-integration/pull/1464","diff_url":"https://github.com/spring-projects/spring-integration/pull/1464.diff","patch_url":"https://github.com/spring-projects/spring-integration/pull/1464.patch","issue_url":"https://api.github.com/repos/spring-projects/spring-integration/issues/1464","number":1464,"state":"open","locked":false,"title":"INT-3600: FileSplitter Namespace and Docs","user":{"login":"garyrussell","id":483832,"avatar_url":"https://avatars.githubusercontent.com/u/483832?v=3","gravatar_id":"","url":"https://api.github.com/users/garyrussell","html_url":"https://github.com/garyrussell","followers_url":"https://api.github.com/users/garyrussell/followers","following_url":"https://api.github.com/users/garyrussell/following{/other_user}","gists_url":"https://api.github.com/users/garyrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/garyrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyrussell/subscriptions","organizations_url":"https://api.github.com/users/garyrussell/orgs","repos_url":"https://api.github.com/users/garyrussell/repos","events_url":"https://api.github.com/users/garyrussell/events{/privacy}","received_events_url":"https://api.github.com/users/garyrussell/received_events","type":"User","site_admin":false},"body":"JIRA: https://jira.spring.io/browse/INT-3600\r\n\r\nAdd `<int-file:splitter/>` namespace component.\r\nAdd `FileSplitter` documentation.","created_at":"2015-06-12T18:35:22Z","updated_at":"2015-06-18T15:29:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ee52fdcbe3b6a991eeb80ad5183a863b9a9d5f8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1464/commits","review_comments_url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1464/comments","review_comment_url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-projects/spring-integration/issues/1464/comments","statuses_url":"https://api.github.com/repos/spring-projects/spring-integration/statuses/ec13cfad029f86ccb73cec8a7a62d99059513c48","head":{"label":"garyrussell:INT-3600","ref":"INT-3600","sha":"ec13cfad029f86ccb73cec8a7a62d99059513c48","user":{"login":"garyrussell","id":483832,"avatar_url":"https://avatars.githubusercontent.com/u/483832?v=3","gravatar_id":"","url":"https://api.github.com/users/garyrussell","html_url":"https://github.com/garyrussell","followers_url":"https://api.github.com/users/garyrussell/followers","following_url":"https://api.github.com/users/garyrussell/following{/other_user}","gists_url":"https://api.github.com/users/garyrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/garyrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyrussell/subscriptions","organizations_url":"https://api.github.com/users/garyrussell/orgs","repos_url":"https://api.github.com/users/garyrussell/repos","events_url":"https://api.github.com/users/garyrussell/events{/privacy}","received_events_url":"https://api.github.com/users/garyrussell/received_events","type":"User","site_admin":false},"repo":{"id":2197787,"name":"spring-integration","full_name":"garyrussell/spring-integration","owner":{"login":"garyrussell","id":483832,"avatar_url":"https://avatars.githubusercontent.com/u/483832?v=3","gravatar_id":"","url":"https://api.github.com/users/garyrussell","html_url":"https://github.com/garyrussell","followers_url":"https://api.github.com/users/garyrussell/followers","following_url":"https://api.github.com/users/garyrussell/following{/other_user}","gists_url":"https://api.github.com/users/garyrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/garyrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyrussell/subscriptions","organizations_url":"https://api.github.com/users/garyrussell/orgs","repos_url":"https://api.github.com/users/garyrussell/repos","events_url":"https://api.github.com/users/garyrussell/events{/privacy}","received_events_url":"https://api.github.com/users/garyrussell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/garyrussell/spring-integration","description":"","fork":true,"url":"https://api.github.com/repos/garyrussell/spring-integration","forks_url":"https://api.github.com/repos/garyrussell/spring-integration/forks","keys_url":"https://api.github.com/repos/garyrussell/spring-integration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/garyrussell/spring-integration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/garyrussell/spring-integration/teams","hooks_url":"https://api.github.com/repos/garyrussell/spring-integration/hooks","issue_events_url":"https://api.github.com/repos/garyrussell/spring-integration/issues/events{/number}","events_url":"https://api.github.com/repos/garyrussell/spring-integration/events","assignees_url":"https://api.github.com/repos/garyrussell/spring-integration/assignees{/user}","branches_url":"https://api.github.com/repos/garyrussell/spring-integration/branches{/branch}","tags_url":"https://api.github.com/repos/garyrussell/spring-integration/tags","blobs_url":"https://api.github.com/repos/garyrussell/spring-integration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/garyrussell/spring-integration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/garyrussell/spring-integration/git/refs{/sha}","trees_url":"https://api.github.com/repos/garyrussell/spring-integration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/garyrussell/spring-integration/statuses/{sha}","languages_url":"https://api.github.com/repos/garyrussell/spring-integration/languages","stargazers_url":"https://api.github.com/repos/garyrussell/spring-integration/stargazers","contributors_url":"https://api.github.com/repos/garyrussell/spring-integration/contributors","subscribers_url":"https://api.github.com/repos/garyrussell/spring-integration/subscribers","subscription_url":"https://api.github.com/repos/garyrussell/spring-integration/subscription","commits_url":"https://api.github.com/repos/garyrussell/spring-integration/commits{/sha}","git_commits_url":"https://api.github.com/repos/garyrussell/spring-integration/git/commits{/sha}","comments_url":"https://api.github.com/repos/garyrussell/spring-integration/comments{/number}","issue_comment_url":"https://api.github.com/repos/garyrussell/spring-integration/issues/comments{/number}","contents_url":"https://api.github.com/repos/garyrussell/spring-integration/contents/{+path}","compare_url":"https://api.github.com/repos/garyrussell/spring-integration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/garyrussell/spring-integration/merges","archive_url":"https://api.github.com/repos/garyrussell/spring-integration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/garyrussell/spring-integration/downloads","issues_url":"https://api.github.com/repos/garyrussell/spring-integration/issues{/number}","pulls_url":"https://api.github.com/repos/garyrussell/spring-integration/pulls{/number}","milestones_url":"https://api.github.com/repos/garyrussell/spring-integration/milestones{/number}","notifications_url":"https://api.github.com/repos/garyrussell/spring-integration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/garyrussell/spring-integration/labels{/name}","releases_url":"https://api.github.com/repos/garyrussell/spring-integration/releases{/id}","created_at":"2011-08-12T15:45:00Z","updated_at":"2015-05-05T14:02:54Z","pushed_at":"2015-06-17T22:32:18Z","git_url":"git://github.com/garyrussell/spring-integration.git","ssh_url":"git@github.com:garyrussell/spring-integration.git","clone_url":"https://github.com/garyrussell/spring-integration.git","svn_url":"https://github.com/garyrussell/spring-integration","homepage":"","size":36481,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"spring-projects:master","ref":"master","sha":"51b52ea3a66a04bfffc83fedd6d36435103d1b50","user":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":2090979,"name":"spring-integration","full_name":"spring-projects/spring-integration","owner":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-projects/spring-integration","description":"Spring Integration provides an extension of the Spring programming model to support the well-known Enterprise Integration Patterns (EIP)","fork":false,"url":"https://api.github.com/repos/spring-projects/spring-integration","forks_url":"https://api.github.com/repos/spring-projects/spring-integration/forks","keys_url":"https://api.github.com/repos/spring-projects/spring-integration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-projects/spring-integration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-projects/spring-integration/teams","hooks_url":"https://api.github.com/repos/spring-projects/spring-integration/hooks","issue_events_url":"https://api.github.com/repos/spring-projects/spring-integration/issues/events{/number}","events_url":"https://api.github.com/repos/spring-projects/spring-integration/events","assignees_url":"https://api.github.com/repos/spring-projects/spring-integration/assignees{/user}","branches_url":"https://api.github.com/repos/spring-projects/spring-integration/branches{/branch}","tags_url":"https://api.github.com/repos/spring-projects/spring-integration/tags","blobs_url":"https://api.github.com/repos/spring-projects/spring-integration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-projects/spring-integration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-projects/spring-integration/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-projects/spring-integration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-projects/spring-integration/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-projects/spring-integration/languages","stargazers_url":"https://api.github.com/repos/spring-projects/spring-integration/stargazers","contributors_url":"https://api.github.com/repos/spring-projects/spring-integration/contributors","subscribers_url":"https://api.github.com/repos/spring-projects/spring-integration/subscribers","subscription_url":"https://api.github.com/repos/spring-projects/spring-integration/subscription","commits_url":"https://api.github.com/repos/spring-projects/spring-integration/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-projects/spring-integration/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-projects/spring-integration/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-projects/spring-integration/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-projects/spring-integration/contents/{+path}","compare_url":"https://api.github.com/repos/spring-projects/spring-integration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-projects/spring-integration/merges","archive_url":"https://api.github.com/repos/spring-projects/spring-integration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-projects/spring-integration/downloads","issues_url":"https://api.github.com/repos/spring-projects/spring-integration/issues{/number}","pulls_url":"https://api.github.com/repos/spring-projects/spring-integration/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-projects/spring-integration/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-projects/spring-integration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-projects/spring-integration/labels{/name}","releases_url":"https://api.github.com/repos/spring-projects/spring-integration/releases{/id}","created_at":"2011-07-22T21:47:27Z","updated_at":"2015-06-17T02:22:21Z","pushed_at":"2015-06-18T01:05:46Z","git_url":"git://github.com/spring-projects/spring-integration.git","ssh_url":"git@github.com:spring-projects/spring-integration.git","clone_url":"https://github.com/spring-projects/spring-integration.git","svn_url":"https://github.com/spring-projects/spring-integration","homepage":"http://projects.spring.io/spring-integration/","size":85723,"stargazers_count":361,"watchers_count":361,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":326,"mirror_url":null,"open_issues_count":9,"forks":326,"open_issues":9,"watchers":361,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1464"},"html":{"href":"https://github.com/spring-projects/spring-integration/pull/1464"},"issue":{"href":"https://api.github.com/repos/spring-projects/spring-integration/issues/1464"},"comments":{"href":"https://api.github.com/repos/spring-projects/spring-integration/issues/1464/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1464/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1464/commits"},"statuses":{"href":"https://api.github.com/repos/spring-projects/spring-integration/statuses/ec13cfad029f86ccb73cec8a7a62d99059513c48"}}}}