{"action":"created","issue":{"url":"https://api.github.com/repos/angular-ui/bootstrap/issues/4767","labels_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/4767/labels{/name}","comments_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/4767/comments","events_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/4767/events","html_url":"https://github.com/angular-ui/bootstrap/pull/4767","id":113904440,"number":4767,"title":"fix(dateparser): baseDate only care about dates","user":{"login":"Foxandxss","id":1087957,"avatar_url":"https://avatars.githubusercontent.com/u/1087957?v=3","gravatar_id":"","url":"https://api.github.com/users/Foxandxss","html_url":"https://github.com/Foxandxss","followers_url":"https://api.github.com/users/Foxandxss/followers","following_url":"https://api.github.com/users/Foxandxss/following{/other_user}","gists_url":"https://api.github.com/users/Foxandxss/gists{/gist_id}","starred_url":"https://api.github.com/users/Foxandxss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Foxandxss/subscriptions","organizations_url":"https://api.github.com/users/Foxandxss/orgs","repos_url":"https://api.github.com/users/Foxandxss/repos","events_url":"https://api.github.com/users/Foxandxss/events{/privacy}","received_events_url":"https://api.github.com/users/Foxandxss/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/angular-ui/bootstrap/labels/component:%20dateparser","name":"component: dateparser","color":"ffffff"},{"url":"https://api.github.com/repos/angular-ui/bootstrap/labels/needs:%20review","name":"needs: review","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/angular-ui/bootstrap/milestones/9","html_url":"https://github.com/angular-ui/bootstrap/milestones/1.0.0","labels_url":"https://api.github.com/repos/angular-ui/bootstrap/milestones/9/labels","id":528366,"number":9,"title":"1.0.0","description":"Rewrite in ES6","creator":{"login":"chrisirhc","id":132584,"avatar_url":"https://avatars.githubusercontent.com/u/132584?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisirhc","html_url":"https://github.com/chrisirhc","followers_url":"https://api.github.com/users/chrisirhc/followers","following_url":"https://api.github.com/users/chrisirhc/following{/other_user}","gists_url":"https://api.github.com/users/chrisirhc/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisirhc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisirhc/subscriptions","organizations_url":"https://api.github.com/users/chrisirhc/orgs","repos_url":"https://api.github.com/users/chrisirhc/repos","events_url":"https://api.github.com/users/chrisirhc/events{/privacy}","received_events_url":"https://api.github.com/users/chrisirhc/received_events","type":"User","site_admin":false},"open_issues":62,"closed_issues":48,"state":"open","created_at":"2014-01-07T00:22:46Z","updated_at":"2015-10-28T19:57:31Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2015-10-28T19:31:51Z","updated_at":"2015-10-28T20:10:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/4767","html_url":"https://github.com/angular-ui/bootstrap/pull/4767","diff_url":"https://github.com/angular-ui/bootstrap/pull/4767.diff","patch_url":"https://github.com/angular-ui/bootstrap/pull/4767.patch"},"body":"So, `setFullYear` won't respect the time part, and since we want to respect the timezone, it doesn't make sense anyway right?\r\n\r\nSo I removed all the time part and also added tests to it.\r\n\r\nNot entirely sure if I am right, but I think so.\r\n\r\nThoughts @wesleycho ?"},"comment":{"url":"https://api.github.com/repos/angular-ui/bootstrap/issues/comments/151975916","html_url":"https://github.com/angular-ui/bootstrap/pull/4767#issuecomment-151975916","issue_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/4767","id":151975916,"user":{"login":"wesleycho","id":1703387,"avatar_url":"https://avatars.githubusercontent.com/u/1703387?v=3","gravatar_id":"","url":"https://api.github.com/users/wesleycho","html_url":"https://github.com/wesleycho","followers_url":"https://api.github.com/users/wesleycho/followers","following_url":"https://api.github.com/users/wesleycho/following{/other_user}","gists_url":"https://api.github.com/users/wesleycho/gists{/gist_id}","starred_url":"https://api.github.com/users/wesleycho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesleycho/subscriptions","organizations_url":"https://api.github.com/users/wesleycho/orgs","repos_url":"https://api.github.com/users/wesleycho/repos","events_url":"https://api.github.com/users/wesleycho/events{/privacy}","received_events_url":"https://api.github.com/users/wesleycho/received_events","type":"User","site_admin":false},"created_at":"2015-10-28T20:10:24Z","updated_at":"2015-10-28T20:10:24Z","body":"Oh you're right, I should have took a second look at the code"}}