{"action":"created","comment":{"url":"https://api.github.com/repos/scala-js/scala-js-dom/pulls/comments/44226892","id":44226892,"diff_hunk":"@@ -257,17 +278,17 @@ object RsaKeyGenParams {\n \n @js.native\n trait RsaHashedKeyGenParams extends RsaKeyGenParams {\n-  var hash: String = js.native\n+  var hash: HashAlgorithm = js.native\n }\n \n @js.native\n object RsaHashedKeyGenParams {\n   @inline\n-  def apply(name: String, modulusLength: Long,\n-      publicExponent: BigInteger, hash: String): RsaHashedKeyGenParams = {\n-    js.Dynamic.literal(name = name, modulusLength = modulusLength.toDouble,\n+  def apply( modulusLength: Long,\n+      publicExponent: BigInteger, hash: HashAlgorithmIdentifier): RsaHashedKeyGenParams = {\n+    js.Dynamic.literal(name = \"RSASSA-PKCS1-v1_5\", modulusLength = modulusLength.toDouble,","path":"src/main/scala/org/scalajs/dom/crypto/Crypto.scala","position":198,"original_position":198,"commit_id":"bf8d740bb33c48e4729bba7fb4919d0513d63808","original_commit_id":"bf8d740bb33c48e4729bba7fb4919d0513d63808","user":{"login":"mseddon","id":4021991,"avatar_url":"https://avatars.githubusercontent.com/u/4021991?v=3","gravatar_id":"","url":"https://api.github.com/users/mseddon","html_url":"https://github.com/mseddon","followers_url":"https://api.github.com/users/mseddon/followers","following_url":"https://api.github.com/users/mseddon/following{/other_user}","gists_url":"https://api.github.com/users/mseddon/gists{/gist_id}","starred_url":"https://api.github.com/users/mseddon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mseddon/subscriptions","organizations_url":"https://api.github.com/users/mseddon/orgs","repos_url":"https://api.github.com/users/mseddon/repos","events_url":"https://api.github.com/users/mseddon/events{/privacy}","received_events_url":"https://api.github.com/users/mseddon/received_events","type":"User","site_admin":false},"body":"Okay, that's no problem. There isn't a lot of heavy crypto api users (I believe the list is currently, us. :)), and I still want to go through this api and see if I can strengthen all these Promise[Any]'s.  I will touch most of these classes anyway in that PR.","created_at":"2015-11-08T16:45:08Z","updated_at":"2015-11-08T16:45:08Z","html_url":"https://github.com/scala-js/scala-js-dom/pull/169#discussion_r44226892","pull_request_url":"https://api.github.com/repos/scala-js/scala-js-dom/pulls/169","_links":{"self":{"href":"https://api.github.com/repos/scala-js/scala-js-dom/pulls/comments/44226892"},"html":{"href":"https://github.com/scala-js/scala-js-dom/pull/169#discussion_r44226892"},"pull_request":{"href":"https://api.github.com/repos/scala-js/scala-js-dom/pulls/169"}}},"pull_request":{"url":"https://api.github.com/repos/scala-js/scala-js-dom/pulls/169","id":50063115,"html_url":"https://github.com/scala-js/scala-js-dom/pull/169","diff_url":"https://github.com/scala-js/scala-js-dom/pull/169.diff","patch_url":"https://github.com/scala-js/scala-js-dom/pull/169.patch","issue_url":"https://api.github.com/repos/scala-js/scala-js-dom/issues/169","number":169,"state":"open","locked":false,"title":"Fix #166: generateKeyApi not flexible enough.","user":{"login":"bblfish","id":124506,"avatar_url":"https://avatars.githubusercontent.com/u/124506?v=3","gravatar_id":"","url":"https://api.github.com/users/bblfish","html_url":"https://github.com/bblfish","followers_url":"https://api.github.com/users/bblfish/followers","following_url":"https://api.github.com/users/bblfish/following{/other_user}","gists_url":"https://api.github.com/users/bblfish/gists{/gist_id}","starred_url":"https://api.github.com/users/bblfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bblfish/subscriptions","organizations_url":"https://api.github.com/users/bblfish/orgs","repos_url":"https://api.github.com/users/bblfish/repos","events_url":"https://api.github.com/users/bblfish/events{/privacy}","received_events_url":"https://api.github.com/users/bblfish/received_events","type":"User","site_admin":false},"body":"With these changes it is possible to code the [WebCrypto API signing example](http://www.w3.org/TR/WebCryptoAPI/#examples-signing) in the same style as the example fixing #166 \r\n\r\n```scala\r\n    GlobalCrypto.crypto.subtle.generateKey(\r\n      RsaHashedKeyGenParams(\r\n        2048,\r\n        new Uint8Array(js.Array[Short](1,0,1)), //65537\r\n        HashAlgorithm.`SHA-256`),\r\n      false,\r\n      js.Array(KeyUsages.sign,KeyUsages.verify)\r\n    )\r\n```\r\n","created_at":"2015-11-08T15:58:55Z","updated_at":"2015-11-08T16:45:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f98344ad6557372f1d1f485d15df598ef281a2f2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scala-js/scala-js-dom/pulls/169/commits","review_comments_url":"https://api.github.com/repos/scala-js/scala-js-dom/pulls/169/comments","review_comment_url":"https://api.github.com/repos/scala-js/scala-js-dom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scala-js/scala-js-dom/issues/169/comments","statuses_url":"https://api.github.com/repos/scala-js/scala-js-dom/statuses/bf8d740bb33c48e4729bba7fb4919d0513d63808","head":{"label":"bblfish:fix-generate-key-api","ref":"fix-generate-key-api","sha":"bf8d740bb33c48e4729bba7fb4919d0513d63808","user":{"login":"bblfish","id":124506,"avatar_url":"https://avatars.githubusercontent.com/u/124506?v=3","gravatar_id":"","url":"https://api.github.com/users/bblfish","html_url":"https://github.com/bblfish","followers_url":"https://api.github.com/users/bblfish/followers","following_url":"https://api.github.com/users/bblfish/following{/other_user}","gists_url":"https://api.github.com/users/bblfish/gists{/gist_id}","starred_url":"https://api.github.com/users/bblfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bblfish/subscriptions","organizations_url":"https://api.github.com/users/bblfish/orgs","repos_url":"https://api.github.com/users/bblfish/repos","events_url":"https://api.github.com/users/bblfish/events{/privacy}","received_events_url":"https://api.github.com/users/bblfish/received_events","type":"User","site_admin":false},"repo":{"id":45736516,"name":"scala-js-dom","full_name":"bblfish/scala-js-dom","owner":{"login":"bblfish","id":124506,"avatar_url":"https://avatars.githubusercontent.com/u/124506?v=3","gravatar_id":"","url":"https://api.github.com/users/bblfish","html_url":"https://github.com/bblfish","followers_url":"https://api.github.com/users/bblfish/followers","following_url":"https://api.github.com/users/bblfish/following{/other_user}","gists_url":"https://api.github.com/users/bblfish/gists{/gist_id}","starred_url":"https://api.github.com/users/bblfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bblfish/subscriptions","organizations_url":"https://api.github.com/users/bblfish/orgs","repos_url":"https://api.github.com/users/bblfish/repos","events_url":"https://api.github.com/users/bblfish/events{/privacy}","received_events_url":"https://api.github.com/users/bblfish/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bblfish/scala-js-dom","description":"statically typed dom wrappers for scala-js","fork":true,"url":"https://api.github.com/repos/bblfish/scala-js-dom","forks_url":"https://api.github.com/repos/bblfish/scala-js-dom/forks","keys_url":"https://api.github.com/repos/bblfish/scala-js-dom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bblfish/scala-js-dom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bblfish/scala-js-dom/teams","hooks_url":"https://api.github.com/repos/bblfish/scala-js-dom/hooks","issue_events_url":"https://api.github.com/repos/bblfish/scala-js-dom/issues/events{/number}","events_url":"https://api.github.com/repos/bblfish/scala-js-dom/events","assignees_url":"https://api.github.com/repos/bblfish/scala-js-dom/assignees{/user}","branches_url":"https://api.github.com/repos/bblfish/scala-js-dom/branches{/branch}","tags_url":"https://api.github.com/repos/bblfish/scala-js-dom/tags","blobs_url":"https://api.github.com/repos/bblfish/scala-js-dom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bblfish/scala-js-dom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bblfish/scala-js-dom/git/refs{/sha}","trees_url":"https://api.github.com/repos/bblfish/scala-js-dom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bblfish/scala-js-dom/statuses/{sha}","languages_url":"https://api.github.com/repos/bblfish/scala-js-dom/languages","stargazers_url":"https://api.github.com/repos/bblfish/scala-js-dom/stargazers","contributors_url":"https://api.github.com/repos/bblfish/scala-js-dom/contributors","subscribers_url":"https://api.github.com/repos/bblfish/scala-js-dom/subscribers","subscription_url":"https://api.github.com/repos/bblfish/scala-js-dom/subscription","commits_url":"https://api.github.com/repos/bblfish/scala-js-dom/commits{/sha}","git_commits_url":"https://api.github.com/repos/bblfish/scala-js-dom/git/commits{/sha}","comments_url":"https://api.github.com/repos/bblfish/scala-js-dom/comments{/number}","issue_comment_url":"https://api.github.com/repos/bblfish/scala-js-dom/issues/comments{/number}","contents_url":"https://api.github.com/repos/bblfish/scala-js-dom/contents/{+path}","compare_url":"https://api.github.com/repos/bblfish/scala-js-dom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bblfish/scala-js-dom/merges","archive_url":"https://api.github.com/repos/bblfish/scala-js-dom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bblfish/scala-js-dom/downloads","issues_url":"https://api.github.com/repos/bblfish/scala-js-dom/issues{/number}","pulls_url":"https://api.github.com/repos/bblfish/scala-js-dom/pulls{/number}","milestones_url":"https://api.github.com/repos/bblfish/scala-js-dom/milestones{/number}","notifications_url":"https://api.github.com/repos/bblfish/scala-js-dom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bblfish/scala-js-dom/labels{/name}","releases_url":"https://api.github.com/repos/bblfish/scala-js-dom/releases{/id}","created_at":"2015-11-07T12:59:47Z","updated_at":"2015-11-07T12:59:48Z","pushed_at":"2015-11-08T15:52:13Z","git_url":"git://github.com/bblfish/scala-js-dom.git","ssh_url":"git@github.com:bblfish/scala-js-dom.git","clone_url":"https://github.com/bblfish/scala-js-dom.git","svn_url":"https://github.com/bblfish/scala-js-dom","homepage":null,"size":2049,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scala-js:master","ref":"master","sha":"d80ee580e532a663e3ae429c160286d3e1be4454","user":{"login":"scala-js","id":6039724,"avatar_url":"https://avatars.githubusercontent.com/u/6039724?v=3","gravatar_id":"","url":"https://api.github.com/users/scala-js","html_url":"https://github.com/scala-js","followers_url":"https://api.github.com/users/scala-js/followers","following_url":"https://api.github.com/users/scala-js/following{/other_user}","gists_url":"https://api.github.com/users/scala-js/gists{/gist_id}","starred_url":"https://api.github.com/users/scala-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala-js/subscriptions","organizations_url":"https://api.github.com/users/scala-js/orgs","repos_url":"https://api.github.com/users/scala-js/repos","events_url":"https://api.github.com/users/scala-js/events{/privacy}","received_events_url":"https://api.github.com/users/scala-js/received_events","type":"Organization","site_admin":false},"repo":{"id":13578796,"name":"scala-js-dom","full_name":"scala-js/scala-js-dom","owner":{"login":"scala-js","id":6039724,"avatar_url":"https://avatars.githubusercontent.com/u/6039724?v=3","gravatar_id":"","url":"https://api.github.com/users/scala-js","html_url":"https://github.com/scala-js","followers_url":"https://api.github.com/users/scala-js/followers","following_url":"https://api.github.com/users/scala-js/following{/other_user}","gists_url":"https://api.github.com/users/scala-js/gists{/gist_id}","starred_url":"https://api.github.com/users/scala-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala-js/subscriptions","organizations_url":"https://api.github.com/users/scala-js/orgs","repos_url":"https://api.github.com/users/scala-js/repos","events_url":"https://api.github.com/users/scala-js/events{/privacy}","received_events_url":"https://api.github.com/users/scala-js/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scala-js/scala-js-dom","description":"statically typed dom wrappers for scala-js","fork":false,"url":"https://api.github.com/repos/scala-js/scala-js-dom","forks_url":"https://api.github.com/repos/scala-js/scala-js-dom/forks","keys_url":"https://api.github.com/repos/scala-js/scala-js-dom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scala-js/scala-js-dom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scala-js/scala-js-dom/teams","hooks_url":"https://api.github.com/repos/scala-js/scala-js-dom/hooks","issue_events_url":"https://api.github.com/repos/scala-js/scala-js-dom/issues/events{/number}","events_url":"https://api.github.com/repos/scala-js/scala-js-dom/events","assignees_url":"https://api.github.com/repos/scala-js/scala-js-dom/assignees{/user}","branches_url":"https://api.github.com/repos/scala-js/scala-js-dom/branches{/branch}","tags_url":"https://api.github.com/repos/scala-js/scala-js-dom/tags","blobs_url":"https://api.github.com/repos/scala-js/scala-js-dom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scala-js/scala-js-dom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scala-js/scala-js-dom/git/refs{/sha}","trees_url":"https://api.github.com/repos/scala-js/scala-js-dom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scala-js/scala-js-dom/statuses/{sha}","languages_url":"https://api.github.com/repos/scala-js/scala-js-dom/languages","stargazers_url":"https://api.github.com/repos/scala-js/scala-js-dom/stargazers","contributors_url":"https://api.github.com/repos/scala-js/scala-js-dom/contributors","subscribers_url":"https://api.github.com/repos/scala-js/scala-js-dom/subscribers","subscription_url":"https://api.github.com/repos/scala-js/scala-js-dom/subscription","commits_url":"https://api.github.com/repos/scala-js/scala-js-dom/commits{/sha}","git_commits_url":"https://api.github.com/repos/scala-js/scala-js-dom/git/commits{/sha}","comments_url":"https://api.github.com/repos/scala-js/scala-js-dom/comments{/number}","issue_comment_url":"https://api.github.com/repos/scala-js/scala-js-dom/issues/comments{/number}","contents_url":"https://api.github.com/repos/scala-js/scala-js-dom/contents/{+path}","compare_url":"https://api.github.com/repos/scala-js/scala-js-dom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scala-js/scala-js-dom/merges","archive_url":"https://api.github.com/repos/scala-js/scala-js-dom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scala-js/scala-js-dom/downloads","issues_url":"https://api.github.com/repos/scala-js/scala-js-dom/issues{/number}","pulls_url":"https://api.github.com/repos/scala-js/scala-js-dom/pulls{/number}","milestones_url":"https://api.github.com/repos/scala-js/scala-js-dom/milestones{/number}","notifications_url":"https://api.github.com/repos/scala-js/scala-js-dom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scala-js/scala-js-dom/labels{/name}","releases_url":"https://api.github.com/repos/scala-js/scala-js-dom/releases{/id}","created_at":"2013-10-15T02:35:07Z","updated_at":"2015-11-06T22:32:18Z","pushed_at":"2015-11-08T15:58:55Z","git_url":"git://github.com/scala-js/scala-js-dom.git","ssh_url":"git@github.com:scala-js/scala-js-dom.git","clone_url":"https://github.com/scala-js/scala-js-dom.git","svn_url":"https://github.com/scala-js/scala-js-dom","homepage":null,"size":3085,"stargazers_count":97,"watchers_count":97,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":44,"mirror_url":null,"open_issues_count":16,"forks":44,"open_issues":16,"watchers":97,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scala-js/scala-js-dom/pulls/169"},"html":{"href":"https://github.com/scala-js/scala-js-dom/pull/169"},"issue":{"href":"https://api.github.com/repos/scala-js/scala-js-dom/issues/169"},"comments":{"href":"https://api.github.com/repos/scala-js/scala-js-dom/issues/169/comments"},"review_comments":{"href":"https://api.github.com/repos/scala-js/scala-js-dom/pulls/169/comments"},"review_comment":{"href":"https://api.github.com/repos/scala-js/scala-js-dom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scala-js/scala-js-dom/pulls/169/commits"},"statuses":{"href":"https://api.github.com/repos/scala-js/scala-js-dom/statuses/bf8d740bb33c48e4729bba7fb4919d0513d63808"}}}}