{"action":"created","issue":{"url":"https://api.github.com/repos/mattbryson/TouchSwipe-Jquery-Plugin/issues/209","labels_url":"https://api.github.com/repos/mattbryson/TouchSwipe-Jquery-Plugin/issues/209/labels{/name}","comments_url":"https://api.github.com/repos/mattbryson/TouchSwipe-Jquery-Plugin/issues/209/comments","events_url":"https://api.github.com/repos/mattbryson/TouchSwipe-Jquery-Plugin/issues/209/events","html_url":"https://github.com/mattbryson/TouchSwipe-Jquery-Plugin/issues/209","id":53768500,"number":209,"title":"Tap event should not fire if a user scrolls before releasing finger.","user":{"login":"raldred","id":37096,"avatar_url":"https://avatars.githubusercontent.com/u/37096?v=3","gravatar_id":"","url":"https://api.github.com/users/raldred","html_url":"https://github.com/raldred","followers_url":"https://api.github.com/users/raldred/followers","following_url":"https://api.github.com/users/raldred/following{/other_user}","gists_url":"https://api.github.com/users/raldred/gists{/gist_id}","starred_url":"https://api.github.com/users/raldred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raldred/subscriptions","organizations_url":"https://api.github.com/users/raldred/orgs","repos_url":"https://api.github.com/users/raldred/repos","events_url":"https://api.github.com/users/raldred/events{/privacy}","received_events_url":"https://api.github.com/users/raldred/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-01-08T16:19:19Z","updated_at":"2015-03-24T10:44:16Z","closed_at":null,"body":"Imagine i'm a user on a large page.\r\nThere's a button/action with a swipe tap event handler.\r\nIf I touch that button as my starting point to scrolling the page, the `tap` event on the button/action will be triggered when I let go.\r\nWhen you scroll the page \"sticks\" to your finger so you'll often trigger `touchstart` and `touchend` at the same co-ordinates. \r\n\r\nThis [Demo](http://jsbin.com/tetafi) illustrates the issue, use red button as your the scroll anchor.\r\n\r\nThis is incorrect behaviour, the `tap` event should be cancelled if actually scrolling the page.\r\n\r\nThe only way I can think of reliably detecting this is checking the `event.cancelable` boolean.\r\nThis will be false if the `touchend` event was triggered after scrolling.\r\n\r\nI have tried this in the event callbacks and it seems to work reliably.\r\nAnyone else got any suggestions?\r\n\r\nIt feels like we need a `cancelTapOnScroll` option"},"comment":{"url":"https://api.github.com/repos/mattbryson/TouchSwipe-Jquery-Plugin/issues/comments/85446507","html_url":"https://github.com/mattbryson/TouchSwipe-Jquery-Plugin/issues/209#issuecomment-85446507","issue_url":"https://api.github.com/repos/mattbryson/TouchSwipe-Jquery-Plugin/issues/209","id":85446507,"user":{"login":"lukatiks","id":2555960,"avatar_url":"https://avatars.githubusercontent.com/u/2555960?v=3","gravatar_id":"","url":"https://api.github.com/users/lukatiks","html_url":"https://github.com/lukatiks","followers_url":"https://api.github.com/users/lukatiks/followers","following_url":"https://api.github.com/users/lukatiks/following{/other_user}","gists_url":"https://api.github.com/users/lukatiks/gists{/gist_id}","starred_url":"https://api.github.com/users/lukatiks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukatiks/subscriptions","organizations_url":"https://api.github.com/users/lukatiks/orgs","repos_url":"https://api.github.com/users/lukatiks/repos","events_url":"https://api.github.com/users/lukatiks/events{/privacy}","received_events_url":"https://api.github.com/users/lukatiks/received_events","type":"User","site_admin":false},"created_at":"2015-03-24T10:44:16Z","updated_at":"2015-03-24T10:44:16Z","body":"Unfortunately it looks like my Firefox for Android 36.0.4 does not set `event.cancelable` to `false` on `touchend` after scrolling so some other scroll detection method would be needed for it.\r\n\r\nFirefox seems to send `scroll` events when scrolling, maybe they can be used?"}}