{"action":"created","comment":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/comments/24714330","id":24714330,"diff_hunk":"@@ -171,6 +168,53 @@ void RendererOpenGL::InitOpenGLObjects() {\n     glBindTexture(GL_TEXTURE_2D, 0);\n }\n \n+void RendererOpenGL::ConfigureFramebufferTexture(TextureInfo& texture,\n+                                                 const GPU::Regs::FramebufferConfig& framebuffer) const {\n+    GPU::Regs::PixelFormat format = framebuffer.color_format;\n+    GLint internal_format;\n+\n+    texture.format = format;\n+    texture.width = framebuffer.width;\n+    texture.height = framebuffer.height;\n+\n+    switch (format) {\n+    case GPU::Regs::PixelFormat::RGBA8:\n+        internal_format = GL_RGBA;\n+        texture.gl_format = GL_RGBA;\n+        texture.gl_type = GL_UNSIGNED_INT_8_8_8_8;\n+        break;\n+\n+    case GPU::Regs::PixelFormat::RGB8:\n+        // This format uses BGR since GL_UNSIGNED_BYTE specifies byte-order, instead of native-endian.","path":"src/video_core/renderer_opengl/renderer_opengl.cpp","position":68,"original_position":68,"commit_id":"958a4bc6634941e5798c6585eca5e5da986e41d3","original_commit_id":"958a4bc6634941e5798c6585eca5e5da986e41d3","user":{"login":"neobrain","id":4840017,"avatar_url":"https://avatars.githubusercontent.com/u/4840017?v=3","gravatar_id":"","url":"https://api.github.com/users/neobrain","html_url":"https://github.com/neobrain","followers_url":"https://api.github.com/users/neobrain/followers","following_url":"https://api.github.com/users/neobrain/following{/other_user}","gists_url":"https://api.github.com/users/neobrain/gists{/gist_id}","starred_url":"https://api.github.com/users/neobrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neobrain/subscriptions","organizations_url":"https://api.github.com/users/neobrain/orgs","repos_url":"https://api.github.com/users/neobrain/repos","events_url":"https://api.github.com/users/neobrain/events{/privacy}","received_events_url":"https://api.github.com/users/neobrain/received_events","type":"User","site_admin":false},"body":"Thanks for clearing this up, but... how can you speak about endianness in a 24-bit format? If OpenGL defines pixel formats via the byte order, wouldn't it make more sense for us to follow that convention as well and rename **all** pixel format enum elements accordingly?\r\n","created_at":"2015-02-14T13:13:26Z","updated_at":"2015-02-14T13:13:26Z","html_url":"https://github.com/citra-emu/citra/pull/539#discussion_r24714330","pull_request_url":"https://api.github.com/repos/citra-emu/citra/pulls/539","_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments/24714330"},"html":{"href":"https://github.com/citra-emu/citra/pull/539#discussion_r24714330"},"pull_request":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/539"}}},"pull_request":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/539","id":28774686,"html_url":"https://github.com/citra-emu/citra/pull/539","diff_url":"https://github.com/citra-emu/citra/pull/539.diff","patch_url":"https://github.com/citra-emu/citra/pull/539.patch","issue_url":"https://api.github.com/repos/citra-emu/citra/issues/539","number":539,"state":"open","locked":false,"title":"Framebuffer formats","user":{"login":"linkmauve","id":7755816,"avatar_url":"https://avatars.githubusercontent.com/u/7755816?v=3","gravatar_id":"","url":"https://api.github.com/users/linkmauve","html_url":"https://github.com/linkmauve","followers_url":"https://api.github.com/users/linkmauve/followers","following_url":"https://api.github.com/users/linkmauve/following{/other_user}","gists_url":"https://api.github.com/users/linkmauve/gists{/gist_id}","starred_url":"https://api.github.com/users/linkmauve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkmauve/subscriptions","organizations_url":"https://api.github.com/users/linkmauve/orgs","repos_url":"https://api.github.com/users/linkmauve/repos","events_url":"https://api.github.com/users/linkmauve/events{/privacy}","received_events_url":"https://api.github.com/users/linkmauve/received_events","type":"User","site_admin":false},"body":"Implement the remaining framebuffer formats in the OpenGL renderer, and rename the default format from RGB8 to BGR8, since that’s what it is.","created_at":"2015-02-06T00:16:35Z","updated_at":"2015-02-14T13:13:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73478be57c6aed1c52016bfdf5a01d846fb9f022","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/citra-emu/citra/pulls/539/commits","review_comments_url":"https://api.github.com/repos/citra-emu/citra/pulls/539/comments","review_comment_url":"https://api.github.com/repos/citra-emu/citra/pulls/comments/{number}","comments_url":"https://api.github.com/repos/citra-emu/citra/issues/539/comments","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/958a4bc6634941e5798c6585eca5e5da986e41d3","head":{"label":"linkmauve:framebuffer-formats","ref":"framebuffer-formats","sha":"958a4bc6634941e5798c6585eca5e5da986e41d3","user":{"login":"linkmauve","id":7755816,"avatar_url":"https://avatars.githubusercontent.com/u/7755816?v=3","gravatar_id":"","url":"https://api.github.com/users/linkmauve","html_url":"https://github.com/linkmauve","followers_url":"https://api.github.com/users/linkmauve/followers","following_url":"https://api.github.com/users/linkmauve/following{/other_user}","gists_url":"https://api.github.com/users/linkmauve/gists{/gist_id}","starred_url":"https://api.github.com/users/linkmauve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkmauve/subscriptions","organizations_url":"https://api.github.com/users/linkmauve/orgs","repos_url":"https://api.github.com/users/linkmauve/repos","events_url":"https://api.github.com/users/linkmauve/events{/privacy}","received_events_url":"https://api.github.com/users/linkmauve/received_events","type":"User","site_admin":false},"repo":{"id":23252208,"name":"citra","full_name":"linkmauve/citra","owner":{"login":"linkmauve","id":7755816,"avatar_url":"https://avatars.githubusercontent.com/u/7755816?v=3","gravatar_id":"","url":"https://api.github.com/users/linkmauve","html_url":"https://github.com/linkmauve","followers_url":"https://api.github.com/users/linkmauve/followers","following_url":"https://api.github.com/users/linkmauve/following{/other_user}","gists_url":"https://api.github.com/users/linkmauve/gists{/gist_id}","starred_url":"https://api.github.com/users/linkmauve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkmauve/subscriptions","organizations_url":"https://api.github.com/users/linkmauve/orgs","repos_url":"https://api.github.com/users/linkmauve/repos","events_url":"https://api.github.com/users/linkmauve/events{/privacy}","received_events_url":"https://api.github.com/users/linkmauve/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/linkmauve/citra","description":"Nintendo 3DS emulator/debugger","fork":true,"url":"https://api.github.com/repos/linkmauve/citra","forks_url":"https://api.github.com/repos/linkmauve/citra/forks","keys_url":"https://api.github.com/repos/linkmauve/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkmauve/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkmauve/citra/teams","hooks_url":"https://api.github.com/repos/linkmauve/citra/hooks","issue_events_url":"https://api.github.com/repos/linkmauve/citra/issues/events{/number}","events_url":"https://api.github.com/repos/linkmauve/citra/events","assignees_url":"https://api.github.com/repos/linkmauve/citra/assignees{/user}","branches_url":"https://api.github.com/repos/linkmauve/citra/branches{/branch}","tags_url":"https://api.github.com/repos/linkmauve/citra/tags","blobs_url":"https://api.github.com/repos/linkmauve/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkmauve/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkmauve/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkmauve/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkmauve/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/linkmauve/citra/languages","stargazers_url":"https://api.github.com/repos/linkmauve/citra/stargazers","contributors_url":"https://api.github.com/repos/linkmauve/citra/contributors","subscribers_url":"https://api.github.com/repos/linkmauve/citra/subscribers","subscription_url":"https://api.github.com/repos/linkmauve/citra/subscription","commits_url":"https://api.github.com/repos/linkmauve/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkmauve/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkmauve/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkmauve/citra/issues/comments/{number}","contents_url":"https://api.github.com/repos/linkmauve/citra/contents/{+path}","compare_url":"https://api.github.com/repos/linkmauve/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkmauve/citra/merges","archive_url":"https://api.github.com/repos/linkmauve/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkmauve/citra/downloads","issues_url":"https://api.github.com/repos/linkmauve/citra/issues{/number}","pulls_url":"https://api.github.com/repos/linkmauve/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/linkmauve/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/linkmauve/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkmauve/citra/labels{/name}","releases_url":"https://api.github.com/repos/linkmauve/citra/releases{/id}","created_at":"2014-08-23T09:07:09Z","updated_at":"2014-11-19T09:04:34Z","pushed_at":"2015-02-14T00:41:59Z","git_url":"git://github.com/linkmauve/citra.git","ssh_url":"git@github.com:linkmauve/citra.git","clone_url":"https://github.com/linkmauve/citra.git","svn_url":"https://github.com/linkmauve/citra","homepage":null,"size":7909,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"citra-emu:master","ref":"master","sha":"29a9e4ac25504bee82f273184a1afcc88a3e61e1","user":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=3","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":19866730,"name":"citra","full_name":"citra-emu/citra","owner":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=3","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/citra-emu/citra","description":"Nintendo 3DS emulator/debugger","fork":false,"url":"https://api.github.com/repos/citra-emu/citra","forks_url":"https://api.github.com/repos/citra-emu/citra/forks","keys_url":"https://api.github.com/repos/citra-emu/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/citra-emu/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/citra-emu/citra/teams","hooks_url":"https://api.github.com/repos/citra-emu/citra/hooks","issue_events_url":"https://api.github.com/repos/citra-emu/citra/issues/events{/number}","events_url":"https://api.github.com/repos/citra-emu/citra/events","assignees_url":"https://api.github.com/repos/citra-emu/citra/assignees{/user}","branches_url":"https://api.github.com/repos/citra-emu/citra/branches{/branch}","tags_url":"https://api.github.com/repos/citra-emu/citra/tags","blobs_url":"https://api.github.com/repos/citra-emu/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/citra-emu/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/citra-emu/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/citra-emu/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/citra-emu/citra/languages","stargazers_url":"https://api.github.com/repos/citra-emu/citra/stargazers","contributors_url":"https://api.github.com/repos/citra-emu/citra/contributors","subscribers_url":"https://api.github.com/repos/citra-emu/citra/subscribers","subscription_url":"https://api.github.com/repos/citra-emu/citra/subscription","commits_url":"https://api.github.com/repos/citra-emu/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/citra-emu/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/citra-emu/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/citra-emu/citra/issues/comments/{number}","contents_url":"https://api.github.com/repos/citra-emu/citra/contents/{+path}","compare_url":"https://api.github.com/repos/citra-emu/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/citra-emu/citra/merges","archive_url":"https://api.github.com/repos/citra-emu/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/citra-emu/citra/downloads","issues_url":"https://api.github.com/repos/citra-emu/citra/issues{/number}","pulls_url":"https://api.github.com/repos/citra-emu/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/citra-emu/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/citra-emu/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/citra-emu/citra/labels{/name}","releases_url":"https://api.github.com/repos/citra-emu/citra/releases{/id}","created_at":"2014-05-16T18:33:15Z","updated_at":"2015-02-14T08:43:19Z","pushed_at":"2015-02-13T20:53:34Z","git_url":"git://github.com/citra-emu/citra.git","ssh_url":"git@github.com:citra-emu/citra.git","clone_url":"https://github.com/citra-emu/citra.git","svn_url":"https://github.com/citra-emu/citra","homepage":null,"size":18728,"stargazers_count":577,"watchers_count":577,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":146,"mirror_url":null,"open_issues_count":43,"forks":146,"open_issues":43,"watchers":577,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/539"},"html":{"href":"https://github.com/citra-emu/citra/pull/539"},"issue":{"href":"https://api.github.com/repos/citra-emu/citra/issues/539"},"comments":{"href":"https://api.github.com/repos/citra-emu/citra/issues/539/comments"},"review_comments":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/539/comments"},"review_comment":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/539/commits"},"statuses":{"href":"https://api.github.com/repos/citra-emu/citra/statuses/958a4bc6634941e5798c6585eca5e5da986e41d3"}}}}