{"action":"closed","number":279,"pull_request":{"url":"https://api.github.com/repos/mapbox/carmen/pulls/279","id":37306922,"html_url":"https://github.com/mapbox/carmen/pull/279","diff_url":"https://github.com/mapbox/carmen/pull/279.diff","patch_url":"https://github.com/mapbox/carmen/pull/279.patch","issue_url":"https://api.github.com/repos/mapbox/carmen/issues/279","number":279,"state":"closed","locked":false,"title":"enable regex token replacement","user":{"login":"sbma44","id":31717,"avatar_url":"https://avatars.githubusercontent.com/u/31717?v=3","gravatar_id":"","url":"https://api.github.com/users/sbma44","html_url":"https://github.com/sbma44","followers_url":"https://api.github.com/users/sbma44/followers","following_url":"https://api.github.com/users/sbma44/following{/other_user}","gists_url":"https://api.github.com/users/sbma44/gists{/gist_id}","starred_url":"https://api.github.com/users/sbma44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbma44/subscriptions","organizations_url":"https://api.github.com/users/sbma44/orgs","repos_url":"https://api.github.com/users/sbma44/repos","events_url":"https://api.github.com/users/sbma44/events{/privacy}","received_events_url":"https://api.github.com/users/sbma44/received_events","type":"User","site_admin":false},"body":"This functionality is already somewhat in place due to the nature of current token processing -- tokens containing regex characters could already behave in unexpected ways. This PR alters that codepath to use the XRegExp module.\r\n\r\n- implement named group capture, making existing boundary checking safer and allowing for their use in replacement patterns\r\n- check for numbered groups in the input and throw errors when they are encountered (carmen introduces new groups, making the ordering dangerous--we would have to do some fancy rewrite stuff which is best avoided in favor of named groups)","created_at":"2015-06-09T22:24:35Z","updated_at":"2015-06-16T15:37:13Z","closed_at":"2015-06-16T15:37:13Z","merged_at":"2015-06-16T15:37:13Z","merge_commit_sha":"01f527b30fba749f1f244686bb2cb3169e6426ef","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mapbox/carmen/pulls/279/commits","review_comments_url":"https://api.github.com/repos/mapbox/carmen/pulls/279/comments","review_comment_url":"https://api.github.com/repos/mapbox/carmen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapbox/carmen/issues/279/comments","statuses_url":"https://api.github.com/repos/mapbox/carmen/statuses/35fe3926f2058853e96681797dbbfd1905ace855","head":{"label":"mapbox:regexpectations","ref":"regexpectations","sha":"35fe3926f2058853e96681797dbbfd1905ace855","user":{"login":"mapbox","id":600935,"avatar_url":"https://avatars.githubusercontent.com/u/600935?v=3","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":4587149,"name":"carmen","full_name":"mapbox/carmen","owner":{"login":"mapbox","id":600935,"avatar_url":"https://avatars.githubusercontent.com/u/600935?v=3","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/carmen","description":"Mapnik vector tile-based geocoder with support for swappable data sources","fork":false,"url":"https://api.github.com/repos/mapbox/carmen","forks_url":"https://api.github.com/repos/mapbox/carmen/forks","keys_url":"https://api.github.com/repos/mapbox/carmen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/carmen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/carmen/teams","hooks_url":"https://api.github.com/repos/mapbox/carmen/hooks","issue_events_url":"https://api.github.com/repos/mapbox/carmen/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/carmen/events","assignees_url":"https://api.github.com/repos/mapbox/carmen/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/carmen/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/carmen/tags","blobs_url":"https://api.github.com/repos/mapbox/carmen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/carmen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/carmen/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/carmen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/carmen/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/carmen/languages","stargazers_url":"https://api.github.com/repos/mapbox/carmen/stargazers","contributors_url":"https://api.github.com/repos/mapbox/carmen/contributors","subscribers_url":"https://api.github.com/repos/mapbox/carmen/subscribers","subscription_url":"https://api.github.com/repos/mapbox/carmen/subscription","commits_url":"https://api.github.com/repos/mapbox/carmen/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/carmen/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/carmen/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/carmen/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/carmen/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/carmen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/carmen/merges","archive_url":"https://api.github.com/repos/mapbox/carmen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/carmen/downloads","issues_url":"https://api.github.com/repos/mapbox/carmen/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/carmen/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/carmen/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/carmen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/carmen/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/carmen/releases{/id}","created_at":"2012-06-07T15:50:21Z","updated_at":"2015-05-19T20:42:25Z","pushed_at":"2015-06-16T15:37:13Z","git_url":"git://github.com/mapbox/carmen.git","ssh_url":"git@github.com:mapbox/carmen.git","clone_url":"https://github.com/mapbox/carmen.git","svn_url":"https://github.com/mapbox/carmen","homepage":"","size":18484,"stargazers_count":89,"watchers_count":89,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":25,"forks":17,"open_issues":25,"watchers":89,"default_branch":"master"}},"base":{"label":"mapbox:master","ref":"master","sha":"f53e91c7d8c7798193ab067bb233312f81385fd7","user":{"login":"mapbox","id":600935,"avatar_url":"https://avatars.githubusercontent.com/u/600935?v=3","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":4587149,"name":"carmen","full_name":"mapbox/carmen","owner":{"login":"mapbox","id":600935,"avatar_url":"https://avatars.githubusercontent.com/u/600935?v=3","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/carmen","description":"Mapnik vector tile-based geocoder with support for swappable data sources","fork":false,"url":"https://api.github.com/repos/mapbox/carmen","forks_url":"https://api.github.com/repos/mapbox/carmen/forks","keys_url":"https://api.github.com/repos/mapbox/carmen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/carmen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/carmen/teams","hooks_url":"https://api.github.com/repos/mapbox/carmen/hooks","issue_events_url":"https://api.github.com/repos/mapbox/carmen/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/carmen/events","assignees_url":"https://api.github.com/repos/mapbox/carmen/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/carmen/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/carmen/tags","blobs_url":"https://api.github.com/repos/mapbox/carmen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/carmen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/carmen/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/carmen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/carmen/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/carmen/languages","stargazers_url":"https://api.github.com/repos/mapbox/carmen/stargazers","contributors_url":"https://api.github.com/repos/mapbox/carmen/contributors","subscribers_url":"https://api.github.com/repos/mapbox/carmen/subscribers","subscription_url":"https://api.github.com/repos/mapbox/carmen/subscription","commits_url":"https://api.github.com/repos/mapbox/carmen/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/carmen/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/carmen/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/carmen/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/carmen/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/carmen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/carmen/merges","archive_url":"https://api.github.com/repos/mapbox/carmen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/carmen/downloads","issues_url":"https://api.github.com/repos/mapbox/carmen/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/carmen/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/carmen/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/carmen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/carmen/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/carmen/releases{/id}","created_at":"2012-06-07T15:50:21Z","updated_at":"2015-05-19T20:42:25Z","pushed_at":"2015-06-16T15:37:13Z","git_url":"git://github.com/mapbox/carmen.git","ssh_url":"git@github.com:mapbox/carmen.git","clone_url":"https://github.com/mapbox/carmen.git","svn_url":"https://github.com/mapbox/carmen","homepage":"","size":18484,"stargazers_count":89,"watchers_count":89,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":25,"forks":17,"open_issues":25,"watchers":89,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapbox/carmen/pulls/279"},"html":{"href":"https://github.com/mapbox/carmen/pull/279"},"issue":{"href":"https://api.github.com/repos/mapbox/carmen/issues/279"},"comments":{"href":"https://api.github.com/repos/mapbox/carmen/issues/279/comments"},"review_comments":{"href":"https://api.github.com/repos/mapbox/carmen/pulls/279/comments"},"review_comment":{"href":"https://api.github.com/repos/mapbox/carmen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapbox/carmen/pulls/279/commits"},"statuses":{"href":"https://api.github.com/repos/mapbox/carmen/statuses/35fe3926f2058853e96681797dbbfd1905ace855"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"sbma44","id":31717,"avatar_url":"https://avatars.githubusercontent.com/u/31717?v=3","gravatar_id":"","url":"https://api.github.com/users/sbma44","html_url":"https://github.com/sbma44","followers_url":"https://api.github.com/users/sbma44/followers","following_url":"https://api.github.com/users/sbma44/following{/other_user}","gists_url":"https://api.github.com/users/sbma44/gists{/gist_id}","starred_url":"https://api.github.com/users/sbma44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbma44/subscriptions","organizations_url":"https://api.github.com/users/sbma44/orgs","repos_url":"https://api.github.com/users/sbma44/repos","events_url":"https://api.github.com/users/sbma44/events{/privacy}","received_events_url":"https://api.github.com/users/sbma44/received_events","type":"User","site_admin":false},"comments":4,"review_comments":1,"commits":6,"additions":43,"deletions":8,"changed_files":3}}