{"action":"created","issue":{"url":"https://api.github.com/repos/davidgfnet/whatsapp-purple/issues/208","labels_url":"https://api.github.com/repos/davidgfnet/whatsapp-purple/issues/208/labels{/name}","comments_url":"https://api.github.com/repos/davidgfnet/whatsapp-purple/issues/208/comments","events_url":"https://api.github.com/repos/davidgfnet/whatsapp-purple/issues/208/events","html_url":"https://github.com/davidgfnet/whatsapp-purple/issues/208","id":54954360,"number":208,"title":"Geolocation wrong","user":{"login":"nesciens","id":1703518,"avatar_url":"https://avatars.githubusercontent.com/u/1703518?v=3","gravatar_id":"","url":"https://api.github.com/users/nesciens","html_url":"https://github.com/nesciens","followers_url":"https://api.github.com/users/nesciens/followers","following_url":"https://api.github.com/users/nesciens/following{/other_user}","gists_url":"https://api.github.com/users/nesciens/gists{/gist_id}","starred_url":"https://api.github.com/users/nesciens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nesciens/subscriptions","organizations_url":"https://api.github.com/users/nesciens/orgs","repos_url":"https://api.github.com/users/nesciens/repos","events_url":"https://api.github.com/users/nesciens/events{/privacy}","received_events_url":"https://api.github.com/users/nesciens/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-01-20T23:10:21Z","updated_at":"2015-01-20T23:15:31Z","closed_at":null,"body":"Functions str2dbl and dbl2str both are incorrect for circa 55% of inputs, namely for all non-integral negative inputs and non-integral inputs whose first decimal is 0. In particular, location messages are inaccurate in the western and southern hemispheres and near integral latitudes and longitudes.\r\n\r\nMoreover the use of dbl2str in query_chat_location leaks memory.\r\n\r\nFor my patch writing, how do you feel about using glib [1] or istringstreams [2] in whatsapp_purple.cc?\r\n\r\n[1] https://developer.gnome.org/glib/stable/glib-String-Utility-Functions.html#g-ascii-strtod\r\n[2] https://stackoverflow.com/questions/1333451/c-locale-independent-atof"},"comment":{"url":"https://api.github.com/repos/davidgfnet/whatsapp-purple/issues/comments/70754558","html_url":"https://github.com/davidgfnet/whatsapp-purple/issues/208#issuecomment-70754558","issue_url":"https://api.github.com/repos/davidgfnet/whatsapp-purple/issues/208","id":70754558,"user":{"login":"davidgfnet","id":3145339,"avatar_url":"https://avatars.githubusercontent.com/u/3145339?v=3","gravatar_id":"","url":"https://api.github.com/users/davidgfnet","html_url":"https://github.com/davidgfnet","followers_url":"https://api.github.com/users/davidgfnet/followers","following_url":"https://api.github.com/users/davidgfnet/following{/other_user}","gists_url":"https://api.github.com/users/davidgfnet/gists{/gist_id}","starred_url":"https://api.github.com/users/davidgfnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidgfnet/subscriptions","organizations_url":"https://api.github.com/users/davidgfnet/orgs","repos_url":"https://api.github.com/users/davidgfnet/repos","events_url":"https://api.github.com/users/davidgfnet/events{/privacy}","received_events_url":"https://api.github.com/users/davidgfnet/received_events","type":"User","site_admin":false},"created_at":"2015-01-20T23:15:31Z","updated_at":"2015-01-20T23:15:31Z","body":"Ops you're right, hehe. I should kick myself for such a basic error. Thanks again.\r\nBTW feel free to submit pull requests any time you want!"}}