{"push_id":719061820,"size":18,"distinct_size":10,"ref":"refs/heads/seclabels2","head":"3e206018b3af20e1cc1e3ef9e03f49b05fccc9d9","before":"2348baa067bd22ace6993cb9d317bd72e1f11849","commits":[{"sha":"848ab685f74afae102e265108518095942ecb293","author":{"email":"23d9981432efa88691fd2a71f5525bc2174f7664@redhat.com","name":"Luyao Huang"},"message":"virsh: report error if vcpu number exceed the guest maxvcpu number\n\nCommit id '81dd81e' caused a regression when attempting to print a\nspecific vcpuid that is out of the range of the maximum vcpus for\nthe guest, such as:\n\n $ virsh vcpupin $dom 1000\n VCPU: CPU Affinity\n ----------------------------------\n\n $\n\nRather than just recover the old message, let's adjust the message based\non what would be displayed for a similar failure in the set path, such as:\n\n $ virsh vcpupin $dom 1000\n error: vcpu 1000 is out of range of persistent cpu count 2\n\n $ virsh vcpupin $dom 1000 --live\n error: vcpu 1000 is out of range of live cpu count 2\n\n $\n\nSigned-off-by: Luyao Huang <lhuang@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/848ab685f74afae102e265108518095942ecb293"},{"sha":"2c05841246e30205d06cc186b1ba7434d2bae880","author":{"email":"87558058f6f829e5ec976c8ef960720af4ff9c7d@redhat.com","name":"John Ferlan"},"message":"util: Avoid Coverity FORWARD_NULL\n\nAvoid a false positive since Coverity find a path in virResizeN which\ncould return 0 prior to the allocation of memory and thus flags a\npossible NULL dereference. Instead allocate the output buffer based\non 'nparams' and only fill it partially if need be - shouldn't be too\nmuch a waste of space. Quicker than multiple VIR_RESIZE_N calls or\ntwo loops of STREQ's sandwiched around a single VIR_ALLOC_N using\n'n' matches from a first loop to generate the 'n' addresses to return\n\nSigned-off-by: John Ferlan <jferlan@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/2c05841246e30205d06cc186b1ba7434d2bae880"},{"sha":"2854079496d29dd482a8c301fd4cecf5fa45515f","author":{"email":"7fa0e2698a05be944b362bdf5d7736c0162e16c9@virtuozzo.com","name":"Nikolay Shirokovskiy"},"message":"vz: fix SDK event dispatching\n\nCurrent version of SDK event dispatcing is incorrect. For most VM events (add,\ndelete etc) issuer type is PIE_DISPATCHER. Actually analyzing issuer type\ndoesn't have any benifints so this patch get rid of it. All dispatching is done\nonly on event type.\n\nSigned-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/2854079496d29dd482a8c301fd4cecf5fa45515f"},{"sha":"d51876bc8e10d1f8872b28cea113b97018bddb1f","author":{"email":"8c3f1b821d9adf233f787f1527ecaa1537ea24a2@redhat.com","name":"Daniel Veillard"},"message":"Avoid XSS vulnerability on the search engine\n\nRaised by https://www.xssposed.org/incidents/69566/\nNeed to escape the user provided query before displaying it back","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/d51876bc8e10d1f8872b28cea113b97018bddb1f"},{"sha":"cf739b35682305e69a8218731507084535d5e846","author":{"email":"8c3f1b821d9adf233f787f1527ecaa1537ea24a2@redhat.com","name":"Daniel Veillard"},"message":"better patch for the XSS search issue\n\nSince the query string could be output when displaying the results too","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/cf739b35682305e69a8218731507084535d5e846"},{"sha":"d28fefc66a29e0185a849e5205cbfc1c9e961bfa","author":{"email":"d4772d05997b8abf035041e3b4f4996380ea7e7a@redhat.com","name":"Pavel Hrdina"},"message":"qemu_driver: live/config checks cleanup\n\nSigned-off-by: Pavel Hrdina <phrdina@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/d28fefc66a29e0185a849e5205cbfc1c9e961bfa"},{"sha":"651426e93ec49dd0fc891ff1c511b0f7f843a143","author":{"email":"82bcdc4bd8b0265ee488eb5c489ce233d2f86b5c@parallels.com","name":"Dmitry Guryanov"},"message":"vz: fix building capabilities\n\nThere should be at least one domain for each guest\nin cababilities. And in current code we don't add\ndomain for this guest for example.\n\n    if ((guest = virCapabilitiesAddGuest(caps, VIR_DOMAIN_OSTYPE_HVM,\n                                         VIR_ARCH_X86_64,\n                                         \"vz\",\n                                         NULL, 0, NULL)) == NULL)\n\nAnyway, with two virt types it looks a litte messy, so let's\nmove adding guest and domain to a separate function.\n\nSigned-off-by: Dmitry Guryanov <dguryanov@parallels.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/651426e93ec49dd0fc891ff1c511b0f7f843a143"},{"sha":"beddef3967164d4feb98a6d522377803663821d4","author":{"email":"6088ba5510a617d695c444b15f13426d8a9a8aa0@virtuozzo.com","name":"Mikhail Feoktistov"},"message":"vz: assign static IPs and default gateways for network adapter\n\nWe support only one IPv4 and one IPv6 default gateway.\nIf static IPs are not present in instance config,\nthen we switch on DHCP for this adapter.\nPrlVmDevNet_SetAutoApply to makes necessary settings within guest OS\nIn linux case it creates network startup scripts\n/etc/sysconfig/network-scripts/ifcfg-ethN and fills it with necessary\nparameters.","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/beddef3967164d4feb98a6d522377803663821d4"},{"sha":"69d08aa79123962ddd977ba68c55fcabd07b2c0f","author":{"email":"83d82aaba2eed257f4814b0c239c260c4caaadf0@redhat.com","name":"Michal Privoznik"},"message":"locking: Allow seclabel remembering\n\nTo keep original seclabel for files libvirt is touching we need a\nsingle point where the original seclabels can be stored. Instead\nof inventing a new one we can misuse virtlockd which already has\nnearly all the infrastructure we need. As nice feature, it keeps\nits internal state between virtlockd restarts. Again, it's\nsomething we are going to need, as we don't want to lose the\noriginal labels on the lock daemon restart.\n\nIn this commit two functions are introduced:\n\nvirLockManagerRememberSeclabel that takes three arguments:\n\n    path, model and seclabel\n\nwhere @path is unique identifier for the file we are about to\nlabel, @model and @seclabel then represents original seclabel.\n\nvirLockManagerRecallSeclabel then takes:\n\n    path, model, *seclabel\n\nand returns number of references held on @path. If the return\nvalue is zero, *seclabel contains the original label stored by\nfirst call of RememberSeclabel(). If a positive value is\nreturned, other domains are still using the @path and the\noriginal label shall not be restored.\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":true,"url":"https://api.github.com/repos/zippy2/libvirt/commits/69d08aa79123962ddd977ba68c55fcabd07b2c0f"},{"sha":"44c80b4595907ca1e854a5d458b9adba2cd3b654","author":{"email":"83d82aaba2eed257f4814b0c239c260c4caaadf0@redhat.com","name":"Michal Privoznik"},"message":"locking: Implement seclabel stubs for NOP\n\nThe NOP drivers needs implementation, although the function\nbodies are empty. This is because the virLockManager APIs check\nfor driver implementation and returns an error if there's none.\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":true,"url":"https://api.github.com/repos/zippy2/libvirt/commits/44c80b4595907ca1e854a5d458b9adba2cd3b654"},{"sha":"a9e53cd7912d608638e061fff43a1a2928d3581b","author":{"email":"83d82aaba2eed257f4814b0c239c260c4caaadf0@redhat.com","name":"Michal Privoznik"},"message":"domain_lock: Introduce seclabel APIs\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":true,"url":"https://api.github.com/repos/zippy2/libvirt/commits/a9e53cd7912d608638e061fff43a1a2928d3581b"},{"sha":"109362d2b46c6ce61f9860973d670d58951fb238","author":{"email":"83d82aaba2eed257f4814b0c239c260c4caaadf0@redhat.com","name":"Michal Privoznik"},"message":"locking: Add virLockSeclabelProtocol\n\nSo far no ConnectOpen() is introduced as it's not needed for such\nsimple use case like this. It's crucial to separate this from\nvirLockSpace program that already exists. Not only it requires\nvirDomainObjPtr for its ConnectOpen() (subsequently all security\ndrivers would need rework as they use virDomainDefPtr), but from\nnature of things it doesn't belong there either. virLockSpace handles\ndisk locking, not labeling and it's not clean to pollute its\nnamespace anyway.\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":true,"url":"https://api.github.com/repos/zippy2/libvirt/commits/109362d2b46c6ce61f9860973d670d58951fb238"},{"sha":"aa3e58a102c5bf3f4001704ac361000007920e62","author":{"email":"83d82aaba2eed257f4814b0c239c260c4caaadf0@redhat.com","name":"Michal Privoznik"},"message":"driver_lockd: Implement seclabel APIs\n\nThis is the client side, so there's nothing more we need to do\nthan call the RPC. Although, there's one interesting change: new\nvirLockManagerLockSeclabelConnect() had to be implemented since the\nVIR_LOCK_SPACE_PROTOCOL_PROGRAM doesn't have any ConnectOpen()\nprocedure.\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":true,"url":"https://api.github.com/repos/zippy2/libvirt/commits/aa3e58a102c5bf3f4001704ac361000007920e62"},{"sha":"1ebb651ebe66f40016a6609d0ddd1abe09321f1e","author":{"email":"83d82aaba2eed257f4814b0c239c260c4caaadf0@redhat.com","name":"Michal Privoznik"},"message":"lock_daemon: Implement server dispatch\n\nAnd register the program, finally. Although, only stub\nimplementation of the Remember() and Recall() functions\nis added. The real implementation will follow.\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":true,"url":"https://api.github.com/repos/zippy2/libvirt/commits/1ebb651ebe66f40016a6609d0ddd1abe09321f1e"},{"sha":"25dc7b84b20bebb8058c6d911944fd3a39e5128c","author":{"email":"83d82aaba2eed257f4814b0c239c260c4caaadf0@redhat.com","name":"Michal Privoznik"},"message":"lock_daemon: Implement seclabel APIs\n\nThe most interesting part where all the hard work takes place.\n\nFor storing triplets of strings a two dimensional table would be\nthe most intuitive approach. Or, if the triplet is rearranged\ninto pair of one string and a pair, a hash table can be used. But\nhey, we already have those! Excellent. In other words,\n\n        <path, model, seclabel>\n\nis turned into:\n\n        <path, <model, seclabel>>\n\nThe @path is then the key that the hash table is filled with. The\ninner pair is turned into linked list (hash table in a hash table\nwould be awful really). Moreover, we need to store yet another\nitem: reference counter.\n\nWhile virtlockd holds internal state in a JSON file between, this\nfeature is honored too.\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":true,"url":"https://api.github.com/repos/zippy2/libvirt/commits/25dc7b84b20bebb8058c6d911944fd3a39e5128c"},{"sha":"1578597b6ef12e6f158c8a0fd5c4f4321d109827","author":{"email":"83d82aaba2eed257f4814b0c239c260c4caaadf0@redhat.com","name":"Michal Privoznik"},"message":"security_dac: Cleanup virSecurityDACSetOwnershipInternal usage\n\nWe have nice wrappers over internal function that eventually\ncalls the Internal() function, but for future work it's better to\ncall those wrappers instead of the internal function directly.\nThis is due to fact that the wrappers differentiate between\nsetting or restoring the label while the internal function does\nnot.\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":true,"url":"https://api.github.com/repos/zippy2/libvirt/commits/1578597b6ef12e6f158c8a0fd5c4f4321d109827"},{"sha":"cd46594a28615c7111069c28f41a7b063fa2659e","author":{"email":"83d82aaba2eed257f4814b0c239c260c4caaadf0@redhat.com","name":"Michal Privoznik"},"message":"virSecurityManagerNew: Add virLockManagerPluginPtr\n\nFor future work it's crucial to have virLockManagerPluginPtr\nstored in virSecurityDriver. Therefore, we must pass it when\ncreating the security driver.\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":true,"url":"https://api.github.com/repos/zippy2/libvirt/commits/cd46594a28615c7111069c28f41a7b063fa2659e"},{"sha":"3e206018b3af20e1cc1e3ef9e03f49b05fccc9d9","author":{"email":"83d82aaba2eed257f4814b0c239c260c4caaadf0@redhat.com","name":"Michal Privoznik"},"message":"security_dac: Keep original label\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":true,"url":"https://api.github.com/repos/zippy2/libvirt/commits/3e206018b3af20e1cc1e3ef9e03f49b05fccc9d9"}]}