{"action":"created","issue":{"url":"https://api.github.com/repos/weaveworks/weave/issues/1522","labels_url":"https://api.github.com/repos/weaveworks/weave/issues/1522/labels{/name}","comments_url":"https://api.github.com/repos/weaveworks/weave/issues/1522/comments","events_url":"https://api.github.com/repos/weaveworks/weave/issues/1522/events","html_url":"https://github.com/weaveworks/weave/pull/1522","id":110927834,"number":1522,"title":"Fast datapath compatibility with 1.1","user":{"login":"dpw","id":15074,"avatar_url":"https://avatars.githubusercontent.com/u/15074?v=3","gravatar_id":"","url":"https://api.github.com/users/dpw","html_url":"https://github.com/dpw","followers_url":"https://api.github.com/users/dpw/followers","following_url":"https://api.github.com/users/dpw/following{/other_user}","gists_url":"https://api.github.com/users/dpw/gists{/gist_id}","starred_url":"https://api.github.com/users/dpw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpw/subscriptions","organizations_url":"https://api.github.com/users/dpw/orgs","repos_url":"https://api.github.com/users/dpw/repos","events_url":"https://api.github.com/users/dpw/events{/privacy}","received_events_url":"https://api.github.com/users/dpw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"awh","id":1504438,"avatar_url":"https://avatars.githubusercontent.com/u/1504438?v=3","gravatar_id":"","url":"https://api.github.com/users/awh","html_url":"https://github.com/awh","followers_url":"https://api.github.com/users/awh/followers","following_url":"https://api.github.com/users/awh/following{/other_user}","gists_url":"https://api.github.com/users/awh/gists{/gist_id}","starred_url":"https://api.github.com/users/awh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awh/subscriptions","organizations_url":"https://api.github.com/users/awh/orgs","repos_url":"https://api.github.com/users/awh/repos","events_url":"https://api.github.com/users/awh/events{/privacy}","received_events_url":"https://api.github.com/users/awh/received_events","type":"User","site_admin":false},"milestone":null,"comments":4,"created_at":"2015-10-12T08:17:45Z","updated_at":"2015-10-12T22:08:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/weaveworks/weave/pulls/1522","html_url":"https://github.com/weaveworks/weave/pull/1522","diff_url":"https://github.com/weaveworks/weave/pull/1522.diff","patch_url":"https://github.com/weaveworks/weave/pull/1522.patch"},"body":"This is stacked on top of the fdp-rebase branch, so should not be merged until after #1438.\r\n\r\nAddresses #1448.  Compatibility with 1.1 is intended to \"just work\", so that we won't need to explain any special procedure for doing rolling upgrades to 1.2."},"comment":{"url":"https://api.github.com/repos/weaveworks/weave/issues/comments/147534713","html_url":"https://github.com/weaveworks/weave/pull/1522#issuecomment-147534713","issue_url":"https://api.github.com/repos/weaveworks/weave/issues/1522","id":147534713,"user":{"login":"rade","id":109109,"avatar_url":"https://avatars.githubusercontent.com/u/109109?v=3","gravatar_id":"","url":"https://api.github.com/users/rade","html_url":"https://github.com/rade","followers_url":"https://api.github.com/users/rade/followers","following_url":"https://api.github.com/users/rade/following{/other_user}","gists_url":"https://api.github.com/users/rade/gists{/gist_id}","starred_url":"https://api.github.com/users/rade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rade/subscriptions","organizations_url":"https://api.github.com/users/rade/orgs","repos_url":"https://api.github.com/users/rade/repos","events_url":"https://api.github.com/users/rade/events{/privacy}","received_events_url":"https://api.github.com/users/rade/received_events","type":"User","site_admin":false},"created_at":"2015-10-12T22:08:20Z","updated_at":"2015-10-12T22:08:20Z","body":"> the places where we generate random short ids\r\n\r\nafaict there are two functions - `Peers.chooseShortID` and `randomPeerShortyID` - that would be affected. These are *already* affected by the +/-1 change. Yes, the code to produce random numbers in the range 1-4095 is more complicated than for 0-4095, but it would eliminate the +/-1 in the fastdp code."}}