{"action":"created","issue":{"url":"https://api.github.com/repos/jrburke/r.js/issues/809","labels_url":"https://api.github.com/repos/jrburke/r.js/issues/809/labels{/name}","comments_url":"https://api.github.com/repos/jrburke/r.js/issues/809/comments","events_url":"https://api.github.com/repos/jrburke/r.js/issues/809/events","html_url":"https://github.com/jrburke/r.js/issues/809","id":74222616,"number":809,"title":"Can't get \"inlineText\" to work","user":{"login":"JasperTey","id":1280844,"avatar_url":"https://avatars.githubusercontent.com/u/1280844?v=3","gravatar_id":"","url":"https://api.github.com/users/JasperTey","html_url":"https://github.com/JasperTey","followers_url":"https://api.github.com/users/JasperTey/followers","following_url":"https://api.github.com/users/JasperTey/following{/other_user}","gists_url":"https://api.github.com/users/JasperTey/gists{/gist_id}","starred_url":"https://api.github.com/users/JasperTey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JasperTey/subscriptions","organizations_url":"https://api.github.com/users/JasperTey/orgs","repos_url":"https://api.github.com/users/JasperTey/repos","events_url":"https://api.github.com/users/JasperTey/events{/privacy}","received_events_url":"https://api.github.com/users/JasperTey/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-05-08T04:12:14Z","updated_at":"2015-05-26T18:39:39Z","closed_at":"2015-05-26T16:51:52Z","body":"I can't get the `inlineText: true` functionality to work as expected. Searching past issues, I'm experiencing the same thing as #279, except in my case, `findNestedDependencies: true` is already set, and my `text!` includes are direct define() dependencies.\r\n\r\nAn example of one of the modules in question:\r\n\r\n```\r\ndefine([\r\n    'knockout',\r\n    'text!./templates/heatmap.html',\r\n    'jquery',\r\n    'underscore',\r\n    'moment',\r\n    'ko/dates',\r\n    'ko/components',\r\n    'mapping'\r\n], function (ko, htmlString, $, _, moment) {\r\n   // Module code ...\r\n});\r\n```\r\n\r\nThe resulting built module does not end up inlining `text!./templates/heatmap.html`, unless I configure it manually using the `modules` option in my build config.\r\n\r\nOut of curiosity, I even tried using the full path to the text template instead of the relative path (./). That didn't make a difference.\r\n\r\nI'm stumped. What am I missing here?"},"comment":{"url":"https://api.github.com/repos/jrburke/r.js/issues/comments/105629777","html_url":"https://github.com/jrburke/r.js/issues/809#issuecomment-105629777","issue_url":"https://api.github.com/repos/jrburke/r.js/issues/809","id":105629777,"user":{"login":"jrburke","id":73359,"avatar_url":"https://avatars.githubusercontent.com/u/73359?v=3","gravatar_id":"","url":"https://api.github.com/users/jrburke","html_url":"https://github.com/jrburke","followers_url":"https://api.github.com/users/jrburke/followers","following_url":"https://api.github.com/users/jrburke/following{/other_user}","gists_url":"https://api.github.com/users/jrburke/gists{/gist_id}","starred_url":"https://api.github.com/users/jrburke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrburke/subscriptions","organizations_url":"https://api.github.com/users/jrburke/orgs","repos_url":"https://api.github.com/users/jrburke/repos","events_url":"https://api.github.com/users/jrburke/events{/privacy}","received_events_url":"https://api.github.com/users/jrburke/received_events","type":"User","site_admin":false},"created_at":"2015-05-26T18:39:39Z","updated_at":"2015-05-26T18:39:39Z","body":"There is no includeOnly, the idea being that there is likely a top level set of optimized bundles, like the one including knockout, jquery, etc. and that whole bundle can be excluded from a subsequent modules: entry like so:\r\n\r\n```javascript\r\nmodules: [{\r\n  // This main modules target ends up including base libs\r\n  // like jquery knockout, etc.\r\n  name: 'main'\r\n}, {\r\n  name: 'modules/heatmap',\r\n  // This will exclude all the modules that were traced and\r\n  // and included in the 'main' modules layer.\r\n  exclude: ['main']\r\n}]\r\n```\r\n\r\nIf you want more fine grained module combining and exclusions, controlled imperatively with your own build code (and therefore the own build code responsible for final file writes), [amodro-trace](https://github.com/amodrojs/amodro-trace) might be a better option.\r\n\r\nAs to the relative path in modules config, those IDs are top level, absolute IDs, and given that the baseUrl was set to the 'js' directly, IIRC, then asking for './something' at the top level of the ID space will get normalized to 'something' and then to turn that to a path, baseUrl is added to it, so ends up with a 'js/something.js' path. To avoid confusion though absolute IDs are recommended for build config, since it is specified outside of a module and therefore does not have a relative reference."}}