{"action":"created","issue":{"url":"https://api.github.com/repos/node-red/node-red/issues/622","labels_url":"https://api.github.com/repos/node-red/node-red/issues/622/labels{/name}","comments_url":"https://api.github.com/repos/node-red/node-red/issues/622/comments","events_url":"https://api.github.com/repos/node-red/node-red/issues/622/events","html_url":"https://github.com/node-red/node-red/issues/622","id":69778195,"number":622,"title":"SerialPort Out: \"Add Split Character\" broken","user":{"login":"bramleyd","id":6122143,"avatar_url":"https://avatars.githubusercontent.com/u/6122143?v=3","gravatar_id":"","url":"https://api.github.com/users/bramleyd","html_url":"https://github.com/bramleyd","followers_url":"https://api.github.com/users/bramleyd/followers","following_url":"https://api.github.com/users/bramleyd/following{/other_user}","gists_url":"https://api.github.com/users/bramleyd/gists{/gist_id}","starred_url":"https://api.github.com/users/bramleyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bramleyd/subscriptions","organizations_url":"https://api.github.com/users/bramleyd/orgs","repos_url":"https://api.github.com/users/bramleyd/repos","events_url":"https://api.github.com/users/bramleyd/events{/privacy}","received_events_url":"https://api.github.com/users/bramleyd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-21T08:10:21Z","updated_at":"2015-04-21T08:19:53Z","closed_at":null,"body":"The serial-out node is no longer adding the separator character in 0.10.6.\r\n\r\nIssue looks to be comparing boolean addchar to string \"true\".  Guessing this was introduced when the Add Separator to Output option was changed from Dropdown to checkbox.\r\n\r\nThe following change in serial.js has fixed the problem for me:\r\n\r\nChange:\r\nif (node.serialConfig.addchar == \"true\") {\r\n   node.addCh = this.serialConfig.newline.replace(\"\\\\n\",\"\\n\").replace(\"\\\\r\",\"\\r\").replace(\"\\\\t\",\"\\t\").replace(\"\\\\e\",\"\\e\").replace(\"\\\\f\",\"\\f\").replace(\"\\\\0\",\"\\0\");\r\n }\r\n\r\nto:\r\n\r\nif (node.serialConfig.addchar == true) {\r\n\t\t\t\t\r\n                node.addCh = this.serialConfig.newline.replace(\"\\\\n\",\"\\n\").replace(\"\\\\r\",\"\\r\").replace(\"\\\\t\",\"\\t\").replace(\"\\\\e\",\"\\e\").replace(\"\\\\f\",\"\\f\").replace(\"\\\\0\",\"\\0\");\r\n }\r\n"},"comment":{"url":"https://api.github.com/repos/node-red/node-red/issues/comments/94699809","html_url":"https://github.com/node-red/node-red/issues/622#issuecomment-94699809","issue_url":"https://api.github.com/repos/node-red/node-red/issues/622","id":94699809,"user":{"login":"knolleary","id":51083,"avatar_url":"https://avatars.githubusercontent.com/u/51083?v=3","gravatar_id":"","url":"https://api.github.com/users/knolleary","html_url":"https://github.com/knolleary","followers_url":"https://api.github.com/users/knolleary/followers","following_url":"https://api.github.com/users/knolleary/following{/other_user}","gists_url":"https://api.github.com/users/knolleary/gists{/gist_id}","starred_url":"https://api.github.com/users/knolleary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knolleary/subscriptions","organizations_url":"https://api.github.com/users/knolleary/orgs","repos_url":"https://api.github.com/users/knolleary/repos","events_url":"https://api.github.com/users/knolleary/events{/privacy}","received_events_url":"https://api.github.com/users/knolleary/received_events","type":"User","site_admin":false},"created_at":"2015-04-21T08:19:53Z","updated_at":"2015-04-21T08:19:53Z","body":"Hmm, this appears like it was broken back in November, so all of the 0.10.x releases would have been similar affected.\r\n\r\nApologies - fix forthcoming.\r\n\r\n"}}