{"action":"closed","number":12385,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/12385","id":50433762,"html_url":"https://github.com/cms-sw/cmssw/pull/12385","diff_url":"https://github.com/cms-sw/cmssw/pull/12385.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/12385.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/12385","number":12385,"state":"closed","locked":false,"title":"SiStrip unpacker corrupted buffer fix","user":{"login":"forthommel","id":330969,"avatar_url":"https://avatars.githubusercontent.com/u/330969?v=3","gravatar_id":"","url":"https://api.github.com/users/forthommel","html_url":"https://github.com/forthommel","followers_url":"https://api.github.com/users/forthommel/followers","following_url":"https://api.github.com/users/forthommel/following{/other_user}","gists_url":"https://api.github.com/users/forthommel/gists{/gist_id}","starred_url":"https://api.github.com/users/forthommel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forthommel/subscriptions","organizations_url":"https://api.github.com/users/forthommel/orgs","repos_url":"https://api.github.com/users/forthommel/repos","events_url":"https://api.github.com/users/forthommel/events{/privacy}","received_events_url":"https://api.github.com/users/forthommel/received_events","type":"User","site_admin":false},"body":"The FEDBuffer object modified in #12157 to introduce the new FED readout modes was feeding corrupted data due to an improperly set variable (the switch between the legacy unpacker and its updated version). \r\nAlso, the packet code returned in the case of a ZS lite format was improperly set.\r\n\r\nThis commit has been tested against 4.53 and 140.53, and the baseline behaviour on the list of corrupted FED (<7_5_5) has been restored (4.53):\r\n\r\n![fedvsapvid](https://cloud.githubusercontent.com/assets/330969/11102394/9192305c-88bc-11e5-8c87-d96b6b29dd27.png)\r\n![corruptedfeds](https://cloud.githubusercontent.com/assets/330969/11102398/9b8d1040-88bc-11e5-8c0e-1b3558d33eea.png)\r\n\r\n","created_at":"2015-11-11T20:44:20Z","updated_at":"2015-11-12T13:17:23Z","closed_at":"2015-11-12T13:17:22Z","merged_at":"2015-11-12T13:17:22Z","merge_commit_sha":"13fc6736a816173c886ab7d3cce0e01cb3718826","assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/51","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_7_5_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/51/labels","id":982516,"number":51,"title":"Next CMSSW_7_5_X","description":"","creator":{"login":"nclopezo","id":1944922,"avatar_url":"https://avatars.githubusercontent.com/u/1944922?v=3","gravatar_id":"","url":"https://api.github.com/users/nclopezo","html_url":"https://github.com/nclopezo","followers_url":"https://api.github.com/users/nclopezo/followers","following_url":"https://api.github.com/users/nclopezo/following{/other_user}","gists_url":"https://api.github.com/users/nclopezo/gists{/gist_id}","starred_url":"https://api.github.com/users/nclopezo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nclopezo/subscriptions","organizations_url":"https://api.github.com/users/nclopezo/orgs","repos_url":"https://api.github.com/users/nclopezo/repos","events_url":"https://api.github.com/users/nclopezo/events{/privacy}","received_events_url":"https://api.github.com/users/nclopezo/received_events","type":"User","site_admin":false},"open_issues":40,"closed_issues":1505,"state":"open","created_at":"2015-02-17T08:21:25Z","updated_at":"2015-11-12T13:17:22Z","due_on":"2015-05-31T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/12385/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/12385/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/12385/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/ad3da7bb4c949638b9c398709553d4d22ae1bc98","head":{"label":"forthommel:from-CMSSW_7_5_5","ref":"from-CMSSW_7_5_5","sha":"ad3da7bb4c949638b9c398709553d4d22ae1bc98","user":{"login":"forthommel","id":330969,"avatar_url":"https://avatars.githubusercontent.com/u/330969?v=3","gravatar_id":"","url":"https://api.github.com/users/forthommel","html_url":"https://github.com/forthommel","followers_url":"https://api.github.com/users/forthommel/followers","following_url":"https://api.github.com/users/forthommel/following{/other_user}","gists_url":"https://api.github.com/users/forthommel/gists{/gist_id}","starred_url":"https://api.github.com/users/forthommel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forthommel/subscriptions","organizations_url":"https://api.github.com/users/forthommel/orgs","repos_url":"https://api.github.com/users/forthommel/repos","events_url":"https://api.github.com/users/forthommel/events{/privacy}","received_events_url":"https://api.github.com/users/forthommel/received_events","type":"User","site_admin":false},"repo":{"id":13650413,"name":"cmssw","full_name":"forthommel/cmssw","owner":{"login":"forthommel","id":330969,"avatar_url":"https://avatars.githubusercontent.com/u/330969?v=3","gravatar_id":"","url":"https://api.github.com/users/forthommel","html_url":"https://github.com/forthommel","followers_url":"https://api.github.com/users/forthommel/followers","following_url":"https://api.github.com/users/forthommel/following{/other_user}","gists_url":"https://api.github.com/users/forthommel/gists{/gist_id}","starred_url":"https://api.github.com/users/forthommel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forthommel/subscriptions","organizations_url":"https://api.github.com/users/forthommel/orgs","repos_url":"https://api.github.com/users/forthommel/repos","events_url":"https://api.github.com/users/forthommel/events{/privacy}","received_events_url":"https://api.github.com/users/forthommel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/forthommel/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/forthommel/cmssw","forks_url":"https://api.github.com/repos/forthommel/cmssw/forks","keys_url":"https://api.github.com/repos/forthommel/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/forthommel/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/forthommel/cmssw/teams","hooks_url":"https://api.github.com/repos/forthommel/cmssw/hooks","issue_events_url":"https://api.github.com/repos/forthommel/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/forthommel/cmssw/events","assignees_url":"https://api.github.com/repos/forthommel/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/forthommel/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/forthommel/cmssw/tags","blobs_url":"https://api.github.com/repos/forthommel/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/forthommel/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/forthommel/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/forthommel/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/forthommel/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/forthommel/cmssw/languages","stargazers_url":"https://api.github.com/repos/forthommel/cmssw/stargazers","contributors_url":"https://api.github.com/repos/forthommel/cmssw/contributors","subscribers_url":"https://api.github.com/repos/forthommel/cmssw/subscribers","subscription_url":"https://api.github.com/repos/forthommel/cmssw/subscription","commits_url":"https://api.github.com/repos/forthommel/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/forthommel/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/forthommel/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/forthommel/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/forthommel/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/forthommel/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/forthommel/cmssw/merges","archive_url":"https://api.github.com/repos/forthommel/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/forthommel/cmssw/downloads","issues_url":"https://api.github.com/repos/forthommel/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/forthommel/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/forthommel/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/forthommel/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/forthommel/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/forthommel/cmssw/releases{/id}","created_at":"2013-10-17T13:55:38Z","updated_at":"2015-02-07T09:45:33Z","pushed_at":"2015-11-11T23:32:33Z","git_url":"git://github.com/forthommel/cmssw.git","ssh_url":"git@github.com:forthommel/cmssw.git","clone_url":"https://github.com/forthommel/cmssw.git","svn_url":"https://github.com/forthommel/cmssw","homepage":"cms-sw.github.io/cmssw","size":767478,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"CMSSW_7_0_X"}},"base":{"label":"cms-sw:CMSSW_7_5_X","ref":"CMSSW_7_5_X","sha":"10ca840124f688e353b07dcd0954f27d0f8e11f9","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","created_at":"2013-06-26T14:09:07Z","updated_at":"2015-11-08T07:56:28Z","pushed_at":"2015-11-12T13:17:23Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":1321305,"stargazers_count":269,"watchers_count":269,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1620,"mirror_url":null,"open_issues_count":263,"forks":1620,"open_issues":263,"watchers":269,"default_branch":"CMSSW_8_0_X"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/12385"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/12385"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/12385"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/12385/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/12385/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/12385/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/ad3da7bb4c949638b9c398709553d4d22ae1bc98"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"davidlange6","id":5042883,"avatar_url":"https://avatars.githubusercontent.com/u/5042883?v=3","gravatar_id":"","url":"https://api.github.com/users/davidlange6","html_url":"https://github.com/davidlange6","followers_url":"https://api.github.com/users/davidlange6/followers","following_url":"https://api.github.com/users/davidlange6/following{/other_user}","gists_url":"https://api.github.com/users/davidlange6/gists{/gist_id}","starred_url":"https://api.github.com/users/davidlange6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidlange6/subscriptions","organizations_url":"https://api.github.com/users/davidlange6/orgs","repos_url":"https://api.github.com/users/davidlange6/repos","events_url":"https://api.github.com/users/davidlange6/events{/privacy}","received_events_url":"https://api.github.com/users/davidlange6/received_events","type":"User","site_admin":false},"comments":8,"review_comments":0,"commits":1,"additions":5,"deletions":15,"changed_files":7}}