{"action":"opened","issue":{"url":"https://api.github.com/repos/girder/girder/issues/717","labels_url":"https://api.github.com/repos/girder/girder/issues/717/labels{/name}","comments_url":"https://api.github.com/repos/girder/girder/issues/717/comments","events_url":"https://api.github.com/repos/girder/girder/issues/717/events","html_url":"https://github.com/girder/girder/issues/717","id":59836793,"number":717,"title":"Enhance style tests to detect variable names which shadow Python builtins","user":{"login":"brianhelba","id":1282879,"avatar_url":"https://avatars.githubusercontent.com/u/1282879?v=3","gravatar_id":"","url":"https://api.github.com/users/brianhelba","html_url":"https://github.com/brianhelba","followers_url":"https://api.github.com/users/brianhelba/followers","following_url":"https://api.github.com/users/brianhelba/following{/other_user}","gists_url":"https://api.github.com/users/brianhelba/gists{/gist_id}","starred_url":"https://api.github.com/users/brianhelba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianhelba/subscriptions","organizations_url":"https://api.github.com/users/brianhelba/orgs","repos_url":"https://api.github.com/users/brianhelba/repos","events_url":"https://api.github.com/users/brianhelba/events{/privacy}","received_events_url":"https://api.github.com/users/brianhelba/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-03-04T18:06:35Z","updated_at":"2015-03-04T18:06:35Z","closed_at":null,"body":"There are a number of places in the Python code that define variables \"id\", \"hash\", etc. These override Python builtin functions which are always in the namespace, which is a bad practice.\r\n\r\nIn addition to renaming the variables, we need the style tests to warn about this issue. Unfortunately, Flake8 does not appear to have a checker for this. Other style checking tools may need to be utilized."}}