{"action":"opened","issue":{"url":"https://api.github.com/repos/baccuslab/spike-sorting/issues/9","labels_url":"https://api.github.com/repos/baccuslab/spike-sorting/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/baccuslab/spike-sorting/issues/9/comments","events_url":"https://api.github.com/repos/baccuslab/spike-sorting/issues/9/events","html_url":"https://github.com/baccuslab/spike-sorting/issues/9","id":112843071,"number":9,"title":"Major revision needed","user":{"login":"bnaecker","id":3259107,"avatar_url":"https://avatars.githubusercontent.com/u/3259107?v=3","gravatar_id":"","url":"https://api.github.com/users/bnaecker","html_url":"https://github.com/bnaecker","followers_url":"https://api.github.com/users/bnaecker/followers","following_url":"https://api.github.com/users/bnaecker/following{/other_user}","gists_url":"https://api.github.com/users/bnaecker/gists{/gist_id}","starred_url":"https://api.github.com/users/bnaecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnaecker/subscriptions","organizations_url":"https://api.github.com/users/bnaecker/orgs","repos_url":"https://api.github.com/users/bnaecker/repos","events_url":"https://api.github.com/users/bnaecker/events{/privacy}","received_events_url":"https://api.github.com/users/bnaecker/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-10-22T16:39:48Z","updated_at":"2015-10-22T16:39:48Z","closed_at":null,"body":"The spike sorting code as is does not work. There seem to be problems with, at the least: data is read from files inconsistently; transposes in some places but not others; removal of clusters and cross-talk; selection in multi-dimensional clustering is broken.\r\n\r\nI talked with Steve yesterday, and we agreed on something like the following. I am going to dig through the history for the newest commit with no substantive changes. A non-substantive change is something like updating Matlab's function names (e.g., `getuprop` -> `getappdata`). A substantive change is pretty much anything to our own files, stuff like file I/O, computation of filters, cluster selection, transpositions of arrays, etc. \r\n\r\nAfter finding this commit, there are 3 major stages to my proposed update process.\r\n\r\n1. Get the code to work on a new version of Matlab, with __no changes__ to computations, clustering, file formats, transpositions, or anything else. Literally just port the old code to new Matlab.\r\n\r\n2. After we are convinced that this is working correctly, _only then_ should we update the file I/O routines to take data from the new HDF5 formats, both data and snippets.\r\n\r\n3. If everything up to this point goes swimmingly, and _if_ we deem it necessary, we'll make efficiency improvements. Things like loop optimization, using the `DIM` argument to functions rather than transposing, replacing unused return values with `~`, etc."}}