{"action":"created","comment":{"url":"https://api.github.com/repos/google/rappor/pulls/comments/31177175","id":31177175,"diff_hunk":"@@ -240,6 +240,8 @@ make-summary() {\n     | sed -e '/TABLE_ROWS/ r rows.html' \\\n     > $filename\n \n+  rm rows.html","path":"regtest.sh","position":null,"original_position":13,"commit_id":"9f145136971970d278950035e2d1325c84e208eb","original_commit_id":"9a8310f317bed770e87cc1019f712480186b9e89","user":{"login":"ilyamironov","id":10524481,"avatar_url":"https://avatars.githubusercontent.com/u/10524481?v=3","gravatar_id":"","url":"https://api.github.com/users/ilyamironov","html_url":"https://github.com/ilyamironov","followers_url":"https://api.github.com/users/ilyamironov/followers","following_url":"https://api.github.com/users/ilyamironov/following{/other_user}","gists_url":"https://api.github.com/users/ilyamironov/gists{/gist_id}","starred_url":"https://api.github.com/users/ilyamironov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilyamironov/subscriptions","organizations_url":"https://api.github.com/users/ilyamironov/orgs","repos_url":"https://api.github.com/users/ilyamironov/repos","events_url":"https://api.github.com/users/ilyamironov/events{/privacy}","received_events_url":"https://api.github.com/users/ilyamironov/received_events","type":"User","site_admin":false},"body":"\"./test.sh all\" did not flag anything, so I merged the branch into master\nand deleted it.\n\nOn Wed, May 27, 2015 at 12:59 PM andychu <notifications@github.com> wrote:\n\n> In regtest.sh\n> <https://github.com/google/rappor/pull/37#discussion_r31173817>:\n>\n> > @@ -240,6 +240,8 @@ make-summary() {\n> >      | sed -e '/TABLE_ROWS/ r rows.html' \\\n> >      > $filename\n> >\n> > +  rm rows.html\n>\n> LGTM\n> On Tue, May 26, 2015 at 8:50 PM, Ilya Mironov <notifications@github.com>\n> wrote: In regtest.sh <\n> https://github.com/google/rappor/pull/37#discussion_r31101404>: > @@\n> -240,6 +240,8 @@ make-summary() { > | sed -e '/TABLE_ROWS/ r rows.html' \\ >\n> > $filename > > + rm rows.html I removed the line for now, but still wonder\n> - why do we need the rows.html file lying around?\n> It's an intermediate output, and we so far we keep all intermediate\n> outputs. We could move them if they're in the way but I think it's nice to\n> have for debuggability. Make sure './test.sh all' passes (I think I only\n> checked ./test.sh r-unit) and then go ahead and submit. This may catch some\n> lint errors, etc. thanks, Andy\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/google/rappor/pull/37/files#r31173817>.\n>\n","created_at":"2015-05-27T20:35:06Z","updated_at":"2015-05-27T20:35:06Z","html_url":"https://github.com/google/rappor/pull/37#discussion_r31177175","pull_request_url":"https://api.github.com/repos/google/rappor/pulls/37","_links":{"self":{"href":"https://api.github.com/repos/google/rappor/pulls/comments/31177175"},"html":{"href":"https://github.com/google/rappor/pull/37#discussion_r31177175"},"pull_request":{"href":"https://api.github.com/repos/google/rappor/pulls/37"}}},"pull_request":{"url":"https://api.github.com/repos/google/rappor/pulls/37","id":34762986,"html_url":"https://github.com/google/rappor/pull/37","diff_url":"https://github.com/google/rappor/pull/37.diff","patch_url":"https://github.com/google/rappor/pull/37.patch","issue_url":"https://api.github.com/repos/google/rappor/issues/37","number":37,"state":"closed","locked":false,"title":"Constrained lm","user":{"login":"ilyamironov","id":10524481,"avatar_url":"https://avatars.githubusercontent.com/u/10524481?v=3","gravatar_id":"","url":"https://api.github.com/users/ilyamironov","html_url":"https://github.com/ilyamironov","followers_url":"https://api.github.com/users/ilyamironov/followers","following_url":"https://api.github.com/users/ilyamironov/following{/other_user}","gists_url":"https://api.github.com/users/ilyamironov/gists{/gist_id}","starred_url":"https://api.github.com/users/ilyamironov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilyamironov/subscriptions","organizations_url":"https://api.github.com/users/ilyamironov/orgs","repos_url":"https://api.github.com/users/ilyamironov/repos","events_url":"https://api.github.com/users/ilyamironov/events{/privacy}","received_events_url":"https://api.github.com/users/ilyamironov/received_events","type":"User","site_admin":false},"body":"- Added consistency requirements to the LM program\r\n- Added tracking of standard deviation to Decode\r\n- Added suppression of outputs for which std is larger than the signal ","created_at":"2015-05-05T20:22:38Z","updated_at":"2015-05-27T20:35:06Z","closed_at":"2015-05-27T20:31:28Z","merged_at":"2015-05-27T20:31:28Z","merge_commit_sha":"2843071d7ad4a6844aa5a033f547b8fd7f0270c8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/rappor/pulls/37/commits","review_comments_url":"https://api.github.com/repos/google/rappor/pulls/37/comments","review_comment_url":"https://api.github.com/repos/google/rappor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/rappor/issues/37/comments","statuses_url":"https://api.github.com/repos/google/rappor/statuses/9f145136971970d278950035e2d1325c84e208eb","head":{"label":"google:constrained_lm","ref":"constrained_lm","sha":"9f145136971970d278950035e2d1325c84e208eb","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":25319462,"name":"rappor","full_name":"google/rappor","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/rappor","description":"RAPPOR: Privacy-Preserving Reporting Algorithms","fork":false,"url":"https://api.github.com/repos/google/rappor","forks_url":"https://api.github.com/repos/google/rappor/forks","keys_url":"https://api.github.com/repos/google/rappor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/rappor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/rappor/teams","hooks_url":"https://api.github.com/repos/google/rappor/hooks","issue_events_url":"https://api.github.com/repos/google/rappor/issues/events{/number}","events_url":"https://api.github.com/repos/google/rappor/events","assignees_url":"https://api.github.com/repos/google/rappor/assignees{/user}","branches_url":"https://api.github.com/repos/google/rappor/branches{/branch}","tags_url":"https://api.github.com/repos/google/rappor/tags","blobs_url":"https://api.github.com/repos/google/rappor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/rappor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/rappor/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/rappor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/rappor/statuses/{sha}","languages_url":"https://api.github.com/repos/google/rappor/languages","stargazers_url":"https://api.github.com/repos/google/rappor/stargazers","contributors_url":"https://api.github.com/repos/google/rappor/contributors","subscribers_url":"https://api.github.com/repos/google/rappor/subscribers","subscription_url":"https://api.github.com/repos/google/rappor/subscription","commits_url":"https://api.github.com/repos/google/rappor/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/rappor/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/rappor/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/rappor/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/rappor/contents/{+path}","compare_url":"https://api.github.com/repos/google/rappor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/rappor/merges","archive_url":"https://api.github.com/repos/google/rappor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/rappor/downloads","issues_url":"https://api.github.com/repos/google/rappor/issues{/number}","pulls_url":"https://api.github.com/repos/google/rappor/pulls{/number}","milestones_url":"https://api.github.com/repos/google/rappor/milestones{/number}","notifications_url":"https://api.github.com/repos/google/rappor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/rappor/labels{/name}","releases_url":"https://api.github.com/repos/google/rappor/releases{/id}","created_at":"2014-10-16T20:05:27Z","updated_at":"2015-05-27T05:11:06Z","pushed_at":"2015-05-27T20:31:32Z","git_url":"git://github.com/google/rappor.git","ssh_url":"git@github.com:google/rappor.git","clone_url":"https://github.com/google/rappor.git","svn_url":"https://github.com/google/rappor","homepage":"","size":2504,"stargazers_count":117,"watchers_count":117,"language":"R","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":21,"mirror_url":null,"open_issues_count":20,"forks":21,"open_issues":20,"watchers":117,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"2fcec8eb040c64e872ba77a87ee9b3b79aeffcd8","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":25319462,"name":"rappor","full_name":"google/rappor","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/rappor","description":"RAPPOR: Privacy-Preserving Reporting Algorithms","fork":false,"url":"https://api.github.com/repos/google/rappor","forks_url":"https://api.github.com/repos/google/rappor/forks","keys_url":"https://api.github.com/repos/google/rappor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/rappor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/rappor/teams","hooks_url":"https://api.github.com/repos/google/rappor/hooks","issue_events_url":"https://api.github.com/repos/google/rappor/issues/events{/number}","events_url":"https://api.github.com/repos/google/rappor/events","assignees_url":"https://api.github.com/repos/google/rappor/assignees{/user}","branches_url":"https://api.github.com/repos/google/rappor/branches{/branch}","tags_url":"https://api.github.com/repos/google/rappor/tags","blobs_url":"https://api.github.com/repos/google/rappor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/rappor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/rappor/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/rappor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/rappor/statuses/{sha}","languages_url":"https://api.github.com/repos/google/rappor/languages","stargazers_url":"https://api.github.com/repos/google/rappor/stargazers","contributors_url":"https://api.github.com/repos/google/rappor/contributors","subscribers_url":"https://api.github.com/repos/google/rappor/subscribers","subscription_url":"https://api.github.com/repos/google/rappor/subscription","commits_url":"https://api.github.com/repos/google/rappor/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/rappor/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/rappor/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/rappor/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/rappor/contents/{+path}","compare_url":"https://api.github.com/repos/google/rappor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/rappor/merges","archive_url":"https://api.github.com/repos/google/rappor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/rappor/downloads","issues_url":"https://api.github.com/repos/google/rappor/issues{/number}","pulls_url":"https://api.github.com/repos/google/rappor/pulls{/number}","milestones_url":"https://api.github.com/repos/google/rappor/milestones{/number}","notifications_url":"https://api.github.com/repos/google/rappor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/rappor/labels{/name}","releases_url":"https://api.github.com/repos/google/rappor/releases{/id}","created_at":"2014-10-16T20:05:27Z","updated_at":"2015-05-27T05:11:06Z","pushed_at":"2015-05-27T20:31:32Z","git_url":"git://github.com/google/rappor.git","ssh_url":"git@github.com:google/rappor.git","clone_url":"https://github.com/google/rappor.git","svn_url":"https://github.com/google/rappor","homepage":"","size":2504,"stargazers_count":117,"watchers_count":117,"language":"R","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":21,"mirror_url":null,"open_issues_count":20,"forks":21,"open_issues":20,"watchers":117,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/rappor/pulls/37"},"html":{"href":"https://github.com/google/rappor/pull/37"},"issue":{"href":"https://api.github.com/repos/google/rappor/issues/37"},"comments":{"href":"https://api.github.com/repos/google/rappor/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/google/rappor/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/google/rappor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/rappor/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/google/rappor/statuses/9f145136971970d278950035e2d1325c84e208eb"}}}}