{"action":"created","issue":{"url":"https://api.github.com/repos/JoanZapata/android-iconify/issues/134","labels_url":"https://api.github.com/repos/JoanZapata/android-iconify/issues/134/labels{/name}","comments_url":"https://api.github.com/repos/JoanZapata/android-iconify/issues/134/comments","events_url":"https://api.github.com/repos/JoanZapata/android-iconify/issues/134/events","html_url":"https://github.com/JoanZapata/android-iconify/pull/134","id":113524255,"number":134,"title":"Fix and enhance IconDrawable","user":{"login":"1zaman","id":4244109,"avatar_url":"https://avatars.githubusercontent.com/u/4244109?v=3","gravatar_id":"","url":"https://api.github.com/users/1zaman","html_url":"https://github.com/1zaman","followers_url":"https://api.github.com/users/1zaman/followers","following_url":"https://api.github.com/users/1zaman/following{/other_user}","gists_url":"https://api.github.com/users/1zaman/gists{/gist_id}","starred_url":"https://api.github.com/users/1zaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1zaman/subscriptions","organizations_url":"https://api.github.com/users/1zaman/orgs","repos_url":"https://api.github.com/users/1zaman/repos","events_url":"https://api.github.com/users/1zaman/events{/privacy}","received_events_url":"https://api.github.com/users/1zaman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-10-27T07:39:58Z","updated_at":"2015-11-25T11:55:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/JoanZapata/android-iconify/pulls/134","html_url":"https://github.com/JoanZapata/android-iconify/pull/134","diff_url":"https://github.com/JoanZapata/android-iconify/pull/134.diff","patch_url":"https://github.com/JoanZapata/android-iconify/pull/134.patch"},"body":"This pull request adds lots of enhancements and fixes to `IconDrawable`:\r\n\r\n - Adds spin animation functionality.\r\n - Adds constant state in order to work around bugs in the framework and support library where this is expected (resolves #93, resolves #121).\r\n - Handle the case where the width of the icon is not the same as it's height by returning the correct intrinsic width, and changing the drawing logic to always fit the icon within it's bounds.\r\n - Adds support for color state lists.\r\n - Adds support for tint, and sets the default to implement the half translucency on disabled state, and removed the custom logic to do it by changing the alpha.\r\n - Modulates the existing alpha from the color instead of replacing it.\r\n - Removes the changing of the bounds upon size change, as that should only be done by the view.\r\n - Adds missing implementations of base methods.\r\n\r\nNote that because we need to be able to generate the drawable without a `Context` from the constant state, the methods that resolved resources (i.e. colors, dimensions) now have to take a `Context` as a parameter. This unfortunately makes the change backwards-incompatible.\r\n\r\nThe spin animation logic is also slightly changed in `CustomTypefaceSpan` to initialize the start time upon first draw instead of upon instantiation, since that is the actual start time of the animation. This matches it with the implementation in `IconDrawable`."},"comment":{"url":"https://api.github.com/repos/JoanZapata/android-iconify/issues/comments/159586970","html_url":"https://github.com/JoanZapata/android-iconify/pull/134#issuecomment-159586970","issue_url":"https://api.github.com/repos/JoanZapata/android-iconify/issues/134","id":159586970,"user":{"login":"JoanZapata","id":675408,"avatar_url":"https://avatars.githubusercontent.com/u/675408?v=3","gravatar_id":"","url":"https://api.github.com/users/JoanZapata","html_url":"https://github.com/JoanZapata","followers_url":"https://api.github.com/users/JoanZapata/followers","following_url":"https://api.github.com/users/JoanZapata/following{/other_user}","gists_url":"https://api.github.com/users/JoanZapata/gists{/gist_id}","starred_url":"https://api.github.com/users/JoanZapata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoanZapata/subscriptions","organizations_url":"https://api.github.com/users/JoanZapata/orgs","repos_url":"https://api.github.com/users/JoanZapata/repos","events_url":"https://api.github.com/users/JoanZapata/events{/privacy}","received_events_url":"https://api.github.com/users/JoanZapata/received_events","type":"User","site_admin":false},"created_at":"2015-11-25T11:55:46Z","updated_at":"2015-11-25T11:55:46Z","body":"Yep, already merged it locally, thanks. :)"}}