{"action":"created","comment":{"url":"https://api.github.com/repos/youtube/vitess/pulls/comments/39574990","id":39574990,"diff_hunk":"@@ -5,30 +5,20 @@\n package binlog\n \n import (\n-\t\"encoding/base64\"\n-\t\"strconv\"\n-\t\"strings\"\n-\n \tlog \"github.com/golang/glog\"\n \t\"github.com/youtube/vitess/go/vt/binlog/proto\"\n \t\"github.com/youtube/vitess/go/vt/key\"\n+\tannotations \"github.com/youtube/vitess/go/vt/sqlannotations\"","path":"go/vt/binlog/keyrange_filter.go","position":11,"original_position":11,"commit_id":"f0682b0ec8326dc9e7663e9e7d92b1ec12bed09d","original_commit_id":"f0682b0ec8326dc9e7663e9e7d92b1ec12bed09d","user":{"login":"alainjobart","id":4625714,"avatar_url":"https://avatars.githubusercontent.com/u/4625714?v=3","gravatar_id":"","url":"https://api.github.com/users/alainjobart","html_url":"https://github.com/alainjobart","followers_url":"https://api.github.com/users/alainjobart/followers","following_url":"https://api.github.com/users/alainjobart/following{/other_user}","gists_url":"https://api.github.com/users/alainjobart/gists{/gist_id}","starred_url":"https://api.github.com/users/alainjobart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alainjobart/subscriptions","organizations_url":"https://api.github.com/users/alainjobart/orgs","repos_url":"https://api.github.com/users/alainjobart/repos","events_url":"https://api.github.com/users/alainjobart/events{/privacy}","received_events_url":"https://api.github.com/users/alainjobart/received_events","type":"User","site_admin":false},"body":"+1\r\n","created_at":"2015-09-15T22:39:06Z","updated_at":"2015-09-15T22:39:06Z","html_url":"https://github.com/youtube/vitess/pull/1103#discussion_r39574990","pull_request_url":"https://api.github.com/repos/youtube/vitess/pulls/1103","_links":{"self":{"href":"https://api.github.com/repos/youtube/vitess/pulls/comments/39574990"},"html":{"href":"https://github.com/youtube/vitess/pull/1103#discussion_r39574990"},"pull_request":{"href":"https://api.github.com/repos/youtube/vitess/pulls/1103"}}},"pull_request":{"url":"https://api.github.com/repos/youtube/vitess/pulls/1103","id":45097440,"html_url":"https://github.com/youtube/vitess/pull/1103","diff_url":"https://github.com/youtube/vitess/pull/1103.diff","patch_url":"https://github.com/youtube/vitess/pull/1103.patch","issue_url":"https://api.github.com/repos/youtube/vitess/issues/1103","number":1103,"state":"open","locked":false,"title":"Making vtgate add annotations to DML statements.","user":{"login":"erzel","id":14099708,"avatar_url":"https://avatars.githubusercontent.com/u/14099708?v=3","gravatar_id":"","url":"https://api.github.com/users/erzel","html_url":"https://github.com/erzel","followers_url":"https://api.github.com/users/erzel/followers","following_url":"https://api.github.com/users/erzel/following{/other_user}","gists_url":"https://api.github.com/users/erzel/gists{/gist_id}","starred_url":"https://api.github.com/users/erzel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erzel/subscriptions","organizations_url":"https://api.github.com/users/erzel/orgs","repos_url":"https://api.github.com/users/erzel/repos","events_url":"https://api.github.com/users/erzel/events{/privacy}","received_events_url":"https://api.github.com/users/erzel/received_events","type":"User","site_admin":false},"body":"Hi guys,\r\n\r\nThis change does the following:\r\n\r\n+ Adds a package sqlannotations for parsing and annotating SQL DML statement.s\r\n+ Adds vtgate code for annotating DML statements with keyspace id and unfriendly to replication comments. There's still work to do on V3 Execute method.\r\n+ Changes the filtered replication code to parse the new format of annotations.\r\n\r\nPlease try to pay close attention as I'm new to all of this and likely to have made mistakes. Specifically, I am not sure if I found all the filtered-replication code that needs to change.\r\n\r\nNominating people to review: @sougou @alainjobart \r\n","created_at":"2015-09-15T20:22:34Z","updated_at":"2015-09-15T22:39:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2bfd0c19250cbf0de308b0523970668345fd3d37","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/youtube/vitess/pulls/1103/commits","review_comments_url":"https://api.github.com/repos/youtube/vitess/pulls/1103/comments","review_comment_url":"https://api.github.com/repos/youtube/vitess/pulls/comments{/number}","comments_url":"https://api.github.com/repos/youtube/vitess/issues/1103/comments","statuses_url":"https://api.github.com/repos/youtube/vitess/statuses/f0682b0ec8326dc9e7663e9e7d92b1ec12bed09d","head":{"label":"erzel:master","ref":"master","sha":"f0682b0ec8326dc9e7663e9e7d92b1ec12bed09d","user":{"login":"erzel","id":14099708,"avatar_url":"https://avatars.githubusercontent.com/u/14099708?v=3","gravatar_id":"","url":"https://api.github.com/users/erzel","html_url":"https://github.com/erzel","followers_url":"https://api.github.com/users/erzel/followers","following_url":"https://api.github.com/users/erzel/following{/other_user}","gists_url":"https://api.github.com/users/erzel/gists{/gist_id}","starred_url":"https://api.github.com/users/erzel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erzel/subscriptions","organizations_url":"https://api.github.com/users/erzel/orgs","repos_url":"https://api.github.com/users/erzel/repos","events_url":"https://api.github.com/users/erzel/events{/privacy}","received_events_url":"https://api.github.com/users/erzel/received_events","type":"User","site_admin":false},"repo":{"id":41829214,"name":"vitess","full_name":"erzel/vitess","owner":{"login":"erzel","id":14099708,"avatar_url":"https://avatars.githubusercontent.com/u/14099708?v=3","gravatar_id":"","url":"https://api.github.com/users/erzel","html_url":"https://github.com/erzel","followers_url":"https://api.github.com/users/erzel/followers","following_url":"https://api.github.com/users/erzel/following{/other_user}","gists_url":"https://api.github.com/users/erzel/gists{/gist_id}","starred_url":"https://api.github.com/users/erzel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erzel/subscriptions","organizations_url":"https://api.github.com/users/erzel/orgs","repos_url":"https://api.github.com/users/erzel/repos","events_url":"https://api.github.com/users/erzel/events{/privacy}","received_events_url":"https://api.github.com/users/erzel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erzel/vitess","description":"vitess provides servers and tools which facilitate scaling of MySQL databases for large scale web services.","fork":true,"url":"https://api.github.com/repos/erzel/vitess","forks_url":"https://api.github.com/repos/erzel/vitess/forks","keys_url":"https://api.github.com/repos/erzel/vitess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erzel/vitess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erzel/vitess/teams","hooks_url":"https://api.github.com/repos/erzel/vitess/hooks","issue_events_url":"https://api.github.com/repos/erzel/vitess/issues/events{/number}","events_url":"https://api.github.com/repos/erzel/vitess/events","assignees_url":"https://api.github.com/repos/erzel/vitess/assignees{/user}","branches_url":"https://api.github.com/repos/erzel/vitess/branches{/branch}","tags_url":"https://api.github.com/repos/erzel/vitess/tags","blobs_url":"https://api.github.com/repos/erzel/vitess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erzel/vitess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erzel/vitess/git/refs{/sha}","trees_url":"https://api.github.com/repos/erzel/vitess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erzel/vitess/statuses/{sha}","languages_url":"https://api.github.com/repos/erzel/vitess/languages","stargazers_url":"https://api.github.com/repos/erzel/vitess/stargazers","contributors_url":"https://api.github.com/repos/erzel/vitess/contributors","subscribers_url":"https://api.github.com/repos/erzel/vitess/subscribers","subscription_url":"https://api.github.com/repos/erzel/vitess/subscription","commits_url":"https://api.github.com/repos/erzel/vitess/commits{/sha}","git_commits_url":"https://api.github.com/repos/erzel/vitess/git/commits{/sha}","comments_url":"https://api.github.com/repos/erzel/vitess/comments{/number}","issue_comment_url":"https://api.github.com/repos/erzel/vitess/issues/comments{/number}","contents_url":"https://api.github.com/repos/erzel/vitess/contents/{+path}","compare_url":"https://api.github.com/repos/erzel/vitess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erzel/vitess/merges","archive_url":"https://api.github.com/repos/erzel/vitess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erzel/vitess/downloads","issues_url":"https://api.github.com/repos/erzel/vitess/issues{/number}","pulls_url":"https://api.github.com/repos/erzel/vitess/pulls{/number}","milestones_url":"https://api.github.com/repos/erzel/vitess/milestones{/number}","notifications_url":"https://api.github.com/repos/erzel/vitess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erzel/vitess/labels{/name}","releases_url":"https://api.github.com/repos/erzel/vitess/releases{/id}","created_at":"2015-09-02T21:42:27Z","updated_at":"2015-09-02T21:42:30Z","pushed_at":"2015-09-15T20:00:54Z","git_url":"git://github.com/erzel/vitess.git","ssh_url":"git@github.com:erzel/vitess.git","clone_url":"https://github.com/erzel/vitess.git","svn_url":"https://github.com/erzel/vitess","homepage":null,"size":50482,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"youtube:master","ref":"master","sha":"f22735810780deeacd4a4b46a84871267252514d","user":{"login":"youtube","id":4052902,"avatar_url":"https://avatars.githubusercontent.com/u/4052902?v=3","gravatar_id":"","url":"https://api.github.com/users/youtube","html_url":"https://github.com/youtube","followers_url":"https://api.github.com/users/youtube/followers","following_url":"https://api.github.com/users/youtube/following{/other_user}","gists_url":"https://api.github.com/users/youtube/gists{/gist_id}","starred_url":"https://api.github.com/users/youtube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youtube/subscriptions","organizations_url":"https://api.github.com/users/youtube/orgs","repos_url":"https://api.github.com/users/youtube/repos","events_url":"https://api.github.com/users/youtube/events{/privacy}","received_events_url":"https://api.github.com/users/youtube/received_events","type":"Organization","site_admin":false},"repo":{"id":11008207,"name":"vitess","full_name":"youtube/vitess","owner":{"login":"youtube","id":4052902,"avatar_url":"https://avatars.githubusercontent.com/u/4052902?v=3","gravatar_id":"","url":"https://api.github.com/users/youtube","html_url":"https://github.com/youtube","followers_url":"https://api.github.com/users/youtube/followers","following_url":"https://api.github.com/users/youtube/following{/other_user}","gists_url":"https://api.github.com/users/youtube/gists{/gist_id}","starred_url":"https://api.github.com/users/youtube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youtube/subscriptions","organizations_url":"https://api.github.com/users/youtube/orgs","repos_url":"https://api.github.com/users/youtube/repos","events_url":"https://api.github.com/users/youtube/events{/privacy}","received_events_url":"https://api.github.com/users/youtube/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/youtube/vitess","description":"vitess provides servers and tools which facilitate scaling of MySQL databases for large scale web services.","fork":false,"url":"https://api.github.com/repos/youtube/vitess","forks_url":"https://api.github.com/repos/youtube/vitess/forks","keys_url":"https://api.github.com/repos/youtube/vitess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/youtube/vitess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/youtube/vitess/teams","hooks_url":"https://api.github.com/repos/youtube/vitess/hooks","issue_events_url":"https://api.github.com/repos/youtube/vitess/issues/events{/number}","events_url":"https://api.github.com/repos/youtube/vitess/events","assignees_url":"https://api.github.com/repos/youtube/vitess/assignees{/user}","branches_url":"https://api.github.com/repos/youtube/vitess/branches{/branch}","tags_url":"https://api.github.com/repos/youtube/vitess/tags","blobs_url":"https://api.github.com/repos/youtube/vitess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/youtube/vitess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/youtube/vitess/git/refs{/sha}","trees_url":"https://api.github.com/repos/youtube/vitess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/youtube/vitess/statuses/{sha}","languages_url":"https://api.github.com/repos/youtube/vitess/languages","stargazers_url":"https://api.github.com/repos/youtube/vitess/stargazers","contributors_url":"https://api.github.com/repos/youtube/vitess/contributors","subscribers_url":"https://api.github.com/repos/youtube/vitess/subscribers","subscription_url":"https://api.github.com/repos/youtube/vitess/subscription","commits_url":"https://api.github.com/repos/youtube/vitess/commits{/sha}","git_commits_url":"https://api.github.com/repos/youtube/vitess/git/commits{/sha}","comments_url":"https://api.github.com/repos/youtube/vitess/comments{/number}","issue_comment_url":"https://api.github.com/repos/youtube/vitess/issues/comments{/number}","contents_url":"https://api.github.com/repos/youtube/vitess/contents/{+path}","compare_url":"https://api.github.com/repos/youtube/vitess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/youtube/vitess/merges","archive_url":"https://api.github.com/repos/youtube/vitess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/youtube/vitess/downloads","issues_url":"https://api.github.com/repos/youtube/vitess/issues{/number}","pulls_url":"https://api.github.com/repos/youtube/vitess/pulls{/number}","milestones_url":"https://api.github.com/repos/youtube/vitess/milestones{/number}","notifications_url":"https://api.github.com/repos/youtube/vitess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/youtube/vitess/labels{/name}","releases_url":"https://api.github.com/repos/youtube/vitess/releases{/id}","created_at":"2013-06-27T21:20:28Z","updated_at":"2015-09-14T17:29:09Z","pushed_at":"2015-09-15T22:10:40Z","git_url":"git://github.com/youtube/vitess.git","ssh_url":"git@github.com:youtube/vitess.git","clone_url":"https://github.com/youtube/vitess.git","svn_url":"https://github.com/youtube/vitess","homepage":null,"size":72183,"stargazers_count":2790,"watchers_count":2790,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":355,"mirror_url":null,"open_issues_count":18,"forks":355,"open_issues":18,"watchers":2790,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/youtube/vitess/pulls/1103"},"html":{"href":"https://github.com/youtube/vitess/pull/1103"},"issue":{"href":"https://api.github.com/repos/youtube/vitess/issues/1103"},"comments":{"href":"https://api.github.com/repos/youtube/vitess/issues/1103/comments"},"review_comments":{"href":"https://api.github.com/repos/youtube/vitess/pulls/1103/comments"},"review_comment":{"href":"https://api.github.com/repos/youtube/vitess/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/youtube/vitess/pulls/1103/commits"},"statuses":{"href":"https://api.github.com/repos/youtube/vitess/statuses/f0682b0ec8326dc9e7663e9e7d92b1ec12bed09d"}}}}