{"action":"created","comment":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/31657249","id":31657249,"diff_hunk":"@@ -208,6 +208,10 @@ ssize_t sock_ep_sendmsg(struct fid_ep *ep, const struct fi_msg *msg,\n \t\tconn = sock_ep_lookup_conn(sock_ep);\n \t} else {\n \t\tconn = sock_av_lookup_addr(sock_ep, tx_ctx->av, msg->addr);\n+\t\tif (!conn) {\n+\t\t\tSOCK_LOG_ERROR(\"Address lookup failed\\n\");","path":"prov/sockets/src/sock_msg.c","position":5,"original_position":5,"commit_id":"373312da1bea98789addd01666a6e0c364dc8336","original_commit_id":"6275a9109c633f5070f7827ba2b8237e9fbe5ea4","user":{"login":"sayantansur","id":8459709,"avatar_url":"https://avatars.githubusercontent.com/u/8459709?v=3","gravatar_id":"","url":"https://api.github.com/users/sayantansur","html_url":"https://github.com/sayantansur","followers_url":"https://api.github.com/users/sayantansur/followers","following_url":"https://api.github.com/users/sayantansur/following{/other_user}","gists_url":"https://api.github.com/users/sayantansur/gists{/gist_id}","starred_url":"https://api.github.com/users/sayantansur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sayantansur/subscriptions","organizations_url":"https://api.github.com/users/sayantansur/orgs","repos_url":"https://api.github.com/users/sayantansur/repos","events_url":"https://api.github.com/users/sayantansur/events{/privacy}","received_events_url":"https://api.github.com/users/sayantansur/received_events","type":"User","site_admin":false},"body":"added","created_at":"2015-06-03T18:56:18Z","updated_at":"2015-06-03T18:56:18Z","html_url":"https://github.com/ofiwg/libfabric/pull/1048#discussion_r31657249","pull_request_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/1048","_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/31657249"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/1048#discussion_r31657249"},"pull_request":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/1048"}}},"pull_request":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/1048","id":36846558,"html_url":"https://github.com/ofiwg/libfabric/pull/1048","diff_url":"https://github.com/ofiwg/libfabric/pull/1048.diff","patch_url":"https://github.com/ofiwg/libfabric/pull/1048.patch","issue_url":"https://api.github.com/repos/ofiwg/libfabric/issues/1048","number":1048,"state":"open","locked":false,"title":"sockets: improve error reports when connect fails","user":{"login":"sayantansur","id":8459709,"avatar_url":"https://avatars.githubusercontent.com/u/8459709?v=3","gravatar_id":"","url":"https://api.github.com/users/sayantansur","html_url":"https://github.com/sayantansur","followers_url":"https://api.github.com/users/sayantansur/followers","following_url":"https://api.github.com/users/sayantansur/following{/other_user}","gists_url":"https://api.github.com/users/sayantansur/gists{/gist_id}","starred_url":"https://api.github.com/users/sayantansur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sayantansur/subscriptions","organizations_url":"https://api.github.com/users/sayantansur/orgs","repos_url":"https://api.github.com/users/sayantansur/repos","events_url":"https://api.github.com/users/sayantansur/events{/privacy}","received_events_url":"https://api.github.com/users/sayantansur/received_events","type":"User","site_admin":false},"body":"Improve error reporting when trying to send to a target with which\r\nconnect fails. The provider was reporting -FI_EAGAIN when the\r\nunderlying connect fails for RDM type EP.\r\n\r\nAlso, inet_ntoa() cannot be called twice in a print function. It updates\r\na string in static storage, and if there are two calls, the second can\r\noverwrite the buffer - order of expression evaluation isn't defined\r\nin the C-standard. At least one print statement was printing the wrong\r\nsource address.\r\n\r\nSigned-off-by: Sayantan Sur <sayantan.sur@intel.com>\r\n\r\n@jithinjosepkl @shantonu @shefty : Please review","created_at":"2015-06-03T15:41:21Z","updated_at":"2015-06-03T18:56:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"176daec3a9fb5a98c8174c6b60324c57876cf492","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/1048/commits","review_comments_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/1048/comments","review_comment_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/issues/1048/comments","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/373312da1bea98789addd01666a6e0c364dc8336","head":{"label":"sayantansur:sockets-eagain","ref":"sockets-eagain","sha":"373312da1bea98789addd01666a6e0c364dc8336","user":{"login":"sayantansur","id":8459709,"avatar_url":"https://avatars.githubusercontent.com/u/8459709?v=3","gravatar_id":"","url":"https://api.github.com/users/sayantansur","html_url":"https://github.com/sayantansur","followers_url":"https://api.github.com/users/sayantansur/followers","following_url":"https://api.github.com/users/sayantansur/following{/other_user}","gists_url":"https://api.github.com/users/sayantansur/gists{/gist_id}","starred_url":"https://api.github.com/users/sayantansur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sayantansur/subscriptions","organizations_url":"https://api.github.com/users/sayantansur/orgs","repos_url":"https://api.github.com/users/sayantansur/repos","events_url":"https://api.github.com/users/sayantansur/events{/privacy}","received_events_url":"https://api.github.com/users/sayantansur/received_events","type":"User","site_admin":false},"repo":{"id":23470420,"name":"libfabric","full_name":"sayantansur/libfabric","owner":{"login":"sayantansur","id":8459709,"avatar_url":"https://avatars.githubusercontent.com/u/8459709?v=3","gravatar_id":"","url":"https://api.github.com/users/sayantansur","html_url":"https://github.com/sayantansur","followers_url":"https://api.github.com/users/sayantansur/followers","following_url":"https://api.github.com/users/sayantansur/following{/other_user}","gists_url":"https://api.github.com/users/sayantansur/gists{/gist_id}","starred_url":"https://api.github.com/users/sayantansur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sayantansur/subscriptions","organizations_url":"https://api.github.com/users/sayantansur/orgs","repos_url":"https://api.github.com/users/sayantansur/repos","events_url":"https://api.github.com/users/sayantansur/events{/privacy}","received_events_url":"https://api.github.com/users/sayantansur/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sayantansur/libfabric","description":"Open Fabric Interfaces","fork":true,"url":"https://api.github.com/repos/sayantansur/libfabric","forks_url":"https://api.github.com/repos/sayantansur/libfabric/forks","keys_url":"https://api.github.com/repos/sayantansur/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sayantansur/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sayantansur/libfabric/teams","hooks_url":"https://api.github.com/repos/sayantansur/libfabric/hooks","issue_events_url":"https://api.github.com/repos/sayantansur/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/sayantansur/libfabric/events","assignees_url":"https://api.github.com/repos/sayantansur/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/sayantansur/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/sayantansur/libfabric/tags","blobs_url":"https://api.github.com/repos/sayantansur/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sayantansur/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sayantansur/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/sayantansur/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sayantansur/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/sayantansur/libfabric/languages","stargazers_url":"https://api.github.com/repos/sayantansur/libfabric/stargazers","contributors_url":"https://api.github.com/repos/sayantansur/libfabric/contributors","subscribers_url":"https://api.github.com/repos/sayantansur/libfabric/subscribers","subscription_url":"https://api.github.com/repos/sayantansur/libfabric/subscription","commits_url":"https://api.github.com/repos/sayantansur/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/sayantansur/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/sayantansur/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/sayantansur/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/sayantansur/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/sayantansur/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sayantansur/libfabric/merges","archive_url":"https://api.github.com/repos/sayantansur/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sayantansur/libfabric/downloads","issues_url":"https://api.github.com/repos/sayantansur/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/sayantansur/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/sayantansur/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/sayantansur/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sayantansur/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/sayantansur/libfabric/releases{/id}","created_at":"2014-08-29T16:32:26Z","updated_at":"2015-04-29T22:53:07Z","pushed_at":"2015-06-03T18:56:07Z","git_url":"git://github.com/sayantansur/libfabric.git","ssh_url":"git@github.com:sayantansur/libfabric.git","clone_url":"https://github.com/sayantansur/libfabric.git","svn_url":"https://github.com/sayantansur/libfabric","homepage":null,"size":6245,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ofiwg:master","ref":"master","sha":"f2f90178067f23edff0964337e06281728f5048e","user":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars.githubusercontent.com/u/8459445?v=3","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"repo":{"id":22996097,"name":"libfabric","full_name":"ofiwg/libfabric","owner":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars.githubusercontent.com/u/8459445?v=3","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ofiwg/libfabric","description":"Open Fabric Interfaces","fork":false,"url":"https://api.github.com/repos/ofiwg/libfabric","forks_url":"https://api.github.com/repos/ofiwg/libfabric/forks","keys_url":"https://api.github.com/repos/ofiwg/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ofiwg/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ofiwg/libfabric/teams","hooks_url":"https://api.github.com/repos/ofiwg/libfabric/hooks","issue_events_url":"https://api.github.com/repos/ofiwg/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/ofiwg/libfabric/events","assignees_url":"https://api.github.com/repos/ofiwg/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/ofiwg/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/ofiwg/libfabric/tags","blobs_url":"https://api.github.com/repos/ofiwg/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ofiwg/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ofiwg/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/ofiwg/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/ofiwg/libfabric/languages","stargazers_url":"https://api.github.com/repos/ofiwg/libfabric/stargazers","contributors_url":"https://api.github.com/repos/ofiwg/libfabric/contributors","subscribers_url":"https://api.github.com/repos/ofiwg/libfabric/subscribers","subscription_url":"https://api.github.com/repos/ofiwg/libfabric/subscription","commits_url":"https://api.github.com/repos/ofiwg/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/ofiwg/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/ofiwg/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/ofiwg/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/ofiwg/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ofiwg/libfabric/merges","archive_url":"https://api.github.com/repos/ofiwg/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ofiwg/libfabric/downloads","issues_url":"https://api.github.com/repos/ofiwg/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/ofiwg/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/ofiwg/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/ofiwg/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ofiwg/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/ofiwg/libfabric/releases{/id}","created_at":"2014-08-15T16:45:53Z","updated_at":"2015-05-29T15:45:17Z","pushed_at":"2015-06-03T18:56:07Z","git_url":"git://github.com/ofiwg/libfabric.git","ssh_url":"git@github.com:ofiwg/libfabric.git","clone_url":"https://github.com/ofiwg/libfabric.git","svn_url":"https://github.com/ofiwg/libfabric","homepage":"http://ofiwg.github.io/libfabric/","size":14643,"stargazers_count":34,"watchers_count":34,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":36,"mirror_url":null,"open_issues_count":49,"forks":36,"open_issues":49,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/1048"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/1048"},"issue":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/1048"},"comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/1048/comments"},"review_comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/1048/comments"},"review_comment":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/1048/commits"},"statuses":{"href":"https://api.github.com/repos/ofiwg/libfabric/statuses/373312da1bea98789addd01666a6e0c364dc8336"}}}}