{"action":"created","issue":{"url":"https://api.github.com/repos/ganskef/LittleProxy-mitm/issues/12","labels_url":"https://api.github.com/repos/ganskef/LittleProxy-mitm/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/ganskef/LittleProxy-mitm/issues/12/comments","events_url":"https://api.github.com/repos/ganskef/LittleProxy-mitm/issues/12/events","html_url":"https://github.com/ganskef/LittleProxy-mitm/pull/12","id":109836505,"number":12,"title":"CertificateSniffingMitmManager throws exceptions","user":{"login":"ganskef","id":10618502,"avatar_url":"https://avatars.githubusercontent.com/u/10618502?v=3","gravatar_id":"","url":"https://api.github.com/users/ganskef","html_url":"https://github.com/ganskef","followers_url":"https://api.github.com/users/ganskef/followers","following_url":"https://api.github.com/users/ganskef/following{/other_user}","gists_url":"https://api.github.com/users/ganskef/gists{/gist_id}","starred_url":"https://api.github.com/users/ganskef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ganskef/subscriptions","organizations_url":"https://api.github.com/users/ganskef/orgs","repos_url":"https://api.github.com/users/ganskef/repos","events_url":"https://api.github.com/users/ganskef/events{/privacy}","received_events_url":"https://api.github.com/users/ganskef/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-05T16:28:28Z","updated_at":"2015-10-16T16:18:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ganskef/LittleProxy-mitm/pulls/12","html_url":"https://github.com/ganskef/LittleProxy-mitm/pull/12","diff_url":"https://github.com/ganskef/LittleProxy-mitm/pull/12.diff","patch_url":"https://github.com/ganskef/LittleProxy-mitm/pull/12.patch"},"body":"Based on the suggestion of @rhehl in #11 I created this PR to discuss this issue (and for practice).\r\n\r\nIgnore null in SAN holder since it's a valid return value in upstreamCert.getSubjectAlternativeNames(), if the certificate hasn't this extension. \r\n\r\nAdded a test and reorg test classes to init this alternate MITM manager."},"comment":{"url":"https://api.github.com/repos/ganskef/LittleProxy-mitm/issues/comments/148758751","html_url":"https://github.com/ganskef/LittleProxy-mitm/pull/12#issuecomment-148758751","issue_url":"https://api.github.com/repos/ganskef/LittleProxy-mitm/issues/12","id":148758751,"user":{"login":"ganskef","id":10618502,"avatar_url":"https://avatars.githubusercontent.com/u/10618502?v=3","gravatar_id":"","url":"https://api.github.com/users/ganskef","html_url":"https://github.com/ganskef","followers_url":"https://api.github.com/users/ganskef/followers","following_url":"https://api.github.com/users/ganskef/following{/other_user}","gists_url":"https://api.github.com/users/ganskef/gists{/gist_id}","starred_url":"https://api.github.com/users/ganskef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ganskef/subscriptions","organizations_url":"https://api.github.com/users/ganskef/orgs","repos_url":"https://api.github.com/users/ganskef/repos","events_url":"https://api.github.com/users/ganskef/events{/privacy}","received_events_url":"https://api.github.com/users/ganskef/received_events","type":"User","site_admin":false},"created_at":"2015-10-16T16:18:45Z","updated_at":"2015-10-16T16:18:45Z","body":"There are no comments. So I'm going to merge it."}}