{"action":"opened","number":2,"pull_request":{"url":"https://api.github.com/repos/tlvince/angular-underscore-string/pulls/2","id":29836515,"html_url":"https://github.com/tlvince/angular-underscore-string/pull/2","diff_url":"https://github.com/tlvince/angular-underscore-string/pull/2.diff","patch_url":"https://github.com/tlvince/angular-underscore-string/pull/2.patch","issue_url":"https://api.github.com/repos/tlvince/angular-underscore-string/issues/2","number":2,"state":"open","locked":false,"title":"Using Underscore.string's global (rather than mixin) and modifying filter name","user":{"login":"nickL","id":13480,"avatar_url":"https://avatars.githubusercontent.com/u/13480?v=3","gravatar_id":"","url":"https://api.github.com/users/nickL","html_url":"https://github.com/nickL","followers_url":"https://api.github.com/users/nickL/followers","following_url":"https://api.github.com/users/nickL/following{/other_user}","gists_url":"https://api.github.com/users/nickL/gists{/gist_id}","starred_url":"https://api.github.com/users/nickL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickL/subscriptions","organizations_url":"https://api.github.com/users/nickL/orgs","repos_url":"https://api.github.com/users/nickL/repos","events_url":"https://api.github.com/users/nickL/events{/privacy}","received_events_url":"https://api.github.com/users/nickL/received_events","type":"User","site_admin":false},"body":"Hey what's up @tlvince, great idea adding this filter.  I'm moving a few external libs into angular and was happy to see this package existed as I was searching for a solution for `underscore.string`\r\n\r\nI noticed the filter provided uses the `_.str` mixin.  The latest `underscore.string` exposes a global (`s`) that will work without having to manually mixin to underscore/lo-dash. There's a few things that are overridden when doing so so it looks [like it's no longer recommended](https://github.com/epeli/underscore.string#underscorejslo-dash-integration).  With that in mind, I made a tiny change to use the `s` global in the filter.  \r\n\r\nI also with the angular 1.2+ i  was unable to to get the filter working with it named `_.str`. I think the period is conflicting with angular 'FilterProvider`. Removing it and naming it `_str` gets it back working.\r\n\r\nLet me know if these changes make sense to you?  Only took a second so I wanted to send em over in case anyone else wants to leverage the code you started. \r\n\r\nThanks for adding this!","created_at":"2015-02-23T19:17:23Z","updated_at":"2015-02-23T19:17:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tlvince/angular-underscore-string/pulls/2/commits","review_comments_url":"https://api.github.com/repos/tlvince/angular-underscore-string/pulls/2/comments","review_comment_url":"https://api.github.com/repos/tlvince/angular-underscore-string/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tlvince/angular-underscore-string/issues/2/comments","statuses_url":"https://api.github.com/repos/tlvince/angular-underscore-string/statuses/83d08719bd4b58d4411a675003f60378f59a96f8","head":{"label":"nickL:master","ref":"master","sha":"83d08719bd4b58d4411a675003f60378f59a96f8","user":{"login":"nickL","id":13480,"avatar_url":"https://avatars.githubusercontent.com/u/13480?v=3","gravatar_id":"","url":"https://api.github.com/users/nickL","html_url":"https://github.com/nickL","followers_url":"https://api.github.com/users/nickL/followers","following_url":"https://api.github.com/users/nickL/following{/other_user}","gists_url":"https://api.github.com/users/nickL/gists{/gist_id}","starred_url":"https://api.github.com/users/nickL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickL/subscriptions","organizations_url":"https://api.github.com/users/nickL/orgs","repos_url":"https://api.github.com/users/nickL/repos","events_url":"https://api.github.com/users/nickL/events{/privacy}","received_events_url":"https://api.github.com/users/nickL/received_events","type":"User","site_admin":false},"repo":{"id":31222590,"name":"angular-underscore-string","full_name":"nickL/angular-underscore-string","owner":{"login":"nickL","id":13480,"avatar_url":"https://avatars.githubusercontent.com/u/13480?v=3","gravatar_id":"","url":"https://api.github.com/users/nickL","html_url":"https://github.com/nickL","followers_url":"https://api.github.com/users/nickL/followers","following_url":"https://api.github.com/users/nickL/following{/other_user}","gists_url":"https://api.github.com/users/nickL/gists{/gist_id}","starred_url":"https://api.github.com/users/nickL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickL/subscriptions","organizations_url":"https://api.github.com/users/nickL/orgs","repos_url":"https://api.github.com/users/nickL/repos","events_url":"https://api.github.com/users/nickL/events{/privacy}","received_events_url":"https://api.github.com/users/nickL/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nickL/angular-underscore-string","description":"Underscore.string as Angular filters","fork":true,"url":"https://api.github.com/repos/nickL/angular-underscore-string","forks_url":"https://api.github.com/repos/nickL/angular-underscore-string/forks","keys_url":"https://api.github.com/repos/nickL/angular-underscore-string/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nickL/angular-underscore-string/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nickL/angular-underscore-string/teams","hooks_url":"https://api.github.com/repos/nickL/angular-underscore-string/hooks","issue_events_url":"https://api.github.com/repos/nickL/angular-underscore-string/issues/events{/number}","events_url":"https://api.github.com/repos/nickL/angular-underscore-string/events","assignees_url":"https://api.github.com/repos/nickL/angular-underscore-string/assignees{/user}","branches_url":"https://api.github.com/repos/nickL/angular-underscore-string/branches{/branch}","tags_url":"https://api.github.com/repos/nickL/angular-underscore-string/tags","blobs_url":"https://api.github.com/repos/nickL/angular-underscore-string/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nickL/angular-underscore-string/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nickL/angular-underscore-string/git/refs{/sha}","trees_url":"https://api.github.com/repos/nickL/angular-underscore-string/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nickL/angular-underscore-string/statuses/{sha}","languages_url":"https://api.github.com/repos/nickL/angular-underscore-string/languages","stargazers_url":"https://api.github.com/repos/nickL/angular-underscore-string/stargazers","contributors_url":"https://api.github.com/repos/nickL/angular-underscore-string/contributors","subscribers_url":"https://api.github.com/repos/nickL/angular-underscore-string/subscribers","subscription_url":"https://api.github.com/repos/nickL/angular-underscore-string/subscription","commits_url":"https://api.github.com/repos/nickL/angular-underscore-string/commits{/sha}","git_commits_url":"https://api.github.com/repos/nickL/angular-underscore-string/git/commits{/sha}","comments_url":"https://api.github.com/repos/nickL/angular-underscore-string/comments{/number}","issue_comment_url":"https://api.github.com/repos/nickL/angular-underscore-string/issues/comments{/number}","contents_url":"https://api.github.com/repos/nickL/angular-underscore-string/contents/{+path}","compare_url":"https://api.github.com/repos/nickL/angular-underscore-string/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nickL/angular-underscore-string/merges","archive_url":"https://api.github.com/repos/nickL/angular-underscore-string/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nickL/angular-underscore-string/downloads","issues_url":"https://api.github.com/repos/nickL/angular-underscore-string/issues{/number}","pulls_url":"https://api.github.com/repos/nickL/angular-underscore-string/pulls{/number}","milestones_url":"https://api.github.com/repos/nickL/angular-underscore-string/milestones{/number}","notifications_url":"https://api.github.com/repos/nickL/angular-underscore-string/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nickL/angular-underscore-string/labels{/name}","releases_url":"https://api.github.com/repos/nickL/angular-underscore-string/releases{/id}","created_at":"2015-02-23T18:30:32Z","updated_at":"2015-02-23T18:30:33Z","pushed_at":"2015-02-23T19:06:26Z","git_url":"git://github.com/nickL/angular-underscore-string.git","ssh_url":"git@github.com:nickL/angular-underscore-string.git","clone_url":"https://github.com/nickL/angular-underscore-string.git","svn_url":"https://github.com/nickL/angular-underscore-string","homepage":"","size":82,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tlvince:master","ref":"master","sha":"38b19f98b7b93ba0d80e6b0d4a00208739fd79d6","user":{"login":"tlvince","id":323761,"avatar_url":"https://avatars.githubusercontent.com/u/323761?v=3","gravatar_id":"","url":"https://api.github.com/users/tlvince","html_url":"https://github.com/tlvince","followers_url":"https://api.github.com/users/tlvince/followers","following_url":"https://api.github.com/users/tlvince/following{/other_user}","gists_url":"https://api.github.com/users/tlvince/gists{/gist_id}","starred_url":"https://api.github.com/users/tlvince/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlvince/subscriptions","organizations_url":"https://api.github.com/users/tlvince/orgs","repos_url":"https://api.github.com/users/tlvince/repos","events_url":"https://api.github.com/users/tlvince/events{/privacy}","received_events_url":"https://api.github.com/users/tlvince/received_events","type":"User","site_admin":false},"repo":{"id":14961796,"name":"angular-underscore-string","full_name":"tlvince/angular-underscore-string","owner":{"login":"tlvince","id":323761,"avatar_url":"https://avatars.githubusercontent.com/u/323761?v=3","gravatar_id":"","url":"https://api.github.com/users/tlvince","html_url":"https://github.com/tlvince","followers_url":"https://api.github.com/users/tlvince/followers","following_url":"https://api.github.com/users/tlvince/following{/other_user}","gists_url":"https://api.github.com/users/tlvince/gists{/gist_id}","starred_url":"https://api.github.com/users/tlvince/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlvince/subscriptions","organizations_url":"https://api.github.com/users/tlvince/orgs","repos_url":"https://api.github.com/users/tlvince/repos","events_url":"https://api.github.com/users/tlvince/events{/privacy}","received_events_url":"https://api.github.com/users/tlvince/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tlvince/angular-underscore-string","description":"Underscore.string as Angular filters","fork":false,"url":"https://api.github.com/repos/tlvince/angular-underscore-string","forks_url":"https://api.github.com/repos/tlvince/angular-underscore-string/forks","keys_url":"https://api.github.com/repos/tlvince/angular-underscore-string/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tlvince/angular-underscore-string/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tlvince/angular-underscore-string/teams","hooks_url":"https://api.github.com/repos/tlvince/angular-underscore-string/hooks","issue_events_url":"https://api.github.com/repos/tlvince/angular-underscore-string/issues/events{/number}","events_url":"https://api.github.com/repos/tlvince/angular-underscore-string/events","assignees_url":"https://api.github.com/repos/tlvince/angular-underscore-string/assignees{/user}","branches_url":"https://api.github.com/repos/tlvince/angular-underscore-string/branches{/branch}","tags_url":"https://api.github.com/repos/tlvince/angular-underscore-string/tags","blobs_url":"https://api.github.com/repos/tlvince/angular-underscore-string/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tlvince/angular-underscore-string/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tlvince/angular-underscore-string/git/refs{/sha}","trees_url":"https://api.github.com/repos/tlvince/angular-underscore-string/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tlvince/angular-underscore-string/statuses/{sha}","languages_url":"https://api.github.com/repos/tlvince/angular-underscore-string/languages","stargazers_url":"https://api.github.com/repos/tlvince/angular-underscore-string/stargazers","contributors_url":"https://api.github.com/repos/tlvince/angular-underscore-string/contributors","subscribers_url":"https://api.github.com/repos/tlvince/angular-underscore-string/subscribers","subscription_url":"https://api.github.com/repos/tlvince/angular-underscore-string/subscription","commits_url":"https://api.github.com/repos/tlvince/angular-underscore-string/commits{/sha}","git_commits_url":"https://api.github.com/repos/tlvince/angular-underscore-string/git/commits{/sha}","comments_url":"https://api.github.com/repos/tlvince/angular-underscore-string/comments{/number}","issue_comment_url":"https://api.github.com/repos/tlvince/angular-underscore-string/issues/comments{/number}","contents_url":"https://api.github.com/repos/tlvince/angular-underscore-string/contents/{+path}","compare_url":"https://api.github.com/repos/tlvince/angular-underscore-string/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tlvince/angular-underscore-string/merges","archive_url":"https://api.github.com/repos/tlvince/angular-underscore-string/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tlvince/angular-underscore-string/downloads","issues_url":"https://api.github.com/repos/tlvince/angular-underscore-string/issues{/number}","pulls_url":"https://api.github.com/repos/tlvince/angular-underscore-string/pulls{/number}","milestones_url":"https://api.github.com/repos/tlvince/angular-underscore-string/milestones{/number}","notifications_url":"https://api.github.com/repos/tlvince/angular-underscore-string/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tlvince/angular-underscore-string/labels{/name}","releases_url":"https://api.github.com/repos/tlvince/angular-underscore-string/releases{/id}","created_at":"2013-12-05T18:12:36Z","updated_at":"2014-11-03T21:04:05Z","pushed_at":"2014-04-09T21:37:55Z","git_url":"git://github.com/tlvince/angular-underscore-string.git","ssh_url":"git@github.com:tlvince/angular-underscore-string.git","clone_url":"https://github.com/tlvince/angular-underscore-string.git","svn_url":"https://github.com/tlvince/angular-underscore-string","homepage":"","size":128,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tlvince/angular-underscore-string/pulls/2"},"html":{"href":"https://github.com/tlvince/angular-underscore-string/pull/2"},"issue":{"href":"https://api.github.com/repos/tlvince/angular-underscore-string/issues/2"},"comments":{"href":"https://api.github.com/repos/tlvince/angular-underscore-string/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/tlvince/angular-underscore-string/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/tlvince/angular-underscore-string/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tlvince/angular-underscore-string/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/tlvince/angular-underscore-string/statuses/83d08719bd4b58d4411a675003f60378f59a96f8"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":2,"deletions":2,"changed_files":1}}