{"action":"closed","number":153,"pull_request":{"url":"https://api.github.com/repos/NLua/NLua/pulls/153","id":31695449,"html_url":"https://github.com/NLua/NLua/pull/153","diff_url":"https://github.com/NLua/NLua/pull/153.diff","patch_url":"https://github.com/NLua/NLua/pull/153.patch","issue_url":"https://api.github.com/repos/NLua/NLua/issues/153","number":153,"state":"closed","locked":false,"title":"Quick updates to Unity3D compatibility","user":{"login":"Mervill","id":6798456,"avatar_url":"https://avatars.githubusercontent.com/u/6798456?v=3","gravatar_id":"","url":"https://api.github.com/users/Mervill","html_url":"https://github.com/Mervill","followers_url":"https://api.github.com/users/Mervill/followers","following_url":"https://api.github.com/users/Mervill/following{/other_user}","gists_url":"https://api.github.com/users/Mervill/gists{/gist_id}","starred_url":"https://api.github.com/users/Mervill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mervill/subscriptions","organizations_url":"https://api.github.com/users/Mervill/orgs","repos_url":"https://api.github.com/users/Mervill/repos","events_url":"https://api.github.com/users/Mervill/events{/privacy}","received_events_url":"https://api.github.com/users/Mervill/received_events","type":"User","site_admin":false},"body":"Hello!\r\n\r\nI have two simple commits that make NLua compile cleanly in Unity3D.\r\n\r\nThe first omits `BindFlags.cs` from being compiled when `UNITY_3D` is given as a compiler directive. I'm not 100% sure whats going on here, but the short story is that Unity uses it's own fork of an older version of mono.\r\n\r\nSeccond, as has been discussed before [https://github.com/NLua/NLua/pull/106#issuecomment-58049417] the line endings of some files have been normalized to prevent the Unity compiler from throwing warnings.\r\n\r\nI should also mention that Unity3D recently relaxed it's Indie licence and now allows indie games to load non-C# dll's. Therefore my [Unity3D-NLua](https://github.com/Mervill/Unity3D-NLua) project has ended support for KopiLua. I might resume support for KopiLua later, but I'd prefer to focus on using KeraLua/Native C now that it's available to all Unity users.\r\n\r\nThanks!","created_at":"2015-03-22T21:33:21Z","updated_at":"2015-04-01T01:25:22Z","closed_at":"2015-04-01T01:25:22Z","merged_at":"2015-04-01T01:25:22Z","merge_commit_sha":"f06c838d6346d2bd944cd83b687a98c015218c2c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NLua/NLua/pulls/153/commits","review_comments_url":"https://api.github.com/repos/NLua/NLua/pulls/153/comments","review_comment_url":"https://api.github.com/repos/NLua/NLua/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NLua/NLua/issues/153/comments","statuses_url":"https://api.github.com/repos/NLua/NLua/statuses/f7eea5c085179e5a4e07720bac3dbe48e9a62dda","head":{"label":"Mervill:master","ref":"master","sha":"f7eea5c085179e5a4e07720bac3dbe48e9a62dda","user":{"login":"Mervill","id":6798456,"avatar_url":"https://avatars.githubusercontent.com/u/6798456?v=3","gravatar_id":"","url":"https://api.github.com/users/Mervill","html_url":"https://github.com/Mervill","followers_url":"https://api.github.com/users/Mervill/followers","following_url":"https://api.github.com/users/Mervill/following{/other_user}","gists_url":"https://api.github.com/users/Mervill/gists{/gist_id}","starred_url":"https://api.github.com/users/Mervill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mervill/subscriptions","organizations_url":"https://api.github.com/users/Mervill/orgs","repos_url":"https://api.github.com/users/Mervill/repos","events_url":"https://api.github.com/users/Mervill/events{/privacy}","received_events_url":"https://api.github.com/users/Mervill/received_events","type":"User","site_admin":false},"repo":{"id":25006047,"name":"NLua","full_name":"Mervill/NLua","owner":{"login":"Mervill","id":6798456,"avatar_url":"https://avatars.githubusercontent.com/u/6798456?v=3","gravatar_id":"","url":"https://api.github.com/users/Mervill","html_url":"https://github.com/Mervill","followers_url":"https://api.github.com/users/Mervill/followers","following_url":"https://api.github.com/users/Mervill/following{/other_user}","gists_url":"https://api.github.com/users/Mervill/gists{/gist_id}","starred_url":"https://api.github.com/users/Mervill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mervill/subscriptions","organizations_url":"https://api.github.com/users/Mervill/orgs","repos_url":"https://api.github.com/users/Mervill/repos","events_url":"https://api.github.com/users/Mervill/events{/privacy}","received_events_url":"https://api.github.com/users/Mervill/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Mervill/NLua","description":"NLua is the bind between Lua world and the .NET world.","fork":true,"url":"https://api.github.com/repos/Mervill/NLua","forks_url":"https://api.github.com/repos/Mervill/NLua/forks","keys_url":"https://api.github.com/repos/Mervill/NLua/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mervill/NLua/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mervill/NLua/teams","hooks_url":"https://api.github.com/repos/Mervill/NLua/hooks","issue_events_url":"https://api.github.com/repos/Mervill/NLua/issues/events{/number}","events_url":"https://api.github.com/repos/Mervill/NLua/events","assignees_url":"https://api.github.com/repos/Mervill/NLua/assignees{/user}","branches_url":"https://api.github.com/repos/Mervill/NLua/branches{/branch}","tags_url":"https://api.github.com/repos/Mervill/NLua/tags","blobs_url":"https://api.github.com/repos/Mervill/NLua/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mervill/NLua/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mervill/NLua/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mervill/NLua/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mervill/NLua/statuses/{sha}","languages_url":"https://api.github.com/repos/Mervill/NLua/languages","stargazers_url":"https://api.github.com/repos/Mervill/NLua/stargazers","contributors_url":"https://api.github.com/repos/Mervill/NLua/contributors","subscribers_url":"https://api.github.com/repos/Mervill/NLua/subscribers","subscription_url":"https://api.github.com/repos/Mervill/NLua/subscription","commits_url":"https://api.github.com/repos/Mervill/NLua/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mervill/NLua/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mervill/NLua/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mervill/NLua/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mervill/NLua/contents/{+path}","compare_url":"https://api.github.com/repos/Mervill/NLua/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mervill/NLua/merges","archive_url":"https://api.github.com/repos/Mervill/NLua/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mervill/NLua/downloads","issues_url":"https://api.github.com/repos/Mervill/NLua/issues{/number}","pulls_url":"https://api.github.com/repos/Mervill/NLua/pulls{/number}","milestones_url":"https://api.github.com/repos/Mervill/NLua/milestones{/number}","notifications_url":"https://api.github.com/repos/Mervill/NLua/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mervill/NLua/labels{/name}","releases_url":"https://api.github.com/repos/Mervill/NLua/releases{/id}","created_at":"2014-10-09T19:53:54Z","updated_at":"2015-03-21T22:24:45Z","pushed_at":"2015-03-21T22:26:05Z","git_url":"git://github.com/Mervill/NLua.git","ssh_url":"git@github.com:Mervill/NLua.git","clone_url":"https://github.com/Mervill/NLua.git","svn_url":"https://github.com/Mervill/NLua","homepage":null,"size":3774,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NLua:master","ref":"master","sha":"20873726fb9786f811172f01d42ab48b8c619023","user":{"login":"NLua","id":3756971,"avatar_url":"https://avatars.githubusercontent.com/u/3756971?v=3","gravatar_id":"","url":"https://api.github.com/users/NLua","html_url":"https://github.com/NLua","followers_url":"https://api.github.com/users/NLua/followers","following_url":"https://api.github.com/users/NLua/following{/other_user}","gists_url":"https://api.github.com/users/NLua/gists{/gist_id}","starred_url":"https://api.github.com/users/NLua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NLua/subscriptions","organizations_url":"https://api.github.com/users/NLua/orgs","repos_url":"https://api.github.com/users/NLua/repos","events_url":"https://api.github.com/users/NLua/events{/privacy}","received_events_url":"https://api.github.com/users/NLua/received_events","type":"Organization","site_admin":false},"repo":{"id":8605054,"name":"NLua","full_name":"NLua/NLua","owner":{"login":"NLua","id":3756971,"avatar_url":"https://avatars.githubusercontent.com/u/3756971?v=3","gravatar_id":"","url":"https://api.github.com/users/NLua","html_url":"https://github.com/NLua","followers_url":"https://api.github.com/users/NLua/followers","following_url":"https://api.github.com/users/NLua/following{/other_user}","gists_url":"https://api.github.com/users/NLua/gists{/gist_id}","starred_url":"https://api.github.com/users/NLua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NLua/subscriptions","organizations_url":"https://api.github.com/users/NLua/orgs","repos_url":"https://api.github.com/users/NLua/repos","events_url":"https://api.github.com/users/NLua/events{/privacy}","received_events_url":"https://api.github.com/users/NLua/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NLua/NLua","description":"NLua is the bind between Lua world and the .NET world.","fork":false,"url":"https://api.github.com/repos/NLua/NLua","forks_url":"https://api.github.com/repos/NLua/NLua/forks","keys_url":"https://api.github.com/repos/NLua/NLua/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NLua/NLua/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NLua/NLua/teams","hooks_url":"https://api.github.com/repos/NLua/NLua/hooks","issue_events_url":"https://api.github.com/repos/NLua/NLua/issues/events{/number}","events_url":"https://api.github.com/repos/NLua/NLua/events","assignees_url":"https://api.github.com/repos/NLua/NLua/assignees{/user}","branches_url":"https://api.github.com/repos/NLua/NLua/branches{/branch}","tags_url":"https://api.github.com/repos/NLua/NLua/tags","blobs_url":"https://api.github.com/repos/NLua/NLua/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NLua/NLua/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NLua/NLua/git/refs{/sha}","trees_url":"https://api.github.com/repos/NLua/NLua/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NLua/NLua/statuses/{sha}","languages_url":"https://api.github.com/repos/NLua/NLua/languages","stargazers_url":"https://api.github.com/repos/NLua/NLua/stargazers","contributors_url":"https://api.github.com/repos/NLua/NLua/contributors","subscribers_url":"https://api.github.com/repos/NLua/NLua/subscribers","subscription_url":"https://api.github.com/repos/NLua/NLua/subscription","commits_url":"https://api.github.com/repos/NLua/NLua/commits{/sha}","git_commits_url":"https://api.github.com/repos/NLua/NLua/git/commits{/sha}","comments_url":"https://api.github.com/repos/NLua/NLua/comments{/number}","issue_comment_url":"https://api.github.com/repos/NLua/NLua/issues/comments{/number}","contents_url":"https://api.github.com/repos/NLua/NLua/contents/{+path}","compare_url":"https://api.github.com/repos/NLua/NLua/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NLua/NLua/merges","archive_url":"https://api.github.com/repos/NLua/NLua/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NLua/NLua/downloads","issues_url":"https://api.github.com/repos/NLua/NLua/issues{/number}","pulls_url":"https://api.github.com/repos/NLua/NLua/pulls{/number}","milestones_url":"https://api.github.com/repos/NLua/NLua/milestones{/number}","notifications_url":"https://api.github.com/repos/NLua/NLua/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NLua/NLua/labels{/name}","releases_url":"https://api.github.com/repos/NLua/NLua/releases{/id}","created_at":"2013-03-06T14:27:53Z","updated_at":"2015-04-01T01:17:32Z","pushed_at":"2015-04-01T01:25:22Z","git_url":"git://github.com/NLua/NLua.git","ssh_url":"git@github.com:NLua/NLua.git","clone_url":"https://github.com/NLua/NLua.git","svn_url":"https://github.com/NLua/NLua","homepage":null,"size":5338,"stargazers_count":336,"watchers_count":336,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":106,"mirror_url":null,"open_issues_count":13,"forks":106,"open_issues":13,"watchers":336,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NLua/NLua/pulls/153"},"html":{"href":"https://github.com/NLua/NLua/pull/153"},"issue":{"href":"https://api.github.com/repos/NLua/NLua/issues/153"},"comments":{"href":"https://api.github.com/repos/NLua/NLua/issues/153/comments"},"review_comments":{"href":"https://api.github.com/repos/NLua/NLua/pulls/153/comments"},"review_comment":{"href":"https://api.github.com/repos/NLua/NLua/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NLua/NLua/pulls/153/commits"},"statuses":{"href":"https://api.github.com/repos/NLua/NLua/statuses/f7eea5c085179e5a4e07720bac3dbe48e9a62dda"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"viniciusjarina","id":926868,"avatar_url":"https://avatars.githubusercontent.com/u/926868?v=3","gravatar_id":"","url":"https://api.github.com/users/viniciusjarina","html_url":"https://github.com/viniciusjarina","followers_url":"https://api.github.com/users/viniciusjarina/followers","following_url":"https://api.github.com/users/viniciusjarina/following{/other_user}","gists_url":"https://api.github.com/users/viniciusjarina/gists{/gist_id}","starred_url":"https://api.github.com/users/viniciusjarina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viniciusjarina/subscriptions","organizations_url":"https://api.github.com/users/viniciusjarina/orgs","repos_url":"https://api.github.com/users/viniciusjarina/repos","events_url":"https://api.github.com/users/viniciusjarina/events{/privacy}","received_events_url":"https://api.github.com/users/viniciusjarina/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":2,"additions":141,"deletions":140,"changed_files":3}}