{"action":"created","issue":{"url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/1785","labels_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/1785/labels{/name}","comments_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/1785/comments","events_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/1785/events","html_url":"https://github.com/magnumripper/JohnTheRipper/issues/1785","id":108450944,"number":1785,"title":"Travis/Circle warnings","user":{"login":"magnumripper","id":1268598,"avatar_url":"https://avatars.githubusercontent.com/u/1268598?v=3","gravatar_id":"","url":"https://api.github.com/users/magnumripper","html_url":"https://github.com/magnumripper","followers_url":"https://api.github.com/users/magnumripper/followers","following_url":"https://api.github.com/users/magnumripper/following{/other_user}","gists_url":"https://api.github.com/users/magnumripper/gists{/gist_id}","starred_url":"https://api.github.com/users/magnumripper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magnumripper/subscriptions","organizations_url":"https://api.github.com/users/magnumripper/orgs","repos_url":"https://api.github.com/users/magnumripper/repos","events_url":"https://api.github.com/users/magnumripper/events{/privacy}","received_events_url":"https://api.github.com/users/magnumripper/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/magnumripper/JohnTheRipper/labels/bug","name":"bug","color":"e11d21"}],"state":"open","locked":false,"assignee":{"login":"jfoug","id":1270024,"avatar_url":"https://avatars.githubusercontent.com/u/1270024?v=3","gravatar_id":"","url":"https://api.github.com/users/jfoug","html_url":"https://github.com/jfoug","followers_url":"https://api.github.com/users/jfoug/followers","following_url":"https://api.github.com/users/jfoug/following{/other_user}","gists_url":"https://api.github.com/users/jfoug/gists{/gist_id}","starred_url":"https://api.github.com/users/jfoug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfoug/subscriptions","organizations_url":"https://api.github.com/users/jfoug/orgs","repos_url":"https://api.github.com/users/jfoug/repos","events_url":"https://api.github.com/users/jfoug/events{/privacy}","received_events_url":"https://api.github.com/users/jfoug/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/magnumripper/JohnTheRipper/milestones/2","html_url":"https://github.com/magnumripper/JohnTheRipper/milestones/1.8.0-jumbo-2","labels_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/milestones/2/labels","id":492145,"number":2,"title":"1.8.0-jumbo-2","description":"Please assign ALL issues which should be in J2 to this milestone, and lets push forward in fixing all of them.","creator":{"login":"magnumripper","id":1268598,"avatar_url":"https://avatars.githubusercontent.com/u/1268598?v=3","gravatar_id":"","url":"https://api.github.com/users/magnumripper","html_url":"https://github.com/magnumripper","followers_url":"https://api.github.com/users/magnumripper/followers","following_url":"https://api.github.com/users/magnumripper/following{/other_user}","gists_url":"https://api.github.com/users/magnumripper/gists{/gist_id}","starred_url":"https://api.github.com/users/magnumripper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magnumripper/subscriptions","organizations_url":"https://api.github.com/users/magnumripper/orgs","repos_url":"https://api.github.com/users/magnumripper/repos","events_url":"https://api.github.com/users/magnumripper/events{/privacy}","received_events_url":"https://api.github.com/users/magnumripper/received_events","type":"User","site_admin":false},"open_issues":73,"closed_issues":172,"state":"open","created_at":"2013-11-21T06:59:25Z","updated_at":"2015-09-26T09:06:57Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2015-09-26T09:06:57Z","updated_at":"2015-09-26T14:53:46Z","closed_at":null,"body":"Travis gcc\r\n```\r\npostgres_fmt_plug.c: In function ‘valid’:\r\npostgres_fmt_plug.c:112:2: warning: passing argument 1 of ‘hexlenl’ discards ‘const’ qualifier from pointer target type [enabled by default]\r\ncommon.h:120:5: note: expected ‘char *’ but argument is of type ‘const char *’\r\npostgres_fmt_plug.c:119:2: warning: passing argument 1 of ‘hexlenl’ discards ‘const’ qualifier from pointer target type [enabled by default]\r\ncommon.h:120:5: note: expected ‘char *’ but argument is of type ‘const char *’\r\n```\r\n\r\nTravis clang\r\n```\r\nlotus85_fmt_plug.c:59:19: warning: unused variable 'LOTUS85_BASE16_CHARSET'\r\n      [-Wunused-const-variable]\r\nstatic const char LOTUS85_BASE16_CHARSET[] = \"0123456789ABCDEFabcdef\";\r\n                  ^\r\n1 warning generated.\r\npostgres_fmt_plug.c:112:14: warning: passing 'const char *' to parameter of type\r\n      'char *' discards qualifiers\r\n      [-Wincompatible-pointer-types-discards-qualifiers]\r\n        if (hexlenl(&p[1]) != 2*BINARY_SIZE)\r\n                    ^~~~~\r\n./common.h:120:19: note: passing argument to parameter 'q' here\r\nint hexlenl(char *q); /* lower cased only */\r\n                  ^\r\npostgres_fmt_plug.c:119:18: warning: passing 'const char *' to parameter of type\r\n      'char *' discards qualifiers\r\n      [-Wincompatible-pointer-types-discards-qualifiers]\r\n        if (abs(hexlenl(&p[1])) != 8)\r\n                        ^~~~~\r\n./common.h:120:19: note: passing argument to parameter 'q' here\r\nint hexlenl(char *q); /* lower cased only */\r\n```\r\n\r\nCircle\r\n```\r\npostgres_fmt_plug.c: In function 'valid':\r\npostgres_fmt_plug.c:112:14: warning: passing argument 1 of 'hexlenl' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]\r\n  if (hexlenl(&p[1]) != 2*BINARY_SIZE)\r\n              ^\r\nIn file included from postgres_fmt_plug.c:35:0:\r\ncommon.h:120:5: note: expected 'char *' but argument is of type 'const char *'\r\n int hexlenl(char *q); /* lower cased only */\r\n     ^\r\npostgres_fmt_plug.c:119:18: warning: passing argument 1 of 'hexlenl' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]\r\n  if (abs(hexlenl(&p[1])) != 8)\r\n                  ^\r\nIn file included from postgres_fmt_plug.c:35:0:\r\ncommon.h:120:5: note: expected 'char *' but argument is of type 'const char *'\r\n int hexlenl(char *q); /* lower cased only */\r\n     ^\r\n```"},"comment":{"url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/comments/143460766","html_url":"https://github.com/magnumripper/JohnTheRipper/issues/1785#issuecomment-143460766","issue_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/1785","id":143460766,"user":{"login":"jfoug","id":1270024,"avatar_url":"https://avatars.githubusercontent.com/u/1270024?v=3","gravatar_id":"","url":"https://api.github.com/users/jfoug","html_url":"https://github.com/jfoug","followers_url":"https://api.github.com/users/jfoug/followers","following_url":"https://api.github.com/users/jfoug/following{/other_user}","gists_url":"https://api.github.com/users/jfoug/gists{/gist_id}","starred_url":"https://api.github.com/users/jfoug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfoug/subscriptions","organizations_url":"https://api.github.com/users/jfoug/orgs","repos_url":"https://api.github.com/users/jfoug/repos","events_url":"https://api.github.com/users/jfoug/events{/privacy}","received_events_url":"https://api.github.com/users/jfoug/received_events","type":"User","site_admin":false},"created_at":"2015-09-26T14:53:46Z","updated_at":"2015-09-26T14:53:46Z","body":"```\r\n#if AC_BUILT && !HAVE_STRCASESTR || !AC_BUILT && defined(__MINGW__)\r\nchar *strcasestr(const char *haystack, const char *needle);\r\n#endif\r\n```\r\nthe ```||``` in the if is being added.  NOTE, we are doing mingw without a configure, (legacy).  That is why this 'implicit' warning is happening, I think.   That the code LINKS bothers me. It means that mingw actually must 'have' that function, it simply does not expose it, at least in the same way that we have header includes.   So I am adding the same OR block to the jumbo.c file also.  NOTE, it may cause the mingw build to fail (multiple defined at link time).  We will have to see.  But if we are going to use our declaration, we should use our definition of the function.  The mingw 'could' be defined in a dll or something, so I am not sure about this one.  But the implementation we have is safe and matches 100% what is declared in jumbo.h (albet a little slow)."}}