{"action":"created","issue":{"url":"https://api.github.com/repos/HewlettPackard/grommet/issues/168","labels_url":"https://api.github.com/repos/HewlettPackard/grommet/issues/168/labels{/name}","comments_url":"https://api.github.com/repos/HewlettPackard/grommet/issues/168/comments","events_url":"https://api.github.com/repos/HewlettPackard/grommet/issues/168/events","html_url":"https://github.com/HewlettPackard/grommet/issues/168","id":102860614,"number":168,"title":"[people-finder] project issues with eslint","user":{"login":"rtspotts","id":13949416,"avatar_url":"https://avatars.githubusercontent.com/u/13949416?v=3","gravatar_id":"","url":"https://api.github.com/users/rtspotts","html_url":"https://github.com/rtspotts","followers_url":"https://api.github.com/users/rtspotts/followers","following_url":"https://api.github.com/users/rtspotts/following{/other_user}","gists_url":"https://api.github.com/users/rtspotts/gists{/gist_id}","starred_url":"https://api.github.com/users/rtspotts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtspotts/subscriptions","organizations_url":"https://api.github.com/users/rtspotts/orgs","repos_url":"https://api.github.com/users/rtspotts/repos","events_url":"https://api.github.com/users/rtspotts/events{/privacy}","received_events_url":"https://api.github.com/users/rtspotts/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-24T18:29:01Z","updated_at":"2015-08-24T18:47:14Z","closed_at":null,"body":"Installed the people finder example app using 'grommet init people-finder' and ran 'npm install' in the people-finder directory.  When trying to get the dev environment running with 'gulp dev' there is an error thrown in the eslint process:\r\n\r\nError: Definition for rule 'react/jsx-max-props-per-line' was not found.\r\nat C:\\Users\\RTS\\Grommet_Apps\\people-finder\\node_modules\\eslint\\lib\\eslint.js\r\n:647:27\r\n\r\nCommenting the lines:   \r\n\r\n  73:  react/jsx-max-props-per-line: 1\r\n  74:  react/jsx-no-duplicate-props: 1\r\n\r\nin **people-finder/node_modules/grommet/utils/gulp/eslintrc** clears up the problem.  It appears that the rules above are not supported by the eslint and eslint-plugin-react versions specified in the package.json file supplied in the example."},"comment":{"url":"https://api.github.com/repos/HewlettPackard/grommet/issues/comments/134335098","html_url":"https://github.com/HewlettPackard/grommet/issues/168#issuecomment-134335098","issue_url":"https://api.github.com/repos/HewlettPackard/grommet/issues/168","id":134335098,"user":{"login":"alansouzati","id":1207250,"avatar_url":"https://avatars.githubusercontent.com/u/1207250?v=3","gravatar_id":"","url":"https://api.github.com/users/alansouzati","html_url":"https://github.com/alansouzati","followers_url":"https://api.github.com/users/alansouzati/followers","following_url":"https://api.github.com/users/alansouzati/following{/other_user}","gists_url":"https://api.github.com/users/alansouzati/gists{/gist_id}","starred_url":"https://api.github.com/users/alansouzati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alansouzati/subscriptions","organizations_url":"https://api.github.com/users/alansouzati/orgs","repos_url":"https://api.github.com/users/alansouzati/repos","events_url":"https://api.github.com/users/alansouzati/events{/privacy}","received_events_url":"https://api.github.com/users/alansouzati/received_events","type":"User","site_admin":false},"created_at":"2015-08-24T18:47:14Z","updated_at":"2015-08-24T18:47:14Z","body":"Thanks @rtspotts for submitting this. \r\n\r\nIf you are using Grommet version `< 0.3.2` then your package.json has the dependency set like this:\r\n\r\n```\r\n  dependencies: {\r\n    \"grommet\": \"https://github.com/HewlettPackard/grommet.git#stable\"\r\n  }\r\n```\r\n\r\nThis means that we are using the latest stable branch (every commit that passed the CI build). As we are in early stages, this is sometimes extremely useful because it allows you to get the latest bits from Grommet without waiting for an actual release.\r\n\r\nAt the same time, this is problematic because of conflicting changes. \r\n\r\nThis is the issue you are facing, the latest stable branch had a change that conflicted with your version of eslint, as you pointed out.\r\n\r\nThere are a couple of fixes possible for this:\r\n\r\n### Update grommet\r\n\r\nRecommended\r\n\r\n```\r\n$ npm update -g grommet\r\n$ grommet --version //0.3.2\r\n$ grommet init people-finder\r\n```\r\n\r\n### Update library dependencies\r\n\r\n```\r\n  dependencies: {\r\n    \"grommet\": \"https://github.com/HewlettPackard/grommet.git#stable\"\r\n  },\r\n  devDependencies: {\r\n    ...\r\n    \"gulp-eslint\": \"^1.0.0\",\r\n    \"eslint\": \"^1.1.0\",\r\n    \"eslint-plugin-react\": \"^3.2.3\",\r\n    ...\r\n  }\r\n```\r\n\r\nthen run `npm update` inside people-finder\r\n\r\n### Use a fixed Grommet version in your package.json:\r\n\r\n```\r\n  dependencies: {\r\n    \"grommet\": \"0.3.1\"\r\n  }\r\n```\r\n\r\nthen run `npm update` inside people-finder\r\n\r\nPlease let us know if any of these fixes worked for you."}}