{"action":"created","comment":{"url":"https://api.github.com/repos/servo/servo/pulls/comments/43119964","id":43119964,"diff_hunk":"@@ -353,9 +378,10 @@ impl WebSocketMethods for WebSocket {\n         let mut other_sender = self.sender.borrow_mut();\n         let my_sender = other_sender.as_mut().unwrap();\n \n-        self.buffered_amount.set(self.buffered_amount.get() + (data.0.as_bytes().len() as u32));\n+        self.buffered_amount.set(bufferedAmount);\n \n-        let _ = my_sender.lock().unwrap().send_message(Message::Text(data.0));\n+        /*Previously, the message was sent before this section\n+          will this make a difference?*/","path":"components/script/dom/websocket.rs","position":41,"original_position":41,"commit_id":"6d2ca6b099a5d1fda5a5b3689b5b07cd19be52a4","original_commit_id":"6d2ca6b099a5d1fda5a5b3689b5b07cd19be52a4","user":{"login":"jdm","id":27658,"avatar_url":"https://avatars.githubusercontent.com/u/27658?v=3","gravatar_id":"","url":"https://api.github.com/users/jdm","html_url":"https://github.com/jdm","followers_url":"https://api.github.com/users/jdm/followers","following_url":"https://api.github.com/users/jdm/following{/other_user}","gists_url":"https://api.github.com/users/jdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdm/subscriptions","organizations_url":"https://api.github.com/users/jdm/orgs","repos_url":"https://api.github.com/users/jdm/repos","events_url":"https://api.github.com/users/jdm/events{/privacy}","received_events_url":"https://api.github.com/users/jdm/received_events","type":"User","site_admin":false},"body":"It will not make a difference.","created_at":"2015-10-27T13:26:07Z","updated_at":"2015-10-27T13:26:07Z","html_url":"https://github.com/servo/servo/pull/8218#discussion_r43119964","pull_request_url":"https://api.github.com/repos/servo/servo/pulls/8218","_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/43119964"},"html":{"href":"https://github.com/servo/servo/pull/8218#discussion_r43119964"},"pull_request":{"href":"https://api.github.com/repos/servo/servo/pulls/8218"}}},"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/8218","id":48824947,"html_url":"https://github.com/servo/servo/pull/8218","diff_url":"https://github.com/servo/servo/pull/8218.diff","patch_url":"https://github.com/servo/servo/pull/8218.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/8218","number":8218,"state":"open","locked":false,"title":"#8213: Implement Blob variant of WebSocket.send","user":{"login":"nikkisquared","id":7886109,"avatar_url":"https://avatars.githubusercontent.com/u/7886109?v=3","gravatar_id":"","url":"https://api.github.com/users/nikkisquared","html_url":"https://github.com/nikkisquared","followers_url":"https://api.github.com/users/nikkisquared/followers","following_url":"https://api.github.com/users/nikkisquared/following{/other_user}","gists_url":"https://api.github.com/users/nikkisquared/gists{/gist_id}","starred_url":"https://api.github.com/users/nikkisquared/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikkisquared/subscriptions","organizations_url":"https://api.github.com/users/nikkisquared/orgs","repos_url":"https://api.github.com/users/nikkisquared/repos","events_url":"https://api.github.com/users/nikkisquared/events{/privacy}","received_events_url":"https://api.github.com/users/nikkisquared/received_events","type":"User","site_admin":false},"body":"I'm working on resolving https://github.com/servo/servo/issues/8213 as per the spec online and feedback in the servo channel. Note that currently I cannot build (and thus test) my code, so this is a bit of a rough first draft. I'd still like feedback on my progress, and I hope that there is another way for my code to be tested.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/servo/servo/8218)\n<!-- Reviewable:end -->\n","created_at":"2015-10-27T03:26:49Z","updated_at":"2015-10-27T13:26:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41f53cf05ef5e4175b004f0e7e665f612db79fad","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/8218/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/8218/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/8218/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/6d2ca6b099a5d1fda5a5b3689b5b07cd19be52a4","head":{"label":"nikkisquared:master","ref":"master","sha":"6d2ca6b099a5d1fda5a5b3689b5b07cd19be52a4","user":{"login":"nikkisquared","id":7886109,"avatar_url":"https://avatars.githubusercontent.com/u/7886109?v=3","gravatar_id":"","url":"https://api.github.com/users/nikkisquared","html_url":"https://github.com/nikkisquared","followers_url":"https://api.github.com/users/nikkisquared/followers","following_url":"https://api.github.com/users/nikkisquared/following{/other_user}","gists_url":"https://api.github.com/users/nikkisquared/gists{/gist_id}","starred_url":"https://api.github.com/users/nikkisquared/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikkisquared/subscriptions","organizations_url":"https://api.github.com/users/nikkisquared/orgs","repos_url":"https://api.github.com/users/nikkisquared/repos","events_url":"https://api.github.com/users/nikkisquared/events{/privacy}","received_events_url":"https://api.github.com/users/nikkisquared/received_events","type":"User","site_admin":false},"repo":{"id":44995414,"name":"servo","full_name":"nikkisquared/servo","owner":{"login":"nikkisquared","id":7886109,"avatar_url":"https://avatars.githubusercontent.com/u/7886109?v=3","gravatar_id":"","url":"https://api.github.com/users/nikkisquared","html_url":"https://github.com/nikkisquared","followers_url":"https://api.github.com/users/nikkisquared/followers","following_url":"https://api.github.com/users/nikkisquared/following{/other_user}","gists_url":"https://api.github.com/users/nikkisquared/gists{/gist_id}","starred_url":"https://api.github.com/users/nikkisquared/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikkisquared/subscriptions","organizations_url":"https://api.github.com/users/nikkisquared/orgs","repos_url":"https://api.github.com/users/nikkisquared/repos","events_url":"https://api.github.com/users/nikkisquared/events{/privacy}","received_events_url":"https://api.github.com/users/nikkisquared/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nikkisquared/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/nikkisquared/servo","forks_url":"https://api.github.com/repos/nikkisquared/servo/forks","keys_url":"https://api.github.com/repos/nikkisquared/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nikkisquared/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nikkisquared/servo/teams","hooks_url":"https://api.github.com/repos/nikkisquared/servo/hooks","issue_events_url":"https://api.github.com/repos/nikkisquared/servo/issues/events{/number}","events_url":"https://api.github.com/repos/nikkisquared/servo/events","assignees_url":"https://api.github.com/repos/nikkisquared/servo/assignees{/user}","branches_url":"https://api.github.com/repos/nikkisquared/servo/branches{/branch}","tags_url":"https://api.github.com/repos/nikkisquared/servo/tags","blobs_url":"https://api.github.com/repos/nikkisquared/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nikkisquared/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nikkisquared/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/nikkisquared/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nikkisquared/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/nikkisquared/servo/languages","stargazers_url":"https://api.github.com/repos/nikkisquared/servo/stargazers","contributors_url":"https://api.github.com/repos/nikkisquared/servo/contributors","subscribers_url":"https://api.github.com/repos/nikkisquared/servo/subscribers","subscription_url":"https://api.github.com/repos/nikkisquared/servo/subscription","commits_url":"https://api.github.com/repos/nikkisquared/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/nikkisquared/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/nikkisquared/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/nikkisquared/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/nikkisquared/servo/contents/{+path}","compare_url":"https://api.github.com/repos/nikkisquared/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nikkisquared/servo/merges","archive_url":"https://api.github.com/repos/nikkisquared/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nikkisquared/servo/downloads","issues_url":"https://api.github.com/repos/nikkisquared/servo/issues{/number}","pulls_url":"https://api.github.com/repos/nikkisquared/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/nikkisquared/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/nikkisquared/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nikkisquared/servo/labels{/name}","releases_url":"https://api.github.com/repos/nikkisquared/servo/releases{/id}","created_at":"2015-10-26T20:31:05Z","updated_at":"2015-10-26T20:04:06Z","pushed_at":"2015-10-27T03:22:51Z","git_url":"git://github.com/nikkisquared/servo.git","ssh_url":"git@github.com:nikkisquared/servo.git","clone_url":"https://github.com/nikkisquared/servo.git","svn_url":"https://github.com/nikkisquared/servo","homepage":"","size":144863,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"e49c7a3acbc36549e52f99ad67048f5e31352bad","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","created_at":"2012-02-08T19:07:25Z","updated_at":"2015-10-27T12:55:43Z","pushed_at":"2015-10-27T13:15:26Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"","size":348780,"stargazers_count":5065,"watchers_count":5065,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":821,"mirror_url":null,"open_issues_count":1199,"forks":821,"open_issues":1199,"watchers":5065,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/8218"},"html":{"href":"https://github.com/servo/servo/pull/8218"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/8218"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/8218/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/8218/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/8218/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/6d2ca6b099a5d1fda5a5b3689b5b07cd19be52a4"}}}}