{"action":"created","comment":{"url":"https://api.github.com/repos/ecomfe/ub-ria-ui/pulls/comments/39942863","id":39942863,"diff_hunk":"@@ -126,22 +129,31 @@ define(function (require) {\n                     'a',\n                     function (e) {\n                         var itemClass = controlHelper.getPartClassName('item');\n+                        var itemRemoveClass = controlHelper.getPartClassName('item-remove');\n                         var cmdItemClass = controlHelper.getPartClassName('item-cmd');\n                         var $t = $(e.target);\n+                        var $tWrapper = $t.closest('a');","path":"src/filter/Filter.js","position":58,"original_position":58,"commit_id":"4c82960da2ee87f35dd0a3d4c143866bc09b6a80","original_commit_id":"4c82960da2ee87f35dd0a3d4c143866bc09b6a80","user":{"login":"Justineo","id":1726061,"avatar_url":"https://avatars.githubusercontent.com/u/1726061?v=3","gravatar_id":"","url":"https://api.github.com/users/Justineo","html_url":"https://github.com/Justineo","followers_url":"https://api.github.com/users/Justineo/followers","following_url":"https://api.github.com/users/Justineo/following{/other_user}","gists_url":"https://api.github.com/users/Justineo/gists{/gist_id}","starred_url":"https://api.github.com/users/Justineo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Justineo/subscriptions","organizations_url":"https://api.github.com/users/Justineo/orgs","repos_url":"https://api.github.com/users/Justineo/repos","events_url":"https://api.github.com/users/Justineo/events{/privacy}","received_events_url":"https://api.github.com/users/Justineo/received_events","type":"User","site_admin":false},"body":"我们的编码规范没有允许此类例外。\r\n\r\n@otakustay 怎么看？我觉得还是有必要理清楚这样命名的需求是否合理的：\r\n\r\n1. 如果我们所有 DOM 操作都通过 jQuery 进行，那么不会有 HTMLElement 的引用，默认表示引用 DOM 内容的都是 jQuery 对象；\r\n2. 代码中如果是原生/jQuery 操作都有，那么有什么方式能够让这个对象是否是 jQuery 对象一目了然呢？用 `$` 开头来做此区分似乎是比较常见的做法，但是与我们的编码规范相违背。","created_at":"2015-09-21T06:00:03Z","updated_at":"2015-09-21T06:00:03Z","html_url":"https://github.com/ecomfe/ub-ria-ui/pull/99#discussion_r39942863","pull_request_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/pulls/99","_links":{"self":{"href":"https://api.github.com/repos/ecomfe/ub-ria-ui/pulls/comments/39942863"},"html":{"href":"https://github.com/ecomfe/ub-ria-ui/pull/99#discussion_r39942863"},"pull_request":{"href":"https://api.github.com/repos/ecomfe/ub-ria-ui/pulls/99"}}},"pull_request":{"url":"https://api.github.com/repos/ecomfe/ub-ria-ui/pulls/99","id":45381931,"html_url":"https://github.com/ecomfe/ub-ria-ui/pull/99","diff_url":"https://github.com/ecomfe/ub-ria-ui/pull/99.diff","patch_url":"https://github.com/ecomfe/ub-ria-ui/pull/99.patch","issue_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/issues/99","number":99,"state":"open","locked":false,"title":"控件升级-9.18","user":{"login":"bobshen","id":2577670,"avatar_url":"https://avatars.githubusercontent.com/u/2577670?v=3","gravatar_id":"","url":"https://api.github.com/users/bobshen","html_url":"https://github.com/bobshen","followers_url":"https://api.github.com/users/bobshen/followers","following_url":"https://api.github.com/users/bobshen/following{/other_user}","gists_url":"https://api.github.com/users/bobshen/gists{/gist_id}","starred_url":"https://api.github.com/users/bobshen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobshen/subscriptions","organizations_url":"https://api.github.com/users/bobshen/orgs","repos_url":"https://api.github.com/users/bobshen/repos","events_url":"https://api.github.com/users/bobshen/events{/privacy}","received_events_url":"https://api.github.com/users/bobshen/received_events","type":"User","site_admin":false},"body":"1. AutoComplete的事件参数升级\r\n2. Filter支持删除添加的自定义选择项","created_at":"2015-09-18T08:41:40Z","updated_at":"2015-09-21T06:00:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ecf2f5822f978f9dc13cf8a52d212372df2f7bb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/pulls/99/commits","review_comments_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/pulls/99/comments","review_comment_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/issues/99/comments","statuses_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/statuses/4c82960da2ee87f35dd0a3d4c143866bc09b6a80","head":{"label":"bobshen:master","ref":"master","sha":"4c82960da2ee87f35dd0a3d4c143866bc09b6a80","user":{"login":"bobshen","id":2577670,"avatar_url":"https://avatars.githubusercontent.com/u/2577670?v=3","gravatar_id":"","url":"https://api.github.com/users/bobshen","html_url":"https://github.com/bobshen","followers_url":"https://api.github.com/users/bobshen/followers","following_url":"https://api.github.com/users/bobshen/following{/other_user}","gists_url":"https://api.github.com/users/bobshen/gists{/gist_id}","starred_url":"https://api.github.com/users/bobshen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobshen/subscriptions","organizations_url":"https://api.github.com/users/bobshen/orgs","repos_url":"https://api.github.com/users/bobshen/repos","events_url":"https://api.github.com/users/bobshen/events{/privacy}","received_events_url":"https://api.github.com/users/bobshen/received_events","type":"User","site_admin":false},"repo":{"id":42705931,"name":"ub-ria-ui","full_name":"bobshen/ub-ria-ui","owner":{"login":"bobshen","id":2577670,"avatar_url":"https://avatars.githubusercontent.com/u/2577670?v=3","gravatar_id":"","url":"https://api.github.com/users/bobshen","html_url":"https://github.com/bobshen","followers_url":"https://api.github.com/users/bobshen/followers","following_url":"https://api.github.com/users/bobshen/following{/other_user}","gists_url":"https://api.github.com/users/bobshen/gists{/gist_id}","starred_url":"https://api.github.com/users/bobshen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobshen/subscriptions","organizations_url":"https://api.github.com/users/bobshen/orgs","repos_url":"https://api.github.com/users/bobshen/repos","events_url":"https://api.github.com/users/bobshen/events{/privacy}","received_events_url":"https://api.github.com/users/bobshen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bobshen/ub-ria-ui","description":"UI components for ub ria applications - standardized & implemented","fork":true,"url":"https://api.github.com/repos/bobshen/ub-ria-ui","forks_url":"https://api.github.com/repos/bobshen/ub-ria-ui/forks","keys_url":"https://api.github.com/repos/bobshen/ub-ria-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bobshen/ub-ria-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bobshen/ub-ria-ui/teams","hooks_url":"https://api.github.com/repos/bobshen/ub-ria-ui/hooks","issue_events_url":"https://api.github.com/repos/bobshen/ub-ria-ui/issues/events{/number}","events_url":"https://api.github.com/repos/bobshen/ub-ria-ui/events","assignees_url":"https://api.github.com/repos/bobshen/ub-ria-ui/assignees{/user}","branches_url":"https://api.github.com/repos/bobshen/ub-ria-ui/branches{/branch}","tags_url":"https://api.github.com/repos/bobshen/ub-ria-ui/tags","blobs_url":"https://api.github.com/repos/bobshen/ub-ria-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bobshen/ub-ria-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bobshen/ub-ria-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/bobshen/ub-ria-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bobshen/ub-ria-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/bobshen/ub-ria-ui/languages","stargazers_url":"https://api.github.com/repos/bobshen/ub-ria-ui/stargazers","contributors_url":"https://api.github.com/repos/bobshen/ub-ria-ui/contributors","subscribers_url":"https://api.github.com/repos/bobshen/ub-ria-ui/subscribers","subscription_url":"https://api.github.com/repos/bobshen/ub-ria-ui/subscription","commits_url":"https://api.github.com/repos/bobshen/ub-ria-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/bobshen/ub-ria-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/bobshen/ub-ria-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/bobshen/ub-ria-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/bobshen/ub-ria-ui/contents/{+path}","compare_url":"https://api.github.com/repos/bobshen/ub-ria-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bobshen/ub-ria-ui/merges","archive_url":"https://api.github.com/repos/bobshen/ub-ria-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bobshen/ub-ria-ui/downloads","issues_url":"https://api.github.com/repos/bobshen/ub-ria-ui/issues{/number}","pulls_url":"https://api.github.com/repos/bobshen/ub-ria-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/bobshen/ub-ria-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/bobshen/ub-ria-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bobshen/ub-ria-ui/labels{/name}","releases_url":"https://api.github.com/repos/bobshen/ub-ria-ui/releases{/id}","created_at":"2015-09-18T07:17:29Z","updated_at":"2015-09-18T07:17:30Z","pushed_at":"2015-09-18T09:01:20Z","git_url":"git://github.com/bobshen/ub-ria-ui.git","ssh_url":"git@github.com:bobshen/ub-ria-ui.git","clone_url":"https://github.com/bobshen/ub-ria-ui.git","svn_url":"https://github.com/bobshen/ub-ria-ui","homepage":null,"size":5275,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ecomfe:master","ref":"master","sha":"5dca7a794f4e5683c0a0caf5555c876233b56684","user":{"login":"ecomfe","id":2268460,"avatar_url":"https://avatars.githubusercontent.com/u/2268460?v=3","gravatar_id":"","url":"https://api.github.com/users/ecomfe","html_url":"https://github.com/ecomfe","followers_url":"https://api.github.com/users/ecomfe/followers","following_url":"https://api.github.com/users/ecomfe/following{/other_user}","gists_url":"https://api.github.com/users/ecomfe/gists{/gist_id}","starred_url":"https://api.github.com/users/ecomfe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecomfe/subscriptions","organizations_url":"https://api.github.com/users/ecomfe/orgs","repos_url":"https://api.github.com/users/ecomfe/repos","events_url":"https://api.github.com/users/ecomfe/events{/privacy}","received_events_url":"https://api.github.com/users/ecomfe/received_events","type":"Organization","site_admin":false},"repo":{"id":23924615,"name":"ub-ria-ui","full_name":"ecomfe/ub-ria-ui","owner":{"login":"ecomfe","id":2268460,"avatar_url":"https://avatars.githubusercontent.com/u/2268460?v=3","gravatar_id":"","url":"https://api.github.com/users/ecomfe","html_url":"https://github.com/ecomfe","followers_url":"https://api.github.com/users/ecomfe/followers","following_url":"https://api.github.com/users/ecomfe/following{/other_user}","gists_url":"https://api.github.com/users/ecomfe/gists{/gist_id}","starred_url":"https://api.github.com/users/ecomfe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecomfe/subscriptions","organizations_url":"https://api.github.com/users/ecomfe/orgs","repos_url":"https://api.github.com/users/ecomfe/repos","events_url":"https://api.github.com/users/ecomfe/events{/privacy}","received_events_url":"https://api.github.com/users/ecomfe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ecomfe/ub-ria-ui","description":"UI components for ub ria applications - standardized & implemented","fork":false,"url":"https://api.github.com/repos/ecomfe/ub-ria-ui","forks_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/forks","keys_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/teams","hooks_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/hooks","issue_events_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/issues/events{/number}","events_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/events","assignees_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/assignees{/user}","branches_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/branches{/branch}","tags_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/tags","blobs_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/languages","stargazers_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/stargazers","contributors_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/contributors","subscribers_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/subscribers","subscription_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/subscription","commits_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/contents/{+path}","compare_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/merges","archive_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/downloads","issues_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/issues{/number}","pulls_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/labels{/name}","releases_url":"https://api.github.com/repos/ecomfe/ub-ria-ui/releases{/id}","created_at":"2014-09-11T15:43:21Z","updated_at":"2015-09-16T08:55:58Z","pushed_at":"2015-09-18T09:01:21Z","git_url":"git://github.com/ecomfe/ub-ria-ui.git","ssh_url":"git@github.com:ecomfe/ub-ria-ui.git","clone_url":"https://github.com/ecomfe/ub-ria-ui.git","svn_url":"https://github.com/ecomfe/ub-ria-ui","homepage":null,"size":5275,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":24,"forks":24,"open_issues":24,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ecomfe/ub-ria-ui/pulls/99"},"html":{"href":"https://github.com/ecomfe/ub-ria-ui/pull/99"},"issue":{"href":"https://api.github.com/repos/ecomfe/ub-ria-ui/issues/99"},"comments":{"href":"https://api.github.com/repos/ecomfe/ub-ria-ui/issues/99/comments"},"review_comments":{"href":"https://api.github.com/repos/ecomfe/ub-ria-ui/pulls/99/comments"},"review_comment":{"href":"https://api.github.com/repos/ecomfe/ub-ria-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ecomfe/ub-ria-ui/pulls/99/commits"},"statuses":{"href":"https://api.github.com/repos/ecomfe/ub-ria-ui/statuses/4c82960da2ee87f35dd0a3d4c143866bc09b6a80"}}}}