{"action":"created","issue":{"url":"https://api.github.com/repos/mesosphere/marathon-ui/issues/321","labels_url":"https://api.github.com/repos/mesosphere/marathon-ui/issues/321/labels{/name}","comments_url":"https://api.github.com/repos/mesosphere/marathon-ui/issues/321/comments","events_url":"https://api.github.com/repos/mesosphere/marathon-ui/issues/321/events","html_url":"https://github.com/mesosphere/marathon-ui/pull/321","id":111991551,"number":321,"title":"Collapsing breadcrumbs","user":{"login":"philipnrmn","id":2989362,"avatar_url":"https://avatars.githubusercontent.com/u/2989362?v=3","gravatar_id":"","url":"https://api.github.com/users/philipnrmn","html_url":"https://github.com/philipnrmn","followers_url":"https://api.github.com/users/philipnrmn/followers","following_url":"https://api.github.com/users/philipnrmn/following{/other_user}","gists_url":"https://api.github.com/users/philipnrmn/gists{/gist_id}","starred_url":"https://api.github.com/users/philipnrmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philipnrmn/subscriptions","organizations_url":"https://api.github.com/users/philipnrmn/orgs","repos_url":"https://api.github.com/users/philipnrmn/repos","events_url":"https://api.github.com/users/philipnrmn/events{/privacy}","received_events_url":"https://api.github.com/users/philipnrmn/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mesosphere/marathon-ui/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"aldipower","id":859154,"avatar_url":"https://avatars.githubusercontent.com/u/859154?v=3","gravatar_id":"","url":"https://api.github.com/users/aldipower","html_url":"https://github.com/aldipower","followers_url":"https://api.github.com/users/aldipower/followers","following_url":"https://api.github.com/users/aldipower/following{/other_user}","gists_url":"https://api.github.com/users/aldipower/gists{/gist_id}","starred_url":"https://api.github.com/users/aldipower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aldipower/subscriptions","organizations_url":"https://api.github.com/users/aldipower/orgs","repos_url":"https://api.github.com/users/aldipower/repos","events_url":"https://api.github.com/users/aldipower/events{/privacy}","received_events_url":"https://api.github.com/users/aldipower/received_events","type":"User","site_admin":false},"milestone":null,"comments":4,"created_at":"2015-10-18T00:01:54Z","updated_at":"2015-10-19T11:51:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mesosphere/marathon-ui/pulls/321","html_url":"https://github.com/mesosphere/marathon-ui/pull/321","diff_url":"https://github.com/mesosphere/marathon-ui/pull/321.diff","patch_url":"https://github.com/mesosphere/marathon-ui/pull/321.patch"},"body":"A tentative PR, as this functionality has some issues and I'm not sure it's yet good enough to merge. \r\n\r\nThe breadcrumbs now collapse to ellipsis when the user manipulates the window size in the usual 'is it responsive' test. More usefully, they render as ellipsis when the path is too long to fit. \r\n\r\nThe drawback is that when the user uses the breadcrumbs to navigate to parent groups, the breadcrumb component cannot gauge whether they can render in the available space without performing that render step. That is to say, having collapsed the breadcrumbs, it's hard to expand them. \r\n\r\nWithout a pure CSS solution (I was not able to find one that was satisfactory) and without resorting to funky text-width heuristics, this is hard to resolve elegantly. The only alternative I could work out was to maintain an `visibility: hidden` set of text elements in the DOM to track the inner width of the breadcrumbs, but this is a brutal way of going about it and I reverted that work. "},"comment":{"url":"https://api.github.com/repos/mesosphere/marathon-ui/issues/comments/149192613","html_url":"https://github.com/mesosphere/marathon-ui/pull/321#issuecomment-149192613","issue_url":"https://api.github.com/repos/mesosphere/marathon-ui/issues/321","id":149192613,"user":{"login":"philipnrmn","id":2989362,"avatar_url":"https://avatars.githubusercontent.com/u/2989362?v=3","gravatar_id":"","url":"https://api.github.com/users/philipnrmn","html_url":"https://github.com/philipnrmn","followers_url":"https://api.github.com/users/philipnrmn/followers","following_url":"https://api.github.com/users/philipnrmn/following{/other_user}","gists_url":"https://api.github.com/users/philipnrmn/gists{/gist_id}","starred_url":"https://api.github.com/users/philipnrmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philipnrmn/subscriptions","organizations_url":"https://api.github.com/users/philipnrmn/orgs","repos_url":"https://api.github.com/users/philipnrmn/repos","events_url":"https://api.github.com/users/philipnrmn/events{/privacy}","received_events_url":"https://api.github.com/users/philipnrmn/received_events","type":"User","site_admin":false},"created_at":"2015-10-19T11:51:51Z","updated_at":"2015-10-19T11:51:51Z","body":"Hi guys, thanks for all the helpful insights. I've taken a significantly different tack now so rather than squash these two commits and lose your comments, I'll open a new PR. "}}