{"action":"created","issue":{"url":"https://api.github.com/repos/Shopify/statsd-instrument/issues/66","labels_url":"https://api.github.com/repos/Shopify/statsd-instrument/issues/66/labels{/name}","comments_url":"https://api.github.com/repos/Shopify/statsd-instrument/issues/66/comments","events_url":"https://api.github.com/repos/Shopify/statsd-instrument/issues/66/events","html_url":"https://github.com/Shopify/statsd-instrument/pull/66","id":112147936,"number":66,"title":"Don't create new method with public visibility scope","user":{"login":"tjoyal","id":207902,"avatar_url":"https://avatars.githubusercontent.com/u/207902?v=3","gravatar_id":"","url":"https://api.github.com/users/tjoyal","html_url":"https://github.com/tjoyal","followers_url":"https://api.github.com/users/tjoyal/followers","following_url":"https://api.github.com/users/tjoyal/following{/other_user}","gists_url":"https://api.github.com/users/tjoyal/gists{/gist_id}","starred_url":"https://api.github.com/users/tjoyal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjoyal/subscriptions","organizations_url":"https://api.github.com/users/tjoyal/orgs","repos_url":"https://api.github.com/users/tjoyal/repos","events_url":"https://api.github.com/users/tjoyal/events{/privacy}","received_events_url":"https://api.github.com/users/tjoyal/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-10-19T13:47:14Z","updated_at":"2015-10-21T12:37:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Shopify/statsd-instrument/pulls/66","html_url":"https://github.com/Shopify/statsd-instrument/pull/66","diff_url":"https://github.com/Shopify/statsd-instrument/pull/66.diff","patch_url":"https://github.com/Shopify/statsd-instrument/pull/66.patch"},"body":"Proposed extra visibility tune-up on top of #65 \r\n\r\nI do not think there is any reasons for dynamically created methods `method_name_without_statsd` and `method_name_with_statsd` to be generated in the public scope.\r\n\r\nAt first I tried to bing the scope to the caller scope, but turns out some projects are already using this gem in their initialization this way, leading to a public scope which I think is not right.\r\n```ruby\r\nObject.extend StatsD::Instrument\r\nObject.statsd_measure :call, 'Object.call'\r\n```\r\n\r\nAlso, found and fix an issue where removing a StatsD would not always restore the appropriate scope. (Should I make a PR just for that?)\r\n\r\nPlease review @gmalette @wvanbergen "},"comment":{"url":"https://api.github.com/repos/Shopify/statsd-instrument/issues/comments/149880250","html_url":"https://github.com/Shopify/statsd-instrument/pull/66#issuecomment-149880250","issue_url":"https://api.github.com/repos/Shopify/statsd-instrument/issues/66","id":149880250,"user":{"login":"tjoyal","id":207902,"avatar_url":"https://avatars.githubusercontent.com/u/207902?v=3","gravatar_id":"","url":"https://api.github.com/users/tjoyal","html_url":"https://github.com/tjoyal","followers_url":"https://api.github.com/users/tjoyal/followers","following_url":"https://api.github.com/users/tjoyal/following{/other_user}","gists_url":"https://api.github.com/users/tjoyal/gists{/gist_id}","starred_url":"https://api.github.com/users/tjoyal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjoyal/subscriptions","organizations_url":"https://api.github.com/users/tjoyal/orgs","repos_url":"https://api.github.com/users/tjoyal/repos","events_url":"https://api.github.com/users/tjoyal/events{/privacy}","received_events_url":"https://api.github.com/users/tjoyal/received_events","type":"User","site_admin":false},"created_at":"2015-10-21T12:37:29Z","updated_at":"2015-10-21T12:37:29Z","body":"ping :)"}}