{"action":"created","comment":{"url":"https://api.github.com/repos/realm/jazzy/pulls/comments/27811301","id":27811301,"diff_hunk":"@@ -1,925 +1,416 @@\n+////////////////////////////////\n+// Constants\n+////////////////////////////////\n+\n+$bg_color: #414141;\n $doc_coverage_color: #999;\n+$code_color: #777;\n+$code_bg_color: #eee;\n+$link_color: #0088cc;\n+$white_color: #fff;\n+$light_gray_bg_color: #f2f2f2;\n+$declaration_bg_color: #f9f9f9;\n+$sidebar_bg_color: #f9f9f9;\n+$declaration_lang_title_swift_color: #4b8afb;\n+\n+$sidebar_width: 230px;\n $content_wrapper_width: 980px;\n-$code-font: 12px Menlo, monospace;\n-$graybox-border: 1px solid rgba(233, 233, 233, 1);\n+$content_top_offset: 70px;\n+$content_body_margin: 16px;\n+$content_body_left_offset: $sidebar_width + $content_body_margin;\n+$header_height: 26px;\n+$breadcrumb_padding_top: 17px;\n+\n+$code_font: 0.95em Menlo, monospace;\n+\n+$gray_border: 1px solid #e2e2e2;\n+$declaration_swift_border: 5px solid #cde9f4;\n+\n+////////////////////////////////\n+// Reset\n+////////////////////////////////\n \n html, body, div, span, h1, h3, h4, p, a, code, em, img, ul, li, table, tbody, tr, td {\n   background: transparent;\n   border: 0;\n-  font-size: 100%;\n   margin: 0;\n   outline: 0;\n   padding: 0;\n   vertical-align: baseline;\n }\n \n-#reference {\n-  .declaration .Swift pre {\n-    // Ensure that declarations wrap, as they're a single line\n-    white-space: pre-wrap;\n-    font-size: 140%;\n-  }\n+////////////////////////////////\n+// Global\n+////////////////////////////////\n \n-  .x-instance-method.Swift {\n-    margin-left: 15px;\n-  }\n-  .chapter {\n-    overflow-x: hidden;\n-    border-top: 0;\n-    border-left: 1px solid rgba(233, 233, 233, 1);\n-    border-right: 1px solid rgba(233, 233, 233, 1);\n-    border-bottom: 1px solid rgba(233, 233, 233, 1);\n-  }\n-  .nav-chapters {\n-    height: 100%;\n-  }\n-  .part-name {\n-    color: #000;\n-    cursor: default;\n-    padding: 15px 15px 15px 20px;\n-    min-height: 61px;\n-    &.tasks {\n-      background: #fff;\n-      overflow: auto;\n-    }\n-  }\n-  .book-parts a {\n-    display: initial;\n-    margin-left: 0;\n-  }\n-  .nav-chapters li {\n-    color: rgba(128, 128, 128, 1);\n-    margin-left: 12px;\n-    padding-left: 10px;\n-    text-indent: -10px;\n-  }\n-  .chapter-name {\n-    margin-top: 21px;\n-  }\n+body {\n+  background-color: $light_gray_bg_color;\n+  font-family: Helvetica, freesans, Arial, sans-serif;","path":"lib/jazzy/assets/css/jazzy.css.scss","position":93,"original_position":93,"commit_id":"75debe3eb4ce31109d56ac8cf7ff70f60dc1deb3","original_commit_id":"75debe3eb4ce31109d56ac8cf7ff70f60dc1deb3","user":{"login":"segiddins","id":1946610,"avatar_url":"https://avatars.githubusercontent.com/u/1946610?v=3","gravatar_id":"","url":"https://api.github.com/users/segiddins","html_url":"https://github.com/segiddins","followers_url":"https://api.github.com/users/segiddins/followers","following_url":"https://api.github.com/users/segiddins/following{/other_user}","gists_url":"https://api.github.com/users/segiddins/gists{/gist_id}","starred_url":"https://api.github.com/users/segiddins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segiddins/subscriptions","organizations_url":"https://api.github.com/users/segiddins/orgs","repos_url":"https://api.github.com/users/segiddins/repos","events_url":"https://api.github.com/users/segiddins/events{/privacy}","received_events_url":"https://api.github.com/users/segiddins/received_events","type":"User","site_admin":false},"body":"should we use Helvetica Neue?","created_at":"2015-04-06T17:11:41Z","updated_at":"2015-04-06T17:11:41Z","html_url":"https://github.com/realm/jazzy/pull/203#discussion_r27811301","pull_request_url":"https://api.github.com/repos/realm/jazzy/pulls/203","_links":{"self":{"href":"https://api.github.com/repos/realm/jazzy/pulls/comments/27811301"},"html":{"href":"https://github.com/realm/jazzy/pull/203#discussion_r27811301"},"pull_request":{"href":"https://api.github.com/repos/realm/jazzy/pulls/203"}}},"pull_request":{"url":"https://api.github.com/repos/realm/jazzy/pulls/203","id":32641032,"html_url":"https://github.com/realm/jazzy/pull/203","diff_url":"https://github.com/realm/jazzy/pull/203.diff","patch_url":"https://github.com/realm/jazzy/pull/203.patch","issue_url":"https://api.github.com/repos/realm/jazzy/issues/203","number":203,"state":"open","locked":false,"title":"[HTML+CSS] Cleaned up front end HTML & CSS. Fixes #95.","user":{"login":"jpsim","id":474794,"avatar_url":"https://avatars.githubusercontent.com/u/474794?v=3","gravatar_id":"","url":"https://api.github.com/users/jpsim","html_url":"https://github.com/jpsim","followers_url":"https://api.github.com/users/jpsim/followers","following_url":"https://api.github.com/users/jpsim/following{/other_user}","gists_url":"https://api.github.com/users/jpsim/gists{/gist_id}","starred_url":"https://api.github.com/users/jpsim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpsim/subscriptions","organizations_url":"https://api.github.com/users/jpsim/orgs","repos_url":"https://api.github.com/users/jpsim/repos","events_url":"https://api.github.com/users/jpsim/events{/privacy}","received_events_url":"https://api.github.com/users/jpsim/received_events","type":"User","site_admin":false},"body":"Also addresses #175. This is necessarily a large PR since it touches on the overall front end design and should have been done at the project's inception. But it cuts the number of lines of CSS from 927 to 418 by deduplicating CSS logic and rules that used to override due to the CSS being hacked together from Apple's source and us adding in styling in an ad-hoc fashion.\r\n\r\nIf you'd like to review these changes, I'd appreciate if you could browse Alamofire's HTML docs from [this branch](https://static.realm.io/jazzy_demo/alamofire-jp-frontend-cleanup) and compare to what's currently generated by the [master branch](https://static.realm.io/jazzy_demo/alamofire-master).\r\n\r\nSome of these changes may feel like a step backwards design-wise, but it should be much simpler to change things now.\r\n\r\nFeedback is very appreciated at this point, so please speak up about what you dislike @segiddins @yoshyosh @beltex @jessesquires.","created_at":"2015-04-04T23:00:15Z","updated_at":"2015-04-06T17:11:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"74a807d5d4f1ded7e18bd6c1fda2e164f008a3f0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/realm/jazzy/pulls/203/commits","review_comments_url":"https://api.github.com/repos/realm/jazzy/pulls/203/comments","review_comment_url":"https://api.github.com/repos/realm/jazzy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/realm/jazzy/issues/203/comments","statuses_url":"https://api.github.com/repos/realm/jazzy/statuses/75debe3eb4ce31109d56ac8cf7ff70f60dc1deb3","head":{"label":"realm:jp-frontend-cleanup","ref":"jp-frontend-cleanup","sha":"75debe3eb4ce31109d56ac8cf7ff70f60dc1deb3","user":{"login":"realm","id":7575099,"avatar_url":"https://avatars.githubusercontent.com/u/7575099?v=3","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"repo":{"id":20552964,"name":"jazzy","full_name":"realm/jazzy","owner":{"login":"realm","id":7575099,"avatar_url":"https://avatars.githubusercontent.com/u/7575099?v=3","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/realm/jazzy","description":"Soulful docs for Swift & Objective-C","fork":false,"url":"https://api.github.com/repos/realm/jazzy","forks_url":"https://api.github.com/repos/realm/jazzy/forks","keys_url":"https://api.github.com/repos/realm/jazzy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/realm/jazzy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/realm/jazzy/teams","hooks_url":"https://api.github.com/repos/realm/jazzy/hooks","issue_events_url":"https://api.github.com/repos/realm/jazzy/issues/events{/number}","events_url":"https://api.github.com/repos/realm/jazzy/events","assignees_url":"https://api.github.com/repos/realm/jazzy/assignees{/user}","branches_url":"https://api.github.com/repos/realm/jazzy/branches{/branch}","tags_url":"https://api.github.com/repos/realm/jazzy/tags","blobs_url":"https://api.github.com/repos/realm/jazzy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/realm/jazzy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/realm/jazzy/git/refs{/sha}","trees_url":"https://api.github.com/repos/realm/jazzy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/realm/jazzy/statuses/{sha}","languages_url":"https://api.github.com/repos/realm/jazzy/languages","stargazers_url":"https://api.github.com/repos/realm/jazzy/stargazers","contributors_url":"https://api.github.com/repos/realm/jazzy/contributors","subscribers_url":"https://api.github.com/repos/realm/jazzy/subscribers","subscription_url":"https://api.github.com/repos/realm/jazzy/subscription","commits_url":"https://api.github.com/repos/realm/jazzy/commits{/sha}","git_commits_url":"https://api.github.com/repos/realm/jazzy/git/commits{/sha}","comments_url":"https://api.github.com/repos/realm/jazzy/comments{/number}","issue_comment_url":"https://api.github.com/repos/realm/jazzy/issues/comments{/number}","contents_url":"https://api.github.com/repos/realm/jazzy/contents/{+path}","compare_url":"https://api.github.com/repos/realm/jazzy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/realm/jazzy/merges","archive_url":"https://api.github.com/repos/realm/jazzy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/realm/jazzy/downloads","issues_url":"https://api.github.com/repos/realm/jazzy/issues{/number}","pulls_url":"https://api.github.com/repos/realm/jazzy/pulls{/number}","milestones_url":"https://api.github.com/repos/realm/jazzy/milestones{/number}","notifications_url":"https://api.github.com/repos/realm/jazzy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/realm/jazzy/labels{/name}","releases_url":"https://api.github.com/repos/realm/jazzy/releases{/id}","created_at":"2014-06-06T05:52:11Z","updated_at":"2015-04-06T16:01:44Z","pushed_at":"2015-04-06T17:10:22Z","git_url":"git://github.com/realm/jazzy.git","ssh_url":"git@github.com:realm/jazzy.git","clone_url":"https://github.com/realm/jazzy.git","svn_url":"https://github.com/realm/jazzy","homepage":"","size":20842,"stargazers_count":1546,"watchers_count":1546,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"open_issues_count":49,"forks":60,"open_issues":49,"watchers":1546,"default_branch":"master"}},"base":{"label":"realm:master","ref":"master","sha":"2d7b5f35d513a21eaa4aab50743486484c2bf969","user":{"login":"realm","id":7575099,"avatar_url":"https://avatars.githubusercontent.com/u/7575099?v=3","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"repo":{"id":20552964,"name":"jazzy","full_name":"realm/jazzy","owner":{"login":"realm","id":7575099,"avatar_url":"https://avatars.githubusercontent.com/u/7575099?v=3","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/realm/jazzy","description":"Soulful docs for Swift & Objective-C","fork":false,"url":"https://api.github.com/repos/realm/jazzy","forks_url":"https://api.github.com/repos/realm/jazzy/forks","keys_url":"https://api.github.com/repos/realm/jazzy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/realm/jazzy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/realm/jazzy/teams","hooks_url":"https://api.github.com/repos/realm/jazzy/hooks","issue_events_url":"https://api.github.com/repos/realm/jazzy/issues/events{/number}","events_url":"https://api.github.com/repos/realm/jazzy/events","assignees_url":"https://api.github.com/repos/realm/jazzy/assignees{/user}","branches_url":"https://api.github.com/repos/realm/jazzy/branches{/branch}","tags_url":"https://api.github.com/repos/realm/jazzy/tags","blobs_url":"https://api.github.com/repos/realm/jazzy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/realm/jazzy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/realm/jazzy/git/refs{/sha}","trees_url":"https://api.github.com/repos/realm/jazzy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/realm/jazzy/statuses/{sha}","languages_url":"https://api.github.com/repos/realm/jazzy/languages","stargazers_url":"https://api.github.com/repos/realm/jazzy/stargazers","contributors_url":"https://api.github.com/repos/realm/jazzy/contributors","subscribers_url":"https://api.github.com/repos/realm/jazzy/subscribers","subscription_url":"https://api.github.com/repos/realm/jazzy/subscription","commits_url":"https://api.github.com/repos/realm/jazzy/commits{/sha}","git_commits_url":"https://api.github.com/repos/realm/jazzy/git/commits{/sha}","comments_url":"https://api.github.com/repos/realm/jazzy/comments{/number}","issue_comment_url":"https://api.github.com/repos/realm/jazzy/issues/comments{/number}","contents_url":"https://api.github.com/repos/realm/jazzy/contents/{+path}","compare_url":"https://api.github.com/repos/realm/jazzy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/realm/jazzy/merges","archive_url":"https://api.github.com/repos/realm/jazzy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/realm/jazzy/downloads","issues_url":"https://api.github.com/repos/realm/jazzy/issues{/number}","pulls_url":"https://api.github.com/repos/realm/jazzy/pulls{/number}","milestones_url":"https://api.github.com/repos/realm/jazzy/milestones{/number}","notifications_url":"https://api.github.com/repos/realm/jazzy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/realm/jazzy/labels{/name}","releases_url":"https://api.github.com/repos/realm/jazzy/releases{/id}","created_at":"2014-06-06T05:52:11Z","updated_at":"2015-04-06T16:01:44Z","pushed_at":"2015-04-06T17:10:22Z","git_url":"git://github.com/realm/jazzy.git","ssh_url":"git@github.com:realm/jazzy.git","clone_url":"https://github.com/realm/jazzy.git","svn_url":"https://github.com/realm/jazzy","homepage":"","size":20842,"stargazers_count":1546,"watchers_count":1546,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"open_issues_count":49,"forks":60,"open_issues":49,"watchers":1546,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/realm/jazzy/pulls/203"},"html":{"href":"https://github.com/realm/jazzy/pull/203"},"issue":{"href":"https://api.github.com/repos/realm/jazzy/issues/203"},"comments":{"href":"https://api.github.com/repos/realm/jazzy/issues/203/comments"},"review_comments":{"href":"https://api.github.com/repos/realm/jazzy/pulls/203/comments"},"review_comment":{"href":"https://api.github.com/repos/realm/jazzy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/realm/jazzy/pulls/203/commits"},"statuses":{"href":"https://api.github.com/repos/realm/jazzy/statuses/75debe3eb4ce31109d56ac8cf7ff70f60dc1deb3"}}}}