{"action":"created","comment":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/39938058","id":39938058,"diff_hunk":"@@ -497,19 +497,10 @@ bool HasAdequateAirUnitReloadBuildings(ActorInfo actorInfo)\n \n \t\t\t\tcase BuildingType.Refinery:\n \n-\t\t\t\t\t// Try and place the refinery near a resource field\n-\t\t\t\t\tvar nearbyResources = Map.FindTilesInCircle(baseCenter, Info.MaxBaseRadius)\n-\t\t\t\t\t\t.Where(a => resourceTypeIndices.Get(Map.GetTerrainIndex(a)))\n-\t\t\t\t\t\t.Shuffle(Random);\n+\t\t\t\t\t// Old code to place closer to resources was removed for performance reasons.\n+\t\t\t\t\t// TODO: Reimplement it in a way to doesn't cause performance issues.","path":"OpenRA.Mods.Common/AI/HackyAI.cs","position":9,"original_position":9,"commit_id":"91e36f2c7acb515d8b2f0f21d9a27c67c3e87b10","original_commit_id":"91e36f2c7acb515d8b2f0f21d9a27c67c3e87b10","user":{"login":"ScottNZ","id":1712619,"avatar_url":"https://avatars.githubusercontent.com/u/1712619?v=3","gravatar_id":"","url":"https://api.github.com/users/ScottNZ","html_url":"https://github.com/ScottNZ","followers_url":"https://api.github.com/users/ScottNZ/followers","following_url":"https://api.github.com/users/ScottNZ/following{/other_user}","gists_url":"https://api.github.com/users/ScottNZ/gists{/gist_id}","starred_url":"https://api.github.com/users/ScottNZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScottNZ/subscriptions","organizations_url":"https://api.github.com/users/ScottNZ/orgs","repos_url":"https://api.github.com/users/ScottNZ/repos","events_url":"https://api.github.com/users/ScottNZ/events{/privacy}","received_events_url":"https://api.github.com/users/ScottNZ/received_events","type":"User","site_admin":false},"body":"to -> that?","created_at":"2015-09-21T01:36:38Z","updated_at":"2015-09-21T01:36:38Z","html_url":"https://github.com/OpenRA/OpenRA/pull/9400#discussion_r39938058","pull_request_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9400","_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/39938058"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/9400#discussion_r39938058"},"pull_request":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9400"}}},"pull_request":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9400","id":45509060,"html_url":"https://github.com/OpenRA/OpenRA/pull/9400","diff_url":"https://github.com/OpenRA/OpenRA/pull/9400.diff","patch_url":"https://github.com/OpenRA/OpenRA/pull/9400.patch","issue_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/9400","number":9400,"state":"open","locked":false,"title":"Fixed massive AI base builder performance issue","user":{"login":"reaperrr","id":2857877,"avatar_url":"https://avatars.githubusercontent.com/u/2857877?v=3","gravatar_id":"","url":"https://api.github.com/users/reaperrr","html_url":"https://github.com/reaperrr","followers_url":"https://api.github.com/users/reaperrr/followers","following_url":"https://api.github.com/users/reaperrr/following{/other_user}","gists_url":"https://api.github.com/users/reaperrr/gists{/gist_id}","starred_url":"https://api.github.com/users/reaperrr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reaperrr/subscriptions","organizations_url":"https://api.github.com/users/reaperrr/orgs","repos_url":"https://api.github.com/users/reaperrr/repos","events_url":"https://api.github.com/users/reaperrr/events{/privacy}","received_events_url":"https://api.github.com/users/reaperrr/received_events","type":"User","site_admin":false},"body":"HackyAI causes occasional BaseBuilder-related lag spikes of anywhere between 200 and 1200(!) milliseconds.\r\n\r\nAfter throwing around with PerfTimers, I narrowed it down to the refinery placement.\r\nThis PR removes the check for nearby resources and simply places refinery normally. That check is just way, way too expensive, and I didn't notice much of a difference in AI refinery placement.\r\n\r\nCloses #4717.","created_at":"2015-09-21T01:31:08Z","updated_at":"2015-09-21T01:36:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9481d4d0ab60a6aea558469f4826ac0ebc815ec1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9400/commits","review_comments_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9400/comments","review_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/9400/comments","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/91e36f2c7acb515d8b2f0f21d9a27c67c3e87b10","head":{"label":"reaperrr:fix-airefplaceperf","ref":"fix-airefplaceperf","sha":"91e36f2c7acb515d8b2f0f21d9a27c67c3e87b10","user":{"login":"reaperrr","id":2857877,"avatar_url":"https://avatars.githubusercontent.com/u/2857877?v=3","gravatar_id":"","url":"https://api.github.com/users/reaperrr","html_url":"https://github.com/reaperrr","followers_url":"https://api.github.com/users/reaperrr/followers","following_url":"https://api.github.com/users/reaperrr/following{/other_user}","gists_url":"https://api.github.com/users/reaperrr/gists{/gist_id}","starred_url":"https://api.github.com/users/reaperrr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reaperrr/subscriptions","organizations_url":"https://api.github.com/users/reaperrr/orgs","repos_url":"https://api.github.com/users/reaperrr/repos","events_url":"https://api.github.com/users/reaperrr/events{/privacy}","received_events_url":"https://api.github.com/users/reaperrr/received_events","type":"User","site_admin":false},"repo":{"id":6804707,"name":"OpenRA","full_name":"reaperrr/OpenRA","owner":{"login":"reaperrr","id":2857877,"avatar_url":"https://avatars.githubusercontent.com/u/2857877?v=3","gravatar_id":"","url":"https://api.github.com/users/reaperrr","html_url":"https://github.com/reaperrr","followers_url":"https://api.github.com/users/reaperrr/followers","following_url":"https://api.github.com/users/reaperrr/following{/other_user}","gists_url":"https://api.github.com/users/reaperrr/gists{/gist_id}","starred_url":"https://api.github.com/users/reaperrr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reaperrr/subscriptions","organizations_url":"https://api.github.com/users/reaperrr/orgs","repos_url":"https://api.github.com/users/reaperrr/repos","events_url":"https://api.github.com/users/reaperrr/events{/privacy}","received_events_url":"https://api.github.com/users/reaperrr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/reaperrr/OpenRA","description":"An open-source implementation of the Red Alert engine using .NET/mono and OpenGL. Runs on Windows, Linux and OSX. Bugs at http://bugs.open-ra.org/","fork":true,"url":"https://api.github.com/repos/reaperrr/OpenRA","forks_url":"https://api.github.com/repos/reaperrr/OpenRA/forks","keys_url":"https://api.github.com/repos/reaperrr/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reaperrr/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reaperrr/OpenRA/teams","hooks_url":"https://api.github.com/repos/reaperrr/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/reaperrr/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/reaperrr/OpenRA/events","assignees_url":"https://api.github.com/repos/reaperrr/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/reaperrr/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/reaperrr/OpenRA/tags","blobs_url":"https://api.github.com/repos/reaperrr/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reaperrr/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reaperrr/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/reaperrr/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reaperrr/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/reaperrr/OpenRA/languages","stargazers_url":"https://api.github.com/repos/reaperrr/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/reaperrr/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/reaperrr/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/reaperrr/OpenRA/subscription","commits_url":"https://api.github.com/repos/reaperrr/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/reaperrr/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/reaperrr/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/reaperrr/OpenRA/issues/comments{/number}","contents_url":"https://api.github.com/repos/reaperrr/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/reaperrr/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reaperrr/OpenRA/merges","archive_url":"https://api.github.com/repos/reaperrr/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reaperrr/OpenRA/downloads","issues_url":"https://api.github.com/repos/reaperrr/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/reaperrr/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/reaperrr/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/reaperrr/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reaperrr/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/reaperrr/OpenRA/releases{/id}","created_at":"2012-11-21T23:13:26Z","updated_at":"2015-09-20T21:10:57Z","pushed_at":"2015-09-21T01:21:41Z","git_url":"git://github.com/reaperrr/OpenRA.git","ssh_url":"git@github.com:reaperrr/OpenRA.git","clone_url":"https://github.com/reaperrr/OpenRA.git","svn_url":"https://github.com/reaperrr/OpenRA","homepage":"http://open-ra.org","size":102512,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"bleed"}},"base":{"label":"OpenRA:bleed","ref":"bleed","sha":"bbdd5979178c8c46766d216a82b307883bf67147","user":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars.githubusercontent.com/u/409046?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"repo":{"id":959908,"name":"OpenRA","full_name":"OpenRA/OpenRA","owner":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars.githubusercontent.com/u/409046?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenRA/OpenRA","description":"Open Source real-time strategy game engine for early Westwood games such as Command & Conquer: Red Alert written in C# using SDL and OpenGL. Runs on Windows, Linux, *BSD and Mac OS X.","fork":false,"url":"https://api.github.com/repos/OpenRA/OpenRA","forks_url":"https://api.github.com/repos/OpenRA/OpenRA/forks","keys_url":"https://api.github.com/repos/OpenRA/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenRA/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenRA/OpenRA/teams","hooks_url":"https://api.github.com/repos/OpenRA/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/OpenRA/OpenRA/events","assignees_url":"https://api.github.com/repos/OpenRA/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/OpenRA/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/OpenRA/OpenRA/tags","blobs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenRA/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenRA/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenRA/OpenRA/languages","stargazers_url":"https://api.github.com/repos/OpenRA/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/OpenRA/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/OpenRA/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/OpenRA/OpenRA/subscription","commits_url":"https://api.github.com/repos/OpenRA/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenRA/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenRA/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/OpenRA/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenRA/OpenRA/merges","archive_url":"https://api.github.com/repos/OpenRA/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenRA/OpenRA/downloads","issues_url":"https://api.github.com/repos/OpenRA/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenRA/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenRA/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenRA/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/OpenRA/OpenRA/releases{/id}","created_at":"2010-10-04T07:38:05Z","updated_at":"2015-09-20T23:49:01Z","pushed_at":"2015-09-21T01:31:09Z","git_url":"git://github.com/OpenRA/OpenRA.git","ssh_url":"git@github.com:OpenRA/OpenRA.git","clone_url":"https://github.com/OpenRA/OpenRA.git","svn_url":"https://github.com/OpenRA/OpenRA","homepage":"http://www.openra.net","size":191688,"stargazers_count":2170,"watchers_count":2170,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":773,"mirror_url":null,"open_issues_count":910,"forks":773,"open_issues":910,"watchers":2170,"default_branch":"bleed"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9400"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/9400"},"issue":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/9400"},"comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/9400/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9400/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9400/commits"},"statuses":{"href":"https://api.github.com/repos/OpenRA/OpenRA/statuses/91e36f2c7acb515d8b2f0f21d9a27c67c3e87b10"}}}}