{"action":"created","issue":{"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/363","labels_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/363/labels{/name}","comments_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/363/comments","events_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/363/events","html_url":"https://github.com/WikiWatershed/model-my-watershed/pull/363","id":87499242,"number":363,"title":"Update the URL with active scenario","user":{"login":"mmcfarland","id":1014341,"avatar_url":"https://avatars.githubusercontent.com/u/1014341?v=3","gravatar_id":"","url":"https://api.github.com/users/mmcfarland","html_url":"https://github.com/mmcfarland","followers_url":"https://api.github.com/users/mmcfarland/followers","following_url":"https://api.github.com/users/mmcfarland/following{/other_user}","gists_url":"https://api.github.com/users/mmcfarland/gists{/gist_id}","starred_url":"https://api.github.com/users/mmcfarland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmcfarland/subscriptions","organizations_url":"https://api.github.com/users/mmcfarland/orgs","repos_url":"https://api.github.com/users/mmcfarland/repos","events_url":"https://api.github.com/users/mmcfarland/events{/privacy}","received_events_url":"https://api.github.com/users/mmcfarland/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/labels/in%20review","name":"in review","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"rajadain","id":1430060,"avatar_url":"https://avatars.githubusercontent.com/u/1430060?v=3","gravatar_id":"","url":"https://api.github.com/users/rajadain","html_url":"https://github.com/rajadain","followers_url":"https://api.github.com/users/rajadain/followers","following_url":"https://api.github.com/users/rajadain/following{/other_user}","gists_url":"https://api.github.com/users/rajadain/gists{/gist_id}","starred_url":"https://api.github.com/users/rajadain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajadain/subscriptions","organizations_url":"https://api.github.com/users/rajadain/orgs","repos_url":"https://api.github.com/users/rajadain/repos","events_url":"https://api.github.com/users/rajadain/events{/privacy}","received_events_url":"https://api.github.com/users/rajadain/received_events","type":"User","site_admin":false},"milestone":null,"comments":7,"created_at":"2015-06-11T21:09:29Z","updated_at":"2015-06-12T13:50:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/363","html_url":"https://github.com/WikiWatershed/model-my-watershed/pull/363","diff_url":"https://github.com/WikiWatershed/model-my-watershed/pull/363.diff","patch_url":"https://github.com/WikiWatershed/model-my-watershed/pull/363.patch"},"body":"Allow the URL to be set with the active scenario and restore that\r\nscenario to active status allows easier sharing of public links.\r\n\r\nTesting:\r\n* Non-saved projects should not generate unique url structures\r\n* Saved projects should update the URL with the scenario ID when it's activated\r\n* Full scenario URLs should select the correct tab on reload\r\n* Bad scenario Ids redirect to the first scenario\r\n* Adding a new scenario will update the URL with the correct ID when the ID is received from the save operation.\r\n\r\nConnects #280 "},"comment":{"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/comments/111498713","html_url":"https://github.com/WikiWatershed/model-my-watershed/pull/363#issuecomment-111498713","issue_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/363","id":111498713,"user":{"login":"mmcfarland","id":1014341,"avatar_url":"https://avatars.githubusercontent.com/u/1014341?v=3","gravatar_id":"","url":"https://api.github.com/users/mmcfarland","html_url":"https://github.com/mmcfarland","followers_url":"https://api.github.com/users/mmcfarland/followers","following_url":"https://api.github.com/users/mmcfarland/following{/other_user}","gists_url":"https://api.github.com/users/mmcfarland/gists{/gist_id}","starred_url":"https://api.github.com/users/mmcfarland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmcfarland/subscriptions","organizations_url":"https://api.github.com/users/mmcfarland/orgs","repos_url":"https://api.github.com/users/mmcfarland/repos","events_url":"https://api.github.com/users/mmcfarland/events{/privacy}","received_events_url":"https://api.github.com/users/mmcfarland/received_events","type":"User","site_admin":false},"created_at":"2015-06-12T13:50:42Z","updated_at":"2015-06-12T13:50:42Z","body":"Yeah, I considered what to do with invalid scenario fragments, and from a strict point of view it made sense that if the resource you asked for didn't exist, you should get a 404 - but probably we should be more generous than that.  The main use case I'm thinking of is that of a shared scenario that gets deleted, should that link be broken or should it just go to the default project?  The only reason to consider not going there is if there's some context like, \"look at how badly this new plan affects the water quality\", but the default scenario is another plan that affects the quality positively - seems like it could lead to confusion.  I suppose with named scenarios, the best thing to do is just go to the project if the scenario is bad and hope for the best."}}