{"action":"created","comment":{"url":"https://api.github.com/repos/OpenMS/OpenMS/pulls/comments/46708343","id":46708343,"diff_hunk":"@@ -751,30 +731,8 @@ namespace OpenMS\n         os << \"mass_type=\\\"average\\\" \";\n       }\n       os << \"charges=\\\"\" << search_param.charges << \"\\\" \";\n-      if (search_param.enzyme == ProteinIdentification::TRYPSIN)\n-      {\n-        os << \"enzyme=\\\"trypsin\\\" \";\n-      }\n-      if (search_param.enzyme == ProteinIdentification::PEPSIN_A)\n-      {\n-        os << \"enzyme=\\\"pepsin_a\\\" \";\n-      }\n-      if (search_param.enzyme == ProteinIdentification::PROTEASE_K)\n-      {\n-        os << \"enzyme=\\\"protease_k\\\" \";\n-      }\n-      if (search_param.enzyme == ProteinIdentification::CHYMOTRYPSIN)\n-      {\n-        os << \"enzyme=\\\"chymotrypsin\\\" \";\n-      }\n-      else if (search_param.enzyme == ProteinIdentification::NO_ENZYME)\n-      {\n-        os << \"enzyme=\\\"no_enzyme\\\" \";\n-      }\n-      else if (search_param.enzyme == ProteinIdentification::UNKNOWN_ENZYME)\n-      {\n-        os << \"enzyme=\\\"unknown_enzyme\\\" \";\n-      }\n+      String enzyme_name = search_param.digestion_enzyme.getName();\n+      os << \"enzyme=\\\"\" << enzyme_name.toLower() << \"\\\" \";","path":"src/openms/source/FORMAT/ConsensusXMLFile.cpp","position":79,"original_position":79,"commit_id":"86136ce1ffc016464e613d0ebcd9b4e4297a49b2","original_commit_id":"86136ce1ffc016464e613d0ebcd9b4e4297a49b2","user":{"login":"timosachsenberg","id":5803621,"avatar_url":"https://avatars.githubusercontent.com/u/5803621?v=3","gravatar_id":"","url":"https://api.github.com/users/timosachsenberg","html_url":"https://github.com/timosachsenberg","followers_url":"https://api.github.com/users/timosachsenberg/followers","following_url":"https://api.github.com/users/timosachsenberg/following{/other_user}","gists_url":"https://api.github.com/users/timosachsenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/timosachsenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timosachsenberg/subscriptions","organizations_url":"https://api.github.com/users/timosachsenberg/orgs","repos_url":"https://api.github.com/users/timosachsenberg/repos","events_url":"https://api.github.com/users/timosachsenberg/events{/privacy}","received_events_url":"https://api.github.com/users/timosachsenberg/received_events","type":"User","site_admin":false},"body":"is this correct? do we have all names as lower case in enzymes db? if so this might be a source of errors if e.g. a user adds a new enzyme with Upper case letters.\r\n","created_at":"2015-12-04T17:35:04Z","updated_at":"2015-12-04T17:35:04Z","html_url":"https://github.com/OpenMS/OpenMS/pull/1743#discussion_r46708343","pull_request_url":"https://api.github.com/repos/OpenMS/OpenMS/pulls/1743","_links":{"self":{"href":"https://api.github.com/repos/OpenMS/OpenMS/pulls/comments/46708343"},"html":{"href":"https://github.com/OpenMS/OpenMS/pull/1743#discussion_r46708343"},"pull_request":{"href":"https://api.github.com/repos/OpenMS/OpenMS/pulls/1743"}}},"pull_request":{"url":"https://api.github.com/repos/OpenMS/OpenMS/pulls/1743","id":52693951,"html_url":"https://github.com/OpenMS/OpenMS/pull/1743","diff_url":"https://github.com/OpenMS/OpenMS/pull/1743.diff","patch_url":"https://github.com/OpenMS/OpenMS/pull/1743.patch","issue_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/1743","number":1743,"state":"open","locked":false,"title":"Remove enzyme enum in ProteinIdentification#1411","user":{"login":"liangoaix","id":4321857,"avatar_url":"https://avatars.githubusercontent.com/u/4321857?v=3","gravatar_id":"","url":"https://api.github.com/users/liangoaix","html_url":"https://github.com/liangoaix","followers_url":"https://api.github.com/users/liangoaix/followers","following_url":"https://api.github.com/users/liangoaix/following{/other_user}","gists_url":"https://api.github.com/users/liangoaix/gists{/gist_id}","starred_url":"https://api.github.com/users/liangoaix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liangoaix/subscriptions","organizations_url":"https://api.github.com/users/liangoaix/orgs","repos_url":"https://api.github.com/users/liangoaix/repos","events_url":"https://api.github.com/users/liangoaix/events{/privacy}","received_events_url":"https://api.github.com/users/liangoaix/received_events","type":"User","site_admin":false},"body":"Remove enzyme enum in ProteinIdentification #1411","created_at":"2015-12-04T16:58:26Z","updated_at":"2015-12-04T17:35:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91a335128a94fe1d49e08cffd640a49d6463c60e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OpenMS/OpenMS/pulls/1743/commits","review_comments_url":"https://api.github.com/repos/OpenMS/OpenMS/pulls/1743/comments","review_comment_url":"https://api.github.com/repos/OpenMS/OpenMS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/1743/comments","statuses_url":"https://api.github.com/repos/OpenMS/OpenMS/statuses/86136ce1ffc016464e613d0ebcd9b4e4297a49b2","head":{"label":"liangoaix:remove_enzyme_enum","ref":"remove_enzyme_enum","sha":"86136ce1ffc016464e613d0ebcd9b4e4297a49b2","user":{"login":"liangoaix","id":4321857,"avatar_url":"https://avatars.githubusercontent.com/u/4321857?v=3","gravatar_id":"","url":"https://api.github.com/users/liangoaix","html_url":"https://github.com/liangoaix","followers_url":"https://api.github.com/users/liangoaix/followers","following_url":"https://api.github.com/users/liangoaix/following{/other_user}","gists_url":"https://api.github.com/users/liangoaix/gists{/gist_id}","starred_url":"https://api.github.com/users/liangoaix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liangoaix/subscriptions","organizations_url":"https://api.github.com/users/liangoaix/orgs","repos_url":"https://api.github.com/users/liangoaix/repos","events_url":"https://api.github.com/users/liangoaix/events{/privacy}","received_events_url":"https://api.github.com/users/liangoaix/received_events","type":"User","site_admin":false},"repo":{"id":17285984,"name":"OpenMS","full_name":"liangoaix/OpenMS","owner":{"login":"liangoaix","id":4321857,"avatar_url":"https://avatars.githubusercontent.com/u/4321857?v=3","gravatar_id":"","url":"https://api.github.com/users/liangoaix","html_url":"https://github.com/liangoaix","followers_url":"https://api.github.com/users/liangoaix/followers","following_url":"https://api.github.com/users/liangoaix/following{/other_user}","gists_url":"https://api.github.com/users/liangoaix/gists{/gist_id}","starred_url":"https://api.github.com/users/liangoaix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liangoaix/subscriptions","organizations_url":"https://api.github.com/users/liangoaix/orgs","repos_url":"https://api.github.com/users/liangoaix/repos","events_url":"https://api.github.com/users/liangoaix/events{/privacy}","received_events_url":"https://api.github.com/users/liangoaix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/liangoaix/OpenMS","description":"The codebase of the OpenMS project","fork":true,"url":"https://api.github.com/repos/liangoaix/OpenMS","forks_url":"https://api.github.com/repos/liangoaix/OpenMS/forks","keys_url":"https://api.github.com/repos/liangoaix/OpenMS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liangoaix/OpenMS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liangoaix/OpenMS/teams","hooks_url":"https://api.github.com/repos/liangoaix/OpenMS/hooks","issue_events_url":"https://api.github.com/repos/liangoaix/OpenMS/issues/events{/number}","events_url":"https://api.github.com/repos/liangoaix/OpenMS/events","assignees_url":"https://api.github.com/repos/liangoaix/OpenMS/assignees{/user}","branches_url":"https://api.github.com/repos/liangoaix/OpenMS/branches{/branch}","tags_url":"https://api.github.com/repos/liangoaix/OpenMS/tags","blobs_url":"https://api.github.com/repos/liangoaix/OpenMS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liangoaix/OpenMS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liangoaix/OpenMS/git/refs{/sha}","trees_url":"https://api.github.com/repos/liangoaix/OpenMS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liangoaix/OpenMS/statuses/{sha}","languages_url":"https://api.github.com/repos/liangoaix/OpenMS/languages","stargazers_url":"https://api.github.com/repos/liangoaix/OpenMS/stargazers","contributors_url":"https://api.github.com/repos/liangoaix/OpenMS/contributors","subscribers_url":"https://api.github.com/repos/liangoaix/OpenMS/subscribers","subscription_url":"https://api.github.com/repos/liangoaix/OpenMS/subscription","commits_url":"https://api.github.com/repos/liangoaix/OpenMS/commits{/sha}","git_commits_url":"https://api.github.com/repos/liangoaix/OpenMS/git/commits{/sha}","comments_url":"https://api.github.com/repos/liangoaix/OpenMS/comments{/number}","issue_comment_url":"https://api.github.com/repos/liangoaix/OpenMS/issues/comments{/number}","contents_url":"https://api.github.com/repos/liangoaix/OpenMS/contents/{+path}","compare_url":"https://api.github.com/repos/liangoaix/OpenMS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liangoaix/OpenMS/merges","archive_url":"https://api.github.com/repos/liangoaix/OpenMS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liangoaix/OpenMS/downloads","issues_url":"https://api.github.com/repos/liangoaix/OpenMS/issues{/number}","pulls_url":"https://api.github.com/repos/liangoaix/OpenMS/pulls{/number}","milestones_url":"https://api.github.com/repos/liangoaix/OpenMS/milestones{/number}","notifications_url":"https://api.github.com/repos/liangoaix/OpenMS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liangoaix/OpenMS/labels{/name}","releases_url":"https://api.github.com/repos/liangoaix/OpenMS/releases{/id}","created_at":"2014-02-28T12:50:29Z","updated_at":"2014-07-20T14:14:08Z","pushed_at":"2015-12-04T16:56:18Z","git_url":"git://github.com/liangoaix/OpenMS.git","ssh_url":"git@github.com:liangoaix/OpenMS.git","clone_url":"https://github.com/liangoaix/OpenMS.git","svn_url":"https://github.com/liangoaix/OpenMS","homepage":null,"size":211668,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"OpenMS:develop","ref":"develop","sha":"dd44ac35c6e3e0f2756c07e136dc548d1a7014e7","user":{"login":"OpenMS","id":5994841,"avatar_url":"https://avatars.githubusercontent.com/u/5994841?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenMS","html_url":"https://github.com/OpenMS","followers_url":"https://api.github.com/users/OpenMS/followers","following_url":"https://api.github.com/users/OpenMS/following{/other_user}","gists_url":"https://api.github.com/users/OpenMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenMS/subscriptions","organizations_url":"https://api.github.com/users/OpenMS/orgs","repos_url":"https://api.github.com/users/OpenMS/repos","events_url":"https://api.github.com/users/OpenMS/events{/privacy}","received_events_url":"https://api.github.com/users/OpenMS/received_events","type":"Organization","site_admin":false},"repo":{"id":15763403,"name":"OpenMS","full_name":"OpenMS/OpenMS","owner":{"login":"OpenMS","id":5994841,"avatar_url":"https://avatars.githubusercontent.com/u/5994841?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenMS","html_url":"https://github.com/OpenMS","followers_url":"https://api.github.com/users/OpenMS/followers","following_url":"https://api.github.com/users/OpenMS/following{/other_user}","gists_url":"https://api.github.com/users/OpenMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenMS/subscriptions","organizations_url":"https://api.github.com/users/OpenMS/orgs","repos_url":"https://api.github.com/users/OpenMS/repos","events_url":"https://api.github.com/users/OpenMS/events{/privacy}","received_events_url":"https://api.github.com/users/OpenMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenMS/OpenMS","description":"The codebase of the OpenMS project","fork":false,"url":"https://api.github.com/repos/OpenMS/OpenMS","forks_url":"https://api.github.com/repos/OpenMS/OpenMS/forks","keys_url":"https://api.github.com/repos/OpenMS/OpenMS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenMS/OpenMS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenMS/OpenMS/teams","hooks_url":"https://api.github.com/repos/OpenMS/OpenMS/hooks","issue_events_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/events{/number}","events_url":"https://api.github.com/repos/OpenMS/OpenMS/events","assignees_url":"https://api.github.com/repos/OpenMS/OpenMS/assignees{/user}","branches_url":"https://api.github.com/repos/OpenMS/OpenMS/branches{/branch}","tags_url":"https://api.github.com/repos/OpenMS/OpenMS/tags","blobs_url":"https://api.github.com/repos/OpenMS/OpenMS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenMS/OpenMS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenMS/OpenMS/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenMS/OpenMS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenMS/OpenMS/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenMS/OpenMS/languages","stargazers_url":"https://api.github.com/repos/OpenMS/OpenMS/stargazers","contributors_url":"https://api.github.com/repos/OpenMS/OpenMS/contributors","subscribers_url":"https://api.github.com/repos/OpenMS/OpenMS/subscribers","subscription_url":"https://api.github.com/repos/OpenMS/OpenMS/subscription","commits_url":"https://api.github.com/repos/OpenMS/OpenMS/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenMS/OpenMS/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenMS/OpenMS/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenMS/OpenMS/contents/{+path}","compare_url":"https://api.github.com/repos/OpenMS/OpenMS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenMS/OpenMS/merges","archive_url":"https://api.github.com/repos/OpenMS/OpenMS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenMS/OpenMS/downloads","issues_url":"https://api.github.com/repos/OpenMS/OpenMS/issues{/number}","pulls_url":"https://api.github.com/repos/OpenMS/OpenMS/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenMS/OpenMS/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenMS/OpenMS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenMS/OpenMS/labels{/name}","releases_url":"https://api.github.com/repos/OpenMS/OpenMS/releases{/id}","created_at":"2014-01-09T10:15:13Z","updated_at":"2015-11-02T09:06:05Z","pushed_at":"2015-12-04T16:58:26Z","git_url":"git://github.com/OpenMS/OpenMS.git","ssh_url":"git@github.com:OpenMS/OpenMS.git","clone_url":"https://github.com/OpenMS/OpenMS.git","svn_url":"https://github.com/OpenMS/OpenMS","homepage":null,"size":213865,"stargazers_count":35,"watchers_count":35,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":358,"forks":45,"open_issues":358,"watchers":35,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenMS/OpenMS/pulls/1743"},"html":{"href":"https://github.com/OpenMS/OpenMS/pull/1743"},"issue":{"href":"https://api.github.com/repos/OpenMS/OpenMS/issues/1743"},"comments":{"href":"https://api.github.com/repos/OpenMS/OpenMS/issues/1743/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenMS/OpenMS/pulls/1743/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenMS/OpenMS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenMS/OpenMS/pulls/1743/commits"},"statuses":{"href":"https://api.github.com/repos/OpenMS/OpenMS/statuses/86136ce1ffc016464e613d0ebcd9b4e4297a49b2"}}}}