{"action":"created","comment":{"url":"https://api.github.com/repos/penzance/ab-testing-tool/pulls/comments/26767663","id":26767663,"diff_hunk":"@@ -2,6 +2,7 @@\n from canvas_sdk.methods import modules\n from canvas_sdk import RequestContext\n from canvas_sdk.exceptions import CanvasAPIError\n+from canvas_sdk.utils import get_all_list_data\n from django.conf import settings\n \n from ab_tool.exceptions import (MISSING_LTI_PARAM, MISSING_LTI_LAUNCH,","path":"ab_tool/canvas.py","position":7,"original_position":7,"commit_id":"959502b49573d4c3a7cf0abc3c62bc56fb91ec72","original_commit_id":"959502b49573d4c3a7cf0abc3c62bc56fb91ec72","user":{"login":"eparker71","id":1084287,"avatar_url":"https://avatars.githubusercontent.com/u/1084287?v=3","gravatar_id":"","url":"https://api.github.com/users/eparker71","html_url":"https://github.com/eparker71","followers_url":"https://api.github.com/users/eparker71/followers","following_url":"https://api.github.com/users/eparker71/following{/other_user}","gists_url":"https://api.github.com/users/eparker71/gists{/gist_id}","starred_url":"https://api.github.com/users/eparker71/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eparker71/subscriptions","organizations_url":"https://api.github.com/users/eparker71/orgs","repos_url":"https://api.github.com/users/eparker71/repos","events_url":"https://api.github.com/users/eparker71/events{/privacy}","received_events_url":"https://api.github.com/users/eparker71/received_events","type":"User","site_admin":false},"body":"unused import removed","created_at":"2015-03-19T15:55:10Z","updated_at":"2015-03-19T15:55:10Z","html_url":"https://github.com/penzance/ab-testing-tool/pull/162#discussion_r26767663","pull_request_url":"https://api.github.com/repos/penzance/ab-testing-tool/pulls/162","_links":{"self":{"href":"https://api.github.com/repos/penzance/ab-testing-tool/pulls/comments/26767663"},"html":{"href":"https://github.com/penzance/ab-testing-tool/pull/162#discussion_r26767663"},"pull_request":{"href":"https://api.github.com/repos/penzance/ab-testing-tool/pulls/162"}}},"pull_request":{"url":"https://api.github.com/repos/penzance/ab-testing-tool/pulls/162","id":31527172,"html_url":"https://github.com/penzance/ab-testing-tool/pull/162","diff_url":"https://github.com/penzance/ab-testing-tool/pull/162.diff","patch_url":"https://github.com/penzance/ab-testing-tool/pull/162.patch","issue_url":"https://api.github.com/repos/penzance/ab-testing-tool/issues/162","number":162,"state":"open","locked":false,"title":"Bugfix/eparker/tlt 949 download file is not showing all students in the course","user":{"login":"eparker71","id":1084287,"avatar_url":"https://avatars.githubusercontent.com/u/1084287?v=3","gravatar_id":"","url":"https://api.github.com/users/eparker71","html_url":"https://github.com/eparker71","followers_url":"https://api.github.com/users/eparker71/followers","following_url":"https://api.github.com/users/eparker71/following{/other_user}","gists_url":"https://api.github.com/users/eparker71/gists{/gist_id}","starred_url":"https://api.github.com/users/eparker71/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eparker71/subscriptions","organizations_url":"https://api.github.com/users/eparker71/orgs","repos_url":"https://api.github.com/users/eparker71/repos","events_url":"https://api.github.com/users/eparker71/events{/privacy}","received_events_url":"https://api.github.com/users/eparker71/received_events","type":"User","site_admin":false},"body":"First off, I know this is a bugfix and technically should be merged to master. However, I goofed and created this branch from develop, so I'm going to merge back to develop. Since we are all adding to develop and that will become the new master when we release I don't' see any issues with that. If you do please let me know.\r\n\r\nThis fixes bug that was causing the download file to not show all the students in the course. The bug fix was easy, we just needed to wrap the SDK call to get the enrollment data in the SDK util method get_all_list_data. The straight call to get enrollments was not following the next url to get the next page of students. The get_all_list_data util method take the call (any call really) as an argument and automatically follows the next url to retrieve the full list. This is what the code looks like now:\r\n```\r\nenrollments = get_all_list_data(request_context, list_users_in_course_users, \r\n                                experiment.course_id, None, enrollment_type=\"student\")\r\n```\r\nThis PR also includes unit tests for the spreadsheet module. There were previously no unit tests for this module. My last run of coverage shows we are getting 97% of the code now. ","created_at":"2015-03-19T14:19:59Z","updated_at":"2015-03-19T15:55:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4683ed3e04e3611c7931a8408f18e0a7e85c1f02","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/penzance/ab-testing-tool/pulls/162/commits","review_comments_url":"https://api.github.com/repos/penzance/ab-testing-tool/pulls/162/comments","review_comment_url":"https://api.github.com/repos/penzance/ab-testing-tool/pulls/comments{/number}","comments_url":"https://api.github.com/repos/penzance/ab-testing-tool/issues/162/comments","statuses_url":"https://api.github.com/repos/penzance/ab-testing-tool/statuses/959502b49573d4c3a7cf0abc3c62bc56fb91ec72","head":{"label":"penzance:bugfix/eparker/TLT-949-download-file-is-not-showing-all-students-in-the-course","ref":"bugfix/eparker/TLT-949-download-file-is-not-showing-all-students-in-the-course","sha":"959502b49573d4c3a7cf0abc3c62bc56fb91ec72","user":{"login":"penzance","id":7885127,"avatar_url":"https://avatars.githubusercontent.com/u/7885127?v=3","gravatar_id":"","url":"https://api.github.com/users/penzance","html_url":"https://github.com/penzance","followers_url":"https://api.github.com/users/penzance/followers","following_url":"https://api.github.com/users/penzance/following{/other_user}","gists_url":"https://api.github.com/users/penzance/gists{/gist_id}","starred_url":"https://api.github.com/users/penzance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/penzance/subscriptions","organizations_url":"https://api.github.com/users/penzance/orgs","repos_url":"https://api.github.com/users/penzance/repos","events_url":"https://api.github.com/users/penzance/events{/privacy}","received_events_url":"https://api.github.com/users/penzance/received_events","type":"Organization","site_admin":false},"repo":{"id":22353530,"name":"ab-testing-tool","full_name":"penzance/ab-testing-tool","owner":{"login":"penzance","id":7885127,"avatar_url":"https://avatars.githubusercontent.com/u/7885127?v=3","gravatar_id":"","url":"https://api.github.com/users/penzance","html_url":"https://github.com/penzance","followers_url":"https://api.github.com/users/penzance/followers","following_url":"https://api.github.com/users/penzance/following{/other_user}","gists_url":"https://api.github.com/users/penzance/gists{/gist_id}","starred_url":"https://api.github.com/users/penzance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/penzance/subscriptions","organizations_url":"https://api.github.com/users/penzance/orgs","repos_url":"https://api.github.com/users/penzance/repos","events_url":"https://api.github.com/users/penzance/events{/privacy}","received_events_url":"https://api.github.com/users/penzance/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/penzance/ab-testing-tool","description":"stage","fork":false,"url":"https://api.github.com/repos/penzance/ab-testing-tool","forks_url":"https://api.github.com/repos/penzance/ab-testing-tool/forks","keys_url":"https://api.github.com/repos/penzance/ab-testing-tool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/penzance/ab-testing-tool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/penzance/ab-testing-tool/teams","hooks_url":"https://api.github.com/repos/penzance/ab-testing-tool/hooks","issue_events_url":"https://api.github.com/repos/penzance/ab-testing-tool/issues/events{/number}","events_url":"https://api.github.com/repos/penzance/ab-testing-tool/events","assignees_url":"https://api.github.com/repos/penzance/ab-testing-tool/assignees{/user}","branches_url":"https://api.github.com/repos/penzance/ab-testing-tool/branches{/branch}","tags_url":"https://api.github.com/repos/penzance/ab-testing-tool/tags","blobs_url":"https://api.github.com/repos/penzance/ab-testing-tool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/penzance/ab-testing-tool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/penzance/ab-testing-tool/git/refs{/sha}","trees_url":"https://api.github.com/repos/penzance/ab-testing-tool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/penzance/ab-testing-tool/statuses/{sha}","languages_url":"https://api.github.com/repos/penzance/ab-testing-tool/languages","stargazers_url":"https://api.github.com/repos/penzance/ab-testing-tool/stargazers","contributors_url":"https://api.github.com/repos/penzance/ab-testing-tool/contributors","subscribers_url":"https://api.github.com/repos/penzance/ab-testing-tool/subscribers","subscription_url":"https://api.github.com/repos/penzance/ab-testing-tool/subscription","commits_url":"https://api.github.com/repos/penzance/ab-testing-tool/commits{/sha}","git_commits_url":"https://api.github.com/repos/penzance/ab-testing-tool/git/commits{/sha}","comments_url":"https://api.github.com/repos/penzance/ab-testing-tool/comments{/number}","issue_comment_url":"https://api.github.com/repos/penzance/ab-testing-tool/issues/comments{/number}","contents_url":"https://api.github.com/repos/penzance/ab-testing-tool/contents/{+path}","compare_url":"https://api.github.com/repos/penzance/ab-testing-tool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/penzance/ab-testing-tool/merges","archive_url":"https://api.github.com/repos/penzance/ab-testing-tool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/penzance/ab-testing-tool/downloads","issues_url":"https://api.github.com/repos/penzance/ab-testing-tool/issues{/number}","pulls_url":"https://api.github.com/repos/penzance/ab-testing-tool/pulls{/number}","milestones_url":"https://api.github.com/repos/penzance/ab-testing-tool/milestones{/number}","notifications_url":"https://api.github.com/repos/penzance/ab-testing-tool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/penzance/ab-testing-tool/labels{/name}","releases_url":"https://api.github.com/repos/penzance/ab-testing-tool/releases{/id}","created_at":"2014-07-28T18:39:09Z","updated_at":"2015-03-17T14:05:36Z","pushed_at":"2015-03-19T15:50:39Z","git_url":"git://github.com/penzance/ab-testing-tool.git","ssh_url":"git@github.com:penzance/ab-testing-tool.git","clone_url":"https://github.com/penzance/ab-testing-tool.git","svn_url":"https://github.com/penzance/ab-testing-tool","homepage":"","size":4568,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":3,"default_branch":"master"}},"base":{"label":"penzance:develop","ref":"develop","sha":"8056ccf357d88e207713d7ba53a0938e25ac49d1","user":{"login":"penzance","id":7885127,"avatar_url":"https://avatars.githubusercontent.com/u/7885127?v=3","gravatar_id":"","url":"https://api.github.com/users/penzance","html_url":"https://github.com/penzance","followers_url":"https://api.github.com/users/penzance/followers","following_url":"https://api.github.com/users/penzance/following{/other_user}","gists_url":"https://api.github.com/users/penzance/gists{/gist_id}","starred_url":"https://api.github.com/users/penzance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/penzance/subscriptions","organizations_url":"https://api.github.com/users/penzance/orgs","repos_url":"https://api.github.com/users/penzance/repos","events_url":"https://api.github.com/users/penzance/events{/privacy}","received_events_url":"https://api.github.com/users/penzance/received_events","type":"Organization","site_admin":false},"repo":{"id":22353530,"name":"ab-testing-tool","full_name":"penzance/ab-testing-tool","owner":{"login":"penzance","id":7885127,"avatar_url":"https://avatars.githubusercontent.com/u/7885127?v=3","gravatar_id":"","url":"https://api.github.com/users/penzance","html_url":"https://github.com/penzance","followers_url":"https://api.github.com/users/penzance/followers","following_url":"https://api.github.com/users/penzance/following{/other_user}","gists_url":"https://api.github.com/users/penzance/gists{/gist_id}","starred_url":"https://api.github.com/users/penzance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/penzance/subscriptions","organizations_url":"https://api.github.com/users/penzance/orgs","repos_url":"https://api.github.com/users/penzance/repos","events_url":"https://api.github.com/users/penzance/events{/privacy}","received_events_url":"https://api.github.com/users/penzance/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/penzance/ab-testing-tool","description":"stage","fork":false,"url":"https://api.github.com/repos/penzance/ab-testing-tool","forks_url":"https://api.github.com/repos/penzance/ab-testing-tool/forks","keys_url":"https://api.github.com/repos/penzance/ab-testing-tool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/penzance/ab-testing-tool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/penzance/ab-testing-tool/teams","hooks_url":"https://api.github.com/repos/penzance/ab-testing-tool/hooks","issue_events_url":"https://api.github.com/repos/penzance/ab-testing-tool/issues/events{/number}","events_url":"https://api.github.com/repos/penzance/ab-testing-tool/events","assignees_url":"https://api.github.com/repos/penzance/ab-testing-tool/assignees{/user}","branches_url":"https://api.github.com/repos/penzance/ab-testing-tool/branches{/branch}","tags_url":"https://api.github.com/repos/penzance/ab-testing-tool/tags","blobs_url":"https://api.github.com/repos/penzance/ab-testing-tool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/penzance/ab-testing-tool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/penzance/ab-testing-tool/git/refs{/sha}","trees_url":"https://api.github.com/repos/penzance/ab-testing-tool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/penzance/ab-testing-tool/statuses/{sha}","languages_url":"https://api.github.com/repos/penzance/ab-testing-tool/languages","stargazers_url":"https://api.github.com/repos/penzance/ab-testing-tool/stargazers","contributors_url":"https://api.github.com/repos/penzance/ab-testing-tool/contributors","subscribers_url":"https://api.github.com/repos/penzance/ab-testing-tool/subscribers","subscription_url":"https://api.github.com/repos/penzance/ab-testing-tool/subscription","commits_url":"https://api.github.com/repos/penzance/ab-testing-tool/commits{/sha}","git_commits_url":"https://api.github.com/repos/penzance/ab-testing-tool/git/commits{/sha}","comments_url":"https://api.github.com/repos/penzance/ab-testing-tool/comments{/number}","issue_comment_url":"https://api.github.com/repos/penzance/ab-testing-tool/issues/comments{/number}","contents_url":"https://api.github.com/repos/penzance/ab-testing-tool/contents/{+path}","compare_url":"https://api.github.com/repos/penzance/ab-testing-tool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/penzance/ab-testing-tool/merges","archive_url":"https://api.github.com/repos/penzance/ab-testing-tool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/penzance/ab-testing-tool/downloads","issues_url":"https://api.github.com/repos/penzance/ab-testing-tool/issues{/number}","pulls_url":"https://api.github.com/repos/penzance/ab-testing-tool/pulls{/number}","milestones_url":"https://api.github.com/repos/penzance/ab-testing-tool/milestones{/number}","notifications_url":"https://api.github.com/repos/penzance/ab-testing-tool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/penzance/ab-testing-tool/labels{/name}","releases_url":"https://api.github.com/repos/penzance/ab-testing-tool/releases{/id}","created_at":"2014-07-28T18:39:09Z","updated_at":"2015-03-17T14:05:36Z","pushed_at":"2015-03-19T15:50:39Z","git_url":"git://github.com/penzance/ab-testing-tool.git","ssh_url":"git@github.com:penzance/ab-testing-tool.git","clone_url":"https://github.com/penzance/ab-testing-tool.git","svn_url":"https://github.com/penzance/ab-testing-tool","homepage":"","size":4568,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/penzance/ab-testing-tool/pulls/162"},"html":{"href":"https://github.com/penzance/ab-testing-tool/pull/162"},"issue":{"href":"https://api.github.com/repos/penzance/ab-testing-tool/issues/162"},"comments":{"href":"https://api.github.com/repos/penzance/ab-testing-tool/issues/162/comments"},"review_comments":{"href":"https://api.github.com/repos/penzance/ab-testing-tool/pulls/162/comments"},"review_comment":{"href":"https://api.github.com/repos/penzance/ab-testing-tool/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/penzance/ab-testing-tool/pulls/162/commits"},"statuses":{"href":"https://api.github.com/repos/penzance/ab-testing-tool/statuses/959502b49573d4c3a7cf0abc3c62bc56fb91ec72"}}}}