{"action":"created","comment":{"url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/pulls/comments/26223352","id":26223352,"diff_hunk":"@@ -85,7 +85,7 @@\n         <dependency>\n             <groupId>org.jboss.aerogear.unifiedpush</groupId>\n             <artifactId>unifiedpush-push-model</artifactId>\n-            <version>1.1.0-alpha.1</version>\n+            <version>1.1.0-alpha.2-SNAPSHOT</version>","path":"pom.xml","position":5,"original_position":5,"commit_id":"657ab12e39c5f65a17c258561e96a2432d359820","original_commit_id":"1630e15f22c4371d1004badd4de5675fdd5079e0","user":{"login":"matzew","id":157646,"avatar_url":"https://avatars.githubusercontent.com/u/157646?v=3","gravatar_id":"","url":"https://api.github.com/users/matzew","html_url":"https://github.com/matzew","followers_url":"https://api.github.com/users/matzew/followers","following_url":"https://api.github.com/users/matzew/following{/other_user}","gists_url":"https://api.github.com/users/matzew/gists{/gist_id}","starred_url":"https://api.github.com/users/matzew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matzew/subscriptions","organizations_url":"https://api.github.com/users/matzew/orgs","repos_url":"https://api.github.com/users/matzew/repos","events_url":"https://api.github.com/users/matzew/events{/privacy}","received_events_url":"https://api.github.com/users/matzew/received_events","type":"User","site_admin":false},"body":"ah, sorry :-)\n\nOn Wed, Mar 11, 2015 at 4:15 PM, Sebastien Blanc <notifications@github.com>\nwrote:\n\n> In pom.xml\n> <https://github.com/aerogear/aerogear-unifiedpush-java-client/pull/68#discussion_r26220827>\n> :\n>\n> > @@ -85,7 +85,7 @@\n> >          <dependency>\n> >              <groupId>org.jboss.aerogear.unifiedpush</groupId>\n> >              <artifactId>unifiedpush-push-model</artifactId>\n> > -            <version>1.1.0-alpha.1</version>\n> > +            <version>1.1.0-alpha.2-SNAPSHOT</version>\n>\n> @matzew <https://github.com/matzew> Ah but that only happens for the\n> version of the project itself, no ? Here we are speaking of a dependency\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/aerogear/aerogear-unifiedpush-java-client/pull/68/files#r26220827>\n> .\n>\n\n\n\n-- \nMatthias Wessendorf\n\nblog: http://matthiaswessendorf.wordpress.com/\nsessions: http://www.slideshare.net/mwessendorf\ntwitter: http://twitter.com/mwessendorf\n","created_at":"2015-03-11T15:39:08Z","updated_at":"2015-03-11T15:39:08Z","html_url":"https://github.com/aerogear/aerogear-unifiedpush-java-client/pull/68#discussion_r26223352","pull_request_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/pulls/68","_links":{"self":{"href":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/pulls/comments/26223352"},"html":{"href":"https://github.com/aerogear/aerogear-unifiedpush-java-client/pull/68#discussion_r26223352"},"pull_request":{"href":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/pulls/68"}}},"pull_request":{"url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/pulls/68","id":30470423,"html_url":"https://github.com/aerogear/aerogear-unifiedpush-java-client/pull/68","diff_url":"https://github.com/aerogear/aerogear-unifiedpush-java-client/pull/68.diff","patch_url":"https://github.com/aerogear/aerogear-unifiedpush-java-client/pull/68.patch","issue_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/issues/68","number":68,"state":"open","locked":false,"title":"AGPUSH-1262 : add windows builder methods","user":{"login":"sebastienblanc","id":335133,"avatar_url":"https://avatars.githubusercontent.com/u/335133?v=3","gravatar_id":"","url":"https://api.github.com/users/sebastienblanc","html_url":"https://github.com/sebastienblanc","followers_url":"https://api.github.com/users/sebastienblanc/followers","following_url":"https://api.github.com/users/sebastienblanc/following{/other_user}","gists_url":"https://api.github.com/users/sebastienblanc/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastienblanc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastienblanc/subscriptions","organizations_url":"https://api.github.com/users/sebastienblanc/orgs","repos_url":"https://api.github.com/users/sebastienblanc/repos","events_url":"https://api.github.com/users/sebastienblanc/events{/privacy}","received_events_url":"https://api.github.com/users/sebastienblanc/received_events","type":"User","site_admin":false},"body":"This is a first version of Windows support for the Java Sender. This should be merged only after the UPS alpha.2 release (tha'ts why the pom.xml is for now modified to enable testing).\r\n\r\nPlease take a close look at the new API methods, the test case can be a good start.\r\nI'm not sure about the `build()` method of the `WindowsBuilder` , it builds and return the `UnifiedPushMessage` but maybe it should return the `MessageBuilder` instead since it's a \"sub\"-builder, wdyt ? \r\n\r\n@edewit @secondsun could you take a look ? ","created_at":"2015-03-04T14:42:01Z","updated_at":"2015-03-11T15:39:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ccbebf65d15db16b1371628c2f04b3ce86af7bd0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/pulls/68/commits","review_comments_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/pulls/68/comments","review_comment_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/issues/68/comments","statuses_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/statuses/657ab12e39c5f65a17c258561e96a2432d359820","head":{"label":"sebastienblanc:AGPUSH-1262","ref":"AGPUSH-1262","sha":"657ab12e39c5f65a17c258561e96a2432d359820","user":{"login":"sebastienblanc","id":335133,"avatar_url":"https://avatars.githubusercontent.com/u/335133?v=3","gravatar_id":"","url":"https://api.github.com/users/sebastienblanc","html_url":"https://github.com/sebastienblanc","followers_url":"https://api.github.com/users/sebastienblanc/followers","following_url":"https://api.github.com/users/sebastienblanc/following{/other_user}","gists_url":"https://api.github.com/users/sebastienblanc/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastienblanc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastienblanc/subscriptions","organizations_url":"https://api.github.com/users/sebastienblanc/orgs","repos_url":"https://api.github.com/users/sebastienblanc/repos","events_url":"https://api.github.com/users/sebastienblanc/events{/privacy}","received_events_url":"https://api.github.com/users/sebastienblanc/received_events","type":"User","site_admin":false},"repo":{"id":10666240,"name":"aerogear-unified-push-java-client","full_name":"sebastienblanc/aerogear-unified-push-java-client","owner":{"login":"sebastienblanc","id":335133,"avatar_url":"https://avatars.githubusercontent.com/u/335133?v=3","gravatar_id":"","url":"https://api.github.com/users/sebastienblanc","html_url":"https://github.com/sebastienblanc","followers_url":"https://api.github.com/users/sebastienblanc/followers","following_url":"https://api.github.com/users/sebastienblanc/following{/other_user}","gists_url":"https://api.github.com/users/sebastienblanc/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastienblanc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastienblanc/subscriptions","organizations_url":"https://api.github.com/users/sebastienblanc/orgs","repos_url":"https://api.github.com/users/sebastienblanc/repos","events_url":"https://api.github.com/users/sebastienblanc/events{/privacy}","received_events_url":"https://api.github.com/users/sebastienblanc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sebastienblanc/aerogear-unified-push-java-client","description":"Java API to access the Unified Push Server","fork":true,"url":"https://api.github.com/repos/sebastienblanc/aerogear-unified-push-java-client","forks_url":"https://api.github.com/repos/sebastienblanc/aerogear-unified-push-java-client/forks","keys_url":"https://api.github.com/repos/sebastienblanc/aerogear-unified-push-java-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sebastienblanc/aerogear-unified-push-java-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sebastienblanc/aerogear-unified-push-java-client/teams","hooks_url":"https://api.github.com/repos/sebastienblanc/aerogear-unified-push-java-client/hooks","issue_events_url":"https://api.github.com/repos/sebastienblanc/aerogear-unified-push-java-client/issues/events{/number}","events_url":"https://api.github.com/repos/sebastienblanc/aerogear-unified-push-java-client/events","assignees_url":"https://api.github.com/repos/sebastienblanc/aerogear-unified-push-java-client/assignees{/user}","branches_url":"https://api.github.com/repos/sebastienblanc/aerogear-unified-push-java-client/branches{/branch}","tags_url":"https://api.github.com/repos/sebastienblanc/aerogear-unified-push-java-client/tags","blobs_url":"https://api.github.com/repos/sebastienblanc/aerogear-unified-push-java-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sebastienblanc/aerogear-unified-push-java-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sebastienblanc/aerogear-unified-push-java-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/sebastienblanc/aerogear-unified-push-java-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sebastienblanc/aerogear-unified-push-java-client/statuses/{sha}","languages_url":"https://api.github.com/repos/sebastienblanc/aerogear-unified-push-java-client/languages","stargazers_url":"https://api.github.com/repos/sebastienblanc/aerogear-unified-push-java-client/stargazers","contributors_url":"https://api.github.com/repos/sebastienblanc/aerogear-unified-push-java-client/contributors","subscribers_url":"https://api.github.com/repos/sebastienblanc/aerogear-unified-push-java-client/subscribers","subscription_url":"https://api.github.com/repos/sebastienblanc/aerogear-unified-push-java-client/subscription","commits_url":"https://api.github.com/repos/sebastienblanc/aerogear-unified-push-java-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/sebastienblanc/aerogear-unified-push-java-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/sebastienblanc/aerogear-unified-push-java-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/sebastienblanc/aerogear-unified-push-java-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/sebastienblanc/aerogear-unified-push-java-client/contents/{+path}","compare_url":"https://api.github.com/repos/sebastienblanc/aerogear-unified-push-java-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sebastienblanc/aerogear-unified-push-java-client/merges","archive_url":"https://api.github.com/repos/sebastienblanc/aerogear-unified-push-java-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sebastienblanc/aerogear-unified-push-java-client/downloads","issues_url":"https://api.github.com/repos/sebastienblanc/aerogear-unified-push-java-client/issues{/number}","pulls_url":"https://api.github.com/repos/sebastienblanc/aerogear-unified-push-java-client/pulls{/number}","milestones_url":"https://api.github.com/repos/sebastienblanc/aerogear-unified-push-java-client/milestones{/number}","notifications_url":"https://api.github.com/repos/sebastienblanc/aerogear-unified-push-java-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sebastienblanc/aerogear-unified-push-java-client/labels{/name}","releases_url":"https://api.github.com/repos/sebastienblanc/aerogear-unified-push-java-client/releases{/id}","created_at":"2013-06-13T13:04:35Z","updated_at":"2013-06-13T13:04:35Z","pushed_at":"2015-03-11T14:47:25Z","git_url":"git://github.com/sebastienblanc/aerogear-unified-push-java-client.git","ssh_url":"git@github.com:sebastienblanc/aerogear-unified-push-java-client.git","clone_url":"https://github.com/sebastienblanc/aerogear-unified-push-java-client.git","svn_url":"https://github.com/sebastienblanc/aerogear-unified-push-java-client","homepage":null,"size":482,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aerogear:master","ref":"master","sha":"f6199a5fea0c9b63c0fa1af9267a6d28a7b9b66f","user":{"login":"aerogear","id":954205,"avatar_url":"https://avatars.githubusercontent.com/u/954205?v=3","gravatar_id":"","url":"https://api.github.com/users/aerogear","html_url":"https://github.com/aerogear","followers_url":"https://api.github.com/users/aerogear/followers","following_url":"https://api.github.com/users/aerogear/following{/other_user}","gists_url":"https://api.github.com/users/aerogear/gists{/gist_id}","starred_url":"https://api.github.com/users/aerogear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerogear/subscriptions","organizations_url":"https://api.github.com/users/aerogear/orgs","repos_url":"https://api.github.com/users/aerogear/repos","events_url":"https://api.github.com/users/aerogear/events{/privacy}","received_events_url":"https://api.github.com/users/aerogear/received_events","type":"Organization","site_admin":false},"repo":{"id":10645543,"name":"aerogear-unifiedpush-java-client","full_name":"aerogear/aerogear-unifiedpush-java-client","owner":{"login":"aerogear","id":954205,"avatar_url":"https://avatars.githubusercontent.com/u/954205?v=3","gravatar_id":"","url":"https://api.github.com/users/aerogear","html_url":"https://github.com/aerogear","followers_url":"https://api.github.com/users/aerogear/followers","following_url":"https://api.github.com/users/aerogear/following{/other_user}","gists_url":"https://api.github.com/users/aerogear/gists{/gist_id}","starred_url":"https://api.github.com/users/aerogear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerogear/subscriptions","organizations_url":"https://api.github.com/users/aerogear/orgs","repos_url":"https://api.github.com/users/aerogear/repos","events_url":"https://api.github.com/users/aerogear/events{/privacy}","received_events_url":"https://api.github.com/users/aerogear/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aerogear/aerogear-unifiedpush-java-client","description":"Java API to access the Unified Push Server","fork":false,"url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client","forks_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/forks","keys_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/teams","hooks_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/hooks","issue_events_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/issues/events{/number}","events_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/events","assignees_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/assignees{/user}","branches_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/branches{/branch}","tags_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/tags","blobs_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/statuses/{sha}","languages_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/languages","stargazers_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/stargazers","contributors_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/contributors","subscribers_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/subscribers","subscription_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/subscription","commits_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/contents/{+path}","compare_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/merges","archive_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/downloads","issues_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/issues{/number}","pulls_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/pulls{/number}","milestones_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/milestones{/number}","notifications_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/labels{/name}","releases_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/releases{/id}","created_at":"2013-06-12T15:14:10Z","updated_at":"2015-02-11T13:33:45Z","pushed_at":"2015-02-11T13:33:44Z","git_url":"git://github.com/aerogear/aerogear-unifiedpush-java-client.git","ssh_url":"git@github.com:aerogear/aerogear-unifiedpush-java-client.git","clone_url":"https://github.com/aerogear/aerogear-unifiedpush-java-client.git","svn_url":"https://github.com/aerogear/aerogear-unifiedpush-java-client","homepage":null,"size":1207,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":1,"forks":24,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/pulls/68"},"html":{"href":"https://github.com/aerogear/aerogear-unifiedpush-java-client/pull/68"},"issue":{"href":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/issues/68"},"comments":{"href":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-java-client/statuses/657ab12e39c5f65a17c258561e96a2432d359820"}}}}