{"action":"created","comment":{"url":"https://api.github.com/repos/ros/rospack/pulls/comments/47261875","id":47261875,"diff_hunk":"@@ -152,6 +152,7 @@ class ROSPACK_DECL Rosstackage\n     std::tr1::unordered_map<std::string, Stackage*> stackages_;\n     Stackage* findWithRecrawl(const std::string& name);\n     void log(const std::string& level, const std::string& msg, bool append_errno);\n+    void clearStackages();","path":"include/rospack/rospack.h","position":4,"original_position":4,"commit_id":"46be507bf4eee4ddb8cc5dfbff7375eb5cd4ed53","original_commit_id":"46be507bf4eee4ddb8cc5dfbff7375eb5cd4ed53","user":{"login":"dirk-thomas","id":1335366,"avatar_url":"https://avatars.githubusercontent.com/u/1335366?v=3","gravatar_id":"","url":"https://api.github.com/users/dirk-thomas","html_url":"https://github.com/dirk-thomas","followers_url":"https://api.github.com/users/dirk-thomas/followers","following_url":"https://api.github.com/users/dirk-thomas/following{/other_user}","gists_url":"https://api.github.com/users/dirk-thomas/gists{/gist_id}","starred_url":"https://api.github.com/users/dirk-thomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirk-thomas/subscriptions","organizations_url":"https://api.github.com/users/dirk-thomas/orgs","repos_url":"https://api.github.com/users/dirk-thomas/repos","events_url":"https://api.github.com/users/dirk-thomas/events{/privacy}","received_events_url":"https://api.github.com/users/dirk-thomas/received_events","type":"User","site_admin":false},"body":"We don't enforce it but try to avoid it when possible since many more people have from-source builds.","created_at":"2015-12-10T18:11:36Z","updated_at":"2015-12-10T18:11:36Z","html_url":"https://github.com/ros/rospack/pull/54#discussion_r47261875","pull_request_url":"https://api.github.com/repos/ros/rospack/pulls/54","_links":{"self":{"href":"https://api.github.com/repos/ros/rospack/pulls/comments/47261875"},"html":{"href":"https://github.com/ros/rospack/pull/54#discussion_r47261875"},"pull_request":{"href":"https://api.github.com/repos/ros/rospack/pulls/54"}}},"pull_request":{"url":"https://api.github.com/repos/ros/rospack/pulls/54","id":53207708,"html_url":"https://github.com/ros/rospack/pull/54","diff_url":"https://github.com/ros/rospack/pull/54.diff","patch_url":"https://github.com/ros/rospack/pull/54.patch","issue_url":"https://api.github.com/repos/ros/rospack/issues/54","number":54,"state":"open","locked":false,"title":"Reuse previous results for better performance (replaces #49)","user":{"login":"gerkey","id":1188842,"avatar_url":"https://avatars.githubusercontent.com/u/1188842?v=3","gravatar_id":"","url":"https://api.github.com/users/gerkey","html_url":"https://github.com/gerkey","followers_url":"https://api.github.com/users/gerkey/followers","following_url":"https://api.github.com/users/gerkey/following{/other_user}","gists_url":"https://api.github.com/users/gerkey/gists{/gist_id}","starred_url":"https://api.github.com/users/gerkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerkey/subscriptions","organizations_url":"https://api.github.com/users/gerkey/orgs","repos_url":"https://api.github.com/users/gerkey/repos","events_url":"https://api.github.com/users/gerkey/events{/privacy}","received_events_url":"https://api.github.com/users/gerkey/received_events","type":"User","site_admin":false},"body":"This is a replacement for #49 that fixes a couple of problems and adds tests to demonstrate that the in-process behavior is correct in the case of environment variable change: https://github.com/ros/rospack/blob/reuse_cache/test/test/utest.cpp#L130.\r\n\r\nRequires ros/ros#98.\r\n\r\nI think that this is a good change and am satisfied that we've done a good amount of testing on it. @dirk-thomas, what's your opinion? Other test cases that we should consider?\r\n\r\nBtw, I'm targeting this change at indigo, but it could go to jade instead.","created_at":"2015-12-10T02:24:33Z","updated_at":"2015-12-10T18:11:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"082afaa674132803d4ec9f0c607a34fa5e23b14f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ros/rospack/pulls/54/commits","review_comments_url":"https://api.github.com/repos/ros/rospack/pulls/54/comments","review_comment_url":"https://api.github.com/repos/ros/rospack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros/rospack/issues/54/comments","statuses_url":"https://api.github.com/repos/ros/rospack/statuses/46be507bf4eee4ddb8cc5dfbff7375eb5cd4ed53","head":{"label":"ros:reuse_cache","ref":"reuse_cache","sha":"46be507bf4eee4ddb8cc5dfbff7375eb5cd4ed53","user":{"login":"ros","id":547448,"avatar_url":"https://avatars.githubusercontent.com/u/547448?v=3","gravatar_id":"","url":"https://api.github.com/users/ros","html_url":"https://github.com/ros","followers_url":"https://api.github.com/users/ros/followers","following_url":"https://api.github.com/users/ros/following{/other_user}","gists_url":"https://api.github.com/users/ros/gists{/gist_id}","starred_url":"https://api.github.com/users/ros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros/subscriptions","organizations_url":"https://api.github.com/users/ros/orgs","repos_url":"https://api.github.com/users/ros/repos","events_url":"https://api.github.com/users/ros/events{/privacy}","received_events_url":"https://api.github.com/users/ros/received_events","type":"Organization","site_admin":false},"repo":{"id":7512077,"name":"rospack","full_name":"ros/rospack","owner":{"login":"ros","id":547448,"avatar_url":"https://avatars.githubusercontent.com/u/547448?v=3","gravatar_id":"","url":"https://api.github.com/users/ros","html_url":"https://github.com/ros","followers_url":"https://api.github.com/users/ros/followers","following_url":"https://api.github.com/users/ros/following{/other_user}","gists_url":"https://api.github.com/users/ros/gists{/gist_id}","starred_url":"https://api.github.com/users/ros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros/subscriptions","organizations_url":"https://api.github.com/users/ros/orgs","repos_url":"https://api.github.com/users/ros/repos","events_url":"https://api.github.com/users/ros/events{/privacy}","received_events_url":"https://api.github.com/users/ros/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros/rospack","description":"A command-line tool for retrieving information about ROS packages available on the filesystem","fork":false,"url":"https://api.github.com/repos/ros/rospack","forks_url":"https://api.github.com/repos/ros/rospack/forks","keys_url":"https://api.github.com/repos/ros/rospack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros/rospack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros/rospack/teams","hooks_url":"https://api.github.com/repos/ros/rospack/hooks","issue_events_url":"https://api.github.com/repos/ros/rospack/issues/events{/number}","events_url":"https://api.github.com/repos/ros/rospack/events","assignees_url":"https://api.github.com/repos/ros/rospack/assignees{/user}","branches_url":"https://api.github.com/repos/ros/rospack/branches{/branch}","tags_url":"https://api.github.com/repos/ros/rospack/tags","blobs_url":"https://api.github.com/repos/ros/rospack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros/rospack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros/rospack/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros/rospack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros/rospack/statuses/{sha}","languages_url":"https://api.github.com/repos/ros/rospack/languages","stargazers_url":"https://api.github.com/repos/ros/rospack/stargazers","contributors_url":"https://api.github.com/repos/ros/rospack/contributors","subscribers_url":"https://api.github.com/repos/ros/rospack/subscribers","subscription_url":"https://api.github.com/repos/ros/rospack/subscription","commits_url":"https://api.github.com/repos/ros/rospack/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros/rospack/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros/rospack/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros/rospack/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros/rospack/contents/{+path}","compare_url":"https://api.github.com/repos/ros/rospack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros/rospack/merges","archive_url":"https://api.github.com/repos/ros/rospack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros/rospack/downloads","issues_url":"https://api.github.com/repos/ros/rospack/issues{/number}","pulls_url":"https://api.github.com/repos/ros/rospack/pulls{/number}","milestones_url":"https://api.github.com/repos/ros/rospack/milestones{/number}","notifications_url":"https://api.github.com/repos/ros/rospack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros/rospack/labels{/name}","releases_url":"https://api.github.com/repos/ros/rospack/releases{/id}","created_at":"2013-01-09T00:25:09Z","updated_at":"2015-04-08T19:47:58Z","pushed_at":"2015-12-10T02:24:33Z","git_url":"git://github.com/ros/rospack.git","ssh_url":"git@github.com:ros/rospack.git","clone_url":"https://github.com/ros/rospack.git","svn_url":"https://github.com/ros/rospack","homepage":null,"size":643,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":2,"forks":19,"open_issues":2,"watchers":4,"default_branch":"indigo-devel"}},"base":{"label":"ros:indigo-devel","ref":"indigo-devel","sha":"9f5f18eac01ed97144c88f9613630883c480fac9","user":{"login":"ros","id":547448,"avatar_url":"https://avatars.githubusercontent.com/u/547448?v=3","gravatar_id":"","url":"https://api.github.com/users/ros","html_url":"https://github.com/ros","followers_url":"https://api.github.com/users/ros/followers","following_url":"https://api.github.com/users/ros/following{/other_user}","gists_url":"https://api.github.com/users/ros/gists{/gist_id}","starred_url":"https://api.github.com/users/ros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros/subscriptions","organizations_url":"https://api.github.com/users/ros/orgs","repos_url":"https://api.github.com/users/ros/repos","events_url":"https://api.github.com/users/ros/events{/privacy}","received_events_url":"https://api.github.com/users/ros/received_events","type":"Organization","site_admin":false},"repo":{"id":7512077,"name":"rospack","full_name":"ros/rospack","owner":{"login":"ros","id":547448,"avatar_url":"https://avatars.githubusercontent.com/u/547448?v=3","gravatar_id":"","url":"https://api.github.com/users/ros","html_url":"https://github.com/ros","followers_url":"https://api.github.com/users/ros/followers","following_url":"https://api.github.com/users/ros/following{/other_user}","gists_url":"https://api.github.com/users/ros/gists{/gist_id}","starred_url":"https://api.github.com/users/ros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros/subscriptions","organizations_url":"https://api.github.com/users/ros/orgs","repos_url":"https://api.github.com/users/ros/repos","events_url":"https://api.github.com/users/ros/events{/privacy}","received_events_url":"https://api.github.com/users/ros/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros/rospack","description":"A command-line tool for retrieving information about ROS packages available on the filesystem","fork":false,"url":"https://api.github.com/repos/ros/rospack","forks_url":"https://api.github.com/repos/ros/rospack/forks","keys_url":"https://api.github.com/repos/ros/rospack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros/rospack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros/rospack/teams","hooks_url":"https://api.github.com/repos/ros/rospack/hooks","issue_events_url":"https://api.github.com/repos/ros/rospack/issues/events{/number}","events_url":"https://api.github.com/repos/ros/rospack/events","assignees_url":"https://api.github.com/repos/ros/rospack/assignees{/user}","branches_url":"https://api.github.com/repos/ros/rospack/branches{/branch}","tags_url":"https://api.github.com/repos/ros/rospack/tags","blobs_url":"https://api.github.com/repos/ros/rospack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros/rospack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros/rospack/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros/rospack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros/rospack/statuses/{sha}","languages_url":"https://api.github.com/repos/ros/rospack/languages","stargazers_url":"https://api.github.com/repos/ros/rospack/stargazers","contributors_url":"https://api.github.com/repos/ros/rospack/contributors","subscribers_url":"https://api.github.com/repos/ros/rospack/subscribers","subscription_url":"https://api.github.com/repos/ros/rospack/subscription","commits_url":"https://api.github.com/repos/ros/rospack/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros/rospack/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros/rospack/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros/rospack/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros/rospack/contents/{+path}","compare_url":"https://api.github.com/repos/ros/rospack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros/rospack/merges","archive_url":"https://api.github.com/repos/ros/rospack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros/rospack/downloads","issues_url":"https://api.github.com/repos/ros/rospack/issues{/number}","pulls_url":"https://api.github.com/repos/ros/rospack/pulls{/number}","milestones_url":"https://api.github.com/repos/ros/rospack/milestones{/number}","notifications_url":"https://api.github.com/repos/ros/rospack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros/rospack/labels{/name}","releases_url":"https://api.github.com/repos/ros/rospack/releases{/id}","created_at":"2013-01-09T00:25:09Z","updated_at":"2015-04-08T19:47:58Z","pushed_at":"2015-12-10T02:24:33Z","git_url":"git://github.com/ros/rospack.git","ssh_url":"git@github.com:ros/rospack.git","clone_url":"https://github.com/ros/rospack.git","svn_url":"https://github.com/ros/rospack","homepage":null,"size":643,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":2,"forks":19,"open_issues":2,"watchers":4,"default_branch":"indigo-devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ros/rospack/pulls/54"},"html":{"href":"https://github.com/ros/rospack/pull/54"},"issue":{"href":"https://api.github.com/repos/ros/rospack/issues/54"},"comments":{"href":"https://api.github.com/repos/ros/rospack/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/ros/rospack/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/ros/rospack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros/rospack/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/ros/rospack/statuses/46be507bf4eee4ddb8cc5dfbff7375eb5cd4ed53"}}}}