{"action":"created","issue":{"url":"https://api.github.com/repos/dimsemenov/Magnific-Popup/issues/734","labels_url":"https://api.github.com/repos/dimsemenov/Magnific-Popup/issues/734/labels{/name}","comments_url":"https://api.github.com/repos/dimsemenov/Magnific-Popup/issues/734/comments","events_url":"https://api.github.com/repos/dimsemenov/Magnific-Popup/issues/734/events","html_url":"https://github.com/dimsemenov/Magnific-Popup/issues/734","id":106949311,"number":734,"title":"Incompatibility with XHTML","user":{"login":"Noitidart","id":6372489,"avatar_url":"https://avatars.githubusercontent.com/u/6372489?v=3","gravatar_id":"","url":"https://api.github.com/users/Noitidart","html_url":"https://github.com/Noitidart","followers_url":"https://api.github.com/users/Noitidart/followers","following_url":"https://api.github.com/users/Noitidart/following{/other_user}","gists_url":"https://api.github.com/users/Noitidart/gists{/gist_id}","starred_url":"https://api.github.com/users/Noitidart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Noitidart/subscriptions","organizations_url":"https://api.github.com/users/Noitidart/orgs","repos_url":"https://api.github.com/users/Noitidart/repos","events_url":"https://api.github.com/users/Noitidart/events{/privacy}","received_events_url":"https://api.github.com/users/Noitidart/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-09-17T09:53:36Z","updated_at":"2015-09-17T10:56:30Z","closed_at":"2015-09-17T10:34:34Z","body":"In Firefox addons to localize our pages we have to use `.xhtml` files. In XHTML, the `&times;` is an `undefined identity`. So this throws `undefined identity` then makes jquery fragment builder throw a syntax error.\r\n\r\nError is here: https://github.com/dimsemenov/Magnific-Popup/blob/master/dist/jquery.magnific-popup.js#L906\r\n\r\nI had to fix it to use an `X`, but I'm not sure what to do for the times character in xhtml"},"comment":{"url":"https://api.github.com/repos/dimsemenov/Magnific-Popup/issues/comments/141042567","html_url":"https://github.com/dimsemenov/Magnific-Popup/issues/734#issuecomment-141042567","issue_url":"https://api.github.com/repos/dimsemenov/Magnific-Popup/issues/734","id":141042567,"user":{"login":"Noitidart","id":6372489,"avatar_url":"https://avatars.githubusercontent.com/u/6372489?v=3","gravatar_id":"","url":"https://api.github.com/users/Noitidart","html_url":"https://github.com/Noitidart","followers_url":"https://api.github.com/users/Noitidart/followers","following_url":"https://api.github.com/users/Noitidart/following{/other_user}","gists_url":"https://api.github.com/users/Noitidart/gists{/gist_id}","starred_url":"https://api.github.com/users/Noitidart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Noitidart/subscriptions","organizations_url":"https://api.github.com/users/Noitidart/orgs","repos_url":"https://api.github.com/users/Noitidart/repos","events_url":"https://api.github.com/users/Noitidart/events{/privacy}","received_events_url":"https://api.github.com/users/Noitidart/received_events","type":"User","site_admin":false},"created_at":"2015-09-17T10:56:30Z","updated_at":"2015-09-17T10:56:30Z","body":"The only fix i was able to ome up with so it doesnt hijack shift key was to add to this line:\r\n\r\nhttps://github.com/dimsemenov/Magnific-Popup/blob/a84fd7ca0615dedffc7d55782e80dd49db6e6987/dist/jquery.magnific-popup.js#L645\r\n\r\nI made it from:\r\n\r\n    if(!midClick && ( e.which === 2 || e.ctrlKey || e.metaKey ) ) {\r\n\r\nto:\r\n\r\n    if(!midClick && ( e.which === 2 || e.ctrlKey || e.metaKey || e.shiftKey ) ) {\r\n\r\nshould we implement this as a fix? should we add in  e.altKey? I haven't seen it but maybe someone somewhere uses it?"}}