{"action":"opened","number":29,"pull_request":{"url":"https://api.github.com/repos/aardappel/treesheets/pulls/29","id":31235133,"html_url":"https://github.com/aardappel/treesheets/pull/29","diff_url":"https://github.com/aardappel/treesheets/pull/29.diff","patch_url":"https://github.com/aardappel/treesheets/pull/29.patch","issue_url":"https://api.github.com/repos/aardappel/treesheets/issues/29","number":29,"state":"open","locked":false,"title":"Create files for BSD and GNU make with changes inside of Makefile.common","user":{"login":"senderghost","id":11497512,"avatar_url":"https://avatars.githubusercontent.com/u/11497512?v=3","gravatar_id":"","url":"https://api.github.com/users/senderghost","html_url":"https://github.com/senderghost","followers_url":"https://api.github.com/users/senderghost/followers","following_url":"https://api.github.com/users/senderghost/following{/other_user}","gists_url":"https://api.github.com/users/senderghost/gists{/gist_id}","starred_url":"https://api.github.com/users/senderghost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/senderghost/subscriptions","organizations_url":"https://api.github.com/users/senderghost/orgs","repos_url":"https://api.github.com/users/senderghost/repos","events_url":"https://api.github.com/users/senderghost/events{/privacy}","received_events_url":"https://api.github.com/users/senderghost/received_events","type":"User","site_admin":false},"body":"Hello, Wouter van Oortmerssen.\r\n\r\nThanks for addition of Makefile, which I created a while ago on FreeBSD Bugzilla.\r\n\r\nMy initial version was compatible with BSD and GNU make variants. But you introduced some changes, which used as a GNU extensions and not compatible with BSD make.\r\n\r\nI propose to create BSDmakefile and GNUmakefile with changes inside of Makefile.common.\r\nThe BSDmakefile (GNUmakefile) is alternative Makefile's name for BSD (GNU) make. This way, they might be used on BSD and Linux operating systems without additional dependencies on particular make system.\r\n\r\nAlso, I propose to move installation and deinstallation from \"all\" target (goal) to \"install\" and \"deinstall\" targets. The C++ \"-O3\" compiler option (for CXXFLAGS) might be used on \"release\" target. This is useful in case of system-wide configuration (e.g. inside of /etc/make.conf) or custom options and adds more granularity.\r\n\r\nThe examples of basic usage:\r\nBuild executable with system-wide configuraion and/or custom options from environment:\r\n% make\r\nBuild and install executable file:\r\n% make install\r\nDeinstall executable file:\r\n% make deinstall\r\nRemove intermediate files:\r\n% make clean\r\nBuild release version (with C++ \"-O3\" compiler option):\r\n% make release\r\nBuild debug version (with C++ \"-g\" compiler option):\r\n% make debug\r\nAlso possible to combine targets:\r\nBuild release version and install executable file:\r\n% make release install\r\nBuild debug version and install executable file:\r\n% make debug install\r\nDeinstall executable and remove intermediate files, if needed:\r\n% make deinstall clean\r\n\r\nTested on FreeBSD 10 for make and gmake variants.","created_at":"2015-03-16T11:28:41Z","updated_at":"2015-03-16T11:28:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aardappel/treesheets/pulls/29/commits","review_comments_url":"https://api.github.com/repos/aardappel/treesheets/pulls/29/comments","review_comment_url":"https://api.github.com/repos/aardappel/treesheets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aardappel/treesheets/issues/29/comments","statuses_url":"https://api.github.com/repos/aardappel/treesheets/statuses/488dfbfdbfd7f8e0ed469edea7ff0c95d58933d5","head":{"label":"senderghost:makefiles","ref":"makefiles","sha":"488dfbfdbfd7f8e0ed469edea7ff0c95d58933d5","user":{"login":"senderghost","id":11497512,"avatar_url":"https://avatars.githubusercontent.com/u/11497512?v=3","gravatar_id":"","url":"https://api.github.com/users/senderghost","html_url":"https://github.com/senderghost","followers_url":"https://api.github.com/users/senderghost/followers","following_url":"https://api.github.com/users/senderghost/following{/other_user}","gists_url":"https://api.github.com/users/senderghost/gists{/gist_id}","starred_url":"https://api.github.com/users/senderghost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/senderghost/subscriptions","organizations_url":"https://api.github.com/users/senderghost/orgs","repos_url":"https://api.github.com/users/senderghost/repos","events_url":"https://api.github.com/users/senderghost/events{/privacy}","received_events_url":"https://api.github.com/users/senderghost/received_events","type":"User","site_admin":false},"repo":{"id":32313652,"name":"treesheets","full_name":"senderghost/treesheets","owner":{"login":"senderghost","id":11497512,"avatar_url":"https://avatars.githubusercontent.com/u/11497512?v=3","gravatar_id":"","url":"https://api.github.com/users/senderghost","html_url":"https://github.com/senderghost","followers_url":"https://api.github.com/users/senderghost/followers","following_url":"https://api.github.com/users/senderghost/following{/other_user}","gists_url":"https://api.github.com/users/senderghost/gists{/gist_id}","starred_url":"https://api.github.com/users/senderghost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/senderghost/subscriptions","organizations_url":"https://api.github.com/users/senderghost/orgs","repos_url":"https://api.github.com/users/senderghost/repos","events_url":"https://api.github.com/users/senderghost/events{/privacy}","received_events_url":"https://api.github.com/users/senderghost/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/senderghost/treesheets","description":"TreeSheets : Free Form Data Organizer (see treesheets.com)","fork":true,"url":"https://api.github.com/repos/senderghost/treesheets","forks_url":"https://api.github.com/repos/senderghost/treesheets/forks","keys_url":"https://api.github.com/repos/senderghost/treesheets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/senderghost/treesheets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/senderghost/treesheets/teams","hooks_url":"https://api.github.com/repos/senderghost/treesheets/hooks","issue_events_url":"https://api.github.com/repos/senderghost/treesheets/issues/events{/number}","events_url":"https://api.github.com/repos/senderghost/treesheets/events","assignees_url":"https://api.github.com/repos/senderghost/treesheets/assignees{/user}","branches_url":"https://api.github.com/repos/senderghost/treesheets/branches{/branch}","tags_url":"https://api.github.com/repos/senderghost/treesheets/tags","blobs_url":"https://api.github.com/repos/senderghost/treesheets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/senderghost/treesheets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/senderghost/treesheets/git/refs{/sha}","trees_url":"https://api.github.com/repos/senderghost/treesheets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/senderghost/treesheets/statuses/{sha}","languages_url":"https://api.github.com/repos/senderghost/treesheets/languages","stargazers_url":"https://api.github.com/repos/senderghost/treesheets/stargazers","contributors_url":"https://api.github.com/repos/senderghost/treesheets/contributors","subscribers_url":"https://api.github.com/repos/senderghost/treesheets/subscribers","subscription_url":"https://api.github.com/repos/senderghost/treesheets/subscription","commits_url":"https://api.github.com/repos/senderghost/treesheets/commits{/sha}","git_commits_url":"https://api.github.com/repos/senderghost/treesheets/git/commits{/sha}","comments_url":"https://api.github.com/repos/senderghost/treesheets/comments{/number}","issue_comment_url":"https://api.github.com/repos/senderghost/treesheets/issues/comments{/number}","contents_url":"https://api.github.com/repos/senderghost/treesheets/contents/{+path}","compare_url":"https://api.github.com/repos/senderghost/treesheets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/senderghost/treesheets/merges","archive_url":"https://api.github.com/repos/senderghost/treesheets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/senderghost/treesheets/downloads","issues_url":"https://api.github.com/repos/senderghost/treesheets/issues{/number}","pulls_url":"https://api.github.com/repos/senderghost/treesheets/pulls{/number}","milestones_url":"https://api.github.com/repos/senderghost/treesheets/milestones{/number}","notifications_url":"https://api.github.com/repos/senderghost/treesheets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/senderghost/treesheets/labels{/name}","releases_url":"https://api.github.com/repos/senderghost/treesheets/releases{/id}","created_at":"2015-03-16T09:17:52Z","updated_at":"2015-03-16T09:17:52Z","pushed_at":"2015-03-16T09:49:33Z","git_url":"git://github.com/senderghost/treesheets.git","ssh_url":"git@github.com:senderghost/treesheets.git","clone_url":"https://github.com/senderghost/treesheets.git","svn_url":"https://github.com/senderghost/treesheets","homepage":null,"size":2732,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aardappel:master","ref":"master","sha":"7950f7781414a3bdca1edeeeb3b5574bf54bdb2f","user":{"login":"aardappel","id":4663648,"avatar_url":"https://avatars.githubusercontent.com/u/4663648?v=3","gravatar_id":"","url":"https://api.github.com/users/aardappel","html_url":"https://github.com/aardappel","followers_url":"https://api.github.com/users/aardappel/followers","following_url":"https://api.github.com/users/aardappel/following{/other_user}","gists_url":"https://api.github.com/users/aardappel/gists{/gist_id}","starred_url":"https://api.github.com/users/aardappel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aardappel/subscriptions","organizations_url":"https://api.github.com/users/aardappel/orgs","repos_url":"https://api.github.com/users/aardappel/repos","events_url":"https://api.github.com/users/aardappel/events{/privacy}","received_events_url":"https://api.github.com/users/aardappel/received_events","type":"User","site_admin":false},"repo":{"id":10671623,"name":"treesheets","full_name":"aardappel/treesheets","owner":{"login":"aardappel","id":4663648,"avatar_url":"https://avatars.githubusercontent.com/u/4663648?v=3","gravatar_id":"","url":"https://api.github.com/users/aardappel","html_url":"https://github.com/aardappel","followers_url":"https://api.github.com/users/aardappel/followers","following_url":"https://api.github.com/users/aardappel/following{/other_user}","gists_url":"https://api.github.com/users/aardappel/gists{/gist_id}","starred_url":"https://api.github.com/users/aardappel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aardappel/subscriptions","organizations_url":"https://api.github.com/users/aardappel/orgs","repos_url":"https://api.github.com/users/aardappel/repos","events_url":"https://api.github.com/users/aardappel/events{/privacy}","received_events_url":"https://api.github.com/users/aardappel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aardappel/treesheets","description":"TreeSheets : Free Form Data Organizer (see treesheets.com)","fork":false,"url":"https://api.github.com/repos/aardappel/treesheets","forks_url":"https://api.github.com/repos/aardappel/treesheets/forks","keys_url":"https://api.github.com/repos/aardappel/treesheets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aardappel/treesheets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aardappel/treesheets/teams","hooks_url":"https://api.github.com/repos/aardappel/treesheets/hooks","issue_events_url":"https://api.github.com/repos/aardappel/treesheets/issues/events{/number}","events_url":"https://api.github.com/repos/aardappel/treesheets/events","assignees_url":"https://api.github.com/repos/aardappel/treesheets/assignees{/user}","branches_url":"https://api.github.com/repos/aardappel/treesheets/branches{/branch}","tags_url":"https://api.github.com/repos/aardappel/treesheets/tags","blobs_url":"https://api.github.com/repos/aardappel/treesheets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aardappel/treesheets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aardappel/treesheets/git/refs{/sha}","trees_url":"https://api.github.com/repos/aardappel/treesheets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aardappel/treesheets/statuses/{sha}","languages_url":"https://api.github.com/repos/aardappel/treesheets/languages","stargazers_url":"https://api.github.com/repos/aardappel/treesheets/stargazers","contributors_url":"https://api.github.com/repos/aardappel/treesheets/contributors","subscribers_url":"https://api.github.com/repos/aardappel/treesheets/subscribers","subscription_url":"https://api.github.com/repos/aardappel/treesheets/subscription","commits_url":"https://api.github.com/repos/aardappel/treesheets/commits{/sha}","git_commits_url":"https://api.github.com/repos/aardappel/treesheets/git/commits{/sha}","comments_url":"https://api.github.com/repos/aardappel/treesheets/comments{/number}","issue_comment_url":"https://api.github.com/repos/aardappel/treesheets/issues/comments{/number}","contents_url":"https://api.github.com/repos/aardappel/treesheets/contents/{+path}","compare_url":"https://api.github.com/repos/aardappel/treesheets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aardappel/treesheets/merges","archive_url":"https://api.github.com/repos/aardappel/treesheets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aardappel/treesheets/downloads","issues_url":"https://api.github.com/repos/aardappel/treesheets/issues{/number}","pulls_url":"https://api.github.com/repos/aardappel/treesheets/pulls{/number}","milestones_url":"https://api.github.com/repos/aardappel/treesheets/milestones{/number}","notifications_url":"https://api.github.com/repos/aardappel/treesheets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aardappel/treesheets/labels{/name}","releases_url":"https://api.github.com/repos/aardappel/treesheets/releases{/id}","created_at":"2013-06-13T17:30:30Z","updated_at":"2015-03-16T10:46:22Z","pushed_at":"2015-03-13T01:39:55Z","git_url":"git://github.com/aardappel/treesheets.git","ssh_url":"git@github.com:aardappel/treesheets.git","clone_url":"https://github.com/aardappel/treesheets.git","svn_url":"https://github.com/aardappel/treesheets","homepage":null,"size":2732,"stargazers_count":179,"watchers_count":179,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":7,"forks":31,"open_issues":7,"watchers":179,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aardappel/treesheets/pulls/29"},"html":{"href":"https://github.com/aardappel/treesheets/pull/29"},"issue":{"href":"https://api.github.com/repos/aardappel/treesheets/issues/29"},"comments":{"href":"https://api.github.com/repos/aardappel/treesheets/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/aardappel/treesheets/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/aardappel/treesheets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aardappel/treesheets/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/aardappel/treesheets/statuses/488dfbfdbfd7f8e0ed469edea7ff0c95d58933d5"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":25,"deletions":9,"changed_files":3}}