{"action":"created","comment":{"url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments/44244927","id":44244927,"diff_hunk":"@@ -127,8 +148,15 @@\n \n     wtu.setupUnitQuad(gl);\n \n+    var testProgram = wtu.setupProgram(gl, ['vshader', 'fbadshader']);\n+    if (!testProgram) {\n+        testPassed(\"To define the same uniform in two uniform blocks should fail\");\n+    }\n+\n     var program = wtu.setupProgram(gl, ['vshader', 'fshader']);\n-    wtu.glErrorShouldBe(gl, gl.NO_ERROR, \"should be able to compile shader with uniform blocks without error\");","path":"sdk/tests/conformance2/buffers/uniform-buffers.html","position":38,"original_position":38,"commit_id":"53b175d36f047ca6a0a68596d1b4698c62d191c8","original_commit_id":"53b175d36f047ca6a0a68596d1b4698c62d191c8","user":{"login":"Richard-Yunchao","id":11435653,"avatar_url":"https://avatars.githubusercontent.com/u/11435653?v=3","gravatar_id":"","url":"https://api.github.com/users/Richard-Yunchao","html_url":"https://github.com/Richard-Yunchao","followers_url":"https://api.github.com/users/Richard-Yunchao/followers","following_url":"https://api.github.com/users/Richard-Yunchao/following{/other_user}","gists_url":"https://api.github.com/users/Richard-Yunchao/gists{/gist_id}","starred_url":"https://api.github.com/users/Richard-Yunchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Richard-Yunchao/subscriptions","organizations_url":"https://api.github.com/users/Richard-Yunchao/orgs","repos_url":"https://api.github.com/users/Richard-Yunchao/repos","events_url":"https://api.github.com/users/Richard-Yunchao/events{/privacy}","received_events_url":"https://api.github.com/users/Richard-Yunchao/received_events","type":"User","site_admin":false},"body":"I added the new uniform blocks in fbadshader, used glErrorShouldBe( ) to test the compile/link status, found it succeed to compile in Chromium. It was a bug, I thought. However, I found that the JS code was wrong: if shaders fail to compile or link, it will not generate glError. As a result, using wtu.glErrorShouldBe( ) to detect setupProgram( ) is not appropriate.\r\n\r\nIn fact, setupProgram will detect the COMPILE_STATUS and LINK_STATUS and return NULL if the shaders are failed to compile/link.","created_at":"2015-11-09T06:42:37Z","updated_at":"2015-11-09T06:42:37Z","html_url":"https://github.com/KhronosGroup/WebGL/pull/1297#discussion_r44244927","pull_request_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1297","_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments/44244927"},"html":{"href":"https://github.com/KhronosGroup/WebGL/pull/1297#discussion_r44244927"},"pull_request":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1297"}}},"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1297","id":50089325,"html_url":"https://github.com/KhronosGroup/WebGL/pull/1297","diff_url":"https://github.com/KhronosGroup/WebGL/pull/1297.diff","patch_url":"https://github.com/KhronosGroup/WebGL/pull/1297.patch","issue_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/1297","number":1297,"state":"open","locked":false,"title":"To define the same uniform in two uniform blocks should fail","user":{"login":"Richard-Yunchao","id":11435653,"avatar_url":"https://avatars.githubusercontent.com/u/11435653?v=3","gravatar_id":"","url":"https://api.github.com/users/Richard-Yunchao","html_url":"https://github.com/Richard-Yunchao","followers_url":"https://api.github.com/users/Richard-Yunchao/followers","following_url":"https://api.github.com/users/Richard-Yunchao/following{/other_user}","gists_url":"https://api.github.com/users/Richard-Yunchao/gists{/gist_id}","starred_url":"https://api.github.com/users/Richard-Yunchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Richard-Yunchao/subscriptions","organizations_url":"https://api.github.com/users/Richard-Yunchao/orgs","repos_url":"https://api.github.com/users/Richard-Yunchao/repos","events_url":"https://api.github.com/users/Richard-Yunchao/events{/privacy}","received_events_url":"https://api.github.com/users/Richard-Yunchao/received_events","type":"User","site_admin":false},"body":"PTAL. ","created_at":"2015-11-09T06:36:58Z","updated_at":"2015-11-09T06:42:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3719bf7a64e24ed1e09026378e97539b29318e79","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1297/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1297/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/1297/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/53b175d36f047ca6a0a68596d1b4698c62d191c8","head":{"label":"Richard-Yunchao:bad-uniform-blocks","ref":"bad-uniform-blocks","sha":"53b175d36f047ca6a0a68596d1b4698c62d191c8","user":{"login":"Richard-Yunchao","id":11435653,"avatar_url":"https://avatars.githubusercontent.com/u/11435653?v=3","gravatar_id":"","url":"https://api.github.com/users/Richard-Yunchao","html_url":"https://github.com/Richard-Yunchao","followers_url":"https://api.github.com/users/Richard-Yunchao/followers","following_url":"https://api.github.com/users/Richard-Yunchao/following{/other_user}","gists_url":"https://api.github.com/users/Richard-Yunchao/gists{/gist_id}","starred_url":"https://api.github.com/users/Richard-Yunchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Richard-Yunchao/subscriptions","organizations_url":"https://api.github.com/users/Richard-Yunchao/orgs","repos_url":"https://api.github.com/users/Richard-Yunchao/repos","events_url":"https://api.github.com/users/Richard-Yunchao/events{/privacy}","received_events_url":"https://api.github.com/users/Richard-Yunchao/received_events","type":"User","site_admin":false},"repo":{"id":32059852,"name":"WebGL","full_name":"Richard-Yunchao/WebGL","owner":{"login":"Richard-Yunchao","id":11435653,"avatar_url":"https://avatars.githubusercontent.com/u/11435653?v=3","gravatar_id":"","url":"https://api.github.com/users/Richard-Yunchao","html_url":"https://github.com/Richard-Yunchao","followers_url":"https://api.github.com/users/Richard-Yunchao/followers","following_url":"https://api.github.com/users/Richard-Yunchao/following{/other_user}","gists_url":"https://api.github.com/users/Richard-Yunchao/gists{/gist_id}","starred_url":"https://api.github.com/users/Richard-Yunchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Richard-Yunchao/subscriptions","organizations_url":"https://api.github.com/users/Richard-Yunchao/orgs","repos_url":"https://api.github.com/users/Richard-Yunchao/repos","events_url":"https://api.github.com/users/Richard-Yunchao/events{/privacy}","received_events_url":"https://api.github.com/users/Richard-Yunchao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Richard-Yunchao/WebGL","description":"The Official Khronos WebGL Repository","fork":true,"url":"https://api.github.com/repos/Richard-Yunchao/WebGL","forks_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/forks","keys_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/teams","hooks_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/hooks","issue_events_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/issues/events{/number}","events_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/events","assignees_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/assignees{/user}","branches_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/branches{/branch}","tags_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/tags","blobs_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/git/refs{/sha}","trees_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/statuses/{sha}","languages_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/languages","stargazers_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/stargazers","contributors_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/contributors","subscribers_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/subscribers","subscription_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/subscription","commits_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/commits{/sha}","git_commits_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/git/commits{/sha}","comments_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/comments{/number}","issue_comment_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/issues/comments{/number}","contents_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/contents/{+path}","compare_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/merges","archive_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/downloads","issues_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/issues{/number}","pulls_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/pulls{/number}","milestones_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/milestones{/number}","notifications_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/labels{/name}","releases_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/releases{/id}","created_at":"2015-03-12T05:57:15Z","updated_at":"2015-03-16T06:06:31Z","pushed_at":"2015-11-09T06:41:47Z","git_url":"git://github.com/Richard-Yunchao/WebGL.git","ssh_url":"git@github.com:Richard-Yunchao/WebGL.git","clone_url":"https://github.com/Richard-Yunchao/WebGL.git","svn_url":"https://github.com/Richard-Yunchao/WebGL","homepage":null,"size":20287,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"ffdb6d6384b76d6dc6205c4c10fdbcc5eedc3227","user":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":5207280,"name":"WebGL","full_name":"KhronosGroup/WebGL","owner":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/WebGL","description":"The Official Khronos WebGL Repository","fork":false,"url":"https://api.github.com/repos/KhronosGroup/WebGL","forks_url":"https://api.github.com/repos/KhronosGroup/WebGL/forks","keys_url":"https://api.github.com/repos/KhronosGroup/WebGL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/WebGL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/WebGL/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/WebGL/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/WebGL/events","assignees_url":"https://api.github.com/repos/KhronosGroup/WebGL/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/WebGL/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/WebGL/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/WebGL/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/WebGL/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/WebGL/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/WebGL/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/WebGL/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/WebGL/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/WebGL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/WebGL/merges","archive_url":"https://api.github.com/repos/KhronosGroup/WebGL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/WebGL/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/WebGL/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/WebGL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/WebGL/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/WebGL/releases{/id}","created_at":"2012-07-27T17:21:51Z","updated_at":"2015-11-07T04:52:28Z","pushed_at":"2015-11-09T06:41:48Z","git_url":"git://github.com/KhronosGroup/WebGL.git","ssh_url":"git@github.com:KhronosGroup/WebGL.git","clone_url":"https://github.com/KhronosGroup/WebGL.git","svn_url":"https://github.com/KhronosGroup/WebGL","homepage":null,"size":33653,"stargazers_count":450,"watchers_count":450,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":250,"mirror_url":null,"open_issues_count":42,"forks":250,"open_issues":42,"watchers":450,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1297"},"html":{"href":"https://github.com/KhronosGroup/WebGL/pull/1297"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/issues/1297"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/issues/1297/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1297/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1297/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/53b175d36f047ca6a0a68596d1b4698c62d191c8"}}}}