{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/pulls/comments/26168074","id":26168074,"diff_hunk":"@@ -50,11 +50,10 @@ Planned features:\n     (divide [this x y] (/ x y)))\n \n ;; A proxied implementation of MathService for use via RPC\n-(defservice remote-math-service\n+(def-remote-service remote-math-service","path":"README.md","position":14,"original_position":14,"commit_id":"0351c536c31c2dd7a32255afb4284835dac92f20","original_commit_id":"7f2022375340aaff250c62e83fc6c56bf383c792","user":{"login":"nathanielksmith","id":98482,"avatar_url":"https://avatars.githubusercontent.com/u/98482?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanielksmith","html_url":"https://github.com/nathanielksmith","followers_url":"https://api.github.com/users/nathanielksmith/followers","following_url":"https://api.github.com/users/nathanielksmith/following{/other_user}","gists_url":"https://api.github.com/users/nathanielksmith/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanielksmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanielksmith/subscriptions","organizations_url":"https://api.github.com/users/nathanielksmith/orgs","repos_url":"https://api.github.com/users/nathanielksmith/repos","events_url":"https://api.github.com/users/nathanielksmith/events{/privacy}","received_events_url":"https://api.github.com/users/nathanielksmith/received_events","type":"User","site_admin":false},"body":"yeah -- it's weird and unusual but `defremoteservice` also felt weird/wrong? which do you think is less wrong?","created_at":"2015-03-10T21:27:54Z","updated_at":"2015-03-10T21:27:54Z","html_url":"https://github.com/puppetlabs/trapperkeeper-rpc/pull/16#discussion_r26168074","pull_request_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/pulls/comments/26168074"},"html":{"href":"https://github.com/puppetlabs/trapperkeeper-rpc/pull/16#discussion_r26168074"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/pulls/16","id":30815027,"html_url":"https://github.com/puppetlabs/trapperkeeper-rpc/pull/16","diff_url":"https://github.com/puppetlabs/trapperkeeper-rpc/pull/16.diff","patch_url":"https://github.com/puppetlabs/trapperkeeper-rpc/pull/16.patch","issue_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/issues/16","number":16,"state":"open","locked":false,"title":"Expose macros for creating RPC'd services and re-use HTTP clients","user":{"login":"nathanielksmith","id":98482,"avatar_url":"https://avatars.githubusercontent.com/u/98482?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanielksmith","html_url":"https://github.com/nathanielksmith","followers_url":"https://api.github.com/users/nathanielksmith/followers","following_url":"https://api.github.com/users/nathanielksmith/following{/other_user}","gists_url":"https://api.github.com/users/nathanielksmith/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanielksmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanielksmith/subscriptions","organizations_url":"https://api.github.com/users/nathanielksmith/orgs","repos_url":"https://api.github.com/users/nathanielksmith/repos","events_url":"https://api.github.com/users/nathanielksmith/events{/privacy}","received_events_url":"https://api.github.com/users/nathanielksmith/received_events","type":"User","site_admin":false},"body":"This commit adds helpful macros for automatically creating RPC'd TK services.\r\n\r\nthe underlying call-remote-svc-fn is still available / exposed for more complex\r\nservices but these macros should be the standard for making RPC'd services.\r\n\r\nAdditionally, a memoized function now wraps http.client.sync/create-client\r\nbased on rpc settings and svc id, meaning that http clients are reused per\r\nservice.","created_at":"2015-03-10T01:09:33Z","updated_at":"2015-03-10T21:27:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2260b2d26b8580b92a1f18676d9b76cbc74699af","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/pulls/16/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/pulls/16/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/issues/16/comments","statuses_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/statuses/0351c536c31c2dd7a32255afb4284835dac92f20","head":{"label":"puppetlabs:macro-ui","ref":"macro-ui","sha":"0351c536c31c2dd7a32255afb4284835dac92f20","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":27504088,"name":"trapperkeeper-rpc","full_name":"puppetlabs/trapperkeeper-rpc","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/trapperkeeper-rpc","description":"RPC service and implementation library for TrapperKeeper services.","fork":false,"url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc","forks_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/forks","keys_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/teams","hooks_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/events","assignees_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/tags","blobs_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/subscription","commits_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/merges","archive_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/downloads","issues_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/releases{/id}","created_at":"2014-12-03T19:36:03Z","updated_at":"2015-01-21T01:12:30Z","pushed_at":"2015-03-10T21:27:10Z","git_url":"git://github.com/puppetlabs/trapperkeeper-rpc.git","ssh_url":"git@github.com:puppetlabs/trapperkeeper-rpc.git","clone_url":"https://github.com/puppetlabs/trapperkeeper-rpc.git","svn_url":"https://github.com/puppetlabs/trapperkeeper-rpc","homepage":null,"size":363,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":13,"forks":2,"open_issues":13,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"a43a0232ede13bb066f9634822006aaa7bd71c32","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":27504088,"name":"trapperkeeper-rpc","full_name":"puppetlabs/trapperkeeper-rpc","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/trapperkeeper-rpc","description":"RPC service and implementation library for TrapperKeeper services.","fork":false,"url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc","forks_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/forks","keys_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/teams","hooks_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/events","assignees_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/tags","blobs_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/subscription","commits_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/merges","archive_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/downloads","issues_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/releases{/id}","created_at":"2014-12-03T19:36:03Z","updated_at":"2015-01-21T01:12:30Z","pushed_at":"2015-03-10T21:27:10Z","git_url":"git://github.com/puppetlabs/trapperkeeper-rpc.git","ssh_url":"git@github.com:puppetlabs/trapperkeeper-rpc.git","clone_url":"https://github.com/puppetlabs/trapperkeeper-rpc.git","svn_url":"https://github.com/puppetlabs/trapperkeeper-rpc","homepage":null,"size":363,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":13,"forks":2,"open_issues":13,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/pulls/16"},"html":{"href":"https://github.com/puppetlabs/trapperkeeper-rpc/pull/16"},"issue":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/issues/16"},"comments":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-rpc/statuses/0351c536c31c2dd7a32255afb4284835dac92f20"}}}}