{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/olympia/pulls/comments/41191759","id":41191759,"diff_hunk":"@@ -0,0 +1,42 @@\n+{% extends \"devhub/base.html\" %}","path":"apps/devhub/templates/devhub/api/agreement.html","position":1,"original_position":1,"commit_id":"7d680e8a384cab0188d20ba8d8b134423a90ddde","original_commit_id":"7d680e8a384cab0188d20ba8d8b134423a90ddde","user":{"login":"Nolski","id":2600677,"avatar_url":"https://avatars.githubusercontent.com/u/2600677?v=3","gravatar_id":"","url":"https://api.github.com/users/Nolski","html_url":"https://github.com/Nolski","followers_url":"https://api.github.com/users/Nolski/followers","following_url":"https://api.github.com/users/Nolski/following{/other_user}","gists_url":"https://api.github.com/users/Nolski/gists{/gist_id}","starred_url":"https://api.github.com/users/Nolski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nolski/subscriptions","organizations_url":"https://api.github.com/users/Nolski/orgs","repos_url":"https://api.github.com/users/Nolski/repos","events_url":"https://api.github.com/users/Nolski/events{/privacy}","received_events_url":"https://api.github.com/users/Nolski/received_events","type":"User","site_admin":false},"body":"Ah right, so here is where I don't understand the UX of the current flow. Here is what happens in our hypothetical flow.\r\n\r\n1. User logs into AMO\r\n2. User clicks nav link to generate API key\r\n3. User is redirected to this page\r\n<img width=\"1243\" alt=\"screen shot 2015-10-05 at 4 02 56 pm\" src=\"https://cloud.githubusercontent.com/assets/2600677/10292281/5cec7428-6b7c-11e5-925b-02ee778993c7.png\">\r\n5. User accepts and is sent to actual API page\r\n\r\nNow the issue here is that the page shown has nothing to do with API keys. it has a side bar that has a whole bunch of steps, none of which mean anything to someone trying to reach the API page. I must have missed this back in my last commit but this is why I suggested having a separate page for accepting the license.","created_at":"2015-10-05T20:17:41Z","updated_at":"2015-10-05T20:17:41Z","html_url":"https://github.com/mozilla/olympia/pull/796#discussion_r41191759","pull_request_url":"https://api.github.com/repos/mozilla/olympia/pulls/796","_links":{"self":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/comments/41191759"},"html":{"href":"https://github.com/mozilla/olympia/pull/796#discussion_r41191759"},"pull_request":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/796"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/olympia/pulls/796","id":46588924,"html_url":"https://github.com/mozilla/olympia/pull/796","diff_url":"https://github.com/mozilla/olympia/pull/796.diff","patch_url":"https://github.com/mozilla/olympia/pull/796.patch","issue_url":"https://api.github.com/repos/mozilla/olympia/issues/796","number":796,"state":"open","locked":false,"title":"Added separate ToS page (bug 1209226)","user":{"login":"Nolski","id":2600677,"avatar_url":"https://avatars.githubusercontent.com/u/2600677?v=3","gravatar_id":"","url":"https://api.github.com/users/Nolski","html_url":"https://github.com/Nolski","followers_url":"https://api.github.com/users/Nolski/followers","following_url":"https://api.github.com/users/Nolski/following{/other_user}","gists_url":"https://api.github.com/users/Nolski/gists{/gist_id}","starred_url":"https://api.github.com/users/Nolski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nolski/subscriptions","organizations_url":"https://api.github.com/users/Nolski/orgs","repos_url":"https://api.github.com/users/Nolski/repos","events_url":"https://api.github.com/users/Nolski/events{/privacy}","received_events_url":"https://api.github.com/users/Nolski/received_events","type":"User","site_admin":false},"body":"Work in Progress:\r\n\r\nHaving issues with tests due to the fact that the user is populated somewhere in the unit tests which automatically causes the request to forward onto the next step (throwing assertion errors). Can't seem to figure out how to populate that request.user object.","created_at":"2015-10-01T23:21:20Z","updated_at":"2015-10-05T20:17:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41292a53dc963300c192ae24f352cf3d6beb3787","assignee":{"login":"kumar303","id":55398,"avatar_url":"https://avatars.githubusercontent.com/u/55398?v=3","gravatar_id":"","url":"https://api.github.com/users/kumar303","html_url":"https://github.com/kumar303","followers_url":"https://api.github.com/users/kumar303/followers","following_url":"https://api.github.com/users/kumar303/following{/other_user}","gists_url":"https://api.github.com/users/kumar303/gists{/gist_id}","starred_url":"https://api.github.com/users/kumar303/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumar303/subscriptions","organizations_url":"https://api.github.com/users/kumar303/orgs","repos_url":"https://api.github.com/users/kumar303/repos","events_url":"https://api.github.com/users/kumar303/events{/privacy}","received_events_url":"https://api.github.com/users/kumar303/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/olympia/pulls/796/commits","review_comments_url":"https://api.github.com/repos/mozilla/olympia/pulls/796/comments","review_comment_url":"https://api.github.com/repos/mozilla/olympia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/olympia/issues/796/comments","statuses_url":"https://api.github.com/repos/mozilla/olympia/statuses/7d680e8a384cab0188d20ba8d8b134423a90ddde","head":{"label":"Nolski:signing-api-agreement","ref":"signing-api-agreement","sha":"7d680e8a384cab0188d20ba8d8b134423a90ddde","user":{"login":"Nolski","id":2600677,"avatar_url":"https://avatars.githubusercontent.com/u/2600677?v=3","gravatar_id":"","url":"https://api.github.com/users/Nolski","html_url":"https://github.com/Nolski","followers_url":"https://api.github.com/users/Nolski/followers","following_url":"https://api.github.com/users/Nolski/following{/other_user}","gists_url":"https://api.github.com/users/Nolski/gists{/gist_id}","starred_url":"https://api.github.com/users/Nolski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nolski/subscriptions","organizations_url":"https://api.github.com/users/Nolski/orgs","repos_url":"https://api.github.com/users/Nolski/repos","events_url":"https://api.github.com/users/Nolski/events{/privacy}","received_events_url":"https://api.github.com/users/Nolski/received_events","type":"User","site_admin":false},"repo":{"id":41709418,"name":"olympia","full_name":"Nolski/olympia","owner":{"login":"Nolski","id":2600677,"avatar_url":"https://avatars.githubusercontent.com/u/2600677?v=3","gravatar_id":"","url":"https://api.github.com/users/Nolski","html_url":"https://github.com/Nolski","followers_url":"https://api.github.com/users/Nolski/followers","following_url":"https://api.github.com/users/Nolski/following{/other_user}","gists_url":"https://api.github.com/users/Nolski/gists{/gist_id}","starred_url":"https://api.github.com/users/Nolski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nolski/subscriptions","organizations_url":"https://api.github.com/users/Nolski/orgs","repos_url":"https://api.github.com/users/Nolski/repos","events_url":"https://api.github.com/users/Nolski/events{/privacy}","received_events_url":"https://api.github.com/users/Nolski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Nolski/olympia","description":"addons.mozilla.org, reloaded.","fork":true,"url":"https://api.github.com/repos/Nolski/olympia","forks_url":"https://api.github.com/repos/Nolski/olympia/forks","keys_url":"https://api.github.com/repos/Nolski/olympia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nolski/olympia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nolski/olympia/teams","hooks_url":"https://api.github.com/repos/Nolski/olympia/hooks","issue_events_url":"https://api.github.com/repos/Nolski/olympia/issues/events{/number}","events_url":"https://api.github.com/repos/Nolski/olympia/events","assignees_url":"https://api.github.com/repos/Nolski/olympia/assignees{/user}","branches_url":"https://api.github.com/repos/Nolski/olympia/branches{/branch}","tags_url":"https://api.github.com/repos/Nolski/olympia/tags","blobs_url":"https://api.github.com/repos/Nolski/olympia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nolski/olympia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nolski/olympia/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nolski/olympia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nolski/olympia/statuses/{sha}","languages_url":"https://api.github.com/repos/Nolski/olympia/languages","stargazers_url":"https://api.github.com/repos/Nolski/olympia/stargazers","contributors_url":"https://api.github.com/repos/Nolski/olympia/contributors","subscribers_url":"https://api.github.com/repos/Nolski/olympia/subscribers","subscription_url":"https://api.github.com/repos/Nolski/olympia/subscription","commits_url":"https://api.github.com/repos/Nolski/olympia/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nolski/olympia/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nolski/olympia/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nolski/olympia/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nolski/olympia/contents/{+path}","compare_url":"https://api.github.com/repos/Nolski/olympia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nolski/olympia/merges","archive_url":"https://api.github.com/repos/Nolski/olympia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nolski/olympia/downloads","issues_url":"https://api.github.com/repos/Nolski/olympia/issues{/number}","pulls_url":"https://api.github.com/repos/Nolski/olympia/pulls{/number}","milestones_url":"https://api.github.com/repos/Nolski/olympia/milestones{/number}","notifications_url":"https://api.github.com/repos/Nolski/olympia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nolski/olympia/labels{/name}","releases_url":"https://api.github.com/repos/Nolski/olympia/releases{/id}","created_at":"2015-09-01T01:17:38Z","updated_at":"2015-09-01T01:17:44Z","pushed_at":"2015-10-05T14:06:12Z","git_url":"git://github.com/Nolski/olympia.git","ssh_url":"git@github.com:Nolski/olympia.git","clone_url":"https://github.com/Nolski/olympia.git","svn_url":"https://github.com/Nolski/olympia","homepage":"https://addons.mozilla.org/","size":424664,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"1d02e0179f6ad02aa5f7e200f3ebc9e95c1a8e35","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":16416867,"name":"olympia","full_name":"mozilla/olympia","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/olympia","description":"addons.mozilla.org, reloaded.","fork":false,"url":"https://api.github.com/repos/mozilla/olympia","forks_url":"https://api.github.com/repos/mozilla/olympia/forks","keys_url":"https://api.github.com/repos/mozilla/olympia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/olympia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/olympia/teams","hooks_url":"https://api.github.com/repos/mozilla/olympia/hooks","issue_events_url":"https://api.github.com/repos/mozilla/olympia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/olympia/events","assignees_url":"https://api.github.com/repos/mozilla/olympia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/olympia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/olympia/tags","blobs_url":"https://api.github.com/repos/mozilla/olympia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/olympia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/olympia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/olympia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/olympia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/olympia/languages","stargazers_url":"https://api.github.com/repos/mozilla/olympia/stargazers","contributors_url":"https://api.github.com/repos/mozilla/olympia/contributors","subscribers_url":"https://api.github.com/repos/mozilla/olympia/subscribers","subscription_url":"https://api.github.com/repos/mozilla/olympia/subscription","commits_url":"https://api.github.com/repos/mozilla/olympia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/olympia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/olympia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/olympia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/olympia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/olympia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/olympia/merges","archive_url":"https://api.github.com/repos/mozilla/olympia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/olympia/downloads","issues_url":"https://api.github.com/repos/mozilla/olympia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/olympia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/olympia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/olympia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/olympia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/olympia/releases{/id}","created_at":"2014-01-31T18:44:15Z","updated_at":"2015-10-01T10:27:07Z","pushed_at":"2015-10-05T17:15:20Z","git_url":"git://github.com/mozilla/olympia.git","ssh_url":"git@github.com:mozilla/olympia.git","clone_url":"https://github.com/mozilla/olympia.git","svn_url":"https://github.com/mozilla/olympia","homepage":"https://addons.mozilla.org/","size":477793,"stargazers_count":55,"watchers_count":55,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":112,"mirror_url":null,"open_issues_count":16,"forks":112,"open_issues":16,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/796"},"html":{"href":"https://github.com/mozilla/olympia/pull/796"},"issue":{"href":"https://api.github.com/repos/mozilla/olympia/issues/796"},"comments":{"href":"https://api.github.com/repos/mozilla/olympia/issues/796/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/796/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/796/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/olympia/statuses/7d680e8a384cab0188d20ba8d8b134423a90ddde"}}}}