{"action":"created","comment":{"url":"https://api.github.com/repos/sharetribe/sharetribe/pulls/comments/30050104","id":30050104,"diff_hunk":"@@ -145,8 +145,8 @@ class Community < ActiveRecord::Base\n   VALID_BROWSE_TYPES = %{grid map list}\n   validates_inclusion_of :default_browse_view, :in => VALID_BROWSE_TYPES\n \n-  VALID_NAME_DISPLAY_TYPES = %{first_name_only first_name_with_initial}\n-  validates_inclusion_of :default_browse_view, :in => VALID_BROWSE_TYPES, :allow_nil => true, :allow_blank => true\n+  VALID_NAME_DISPLAY_TYPES = %{first_name_only first_name_with_initial full_name}\n+  validates_inclusion_of :name_display_type, :in => VALID_NAME_DISPLAY_TYPES","path":"app/models/community.rb","position":7,"original_position":7,"commit_id":"de84dd8495bdfd7467aa2bf7a72ac247d2f186dc","original_commit_id":"de84dd8495bdfd7467aa2bf7a72ac247d2f186dc","user":{"login":"Gnito","id":717315,"avatar_url":"https://avatars.githubusercontent.com/u/717315?v=3","gravatar_id":"","url":"https://api.github.com/users/Gnito","html_url":"https://github.com/Gnito","followers_url":"https://api.github.com/users/Gnito/followers","following_url":"https://api.github.com/users/Gnito/following{/other_user}","gists_url":"https://api.github.com/users/Gnito/gists{/gist_id}","starred_url":"https://api.github.com/users/Gnito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gnito/subscriptions","organizations_url":"https://api.github.com/users/Gnito/orgs","repos_url":"https://api.github.com/users/Gnito/repos","events_url":"https://api.github.com/users/Gnito/events{/privacy}","received_events_url":"https://api.github.com/users/Gnito/received_events","type":"User","site_admin":false},"body":":default_browse_view has validations just above these lines. \r\n(So this is just old copy-paste error, which has not worked correctly ever)\r\nAs discussed irl, I started to check if this has real-life effects since there was before allow_nil etc. extra rules ...deciced not to spend time with that since we should never allow nil or blank for this parameter.\r\n\r\nThis is related to\r\nhttp://localhost:3000/en/admin/communities/1/edit_look_and_feel#community_default_browse_view\r\nWhere there are just 3 options allowed (and unlike previous name-type selection functionality, there is no blank as default value for any of those three options. And after this bugfix, blank option is removed from name-type select too.) ","created_at":"2015-05-11T15:39:24Z","updated_at":"2015-05-11T15:39:24Z","html_url":"https://github.com/sharetribe/sharetribe/pull/1199#discussion_r30050104","pull_request_url":"https://api.github.com/repos/sharetribe/sharetribe/pulls/1199","_links":{"self":{"href":"https://api.github.com/repos/sharetribe/sharetribe/pulls/comments/30050104"},"html":{"href":"https://github.com/sharetribe/sharetribe/pull/1199#discussion_r30050104"},"pull_request":{"href":"https://api.github.com/repos/sharetribe/sharetribe/pulls/1199"}}},"pull_request":{"url":"https://api.github.com/repos/sharetribe/sharetribe/pulls/1199","id":34833036,"html_url":"https://github.com/sharetribe/sharetribe/pull/1199","diff_url":"https://github.com/sharetribe/sharetribe/pull/1199.diff","patch_url":"https://github.com/sharetribe/sharetribe/pull/1199.patch","issue_url":"https://api.github.com/repos/sharetribe/sharetribe/issues/1199","number":1199,"state":"open","locked":false,"title":"handle empty name_display_type as fullname","user":{"login":"Gnito","id":717315,"avatar_url":"https://avatars.githubusercontent.com/u/717315?v=3","gravatar_id":"","url":"https://api.github.com/users/Gnito","html_url":"https://github.com/Gnito","followers_url":"https://api.github.com/users/Gnito/followers","following_url":"https://api.github.com/users/Gnito/following{/other_user}","gists_url":"https://api.github.com/users/Gnito/gists{/gist_id}","starred_url":"https://api.github.com/users/Gnito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gnito/subscriptions","organizations_url":"https://api.github.com/users/Gnito/orgs","repos_url":"https://api.github.com/users/Gnito/repos","events_url":"https://api.github.com/users/Gnito/events{/privacy}","received_events_url":"https://api.github.com/users/Gnito/received_events","type":"User","site_admin":false},"body":"Better solution might be to make db migration and change the behaviour in 5++ files. \r\nHowever, is this good enough?\r\n(This comment is related to first commit)","created_at":"2015-05-06T16:10:46Z","updated_at":"2015-05-11T15:39:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b51cf693aea3cd8f87450ad8ae7ddb196a83b47","assignee":{"login":"ovan","id":271845,"avatar_url":"https://avatars.githubusercontent.com/u/271845?v=3","gravatar_id":"","url":"https://api.github.com/users/ovan","html_url":"https://github.com/ovan","followers_url":"https://api.github.com/users/ovan/followers","following_url":"https://api.github.com/users/ovan/following{/other_user}","gists_url":"https://api.github.com/users/ovan/gists{/gist_id}","starred_url":"https://api.github.com/users/ovan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovan/subscriptions","organizations_url":"https://api.github.com/users/ovan/orgs","repos_url":"https://api.github.com/users/ovan/repos","events_url":"https://api.github.com/users/ovan/events{/privacy}","received_events_url":"https://api.github.com/users/ovan/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/sharetribe/sharetribe/pulls/1199/commits","review_comments_url":"https://api.github.com/repos/sharetribe/sharetribe/pulls/1199/comments","review_comment_url":"https://api.github.com/repos/sharetribe/sharetribe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sharetribe/sharetribe/issues/1199/comments","statuses_url":"https://api.github.com/repos/sharetribe/sharetribe/statuses/de84dd8495bdfd7467aa2bf7a72ac247d2f186dc","head":{"label":"sharetribe:bug-display-type-fullname","ref":"bug-display-type-fullname","sha":"de84dd8495bdfd7467aa2bf7a72ac247d2f186dc","user":{"login":"sharetribe","id":1733898,"avatar_url":"https://avatars.githubusercontent.com/u/1733898?v=3","gravatar_id":"","url":"https://api.github.com/users/sharetribe","html_url":"https://github.com/sharetribe","followers_url":"https://api.github.com/users/sharetribe/followers","following_url":"https://api.github.com/users/sharetribe/following{/other_user}","gists_url":"https://api.github.com/users/sharetribe/gists{/gist_id}","starred_url":"https://api.github.com/users/sharetribe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharetribe/subscriptions","organizations_url":"https://api.github.com/users/sharetribe/orgs","repos_url":"https://api.github.com/users/sharetribe/repos","events_url":"https://api.github.com/users/sharetribe/events{/privacy}","received_events_url":"https://api.github.com/users/sharetribe/received_events","type":"Organization","site_admin":false},"repo":{"id":4447023,"name":"sharetribe","full_name":"sharetribe/sharetribe","owner":{"login":"sharetribe","id":1733898,"avatar_url":"https://avatars.githubusercontent.com/u/1733898?v=3","gravatar_id":"","url":"https://api.github.com/users/sharetribe","html_url":"https://github.com/sharetribe","followers_url":"https://api.github.com/users/sharetribe/followers","following_url":"https://api.github.com/users/sharetribe/following{/other_user}","gists_url":"https://api.github.com/users/sharetribe/gists{/gist_id}","starred_url":"https://api.github.com/users/sharetribe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharetribe/subscriptions","organizations_url":"https://api.github.com/users/sharetribe/orgs","repos_url":"https://api.github.com/users/sharetribe/repos","events_url":"https://api.github.com/users/sharetribe/events{/privacy}","received_events_url":"https://api.github.com/users/sharetribe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sharetribe/sharetribe","description":"Open source marketplace platform","fork":false,"url":"https://api.github.com/repos/sharetribe/sharetribe","forks_url":"https://api.github.com/repos/sharetribe/sharetribe/forks","keys_url":"https://api.github.com/repos/sharetribe/sharetribe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sharetribe/sharetribe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sharetribe/sharetribe/teams","hooks_url":"https://api.github.com/repos/sharetribe/sharetribe/hooks","issue_events_url":"https://api.github.com/repos/sharetribe/sharetribe/issues/events{/number}","events_url":"https://api.github.com/repos/sharetribe/sharetribe/events","assignees_url":"https://api.github.com/repos/sharetribe/sharetribe/assignees{/user}","branches_url":"https://api.github.com/repos/sharetribe/sharetribe/branches{/branch}","tags_url":"https://api.github.com/repos/sharetribe/sharetribe/tags","blobs_url":"https://api.github.com/repos/sharetribe/sharetribe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sharetribe/sharetribe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sharetribe/sharetribe/git/refs{/sha}","trees_url":"https://api.github.com/repos/sharetribe/sharetribe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sharetribe/sharetribe/statuses/{sha}","languages_url":"https://api.github.com/repos/sharetribe/sharetribe/languages","stargazers_url":"https://api.github.com/repos/sharetribe/sharetribe/stargazers","contributors_url":"https://api.github.com/repos/sharetribe/sharetribe/contributors","subscribers_url":"https://api.github.com/repos/sharetribe/sharetribe/subscribers","subscription_url":"https://api.github.com/repos/sharetribe/sharetribe/subscription","commits_url":"https://api.github.com/repos/sharetribe/sharetribe/commits{/sha}","git_commits_url":"https://api.github.com/repos/sharetribe/sharetribe/git/commits{/sha}","comments_url":"https://api.github.com/repos/sharetribe/sharetribe/comments{/number}","issue_comment_url":"https://api.github.com/repos/sharetribe/sharetribe/issues/comments{/number}","contents_url":"https://api.github.com/repos/sharetribe/sharetribe/contents/{+path}","compare_url":"https://api.github.com/repos/sharetribe/sharetribe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sharetribe/sharetribe/merges","archive_url":"https://api.github.com/repos/sharetribe/sharetribe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sharetribe/sharetribe/downloads","issues_url":"https://api.github.com/repos/sharetribe/sharetribe/issues{/number}","pulls_url":"https://api.github.com/repos/sharetribe/sharetribe/pulls{/number}","milestones_url":"https://api.github.com/repos/sharetribe/sharetribe/milestones{/number}","notifications_url":"https://api.github.com/repos/sharetribe/sharetribe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sharetribe/sharetribe/labels{/name}","releases_url":"https://api.github.com/repos/sharetribe/sharetribe/releases{/id}","created_at":"2012-05-25T15:34:17Z","updated_at":"2015-05-11T11:34:38Z","pushed_at":"2015-05-11T14:43:43Z","git_url":"git://github.com/sharetribe/sharetribe.git","ssh_url":"git@github.com:sharetribe/sharetribe.git","clone_url":"https://github.com/sharetribe/sharetribe.git","svn_url":"https://github.com/sharetribe/sharetribe","homepage":"https://www.sharetribe.com","size":116692,"stargazers_count":297,"watchers_count":297,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":203,"mirror_url":null,"open_issues_count":16,"forks":203,"open_issues":16,"watchers":297,"default_branch":"master"}},"base":{"label":"sharetribe:master","ref":"master","sha":"88da82a6378e81d4ca6d64bf762df315cf25e716","user":{"login":"sharetribe","id":1733898,"avatar_url":"https://avatars.githubusercontent.com/u/1733898?v=3","gravatar_id":"","url":"https://api.github.com/users/sharetribe","html_url":"https://github.com/sharetribe","followers_url":"https://api.github.com/users/sharetribe/followers","following_url":"https://api.github.com/users/sharetribe/following{/other_user}","gists_url":"https://api.github.com/users/sharetribe/gists{/gist_id}","starred_url":"https://api.github.com/users/sharetribe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharetribe/subscriptions","organizations_url":"https://api.github.com/users/sharetribe/orgs","repos_url":"https://api.github.com/users/sharetribe/repos","events_url":"https://api.github.com/users/sharetribe/events{/privacy}","received_events_url":"https://api.github.com/users/sharetribe/received_events","type":"Organization","site_admin":false},"repo":{"id":4447023,"name":"sharetribe","full_name":"sharetribe/sharetribe","owner":{"login":"sharetribe","id":1733898,"avatar_url":"https://avatars.githubusercontent.com/u/1733898?v=3","gravatar_id":"","url":"https://api.github.com/users/sharetribe","html_url":"https://github.com/sharetribe","followers_url":"https://api.github.com/users/sharetribe/followers","following_url":"https://api.github.com/users/sharetribe/following{/other_user}","gists_url":"https://api.github.com/users/sharetribe/gists{/gist_id}","starred_url":"https://api.github.com/users/sharetribe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharetribe/subscriptions","organizations_url":"https://api.github.com/users/sharetribe/orgs","repos_url":"https://api.github.com/users/sharetribe/repos","events_url":"https://api.github.com/users/sharetribe/events{/privacy}","received_events_url":"https://api.github.com/users/sharetribe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sharetribe/sharetribe","description":"Open source marketplace platform","fork":false,"url":"https://api.github.com/repos/sharetribe/sharetribe","forks_url":"https://api.github.com/repos/sharetribe/sharetribe/forks","keys_url":"https://api.github.com/repos/sharetribe/sharetribe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sharetribe/sharetribe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sharetribe/sharetribe/teams","hooks_url":"https://api.github.com/repos/sharetribe/sharetribe/hooks","issue_events_url":"https://api.github.com/repos/sharetribe/sharetribe/issues/events{/number}","events_url":"https://api.github.com/repos/sharetribe/sharetribe/events","assignees_url":"https://api.github.com/repos/sharetribe/sharetribe/assignees{/user}","branches_url":"https://api.github.com/repos/sharetribe/sharetribe/branches{/branch}","tags_url":"https://api.github.com/repos/sharetribe/sharetribe/tags","blobs_url":"https://api.github.com/repos/sharetribe/sharetribe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sharetribe/sharetribe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sharetribe/sharetribe/git/refs{/sha}","trees_url":"https://api.github.com/repos/sharetribe/sharetribe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sharetribe/sharetribe/statuses/{sha}","languages_url":"https://api.github.com/repos/sharetribe/sharetribe/languages","stargazers_url":"https://api.github.com/repos/sharetribe/sharetribe/stargazers","contributors_url":"https://api.github.com/repos/sharetribe/sharetribe/contributors","subscribers_url":"https://api.github.com/repos/sharetribe/sharetribe/subscribers","subscription_url":"https://api.github.com/repos/sharetribe/sharetribe/subscription","commits_url":"https://api.github.com/repos/sharetribe/sharetribe/commits{/sha}","git_commits_url":"https://api.github.com/repos/sharetribe/sharetribe/git/commits{/sha}","comments_url":"https://api.github.com/repos/sharetribe/sharetribe/comments{/number}","issue_comment_url":"https://api.github.com/repos/sharetribe/sharetribe/issues/comments{/number}","contents_url":"https://api.github.com/repos/sharetribe/sharetribe/contents/{+path}","compare_url":"https://api.github.com/repos/sharetribe/sharetribe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sharetribe/sharetribe/merges","archive_url":"https://api.github.com/repos/sharetribe/sharetribe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sharetribe/sharetribe/downloads","issues_url":"https://api.github.com/repos/sharetribe/sharetribe/issues{/number}","pulls_url":"https://api.github.com/repos/sharetribe/sharetribe/pulls{/number}","milestones_url":"https://api.github.com/repos/sharetribe/sharetribe/milestones{/number}","notifications_url":"https://api.github.com/repos/sharetribe/sharetribe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sharetribe/sharetribe/labels{/name}","releases_url":"https://api.github.com/repos/sharetribe/sharetribe/releases{/id}","created_at":"2012-05-25T15:34:17Z","updated_at":"2015-05-11T11:34:38Z","pushed_at":"2015-05-11T14:43:43Z","git_url":"git://github.com/sharetribe/sharetribe.git","ssh_url":"git@github.com:sharetribe/sharetribe.git","clone_url":"https://github.com/sharetribe/sharetribe.git","svn_url":"https://github.com/sharetribe/sharetribe","homepage":"https://www.sharetribe.com","size":116692,"stargazers_count":297,"watchers_count":297,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":203,"mirror_url":null,"open_issues_count":16,"forks":203,"open_issues":16,"watchers":297,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sharetribe/sharetribe/pulls/1199"},"html":{"href":"https://github.com/sharetribe/sharetribe/pull/1199"},"issue":{"href":"https://api.github.com/repos/sharetribe/sharetribe/issues/1199"},"comments":{"href":"https://api.github.com/repos/sharetribe/sharetribe/issues/1199/comments"},"review_comments":{"href":"https://api.github.com/repos/sharetribe/sharetribe/pulls/1199/comments"},"review_comment":{"href":"https://api.github.com/repos/sharetribe/sharetribe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sharetribe/sharetribe/pulls/1199/commits"},"statuses":{"href":"https://api.github.com/repos/sharetribe/sharetribe/statuses/de84dd8495bdfd7467aa2bf7a72ac247d2f186dc"}}}}