{"push_id":918889460,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"23469da8a05168f408e14b8decc9592b1f5e9117","before":"8093cbb5629740804b2814423ad3c5791b5ff523","commits":[{"sha":"23469da8a05168f408e14b8decc9592b1f5e9117","author":{"email":"10524d79fe764534ec8ef145209973705d3249d5@twitter.com","name":"Mike Kaplinskiy"},"message":"Fix maven resolver for certain packages.\n\nSummary:\nThe values specified in ArtifactDescriptorResult aren't sane in most ways. That is, they need evaluation & variable substitution.\n\nI'm not sure why this was here in the first place, so this patch may be wrong. That is, I think the CollectRequest correctly returns direct dependencies as part of the query. Perhaps I'm missing something, so please tell me if something breaks with this approach.\n\nI'd love to test this for buck itself, but I couldn't find a (direct) dependency list for it. Is there one somewhere?\n\nBefore:\n```shell\nException in thread \"main\" org.eclipse.aether.resolution.DependencyResolutionException: Could not find artifact\nio.netty:netty-tcnative:jar:${os.detected.classifier}:1.1.30.Fork2 in http://repo1.maven.org/maven2 (http://repo1.maven.org/maven2)\n\tat org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveDependencies(DefaultRepositorySystem.java:384)\n\tat com.facebook.buck.maven.Resolver.getRunTimeTransitiveDeps(Resolver.java:435)\n\tat com.facebook.buck.maven.Resolver.resolve(Resolver.java:121)\n\tat com.facebook.buck.maven.Resolver.main(Resolver.java:482)\nCaused by: org.eclipse.aether.resolution.ArtifactResolutionException: Could not find artifact io.netty:netty-tcnative:jar:${os.detected.classifier}:1.1.30.Fork2\nin http://repo1.maven.org/maven2 (http://repo1.maven.org/maven2)\n\tat org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:444)\n\tat org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts(DefaultArtifactResolver.java:246)\n\tat org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveDependencies(DefaultRepositorySystem.java:367)\n\t... 3 more\nCaused by: org.eclipse.aether.transfer.ArtifactNotFoundException: Could not find artifact io.netty:netty-tcnative:jar:${os.detected.classifier}:1.1.30.Fork2 in\nhttp://repo1.maven.org/maven2 (http://repo1.maven.org/maven2)\n\tat org.eclipse.aether.connector.basic.ArtifactTransportListener.transferFailed(ArtifactTransportListener.java:39)\n\tat org.eclipse.aether.connector.basic.BasicRepositoryConnector$TaskRunner.run(BasicRepositoryConnector.java:355)\n\tat org.eclipse.aether.util.concurrency.RunnableErrorForwarder$1.run(RunnableErrorForwarder.java:67)\n\tat org.eclipse.aether.connector.basic.BasicRepositoryConnector$DirectExecutor.execute(BasicRepositoryConnector.java:581)\n\tat org.eclipse.aether.connector.basic.BasicRepositoryConnector.get(BasicRepositoryConnector.java:249)\n\tat org.eclipse.aether.internal.impl.DefaultArtifactResolver.performDownloads(DefaultArtifactResolver.java:520)\n\tat org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:421)\n\t... 5 more\n\n```\n\nAfter: Works :)\n\nThis fixes #456 as well.\n\nCloses https://github.com/facebook/buck/pull/491\n\nTest Plan:\n```shell\nbuck run src/com/facebook/buck/maven:resolver -- /tmp/buck_repo/ thirdparty/jvm\n/tmp/mvn/ http://repo1.maven.org/maven2 io.netty:netty-all:4.0.24.Final\n```\n\nPlus tests were added in ffec8f597bef37ed33851735910808a96ee4cbd1\n\nReviewed By: sdwilsh\n\nfb-gh-sync-id: d089f02","distinct":true,"url":"https://api.github.com/repos/facebook/buck/commits/23469da8a05168f408e14b8decc9592b1f5e9117"}]}