{"action":"created","issue":{"url":"https://api.github.com/repos/ansible/ansible/issues/12211","labels_url":"https://api.github.com/repos/ansible/ansible/issues/12211/labels{/name}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/12211/comments","events_url":"https://api.github.com/repos/ansible/ansible/issues/12211/events","html_url":"https://github.com/ansible/ansible/pull/12211","id":104528538,"number":12211,"title":"Make sure combine_vars() returns a dict","user":{"login":"mgedmin","id":159967,"avatar_url":"https://avatars.githubusercontent.com/u/159967?v=3","gravatar_id":"","url":"https://api.github.com/users/mgedmin","html_url":"https://github.com/mgedmin","followers_url":"https://api.github.com/users/mgedmin/followers","following_url":"https://api.github.com/users/mgedmin/following{/other_user}","gists_url":"https://api.github.com/users/mgedmin/gists{/gist_id}","starred_url":"https://api.github.com/users/mgedmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgedmin/subscriptions","organizations_url":"https://api.github.com/users/mgedmin/orgs","repos_url":"https://api.github.com/users/mgedmin/repos","events_url":"https://api.github.com/users/mgedmin/events{/privacy}","received_events_url":"https://api.github.com/users/mgedmin/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-02T17:04:10Z","updated_at":"2015-09-02T17:54:43Z","closed_at":"2015-09-02T17:54:43Z","pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/12211","html_url":"https://github.com/ansible/ansible/pull/12211","diff_url":"https://github.com/ansible/ansible/pull/12211.diff","patch_url":"https://github.com/ansible/ansible/pull/12211.patch"},"body":"Prior to commit 54dbfba8f8c83f226eff3ab53a1ec3e099fe1e56 the return value of\ncombine_vars (and VariableManager._combine_vars) was always the builtin dict\ntype.  The named commit changed that, by accident, and this introduced a bug\n(#12206).  This change reverts to prior behavior where combine_vars() always\nreturns a builtin dict and fixes #12206.\n\nNote: VariableManager._combine_vars() has been refactored since 54dbfba and\nnow calls combine_vars().  Yay reduced code duplication!"},"comment":{"url":"https://api.github.com/repos/ansible/ansible/issues/comments/137189937","html_url":"https://github.com/ansible/ansible/pull/12211#issuecomment-137189937","issue_url":"https://api.github.com/repos/ansible/ansible/issues/12211","id":137189937,"user":{"login":"jimi-c","id":26403,"avatar_url":"https://avatars.githubusercontent.com/u/26403?v=3","gravatar_id":"","url":"https://api.github.com/users/jimi-c","html_url":"https://github.com/jimi-c","followers_url":"https://api.github.com/users/jimi-c/followers","following_url":"https://api.github.com/users/jimi-c/following{/other_user}","gists_url":"https://api.github.com/users/jimi-c/gists{/gist_id}","starred_url":"https://api.github.com/users/jimi-c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimi-c/subscriptions","organizations_url":"https://api.github.com/users/jimi-c/orgs","repos_url":"https://api.github.com/users/jimi-c/repos","events_url":"https://api.github.com/users/jimi-c/events{/privacy}","received_events_url":"https://api.github.com/users/jimi-c/received_events","type":"User","site_admin":false},"created_at":"2015-09-02T17:54:42Z","updated_at":"2015-09-02T17:54:42Z","body":"Closing per discussion in IRC, regarding the fix in 54dbfba being intentional. We're fixing #12206 in a slightly different way.\r\n\r\nThanks!"}}