{"action":"created","comment":{"url":"https://api.github.com/repos/sailfishos/sailfish-office/pulls/comments/29736579","id":29736579,"diff_hunk":"@@ -35,6 +35,13 @@ Page {\n         //% \"Index\"\n         header: PageHeader { title: qsTrId( \"sailfish-office-he-pdf_index\" ); }\n \n+        ViewPlaceholder {\n+            id: placeholder\n+            //% \"Document has no table of content\"\n+            text: qsTrId(\"sailfish-office-me-no-toc\")\n+        }\n+        onModelChanged: placeholder.enabled = !model || (model.count == 0)","path":"plugin/PDFDocumentToCPage.qml","position":9,"original_position":9,"commit_id":"9327a964c1a3a32521b5fc584b80ecc052dfaf88","original_commit_id":"9327a964c1a3a32521b5fc584b80ecc052dfaf88","user":{"login":"VDVsx","id":157582,"avatar_url":"https://avatars.githubusercontent.com/u/157582?v=3","gravatar_id":"","url":"https://api.github.com/users/VDVsx","html_url":"https://github.com/VDVsx","followers_url":"https://api.github.com/users/VDVsx/followers","following_url":"https://api.github.com/users/VDVsx/following{/other_user}","gists_url":"https://api.github.com/users/VDVsx/gists{/gist_id}","starred_url":"https://api.github.com/users/VDVsx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VDVsx/subscriptions","organizations_url":"https://api.github.com/users/VDVsx/orgs","repos_url":"https://api.github.com/users/VDVsx/repos","events_url":"https://api.github.com/users/VDVsx/events{/privacy}","received_events_url":"https://api.github.com/users/VDVsx/received_events","type":"User","site_admin":false},"body":"Is this really needed here ? \"enabled = !model || (model.count == 0)\", should be enough inside above item.","created_at":"2015-05-06T06:18:42Z","updated_at":"2015-05-06T06:18:42Z","html_url":"https://github.com/sailfishos/sailfish-office/pull/30#discussion_r29736579","pull_request_url":"https://api.github.com/repos/sailfishos/sailfish-office/pulls/30","_links":{"self":{"href":"https://api.github.com/repos/sailfishos/sailfish-office/pulls/comments/29736579"},"html":{"href":"https://github.com/sailfishos/sailfish-office/pull/30#discussion_r29736579"},"pull_request":{"href":"https://api.github.com/repos/sailfishos/sailfish-office/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/sailfishos/sailfish-office/pulls/30","id":34702504,"html_url":"https://github.com/sailfishos/sailfish-office/pull/30","diff_url":"https://github.com/sailfishos/sailfish-office/pull/30.diff","patch_url":"https://github.com/sailfishos/sailfish-office/pull/30.patch","issue_url":"https://api.github.com/repos/sailfishos/sailfish-office/issues/30","number":30,"state":"open","locked":false,"title":"[office] Add a placeholder for the table of content of PDF documents.","user":{"login":"dcaliste","id":5889532,"avatar_url":"https://avatars.githubusercontent.com/u/5889532?v=3","gravatar_id":"","url":"https://api.github.com/users/dcaliste","html_url":"https://github.com/dcaliste","followers_url":"https://api.github.com/users/dcaliste/followers","following_url":"https://api.github.com/users/dcaliste/following{/other_user}","gists_url":"https://api.github.com/users/dcaliste/gists{/gist_id}","starred_url":"https://api.github.com/users/dcaliste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcaliste/subscriptions","organizations_url":"https://api.github.com/users/dcaliste/orgs","repos_url":"https://api.github.com/users/dcaliste/repos","events_url":"https://api.github.com/users/dcaliste/events{/privacy}","received_events_url":"https://api.github.com/users/dcaliste/received_events","type":"User","site_admin":false},"body":"This adds a message for empty index page for PDF documents instead of showing an empty page.\r\n\r\nThe enabled attribute of the placeholder is not set by binding since the tocmodel object comes from a different thread and QML complains about signaling from a different thread. Thus, enabled attribute is set by javascript by reading the count value when model is set instead.","created_at":"2015-05-05T07:57:12Z","updated_at":"2015-05-06T06:18:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"51aeec6da7379461af8aae3908b2078ca9dd1037","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sailfishos/sailfish-office/pulls/30/commits","review_comments_url":"https://api.github.com/repos/sailfishos/sailfish-office/pulls/30/comments","review_comment_url":"https://api.github.com/repos/sailfishos/sailfish-office/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sailfishos/sailfish-office/issues/30/comments","statuses_url":"https://api.github.com/repos/sailfishos/sailfish-office/statuses/9327a964c1a3a32521b5fc584b80ecc052dfaf88","head":{"label":"dcaliste:notoc","ref":"notoc","sha":"9327a964c1a3a32521b5fc584b80ecc052dfaf88","user":{"login":"dcaliste","id":5889532,"avatar_url":"https://avatars.githubusercontent.com/u/5889532?v=3","gravatar_id":"","url":"https://api.github.com/users/dcaliste","html_url":"https://github.com/dcaliste","followers_url":"https://api.github.com/users/dcaliste/followers","following_url":"https://api.github.com/users/dcaliste/following{/other_user}","gists_url":"https://api.github.com/users/dcaliste/gists{/gist_id}","starred_url":"https://api.github.com/users/dcaliste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcaliste/subscriptions","organizations_url":"https://api.github.com/users/dcaliste/orgs","repos_url":"https://api.github.com/users/dcaliste/repos","events_url":"https://api.github.com/users/dcaliste/events{/privacy}","received_events_url":"https://api.github.com/users/dcaliste/received_events","type":"User","site_admin":false},"repo":{"id":32389480,"name":"sailfish-office","full_name":"dcaliste/sailfish-office","owner":{"login":"dcaliste","id":5889532,"avatar_url":"https://avatars.githubusercontent.com/u/5889532?v=3","gravatar_id":"","url":"https://api.github.com/users/dcaliste","html_url":"https://github.com/dcaliste","followers_url":"https://api.github.com/users/dcaliste/followers","following_url":"https://api.github.com/users/dcaliste/following{/other_user}","gists_url":"https://api.github.com/users/dcaliste/gists{/gist_id}","starred_url":"https://api.github.com/users/dcaliste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcaliste/subscriptions","organizations_url":"https://api.github.com/users/dcaliste/orgs","repos_url":"https://api.github.com/users/dcaliste/repos","events_url":"https://api.github.com/users/dcaliste/events{/privacy}","received_events_url":"https://api.github.com/users/dcaliste/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dcaliste/sailfish-office","description":"Sailfish Office","fork":true,"url":"https://api.github.com/repos/dcaliste/sailfish-office","forks_url":"https://api.github.com/repos/dcaliste/sailfish-office/forks","keys_url":"https://api.github.com/repos/dcaliste/sailfish-office/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcaliste/sailfish-office/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcaliste/sailfish-office/teams","hooks_url":"https://api.github.com/repos/dcaliste/sailfish-office/hooks","issue_events_url":"https://api.github.com/repos/dcaliste/sailfish-office/issues/events{/number}","events_url":"https://api.github.com/repos/dcaliste/sailfish-office/events","assignees_url":"https://api.github.com/repos/dcaliste/sailfish-office/assignees{/user}","branches_url":"https://api.github.com/repos/dcaliste/sailfish-office/branches{/branch}","tags_url":"https://api.github.com/repos/dcaliste/sailfish-office/tags","blobs_url":"https://api.github.com/repos/dcaliste/sailfish-office/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcaliste/sailfish-office/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcaliste/sailfish-office/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcaliste/sailfish-office/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcaliste/sailfish-office/statuses/{sha}","languages_url":"https://api.github.com/repos/dcaliste/sailfish-office/languages","stargazers_url":"https://api.github.com/repos/dcaliste/sailfish-office/stargazers","contributors_url":"https://api.github.com/repos/dcaliste/sailfish-office/contributors","subscribers_url":"https://api.github.com/repos/dcaliste/sailfish-office/subscribers","subscription_url":"https://api.github.com/repos/dcaliste/sailfish-office/subscription","commits_url":"https://api.github.com/repos/dcaliste/sailfish-office/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcaliste/sailfish-office/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcaliste/sailfish-office/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcaliste/sailfish-office/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcaliste/sailfish-office/contents/{+path}","compare_url":"https://api.github.com/repos/dcaliste/sailfish-office/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcaliste/sailfish-office/merges","archive_url":"https://api.github.com/repos/dcaliste/sailfish-office/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcaliste/sailfish-office/downloads","issues_url":"https://api.github.com/repos/dcaliste/sailfish-office/issues{/number}","pulls_url":"https://api.github.com/repos/dcaliste/sailfish-office/pulls{/number}","milestones_url":"https://api.github.com/repos/dcaliste/sailfish-office/milestones{/number}","notifications_url":"https://api.github.com/repos/dcaliste/sailfish-office/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcaliste/sailfish-office/labels{/name}","releases_url":"https://api.github.com/repos/dcaliste/sailfish-office/releases{/id}","created_at":"2015-03-17T11:28:28Z","updated_at":"2015-05-04T19:50:48Z","pushed_at":"2015-05-04T19:51:40Z","git_url":"git://github.com/dcaliste/sailfish-office.git","ssh_url":"git@github.com:dcaliste/sailfish-office.git","clone_url":"https://github.com/dcaliste/sailfish-office.git","svn_url":"https://github.com/dcaliste/sailfish-office","homepage":null,"size":588,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sailfishos:master","ref":"master","sha":"3085f8df1b1a97b241b9459c285ba1ba33b8c2b2","user":{"login":"sailfishos","id":6198659,"avatar_url":"https://avatars.githubusercontent.com/u/6198659?v=3","gravatar_id":"","url":"https://api.github.com/users/sailfishos","html_url":"https://github.com/sailfishos","followers_url":"https://api.github.com/users/sailfishos/followers","following_url":"https://api.github.com/users/sailfishos/following{/other_user}","gists_url":"https://api.github.com/users/sailfishos/gists{/gist_id}","starred_url":"https://api.github.com/users/sailfishos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sailfishos/subscriptions","organizations_url":"https://api.github.com/users/sailfishos/orgs","repos_url":"https://api.github.com/users/sailfishos/repos","events_url":"https://api.github.com/users/sailfishos/events{/privacy}","received_events_url":"https://api.github.com/users/sailfishos/received_events","type":"Organization","site_admin":false},"repo":{"id":20478568,"name":"sailfish-office","full_name":"sailfishos/sailfish-office","owner":{"login":"sailfishos","id":6198659,"avatar_url":"https://avatars.githubusercontent.com/u/6198659?v=3","gravatar_id":"","url":"https://api.github.com/users/sailfishos","html_url":"https://github.com/sailfishos","followers_url":"https://api.github.com/users/sailfishos/followers","following_url":"https://api.github.com/users/sailfishos/following{/other_user}","gists_url":"https://api.github.com/users/sailfishos/gists{/gist_id}","starred_url":"https://api.github.com/users/sailfishos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sailfishos/subscriptions","organizations_url":"https://api.github.com/users/sailfishos/orgs","repos_url":"https://api.github.com/users/sailfishos/repos","events_url":"https://api.github.com/users/sailfishos/events{/privacy}","received_events_url":"https://api.github.com/users/sailfishos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sailfishos/sailfish-office","description":"Sailfish Office","fork":false,"url":"https://api.github.com/repos/sailfishos/sailfish-office","forks_url":"https://api.github.com/repos/sailfishos/sailfish-office/forks","keys_url":"https://api.github.com/repos/sailfishos/sailfish-office/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sailfishos/sailfish-office/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sailfishos/sailfish-office/teams","hooks_url":"https://api.github.com/repos/sailfishos/sailfish-office/hooks","issue_events_url":"https://api.github.com/repos/sailfishos/sailfish-office/issues/events{/number}","events_url":"https://api.github.com/repos/sailfishos/sailfish-office/events","assignees_url":"https://api.github.com/repos/sailfishos/sailfish-office/assignees{/user}","branches_url":"https://api.github.com/repos/sailfishos/sailfish-office/branches{/branch}","tags_url":"https://api.github.com/repos/sailfishos/sailfish-office/tags","blobs_url":"https://api.github.com/repos/sailfishos/sailfish-office/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sailfishos/sailfish-office/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sailfishos/sailfish-office/git/refs{/sha}","trees_url":"https://api.github.com/repos/sailfishos/sailfish-office/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sailfishos/sailfish-office/statuses/{sha}","languages_url":"https://api.github.com/repos/sailfishos/sailfish-office/languages","stargazers_url":"https://api.github.com/repos/sailfishos/sailfish-office/stargazers","contributors_url":"https://api.github.com/repos/sailfishos/sailfish-office/contributors","subscribers_url":"https://api.github.com/repos/sailfishos/sailfish-office/subscribers","subscription_url":"https://api.github.com/repos/sailfishos/sailfish-office/subscription","commits_url":"https://api.github.com/repos/sailfishos/sailfish-office/commits{/sha}","git_commits_url":"https://api.github.com/repos/sailfishos/sailfish-office/git/commits{/sha}","comments_url":"https://api.github.com/repos/sailfishos/sailfish-office/comments{/number}","issue_comment_url":"https://api.github.com/repos/sailfishos/sailfish-office/issues/comments{/number}","contents_url":"https://api.github.com/repos/sailfishos/sailfish-office/contents/{+path}","compare_url":"https://api.github.com/repos/sailfishos/sailfish-office/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sailfishos/sailfish-office/merges","archive_url":"https://api.github.com/repos/sailfishos/sailfish-office/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sailfishos/sailfish-office/downloads","issues_url":"https://api.github.com/repos/sailfishos/sailfish-office/issues{/number}","pulls_url":"https://api.github.com/repos/sailfishos/sailfish-office/pulls{/number}","milestones_url":"https://api.github.com/repos/sailfishos/sailfish-office/milestones{/number}","notifications_url":"https://api.github.com/repos/sailfishos/sailfish-office/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sailfishos/sailfish-office/labels{/name}","releases_url":"https://api.github.com/repos/sailfishos/sailfish-office/releases{/id}","created_at":"2014-06-04T10:08:14Z","updated_at":"2015-05-04T07:05:51Z","pushed_at":"2015-05-05T07:57:12Z","git_url":"git://github.com/sailfishos/sailfish-office.git","ssh_url":"git@github.com:sailfishos/sailfish-office.git","clone_url":"https://github.com/sailfishos/sailfish-office.git","svn_url":"https://github.com/sailfishos/sailfish-office","homepage":null,"size":999,"stargazers_count":24,"watchers_count":24,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":6,"forks":12,"open_issues":6,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sailfishos/sailfish-office/pulls/30"},"html":{"href":"https://github.com/sailfishos/sailfish-office/pull/30"},"issue":{"href":"https://api.github.com/repos/sailfishos/sailfish-office/issues/30"},"comments":{"href":"https://api.github.com/repos/sailfishos/sailfish-office/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/sailfishos/sailfish-office/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/sailfishos/sailfish-office/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sailfishos/sailfish-office/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/sailfishos/sailfish-office/statuses/9327a964c1a3a32521b5fc584b80ecc052dfaf88"}}}}