{"action":"created","issue":{"url":"https://api.github.com/repos/jenkinsci/jenkins/issues/1685","labels_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/1685/labels{/name}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/1685/comments","events_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/1685/events","html_url":"https://github.com/jenkinsci/jenkins/pull/1685","id":72901561,"number":1685,"title":"[JENKINS-28192] SecretRewriter.rewriteRecursive fails to resolve symbolic links on Windows","user":{"login":"ikedam","id":3115961,"avatar_url":"https://avatars.githubusercontent.com/u/3115961?v=3","gravatar_id":"","url":"https://api.github.com/users/ikedam","html_url":"https://github.com/ikedam","followers_url":"https://api.github.com/users/ikedam/followers","following_url":"https://api.github.com/users/ikedam/following{/other_user}","gists_url":"https://api.github.com/users/ikedam/gists{/gist_id}","starred_url":"https://api.github.com/users/ikedam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikedam/subscriptions","organizations_url":"https://api.github.com/users/ikedam/orgs","repos_url":"https://api.github.com/users/ikedam/repos","events_url":"https://api.github.com/users/ikedam/events{/privacy}","received_events_url":"https://api.github.com/users/ikedam/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-05-04T02:24:34Z","updated_at":"2015-05-05T02:42:34Z","closed_at":"2015-05-05T02:42:34Z","pull_request":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1685","html_url":"https://github.com/jenkinsci/jenkins/pull/1685","diff_url":"https://github.com/jenkinsci/jenkins/pull/1685.diff","patch_url":"https://github.com/jenkinsci/jenkins/pull/1685.patch"},"body":"[JENKINS-28192](https://issues.jenkins-ci.org/browse/JENKINS-28192)\r\n\r\n`SecretRewriter.rewriteRecursive` fails to resolve symbolic links on Windows,\r\nand fails to detect symbolic links.\r\nThis results `SecretRewriterTest#recursionDetection` doesn't finish on Windows.\r\n\r\nThis is caused for `File#getCanonicalPath` resolves symbolic links only on *nix systems, not on Windows.\r\nThis change uses `java.nio.file.Path#toRealPath` instead. It's provided only on Java 7 and falls back to `File#getCanonicalPath` on Java 6.\r\n"},"comment":{"url":"https://api.github.com/repos/jenkinsci/jenkins/issues/comments/98916382","html_url":"https://github.com/jenkinsci/jenkins/pull/1685#issuecomment-98916382","issue_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/1685","id":98916382,"user":{"login":"ikedam","id":3115961,"avatar_url":"https://avatars.githubusercontent.com/u/3115961?v=3","gravatar_id":"","url":"https://api.github.com/users/ikedam","html_url":"https://github.com/ikedam","followers_url":"https://api.github.com/users/ikedam/followers","following_url":"https://api.github.com/users/ikedam/following{/other_user}","gists_url":"https://api.github.com/users/ikedam/gists{/gist_id}","starred_url":"https://api.github.com/users/ikedam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikedam/subscriptions","organizations_url":"https://api.github.com/users/ikedam/orgs","repos_url":"https://api.github.com/users/ikedam/repos","events_url":"https://api.github.com/users/ikedam/events{/privacy}","received_events_url":"https://api.github.com/users/ikedam/received_events","type":"User","site_admin":false},"created_at":"2015-05-05T02:42:34Z","updated_at":"2015-05-05T02:42:34Z","body":"OK. Anyway, I found that `VirtualFile#isIllegalSymlink` is also affected and should be fixed.\r\nI'll recreate a new pull request after 1.614 (targeting Java >= 1.7) is released."}}