{"action":"closed","number":65,"pull_request":{"url":"https://api.github.com/repos/tonystone/geofeatures/pulls/65","id":45802560,"html_url":"https://github.com/tonystone/geofeatures/pull/65","diff_url":"https://github.com/tonystone/geofeatures/pull/65.diff","patch_url":"https://github.com/tonystone/geofeatures/pull/65.patch","issue_url":"https://api.github.com/repos/tonystone/geofeatures/issues/65","number":65,"state":"closed","locked":false,"title":"Refactor storage","user":{"login":"tonystone","id":3036270,"avatar_url":"https://avatars.githubusercontent.com/u/3036270?v=3","gravatar_id":"","url":"https://api.github.com/users/tonystone","html_url":"https://github.com/tonystone","followers_url":"https://api.github.com/users/tonystone/followers","following_url":"https://api.github.com/users/tonystone/following{/other_user}","gists_url":"https://api.github.com/users/tonystone/gists{/gist_id}","starred_url":"https://api.github.com/users/tonystone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonystone/subscriptions","organizations_url":"https://api.github.com/users/tonystone/orgs","repos_url":"https://api.github.com/users/tonystone/repos","events_url":"https://api.github.com/users/tonystone/events{/privacy}","received_events_url":"https://api.github.com/users/tonystone/received_events","type":"User","site_admin":false},"body":"## Refactoring storage\r\n\r\nMoving from using the `geofeatures::GeometryVariant` as a storage class to using the specific C++ backing classes such as `geofeatures::Point`, `geofeatures::Box`, etc.  This will make the majority of the Objective-C code simpler to understand and maintain as well as allow us to rely on a no throw guarantee for the C++ storage classes.\r\n\r\nThe type `geofeatures::GeometryPtrVariant` has been added to enable the generic algorithms to work on the specific classes through the boost::static_visiter methods without the overhead of constructing a new object.\r\n\r\nDue to the removal of some exception handling that is no longer needed, the code coverage has been increased substantially.","created_at":"2015-09-23T16:45:00Z","updated_at":"2015-09-23T17:13:55Z","closed_at":"2015-09-23T17:13:55Z","merged_at":null,"merge_commit_sha":"dbd9d7a09fa790d4fe9bd1e4a51150ec8344fd7a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tonystone/geofeatures/pulls/65/commits","review_comments_url":"https://api.github.com/repos/tonystone/geofeatures/pulls/65/comments","review_comment_url":"https://api.github.com/repos/tonystone/geofeatures/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tonystone/geofeatures/issues/65/comments","statuses_url":"https://api.github.com/repos/tonystone/geofeatures/statuses/765f9b0a97ae3170375af746f2505af89987c141","head":{"label":"tonystone:refactor-storage","ref":"refactor-storage","sha":"765f9b0a97ae3170375af746f2505af89987c141","user":{"login":"tonystone","id":3036270,"avatar_url":"https://avatars.githubusercontent.com/u/3036270?v=3","gravatar_id":"","url":"https://api.github.com/users/tonystone","html_url":"https://github.com/tonystone","followers_url":"https://api.github.com/users/tonystone/followers","following_url":"https://api.github.com/users/tonystone/following{/other_user}","gists_url":"https://api.github.com/users/tonystone/gists{/gist_id}","starred_url":"https://api.github.com/users/tonystone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonystone/subscriptions","organizations_url":"https://api.github.com/users/tonystone/orgs","repos_url":"https://api.github.com/users/tonystone/repos","events_url":"https://api.github.com/users/tonystone/events{/privacy}","received_events_url":"https://api.github.com/users/tonystone/received_events","type":"User","site_admin":false},"repo":{"id":41232751,"name":"geofeatures","full_name":"tonystone/geofeatures","owner":{"login":"tonystone","id":3036270,"avatar_url":"https://avatars.githubusercontent.com/u/3036270?v=3","gravatar_id":"","url":"https://api.github.com/users/tonystone","html_url":"https://github.com/tonystone","followers_url":"https://api.github.com/users/tonystone/followers","following_url":"https://api.github.com/users/tonystone/following{/other_user}","gists_url":"https://api.github.com/users/tonystone/gists{/gist_id}","starred_url":"https://api.github.com/users/tonystone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonystone/subscriptions","organizations_url":"https://api.github.com/users/tonystone/orgs","repos_url":"https://api.github.com/users/tonystone/repos","events_url":"https://api.github.com/users/tonystone/events{/privacy}","received_events_url":"https://api.github.com/users/tonystone/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tonystone/geofeatures","description":"A lightweight, high performance geometry library for Objective-C","fork":false,"url":"https://api.github.com/repos/tonystone/geofeatures","forks_url":"https://api.github.com/repos/tonystone/geofeatures/forks","keys_url":"https://api.github.com/repos/tonystone/geofeatures/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tonystone/geofeatures/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tonystone/geofeatures/teams","hooks_url":"https://api.github.com/repos/tonystone/geofeatures/hooks","issue_events_url":"https://api.github.com/repos/tonystone/geofeatures/issues/events{/number}","events_url":"https://api.github.com/repos/tonystone/geofeatures/events","assignees_url":"https://api.github.com/repos/tonystone/geofeatures/assignees{/user}","branches_url":"https://api.github.com/repos/tonystone/geofeatures/branches{/branch}","tags_url":"https://api.github.com/repos/tonystone/geofeatures/tags","blobs_url":"https://api.github.com/repos/tonystone/geofeatures/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tonystone/geofeatures/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tonystone/geofeatures/git/refs{/sha}","trees_url":"https://api.github.com/repos/tonystone/geofeatures/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tonystone/geofeatures/statuses/{sha}","languages_url":"https://api.github.com/repos/tonystone/geofeatures/languages","stargazers_url":"https://api.github.com/repos/tonystone/geofeatures/stargazers","contributors_url":"https://api.github.com/repos/tonystone/geofeatures/contributors","subscribers_url":"https://api.github.com/repos/tonystone/geofeatures/subscribers","subscription_url":"https://api.github.com/repos/tonystone/geofeatures/subscription","commits_url":"https://api.github.com/repos/tonystone/geofeatures/commits{/sha}","git_commits_url":"https://api.github.com/repos/tonystone/geofeatures/git/commits{/sha}","comments_url":"https://api.github.com/repos/tonystone/geofeatures/comments{/number}","issue_comment_url":"https://api.github.com/repos/tonystone/geofeatures/issues/comments{/number}","contents_url":"https://api.github.com/repos/tonystone/geofeatures/contents/{+path}","compare_url":"https://api.github.com/repos/tonystone/geofeatures/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tonystone/geofeatures/merges","archive_url":"https://api.github.com/repos/tonystone/geofeatures/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tonystone/geofeatures/downloads","issues_url":"https://api.github.com/repos/tonystone/geofeatures/issues{/number}","pulls_url":"https://api.github.com/repos/tonystone/geofeatures/pulls{/number}","milestones_url":"https://api.github.com/repos/tonystone/geofeatures/milestones{/number}","notifications_url":"https://api.github.com/repos/tonystone/geofeatures/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tonystone/geofeatures/labels{/name}","releases_url":"https://api.github.com/repos/tonystone/geofeatures/releases{/id}","created_at":"2015-08-23T02:35:40Z","updated_at":"2015-09-15T20:47:38Z","pushed_at":"2015-09-23T16:45:00Z","git_url":"git://github.com/tonystone/geofeatures.git","ssh_url":"git@github.com:tonystone/geofeatures.git","clone_url":"https://github.com/tonystone/geofeatures.git","svn_url":"https://github.com/tonystone/geofeatures","homepage":"","size":18600,"stargazers_count":7,"watchers_count":7,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":12,"forks":3,"open_issues":12,"watchers":7,"default_branch":"master"}},"base":{"label":"tonystone:master","ref":"master","sha":"bc953e6ac338ac52f8c1a858e065a2f2245c6d5b","user":{"login":"tonystone","id":3036270,"avatar_url":"https://avatars.githubusercontent.com/u/3036270?v=3","gravatar_id":"","url":"https://api.github.com/users/tonystone","html_url":"https://github.com/tonystone","followers_url":"https://api.github.com/users/tonystone/followers","following_url":"https://api.github.com/users/tonystone/following{/other_user}","gists_url":"https://api.github.com/users/tonystone/gists{/gist_id}","starred_url":"https://api.github.com/users/tonystone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonystone/subscriptions","organizations_url":"https://api.github.com/users/tonystone/orgs","repos_url":"https://api.github.com/users/tonystone/repos","events_url":"https://api.github.com/users/tonystone/events{/privacy}","received_events_url":"https://api.github.com/users/tonystone/received_events","type":"User","site_admin":false},"repo":{"id":41232751,"name":"geofeatures","full_name":"tonystone/geofeatures","owner":{"login":"tonystone","id":3036270,"avatar_url":"https://avatars.githubusercontent.com/u/3036270?v=3","gravatar_id":"","url":"https://api.github.com/users/tonystone","html_url":"https://github.com/tonystone","followers_url":"https://api.github.com/users/tonystone/followers","following_url":"https://api.github.com/users/tonystone/following{/other_user}","gists_url":"https://api.github.com/users/tonystone/gists{/gist_id}","starred_url":"https://api.github.com/users/tonystone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonystone/subscriptions","organizations_url":"https://api.github.com/users/tonystone/orgs","repos_url":"https://api.github.com/users/tonystone/repos","events_url":"https://api.github.com/users/tonystone/events{/privacy}","received_events_url":"https://api.github.com/users/tonystone/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tonystone/geofeatures","description":"A lightweight, high performance geometry library for Objective-C","fork":false,"url":"https://api.github.com/repos/tonystone/geofeatures","forks_url":"https://api.github.com/repos/tonystone/geofeatures/forks","keys_url":"https://api.github.com/repos/tonystone/geofeatures/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tonystone/geofeatures/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tonystone/geofeatures/teams","hooks_url":"https://api.github.com/repos/tonystone/geofeatures/hooks","issue_events_url":"https://api.github.com/repos/tonystone/geofeatures/issues/events{/number}","events_url":"https://api.github.com/repos/tonystone/geofeatures/events","assignees_url":"https://api.github.com/repos/tonystone/geofeatures/assignees{/user}","branches_url":"https://api.github.com/repos/tonystone/geofeatures/branches{/branch}","tags_url":"https://api.github.com/repos/tonystone/geofeatures/tags","blobs_url":"https://api.github.com/repos/tonystone/geofeatures/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tonystone/geofeatures/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tonystone/geofeatures/git/refs{/sha}","trees_url":"https://api.github.com/repos/tonystone/geofeatures/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tonystone/geofeatures/statuses/{sha}","languages_url":"https://api.github.com/repos/tonystone/geofeatures/languages","stargazers_url":"https://api.github.com/repos/tonystone/geofeatures/stargazers","contributors_url":"https://api.github.com/repos/tonystone/geofeatures/contributors","subscribers_url":"https://api.github.com/repos/tonystone/geofeatures/subscribers","subscription_url":"https://api.github.com/repos/tonystone/geofeatures/subscription","commits_url":"https://api.github.com/repos/tonystone/geofeatures/commits{/sha}","git_commits_url":"https://api.github.com/repos/tonystone/geofeatures/git/commits{/sha}","comments_url":"https://api.github.com/repos/tonystone/geofeatures/comments{/number}","issue_comment_url":"https://api.github.com/repos/tonystone/geofeatures/issues/comments{/number}","contents_url":"https://api.github.com/repos/tonystone/geofeatures/contents/{+path}","compare_url":"https://api.github.com/repos/tonystone/geofeatures/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tonystone/geofeatures/merges","archive_url":"https://api.github.com/repos/tonystone/geofeatures/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tonystone/geofeatures/downloads","issues_url":"https://api.github.com/repos/tonystone/geofeatures/issues{/number}","pulls_url":"https://api.github.com/repos/tonystone/geofeatures/pulls{/number}","milestones_url":"https://api.github.com/repos/tonystone/geofeatures/milestones{/number}","notifications_url":"https://api.github.com/repos/tonystone/geofeatures/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tonystone/geofeatures/labels{/name}","releases_url":"https://api.github.com/repos/tonystone/geofeatures/releases{/id}","created_at":"2015-08-23T02:35:40Z","updated_at":"2015-09-15T20:47:38Z","pushed_at":"2015-09-23T16:45:00Z","git_url":"git://github.com/tonystone/geofeatures.git","ssh_url":"git@github.com:tonystone/geofeatures.git","clone_url":"https://github.com/tonystone/geofeatures.git","svn_url":"https://github.com/tonystone/geofeatures","homepage":"","size":18600,"stargazers_count":7,"watchers_count":7,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":12,"forks":3,"open_issues":12,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tonystone/geofeatures/pulls/65"},"html":{"href":"https://github.com/tonystone/geofeatures/pull/65"},"issue":{"href":"https://api.github.com/repos/tonystone/geofeatures/issues/65"},"comments":{"href":"https://api.github.com/repos/tonystone/geofeatures/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/tonystone/geofeatures/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/tonystone/geofeatures/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tonystone/geofeatures/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/tonystone/geofeatures/statuses/765f9b0a97ae3170375af746f2505af89987c141"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"commits":20,"additions":16753,"deletions":16328,"changed_files":69}}