{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/34949967","id":34949967,"diff_hunk":"@@ -77,8 +77,10 @@ void CGUIViewStateWindowPVRGuide::SaveViewState(void)\n \n CGUIViewStateWindowPVRTimers::CGUIViewStateWindowPVRTimers(const int windowId, const CFileItemList& items) : CGUIViewStatePVR(windowId, items)\n {\n-  AddSortMethod(SortByLabel, 551, LABEL_MASKS(\"%L\", \"%I\", \"%L\", \"\"));   // FileName, Size | Foldername, empty\n-  AddSortMethod(SortByDate, 552, LABEL_MASKS(\"%L\", \"%J\", \"%L\", \"%J\"));  // FileName, Date | Foldername, Date\n+  SortAttribute sortAttributes(CSettings::Get().GetBool(\"filelists.ignorethewhensorting\") ? SortAttributeIgnoreArticle : SortAttributeNone);\n+  sortAttributes = (SortAttribute)((int)sortAttributes | SortAttributeIgnoreFolders);","path":"xbmc/pvr/windows/GUIViewStatePVR.cpp","position":7,"original_position":7,"commit_id":"fdc0ae73dedf86e62808cedaba580a9bad040a63","original_commit_id":"fdc0ae73dedf86e62808cedaba580a9bad040a63","user":{"login":"ksooo","id":3226626,"avatar_url":"https://avatars.githubusercontent.com/u/3226626?v=3","gravatar_id":"","url":"https://api.github.com/users/ksooo","html_url":"https://github.com/ksooo","followers_url":"https://api.github.com/users/ksooo/followers","following_url":"https://api.github.com/users/ksooo/following{/other_user}","gists_url":"https://api.github.com/users/ksooo/gists{/gist_id}","starred_url":"https://api.github.com/users/ksooo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksooo/subscriptions","organizations_url":"https://api.github.com/users/ksooo/orgs","repos_url":"https://api.github.com/users/ksooo/repos","events_url":"https://api.github.com/users/ksooo/events{/privacy}","received_events_url":"https://api.github.com/users/ksooo/received_events","type":"User","site_admin":false},"body":"It's pretty simple. You introduced a new line of code and used a c style cast there. In Kodi, for new code we are using c++ style  casts. If old code in the same source file uses old style casts, no need to change that old code.","created_at":"2015-07-18T18:08:36Z","updated_at":"2015-07-18T18:08:36Z","html_url":"https://github.com/xbmc/xbmc/pull/7455#discussion_r34949967","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/7455","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/34949967"},"html":{"href":"https://github.com/xbmc/xbmc/pull/7455#discussion_r34949967"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7455"}}},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/7455","id":39495226,"html_url":"https://github.com/xbmc/xbmc/pull/7455","diff_url":"https://github.com/xbmc/xbmc/pull/7455.diff","patch_url":"https://github.com/xbmc/xbmc/pull/7455.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/7455","number":7455,"state":"open","locked":false,"title":"[PVR] Ignore article & folders when sorting Timers","user":{"login":"metaron-uk","id":12870817,"avatar_url":"https://avatars.githubusercontent.com/u/12870817?v=3","gravatar_id":"","url":"https://api.github.com/users/metaron-uk","html_url":"https://github.com/metaron-uk","followers_url":"https://api.github.com/users/metaron-uk/followers","following_url":"https://api.github.com/users/metaron-uk/following{/other_user}","gists_url":"https://api.github.com/users/metaron-uk/gists{/gist_id}","starred_url":"https://api.github.com/users/metaron-uk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metaron-uk/subscriptions","organizations_url":"https://api.github.com/users/metaron-uk/orgs","repos_url":"https://api.github.com/users/metaron-uk/repos","events_url":"https://api.github.com/users/metaron-uk/events{/privacy}","received_events_url":"https://api.github.com/users/metaron-uk/received_events","type":"User","site_admin":false},"body":"With the introduction of repeating timers which are handled as folders, Manual timers were always appearing at the bottom, sorted separately. This is confusing.\r\n\r\nAfter discussing with @Ksooo ( http://forum.kodi.tv/showthread.php?tid=227026&pid=2047719#pid2047719 ), this pull request sorts 'repeating' and 'manual' timers together (both when sorting by date and by name) which should make them much easier to find in a long list.\r\n\r\nThe opportunity has also been taken to 'ignore articles' so there are less timers starting with 'T'.\r\n\r\n![screenshot010](https://cloud.githubusercontent.com/assets/12870817/8575489/2bfe6732-2594-11e5-8eee-cbc1c387b21e.png)\r\n","created_at":"2015-07-08T16:16:16Z","updated_at":"2015-07-18T18:08:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"adb8b6e39f9f271be3d64f2c460d12c936d0740d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/7455/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/7455/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/7455/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/fdc0ae73dedf86e62808cedaba580a9bad040a63","head":{"label":"metaron-uk:pvrTimerSortOrder","ref":"pvrTimerSortOrder","sha":"fdc0ae73dedf86e62808cedaba580a9bad040a63","user":{"login":"metaron-uk","id":12870817,"avatar_url":"https://avatars.githubusercontent.com/u/12870817?v=3","gravatar_id":"","url":"https://api.github.com/users/metaron-uk","html_url":"https://github.com/metaron-uk","followers_url":"https://api.github.com/users/metaron-uk/followers","following_url":"https://api.github.com/users/metaron-uk/following{/other_user}","gists_url":"https://api.github.com/users/metaron-uk/gists{/gist_id}","starred_url":"https://api.github.com/users/metaron-uk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metaron-uk/subscriptions","organizations_url":"https://api.github.com/users/metaron-uk/orgs","repos_url":"https://api.github.com/users/metaron-uk/repos","events_url":"https://api.github.com/users/metaron-uk/events{/privacy}","received_events_url":"https://api.github.com/users/metaron-uk/received_events","type":"User","site_admin":false},"repo":{"id":37365331,"name":"xbmc","full_name":"metaron-uk/xbmc","owner":{"login":"metaron-uk","id":12870817,"avatar_url":"https://avatars.githubusercontent.com/u/12870817?v=3","gravatar_id":"","url":"https://api.github.com/users/metaron-uk","html_url":"https://github.com/metaron-uk","followers_url":"https://api.github.com/users/metaron-uk/followers","following_url":"https://api.github.com/users/metaron-uk/following{/other_user}","gists_url":"https://api.github.com/users/metaron-uk/gists{/gist_id}","starred_url":"https://api.github.com/users/metaron-uk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metaron-uk/subscriptions","organizations_url":"https://api.github.com/users/metaron-uk/orgs","repos_url":"https://api.github.com/users/metaron-uk/repos","events_url":"https://api.github.com/users/metaron-uk/events{/privacy}","received_events_url":"https://api.github.com/users/metaron-uk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/metaron-uk/xbmc","description":"XBMC Main Repository","fork":true,"url":"https://api.github.com/repos/metaron-uk/xbmc","forks_url":"https://api.github.com/repos/metaron-uk/xbmc/forks","keys_url":"https://api.github.com/repos/metaron-uk/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metaron-uk/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metaron-uk/xbmc/teams","hooks_url":"https://api.github.com/repos/metaron-uk/xbmc/hooks","issue_events_url":"https://api.github.com/repos/metaron-uk/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/metaron-uk/xbmc/events","assignees_url":"https://api.github.com/repos/metaron-uk/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/metaron-uk/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/metaron-uk/xbmc/tags","blobs_url":"https://api.github.com/repos/metaron-uk/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metaron-uk/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metaron-uk/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/metaron-uk/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metaron-uk/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/metaron-uk/xbmc/languages","stargazers_url":"https://api.github.com/repos/metaron-uk/xbmc/stargazers","contributors_url":"https://api.github.com/repos/metaron-uk/xbmc/contributors","subscribers_url":"https://api.github.com/repos/metaron-uk/xbmc/subscribers","subscription_url":"https://api.github.com/repos/metaron-uk/xbmc/subscription","commits_url":"https://api.github.com/repos/metaron-uk/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/metaron-uk/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/metaron-uk/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/metaron-uk/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/metaron-uk/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/metaron-uk/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metaron-uk/xbmc/merges","archive_url":"https://api.github.com/repos/metaron-uk/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metaron-uk/xbmc/downloads","issues_url":"https://api.github.com/repos/metaron-uk/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/metaron-uk/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/metaron-uk/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/metaron-uk/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metaron-uk/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/metaron-uk/xbmc/releases{/id}","created_at":"2015-06-13T09:15:46Z","updated_at":"2015-06-13T09:16:18Z","pushed_at":"2015-07-10T15:41:45Z","git_url":"git://github.com/metaron-uk/xbmc.git","ssh_url":"git@github.com:metaron-uk/xbmc.git","clone_url":"https://github.com/metaron-uk/xbmc.git","svn_url":"https://github.com/metaron-uk/xbmc","homepage":"http://xbmc.org","size":512889,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"5172b7e6c09d309b1d1e9ae0b95bd41eef6b7495","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","created_at":"2011-01-03T21:18:51Z","updated_at":"2015-07-18T16:47:24Z","pushed_at":"2015-07-18T15:41:21Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1864718,"stargazers_count":4012,"watchers_count":4012,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2925,"mirror_url":null,"open_issues_count":184,"forks":2925,"open_issues":184,"watchers":4012,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7455"},"html":{"href":"https://github.com/xbmc/xbmc/pull/7455"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/7455"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/7455/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7455/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7455/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/fdc0ae73dedf86e62808cedaba580a9bad040a63"}}}}