{"action":"created","issue":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/1008","labels_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/1008/labels{/name}","comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/1008/comments","events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/1008/events","html_url":"https://github.com/cfpb/cfgov-refresh/pull/1008","id":107795969,"number":1008,"title":"Update ESLint config for version 1.5.1 compatibility","user":{"login":"anselmbradford","id":704760,"avatar_url":"https://avatars.githubusercontent.com/u/704760?v=3","gravatar_id":"","url":"https://api.github.com/users/anselmbradford","html_url":"https://github.com/anselmbradford","followers_url":"https://api.github.com/users/anselmbradford/followers","following_url":"https://api.github.com/users/anselmbradford/following{/other_user}","gists_url":"https://api.github.com/users/anselmbradford/gists{/gist_id}","starred_url":"https://api.github.com/users/anselmbradford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anselmbradford/subscriptions","organizations_url":"https://api.github.com/users/anselmbradford/orgs","repos_url":"https://api.github.com/users/anselmbradford/repos","events_url":"https://api.github.com/users/anselmbradford/events{/privacy}","received_events_url":"https://api.github.com/users/anselmbradford/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-22T20:33:11Z","updated_at":"2015-09-23T21:08:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/1008","html_url":"https://github.com/cfpb/cfgov-refresh/pull/1008","diff_url":"https://github.com/cfpb/cfgov-refresh/pull/1008.diff","patch_url":"https://github.com/cfpb/cfgov-refresh/pull/1008.patch"},"body":"Update ESLint config for  version 1.5.1 compatibility.\r\nFixes ESLint errors that were breaking on Travis.\r\n\r\n## Additions\r\n\r\n- Added additional environments and rules for version 1.5.1 ESLint compatibility.\r\n\r\n## Changes\r\n\r\n- Fixes linting errors:\r\n  - Formats tests to fix indenting errors.\r\n  - Moves requires to top of files in tests.\r\n- Moves gulp linting implementation to a helper function.\r\n\r\n## Testing\r\n\r\n- `gulp build && gulp lint` should have no errors\r\n\r\n## Review\r\n\r\n- @jimmynotjim \r\n- @sebworks \r\n- @KimberlyMunoz \r\n\r\n## Todos\r\n\r\n- ~~I have a PR open with gulp-eslint for updating that to [1.5.1](https://github.com/adametry/gulp-eslint/pull/96), but this doesn't appear to add any breaking changes so should be able to go in before that is merged.~~ Not necessary, the caret versioning actually already brings in `1.5.1` without an updated needed in gulp-eslint."},"comment":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/comments/142729025","html_url":"https://github.com/cfpb/cfgov-refresh/pull/1008#issuecomment-142729025","issue_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/1008","id":142729025,"user":{"login":"jimmynotjim","id":1280430,"avatar_url":"https://avatars.githubusercontent.com/u/1280430?v=3","gravatar_id":"","url":"https://api.github.com/users/jimmynotjim","html_url":"https://github.com/jimmynotjim","followers_url":"https://api.github.com/users/jimmynotjim/followers","following_url":"https://api.github.com/users/jimmynotjim/following{/other_user}","gists_url":"https://api.github.com/users/jimmynotjim/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmynotjim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmynotjim/subscriptions","organizations_url":"https://api.github.com/users/jimmynotjim/orgs","repos_url":"https://api.github.com/users/jimmynotjim/repos","events_url":"https://api.github.com/users/jimmynotjim/events{/privacy}","received_events_url":"https://api.github.com/users/jimmynotjim/received_events","type":"User","site_admin":false},"created_at":"2015-09-23T21:08:18Z","updated_at":"2015-09-23T21:08:18Z","body":"Well somehow we've jumped to 78 warnings, but at least the errors are gone! :+1: "}}