{"action":"created","issue":{"url":"https://api.github.com/repos/Vestorly/torii/issues/216","labels_url":"https://api.github.com/repos/Vestorly/torii/issues/216/labels{/name}","comments_url":"https://api.github.com/repos/Vestorly/torii/issues/216/comments","events_url":"https://api.github.com/repos/Vestorly/torii/issues/216/events","html_url":"https://github.com/Vestorly/torii/pull/216","id":101671405,"number":216,"title":"add openid-connect with jwt tokens","user":{"login":"albertjan","id":301791,"avatar_url":"https://avatars.githubusercontent.com/u/301791?v=3","gravatar_id":"","url":"https://api.github.com/users/albertjan","html_url":"https://github.com/albertjan","followers_url":"https://api.github.com/users/albertjan/followers","following_url":"https://api.github.com/users/albertjan/following{/other_user}","gists_url":"https://api.github.com/users/albertjan/gists{/gist_id}","starred_url":"https://api.github.com/users/albertjan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albertjan/subscriptions","organizations_url":"https://api.github.com/users/albertjan/orgs","repos_url":"https://api.github.com/users/albertjan/repos","events_url":"https://api.github.com/users/albertjan/events{/privacy}","received_events_url":"https://api.github.com/users/albertjan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-08-18T14:35:15Z","updated_at":"2015-08-27T10:10:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Vestorly/torii/pulls/216","html_url":"https://github.com/Vestorly/torii/pull/216","diff_url":"https://github.com/Vestorly/torii/pull/216.diff","patch_url":"https://github.com/Vestorly/torii/pull/216.patch"},"body":"Adds a generic openid connect provider.\r\n\r\n - decodes the jwt to a javascript object\r\n - doesn't validate it that would mean adding a __lot__ of dependencies for certificate validation\r\n - tested irl with auth0 also borrowed some jwt decode tests from them\r\n\r\nThere are two places I've sinned:\r\n\r\n - https://github.com/Vestorly/torii/pull/216/files#diff-23d0d8b5a38b82137f4e75d6823cafc3R9\r\n  - I needed to call escape because that doesn't bother with utf8 stuff I linked to the so answer\r\n - https://github.com/Vestorly/torii/pull/216/files#diff-848166d56bb9eaef2df51ff601b48b18R48\r\n  - I wasn't able to override `optionalUrlParams` here: https://github.com/Vestorly/torii/pull/216/files#diff-848166d56bb9eaef2df51ff601b48b18R21 maybe you have a better idea how to fix it.\r\n"},"comment":{"url":"https://api.github.com/repos/Vestorly/torii/issues/comments/135370834","html_url":"https://github.com/Vestorly/torii/pull/216#issuecomment-135370834","issue_url":"https://api.github.com/repos/Vestorly/torii/issues/216","id":135370834,"user":{"login":"albertjan","id":301791,"avatar_url":"https://avatars.githubusercontent.com/u/301791?v=3","gravatar_id":"","url":"https://api.github.com/users/albertjan","html_url":"https://github.com/albertjan","followers_url":"https://api.github.com/users/albertjan/followers","following_url":"https://api.github.com/users/albertjan/following{/other_user}","gists_url":"https://api.github.com/users/albertjan/gists{/gist_id}","starred_url":"https://api.github.com/users/albertjan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albertjan/subscriptions","organizations_url":"https://api.github.com/users/albertjan/orgs","repos_url":"https://api.github.com/users/albertjan/repos","events_url":"https://api.github.com/users/albertjan/events{/privacy}","received_events_url":"https://api.github.com/users/albertjan/received_events","type":"User","site_admin":false},"created_at":"2015-08-27T10:10:48Z","updated_at":"2015-08-27T10:10:48Z","body":"@mixonic How do you want me to proceed? :smile: "}}