{"action":"closed","number":190,"pull_request":{"url":"https://api.github.com/repos/sidorares/node-mysql2/pulls/190","id":42814409,"html_url":"https://github.com/sidorares/node-mysql2/pull/190","diff_url":"https://github.com/sidorares/node-mysql2/pull/190.diff","patch_url":"https://github.com/sidorares/node-mysql2/pull/190.patch","issue_url":"https://api.github.com/repos/sidorares/node-mysql2/issues/190","number":190,"state":"closed","locked":false,"title":"Make SSL ciphers configurable","user":{"login":"miro","id":4402654,"avatar_url":"https://avatars.githubusercontent.com/u/4402654?v=3","gravatar_id":"","url":"https://api.github.com/users/miro","html_url":"https://github.com/miro","followers_url":"https://api.github.com/users/miro/followers","following_url":"https://api.github.com/users/miro/following{/other_user}","gists_url":"https://api.github.com/users/miro/gists{/gist_id}","starred_url":"https://api.github.com/users/miro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miro/subscriptions","organizations_url":"https://api.github.com/users/miro/orgs","repos_url":"https://api.github.com/users/miro/repos","events_url":"https://api.github.com/users/miro/events{/privacy}","received_events_url":"https://api.github.com/users/miro/received_events","type":"User","site_admin":false},"body":"On the Debian production environment which I am using some combination of OpenSSL and MySQL updates caused connecting via SSL to become impossible, error yilded was\r\n\r\n> Error: 139693901379552:error:14082174:SSL routines:SSL3_CHECK_CERT_AND_ALGORITHM:dh key too small:s3_clnt.c:3331:\r\n\r\nI figured out that this is likely related to [this](https://bugzilla.redhat.com/show_bug.cgi?id=1228755).\r\n\r\nFor us to be able to get connecting to the MySQL database working again on our current production setup we needed to control what SSL cipher was being used. (Especially we wanted a cipher which didn't use the *Diffie Hellman protocol*)\r\n\r\nThis change makes possible to tell which ciphers to use when connecting with SSL. Not sure if this is something you'd like to have, or is this properly prepared for merging, but here it is - just in case. \r\n\r\n(I'm surprised that no-one else hasn't bumped into this problem)","created_at":"2015-08-19T13:33:05Z","updated_at":"2015-08-19T23:38:11Z","closed_at":"2015-08-19T23:38:11Z","merged_at":"2015-08-19T23:38:11Z","merge_commit_sha":"147da848937e9d08d89c714040c1b10a7e82deb6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sidorares/node-mysql2/pulls/190/commits","review_comments_url":"https://api.github.com/repos/sidorares/node-mysql2/pulls/190/comments","review_comment_url":"https://api.github.com/repos/sidorares/node-mysql2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sidorares/node-mysql2/issues/190/comments","statuses_url":"https://api.github.com/repos/sidorares/node-mysql2/statuses/755572c55f637a5879a8247e3e636e362d3e6251","head":{"label":"miro:feature/parameterized-ciphers","ref":"feature/parameterized-ciphers","sha":"755572c55f637a5879a8247e3e636e362d3e6251","user":{"login":"miro","id":4402654,"avatar_url":"https://avatars.githubusercontent.com/u/4402654?v=3","gravatar_id":"","url":"https://api.github.com/users/miro","html_url":"https://github.com/miro","followers_url":"https://api.github.com/users/miro/followers","following_url":"https://api.github.com/users/miro/following{/other_user}","gists_url":"https://api.github.com/users/miro/gists{/gist_id}","starred_url":"https://api.github.com/users/miro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miro/subscriptions","organizations_url":"https://api.github.com/users/miro/orgs","repos_url":"https://api.github.com/users/miro/repos","events_url":"https://api.github.com/users/miro/events{/privacy}","received_events_url":"https://api.github.com/users/miro/received_events","type":"User","site_admin":false},"repo":{"id":41023209,"name":"node-mysql2","full_name":"miro/node-mysql2","owner":{"login":"miro","id":4402654,"avatar_url":"https://avatars.githubusercontent.com/u/4402654?v=3","gravatar_id":"","url":"https://api.github.com/users/miro","html_url":"https://github.com/miro","followers_url":"https://api.github.com/users/miro/followers","following_url":"https://api.github.com/users/miro/following{/other_user}","gists_url":"https://api.github.com/users/miro/gists{/gist_id}","starred_url":"https://api.github.com/users/miro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miro/subscriptions","organizations_url":"https://api.github.com/users/miro/orgs","repos_url":"https://api.github.com/users/miro/repos","events_url":"https://api.github.com/users/miro/events{/privacy}","received_events_url":"https://api.github.com/users/miro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/miro/node-mysql2","description":"fast node-mysql compatible mysql driver for node.js","fork":true,"url":"https://api.github.com/repos/miro/node-mysql2","forks_url":"https://api.github.com/repos/miro/node-mysql2/forks","keys_url":"https://api.github.com/repos/miro/node-mysql2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/miro/node-mysql2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/miro/node-mysql2/teams","hooks_url":"https://api.github.com/repos/miro/node-mysql2/hooks","issue_events_url":"https://api.github.com/repos/miro/node-mysql2/issues/events{/number}","events_url":"https://api.github.com/repos/miro/node-mysql2/events","assignees_url":"https://api.github.com/repos/miro/node-mysql2/assignees{/user}","branches_url":"https://api.github.com/repos/miro/node-mysql2/branches{/branch}","tags_url":"https://api.github.com/repos/miro/node-mysql2/tags","blobs_url":"https://api.github.com/repos/miro/node-mysql2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/miro/node-mysql2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/miro/node-mysql2/git/refs{/sha}","trees_url":"https://api.github.com/repos/miro/node-mysql2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/miro/node-mysql2/statuses/{sha}","languages_url":"https://api.github.com/repos/miro/node-mysql2/languages","stargazers_url":"https://api.github.com/repos/miro/node-mysql2/stargazers","contributors_url":"https://api.github.com/repos/miro/node-mysql2/contributors","subscribers_url":"https://api.github.com/repos/miro/node-mysql2/subscribers","subscription_url":"https://api.github.com/repos/miro/node-mysql2/subscription","commits_url":"https://api.github.com/repos/miro/node-mysql2/commits{/sha}","git_commits_url":"https://api.github.com/repos/miro/node-mysql2/git/commits{/sha}","comments_url":"https://api.github.com/repos/miro/node-mysql2/comments{/number}","issue_comment_url":"https://api.github.com/repos/miro/node-mysql2/issues/comments{/number}","contents_url":"https://api.github.com/repos/miro/node-mysql2/contents/{+path}","compare_url":"https://api.github.com/repos/miro/node-mysql2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/miro/node-mysql2/merges","archive_url":"https://api.github.com/repos/miro/node-mysql2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/miro/node-mysql2/downloads","issues_url":"https://api.github.com/repos/miro/node-mysql2/issues{/number}","pulls_url":"https://api.github.com/repos/miro/node-mysql2/pulls{/number}","milestones_url":"https://api.github.com/repos/miro/node-mysql2/milestones{/number}","notifications_url":"https://api.github.com/repos/miro/node-mysql2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/miro/node-mysql2/labels{/name}","releases_url":"https://api.github.com/repos/miro/node-mysql2/releases{/id}","created_at":"2015-08-19T08:46:27Z","updated_at":"2015-08-19T08:46:27Z","pushed_at":"2015-08-19T11:12:59Z","git_url":"git://github.com/miro/node-mysql2.git","ssh_url":"git@github.com:miro/node-mysql2.git","clone_url":"https://github.com/miro/node-mysql2.git","svn_url":"https://github.com/miro/node-mysql2","homepage":null,"size":1994,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sidorares:master","ref":"master","sha":"f251d505a5b1aabcd95c8e2d2a4c3c85513081b8","user":{"login":"sidorares","id":173025,"avatar_url":"https://avatars.githubusercontent.com/u/173025?v=3","gravatar_id":"","url":"https://api.github.com/users/sidorares","html_url":"https://github.com/sidorares","followers_url":"https://api.github.com/users/sidorares/followers","following_url":"https://api.github.com/users/sidorares/following{/other_user}","gists_url":"https://api.github.com/users/sidorares/gists{/gist_id}","starred_url":"https://api.github.com/users/sidorares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sidorares/subscriptions","organizations_url":"https://api.github.com/users/sidorares/orgs","repos_url":"https://api.github.com/users/sidorares/repos","events_url":"https://api.github.com/users/sidorares/events{/privacy}","received_events_url":"https://api.github.com/users/sidorares/received_events","type":"User","site_admin":false},"repo":{"id":9489902,"name":"node-mysql2","full_name":"sidorares/node-mysql2","owner":{"login":"sidorares","id":173025,"avatar_url":"https://avatars.githubusercontent.com/u/173025?v=3","gravatar_id":"","url":"https://api.github.com/users/sidorares","html_url":"https://github.com/sidorares","followers_url":"https://api.github.com/users/sidorares/followers","following_url":"https://api.github.com/users/sidorares/following{/other_user}","gists_url":"https://api.github.com/users/sidorares/gists{/gist_id}","starred_url":"https://api.github.com/users/sidorares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sidorares/subscriptions","organizations_url":"https://api.github.com/users/sidorares/orgs","repos_url":"https://api.github.com/users/sidorares/repos","events_url":"https://api.github.com/users/sidorares/events{/privacy}","received_events_url":"https://api.github.com/users/sidorares/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sidorares/node-mysql2","description":"fast node-mysql compatible mysql driver for node.js","fork":false,"url":"https://api.github.com/repos/sidorares/node-mysql2","forks_url":"https://api.github.com/repos/sidorares/node-mysql2/forks","keys_url":"https://api.github.com/repos/sidorares/node-mysql2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sidorares/node-mysql2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sidorares/node-mysql2/teams","hooks_url":"https://api.github.com/repos/sidorares/node-mysql2/hooks","issue_events_url":"https://api.github.com/repos/sidorares/node-mysql2/issues/events{/number}","events_url":"https://api.github.com/repos/sidorares/node-mysql2/events","assignees_url":"https://api.github.com/repos/sidorares/node-mysql2/assignees{/user}","branches_url":"https://api.github.com/repos/sidorares/node-mysql2/branches{/branch}","tags_url":"https://api.github.com/repos/sidorares/node-mysql2/tags","blobs_url":"https://api.github.com/repos/sidorares/node-mysql2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sidorares/node-mysql2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sidorares/node-mysql2/git/refs{/sha}","trees_url":"https://api.github.com/repos/sidorares/node-mysql2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sidorares/node-mysql2/statuses/{sha}","languages_url":"https://api.github.com/repos/sidorares/node-mysql2/languages","stargazers_url":"https://api.github.com/repos/sidorares/node-mysql2/stargazers","contributors_url":"https://api.github.com/repos/sidorares/node-mysql2/contributors","subscribers_url":"https://api.github.com/repos/sidorares/node-mysql2/subscribers","subscription_url":"https://api.github.com/repos/sidorares/node-mysql2/subscription","commits_url":"https://api.github.com/repos/sidorares/node-mysql2/commits{/sha}","git_commits_url":"https://api.github.com/repos/sidorares/node-mysql2/git/commits{/sha}","comments_url":"https://api.github.com/repos/sidorares/node-mysql2/comments{/number}","issue_comment_url":"https://api.github.com/repos/sidorares/node-mysql2/issues/comments{/number}","contents_url":"https://api.github.com/repos/sidorares/node-mysql2/contents/{+path}","compare_url":"https://api.github.com/repos/sidorares/node-mysql2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sidorares/node-mysql2/merges","archive_url":"https://api.github.com/repos/sidorares/node-mysql2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sidorares/node-mysql2/downloads","issues_url":"https://api.github.com/repos/sidorares/node-mysql2/issues{/number}","pulls_url":"https://api.github.com/repos/sidorares/node-mysql2/pulls{/number}","milestones_url":"https://api.github.com/repos/sidorares/node-mysql2/milestones{/number}","notifications_url":"https://api.github.com/repos/sidorares/node-mysql2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sidorares/node-mysql2/labels{/name}","releases_url":"https://api.github.com/repos/sidorares/node-mysql2/releases{/id}","created_at":"2013-04-17T05:23:59Z","updated_at":"2015-08-19T20:54:39Z","pushed_at":"2015-08-19T23:38:11Z","git_url":"git://github.com/sidorares/node-mysql2.git","ssh_url":"git@github.com:sidorares/node-mysql2.git","clone_url":"https://github.com/sidorares/node-mysql2.git","svn_url":"https://github.com/sidorares/node-mysql2","homepage":null,"size":1994,"stargazers_count":187,"watchers_count":187,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":27,"forks":40,"open_issues":27,"watchers":187,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sidorares/node-mysql2/pulls/190"},"html":{"href":"https://github.com/sidorares/node-mysql2/pull/190"},"issue":{"href":"https://api.github.com/repos/sidorares/node-mysql2/issues/190"},"comments":{"href":"https://api.github.com/repos/sidorares/node-mysql2/issues/190/comments"},"review_comments":{"href":"https://api.github.com/repos/sidorares/node-mysql2/pulls/190/comments"},"review_comment":{"href":"https://api.github.com/repos/sidorares/node-mysql2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sidorares/node-mysql2/pulls/190/commits"},"statuses":{"href":"https://api.github.com/repos/sidorares/node-mysql2/statuses/755572c55f637a5879a8247e3e636e362d3e6251"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"sidorares","id":173025,"avatar_url":"https://avatars.githubusercontent.com/u/173025?v=3","gravatar_id":"","url":"https://api.github.com/users/sidorares","html_url":"https://github.com/sidorares","followers_url":"https://api.github.com/users/sidorares/followers","following_url":"https://api.github.com/users/sidorares/following{/other_user}","gists_url":"https://api.github.com/users/sidorares/gists{/gist_id}","starred_url":"https://api.github.com/users/sidorares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sidorares/subscriptions","organizations_url":"https://api.github.com/users/sidorares/orgs","repos_url":"https://api.github.com/users/sidorares/repos","events_url":"https://api.github.com/users/sidorares/events{/privacy}","received_events_url":"https://api.github.com/users/sidorares/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":2,"deletions":1,"changed_files":1}}