{"action":"created","comment":{"url":"https://api.github.com/repos/wikimedia/jquery.ime/pulls/comments/48599684","id":48599684,"diff_hunk":"@@ -1,17 +1,41 @@\n ( function ( $ ) {\n \t'use strict';\n+\tvar TextEntryFactory, TextEntry, FormWidgetEntry, ContentEditableEntry,\n+\t\tdefaultInputMethod;\n \n \t// rangy is defined in the rangy library\n \t/*global rangy */\n \n \t/**\n+\t * Minimal functionality from OOjs: Initialize a class for OO inheritance","path":"src/jquery.ime.js","position":10,"original_position":10,"commit_id":"d6778c8412e6b6b8488c6979f9f77706d88fe6b1","original_commit_id":"d6778c8412e6b6b8488c6979f9f77706d88fe6b1","user":{"login":"santhoshtr","id":161672,"avatar_url":"https://avatars.githubusercontent.com/u/161672?v=3","gravatar_id":"","url":"https://api.github.com/users/santhoshtr","html_url":"https://github.com/santhoshtr","followers_url":"https://api.github.com/users/santhoshtr/followers","following_url":"https://api.github.com/users/santhoshtr/following{/other_user}","gists_url":"https://api.github.com/users/santhoshtr/gists{/gist_id}","starred_url":"https://api.github.com/users/santhoshtr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/santhoshtr/subscriptions","organizations_url":"https://api.github.com/users/santhoshtr/orgs","repos_url":"https://api.github.com/users/santhoshtr/repos","events_url":"https://api.github.com/users/santhoshtr/events{/privacy}","received_events_url":"https://api.github.com/users/santhoshtr/received_events","type":"User","site_admin":false},"body":"Developers outside Wikimedia will not be familiar with OOJS. You can remove reference to OOJS  and just state what really the method does- in this case having static members initizlied with empty object.\r\n\r\n","created_at":"2015-12-30T11:35:51Z","updated_at":"2015-12-30T11:35:51Z","html_url":"https://github.com/wikimedia/jquery.ime/pull/424#discussion_r48599684","pull_request_url":"https://api.github.com/repos/wikimedia/jquery.ime/pulls/424","_links":{"self":{"href":"https://api.github.com/repos/wikimedia/jquery.ime/pulls/comments/48599684"},"html":{"href":"https://github.com/wikimedia/jquery.ime/pull/424#discussion_r48599684"},"pull_request":{"href":"https://api.github.com/repos/wikimedia/jquery.ime/pulls/424"}}},"pull_request":{"url":"https://api.github.com/repos/wikimedia/jquery.ime/pulls/424","id":54548629,"html_url":"https://github.com/wikimedia/jquery.ime/pull/424","diff_url":"https://github.com/wikimedia/jquery.ime/pull/424.diff","patch_url":"https://github.com/wikimedia/jquery.ime/pull/424.patch","issue_url":"https://api.github.com/repos/wikimedia/jquery.ime/issues/424","number":424,"state":"open","locked":false,"title":"Modularise editable element text access","user":{"login":"divec","id":4414885,"avatar_url":"https://avatars.githubusercontent.com/u/4414885?v=3","gravatar_id":"","url":"https://api.github.com/users/divec","html_url":"https://github.com/divec","followers_url":"https://api.github.com/users/divec/followers","following_url":"https://api.github.com/users/divec/following{/other_user}","gists_url":"https://api.github.com/users/divec/gists{/gist_id}","starred_url":"https://api.github.com/users/divec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divec/subscriptions","organizations_url":"https://api.github.com/users/divec/orgs","repos_url":"https://api.github.com/users/divec/repos","events_url":"https://api.github.com/users/divec/events{/privacy}","received_events_url":"https://api.github.com/users/divec/received_events","type":"User","site_admin":false},"body":"Move the code specific to each type of editable element text access into a\r\ndedicated class, and use a factory pattern so a project using jQuery.IME can\r\nregister its own editable element text access implementation.\r\n\r\nTextEntry,\r\nTextEntry#getTextBeforeSelection( maxLength ),\r\nTextEntry#replaceTextAtSelection( precedingCharCount, newText ):\r\n* Abstract base class with methods to read/replace editable element text\r\n\r\nFormWidgetEntry,\r\nContentEditableEntry:\r\n* Concrete implementations for particular editable element types\r\n\r\nTextEntryFactory,\r\nTextEntryFactory#wrap( $element ),\r\n* Factory class with method to wrap editable element\r\n\r\n$.ime.TextEntry,\r\n$.ime.textEntryFactory:\r\n* Publicly accesible abstract base class and factory singleton","created_at":"2015-12-24T12:32:05Z","updated_at":"2015-12-30T11:35:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a8391de506fad5dc2602969af33ab931591d330","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wikimedia/jquery.ime/pulls/424/commits","review_comments_url":"https://api.github.com/repos/wikimedia/jquery.ime/pulls/424/comments","review_comment_url":"https://api.github.com/repos/wikimedia/jquery.ime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wikimedia/jquery.ime/issues/424/comments","statuses_url":"https://api.github.com/repos/wikimedia/jquery.ime/statuses/d6778c8412e6b6b8488c6979f9f77706d88fe6b1","head":{"label":"divec:text-entry","ref":"text-entry","sha":"d6778c8412e6b6b8488c6979f9f77706d88fe6b1","user":{"login":"divec","id":4414885,"avatar_url":"https://avatars.githubusercontent.com/u/4414885?v=3","gravatar_id":"","url":"https://api.github.com/users/divec","html_url":"https://github.com/divec","followers_url":"https://api.github.com/users/divec/followers","following_url":"https://api.github.com/users/divec/following{/other_user}","gists_url":"https://api.github.com/users/divec/gists{/gist_id}","starred_url":"https://api.github.com/users/divec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divec/subscriptions","organizations_url":"https://api.github.com/users/divec/orgs","repos_url":"https://api.github.com/users/divec/repos","events_url":"https://api.github.com/users/divec/events{/privacy}","received_events_url":"https://api.github.com/users/divec/received_events","type":"User","site_admin":false},"repo":{"id":47840628,"name":"jquery.ime","full_name":"divec/jquery.ime","owner":{"login":"divec","id":4414885,"avatar_url":"https://avatars.githubusercontent.com/u/4414885?v=3","gravatar_id":"","url":"https://api.github.com/users/divec","html_url":"https://github.com/divec","followers_url":"https://api.github.com/users/divec/followers","following_url":"https://api.github.com/users/divec/following{/other_user}","gists_url":"https://api.github.com/users/divec/gists{/gist_id}","starred_url":"https://api.github.com/users/divec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divec/subscriptions","organizations_url":"https://api.github.com/users/divec/orgs","repos_url":"https://api.github.com/users/divec/repos","events_url":"https://api.github.com/users/divec/events{/privacy}","received_events_url":"https://api.github.com/users/divec/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/divec/jquery.ime","description":"jQuery based input methods library","fork":true,"url":"https://api.github.com/repos/divec/jquery.ime","forks_url":"https://api.github.com/repos/divec/jquery.ime/forks","keys_url":"https://api.github.com/repos/divec/jquery.ime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/divec/jquery.ime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/divec/jquery.ime/teams","hooks_url":"https://api.github.com/repos/divec/jquery.ime/hooks","issue_events_url":"https://api.github.com/repos/divec/jquery.ime/issues/events{/number}","events_url":"https://api.github.com/repos/divec/jquery.ime/events","assignees_url":"https://api.github.com/repos/divec/jquery.ime/assignees{/user}","branches_url":"https://api.github.com/repos/divec/jquery.ime/branches{/branch}","tags_url":"https://api.github.com/repos/divec/jquery.ime/tags","blobs_url":"https://api.github.com/repos/divec/jquery.ime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/divec/jquery.ime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/divec/jquery.ime/git/refs{/sha}","trees_url":"https://api.github.com/repos/divec/jquery.ime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/divec/jquery.ime/statuses/{sha}","languages_url":"https://api.github.com/repos/divec/jquery.ime/languages","stargazers_url":"https://api.github.com/repos/divec/jquery.ime/stargazers","contributors_url":"https://api.github.com/repos/divec/jquery.ime/contributors","subscribers_url":"https://api.github.com/repos/divec/jquery.ime/subscribers","subscription_url":"https://api.github.com/repos/divec/jquery.ime/subscription","commits_url":"https://api.github.com/repos/divec/jquery.ime/commits{/sha}","git_commits_url":"https://api.github.com/repos/divec/jquery.ime/git/commits{/sha}","comments_url":"https://api.github.com/repos/divec/jquery.ime/comments{/number}","issue_comment_url":"https://api.github.com/repos/divec/jquery.ime/issues/comments{/number}","contents_url":"https://api.github.com/repos/divec/jquery.ime/contents/{+path}","compare_url":"https://api.github.com/repos/divec/jquery.ime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/divec/jquery.ime/merges","archive_url":"https://api.github.com/repos/divec/jquery.ime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/divec/jquery.ime/downloads","issues_url":"https://api.github.com/repos/divec/jquery.ime/issues{/number}","pulls_url":"https://api.github.com/repos/divec/jquery.ime/pulls{/number}","milestones_url":"https://api.github.com/repos/divec/jquery.ime/milestones{/number}","notifications_url":"https://api.github.com/repos/divec/jquery.ime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/divec/jquery.ime/labels{/name}","releases_url":"https://api.github.com/repos/divec/jquery.ime/releases{/id}","created_at":"2015-12-11T17:22:33Z","updated_at":"2015-12-11T17:22:34Z","pushed_at":"2015-12-24T12:33:41Z","git_url":"git://github.com/divec/jquery.ime.git","ssh_url":"git@github.com:divec/jquery.ime.git","clone_url":"https://github.com/divec/jquery.ime.git","svn_url":"https://github.com/divec/jquery.ime","homepage":null,"size":1743,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wikimedia:master","ref":"master","sha":"ea97e4bb7523bc3e77d7eecadbdcd1f0ef2f7037","user":{"login":"wikimedia","id":56668,"avatar_url":"https://avatars.githubusercontent.com/u/56668?v=3","gravatar_id":"","url":"https://api.github.com/users/wikimedia","html_url":"https://github.com/wikimedia","followers_url":"https://api.github.com/users/wikimedia/followers","following_url":"https://api.github.com/users/wikimedia/following{/other_user}","gists_url":"https://api.github.com/users/wikimedia/gists{/gist_id}","starred_url":"https://api.github.com/users/wikimedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikimedia/subscriptions","organizations_url":"https://api.github.com/users/wikimedia/orgs","repos_url":"https://api.github.com/users/wikimedia/repos","events_url":"https://api.github.com/users/wikimedia/events{/privacy}","received_events_url":"https://api.github.com/users/wikimedia/received_events","type":"Organization","site_admin":false},"repo":{"id":5444100,"name":"jquery.ime","full_name":"wikimedia/jquery.ime","owner":{"login":"wikimedia","id":56668,"avatar_url":"https://avatars.githubusercontent.com/u/56668?v=3","gravatar_id":"","url":"https://api.github.com/users/wikimedia","html_url":"https://github.com/wikimedia","followers_url":"https://api.github.com/users/wikimedia/followers","following_url":"https://api.github.com/users/wikimedia/following{/other_user}","gists_url":"https://api.github.com/users/wikimedia/gists{/gist_id}","starred_url":"https://api.github.com/users/wikimedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikimedia/subscriptions","organizations_url":"https://api.github.com/users/wikimedia/orgs","repos_url":"https://api.github.com/users/wikimedia/repos","events_url":"https://api.github.com/users/wikimedia/events{/privacy}","received_events_url":"https://api.github.com/users/wikimedia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wikimedia/jquery.ime","description":"jQuery based input methods library","fork":false,"url":"https://api.github.com/repos/wikimedia/jquery.ime","forks_url":"https://api.github.com/repos/wikimedia/jquery.ime/forks","keys_url":"https://api.github.com/repos/wikimedia/jquery.ime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wikimedia/jquery.ime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wikimedia/jquery.ime/teams","hooks_url":"https://api.github.com/repos/wikimedia/jquery.ime/hooks","issue_events_url":"https://api.github.com/repos/wikimedia/jquery.ime/issues/events{/number}","events_url":"https://api.github.com/repos/wikimedia/jquery.ime/events","assignees_url":"https://api.github.com/repos/wikimedia/jquery.ime/assignees{/user}","branches_url":"https://api.github.com/repos/wikimedia/jquery.ime/branches{/branch}","tags_url":"https://api.github.com/repos/wikimedia/jquery.ime/tags","blobs_url":"https://api.github.com/repos/wikimedia/jquery.ime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wikimedia/jquery.ime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wikimedia/jquery.ime/git/refs{/sha}","trees_url":"https://api.github.com/repos/wikimedia/jquery.ime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wikimedia/jquery.ime/statuses/{sha}","languages_url":"https://api.github.com/repos/wikimedia/jquery.ime/languages","stargazers_url":"https://api.github.com/repos/wikimedia/jquery.ime/stargazers","contributors_url":"https://api.github.com/repos/wikimedia/jquery.ime/contributors","subscribers_url":"https://api.github.com/repos/wikimedia/jquery.ime/subscribers","subscription_url":"https://api.github.com/repos/wikimedia/jquery.ime/subscription","commits_url":"https://api.github.com/repos/wikimedia/jquery.ime/commits{/sha}","git_commits_url":"https://api.github.com/repos/wikimedia/jquery.ime/git/commits{/sha}","comments_url":"https://api.github.com/repos/wikimedia/jquery.ime/comments{/number}","issue_comment_url":"https://api.github.com/repos/wikimedia/jquery.ime/issues/comments{/number}","contents_url":"https://api.github.com/repos/wikimedia/jquery.ime/contents/{+path}","compare_url":"https://api.github.com/repos/wikimedia/jquery.ime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wikimedia/jquery.ime/merges","archive_url":"https://api.github.com/repos/wikimedia/jquery.ime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wikimedia/jquery.ime/downloads","issues_url":"https://api.github.com/repos/wikimedia/jquery.ime/issues{/number}","pulls_url":"https://api.github.com/repos/wikimedia/jquery.ime/pulls{/number}","milestones_url":"https://api.github.com/repos/wikimedia/jquery.ime/milestones{/number}","notifications_url":"https://api.github.com/repos/wikimedia/jquery.ime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wikimedia/jquery.ime/labels{/name}","releases_url":"https://api.github.com/repos/wikimedia/jquery.ime/releases{/id}","created_at":"2012-08-16T20:19:33Z","updated_at":"2015-11-17T10:20:33Z","pushed_at":"2015-12-24T12:32:05Z","git_url":"git://github.com/wikimedia/jquery.ime.git","ssh_url":"git@github.com:wikimedia/jquery.ime.git","clone_url":"https://github.com/wikimedia/jquery.ime.git","svn_url":"https://github.com/wikimedia/jquery.ime","homepage":null,"size":2331,"stargazers_count":96,"watchers_count":96,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":111,"mirror_url":null,"open_issues_count":69,"forks":111,"open_issues":69,"watchers":96,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wikimedia/jquery.ime/pulls/424"},"html":{"href":"https://github.com/wikimedia/jquery.ime/pull/424"},"issue":{"href":"https://api.github.com/repos/wikimedia/jquery.ime/issues/424"},"comments":{"href":"https://api.github.com/repos/wikimedia/jquery.ime/issues/424/comments"},"review_comments":{"href":"https://api.github.com/repos/wikimedia/jquery.ime/pulls/424/comments"},"review_comment":{"href":"https://api.github.com/repos/wikimedia/jquery.ime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wikimedia/jquery.ime/pulls/424/commits"},"statuses":{"href":"https://api.github.com/repos/wikimedia/jquery.ime/statuses/d6778c8412e6b6b8488c6979f9f77706d88fe6b1"}}}}