{"action":"created","issue":{"url":"https://api.github.com/repos/concrete5/concrete5/issues/2507","labels_url":"https://api.github.com/repos/concrete5/concrete5/issues/2507/labels{/name}","comments_url":"https://api.github.com/repos/concrete5/concrete5/issues/2507/comments","events_url":"https://api.github.com/repos/concrete5/concrete5/issues/2507/events","html_url":"https://github.com/concrete5/concrete5/issues/2507","id":80581542,"number":2507,"title":"Old constants to be removed","user":{"login":"mlocati","id":928116,"avatar_url":"https://avatars.githubusercontent.com/u/928116?v=3","gravatar_id":"","url":"https://api.github.com/users/mlocati","html_url":"https://github.com/mlocati","followers_url":"https://api.github.com/users/mlocati/followers","following_url":"https://api.github.com/users/mlocati/following{/other_user}","gists_url":"https://api.github.com/users/mlocati/gists{/gist_id}","starred_url":"https://api.github.com/users/mlocati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlocati/subscriptions","organizations_url":"https://api.github.com/users/mlocati/orgs","repos_url":"https://api.github.com/users/mlocati/repos","events_url":"https://api.github.com/users/mlocati/events{/privacy}","received_events_url":"https://api.github.com/users/mlocati/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-25T16:07:06Z","updated_at":"2015-05-25T16:09:09Z","closed_at":null,"body":"I scanned the 5.7 codebase looking for the constants that we used in 5.6.\r\nWe still have some of them around:\r\n\r\n- [ ] C5_ENVIRONMENT_ONLY\r\n  (should only be used by `Application::isRunThroughCommandLineInterface`)\r\n- [ ] DIR_FILES_CACHE\r\n- [ ] DIR_FILES_TRASH\r\n- [ ] DIR_FILES_UPLOADED\r\n- [ ] DIR_TMP\r\n- [ ] EMAIL_ADDRESS_FORGOT_PASSWORD\r\n- [ ] EMAIL_ADDRESS_VALIDATE\r\n- [ ] ENABLE_APP_NEWS\r\n- [ ] ENABLE_EMAILS\r\n- [ ] ENABLE_USER_TIMEZONES\r\n- [ ] LOCALE\r\n- [ ] PASSWORD_SALT\r\n- [ ] SITE\r\n- [ ] STATISTICS_TRACK_PAGE_VIEWS\r\n- [ ] STRING_UTILS_CASE_FIRST_LOWER\r\n- [ ] STRING_UTILS_CASE_FIRST_UPPER\r\n- [ ] STRING_UTILS_CASE_HAS_LOWER\r\n- [ ] STRING_UTILS_CASE_HAS_NONALPH\r\n- [ ] STRING_UTILS_CASE_HAS_UPPER\r\n- [ ] STRING_UTILS_CASE_MIXED\r\n- [ ] STRING_UTILS_TRUNCATE_CHARS\r\n- [ ] UPLOAD_FILE_EXTENSIONS_ALLOWED\r\n- [ ] UPLOAD_FILE_EXTENSIONS_CONFIGURABLE\r\n- [ ] URL_REWRITING\r\n- [ ] URL_REWRITING_ALL\r\n"},"comment":{"url":"https://api.github.com/repos/concrete5/concrete5/issues/comments/105257780","html_url":"https://github.com/concrete5/concrete5/issues/2507#issuecomment-105257780","issue_url":"https://api.github.com/repos/concrete5/concrete5/issues/2507","id":105257780,"user":{"login":"mlocati","id":928116,"avatar_url":"https://avatars.githubusercontent.com/u/928116?v=3","gravatar_id":"","url":"https://api.github.com/users/mlocati","html_url":"https://github.com/mlocati","followers_url":"https://api.github.com/users/mlocati/followers","following_url":"https://api.github.com/users/mlocati/following{/other_user}","gists_url":"https://api.github.com/users/mlocati/gists{/gist_id}","starred_url":"https://api.github.com/users/mlocati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlocati/subscriptions","organizations_url":"https://api.github.com/users/mlocati/orgs","repos_url":"https://api.github.com/users/mlocati/repos","events_url":"https://api.github.com/users/mlocati/events{/privacy}","received_events_url":"https://api.github.com/users/mlocati/received_events","type":"User","site_admin":false},"created_at":"2015-05-25T16:09:09Z","updated_at":"2015-05-25T16:09:09Z","body":"- [X] C5_ENVIRONMENT_ONLY -> Fixed in #2506\r\n- [X] ENABLE_USER_TIMEZONES -> Fixed in #2506\r\n"}}