{"action":"created","comment":{"url":"https://api.github.com/repos/Wizcorp/wui-Dom/pulls/comments/32902143","id":32902143,"diff_hunk":"@@ -103,22 +91,23 @@ WuiDom.prototype._assign = function (tagName, options) {\n \t\t}\n \t} else if (tagName instanceof window.Element) {\n \t\t// the first passed argument already is a real HTML Element\n-\n \t\tthis.rootElement = tagName;\n \t} else {\n \t\tthrow new Error('WuiDom.assign requires the given argument to be a DOM Element or tagName.');\n \t}\n \n-\tif (options && options.name) {\n-\t\tthis._name = options.name;\n-\t}\n+\toptions = options || {};\n \n-\tif (options && options.hidden) {\n-\t\t// start hidden\n+\t// start hidden\n+\tif (options.hidden) {\n \t\tthis.hide();\n \t}\n \n-\treturn this.rootElement;\n+\t// set identifier (used by getChild)\n+\tthis._name = String(options.name);","path":"index.js","position":58,"original_position":58,"commit_id":"d6362202aae85d56ad18a080ea645d03bc6fbed2","original_commit_id":"d6362202aae85d56ad18a080ea645d03bc6fbed2","user":{"login":"micky2be","id":728644,"avatar_url":"https://avatars.githubusercontent.com/u/728644?v=3","gravatar_id":"","url":"https://api.github.com/users/micky2be","html_url":"https://github.com/micky2be","followers_url":"https://api.github.com/users/micky2be/followers","following_url":"https://api.github.com/users/micky2be/following{/other_user}","gists_url":"https://api.github.com/users/micky2be/gists{/gist_id}","starred_url":"https://api.github.com/users/micky2be/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micky2be/subscriptions","organizations_url":"https://api.github.com/users/micky2be/orgs","repos_url":"https://api.github.com/users/micky2be/repos","events_url":"https://api.github.com/users/micky2be/events{/privacy}","received_events_url":"https://api.github.com/users/micky2be/received_events","type":"User","site_admin":false},"body":"Yes and No. (I forgot to push the latest change)\r\nI let the developer take the responsibility to not set `name` to undefined","created_at":"2015-06-22T02:28:52Z","updated_at":"2015-06-22T02:28:52Z","html_url":"https://github.com/Wizcorp/wui-Dom/pull/52#discussion_r32902143","pull_request_url":"https://api.github.com/repos/Wizcorp/wui-Dom/pulls/52","_links":{"self":{"href":"https://api.github.com/repos/Wizcorp/wui-Dom/pulls/comments/32902143"},"html":{"href":"https://github.com/Wizcorp/wui-Dom/pull/52#discussion_r32902143"},"pull_request":{"href":"https://api.github.com/repos/Wizcorp/wui-Dom/pulls/52"}}},"pull_request":{"url":"https://api.github.com/repos/Wizcorp/wui-Dom/pulls/52","id":38195295,"html_url":"https://github.com/Wizcorp/wui-Dom/pull/52","diff_url":"https://github.com/Wizcorp/wui-Dom/pull/52.diff","patch_url":"https://github.com/Wizcorp/wui-Dom/pull/52.patch","issue_url":"https://api.github.com/repos/Wizcorp/wui-Dom/issues/52","number":52,"state":"open","locked":false,"title":"Use existing method for WuiDom creation","user":{"login":"micky2be","id":728644,"avatar_url":"https://avatars.githubusercontent.com/u/728644?v=3","gravatar_id":"","url":"https://api.github.com/users/micky2be","html_url":"https://github.com/micky2be","followers_url":"https://api.github.com/users/micky2be/followers","following_url":"https://api.github.com/users/micky2be/following{/other_user}","gists_url":"https://api.github.com/users/micky2be/gists{/gist_id}","starred_url":"https://api.github.com/users/micky2be/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micky2be/subscriptions","organizations_url":"https://api.github.com/users/micky2be/orgs","repos_url":"https://api.github.com/users/micky2be/repos","events_url":"https://api.github.com/users/micky2be/events{/privacy}","received_events_url":"https://api.github.com/users/micky2be/received_events","type":"User","site_admin":false},"body":"Use existing method on WuiDom instead of depending on createHtmlElement.","created_at":"2015-06-22T01:50:40Z","updated_at":"2015-06-22T02:28:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"afb14b41dbbdc8ee6e1cd6eee0ffd9a4b3c94d6e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Wizcorp/wui-Dom/pulls/52/commits","review_comments_url":"https://api.github.com/repos/Wizcorp/wui-Dom/pulls/52/comments","review_comment_url":"https://api.github.com/repos/Wizcorp/wui-Dom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wizcorp/wui-Dom/issues/52/comments","statuses_url":"https://api.github.com/repos/Wizcorp/wui-Dom/statuses/d6362202aae85d56ad18a080ea645d03bc6fbed2","head":{"label":"micky2be:master","ref":"master","sha":"d6362202aae85d56ad18a080ea645d03bc6fbed2","user":{"login":"micky2be","id":728644,"avatar_url":"https://avatars.githubusercontent.com/u/728644?v=3","gravatar_id":"","url":"https://api.github.com/users/micky2be","html_url":"https://github.com/micky2be","followers_url":"https://api.github.com/users/micky2be/followers","following_url":"https://api.github.com/users/micky2be/following{/other_user}","gists_url":"https://api.github.com/users/micky2be/gists{/gist_id}","starred_url":"https://api.github.com/users/micky2be/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micky2be/subscriptions","organizations_url":"https://api.github.com/users/micky2be/orgs","repos_url":"https://api.github.com/users/micky2be/repos","events_url":"https://api.github.com/users/micky2be/events{/privacy}","received_events_url":"https://api.github.com/users/micky2be/received_events","type":"User","site_admin":false},"repo":{"id":33841405,"name":"wui-Dom","full_name":"micky2be/wui-Dom","owner":{"login":"micky2be","id":728644,"avatar_url":"https://avatars.githubusercontent.com/u/728644?v=3","gravatar_id":"","url":"https://api.github.com/users/micky2be","html_url":"https://github.com/micky2be","followers_url":"https://api.github.com/users/micky2be/followers","following_url":"https://api.github.com/users/micky2be/following{/other_user}","gists_url":"https://api.github.com/users/micky2be/gists{/gist_id}","starred_url":"https://api.github.com/users/micky2be/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micky2be/subscriptions","organizations_url":"https://api.github.com/users/micky2be/orgs","repos_url":"https://api.github.com/users/micky2be/repos","events_url":"https://api.github.com/users/micky2be/events{/privacy}","received_events_url":"https://api.github.com/users/micky2be/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/micky2be/wui-Dom","description":"JavaScripted and eventy DOM","fork":true,"url":"https://api.github.com/repos/micky2be/wui-Dom","forks_url":"https://api.github.com/repos/micky2be/wui-Dom/forks","keys_url":"https://api.github.com/repos/micky2be/wui-Dom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/micky2be/wui-Dom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/micky2be/wui-Dom/teams","hooks_url":"https://api.github.com/repos/micky2be/wui-Dom/hooks","issue_events_url":"https://api.github.com/repos/micky2be/wui-Dom/issues/events{/number}","events_url":"https://api.github.com/repos/micky2be/wui-Dom/events","assignees_url":"https://api.github.com/repos/micky2be/wui-Dom/assignees{/user}","branches_url":"https://api.github.com/repos/micky2be/wui-Dom/branches{/branch}","tags_url":"https://api.github.com/repos/micky2be/wui-Dom/tags","blobs_url":"https://api.github.com/repos/micky2be/wui-Dom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/micky2be/wui-Dom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/micky2be/wui-Dom/git/refs{/sha}","trees_url":"https://api.github.com/repos/micky2be/wui-Dom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/micky2be/wui-Dom/statuses/{sha}","languages_url":"https://api.github.com/repos/micky2be/wui-Dom/languages","stargazers_url":"https://api.github.com/repos/micky2be/wui-Dom/stargazers","contributors_url":"https://api.github.com/repos/micky2be/wui-Dom/contributors","subscribers_url":"https://api.github.com/repos/micky2be/wui-Dom/subscribers","subscription_url":"https://api.github.com/repos/micky2be/wui-Dom/subscription","commits_url":"https://api.github.com/repos/micky2be/wui-Dom/commits{/sha}","git_commits_url":"https://api.github.com/repos/micky2be/wui-Dom/git/commits{/sha}","comments_url":"https://api.github.com/repos/micky2be/wui-Dom/comments{/number}","issue_comment_url":"https://api.github.com/repos/micky2be/wui-Dom/issues/comments{/number}","contents_url":"https://api.github.com/repos/micky2be/wui-Dom/contents/{+path}","compare_url":"https://api.github.com/repos/micky2be/wui-Dom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/micky2be/wui-Dom/merges","archive_url":"https://api.github.com/repos/micky2be/wui-Dom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/micky2be/wui-Dom/downloads","issues_url":"https://api.github.com/repos/micky2be/wui-Dom/issues{/number}","pulls_url":"https://api.github.com/repos/micky2be/wui-Dom/pulls{/number}","milestones_url":"https://api.github.com/repos/micky2be/wui-Dom/milestones{/number}","notifications_url":"https://api.github.com/repos/micky2be/wui-Dom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/micky2be/wui-Dom/labels{/name}","releases_url":"https://api.github.com/repos/micky2be/wui-Dom/releases{/id}","created_at":"2015-04-13T01:24:26Z","updated_at":"2015-04-13T01:24:59Z","pushed_at":"2015-06-22T01:38:02Z","git_url":"git://github.com/micky2be/wui-Dom.git","ssh_url":"git@github.com:micky2be/wui-Dom.git","clone_url":"https://github.com/micky2be/wui-Dom.git","svn_url":"https://github.com/micky2be/wui-Dom","homepage":"","size":248,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Wizcorp:master","ref":"master","sha":"01fed89b857646aadb7bb9e845b55db2ae13fc87","user":{"login":"Wizcorp","id":592346,"avatar_url":"https://avatars.githubusercontent.com/u/592346?v=3","gravatar_id":"","url":"https://api.github.com/users/Wizcorp","html_url":"https://github.com/Wizcorp","followers_url":"https://api.github.com/users/Wizcorp/followers","following_url":"https://api.github.com/users/Wizcorp/following{/other_user}","gists_url":"https://api.github.com/users/Wizcorp/gists{/gist_id}","starred_url":"https://api.github.com/users/Wizcorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wizcorp/subscriptions","organizations_url":"https://api.github.com/users/Wizcorp/orgs","repos_url":"https://api.github.com/users/Wizcorp/repos","events_url":"https://api.github.com/users/Wizcorp/events{/privacy}","received_events_url":"https://api.github.com/users/Wizcorp/received_events","type":"Organization","site_admin":false},"repo":{"id":16451132,"name":"wui-Dom","full_name":"Wizcorp/wui-Dom","owner":{"login":"Wizcorp","id":592346,"avatar_url":"https://avatars.githubusercontent.com/u/592346?v=3","gravatar_id":"","url":"https://api.github.com/users/Wizcorp","html_url":"https://github.com/Wizcorp","followers_url":"https://api.github.com/users/Wizcorp/followers","following_url":"https://api.github.com/users/Wizcorp/following{/other_user}","gists_url":"https://api.github.com/users/Wizcorp/gists{/gist_id}","starred_url":"https://api.github.com/users/Wizcorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wizcorp/subscriptions","organizations_url":"https://api.github.com/users/Wizcorp/orgs","repos_url":"https://api.github.com/users/Wizcorp/repos","events_url":"https://api.github.com/users/Wizcorp/events{/privacy}","received_events_url":"https://api.github.com/users/Wizcorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wizcorp/wui-Dom","description":"JavaScripted and eventy DOM","fork":false,"url":"https://api.github.com/repos/Wizcorp/wui-Dom","forks_url":"https://api.github.com/repos/Wizcorp/wui-Dom/forks","keys_url":"https://api.github.com/repos/Wizcorp/wui-Dom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wizcorp/wui-Dom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wizcorp/wui-Dom/teams","hooks_url":"https://api.github.com/repos/Wizcorp/wui-Dom/hooks","issue_events_url":"https://api.github.com/repos/Wizcorp/wui-Dom/issues/events{/number}","events_url":"https://api.github.com/repos/Wizcorp/wui-Dom/events","assignees_url":"https://api.github.com/repos/Wizcorp/wui-Dom/assignees{/user}","branches_url":"https://api.github.com/repos/Wizcorp/wui-Dom/branches{/branch}","tags_url":"https://api.github.com/repos/Wizcorp/wui-Dom/tags","blobs_url":"https://api.github.com/repos/Wizcorp/wui-Dom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wizcorp/wui-Dom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wizcorp/wui-Dom/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wizcorp/wui-Dom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wizcorp/wui-Dom/statuses/{sha}","languages_url":"https://api.github.com/repos/Wizcorp/wui-Dom/languages","stargazers_url":"https://api.github.com/repos/Wizcorp/wui-Dom/stargazers","contributors_url":"https://api.github.com/repos/Wizcorp/wui-Dom/contributors","subscribers_url":"https://api.github.com/repos/Wizcorp/wui-Dom/subscribers","subscription_url":"https://api.github.com/repos/Wizcorp/wui-Dom/subscription","commits_url":"https://api.github.com/repos/Wizcorp/wui-Dom/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wizcorp/wui-Dom/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wizcorp/wui-Dom/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wizcorp/wui-Dom/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wizcorp/wui-Dom/contents/{+path}","compare_url":"https://api.github.com/repos/Wizcorp/wui-Dom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wizcorp/wui-Dom/merges","archive_url":"https://api.github.com/repos/Wizcorp/wui-Dom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wizcorp/wui-Dom/downloads","issues_url":"https://api.github.com/repos/Wizcorp/wui-Dom/issues{/number}","pulls_url":"https://api.github.com/repos/Wizcorp/wui-Dom/pulls{/number}","milestones_url":"https://api.github.com/repos/Wizcorp/wui-Dom/milestones{/number}","notifications_url":"https://api.github.com/repos/Wizcorp/wui-Dom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wizcorp/wui-Dom/labels{/name}","releases_url":"https://api.github.com/repos/Wizcorp/wui-Dom/releases{/id}","created_at":"2014-02-02T08:05:27Z","updated_at":"2015-04-20T02:20:57Z","pushed_at":"2015-06-22T01:50:41Z","git_url":"git://github.com/Wizcorp/wui-Dom.git","ssh_url":"git@github.com:Wizcorp/wui-Dom.git","clone_url":"https://github.com/Wizcorp/wui-Dom.git","svn_url":"https://github.com/Wizcorp/wui-Dom","homepage":"","size":543,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":7,"forks":3,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Wizcorp/wui-Dom/pulls/52"},"html":{"href":"https://github.com/Wizcorp/wui-Dom/pull/52"},"issue":{"href":"https://api.github.com/repos/Wizcorp/wui-Dom/issues/52"},"comments":{"href":"https://api.github.com/repos/Wizcorp/wui-Dom/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/Wizcorp/wui-Dom/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/Wizcorp/wui-Dom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wizcorp/wui-Dom/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/Wizcorp/wui-Dom/statuses/d6362202aae85d56ad18a080ea645d03bc6fbed2"}}}}