{"action":"created","comment":{"url":"https://api.github.com/repos/twitter/scalding/pulls/comments/31266622","id":31266622,"diff_hunk":"@@ -66,37 +49,26 @@ object TypedParquetSink {\n   /**\n    * Create typed parquet sink.\n    * Here is an example:\n-   *\n-   *  case class SampleClassB(string: String, int: Int, double: Option[Double], a: SampleClassA)\n-   *\n-   *  class WriteSupport extends ParquetWriteSupport[SampleClassB] {\n-   *    import com.twitter.scalding.parquet.tuple.macros.Macros._\n-   *\n-   *    override def writeRecord(r: SampleClassB, rc: RecordConsumer, schema: MessageType): Unit =\n-   *      caseClassWriteSupport[SampleClassB](r, rc, schema)\n-   *    override val rootSchema: String = caseClassParquetSchema[SampleClassB]\n-   *  }\n-   *\n-   *  val sink = TypedParquetSink[SampleClassB, WriteSupport](Seq(outputPath))\n+   *  import com.twitter.scalding.parquet.tuple.macros.Macros._\n+   *  val sink = TypedParquetSink[SampleClass](Seq(outputPath),\n+   *    caseClassParquetWriteSupport[SampleClass](caseClassParquetSchema[SampleClass]))\n    *\n    * @param paths paths of parquet I/O\n-   * @param t Read support type tag\n    * @tparam T Tuple type\n-   * @tparam W Write support type\n    * @return a typed parquet source.\n    */\n-  def apply[T, W <: ParquetWriteSupport[T]](paths: Seq[String])(implicit t: ClassTag[W]) =\n-    new TypedFixedPathParquetTuple[T, ParquetReadSupport[T], W](paths, null, t.runtimeClass.asInstanceOf[Class[W]])\n+  def apply[T](paths: Seq[String], writeSupport: ParquetWriteSupport[T]) =\n+    new TypedFixedPathParquetTuple[T](paths, null, writeSupport)\n }\n \n /**\n  * Typed Parquet tuple source/sink.\n  */\n-trait TypedParquet[T, R <: ParquetReadSupport[T], W <: ParquetWriteSupport[T]] extends FileSource with Mappable[T]\n+trait TypedParquet[T] extends FileSource with Mappable[T]\n   with TypedSink[T] with HasFilterPredicate {\n \n-  val readSupport: Class[R]\n-  val writeSupport: Class[W]\n+  val readSupport: ParquetReadSupport[T]","path":"scalding-parquet/src/main/scala/com/twitter/scalding/parquet/tuple/TypedParquet.scala","position":110,"original_position":110,"commit_id":"60e7390ea018f291728aab65414e125108541e79","original_commit_id":"60e7390ea018f291728aab65414e125108541e79","user":{"login":"johnynek","id":67958,"avatar_url":"https://avatars.githubusercontent.com/u/67958?v=3","gravatar_id":"","url":"https://api.github.com/users/johnynek","html_url":"https://github.com/johnynek","followers_url":"https://api.github.com/users/johnynek/followers","following_url":"https://api.github.com/users/johnynek/following{/other_user}","gists_url":"https://api.github.com/users/johnynek/gists{/gist_id}","starred_url":"https://api.github.com/users/johnynek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnynek/subscriptions","organizations_url":"https://api.github.com/users/johnynek/orgs","repos_url":"https://api.github.com/users/johnynek/repos","events_url":"https://api.github.com/users/johnynek/events{/privacy}","received_events_url":"https://api.github.com/users/johnynek/received_events","type":"User","site_admin":false},"body":"generally in scala it is better to make `def` abstract. making an abstract `val` can cause some issues (val init order bug).","created_at":"2015-05-28T19:02:52Z","updated_at":"2015-05-28T19:02:52Z","html_url":"https://github.com/twitter/scalding/pull/1303#discussion_r31266622","pull_request_url":"https://api.github.com/repos/twitter/scalding/pulls/1303","_links":{"self":{"href":"https://api.github.com/repos/twitter/scalding/pulls/comments/31266622"},"html":{"href":"https://github.com/twitter/scalding/pull/1303#discussion_r31266622"},"pull_request":{"href":"https://api.github.com/repos/twitter/scalding/pulls/1303"}}},"pull_request":{"url":"https://api.github.com/repos/twitter/scalding/pulls/1303","id":36159344,"html_url":"https://github.com/twitter/scalding/pull/1303","diff_url":"https://github.com/twitter/scalding/pull/1303.diff","patch_url":"https://github.com/twitter/scalding/pull/1303.patch","issue_url":"https://api.github.com/repos/twitter/scalding/issues/1303","number":1303,"state":"open","locked":false,"title":"Improve TypedParquetTuple #1302","user":{"login":"JiJiTang","id":10888658,"avatar_url":"https://avatars.githubusercontent.com/u/10888658?v=3","gravatar_id":"","url":"https://api.github.com/users/JiJiTang","html_url":"https://github.com/JiJiTang","followers_url":"https://api.github.com/users/JiJiTang/followers","following_url":"https://api.github.com/users/JiJiTang/following{/other_user}","gists_url":"https://api.github.com/users/JiJiTang/gists{/gist_id}","starred_url":"https://api.github.com/users/JiJiTang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JiJiTang/subscriptions","organizations_url":"https://api.github.com/users/JiJiTang/orgs","repos_url":"https://api.github.com/users/JiJiTang/repos","events_url":"https://api.github.com/users/JiJiTang/events{/privacy}","received_events_url":"https://api.github.com/users/JiJiTang/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-05-25T21:59:00Z","updated_at":"2015-05-28T19:02:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d1bd23812f93f3728a53008abe441606cf4c5b5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/twitter/scalding/pulls/1303/commits","review_comments_url":"https://api.github.com/repos/twitter/scalding/pulls/1303/comments","review_comment_url":"https://api.github.com/repos/twitter/scalding/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twitter/scalding/issues/1303/comments","statuses_url":"https://api.github.com/repos/twitter/scalding/statuses/60e7390ea018f291728aab65414e125108541e79","head":{"label":"JiJiTang:develop","ref":"develop","sha":"60e7390ea018f291728aab65414e125108541e79","user":{"login":"JiJiTang","id":10888658,"avatar_url":"https://avatars.githubusercontent.com/u/10888658?v=3","gravatar_id":"","url":"https://api.github.com/users/JiJiTang","html_url":"https://github.com/JiJiTang","followers_url":"https://api.github.com/users/JiJiTang/followers","following_url":"https://api.github.com/users/JiJiTang/following{/other_user}","gists_url":"https://api.github.com/users/JiJiTang/gists{/gist_id}","starred_url":"https://api.github.com/users/JiJiTang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JiJiTang/subscriptions","organizations_url":"https://api.github.com/users/JiJiTang/orgs","repos_url":"https://api.github.com/users/JiJiTang/repos","events_url":"https://api.github.com/users/JiJiTang/events{/privacy}","received_events_url":"https://api.github.com/users/JiJiTang/received_events","type":"User","site_admin":false},"repo":{"id":30433237,"name":"scalding","full_name":"JiJiTang/scalding","owner":{"login":"JiJiTang","id":10888658,"avatar_url":"https://avatars.githubusercontent.com/u/10888658?v=3","gravatar_id":"","url":"https://api.github.com/users/JiJiTang","html_url":"https://github.com/JiJiTang","followers_url":"https://api.github.com/users/JiJiTang/followers","following_url":"https://api.github.com/users/JiJiTang/following{/other_user}","gists_url":"https://api.github.com/users/JiJiTang/gists{/gist_id}","starred_url":"https://api.github.com/users/JiJiTang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JiJiTang/subscriptions","organizations_url":"https://api.github.com/users/JiJiTang/orgs","repos_url":"https://api.github.com/users/JiJiTang/repos","events_url":"https://api.github.com/users/JiJiTang/events{/privacy}","received_events_url":"https://api.github.com/users/JiJiTang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JiJiTang/scalding","description":"A Scala API for Cascading","fork":true,"url":"https://api.github.com/repos/JiJiTang/scalding","forks_url":"https://api.github.com/repos/JiJiTang/scalding/forks","keys_url":"https://api.github.com/repos/JiJiTang/scalding/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JiJiTang/scalding/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JiJiTang/scalding/teams","hooks_url":"https://api.github.com/repos/JiJiTang/scalding/hooks","issue_events_url":"https://api.github.com/repos/JiJiTang/scalding/issues/events{/number}","events_url":"https://api.github.com/repos/JiJiTang/scalding/events","assignees_url":"https://api.github.com/repos/JiJiTang/scalding/assignees{/user}","branches_url":"https://api.github.com/repos/JiJiTang/scalding/branches{/branch}","tags_url":"https://api.github.com/repos/JiJiTang/scalding/tags","blobs_url":"https://api.github.com/repos/JiJiTang/scalding/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JiJiTang/scalding/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JiJiTang/scalding/git/refs{/sha}","trees_url":"https://api.github.com/repos/JiJiTang/scalding/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JiJiTang/scalding/statuses/{sha}","languages_url":"https://api.github.com/repos/JiJiTang/scalding/languages","stargazers_url":"https://api.github.com/repos/JiJiTang/scalding/stargazers","contributors_url":"https://api.github.com/repos/JiJiTang/scalding/contributors","subscribers_url":"https://api.github.com/repos/JiJiTang/scalding/subscribers","subscription_url":"https://api.github.com/repos/JiJiTang/scalding/subscription","commits_url":"https://api.github.com/repos/JiJiTang/scalding/commits{/sha}","git_commits_url":"https://api.github.com/repos/JiJiTang/scalding/git/commits{/sha}","comments_url":"https://api.github.com/repos/JiJiTang/scalding/comments{/number}","issue_comment_url":"https://api.github.com/repos/JiJiTang/scalding/issues/comments{/number}","contents_url":"https://api.github.com/repos/JiJiTang/scalding/contents/{+path}","compare_url":"https://api.github.com/repos/JiJiTang/scalding/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JiJiTang/scalding/merges","archive_url":"https://api.github.com/repos/JiJiTang/scalding/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JiJiTang/scalding/downloads","issues_url":"https://api.github.com/repos/JiJiTang/scalding/issues{/number}","pulls_url":"https://api.github.com/repos/JiJiTang/scalding/pulls{/number}","milestones_url":"https://api.github.com/repos/JiJiTang/scalding/milestones{/number}","notifications_url":"https://api.github.com/repos/JiJiTang/scalding/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JiJiTang/scalding/labels{/name}","releases_url":"https://api.github.com/repos/JiJiTang/scalding/releases{/id}","created_at":"2015-02-06T21:12:04Z","updated_at":"2015-04-21T20:18:12Z","pushed_at":"2015-05-25T21:56:58Z","git_url":"git://github.com/JiJiTang/scalding.git","ssh_url":"git@github.com:JiJiTang/scalding.git","clone_url":"https://github.com/JiJiTang/scalding.git","svn_url":"https://github.com/JiJiTang/scalding","homepage":"http://twitter.com/scalding","size":12771,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"twitter:develop","ref":"develop","sha":"bd8cd5159664c0fb14f883fc15c6093de5a28289","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":3146558,"name":"scalding","full_name":"twitter/scalding","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/scalding","description":"A Scala API for Cascading","fork":false,"url":"https://api.github.com/repos/twitter/scalding","forks_url":"https://api.github.com/repos/twitter/scalding/forks","keys_url":"https://api.github.com/repos/twitter/scalding/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/scalding/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/scalding/teams","hooks_url":"https://api.github.com/repos/twitter/scalding/hooks","issue_events_url":"https://api.github.com/repos/twitter/scalding/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/scalding/events","assignees_url":"https://api.github.com/repos/twitter/scalding/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/scalding/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/scalding/tags","blobs_url":"https://api.github.com/repos/twitter/scalding/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/scalding/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/scalding/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/scalding/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/scalding/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/scalding/languages","stargazers_url":"https://api.github.com/repos/twitter/scalding/stargazers","contributors_url":"https://api.github.com/repos/twitter/scalding/contributors","subscribers_url":"https://api.github.com/repos/twitter/scalding/subscribers","subscription_url":"https://api.github.com/repos/twitter/scalding/subscription","commits_url":"https://api.github.com/repos/twitter/scalding/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/scalding/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/scalding/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/scalding/issues/comments{/number}","contents_url":"https://api.github.com/repos/twitter/scalding/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/scalding/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/scalding/merges","archive_url":"https://api.github.com/repos/twitter/scalding/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/scalding/downloads","issues_url":"https://api.github.com/repos/twitter/scalding/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/scalding/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/scalding/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/scalding/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/scalding/labels{/name}","releases_url":"https://api.github.com/repos/twitter/scalding/releases{/id}","created_at":"2012-01-10T16:22:08Z","updated_at":"2015-05-27T23:11:19Z","pushed_at":"2015-05-28T18:41:55Z","git_url":"git://github.com/twitter/scalding.git","ssh_url":"git@github.com:twitter/scalding.git","clone_url":"https://github.com/twitter/scalding.git","svn_url":"https://github.com/twitter/scalding","homepage":"http://twitter.com/scalding","size":24235,"stargazers_count":2095,"watchers_count":2095,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":475,"mirror_url":null,"open_issues_count":223,"forks":475,"open_issues":223,"watchers":2095,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter/scalding/pulls/1303"},"html":{"href":"https://github.com/twitter/scalding/pull/1303"},"issue":{"href":"https://api.github.com/repos/twitter/scalding/issues/1303"},"comments":{"href":"https://api.github.com/repos/twitter/scalding/issues/1303/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter/scalding/pulls/1303/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter/scalding/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twitter/scalding/pulls/1303/commits"},"statuses":{"href":"https://api.github.com/repos/twitter/scalding/statuses/60e7390ea018f291728aab65414e125108541e79"}}}}