{"action":"closed","number":10,"pull_request":{"url":"https://api.github.com/repos/masylum/Backbone.Subset/pulls/10","id":4073792,"html_url":"https://github.com/masylum/Backbone.Subset/pull/10","diff_url":"https://github.com/masylum/Backbone.Subset/pull/10.diff","patch_url":"https://github.com/masylum/Backbone.Subset/pull/10.patch","issue_url":"https://api.github.com/repos/masylum/Backbone.Subset/issues/10","number":10,"state":"closed","locked":false,"title":"Compatibility with Backbone 0.9.10 (fixes #9)","user":{"login":"bgarret","id":231680,"avatar_url":"https://avatars.githubusercontent.com/u/231680?v=3","gravatar_id":"","url":"https://api.github.com/users/bgarret","html_url":"https://github.com/bgarret","followers_url":"https://api.github.com/users/bgarret/followers","following_url":"https://api.github.com/users/bgarret/following{/other_user}","gists_url":"https://api.github.com/users/bgarret/gists{/gist_id}","starred_url":"https://api.github.com/users/bgarret/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgarret/subscriptions","organizations_url":"https://api.github.com/users/bgarret/orgs","repos_url":"https://api.github.com/users/bgarret/repos","events_url":"https://api.github.com/users/bgarret/events{/privacy}","received_events_url":"https://api.github.com/users/bgarret/received_events","type":"User","site_admin":false},"body":"There were two additional problems besides the one in issue #9 :\r\n* `this._byCid` does not exist anymore in 0.9.10\r\n* `!model.id` breaks with a numeric id set to `0`\r\n\r\nUsing the `get` method here is much cleaner as it is guaranteed to abstract between the different versions of Backbone. Besides, not depending on private interfaces is always good :wink: \r\n\r\nAs @Crisfole said, `this.models` was not initialized properly.\r\n\r\nThe test suite now passes with both Backbone 0.9.10 and 0.5.3.","created_at":"2013-02-10T11:04:55Z","updated_at":"2015-01-28T16:29:59Z","closed_at":"2015-01-28T16:29:59Z","merged_at":null,"merge_commit_sha":"ac51f07ad151ea0a870a1502cc57845d82665bed","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/masylum/Backbone.Subset/pulls/10/commits","review_comments_url":"https://api.github.com/repos/masylum/Backbone.Subset/pulls/10/comments","review_comment_url":"https://api.github.com/repos/masylum/Backbone.Subset/pulls/comments/{number}","comments_url":"https://api.github.com/repos/masylum/Backbone.Subset/issues/10/comments","statuses_url":"https://api.github.com/repos/masylum/Backbone.Subset/statuses/4afa83b652f40c827cf5b6557e653e1a8dbbe42c","head":{"label":"bgarret:latest-backbone","ref":"latest-backbone","sha":"4afa83b652f40c827cf5b6557e653e1a8dbbe42c","user":{"login":"bgarret","id":231680,"avatar_url":"https://avatars.githubusercontent.com/u/231680?v=3","gravatar_id":"","url":"https://api.github.com/users/bgarret","html_url":"https://github.com/bgarret","followers_url":"https://api.github.com/users/bgarret/followers","following_url":"https://api.github.com/users/bgarret/following{/other_user}","gists_url":"https://api.github.com/users/bgarret/gists{/gist_id}","starred_url":"https://api.github.com/users/bgarret/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgarret/subscriptions","organizations_url":"https://api.github.com/users/bgarret/orgs","repos_url":"https://api.github.com/users/bgarret/repos","events_url":"https://api.github.com/users/bgarret/events{/privacy}","received_events_url":"https://api.github.com/users/bgarret/received_events","type":"User","site_admin":false},"repo":null},"base":{"label":"masylum:master","ref":"master","sha":"3fe14c5a3f4fcb4962c68358e45048272376c44e","user":{"login":"masylum","id":28248,"avatar_url":"https://avatars.githubusercontent.com/u/28248?v=3","gravatar_id":"","url":"https://api.github.com/users/masylum","html_url":"https://github.com/masylum","followers_url":"https://api.github.com/users/masylum/followers","following_url":"https://api.github.com/users/masylum/following{/other_user}","gists_url":"https://api.github.com/users/masylum/gists{/gist_id}","starred_url":"https://api.github.com/users/masylum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masylum/subscriptions","organizations_url":"https://api.github.com/users/masylum/orgs","repos_url":"https://api.github.com/users/masylum/repos","events_url":"https://api.github.com/users/masylum/events{/privacy}","received_events_url":"https://api.github.com/users/masylum/received_events","type":"User","site_admin":false},"repo":{"id":2849341,"name":"Backbone.Subset","full_name":"masylum/Backbone.Subset","owner":{"login":"masylum","id":28248,"avatar_url":"https://avatars.githubusercontent.com/u/28248?v=3","gravatar_id":"","url":"https://api.github.com/users/masylum","html_url":"https://github.com/masylum","followers_url":"https://api.github.com/users/masylum/followers","following_url":"https://api.github.com/users/masylum/following{/other_user}","gists_url":"https://api.github.com/users/masylum/gists{/gist_id}","starred_url":"https://api.github.com/users/masylum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masylum/subscriptions","organizations_url":"https://api.github.com/users/masylum/orgs","repos_url":"https://api.github.com/users/masylum/repos","events_url":"https://api.github.com/users/masylum/events{/privacy}","received_events_url":"https://api.github.com/users/masylum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/masylum/Backbone.Subset","description":"Provides a collection-like constructor that allows you create a collection that is subset from a parent one","fork":false,"url":"https://api.github.com/repos/masylum/Backbone.Subset","forks_url":"https://api.github.com/repos/masylum/Backbone.Subset/forks","keys_url":"https://api.github.com/repos/masylum/Backbone.Subset/keys{/key_id}","collaborators_url":"https://api.github.com/repos/masylum/Backbone.Subset/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/masylum/Backbone.Subset/teams","hooks_url":"https://api.github.com/repos/masylum/Backbone.Subset/hooks","issue_events_url":"https://api.github.com/repos/masylum/Backbone.Subset/issues/events{/number}","events_url":"https://api.github.com/repos/masylum/Backbone.Subset/events","assignees_url":"https://api.github.com/repos/masylum/Backbone.Subset/assignees{/user}","branches_url":"https://api.github.com/repos/masylum/Backbone.Subset/branches{/branch}","tags_url":"https://api.github.com/repos/masylum/Backbone.Subset/tags","blobs_url":"https://api.github.com/repos/masylum/Backbone.Subset/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/masylum/Backbone.Subset/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/masylum/Backbone.Subset/git/refs{/sha}","trees_url":"https://api.github.com/repos/masylum/Backbone.Subset/git/trees{/sha}","statuses_url":"https://api.github.com/repos/masylum/Backbone.Subset/statuses/{sha}","languages_url":"https://api.github.com/repos/masylum/Backbone.Subset/languages","stargazers_url":"https://api.github.com/repos/masylum/Backbone.Subset/stargazers","contributors_url":"https://api.github.com/repos/masylum/Backbone.Subset/contributors","subscribers_url":"https://api.github.com/repos/masylum/Backbone.Subset/subscribers","subscription_url":"https://api.github.com/repos/masylum/Backbone.Subset/subscription","commits_url":"https://api.github.com/repos/masylum/Backbone.Subset/commits{/sha}","git_commits_url":"https://api.github.com/repos/masylum/Backbone.Subset/git/commits{/sha}","comments_url":"https://api.github.com/repos/masylum/Backbone.Subset/comments{/number}","issue_comment_url":"https://api.github.com/repos/masylum/Backbone.Subset/issues/comments/{number}","contents_url":"https://api.github.com/repos/masylum/Backbone.Subset/contents/{+path}","compare_url":"https://api.github.com/repos/masylum/Backbone.Subset/compare/{base}...{head}","merges_url":"https://api.github.com/repos/masylum/Backbone.Subset/merges","archive_url":"https://api.github.com/repos/masylum/Backbone.Subset/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/masylum/Backbone.Subset/downloads","issues_url":"https://api.github.com/repos/masylum/Backbone.Subset/issues{/number}","pulls_url":"https://api.github.com/repos/masylum/Backbone.Subset/pulls{/number}","milestones_url":"https://api.github.com/repos/masylum/Backbone.Subset/milestones{/number}","notifications_url":"https://api.github.com/repos/masylum/Backbone.Subset/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/masylum/Backbone.Subset/labels{/name}","releases_url":"https://api.github.com/repos/masylum/Backbone.Subset/releases{/id}","created_at":"2011-11-25T11:48:25Z","updated_at":"2014-10-02T18:31:33Z","pushed_at":"2012-09-28T17:19:47Z","git_url":"git://github.com/masylum/Backbone.Subset.git","ssh_url":"git@github.com:masylum/Backbone.Subset.git","clone_url":"https://github.com/masylum/Backbone.Subset.git","svn_url":"https://github.com/masylum/Backbone.Subset","homepage":"","size":4235,"stargazers_count":90,"watchers_count":90,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":6,"forks":20,"open_issues":6,"watchers":90,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/masylum/Backbone.Subset/pulls/10"},"html":{"href":"https://github.com/masylum/Backbone.Subset/pull/10"},"issue":{"href":"https://api.github.com/repos/masylum/Backbone.Subset/issues/10"},"comments":{"href":"https://api.github.com/repos/masylum/Backbone.Subset/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/masylum/Backbone.Subset/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/masylum/Backbone.Subset/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/masylum/Backbone.Subset/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/masylum/Backbone.Subset/statuses/4afa83b652f40c827cf5b6557e653e1a8dbbe42c"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"commits":1,"additions":3,"deletions":2,"changed_files":1}}