{"action":"created","comment":{"url":"https://api.github.com/repos/salsify/arc-furnace/pulls/comments/47296689","id":47296689,"diff_hunk":"@@ -38,7 +38,8 @@ def self.hash_node(node_id, type: ArcFurnace::Hash, params:)\n     # for the source.\n     def self.source(node_id, type:, params:)\n       raise \"Source #{type} is not a Source!\" unless type <= Source\n-      define_intermediate(node_id, type: type, params: params)\n+      instance = define_intermediate(node_id, type: type, params: params)","path":"lib/arc-furnace/pipeline.rb","position":5,"original_position":5,"commit_id":"81a6576b8b3931931c3ff633a09f4281f5fe7c9d","original_commit_id":"81a6576b8b3931931c3ff633a09f4281f5fe7c9d","user":{"login":"dspangen","id":1711045,"avatar_url":"https://avatars.githubusercontent.com/u/1711045?v=3","gravatar_id":"","url":"https://api.github.com/users/dspangen","html_url":"https://github.com/dspangen","followers_url":"https://api.github.com/users/dspangen/followers","following_url":"https://api.github.com/users/dspangen/following{/other_user}","gists_url":"https://api.github.com/users/dspangen/gists{/gist_id}","starred_url":"https://api.github.com/users/dspangen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dspangen/subscriptions","organizations_url":"https://api.github.com/users/dspangen/orgs","repos_url":"https://api.github.com/users/dspangen/repos","events_url":"https://api.github.com/users/dspangen/events{/privacy}","received_events_url":"https://api.github.com/users/dspangen/received_events","type":"User","site_admin":false},"body":"Have we verified that this provides enough information? I can see how this would provide a more local stacktrace (and would tell you what node in the `Pipeline` raised an issue, but I think we'd rather want to capture the options that the node was constructed with...?","created_at":"2015-12-10T22:30:53Z","updated_at":"2015-12-10T22:30:53Z","html_url":"https://github.com/salsify/arc-furnace/pull/10#discussion_r47296689","pull_request_url":"https://api.github.com/repos/salsify/arc-furnace/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/salsify/arc-furnace/pulls/comments/47296689"},"html":{"href":"https://github.com/salsify/arc-furnace/pull/10#discussion_r47296689"},"pull_request":{"href":"https://api.github.com/repos/salsify/arc-furnace/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/salsify/arc-furnace/pulls/10","id":53324388,"html_url":"https://github.com/salsify/arc-furnace/pull/10","diff_url":"https://github.com/salsify/arc-furnace/pull/10.diff","patch_url":"https://github.com/salsify/arc-furnace/pull/10.patch","issue_url":"https://api.github.com/repos/salsify/arc-furnace/issues/10","number":10,"state":"open","locked":false,"title":"added error handling that takes a block for source so that malformed …","user":{"login":"jford8820","id":11723485,"avatar_url":"https://avatars.githubusercontent.com/u/11723485?v=3","gravatar_id":"","url":"https://api.github.com/users/jford8820","html_url":"https://github.com/jford8820","followers_url":"https://api.github.com/users/jford8820/followers","following_url":"https://api.github.com/users/jford8820/following{/other_user}","gists_url":"https://api.github.com/users/jford8820/gists{/gist_id}","starred_url":"https://api.github.com/users/jford8820/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jford8820/subscriptions","organizations_url":"https://api.github.com/users/jford8820/orgs","repos_url":"https://api.github.com/users/jford8820/repos","events_url":"https://api.github.com/users/jford8820/events{/privacy}","received_events_url":"https://api.github.com/users/jford8820/received_events","type":"User","site_admin":false},"body":"…csv errors waterfall the stack trace","created_at":"2015-12-10T22:06:15Z","updated_at":"2015-12-10T22:30:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d8327689ebccd998ba970479c22d408c41622e5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/salsify/arc-furnace/pulls/10/commits","review_comments_url":"https://api.github.com/repos/salsify/arc-furnace/pulls/10/comments","review_comment_url":"https://api.github.com/repos/salsify/arc-furnace/pulls/comments{/number}","comments_url":"https://api.github.com/repos/salsify/arc-furnace/issues/10/comments","statuses_url":"https://api.github.com/repos/salsify/arc-furnace/statuses/81a6576b8b3931931c3ff633a09f4281f5fe7c9d","head":{"label":"salsify:error-handling-with-block","ref":"error-handling-with-block","sha":"81a6576b8b3931931c3ff633a09f4281f5fe7c9d","user":{"login":"salsify","id":2165267,"avatar_url":"https://avatars.githubusercontent.com/u/2165267?v=3","gravatar_id":"","url":"https://api.github.com/users/salsify","html_url":"https://github.com/salsify","followers_url":"https://api.github.com/users/salsify/followers","following_url":"https://api.github.com/users/salsify/following{/other_user}","gists_url":"https://api.github.com/users/salsify/gists{/gist_id}","starred_url":"https://api.github.com/users/salsify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salsify/subscriptions","organizations_url":"https://api.github.com/users/salsify/orgs","repos_url":"https://api.github.com/users/salsify/repos","events_url":"https://api.github.com/users/salsify/events{/privacy}","received_events_url":"https://api.github.com/users/salsify/received_events","type":"Organization","site_admin":false},"repo":{"id":39085610,"name":"arc-furnace","full_name":"salsify/arc-furnace","owner":{"login":"salsify","id":2165267,"avatar_url":"https://avatars.githubusercontent.com/u/2165267?v=3","gravatar_id":"","url":"https://api.github.com/users/salsify","html_url":"https://github.com/salsify","followers_url":"https://api.github.com/users/salsify/followers","following_url":"https://api.github.com/users/salsify/following{/other_user}","gists_url":"https://api.github.com/users/salsify/gists{/gist_id}","starred_url":"https://api.github.com/users/salsify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salsify/subscriptions","organizations_url":"https://api.github.com/users/salsify/orgs","repos_url":"https://api.github.com/users/salsify/repos","events_url":"https://api.github.com/users/salsify/events{/privacy}","received_events_url":"https://api.github.com/users/salsify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/salsify/arc-furnace","description":"Need to melt, weave, and meld information together? Arc furnace will fuse anything you've got.","fork":false,"url":"https://api.github.com/repos/salsify/arc-furnace","forks_url":"https://api.github.com/repos/salsify/arc-furnace/forks","keys_url":"https://api.github.com/repos/salsify/arc-furnace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/salsify/arc-furnace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/salsify/arc-furnace/teams","hooks_url":"https://api.github.com/repos/salsify/arc-furnace/hooks","issue_events_url":"https://api.github.com/repos/salsify/arc-furnace/issues/events{/number}","events_url":"https://api.github.com/repos/salsify/arc-furnace/events","assignees_url":"https://api.github.com/repos/salsify/arc-furnace/assignees{/user}","branches_url":"https://api.github.com/repos/salsify/arc-furnace/branches{/branch}","tags_url":"https://api.github.com/repos/salsify/arc-furnace/tags","blobs_url":"https://api.github.com/repos/salsify/arc-furnace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/salsify/arc-furnace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/salsify/arc-furnace/git/refs{/sha}","trees_url":"https://api.github.com/repos/salsify/arc-furnace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/salsify/arc-furnace/statuses/{sha}","languages_url":"https://api.github.com/repos/salsify/arc-furnace/languages","stargazers_url":"https://api.github.com/repos/salsify/arc-furnace/stargazers","contributors_url":"https://api.github.com/repos/salsify/arc-furnace/contributors","subscribers_url":"https://api.github.com/repos/salsify/arc-furnace/subscribers","subscription_url":"https://api.github.com/repos/salsify/arc-furnace/subscription","commits_url":"https://api.github.com/repos/salsify/arc-furnace/commits{/sha}","git_commits_url":"https://api.github.com/repos/salsify/arc-furnace/git/commits{/sha}","comments_url":"https://api.github.com/repos/salsify/arc-furnace/comments{/number}","issue_comment_url":"https://api.github.com/repos/salsify/arc-furnace/issues/comments{/number}","contents_url":"https://api.github.com/repos/salsify/arc-furnace/contents/{+path}","compare_url":"https://api.github.com/repos/salsify/arc-furnace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/salsify/arc-furnace/merges","archive_url":"https://api.github.com/repos/salsify/arc-furnace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/salsify/arc-furnace/downloads","issues_url":"https://api.github.com/repos/salsify/arc-furnace/issues{/number}","pulls_url":"https://api.github.com/repos/salsify/arc-furnace/pulls{/number}","milestones_url":"https://api.github.com/repos/salsify/arc-furnace/milestones{/number}","notifications_url":"https://api.github.com/repos/salsify/arc-furnace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/salsify/arc-furnace/labels{/name}","releases_url":"https://api.github.com/repos/salsify/arc-furnace/releases{/id}","created_at":"2015-07-14T16:07:33Z","updated_at":"2015-10-23T14:53:20Z","pushed_at":"2015-12-10T22:06:15Z","git_url":"git://github.com/salsify/arc-furnace.git","ssh_url":"git@github.com:salsify/arc-furnace.git","clone_url":"https://github.com/salsify/arc-furnace.git","svn_url":"https://github.com/salsify/arc-furnace","homepage":null,"size":93,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":4,"default_branch":"master"}},"base":{"label":"salsify:master","ref":"master","sha":"fc5fbaeca76e67515434dd6069229bc52017151c","user":{"login":"salsify","id":2165267,"avatar_url":"https://avatars.githubusercontent.com/u/2165267?v=3","gravatar_id":"","url":"https://api.github.com/users/salsify","html_url":"https://github.com/salsify","followers_url":"https://api.github.com/users/salsify/followers","following_url":"https://api.github.com/users/salsify/following{/other_user}","gists_url":"https://api.github.com/users/salsify/gists{/gist_id}","starred_url":"https://api.github.com/users/salsify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salsify/subscriptions","organizations_url":"https://api.github.com/users/salsify/orgs","repos_url":"https://api.github.com/users/salsify/repos","events_url":"https://api.github.com/users/salsify/events{/privacy}","received_events_url":"https://api.github.com/users/salsify/received_events","type":"Organization","site_admin":false},"repo":{"id":39085610,"name":"arc-furnace","full_name":"salsify/arc-furnace","owner":{"login":"salsify","id":2165267,"avatar_url":"https://avatars.githubusercontent.com/u/2165267?v=3","gravatar_id":"","url":"https://api.github.com/users/salsify","html_url":"https://github.com/salsify","followers_url":"https://api.github.com/users/salsify/followers","following_url":"https://api.github.com/users/salsify/following{/other_user}","gists_url":"https://api.github.com/users/salsify/gists{/gist_id}","starred_url":"https://api.github.com/users/salsify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salsify/subscriptions","organizations_url":"https://api.github.com/users/salsify/orgs","repos_url":"https://api.github.com/users/salsify/repos","events_url":"https://api.github.com/users/salsify/events{/privacy}","received_events_url":"https://api.github.com/users/salsify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/salsify/arc-furnace","description":"Need to melt, weave, and meld information together? Arc furnace will fuse anything you've got.","fork":false,"url":"https://api.github.com/repos/salsify/arc-furnace","forks_url":"https://api.github.com/repos/salsify/arc-furnace/forks","keys_url":"https://api.github.com/repos/salsify/arc-furnace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/salsify/arc-furnace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/salsify/arc-furnace/teams","hooks_url":"https://api.github.com/repos/salsify/arc-furnace/hooks","issue_events_url":"https://api.github.com/repos/salsify/arc-furnace/issues/events{/number}","events_url":"https://api.github.com/repos/salsify/arc-furnace/events","assignees_url":"https://api.github.com/repos/salsify/arc-furnace/assignees{/user}","branches_url":"https://api.github.com/repos/salsify/arc-furnace/branches{/branch}","tags_url":"https://api.github.com/repos/salsify/arc-furnace/tags","blobs_url":"https://api.github.com/repos/salsify/arc-furnace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/salsify/arc-furnace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/salsify/arc-furnace/git/refs{/sha}","trees_url":"https://api.github.com/repos/salsify/arc-furnace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/salsify/arc-furnace/statuses/{sha}","languages_url":"https://api.github.com/repos/salsify/arc-furnace/languages","stargazers_url":"https://api.github.com/repos/salsify/arc-furnace/stargazers","contributors_url":"https://api.github.com/repos/salsify/arc-furnace/contributors","subscribers_url":"https://api.github.com/repos/salsify/arc-furnace/subscribers","subscription_url":"https://api.github.com/repos/salsify/arc-furnace/subscription","commits_url":"https://api.github.com/repos/salsify/arc-furnace/commits{/sha}","git_commits_url":"https://api.github.com/repos/salsify/arc-furnace/git/commits{/sha}","comments_url":"https://api.github.com/repos/salsify/arc-furnace/comments{/number}","issue_comment_url":"https://api.github.com/repos/salsify/arc-furnace/issues/comments{/number}","contents_url":"https://api.github.com/repos/salsify/arc-furnace/contents/{+path}","compare_url":"https://api.github.com/repos/salsify/arc-furnace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/salsify/arc-furnace/merges","archive_url":"https://api.github.com/repos/salsify/arc-furnace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/salsify/arc-furnace/downloads","issues_url":"https://api.github.com/repos/salsify/arc-furnace/issues{/number}","pulls_url":"https://api.github.com/repos/salsify/arc-furnace/pulls{/number}","milestones_url":"https://api.github.com/repos/salsify/arc-furnace/milestones{/number}","notifications_url":"https://api.github.com/repos/salsify/arc-furnace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/salsify/arc-furnace/labels{/name}","releases_url":"https://api.github.com/repos/salsify/arc-furnace/releases{/id}","created_at":"2015-07-14T16:07:33Z","updated_at":"2015-10-23T14:53:20Z","pushed_at":"2015-12-10T22:06:15Z","git_url":"git://github.com/salsify/arc-furnace.git","ssh_url":"git@github.com:salsify/arc-furnace.git","clone_url":"https://github.com/salsify/arc-furnace.git","svn_url":"https://github.com/salsify/arc-furnace","homepage":null,"size":93,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/salsify/arc-furnace/pulls/10"},"html":{"href":"https://github.com/salsify/arc-furnace/pull/10"},"issue":{"href":"https://api.github.com/repos/salsify/arc-furnace/issues/10"},"comments":{"href":"https://api.github.com/repos/salsify/arc-furnace/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/salsify/arc-furnace/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/salsify/arc-furnace/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/salsify/arc-furnace/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/salsify/arc-furnace/statuses/81a6576b8b3931931c3ff633a09f4281f5fe7c9d"}}}}