{"action":"created","issue":{"url":"https://api.github.com/repos/osmlab/to-fix/issues/66","labels_url":"https://api.github.com/repos/osmlab/to-fix/issues/66/labels{/name}","comments_url":"https://api.github.com/repos/osmlab/to-fix/issues/66/comments","events_url":"https://api.github.com/repos/osmlab/to-fix/issues/66/events","html_url":"https://github.com/osmlab/to-fix/pull/66","id":57260522,"number":66,"title":"use require() to load jquery to provide compatibility w/ atom shell","user":{"login":"sbma44","id":31717,"avatar_url":"https://avatars.githubusercontent.com/u/31717?v=3","gravatar_id":"","url":"https://api.github.com/users/sbma44","html_url":"https://github.com/sbma44","followers_url":"https://api.github.com/users/sbma44/followers","following_url":"https://api.github.com/users/sbma44/following{/other_user}","gists_url":"https://api.github.com/users/sbma44/gists{/gist_id}","starred_url":"https://api.github.com/users/sbma44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbma44/subscriptions","organizations_url":"https://api.github.com/users/sbma44/orgs","repos_url":"https://api.github.com/users/sbma44/repos","events_url":"https://api.github.com/users/sbma44/events{/privacy}","received_events_url":"https://api.github.com/users/sbma44/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-02-11T00:31:45Z","updated_at":"2015-03-14T21:24:03Z","closed_at":"2015-03-14T21:22:14Z","pull_request":{"url":"https://api.github.com/repos/osmlab/to-fix/pulls/66","html_url":"https://github.com/osmlab/to-fix/pull/66","diff_url":"https://github.com/osmlab/to-fix/pull/66.diff","patch_url":"https://github.com/osmlab/to-fix/pull/66.patch"},"body":"this PR moves JQuery into the project in order to support Atom Shell. Unfortunately, when loaded through normal means in AS, jQuery makes bad assumptions about the environment and becomes unreachable by the rest of the browser scripts. This is fixable, but only through the use of require() to load JQ. More here:\r\n\r\nhttps://github.com/atom/atom-shell/issues/254\r\n\r\nDownside:\r\n- jQuery no longer loaded via CDN, need to worry about versions more\r\n\r\nUpside:\r\n- [Atom Shell always-on-top functionality for mappers](https://github.com/sbma44/to-fix-on-top); and stable JQ isn't so bad anyway"},"comment":{"url":"https://api.github.com/repos/osmlab/to-fix/issues/comments/80725047","html_url":"https://github.com/osmlab/to-fix/pull/66#issuecomment-80725047","issue_url":"https://api.github.com/repos/osmlab/to-fix/issues/66","id":80725047,"user":{"login":"sbma44","id":31717,"avatar_url":"https://avatars.githubusercontent.com/u/31717?v=3","gravatar_id":"","url":"https://api.github.com/users/sbma44","html_url":"https://github.com/sbma44","followers_url":"https://api.github.com/users/sbma44/followers","following_url":"https://api.github.com/users/sbma44/following{/other_user}","gists_url":"https://api.github.com/users/sbma44/gists{/gist_id}","starred_url":"https://api.github.com/users/sbma44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbma44/subscriptions","organizations_url":"https://api.github.com/users/sbma44/orgs","repos_url":"https://api.github.com/users/sbma44/repos","events_url":"https://api.github.com/users/sbma44/events{/privacy}","received_events_url":"https://api.github.com/users/sbma44/received_events","type":"User","site_admin":false},"created_at":"2015-03-14T21:24:03Z","updated_at":"2015-03-14T21:24:03Z","body":"no worries! thanks for having a look"}}