{"action":"created","comment":{"url":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/comments/36593531","id":36593531,"diff_hunk":"@@ -319,6 +319,9 @@ void MainWindow::loginError(Response::ResponseCode r, QString reasonStr, quint32\n         case Response::RespClientIdRequired:\n             QMessageBox::critical(this, tr(\"Error\"), tr(\"This server requires client ID's. Your client is either failing to generate an ID or you are running a modified client.\\nPlease close and reopen your client to try again.\"));\n             break;\n+        case Response::RespContextError:\n+            QMessageBox::critical(this, tr(\"Error\"), tr(\"An internal error has occurred, please try closing and reopening your client and try again. If the error persists try updating your client to the most recent build and if need be contact your software provider.\"));","path":"cockatrice/src/window_main.cpp","position":5,"original_position":5,"commit_id":"3f78e0bec397caf3a26b7d79ee84d643806d0fc7","original_commit_id":"3f78e0bec397caf3a26b7d79ee84d643806d0fc7","user":{"login":"Daenyth","id":14644,"avatar_url":"https://avatars.githubusercontent.com/u/14644?v=3","gravatar_id":"","url":"https://api.github.com/users/Daenyth","html_url":"https://github.com/Daenyth","followers_url":"https://api.github.com/users/Daenyth/followers","following_url":"https://api.github.com/users/Daenyth/following{/other_user}","gists_url":"https://api.github.com/users/Daenyth/gists{/gist_id}","starred_url":"https://api.github.com/users/Daenyth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Daenyth/subscriptions","organizations_url":"https://api.github.com/users/Daenyth/orgs","repos_url":"https://api.github.com/users/Daenyth/repos","events_url":"https://api.github.com/users/Daenyth/events{/privacy}","received_events_url":"https://api.github.com/users/Daenyth/received_events","type":"User","site_admin":false},"body":"Under normal operation it should never happen, it indicates a bug\n\nOn Sun, Aug 9, 2015 at 4:53 PM Gavin Bisesi <daenyth@gmail.com> wrote:\n\n> The server returns this response in a lot of places.\n>\n> On Sun, Aug 9, 2015 at 4:37 PM woogerboy21 <notifications@github.com>\n> wrote:\n>\n>> In cockatrice/src/window_main.cpp\n>> <https://github.com/Cockatrice/Cockatrice/pull/1350#discussion_r36593326>\n>> :\n>>\n>> > @@ -319,6 +319,9 @@ void MainWindow::loginError(Response::ResponseCode r, QString reasonStr, quint32\n>> >          case Response::RespClientIdRequired:\n>> >              QMessageBox::critical(this, tr(\"Error\"), tr(\"This server requires client ID's. Your client is either failing to generate an ID or you are running a modified client.\\nPlease close and reopen your client to try again.\"));\n>> >              break;\n>> > +        case Response::RespContextError:\n>> > +            QMessageBox::critical(this, tr(\"Error\"), tr(\"An internal error has occurred, please try closing and reopening your client and try again. If the error persists try updating your client to the most recent build and if need be contact your software provider.\"));\n>>\n>> The error message only occurs in the login process and not any were else.\n>> Could there be a better description, sure. Is it better than before. YES.\n>>\n>> —\n>> Reply to this email directly or view it on GitHub\n>> <https://github.com/Cockatrice/Cockatrice/pull/1350/files#r36593326>.\n>>\n>\n","created_at":"2015-08-09T20:54:10Z","updated_at":"2015-08-09T20:54:10Z","html_url":"https://github.com/Cockatrice/Cockatrice/pull/1350#discussion_r36593531","pull_request_url":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/1350","_links":{"self":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/comments/36593531"},"html":{"href":"https://github.com/Cockatrice/Cockatrice/pull/1350#discussion_r36593531"},"pull_request":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/1350"}}},"pull_request":{"url":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/1350","id":41973401,"html_url":"https://github.com/Cockatrice/Cockatrice/pull/1350","diff_url":"https://github.com/Cockatrice/Cockatrice/pull/1350.diff","patch_url":"https://github.com/Cockatrice/Cockatrice/pull/1350.patch","issue_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/1350","number":1350,"state":"closed","locked":false,"title":"Update Error 11 Clarity","user":{"login":"woogerboy21","id":1361287,"avatar_url":"https://avatars.githubusercontent.com/u/1361287?v=3","gravatar_id":"","url":"https://api.github.com/users/woogerboy21","html_url":"https://github.com/woogerboy21","followers_url":"https://api.github.com/users/woogerboy21/followers","following_url":"https://api.github.com/users/woogerboy21/following{/other_user}","gists_url":"https://api.github.com/users/woogerboy21/gists{/gist_id}","starred_url":"https://api.github.com/users/woogerboy21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woogerboy21/subscriptions","organizations_url":"https://api.github.com/users/woogerboy21/orgs","repos_url":"https://api.github.com/users/woogerboy21/repos","events_url":"https://api.github.com/users/woogerboy21/events{/privacy}","received_events_url":"https://api.github.com/users/woogerboy21/received_events","type":"User","site_admin":false},"body":"Added case statement for the RespContextError return code when login failures occur due to updates in the protocol standards.","created_at":"2015-08-09T16:58:06Z","updated_at":"2015-08-09T20:54:10Z","closed_at":"2015-08-09T18:02:34Z","merged_at":"2015-08-09T18:02:34Z","merge_commit_sha":"b748423e84176b23db44590111ec9d25a2a7a997","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/1350/commits","review_comments_url":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/1350/comments","review_comment_url":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/1350/comments","statuses_url":"https://api.github.com/repos/Cockatrice/Cockatrice/statuses/3f78e0bec397caf3a26b7d79ee84d643806d0fc7","head":{"label":"woogerboy21:showmoreinfo_logincontexterror","ref":"showmoreinfo_logincontexterror","sha":"3f78e0bec397caf3a26b7d79ee84d643806d0fc7","user":{"login":"woogerboy21","id":1361287,"avatar_url":"https://avatars.githubusercontent.com/u/1361287?v=3","gravatar_id":"","url":"https://api.github.com/users/woogerboy21","html_url":"https://github.com/woogerboy21","followers_url":"https://api.github.com/users/woogerboy21/followers","following_url":"https://api.github.com/users/woogerboy21/following{/other_user}","gists_url":"https://api.github.com/users/woogerboy21/gists{/gist_id}","starred_url":"https://api.github.com/users/woogerboy21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woogerboy21/subscriptions","organizations_url":"https://api.github.com/users/woogerboy21/orgs","repos_url":"https://api.github.com/users/woogerboy21/repos","events_url":"https://api.github.com/users/woogerboy21/events{/privacy}","received_events_url":"https://api.github.com/users/woogerboy21/received_events","type":"User","site_admin":false},"repo":{"id":21113338,"name":"Cockatrice","full_name":"woogerboy21/Cockatrice","owner":{"login":"woogerboy21","id":1361287,"avatar_url":"https://avatars.githubusercontent.com/u/1361287?v=3","gravatar_id":"","url":"https://api.github.com/users/woogerboy21","html_url":"https://github.com/woogerboy21","followers_url":"https://api.github.com/users/woogerboy21/followers","following_url":"https://api.github.com/users/woogerboy21/following{/other_user}","gists_url":"https://api.github.com/users/woogerboy21/gists{/gist_id}","starred_url":"https://api.github.com/users/woogerboy21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woogerboy21/subscriptions","organizations_url":"https://api.github.com/users/woogerboy21/orgs","repos_url":"https://api.github.com/users/woogerboy21/repos","events_url":"https://api.github.com/users/woogerboy21/events{/privacy}","received_events_url":"https://api.github.com/users/woogerboy21/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/woogerboy21/Cockatrice","description":"A cross-platform virtual tabletop for multiplayer card games","fork":true,"url":"https://api.github.com/repos/woogerboy21/Cockatrice","forks_url":"https://api.github.com/repos/woogerboy21/Cockatrice/forks","keys_url":"https://api.github.com/repos/woogerboy21/Cockatrice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/woogerboy21/Cockatrice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/woogerboy21/Cockatrice/teams","hooks_url":"https://api.github.com/repos/woogerboy21/Cockatrice/hooks","issue_events_url":"https://api.github.com/repos/woogerboy21/Cockatrice/issues/events{/number}","events_url":"https://api.github.com/repos/woogerboy21/Cockatrice/events","assignees_url":"https://api.github.com/repos/woogerboy21/Cockatrice/assignees{/user}","branches_url":"https://api.github.com/repos/woogerboy21/Cockatrice/branches{/branch}","tags_url":"https://api.github.com/repos/woogerboy21/Cockatrice/tags","blobs_url":"https://api.github.com/repos/woogerboy21/Cockatrice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/woogerboy21/Cockatrice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/woogerboy21/Cockatrice/git/refs{/sha}","trees_url":"https://api.github.com/repos/woogerboy21/Cockatrice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/woogerboy21/Cockatrice/statuses/{sha}","languages_url":"https://api.github.com/repos/woogerboy21/Cockatrice/languages","stargazers_url":"https://api.github.com/repos/woogerboy21/Cockatrice/stargazers","contributors_url":"https://api.github.com/repos/woogerboy21/Cockatrice/contributors","subscribers_url":"https://api.github.com/repos/woogerboy21/Cockatrice/subscribers","subscription_url":"https://api.github.com/repos/woogerboy21/Cockatrice/subscription","commits_url":"https://api.github.com/repos/woogerboy21/Cockatrice/commits{/sha}","git_commits_url":"https://api.github.com/repos/woogerboy21/Cockatrice/git/commits{/sha}","comments_url":"https://api.github.com/repos/woogerboy21/Cockatrice/comments{/number}","issue_comment_url":"https://api.github.com/repos/woogerboy21/Cockatrice/issues/comments{/number}","contents_url":"https://api.github.com/repos/woogerboy21/Cockatrice/contents/{+path}","compare_url":"https://api.github.com/repos/woogerboy21/Cockatrice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/woogerboy21/Cockatrice/merges","archive_url":"https://api.github.com/repos/woogerboy21/Cockatrice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/woogerboy21/Cockatrice/downloads","issues_url":"https://api.github.com/repos/woogerboy21/Cockatrice/issues{/number}","pulls_url":"https://api.github.com/repos/woogerboy21/Cockatrice/pulls{/number}","milestones_url":"https://api.github.com/repos/woogerboy21/Cockatrice/milestones{/number}","notifications_url":"https://api.github.com/repos/woogerboy21/Cockatrice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/woogerboy21/Cockatrice/labels{/name}","releases_url":"https://api.github.com/repos/woogerboy21/Cockatrice/releases{/id}","created_at":"2014-06-23T03:52:32Z","updated_at":"2015-03-06T17:12:51Z","pushed_at":"2015-08-09T19:28:23Z","git_url":"git://github.com/woogerboy21/Cockatrice.git","ssh_url":"git@github.com:woogerboy21/Cockatrice.git","clone_url":"https://github.com/woogerboy21/Cockatrice.git","svn_url":"https://github.com/woogerboy21/Cockatrice","homepage":"","size":30778,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Cockatrice:master","ref":"master","sha":"1f22f1743cbfba5837a11b7c87515bd7e773ead8","user":{"login":"Cockatrice","id":9746249,"avatar_url":"https://avatars.githubusercontent.com/u/9746249?v=3","gravatar_id":"","url":"https://api.github.com/users/Cockatrice","html_url":"https://github.com/Cockatrice","followers_url":"https://api.github.com/users/Cockatrice/followers","following_url":"https://api.github.com/users/Cockatrice/following{/other_user}","gists_url":"https://api.github.com/users/Cockatrice/gists{/gist_id}","starred_url":"https://api.github.com/users/Cockatrice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cockatrice/subscriptions","organizations_url":"https://api.github.com/users/Cockatrice/orgs","repos_url":"https://api.github.com/users/Cockatrice/repos","events_url":"https://api.github.com/users/Cockatrice/events{/privacy}","received_events_url":"https://api.github.com/users/Cockatrice/received_events","type":"Organization","site_admin":false},"repo":{"id":2907031,"name":"Cockatrice","full_name":"Cockatrice/Cockatrice","owner":{"login":"Cockatrice","id":9746249,"avatar_url":"https://avatars.githubusercontent.com/u/9746249?v=3","gravatar_id":"","url":"https://api.github.com/users/Cockatrice","html_url":"https://github.com/Cockatrice","followers_url":"https://api.github.com/users/Cockatrice/followers","following_url":"https://api.github.com/users/Cockatrice/following{/other_user}","gists_url":"https://api.github.com/users/Cockatrice/gists{/gist_id}","starred_url":"https://api.github.com/users/Cockatrice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cockatrice/subscriptions","organizations_url":"https://api.github.com/users/Cockatrice/orgs","repos_url":"https://api.github.com/users/Cockatrice/repos","events_url":"https://api.github.com/users/Cockatrice/events{/privacy}","received_events_url":"https://api.github.com/users/Cockatrice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Cockatrice/Cockatrice","description":"A cross-platform virtual tabletop for multiplayer card games","fork":false,"url":"https://api.github.com/repos/Cockatrice/Cockatrice","forks_url":"https://api.github.com/repos/Cockatrice/Cockatrice/forks","keys_url":"https://api.github.com/repos/Cockatrice/Cockatrice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cockatrice/Cockatrice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cockatrice/Cockatrice/teams","hooks_url":"https://api.github.com/repos/Cockatrice/Cockatrice/hooks","issue_events_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/events{/number}","events_url":"https://api.github.com/repos/Cockatrice/Cockatrice/events","assignees_url":"https://api.github.com/repos/Cockatrice/Cockatrice/assignees{/user}","branches_url":"https://api.github.com/repos/Cockatrice/Cockatrice/branches{/branch}","tags_url":"https://api.github.com/repos/Cockatrice/Cockatrice/tags","blobs_url":"https://api.github.com/repos/Cockatrice/Cockatrice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cockatrice/Cockatrice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cockatrice/Cockatrice/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cockatrice/Cockatrice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cockatrice/Cockatrice/statuses/{sha}","languages_url":"https://api.github.com/repos/Cockatrice/Cockatrice/languages","stargazers_url":"https://api.github.com/repos/Cockatrice/Cockatrice/stargazers","contributors_url":"https://api.github.com/repos/Cockatrice/Cockatrice/contributors","subscribers_url":"https://api.github.com/repos/Cockatrice/Cockatrice/subscribers","subscription_url":"https://api.github.com/repos/Cockatrice/Cockatrice/subscription","commits_url":"https://api.github.com/repos/Cockatrice/Cockatrice/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cockatrice/Cockatrice/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cockatrice/Cockatrice/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cockatrice/Cockatrice/contents/{+path}","compare_url":"https://api.github.com/repos/Cockatrice/Cockatrice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cockatrice/Cockatrice/merges","archive_url":"https://api.github.com/repos/Cockatrice/Cockatrice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cockatrice/Cockatrice/downloads","issues_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues{/number}","pulls_url":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls{/number}","milestones_url":"https://api.github.com/repos/Cockatrice/Cockatrice/milestones{/number}","notifications_url":"https://api.github.com/repos/Cockatrice/Cockatrice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cockatrice/Cockatrice/labels{/name}","releases_url":"https://api.github.com/repos/Cockatrice/Cockatrice/releases{/id}","created_at":"2011-12-03T20:58:09Z","updated_at":"2015-08-08T05:05:11Z","pushed_at":"2015-08-09T20:21:08Z","git_url":"git://github.com/Cockatrice/Cockatrice.git","ssh_url":"git@github.com:Cockatrice/Cockatrice.git","clone_url":"https://github.com/Cockatrice/Cockatrice.git","svn_url":"https://github.com/Cockatrice/Cockatrice","homepage":"","size":42055,"stargazers_count":291,"watchers_count":291,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":185,"mirror_url":null,"open_issues_count":213,"forks":185,"open_issues":213,"watchers":291,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/1350"},"html":{"href":"https://github.com/Cockatrice/Cockatrice/pull/1350"},"issue":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/1350"},"comments":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/1350/comments"},"review_comments":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/1350/comments"},"review_comment":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/1350/commits"},"statuses":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/statuses/3f78e0bec397caf3a26b7d79ee84d643806d0fc7"}}}}