{"action":"created","comment":{"url":"https://api.github.com/repos/D-Programming-Language/druntime/pulls/comments/23419455","id":23419455,"diff_hunk":"@@ -2033,6 +2208,13 @@ struct Gcx\n         return 1;\n     }\n \n+    static struct ScanRange\n+    {\n+        void* pbot;\n+        void* ptop;\n+        Pool* pool;","path":"src/gc/gc.d","position":316,"original_position":316,"commit_id":"90172462b0ecbff70ab0bce62bf3dfaadd0b4acf","original_commit_id":"90172462b0ecbff70ab0bce62bf3dfaadd0b4acf","user":{"login":"MartinNowak","id":288976,"avatar_url":"https://avatars.githubusercontent.com/u/288976?v=3","gravatar_id":"","url":"https://api.github.com/users/MartinNowak","html_url":"https://github.com/MartinNowak","followers_url":"https://api.github.com/users/MartinNowak/followers","following_url":"https://api.github.com/users/MartinNowak/following{/other_user}","gists_url":"https://api.github.com/users/MartinNowak/gists{/gist_id}","starred_url":"https://api.github.com/users/MartinNowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartinNowak/subscriptions","organizations_url":"https://api.github.com/users/MartinNowak/orgs","repos_url":"https://api.github.com/users/MartinNowak/repos","events_url":"https://api.github.com/users/MartinNowak/events{/privacy}","received_events_url":"https://api.github.com/users/MartinNowak/received_events","type":"User","site_admin":false},"body":"Might be better to use a second stack for the pools in parallel.","created_at":"2015-01-22T23:15:12Z","updated_at":"2015-01-22T23:15:12Z","html_url":"https://github.com/D-Programming-Language/druntime/pull/1022#discussion_r23419455","pull_request_url":"https://api.github.com/repos/D-Programming-Language/druntime/pulls/1022","_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/druntime/pulls/comments/23419455"},"html":{"href":"https://github.com/D-Programming-Language/druntime/pull/1022#discussion_r23419455"},"pull_request":{"href":"https://api.github.com/repos/D-Programming-Language/druntime/pulls/1022"}}},"pull_request":{"url":"https://api.github.com/repos/D-Programming-Language/druntime/pulls/1022","id":24465602,"html_url":"https://github.com/D-Programming-Language/druntime/pull/1022","diff_url":"https://github.com/D-Programming-Language/druntime/pull/1022.diff","patch_url":"https://github.com/D-Programming-Language/druntime/pull/1022.patch","issue_url":"https://api.github.com/repos/D-Programming-Language/druntime/issues/1022","number":1022,"state":"open","locked":false,"title":"[WIP] precise GC as presented at DConf 2013","user":{"login":"rainers","id":702284,"avatar_url":"https://avatars.githubusercontent.com/u/702284?v=3","gravatar_id":"","url":"https://api.github.com/users/rainers","html_url":"https://github.com/rainers","followers_url":"https://api.github.com/users/rainers/followers","following_url":"https://api.github.com/users/rainers/following{/other_user}","gists_url":"https://api.github.com/users/rainers/gists{/gist_id}","starred_url":"https://api.github.com/users/rainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rainers/subscriptions","organizations_url":"https://api.github.com/users/rainers/orgs","repos_url":"https://api.github.com/users/rainers/repos","events_url":"https://api.github.com/users/rainers/events{/privacy}","received_events_url":"https://api.github.com/users/rainers/received_events","type":"User","site_admin":false},"body":"This is the precise GC as presented at DConf 2013. It generates pointer bitmaps for each type T using RTInfo!T and stores a bitmap alongside pool memory to use for following only pointer references.\r\n\r\nRTInfo generation isn't working properly at the moment (needs https://github.com/D-Programming-Language/dmd/pull/3958 or https://github.com/D-Programming-Language/dmd/pull/2480), but using the compiler default will just scan some types conservatively instead of precisely.\r\n\r\nSome notes:\r\n- only the heap is scanned precisely, not stacks or the data/TLS segments\r\n- compilation is slower: I measured 3:46min for the \"quick\" test suite on Win32 instead of 3:26 for master (we might need a special trait to avoid a lot of CTFE)\r\n- execution is slower: the allocation heavy druntime benchmarks take 58sec instead of 51sec (unfortunately there are 2 list-benchmark  which don't give reliable timings).\r\n- associative arrays need a dirty hack to support precise scanning of the key/value pairs in Entry: the TypeInfo for that is geneerated at runtime and stored in the Impl struct of each instance.\r\n- dynamic arrays need to \"re-emplace\" their type info pointer bitmaps for large arrays, because data is \"sometimes\" placed at an offset of 16 bytes\r\n\r\nI'm opening this as a pull request to verify building on other platforms aswell as making it more publically visible and open for review/discussion.\r\n\r\nI plan to create another version that stores type info per allocation block and use this during scanning. This can avoid the troubles for the arrays, but will not allow reassigning new types to partial memory blocks (e.g. when using std.emplace on fields of a class).","created_at":"2014-11-14T19:47:43Z","updated_at":"2015-01-22T23:15:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e54cdcceaf5ed9f5c61ac5902cbc1540a7bdd0b2","assignee":null,"milestone":{"url":"https://api.github.com/repos/D-Programming-Language/druntime/milestones/4","labels_url":"https://api.github.com/repos/D-Programming-Language/druntime/milestones/4/labels","id":821355,"number":4,"title":"2.067","description":null,"creator":{"login":"MartinNowak","id":288976,"avatar_url":"https://avatars.githubusercontent.com/u/288976?v=3","gravatar_id":"","url":"https://api.github.com/users/MartinNowak","html_url":"https://github.com/MartinNowak","followers_url":"https://api.github.com/users/MartinNowak/followers","following_url":"https://api.github.com/users/MartinNowak/following{/other_user}","gists_url":"https://api.github.com/users/MartinNowak/gists{/gist_id}","starred_url":"https://api.github.com/users/MartinNowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartinNowak/subscriptions","organizations_url":"https://api.github.com/users/MartinNowak/orgs","repos_url":"https://api.github.com/users/MartinNowak/repos","events_url":"https://api.github.com/users/MartinNowak/events{/privacy}","received_events_url":"https://api.github.com/users/MartinNowak/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2014-10-10T16:06:25Z","updated_at":"2014-11-18T01:17:48Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/D-Programming-Language/druntime/pulls/1022/commits","review_comments_url":"https://api.github.com/repos/D-Programming-Language/druntime/pulls/1022/comments","review_comment_url":"https://api.github.com/repos/D-Programming-Language/druntime/pulls/comments/{number}","comments_url":"https://api.github.com/repos/D-Programming-Language/druntime/issues/1022/comments","statuses_url":"https://api.github.com/repos/D-Programming-Language/druntime/statuses/90172462b0ecbff70ab0bce62bf3dfaadd0b4acf","head":{"label":"rainers:gc_precise_nov14","ref":"gc_precise_nov14","sha":"90172462b0ecbff70ab0bce62bf3dfaadd0b4acf","user":{"login":"rainers","id":702284,"avatar_url":"https://avatars.githubusercontent.com/u/702284?v=3","gravatar_id":"","url":"https://api.github.com/users/rainers","html_url":"https://github.com/rainers","followers_url":"https://api.github.com/users/rainers/followers","following_url":"https://api.github.com/users/rainers/following{/other_user}","gists_url":"https://api.github.com/users/rainers/gists{/gist_id}","starred_url":"https://api.github.com/users/rainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rainers/subscriptions","organizations_url":"https://api.github.com/users/rainers/orgs","repos_url":"https://api.github.com/users/rainers/repos","events_url":"https://api.github.com/users/rainers/events{/privacy}","received_events_url":"https://api.github.com/users/rainers/received_events","type":"User","site_admin":false},"repo":{"id":1625600,"name":"druntime","full_name":"rainers/druntime","owner":{"login":"rainers","id":702284,"avatar_url":"https://avatars.githubusercontent.com/u/702284?v=3","gravatar_id":"","url":"https://api.github.com/users/rainers","html_url":"https://github.com/rainers","followers_url":"https://api.github.com/users/rainers/followers","following_url":"https://api.github.com/users/rainers/following{/other_user}","gists_url":"https://api.github.com/users/rainers/gists{/gist_id}","starred_url":"https://api.github.com/users/rainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rainers/subscriptions","organizations_url":"https://api.github.com/users/rainers/orgs","repos_url":"https://api.github.com/users/rainers/repos","events_url":"https://api.github.com/users/rainers/events{/privacy}","received_events_url":"https://api.github.com/users/rainers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rainers/druntime","description":"Low level runtime library for the D programming language","fork":true,"url":"https://api.github.com/repos/rainers/druntime","forks_url":"https://api.github.com/repos/rainers/druntime/forks","keys_url":"https://api.github.com/repos/rainers/druntime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rainers/druntime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rainers/druntime/teams","hooks_url":"https://api.github.com/repos/rainers/druntime/hooks","issue_events_url":"https://api.github.com/repos/rainers/druntime/issues/events{/number}","events_url":"https://api.github.com/repos/rainers/druntime/events","assignees_url":"https://api.github.com/repos/rainers/druntime/assignees{/user}","branches_url":"https://api.github.com/repos/rainers/druntime/branches{/branch}","tags_url":"https://api.github.com/repos/rainers/druntime/tags","blobs_url":"https://api.github.com/repos/rainers/druntime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rainers/druntime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rainers/druntime/git/refs{/sha}","trees_url":"https://api.github.com/repos/rainers/druntime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rainers/druntime/statuses/{sha}","languages_url":"https://api.github.com/repos/rainers/druntime/languages","stargazers_url":"https://api.github.com/repos/rainers/druntime/stargazers","contributors_url":"https://api.github.com/repos/rainers/druntime/contributors","subscribers_url":"https://api.github.com/repos/rainers/druntime/subscribers","subscription_url":"https://api.github.com/repos/rainers/druntime/subscription","commits_url":"https://api.github.com/repos/rainers/druntime/commits{/sha}","git_commits_url":"https://api.github.com/repos/rainers/druntime/git/commits{/sha}","comments_url":"https://api.github.com/repos/rainers/druntime/comments{/number}","issue_comment_url":"https://api.github.com/repos/rainers/druntime/issues/comments/{number}","contents_url":"https://api.github.com/repos/rainers/druntime/contents/{+path}","compare_url":"https://api.github.com/repos/rainers/druntime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rainers/druntime/merges","archive_url":"https://api.github.com/repos/rainers/druntime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rainers/druntime/downloads","issues_url":"https://api.github.com/repos/rainers/druntime/issues{/number}","pulls_url":"https://api.github.com/repos/rainers/druntime/pulls{/number}","milestones_url":"https://api.github.com/repos/rainers/druntime/milestones{/number}","notifications_url":"https://api.github.com/repos/rainers/druntime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rainers/druntime/labels{/name}","releases_url":"https://api.github.com/repos/rainers/druntime/releases{/id}","created_at":"2011-04-17T07:30:25Z","updated_at":"2014-06-14T15:40:00Z","pushed_at":"2015-01-22T08:36:56Z","git_url":"git://github.com/rainers/druntime.git","ssh_url":"git@github.com:rainers/druntime.git","clone_url":"https://github.com/rainers/druntime.git","svn_url":"https://github.com/rainers/druntime","homepage":"d-programming-language.org","size":9506,"stargazers_count":4,"watchers_count":4,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"D-Programming-Language:master","ref":"master","sha":"36b430d2e4a41c9ad9da68c64687c6bec815e600","user":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"repo":{"id":1257087,"name":"druntime","full_name":"D-Programming-Language/druntime","owner":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/D-Programming-Language/druntime","description":"Low level runtime library for the D programming language","fork":false,"url":"https://api.github.com/repos/D-Programming-Language/druntime","forks_url":"https://api.github.com/repos/D-Programming-Language/druntime/forks","keys_url":"https://api.github.com/repos/D-Programming-Language/druntime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/D-Programming-Language/druntime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/D-Programming-Language/druntime/teams","hooks_url":"https://api.github.com/repos/D-Programming-Language/druntime/hooks","issue_events_url":"https://api.github.com/repos/D-Programming-Language/druntime/issues/events{/number}","events_url":"https://api.github.com/repos/D-Programming-Language/druntime/events","assignees_url":"https://api.github.com/repos/D-Programming-Language/druntime/assignees{/user}","branches_url":"https://api.github.com/repos/D-Programming-Language/druntime/branches{/branch}","tags_url":"https://api.github.com/repos/D-Programming-Language/druntime/tags","blobs_url":"https://api.github.com/repos/D-Programming-Language/druntime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/D-Programming-Language/druntime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/D-Programming-Language/druntime/git/refs{/sha}","trees_url":"https://api.github.com/repos/D-Programming-Language/druntime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/D-Programming-Language/druntime/statuses/{sha}","languages_url":"https://api.github.com/repos/D-Programming-Language/druntime/languages","stargazers_url":"https://api.github.com/repos/D-Programming-Language/druntime/stargazers","contributors_url":"https://api.github.com/repos/D-Programming-Language/druntime/contributors","subscribers_url":"https://api.github.com/repos/D-Programming-Language/druntime/subscribers","subscription_url":"https://api.github.com/repos/D-Programming-Language/druntime/subscription","commits_url":"https://api.github.com/repos/D-Programming-Language/druntime/commits{/sha}","git_commits_url":"https://api.github.com/repos/D-Programming-Language/druntime/git/commits{/sha}","comments_url":"https://api.github.com/repos/D-Programming-Language/druntime/comments{/number}","issue_comment_url":"https://api.github.com/repos/D-Programming-Language/druntime/issues/comments/{number}","contents_url":"https://api.github.com/repos/D-Programming-Language/druntime/contents/{+path}","compare_url":"https://api.github.com/repos/D-Programming-Language/druntime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/D-Programming-Language/druntime/merges","archive_url":"https://api.github.com/repos/D-Programming-Language/druntime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/D-Programming-Language/druntime/downloads","issues_url":"https://api.github.com/repos/D-Programming-Language/druntime/issues{/number}","pulls_url":"https://api.github.com/repos/D-Programming-Language/druntime/pulls{/number}","milestones_url":"https://api.github.com/repos/D-Programming-Language/druntime/milestones{/number}","notifications_url":"https://api.github.com/repos/D-Programming-Language/druntime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/D-Programming-Language/druntime/labels{/name}","releases_url":"https://api.github.com/repos/D-Programming-Language/druntime/releases{/id}","created_at":"2011-01-15T07:01:38Z","updated_at":"2015-01-22T02:02:22Z","pushed_at":"2015-01-22T02:02:22Z","git_url":"git://github.com/D-Programming-Language/druntime.git","ssh_url":"git@github.com:D-Programming-Language/druntime.git","clone_url":"https://github.com/D-Programming-Language/druntime.git","svn_url":"https://github.com/D-Programming-Language/druntime","homepage":"dlang.org","size":15835,"stargazers_count":338,"watchers_count":338,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":220,"mirror_url":null,"open_issues_count":33,"forks":220,"open_issues":33,"watchers":338,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/druntime/pulls/1022"},"html":{"href":"https://github.com/D-Programming-Language/druntime/pull/1022"},"issue":{"href":"https://api.github.com/repos/D-Programming-Language/druntime/issues/1022"},"comments":{"href":"https://api.github.com/repos/D-Programming-Language/druntime/issues/1022/comments"},"review_comments":{"href":"https://api.github.com/repos/D-Programming-Language/druntime/pulls/1022/comments"},"review_comment":{"href":"https://api.github.com/repos/D-Programming-Language/druntime/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/D-Programming-Language/druntime/pulls/1022/commits"},"statuses":{"href":"https://api.github.com/repos/D-Programming-Language/druntime/statuses/90172462b0ecbff70ab0bce62bf3dfaadd0b4acf"}}}}