{"action":"created","issue":{"url":"https://api.github.com/repos/ramda/ramda/issues/1529","labels_url":"https://api.github.com/repos/ramda/ramda/issues/1529/labels{/name}","comments_url":"https://api.github.com/repos/ramda/ramda/issues/1529/comments","events_url":"https://api.github.com/repos/ramda/ramda/issues/1529/events","html_url":"https://github.com/ramda/ramda/pull/1529","id":118226694,"number":1529,"title":"RFC: switch to eslint","user":{"login":"gilligan","id":27668,"avatar_url":"https://avatars.githubusercontent.com/u/27668?v=3","gravatar_id":"","url":"https://api.github.com/users/gilligan","html_url":"https://github.com/gilligan","followers_url":"https://api.github.com/users/gilligan/followers","following_url":"https://api.github.com/users/gilligan/following{/other_user}","gists_url":"https://api.github.com/users/gilligan/gists{/gist_id}","starred_url":"https://api.github.com/users/gilligan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gilligan/subscriptions","organizations_url":"https://api.github.com/users/gilligan/orgs","repos_url":"https://api.github.com/users/gilligan/repos","events_url":"https://api.github.com/users/gilligan/events{/privacy}","received_events_url":"https://api.github.com/users/gilligan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-11-21T23:09:14Z","updated_at":"2015-12-09T22:03:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ramda/ramda/pulls/1529","html_url":"https://github.com/ramda/ramda/pull/1529","diff_url":"https://github.com/ramda/ramda/pull/1529.diff","patch_url":"https://github.com/ramda/ramda/pull/1529.patch"},"body":"### what\r\nAs mentioned on gitter I would like to replace `jshint` and `jscs` with `eslint`. \r\n\r\n### why\r\neslint is flexible and powerful enough to replace the functionality of both tools. Even if rules beyond current capabilities might be required at some point there is a nice plugin architecture which would allow for custom rules. Apart from that jshint is somewhat archaic.\r\n\r\n### status\r\nI started off by creating an `.eslintrc` with https://www.npmjs.com/package/polyjuice and continued to fine tune manually. Further manual tweakings were required. I had to do some consistency fixes to get everything error-free. I will provide more detail later on.\r\n\r\nThere is far more that could be configured but obviously I could not just decide that on my own in this PR. For now I'd like to hear what everyone thinks about using eslint and if I should invest more time into this.\r\n\r\n### edit\r\nEslint has good documentation on all of its rules : http://eslint.org/docs/rules/ and configuration in general : http://eslint.org/docs/user-guide/configuring.html\r\n\r\nIt would be easiest if everyone could suggest concrete eslint rule settings (like @scott-christopher did below with one-var) that should be included. I'm happy to add rules and adjust the code accordingly. "},"comment":{"url":"https://api.github.com/repos/ramda/ramda/issues/comments/163409721","html_url":"https://github.com/ramda/ramda/pull/1529#issuecomment-163409721","issue_url":"https://api.github.com/repos/ramda/ramda/issues/1529","id":163409721,"user":{"login":"gilligan","id":27668,"avatar_url":"https://avatars.githubusercontent.com/u/27668?v=3","gravatar_id":"","url":"https://api.github.com/users/gilligan","html_url":"https://github.com/gilligan","followers_url":"https://api.github.com/users/gilligan/followers","following_url":"https://api.github.com/users/gilligan/following{/other_user}","gists_url":"https://api.github.com/users/gilligan/gists{/gist_id}","starred_url":"https://api.github.com/users/gilligan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gilligan/subscriptions","organizations_url":"https://api.github.com/users/gilligan/orgs","repos_url":"https://api.github.com/users/gilligan/repos","events_url":"https://api.github.com/users/gilligan/events{/privacy}","received_events_url":"https://api.github.com/users/gilligan/received_events","type":"User","site_admin":false},"created_at":"2015-12-09T22:03:15Z","updated_at":"2015-12-09T22:03:15Z","body":"While adjusting the sources for `one-var` I realised that sometimes there is a blank line after the var statements block and sometimes there is not. Is this something you would like to see standardised the one or the other way @davidchambers @scott-christopher ?"}}