{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/22904314","id":22904314,"diff_hunk":"@@ -129,6 +141,11 @@ def silhouette_samples(X, labels, metric='euclidean', **kwds):\n         allowed by :func:`sklearn.metrics.pairwise.pairwise_distances`. If X is\n         the distance array itself, use \"precomputed\" as the metric.\n \n+    sample_weight : array, shape = [n_samples], optional","path":"sklearn/metrics/cluster/unsupervised.py","position":67,"original_position":67,"commit_id":"e56d3afa6f7c9e194fdab8082f9b47660818e8b6","original_commit_id":"e56d3afa6f7c9e194fdab8082f9b47660818e8b6","user":{"login":"amueller","id":449558,"avatar_url":"https://avatars.githubusercontent.com/u/449558?v=3","gravatar_id":"","url":"https://api.github.com/users/amueller","html_url":"https://github.com/amueller","followers_url":"https://api.github.com/users/amueller/followers","following_url":"https://api.github.com/users/amueller/following{/other_user}","gists_url":"https://api.github.com/users/amueller/gists{/gist_id}","starred_url":"https://api.github.com/users/amueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amueller/subscriptions","organizations_url":"https://api.github.com/users/amueller/orgs","repos_url":"https://api.github.com/users/amueller/repos","events_url":"https://api.github.com/users/amueller/events{/privacy}","received_events_url":"https://api.github.com/users/amueller/received_events","type":"User","site_admin":false},"body":"Do you have a reference for this definition of sample weights?","created_at":"2015-01-13T23:18:02Z","updated_at":"2015-01-13T23:18:02Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/4087#discussion_r22904314","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4087","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/22904314"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/4087#discussion_r22904314"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4087"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4087","id":27194018,"html_url":"https://github.com/scikit-learn/scikit-learn/pull/4087","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/4087.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/4087.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4087","number":4087,"state":"open","locked":false,"title":"[MRG] support sample_weight in silhouette_score","user":{"login":"jnothman","id":78827,"avatar_url":"https://avatars.githubusercontent.com/u/78827?v=3","gravatar_id":"","url":"https://api.github.com/users/jnothman","html_url":"https://github.com/jnothman","followers_url":"https://api.github.com/users/jnothman/followers","following_url":"https://api.github.com/users/jnothman/following{/other_user}","gists_url":"https://api.github.com/users/jnothman/gists{/gist_id}","starred_url":"https://api.github.com/users/jnothman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnothman/subscriptions","organizations_url":"https://api.github.com/users/jnothman/orgs","repos_url":"https://api.github.com/users/jnothman/repos","events_url":"https://api.github.com/users/jnothman/events{/privacy}","received_events_url":"https://api.github.com/users/jnothman/received_events","type":"User","site_admin":false},"body":"I sought `sample_weight` in `silhouette_score`, to account for multiple points that are merged into one when calculating average distances. Hacking it into the current implementation resulted in a very slow solution. Thus this PR also rewrites the implementation, yielding something that's a bit slower than the solution at master, but supports `sample_weight`.\r\n\r\nI've also added tests for correctness which I haven't otherwise found in the code.","created_at":"2015-01-12T13:35:12Z","updated_at":"2015-01-13T23:18:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ebf972990510dbde88f9cbd26a6409d631bcb036","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4087/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4087/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/{number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4087/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/e56d3afa6f7c9e194fdab8082f9b47660818e8b6","head":{"label":"jnothman:silhouette","ref":"silhouette","sha":"e56d3afa6f7c9e194fdab8082f9b47660818e8b6","user":{"login":"jnothman","id":78827,"avatar_url":"https://avatars.githubusercontent.com/u/78827?v=3","gravatar_id":"","url":"https://api.github.com/users/jnothman","html_url":"https://github.com/jnothman","followers_url":"https://api.github.com/users/jnothman/followers","following_url":"https://api.github.com/users/jnothman/following{/other_user}","gists_url":"https://api.github.com/users/jnothman/gists{/gist_id}","starred_url":"https://api.github.com/users/jnothman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnothman/subscriptions","organizations_url":"https://api.github.com/users/jnothman/orgs","repos_url":"https://api.github.com/users/jnothman/repos","events_url":"https://api.github.com/users/jnothman/events{/privacy}","received_events_url":"https://api.github.com/users/jnothman/received_events","type":"User","site_admin":false},"repo":{"id":8691611,"name":"scikit-learn","full_name":"jnothman/scikit-learn","owner":{"login":"jnothman","id":78827,"avatar_url":"https://avatars.githubusercontent.com/u/78827?v=3","gravatar_id":"","url":"https://api.github.com/users/jnothman","html_url":"https://github.com/jnothman","followers_url":"https://api.github.com/users/jnothman/followers","following_url":"https://api.github.com/users/jnothman/following{/other_user}","gists_url":"https://api.github.com/users/jnothman/gists{/gist_id}","starred_url":"https://api.github.com/users/jnothman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnothman/subscriptions","organizations_url":"https://api.github.com/users/jnothman/orgs","repos_url":"https://api.github.com/users/jnothman/repos","events_url":"https://api.github.com/users/jnothman/events{/privacy}","received_events_url":"https://api.github.com/users/jnothman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jnothman/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/jnothman/scikit-learn","forks_url":"https://api.github.com/repos/jnothman/scikit-learn/forks","keys_url":"https://api.github.com/repos/jnothman/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jnothman/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jnothman/scikit-learn/teams","hooks_url":"https://api.github.com/repos/jnothman/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/jnothman/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/jnothman/scikit-learn/events","assignees_url":"https://api.github.com/repos/jnothman/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/jnothman/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/jnothman/scikit-learn/tags","blobs_url":"https://api.github.com/repos/jnothman/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jnothman/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jnothman/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/jnothman/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jnothman/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/jnothman/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/jnothman/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/jnothman/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/jnothman/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/jnothman/scikit-learn/subscription","commits_url":"https://api.github.com/repos/jnothman/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/jnothman/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/jnothman/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/jnothman/scikit-learn/issues/comments/{number}","contents_url":"https://api.github.com/repos/jnothman/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/jnothman/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jnothman/scikit-learn/merges","archive_url":"https://api.github.com/repos/jnothman/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jnothman/scikit-learn/downloads","issues_url":"https://api.github.com/repos/jnothman/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/jnothman/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/jnothman/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/jnothman/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jnothman/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/jnothman/scikit-learn/releases{/id}","created_at":"2013-03-10T21:10:51Z","updated_at":"2014-12-23T12:16:57Z","pushed_at":"2015-01-13T22:56:29Z","git_url":"git://github.com/jnothman/scikit-learn.git","ssh_url":"git@github.com:jnothman/scikit-learn.git","clone_url":"https://github.com/jnothman/scikit-learn.git","svn_url":"https://github.com/jnothman/scikit-learn","homepage":"http://scikit-learn.org","size":63217,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"f914afae73cce55c9e59c04d7d976a77ba5c4c36","user":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/{number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","created_at":"2010-08-17T09:43:38Z","updated_at":"2015-01-13T20:14:08Z","pushed_at":"2015-01-13T15:08:58Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":109237,"stargazers_count":4826,"watchers_count":4826,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2784,"mirror_url":null,"open_issues_count":565,"forks":2784,"open_issues":565,"watchers":4826,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4087"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/4087"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4087"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4087/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4087/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4087/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/e56d3afa6f7c9e194fdab8082f9b47660818e8b6"}}}}