{"action":"created","issue":{"url":"https://api.github.com/repos/UmbraEngineering/Placeholder/issues/11","labels_url":"https://api.github.com/repos/UmbraEngineering/Placeholder/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/UmbraEngineering/Placeholder/issues/11/comments","events_url":"https://api.github.com/repos/UmbraEngineering/Placeholder/issues/11/events","html_url":"https://github.com/UmbraEngineering/Placeholder/issues/11","id":64185078,"number":11,"title":"Simple.js adds undefined as a placeholder where no placeholder attribute exists","user":{"login":"adrianosmond","id":1849339,"avatar_url":"https://avatars.githubusercontent.com/u/1849339?v=3","gravatar_id":"","url":"https://api.github.com/users/adrianosmond","html_url":"https://github.com/adrianosmond","followers_url":"https://api.github.com/users/adrianosmond/followers","following_url":"https://api.github.com/users/adrianosmond/following{/other_user}","gists_url":"https://api.github.com/users/adrianosmond/gists{/gist_id}","starred_url":"https://api.github.com/users/adrianosmond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrianosmond/subscriptions","organizations_url":"https://api.github.com/users/adrianosmond/orgs","repos_url":"https://api.github.com/users/adrianosmond/repos","events_url":"https://api.github.com/users/adrianosmond/events{/privacy}","received_events_url":"https://api.github.com/users/adrianosmond/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-03-25T06:00:20Z","updated_at":"2015-05-23T21:03:48Z","closed_at":null,"body":""},"comment":{"url":"https://api.github.com/repos/UmbraEngineering/Placeholder/issues/comments/104944694","html_url":"https://github.com/UmbraEngineering/Placeholder/issues/11#issuecomment-104944694","issue_url":"https://api.github.com/repos/UmbraEngineering/Placeholder/issues/11","id":104944694,"user":{"login":"replete","id":812139,"avatar_url":"https://avatars.githubusercontent.com/u/812139?v=3","gravatar_id":"","url":"https://api.github.com/users/replete","html_url":"https://github.com/replete","followers_url":"https://api.github.com/users/replete/followers","following_url":"https://api.github.com/users/replete/following{/other_user}","gists_url":"https://api.github.com/users/replete/gists{/gist_id}","starred_url":"https://api.github.com/users/replete/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/replete/subscriptions","organizations_url":"https://api.github.com/users/replete/orgs","repos_url":"https://api.github.com/users/replete/repos","events_url":"https://api.github.com/users/replete/events{/privacy}","received_events_url":"https://api.github.com/users/replete/received_events","type":"User","site_admin":false},"created_at":"2015-05-23T21:03:48Z","updated_at":"2015-05-23T21:03:48Z","body":"I investigated a bit further, and made the following modification which changes behaviour like so:\r\n\r\n* Ignores [type=password], because shimmed placeholder text is obfuscated with the password circles\r\n* Ignores <textarea>, because textarea doesn't support placeholders and it wasn't checking for existance of a [placeholder] attribute.\r\n\r\nNew _isValidElement_ function:\r\n```javascript\r\n\tfunction isValidElement(elem) {\r\n\t\tvar tag = (elem.nodeName || '').toLowerCase();\r\n\t\treturn (tag !== 'textarea' && (tag === 'input' && (elem.type === 'text' || elem.type !== 'password')));\r\n\t}\r\n```\r\n\r\nI spent a little while adding logic for `.getAttribute('placeholder')`, but ran into problems only reading `getAttribute()` for valid _elem_. For some reason `MutationEvent` where coming through, and I ran into issues making the logic (`x instanceof y` etc) work well in IE7+.\r\n\r\nI only need IE9 so I'll leave it as is for now."}}