{"action":"created","comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/31308741","id":31308741,"diff_hunk":"@@ -21,26 +23,80 @@\n #include \"servo.h\"\n #include \"periph/pwm.h\"\n \n+#define ENABLE_DEBUG    (0)\n+#include \"debug.h\"\n+\n+#define SEC_IN_USEC     (1000000U)","path":"drivers/servo/servo.c","position":22,"original_position":22,"commit_id":"bc29cd9e54454f41cf057eb938b878719c160be7","original_commit_id":"bc29cd9e54454f41cf057eb938b878719c160be7","user":{"login":"PeterKietzmann","id":7765855,"avatar_url":"https://avatars.githubusercontent.com/u/7765855?v=3","gravatar_id":"","url":"https://api.github.com/users/PeterKietzmann","html_url":"https://github.com/PeterKietzmann","followers_url":"https://api.github.com/users/PeterKietzmann/followers","following_url":"https://api.github.com/users/PeterKietzmann/following{/other_user}","gists_url":"https://api.github.com/users/PeterKietzmann/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterKietzmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterKietzmann/subscriptions","organizations_url":"https://api.github.com/users/PeterKietzmann/orgs","repos_url":"https://api.github.com/users/PeterKietzmann/repos","events_url":"https://api.github.com/users/PeterKietzmann/events{/privacy}","received_events_url":"https://api.github.com/users/PeterKietzmann/received_events","type":"User","site_admin":false},"body":"I don't really mind. Just remembered that I've seen this \"issue\" commented in some PRs. Let's see what Hauke says.","created_at":"2015-05-29T08:56:32Z","updated_at":"2015-05-29T08:56:32Z","html_url":"https://github.com/RIOT-OS/RIOT/pull/3106#discussion_r31308741","pull_request_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3106","_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/31308741"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/3106#discussion_r31308741"},"pull_request":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3106"}}},"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3106","id":36455536,"html_url":"https://github.com/RIOT-OS/RIOT/pull/3106","diff_url":"https://github.com/RIOT-OS/RIOT/pull/3106.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/3106.patch","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/3106","number":3106,"state":"open","locked":false,"title":"drivers/servo: Add test program, handle inexact frequencies","user":{"login":"gebart","id":317506,"avatar_url":"https://avatars.githubusercontent.com/u/317506?v=3","gravatar_id":"","url":"https://api.github.com/users/gebart","html_url":"https://github.com/gebart","followers_url":"https://api.github.com/users/gebart/followers","following_url":"https://api.github.com/users/gebart/following{/other_user}","gists_url":"https://api.github.com/users/gebart/gists{/gist_id}","starred_url":"https://api.github.com/users/gebart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gebart/subscriptions","organizations_url":"https://api.github.com/users/gebart/orgs","repos_url":"https://api.github.com/users/gebart/repos","events_url":"https://api.github.com/users/gebart/events{/privacy}","received_events_url":"https://api.github.com/users/gebart/received_events","type":"User","site_admin":false},"body":"This improves the initialization procedure of the servo driver to account for limited frequency selections in the PWM module of some controllers (e.g. Kinetis)\r\n\r\nAdded a simple test program to try it out on a real servo. Connect an RC servo to `PWM_0` channel 0 to see any results.","created_at":"2015-05-28T22:00:34Z","updated_at":"2015-05-29T08:56:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d39e1bb98b89068503a30aa4a3acb96a242e8cd","assignee":{"login":"haukepetersen","id":620834,"avatar_url":"https://avatars.githubusercontent.com/u/620834?v=3","gravatar_id":"","url":"https://api.github.com/users/haukepetersen","html_url":"https://github.com/haukepetersen","followers_url":"https://api.github.com/users/haukepetersen/followers","following_url":"https://api.github.com/users/haukepetersen/following{/other_user}","gists_url":"https://api.github.com/users/haukepetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/haukepetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haukepetersen/subscriptions","organizations_url":"https://api.github.com/users/haukepetersen/orgs","repos_url":"https://api.github.com/users/haukepetersen/repos","events_url":"https://api.github.com/users/haukepetersen/events{/privacy}","received_events_url":"https://api.github.com/users/haukepetersen/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3106/commits","review_comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3106/comments","review_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/3106/comments","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/bc29cd9e54454f41cf057eb938b878719c160be7","head":{"label":"gebart:pr/servo-updates","ref":"pr/servo-updates","sha":"bc29cd9e54454f41cf057eb938b878719c160be7","user":{"login":"gebart","id":317506,"avatar_url":"https://avatars.githubusercontent.com/u/317506?v=3","gravatar_id":"","url":"https://api.github.com/users/gebart","html_url":"https://github.com/gebart","followers_url":"https://api.github.com/users/gebart/followers","following_url":"https://api.github.com/users/gebart/following{/other_user}","gists_url":"https://api.github.com/users/gebart/gists{/gist_id}","starred_url":"https://api.github.com/users/gebart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gebart/subscriptions","organizations_url":"https://api.github.com/users/gebart/orgs","repos_url":"https://api.github.com/users/gebart/repos","events_url":"https://api.github.com/users/gebart/events{/privacy}","received_events_url":"https://api.github.com/users/gebart/received_events","type":"User","site_admin":false},"repo":{"id":20130177,"name":"RIOT","full_name":"gebart/RIOT","owner":{"login":"gebart","id":317506,"avatar_url":"https://avatars.githubusercontent.com/u/317506?v=3","gravatar_id":"","url":"https://api.github.com/users/gebart","html_url":"https://github.com/gebart","followers_url":"https://api.github.com/users/gebart/followers","following_url":"https://api.github.com/users/gebart/following{/other_user}","gists_url":"https://api.github.com/users/gebart/gists{/gist_id}","starred_url":"https://api.github.com/users/gebart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gebart/subscriptions","organizations_url":"https://api.github.com/users/gebart/orgs","repos_url":"https://api.github.com/users/gebart/repos","events_url":"https://api.github.com/users/gebart/events{/privacy}","received_events_url":"https://api.github.com/users/gebart/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gebart/RIOT","description":"RIOT -  The friendly OS for IoT","fork":true,"url":"https://api.github.com/repos/gebart/RIOT","forks_url":"https://api.github.com/repos/gebart/RIOT/forks","keys_url":"https://api.github.com/repos/gebart/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gebart/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gebart/RIOT/teams","hooks_url":"https://api.github.com/repos/gebart/RIOT/hooks","issue_events_url":"https://api.github.com/repos/gebart/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/gebart/RIOT/events","assignees_url":"https://api.github.com/repos/gebart/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/gebart/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/gebart/RIOT/tags","blobs_url":"https://api.github.com/repos/gebart/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gebart/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gebart/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/gebart/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gebart/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/gebart/RIOT/languages","stargazers_url":"https://api.github.com/repos/gebart/RIOT/stargazers","contributors_url":"https://api.github.com/repos/gebart/RIOT/contributors","subscribers_url":"https://api.github.com/repos/gebart/RIOT/subscribers","subscription_url":"https://api.github.com/repos/gebart/RIOT/subscription","commits_url":"https://api.github.com/repos/gebart/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/gebart/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/gebart/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/gebart/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/gebart/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/gebart/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gebart/RIOT/merges","archive_url":"https://api.github.com/repos/gebart/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gebart/RIOT/downloads","issues_url":"https://api.github.com/repos/gebart/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/gebart/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/gebart/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/gebart/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gebart/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/gebart/RIOT/releases{/id}","created_at":"2014-05-24T13:31:43Z","updated_at":"2015-05-06T11:59:03Z","pushed_at":"2015-05-29T07:37:48Z","git_url":"git://github.com/gebart/RIOT.git","ssh_url":"git@github.com:gebart/RIOT.git","clone_url":"https://github.com/gebart/RIOT.git","svn_url":"https://github.com/gebart/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":23746,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"RIOT-OS:master","ref":"master","sha":"7ab88539ebcb0d2423513b7df096472cdacfb146","user":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars.githubusercontent.com/u/3079480?v=3","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"repo":{"id":7370241,"name":"RIOT","full_name":"RIOT-OS/RIOT","owner":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars.githubusercontent.com/u/3079480?v=3","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RIOT-OS/RIOT","description":"RIOT -  The friendly OS for IoT","fork":false,"url":"https://api.github.com/repos/RIOT-OS/RIOT","forks_url":"https://api.github.com/repos/RIOT-OS/RIOT/forks","keys_url":"https://api.github.com/repos/RIOT-OS/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIOT-OS/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIOT-OS/RIOT/teams","hooks_url":"https://api.github.com/repos/RIOT-OS/RIOT/hooks","issue_events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/events","assignees_url":"https://api.github.com/repos/RIOT-OS/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/RIOT-OS/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/tags","blobs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/RIOT-OS/RIOT/languages","stargazers_url":"https://api.github.com/repos/RIOT-OS/RIOT/stargazers","contributors_url":"https://api.github.com/repos/RIOT-OS/RIOT/contributors","subscribers_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscribers","subscription_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscription","commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/RIOT-OS/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/RIOT-OS/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIOT-OS/RIOT/merges","archive_url":"https://api.github.com/repos/RIOT-OS/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIOT-OS/RIOT/downloads","issues_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/RIOT-OS/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/RIOT-OS/RIOT/releases{/id}","created_at":"2012-12-29T20:38:40Z","updated_at":"2015-05-29T01:38:44Z","pushed_at":"2015-05-29T08:45:44Z","git_url":"git://github.com/RIOT-OS/RIOT.git","ssh_url":"git@github.com:RIOT-OS/RIOT.git","clone_url":"https://github.com/RIOT-OS/RIOT.git","svn_url":"https://github.com/RIOT-OS/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":125135,"stargazers_count":400,"watchers_count":400,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":305,"mirror_url":null,"open_issues_count":320,"forks":305,"open_issues":320,"watchers":400,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3106"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/3106"},"issue":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/3106"},"comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/3106/comments"},"review_comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3106/comments"},"review_comment":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3106/commits"},"statuses":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/bc29cd9e54454f41cf057eb938b878719c160be7"}}}}