{"action":"closed","number":1458,"pull_request":{"url":"https://api.github.com/repos/buildbot/buildbot/pulls/1458","id":26321412,"html_url":"https://github.com/buildbot/buildbot/pull/1458","diff_url":"https://github.com/buildbot/buildbot/pull/1458.diff","patch_url":"https://github.com/buildbot/buildbot/pull/1458.patch","issue_url":"https://api.github.com/repos/buildbot/buildbot/issues/1458","number":1458,"state":"closed","locked":false,"title":"Instead of hard-coding a list of modes in svn.startVC(), use getattr instead","user":{"login":"dburkart","id":55467,"avatar_url":"https://avatars.githubusercontent.com/u/55467?v=3","gravatar_id":"","url":"https://api.github.com/users/dburkart","html_url":"https://github.com/dburkart","followers_url":"https://api.github.com/users/dburkart/followers","following_url":"https://api.github.com/users/dburkart/following{/other_user}","gists_url":"https://api.github.com/users/dburkart/gists{/gist_id}","starred_url":"https://api.github.com/users/dburkart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dburkart/subscriptions","organizations_url":"https://api.github.com/users/dburkart/orgs","repos_url":"https://api.github.com/users/dburkart/repos","events_url":"https://api.github.com/users/dburkart/events{/privacy}","received_events_url":"https://api.github.com/users/dburkart/received_events","type":"User","site_admin":false},"body":"This patch allows users of buildbot to subclass the SVN class and create a new\r\nmode. The only way to do this currently is by copying the entire startVC() class\r\nto ensure that the new mode callback is added in the proper place.","created_at":"2014-12-18T18:32:48Z","updated_at":"2015-04-03T06:39:02Z","closed_at":"2015-04-03T06:39:02Z","merged_at":null,"merge_commit_sha":"b9d7106e76955e05c8c5ccc37be3f8b418e6c56a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/buildbot/buildbot/pulls/1458/commits","review_comments_url":"https://api.github.com/repos/buildbot/buildbot/pulls/1458/comments","review_comment_url":"https://api.github.com/repos/buildbot/buildbot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/buildbot/buildbot/issues/1458/comments","statuses_url":"https://api.github.com/repos/buildbot/buildbot/statuses/af08a69deb41d9f4bff827e65451fdce5babea42","head":{"label":"dburkart:svn-changes","ref":"svn-changes","sha":"af08a69deb41d9f4bff827e65451fdce5babea42","user":{"login":"dburkart","id":55467,"avatar_url":"https://avatars.githubusercontent.com/u/55467?v=3","gravatar_id":"","url":"https://api.github.com/users/dburkart","html_url":"https://github.com/dburkart","followers_url":"https://api.github.com/users/dburkart/followers","following_url":"https://api.github.com/users/dburkart/following{/other_user}","gists_url":"https://api.github.com/users/dburkart/gists{/gist_id}","starred_url":"https://api.github.com/users/dburkart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dburkart/subscriptions","organizations_url":"https://api.github.com/users/dburkart/orgs","repos_url":"https://api.github.com/users/dburkart/repos","events_url":"https://api.github.com/users/dburkart/events{/privacy}","received_events_url":"https://api.github.com/users/dburkart/received_events","type":"User","site_admin":false},"repo":{"id":28195128,"name":"buildbot","full_name":"dburkart/buildbot","owner":{"login":"dburkart","id":55467,"avatar_url":"https://avatars.githubusercontent.com/u/55467?v=3","gravatar_id":"","url":"https://api.github.com/users/dburkart","html_url":"https://github.com/dburkart","followers_url":"https://api.github.com/users/dburkart/followers","following_url":"https://api.github.com/users/dburkart/following{/other_user}","gists_url":"https://api.github.com/users/dburkart/gists{/gist_id}","starred_url":"https://api.github.com/users/dburkart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dburkart/subscriptions","organizations_url":"https://api.github.com/users/dburkart/orgs","repos_url":"https://api.github.com/users/dburkart/repos","events_url":"https://api.github.com/users/dburkart/events{/privacy}","received_events_url":"https://api.github.com/users/dburkart/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dburkart/buildbot","description":"Python-based continuous integration testing framework; send pull requests for your patches!","fork":true,"url":"https://api.github.com/repos/dburkart/buildbot","forks_url":"https://api.github.com/repos/dburkart/buildbot/forks","keys_url":"https://api.github.com/repos/dburkart/buildbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dburkart/buildbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dburkart/buildbot/teams","hooks_url":"https://api.github.com/repos/dburkart/buildbot/hooks","issue_events_url":"https://api.github.com/repos/dburkart/buildbot/issues/events{/number}","events_url":"https://api.github.com/repos/dburkart/buildbot/events","assignees_url":"https://api.github.com/repos/dburkart/buildbot/assignees{/user}","branches_url":"https://api.github.com/repos/dburkart/buildbot/branches{/branch}","tags_url":"https://api.github.com/repos/dburkart/buildbot/tags","blobs_url":"https://api.github.com/repos/dburkart/buildbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dburkart/buildbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dburkart/buildbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/dburkart/buildbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dburkart/buildbot/statuses/{sha}","languages_url":"https://api.github.com/repos/dburkart/buildbot/languages","stargazers_url":"https://api.github.com/repos/dburkart/buildbot/stargazers","contributors_url":"https://api.github.com/repos/dburkart/buildbot/contributors","subscribers_url":"https://api.github.com/repos/dburkart/buildbot/subscribers","subscription_url":"https://api.github.com/repos/dburkart/buildbot/subscription","commits_url":"https://api.github.com/repos/dburkart/buildbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/dburkart/buildbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/dburkart/buildbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/dburkart/buildbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/dburkart/buildbot/contents/{+path}","compare_url":"https://api.github.com/repos/dburkart/buildbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dburkart/buildbot/merges","archive_url":"https://api.github.com/repos/dburkart/buildbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dburkart/buildbot/downloads","issues_url":"https://api.github.com/repos/dburkart/buildbot/issues{/number}","pulls_url":"https://api.github.com/repos/dburkart/buildbot/pulls{/number}","milestones_url":"https://api.github.com/repos/dburkart/buildbot/milestones{/number}","notifications_url":"https://api.github.com/repos/dburkart/buildbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dburkart/buildbot/labels{/name}","releases_url":"https://api.github.com/repos/dburkart/buildbot/releases{/id}","created_at":"2014-12-18T18:03:57Z","updated_at":"2014-12-18T18:04:01Z","pushed_at":"2014-12-18T19:22:25Z","git_url":"git://github.com/dburkart/buildbot.git","ssh_url":"git@github.com:dburkart/buildbot.git","clone_url":"https://github.com/dburkart/buildbot.git","svn_url":"https://github.com/dburkart/buildbot","homepage":"http://buildbot.net","size":33666,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"buildbot:master","ref":"master","sha":"ff19331c2e266e510802d04ebf6b082e5b479886","user":{"login":"buildbot","id":324515,"avatar_url":"https://avatars.githubusercontent.com/u/324515?v=3","gravatar_id":"","url":"https://api.github.com/users/buildbot","html_url":"https://github.com/buildbot","followers_url":"https://api.github.com/users/buildbot/followers","following_url":"https://api.github.com/users/buildbot/following{/other_user}","gists_url":"https://api.github.com/users/buildbot/gists{/gist_id}","starred_url":"https://api.github.com/users/buildbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildbot/subscriptions","organizations_url":"https://api.github.com/users/buildbot/orgs","repos_url":"https://api.github.com/users/buildbot/repos","events_url":"https://api.github.com/users/buildbot/events{/privacy}","received_events_url":"https://api.github.com/users/buildbot/received_events","type":"Organization","site_admin":false},"repo":{"id":760165,"name":"buildbot","full_name":"buildbot/buildbot","owner":{"login":"buildbot","id":324515,"avatar_url":"https://avatars.githubusercontent.com/u/324515?v=3","gravatar_id":"","url":"https://api.github.com/users/buildbot","html_url":"https://github.com/buildbot","followers_url":"https://api.github.com/users/buildbot/followers","following_url":"https://api.github.com/users/buildbot/following{/other_user}","gists_url":"https://api.github.com/users/buildbot/gists{/gist_id}","starred_url":"https://api.github.com/users/buildbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildbot/subscriptions","organizations_url":"https://api.github.com/users/buildbot/orgs","repos_url":"https://api.github.com/users/buildbot/repos","events_url":"https://api.github.com/users/buildbot/events{/privacy}","received_events_url":"https://api.github.com/users/buildbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/buildbot/buildbot","description":"Python-based continuous integration testing framework; send pull requests for your patches!","fork":false,"url":"https://api.github.com/repos/buildbot/buildbot","forks_url":"https://api.github.com/repos/buildbot/buildbot/forks","keys_url":"https://api.github.com/repos/buildbot/buildbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buildbot/buildbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buildbot/buildbot/teams","hooks_url":"https://api.github.com/repos/buildbot/buildbot/hooks","issue_events_url":"https://api.github.com/repos/buildbot/buildbot/issues/events{/number}","events_url":"https://api.github.com/repos/buildbot/buildbot/events","assignees_url":"https://api.github.com/repos/buildbot/buildbot/assignees{/user}","branches_url":"https://api.github.com/repos/buildbot/buildbot/branches{/branch}","tags_url":"https://api.github.com/repos/buildbot/buildbot/tags","blobs_url":"https://api.github.com/repos/buildbot/buildbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buildbot/buildbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buildbot/buildbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/buildbot/buildbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buildbot/buildbot/statuses/{sha}","languages_url":"https://api.github.com/repos/buildbot/buildbot/languages","stargazers_url":"https://api.github.com/repos/buildbot/buildbot/stargazers","contributors_url":"https://api.github.com/repos/buildbot/buildbot/contributors","subscribers_url":"https://api.github.com/repos/buildbot/buildbot/subscribers","subscription_url":"https://api.github.com/repos/buildbot/buildbot/subscription","commits_url":"https://api.github.com/repos/buildbot/buildbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/buildbot/buildbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/buildbot/buildbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/buildbot/buildbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/buildbot/buildbot/contents/{+path}","compare_url":"https://api.github.com/repos/buildbot/buildbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buildbot/buildbot/merges","archive_url":"https://api.github.com/repos/buildbot/buildbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buildbot/buildbot/downloads","issues_url":"https://api.github.com/repos/buildbot/buildbot/issues{/number}","pulls_url":"https://api.github.com/repos/buildbot/buildbot/pulls{/number}","milestones_url":"https://api.github.com/repos/buildbot/buildbot/milestones{/number}","notifications_url":"https://api.github.com/repos/buildbot/buildbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buildbot/buildbot/labels{/name}","releases_url":"https://api.github.com/repos/buildbot/buildbot/releases{/id}","created_at":"2010-07-06T17:56:53Z","updated_at":"2015-04-03T06:20:04Z","pushed_at":"2015-04-03T06:20:04Z","git_url":"git://github.com/buildbot/buildbot.git","ssh_url":"git@github.com:buildbot/buildbot.git","clone_url":"https://github.com/buildbot/buildbot.git","svn_url":"https://github.com/buildbot/buildbot","homepage":"http://buildbot.net","size":50689,"stargazers_count":1475,"watchers_count":1475,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":679,"mirror_url":null,"open_issues_count":18,"forks":679,"open_issues":18,"watchers":1475,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/1458"},"html":{"href":"https://github.com/buildbot/buildbot/pull/1458"},"issue":{"href":"https://api.github.com/repos/buildbot/buildbot/issues/1458"},"comments":{"href":"https://api.github.com/repos/buildbot/buildbot/issues/1458/comments"},"review_comments":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/1458/comments"},"review_comment":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/1458/commits"},"statuses":{"href":"https://api.github.com/repos/buildbot/buildbot/statuses/af08a69deb41d9f4bff827e65451fdce5babea42"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":12,"review_comments":0,"commits":1,"additions":1,"deletions":4,"changed_files":1}}