{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/componentkit/pulls/comments/31493870","id":31493870,"diff_hunk":"@@ -348,20 +348,26 @@ static void _iterate(CK::ArrayController::Input::Items::ItemsBucketizedBySection\n }\n \n /**\n- Clients of Output::Changeset::map() may reuturn invalid pairs. For example {nil, <object>} for a deletion, instead of\n+ Clients of Output::Changeset::map() may return invalid pairs. For example {nil, <object>} for a deletion, instead of\n  {<object>, nil}.\n  */\n-NS_INLINE void _validateBeforeAfterPair(Output::Changeset::BeforeAfterPair pair, IndexPath indexPath, CKArrayControllerChangeType changeType)\n+NS_INLINE void _validateBeforeAfterPair(Output::Changeset::BeforeAfterPair pair, IndexPath sourceIndexPath, IndexPath destinationIndexPath, CKArrayControllerChangeType changeType)\n {\n   if (changeType == CKArrayControllerChangeTypeUpdate) {\n-    CKInternalConsistencyCheckIf(pair.first != nil, ([NSString stringWithFormat:@\"update {%zd, %zd}: before MUST NOT be nil.\", indexPath.item, indexPath.section]));\n-    CKInternalConsistencyCheckIf(pair.second != nil, ([NSString stringWithFormat:@\"update {%zd, %zd}: after MUST NOT be nil.\", indexPath.item, indexPath.section]));\n+    CKInternalConsistencyCheckIf(pair.first != nil, ([NSString stringWithFormat:@\"update {%zd, %zd}: before MUST NOT be nil.\", sourceIndexPath.item, sourceIndexPath.section]));\n+    CKInternalConsistencyCheckIf(pair.second != nil, ([NSString stringWithFormat:@\"update {%zd, %zd}: after MUST NOT be nil.\", sourceIndexPath.item, sourceIndexPath.section]));\n+    CKInternalConsistencyCheckIf(sourceIndexPath.section != NSNotFound, ([NSString stringWithFormat:@\"update MUST have sourceIndexPath\"]));","path":"ComponentKit/Utilities/CKArrayControllerChangeset.mm","position":38,"original_position":38,"commit_id":"66cdd221f840b712a6c38f05e693e253945aa2e8","original_commit_id":"66cdd221f840b712a6c38f05e693e253945aa2e8","user":{"login":"benlodotcom","id":313959,"avatar_url":"https://avatars.githubusercontent.com/u/313959?v=3","gravatar_id":"","url":"https://api.github.com/users/benlodotcom","html_url":"https://github.com/benlodotcom","followers_url":"https://api.github.com/users/benlodotcom/followers","following_url":"https://api.github.com/users/benlodotcom/following{/other_user}","gists_url":"https://api.github.com/users/benlodotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/benlodotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benlodotcom/subscriptions","organizations_url":"https://api.github.com/users/benlodotcom/orgs","repos_url":"https://api.github.com/users/benlodotcom/repos","events_url":"https://api.github.com/users/benlodotcom/events{/privacy}","received_events_url":"https://api.github.com/users/benlodotcom/received_events","type":"User","site_admin":false},"body":"Ok but what about the row, let's compare the indexPath value to {} instead","created_at":"2015-06-02T05:35:56Z","updated_at":"2015-06-02T05:35:56Z","html_url":"https://github.com/facebook/componentkit/pull/217#discussion_r31493870","pull_request_url":"https://api.github.com/repos/facebook/componentkit/pulls/217","_links":{"self":{"href":"https://api.github.com/repos/facebook/componentkit/pulls/comments/31493870"},"html":{"href":"https://github.com/facebook/componentkit/pull/217#discussion_r31493870"},"pull_request":{"href":"https://api.github.com/repos/facebook/componentkit/pulls/217"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/componentkit/pulls/217","id":36549821,"html_url":"https://github.com/facebook/componentkit/pull/217","diff_url":"https://github.com/facebook/componentkit/pull/217.diff","patch_url":"https://github.com/facebook/componentkit/pull/217.patch","issue_url":"https://api.github.com/repos/facebook/componentkit/issues/217","number":217,"state":"open","locked":false,"title":"[CDS] more preparation for moves","user":{"login":"majak","id":713625,"avatar_url":"https://avatars.githubusercontent.com/u/713625?v=3","gravatar_id":"","url":"https://api.github.com/users/majak","html_url":"https://github.com/majak","followers_url":"https://api.github.com/users/majak/followers","following_url":"https://api.github.com/users/majak/following{/other_user}","gists_url":"https://api.github.com/users/majak/gists{/gist_id}","starred_url":"https://api.github.com/users/majak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majak/subscriptions","organizations_url":"https://api.github.com/users/majak/orgs","repos_url":"https://api.github.com/users/majak/repos","events_url":"https://api.github.com/users/majak/events{/privacy}","received_events_url":"https://api.github.com/users/majak/received_events","type":"User","site_admin":false},"body":"New updates in `CKArrayControllerOutputItems` are no longer specified as `CKArrayControllerOutputChange`, but only as a minimal set of values which specify update command. \r\nExtends `CKArrayControllerOutputChange` and `CKComponentPreparationItem` to work with two indexPaths.","created_at":"2015-05-29T22:13:04Z","updated_at":"2015-06-02T05:35:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2cd4b6114f9727d6cab4a8a93405b4a8be516a45","assignee":{"login":"benlodotcom","id":313959,"avatar_url":"https://avatars.githubusercontent.com/u/313959?v=3","gravatar_id":"","url":"https://api.github.com/users/benlodotcom","html_url":"https://github.com/benlodotcom","followers_url":"https://api.github.com/users/benlodotcom/followers","following_url":"https://api.github.com/users/benlodotcom/following{/other_user}","gists_url":"https://api.github.com/users/benlodotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/benlodotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benlodotcom/subscriptions","organizations_url":"https://api.github.com/users/benlodotcom/orgs","repos_url":"https://api.github.com/users/benlodotcom/repos","events_url":"https://api.github.com/users/benlodotcom/events{/privacy}","received_events_url":"https://api.github.com/users/benlodotcom/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/facebook/componentkit/pulls/217/commits","review_comments_url":"https://api.github.com/repos/facebook/componentkit/pulls/217/comments","review_comment_url":"https://api.github.com/repos/facebook/componentkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/componentkit/issues/217/comments","statuses_url":"https://api.github.com/repos/facebook/componentkit/statuses/66cdd221f840b712a6c38f05e693e253945aa2e8","head":{"label":"majak:moves","ref":"moves","sha":"66cdd221f840b712a6c38f05e693e253945aa2e8","user":{"login":"majak","id":713625,"avatar_url":"https://avatars.githubusercontent.com/u/713625?v=3","gravatar_id":"","url":"https://api.github.com/users/majak","html_url":"https://github.com/majak","followers_url":"https://api.github.com/users/majak/followers","following_url":"https://api.github.com/users/majak/following{/other_user}","gists_url":"https://api.github.com/users/majak/gists{/gist_id}","starred_url":"https://api.github.com/users/majak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majak/subscriptions","organizations_url":"https://api.github.com/users/majak/orgs","repos_url":"https://api.github.com/users/majak/repos","events_url":"https://api.github.com/users/majak/events{/privacy}","received_events_url":"https://api.github.com/users/majak/received_events","type":"User","site_admin":false},"repo":{"id":33434906,"name":"componentkit","full_name":"majak/componentkit","owner":{"login":"majak","id":713625,"avatar_url":"https://avatars.githubusercontent.com/u/713625?v=3","gravatar_id":"","url":"https://api.github.com/users/majak","html_url":"https://github.com/majak","followers_url":"https://api.github.com/users/majak/followers","following_url":"https://api.github.com/users/majak/following{/other_user}","gists_url":"https://api.github.com/users/majak/gists{/gist_id}","starred_url":"https://api.github.com/users/majak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majak/subscriptions","organizations_url":"https://api.github.com/users/majak/orgs","repos_url":"https://api.github.com/users/majak/repos","events_url":"https://api.github.com/users/majak/events{/privacy}","received_events_url":"https://api.github.com/users/majak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/majak/componentkit","description":"A React-inspired view framework for iOS.","fork":true,"url":"https://api.github.com/repos/majak/componentkit","forks_url":"https://api.github.com/repos/majak/componentkit/forks","keys_url":"https://api.github.com/repos/majak/componentkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/majak/componentkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/majak/componentkit/teams","hooks_url":"https://api.github.com/repos/majak/componentkit/hooks","issue_events_url":"https://api.github.com/repos/majak/componentkit/issues/events{/number}","events_url":"https://api.github.com/repos/majak/componentkit/events","assignees_url":"https://api.github.com/repos/majak/componentkit/assignees{/user}","branches_url":"https://api.github.com/repos/majak/componentkit/branches{/branch}","tags_url":"https://api.github.com/repos/majak/componentkit/tags","blobs_url":"https://api.github.com/repos/majak/componentkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/majak/componentkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/majak/componentkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/majak/componentkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/majak/componentkit/statuses/{sha}","languages_url":"https://api.github.com/repos/majak/componentkit/languages","stargazers_url":"https://api.github.com/repos/majak/componentkit/stargazers","contributors_url":"https://api.github.com/repos/majak/componentkit/contributors","subscribers_url":"https://api.github.com/repos/majak/componentkit/subscribers","subscription_url":"https://api.github.com/repos/majak/componentkit/subscription","commits_url":"https://api.github.com/repos/majak/componentkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/majak/componentkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/majak/componentkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/majak/componentkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/majak/componentkit/contents/{+path}","compare_url":"https://api.github.com/repos/majak/componentkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/majak/componentkit/merges","archive_url":"https://api.github.com/repos/majak/componentkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/majak/componentkit/downloads","issues_url":"https://api.github.com/repos/majak/componentkit/issues{/number}","pulls_url":"https://api.github.com/repos/majak/componentkit/pulls{/number}","milestones_url":"https://api.github.com/repos/majak/componentkit/milestones{/number}","notifications_url":"https://api.github.com/repos/majak/componentkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/majak/componentkit/labels{/name}","releases_url":"https://api.github.com/repos/majak/componentkit/releases{/id}","created_at":"2015-04-05T08:19:19Z","updated_at":"2015-04-15T20:02:57Z","pushed_at":"2015-05-29T22:53:02Z","git_url":"git://github.com/majak/componentkit.git","ssh_url":"git@github.com:majak/componentkit.git","clone_url":"https://github.com/majak/componentkit.git","svn_url":"https://github.com/majak/componentkit","homepage":"http://www.componentkit.org/","size":7802,"stargazers_count":0,"watchers_count":0,"language":"Objective-C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"0d25162b8b381dd9f366685cec11607cf9402289","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":32600951,"name":"componentkit","full_name":"facebook/componentkit","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/componentkit","description":"A React-inspired view framework for iOS.","fork":false,"url":"https://api.github.com/repos/facebook/componentkit","forks_url":"https://api.github.com/repos/facebook/componentkit/forks","keys_url":"https://api.github.com/repos/facebook/componentkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/componentkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/componentkit/teams","hooks_url":"https://api.github.com/repos/facebook/componentkit/hooks","issue_events_url":"https://api.github.com/repos/facebook/componentkit/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/componentkit/events","assignees_url":"https://api.github.com/repos/facebook/componentkit/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/componentkit/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/componentkit/tags","blobs_url":"https://api.github.com/repos/facebook/componentkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/componentkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/componentkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/componentkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/componentkit/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/componentkit/languages","stargazers_url":"https://api.github.com/repos/facebook/componentkit/stargazers","contributors_url":"https://api.github.com/repos/facebook/componentkit/contributors","subscribers_url":"https://api.github.com/repos/facebook/componentkit/subscribers","subscription_url":"https://api.github.com/repos/facebook/componentkit/subscription","commits_url":"https://api.github.com/repos/facebook/componentkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/componentkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/componentkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/componentkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/componentkit/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/componentkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/componentkit/merges","archive_url":"https://api.github.com/repos/facebook/componentkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/componentkit/downloads","issues_url":"https://api.github.com/repos/facebook/componentkit/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/componentkit/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/componentkit/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/componentkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/componentkit/labels{/name}","releases_url":"https://api.github.com/repos/facebook/componentkit/releases{/id}","created_at":"2015-03-20T18:42:47Z","updated_at":"2015-06-02T03:29:35Z","pushed_at":"2015-06-02T03:18:00Z","git_url":"git://github.com/facebook/componentkit.git","ssh_url":"git@github.com:facebook/componentkit.git","clone_url":"https://github.com/facebook/componentkit.git","svn_url":"https://github.com/facebook/componentkit","homepage":"http://www.componentkit.org/","size":10448,"stargazers_count":2034,"watchers_count":2034,"language":"Objective-C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":150,"mirror_url":null,"open_issues_count":35,"forks":150,"open_issues":35,"watchers":2034,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/componentkit/pulls/217"},"html":{"href":"https://github.com/facebook/componentkit/pull/217"},"issue":{"href":"https://api.github.com/repos/facebook/componentkit/issues/217"},"comments":{"href":"https://api.github.com/repos/facebook/componentkit/issues/217/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/componentkit/pulls/217/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/componentkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/componentkit/pulls/217/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/componentkit/statuses/66cdd221f840b712a6c38f05e693e253945aa2e8"}}}}