{"action":"created","issue":{"url":"https://api.github.com/repos/OpenSC/engine_pkcs11/issues/22","labels_url":"https://api.github.com/repos/OpenSC/engine_pkcs11/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/OpenSC/engine_pkcs11/issues/22/comments","events_url":"https://api.github.com/repos/OpenSC/engine_pkcs11/issues/22/events","html_url":"https://github.com/OpenSC/engine_pkcs11/pull/22","id":108838922,"number":22,"title":"Exercise different methods for setting the PIN","user":{"login":"levitte","id":698918,"avatar_url":"https://avatars.githubusercontent.com/u/698918?v=3","gravatar_id":"","url":"https://api.github.com/users/levitte","html_url":"https://github.com/levitte","followers_url":"https://api.github.com/users/levitte/followers","following_url":"https://api.github.com/users/levitte/following{/other_user}","gists_url":"https://api.github.com/users/levitte/gists{/gist_id}","starred_url":"https://api.github.com/users/levitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levitte/subscriptions","organizations_url":"https://api.github.com/users/levitte/orgs","repos_url":"https://api.github.com/users/levitte/repos","events_url":"https://api.github.com/users/levitte/events{/privacy}","received_events_url":"https://api.github.com/users/levitte/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-29T10:17:58Z","updated_at":"2015-09-29T10:22:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OpenSC/engine_pkcs11/pulls/22","html_url":"https://github.com/OpenSC/engine_pkcs11/pull/22","diff_url":"https://github.com/OpenSC/engine_pkcs11/pull/22.diff","patch_url":"https://github.com/OpenSC/engine_pkcs11/pull/22.patch"},"body":"tests/evp-sign.c is enhanced with a couple of UI_METHODs to exercise\r\nhaving the PIN set through callback data to a UI_METHOD called by\r\nget_pin, or set through ENGINE_ctrl_cmd_string.  In the latter case,\r\nthere is still a UI_METHOD used, but that one will fail on use,\r\nbecause that will mean get_pin was called and didn't pick up the\r\nexisting pin.\r\n\r\ntests/softhsm gets some additional runs of evp-sign to make sure it\r\nworks in both pin setting modes."},"comment":{"url":"https://api.github.com/repos/OpenSC/engine_pkcs11/issues/comments/144016235","html_url":"https://github.com/OpenSC/engine_pkcs11/pull/22#issuecomment-144016235","issue_url":"https://api.github.com/repos/OpenSC/engine_pkcs11/issues/22","id":144016235,"user":{"login":"levitte","id":698918,"avatar_url":"https://avatars.githubusercontent.com/u/698918?v=3","gravatar_id":"","url":"https://api.github.com/users/levitte","html_url":"https://github.com/levitte","followers_url":"https://api.github.com/users/levitte/followers","following_url":"https://api.github.com/users/levitte/following{/other_user}","gists_url":"https://api.github.com/users/levitte/gists{/gist_id}","starred_url":"https://api.github.com/users/levitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levitte/subscriptions","organizations_url":"https://api.github.com/users/levitte/orgs","repos_url":"https://api.github.com/users/levitte/repos","events_url":"https://api.github.com/users/levitte/events{/privacy}","received_events_url":"https://api.github.com/users/levitte/received_events","type":"User","site_admin":false},"created_at":"2015-09-29T10:22:03Z","updated_at":"2015-09-29T10:22:03Z","body":"Note that with current master, these tests will fail with using the 'default' pin setting method, because `get_pin` make horrendous assumptions about the callback data sent from the evp-sign.\r\n\r\nI expect this to work much better with commit b6da54a849fbf1ba04ba95e1a9386ba42ec59dfb from [pull request 20](https://github.com/OpenSC/engine_pkcs11/pull/20)"}}