{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/32376712","id":32376712,"diff_hunk":"@@ -49,7 +41,7 @@ internal sealed partial class ChainPal : IDisposable, IChainPal\n             return status.dwError == 0;\n         }\n \n-        public IEnumerable<X509ChainElement> ChainElements\n+        public X509ChainElement[] ChainElements","path":"src/System.Security.Cryptography.X509Certificates/src/Internal/Cryptography/Pal.Windows/ChainPal.cs","position":30,"original_position":30,"commit_id":"920c72b271485e05d048b3d4ecafb0f71cd06905","original_commit_id":"920c72b271485e05d048b3d4ecafb0f71cd06905","user":{"login":"bartonjs","id":10642668,"avatar_url":"https://avatars.githubusercontent.com/u/10642668?v=3","gravatar_id":"","url":"https://api.github.com/users/bartonjs","html_url":"https://github.com/bartonjs","followers_url":"https://api.github.com/users/bartonjs/followers","following_url":"https://api.github.com/users/bartonjs/following{/other_user}","gists_url":"https://api.github.com/users/bartonjs/gists{/gist_id}","starred_url":"https://api.github.com/users/bartonjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartonjs/subscriptions","organizations_url":"https://api.github.com/users/bartonjs/orgs","repos_url":"https://api.github.com/users/bartonjs/repos","events_url":"https://api.github.com/users/bartonjs/events{/privacy}","received_events_url":"https://api.github.com/users/bartonjs/received_events","type":"User","site_admin":false},"body":"You mean @dotnet-bot, of course :smile:.  The properties on the PAL types for the certificates are memoized by the calling type, and tend to have the same signature as their entrypoint.  So the allocating property is never called twice.\r\n\r\nThis part of X509 was, shall we say, before my time.  I'd probably have done it as methods, but don't know that changing it is justified.  (I'm merely providing insight here, not trying to add to inertia)","created_at":"2015-06-14T06:08:44Z","updated_at":"2015-06-14T06:08:44Z","html_url":"https://github.com/dotnet/corefx/pull/2033#discussion_r32376712","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/2033","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/32376712"},"html":{"href":"https://github.com/dotnet/corefx/pull/2033#discussion_r32376712"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/2033"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/2033","id":37627788,"html_url":"https://github.com/dotnet/corefx/pull/2033","diff_url":"https://github.com/dotnet/corefx/pull/2033.diff","patch_url":"https://github.com/dotnet/corefx/pull/2033.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/2033","number":2033,"state":"open","locked":false,"title":"Avoid unnecessary allocations related to X509ChainElementCollection","user":{"login":"justinvp","id":710598,"avatar_url":"https://avatars.githubusercontent.com/u/710598?v=3","gravatar_id":"","url":"https://api.github.com/users/justinvp","html_url":"https://github.com/justinvp","followers_url":"https://api.github.com/users/justinvp/followers","following_url":"https://api.github.com/users/justinvp/following{/other_user}","gists_url":"https://api.github.com/users/justinvp/gists{/gist_id}","starred_url":"https://api.github.com/users/justinvp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinvp/subscriptions","organizations_url":"https://api.github.com/users/justinvp/orgs","repos_url":"https://api.github.com/users/justinvp/repos","events_url":"https://api.github.com/users/justinvp/events{/privacy}","received_events_url":"https://api.github.com/users/justinvp/received_events","type":"User","site_admin":false},"body":"- Avoid intermediate `LowLevelList<T>`, `Array`, and `Enumerator` allocations.\r\n- Minor cleanup.\r\n\r\n/cc @bartonjs","created_at":"2015-06-13T16:56:36Z","updated_at":"2015-06-14T06:08:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42dc961f74528fe46e7e52964693d9506f5886d4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/2033/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/2033/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/2033/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/920c72b271485e05d048b3d4ecafb0f71cd06905","head":{"label":"justinvp:x509_chainpal","ref":"x509_chainpal","sha":"920c72b271485e05d048b3d4ecafb0f71cd06905","user":{"login":"justinvp","id":710598,"avatar_url":"https://avatars.githubusercontent.com/u/710598?v=3","gravatar_id":"","url":"https://api.github.com/users/justinvp","html_url":"https://github.com/justinvp","followers_url":"https://api.github.com/users/justinvp/followers","following_url":"https://api.github.com/users/justinvp/following{/other_user}","gists_url":"https://api.github.com/users/justinvp/gists{/gist_id}","starred_url":"https://api.github.com/users/justinvp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinvp/subscriptions","organizations_url":"https://api.github.com/users/justinvp/orgs","repos_url":"https://api.github.com/users/justinvp/repos","events_url":"https://api.github.com/users/justinvp/events{/privacy}","received_events_url":"https://api.github.com/users/justinvp/received_events","type":"User","site_admin":false},"repo":{"id":28229041,"name":"corefx","full_name":"justinvp/corefx","owner":{"login":"justinvp","id":710598,"avatar_url":"https://avatars.githubusercontent.com/u/710598?v=3","gravatar_id":"","url":"https://api.github.com/users/justinvp","html_url":"https://github.com/justinvp","followers_url":"https://api.github.com/users/justinvp/followers","following_url":"https://api.github.com/users/justinvp/following{/other_user}","gists_url":"https://api.github.com/users/justinvp/gists{/gist_id}","starred_url":"https://api.github.com/users/justinvp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinvp/subscriptions","organizations_url":"https://api.github.com/users/justinvp/orgs","repos_url":"https://api.github.com/users/justinvp/repos","events_url":"https://api.github.com/users/justinvp/events{/privacy}","received_events_url":"https://api.github.com/users/justinvp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/justinvp/corefx","description":"This repository contains the foundational libraries that make up the .NET Core development stack.","fork":true,"url":"https://api.github.com/repos/justinvp/corefx","forks_url":"https://api.github.com/repos/justinvp/corefx/forks","keys_url":"https://api.github.com/repos/justinvp/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/justinvp/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/justinvp/corefx/teams","hooks_url":"https://api.github.com/repos/justinvp/corefx/hooks","issue_events_url":"https://api.github.com/repos/justinvp/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/justinvp/corefx/events","assignees_url":"https://api.github.com/repos/justinvp/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/justinvp/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/justinvp/corefx/tags","blobs_url":"https://api.github.com/repos/justinvp/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/justinvp/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/justinvp/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/justinvp/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/justinvp/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/justinvp/corefx/languages","stargazers_url":"https://api.github.com/repos/justinvp/corefx/stargazers","contributors_url":"https://api.github.com/repos/justinvp/corefx/contributors","subscribers_url":"https://api.github.com/repos/justinvp/corefx/subscribers","subscription_url":"https://api.github.com/repos/justinvp/corefx/subscription","commits_url":"https://api.github.com/repos/justinvp/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/justinvp/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/justinvp/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/justinvp/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/justinvp/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/justinvp/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/justinvp/corefx/merges","archive_url":"https://api.github.com/repos/justinvp/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/justinvp/corefx/downloads","issues_url":"https://api.github.com/repos/justinvp/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/justinvp/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/justinvp/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/justinvp/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/justinvp/corefx/labels{/name}","releases_url":"https://api.github.com/repos/justinvp/corefx/releases{/id}","created_at":"2014-12-19T12:43:43Z","updated_at":"2015-04-30T22:29:39Z","pushed_at":"2015-06-13T16:53:07Z","git_url":"git://github.com/justinvp/corefx.git","ssh_url":"git@github.com:justinvp/corefx.git","clone_url":"https://github.com/justinvp/corefx.git","svn_url":"https://github.com/justinvp/corefx","homepage":"","size":21360,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"8f390a79695b2f070cc832395438fe51f5c22d3d","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","created_at":"2014-11-06T23:42:48Z","updated_at":"2015-06-14T03:37:05Z","pushed_at":"2015-06-14T02:56:05Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/core/","size":45652,"stargazers_count":7915,"watchers_count":7915,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1607,"mirror_url":null,"open_issues_count":417,"forks":1607,"open_issues":417,"watchers":7915,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/2033"},"html":{"href":"https://github.com/dotnet/corefx/pull/2033"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/2033"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/2033/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/2033/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/2033/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/920c72b271485e05d048b3d4ecafb0f71cd06905"}}}}