{"action":"created","comment":{"url":"https://api.github.com/repos/twitter/finagle/pulls/comments/28723905","id":28723905,"diff_hunk":"@@ -0,0 +1,13 @@\n+# Finable Thrift - Trace Ruby Thread Saftey\n+\n+## Synopsis\n+Design decisions behind thread saftey in Trace","path":"finagle-thrift/src/main/ruby/README.md","position":4,"original_position":4,"commit_id":"5df0dacdd53c9bacb31bf2f3dcd1f29d82859075","original_commit_id":"5df0dacdd53c9bacb31bf2f3dcd1f29d82859075","user":{"login":"mosesn","id":156562,"avatar_url":"https://avatars.githubusercontent.com/u/156562?v=3","gravatar_id":"","url":"https://api.github.com/users/mosesn","html_url":"https://github.com/mosesn","followers_url":"https://api.github.com/users/mosesn/followers","following_url":"https://api.github.com/users/mosesn/following{/other_user}","gists_url":"https://api.github.com/users/mosesn/gists{/gist_id}","starred_url":"https://api.github.com/users/mosesn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mosesn/subscriptions","organizations_url":"https://api.github.com/users/mosesn/orgs","repos_url":"https://api.github.com/users/mosesn/repos","events_url":"https://api.github.com/users/mosesn/events{/privacy}","received_events_url":"https://api.github.com/users/mosesn/received_events","type":"User","site_admin":false},"body":"I'm not sure this makes sense from a user perspective.  Most folks reading the README probably don't care terribly about the design decision, and probably care more about how to use it.  If you want to document the design decision, probably best to do that in the code.  Could we keep the README just focusing on what is a valid use of tracing?","created_at":"2015-04-20T20:09:00Z","updated_at":"2015-04-20T20:09:00Z","html_url":"https://github.com/twitter/finagle/pull/363#discussion_r28723905","pull_request_url":"https://api.github.com/repos/twitter/finagle/pulls/363","_links":{"self":{"href":"https://api.github.com/repos/twitter/finagle/pulls/comments/28723905"},"html":{"href":"https://github.com/twitter/finagle/pull/363#discussion_r28723905"},"pull_request":{"href":"https://api.github.com/repos/twitter/finagle/pulls/363"}}},"pull_request":{"url":"https://api.github.com/repos/twitter/finagle/pulls/363","id":32912805,"html_url":"https://github.com/twitter/finagle/pull/363","diff_url":"https://github.com/twitter/finagle/pull/363.diff","patch_url":"https://github.com/twitter/finagle/pull/363.patch","issue_url":"https://api.github.com/repos/twitter/finagle/issues/363","number":363,"state":"open","locked":false,"title":"Make Trace's internal stack thread local","user":{"login":"jamescway","id":473680,"avatar_url":"https://avatars.githubusercontent.com/u/473680?v=3","gravatar_id":"","url":"https://api.github.com/users/jamescway","html_url":"https://github.com/jamescway","followers_url":"https://api.github.com/users/jamescway/followers","following_url":"https://api.github.com/users/jamescway/following{/other_user}","gists_url":"https://api.github.com/users/jamescway/gists{/gist_id}","starred_url":"https://api.github.com/users/jamescway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamescway/subscriptions","organizations_url":"https://api.github.com/users/jamescway/orgs","repos_url":"https://api.github.com/users/jamescway/repos","events_url":"https://api.github.com/users/jamescway/events{/privacy}","received_events_url":"https://api.github.com/users/jamescway/received_events","type":"User","site_admin":false},"body":"Trace's global stack variable is not thread safe. Changing to be thread local for thread safety.  \r\n\r\nWe are using finagle-thrift as part of tracing service calls with Zipkin.\r\n\r\nThis issue manifest itself with Jruby 1.7 and a multi threaded application.","created_at":"2015-04-08T23:34:34Z","updated_at":"2015-04-20T20:09:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"411343b8d56b647b51df4e3fd41afe1c2e73f7c2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/twitter/finagle/pulls/363/commits","review_comments_url":"https://api.github.com/repos/twitter/finagle/pulls/363/comments","review_comment_url":"https://api.github.com/repos/twitter/finagle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twitter/finagle/issues/363/comments","statuses_url":"https://api.github.com/repos/twitter/finagle/statuses/5df0dacdd53c9bacb31bf2f3dcd1f29d82859075","head":{"label":"jamescway:safe","ref":"safe","sha":"5df0dacdd53c9bacb31bf2f3dcd1f29d82859075","user":{"login":"jamescway","id":473680,"avatar_url":"https://avatars.githubusercontent.com/u/473680?v=3","gravatar_id":"","url":"https://api.github.com/users/jamescway","html_url":"https://github.com/jamescway","followers_url":"https://api.github.com/users/jamescway/followers","following_url":"https://api.github.com/users/jamescway/following{/other_user}","gists_url":"https://api.github.com/users/jamescway/gists{/gist_id}","starred_url":"https://api.github.com/users/jamescway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamescway/subscriptions","organizations_url":"https://api.github.com/users/jamescway/orgs","repos_url":"https://api.github.com/users/jamescway/repos","events_url":"https://api.github.com/users/jamescway/events{/privacy}","received_events_url":"https://api.github.com/users/jamescway/received_events","type":"User","site_admin":false},"repo":{"id":33145491,"name":"finagle","full_name":"jamescway/finagle","owner":{"login":"jamescway","id":473680,"avatar_url":"https://avatars.githubusercontent.com/u/473680?v=3","gravatar_id":"","url":"https://api.github.com/users/jamescway","html_url":"https://github.com/jamescway","followers_url":"https://api.github.com/users/jamescway/followers","following_url":"https://api.github.com/users/jamescway/following{/other_user}","gists_url":"https://api.github.com/users/jamescway/gists{/gist_id}","starred_url":"https://api.github.com/users/jamescway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamescway/subscriptions","organizations_url":"https://api.github.com/users/jamescway/orgs","repos_url":"https://api.github.com/users/jamescway/repos","events_url":"https://api.github.com/users/jamescway/events{/privacy}","received_events_url":"https://api.github.com/users/jamescway/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jamescway/finagle","description":"A fault tolerant, protocol-agnostic RPC system","fork":true,"url":"https://api.github.com/repos/jamescway/finagle","forks_url":"https://api.github.com/repos/jamescway/finagle/forks","keys_url":"https://api.github.com/repos/jamescway/finagle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jamescway/finagle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jamescway/finagle/teams","hooks_url":"https://api.github.com/repos/jamescway/finagle/hooks","issue_events_url":"https://api.github.com/repos/jamescway/finagle/issues/events{/number}","events_url":"https://api.github.com/repos/jamescway/finagle/events","assignees_url":"https://api.github.com/repos/jamescway/finagle/assignees{/user}","branches_url":"https://api.github.com/repos/jamescway/finagle/branches{/branch}","tags_url":"https://api.github.com/repos/jamescway/finagle/tags","blobs_url":"https://api.github.com/repos/jamescway/finagle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jamescway/finagle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jamescway/finagle/git/refs{/sha}","trees_url":"https://api.github.com/repos/jamescway/finagle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jamescway/finagle/statuses/{sha}","languages_url":"https://api.github.com/repos/jamescway/finagle/languages","stargazers_url":"https://api.github.com/repos/jamescway/finagle/stargazers","contributors_url":"https://api.github.com/repos/jamescway/finagle/contributors","subscribers_url":"https://api.github.com/repos/jamescway/finagle/subscribers","subscription_url":"https://api.github.com/repos/jamescway/finagle/subscription","commits_url":"https://api.github.com/repos/jamescway/finagle/commits{/sha}","git_commits_url":"https://api.github.com/repos/jamescway/finagle/git/commits{/sha}","comments_url":"https://api.github.com/repos/jamescway/finagle/comments{/number}","issue_comment_url":"https://api.github.com/repos/jamescway/finagle/issues/comments{/number}","contents_url":"https://api.github.com/repos/jamescway/finagle/contents/{+path}","compare_url":"https://api.github.com/repos/jamescway/finagle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jamescway/finagle/merges","archive_url":"https://api.github.com/repos/jamescway/finagle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jamescway/finagle/downloads","issues_url":"https://api.github.com/repos/jamescway/finagle/issues{/number}","pulls_url":"https://api.github.com/repos/jamescway/finagle/pulls{/number}","milestones_url":"https://api.github.com/repos/jamescway/finagle/milestones{/number}","notifications_url":"https://api.github.com/repos/jamescway/finagle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jamescway/finagle/labels{/name}","releases_url":"https://api.github.com/repos/jamescway/finagle/releases{/id}","created_at":"2015-03-30T20:13:44Z","updated_at":"2015-04-20T17:51:41Z","pushed_at":"2015-04-20T17:54:09Z","git_url":"git://github.com/jamescway/finagle.git","ssh_url":"git@github.com:jamescway/finagle.git","clone_url":"https://github.com/jamescway/finagle.git","svn_url":"https://github.com/jamescway/finagle","homepage":"http://twitter.github.io/finagle","size":25840,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"twitter:master","ref":"master","sha":"1e06db17ca2de4b85209dd2fbc18e635815e994b","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":1007362,"name":"finagle","full_name":"twitter/finagle","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/finagle","description":"A fault tolerant, protocol-agnostic RPC system","fork":false,"url":"https://api.github.com/repos/twitter/finagle","forks_url":"https://api.github.com/repos/twitter/finagle/forks","keys_url":"https://api.github.com/repos/twitter/finagle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/finagle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/finagle/teams","hooks_url":"https://api.github.com/repos/twitter/finagle/hooks","issue_events_url":"https://api.github.com/repos/twitter/finagle/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/finagle/events","assignees_url":"https://api.github.com/repos/twitter/finagle/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/finagle/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/finagle/tags","blobs_url":"https://api.github.com/repos/twitter/finagle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/finagle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/finagle/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/finagle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/finagle/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/finagle/languages","stargazers_url":"https://api.github.com/repos/twitter/finagle/stargazers","contributors_url":"https://api.github.com/repos/twitter/finagle/contributors","subscribers_url":"https://api.github.com/repos/twitter/finagle/subscribers","subscription_url":"https://api.github.com/repos/twitter/finagle/subscription","commits_url":"https://api.github.com/repos/twitter/finagle/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/finagle/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/finagle/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/finagle/issues/comments{/number}","contents_url":"https://api.github.com/repos/twitter/finagle/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/finagle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/finagle/merges","archive_url":"https://api.github.com/repos/twitter/finagle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/finagle/downloads","issues_url":"https://api.github.com/repos/twitter/finagle/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/finagle/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/finagle/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/finagle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/finagle/labels{/name}","releases_url":"https://api.github.com/repos/twitter/finagle/releases{/id}","created_at":"2010-10-19T22:10:09Z","updated_at":"2015-04-20T17:16:39Z","pushed_at":"2015-04-20T20:03:19Z","git_url":"git://github.com/twitter/finagle.git","ssh_url":"git@github.com:twitter/finagle.git","clone_url":"https://github.com/twitter/finagle.git","svn_url":"https://github.com/twitter/finagle","homepage":"http://twitter.github.io/finagle","size":33729,"stargazers_count":3364,"watchers_count":3364,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":633,"mirror_url":null,"open_issues_count":44,"forks":633,"open_issues":44,"watchers":3364,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter/finagle/pulls/363"},"html":{"href":"https://github.com/twitter/finagle/pull/363"},"issue":{"href":"https://api.github.com/repos/twitter/finagle/issues/363"},"comments":{"href":"https://api.github.com/repos/twitter/finagle/issues/363/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter/finagle/pulls/363/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter/finagle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twitter/finagle/pulls/363/commits"},"statuses":{"href":"https://api.github.com/repos/twitter/finagle/statuses/5df0dacdd53c9bacb31bf2f3dcd1f29d82859075"}}}}