{"action":"closed","number":19007,"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/19007","id":29655086,"html_url":"https://github.com/rails/rails/pull/19007","diff_url":"https://github.com/rails/rails/pull/19007.diff","patch_url":"https://github.com/rails/rails/pull/19007.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/19007","number":19007,"state":"closed","locked":false,"title":"Cache url_helpers instead of creating each time","user":{"login":"evanphx","id":7,"avatar_url":"https://avatars.githubusercontent.com/u/7?v=3","gravatar_id":"","url":"https://api.github.com/users/evanphx","html_url":"https://github.com/evanphx","followers_url":"https://api.github.com/users/evanphx/followers","following_url":"https://api.github.com/users/evanphx/following{/other_user}","gists_url":"https://api.github.com/users/evanphx/gists{/gist_id}","starred_url":"https://api.github.com/users/evanphx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evanphx/subscriptions","organizations_url":"https://api.github.com/users/evanphx/orgs","repos_url":"https://api.github.com/users/evanphx/repos","events_url":"https://api.github.com/users/evanphx/events{/privacy}","received_events_url":"https://api.github.com/users/evanphx/received_events","type":"User","site_admin":false},"body":"This has 2 effects:\r\n\r\n1. RoutesProxy is CRAZY faster because it's no longer creating a new\r\nModule each time method_missing is hit.\r\n2. It bypasses an existing bug in ruby that makes `class << obj` unsafe\r\nto be used in threading contexts.","created_at":"2015-02-19T22:24:02Z","updated_at":"2015-02-19T23:34:51Z","closed_at":"2015-02-19T23:34:51Z","merged_at":"2015-02-19T23:34:51Z","merge_commit_sha":"9b038b9621360a73512bb26e788a7420773e4a70","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/19007/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/19007/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rails/rails/issues/19007/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/e002a68a4ec19c1d4278e9b523283f59fbe56be1","head":{"label":"evanphx:route_proxy","ref":"route_proxy","sha":"e002a68a4ec19c1d4278e9b523283f59fbe56be1","user":{"login":"evanphx","id":7,"avatar_url":"https://avatars.githubusercontent.com/u/7?v=3","gravatar_id":"","url":"https://api.github.com/users/evanphx","html_url":"https://github.com/evanphx","followers_url":"https://api.github.com/users/evanphx/followers","following_url":"https://api.github.com/users/evanphx/following{/other_user}","gists_url":"https://api.github.com/users/evanphx/gists{/gist_id}","starred_url":"https://api.github.com/users/evanphx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evanphx/subscriptions","organizations_url":"https://api.github.com/users/evanphx/orgs","repos_url":"https://api.github.com/users/evanphx/repos","events_url":"https://api.github.com/users/evanphx/events{/privacy}","received_events_url":"https://api.github.com/users/evanphx/received_events","type":"User","site_admin":false},"repo":{"id":31040082,"name":"rails","full_name":"evanphx/rails","owner":{"login":"evanphx","id":7,"avatar_url":"https://avatars.githubusercontent.com/u/7?v=3","gravatar_id":"","url":"https://api.github.com/users/evanphx","html_url":"https://github.com/evanphx","followers_url":"https://api.github.com/users/evanphx/followers","following_url":"https://api.github.com/users/evanphx/following{/other_user}","gists_url":"https://api.github.com/users/evanphx/gists{/gist_id}","starred_url":"https://api.github.com/users/evanphx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evanphx/subscriptions","organizations_url":"https://api.github.com/users/evanphx/orgs","repos_url":"https://api.github.com/users/evanphx/repos","events_url":"https://api.github.com/users/evanphx/events{/privacy}","received_events_url":"https://api.github.com/users/evanphx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/evanphx/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/evanphx/rails","forks_url":"https://api.github.com/repos/evanphx/rails/forks","keys_url":"https://api.github.com/repos/evanphx/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evanphx/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evanphx/rails/teams","hooks_url":"https://api.github.com/repos/evanphx/rails/hooks","issue_events_url":"https://api.github.com/repos/evanphx/rails/issues/events{/number}","events_url":"https://api.github.com/repos/evanphx/rails/events","assignees_url":"https://api.github.com/repos/evanphx/rails/assignees{/user}","branches_url":"https://api.github.com/repos/evanphx/rails/branches{/branch}","tags_url":"https://api.github.com/repos/evanphx/rails/tags","blobs_url":"https://api.github.com/repos/evanphx/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evanphx/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evanphx/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/evanphx/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evanphx/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/evanphx/rails/languages","stargazers_url":"https://api.github.com/repos/evanphx/rails/stargazers","contributors_url":"https://api.github.com/repos/evanphx/rails/contributors","subscribers_url":"https://api.github.com/repos/evanphx/rails/subscribers","subscription_url":"https://api.github.com/repos/evanphx/rails/subscription","commits_url":"https://api.github.com/repos/evanphx/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/evanphx/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/evanphx/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/evanphx/rails/issues/comments/{number}","contents_url":"https://api.github.com/repos/evanphx/rails/contents/{+path}","compare_url":"https://api.github.com/repos/evanphx/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evanphx/rails/merges","archive_url":"https://api.github.com/repos/evanphx/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evanphx/rails/downloads","issues_url":"https://api.github.com/repos/evanphx/rails/issues{/number}","pulls_url":"https://api.github.com/repos/evanphx/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/evanphx/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/evanphx/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evanphx/rails/labels{/name}","releases_url":"https://api.github.com/repos/evanphx/rails/releases{/id}","created_at":"2015-02-19T22:22:19Z","updated_at":"2015-02-19T22:22:53Z","pushed_at":"2015-02-19T23:11:11Z","git_url":"git://github.com/evanphx/rails.git","ssh_url":"git@github.com:evanphx/rails.git","clone_url":"https://github.com/evanphx/rails.git","svn_url":"https://github.com/evanphx/rails","homepage":"http://rubyonrails.org","size":377154,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"da2987afc9b1a03899304c0ea24a1dec395d39b8","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments/{number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","created_at":"2008-04-11T02:19:47Z","updated_at":"2015-02-19T19:39:29Z","pushed_at":"2015-02-19T23:34:51Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":377154,"stargazers_count":25015,"watchers_count":25015,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9752,"mirror_url":null,"open_issues_count":743,"forks":9752,"open_issues":743,"watchers":25015,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/19007"},"html":{"href":"https://github.com/rails/rails/pull/19007"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/19007"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/19007/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/19007/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/19007/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/e002a68a4ec19c1d4278e9b523283f59fbe56be1"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"rafaelfranca","id":47848,"avatar_url":"https://avatars.githubusercontent.com/u/47848?v=3","gravatar_id":"","url":"https://api.github.com/users/rafaelfranca","html_url":"https://github.com/rafaelfranca","followers_url":"https://api.github.com/users/rafaelfranca/followers","following_url":"https://api.github.com/users/rafaelfranca/following{/other_user}","gists_url":"https://api.github.com/users/rafaelfranca/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelfranca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelfranca/subscriptions","organizations_url":"https://api.github.com/users/rafaelfranca/orgs","repos_url":"https://api.github.com/users/rafaelfranca/repos","events_url":"https://api.github.com/users/rafaelfranca/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelfranca/received_events","type":"User","site_admin":false},"comments":0,"review_comments":3,"commits":2,"additions":9,"deletions":6,"changed_files":3}}