{"push_id":649470013,"size":3,"distinct_size":3,"ref":"refs/heads/master","head":"87f47a60ae0bc1c5351cb409954e70f0f80a8aab","before":"0fc0b9a6717d9cdfa35df60eceb0549b51bf237d","commits":[{"sha":"d710684f8efb4a557aa7ef116e13e1306eafeceb","author":{"email":"97e4d5d0e400e5ad37382425ea95bde8b3933403@squaremobius.net","name":"Michael Bridgen"},"message":"Should not pass value of `$PROCFS` (close #622)\n\nThis is picked from squaremo/weave@d3cc606d5b356dff59ce2ab8304d8b54b27a61b9\n\nThe environment variable `PROCFS` was originally added so that the script\ncould be run in a container. The host's /proc is bind-mounted as /hostproc,\nand the script must be told this.\n\nThe remote weaving changes got this a bit wrong, by using the value of\n`$PROCFS` in a \"volume\" mount argument (`-v`) to docker -- but when\ninvoking a container, the left-hand-side of the volume mount should\n*always* be `/proc` (and the right-hand-side always `/hostproc`),\nsince it will always be binding the host's `/proc` to the container's\n`/hostproc`.\n\nThe gist is that docker looks at host's root filesystem and if you\npass `-v /hostporc:/hostproc` when running from a container where\nyou have already bind-mounted it, it will end-up creating empty\ndirectory in the target container as there is no `/hostproc` from\ndocker's perspective.","distinct":true,"url":"https://api.github.com/repos/weaveworks/weave/commits/d710684f8efb4a557aa7ef116e13e1306eafeceb"},{"sha":"9d0c9f1264eea31f0496e3593cc4285c5ad97dd8","author":{"email":"59b6733e47280dc0842a1e64fb2a9c742d686e46@gmail.com","name":"Ilya Dmitrichenko"},"message":"Move definition of `$PROCFS` (cosmetic)\n\nIt's not required to be set at the top, it's only looked at down below.","distinct":true,"url":"https://api.github.com/repos/weaveworks/weave/commits/9d0c9f1264eea31f0496e3593cc4285c5ad97dd8"},{"sha":"87f47a60ae0bc1c5351cb409954e70f0f80a8aab","author":{"email":"ac8fcaf748b7189c49a384a5580dc9e80633299a@gmail.com","name":"rade"},"message":"Merge pull request #621 from errordeveloper/fix-binding-hostproc-within-container-where-is-already-bound\n\nShould not pass value of `$PROCFS`\r\n\r\nFixes #622.","distinct":true,"url":"https://api.github.com/repos/weaveworks/weave/commits/87f47a60ae0bc1c5351cb409954e70f0f80a8aab"}]}