{"action":"created","issue":{"url":"https://api.github.com/repos/micmro/performance-bookmarklet/issues/32","labels_url":"https://api.github.com/repos/micmro/performance-bookmarklet/issues/32/labels{/name}","comments_url":"https://api.github.com/repos/micmro/performance-bookmarklet/issues/32/comments","events_url":"https://api.github.com/repos/micmro/performance-bookmarklet/issues/32/events","html_url":"https://github.com/micmro/performance-bookmarklet/pull/32","id":99115434,"number":32,"title":"Page metrics can now be persisted across refreshes","user":{"login":"billthompson","id":1090773,"avatar_url":"https://avatars.githubusercontent.com/u/1090773?v=3","gravatar_id":"","url":"https://api.github.com/users/billthompson","html_url":"https://github.com/billthompson","followers_url":"https://api.github.com/users/billthompson/followers","following_url":"https://api.github.com/users/billthompson/following{/other_user}","gists_url":"https://api.github.com/users/billthompson/gists{/gist_id}","starred_url":"https://api.github.com/users/billthompson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billthompson/subscriptions","organizations_url":"https://api.github.com/users/billthompson/orgs","repos_url":"https://api.github.com/users/billthompson/repos","events_url":"https://api.github.com/users/billthompson/events{/privacy}","received_events_url":"https://api.github.com/users/billthompson/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-08-05T04:42:13Z","updated_at":"2015-08-05T17:03:17Z","closed_at":"2015-08-05T14:42:41Z","pull_request":{"url":"https://api.github.com/repos/micmro/performance-bookmarklet/pulls/32","html_url":"https://github.com/micmro/performance-bookmarklet/pull/32","diff_url":"https://github.com/micmro/performance-bookmarklet/pull/32.diff","patch_url":"https://github.com/micmro/performance-bookmarklet/pull/32.patch"},"body":"## What? Why?\r\nI couldn't find a tool (bookmarklet or extension) that would persist page performance metrics between page refreshes and ideally, I would like to copy the output into a spreadsheet and create pivot tables to analyze the data pre/post page modification.\r\n\r\nThis PR creates a ```PageMetric``` class that stores a very small subset of the data collected to localStorage so that the performance between page loads can be analyzed and compared.\r\n\r\nThis data is exposed via ```PerformanceBookmarklet.PageMetric.dump()```.\r\n\r\nHere's what it looks like in action:\r\n![page-metrics-feature](https://cloud.githubusercontent.com/assets/1090773/9078320/dfaeabb6-3b01-11e5-92e0-5bfc0e770998.gif)\r\n\r\nWhat do you think?\r\n\r\n## Additional Deploy Steps?\r\nNone that I know of. Is there any special testing that I need to do to ensure compatibility with the browser extensions?\r\n\r\n## How was it tested?\r\n* I created a local HTML page and injected the performanceBookmarklet.js into the page.\r\n* Run ```PerformanceBookmarklet.PageMetric.dump(\",\", false);``` from the console. \r\n  * Verify the page metrics are logged to the console as CSV.\r\n  * Verify the localStorage key ```performance-bookmarklet-metrics``` is still present.\r\n* Run ```PerformanceBookmarklet.PageMetric.dump();``` from the console.\r\n  * Verify the page metrics are logged to the console as TSV.\r\n  * Verify the localStorage key ```performance-bookmarklet-metrics``` is NOT present."},"comment":{"url":"https://api.github.com/repos/micmro/performance-bookmarklet/issues/comments/128071027","html_url":"https://github.com/micmro/performance-bookmarklet/pull/32#issuecomment-128071027","issue_url":"https://api.github.com/repos/micmro/performance-bookmarklet/issues/32","id":128071027,"user":{"login":"billthompson","id":1090773,"avatar_url":"https://avatars.githubusercontent.com/u/1090773?v=3","gravatar_id":"","url":"https://api.github.com/users/billthompson","html_url":"https://github.com/billthompson","followers_url":"https://api.github.com/users/billthompson/followers","following_url":"https://api.github.com/users/billthompson/following{/other_user}","gists_url":"https://api.github.com/users/billthompson/gists{/gist_id}","starred_url":"https://api.github.com/users/billthompson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billthompson/subscriptions","organizations_url":"https://api.github.com/users/billthompson/orgs","repos_url":"https://api.github.com/users/billthompson/repos","events_url":"https://api.github.com/users/billthompson/events{/privacy}","received_events_url":"https://api.github.com/users/billthompson/received_events","type":"User","site_admin":false},"created_at":"2015-08-05T17:03:17Z","updated_at":"2015-08-05T17:03:17Z","body":"Thanks for reviewing! WebPageTest would have been awesome but in this case I needed to test behind our firewall without the hassle of setting up a private instance. I'm using my fork locally, so no worries on getting this merged. I wasn't even sure if you wanted this functionality.\r\n\r\nThanks for making this bookmarklet available!"}}