{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/23462961","id":23462961,"diff_hunk":"@@ -187,7 +288,34 @@ namespace librbd {\n \t\t\t\t << m_object_image_extents << dendl;\n \n \t  m_state = LIBRBD_AIO_WRITE_COPYUP;\n-\t  read_from_parent(m_object_image_extents);\n+\n+          if (is_copy_on_read(m_ictx, m_snap_id)) {\n+\t    m_ictx->copyup_list_lock.Lock();","path":"src/librbd/AioRequest.cc","position":null,"original_position":231,"commit_id":"27f827279b5e09477a78f103945989a497e70894","original_commit_id":"424ebb62c370e7ed1a66a0a2ca1f674a35302bd1","user":{"login":"dillaman","id":4739042,"avatar_url":"https://avatars.githubusercontent.com/u/4739042?v=3","gravatar_id":"","url":"https://api.github.com/users/dillaman","html_url":"https://github.com/dillaman","followers_url":"https://api.github.com/users/dillaman/followers","following_url":"https://api.github.com/users/dillaman/following{/other_user}","gists_url":"https://api.github.com/users/dillaman/gists{/gist_id}","starred_url":"https://api.github.com/users/dillaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dillaman/subscriptions","organizations_url":"https://api.github.com/users/dillaman/orgs","repos_url":"https://api.github.com/users/dillaman/repos","events_url":"https://api.github.com/users/dillaman/events{/privacy}","received_events_url":"https://api.github.com/users/dillaman/received_events","type":"User","site_admin":false},"body":"@jdurgin The ```read_from_parent``` deletion is protected by the lock acquired in ```CopyupRequest```'s destructor.  Good catch w/ the missing lock for ```append_request```.","created_at":"2015-01-23T16:53:44Z","updated_at":"2015-01-23T16:53:44Z","html_url":"https://github.com/ceph/ceph/pull/3040#discussion_r23462961","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/3040","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/23462961"},"html":{"href":"https://github.com/ceph/ceph/pull/3040#discussion_r23462961"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/3040"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/3040","id":25251353,"html_url":"https://github.com/ceph/ceph/pull/3040","diff_url":"https://github.com/ceph/ceph/pull/3040.diff","patch_url":"https://github.com/ceph/ceph/pull/3040.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/3040","number":3040,"state":"open","locked":false,"title":"RBD copy on read","user":{"login":"cchengleo","id":1903817,"avatar_url":"https://avatars.githubusercontent.com/u/1903817?v=3","gravatar_id":"","url":"https://api.github.com/users/cchengleo","html_url":"https://github.com/cchengleo","followers_url":"https://api.github.com/users/cchengleo/followers","following_url":"https://api.github.com/users/cchengleo/following{/other_user}","gists_url":"https://api.github.com/users/cchengleo/gists{/gist_id}","starred_url":"https://api.github.com/users/cchengleo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cchengleo/subscriptions","organizations_url":"https://api.github.com/users/cchengleo/orgs","repos_url":"https://api.github.com/users/cchengleo/repos","events_url":"https://api.github.com/users/cchengleo/events{/privacy}","received_events_url":"https://api.github.com/users/cchengleo/received_events","type":"User","site_admin":false},"body":"This is the copy-on-read feature based on both cmgitdream's (https://github.com/ceph/ceph/pull/2158) and cchengleo's (https://github.com/ceph/ceph/pull/2587) improvement. Please close https://github.com/ceph/ceph/pull/3030 and https://github.com/ceph/ceph/pull/2852 as it is easier to merge into this.","created_at":"2014-12-01T07:27:42Z","updated_at":"2015-01-23T16:53:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"736a0e705ef6ef141890a245ff5658df3c0ec130","assignee":{"login":"dillaman","id":4739042,"avatar_url":"https://avatars.githubusercontent.com/u/4739042?v=3","gravatar_id":"","url":"https://api.github.com/users/dillaman","html_url":"https://github.com/dillaman","followers_url":"https://api.github.com/users/dillaman/followers","following_url":"https://api.github.com/users/dillaman/following{/other_user}","gists_url":"https://api.github.com/users/dillaman/gists{/gist_id}","starred_url":"https://api.github.com/users/dillaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dillaman/subscriptions","organizations_url":"https://api.github.com/users/dillaman/orgs","repos_url":"https://api.github.com/users/dillaman/repos","events_url":"https://api.github.com/users/dillaman/events{/privacy}","received_events_url":"https://api.github.com/users/dillaman/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/3040/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/3040/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/3040/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/27f827279b5e09477a78f103945989a497e70894","head":{"label":"cchengleo:wip-copy-on-read","ref":"wip-copy-on-read","sha":"27f827279b5e09477a78f103945989a497e70894","user":{"login":"cchengleo","id":1903817,"avatar_url":"https://avatars.githubusercontent.com/u/1903817?v=3","gravatar_id":"","url":"https://api.github.com/users/cchengleo","html_url":"https://github.com/cchengleo","followers_url":"https://api.github.com/users/cchengleo/followers","following_url":"https://api.github.com/users/cchengleo/following{/other_user}","gists_url":"https://api.github.com/users/cchengleo/gists{/gist_id}","starred_url":"https://api.github.com/users/cchengleo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cchengleo/subscriptions","organizations_url":"https://api.github.com/users/cchengleo/orgs","repos_url":"https://api.github.com/users/cchengleo/repos","events_url":"https://api.github.com/users/cchengleo/events{/privacy}","received_events_url":"https://api.github.com/users/cchengleo/received_events","type":"User","site_admin":false},"repo":{"id":23717668,"name":"ceph","full_name":"cchengleo/ceph","owner":{"login":"cchengleo","id":1903817,"avatar_url":"https://avatars.githubusercontent.com/u/1903817?v=3","gravatar_id":"","url":"https://api.github.com/users/cchengleo","html_url":"https://github.com/cchengleo","followers_url":"https://api.github.com/users/cchengleo/followers","following_url":"https://api.github.com/users/cchengleo/following{/other_user}","gists_url":"https://api.github.com/users/cchengleo/gists{/gist_id}","starred_url":"https://api.github.com/users/cchengleo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cchengleo/subscriptions","organizations_url":"https://api.github.com/users/cchengleo/orgs","repos_url":"https://api.github.com/users/cchengleo/repos","events_url":"https://api.github.com/users/cchengleo/events{/privacy}","received_events_url":"https://api.github.com/users/cchengleo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cchengleo/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/cchengleo/ceph","forks_url":"https://api.github.com/repos/cchengleo/ceph/forks","keys_url":"https://api.github.com/repos/cchengleo/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cchengleo/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cchengleo/ceph/teams","hooks_url":"https://api.github.com/repos/cchengleo/ceph/hooks","issue_events_url":"https://api.github.com/repos/cchengleo/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/cchengleo/ceph/events","assignees_url":"https://api.github.com/repos/cchengleo/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/cchengleo/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/cchengleo/ceph/tags","blobs_url":"https://api.github.com/repos/cchengleo/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cchengleo/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cchengleo/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/cchengleo/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cchengleo/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/cchengleo/ceph/languages","stargazers_url":"https://api.github.com/repos/cchengleo/ceph/stargazers","contributors_url":"https://api.github.com/repos/cchengleo/ceph/contributors","subscribers_url":"https://api.github.com/repos/cchengleo/ceph/subscribers","subscription_url":"https://api.github.com/repos/cchengleo/ceph/subscription","commits_url":"https://api.github.com/repos/cchengleo/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/cchengleo/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/cchengleo/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/cchengleo/ceph/issues/comments/{number}","contents_url":"https://api.github.com/repos/cchengleo/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/cchengleo/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cchengleo/ceph/merges","archive_url":"https://api.github.com/repos/cchengleo/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cchengleo/ceph/downloads","issues_url":"https://api.github.com/repos/cchengleo/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/cchengleo/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/cchengleo/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/cchengleo/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cchengleo/ceph/labels{/name}","releases_url":"https://api.github.com/repos/cchengleo/ceph/releases{/id}","created_at":"2014-09-05T20:40:16Z","updated_at":"2015-01-20T03:57:55Z","pushed_at":"2015-01-23T03:38:31Z","git_url":"git://github.com/cchengleo/ceph.git","ssh_url":"git@github.com:cchengleo/ceph.git","clone_url":"https://github.com/cchengleo/ceph.git","svn_url":"https://github.com/cchengleo/ceph","homepage":"http://ceph.com","size":101561,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"026c9cb21cc5ba6b48d2202e112851fcfd42f50d","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments/{number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","created_at":"2011-09-01T21:41:26Z","updated_at":"2015-01-23T16:47:27Z","pushed_at":"2015-01-23T16:47:33Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":329679,"stargazers_count":1093,"watchers_count":1093,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":570,"mirror_url":null,"open_issues_count":87,"forks":570,"open_issues":87,"watchers":1093,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/3040"},"html":{"href":"https://github.com/ceph/ceph/pull/3040"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/3040"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/3040/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/3040/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/3040/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/27f827279b5e09477a78f103945989a497e70894"}}}}