{"push_id":692177127,"size":9,"distinct_size":3,"ref":"refs/heads/jerlbeck/wip/ms-struct","head":"5522d4a5ef71157c7429d687cbc96a3f29f74ea0","before":"dd1567812895ed5092d77db653be91c17cd7f5c3","commits":[{"sha":"09fdf6622a3774849bc90b9c4fedf76fdc76ac03","author":{"email":"bc4099e8129048574af98275fa037a1c852d38db@sysmocom.de","name":"Jacob Erlbeck"},"message":"bssgp: Handle btcx == NULL in gprs_bssgp_pcu_rx_sign (Coverity)\n\nCurrently it is assumed, that btcx is non-NULL. The btcx is only used\nto obtain the BVCI in some log messages.\n\nThis commit changes that by using -1 as shown BVCI value.\n\nFixes: Coverity CID 1040961\nSponsored-by: On-Waves ehf","distinct":false,"url":"https://api.github.com/repos/osmocom/osmo-pcu/commits/09fdf6622a3774849bc90b9c4fedf76fdc76ac03"},{"sha":"d0aee85b29a17e6ef3fb1454a798e10ced0d0266","author":{"email":"bc4099e8129048574af98275fa037a1c852d38db@sysmocom.de","name":"Jacob Erlbeck"},"message":"llc: Fix LLC UI frame detection (Coverity)\n\nCurrently the wrong nibble is masked out, so the conditional\nexpression always yields true.\n\nTherefore gprs_llc::is_user_data_frame() always returns true. As a\nconsequence, the low watermark feature of\ngprs_rlcmac_dl_tbf::llc_dequeue() is not being used in fact.\n\nThis commit fixes the mask value.\n\nFixes: Coverity CID 1292834, 1292835\nSponsored-by: On-Waves ehf","distinct":false,"url":"https://api.github.com/repos/osmocom/osmo-pcu/commits/d0aee85b29a17e6ef3fb1454a798e10ced0d0266"},{"sha":"0ae431380015a5c6a944a9edd1620e56b0b65445","author":{"email":"bc4099e8129048574af98275fa037a1c852d38db@sysmocom.de","name":"Jacob Erlbeck"},"message":"bssgp: Calculate the avg_delay_ms in 32bit only (Coverity)\n\nCurrently the delay_sum is stored in 64 to avoid overflow errors.\nBut only the result of tv_sec * 1000 is casted to 64 bit, resulting\nin an overflow if the accumulated queue delay reached 25 days (which\nwill not happen in practice, unless there are >200k LLC messages with\na max of 10s delay each in the queue). If that were the case, the\nonly impact would be a wrong number in a log message and in the BSSGP\nFLOW CONTROL message.\n\nThis commit changes the calculations so that they are done in 32 bit\nonly, rather than to do the calculation in 64 bit properly.\n\nFixes: Coverity CID 1298705\nSponsored-by: On-Waves ehf","distinct":false,"url":"https://api.github.com/repos/osmocom/osmo-pcu/commits/0ae431380015a5c6a944a9edd1620e56b0b65445"},{"sha":"7bf9f49728a306976b1974a52a9039807b0a2979","author":{"email":"bc4099e8129048574af98275fa037a1c852d38db@sysmocom.de","name":"Jacob Erlbeck"},"message":"tbf: Check for NULL in name() (Coverity)\n\nThe gprs_rlcmac_tbf::name() method is generally used to generate log\nmessages. To avoid the need for an explicit NULL check for the tbf\nand to get a consistent text if it is NULL, this commit adds a\nNULL check to the method itself so that it can be called with this ==\nNULL.\n\nFixes: Coverity CID 1304680, 1304681\nSponsored-by: On-Waves ehf","distinct":false,"url":"https://api.github.com/repos/osmocom/osmo-pcu/commits/7bf9f49728a306976b1974a52a9039807b0a2979"},{"sha":"25db7c6116d11a91697e439fcbc21eb824beace4","author":{"email":"bc4099e8129048574af98275fa037a1c852d38db@sysmocom.de","name":"Jacob Erlbeck"},"message":"ms: Add missing initialiser for m_delay (Coverity)\n\nSet m_delay to 0 in the constructor to disable the timer feature by\ndefault.\n\nFixes: Coverity CID 1304682\nSponsored-by: On-Waves ehf","distinct":false,"url":"https://api.github.com/repos/osmocom/osmo-pcu/commits/25db7c6116d11a91697e439fcbc21eb824beace4"},{"sha":"0808f6860111ef54e80a2865029760e063c29755","author":{"email":"bc4099e8129048574af98275fa037a1c852d38db@sysmocom.de","name":"Jacob Erlbeck"},"message":"ms: Fix timer start condition (Coverity)\n\nCurrently the timer can be started even if m_ul_tbf is attached.\n\nReplace m_dl_tbf by m_ul_tbf to only start the timer if _both_ TBF\nare detached.\n\nFixes: Coverity CID 1304683\nSponsored-by: On-Waves ehf","distinct":false,"url":"https://api.github.com/repos/osmocom/osmo-pcu/commits/0808f6860111ef54e80a2865029760e063c29755"},{"sha":"058c0274f87a0cc0ade2e4b22ad3e2820031cff6","author":{"email":"bc4099e8129048574af98275fa037a1c852d38db@sysmocom.de","name":"Jacob Erlbeck"},"message":"l1: Pass all L1 measurements upwards (TODO)\n\nCurrently only the RSSI value is passed to the upper layers. Other\nvalues like TA and BER which are needed for TA update respectively CS\nselection are not propagated.\n\nThis commit introduces and passes a struct that contains a set of\nmeasurement values.\n\nTODO:\n - the struct is currently defined in pcu_l1_if.h. Consider to put\n   it into a separate file.\n\nSponsored-by: On-Waves ehf","distinct":true,"url":"https://api.github.com/repos/osmocom/osmo-pcu/commits/058c0274f87a0cc0ade2e4b22ad3e2820031cff6"},{"sha":"4507a1f2aad235aff7cb56925a498d0175710f7d","author":{"email":"bc4099e8129048574af98275fa037a1c852d38db@sysmocom.de","name":"Jacob Erlbeck"},"message":"ms: Store the L1 measurement values in the MS objects\n\nThis commits adds the GprsMs::update_l1_meas() and GprsMs::l1_meas()\nmethods to store and access the measurement values. The internal\nstate is updated depending on which values are actually set.\n\nIn addition, these values are shown in the output of the 'show ms\nimsi|tlli' command.\n\nSponsored-by: On-Waves ehf","distinct":true,"url":"https://api.github.com/repos/osmocom/osmo-pcu/commits/4507a1f2aad235aff7cb56925a498d0175710f7d"},{"sha":"5522d4a5ef71157c7429d687cbc96a3f29f74ea0","author":{"email":"bc4099e8129048574af98275fa037a1c852d38db@sysmocom.de","name":"Jacob Erlbeck"},"message":"ms: Add UL CS selection based on L1 link quality\n\nCurrently the UL CS values are set to the corresponding DL CS value,\neventually limited by a maximum value. This approach does not reflect\nthe general situation of the RF link between ME and BTS, which is\nrather asymmetric e.g. due to a lower degree of TX efficiency of the\nbuilt-in antenna. This means, that UL and DL CS control should be\ndecoupled for better results.\n\nThis commit adds automatic UL CS selection based on the link quality\nmeasurement parameter. Each coding scheme is mapped to a link quality\nrange. If the link quality value leaves that range, the current UL CS\nvalue is increased/decreased accordingly. This value will be copied\nwhen the next PACKET_UPLINK_ACK_NACK or PACKET_UPLINK_ASSIGMENT is\nsent to the MS.\n\nThe following VTY command will be added to the config-pcu node:\n\n-  cs link-quality-ranges cs1 <0-20> cs2 <0-20> <0-20>\n          cs3 <0-20> <0-20> cs4 <0-20>\n\nwhich sets the ranges for the four coding schemes. For instance the\nexample below reflects the current default values:\n\n  cs link-quality-ranges cs1 5 cs2 4 8 cs3 7 12 cs4 10\n\nset the following ranges, where the overlapping is used to configure\na hysteresis:\n\n  CS1: -inf ..  5\n  CS2:    4 ..  8\n  CS3:    7 .. 12\n  CS4:   10 .. inf\n\nSponsored-by: On-Waves ehf","distinct":true,"url":"https://api.github.com/repos/osmocom/osmo-pcu/commits/5522d4a5ef71157c7429d687cbc96a3f29f74ea0"}]}