{"action":"created","issue":{"url":"https://api.github.com/repos/rietveld-codereview/rietveld/issues/531","labels_url":"https://api.github.com/repos/rietveld-codereview/rietveld/issues/531/labels{/name}","comments_url":"https://api.github.com/repos/rietveld-codereview/rietveld/issues/531/comments","events_url":"https://api.github.com/repos/rietveld-codereview/rietveld/issues/531/events","html_url":"https://github.com/rietveld-codereview/rietveld/issues/531","id":111458115,"number":531,"title":"upload.py: certificate verify failed","user":{"login":"techtonik","id":515889,"avatar_url":"https://avatars.githubusercontent.com/u/515889?v=3","gravatar_id":"","url":"https://api.github.com/users/techtonik","html_url":"https://github.com/techtonik","followers_url":"https://api.github.com/users/techtonik/followers","following_url":"https://api.github.com/users/techtonik/following{/other_user}","gists_url":"https://api.github.com/users/techtonik/gists{/gist_id}","starred_url":"https://api.github.com/users/techtonik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/techtonik/subscriptions","organizations_url":"https://api.github.com/users/techtonik/orgs","repos_url":"https://api.github.com/users/techtonik/repos","events_url":"https://api.github.com/users/techtonik/events{/privacy}","received_events_url":"https://api.github.com/users/techtonik/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2015-10-14T18:13:31Z","updated_at":"2015-10-16T08:09:34Z","closed_at":"2015-10-15T08:07:40Z","body":"I can't upload review to https://codereview.chromium.org\r\nWhat's wrong with this certificate stuff? It is Python 2.7.10\r\n\r\n```\r\n>python upload.py -s https://codereview.chromium.org -t \"Don't fail hash validation\"\r\nThe following files are not added to version control:\r\nupload.py\r\nAre you sure to continue?(y/N) y\r\nUpload server: https://codereview.chromium.org (change with -s/--server)\r\nEmail (login for uploading to https://codereview.chromium.org) [techtonik@gmail.com]:\r\nPassword for techtonik@gmail.com:\r\nTraceback (most recent call last):\r\n  File \"upload.py\", line 2719, in <module>\r\n    main()\r\n  File \"upload.py\", line 2711, in main\r\n    RealMain(sys.argv)\r\n  File \"upload.py\", line 2667, in RealMain\r\n    response_body = rpc_server.Send(\"/upload\", body, content_type=ctype)\r\n  File \"upload.py\", line 446, in Send\r\n    self._Authenticate()\r\n  File \"upload.py\", line 501, in _Authenticate\r\n    super(HttpRpcServer, self)._Authenticate()\r\n  File \"upload.py\", line 381, in _Authenticate\r\n    auth_token = self._GetAuthToken(credentials[0], credentials[1])\r\n  File \"upload.py\", line 325, in _GetAuthToken\r\n    response = self.opener.open(req)\r\n  File \"C:\\Python27\\lib\\urllib2.py\", line 431, in open\r\n    response = self._open(req, data)\r\n  File \"C:\\Python27\\lib\\urllib2.py\", line 449, in _open\r\n    '_open', req)\r\n  File \"C:\\Python27\\lib\\urllib2.py\", line 409, in _call_chain\r\n    result = func(*args)\r\n  File \"C:\\Python27\\lib\\urllib2.py\", line 1240, in https_open\r\n    context=self._context)\r\n  File \"C:\\Python27\\lib\\urllib2.py\", line 1197, in do_open\r\n    raise URLError(err)\r\nurllib2.URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:590)>\r\n```"},"comment":{"url":"https://api.github.com/repos/rietveld-codereview/rietveld/issues/comments/148646681","html_url":"https://github.com/rietveld-codereview/rietveld/issues/531#issuecomment-148646681","issue_url":"https://api.github.com/repos/rietveld-codereview/rietveld/issues/531","id":148646681,"user":{"login":"andialbrecht","id":25632,"avatar_url":"https://avatars.githubusercontent.com/u/25632?v=3","gravatar_id":"","url":"https://api.github.com/users/andialbrecht","html_url":"https://github.com/andialbrecht","followers_url":"https://api.github.com/users/andialbrecht/followers","following_url":"https://api.github.com/users/andialbrecht/following{/other_user}","gists_url":"https://api.github.com/users/andialbrecht/gists{/gist_id}","starred_url":"https://api.github.com/users/andialbrecht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andialbrecht/subscriptions","organizations_url":"https://api.github.com/users/andialbrecht/orgs","repos_url":"https://api.github.com/users/andialbrecht/repos","events_url":"https://api.github.com/users/andialbrecht/events{/privacy}","received_events_url":"https://api.github.com/users/andialbrecht/received_events","type":"User","site_admin":false},"created_at":"2015-10-16T08:09:34Z","updated_at":"2015-10-16T08:09:34Z","body":"IMO that's something that needs to be fixed in Python (or maybe even on the client since Python 2.7.10 and Win7 works). \r\n\r\nI don't think it's a good idea to maintain certificates here in this repo. They go out-of-sync sooner or later and may introduce security risks. What I could think of is adding some kind of \"--cert\" flag where it's upon the user to use this flag and provide certificates on his own."}}