{"action":"created","comment":{"url":"https://api.github.com/repos/phoenixframework/phoenix/pulls/comments/23387514","id":23387514,"diff_hunk":"@@ -0,0 +1,97 @@\n+defmodule Phoenix.HTML.Tag do\n+  @moduledoc ~S\"\"\"\n+  Helpers related to producing HTML tags within templates.\n+  \"\"\"\n+\n+  alias Phoenix.HTML.Safe\n+\n+  @data_attrs [:method, :remote, :confirm]","path":"lib/phoenix/html/tag.ex","position":8,"original_position":8,"commit_id":"83dc15c1709d42ed4d4d592c58e86e4ddf325840","original_commit_id":"59f23a361876c220dd5985d87b78e588952b6abe","user":{"login":"rafaelfranca","id":47848,"avatar_url":"https://avatars.githubusercontent.com/u/47848?v=3","gravatar_id":"","url":"https://api.github.com/users/rafaelfranca","html_url":"https://github.com/rafaelfranca","followers_url":"https://api.github.com/users/rafaelfranca/followers","following_url":"https://api.github.com/users/rafaelfranca/following{/other_user}","gists_url":"https://api.github.com/users/rafaelfranca/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelfranca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelfranca/subscriptions","organizations_url":"https://api.github.com/users/rafaelfranca/orgs","repos_url":"https://api.github.com/users/rafaelfranca/repos","events_url":"https://api.github.com/users/rafaelfranca/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelfranca/received_events","type":"User","site_admin":false},"body":"In fact we chose to moving away from handling an special set of data attributes on Rails. We just tell people to use the data attribute directly as `tag(:a, \"My link\", { data: { confirm: 'Something } })` instead of `tag(:a, \"My link\", confirm: 'Something })`","created_at":"2015-01-22T16:25:09Z","updated_at":"2015-01-22T16:25:09Z","html_url":"https://github.com/phoenixframework/phoenix/pull/321#discussion_r23387514","pull_request_url":"https://api.github.com/repos/phoenixframework/phoenix/pulls/321","_links":{"self":{"href":"https://api.github.com/repos/phoenixframework/phoenix/pulls/comments/23387514"},"html":{"href":"https://github.com/phoenixframework/phoenix/pull/321#discussion_r23387514"},"pull_request":{"href":"https://api.github.com/repos/phoenixframework/phoenix/pulls/321"}}},"pull_request":{"url":"https://api.github.com/repos/phoenixframework/phoenix/pulls/321","id":20861285,"html_url":"https://github.com/phoenixframework/phoenix/pull/321","diff_url":"https://github.com/phoenixframework/phoenix/pull/321.diff","patch_url":"https://github.com/phoenixframework/phoenix/pull/321.patch","issue_url":"https://api.github.com/repos/phoenixframework/phoenix/issues/321","number":321,"state":"open","locked":false,"title":"Form Helper","user":{"login":"scrogson","id":53274,"avatar_url":"https://avatars.githubusercontent.com/u/53274?v=3","gravatar_id":"","url":"https://api.github.com/users/scrogson","html_url":"https://github.com/scrogson","followers_url":"https://api.github.com/users/scrogson/followers","following_url":"https://api.github.com/users/scrogson/following{/other_user}","gists_url":"https://api.github.com/users/scrogson/gists{/gist_id}","starred_url":"https://api.github.com/users/scrogson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrogson/subscriptions","organizations_url":"https://api.github.com/users/scrogson/orgs","repos_url":"https://api.github.com/users/scrogson/repos","events_url":"https://api.github.com/users/scrogson/events{/privacy}","received_events_url":"https://api.github.com/users/scrogson/received_events","type":"User","site_admin":false},"body":"This is a WIP spike, please feel free to comment or suggest changes. An end goal for\r\nme to is have something like\r\n[SimpleForm](https://github.com/plataformatec/simple_form/) so hopefully\r\n@josevalim will have some thoughts.\r\n\r\nThis will also rely heavily on the `Resource` protocol discussed in #320.","created_at":"2014-09-07T15:52:51Z","updated_at":"2015-01-22T16:25:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c52e20aefb571a6e51ebf061758c1b5c6320ec4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/phoenixframework/phoenix/pulls/321/commits","review_comments_url":"https://api.github.com/repos/phoenixframework/phoenix/pulls/321/comments","review_comment_url":"https://api.github.com/repos/phoenixframework/phoenix/pulls/comments/{number}","comments_url":"https://api.github.com/repos/phoenixframework/phoenix/issues/321/comments","statuses_url":"https://api.github.com/repos/phoenixframework/phoenix/statuses/83dc15c1709d42ed4d4d592c58e86e4ddf325840","head":{"label":"scrogson:forms","ref":"forms","sha":"83dc15c1709d42ed4d4d592c58e86e4ddf325840","user":{"login":"scrogson","id":53274,"avatar_url":"https://avatars.githubusercontent.com/u/53274?v=3","gravatar_id":"","url":"https://api.github.com/users/scrogson","html_url":"https://github.com/scrogson","followers_url":"https://api.github.com/users/scrogson/followers","following_url":"https://api.github.com/users/scrogson/following{/other_user}","gists_url":"https://api.github.com/users/scrogson/gists{/gist_id}","starred_url":"https://api.github.com/users/scrogson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrogson/subscriptions","organizations_url":"https://api.github.com/users/scrogson/orgs","repos_url":"https://api.github.com/users/scrogson/repos","events_url":"https://api.github.com/users/scrogson/events{/privacy}","received_events_url":"https://api.github.com/users/scrogson/received_events","type":"User","site_admin":false},"repo":{"id":16809572,"name":"phoenix","full_name":"scrogson/phoenix","owner":{"login":"scrogson","id":53274,"avatar_url":"https://avatars.githubusercontent.com/u/53274?v=3","gravatar_id":"","url":"https://api.github.com/users/scrogson","html_url":"https://github.com/scrogson","followers_url":"https://api.github.com/users/scrogson/followers","following_url":"https://api.github.com/users/scrogson/following{/other_user}","gists_url":"https://api.github.com/users/scrogson/gists{/gist_id}","starred_url":"https://api.github.com/users/scrogson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrogson/subscriptions","organizations_url":"https://api.github.com/users/scrogson/orgs","repos_url":"https://api.github.com/users/scrogson/repos","events_url":"https://api.github.com/users/scrogson/events{/privacy}","received_events_url":"https://api.github.com/users/scrogson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/scrogson/phoenix","description":"Elixir Web Framework","fork":true,"url":"https://api.github.com/repos/scrogson/phoenix","forks_url":"https://api.github.com/repos/scrogson/phoenix/forks","keys_url":"https://api.github.com/repos/scrogson/phoenix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scrogson/phoenix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scrogson/phoenix/teams","hooks_url":"https://api.github.com/repos/scrogson/phoenix/hooks","issue_events_url":"https://api.github.com/repos/scrogson/phoenix/issues/events{/number}","events_url":"https://api.github.com/repos/scrogson/phoenix/events","assignees_url":"https://api.github.com/repos/scrogson/phoenix/assignees{/user}","branches_url":"https://api.github.com/repos/scrogson/phoenix/branches{/branch}","tags_url":"https://api.github.com/repos/scrogson/phoenix/tags","blobs_url":"https://api.github.com/repos/scrogson/phoenix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scrogson/phoenix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scrogson/phoenix/git/refs{/sha}","trees_url":"https://api.github.com/repos/scrogson/phoenix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scrogson/phoenix/statuses/{sha}","languages_url":"https://api.github.com/repos/scrogson/phoenix/languages","stargazers_url":"https://api.github.com/repos/scrogson/phoenix/stargazers","contributors_url":"https://api.github.com/repos/scrogson/phoenix/contributors","subscribers_url":"https://api.github.com/repos/scrogson/phoenix/subscribers","subscription_url":"https://api.github.com/repos/scrogson/phoenix/subscription","commits_url":"https://api.github.com/repos/scrogson/phoenix/commits{/sha}","git_commits_url":"https://api.github.com/repos/scrogson/phoenix/git/commits{/sha}","comments_url":"https://api.github.com/repos/scrogson/phoenix/comments{/number}","issue_comment_url":"https://api.github.com/repos/scrogson/phoenix/issues/comments/{number}","contents_url":"https://api.github.com/repos/scrogson/phoenix/contents/{+path}","compare_url":"https://api.github.com/repos/scrogson/phoenix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scrogson/phoenix/merges","archive_url":"https://api.github.com/repos/scrogson/phoenix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scrogson/phoenix/downloads","issues_url":"https://api.github.com/repos/scrogson/phoenix/issues{/number}","pulls_url":"https://api.github.com/repos/scrogson/phoenix/pulls{/number}","milestones_url":"https://api.github.com/repos/scrogson/phoenix/milestones{/number}","notifications_url":"https://api.github.com/repos/scrogson/phoenix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scrogson/phoenix/labels{/name}","releases_url":"https://api.github.com/repos/scrogson/phoenix/releases{/id}","created_at":"2014-02-13T16:46:53Z","updated_at":"2014-07-02T04:49:12Z","pushed_at":"2014-12-05T21:02:37Z","git_url":"git://github.com/scrogson/phoenix.git","ssh_url":"git@github.com:scrogson/phoenix.git","clone_url":"https://github.com/scrogson/phoenix.git","svn_url":"https://github.com/scrogson/phoenix","homepage":"","size":1419,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"phoenixframework:master","ref":"master","sha":"725bad0794473f7832c9d7d12cd3d9bf5802cfc7","user":{"login":"phoenixframework","id":6510388,"avatar_url":"https://avatars.githubusercontent.com/u/6510388?v=3","gravatar_id":"","url":"https://api.github.com/users/phoenixframework","html_url":"https://github.com/phoenixframework","followers_url":"https://api.github.com/users/phoenixframework/followers","following_url":"https://api.github.com/users/phoenixframework/following{/other_user}","gists_url":"https://api.github.com/users/phoenixframework/gists{/gist_id}","starred_url":"https://api.github.com/users/phoenixframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phoenixframework/subscriptions","organizations_url":"https://api.github.com/users/phoenixframework/orgs","repos_url":"https://api.github.com/users/phoenixframework/repos","events_url":"https://api.github.com/users/phoenixframework/events{/privacy}","received_events_url":"https://api.github.com/users/phoenixframework/received_events","type":"Organization","site_admin":false},"repo":{"id":16072585,"name":"phoenix","full_name":"phoenixframework/phoenix","owner":{"login":"phoenixframework","id":6510388,"avatar_url":"https://avatars.githubusercontent.com/u/6510388?v=3","gravatar_id":"","url":"https://api.github.com/users/phoenixframework","html_url":"https://github.com/phoenixframework","followers_url":"https://api.github.com/users/phoenixframework/followers","following_url":"https://api.github.com/users/phoenixframework/following{/other_user}","gists_url":"https://api.github.com/users/phoenixframework/gists{/gist_id}","starred_url":"https://api.github.com/users/phoenixframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phoenixframework/subscriptions","organizations_url":"https://api.github.com/users/phoenixframework/orgs","repos_url":"https://api.github.com/users/phoenixframework/repos","events_url":"https://api.github.com/users/phoenixframework/events{/privacy}","received_events_url":"https://api.github.com/users/phoenixframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phoenixframework/phoenix","description":"A highly connected web framework for the Elixir programming language","fork":false,"url":"https://api.github.com/repos/phoenixframework/phoenix","forks_url":"https://api.github.com/repos/phoenixframework/phoenix/forks","keys_url":"https://api.github.com/repos/phoenixframework/phoenix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phoenixframework/phoenix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phoenixframework/phoenix/teams","hooks_url":"https://api.github.com/repos/phoenixframework/phoenix/hooks","issue_events_url":"https://api.github.com/repos/phoenixframework/phoenix/issues/events{/number}","events_url":"https://api.github.com/repos/phoenixframework/phoenix/events","assignees_url":"https://api.github.com/repos/phoenixframework/phoenix/assignees{/user}","branches_url":"https://api.github.com/repos/phoenixframework/phoenix/branches{/branch}","tags_url":"https://api.github.com/repos/phoenixframework/phoenix/tags","blobs_url":"https://api.github.com/repos/phoenixframework/phoenix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phoenixframework/phoenix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phoenixframework/phoenix/git/refs{/sha}","trees_url":"https://api.github.com/repos/phoenixframework/phoenix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phoenixframework/phoenix/statuses/{sha}","languages_url":"https://api.github.com/repos/phoenixframework/phoenix/languages","stargazers_url":"https://api.github.com/repos/phoenixframework/phoenix/stargazers","contributors_url":"https://api.github.com/repos/phoenixframework/phoenix/contributors","subscribers_url":"https://api.github.com/repos/phoenixframework/phoenix/subscribers","subscription_url":"https://api.github.com/repos/phoenixframework/phoenix/subscription","commits_url":"https://api.github.com/repos/phoenixframework/phoenix/commits{/sha}","git_commits_url":"https://api.github.com/repos/phoenixframework/phoenix/git/commits{/sha}","comments_url":"https://api.github.com/repos/phoenixframework/phoenix/comments{/number}","issue_comment_url":"https://api.github.com/repos/phoenixframework/phoenix/issues/comments/{number}","contents_url":"https://api.github.com/repos/phoenixframework/phoenix/contents/{+path}","compare_url":"https://api.github.com/repos/phoenixframework/phoenix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phoenixframework/phoenix/merges","archive_url":"https://api.github.com/repos/phoenixframework/phoenix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phoenixframework/phoenix/downloads","issues_url":"https://api.github.com/repos/phoenixframework/phoenix/issues{/number}","pulls_url":"https://api.github.com/repos/phoenixframework/phoenix/pulls{/number}","milestones_url":"https://api.github.com/repos/phoenixframework/phoenix/milestones{/number}","notifications_url":"https://api.github.com/repos/phoenixframework/phoenix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phoenixframework/phoenix/labels{/name}","releases_url":"https://api.github.com/repos/phoenixframework/phoenix/releases{/id}","created_at":"2014-01-20T14:14:11Z","updated_at":"2015-01-22T13:25:29Z","pushed_at":"2015-01-22T14:04:06Z","git_url":"git://github.com/phoenixframework/phoenix.git","ssh_url":"git@github.com:phoenixframework/phoenix.git","clone_url":"https://github.com/phoenixframework/phoenix.git","svn_url":"https://github.com/phoenixframework/phoenix","homepage":"http://www.phoenixframework.org","size":6083,"stargazers_count":1872,"watchers_count":1872,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":168,"mirror_url":null,"open_issues_count":16,"forks":168,"open_issues":16,"watchers":1872,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phoenixframework/phoenix/pulls/321"},"html":{"href":"https://github.com/phoenixframework/phoenix/pull/321"},"issue":{"href":"https://api.github.com/repos/phoenixframework/phoenix/issues/321"},"comments":{"href":"https://api.github.com/repos/phoenixframework/phoenix/issues/321/comments"},"review_comments":{"href":"https://api.github.com/repos/phoenixframework/phoenix/pulls/321/comments"},"review_comment":{"href":"https://api.github.com/repos/phoenixframework/phoenix/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/phoenixframework/phoenix/pulls/321/commits"},"statuses":{"href":"https://api.github.com/repos/phoenixframework/phoenix/statuses/83dc15c1709d42ed4d4d592c58e86e4ddf325840"}}}}