{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/5847","labels_url":"https://api.github.com/repos/openshift/origin/issues/5847/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/5847/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/5847/events","html_url":"https://github.com/openshift/origin/pull/5847","id":116353300,"number":5847,"title":"Recycler image and command","user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/openshift/origin/labels/area/compatibility","name":"area/compatibility","color":"006b75"},{"url":"https://api.github.com/repos/openshift/origin/labels/area/documentation","name":"area/documentation","color":"006b75"},{"url":"https://api.github.com/repos/openshift/origin/labels/priority/P1","name":"priority/P1","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/openshift/origin/milestones/5","html_url":"https://github.com/openshift/origin/milestones/1.1.0","labels_url":"https://api.github.com/repos/openshift/origin/milestones/5/labels","id":1119756,"number":5,"title":"1.1.0","description":"Corresponds to the 3.1.0 OSE release","creator":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":275,"state":"open","created_at":"2015-05-20T04:04:56Z","updated_at":"2015-11-12T06:10:14Z","due_on":"2015-11-14T05:00:00Z","closed_at":null},"comments":46,"created_at":"2015-11-11T15:09:48Z","updated_at":"2015-11-12T20:06:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/5847","html_url":"https://github.com/openshift/origin/pull/5847","diff_url":"https://github.com/openshift/origin/pull/5847.diff","patch_url":"https://github.com/openshift/origin/pull/5847.patch"},"body":"Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1279683\r\nFixes https://bugzilla.redhat.com/show_bug.cgi?id=1279335\r\n\r\nBuilds on https://github.com/openshift/origin/pull/5792. Together, these pulls:\r\n\r\n* Add a \"openshift/origin-recycler\" image containing a \"recycle\" binary\r\n* Updates recycle controller to use this image, running as uid 0 (and to only pull if not present)\r\n* This binary walks the filesystem under the dir it is given to clean, lstat-ing and using `setfsuid` to become the owning uid of each directory before attempting to remove the children of that directory\r\n* Removes `shred` calls, per feedback from @eparis about their efficacy on the filesystems we're using for persistent volumes. That change should be documented\r\n\r\nKnown limitations which will fail the recycle and require an admin to intervene before the PV is reused:\r\n* directories with only group permissions (no owner permissions) can receive permission denied errors, since only `setfsuid` is being used\r\n* nested directories with alternating owner uids with only user permissions can fail recycling (only a single fsuid can be set at any given time)\r\n* Errors calling `setfsuid`"},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/156219654","html_url":"https://github.com/openshift/origin/pull/5847#issuecomment-156219654","issue_url":"https://api.github.com/repos/openshift/origin/issues/5847","id":156219654,"user":{"login":"openshift-bot","id":1779249,"avatar_url":"https://avatars.githubusercontent.com/u/1779249?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift-bot","html_url":"https://github.com/openshift-bot","followers_url":"https://api.github.com/users/openshift-bot/followers","following_url":"https://api.github.com/users/openshift-bot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-bot/subscriptions","organizations_url":"https://api.github.com/users/openshift-bot/orgs","repos_url":"https://api.github.com/users/openshift-bot/repos","events_url":"https://api.github.com/users/openshift-bot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-bot/received_events","type":"User","site_admin":false},"created_at":"2015-11-12T20:06:15Z","updated_at":"2015-11-12T20:06:15Z","body":"continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/7090/)"}}