{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/facter/pulls/comments/31850585","id":31850585,"diff_hunk":"@@ -158,6 +158,20 @@ namespace facter { namespace facts {\n         }\n \n         /**\n+        * Gets a fact value by name without resolving the fact.\n+        * @tparam T The expected type of the value.\n+        * @param name The name of the fact to get the value of.\n+        * @return Returns a pointer to the fact value or nullptr if the fact is not resolved or the value is not the expected type.","path":"lib/inc/facter/facts/collection.hpp","position":7,"original_position":7,"commit_id":"a1085088a427e6e682971792d18ab0cbee56bfd7","original_commit_id":"a1085088a427e6e682971792d18ab0cbee56bfd7","user":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars.githubusercontent.com/u/8162496?v=3","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"body":"There's no dynamic cast, so will this be true?","created_at":"2015-06-05T20:53:47Z","updated_at":"2015-06-05T20:53:47Z","html_url":"https://github.com/puppetlabs/facter/pull/965#discussion_r31850585","pull_request_url":"https://api.github.com/repos/puppetlabs/facter/pulls/965","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/comments/31850585"},"html":{"href":"https://github.com/puppetlabs/facter/pull/965#discussion_r31850585"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/965"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/facter/pulls/965","id":37053127,"html_url":"https://github.com/puppetlabs/facter/pull/965","diff_url":"https://github.com/puppetlabs/facter/pull/965.diff","patch_url":"https://github.com/puppetlabs/facter/pull/965.patch","issue_url":"https://api.github.com/repos/puppetlabs/facter/issues/965","number":965,"state":"open","locked":false,"title":"(FACT-965) Ensure fact resolution occurs under JNI lock for JRuby.","user":{"login":"peterhuene","id":509666,"avatar_url":"https://avatars.githubusercontent.com/u/509666?v=3","gravatar_id":"","url":"https://api.github.com/users/peterhuene","html_url":"https://github.com/peterhuene","followers_url":"https://api.github.com/users/peterhuene/followers","following_url":"https://api.github.com/users/peterhuene/following{/other_user}","gists_url":"https://api.github.com/users/peterhuene/gists{/gist_id}","starred_url":"https://api.github.com/users/peterhuene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterhuene/subscriptions","organizations_url":"https://api.github.com/users/peterhuene/orgs","repos_url":"https://api.github.com/users/peterhuene/repos","events_url":"https://api.github.com/users/peterhuene/events{/privacy}","received_events_url":"https://api.github.com/users/peterhuene/received_events","type":"User","site_admin":false},"body":"Currently, fact resolution occurs upon the first call to\r\n`com.puppetlabs.Facter.lookup`. Because native libraries are shared between\r\nJava threads and fact collections are not thread-safe, this is inherently unsafe.\r\n\r\nThis moves the resolution of the facts into loading of the library,\r\nwhich is protected by a JVM mutex.  Puppet Server will now load the facter\r\nJNI shim class at startup, causing all fact resolution to occur only\r\nonce at startup.  Because the JNI shim only supports reading a fact's\r\nvalue, subsequent calls to `com.puppetlabs.Facter.lookup` do not need to\r\nbe protected as the collection is considered to be immutable after\r\nloading of the native library.","created_at":"2015-06-05T17:37:17Z","updated_at":"2015-06-05T20:53:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c7b2c5a4798e6267bfed584fb93a41369ac17b1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/facter/pulls/965/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/facter/pulls/965/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/facter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/facter/issues/965/comments","statuses_url":"https://api.github.com/repos/puppetlabs/facter/statuses/a1085088a427e6e682971792d18ab0cbee56bfd7","head":{"label":"peterhuene:fact/965","ref":"fact/965","sha":"a1085088a427e6e682971792d18ab0cbee56bfd7","user":{"login":"peterhuene","id":509666,"avatar_url":"https://avatars.githubusercontent.com/u/509666?v=3","gravatar_id":"","url":"https://api.github.com/users/peterhuene","html_url":"https://github.com/peterhuene","followers_url":"https://api.github.com/users/peterhuene/followers","following_url":"https://api.github.com/users/peterhuene/following{/other_user}","gists_url":"https://api.github.com/users/peterhuene/gists{/gist_id}","starred_url":"https://api.github.com/users/peterhuene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterhuene/subscriptions","organizations_url":"https://api.github.com/users/peterhuene/orgs","repos_url":"https://api.github.com/users/peterhuene/repos","events_url":"https://api.github.com/users/peterhuene/events{/privacy}","received_events_url":"https://api.github.com/users/peterhuene/received_events","type":"User","site_admin":false},"repo":{"id":15720773,"name":"facter","full_name":"peterhuene/facter","owner":{"login":"peterhuene","id":509666,"avatar_url":"https://avatars.githubusercontent.com/u/509666?v=3","gravatar_id":"","url":"https://api.github.com/users/peterhuene","html_url":"https://github.com/peterhuene","followers_url":"https://api.github.com/users/peterhuene/followers","following_url":"https://api.github.com/users/peterhuene/following{/other_user}","gists_url":"https://api.github.com/users/peterhuene/gists{/gist_id}","starred_url":"https://api.github.com/users/peterhuene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterhuene/subscriptions","organizations_url":"https://api.github.com/users/peterhuene/orgs","repos_url":"https://api.github.com/users/peterhuene/repos","events_url":"https://api.github.com/users/peterhuene/events{/privacy}","received_events_url":"https://api.github.com/users/peterhuene/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peterhuene/facter","description":"","fork":true,"url":"https://api.github.com/repos/peterhuene/facter","forks_url":"https://api.github.com/repos/peterhuene/facter/forks","keys_url":"https://api.github.com/repos/peterhuene/facter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peterhuene/facter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peterhuene/facter/teams","hooks_url":"https://api.github.com/repos/peterhuene/facter/hooks","issue_events_url":"https://api.github.com/repos/peterhuene/facter/issues/events{/number}","events_url":"https://api.github.com/repos/peterhuene/facter/events","assignees_url":"https://api.github.com/repos/peterhuene/facter/assignees{/user}","branches_url":"https://api.github.com/repos/peterhuene/facter/branches{/branch}","tags_url":"https://api.github.com/repos/peterhuene/facter/tags","blobs_url":"https://api.github.com/repos/peterhuene/facter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peterhuene/facter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peterhuene/facter/git/refs{/sha}","trees_url":"https://api.github.com/repos/peterhuene/facter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peterhuene/facter/statuses/{sha}","languages_url":"https://api.github.com/repos/peterhuene/facter/languages","stargazers_url":"https://api.github.com/repos/peterhuene/facter/stargazers","contributors_url":"https://api.github.com/repos/peterhuene/facter/contributors","subscribers_url":"https://api.github.com/repos/peterhuene/facter/subscribers","subscription_url":"https://api.github.com/repos/peterhuene/facter/subscription","commits_url":"https://api.github.com/repos/peterhuene/facter/commits{/sha}","git_commits_url":"https://api.github.com/repos/peterhuene/facter/git/commits{/sha}","comments_url":"https://api.github.com/repos/peterhuene/facter/comments{/number}","issue_comment_url":"https://api.github.com/repos/peterhuene/facter/issues/comments{/number}","contents_url":"https://api.github.com/repos/peterhuene/facter/contents/{+path}","compare_url":"https://api.github.com/repos/peterhuene/facter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peterhuene/facter/merges","archive_url":"https://api.github.com/repos/peterhuene/facter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peterhuene/facter/downloads","issues_url":"https://api.github.com/repos/peterhuene/facter/issues{/number}","pulls_url":"https://api.github.com/repos/peterhuene/facter/pulls{/number}","milestones_url":"https://api.github.com/repos/peterhuene/facter/milestones{/number}","notifications_url":"https://api.github.com/repos/peterhuene/facter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peterhuene/facter/labels{/name}","releases_url":"https://api.github.com/repos/peterhuene/facter/releases{/id}","created_at":"2014-01-08T00:16:20Z","updated_at":"2015-05-07T20:14:35Z","pushed_at":"2015-06-05T20:50:24Z","git_url":"git://github.com/peterhuene/facter.git","ssh_url":"git@github.com:peterhuene/facter.git","clone_url":"https://github.com/peterhuene/facter.git","svn_url":"https://github.com/peterhuene/facter","homepage":"http://projects.puppetlabs.com/projects/facter","size":11360,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"7125588f2b79a7844b362d396c9b2ae9f4d5183e","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910757,"name":"facter","full_name":"puppetlabs/facter","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/facter","description":"Collect and display system facts","fork":false,"url":"https://api.github.com/repos/puppetlabs/facter","forks_url":"https://api.github.com/repos/puppetlabs/facter/forks","keys_url":"https://api.github.com/repos/puppetlabs/facter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/facter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/facter/teams","hooks_url":"https://api.github.com/repos/puppetlabs/facter/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/facter/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/facter/events","assignees_url":"https://api.github.com/repos/puppetlabs/facter/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/facter/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/facter/tags","blobs_url":"https://api.github.com/repos/puppetlabs/facter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/facter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/facter/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/facter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/facter/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/facter/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/facter/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/facter/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/facter/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/facter/subscription","commits_url":"https://api.github.com/repos/puppetlabs/facter/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/facter/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/facter/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/facter/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/facter/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/facter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/facter/merges","archive_url":"https://api.github.com/repos/puppetlabs/facter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/facter/downloads","issues_url":"https://api.github.com/repos/puppetlabs/facter/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/facter/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/facter/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/facter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/facter/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/facter/releases{/id}","created_at":"2010-09-14T19:31:04Z","updated_at":"2015-05-27T11:25:57Z","pushed_at":"2015-06-05T20:50:25Z","git_url":"git://github.com/puppetlabs/facter.git","ssh_url":"git@github.com:puppetlabs/facter.git","clone_url":"https://github.com/puppetlabs/facter.git","svn_url":"https://github.com/puppetlabs/facter","homepage":"https://tickets.puppetlabs.com/browse/FACT","size":20178,"stargazers_count":373,"watchers_count":373,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":361,"mirror_url":null,"open_issues_count":3,"forks":361,"open_issues":3,"watchers":373,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/965"},"html":{"href":"https://github.com/puppetlabs/facter/pull/965"},"issue":{"href":"https://api.github.com/repos/puppetlabs/facter/issues/965"},"comments":{"href":"https://api.github.com/repos/puppetlabs/facter/issues/965/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/965/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/965/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/facter/statuses/a1085088a427e6e682971792d18ab0cbee56bfd7"}}}}