{"action":"created","issue":{"url":"https://api.github.com/repos/numenta/htm.java/issues/212","labels_url":"https://api.github.com/repos/numenta/htm.java/issues/212/labels{/name}","comments_url":"https://api.github.com/repos/numenta/htm.java/issues/212/comments","events_url":"https://api.github.com/repos/numenta/htm.java/issues/212/events","html_url":"https://github.com/numenta/htm.java/pull/212","id":64435945,"number":212,"title":"Adding logging to SparsePassThroughEncoder","user":{"login":"antidata","id":576468,"avatar_url":"https://avatars.githubusercontent.com/u/576468?v=3","gravatar_id":"","url":"https://api.github.com/users/antidata","html_url":"https://github.com/antidata","followers_url":"https://api.github.com/users/antidata/followers","following_url":"https://api.github.com/users/antidata/following{/other_user}","gists_url":"https://api.github.com/users/antidata/gists{/gist_id}","starred_url":"https://api.github.com/users/antidata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antidata/subscriptions","organizations_url":"https://api.github.com/users/antidata/orgs","repos_url":"https://api.github.com/users/antidata/repos","events_url":"https://api.github.com/users/antidata/events{/privacy}","received_events_url":"https://api.github.com/users/antidata/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-03-26T04:07:59Z","updated_at":"2015-03-26T09:03:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/numenta/htm.java/pulls/212","html_url":"https://github.com/numenta/htm.java/pull/212","diff_url":"https://github.com/numenta/htm.java/pull/212.diff","patch_url":"https://github.com/numenta/htm.java/pull/212.patch"},"body":"Fixes #207 "},"comment":{"url":"https://api.github.com/repos/numenta/htm.java/issues/comments/86414201","html_url":"https://github.com/numenta/htm.java/pull/212#issuecomment-86414201","issue_url":"https://api.github.com/repos/numenta/htm.java/issues/212","id":86414201,"user":{"login":"cogmission","id":2340086,"avatar_url":"https://avatars.githubusercontent.com/u/2340086?v=3","gravatar_id":"","url":"https://api.github.com/users/cogmission","html_url":"https://github.com/cogmission","followers_url":"https://api.github.com/users/cogmission/followers","following_url":"https://api.github.com/users/cogmission/following{/other_user}","gists_url":"https://api.github.com/users/cogmission/gists{/gist_id}","starred_url":"https://api.github.com/users/cogmission/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cogmission/subscriptions","organizations_url":"https://api.github.com/users/cogmission/orgs","repos_url":"https://api.github.com/users/cogmission/repos","events_url":"https://api.github.com/users/cogmission/events{/privacy}","received_events_url":"https://api.github.com/users/cogmission/received_events","type":"User","site_admin":false},"created_at":"2015-03-26T09:03:39Z","updated_at":"2015-03-26T09:03:39Z","body":"@antidata \r\nThank you for your contribution!\r\n\r\nA few \"nits\". \r\n\r\nJava has horrid Object explosion when concatenating Strings (i.e. \"Str\" + \"ing\"), so I would recommend using the style of logging such as: \r\n\r\n```Java\r\nLOG.trace(\"input: {}, val: {}, value: {}, output: {}\",\r\n+\t\t\t\t\tinput, val, value, Arrays.toString(output));\r\n```\r\n...instead of \r\n```Java\r\nLOG.trace(\"input: \" + input + \", val: \" + val + \", value: \" + value + \", output: \" + Arrays.toString(output));\r\n```\r\n...using the \"{}\" as replacement markers...\r\n\r\nSecondly, can you use 4 spaces (no tabs) for indentation?\r\n\r\nAlso, for long lines, I prefer wrapping the line with \"stepped\" indentation rather than a new line for every continuation like so...\r\n\r\n```Java\r\nLOGGER.trace(\"Building new SparsePassThroughEncoder instance, outputWidth:  {} {} {}\" \r\n    outputWidth,  \" outputBitsOnCount: \", outputBitsOnCount);\r\n```\r\n\r\ninstead of:\r\n\r\n```Java\r\nLOGGER.trace(\"Building new SparsePassThroughEncoder instance, outputWidth: \" +\r\n+                outputWidth +\r\n+                \" outputBitsOnCount: \" +\r\n+                outputBitsOnCount);\r\n```"}}