{"action":"created","issue":{"url":"https://api.github.com/repos/jgwhite/ember-sortable/issues/51","labels_url":"https://api.github.com/repos/jgwhite/ember-sortable/issues/51/labels{/name}","comments_url":"https://api.github.com/repos/jgwhite/ember-sortable/issues/51/comments","events_url":"https://api.github.com/repos/jgwhite/ember-sortable/issues/51/events","html_url":"https://github.com/jgwhite/ember-sortable/pull/51","id":99901619,"number":51,"title":"Distinguish between clicking and dragging an item","user":{"login":"opsb","id":46232,"avatar_url":"https://avatars.githubusercontent.com/u/46232?v=3","gravatar_id":"","url":"https://api.github.com/users/opsb","html_url":"https://github.com/opsb","followers_url":"https://api.github.com/users/opsb/followers","following_url":"https://api.github.com/users/opsb/following{/other_user}","gists_url":"https://api.github.com/users/opsb/gists{/gist_id}","starred_url":"https://api.github.com/users/opsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opsb/subscriptions","organizations_url":"https://api.github.com/users/opsb/orgs","repos_url":"https://api.github.com/users/opsb/repos","events_url":"https://api.github.com/users/opsb/events{/privacy}","received_events_url":"https://api.github.com/users/opsb/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-08-09T14:29:26Z","updated_at":"2015-08-10T03:49:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jgwhite/ember-sortable/pulls/51","html_url":"https://github.com/jgwhite/ember-sortable/pull/51","diff_url":"https://github.com/jgwhite/ember-sortable/pull/51.diff","patch_url":"https://github.com/jgwhite/ember-sortable/pull/51.patch"},"body":"PR to solve https://github.com/jgwhite/ember-sortable/issues/50. \r\n\r\nThis delays the start of a drag until the mouse is moved. If a drag is completed it also prevents a click from being fired on the item that's just been dragged.\r\n\r\nI'm afraid there's no tests included, not sure how to test drag n drop. I can circle back but I need to take a look at denzo's fork https://github.com/denzo/ember-sortable and get dragging between lists working within my app as a first priority (currently swapping out an existing component that used jquery-ui-sortable). \r\n\r\nFor manual testing I've introduced an {{item-presenter item=item}} component, which reports 'Item clicked' to the console when it's clicked, and added it to the horizontal demo. When an item is dragged you'll see 'Updated'. You should see that they're now mutually exclusive.\r\n\r\nI've tested in IE(9), chrome(latest), safari(latest) and firefox(latest)."},"comment":{"url":"https://api.github.com/repos/jgwhite/ember-sortable/issues/comments/129289708","html_url":"https://github.com/jgwhite/ember-sortable/pull/51#issuecomment-129289708","issue_url":"https://api.github.com/repos/jgwhite/ember-sortable/issues/51","id":129289708,"user":{"login":"jgwhite","id":34030,"avatar_url":"https://avatars.githubusercontent.com/u/34030?v=3","gravatar_id":"","url":"https://api.github.com/users/jgwhite","html_url":"https://github.com/jgwhite","followers_url":"https://api.github.com/users/jgwhite/followers","following_url":"https://api.github.com/users/jgwhite/following{/other_user}","gists_url":"https://api.github.com/users/jgwhite/gists{/gist_id}","starred_url":"https://api.github.com/users/jgwhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgwhite/subscriptions","organizations_url":"https://api.github.com/users/jgwhite/orgs","repos_url":"https://api.github.com/users/jgwhite/repos","events_url":"https://api.github.com/users/jgwhite/events{/privacy}","received_events_url":"https://api.github.com/users/jgwhite/received_events","type":"User","site_admin":false},"created_at":"2015-08-10T03:49:39Z","updated_at":"2015-08-10T03:49:39Z","body":"This is perfect, thanks so much. I like the approach you took with verifying behaviour. Now that component integration tests have arrived we'll be using them in the suite."}}