{"action":"created","comment":{"url":"https://api.github.com/repos/medallia/thrift/pulls/comments/30530102","id":30530102,"diff_hunk":"@@ -2579,7 +2584,15 @@ void t_java_generator::generate_service_future_interface(t_service* tservice) {\n   vector<t_function*> functions = tservice->get_functions();\n   vector<t_function*>::iterator f_iter;\n   for (f_iter = functions.begin(); f_iter != functions.end(); ++f_iter) {\n-    indent(f_service_) << function_signature_future(*f_iter) << \";\" << endl << endl;\n+    t_function* t_f = *f_iter;\n+    int mask;","path":"compiler/cpp/src/generate/t_java_generator.cc","position":43,"original_position":43,"commit_id":"42649813bf788636d11bfeb560811d22bc414fe5","original_commit_id":"42649813bf788636d11bfeb560811d22bc414fe5","user":{"login":"thorvald","id":637674,"avatar_url":"https://avatars.githubusercontent.com/u/637674?v=3","gravatar_id":"","url":"https://api.github.com/users/thorvald","html_url":"https://github.com/thorvald","followers_url":"https://api.github.com/users/thorvald/followers","following_url":"https://api.github.com/users/thorvald/following{/other_user}","gists_url":"https://api.github.com/users/thorvald/gists{/gist_id}","starred_url":"https://api.github.com/users/thorvald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thorvald/subscriptions","organizations_url":"https://api.github.com/users/thorvald/orgs","repos_url":"https://api.github.com/users/thorvald/repos","events_url":"https://api.github.com/users/thorvald/events{/privacy}","received_events_url":"https://api.github.com/users/thorvald/received_events","type":"User","site_admin":false},"body":"Yes, it's safe. If you want to be style-consistent, then leave \"int i\" on a separate line, then initialize it in the for-loop.\r\n","created_at":"2015-05-18T17:44:14Z","updated_at":"2015-05-18T17:44:14Z","html_url":"https://github.com/medallia/thrift/pull/1#discussion_r30530102","pull_request_url":"https://api.github.com/repos/medallia/thrift/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/medallia/thrift/pulls/comments/30530102"},"html":{"href":"https://github.com/medallia/thrift/pull/1#discussion_r30530102"},"pull_request":{"href":"https://api.github.com/repos/medallia/thrift/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/medallia/thrift/pulls/1","id":35582057,"html_url":"https://github.com/medallia/thrift/pull/1","diff_url":"https://github.com/medallia/thrift/pull/1.diff","patch_url":"https://github.com/medallia/thrift/pull/1.patch","issue_url":"https://api.github.com/repos/medallia/thrift/issues/1","number":1,"state":"open","locked":false,"title":"Exponential methods for future combinations.","user":{"login":"hbandura","id":731692,"avatar_url":"https://avatars.githubusercontent.com/u/731692?v=3","gravatar_id":"","url":"https://api.github.com/users/hbandura","html_url":"https://github.com/hbandura","followers_url":"https://api.github.com/users/hbandura/followers","following_url":"https://api.github.com/users/hbandura/following{/other_user}","gists_url":"https://api.github.com/users/hbandura/gists{/gist_id}","starred_url":"https://api.github.com/users/hbandura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hbandura/subscriptions","organizations_url":"https://api.github.com/users/hbandura/orgs","repos_url":"https://api.github.com/users/hbandura/repos","events_url":"https://api.github.com/users/hbandura/events{/privacy}","received_events_url":"https://api.github.com/users/hbandura/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-05-17T05:22:30Z","updated_at":"2015-05-18T17:44:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac08d0f0ac10d3c79ca568e0dd706aa54e9cc693","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/medallia/thrift/pulls/1/commits","review_comments_url":"https://api.github.com/repos/medallia/thrift/pulls/1/comments","review_comment_url":"https://api.github.com/repos/medallia/thrift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/medallia/thrift/issues/1/comments","statuses_url":"https://api.github.com/repos/medallia/thrift/statuses/42649813bf788636d11bfeb560811d22bc414fe5","head":{"label":"hbandura:future-iface","ref":"future-iface","sha":"42649813bf788636d11bfeb560811d22bc414fe5","user":{"login":"hbandura","id":731692,"avatar_url":"https://avatars.githubusercontent.com/u/731692?v=3","gravatar_id":"","url":"https://api.github.com/users/hbandura","html_url":"https://github.com/hbandura","followers_url":"https://api.github.com/users/hbandura/followers","following_url":"https://api.github.com/users/hbandura/following{/other_user}","gists_url":"https://api.github.com/users/hbandura/gists{/gist_id}","starred_url":"https://api.github.com/users/hbandura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hbandura/subscriptions","organizations_url":"https://api.github.com/users/hbandura/orgs","repos_url":"https://api.github.com/users/hbandura/repos","events_url":"https://api.github.com/users/hbandura/events{/privacy}","received_events_url":"https://api.github.com/users/hbandura/received_events","type":"User","site_admin":false},"repo":{"id":35753121,"name":"thrift","full_name":"hbandura/thrift","owner":{"login":"hbandura","id":731692,"avatar_url":"https://avatars.githubusercontent.com/u/731692?v=3","gravatar_id":"","url":"https://api.github.com/users/hbandura","html_url":"https://github.com/hbandura","followers_url":"https://api.github.com/users/hbandura/followers","following_url":"https://api.github.com/users/hbandura/following{/other_user}","gists_url":"https://api.github.com/users/hbandura/gists{/gist_id}","starred_url":"https://api.github.com/users/hbandura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hbandura/subscriptions","organizations_url":"https://api.github.com/users/hbandura/orgs","repos_url":"https://api.github.com/users/hbandura/repos","events_url":"https://api.github.com/users/hbandura/events{/privacy}","received_events_url":"https://api.github.com/users/hbandura/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hbandura/thrift","description":"Fork of Apache Thrift to add support for FutureIface (async client based on Java8 CompletableFuture) in Java code generator","fork":true,"url":"https://api.github.com/repos/hbandura/thrift","forks_url":"https://api.github.com/repos/hbandura/thrift/forks","keys_url":"https://api.github.com/repos/hbandura/thrift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hbandura/thrift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hbandura/thrift/teams","hooks_url":"https://api.github.com/repos/hbandura/thrift/hooks","issue_events_url":"https://api.github.com/repos/hbandura/thrift/issues/events{/number}","events_url":"https://api.github.com/repos/hbandura/thrift/events","assignees_url":"https://api.github.com/repos/hbandura/thrift/assignees{/user}","branches_url":"https://api.github.com/repos/hbandura/thrift/branches{/branch}","tags_url":"https://api.github.com/repos/hbandura/thrift/tags","blobs_url":"https://api.github.com/repos/hbandura/thrift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hbandura/thrift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hbandura/thrift/git/refs{/sha}","trees_url":"https://api.github.com/repos/hbandura/thrift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hbandura/thrift/statuses/{sha}","languages_url":"https://api.github.com/repos/hbandura/thrift/languages","stargazers_url":"https://api.github.com/repos/hbandura/thrift/stargazers","contributors_url":"https://api.github.com/repos/hbandura/thrift/contributors","subscribers_url":"https://api.github.com/repos/hbandura/thrift/subscribers","subscription_url":"https://api.github.com/repos/hbandura/thrift/subscription","commits_url":"https://api.github.com/repos/hbandura/thrift/commits{/sha}","git_commits_url":"https://api.github.com/repos/hbandura/thrift/git/commits{/sha}","comments_url":"https://api.github.com/repos/hbandura/thrift/comments{/number}","issue_comment_url":"https://api.github.com/repos/hbandura/thrift/issues/comments{/number}","contents_url":"https://api.github.com/repos/hbandura/thrift/contents/{+path}","compare_url":"https://api.github.com/repos/hbandura/thrift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hbandura/thrift/merges","archive_url":"https://api.github.com/repos/hbandura/thrift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hbandura/thrift/downloads","issues_url":"https://api.github.com/repos/hbandura/thrift/issues{/number}","pulls_url":"https://api.github.com/repos/hbandura/thrift/pulls{/number}","milestones_url":"https://api.github.com/repos/hbandura/thrift/milestones{/number}","notifications_url":"https://api.github.com/repos/hbandura/thrift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hbandura/thrift/labels{/name}","releases_url":"https://api.github.com/repos/hbandura/thrift/releases{/id}","created_at":"2015-05-17T05:20:57Z","updated_at":"2015-05-17T05:21:02Z","pushed_at":"2015-05-18T17:23:54Z","git_url":"git://github.com/hbandura/thrift.git","ssh_url":"git@github.com:hbandura/thrift.git","clone_url":"https://github.com/hbandura/thrift.git","svn_url":"https://github.com/hbandura/thrift","homepage":"","size":12369,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"medallia:future-iface","ref":"future-iface","sha":"39e4ae31c9efe2bdcadc34792990cfadb9bbe79c","user":{"login":"medallia","id":2198222,"avatar_url":"https://avatars.githubusercontent.com/u/2198222?v=3","gravatar_id":"","url":"https://api.github.com/users/medallia","html_url":"https://github.com/medallia","followers_url":"https://api.github.com/users/medallia/followers","following_url":"https://api.github.com/users/medallia/following{/other_user}","gists_url":"https://api.github.com/users/medallia/gists{/gist_id}","starred_url":"https://api.github.com/users/medallia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/medallia/subscriptions","organizations_url":"https://api.github.com/users/medallia/orgs","repos_url":"https://api.github.com/users/medallia/repos","events_url":"https://api.github.com/users/medallia/events{/privacy}","received_events_url":"https://api.github.com/users/medallia/received_events","type":"Organization","site_admin":false},"repo":{"id":34145574,"name":"thrift","full_name":"medallia/thrift","owner":{"login":"medallia","id":2198222,"avatar_url":"https://avatars.githubusercontent.com/u/2198222?v=3","gravatar_id":"","url":"https://api.github.com/users/medallia","html_url":"https://github.com/medallia","followers_url":"https://api.github.com/users/medallia/followers","following_url":"https://api.github.com/users/medallia/following{/other_user}","gists_url":"https://api.github.com/users/medallia/gists{/gist_id}","starred_url":"https://api.github.com/users/medallia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/medallia/subscriptions","organizations_url":"https://api.github.com/users/medallia/orgs","repos_url":"https://api.github.com/users/medallia/repos","events_url":"https://api.github.com/users/medallia/events{/privacy}","received_events_url":"https://api.github.com/users/medallia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/medallia/thrift","description":"Fork of Apache Thrift to add support for FutureIface (async client based on Java8 CompletableFuture) in Java code generator","fork":true,"url":"https://api.github.com/repos/medallia/thrift","forks_url":"https://api.github.com/repos/medallia/thrift/forks","keys_url":"https://api.github.com/repos/medallia/thrift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/medallia/thrift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/medallia/thrift/teams","hooks_url":"https://api.github.com/repos/medallia/thrift/hooks","issue_events_url":"https://api.github.com/repos/medallia/thrift/issues/events{/number}","events_url":"https://api.github.com/repos/medallia/thrift/events","assignees_url":"https://api.github.com/repos/medallia/thrift/assignees{/user}","branches_url":"https://api.github.com/repos/medallia/thrift/branches{/branch}","tags_url":"https://api.github.com/repos/medallia/thrift/tags","blobs_url":"https://api.github.com/repos/medallia/thrift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/medallia/thrift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/medallia/thrift/git/refs{/sha}","trees_url":"https://api.github.com/repos/medallia/thrift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/medallia/thrift/statuses/{sha}","languages_url":"https://api.github.com/repos/medallia/thrift/languages","stargazers_url":"https://api.github.com/repos/medallia/thrift/stargazers","contributors_url":"https://api.github.com/repos/medallia/thrift/contributors","subscribers_url":"https://api.github.com/repos/medallia/thrift/subscribers","subscription_url":"https://api.github.com/repos/medallia/thrift/subscription","commits_url":"https://api.github.com/repos/medallia/thrift/commits{/sha}","git_commits_url":"https://api.github.com/repos/medallia/thrift/git/commits{/sha}","comments_url":"https://api.github.com/repos/medallia/thrift/comments{/number}","issue_comment_url":"https://api.github.com/repos/medallia/thrift/issues/comments{/number}","contents_url":"https://api.github.com/repos/medallia/thrift/contents/{+path}","compare_url":"https://api.github.com/repos/medallia/thrift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/medallia/thrift/merges","archive_url":"https://api.github.com/repos/medallia/thrift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/medallia/thrift/downloads","issues_url":"https://api.github.com/repos/medallia/thrift/issues{/number}","pulls_url":"https://api.github.com/repos/medallia/thrift/pulls{/number}","milestones_url":"https://api.github.com/repos/medallia/thrift/milestones{/number}","notifications_url":"https://api.github.com/repos/medallia/thrift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/medallia/thrift/labels{/name}","releases_url":"https://api.github.com/repos/medallia/thrift/releases{/id}","created_at":"2015-04-17T23:57:24Z","updated_at":"2015-04-21T21:10:44Z","pushed_at":"2015-05-18T17:23:55Z","git_url":"git://github.com/medallia/thrift.git","ssh_url":"git@github.com:medallia/thrift.git","clone_url":"https://github.com/medallia/thrift.git","svn_url":"https://github.com/medallia/thrift","homepage":"","size":12403,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/medallia/thrift/pulls/1"},"html":{"href":"https://github.com/medallia/thrift/pull/1"},"issue":{"href":"https://api.github.com/repos/medallia/thrift/issues/1"},"comments":{"href":"https://api.github.com/repos/medallia/thrift/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/medallia/thrift/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/medallia/thrift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/medallia/thrift/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/medallia/thrift/statuses/42649813bf788636d11bfeb560811d22bc414fe5"}}}}