{"action":"created","comment":{"url":"https://api.github.com/repos/LLNL/spack/pulls/comments/48173855","id":48173855,"diff_hunk":"@@ -15,15 +15,17 @@ class Hwloc(Package):\n     homepage = \"http://www.open-mpi.org/projects/hwloc/\"\n     url      = \"http://www.open-mpi.org/software/hwloc/v1.9/downloads/hwloc-1.9.tar.gz\"\n \n+    version('1.11.2', '486169cbe111cdea57be12638828ebbf',\n+            url='http://www.open-mpi.org/software/hwloc/v1.11/downloads/hwloc-1.11.2.tar.bz2')\n     version('1.11.1', '002742efd3a8431f98d6315365a2b543',\n             url='http://www.open-mpi.org/software/hwloc/v1.11/downloads/hwloc-1.11.1.tar.bz2')\n     version('1.9', '1f9f9155682fe8946a97c08896109508')\n \n-    depends_on('libpciaccess')\n+    # libpciaccess is not supported on OS X\n+    depends_on('libpciaccess', when='=linux')","path":"var/spack/packages/hwloc/package.py","position":12,"original_position":12,"commit_id":"b31f7bd19f159945968850f091093494a15e147b","original_commit_id":"b31f7bd19f159945968850f091093494a15e147b","user":{"login":"tgamblin","id":299842,"avatar_url":"https://avatars.githubusercontent.com/u/299842?v=3","gravatar_id":"","url":"https://api.github.com/users/tgamblin","html_url":"https://github.com/tgamblin","followers_url":"https://api.github.com/users/tgamblin/followers","following_url":"https://api.github.com/users/tgamblin/following{/other_user}","gists_url":"https://api.github.com/users/tgamblin/gists{/gist_id}","starred_url":"https://api.github.com/users/tgamblin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgamblin/subscriptions","organizations_url":"https://api.github.com/users/tgamblin/orgs","repos_url":"https://api.github.com/users/tgamblin/repos","events_url":"https://api.github.com/users/tgamblin/events{/privacy}","received_events_url":"https://api.github.com/users/tgamblin/received_events","type":"User","site_admin":false},"body":"Let me see what i can add -- one reason this is complicated is that the `spec` syntax doesn't really have a way to say \"not\" for architectures right now -- `Specs` are really match objects and they only match in the positive.\r\n\r\nA simple way to do this would be something like:\r\n```python\r\ndepends_on('libpciaccess', when='!=darwin-x86_64')\r\n```\r\nthat would be much clearer than the above proposals.  I would need to think through how the spec syntax should be modified to support this, but it is something we need.\r\n\r\nThe other option would be to just add \"when_not\", which might be easier short-term.  That would look like this:\r\n```python\r\ndepends_on('libpciaccess', when_not='=darwin-x86_64')\r\n```\r\nYou could test either of these in `install` by just writing:\r\n```python\r\n    if 'libpciaccess' in spec:\r\n        ...\r\n```\r\n\r\nWould either of those work for you?","created_at":"2015-12-21T18:22:53Z","updated_at":"2015-12-21T18:22:53Z","html_url":"https://github.com/LLNL/spack/pull/257#discussion_r48173855","pull_request_url":"https://api.github.com/repos/LLNL/spack/pulls/257","_links":{"self":{"href":"https://api.github.com/repos/LLNL/spack/pulls/comments/48173855"},"html":{"href":"https://github.com/LLNL/spack/pull/257#discussion_r48173855"},"pull_request":{"href":"https://api.github.com/repos/LLNL/spack/pulls/257"}}},"pull_request":{"url":"https://api.github.com/repos/LLNL/spack/pulls/257","id":54268951,"html_url":"https://github.com/LLNL/spack/pull/257","diff_url":"https://github.com/LLNL/spack/pull/257.diff","patch_url":"https://github.com/LLNL/spack/pull/257.patch","issue_url":"https://api.github.com/repos/LLNL/spack/issues/257","number":257,"state":"open","locked":false,"title":"Update hwloc; don't require libpciaccess on OS X","user":{"login":"eschnett","id":213514,"avatar_url":"https://avatars.githubusercontent.com/u/213514?v=3","gravatar_id":"","url":"https://api.github.com/users/eschnett","html_url":"https://github.com/eschnett","followers_url":"https://api.github.com/users/eschnett/followers","following_url":"https://api.github.com/users/eschnett/following{/other_user}","gists_url":"https://api.github.com/users/eschnett/gists{/gist_id}","starred_url":"https://api.github.com/users/eschnett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eschnett/subscriptions","organizations_url":"https://api.github.com/users/eschnett/orgs","repos_url":"https://api.github.com/users/eschnett/repos","events_url":"https://api.github.com/users/eschnett/events{/privacy}","received_events_url":"https://api.github.com/users/eschnett/received_events","type":"User","site_admin":false},"body":"- hwloc 1.11.2 is available.\r\n- libpciaccess is not supported on OS X; don't require it there.","created_at":"2015-12-21T15:35:15Z","updated_at":"2015-12-21T18:22:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0b0070039ebd82e6369cf7ca5954869d87e7df88","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/LLNL/spack/pulls/257/commits","review_comments_url":"https://api.github.com/repos/LLNL/spack/pulls/257/comments","review_comment_url":"https://api.github.com/repos/LLNL/spack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LLNL/spack/issues/257/comments","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/b31f7bd19f159945968850f091093494a15e147b","head":{"label":"eschnett:eschnett/hwloc-1.11.2","ref":"eschnett/hwloc-1.11.2","sha":"b31f7bd19f159945968850f091093494a15e147b","user":{"login":"eschnett","id":213514,"avatar_url":"https://avatars.githubusercontent.com/u/213514?v=3","gravatar_id":"","url":"https://api.github.com/users/eschnett","html_url":"https://github.com/eschnett","followers_url":"https://api.github.com/users/eschnett/followers","following_url":"https://api.github.com/users/eschnett/following{/other_user}","gists_url":"https://api.github.com/users/eschnett/gists{/gist_id}","starred_url":"https://api.github.com/users/eschnett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eschnett/subscriptions","organizations_url":"https://api.github.com/users/eschnett/orgs","repos_url":"https://api.github.com/users/eschnett/repos","events_url":"https://api.github.com/users/eschnett/events{/privacy}","received_events_url":"https://api.github.com/users/eschnett/received_events","type":"User","site_admin":false},"repo":{"id":46377584,"name":"spack","full_name":"eschnett/spack","owner":{"login":"eschnett","id":213514,"avatar_url":"https://avatars.githubusercontent.com/u/213514?v=3","gravatar_id":"","url":"https://api.github.com/users/eschnett","html_url":"https://github.com/eschnett","followers_url":"https://api.github.com/users/eschnett/followers","following_url":"https://api.github.com/users/eschnett/following{/other_user}","gists_url":"https://api.github.com/users/eschnett/gists{/gist_id}","starred_url":"https://api.github.com/users/eschnett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eschnett/subscriptions","organizations_url":"https://api.github.com/users/eschnett/orgs","repos_url":"https://api.github.com/users/eschnett/repos","events_url":"https://api.github.com/users/eschnett/events{/privacy}","received_events_url":"https://api.github.com/users/eschnett/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eschnett/spack","description":"A flexible package manager designed to support multiple versions, configurations, platforms, and compilers.","fork":true,"url":"https://api.github.com/repos/eschnett/spack","forks_url":"https://api.github.com/repos/eschnett/spack/forks","keys_url":"https://api.github.com/repos/eschnett/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eschnett/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eschnett/spack/teams","hooks_url":"https://api.github.com/repos/eschnett/spack/hooks","issue_events_url":"https://api.github.com/repos/eschnett/spack/issues/events{/number}","events_url":"https://api.github.com/repos/eschnett/spack/events","assignees_url":"https://api.github.com/repos/eschnett/spack/assignees{/user}","branches_url":"https://api.github.com/repos/eschnett/spack/branches{/branch}","tags_url":"https://api.github.com/repos/eschnett/spack/tags","blobs_url":"https://api.github.com/repos/eschnett/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eschnett/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eschnett/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/eschnett/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eschnett/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/eschnett/spack/languages","stargazers_url":"https://api.github.com/repos/eschnett/spack/stargazers","contributors_url":"https://api.github.com/repos/eschnett/spack/contributors","subscribers_url":"https://api.github.com/repos/eschnett/spack/subscribers","subscription_url":"https://api.github.com/repos/eschnett/spack/subscription","commits_url":"https://api.github.com/repos/eschnett/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/eschnett/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/eschnett/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/eschnett/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/eschnett/spack/contents/{+path}","compare_url":"https://api.github.com/repos/eschnett/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eschnett/spack/merges","archive_url":"https://api.github.com/repos/eschnett/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eschnett/spack/downloads","issues_url":"https://api.github.com/repos/eschnett/spack/issues{/number}","pulls_url":"https://api.github.com/repos/eschnett/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/eschnett/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/eschnett/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eschnett/spack/labels{/name}","releases_url":"https://api.github.com/repos/eschnett/spack/releases{/id}","created_at":"2015-11-17T21:48:07Z","updated_at":"2015-11-17T21:48:09Z","pushed_at":"2015-12-21T15:36:44Z","git_url":"git://github.com/eschnett/spack.git","ssh_url":"git@github.com:eschnett/spack.git","clone_url":"https://github.com/eschnett/spack.git","svn_url":"https://github.com/eschnett/spack","homepage":"http://scalability-llnl.github.io/spack","size":3053,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"LLNL:develop","ref":"develop","sha":"dccfcd10f7eaea8bfa7db75d1b49c6119854e0ec","user":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"repo":{"id":15730865,"name":"spack","full_name":"LLNL/spack","owner":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LLNL/spack","description":"A flexible package manager designed to support multiple versions, configurations, platforms, and compilers.","fork":false,"url":"https://api.github.com/repos/LLNL/spack","forks_url":"https://api.github.com/repos/LLNL/spack/forks","keys_url":"https://api.github.com/repos/LLNL/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LLNL/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LLNL/spack/teams","hooks_url":"https://api.github.com/repos/LLNL/spack/hooks","issue_events_url":"https://api.github.com/repos/LLNL/spack/issues/events{/number}","events_url":"https://api.github.com/repos/LLNL/spack/events","assignees_url":"https://api.github.com/repos/LLNL/spack/assignees{/user}","branches_url":"https://api.github.com/repos/LLNL/spack/branches{/branch}","tags_url":"https://api.github.com/repos/LLNL/spack/tags","blobs_url":"https://api.github.com/repos/LLNL/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LLNL/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LLNL/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/LLNL/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/LLNL/spack/languages","stargazers_url":"https://api.github.com/repos/LLNL/spack/stargazers","contributors_url":"https://api.github.com/repos/LLNL/spack/contributors","subscribers_url":"https://api.github.com/repos/LLNL/spack/subscribers","subscription_url":"https://api.github.com/repos/LLNL/spack/subscription","commits_url":"https://api.github.com/repos/LLNL/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/LLNL/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/LLNL/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/LLNL/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/LLNL/spack/contents/{+path}","compare_url":"https://api.github.com/repos/LLNL/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LLNL/spack/merges","archive_url":"https://api.github.com/repos/LLNL/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LLNL/spack/downloads","issues_url":"https://api.github.com/repos/LLNL/spack/issues{/number}","pulls_url":"https://api.github.com/repos/LLNL/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/LLNL/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/LLNL/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LLNL/spack/labels{/name}","releases_url":"https://api.github.com/repos/LLNL/spack/releases{/id}","created_at":"2014-01-08T09:22:12Z","updated_at":"2015-12-18T03:43:25Z","pushed_at":"2015-12-21T17:24:17Z","git_url":"git://github.com/LLNL/spack.git","ssh_url":"git@github.com:LLNL/spack.git","clone_url":"https://github.com/LLNL/spack.git","svn_url":"https://github.com/LLNL/spack","homepage":"http://llnl.github.io/spack","size":4195,"stargazers_count":64,"watchers_count":64,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":62,"mirror_url":null,"open_issues_count":58,"forks":62,"open_issues":58,"watchers":64,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/LLNL/spack/pulls/257"},"html":{"href":"https://github.com/LLNL/spack/pull/257"},"issue":{"href":"https://api.github.com/repos/LLNL/spack/issues/257"},"comments":{"href":"https://api.github.com/repos/LLNL/spack/issues/257/comments"},"review_comments":{"href":"https://api.github.com/repos/LLNL/spack/pulls/257/comments"},"review_comment":{"href":"https://api.github.com/repos/LLNL/spack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LLNL/spack/pulls/257/commits"},"statuses":{"href":"https://api.github.com/repos/LLNL/spack/statuses/b31f7bd19f159945968850f091093494a15e147b"}}}}