{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/36222977","id":36222977,"diff_hunk":"@@ -23,7 +23,7 @@ public DirectoryInfo(String path)\n         }\n \n         [System.Security.SecuritySafeCritical]\n-        internal DirectoryInfo(String fullPath, IFileSystemObject fileSystemObject) : base(fileSystemObject)\n+        internal DirectoryInfo(String fullPath, bool ignoreThis)","path":"src/System.IO.FileSystem/src/System/IO/DirectoryInfo.cs","position":14,"original_position":14,"commit_id":"208a33a6283e44ad6dd2df04ece5afa18f88e01d","original_commit_id":"208a33a6283e44ad6dd2df04ece5afa18f88e01d","user":{"login":"justinvp","id":710598,"avatar_url":"https://avatars.githubusercontent.com/u/710598?v=3","gravatar_id":"","url":"https://api.github.com/users/justinvp","html_url":"https://github.com/justinvp","followers_url":"https://api.github.com/users/justinvp/followers","following_url":"https://api.github.com/users/justinvp/following{/other_user}","gists_url":"https://api.github.com/users/justinvp/gists{/gist_id}","starred_url":"https://api.github.com/users/justinvp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinvp/subscriptions","organizations_url":"https://api.github.com/users/justinvp/orgs","repos_url":"https://api.github.com/users/justinvp/repos","events_url":"https://api.github.com/users/justinvp/events{/privacy}","received_events_url":"https://api.github.com/users/justinvp/received_events","type":"User","site_admin":false},"body":"> The ignored parameter is unfortunate.\r\n\r\nI agree. I just went with the ignored parameter as this is what was done [previously](https://github.com/dotnet/coreclr/blob/4cf8a6b082d9bb1789facd996d8265d3908757b2/src/mscorlib/src/System/IO/FileInfo.cs#L132). I'll hold off on improving this until I hear back on the overall direction of the proposal.","created_at":"2015-08-04T18:20:43Z","updated_at":"2015-08-04T18:20:43Z","html_url":"https://github.com/dotnet/corefx/pull/2343#discussion_r36222977","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/2343","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/36222977"},"html":{"href":"https://github.com/dotnet/corefx/pull/2343#discussion_r36222977"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/2343"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/2343","id":39860721,"html_url":"https://github.com/dotnet/corefx/pull/2343","diff_url":"https://github.com/dotnet/corefx/pull/2343.diff","patch_url":"https://github.com/dotnet/corefx/pull/2343.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/2343","number":2343,"state":"open","locked":false,"title":"Eliminate extra IFileSystemObject allocation for FileSystemInfo/FileInfo/DirectoryInfo on Win32 and Unix","user":{"login":"justinvp","id":710598,"avatar_url":"https://avatars.githubusercontent.com/u/710598?v=3","gravatar_id":"","url":"https://api.github.com/users/justinvp","html_url":"https://github.com/justinvp","followers_url":"https://api.github.com/users/justinvp/followers","following_url":"https://api.github.com/users/justinvp/following{/other_user}","gists_url":"https://api.github.com/users/justinvp/gists{/gist_id}","starred_url":"https://api.github.com/users/justinvp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinvp/subscriptions","organizations_url":"https://api.github.com/users/justinvp/orgs","repos_url":"https://api.github.com/users/justinvp/repos","events_url":"https://api.github.com/users/justinvp/events{/privacy}","received_events_url":"https://api.github.com/users/justinvp/received_events","type":"User","site_admin":false},"body":"`FileSystemInfo`/`FileInfo`/`DirectoryInfo` carry an internal `IFileSystemObject`, which `FileSystemInfo` calls for the actual implementation. While this enables `FileSystemInfo`/`FileInfo`/`DirectoryInfo` to be used with WinRT on Windows, it comes with the cost of an extra unnecessary object allocation for plain Win32 and Unix. The extra allocation might not be a huge deal for one-off instances of `FileInfo` or `DirectoryInfo` but when enumerating lots of these from the file system, the extra allocations start adding up.\r\n\r\nThis change eliminates the extra object allocation on Win32 and Unix, while keeping the internal `FileSystem` abstraction intact. After this change, the extra object allocation only happens when the WinRT APIs need to be used on Windows.\r\n\r\nIt does this by having `FileSystemInfo` implement the internal `IFileSystemObject` interface itself, instead of implementing the interface on separate `Win32FileSystemObject` and `UnixFileSystemObject` objects. `FileSytemInfo` becomes a partial class and its internal `FileSystemObject` property that provides the `IFileSystemObject` instance is moved to be defined by platform-specific partials. Win32FileSystemObject.cs becomes the FileSystemInfo.Windows.cs partial along with the FileSystemInfo.Win32.cs partial and its `FileSystemObject` always returns `this`, similarly, UnixFileSystemObject.cs becomes FileSystemInfo.Unix.cs and returns `this` for `FileSystemObject`. FileSystemInfo.WinRT.cs does the multi-plexing behavior: if the Win32 APIs can be used, `FileSystemObject` returns `this`, otherwise it returns a `WinRTFileSystemObject` that uses the WinRT APIs.\r\n\r\nAside: I'd like to use a similar approach to eliminate the need for the extra `FileStreamBase` object allocation inside `FileStream`, but I'll submit that as a separate PR, assuming the approach in this PR (or something like it) is acceptable.\r\n\r\nNote: I could not compile/test the WinRT side (`EnableWinRT=true`) so it's possible I missed something there.","created_at":"2015-07-13T21:51:05Z","updated_at":"2015-08-04T18:20:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"610bb6c539675646f220b8a47a866b5ccbfc1268","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/2343/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/2343/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/2343/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/208a33a6283e44ad6dd2df04ece5afa18f88e01d","head":{"label":"justinvp:filesysteminfo","ref":"filesysteminfo","sha":"208a33a6283e44ad6dd2df04ece5afa18f88e01d","user":{"login":"justinvp","id":710598,"avatar_url":"https://avatars.githubusercontent.com/u/710598?v=3","gravatar_id":"","url":"https://api.github.com/users/justinvp","html_url":"https://github.com/justinvp","followers_url":"https://api.github.com/users/justinvp/followers","following_url":"https://api.github.com/users/justinvp/following{/other_user}","gists_url":"https://api.github.com/users/justinvp/gists{/gist_id}","starred_url":"https://api.github.com/users/justinvp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinvp/subscriptions","organizations_url":"https://api.github.com/users/justinvp/orgs","repos_url":"https://api.github.com/users/justinvp/repos","events_url":"https://api.github.com/users/justinvp/events{/privacy}","received_events_url":"https://api.github.com/users/justinvp/received_events","type":"User","site_admin":false},"repo":{"id":28229041,"name":"corefx","full_name":"justinvp/corefx","owner":{"login":"justinvp","id":710598,"avatar_url":"https://avatars.githubusercontent.com/u/710598?v=3","gravatar_id":"","url":"https://api.github.com/users/justinvp","html_url":"https://github.com/justinvp","followers_url":"https://api.github.com/users/justinvp/followers","following_url":"https://api.github.com/users/justinvp/following{/other_user}","gists_url":"https://api.github.com/users/justinvp/gists{/gist_id}","starred_url":"https://api.github.com/users/justinvp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinvp/subscriptions","organizations_url":"https://api.github.com/users/justinvp/orgs","repos_url":"https://api.github.com/users/justinvp/repos","events_url":"https://api.github.com/users/justinvp/events{/privacy}","received_events_url":"https://api.github.com/users/justinvp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/justinvp/corefx","description":"This repository contains the foundational libraries that make up the .NET Core development stack.","fork":true,"url":"https://api.github.com/repos/justinvp/corefx","forks_url":"https://api.github.com/repos/justinvp/corefx/forks","keys_url":"https://api.github.com/repos/justinvp/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/justinvp/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/justinvp/corefx/teams","hooks_url":"https://api.github.com/repos/justinvp/corefx/hooks","issue_events_url":"https://api.github.com/repos/justinvp/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/justinvp/corefx/events","assignees_url":"https://api.github.com/repos/justinvp/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/justinvp/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/justinvp/corefx/tags","blobs_url":"https://api.github.com/repos/justinvp/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/justinvp/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/justinvp/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/justinvp/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/justinvp/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/justinvp/corefx/languages","stargazers_url":"https://api.github.com/repos/justinvp/corefx/stargazers","contributors_url":"https://api.github.com/repos/justinvp/corefx/contributors","subscribers_url":"https://api.github.com/repos/justinvp/corefx/subscribers","subscription_url":"https://api.github.com/repos/justinvp/corefx/subscription","commits_url":"https://api.github.com/repos/justinvp/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/justinvp/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/justinvp/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/justinvp/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/justinvp/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/justinvp/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/justinvp/corefx/merges","archive_url":"https://api.github.com/repos/justinvp/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/justinvp/corefx/downloads","issues_url":"https://api.github.com/repos/justinvp/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/justinvp/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/justinvp/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/justinvp/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/justinvp/corefx/labels{/name}","releases_url":"https://api.github.com/repos/justinvp/corefx/releases{/id}","created_at":"2014-12-19T12:43:43Z","updated_at":"2015-04-30T22:29:39Z","pushed_at":"2015-08-03T21:00:24Z","git_url":"git://github.com/justinvp/corefx.git","ssh_url":"git@github.com:justinvp/corefx.git","clone_url":"https://github.com/justinvp/corefx.git","svn_url":"https://github.com/justinvp/corefx","homepage":"","size":26075,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"b128e585280b624d208cea2fefb52f5885bdc076","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","created_at":"2014-11-06T23:42:48Z","updated_at":"2015-08-04T16:14:40Z","pushed_at":"2015-08-04T18:13:35Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/core/","size":57832,"stargazers_count":8166,"watchers_count":8166,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1712,"mirror_url":null,"open_issues_count":530,"forks":1712,"open_issues":530,"watchers":8166,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/2343"},"html":{"href":"https://github.com/dotnet/corefx/pull/2343"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/2343"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/2343/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/2343/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/2343/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/208a33a6283e44ad6dd2df04ece5afa18f88e01d"}}}}