{"action":"created","issue":{"url":"https://api.github.com/repos/MightyPirates/OpenComputers/issues/848","labels_url":"https://api.github.com/repos/MightyPirates/OpenComputers/issues/848/labels{/name}","comments_url":"https://api.github.com/repos/MightyPirates/OpenComputers/issues/848/comments","events_url":"https://api.github.com/repos/MightyPirates/OpenComputers/issues/848/events","html_url":"https://github.com/MightyPirates/OpenComputers/pull/848","id":55386126,"number":848,"title":"Fix InventoryUtils.insertIntoInventory","user":{"login":"DirtYiCE","id":81199,"avatar_url":"https://avatars.githubusercontent.com/u/81199?v=3","gravatar_id":"","url":"https://api.github.com/users/DirtYiCE","html_url":"https://github.com/DirtYiCE","followers_url":"https://api.github.com/users/DirtYiCE/followers","following_url":"https://api.github.com/users/DirtYiCE/following{/other_user}","gists_url":"https://api.github.com/users/DirtYiCE/gists{/gist_id}","starred_url":"https://api.github.com/users/DirtYiCE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DirtYiCE/subscriptions","organizations_url":"https://api.github.com/users/DirtYiCE/orgs","repos_url":"https://api.github.com/users/DirtYiCE/repos","events_url":"https://api.github.com/users/DirtYiCE/events{/privacy}","received_events_url":"https://api.github.com/users/DirtYiCE/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-01-24T21:50:38Z","updated_at":"2015-01-27T16:45:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/MightyPirates/OpenComputers/pulls/848","html_url":"https://github.com/MightyPirates/OpenComputers/pull/848","diff_url":"https://github.com/MightyPirates/OpenComputers/pull/848.diff","patch_url":"https://github.com/MightyPirates/OpenComputers/pull/848.patch"},"body":"According to the documentation `inventory_controller.suckFromSlot`, `robot.suck` and friends try to put the sucked item into the selected slot, and only if it's occupied try others. However the implementation first tried to merge the stack with existing stacks in the inventory, and only if it failed put into the selected slot. This commit fixes it.\r\n\r\nBut only of course if the documented is the intended behaviour. (But I hope so, because otherwise using `robot.suck` is a mess since you have no idea what you just picked up at where it ended, unless you have a completely empty inventory...)"},"comment":{"url":"https://api.github.com/repos/MightyPirates/OpenComputers/issues/comments/71681116","html_url":"https://github.com/MightyPirates/OpenComputers/pull/848#issuecomment-71681116","issue_url":"https://api.github.com/repos/MightyPirates/OpenComputers/issues/848","id":71681116,"user":{"login":"DirtYiCE","id":81199,"avatar_url":"https://avatars.githubusercontent.com/u/81199?v=3","gravatar_id":"","url":"https://api.github.com/users/DirtYiCE","html_url":"https://github.com/DirtYiCE","followers_url":"https://api.github.com/users/DirtYiCE/followers","following_url":"https://api.github.com/users/DirtYiCE/following{/other_user}","gists_url":"https://api.github.com/users/DirtYiCE/gists{/gist_id}","starred_url":"https://api.github.com/users/DirtYiCE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DirtYiCE/subscriptions","organizations_url":"https://api.github.com/users/DirtYiCE/orgs","repos_url":"https://api.github.com/users/DirtYiCE/repos","events_url":"https://api.github.com/users/DirtYiCE/events{/privacy}","received_events_url":"https://api.github.com/users/DirtYiCE/received_events","type":"User","site_admin":false},"created_at":"2015-01-27T16:45:10Z","updated_at":"2015-01-27T16:45:10Z","body":"Actually there is a problem with that second return value: what if the itemstack ends up in multiple slots? Return all of them?"}}