{"action":"created","comment":{"url":"https://api.github.com/repos/MakerStudios/souvenir/pulls/comments/47807428","id":47807428,"diff_hunk":"@@ -47,6 +47,7 @@ function cache(cache_provider, cache_options)\n \t\t\t\t{\n \t\t\t\t\t// If there was an error interacting with the cache, then\n \t\t\t\t\t// fall through to the original function.\n+\t\t\t\t\t// (this will never happen in current code state)","path":"lib/cache.js","position":4,"original_position":4,"commit_id":"f97a0f9f62adeec6434a6350e90ee34244e6ecf2","original_commit_id":"f97a0f9f62adeec6434a6350e90ee34244e6ecf2","user":{"login":"jbergknoff","id":2678832,"avatar_url":"https://avatars.githubusercontent.com/u/2678832?v=3","gravatar_id":"","url":"https://api.github.com/users/jbergknoff","html_url":"https://github.com/jbergknoff","followers_url":"https://api.github.com/users/jbergknoff/followers","following_url":"https://api.github.com/users/jbergknoff/following{/other_user}","gists_url":"https://api.github.com/users/jbergknoff/gists{/gist_id}","starred_url":"https://api.github.com/users/jbergknoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbergknoff/subscriptions","organizations_url":"https://api.github.com/users/jbergknoff/orgs","repos_url":"https://api.github.com/users/jbergknoff/repos","events_url":"https://api.github.com/users/jbergknoff/events{/privacy}","received_events_url":"https://api.github.com/users/jbergknoff/received_events","type":"User","site_admin":false},"body":"I'm not sure why I swallowed the error in the redis cache provider. That seems like an oversight that we may want to fix.\r\n\r\nHowever, a user might bring his own cache provider which does emit errors, so this comment isn't quite right.","created_at":"2015-12-16T17:35:06Z","updated_at":"2015-12-16T17:35:06Z","html_url":"https://github.com/MakerStudios/souvenir/pull/7#discussion_r47807428","pull_request_url":"https://api.github.com/repos/MakerStudios/souvenir/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/MakerStudios/souvenir/pulls/comments/47807428"},"html":{"href":"https://github.com/MakerStudios/souvenir/pull/7#discussion_r47807428"},"pull_request":{"href":"https://api.github.com/repos/MakerStudios/souvenir/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/MakerStudios/souvenir/pulls/7","id":53786098,"html_url":"https://github.com/MakerStudios/souvenir/pull/7","diff_url":"https://github.com/MakerStudios/souvenir/pull/7.diff","patch_url":"https://github.com/MakerStudios/souvenir/pull/7.patch","issue_url":"https://api.github.com/repos/MakerStudios/souvenir/issues/7","number":7,"state":"open","locked":false,"title":"Sequential same key requests issue","user":{"login":"camsjams","id":833485,"avatar_url":"https://avatars.githubusercontent.com/u/833485?v=3","gravatar_id":"","url":"https://api.github.com/users/camsjams","html_url":"https://github.com/camsjams","followers_url":"https://api.github.com/users/camsjams/followers","following_url":"https://api.github.com/users/camsjams/following{/other_user}","gists_url":"https://api.github.com/users/camsjams/gists{/gist_id}","starred_url":"https://api.github.com/users/camsjams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camsjams/subscriptions","organizations_url":"https://api.github.com/users/camsjams/orgs","repos_url":"https://api.github.com/users/camsjams/repos","events_url":"https://api.github.com/users/camsjams/events{/privacy}","received_events_url":"https://api.github.com/users/camsjams/received_events","type":"User","site_admin":false},"body":"This is a patch to fix a case where same-key requests are made to souvenir, and the first is handled but doesn't send callbacks to next in line invocations. Occurs from cache `set` portion of code as well as `get` from cache.\r\n\r\nIt is more apparent when using redis cache layer.\r\n\r\nThe bug was introduced in [v1.1.0](https://github.com/MakerStudios/souvenir/tree/v1.1.0)\r\n\r\nSee added unit test for an example of how the issue occurs.","created_at":"2015-12-16T01:03:37Z","updated_at":"2015-12-16T17:35:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9334c860d6ac4074816b60259dd2a5f2d649d88e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MakerStudios/souvenir/pulls/7/commits","review_comments_url":"https://api.github.com/repos/MakerStudios/souvenir/pulls/7/comments","review_comment_url":"https://api.github.com/repos/MakerStudios/souvenir/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MakerStudios/souvenir/issues/7/comments","statuses_url":"https://api.github.com/repos/MakerStudios/souvenir/statuses/f97a0f9f62adeec6434a6350e90ee34244e6ecf2","head":{"label":"MakerStudios:pending-callbacks","ref":"pending-callbacks","sha":"f97a0f9f62adeec6434a6350e90ee34244e6ecf2","user":{"login":"MakerStudios","id":1356202,"avatar_url":"https://avatars.githubusercontent.com/u/1356202?v=3","gravatar_id":"","url":"https://api.github.com/users/MakerStudios","html_url":"https://github.com/MakerStudios","followers_url":"https://api.github.com/users/MakerStudios/followers","following_url":"https://api.github.com/users/MakerStudios/following{/other_user}","gists_url":"https://api.github.com/users/MakerStudios/gists{/gist_id}","starred_url":"https://api.github.com/users/MakerStudios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MakerStudios/subscriptions","organizations_url":"https://api.github.com/users/MakerStudios/orgs","repos_url":"https://api.github.com/users/MakerStudios/repos","events_url":"https://api.github.com/users/MakerStudios/events{/privacy}","received_events_url":"https://api.github.com/users/MakerStudios/received_events","type":"Organization","site_admin":false},"repo":{"id":13076966,"name":"souvenir","full_name":"MakerStudios/souvenir","owner":{"login":"MakerStudios","id":1356202,"avatar_url":"https://avatars.githubusercontent.com/u/1356202?v=3","gravatar_id":"","url":"https://api.github.com/users/MakerStudios","html_url":"https://github.com/MakerStudios","followers_url":"https://api.github.com/users/MakerStudios/followers","following_url":"https://api.github.com/users/MakerStudios/following{/other_user}","gists_url":"https://api.github.com/users/MakerStudios/gists{/gist_id}","starred_url":"https://api.github.com/users/MakerStudios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MakerStudios/subscriptions","organizations_url":"https://api.github.com/users/MakerStudios/orgs","repos_url":"https://api.github.com/users/MakerStudios/repos","events_url":"https://api.github.com/users/MakerStudios/events{/privacy}","received_events_url":"https://api.github.com/users/MakerStudios/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MakerStudios/souvenir","description":"Unobtrusive caching for async functions","fork":false,"url":"https://api.github.com/repos/MakerStudios/souvenir","forks_url":"https://api.github.com/repos/MakerStudios/souvenir/forks","keys_url":"https://api.github.com/repos/MakerStudios/souvenir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MakerStudios/souvenir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MakerStudios/souvenir/teams","hooks_url":"https://api.github.com/repos/MakerStudios/souvenir/hooks","issue_events_url":"https://api.github.com/repos/MakerStudios/souvenir/issues/events{/number}","events_url":"https://api.github.com/repos/MakerStudios/souvenir/events","assignees_url":"https://api.github.com/repos/MakerStudios/souvenir/assignees{/user}","branches_url":"https://api.github.com/repos/MakerStudios/souvenir/branches{/branch}","tags_url":"https://api.github.com/repos/MakerStudios/souvenir/tags","blobs_url":"https://api.github.com/repos/MakerStudios/souvenir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MakerStudios/souvenir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MakerStudios/souvenir/git/refs{/sha}","trees_url":"https://api.github.com/repos/MakerStudios/souvenir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MakerStudios/souvenir/statuses/{sha}","languages_url":"https://api.github.com/repos/MakerStudios/souvenir/languages","stargazers_url":"https://api.github.com/repos/MakerStudios/souvenir/stargazers","contributors_url":"https://api.github.com/repos/MakerStudios/souvenir/contributors","subscribers_url":"https://api.github.com/repos/MakerStudios/souvenir/subscribers","subscription_url":"https://api.github.com/repos/MakerStudios/souvenir/subscription","commits_url":"https://api.github.com/repos/MakerStudios/souvenir/commits{/sha}","git_commits_url":"https://api.github.com/repos/MakerStudios/souvenir/git/commits{/sha}","comments_url":"https://api.github.com/repos/MakerStudios/souvenir/comments{/number}","issue_comment_url":"https://api.github.com/repos/MakerStudios/souvenir/issues/comments{/number}","contents_url":"https://api.github.com/repos/MakerStudios/souvenir/contents/{+path}","compare_url":"https://api.github.com/repos/MakerStudios/souvenir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MakerStudios/souvenir/merges","archive_url":"https://api.github.com/repos/MakerStudios/souvenir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MakerStudios/souvenir/downloads","issues_url":"https://api.github.com/repos/MakerStudios/souvenir/issues{/number}","pulls_url":"https://api.github.com/repos/MakerStudios/souvenir/pulls{/number}","milestones_url":"https://api.github.com/repos/MakerStudios/souvenir/milestones{/number}","notifications_url":"https://api.github.com/repos/MakerStudios/souvenir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MakerStudios/souvenir/labels{/name}","releases_url":"https://api.github.com/repos/MakerStudios/souvenir/releases{/id}","created_at":"2013-09-24T21:24:45Z","updated_at":"2015-06-09T12:26:36Z","pushed_at":"2015-12-16T01:30:22Z","git_url":"git://github.com/MakerStudios/souvenir.git","ssh_url":"git@github.com:MakerStudios/souvenir.git","clone_url":"https://github.com/MakerStudios/souvenir.git","svn_url":"https://github.com/MakerStudios/souvenir","homepage":"","size":49,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":5,"default_branch":"master"}},"base":{"label":"MakerStudios:master","ref":"master","sha":"7f37da6a3c3ba7361c9777ca82e0f16aa59aed87","user":{"login":"MakerStudios","id":1356202,"avatar_url":"https://avatars.githubusercontent.com/u/1356202?v=3","gravatar_id":"","url":"https://api.github.com/users/MakerStudios","html_url":"https://github.com/MakerStudios","followers_url":"https://api.github.com/users/MakerStudios/followers","following_url":"https://api.github.com/users/MakerStudios/following{/other_user}","gists_url":"https://api.github.com/users/MakerStudios/gists{/gist_id}","starred_url":"https://api.github.com/users/MakerStudios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MakerStudios/subscriptions","organizations_url":"https://api.github.com/users/MakerStudios/orgs","repos_url":"https://api.github.com/users/MakerStudios/repos","events_url":"https://api.github.com/users/MakerStudios/events{/privacy}","received_events_url":"https://api.github.com/users/MakerStudios/received_events","type":"Organization","site_admin":false},"repo":{"id":13076966,"name":"souvenir","full_name":"MakerStudios/souvenir","owner":{"login":"MakerStudios","id":1356202,"avatar_url":"https://avatars.githubusercontent.com/u/1356202?v=3","gravatar_id":"","url":"https://api.github.com/users/MakerStudios","html_url":"https://github.com/MakerStudios","followers_url":"https://api.github.com/users/MakerStudios/followers","following_url":"https://api.github.com/users/MakerStudios/following{/other_user}","gists_url":"https://api.github.com/users/MakerStudios/gists{/gist_id}","starred_url":"https://api.github.com/users/MakerStudios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MakerStudios/subscriptions","organizations_url":"https://api.github.com/users/MakerStudios/orgs","repos_url":"https://api.github.com/users/MakerStudios/repos","events_url":"https://api.github.com/users/MakerStudios/events{/privacy}","received_events_url":"https://api.github.com/users/MakerStudios/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MakerStudios/souvenir","description":"Unobtrusive caching for async functions","fork":false,"url":"https://api.github.com/repos/MakerStudios/souvenir","forks_url":"https://api.github.com/repos/MakerStudios/souvenir/forks","keys_url":"https://api.github.com/repos/MakerStudios/souvenir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MakerStudios/souvenir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MakerStudios/souvenir/teams","hooks_url":"https://api.github.com/repos/MakerStudios/souvenir/hooks","issue_events_url":"https://api.github.com/repos/MakerStudios/souvenir/issues/events{/number}","events_url":"https://api.github.com/repos/MakerStudios/souvenir/events","assignees_url":"https://api.github.com/repos/MakerStudios/souvenir/assignees{/user}","branches_url":"https://api.github.com/repos/MakerStudios/souvenir/branches{/branch}","tags_url":"https://api.github.com/repos/MakerStudios/souvenir/tags","blobs_url":"https://api.github.com/repos/MakerStudios/souvenir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MakerStudios/souvenir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MakerStudios/souvenir/git/refs{/sha}","trees_url":"https://api.github.com/repos/MakerStudios/souvenir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MakerStudios/souvenir/statuses/{sha}","languages_url":"https://api.github.com/repos/MakerStudios/souvenir/languages","stargazers_url":"https://api.github.com/repos/MakerStudios/souvenir/stargazers","contributors_url":"https://api.github.com/repos/MakerStudios/souvenir/contributors","subscribers_url":"https://api.github.com/repos/MakerStudios/souvenir/subscribers","subscription_url":"https://api.github.com/repos/MakerStudios/souvenir/subscription","commits_url":"https://api.github.com/repos/MakerStudios/souvenir/commits{/sha}","git_commits_url":"https://api.github.com/repos/MakerStudios/souvenir/git/commits{/sha}","comments_url":"https://api.github.com/repos/MakerStudios/souvenir/comments{/number}","issue_comment_url":"https://api.github.com/repos/MakerStudios/souvenir/issues/comments{/number}","contents_url":"https://api.github.com/repos/MakerStudios/souvenir/contents/{+path}","compare_url":"https://api.github.com/repos/MakerStudios/souvenir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MakerStudios/souvenir/merges","archive_url":"https://api.github.com/repos/MakerStudios/souvenir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MakerStudios/souvenir/downloads","issues_url":"https://api.github.com/repos/MakerStudios/souvenir/issues{/number}","pulls_url":"https://api.github.com/repos/MakerStudios/souvenir/pulls{/number}","milestones_url":"https://api.github.com/repos/MakerStudios/souvenir/milestones{/number}","notifications_url":"https://api.github.com/repos/MakerStudios/souvenir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MakerStudios/souvenir/labels{/name}","releases_url":"https://api.github.com/repos/MakerStudios/souvenir/releases{/id}","created_at":"2013-09-24T21:24:45Z","updated_at":"2015-06-09T12:26:36Z","pushed_at":"2015-12-16T01:30:22Z","git_url":"git://github.com/MakerStudios/souvenir.git","ssh_url":"git@github.com:MakerStudios/souvenir.git","clone_url":"https://github.com/MakerStudios/souvenir.git","svn_url":"https://github.com/MakerStudios/souvenir","homepage":"","size":49,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MakerStudios/souvenir/pulls/7"},"html":{"href":"https://github.com/MakerStudios/souvenir/pull/7"},"issue":{"href":"https://api.github.com/repos/MakerStudios/souvenir/issues/7"},"comments":{"href":"https://api.github.com/repos/MakerStudios/souvenir/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/MakerStudios/souvenir/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/MakerStudios/souvenir/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MakerStudios/souvenir/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/MakerStudios/souvenir/statuses/f97a0f9f62adeec6434a6350e90ee34244e6ecf2"}}}}