{"action":"created","comment":{"url":"https://api.github.com/repos/playframework/playframework/pulls/comments/40642026","id":40642026,"diff_hunk":"@@ -71,9 +74,21 @@ trait WsTestClient {\n       block(wrappedClient)\n     } finally {\n       client.close()\n+      materializer.shutdown()\n     }\n   }\n \n+  /**\n+   * The stream materializer used in the implementation of the `withClient` method to create a WS client.\n+   *\n+   * @note Overriding this method is possible, but be aware that a fresh instance of `ActorMaterializer`\n+   * must be returned each time, since upon calling `withClient` the actor materializer is automatically\n+   * shut down (together with the underlying `ActorSystem`).\n+   */\n+  protected def createMaterializer(): ActorMaterializer = {\n+    val name = \"ws-test-client\"\n+    ActorMaterializer(namePrefix = Some(name))(ActorSystem(name))","path":"framework/src/play-ws/src/main/scala/play/api/test/WSTestClient.scala","position":null,"original_position":36,"commit_id":"8f1df6ce62cc8e683af856a7cce19084bfac6e11","original_commit_id":"dbed859af65af874e1abafaff9572bb6973ce370","user":{"login":"dotta","id":703748,"avatar_url":"https://avatars.githubusercontent.com/u/703748?v=3","gravatar_id":"","url":"https://api.github.com/users/dotta","html_url":"https://github.com/dotta","followers_url":"https://api.github.com/users/dotta/followers","following_url":"https://api.github.com/users/dotta/following{/other_user}","gists_url":"https://api.github.com/users/dotta/gists{/gist_id}","starred_url":"https://api.github.com/users/dotta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotta/subscriptions","organizations_url":"https://api.github.com/users/dotta/orgs","repos_url":"https://api.github.com/users/dotta/repos","events_url":"https://api.github.com/users/dotta/events{/privacy}","received_events_url":"https://api.github.com/users/dotta/received_events","type":"User","site_admin":false},"body":"Of course you are right. I had a look at the implementation and somehow convinced myself that sending a `PoisonPill` was shutting down the actor system. Anyhow, it's fixed now, so this PR should be finally in shape.","created_at":"2015-09-29T07:36:39Z","updated_at":"2015-09-29T07:36:39Z","html_url":"https://github.com/playframework/playframework/pull/5122#discussion_r40642026","pull_request_url":"https://api.github.com/repos/playframework/playframework/pulls/5122","_links":{"self":{"href":"https://api.github.com/repos/playframework/playframework/pulls/comments/40642026"},"html":{"href":"https://github.com/playframework/playframework/pull/5122#discussion_r40642026"},"pull_request":{"href":"https://api.github.com/repos/playframework/playframework/pulls/5122"}}},"pull_request":{"url":"https://api.github.com/repos/playframework/playframework/pulls/5122","id":45762604,"html_url":"https://github.com/playframework/playframework/pull/5122","diff_url":"https://github.com/playframework/playframework/pull/5122.diff","patch_url":"https://github.com/playframework/playframework/pull/5122.patch","issue_url":"https://api.github.com/repos/playframework/playframework/issues/5122","number":5122,"state":"open","locked":false,"title":"Wip/ws request streaming","user":{"login":"dotta","id":703748,"avatar_url":"https://avatars.githubusercontent.com/u/703748?v=3","gravatar_id":"","url":"https://api.github.com/users/dotta","html_url":"https://github.com/dotta","followers_url":"https://api.github.com/users/dotta/followers","following_url":"https://api.github.com/users/dotta/following{/other_user}","gists_url":"https://api.github.com/users/dotta/gists{/gist_id}","starred_url":"https://api.github.com/users/dotta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotta/subscriptions","organizations_url":"https://api.github.com/users/dotta/orgs","repos_url":"https://api.github.com/users/dotta/repos","events_url":"https://api.github.com/users/dotta/events{/privacy}","received_events_url":"https://api.github.com/users/dotta/received_events","type":"User","site_admin":false},"body":"**This PR depends on #5082**\r\n\r\n* Bumped version of scala-java8-compat to 0.7.0 ( I thought this was done by @jroper already, but it doesn't look like it's the case) - a590932703aa045de07c5ef08fc31ba60b7864d5\r\n* Improved deprecation message for `Action.iteratee` - 2c4c79cb649f3acc2bcf99b838d8b14ce30e1c8c\r\n* Renamed StreamedRequest into Streamed - 231628da07303306a4ca4d1602c728572a72cd0b\r\n* Don't enumerate request body last chunk in akka-http server - 8597b238ce5c832a7863874562d267ac71f97cba\r\n* Implemented request body streaming for both Java/Scala. Fix #3351 - 1d96a4b2cc9239411a48e0fb2217e398f67780d4\r\n\r\nMissing:\r\n* Documentation for request body streaming","created_at":"2015-09-23T10:13:26Z","updated_at":"2015-09-29T07:36:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"32a4988f1f77830da4439352f6d0654e09ea225b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/playframework/playframework/pulls/5122/commits","review_comments_url":"https://api.github.com/repos/playframework/playframework/pulls/5122/comments","review_comment_url":"https://api.github.com/repos/playframework/playframework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/playframework/playframework/issues/5122/comments","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/8f1df6ce62cc8e683af856a7cce19084bfac6e11","head":{"label":"dotta:wip/ws-request-streaming","ref":"wip/ws-request-streaming","sha":"8f1df6ce62cc8e683af856a7cce19084bfac6e11","user":{"login":"dotta","id":703748,"avatar_url":"https://avatars.githubusercontent.com/u/703748?v=3","gravatar_id":"","url":"https://api.github.com/users/dotta","html_url":"https://github.com/dotta","followers_url":"https://api.github.com/users/dotta/followers","following_url":"https://api.github.com/users/dotta/following{/other_user}","gists_url":"https://api.github.com/users/dotta/gists{/gist_id}","starred_url":"https://api.github.com/users/dotta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotta/subscriptions","organizations_url":"https://api.github.com/users/dotta/orgs","repos_url":"https://api.github.com/users/dotta/repos","events_url":"https://api.github.com/users/dotta/events{/privacy}","received_events_url":"https://api.github.com/users/dotta/received_events","type":"User","site_admin":false},"repo":{"id":27679969,"name":"playframework","full_name":"dotta/playframework","owner":{"login":"dotta","id":703748,"avatar_url":"https://avatars.githubusercontent.com/u/703748?v=3","gravatar_id":"","url":"https://api.github.com/users/dotta","html_url":"https://github.com/dotta","followers_url":"https://api.github.com/users/dotta/followers","following_url":"https://api.github.com/users/dotta/following{/other_user}","gists_url":"https://api.github.com/users/dotta/gists{/gist_id}","starred_url":"https://api.github.com/users/dotta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotta/subscriptions","organizations_url":"https://api.github.com/users/dotta/orgs","repos_url":"https://api.github.com/users/dotta/repos","events_url":"https://api.github.com/users/dotta/events{/privacy}","received_events_url":"https://api.github.com/users/dotta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dotta/playframework","description":"Play Framework","fork":true,"url":"https://api.github.com/repos/dotta/playframework","forks_url":"https://api.github.com/repos/dotta/playframework/forks","keys_url":"https://api.github.com/repos/dotta/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotta/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotta/playframework/teams","hooks_url":"https://api.github.com/repos/dotta/playframework/hooks","issue_events_url":"https://api.github.com/repos/dotta/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/dotta/playframework/events","assignees_url":"https://api.github.com/repos/dotta/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/dotta/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/dotta/playframework/tags","blobs_url":"https://api.github.com/repos/dotta/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotta/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotta/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotta/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotta/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/dotta/playframework/languages","stargazers_url":"https://api.github.com/repos/dotta/playframework/stargazers","contributors_url":"https://api.github.com/repos/dotta/playframework/contributors","subscribers_url":"https://api.github.com/repos/dotta/playframework/subscribers","subscription_url":"https://api.github.com/repos/dotta/playframework/subscription","commits_url":"https://api.github.com/repos/dotta/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotta/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotta/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotta/playframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotta/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/dotta/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotta/playframework/merges","archive_url":"https://api.github.com/repos/dotta/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotta/playframework/downloads","issues_url":"https://api.github.com/repos/dotta/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/dotta/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/dotta/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/dotta/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotta/playframework/labels{/name}","releases_url":"https://api.github.com/repos/dotta/playframework/releases{/id}","created_at":"2014-12-07T18:26:54Z","updated_at":"2015-05-06T16:18:19Z","pushed_at":"2015-09-29T05:21:25Z","git_url":"git://github.com/dotta/playframework.git","ssh_url":"git@github.com:dotta/playframework.git","clone_url":"https://github.com/dotta/playframework.git","svn_url":"https://github.com/dotta/playframework","homepage":"http://www.playframework.com/","size":77197,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"playframework:master","ref":"master","sha":"2fe151c7eb82c0959bc642679ea86762f48fff02","user":{"login":"playframework","id":319107,"avatar_url":"https://avatars.githubusercontent.com/u/319107?v=3","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"repo":{"id":2340549,"name":"playframework","full_name":"playframework/playframework","owner":{"login":"playframework","id":319107,"avatar_url":"https://avatars.githubusercontent.com/u/319107?v=3","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/playframework/playframework","description":"Play Framework","fork":false,"url":"https://api.github.com/repos/playframework/playframework","forks_url":"https://api.github.com/repos/playframework/playframework/forks","keys_url":"https://api.github.com/repos/playframework/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/playframework/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/playframework/playframework/teams","hooks_url":"https://api.github.com/repos/playframework/playframework/hooks","issue_events_url":"https://api.github.com/repos/playframework/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/playframework/playframework/events","assignees_url":"https://api.github.com/repos/playframework/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/playframework/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/playframework/playframework/tags","blobs_url":"https://api.github.com/repos/playframework/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/playframework/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/playframework/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/playframework/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/playframework/playframework/languages","stargazers_url":"https://api.github.com/repos/playframework/playframework/stargazers","contributors_url":"https://api.github.com/repos/playframework/playframework/contributors","subscribers_url":"https://api.github.com/repos/playframework/playframework/subscribers","subscription_url":"https://api.github.com/repos/playframework/playframework/subscription","commits_url":"https://api.github.com/repos/playframework/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/playframework/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/playframework/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/playframework/playframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/playframework/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/playframework/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/playframework/playframework/merges","archive_url":"https://api.github.com/repos/playframework/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/playframework/playframework/downloads","issues_url":"https://api.github.com/repos/playframework/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/playframework/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/playframework/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/playframework/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/playframework/playframework/labels{/name}","releases_url":"https://api.github.com/repos/playframework/playframework/releases{/id}","created_at":"2011-09-07T09:24:08Z","updated_at":"2015-09-29T05:44:22Z","pushed_at":"2015-09-29T05:21:25Z","git_url":"git://github.com/playframework/playframework.git","ssh_url":"git@github.com:playframework/playframework.git","clone_url":"https://github.com/playframework/playframework.git","svn_url":"https://github.com/playframework/playframework","homepage":"http://www.playframework.com/","size":128706,"stargazers_count":6847,"watchers_count":6847,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2438,"mirror_url":null,"open_issues_count":278,"forks":2438,"open_issues":278,"watchers":6847,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/playframework/playframework/pulls/5122"},"html":{"href":"https://github.com/playframework/playframework/pull/5122"},"issue":{"href":"https://api.github.com/repos/playframework/playframework/issues/5122"},"comments":{"href":"https://api.github.com/repos/playframework/playframework/issues/5122/comments"},"review_comments":{"href":"https://api.github.com/repos/playframework/playframework/pulls/5122/comments"},"review_comment":{"href":"https://api.github.com/repos/playframework/playframework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/playframework/playframework/pulls/5122/commits"},"statuses":{"href":"https://api.github.com/repos/playframework/playframework/statuses/8f1df6ce62cc8e683af856a7cce19084bfac6e11"}}}}