{"action":"created","comment":{"url":"https://api.github.com/repos/refinery29/piston/pulls/comments/39992048","id":39992048,"diff_hunk":"@@ -92,6 +92,6 @@ public function validateResponse($response)\n             return $response;\n         }\n \n-        throw new \\Exception('Your request must return an instance of Response');\n+        throw new \\Exception('Your request must return an instance of Refinery29\\Piston\\Http\\JsonResponse');","path":"src/Router/PistonStrategy.php","position":16,"original_position":16,"commit_id":"a5c5fc50cd760e290d0dee915f7022cf560cb207","original_commit_id":"a5c5fc50cd760e290d0dee915f7022cf560cb207","user":{"login":"localheinz","id":605483,"avatar_url":"https://avatars.githubusercontent.com/u/605483?v=3","gravatar_id":"","url":"https://api.github.com/users/localheinz","html_url":"https://github.com/localheinz","followers_url":"https://api.github.com/users/localheinz/followers","following_url":"https://api.github.com/users/localheinz/following{/other_user}","gists_url":"https://api.github.com/users/localheinz/gists{/gist_id}","starred_url":"https://api.github.com/users/localheinz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/localheinz/subscriptions","organizations_url":"https://api.github.com/users/localheinz/orgs","repos_url":"https://api.github.com/users/localheinz/repos","events_url":"https://api.github.com/users/localheinz/events{/privacy}","received_events_url":"https://api.github.com/users/localheinz/received_events","type":"User","site_admin":false},"body":"@kayladnls \r\n\r\nNot sure, shouldn't this be `Refinery29\\Piston\\Http\\Response`?\r\n\r\nAlso, if we `sprintf()`, we gain the benefit of refactoring / finding usages / etc.\r\n\r\n```php\r\nthrow new \\Exception(sprintf(\r\n    'Your request must return an instance of %s',\r\n    Response::class\r\n));\r\n```\r\n\r\nWhat do you think?","created_at":"2015-09-21T16:28:41Z","updated_at":"2015-09-21T16:28:41Z","html_url":"https://github.com/refinery29/piston/pull/88#discussion_r39992048","pull_request_url":"https://api.github.com/repos/refinery29/piston/pulls/88","_links":{"self":{"href":"https://api.github.com/repos/refinery29/piston/pulls/comments/39992048"},"html":{"href":"https://github.com/refinery29/piston/pull/88#discussion_r39992048"},"pull_request":{"href":"https://api.github.com/repos/refinery29/piston/pulls/88"}}},"pull_request":{"url":"https://api.github.com/repos/refinery29/piston/pulls/88","id":45212190,"html_url":"https://github.com/refinery29/piston/pull/88","diff_url":"https://github.com/refinery29/piston/pull/88.diff","patch_url":"https://github.com/refinery29/piston/pull/88.patch","issue_url":"https://api.github.com/repos/refinery29/piston/issues/88","number":88,"state":"open","locked":false,"title":"Use api output","user":{"login":"kayladnls","id":1276798,"avatar_url":"https://avatars.githubusercontent.com/u/1276798?v=3","gravatar_id":"","url":"https://api.github.com/users/kayladnls","html_url":"https://github.com/kayladnls","followers_url":"https://api.github.com/users/kayladnls/followers","following_url":"https://api.github.com/users/kayladnls/following{/other_user}","gists_url":"https://api.github.com/users/kayladnls/gists{/gist_id}","starred_url":"https://api.github.com/users/kayladnls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kayladnls/subscriptions","organizations_url":"https://api.github.com/users/kayladnls/orgs","repos_url":"https://api.github.com/users/kayladnls/repos","events_url":"https://api.github.com/users/kayladnls/events{/privacy}","received_events_url":"https://api.github.com/users/kayladnls/received_events","type":"User","site_admin":false},"body":"This PR: \r\n\r\n- [x] Removes Response Pipeline and output stages in favor of `refinery29/api-output`\r\n- [x] Renames JsonResponse to Response and injects, rather than extends `Symfony/Http/Response`\r\n- [x] Makes use of `refinery29/api-output`\r\n- [x] pulls in `refinery29/php-cs-fixer-config` from packagist, rather than vcs repo link. ","created_at":"2015-09-16T19:13:01Z","updated_at":"2015-09-21T16:28:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce866328464443674e133cfc8a3ad8d83c6d6aaa","assignee":{"login":"localheinz","id":605483,"avatar_url":"https://avatars.githubusercontent.com/u/605483?v=3","gravatar_id":"","url":"https://api.github.com/users/localheinz","html_url":"https://github.com/localheinz","followers_url":"https://api.github.com/users/localheinz/followers","following_url":"https://api.github.com/users/localheinz/following{/other_user}","gists_url":"https://api.github.com/users/localheinz/gists{/gist_id}","starred_url":"https://api.github.com/users/localheinz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/localheinz/subscriptions","organizations_url":"https://api.github.com/users/localheinz/orgs","repos_url":"https://api.github.com/users/localheinz/repos","events_url":"https://api.github.com/users/localheinz/events{/privacy}","received_events_url":"https://api.github.com/users/localheinz/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/refinery29/piston/pulls/88/commits","review_comments_url":"https://api.github.com/repos/refinery29/piston/pulls/88/comments","review_comment_url":"https://api.github.com/repos/refinery29/piston/pulls/comments{/number}","comments_url":"https://api.github.com/repos/refinery29/piston/issues/88/comments","statuses_url":"https://api.github.com/repos/refinery29/piston/statuses/a5c5fc50cd760e290d0dee915f7022cf560cb207","head":{"label":"refinery29:useApiOutput","ref":"useApiOutput","sha":"a5c5fc50cd760e290d0dee915f7022cf560cb207","user":{"login":"refinery29","id":821624,"avatar_url":"https://avatars.githubusercontent.com/u/821624?v=3","gravatar_id":"","url":"https://api.github.com/users/refinery29","html_url":"https://github.com/refinery29","followers_url":"https://api.github.com/users/refinery29/followers","following_url":"https://api.github.com/users/refinery29/following{/other_user}","gists_url":"https://api.github.com/users/refinery29/gists{/gist_id}","starred_url":"https://api.github.com/users/refinery29/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refinery29/subscriptions","organizations_url":"https://api.github.com/users/refinery29/orgs","repos_url":"https://api.github.com/users/refinery29/repos","events_url":"https://api.github.com/users/refinery29/events{/privacy}","received_events_url":"https://api.github.com/users/refinery29/received_events","type":"Organization","site_admin":false},"repo":{"id":36875607,"name":"piston","full_name":"refinery29/piston","owner":{"login":"refinery29","id":821624,"avatar_url":"https://avatars.githubusercontent.com/u/821624?v=3","gravatar_id":"","url":"https://api.github.com/users/refinery29","html_url":"https://github.com/refinery29","followers_url":"https://api.github.com/users/refinery29/followers","following_url":"https://api.github.com/users/refinery29/following{/other_user}","gists_url":"https://api.github.com/users/refinery29/gists{/gist_id}","starred_url":"https://api.github.com/users/refinery29/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refinery29/subscriptions","organizations_url":"https://api.github.com/users/refinery29/orgs","repos_url":"https://api.github.com/users/refinery29/repos","events_url":"https://api.github.com/users/refinery29/events{/privacy}","received_events_url":"https://api.github.com/users/refinery29/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/refinery29/piston","description":":blue_car: Opinionated Micro Framework for APIs","fork":false,"url":"https://api.github.com/repos/refinery29/piston","forks_url":"https://api.github.com/repos/refinery29/piston/forks","keys_url":"https://api.github.com/repos/refinery29/piston/keys{/key_id}","collaborators_url":"https://api.github.com/repos/refinery29/piston/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/refinery29/piston/teams","hooks_url":"https://api.github.com/repos/refinery29/piston/hooks","issue_events_url":"https://api.github.com/repos/refinery29/piston/issues/events{/number}","events_url":"https://api.github.com/repos/refinery29/piston/events","assignees_url":"https://api.github.com/repos/refinery29/piston/assignees{/user}","branches_url":"https://api.github.com/repos/refinery29/piston/branches{/branch}","tags_url":"https://api.github.com/repos/refinery29/piston/tags","blobs_url":"https://api.github.com/repos/refinery29/piston/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/refinery29/piston/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/refinery29/piston/git/refs{/sha}","trees_url":"https://api.github.com/repos/refinery29/piston/git/trees{/sha}","statuses_url":"https://api.github.com/repos/refinery29/piston/statuses/{sha}","languages_url":"https://api.github.com/repos/refinery29/piston/languages","stargazers_url":"https://api.github.com/repos/refinery29/piston/stargazers","contributors_url":"https://api.github.com/repos/refinery29/piston/contributors","subscribers_url":"https://api.github.com/repos/refinery29/piston/subscribers","subscription_url":"https://api.github.com/repos/refinery29/piston/subscription","commits_url":"https://api.github.com/repos/refinery29/piston/commits{/sha}","git_commits_url":"https://api.github.com/repos/refinery29/piston/git/commits{/sha}","comments_url":"https://api.github.com/repos/refinery29/piston/comments{/number}","issue_comment_url":"https://api.github.com/repos/refinery29/piston/issues/comments{/number}","contents_url":"https://api.github.com/repos/refinery29/piston/contents/{+path}","compare_url":"https://api.github.com/repos/refinery29/piston/compare/{base}...{head}","merges_url":"https://api.github.com/repos/refinery29/piston/merges","archive_url":"https://api.github.com/repos/refinery29/piston/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/refinery29/piston/downloads","issues_url":"https://api.github.com/repos/refinery29/piston/issues{/number}","pulls_url":"https://api.github.com/repos/refinery29/piston/pulls{/number}","milestones_url":"https://api.github.com/repos/refinery29/piston/milestones{/number}","notifications_url":"https://api.github.com/repos/refinery29/piston/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/refinery29/piston/labels{/name}","releases_url":"https://api.github.com/repos/refinery29/piston/releases{/id}","created_at":"2015-06-04T14:33:58Z","updated_at":"2015-09-10T20:59:48Z","pushed_at":"2015-09-21T16:17:55Z","git_url":"git://github.com/refinery29/piston.git","ssh_url":"git@github.com:refinery29/piston.git","clone_url":"https://github.com/refinery29/piston.git","svn_url":"https://github.com/refinery29/piston","homepage":"","size":1072,"stargazers_count":11,"watchers_count":11,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":11,"default_branch":"master"}},"base":{"label":"refinery29:master","ref":"master","sha":"e2be1e50bcb89b92ee038786e7dfbb678c2441ff","user":{"login":"refinery29","id":821624,"avatar_url":"https://avatars.githubusercontent.com/u/821624?v=3","gravatar_id":"","url":"https://api.github.com/users/refinery29","html_url":"https://github.com/refinery29","followers_url":"https://api.github.com/users/refinery29/followers","following_url":"https://api.github.com/users/refinery29/following{/other_user}","gists_url":"https://api.github.com/users/refinery29/gists{/gist_id}","starred_url":"https://api.github.com/users/refinery29/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refinery29/subscriptions","organizations_url":"https://api.github.com/users/refinery29/orgs","repos_url":"https://api.github.com/users/refinery29/repos","events_url":"https://api.github.com/users/refinery29/events{/privacy}","received_events_url":"https://api.github.com/users/refinery29/received_events","type":"Organization","site_admin":false},"repo":{"id":36875607,"name":"piston","full_name":"refinery29/piston","owner":{"login":"refinery29","id":821624,"avatar_url":"https://avatars.githubusercontent.com/u/821624?v=3","gravatar_id":"","url":"https://api.github.com/users/refinery29","html_url":"https://github.com/refinery29","followers_url":"https://api.github.com/users/refinery29/followers","following_url":"https://api.github.com/users/refinery29/following{/other_user}","gists_url":"https://api.github.com/users/refinery29/gists{/gist_id}","starred_url":"https://api.github.com/users/refinery29/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refinery29/subscriptions","organizations_url":"https://api.github.com/users/refinery29/orgs","repos_url":"https://api.github.com/users/refinery29/repos","events_url":"https://api.github.com/users/refinery29/events{/privacy}","received_events_url":"https://api.github.com/users/refinery29/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/refinery29/piston","description":":blue_car: Opinionated Micro Framework for APIs","fork":false,"url":"https://api.github.com/repos/refinery29/piston","forks_url":"https://api.github.com/repos/refinery29/piston/forks","keys_url":"https://api.github.com/repos/refinery29/piston/keys{/key_id}","collaborators_url":"https://api.github.com/repos/refinery29/piston/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/refinery29/piston/teams","hooks_url":"https://api.github.com/repos/refinery29/piston/hooks","issue_events_url":"https://api.github.com/repos/refinery29/piston/issues/events{/number}","events_url":"https://api.github.com/repos/refinery29/piston/events","assignees_url":"https://api.github.com/repos/refinery29/piston/assignees{/user}","branches_url":"https://api.github.com/repos/refinery29/piston/branches{/branch}","tags_url":"https://api.github.com/repos/refinery29/piston/tags","blobs_url":"https://api.github.com/repos/refinery29/piston/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/refinery29/piston/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/refinery29/piston/git/refs{/sha}","trees_url":"https://api.github.com/repos/refinery29/piston/git/trees{/sha}","statuses_url":"https://api.github.com/repos/refinery29/piston/statuses/{sha}","languages_url":"https://api.github.com/repos/refinery29/piston/languages","stargazers_url":"https://api.github.com/repos/refinery29/piston/stargazers","contributors_url":"https://api.github.com/repos/refinery29/piston/contributors","subscribers_url":"https://api.github.com/repos/refinery29/piston/subscribers","subscription_url":"https://api.github.com/repos/refinery29/piston/subscription","commits_url":"https://api.github.com/repos/refinery29/piston/commits{/sha}","git_commits_url":"https://api.github.com/repos/refinery29/piston/git/commits{/sha}","comments_url":"https://api.github.com/repos/refinery29/piston/comments{/number}","issue_comment_url":"https://api.github.com/repos/refinery29/piston/issues/comments{/number}","contents_url":"https://api.github.com/repos/refinery29/piston/contents/{+path}","compare_url":"https://api.github.com/repos/refinery29/piston/compare/{base}...{head}","merges_url":"https://api.github.com/repos/refinery29/piston/merges","archive_url":"https://api.github.com/repos/refinery29/piston/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/refinery29/piston/downloads","issues_url":"https://api.github.com/repos/refinery29/piston/issues{/number}","pulls_url":"https://api.github.com/repos/refinery29/piston/pulls{/number}","milestones_url":"https://api.github.com/repos/refinery29/piston/milestones{/number}","notifications_url":"https://api.github.com/repos/refinery29/piston/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/refinery29/piston/labels{/name}","releases_url":"https://api.github.com/repos/refinery29/piston/releases{/id}","created_at":"2015-06-04T14:33:58Z","updated_at":"2015-09-10T20:59:48Z","pushed_at":"2015-09-21T16:17:55Z","git_url":"git://github.com/refinery29/piston.git","ssh_url":"git@github.com:refinery29/piston.git","clone_url":"https://github.com/refinery29/piston.git","svn_url":"https://github.com/refinery29/piston","homepage":"","size":1072,"stargazers_count":11,"watchers_count":11,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/refinery29/piston/pulls/88"},"html":{"href":"https://github.com/refinery29/piston/pull/88"},"issue":{"href":"https://api.github.com/repos/refinery29/piston/issues/88"},"comments":{"href":"https://api.github.com/repos/refinery29/piston/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/refinery29/piston/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/refinery29/piston/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/refinery29/piston/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/refinery29/piston/statuses/a5c5fc50cd760e290d0dee915f7022cf560cb207"}}}}