{"action":"closed","number":43,"pull_request":{"url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/pulls/43","id":42770903,"html_url":"https://github.com/python-xmp-toolkit/python-xmp-toolkit/pull/43","diff_url":"https://github.com/python-xmp-toolkit/python-xmp-toolkit/pull/43.diff","patch_url":"https://github.com/python-xmp-toolkit/python-xmp-toolkit/pull/43.patch","issue_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/issues/43","number":43,"state":"closed","locked":false,"title":"Use escaped ASCII for unicode filename on python2","user":{"login":"quintusdias","id":2761822,"avatar_url":"https://avatars.githubusercontent.com/u/2761822?v=3","gravatar_id":"","url":"https://api.github.com/users/quintusdias","html_url":"https://github.com/quintusdias","followers_url":"https://api.github.com/users/quintusdias/followers","following_url":"https://api.github.com/users/quintusdias/following{/other_user}","gists_url":"https://api.github.com/users/quintusdias/gists{/gist_id}","starred_url":"https://api.github.com/users/quintusdias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quintusdias/subscriptions","organizations_url":"https://api.github.com/users/quintusdias/orgs","repos_url":"https://api.github.com/users/quintusdias/repos","events_url":"https://api.github.com/users/quintusdias/events{/privacy}","received_events_url":"https://api.github.com/users/quintusdias/received_events","type":"User","site_admin":false},"body":"__repr__ with unicode is problematic in python2.\r\n\r\nInterpolating a unicode filename into an ASCII string as previously\r\ndone  resulted in a UnicodeEncodeError.  We cannot interpolate a\r\nunicode filename into a unicode string as the __repr__ function\r\nmust return a byte string in python2.  Since __repr__ does not\r\nabsolutely have to return a byte string that can always be used to\r\nrecreate the object, we just use REPR on the unicode filename under\r\npython2, which results in escaped ASCII.\r\n\r\nWe cannot simply use repr(filename) for all cases, since it does change\r\nthe output in python3, changes something that isn't broken, and breaks\r\ntwo existing tests anyway.\r\n\r\nIn python3 the issue doesn't arise since __repr__ and __str__ return\r\nunicode instead of byte strings.\r\n\r\nCloses-Issue:  #36","created_at":"2015-08-19T02:28:37Z","updated_at":"2015-08-27T00:24:02Z","closed_at":"2015-08-27T00:24:02Z","merged_at":"2015-08-27T00:24:02Z","merge_commit_sha":"a62de283da8fcce13f5abc8d920bf83e1ab59127","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/pulls/43/commits","review_comments_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/pulls/43/comments","review_comment_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/issues/43/comments","statuses_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/statuses/ff0306f22bc20d67a04164c030b613e17b6591e2","head":{"label":"quintusdias:issue36v2","ref":"issue36v2","sha":"ff0306f22bc20d67a04164c030b613e17b6591e2","user":{"login":"quintusdias","id":2761822,"avatar_url":"https://avatars.githubusercontent.com/u/2761822?v=3","gravatar_id":"","url":"https://api.github.com/users/quintusdias","html_url":"https://github.com/quintusdias","followers_url":"https://api.github.com/users/quintusdias/followers","following_url":"https://api.github.com/users/quintusdias/following{/other_user}","gists_url":"https://api.github.com/users/quintusdias/gists{/gist_id}","starred_url":"https://api.github.com/users/quintusdias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quintusdias/subscriptions","organizations_url":"https://api.github.com/users/quintusdias/orgs","repos_url":"https://api.github.com/users/quintusdias/repos","events_url":"https://api.github.com/users/quintusdias/events{/privacy}","received_events_url":"https://api.github.com/users/quintusdias/received_events","type":"User","site_admin":false},"repo":{"id":13416153,"name":"python-xmp-toolkit","full_name":"quintusdias/python-xmp-toolkit","owner":{"login":"quintusdias","id":2761822,"avatar_url":"https://avatars.githubusercontent.com/u/2761822?v=3","gravatar_id":"","url":"https://api.github.com/users/quintusdias","html_url":"https://github.com/quintusdias","followers_url":"https://api.github.com/users/quintusdias/followers","following_url":"https://api.github.com/users/quintusdias/following{/other_user}","gists_url":"https://api.github.com/users/quintusdias/gists{/gist_id}","starred_url":"https://api.github.com/users/quintusdias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quintusdias/subscriptions","organizations_url":"https://api.github.com/users/quintusdias/orgs","repos_url":"https://api.github.com/users/quintusdias/repos","events_url":"https://api.github.com/users/quintusdias/events{/privacy}","received_events_url":"https://api.github.com/users/quintusdias/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/quintusdias/python-xmp-toolkit","description":"Python XMP Toolkit","fork":true,"url":"https://api.github.com/repos/quintusdias/python-xmp-toolkit","forks_url":"https://api.github.com/repos/quintusdias/python-xmp-toolkit/forks","keys_url":"https://api.github.com/repos/quintusdias/python-xmp-toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quintusdias/python-xmp-toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quintusdias/python-xmp-toolkit/teams","hooks_url":"https://api.github.com/repos/quintusdias/python-xmp-toolkit/hooks","issue_events_url":"https://api.github.com/repos/quintusdias/python-xmp-toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/quintusdias/python-xmp-toolkit/events","assignees_url":"https://api.github.com/repos/quintusdias/python-xmp-toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/quintusdias/python-xmp-toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/quintusdias/python-xmp-toolkit/tags","blobs_url":"https://api.github.com/repos/quintusdias/python-xmp-toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quintusdias/python-xmp-toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quintusdias/python-xmp-toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/quintusdias/python-xmp-toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quintusdias/python-xmp-toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/quintusdias/python-xmp-toolkit/languages","stargazers_url":"https://api.github.com/repos/quintusdias/python-xmp-toolkit/stargazers","contributors_url":"https://api.github.com/repos/quintusdias/python-xmp-toolkit/contributors","subscribers_url":"https://api.github.com/repos/quintusdias/python-xmp-toolkit/subscribers","subscription_url":"https://api.github.com/repos/quintusdias/python-xmp-toolkit/subscription","commits_url":"https://api.github.com/repos/quintusdias/python-xmp-toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/quintusdias/python-xmp-toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/quintusdias/python-xmp-toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/quintusdias/python-xmp-toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/quintusdias/python-xmp-toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/quintusdias/python-xmp-toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quintusdias/python-xmp-toolkit/merges","archive_url":"https://api.github.com/repos/quintusdias/python-xmp-toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quintusdias/python-xmp-toolkit/downloads","issues_url":"https://api.github.com/repos/quintusdias/python-xmp-toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/quintusdias/python-xmp-toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/quintusdias/python-xmp-toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/quintusdias/python-xmp-toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quintusdias/python-xmp-toolkit/labels{/name}","releases_url":"https://api.github.com/repos/quintusdias/python-xmp-toolkit/releases{/id}","created_at":"2013-10-08T14:42:09Z","updated_at":"2015-08-13T10:53:24Z","pushed_at":"2015-08-19T02:27:15Z","git_url":"git://github.com/quintusdias/python-xmp-toolkit.git","ssh_url":"git@github.com:quintusdias/python-xmp-toolkit.git","clone_url":"https://github.com/quintusdias/python-xmp-toolkit.git","svn_url":"https://github.com/quintusdias/python-xmp-toolkit","homepage":null,"size":3864,"stargazers_count":0,"watchers_count":0,"language":"PostScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"python-xmp-toolkit:master","ref":"master","sha":"82dd2a848fc0255a299aa6af7614f2939e4b2d60","user":{"login":"python-xmp-toolkit","id":5638728,"avatar_url":"https://avatars.githubusercontent.com/u/5638728?v=3","gravatar_id":"","url":"https://api.github.com/users/python-xmp-toolkit","html_url":"https://github.com/python-xmp-toolkit","followers_url":"https://api.github.com/users/python-xmp-toolkit/followers","following_url":"https://api.github.com/users/python-xmp-toolkit/following{/other_user}","gists_url":"https://api.github.com/users/python-xmp-toolkit/gists{/gist_id}","starred_url":"https://api.github.com/users/python-xmp-toolkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-xmp-toolkit/subscriptions","organizations_url":"https://api.github.com/users/python-xmp-toolkit/orgs","repos_url":"https://api.github.com/users/python-xmp-toolkit/repos","events_url":"https://api.github.com/users/python-xmp-toolkit/events{/privacy}","received_events_url":"https://api.github.com/users/python-xmp-toolkit/received_events","type":"Organization","site_admin":false},"repo":{"id":13415322,"name":"python-xmp-toolkit","full_name":"python-xmp-toolkit/python-xmp-toolkit","owner":{"login":"python-xmp-toolkit","id":5638728,"avatar_url":"https://avatars.githubusercontent.com/u/5638728?v=3","gravatar_id":"","url":"https://api.github.com/users/python-xmp-toolkit","html_url":"https://github.com/python-xmp-toolkit","followers_url":"https://api.github.com/users/python-xmp-toolkit/followers","following_url":"https://api.github.com/users/python-xmp-toolkit/following{/other_user}","gists_url":"https://api.github.com/users/python-xmp-toolkit/gists{/gist_id}","starred_url":"https://api.github.com/users/python-xmp-toolkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-xmp-toolkit/subscriptions","organizations_url":"https://api.github.com/users/python-xmp-toolkit/orgs","repos_url":"https://api.github.com/users/python-xmp-toolkit/repos","events_url":"https://api.github.com/users/python-xmp-toolkit/events{/privacy}","received_events_url":"https://api.github.com/users/python-xmp-toolkit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/python-xmp-toolkit/python-xmp-toolkit","description":"Python XMP Toolkit","fork":false,"url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit","forks_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/forks","keys_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/teams","hooks_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/hooks","issue_events_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/events","assignees_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/tags","blobs_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/languages","stargazers_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/stargazers","contributors_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/contributors","subscribers_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/subscribers","subscription_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/subscription","commits_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/merges","archive_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/downloads","issues_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/labels{/name}","releases_url":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/releases{/id}","created_at":"2013-10-08T14:12:50Z","updated_at":"2015-08-18T00:12:16Z","pushed_at":"2015-08-27T00:24:02Z","git_url":"git://github.com/python-xmp-toolkit/python-xmp-toolkit.git","ssh_url":"git@github.com:python-xmp-toolkit/python-xmp-toolkit.git","clone_url":"https://github.com/python-xmp-toolkit/python-xmp-toolkit.git","svn_url":"https://github.com/python-xmp-toolkit/python-xmp-toolkit","homepage":"http://python-xmp-toolkit.readthedocs.org/","size":4159,"stargazers_count":15,"watchers_count":15,"language":"PostScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":6,"forks":8,"open_issues":6,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/pulls/43"},"html":{"href":"https://github.com/python-xmp-toolkit/python-xmp-toolkit/pull/43"},"issue":{"href":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/issues/43"},"comments":{"href":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/python-xmp-toolkit/python-xmp-toolkit/statuses/ff0306f22bc20d67a04164c030b613e17b6591e2"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"quintusdias","id":2761822,"avatar_url":"https://avatars.githubusercontent.com/u/2761822?v=3","gravatar_id":"","url":"https://api.github.com/users/quintusdias","html_url":"https://github.com/quintusdias","followers_url":"https://api.github.com/users/quintusdias/followers","following_url":"https://api.github.com/users/quintusdias/following{/other_user}","gists_url":"https://api.github.com/users/quintusdias/gists{/gist_id}","starred_url":"https://api.github.com/users/quintusdias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quintusdias/subscriptions","organizations_url":"https://api.github.com/users/quintusdias/orgs","repos_url":"https://api.github.com/users/quintusdias/repos","events_url":"https://api.github.com/users/quintusdias/events{/privacy}","received_events_url":"https://api.github.com/users/quintusdias/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":53,"deletions":6,"changed_files":2}}