{"action":"created","comment":{"url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/pulls/comments/32931210","id":32931210,"diff_hunk":"@@ -224,12 +224,13 @@ QString NemoCalendarManager::getNotebookColor(const QString &notebookUid) const\n \n void NemoCalendarManager::cancelAgendaRefresh(NemoCalendarAgendaModel *model)\n {\n-    mAgendaRefreshList.removeOne(model);\n+    if (!mAgendaRefreshList.isEmpty())\n+        mAgendaRefreshList.removeOne(model);","path":"src/calendarmanager.cpp","position":6,"original_position":6,"commit_id":"6c637e06ed13b9b5253fa3edcd0bcb04845b228a","original_commit_id":"6c637e06ed13b9b5253fa3edcd0bcb04845b228a","user":{"login":"pgerdt","id":2118674,"avatar_url":"https://avatars.githubusercontent.com/u/2118674?v=3","gravatar_id":"","url":"https://api.github.com/users/pgerdt","html_url":"https://github.com/pgerdt","followers_url":"https://api.github.com/users/pgerdt/followers","following_url":"https://api.github.com/users/pgerdt/following{/other_user}","gists_url":"https://api.github.com/users/pgerdt/gists{/gist_id}","starred_url":"https://api.github.com/users/pgerdt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgerdt/subscriptions","organizations_url":"https://api.github.com/users/pgerdt/orgs","repos_url":"https://api.github.com/users/pgerdt/repos","events_url":"https://api.github.com/users/pgerdt/events{/privacy}","received_events_url":"https://api.github.com/users/pgerdt/received_events","type":"User","site_admin":false},"body":"Well, the QList documentation says that isEmpty should be checked before calling member functions, see last paragraph of this section: http://doc.qt.io/qt-5/qlist.html#details","created_at":"2015-06-22T13:03:04Z","updated_at":"2015-06-22T13:03:04Z","html_url":"https://github.com/nemomobile/nemo-qml-plugin-calendar/pull/55#discussion_r32931210","pull_request_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/pulls/55","_links":{"self":{"href":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/pulls/comments/32931210"},"html":{"href":"https://github.com/nemomobile/nemo-qml-plugin-calendar/pull/55#discussion_r32931210"},"pull_request":{"href":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/pulls/55"}}},"pull_request":{"url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/pulls/55","id":38224164,"html_url":"https://github.com/nemomobile/nemo-qml-plugin-calendar/pull/55","diff_url":"https://github.com/nemomobile/nemo-qml-plugin-calendar/pull/55.diff","patch_url":"https://github.com/nemomobile/nemo-qml-plugin-calendar/pull/55.patch","issue_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/issues/55","number":55,"state":"open","locked":false,"title":"Improve calendardataservice teardown, add QList guards for robustness","user":{"login":"pgerdt","id":2118674,"avatar_url":"https://avatars.githubusercontent.com/u/2118674?v=3","gravatar_id":"","url":"https://api.github.com/users/pgerdt","html_url":"https://github.com/pgerdt","followers_url":"https://api.github.com/users/pgerdt/followers","following_url":"https://api.github.com/users/pgerdt/following{/other_user}","gists_url":"https://api.github.com/users/pgerdt/gists{/gist_id}","starred_url":"https://api.github.com/users/pgerdt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgerdt/subscriptions","organizations_url":"https://api.github.com/users/pgerdt/orgs","repos_url":"https://api.github.com/users/pgerdt/repos","events_url":"https://api.github.com/users/pgerdt/events{/privacy}","received_events_url":"https://api.github.com/users/pgerdt/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-06-22T11:56:48Z","updated_at":"2015-06-22T13:03:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e0526842232330732751ae39447436d3cd14e0a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/pulls/55/commits","review_comments_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/pulls/55/comments","review_comment_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/issues/55/comments","statuses_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/statuses/6c637e06ed13b9b5253fa3edcd0bcb04845b228a","head":{"label":"pgerdt:prevent-crash","ref":"prevent-crash","sha":"6c637e06ed13b9b5253fa3edcd0bcb04845b228a","user":{"login":"pgerdt","id":2118674,"avatar_url":"https://avatars.githubusercontent.com/u/2118674?v=3","gravatar_id":"","url":"https://api.github.com/users/pgerdt","html_url":"https://github.com/pgerdt","followers_url":"https://api.github.com/users/pgerdt/followers","following_url":"https://api.github.com/users/pgerdt/following{/other_user}","gists_url":"https://api.github.com/users/pgerdt/gists{/gist_id}","starred_url":"https://api.github.com/users/pgerdt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgerdt/subscriptions","organizations_url":"https://api.github.com/users/pgerdt/orgs","repos_url":"https://api.github.com/users/pgerdt/repos","events_url":"https://api.github.com/users/pgerdt/events{/privacy}","received_events_url":"https://api.github.com/users/pgerdt/received_events","type":"User","site_admin":false},"repo":{"id":14550636,"name":"nemo-qml-plugin-calendar","full_name":"pgerdt/nemo-qml-plugin-calendar","owner":{"login":"pgerdt","id":2118674,"avatar_url":"https://avatars.githubusercontent.com/u/2118674?v=3","gravatar_id":"","url":"https://api.github.com/users/pgerdt","html_url":"https://github.com/pgerdt","followers_url":"https://api.github.com/users/pgerdt/followers","following_url":"https://api.github.com/users/pgerdt/following{/other_user}","gists_url":"https://api.github.com/users/pgerdt/gists{/gist_id}","starred_url":"https://api.github.com/users/pgerdt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgerdt/subscriptions","organizations_url":"https://api.github.com/users/pgerdt/orgs","repos_url":"https://api.github.com/users/pgerdt/repos","events_url":"https://api.github.com/users/pgerdt/events{/privacy}","received_events_url":"https://api.github.com/users/pgerdt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pgerdt/nemo-qml-plugin-calendar","description":"Calendar plugin for Nemo Mobile.","fork":true,"url":"https://api.github.com/repos/pgerdt/nemo-qml-plugin-calendar","forks_url":"https://api.github.com/repos/pgerdt/nemo-qml-plugin-calendar/forks","keys_url":"https://api.github.com/repos/pgerdt/nemo-qml-plugin-calendar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pgerdt/nemo-qml-plugin-calendar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pgerdt/nemo-qml-plugin-calendar/teams","hooks_url":"https://api.github.com/repos/pgerdt/nemo-qml-plugin-calendar/hooks","issue_events_url":"https://api.github.com/repos/pgerdt/nemo-qml-plugin-calendar/issues/events{/number}","events_url":"https://api.github.com/repos/pgerdt/nemo-qml-plugin-calendar/events","assignees_url":"https://api.github.com/repos/pgerdt/nemo-qml-plugin-calendar/assignees{/user}","branches_url":"https://api.github.com/repos/pgerdt/nemo-qml-plugin-calendar/branches{/branch}","tags_url":"https://api.github.com/repos/pgerdt/nemo-qml-plugin-calendar/tags","blobs_url":"https://api.github.com/repos/pgerdt/nemo-qml-plugin-calendar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pgerdt/nemo-qml-plugin-calendar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pgerdt/nemo-qml-plugin-calendar/git/refs{/sha}","trees_url":"https://api.github.com/repos/pgerdt/nemo-qml-plugin-calendar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pgerdt/nemo-qml-plugin-calendar/statuses/{sha}","languages_url":"https://api.github.com/repos/pgerdt/nemo-qml-plugin-calendar/languages","stargazers_url":"https://api.github.com/repos/pgerdt/nemo-qml-plugin-calendar/stargazers","contributors_url":"https://api.github.com/repos/pgerdt/nemo-qml-plugin-calendar/contributors","subscribers_url":"https://api.github.com/repos/pgerdt/nemo-qml-plugin-calendar/subscribers","subscription_url":"https://api.github.com/repos/pgerdt/nemo-qml-plugin-calendar/subscription","commits_url":"https://api.github.com/repos/pgerdt/nemo-qml-plugin-calendar/commits{/sha}","git_commits_url":"https://api.github.com/repos/pgerdt/nemo-qml-plugin-calendar/git/commits{/sha}","comments_url":"https://api.github.com/repos/pgerdt/nemo-qml-plugin-calendar/comments{/number}","issue_comment_url":"https://api.github.com/repos/pgerdt/nemo-qml-plugin-calendar/issues/comments{/number}","contents_url":"https://api.github.com/repos/pgerdt/nemo-qml-plugin-calendar/contents/{+path}","compare_url":"https://api.github.com/repos/pgerdt/nemo-qml-plugin-calendar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pgerdt/nemo-qml-plugin-calendar/merges","archive_url":"https://api.github.com/repos/pgerdt/nemo-qml-plugin-calendar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pgerdt/nemo-qml-plugin-calendar/downloads","issues_url":"https://api.github.com/repos/pgerdt/nemo-qml-plugin-calendar/issues{/number}","pulls_url":"https://api.github.com/repos/pgerdt/nemo-qml-plugin-calendar/pulls{/number}","milestones_url":"https://api.github.com/repos/pgerdt/nemo-qml-plugin-calendar/milestones{/number}","notifications_url":"https://api.github.com/repos/pgerdt/nemo-qml-plugin-calendar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pgerdt/nemo-qml-plugin-calendar/labels{/name}","releases_url":"https://api.github.com/repos/pgerdt/nemo-qml-plugin-calendar/releases{/id}","created_at":"2013-11-20T08:19:06Z","updated_at":"2014-06-02T13:22:16Z","pushed_at":"2015-06-22T11:55:51Z","git_url":"git://github.com/pgerdt/nemo-qml-plugin-calendar.git","ssh_url":"git@github.com:pgerdt/nemo-qml-plugin-calendar.git","clone_url":"https://github.com/pgerdt/nemo-qml-plugin-calendar.git","svn_url":"https://github.com/pgerdt/nemo-qml-plugin-calendar","homepage":null,"size":625,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nemomobile:master","ref":"master","sha":"5e689ad5112951fa02ad49112e23395c25a895d7","user":{"login":"nemomobile","id":1088947,"avatar_url":"https://avatars.githubusercontent.com/u/1088947?v=3","gravatar_id":"","url":"https://api.github.com/users/nemomobile","html_url":"https://github.com/nemomobile","followers_url":"https://api.github.com/users/nemomobile/followers","following_url":"https://api.github.com/users/nemomobile/following{/other_user}","gists_url":"https://api.github.com/users/nemomobile/gists{/gist_id}","starred_url":"https://api.github.com/users/nemomobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nemomobile/subscriptions","organizations_url":"https://api.github.com/users/nemomobile/orgs","repos_url":"https://api.github.com/users/nemomobile/repos","events_url":"https://api.github.com/users/nemomobile/events{/privacy}","received_events_url":"https://api.github.com/users/nemomobile/received_events","type":"Organization","site_admin":false},"repo":{"id":9445424,"name":"nemo-qml-plugin-calendar","full_name":"nemomobile/nemo-qml-plugin-calendar","owner":{"login":"nemomobile","id":1088947,"avatar_url":"https://avatars.githubusercontent.com/u/1088947?v=3","gravatar_id":"","url":"https://api.github.com/users/nemomobile","html_url":"https://github.com/nemomobile","followers_url":"https://api.github.com/users/nemomobile/followers","following_url":"https://api.github.com/users/nemomobile/following{/other_user}","gists_url":"https://api.github.com/users/nemomobile/gists{/gist_id}","starred_url":"https://api.github.com/users/nemomobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nemomobile/subscriptions","organizations_url":"https://api.github.com/users/nemomobile/orgs","repos_url":"https://api.github.com/users/nemomobile/repos","events_url":"https://api.github.com/users/nemomobile/events{/privacy}","received_events_url":"https://api.github.com/users/nemomobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nemomobile/nemo-qml-plugin-calendar","description":"Calendar plugin for Nemo Mobile.","fork":false,"url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar","forks_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/forks","keys_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/teams","hooks_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/hooks","issue_events_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/issues/events{/number}","events_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/events","assignees_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/assignees{/user}","branches_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/branches{/branch}","tags_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/tags","blobs_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/git/refs{/sha}","trees_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/statuses/{sha}","languages_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/languages","stargazers_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/stargazers","contributors_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/contributors","subscribers_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/subscribers","subscription_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/subscription","commits_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/commits{/sha}","git_commits_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/git/commits{/sha}","comments_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/comments{/number}","issue_comment_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/issues/comments{/number}","contents_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/contents/{+path}","compare_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/merges","archive_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/downloads","issues_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/issues{/number}","pulls_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/pulls{/number}","milestones_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/milestones{/number}","notifications_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/labels{/name}","releases_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/releases{/id}","created_at":"2013-04-15T09:40:46Z","updated_at":"2015-04-17T12:33:16Z","pushed_at":"2015-06-22T11:56:49Z","git_url":"git://github.com/nemomobile/nemo-qml-plugin-calendar.git","ssh_url":"git@github.com:nemomobile/nemo-qml-plugin-calendar.git","clone_url":"https://github.com/nemomobile/nemo-qml-plugin-calendar.git","svn_url":"https://github.com/nemomobile/nemo-qml-plugin-calendar","homepage":null,"size":850,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":1,"forks":8,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/pulls/55"},"html":{"href":"https://github.com/nemomobile/nemo-qml-plugin-calendar/pull/55"},"issue":{"href":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/issues/55"},"comments":{"href":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-calendar/statuses/6c637e06ed13b9b5253fa3edcd0bcb04845b228a"}}}}