{"action":"opened","number":1579,"pull_request":{"url":"https://api.github.com/repos/doctrine/doctrine2/pulls/1579","id":52780569,"html_url":"https://github.com/doctrine/doctrine2/pull/1579","diff_url":"https://github.com/doctrine/doctrine2/pull/1579.diff","patch_url":"https://github.com/doctrine/doctrine2/pull/1579.patch","issue_url":"https://api.github.com/repos/doctrine/doctrine2/issues/1579","number":1579,"state":"open","locked":false,"title":"Reduce code duplication in ProxyFactory::createInitialized","user":{"login":"aschempp","id":1073273,"avatar_url":"https://avatars.githubusercontent.com/u/1073273?v=3","gravatar_id":"","url":"https://api.github.com/users/aschempp","html_url":"https://github.com/aschempp","followers_url":"https://api.github.com/users/aschempp/followers","following_url":"https://api.github.com/users/aschempp/following{/other_user}","gists_url":"https://api.github.com/users/aschempp/gists{/gist_id}","starred_url":"https://api.github.com/users/aschempp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aschempp/subscriptions","organizations_url":"https://api.github.com/users/aschempp/orgs","repos_url":"https://api.github.com/users/aschempp/repos","events_url":"https://api.github.com/users/aschempp/events{/privacy}","received_events_url":"https://api.github.com/users/aschempp/received_events","type":"User","site_admin":false},"body":"The only difference between the ~30 lines in the IF-statement is that the __wakup method is called on the proxy object. The \"simplified\" version adds the if-statement using an inherited flag in the closure.","created_at":"2015-12-06T13:59:19Z","updated_at":"2015-12-06T13:59:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/doctrine/doctrine2/pulls/1579/commits","review_comments_url":"https://api.github.com/repos/doctrine/doctrine2/pulls/1579/comments","review_comment_url":"https://api.github.com/repos/doctrine/doctrine2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/doctrine/doctrine2/issues/1579/comments","statuses_url":"https://api.github.com/repos/doctrine/doctrine2/statuses/4df7699ced33efdfab08d46e4135293b5dbbb138","head":{"label":"aschempp:proxy-initialized-cs","ref":"proxy-initialized-cs","sha":"4df7699ced33efdfab08d46e4135293b5dbbb138","user":{"login":"aschempp","id":1073273,"avatar_url":"https://avatars.githubusercontent.com/u/1073273?v=3","gravatar_id":"","url":"https://api.github.com/users/aschempp","html_url":"https://github.com/aschempp","followers_url":"https://api.github.com/users/aschempp/followers","following_url":"https://api.github.com/users/aschempp/following{/other_user}","gists_url":"https://api.github.com/users/aschempp/gists{/gist_id}","starred_url":"https://api.github.com/users/aschempp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aschempp/subscriptions","organizations_url":"https://api.github.com/users/aschempp/orgs","repos_url":"https://api.github.com/users/aschempp/repos","events_url":"https://api.github.com/users/aschempp/events{/privacy}","received_events_url":"https://api.github.com/users/aschempp/received_events","type":"User","site_admin":false},"repo":{"id":47498459,"name":"doctrine2","full_name":"aschempp/doctrine2","owner":{"login":"aschempp","id":1073273,"avatar_url":"https://avatars.githubusercontent.com/u/1073273?v=3","gravatar_id":"","url":"https://api.github.com/users/aschempp","html_url":"https://github.com/aschempp","followers_url":"https://api.github.com/users/aschempp/followers","following_url":"https://api.github.com/users/aschempp/following{/other_user}","gists_url":"https://api.github.com/users/aschempp/gists{/gist_id}","starred_url":"https://api.github.com/users/aschempp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aschempp/subscriptions","organizations_url":"https://api.github.com/users/aschempp/orgs","repos_url":"https://api.github.com/users/aschempp/repos","events_url":"https://api.github.com/users/aschempp/events{/privacy}","received_events_url":"https://api.github.com/users/aschempp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aschempp/doctrine2","description":"Doctrine 2 Object Relational Mapper (ORM)","fork":true,"url":"https://api.github.com/repos/aschempp/doctrine2","forks_url":"https://api.github.com/repos/aschempp/doctrine2/forks","keys_url":"https://api.github.com/repos/aschempp/doctrine2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aschempp/doctrine2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aschempp/doctrine2/teams","hooks_url":"https://api.github.com/repos/aschempp/doctrine2/hooks","issue_events_url":"https://api.github.com/repos/aschempp/doctrine2/issues/events{/number}","events_url":"https://api.github.com/repos/aschempp/doctrine2/events","assignees_url":"https://api.github.com/repos/aschempp/doctrine2/assignees{/user}","branches_url":"https://api.github.com/repos/aschempp/doctrine2/branches{/branch}","tags_url":"https://api.github.com/repos/aschempp/doctrine2/tags","blobs_url":"https://api.github.com/repos/aschempp/doctrine2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aschempp/doctrine2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aschempp/doctrine2/git/refs{/sha}","trees_url":"https://api.github.com/repos/aschempp/doctrine2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aschempp/doctrine2/statuses/{sha}","languages_url":"https://api.github.com/repos/aschempp/doctrine2/languages","stargazers_url":"https://api.github.com/repos/aschempp/doctrine2/stargazers","contributors_url":"https://api.github.com/repos/aschempp/doctrine2/contributors","subscribers_url":"https://api.github.com/repos/aschempp/doctrine2/subscribers","subscription_url":"https://api.github.com/repos/aschempp/doctrine2/subscription","commits_url":"https://api.github.com/repos/aschempp/doctrine2/commits{/sha}","git_commits_url":"https://api.github.com/repos/aschempp/doctrine2/git/commits{/sha}","comments_url":"https://api.github.com/repos/aschempp/doctrine2/comments{/number}","issue_comment_url":"https://api.github.com/repos/aschempp/doctrine2/issues/comments{/number}","contents_url":"https://api.github.com/repos/aschempp/doctrine2/contents/{+path}","compare_url":"https://api.github.com/repos/aschempp/doctrine2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aschempp/doctrine2/merges","archive_url":"https://api.github.com/repos/aschempp/doctrine2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aschempp/doctrine2/downloads","issues_url":"https://api.github.com/repos/aschempp/doctrine2/issues{/number}","pulls_url":"https://api.github.com/repos/aschempp/doctrine2/pulls{/number}","milestones_url":"https://api.github.com/repos/aschempp/doctrine2/milestones{/number}","notifications_url":"https://api.github.com/repos/aschempp/doctrine2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aschempp/doctrine2/labels{/name}","releases_url":"https://api.github.com/repos/aschempp/doctrine2/releases{/id}","created_at":"2015-12-06T13:48:33Z","updated_at":"2015-12-06T13:48:37Z","pushed_at":"2015-12-06T13:56:57Z","git_url":"git://github.com/aschempp/doctrine2.git","ssh_url":"git@github.com:aschempp/doctrine2.git","clone_url":"https://github.com/aschempp/doctrine2.git","svn_url":"https://github.com/aschempp/doctrine2","homepage":"http://www.doctrine-project.org","size":27068,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"doctrine:master","ref":"master","sha":"3c3b7364bab7593e4b03e49140834d74ce26510e","user":{"login":"doctrine","id":209254,"avatar_url":"https://avatars.githubusercontent.com/u/209254?v=3","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"repo":{"id":597887,"name":"doctrine2","full_name":"doctrine/doctrine2","owner":{"login":"doctrine","id":209254,"avatar_url":"https://avatars.githubusercontent.com/u/209254?v=3","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/doctrine/doctrine2","description":"Doctrine 2 Object Relational Mapper (ORM)","fork":false,"url":"https://api.github.com/repos/doctrine/doctrine2","forks_url":"https://api.github.com/repos/doctrine/doctrine2/forks","keys_url":"https://api.github.com/repos/doctrine/doctrine2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doctrine/doctrine2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doctrine/doctrine2/teams","hooks_url":"https://api.github.com/repos/doctrine/doctrine2/hooks","issue_events_url":"https://api.github.com/repos/doctrine/doctrine2/issues/events{/number}","events_url":"https://api.github.com/repos/doctrine/doctrine2/events","assignees_url":"https://api.github.com/repos/doctrine/doctrine2/assignees{/user}","branches_url":"https://api.github.com/repos/doctrine/doctrine2/branches{/branch}","tags_url":"https://api.github.com/repos/doctrine/doctrine2/tags","blobs_url":"https://api.github.com/repos/doctrine/doctrine2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doctrine/doctrine2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doctrine/doctrine2/git/refs{/sha}","trees_url":"https://api.github.com/repos/doctrine/doctrine2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doctrine/doctrine2/statuses/{sha}","languages_url":"https://api.github.com/repos/doctrine/doctrine2/languages","stargazers_url":"https://api.github.com/repos/doctrine/doctrine2/stargazers","contributors_url":"https://api.github.com/repos/doctrine/doctrine2/contributors","subscribers_url":"https://api.github.com/repos/doctrine/doctrine2/subscribers","subscription_url":"https://api.github.com/repos/doctrine/doctrine2/subscription","commits_url":"https://api.github.com/repos/doctrine/doctrine2/commits{/sha}","git_commits_url":"https://api.github.com/repos/doctrine/doctrine2/git/commits{/sha}","comments_url":"https://api.github.com/repos/doctrine/doctrine2/comments{/number}","issue_comment_url":"https://api.github.com/repos/doctrine/doctrine2/issues/comments{/number}","contents_url":"https://api.github.com/repos/doctrine/doctrine2/contents/{+path}","compare_url":"https://api.github.com/repos/doctrine/doctrine2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doctrine/doctrine2/merges","archive_url":"https://api.github.com/repos/doctrine/doctrine2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doctrine/doctrine2/downloads","issues_url":"https://api.github.com/repos/doctrine/doctrine2/issues{/number}","pulls_url":"https://api.github.com/repos/doctrine/doctrine2/pulls{/number}","milestones_url":"https://api.github.com/repos/doctrine/doctrine2/milestones{/number}","notifications_url":"https://api.github.com/repos/doctrine/doctrine2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doctrine/doctrine2/labels{/name}","releases_url":"https://api.github.com/repos/doctrine/doctrine2/releases{/id}","created_at":"2010-04-06T21:42:59Z","updated_at":"2015-12-06T03:48:35Z","pushed_at":"2015-12-06T13:59:20Z","git_url":"git://github.com/doctrine/doctrine2.git","ssh_url":"git@github.com:doctrine/doctrine2.git","clone_url":"https://github.com/doctrine/doctrine2.git","svn_url":"https://github.com/doctrine/doctrine2","homepage":"http://www.doctrine-project.org","size":31210,"stargazers_count":2819,"watchers_count":2819,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1407,"mirror_url":null,"open_issues_count":96,"forks":1407,"open_issues":96,"watchers":2819,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/1579"},"html":{"href":"https://github.com/doctrine/doctrine2/pull/1579"},"issue":{"href":"https://api.github.com/repos/doctrine/doctrine2/issues/1579"},"comments":{"href":"https://api.github.com/repos/doctrine/doctrine2/issues/1579/comments"},"review_comments":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/1579/comments"},"review_comment":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/1579/commits"},"statuses":{"href":"https://api.github.com/repos/doctrine/doctrine2/statuses/4df7699ced33efdfab08d46e4135293b5dbbb138"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":7,"deletions":39,"changed_files":1}}