{"action":"opened","number":57,"pull_request":{"url":"https://api.github.com/repos/wvanbergen/kafka/pulls/57","id":35757656,"html_url":"https://github.com/wvanbergen/kafka/pull/57","diff_url":"https://github.com/wvanbergen/kafka/pull/57.diff","patch_url":"https://github.com/wvanbergen/kafka/pull/57.patch","issue_url":"https://api.github.com/repos/wvanbergen/kafka/issues/57","number":57,"state":"open","locked":false,"title":"Handle sarama.ErrOffsetOfRange error somewhat gracefully. ","user":{"login":"shivnagarajan","id":11840428,"avatar_url":"https://avatars.githubusercontent.com/u/11840428?v=3","gravatar_id":"","url":"https://api.github.com/users/shivnagarajan","html_url":"https://github.com/shivnagarajan","followers_url":"https://api.github.com/users/shivnagarajan/followers","following_url":"https://api.github.com/users/shivnagarajan/following{/other_user}","gists_url":"https://api.github.com/users/shivnagarajan/gists{/gist_id}","starred_url":"https://api.github.com/users/shivnagarajan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shivnagarajan/subscriptions","organizations_url":"https://api.github.com/users/shivnagarajan/orgs","repos_url":"https://api.github.com/users/shivnagarajan/repos","events_url":"https://api.github.com/users/shivnagarajan/events{/privacy}","received_events_url":"https://api.github.com/users/shivnagarajan/received_events","type":"User","site_admin":false},"body":"When the offset retrieved from initializePartition in offsetManager,\r\nis very far off from the currently available offset, (i.e. < offsetOldest or > offsetNewest) \r\nthe consumePartition call will return a sarama.ErrOffsetOutOfRange error.\r\n\r\nThis change just adjusts the offset to either offsetOldest or offsetNewest, based on\r\nwhat was specified in the sarama.Config and retries the call to consumePartition\r\n\r\n@wvanbergen \r\n\r\nWill write a specific test to test out this behaviour also, just wanted to get early opinions :smile:","created_at":"2015-05-19T18:02:32Z","updated_at":"2015-05-19T18:02:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wvanbergen/kafka/pulls/57/commits","review_comments_url":"https://api.github.com/repos/wvanbergen/kafka/pulls/57/comments","review_comment_url":"https://api.github.com/repos/wvanbergen/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wvanbergen/kafka/issues/57/comments","statuses_url":"https://api.github.com/repos/wvanbergen/kafka/statuses/51a0af7bfcc8feb73423640c1f742af5dedc0657","head":{"label":"wvanbergen:consumer_group_outof_range","ref":"consumer_group_outof_range","sha":"51a0af7bfcc8feb73423640c1f742af5dedc0657","user":{"login":"wvanbergen","id":15870,"avatar_url":"https://avatars.githubusercontent.com/u/15870?v=3","gravatar_id":"","url":"https://api.github.com/users/wvanbergen","html_url":"https://github.com/wvanbergen","followers_url":"https://api.github.com/users/wvanbergen/followers","following_url":"https://api.github.com/users/wvanbergen/following{/other_user}","gists_url":"https://api.github.com/users/wvanbergen/gists{/gist_id}","starred_url":"https://api.github.com/users/wvanbergen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wvanbergen/subscriptions","organizations_url":"https://api.github.com/users/wvanbergen/orgs","repos_url":"https://api.github.com/users/wvanbergen/repos","events_url":"https://api.github.com/users/wvanbergen/events{/privacy}","received_events_url":"https://api.github.com/users/wvanbergen/received_events","type":"User","site_admin":false},"repo":{"id":19999011,"name":"kafka","full_name":"wvanbergen/kafka","owner":{"login":"wvanbergen","id":15870,"avatar_url":"https://avatars.githubusercontent.com/u/15870?v=3","gravatar_id":"","url":"https://api.github.com/users/wvanbergen","html_url":"https://github.com/wvanbergen","followers_url":"https://api.github.com/users/wvanbergen/followers","following_url":"https://api.github.com/users/wvanbergen/following{/other_user}","gists_url":"https://api.github.com/users/wvanbergen/gists{/gist_id}","starred_url":"https://api.github.com/users/wvanbergen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wvanbergen/subscriptions","organizations_url":"https://api.github.com/users/wvanbergen/orgs","repos_url":"https://api.github.com/users/wvanbergen/repos","events_url":"https://api.github.com/users/wvanbergen/events{/privacy}","received_events_url":"https://api.github.com/users/wvanbergen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wvanbergen/kafka","description":"Load-balancing, resuming Kafka consumer for go, backed by Zookeeper.","fork":false,"url":"https://api.github.com/repos/wvanbergen/kafka","forks_url":"https://api.github.com/repos/wvanbergen/kafka/forks","keys_url":"https://api.github.com/repos/wvanbergen/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wvanbergen/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wvanbergen/kafka/teams","hooks_url":"https://api.github.com/repos/wvanbergen/kafka/hooks","issue_events_url":"https://api.github.com/repos/wvanbergen/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/wvanbergen/kafka/events","assignees_url":"https://api.github.com/repos/wvanbergen/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/wvanbergen/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/wvanbergen/kafka/tags","blobs_url":"https://api.github.com/repos/wvanbergen/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wvanbergen/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wvanbergen/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/wvanbergen/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wvanbergen/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/wvanbergen/kafka/languages","stargazers_url":"https://api.github.com/repos/wvanbergen/kafka/stargazers","contributors_url":"https://api.github.com/repos/wvanbergen/kafka/contributors","subscribers_url":"https://api.github.com/repos/wvanbergen/kafka/subscribers","subscription_url":"https://api.github.com/repos/wvanbergen/kafka/subscription","commits_url":"https://api.github.com/repos/wvanbergen/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/wvanbergen/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/wvanbergen/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/wvanbergen/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/wvanbergen/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/wvanbergen/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wvanbergen/kafka/merges","archive_url":"https://api.github.com/repos/wvanbergen/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wvanbergen/kafka/downloads","issues_url":"https://api.github.com/repos/wvanbergen/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/wvanbergen/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/wvanbergen/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/wvanbergen/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wvanbergen/kafka/labels{/name}","releases_url":"https://api.github.com/repos/wvanbergen/kafka/releases{/id}","created_at":"2014-05-20T21:55:17Z","updated_at":"2015-05-16T04:56:16Z","pushed_at":"2015-05-19T17:58:26Z","git_url":"git://github.com/wvanbergen/kafka.git","ssh_url":"git@github.com:wvanbergen/kafka.git","clone_url":"https://github.com/wvanbergen/kafka.git","svn_url":"https://github.com/wvanbergen/kafka","homepage":"","size":1075,"stargazers_count":25,"watchers_count":25,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":6,"forks":11,"open_issues":6,"watchers":25,"default_branch":"master"}},"base":{"label":"wvanbergen:master","ref":"master","sha":"4818c4cb0f7929d21fc2a1d6b4795dcbe9e9127e","user":{"login":"wvanbergen","id":15870,"avatar_url":"https://avatars.githubusercontent.com/u/15870?v=3","gravatar_id":"","url":"https://api.github.com/users/wvanbergen","html_url":"https://github.com/wvanbergen","followers_url":"https://api.github.com/users/wvanbergen/followers","following_url":"https://api.github.com/users/wvanbergen/following{/other_user}","gists_url":"https://api.github.com/users/wvanbergen/gists{/gist_id}","starred_url":"https://api.github.com/users/wvanbergen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wvanbergen/subscriptions","organizations_url":"https://api.github.com/users/wvanbergen/orgs","repos_url":"https://api.github.com/users/wvanbergen/repos","events_url":"https://api.github.com/users/wvanbergen/events{/privacy}","received_events_url":"https://api.github.com/users/wvanbergen/received_events","type":"User","site_admin":false},"repo":{"id":19999011,"name":"kafka","full_name":"wvanbergen/kafka","owner":{"login":"wvanbergen","id":15870,"avatar_url":"https://avatars.githubusercontent.com/u/15870?v=3","gravatar_id":"","url":"https://api.github.com/users/wvanbergen","html_url":"https://github.com/wvanbergen","followers_url":"https://api.github.com/users/wvanbergen/followers","following_url":"https://api.github.com/users/wvanbergen/following{/other_user}","gists_url":"https://api.github.com/users/wvanbergen/gists{/gist_id}","starred_url":"https://api.github.com/users/wvanbergen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wvanbergen/subscriptions","organizations_url":"https://api.github.com/users/wvanbergen/orgs","repos_url":"https://api.github.com/users/wvanbergen/repos","events_url":"https://api.github.com/users/wvanbergen/events{/privacy}","received_events_url":"https://api.github.com/users/wvanbergen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wvanbergen/kafka","description":"Load-balancing, resuming Kafka consumer for go, backed by Zookeeper.","fork":false,"url":"https://api.github.com/repos/wvanbergen/kafka","forks_url":"https://api.github.com/repos/wvanbergen/kafka/forks","keys_url":"https://api.github.com/repos/wvanbergen/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wvanbergen/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wvanbergen/kafka/teams","hooks_url":"https://api.github.com/repos/wvanbergen/kafka/hooks","issue_events_url":"https://api.github.com/repos/wvanbergen/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/wvanbergen/kafka/events","assignees_url":"https://api.github.com/repos/wvanbergen/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/wvanbergen/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/wvanbergen/kafka/tags","blobs_url":"https://api.github.com/repos/wvanbergen/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wvanbergen/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wvanbergen/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/wvanbergen/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wvanbergen/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/wvanbergen/kafka/languages","stargazers_url":"https://api.github.com/repos/wvanbergen/kafka/stargazers","contributors_url":"https://api.github.com/repos/wvanbergen/kafka/contributors","subscribers_url":"https://api.github.com/repos/wvanbergen/kafka/subscribers","subscription_url":"https://api.github.com/repos/wvanbergen/kafka/subscription","commits_url":"https://api.github.com/repos/wvanbergen/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/wvanbergen/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/wvanbergen/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/wvanbergen/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/wvanbergen/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/wvanbergen/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wvanbergen/kafka/merges","archive_url":"https://api.github.com/repos/wvanbergen/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wvanbergen/kafka/downloads","issues_url":"https://api.github.com/repos/wvanbergen/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/wvanbergen/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/wvanbergen/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/wvanbergen/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wvanbergen/kafka/labels{/name}","releases_url":"https://api.github.com/repos/wvanbergen/kafka/releases{/id}","created_at":"2014-05-20T21:55:17Z","updated_at":"2015-05-16T04:56:16Z","pushed_at":"2015-05-19T17:58:26Z","git_url":"git://github.com/wvanbergen/kafka.git","ssh_url":"git@github.com:wvanbergen/kafka.git","clone_url":"https://github.com/wvanbergen/kafka.git","svn_url":"https://github.com/wvanbergen/kafka","homepage":"","size":1075,"stargazers_count":25,"watchers_count":25,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":6,"forks":11,"open_issues":6,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wvanbergen/kafka/pulls/57"},"html":{"href":"https://github.com/wvanbergen/kafka/pull/57"},"issue":{"href":"https://api.github.com/repos/wvanbergen/kafka/issues/57"},"comments":{"href":"https://api.github.com/repos/wvanbergen/kafka/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/wvanbergen/kafka/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/wvanbergen/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wvanbergen/kafka/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/wvanbergen/kafka/statuses/51a0af7bfcc8feb73423640c1f742af5dedc0657"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":15,"deletions":0,"changed_files":1}}