{"action":"created","issue":{"url":"https://api.github.com/repos/beatfactor/nightwatch/issues/414","labels_url":"https://api.github.com/repos/beatfactor/nightwatch/issues/414/labels{/name}","comments_url":"https://api.github.com/repos/beatfactor/nightwatch/issues/414/comments","events_url":"https://api.github.com/repos/beatfactor/nightwatch/issues/414/events","html_url":"https://github.com/beatfactor/nightwatch/pull/414","id":67965582,"number":414,"title":"Enhanced support for page object model","user":{"login":"sknopf","id":1311638,"avatar_url":"https://avatars.githubusercontent.com/u/1311638?v=3","gravatar_id":"","url":"https://api.github.com/users/sknopf","html_url":"https://github.com/sknopf","followers_url":"https://api.github.com/users/sknopf/followers","following_url":"https://api.github.com/users/sknopf/following{/other_user}","gists_url":"https://api.github.com/users/sknopf/gists{/gist_id}","starred_url":"https://api.github.com/users/sknopf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sknopf/subscriptions","organizations_url":"https://api.github.com/users/sknopf/orgs","repos_url":"https://api.github.com/users/sknopf/repos","events_url":"https://api.github.com/users/sknopf/events{/privacy}","received_events_url":"https://api.github.com/users/sknopf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":19,"created_at":"2015-04-12T22:05:12Z","updated_at":"2015-05-07T14:24:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/beatfactor/nightwatch/pulls/414","html_url":"https://github.com/beatfactor/nightwatch/pull/414","diff_url":"https://github.com/beatfactor/nightwatch/pull/414.diff","patch_url":"https://github.com/beatfactor/nightwatch/pull/414.patch"},"body":"This adds support for _enhanced_ page object model. It doesn't yet include tests or updated documentation, as I wanted to first get feedback.\r\n\r\nA couple notable features:\r\n- Supports sections (i.e., nested page objects)\r\n- Supports mixin functions used to encapsulate logic that doesn't fit the normal element/selector paradigm\r\n- Easy to share elements across page objects or sections\r\n- Simple API that mirrors the one already in Nightwatch\r\n\r\nWe've been using this for a few weeks internally at Twitter now and it's been working great. Though I'm sure there are some kinks to still get sorted out - one I am aware of supporting custom client commands and assertions whose first argument is not a selector.\r\n\r\n@beatfactor let me know what you think."},"comment":{"url":"https://api.github.com/repos/beatfactor/nightwatch/issues/comments/99884840","html_url":"https://github.com/beatfactor/nightwatch/pull/414#issuecomment-99884840","issue_url":"https://api.github.com/repos/beatfactor/nightwatch/issues/414","id":99884840,"user":{"login":"beatfactor","id":419506,"avatar_url":"https://avatars.githubusercontent.com/u/419506?v=3","gravatar_id":"","url":"https://api.github.com/users/beatfactor","html_url":"https://github.com/beatfactor","followers_url":"https://api.github.com/users/beatfactor/followers","following_url":"https://api.github.com/users/beatfactor/following{/other_user}","gists_url":"https://api.github.com/users/beatfactor/gists{/gist_id}","starred_url":"https://api.github.com/users/beatfactor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beatfactor/subscriptions","organizations_url":"https://api.github.com/users/beatfactor/orgs","repos_url":"https://api.github.com/users/beatfactor/repos","events_url":"https://api.github.com/users/beatfactor/events{/privacy}","received_events_url":"https://api.github.com/users/beatfactor/received_events","type":"User","site_admin":false},"created_at":"2015-05-07T14:24:10Z","updated_at":"2015-05-07T14:24:10Z","body":"@sknopf would it be ok if I merge this in the next major version, i.e. 0.7? I'm currently working on an another major new feature (new assertion library) and I think it would be nice to also include this as a headliner. Besides, this is a large enough enhancement to increase the version number."}}