{"action":"created","issue":{"url":"https://api.github.com/repos/marinmitev/smarthome/issues/107","labels_url":"https://api.github.com/repos/marinmitev/smarthome/issues/107/labels{/name}","comments_url":"https://api.github.com/repos/marinmitev/smarthome/issues/107/comments","events_url":"https://api.github.com/repos/marinmitev/smarthome/issues/107/events","html_url":"https://github.com/marinmitev/smarthome/issues/107","id":108280612,"number":107,"title":"Ids of CustomizedModuleTypes ","user":{"login":"BenediktNiehues","id":496568,"avatar_url":"https://avatars.githubusercontent.com/u/496568?v=3","gravatar_id":"","url":"https://api.github.com/users/BenediktNiehues","html_url":"https://github.com/BenediktNiehues","followers_url":"https://api.github.com/users/BenediktNiehues/followers","following_url":"https://api.github.com/users/BenediktNiehues/following{/other_user}","gists_url":"https://api.github.com/users/BenediktNiehues/gists{/gist_id}","starred_url":"https://api.github.com/users/BenediktNiehues/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenediktNiehues/subscriptions","organizations_url":"https://api.github.com/users/BenediktNiehues/orgs","repos_url":"https://api.github.com/users/BenediktNiehues/repos","events_url":"https://api.github.com/users/BenediktNiehues/events{/privacy}","received_events_url":"https://api.github.com/users/BenediktNiehues/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-09-25T08:01:14Z","updated_at":"2015-10-01T12:59:11Z","closed_at":null,"body":"I would like to have only the last part of the ID be treated as the ID of an customized moduleType. So that we can express a chain for  BaseModuleType->CutomModuleType->MoreCustomModuleType as follows:\r\n```\r\n\"BaseModuleType\": {...}\r\n\r\n\"BaseModuleType:CustomModuleType\":{...}\r\n\r\n\"CustomModuleType:MoreCustomModuleType\":{...}\r\n```\r\nThe Ids of the CustomModuleTypes should be only CustomModuleType and MoreCustomModuleType then. With this approach the CustomModuleType only needs to know its direct parent as it should be in the implementation as well.\r\nIn the rule where these moduleTypes will be used, we then only should specify the ID of the CustomModuleType as well.\r\n"},"comment":{"url":"https://api.github.com/repos/marinmitev/smarthome/issues/comments/144719714","html_url":"https://github.com/marinmitev/smarthome/issues/107#issuecomment-144719714","issue_url":"https://api.github.com/repos/marinmitev/smarthome/issues/107","id":144719714,"user":{"login":"kaikreuzer","id":3244965,"avatar_url":"https://avatars.githubusercontent.com/u/3244965?v=3","gravatar_id":"","url":"https://api.github.com/users/kaikreuzer","html_url":"https://github.com/kaikreuzer","followers_url":"https://api.github.com/users/kaikreuzer/followers","following_url":"https://api.github.com/users/kaikreuzer/following{/other_user}","gists_url":"https://api.github.com/users/kaikreuzer/gists{/gist_id}","starred_url":"https://api.github.com/users/kaikreuzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaikreuzer/subscriptions","organizations_url":"https://api.github.com/users/kaikreuzer/orgs","repos_url":"https://api.github.com/users/kaikreuzer/repos","events_url":"https://api.github.com/users/kaikreuzer/events{/privacy}","received_events_url":"https://api.github.com/users/kaikreuzer/received_events","type":"User","site_admin":false},"created_at":"2015-10-01T12:59:11Z","updated_at":"2015-10-01T12:59:11Z","body":"> use a dedicated property \"parent\" to specify the system(parent) module type.\r\n\r\nWhere do you want to introduce this new property? On the ModuleType class? This would imho spoil the class with stuff that is only relevant for certain implementations. I would very much prefer to have it only introduced in a subclass instead."}}