{"action":"closed","number":325,"pull_request":{"url":"https://api.github.com/repos/madebymany/sir-trevor-js/pulls/325","id":31648755,"html_url":"https://github.com/madebymany/sir-trevor-js/pull/325","diff_url":"https://github.com/madebymany/sir-trevor-js/pull/325.diff","patch_url":"https://github.com/madebymany/sir-trevor-js/pull/325.patch","issue_url":"https://api.github.com/repos/madebymany/sir-trevor-js/issues/325","number":325,"state":"closed","locked":false,"title":"Added ability to override the upload url in custom blocks","user":{"login":"efexen","id":1451215,"avatar_url":"https://avatars.githubusercontent.com/u/1451215?v=3","gravatar_id":"","url":"https://api.github.com/users/efexen","html_url":"https://github.com/efexen","followers_url":"https://api.github.com/users/efexen/followers","following_url":"https://api.github.com/users/efexen/following{/other_user}","gists_url":"https://api.github.com/users/efexen/gists{/gist_id}","starred_url":"https://api.github.com/users/efexen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/efexen/subscriptions","organizations_url":"https://api.github.com/users/efexen/orgs","repos_url":"https://api.github.com/users/efexen/repos","events_url":"https://api.github.com/users/efexen/events{/privacy}","received_events_url":"https://api.github.com/users/efexen/received_events","type":"User","site_admin":false},"body":"Hey,\r\n\r\nI was working on a project using sir-trevor-js the other day and created several custom blocks, as part of this work I found that there was no good way to override the upload url for my custom blocks which resulted in less than optimal server side code.\r\n\r\nThis PR makes it possible to override the uploadUrl for custom blocks by setting uploadUrl in the body of the custom block, if no override is present the global default is used instead.\r\n\r\nI've added some clarification around the use of uploadUrl in the documentation under Custom Blocks heading and a mention of the new feature detailed above.\r\n\r\nLet me know what you think.\r\n\r\nThanks\r\n.FxN","created_at":"2015-03-20T20:24:23Z","updated_at":"2015-03-24T12:49:50Z","closed_at":"2015-03-24T12:49:50Z","merged_at":"2015-03-24T12:49:50Z","merge_commit_sha":"f88d1b46ff450e4b18bc9ac8445c501c208c1412","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/madebymany/sir-trevor-js/pulls/325/commits","review_comments_url":"https://api.github.com/repos/madebymany/sir-trevor-js/pulls/325/comments","review_comment_url":"https://api.github.com/repos/madebymany/sir-trevor-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/madebymany/sir-trevor-js/issues/325/comments","statuses_url":"https://api.github.com/repos/madebymany/sir-trevor-js/statuses/13be28b57db4b17198b7b6ef7d27ddeb5a40332b","head":{"label":"efexen:upload_url_override","ref":"upload_url_override","sha":"13be28b57db4b17198b7b6ef7d27ddeb5a40332b","user":{"login":"efexen","id":1451215,"avatar_url":"https://avatars.githubusercontent.com/u/1451215?v=3","gravatar_id":"","url":"https://api.github.com/users/efexen","html_url":"https://github.com/efexen","followers_url":"https://api.github.com/users/efexen/followers","following_url":"https://api.github.com/users/efexen/following{/other_user}","gists_url":"https://api.github.com/users/efexen/gists{/gist_id}","starred_url":"https://api.github.com/users/efexen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/efexen/subscriptions","organizations_url":"https://api.github.com/users/efexen/orgs","repos_url":"https://api.github.com/users/efexen/repos","events_url":"https://api.github.com/users/efexen/events{/privacy}","received_events_url":"https://api.github.com/users/efexen/received_events","type":"User","site_admin":false},"repo":{"id":32604141,"name":"sir-trevor-js","full_name":"efexen/sir-trevor-js","owner":{"login":"efexen","id":1451215,"avatar_url":"https://avatars.githubusercontent.com/u/1451215?v=3","gravatar_id":"","url":"https://api.github.com/users/efexen","html_url":"https://github.com/efexen","followers_url":"https://api.github.com/users/efexen/followers","following_url":"https://api.github.com/users/efexen/following{/other_user}","gists_url":"https://api.github.com/users/efexen/gists{/gist_id}","starred_url":"https://api.github.com/users/efexen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/efexen/subscriptions","organizations_url":"https://api.github.com/users/efexen/orgs","repos_url":"https://api.github.com/users/efexen/repos","events_url":"https://api.github.com/users/efexen/events{/privacy}","received_events_url":"https://api.github.com/users/efexen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/efexen/sir-trevor-js","description":"Rich content editing entirely re-imagined for the web","fork":true,"url":"https://api.github.com/repos/efexen/sir-trevor-js","forks_url":"https://api.github.com/repos/efexen/sir-trevor-js/forks","keys_url":"https://api.github.com/repos/efexen/sir-trevor-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/efexen/sir-trevor-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/efexen/sir-trevor-js/teams","hooks_url":"https://api.github.com/repos/efexen/sir-trevor-js/hooks","issue_events_url":"https://api.github.com/repos/efexen/sir-trevor-js/issues/events{/number}","events_url":"https://api.github.com/repos/efexen/sir-trevor-js/events","assignees_url":"https://api.github.com/repos/efexen/sir-trevor-js/assignees{/user}","branches_url":"https://api.github.com/repos/efexen/sir-trevor-js/branches{/branch}","tags_url":"https://api.github.com/repos/efexen/sir-trevor-js/tags","blobs_url":"https://api.github.com/repos/efexen/sir-trevor-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/efexen/sir-trevor-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/efexen/sir-trevor-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/efexen/sir-trevor-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/efexen/sir-trevor-js/statuses/{sha}","languages_url":"https://api.github.com/repos/efexen/sir-trevor-js/languages","stargazers_url":"https://api.github.com/repos/efexen/sir-trevor-js/stargazers","contributors_url":"https://api.github.com/repos/efexen/sir-trevor-js/contributors","subscribers_url":"https://api.github.com/repos/efexen/sir-trevor-js/subscribers","subscription_url":"https://api.github.com/repos/efexen/sir-trevor-js/subscription","commits_url":"https://api.github.com/repos/efexen/sir-trevor-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/efexen/sir-trevor-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/efexen/sir-trevor-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/efexen/sir-trevor-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/efexen/sir-trevor-js/contents/{+path}","compare_url":"https://api.github.com/repos/efexen/sir-trevor-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/efexen/sir-trevor-js/merges","archive_url":"https://api.github.com/repos/efexen/sir-trevor-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/efexen/sir-trevor-js/downloads","issues_url":"https://api.github.com/repos/efexen/sir-trevor-js/issues{/number}","pulls_url":"https://api.github.com/repos/efexen/sir-trevor-js/pulls{/number}","milestones_url":"https://api.github.com/repos/efexen/sir-trevor-js/milestones{/number}","notifications_url":"https://api.github.com/repos/efexen/sir-trevor-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/efexen/sir-trevor-js/labels{/name}","releases_url":"https://api.github.com/repos/efexen/sir-trevor-js/releases{/id}","created_at":"2015-03-20T20:01:06Z","updated_at":"2015-03-20T20:01:07Z","pushed_at":"2015-03-20T20:18:14Z","git_url":"git://github.com/efexen/sir-trevor-js.git","ssh_url":"git@github.com:efexen/sir-trevor-js.git","clone_url":"https://github.com/efexen/sir-trevor-js.git","svn_url":"https://github.com/efexen/sir-trevor-js","homepage":"http://madebymany.github.io/sir-trevor-js/","size":10012,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"madebymany:master","ref":"master","sha":"de7cb78455b8880651ae983ec2eaba65f59815e2","user":{"login":"madebymany","id":55873,"avatar_url":"https://avatars.githubusercontent.com/u/55873?v=3","gravatar_id":"","url":"https://api.github.com/users/madebymany","html_url":"https://github.com/madebymany","followers_url":"https://api.github.com/users/madebymany/followers","following_url":"https://api.github.com/users/madebymany/following{/other_user}","gists_url":"https://api.github.com/users/madebymany/gists{/gist_id}","starred_url":"https://api.github.com/users/madebymany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madebymany/subscriptions","organizations_url":"https://api.github.com/users/madebymany/orgs","repos_url":"https://api.github.com/users/madebymany/repos","events_url":"https://api.github.com/users/madebymany/events{/privacy}","received_events_url":"https://api.github.com/users/madebymany/received_events","type":"Organization","site_admin":false},"repo":{"id":5311424,"name":"sir-trevor-js","full_name":"madebymany/sir-trevor-js","owner":{"login":"madebymany","id":55873,"avatar_url":"https://avatars.githubusercontent.com/u/55873?v=3","gravatar_id":"","url":"https://api.github.com/users/madebymany","html_url":"https://github.com/madebymany","followers_url":"https://api.github.com/users/madebymany/followers","following_url":"https://api.github.com/users/madebymany/following{/other_user}","gists_url":"https://api.github.com/users/madebymany/gists{/gist_id}","starred_url":"https://api.github.com/users/madebymany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madebymany/subscriptions","organizations_url":"https://api.github.com/users/madebymany/orgs","repos_url":"https://api.github.com/users/madebymany/repos","events_url":"https://api.github.com/users/madebymany/events{/privacy}","received_events_url":"https://api.github.com/users/madebymany/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/madebymany/sir-trevor-js","description":"Rich content editing entirely re-imagined for the web","fork":false,"url":"https://api.github.com/repos/madebymany/sir-trevor-js","forks_url":"https://api.github.com/repos/madebymany/sir-trevor-js/forks","keys_url":"https://api.github.com/repos/madebymany/sir-trevor-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/madebymany/sir-trevor-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/madebymany/sir-trevor-js/teams","hooks_url":"https://api.github.com/repos/madebymany/sir-trevor-js/hooks","issue_events_url":"https://api.github.com/repos/madebymany/sir-trevor-js/issues/events{/number}","events_url":"https://api.github.com/repos/madebymany/sir-trevor-js/events","assignees_url":"https://api.github.com/repos/madebymany/sir-trevor-js/assignees{/user}","branches_url":"https://api.github.com/repos/madebymany/sir-trevor-js/branches{/branch}","tags_url":"https://api.github.com/repos/madebymany/sir-trevor-js/tags","blobs_url":"https://api.github.com/repos/madebymany/sir-trevor-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/madebymany/sir-trevor-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/madebymany/sir-trevor-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/madebymany/sir-trevor-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/madebymany/sir-trevor-js/statuses/{sha}","languages_url":"https://api.github.com/repos/madebymany/sir-trevor-js/languages","stargazers_url":"https://api.github.com/repos/madebymany/sir-trevor-js/stargazers","contributors_url":"https://api.github.com/repos/madebymany/sir-trevor-js/contributors","subscribers_url":"https://api.github.com/repos/madebymany/sir-trevor-js/subscribers","subscription_url":"https://api.github.com/repos/madebymany/sir-trevor-js/subscription","commits_url":"https://api.github.com/repos/madebymany/sir-trevor-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/madebymany/sir-trevor-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/madebymany/sir-trevor-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/madebymany/sir-trevor-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/madebymany/sir-trevor-js/contents/{+path}","compare_url":"https://api.github.com/repos/madebymany/sir-trevor-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/madebymany/sir-trevor-js/merges","archive_url":"https://api.github.com/repos/madebymany/sir-trevor-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/madebymany/sir-trevor-js/downloads","issues_url":"https://api.github.com/repos/madebymany/sir-trevor-js/issues{/number}","pulls_url":"https://api.github.com/repos/madebymany/sir-trevor-js/pulls{/number}","milestones_url":"https://api.github.com/repos/madebymany/sir-trevor-js/milestones{/number}","notifications_url":"https://api.github.com/repos/madebymany/sir-trevor-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/madebymany/sir-trevor-js/labels{/name}","releases_url":"https://api.github.com/repos/madebymany/sir-trevor-js/releases{/id}","created_at":"2012-08-06T07:50:15Z","updated_at":"2015-03-23T13:53:42Z","pushed_at":"2015-03-24T12:49:50Z","git_url":"git://github.com/madebymany/sir-trevor-js.git","ssh_url":"git@github.com:madebymany/sir-trevor-js.git","clone_url":"https://github.com/madebymany/sir-trevor-js.git","svn_url":"https://github.com/madebymany/sir-trevor-js","homepage":"http://madebymany.github.io/sir-trevor-js/","size":13603,"stargazers_count":3682,"watchers_count":3682,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":336,"mirror_url":null,"open_issues_count":60,"forks":336,"open_issues":60,"watchers":3682,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/madebymany/sir-trevor-js/pulls/325"},"html":{"href":"https://github.com/madebymany/sir-trevor-js/pull/325"},"issue":{"href":"https://api.github.com/repos/madebymany/sir-trevor-js/issues/325"},"comments":{"href":"https://api.github.com/repos/madebymany/sir-trevor-js/issues/325/comments"},"review_comments":{"href":"https://api.github.com/repos/madebymany/sir-trevor-js/pulls/325/comments"},"review_comment":{"href":"https://api.github.com/repos/madebymany/sir-trevor-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/madebymany/sir-trevor-js/pulls/325/commits"},"statuses":{"href":"https://api.github.com/repos/madebymany/sir-trevor-js/statuses/13be28b57db4b17198b7b6ef7d27ddeb5a40332b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ninjabiscuit","id":242949,"avatar_url":"https://avatars.githubusercontent.com/u/242949?v=3","gravatar_id":"","url":"https://api.github.com/users/ninjabiscuit","html_url":"https://github.com/ninjabiscuit","followers_url":"https://api.github.com/users/ninjabiscuit/followers","following_url":"https://api.github.com/users/ninjabiscuit/following{/other_user}","gists_url":"https://api.github.com/users/ninjabiscuit/gists{/gist_id}","starred_url":"https://api.github.com/users/ninjabiscuit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninjabiscuit/subscriptions","organizations_url":"https://api.github.com/users/ninjabiscuit/orgs","repos_url":"https://api.github.com/users/ninjabiscuit/repos","events_url":"https://api.github.com/users/ninjabiscuit/events{/privacy}","received_events_url":"https://api.github.com/users/ninjabiscuit/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":4,"deletions":2,"changed_files":2}}