{"action":"created","issue":{"url":"https://api.github.com/repos/libstorage/libstoragemgmt/issues/69","labels_url":"https://api.github.com/repos/libstorage/libstoragemgmt/issues/69/labels{/name}","comments_url":"https://api.github.com/repos/libstorage/libstoragemgmt/issues/69/comments","events_url":"https://api.github.com/repos/libstorage/libstoragemgmt/issues/69/events","html_url":"https://github.com/libstorage/libstoragemgmt/pull/69","id":114345362,"number":69,"title":"Add volume-ident-led-* support for volumes","user":{"login":"joehandzik","id":7061812,"avatar_url":"https://avatars.githubusercontent.com/u/7061812?v=3","gravatar_id":"","url":"https://api.github.com/users/joehandzik","html_url":"https://github.com/joehandzik","followers_url":"https://api.github.com/users/joehandzik/followers","following_url":"https://api.github.com/users/joehandzik/following{/other_user}","gists_url":"https://api.github.com/users/joehandzik/gists{/gist_id}","starred_url":"https://api.github.com/users/joehandzik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joehandzik/subscriptions","organizations_url":"https://api.github.com/users/joehandzik/orgs","repos_url":"https://api.github.com/users/joehandzik/repos","events_url":"https://api.github.com/users/joehandzik/events{/privacy}","received_events_url":"https://api.github.com/users/joehandzik/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-10-30T19:59:35Z","updated_at":"2015-11-06T16:42:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/libstorage/libstoragemgmt/pulls/69","html_url":"https://github.com/libstorage/libstoragemgmt/pull/69","diff_url":"https://github.com/libstorage/libstoragemgmt/pull/69.diff","patch_url":"https://github.com/libstorage/libstoragemgmt/pull/69.patch"},"body":"Hopefully this one is less controversial. These two patches allow you to enable and disable LEDs behind logical volumes on a Smart Array (and I assume other controllers, but I don't know the other plugins well enough to implement for them). Take a look lemme know what you think."},"comment":{"url":"https://api.github.com/repos/libstorage/libstoragemgmt/issues/comments/154465984","html_url":"https://github.com/libstorage/libstoragemgmt/pull/69#issuecomment-154465984","issue_url":"https://api.github.com/repos/libstorage/libstoragemgmt/issues/69","id":154465984,"user":{"login":"tasleson","id":2520480,"avatar_url":"https://avatars.githubusercontent.com/u/2520480?v=3","gravatar_id":"","url":"https://api.github.com/users/tasleson","html_url":"https://github.com/tasleson","followers_url":"https://api.github.com/users/tasleson/followers","following_url":"https://api.github.com/users/tasleson/following{/other_user}","gists_url":"https://api.github.com/users/tasleson/gists{/gist_id}","starred_url":"https://api.github.com/users/tasleson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tasleson/subscriptions","organizations_url":"https://api.github.com/users/tasleson/orgs","repos_url":"https://api.github.com/users/tasleson/repos","events_url":"https://api.github.com/users/tasleson/events{/privacy}","received_events_url":"https://api.github.com/users/tasleson/received_events","type":"User","site_admin":false},"created_at":"2015-11-06T16:42:28Z","updated_at":"2015-11-06T16:42:28Z","body":"My initial reaction was kind of like @cathay4t, *\"What's with blinking all the lights for a volume?\"*.  My use case is finding a disk that needs to be replaced.  However, I don't see any reason why adding blinking for all the disks that make up a volume is bad from an API decision.  It should work fine for a HBA or a SAN box that has 1K+ disks, in fact in larger configurations it becomes more of an asset if needed (This virtual disk sits on 1K disks, light them up so we can remove them for law enforcement).  My main thought when looking at the API change is if the change works well across all the different things we manage?  In this case I think having it on the Volume is perfectly acceptable too.\r\n\r\nAdditionally, we need to remember that it could be possible that an array could implement blinking lights for a volume, but not support `pool_member_info`, so in some cases a user couldn't implement this functionality themselves.\r\n"}}