{"action":"created","comment":{"url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/pulls/comments/47356401","id":47356401,"diff_hunk":"@@ -0,0 +1,159 @@\n+# VPC Configuration\n+\n+### Contents\n+\n+##### [1. Basic configuration](#basic-configuration)\n+\n+VPC configuration is done in the under the 'vpc' key section of the cloudformation configuration file.\n+\n+Defaults are set so that without specifying anything, we get a VPC with CIDR `10.128.0.0/16` and 3 subnets, `10.0.0.0/20`, `10.0.16.0/20`, and `10.0.32.0/20`","path":"docs/vpc-configuration.md","position":9,"original_position":9,"commit_id":"758ea654cb71273b4ac5bccad9cd6d9a668d01cc","original_commit_id":"758ea654cb71273b4ac5bccad9cd6d9a668d01cc","user":{"login":"niallcreech","id":2128678,"avatar_url":"https://avatars.githubusercontent.com/u/2128678?v=3","gravatar_id":"","url":"https://api.github.com/users/niallcreech","html_url":"https://github.com/niallcreech","followers_url":"https://api.github.com/users/niallcreech/followers","following_url":"https://api.github.com/users/niallcreech/following{/other_user}","gists_url":"https://api.github.com/users/niallcreech/gists{/gist_id}","starred_url":"https://api.github.com/users/niallcreech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niallcreech/subscriptions","organizations_url":"https://api.github.com/users/niallcreech/orgs","repos_url":"https://api.github.com/users/niallcreech/repos","events_url":"https://api.github.com/users/niallcreech/events{/privacy}","received_events_url":"https://api.github.com/users/niallcreech/received_events","type":"User","site_admin":false},"body":"cocked up documentation, my apologies","created_at":"2015-12-11T13:53:32Z","updated_at":"2015-12-11T13:53:32Z","html_url":"https://github.com/ministryofjustice/bootstrap-cfn/pull/164#discussion_r47356401","pull_request_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/pulls/164","_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/pulls/comments/47356401"},"html":{"href":"https://github.com/ministryofjustice/bootstrap-cfn/pull/164#discussion_r47356401"},"pull_request":{"href":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/pulls/164"}}},"pull_request":{"url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/pulls/164","id":52881866,"html_url":"https://github.com/ministryofjustice/bootstrap-cfn/pull/164","diff_url":"https://github.com/ministryofjustice/bootstrap-cfn/pull/164.diff","patch_url":"https://github.com/ministryofjustice/bootstrap-cfn/pull/164.patch","issue_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/issues/164","number":164,"state":"open","locked":false,"title":"(WIP) Add vpc peering","user":{"login":"niallcreech","id":2128678,"avatar_url":"https://avatars.githubusercontent.com/u/2128678?v=3","gravatar_id":"","url":"https://api.github.com/users/niallcreech","html_url":"https://github.com/niallcreech","followers_url":"https://api.github.com/users/niallcreech/followers","following_url":"https://api.github.com/users/niallcreech/following{/other_user}","gists_url":"https://api.github.com/users/niallcreech/gists{/gist_id}","starred_url":"https://api.github.com/users/niallcreech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niallcreech/subscriptions","organizations_url":"https://api.github.com/users/niallcreech/orgs","repos_url":"https://api.github.com/users/niallcreech/repos","events_url":"https://api.github.com/users/niallcreech/events{/privacy}","received_events_url":"https://api.github.com/users/niallcreech/received_events","type":"User","site_admin":false},"body":"This change allows us to set up a config with,\r\n      \r\n      vpc:\r\n          peering:\r\n            helloworld-dev1: {}\r\n\r\nand run `fab enable_vpc_peering' to automatically create a peering connection with that stack name match. Currently the both vpc's overall CIDR will be routed between all route tables. The empty dictionary allows for expansion of configuration settings into more granular control. \r\n\r\n    * Create new class VPC to handle vpc connections and peering\r\n    * Update requirements to include boto3\r\n    * Add new fab tasks enable/disable_vpc_peering\r\n    * Add boto3 to setup.py requirements\r\n    * Add VPC docs page\r\n    * Add vpc requester/accepter routes to all route tables in each vpc","created_at":"2015-12-07T18:28:37Z","updated_at":"2015-12-11T13:53:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d4d698d8e0bfd806405d3d9fa508fb9384ced4a","assignee":{"login":"niallcreech","id":2128678,"avatar_url":"https://avatars.githubusercontent.com/u/2128678?v=3","gravatar_id":"","url":"https://api.github.com/users/niallcreech","html_url":"https://github.com/niallcreech","followers_url":"https://api.github.com/users/niallcreech/followers","following_url":"https://api.github.com/users/niallcreech/following{/other_user}","gists_url":"https://api.github.com/users/niallcreech/gists{/gist_id}","starred_url":"https://api.github.com/users/niallcreech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niallcreech/subscriptions","organizations_url":"https://api.github.com/users/niallcreech/orgs","repos_url":"https://api.github.com/users/niallcreech/repos","events_url":"https://api.github.com/users/niallcreech/events{/privacy}","received_events_url":"https://api.github.com/users/niallcreech/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/pulls/164/commits","review_comments_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/pulls/164/comments","review_comment_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/issues/164/comments","statuses_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/statuses/758ea654cb71273b4ac5bccad9cd6d9a668d01cc","head":{"label":"ministryofjustice:add_vpc_peering","ref":"add_vpc_peering","sha":"758ea654cb71273b4ac5bccad9cd6d9a668d01cc","user":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":29302791,"name":"bootstrap-cfn","full_name":"ministryofjustice/bootstrap-cfn","owner":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ministryofjustice/bootstrap-cfn","description":"Opinionated layer for AWS CloudFormation","fork":false,"url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn","forks_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/forks","keys_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/events","assignees_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/merges","archive_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/releases{/id}","created_at":"2015-01-15T15:08:58Z","updated_at":"2015-10-13T18:19:35Z","pushed_at":"2015-12-09T18:57:04Z","git_url":"git://github.com/ministryofjustice/bootstrap-cfn.git","ssh_url":"git@github.com:ministryofjustice/bootstrap-cfn.git","clone_url":"https://github.com/ministryofjustice/bootstrap-cfn.git","svn_url":"https://github.com/ministryofjustice/bootstrap-cfn","homepage":"","size":493,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":11,"forks":1,"open_issues":11,"watchers":5,"default_branch":"master"}},"base":{"label":"ministryofjustice:master","ref":"master","sha":"533365b1610d94e9d846e7b92973f203077ee4d2","user":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":29302791,"name":"bootstrap-cfn","full_name":"ministryofjustice/bootstrap-cfn","owner":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ministryofjustice/bootstrap-cfn","description":"Opinionated layer for AWS CloudFormation","fork":false,"url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn","forks_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/forks","keys_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/events","assignees_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/merges","archive_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/releases{/id}","created_at":"2015-01-15T15:08:58Z","updated_at":"2015-10-13T18:19:35Z","pushed_at":"2015-12-09T18:57:04Z","git_url":"git://github.com/ministryofjustice/bootstrap-cfn.git","ssh_url":"git@github.com:ministryofjustice/bootstrap-cfn.git","clone_url":"https://github.com/ministryofjustice/bootstrap-cfn.git","svn_url":"https://github.com/ministryofjustice/bootstrap-cfn","homepage":"","size":493,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":11,"forks":1,"open_issues":11,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/pulls/164"},"html":{"href":"https://github.com/ministryofjustice/bootstrap-cfn/pull/164"},"issue":{"href":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/issues/164"},"comments":{"href":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/issues/164/comments"},"review_comments":{"href":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/pulls/164/comments"},"review_comment":{"href":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/pulls/164/commits"},"statuses":{"href":"https://api.github.com/repos/ministryofjustice/bootstrap-cfn/statuses/758ea654cb71273b4ac5bccad9cd6d9a668d01cc"}}}}