{"action":"created","comment":{"url":"https://api.github.com/repos/inveniosoftware/invenio/pulls/comments/24232450","id":24232450,"diff_hunk":"@@ -44,6 +46,9 @@ def do_upgrade():\n \n def estimate():\n     \"\"\"Estimate running time of upgrade in seconds (optional).\"\"\"\n-    return run_sql(\n-        \"SELECT COUNT(id) AS ids FROM oauth2TOKEN\"\n-    )[0][0]\n+    try:\n+        return run_sql(\n+            \"SELECT COUNT(id) AS ids FROM oauth2TOKEN\"\n+        )[0][0]\n+    except:","path":"invenio/modules/oauth2server/upgrades/oauth2server_2014_10_21_encrypted_token_columns.py","position":22,"original_position":22,"commit_id":"241fce962b9d44e620f144e7f7d7b3d4e6d9a001","original_commit_id":"241fce962b9d44e620f144e7f7d7b3d4e6d9a001","user":{"login":"jirikuncar","id":189798,"avatar_url":"https://avatars.githubusercontent.com/u/189798?v=3","gravatar_id":"","url":"https://api.github.com/users/jirikuncar","html_url":"https://github.com/jirikuncar","followers_url":"https://api.github.com/users/jirikuncar/followers","following_url":"https://api.github.com/users/jirikuncar/following{/other_user}","gists_url":"https://api.github.com/users/jirikuncar/gists{/gist_id}","starred_url":"https://api.github.com/users/jirikuncar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jirikuncar/subscriptions","organizations_url":"https://api.github.com/users/jirikuncar/orgs","repos_url":"https://api.github.com/users/jirikuncar/repos","events_url":"https://api.github.com/users/jirikuncar/events{/privacy}","received_events_url":"https://api.github.com/users/jirikuncar/received_events","type":"User","site_admin":false},"body":"Why do you need to catch the exception here?\r\n\r\n--\r\nPS: `except Exception:`","created_at":"2015-02-06T10:22:22Z","updated_at":"2015-02-06T10:22:22Z","html_url":"https://github.com/inveniosoftware/invenio/pull/2747#discussion_r24232450","pull_request_url":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2747","_links":{"self":{"href":"https://api.github.com/repos/inveniosoftware/invenio/pulls/comments/24232450"},"html":{"href":"https://github.com/inveniosoftware/invenio/pull/2747#discussion_r24232450"},"pull_request":{"href":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2747"}}},"pull_request":{"url":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2747","id":28737435,"html_url":"https://github.com/inveniosoftware/invenio/pull/2747","diff_url":"https://github.com/inveniosoftware/invenio/pull/2747.diff","patch_url":"https://github.com/inveniosoftware/invenio/pull/2747.patch","issue_url":"https://api.github.com/repos/inveniosoftware/invenio/issues/2747","number":2747,"state":"open","locked":false,"title":"installation: upgrade recipes fix","user":{"login":"egabancho","id":582735,"avatar_url":"https://avatars.githubusercontent.com/u/582735?v=3","gravatar_id":"","url":"https://api.github.com/users/egabancho","html_url":"https://github.com/egabancho","followers_url":"https://api.github.com/users/egabancho/followers","following_url":"https://api.github.com/users/egabancho/following{/other_user}","gists_url":"https://api.github.com/users/egabancho/gists{/gist_id}","starred_url":"https://api.github.com/users/egabancho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egabancho/subscriptions","organizations_url":"https://api.github.com/users/egabancho/orgs","repos_url":"https://api.github.com/users/egabancho/repos","events_url":"https://api.github.com/users/egabancho/events{/privacy}","received_events_url":"https://api.github.com/users/egabancho/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-02-05T16:16:13Z","updated_at":"2015-02-06T10:22:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da0b5d07926224b44c1862a293d9d6950f3d7586","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2747/commits","review_comments_url":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2747/comments","review_comment_url":"https://api.github.com/repos/inveniosoftware/invenio/pulls/comments/{number}","comments_url":"https://api.github.com/repos/inveniosoftware/invenio/issues/2747/comments","statuses_url":"https://api.github.com/repos/inveniosoftware/invenio/statuses/241fce962b9d44e620f144e7f7d7b3d4e6d9a001","head":{"label":"egabancho:pu-fix-oauth-upgrade-recipies","ref":"pu-fix-oauth-upgrade-recipies","sha":"241fce962b9d44e620f144e7f7d7b3d4e6d9a001","user":{"login":"egabancho","id":582735,"avatar_url":"https://avatars.githubusercontent.com/u/582735?v=3","gravatar_id":"","url":"https://api.github.com/users/egabancho","html_url":"https://github.com/egabancho","followers_url":"https://api.github.com/users/egabancho/followers","following_url":"https://api.github.com/users/egabancho/following{/other_user}","gists_url":"https://api.github.com/users/egabancho/gists{/gist_id}","starred_url":"https://api.github.com/users/egabancho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egabancho/subscriptions","organizations_url":"https://api.github.com/users/egabancho/orgs","repos_url":"https://api.github.com/users/egabancho/repos","events_url":"https://api.github.com/users/egabancho/events{/privacy}","received_events_url":"https://api.github.com/users/egabancho/received_events","type":"User","site_admin":false},"repo":{"id":16029654,"name":"invenio","full_name":"egabancho/invenio","owner":{"login":"egabancho","id":582735,"avatar_url":"https://avatars.githubusercontent.com/u/582735?v=3","gravatar_id":"","url":"https://api.github.com/users/egabancho","html_url":"https://github.com/egabancho","followers_url":"https://api.github.com/users/egabancho/followers","following_url":"https://api.github.com/users/egabancho/following{/other_user}","gists_url":"https://api.github.com/users/egabancho/gists{/gist_id}","starred_url":"https://api.github.com/users/egabancho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egabancho/subscriptions","organizations_url":"https://api.github.com/users/egabancho/orgs","repos_url":"https://api.github.com/users/egabancho/repos","events_url":"https://api.github.com/users/egabancho/events{/privacy}","received_events_url":"https://api.github.com/users/egabancho/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/egabancho/invenio","description":"Invenio source code mirror.  Please use Trac for collaborating.","fork":true,"url":"https://api.github.com/repos/egabancho/invenio","forks_url":"https://api.github.com/repos/egabancho/invenio/forks","keys_url":"https://api.github.com/repos/egabancho/invenio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/egabancho/invenio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/egabancho/invenio/teams","hooks_url":"https://api.github.com/repos/egabancho/invenio/hooks","issue_events_url":"https://api.github.com/repos/egabancho/invenio/issues/events{/number}","events_url":"https://api.github.com/repos/egabancho/invenio/events","assignees_url":"https://api.github.com/repos/egabancho/invenio/assignees{/user}","branches_url":"https://api.github.com/repos/egabancho/invenio/branches{/branch}","tags_url":"https://api.github.com/repos/egabancho/invenio/tags","blobs_url":"https://api.github.com/repos/egabancho/invenio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/egabancho/invenio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/egabancho/invenio/git/refs{/sha}","trees_url":"https://api.github.com/repos/egabancho/invenio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/egabancho/invenio/statuses/{sha}","languages_url":"https://api.github.com/repos/egabancho/invenio/languages","stargazers_url":"https://api.github.com/repos/egabancho/invenio/stargazers","contributors_url":"https://api.github.com/repos/egabancho/invenio/contributors","subscribers_url":"https://api.github.com/repos/egabancho/invenio/subscribers","subscription_url":"https://api.github.com/repos/egabancho/invenio/subscription","commits_url":"https://api.github.com/repos/egabancho/invenio/commits{/sha}","git_commits_url":"https://api.github.com/repos/egabancho/invenio/git/commits{/sha}","comments_url":"https://api.github.com/repos/egabancho/invenio/comments{/number}","issue_comment_url":"https://api.github.com/repos/egabancho/invenio/issues/comments/{number}","contents_url":"https://api.github.com/repos/egabancho/invenio/contents/{+path}","compare_url":"https://api.github.com/repos/egabancho/invenio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/egabancho/invenio/merges","archive_url":"https://api.github.com/repos/egabancho/invenio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/egabancho/invenio/downloads","issues_url":"https://api.github.com/repos/egabancho/invenio/issues{/number}","pulls_url":"https://api.github.com/repos/egabancho/invenio/pulls{/number}","milestones_url":"https://api.github.com/repos/egabancho/invenio/milestones{/number}","notifications_url":"https://api.github.com/repos/egabancho/invenio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/egabancho/invenio/labels{/name}","releases_url":"https://api.github.com/repos/egabancho/invenio/releases{/id}","created_at":"2014-01-18T16:56:40Z","updated_at":"2015-02-03T10:49:40Z","pushed_at":"2015-02-06T08:13:28Z","git_url":"git://github.com/egabancho/invenio.git","ssh_url":"git@github.com:egabancho/invenio.git","clone_url":"https://github.com/egabancho/invenio.git","svn_url":"https://github.com/egabancho/invenio","homepage":"http://invenio-software.org/","size":75592,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":0,"default_branch":"pu"}},"base":{"label":"inveniosoftware:pu","ref":"pu","sha":"f09463ba47f874b1df23806e0d782ca91c7eac3b","user":{"login":"inveniosoftware","id":1157480,"avatar_url":"https://avatars.githubusercontent.com/u/1157480?v=3","gravatar_id":"","url":"https://api.github.com/users/inveniosoftware","html_url":"https://github.com/inveniosoftware","followers_url":"https://api.github.com/users/inveniosoftware/followers","following_url":"https://api.github.com/users/inveniosoftware/following{/other_user}","gists_url":"https://api.github.com/users/inveniosoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/inveniosoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inveniosoftware/subscriptions","organizations_url":"https://api.github.com/users/inveniosoftware/orgs","repos_url":"https://api.github.com/users/inveniosoftware/repos","events_url":"https://api.github.com/users/inveniosoftware/events{/privacy}","received_events_url":"https://api.github.com/users/inveniosoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":2665618,"name":"invenio","full_name":"inveniosoftware/invenio","owner":{"login":"inveniosoftware","id":1157480,"avatar_url":"https://avatars.githubusercontent.com/u/1157480?v=3","gravatar_id":"","url":"https://api.github.com/users/inveniosoftware","html_url":"https://github.com/inveniosoftware","followers_url":"https://api.github.com/users/inveniosoftware/followers","following_url":"https://api.github.com/users/inveniosoftware/following{/other_user}","gists_url":"https://api.github.com/users/inveniosoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/inveniosoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inveniosoftware/subscriptions","organizations_url":"https://api.github.com/users/inveniosoftware/orgs","repos_url":"https://api.github.com/users/inveniosoftware/repos","events_url":"https://api.github.com/users/inveniosoftware/events{/privacy}","received_events_url":"https://api.github.com/users/inveniosoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inveniosoftware/invenio","description":"Invenio digital library software","fork":false,"url":"https://api.github.com/repos/inveniosoftware/invenio","forks_url":"https://api.github.com/repos/inveniosoftware/invenio/forks","keys_url":"https://api.github.com/repos/inveniosoftware/invenio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inveniosoftware/invenio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inveniosoftware/invenio/teams","hooks_url":"https://api.github.com/repos/inveniosoftware/invenio/hooks","issue_events_url":"https://api.github.com/repos/inveniosoftware/invenio/issues/events{/number}","events_url":"https://api.github.com/repos/inveniosoftware/invenio/events","assignees_url":"https://api.github.com/repos/inveniosoftware/invenio/assignees{/user}","branches_url":"https://api.github.com/repos/inveniosoftware/invenio/branches{/branch}","tags_url":"https://api.github.com/repos/inveniosoftware/invenio/tags","blobs_url":"https://api.github.com/repos/inveniosoftware/invenio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inveniosoftware/invenio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inveniosoftware/invenio/git/refs{/sha}","trees_url":"https://api.github.com/repos/inveniosoftware/invenio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inveniosoftware/invenio/statuses/{sha}","languages_url":"https://api.github.com/repos/inveniosoftware/invenio/languages","stargazers_url":"https://api.github.com/repos/inveniosoftware/invenio/stargazers","contributors_url":"https://api.github.com/repos/inveniosoftware/invenio/contributors","subscribers_url":"https://api.github.com/repos/inveniosoftware/invenio/subscribers","subscription_url":"https://api.github.com/repos/inveniosoftware/invenio/subscription","commits_url":"https://api.github.com/repos/inveniosoftware/invenio/commits{/sha}","git_commits_url":"https://api.github.com/repos/inveniosoftware/invenio/git/commits{/sha}","comments_url":"https://api.github.com/repos/inveniosoftware/invenio/comments{/number}","issue_comment_url":"https://api.github.com/repos/inveniosoftware/invenio/issues/comments/{number}","contents_url":"https://api.github.com/repos/inveniosoftware/invenio/contents/{+path}","compare_url":"https://api.github.com/repos/inveniosoftware/invenio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inveniosoftware/invenio/merges","archive_url":"https://api.github.com/repos/inveniosoftware/invenio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inveniosoftware/invenio/downloads","issues_url":"https://api.github.com/repos/inveniosoftware/invenio/issues{/number}","pulls_url":"https://api.github.com/repos/inveniosoftware/invenio/pulls{/number}","milestones_url":"https://api.github.com/repos/inveniosoftware/invenio/milestones{/number}","notifications_url":"https://api.github.com/repos/inveniosoftware/invenio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inveniosoftware/invenio/labels{/name}","releases_url":"https://api.github.com/repos/inveniosoftware/invenio/releases{/id}","created_at":"2011-10-28T14:33:51Z","updated_at":"2015-02-05T12:49:52Z","pushed_at":"2015-02-05T12:49:46Z","git_url":"git://github.com/inveniosoftware/invenio.git","ssh_url":"git@github.com:inveniosoftware/invenio.git","clone_url":"https://github.com/inveniosoftware/invenio.git","svn_url":"https://github.com/inveniosoftware/invenio","homepage":"http://invenio-software.org/","size":87480,"stargazers_count":47,"watchers_count":47,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":110,"mirror_url":null,"open_issues_count":827,"forks":110,"open_issues":827,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2747"},"html":{"href":"https://github.com/inveniosoftware/invenio/pull/2747"},"issue":{"href":"https://api.github.com/repos/inveniosoftware/invenio/issues/2747"},"comments":{"href":"https://api.github.com/repos/inveniosoftware/invenio/issues/2747/comments"},"review_comments":{"href":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2747/comments"},"review_comment":{"href":"https://api.github.com/repos/inveniosoftware/invenio/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2747/commits"},"statuses":{"href":"https://api.github.com/repos/inveniosoftware/invenio/statuses/241fce962b9d44e620f144e7f7d7b3d4e6d9a001"}}}}