{"action":"created","comment":{"url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/pulls/comments/48043988","id":48043988,"diff_hunk":"@@ -164,6 +164,10 @@ function compileToString(sources, options){\n       compile(sources, options)\n         .on(\"close\", function(exitCode){\n           fs.readFile(info.path, function(err, data){\n+            if (exitCode !== 0) {\n+              err = \"Compiler process exited with code \" + exitCode;\n+            }","path":"index.js","position":6,"original_position":6,"commit_id":"acd6e7d6d440a8d816006fa27f138e33c1d60732","original_commit_id":"acd6e7d6d440a8d816006fa27f138e33c1d60732","user":{"login":"unindented","id":69485,"avatar_url":"https://avatars.githubusercontent.com/u/69485?v=3","gravatar_id":"","url":"https://api.github.com/users/unindented","html_url":"https://github.com/unindented","followers_url":"https://api.github.com/users/unindented/followers","following_url":"https://api.github.com/users/unindented/following{/other_user}","gists_url":"https://api.github.com/users/unindented/gists{/gist_id}","starred_url":"https://api.github.com/users/unindented/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unindented/subscriptions","organizations_url":"https://api.github.com/users/unindented/orgs","repos_url":"https://api.github.com/users/unindented/repos","events_url":"https://api.github.com/users/unindented/events{/privacy}","received_events_url":"https://api.github.com/users/unindented/received_events","type":"User","site_admin":false},"body":"Non-zero exit codes were being ignored, and the promise was being resolved, when it should have been rejected. 😞","created_at":"2015-12-18T16:43:01Z","updated_at":"2015-12-18T16:43:01Z","html_url":"https://github.com/rtfeldman/node-elm-compiler/pull/19#discussion_r48043988","pull_request_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/rtfeldman/node-elm-compiler/pulls/comments/48043988"},"html":{"href":"https://github.com/rtfeldman/node-elm-compiler/pull/19#discussion_r48043988"},"pull_request":{"href":"https://api.github.com/repos/rtfeldman/node-elm-compiler/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/pulls/19","id":54123220,"html_url":"https://github.com/rtfeldman/node-elm-compiler/pull/19","diff_url":"https://github.com/rtfeldman/node-elm-compiler/pull/19.diff","patch_url":"https://github.com/rtfeldman/node-elm-compiler/pull/19.patch","issue_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/issues/19","number":19,"state":"open","locked":false,"title":"Test compilation of bad sources","user":{"login":"unindented","id":69485,"avatar_url":"https://avatars.githubusercontent.com/u/69485?v=3","gravatar_id":"","url":"https://api.github.com/users/unindented","html_url":"https://github.com/unindented","followers_url":"https://api.github.com/users/unindented/followers","following_url":"https://api.github.com/users/unindented/following{/other_user}","gists_url":"https://api.github.com/users/unindented/gists{/gist_id}","starred_url":"https://api.github.com/users/unindented/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unindented/subscriptions","organizations_url":"https://api.github.com/users/unindented/orgs","repos_url":"https://api.github.com/users/unindented/repos","events_url":"https://api.github.com/users/unindented/events{/privacy}","received_events_url":"https://api.github.com/users/unindented/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-12-18T16:42:05Z","updated_at":"2015-12-18T16:43:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"185473a0912b30db4d0bfcac1abc41f699ba21aa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/pulls/19/commits","review_comments_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/pulls/19/comments","review_comment_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/issues/19/comments","statuses_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/statuses/acd6e7d6d440a8d816006fa27f138e33c1d60732","head":{"label":"unindented:master","ref":"master","sha":"acd6e7d6d440a8d816006fa27f138e33c1d60732","user":{"login":"unindented","id":69485,"avatar_url":"https://avatars.githubusercontent.com/u/69485?v=3","gravatar_id":"","url":"https://api.github.com/users/unindented","html_url":"https://github.com/unindented","followers_url":"https://api.github.com/users/unindented/followers","following_url":"https://api.github.com/users/unindented/following{/other_user}","gists_url":"https://api.github.com/users/unindented/gists{/gist_id}","starred_url":"https://api.github.com/users/unindented/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unindented/subscriptions","organizations_url":"https://api.github.com/users/unindented/orgs","repos_url":"https://api.github.com/users/unindented/repos","events_url":"https://api.github.com/users/unindented/events{/privacy}","received_events_url":"https://api.github.com/users/unindented/received_events","type":"User","site_admin":false},"repo":{"id":48244831,"name":"node-elm-compiler","full_name":"unindented/node-elm-compiler","owner":{"login":"unindented","id":69485,"avatar_url":"https://avatars.githubusercontent.com/u/69485?v=3","gravatar_id":"","url":"https://api.github.com/users/unindented","html_url":"https://github.com/unindented","followers_url":"https://api.github.com/users/unindented/followers","following_url":"https://api.github.com/users/unindented/following{/other_user}","gists_url":"https://api.github.com/users/unindented/gists{/gist_id}","starred_url":"https://api.github.com/users/unindented/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unindented/subscriptions","organizations_url":"https://api.github.com/users/unindented/orgs","repos_url":"https://api.github.com/users/unindented/repos","events_url":"https://api.github.com/users/unindented/events{/privacy}","received_events_url":"https://api.github.com/users/unindented/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/unindented/node-elm-compiler","description":"A Node.js interface to the Elm compiler binaries.","fork":true,"url":"https://api.github.com/repos/unindented/node-elm-compiler","forks_url":"https://api.github.com/repos/unindented/node-elm-compiler/forks","keys_url":"https://api.github.com/repos/unindented/node-elm-compiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unindented/node-elm-compiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unindented/node-elm-compiler/teams","hooks_url":"https://api.github.com/repos/unindented/node-elm-compiler/hooks","issue_events_url":"https://api.github.com/repos/unindented/node-elm-compiler/issues/events{/number}","events_url":"https://api.github.com/repos/unindented/node-elm-compiler/events","assignees_url":"https://api.github.com/repos/unindented/node-elm-compiler/assignees{/user}","branches_url":"https://api.github.com/repos/unindented/node-elm-compiler/branches{/branch}","tags_url":"https://api.github.com/repos/unindented/node-elm-compiler/tags","blobs_url":"https://api.github.com/repos/unindented/node-elm-compiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unindented/node-elm-compiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unindented/node-elm-compiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/unindented/node-elm-compiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unindented/node-elm-compiler/statuses/{sha}","languages_url":"https://api.github.com/repos/unindented/node-elm-compiler/languages","stargazers_url":"https://api.github.com/repos/unindented/node-elm-compiler/stargazers","contributors_url":"https://api.github.com/repos/unindented/node-elm-compiler/contributors","subscribers_url":"https://api.github.com/repos/unindented/node-elm-compiler/subscribers","subscription_url":"https://api.github.com/repos/unindented/node-elm-compiler/subscription","commits_url":"https://api.github.com/repos/unindented/node-elm-compiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/unindented/node-elm-compiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/unindented/node-elm-compiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/unindented/node-elm-compiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/unindented/node-elm-compiler/contents/{+path}","compare_url":"https://api.github.com/repos/unindented/node-elm-compiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unindented/node-elm-compiler/merges","archive_url":"https://api.github.com/repos/unindented/node-elm-compiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unindented/node-elm-compiler/downloads","issues_url":"https://api.github.com/repos/unindented/node-elm-compiler/issues{/number}","pulls_url":"https://api.github.com/repos/unindented/node-elm-compiler/pulls{/number}","milestones_url":"https://api.github.com/repos/unindented/node-elm-compiler/milestones{/number}","notifications_url":"https://api.github.com/repos/unindented/node-elm-compiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unindented/node-elm-compiler/labels{/name}","releases_url":"https://api.github.com/repos/unindented/node-elm-compiler/releases{/id}","created_at":"2015-12-18T16:23:00Z","updated_at":"2015-12-18T16:23:01Z","pushed_at":"2015-12-18T16:41:12Z","git_url":"git://github.com/unindented/node-elm-compiler.git","ssh_url":"git@github.com:unindented/node-elm-compiler.git","clone_url":"https://github.com/unindented/node-elm-compiler.git","svn_url":"https://github.com/unindented/node-elm-compiler","homepage":null,"size":56,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rtfeldman:master","ref":"master","sha":"97ede2126355ea78d656d15897d91e1db053df22","user":{"login":"rtfeldman","id":1094080,"avatar_url":"https://avatars.githubusercontent.com/u/1094080?v=3","gravatar_id":"","url":"https://api.github.com/users/rtfeldman","html_url":"https://github.com/rtfeldman","followers_url":"https://api.github.com/users/rtfeldman/followers","following_url":"https://api.github.com/users/rtfeldman/following{/other_user}","gists_url":"https://api.github.com/users/rtfeldman/gists{/gist_id}","starred_url":"https://api.github.com/users/rtfeldman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtfeldman/subscriptions","organizations_url":"https://api.github.com/users/rtfeldman/orgs","repos_url":"https://api.github.com/users/rtfeldman/repos","events_url":"https://api.github.com/users/rtfeldman/events{/privacy}","received_events_url":"https://api.github.com/users/rtfeldman/received_events","type":"User","site_admin":false},"repo":{"id":32271778,"name":"node-elm-compiler","full_name":"rtfeldman/node-elm-compiler","owner":{"login":"rtfeldman","id":1094080,"avatar_url":"https://avatars.githubusercontent.com/u/1094080?v=3","gravatar_id":"","url":"https://api.github.com/users/rtfeldman","html_url":"https://github.com/rtfeldman","followers_url":"https://api.github.com/users/rtfeldman/followers","following_url":"https://api.github.com/users/rtfeldman/following{/other_user}","gists_url":"https://api.github.com/users/rtfeldman/gists{/gist_id}","starred_url":"https://api.github.com/users/rtfeldman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtfeldman/subscriptions","organizations_url":"https://api.github.com/users/rtfeldman/orgs","repos_url":"https://api.github.com/users/rtfeldman/repos","events_url":"https://api.github.com/users/rtfeldman/events{/privacy}","received_events_url":"https://api.github.com/users/rtfeldman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rtfeldman/node-elm-compiler","description":"A Node.js interface to the Elm compiler binaries.","fork":false,"url":"https://api.github.com/repos/rtfeldman/node-elm-compiler","forks_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/forks","keys_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/teams","hooks_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/hooks","issue_events_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/issues/events{/number}","events_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/events","assignees_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/assignees{/user}","branches_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/branches{/branch}","tags_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/tags","blobs_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/statuses/{sha}","languages_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/languages","stargazers_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/stargazers","contributors_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/contributors","subscribers_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/subscribers","subscription_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/subscription","commits_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/contents/{+path}","compare_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/merges","archive_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/downloads","issues_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/issues{/number}","pulls_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/pulls{/number}","milestones_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/milestones{/number}","notifications_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/labels{/name}","releases_url":"https://api.github.com/repos/rtfeldman/node-elm-compiler/releases{/id}","created_at":"2015-03-15T16:47:22Z","updated_at":"2015-12-15T09:04:02Z","pushed_at":"2015-12-18T16:42:05Z","git_url":"git://github.com/rtfeldman/node-elm-compiler.git","ssh_url":"git@github.com:rtfeldman/node-elm-compiler.git","clone_url":"https://github.com/rtfeldman/node-elm-compiler.git","svn_url":"https://github.com/rtfeldman/node-elm-compiler","homepage":null,"size":55,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rtfeldman/node-elm-compiler/pulls/19"},"html":{"href":"https://github.com/rtfeldman/node-elm-compiler/pull/19"},"issue":{"href":"https://api.github.com/repos/rtfeldman/node-elm-compiler/issues/19"},"comments":{"href":"https://api.github.com/repos/rtfeldman/node-elm-compiler/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/rtfeldman/node-elm-compiler/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/rtfeldman/node-elm-compiler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rtfeldman/node-elm-compiler/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/rtfeldman/node-elm-compiler/statuses/acd6e7d6d440a8d816006fa27f138e33c1d60732"}}}}