{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/comments/25365837","id":25365837,"diff_hunk":"@@ -1,14 +1,20 @@\n+# Where the puppet-agent dependency places puppet, facter, etc...\n+# Puppet server expects to load Puppet from this location\n+os-settings: {\n+    ruby-load-path: [/opt/puppetlabs/puppet/lib/ruby/vendor_ruby]\n+}\n+\n # configuration for the JRuby interpreters\n jruby-puppet: {\n     # This setting determines where JRuby will look for gems.  It is also\n     # used by the `puppetserver gem` command line tool.\n-    gem-home: /var/lib/puppet/jruby-gems\n+    gem-home: /opt/puppetlabs/server/data/puppetserver/jruby-gems\n \n     # (optional) path to puppet conf dir; if not specified, will use the puppet default\n-    master-conf-dir: /etc/puppetlabs/agent\n+    master-conf-dir: /etc/puppetlabs/puppet\n \n     # (optional) path to puppet var dir; if not specified, will use the puppet default\n-    master-var-dir: /opt/puppetlabs/agent/cache\n+    master-var-dir: /opt/puppetlabs/server/data/puppetserver","path":"resources/ext/config/conf.d/puppetserver.conf","position":20,"original_position":20,"commit_id":"1c85a1f56081a4a1a31839116106beb1f951a340","original_commit_id":"449cfd9b9f34b7fd23586cb450a8a4c3586819a5","user":{"login":"cprice404","id":1341071,"avatar_url":"https://avatars.githubusercontent.com/u/1341071?v=3","gravatar_id":"","url":"https://api.github.com/users/cprice404","html_url":"https://github.com/cprice404","followers_url":"https://api.github.com/users/cprice404/followers","following_url":"https://api.github.com/users/cprice404/following{/other_user}","gists_url":"https://api.github.com/users/cprice404/gists{/gist_id}","starred_url":"https://api.github.com/users/cprice404/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cprice404/subscriptions","organizations_url":"https://api.github.com/users/cprice404/orgs","repos_url":"https://api.github.com/users/cprice404/repos","events_url":"https://api.github.com/users/cprice404/events{/privacy}","received_events_url":"https://api.github.com/users/cprice404/received_events","type":"User","site_admin":false},"body":"I generally agree with your comments, @joshcooper, but that postinst step will only guarantee that `puppet master --configprint vardir` will work *if* the files aren't modified later.  So it should be fine for beaker/acceptance tests unless there are tests that manipulate the vardir setting, just something for us to be aware of.\r\n\r\nAnd yes, I'm thinking that in P5 we should remove the 'master' command altogether and add tools for interrogating the necessary settings from Puppet Server directly.  I don't think we have any intention of adding any new beaker settings for that, totally agree with your statement.","created_at":"2015-02-25T18:40:06Z","updated_at":"2015-02-25T18:40:06Z","html_url":"https://github.com/puppetlabs/puppet-server/pull/411#discussion_r25365837","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/411","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/comments/25365837"},"html":{"href":"https://github.com/puppetlabs/puppet-server/pull/411#discussion_r25365837"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/411"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/411","id":29833314,"html_url":"https://github.com/puppetlabs/puppet-server/pull/411","diff_url":"https://github.com/puppetlabs/puppet-server/pull/411.diff","patch_url":"https://github.com/puppetlabs/puppet-server/pull/411.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/411","number":411,"state":"open","locked":false,"title":"[FOR EARLY REVIEW] Get EL-7 Smoke Tests Passing","user":{"login":"jeffmccune","id":8972,"avatar_url":"https://avatars.githubusercontent.com/u/8972?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffmccune","html_url":"https://github.com/jeffmccune","followers_url":"https://api.github.com/users/jeffmccune/followers","following_url":"https://api.github.com/users/jeffmccune/following{/other_user}","gists_url":"https://api.github.com/users/jeffmccune/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffmccune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffmccune/subscriptions","organizations_url":"https://api.github.com/users/jeffmccune/orgs","repos_url":"https://api.github.com/users/jeffmccune/repos","events_url":"https://api.github.com/users/jeffmccune/events{/privacy}","received_events_url":"https://api.github.com/users/jeffmccune/received_events","type":"User","site_admin":false},"body":"This set of changes results in EL-7 smoke tests passing again, which is a step\r\nin the direction of getting CI green again.\r\n\r\nCURRENT PLAN: All changes to the paths will be included in this pull request.  These changes are mostly captured in the tickets blocked by SERVER-369, but additional changes may be necessary that are not captured in those blocked tickets.","created_at":"2015-02-23T18:36:35Z","updated_at":"2015-02-25T18:40:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3762c2a3eaaf78f0e90ce7b372f912e24957d06","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/411/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/411/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/411/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet-server/statuses/1c85a1f56081a4a1a31839116106beb1f951a340","head":{"label":"jeffmccune:s369_the_vardir_that_is_not","ref":"s369_the_vardir_that_is_not","sha":"1c85a1f56081a4a1a31839116106beb1f951a340","user":{"login":"jeffmccune","id":8972,"avatar_url":"https://avatars.githubusercontent.com/u/8972?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffmccune","html_url":"https://github.com/jeffmccune","followers_url":"https://api.github.com/users/jeffmccune/followers","following_url":"https://api.github.com/users/jeffmccune/following{/other_user}","gists_url":"https://api.github.com/users/jeffmccune/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffmccune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffmccune/subscriptions","organizations_url":"https://api.github.com/users/jeffmccune/orgs","repos_url":"https://api.github.com/users/jeffmccune/repos","events_url":"https://api.github.com/users/jeffmccune/events{/privacy}","received_events_url":"https://api.github.com/users/jeffmccune/received_events","type":"User","site_admin":false},"repo":{"id":26023101,"name":"puppet-server","full_name":"jeffmccune/puppet-server","owner":{"login":"jeffmccune","id":8972,"avatar_url":"https://avatars.githubusercontent.com/u/8972?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffmccune","html_url":"https://github.com/jeffmccune","followers_url":"https://api.github.com/users/jeffmccune/followers","following_url":"https://api.github.com/users/jeffmccune/following{/other_user}","gists_url":"https://api.github.com/users/jeffmccune/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffmccune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffmccune/subscriptions","organizations_url":"https://api.github.com/users/jeffmccune/orgs","repos_url":"https://api.github.com/users/jeffmccune/repos","events_url":"https://api.github.com/users/jeffmccune/events{/privacy}","received_events_url":"https://api.github.com/users/jeffmccune/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeffmccune/puppet-server","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/jeffmccune/puppet-server","forks_url":"https://api.github.com/repos/jeffmccune/puppet-server/forks","keys_url":"https://api.github.com/repos/jeffmccune/puppet-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeffmccune/puppet-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeffmccune/puppet-server/teams","hooks_url":"https://api.github.com/repos/jeffmccune/puppet-server/hooks","issue_events_url":"https://api.github.com/repos/jeffmccune/puppet-server/issues/events{/number}","events_url":"https://api.github.com/repos/jeffmccune/puppet-server/events","assignees_url":"https://api.github.com/repos/jeffmccune/puppet-server/assignees{/user}","branches_url":"https://api.github.com/repos/jeffmccune/puppet-server/branches{/branch}","tags_url":"https://api.github.com/repos/jeffmccune/puppet-server/tags","blobs_url":"https://api.github.com/repos/jeffmccune/puppet-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeffmccune/puppet-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeffmccune/puppet-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeffmccune/puppet-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeffmccune/puppet-server/statuses/{sha}","languages_url":"https://api.github.com/repos/jeffmccune/puppet-server/languages","stargazers_url":"https://api.github.com/repos/jeffmccune/puppet-server/stargazers","contributors_url":"https://api.github.com/repos/jeffmccune/puppet-server/contributors","subscribers_url":"https://api.github.com/repos/jeffmccune/puppet-server/subscribers","subscription_url":"https://api.github.com/repos/jeffmccune/puppet-server/subscription","commits_url":"https://api.github.com/repos/jeffmccune/puppet-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeffmccune/puppet-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeffmccune/puppet-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeffmccune/puppet-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeffmccune/puppet-server/contents/{+path}","compare_url":"https://api.github.com/repos/jeffmccune/puppet-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeffmccune/puppet-server/merges","archive_url":"https://api.github.com/repos/jeffmccune/puppet-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeffmccune/puppet-server/downloads","issues_url":"https://api.github.com/repos/jeffmccune/puppet-server/issues{/number}","pulls_url":"https://api.github.com/repos/jeffmccune/puppet-server/pulls{/number}","milestones_url":"https://api.github.com/repos/jeffmccune/puppet-server/milestones{/number}","notifications_url":"https://api.github.com/repos/jeffmccune/puppet-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeffmccune/puppet-server/labels{/name}","releases_url":"https://api.github.com/repos/jeffmccune/puppet-server/releases{/id}","created_at":"2014-10-31T16:07:28Z","updated_at":"2014-12-01T21:46:54Z","pushed_at":"2015-02-25T02:12:44Z","git_url":"git://github.com/jeffmccune/puppet-server.git","ssh_url":"git@github.com:jeffmccune/puppet-server.git","clone_url":"https://github.com/jeffmccune/puppet-server.git","svn_url":"https://github.com/jeffmccune/puppet-server","homepage":"https://tickets.puppetlabs.com/browse/SERVER","size":1889,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"1445aac5a77a5b012d6131e54fdd69f7ac24a234","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":19546488,"name":"puppet-server","full_name":"puppetlabs/puppet-server","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet-server","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet-server","forks_url":"https://api.github.com/repos/puppetlabs/puppet-server/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet-server/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet-server/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet-server/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet-server/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet-server/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet-server/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet-server/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet-server/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet-server/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet-server/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet-server/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet-server/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet-server/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet-server/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet-server/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet-server/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet-server/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet-server/releases{/id}","created_at":"2014-05-07T19:00:24Z","updated_at":"2015-02-24T02:02:07Z","pushed_at":"2015-02-25T14:56:57Z","git_url":"git://github.com/puppetlabs/puppet-server.git","ssh_url":"git@github.com:puppetlabs/puppet-server.git","clone_url":"https://github.com/puppetlabs/puppet-server.git","svn_url":"https://github.com/puppetlabs/puppet-server","homepage":"https://tickets.puppetlabs.com/browse/SERVER","size":5080,"stargazers_count":81,"watchers_count":81,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":8,"forks":42,"open_issues":8,"watchers":81,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/411"},"html":{"href":"https://github.com/puppetlabs/puppet-server/pull/411"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/issues/411"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/issues/411/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/411/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/411/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/statuses/1c85a1f56081a4a1a31839116106beb1f951a340"}}}}