{"action":"created","comment":{"url":"https://api.github.com/repos/MariaDB/server/pulls/comments/39607102","id":39607102,"diff_hunk":"@@ -957,7 +974,7 @@ then\n   fi\n \n   # Launch mysqld with numactl.\n-  cmd=\"$cmd numactl --interleave=all\"\n+  [ $simulate -eq 0 ] && cmd=\"$cmd numactl --interleave=all\"","path":"scripts/mysqld_safe.sh","position":127,"original_position":127,"commit_id":"c865ba457b21ee55997bb34031d8faa4f9c028ac","original_commit_id":"c865ba457b21ee55997bb34031d8faa4f9c028ac","user":{"login":"grooverdan","id":462287,"avatar_url":"https://avatars.githubusercontent.com/u/462287?v=3","gravatar_id":"","url":"https://api.github.com/users/grooverdan","html_url":"https://github.com/grooverdan","followers_url":"https://api.github.com/users/grooverdan/followers","following_url":"https://api.github.com/users/grooverdan/following{/other_user}","gists_url":"https://api.github.com/users/grooverdan/gists{/gist_id}","starred_url":"https://api.github.com/users/grooverdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grooverdan/subscriptions","organizations_url":"https://api.github.com/users/grooverdan/orgs","repos_url":"https://api.github.com/users/grooverdan/repos","events_url":"https://api.github.com/users/grooverdan/events{/privacy}","received_events_url":"https://api.github.com/users/grooverdan/received_events","type":"User","site_admin":false},"body":"The mariadb-service-convert is creating a config override file if the defaults have changed. I'd rather leave ExecStart omitted and hence refer to the default service file blank if numa_interleave isn't set.","created_at":"2015-09-16T08:56:52Z","updated_at":"2015-09-16T08:56:52Z","html_url":"https://github.com/MariaDB/server/pull/83#discussion_r39607102","pull_request_url":"https://api.github.com/repos/MariaDB/server/pulls/83","_links":{"self":{"href":"https://api.github.com/repos/MariaDB/server/pulls/comments/39607102"},"html":{"href":"https://github.com/MariaDB/server/pull/83#discussion_r39607102"},"pull_request":{"href":"https://api.github.com/repos/MariaDB/server/pulls/83"}}},"pull_request":{"url":"https://api.github.com/repos/MariaDB/server/pulls/83","id":39740830,"html_url":"https://github.com/MariaDB/server/pull/83","diff_url":"https://github.com/MariaDB/server/pull/83.diff","patch_url":"https://github.com/MariaDB/server/pull/83.patch","issue_url":"https://api.github.com/repos/MariaDB/server/issues/83","number":83,"state":"open","locked":false,"title":"Mdev 5536 Add systemd notify and socket activation capabilities to 10.1 branch","user":{"login":"grooverdan","id":462287,"avatar_url":"https://avatars.githubusercontent.com/u/462287?v=3","gravatar_id":"","url":"https://api.github.com/users/grooverdan","html_url":"https://github.com/grooverdan","followers_url":"https://api.github.com/users/grooverdan/followers","following_url":"https://api.github.com/users/grooverdan/following{/other_user}","gists_url":"https://api.github.com/users/grooverdan/gists{/gist_id}","starred_url":"https://api.github.com/users/grooverdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grooverdan/subscriptions","organizations_url":"https://api.github.com/users/grooverdan/orgs","repos_url":"https://api.github.com/users/grooverdan/repos","events_url":"https://api.github.com/users/grooverdan/events{/privacy}","received_events_url":"https://api.github.com/users/grooverdan/received_events","type":"User","site_admin":false},"body":"from all the comments in #26 I've make a 10.1 PR here as, adding dependencies on systemd libs was problematic and socket activation was invasive.\r\n\r\nAdds optional compile option WITH_SYSTEMD to provide system functions\r\n\r\nDebian and Ubuntu packages include systemd libraries as dependencies\r\n\r\nmariadb-service-convert converts the [mysqld_safe] options into an\r\nequilivent systemd file which runs mysqld directly.\r\n\r\nmariadb-socket-convert takes the [mysqld] network and socket options\r\nand creates an equalivent mariadb.socket file.\r\n\r\nSystem service file can be either Type=notify or a socket activation.\r\n\r\nCompiling with systemd does not change any previous behaviour expected\r\nof mysqld.\r\n\r\nDevelopment funded by Open Source Developers Club (Australia)","created_at":"2015-07-11T05:50:40Z","updated_at":"2015-09-16T08:56:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d9b34b6347d7acead1590b0a364b293f7b20443","assignee":{"login":"vuvova","id":2737648,"avatar_url":"https://avatars.githubusercontent.com/u/2737648?v=3","gravatar_id":"","url":"https://api.github.com/users/vuvova","html_url":"https://github.com/vuvova","followers_url":"https://api.github.com/users/vuvova/followers","following_url":"https://api.github.com/users/vuvova/following{/other_user}","gists_url":"https://api.github.com/users/vuvova/gists{/gist_id}","starred_url":"https://api.github.com/users/vuvova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuvova/subscriptions","organizations_url":"https://api.github.com/users/vuvova/orgs","repos_url":"https://api.github.com/users/vuvova/repos","events_url":"https://api.github.com/users/vuvova/events{/privacy}","received_events_url":"https://api.github.com/users/vuvova/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/MariaDB/server/pulls/83/commits","review_comments_url":"https://api.github.com/repos/MariaDB/server/pulls/83/comments","review_comment_url":"https://api.github.com/repos/MariaDB/server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MariaDB/server/issues/83/comments","statuses_url":"https://api.github.com/repos/MariaDB/server/statuses/c865ba457b21ee55997bb34031d8faa4f9c028ac","head":{"label":"openquery:MDEV-5536-systemd-socket-activation-notification-10.1_clean","ref":"MDEV-5536-systemd-socket-activation-notification-10.1_clean","sha":"c865ba457b21ee55997bb34031d8faa4f9c028ac","user":{"login":"openquery","id":454132,"avatar_url":"https://avatars.githubusercontent.com/u/454132?v=3","gravatar_id":"","url":"https://api.github.com/users/openquery","html_url":"https://github.com/openquery","followers_url":"https://api.github.com/users/openquery/followers","following_url":"https://api.github.com/users/openquery/following{/other_user}","gists_url":"https://api.github.com/users/openquery/gists{/gist_id}","starred_url":"https://api.github.com/users/openquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openquery/subscriptions","organizations_url":"https://api.github.com/users/openquery/orgs","repos_url":"https://api.github.com/users/openquery/repos","events_url":"https://api.github.com/users/openquery/events{/privacy}","received_events_url":"https://api.github.com/users/openquery/received_events","type":"Organization","site_admin":false},"repo":{"id":31842541,"name":"mariadb-server","full_name":"openquery/mariadb-server","owner":{"login":"openquery","id":454132,"avatar_url":"https://avatars.githubusercontent.com/u/454132?v=3","gravatar_id":"","url":"https://api.github.com/users/openquery","html_url":"https://github.com/openquery","followers_url":"https://api.github.com/users/openquery/followers","following_url":"https://api.github.com/users/openquery/following{/other_user}","gists_url":"https://api.github.com/users/openquery/gists{/gist_id}","starred_url":"https://api.github.com/users/openquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openquery/subscriptions","organizations_url":"https://api.github.com/users/openquery/orgs","repos_url":"https://api.github.com/users/openquery/repos","events_url":"https://api.github.com/users/openquery/events{/privacy}","received_events_url":"https://api.github.com/users/openquery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openquery/mariadb-server","description":"MariaDB server is a community developed fork of MySQL server. Started by core members of the original MySQL team, MariaDB actively works with outside developers to deliver the most featureful, stable, and sanely licensed open SQL server in the industry.","fork":true,"url":"https://api.github.com/repos/openquery/mariadb-server","forks_url":"https://api.github.com/repos/openquery/mariadb-server/forks","keys_url":"https://api.github.com/repos/openquery/mariadb-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openquery/mariadb-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openquery/mariadb-server/teams","hooks_url":"https://api.github.com/repos/openquery/mariadb-server/hooks","issue_events_url":"https://api.github.com/repos/openquery/mariadb-server/issues/events{/number}","events_url":"https://api.github.com/repos/openquery/mariadb-server/events","assignees_url":"https://api.github.com/repos/openquery/mariadb-server/assignees{/user}","branches_url":"https://api.github.com/repos/openquery/mariadb-server/branches{/branch}","tags_url":"https://api.github.com/repos/openquery/mariadb-server/tags","blobs_url":"https://api.github.com/repos/openquery/mariadb-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openquery/mariadb-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openquery/mariadb-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/openquery/mariadb-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openquery/mariadb-server/statuses/{sha}","languages_url":"https://api.github.com/repos/openquery/mariadb-server/languages","stargazers_url":"https://api.github.com/repos/openquery/mariadb-server/stargazers","contributors_url":"https://api.github.com/repos/openquery/mariadb-server/contributors","subscribers_url":"https://api.github.com/repos/openquery/mariadb-server/subscribers","subscription_url":"https://api.github.com/repos/openquery/mariadb-server/subscription","commits_url":"https://api.github.com/repos/openquery/mariadb-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/openquery/mariadb-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/openquery/mariadb-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/openquery/mariadb-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/openquery/mariadb-server/contents/{+path}","compare_url":"https://api.github.com/repos/openquery/mariadb-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openquery/mariadb-server/merges","archive_url":"https://api.github.com/repos/openquery/mariadb-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openquery/mariadb-server/downloads","issues_url":"https://api.github.com/repos/openquery/mariadb-server/issues{/number}","pulls_url":"https://api.github.com/repos/openquery/mariadb-server/pulls{/number}","milestones_url":"https://api.github.com/repos/openquery/mariadb-server/milestones{/number}","notifications_url":"https://api.github.com/repos/openquery/mariadb-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openquery/mariadb-server/labels{/name}","releases_url":"https://api.github.com/repos/openquery/mariadb-server/releases{/id}","created_at":"2015-03-08T07:53:45Z","updated_at":"2015-05-01T08:16:57Z","pushed_at":"2015-09-06T03:52:04Z","git_url":"git://github.com/openquery/mariadb-server.git","ssh_url":"git@github.com:openquery/mariadb-server.git","clone_url":"https://github.com/openquery/mariadb-server.git","svn_url":"https://github.com/openquery/mariadb-server","homepage":"","size":361894,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"10.0"}},"base":{"label":"MariaDB:10.1","ref":"10.1","sha":"a0df8225eced15c8a3a03ca0d9129badf022b34c","user":{"login":"MariaDB","id":4739304,"avatar_url":"https://avatars.githubusercontent.com/u/4739304?v=3","gravatar_id":"","url":"https://api.github.com/users/MariaDB","html_url":"https://github.com/MariaDB","followers_url":"https://api.github.com/users/MariaDB/followers","following_url":"https://api.github.com/users/MariaDB/following{/other_user}","gists_url":"https://api.github.com/users/MariaDB/gists{/gist_id}","starred_url":"https://api.github.com/users/MariaDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MariaDB/subscriptions","organizations_url":"https://api.github.com/users/MariaDB/orgs","repos_url":"https://api.github.com/users/MariaDB/repos","events_url":"https://api.github.com/users/MariaDB/events{/privacy}","received_events_url":"https://api.github.com/users/MariaDB/received_events","type":"Organization","site_admin":false},"repo":{"id":19816070,"name":"server","full_name":"MariaDB/server","owner":{"login":"MariaDB","id":4739304,"avatar_url":"https://avatars.githubusercontent.com/u/4739304?v=3","gravatar_id":"","url":"https://api.github.com/users/MariaDB","html_url":"https://github.com/MariaDB","followers_url":"https://api.github.com/users/MariaDB/followers","following_url":"https://api.github.com/users/MariaDB/following{/other_user}","gists_url":"https://api.github.com/users/MariaDB/gists{/gist_id}","starred_url":"https://api.github.com/users/MariaDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MariaDB/subscriptions","organizations_url":"https://api.github.com/users/MariaDB/orgs","repos_url":"https://api.github.com/users/MariaDB/repos","events_url":"https://api.github.com/users/MariaDB/events{/privacy}","received_events_url":"https://api.github.com/users/MariaDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MariaDB/server","description":"MariaDB server is a community developed fork of MySQL server. Started by core members of the original MySQL team, MariaDB actively works with outside developers to deliver the most featureful, stable, and sanely licensed open SQL server in the industry.","fork":false,"url":"https://api.github.com/repos/MariaDB/server","forks_url":"https://api.github.com/repos/MariaDB/server/forks","keys_url":"https://api.github.com/repos/MariaDB/server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MariaDB/server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MariaDB/server/teams","hooks_url":"https://api.github.com/repos/MariaDB/server/hooks","issue_events_url":"https://api.github.com/repos/MariaDB/server/issues/events{/number}","events_url":"https://api.github.com/repos/MariaDB/server/events","assignees_url":"https://api.github.com/repos/MariaDB/server/assignees{/user}","branches_url":"https://api.github.com/repos/MariaDB/server/branches{/branch}","tags_url":"https://api.github.com/repos/MariaDB/server/tags","blobs_url":"https://api.github.com/repos/MariaDB/server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MariaDB/server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MariaDB/server/git/refs{/sha}","trees_url":"https://api.github.com/repos/MariaDB/server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MariaDB/server/statuses/{sha}","languages_url":"https://api.github.com/repos/MariaDB/server/languages","stargazers_url":"https://api.github.com/repos/MariaDB/server/stargazers","contributors_url":"https://api.github.com/repos/MariaDB/server/contributors","subscribers_url":"https://api.github.com/repos/MariaDB/server/subscribers","subscription_url":"https://api.github.com/repos/MariaDB/server/subscription","commits_url":"https://api.github.com/repos/MariaDB/server/commits{/sha}","git_commits_url":"https://api.github.com/repos/MariaDB/server/git/commits{/sha}","comments_url":"https://api.github.com/repos/MariaDB/server/comments{/number}","issue_comment_url":"https://api.github.com/repos/MariaDB/server/issues/comments{/number}","contents_url":"https://api.github.com/repos/MariaDB/server/contents/{+path}","compare_url":"https://api.github.com/repos/MariaDB/server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MariaDB/server/merges","archive_url":"https://api.github.com/repos/MariaDB/server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MariaDB/server/downloads","issues_url":"https://api.github.com/repos/MariaDB/server/issues{/number}","pulls_url":"https://api.github.com/repos/MariaDB/server/pulls{/number}","milestones_url":"https://api.github.com/repos/MariaDB/server/milestones{/number}","notifications_url":"https://api.github.com/repos/MariaDB/server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MariaDB/server/labels{/name}","releases_url":"https://api.github.com/repos/MariaDB/server/releases{/id}","created_at":"2014-05-15T10:58:50Z","updated_at":"2015-09-15T17:05:21Z","pushed_at":"2015-09-15T22:59:50Z","git_url":"git://github.com/MariaDB/server.git","ssh_url":"git@github.com:MariaDB/server.git","clone_url":"https://github.com/MariaDB/server.git","svn_url":"https://github.com/MariaDB/server","homepage":"","size":1398699,"stargazers_count":564,"watchers_count":564,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":148,"mirror_url":null,"open_issues_count":30,"forks":148,"open_issues":30,"watchers":564,"default_branch":"10.1"}},"_links":{"self":{"href":"https://api.github.com/repos/MariaDB/server/pulls/83"},"html":{"href":"https://github.com/MariaDB/server/pull/83"},"issue":{"href":"https://api.github.com/repos/MariaDB/server/issues/83"},"comments":{"href":"https://api.github.com/repos/MariaDB/server/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/MariaDB/server/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/MariaDB/server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MariaDB/server/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/MariaDB/server/statuses/c865ba457b21ee55997bb34031d8faa4f9c028ac"}}}}