{"action":"created","issue":{"url":"https://api.github.com/repos/sonata-project/GoogleAuthenticator/issues/6","labels_url":"https://api.github.com/repos/sonata-project/GoogleAuthenticator/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/sonata-project/GoogleAuthenticator/issues/6/comments","events_url":"https://api.github.com/repos/sonata-project/GoogleAuthenticator/issues/6/events","html_url":"https://github.com/sonata-project/GoogleAuthenticator/pull/6","id":48490628,"number":6,"title":"Use issuer instead of hostname in getUrl","user":{"login":"barryvdh","id":973269,"avatar_url":"https://avatars.githubusercontent.com/u/973269?v=3","gravatar_id":"","url":"https://api.github.com/users/barryvdh","html_url":"https://github.com/barryvdh","followers_url":"https://api.github.com/users/barryvdh/followers","following_url":"https://api.github.com/users/barryvdh/following{/other_user}","gists_url":"https://api.github.com/users/barryvdh/gists{/gist_id}","starred_url":"https://api.github.com/users/barryvdh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barryvdh/subscriptions","organizations_url":"https://api.github.com/users/barryvdh/orgs","repos_url":"https://api.github.com/users/barryvdh/repos","events_url":"https://api.github.com/users/barryvdh/events{/privacy}","received_events_url":"https://api.github.com/users/barryvdh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2014-11-12T09:40:46Z","updated_at":"2015-02-19T12:50:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sonata-project/GoogleAuthenticator/pulls/6","html_url":"https://github.com/sonata-project/GoogleAuthenticator/pull/6","diff_url":"https://github.com/sonata-project/GoogleAuthenticator/pull/6.diff","patch_url":"https://github.com/sonata-project/GoogleAuthenticator/pull/6.patch"},"body":"An issuer is STRONGLY RECOMMENDED: https://code.google.com/p/google-authenticator/wiki/KeyUriFormat\r\nThe label can be an email but doesn't have to be. The hostname was a bit unexpected, and it wasn't possible to use an identifier.\r\n\r\nThis could be considered as a breaking change, but I changed the hostname to issuer. So instead of having the label username@hostname.com it will now by username, with hostname.com as issuer. That should only effect the way the app shows the token (I think)\r\n\r\nIf you were to allow a more breaking change, the issuer could be made optional as the last argument, although it is stated as strongly recommended.\r\n\r\n(An alternative would be #5 but that doesn't allow for labels other then emails)"},"comment":{"url":"https://api.github.com/repos/sonata-project/GoogleAuthenticator/issues/comments/75046728","html_url":"https://github.com/sonata-project/GoogleAuthenticator/pull/6#issuecomment-75046728","issue_url":"https://api.github.com/repos/sonata-project/GoogleAuthenticator/issues/6","id":75046728,"user":{"login":"rande","id":14672,"avatar_url":"https://avatars.githubusercontent.com/u/14672?v=3","gravatar_id":"","url":"https://api.github.com/users/rande","html_url":"https://github.com/rande","followers_url":"https://api.github.com/users/rande/followers","following_url":"https://api.github.com/users/rande/following{/other_user}","gists_url":"https://api.github.com/users/rande/gists{/gist_id}","starred_url":"https://api.github.com/users/rande/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rande/subscriptions","organizations_url":"https://api.github.com/users/rande/orgs","repos_url":"https://api.github.com/users/rande/repos","events_url":"https://api.github.com/users/rande/events{/privacy}","received_events_url":"https://api.github.com/users/rande/received_events","type":"User","site_admin":false},"created_at":"2015-02-19T12:50:53Z","updated_at":"2015-02-19T12:50:53Z","body":"@barryvdh this code does not seems to be BC"}}