{"action":"created","issue":{"url":"https://api.github.com/repos/shazow/urllib3/issues/345","labels_url":"https://api.github.com/repos/shazow/urllib3/issues/345/labels{/name}","comments_url":"https://api.github.com/repos/shazow/urllib3/issues/345/comments","events_url":"https://api.github.com/repos/shazow/urllib3/issues/345/events","html_url":"https://github.com/shazow/urllib3/issues/345","id":28357530,"number":345,"title":"Automatically detecting non-relative imports","user":{"login":"kevinburke","id":234019,"avatar_url":"https://avatars.githubusercontent.com/u/234019?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinburke","html_url":"https://github.com/kevinburke","followers_url":"https://api.github.com/users/kevinburke/followers","following_url":"https://api.github.com/users/kevinburke/following{/other_user}","gists_url":"https://api.github.com/users/kevinburke/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinburke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinburke/subscriptions","organizations_url":"https://api.github.com/users/kevinburke/orgs","repos_url":"https://api.github.com/users/kevinburke/repos","events_url":"https://api.github.com/users/kevinburke/events{/privacy}","received_events_url":"https://api.github.com/users/kevinburke/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2014-02-26T18:37:09Z","updated_at":"2015-10-21T05:31:06Z","closed_at":"2014-02-26T19:09:02Z","body":"Lately there was an issue with a non-relative import breaking pip's vendoring of urllib3. I was wondering if we can add an automated check for a non-relative import that would break vendoring.\r\n\r\nI tried adding this to tox.ini\r\n\r\n```\r\negrep -R \"^(\\s+)from urllib3|^(\\s+)import urllib3\" urllib3\r\n```\r\n\r\nHowever this matches a false positive in pyopenssl.py, sadly.\r\n\r\nWondering if there's a best practice here or something we can do."},"comment":{"url":"https://api.github.com/repos/shazow/urllib3/issues/comments/149787968","html_url":"https://github.com/shazow/urllib3/issues/345#issuecomment-149787968","issue_url":"https://api.github.com/repos/shazow/urllib3/issues/345","id":149787968,"user":{"login":"jayvdb","id":15092,"avatar_url":"https://avatars.githubusercontent.com/u/15092?v=3","gravatar_id":"","url":"https://api.github.com/users/jayvdb","html_url":"https://github.com/jayvdb","followers_url":"https://api.github.com/users/jayvdb/followers","following_url":"https://api.github.com/users/jayvdb/following{/other_user}","gists_url":"https://api.github.com/users/jayvdb/gists{/gist_id}","starred_url":"https://api.github.com/users/jayvdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayvdb/subscriptions","organizations_url":"https://api.github.com/users/jayvdb/orgs","repos_url":"https://api.github.com/users/jayvdb/repos","events_url":"https://api.github.com/users/jayvdb/events{/privacy}","received_events_url":"https://api.github.com/users/jayvdb/received_events","type":"User","site_admin":false},"created_at":"2015-10-21T05:31:06Z","updated_at":"2015-10-21T05:31:06Z","body":"fwiw, this will be achieved by https://github.com/shazow/urllib3/pull/398"}}