{"action":"created","issue":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/2220","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/2220/labels{/name}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/2220/comments","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/2220/events","html_url":"https://github.com/mapbox/mapbox-gl-native/pull/2220","id":104258592,"number":2220,"title":"Feature/logo attributions icon","user":{"login":"tobrun","id":2151639,"avatar_url":"https://avatars.githubusercontent.com/u/2151639?v=3","gravatar_id":"","url":"https://api.github.com/users/tobrun","html_url":"https://github.com/tobrun","followers_url":"https://api.github.com/users/tobrun/followers","following_url":"https://api.github.com/users/tobrun/following{/other_user}","gists_url":"https://api.github.com/users/tobrun/gists{/gist_id}","starred_url":"https://api.github.com/users/tobrun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobrun/subscriptions","organizations_url":"https://api.github.com/users/tobrun/orgs","repos_url":"https://api.github.com/users/tobrun/repos","events_url":"https://api.github.com/users/tobrun/events{/privacy}","received_events_url":"https://api.github.com/users/tobrun/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels/Android","name":"Android","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/milestones/6","html_url":"https://github.com/mapbox/mapbox-gl-native/milestones/android-v0.1.0","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/milestones/6/labels","id":982241,"number":6,"title":"android-v0.1.0","description":"","creator":{"login":"ljbade","id":1215089,"avatar_url":"https://avatars.githubusercontent.com/u/1215089?v=3","gravatar_id":"","url":"https://api.github.com/users/ljbade","html_url":"https://github.com/ljbade","followers_url":"https://api.github.com/users/ljbade/followers","following_url":"https://api.github.com/users/ljbade/following{/other_user}","gists_url":"https://api.github.com/users/ljbade/gists{/gist_id}","starred_url":"https://api.github.com/users/ljbade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljbade/subscriptions","organizations_url":"https://api.github.com/users/ljbade/orgs","repos_url":"https://api.github.com/users/ljbade/repos","events_url":"https://api.github.com/users/ljbade/events{/privacy}","received_events_url":"https://api.github.com/users/ljbade/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":125,"state":"open","created_at":"2015-02-17T02:38:50Z","updated_at":"2015-09-04T17:39:25Z","due_on":"2015-09-04T07:00:00Z","closed_at":null},"comments":9,"created_at":"2015-09-01T12:50:31Z","updated_at":"2015-09-05T14:37:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/2220","html_url":"https://github.com/mapbox/mapbox-gl-native/pull/2220","diff_url":"https://github.com/mapbox/mapbox-gl-native/pull/2220.diff","patch_url":"https://github.com/mapbox/mapbox-gl-native/pull/2220.patch"},"body":"As discussed in #2074 \r\n\r\nNotes:\r\n- I'm using Drawable tinting from support library using ColorStateList for attribution control. Currently their is a [bug](https://code.google.com/p/android/issues/detail?id=172067) in support library not showing the pressed state for Lollipop and higher. \r\n\r\n- Dialog for attribution control is not styled\r\n"},"comment":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/comments/137960680","html_url":"https://github.com/mapbox/mapbox-gl-native/pull/2220#issuecomment-137960680","issue_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/2220","id":137960680,"user":{"login":"tobrun","id":2151639,"avatar_url":"https://avatars.githubusercontent.com/u/2151639?v=3","gravatar_id":"","url":"https://api.github.com/users/tobrun","html_url":"https://github.com/tobrun","followers_url":"https://api.github.com/users/tobrun/followers","following_url":"https://api.github.com/users/tobrun/following{/other_user}","gists_url":"https://api.github.com/users/tobrun/gists{/gist_id}","starred_url":"https://api.github.com/users/tobrun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobrun/subscriptions","organizations_url":"https://api.github.com/users/tobrun/orgs","repos_url":"https://api.github.com/users/tobrun/repos","events_url":"https://api.github.com/users/tobrun/events{/privacy}","received_events_url":"https://api.github.com/users/tobrun/received_events","type":"User","site_admin":false},"created_at":"2015-09-05T14:37:45Z","updated_at":"2015-09-05T14:37:45Z","body":"@bleege thanks for the feedback and testing out the PR.  \r\n\r\nI find it a bit odd, Lint did not show any min.Sdk warning.. Will verify this, and if true will open an ticket at google's issue tracker. \r\n\r\nI will be migrating away from ColorStateList. Besides that it is [broken](https://code.google.com/p/android/issues/detail?id=172067) it is also not completely backward compatible without doing it ourselves. I will add the same 'fixed-color' blue icon as on iOS. \r\n\r\nThe whole setup behind current ColorStateList setup was that the attribution control would be automatically tinted in colors from the users theme. They would be able to apply an own theme tag in xml if they wanted to override the colors from their own theme. I will be on the lookout if something changes in this space. \r\n\r\nPersonal reminder: do regression test on older platforms before submitting a PR.\r\nThanks again for looking at PR, glad this was spotted before merging!  \r\n\r\n\r\n\r\n\r\n\r\n\r\n "}}