{"action":"closed","number":30,"pull_request":{"url":"https://api.github.com/repos/HiSPARC/pysparc/pulls/30","id":45654034,"html_url":"https://github.com/HiSPARC/pysparc/pull/30","diff_url":"https://github.com/HiSPARC/pysparc/pull/30.diff","patch_url":"https://github.com/HiSPARC/pysparc/pull/30.patch","issue_url":"https://api.github.com/repos/HiSPARC/pysparc/issues/30","number":30,"state":"closed","locked":false,"title":"Update std_dev to use same units as LabView DAQ","user":{"login":"153957","id":1433682,"avatar_url":"https://avatars.githubusercontent.com/u/1433682?v=3","gravatar_id":"","url":"https://api.github.com/users/153957","html_url":"https://github.com/153957","followers_url":"https://api.github.com/users/153957/followers","following_url":"https://api.github.com/users/153957/following{/other_user}","gists_url":"https://api.github.com/users/153957/gists{/gist_id}","starred_url":"https://api.github.com/users/153957/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/153957/subscriptions","organizations_url":"https://api.github.com/users/153957/orgs","repos_url":"https://api.github.com/users/153957/repos","events_url":"https://api.github.com/users/153957/events{/privacy}","received_events_url":"https://api.github.com/users/153957/received_events","type":"User","site_admin":false},"body":"Make std_dev units of milli ADC counts, to match the output from the HiSPARC DAQ (LabView):\r\nhttps://github.com/jorianvo/HISPARC_baseline/blob/master/project/Baseline/src/intern.c#L164-L167\r\n\r\nPySPARC stddev is typically 1-2 ADC counts, while for the HiSPARC DAQ typical values are 600-1300 milli ADC counts. Maybe we do not need that many digits for the stddev but for consistency it would be better to keep the units the same.","created_at":"2015-09-22T11:52:36Z","updated_at":"2015-10-04T20:48:56Z","closed_at":"2015-10-04T20:48:56Z","merged_at":"2015-10-04T20:48:56Z","merge_commit_sha":"20dab24ea19b8a3cb6f8fa0f41244ff483933368","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/HiSPARC/pysparc/pulls/30/commits","review_comments_url":"https://api.github.com/repos/HiSPARC/pysparc/pulls/30/comments","review_comment_url":"https://api.github.com/repos/HiSPARC/pysparc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HiSPARC/pysparc/issues/30/comments","statuses_url":"https://api.github.com/repos/HiSPARC/pysparc/statuses/b4f9ffb25c6d8d8f39fe2ff14ce9b9a901ab0b54","head":{"label":"HiSPARC:std_dev-units","ref":"std_dev-units","sha":"b4f9ffb25c6d8d8f39fe2ff14ce9b9a901ab0b54","user":{"login":"HiSPARC","id":1443119,"avatar_url":"https://avatars.githubusercontent.com/u/1443119?v=3","gravatar_id":"","url":"https://api.github.com/users/HiSPARC","html_url":"https://github.com/HiSPARC","followers_url":"https://api.github.com/users/HiSPARC/followers","following_url":"https://api.github.com/users/HiSPARC/following{/other_user}","gists_url":"https://api.github.com/users/HiSPARC/gists{/gist_id}","starred_url":"https://api.github.com/users/HiSPARC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HiSPARC/subscriptions","organizations_url":"https://api.github.com/users/HiSPARC/orgs","repos_url":"https://api.github.com/users/HiSPARC/repos","events_url":"https://api.github.com/users/HiSPARC/events{/privacy}","received_events_url":"https://api.github.com/users/HiSPARC/received_events","type":"Organization","site_admin":false},"repo":{"id":4635510,"name":"pysparc","full_name":"HiSPARC/pysparc","owner":{"login":"HiSPARC","id":1443119,"avatar_url":"https://avatars.githubusercontent.com/u/1443119?v=3","gravatar_id":"","url":"https://api.github.com/users/HiSPARC","html_url":"https://github.com/HiSPARC","followers_url":"https://api.github.com/users/HiSPARC/followers","following_url":"https://api.github.com/users/HiSPARC/following{/other_user}","gists_url":"https://api.github.com/users/HiSPARC/gists{/gist_id}","starred_url":"https://api.github.com/users/HiSPARC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HiSPARC/subscriptions","organizations_url":"https://api.github.com/users/HiSPARC/orgs","repos_url":"https://api.github.com/users/HiSPARC/repos","events_url":"https://api.github.com/users/HiSPARC/events{/privacy}","received_events_url":"https://api.github.com/users/HiSPARC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HiSPARC/pysparc","description":"HiSPARC DAQ implemented in Python","fork":false,"url":"https://api.github.com/repos/HiSPARC/pysparc","forks_url":"https://api.github.com/repos/HiSPARC/pysparc/forks","keys_url":"https://api.github.com/repos/HiSPARC/pysparc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HiSPARC/pysparc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HiSPARC/pysparc/teams","hooks_url":"https://api.github.com/repos/HiSPARC/pysparc/hooks","issue_events_url":"https://api.github.com/repos/HiSPARC/pysparc/issues/events{/number}","events_url":"https://api.github.com/repos/HiSPARC/pysparc/events","assignees_url":"https://api.github.com/repos/HiSPARC/pysparc/assignees{/user}","branches_url":"https://api.github.com/repos/HiSPARC/pysparc/branches{/branch}","tags_url":"https://api.github.com/repos/HiSPARC/pysparc/tags","blobs_url":"https://api.github.com/repos/HiSPARC/pysparc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HiSPARC/pysparc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HiSPARC/pysparc/git/refs{/sha}","trees_url":"https://api.github.com/repos/HiSPARC/pysparc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HiSPARC/pysparc/statuses/{sha}","languages_url":"https://api.github.com/repos/HiSPARC/pysparc/languages","stargazers_url":"https://api.github.com/repos/HiSPARC/pysparc/stargazers","contributors_url":"https://api.github.com/repos/HiSPARC/pysparc/contributors","subscribers_url":"https://api.github.com/repos/HiSPARC/pysparc/subscribers","subscription_url":"https://api.github.com/repos/HiSPARC/pysparc/subscription","commits_url":"https://api.github.com/repos/HiSPARC/pysparc/commits{/sha}","git_commits_url":"https://api.github.com/repos/HiSPARC/pysparc/git/commits{/sha}","comments_url":"https://api.github.com/repos/HiSPARC/pysparc/comments{/number}","issue_comment_url":"https://api.github.com/repos/HiSPARC/pysparc/issues/comments{/number}","contents_url":"https://api.github.com/repos/HiSPARC/pysparc/contents/{+path}","compare_url":"https://api.github.com/repos/HiSPARC/pysparc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HiSPARC/pysparc/merges","archive_url":"https://api.github.com/repos/HiSPARC/pysparc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HiSPARC/pysparc/downloads","issues_url":"https://api.github.com/repos/HiSPARC/pysparc/issues{/number}","pulls_url":"https://api.github.com/repos/HiSPARC/pysparc/pulls{/number}","milestones_url":"https://api.github.com/repos/HiSPARC/pysparc/milestones{/number}","notifications_url":"https://api.github.com/repos/HiSPARC/pysparc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HiSPARC/pysparc/labels{/name}","releases_url":"https://api.github.com/repos/HiSPARC/pysparc/releases{/id}","created_at":"2012-06-12T09:28:26Z","updated_at":"2015-04-20T09:30:33Z","pushed_at":"2015-10-04T20:48:56Z","git_url":"git://github.com/HiSPARC/pysparc.git","ssh_url":"git@github.com:HiSPARC/pysparc.git","clone_url":"https://github.com/HiSPARC/pysparc.git","svn_url":"https://github.com/HiSPARC/pysparc","homepage":null,"size":1175,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":11,"forks":0,"open_issues":11,"watchers":3,"default_branch":"master"}},"base":{"label":"HiSPARC:master","ref":"master","sha":"ced06268052cff22424b9479608ab3adce25a59b","user":{"login":"HiSPARC","id":1443119,"avatar_url":"https://avatars.githubusercontent.com/u/1443119?v=3","gravatar_id":"","url":"https://api.github.com/users/HiSPARC","html_url":"https://github.com/HiSPARC","followers_url":"https://api.github.com/users/HiSPARC/followers","following_url":"https://api.github.com/users/HiSPARC/following{/other_user}","gists_url":"https://api.github.com/users/HiSPARC/gists{/gist_id}","starred_url":"https://api.github.com/users/HiSPARC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HiSPARC/subscriptions","organizations_url":"https://api.github.com/users/HiSPARC/orgs","repos_url":"https://api.github.com/users/HiSPARC/repos","events_url":"https://api.github.com/users/HiSPARC/events{/privacy}","received_events_url":"https://api.github.com/users/HiSPARC/received_events","type":"Organization","site_admin":false},"repo":{"id":4635510,"name":"pysparc","full_name":"HiSPARC/pysparc","owner":{"login":"HiSPARC","id":1443119,"avatar_url":"https://avatars.githubusercontent.com/u/1443119?v=3","gravatar_id":"","url":"https://api.github.com/users/HiSPARC","html_url":"https://github.com/HiSPARC","followers_url":"https://api.github.com/users/HiSPARC/followers","following_url":"https://api.github.com/users/HiSPARC/following{/other_user}","gists_url":"https://api.github.com/users/HiSPARC/gists{/gist_id}","starred_url":"https://api.github.com/users/HiSPARC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HiSPARC/subscriptions","organizations_url":"https://api.github.com/users/HiSPARC/orgs","repos_url":"https://api.github.com/users/HiSPARC/repos","events_url":"https://api.github.com/users/HiSPARC/events{/privacy}","received_events_url":"https://api.github.com/users/HiSPARC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HiSPARC/pysparc","description":"HiSPARC DAQ implemented in Python","fork":false,"url":"https://api.github.com/repos/HiSPARC/pysparc","forks_url":"https://api.github.com/repos/HiSPARC/pysparc/forks","keys_url":"https://api.github.com/repos/HiSPARC/pysparc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HiSPARC/pysparc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HiSPARC/pysparc/teams","hooks_url":"https://api.github.com/repos/HiSPARC/pysparc/hooks","issue_events_url":"https://api.github.com/repos/HiSPARC/pysparc/issues/events{/number}","events_url":"https://api.github.com/repos/HiSPARC/pysparc/events","assignees_url":"https://api.github.com/repos/HiSPARC/pysparc/assignees{/user}","branches_url":"https://api.github.com/repos/HiSPARC/pysparc/branches{/branch}","tags_url":"https://api.github.com/repos/HiSPARC/pysparc/tags","blobs_url":"https://api.github.com/repos/HiSPARC/pysparc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HiSPARC/pysparc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HiSPARC/pysparc/git/refs{/sha}","trees_url":"https://api.github.com/repos/HiSPARC/pysparc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HiSPARC/pysparc/statuses/{sha}","languages_url":"https://api.github.com/repos/HiSPARC/pysparc/languages","stargazers_url":"https://api.github.com/repos/HiSPARC/pysparc/stargazers","contributors_url":"https://api.github.com/repos/HiSPARC/pysparc/contributors","subscribers_url":"https://api.github.com/repos/HiSPARC/pysparc/subscribers","subscription_url":"https://api.github.com/repos/HiSPARC/pysparc/subscription","commits_url":"https://api.github.com/repos/HiSPARC/pysparc/commits{/sha}","git_commits_url":"https://api.github.com/repos/HiSPARC/pysparc/git/commits{/sha}","comments_url":"https://api.github.com/repos/HiSPARC/pysparc/comments{/number}","issue_comment_url":"https://api.github.com/repos/HiSPARC/pysparc/issues/comments{/number}","contents_url":"https://api.github.com/repos/HiSPARC/pysparc/contents/{+path}","compare_url":"https://api.github.com/repos/HiSPARC/pysparc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HiSPARC/pysparc/merges","archive_url":"https://api.github.com/repos/HiSPARC/pysparc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HiSPARC/pysparc/downloads","issues_url":"https://api.github.com/repos/HiSPARC/pysparc/issues{/number}","pulls_url":"https://api.github.com/repos/HiSPARC/pysparc/pulls{/number}","milestones_url":"https://api.github.com/repos/HiSPARC/pysparc/milestones{/number}","notifications_url":"https://api.github.com/repos/HiSPARC/pysparc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HiSPARC/pysparc/labels{/name}","releases_url":"https://api.github.com/repos/HiSPARC/pysparc/releases{/id}","created_at":"2012-06-12T09:28:26Z","updated_at":"2015-04-20T09:30:33Z","pushed_at":"2015-10-04T20:48:56Z","git_url":"git://github.com/HiSPARC/pysparc.git","ssh_url":"git@github.com:HiSPARC/pysparc.git","clone_url":"https://github.com/HiSPARC/pysparc.git","svn_url":"https://github.com/HiSPARC/pysparc","homepage":null,"size":1175,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":11,"forks":0,"open_issues":11,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HiSPARC/pysparc/pulls/30"},"html":{"href":"https://github.com/HiSPARC/pysparc/pull/30"},"issue":{"href":"https://api.github.com/repos/HiSPARC/pysparc/issues/30"},"comments":{"href":"https://api.github.com/repos/HiSPARC/pysparc/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/HiSPARC/pysparc/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/HiSPARC/pysparc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HiSPARC/pysparc/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/HiSPARC/pysparc/statuses/b4f9ffb25c6d8d8f39fe2ff14ce9b9a901ab0b54"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"153957","id":1433682,"avatar_url":"https://avatars.githubusercontent.com/u/1433682?v=3","gravatar_id":"","url":"https://api.github.com/users/153957","html_url":"https://github.com/153957","followers_url":"https://api.github.com/users/153957/followers","following_url":"https://api.github.com/users/153957/following{/other_user}","gists_url":"https://api.github.com/users/153957/gists{/gist_id}","starred_url":"https://api.github.com/users/153957/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/153957/subscriptions","organizations_url":"https://api.github.com/users/153957/orgs","repos_url":"https://api.github.com/users/153957/repos","events_url":"https://api.github.com/users/153957/events{/privacy}","received_events_url":"https://api.github.com/users/153957/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}