{"comment":{"url":"https://api.github.com/repos/kasper93/mpc-hc/comments/9451174","html_url":"https://github.com/kasper93/mpc-hc/commit/4cd98589aeb8e6827654458e33ef2a15d758ad84#commitcomment-9451174","id":9451174,"user":{"login":"kasper93","id":1126053,"avatar_url":"https://avatars.githubusercontent.com/u/1126053?v=3","gravatar_id":"","url":"https://api.github.com/users/kasper93","html_url":"https://github.com/kasper93","followers_url":"https://api.github.com/users/kasper93/followers","following_url":"https://api.github.com/users/kasper93/following{/other_user}","gists_url":"https://api.github.com/users/kasper93/gists{/gist_id}","starred_url":"https://api.github.com/users/kasper93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kasper93/subscriptions","organizations_url":"https://api.github.com/users/kasper93/orgs","repos_url":"https://api.github.com/users/kasper93/repos","events_url":"https://api.github.com/users/kasper93/events{/privacy}","received_events_url":"https://api.github.com/users/kasper93/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"4cd98589aeb8e6827654458e33ef2a15d758ad84","created_at":"2015-01-27T00:58:27Z","updated_at":"2015-01-27T00:58:27Z","body":"@Underground78: Addnotialy we have a bug in `version.sh` for LAV. And it updates the file every time and triggers compilation while it shouldn't \r\n\r\n``` diff\r\ndiff --git a/common/version.sh b/common/version.sh\r\nindex 83ee404..cee087d 100644\r\n--- a/common/version.sh\r\n+++ b/common/version.sh\r\n@@ -58,7 +58,7 @@ else\r\n   fi\r\n fi\r\n \r\n-version_info+=\"#define LAV_VERSION_BUILD $ver\"$'\\n'\r\n+version_info+=\"#define LAV_VERSION_BUILD $ver\"\r\n \r\n # Update version_rev.h if it does not exist, or if version information was changed.\r\n if [[ ! -f \"$versionfile\" ]] || [[ \"$version_info\" != \"$(<\"$versionfile\")\" ]]; then\r\n```"}}