{"action":"created","comment":{"url":"https://api.github.com/repos/windup/windup/pulls/comments/26498219","id":26498219,"diff_hunk":"@@ -0,0 +1,30 @@\n+package org.jboss.windup.config.parser.metadata;\n+\n+import org.apache.commons.lang.StringUtils;\n+import org.jboss.forge.furnace.addons.AddonId;\n+import org.jboss.windup.config.exception.ConfigurationException;\n+import org.jboss.windup.config.parser.ElementHandler;\n+import org.jboss.windup.config.parser.NamespaceElementHandler;\n+import org.jboss.windup.config.parser.ParserContext;\n+import org.w3c.dom.Element;\n+\n+@NamespaceElementHandler(elementName = \"addon\", namespace = \"http://windup.jboss.org/v1/xml\")\n+public class MetadataDependencyAddon implements ElementHandler<AddonId>\n+{\n+    private static String ID=\"id\";\n+    @Override\n+    public AddonId processElement(ParserContext handlerManager, Element element) throws ConfigurationException\n+    {\n+        String id = element.getAttribute(ID);\n+        if (!StringUtils.isBlank(id))","path":"config-xml/addon/src/main/java/org/jboss/windup/config/parser/metadata/MetadataDependencyAddon.java","position":19,"original_position":19,"commit_id":"1b77e038d18906e86f937413760a9fe21e390238","original_commit_id":"1b77e038d18906e86f937413760a9fe21e390238","user":{"login":"lincolnthree","id":362329,"avatar_url":"https://avatars.githubusercontent.com/u/362329?v=3","gravatar_id":"","url":"https://api.github.com/users/lincolnthree","html_url":"https://github.com/lincolnthree","followers_url":"https://api.github.com/users/lincolnthree/followers","following_url":"https://api.github.com/users/lincolnthree/following{/other_user}","gists_url":"https://api.github.com/users/lincolnthree/gists{/gist_id}","starred_url":"https://api.github.com/users/lincolnthree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lincolnthree/subscriptions","organizations_url":"https://api.github.com/users/lincolnthree/orgs","repos_url":"https://api.github.com/users/lincolnthree/repos","events_url":"https://api.github.com/users/lincolnthree/events{/privacy}","received_events_url":"https://api.github.com/users/lincolnthree/received_events","type":"User","site_admin":false},"body":"Need to throw a validation exception if this value is missing. (Like our existing handlers.)","created_at":"2015-03-16T15:57:44Z","updated_at":"2015-03-16T15:57:44Z","html_url":"https://github.com/windup/windup/pull/496#discussion_r26498219","pull_request_url":"https://api.github.com/repos/windup/windup/pulls/496","_links":{"self":{"href":"https://api.github.com/repos/windup/windup/pulls/comments/26498219"},"html":{"href":"https://github.com/windup/windup/pull/496#discussion_r26498219"},"pull_request":{"href":"https://api.github.com/repos/windup/windup/pulls/496"}}},"pull_request":{"url":"https://api.github.com/repos/windup/windup/pulls/496","id":31031461,"html_url":"https://github.com/windup/windup/pull/496","diff_url":"https://github.com/windup/windup/pull/496.diff","patch_url":"https://github.com/windup/windup/pull/496.patch","issue_url":"https://api.github.com/repos/windup/windup/issues/496","number":496,"state":"open","locked":false,"title":"WINDUP-521: Rule Externalization - Create XML Handlers for Rule metadata","user":{"login":"mbriskar","id":1478315,"avatar_url":"https://avatars.githubusercontent.com/u/1478315?v=3","gravatar_id":"","url":"https://api.github.com/users/mbriskar","html_url":"https://github.com/mbriskar","followers_url":"https://api.github.com/users/mbriskar/followers","following_url":"https://api.github.com/users/mbriskar/following{/other_user}","gists_url":"https://api.github.com/users/mbriskar/gists{/gist_id}","starred_url":"https://api.github.com/users/mbriskar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbriskar/subscriptions","organizations_url":"https://api.github.com/users/mbriskar/orgs","repos_url":"https://api.github.com/users/mbriskar/repos","events_url":"https://api.github.com/users/mbriskar/events{/privacy}","received_events_url":"https://api.github.com/users/mbriskar/received_events","type":"User","site_admin":false},"body":"This PR is not complicated. I have created one MetadataRootHandler that covers all the metadata processing using the subhandlers and after each processment fills the MetadataBuilder with the processed information. The structure was followed from https://issues.jboss.org/browse/WINDUP-521 except the versionRange to be not optional but compulsory (at least for now)","created_at":"2015-03-12T12:35:29Z","updated_at":"2015-03-16T15:57:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61bec6b7969a128835beacffa9d97de6ef1b57f9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/windup/windup/pulls/496/commits","review_comments_url":"https://api.github.com/repos/windup/windup/pulls/496/comments","review_comment_url":"https://api.github.com/repos/windup/windup/pulls/comments{/number}","comments_url":"https://api.github.com/repos/windup/windup/issues/496/comments","statuses_url":"https://api.github.com/repos/windup/windup/statuses/1b77e038d18906e86f937413760a9fe21e390238","head":{"label":"mbriskar:Metadate_XML","ref":"Metadate_XML","sha":"1b77e038d18906e86f937413760a9fe21e390238","user":{"login":"mbriskar","id":1478315,"avatar_url":"https://avatars.githubusercontent.com/u/1478315?v=3","gravatar_id":"","url":"https://api.github.com/users/mbriskar","html_url":"https://github.com/mbriskar","followers_url":"https://api.github.com/users/mbriskar/followers","following_url":"https://api.github.com/users/mbriskar/following{/other_user}","gists_url":"https://api.github.com/users/mbriskar/gists{/gist_id}","starred_url":"https://api.github.com/users/mbriskar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbriskar/subscriptions","organizations_url":"https://api.github.com/users/mbriskar/orgs","repos_url":"https://api.github.com/users/mbriskar/repos","events_url":"https://api.github.com/users/mbriskar/events{/privacy}","received_events_url":"https://api.github.com/users/mbriskar/received_events","type":"User","site_admin":false},"repo":{"id":21489235,"name":"windup","full_name":"mbriskar/windup","owner":{"login":"mbriskar","id":1478315,"avatar_url":"https://avatars.githubusercontent.com/u/1478315?v=3","gravatar_id":"","url":"https://api.github.com/users/mbriskar","html_url":"https://github.com/mbriskar","followers_url":"https://api.github.com/users/mbriskar/followers","following_url":"https://api.github.com/users/mbriskar/following{/other_user}","gists_url":"https://api.github.com/users/mbriskar/gists{/gist_id}","starred_url":"https://api.github.com/users/mbriskar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbriskar/subscriptions","organizations_url":"https://api.github.com/users/mbriskar/orgs","repos_url":"https://api.github.com/users/mbriskar/repos","events_url":"https://api.github.com/users/mbriskar/events{/privacy}","received_events_url":"https://api.github.com/users/mbriskar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mbriskar/windup","description":"Windup","fork":true,"url":"https://api.github.com/repos/mbriskar/windup","forks_url":"https://api.github.com/repos/mbriskar/windup/forks","keys_url":"https://api.github.com/repos/mbriskar/windup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbriskar/windup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbriskar/windup/teams","hooks_url":"https://api.github.com/repos/mbriskar/windup/hooks","issue_events_url":"https://api.github.com/repos/mbriskar/windup/issues/events{/number}","events_url":"https://api.github.com/repos/mbriskar/windup/events","assignees_url":"https://api.github.com/repos/mbriskar/windup/assignees{/user}","branches_url":"https://api.github.com/repos/mbriskar/windup/branches{/branch}","tags_url":"https://api.github.com/repos/mbriskar/windup/tags","blobs_url":"https://api.github.com/repos/mbriskar/windup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbriskar/windup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbriskar/windup/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbriskar/windup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbriskar/windup/statuses/{sha}","languages_url":"https://api.github.com/repos/mbriskar/windup/languages","stargazers_url":"https://api.github.com/repos/mbriskar/windup/stargazers","contributors_url":"https://api.github.com/repos/mbriskar/windup/contributors","subscribers_url":"https://api.github.com/repos/mbriskar/windup/subscribers","subscription_url":"https://api.github.com/repos/mbriskar/windup/subscription","commits_url":"https://api.github.com/repos/mbriskar/windup/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbriskar/windup/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbriskar/windup/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbriskar/windup/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbriskar/windup/contents/{+path}","compare_url":"https://api.github.com/repos/mbriskar/windup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbriskar/windup/merges","archive_url":"https://api.github.com/repos/mbriskar/windup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbriskar/windup/downloads","issues_url":"https://api.github.com/repos/mbriskar/windup/issues{/number}","pulls_url":"https://api.github.com/repos/mbriskar/windup/pulls{/number}","milestones_url":"https://api.github.com/repos/mbriskar/windup/milestones{/number}","notifications_url":"https://api.github.com/repos/mbriskar/windup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbriskar/windup/labels{/name}","releases_url":"https://api.github.com/repos/mbriskar/windup/releases{/id}","created_at":"2014-07-04T07:36:58Z","updated_at":"2015-02-19T16:05:50Z","pushed_at":"2015-03-12T16:02:09Z","git_url":"git://github.com/mbriskar/windup.git","ssh_url":"git@github.com:mbriskar/windup.git","clone_url":"https://github.com/mbriskar/windup.git","svn_url":"https://github.com/mbriskar/windup","homepage":null,"size":34826,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"windup:master","ref":"master","sha":"21a3d9cf6626537e0eff58c9838bb03d700c2f1c","user":{"login":"windup","id":4266383,"avatar_url":"https://avatars.githubusercontent.com/u/4266383?v=3","gravatar_id":"","url":"https://api.github.com/users/windup","html_url":"https://github.com/windup","followers_url":"https://api.github.com/users/windup/followers","following_url":"https://api.github.com/users/windup/following{/other_user}","gists_url":"https://api.github.com/users/windup/gists{/gist_id}","starred_url":"https://api.github.com/users/windup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windup/subscriptions","organizations_url":"https://api.github.com/users/windup/orgs","repos_url":"https://api.github.com/users/windup/repos","events_url":"https://api.github.com/users/windup/events{/privacy}","received_events_url":"https://api.github.com/users/windup/received_events","type":"Organization","site_admin":false},"repo":{"id":9702026,"name":"windup","full_name":"windup/windup","owner":{"login":"windup","id":4266383,"avatar_url":"https://avatars.githubusercontent.com/u/4266383?v=3","gravatar_id":"","url":"https://api.github.com/users/windup","html_url":"https://github.com/windup","followers_url":"https://api.github.com/users/windup/followers","following_url":"https://api.github.com/users/windup/following{/other_user}","gists_url":"https://api.github.com/users/windup/gists{/gist_id}","starred_url":"https://api.github.com/users/windup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windup/subscriptions","organizations_url":"https://api.github.com/users/windup/orgs","repos_url":"https://api.github.com/users/windup/repos","events_url":"https://api.github.com/users/windup/events{/privacy}","received_events_url":"https://api.github.com/users/windup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/windup/windup","description":"Windup - JBoss Automated Migration Tool","fork":false,"url":"https://api.github.com/repos/windup/windup","forks_url":"https://api.github.com/repos/windup/windup/forks","keys_url":"https://api.github.com/repos/windup/windup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/windup/windup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/windup/windup/teams","hooks_url":"https://api.github.com/repos/windup/windup/hooks","issue_events_url":"https://api.github.com/repos/windup/windup/issues/events{/number}","events_url":"https://api.github.com/repos/windup/windup/events","assignees_url":"https://api.github.com/repos/windup/windup/assignees{/user}","branches_url":"https://api.github.com/repos/windup/windup/branches{/branch}","tags_url":"https://api.github.com/repos/windup/windup/tags","blobs_url":"https://api.github.com/repos/windup/windup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/windup/windup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/windup/windup/git/refs{/sha}","trees_url":"https://api.github.com/repos/windup/windup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/windup/windup/statuses/{sha}","languages_url":"https://api.github.com/repos/windup/windup/languages","stargazers_url":"https://api.github.com/repos/windup/windup/stargazers","contributors_url":"https://api.github.com/repos/windup/windup/contributors","subscribers_url":"https://api.github.com/repos/windup/windup/subscribers","subscription_url":"https://api.github.com/repos/windup/windup/subscription","commits_url":"https://api.github.com/repos/windup/windup/commits{/sha}","git_commits_url":"https://api.github.com/repos/windup/windup/git/commits{/sha}","comments_url":"https://api.github.com/repos/windup/windup/comments{/number}","issue_comment_url":"https://api.github.com/repos/windup/windup/issues/comments{/number}","contents_url":"https://api.github.com/repos/windup/windup/contents/{+path}","compare_url":"https://api.github.com/repos/windup/windup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/windup/windup/merges","archive_url":"https://api.github.com/repos/windup/windup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/windup/windup/downloads","issues_url":"https://api.github.com/repos/windup/windup/issues{/number}","pulls_url":"https://api.github.com/repos/windup/windup/pulls{/number}","milestones_url":"https://api.github.com/repos/windup/windup/milestones{/number}","notifications_url":"https://api.github.com/repos/windup/windup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/windup/windup/labels{/name}","releases_url":"https://api.github.com/repos/windup/windup/releases{/id}","created_at":"2013-04-26T18:52:08Z","updated_at":"2015-03-16T15:52:55Z","pushed_at":"2015-03-16T15:52:54Z","git_url":"git://github.com/windup/windup.git","ssh_url":"git@github.com:windup/windup.git","clone_url":"https://github.com/windup/windup.git","svn_url":"https://github.com/windup/windup","homepage":"","size":89079,"stargazers_count":34,"watchers_count":34,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":64,"mirror_url":null,"open_issues_count":41,"forks":64,"open_issues":41,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/windup/windup/pulls/496"},"html":{"href":"https://github.com/windup/windup/pull/496"},"issue":{"href":"https://api.github.com/repos/windup/windup/issues/496"},"comments":{"href":"https://api.github.com/repos/windup/windup/issues/496/comments"},"review_comments":{"href":"https://api.github.com/repos/windup/windup/pulls/496/comments"},"review_comment":{"href":"https://api.github.com/repos/windup/windup/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/windup/windup/pulls/496/commits"},"statuses":{"href":"https://api.github.com/repos/windup/windup/statuses/1b77e038d18906e86f937413760a9fe21e390238"}}}}