{"action":"created","comment":{"url":"https://api.github.com/repos/segmentio/integration-mailchimp/pulls/comments/36148770","id":36148770,"diff_hunk":"@@ -90,4 +92,13 @@ function _case(trait){\n   return uncase(trait.replace(/\\s+/g, ''))\n     .replace(/\\s+/g, '')\n     .toUpperCase();\n+}\n+\n+/**\n+ * Turn boolean types to strings to prevent MC from silently dropping calls","path":"lib/mapper.js","position":65,"original_position":65,"commit_id":"d0269cff7a0fc13908f893ffafde537ad9fb4a0d","original_commit_id":"d0269cff7a0fc13908f893ffafde537ad9fb4a0d","user":{"login":"ndhoule","id":1863990,"avatar_url":"https://avatars.githubusercontent.com/u/1863990?v=3","gravatar_id":"","url":"https://api.github.com/users/ndhoule","html_url":"https://github.com/ndhoule","followers_url":"https://api.github.com/users/ndhoule/followers","following_url":"https://api.github.com/users/ndhoule/following{/other_user}","gists_url":"https://api.github.com/users/ndhoule/gists{/gist_id}","starred_url":"https://api.github.com/users/ndhoule/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndhoule/subscriptions","organizations_url":"https://api.github.com/users/ndhoule/orgs","repos_url":"https://api.github.com/users/ndhoule/repos","events_url":"https://api.github.com/users/ndhoule/events{/privacy}","received_events_url":"https://api.github.com/users/ndhoule/received_events","type":"User","site_admin":false},"body":"\"Turn boolean types to strings.\" is enough of a description; add the bit about why it's necessary (MC dropping calls) up where it's being used. This function is generic enough that it's useful outside this context; there's no need to tie in the MC issue here","created_at":"2015-08-04T01:02:23Z","updated_at":"2015-08-04T01:02:23Z","html_url":"https://github.com/segmentio/integration-mailchimp/pull/18#discussion_r36148770","pull_request_url":"https://api.github.com/repos/segmentio/integration-mailchimp/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/segmentio/integration-mailchimp/pulls/comments/36148770"},"html":{"href":"https://github.com/segmentio/integration-mailchimp/pull/18#discussion_r36148770"},"pull_request":{"href":"https://api.github.com/repos/segmentio/integration-mailchimp/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/segmentio/integration-mailchimp/pulls/18","id":41393416,"html_url":"https://github.com/segmentio/integration-mailchimp/pull/18","diff_url":"https://github.com/segmentio/integration-mailchimp/pull/18.diff","patch_url":"https://github.com/segmentio/integration-mailchimp/pull/18.patch","issue_url":"https://api.github.com/repos/segmentio/integration-mailchimp/issues/18","number":18,"state":"open","locked":false,"title":"upgrade to 3.0, build subscribe logic","user":{"login":"hankim813","id":5907121,"avatar_url":"https://avatars.githubusercontent.com/u/5907121?v=3","gravatar_id":"","url":"https://api.github.com/users/hankim813","html_url":"https://github.com/hankim813","followers_url":"https://api.github.com/users/hankim813/followers","following_url":"https://api.github.com/users/hankim813/following{/other_user}","gists_url":"https://api.github.com/users/hankim813/gists{/gist_id}","starred_url":"https://api.github.com/users/hankim813/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hankim813/subscriptions","organizations_url":"https://api.github.com/users/hankim813/orgs","repos_url":"https://api.github.com/users/hankim813/repos","events_url":"https://api.github.com/users/hankim813/events{/privacy}","received_events_url":"https://api.github.com/users/hankim813/received_events","type":"User","site_admin":false},"body":"Upgrade to their recent 3.0 api \r\n\r\nbuild more robust logic for subscribing and updating user profiles and prevent users from being resubscribed unintentionally\r\n\r\n","created_at":"2015-08-01T01:06:27Z","updated_at":"2015-08-04T01:02:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2fee1ec6b1489211a3c43d7f1c2ad9c70ca4094a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/segmentio/integration-mailchimp/pulls/18/commits","review_comments_url":"https://api.github.com/repos/segmentio/integration-mailchimp/pulls/18/comments","review_comment_url":"https://api.github.com/repos/segmentio/integration-mailchimp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/segmentio/integration-mailchimp/issues/18/comments","statuses_url":"https://api.github.com/repos/segmentio/integration-mailchimp/statuses/d0269cff7a0fc13908f893ffafde537ad9fb4a0d","head":{"label":"segmentio:migrate-to-3.0api","ref":"migrate-to-3.0api","sha":"d0269cff7a0fc13908f893ffafde537ad9fb4a0d","user":{"login":"segmentio","id":819518,"avatar_url":"https://avatars.githubusercontent.com/u/819518?v=3","gravatar_id":"","url":"https://api.github.com/users/segmentio","html_url":"https://github.com/segmentio","followers_url":"https://api.github.com/users/segmentio/followers","following_url":"https://api.github.com/users/segmentio/following{/other_user}","gists_url":"https://api.github.com/users/segmentio/gists{/gist_id}","starred_url":"https://api.github.com/users/segmentio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segmentio/subscriptions","organizations_url":"https://api.github.com/users/segmentio/orgs","repos_url":"https://api.github.com/users/segmentio/repos","events_url":"https://api.github.com/users/segmentio/events{/privacy}","received_events_url":"https://api.github.com/users/segmentio/received_events","type":"Organization","site_admin":false},"repo":{"id":26639850,"name":"integration-mailchimp","full_name":"segmentio/integration-mailchimp","owner":{"login":"segmentio","id":819518,"avatar_url":"https://avatars.githubusercontent.com/u/819518?v=3","gravatar_id":"","url":"https://api.github.com/users/segmentio","html_url":"https://github.com/segmentio","followers_url":"https://api.github.com/users/segmentio/followers","following_url":"https://api.github.com/users/segmentio/following{/other_user}","gists_url":"https://api.github.com/users/segmentio/gists{/gist_id}","starred_url":"https://api.github.com/users/segmentio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segmentio/subscriptions","organizations_url":"https://api.github.com/users/segmentio/orgs","repos_url":"https://api.github.com/users/segmentio/repos","events_url":"https://api.github.com/users/segmentio/events{/privacy}","received_events_url":"https://api.github.com/users/segmentio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/segmentio/integration-mailchimp","description":"MailChimp server-side integration","fork":false,"url":"https://api.github.com/repos/segmentio/integration-mailchimp","forks_url":"https://api.github.com/repos/segmentio/integration-mailchimp/forks","keys_url":"https://api.github.com/repos/segmentio/integration-mailchimp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/segmentio/integration-mailchimp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/segmentio/integration-mailchimp/teams","hooks_url":"https://api.github.com/repos/segmentio/integration-mailchimp/hooks","issue_events_url":"https://api.github.com/repos/segmentio/integration-mailchimp/issues/events{/number}","events_url":"https://api.github.com/repos/segmentio/integration-mailchimp/events","assignees_url":"https://api.github.com/repos/segmentio/integration-mailchimp/assignees{/user}","branches_url":"https://api.github.com/repos/segmentio/integration-mailchimp/branches{/branch}","tags_url":"https://api.github.com/repos/segmentio/integration-mailchimp/tags","blobs_url":"https://api.github.com/repos/segmentio/integration-mailchimp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/segmentio/integration-mailchimp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/segmentio/integration-mailchimp/git/refs{/sha}","trees_url":"https://api.github.com/repos/segmentio/integration-mailchimp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/segmentio/integration-mailchimp/statuses/{sha}","languages_url":"https://api.github.com/repos/segmentio/integration-mailchimp/languages","stargazers_url":"https://api.github.com/repos/segmentio/integration-mailchimp/stargazers","contributors_url":"https://api.github.com/repos/segmentio/integration-mailchimp/contributors","subscribers_url":"https://api.github.com/repos/segmentio/integration-mailchimp/subscribers","subscription_url":"https://api.github.com/repos/segmentio/integration-mailchimp/subscription","commits_url":"https://api.github.com/repos/segmentio/integration-mailchimp/commits{/sha}","git_commits_url":"https://api.github.com/repos/segmentio/integration-mailchimp/git/commits{/sha}","comments_url":"https://api.github.com/repos/segmentio/integration-mailchimp/comments{/number}","issue_comment_url":"https://api.github.com/repos/segmentio/integration-mailchimp/issues/comments{/number}","contents_url":"https://api.github.com/repos/segmentio/integration-mailchimp/contents/{+path}","compare_url":"https://api.github.com/repos/segmentio/integration-mailchimp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/segmentio/integration-mailchimp/merges","archive_url":"https://api.github.com/repos/segmentio/integration-mailchimp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/segmentio/integration-mailchimp/downloads","issues_url":"https://api.github.com/repos/segmentio/integration-mailchimp/issues{/number}","pulls_url":"https://api.github.com/repos/segmentio/integration-mailchimp/pulls{/number}","milestones_url":"https://api.github.com/repos/segmentio/integration-mailchimp/milestones{/number}","notifications_url":"https://api.github.com/repos/segmentio/integration-mailchimp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/segmentio/integration-mailchimp/labels{/name}","releases_url":"https://api.github.com/repos/segmentio/integration-mailchimp/releases{/id}","created_at":"2014-11-14T13:31:38Z","updated_at":"2015-04-09T05:22:44Z","pushed_at":"2015-08-01T01:06:27Z","git_url":"git://github.com/segmentio/integration-mailchimp.git","ssh_url":"git@github.com:segmentio/integration-mailchimp.git","clone_url":"https://github.com/segmentio/integration-mailchimp.git","svn_url":"https://github.com/segmentio/integration-mailchimp","homepage":"segment.com","size":374,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":4,"default_branch":"master"}},"base":{"label":"segmentio:master","ref":"master","sha":"2108db38f38a268df98a600f975009ef1869d042","user":{"login":"segmentio","id":819518,"avatar_url":"https://avatars.githubusercontent.com/u/819518?v=3","gravatar_id":"","url":"https://api.github.com/users/segmentio","html_url":"https://github.com/segmentio","followers_url":"https://api.github.com/users/segmentio/followers","following_url":"https://api.github.com/users/segmentio/following{/other_user}","gists_url":"https://api.github.com/users/segmentio/gists{/gist_id}","starred_url":"https://api.github.com/users/segmentio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segmentio/subscriptions","organizations_url":"https://api.github.com/users/segmentio/orgs","repos_url":"https://api.github.com/users/segmentio/repos","events_url":"https://api.github.com/users/segmentio/events{/privacy}","received_events_url":"https://api.github.com/users/segmentio/received_events","type":"Organization","site_admin":false},"repo":{"id":26639850,"name":"integration-mailchimp","full_name":"segmentio/integration-mailchimp","owner":{"login":"segmentio","id":819518,"avatar_url":"https://avatars.githubusercontent.com/u/819518?v=3","gravatar_id":"","url":"https://api.github.com/users/segmentio","html_url":"https://github.com/segmentio","followers_url":"https://api.github.com/users/segmentio/followers","following_url":"https://api.github.com/users/segmentio/following{/other_user}","gists_url":"https://api.github.com/users/segmentio/gists{/gist_id}","starred_url":"https://api.github.com/users/segmentio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segmentio/subscriptions","organizations_url":"https://api.github.com/users/segmentio/orgs","repos_url":"https://api.github.com/users/segmentio/repos","events_url":"https://api.github.com/users/segmentio/events{/privacy}","received_events_url":"https://api.github.com/users/segmentio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/segmentio/integration-mailchimp","description":"MailChimp server-side integration","fork":false,"url":"https://api.github.com/repos/segmentio/integration-mailchimp","forks_url":"https://api.github.com/repos/segmentio/integration-mailchimp/forks","keys_url":"https://api.github.com/repos/segmentio/integration-mailchimp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/segmentio/integration-mailchimp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/segmentio/integration-mailchimp/teams","hooks_url":"https://api.github.com/repos/segmentio/integration-mailchimp/hooks","issue_events_url":"https://api.github.com/repos/segmentio/integration-mailchimp/issues/events{/number}","events_url":"https://api.github.com/repos/segmentio/integration-mailchimp/events","assignees_url":"https://api.github.com/repos/segmentio/integration-mailchimp/assignees{/user}","branches_url":"https://api.github.com/repos/segmentio/integration-mailchimp/branches{/branch}","tags_url":"https://api.github.com/repos/segmentio/integration-mailchimp/tags","blobs_url":"https://api.github.com/repos/segmentio/integration-mailchimp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/segmentio/integration-mailchimp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/segmentio/integration-mailchimp/git/refs{/sha}","trees_url":"https://api.github.com/repos/segmentio/integration-mailchimp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/segmentio/integration-mailchimp/statuses/{sha}","languages_url":"https://api.github.com/repos/segmentio/integration-mailchimp/languages","stargazers_url":"https://api.github.com/repos/segmentio/integration-mailchimp/stargazers","contributors_url":"https://api.github.com/repos/segmentio/integration-mailchimp/contributors","subscribers_url":"https://api.github.com/repos/segmentio/integration-mailchimp/subscribers","subscription_url":"https://api.github.com/repos/segmentio/integration-mailchimp/subscription","commits_url":"https://api.github.com/repos/segmentio/integration-mailchimp/commits{/sha}","git_commits_url":"https://api.github.com/repos/segmentio/integration-mailchimp/git/commits{/sha}","comments_url":"https://api.github.com/repos/segmentio/integration-mailchimp/comments{/number}","issue_comment_url":"https://api.github.com/repos/segmentio/integration-mailchimp/issues/comments{/number}","contents_url":"https://api.github.com/repos/segmentio/integration-mailchimp/contents/{+path}","compare_url":"https://api.github.com/repos/segmentio/integration-mailchimp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/segmentio/integration-mailchimp/merges","archive_url":"https://api.github.com/repos/segmentio/integration-mailchimp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/segmentio/integration-mailchimp/downloads","issues_url":"https://api.github.com/repos/segmentio/integration-mailchimp/issues{/number}","pulls_url":"https://api.github.com/repos/segmentio/integration-mailchimp/pulls{/number}","milestones_url":"https://api.github.com/repos/segmentio/integration-mailchimp/milestones{/number}","notifications_url":"https://api.github.com/repos/segmentio/integration-mailchimp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/segmentio/integration-mailchimp/labels{/name}","releases_url":"https://api.github.com/repos/segmentio/integration-mailchimp/releases{/id}","created_at":"2014-11-14T13:31:38Z","updated_at":"2015-04-09T05:22:44Z","pushed_at":"2015-08-01T01:06:27Z","git_url":"git://github.com/segmentio/integration-mailchimp.git","ssh_url":"git@github.com:segmentio/integration-mailchimp.git","clone_url":"https://github.com/segmentio/integration-mailchimp.git","svn_url":"https://github.com/segmentio/integration-mailchimp","homepage":"segment.com","size":374,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/segmentio/integration-mailchimp/pulls/18"},"html":{"href":"https://github.com/segmentio/integration-mailchimp/pull/18"},"issue":{"href":"https://api.github.com/repos/segmentio/integration-mailchimp/issues/18"},"comments":{"href":"https://api.github.com/repos/segmentio/integration-mailchimp/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/segmentio/integration-mailchimp/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/segmentio/integration-mailchimp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/segmentio/integration-mailchimp/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/segmentio/integration-mailchimp/statuses/d0269cff7a0fc13908f893ffafde537ad9fb4a0d"}}}}