{"comment":{"url":"https://api.github.com/repos/Crotalus/fa/comments/9491811","html_url":"https://github.com/Crotalus/fa/commit/52436080f0045a82b30015b2a4d495d4ff646b72#commitcomment-9491811","id":9491811,"user":{"login":"ChrisKitching","id":3526849,"avatar_url":"https://avatars.githubusercontent.com/u/3526849?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisKitching","html_url":"https://github.com/ChrisKitching","followers_url":"https://api.github.com/users/ChrisKitching/followers","following_url":"https://api.github.com/users/ChrisKitching/following{/other_user}","gists_url":"https://api.github.com/users/ChrisKitching/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisKitching/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisKitching/subscriptions","organizations_url":"https://api.github.com/users/ChrisKitching/orgs","repos_url":"https://api.github.com/users/ChrisKitching/repos","events_url":"https://api.github.com/users/ChrisKitching/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisKitching/received_events","type":"User","site_admin":false},"position":31,"line":4174,"path":"lua/ui/lobby/lobby.lua","commit_id":"52436080f0045a82b30015b2a4d495d4ff646b72","created_at":"2015-01-29T04:08:16Z","updated_at":"2015-01-29T04:08:16Z","body":"It occurs to me that, due to this loop, the performance of your routine might actually be worse than what was here before.\r\n\r\nWith your code, we now *always* call SetSlotCPUBar for *every* player when just one benchmark value has updated.\r\nThe old code, while it sent more messages over the network than it needed to, did less UI updating. In the lobby, our main problem is UI lag, we don't care overly much about optimising the wire protocol (yes, it's shit and we need to fix it, but we don't have to send that much data around so it's not a hugely big deal if we do a little more than we need to)"}}