{"action":"created","issue":{"url":"https://api.github.com/repos/clickalicious/Doozr/issues/56","labels_url":"https://api.github.com/repos/clickalicious/Doozr/issues/56/labels{/name}","comments_url":"https://api.github.com/repos/clickalicious/Doozr/issues/56/comments","events_url":"https://api.github.com/repos/clickalicious/Doozr/issues/56/events","html_url":"https://github.com/clickalicious/Doozr/issues/56","id":68672113,"number":56,"title":"Inject: Annotation @Inject is misleading","user":{"login":"clickalicious","id":514566,"avatar_url":"https://avatars.githubusercontent.com/u/514566?v=3","gravatar_id":"","url":"https://api.github.com/users/clickalicious","html_url":"https://github.com/clickalicious","followers_url":"https://api.github.com/users/clickalicious/followers","following_url":"https://api.github.com/users/clickalicious/following{/other_user}","gists_url":"https://api.github.com/users/clickalicious/gists{/gist_id}","starred_url":"https://api.github.com/users/clickalicious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clickalicious/subscriptions","organizations_url":"https://api.github.com/users/clickalicious/orgs","repos_url":"https://api.github.com/users/clickalicious/repos","events_url":"https://api.github.com/users/clickalicious/events{/privacy}","received_events_url":"https://api.github.com/users/clickalicious/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/clickalicious/Doozr/labels/bug","name":"bug","color":"fc2929"}],"state":"closed","locked":false,"assignee":{"login":"clickalicious","id":514566,"avatar_url":"https://avatars.githubusercontent.com/u/514566?v=3","gravatar_id":"","url":"https://api.github.com/users/clickalicious","html_url":"https://github.com/clickalicious","followers_url":"https://api.github.com/users/clickalicious/followers","following_url":"https://api.github.com/users/clickalicious/following{/other_user}","gists_url":"https://api.github.com/users/clickalicious/gists{/gist_id}","starred_url":"https://api.github.com/users/clickalicious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clickalicious/subscriptions","organizations_url":"https://api.github.com/users/clickalicious/orgs","repos_url":"https://api.github.com/users/clickalicious/repos","events_url":"https://api.github.com/users/clickalicious/events{/privacy}","received_events_url":"https://api.github.com/users/clickalicious/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/clickalicious/Doozr/milestones/2","html_url":"https://github.com/clickalicious/Doozr/milestones/First%20stable%20release%200.1.0","labels_url":"https://api.github.com/repos/clickalicious/Doozr/milestones/2/labels","id":447064,"number":2,"title":"First stable release 0.1.0","description":"The first stable release will be the first version which is used as base for all further development and all branches for release 0.1.0.","creator":{"login":"clickalicious","id":514566,"avatar_url":"https://avatars.githubusercontent.com/u/514566?v=3","gravatar_id":"","url":"https://api.github.com/users/clickalicious","html_url":"https://github.com/clickalicious","followers_url":"https://api.github.com/users/clickalicious/followers","following_url":"https://api.github.com/users/clickalicious/following{/other_user}","gists_url":"https://api.github.com/users/clickalicious/gists{/gist_id}","starred_url":"https://api.github.com/users/clickalicious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clickalicious/subscriptions","organizations_url":"https://api.github.com/users/clickalicious/orgs","repos_url":"https://api.github.com/users/clickalicious/repos","events_url":"https://api.github.com/users/clickalicious/events{/privacy}","received_events_url":"https://api.github.com/users/clickalicious/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":34,"state":"open","created_at":"2013-10-07T07:49:03Z","updated_at":"2015-08-24T09:31:06Z","due_on":"2015-08-30T22:00:00Z","closed_at":null},"comments":1,"created_at":"2015-04-15T12:44:27Z","updated_at":"2015-08-24T09:31:06Z","closed_at":"2015-08-24T09:31:06Z","body":"The property \"identifier\" is misused and leads to confusion. DoozR's DI is based on an optional property \"identifier\" which is in that context used for identifying an existing Instance for injection for automagically injections and manually injections by identifier.\r\n\r\nIn the annotation class Inject the property \"identifier\" is used to identifiy the receiver of the injection. For example currently its used with a string for example `getInstance` which leads to an injection via method ...::getInstance(...). This works as expected but could lead to an error. \r\n\r\nWe also need the property now for identifying instances to inject if not explicit mapped before.\r\n\r\nWe need to rename the property `identifier` of the class Injection to `receiver` same for parser which parses `.dependencies`. We need to ensure that the logic and convention is always 1:1. \r\n\r\nSo we implement both in @Inject - property `receiver` (name of the receiver to inject via e.g. getInstance) and property `identifier` (which instance! like UUID)."},"comment":{"url":"https://api.github.com/repos/clickalicious/Doozr/issues/comments/134109158","html_url":"https://github.com/clickalicious/Doozr/issues/56#issuecomment-134109158","issue_url":"https://api.github.com/repos/clickalicious/Doozr/issues/56","id":134109158,"user":{"login":"clickalicious","id":514566,"avatar_url":"https://avatars.githubusercontent.com/u/514566?v=3","gravatar_id":"","url":"https://api.github.com/users/clickalicious","html_url":"https://github.com/clickalicious","followers_url":"https://api.github.com/users/clickalicious/followers","following_url":"https://api.github.com/users/clickalicious/following{/other_user}","gists_url":"https://api.github.com/users/clickalicious/gists{/gist_id}","starred_url":"https://api.github.com/users/clickalicious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clickalicious/subscriptions","organizations_url":"https://api.github.com/users/clickalicious/orgs","repos_url":"https://api.github.com/users/clickalicious/repos","events_url":"https://api.github.com/users/clickalicious/events{/privacy}","received_events_url":"https://api.github.com/users/clickalicious/received_events","type":"User","site_admin":false},"created_at":"2015-08-24T09:31:06Z","updated_at":"2015-08-24T09:31:06Z","body":"Will be integrated into and fixed with #67."}}