{"action":"created","issue":{"url":"https://api.github.com/repos/radar/paranoia/issues/177","labels_url":"https://api.github.com/repos/radar/paranoia/issues/177/labels{/name}","comments_url":"https://api.github.com/repos/radar/paranoia/issues/177/comments","events_url":"https://api.github.com/repos/radar/paranoia/issues/177/events","html_url":"https://github.com/radar/paranoia/pull/177","id":46798971,"number":177,"title":"Rename Paranoia#destroyed? to Paranoia#paranoia_destroyed?","user":{"login":"huoxito","id":245662,"avatar_url":"https://avatars.githubusercontent.com/u/245662?v=3","gravatar_id":"","url":"https://api.github.com/users/huoxito","html_url":"https://github.com/huoxito","followers_url":"https://api.github.com/users/huoxito/followers","following_url":"https://api.github.com/users/huoxito/following{/other_user}","gists_url":"https://api.github.com/users/huoxito/gists{/gist_id}","starred_url":"https://api.github.com/users/huoxito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huoxito/subscriptions","organizations_url":"https://api.github.com/users/huoxito/orgs","repos_url":"https://api.github.com/users/huoxito/repos","events_url":"https://api.github.com/users/huoxito/events{/privacy}","received_events_url":"https://api.github.com/users/huoxito/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2014-10-25T01:54:54Z","updated_at":"2015-01-19T20:37:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/radar/paranoia/pulls/177","html_url":"https://github.com/radar/paranoia/pull/177","diff_url":"https://github.com/radar/paranoia/pull/177.diff","patch_url":"https://github.com/radar/paranoia/pull/177.patch"},"body":"There was a change in ActiveRecord#update_columns on latest rails\r\nso now it checks for `destroyed?` instead of `persisted?`. Paranoia\r\ncan't override `destoyed?` like this anymore otherwise\r\n`update_columns` will always raise:\r\n\r\n        ActiveRecord::ActiveRecordError: cannot update a destroyed record\r\n\r\nsee rails/rails@0f99aa6\r\n\r\n@radar this is a breaking change so not sure how you want to handle it. Couldn't think of a fix other than renaming the method. I'm not sure why `destroyed?` was overridden here in the first place but if tests are missing a scenario this could break something else too. Let you know if I find anything new."},"comment":{"url":"https://api.github.com/repos/radar/paranoia/issues/comments/70556551","html_url":"https://github.com/radar/paranoia/pull/177#issuecomment-70556551","issue_url":"https://api.github.com/repos/radar/paranoia/issues/177","id":70556551,"user":{"login":"radar","id":2687,"avatar_url":"https://avatars.githubusercontent.com/u/2687?v=3","gravatar_id":"","url":"https://api.github.com/users/radar","html_url":"https://github.com/radar","followers_url":"https://api.github.com/users/radar/followers","following_url":"https://api.github.com/users/radar/following{/other_user}","gists_url":"https://api.github.com/users/radar/gists{/gist_id}","starred_url":"https://api.github.com/users/radar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radar/subscriptions","organizations_url":"https://api.github.com/users/radar/orgs","repos_url":"https://api.github.com/users/radar/repos","events_url":"https://api.github.com/users/radar/events{/privacy}","received_events_url":"https://api.github.com/users/radar/received_events","type":"User","site_admin":false},"created_at":"2015-01-19T20:37:20Z","updated_at":"2015-01-19T20:37:20Z","body":"I agree that overriding core methods isn't the way to go and I'm fine with switching it to `#paranoia_destroyed?` with a deprecation in the 2.0.x releases. Please remember to update the README too."}}