{"action":"created","issue":{"url":"https://api.github.com/repos/zackthehuman/chip8/issues/2","labels_url":"https://api.github.com/repos/zackthehuman/chip8/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/zackthehuman/chip8/issues/2/comments","events_url":"https://api.github.com/repos/zackthehuman/chip8/issues/2/events","html_url":"https://github.com/zackthehuman/chip8/pull/2","id":122451142,"number":2,"title":"Fix tone to actually be a sine wave.","user":{"login":"krisselden","id":61024,"avatar_url":"https://avatars.githubusercontent.com/u/61024?v=3","gravatar_id":"","url":"https://api.github.com/users/krisselden","html_url":"https://github.com/krisselden","followers_url":"https://api.github.com/users/krisselden/followers","following_url":"https://api.github.com/users/krisselden/following{/other_user}","gists_url":"https://api.github.com/users/krisselden/gists{/gist_id}","starred_url":"https://api.github.com/users/krisselden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krisselden/subscriptions","organizations_url":"https://api.github.com/users/krisselden/orgs","repos_url":"https://api.github.com/users/krisselden/repos","events_url":"https://api.github.com/users/krisselden/events{/privacy}","received_events_url":"https://api.github.com/users/krisselden/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-12-16T08:19:20Z","updated_at":"2015-12-17T03:48:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zackthehuman/chip8/pulls/2","html_url":"https://github.com/zackthehuman/chip8/pull/2","diff_url":"https://github.com/zackthehuman/chip8/pull/2.diff","patch_url":"https://github.com/zackthehuman/chip8/pull/2.patch"},"body":"Though pause and unpause immediately write 0 instead of fading or fading in from 0 which can cause a slight click when not near the beginning or end of a period.\r\n\r\nSome games don't activate it long enough to hear a complete period so it sounds like a click or silence depending on where the generator's angle is.\r\n\r\nMaybe a minimum duration and using the mixer to fade in/out or just restart from the begining."},"comment":{"url":"https://api.github.com/repos/zackthehuman/chip8/issues/comments/165329887","html_url":"https://github.com/zackthehuman/chip8/pull/2#issuecomment-165329887","issue_url":"https://api.github.com/repos/zackthehuman/chip8/issues/2","id":165329887,"user":{"login":"krisselden","id":61024,"avatar_url":"https://avatars.githubusercontent.com/u/61024?v=3","gravatar_id":"","url":"https://api.github.com/users/krisselden","html_url":"https://github.com/krisselden","followers_url":"https://api.github.com/users/krisselden/followers","following_url":"https://api.github.com/users/krisselden/following{/other_user}","gists_url":"https://api.github.com/users/krisselden/gists{/gist_id}","starred_url":"https://api.github.com/users/krisselden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krisselden/subscriptions","organizations_url":"https://api.github.com/users/krisselden/orgs","repos_url":"https://api.github.com/users/krisselden/repos","events_url":"https://api.github.com/users/krisselden/events{/privacy}","received_events_url":"https://api.github.com/users/krisselden/received_events","type":"User","site_admin":false},"created_at":"2015-12-17T03:48:10Z","updated_at":"2015-12-17T03:48:10Z","body":"@zackthehuman it is part of SDL_stdinc.h which is included by the header of this but I will add it"}}