{"action":"reopened","issue":{"url":"https://api.github.com/repos/unikent/moodle-tool_adhoc/issues/17","labels_url":"https://api.github.com/repos/unikent/moodle-tool_adhoc/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/unikent/moodle-tool_adhoc/issues/17/comments","events_url":"https://api.github.com/repos/unikent/moodle-tool_adhoc/issues/17/events","html_url":"https://github.com/unikent/moodle-tool_adhoc/issues/17","id":100815351,"number":17,"title":"Renderer should not access DB","user":{"login":"mudrd8mz","id":85831,"avatar_url":"https://avatars.githubusercontent.com/u/85831?v=3","gravatar_id":"","url":"https://api.github.com/users/mudrd8mz","html_url":"https://github.com/mudrd8mz","followers_url":"https://api.github.com/users/mudrd8mz/followers","following_url":"https://api.github.com/users/mudrd8mz/following{/other_user}","gists_url":"https://api.github.com/users/mudrd8mz/gists{/gist_id}","starred_url":"https://api.github.com/users/mudrd8mz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mudrd8mz/subscriptions","organizations_url":"https://api.github.com/users/mudrd8mz/orgs","repos_url":"https://api.github.com/users/mudrd8mz/repos","events_url":"https://api.github.com/users/mudrd8mz/events{/privacy}","received_events_url":"https://api.github.com/users/mudrd8mz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-13T16:40:54Z","updated_at":"2015-08-17T10:18:43Z","closed_at":null,"body":"The `tool_adhoc_renderer::adhoc_tasks_table()` should receive all data to render via parameters, it itself should not access $DB. I know this pattern is often violated but because I can see the code is otherwise very clean and modern, I was thinking you might want to have this improved, too :-)"}}