{"action":"created","comment":{"url":"https://api.github.com/repos/cloudflare/redoctober/pulls/comments/43700239","id":43700239,"diff_hunk":"@@ -134,9 +134,9 @@ func NewServer(process chan<- userRequest, staticPath, addr, caPath string, cert\n \t\t\tlog.Fatal(err)\n \t\t}\n \t\tif len(listenFDs) != 1 {\n-\t\t\tlog.Fatal(\"Unexpected number of socket activation FDs!\")\n+\t\t\tlog.Fatalf(\"Unexpected number of socket activation FDs! (%v)\", len(listenFDs))","path":"redoctober.go","position":null,"original_position":5,"commit_id":"90ff2ceae27a53a7dc01c7ab1e2b5c2ead932c4f","original_commit_id":"fe973169fad414b1525acb7c4895bed4216492f1","user":{"login":"jkroll-cf","id":15053733,"avatar_url":"https://avatars.githubusercontent.com/u/15053733?v=3","gravatar_id":"","url":"https://api.github.com/users/jkroll-cf","html_url":"https://github.com/jkroll-cf","followers_url":"https://api.github.com/users/jkroll-cf/followers","following_url":"https://api.github.com/users/jkroll-cf/following{/other_user}","gists_url":"https://api.github.com/users/jkroll-cf/gists{/gist_id}","starred_url":"https://api.github.com/users/jkroll-cf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkroll-cf/subscriptions","organizations_url":"https://api.github.com/users/jkroll-cf/orgs","repos_url":"https://api.github.com/users/jkroll-cf/repos","events_url":"https://api.github.com/users/jkroll-cf/events{/privacy}","received_events_url":"https://api.github.com/users/jkroll-cf/received_events","type":"User","site_admin":false},"body":"Addressed Jacob's comments and improved TLS config while I'm in there.","created_at":"2015-11-02T23:42:57Z","updated_at":"2015-11-02T23:42:57Z","html_url":"https://github.com/cloudflare/redoctober/pull/100#discussion_r43700239","pull_request_url":"https://api.github.com/repos/cloudflare/redoctober/pulls/100","_links":{"self":{"href":"https://api.github.com/repos/cloudflare/redoctober/pulls/comments/43700239"},"html":{"href":"https://github.com/cloudflare/redoctober/pull/100#discussion_r43700239"},"pull_request":{"href":"https://api.github.com/repos/cloudflare/redoctober/pulls/100"}}},"pull_request":{"url":"https://api.github.com/repos/cloudflare/redoctober/pulls/100","id":49501701,"html_url":"https://github.com/cloudflare/redoctober/pull/100","diff_url":"https://github.com/cloudflare/redoctober/pull/100.diff","patch_url":"https://github.com/cloudflare/redoctober/pull/100.patch","issue_url":"https://api.github.com/repos/cloudflare/redoctober/issues/100","number":100,"state":"open","locked":false,"title":"Wrap systemd-provided sockets in a TLS listener.","user":{"login":"jkroll-cf","id":15053733,"avatar_url":"https://avatars.githubusercontent.com/u/15053733?v=3","gravatar_id":"","url":"https://api.github.com/users/jkroll-cf","html_url":"https://github.com/jkroll-cf","followers_url":"https://api.github.com/users/jkroll-cf/followers","following_url":"https://api.github.com/users/jkroll-cf/following{/other_user}","gists_url":"https://api.github.com/users/jkroll-cf/gists{/gist_id}","starred_url":"https://api.github.com/users/jkroll-cf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkroll-cf/subscriptions","organizations_url":"https://api.github.com/users/jkroll-cf/orgs","repos_url":"https://api.github.com/users/jkroll-cf/repos","events_url":"https://api.github.com/users/jkroll-cf/events{/privacy}","received_events_url":"https://api.github.com/users/jkroll-cf/received_events","type":"User","site_admin":false},"body":"This fixes a bug introduced by the new socket activation/systemd-brokered listening whereby Red October speaks HTTP rather than HTTPS over that socket.","created_at":"2015-11-02T23:33:26Z","updated_at":"2015-11-02T23:42:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d79922f3f7c2c4778bf65982204e2db04f9508e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cloudflare/redoctober/pulls/100/commits","review_comments_url":"https://api.github.com/repos/cloudflare/redoctober/pulls/100/comments","review_comment_url":"https://api.github.com/repos/cloudflare/redoctober/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudflare/redoctober/issues/100/comments","statuses_url":"https://api.github.com/repos/cloudflare/redoctober/statuses/90ff2ceae27a53a7dc01c7ab1e2b5c2ead932c4f","head":{"label":"cloudflare:jkroll/listen-tls-socket-activated","ref":"jkroll/listen-tls-socket-activated","sha":"90ff2ceae27a53a7dc01c7ab1e2b5c2ead932c4f","user":{"login":"cloudflare","id":314135,"avatar_url":"https://avatars.githubusercontent.com/u/314135?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudflare","html_url":"https://github.com/cloudflare","followers_url":"https://api.github.com/users/cloudflare/followers","following_url":"https://api.github.com/users/cloudflare/following{/other_user}","gists_url":"https://api.github.com/users/cloudflare/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudflare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudflare/subscriptions","organizations_url":"https://api.github.com/users/cloudflare/orgs","repos_url":"https://api.github.com/users/cloudflare/repos","events_url":"https://api.github.com/users/cloudflare/events{/privacy}","received_events_url":"https://api.github.com/users/cloudflare/received_events","type":"Organization","site_admin":false},"repo":{"id":14510383,"name":"redoctober","full_name":"cloudflare/redoctober","owner":{"login":"cloudflare","id":314135,"avatar_url":"https://avatars.githubusercontent.com/u/314135?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudflare","html_url":"https://github.com/cloudflare","followers_url":"https://api.github.com/users/cloudflare/followers","following_url":"https://api.github.com/users/cloudflare/following{/other_user}","gists_url":"https://api.github.com/users/cloudflare/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudflare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudflare/subscriptions","organizations_url":"https://api.github.com/users/cloudflare/orgs","repos_url":"https://api.github.com/users/cloudflare/repos","events_url":"https://api.github.com/users/cloudflare/events{/privacy}","received_events_url":"https://api.github.com/users/cloudflare/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudflare/redoctober","description":"Go server for two-man rule style file encryption and decryption.","fork":false,"url":"https://api.github.com/repos/cloudflare/redoctober","forks_url":"https://api.github.com/repos/cloudflare/redoctober/forks","keys_url":"https://api.github.com/repos/cloudflare/redoctober/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudflare/redoctober/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudflare/redoctober/teams","hooks_url":"https://api.github.com/repos/cloudflare/redoctober/hooks","issue_events_url":"https://api.github.com/repos/cloudflare/redoctober/issues/events{/number}","events_url":"https://api.github.com/repos/cloudflare/redoctober/events","assignees_url":"https://api.github.com/repos/cloudflare/redoctober/assignees{/user}","branches_url":"https://api.github.com/repos/cloudflare/redoctober/branches{/branch}","tags_url":"https://api.github.com/repos/cloudflare/redoctober/tags","blobs_url":"https://api.github.com/repos/cloudflare/redoctober/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudflare/redoctober/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudflare/redoctober/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudflare/redoctober/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudflare/redoctober/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudflare/redoctober/languages","stargazers_url":"https://api.github.com/repos/cloudflare/redoctober/stargazers","contributors_url":"https://api.github.com/repos/cloudflare/redoctober/contributors","subscribers_url":"https://api.github.com/repos/cloudflare/redoctober/subscribers","subscription_url":"https://api.github.com/repos/cloudflare/redoctober/subscription","commits_url":"https://api.github.com/repos/cloudflare/redoctober/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudflare/redoctober/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudflare/redoctober/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudflare/redoctober/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudflare/redoctober/contents/{+path}","compare_url":"https://api.github.com/repos/cloudflare/redoctober/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudflare/redoctober/merges","archive_url":"https://api.github.com/repos/cloudflare/redoctober/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudflare/redoctober/downloads","issues_url":"https://api.github.com/repos/cloudflare/redoctober/issues{/number}","pulls_url":"https://api.github.com/repos/cloudflare/redoctober/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudflare/redoctober/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudflare/redoctober/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudflare/redoctober/labels{/name}","releases_url":"https://api.github.com/repos/cloudflare/redoctober/releases{/id}","created_at":"2013-11-19T01:15:58Z","updated_at":"2015-11-02T10:08:40Z","pushed_at":"2015-11-02T23:42:30Z","git_url":"git://github.com/cloudflare/redoctober.git","ssh_url":"git@github.com:cloudflare/redoctober.git","clone_url":"https://github.com/cloudflare/redoctober.git","svn_url":"https://github.com/cloudflare/redoctober","homepage":"http://blog.cloudflare.com/red-october-cloudflares-open-source-implementation-of-the-two-man-rule","size":1227,"stargazers_count":894,"watchers_count":894,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":71,"mirror_url":null,"open_issues_count":11,"forks":71,"open_issues":11,"watchers":894,"default_branch":"master"}},"base":{"label":"cloudflare:master","ref":"master","sha":"b7956979f4570593d6057b3b950b0ba295a6b819","user":{"login":"cloudflare","id":314135,"avatar_url":"https://avatars.githubusercontent.com/u/314135?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudflare","html_url":"https://github.com/cloudflare","followers_url":"https://api.github.com/users/cloudflare/followers","following_url":"https://api.github.com/users/cloudflare/following{/other_user}","gists_url":"https://api.github.com/users/cloudflare/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudflare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudflare/subscriptions","organizations_url":"https://api.github.com/users/cloudflare/orgs","repos_url":"https://api.github.com/users/cloudflare/repos","events_url":"https://api.github.com/users/cloudflare/events{/privacy}","received_events_url":"https://api.github.com/users/cloudflare/received_events","type":"Organization","site_admin":false},"repo":{"id":14510383,"name":"redoctober","full_name":"cloudflare/redoctober","owner":{"login":"cloudflare","id":314135,"avatar_url":"https://avatars.githubusercontent.com/u/314135?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudflare","html_url":"https://github.com/cloudflare","followers_url":"https://api.github.com/users/cloudflare/followers","following_url":"https://api.github.com/users/cloudflare/following{/other_user}","gists_url":"https://api.github.com/users/cloudflare/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudflare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudflare/subscriptions","organizations_url":"https://api.github.com/users/cloudflare/orgs","repos_url":"https://api.github.com/users/cloudflare/repos","events_url":"https://api.github.com/users/cloudflare/events{/privacy}","received_events_url":"https://api.github.com/users/cloudflare/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudflare/redoctober","description":"Go server for two-man rule style file encryption and decryption.","fork":false,"url":"https://api.github.com/repos/cloudflare/redoctober","forks_url":"https://api.github.com/repos/cloudflare/redoctober/forks","keys_url":"https://api.github.com/repos/cloudflare/redoctober/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudflare/redoctober/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudflare/redoctober/teams","hooks_url":"https://api.github.com/repos/cloudflare/redoctober/hooks","issue_events_url":"https://api.github.com/repos/cloudflare/redoctober/issues/events{/number}","events_url":"https://api.github.com/repos/cloudflare/redoctober/events","assignees_url":"https://api.github.com/repos/cloudflare/redoctober/assignees{/user}","branches_url":"https://api.github.com/repos/cloudflare/redoctober/branches{/branch}","tags_url":"https://api.github.com/repos/cloudflare/redoctober/tags","blobs_url":"https://api.github.com/repos/cloudflare/redoctober/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudflare/redoctober/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudflare/redoctober/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudflare/redoctober/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudflare/redoctober/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudflare/redoctober/languages","stargazers_url":"https://api.github.com/repos/cloudflare/redoctober/stargazers","contributors_url":"https://api.github.com/repos/cloudflare/redoctober/contributors","subscribers_url":"https://api.github.com/repos/cloudflare/redoctober/subscribers","subscription_url":"https://api.github.com/repos/cloudflare/redoctober/subscription","commits_url":"https://api.github.com/repos/cloudflare/redoctober/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudflare/redoctober/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudflare/redoctober/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudflare/redoctober/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudflare/redoctober/contents/{+path}","compare_url":"https://api.github.com/repos/cloudflare/redoctober/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudflare/redoctober/merges","archive_url":"https://api.github.com/repos/cloudflare/redoctober/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudflare/redoctober/downloads","issues_url":"https://api.github.com/repos/cloudflare/redoctober/issues{/number}","pulls_url":"https://api.github.com/repos/cloudflare/redoctober/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudflare/redoctober/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudflare/redoctober/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudflare/redoctober/labels{/name}","releases_url":"https://api.github.com/repos/cloudflare/redoctober/releases{/id}","created_at":"2013-11-19T01:15:58Z","updated_at":"2015-11-02T10:08:40Z","pushed_at":"2015-11-02T23:42:30Z","git_url":"git://github.com/cloudflare/redoctober.git","ssh_url":"git@github.com:cloudflare/redoctober.git","clone_url":"https://github.com/cloudflare/redoctober.git","svn_url":"https://github.com/cloudflare/redoctober","homepage":"http://blog.cloudflare.com/red-october-cloudflares-open-source-implementation-of-the-two-man-rule","size":1227,"stargazers_count":894,"watchers_count":894,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":71,"mirror_url":null,"open_issues_count":11,"forks":71,"open_issues":11,"watchers":894,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudflare/redoctober/pulls/100"},"html":{"href":"https://github.com/cloudflare/redoctober/pull/100"},"issue":{"href":"https://api.github.com/repos/cloudflare/redoctober/issues/100"},"comments":{"href":"https://api.github.com/repos/cloudflare/redoctober/issues/100/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudflare/redoctober/pulls/100/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudflare/redoctober/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudflare/redoctober/pulls/100/commits"},"statuses":{"href":"https://api.github.com/repos/cloudflare/redoctober/statuses/90ff2ceae27a53a7dc01c7ab1e2b5c2ead932c4f"}}}}