{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/32405740","id":32405740,"diff_hunk":"@@ -7659,6 +7720,9 @@ int Client::_write(Fh *f, int64_t offset, uint64_t size, const char *buf)\n   }\n \n   put_cap_ref(in, CEPH_CAP_FILE_WR);\n+  if (buf == NULL && iov != NULL) {\n+    delete[] bparr; ","path":"src/client/Client.cc","position":127,"original_position":127,"commit_id":"067ab73772f63792d148fcdce6f5e44f42f9ce04","original_commit_id":"f6bf6c2a969b3d79179d1f14375ed9dfa3fd49ea","user":{"login":"JevonQ","id":9070185,"avatar_url":"https://avatars.githubusercontent.com/u/9070185?v=3","gravatar_id":"","url":"https://api.github.com/users/JevonQ","html_url":"https://github.com/JevonQ","followers_url":"https://api.github.com/users/JevonQ/followers","following_url":"https://api.github.com/users/JevonQ/following{/other_user}","gists_url":"https://api.github.com/users/JevonQ/gists{/gist_id}","starred_url":"https://api.github.com/users/JevonQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JevonQ/subscriptions","organizations_url":"https://api.github.com/users/JevonQ/orgs","repos_url":"https://api.github.com/users/JevonQ/repos","events_url":"https://api.github.com/users/JevonQ/events{/privacy}","received_events_url":"https://api.github.com/users/JevonQ/received_events","type":"User","site_admin":false},"body":"Make sense, I'll revise the code.","created_at":"2015-06-15T09:56:37Z","updated_at":"2015-06-15T09:56:37Z","html_url":"https://github.com/ceph/ceph/pull/4954#discussion_r32405740","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/4954","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/32405740"},"html":{"href":"https://github.com/ceph/ceph/pull/4954#discussion_r32405740"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/4954"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/4954","id":37654193,"html_url":"https://github.com/ceph/ceph/pull/4954","diff_url":"https://github.com/ceph/ceph/pull/4954.diff","patch_url":"https://github.com/ceph/ceph/pull/4954.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/4954","number":4954,"state":"open","locked":false,"title":"libcephfs: add ceph_p{read,write}v","user":{"login":"JevonQ","id":9070185,"avatar_url":"https://avatars.githubusercontent.com/u/9070185?v=3","gravatar_id":"","url":"https://api.github.com/users/JevonQ","html_url":"https://github.com/JevonQ","followers_url":"https://api.github.com/users/JevonQ/followers","following_url":"https://api.github.com/users/JevonQ/following{/other_user}","gists_url":"https://api.github.com/users/JevonQ/gists{/gist_id}","starred_url":"https://api.github.com/users/JevonQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JevonQ/subscriptions","organizations_url":"https://api.github.com/users/JevonQ/orgs","repos_url":"https://api.github.com/users/JevonQ/repos","events_url":"https://api.github.com/users/JevonQ/events{/privacy}","received_events_url":"https://api.github.com/users/JevonQ/received_events","type":"User","site_admin":false},"body":"Add interfaces in libcephfs to enable users to read/write data via iovec structure.\r\n\r\nSigned-off-by: Jevon Qiao <qiaojianfeng@unitedstack.com>","created_at":"2015-06-15T02:26:14Z","updated_at":"2015-06-15T09:56:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de9c473960949d7be2b10ff80a9e8d5c61cd28e9","assignee":{"login":"jcsp","id":944640,"avatar_url":"https://avatars.githubusercontent.com/u/944640?v=3","gravatar_id":"","url":"https://api.github.com/users/jcsp","html_url":"https://github.com/jcsp","followers_url":"https://api.github.com/users/jcsp/followers","following_url":"https://api.github.com/users/jcsp/following{/other_user}","gists_url":"https://api.github.com/users/jcsp/gists{/gist_id}","starred_url":"https://api.github.com/users/jcsp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcsp/subscriptions","organizations_url":"https://api.github.com/users/jcsp/orgs","repos_url":"https://api.github.com/users/jcsp/repos","events_url":"https://api.github.com/users/jcsp/events{/privacy}","received_events_url":"https://api.github.com/users/jcsp/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/4954/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/4954/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/4954/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/067ab73772f63792d148fcdce6f5e44f42f9ce04","head":{"label":"JevonQ:add-iov-support-in-libcephfs","ref":"add-iov-support-in-libcephfs","sha":"067ab73772f63792d148fcdce6f5e44f42f9ce04","user":{"login":"JevonQ","id":9070185,"avatar_url":"https://avatars.githubusercontent.com/u/9070185?v=3","gravatar_id":"","url":"https://api.github.com/users/JevonQ","html_url":"https://github.com/JevonQ","followers_url":"https://api.github.com/users/JevonQ/followers","following_url":"https://api.github.com/users/JevonQ/following{/other_user}","gists_url":"https://api.github.com/users/JevonQ/gists{/gist_id}","starred_url":"https://api.github.com/users/JevonQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JevonQ/subscriptions","organizations_url":"https://api.github.com/users/JevonQ/orgs","repos_url":"https://api.github.com/users/JevonQ/repos","events_url":"https://api.github.com/users/JevonQ/events{/privacy}","received_events_url":"https://api.github.com/users/JevonQ/received_events","type":"User","site_admin":false},"repo":{"id":37184362,"name":"ceph","full_name":"JevonQ/ceph","owner":{"login":"JevonQ","id":9070185,"avatar_url":"https://avatars.githubusercontent.com/u/9070185?v=3","gravatar_id":"","url":"https://api.github.com/users/JevonQ","html_url":"https://github.com/JevonQ","followers_url":"https://api.github.com/users/JevonQ/followers","following_url":"https://api.github.com/users/JevonQ/following{/other_user}","gists_url":"https://api.github.com/users/JevonQ/gists{/gist_id}","starred_url":"https://api.github.com/users/JevonQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JevonQ/subscriptions","organizations_url":"https://api.github.com/users/JevonQ/orgs","repos_url":"https://api.github.com/users/JevonQ/repos","events_url":"https://api.github.com/users/JevonQ/events{/privacy}","received_events_url":"https://api.github.com/users/JevonQ/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JevonQ/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/JevonQ/ceph","forks_url":"https://api.github.com/repos/JevonQ/ceph/forks","keys_url":"https://api.github.com/repos/JevonQ/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JevonQ/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JevonQ/ceph/teams","hooks_url":"https://api.github.com/repos/JevonQ/ceph/hooks","issue_events_url":"https://api.github.com/repos/JevonQ/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/JevonQ/ceph/events","assignees_url":"https://api.github.com/repos/JevonQ/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/JevonQ/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/JevonQ/ceph/tags","blobs_url":"https://api.github.com/repos/JevonQ/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JevonQ/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JevonQ/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/JevonQ/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JevonQ/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/JevonQ/ceph/languages","stargazers_url":"https://api.github.com/repos/JevonQ/ceph/stargazers","contributors_url":"https://api.github.com/repos/JevonQ/ceph/contributors","subscribers_url":"https://api.github.com/repos/JevonQ/ceph/subscribers","subscription_url":"https://api.github.com/repos/JevonQ/ceph/subscription","commits_url":"https://api.github.com/repos/JevonQ/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/JevonQ/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/JevonQ/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/JevonQ/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/JevonQ/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/JevonQ/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JevonQ/ceph/merges","archive_url":"https://api.github.com/repos/JevonQ/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JevonQ/ceph/downloads","issues_url":"https://api.github.com/repos/JevonQ/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/JevonQ/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/JevonQ/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/JevonQ/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JevonQ/ceph/labels{/name}","releases_url":"https://api.github.com/repos/JevonQ/ceph/releases{/id}","created_at":"2015-06-10T08:15:49Z","updated_at":"2015-06-10T08:16:02Z","pushed_at":"2015-06-15T09:46:26Z","git_url":"git://github.com/JevonQ/ceph.git","ssh_url":"git@github.com:JevonQ/ceph.git","clone_url":"https://github.com/JevonQ/ceph.git","svn_url":"https://github.com/JevonQ/ceph","homepage":"http://ceph.com","size":127040,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"ac4477926f49dc91e012d61096dbbdde5650bc8a","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","created_at":"2011-09-01T21:41:26Z","updated_at":"2015-06-13T03:21:52Z","pushed_at":"2015-06-15T09:46:29Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":433625,"stargazers_count":1366,"watchers_count":1366,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":748,"mirror_url":null,"open_issues_count":156,"forks":748,"open_issues":156,"watchers":1366,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/4954"},"html":{"href":"https://github.com/ceph/ceph/pull/4954"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/4954"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/4954/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/4954/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/4954/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/067ab73772f63792d148fcdce6f5e44f42f9ce04"}}}}