{"action":"opened","number":640,"pull_request":{"url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/pulls/640","id":36232227,"html_url":"https://github.com/michaelhashimoto/liferay-portal/pull/640","diff_url":"https://github.com/michaelhashimoto/liferay-portal/pull/640.diff","patch_url":"https://github.com/michaelhashimoto/liferay-portal/pull/640.patch","issue_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/issues/640","number":640,"state":"open","locked":false,"title":"moved js in LoggerUtil to methods in main.js","user":{"login":"AngeloYoun","id":11049786,"avatar_url":"https://avatars.githubusercontent.com/u/11049786?v=3","gravatar_id":"","url":"https://api.github.com/users/AngeloYoun","html_url":"https://github.com/AngeloYoun","followers_url":"https://api.github.com/users/AngeloYoun/followers","following_url":"https://api.github.com/users/AngeloYoun/following{/other_user}","gists_url":"https://api.github.com/users/AngeloYoun/gists{/gist_id}","starred_url":"https://api.github.com/users/AngeloYoun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AngeloYoun/subscriptions","organizations_url":"https://api.github.com/users/AngeloYoun/orgs","repos_url":"https://api.github.com/users/AngeloYoun/repos","events_url":"https://api.github.com/users/AngeloYoun/events{/privacy}","received_events_url":"https://api.github.com/users/AngeloYoun/received_events","type":"User","site_admin":false},"body":"Hey @michaelhashimoto, I moved over the javascript logic out of LoggerUtil.java, can you go over it to see if there are any issues? \r\nThere is also a setID method which I think is currently broken.\r\n(the ID that is set is the same value as the one used to find the node....) \r\n\r\nAlso isWrittenToLogger needed a try catch but i'm not sure I wrote it to Liferay standards.\r\n\r\nThanks!","created_at":"2015-05-26T18:38:38Z","updated_at":"2015-05-26T18:38:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/pulls/640/commits","review_comments_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/pulls/640/comments","review_comment_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/issues/640/comments","statuses_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/statuses/9cf2cf9fc82eaba8449b4317e9def6b7a9e221d3","head":{"label":"AngeloYoun:LRQA-14421","ref":"LRQA-14421","sha":"9cf2cf9fc82eaba8449b4317e9def6b7a9e221d3","user":{"login":"AngeloYoun","id":11049786,"avatar_url":"https://avatars.githubusercontent.com/u/11049786?v=3","gravatar_id":"","url":"https://api.github.com/users/AngeloYoun","html_url":"https://github.com/AngeloYoun","followers_url":"https://api.github.com/users/AngeloYoun/followers","following_url":"https://api.github.com/users/AngeloYoun/following{/other_user}","gists_url":"https://api.github.com/users/AngeloYoun/gists{/gist_id}","starred_url":"https://api.github.com/users/AngeloYoun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AngeloYoun/subscriptions","organizations_url":"https://api.github.com/users/AngeloYoun/orgs","repos_url":"https://api.github.com/users/AngeloYoun/repos","events_url":"https://api.github.com/users/AngeloYoun/events{/privacy}","received_events_url":"https://api.github.com/users/AngeloYoun/received_events","type":"User","site_admin":false},"repo":{"id":30935478,"name":"liferay-portal","full_name":"AngeloYoun/liferay-portal","owner":{"login":"AngeloYoun","id":11049786,"avatar_url":"https://avatars.githubusercontent.com/u/11049786?v=3","gravatar_id":"","url":"https://api.github.com/users/AngeloYoun","html_url":"https://github.com/AngeloYoun","followers_url":"https://api.github.com/users/AngeloYoun/followers","following_url":"https://api.github.com/users/AngeloYoun/following{/other_user}","gists_url":"https://api.github.com/users/AngeloYoun/gists{/gist_id}","starred_url":"https://api.github.com/users/AngeloYoun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AngeloYoun/subscriptions","organizations_url":"https://api.github.com/users/AngeloYoun/orgs","repos_url":"https://api.github.com/users/AngeloYoun/repos","events_url":"https://api.github.com/users/AngeloYoun/events{/privacy}","received_events_url":"https://api.github.com/users/AngeloYoun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AngeloYoun/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/AngeloYoun/liferay-portal","forks_url":"https://api.github.com/repos/AngeloYoun/liferay-portal/forks","keys_url":"https://api.github.com/repos/AngeloYoun/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AngeloYoun/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AngeloYoun/liferay-portal/teams","hooks_url":"https://api.github.com/repos/AngeloYoun/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/AngeloYoun/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/AngeloYoun/liferay-portal/events","assignees_url":"https://api.github.com/repos/AngeloYoun/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/AngeloYoun/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/AngeloYoun/liferay-portal/tags","blobs_url":"https://api.github.com/repos/AngeloYoun/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AngeloYoun/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AngeloYoun/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/AngeloYoun/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AngeloYoun/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/AngeloYoun/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/AngeloYoun/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/AngeloYoun/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/AngeloYoun/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/AngeloYoun/liferay-portal/subscription","commits_url":"https://api.github.com/repos/AngeloYoun/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/AngeloYoun/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/AngeloYoun/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/AngeloYoun/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/AngeloYoun/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/AngeloYoun/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AngeloYoun/liferay-portal/merges","archive_url":"https://api.github.com/repos/AngeloYoun/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AngeloYoun/liferay-portal/downloads","issues_url":"https://api.github.com/repos/AngeloYoun/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/AngeloYoun/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/AngeloYoun/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/AngeloYoun/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AngeloYoun/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/AngeloYoun/liferay-portal/releases{/id}","created_at":"2015-02-17T20:12:07Z","updated_at":"2015-04-30T17:09:47Z","pushed_at":"2015-05-26T18:31:18Z","git_url":"git://github.com/AngeloYoun/liferay-portal.git","ssh_url":"git@github.com:AngeloYoun/liferay-portal.git","clone_url":"https://github.com/AngeloYoun/liferay-portal.git","svn_url":"https://github.com/AngeloYoun/liferay-portal","homepage":"http://liferay.com","size":4457329,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"michaelhashimoto:master","ref":"master","sha":"18967505d91a9c3286249d9b56cd1fb41305eca8","user":{"login":"michaelhashimoto","id":863043,"avatar_url":"https://avatars.githubusercontent.com/u/863043?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelhashimoto","html_url":"https://github.com/michaelhashimoto","followers_url":"https://api.github.com/users/michaelhashimoto/followers","following_url":"https://api.github.com/users/michaelhashimoto/following{/other_user}","gists_url":"https://api.github.com/users/michaelhashimoto/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelhashimoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelhashimoto/subscriptions","organizations_url":"https://api.github.com/users/michaelhashimoto/orgs","repos_url":"https://api.github.com/users/michaelhashimoto/repos","events_url":"https://api.github.com/users/michaelhashimoto/events{/privacy}","received_events_url":"https://api.github.com/users/michaelhashimoto/received_events","type":"User","site_admin":false},"repo":{"id":1926698,"name":"liferay-portal","full_name":"michaelhashimoto/liferay-portal","owner":{"login":"michaelhashimoto","id":863043,"avatar_url":"https://avatars.githubusercontent.com/u/863043?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelhashimoto","html_url":"https://github.com/michaelhashimoto","followers_url":"https://api.github.com/users/michaelhashimoto/followers","following_url":"https://api.github.com/users/michaelhashimoto/following{/other_user}","gists_url":"https://api.github.com/users/michaelhashimoto/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelhashimoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelhashimoto/subscriptions","organizations_url":"https://api.github.com/users/michaelhashimoto/orgs","repos_url":"https://api.github.com/users/michaelhashimoto/repos","events_url":"https://api.github.com/users/michaelhashimoto/events{/privacy}","received_events_url":"https://api.github.com/users/michaelhashimoto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/michaelhashimoto/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/michaelhashimoto/liferay-portal","forks_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/forks","keys_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/teams","hooks_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/events","assignees_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/tags","blobs_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/subscription","commits_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/merges","archive_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/downloads","issues_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/michaelhashimoto/liferay-portal/releases{/id}","created_at":"2011-06-21T00:39:15Z","updated_at":"2015-05-08T18:51:13Z","pushed_at":"2015-05-26T18:38:38Z","git_url":"git://github.com/michaelhashimoto/liferay-portal.git","ssh_url":"git@github.com:michaelhashimoto/liferay-portal.git","clone_url":"https://github.com/michaelhashimoto/liferay-portal.git","svn_url":"https://github.com/michaelhashimoto/liferay-portal","homepage":"http://liferay.com","size":4496231,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/michaelhashimoto/liferay-portal/pulls/640"},"html":{"href":"https://github.com/michaelhashimoto/liferay-portal/pull/640"},"issue":{"href":"https://api.github.com/repos/michaelhashimoto/liferay-portal/issues/640"},"comments":{"href":"https://api.github.com/repos/michaelhashimoto/liferay-portal/issues/640/comments"},"review_comments":{"href":"https://api.github.com/repos/michaelhashimoto/liferay-portal/pulls/640/comments"},"review_comment":{"href":"https://api.github.com/repos/michaelhashimoto/liferay-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/michaelhashimoto/liferay-portal/pulls/640/commits"},"statuses":{"href":"https://api.github.com/repos/michaelhashimoto/liferay-portal/statuses/9cf2cf9fc82eaba8449b4317e9def6b7a9e221d3"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":47,"additions":1473,"deletions":1520,"changed_files":234}}