{"action":"created","comment":{"url":"https://api.github.com/repos/ipython/ipython/pulls/comments/23633653","id":23633653,"diff_hunk":"@@ -138,6 +138,10 @@ def base_url(self):\n         return self.settings.get('base_url', '/')\n \n     @property\n+    def default_url(self):\n+        return self.settings.get('default_url', '')","path":"IPython/html/base/handlers.py","position":5,"original_position":5,"commit_id":"a173b6a256961130770f8ccd31b01e7257cfa4c3","original_commit_id":"a173b6a256961130770f8ccd31b01e7257cfa4c3","user":{"login":"minrk","id":151929,"avatar_url":"https://avatars.githubusercontent.com/u/151929?v=3","gravatar_id":"","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"body":"There are no redirects associated with this value. An href to '' doesn't go anywhere.","created_at":"2015-01-27T19:14:20Z","updated_at":"2015-01-27T19:14:20Z","html_url":"https://github.com/ipython/ipython/pull/7608#discussion_r23633653","pull_request_url":"https://api.github.com/repos/ipython/ipython/pulls/7608","_links":{"self":{"href":"https://api.github.com/repos/ipython/ipython/pulls/comments/23633653"},"html":{"href":"https://github.com/ipython/ipython/pull/7608#discussion_r23633653"},"pull_request":{"href":"https://api.github.com/repos/ipython/ipython/pulls/7608"}}},"pull_request":{"url":"https://api.github.com/repos/ipython/ipython/pulls/7608","id":28133391,"html_url":"https://github.com/ipython/ipython/pull/7608","diff_url":"https://github.com/ipython/ipython/pull/7608.diff","patch_url":"https://github.com/ipython/ipython/pull/7608.patch","issue_url":"https://api.github.com/repos/ipython/ipython/issues/7608","number":7608,"state":"open","locked":false,"title":"use default_url for logo link","user":{"login":"minrk","id":151929,"avatar_url":"https://avatars.githubusercontent.com/u/151929?v=3","gravatar_id":"","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"body":"Now `/` and clicking the logo both take you do default_url, which is base_url/tree by default.\n\ncloses #7607","created_at":"2015-01-27T18:41:59Z","updated_at":"2015-01-27T19:14:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f76083165197579e27f9a6d1728c25f1087962e","assignee":null,"milestone":{"url":"https://api.github.com/repos/ipython/ipython/milestones/13","labels_url":"https://api.github.com/repos/ipython/ipython/milestones/13/labels","id":532467,"number":13,"title":"3.0","description":"IPython 3.0 \"Early\" 2015","creator":{"login":"Carreau","id":335567,"avatar_url":"https://avatars.githubusercontent.com/u/335567?v=3","gravatar_id":"","url":"https://api.github.com/users/Carreau","html_url":"https://github.com/Carreau","followers_url":"https://api.github.com/users/Carreau/followers","following_url":"https://api.github.com/users/Carreau/following{/other_user}","gists_url":"https://api.github.com/users/Carreau/gists{/gist_id}","starred_url":"https://api.github.com/users/Carreau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carreau/subscriptions","organizations_url":"https://api.github.com/users/Carreau/orgs","repos_url":"https://api.github.com/users/Carreau/repos","events_url":"https://api.github.com/users/Carreau/events{/privacy}","received_events_url":"https://api.github.com/users/Carreau/received_events","type":"User","site_admin":false},"open_issues":20,"closed_issues":1049,"state":"open","created_at":"2014-01-10T13:22:15Z","updated_at":"2015-01-27T19:11:00Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/ipython/ipython/pulls/7608/commits","review_comments_url":"https://api.github.com/repos/ipython/ipython/pulls/7608/comments","review_comment_url":"https://api.github.com/repos/ipython/ipython/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ipython/ipython/issues/7608/comments","statuses_url":"https://api.github.com/repos/ipython/ipython/statuses/a173b6a256961130770f8ccd31b01e7257cfa4c3","head":{"label":"minrk:default-location","ref":"default-location","sha":"a173b6a256961130770f8ccd31b01e7257cfa4c3","user":{"login":"minrk","id":151929,"avatar_url":"https://avatars.githubusercontent.com/u/151929?v=3","gravatar_id":"","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"repo":{"id":659446,"name":"ipython","full_name":"minrk/ipython","owner":{"login":"minrk","id":151929,"avatar_url":"https://avatars.githubusercontent.com/u/151929?v=3","gravatar_id":"","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/minrk/ipython","description":"","fork":true,"url":"https://api.github.com/repos/minrk/ipython","forks_url":"https://api.github.com/repos/minrk/ipython/forks","keys_url":"https://api.github.com/repos/minrk/ipython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minrk/ipython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minrk/ipython/teams","hooks_url":"https://api.github.com/repos/minrk/ipython/hooks","issue_events_url":"https://api.github.com/repos/minrk/ipython/issues/events{/number}","events_url":"https://api.github.com/repos/minrk/ipython/events","assignees_url":"https://api.github.com/repos/minrk/ipython/assignees{/user}","branches_url":"https://api.github.com/repos/minrk/ipython/branches{/branch}","tags_url":"https://api.github.com/repos/minrk/ipython/tags","blobs_url":"https://api.github.com/repos/minrk/ipython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minrk/ipython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minrk/ipython/git/refs{/sha}","trees_url":"https://api.github.com/repos/minrk/ipython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minrk/ipython/statuses/{sha}","languages_url":"https://api.github.com/repos/minrk/ipython/languages","stargazers_url":"https://api.github.com/repos/minrk/ipython/stargazers","contributors_url":"https://api.github.com/repos/minrk/ipython/contributors","subscribers_url":"https://api.github.com/repos/minrk/ipython/subscribers","subscription_url":"https://api.github.com/repos/minrk/ipython/subscription","commits_url":"https://api.github.com/repos/minrk/ipython/commits{/sha}","git_commits_url":"https://api.github.com/repos/minrk/ipython/git/commits{/sha}","comments_url":"https://api.github.com/repos/minrk/ipython/comments{/number}","issue_comment_url":"https://api.github.com/repos/minrk/ipython/issues/comments/{number}","contents_url":"https://api.github.com/repos/minrk/ipython/contents/{+path}","compare_url":"https://api.github.com/repos/minrk/ipython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minrk/ipython/merges","archive_url":"https://api.github.com/repos/minrk/ipython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minrk/ipython/downloads","issues_url":"https://api.github.com/repos/minrk/ipython/issues{/number}","pulls_url":"https://api.github.com/repos/minrk/ipython/pulls{/number}","milestones_url":"https://api.github.com/repos/minrk/ipython/milestones{/number}","notifications_url":"https://api.github.com/repos/minrk/ipython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minrk/ipython/labels{/name}","releases_url":"https://api.github.com/repos/minrk/ipython/releases{/id}","created_at":"2010-05-10T18:37:01Z","updated_at":"2015-01-24T22:43:04Z","pushed_at":"2015-01-27T18:51:39Z","git_url":"git://github.com/minrk/ipython.git","ssh_url":"git@github.com:minrk/ipython.git","clone_url":"https://github.com/minrk/ipython.git","svn_url":"https://github.com/minrk/ipython","homepage":"","size":74516,"stargazers_count":17,"watchers_count":17,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":17,"default_branch":"master"}},"base":{"label":"ipython:master","ref":"master","sha":"b29264c2d2385d185b40b9ad0b88310646b2bdb7","user":{"login":"ipython","id":230453,"avatar_url":"https://avatars.githubusercontent.com/u/230453?v=3","gravatar_id":"","url":"https://api.github.com/users/ipython","html_url":"https://github.com/ipython","followers_url":"https://api.github.com/users/ipython/followers","following_url":"https://api.github.com/users/ipython/following{/other_user}","gists_url":"https://api.github.com/users/ipython/gists{/gist_id}","starred_url":"https://api.github.com/users/ipython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipython/subscriptions","organizations_url":"https://api.github.com/users/ipython/orgs","repos_url":"https://api.github.com/users/ipython/repos","events_url":"https://api.github.com/users/ipython/events{/privacy}","received_events_url":"https://api.github.com/users/ipython/received_events","type":"Organization","site_admin":false},"repo":{"id":658518,"name":"ipython","full_name":"ipython/ipython","owner":{"login":"ipython","id":230453,"avatar_url":"https://avatars.githubusercontent.com/u/230453?v=3","gravatar_id":"","url":"https://api.github.com/users/ipython","html_url":"https://github.com/ipython","followers_url":"https://api.github.com/users/ipython/followers","following_url":"https://api.github.com/users/ipython/following{/other_user}","gists_url":"https://api.github.com/users/ipython/gists{/gist_id}","starred_url":"https://api.github.com/users/ipython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipython/subscriptions","organizations_url":"https://api.github.com/users/ipython/orgs","repos_url":"https://api.github.com/users/ipython/repos","events_url":"https://api.github.com/users/ipython/events{/privacy}","received_events_url":"https://api.github.com/users/ipython/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ipython/ipython","description":"Official repository for IPython itself. Other repos in the IPython organization contain things like the website, documentation builds, etc.","fork":false,"url":"https://api.github.com/repos/ipython/ipython","forks_url":"https://api.github.com/repos/ipython/ipython/forks","keys_url":"https://api.github.com/repos/ipython/ipython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipython/ipython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipython/ipython/teams","hooks_url":"https://api.github.com/repos/ipython/ipython/hooks","issue_events_url":"https://api.github.com/repos/ipython/ipython/issues/events{/number}","events_url":"https://api.github.com/repos/ipython/ipython/events","assignees_url":"https://api.github.com/repos/ipython/ipython/assignees{/user}","branches_url":"https://api.github.com/repos/ipython/ipython/branches{/branch}","tags_url":"https://api.github.com/repos/ipython/ipython/tags","blobs_url":"https://api.github.com/repos/ipython/ipython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipython/ipython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipython/ipython/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipython/ipython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipython/ipython/statuses/{sha}","languages_url":"https://api.github.com/repos/ipython/ipython/languages","stargazers_url":"https://api.github.com/repos/ipython/ipython/stargazers","contributors_url":"https://api.github.com/repos/ipython/ipython/contributors","subscribers_url":"https://api.github.com/repos/ipython/ipython/subscribers","subscription_url":"https://api.github.com/repos/ipython/ipython/subscription","commits_url":"https://api.github.com/repos/ipython/ipython/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipython/ipython/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipython/ipython/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipython/ipython/issues/comments/{number}","contents_url":"https://api.github.com/repos/ipython/ipython/contents/{+path}","compare_url":"https://api.github.com/repos/ipython/ipython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipython/ipython/merges","archive_url":"https://api.github.com/repos/ipython/ipython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipython/ipython/downloads","issues_url":"https://api.github.com/repos/ipython/ipython/issues{/number}","pulls_url":"https://api.github.com/repos/ipython/ipython/pulls{/number}","milestones_url":"https://api.github.com/repos/ipython/ipython/milestones{/number}","notifications_url":"https://api.github.com/repos/ipython/ipython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipython/ipython/labels{/name}","releases_url":"https://api.github.com/repos/ipython/ipython/releases{/id}","created_at":"2010-05-10T04:46:06Z","updated_at":"2015-01-27T19:11:00Z","pushed_at":"2015-01-27T19:11:00Z","git_url":"git://github.com/ipython/ipython.git","ssh_url":"git@github.com:ipython/ipython.git","clone_url":"https://github.com/ipython/ipython.git","svn_url":"https://github.com/ipython/ipython","homepage":"http://ipython.org","size":106193,"stargazers_count":5591,"watchers_count":5591,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1671,"mirror_url":null,"open_issues_count":753,"forks":1671,"open_issues":753,"watchers":5591,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ipython/ipython/pulls/7608"},"html":{"href":"https://github.com/ipython/ipython/pull/7608"},"issue":{"href":"https://api.github.com/repos/ipython/ipython/issues/7608"},"comments":{"href":"https://api.github.com/repos/ipython/ipython/issues/7608/comments"},"review_comments":{"href":"https://api.github.com/repos/ipython/ipython/pulls/7608/comments"},"review_comment":{"href":"https://api.github.com/repos/ipython/ipython/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ipython/ipython/pulls/7608/commits"},"statuses":{"href":"https://api.github.com/repos/ipython/ipython/statuses/a173b6a256961130770f8ccd31b01e7257cfa4c3"}}}}