{"action":"created","comment":{"url":"https://api.github.com/repos/videojs/video.js/pulls/comments/34391196","id":34391196,"diff_hunk":"@@ -0,0 +1,25 @@\n+import CaptionsButton from './captions-button.js';\n+\n+/**\n+ * The button component for toggling and selecting descriptions\n+ *\n+ * @constructor\n+ */\n+class DescriptionsButton extends CaptionsButton {","path":"src/js/control-bar/text-track-controls/descriptions-button.js","position":8,"original_position":8,"commit_id":"26e1b7b3e26ef4f96e63ccb8405c1c7857b128dd","original_commit_id":"26e1b7b3e26ef4f96e63ccb8405c1c7857b128dd","user":{"login":"heff","id":166,"avatar_url":"https://avatars.githubusercontent.com/u/166?v=3","gravatar_id":"","url":"https://api.github.com/users/heff","html_url":"https://github.com/heff","followers_url":"https://api.github.com/users/heff/followers","following_url":"https://api.github.com/users/heff/following{/other_user}","gists_url":"https://api.github.com/users/heff/gists{/gist_id}","starred_url":"https://api.github.com/users/heff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heff/subscriptions","organizations_url":"https://api.github.com/users/heff/orgs","repos_url":"https://api.github.com/users/heff/repos","events_url":"https://api.github.com/users/heff/events{/privacy}","received_events_url":"https://api.github.com/users/heff/received_events","type":"User","site_admin":false},"body":"Is there a reason this needs subclass CaptionsButton instead of TextTrackButton?\r\n\r\nIf I were to guess it would be because there doesn't appear to be any handling of native vs non-native tracks in TextTrackButton. @gkatsev is there a reason why that's in CaptionsButton and not TextTrackButton?","created_at":"2015-07-10T20:05:11Z","updated_at":"2015-07-10T20:05:11Z","html_url":"https://github.com/videojs/video.js/pull/2328#discussion_r34391196","pull_request_url":"https://api.github.com/repos/videojs/video.js/pulls/2328","_links":{"self":{"href":"https://api.github.com/repos/videojs/video.js/pulls/comments/34391196"},"html":{"href":"https://github.com/videojs/video.js/pull/2328#discussion_r34391196"},"pull_request":{"href":"https://api.github.com/repos/videojs/video.js/pulls/2328"}}},"pull_request":{"url":"https://api.github.com/repos/videojs/video.js/pulls/2328","id":39547319,"html_url":"https://github.com/videojs/video.js/pull/2328","diff_url":"https://github.com/videojs/video.js/pull/2328.diff","patch_url":"https://github.com/videojs/video.js/pull/2328.patch","issue_url":"https://api.github.com/repos/videojs/video.js/issues/2328","number":2328,"state":"open","locked":false,"title":"Support text descriptions tracks in v5.","user":{"login":"OwenEdwards","id":2245205,"avatar_url":"https://avatars.githubusercontent.com/u/2245205?v=3","gravatar_id":"","url":"https://api.github.com/users/OwenEdwards","html_url":"https://github.com/OwenEdwards","followers_url":"https://api.github.com/users/OwenEdwards/followers","following_url":"https://api.github.com/users/OwenEdwards/following{/other_user}","gists_url":"https://api.github.com/users/OwenEdwards/gists{/gist_id}","starred_url":"https://api.github.com/users/OwenEdwards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OwenEdwards/subscriptions","organizations_url":"https://api.github.com/users/OwenEdwards/orgs","repos_url":"https://api.github.com/users/OwenEdwards/repos","events_url":"https://api.github.com/users/OwenEdwards/events{/privacy}","received_events_url":"https://api.github.com/users/OwenEdwards/received_events","type":"User","site_admin":false},"body":"Add support for text descriptions tracks into video.js v5. Adds a control for 'audio description' tracks, and allows the tracks to be displayed and styled by the same control as closed captions. Also allows the description track to be hidden, but still read by a screen reader, for the use case where a user has a screen reader but doesn't want the text overlaying the video.\r\n\r\nAn example HTML file is included as `sandbox/descriptions.html.example`; the associated descriptions track, chapters track, and several captions tracks are in `docs/examples/shared/elephantsdream`.","created_at":"2015-07-09T04:30:53Z","updated_at":"2015-07-10T20:05:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2396e7f2a71d6a61156b85cb9cd4f48f6fabb07","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/videojs/video.js/pulls/2328/commits","review_comments_url":"https://api.github.com/repos/videojs/video.js/pulls/2328/comments","review_comment_url":"https://api.github.com/repos/videojs/video.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/videojs/video.js/issues/2328/comments","statuses_url":"https://api.github.com/repos/videojs/video.js/statuses/26e1b7b3e26ef4f96e63ccb8405c1c7857b128dd","head":{"label":"ICTASolutions:descriptions-track-support-for-v5","ref":"descriptions-track-support-for-v5","sha":"26e1b7b3e26ef4f96e63ccb8405c1c7857b128dd","user":{"login":"ICTASolutions","id":10732559,"avatar_url":"https://avatars.githubusercontent.com/u/10732559?v=3","gravatar_id":"","url":"https://api.github.com/users/ICTASolutions","html_url":"https://github.com/ICTASolutions","followers_url":"https://api.github.com/users/ICTASolutions/followers","following_url":"https://api.github.com/users/ICTASolutions/following{/other_user}","gists_url":"https://api.github.com/users/ICTASolutions/gists{/gist_id}","starred_url":"https://api.github.com/users/ICTASolutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ICTASolutions/subscriptions","organizations_url":"https://api.github.com/users/ICTASolutions/orgs","repos_url":"https://api.github.com/users/ICTASolutions/repos","events_url":"https://api.github.com/users/ICTASolutions/events{/privacy}","received_events_url":"https://api.github.com/users/ICTASolutions/received_events","type":"Organization","site_admin":false},"repo":{"id":34020961,"name":"video.js","full_name":"ICTASolutions/video.js","owner":{"login":"ICTASolutions","id":10732559,"avatar_url":"https://avatars.githubusercontent.com/u/10732559?v=3","gravatar_id":"","url":"https://api.github.com/users/ICTASolutions","html_url":"https://github.com/ICTASolutions","followers_url":"https://api.github.com/users/ICTASolutions/followers","following_url":"https://api.github.com/users/ICTASolutions/following{/other_user}","gists_url":"https://api.github.com/users/ICTASolutions/gists{/gist_id}","starred_url":"https://api.github.com/users/ICTASolutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ICTASolutions/subscriptions","organizations_url":"https://api.github.com/users/ICTASolutions/orgs","repos_url":"https://api.github.com/users/ICTASolutions/repos","events_url":"https://api.github.com/users/ICTASolutions/events{/privacy}","received_events_url":"https://api.github.com/users/ICTASolutions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ICTASolutions/video.js","description":"Video.js - open source HTML5 & Flash video player","fork":true,"url":"https://api.github.com/repos/ICTASolutions/video.js","forks_url":"https://api.github.com/repos/ICTASolutions/video.js/forks","keys_url":"https://api.github.com/repos/ICTASolutions/video.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ICTASolutions/video.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ICTASolutions/video.js/teams","hooks_url":"https://api.github.com/repos/ICTASolutions/video.js/hooks","issue_events_url":"https://api.github.com/repos/ICTASolutions/video.js/issues/events{/number}","events_url":"https://api.github.com/repos/ICTASolutions/video.js/events","assignees_url":"https://api.github.com/repos/ICTASolutions/video.js/assignees{/user}","branches_url":"https://api.github.com/repos/ICTASolutions/video.js/branches{/branch}","tags_url":"https://api.github.com/repos/ICTASolutions/video.js/tags","blobs_url":"https://api.github.com/repos/ICTASolutions/video.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ICTASolutions/video.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ICTASolutions/video.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/ICTASolutions/video.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ICTASolutions/video.js/statuses/{sha}","languages_url":"https://api.github.com/repos/ICTASolutions/video.js/languages","stargazers_url":"https://api.github.com/repos/ICTASolutions/video.js/stargazers","contributors_url":"https://api.github.com/repos/ICTASolutions/video.js/contributors","subscribers_url":"https://api.github.com/repos/ICTASolutions/video.js/subscribers","subscription_url":"https://api.github.com/repos/ICTASolutions/video.js/subscription","commits_url":"https://api.github.com/repos/ICTASolutions/video.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/ICTASolutions/video.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/ICTASolutions/video.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/ICTASolutions/video.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/ICTASolutions/video.js/contents/{+path}","compare_url":"https://api.github.com/repos/ICTASolutions/video.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ICTASolutions/video.js/merges","archive_url":"https://api.github.com/repos/ICTASolutions/video.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ICTASolutions/video.js/downloads","issues_url":"https://api.github.com/repos/ICTASolutions/video.js/issues{/number}","pulls_url":"https://api.github.com/repos/ICTASolutions/video.js/pulls{/number}","milestones_url":"https://api.github.com/repos/ICTASolutions/video.js/milestones{/number}","notifications_url":"https://api.github.com/repos/ICTASolutions/video.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ICTASolutions/video.js/labels{/name}","releases_url":"https://api.github.com/repos/ICTASolutions/video.js/releases{/id}","created_at":"2015-04-15T22:04:15Z","updated_at":"2015-04-15T22:04:18Z","pushed_at":"2015-07-09T04:18:11Z","git_url":"git://github.com/ICTASolutions/video.js.git","ssh_url":"git@github.com:ICTASolutions/video.js.git","clone_url":"https://github.com/ICTASolutions/video.js.git","svn_url":"https://github.com/ICTASolutions/video.js","homepage":"www.videojs.com","size":14074,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"videojs:master","ref":"master","sha":"004b1e8f7bfbae1749e7b141b9ccd45b3d1a5bca","user":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"repo":{"id":667006,"name":"video.js","full_name":"videojs/video.js","owner":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/videojs/video.js","description":"Video.js - open source HTML5 & Flash video player","fork":false,"url":"https://api.github.com/repos/videojs/video.js","forks_url":"https://api.github.com/repos/videojs/video.js/forks","keys_url":"https://api.github.com/repos/videojs/video.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/videojs/video.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/videojs/video.js/teams","hooks_url":"https://api.github.com/repos/videojs/video.js/hooks","issue_events_url":"https://api.github.com/repos/videojs/video.js/issues/events{/number}","events_url":"https://api.github.com/repos/videojs/video.js/events","assignees_url":"https://api.github.com/repos/videojs/video.js/assignees{/user}","branches_url":"https://api.github.com/repos/videojs/video.js/branches{/branch}","tags_url":"https://api.github.com/repos/videojs/video.js/tags","blobs_url":"https://api.github.com/repos/videojs/video.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/videojs/video.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/videojs/video.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/videojs/video.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/videojs/video.js/statuses/{sha}","languages_url":"https://api.github.com/repos/videojs/video.js/languages","stargazers_url":"https://api.github.com/repos/videojs/video.js/stargazers","contributors_url":"https://api.github.com/repos/videojs/video.js/contributors","subscribers_url":"https://api.github.com/repos/videojs/video.js/subscribers","subscription_url":"https://api.github.com/repos/videojs/video.js/subscription","commits_url":"https://api.github.com/repos/videojs/video.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/videojs/video.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/videojs/video.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/videojs/video.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/videojs/video.js/contents/{+path}","compare_url":"https://api.github.com/repos/videojs/video.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/videojs/video.js/merges","archive_url":"https://api.github.com/repos/videojs/video.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/videojs/video.js/downloads","issues_url":"https://api.github.com/repos/videojs/video.js/issues{/number}","pulls_url":"https://api.github.com/repos/videojs/video.js/pulls{/number}","milestones_url":"https://api.github.com/repos/videojs/video.js/milestones{/number}","notifications_url":"https://api.github.com/repos/videojs/video.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/videojs/video.js/labels{/name}","releases_url":"https://api.github.com/repos/videojs/video.js/releases{/id}","created_at":"2010-05-14T18:45:10Z","updated_at":"2015-07-10T18:49:46Z","pushed_at":"2015-07-10T19:42:30Z","git_url":"git://github.com/videojs/video.js.git","ssh_url":"git@github.com:videojs/video.js.git","clone_url":"https://github.com/videojs/video.js.git","svn_url":"https://github.com/videojs/video.js","homepage":"www.videojs.com","size":49777,"stargazers_count":9537,"watchers_count":9537,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":2719,"mirror_url":null,"open_issues_count":207,"forks":2719,"open_issues":207,"watchers":9537,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/videojs/video.js/pulls/2328"},"html":{"href":"https://github.com/videojs/video.js/pull/2328"},"issue":{"href":"https://api.github.com/repos/videojs/video.js/issues/2328"},"comments":{"href":"https://api.github.com/repos/videojs/video.js/issues/2328/comments"},"review_comments":{"href":"https://api.github.com/repos/videojs/video.js/pulls/2328/comments"},"review_comment":{"href":"https://api.github.com/repos/videojs/video.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/videojs/video.js/pulls/2328/commits"},"statuses":{"href":"https://api.github.com/repos/videojs/video.js/statuses/26e1b7b3e26ef4f96e63ccb8405c1c7857b128dd"}}}}