{"action":"created","issue":{"url":"https://api.github.com/repos/appcelerator/HAL/issues/29","labels_url":"https://api.github.com/repos/appcelerator/HAL/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/appcelerator/HAL/issues/29/comments","events_url":"https://api.github.com/repos/appcelerator/HAL/issues/29/events","html_url":"https://github.com/appcelerator/HAL/pull/29","id":56580460,"number":29,"title":"Build GTest from source - NOT READY FOR REVIEW","user":{"login":"sgtcoolguy","id":3252,"avatar_url":"https://avatars.githubusercontent.com/u/3252?v=3","gravatar_id":"","url":"https://api.github.com/users/sgtcoolguy","html_url":"https://github.com/sgtcoolguy","followers_url":"https://api.github.com/users/sgtcoolguy/followers","following_url":"https://api.github.com/users/sgtcoolguy/following{/other_user}","gists_url":"https://api.github.com/users/sgtcoolguy/gists{/gist_id}","starred_url":"https://api.github.com/users/sgtcoolguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgtcoolguy/subscriptions","organizations_url":"https://api.github.com/users/sgtcoolguy/orgs","repos_url":"https://api.github.com/users/sgtcoolguy/repos","events_url":"https://api.github.com/users/sgtcoolguy/events{/privacy}","received_events_url":"https://api.github.com/users/sgtcoolguy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-02-04T20:10:28Z","updated_at":"2015-10-07T02:39:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/appcelerator/HAL/pulls/29","html_url":"https://github.com/appcelerator/HAL/pull/29","diff_url":"https://github.com/appcelerator/HAL/pull/29.diff","patch_url":"https://github.com/appcelerator/HAL/pull/29.patch"},"body":"Currently we require a user to download a pre-compiled gtest and set GTEST_ROOT env variable to it's location. The build_and_test.sh script would try to do that for you (on mac).\r\n\r\nBut, we're running into problems with the pre-compiled version on Windows in TitaniumKit once we start specifying a CMAKE_SYSTEM_NAME and CMAKE_SYSTEM_VERSION (to set to WindowsPhone 8.1 or WindowsStore 8.1). Also, the gtest docs now say to compile from source because otherwise you can run into weird compile issues due to flags differing between the pre-compiled gtest and what you're building to test.\r\n\r\nThis does allow us to compile with those flags, though now we run into the issues of the generated exes being intended for the phone and therefore they won't execute normally under ctest."},"comment":{"url":"https://api.github.com/repos/appcelerator/HAL/issues/comments/146062148","html_url":"https://github.com/appcelerator/HAL/pull/29#issuecomment-146062148","issue_url":"https://api.github.com/repos/appcelerator/HAL/issues/29","id":146062148,"user":{"login":"infosia","id":1661068,"avatar_url":"https://avatars.githubusercontent.com/u/1661068?v=3","gravatar_id":"","url":"https://api.github.com/users/infosia","html_url":"https://github.com/infosia","followers_url":"https://api.github.com/users/infosia/followers","following_url":"https://api.github.com/users/infosia/following{/other_user}","gists_url":"https://api.github.com/users/infosia/gists{/gist_id}","starred_url":"https://api.github.com/users/infosia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infosia/subscriptions","organizations_url":"https://api.github.com/users/infosia/orgs","repos_url":"https://api.github.com/users/infosia/repos","events_url":"https://api.github.com/users/infosia/events{/privacy}","received_events_url":"https://api.github.com/users/infosia/received_events","type":"User","site_admin":false},"created_at":"2015-10-07T02:39:33Z","updated_at":"2015-10-07T02:39:33Z","body":"Looks good to me, tested on OS X, Windows 8.1 and Windows 10. :+1: Merging."}}