{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments/22876413","id":22876413,"diff_hunk":"@@ -37,22 +33,23 @@\n   [req]\n   (assoc-in req [:headers \"accept\"] \"text/plain\"))\n \n-(deftestseq metrics-set-handler\n+(let [app (server/build-app)]\n+  (deftestseq metrics-set-handler","path":"test/puppetlabs/puppetdb/http/metrics_test.clj","position":26,"original_position":26,"commit_id":"b4eea40f8dc3c2d9d8ccb47140b3b9f9eef58745","original_commit_id":"b4eea40f8dc3c2d9d8ccb47140b3b9f9eef58745","user":{"login":"wkalt","id":4952091,"avatar_url":"https://avatars.githubusercontent.com/u/4952091?v=3","gravatar_id":"","url":"https://api.github.com/users/wkalt","html_url":"https://github.com/wkalt","followers_url":"https://api.github.com/users/wkalt/followers","following_url":"https://api.github.com/users/wkalt/following{/other_user}","gists_url":"https://api.github.com/users/wkalt/gists{/gist_id}","starred_url":"https://api.github.com/users/wkalt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkalt/subscriptions","organizations_url":"https://api.github.com/users/wkalt/orgs","repos_url":"https://api.github.com/users/wkalt/repos","events_url":"https://api.github.com/users/wkalt/events{/privacy}","received_events_url":"https://api.github.com/users/wkalt/received_events","type":"User","site_admin":false},"body":"this seems strange to me. Any reason not to put the let inside the deftestseq?","created_at":"2015-01-13T17:05:07Z","updated_at":"2015-01-13T17:05:07Z","html_url":"https://github.com/puppetlabs/puppetdb/pull/1209#discussion_r22876413","pull_request_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1209","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments/22876413"},"html":{"href":"https://github.com/puppetlabs/puppetdb/pull/1209#discussion_r22876413"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1209"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1209","id":27138578,"html_url":"https://github.com/puppetlabs/puppetdb/pull/1209","diff_url":"https://github.com/puppetlabs/puppetdb/pull/1209.diff","patch_url":"https://github.com/puppetlabs/puppetdb/pull/1209.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1209","number":1209,"state":"open","locked":false,"title":"(PDB-800) Move metrics server to its own tk service","user":{"login":"ajroetker","id":3198124,"avatar_url":"https://avatars.githubusercontent.com/u/3198124?v=3","gravatar_id":"","url":"https://api.github.com/users/ajroetker","html_url":"https://github.com/ajroetker","followers_url":"https://api.github.com/users/ajroetker/followers","following_url":"https://api.github.com/users/ajroetker/following{/other_user}","gists_url":"https://api.github.com/users/ajroetker/gists{/gist_id}","starred_url":"https://api.github.com/users/ajroetker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajroetker/subscriptions","organizations_url":"https://api.github.com/users/ajroetker/orgs","repos_url":"https://api.github.com/users/ajroetker/repos","events_url":"https://api.github.com/users/ajroetker/events{/privacy}","received_events_url":"https://api.github.com/users/ajroetker/received_events","type":"User","site_admin":false},"body":"This commit moves the metrics endpoints to their own trapperkeeper\r\nservice, using the web-router-service to mount it and the\r\npuppetdb service at the appropriate routes.","created_at":"2015-01-09T23:51:38Z","updated_at":"2015-01-13T17:05:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4bde2341c7807db3602eeb9593d92c8cb7f89d12","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1209/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1209/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments/{number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1209/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/b4eea40f8dc3c2d9d8ccb47140b3b9f9eef58745","head":{"label":"ajroetker:PDB-800_Move_metrics_server_to_its_own_tk_service","ref":"PDB-800_Move_metrics_server_to_its_own_tk_service","sha":"b4eea40f8dc3c2d9d8ccb47140b3b9f9eef58745","user":{"login":"ajroetker","id":3198124,"avatar_url":"https://avatars.githubusercontent.com/u/3198124?v=3","gravatar_id":"","url":"https://api.github.com/users/ajroetker","html_url":"https://github.com/ajroetker","followers_url":"https://api.github.com/users/ajroetker/followers","following_url":"https://api.github.com/users/ajroetker/following{/other_user}","gists_url":"https://api.github.com/users/ajroetker/gists{/gist_id}","starred_url":"https://api.github.com/users/ajroetker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajroetker/subscriptions","organizations_url":"https://api.github.com/users/ajroetker/orgs","repos_url":"https://api.github.com/users/ajroetker/repos","events_url":"https://api.github.com/users/ajroetker/events{/privacy}","received_events_url":"https://api.github.com/users/ajroetker/received_events","type":"User","site_admin":false},"repo":{"id":10415180,"name":"puppetdb","full_name":"ajroetker/puppetdb","owner":{"login":"ajroetker","id":3198124,"avatar_url":"https://avatars.githubusercontent.com/u/3198124?v=3","gravatar_id":"","url":"https://api.github.com/users/ajroetker","html_url":"https://github.com/ajroetker","followers_url":"https://api.github.com/users/ajroetker/followers","following_url":"https://api.github.com/users/ajroetker/following{/other_user}","gists_url":"https://api.github.com/users/ajroetker/gists{/gist_id}","starred_url":"https://api.github.com/users/ajroetker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajroetker/subscriptions","organizations_url":"https://api.github.com/users/ajroetker/orgs","repos_url":"https://api.github.com/users/ajroetker/repos","events_url":"https://api.github.com/users/ajroetker/events{/privacy}","received_events_url":"https://api.github.com/users/ajroetker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ajroetker/puppetdb","description":"Centralized Puppet Storage","fork":true,"url":"https://api.github.com/repos/ajroetker/puppetdb","forks_url":"https://api.github.com/repos/ajroetker/puppetdb/forks","keys_url":"https://api.github.com/repos/ajroetker/puppetdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajroetker/puppetdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajroetker/puppetdb/teams","hooks_url":"https://api.github.com/repos/ajroetker/puppetdb/hooks","issue_events_url":"https://api.github.com/repos/ajroetker/puppetdb/issues/events{/number}","events_url":"https://api.github.com/repos/ajroetker/puppetdb/events","assignees_url":"https://api.github.com/repos/ajroetker/puppetdb/assignees{/user}","branches_url":"https://api.github.com/repos/ajroetker/puppetdb/branches{/branch}","tags_url":"https://api.github.com/repos/ajroetker/puppetdb/tags","blobs_url":"https://api.github.com/repos/ajroetker/puppetdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajroetker/puppetdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajroetker/puppetdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajroetker/puppetdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajroetker/puppetdb/statuses/{sha}","languages_url":"https://api.github.com/repos/ajroetker/puppetdb/languages","stargazers_url":"https://api.github.com/repos/ajroetker/puppetdb/stargazers","contributors_url":"https://api.github.com/repos/ajroetker/puppetdb/contributors","subscribers_url":"https://api.github.com/repos/ajroetker/puppetdb/subscribers","subscription_url":"https://api.github.com/repos/ajroetker/puppetdb/subscription","commits_url":"https://api.github.com/repos/ajroetker/puppetdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajroetker/puppetdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajroetker/puppetdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajroetker/puppetdb/issues/comments/{number}","contents_url":"https://api.github.com/repos/ajroetker/puppetdb/contents/{+path}","compare_url":"https://api.github.com/repos/ajroetker/puppetdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajroetker/puppetdb/merges","archive_url":"https://api.github.com/repos/ajroetker/puppetdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajroetker/puppetdb/downloads","issues_url":"https://api.github.com/repos/ajroetker/puppetdb/issues{/number}","pulls_url":"https://api.github.com/repos/ajroetker/puppetdb/pulls{/number}","milestones_url":"https://api.github.com/repos/ajroetker/puppetdb/milestones{/number}","notifications_url":"https://api.github.com/repos/ajroetker/puppetdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajroetker/puppetdb/labels{/name}","releases_url":"https://api.github.com/repos/ajroetker/puppetdb/releases{/id}","created_at":"2013-05-31T23:59:00Z","updated_at":"2015-01-02T21:47:47Z","pushed_at":"2015-01-13T16:55:21Z","git_url":"git://github.com/ajroetker/puppetdb.git","ssh_url":"git@github.com:ajroetker/puppetdb.git","clone_url":"https://github.com/ajroetker/puppetdb.git","svn_url":"https://github.com/ajroetker/puppetdb","homepage":"http://docs.puppetlabs.com/puppetdb","size":10987,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"5b65df96b240193051526f21d541d3550397138f","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":2193032,"name":"puppetdb","full_name":"puppetlabs/puppetdb","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetdb","description":"Centralized Puppet Storage","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetdb","forks_url":"https://api.github.com/repos/puppetlabs/puppetdb/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetdb/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetdb/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetdb/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetdb/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetdb/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetdb/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetdb/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetdb/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetdb/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetdb/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetdb/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/comments/{number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetdb/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetdb/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetdb/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetdb/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetdb/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetdb/releases{/id}","created_at":"2011-08-11T18:54:46Z","updated_at":"2015-01-12T15:18:20Z","pushed_at":"2015-01-13T00:52:22Z","git_url":"git://github.com/puppetlabs/puppetdb.git","ssh_url":"git@github.com:puppetlabs/puppetdb.git","clone_url":"https://github.com/puppetlabs/puppetdb.git","svn_url":"https://github.com/puppetlabs/puppetdb","homepage":"http://docs.puppetlabs.com/puppetdb","size":16983,"stargazers_count":155,"watchers_count":155,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":119,"mirror_url":null,"open_issues_count":7,"forks":119,"open_issues":7,"watchers":155,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1209"},"html":{"href":"https://github.com/puppetlabs/puppetdb/pull/1209"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1209"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1209/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1209/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1209/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/b4eea40f8dc3c2d9d8ccb47140b3b9f9eef58745"}}}}