{"action":"created","issue":{"url":"https://api.github.com/repos/brettwooldridge/HikariCP/issues/362","labels_url":"https://api.github.com/repos/brettwooldridge/HikariCP/issues/362/labels{/name}","comments_url":"https://api.github.com/repos/brettwooldridge/HikariCP/issues/362/comments","events_url":"https://api.github.com/repos/brettwooldridge/HikariCP/issues/362/events","html_url":"https://github.com/brettwooldridge/HikariCP/pull/362","id":98420653,"number":362,"title":"[2.3.x] Ensure closed connections returned to pool","user":{"login":"schlosna","id":54594,"avatar_url":"https://avatars.githubusercontent.com/u/54594?v=3","gravatar_id":"","url":"https://api.github.com/users/schlosna","html_url":"https://github.com/schlosna","followers_url":"https://api.github.com/users/schlosna/followers","following_url":"https://api.github.com/users/schlosna/following{/other_user}","gists_url":"https://api.github.com/users/schlosna/gists{/gist_id}","starred_url":"https://api.github.com/users/schlosna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schlosna/subscriptions","organizations_url":"https://api.github.com/users/schlosna/orgs","repos_url":"https://api.github.com/users/schlosna/repos","events_url":"https://api.github.com/users/schlosna/events{/privacy}","received_events_url":"https://api.github.com/users/schlosna/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-31T16:04:34Z","updated_at":"2015-07-31T18:04:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/brettwooldridge/HikariCP/pulls/362","html_url":"https://github.com/brettwooldridge/HikariCP/pull/362","diff_url":"https://github.com/brettwooldridge/HikariCP/pull/362.diff","patch_url":"https://github.com/brettwooldridge/HikariCP/pull/362.patch"},"body":"If an exception occurs while closing a connection's open statements\r\n(e.g. NullPointerException due to concurrent close of statement with\r\nconnection), the connection was not returned to the pool.\r\n\r\nWe now check for this possibility and ensure the connection is returned\r\nto the pool."},"comment":{"url":"https://api.github.com/repos/brettwooldridge/HikariCP/issues/comments/126772757","html_url":"https://github.com/brettwooldridge/HikariCP/pull/362#issuecomment-126772757","issue_url":"https://api.github.com/repos/brettwooldridge/HikariCP/issues/362","id":126772757,"user":{"login":"schlosna","id":54594,"avatar_url":"https://avatars.githubusercontent.com/u/54594?v=3","gravatar_id":"","url":"https://api.github.com/users/schlosna","html_url":"https://github.com/schlosna","followers_url":"https://api.github.com/users/schlosna/followers","following_url":"https://api.github.com/users/schlosna/following{/other_user}","gists_url":"https://api.github.com/users/schlosna/gists{/gist_id}","starred_url":"https://api.github.com/users/schlosna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schlosna/subscriptions","organizations_url":"https://api.github.com/users/schlosna/orgs","repos_url":"https://api.github.com/users/schlosna/repos","events_url":"https://api.github.com/users/schlosna/events{/privacy}","received_events_url":"https://api.github.com/users/schlosna/received_events","type":"User","site_admin":false},"created_at":"2015-07-31T18:04:20Z","updated_at":"2015-07-31T18:04:20Z","body":"Hi @brettwooldridge, thanks for the great work with Hikari! We recently switch some applications from c3p0 over to Hikari and have been running load tests and encountered the following NPE which seems like the same as issue #270. I realize that the JDBC spec does not require Connection, Statement, etc. to be thread safe, but I'd like to propose the changes on this PR to avoid these exceptions on close.\r\n\r\n```\r\njava.lang.NullPointerException\r\n\tat com.zaxxer.hikari.proxy.ConnectionProxy.close(ConnectionProxy.java:182)\r\n```"}}