{"action":"closed","number":106,"pull_request":{"url":"https://api.github.com/repos/denisenkom/go-mssqldb/pulls/106","id":38939702,"html_url":"https://github.com/denisenkom/go-mssqldb/pull/106","diff_url":"https://github.com/denisenkom/go-mssqldb/pull/106.diff","patch_url":"https://github.com/denisenkom/go-mssqldb/pull/106.patch","issue_url":"https://api.github.com/repos/denisenkom/go-mssqldb/issues/106","number":106,"state":"closed","locked":false,"title":"fix an issue where col data can be overwritten during Next()","user":{"login":"courtf","id":1542071,"avatar_url":"https://avatars.githubusercontent.com/u/1542071?v=3","gravatar_id":"","url":"https://api.github.com/users/courtf","html_url":"https://github.com/courtf","followers_url":"https://api.github.com/users/courtf/followers","following_url":"https://api.github.com/users/courtf/following{/other_user}","gists_url":"https://api.github.com/users/courtf/gists{/gist_id}","starred_url":"https://api.github.com/users/courtf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/courtf/subscriptions","organizations_url":"https://api.github.com/users/courtf/orgs","repos_url":"https://api.github.com/users/courtf/repos","events_url":"https://api.github.com/users/courtf/events{/privacy}","received_events_url":"https://api.github.com/users/courtf/received_events","type":"User","site_admin":false},"body":"hey there, I noticed an issue where often I would receive the same value in a column for two sequential rows when using rows.Next().  This is caused by slicing a buffer, which ends up reusing the backing array.  This happens every time on my binary(32) column, but making a copy like below fixes it.","created_at":"2015-07-01T01:00:20Z","updated_at":"2015-07-03T19:12:47Z","closed_at":"2015-07-03T19:12:47Z","merged_at":"2015-07-03T19:12:47Z","merge_commit_sha":"c0c21ae5820e79e79736faef7d80e211cb1c5380","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/denisenkom/go-mssqldb/pulls/106/commits","review_comments_url":"https://api.github.com/repos/denisenkom/go-mssqldb/pulls/106/comments","review_comment_url":"https://api.github.com/repos/denisenkom/go-mssqldb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/denisenkom/go-mssqldb/issues/106/comments","statuses_url":"https://api.github.com/repos/denisenkom/go-mssqldb/statuses/90c2c7e45621c9dd892a894c49ebacbee0267472","head":{"label":"courtf:dupe_col_vals_bug","ref":"dupe_col_vals_bug","sha":"90c2c7e45621c9dd892a894c49ebacbee0267472","user":{"login":"courtf","id":1542071,"avatar_url":"https://avatars.githubusercontent.com/u/1542071?v=3","gravatar_id":"","url":"https://api.github.com/users/courtf","html_url":"https://github.com/courtf","followers_url":"https://api.github.com/users/courtf/followers","following_url":"https://api.github.com/users/courtf/following{/other_user}","gists_url":"https://api.github.com/users/courtf/gists{/gist_id}","starred_url":"https://api.github.com/users/courtf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/courtf/subscriptions","organizations_url":"https://api.github.com/users/courtf/orgs","repos_url":"https://api.github.com/users/courtf/repos","events_url":"https://api.github.com/users/courtf/events{/privacy}","received_events_url":"https://api.github.com/users/courtf/received_events","type":"User","site_admin":false},"repo":{"id":38340769,"name":"go-mssqldb","full_name":"courtf/go-mssqldb","owner":{"login":"courtf","id":1542071,"avatar_url":"https://avatars.githubusercontent.com/u/1542071?v=3","gravatar_id":"","url":"https://api.github.com/users/courtf","html_url":"https://github.com/courtf","followers_url":"https://api.github.com/users/courtf/followers","following_url":"https://api.github.com/users/courtf/following{/other_user}","gists_url":"https://api.github.com/users/courtf/gists{/gist_id}","starred_url":"https://api.github.com/users/courtf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/courtf/subscriptions","organizations_url":"https://api.github.com/users/courtf/orgs","repos_url":"https://api.github.com/users/courtf/repos","events_url":"https://api.github.com/users/courtf/events{/privacy}","received_events_url":"https://api.github.com/users/courtf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/courtf/go-mssqldb","description":"Microsoft SQL server driver written in go language","fork":true,"url":"https://api.github.com/repos/courtf/go-mssqldb","forks_url":"https://api.github.com/repos/courtf/go-mssqldb/forks","keys_url":"https://api.github.com/repos/courtf/go-mssqldb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/courtf/go-mssqldb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/courtf/go-mssqldb/teams","hooks_url":"https://api.github.com/repos/courtf/go-mssqldb/hooks","issue_events_url":"https://api.github.com/repos/courtf/go-mssqldb/issues/events{/number}","events_url":"https://api.github.com/repos/courtf/go-mssqldb/events","assignees_url":"https://api.github.com/repos/courtf/go-mssqldb/assignees{/user}","branches_url":"https://api.github.com/repos/courtf/go-mssqldb/branches{/branch}","tags_url":"https://api.github.com/repos/courtf/go-mssqldb/tags","blobs_url":"https://api.github.com/repos/courtf/go-mssqldb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/courtf/go-mssqldb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/courtf/go-mssqldb/git/refs{/sha}","trees_url":"https://api.github.com/repos/courtf/go-mssqldb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/courtf/go-mssqldb/statuses/{sha}","languages_url":"https://api.github.com/repos/courtf/go-mssqldb/languages","stargazers_url":"https://api.github.com/repos/courtf/go-mssqldb/stargazers","contributors_url":"https://api.github.com/repos/courtf/go-mssqldb/contributors","subscribers_url":"https://api.github.com/repos/courtf/go-mssqldb/subscribers","subscription_url":"https://api.github.com/repos/courtf/go-mssqldb/subscription","commits_url":"https://api.github.com/repos/courtf/go-mssqldb/commits{/sha}","git_commits_url":"https://api.github.com/repos/courtf/go-mssqldb/git/commits{/sha}","comments_url":"https://api.github.com/repos/courtf/go-mssqldb/comments{/number}","issue_comment_url":"https://api.github.com/repos/courtf/go-mssqldb/issues/comments{/number}","contents_url":"https://api.github.com/repos/courtf/go-mssqldb/contents/{+path}","compare_url":"https://api.github.com/repos/courtf/go-mssqldb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/courtf/go-mssqldb/merges","archive_url":"https://api.github.com/repos/courtf/go-mssqldb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/courtf/go-mssqldb/downloads","issues_url":"https://api.github.com/repos/courtf/go-mssqldb/issues{/number}","pulls_url":"https://api.github.com/repos/courtf/go-mssqldb/pulls{/number}","milestones_url":"https://api.github.com/repos/courtf/go-mssqldb/milestones{/number}","notifications_url":"https://api.github.com/repos/courtf/go-mssqldb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/courtf/go-mssqldb/labels{/name}","releases_url":"https://api.github.com/repos/courtf/go-mssqldb/releases{/id}","created_at":"2015-07-01T00:50:02Z","updated_at":"2015-07-01T00:50:03Z","pushed_at":"2015-07-01T02:04:08Z","git_url":"git://github.com/courtf/go-mssqldb.git","ssh_url":"git@github.com:courtf/go-mssqldb.git","clone_url":"https://github.com/courtf/go-mssqldb.git","svn_url":"https://github.com/courtf/go-mssqldb","homepage":"","size":820,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"denisenkom:master","ref":"master","sha":"3fc47c72c5377f66a4bb00da4f56bc91b8fe73cb","user":{"login":"denisenkom","id":2815692,"avatar_url":"https://avatars.githubusercontent.com/u/2815692?v=3","gravatar_id":"","url":"https://api.github.com/users/denisenkom","html_url":"https://github.com/denisenkom","followers_url":"https://api.github.com/users/denisenkom/followers","following_url":"https://api.github.com/users/denisenkom/following{/other_user}","gists_url":"https://api.github.com/users/denisenkom/gists{/gist_id}","starred_url":"https://api.github.com/users/denisenkom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denisenkom/subscriptions","organizations_url":"https://api.github.com/users/denisenkom/orgs","repos_url":"https://api.github.com/users/denisenkom/repos","events_url":"https://api.github.com/users/denisenkom/events{/privacy}","received_events_url":"https://api.github.com/users/denisenkom/received_events","type":"User","site_admin":false},"repo":{"id":15213446,"name":"go-mssqldb","full_name":"denisenkom/go-mssqldb","owner":{"login":"denisenkom","id":2815692,"avatar_url":"https://avatars.githubusercontent.com/u/2815692?v=3","gravatar_id":"","url":"https://api.github.com/users/denisenkom","html_url":"https://github.com/denisenkom","followers_url":"https://api.github.com/users/denisenkom/followers","following_url":"https://api.github.com/users/denisenkom/following{/other_user}","gists_url":"https://api.github.com/users/denisenkom/gists{/gist_id}","starred_url":"https://api.github.com/users/denisenkom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denisenkom/subscriptions","organizations_url":"https://api.github.com/users/denisenkom/orgs","repos_url":"https://api.github.com/users/denisenkom/repos","events_url":"https://api.github.com/users/denisenkom/events{/privacy}","received_events_url":"https://api.github.com/users/denisenkom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/denisenkom/go-mssqldb","description":"Microsoft SQL server driver written in go language","fork":false,"url":"https://api.github.com/repos/denisenkom/go-mssqldb","forks_url":"https://api.github.com/repos/denisenkom/go-mssqldb/forks","keys_url":"https://api.github.com/repos/denisenkom/go-mssqldb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/denisenkom/go-mssqldb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/denisenkom/go-mssqldb/teams","hooks_url":"https://api.github.com/repos/denisenkom/go-mssqldb/hooks","issue_events_url":"https://api.github.com/repos/denisenkom/go-mssqldb/issues/events{/number}","events_url":"https://api.github.com/repos/denisenkom/go-mssqldb/events","assignees_url":"https://api.github.com/repos/denisenkom/go-mssqldb/assignees{/user}","branches_url":"https://api.github.com/repos/denisenkom/go-mssqldb/branches{/branch}","tags_url":"https://api.github.com/repos/denisenkom/go-mssqldb/tags","blobs_url":"https://api.github.com/repos/denisenkom/go-mssqldb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/denisenkom/go-mssqldb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/denisenkom/go-mssqldb/git/refs{/sha}","trees_url":"https://api.github.com/repos/denisenkom/go-mssqldb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/denisenkom/go-mssqldb/statuses/{sha}","languages_url":"https://api.github.com/repos/denisenkom/go-mssqldb/languages","stargazers_url":"https://api.github.com/repos/denisenkom/go-mssqldb/stargazers","contributors_url":"https://api.github.com/repos/denisenkom/go-mssqldb/contributors","subscribers_url":"https://api.github.com/repos/denisenkom/go-mssqldb/subscribers","subscription_url":"https://api.github.com/repos/denisenkom/go-mssqldb/subscription","commits_url":"https://api.github.com/repos/denisenkom/go-mssqldb/commits{/sha}","git_commits_url":"https://api.github.com/repos/denisenkom/go-mssqldb/git/commits{/sha}","comments_url":"https://api.github.com/repos/denisenkom/go-mssqldb/comments{/number}","issue_comment_url":"https://api.github.com/repos/denisenkom/go-mssqldb/issues/comments{/number}","contents_url":"https://api.github.com/repos/denisenkom/go-mssqldb/contents/{+path}","compare_url":"https://api.github.com/repos/denisenkom/go-mssqldb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/denisenkom/go-mssqldb/merges","archive_url":"https://api.github.com/repos/denisenkom/go-mssqldb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/denisenkom/go-mssqldb/downloads","issues_url":"https://api.github.com/repos/denisenkom/go-mssqldb/issues{/number}","pulls_url":"https://api.github.com/repos/denisenkom/go-mssqldb/pulls{/number}","milestones_url":"https://api.github.com/repos/denisenkom/go-mssqldb/milestones{/number}","notifications_url":"https://api.github.com/repos/denisenkom/go-mssqldb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/denisenkom/go-mssqldb/labels{/name}","releases_url":"https://api.github.com/repos/denisenkom/go-mssqldb/releases{/id}","created_at":"2013-12-16T00:10:47Z","updated_at":"2015-07-01T00:16:28Z","pushed_at":"2015-07-03T19:12:47Z","git_url":"git://github.com/denisenkom/go-mssqldb.git","ssh_url":"git@github.com:denisenkom/go-mssqldb.git","clone_url":"https://github.com/denisenkom/go-mssqldb.git","svn_url":"https://github.com/denisenkom/go-mssqldb","homepage":"","size":1703,"stargazers_count":171,"watchers_count":171,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":17,"forks":35,"open_issues":17,"watchers":171,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/denisenkom/go-mssqldb/pulls/106"},"html":{"href":"https://github.com/denisenkom/go-mssqldb/pull/106"},"issue":{"href":"https://api.github.com/repos/denisenkom/go-mssqldb/issues/106"},"comments":{"href":"https://api.github.com/repos/denisenkom/go-mssqldb/issues/106/comments"},"review_comments":{"href":"https://api.github.com/repos/denisenkom/go-mssqldb/pulls/106/comments"},"review_comment":{"href":"https://api.github.com/repos/denisenkom/go-mssqldb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/denisenkom/go-mssqldb/pulls/106/commits"},"statuses":{"href":"https://api.github.com/repos/denisenkom/go-mssqldb/statuses/90c2c7e45621c9dd892a894c49ebacbee0267472"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"denisenkom","id":2815692,"avatar_url":"https://avatars.githubusercontent.com/u/2815692?v=3","gravatar_id":"","url":"https://api.github.com/users/denisenkom","html_url":"https://github.com/denisenkom","followers_url":"https://api.github.com/users/denisenkom/followers","following_url":"https://api.github.com/users/denisenkom/following{/other_user}","gists_url":"https://api.github.com/users/denisenkom/gists{/gist_id}","starred_url":"https://api.github.com/users/denisenkom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denisenkom/subscriptions","organizations_url":"https://api.github.com/users/denisenkom/orgs","repos_url":"https://api.github.com/users/denisenkom/repos","events_url":"https://api.github.com/users/denisenkom/events{/privacy}","received_events_url":"https://api.github.com/users/denisenkom/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":12,"deletions":2,"changed_files":1}}