{"action":"closed","number":7973,"pull_request":{"url":"https://api.github.com/repos/contao/core/pulls/7973","id":42667197,"html_url":"https://github.com/contao/core/pull/7973","diff_url":"https://github.com/contao/core/pull/7973.diff","patch_url":"https://github.com/contao/core/pull/7973.patch","issue_url":"https://api.github.com/repos/contao/core/issues/7973","number":7973,"state":"closed","locked":false,"title":"Fix phpdoc return type of static find* methods.","user":{"login":"dmolineus","id":1186266,"avatar_url":"https://avatars.githubusercontent.com/u/1186266?v=3","gravatar_id":"","url":"https://api.github.com/users/dmolineus","html_url":"https://github.com/dmolineus","followers_url":"https://api.github.com/users/dmolineus/followers","following_url":"https://api.github.com/users/dmolineus/following{/other_user}","gists_url":"https://api.github.com/users/dmolineus/gists{/gist_id}","starred_url":"https://api.github.com/users/dmolineus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmolineus/subscriptions","organizations_url":"https://api.github.com/users/dmolineus/orgs","repos_url":"https://api.github.com/users/dmolineus/repos","events_url":"https://api.github.com/users/dmolineus/events{/privacy}","received_events_url":"https://api.github.com/users/dmolineus/received_events","type":"User","site_admin":false},"body":"[PhpSpec](http://www.phpspec.net/) within a Contao project stops working after the magic methods got documented. It's caused by the wrong usage of `$this` when documenting static methods. It does not make any sense to use it here as there is no instance of the class.\r\n\r\nPHPSpec uses the phpdoc to generate their double classes and creates wrappers for the methods.\r\n\r\nI guess it was added because of IDE support. But I really prefer keeping such great tools like phpspec working over fixing IDE issues.\r\n\r\nThis pull request replaces the `$this` return value by the actual used class.","created_at":"2015-08-18T07:03:13Z","updated_at":"2015-08-21T09:09:28Z","closed_at":"2015-08-21T09:09:28Z","merged_at":null,"merge_commit_sha":"cac8c2ca342f7853b60174df3f45adba8643e542","assignee":null,"milestone":{"url":"https://api.github.com/repos/contao/core/milestones/112","html_url":"https://github.com/contao/core/milestones/3.5.3","labels_url":"https://api.github.com/repos/contao/core/milestones/112/labels","id":1226977,"number":112,"title":"3.5.3","description":"Contao 3.5.3 (bugfix release)","creator":{"login":"leofeyer","id":1192057,"avatar_url":"https://avatars.githubusercontent.com/u/1192057?v=3","gravatar_id":"","url":"https://api.github.com/users/leofeyer","html_url":"https://github.com/leofeyer","followers_url":"https://api.github.com/users/leofeyer/followers","following_url":"https://api.github.com/users/leofeyer/following{/other_user}","gists_url":"https://api.github.com/users/leofeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/leofeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leofeyer/subscriptions","organizations_url":"https://api.github.com/users/leofeyer/orgs","repos_url":"https://api.github.com/users/leofeyer/repos","events_url":"https://api.github.com/users/leofeyer/events{/privacy}","received_events_url":"https://api.github.com/users/leofeyer/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":21,"state":"open","created_at":"2015-07-27T07:31:06Z","updated_at":"2015-08-21T09:09:28Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/contao/core/pulls/7973/commits","review_comments_url":"https://api.github.com/repos/contao/core/pulls/7973/comments","review_comment_url":"https://api.github.com/repos/contao/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/contao/core/issues/7973/comments","statuses_url":"https://api.github.com/repos/contao/core/statuses/83688357e22c84b81907230c65f74ba020e8f9f6","head":{"label":"dmolineus:fix/phpdoc-return-values","ref":"fix/phpdoc-return-values","sha":"83688357e22c84b81907230c65f74ba020e8f9f6","user":{"login":"dmolineus","id":1186266,"avatar_url":"https://avatars.githubusercontent.com/u/1186266?v=3","gravatar_id":"","url":"https://api.github.com/users/dmolineus","html_url":"https://github.com/dmolineus","followers_url":"https://api.github.com/users/dmolineus/followers","following_url":"https://api.github.com/users/dmolineus/following{/other_user}","gists_url":"https://api.github.com/users/dmolineus/gists{/gist_id}","starred_url":"https://api.github.com/users/dmolineus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmolineus/subscriptions","organizations_url":"https://api.github.com/users/dmolineus/orgs","repos_url":"https://api.github.com/users/dmolineus/repos","events_url":"https://api.github.com/users/dmolineus/events{/privacy}","received_events_url":"https://api.github.com/users/dmolineus/received_events","type":"User","site_admin":false},"repo":{"id":12556841,"name":"contao-core","full_name":"dmolineus/contao-core","owner":{"login":"dmolineus","id":1186266,"avatar_url":"https://avatars.githubusercontent.com/u/1186266?v=3","gravatar_id":"","url":"https://api.github.com/users/dmolineus","html_url":"https://github.com/dmolineus","followers_url":"https://api.github.com/users/dmolineus/followers","following_url":"https://api.github.com/users/dmolineus/following{/other_user}","gists_url":"https://api.github.com/users/dmolineus/gists{/gist_id}","starred_url":"https://api.github.com/users/dmolineus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmolineus/subscriptions","organizations_url":"https://api.github.com/users/dmolineus/orgs","repos_url":"https://api.github.com/users/dmolineus/repos","events_url":"https://api.github.com/users/dmolineus/events{/privacy}","received_events_url":"https://api.github.com/users/dmolineus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmolineus/contao-core","description":"Contao Open Source CMS","fork":true,"url":"https://api.github.com/repos/dmolineus/contao-core","forks_url":"https://api.github.com/repos/dmolineus/contao-core/forks","keys_url":"https://api.github.com/repos/dmolineus/contao-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmolineus/contao-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmolineus/contao-core/teams","hooks_url":"https://api.github.com/repos/dmolineus/contao-core/hooks","issue_events_url":"https://api.github.com/repos/dmolineus/contao-core/issues/events{/number}","events_url":"https://api.github.com/repos/dmolineus/contao-core/events","assignees_url":"https://api.github.com/repos/dmolineus/contao-core/assignees{/user}","branches_url":"https://api.github.com/repos/dmolineus/contao-core/branches{/branch}","tags_url":"https://api.github.com/repos/dmolineus/contao-core/tags","blobs_url":"https://api.github.com/repos/dmolineus/contao-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmolineus/contao-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmolineus/contao-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmolineus/contao-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmolineus/contao-core/statuses/{sha}","languages_url":"https://api.github.com/repos/dmolineus/contao-core/languages","stargazers_url":"https://api.github.com/repos/dmolineus/contao-core/stargazers","contributors_url":"https://api.github.com/repos/dmolineus/contao-core/contributors","subscribers_url":"https://api.github.com/repos/dmolineus/contao-core/subscribers","subscription_url":"https://api.github.com/repos/dmolineus/contao-core/subscription","commits_url":"https://api.github.com/repos/dmolineus/contao-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmolineus/contao-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmolineus/contao-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmolineus/contao-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmolineus/contao-core/contents/{+path}","compare_url":"https://api.github.com/repos/dmolineus/contao-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmolineus/contao-core/merges","archive_url":"https://api.github.com/repos/dmolineus/contao-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmolineus/contao-core/downloads","issues_url":"https://api.github.com/repos/dmolineus/contao-core/issues{/number}","pulls_url":"https://api.github.com/repos/dmolineus/contao-core/pulls{/number}","milestones_url":"https://api.github.com/repos/dmolineus/contao-core/milestones{/number}","notifications_url":"https://api.github.com/repos/dmolineus/contao-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmolineus/contao-core/labels{/name}","releases_url":"https://api.github.com/repos/dmolineus/contao-core/releases{/id}","created_at":"2013-09-03T06:39:10Z","updated_at":"2014-07-17T08:27:38Z","pushed_at":"2015-08-21T05:24:38Z","git_url":"git://github.com/dmolineus/contao-core.git","ssh_url":"git@github.com:dmolineus/contao-core.git","clone_url":"https://github.com/dmolineus/contao-core.git","svn_url":"https://github.com/dmolineus/contao-core","homepage":"","size":68196,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"contao:develop","ref":"develop","sha":"3c671bff95fe56b71ed5799142c32e556576c032","user":{"login":"contao","id":1206136,"avatar_url":"https://avatars.githubusercontent.com/u/1206136?v=3","gravatar_id":"","url":"https://api.github.com/users/contao","html_url":"https://github.com/contao","followers_url":"https://api.github.com/users/contao/followers","following_url":"https://api.github.com/users/contao/following{/other_user}","gists_url":"https://api.github.com/users/contao/gists{/gist_id}","starred_url":"https://api.github.com/users/contao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contao/subscriptions","organizations_url":"https://api.github.com/users/contao/orgs","repos_url":"https://api.github.com/users/contao/repos","events_url":"https://api.github.com/users/contao/events{/privacy}","received_events_url":"https://api.github.com/users/contao/received_events","type":"Organization","site_admin":false},"repo":{"id":2875825,"name":"core","full_name":"contao/core","owner":{"login":"contao","id":1206136,"avatar_url":"https://avatars.githubusercontent.com/u/1206136?v=3","gravatar_id":"","url":"https://api.github.com/users/contao","html_url":"https://github.com/contao","followers_url":"https://api.github.com/users/contao/followers","following_url":"https://api.github.com/users/contao/following{/other_user}","gists_url":"https://api.github.com/users/contao/gists{/gist_id}","starred_url":"https://api.github.com/users/contao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contao/subscriptions","organizations_url":"https://api.github.com/users/contao/orgs","repos_url":"https://api.github.com/users/contao/repos","events_url":"https://api.github.com/users/contao/events{/privacy}","received_events_url":"https://api.github.com/users/contao/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/contao/core","description":"Contao Open Source CMS","fork":false,"url":"https://api.github.com/repos/contao/core","forks_url":"https://api.github.com/repos/contao/core/forks","keys_url":"https://api.github.com/repos/contao/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/contao/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/contao/core/teams","hooks_url":"https://api.github.com/repos/contao/core/hooks","issue_events_url":"https://api.github.com/repos/contao/core/issues/events{/number}","events_url":"https://api.github.com/repos/contao/core/events","assignees_url":"https://api.github.com/repos/contao/core/assignees{/user}","branches_url":"https://api.github.com/repos/contao/core/branches{/branch}","tags_url":"https://api.github.com/repos/contao/core/tags","blobs_url":"https://api.github.com/repos/contao/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/contao/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/contao/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/contao/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/contao/core/statuses/{sha}","languages_url":"https://api.github.com/repos/contao/core/languages","stargazers_url":"https://api.github.com/repos/contao/core/stargazers","contributors_url":"https://api.github.com/repos/contao/core/contributors","subscribers_url":"https://api.github.com/repos/contao/core/subscribers","subscription_url":"https://api.github.com/repos/contao/core/subscription","commits_url":"https://api.github.com/repos/contao/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/contao/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/contao/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/contao/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/contao/core/contents/{+path}","compare_url":"https://api.github.com/repos/contao/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/contao/core/merges","archive_url":"https://api.github.com/repos/contao/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/contao/core/downloads","issues_url":"https://api.github.com/repos/contao/core/issues{/number}","pulls_url":"https://api.github.com/repos/contao/core/pulls{/number}","milestones_url":"https://api.github.com/repos/contao/core/milestones{/number}","notifications_url":"https://api.github.com/repos/contao/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/contao/core/labels{/name}","releases_url":"https://api.github.com/repos/contao/core/releases{/id}","created_at":"2011-11-29T15:24:38Z","updated_at":"2015-08-16T19:23:46Z","pushed_at":"2015-08-21T09:08:41Z","git_url":"git://github.com/contao/core.git","ssh_url":"git@github.com:contao/core.git","clone_url":"https://github.com/contao/core.git","svn_url":"https://github.com/contao/core","homepage":"","size":109465,"stargazers_count":477,"watchers_count":477,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":237,"mirror_url":null,"open_issues_count":591,"forks":237,"open_issues":591,"watchers":477,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/contao/core/pulls/7973"},"html":{"href":"https://github.com/contao/core/pull/7973"},"issue":{"href":"https://api.github.com/repos/contao/core/issues/7973"},"comments":{"href":"https://api.github.com/repos/contao/core/issues/7973/comments"},"review_comments":{"href":"https://api.github.com/repos/contao/core/pulls/7973/comments"},"review_comment":{"href":"https://api.github.com/repos/contao/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/contao/core/pulls/7973/commits"},"statuses":{"href":"https://api.github.com/repos/contao/core/statuses/83688357e22c84b81907230c65f74ba020e8f9f6"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":16,"review_comments":0,"commits":2,"additions":1778,"deletions":1778,"changed_files":31}}