{"action":"created","issue":{"url":"https://api.github.com/repos/the-tcpdump-group/libpcap/issues/453","labels_url":"https://api.github.com/repos/the-tcpdump-group/libpcap/issues/453/labels{/name}","comments_url":"https://api.github.com/repos/the-tcpdump-group/libpcap/issues/453/comments","events_url":"https://api.github.com/repos/the-tcpdump-group/libpcap/issues/453/events","html_url":"https://github.com/the-tcpdump-group/libpcap/pull/453","id":104008390,"number":453,"title":"WIN32 and _WIN32 macros","user":{"login":"ujos","id":70940,"avatar_url":"https://avatars.githubusercontent.com/u/70940?v=3","gravatar_id":"","url":"https://api.github.com/users/ujos","html_url":"https://github.com/ujos","followers_url":"https://api.github.com/users/ujos/followers","following_url":"https://api.github.com/users/ujos/following{/other_user}","gists_url":"https://api.github.com/users/ujos/gists{/gist_id}","starred_url":"https://api.github.com/users/ujos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ujos/subscriptions","organizations_url":"https://api.github.com/users/ujos/orgs","repos_url":"https://api.github.com/users/ujos/repos","events_url":"https://api.github.com/users/ujos/events{/privacy}","received_events_url":"https://api.github.com/users/ujos/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":23,"created_at":"2015-08-31T08:20:42Z","updated_at":"2015-09-22T03:29:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/the-tcpdump-group/libpcap/pulls/453","html_url":"https://github.com/the-tcpdump-group/libpcap/pull/453","diff_url":"https://github.com/the-tcpdump-group/libpcap/pull/453.diff","patch_url":"https://github.com/the-tcpdump-group/libpcap/pull/453.patch"},"body":"Hi\r\n\r\nThere is issue with libpcap on Windows. When you create new application and include pcap.h file, you have compilation error like:\r\n\r\nfatal error C1083: Cannot open include file: 'sys/time.h': No such file or directory\r\n\r\nThe reason is \"#if defined(WIN32)\". This macro is not standard macro and compiler does not create it by default. However there is another one \"_WIN32\" which is defined by Visual C++ compiler by default. I believe we should use it instead of WIN32. \r\n\r\nIn my fork I've fixed this also fixed some ADAPTER/Adapter type issues. Code successfully compiles with WinPcap 4.1.3 (with some changes inside WinPcap)\r\n\r\nThanks\r\nDima\r\n"},"comment":{"url":"https://api.github.com/repos/the-tcpdump-group/libpcap/issues/comments/142170116","html_url":"https://github.com/the-tcpdump-group/libpcap/pull/453#issuecomment-142170116","issue_url":"https://api.github.com/repos/the-tcpdump-group/libpcap/issues/453","id":142170116,"user":{"login":"fxlb","id":2846004,"avatar_url":"https://avatars.githubusercontent.com/u/2846004?v=3","gravatar_id":"","url":"https://api.github.com/users/fxlb","html_url":"https://github.com/fxlb","followers_url":"https://api.github.com/users/fxlb/followers","following_url":"https://api.github.com/users/fxlb/following{/other_user}","gists_url":"https://api.github.com/users/fxlb/gists{/gist_id}","starred_url":"https://api.github.com/users/fxlb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fxlb/subscriptions","organizations_url":"https://api.github.com/users/fxlb/orgs","repos_url":"https://api.github.com/users/fxlb/repos","events_url":"https://api.github.com/users/fxlb/events{/privacy}","received_events_url":"https://api.github.com/users/fxlb/received_events","type":"User","site_admin":false},"created_at":"2015-09-22T03:29:53Z","updated_at":"2015-09-22T03:29:53Z","body":"Some of your previous changes have also newlines at end of lines.\r\n\r\nFor changes like `s/snprintf/pcap_snprintf/`, a shell line with a for loop and a sed command is very effective.\r\n"}}