{"action":"created","issue":{"url":"https://api.github.com/repos/Theano/Theano/issues/3500","labels_url":"https://api.github.com/repos/Theano/Theano/issues/3500/labels{/name}","comments_url":"https://api.github.com/repos/Theano/Theano/issues/3500/comments","events_url":"https://api.github.com/repos/Theano/Theano/issues/3500/events","html_url":"https://github.com/Theano/Theano/pull/3500","id":110113411,"number":3500,"title":"map_variables: deal with cached constants","user":{"login":"cooijmanstim","id":206920,"avatar_url":"https://avatars.githubusercontent.com/u/206920?v=3","gravatar_id":"","url":"https://api.github.com/users/cooijmanstim","html_url":"https://github.com/cooijmanstim","followers_url":"https://api.github.com/users/cooijmanstim/followers","following_url":"https://api.github.com/users/cooijmanstim/following{/other_user}","gists_url":"https://api.github.com/users/cooijmanstim/gists{/gist_id}","starred_url":"https://api.github.com/users/cooijmanstim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cooijmanstim/subscriptions","organizations_url":"https://api.github.com/users/cooijmanstim/orgs","repos_url":"https://api.github.com/users/cooijmanstim/repos","events_url":"https://api.github.com/users/cooijmanstim/events{/privacy}","received_events_url":"https://api.github.com/users/cooijmanstim/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-10-06T22:19:52Z","updated_at":"2015-11-09T16:53:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Theano/Theano/pulls/3500","html_url":"https://github.com/Theano/Theano/pull/3500","diff_url":"https://github.com/Theano/Theano/pull/3500.diff","patch_url":"https://github.com/Theano/Theano/pull/3500.patch"},"body":"map_variables fails when expressions that are not simply inputs are replaced by expressions that contain cached constants. This PR adds a failing test and a patch to fix the problem. Also, the argument additional_inputs is no longer needed as newly introduced inputs are automatically added using FunctionGraph.add_input."},"comment":{"url":"https://api.github.com/repos/Theano/Theano/issues/comments/155121345","html_url":"https://github.com/Theano/Theano/pull/3500#issuecomment-155121345","issue_url":"https://api.github.com/repos/Theano/Theano/issues/3500","id":155121345,"user":{"login":"lamblin","id":178249,"avatar_url":"https://avatars.githubusercontent.com/u/178249?v=3","gravatar_id":"","url":"https://api.github.com/users/lamblin","html_url":"https://github.com/lamblin","followers_url":"https://api.github.com/users/lamblin/followers","following_url":"https://api.github.com/users/lamblin/following{/other_user}","gists_url":"https://api.github.com/users/lamblin/gists{/gist_id}","starred_url":"https://api.github.com/users/lamblin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamblin/subscriptions","organizations_url":"https://api.github.com/users/lamblin/orgs","repos_url":"https://api.github.com/users/lamblin/repos","events_url":"https://api.github.com/users/lamblin/events{/privacy}","received_events_url":"https://api.github.com/users/lamblin/received_events","type":"User","site_admin":false},"created_at":"2015-11-09T16:53:15Z","updated_at":"2015-11-09T16:53:15Z","body":"I would prefer that to be part of Theano, actually, since that can be a useful feature to expose to people using Theano at the graph-manipulation level. Not sure what the others are thinging."}}