{"action":"created","comment":{"url":"https://api.github.com/repos/aws/aws-sdk-java/pulls/comments/48067965","id":48067965,"diff_hunk":"@@ -107,7 +107,9 @@ private AuthRetryParameters redirectToS3External() {\n     }\n \n     private AWSS3V4Signer buildSigV4Signer(final String region) {\n-        AWSS3V4Signer v4Signer = new AWSS3V4Signer();\n+        // Retry with chunkedEncoding set to true.\n+        boolean isChunkedEncoding = true;\n+        AWSS3V4Signer v4Signer = new AWSS3V4Signer(isChunkedEncoding);","path":"aws-java-sdk-s3/src/main/java/com/amazonaws/services/s3/internal/S3V4AuthErrorRetryStrategy.java","position":16,"original_position":16,"commit_id":"3e14d5dda6b4538ae8878111383078211656f17d","original_commit_id":"3e14d5dda6b4538ae8878111383078211656f17d","user":{"login":"shorea","id":11096681,"avatar_url":"https://avatars.githubusercontent.com/u/11096681?v=3","gravatar_id":"","url":"https://api.github.com/users/shorea","html_url":"https://github.com/shorea","followers_url":"https://api.github.com/users/shorea/followers","following_url":"https://api.github.com/users/shorea/following{/other_user}","gists_url":"https://api.github.com/users/shorea/gists{/gist_id}","starred_url":"https://api.github.com/users/shorea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shorea/subscriptions","organizations_url":"https://api.github.com/users/shorea/orgs","repos_url":"https://api.github.com/users/shorea/repos","events_url":"https://api.github.com/users/shorea/events{/privacy}","received_events_url":"https://api.github.com/users/shorea/received_events","type":"User","site_admin":false},"body":"For your use case this class will never be used so this is fine but it may be confusing if another developer sets the configuration option and it isn't honored in the retry policy.","created_at":"2015-12-18T20:44:58Z","updated_at":"2015-12-18T20:44:58Z","html_url":"https://github.com/aws/aws-sdk-java/pull/581#discussion_r48067965","pull_request_url":"https://api.github.com/repos/aws/aws-sdk-java/pulls/581","_links":{"self":{"href":"https://api.github.com/repos/aws/aws-sdk-java/pulls/comments/48067965"},"html":{"href":"https://github.com/aws/aws-sdk-java/pull/581#discussion_r48067965"},"pull_request":{"href":"https://api.github.com/repos/aws/aws-sdk-java/pulls/581"}}},"pull_request":{"url":"https://api.github.com/repos/aws/aws-sdk-java/pulls/581","id":54147092,"html_url":"https://github.com/aws/aws-sdk-java/pull/581","diff_url":"https://github.com/aws/aws-sdk-java/pull/581.diff","patch_url":"https://github.com/aws/aws-sdk-java/pull/581.patch","issue_url":"https://api.github.com/repos/aws/aws-sdk-java/issues/581","number":581,"state":"open","locked":false,"title":"Add an option to disable chunked encoding.","user":{"login":"harshavardhana","id":622699,"avatar_url":"https://avatars.githubusercontent.com/u/622699?v=3","gravatar_id":"","url":"https://api.github.com/users/harshavardhana","html_url":"https://github.com/harshavardhana","followers_url":"https://api.github.com/users/harshavardhana/followers","following_url":"https://api.github.com/users/harshavardhana/following{/other_user}","gists_url":"https://api.github.com/users/harshavardhana/gists{/gist_id}","starred_url":"https://api.github.com/users/harshavardhana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshavardhana/subscriptions","organizations_url":"https://api.github.com/users/harshavardhana/orgs","repos_url":"https://api.github.com/users/harshavardhana/repos","events_url":"https://api.github.com/users/harshavardhana/events{/privacy}","received_events_url":"https://api.github.com/users/harshavardhana/received_events","type":"User","site_admin":false},"body":"This is done to allow sha256 calculation of proper\r\npayload in PutObjectRequest and UploadPartRequest.\r\n\r\nFixes #580","created_at":"2015-12-18T20:35:29Z","updated_at":"2015-12-18T20:44:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a9ce06f4dfe22ce41adde0ed6d3c834ba094c3ff","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aws/aws-sdk-java/pulls/581/commits","review_comments_url":"https://api.github.com/repos/aws/aws-sdk-java/pulls/581/comments","review_comment_url":"https://api.github.com/repos/aws/aws-sdk-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aws/aws-sdk-java/issues/581/comments","statuses_url":"https://api.github.com/repos/aws/aws-sdk-java/statuses/3e14d5dda6b4538ae8878111383078211656f17d","head":{"label":"harshavardhana:chunked-encoding","ref":"chunked-encoding","sha":"3e14d5dda6b4538ae8878111383078211656f17d","user":{"login":"harshavardhana","id":622699,"avatar_url":"https://avatars.githubusercontent.com/u/622699?v=3","gravatar_id":"","url":"https://api.github.com/users/harshavardhana","html_url":"https://github.com/harshavardhana","followers_url":"https://api.github.com/users/harshavardhana/followers","following_url":"https://api.github.com/users/harshavardhana/following{/other_user}","gists_url":"https://api.github.com/users/harshavardhana/gists{/gist_id}","starred_url":"https://api.github.com/users/harshavardhana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshavardhana/subscriptions","organizations_url":"https://api.github.com/users/harshavardhana/orgs","repos_url":"https://api.github.com/users/harshavardhana/repos","events_url":"https://api.github.com/users/harshavardhana/events{/privacy}","received_events_url":"https://api.github.com/users/harshavardhana/received_events","type":"User","site_admin":false},"repo":{"id":48252839,"name":"aws-sdk-java","full_name":"harshavardhana/aws-sdk-java","owner":{"login":"harshavardhana","id":622699,"avatar_url":"https://avatars.githubusercontent.com/u/622699?v=3","gravatar_id":"","url":"https://api.github.com/users/harshavardhana","html_url":"https://github.com/harshavardhana","followers_url":"https://api.github.com/users/harshavardhana/followers","following_url":"https://api.github.com/users/harshavardhana/following{/other_user}","gists_url":"https://api.github.com/users/harshavardhana/gists{/gist_id}","starred_url":"https://api.github.com/users/harshavardhana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshavardhana/subscriptions","organizations_url":"https://api.github.com/users/harshavardhana/orgs","repos_url":"https://api.github.com/users/harshavardhana/repos","events_url":"https://api.github.com/users/harshavardhana/events{/privacy}","received_events_url":"https://api.github.com/users/harshavardhana/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/harshavardhana/aws-sdk-java","description":"Official mirror of the AWS SDK for Java. For more information on the AWS SDK for Java, see our web site:","fork":true,"url":"https://api.github.com/repos/harshavardhana/aws-sdk-java","forks_url":"https://api.github.com/repos/harshavardhana/aws-sdk-java/forks","keys_url":"https://api.github.com/repos/harshavardhana/aws-sdk-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harshavardhana/aws-sdk-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harshavardhana/aws-sdk-java/teams","hooks_url":"https://api.github.com/repos/harshavardhana/aws-sdk-java/hooks","issue_events_url":"https://api.github.com/repos/harshavardhana/aws-sdk-java/issues/events{/number}","events_url":"https://api.github.com/repos/harshavardhana/aws-sdk-java/events","assignees_url":"https://api.github.com/repos/harshavardhana/aws-sdk-java/assignees{/user}","branches_url":"https://api.github.com/repos/harshavardhana/aws-sdk-java/branches{/branch}","tags_url":"https://api.github.com/repos/harshavardhana/aws-sdk-java/tags","blobs_url":"https://api.github.com/repos/harshavardhana/aws-sdk-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harshavardhana/aws-sdk-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harshavardhana/aws-sdk-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/harshavardhana/aws-sdk-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harshavardhana/aws-sdk-java/statuses/{sha}","languages_url":"https://api.github.com/repos/harshavardhana/aws-sdk-java/languages","stargazers_url":"https://api.github.com/repos/harshavardhana/aws-sdk-java/stargazers","contributors_url":"https://api.github.com/repos/harshavardhana/aws-sdk-java/contributors","subscribers_url":"https://api.github.com/repos/harshavardhana/aws-sdk-java/subscribers","subscription_url":"https://api.github.com/repos/harshavardhana/aws-sdk-java/subscription","commits_url":"https://api.github.com/repos/harshavardhana/aws-sdk-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/harshavardhana/aws-sdk-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/harshavardhana/aws-sdk-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/harshavardhana/aws-sdk-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/harshavardhana/aws-sdk-java/contents/{+path}","compare_url":"https://api.github.com/repos/harshavardhana/aws-sdk-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harshavardhana/aws-sdk-java/merges","archive_url":"https://api.github.com/repos/harshavardhana/aws-sdk-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harshavardhana/aws-sdk-java/downloads","issues_url":"https://api.github.com/repos/harshavardhana/aws-sdk-java/issues{/number}","pulls_url":"https://api.github.com/repos/harshavardhana/aws-sdk-java/pulls{/number}","milestones_url":"https://api.github.com/repos/harshavardhana/aws-sdk-java/milestones{/number}","notifications_url":"https://api.github.com/repos/harshavardhana/aws-sdk-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harshavardhana/aws-sdk-java/labels{/name}","releases_url":"https://api.github.com/repos/harshavardhana/aws-sdk-java/releases{/id}","created_at":"2015-12-18T19:33:11Z","updated_at":"2015-12-18T19:33:51Z","pushed_at":"2015-12-18T20:35:13Z","git_url":"git://github.com/harshavardhana/aws-sdk-java.git","ssh_url":"git@github.com:harshavardhana/aws-sdk-java.git","clone_url":"https://github.com/harshavardhana/aws-sdk-java.git","svn_url":"https://github.com/harshavardhana/aws-sdk-java","homepage":"http://aws.amazon.com/sdkforjava","size":105762,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aws:master","ref":"master","sha":"b33283258a7903ff28eab1ede9a4eb7f89db05d8","user":{"login":"aws","id":2232217,"avatar_url":"https://avatars.githubusercontent.com/u/2232217?v=3","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"repo":{"id":574877,"name":"aws-sdk-java","full_name":"aws/aws-sdk-java","owner":{"login":"aws","id":2232217,"avatar_url":"https://avatars.githubusercontent.com/u/2232217?v=3","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aws/aws-sdk-java","description":"Official mirror of the AWS SDK for Java. For more information on the AWS SDK for Java, see our web site:","fork":false,"url":"https://api.github.com/repos/aws/aws-sdk-java","forks_url":"https://api.github.com/repos/aws/aws-sdk-java/forks","keys_url":"https://api.github.com/repos/aws/aws-sdk-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws/aws-sdk-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws/aws-sdk-java/teams","hooks_url":"https://api.github.com/repos/aws/aws-sdk-java/hooks","issue_events_url":"https://api.github.com/repos/aws/aws-sdk-java/issues/events{/number}","events_url":"https://api.github.com/repos/aws/aws-sdk-java/events","assignees_url":"https://api.github.com/repos/aws/aws-sdk-java/assignees{/user}","branches_url":"https://api.github.com/repos/aws/aws-sdk-java/branches{/branch}","tags_url":"https://api.github.com/repos/aws/aws-sdk-java/tags","blobs_url":"https://api.github.com/repos/aws/aws-sdk-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws/aws-sdk-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws/aws-sdk-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws/aws-sdk-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws/aws-sdk-java/statuses/{sha}","languages_url":"https://api.github.com/repos/aws/aws-sdk-java/languages","stargazers_url":"https://api.github.com/repos/aws/aws-sdk-java/stargazers","contributors_url":"https://api.github.com/repos/aws/aws-sdk-java/contributors","subscribers_url":"https://api.github.com/repos/aws/aws-sdk-java/subscribers","subscription_url":"https://api.github.com/repos/aws/aws-sdk-java/subscription","commits_url":"https://api.github.com/repos/aws/aws-sdk-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws/aws-sdk-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws/aws-sdk-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws/aws-sdk-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/aws/aws-sdk-java/contents/{+path}","compare_url":"https://api.github.com/repos/aws/aws-sdk-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws/aws-sdk-java/merges","archive_url":"https://api.github.com/repos/aws/aws-sdk-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws/aws-sdk-java/downloads","issues_url":"https://api.github.com/repos/aws/aws-sdk-java/issues{/number}","pulls_url":"https://api.github.com/repos/aws/aws-sdk-java/pulls{/number}","milestones_url":"https://api.github.com/repos/aws/aws-sdk-java/milestones{/number}","notifications_url":"https://api.github.com/repos/aws/aws-sdk-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws/aws-sdk-java/labels{/name}","releases_url":"https://api.github.com/repos/aws/aws-sdk-java/releases{/id}","created_at":"2010-03-22T23:34:58Z","updated_at":"2015-12-17T12:11:45Z","pushed_at":"2015-12-18T20:35:29Z","git_url":"git://github.com/aws/aws-sdk-java.git","ssh_url":"git@github.com:aws/aws-sdk-java.git","clone_url":"https://github.com/aws/aws-sdk-java.git","svn_url":"https://github.com/aws/aws-sdk-java","homepage":"http://aws.amazon.com/sdkforjava","size":107105,"stargazers_count":1227,"watchers_count":1227,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":814,"mirror_url":null,"open_issues_count":108,"forks":814,"open_issues":108,"watchers":1227,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aws/aws-sdk-java/pulls/581"},"html":{"href":"https://github.com/aws/aws-sdk-java/pull/581"},"issue":{"href":"https://api.github.com/repos/aws/aws-sdk-java/issues/581"},"comments":{"href":"https://api.github.com/repos/aws/aws-sdk-java/issues/581/comments"},"review_comments":{"href":"https://api.github.com/repos/aws/aws-sdk-java/pulls/581/comments"},"review_comment":{"href":"https://api.github.com/repos/aws/aws-sdk-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aws/aws-sdk-java/pulls/581/commits"},"statuses":{"href":"https://api.github.com/repos/aws/aws-sdk-java/statuses/3e14d5dda6b4538ae8878111383078211656f17d"}}}}