{"action":"created","comment":{"url":"https://api.github.com/repos/ember-cli/ember-cli/pulls/comments/46780021","id":46780021,"diff_hunk":"@@ -0,0 +1,25 @@\n+'use strict';\n+\n+var Promise   = require('../ext/promise');\n+var fs        = require('fs-extra');\n+var temp      = require('temp');\n+var mkdir     = Promise.denodeify(fs.mkdir);\n+var mkdirTemp = Promise.denodeify(temp.mkdir);\n+\n+function exists(dir) {\n+  return new Promise(function(resolve) {\n+    fs.exists(dir, resolve);\n+  });\n+}\n+\n+function mkTmpDirIn(dir) {\n+  return exists(dir).then(function(doesExist) {\n+    if (!doesExist) {\n+      mkdir(dir);","path":"lib/utilities/mk-tmp-dir-in.js","position":18,"original_position":18,"commit_id":"32443209921f9d9f431da4184eca3b4f68ce7928","original_commit_id":"32443209921f9d9f431da4184eca3b4f68ce7928","user":{"login":"akatov","id":1148449,"avatar_url":"https://avatars.githubusercontent.com/u/1148449?v=3","gravatar_id":"","url":"https://api.github.com/users/akatov","html_url":"https://github.com/akatov","followers_url":"https://api.github.com/users/akatov/followers","following_url":"https://api.github.com/users/akatov/following{/other_user}","gists_url":"https://api.github.com/users/akatov/gists{/gist_id}","starred_url":"https://api.github.com/users/akatov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akatov/subscriptions","organizations_url":"https://api.github.com/users/akatov/orgs","repos_url":"https://api.github.com/users/akatov/repos","events_url":"https://api.github.com/users/akatov/events{/privacy}","received_events_url":"https://api.github.com/users/akatov/received_events","type":"User","site_admin":false},"body":"hmm, we aren't using the return value of the promise, nor does the promise actually return a value..\r\nhowever, if mkdir rejects we want the containing promise to reject also. So I'll update this.","created_at":"2015-12-07T01:04:22Z","updated_at":"2015-12-07T01:04:22Z","html_url":"https://github.com/ember-cli/ember-cli/pull/5190#discussion_r46780021","pull_request_url":"https://api.github.com/repos/ember-cli/ember-cli/pulls/5190","_links":{"self":{"href":"https://api.github.com/repos/ember-cli/ember-cli/pulls/comments/46780021"},"html":{"href":"https://github.com/ember-cli/ember-cli/pull/5190#discussion_r46780021"},"pull_request":{"href":"https://api.github.com/repos/ember-cli/ember-cli/pulls/5190"}}},"pull_request":{"url":"https://api.github.com/repos/ember-cli/ember-cli/pulls/5190","id":52795418,"html_url":"https://github.com/ember-cli/ember-cli/pull/5190","diff_url":"https://github.com/ember-cli/ember-cli/pull/5190.diff","patch_url":"https://github.com/ember-cli/ember-cli/pull/5190.patch","issue_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/5190","number":5190,"state":"open","locked":false,"title":"Only use `temp` dependency, not `tmp-sync`","user":{"login":"akatov","id":1148449,"avatar_url":"https://avatars.githubusercontent.com/u/1148449?v=3","gravatar_id":"","url":"https://api.github.com/users/akatov","html_url":"https://github.com/akatov","followers_url":"https://api.github.com/users/akatov/followers","following_url":"https://api.github.com/users/akatov/following{/other_user}","gists_url":"https://api.github.com/users/akatov/gists{/gist_id}","starred_url":"https://api.github.com/users/akatov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akatov/subscriptions","organizations_url":"https://api.github.com/users/akatov/orgs","repos_url":"https://api.github.com/users/akatov/repos","events_url":"https://api.github.com/users/akatov/events{/privacy}","received_events_url":"https://api.github.com/users/akatov/received_events","type":"User","site_admin":false},"body":"Don't use `tmp-sync` dependency which eventually depends on a deprecated `lodash` version.\r\nInstead, use promise-wrapped functions from `temp`","created_at":"2015-12-07T00:15:40Z","updated_at":"2015-12-07T01:04:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"919e8c5c2e17070b49417692a48c8fe83317e1dc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ember-cli/ember-cli/pulls/5190/commits","review_comments_url":"https://api.github.com/repos/ember-cli/ember-cli/pulls/5190/comments","review_comment_url":"https://api.github.com/repos/ember-cli/ember-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/5190/comments","statuses_url":"https://api.github.com/repos/ember-cli/ember-cli/statuses/32443209921f9d9f431da4184eca3b4f68ce7928","head":{"label":"akatov:only-temp","ref":"only-temp","sha":"32443209921f9d9f431da4184eca3b4f68ce7928","user":{"login":"akatov","id":1148449,"avatar_url":"https://avatars.githubusercontent.com/u/1148449?v=3","gravatar_id":"","url":"https://api.github.com/users/akatov","html_url":"https://github.com/akatov","followers_url":"https://api.github.com/users/akatov/followers","following_url":"https://api.github.com/users/akatov/following{/other_user}","gists_url":"https://api.github.com/users/akatov/gists{/gist_id}","starred_url":"https://api.github.com/users/akatov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akatov/subscriptions","organizations_url":"https://api.github.com/users/akatov/orgs","repos_url":"https://api.github.com/users/akatov/repos","events_url":"https://api.github.com/users/akatov/events{/privacy}","received_events_url":"https://api.github.com/users/akatov/received_events","type":"User","site_admin":false},"repo":{"id":47484325,"name":"ember-cli","full_name":"akatov/ember-cli","owner":{"login":"akatov","id":1148449,"avatar_url":"https://avatars.githubusercontent.com/u/1148449?v=3","gravatar_id":"","url":"https://api.github.com/users/akatov","html_url":"https://github.com/akatov","followers_url":"https://api.github.com/users/akatov/followers","following_url":"https://api.github.com/users/akatov/following{/other_user}","gists_url":"https://api.github.com/users/akatov/gists{/gist_id}","starred_url":"https://api.github.com/users/akatov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akatov/subscriptions","organizations_url":"https://api.github.com/users/akatov/orgs","repos_url":"https://api.github.com/users/akatov/repos","events_url":"https://api.github.com/users/akatov/events{/privacy}","received_events_url":"https://api.github.com/users/akatov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akatov/ember-cli","description":"","fork":true,"url":"https://api.github.com/repos/akatov/ember-cli","forks_url":"https://api.github.com/repos/akatov/ember-cli/forks","keys_url":"https://api.github.com/repos/akatov/ember-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akatov/ember-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akatov/ember-cli/teams","hooks_url":"https://api.github.com/repos/akatov/ember-cli/hooks","issue_events_url":"https://api.github.com/repos/akatov/ember-cli/issues/events{/number}","events_url":"https://api.github.com/repos/akatov/ember-cli/events","assignees_url":"https://api.github.com/repos/akatov/ember-cli/assignees{/user}","branches_url":"https://api.github.com/repos/akatov/ember-cli/branches{/branch}","tags_url":"https://api.github.com/repos/akatov/ember-cli/tags","blobs_url":"https://api.github.com/repos/akatov/ember-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akatov/ember-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akatov/ember-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/akatov/ember-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akatov/ember-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/akatov/ember-cli/languages","stargazers_url":"https://api.github.com/repos/akatov/ember-cli/stargazers","contributors_url":"https://api.github.com/repos/akatov/ember-cli/contributors","subscribers_url":"https://api.github.com/repos/akatov/ember-cli/subscribers","subscription_url":"https://api.github.com/repos/akatov/ember-cli/subscription","commits_url":"https://api.github.com/repos/akatov/ember-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/akatov/ember-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/akatov/ember-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/akatov/ember-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/akatov/ember-cli/contents/{+path}","compare_url":"https://api.github.com/repos/akatov/ember-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akatov/ember-cli/merges","archive_url":"https://api.github.com/repos/akatov/ember-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akatov/ember-cli/downloads","issues_url":"https://api.github.com/repos/akatov/ember-cli/issues{/number}","pulls_url":"https://api.github.com/repos/akatov/ember-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/akatov/ember-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/akatov/ember-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akatov/ember-cli/labels{/name}","releases_url":"https://api.github.com/repos/akatov/ember-cli/releases{/id}","created_at":"2015-12-06T05:02:26Z","updated_at":"2015-12-06T05:02:28Z","pushed_at":"2015-12-07T00:12:24Z","git_url":"git://github.com/akatov/ember-cli.git","ssh_url":"git@github.com:akatov/ember-cli.git","clone_url":"https://github.com/akatov/ember-cli.git","svn_url":"https://github.com/akatov/ember-cli","homepage":"http://ember-cli.com/","size":6546,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ember-cli:master","ref":"master","sha":"94321574e471ad8fadb917f80530941d047f2676","user":{"login":"ember-cli","id":10262982,"avatar_url":"https://avatars.githubusercontent.com/u/10262982?v=3","gravatar_id":"","url":"https://api.github.com/users/ember-cli","html_url":"https://github.com/ember-cli","followers_url":"https://api.github.com/users/ember-cli/followers","following_url":"https://api.github.com/users/ember-cli/following{/other_user}","gists_url":"https://api.github.com/users/ember-cli/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-cli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-cli/subscriptions","organizations_url":"https://api.github.com/users/ember-cli/orgs","repos_url":"https://api.github.com/users/ember-cli/repos","events_url":"https://api.github.com/users/ember-cli/events{/privacy}","received_events_url":"https://api.github.com/users/ember-cli/received_events","type":"Organization","site_admin":false},"repo":{"id":14089735,"name":"ember-cli","full_name":"ember-cli/ember-cli","owner":{"login":"ember-cli","id":10262982,"avatar_url":"https://avatars.githubusercontent.com/u/10262982?v=3","gravatar_id":"","url":"https://api.github.com/users/ember-cli","html_url":"https://github.com/ember-cli","followers_url":"https://api.github.com/users/ember-cli/followers","following_url":"https://api.github.com/users/ember-cli/following{/other_user}","gists_url":"https://api.github.com/users/ember-cli/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-cli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-cli/subscriptions","organizations_url":"https://api.github.com/users/ember-cli/orgs","repos_url":"https://api.github.com/users/ember-cli/repos","events_url":"https://api.github.com/users/ember-cli/events{/privacy}","received_events_url":"https://api.github.com/users/ember-cli/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ember-cli/ember-cli","description":"","fork":false,"url":"https://api.github.com/repos/ember-cli/ember-cli","forks_url":"https://api.github.com/repos/ember-cli/ember-cli/forks","keys_url":"https://api.github.com/repos/ember-cli/ember-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ember-cli/ember-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ember-cli/ember-cli/teams","hooks_url":"https://api.github.com/repos/ember-cli/ember-cli/hooks","issue_events_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/events{/number}","events_url":"https://api.github.com/repos/ember-cli/ember-cli/events","assignees_url":"https://api.github.com/repos/ember-cli/ember-cli/assignees{/user}","branches_url":"https://api.github.com/repos/ember-cli/ember-cli/branches{/branch}","tags_url":"https://api.github.com/repos/ember-cli/ember-cli/tags","blobs_url":"https://api.github.com/repos/ember-cli/ember-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ember-cli/ember-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ember-cli/ember-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/ember-cli/ember-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ember-cli/ember-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/ember-cli/ember-cli/languages","stargazers_url":"https://api.github.com/repos/ember-cli/ember-cli/stargazers","contributors_url":"https://api.github.com/repos/ember-cli/ember-cli/contributors","subscribers_url":"https://api.github.com/repos/ember-cli/ember-cli/subscribers","subscription_url":"https://api.github.com/repos/ember-cli/ember-cli/subscription","commits_url":"https://api.github.com/repos/ember-cli/ember-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/ember-cli/ember-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/ember-cli/ember-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/ember-cli/ember-cli/contents/{+path}","compare_url":"https://api.github.com/repos/ember-cli/ember-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ember-cli/ember-cli/merges","archive_url":"https://api.github.com/repos/ember-cli/ember-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ember-cli/ember-cli/downloads","issues_url":"https://api.github.com/repos/ember-cli/ember-cli/issues{/number}","pulls_url":"https://api.github.com/repos/ember-cli/ember-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/ember-cli/ember-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/ember-cli/ember-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ember-cli/ember-cli/labels{/name}","releases_url":"https://api.github.com/repos/ember-cli/ember-cli/releases{/id}","created_at":"2013-11-03T17:34:43Z","updated_at":"2015-12-06T14:41:51Z","pushed_at":"2015-12-07T00:15:40Z","git_url":"git://github.com/ember-cli/ember-cli.git","ssh_url":"git@github.com:ember-cli/ember-cli.git","clone_url":"https://github.com/ember-cli/ember-cli.git","svn_url":"https://github.com/ember-cli/ember-cli","homepage":"http://ember-cli.com/","size":16619,"stargazers_count":2699,"watchers_count":2699,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":766,"mirror_url":null,"open_issues_count":262,"forks":766,"open_issues":262,"watchers":2699,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ember-cli/ember-cli/pulls/5190"},"html":{"href":"https://github.com/ember-cli/ember-cli/pull/5190"},"issue":{"href":"https://api.github.com/repos/ember-cli/ember-cli/issues/5190"},"comments":{"href":"https://api.github.com/repos/ember-cli/ember-cli/issues/5190/comments"},"review_comments":{"href":"https://api.github.com/repos/ember-cli/ember-cli/pulls/5190/comments"},"review_comment":{"href":"https://api.github.com/repos/ember-cli/ember-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ember-cli/ember-cli/pulls/5190/commits"},"statuses":{"href":"https://api.github.com/repos/ember-cli/ember-cli/statuses/32443209921f9d9f431da4184eca3b4f68ce7928"}}}}