{"action":"created","issue":{"url":"https://api.github.com/repos/dankelley/oce/issues/783","labels_url":"https://api.github.com/repos/dankelley/oce/issues/783/labels{/name}","comments_url":"https://api.github.com/repos/dankelley/oce/issues/783/comments","events_url":"https://api.github.com/repos/dankelley/oce/issues/783/events","html_url":"https://github.com/dankelley/oce/issues/783","id":117842674,"number":783,"title":"read.adp.rdi() no longer reads bottom track or nav for Workhorse VMDAS files","user":{"login":"richardsc","id":233584,"avatar_url":"https://avatars.githubusercontent.com/u/233584?v=3","gravatar_id":"","url":"https://api.github.com/users/richardsc","html_url":"https://github.com/richardsc","followers_url":"https://api.github.com/users/richardsc/followers","following_url":"https://api.github.com/users/richardsc/following{/other_user}","gists_url":"https://api.github.com/users/richardsc/gists{/gist_id}","starred_url":"https://api.github.com/users/richardsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardsc/subscriptions","organizations_url":"https://api.github.com/users/richardsc/orgs","repos_url":"https://api.github.com/users/richardsc/repos","events_url":"https://api.github.com/users/richardsc/events{/privacy}","received_events_url":"https://api.github.com/users/richardsc/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dankelley/oce/labels/adp","name":"adp","color":"eb6420"}],"state":"open","locked":false,"assignee":{"login":"dankelley","id":99469,"avatar_url":"https://avatars.githubusercontent.com/u/99469?v=3","gravatar_id":"","url":"https://api.github.com/users/dankelley","html_url":"https://github.com/dankelley","followers_url":"https://api.github.com/users/dankelley/followers","following_url":"https://api.github.com/users/dankelley/following{/other_user}","gists_url":"https://api.github.com/users/dankelley/gists{/gist_id}","starred_url":"https://api.github.com/users/dankelley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankelley/subscriptions","organizations_url":"https://api.github.com/users/dankelley/orgs","repos_url":"https://api.github.com/users/dankelley/repos","events_url":"https://api.github.com/users/dankelley/events{/privacy}","received_events_url":"https://api.github.com/users/dankelley/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2015-11-19T15:50:12Z","updated_at":"2015-11-19T18:20:07Z","closed_at":null,"body":"This seems to be a consequence of the firmware check fix for Issue #777, but because OceanSurveyors and Workhorse instruments have firmware numbers in a different range (e.g. 23.XX for OS and 51.XX for Workhorse), `read.adp.rdi()` is confusing the two. An example (see [oce-issues](https://github.com/dankelley/oce-issues/tree/master/783):\r\n```r\r\nlibrary(oce)\r\nd <- read.adp.rdi(file)\r\nexpect_true('br' %in% names(d@data), info=\"This file should have bottom range, br\")\r\n```\r\n```r\r\nError: \"br\" %in% names(d@data) isn't true\r\nThis file should have bottom range, br\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/dankelley/oce/issues/comments/158145367","html_url":"https://github.com/dankelley/oce/issues/783#issuecomment-158145367","issue_url":"https://api.github.com/repos/dankelley/oce/issues/783","id":158145367,"user":{"login":"dankelley","id":99469,"avatar_url":"https://avatars.githubusercontent.com/u/99469?v=3","gravatar_id":"","url":"https://api.github.com/users/dankelley","html_url":"https://github.com/dankelley","followers_url":"https://api.github.com/users/dankelley/followers","following_url":"https://api.github.com/users/dankelley/following{/other_user}","gists_url":"https://api.github.com/users/dankelley/gists{/gist_id}","starred_url":"https://api.github.com/users/dankelley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankelley/subscriptions","organizations_url":"https://api.github.com/users/dankelley/orgs","repos_url":"https://api.github.com/users/dankelley/repos","events_url":"https://api.github.com/users/dankelley/events{/privacy}","received_events_url":"https://api.github.com/users/dankelley/received_events","type":"User","site_admin":false},"created_at":"2015-11-19T18:20:07Z","updated_at":"2015-11-19T18:20:07Z","body":"Question for @richardsc -- do you think the only way to know the instrument type is through the serial numbers?\r\n\r\nAt the moment I do that from the lengths of some header chunks, but I know from the most recent file that this fails. I'm not sure that we would ever *need* to know the instrument type, mind you, but it seems odd that a datafile cannot reveal that. I had a quick look at Rich's code, and he seems to do what oce does, guessing instrument type from some header lengths ... really, this is odd."}}