{"action":"created","issue":{"url":"https://api.github.com/repos/statsmodels/statsmodels/issues/2430","labels_url":"https://api.github.com/repos/statsmodels/statsmodels/issues/2430/labels{/name}","comments_url":"https://api.github.com/repos/statsmodels/statsmodels/issues/2430/comments","events_url":"https://api.github.com/repos/statsmodels/statsmodels/issues/2430/events","html_url":"https://github.com/statsmodels/statsmodels/issues/2430","id":83717626,"number":2430,"title":"Doc/Bug: plot_acf only allows integer lags argument.","user":{"login":"ChadFulton","id":280864,"avatar_url":"https://avatars.githubusercontent.com/u/280864?v=3","gravatar_id":"","url":"https://api.github.com/users/ChadFulton","html_url":"https://github.com/ChadFulton","followers_url":"https://api.github.com/users/ChadFulton/followers","following_url":"https://api.github.com/users/ChadFulton/following{/other_user}","gists_url":"https://api.github.com/users/ChadFulton/gists{/gist_id}","starred_url":"https://api.github.com/users/ChadFulton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChadFulton/subscriptions","organizations_url":"https://api.github.com/users/ChadFulton/orgs","repos_url":"https://api.github.com/users/ChadFulton/repos","events_url":"https://api.github.com/users/ChadFulton/events{/privacy}","received_events_url":"https://api.github.com/users/ChadFulton/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-06-01T22:11:18Z","updated_at":"2015-06-01T22:54:05Z","closed_at":null,"body":"The signature of `plot_acf` is:\r\n\r\n```python\r\ndef plot_acf(x, ax=None, lags=None, alpha=.05, use_vlines=True, unbiased=False,\r\n            fft=False, **kwargs):\r\n```\r\n\r\nwhere the documentation suggests:\r\n\r\n```python\r\n\"\"\"\r\nlags : array_like, optional\r\n        Array of lag values, used on horizontal axis.\r\n        If not given, ``lags=np.arange(len(corr))`` is used.\r\n\"\"\"\r\n```\r\n\r\nBut in fact only integer arguments are allowed. I guess either the docs should be changed to specify integer arguments or the code should be changed to allow an array. I can submit a PR for either option.\r\n\r\nMy preference is for the latter option since it doesn't require too much of a change and might be useful (the particular use case I'm thinking of is that you may not want the zeroth lag plotted, since it's always 1)."},"comment":{"url":"https://api.github.com/repos/statsmodels/statsmodels/issues/comments/107740544","html_url":"https://github.com/statsmodels/statsmodels/issues/2430#issuecomment-107740544","issue_url":"https://api.github.com/repos/statsmodels/statsmodels/issues/2430","id":107740544,"user":{"login":"ChadFulton","id":280864,"avatar_url":"https://avatars.githubusercontent.com/u/280864?v=3","gravatar_id":"","url":"https://api.github.com/users/ChadFulton","html_url":"https://github.com/ChadFulton","followers_url":"https://api.github.com/users/ChadFulton/followers","following_url":"https://api.github.com/users/ChadFulton/following{/other_user}","gists_url":"https://api.github.com/users/ChadFulton/gists{/gist_id}","starred_url":"https://api.github.com/users/ChadFulton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChadFulton/subscriptions","organizations_url":"https://api.github.com/users/ChadFulton/orgs","repos_url":"https://api.github.com/users/ChadFulton/repos","events_url":"https://api.github.com/users/ChadFulton/events{/privacy}","received_events_url":"https://api.github.com/users/ChadFulton/received_events","type":"User","site_admin":false},"created_at":"2015-06-01T22:54:05Z","updated_at":"2015-06-01T22:54:05Z","body":"I guess this would be in symmetry to `acorr_ljungbox`, which has the following to say about lags:\r\n\r\n```python\r\n\"\"\"\r\nlags : None, int or array_like\r\n    If lags is an integer then this is taken to be the largest lag\r\n    that is included, the test result is reported for all smaller lag length.\r\n    If lags is a list or array, then all lags are included up to the largest\r\n    lag in the list, however only the tests for the lags in the list are\r\n    reported.\r\n\"\"\"\r\n```\r\n\r\nThe only thing I have considered doing with it is excluding the zeroth lag. I suppose you might want to \"zoom in\" on some section, but that may not be done frequently enough to have code to do that."}}