{"action":"closed","number":4,"pull_request":{"url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/pulls/4","id":31346263,"html_url":"https://github.com/markmarijnissen/cordova-promise-fs/pull/4","diff_url":"https://github.com/markmarijnissen/cordova-promise-fs/pull/4.diff","patch_url":"https://github.com/markmarijnissen/cordova-promise-fs/pull/4.patch","issue_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/issues/4","number":4,"state":"closed","locked":false,"title":"Assume URLs are well-formed instead of trying to encode them for the user","user":{"login":"Ezku","id":412022,"avatar_url":"https://avatars.githubusercontent.com/u/412022?v=3","gravatar_id":"","url":"https://api.github.com/users/Ezku","html_url":"https://github.com/Ezku","followers_url":"https://api.github.com/users/Ezku/followers","following_url":"https://api.github.com/users/Ezku/following{/other_user}","gists_url":"https://api.github.com/users/Ezku/gists{/gist_id}","starred_url":"https://api.github.com/users/Ezku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ezku/subscriptions","organizations_url":"https://api.github.com/users/Ezku/orgs","repos_url":"https://api.github.com/users/Ezku/repos","events_url":"https://api.github.com/users/Ezku/events{/privacy}","received_events_url":"https://api.github.com/users/Ezku/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nI had a use case where a URL contained encoded parameters in its query string. Trying to upload to an endpoint with `fs.upload` would corrupt the parameters by re-encoding them, although the URL was already perfectly fine.\r\n\r\nThis pull request removes the call to `encodeURI`, assuming users will be able to take care of the proper encoding of their URLs themselves.\r\n\r\nCheers,\r\nEevert","created_at":"2015-03-17T15:33:09Z","updated_at":"2015-03-17T15:56:09Z","closed_at":"2015-03-17T15:56:09Z","merged_at":"2015-03-17T15:56:09Z","merge_commit_sha":"8011bf214423c4147d0a98397abed9f41e08e21e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/pulls/4/commits","review_comments_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/pulls/4/comments","review_comment_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/issues/4/comments","statuses_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/statuses/bf0a89a3b9ee27c48fb6df72d772c529a3d0f449","head":{"label":"AppGyver:master","ref":"master","sha":"bf0a89a3b9ee27c48fb6df72d772c529a3d0f449","user":{"login":"AppGyver","id":555875,"avatar_url":"https://avatars.githubusercontent.com/u/555875?v=3","gravatar_id":"","url":"https://api.github.com/users/AppGyver","html_url":"https://github.com/AppGyver","followers_url":"https://api.github.com/users/AppGyver/followers","following_url":"https://api.github.com/users/AppGyver/following{/other_user}","gists_url":"https://api.github.com/users/AppGyver/gists{/gist_id}","starred_url":"https://api.github.com/users/AppGyver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppGyver/subscriptions","organizations_url":"https://api.github.com/users/AppGyver/orgs","repos_url":"https://api.github.com/users/AppGyver/repos","events_url":"https://api.github.com/users/AppGyver/events{/privacy}","received_events_url":"https://api.github.com/users/AppGyver/received_events","type":"Organization","site_admin":false},"repo":{"id":32386359,"name":"cordova-promise-fs","full_name":"AppGyver/cordova-promise-fs","owner":{"login":"AppGyver","id":555875,"avatar_url":"https://avatars.githubusercontent.com/u/555875?v=3","gravatar_id":"","url":"https://api.github.com/users/AppGyver","html_url":"https://github.com/AppGyver","followers_url":"https://api.github.com/users/AppGyver/followers","following_url":"https://api.github.com/users/AppGyver/following{/other_user}","gists_url":"https://api.github.com/users/AppGyver/gists{/gist_id}","starred_url":"https://api.github.com/users/AppGyver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppGyver/subscriptions","organizations_url":"https://api.github.com/users/AppGyver/orgs","repos_url":"https://api.github.com/users/AppGyver/repos","events_url":"https://api.github.com/users/AppGyver/events{/privacy}","received_events_url":"https://api.github.com/users/AppGyver/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AppGyver/cordova-promise-fs","description":"Wraps the Cordova File API in convenient functions (that return a Promise)","fork":true,"url":"https://api.github.com/repos/AppGyver/cordova-promise-fs","forks_url":"https://api.github.com/repos/AppGyver/cordova-promise-fs/forks","keys_url":"https://api.github.com/repos/AppGyver/cordova-promise-fs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AppGyver/cordova-promise-fs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AppGyver/cordova-promise-fs/teams","hooks_url":"https://api.github.com/repos/AppGyver/cordova-promise-fs/hooks","issue_events_url":"https://api.github.com/repos/AppGyver/cordova-promise-fs/issues/events{/number}","events_url":"https://api.github.com/repos/AppGyver/cordova-promise-fs/events","assignees_url":"https://api.github.com/repos/AppGyver/cordova-promise-fs/assignees{/user}","branches_url":"https://api.github.com/repos/AppGyver/cordova-promise-fs/branches{/branch}","tags_url":"https://api.github.com/repos/AppGyver/cordova-promise-fs/tags","blobs_url":"https://api.github.com/repos/AppGyver/cordova-promise-fs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AppGyver/cordova-promise-fs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AppGyver/cordova-promise-fs/git/refs{/sha}","trees_url":"https://api.github.com/repos/AppGyver/cordova-promise-fs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AppGyver/cordova-promise-fs/statuses/{sha}","languages_url":"https://api.github.com/repos/AppGyver/cordova-promise-fs/languages","stargazers_url":"https://api.github.com/repos/AppGyver/cordova-promise-fs/stargazers","contributors_url":"https://api.github.com/repos/AppGyver/cordova-promise-fs/contributors","subscribers_url":"https://api.github.com/repos/AppGyver/cordova-promise-fs/subscribers","subscription_url":"https://api.github.com/repos/AppGyver/cordova-promise-fs/subscription","commits_url":"https://api.github.com/repos/AppGyver/cordova-promise-fs/commits{/sha}","git_commits_url":"https://api.github.com/repos/AppGyver/cordova-promise-fs/git/commits{/sha}","comments_url":"https://api.github.com/repos/AppGyver/cordova-promise-fs/comments{/number}","issue_comment_url":"https://api.github.com/repos/AppGyver/cordova-promise-fs/issues/comments{/number}","contents_url":"https://api.github.com/repos/AppGyver/cordova-promise-fs/contents/{+path}","compare_url":"https://api.github.com/repos/AppGyver/cordova-promise-fs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AppGyver/cordova-promise-fs/merges","archive_url":"https://api.github.com/repos/AppGyver/cordova-promise-fs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AppGyver/cordova-promise-fs/downloads","issues_url":"https://api.github.com/repos/AppGyver/cordova-promise-fs/issues{/number}","pulls_url":"https://api.github.com/repos/AppGyver/cordova-promise-fs/pulls{/number}","milestones_url":"https://api.github.com/repos/AppGyver/cordova-promise-fs/milestones{/number}","notifications_url":"https://api.github.com/repos/AppGyver/cordova-promise-fs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AppGyver/cordova-promise-fs/labels{/name}","releases_url":"https://api.github.com/repos/AppGyver/cordova-promise-fs/releases{/id}","created_at":"2015-03-17T10:18:03Z","updated_at":"2015-03-17T10:22:46Z","pushed_at":"2015-03-17T10:22:46Z","git_url":"git://github.com/AppGyver/cordova-promise-fs.git","ssh_url":"git@github.com:AppGyver/cordova-promise-fs.git","clone_url":"https://github.com/AppGyver/cordova-promise-fs.git","svn_url":"https://github.com/AppGyver/cordova-promise-fs","homepage":"","size":388,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"markmarijnissen:master","ref":"master","sha":"9b287684f92077bb5d9c90bad0a3522f420da3ae","user":{"login":"markmarijnissen","id":1287693,"avatar_url":"https://avatars.githubusercontent.com/u/1287693?v=3","gravatar_id":"","url":"https://api.github.com/users/markmarijnissen","html_url":"https://github.com/markmarijnissen","followers_url":"https://api.github.com/users/markmarijnissen/followers","following_url":"https://api.github.com/users/markmarijnissen/following{/other_user}","gists_url":"https://api.github.com/users/markmarijnissen/gists{/gist_id}","starred_url":"https://api.github.com/users/markmarijnissen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markmarijnissen/subscriptions","organizations_url":"https://api.github.com/users/markmarijnissen/orgs","repos_url":"https://api.github.com/users/markmarijnissen/repos","events_url":"https://api.github.com/users/markmarijnissen/events{/privacy}","received_events_url":"https://api.github.com/users/markmarijnissen/received_events","type":"User","site_admin":false},"repo":{"id":26128885,"name":"cordova-promise-fs","full_name":"markmarijnissen/cordova-promise-fs","owner":{"login":"markmarijnissen","id":1287693,"avatar_url":"https://avatars.githubusercontent.com/u/1287693?v=3","gravatar_id":"","url":"https://api.github.com/users/markmarijnissen","html_url":"https://github.com/markmarijnissen","followers_url":"https://api.github.com/users/markmarijnissen/followers","following_url":"https://api.github.com/users/markmarijnissen/following{/other_user}","gists_url":"https://api.github.com/users/markmarijnissen/gists{/gist_id}","starred_url":"https://api.github.com/users/markmarijnissen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markmarijnissen/subscriptions","organizations_url":"https://api.github.com/users/markmarijnissen/orgs","repos_url":"https://api.github.com/users/markmarijnissen/repos","events_url":"https://api.github.com/users/markmarijnissen/events{/privacy}","received_events_url":"https://api.github.com/users/markmarijnissen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/markmarijnissen/cordova-promise-fs","description":"Wraps the Cordova File API in convenient functions (that return a Promise)","fork":false,"url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs","forks_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/forks","keys_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/teams","hooks_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/hooks","issue_events_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/issues/events{/number}","events_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/events","assignees_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/assignees{/user}","branches_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/branches{/branch}","tags_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/tags","blobs_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/git/refs{/sha}","trees_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/statuses/{sha}","languages_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/languages","stargazers_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/stargazers","contributors_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/contributors","subscribers_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/subscribers","subscription_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/subscription","commits_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/commits{/sha}","git_commits_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/git/commits{/sha}","comments_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/comments{/number}","issue_comment_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/issues/comments{/number}","contents_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/contents/{+path}","compare_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/merges","archive_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/downloads","issues_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/issues{/number}","pulls_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/pulls{/number}","milestones_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/milestones{/number}","notifications_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/labels{/name}","releases_url":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/releases{/id}","created_at":"2014-11-03T16:58:55Z","updated_at":"2015-03-16T08:13:19Z","pushed_at":"2015-03-17T15:56:09Z","git_url":"git://github.com/markmarijnissen/cordova-promise-fs.git","ssh_url":"git@github.com:markmarijnissen/cordova-promise-fs.git","clone_url":"https://github.com/markmarijnissen/cordova-promise-fs.git","svn_url":"https://github.com/markmarijnissen/cordova-promise-fs","homepage":"","size":388,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/pulls/4"},"html":{"href":"https://github.com/markmarijnissen/cordova-promise-fs/pull/4"},"issue":{"href":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/issues/4"},"comments":{"href":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/markmarijnissen/cordova-promise-fs/statuses/bf0a89a3b9ee27c48fb6df72d772c529a3d0f449"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"markmarijnissen","id":1287693,"avatar_url":"https://avatars.githubusercontent.com/u/1287693?v=3","gravatar_id":"","url":"https://api.github.com/users/markmarijnissen","html_url":"https://github.com/markmarijnissen","followers_url":"https://api.github.com/users/markmarijnissen/followers","following_url":"https://api.github.com/users/markmarijnissen/following{/other_user}","gists_url":"https://api.github.com/users/markmarijnissen/gists{/gist_id}","starred_url":"https://api.github.com/users/markmarijnissen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markmarijnissen/subscriptions","organizations_url":"https://api.github.com/users/markmarijnissen/orgs","repos_url":"https://api.github.com/users/markmarijnissen/repos","events_url":"https://api.github.com/users/markmarijnissen/events{/privacy}","received_events_url":"https://api.github.com/users/markmarijnissen/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":4,"changed_files":2}}