{"action":"closed","number":32,"pull_request":{"url":"https://api.github.com/repos/johnpolacek/stacktable.js/pulls/32","id":50062368,"html_url":"https://github.com/johnpolacek/stacktable.js/pull/32","diff_url":"https://github.com/johnpolacek/stacktable.js/pull/32.diff","patch_url":"https://github.com/johnpolacek/stacktable.js/pull/32.patch","issue_url":"https://api.github.com/repos/johnpolacek/stacktable.js/issues/32","number":32,"state":"closed","locked":false,"title":"declare variables and remove unused","user":{"login":"igncp","id":5245900,"avatar_url":"https://avatars.githubusercontent.com/u/5245900?v=3","gravatar_id":"","url":"https://api.github.com/users/igncp","html_url":"https://github.com/igncp","followers_url":"https://api.github.com/users/igncp/followers","following_url":"https://api.github.com/users/igncp/following{/other_user}","gists_url":"https://api.github.com/users/igncp/gists{/gist_id}","starred_url":"https://api.github.com/users/igncp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igncp/subscriptions","organizations_url":"https://api.github.com/users/igncp/orgs","repos_url":"https://api.github.com/users/igncp/repos","events_url":"https://api.github.com/users/igncp/events{/privacy}","received_events_url":"https://api.github.com/users/igncp/received_events","type":"User","site_admin":false},"body":"Hi there,\r\n\r\nA few variables were not declared, so they were attached to the global scope (i.e. `window`). You can try it with any of them in the project website, for example you can see from a browser's console `window.headIndex` or `window.$table` have a value. Also removed some variables that were not used, to spare a few bits. Hope it helps.\r\n\r\nCheers","created_at":"2015-11-08T15:20:24Z","updated_at":"2015-11-19T12:43:46Z","closed_at":"2015-11-19T12:43:46Z","merged_at":"2015-11-19T12:43:46Z","merge_commit_sha":"1007dec1f1429baeb82a613238430fe0d403dafe","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/johnpolacek/stacktable.js/pulls/32/commits","review_comments_url":"https://api.github.com/repos/johnpolacek/stacktable.js/pulls/32/comments","review_comment_url":"https://api.github.com/repos/johnpolacek/stacktable.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/johnpolacek/stacktable.js/issues/32/comments","statuses_url":"https://api.github.com/repos/johnpolacek/stacktable.js/statuses/f6a0777550a93392913c07ada2dd4a4704d838d3","head":{"label":"igncp:PR","ref":"PR","sha":"f6a0777550a93392913c07ada2dd4a4704d838d3","user":{"login":"igncp","id":5245900,"avatar_url":"https://avatars.githubusercontent.com/u/5245900?v=3","gravatar_id":"","url":"https://api.github.com/users/igncp","html_url":"https://github.com/igncp","followers_url":"https://api.github.com/users/igncp/followers","following_url":"https://api.github.com/users/igncp/following{/other_user}","gists_url":"https://api.github.com/users/igncp/gists{/gist_id}","starred_url":"https://api.github.com/users/igncp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igncp/subscriptions","organizations_url":"https://api.github.com/users/igncp/orgs","repos_url":"https://api.github.com/users/igncp/repos","events_url":"https://api.github.com/users/igncp/events{/privacy}","received_events_url":"https://api.github.com/users/igncp/received_events","type":"User","site_admin":false},"repo":{"id":45784991,"name":"stacktable.js","full_name":"igncp/stacktable.js","owner":{"login":"igncp","id":5245900,"avatar_url":"https://avatars.githubusercontent.com/u/5245900?v=3","gravatar_id":"","url":"https://api.github.com/users/igncp","html_url":"https://github.com/igncp","followers_url":"https://api.github.com/users/igncp/followers","following_url":"https://api.github.com/users/igncp/following{/other_user}","gists_url":"https://api.github.com/users/igncp/gists{/gist_id}","starred_url":"https://api.github.com/users/igncp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igncp/subscriptions","organizations_url":"https://api.github.com/users/igncp/orgs","repos_url":"https://api.github.com/users/igncp/repos","events_url":"https://api.github.com/users/igncp/events{/privacy}","received_events_url":"https://api.github.com/users/igncp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/igncp/stacktable.js","description":"jQuery plugin for stacking tables on small screens","fork":true,"url":"https://api.github.com/repos/igncp/stacktable.js","forks_url":"https://api.github.com/repos/igncp/stacktable.js/forks","keys_url":"https://api.github.com/repos/igncp/stacktable.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/igncp/stacktable.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/igncp/stacktable.js/teams","hooks_url":"https://api.github.com/repos/igncp/stacktable.js/hooks","issue_events_url":"https://api.github.com/repos/igncp/stacktable.js/issues/events{/number}","events_url":"https://api.github.com/repos/igncp/stacktable.js/events","assignees_url":"https://api.github.com/repos/igncp/stacktable.js/assignees{/user}","branches_url":"https://api.github.com/repos/igncp/stacktable.js/branches{/branch}","tags_url":"https://api.github.com/repos/igncp/stacktable.js/tags","blobs_url":"https://api.github.com/repos/igncp/stacktable.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/igncp/stacktable.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/igncp/stacktable.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/igncp/stacktable.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/igncp/stacktable.js/statuses/{sha}","languages_url":"https://api.github.com/repos/igncp/stacktable.js/languages","stargazers_url":"https://api.github.com/repos/igncp/stacktable.js/stargazers","contributors_url":"https://api.github.com/repos/igncp/stacktable.js/contributors","subscribers_url":"https://api.github.com/repos/igncp/stacktable.js/subscribers","subscription_url":"https://api.github.com/repos/igncp/stacktable.js/subscription","commits_url":"https://api.github.com/repos/igncp/stacktable.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/igncp/stacktable.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/igncp/stacktable.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/igncp/stacktable.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/igncp/stacktable.js/contents/{+path}","compare_url":"https://api.github.com/repos/igncp/stacktable.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/igncp/stacktable.js/merges","archive_url":"https://api.github.com/repos/igncp/stacktable.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/igncp/stacktable.js/downloads","issues_url":"https://api.github.com/repos/igncp/stacktable.js/issues{/number}","pulls_url":"https://api.github.com/repos/igncp/stacktable.js/pulls{/number}","milestones_url":"https://api.github.com/repos/igncp/stacktable.js/milestones{/number}","notifications_url":"https://api.github.com/repos/igncp/stacktable.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/igncp/stacktable.js/labels{/name}","releases_url":"https://api.github.com/repos/igncp/stacktable.js/releases{/id}","created_at":"2015-11-08T14:59:31Z","updated_at":"2015-11-08T14:59:35Z","pushed_at":"2015-11-08T15:14:49Z","git_url":"git://github.com/igncp/stacktable.js.git","ssh_url":"git@github.com:igncp/stacktable.js.git","clone_url":"https://github.com/igncp/stacktable.js.git","svn_url":"https://github.com/igncp/stacktable.js","homepage":"http://johnpolacek.github.com/stacktable.js/","size":185,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"johnpolacek:master","ref":"master","sha":"4ec35813ec79db8b2de784a866edcf1640a6bb33","user":{"login":"johnpolacek","id":179482,"avatar_url":"https://avatars.githubusercontent.com/u/179482?v=3","gravatar_id":"","url":"https://api.github.com/users/johnpolacek","html_url":"https://github.com/johnpolacek","followers_url":"https://api.github.com/users/johnpolacek/followers","following_url":"https://api.github.com/users/johnpolacek/following{/other_user}","gists_url":"https://api.github.com/users/johnpolacek/gists{/gist_id}","starred_url":"https://api.github.com/users/johnpolacek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnpolacek/subscriptions","organizations_url":"https://api.github.com/users/johnpolacek/orgs","repos_url":"https://api.github.com/users/johnpolacek/repos","events_url":"https://api.github.com/users/johnpolacek/events{/privacy}","received_events_url":"https://api.github.com/users/johnpolacek/received_events","type":"User","site_admin":false},"repo":{"id":7069755,"name":"stacktable.js","full_name":"johnpolacek/stacktable.js","owner":{"login":"johnpolacek","id":179482,"avatar_url":"https://avatars.githubusercontent.com/u/179482?v=3","gravatar_id":"","url":"https://api.github.com/users/johnpolacek","html_url":"https://github.com/johnpolacek","followers_url":"https://api.github.com/users/johnpolacek/followers","following_url":"https://api.github.com/users/johnpolacek/following{/other_user}","gists_url":"https://api.github.com/users/johnpolacek/gists{/gist_id}","starred_url":"https://api.github.com/users/johnpolacek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnpolacek/subscriptions","organizations_url":"https://api.github.com/users/johnpolacek/orgs","repos_url":"https://api.github.com/users/johnpolacek/repos","events_url":"https://api.github.com/users/johnpolacek/events{/privacy}","received_events_url":"https://api.github.com/users/johnpolacek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnpolacek/stacktable.js","description":"jQuery plugin for stacking tables on small screens","fork":false,"url":"https://api.github.com/repos/johnpolacek/stacktable.js","forks_url":"https://api.github.com/repos/johnpolacek/stacktable.js/forks","keys_url":"https://api.github.com/repos/johnpolacek/stacktable.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnpolacek/stacktable.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnpolacek/stacktable.js/teams","hooks_url":"https://api.github.com/repos/johnpolacek/stacktable.js/hooks","issue_events_url":"https://api.github.com/repos/johnpolacek/stacktable.js/issues/events{/number}","events_url":"https://api.github.com/repos/johnpolacek/stacktable.js/events","assignees_url":"https://api.github.com/repos/johnpolacek/stacktable.js/assignees{/user}","branches_url":"https://api.github.com/repos/johnpolacek/stacktable.js/branches{/branch}","tags_url":"https://api.github.com/repos/johnpolacek/stacktable.js/tags","blobs_url":"https://api.github.com/repos/johnpolacek/stacktable.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnpolacek/stacktable.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnpolacek/stacktable.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnpolacek/stacktable.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnpolacek/stacktable.js/statuses/{sha}","languages_url":"https://api.github.com/repos/johnpolacek/stacktable.js/languages","stargazers_url":"https://api.github.com/repos/johnpolacek/stacktable.js/stargazers","contributors_url":"https://api.github.com/repos/johnpolacek/stacktable.js/contributors","subscribers_url":"https://api.github.com/repos/johnpolacek/stacktable.js/subscribers","subscription_url":"https://api.github.com/repos/johnpolacek/stacktable.js/subscription","commits_url":"https://api.github.com/repos/johnpolacek/stacktable.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnpolacek/stacktable.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnpolacek/stacktable.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnpolacek/stacktable.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnpolacek/stacktable.js/contents/{+path}","compare_url":"https://api.github.com/repos/johnpolacek/stacktable.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnpolacek/stacktable.js/merges","archive_url":"https://api.github.com/repos/johnpolacek/stacktable.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnpolacek/stacktable.js/downloads","issues_url":"https://api.github.com/repos/johnpolacek/stacktable.js/issues{/number}","pulls_url":"https://api.github.com/repos/johnpolacek/stacktable.js/pulls{/number}","milestones_url":"https://api.github.com/repos/johnpolacek/stacktable.js/milestones{/number}","notifications_url":"https://api.github.com/repos/johnpolacek/stacktable.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnpolacek/stacktable.js/labels{/name}","releases_url":"https://api.github.com/repos/johnpolacek/stacktable.js/releases{/id}","created_at":"2012-12-08T17:02:55Z","updated_at":"2015-11-19T08:38:02Z","pushed_at":"2015-11-19T12:43:46Z","git_url":"git://github.com/johnpolacek/stacktable.js.git","ssh_url":"git@github.com:johnpolacek/stacktable.js.git","clone_url":"https://github.com/johnpolacek/stacktable.js.git","svn_url":"https://github.com/johnpolacek/stacktable.js","homepage":"http://johnpolacek.github.com/stacktable.js/","size":504,"stargazers_count":736,"watchers_count":736,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":83,"mirror_url":null,"open_issues_count":7,"forks":83,"open_issues":7,"watchers":736,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/johnpolacek/stacktable.js/pulls/32"},"html":{"href":"https://github.com/johnpolacek/stacktable.js/pull/32"},"issue":{"href":"https://api.github.com/repos/johnpolacek/stacktable.js/issues/32"},"comments":{"href":"https://api.github.com/repos/johnpolacek/stacktable.js/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/johnpolacek/stacktable.js/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/johnpolacek/stacktable.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/johnpolacek/stacktable.js/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/johnpolacek/stacktable.js/statuses/f6a0777550a93392913c07ada2dd4a4704d838d3"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"johnpolacek","id":179482,"avatar_url":"https://avatars.githubusercontent.com/u/179482?v=3","gravatar_id":"","url":"https://api.github.com/users/johnpolacek","html_url":"https://github.com/johnpolacek","followers_url":"https://api.github.com/users/johnpolacek/followers","following_url":"https://api.github.com/users/johnpolacek/following{/other_user}","gists_url":"https://api.github.com/users/johnpolacek/gists{/gist_id}","starred_url":"https://api.github.com/users/johnpolacek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnpolacek/subscriptions","organizations_url":"https://api.github.com/users/johnpolacek/orgs","repos_url":"https://api.github.com/users/johnpolacek/repos","events_url":"https://api.github.com/users/johnpolacek/events{/privacy}","received_events_url":"https://api.github.com/users/johnpolacek/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":16,"deletions":12,"changed_files":1}}