{"action":"created","issue":{"url":"https://api.github.com/repos/brian-team/brian2/issues/537","labels_url":"https://api.github.com/repos/brian-team/brian2/issues/537/labels{/name}","comments_url":"https://api.github.com/repos/brian-team/brian2/issues/537/comments","events_url":"https://api.github.com/repos/brian-team/brian2/issues/537/events","html_url":"https://github.com/brian-team/brian2/pull/537","id":99685186,"number":537,"title":"[MRG] Fix OpenMP profiling","user":{"login":"mstimberg","id":1381982,"avatar_url":"https://avatars.githubusercontent.com/u/1381982?v=3","gravatar_id":"","url":"https://api.github.com/users/mstimberg","html_url":"https://github.com/mstimberg","followers_url":"https://api.github.com/users/mstimberg/followers","following_url":"https://api.github.com/users/mstimberg/following{/other_user}","gists_url":"https://api.github.com/users/mstimberg/gists{/gist_id}","starred_url":"https://api.github.com/users/mstimberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstimberg/subscriptions","organizations_url":"https://api.github.com/users/mstimberg/orgs","repos_url":"https://api.github.com/users/mstimberg/repos","events_url":"https://api.github.com/users/mstimberg/events{/privacy}","received_events_url":"https://api.github.com/users/mstimberg/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/brian-team/brian2/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-08-07T16:43:30Z","updated_at":"2015-08-08T09:47:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/brian-team/brian2/pulls/537","html_url":"https://github.com/brian-team/brian2/pull/537","diff_url":"https://github.com/brian-team/brian2/pull/537.diff","patch_url":"https://github.com/brian-team/brian2/pull/537.patch"},"body":"This has two small fixes to the OpenMP support: in the synapses template, every code that used a scalar variable incorrectly triggered the use of the single-thread code (affecting the post code in STDP). The second fix is to use `omp_get_wtime` instead of `std::clock` to count runtimes, this avoid the weird profiling results and makes it unnecessary to divide by number of threads etc.\r\n\r\nIt's all fairly simple changes and it would be ready to merge but the OpenMP test now apparently no longer compiles on Windows. @thesamovar could you have a look at it? It does not give any helpful output in the log and trying to figure this out in my Windows VM is way too annoying for a Friday evening..."},"comment":{"url":"https://api.github.com/repos/brian-team/brian2/issues/comments/128944908","html_url":"https://github.com/brian-team/brian2/pull/537#issuecomment-128944908","issue_url":"https://api.github.com/repos/brian-team/brian2/issues/537","id":128944908,"user":{"login":"mstimberg","id":1381982,"avatar_url":"https://avatars.githubusercontent.com/u/1381982?v=3","gravatar_id":"","url":"https://api.github.com/users/mstimberg","html_url":"https://github.com/mstimberg","followers_url":"https://api.github.com/users/mstimberg/followers","following_url":"https://api.github.com/users/mstimberg/following{/other_user}","gists_url":"https://api.github.com/users/mstimberg/gists{/gist_id}","starred_url":"https://api.github.com/users/mstimberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstimberg/subscriptions","organizations_url":"https://api.github.com/users/mstimberg/orgs","repos_url":"https://api.github.com/users/mstimberg/repos","events_url":"https://api.github.com/users/mstimberg/events{/privacy}","received_events_url":"https://api.github.com/users/mstimberg/received_events","type":"User","site_admin":false},"created_at":"2015-08-08T09:47:56Z","updated_at":"2015-08-08T09:47:56Z","body":"Thanks for figuring this out, I'm merging it now."}}