{"action":"created","issue":{"url":"https://api.github.com/repos/logstash-plugins/logstash-input-graphite/issues/5","labels_url":"https://api.github.com/repos/logstash-plugins/logstash-input-graphite/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-input-graphite/issues/5/comments","events_url":"https://api.github.com/repos/logstash-plugins/logstash-input-graphite/issues/5/events","html_url":"https://github.com/logstash-plugins/logstash-input-graphite/pull/5","id":110538505,"number":5,"title":"added comments and specs","user":{"login":"colinsurprenant","id":2010,"avatar_url":"https://avatars.githubusercontent.com/u/2010?v=3","gravatar_id":"","url":"https://api.github.com/users/colinsurprenant","html_url":"https://github.com/colinsurprenant","followers_url":"https://api.github.com/users/colinsurprenant/followers","following_url":"https://api.github.com/users/colinsurprenant/following{/other_user}","gists_url":"https://api.github.com/users/colinsurprenant/gists{/gist_id}","starred_url":"https://api.github.com/users/colinsurprenant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colinsurprenant/subscriptions","organizations_url":"https://api.github.com/users/colinsurprenant/orgs","repos_url":"https://api.github.com/users/colinsurprenant/repos","events_url":"https://api.github.com/users/colinsurprenant/events{/privacy}","received_events_url":"https://api.github.com/users/colinsurprenant/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-10-08T20:50:56Z","updated_at":"2015-10-08T21:23:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/logstash-plugins/logstash-input-graphite/pulls/5","html_url":"https://github.com/logstash-plugins/logstash-input-graphite/pull/5","diff_url":"https://github.com/logstash-plugins/logstash-input-graphite/pull/5.diff","patch_url":"https://github.com/logstash-plugins/logstash-input-graphite/pull/5.patch"},"body":"this PR basically only add specs to validate new shutdown semantics. \r\n\r\nthis replaces #3 - @jsvd's commit has been moved here.\r\n\r\nAs discussed in #3 I will add a new issue for eventual specs refactors. I refactored the spec to mimic what we have in the tcp input specs. we will also need to DRY the spec_helper code with the tcp and udp inputs."},"comment":{"url":"https://api.github.com/repos/logstash-plugins/logstash-input-graphite/issues/comments/146689857","html_url":"https://github.com/logstash-plugins/logstash-input-graphite/pull/5#issuecomment-146689857","issue_url":"https://api.github.com/repos/logstash-plugins/logstash-input-graphite/issues/5","id":146689857,"user":{"login":"colinsurprenant","id":2010,"avatar_url":"https://avatars.githubusercontent.com/u/2010?v=3","gravatar_id":"","url":"https://api.github.com/users/colinsurprenant","html_url":"https://github.com/colinsurprenant","followers_url":"https://api.github.com/users/colinsurprenant/followers","following_url":"https://api.github.com/users/colinsurprenant/following{/other_user}","gists_url":"https://api.github.com/users/colinsurprenant/gists{/gist_id}","starred_url":"https://api.github.com/users/colinsurprenant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colinsurprenant/subscriptions","organizations_url":"https://api.github.com/users/colinsurprenant/orgs","repos_url":"https://api.github.com/users/colinsurprenant/repos","events_url":"https://api.github.com/users/colinsurprenant/events{/privacy}","received_events_url":"https://api.github.com/users/colinsurprenant/received_events","type":"User","site_admin":false},"created_at":"2015-10-08T21:23:15Z","updated_at":"2015-10-08T21:23:15Z","body":":shipit: thanks guys!"}}