{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/universal-search-addon/issues/13","labels_url":"https://api.github.com/repos/mozilla/universal-search-addon/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/universal-search-addon/issues/13/comments","events_url":"https://api.github.com/repos/mozilla/universal-search-addon/issues/13/events","html_url":"https://github.com/mozilla/universal-search-addon/pull/13","id":90775607,"number":13,"title":"Adding stub ESLint task","user":{"login":"pdehaan","id":557895,"avatar_url":"https://avatars.githubusercontent.com/u/557895?v=3","gravatar_id":"","url":"https://api.github.com/users/pdehaan","html_url":"https://github.com/pdehaan","followers_url":"https://api.github.com/users/pdehaan/followers","following_url":"https://api.github.com/users/pdehaan/following{/other_user}","gists_url":"https://api.github.com/users/pdehaan/gists{/gist_id}","starred_url":"https://api.github.com/users/pdehaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdehaan/subscriptions","organizations_url":"https://api.github.com/users/pdehaan/orgs","repos_url":"https://api.github.com/users/pdehaan/repos","events_url":"https://api.github.com/users/pdehaan/events{/privacy}","received_events_url":"https://api.github.com/users/pdehaan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-06-24T20:42:22Z","updated_at":"2015-07-01T17:44:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/universal-search-addon/pulls/13","html_url":"https://github.com/mozilla/universal-search-addon/pull/13","diff_url":"https://github.com/mozilla/universal-search-addon/pull/13.diff","patch_url":"https://github.com/mozilla/universal-search-addon/pull/13.patch"},"body":"Alpha quality contribution here... I didn't add a Grunt or Gulp build system, and the ESLint rules still need a bit of tweaking, and the `npm run lint` task doesn't pass yet, but we have to start somewhere (even if that somewhere is closing this PR and telling me to go away).\r\n\r\n### Current ESLint output:\r\n\r\n```sh\r\n% npm run lint\r\n\r\n> mozilla-universal-search-addon@1.0.0 lint /Users/pdehaan/dev/github/universal-search-addon\r\n> eslint .\r\n\r\n\r\nbootstrap.js\r\n   3:57  error  Cm is defined but never used         no-unused-vars\r\n   9:9   error  startup is defined but never used    no-unused-vars\r\n  13:9   error  shutdown is defined but never used   no-unused-vars\r\n  15:13  error  Expected '===' and instead saw '=='  eqeqeq\r\n  15:16  error  \"APP_SHUTDOWN\" is not defined        no-undef\r\n  18:29  error  \"mediatorListener\" is not defined    no-undef\r\n  21:9   error  install is defined but never used    no-unused-vars\r\n  26:9   error  uninstall is defined but never used  no-unused-vars\r\n\r\nlib/main.js\r\n    5:17  error  Cc is defined but never used                       no-unused-vars\r\n    5:33  error  Ci is defined but never used                       no-unused-vars\r\n    5:57  error  Cm is defined but never used                       no-unused-vars\r\n   16:4   error  EXPORTED_SYMBOLS is defined but never used         no-unused-vars\r\n   25:53  error  Missing space before value for key \"configurable\"  key-spacing\r\n   25:65  error  Missing space before value for key \"value\"         key-spacing\r\n   75:3   error  Missing semicolon                                  semi\r\n   85:10  error  Trailing spaces not allowed                        no-trailing-spaces\r\n   91:44  error  win is already declared in the upper scope         no-shadow\r\n   92:14  error  Expected '===' and instead saw '=='                eqeqeq\r\n   95:56  error  Trailing spaces not allowed                        no-trailing-spaces\r\n   96:30  error  Expected '===' and instead saw '=='                eqeqeq\r\n  102:1   error  Unnecessary semicolon                              no-extra-semi\r\n  104:4   error  Main is defined but never used                     no-unused-vars\r\n\r\nlib/ui/GoButton.js\r\n  5:4  error  EXPORTED_SYMBOLS is defined but never used  no-unused-vars\r\n\r\nlib/ui/Popup.js\r\n   12:4   error  EXPORTED_SYMBOLS is defined but never used  no-unused-vars\r\n   22:1   error  Unnecessary semicolon                       no-extra-semi\r\n   23:18  error  Duplicate key 'onPopupShowing'              no-dupe-keys\r\n   23:18  error  Duplicate key 'onPopupHiding'               no-dupe-keys\r\n   26:11  error  Extra space before value for key \"render\"   key-spacing\r\n   67:11  error  Expected '!==' and instead saw '!='         eqeqeq\r\n   68:17  error  Expected '===' and instead saw '=='         eqeqeq\r\n   71:30  error  Expected '===' and instead saw '=='         eqeqeq\r\n   82:24  error  Expected '===' and instead saw '=='         eqeqeq\r\n   84:30  error  Expected '===' and instead saw '=='         eqeqeq\r\n  117:15  error  Multiple spaces found before '='            no-multi-spaces\r\n  126:41  error  A space is required after ','               comma-spacing\r\n  127:39  error  A space is required after ','               comma-spacing\r\n  175:7   error  Trailing spaces not allowed                 no-trailing-spaces\r\n  191:84  error  Missing semicolon                           semi\r\n  205:4   error  Expected no return value                    consistent-return\r\n  210:58  error  Missing semicolon                           semi\r\n  211:60  error  Missing semicolon                           semi\r\n  211:62  error  Unexpected trailing comma                   comma-dangle\r\n\r\nlib/ui/Urlbar.js\r\n   5:4   error  EXPORTED_SYMBOLS is defined but never used  no-unused-vars\r\n  53:18  error  Expected '===' and instead saw '=='         eqeqeq\r\n  56:18  error  Expected '===' and instead saw '=='         eqeqeq\r\n  57:50  error  Expected '===' and instead saw '=='         eqeqeq\r\n\r\n✖ 46 problems (46 errors, 0 warnings)\r\n```\r\n\r\nI can probably fix most of those style issues in a separate PR if you want. And we can disable any default ESLint rules that you don't like (ie: `comma-dangle`, `consistent-return`, and whatever else, although most make sense and are easy fixes). We can also ignore any errors per-line in ESLint if we want to ignore that `\"EXPORTED_SYMBOLS is defined but never used\"` message but not bulk disable that `no-unused-vars` rule.\r\n"},"comment":{"url":"https://api.github.com/repos/mozilla/universal-search-addon/issues/comments/117763235","html_url":"https://github.com/mozilla/universal-search-addon/pull/13#issuecomment-117763235","issue_url":"https://api.github.com/repos/mozilla/universal-search-addon/issues/13","id":117763235,"user":{"login":"6a68","id":96396,"avatar_url":"https://avatars.githubusercontent.com/u/96396?v=3","gravatar_id":"","url":"https://api.github.com/users/6a68","html_url":"https://github.com/6a68","followers_url":"https://api.github.com/users/6a68/followers","following_url":"https://api.github.com/users/6a68/following{/other_user}","gists_url":"https://api.github.com/users/6a68/gists{/gist_id}","starred_url":"https://api.github.com/users/6a68/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/6a68/subscriptions","organizations_url":"https://api.github.com/users/6a68/orgs","repos_url":"https://api.github.com/users/6a68/repos","events_url":"https://api.github.com/users/6a68/events{/privacy}","received_events_url":"https://api.github.com/users/6a68/received_events","type":"User","site_admin":false},"created_at":"2015-07-01T17:44:59Z","updated_at":"2015-07-01T17:44:59Z","body":"OK, the MVP is out the door, more or less. Guess this puppy needs a rebase.\r\n\r\nI wonder what variation of ESlint is used for Gecko JS, that is, the weird overlap of JS 1.8.5 and moz vendor-specific ES6 / WebAPI APIs/features. @pdehaan thoughts?"}}