{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/fxa-oauth-server/issues/218","labels_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/issues/218/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/issues/218/comments","events_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/issues/218/events","html_url":"https://github.com/mozilla/fxa-oauth-server/pull/218","id":57418543,"number":218,"title":"make the clients keys mandatory in the config file","user":{"login":"jrgm","id":758162,"avatar_url":"https://avatars.githubusercontent.com/u/758162?v=3","gravatar_id":"","url":"https://api.github.com/users/jrgm","html_url":"https://github.com/jrgm","followers_url":"https://api.github.com/users/jrgm/followers","following_url":"https://api.github.com/users/jrgm/following{/other_user}","gists_url":"https://api.github.com/users/jrgm/gists{/gist_id}","starred_url":"https://api.github.com/users/jrgm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrgm/subscriptions","organizations_url":"https://api.github.com/users/jrgm/orgs","repos_url":"https://api.github.com/users/jrgm/repos","events_url":"https://api.github.com/users/jrgm/events{/privacy}","received_events_url":"https://api.github.com/users/jrgm/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mozilla/fxa-oauth-server/labels/waffle:in%20review","name":"waffle:in review","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-02-12T05:16:53Z","updated_at":"2015-02-12T23:06:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/fxa-oauth-server/pulls/218","html_url":"https://github.com/mozilla/fxa-oauth-server/pull/218","diff_url":"https://github.com/mozilla/fxa-oauth-server/pull/218.diff","patch_url":"https://github.com/mozilla/fxa-oauth-server/pull/218.patch"},"body":"In getting setup to deploy the train-30 oauth server in production today, there was delay caused by a one-character typo in the production config, a typo in 'redirecturl' (all lower case, not camelCase 'redirectUrl'). The typo didn't exist in the stage config, which made this tedious to figure out.\r\n\r\nAnyways, the code as written should guard against and attempt to insert a NULL into a non-NULL column.\r\n\r\nIn dev, a mispelled key will show an error message like this:\r\n\r\n  `fxa-oauth-server.db.ERROR: client.missing.keys {\"key\":\"canGrant\",\"name\":\"Firefox Hello DEV\"}`\r\n\r\n(We lose some flexibility in the config files by making keys mandatory; could consider just moving this logic to db migration files.)\r\n\r\nNOTE: If this patch is merged, this file will need to have 'canGrant: false' added where is it missing: https://github.com/mozilla/fxa-dev/blob/master/roles/oauth/templates/config.json.j2. "},"comment":{"url":"https://api.github.com/repos/mozilla/fxa-oauth-server/issues/comments/74173253","html_url":"https://github.com/mozilla/fxa-oauth-server/pull/218#issuecomment-74173253","issue_url":"https://api.github.com/repos/mozilla/fxa-oauth-server/issues/218","id":74173253,"user":{"login":"jrgm","id":758162,"avatar_url":"https://avatars.githubusercontent.com/u/758162?v=3","gravatar_id":"","url":"https://api.github.com/users/jrgm","html_url":"https://github.com/jrgm","followers_url":"https://api.github.com/users/jrgm/followers","following_url":"https://api.github.com/users/jrgm/following{/other_user}","gists_url":"https://api.github.com/users/jrgm/gists{/gist_id}","starred_url":"https://api.github.com/users/jrgm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrgm/subscriptions","organizations_url":"https://api.github.com/users/jrgm/orgs","repos_url":"https://api.github.com/users/jrgm/repos","events_url":"https://api.github.com/users/jrgm/events{/privacy}","received_events_url":"https://api.github.com/users/jrgm/received_events","type":"User","site_admin":false},"created_at":"2015-02-12T23:06:33Z","updated_at":"2015-02-12T23:06:33Z","body":"Okay merging this and https://github.com/mozilla/fxa-dev/pull/113 and will make sure latest.dev.lcip.org is happy. "}}