{"action":"created","comment":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/comments/31584315","id":31584315,"diff_hunk":"@@ -40,4 +49,26 @@ public void testFlowManager() throws Exception {\n     flowManager.stop();\n   }\n \n+  @Test\n+  public void testDeployApplicationInNamespace() throws Exception {\n+    Id.Namespace namespace = new Id.Namespace (\"Test1\");\n+    createNamespace(new NamespaceMeta.Builder().setName(namespace).build());\n+    ClientConfig clientConfig = new ClientConfig.Builder(getClientConfig()).build();\n+    clientConfig.setNamespace(namespace);\n+    ApplicationManager applicationManager = deployApplication(namespace, TestApplication.class);\n+    FlowManager flowManager = applicationManager.getFlowManager(TestFlow.NAME).start();\n+    flowManager.stop();\n+    ApplicationClient applicationClient = new ApplicationClient(clientConfig);\n+    Assert.assertEquals(\"TestApplication\", applicationClient.list().get(0).getName());\n+    applicationClient.delete(\"TestApplication\");\n+    Assert.assertEquals(0, new ApplicationClient(clientConfig).list().size());\n+\n+    // Check the default namespaces applications to see whether the application wasnt made in the default namespace\n+    ClientConfig defaultClientConfig = new ClientConfig.Builder(getClientConfig()).build();\n+    defaultClientConfig.setNamespace(Constants.DEFAULT_NAMESPACE_ID);\n+    Assert.assertEquals(0, new ApplicationClient(defaultClientConfig).list().size());","path":"cdap-integration-test/src/test/java/co/cask/cdap/test/IntegrationTestBaseTest.java","position":45,"original_position":45,"commit_id":"0e4405b4fb5db4261eb3ac5d1b5a7bea8115a62e","original_commit_id":"0e4405b4fb5db4261eb3ac5d1b5a7bea8115a62e","user":{"login":"gsps1","id":1328150,"avatar_url":"https://avatars.githubusercontent.com/u/1328150?v=3","gravatar_id":"","url":"https://api.github.com/users/gsps1","html_url":"https://github.com/gsps1","followers_url":"https://api.github.com/users/gsps1/followers","following_url":"https://api.github.com/users/gsps1/following{/other_user}","gists_url":"https://api.github.com/users/gsps1/gists{/gist_id}","starred_url":"https://api.github.com/users/gsps1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsps1/subscriptions","organizations_url":"https://api.github.com/users/gsps1/orgs","repos_url":"https://api.github.com/users/gsps1/repos","events_url":"https://api.github.com/users/gsps1/events{/privacy}","received_events_url":"https://api.github.com/users/gsps1/received_events","type":"User","site_admin":false},"body":"i would move this check before you delete the application in ``test`` namespace","created_at":"2015-06-03T00:15:02Z","updated_at":"2015-06-03T00:15:02Z","html_url":"https://github.com/caskdata/cdap/pull/2817#discussion_r31584315","pull_request_url":"https://api.github.com/repos/caskdata/cdap/pulls/2817","_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments/31584315"},"html":{"href":"https://github.com/caskdata/cdap/pull/2817#discussion_r31584315"},"pull_request":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/2817"}}},"pull_request":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/2817","id":36787234,"html_url":"https://github.com/caskdata/cdap/pull/2817","diff_url":"https://github.com/caskdata/cdap/pull/2817.diff","patch_url":"https://github.com/caskdata/cdap/pull/2817.patch","issue_url":"https://api.github.com/repos/caskdata/cdap/issues/2817","number":2817,"state":"open","locked":false,"title":"Feature/cdap 2535 fix deploy integration test manager","user":{"login":"rohanahata","id":2381977,"avatar_url":"https://avatars.githubusercontent.com/u/2381977?v=3","gravatar_id":"","url":"https://api.github.com/users/rohanahata","html_url":"https://github.com/rohanahata","followers_url":"https://api.github.com/users/rohanahata/followers","following_url":"https://api.github.com/users/rohanahata/following{/other_user}","gists_url":"https://api.github.com/users/rohanahata/gists{/gist_id}","starred_url":"https://api.github.com/users/rohanahata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohanahata/subscriptions","organizations_url":"https://api.github.com/users/rohanahata/orgs","repos_url":"https://api.github.com/users/rohanahata/repos","events_url":"https://api.github.com/users/rohanahata/events{/privacy}","received_events_url":"https://api.github.com/users/rohanahata/received_events","type":"User","site_admin":false},"body":"Feature makes sure that deploy application is now making use of namespace that is passed as function parameter\r\nBuild : http://builds.cask.co/browse/CDAP-DUT1944-2\r\nJIRA : https://issues.cask.co/browse/CDAP-2535","created_at":"2015-06-03T00:04:10Z","updated_at":"2015-06-03T00:15:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd786abc7c366fe4dc5b3f635b5808af4e392a15","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/caskdata/cdap/pulls/2817/commits","review_comments_url":"https://api.github.com/repos/caskdata/cdap/pulls/2817/comments","review_comment_url":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caskdata/cdap/issues/2817/comments","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/0e4405b4fb5db4261eb3ac5d1b5a7bea8115a62e","head":{"label":"caskdata:feature/CDAP-2535-fix-deploy-integrationTestManager","ref":"feature/CDAP-2535-fix-deploy-integrationTestManager","sha":"0e4405b4fb5db4261eb3ac5d1b5a7bea8115a62e","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","created_at":"2014-08-02T09:00:10Z","updated_at":"2015-05-29T17:15:23Z","pushed_at":"2015-06-03T00:13:04Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"http://cdap.io","size":881989,"stargazers_count":50,"watchers_count":50,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":17,"mirror_url":null,"open_issues_count":20,"forks":17,"open_issues":20,"watchers":50,"default_branch":"develop"}},"base":{"label":"caskdata:develop","ref":"develop","sha":"fb7f14387d1e6de789cacb65414c628d46d9506d","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","created_at":"2014-08-02T09:00:10Z","updated_at":"2015-05-29T17:15:23Z","pushed_at":"2015-06-03T00:13:04Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"http://cdap.io","size":881989,"stargazers_count":50,"watchers_count":50,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":17,"mirror_url":null,"open_issues_count":20,"forks":17,"open_issues":20,"watchers":50,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/2817"},"html":{"href":"https://github.com/caskdata/cdap/pull/2817"},"issue":{"href":"https://api.github.com/repos/caskdata/cdap/issues/2817"},"comments":{"href":"https://api.github.com/repos/caskdata/cdap/issues/2817/comments"},"review_comments":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/2817/comments"},"review_comment":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/2817/commits"},"statuses":{"href":"https://api.github.com/repos/caskdata/cdap/statuses/0e4405b4fb5db4261eb3ac5d1b5a7bea8115a62e"}}}}