{"action":"created","issue":{"url":"https://api.github.com/repos/OpenF2/F2/issues/219","labels_url":"https://api.github.com/repos/OpenF2/F2/issues/219/labels{/name}","comments_url":"https://api.github.com/repos/OpenF2/F2/issues/219/comments","events_url":"https://api.github.com/repos/OpenF2/F2/issues/219/events","html_url":"https://github.com/OpenF2/F2/pull/219","id":53092666,"number":219,"title":"Refactor App Handlers","user":{"login":"montlebalm","id":739390,"avatar_url":"https://avatars.githubusercontent.com/u/739390?v=3","gravatar_id":"","url":"https://api.github.com/users/montlebalm","html_url":"https://github.com/montlebalm","followers_url":"https://api.github.com/users/montlebalm/followers","following_url":"https://api.github.com/users/montlebalm/following{/other_user}","gists_url":"https://api.github.com/users/montlebalm/gists{/gist_id}","starred_url":"https://api.github.com/users/montlebalm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/montlebalm/subscriptions","organizations_url":"https://api.github.com/users/montlebalm/orgs","repos_url":"https://api.github.com/users/montlebalm/repos","events_url":"https://api.github.com/users/montlebalm/events{/privacy}","received_events_url":"https://api.github.com/users/montlebalm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2014-12-30T04:33:44Z","updated_at":"2015-01-13T22:53:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OpenF2/F2/pulls/219","html_url":"https://github.com/OpenF2/F2/pull/219","diff_url":"https://github.com/OpenF2/F2/pull/219.diff","patch_url":"https://github.com/OpenF2/F2/pull/219.patch"},"body":"This PR refactors the AppHandlers code and related tests. Its intent is to speed up the necessary tests and remove the unwanted ones (~1,300 loc). The changes to the library are minor and should retain all prior functionality.\r\n\r\nChanges:\r\n- Clean up formatting of source\r\n- Remove unnecessary tests\r\n- Add new appropriate tests\r\n- Rename test sections to be more clear\r\n- Speed up tests\r\n\r\nMinor additional changes:\r\n- Moved preamble to header template\r\n- Simplified `F2.log()`\r\n\r\nPlease double check my changes to `src/lib/app_handlers.js` and `F2.log()` to make sure I didn't alter existing functionality. Also, if possible, please pull down this branch and look over the AppHandler tests. See if there's anything missing or if any of the test cases should be moved around."},"comment":{"url":"https://api.github.com/repos/OpenF2/F2/issues/comments/69837469","html_url":"https://github.com/OpenF2/F2/pull/219#issuecomment-69837469","issue_url":"https://api.github.com/repos/OpenF2/F2/issues/219","id":69837469,"user":{"login":"montlebalm","id":739390,"avatar_url":"https://avatars.githubusercontent.com/u/739390?v=3","gravatar_id":"","url":"https://api.github.com/users/montlebalm","html_url":"https://github.com/montlebalm","followers_url":"https://api.github.com/users/montlebalm/followers","following_url":"https://api.github.com/users/montlebalm/following{/other_user}","gists_url":"https://api.github.com/users/montlebalm/gists{/gist_id}","starred_url":"https://api.github.com/users/montlebalm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/montlebalm/subscriptions","organizations_url":"https://api.github.com/users/montlebalm/orgs","repos_url":"https://api.github.com/users/montlebalm/repos","events_url":"https://api.github.com/users/montlebalm/events{/privacy}","received_events_url":"https://api.github.com/users/montlebalm/received_events","type":"User","site_admin":false},"created_at":"2015-01-13T22:53:40Z","updated_at":"2015-01-13T22:53:40Z","body":"@markhealey @brianbaker ok to merge?"}}