{"action":"created","comment":{"url":"https://api.github.com/repos/presidentbeef/brakeman/pulls/comments/23161482","id":23161482,"diff_hunk":"@@ -2,4 +2,9 @@ class SweetLib\n   def do_some_cool_stuff bad\n     `ls #{bad}`\n   end\n+\n+  def test_find_group","path":"test/apps/rails4/lib/sweet_lib.rb","position":5,"original_position":5,"commit_id":"3b4ff89182b39adb079a72f75bee78185adebdcc","original_commit_id":"3b4ff89182b39adb079a72f75bee78185adebdcc","user":{"login":"ptoomey3","id":103360,"avatar_url":"https://avatars.githubusercontent.com/u/103360?v=3","gravatar_id":"","url":"https://api.github.com/users/ptoomey3","html_url":"https://github.com/ptoomey3","followers_url":"https://api.github.com/users/ptoomey3/followers","following_url":"https://api.github.com/users/ptoomey3/following{/other_user}","gists_url":"https://api.github.com/users/ptoomey3/gists{/gist_id}","starred_url":"https://api.github.com/users/ptoomey3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptoomey3/subscriptions","organizations_url":"https://api.github.com/users/ptoomey3/orgs","repos_url":"https://api.github.com/users/ptoomey3/repos","events_url":"https://api.github.com/users/ptoomey3/events{/privacy}","received_events_url":"https://api.github.com/users/ptoomey3/received_events","type":"User","site_admin":true},"body":"Same with the test name. It should have been `test_remove` or some such thing. ","created_at":"2015-01-19T14:10:49Z","updated_at":"2015-01-19T14:10:49Z","html_url":"https://github.com/presidentbeef/brakeman/pull/605#discussion_r23161482","pull_request_url":"https://api.github.com/repos/presidentbeef/brakeman/pulls/605","_links":{"self":{"href":"https://api.github.com/repos/presidentbeef/brakeman/pulls/comments/23161482"},"html":{"href":"https://github.com/presidentbeef/brakeman/pull/605#discussion_r23161482"},"pull_request":{"href":"https://api.github.com/repos/presidentbeef/brakeman/pulls/605"}}},"pull_request":{"url":"https://api.github.com/repos/presidentbeef/brakeman/pulls/605","id":26916071,"html_url":"https://github.com/presidentbeef/brakeman/pull/605","diff_url":"https://github.com/presidentbeef/brakeman/pull/605.diff","patch_url":"https://github.com/presidentbeef/brakeman/pull/605.patch","issue_url":"https://api.github.com/repos/presidentbeef/brakeman/issues/605","number":605,"state":"closed","locked":false,"title":"process inner body expressions to trigger interpolated string warnings","user":{"login":"ptoomey3","id":103360,"avatar_url":"https://avatars.githubusercontent.com/u/103360?v=3","gravatar_id":"","url":"https://api.github.com/users/ptoomey3","html_url":"https://github.com/ptoomey3","followers_url":"https://api.github.com/users/ptoomey3/followers","following_url":"https://api.github.com/users/ptoomey3/following{/other_user}","gists_url":"https://api.github.com/users/ptoomey3/gists{/gist_id}","starred_url":"https://api.github.com/users/ptoomey3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptoomey3/subscriptions","organizations_url":"https://api.github.com/users/ptoomey3/orgs","repos_url":"https://api.github.com/users/ptoomey3/repos","events_url":"https://api.github.com/users/ptoomey3/events{/privacy}","received_events_url":"https://api.github.com/users/ptoomey3/received_events","type":"User","site_admin":true},"body":"We had added library processing to our internal fork of brakeman and noticed that some things, like warnings related to interpolated strings, were not getting triggered in scanned libs. So, I made a change in https://github.com/github/brakeman/pull/10 that processes the inner body expression similar to how other processors do (controllers, etc). However, I'm still not 100% sure if the approach taken is idiomatic with the rest of brakeman. So, please let me know if there is a more \"correct\" way of ensuring that the nested body's are processed so that interpolated strings are analyzed correctly. \r\n\r\n/cc @gregose @mastahyeti @oreoshake ","created_at":"2015-01-06T20:37:40Z","updated_at":"2015-01-19T14:10:49Z","closed_at":"2015-01-19T09:47:07Z","merged_at":"2015-01-19T09:47:07Z","merge_commit_sha":"b4bcb3e4a296986ca12499927056cde93c58ae5d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/presidentbeef/brakeman/pulls/605/commits","review_comments_url":"https://api.github.com/repos/presidentbeef/brakeman/pulls/605/comments","review_comment_url":"https://api.github.com/repos/presidentbeef/brakeman/pulls/comments/{number}","comments_url":"https://api.github.com/repos/presidentbeef/brakeman/issues/605/comments","statuses_url":"https://api.github.com/repos/presidentbeef/brakeman/statuses/3b4ff89182b39adb079a72f75bee78185adebdcc","head":{"label":"github:add_interp_string_lib_test","ref":"add_interp_string_lib_test","sha":"3b4ff89182b39adb079a72f75bee78185adebdcc","user":{"login":"github","id":9919,"avatar_url":"https://avatars.githubusercontent.com/u/9919?v=3","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"repo":{"id":8016619,"name":"brakeman","full_name":"github/brakeman","owner":{"login":"github","id":9919,"avatar_url":"https://avatars.githubusercontent.com/u/9919?v=3","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/github/brakeman","description":"A static analysis security vulnerability scanner for Ruby on Rails applications","fork":true,"url":"https://api.github.com/repos/github/brakeman","forks_url":"https://api.github.com/repos/github/brakeman/forks","keys_url":"https://api.github.com/repos/github/brakeman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/github/brakeman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/github/brakeman/teams","hooks_url":"https://api.github.com/repos/github/brakeman/hooks","issue_events_url":"https://api.github.com/repos/github/brakeman/issues/events{/number}","events_url":"https://api.github.com/repos/github/brakeman/events","assignees_url":"https://api.github.com/repos/github/brakeman/assignees{/user}","branches_url":"https://api.github.com/repos/github/brakeman/branches{/branch}","tags_url":"https://api.github.com/repos/github/brakeman/tags","blobs_url":"https://api.github.com/repos/github/brakeman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/github/brakeman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/github/brakeman/git/refs{/sha}","trees_url":"https://api.github.com/repos/github/brakeman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/github/brakeman/statuses/{sha}","languages_url":"https://api.github.com/repos/github/brakeman/languages","stargazers_url":"https://api.github.com/repos/github/brakeman/stargazers","contributors_url":"https://api.github.com/repos/github/brakeman/contributors","subscribers_url":"https://api.github.com/repos/github/brakeman/subscribers","subscription_url":"https://api.github.com/repos/github/brakeman/subscription","commits_url":"https://api.github.com/repos/github/brakeman/commits{/sha}","git_commits_url":"https://api.github.com/repos/github/brakeman/git/commits{/sha}","comments_url":"https://api.github.com/repos/github/brakeman/comments{/number}","issue_comment_url":"https://api.github.com/repos/github/brakeman/issues/comments/{number}","contents_url":"https://api.github.com/repos/github/brakeman/contents/{+path}","compare_url":"https://api.github.com/repos/github/brakeman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/github/brakeman/merges","archive_url":"https://api.github.com/repos/github/brakeman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/github/brakeman/downloads","issues_url":"https://api.github.com/repos/github/brakeman/issues{/number}","pulls_url":"https://api.github.com/repos/github/brakeman/pulls{/number}","milestones_url":"https://api.github.com/repos/github/brakeman/milestones{/number}","notifications_url":"https://api.github.com/repos/github/brakeman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/github/brakeman/labels{/name}","releases_url":"https://api.github.com/repos/github/brakeman/releases{/id}","created_at":"2013-02-04T21:28:57Z","updated_at":"2015-01-11T01:35:35Z","pushed_at":"2015-01-06T23:34:26Z","git_url":"git://github.com/github/brakeman.git","ssh_url":"git@github.com:github/brakeman.git","clone_url":"https://github.com/github/brakeman.git","svn_url":"https://github.com/github/brakeman","homepage":"http://brakemanscanner.org/","size":10904,"stargazers_count":12,"watchers_count":12,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":0,"forks":5,"open_issues":0,"watchers":12,"default_branch":"github"}},"base":{"label":"presidentbeef:master","ref":"master","sha":"9fcfd33b6481d882ab1e414dde5e8a0d3bcc01b7","user":{"login":"presidentbeef","id":75613,"avatar_url":"https://avatars.githubusercontent.com/u/75613?v=3","gravatar_id":"","url":"https://api.github.com/users/presidentbeef","html_url":"https://github.com/presidentbeef","followers_url":"https://api.github.com/users/presidentbeef/followers","following_url":"https://api.github.com/users/presidentbeef/following{/other_user}","gists_url":"https://api.github.com/users/presidentbeef/gists{/gist_id}","starred_url":"https://api.github.com/users/presidentbeef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/presidentbeef/subscriptions","organizations_url":"https://api.github.com/users/presidentbeef/orgs","repos_url":"https://api.github.com/users/presidentbeef/repos","events_url":"https://api.github.com/users/presidentbeef/events{/privacy}","received_events_url":"https://api.github.com/users/presidentbeef/received_events","type":"User","site_admin":false},"repo":{"id":865250,"name":"brakeman","full_name":"presidentbeef/brakeman","owner":{"login":"presidentbeef","id":75613,"avatar_url":"https://avatars.githubusercontent.com/u/75613?v=3","gravatar_id":"","url":"https://api.github.com/users/presidentbeef","html_url":"https://github.com/presidentbeef","followers_url":"https://api.github.com/users/presidentbeef/followers","following_url":"https://api.github.com/users/presidentbeef/following{/other_user}","gists_url":"https://api.github.com/users/presidentbeef/gists{/gist_id}","starred_url":"https://api.github.com/users/presidentbeef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/presidentbeef/subscriptions","organizations_url":"https://api.github.com/users/presidentbeef/orgs","repos_url":"https://api.github.com/users/presidentbeef/repos","events_url":"https://api.github.com/users/presidentbeef/events{/privacy}","received_events_url":"https://api.github.com/users/presidentbeef/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/presidentbeef/brakeman","description":"A static analysis security vulnerability scanner for Ruby on Rails applications","fork":false,"url":"https://api.github.com/repos/presidentbeef/brakeman","forks_url":"https://api.github.com/repos/presidentbeef/brakeman/forks","keys_url":"https://api.github.com/repos/presidentbeef/brakeman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/presidentbeef/brakeman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/presidentbeef/brakeman/teams","hooks_url":"https://api.github.com/repos/presidentbeef/brakeman/hooks","issue_events_url":"https://api.github.com/repos/presidentbeef/brakeman/issues/events{/number}","events_url":"https://api.github.com/repos/presidentbeef/brakeman/events","assignees_url":"https://api.github.com/repos/presidentbeef/brakeman/assignees{/user}","branches_url":"https://api.github.com/repos/presidentbeef/brakeman/branches{/branch}","tags_url":"https://api.github.com/repos/presidentbeef/brakeman/tags","blobs_url":"https://api.github.com/repos/presidentbeef/brakeman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/presidentbeef/brakeman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/presidentbeef/brakeman/git/refs{/sha}","trees_url":"https://api.github.com/repos/presidentbeef/brakeman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/presidentbeef/brakeman/statuses/{sha}","languages_url":"https://api.github.com/repos/presidentbeef/brakeman/languages","stargazers_url":"https://api.github.com/repos/presidentbeef/brakeman/stargazers","contributors_url":"https://api.github.com/repos/presidentbeef/brakeman/contributors","subscribers_url":"https://api.github.com/repos/presidentbeef/brakeman/subscribers","subscription_url":"https://api.github.com/repos/presidentbeef/brakeman/subscription","commits_url":"https://api.github.com/repos/presidentbeef/brakeman/commits{/sha}","git_commits_url":"https://api.github.com/repos/presidentbeef/brakeman/git/commits{/sha}","comments_url":"https://api.github.com/repos/presidentbeef/brakeman/comments{/number}","issue_comment_url":"https://api.github.com/repos/presidentbeef/brakeman/issues/comments/{number}","contents_url":"https://api.github.com/repos/presidentbeef/brakeman/contents/{+path}","compare_url":"https://api.github.com/repos/presidentbeef/brakeman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/presidentbeef/brakeman/merges","archive_url":"https://api.github.com/repos/presidentbeef/brakeman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/presidentbeef/brakeman/downloads","issues_url":"https://api.github.com/repos/presidentbeef/brakeman/issues{/number}","pulls_url":"https://api.github.com/repos/presidentbeef/brakeman/pulls{/number}","milestones_url":"https://api.github.com/repos/presidentbeef/brakeman/milestones{/number}","notifications_url":"https://api.github.com/repos/presidentbeef/brakeman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/presidentbeef/brakeman/labels{/name}","releases_url":"https://api.github.com/repos/presidentbeef/brakeman/releases{/id}","created_at":"2010-08-27T00:00:58Z","updated_at":"2015-01-19T13:57:26Z","pushed_at":"2015-01-19T09:47:07Z","git_url":"git://github.com/presidentbeef/brakeman.git","ssh_url":"git@github.com:presidentbeef/brakeman.git","clone_url":"https://github.com/presidentbeef/brakeman.git","svn_url":"https://github.com/presidentbeef/brakeman","homepage":"http://brakemanscanner.org/","size":26120,"stargazers_count":2222,"watchers_count":2222,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":171,"mirror_url":null,"open_issues_count":28,"forks":171,"open_issues":28,"watchers":2222,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/presidentbeef/brakeman/pulls/605"},"html":{"href":"https://github.com/presidentbeef/brakeman/pull/605"},"issue":{"href":"https://api.github.com/repos/presidentbeef/brakeman/issues/605"},"comments":{"href":"https://api.github.com/repos/presidentbeef/brakeman/issues/605/comments"},"review_comments":{"href":"https://api.github.com/repos/presidentbeef/brakeman/pulls/605/comments"},"review_comment":{"href":"https://api.github.com/repos/presidentbeef/brakeman/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/presidentbeef/brakeman/pulls/605/commits"},"statuses":{"href":"https://api.github.com/repos/presidentbeef/brakeman/statuses/3b4ff89182b39adb079a72f75bee78185adebdcc"}}}}