{"action":"created","comment":{"url":"https://api.github.com/repos/zotero/translators/pulls/comments/38476862","id":38476862,"diff_hunk":"@@ -1173,6 +1173,20 @@ function doExport() {\n \t\t// determine type\n \t\tvar type = zotero2bibtexTypeMap[item.itemType];\n \t\tif (typeof(type) == \"function\") { type = type(item); }\n+\n+\t\t// The thesis Zotero type doesn't nicely map onto a BibTeX type,\n+\t\t// as BibTeX uses both @mastersthesis and @phdthesis. We thus have\n+\t\t// to tell them apart by the \"Type\" field as well as by the item type.\n+\t\tif (type == \"phdthesis\") {\n+\t\t\t// In practice, we just want to separate out masters theses,\n+\t\t\t// and will assume everything else maps to @phdthesis. Better to\n+\t\t\t// err on the side of caution.\n+\t\t\tif (item[\"type\"] && item[\"type\"].toLowerCase() == \"masters\") {","path":"BibTeX.js","position":12,"original_position":12,"commit_id":"700460c5b24cd7d6214542d19d7c598143349125","original_commit_id":"700460c5b24cd7d6214542d19d7c598143349125","user":{"login":"adam3smith","id":128986,"avatar_url":"https://avatars.githubusercontent.com/u/128986?v=3","gravatar_id":"","url":"https://api.github.com/users/adam3smith","html_url":"https://github.com/adam3smith","followers_url":"https://api.github.com/users/adam3smith/followers","following_url":"https://api.github.com/users/adam3smith/following{/other_user}","gists_url":"https://api.github.com/users/adam3smith/gists{/gist_id}","starred_url":"https://api.github.com/users/adam3smith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adam3smith/subscriptions","organizations_url":"https://api.github.com/users/adam3smith/orgs","repos_url":"https://api.github.com/users/adam3smith/repos","events_url":"https://api.github.com/users/adam3smith/events{/privacy}","received_events_url":"https://api.github.com/users/adam3smith/received_events","type":"User","site_admin":false},"body":"I think we can be a little more generous here, no? I'm thinking ```.indexOf(\"master\")!=-1```\r\n@karnesky -- any objections here?","created_at":"2015-09-01T21:51:03Z","updated_at":"2015-09-01T21:51:03Z","html_url":"https://github.com/zotero/translators/pull/941#discussion_r38476862","pull_request_url":"https://api.github.com/repos/zotero/translators/pulls/941","_links":{"self":{"href":"https://api.github.com/repos/zotero/translators/pulls/comments/38476862"},"html":{"href":"https://github.com/zotero/translators/pull/941#discussion_r38476862"},"pull_request":{"href":"https://api.github.com/repos/zotero/translators/pulls/941"}}},"pull_request":{"url":"https://api.github.com/repos/zotero/translators/pulls/941","id":43843982,"html_url":"https://github.com/zotero/translators/pull/941","diff_url":"https://github.com/zotero/translators/pull/941.diff","patch_url":"https://github.com/zotero/translators/pull/941.patch","issue_url":"https://api.github.com/repos/zotero/translators/issues/941","number":941,"state":"open","locked":false,"title":"Discriminates phdthesis and mastersthesis BibTeX types.","user":{"login":"cgranade","id":31516,"avatar_url":"https://avatars.githubusercontent.com/u/31516?v=3","gravatar_id":"","url":"https://api.github.com/users/cgranade","html_url":"https://github.com/cgranade","followers_url":"https://api.github.com/users/cgranade/followers","following_url":"https://api.github.com/users/cgranade/following{/other_user}","gists_url":"https://api.github.com/users/cgranade/gists{/gist_id}","starred_url":"https://api.github.com/users/cgranade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgranade/subscriptions","organizations_url":"https://api.github.com/users/cgranade/orgs","repos_url":"https://api.github.com/users/cgranade/repos","events_url":"https://api.github.com/users/cgranade/events{/privacy}","received_events_url":"https://api.github.com/users/cgranade/received_events","type":"User","site_admin":false},"body":"This PR discriminates between the ``@phdthesis`` and ``@mastersthesis`` BibTeX types using the type field of Zotero items of type ``thesis``. See https://forums.zotero.org/discussion/6276/support-for-masters-thesis-type-and-full-bibtex-format/ for a discussion of the pros and cons to this approach.","created_at":"2015-09-01T07:10:26Z","updated_at":"2015-09-01T21:51:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec6d977cb128c965f0da96931c5abca7f268d025","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zotero/translators/pulls/941/commits","review_comments_url":"https://api.github.com/repos/zotero/translators/pulls/941/comments","review_comment_url":"https://api.github.com/repos/zotero/translators/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zotero/translators/issues/941/comments","statuses_url":"https://api.github.com/repos/zotero/translators/statuses/700460c5b24cd7d6214542d19d7c598143349125","head":{"label":"cgranade:fix-bibtex-revtex","ref":"fix-bibtex-revtex","sha":"700460c5b24cd7d6214542d19d7c598143349125","user":{"login":"cgranade","id":31516,"avatar_url":"https://avatars.githubusercontent.com/u/31516?v=3","gravatar_id":"","url":"https://api.github.com/users/cgranade","html_url":"https://github.com/cgranade","followers_url":"https://api.github.com/users/cgranade/followers","following_url":"https://api.github.com/users/cgranade/following{/other_user}","gists_url":"https://api.github.com/users/cgranade/gists{/gist_id}","starred_url":"https://api.github.com/users/cgranade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgranade/subscriptions","organizations_url":"https://api.github.com/users/cgranade/orgs","repos_url":"https://api.github.com/users/cgranade/repos","events_url":"https://api.github.com/users/cgranade/events{/privacy}","received_events_url":"https://api.github.com/users/cgranade/received_events","type":"User","site_admin":false},"repo":{"id":41721790,"name":"translators","full_name":"cgranade/translators","owner":{"login":"cgranade","id":31516,"avatar_url":"https://avatars.githubusercontent.com/u/31516?v=3","gravatar_id":"","url":"https://api.github.com/users/cgranade","html_url":"https://github.com/cgranade","followers_url":"https://api.github.com/users/cgranade/followers","following_url":"https://api.github.com/users/cgranade/following{/other_user}","gists_url":"https://api.github.com/users/cgranade/gists{/gist_id}","starred_url":"https://api.github.com/users/cgranade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgranade/subscriptions","organizations_url":"https://api.github.com/users/cgranade/orgs","repos_url":"https://api.github.com/users/cgranade/repos","events_url":"https://api.github.com/users/cgranade/events{/privacy}","received_events_url":"https://api.github.com/users/cgranade/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cgranade/translators","description":"Zotero Translators","fork":true,"url":"https://api.github.com/repos/cgranade/translators","forks_url":"https://api.github.com/repos/cgranade/translators/forks","keys_url":"https://api.github.com/repos/cgranade/translators/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cgranade/translators/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cgranade/translators/teams","hooks_url":"https://api.github.com/repos/cgranade/translators/hooks","issue_events_url":"https://api.github.com/repos/cgranade/translators/issues/events{/number}","events_url":"https://api.github.com/repos/cgranade/translators/events","assignees_url":"https://api.github.com/repos/cgranade/translators/assignees{/user}","branches_url":"https://api.github.com/repos/cgranade/translators/branches{/branch}","tags_url":"https://api.github.com/repos/cgranade/translators/tags","blobs_url":"https://api.github.com/repos/cgranade/translators/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cgranade/translators/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cgranade/translators/git/refs{/sha}","trees_url":"https://api.github.com/repos/cgranade/translators/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cgranade/translators/statuses/{sha}","languages_url":"https://api.github.com/repos/cgranade/translators/languages","stargazers_url":"https://api.github.com/repos/cgranade/translators/stargazers","contributors_url":"https://api.github.com/repos/cgranade/translators/contributors","subscribers_url":"https://api.github.com/repos/cgranade/translators/subscribers","subscription_url":"https://api.github.com/repos/cgranade/translators/subscription","commits_url":"https://api.github.com/repos/cgranade/translators/commits{/sha}","git_commits_url":"https://api.github.com/repos/cgranade/translators/git/commits{/sha}","comments_url":"https://api.github.com/repos/cgranade/translators/comments{/number}","issue_comment_url":"https://api.github.com/repos/cgranade/translators/issues/comments{/number}","contents_url":"https://api.github.com/repos/cgranade/translators/contents/{+path}","compare_url":"https://api.github.com/repos/cgranade/translators/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cgranade/translators/merges","archive_url":"https://api.github.com/repos/cgranade/translators/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cgranade/translators/downloads","issues_url":"https://api.github.com/repos/cgranade/translators/issues{/number}","pulls_url":"https://api.github.com/repos/cgranade/translators/pulls{/number}","milestones_url":"https://api.github.com/repos/cgranade/translators/milestones{/number}","notifications_url":"https://api.github.com/repos/cgranade/translators/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cgranade/translators/labels{/name}","releases_url":"https://api.github.com/repos/cgranade/translators/releases{/id}","created_at":"2015-09-01T06:43:57Z","updated_at":"2015-09-01T06:44:00Z","pushed_at":"2015-09-01T07:13:42Z","git_url":"git://github.com/cgranade/translators.git","ssh_url":"git@github.com:cgranade/translators.git","clone_url":"https://github.com/cgranade/translators.git","svn_url":"https://github.com/cgranade/translators","homepage":"http://www.zotero.org/support/dev/translators","size":17370,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zotero:master","ref":"master","sha":"13dd168b8a79deabc345b762c62d560af6180693","user":{"login":"zotero","id":891917,"avatar_url":"https://avatars.githubusercontent.com/u/891917?v=3","gravatar_id":"","url":"https://api.github.com/users/zotero","html_url":"https://github.com/zotero","followers_url":"https://api.github.com/users/zotero/followers","following_url":"https://api.github.com/users/zotero/following{/other_user}","gists_url":"https://api.github.com/users/zotero/gists{/gist_id}","starred_url":"https://api.github.com/users/zotero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zotero/subscriptions","organizations_url":"https://api.github.com/users/zotero/orgs","repos_url":"https://api.github.com/users/zotero/repos","events_url":"https://api.github.com/users/zotero/events{/privacy}","received_events_url":"https://api.github.com/users/zotero/received_events","type":"Organization","site_admin":false},"repo":{"id":1991863,"name":"translators","full_name":"zotero/translators","owner":{"login":"zotero","id":891917,"avatar_url":"https://avatars.githubusercontent.com/u/891917?v=3","gravatar_id":"","url":"https://api.github.com/users/zotero","html_url":"https://github.com/zotero","followers_url":"https://api.github.com/users/zotero/followers","following_url":"https://api.github.com/users/zotero/following{/other_user}","gists_url":"https://api.github.com/users/zotero/gists{/gist_id}","starred_url":"https://api.github.com/users/zotero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zotero/subscriptions","organizations_url":"https://api.github.com/users/zotero/orgs","repos_url":"https://api.github.com/users/zotero/repos","events_url":"https://api.github.com/users/zotero/events{/privacy}","received_events_url":"https://api.github.com/users/zotero/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zotero/translators","description":"Zotero Translators","fork":false,"url":"https://api.github.com/repos/zotero/translators","forks_url":"https://api.github.com/repos/zotero/translators/forks","keys_url":"https://api.github.com/repos/zotero/translators/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zotero/translators/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zotero/translators/teams","hooks_url":"https://api.github.com/repos/zotero/translators/hooks","issue_events_url":"https://api.github.com/repos/zotero/translators/issues/events{/number}","events_url":"https://api.github.com/repos/zotero/translators/events","assignees_url":"https://api.github.com/repos/zotero/translators/assignees{/user}","branches_url":"https://api.github.com/repos/zotero/translators/branches{/branch}","tags_url":"https://api.github.com/repos/zotero/translators/tags","blobs_url":"https://api.github.com/repos/zotero/translators/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zotero/translators/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zotero/translators/git/refs{/sha}","trees_url":"https://api.github.com/repos/zotero/translators/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zotero/translators/statuses/{sha}","languages_url":"https://api.github.com/repos/zotero/translators/languages","stargazers_url":"https://api.github.com/repos/zotero/translators/stargazers","contributors_url":"https://api.github.com/repos/zotero/translators/contributors","subscribers_url":"https://api.github.com/repos/zotero/translators/subscribers","subscription_url":"https://api.github.com/repos/zotero/translators/subscription","commits_url":"https://api.github.com/repos/zotero/translators/commits{/sha}","git_commits_url":"https://api.github.com/repos/zotero/translators/git/commits{/sha}","comments_url":"https://api.github.com/repos/zotero/translators/comments{/number}","issue_comment_url":"https://api.github.com/repos/zotero/translators/issues/comments{/number}","contents_url":"https://api.github.com/repos/zotero/translators/contents/{+path}","compare_url":"https://api.github.com/repos/zotero/translators/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zotero/translators/merges","archive_url":"https://api.github.com/repos/zotero/translators/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zotero/translators/downloads","issues_url":"https://api.github.com/repos/zotero/translators/issues{/number}","pulls_url":"https://api.github.com/repos/zotero/translators/pulls{/number}","milestones_url":"https://api.github.com/repos/zotero/translators/milestones{/number}","notifications_url":"https://api.github.com/repos/zotero/translators/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zotero/translators/labels{/name}","releases_url":"https://api.github.com/repos/zotero/translators/releases{/id}","created_at":"2011-07-03T17:40:38Z","updated_at":"2015-08-04T09:27:31Z","pushed_at":"2015-09-01T21:23:22Z","git_url":"git://github.com/zotero/translators.git","ssh_url":"git@github.com:zotero/translators.git","clone_url":"https://github.com/zotero/translators.git","svn_url":"https://github.com/zotero/translators","homepage":"http://www.zotero.org/support/dev/translators","size":17370,"stargazers_count":151,"watchers_count":151,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":136,"mirror_url":null,"open_issues_count":130,"forks":136,"open_issues":130,"watchers":151,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zotero/translators/pulls/941"},"html":{"href":"https://github.com/zotero/translators/pull/941"},"issue":{"href":"https://api.github.com/repos/zotero/translators/issues/941"},"comments":{"href":"https://api.github.com/repos/zotero/translators/issues/941/comments"},"review_comments":{"href":"https://api.github.com/repos/zotero/translators/pulls/941/comments"},"review_comment":{"href":"https://api.github.com/repos/zotero/translators/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zotero/translators/pulls/941/commits"},"statuses":{"href":"https://api.github.com/repos/zotero/translators/statuses/700460c5b24cd7d6214542d19d7c598143349125"}}}}