{"action":"closed","number":3,"pull_request":{"url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/pulls/3","id":19852364,"html_url":"https://github.com/ademaria/ubuntu-ec2net/pull/3","diff_url":"https://github.com/ademaria/ubuntu-ec2net/pull/3.diff","patch_url":"https://github.com/ademaria/ubuntu-ec2net/pull/3.patch","issue_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/issues/3","number":3,"state":"closed","locked":false,"title":"Finish porting script: shouldn't attempt action until after networking is up","user":{"login":"jcoleman","id":125331,"avatar_url":"https://avatars.githubusercontent.com/u/125331?v=3","gravatar_id":"","url":"https://api.github.com/users/jcoleman","html_url":"https://github.com/jcoleman","followers_url":"https://api.github.com/users/jcoleman/followers","following_url":"https://api.github.com/users/jcoleman/following{/other_user}","gists_url":"https://api.github.com/users/jcoleman/gists{/gist_id}","starred_url":"https://api.github.com/users/jcoleman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcoleman/subscriptions","organizations_url":"https://api.github.com/users/jcoleman/orgs","repos_url":"https://api.github.com/users/jcoleman/repos","events_url":"https://api.github.com/users/jcoleman/events{/privacy}","received_events_url":"https://api.github.com/users/jcoleman/received_events","type":"User","site_admin":false},"body":"The script relies on having networking available to access the instance metadata service, and so the script can't run until networking is up. The original AWS script (in Amazon Linux) exits the hot plug script early if init hasn't finished or the networking service isn't up yet. That part of the script was commented out in this port, but not having it causes instances to (sometimes, because of a race condition I assume) fail to bring up the loopback interface if this script is installed prior to boot (e.g., in a baked AMI.)\r\n\r\nI've updated the script to exit early if eth0 isn't up yet to solve this issue.","created_at":"2014-08-15T16:13:21Z","updated_at":"2015-01-21T17:18:22Z","closed_at":"2015-01-21T17:18:22Z","merged_at":"2015-01-21T17:18:22Z","merge_commit_sha":"12d39e8127d16b5471584ad654ed54571e29898a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/pulls/3/commits","review_comments_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/pulls/3/comments","review_comment_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/issues/3/comments","statuses_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/statuses/d3b6b6ec5ac9dda8378796cf3213ba804dc87a50","head":{"label":"jcoleman:master","ref":"master","sha":"d3b6b6ec5ac9dda8378796cf3213ba804dc87a50","user":{"login":"jcoleman","id":125331,"avatar_url":"https://avatars.githubusercontent.com/u/125331?v=3","gravatar_id":"","url":"https://api.github.com/users/jcoleman","html_url":"https://github.com/jcoleman","followers_url":"https://api.github.com/users/jcoleman/followers","following_url":"https://api.github.com/users/jcoleman/following{/other_user}","gists_url":"https://api.github.com/users/jcoleman/gists{/gist_id}","starred_url":"https://api.github.com/users/jcoleman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcoleman/subscriptions","organizations_url":"https://api.github.com/users/jcoleman/orgs","repos_url":"https://api.github.com/users/jcoleman/repos","events_url":"https://api.github.com/users/jcoleman/events{/privacy}","received_events_url":"https://api.github.com/users/jcoleman/received_events","type":"User","site_admin":false},"repo":{"id":22995131,"name":"ubuntu-ec2net","full_name":"jcoleman/ubuntu-ec2net","owner":{"login":"jcoleman","id":125331,"avatar_url":"https://avatars.githubusercontent.com/u/125331?v=3","gravatar_id":"","url":"https://api.github.com/users/jcoleman","html_url":"https://github.com/jcoleman","followers_url":"https://api.github.com/users/jcoleman/followers","following_url":"https://api.github.com/users/jcoleman/following{/other_user}","gists_url":"https://api.github.com/users/jcoleman/gists{/gist_id}","starred_url":"https://api.github.com/users/jcoleman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcoleman/subscriptions","organizations_url":"https://api.github.com/users/jcoleman/orgs","repos_url":"https://api.github.com/users/jcoleman/repos","events_url":"https://api.github.com/users/jcoleman/events{/privacy}","received_events_url":"https://api.github.com/users/jcoleman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jcoleman/ubuntu-ec2net","description":"port of Amazon ec2net to debian/ubuntu for automatically configuring AWS VPC interfaces","fork":true,"url":"https://api.github.com/repos/jcoleman/ubuntu-ec2net","forks_url":"https://api.github.com/repos/jcoleman/ubuntu-ec2net/forks","keys_url":"https://api.github.com/repos/jcoleman/ubuntu-ec2net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcoleman/ubuntu-ec2net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcoleman/ubuntu-ec2net/teams","hooks_url":"https://api.github.com/repos/jcoleman/ubuntu-ec2net/hooks","issue_events_url":"https://api.github.com/repos/jcoleman/ubuntu-ec2net/issues/events{/number}","events_url":"https://api.github.com/repos/jcoleman/ubuntu-ec2net/events","assignees_url":"https://api.github.com/repos/jcoleman/ubuntu-ec2net/assignees{/user}","branches_url":"https://api.github.com/repos/jcoleman/ubuntu-ec2net/branches{/branch}","tags_url":"https://api.github.com/repos/jcoleman/ubuntu-ec2net/tags","blobs_url":"https://api.github.com/repos/jcoleman/ubuntu-ec2net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcoleman/ubuntu-ec2net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcoleman/ubuntu-ec2net/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcoleman/ubuntu-ec2net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcoleman/ubuntu-ec2net/statuses/{sha}","languages_url":"https://api.github.com/repos/jcoleman/ubuntu-ec2net/languages","stargazers_url":"https://api.github.com/repos/jcoleman/ubuntu-ec2net/stargazers","contributors_url":"https://api.github.com/repos/jcoleman/ubuntu-ec2net/contributors","subscribers_url":"https://api.github.com/repos/jcoleman/ubuntu-ec2net/subscribers","subscription_url":"https://api.github.com/repos/jcoleman/ubuntu-ec2net/subscription","commits_url":"https://api.github.com/repos/jcoleman/ubuntu-ec2net/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcoleman/ubuntu-ec2net/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcoleman/ubuntu-ec2net/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcoleman/ubuntu-ec2net/issues/comments/{number}","contents_url":"https://api.github.com/repos/jcoleman/ubuntu-ec2net/contents/{+path}","compare_url":"https://api.github.com/repos/jcoleman/ubuntu-ec2net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcoleman/ubuntu-ec2net/merges","archive_url":"https://api.github.com/repos/jcoleman/ubuntu-ec2net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcoleman/ubuntu-ec2net/downloads","issues_url":"https://api.github.com/repos/jcoleman/ubuntu-ec2net/issues{/number}","pulls_url":"https://api.github.com/repos/jcoleman/ubuntu-ec2net/pulls{/number}","milestones_url":"https://api.github.com/repos/jcoleman/ubuntu-ec2net/milestones{/number}","notifications_url":"https://api.github.com/repos/jcoleman/ubuntu-ec2net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcoleman/ubuntu-ec2net/labels{/name}","releases_url":"https://api.github.com/repos/jcoleman/ubuntu-ec2net/releases{/id}","created_at":"2014-08-15T16:08:46Z","updated_at":"2014-08-13T12:15:49Z","pushed_at":"2014-08-15T16:10:32Z","git_url":"git://github.com/jcoleman/ubuntu-ec2net.git","ssh_url":"git@github.com:jcoleman/ubuntu-ec2net.git","clone_url":"https://github.com/jcoleman/ubuntu-ec2net.git","svn_url":"https://github.com/jcoleman/ubuntu-ec2net","homepage":null,"size":121,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ademaria:master","ref":"master","sha":"105e57404a6b5b3cfc2f3d1f8544cfd23d73c2d8","user":{"login":"ademaria","id":5128627,"avatar_url":"https://avatars.githubusercontent.com/u/5128627?v=3","gravatar_id":"","url":"https://api.github.com/users/ademaria","html_url":"https://github.com/ademaria","followers_url":"https://api.github.com/users/ademaria/followers","following_url":"https://api.github.com/users/ademaria/following{/other_user}","gists_url":"https://api.github.com/users/ademaria/gists{/gist_id}","starred_url":"https://api.github.com/users/ademaria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ademaria/subscriptions","organizations_url":"https://api.github.com/users/ademaria/orgs","repos_url":"https://api.github.com/users/ademaria/repos","events_url":"https://api.github.com/users/ademaria/events{/privacy}","received_events_url":"https://api.github.com/users/ademaria/received_events","type":"User","site_admin":false},"repo":{"id":15025953,"name":"ubuntu-ec2net","full_name":"ademaria/ubuntu-ec2net","owner":{"login":"ademaria","id":5128627,"avatar_url":"https://avatars.githubusercontent.com/u/5128627?v=3","gravatar_id":"","url":"https://api.github.com/users/ademaria","html_url":"https://github.com/ademaria","followers_url":"https://api.github.com/users/ademaria/followers","following_url":"https://api.github.com/users/ademaria/following{/other_user}","gists_url":"https://api.github.com/users/ademaria/gists{/gist_id}","starred_url":"https://api.github.com/users/ademaria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ademaria/subscriptions","organizations_url":"https://api.github.com/users/ademaria/orgs","repos_url":"https://api.github.com/users/ademaria/repos","events_url":"https://api.github.com/users/ademaria/events{/privacy}","received_events_url":"https://api.github.com/users/ademaria/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ademaria/ubuntu-ec2net","description":"port of Amazon ec2net to debian/ubuntu for automatically configuring AWS VPC interfaces","fork":false,"url":"https://api.github.com/repos/ademaria/ubuntu-ec2net","forks_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/forks","keys_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/teams","hooks_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/hooks","issue_events_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/issues/events{/number}","events_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/events","assignees_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/assignees{/user}","branches_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/branches{/branch}","tags_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/tags","blobs_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/git/refs{/sha}","trees_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/statuses/{sha}","languages_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/languages","stargazers_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/stargazers","contributors_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/contributors","subscribers_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/subscribers","subscription_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/subscription","commits_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/commits{/sha}","git_commits_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/git/commits{/sha}","comments_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/comments{/number}","issue_comment_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/issues/comments/{number}","contents_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/contents/{+path}","compare_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/merges","archive_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/downloads","issues_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/issues{/number}","pulls_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/pulls{/number}","milestones_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/milestones{/number}","notifications_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/labels{/name}","releases_url":"https://api.github.com/repos/ademaria/ubuntu-ec2net/releases{/id}","created_at":"2013-12-08T15:29:36Z","updated_at":"2014-12-03T05:41:25Z","pushed_at":"2015-01-21T17:18:22Z","git_url":"git://github.com/ademaria/ubuntu-ec2net.git","ssh_url":"git@github.com:ademaria/ubuntu-ec2net.git","clone_url":"https://github.com/ademaria/ubuntu-ec2net.git","svn_url":"https://github.com/ademaria/ubuntu-ec2net","homepage":null,"size":187,"stargazers_count":17,"watchers_count":17,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":4,"forks":9,"open_issues":4,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ademaria/ubuntu-ec2net/pulls/3"},"html":{"href":"https://github.com/ademaria/ubuntu-ec2net/pull/3"},"issue":{"href":"https://api.github.com/repos/ademaria/ubuntu-ec2net/issues/3"},"comments":{"href":"https://api.github.com/repos/ademaria/ubuntu-ec2net/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/ademaria/ubuntu-ec2net/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/ademaria/ubuntu-ec2net/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ademaria/ubuntu-ec2net/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/ademaria/ubuntu-ec2net/statuses/d3b6b6ec5ac9dda8378796cf3213ba804dc87a50"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ademaria","id":5128627,"avatar_url":"https://avatars.githubusercontent.com/u/5128627?v=3","gravatar_id":"","url":"https://api.github.com/users/ademaria","html_url":"https://github.com/ademaria","followers_url":"https://api.github.com/users/ademaria/followers","following_url":"https://api.github.com/users/ademaria/following{/other_user}","gists_url":"https://api.github.com/users/ademaria/gists{/gist_id}","starred_url":"https://api.github.com/users/ademaria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ademaria/subscriptions","organizations_url":"https://api.github.com/users/ademaria/orgs","repos_url":"https://api.github.com/users/ademaria/repos","events_url":"https://api.github.com/users/ademaria/events{/privacy}","received_events_url":"https://api.github.com/users/ademaria/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":5,"deletions":7,"changed_files":1}}