{"action":"created","issue":{"url":"https://api.github.com/repos/cuba-rb/cuba/issues/2","labels_url":"https://api.github.com/repos/cuba-rb/cuba/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/cuba-rb/cuba/issues/2/comments","events_url":"https://api.github.com/repos/cuba-rb/cuba/issues/2/events","html_url":"https://github.com/cuba-rb/cuba/pull/2","id":121128553,"number":2,"title":"Add Cuba::Test and remove rack-test integration.","user":{"login":"frodsan","id":840464,"avatar_url":"https://avatars.githubusercontent.com/u/840464?v=3","gravatar_id":"","url":"https://api.github.com/users/frodsan","html_url":"https://github.com/frodsan","followers_url":"https://api.github.com/users/frodsan/followers","following_url":"https://api.github.com/users/frodsan/following{/other_user}","gists_url":"https://api.github.com/users/frodsan/gists{/gist_id}","starred_url":"https://api.github.com/users/frodsan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frodsan/subscriptions","organizations_url":"https://api.github.com/users/frodsan/orgs","repos_url":"https://api.github.com/users/frodsan/repos","events_url":"https://api.github.com/users/frodsan/events{/privacy}","received_events_url":"https://api.github.com/users/frodsan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-12-08T23:56:00Z","updated_at":"2015-12-10T15:00:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cuba-rb/cuba/pulls/2","html_url":"https://github.com/cuba-rb/cuba/pull/2","diff_url":"https://github.com/cuba-rb/cuba/pull/2.diff","patch_url":"https://github.com/cuba-rb/cuba/pull/2.patch"},"body":"I think we should avoid dependencies if it is possible. This removes rack-test/cutest dependency and instead adds a helper class to simulate requests called Cuba::Test. It follows the same pattern I found in Syro's tests.\r\n\r\nCuba::Test is test-framework agnostic. We can use this class to test Cuba's code.\r\n\r\nOf course, users can use rack-test or capybara. They are easy to set up anyway.\r\n\r\nDo you think we should extract the old behaviour and put it in a gem?\r\n\r\nPD: I haven't removed rack-test dependency from the project, because we are using it in some tests. I would change that when this PR gets merged."},"comment":{"url":"https://api.github.com/repos/cuba-rb/cuba/issues/comments/163651215","html_url":"https://github.com/cuba-rb/cuba/pull/2#issuecomment-163651215","issue_url":"https://api.github.com/repos/cuba-rb/cuba/issues/2","id":163651215,"user":{"login":"frodsan","id":840464,"avatar_url":"https://avatars.githubusercontent.com/u/840464?v=3","gravatar_id":"","url":"https://api.github.com/users/frodsan","html_url":"https://github.com/frodsan","followers_url":"https://api.github.com/users/frodsan/followers","following_url":"https://api.github.com/users/frodsan/following{/other_user}","gists_url":"https://api.github.com/users/frodsan/gists{/gist_id}","starred_url":"https://api.github.com/users/frodsan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frodsan/subscriptions","organizations_url":"https://api.github.com/users/frodsan/orgs","repos_url":"https://api.github.com/users/frodsan/repos","events_url":"https://api.github.com/users/frodsan/events{/privacy}","received_events_url":"https://api.github.com/users/frodsan/received_events","type":"User","site_admin":false},"created_at":"2015-12-10T15:00:41Z","updated_at":"2015-12-10T15:00:41Z","body":"@soveran I rebased the PR."}}