{"action":"created","issue":{"url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/3725","labels_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/3725/labels{/name}","comments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/3725/comments","events_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/3725/events","html_url":"https://github.com/ets-berkeley-edu/calcentral/pull/3725","id":73475211,"number":3725,"title":"CLC-5203 Revert to old View As UX, keeping back-end storage","user":{"login":"paulkerschen","id":2413467,"avatar_url":"https://avatars.githubusercontent.com/u/2413467?v=3","gravatar_id":"","url":"https://api.github.com/users/paulkerschen","html_url":"https://github.com/paulkerschen","followers_url":"https://api.github.com/users/paulkerschen/followers","following_url":"https://api.github.com/users/paulkerschen/following{/other_user}","gists_url":"https://api.github.com/users/paulkerschen/gists{/gist_id}","starred_url":"https://api.github.com/users/paulkerschen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulkerschen/subscriptions","organizations_url":"https://api.github.com/users/paulkerschen/orgs","repos_url":"https://api.github.com/users/paulkerschen/repos","events_url":"https://api.github.com/users/paulkerschen/events{/privacy}","received_events_url":"https://api.github.com/users/paulkerschen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-06T00:39:54Z","updated_at":"2015-05-06T17:33:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/3725","html_url":"https://github.com/ets-berkeley-edu/calcentral/pull/3725","diff_url":"https://github.com/ets-berkeley-edu/calcentral/pull/3725.diff","patch_url":"https://github.com/ets-berkeley-edu/calcentral/pull/3725.patch"},"body":"https://jira.ets.berkeley.edu/jira/browse/CLC-5203\r\n\r\nThis PR attempts the minimum to get the old View As UX working with the new database approach.\r\n  - The template is almost entirely reverted to the pre-#3544 settings.html. (One change: the duplicate \"Stop Acting As\" button first noted in CLC-3506 is no longer present.)\r\n  - The pre-#3544 adminController.js and the post-#3544 studentLookupController.js are stitched together into a single admin controller.\r\n  - \"Clear all users\" API endpoints are added, as the old UX requires.\r\n  - Unused front-end code is removed.\r\n  - Saving a user now removes them from the Recent Users list. Duplication between two lists was no big deal in the tabbed UI, but it looks distinctly odd when both lists are visible.\r\n  - Verbose logging in the stored-user models is removed.\r\n\r\nThere are couple of issues that should be addressed as follow-up tasks.\r\n  - Code duplication in the server-side controller, model and tests.\r\n  - While users can now manually clear the Recent Users list, the issue noted in CLC-5157 (no automatic limit to list size) remains.\r\n\r\nI've removed large chunks of code committed in #3544, but of course that implies no disrespect for the work done there. I needed to revert as comprehensively as possible to be sure that I wasn't relying on any hidden dependencies, but I expect that whoever next works on View As will want to revert most of this commit in turn, and take it from there."},"comment":{"url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/comments/99545690","html_url":"https://github.com/ets-berkeley-edu/calcentral/pull/3725#issuecomment-99545690","issue_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/3725","id":99545690,"user":{"login":"christianv","id":127199,"avatar_url":"https://avatars.githubusercontent.com/u/127199?v=3","gravatar_id":"","url":"https://api.github.com/users/christianv","html_url":"https://github.com/christianv","followers_url":"https://api.github.com/users/christianv/followers","following_url":"https://api.github.com/users/christianv/following{/other_user}","gists_url":"https://api.github.com/users/christianv/gists{/gist_id}","starred_url":"https://api.github.com/users/christianv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christianv/subscriptions","organizations_url":"https://api.github.com/users/christianv/orgs","repos_url":"https://api.github.com/users/christianv/repos","events_url":"https://api.github.com/users/christianv/events{/privacy}","received_events_url":"https://api.github.com/users/christianv/received_events","type":"User","site_admin":false},"created_at":"2015-05-06T17:33:34Z","updated_at":"2015-05-06T17:33:34Z","body":"front-end lgtm - would be good to also have a back-end review\r\n/cc @ctweney @redconfetti @raydavis "}}