{"action":"created","issue":{"url":"https://api.github.com/repos/SmokinCaterpillar/pypet/issues/16","labels_url":"https://api.github.com/repos/SmokinCaterpillar/pypet/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/SmokinCaterpillar/pypet/issues/16/comments","events_url":"https://api.github.com/repos/SmokinCaterpillar/pypet/issues/16/events","html_url":"https://github.com/SmokinCaterpillar/pypet/issues/16","id":69143737,"number":16,"title":"log_folder=None not working any more in 0.1b.10","user":{"login":"wulmer","id":1672353,"avatar_url":"https://avatars.githubusercontent.com/u/1672353?v=3","gravatar_id":"","url":"https://api.github.com/users/wulmer","html_url":"https://github.com/wulmer","followers_url":"https://api.github.com/users/wulmer/followers","following_url":"https://api.github.com/users/wulmer/following{/other_user}","gists_url":"https://api.github.com/users/wulmer/gists{/gist_id}","starred_url":"https://api.github.com/users/wulmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wulmer/subscriptions","organizations_url":"https://api.github.com/users/wulmer/orgs","repos_url":"https://api.github.com/users/wulmer/repos","events_url":"https://api.github.com/users/wulmer/events{/privacy}","received_events_url":"https://api.github.com/users/wulmer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-04-17T13:54:47Z","updated_at":"2015-04-22T20:19:12Z","closed_at":null,"body":"Hi,\r\nI just upgraded from 0.1b.9 to the new release 0.1b.10 and most things smoothly upgraded. There was a minor issue with the logging config. In [0.1b.9](http://pypet.readthedocs.org/en/0.1b.9/pypetdoc/environmentdoc.html#pypet.environment.Environment) it was possible to specify `log_folder=None` in the `Environment` constructor, whereas this option has vanished in [0.1b.10](http://pypet.readthedocs.org/en/0.1b.10/pypetdoc/environmentdoc.html#pypet.environment.Environment).\r\nUsing `log_folder=None` in 0.1b.10 raises an error in `pypetlogging.py`:\r\n\r\n    File \"c:\\home\\hub\\uq\\venv\\lib\\site-packages\\pypet\\pypetlogging.py\", line 125, in _change_logging_kwargs\r\n        handler_dict['filename'] = os.path.join(log_folder, handler_dict['filename'])\r\n\r\nbecause the `log_folder` is None.\r\nIs there another way to disable logging in `0.1b.10` or could the old behavior be restored? \r\nIn the latter case, I can try to submit a patch for this, but I want to clarify first which behavior is the right one.\r\n\r\nRegards.\r\nWolfgang"},"comment":{"url":"https://api.github.com/repos/SmokinCaterpillar/pypet/issues/comments/95324226","html_url":"https://github.com/SmokinCaterpillar/pypet/issues/16#issuecomment-95324226","issue_url":"https://api.github.com/repos/SmokinCaterpillar/pypet/issues/16","id":95324226,"user":{"login":"wulmer","id":1672353,"avatar_url":"https://avatars.githubusercontent.com/u/1672353?v=3","gravatar_id":"","url":"https://api.github.com/users/wulmer","html_url":"https://github.com/wulmer","followers_url":"https://api.github.com/users/wulmer/followers","following_url":"https://api.github.com/users/wulmer/following{/other_user}","gists_url":"https://api.github.com/users/wulmer/gists{/gist_id}","starred_url":"https://api.github.com/users/wulmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wulmer/subscriptions","organizations_url":"https://api.github.com/users/wulmer/orgs","repos_url":"https://api.github.com/users/wulmer/repos","events_url":"https://api.github.com/users/wulmer/events{/privacy}","received_events_url":"https://api.github.com/users/wulmer/received_events","type":"User","site_admin":false},"created_at":"2015-04-22T20:19:12Z","updated_at":"2015-04-22T20:19:12Z","body":"The only misunderstanding I had with the current documentation was that it did not specify how to disable logging using the *old* arguments. Especially the fact that we mixed old and new style arguments messed up the logging configuration.\r\n\r\nYour planned fix for the next version where either `log_config` or the other arguments can be used (and not together) will make this clear (at least when executing the code).\r\n\r\nBTW: Is it really necessary to have different logging INI files for Windows and Linux (i.e., `default.ini` and `windows_default.ini`)? The only difference I can see between them is the use of `\\\\` vs. `/`. In my experience, Python is quite capable of dealing with this difference so I expect the Windows version to accept logging config paths with `/` instead of `\\\\`. If you cannot try this on a Windows machine, I can test it for you."}}