{"action":"created","comment":{"url":"https://api.github.com/repos/nengo/nengo_viz/pulls/comments/31491625","id":31491625,"diff_hunk":"@@ -211,7 +213,7 @@ def handle_ws_request(self, args, db):\n         else:\n             command = 'ws_%s' % args[0]\n \n-        client = ClientSocket(self.request, '')\n+        client = self.server.create_websocket(self.request)","path":"nengo_viz/swi.py","position":15,"original_position":15,"commit_id":"e7181ff811a74638a4fee048c4cf4de92686f0b8","original_commit_id":"e7181ff811a74638a4fee048c4cf4de92686f0b8","user":{"login":"jgosmann","id":850157,"avatar_url":"https://avatars.githubusercontent.com/u/850157?v=3","gravatar_id":"","url":"https://api.github.com/users/jgosmann","html_url":"https://github.com/jgosmann","followers_url":"https://api.github.com/users/jgosmann/followers","following_url":"https://api.github.com/users/jgosmann/following{/other_user}","gists_url":"https://api.github.com/users/jgosmann/gists{/gist_id}","starred_url":"https://api.github.com/users/jgosmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgosmann/subscriptions","organizations_url":"https://api.github.com/users/jgosmann/orgs","repos_url":"https://api.github.com/users/jgosmann/repos","events_url":"https://api.github.com/users/jgosmann/events{/privacy}","received_events_url":"https://api.github.com/users/jgosmann/received_events","type":"User","site_admin":false},"body":"`BaseHTTPRequestHandler`","created_at":"2015-06-02T03:59:10Z","updated_at":"2015-06-02T03:59:10Z","html_url":"https://github.com/nengo/nengo_viz/pull/263#discussion_r31491625","pull_request_url":"https://api.github.com/repos/nengo/nengo_viz/pulls/263","_links":{"self":{"href":"https://api.github.com/repos/nengo/nengo_viz/pulls/comments/31491625"},"html":{"href":"https://github.com/nengo/nengo_viz/pull/263#discussion_r31491625"},"pull_request":{"href":"https://api.github.com/repos/nengo/nengo_viz/pulls/263"}}},"pull_request":{"url":"https://api.github.com/repos/nengo/nengo_viz/pulls/263","id":36672694,"html_url":"https://github.com/nengo/nengo_viz/pull/263","diff_url":"https://github.com/nengo/nengo_viz/pull/263.diff","patch_url":"https://github.com/nengo/nengo_viz/pull/263.patch","issue_url":"https://api.github.com/repos/nengo/nengo_viz/issues/263","number":263,"state":"open","locked":false,"title":"Properly close websockets on server shutdown.","user":{"login":"jgosmann","id":850157,"avatar_url":"https://avatars.githubusercontent.com/u/850157?v=3","gravatar_id":"","url":"https://api.github.com/users/jgosmann","html_url":"https://github.com/jgosmann","followers_url":"https://api.github.com/users/jgosmann/followers","following_url":"https://api.github.com/users/jgosmann/following{/other_user}","gists_url":"https://api.github.com/users/jgosmann/gists{/gist_id}","starred_url":"https://api.github.com/users/jgosmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgosmann/subscriptions","organizations_url":"https://api.github.com/users/jgosmann/orgs","repos_url":"https://api.github.com/users/jgosmann/repos","events_url":"https://api.github.com/users/jgosmann/events{/privacy}","received_events_url":"https://api.github.com/users/jgosmann/received_events","type":"User","site_admin":false},"body":"Fixes #222.\r\n\r\nI think, with this PR all websocket connections are always properly closed no matter which side initiates the close. Because of the organization of the server code, this patch is not as straight-forward as I'd like it to be. In fact, the organization of the server code seems a bit convoluted without a good separation of concerns. But refactoring it would be a slightly larger job. It might be complicated by the base Python classes which probably where to designed with prolonged connections (websockets) in mind.","created_at":"2015-06-01T21:26:10Z","updated_at":"2015-06-02T03:59:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a7b6bfabf04f6c61a3e03ecfa2babb2acfbbe37","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nengo/nengo_viz/pulls/263/commits","review_comments_url":"https://api.github.com/repos/nengo/nengo_viz/pulls/263/comments","review_comment_url":"https://api.github.com/repos/nengo/nengo_viz/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nengo/nengo_viz/issues/263/comments","statuses_url":"https://api.github.com/repos/nengo/nengo_viz/statuses/e7181ff811a74638a4fee048c4cf4de92686f0b8","head":{"label":"nengo:closing-handshake","ref":"closing-handshake","sha":"e7181ff811a74638a4fee048c4cf4de92686f0b8","user":{"login":"nengo","id":9197486,"avatar_url":"https://avatars.githubusercontent.com/u/9197486?v=3","gravatar_id":"","url":"https://api.github.com/users/nengo","html_url":"https://github.com/nengo","followers_url":"https://api.github.com/users/nengo/followers","following_url":"https://api.github.com/users/nengo/following{/other_user}","gists_url":"https://api.github.com/users/nengo/gists{/gist_id}","starred_url":"https://api.github.com/users/nengo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nengo/subscriptions","organizations_url":"https://api.github.com/users/nengo/orgs","repos_url":"https://api.github.com/users/nengo/repos","events_url":"https://api.github.com/users/nengo/events{/privacy}","received_events_url":"https://api.github.com/users/nengo/received_events","type":"Organization","site_admin":false},"repo":{"id":28949681,"name":"nengo_viz","full_name":"nengo/nengo_viz","owner":{"login":"nengo","id":9197486,"avatar_url":"https://avatars.githubusercontent.com/u/9197486?v=3","gravatar_id":"","url":"https://api.github.com/users/nengo","html_url":"https://github.com/nengo","followers_url":"https://api.github.com/users/nengo/followers","following_url":"https://api.github.com/users/nengo/following{/other_user}","gists_url":"https://api.github.com/users/nengo/gists{/gist_id}","starred_url":"https://api.github.com/users/nengo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nengo/subscriptions","organizations_url":"https://api.github.com/users/nengo/orgs","repos_url":"https://api.github.com/users/nengo/repos","events_url":"https://api.github.com/users/nengo/events{/privacy}","received_events_url":"https://api.github.com/users/nengo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nengo/nengo_viz","description":"Nengo interactive visualizer","fork":false,"url":"https://api.github.com/repos/nengo/nengo_viz","forks_url":"https://api.github.com/repos/nengo/nengo_viz/forks","keys_url":"https://api.github.com/repos/nengo/nengo_viz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nengo/nengo_viz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nengo/nengo_viz/teams","hooks_url":"https://api.github.com/repos/nengo/nengo_viz/hooks","issue_events_url":"https://api.github.com/repos/nengo/nengo_viz/issues/events{/number}","events_url":"https://api.github.com/repos/nengo/nengo_viz/events","assignees_url":"https://api.github.com/repos/nengo/nengo_viz/assignees{/user}","branches_url":"https://api.github.com/repos/nengo/nengo_viz/branches{/branch}","tags_url":"https://api.github.com/repos/nengo/nengo_viz/tags","blobs_url":"https://api.github.com/repos/nengo/nengo_viz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nengo/nengo_viz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nengo/nengo_viz/git/refs{/sha}","trees_url":"https://api.github.com/repos/nengo/nengo_viz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nengo/nengo_viz/statuses/{sha}","languages_url":"https://api.github.com/repos/nengo/nengo_viz/languages","stargazers_url":"https://api.github.com/repos/nengo/nengo_viz/stargazers","contributors_url":"https://api.github.com/repos/nengo/nengo_viz/contributors","subscribers_url":"https://api.github.com/repos/nengo/nengo_viz/subscribers","subscription_url":"https://api.github.com/repos/nengo/nengo_viz/subscription","commits_url":"https://api.github.com/repos/nengo/nengo_viz/commits{/sha}","git_commits_url":"https://api.github.com/repos/nengo/nengo_viz/git/commits{/sha}","comments_url":"https://api.github.com/repos/nengo/nengo_viz/comments{/number}","issue_comment_url":"https://api.github.com/repos/nengo/nengo_viz/issues/comments{/number}","contents_url":"https://api.github.com/repos/nengo/nengo_viz/contents/{+path}","compare_url":"https://api.github.com/repos/nengo/nengo_viz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nengo/nengo_viz/merges","archive_url":"https://api.github.com/repos/nengo/nengo_viz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nengo/nengo_viz/downloads","issues_url":"https://api.github.com/repos/nengo/nengo_viz/issues{/number}","pulls_url":"https://api.github.com/repos/nengo/nengo_viz/pulls{/number}","milestones_url":"https://api.github.com/repos/nengo/nengo_viz/milestones{/number}","notifications_url":"https://api.github.com/repos/nengo/nengo_viz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nengo/nengo_viz/labels{/name}","releases_url":"https://api.github.com/repos/nengo/nengo_viz/releases{/id}","created_at":"2015-01-08T05:00:06Z","updated_at":"2015-05-31T22:38:41Z","pushed_at":"2015-06-02T01:16:36Z","git_url":"git://github.com/nengo/nengo_viz.git","ssh_url":"git@github.com:nengo/nengo_viz.git","clone_url":"https://github.com/nengo/nengo_viz.git","svn_url":"https://github.com/nengo/nengo_viz","homepage":"","size":8289,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":87,"forks":1,"open_issues":87,"watchers":5,"default_branch":"master"}},"base":{"label":"nengo:master","ref":"master","sha":"31caa433b504c71430bcf2b5c79a9dce0211e927","user":{"login":"nengo","id":9197486,"avatar_url":"https://avatars.githubusercontent.com/u/9197486?v=3","gravatar_id":"","url":"https://api.github.com/users/nengo","html_url":"https://github.com/nengo","followers_url":"https://api.github.com/users/nengo/followers","following_url":"https://api.github.com/users/nengo/following{/other_user}","gists_url":"https://api.github.com/users/nengo/gists{/gist_id}","starred_url":"https://api.github.com/users/nengo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nengo/subscriptions","organizations_url":"https://api.github.com/users/nengo/orgs","repos_url":"https://api.github.com/users/nengo/repos","events_url":"https://api.github.com/users/nengo/events{/privacy}","received_events_url":"https://api.github.com/users/nengo/received_events","type":"Organization","site_admin":false},"repo":{"id":28949681,"name":"nengo_viz","full_name":"nengo/nengo_viz","owner":{"login":"nengo","id":9197486,"avatar_url":"https://avatars.githubusercontent.com/u/9197486?v=3","gravatar_id":"","url":"https://api.github.com/users/nengo","html_url":"https://github.com/nengo","followers_url":"https://api.github.com/users/nengo/followers","following_url":"https://api.github.com/users/nengo/following{/other_user}","gists_url":"https://api.github.com/users/nengo/gists{/gist_id}","starred_url":"https://api.github.com/users/nengo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nengo/subscriptions","organizations_url":"https://api.github.com/users/nengo/orgs","repos_url":"https://api.github.com/users/nengo/repos","events_url":"https://api.github.com/users/nengo/events{/privacy}","received_events_url":"https://api.github.com/users/nengo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nengo/nengo_viz","description":"Nengo interactive visualizer","fork":false,"url":"https://api.github.com/repos/nengo/nengo_viz","forks_url":"https://api.github.com/repos/nengo/nengo_viz/forks","keys_url":"https://api.github.com/repos/nengo/nengo_viz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nengo/nengo_viz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nengo/nengo_viz/teams","hooks_url":"https://api.github.com/repos/nengo/nengo_viz/hooks","issue_events_url":"https://api.github.com/repos/nengo/nengo_viz/issues/events{/number}","events_url":"https://api.github.com/repos/nengo/nengo_viz/events","assignees_url":"https://api.github.com/repos/nengo/nengo_viz/assignees{/user}","branches_url":"https://api.github.com/repos/nengo/nengo_viz/branches{/branch}","tags_url":"https://api.github.com/repos/nengo/nengo_viz/tags","blobs_url":"https://api.github.com/repos/nengo/nengo_viz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nengo/nengo_viz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nengo/nengo_viz/git/refs{/sha}","trees_url":"https://api.github.com/repos/nengo/nengo_viz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nengo/nengo_viz/statuses/{sha}","languages_url":"https://api.github.com/repos/nengo/nengo_viz/languages","stargazers_url":"https://api.github.com/repos/nengo/nengo_viz/stargazers","contributors_url":"https://api.github.com/repos/nengo/nengo_viz/contributors","subscribers_url":"https://api.github.com/repos/nengo/nengo_viz/subscribers","subscription_url":"https://api.github.com/repos/nengo/nengo_viz/subscription","commits_url":"https://api.github.com/repos/nengo/nengo_viz/commits{/sha}","git_commits_url":"https://api.github.com/repos/nengo/nengo_viz/git/commits{/sha}","comments_url":"https://api.github.com/repos/nengo/nengo_viz/comments{/number}","issue_comment_url":"https://api.github.com/repos/nengo/nengo_viz/issues/comments{/number}","contents_url":"https://api.github.com/repos/nengo/nengo_viz/contents/{+path}","compare_url":"https://api.github.com/repos/nengo/nengo_viz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nengo/nengo_viz/merges","archive_url":"https://api.github.com/repos/nengo/nengo_viz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nengo/nengo_viz/downloads","issues_url":"https://api.github.com/repos/nengo/nengo_viz/issues{/number}","pulls_url":"https://api.github.com/repos/nengo/nengo_viz/pulls{/number}","milestones_url":"https://api.github.com/repos/nengo/nengo_viz/milestones{/number}","notifications_url":"https://api.github.com/repos/nengo/nengo_viz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nengo/nengo_viz/labels{/name}","releases_url":"https://api.github.com/repos/nengo/nengo_viz/releases{/id}","created_at":"2015-01-08T05:00:06Z","updated_at":"2015-05-31T22:38:41Z","pushed_at":"2015-06-02T01:16:36Z","git_url":"git://github.com/nengo/nengo_viz.git","ssh_url":"git@github.com:nengo/nengo_viz.git","clone_url":"https://github.com/nengo/nengo_viz.git","svn_url":"https://github.com/nengo/nengo_viz","homepage":"","size":8289,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":87,"forks":1,"open_issues":87,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nengo/nengo_viz/pulls/263"},"html":{"href":"https://github.com/nengo/nengo_viz/pull/263"},"issue":{"href":"https://api.github.com/repos/nengo/nengo_viz/issues/263"},"comments":{"href":"https://api.github.com/repos/nengo/nengo_viz/issues/263/comments"},"review_comments":{"href":"https://api.github.com/repos/nengo/nengo_viz/pulls/263/comments"},"review_comment":{"href":"https://api.github.com/repos/nengo/nengo_viz/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nengo/nengo_viz/pulls/263/commits"},"statuses":{"href":"https://api.github.com/repos/nengo/nengo_viz/statuses/e7181ff811a74638a4fee048c4cf4de92686f0b8"}}}}