{"action":"created","comment":{"url":"https://api.github.com/repos/aodn/ncdfgenerator/pulls/comments/28941736","id":28941736,"diff_hunk":"@@ -189,6 +191,17 @@ public void populateValues(\n \t\tResultSetMetaData m = rs.getMetaData();\n \t\tint numColumns = m.getColumnCount();\n \n+\n+\t\t// organize dimensions by name\n+\t\tMap< String, IDimension> dimensionsMap = new HashMap< String, IDimension> (); \n+\t\tfor( IDimension dimension : dimensions ) \n+\t\t\tdimensionsMap.put( dimension.getName(), dimension );\n+\n+\t\t// organize variables by name\n+\t\tMap< String, IVariableEncoder> encodersMap = new HashMap< String, IVariableEncoder> (); ","path":"src/main/java/au/org/emii/ncdfgenerator/NcdfEncoder.java","position":113,"original_position":113,"commit_id":"09e267a4c89d8ac5aa4f84061e6b3ef07b737edc","original_commit_id":"09e267a4c89d8ac5aa4f84061e6b3ef07b737edc","user":{"login":"jonescc","id":1860215,"avatar_url":"https://avatars.githubusercontent.com/u/1860215?v=3","gravatar_id":"","url":"https://api.github.com/users/jonescc","html_url":"https://github.com/jonescc","followers_url":"https://api.github.com/users/jonescc/followers","following_url":"https://api.github.com/users/jonescc/following{/other_user}","gists_url":"https://api.github.com/users/jonescc/gists{/gist_id}","starred_url":"https://api.github.com/users/jonescc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonescc/subscriptions","organizations_url":"https://api.github.com/users/jonescc/orgs","repos_url":"https://api.github.com/users/jonescc/repos","events_url":"https://api.github.com/users/jonescc/events{/privacy}","received_events_url":"https://api.github.com/users/jonescc/received_events","type":"User","site_admin":false},"body":"I think renaming encoders to variables above made the code much more readable - perhaps consider doing the same here?  ","created_at":"2015-04-23T07:34:42Z","updated_at":"2015-04-23T07:34:42Z","html_url":"https://github.com/aodn/ncdfgenerator/pull/20#discussion_r28941736","pull_request_url":"https://api.github.com/repos/aodn/ncdfgenerator/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/aodn/ncdfgenerator/pulls/comments/28941736"},"html":{"href":"https://github.com/aodn/ncdfgenerator/pull/20#discussion_r28941736"},"pull_request":{"href":"https://api.github.com/repos/aodn/ncdfgenerator/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/aodn/ncdfgenerator/pulls/20","id":33924563,"html_url":"https://github.com/aodn/ncdfgenerator/pull/20","diff_url":"https://github.com/aodn/ncdfgenerator/pull/20.diff","patch_url":"https://github.com/aodn/ncdfgenerator/pull/20.patch","issue_url":"https://api.github.com/repos/aodn/ncdfgenerator/issues/20","number":20,"state":"open","locked":false,"title":"use lists for dimensions and attributes to preserve ordering","user":{"login":"julian1","id":4312379,"avatar_url":"https://avatars.githubusercontent.com/u/4312379?v=3","gravatar_id":"","url":"https://api.github.com/users/julian1","html_url":"https://github.com/julian1","followers_url":"https://api.github.com/users/julian1/followers","following_url":"https://api.github.com/users/julian1/following{/other_user}","gists_url":"https://api.github.com/users/julian1/gists{/gist_id}","starred_url":"https://api.github.com/users/julian1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julian1/subscriptions","organizations_url":"https://api.github.com/users/julian1/orgs","repos_url":"https://api.github.com/users/julian1/repos","events_url":"https://api.github.com/users/julian1/events{/privacy}","received_events_url":"https://api.github.com/users/julian1/received_events","type":"User","site_admin":false},"body":"Addresses https://github.com/aodn/ncdfgenerator/issues/18","created_at":"2015-04-23T05:08:01Z","updated_at":"2015-04-23T07:34:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30356de6a6e765a5a475057d80172cbec7b305f4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aodn/ncdfgenerator/pulls/20/commits","review_comments_url":"https://api.github.com/repos/aodn/ncdfgenerator/pulls/20/comments","review_comment_url":"https://api.github.com/repos/aodn/ncdfgenerator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aodn/ncdfgenerator/issues/20/comments","statuses_url":"https://api.github.com/repos/aodn/ncdfgenerator/statuses/09e267a4c89d8ac5aa4f84061e6b3ef07b737edc","head":{"label":"aodn:devel12-pr2","ref":"devel12-pr2","sha":"09e267a4c89d8ac5aa4f84061e6b3ef07b737edc","user":{"login":"aodn","id":2802166,"avatar_url":"https://avatars.githubusercontent.com/u/2802166?v=3","gravatar_id":"","url":"https://api.github.com/users/aodn","html_url":"https://github.com/aodn","followers_url":"https://api.github.com/users/aodn/followers","following_url":"https://api.github.com/users/aodn/following{/other_user}","gists_url":"https://api.github.com/users/aodn/gists{/gist_id}","starred_url":"https://api.github.com/users/aodn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aodn/subscriptions","organizations_url":"https://api.github.com/users/aodn/orgs","repos_url":"https://api.github.com/users/aodn/repos","events_url":"https://api.github.com/users/aodn/events{/privacy}","received_events_url":"https://api.github.com/users/aodn/received_events","type":"Organization","site_admin":false},"repo":{"id":33917023,"name":"ncdfgenerator","full_name":"aodn/ncdfgenerator","owner":{"login":"aodn","id":2802166,"avatar_url":"https://avatars.githubusercontent.com/u/2802166?v=3","gravatar_id":"","url":"https://api.github.com/users/aodn","html_url":"https://github.com/aodn","followers_url":"https://api.github.com/users/aodn/followers","following_url":"https://api.github.com/users/aodn/following{/other_user}","gists_url":"https://api.github.com/users/aodn/gists{/gist_id}","starred_url":"https://api.github.com/users/aodn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aodn/subscriptions","organizations_url":"https://api.github.com/users/aodn/orgs","repos_url":"https://api.github.com/users/aodn/repos","events_url":"https://api.github.com/users/aodn/events{/privacy}","received_events_url":"https://api.github.com/users/aodn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aodn/ncdfgenerator","description":"A library to produce NetCDF files from data in a relational database","fork":false,"url":"https://api.github.com/repos/aodn/ncdfgenerator","forks_url":"https://api.github.com/repos/aodn/ncdfgenerator/forks","keys_url":"https://api.github.com/repos/aodn/ncdfgenerator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aodn/ncdfgenerator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aodn/ncdfgenerator/teams","hooks_url":"https://api.github.com/repos/aodn/ncdfgenerator/hooks","issue_events_url":"https://api.github.com/repos/aodn/ncdfgenerator/issues/events{/number}","events_url":"https://api.github.com/repos/aodn/ncdfgenerator/events","assignees_url":"https://api.github.com/repos/aodn/ncdfgenerator/assignees{/user}","branches_url":"https://api.github.com/repos/aodn/ncdfgenerator/branches{/branch}","tags_url":"https://api.github.com/repos/aodn/ncdfgenerator/tags","blobs_url":"https://api.github.com/repos/aodn/ncdfgenerator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aodn/ncdfgenerator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aodn/ncdfgenerator/git/refs{/sha}","trees_url":"https://api.github.com/repos/aodn/ncdfgenerator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aodn/ncdfgenerator/statuses/{sha}","languages_url":"https://api.github.com/repos/aodn/ncdfgenerator/languages","stargazers_url":"https://api.github.com/repos/aodn/ncdfgenerator/stargazers","contributors_url":"https://api.github.com/repos/aodn/ncdfgenerator/contributors","subscribers_url":"https://api.github.com/repos/aodn/ncdfgenerator/subscribers","subscription_url":"https://api.github.com/repos/aodn/ncdfgenerator/subscription","commits_url":"https://api.github.com/repos/aodn/ncdfgenerator/commits{/sha}","git_commits_url":"https://api.github.com/repos/aodn/ncdfgenerator/git/commits{/sha}","comments_url":"https://api.github.com/repos/aodn/ncdfgenerator/comments{/number}","issue_comment_url":"https://api.github.com/repos/aodn/ncdfgenerator/issues/comments{/number}","contents_url":"https://api.github.com/repos/aodn/ncdfgenerator/contents/{+path}","compare_url":"https://api.github.com/repos/aodn/ncdfgenerator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aodn/ncdfgenerator/merges","archive_url":"https://api.github.com/repos/aodn/ncdfgenerator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aodn/ncdfgenerator/downloads","issues_url":"https://api.github.com/repos/aodn/ncdfgenerator/issues{/number}","pulls_url":"https://api.github.com/repos/aodn/ncdfgenerator/pulls{/number}","milestones_url":"https://api.github.com/repos/aodn/ncdfgenerator/milestones{/number}","notifications_url":"https://api.github.com/repos/aodn/ncdfgenerator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aodn/ncdfgenerator/labels{/name}","releases_url":"https://api.github.com/repos/aodn/ncdfgenerator/releases{/id}","created_at":"2015-04-14T07:23:52Z","updated_at":"2015-04-23T01:13:38Z","pushed_at":"2015-04-23T06:56:35Z","git_url":"git://github.com/aodn/ncdfgenerator.git","ssh_url":"git@github.com:aodn/ncdfgenerator.git","clone_url":"https://github.com/aodn/ncdfgenerator.git","svn_url":"https://github.com/aodn/ncdfgenerator","homepage":"","size":12260,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"aodn:master","ref":"master","sha":"a1e183b33c01c68b02eee714fe105e21daaf07a9","user":{"login":"aodn","id":2802166,"avatar_url":"https://avatars.githubusercontent.com/u/2802166?v=3","gravatar_id":"","url":"https://api.github.com/users/aodn","html_url":"https://github.com/aodn","followers_url":"https://api.github.com/users/aodn/followers","following_url":"https://api.github.com/users/aodn/following{/other_user}","gists_url":"https://api.github.com/users/aodn/gists{/gist_id}","starred_url":"https://api.github.com/users/aodn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aodn/subscriptions","organizations_url":"https://api.github.com/users/aodn/orgs","repos_url":"https://api.github.com/users/aodn/repos","events_url":"https://api.github.com/users/aodn/events{/privacy}","received_events_url":"https://api.github.com/users/aodn/received_events","type":"Organization","site_admin":false},"repo":{"id":33917023,"name":"ncdfgenerator","full_name":"aodn/ncdfgenerator","owner":{"login":"aodn","id":2802166,"avatar_url":"https://avatars.githubusercontent.com/u/2802166?v=3","gravatar_id":"","url":"https://api.github.com/users/aodn","html_url":"https://github.com/aodn","followers_url":"https://api.github.com/users/aodn/followers","following_url":"https://api.github.com/users/aodn/following{/other_user}","gists_url":"https://api.github.com/users/aodn/gists{/gist_id}","starred_url":"https://api.github.com/users/aodn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aodn/subscriptions","organizations_url":"https://api.github.com/users/aodn/orgs","repos_url":"https://api.github.com/users/aodn/repos","events_url":"https://api.github.com/users/aodn/events{/privacy}","received_events_url":"https://api.github.com/users/aodn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aodn/ncdfgenerator","description":"A library to produce NetCDF files from data in a relational database","fork":false,"url":"https://api.github.com/repos/aodn/ncdfgenerator","forks_url":"https://api.github.com/repos/aodn/ncdfgenerator/forks","keys_url":"https://api.github.com/repos/aodn/ncdfgenerator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aodn/ncdfgenerator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aodn/ncdfgenerator/teams","hooks_url":"https://api.github.com/repos/aodn/ncdfgenerator/hooks","issue_events_url":"https://api.github.com/repos/aodn/ncdfgenerator/issues/events{/number}","events_url":"https://api.github.com/repos/aodn/ncdfgenerator/events","assignees_url":"https://api.github.com/repos/aodn/ncdfgenerator/assignees{/user}","branches_url":"https://api.github.com/repos/aodn/ncdfgenerator/branches{/branch}","tags_url":"https://api.github.com/repos/aodn/ncdfgenerator/tags","blobs_url":"https://api.github.com/repos/aodn/ncdfgenerator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aodn/ncdfgenerator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aodn/ncdfgenerator/git/refs{/sha}","trees_url":"https://api.github.com/repos/aodn/ncdfgenerator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aodn/ncdfgenerator/statuses/{sha}","languages_url":"https://api.github.com/repos/aodn/ncdfgenerator/languages","stargazers_url":"https://api.github.com/repos/aodn/ncdfgenerator/stargazers","contributors_url":"https://api.github.com/repos/aodn/ncdfgenerator/contributors","subscribers_url":"https://api.github.com/repos/aodn/ncdfgenerator/subscribers","subscription_url":"https://api.github.com/repos/aodn/ncdfgenerator/subscription","commits_url":"https://api.github.com/repos/aodn/ncdfgenerator/commits{/sha}","git_commits_url":"https://api.github.com/repos/aodn/ncdfgenerator/git/commits{/sha}","comments_url":"https://api.github.com/repos/aodn/ncdfgenerator/comments{/number}","issue_comment_url":"https://api.github.com/repos/aodn/ncdfgenerator/issues/comments{/number}","contents_url":"https://api.github.com/repos/aodn/ncdfgenerator/contents/{+path}","compare_url":"https://api.github.com/repos/aodn/ncdfgenerator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aodn/ncdfgenerator/merges","archive_url":"https://api.github.com/repos/aodn/ncdfgenerator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aodn/ncdfgenerator/downloads","issues_url":"https://api.github.com/repos/aodn/ncdfgenerator/issues{/number}","pulls_url":"https://api.github.com/repos/aodn/ncdfgenerator/pulls{/number}","milestones_url":"https://api.github.com/repos/aodn/ncdfgenerator/milestones{/number}","notifications_url":"https://api.github.com/repos/aodn/ncdfgenerator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aodn/ncdfgenerator/labels{/name}","releases_url":"https://api.github.com/repos/aodn/ncdfgenerator/releases{/id}","created_at":"2015-04-14T07:23:52Z","updated_at":"2015-04-23T01:13:38Z","pushed_at":"2015-04-23T06:56:35Z","git_url":"git://github.com/aodn/ncdfgenerator.git","ssh_url":"git@github.com:aodn/ncdfgenerator.git","clone_url":"https://github.com/aodn/ncdfgenerator.git","svn_url":"https://github.com/aodn/ncdfgenerator","homepage":"","size":12260,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aodn/ncdfgenerator/pulls/20"},"html":{"href":"https://github.com/aodn/ncdfgenerator/pull/20"},"issue":{"href":"https://api.github.com/repos/aodn/ncdfgenerator/issues/20"},"comments":{"href":"https://api.github.com/repos/aodn/ncdfgenerator/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/aodn/ncdfgenerator/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/aodn/ncdfgenerator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aodn/ncdfgenerator/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/aodn/ncdfgenerator/statuses/09e267a4c89d8ac5aa4f84061e6b3ef07b737edc"}}}}