{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/comments/42987342","id":42987342,"diff_hunk":"@@ -485,6 +485,11 @@ def host_inherited_params_objects\n     params\n   end\n \n+  def host_params_objects\n+    # Host parameters should always be first for the uniq order\n+    (host_parameters + host_inherited_params_objects).uniq {|param| param.name}","path":"app/models/host/managed.rb","position":6,"original_position":6,"commit_id":"875da73cf82c05ce76e10df20c53446e2f665512","original_commit_id":"875da73cf82c05ce76e10df20c53446e2f665512","user":{"login":"domcleal","id":482089,"avatar_url":"https://avatars.githubusercontent.com/u/482089?v=3","gravatar_id":"","url":"https://api.github.com/users/domcleal","html_url":"https://github.com/domcleal","followers_url":"https://api.github.com/users/domcleal/followers","following_url":"https://api.github.com/users/domcleal/following{/other_user}","gists_url":"https://api.github.com/users/domcleal/gists{/gist_id}","starred_url":"https://api.github.com/users/domcleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcleal/subscriptions","organizations_url":"https://api.github.com/users/domcleal/orgs","repos_url":"https://api.github.com/users/domcleal/repos","events_url":"https://api.github.com/users/domcleal/events{/privacy}","received_events_url":"https://api.github.com/users/domcleal/received_events","type":"User","site_admin":false},"body":"I think this also needs to reverse `host_inherited_params_objects`.  If uniq's working from most to least specific, then a CommonParameter looks like it'll override an ancestor parameter.  The UI is showing it correctly but the API seems to work in the wrong order.","created_at":"2015-10-26T12:36:44Z","updated_at":"2015-10-26T12:36:44Z","html_url":"https://github.com/theforeman/foreman/pull/2812#discussion_r42987342","pull_request_url":"https://api.github.com/repos/theforeman/foreman/pulls/2812","_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments/42987342"},"html":{"href":"https://github.com/theforeman/foreman/pull/2812#discussion_r42987342"},"pull_request":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2812"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/2812","id":47367295,"html_url":"https://github.com/theforeman/foreman/pull/2812","diff_url":"https://github.com/theforeman/foreman/pull/2812.diff","patch_url":"https://github.com/theforeman/foreman/pull/2812.patch","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/2812","number":2812,"state":"open","locked":false,"title":"Fixes #12132 - [API] Host all parameters should include host parameters","user":{"login":"shlomizadok","id":433583,"avatar_url":"https://avatars.githubusercontent.com/u/433583?v=3","gravatar_id":"","url":"https://api.github.com/users/shlomizadok","html_url":"https://github.com/shlomizadok","followers_url":"https://api.github.com/users/shlomizadok/followers","following_url":"https://api.github.com/users/shlomizadok/following{/other_user}","gists_url":"https://api.github.com/users/shlomizadok/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomizadok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomizadok/subscriptions","organizations_url":"https://api.github.com/users/shlomizadok/orgs","repos_url":"https://api.github.com/users/shlomizadok/repos","events_url":"https://api.github.com/users/shlomizadok/events{/privacy}","received_events_url":"https://api.github.com/users/shlomizadok/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-11T13:52:13Z","updated_at":"2015-10-26T12:36:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67b0c1a4da1ec930b65ee416a2cfd72d1a8ff6a8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman/pulls/2812/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman/pulls/2812/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/2812/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/875da73cf82c05ce76e10df20c53446e2f665512","head":{"label":"shlomizadok:fix_12132","ref":"fix_12132","sha":"875da73cf82c05ce76e10df20c53446e2f665512","user":{"login":"shlomizadok","id":433583,"avatar_url":"https://avatars.githubusercontent.com/u/433583?v=3","gravatar_id":"","url":"https://api.github.com/users/shlomizadok","html_url":"https://github.com/shlomizadok","followers_url":"https://api.github.com/users/shlomizadok/followers","following_url":"https://api.github.com/users/shlomizadok/following{/other_user}","gists_url":"https://api.github.com/users/shlomizadok/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomizadok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomizadok/subscriptions","organizations_url":"https://api.github.com/users/shlomizadok/orgs","repos_url":"https://api.github.com/users/shlomizadok/repos","events_url":"https://api.github.com/users/shlomizadok/events{/privacy}","received_events_url":"https://api.github.com/users/shlomizadok/received_events","type":"User","site_admin":false},"repo":{"id":23541704,"name":"foreman","full_name":"shlomizadok/foreman","owner":{"login":"shlomizadok","id":433583,"avatar_url":"https://avatars.githubusercontent.com/u/433583?v=3","gravatar_id":"","url":"https://api.github.com/users/shlomizadok","html_url":"https://github.com/shlomizadok","followers_url":"https://api.github.com/users/shlomizadok/followers","following_url":"https://api.github.com/users/shlomizadok/following{/other_user}","gists_url":"https://api.github.com/users/shlomizadok/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomizadok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomizadok/subscriptions","organizations_url":"https://api.github.com/users/shlomizadok/orgs","repos_url":"https://api.github.com/users/shlomizadok/repos","events_url":"https://api.github.com/users/shlomizadok/events{/privacy}","received_events_url":"https://api.github.com/users/shlomizadok/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shlomizadok/foreman","description":"an application that automates the lifecycle of servers ","fork":true,"url":"https://api.github.com/repos/shlomizadok/foreman","forks_url":"https://api.github.com/repos/shlomizadok/foreman/forks","keys_url":"https://api.github.com/repos/shlomizadok/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shlomizadok/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shlomizadok/foreman/teams","hooks_url":"https://api.github.com/repos/shlomizadok/foreman/hooks","issue_events_url":"https://api.github.com/repos/shlomizadok/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/shlomizadok/foreman/events","assignees_url":"https://api.github.com/repos/shlomizadok/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/shlomizadok/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/shlomizadok/foreman/tags","blobs_url":"https://api.github.com/repos/shlomizadok/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shlomizadok/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shlomizadok/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/shlomizadok/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shlomizadok/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/shlomizadok/foreman/languages","stargazers_url":"https://api.github.com/repos/shlomizadok/foreman/stargazers","contributors_url":"https://api.github.com/repos/shlomizadok/foreman/contributors","subscribers_url":"https://api.github.com/repos/shlomizadok/foreman/subscribers","subscription_url":"https://api.github.com/repos/shlomizadok/foreman/subscription","commits_url":"https://api.github.com/repos/shlomizadok/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/shlomizadok/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/shlomizadok/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/shlomizadok/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/shlomizadok/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/shlomizadok/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shlomizadok/foreman/merges","archive_url":"https://api.github.com/repos/shlomizadok/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shlomizadok/foreman/downloads","issues_url":"https://api.github.com/repos/shlomizadok/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/shlomizadok/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/shlomizadok/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/shlomizadok/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shlomizadok/foreman/labels{/name}","releases_url":"https://api.github.com/repos/shlomizadok/foreman/releases{/id}","created_at":"2014-09-01T12:29:20Z","updated_at":"2015-05-03T08:08:15Z","pushed_at":"2015-10-26T09:04:48Z","git_url":"git://github.com/shlomizadok/foreman.git","ssh_url":"git@github.com:shlomizadok/foreman.git","clone_url":"https://github.com/shlomizadok/foreman.git","svn_url":"https://github.com/shlomizadok/foreman","homepage":"http://theforeman.org","size":30886,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"theforeman:develop","ref":"develop","sha":"85e82d04e0a7c9c86664240ea46138d303553069","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":258750,"name":"foreman","full_name":"theforeman/foreman","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/foreman","description":"an application that automates the lifecycle of servers ","fork":false,"url":"https://api.github.com/repos/theforeman/foreman","forks_url":"https://api.github.com/repos/theforeman/foreman/forks","keys_url":"https://api.github.com/repos/theforeman/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman/events","assignees_url":"https://api.github.com/repos/theforeman/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman/merges","archive_url":"https://api.github.com/repos/theforeman/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman/releases{/id}","created_at":"2009-07-23T15:07:00Z","updated_at":"2015-10-21T17:34:17Z","pushed_at":"2015-10-26T11:58:37Z","git_url":"git://github.com/theforeman/foreman.git","ssh_url":"git@github.com:theforeman/foreman.git","clone_url":"https://github.com/theforeman/foreman.git","svn_url":"https://github.com/theforeman/foreman","homepage":"http://theforeman.org","size":98687,"stargazers_count":875,"watchers_count":875,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":440,"mirror_url":null,"open_issues_count":91,"forks":440,"open_issues":91,"watchers":875,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2812"},"html":{"href":"https://github.com/theforeman/foreman/pull/2812"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman/issues/2812"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman/issues/2812/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2812/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2812/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman/statuses/875da73cf82c05ce76e10df20c53446e2f665512"}}}}