{"action":"created","comment":{"url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/pulls/comments/26212966","id":26212966,"diff_hunk":"@@ -371,10 +397,13 @@ define(function(require) {\n \n         // according to given item index this should make the item as selected\n         selectItem: function(itemIndex) {\n+            this.$el.a11y_selected(false);\n             _.each(this.model.get('_items'), function(item, index) {\n                 item.selected = (index == itemIndex);\n                 if(item.selected) {\n                     this.model.set('_selectedItem', item);\n+                    this.$('.confidenceSlider-scale-number[data-id=\"'+(itemIndex+1)+'\"]').a11y_selected(true);","path":"js/adapt-contrib-slider.js","position":70,"original_position":70,"commit_id":"2b3131df672f9788e4ac14c1f1ae93529a8ddc7f","original_commit_id":"2b3131df672f9788e4ac14c1f1ae93529a8ddc7f","user":{"login":"oliverfoster","id":7974663,"avatar_url":"https://avatars.githubusercontent.com/u/7974663?v=3","gravatar_id":"","url":"https://api.github.com/users/oliverfoster","html_url":"https://github.com/oliverfoster","followers_url":"https://api.github.com/users/oliverfoster/followers","following_url":"https://api.github.com/users/oliverfoster/following{/other_user}","gists_url":"https://api.github.com/users/oliverfoster/gists{/gist_id}","starred_url":"https://api.github.com/users/oliverfoster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliverfoster/subscriptions","organizations_url":"https://api.github.com/users/oliverfoster/orgs","repos_url":"https://api.github.com/users/oliverfoster/repos","events_url":"https://api.github.com/users/oliverfoster/events{/privacy}","received_events_url":"https://api.github.com/users/oliverfoster/received_events","type":"User","site_admin":false},"body":"I posed a question on this. As the confidence slider heavily extends slider and doesn't reimplement selectItem, this line is currently needed to make confidence slider accessible. I suggest that two separate PR's are made after this one. One to remove this line and one to update confidence slider with it's own implementation of selectItem.\r\n\r\nLet me know your thoughts.","created_at":"2015-03-11T13:53:08Z","updated_at":"2015-03-11T13:53:08Z","html_url":"https://github.com/adaptlearning/adapt-contrib-slider/pull/60#discussion_r26212966","pull_request_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/pulls/60","_links":{"self":{"href":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/pulls/comments/26212966"},"html":{"href":"https://github.com/adaptlearning/adapt-contrib-slider/pull/60#discussion_r26212966"},"pull_request":{"href":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/pulls/60"}}},"pull_request":{"url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/pulls/60","id":29198344,"html_url":"https://github.com/adaptlearning/adapt-contrib-slider/pull/60","diff_url":"https://github.com/adaptlearning/adapt-contrib-slider/pull/60.diff","patch_url":"https://github.com/adaptlearning/adapt-contrib-slider/pull/60.patch","issue_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/issues/60","number":60,"state":"open","locked":false,"title":"onNumberSelected added / template updated","user":{"login":"kirsty-hames","id":7045330,"avatar_url":"https://avatars.githubusercontent.com/u/7045330?v=3","gravatar_id":"","url":"https://api.github.com/users/kirsty-hames","html_url":"https://github.com/kirsty-hames","followers_url":"https://api.github.com/users/kirsty-hames/followers","following_url":"https://api.github.com/users/kirsty-hames/following{/other_user}","gists_url":"https://api.github.com/users/kirsty-hames/gists{/gist_id}","starred_url":"https://api.github.com/users/kirsty-hames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirsty-hames/subscriptions","organizations_url":"https://api.github.com/users/kirsty-hames/orgs","repos_url":"https://api.github.com/users/kirsty-hames/repos","events_url":"https://api.github.com/users/kirsty-hames/events{/privacy}","received_events_url":"https://api.github.com/users/kirsty-hames/received_events","type":"User","site_admin":false},"body":"- slider scale numbers replace slider handle interaction for accessibility users.","created_at":"2015-02-12T17:25:15Z","updated_at":"2015-03-11T13:53:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f5acd6564eb2c89e8d262cc5b44e3b1a39ca139","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/pulls/60/commits","review_comments_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/pulls/60/comments","review_comment_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/pulls/comments{/number}","comments_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/issues/60/comments","statuses_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/statuses/2b3131df672f9788e4ac14c1f1ae93529a8ddc7f","head":{"label":"cgkineo-projects:accessibility-merge","ref":"accessibility-merge","sha":"2b3131df672f9788e4ac14c1f1ae93529a8ddc7f","user":{"login":"cgkineo-projects","id":10864325,"avatar_url":"https://avatars.githubusercontent.com/u/10864325?v=3","gravatar_id":"","url":"https://api.github.com/users/cgkineo-projects","html_url":"https://github.com/cgkineo-projects","followers_url":"https://api.github.com/users/cgkineo-projects/followers","following_url":"https://api.github.com/users/cgkineo-projects/following{/other_user}","gists_url":"https://api.github.com/users/cgkineo-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/cgkineo-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgkineo-projects/subscriptions","organizations_url":"https://api.github.com/users/cgkineo-projects/orgs","repos_url":"https://api.github.com/users/cgkineo-projects/repos","events_url":"https://api.github.com/users/cgkineo-projects/events{/privacy}","received_events_url":"https://api.github.com/users/cgkineo-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":30350705,"name":"adapt-contrib-slider","full_name":"cgkineo-projects/adapt-contrib-slider","owner":{"login":"cgkineo-projects","id":10864325,"avatar_url":"https://avatars.githubusercontent.com/u/10864325?v=3","gravatar_id":"","url":"https://api.github.com/users/cgkineo-projects","html_url":"https://github.com/cgkineo-projects","followers_url":"https://api.github.com/users/cgkineo-projects/followers","following_url":"https://api.github.com/users/cgkineo-projects/following{/other_user}","gists_url":"https://api.github.com/users/cgkineo-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/cgkineo-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgkineo-projects/subscriptions","organizations_url":"https://api.github.com/users/cgkineo-projects/orgs","repos_url":"https://api.github.com/users/cgkineo-projects/repos","events_url":"https://api.github.com/users/cgkineo-projects/events{/privacy}","received_events_url":"https://api.github.com/users/cgkineo-projects/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cgkineo-projects/adapt-contrib-slider","description":"A question component that allows the learner to position a slider on scale","fork":true,"url":"https://api.github.com/repos/cgkineo-projects/adapt-contrib-slider","forks_url":"https://api.github.com/repos/cgkineo-projects/adapt-contrib-slider/forks","keys_url":"https://api.github.com/repos/cgkineo-projects/adapt-contrib-slider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cgkineo-projects/adapt-contrib-slider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cgkineo-projects/adapt-contrib-slider/teams","hooks_url":"https://api.github.com/repos/cgkineo-projects/adapt-contrib-slider/hooks","issue_events_url":"https://api.github.com/repos/cgkineo-projects/adapt-contrib-slider/issues/events{/number}","events_url":"https://api.github.com/repos/cgkineo-projects/adapt-contrib-slider/events","assignees_url":"https://api.github.com/repos/cgkineo-projects/adapt-contrib-slider/assignees{/user}","branches_url":"https://api.github.com/repos/cgkineo-projects/adapt-contrib-slider/branches{/branch}","tags_url":"https://api.github.com/repos/cgkineo-projects/adapt-contrib-slider/tags","blobs_url":"https://api.github.com/repos/cgkineo-projects/adapt-contrib-slider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cgkineo-projects/adapt-contrib-slider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cgkineo-projects/adapt-contrib-slider/git/refs{/sha}","trees_url":"https://api.github.com/repos/cgkineo-projects/adapt-contrib-slider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cgkineo-projects/adapt-contrib-slider/statuses/{sha}","languages_url":"https://api.github.com/repos/cgkineo-projects/adapt-contrib-slider/languages","stargazers_url":"https://api.github.com/repos/cgkineo-projects/adapt-contrib-slider/stargazers","contributors_url":"https://api.github.com/repos/cgkineo-projects/adapt-contrib-slider/contributors","subscribers_url":"https://api.github.com/repos/cgkineo-projects/adapt-contrib-slider/subscribers","subscription_url":"https://api.github.com/repos/cgkineo-projects/adapt-contrib-slider/subscription","commits_url":"https://api.github.com/repos/cgkineo-projects/adapt-contrib-slider/commits{/sha}","git_commits_url":"https://api.github.com/repos/cgkineo-projects/adapt-contrib-slider/git/commits{/sha}","comments_url":"https://api.github.com/repos/cgkineo-projects/adapt-contrib-slider/comments{/number}","issue_comment_url":"https://api.github.com/repos/cgkineo-projects/adapt-contrib-slider/issues/comments{/number}","contents_url":"https://api.github.com/repos/cgkineo-projects/adapt-contrib-slider/contents/{+path}","compare_url":"https://api.github.com/repos/cgkineo-projects/adapt-contrib-slider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cgkineo-projects/adapt-contrib-slider/merges","archive_url":"https://api.github.com/repos/cgkineo-projects/adapt-contrib-slider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cgkineo-projects/adapt-contrib-slider/downloads","issues_url":"https://api.github.com/repos/cgkineo-projects/adapt-contrib-slider/issues{/number}","pulls_url":"https://api.github.com/repos/cgkineo-projects/adapt-contrib-slider/pulls{/number}","milestones_url":"https://api.github.com/repos/cgkineo-projects/adapt-contrib-slider/milestones{/number}","notifications_url":"https://api.github.com/repos/cgkineo-projects/adapt-contrib-slider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cgkineo-projects/adapt-contrib-slider/labels{/name}","releases_url":"https://api.github.com/repos/cgkineo-projects/adapt-contrib-slider/releases{/id}","created_at":"2015-02-05T10:46:23Z","updated_at":"2015-02-05T12:38:49Z","pushed_at":"2015-03-11T13:30:41Z","git_url":"git://github.com/cgkineo-projects/adapt-contrib-slider.git","ssh_url":"git@github.com:cgkineo-projects/adapt-contrib-slider.git","clone_url":"https://github.com/cgkineo-projects/adapt-contrib-slider.git","svn_url":"https://github.com/cgkineo-projects/adapt-contrib-slider","homepage":null,"size":219,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"adaptlearning:develop","ref":"develop","sha":"5210bc835cb8cf2738fe61af00e7dee20406cd1a","user":{"login":"adaptlearning","id":5629464,"avatar_url":"https://avatars.githubusercontent.com/u/5629464?v=3","gravatar_id":"","url":"https://api.github.com/users/adaptlearning","html_url":"https://github.com/adaptlearning","followers_url":"https://api.github.com/users/adaptlearning/followers","following_url":"https://api.github.com/users/adaptlearning/following{/other_user}","gists_url":"https://api.github.com/users/adaptlearning/gists{/gist_id}","starred_url":"https://api.github.com/users/adaptlearning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adaptlearning/subscriptions","organizations_url":"https://api.github.com/users/adaptlearning/orgs","repos_url":"https://api.github.com/users/adaptlearning/repos","events_url":"https://api.github.com/users/adaptlearning/events{/privacy}","received_events_url":"https://api.github.com/users/adaptlearning/received_events","type":"Organization","site_admin":false},"repo":{"id":16702097,"name":"adapt-contrib-slider","full_name":"adaptlearning/adapt-contrib-slider","owner":{"login":"adaptlearning","id":5629464,"avatar_url":"https://avatars.githubusercontent.com/u/5629464?v=3","gravatar_id":"","url":"https://api.github.com/users/adaptlearning","html_url":"https://github.com/adaptlearning","followers_url":"https://api.github.com/users/adaptlearning/followers","following_url":"https://api.github.com/users/adaptlearning/following{/other_user}","gists_url":"https://api.github.com/users/adaptlearning/gists{/gist_id}","starred_url":"https://api.github.com/users/adaptlearning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adaptlearning/subscriptions","organizations_url":"https://api.github.com/users/adaptlearning/orgs","repos_url":"https://api.github.com/users/adaptlearning/repos","events_url":"https://api.github.com/users/adaptlearning/events{/privacy}","received_events_url":"https://api.github.com/users/adaptlearning/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/adaptlearning/adapt-contrib-slider","description":"A question component that allows the learner to position a slider on scale","fork":false,"url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider","forks_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/forks","keys_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/teams","hooks_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/hooks","issue_events_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/issues/events{/number}","events_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/events","assignees_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/assignees{/user}","branches_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/branches{/branch}","tags_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/tags","blobs_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/git/refs{/sha}","trees_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/statuses/{sha}","languages_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/languages","stargazers_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/stargazers","contributors_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/contributors","subscribers_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/subscribers","subscription_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/subscription","commits_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/commits{/sha}","git_commits_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/git/commits{/sha}","comments_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/comments{/number}","issue_comment_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/issues/comments{/number}","contents_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/contents/{+path}","compare_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/merges","archive_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/downloads","issues_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/issues{/number}","pulls_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/pulls{/number}","milestones_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/milestones{/number}","notifications_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/labels{/name}","releases_url":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/releases{/id}","created_at":"2014-02-10T16:54:32Z","updated_at":"2014-11-18T17:45:43Z","pushed_at":"2015-01-21T14:59:06Z","git_url":"git://github.com/adaptlearning/adapt-contrib-slider.git","ssh_url":"git@github.com:adaptlearning/adapt-contrib-slider.git","clone_url":"https://github.com/adaptlearning/adapt-contrib-slider.git","svn_url":"https://github.com/adaptlearning/adapt-contrib-slider","homepage":null,"size":492,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":13,"forks":4,"open_issues":13,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/pulls/60"},"html":{"href":"https://github.com/adaptlearning/adapt-contrib-slider/pull/60"},"issue":{"href":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/issues/60"},"comments":{"href":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/adaptlearning/adapt-contrib-slider/statuses/2b3131df672f9788e4ac14c1f1ae93529a8ddc7f"}}}}