{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/io.js/pulls/comments/30462035","id":30462035,"diff_hunk":"@@ -0,0 +1,50 @@\n+var assert = require('assert');\n+var util = require('util');\n+var repl = require('repl');\n+var zlib = require('zlib');\n+var defaultScopes = [","path":"test/parallel/test-repl-tab.js","position":5,"original_position":5,"commit_id":"dcea4d70641af28cfdcb7b447bbe6abeb8abc909","original_commit_id":"dcea4d70641af28cfdcb7b447bbe6abeb8abc909","user":{"login":"indutny","id":238531,"avatar_url":"https://avatars.githubusercontent.com/u/238531?v=3","gravatar_id":"","url":"https://api.github.com/users/indutny","html_url":"https://github.com/indutny","followers_url":"https://api.github.com/users/indutny/followers","following_url":"https://api.github.com/users/indutny/following{/other_user}","gists_url":"https://api.github.com/users/indutny/gists{/gist_id}","starred_url":"https://api.github.com/users/indutny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indutny/subscriptions","organizations_url":"https://api.github.com/users/indutny/orgs","repos_url":"https://api.github.com/users/indutny/repos","events_url":"https://api.github.com/users/indutny/events{/privacy}","received_events_url":"https://api.github.com/users/indutny/received_events","type":"User","site_admin":false},"body":"This is going to fail if there will be new globals introduced :) Let's skip this assert.","created_at":"2015-05-16T15:40:08Z","updated_at":"2015-05-16T15:40:08Z","html_url":"https://github.com/nodejs/io.js/pull/1682#discussion_r30462035","pull_request_url":"https://api.github.com/repos/nodejs/io.js/pulls/1682","_links":{"self":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/comments/30462035"},"html":{"href":"https://github.com/nodejs/io.js/pull/1682#discussion_r30462035"},"pull_request":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/1682"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/io.js/pulls/1682","id":35202134,"html_url":"https://github.com/nodejs/io.js/pull/1682","diff_url":"https://github.com/nodejs/io.js/pull/1682.diff","patch_url":"https://github.com/nodejs/io.js/pull/1682.patch","issue_url":"https://api.github.com/repos/nodejs/io.js/issues/1682","number":1682,"state":"open","locked":false,"title":"repl: globals must be an array","user":{"login":"yorkie","id":1935767,"avatar_url":"https://avatars.githubusercontent.com/u/1935767?v=3","gravatar_id":"","url":"https://api.github.com/users/yorkie","html_url":"https://github.com/yorkie","followers_url":"https://api.github.com/users/yorkie/followers","following_url":"https://api.github.com/users/yorkie/following{/other_user}","gists_url":"https://api.github.com/users/yorkie/gists{/gist_id}","starred_url":"https://api.github.com/users/yorkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yorkie/subscriptions","organizations_url":"https://api.github.com/users/yorkie/orgs","repos_url":"https://api.github.com/users/yorkie/repos","events_url":"https://api.github.com/users/yorkie/events{/privacy}","received_events_url":"https://api.github.com/users/yorkie/received_events","type":"User","site_admin":false},"body":"Reproduce source code:\r\n\r\n```\r\nrepl.start('>', stream, function(cmd, ctx, file, next) {\r\n  next(cmd);\r\n});\r\n```\r\n\r\nand press <tab> in runtime, it would prints an error over the globals list, that's because we pass the `cmd`(the value is `.scope`) to `eval` function, but we don't verify if the globals is an array.\r\n\r\n/cc @indutny ","created_at":"2015-05-12T08:10:22Z","updated_at":"2015-05-16T15:40:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66422a3fae89425baded7e8973e046bc80e67cf9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/io.js/pulls/1682/commits","review_comments_url":"https://api.github.com/repos/nodejs/io.js/pulls/1682/comments","review_comment_url":"https://api.github.com/repos/nodejs/io.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/io.js/issues/1682/comments","statuses_url":"https://api.github.com/repos/nodejs/io.js/statuses/dcea4d70641af28cfdcb7b447bbe6abeb8abc909","head":{"label":"yorkie:fix/repl-tab","ref":"fix/repl-tab","sha":"dcea4d70641af28cfdcb7b447bbe6abeb8abc909","user":{"login":"yorkie","id":1935767,"avatar_url":"https://avatars.githubusercontent.com/u/1935767?v=3","gravatar_id":"","url":"https://api.github.com/users/yorkie","html_url":"https://github.com/yorkie","followers_url":"https://api.github.com/users/yorkie/followers","following_url":"https://api.github.com/users/yorkie/following{/other_user}","gists_url":"https://api.github.com/users/yorkie/gists{/gist_id}","starred_url":"https://api.github.com/users/yorkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yorkie/subscriptions","organizations_url":"https://api.github.com/users/yorkie/orgs","repos_url":"https://api.github.com/users/yorkie/repos","events_url":"https://api.github.com/users/yorkie/events{/privacy}","received_events_url":"https://api.github.com/users/yorkie/received_events","type":"User","site_admin":false},"repo":{"id":31024000,"name":"io.js","full_name":"yorkie/io.js","owner":{"login":"yorkie","id":1935767,"avatar_url":"https://avatars.githubusercontent.com/u/1935767?v=3","gravatar_id":"","url":"https://api.github.com/users/yorkie","html_url":"https://github.com/yorkie","followers_url":"https://api.github.com/users/yorkie/followers","following_url":"https://api.github.com/users/yorkie/following{/other_user}","gists_url":"https://api.github.com/users/yorkie/gists{/gist_id}","starred_url":"https://api.github.com/users/yorkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yorkie/subscriptions","organizations_url":"https://api.github.com/users/yorkie/orgs","repos_url":"https://api.github.com/users/yorkie/repos","events_url":"https://api.github.com/users/yorkie/events{/privacy}","received_events_url":"https://api.github.com/users/yorkie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yorkie/io.js","description":"A friendly fork of Node.js with an open governance model","fork":true,"url":"https://api.github.com/repos/yorkie/io.js","forks_url":"https://api.github.com/repos/yorkie/io.js/forks","keys_url":"https://api.github.com/repos/yorkie/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yorkie/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yorkie/io.js/teams","hooks_url":"https://api.github.com/repos/yorkie/io.js/hooks","issue_events_url":"https://api.github.com/repos/yorkie/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/yorkie/io.js/events","assignees_url":"https://api.github.com/repos/yorkie/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/yorkie/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/yorkie/io.js/tags","blobs_url":"https://api.github.com/repos/yorkie/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yorkie/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yorkie/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/yorkie/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yorkie/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/yorkie/io.js/languages","stargazers_url":"https://api.github.com/repos/yorkie/io.js/stargazers","contributors_url":"https://api.github.com/repos/yorkie/io.js/contributors","subscribers_url":"https://api.github.com/repos/yorkie/io.js/subscribers","subscription_url":"https://api.github.com/repos/yorkie/io.js/subscription","commits_url":"https://api.github.com/repos/yorkie/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/yorkie/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/yorkie/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/yorkie/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/yorkie/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/yorkie/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yorkie/io.js/merges","archive_url":"https://api.github.com/repos/yorkie/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yorkie/io.js/downloads","issues_url":"https://api.github.com/repos/yorkie/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/yorkie/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/yorkie/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/yorkie/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yorkie/io.js/labels{/name}","releases_url":"https://api.github.com/repos/yorkie/io.js/releases{/id}","created_at":"2015-02-19T16:17:09Z","updated_at":"2015-02-19T16:17:12Z","pushed_at":"2015-05-16T14:00:45Z","git_url":"git://github.com/yorkie/io.js.git","ssh_url":"git@github.com:yorkie/io.js.git","clone_url":"https://github.com/yorkie/io.js.git","svn_url":"https://github.com/yorkie/io.js","homepage":"https://iojs.org","size":128315,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"v1.x"}},"base":{"label":"nodejs:master","ref":"master","sha":"8a0e5295b4c0b83855d4b51496254a759dfe9dfa","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"io.js","full_name":"nodejs/io.js","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/io.js","description":"A friendly fork of Node.js with an open governance model","fork":false,"url":"https://api.github.com/repos/nodejs/io.js","forks_url":"https://api.github.com/repos/nodejs/io.js/forks","keys_url":"https://api.github.com/repos/nodejs/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/io.js/teams","hooks_url":"https://api.github.com/repos/nodejs/io.js/hooks","issue_events_url":"https://api.github.com/repos/nodejs/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/io.js/events","assignees_url":"https://api.github.com/repos/nodejs/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/io.js/tags","blobs_url":"https://api.github.com/repos/nodejs/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/io.js/languages","stargazers_url":"https://api.github.com/repos/nodejs/io.js/stargazers","contributors_url":"https://api.github.com/repos/nodejs/io.js/contributors","subscribers_url":"https://api.github.com/repos/nodejs/io.js/subscribers","subscription_url":"https://api.github.com/repos/nodejs/io.js/subscription","commits_url":"https://api.github.com/repos/nodejs/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/io.js/merges","archive_url":"https://api.github.com/repos/nodejs/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/io.js/downloads","issues_url":"https://api.github.com/repos/nodejs/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/io.js/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/io.js/releases{/id}","created_at":"2014-11-26T19:57:11Z","updated_at":"2015-05-16T15:29:45Z","pushed_at":"2015-05-16T14:00:46Z","git_url":"git://github.com/nodejs/io.js.git","ssh_url":"git@github.com:nodejs/io.js.git","clone_url":"https://github.com/nodejs/io.js.git","svn_url":"https://github.com/nodejs/io.js","homepage":"https://iojs.org","size":180770,"stargazers_count":12378,"watchers_count":12378,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":902,"mirror_url":null,"open_issues_count":255,"forks":902,"open_issues":255,"watchers":12378,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/1682"},"html":{"href":"https://github.com/nodejs/io.js/pull/1682"},"issue":{"href":"https://api.github.com/repos/nodejs/io.js/issues/1682"},"comments":{"href":"https://api.github.com/repos/nodejs/io.js/issues/1682/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/1682/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/1682/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/io.js/statuses/dcea4d70641af28cfdcb7b447bbe6abeb8abc909"}}}}