{"action":"created","comment":{"url":"https://api.github.com/repos/Elgg/Elgg/pulls/comments/31377051","id":31377051,"diff_hunk":"@@ -0,0 +1,189 @@\n+// <script>\n+define(function(require) {\n+\t// inserts the embed content into the textarea\n+\t$(\".embed-item\").live('click', embed.insert);\n+\n+\telgg.register_hook_handler('embed', 'editor', embed._deprecated_custom_insert_js);\n+\n+\t// caches the current textarea id\n+\t$(\".embed-control\").live('click', function() {\n+\t\tvar textAreaId = /embed-control-(\\S)+/.exec($(this).attr('class'))[0];\n+\t\tembed.textAreaId = textAreaId.substr(\"embed-control-\".length);\n+\t});\n+\n+\t// special pagination helper for lightbox\n+\t$('.embed-wrapper .elgg-pagination a').live('click', embed.forward);\n+\n+\t$('.embed-section').live('click', embed.forward);\n+\n+\t$('.elgg-form-embed').live('submit', embed.submit);\n+\n+\tvar embed = {};\n+\n+\t/**\n+\t * Adds support for plugins that extends embed/custom_insert_js deprecated views\n+\t *\n+\t * @param {String} hook\n+\t * @param {String} type\n+\t * @param {Object} params\n+\t * @param {String|Boolean} value\n+\t * @returns {String|Boolean}\n+\t * @private\n+\t */\n+\tembed._deprecated_custom_insert_js = function(hook, type, params, value) {\n+\t\tvar textAreaId = params.textAreaId;\n+\t\tvar content = params.content;\n+\t\tvar event = params.event;\n+\t<?php\n+\t\tif (elgg_view_exists('embed/custom_insert_js')) {\n+\t\t\telgg_deprecated_notice(\"The view embed/custom_insert_js has been replaced by the js hook 'embed', 'editor'.\", 1.9);","path":"mod/embed/views/default/js/elgg/embed.js.php","position":39,"original_position":39,"commit_id":"af685fd0de04e9d583c459ef9cfe75fc5819428d","original_commit_id":"af685fd0de04e9d583c459ef9cfe75fc5819428d","user":{"login":"mrclay","id":170687,"avatar_url":"https://avatars.githubusercontent.com/u/170687?v=3","gravatar_id":"","url":"https://api.github.com/users/mrclay","html_url":"https://github.com/mrclay","followers_url":"https://api.github.com/users/mrclay/followers","following_url":"https://api.github.com/users/mrclay/following{/other_user}","gists_url":"https://api.github.com/users/mrclay/gists{/gist_id}","starred_url":"https://api.github.com/users/mrclay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrclay/subscriptions","organizations_url":"https://api.github.com/users/mrclay/orgs","repos_url":"https://api.github.com/users/mrclay/repos","events_url":"https://api.github.com/users/mrclay/events{/privacy}","received_events_url":"https://api.github.com/users/mrclay/received_events","type":"User","site_admin":false},"body":"Might as well ditch this, huh?","created_at":"2015-05-30T03:07:55Z","updated_at":"2015-05-30T03:07:55Z","html_url":"https://github.com/Elgg/Elgg/pull/8393#discussion_r31377051","pull_request_url":"https://api.github.com/repos/Elgg/Elgg/pulls/8393","_links":{"self":{"href":"https://api.github.com/repos/Elgg/Elgg/pulls/comments/31377051"},"html":{"href":"https://github.com/Elgg/Elgg/pull/8393#discussion_r31377051"},"pull_request":{"href":"https://api.github.com/repos/Elgg/Elgg/pulls/8393"}}},"pull_request":{"url":"https://api.github.com/repos/Elgg/Elgg/pulls/8393","id":36553271,"html_url":"https://github.com/Elgg/Elgg/pull/8393","diff_url":"https://github.com/Elgg/Elgg/pull/8393.diff","patch_url":"https://github.com/Elgg/Elgg/pull/8393.patch","issue_url":"https://api.github.com/repos/Elgg/Elgg/issues/8393","number":8393,"state":"open","locked":false,"title":"WIP(js): Convert everything to AMD","user":{"login":"ewinslow","id":356564,"avatar_url":"https://avatars.githubusercontent.com/u/356564?v=3","gravatar_id":"","url":"https://api.github.com/users/ewinslow","html_url":"https://github.com/ewinslow","followers_url":"https://api.github.com/users/ewinslow/followers","following_url":"https://api.github.com/users/ewinslow/following{/other_user}","gists_url":"https://api.github.com/users/ewinslow/gists{/gist_id}","starred_url":"https://api.github.com/users/ewinslow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewinslow/subscriptions","organizations_url":"https://api.github.com/users/ewinslow/orgs","repos_url":"https://api.github.com/users/ewinslow/repos","events_url":"https://api.github.com/users/ewinslow/events{/privacy}","received_events_url":"https://api.github.com/users/ewinslow/received_events","type":"User","site_admin":false},"body":"BREAKING CHANGE:\r\nelgg.provide and elgg.require have been removed.\r\nUse `define` and `require` instead.\r\nCore libraries are only available under AMD now.","created_at":"2015-05-29T23:15:50Z","updated_at":"2015-05-30T03:07:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f54fbf168fd117b418c1c56765d212bc47dd80c","assignee":null,"milestone":{"url":"https://api.github.com/repos/Elgg/Elgg/milestones/60","html_url":"https://github.com/Elgg/Elgg/milestones/Elgg%202.0.x","labels_url":"https://api.github.com/repos/Elgg/Elgg/milestones/60/labels","id":404754,"number":60,"title":"Elgg 2.0.x","description":"","creator":{"login":"ewinslow","id":356564,"avatar_url":"https://avatars.githubusercontent.com/u/356564?v=3","gravatar_id":"","url":"https://api.github.com/users/ewinslow","html_url":"https://github.com/ewinslow","followers_url":"https://api.github.com/users/ewinslow/followers","following_url":"https://api.github.com/users/ewinslow/following{/other_user}","gists_url":"https://api.github.com/users/ewinslow/gists{/gist_id}","starred_url":"https://api.github.com/users/ewinslow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewinslow/subscriptions","organizations_url":"https://api.github.com/users/ewinslow/orgs","repos_url":"https://api.github.com/users/ewinslow/repos","events_url":"https://api.github.com/users/ewinslow/events{/privacy}","received_events_url":"https://api.github.com/users/ewinslow/received_events","type":"User","site_admin":false},"open_issues":29,"closed_issues":18,"state":"open","created_at":"2013-08-19T00:23:53Z","updated_at":"2015-05-30T00:54:36Z","due_on":"2015-07-05T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/Elgg/Elgg/pulls/8393/commits","review_comments_url":"https://api.github.com/repos/Elgg/Elgg/pulls/8393/comments","review_comment_url":"https://api.github.com/repos/Elgg/Elgg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Elgg/Elgg/issues/8393/comments","statuses_url":"https://api.github.com/repos/Elgg/Elgg/statuses/af685fd0de04e9d583c459ef9cfe75fc5819428d","head":{"label":"ewinslow:amd-all-the-things","ref":"amd-all-the-things","sha":"af685fd0de04e9d583c459ef9cfe75fc5819428d","user":{"login":"ewinslow","id":356564,"avatar_url":"https://avatars.githubusercontent.com/u/356564?v=3","gravatar_id":"","url":"https://api.github.com/users/ewinslow","html_url":"https://github.com/ewinslow","followers_url":"https://api.github.com/users/ewinslow/followers","following_url":"https://api.github.com/users/ewinslow/following{/other_user}","gists_url":"https://api.github.com/users/ewinslow/gists{/gist_id}","starred_url":"https://api.github.com/users/ewinslow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewinslow/subscriptions","organizations_url":"https://api.github.com/users/ewinslow/orgs","repos_url":"https://api.github.com/users/ewinslow/repos","events_url":"https://api.github.com/users/ewinslow/events{/privacy}","received_events_url":"https://api.github.com/users/ewinslow/received_events","type":"User","site_admin":false},"repo":{"id":1455345,"name":"Elgg","full_name":"ewinslow/Elgg","owner":{"login":"ewinslow","id":356564,"avatar_url":"https://avatars.githubusercontent.com/u/356564?v=3","gravatar_id":"","url":"https://api.github.com/users/ewinslow","html_url":"https://github.com/ewinslow","followers_url":"https://api.github.com/users/ewinslow/followers","following_url":"https://api.github.com/users/ewinslow/following{/other_user}","gists_url":"https://api.github.com/users/ewinslow/gists{/gist_id}","starred_url":"https://api.github.com/users/ewinslow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewinslow/subscriptions","organizations_url":"https://api.github.com/users/ewinslow/orgs","repos_url":"https://api.github.com/users/ewinslow/repos","events_url":"https://api.github.com/users/ewinslow/events{/privacy}","received_events_url":"https://api.github.com/users/ewinslow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ewinslow/Elgg","description":"A social networking engine","fork":true,"url":"https://api.github.com/repos/ewinslow/Elgg","forks_url":"https://api.github.com/repos/ewinslow/Elgg/forks","keys_url":"https://api.github.com/repos/ewinslow/Elgg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ewinslow/Elgg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ewinslow/Elgg/teams","hooks_url":"https://api.github.com/repos/ewinslow/Elgg/hooks","issue_events_url":"https://api.github.com/repos/ewinslow/Elgg/issues/events{/number}","events_url":"https://api.github.com/repos/ewinslow/Elgg/events","assignees_url":"https://api.github.com/repos/ewinslow/Elgg/assignees{/user}","branches_url":"https://api.github.com/repos/ewinslow/Elgg/branches{/branch}","tags_url":"https://api.github.com/repos/ewinslow/Elgg/tags","blobs_url":"https://api.github.com/repos/ewinslow/Elgg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ewinslow/Elgg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ewinslow/Elgg/git/refs{/sha}","trees_url":"https://api.github.com/repos/ewinslow/Elgg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ewinslow/Elgg/statuses/{sha}","languages_url":"https://api.github.com/repos/ewinslow/Elgg/languages","stargazers_url":"https://api.github.com/repos/ewinslow/Elgg/stargazers","contributors_url":"https://api.github.com/repos/ewinslow/Elgg/contributors","subscribers_url":"https://api.github.com/repos/ewinslow/Elgg/subscribers","subscription_url":"https://api.github.com/repos/ewinslow/Elgg/subscription","commits_url":"https://api.github.com/repos/ewinslow/Elgg/commits{/sha}","git_commits_url":"https://api.github.com/repos/ewinslow/Elgg/git/commits{/sha}","comments_url":"https://api.github.com/repos/ewinslow/Elgg/comments{/number}","issue_comment_url":"https://api.github.com/repos/ewinslow/Elgg/issues/comments{/number}","contents_url":"https://api.github.com/repos/ewinslow/Elgg/contents/{+path}","compare_url":"https://api.github.com/repos/ewinslow/Elgg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ewinslow/Elgg/merges","archive_url":"https://api.github.com/repos/ewinslow/Elgg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ewinslow/Elgg/downloads","issues_url":"https://api.github.com/repos/ewinslow/Elgg/issues{/number}","pulls_url":"https://api.github.com/repos/ewinslow/Elgg/pulls{/number}","milestones_url":"https://api.github.com/repos/ewinslow/Elgg/milestones{/number}","notifications_url":"https://api.github.com/repos/ewinslow/Elgg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ewinslow/Elgg/labels{/name}","releases_url":"https://api.github.com/repos/ewinslow/Elgg/releases{/id}","created_at":"2011-03-08T16:45:41Z","updated_at":"2015-02-28T08:49:58Z","pushed_at":"2015-05-29T23:28:52Z","git_url":"git://github.com/ewinslow/Elgg.git","ssh_url":"git@github.com:ewinslow/Elgg.git","clone_url":"https://github.com/ewinslow/Elgg.git","svn_url":"https://github.com/ewinslow/Elgg","homepage":"http://elgg.org","size":41548,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"Elgg:master","ref":"master","sha":"6245f36c5e1fbc69d18023d89fc961f75ce931d5","user":{"login":"Elgg","id":79167,"avatar_url":"https://avatars.githubusercontent.com/u/79167?v=3","gravatar_id":"","url":"https://api.github.com/users/Elgg","html_url":"https://github.com/Elgg","followers_url":"https://api.github.com/users/Elgg/followers","following_url":"https://api.github.com/users/Elgg/following{/other_user}","gists_url":"https://api.github.com/users/Elgg/gists{/gist_id}","starred_url":"https://api.github.com/users/Elgg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Elgg/subscriptions","organizations_url":"https://api.github.com/users/Elgg/orgs","repos_url":"https://api.github.com/users/Elgg/repos","events_url":"https://api.github.com/users/Elgg/events{/privacy}","received_events_url":"https://api.github.com/users/Elgg/received_events","type":"Organization","site_admin":false},"repo":{"id":299271,"name":"Elgg","full_name":"Elgg/Elgg","owner":{"login":"Elgg","id":79167,"avatar_url":"https://avatars.githubusercontent.com/u/79167?v=3","gravatar_id":"","url":"https://api.github.com/users/Elgg","html_url":"https://github.com/Elgg","followers_url":"https://api.github.com/users/Elgg/followers","following_url":"https://api.github.com/users/Elgg/following{/other_user}","gists_url":"https://api.github.com/users/Elgg/gists{/gist_id}","starred_url":"https://api.github.com/users/Elgg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Elgg/subscriptions","organizations_url":"https://api.github.com/users/Elgg/orgs","repos_url":"https://api.github.com/users/Elgg/repos","events_url":"https://api.github.com/users/Elgg/events{/privacy}","received_events_url":"https://api.github.com/users/Elgg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Elgg/Elgg","description":"A social networking engine in PHP/MySQL","fork":false,"url":"https://api.github.com/repos/Elgg/Elgg","forks_url":"https://api.github.com/repos/Elgg/Elgg/forks","keys_url":"https://api.github.com/repos/Elgg/Elgg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Elgg/Elgg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Elgg/Elgg/teams","hooks_url":"https://api.github.com/repos/Elgg/Elgg/hooks","issue_events_url":"https://api.github.com/repos/Elgg/Elgg/issues/events{/number}","events_url":"https://api.github.com/repos/Elgg/Elgg/events","assignees_url":"https://api.github.com/repos/Elgg/Elgg/assignees{/user}","branches_url":"https://api.github.com/repos/Elgg/Elgg/branches{/branch}","tags_url":"https://api.github.com/repos/Elgg/Elgg/tags","blobs_url":"https://api.github.com/repos/Elgg/Elgg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Elgg/Elgg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Elgg/Elgg/git/refs{/sha}","trees_url":"https://api.github.com/repos/Elgg/Elgg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Elgg/Elgg/statuses/{sha}","languages_url":"https://api.github.com/repos/Elgg/Elgg/languages","stargazers_url":"https://api.github.com/repos/Elgg/Elgg/stargazers","contributors_url":"https://api.github.com/repos/Elgg/Elgg/contributors","subscribers_url":"https://api.github.com/repos/Elgg/Elgg/subscribers","subscription_url":"https://api.github.com/repos/Elgg/Elgg/subscription","commits_url":"https://api.github.com/repos/Elgg/Elgg/commits{/sha}","git_commits_url":"https://api.github.com/repos/Elgg/Elgg/git/commits{/sha}","comments_url":"https://api.github.com/repos/Elgg/Elgg/comments{/number}","issue_comment_url":"https://api.github.com/repos/Elgg/Elgg/issues/comments{/number}","contents_url":"https://api.github.com/repos/Elgg/Elgg/contents/{+path}","compare_url":"https://api.github.com/repos/Elgg/Elgg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Elgg/Elgg/merges","archive_url":"https://api.github.com/repos/Elgg/Elgg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Elgg/Elgg/downloads","issues_url":"https://api.github.com/repos/Elgg/Elgg/issues{/number}","pulls_url":"https://api.github.com/repos/Elgg/Elgg/pulls{/number}","milestones_url":"https://api.github.com/repos/Elgg/Elgg/milestones{/number}","notifications_url":"https://api.github.com/repos/Elgg/Elgg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Elgg/Elgg/labels{/name}","releases_url":"https://api.github.com/repos/Elgg/Elgg/releases{/id}","created_at":"2009-09-06T17:10:11Z","updated_at":"2015-05-24T10:19:00Z","pushed_at":"2015-05-29T23:28:53Z","git_url":"git://github.com/Elgg/Elgg.git","ssh_url":"git@github.com:Elgg/Elgg.git","clone_url":"https://github.com/Elgg/Elgg.git","svn_url":"https://github.com/Elgg/Elgg","homepage":"http://elgg.org","size":77728,"stargazers_count":719,"watchers_count":719,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":433,"mirror_url":null,"open_issues_count":750,"forks":433,"open_issues":750,"watchers":719,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Elgg/Elgg/pulls/8393"},"html":{"href":"https://github.com/Elgg/Elgg/pull/8393"},"issue":{"href":"https://api.github.com/repos/Elgg/Elgg/issues/8393"},"comments":{"href":"https://api.github.com/repos/Elgg/Elgg/issues/8393/comments"},"review_comments":{"href":"https://api.github.com/repos/Elgg/Elgg/pulls/8393/comments"},"review_comment":{"href":"https://api.github.com/repos/Elgg/Elgg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Elgg/Elgg/pulls/8393/commits"},"statuses":{"href":"https://api.github.com/repos/Elgg/Elgg/statuses/af685fd0de04e9d583c459ef9cfe75fc5819428d"}}}}