{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/18950","labels_url":"https://api.github.com/repos/owncloud/core/issues/18950/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/18950/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/18950/events","html_url":"https://github.com/owncloud/core/pull/18950","id":105766117,"number":18950,"title":"Store appconfig defaults if no value is present","user":{"login":"rullzer","id":45821,"avatar_url":"https://avatars.githubusercontent.com/u/45821?v=3","gravatar_id":"","url":"https://api.github.com/users/rullzer","html_url":"https://github.com/rullzer","followers_url":"https://api.github.com/users/rullzer/followers","following_url":"https://api.github.com/users/rullzer/following{/other_user}","gists_url":"https://api.github.com/users/rullzer/gists{/gist_id}","starred_url":"https://api.github.com/users/rullzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rullzer/subscriptions","organizations_url":"https://api.github.com/users/rullzer/orgs","repos_url":"https://api.github.com/users/rullzer/repos","events_url":"https://api.github.com/users/rullzer/events{/privacy}","received_events_url":"https://api.github.com/users/rullzer/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/owncloud/core/labels/2%20-%20Developing","name":"2 - Developing","color":"ededed"},{"url":"https://api.github.com/repos/owncloud/core/labels/enhancement","name":"enhancement","color":"02e10c"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/37","html_url":"https://github.com/owncloud/core/milestones/8.2-current","labels_url":"https://api.github.com/repos/owncloud/core/milestones/37/labels","id":993629,"number":37,"title":"8.2-current","description":"","creator":{"login":"craigpg","id":160667,"avatar_url":"https://avatars.githubusercontent.com/u/160667?v=3","gravatar_id":"","url":"https://api.github.com/users/craigpg","html_url":"https://github.com/craigpg","followers_url":"https://api.github.com/users/craigpg/followers","following_url":"https://api.github.com/users/craigpg/following{/other_user}","gists_url":"https://api.github.com/users/craigpg/gists{/gist_id}","starred_url":"https://api.github.com/users/craigpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigpg/subscriptions","organizations_url":"https://api.github.com/users/craigpg/orgs","repos_url":"https://api.github.com/users/craigpg/repos","events_url":"https://api.github.com/users/craigpg/events{/privacy}","received_events_url":"https://api.github.com/users/craigpg/received_events","type":"User","site_admin":false},"open_issues":632,"closed_issues":655,"state":"open","created_at":"2015-02-24T16:19:37Z","updated_at":"2015-09-10T13:26:36Z","due_on":"2015-10-20T04:00:00Z","closed_at":null},"comments":4,"created_at":"2015-09-10T09:14:10Z","updated_at":"2015-09-10T15:45:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/18950","html_url":"https://github.com/owncloud/core/pull/18950","diff_url":"https://github.com/owncloud/core/pull/18950.diff","patch_url":"https://github.com/owncloud/core/pull/18950.patch"},"body":"Before:`$appConfig->getValue('app', 'var', 'default')` if 'var' for 'app' was not in the database. Just return the default. However now if we have two places where this code is used\r\n\r\n`$appConfig->getValue('app', 'var', 'FOO')` and `$appConfig->getValue('app', 'var', 'BAR')` this can lead to very strange situations.\r\n\r\nNow a getValue will properly set the default if it is not in the database. So there is consistency again.\r\n\r\n@schiesbn the encryption migration test fail. Could you have a look at them. Since I don't use encryption I don't want to mess with that."},"comment":{"url":"https://api.github.com/repos/owncloud/core/issues/comments/139286584","html_url":"https://github.com/owncloud/core/pull/18950#issuecomment-139286584","issue_url":"https://api.github.com/repos/owncloud/core/issues/18950","id":139286584,"user":{"login":"karlitschek","id":867445,"avatar_url":"https://avatars.githubusercontent.com/u/867445?v=3","gravatar_id":"","url":"https://api.github.com/users/karlitschek","html_url":"https://github.com/karlitschek","followers_url":"https://api.github.com/users/karlitschek/followers","following_url":"https://api.github.com/users/karlitschek/following{/other_user}","gists_url":"https://api.github.com/users/karlitschek/gists{/gist_id}","starred_url":"https://api.github.com/users/karlitschek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karlitschek/subscriptions","organizations_url":"https://api.github.com/users/karlitschek/orgs","repos_url":"https://api.github.com/users/karlitschek/repos","events_url":"https://api.github.com/users/karlitschek/events{/privacy}","received_events_url":"https://api.github.com/users/karlitschek/received_events","type":"User","site_admin":false},"created_at":"2015-09-10T15:45:36Z","updated_at":"2015-09-10T15:45:36Z","body":"Let's not experiment with this now. Something for after 8.2"}}