{"action":"closed","number":1801,"pull_request":{"url":"https://api.github.com/repos/technomancy/leiningen/pulls/1801","id":27438612,"html_url":"https://github.com/technomancy/leiningen/pull/1801","diff_url":"https://github.com/technomancy/leiningen/pull/1801.diff","patch_url":"https://github.com/technomancy/leiningen/pull/1801.patch","issue_url":"https://api.github.com/repos/technomancy/leiningen/issues/1801","number":1801,"state":"closed","locked":false,"title":"Fix for retaining :uberjar-name from profiles.","user":{"login":"kephale","id":400105,"avatar_url":"https://avatars.githubusercontent.com/u/400105?v=3","gravatar_id":"","url":"https://api.github.com/users/kephale","html_url":"https://github.com/kephale","followers_url":"https://api.github.com/users/kephale/followers","following_url":"https://api.github.com/users/kephale/following{/other_user}","gists_url":"https://api.github.com/users/kephale/gists{/gist_id}","starred_url":"https://api.github.com/users/kephale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kephale/subscriptions","organizations_url":"https://api.github.com/users/kephale/orgs","repos_url":"https://api.github.com/users/kephale/repos","events_url":"https://api.github.com/users/kephale/events{/privacy}","received_events_url":"https://api.github.com/users/kephale/received_events","type":"User","site_admin":false},"body":"Hello Friendly Leiningenites,\r\n\r\nThis is a fix for the bug where :uberjar-name isn't maintained from profiles. Tests pass and :uberjar-name is maintained when set inside a profile (albeit true that :uberjar-name is explicitly retained).\r\n\r\nThe gist of changes in this pull request: reusing some of the profiles code from jar.clj inside uberjar.clj, and re-associng uberjar-name after \"preprocess-project\" is called during jar-filename extraction. The idea is that uberjar-name wasn't being used from profiles inside uberjar.clj, and it was being removed during preprocess-project as well.\r\n\r\nCheers,\r\nKyle\r\n","created_at":"2015-01-15T15:57:46Z","updated_at":"2015-01-22T15:18:50Z","closed_at":"2015-01-22T15:18:50Z","merged_at":"2015-01-22T15:18:50Z","merge_commit_sha":"2b6fe7bc13c091ecc3c431ecaaf3da940e0eab2c","assignee":{"login":"hyPiRion","id":504876,"avatar_url":"https://avatars.githubusercontent.com/u/504876?v=3","gravatar_id":"","url":"https://api.github.com/users/hyPiRion","html_url":"https://github.com/hyPiRion","followers_url":"https://api.github.com/users/hyPiRion/followers","following_url":"https://api.github.com/users/hyPiRion/following{/other_user}","gists_url":"https://api.github.com/users/hyPiRion/gists{/gist_id}","starred_url":"https://api.github.com/users/hyPiRion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyPiRion/subscriptions","organizations_url":"https://api.github.com/users/hyPiRion/orgs","repos_url":"https://api.github.com/users/hyPiRion/repos","events_url":"https://api.github.com/users/hyPiRion/events{/privacy}","received_events_url":"https://api.github.com/users/hyPiRion/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/technomancy/leiningen/pulls/1801/commits","review_comments_url":"https://api.github.com/repos/technomancy/leiningen/pulls/1801/comments","review_comment_url":"https://api.github.com/repos/technomancy/leiningen/pulls/comments/{number}","comments_url":"https://api.github.com/repos/technomancy/leiningen/issues/1801/comments","statuses_url":"https://api.github.com/repos/technomancy/leiningen/statuses/de3df01567f65a9c646ed660d8ab374e4b93d66f","head":{"label":"kephale:uberjarname","ref":"uberjarname","sha":"de3df01567f65a9c646ed660d8ab374e4b93d66f","user":{"login":"kephale","id":400105,"avatar_url":"https://avatars.githubusercontent.com/u/400105?v=3","gravatar_id":"","url":"https://api.github.com/users/kephale","html_url":"https://github.com/kephale","followers_url":"https://api.github.com/users/kephale/followers","following_url":"https://api.github.com/users/kephale/following{/other_user}","gists_url":"https://api.github.com/users/kephale/gists{/gist_id}","starred_url":"https://api.github.com/users/kephale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kephale/subscriptions","organizations_url":"https://api.github.com/users/kephale/orgs","repos_url":"https://api.github.com/users/kephale/repos","events_url":"https://api.github.com/users/kephale/events{/privacy}","received_events_url":"https://api.github.com/users/kephale/received_events","type":"User","site_admin":false},"repo":{"id":29304632,"name":"leiningen","full_name":"kephale/leiningen","owner":{"login":"kephale","id":400105,"avatar_url":"https://avatars.githubusercontent.com/u/400105?v=3","gravatar_id":"","url":"https://api.github.com/users/kephale","html_url":"https://github.com/kephale","followers_url":"https://api.github.com/users/kephale/followers","following_url":"https://api.github.com/users/kephale/following{/other_user}","gists_url":"https://api.github.com/users/kephale/gists{/gist_id}","starred_url":"https://api.github.com/users/kephale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kephale/subscriptions","organizations_url":"https://api.github.com/users/kephale/orgs","repos_url":"https://api.github.com/users/kephale/repos","events_url":"https://api.github.com/users/kephale/events{/privacy}","received_events_url":"https://api.github.com/users/kephale/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kephale/leiningen","description":"Automate Clojure projects without setting your hair on fire.","fork":true,"url":"https://api.github.com/repos/kephale/leiningen","forks_url":"https://api.github.com/repos/kephale/leiningen/forks","keys_url":"https://api.github.com/repos/kephale/leiningen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kephale/leiningen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kephale/leiningen/teams","hooks_url":"https://api.github.com/repos/kephale/leiningen/hooks","issue_events_url":"https://api.github.com/repos/kephale/leiningen/issues/events{/number}","events_url":"https://api.github.com/repos/kephale/leiningen/events","assignees_url":"https://api.github.com/repos/kephale/leiningen/assignees{/user}","branches_url":"https://api.github.com/repos/kephale/leiningen/branches{/branch}","tags_url":"https://api.github.com/repos/kephale/leiningen/tags","blobs_url":"https://api.github.com/repos/kephale/leiningen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kephale/leiningen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kephale/leiningen/git/refs{/sha}","trees_url":"https://api.github.com/repos/kephale/leiningen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kephale/leiningen/statuses/{sha}","languages_url":"https://api.github.com/repos/kephale/leiningen/languages","stargazers_url":"https://api.github.com/repos/kephale/leiningen/stargazers","contributors_url":"https://api.github.com/repos/kephale/leiningen/contributors","subscribers_url":"https://api.github.com/repos/kephale/leiningen/subscribers","subscription_url":"https://api.github.com/repos/kephale/leiningen/subscription","commits_url":"https://api.github.com/repos/kephale/leiningen/commits{/sha}","git_commits_url":"https://api.github.com/repos/kephale/leiningen/git/commits{/sha}","comments_url":"https://api.github.com/repos/kephale/leiningen/comments{/number}","issue_comment_url":"https://api.github.com/repos/kephale/leiningen/issues/comments/{number}","contents_url":"https://api.github.com/repos/kephale/leiningen/contents/{+path}","compare_url":"https://api.github.com/repos/kephale/leiningen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kephale/leiningen/merges","archive_url":"https://api.github.com/repos/kephale/leiningen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kephale/leiningen/downloads","issues_url":"https://api.github.com/repos/kephale/leiningen/issues{/number}","pulls_url":"https://api.github.com/repos/kephale/leiningen/pulls{/number}","milestones_url":"https://api.github.com/repos/kephale/leiningen/milestones{/number}","notifications_url":"https://api.github.com/repos/kephale/leiningen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kephale/leiningen/labels{/name}","releases_url":"https://api.github.com/repos/kephale/leiningen/releases{/id}","created_at":"2015-01-15T15:50:33Z","updated_at":"2015-01-15T15:50:34Z","pushed_at":"2015-01-22T13:31:39Z","git_url":"git://github.com/kephale/leiningen.git","ssh_url":"git@github.com:kephale/leiningen.git","clone_url":"https://github.com/kephale/leiningen.git","svn_url":"https://github.com/kephale/leiningen","homepage":"","size":8379,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"technomancy:master","ref":"master","sha":"24052b965235c339285c2785bf935da9359d6b67","user":{"login":"technomancy","id":141,"avatar_url":"https://avatars.githubusercontent.com/u/141?v=3","gravatar_id":"","url":"https://api.github.com/users/technomancy","html_url":"https://github.com/technomancy","followers_url":"https://api.github.com/users/technomancy/followers","following_url":"https://api.github.com/users/technomancy/following{/other_user}","gists_url":"https://api.github.com/users/technomancy/gists{/gist_id}","starred_url":"https://api.github.com/users/technomancy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/technomancy/subscriptions","organizations_url":"https://api.github.com/users/technomancy/orgs","repos_url":"https://api.github.com/users/technomancy/repos","events_url":"https://api.github.com/users/technomancy/events{/privacy}","received_events_url":"https://api.github.com/users/technomancy/received_events","type":"User","site_admin":false},"repo":{"id":356756,"name":"leiningen","full_name":"technomancy/leiningen","owner":{"login":"technomancy","id":141,"avatar_url":"https://avatars.githubusercontent.com/u/141?v=3","gravatar_id":"","url":"https://api.github.com/users/technomancy","html_url":"https://github.com/technomancy","followers_url":"https://api.github.com/users/technomancy/followers","following_url":"https://api.github.com/users/technomancy/following{/other_user}","gists_url":"https://api.github.com/users/technomancy/gists{/gist_id}","starred_url":"https://api.github.com/users/technomancy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/technomancy/subscriptions","organizations_url":"https://api.github.com/users/technomancy/orgs","repos_url":"https://api.github.com/users/technomancy/repos","events_url":"https://api.github.com/users/technomancy/events{/privacy}","received_events_url":"https://api.github.com/users/technomancy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/technomancy/leiningen","description":"Automate Clojure projects without setting your hair on fire.","fork":false,"url":"https://api.github.com/repos/technomancy/leiningen","forks_url":"https://api.github.com/repos/technomancy/leiningen/forks","keys_url":"https://api.github.com/repos/technomancy/leiningen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/technomancy/leiningen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/technomancy/leiningen/teams","hooks_url":"https://api.github.com/repos/technomancy/leiningen/hooks","issue_events_url":"https://api.github.com/repos/technomancy/leiningen/issues/events{/number}","events_url":"https://api.github.com/repos/technomancy/leiningen/events","assignees_url":"https://api.github.com/repos/technomancy/leiningen/assignees{/user}","branches_url":"https://api.github.com/repos/technomancy/leiningen/branches{/branch}","tags_url":"https://api.github.com/repos/technomancy/leiningen/tags","blobs_url":"https://api.github.com/repos/technomancy/leiningen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/technomancy/leiningen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/technomancy/leiningen/git/refs{/sha}","trees_url":"https://api.github.com/repos/technomancy/leiningen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/technomancy/leiningen/statuses/{sha}","languages_url":"https://api.github.com/repos/technomancy/leiningen/languages","stargazers_url":"https://api.github.com/repos/technomancy/leiningen/stargazers","contributors_url":"https://api.github.com/repos/technomancy/leiningen/contributors","subscribers_url":"https://api.github.com/repos/technomancy/leiningen/subscribers","subscription_url":"https://api.github.com/repos/technomancy/leiningen/subscription","commits_url":"https://api.github.com/repos/technomancy/leiningen/commits{/sha}","git_commits_url":"https://api.github.com/repos/technomancy/leiningen/git/commits{/sha}","comments_url":"https://api.github.com/repos/technomancy/leiningen/comments{/number}","issue_comment_url":"https://api.github.com/repos/technomancy/leiningen/issues/comments/{number}","contents_url":"https://api.github.com/repos/technomancy/leiningen/contents/{+path}","compare_url":"https://api.github.com/repos/technomancy/leiningen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/technomancy/leiningen/merges","archive_url":"https://api.github.com/repos/technomancy/leiningen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/technomancy/leiningen/downloads","issues_url":"https://api.github.com/repos/technomancy/leiningen/issues{/number}","pulls_url":"https://api.github.com/repos/technomancy/leiningen/pulls{/number}","milestones_url":"https://api.github.com/repos/technomancy/leiningen/milestones{/number}","notifications_url":"https://api.github.com/repos/technomancy/leiningen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/technomancy/leiningen/labels{/name}","releases_url":"https://api.github.com/repos/technomancy/leiningen/releases{/id}","created_at":"2009-11-01T05:50:07Z","updated_at":"2015-01-21T21:38:40Z","pushed_at":"2015-01-22T15:18:50Z","git_url":"git://github.com/technomancy/leiningen.git","ssh_url":"git@github.com:technomancy/leiningen.git","clone_url":"https://github.com/technomancy/leiningen.git","svn_url":"https://github.com/technomancy/leiningen","homepage":"","size":14038,"stargazers_count":3750,"watchers_count":3750,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":682,"mirror_url":null,"open_issues_count":87,"forks":682,"open_issues":87,"watchers":3750,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/technomancy/leiningen/pulls/1801"},"html":{"href":"https://github.com/technomancy/leiningen/pull/1801"},"issue":{"href":"https://api.github.com/repos/technomancy/leiningen/issues/1801"},"comments":{"href":"https://api.github.com/repos/technomancy/leiningen/issues/1801/comments"},"review_comments":{"href":"https://api.github.com/repos/technomancy/leiningen/pulls/1801/comments"},"review_comment":{"href":"https://api.github.com/repos/technomancy/leiningen/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/technomancy/leiningen/pulls/1801/commits"},"statuses":{"href":"https://api.github.com/repos/technomancy/leiningen/statuses/de3df01567f65a9c646ed660d8ab374e4b93d66f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"hyPiRion","id":504876,"avatar_url":"https://avatars.githubusercontent.com/u/504876?v=3","gravatar_id":"","url":"https://api.github.com/users/hyPiRion","html_url":"https://github.com/hyPiRion","followers_url":"https://api.github.com/users/hyPiRion/followers","following_url":"https://api.github.com/users/hyPiRion/following{/other_user}","gists_url":"https://api.github.com/users/hyPiRion/gists{/gist_id}","starred_url":"https://api.github.com/users/hyPiRion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyPiRion/subscriptions","organizations_url":"https://api.github.com/users/hyPiRion/orgs","repos_url":"https://api.github.com/users/hyPiRion/repos","events_url":"https://api.github.com/users/hyPiRion/events{/privacy}","received_events_url":"https://api.github.com/users/hyPiRion/received_events","type":"User","site_admin":false},"comments":7,"review_comments":0,"commits":2,"additions":8,"deletions":2,"changed_files":1}}