{"action":"created","comment":{"url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/45500161","id":45500161,"diff_hunk":"@@ -22,16 +22,18 @@\n \n package org.jboss.as.selfcontained;\n \n+import java.io.File;\n+\n import org.jboss.msc.service.ServiceName;\n-import org.jboss.vfs.VirtualFile;\n \n /** External content-provider for self-contained servers.\n  *\n  * @author Bob McWhirter\n+ * @author <a href=\"mailto:ropalka@redhat.com\">Richard Opalka</a>\n  */\n public interface ContentProvider {\n \n     ServiceName NAME = ServiceName.JBOSS.append( \"self-contained\", \"content-provider\" );\n \n-    VirtualFile getContent(int index);\n+    File getContent(int index);","path":"self-contained/src/main/java/org/jboss/as/selfcontained/ContentProvider.java","position":19,"original_position":19,"commit_id":"cd1b3a71ae23e7c3197bf3c9078c5eecf4ba3498","original_commit_id":"cd1b3a71ae23e7c3197bf3c9078c5eecf4ba3498","user":{"login":"bstansberry","id":299242,"avatar_url":"https://avatars.githubusercontent.com/u/299242?v=3","gravatar_id":"","url":"https://api.github.com/users/bstansberry","html_url":"https://github.com/bstansberry","followers_url":"https://api.github.com/users/bstansberry/followers","following_url":"https://api.github.com/users/bstansberry/following{/other_user}","gists_url":"https://api.github.com/users/bstansberry/gists{/gist_id}","starred_url":"https://api.github.com/users/bstansberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstansberry/subscriptions","organizations_url":"https://api.github.com/users/bstansberry/orgs","repos_url":"https://api.github.com/users/bstansberry/repos","events_url":"https://api.github.com/users/bstansberry/events{/privacy}","received_events_url":"https://api.github.com/users/bstansberry/received_events","type":"User","site_admin":false},"body":"I'm not sure if this is/isn't a breaking API change. This comment is mostly a note to Ricahrd and reviewers to check that out.","created_at":"2015-11-20T18:23:18Z","updated_at":"2015-11-20T18:23:18Z","html_url":"https://github.com/wildfly/wildfly-core/pull/1261#discussion_r45500161","pull_request_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1261","_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/45500161"},"html":{"href":"https://github.com/wildfly/wildfly-core/pull/1261#discussion_r45500161"},"pull_request":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1261"}}},"pull_request":{"url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1261","id":51367805,"html_url":"https://github.com/wildfly/wildfly-core/pull/1261","diff_url":"https://github.com/wildfly/wildfly-core/pull/1261.diff","patch_url":"https://github.com/wildfly/wildfly-core/pull/1261.patch","issue_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/1261","number":1261,"state":"open","locked":false,"title":"WFCORE-680 Eliminating dependency on JBoss VFS","user":{"login":"ropalka","id":330634,"avatar_url":"https://avatars.githubusercontent.com/u/330634?v=3","gravatar_id":"","url":"https://api.github.com/users/ropalka","html_url":"https://github.com/ropalka","followers_url":"https://api.github.com/users/ropalka/followers","following_url":"https://api.github.com/users/ropalka/following{/other_user}","gists_url":"https://api.github.com/users/ropalka/gists{/gist_id}","starred_url":"https://api.github.com/users/ropalka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ropalka/subscriptions","organizations_url":"https://api.github.com/users/ropalka/orgs","repos_url":"https://api.github.com/users/ropalka/repos","events_url":"https://api.github.com/users/ropalka/events{/privacy}","received_events_url":"https://api.github.com/users/ropalka/received_events","type":"User","site_admin":false},"body":"This PR removes Wildfly dependency on JBoss VFS API.\r\n\r\nFirst half of commits is focused on minimalizing JBoss VFS usage.\r\nSecond half replaces JBoss VFS with new alternative.\r\n\r\nThe new alternative used in this PR is ResourceLoaders framework\r\nlocated at org.jboss.as.server.loaders package.\r\nThis framework was stolen from JBoss Modules project and improved\r\nlittle bit to fit our JBoss VFS replacement needs.\r\n\r\nThis PR modifies vast majority of available structure processors.\r\nIt also rewrites Deployment Overlays feature completely.\r\nThis PR refactores code in many subsystems, so review should be careful.\r\n\r\nDuring the refactoring process I made sure all tests available in both\r\nWF and WF Core base are passing.\r\n\r\nThanks in advance for your review.\r\n","created_at":"2015-11-20T15:14:05Z","updated_at":"2015-11-20T18:23:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2f69a69aeca46919ecbadd41431a19d55091151","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1261/commits","review_comments_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1261/comments","review_comment_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/1261/comments","statuses_url":"https://api.github.com/repos/wildfly/wildfly-core/statuses/cd1b3a71ae23e7c3197bf3c9078c5eecf4ba3498","head":{"label":"ropalka:WFCORE-680","ref":"WFCORE-680","sha":"cd1b3a71ae23e7c3197bf3c9078c5eecf4ba3498","user":{"login":"ropalka","id":330634,"avatar_url":"https://avatars.githubusercontent.com/u/330634?v=3","gravatar_id":"","url":"https://api.github.com/users/ropalka","html_url":"https://github.com/ropalka","followers_url":"https://api.github.com/users/ropalka/followers","following_url":"https://api.github.com/users/ropalka/following{/other_user}","gists_url":"https://api.github.com/users/ropalka/gists{/gist_id}","starred_url":"https://api.github.com/users/ropalka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ropalka/subscriptions","organizations_url":"https://api.github.com/users/ropalka/orgs","repos_url":"https://api.github.com/users/ropalka/repos","events_url":"https://api.github.com/users/ropalka/events{/privacy}","received_events_url":"https://api.github.com/users/ropalka/received_events","type":"User","site_admin":false},"repo":{"id":22142535,"name":"wildfly-core","full_name":"ropalka/wildfly-core","owner":{"login":"ropalka","id":330634,"avatar_url":"https://avatars.githubusercontent.com/u/330634?v=3","gravatar_id":"","url":"https://api.github.com/users/ropalka","html_url":"https://github.com/ropalka","followers_url":"https://api.github.com/users/ropalka/followers","following_url":"https://api.github.com/users/ropalka/following{/other_user}","gists_url":"https://api.github.com/users/ropalka/gists{/gist_id}","starred_url":"https://api.github.com/users/ropalka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ropalka/subscriptions","organizations_url":"https://api.github.com/users/ropalka/orgs","repos_url":"https://api.github.com/users/ropalka/repos","events_url":"https://api.github.com/users/ropalka/events{/privacy}","received_events_url":"https://api.github.com/users/ropalka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ropalka/wildfly-core","description":"The core runtime that is used by the Wildfly application server","fork":true,"url":"https://api.github.com/repos/ropalka/wildfly-core","forks_url":"https://api.github.com/repos/ropalka/wildfly-core/forks","keys_url":"https://api.github.com/repos/ropalka/wildfly-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ropalka/wildfly-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ropalka/wildfly-core/teams","hooks_url":"https://api.github.com/repos/ropalka/wildfly-core/hooks","issue_events_url":"https://api.github.com/repos/ropalka/wildfly-core/issues/events{/number}","events_url":"https://api.github.com/repos/ropalka/wildfly-core/events","assignees_url":"https://api.github.com/repos/ropalka/wildfly-core/assignees{/user}","branches_url":"https://api.github.com/repos/ropalka/wildfly-core/branches{/branch}","tags_url":"https://api.github.com/repos/ropalka/wildfly-core/tags","blobs_url":"https://api.github.com/repos/ropalka/wildfly-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ropalka/wildfly-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ropalka/wildfly-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/ropalka/wildfly-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ropalka/wildfly-core/statuses/{sha}","languages_url":"https://api.github.com/repos/ropalka/wildfly-core/languages","stargazers_url":"https://api.github.com/repos/ropalka/wildfly-core/stargazers","contributors_url":"https://api.github.com/repos/ropalka/wildfly-core/contributors","subscribers_url":"https://api.github.com/repos/ropalka/wildfly-core/subscribers","subscription_url":"https://api.github.com/repos/ropalka/wildfly-core/subscription","commits_url":"https://api.github.com/repos/ropalka/wildfly-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/ropalka/wildfly-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/ropalka/wildfly-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/ropalka/wildfly-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/ropalka/wildfly-core/contents/{+path}","compare_url":"https://api.github.com/repos/ropalka/wildfly-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ropalka/wildfly-core/merges","archive_url":"https://api.github.com/repos/ropalka/wildfly-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ropalka/wildfly-core/downloads","issues_url":"https://api.github.com/repos/ropalka/wildfly-core/issues{/number}","pulls_url":"https://api.github.com/repos/ropalka/wildfly-core/pulls{/number}","milestones_url":"https://api.github.com/repos/ropalka/wildfly-core/milestones{/number}","notifications_url":"https://api.github.com/repos/ropalka/wildfly-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ropalka/wildfly-core/labels{/name}","releases_url":"https://api.github.com/repos/ropalka/wildfly-core/releases{/id}","created_at":"2014-07-23T11:02:02Z","updated_at":"2015-05-07T05:29:06Z","pushed_at":"2015-11-20T13:44:06Z","git_url":"git://github.com/ropalka/wildfly-core.git","ssh_url":"git@github.com:ropalka/wildfly-core.git","clone_url":"https://github.com/ropalka/wildfly-core.git","svn_url":"https://github.com/ropalka/wildfly-core","homepage":null,"size":45956,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wildfly:master","ref":"master","sha":"88934097aa7c1353639c2c4d2f063fab9d39d457","user":{"login":"wildfly","id":3066274,"avatar_url":"https://avatars.githubusercontent.com/u/3066274?v=3","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"repo":{"id":21394954,"name":"wildfly-core","full_name":"wildfly/wildfly-core","owner":{"login":"wildfly","id":3066274,"avatar_url":"https://avatars.githubusercontent.com/u/3066274?v=3","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wildfly/wildfly-core","description":"The core runtime that is used by the Wildfly application server","fork":false,"url":"https://api.github.com/repos/wildfly/wildfly-core","forks_url":"https://api.github.com/repos/wildfly/wildfly-core/forks","keys_url":"https://api.github.com/repos/wildfly/wildfly-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wildfly/wildfly-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wildfly/wildfly-core/teams","hooks_url":"https://api.github.com/repos/wildfly/wildfly-core/hooks","issue_events_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/events{/number}","events_url":"https://api.github.com/repos/wildfly/wildfly-core/events","assignees_url":"https://api.github.com/repos/wildfly/wildfly-core/assignees{/user}","branches_url":"https://api.github.com/repos/wildfly/wildfly-core/branches{/branch}","tags_url":"https://api.github.com/repos/wildfly/wildfly-core/tags","blobs_url":"https://api.github.com/repos/wildfly/wildfly-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wildfly/wildfly-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wildfly/wildfly-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/wildfly/wildfly-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wildfly/wildfly-core/statuses/{sha}","languages_url":"https://api.github.com/repos/wildfly/wildfly-core/languages","stargazers_url":"https://api.github.com/repos/wildfly/wildfly-core/stargazers","contributors_url":"https://api.github.com/repos/wildfly/wildfly-core/contributors","subscribers_url":"https://api.github.com/repos/wildfly/wildfly-core/subscribers","subscription_url":"https://api.github.com/repos/wildfly/wildfly-core/subscription","commits_url":"https://api.github.com/repos/wildfly/wildfly-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/wildfly/wildfly-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/wildfly/wildfly-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/wildfly/wildfly-core/contents/{+path}","compare_url":"https://api.github.com/repos/wildfly/wildfly-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wildfly/wildfly-core/merges","archive_url":"https://api.github.com/repos/wildfly/wildfly-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wildfly/wildfly-core/downloads","issues_url":"https://api.github.com/repos/wildfly/wildfly-core/issues{/number}","pulls_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls{/number}","milestones_url":"https://api.github.com/repos/wildfly/wildfly-core/milestones{/number}","notifications_url":"https://api.github.com/repos/wildfly/wildfly-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wildfly/wildfly-core/labels{/name}","releases_url":"https://api.github.com/repos/wildfly/wildfly-core/releases{/id}","created_at":"2014-07-01T16:33:34Z","updated_at":"2015-10-24T18:36:21Z","pushed_at":"2015-11-20T15:14:05Z","git_url":"git://github.com/wildfly/wildfly-core.git","ssh_url":"git@github.com:wildfly/wildfly-core.git","clone_url":"https://github.com/wildfly/wildfly-core.git","svn_url":"https://github.com/wildfly/wildfly-core","homepage":null,"size":47632,"stargazers_count":36,"watchers_count":36,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":156,"mirror_url":null,"open_issues_count":30,"forks":156,"open_issues":30,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1261"},"html":{"href":"https://github.com/wildfly/wildfly-core/pull/1261"},"issue":{"href":"https://api.github.com/repos/wildfly/wildfly-core/issues/1261"},"comments":{"href":"https://api.github.com/repos/wildfly/wildfly-core/issues/1261/comments"},"review_comments":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1261/comments"},"review_comment":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1261/commits"},"statuses":{"href":"https://api.github.com/repos/wildfly/wildfly-core/statuses/cd1b3a71ae23e7c3197bf3c9078c5eecf4ba3498"}}}}