{"action":"created","comment":{"url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/pulls/comments/43678895","id":43678895,"diff_hunk":"@@ -98,10 +114,21 @@ def get_provider_account request\n     Stormpath::Provider::AccountResolver.new(data_store).resolve_provider_account(href, request)\n   end\n \n+  def oauth_authenticate(options = {})","path":"lib/stormpath-sdk/resource/application.rb","position":53,"original_position":53,"commit_id":"9681557680c0b2e8d077961d55f49986cd6fd032","original_commit_id":"9681557680c0b2e8d077961d55f49986cd6fd032","user":{"login":"ecrisostomo","id":1820138,"avatar_url":"https://avatars.githubusercontent.com/u/1820138?v=3","gravatar_id":"","url":"https://api.github.com/users/ecrisostomo","html_url":"https://github.com/ecrisostomo","followers_url":"https://api.github.com/users/ecrisostomo/followers","following_url":"https://api.github.com/users/ecrisostomo/following{/other_user}","gists_url":"https://api.github.com/users/ecrisostomo/gists{/gist_id}","starred_url":"https://api.github.com/users/ecrisostomo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecrisostomo/subscriptions","organizations_url":"https://api.github.com/users/ecrisostomo/orgs","repos_url":"https://api.github.com/users/ecrisostomo/repos","events_url":"https://api.github.com/users/ecrisostomo/events{/privacy}","received_events_url":"https://api.github.com/users/ecrisostomo/received_events","type":"User","site_admin":false},"body":"I think this should just be called `authenticate` and we determine the type of authenticator that we need to use depending on the content of the request object. Also, I think people should be able to specify actual request objects (like `PasswordGrantRequest` or `RefreshGrantRequest`) instead of just an options array; this would be more object oriented and would produce a much cleaner code in my opinion.","created_at":"2015-11-02T20:41:19Z","updated_at":"2015-11-02T20:41:19Z","html_url":"https://github.com/stormpath/stormpath-sdk-ruby/pull/83#discussion_r43678895","pull_request_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/pulls/83","_links":{"self":{"href":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/pulls/comments/43678895"},"html":{"href":"https://github.com/stormpath/stormpath-sdk-ruby/pull/83#discussion_r43678895"},"pull_request":{"href":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/pulls/83"}}},"pull_request":{"url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/pulls/83","id":45639961,"html_url":"https://github.com/stormpath/stormpath-sdk-ruby/pull/83","diff_url":"https://github.com/stormpath/stormpath-sdk-ruby/pull/83.diff","patch_url":"https://github.com/stormpath/stormpath-sdk-ruby/pull/83.patch","issue_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/issues/83","number":83,"state":"open","locked":false,"title":"Development","user":{"login":"nikone","id":3949031,"avatar_url":"https://avatars.githubusercontent.com/u/3949031?v=3","gravatar_id":"","url":"https://api.github.com/users/nikone","html_url":"https://github.com/nikone","followers_url":"https://api.github.com/users/nikone/followers","following_url":"https://api.github.com/users/nikone/following{/other_user}","gists_url":"https://api.github.com/users/nikone/gists{/gist_id}","starred_url":"https://api.github.com/users/nikone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikone/subscriptions","organizations_url":"https://api.github.com/users/nikone/orgs","repos_url":"https://api.github.com/users/nikone/repos","events_url":"https://api.github.com/users/nikone/events{/privacy}","received_events_url":"https://api.github.com/users/nikone/received_events","type":"User","site_admin":false},"body":"This changes are for the issues marked with 1.0.0.beta.9 tag\r\nhttps://github.com/stormpath/stormpath-sdk-ruby/milestones/1.0.0.beta.9\r\n\r\nthe ID Site error callbacks issue still requires handling of the following errors\r\n\r\norganization name key does not exist\r\norganization is disabled\r\norganization is not mapped to the application\r\n\r\nthis will be added additionally\r\n","created_at":"2015-09-22T08:59:51Z","updated_at":"2015-11-02T20:41:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea14e9af3dda7b9f47f0359bc2de69ae0d11ca4b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/pulls/83/commits","review_comments_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/pulls/83/comments","review_comment_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/issues/83/comments","statuses_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/statuses/9681557680c0b2e8d077961d55f49986cd6fd032","head":{"label":"stormpath:development","ref":"development","sha":"9681557680c0b2e8d077961d55f49986cd6fd032","user":{"login":"stormpath","id":1377453,"avatar_url":"https://avatars.githubusercontent.com/u/1377453?v=3","gravatar_id":"","url":"https://api.github.com/users/stormpath","html_url":"https://github.com/stormpath","followers_url":"https://api.github.com/users/stormpath/followers","following_url":"https://api.github.com/users/stormpath/following{/other_user}","gists_url":"https://api.github.com/users/stormpath/gists{/gist_id}","starred_url":"https://api.github.com/users/stormpath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stormpath/subscriptions","organizations_url":"https://api.github.com/users/stormpath/orgs","repos_url":"https://api.github.com/users/stormpath/repos","events_url":"https://api.github.com/users/stormpath/events{/privacy}","received_events_url":"https://api.github.com/users/stormpath/received_events","type":"Organization","site_admin":false},"repo":{"id":4866246,"name":"stormpath-sdk-ruby","full_name":"stormpath/stormpath-sdk-ruby","owner":{"login":"stormpath","id":1377453,"avatar_url":"https://avatars.githubusercontent.com/u/1377453?v=3","gravatar_id":"","url":"https://api.github.com/users/stormpath","html_url":"https://github.com/stormpath","followers_url":"https://api.github.com/users/stormpath/followers","following_url":"https://api.github.com/users/stormpath/following{/other_user}","gists_url":"https://api.github.com/users/stormpath/gists{/gist_id}","starred_url":"https://api.github.com/users/stormpath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stormpath/subscriptions","organizations_url":"https://api.github.com/users/stormpath/orgs","repos_url":"https://api.github.com/users/stormpath/repos","events_url":"https://api.github.com/users/stormpath/events{/privacy}","received_events_url":"https://api.github.com/users/stormpath/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stormpath/stormpath-sdk-ruby","description":"Ruby SDK for the Stormpath User Management and Authentication REST+JSON API","fork":false,"url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby","forks_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/forks","keys_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/teams","hooks_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/hooks","issue_events_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/events","assignees_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/tags","blobs_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/languages","stargazers_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/stargazers","contributors_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/contributors","subscribers_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/subscribers","subscription_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/subscription","commits_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/merges","archive_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/downloads","issues_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/labels{/name}","releases_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/releases{/id}","created_at":"2012-07-02T23:56:08Z","updated_at":"2015-06-25T02:06:15Z","pushed_at":"2015-10-29T14:33:00Z","git_url":"git://github.com/stormpath/stormpath-sdk-ruby.git","ssh_url":"git@github.com:stormpath/stormpath-sdk-ruby.git","clone_url":"https://github.com/stormpath/stormpath-sdk-ruby.git","svn_url":"https://github.com/stormpath/stormpath-sdk-ruby","homepage":"","size":1809,"stargazers_count":18,"watchers_count":18,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":27,"forks":9,"open_issues":27,"watchers":18,"default_branch":"master"}},"base":{"label":"stormpath:master","ref":"master","sha":"54b991d79650b0b500c98ddcfd9ddfba4d4d329f","user":{"login":"stormpath","id":1377453,"avatar_url":"https://avatars.githubusercontent.com/u/1377453?v=3","gravatar_id":"","url":"https://api.github.com/users/stormpath","html_url":"https://github.com/stormpath","followers_url":"https://api.github.com/users/stormpath/followers","following_url":"https://api.github.com/users/stormpath/following{/other_user}","gists_url":"https://api.github.com/users/stormpath/gists{/gist_id}","starred_url":"https://api.github.com/users/stormpath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stormpath/subscriptions","organizations_url":"https://api.github.com/users/stormpath/orgs","repos_url":"https://api.github.com/users/stormpath/repos","events_url":"https://api.github.com/users/stormpath/events{/privacy}","received_events_url":"https://api.github.com/users/stormpath/received_events","type":"Organization","site_admin":false},"repo":{"id":4866246,"name":"stormpath-sdk-ruby","full_name":"stormpath/stormpath-sdk-ruby","owner":{"login":"stormpath","id":1377453,"avatar_url":"https://avatars.githubusercontent.com/u/1377453?v=3","gravatar_id":"","url":"https://api.github.com/users/stormpath","html_url":"https://github.com/stormpath","followers_url":"https://api.github.com/users/stormpath/followers","following_url":"https://api.github.com/users/stormpath/following{/other_user}","gists_url":"https://api.github.com/users/stormpath/gists{/gist_id}","starred_url":"https://api.github.com/users/stormpath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stormpath/subscriptions","organizations_url":"https://api.github.com/users/stormpath/orgs","repos_url":"https://api.github.com/users/stormpath/repos","events_url":"https://api.github.com/users/stormpath/events{/privacy}","received_events_url":"https://api.github.com/users/stormpath/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stormpath/stormpath-sdk-ruby","description":"Ruby SDK for the Stormpath User Management and Authentication REST+JSON API","fork":false,"url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby","forks_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/forks","keys_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/teams","hooks_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/hooks","issue_events_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/events","assignees_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/tags","blobs_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/languages","stargazers_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/stargazers","contributors_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/contributors","subscribers_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/subscribers","subscription_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/subscription","commits_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/merges","archive_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/downloads","issues_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/labels{/name}","releases_url":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/releases{/id}","created_at":"2012-07-02T23:56:08Z","updated_at":"2015-06-25T02:06:15Z","pushed_at":"2015-10-29T14:33:00Z","git_url":"git://github.com/stormpath/stormpath-sdk-ruby.git","ssh_url":"git@github.com:stormpath/stormpath-sdk-ruby.git","clone_url":"https://github.com/stormpath/stormpath-sdk-ruby.git","svn_url":"https://github.com/stormpath/stormpath-sdk-ruby","homepage":"","size":1809,"stargazers_count":18,"watchers_count":18,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":27,"forks":9,"open_issues":27,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/pulls/83"},"html":{"href":"https://github.com/stormpath/stormpath-sdk-ruby/pull/83"},"issue":{"href":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/issues/83"},"comments":{"href":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/stormpath/stormpath-sdk-ruby/statuses/9681557680c0b2e8d077961d55f49986cd6fd032"}}}}