{"action":"created","issue":{"url":"https://api.github.com/repos/Cantera/cantera/issues/274","labels_url":"https://api.github.com/repos/Cantera/cantera/issues/274/labels{/name}","comments_url":"https://api.github.com/repos/Cantera/cantera/issues/274/comments","events_url":"https://api.github.com/repos/Cantera/cantera/issues/274/events","html_url":"https://github.com/Cantera/cantera/issues/274","id":88436591,"number":274,"title":"Possibly ambiguous index \"H\" in ConstPressureReactor::componentIndex","user":{"login":"thomasfiala","id":6306137,"avatar_url":"https://avatars.githubusercontent.com/u/6306137?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasfiala","html_url":"https://github.com/thomasfiala","followers_url":"https://api.github.com/users/thomasfiala/followers","following_url":"https://api.github.com/users/thomasfiala/following{/other_user}","gists_url":"https://api.github.com/users/thomasfiala/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasfiala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasfiala/subscriptions","organizations_url":"https://api.github.com/users/thomasfiala/orgs","repos_url":"https://api.github.com/users/thomasfiala/repos","events_url":"https://api.github.com/users/thomasfiala/events{/privacy}","received_events_url":"https://api.github.com/users/thomasfiala/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-15T14:03:06Z","updated_at":"2015-06-15T19:03:59Z","closed_at":null,"body":"Using \"H\" to specify enthalpy is possibly ambiguous in functions like ConstPressureReactor::componentIndex:\r\nhttps://github.com/Cantera/cantera/blob/master/src/zeroD/ConstPressureReactor.cpp#L131\r\n\r\nIf atomic hydrogen is contained in the reaction mechanism, calling this function with the argument \"H\" will yield the index of the atomic hydrogen species, and not enthalpy.\r\n\r\nThis might apply to other parts of the code as well."},"comment":{"url":"https://api.github.com/repos/Cantera/cantera/issues/comments/112175121","html_url":"https://github.com/Cantera/cantera/issues/274#issuecomment-112175121","issue_url":"https://api.github.com/repos/Cantera/cantera/issues/274","id":112175121,"user":{"login":"speth","id":644977,"avatar_url":"https://avatars.githubusercontent.com/u/644977?v=3","gravatar_id":"","url":"https://api.github.com/users/speth","html_url":"https://github.com/speth","followers_url":"https://api.github.com/users/speth/followers","following_url":"https://api.github.com/users/speth/following{/other_user}","gists_url":"https://api.github.com/users/speth/gists{/gist_id}","starred_url":"https://api.github.com/users/speth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/speth/subscriptions","organizations_url":"https://api.github.com/users/speth/orgs","repos_url":"https://api.github.com/users/speth/repos","events_url":"https://api.github.com/users/speth/events{/privacy}","received_events_url":"https://api.github.com/users/speth/received_events","type":"User","site_admin":false},"created_at":"2015-06-15T19:03:59Z","updated_at":"2015-06-15T19:03:59Z","body":"This was the result of changes made to resolve the problem identified in #193, which is that there was no way to get the mass fraction of the species \"H\", and introduced the full names \"enthalpy\" and \"mass\" for those state variables while still allowing the short names where possible.\r\n\r\nI think using the full name \"enthalpy\" should be the preferred way of getting the enthalpy. Perhaps using \"H\" and \"m\" for enthalpy and mass should be deprecated and a warning issued? I think the other places this applies are just the implementations of ``componentIndex`` for the ``Reactor`` derived classes."}}