{"action":"created","issue":{"url":"https://api.github.com/repos/unclebob/fitnesse/issues/779","labels_url":"https://api.github.com/repos/unclebob/fitnesse/issues/779/labels{/name}","comments_url":"https://api.github.com/repos/unclebob/fitnesse/issues/779/comments","events_url":"https://api.github.com/repos/unclebob/fitnesse/issues/779/events","html_url":"https://github.com/unclebob/fitnesse/pull/779","id":98606074,"number":779,"title":"Fix bugs in Symbol text replacements","user":{"login":"six42","id":5906592,"avatar_url":"https://avatars.githubusercontent.com/u/5906592?v=3","gravatar_id":"","url":"https://api.github.com/users/six42","html_url":"https://github.com/six42","followers_url":"https://api.github.com/users/six42/followers","following_url":"https://api.github.com/users/six42/following{/other_user}","gists_url":"https://api.github.com/users/six42/gists{/gist_id}","starred_url":"https://api.github.com/users/six42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/six42/subscriptions","organizations_url":"https://api.github.com/users/six42/orgs","repos_url":"https://api.github.com/users/six42/repos","events_url":"https://api.github.com/users/six42/events{/privacy}","received_events_url":"https://api.github.com/users/six42/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/unclebob/fitnesse/milestones/13","html_url":"https://github.com/unclebob/fitnesse/milestones/Next%20release","labels_url":"https://api.github.com/repos/unclebob/fitnesse/milestones/13/labels","id":1322383,"number":13,"title":"Next release","description":"","creator":{"login":"amolenaar","id":96249,"avatar_url":"https://avatars.githubusercontent.com/u/96249?v=3","gravatar_id":"","url":"https://api.github.com/users/amolenaar","html_url":"https://github.com/amolenaar","followers_url":"https://api.github.com/users/amolenaar/followers","following_url":"https://api.github.com/users/amolenaar/following{/other_user}","gists_url":"https://api.github.com/users/amolenaar/gists{/gist_id}","starred_url":"https://api.github.com/users/amolenaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amolenaar/subscriptions","organizations_url":"https://api.github.com/users/amolenaar/orgs","repos_url":"https://api.github.com/users/amolenaar/repos","events_url":"https://api.github.com/users/amolenaar/events{/privacy}","received_events_url":"https://api.github.com/users/amolenaar/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":3,"state":"open","created_at":"2015-09-24T15:48:53Z","updated_at":"2015-09-24T16:04:34Z","due_on":null,"closed_at":null},"comments":12,"created_at":"2015-08-02T12:21:38Z","updated_at":"2015-09-27T19:05:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/unclebob/fitnesse/pulls/779","html_url":"https://github.com/unclebob/fitnesse/pull/779","diff_url":"https://github.com/unclebob/fitnesse/pull/779.diff","patch_url":"https://github.com/unclebob/fitnesse/pull/779.patch"},"body":"This PR makes usage of Symbols in TableTables very easy.\r\n\r\nIt fixes the bugs descibed in\r\nhttp://fitnesse.org/FitNesse.SuiteAcceptanceTests.SuiteSlimTests.TableTableSuite.TestTableTableImplementingStatementExecutorConsumer.TestKnownLimitations\r\n\r\nFor more complex  symbol requirements the fixture can now handle the\r\nfull symbol management itself.\r\n\r\n@jplambert this will break your tests pages you have to add another statement to make your tests pages work. Unluckily it is not possible to fix the bugs without breaking your code as you benefit from the bugs. See the new version of TestTableTableImplementingStatementExecutorConsumer for details.\r\n\r\nThe bug was mainly that the symbol pattern also matches the symbol assignment pattern.\r\nSo if $A was 44 and a cell contains the assignment $A= it was replaced by 44=. This was nothing the fixture could understand. \r\nOnly if the symbol was new no replacment happenend and the assignment was visible in the fixture.\r\n "},"comment":{"url":"https://api.github.com/repos/unclebob/fitnesse/issues/comments/143587940","html_url":"https://github.com/unclebob/fitnesse/pull/779#issuecomment-143587940","issue_url":"https://api.github.com/repos/unclebob/fitnesse/issues/779","id":143587940,"user":{"login":"amolenaar","id":96249,"avatar_url":"https://avatars.githubusercontent.com/u/96249?v=3","gravatar_id":"","url":"https://api.github.com/users/amolenaar","html_url":"https://github.com/amolenaar","followers_url":"https://api.github.com/users/amolenaar/followers","following_url":"https://api.github.com/users/amolenaar/following{/other_user}","gists_url":"https://api.github.com/users/amolenaar/gists{/gist_id}","starred_url":"https://api.github.com/users/amolenaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amolenaar/subscriptions","organizations_url":"https://api.github.com/users/amolenaar/orgs","repos_url":"https://api.github.com/users/amolenaar/repos","events_url":"https://api.github.com/users/amolenaar/events{/privacy}","received_events_url":"https://api.github.com/users/amolenaar/received_events","type":"User","site_admin":false},"created_at":"2015-09-27T19:05:43Z","updated_at":"2015-09-27T19:05:43Z","body":"@hcf @six42 Nice to see such collaboration. I expect the tests could be added and then all can be merged?"}}