{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/24564101","id":24564101,"diff_hunk":"@@ -109,7 +110,14 @@ class ExecutorRunnable(\n     }\n \n     // Send the start request to the ContainerManager\n-    nmClient.startContainer(container, ctx)\n+    try {\n+      nmClient.startContainer(container, ctx)\n+    } catch {\n+      case ex: YarnException =>\n+        logError(\"Exception while start container %s on host %s:\"","path":"yarn/src/main/scala/org/apache/spark/deploy/yarn/ExecutorRunnable.scala","position":17,"original_position":17,"commit_id":"c02140f67c8e7d36675b3ec20f27d25e456900be","original_commit_id":"c02140f67c8e7d36675b3ec20f27d25e456900be","user":{"login":"sryza","id":654855,"avatar_url":"https://avatars.githubusercontent.com/u/654855?v=3","gravatar_id":"","url":"https://api.github.com/users/sryza","html_url":"https://github.com/sryza","followers_url":"https://api.github.com/users/sryza/followers","following_url":"https://api.github.com/users/sryza/following{/other_user}","gists_url":"https://api.github.com/users/sryza/gists{/gist_id}","starred_url":"https://api.github.com/users/sryza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sryza/subscriptions","organizations_url":"https://api.github.com/users/sryza/orgs","repos_url":"https://api.github.com/users/sryza/repos","events_url":"https://api.github.com/users/sryza/events{/privacy}","received_events_url":"https://api.github.com/users/sryza/received_events","type":"User","site_admin":false},"body":"Also, a couple nits: we should use String interpolation instead of `.format`, and \"start\" should be \"starting\".","created_at":"2015-02-12T08:07:09Z","updated_at":"2015-02-12T08:07:09Z","html_url":"https://github.com/apache/spark/pull/4554#discussion_r24564101","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/4554","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/24564101"},"html":{"href":"https://github.com/apache/spark/pull/4554#discussion_r24564101"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/4554"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/4554","id":29157467,"html_url":"https://github.com/apache/spark/pull/4554","diff_url":"https://github.com/apache/spark/pull/4554.diff","patch_url":"https://github.com/apache/spark/pull/4554.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/4554","number":4554,"state":"open","locked":false,"title":"[SPARK-5759][Yarn]ExecutorRunnable should catch YarnException while NMClient start contain...","user":{"login":"lianhuiwang","id":545478,"avatar_url":"https://avatars.githubusercontent.com/u/545478?v=3","gravatar_id":"","url":"https://api.github.com/users/lianhuiwang","html_url":"https://github.com/lianhuiwang","followers_url":"https://api.github.com/users/lianhuiwang/followers","following_url":"https://api.github.com/users/lianhuiwang/following{/other_user}","gists_url":"https://api.github.com/users/lianhuiwang/gists{/gist_id}","starred_url":"https://api.github.com/users/lianhuiwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lianhuiwang/subscriptions","organizations_url":"https://api.github.com/users/lianhuiwang/orgs","repos_url":"https://api.github.com/users/lianhuiwang/repos","events_url":"https://api.github.com/users/lianhuiwang/events{/privacy}","received_events_url":"https://api.github.com/users/lianhuiwang/received_events","type":"User","site_admin":false},"body":"some time since some reasons, it lead to some exception while NMClient start some containers.example:we do not config spark_shuffle on some machines, so it will throw a exception:\r\njava.lang.Error: org.apache.hadoop.yarn.exceptions.InvalidAuxServiceException: The auxService:spark_shuffle does not exist.\r\nbecause YarnAllocator use ThreadPoolExecutor to start Container, so we can not find which container or hostname throw exception. I think we should catch YarnException in ExecutorRunnable when start container. if there are some exceptions, we can know the container id or hostname of failed container.","created_at":"2015-02-12T07:15:57Z","updated_at":"2015-02-12T08:07:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a812c2a1d556989959b804213f3e23628a31968b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/4554/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/4554/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments/{number}","comments_url":"https://api.github.com/repos/apache/spark/issues/4554/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/c02140f67c8e7d36675b3ec20f27d25e456900be","head":{"label":"lianhuiwang:SPARK-5759","ref":"SPARK-5759","sha":"c02140f67c8e7d36675b3ec20f27d25e456900be","user":{"login":"lianhuiwang","id":545478,"avatar_url":"https://avatars.githubusercontent.com/u/545478?v=3","gravatar_id":"","url":"https://api.github.com/users/lianhuiwang","html_url":"https://github.com/lianhuiwang","followers_url":"https://api.github.com/users/lianhuiwang/followers","following_url":"https://api.github.com/users/lianhuiwang/following{/other_user}","gists_url":"https://api.github.com/users/lianhuiwang/gists{/gist_id}","starred_url":"https://api.github.com/users/lianhuiwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lianhuiwang/subscriptions","organizations_url":"https://api.github.com/users/lianhuiwang/orgs","repos_url":"https://api.github.com/users/lianhuiwang/repos","events_url":"https://api.github.com/users/lianhuiwang/events{/privacy}","received_events_url":"https://api.github.com/users/lianhuiwang/received_events","type":"User","site_admin":false},"repo":{"id":20906966,"name":"spark","full_name":"lianhuiwang/spark","owner":{"login":"lianhuiwang","id":545478,"avatar_url":"https://avatars.githubusercontent.com/u/545478?v=3","gravatar_id":"","url":"https://api.github.com/users/lianhuiwang","html_url":"https://github.com/lianhuiwang","followers_url":"https://api.github.com/users/lianhuiwang/followers","following_url":"https://api.github.com/users/lianhuiwang/following{/other_user}","gists_url":"https://api.github.com/users/lianhuiwang/gists{/gist_id}","starred_url":"https://api.github.com/users/lianhuiwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lianhuiwang/subscriptions","organizations_url":"https://api.github.com/users/lianhuiwang/orgs","repos_url":"https://api.github.com/users/lianhuiwang/repos","events_url":"https://api.github.com/users/lianhuiwang/events{/privacy}","received_events_url":"https://api.github.com/users/lianhuiwang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lianhuiwang/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/lianhuiwang/spark","forks_url":"https://api.github.com/repos/lianhuiwang/spark/forks","keys_url":"https://api.github.com/repos/lianhuiwang/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lianhuiwang/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lianhuiwang/spark/teams","hooks_url":"https://api.github.com/repos/lianhuiwang/spark/hooks","issue_events_url":"https://api.github.com/repos/lianhuiwang/spark/issues/events{/number}","events_url":"https://api.github.com/repos/lianhuiwang/spark/events","assignees_url":"https://api.github.com/repos/lianhuiwang/spark/assignees{/user}","branches_url":"https://api.github.com/repos/lianhuiwang/spark/branches{/branch}","tags_url":"https://api.github.com/repos/lianhuiwang/spark/tags","blobs_url":"https://api.github.com/repos/lianhuiwang/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lianhuiwang/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lianhuiwang/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/lianhuiwang/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lianhuiwang/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/lianhuiwang/spark/languages","stargazers_url":"https://api.github.com/repos/lianhuiwang/spark/stargazers","contributors_url":"https://api.github.com/repos/lianhuiwang/spark/contributors","subscribers_url":"https://api.github.com/repos/lianhuiwang/spark/subscribers","subscription_url":"https://api.github.com/repos/lianhuiwang/spark/subscription","commits_url":"https://api.github.com/repos/lianhuiwang/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/lianhuiwang/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/lianhuiwang/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/lianhuiwang/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/lianhuiwang/spark/contents/{+path}","compare_url":"https://api.github.com/repos/lianhuiwang/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lianhuiwang/spark/merges","archive_url":"https://api.github.com/repos/lianhuiwang/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lianhuiwang/spark/downloads","issues_url":"https://api.github.com/repos/lianhuiwang/spark/issues{/number}","pulls_url":"https://api.github.com/repos/lianhuiwang/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/lianhuiwang/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/lianhuiwang/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lianhuiwang/spark/labels{/name}","releases_url":"https://api.github.com/repos/lianhuiwang/spark/releases{/id}","created_at":"2014-06-17T02:01:23Z","updated_at":"2014-07-13T14:14:36Z","pushed_at":"2015-02-12T07:14:16Z","git_url":"git://github.com/lianhuiwang/spark.git","ssh_url":"git@github.com:lianhuiwang/spark.git","clone_url":"https://github.com/lianhuiwang/spark.git","svn_url":"https://github.com/lianhuiwang/spark","homepage":null,"size":88463,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"a38e23c30fb5d12f8f46a119d91a0620036e6800","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-02-12T06:14:08Z","pushed_at":"2015-02-12T03:06:23Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1270127,"stargazers_count":2853,"watchers_count":2853,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2505,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":283,"forks":2505,"open_issues":283,"watchers":2853,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/4554"},"html":{"href":"https://github.com/apache/spark/pull/4554"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/4554"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/4554/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/4554/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/4554/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/c02140f67c8e7d36675b3ec20f27d25e456900be"}}}}