{"action":"created","issue":{"url":"https://api.github.com/repos/uber/tchannel-java/issues/48","labels_url":"https://api.github.com/repos/uber/tchannel-java/issues/48/labels{/name}","comments_url":"https://api.github.com/repos/uber/tchannel-java/issues/48/comments","events_url":"https://api.github.com/repos/uber/tchannel-java/issues/48/events","html_url":"https://github.com/uber/tchannel-java/issues/48","id":103164856,"number":48,"title":"TChannel behavior with ttl 0","user":{"login":"truncs","id":157234,"avatar_url":"https://avatars.githubusercontent.com/u/157234?v=3","gravatar_id":"","url":"https://api.github.com/users/truncs","html_url":"https://github.com/truncs","followers_url":"https://api.github.com/users/truncs/followers","following_url":"https://api.github.com/users/truncs/following{/other_user}","gists_url":"https://api.github.com/users/truncs/gists{/gist_id}","starred_url":"https://api.github.com/users/truncs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/truncs/subscriptions","organizations_url":"https://api.github.com/users/truncs/orgs","repos_url":"https://api.github.com/users/truncs/repos","events_url":"https://api.github.com/users/truncs/events{/privacy}","received_events_url":"https://api.github.com/users/truncs/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/uber/tchannel-java/labels/bug","name":"bug","color":"fc2929"}],"state":"closed","locked":false,"assignee":{"login":"willsalz","id":1295795,"avatar_url":"https://avatars.githubusercontent.com/u/1295795?v=3","gravatar_id":"","url":"https://api.github.com/users/willsalz","html_url":"https://github.com/willsalz","followers_url":"https://api.github.com/users/willsalz/followers","following_url":"https://api.github.com/users/willsalz/following{/other_user}","gists_url":"https://api.github.com/users/willsalz/gists{/gist_id}","starred_url":"https://api.github.com/users/willsalz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willsalz/subscriptions","organizations_url":"https://api.github.com/users/willsalz/orgs","repos_url":"https://api.github.com/users/willsalz/repos","events_url":"https://api.github.com/users/willsalz/events{/privacy}","received_events_url":"https://api.github.com/users/willsalz/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/uber/tchannel-java/milestones/3","html_url":"https://github.com/uber/tchannel-java/milestones/v2","labels_url":"https://api.github.com/repos/uber/tchannel-java/milestones/3/labels","id":1230340,"number":3,"title":"v2","description":"tchannel4j v2 represents a more polished and complete TChannel implementation.\r\n\r\nSlated for v2:\r\n- Perf!\r\n- Message Claiming\r\n- Message Canceling\r\n- HTTP Arg Scheme","creator":{"login":"willsalz","id":1295795,"avatar_url":"https://avatars.githubusercontent.com/u/1295795?v=3","gravatar_id":"","url":"https://api.github.com/users/willsalz","html_url":"https://github.com/willsalz","followers_url":"https://api.github.com/users/willsalz/followers","following_url":"https://api.github.com/users/willsalz/following{/other_user}","gists_url":"https://api.github.com/users/willsalz/gists{/gist_id}","starred_url":"https://api.github.com/users/willsalz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willsalz/subscriptions","organizations_url":"https://api.github.com/users/willsalz/orgs","repos_url":"https://api.github.com/users/willsalz/repos","events_url":"https://api.github.com/users/willsalz/events{/privacy}","received_events_url":"https://api.github.com/users/willsalz/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":2,"state":"open","created_at":"2015-07-28T21:37:27Z","updated_at":"2015-08-31T20:35:52Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2015-08-26T03:36:48Z","updated_at":"2015-08-31T20:35:52Z","closed_at":"2015-08-31T20:35:52Z","body":"I was testing some stuff on hyperbahn when I found this\r\n\r\nTchannelProtocolInvalidTtlError: Got an invalid ttl. Expected positive ttl but got 0\r\n00: 0090 0300 0000 0000 0000 0000 0000 0000  ................  UInt16BE(144) UInt8(3) UInt32BE(0)\r\n10: 0000 0000 0000 0000 0000 0000 0000 0000  ................  UInt8(0) UInt32BE(0)\r\n20: 0000 0000 0000 0000 0000 0000 0000 0968  ...............h\r\n30: 7970 6572 6261 686e 0202 636e 0b70 696e  yperbahn..cn.pin\r\n40: 672d 7365 7276 6572 0261 7304 6a73 6f6e  g-server.as.json\r\n50: 0000 0261 6400 027b 7d00 357b 2273 6572  ...ad..{}.5{\"ser\r\n60: 7669 6365 7322 3a5b 7b22 7365 7276 6963  vices\":[{\"servic\r\n70: 654e 616d 6522 3a22 7069 6e67 2d73 6572  eName\":\"ping-ser\r\n80: 7665 7222 2c22 636f 7374 223a 307d 5d7d  ver\",\"cost\":0}]}\r\nsession=3 127.0.0.1:56981 <-- 127.0.0.1:21306 frame=4294967295 type=0xff\r\nERROR[ProtocolError] id=0xffffffff (4294967295)\r\ntracing: spanid=0000000000000000 parentid=0000000000000000 traceid=0000000000000000 flags=0x00\r\nmessage\r\n    00: 7463 6861 6e6e 656c 2072 6561 6420 6661  tchannel read fa\r\n    10: 696c 7572 653a 2047 6f74 2061 6e20 696e  ilure: Got an in\r\n    20: 7661 6c69 6420 7474 6c2e 2045 7870 6563  valid ttl. Expec\r\n    30: 7465 6420 706f 7369 7469 7665 2074 746c  ted positive ttl\r\n    40: 2062 7574 2067 6f74 2030                  but got 0\r\n\r\n\r\nSo I am not sure if this is defined somewhere in the protocol but if that is the case for every tchannel then\r\n\r\n1) Clients should not be able to make requests with 0 ttl\r\n2) Server should raise an error if it receives any requests with 0 ttl\r\n3) There should be some sane default for this ?"},"comment":{"url":"https://api.github.com/repos/uber/tchannel-java/issues/comments/136491617","html_url":"https://github.com/uber/tchannel-java/issues/48#issuecomment-136491617","issue_url":"https://api.github.com/repos/uber/tchannel-java/issues/48","id":136491617,"user":{"login":"willsalz","id":1295795,"avatar_url":"https://avatars.githubusercontent.com/u/1295795?v=3","gravatar_id":"","url":"https://api.github.com/users/willsalz","html_url":"https://github.com/willsalz","followers_url":"https://api.github.com/users/willsalz/followers","following_url":"https://api.github.com/users/willsalz/following{/other_user}","gists_url":"https://api.github.com/users/willsalz/gists{/gist_id}","starred_url":"https://api.github.com/users/willsalz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willsalz/subscriptions","organizations_url":"https://api.github.com/users/willsalz/orgs","repos_url":"https://api.github.com/users/willsalz/repos","events_url":"https://api.github.com/users/willsalz/events{/privacy}","received_events_url":"https://api.github.com/users/willsalz/received_events","type":"User","site_admin":false},"created_at":"2015-08-31T20:35:52Z","updated_at":"2015-08-31T20:35:52Z","body":"#52 merged."}}