{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/46331948","id":46331948,"diff_hunk":"@@ -125,8 +126,7 @@ CBlockTemplate* CreateNewBlock(const CChainParams& chainparams, const CScript& s\n     pblocktemplate->vTxFees.push_back(-1); // updated at end\n     pblocktemplate->vTxSigOps.push_back(-1); // updated at end\n \n-    // Largest block you're willing to create:\n-    unsigned int nBlockMaxSize = GetArg(\"-blockmaxsize\", DEFAULT_BLOCK_MAX_SIZE);\n+    // Largest block you're willing to create\n     // Limit to betweeen 1K and MAX_BLOCK_SIZE-1K for sanity:\n     nBlockMaxSize = std::max((unsigned int)1000, std::min((unsigned int)(MAX_BLOCK_SIZE-1000), nBlockMaxSize));","path":"src/miner.cpp","position":16,"original_position":16,"commit_id":"2c79653121e5c4699241c690dc14d3e5c25220c6","original_commit_id":"2c79653121e5c4699241c690dc14d3e5c25220c6","user":{"login":"sipa","id":548488,"avatar_url":"https://avatars.githubusercontent.com/u/548488?v=3","gravatar_id":"","url":"https://api.github.com/users/sipa","html_url":"https://github.com/sipa","followers_url":"https://api.github.com/users/sipa/followers","following_url":"https://api.github.com/users/sipa/following{/other_user}","gists_url":"https://api.github.com/users/sipa/gists{/gist_id}","starred_url":"https://api.github.com/users/sipa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sipa/subscriptions","organizations_url":"https://api.github.com/users/sipa/orgs","repos_url":"https://api.github.com/users/sipa/repos","events_url":"https://api.github.com/users/sipa/events{/privacy}","received_events_url":"https://api.github.com/users/sipa/received_events","type":"User","site_admin":false},"body":"This line now mutates a global variable. I think you should make a copy first.","created_at":"2015-12-01T20:11:48Z","updated_at":"2015-12-01T20:11:48Z","html_url":"https://github.com/bitcoin/bitcoin/pull/7131#discussion_r46331948","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7131","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/46331948"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/7131#discussion_r46331948"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7131"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7131","id":52082977,"html_url":"https://github.com/bitcoin/bitcoin/pull/7131","diff_url":"https://github.com/bitcoin/bitcoin/pull/7131.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/7131.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7131","number":7131,"state":"open","locked":false,"title":"Add 'setblockmaxsize' RPC interface","user":{"login":"jtoomim","id":11898859,"avatar_url":"https://avatars.githubusercontent.com/u/11898859?v=3","gravatar_id":"","url":"https://api.github.com/users/jtoomim","html_url":"https://github.com/jtoomim","followers_url":"https://api.github.com/users/jtoomim/followers","following_url":"https://api.github.com/users/jtoomim/following{/other_user}","gists_url":"https://api.github.com/users/jtoomim/gists{/gist_id}","starred_url":"https://api.github.com/users/jtoomim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtoomim/subscriptions","organizations_url":"https://api.github.com/users/jtoomim/orgs","repos_url":"https://api.github.com/users/jtoomim/repos","events_url":"https://api.github.com/users/jtoomim/events{/privacy}","received_events_url":"https://api.github.com/users/jtoomim/received_events","type":"User","site_admin":false},"body":"Verified as functional on testnet. (You need a new transaction to enter mempool after running `bitcoin-cli setblockmaxsize x` and before running getblocktemplate, otherwise GBT will just use the cached template.)\r\n\r\nThis patch was discussed briefly on IRC about 20 hours ago. http://bitcoinstats.com/irc/bitcoin-dev/logs/2015/11/29","created_at":"2015-11-30T03:51:00Z","updated_at":"2015-12-01T20:11:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ccb228c2d2ae109d80c48038293f1eeab08dea97","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7131/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7131/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7131/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/2c79653121e5c4699241c690dc14d3e5c25220c6","head":{"label":"jtoomim:setblockmaxsize","ref":"setblockmaxsize","sha":"2c79653121e5c4699241c690dc14d3e5c25220c6","user":{"login":"jtoomim","id":11898859,"avatar_url":"https://avatars.githubusercontent.com/u/11898859?v=3","gravatar_id":"","url":"https://api.github.com/users/jtoomim","html_url":"https://github.com/jtoomim","followers_url":"https://api.github.com/users/jtoomim/followers","following_url":"https://api.github.com/users/jtoomim/following{/other_user}","gists_url":"https://api.github.com/users/jtoomim/gists{/gist_id}","starred_url":"https://api.github.com/users/jtoomim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtoomim/subscriptions","organizations_url":"https://api.github.com/users/jtoomim/orgs","repos_url":"https://api.github.com/users/jtoomim/repos","events_url":"https://api.github.com/users/jtoomim/events{/privacy}","received_events_url":"https://api.github.com/users/jtoomim/received_events","type":"User","site_admin":false},"repo":{"id":47093750,"name":"bitcoin","full_name":"jtoomim/bitcoin","owner":{"login":"jtoomim","id":11898859,"avatar_url":"https://avatars.githubusercontent.com/u/11898859?v=3","gravatar_id":"","url":"https://api.github.com/users/jtoomim","html_url":"https://github.com/jtoomim","followers_url":"https://api.github.com/users/jtoomim/followers","following_url":"https://api.github.com/users/jtoomim/following{/other_user}","gists_url":"https://api.github.com/users/jtoomim/gists{/gist_id}","starred_url":"https://api.github.com/users/jtoomim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtoomim/subscriptions","organizations_url":"https://api.github.com/users/jtoomim/orgs","repos_url":"https://api.github.com/users/jtoomim/repos","events_url":"https://api.github.com/users/jtoomim/events{/privacy}","received_events_url":"https://api.github.com/users/jtoomim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jtoomim/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/jtoomim/bitcoin","forks_url":"https://api.github.com/repos/jtoomim/bitcoin/forks","keys_url":"https://api.github.com/repos/jtoomim/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jtoomim/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jtoomim/bitcoin/teams","hooks_url":"https://api.github.com/repos/jtoomim/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/jtoomim/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/jtoomim/bitcoin/events","assignees_url":"https://api.github.com/repos/jtoomim/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/jtoomim/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/jtoomim/bitcoin/tags","blobs_url":"https://api.github.com/repos/jtoomim/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jtoomim/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jtoomim/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jtoomim/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jtoomim/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/jtoomim/bitcoin/languages","stargazers_url":"https://api.github.com/repos/jtoomim/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/jtoomim/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/jtoomim/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/jtoomim/bitcoin/subscription","commits_url":"https://api.github.com/repos/jtoomim/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jtoomim/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jtoomim/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jtoomim/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jtoomim/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/jtoomim/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jtoomim/bitcoin/merges","archive_url":"https://api.github.com/repos/jtoomim/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jtoomim/bitcoin/downloads","issues_url":"https://api.github.com/repos/jtoomim/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/jtoomim/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/jtoomim/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/jtoomim/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jtoomim/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/jtoomim/bitcoin/releases{/id}","created_at":"2015-11-30T03:43:31Z","updated_at":"2015-11-30T03:43:44Z","pushed_at":"2015-11-30T03:47:45Z","git_url":"git://github.com/jtoomim/bitcoin.git","ssh_url":"git@github.com:jtoomim/bitcoin.git","clone_url":"https://github.com/jtoomim/bitcoin.git","svn_url":"https://github.com/jtoomim/bitcoin","homepage":"https://bitcoin.org/en/download","size":60110,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"5d5ef3a4cf8e32cdf584811eb5415278f4ba9628","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","created_at":"2010-12-19T15:16:43Z","updated_at":"2015-12-01T11:16:15Z","pushed_at":"2015-12-01T19:56:46Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":99459,"stargazers_count":7902,"watchers_count":7902,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":5423,"mirror_url":null,"open_issues_count":403,"forks":5423,"open_issues":403,"watchers":7902,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7131"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/7131"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/7131"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/7131/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7131/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7131/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/2c79653121e5c4699241c690dc14d3e5c25220c6"}}}}