{"action":"created","issue":{"url":"https://api.github.com/repos/piwik/piwik/issues/8830","labels_url":"https://api.github.com/repos/piwik/piwik/issues/8830/labels{/name}","comments_url":"https://api.github.com/repos/piwik/piwik/issues/8830/comments","events_url":"https://api.github.com/repos/piwik/piwik/issues/8830/events","html_url":"https://github.com/piwik/piwik/pull/8830","id":107431878,"number":8830,"title":"Add missing error control operator prefix '@' before ini_set()","user":{"login":"Joey3000","id":3662335,"avatar_url":"https://avatars.githubusercontent.com/u/3662335?v=3","gravatar_id":"","url":"https://api.github.com/users/Joey3000","html_url":"https://github.com/Joey3000","followers_url":"https://api.github.com/users/Joey3000/followers","following_url":"https://api.github.com/users/Joey3000/following{/other_user}","gists_url":"https://api.github.com/users/Joey3000/gists{/gist_id}","starred_url":"https://api.github.com/users/Joey3000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joey3000/subscriptions","organizations_url":"https://api.github.com/users/Joey3000/orgs","repos_url":"https://api.github.com/users/Joey3000/repos","events_url":"https://api.github.com/users/Joey3000/events{/privacy}","received_events_url":"https://api.github.com/users/Joey3000/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/piwik/piwik/labels/Bug","name":"Bug","color":"fc2929"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-09-21T02:07:39Z","updated_at":"2015-11-11T23:45:42Z","closed_at":"2015-09-21T09:08:23Z","pull_request":{"url":"https://api.github.com/repos/piwik/piwik/pulls/8830","html_url":"https://github.com/piwik/piwik/pull/8830","diff_url":"https://github.com/piwik/piwik/pull/8830.diff","patch_url":"https://github.com/piwik/piwik/pull/8830.patch"},"body":"Background: https://github.com/piwik/piwik/issues/8824#issuecomment-141843420\r\n\r\nThis PR adds `@` where missing before `ini_set()`.\r\n\r\n**Important:**\r\nThe ini_set() presence check-and-show-error block in https://github.com/piwik/piwik/blob/2.15.0-b8/core/testMinimumPhpVersion.php#L35 is **not** being modified by this PR. Please let me know if it needs to be removed."},"comment":{"url":"https://api.github.com/repos/piwik/piwik/issues/comments/155946368","html_url":"https://github.com/piwik/piwik/pull/8830#issuecomment-155946368","issue_url":"https://api.github.com/repos/piwik/piwik/issues/8830","id":155946368,"user":{"login":"cdwiegand","id":121301,"avatar_url":"https://avatars.githubusercontent.com/u/121301?v=3","gravatar_id":"","url":"https://api.github.com/users/cdwiegand","html_url":"https://github.com/cdwiegand","followers_url":"https://api.github.com/users/cdwiegand/followers","following_url":"https://api.github.com/users/cdwiegand/following{/other_user}","gists_url":"https://api.github.com/users/cdwiegand/gists{/gist_id}","starred_url":"https://api.github.com/users/cdwiegand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdwiegand/subscriptions","organizations_url":"https://api.github.com/users/cdwiegand/orgs","repos_url":"https://api.github.com/users/cdwiegand/repos","events_url":"https://api.github.com/users/cdwiegand/events{/privacy}","received_events_url":"https://api.github.com/users/cdwiegand/received_events","type":"User","site_admin":false},"created_at":"2015-11-11T23:45:42Z","updated_at":"2015-11-11T23:45:42Z","body":"Can we remove the ini_set check entirely? We also have ini_set disabled for security reasons (WordPress blog hacks LOVE to use ini_set to hide themselves from causing errors), and so I have to patch piwik every release internally before I can push out updates. I find piwik works just fine with ini_set disabled so long as session handling is working correctly."}}