{"action":"closed","number":563,"pull_request":{"url":"https://api.github.com/repos/falconry/falcon/pulls/563","id":39746161,"html_url":"https://github.com/falconry/falcon/pull/563","diff_url":"https://github.com/falconry/falcon/pull/563.diff","patch_url":"https://github.com/falconry/falcon/pull/563.patch","issue_url":"https://api.github.com/repos/falconry/falcon/issues/563","number":563,"state":"closed","locked":false,"title":"Instruct browser to remove cookies","user":{"login":"Freezerburn","id":1703084,"avatar_url":"https://avatars.githubusercontent.com/u/1703084?v=3","gravatar_id":"","url":"https://api.github.com/users/Freezerburn","html_url":"https://github.com/Freezerburn","followers_url":"https://api.github.com/users/Freezerburn/followers","following_url":"https://api.github.com/users/Freezerburn/following{/other_user}","gists_url":"https://api.github.com/users/Freezerburn/gists{/gist_id}","starred_url":"https://api.github.com/users/Freezerburn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Freezerburn/subscriptions","organizations_url":"https://api.github.com/users/Freezerburn/orgs","repos_url":"https://api.github.com/users/Freezerburn/repos","events_url":"https://api.github.com/users/Freezerburn/events{/privacy}","received_events_url":"https://api.github.com/users/Freezerburn/received_events","type":"User","site_admin":false},"body":"fix: Cookies not being removed from browser\r\n\r\nThe previous behavior of Response's unset_cookie function was just to delete the given name from the SimpleCookie object if it existed. However, this causes a problem in that the browser is not told to remove the cookie on its side, causing all future Request objects to still contain the cookie that was supposed to have been unset/removed. This change causes the Response object to actually set the expires token for the cookie that is being unset to a point in the past, causing the browser to immediately remove the now-expired cookie, which will remove the cookie from future Request objects.","created_at":"2015-07-11T13:50:37Z","updated_at":"2015-10-16T17:56:07Z","closed_at":"2015-10-16T17:56:07Z","merged_at":null,"merge_commit_sha":"d75d84c8941e65cef161da8c3747b66eb1d0fb44","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/falconry/falcon/pulls/563/commits","review_comments_url":"https://api.github.com/repos/falconry/falcon/pulls/563/comments","review_comment_url":"https://api.github.com/repos/falconry/falcon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/falconry/falcon/issues/563/comments","statuses_url":"https://api.github.com/repos/falconry/falcon/statuses/d6ff65844d23d9a82d4da6cd39665c34608ab8ff","head":{"label":"Freezerburn:patch-1","ref":"patch-1","sha":"d6ff65844d23d9a82d4da6cd39665c34608ab8ff","user":{"login":"Freezerburn","id":1703084,"avatar_url":"https://avatars.githubusercontent.com/u/1703084?v=3","gravatar_id":"","url":"https://api.github.com/users/Freezerburn","html_url":"https://github.com/Freezerburn","followers_url":"https://api.github.com/users/Freezerburn/followers","following_url":"https://api.github.com/users/Freezerburn/following{/other_user}","gists_url":"https://api.github.com/users/Freezerburn/gists{/gist_id}","starred_url":"https://api.github.com/users/Freezerburn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Freezerburn/subscriptions","organizations_url":"https://api.github.com/users/Freezerburn/orgs","repos_url":"https://api.github.com/users/Freezerburn/repos","events_url":"https://api.github.com/users/Freezerburn/events{/privacy}","received_events_url":"https://api.github.com/users/Freezerburn/received_events","type":"User","site_admin":false},"repo":{"id":38281540,"name":"falcon","full_name":"Freezerburn/falcon","owner":{"login":"Freezerburn","id":1703084,"avatar_url":"https://avatars.githubusercontent.com/u/1703084?v=3","gravatar_id":"","url":"https://api.github.com/users/Freezerburn","html_url":"https://github.com/Freezerburn","followers_url":"https://api.github.com/users/Freezerburn/followers","following_url":"https://api.github.com/users/Freezerburn/following{/other_user}","gists_url":"https://api.github.com/users/Freezerburn/gists{/gist_id}","starred_url":"https://api.github.com/users/Freezerburn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Freezerburn/subscriptions","organizations_url":"https://api.github.com/users/Freezerburn/orgs","repos_url":"https://api.github.com/users/Freezerburn/repos","events_url":"https://api.github.com/users/Freezerburn/events{/privacy}","received_events_url":"https://api.github.com/users/Freezerburn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Freezerburn/falcon","description":"Falcon is a high-performance Python framework for building cloud APIs, smart proxies, and app backends.","fork":true,"url":"https://api.github.com/repos/Freezerburn/falcon","forks_url":"https://api.github.com/repos/Freezerburn/falcon/forks","keys_url":"https://api.github.com/repos/Freezerburn/falcon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Freezerburn/falcon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Freezerburn/falcon/teams","hooks_url":"https://api.github.com/repos/Freezerburn/falcon/hooks","issue_events_url":"https://api.github.com/repos/Freezerburn/falcon/issues/events{/number}","events_url":"https://api.github.com/repos/Freezerburn/falcon/events","assignees_url":"https://api.github.com/repos/Freezerburn/falcon/assignees{/user}","branches_url":"https://api.github.com/repos/Freezerburn/falcon/branches{/branch}","tags_url":"https://api.github.com/repos/Freezerburn/falcon/tags","blobs_url":"https://api.github.com/repos/Freezerburn/falcon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Freezerburn/falcon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Freezerburn/falcon/git/refs{/sha}","trees_url":"https://api.github.com/repos/Freezerburn/falcon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Freezerburn/falcon/statuses/{sha}","languages_url":"https://api.github.com/repos/Freezerburn/falcon/languages","stargazers_url":"https://api.github.com/repos/Freezerburn/falcon/stargazers","contributors_url":"https://api.github.com/repos/Freezerburn/falcon/contributors","subscribers_url":"https://api.github.com/repos/Freezerburn/falcon/subscribers","subscription_url":"https://api.github.com/repos/Freezerburn/falcon/subscription","commits_url":"https://api.github.com/repos/Freezerburn/falcon/commits{/sha}","git_commits_url":"https://api.github.com/repos/Freezerburn/falcon/git/commits{/sha}","comments_url":"https://api.github.com/repos/Freezerburn/falcon/comments{/number}","issue_comment_url":"https://api.github.com/repos/Freezerburn/falcon/issues/comments{/number}","contents_url":"https://api.github.com/repos/Freezerburn/falcon/contents/{+path}","compare_url":"https://api.github.com/repos/Freezerburn/falcon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Freezerburn/falcon/merges","archive_url":"https://api.github.com/repos/Freezerburn/falcon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Freezerburn/falcon/downloads","issues_url":"https://api.github.com/repos/Freezerburn/falcon/issues{/number}","pulls_url":"https://api.github.com/repos/Freezerburn/falcon/pulls{/number}","milestones_url":"https://api.github.com/repos/Freezerburn/falcon/milestones{/number}","notifications_url":"https://api.github.com/repos/Freezerburn/falcon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Freezerburn/falcon/labels{/name}","releases_url":"https://api.github.com/repos/Freezerburn/falcon/releases{/id}","created_at":"2015-06-30T01:51:21Z","updated_at":"2015-06-30T01:51:21Z","pushed_at":"2015-07-16T10:50:48Z","git_url":"git://github.com/Freezerburn/falcon.git","ssh_url":"git@github.com:Freezerburn/falcon.git","clone_url":"https://github.com/Freezerburn/falcon.git","svn_url":"https://github.com/Freezerburn/falcon","homepage":"http://falconframework.org","size":12007,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"falconry:master","ref":"master","sha":"7331d5d1bfcadf8abc4d68f5d417d214f04f1730","user":{"login":"falconry","id":11353642,"avatar_url":"https://avatars.githubusercontent.com/u/11353642?v=3","gravatar_id":"","url":"https://api.github.com/users/falconry","html_url":"https://github.com/falconry","followers_url":"https://api.github.com/users/falconry/followers","following_url":"https://api.github.com/users/falconry/following{/other_user}","gists_url":"https://api.github.com/users/falconry/gists{/gist_id}","starred_url":"https://api.github.com/users/falconry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/falconry/subscriptions","organizations_url":"https://api.github.com/users/falconry/orgs","repos_url":"https://api.github.com/users/falconry/repos","events_url":"https://api.github.com/users/falconry/events{/privacy}","received_events_url":"https://api.github.com/users/falconry/received_events","type":"Organization","site_admin":false},"repo":{"id":7040500,"name":"falcon","full_name":"falconry/falcon","owner":{"login":"falconry","id":11353642,"avatar_url":"https://avatars.githubusercontent.com/u/11353642?v=3","gravatar_id":"","url":"https://api.github.com/users/falconry","html_url":"https://github.com/falconry","followers_url":"https://api.github.com/users/falconry/followers","following_url":"https://api.github.com/users/falconry/following{/other_user}","gists_url":"https://api.github.com/users/falconry/gists{/gist_id}","starred_url":"https://api.github.com/users/falconry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/falconry/subscriptions","organizations_url":"https://api.github.com/users/falconry/orgs","repos_url":"https://api.github.com/users/falconry/repos","events_url":"https://api.github.com/users/falconry/events{/privacy}","received_events_url":"https://api.github.com/users/falconry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/falconry/falcon","description":"Falcon is a high-performance Python framework for building cloud APIs, smart proxies, and app backends.","fork":false,"url":"https://api.github.com/repos/falconry/falcon","forks_url":"https://api.github.com/repos/falconry/falcon/forks","keys_url":"https://api.github.com/repos/falconry/falcon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/falconry/falcon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/falconry/falcon/teams","hooks_url":"https://api.github.com/repos/falconry/falcon/hooks","issue_events_url":"https://api.github.com/repos/falconry/falcon/issues/events{/number}","events_url":"https://api.github.com/repos/falconry/falcon/events","assignees_url":"https://api.github.com/repos/falconry/falcon/assignees{/user}","branches_url":"https://api.github.com/repos/falconry/falcon/branches{/branch}","tags_url":"https://api.github.com/repos/falconry/falcon/tags","blobs_url":"https://api.github.com/repos/falconry/falcon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/falconry/falcon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/falconry/falcon/git/refs{/sha}","trees_url":"https://api.github.com/repos/falconry/falcon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/falconry/falcon/statuses/{sha}","languages_url":"https://api.github.com/repos/falconry/falcon/languages","stargazers_url":"https://api.github.com/repos/falconry/falcon/stargazers","contributors_url":"https://api.github.com/repos/falconry/falcon/contributors","subscribers_url":"https://api.github.com/repos/falconry/falcon/subscribers","subscription_url":"https://api.github.com/repos/falconry/falcon/subscription","commits_url":"https://api.github.com/repos/falconry/falcon/commits{/sha}","git_commits_url":"https://api.github.com/repos/falconry/falcon/git/commits{/sha}","comments_url":"https://api.github.com/repos/falconry/falcon/comments{/number}","issue_comment_url":"https://api.github.com/repos/falconry/falcon/issues/comments{/number}","contents_url":"https://api.github.com/repos/falconry/falcon/contents/{+path}","compare_url":"https://api.github.com/repos/falconry/falcon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/falconry/falcon/merges","archive_url":"https://api.github.com/repos/falconry/falcon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/falconry/falcon/downloads","issues_url":"https://api.github.com/repos/falconry/falcon/issues{/number}","pulls_url":"https://api.github.com/repos/falconry/falcon/pulls{/number}","milestones_url":"https://api.github.com/repos/falconry/falcon/milestones{/number}","notifications_url":"https://api.github.com/repos/falconry/falcon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/falconry/falcon/labels{/name}","releases_url":"https://api.github.com/repos/falconry/falcon/releases{/id}","created_at":"2012-12-06T18:17:51Z","updated_at":"2015-10-16T12:04:21Z","pushed_at":"2015-10-16T17:55:34Z","git_url":"git://github.com/falconry/falcon.git","ssh_url":"git@github.com:falconry/falcon.git","clone_url":"https://github.com/falconry/falcon.git","svn_url":"https://github.com/falconry/falcon","homepage":"http://falconframework.org","size":15525,"stargazers_count":2191,"watchers_count":2191,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":250,"mirror_url":null,"open_issues_count":198,"forks":250,"open_issues":198,"watchers":2191,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/falconry/falcon/pulls/563"},"html":{"href":"https://github.com/falconry/falcon/pull/563"},"issue":{"href":"https://api.github.com/repos/falconry/falcon/issues/563"},"comments":{"href":"https://api.github.com/repos/falconry/falcon/issues/563/comments"},"review_comments":{"href":"https://api.github.com/repos/falconry/falcon/pulls/563/comments"},"review_comment":{"href":"https://api.github.com/repos/falconry/falcon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/falconry/falcon/pulls/563/commits"},"statuses":{"href":"https://api.github.com/repos/falconry/falcon/statuses/d6ff65844d23d9a82d4da6cd39665c34608ab8ff"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":6,"review_comments":3,"commits":4,"additions":14,"deletions":2,"changed_files":1}}