{"action":"created","comment":{"url":"https://api.github.com/repos/Carthage/Carthage/pulls/comments/33981372","id":33981372,"diff_hunk":"@@ -24,11 +24,11 @@ public struct CopyFrameworksCommand: CommandType {\n \t\t\t\t|> flatMap(.Concat) { frameworkPath -> SignalProducer<(), CarthageError> in\n \t\t\t\t\tlet frameworkName = frameworkPath.lastPathComponent\n \n-\t\t\t\t\tlet source = NSURL(fileURLWithPath: frameworkPath, isDirectory: true)!\n+\t\t\t\t\tlet source = Result(NSURL(fileURLWithPath: frameworkPath, isDirectory: true), failWith: CarthageError.InvalidArgument(description: \"Could not find framework \\\"\\(frameworkName)\\\" at path \\(frameworkPath). Ensure that the given path is appropriately entered and that your \\\"Input Files\\\" have been entered correctly.\"))\n \t\t\t\t\tlet target = frameworksFolder().map { $0.URLByAppendingPathComponent(frameworkName, isDirectory: true) }\n \n-\t\t\t\t\treturn SignalProducer(result: target &&& validArchitectures())\n-\t\t\t\t\t\t|> flatMap(.Merge) { (target, validArchitectures) -> SignalProducer<(), CarthageError> in\n+\t\t\t\t\treturn combineLatest(SignalProducer(result: source), SignalProducer(result: target), SignalProducer(result: validArchitectures()))","path":"Source/carthage/CopyFrameworks.swift","position":10,"original_position":10,"commit_id":"130bade9c1e25ae7149412461a9c4625eaec031a","original_commit_id":"130bade9c1e25ae7149412461a9c4625eaec031a","user":{"login":"eliperkins","id":1051453,"avatar_url":"https://avatars.githubusercontent.com/u/1051453?v=3","gravatar_id":"","url":"https://api.github.com/users/eliperkins","html_url":"https://github.com/eliperkins","followers_url":"https://api.github.com/users/eliperkins/followers","following_url":"https://api.github.com/users/eliperkins/following{/other_user}","gists_url":"https://api.github.com/users/eliperkins/gists{/gist_id}","starred_url":"https://api.github.com/users/eliperkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eliperkins/subscriptions","organizations_url":"https://api.github.com/users/eliperkins/orgs","repos_url":"https://api.github.com/users/eliperkins/repos","events_url":"https://api.github.com/users/eliperkins/events{/privacy}","received_events_url":"https://api.github.com/users/eliperkins/received_events","type":"User","site_admin":false},"body":"After checking out antitypical/Result#47 and #547, I swapped this back to a `combineLatest` to handle the next value coming along. Using `&&&` created a tuple within a tuple instead of a tuple with three values. \r\n\r\nNot sure if this is best! @robrix @ikesyo ","created_at":"2015-07-06T20:56:56Z","updated_at":"2015-07-06T20:56:56Z","html_url":"https://github.com/Carthage/Carthage/pull/526#discussion_r33981372","pull_request_url":"https://api.github.com/repos/Carthage/Carthage/pulls/526","_links":{"self":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/comments/33981372"},"html":{"href":"https://github.com/Carthage/Carthage/pull/526#discussion_r33981372"},"pull_request":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/526"}}},"pull_request":{"url":"https://api.github.com/repos/Carthage/Carthage/pulls/526","id":36989562,"html_url":"https://github.com/Carthage/Carthage/pull/526","diff_url":"https://github.com/Carthage/Carthage/pull/526.diff","patch_url":"https://github.com/Carthage/Carthage/pull/526.patch","issue_url":"https://api.github.com/repos/Carthage/Carthage/issues/526","number":526,"state":"open","locked":false,"title":"Remove explicit unwrap of optional when looking for framework source","user":{"login":"eliperkins","id":1051453,"avatar_url":"https://avatars.githubusercontent.com/u/1051453?v=3","gravatar_id":"","url":"https://api.github.com/users/eliperkins","html_url":"https://github.com/eliperkins","followers_url":"https://api.github.com/users/eliperkins/followers","following_url":"https://api.github.com/users/eliperkins/following{/other_user}","gists_url":"https://api.github.com/users/eliperkins/gists{/gist_id}","starred_url":"https://api.github.com/users/eliperkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eliperkins/subscriptions","organizations_url":"https://api.github.com/users/eliperkins/orgs","repos_url":"https://api.github.com/users/eliperkins/repos","events_url":"https://api.github.com/users/eliperkins/events{/privacy}","received_events_url":"https://api.github.com/users/eliperkins/received_events","type":"User","site_admin":false},"body":"(Hopefully) Fixes #404","created_at":"2015-06-04T23:45:59Z","updated_at":"2015-07-06T20:56:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0238aaba4c8b69cfe382a090fb6f8af14c5a64cf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Carthage/Carthage/pulls/526/commits","review_comments_url":"https://api.github.com/repos/Carthage/Carthage/pulls/526/comments","review_comment_url":"https://api.github.com/repos/Carthage/Carthage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Carthage/Carthage/issues/526/comments","statuses_url":"https://api.github.com/repos/Carthage/Carthage/statuses/130bade9c1e25ae7149412461a9c4625eaec031a","head":{"label":"eliperkins:feature/remove-explicit-unwrap","ref":"feature/remove-explicit-unwrap","sha":"130bade9c1e25ae7149412461a9c4625eaec031a","user":{"login":"eliperkins","id":1051453,"avatar_url":"https://avatars.githubusercontent.com/u/1051453?v=3","gravatar_id":"","url":"https://api.github.com/users/eliperkins","html_url":"https://github.com/eliperkins","followers_url":"https://api.github.com/users/eliperkins/followers","following_url":"https://api.github.com/users/eliperkins/following{/other_user}","gists_url":"https://api.github.com/users/eliperkins/gists{/gist_id}","starred_url":"https://api.github.com/users/eliperkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eliperkins/subscriptions","organizations_url":"https://api.github.com/users/eliperkins/orgs","repos_url":"https://api.github.com/users/eliperkins/repos","events_url":"https://api.github.com/users/eliperkins/events{/privacy}","received_events_url":"https://api.github.com/users/eliperkins/received_events","type":"User","site_admin":false},"repo":{"id":27610688,"name":"Carthage","full_name":"eliperkins/Carthage","owner":{"login":"eliperkins","id":1051453,"avatar_url":"https://avatars.githubusercontent.com/u/1051453?v=3","gravatar_id":"","url":"https://api.github.com/users/eliperkins","html_url":"https://github.com/eliperkins","followers_url":"https://api.github.com/users/eliperkins/followers","following_url":"https://api.github.com/users/eliperkins/following{/other_user}","gists_url":"https://api.github.com/users/eliperkins/gists{/gist_id}","starred_url":"https://api.github.com/users/eliperkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eliperkins/subscriptions","organizations_url":"https://api.github.com/users/eliperkins/orgs","repos_url":"https://api.github.com/users/eliperkins/repos","events_url":"https://api.github.com/users/eliperkins/events{/privacy}","received_events_url":"https://api.github.com/users/eliperkins/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eliperkins/Carthage","description":"A simple, decentralized dependency manager for Cocoa","fork":true,"url":"https://api.github.com/repos/eliperkins/Carthage","forks_url":"https://api.github.com/repos/eliperkins/Carthage/forks","keys_url":"https://api.github.com/repos/eliperkins/Carthage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eliperkins/Carthage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eliperkins/Carthage/teams","hooks_url":"https://api.github.com/repos/eliperkins/Carthage/hooks","issue_events_url":"https://api.github.com/repos/eliperkins/Carthage/issues/events{/number}","events_url":"https://api.github.com/repos/eliperkins/Carthage/events","assignees_url":"https://api.github.com/repos/eliperkins/Carthage/assignees{/user}","branches_url":"https://api.github.com/repos/eliperkins/Carthage/branches{/branch}","tags_url":"https://api.github.com/repos/eliperkins/Carthage/tags","blobs_url":"https://api.github.com/repos/eliperkins/Carthage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eliperkins/Carthage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eliperkins/Carthage/git/refs{/sha}","trees_url":"https://api.github.com/repos/eliperkins/Carthage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eliperkins/Carthage/statuses/{sha}","languages_url":"https://api.github.com/repos/eliperkins/Carthage/languages","stargazers_url":"https://api.github.com/repos/eliperkins/Carthage/stargazers","contributors_url":"https://api.github.com/repos/eliperkins/Carthage/contributors","subscribers_url":"https://api.github.com/repos/eliperkins/Carthage/subscribers","subscription_url":"https://api.github.com/repos/eliperkins/Carthage/subscription","commits_url":"https://api.github.com/repos/eliperkins/Carthage/commits{/sha}","git_commits_url":"https://api.github.com/repos/eliperkins/Carthage/git/commits{/sha}","comments_url":"https://api.github.com/repos/eliperkins/Carthage/comments{/number}","issue_comment_url":"https://api.github.com/repos/eliperkins/Carthage/issues/comments{/number}","contents_url":"https://api.github.com/repos/eliperkins/Carthage/contents/{+path}","compare_url":"https://api.github.com/repos/eliperkins/Carthage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eliperkins/Carthage/merges","archive_url":"https://api.github.com/repos/eliperkins/Carthage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eliperkins/Carthage/downloads","issues_url":"https://api.github.com/repos/eliperkins/Carthage/issues{/number}","pulls_url":"https://api.github.com/repos/eliperkins/Carthage/pulls{/number}","milestones_url":"https://api.github.com/repos/eliperkins/Carthage/milestones{/number}","notifications_url":"https://api.github.com/repos/eliperkins/Carthage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eliperkins/Carthage/labels{/name}","releases_url":"https://api.github.com/repos/eliperkins/Carthage/releases{/id}","created_at":"2014-12-05T21:22:41Z","updated_at":"2014-12-05T21:22:44Z","pushed_at":"2015-07-06T20:54:29Z","git_url":"git://github.com/eliperkins/Carthage.git","ssh_url":"git@github.com:eliperkins/Carthage.git","clone_url":"https://github.com/eliperkins/Carthage.git","svn_url":"https://github.com/eliperkins/Carthage","homepage":"","size":6446,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Carthage:master","ref":"master","sha":"2298797e3b3b53c756aa02194627290849b2079d","user":{"login":"Carthage","id":9146792,"avatar_url":"https://avatars.githubusercontent.com/u/9146792?v=3","gravatar_id":"","url":"https://api.github.com/users/Carthage","html_url":"https://github.com/Carthage","followers_url":"https://api.github.com/users/Carthage/followers","following_url":"https://api.github.com/users/Carthage/following{/other_user}","gists_url":"https://api.github.com/users/Carthage/gists{/gist_id}","starred_url":"https://api.github.com/users/Carthage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carthage/subscriptions","organizations_url":"https://api.github.com/users/Carthage/orgs","repos_url":"https://api.github.com/users/Carthage/repos","events_url":"https://api.github.com/users/Carthage/events{/privacy}","received_events_url":"https://api.github.com/users/Carthage/received_events","type":"Organization","site_admin":false},"repo":{"id":25050844,"name":"Carthage","full_name":"Carthage/Carthage","owner":{"login":"Carthage","id":9146792,"avatar_url":"https://avatars.githubusercontent.com/u/9146792?v=3","gravatar_id":"","url":"https://api.github.com/users/Carthage","html_url":"https://github.com/Carthage","followers_url":"https://api.github.com/users/Carthage/followers","following_url":"https://api.github.com/users/Carthage/following{/other_user}","gists_url":"https://api.github.com/users/Carthage/gists{/gist_id}","starred_url":"https://api.github.com/users/Carthage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carthage/subscriptions","organizations_url":"https://api.github.com/users/Carthage/orgs","repos_url":"https://api.github.com/users/Carthage/repos","events_url":"https://api.github.com/users/Carthage/events{/privacy}","received_events_url":"https://api.github.com/users/Carthage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Carthage/Carthage","description":"A simple, decentralized dependency manager for Cocoa","fork":false,"url":"https://api.github.com/repos/Carthage/Carthage","forks_url":"https://api.github.com/repos/Carthage/Carthage/forks","keys_url":"https://api.github.com/repos/Carthage/Carthage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Carthage/Carthage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Carthage/Carthage/teams","hooks_url":"https://api.github.com/repos/Carthage/Carthage/hooks","issue_events_url":"https://api.github.com/repos/Carthage/Carthage/issues/events{/number}","events_url":"https://api.github.com/repos/Carthage/Carthage/events","assignees_url":"https://api.github.com/repos/Carthage/Carthage/assignees{/user}","branches_url":"https://api.github.com/repos/Carthage/Carthage/branches{/branch}","tags_url":"https://api.github.com/repos/Carthage/Carthage/tags","blobs_url":"https://api.github.com/repos/Carthage/Carthage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Carthage/Carthage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Carthage/Carthage/git/refs{/sha}","trees_url":"https://api.github.com/repos/Carthage/Carthage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Carthage/Carthage/statuses/{sha}","languages_url":"https://api.github.com/repos/Carthage/Carthage/languages","stargazers_url":"https://api.github.com/repos/Carthage/Carthage/stargazers","contributors_url":"https://api.github.com/repos/Carthage/Carthage/contributors","subscribers_url":"https://api.github.com/repos/Carthage/Carthage/subscribers","subscription_url":"https://api.github.com/repos/Carthage/Carthage/subscription","commits_url":"https://api.github.com/repos/Carthage/Carthage/commits{/sha}","git_commits_url":"https://api.github.com/repos/Carthage/Carthage/git/commits{/sha}","comments_url":"https://api.github.com/repos/Carthage/Carthage/comments{/number}","issue_comment_url":"https://api.github.com/repos/Carthage/Carthage/issues/comments{/number}","contents_url":"https://api.github.com/repos/Carthage/Carthage/contents/{+path}","compare_url":"https://api.github.com/repos/Carthage/Carthage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Carthage/Carthage/merges","archive_url":"https://api.github.com/repos/Carthage/Carthage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Carthage/Carthage/downloads","issues_url":"https://api.github.com/repos/Carthage/Carthage/issues{/number}","pulls_url":"https://api.github.com/repos/Carthage/Carthage/pulls{/number}","milestones_url":"https://api.github.com/repos/Carthage/Carthage/milestones{/number}","notifications_url":"https://api.github.com/repos/Carthage/Carthage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Carthage/Carthage/labels{/name}","releases_url":"https://api.github.com/repos/Carthage/Carthage/releases{/id}","created_at":"2014-10-10T19:54:55Z","updated_at":"2015-07-06T18:30:34Z","pushed_at":"2015-07-06T20:54:29Z","git_url":"git://github.com/Carthage/Carthage.git","ssh_url":"git@github.com:Carthage/Carthage.git","clone_url":"https://github.com/Carthage/Carthage.git","svn_url":"https://github.com/Carthage/Carthage","homepage":"","size":13088,"stargazers_count":3653,"watchers_count":3653,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":166,"mirror_url":null,"open_issues_count":96,"forks":166,"open_issues":96,"watchers":3653,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/526"},"html":{"href":"https://github.com/Carthage/Carthage/pull/526"},"issue":{"href":"https://api.github.com/repos/Carthage/Carthage/issues/526"},"comments":{"href":"https://api.github.com/repos/Carthage/Carthage/issues/526/comments"},"review_comments":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/526/comments"},"review_comment":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/526/commits"},"statuses":{"href":"https://api.github.com/repos/Carthage/Carthage/statuses/130bade9c1e25ae7149412461a9c4625eaec031a"}}}}