{"action":"closed","number":29,"pull_request":{"url":"https://api.github.com/repos/chauth/confluence_http_authenticator/pulls/29","id":37750183,"html_url":"https://github.com/chauth/confluence_http_authenticator/pull/29","diff_url":"https://github.com/chauth/confluence_http_authenticator/pull/29.diff","patch_url":"https://github.com/chauth/confluence_http_authenticator/pull/29.patch","issue_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/issues/29","number":29,"state":"closed","locked":false,"title":"Update for Confluence 5.8","user":{"login":"TheMysteriousX","id":590630,"avatar_url":"https://avatars.githubusercontent.com/u/590630?v=3","gravatar_id":"","url":"https://api.github.com/users/TheMysteriousX","html_url":"https://github.com/TheMysteriousX","followers_url":"https://api.github.com/users/TheMysteriousX/followers","following_url":"https://api.github.com/users/TheMysteriousX/following{/other_user}","gists_url":"https://api.github.com/users/TheMysteriousX/gists{/gist_id}","starred_url":"https://api.github.com/users/TheMysteriousX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheMysteriousX/subscriptions","organizations_url":"https://api.github.com/users/TheMysteriousX/orgs","repos_url":"https://api.github.com/users/TheMysteriousX/repos","events_url":"https://api.github.com/users/TheMysteriousX/events{/privacy}","received_events_url":"https://api.github.com/users/TheMysteriousX/received_events","type":"User","site_admin":false},"body":"The presence of a spring applicationContext.xml file under 5.8 completely breaks Confluence - even removing 'autowire=\"byName\"' is insufficient. This seems to be the cause of #28.\r\n\r\nI'm not convinced that this is an intended change, but unfortunately Atlassian support are being a little unhelpful. Fortunately there is no impact (unless someone intends importing shibauth.confluence.authentication.shibboleth.RemoteUserAuthenticator via spring injection).\r\n\r\nIdeally this could use some wider testing before its merged.\r\n\r\nIt will *probably* work on versions < 5.8.4, but I haven't checked.\r\n\r\nI've got a few other changes that I'll send another pull for at a later date, but those aren't required for the version bump.\r\n\r\nSigned-Off-By: Adam Bishop <adam@omega.org.uk>","created_at":"2015-06-16T00:47:11Z","updated_at":"2015-06-20T03:41:27Z","closed_at":"2015-06-20T03:41:27Z","merged_at":"2015-06-20T03:41:27Z","merge_commit_sha":"007fc6c5c57fcd82af2883b0d80849d086442bdc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/pulls/29/commits","review_comments_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/pulls/29/comments","review_comment_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/issues/29/comments","statuses_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/statuses/cf4ecb40079f738496b1bdf37dbf04da79f8d488","head":{"label":"TheMysteriousX:master","ref":"master","sha":"cf4ecb40079f738496b1bdf37dbf04da79f8d488","user":{"login":"TheMysteriousX","id":590630,"avatar_url":"https://avatars.githubusercontent.com/u/590630?v=3","gravatar_id":"","url":"https://api.github.com/users/TheMysteriousX","html_url":"https://github.com/TheMysteriousX","followers_url":"https://api.github.com/users/TheMysteriousX/followers","following_url":"https://api.github.com/users/TheMysteriousX/following{/other_user}","gists_url":"https://api.github.com/users/TheMysteriousX/gists{/gist_id}","starred_url":"https://api.github.com/users/TheMysteriousX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheMysteriousX/subscriptions","organizations_url":"https://api.github.com/users/TheMysteriousX/orgs","repos_url":"https://api.github.com/users/TheMysteriousX/repos","events_url":"https://api.github.com/users/TheMysteriousX/events{/privacy}","received_events_url":"https://api.github.com/users/TheMysteriousX/received_events","type":"User","site_admin":false},"repo":{"id":37126152,"name":"confluence_http_authenticator","full_name":"TheMysteriousX/confluence_http_authenticator","owner":{"login":"TheMysteriousX","id":590630,"avatar_url":"https://avatars.githubusercontent.com/u/590630?v=3","gravatar_id":"","url":"https://api.github.com/users/TheMysteriousX","html_url":"https://github.com/TheMysteriousX","followers_url":"https://api.github.com/users/TheMysteriousX/followers","following_url":"https://api.github.com/users/TheMysteriousX/following{/other_user}","gists_url":"https://api.github.com/users/TheMysteriousX/gists{/gist_id}","starred_url":"https://api.github.com/users/TheMysteriousX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheMysteriousX/subscriptions","organizations_url":"https://api.github.com/users/TheMysteriousX/orgs","repos_url":"https://api.github.com/users/TheMysteriousX/repos","events_url":"https://api.github.com/users/TheMysteriousX/events{/privacy}","received_events_url":"https://api.github.com/users/TheMysteriousX/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TheMysteriousX/confluence_http_authenticator","description":"The new home of the Confluence HTTP Authenticator (formerly known as the Confluence Shibboleth Authenticator)","fork":true,"url":"https://api.github.com/repos/TheMysteriousX/confluence_http_authenticator","forks_url":"https://api.github.com/repos/TheMysteriousX/confluence_http_authenticator/forks","keys_url":"https://api.github.com/repos/TheMysteriousX/confluence_http_authenticator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheMysteriousX/confluence_http_authenticator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheMysteriousX/confluence_http_authenticator/teams","hooks_url":"https://api.github.com/repos/TheMysteriousX/confluence_http_authenticator/hooks","issue_events_url":"https://api.github.com/repos/TheMysteriousX/confluence_http_authenticator/issues/events{/number}","events_url":"https://api.github.com/repos/TheMysteriousX/confluence_http_authenticator/events","assignees_url":"https://api.github.com/repos/TheMysteriousX/confluence_http_authenticator/assignees{/user}","branches_url":"https://api.github.com/repos/TheMysteriousX/confluence_http_authenticator/branches{/branch}","tags_url":"https://api.github.com/repos/TheMysteriousX/confluence_http_authenticator/tags","blobs_url":"https://api.github.com/repos/TheMysteriousX/confluence_http_authenticator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheMysteriousX/confluence_http_authenticator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheMysteriousX/confluence_http_authenticator/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheMysteriousX/confluence_http_authenticator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheMysteriousX/confluence_http_authenticator/statuses/{sha}","languages_url":"https://api.github.com/repos/TheMysteriousX/confluence_http_authenticator/languages","stargazers_url":"https://api.github.com/repos/TheMysteriousX/confluence_http_authenticator/stargazers","contributors_url":"https://api.github.com/repos/TheMysteriousX/confluence_http_authenticator/contributors","subscribers_url":"https://api.github.com/repos/TheMysteriousX/confluence_http_authenticator/subscribers","subscription_url":"https://api.github.com/repos/TheMysteriousX/confluence_http_authenticator/subscription","commits_url":"https://api.github.com/repos/TheMysteriousX/confluence_http_authenticator/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheMysteriousX/confluence_http_authenticator/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheMysteriousX/confluence_http_authenticator/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheMysteriousX/confluence_http_authenticator/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheMysteriousX/confluence_http_authenticator/contents/{+path}","compare_url":"https://api.github.com/repos/TheMysteriousX/confluence_http_authenticator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheMysteriousX/confluence_http_authenticator/merges","archive_url":"https://api.github.com/repos/TheMysteriousX/confluence_http_authenticator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheMysteriousX/confluence_http_authenticator/downloads","issues_url":"https://api.github.com/repos/TheMysteriousX/confluence_http_authenticator/issues{/number}","pulls_url":"https://api.github.com/repos/TheMysteriousX/confluence_http_authenticator/pulls{/number}","milestones_url":"https://api.github.com/repos/TheMysteriousX/confluence_http_authenticator/milestones{/number}","notifications_url":"https://api.github.com/repos/TheMysteriousX/confluence_http_authenticator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheMysteriousX/confluence_http_authenticator/labels{/name}","releases_url":"https://api.github.com/repos/TheMysteriousX/confluence_http_authenticator/releases{/id}","created_at":"2015-06-09T10:39:31Z","updated_at":"2015-06-09T10:39:35Z","pushed_at":"2015-06-15T23:52:22Z","git_url":"git://github.com/TheMysteriousX/confluence_http_authenticator.git","ssh_url":"git@github.com:TheMysteriousX/confluence_http_authenticator.git","clone_url":"https://github.com/TheMysteriousX/confluence_http_authenticator.git","svn_url":"https://github.com/TheMysteriousX/confluence_http_authenticator","homepage":null,"size":10551,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chauth:master","ref":"master","sha":"ca7926df0a377304cef66f9dab68deb1451f7259","user":{"login":"chauth","id":3362842,"avatar_url":"https://avatars.githubusercontent.com/u/3362842?v=3","gravatar_id":"","url":"https://api.github.com/users/chauth","html_url":"https://github.com/chauth","followers_url":"https://api.github.com/users/chauth/followers","following_url":"https://api.github.com/users/chauth/following{/other_user}","gists_url":"https://api.github.com/users/chauth/gists{/gist_id}","starred_url":"https://api.github.com/users/chauth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chauth/subscriptions","organizations_url":"https://api.github.com/users/chauth/orgs","repos_url":"https://api.github.com/users/chauth/repos","events_url":"https://api.github.com/users/chauth/events{/privacy}","received_events_url":"https://api.github.com/users/chauth/received_events","type":"Organization","site_admin":false},"repo":{"id":7789418,"name":"confluence_http_authenticator","full_name":"chauth/confluence_http_authenticator","owner":{"login":"chauth","id":3362842,"avatar_url":"https://avatars.githubusercontent.com/u/3362842?v=3","gravatar_id":"","url":"https://api.github.com/users/chauth","html_url":"https://github.com/chauth","followers_url":"https://api.github.com/users/chauth/followers","following_url":"https://api.github.com/users/chauth/following{/other_user}","gists_url":"https://api.github.com/users/chauth/gists{/gist_id}","starred_url":"https://api.github.com/users/chauth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chauth/subscriptions","organizations_url":"https://api.github.com/users/chauth/orgs","repos_url":"https://api.github.com/users/chauth/repos","events_url":"https://api.github.com/users/chauth/events{/privacy}","received_events_url":"https://api.github.com/users/chauth/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chauth/confluence_http_authenticator","description":"The new home of the Confluence HTTP Authenticator (formerly known as the Confluence Shibboleth Authenticator)","fork":false,"url":"https://api.github.com/repos/chauth/confluence_http_authenticator","forks_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/forks","keys_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/teams","hooks_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/hooks","issue_events_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/issues/events{/number}","events_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/events","assignees_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/assignees{/user}","branches_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/branches{/branch}","tags_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/tags","blobs_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/git/refs{/sha}","trees_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/statuses/{sha}","languages_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/languages","stargazers_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/stargazers","contributors_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/contributors","subscribers_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/subscribers","subscription_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/subscription","commits_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/commits{/sha}","git_commits_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/git/commits{/sha}","comments_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/comments{/number}","issue_comment_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/issues/comments{/number}","contents_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/contents/{+path}","compare_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/merges","archive_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/downloads","issues_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/issues{/number}","pulls_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/pulls{/number}","milestones_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/milestones{/number}","notifications_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/labels{/name}","releases_url":"https://api.github.com/repos/chauth/confluence_http_authenticator/releases{/id}","created_at":"2013-01-24T03:07:17Z","updated_at":"2015-06-15T03:46:12Z","pushed_at":"2015-06-20T03:41:28Z","git_url":"git://github.com/chauth/confluence_http_authenticator.git","ssh_url":"git@github.com:chauth/confluence_http_authenticator.git","clone_url":"https://github.com/chauth/confluence_http_authenticator.git","svn_url":"https://github.com/chauth/confluence_http_authenticator","homepage":null,"size":12795,"stargazers_count":38,"watchers_count":38,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":3,"forks":12,"open_issues":3,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chauth/confluence_http_authenticator/pulls/29"},"html":{"href":"https://github.com/chauth/confluence_http_authenticator/pull/29"},"issue":{"href":"https://api.github.com/repos/chauth/confluence_http_authenticator/issues/29"},"comments":{"href":"https://api.github.com/repos/chauth/confluence_http_authenticator/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/chauth/confluence_http_authenticator/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/chauth/confluence_http_authenticator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chauth/confluence_http_authenticator/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/chauth/confluence_http_authenticator/statuses/cf4ecb40079f738496b1bdf37dbf04da79f8d488"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"garysweaver","id":92330,"avatar_url":"https://avatars.githubusercontent.com/u/92330?v=3","gravatar_id":"","url":"https://api.github.com/users/garysweaver","html_url":"https://github.com/garysweaver","followers_url":"https://api.github.com/users/garysweaver/followers","following_url":"https://api.github.com/users/garysweaver/following{/other_user}","gists_url":"https://api.github.com/users/garysweaver/gists{/gist_id}","starred_url":"https://api.github.com/users/garysweaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garysweaver/subscriptions","organizations_url":"https://api.github.com/users/garysweaver/orgs","repos_url":"https://api.github.com/users/garysweaver/repos","events_url":"https://api.github.com/users/garysweaver/events{/privacy}","received_events_url":"https://api.github.com/users/garysweaver/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":4,"additions":14,"deletions":59,"changed_files":4}}