{"action":"created","comment":{"url":"https://api.github.com/repos/xjamundx/neff/pulls/comments/25615480","id":25615480,"diff_hunk":"@@ -8,25 +8,16 @@ if (moreUsers) {\n }\n ```\n \n-### Server Side Usage\n \n-#### NConf-Based Config\n+#### Argument-Based Config\n \n-To get started with neff you'll want to make sure you have setup nconf to contain a `features` setting, which is an object with feature names and either `true` or `false` values. I'm currently doing this using a JSON file and my config looks like this:\n+If you'd instead like to pass the features as parameters you can call the factory method to merge the arguments passed to the method with any (optional) nconf configuration you utilize in your project.\n \n-```json\n-\"features\": {\n+```\n+app.use(neff.factory({","path":"README.md","position":15,"original_position":15,"commit_id":"e4d213c4330c7dea4adf20aef92d1a0c73ff3493","original_commit_id":"e4d213c4330c7dea4adf20aef92d1a0c73ff3493","user":{"login":"xjamundx","id":246143,"avatar_url":"https://avatars.githubusercontent.com/u/246143?v=3","gravatar_id":"","url":"https://api.github.com/users/xjamundx","html_url":"https://github.com/xjamundx","followers_url":"https://api.github.com/users/xjamundx/followers","following_url":"https://api.github.com/users/xjamundx/following{/other_user}","gists_url":"https://api.github.com/users/xjamundx/gists{/gist_id}","starred_url":"https://api.github.com/users/xjamundx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xjamundx/subscriptions","organizations_url":"https://api.github.com/users/xjamundx/orgs","repos_url":"https://api.github.com/users/xjamundx/repos","events_url":"https://api.github.com/users/xjamundx/events{/privacy}","received_events_url":"https://api.github.com/users/xjamundx/received_events","type":"User","site_admin":false},"body":"So not sure how much it matters, but because `neff` is a singleton, each time you include the middleware you wipe the entire list. Maybe it would be better if each `.factor()` returned its own version of `neff`? We don't need `new`, but maybe it could contain it's features in its own scope? \r\n\r\nLet's talk about if this is needed.","created_at":"2015-03-02T17:05:11Z","updated_at":"2015-03-02T17:05:11Z","html_url":"https://github.com/xjamundx/neff/pull/4#discussion_r25615480","pull_request_url":"https://api.github.com/repos/xjamundx/neff/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/xjamundx/neff/pulls/comments/25615480"},"html":{"href":"https://github.com/xjamundx/neff/pull/4#discussion_r25615480"},"pull_request":{"href":"https://api.github.com/repos/xjamundx/neff/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/xjamundx/neff/pulls/4","id":30212083,"html_url":"https://github.com/xjamundx/neff/pull/4","diff_url":"https://github.com/xjamundx/neff/pull/4.diff","patch_url":"https://github.com/xjamundx/neff/pull/4.patch","issue_url":"https://api.github.com/repos/xjamundx/neff/issues/4","number":4,"state":"open","locked":false,"title":"Removing all dependencies","user":{"login":"bluelnkd","id":1892368,"avatar_url":"https://avatars.githubusercontent.com/u/1892368?v=3","gravatar_id":"","url":"https://api.github.com/users/bluelnkd","html_url":"https://github.com/bluelnkd","followers_url":"https://api.github.com/users/bluelnkd/followers","following_url":"https://api.github.com/users/bluelnkd/following{/other_user}","gists_url":"https://api.github.com/users/bluelnkd/gists{/gist_id}","starred_url":"https://api.github.com/users/bluelnkd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluelnkd/subscriptions","organizations_url":"https://api.github.com/users/bluelnkd/orgs","repos_url":"https://api.github.com/users/bluelnkd/repos","events_url":"https://api.github.com/users/bluelnkd/events{/privacy}","received_events_url":"https://api.github.com/users/bluelnkd/received_events","type":"User","site_admin":false},"body":"This gets rid of the usage of nconf all together. No backward compatibility with previous versions of neff.","created_at":"2015-02-28T00:03:28Z","updated_at":"2015-03-02T17:05:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"62492b70fd0f3d6556382a2c84ddaf1a66971703","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xjamundx/neff/pulls/4/commits","review_comments_url":"https://api.github.com/repos/xjamundx/neff/pulls/4/comments","review_comment_url":"https://api.github.com/repos/xjamundx/neff/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xjamundx/neff/issues/4/comments","statuses_url":"https://api.github.com/repos/xjamundx/neff/statuses/e4d213c4330c7dea4adf20aef92d1a0c73ff3493","head":{"label":"bluelnkd:noNconf","ref":"noNconf","sha":"e4d213c4330c7dea4adf20aef92d1a0c73ff3493","user":{"login":"bluelnkd","id":1892368,"avatar_url":"https://avatars.githubusercontent.com/u/1892368?v=3","gravatar_id":"","url":"https://api.github.com/users/bluelnkd","html_url":"https://github.com/bluelnkd","followers_url":"https://api.github.com/users/bluelnkd/followers","following_url":"https://api.github.com/users/bluelnkd/following{/other_user}","gists_url":"https://api.github.com/users/bluelnkd/gists{/gist_id}","starred_url":"https://api.github.com/users/bluelnkd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluelnkd/subscriptions","organizations_url":"https://api.github.com/users/bluelnkd/orgs","repos_url":"https://api.github.com/users/bluelnkd/repos","events_url":"https://api.github.com/users/bluelnkd/events{/privacy}","received_events_url":"https://api.github.com/users/bluelnkd/received_events","type":"User","site_admin":false},"repo":{"id":31327518,"name":"neff","full_name":"bluelnkd/neff","owner":{"login":"bluelnkd","id":1892368,"avatar_url":"https://avatars.githubusercontent.com/u/1892368?v=3","gravatar_id":"","url":"https://api.github.com/users/bluelnkd","html_url":"https://github.com/bluelnkd","followers_url":"https://api.github.com/users/bluelnkd/followers","following_url":"https://api.github.com/users/bluelnkd/following{/other_user}","gists_url":"https://api.github.com/users/bluelnkd/gists{/gist_id}","starred_url":"https://api.github.com/users/bluelnkd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluelnkd/subscriptions","organizations_url":"https://api.github.com/users/bluelnkd/orgs","repos_url":"https://api.github.com/users/bluelnkd/repos","events_url":"https://api.github.com/users/bluelnkd/events{/privacy}","received_events_url":"https://api.github.com/users/bluelnkd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bluelnkd/neff","description":"nconf & express based feature flags","fork":true,"url":"https://api.github.com/repos/bluelnkd/neff","forks_url":"https://api.github.com/repos/bluelnkd/neff/forks","keys_url":"https://api.github.com/repos/bluelnkd/neff/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bluelnkd/neff/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bluelnkd/neff/teams","hooks_url":"https://api.github.com/repos/bluelnkd/neff/hooks","issue_events_url":"https://api.github.com/repos/bluelnkd/neff/issues/events{/number}","events_url":"https://api.github.com/repos/bluelnkd/neff/events","assignees_url":"https://api.github.com/repos/bluelnkd/neff/assignees{/user}","branches_url":"https://api.github.com/repos/bluelnkd/neff/branches{/branch}","tags_url":"https://api.github.com/repos/bluelnkd/neff/tags","blobs_url":"https://api.github.com/repos/bluelnkd/neff/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bluelnkd/neff/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bluelnkd/neff/git/refs{/sha}","trees_url":"https://api.github.com/repos/bluelnkd/neff/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bluelnkd/neff/statuses/{sha}","languages_url":"https://api.github.com/repos/bluelnkd/neff/languages","stargazers_url":"https://api.github.com/repos/bluelnkd/neff/stargazers","contributors_url":"https://api.github.com/repos/bluelnkd/neff/contributors","subscribers_url":"https://api.github.com/repos/bluelnkd/neff/subscribers","subscription_url":"https://api.github.com/repos/bluelnkd/neff/subscription","commits_url":"https://api.github.com/repos/bluelnkd/neff/commits{/sha}","git_commits_url":"https://api.github.com/repos/bluelnkd/neff/git/commits{/sha}","comments_url":"https://api.github.com/repos/bluelnkd/neff/comments{/number}","issue_comment_url":"https://api.github.com/repos/bluelnkd/neff/issues/comments{/number}","contents_url":"https://api.github.com/repos/bluelnkd/neff/contents/{+path}","compare_url":"https://api.github.com/repos/bluelnkd/neff/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bluelnkd/neff/merges","archive_url":"https://api.github.com/repos/bluelnkd/neff/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bluelnkd/neff/downloads","issues_url":"https://api.github.com/repos/bluelnkd/neff/issues{/number}","pulls_url":"https://api.github.com/repos/bluelnkd/neff/pulls{/number}","milestones_url":"https://api.github.com/repos/bluelnkd/neff/milestones{/number}","notifications_url":"https://api.github.com/repos/bluelnkd/neff/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bluelnkd/neff/labels{/name}","releases_url":"https://api.github.com/repos/bluelnkd/neff/releases{/id}","created_at":"2015-02-25T17:54:12Z","updated_at":"2015-02-27T21:46:12Z","pushed_at":"2015-02-28T00:03:09Z","git_url":"git://github.com/bluelnkd/neff.git","ssh_url":"git@github.com:bluelnkd/neff.git","clone_url":"https://github.com/bluelnkd/neff.git","svn_url":"https://github.com/bluelnkd/neff","homepage":null,"size":88,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xjamundx:master","ref":"master","sha":"613606a6966d24a0b9c0dbeb0a2e2f491747803d","user":{"login":"xjamundx","id":246143,"avatar_url":"https://avatars.githubusercontent.com/u/246143?v=3","gravatar_id":"","url":"https://api.github.com/users/xjamundx","html_url":"https://github.com/xjamundx","followers_url":"https://api.github.com/users/xjamundx/followers","following_url":"https://api.github.com/users/xjamundx/following{/other_user}","gists_url":"https://api.github.com/users/xjamundx/gists{/gist_id}","starred_url":"https://api.github.com/users/xjamundx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xjamundx/subscriptions","organizations_url":"https://api.github.com/users/xjamundx/orgs","repos_url":"https://api.github.com/users/xjamundx/repos","events_url":"https://api.github.com/users/xjamundx/events{/privacy}","received_events_url":"https://api.github.com/users/xjamundx/received_events","type":"User","site_admin":false},"repo":{"id":16242768,"name":"neff","full_name":"xjamundx/neff","owner":{"login":"xjamundx","id":246143,"avatar_url":"https://avatars.githubusercontent.com/u/246143?v=3","gravatar_id":"","url":"https://api.github.com/users/xjamundx","html_url":"https://github.com/xjamundx","followers_url":"https://api.github.com/users/xjamundx/followers","following_url":"https://api.github.com/users/xjamundx/following{/other_user}","gists_url":"https://api.github.com/users/xjamundx/gists{/gist_id}","starred_url":"https://api.github.com/users/xjamundx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xjamundx/subscriptions","organizations_url":"https://api.github.com/users/xjamundx/orgs","repos_url":"https://api.github.com/users/xjamundx/repos","events_url":"https://api.github.com/users/xjamundx/events{/privacy}","received_events_url":"https://api.github.com/users/xjamundx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xjamundx/neff","description":"nconf & express based feature flags","fork":false,"url":"https://api.github.com/repos/xjamundx/neff","forks_url":"https://api.github.com/repos/xjamundx/neff/forks","keys_url":"https://api.github.com/repos/xjamundx/neff/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xjamundx/neff/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xjamundx/neff/teams","hooks_url":"https://api.github.com/repos/xjamundx/neff/hooks","issue_events_url":"https://api.github.com/repos/xjamundx/neff/issues/events{/number}","events_url":"https://api.github.com/repos/xjamundx/neff/events","assignees_url":"https://api.github.com/repos/xjamundx/neff/assignees{/user}","branches_url":"https://api.github.com/repos/xjamundx/neff/branches{/branch}","tags_url":"https://api.github.com/repos/xjamundx/neff/tags","blobs_url":"https://api.github.com/repos/xjamundx/neff/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xjamundx/neff/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xjamundx/neff/git/refs{/sha}","trees_url":"https://api.github.com/repos/xjamundx/neff/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xjamundx/neff/statuses/{sha}","languages_url":"https://api.github.com/repos/xjamundx/neff/languages","stargazers_url":"https://api.github.com/repos/xjamundx/neff/stargazers","contributors_url":"https://api.github.com/repos/xjamundx/neff/contributors","subscribers_url":"https://api.github.com/repos/xjamundx/neff/subscribers","subscription_url":"https://api.github.com/repos/xjamundx/neff/subscription","commits_url":"https://api.github.com/repos/xjamundx/neff/commits{/sha}","git_commits_url":"https://api.github.com/repos/xjamundx/neff/git/commits{/sha}","comments_url":"https://api.github.com/repos/xjamundx/neff/comments{/number}","issue_comment_url":"https://api.github.com/repos/xjamundx/neff/issues/comments{/number}","contents_url":"https://api.github.com/repos/xjamundx/neff/contents/{+path}","compare_url":"https://api.github.com/repos/xjamundx/neff/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xjamundx/neff/merges","archive_url":"https://api.github.com/repos/xjamundx/neff/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xjamundx/neff/downloads","issues_url":"https://api.github.com/repos/xjamundx/neff/issues{/number}","pulls_url":"https://api.github.com/repos/xjamundx/neff/pulls{/number}","milestones_url":"https://api.github.com/repos/xjamundx/neff/milestones{/number}","notifications_url":"https://api.github.com/repos/xjamundx/neff/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xjamundx/neff/labels{/name}","releases_url":"https://api.github.com/repos/xjamundx/neff/releases{/id}","created_at":"2014-01-25T23:43:16Z","updated_at":"2014-08-22T14:01:01Z","pushed_at":"2014-01-27T21:06:24Z","git_url":"git://github.com/xjamundx/neff.git","ssh_url":"git@github.com:xjamundx/neff.git","clone_url":"https://github.com/xjamundx/neff.git","svn_url":"https://github.com/xjamundx/neff","homepage":null,"size":148,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xjamundx/neff/pulls/4"},"html":{"href":"https://github.com/xjamundx/neff/pull/4"},"issue":{"href":"https://api.github.com/repos/xjamundx/neff/issues/4"},"comments":{"href":"https://api.github.com/repos/xjamundx/neff/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/xjamundx/neff/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/xjamundx/neff/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xjamundx/neff/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/xjamundx/neff/statuses/e4d213c4330c7dea4adf20aef92d1a0c73ff3493"}}}}