{"action":"created","issue":{"url":"https://api.github.com/repos/pfsense/pfsense-packages/issues/1210","labels_url":"https://api.github.com/repos/pfsense/pfsense-packages/issues/1210/labels{/name}","comments_url":"https://api.github.com/repos/pfsense/pfsense-packages/issues/1210/comments","events_url":"https://api.github.com/repos/pfsense/pfsense-packages/issues/1210/events","html_url":"https://github.com/pfsense/pfsense-packages/pull/1210","id":120544886,"number":1210,"title":"Squid3 - Remove the broken patch CP feature (Bug #5594)","user":{"login":"doktornotor","id":1075960,"avatar_url":"https://avatars.githubusercontent.com/u/1075960?v=3","gravatar_id":"","url":"https://api.github.com/users/doktornotor","html_url":"https://github.com/doktornotor","followers_url":"https://api.github.com/users/doktornotor/followers","following_url":"https://api.github.com/users/doktornotor/following{/other_user}","gists_url":"https://api.github.com/users/doktornotor/gists{/gist_id}","starred_url":"https://api.github.com/users/doktornotor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doktornotor/subscriptions","organizations_url":"https://api.github.com/users/doktornotor/orgs","repos_url":"https://api.github.com/users/doktornotor/repos","events_url":"https://api.github.com/users/doktornotor/events{/privacy}","received_events_url":"https://api.github.com/users/doktornotor/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/pfsense/pfsense-packages/labels/CLA","name":"CLA","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-05T10:13:43Z","updated_at":"2015-12-05T10:39:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pfsense/pfsense-packages/pulls/1210","html_url":"https://github.com/pfsense/pfsense-packages/pull/1210","diff_url":"https://github.com/pfsense/pfsense-packages/pull/1210.diff","patch_url":"https://github.com/pfsense/pfsense-packages/pull/1210.patch"},"body":"This \"feature\" has been broken for almost a year without anyone noticing; see https://redmine.pfsense.org/issues/5594 for details. Remove this junk until a saner alternative is available. System Patches is the way to go until that happens if someone really requires that.\r\n\r\nOn upgrade, an attempt to restore a backup will be made, and appropriate notice filed (and logged). There are also GUI instructions left in place of the original checkbox."},"comment":{"url":"https://api.github.com/repos/pfsense/pfsense-packages/issues/comments/162171574","html_url":"https://github.com/pfsense/pfsense-packages/pull/1210#issuecomment-162171574","issue_url":"https://api.github.com/repos/pfsense/pfsense-packages/issues/1210","id":162171574,"user":{"login":"marcelloc","id":926309,"avatar_url":"https://avatars.githubusercontent.com/u/926309?v=3","gravatar_id":"","url":"https://api.github.com/users/marcelloc","html_url":"https://github.com/marcelloc","followers_url":"https://api.github.com/users/marcelloc/followers","following_url":"https://api.github.com/users/marcelloc/following{/other_user}","gists_url":"https://api.github.com/users/marcelloc/gists{/gist_id}","starred_url":"https://api.github.com/users/marcelloc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcelloc/subscriptions","organizations_url":"https://api.github.com/users/marcelloc/orgs","repos_url":"https://api.github.com/users/marcelloc/repos","events_url":"https://api.github.com/users/marcelloc/events{/privacy}","received_events_url":"https://api.github.com/users/marcelloc/received_events","type":"User","site_admin":false},"created_at":"2015-12-05T10:39:34Z","updated_at":"2015-12-05T10:39:34Z","body":"IIRC, the patch on squid3 was fixed to 2.2 before the first \"remove try\". I'm not sure when it get broken again but I'll try to find it on previous squid code improvements.\r\n\r\nThe best place for it is on pfsense captive portal code to allow access to local deamon only after cp authentication."}}