{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/android/issues/1277","labels_url":"https://api.github.com/repos/owncloud/android/issues/1277/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/android/issues/1277/comments","events_url":"https://api.github.com/repos/owncloud/android/issues/1277/events","html_url":"https://github.com/owncloud/android/pull/1277","id":115928979,"number":1277,"title":"#1193 - optimizing the uploader layout & taking user configured sorting into account","user":{"login":"AndyScherzinger","id":1315170,"avatar_url":"https://avatars.githubusercontent.com/u/1315170?v=3","gravatar_id":"","url":"https://api.github.com/users/AndyScherzinger","html_url":"https://github.com/AndyScherzinger","followers_url":"https://api.github.com/users/AndyScherzinger/followers","following_url":"https://api.github.com/users/AndyScherzinger/following{/other_user}","gists_url":"https://api.github.com/users/AndyScherzinger/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyScherzinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyScherzinger/subscriptions","organizations_url":"https://api.github.com/users/AndyScherzinger/orgs","repos_url":"https://api.github.com/users/AndyScherzinger/repos","events_url":"https://api.github.com/users/AndyScherzinger/events{/privacy}","received_events_url":"https://api.github.com/users/AndyScherzinger/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/owncloud/android/labels/3%20-%20To%20review","name":"3 - To review","color":"CCCCCC"},{"url":"https://api.github.com/repos/owncloud/android/labels/browse","name":"browse","color":"009800"},{"url":"https://api.github.com/repos/owncloud/android/labels/Design","name":"Design","color":"cc317c"},{"url":"https://api.github.com/repos/owncloud/android/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/owncloud/android/labels/uploads","name":"uploads","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-11-09T17:46:13Z","updated_at":"2015-11-20T17:32:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/owncloud/android/pulls/1277","html_url":"https://github.com/owncloud/android/pull/1277","diff_url":"https://github.com/owncloud/android/pull/1277.diff","patch_url":"https://github.com/owncloud/android/pull/1277.patch"},"body":"For the detailed discussion please see #1193, see attached the screenshots for both sortings from my local tests. Works fine switching the sorting in app and then launching the uploader screen via another app.\r\n\r\nThis branch is based on ``master``\r\n\r\nBeware of certain \"details\":\r\n* The buttons are still white since the primary action coloring is part of the ``material_buttons`` branch\r\n* The list is styled according to @jancborchardt's latests wishes (background white, devider #eee), as it is done for all other lists on the ``material_buttons`` branch\r\n* The add folder action is shown on the action bar which will be hidden in the future, as seen on the ``material_fab`` branch since with the introduction of the fab the general guideline has been to hide non-primary actions in the actionbar in the overflow menu\r\n* since the date calculation/visualization is now used in two places I refactored the code accordingly (within this PR)\r\n\r\nPR is ready to review, so pinging @tobiasKaminsky @LukeOwncloud @masensio @davivel @jancborchardt for review and integration within the beta branch :)\r\n\r\n@jancborchardt Little detail: The title is a re-use of the choose-text which I changed for english but will be \"wrong\"/old before the branch is merged into master and transifex translations for the other languages come in. Just letting you know :)\r\n\r\n![device-2015-11-09-182033](https://cloud.githubusercontent.com/assets/1315170/11041882/63db6588-8714-11e5-8aa0-68ab69721e4f.png)\r\n\r\n![device-2015-11-09-182117](https://cloud.githubusercontent.com/assets/1315170/11041884/678d9660-8714-11e5-86b7-12f0ba4b6f26.png)"},"comment":{"url":"https://api.github.com/repos/owncloud/android/issues/comments/158467602","html_url":"https://github.com/owncloud/android/pull/1277#issuecomment-158467602","issue_url":"https://api.github.com/repos/owncloud/android/issues/1277","id":158467602,"user":{"login":"tobiasKaminsky","id":5836855,"avatar_url":"https://avatars.githubusercontent.com/u/5836855?v=3","gravatar_id":"","url":"https://api.github.com/users/tobiasKaminsky","html_url":"https://github.com/tobiasKaminsky","followers_url":"https://api.github.com/users/tobiasKaminsky/followers","following_url":"https://api.github.com/users/tobiasKaminsky/following{/other_user}","gists_url":"https://api.github.com/users/tobiasKaminsky/gists{/gist_id}","starred_url":"https://api.github.com/users/tobiasKaminsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobiasKaminsky/subscriptions","organizations_url":"https://api.github.com/users/tobiasKaminsky/orgs","repos_url":"https://api.github.com/users/tobiasKaminsky/repos","events_url":"https://api.github.com/users/tobiasKaminsky/events{/privacy}","received_events_url":"https://api.github.com/users/tobiasKaminsky/received_events","type":"User","site_admin":false},"created_at":"2015-11-20T17:32:08Z","updated_at":"2015-11-20T17:32:08Z","body":"Looks good to me.\r\nMerging it into beta."}}