{"action":"created","comment":{"url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/pulls/comments/24889923","id":24889923,"diff_hunk":"@@ -41,4 +41,34 @@ public static String tryGetProperty(String key) {\n             return null;\n         }\n     }\n+\n+    /**\n+     * Try to retrieve a system property and returns null if SecurityManager blocks it.\n+     *\n+     * @param key Name of the system property to get the integer for.\n+     * @return the value of the System property\n+     */\n+    public static Integer tryGetIntegerProperty(String key) {\n+        return tryGetIntegerProperty(key, null);\n+    }\n+\n+    /**\n+     * Try to retrieve a system property and returns the defaultValue if SecurityManager blocks it.\n+     *\n+     * @param key Name of the system property to get the integer for.\n+     * @param defaultValue Value to be returned on unsuccessful operation or if the propety is not set.\n+     *\n+     * @return the value of the System property\n+     */\n+    public static Integer tryGetIntegerProperty(String key, Integer defaultValue) {","path":"push/sender/src/main/java/org/jboss/aerogear/unifiedpush/message/util/ConfigurationUtils.java","position":23,"original_position":23,"commit_id":"722553b48748bbc2433600488468a30054350094","original_commit_id":"722553b48748bbc2433600488468a30054350094","user":{"login":"matzew","id":157646,"avatar_url":"https://avatars.githubusercontent.com/u/157646?v=3","gravatar_id":"","url":"https://api.github.com/users/matzew","html_url":"https://github.com/matzew","followers_url":"https://api.github.com/users/matzew/followers","following_url":"https://api.github.com/users/matzew/following{/other_user}","gists_url":"https://api.github.com/users/matzew/gists{/gist_id}","starred_url":"https://api.github.com/users/matzew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matzew/subscriptions","organizations_url":"https://api.github.com/users/matzew/orgs","repos_url":"https://api.github.com/users/matzew/repos","events_url":"https://api.github.com/users/matzew/events{/privacy}","received_events_url":"https://api.github.com/users/matzew/received_events","type":"User","site_admin":false},"body":"wanna add a test ? ","created_at":"2015-02-18T09:58:00Z","updated_at":"2015-02-18T09:58:00Z","html_url":"https://github.com/aerogear/aerogear-unifiedpush-server/pull/496#discussion_r24889923","pull_request_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/pulls/496","_links":{"self":{"href":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/pulls/comments/24889923"},"html":{"href":"https://github.com/aerogear/aerogear-unifiedpush-server/pull/496#discussion_r24889923"},"pull_request":{"href":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/pulls/496"}}},"pull_request":{"url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/pulls/496","id":29512341,"html_url":"https://github.com/aerogear/aerogear-unifiedpush-server/pull/496","diff_url":"https://github.com/aerogear/aerogear-unifiedpush-server/pull/496.diff","patch_url":"https://github.com/aerogear/aerogear-unifiedpush-server/pull/496.patch","issue_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/issues/496","number":496,"state":"open","locked":false,"title":"Fix withFeedbackDestination to obtain host and not port.","user":{"login":"TadeasKriz","id":284197,"avatar_url":"https://avatars.githubusercontent.com/u/284197?v=3","gravatar_id":"","url":"https://api.github.com/users/TadeasKriz","html_url":"https://github.com/TadeasKriz","followers_url":"https://api.github.com/users/TadeasKriz/followers","following_url":"https://api.github.com/users/TadeasKriz/following{/other_user}","gists_url":"https://api.github.com/users/TadeasKriz/gists{/gist_id}","starred_url":"https://api.github.com/users/TadeasKriz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TadeasKriz/subscriptions","organizations_url":"https://api.github.com/users/TadeasKriz/orgs","repos_url":"https://api.github.com/users/TadeasKriz/repos","events_url":"https://api.github.com/users/TadeasKriz/events{/privacy}","received_events_url":"https://api.github.com/users/TadeasKriz/received_events","type":"User","site_admin":false},"body":"There was a typo and the `withFeedbackDestination` was getting the port instead of host resulting in push using custom mock APNS server not working. I've fixed that and added a two new methods into ConfigurationUtils to obtain Integer properties. That way it should not happen to accidentally give something that wants a `String` an `Integer`.","created_at":"2015-02-18T09:51:31Z","updated_at":"2015-02-18T09:58:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0886c998f526c0cb39ba0e73cb98ea733a560422","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/pulls/496/commits","review_comments_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/pulls/496/comments","review_comment_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/pulls/comments/{number}","comments_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/issues/496/comments","statuses_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/statuses/722553b48748bbc2433600488468a30054350094","head":{"label":"TadeasKriz:fix/custom-feedback-host","ref":"fix/custom-feedback-host","sha":"722553b48748bbc2433600488468a30054350094","user":{"login":"TadeasKriz","id":284197,"avatar_url":"https://avatars.githubusercontent.com/u/284197?v=3","gravatar_id":"","url":"https://api.github.com/users/TadeasKriz","html_url":"https://github.com/TadeasKriz","followers_url":"https://api.github.com/users/TadeasKriz/followers","following_url":"https://api.github.com/users/TadeasKriz/following{/other_user}","gists_url":"https://api.github.com/users/TadeasKriz/gists{/gist_id}","starred_url":"https://api.github.com/users/TadeasKriz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TadeasKriz/subscriptions","organizations_url":"https://api.github.com/users/TadeasKriz/orgs","repos_url":"https://api.github.com/users/TadeasKriz/repos","events_url":"https://api.github.com/users/TadeasKriz/events{/privacy}","received_events_url":"https://api.github.com/users/TadeasKriz/received_events","type":"User","site_admin":false},"repo":{"id":13388394,"name":"aerogear-unifiedpush-server","full_name":"TadeasKriz/aerogear-unifiedpush-server","owner":{"login":"TadeasKriz","id":284197,"avatar_url":"https://avatars.githubusercontent.com/u/284197?v=3","gravatar_id":"","url":"https://api.github.com/users/TadeasKriz","html_url":"https://github.com/TadeasKriz","followers_url":"https://api.github.com/users/TadeasKriz/followers","following_url":"https://api.github.com/users/TadeasKriz/following{/other_user}","gists_url":"https://api.github.com/users/TadeasKriz/gists{/gist_id}","starred_url":"https://api.github.com/users/TadeasKriz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TadeasKriz/subscriptions","organizations_url":"https://api.github.com/users/TadeasKriz/orgs","repos_url":"https://api.github.com/users/TadeasKriz/repos","events_url":"https://api.github.com/users/TadeasKriz/events{/privacy}","received_events_url":"https://api.github.com/users/TadeasKriz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TadeasKriz/aerogear-unifiedpush-server","description":"AeroGear Unified Push Server","fork":true,"url":"https://api.github.com/repos/TadeasKriz/aerogear-unifiedpush-server","forks_url":"https://api.github.com/repos/TadeasKriz/aerogear-unifiedpush-server/forks","keys_url":"https://api.github.com/repos/TadeasKriz/aerogear-unifiedpush-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TadeasKriz/aerogear-unifiedpush-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TadeasKriz/aerogear-unifiedpush-server/teams","hooks_url":"https://api.github.com/repos/TadeasKriz/aerogear-unifiedpush-server/hooks","issue_events_url":"https://api.github.com/repos/TadeasKriz/aerogear-unifiedpush-server/issues/events{/number}","events_url":"https://api.github.com/repos/TadeasKriz/aerogear-unifiedpush-server/events","assignees_url":"https://api.github.com/repos/TadeasKriz/aerogear-unifiedpush-server/assignees{/user}","branches_url":"https://api.github.com/repos/TadeasKriz/aerogear-unifiedpush-server/branches{/branch}","tags_url":"https://api.github.com/repos/TadeasKriz/aerogear-unifiedpush-server/tags","blobs_url":"https://api.github.com/repos/TadeasKriz/aerogear-unifiedpush-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TadeasKriz/aerogear-unifiedpush-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TadeasKriz/aerogear-unifiedpush-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/TadeasKriz/aerogear-unifiedpush-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TadeasKriz/aerogear-unifiedpush-server/statuses/{sha}","languages_url":"https://api.github.com/repos/TadeasKriz/aerogear-unifiedpush-server/languages","stargazers_url":"https://api.github.com/repos/TadeasKriz/aerogear-unifiedpush-server/stargazers","contributors_url":"https://api.github.com/repos/TadeasKriz/aerogear-unifiedpush-server/contributors","subscribers_url":"https://api.github.com/repos/TadeasKriz/aerogear-unifiedpush-server/subscribers","subscription_url":"https://api.github.com/repos/TadeasKriz/aerogear-unifiedpush-server/subscription","commits_url":"https://api.github.com/repos/TadeasKriz/aerogear-unifiedpush-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/TadeasKriz/aerogear-unifiedpush-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/TadeasKriz/aerogear-unifiedpush-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/TadeasKriz/aerogear-unifiedpush-server/issues/comments/{number}","contents_url":"https://api.github.com/repos/TadeasKriz/aerogear-unifiedpush-server/contents/{+path}","compare_url":"https://api.github.com/repos/TadeasKriz/aerogear-unifiedpush-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TadeasKriz/aerogear-unifiedpush-server/merges","archive_url":"https://api.github.com/repos/TadeasKriz/aerogear-unifiedpush-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TadeasKriz/aerogear-unifiedpush-server/downloads","issues_url":"https://api.github.com/repos/TadeasKriz/aerogear-unifiedpush-server/issues{/number}","pulls_url":"https://api.github.com/repos/TadeasKriz/aerogear-unifiedpush-server/pulls{/number}","milestones_url":"https://api.github.com/repos/TadeasKriz/aerogear-unifiedpush-server/milestones{/number}","notifications_url":"https://api.github.com/repos/TadeasKriz/aerogear-unifiedpush-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TadeasKriz/aerogear-unifiedpush-server/labels{/name}","releases_url":"https://api.github.com/repos/TadeasKriz/aerogear-unifiedpush-server/releases{/id}","created_at":"2013-10-07T16:02:42Z","updated_at":"2014-06-06T14:24:50Z","pushed_at":"2015-02-18T09:48:37Z","git_url":"git://github.com/TadeasKriz/aerogear-unifiedpush-server.git","ssh_url":"git@github.com:TadeasKriz/aerogear-unifiedpush-server.git","clone_url":"https://github.com/TadeasKriz/aerogear-unifiedpush-server.git","svn_url":"https://github.com/TadeasKriz/aerogear-unifiedpush-server","homepage":"aerogear.org","size":13639,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aerogear:master","ref":"master","sha":"48d27a5fa762ba165ccc3c5d6c8fa1391d3c1eb5","user":{"login":"aerogear","id":954205,"avatar_url":"https://avatars.githubusercontent.com/u/954205?v=3","gravatar_id":"","url":"https://api.github.com/users/aerogear","html_url":"https://github.com/aerogear","followers_url":"https://api.github.com/users/aerogear/followers","following_url":"https://api.github.com/users/aerogear/following{/other_user}","gists_url":"https://api.github.com/users/aerogear/gists{/gist_id}","starred_url":"https://api.github.com/users/aerogear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerogear/subscriptions","organizations_url":"https://api.github.com/users/aerogear/orgs","repos_url":"https://api.github.com/users/aerogear/repos","events_url":"https://api.github.com/users/aerogear/events{/privacy}","received_events_url":"https://api.github.com/users/aerogear/received_events","type":"Organization","site_admin":false},"repo":{"id":10624930,"name":"aerogear-unifiedpush-server","full_name":"aerogear/aerogear-unifiedpush-server","owner":{"login":"aerogear","id":954205,"avatar_url":"https://avatars.githubusercontent.com/u/954205?v=3","gravatar_id":"","url":"https://api.github.com/users/aerogear","html_url":"https://github.com/aerogear","followers_url":"https://api.github.com/users/aerogear/followers","following_url":"https://api.github.com/users/aerogear/following{/other_user}","gists_url":"https://api.github.com/users/aerogear/gists{/gist_id}","starred_url":"https://api.github.com/users/aerogear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerogear/subscriptions","organizations_url":"https://api.github.com/users/aerogear/orgs","repos_url":"https://api.github.com/users/aerogear/repos","events_url":"https://api.github.com/users/aerogear/events{/privacy}","received_events_url":"https://api.github.com/users/aerogear/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aerogear/aerogear-unifiedpush-server","description":"AeroGear UnifiedPush Server","fork":false,"url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server","forks_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/forks","keys_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/teams","hooks_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/hooks","issue_events_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/issues/events{/number}","events_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/events","assignees_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/assignees{/user}","branches_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/branches{/branch}","tags_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/tags","blobs_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/statuses/{sha}","languages_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/languages","stargazers_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/stargazers","contributors_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/contributors","subscribers_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/subscribers","subscription_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/subscription","commits_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/issues/comments/{number}","contents_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/contents/{+path}","compare_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/merges","archive_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/downloads","issues_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/issues{/number}","pulls_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/pulls{/number}","milestones_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/milestones{/number}","notifications_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/labels{/name}","releases_url":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/releases{/id}","created_at":"2013-06-11T15:48:01Z","updated_at":"2015-02-17T15:32:44Z","pushed_at":"2015-02-17T15:48:24Z","git_url":"git://github.com/aerogear/aerogear-unifiedpush-server.git","ssh_url":"git@github.com:aerogear/aerogear-unifiedpush-server.git","clone_url":"https://github.com/aerogear/aerogear-unifiedpush-server.git","svn_url":"https://github.com/aerogear/aerogear-unifiedpush-server","homepage":"aerogear.org","size":22577,"stargazers_count":131,"watchers_count":131,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":76,"mirror_url":null,"open_issues_count":4,"forks":76,"open_issues":4,"watchers":131,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/pulls/496"},"html":{"href":"https://github.com/aerogear/aerogear-unifiedpush-server/pull/496"},"issue":{"href":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/issues/496"},"comments":{"href":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/issues/496/comments"},"review_comments":{"href":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/pulls/496/comments"},"review_comment":{"href":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/pulls/496/commits"},"statuses":{"href":"https://api.github.com/repos/aerogear/aerogear-unifiedpush-server/statuses/722553b48748bbc2433600488468a30054350094"}}}}