{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/comments/33999953","id":33999953,"diff_hunk":"@@ -431,6 +431,22 @@ PrivMgrPrivileges::PrivMgrPrivileges (\n }\n \n // ----------------------------------------------------------------------------\n+// Construct a PrivMgrPrivileges object for on objectUID","path":"sql/sqlcomp/PrivMgrPrivileges.cpp","position":4,"original_position":4,"commit_id":"9c544706429a2dc42277376186e41b28a4ade0f6","original_commit_id":"9c544706429a2dc42277376186e41b28a4ade0f6","user":{"login":"arvind-narain","id":8054653,"avatar_url":"https://avatars.githubusercontent.com/u/8054653?v=3","gravatar_id":"","url":"https://api.github.com/users/arvind-narain","html_url":"https://github.com/arvind-narain","followers_url":"https://api.github.com/users/arvind-narain/followers","following_url":"https://api.github.com/users/arvind-narain/following{/other_user}","gists_url":"https://api.github.com/users/arvind-narain/gists{/gist_id}","starred_url":"https://api.github.com/users/arvind-narain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvind-narain/subscriptions","organizations_url":"https://api.github.com/users/arvind-narain/orgs","repos_url":"https://api.github.com/users/arvind-narain/repos","events_url":"https://api.github.com/users/arvind-narain/events{/privacy}","received_events_url":"https://api.github.com/users/arvind-narain/received_events","type":"User","site_admin":false},"body":"Looks good - Comment could be updated \"for an objectUID\" ","created_at":"2015-07-07T01:05:30Z","updated_at":"2015-07-07T01:05:30Z","html_url":"https://github.com/apache/incubator-trafodion/pull/19#discussion_r33999953","pull_request_url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/comments/33999953"},"html":{"href":"https://github.com/apache/incubator-trafodion/pull/19#discussion_r33999953"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/19","id":39303663,"html_url":"https://github.com/apache/incubator-trafodion/pull/19","diff_url":"https://github.com/apache/incubator-trafodion/pull/19.diff","patch_url":"https://github.com/apache/incubator-trafodion/pull/19.patch","issue_url":"https://api.github.com/repos/apache/incubator-trafodion/issues/19","number":19,"state":"open","locked":false,"title":"Fixes for 1438896 and 1465356","user":{"login":"robertamarton","id":13022496,"avatar_url":"https://avatars.githubusercontent.com/u/13022496?v=3","gravatar_id":"","url":"https://api.github.com/users/robertamarton","html_url":"https://github.com/robertamarton","followers_url":"https://api.github.com/users/robertamarton/followers","following_url":"https://api.github.com/users/robertamarton/following{/other_user}","gists_url":"https://api.github.com/users/robertamarton/gists{/gist_id}","starred_url":"https://api.github.com/users/robertamarton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertamarton/subscriptions","organizations_url":"https://api.github.com/users/robertamarton/orgs","repos_url":"https://api.github.com/users/robertamarton/repos","events_url":"https://api.github.com/users/robertamarton/events{/privacy}","received_events_url":"https://api.github.com/users/robertamarton/received_events","type":"User","site_admin":false},"body":"1438896: Internal error during create or replace view\r\n\r\nThe objectUID check when getting privilege information was not correct.\r\n\r\n1465356: Revoke privilege from role returns dependent object error\r\n\r\nThere is a check in mainline revoke code to determine if the object type is a\r\nview and if the SELECT privilege is no longer applicable. If so, then the\r\ndependent error is returned. However, this code is incorrect and actually the\r\ncorrect code exists in the gatherViewPrivileges method. The view check has been\r\nremoved.\r\n\r\nChange-Id: Ia1a00f18bad301dd1439c2ceb079d69808de7bdd","created_at":"2015-07-06T19:47:59Z","updated_at":"2015-07-07T01:05:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/19/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/19/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-trafodion/issues/19/comments","statuses_url":"https://api.github.com/repos/apache/incubator-trafodion/statuses/9c544706429a2dc42277376186e41b28a4ade0f6","head":{"label":"robertamarton:wrk","ref":"wrk","sha":"9c544706429a2dc42277376186e41b28a4ade0f6","user":{"login":"robertamarton","id":13022496,"avatar_url":"https://avatars.githubusercontent.com/u/13022496?v=3","gravatar_id":"","url":"https://api.github.com/users/robertamarton","html_url":"https://github.com/robertamarton","followers_url":"https://api.github.com/users/robertamarton/followers","following_url":"https://api.github.com/users/robertamarton/following{/other_user}","gists_url":"https://api.github.com/users/robertamarton/gists{/gist_id}","starred_url":"https://api.github.com/users/robertamarton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertamarton/subscriptions","organizations_url":"https://api.github.com/users/robertamarton/orgs","repos_url":"https://api.github.com/users/robertamarton/repos","events_url":"https://api.github.com/users/robertamarton/events{/privacy}","received_events_url":"https://api.github.com/users/robertamarton/received_events","type":"User","site_admin":false},"repo":{"id":38080155,"name":"incubator-trafodion","full_name":"robertamarton/incubator-trafodion","owner":{"login":"robertamarton","id":13022496,"avatar_url":"https://avatars.githubusercontent.com/u/13022496?v=3","gravatar_id":"","url":"https://api.github.com/users/robertamarton","html_url":"https://github.com/robertamarton","followers_url":"https://api.github.com/users/robertamarton/followers","following_url":"https://api.github.com/users/robertamarton/following{/other_user}","gists_url":"https://api.github.com/users/robertamarton/gists{/gist_id}","starred_url":"https://api.github.com/users/robertamarton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertamarton/subscriptions","organizations_url":"https://api.github.com/users/robertamarton/orgs","repos_url":"https://api.github.com/users/robertamarton/repos","events_url":"https://api.github.com/users/robertamarton/events{/privacy}","received_events_url":"https://api.github.com/users/robertamarton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robertamarton/incubator-trafodion","description":"Mirror of Apache Trafodion (Incubating)","fork":true,"url":"https://api.github.com/repos/robertamarton/incubator-trafodion","forks_url":"https://api.github.com/repos/robertamarton/incubator-trafodion/forks","keys_url":"https://api.github.com/repos/robertamarton/incubator-trafodion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robertamarton/incubator-trafodion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robertamarton/incubator-trafodion/teams","hooks_url":"https://api.github.com/repos/robertamarton/incubator-trafodion/hooks","issue_events_url":"https://api.github.com/repos/robertamarton/incubator-trafodion/issues/events{/number}","events_url":"https://api.github.com/repos/robertamarton/incubator-trafodion/events","assignees_url":"https://api.github.com/repos/robertamarton/incubator-trafodion/assignees{/user}","branches_url":"https://api.github.com/repos/robertamarton/incubator-trafodion/branches{/branch}","tags_url":"https://api.github.com/repos/robertamarton/incubator-trafodion/tags","blobs_url":"https://api.github.com/repos/robertamarton/incubator-trafodion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robertamarton/incubator-trafodion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robertamarton/incubator-trafodion/git/refs{/sha}","trees_url":"https://api.github.com/repos/robertamarton/incubator-trafodion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robertamarton/incubator-trafodion/statuses/{sha}","languages_url":"https://api.github.com/repos/robertamarton/incubator-trafodion/languages","stargazers_url":"https://api.github.com/repos/robertamarton/incubator-trafodion/stargazers","contributors_url":"https://api.github.com/repos/robertamarton/incubator-trafodion/contributors","subscribers_url":"https://api.github.com/repos/robertamarton/incubator-trafodion/subscribers","subscription_url":"https://api.github.com/repos/robertamarton/incubator-trafodion/subscription","commits_url":"https://api.github.com/repos/robertamarton/incubator-trafodion/commits{/sha}","git_commits_url":"https://api.github.com/repos/robertamarton/incubator-trafodion/git/commits{/sha}","comments_url":"https://api.github.com/repos/robertamarton/incubator-trafodion/comments{/number}","issue_comment_url":"https://api.github.com/repos/robertamarton/incubator-trafodion/issues/comments{/number}","contents_url":"https://api.github.com/repos/robertamarton/incubator-trafodion/contents/{+path}","compare_url":"https://api.github.com/repos/robertamarton/incubator-trafodion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robertamarton/incubator-trafodion/merges","archive_url":"https://api.github.com/repos/robertamarton/incubator-trafodion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robertamarton/incubator-trafodion/downloads","issues_url":"https://api.github.com/repos/robertamarton/incubator-trafodion/issues{/number}","pulls_url":"https://api.github.com/repos/robertamarton/incubator-trafodion/pulls{/number}","milestones_url":"https://api.github.com/repos/robertamarton/incubator-trafodion/milestones{/number}","notifications_url":"https://api.github.com/repos/robertamarton/incubator-trafodion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robertamarton/incubator-trafodion/labels{/name}","releases_url":"https://api.github.com/repos/robertamarton/incubator-trafodion/releases{/id}","created_at":"2015-06-25T23:40:10Z","updated_at":"2015-06-25T23:40:48Z","pushed_at":"2015-07-01T17:20:15Z","git_url":"git://github.com/robertamarton/incubator-trafodion.git","ssh_url":"git@github.com:robertamarton/incubator-trafodion.git","clone_url":"https://github.com/robertamarton/incubator-trafodion.git","svn_url":"https://github.com/robertamarton/incubator-trafodion","homepage":null,"size":49438,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"2cedff16df7a0b80596fc7e3b8e2223a72790d0d","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":36349344,"name":"incubator-trafodion","full_name":"apache/incubator-trafodion","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-trafodion","description":"Mirror of Apache Trafodion (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-trafodion","forks_url":"https://api.github.com/repos/apache/incubator-trafodion/forks","keys_url":"https://api.github.com/repos/apache/incubator-trafodion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-trafodion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-trafodion/teams","hooks_url":"https://api.github.com/repos/apache/incubator-trafodion/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-trafodion/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-trafodion/events","assignees_url":"https://api.github.com/repos/apache/incubator-trafodion/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-trafodion/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-trafodion/tags","blobs_url":"https://api.github.com/repos/apache/incubator-trafodion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-trafodion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-trafodion/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-trafodion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-trafodion/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-trafodion/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-trafodion/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-trafodion/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-trafodion/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-trafodion/subscription","commits_url":"https://api.github.com/repos/apache/incubator-trafodion/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-trafodion/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-trafodion/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-trafodion/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-trafodion/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-trafodion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-trafodion/merges","archive_url":"https://api.github.com/repos/apache/incubator-trafodion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-trafodion/downloads","issues_url":"https://api.github.com/repos/apache/incubator-trafodion/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-trafodion/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-trafodion/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-trafodion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-trafodion/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-trafodion/releases{/id}","created_at":"2015-05-27T07:00:05Z","updated_at":"2015-06-25T23:41:52Z","pushed_at":"2015-07-06T19:47:59Z","git_url":"git://github.com/apache/incubator-trafodion.git","ssh_url":"git@github.com:apache/incubator-trafodion.git","clone_url":"https://github.com/apache/incubator-trafodion.git","svn_url":"https://github.com/apache/incubator-trafodion","homepage":null,"size":49875,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":"git://git.apache.org/incubator-trafodion.git","open_issues_count":3,"forks":26,"open_issues":3,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/19"},"html":{"href":"https://github.com/apache/incubator-trafodion/pull/19"},"issue":{"href":"https://api.github.com/repos/apache/incubator-trafodion/issues/19"},"comments":{"href":"https://api.github.com/repos/apache/incubator-trafodion/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-trafodion/statuses/9c544706429a2dc42277376186e41b28a4ade0f6"}}}}