{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/22653795","id":22653795,"diff_hunk":"@@ -87,8 +87,8 @@ private static File explode() throws Exception {\n             throw new AssertionError(\"jenkins.war is not in the classpath. If you are running this from the core workspace, run 'mvn install' to create the war image in war/target/jenkins\");\n         File war = Which.jarFile(Class.forName(\"executable.Executable\"));\n \n-        // TODO this assumes that the CWD of the Maven process is the plugin ${basedir}, which may not be the case","path":"test/src/main/java/org/jvnet/hudson/test/WarExploder.java","position":4,"original_position":4,"commit_id":"8fede2c6537a702f26c0c83ff4dc841537ed0df4","original_commit_id":"8fede2c6537a702f26c0c83ff4dc841537ed0df4","user":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"body":"Do not delete this comment, which AFAIK is still a valid problem. It is also noted in `JenkinsRule` sources. `test/pom.xml` already defines `buildDirectory` to be an absolute path, it seems. But `plugins/pom.xml` leaves it unset, I think letting the fallback value be just `target` as a path relative to CWD. I presume the Gradle harness is already setting it; make sure it sets it to an absolute path.","created_at":"2015-01-08T14:28:56Z","updated_at":"2015-01-08T14:28:56Z","html_url":"https://github.com/jenkinsci/jenkins/pull/1519#discussion_r22653795","pull_request_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1519","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/22653795"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/1519#discussion_r22653795"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1519"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1519","id":27016004,"html_url":"https://github.com/jenkinsci/jenkins/pull/1519","diff_url":"https://github.com/jenkinsci/jenkins/pull/1519.diff","patch_url":"https://github.com/jenkinsci/jenkins/pull/1519.patch","issue_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/1519","number":1519,"state":"open","locked":false,"title":"[JENKINS-26331] configurable target directory for WarExploder","user":{"login":"daspilker","id":47957,"avatar_url":"https://avatars.githubusercontent.com/u/47957?v=3","gravatar_id":"","url":"https://api.github.com/users/daspilker","html_url":"https://github.com/daspilker","followers_url":"https://api.github.com/users/daspilker/followers","following_url":"https://api.github.com/users/daspilker/following{/other_user}","gists_url":"https://api.github.com/users/daspilker/gists{/gist_id}","starred_url":"https://api.github.com/users/daspilker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daspilker/subscriptions","organizations_url":"https://api.github.com/users/daspilker/orgs","repos_url":"https://api.github.com/users/daspilker/repos","events_url":"https://api.github.com/users/daspilker/events{/privacy}","received_events_url":"https://api.github.com/users/daspilker/received_events","type":"User","site_admin":false},"body":"See [JENKINS-26331](https://issues.jenkins-ci.org/browse/JENKINS-26331).\r\n\r\nThis uses the same system property as [JenkinsRule](https://github.com/jenkinsci/jenkins/blob/jenkins-1.596/test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java#L647) or [HudsonTestCase](https://github.com/jenkinsci/jenkins/blob/jenkins-1.596/test/src/main/java/org/jvnet/hudson/test/HudsonTestCase.java#L569).","created_at":"2015-01-08T09:29:45Z","updated_at":"2015-01-08T14:28:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f980016d9e47946e2d13571b5d5d33147c121903","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1519/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1519/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/1519/comments","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/8fede2c6537a702f26c0c83ff4dc841537ed0df4","head":{"label":"daspilker:JENKINS-26331","ref":"JENKINS-26331","sha":"8fede2c6537a702f26c0c83ff4dc841537ed0df4","user":{"login":"daspilker","id":47957,"avatar_url":"https://avatars.githubusercontent.com/u/47957?v=3","gravatar_id":"","url":"https://api.github.com/users/daspilker","html_url":"https://github.com/daspilker","followers_url":"https://api.github.com/users/daspilker/followers","following_url":"https://api.github.com/users/daspilker/following{/other_user}","gists_url":"https://api.github.com/users/daspilker/gists{/gist_id}","starred_url":"https://api.github.com/users/daspilker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daspilker/subscriptions","organizations_url":"https://api.github.com/users/daspilker/orgs","repos_url":"https://api.github.com/users/daspilker/repos","events_url":"https://api.github.com/users/daspilker/events{/privacy}","received_events_url":"https://api.github.com/users/daspilker/received_events","type":"User","site_admin":false},"repo":{"id":15698820,"name":"jenkins","full_name":"daspilker/jenkins","owner":{"login":"daspilker","id":47957,"avatar_url":"https://avatars.githubusercontent.com/u/47957?v=3","gravatar_id":"","url":"https://api.github.com/users/daspilker","html_url":"https://github.com/daspilker","followers_url":"https://api.github.com/users/daspilker/followers","following_url":"https://api.github.com/users/daspilker/following{/other_user}","gists_url":"https://api.github.com/users/daspilker/gists{/gist_id}","starred_url":"https://api.github.com/users/daspilker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daspilker/subscriptions","organizations_url":"https://api.github.com/users/daspilker/orgs","repos_url":"https://api.github.com/users/daspilker/repos","events_url":"https://api.github.com/users/daspilker/events{/privacy}","received_events_url":"https://api.github.com/users/daspilker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/daspilker/jenkins","description":"Jenkins Continuous Integration Server","fork":true,"url":"https://api.github.com/repos/daspilker/jenkins","forks_url":"https://api.github.com/repos/daspilker/jenkins/forks","keys_url":"https://api.github.com/repos/daspilker/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daspilker/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daspilker/jenkins/teams","hooks_url":"https://api.github.com/repos/daspilker/jenkins/hooks","issue_events_url":"https://api.github.com/repos/daspilker/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/daspilker/jenkins/events","assignees_url":"https://api.github.com/repos/daspilker/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/daspilker/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/daspilker/jenkins/tags","blobs_url":"https://api.github.com/repos/daspilker/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daspilker/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daspilker/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/daspilker/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daspilker/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/daspilker/jenkins/languages","stargazers_url":"https://api.github.com/repos/daspilker/jenkins/stargazers","contributors_url":"https://api.github.com/repos/daspilker/jenkins/contributors","subscribers_url":"https://api.github.com/repos/daspilker/jenkins/subscribers","subscription_url":"https://api.github.com/repos/daspilker/jenkins/subscription","commits_url":"https://api.github.com/repos/daspilker/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/daspilker/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/daspilker/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/daspilker/jenkins/issues/comments/{number}","contents_url":"https://api.github.com/repos/daspilker/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/daspilker/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daspilker/jenkins/merges","archive_url":"https://api.github.com/repos/daspilker/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daspilker/jenkins/downloads","issues_url":"https://api.github.com/repos/daspilker/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/daspilker/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/daspilker/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/daspilker/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daspilker/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/daspilker/jenkins/releases{/id}","created_at":"2014-01-07T08:19:10Z","updated_at":"2014-01-14T19:48:39Z","pushed_at":"2015-01-08T09:25:16Z","git_url":"git://github.com/daspilker/jenkins.git","ssh_url":"git@github.com:daspilker/jenkins.git","clone_url":"https://github.com/daspilker/jenkins.git","svn_url":"https://github.com/daspilker/jenkins","homepage":"http://jenkins-ci.org/","size":72474,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"84575541491cf44f9b27f867b57bf5f460849d8f","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":1103607,"name":"jenkins","full_name":"jenkinsci/jenkins","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/jenkins","description":"Jenkins Continuous Integration Server","fork":true,"url":"https://api.github.com/repos/jenkinsci/jenkins","forks_url":"https://api.github.com/repos/jenkinsci/jenkins/forks","keys_url":"https://api.github.com/repos/jenkinsci/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/jenkins/teams","hooks_url":"https://api.github.com/repos/jenkinsci/jenkins/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/jenkins/events","assignees_url":"https://api.github.com/repos/jenkinsci/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/jenkins/tags","blobs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/jenkins/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/jenkins/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/jenkins/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/jenkins/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/jenkins/subscription","commits_url":"https://api.github.com/repos/jenkinsci/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/comments/{number}","contents_url":"https://api.github.com/repos/jenkinsci/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/jenkins/merges","archive_url":"https://api.github.com/repos/jenkinsci/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/jenkins/downloads","issues_url":"https://api.github.com/repos/jenkinsci/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/jenkins/releases{/id}","created_at":"2010-11-22T21:21:23Z","updated_at":"2015-01-08T12:53:34Z","pushed_at":"2015-01-07T20:53:36Z","git_url":"git://github.com/jenkinsci/jenkins.git","ssh_url":"git@github.com:jenkinsci/jenkins.git","clone_url":"https://github.com/jenkinsci/jenkins.git","svn_url":"https://github.com/jenkinsci/jenkins","homepage":"http://jenkins-ci.org/","size":392069,"stargazers_count":3527,"watchers_count":3527,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1617,"mirror_url":null,"open_issues_count":89,"forks":1617,"open_issues":89,"watchers":3527,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1519"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/1519"},"issue":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/1519"},"comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/1519/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1519/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1519/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/jenkins/statuses/8fede2c6537a702f26c0c83ff4dc841537ed0df4"}}}}