{"action":"created","issue":{"url":"https://api.github.com/repos/ded/bowser/issues/105","labels_url":"https://api.github.com/repos/ded/bowser/issues/105/labels{/name}","comments_url":"https://api.github.com/repos/ded/bowser/issues/105/comments","events_url":"https://api.github.com/repos/ded/bowser/issues/105/events","html_url":"https://github.com/ded/bowser/pull/105","id":110588744,"number":105,"title":"Expose the UA's os as a property on the results","user":{"login":"wbinnssmith","id":755844,"avatar_url":"https://avatars.githubusercontent.com/u/755844?v=3","gravatar_id":"","url":"https://api.github.com/users/wbinnssmith","html_url":"https://github.com/wbinnssmith","followers_url":"https://api.github.com/users/wbinnssmith/followers","following_url":"https://api.github.com/users/wbinnssmith/following{/other_user}","gists_url":"https://api.github.com/users/wbinnssmith/gists{/gist_id}","starred_url":"https://api.github.com/users/wbinnssmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wbinnssmith/subscriptions","organizations_url":"https://api.github.com/users/wbinnssmith/orgs","repos_url":"https://api.github.com/users/wbinnssmith/repos","events_url":"https://api.github.com/users/wbinnssmith/events{/privacy}","received_events_url":"https://api.github.com/users/wbinnssmith/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-09T05:20:04Z","updated_at":"2015-10-29T21:25:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ded/bowser/pulls/105","html_url":"https://github.com/ded/bowser/pull/105","diff_url":"https://github.com/ded/bowser/pull/105.diff","patch_url":"https://github.com/ded/bowser/pull/105.patch"},"body":"Resolves #98\r\n\r\nThis adds a property for the browser's operating system to the results object. A couple notes:\r\n\r\n* I changed `chromeBook` to `chromeos` as `CrOS` will match things like chrome*boxes* in addition to chromebooks and I think it makes sense in this case to reflect the OS rather than the hardware (the only other place this is done is with iPad/iPod/iPhone). Kept `chromeBook` for backwards compat.\r\n\r\n* Use `linux` for traditional desktop linux systems and leaves the specific vendor names like `android`, `chromeos`, `sailfish`, etc. for those projects that are just built on the kernel and don't use traditional gtk, etc.\r\n\r\n* Use `windows` for windows UAs that aren't windows phone\r\n\r\n* Hoisted up a bunch of the regexes. Getting the feeling that the creation of the results object could be broken up into stages, where each stage adds an appropriate category of property (browser name, os, os version, etc). They're a bit intertwined at the moment.\r\n\r\nAppreciate your feedback. Thanks for the awesome module!"},"comment":{"url":"https://api.github.com/repos/ded/bowser/issues/comments/152332732","html_url":"https://github.com/ded/bowser/pull/105#issuecomment-152332732","issue_url":"https://api.github.com/repos/ded/bowser/issues/105","id":152332732,"user":{"login":"mhulse","id":218624,"avatar_url":"https://avatars.githubusercontent.com/u/218624?v=3","gravatar_id":"","url":"https://api.github.com/users/mhulse","html_url":"https://github.com/mhulse","followers_url":"https://api.github.com/users/mhulse/followers","following_url":"https://api.github.com/users/mhulse/following{/other_user}","gists_url":"https://api.github.com/users/mhulse/gists{/gist_id}","starred_url":"https://api.github.com/users/mhulse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhulse/subscriptions","organizations_url":"https://api.github.com/users/mhulse/orgs","repos_url":"https://api.github.com/users/mhulse/repos","events_url":"https://api.github.com/users/mhulse/events{/privacy}","received_events_url":"https://api.github.com/users/mhulse/received_events","type":"User","site_admin":false},"created_at":"2015-10-29T21:25:19Z","updated_at":"2015-10-29T21:25:19Z","body":"> I'm also thinking it would be useful to expose an os property on the results with the OS in it in the same way name as a string is exposed in addition to a property representing the browser's name. What do you think?\r\n\r\n+1. I think having an `os` key would be of some help. In my case, I need to just output the name of the OS. As your code modifications stand currently, that would not be as easy to do.\r\n\r\nThanks for your work on this @wbinnssmith!"}}