{"comment":{"url":"https://api.github.com/repos/getlantern/lantern_aws/comments/13112206","html_url":"https://github.com/getlantern/lantern_aws/commit/238478da065e7fc166262191aff1c0236d89aa41#commitcomment-13112206","id":13112206,"user":{"login":"aranhoide","id":2204867,"avatar_url":"https://avatars.githubusercontent.com/u/2204867?v=3","gravatar_id":"","url":"https://api.github.com/users/aranhoide","html_url":"https://github.com/aranhoide","followers_url":"https://api.github.com/users/aranhoide/followers","following_url":"https://api.github.com/users/aranhoide/following{/other_user}","gists_url":"https://api.github.com/users/aranhoide/gists{/gist_id}","starred_url":"https://api.github.com/users/aranhoide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aranhoide/subscriptions","organizations_url":"https://api.github.com/users/aranhoide/orgs","repos_url":"https://api.github.com/users/aranhoide/repos","events_url":"https://api.github.com/users/aranhoide/events{/privacy}","received_events_url":"https://api.github.com/users/aranhoide/received_events","type":"User","site_admin":false},"position":14,"line":145,"path":"salt/fallback_proxy/init.sls","commit_id":"238478da065e7fc166262191aff1c0236d89aa41","created_at":"2015-09-08T13:36:04Z","updated_at":"2015-09-08T13:36:04Z","body":"As it is, this means we'll install ats every time we apply the Salt config in this machine.  To prevent that, we could add an `- unless:` clause to this state.  Is there a reliable way to tell whether the install was successful?  What about adding `set -e` at the beginning of the script and adding something like `touch /home/lantern/ats_installed` at the end?  Then we could add `- unless: \"[ -e /home/lantern/ats_installed ]\"`.\r\n\r\nAnyway, it's probably OK to have it like this as a first shot.  We can refine this later."}}