{"action":"created","issue":{"url":"https://api.github.com/repos/puppet-community/puppet-stash/issues/59","labels_url":"https://api.github.com/repos/puppet-community/puppet-stash/issues/59/labels{/name}","comments_url":"https://api.github.com/repos/puppet-community/puppet-stash/issues/59/comments","events_url":"https://api.github.com/repos/puppet-community/puppet-stash/issues/59/events","html_url":"https://github.com/puppet-community/puppet-stash/pull/59","id":64099569,"number":59,"title":"(Issue #58) Do not hard code java path in backup class.","user":{"login":"mkrakowitzer","id":454776,"avatar_url":"https://avatars.githubusercontent.com/u/454776?v=3","gravatar_id":"","url":"https://api.github.com/users/mkrakowitzer","html_url":"https://github.com/mkrakowitzer","followers_url":"https://api.github.com/users/mkrakowitzer/followers","following_url":"https://api.github.com/users/mkrakowitzer/following{/other_user}","gists_url":"https://api.github.com/users/mkrakowitzer/gists{/gist_id}","starred_url":"https://api.github.com/users/mkrakowitzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkrakowitzer/subscriptions","organizations_url":"https://api.github.com/users/mkrakowitzer/orgs","repos_url":"https://api.github.com/users/mkrakowitzer/repos","events_url":"https://api.github.com/users/mkrakowitzer/events{/privacy}","received_events_url":"https://api.github.com/users/mkrakowitzer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-03-24T21:08:39Z","updated_at":"2015-03-25T23:54:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/puppet-community/puppet-stash/pulls/59","html_url":"https://github.com/puppet-community/puppet-stash/pull/59","diff_url":"https://github.com/puppet-community/puppet-stash/pull/59.diff","patch_url":"https://github.com/puppet-community/puppet-stash/pull/59.patch"},"body":"Since the javahome parameter is required. It makes sense to use the\r\npath ${javahome}/bin/java."},"comment":{"url":"https://api.github.com/repos/puppet-community/puppet-stash/issues/comments/86255872","html_url":"https://github.com/puppet-community/puppet-stash/pull/59#issuecomment-86255872","issue_url":"https://api.github.com/repos/puppet-community/puppet-stash/issues/59","id":86255872,"user":{"login":"ryanycoleman","id":1148878,"avatar_url":"https://avatars.githubusercontent.com/u/1148878?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanycoleman","html_url":"https://github.com/ryanycoleman","followers_url":"https://api.github.com/users/ryanycoleman/followers","following_url":"https://api.github.com/users/ryanycoleman/following{/other_user}","gists_url":"https://api.github.com/users/ryanycoleman/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanycoleman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanycoleman/subscriptions","organizations_url":"https://api.github.com/users/ryanycoleman/orgs","repos_url":"https://api.github.com/users/ryanycoleman/repos","events_url":"https://api.github.com/users/ryanycoleman/events{/privacy}","received_events_url":"https://api.github.com/users/ryanycoleman/received_events","type":"User","site_admin":false},"created_at":"2015-03-25T23:54:11Z","updated_at":"2015-03-25T23:54:11Z","body":"@ffrank I feel like I'm missing a piece of context. How's the Forge forcing that behavior?\r\n\r\nI agree with you regarding keeping the module discrete and expecting someone to provide their own java. To me, it's a trade-off between simplicity for someone who just wants to `puppet module install` and `puppet agent -t` vs flexibility for those who want to choose which content satisfies the dependencies. \r\n\r\nFor something as big as Atlasssian Stash, I think it's safe to expect someone to do the extra work to satisfy the dependency on java. Bonus points for including in the README docs on how to satisfy the dependency with puppetlabs-java. "}}