{"action":"created","issue":{"url":"https://api.github.com/repos/andrefarzat/ng-jcrop/issues/38","labels_url":"https://api.github.com/repos/andrefarzat/ng-jcrop/issues/38/labels{/name}","comments_url":"https://api.github.com/repos/andrefarzat/ng-jcrop/issues/38/comments","events_url":"https://api.github.com/repos/andrefarzat/ng-jcrop/issues/38/events","html_url":"https://github.com/andrefarzat/ng-jcrop/issues/38","id":115779540,"number":38,"title":"Accidentally using \"shade\" mode?","user":{"login":"scottybrown","id":3635061,"avatar_url":"https://avatars.githubusercontent.com/u/3635061?v=3","gravatar_id":"","url":"https://api.github.com/users/scottybrown","html_url":"https://github.com/scottybrown","followers_url":"https://api.github.com/users/scottybrown/followers","following_url":"https://api.github.com/users/scottybrown/following{/other_user}","gists_url":"https://api.github.com/users/scottybrown/gists{/gist_id}","starred_url":"https://api.github.com/users/scottybrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottybrown/subscriptions","organizations_url":"https://api.github.com/users/scottybrown/orgs","repos_url":"https://api.github.com/users/scottybrown/repos","events_url":"https://api.github.com/users/scottybrown/events{/privacy}","received_events_url":"https://api.github.com/users/scottybrown/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/andrefarzat/ng-jcrop/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-11-09T02:16:03Z","updated_at":"2015-11-10T05:58:48Z","closed_at":null,"body":"JCrop has a shade mode whereby the grey area surrounding the crop selection box is made up of 4 grey squares, rather than a second image with opacity set to appear grey. This can be seen in the JCrop Github tutorial 4 as an experimental feature.\r\n\r\nng-jcrop seems to be using shade mode accidentally. It calls jQuery.Jcrop($scope.mainImg, config), but I think it should be passing in $scope.mainImg[0] which has a tagName set to IMG rather than undefined.\r\n\r\nShade mode seems to work okay so the impact is probably negligible for most users. The impact for us is that we're trying to modify the crop selection to be circular instead of square. This is much more difficult in shade mode."},"comment":{"url":"https://api.github.com/repos/andrefarzat/ng-jcrop/issues/comments/155305095","html_url":"https://github.com/andrefarzat/ng-jcrop/issues/38#issuecomment-155305095","issue_url":"https://api.github.com/repos/andrefarzat/ng-jcrop/issues/38","id":155305095,"user":{"login":"scottybrown","id":3635061,"avatar_url":"https://avatars.githubusercontent.com/u/3635061?v=3","gravatar_id":"","url":"https://api.github.com/users/scottybrown","html_url":"https://github.com/scottybrown","followers_url":"https://api.github.com/users/scottybrown/followers","following_url":"https://api.github.com/users/scottybrown/following{/other_user}","gists_url":"https://api.github.com/users/scottybrown/gists{/gist_id}","starred_url":"https://api.github.com/users/scottybrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottybrown/subscriptions","organizations_url":"https://api.github.com/users/scottybrown/orgs","repos_url":"https://api.github.com/users/scottybrown/repos","events_url":"https://api.github.com/users/scottybrown/events{/privacy}","received_events_url":"https://api.github.com/users/scottybrown/received_events","type":"User","site_admin":false},"created_at":"2015-11-10T05:58:48Z","updated_at":"2015-11-10T05:58:48Z","body":"Yeah no problem.\r\nI ran the demo and it all seems good. The 3 demos seem to work and definitely aren't using shade mode.\r\nI did get a couple of test failures, not sure if that's something on my end or not.\r\n![screen shot 2015-11-10 at 4 58 28 pm](https://cloud.githubusercontent.com/assets/3635061/11055536/4b0bca3a-87cc-11e5-9044-26d17c2c72f2.png)\r\n"}}