{"action":"created","issue":{"url":"https://api.github.com/repos/hannorein/rebound/issues/73","labels_url":"https://api.github.com/repos/hannorein/rebound/issues/73/labels{/name}","comments_url":"https://api.github.com/repos/hannorein/rebound/issues/73/comments","events_url":"https://api.github.com/repos/hannorein/rebound/issues/73/events","html_url":"https://github.com/hannorein/rebound/issues/73","id":101961126,"number":73,"title":"Exact Finish Time","user":{"login":"hannorein","id":53376,"avatar_url":"https://avatars.githubusercontent.com/u/53376?v=3","gravatar_id":"","url":"https://api.github.com/users/hannorein","html_url":"https://github.com/hannorein","followers_url":"https://api.github.com/users/hannorein/followers","following_url":"https://api.github.com/users/hannorein/following{/other_user}","gists_url":"https://api.github.com/users/hannorein/gists{/gist_id}","starred_url":"https://api.github.com/users/hannorein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hannorein/subscriptions","organizations_url":"https://api.github.com/users/hannorein/orgs","repos_url":"https://api.github.com/users/hannorein/repos","events_url":"https://api.github.com/users/hannorein/events{/privacy}","received_events_url":"https://api.github.com/users/hannorein/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-08-19T18:06:04Z","updated_at":"2015-10-23T15:40:06Z","closed_at":null,"body":"Currently, the exact finish time variable is inconsistent between python and c. Once again. Certainly my fault. \r\n\r\nThe question is how to choose the best default behaviour. Right now c has it set to 0 and python to 1.\r\n\r\nIdea?"},"comment":{"url":"https://api.github.com/repos/hannorein/rebound/issues/comments/150611311","html_url":"https://github.com/hannorein/rebound/issues/73#issuecomment-150611311","issue_url":"https://api.github.com/repos/hannorein/rebound/issues/73","id":150611311,"user":{"login":"dtamayo","id":3408023,"avatar_url":"https://avatars.githubusercontent.com/u/3408023?v=3","gravatar_id":"","url":"https://api.github.com/users/dtamayo","html_url":"https://github.com/dtamayo","followers_url":"https://api.github.com/users/dtamayo/followers","following_url":"https://api.github.com/users/dtamayo/following{/other_user}","gists_url":"https://api.github.com/users/dtamayo/gists{/gist_id}","starred_url":"https://api.github.com/users/dtamayo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtamayo/subscriptions","organizations_url":"https://api.github.com/users/dtamayo/orgs","repos_url":"https://api.github.com/users/dtamayo/repos","events_url":"https://api.github.com/users/dtamayo/events{/privacy}","received_events_url":"https://api.github.com/users/dtamayo/received_events","type":"User","site_admin":false},"created_at":"2015-10-23T15:40:06Z","updated_at":"2015-10-23T15:40:06Z","body":"OK.  That would also give me a reason to go through the ipython examples and change the calculate_orbits to use the new particles[i].element format.  Unless you have an objection to that, do you want to split it up—I’ll do the ipython examples and you can do the C ones?\n\nAlso, the reason we had calculate_orbits in simulation.py was because you couldn’t do jacobi coordinates from within particle.calculate_orbit, since it needed to know about the other particles.  Now we don’t have that limitation, and I think it makes sense to compartmentalize that functionality within the particle class.  Then if you had a thousand planetesimals and a planet, you could calculate the elements of the planet all at once, but without doing the entire simulation.  Would you agree with that?  If so, I can remove sim.calculate_orbits and update all the ipython examples at once.\n\n> On Oct 23, 2015, at 11:29 AM, Hanno Rein <notifications@github.com> wrote:\n> \n> I tend to agree. We'd need to go through all the tutorials and examples to make sure it's consistent.\n> \n> —\n> Reply to this email directly or view it on GitHub <https://github.com/hannorein/rebound/issues/73#issuecomment-150608133>.\n> \n\n"}}