{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/rDSN/pulls/comments/45573014","id":45573014,"diff_hunk":"@@ -133,13 +133,17 @@ class mutation_queue\n     ~mutation_queue()\n     {\n         clear();\n+        // TODO(qinzuoyan): if primary writing is failed (prepare failure or writing log failure),","path":"src/apps/replication/lib/mutation.h","position":4,"original_position":4,"commit_id":"ca42279268ce8ed911b5e58f82654a6c869840d5","original_commit_id":"ca42279268ce8ed911b5e58f82654a6c869840d5","user":{"login":"imzhenyu","id":6927143,"avatar_url":"https://avatars.githubusercontent.com/u/6927143?v=3","gravatar_id":"","url":"https://api.github.com/users/imzhenyu","html_url":"https://github.com/imzhenyu","followers_url":"https://api.github.com/users/imzhenyu/followers","following_url":"https://api.github.com/users/imzhenyu/following{/other_user}","gists_url":"https://api.github.com/users/imzhenyu/gists{/gist_id}","starred_url":"https://api.github.com/users/imzhenyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imzhenyu/subscriptions","organizations_url":"https://api.github.com/users/imzhenyu/orgs","repos_url":"https://api.github.com/users/imzhenyu/repos","events_url":"https://api.github.com/users/imzhenyu/events{/privacy}","received_events_url":"https://api.github.com/users/imzhenyu/received_events","type":"User","site_admin":false},"body":"right, so condition is too strong. it was deleted in other repos and will be pushed later.","created_at":"2015-11-23T05:11:28Z","updated_at":"2015-11-23T05:11:28Z","html_url":"https://github.com/Microsoft/rDSN/pull/100#discussion_r45573014","pull_request_url":"https://api.github.com/repos/Microsoft/rDSN/pulls/100","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/rDSN/pulls/comments/45573014"},"html":{"href":"https://github.com/Microsoft/rDSN/pull/100#discussion_r45573014"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/rDSN/pulls/100"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/rDSN/pulls/100","id":51485746,"html_url":"https://github.com/Microsoft/rDSN/pull/100","diff_url":"https://github.com/Microsoft/rDSN/pull/100.diff","patch_url":"https://github.com/Microsoft/rDSN/pull/100.patch","issue_url":"https://api.github.com/repos/Microsoft/rDSN/issues/100","number":100,"state":"open","locked":false,"title":"add core/replication unit tests; fix some bug; some refactors","user":{"login":"qinzuoyan","id":528445,"avatar_url":"https://avatars.githubusercontent.com/u/528445?v=3","gravatar_id":"","url":"https://api.github.com/users/qinzuoyan","html_url":"https://github.com/qinzuoyan","followers_url":"https://api.github.com/users/qinzuoyan/followers","following_url":"https://api.github.com/users/qinzuoyan/following{/other_user}","gists_url":"https://api.github.com/users/qinzuoyan/gists{/gist_id}","starred_url":"https://api.github.com/users/qinzuoyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qinzuoyan/subscriptions","organizations_url":"https://api.github.com/users/qinzuoyan/orgs","repos_url":"https://api.github.com/users/qinzuoyan/repos","events_url":"https://api.github.com/users/qinzuoyan/events{/privacy}","received_events_url":"https://api.github.com/users/qinzuoyan/received_events","type":"User","site_admin":false},"body":"1. add unit tests in src/core/tests\r\n2. add replication tests in src/rep_tests\r\n3. fix some bugs\r\n4. some code refactors","created_at":"2015-11-23T03:45:28Z","updated_at":"2015-11-23T05:11:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf8e4592b7c3ce92189657a996d56fbfb1c353be","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/rDSN/pulls/100/commits","review_comments_url":"https://api.github.com/repos/Microsoft/rDSN/pulls/100/comments","review_comment_url":"https://api.github.com/repos/Microsoft/rDSN/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/rDSN/issues/100/comments","statuses_url":"https://api.github.com/repos/Microsoft/rDSN/statuses/ca42279268ce8ed911b5e58f82654a6c869840d5","head":{"label":"qinzuoyan:staging","ref":"staging","sha":"ca42279268ce8ed911b5e58f82654a6c869840d5","user":{"login":"qinzuoyan","id":528445,"avatar_url":"https://avatars.githubusercontent.com/u/528445?v=3","gravatar_id":"","url":"https://api.github.com/users/qinzuoyan","html_url":"https://github.com/qinzuoyan","followers_url":"https://api.github.com/users/qinzuoyan/followers","following_url":"https://api.github.com/users/qinzuoyan/following{/other_user}","gists_url":"https://api.github.com/users/qinzuoyan/gists{/gist_id}","starred_url":"https://api.github.com/users/qinzuoyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qinzuoyan/subscriptions","organizations_url":"https://api.github.com/users/qinzuoyan/orgs","repos_url":"https://api.github.com/users/qinzuoyan/repos","events_url":"https://api.github.com/users/qinzuoyan/events{/privacy}","received_events_url":"https://api.github.com/users/qinzuoyan/received_events","type":"User","site_admin":false},"repo":{"id":38676944,"name":"rDSN","full_name":"qinzuoyan/rDSN","owner":{"login":"qinzuoyan","id":528445,"avatar_url":"https://avatars.githubusercontent.com/u/528445?v=3","gravatar_id":"","url":"https://api.github.com/users/qinzuoyan","html_url":"https://github.com/qinzuoyan","followers_url":"https://api.github.com/users/qinzuoyan/followers","following_url":"https://api.github.com/users/qinzuoyan/following{/other_user}","gists_url":"https://api.github.com/users/qinzuoyan/gists{/gist_id}","starred_url":"https://api.github.com/users/qinzuoyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qinzuoyan/subscriptions","organizations_url":"https://api.github.com/users/qinzuoyan/orgs","repos_url":"https://api.github.com/users/qinzuoyan/repos","events_url":"https://api.github.com/users/qinzuoyan/events{/privacy}","received_events_url":"https://api.github.com/users/qinzuoyan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/qinzuoyan/rDSN","description":"Robust Distributed System Nucleus (rDSN) is an open framework for quickly building and managing high performance and robust distributed systems.","fork":true,"url":"https://api.github.com/repos/qinzuoyan/rDSN","forks_url":"https://api.github.com/repos/qinzuoyan/rDSN/forks","keys_url":"https://api.github.com/repos/qinzuoyan/rDSN/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qinzuoyan/rDSN/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qinzuoyan/rDSN/teams","hooks_url":"https://api.github.com/repos/qinzuoyan/rDSN/hooks","issue_events_url":"https://api.github.com/repos/qinzuoyan/rDSN/issues/events{/number}","events_url":"https://api.github.com/repos/qinzuoyan/rDSN/events","assignees_url":"https://api.github.com/repos/qinzuoyan/rDSN/assignees{/user}","branches_url":"https://api.github.com/repos/qinzuoyan/rDSN/branches{/branch}","tags_url":"https://api.github.com/repos/qinzuoyan/rDSN/tags","blobs_url":"https://api.github.com/repos/qinzuoyan/rDSN/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qinzuoyan/rDSN/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qinzuoyan/rDSN/git/refs{/sha}","trees_url":"https://api.github.com/repos/qinzuoyan/rDSN/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qinzuoyan/rDSN/statuses/{sha}","languages_url":"https://api.github.com/repos/qinzuoyan/rDSN/languages","stargazers_url":"https://api.github.com/repos/qinzuoyan/rDSN/stargazers","contributors_url":"https://api.github.com/repos/qinzuoyan/rDSN/contributors","subscribers_url":"https://api.github.com/repos/qinzuoyan/rDSN/subscribers","subscription_url":"https://api.github.com/repos/qinzuoyan/rDSN/subscription","commits_url":"https://api.github.com/repos/qinzuoyan/rDSN/commits{/sha}","git_commits_url":"https://api.github.com/repos/qinzuoyan/rDSN/git/commits{/sha}","comments_url":"https://api.github.com/repos/qinzuoyan/rDSN/comments{/number}","issue_comment_url":"https://api.github.com/repos/qinzuoyan/rDSN/issues/comments{/number}","contents_url":"https://api.github.com/repos/qinzuoyan/rDSN/contents/{+path}","compare_url":"https://api.github.com/repos/qinzuoyan/rDSN/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qinzuoyan/rDSN/merges","archive_url":"https://api.github.com/repos/qinzuoyan/rDSN/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qinzuoyan/rDSN/downloads","issues_url":"https://api.github.com/repos/qinzuoyan/rDSN/issues{/number}","pulls_url":"https://api.github.com/repos/qinzuoyan/rDSN/pulls{/number}","milestones_url":"https://api.github.com/repos/qinzuoyan/rDSN/milestones{/number}","notifications_url":"https://api.github.com/repos/qinzuoyan/rDSN/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qinzuoyan/rDSN/labels{/name}","releases_url":"https://api.github.com/repos/qinzuoyan/rDSN/releases{/id}","created_at":"2015-07-07T09:15:38Z","updated_at":"2015-07-07T09:15:39Z","pushed_at":"2015-11-23T03:56:51Z","git_url":"git://github.com/qinzuoyan/rDSN.git","ssh_url":"git@github.com:qinzuoyan/rDSN.git","clone_url":"https://github.com/qinzuoyan/rDSN.git","svn_url":"https://github.com/qinzuoyan/rDSN","homepage":null,"size":44862,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"staging"}},"base":{"label":"Microsoft:staging","ref":"staging","sha":"384ff4f906dc5eaf61f4da3a0e7ee5e96e6622ce","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":35526700,"name":"rDSN","full_name":"Microsoft/rDSN","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/rDSN","description":"Robust Distributed System Nucleus (rDSN) is an open framework for quickly building and managing high performance and robust distributed systems.","fork":false,"url":"https://api.github.com/repos/Microsoft/rDSN","forks_url":"https://api.github.com/repos/Microsoft/rDSN/forks","keys_url":"https://api.github.com/repos/Microsoft/rDSN/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/rDSN/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/rDSN/teams","hooks_url":"https://api.github.com/repos/Microsoft/rDSN/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/rDSN/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/rDSN/events","assignees_url":"https://api.github.com/repos/Microsoft/rDSN/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/rDSN/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/rDSN/tags","blobs_url":"https://api.github.com/repos/Microsoft/rDSN/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/rDSN/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/rDSN/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/rDSN/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/rDSN/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/rDSN/languages","stargazers_url":"https://api.github.com/repos/Microsoft/rDSN/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/rDSN/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/rDSN/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/rDSN/subscription","commits_url":"https://api.github.com/repos/Microsoft/rDSN/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/rDSN/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/rDSN/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/rDSN/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/rDSN/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/rDSN/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/rDSN/merges","archive_url":"https://api.github.com/repos/Microsoft/rDSN/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/rDSN/downloads","issues_url":"https://api.github.com/repos/Microsoft/rDSN/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/rDSN/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/rDSN/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/rDSN/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/rDSN/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/rDSN/releases{/id}","created_at":"2015-05-13T03:42:34Z","updated_at":"2015-11-21T02:16:42Z","pushed_at":"2015-11-23T03:56:51Z","git_url":"git://github.com/Microsoft/rDSN.git","ssh_url":"git@github.com:Microsoft/rDSN.git","clone_url":"https://github.com/Microsoft/rDSN.git","svn_url":"https://github.com/Microsoft/rDSN","homepage":null,"size":44886,"stargazers_count":411,"watchers_count":411,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":110,"mirror_url":null,"open_issues_count":2,"forks":110,"open_issues":2,"watchers":411,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/rDSN/pulls/100"},"html":{"href":"https://github.com/Microsoft/rDSN/pull/100"},"issue":{"href":"https://api.github.com/repos/Microsoft/rDSN/issues/100"},"comments":{"href":"https://api.github.com/repos/Microsoft/rDSN/issues/100/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/rDSN/pulls/100/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/rDSN/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/rDSN/pulls/100/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/rDSN/statuses/ca42279268ce8ed911b5e58f82654a6c869840d5"}}}}