{"action":"opened","number":4,"pull_request":{"url":"https://api.github.com/repos/mikkyang/rust-blas/pulls/4","id":37267381,"html_url":"https://github.com/mikkyang/rust-blas/pull/4","diff_url":"https://github.com/mikkyang/rust-blas/pull/4.diff","patch_url":"https://github.com/mikkyang/rust-blas/pull/4.patch","issue_url":"https://api.github.com/repos/mikkyang/rust-blas/issues/4","number":4,"state":"open","locked":false,"title":"configurable cblas library?","user":{"login":"joshterrell805","id":4649127,"avatar_url":"https://avatars.githubusercontent.com/u/4649127?v=3","gravatar_id":"","url":"https://api.github.com/users/joshterrell805","html_url":"https://github.com/joshterrell805","followers_url":"https://api.github.com/users/joshterrell805/followers","following_url":"https://api.github.com/users/joshterrell805/following{/other_user}","gists_url":"https://api.github.com/users/joshterrell805/gists{/gist_id}","starred_url":"https://api.github.com/users/joshterrell805/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshterrell805/subscriptions","organizations_url":"https://api.github.com/users/joshterrell805/orgs","repos_url":"https://api.github.com/users/joshterrell805/repos","events_url":"https://api.github.com/users/joshterrell805/events{/privacy}","received_events_url":"https://api.github.com/users/joshterrell805/received_events","type":"User","site_admin":false},"body":"Hi, thanks for writing this wrapper @mikkyang! It seems very intuitive and lacks the extra cruft found in some other ports.\r\n\r\nAs it stands, I was unable to use this library. In my system \"libblas\" links to the (fortran?) blas library which has a different interface than the cblas library. Note that the [blas](http://www.netlib.org/blas/#_blas_routines) functions dont have the \"cblas_\" prefix. The linker couldn't find the functions I wanted to use.\r\n\r\nIn order to get your code working, I had to link against \"cblas\" instead. You'll notice I linked against [openblas](https://github.com/xianyi/OpenBLAS) instead of cblas in this pull request. There may be other implementations of blas that users of this port may want to use too. I don't suggest merging this pull, or making a new pull linking to \"cblas\" instead of \"openblas\". I think a better solution is to let the user decide which library (with the cblas interface) they want to link to. I'm thinking some sort of ENV variable used in the macros, and if the env-var is not defined, use \"cblas\" as default.\r\n\r\nThanks again for the port! I'm very new to rust, but if you want this change and you're not feeling up to making this change, I'd be willing to give it a shot. Also, I'm curious if your projects work if you link to \"cblas\" instead of \"blas\". I think \"cblas\" is the proper library to be linking to. ","created_at":"2015-06-09T15:40:31Z","updated_at":"2015-06-09T15:40:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mikkyang/rust-blas/pulls/4/commits","review_comments_url":"https://api.github.com/repos/mikkyang/rust-blas/pulls/4/comments","review_comment_url":"https://api.github.com/repos/mikkyang/rust-blas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mikkyang/rust-blas/issues/4/comments","statuses_url":"https://api.github.com/repos/mikkyang/rust-blas/statuses/86cf72f37a6886c9a6b9d81ec986fea47c59ea4c","head":{"label":"joshterrell805:master","ref":"master","sha":"86cf72f37a6886c9a6b9d81ec986fea47c59ea4c","user":{"login":"joshterrell805","id":4649127,"avatar_url":"https://avatars.githubusercontent.com/u/4649127?v=3","gravatar_id":"","url":"https://api.github.com/users/joshterrell805","html_url":"https://github.com/joshterrell805","followers_url":"https://api.github.com/users/joshterrell805/followers","following_url":"https://api.github.com/users/joshterrell805/following{/other_user}","gists_url":"https://api.github.com/users/joshterrell805/gists{/gist_id}","starred_url":"https://api.github.com/users/joshterrell805/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshterrell805/subscriptions","organizations_url":"https://api.github.com/users/joshterrell805/orgs","repos_url":"https://api.github.com/users/joshterrell805/repos","events_url":"https://api.github.com/users/joshterrell805/events{/privacy}","received_events_url":"https://api.github.com/users/joshterrell805/received_events","type":"User","site_admin":false},"repo":{"id":37140155,"name":"rust-blas","full_name":"joshterrell805/rust-blas","owner":{"login":"joshterrell805","id":4649127,"avatar_url":"https://avatars.githubusercontent.com/u/4649127?v=3","gravatar_id":"","url":"https://api.github.com/users/joshterrell805","html_url":"https://github.com/joshterrell805","followers_url":"https://api.github.com/users/joshterrell805/followers","following_url":"https://api.github.com/users/joshterrell805/following{/other_user}","gists_url":"https://api.github.com/users/joshterrell805/gists{/gist_id}","starred_url":"https://api.github.com/users/joshterrell805/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshterrell805/subscriptions","organizations_url":"https://api.github.com/users/joshterrell805/orgs","repos_url":"https://api.github.com/users/joshterrell805/repos","events_url":"https://api.github.com/users/joshterrell805/events{/privacy}","received_events_url":"https://api.github.com/users/joshterrell805/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joshterrell805/rust-blas","description":"BLAS bindings for Rust","fork":true,"url":"https://api.github.com/repos/joshterrell805/rust-blas","forks_url":"https://api.github.com/repos/joshterrell805/rust-blas/forks","keys_url":"https://api.github.com/repos/joshterrell805/rust-blas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joshterrell805/rust-blas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joshterrell805/rust-blas/teams","hooks_url":"https://api.github.com/repos/joshterrell805/rust-blas/hooks","issue_events_url":"https://api.github.com/repos/joshterrell805/rust-blas/issues/events{/number}","events_url":"https://api.github.com/repos/joshterrell805/rust-blas/events","assignees_url":"https://api.github.com/repos/joshterrell805/rust-blas/assignees{/user}","branches_url":"https://api.github.com/repos/joshterrell805/rust-blas/branches{/branch}","tags_url":"https://api.github.com/repos/joshterrell805/rust-blas/tags","blobs_url":"https://api.github.com/repos/joshterrell805/rust-blas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joshterrell805/rust-blas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joshterrell805/rust-blas/git/refs{/sha}","trees_url":"https://api.github.com/repos/joshterrell805/rust-blas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joshterrell805/rust-blas/statuses/{sha}","languages_url":"https://api.github.com/repos/joshterrell805/rust-blas/languages","stargazers_url":"https://api.github.com/repos/joshterrell805/rust-blas/stargazers","contributors_url":"https://api.github.com/repos/joshterrell805/rust-blas/contributors","subscribers_url":"https://api.github.com/repos/joshterrell805/rust-blas/subscribers","subscription_url":"https://api.github.com/repos/joshterrell805/rust-blas/subscription","commits_url":"https://api.github.com/repos/joshterrell805/rust-blas/commits{/sha}","git_commits_url":"https://api.github.com/repos/joshterrell805/rust-blas/git/commits{/sha}","comments_url":"https://api.github.com/repos/joshterrell805/rust-blas/comments{/number}","issue_comment_url":"https://api.github.com/repos/joshterrell805/rust-blas/issues/comments{/number}","contents_url":"https://api.github.com/repos/joshterrell805/rust-blas/contents/{+path}","compare_url":"https://api.github.com/repos/joshterrell805/rust-blas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joshterrell805/rust-blas/merges","archive_url":"https://api.github.com/repos/joshterrell805/rust-blas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joshterrell805/rust-blas/downloads","issues_url":"https://api.github.com/repos/joshterrell805/rust-blas/issues{/number}","pulls_url":"https://api.github.com/repos/joshterrell805/rust-blas/pulls{/number}","milestones_url":"https://api.github.com/repos/joshterrell805/rust-blas/milestones{/number}","notifications_url":"https://api.github.com/repos/joshterrell805/rust-blas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joshterrell805/rust-blas/labels{/name}","releases_url":"https://api.github.com/repos/joshterrell805/rust-blas/releases{/id}","created_at":"2015-06-09T15:19:42Z","updated_at":"2015-06-09T15:19:42Z","pushed_at":"2015-06-09T15:24:11Z","git_url":"git://github.com/joshterrell805/rust-blas.git","ssh_url":"git@github.com:joshterrell805/rust-blas.git","clone_url":"https://github.com/joshterrell805/rust-blas.git","svn_url":"https://github.com/joshterrell805/rust-blas","homepage":null,"size":1352,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mikkyang:master","ref":"master","sha":"ce9254d29c8be2100cfe7894db8aef526b63be6d","user":{"login":"mikkyang","id":1226761,"avatar_url":"https://avatars.githubusercontent.com/u/1226761?v=3","gravatar_id":"","url":"https://api.github.com/users/mikkyang","html_url":"https://github.com/mikkyang","followers_url":"https://api.github.com/users/mikkyang/followers","following_url":"https://api.github.com/users/mikkyang/following{/other_user}","gists_url":"https://api.github.com/users/mikkyang/gists{/gist_id}","starred_url":"https://api.github.com/users/mikkyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikkyang/subscriptions","organizations_url":"https://api.github.com/users/mikkyang/orgs","repos_url":"https://api.github.com/users/mikkyang/repos","events_url":"https://api.github.com/users/mikkyang/events{/privacy}","received_events_url":"https://api.github.com/users/mikkyang/received_events","type":"User","site_admin":false},"repo":{"id":22791483,"name":"rust-blas","full_name":"mikkyang/rust-blas","owner":{"login":"mikkyang","id":1226761,"avatar_url":"https://avatars.githubusercontent.com/u/1226761?v=3","gravatar_id":"","url":"https://api.github.com/users/mikkyang","html_url":"https://github.com/mikkyang","followers_url":"https://api.github.com/users/mikkyang/followers","following_url":"https://api.github.com/users/mikkyang/following{/other_user}","gists_url":"https://api.github.com/users/mikkyang/gists{/gist_id}","starred_url":"https://api.github.com/users/mikkyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikkyang/subscriptions","organizations_url":"https://api.github.com/users/mikkyang/orgs","repos_url":"https://api.github.com/users/mikkyang/repos","events_url":"https://api.github.com/users/mikkyang/events{/privacy}","received_events_url":"https://api.github.com/users/mikkyang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikkyang/rust-blas","description":"BLAS bindings for Rust","fork":false,"url":"https://api.github.com/repos/mikkyang/rust-blas","forks_url":"https://api.github.com/repos/mikkyang/rust-blas/forks","keys_url":"https://api.github.com/repos/mikkyang/rust-blas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikkyang/rust-blas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikkyang/rust-blas/teams","hooks_url":"https://api.github.com/repos/mikkyang/rust-blas/hooks","issue_events_url":"https://api.github.com/repos/mikkyang/rust-blas/issues/events{/number}","events_url":"https://api.github.com/repos/mikkyang/rust-blas/events","assignees_url":"https://api.github.com/repos/mikkyang/rust-blas/assignees{/user}","branches_url":"https://api.github.com/repos/mikkyang/rust-blas/branches{/branch}","tags_url":"https://api.github.com/repos/mikkyang/rust-blas/tags","blobs_url":"https://api.github.com/repos/mikkyang/rust-blas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikkyang/rust-blas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikkyang/rust-blas/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikkyang/rust-blas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikkyang/rust-blas/statuses/{sha}","languages_url":"https://api.github.com/repos/mikkyang/rust-blas/languages","stargazers_url":"https://api.github.com/repos/mikkyang/rust-blas/stargazers","contributors_url":"https://api.github.com/repos/mikkyang/rust-blas/contributors","subscribers_url":"https://api.github.com/repos/mikkyang/rust-blas/subscribers","subscription_url":"https://api.github.com/repos/mikkyang/rust-blas/subscription","commits_url":"https://api.github.com/repos/mikkyang/rust-blas/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikkyang/rust-blas/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikkyang/rust-blas/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikkyang/rust-blas/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikkyang/rust-blas/contents/{+path}","compare_url":"https://api.github.com/repos/mikkyang/rust-blas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikkyang/rust-blas/merges","archive_url":"https://api.github.com/repos/mikkyang/rust-blas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikkyang/rust-blas/downloads","issues_url":"https://api.github.com/repos/mikkyang/rust-blas/issues{/number}","pulls_url":"https://api.github.com/repos/mikkyang/rust-blas/pulls{/number}","milestones_url":"https://api.github.com/repos/mikkyang/rust-blas/milestones{/number}","notifications_url":"https://api.github.com/repos/mikkyang/rust-blas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikkyang/rust-blas/labels{/name}","releases_url":"https://api.github.com/repos/mikkyang/rust-blas/releases{/id}","created_at":"2014-08-09T17:34:59Z","updated_at":"2015-06-08T22:26:26Z","pushed_at":"2015-05-11T19:15:23Z","git_url":"git://github.com/mikkyang/rust-blas.git","ssh_url":"git@github.com:mikkyang/rust-blas.git","clone_url":"https://github.com/mikkyang/rust-blas.git","svn_url":"https://github.com/mikkyang/rust-blas","homepage":null,"size":1804,"stargazers_count":16,"watchers_count":16,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mikkyang/rust-blas/pulls/4"},"html":{"href":"https://github.com/mikkyang/rust-blas/pull/4"},"issue":{"href":"https://api.github.com/repos/mikkyang/rust-blas/issues/4"},"comments":{"href":"https://api.github.com/repos/mikkyang/rust-blas/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/mikkyang/rust-blas/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/mikkyang/rust-blas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mikkyang/rust-blas/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/mikkyang/rust-blas/statuses/86cf72f37a6886c9a6b9d81ec986fea47c59ea4c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":3,"deletions":3,"changed_files":3}}