{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/47858029","id":47858029,"diff_hunk":"@@ -306,25 +306,30 @@ private List<DocumentSnapshotSpan> GetSpansAndDocumentsToTag()\n                 var snapshotToDocumentMap = new Dictionary<ITextSnapshot, Document>();\n                 var spansToTag = _dataSource.GetSpansToTag(_textViewOpt, _subjectBuffer);\n \n-                var spansAndDocumentsToTag = spansToTag.Select(span =>\n-                {\n-                    Document document = null;\n-                    if (!snapshotToDocumentMap.TryGetValue(span.Snapshot, out document))\n-                    {\n-                        CheckSnapshot(span.Snapshot);\n-\n-                        document = span.Snapshot.GetOpenDocumentInCurrentContextWithChanges();\n-                        snapshotToDocumentMap[span.Snapshot] = document;\n-                    }\n-\n-                    // document can be null if the buffer the given span is part of is not part of our workspace.\n-                    return new DocumentSnapshotSpan(document, span);\n-                }).ToList();\n+                var spansAndDocumentsToTag = spansToTag\n+                    .Select(span => CreateDocumentSnapshotSpan(span, snapshotToDocumentMap))\n+                    .Where(s => s.Document != null)\n+                    .ToList();\n \n                 Debug.Assert(spansAndDocumentsToTag.Count > 0);\n                 return spansAndDocumentsToTag;\n             }\n \n+            private DocumentSnapshotSpan CreateDocumentSnapshotSpan(SnapshotSpan span, Dictionary<ITextSnapshot, Document> snapshotToDocumentMap)\n+            {\n+                Document document = null;\n+                if (!snapshotToDocumentMap.TryGetValue(span.Snapshot, out document))\n+                {\n+                    CheckSnapshot(span.Snapshot);\n+\n+                    document = span.Snapshot.GetOpenDocumentInCurrentContextWithChanges();\n+                    snapshotToDocumentMap[span.Snapshot] = document;\n+                }\n+\n+                // document can be null if the buffer the given span is part of is not part of our workspace.","path":"src/EditorFeatures/Core/Tagging/AbstractAsynchronousTaggerProvider.TagSource_ProduceTags.cs","position":38,"original_position":38,"commit_id":"bca0ceed3ac1739dccc8416b738b0130cb42bf54","original_commit_id":"bca0ceed3ac1739dccc8416b738b0130cb42bf54","user":{"login":"CyrusNajmabadi","id":4564579,"avatar_url":"https://avatars.githubusercontent.com/u/4564579?v=3","gravatar_id":"","url":"https://api.github.com/users/CyrusNajmabadi","html_url":"https://github.com/CyrusNajmabadi","followers_url":"https://api.github.com/users/CyrusNajmabadi/followers","following_url":"https://api.github.com/users/CyrusNajmabadi/following{/other_user}","gists_url":"https://api.github.com/users/CyrusNajmabadi/gists{/gist_id}","starred_url":"https://api.github.com/users/CyrusNajmabadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyrusNajmabadi/subscriptions","organizations_url":"https://api.github.com/users/CyrusNajmabadi/orgs","repos_url":"https://api.github.com/users/CyrusNajmabadi/repos","events_url":"https://api.github.com/users/CyrusNajmabadi/events{/privacy}","received_events_url":"https://api.github.com/users/CyrusNajmabadi/received_events","type":"User","site_admin":false},"body":"Update comment to mention that we will filter this out in the above query.","created_at":"2015-12-17T01:09:13Z","updated_at":"2015-12-17T01:09:13Z","html_url":"https://github.com/dotnet/roslyn/pull/7539#discussion_r47858029","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/7539","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/47858029"},"html":{"href":"https://github.com/dotnet/roslyn/pull/7539#discussion_r47858029"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/7539"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/7539","id":53901961,"html_url":"https://github.com/dotnet/roslyn/pull/7539","diff_url":"https://github.com/dotnet/roslyn/pull/7539.diff","patch_url":"https://github.com/dotnet/roslyn/pull/7539.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/7539","number":7539,"state":"open","locked":false,"title":"Fix NullRef in SemanticClassificationViewTaggerProvider","user":{"login":"dpoeschl","id":235241,"avatar_url":"https://avatars.githubusercontent.com/u/235241?v=3","gravatar_id":"","url":"https://api.github.com/users/dpoeschl","html_url":"https://github.com/dpoeschl","followers_url":"https://api.github.com/users/dpoeschl/followers","following_url":"https://api.github.com/users/dpoeschl/following{/other_user}","gists_url":"https://api.github.com/users/dpoeschl/gists{/gist_id}","starred_url":"https://api.github.com/users/dpoeschl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpoeschl/subscriptions","organizations_url":"https://api.github.com/users/dpoeschl/orgs","repos_url":"https://api.github.com/users/dpoeschl/repos","events_url":"https://api.github.com/users/dpoeschl/events{/privacy}","received_events_url":"https://api.github.com/users/dpoeschl/received_events","type":"User","site_admin":false},"body":"@balajikris @jasonmalinowski @rchande @KevinH-MS \r\n@dotnet/roslyn-ide ","created_at":"2015-12-16T21:36:03Z","updated_at":"2015-12-17T01:09:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"233c17f18df5e10a751e87095bf972636bf726fe","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/7539/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/7539/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/7539/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/bca0ceed3ac1739dccc8416b738b0130cb42bf54","head":{"label":"dpoeschl:SemanticClassificationNullRef","ref":"SemanticClassificationNullRef","sha":"bca0ceed3ac1739dccc8416b738b0130cb42bf54","user":{"login":"dpoeschl","id":235241,"avatar_url":"https://avatars.githubusercontent.com/u/235241?v=3","gravatar_id":"","url":"https://api.github.com/users/dpoeschl","html_url":"https://github.com/dpoeschl","followers_url":"https://api.github.com/users/dpoeschl/followers","following_url":"https://api.github.com/users/dpoeschl/following{/other_user}","gists_url":"https://api.github.com/users/dpoeschl/gists{/gist_id}","starred_url":"https://api.github.com/users/dpoeschl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpoeschl/subscriptions","organizations_url":"https://api.github.com/users/dpoeschl/orgs","repos_url":"https://api.github.com/users/dpoeschl/repos","events_url":"https://api.github.com/users/dpoeschl/events{/privacy}","received_events_url":"https://api.github.com/users/dpoeschl/received_events","type":"User","site_admin":false},"repo":{"id":30046829,"name":"roslyn","full_name":"dpoeschl/roslyn","owner":{"login":"dpoeschl","id":235241,"avatar_url":"https://avatars.githubusercontent.com/u/235241?v=3","gravatar_id":"","url":"https://api.github.com/users/dpoeschl","html_url":"https://github.com/dpoeschl","followers_url":"https://api.github.com/users/dpoeschl/followers","following_url":"https://api.github.com/users/dpoeschl/following{/other_user}","gists_url":"https://api.github.com/users/dpoeschl/gists{/gist_id}","starred_url":"https://api.github.com/users/dpoeschl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpoeschl/subscriptions","organizations_url":"https://api.github.com/users/dpoeschl/orgs","repos_url":"https://api.github.com/users/dpoeschl/repos","events_url":"https://api.github.com/users/dpoeschl/events{/privacy}","received_events_url":"https://api.github.com/users/dpoeschl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dpoeschl/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/dpoeschl/roslyn","forks_url":"https://api.github.com/repos/dpoeschl/roslyn/forks","keys_url":"https://api.github.com/repos/dpoeschl/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dpoeschl/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dpoeschl/roslyn/teams","hooks_url":"https://api.github.com/repos/dpoeschl/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dpoeschl/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dpoeschl/roslyn/events","assignees_url":"https://api.github.com/repos/dpoeschl/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dpoeschl/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dpoeschl/roslyn/tags","blobs_url":"https://api.github.com/repos/dpoeschl/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dpoeschl/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dpoeschl/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dpoeschl/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dpoeschl/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dpoeschl/roslyn/languages","stargazers_url":"https://api.github.com/repos/dpoeschl/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dpoeschl/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dpoeschl/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dpoeschl/roslyn/subscription","commits_url":"https://api.github.com/repos/dpoeschl/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dpoeschl/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dpoeschl/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dpoeschl/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dpoeschl/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dpoeschl/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dpoeschl/roslyn/merges","archive_url":"https://api.github.com/repos/dpoeschl/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dpoeschl/roslyn/downloads","issues_url":"https://api.github.com/repos/dpoeschl/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dpoeschl/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dpoeschl/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dpoeschl/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dpoeschl/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dpoeschl/roslyn/releases{/id}","created_at":"2015-01-29T23:37:29Z","updated_at":"2015-03-18T18:28:52Z","pushed_at":"2015-12-17T00:25:51Z","git_url":"git://github.com/dpoeschl/roslyn.git","ssh_url":"git@github.com:dpoeschl/roslyn.git","clone_url":"https://github.com/dpoeschl/roslyn.git","svn_url":"https://github.com/dpoeschl/roslyn","homepage":"","size":117488,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"860f5c5f57b7f68cb05ce469c7cbfa39a27998b2","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","created_at":"2015-01-11T02:39:03Z","updated_at":"2015-12-16T22:42:12Z","pushed_at":"2015-12-17T01:07:26Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":146342,"stargazers_count":4025,"watchers_count":4025,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":986,"mirror_url":null,"open_issues_count":1802,"forks":986,"open_issues":1802,"watchers":4025,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/7539"},"html":{"href":"https://github.com/dotnet/roslyn/pull/7539"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/7539"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/7539/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/7539/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/7539/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/bca0ceed3ac1739dccc8416b738b0130cb42bf54"}}}}