{"action":"created","issue":{"url":"https://api.github.com/repos/OHDSI/Cyclops/issues/17","labels_url":"https://api.github.com/repos/OHDSI/Cyclops/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/OHDSI/Cyclops/issues/17/comments","events_url":"https://api.github.com/repos/OHDSI/Cyclops/issues/17/events","html_url":"https://github.com/OHDSI/Cyclops/pull/17","id":76546063,"number":17,"title":"Cross val weightsv2","user":{"login":"ApproximateIdentity","id":2095718,"avatar_url":"https://avatars.githubusercontent.com/u/2095718?v=3","gravatar_id":"","url":"https://api.github.com/users/ApproximateIdentity","html_url":"https://github.com/ApproximateIdentity","followers_url":"https://api.github.com/users/ApproximateIdentity/followers","following_url":"https://api.github.com/users/ApproximateIdentity/following{/other_user}","gists_url":"https://api.github.com/users/ApproximateIdentity/gists{/gist_id}","starred_url":"https://api.github.com/users/ApproximateIdentity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ApproximateIdentity/subscriptions","organizations_url":"https://api.github.com/users/ApproximateIdentity/orgs","repos_url":"https://api.github.com/users/ApproximateIdentity/repos","events_url":"https://api.github.com/users/ApproximateIdentity/events{/privacy}","received_events_url":"https://api.github.com/users/ApproximateIdentity/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-05-15T01:14:06Z","updated_at":"2015-05-31T16:19:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OHDSI/Cyclops/pulls/17","html_url":"https://github.com/OHDSI/Cyclops/pull/17","diff_url":"https://github.com/OHDSI/Cyclops/pull/17.diff","patch_url":"https://github.com/OHDSI/Cyclops/pull/17.patch"},"body":"This branch changes Cyclops so that cross-validation can be used with weights. I have spent a lot of time working on this code and am finally feeling reasonably familiar with the codebase, but I would highly appreciate another pair of critical eyes on the changes I've made. Thanks a lot."},"comment":{"url":"https://api.github.com/repos/OHDSI/Cyclops/issues/comments/107215770","html_url":"https://github.com/OHDSI/Cyclops/pull/17#issuecomment-107215770","issue_url":"https://api.github.com/repos/OHDSI/Cyclops/issues/17","id":107215770,"user":{"login":"ApproximateIdentity","id":2095718,"avatar_url":"https://avatars.githubusercontent.com/u/2095718?v=3","gravatar_id":"","url":"https://api.github.com/users/ApproximateIdentity","html_url":"https://github.com/ApproximateIdentity","followers_url":"https://api.github.com/users/ApproximateIdentity/followers","following_url":"https://api.github.com/users/ApproximateIdentity/following{/other_user}","gists_url":"https://api.github.com/users/ApproximateIdentity/gists{/gist_id}","starred_url":"https://api.github.com/users/ApproximateIdentity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ApproximateIdentity/subscriptions","organizations_url":"https://api.github.com/users/ApproximateIdentity/orgs","repos_url":"https://api.github.com/users/ApproximateIdentity/repos","events_url":"https://api.github.com/users/ApproximateIdentity/events{/privacy}","received_events_url":"https://api.github.com/users/ApproximateIdentity/received_events","type":"User","site_admin":false},"created_at":"2015-05-31T16:19:31Z","updated_at":"2015-05-31T16:19:31Z","body":"Hi Marc thanks for the response. I just wanted to make sure I'm 100% clear on this exactly. Say I'm in the following situation. Both X and y are given by the following single column matrix.\r\n\r\n```\r\n1\r\n0\r\n1\r\n0\r\n```\r\n\r\nLet's say the weights I choose are the following:\r\n\r\n```\r\n1\r\n1\r\n0\r\n0\r\n```\r\n\r\nIf I fit with these weights would it be equivalent to changing the y vector to the following?\r\n\r\n```\r\n1\r\n0\r\n0\r\n0\r\n```\r\n\r\nThe reason I'm wondering is because it seems like I _cannot_ use weights to mimic a train/test split if it's like this. Fitting with weights will not get the same thing as fitting by dropping the rows entirely. This is of course orthogonal to the code in question (and hence this pull request), but it is the reason I wrote this code in the first place so I should know if I can't use this the way I wanted.\r\n\r\nAm I misunderstanding things?"}}