{"action":"created","issue":{"url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/3529","labels_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/3529/labels{/name}","comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/3529/comments","events_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/3529/events","html_url":"https://github.com/D-Programming-Language/phobos/pull/3529","id":99523305,"number":3529,"title":"mmfile.d: MmFile destructor changed not to cal enforce","user":{"login":"sdegtiarev","id":5247173,"avatar_url":"https://avatars.githubusercontent.com/u/5247173?v=3","gravatar_id":"","url":"https://api.github.com/users/sdegtiarev","html_url":"https://github.com/sdegtiarev","followers_url":"https://api.github.com/users/sdegtiarev/followers","following_url":"https://api.github.com/users/sdegtiarev/following{/other_user}","gists_url":"https://api.github.com/users/sdegtiarev/gists{/gist_id}","starred_url":"https://api.github.com/users/sdegtiarev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdegtiarev/subscriptions","organizations_url":"https://api.github.com/users/sdegtiarev/orgs","repos_url":"https://api.github.com/users/sdegtiarev/repos","events_url":"https://api.github.com/users/sdegtiarev/events{/privacy}","received_events_url":"https://api.github.com/users/sdegtiarev/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":26,"created_at":"2015-08-06T20:57:45Z","updated_at":"2015-09-03T13:15:37Z","closed_at":"2015-08-11T21:05:51Z","pull_request":{"url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/3529","html_url":"https://github.com/D-Programming-Language/phobos/pull/3529","diff_url":"https://github.com/D-Programming-Language/phobos/pull/3529.diff","patch_url":"https://github.com/D-Programming-Language/phobos/pull/3529.patch"},"body":"Issue 14868:\r\nMmFile(File,Mode,..) constructor caused the underlying file descriptor to be closed twice, in ~File() and ~MmFile(). Since MmFile destructor called enforce to check return status of close() system call, exception was thrown from inside GC.\r\nThe .close() call is safe and the only meaningful error is EBADF, when the descriptor is closed already, so I commented out the enforce part.\r\n"},"comment":{"url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/comments/137439643","html_url":"https://github.com/D-Programming-Language/phobos/pull/3529#issuecomment-137439643","issue_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/3529","id":137439643,"user":{"login":"CyberShadow","id":160894,"avatar_url":"https://avatars.githubusercontent.com/u/160894?v=3","gravatar_id":"","url":"https://api.github.com/users/CyberShadow","html_url":"https://github.com/CyberShadow","followers_url":"https://api.github.com/users/CyberShadow/followers","following_url":"https://api.github.com/users/CyberShadow/following{/other_user}","gists_url":"https://api.github.com/users/CyberShadow/gists{/gist_id}","starred_url":"https://api.github.com/users/CyberShadow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyberShadow/subscriptions","organizations_url":"https://api.github.com/users/CyberShadow/orgs","repos_url":"https://api.github.com/users/CyberShadow/repos","events_url":"https://api.github.com/users/CyberShadow/events{/privacy}","received_events_url":"https://api.github.com/users/CyberShadow/received_events","type":"User","site_admin":false},"created_at":"2015-09-03T13:15:37Z","updated_at":"2015-09-03T13:15:37Z","body":"Can you please tell me what *concrete* problems do you see with https://github.com/D-Programming-Language/phobos/pull/3619 applied? Preferably unittest code that fails (with https://github.com/D-Programming-Language/phobos/pull/3619 applied)."}}