{"action":"closed","number":35,"pull_request":{"url":"https://api.github.com/repos/Civcraft/FactoryMod/pulls/35","id":27993749,"html_url":"https://github.com/Civcraft/FactoryMod/pull/35","diff_url":"https://github.com/Civcraft/FactoryMod/pull/35.diff","patch_url":"https://github.com/Civcraft/FactoryMod/pull/35.patch","issue_url":"https://api.github.com/repos/Civcraft/FactoryMod/issues/35","number":35,"state":"closed","locked":false,"title":"Fixed the check for citadel access","user":{"login":"spaceFountain","id":5590191,"avatar_url":"https://avatars.githubusercontent.com/u/5590191?v=3","gravatar_id":"","url":"https://api.github.com/users/spaceFountain","html_url":"https://github.com/spaceFountain","followers_url":"https://api.github.com/users/spaceFountain/followers","following_url":"https://api.github.com/users/spaceFountain/following{/other_user}","gists_url":"https://api.github.com/users/spaceFountain/gists{/gist_id}","starred_url":"https://api.github.com/users/spaceFountain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spaceFountain/subscriptions","organizations_url":"https://api.github.com/users/spaceFountain/orgs","repos_url":"https://api.github.com/users/spaceFountain/repos","events_url":"https://api.github.com/users/spaceFountain/events{/privacy}","received_events_url":"https://api.github.com/users/spaceFountain/received_events","type":"User","site_admin":false},"body":"Originally the conditions for teleporting where as follows: \r\n    !citadel_enabled or (citadel_enabled and reinforcement != null) or reinforcement.isAccessible\r\nthis is the same as\r\n    (!citadel_enabled or citadel_enabled) and (!citadel_enabled or reinforcement!=null) or reinforcement.isAccessible\r\n(!citadel_enabled or citadel_enabled) is obviously true so this becomes\r\n   !citadel_enabled or reinforcement != null or reinforcement.isAccessible\r\n\r\nthe problem should be obvious here. If reinforcement is ever not null this will go forward regardless of the ability of the player to access the factory.\r\n\r\nWhat I believe was intended was to check if the reinforcement was null and if so just to allow anyone through. To this end I've changed the condition to:\r\n   !citadel_enabled or reinforcement == null or reinforcement.isAccessible\r\n\r\nI'm not sure why we were getting some reports of it working properly. Possibly people were just misinformed. This should be a very straight forward change, but I'll try to look into seeing if it works after I've finished with my school work which may take a while \r\n\r\n","created_at":"2015-01-25T16:01:24Z","updated_at":"2015-01-25T18:32:07Z","closed_at":"2015-01-25T18:32:07Z","merged_at":"2015-01-25T18:32:07Z","merge_commit_sha":"5bc3d39496dd724212224f9763f7b6301f97c7a7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Civcraft/FactoryMod/pulls/35/commits","review_comments_url":"https://api.github.com/repos/Civcraft/FactoryMod/pulls/35/comments","review_comment_url":"https://api.github.com/repos/Civcraft/FactoryMod/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Civcraft/FactoryMod/issues/35/comments","statuses_url":"https://api.github.com/repos/Civcraft/FactoryMod/statuses/5ac3b0e86c88d99beb25fabccd535d44dc4fbfb8","head":{"label":"spaceFountain:master","ref":"master","sha":"5ac3b0e86c88d99beb25fabccd535d44dc4fbfb8","user":{"login":"spaceFountain","id":5590191,"avatar_url":"https://avatars.githubusercontent.com/u/5590191?v=3","gravatar_id":"","url":"https://api.github.com/users/spaceFountain","html_url":"https://github.com/spaceFountain","followers_url":"https://api.github.com/users/spaceFountain/followers","following_url":"https://api.github.com/users/spaceFountain/following{/other_user}","gists_url":"https://api.github.com/users/spaceFountain/gists{/gist_id}","starred_url":"https://api.github.com/users/spaceFountain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spaceFountain/subscriptions","organizations_url":"https://api.github.com/users/spaceFountain/orgs","repos_url":"https://api.github.com/users/spaceFountain/repos","events_url":"https://api.github.com/users/spaceFountain/events{/privacy}","received_events_url":"https://api.github.com/users/spaceFountain/received_events","type":"User","site_admin":false},"repo":{"id":29501177,"name":"FactoryMod","full_name":"spaceFountain/FactoryMod","owner":{"login":"spaceFountain","id":5590191,"avatar_url":"https://avatars.githubusercontent.com/u/5590191?v=3","gravatar_id":"","url":"https://api.github.com/users/spaceFountain","html_url":"https://github.com/spaceFountain","followers_url":"https://api.github.com/users/spaceFountain/followers","following_url":"https://api.github.com/users/spaceFountain/following{/other_user}","gists_url":"https://api.github.com/users/spaceFountain/gists{/gist_id}","starred_url":"https://api.github.com/users/spaceFountain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spaceFountain/subscriptions","organizations_url":"https://api.github.com/users/spaceFountain/orgs","repos_url":"https://api.github.com/users/spaceFountain/repos","events_url":"https://api.github.com/users/spaceFountain/events{/privacy}","received_events_url":"https://api.github.com/users/spaceFountain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spaceFountain/FactoryMod","description":"","fork":true,"url":"https://api.github.com/repos/spaceFountain/FactoryMod","forks_url":"https://api.github.com/repos/spaceFountain/FactoryMod/forks","keys_url":"https://api.github.com/repos/spaceFountain/FactoryMod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spaceFountain/FactoryMod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spaceFountain/FactoryMod/teams","hooks_url":"https://api.github.com/repos/spaceFountain/FactoryMod/hooks","issue_events_url":"https://api.github.com/repos/spaceFountain/FactoryMod/issues/events{/number}","events_url":"https://api.github.com/repos/spaceFountain/FactoryMod/events","assignees_url":"https://api.github.com/repos/spaceFountain/FactoryMod/assignees{/user}","branches_url":"https://api.github.com/repos/spaceFountain/FactoryMod/branches{/branch}","tags_url":"https://api.github.com/repos/spaceFountain/FactoryMod/tags","blobs_url":"https://api.github.com/repos/spaceFountain/FactoryMod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spaceFountain/FactoryMod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spaceFountain/FactoryMod/git/refs{/sha}","trees_url":"https://api.github.com/repos/spaceFountain/FactoryMod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spaceFountain/FactoryMod/statuses/{sha}","languages_url":"https://api.github.com/repos/spaceFountain/FactoryMod/languages","stargazers_url":"https://api.github.com/repos/spaceFountain/FactoryMod/stargazers","contributors_url":"https://api.github.com/repos/spaceFountain/FactoryMod/contributors","subscribers_url":"https://api.github.com/repos/spaceFountain/FactoryMod/subscribers","subscription_url":"https://api.github.com/repos/spaceFountain/FactoryMod/subscription","commits_url":"https://api.github.com/repos/spaceFountain/FactoryMod/commits{/sha}","git_commits_url":"https://api.github.com/repos/spaceFountain/FactoryMod/git/commits{/sha}","comments_url":"https://api.github.com/repos/spaceFountain/FactoryMod/comments{/number}","issue_comment_url":"https://api.github.com/repos/spaceFountain/FactoryMod/issues/comments/{number}","contents_url":"https://api.github.com/repos/spaceFountain/FactoryMod/contents/{+path}","compare_url":"https://api.github.com/repos/spaceFountain/FactoryMod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spaceFountain/FactoryMod/merges","archive_url":"https://api.github.com/repos/spaceFountain/FactoryMod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spaceFountain/FactoryMod/downloads","issues_url":"https://api.github.com/repos/spaceFountain/FactoryMod/issues{/number}","pulls_url":"https://api.github.com/repos/spaceFountain/FactoryMod/pulls{/number}","milestones_url":"https://api.github.com/repos/spaceFountain/FactoryMod/milestones{/number}","notifications_url":"https://api.github.com/repos/spaceFountain/FactoryMod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spaceFountain/FactoryMod/labels{/name}","releases_url":"https://api.github.com/repos/spaceFountain/FactoryMod/releases{/id}","created_at":"2015-01-19T23:03:27Z","updated_at":"2015-01-25T16:07:50Z","pushed_at":"2015-01-25T16:07:49Z","git_url":"git://github.com/spaceFountain/FactoryMod.git","ssh_url":"git@github.com:spaceFountain/FactoryMod.git","clone_url":"https://github.com/spaceFountain/FactoryMod.git","svn_url":"https://github.com/spaceFountain/FactoryMod","homepage":null,"size":3335,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Civcraft:master","ref":"master","sha":"081cf2fb9fd5ec29be8341676a1daea99a8d021d","user":{"login":"Civcraft","id":3921874,"avatar_url":"https://avatars.githubusercontent.com/u/3921874?v=3","gravatar_id":"","url":"https://api.github.com/users/Civcraft","html_url":"https://github.com/Civcraft","followers_url":"https://api.github.com/users/Civcraft/followers","following_url":"https://api.github.com/users/Civcraft/following{/other_user}","gists_url":"https://api.github.com/users/Civcraft/gists{/gist_id}","starred_url":"https://api.github.com/users/Civcraft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Civcraft/subscriptions","organizations_url":"https://api.github.com/users/Civcraft/orgs","repos_url":"https://api.github.com/users/Civcraft/repos","events_url":"https://api.github.com/users/Civcraft/events{/privacy}","received_events_url":"https://api.github.com/users/Civcraft/received_events","type":"Organization","site_admin":false},"repo":{"id":23559992,"name":"FactoryMod","full_name":"Civcraft/FactoryMod","owner":{"login":"Civcraft","id":3921874,"avatar_url":"https://avatars.githubusercontent.com/u/3921874?v=3","gravatar_id":"","url":"https://api.github.com/users/Civcraft","html_url":"https://github.com/Civcraft","followers_url":"https://api.github.com/users/Civcraft/followers","following_url":"https://api.github.com/users/Civcraft/following{/other_user}","gists_url":"https://api.github.com/users/Civcraft/gists{/gist_id}","starred_url":"https://api.github.com/users/Civcraft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Civcraft/subscriptions","organizations_url":"https://api.github.com/users/Civcraft/orgs","repos_url":"https://api.github.com/users/Civcraft/repos","events_url":"https://api.github.com/users/Civcraft/events{/privacy}","received_events_url":"https://api.github.com/users/Civcraft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Civcraft/FactoryMod","description":"","fork":true,"url":"https://api.github.com/repos/Civcraft/FactoryMod","forks_url":"https://api.github.com/repos/Civcraft/FactoryMod/forks","keys_url":"https://api.github.com/repos/Civcraft/FactoryMod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Civcraft/FactoryMod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Civcraft/FactoryMod/teams","hooks_url":"https://api.github.com/repos/Civcraft/FactoryMod/hooks","issue_events_url":"https://api.github.com/repos/Civcraft/FactoryMod/issues/events{/number}","events_url":"https://api.github.com/repos/Civcraft/FactoryMod/events","assignees_url":"https://api.github.com/repos/Civcraft/FactoryMod/assignees{/user}","branches_url":"https://api.github.com/repos/Civcraft/FactoryMod/branches{/branch}","tags_url":"https://api.github.com/repos/Civcraft/FactoryMod/tags","blobs_url":"https://api.github.com/repos/Civcraft/FactoryMod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Civcraft/FactoryMod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Civcraft/FactoryMod/git/refs{/sha}","trees_url":"https://api.github.com/repos/Civcraft/FactoryMod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Civcraft/FactoryMod/statuses/{sha}","languages_url":"https://api.github.com/repos/Civcraft/FactoryMod/languages","stargazers_url":"https://api.github.com/repos/Civcraft/FactoryMod/stargazers","contributors_url":"https://api.github.com/repos/Civcraft/FactoryMod/contributors","subscribers_url":"https://api.github.com/repos/Civcraft/FactoryMod/subscribers","subscription_url":"https://api.github.com/repos/Civcraft/FactoryMod/subscription","commits_url":"https://api.github.com/repos/Civcraft/FactoryMod/commits{/sha}","git_commits_url":"https://api.github.com/repos/Civcraft/FactoryMod/git/commits{/sha}","comments_url":"https://api.github.com/repos/Civcraft/FactoryMod/comments{/number}","issue_comment_url":"https://api.github.com/repos/Civcraft/FactoryMod/issues/comments/{number}","contents_url":"https://api.github.com/repos/Civcraft/FactoryMod/contents/{+path}","compare_url":"https://api.github.com/repos/Civcraft/FactoryMod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Civcraft/FactoryMod/merges","archive_url":"https://api.github.com/repos/Civcraft/FactoryMod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Civcraft/FactoryMod/downloads","issues_url":"https://api.github.com/repos/Civcraft/FactoryMod/issues{/number}","pulls_url":"https://api.github.com/repos/Civcraft/FactoryMod/pulls{/number}","milestones_url":"https://api.github.com/repos/Civcraft/FactoryMod/milestones{/number}","notifications_url":"https://api.github.com/repos/Civcraft/FactoryMod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Civcraft/FactoryMod/labels{/name}","releases_url":"https://api.github.com/repos/Civcraft/FactoryMod/releases{/id}","created_at":"2014-09-02T00:50:20Z","updated_at":"2015-01-15T14:25:27Z","pushed_at":"2015-01-25T18:32:07Z","git_url":"git://github.com/Civcraft/FactoryMod.git","ssh_url":"git@github.com:Civcraft/FactoryMod.git","clone_url":"https://github.com/Civcraft/FactoryMod.git","svn_url":"https://github.com/Civcraft/FactoryMod","homepage":null,"size":3335,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":9,"forks":5,"open_issues":9,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Civcraft/FactoryMod/pulls/35"},"html":{"href":"https://github.com/Civcraft/FactoryMod/pull/35"},"issue":{"href":"https://api.github.com/repos/Civcraft/FactoryMod/issues/35"},"comments":{"href":"https://api.github.com/repos/Civcraft/FactoryMod/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/Civcraft/FactoryMod/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/Civcraft/FactoryMod/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Civcraft/FactoryMod/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/Civcraft/FactoryMod/statuses/5ac3b0e86c88d99beb25fabccd535d44dc4fbfb8"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"rourke750","id":1648936,"avatar_url":"https://avatars.githubusercontent.com/u/1648936?v=3","gravatar_id":"","url":"https://api.github.com/users/rourke750","html_url":"https://github.com/rourke750","followers_url":"https://api.github.com/users/rourke750/followers","following_url":"https://api.github.com/users/rourke750/following{/other_user}","gists_url":"https://api.github.com/users/rourke750/gists{/gist_id}","starred_url":"https://api.github.com/users/rourke750/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rourke750/subscriptions","organizations_url":"https://api.github.com/users/rourke750/orgs","repos_url":"https://api.github.com/users/rourke750/repos","events_url":"https://api.github.com/users/rourke750/events{/privacy}","received_events_url":"https://api.github.com/users/rourke750/received_events","type":"User","site_admin":false},"comments":7,"review_comments":0,"commits":3,"additions":7,"deletions":8,"changed_files":3}}