{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/readability/issues/248","labels_url":"https://api.github.com/repos/mozilla/readability/issues/248/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/readability/issues/248/comments","events_url":"https://api.github.com/repos/mozilla/readability/issues/248/events","html_url":"https://github.com/mozilla/readability/pull/248","id":107821474,"number":248,"title":"Fix issue 247: detect brs in text to create readerable content","user":{"login":"gijsk","id":375983,"avatar_url":"https://avatars.githubusercontent.com/u/375983?v=3","gravatar_id":"","url":"https://api.github.com/users/gijsk","html_url":"https://github.com/gijsk","followers_url":"https://api.github.com/users/gijsk/followers","following_url":"https://api.github.com/users/gijsk/following{/other_user}","gists_url":"https://api.github.com/users/gijsk/gists{/gist_id}","starred_url":"https://api.github.com/users/gijsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gijsk/subscriptions","organizations_url":"https://api.github.com/users/gijsk/orgs","repos_url":"https://api.github.com/users/gijsk/repos","events_url":"https://api.github.com/users/gijsk/events{/privacy}","received_events_url":"https://api.github.com/users/gijsk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-09-22T23:15:06Z","updated_at":"2015-10-01T12:45:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/readability/pulls/248","html_url":"https://github.com/mozilla/readability/pull/248","diff_url":"https://github.com/mozilla/readability/pull/248.diff","patch_url":"https://github.com/mozilla/readability/pull/248.patch"},"body":"@leibovic How does this look for #247 ? I've not really done a serious performance test, and the messing with the array is a bit icky... but otherwise I think this should do? I picked 5 somewhat arbitrary (see the issue IRC log), but that seems like an OK start to me, and we can tweak if necessary..."},"comment":{"url":"https://api.github.com/repos/mozilla/readability/issues/comments/144716594","html_url":"https://github.com/mozilla/readability/pull/248#issuecomment-144716594","issue_url":"https://api.github.com/repos/mozilla/readability/issues/248","id":144716594,"user":{"login":"gijsk","id":375983,"avatar_url":"https://avatars.githubusercontent.com/u/375983?v=3","gravatar_id":"","url":"https://api.github.com/users/gijsk","html_url":"https://github.com/gijsk","followers_url":"https://api.github.com/users/gijsk/followers","following_url":"https://api.github.com/users/gijsk/following{/other_user}","gists_url":"https://api.github.com/users/gijsk/gists{/gist_id}","starred_url":"https://api.github.com/users/gijsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gijsk/subscriptions","organizations_url":"https://api.github.com/users/gijsk/orgs","repos_url":"https://api.github.com/users/gijsk/repos","events_url":"https://api.github.com/users/gijsk/events{/privacy}","received_events_url":"https://api.github.com/users/gijsk/received_events","type":"User","site_admin":false},"created_at":"2015-10-01T12:45:53Z","updated_at":"2015-10-01T12:45:53Z","body":"Fair points. The code is simpler this way, but it would probably be more performant if we avoided getting the nodelist length (as well as converting the one for the paragraphs into an array). I can look at that.\r\n\r\nWe do have performance tests for the commandline stuff but that won't work with this selector, I'm pretty sure, so I'll have to do some manual testing to get a better idea of what the impact is."}}