{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/1945","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/1945/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/1945/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/1945/events","html_url":"https://github.com/Automattic/wp-calypso/pull/1945","id":123732858,"number":1945,"title":"Settings: use form components","user":{"login":"roccotripaldi","id":2694219,"avatar_url":"https://avatars.githubusercontent.com/u/2694219?v=3","gravatar_id":"","url":"https://api.github.com/users/roccotripaldi","html_url":"https://github.com/roccotripaldi","followers_url":"https://api.github.com/users/roccotripaldi/followers","following_url":"https://api.github.com/users/roccotripaldi/following{/other_user}","gists_url":"https://api.github.com/users/roccotripaldi/gists{/gist_id}","starred_url":"https://api.github.com/users/roccotripaldi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roccotripaldi/subscriptions","organizations_url":"https://api.github.com/users/roccotripaldi/orgs","repos_url":"https://api.github.com/users/roccotripaldi/repos","events_url":"https://api.github.com/users/roccotripaldi/events{/privacy}","received_events_url":"https://api.github.com/users/roccotripaldi/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Site%20Settings","name":"Site Settings","color":"006b75"},{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20Author%20Reply","name":"[Status] Needs Author Reply","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-12-23T22:43:32Z","updated_at":"2015-12-24T01:05:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/1945","html_url":"https://github.com/Automattic/wp-calypso/pull/1945","diff_url":"https://github.com/Automattic/wp-calypso/pull/1945.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/1945.patch"},"body":"This PR is a continuation of #1920 - and should finish off updating Site Settings to use the shared form components instead of straight html tags.\r\n\r\nCloses #88\r\n\r\nCC: @dmsnell for review ( I'm off until Dec. 28, please review after you enjoy your holidays. see you then! )"},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/167016844","html_url":"https://github.com/Automattic/wp-calypso/pull/1945#issuecomment-167016844","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/1945","id":167016844,"user":{"login":"dmsnell","id":5431237,"avatar_url":"https://avatars.githubusercontent.com/u/5431237?v=3","gravatar_id":"","url":"https://api.github.com/users/dmsnell","html_url":"https://github.com/dmsnell","followers_url":"https://api.github.com/users/dmsnell/followers","following_url":"https://api.github.com/users/dmsnell/following{/other_user}","gists_url":"https://api.github.com/users/dmsnell/gists{/gist_id}","starred_url":"https://api.github.com/users/dmsnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmsnell/subscriptions","organizations_url":"https://api.github.com/users/dmsnell/orgs","repos_url":"https://api.github.com/users/dmsnell/repos","events_url":"https://api.github.com/users/dmsnell/events{/privacy}","received_events_url":"https://api.github.com/users/dmsnell/received_events","type":"User","site_admin":false},"created_at":"2015-12-24T01:05:39Z","updated_at":"2015-12-24T01:05:39Z","body":"> all standard form elements should use components from the Form directory\r\n\r\nmy personal thoughts are to have a good reason to wrap them. actually I have no problem doing something like this if we have the proper motivation. for example, if we had some funky API magic behind the scenes or applied some consistent CSS classes to the various elements it would make sense. On the other hand, without a clear direction, it seems a bit hard to justify the effort\r\n\r\nfor pure styling, though, if we say that all forms should use the form component so we can select them, then I think there's a similar argument in the other direction: if all our forms use the wrapper form elements _but are nothing more than the standard form elements_ then we can select every `form` and `option` in CSS just fine.\r\n\r\nit might be weird to mix custom and standard components - `<form><CustomFormThingy /></form>` and maybe that's valid enough of a reason too.\r\n\r\nto me as a reviewer, I'm much more concerned that _someone_ has a good reason for doing this than I am in _agreeing_ with that reason :wink:"}}