{"action":"created","comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/43071247","id":43071247,"diff_hunk":"@@ -233,21 +233,22 @@ func TestEval(t *testing.T) {\n \t\t// Cast expressions.\n \t\t{`true::boolean`, `true`},\n \t\t{`true::int`, `1`},\n-\t\t{`true::float`, `1`},\n+\t\t{`true::float`, `1.0`},\n \t\t{`length(true::text)`, `4`},\n \t\t{`false::boolean`, `false`},\n \t\t{`false::int`, `0`},\n-\t\t{`false::float`, `0`},\n+\t\t{`false::float`, `0.0`},\n \t\t{`length(false::text)`, `5`},\n \t\t{`1::boolean`, `true`},\n \t\t{`0::boolean`, `false`},\n \t\t{`1::int`, `1`},\n-\t\t{`1::float`, `1`},\n+\t\t{`1::float`, `1.0`},\n \t\t{`length(123::text)`, `3`},\n \t\t{`1.1::boolean`, `true`},\n \t\t{`0.0::boolean`, `false`},\n \t\t{`1.1::int`, `1`},\n \t\t{`1.1::float`, `1.1`},\n+\t\t{`1000000::float`, `1000000.0`},","path":"sql/parser/eval_test.go","position":22,"original_position":22,"commit_id":"62ceedae66b641c71992f4ddd961b827f049ee40","original_commit_id":"62ceedae66b641c71992f4ddd961b827f049ee40","user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"body":"Ah, yeah, this will have to be in TestEval. TestParse keeps everything represented as `NumVal`, which is just a string.","created_at":"2015-10-27T00:13:06Z","updated_at":"2015-10-27T00:13:06Z","html_url":"https://github.com/cockroachdb/cockroach/pull/2906#discussion_r43071247","pull_request_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/2906","_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/43071247"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/2906#discussion_r43071247"},"pull_request":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/2906"}}},"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/2906","id":48603786,"html_url":"https://github.com/cockroachdb/cockroach/pull/2906","diff_url":"https://github.com/cockroachdb/cockroach/pull/2906.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/2906.patch","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/2906","number":2906,"state":"open","locked":false,"title":"sql/parser: print whole floats as decimals - Fixes #2332","user":{"login":"jmank88","id":1194128,"avatar_url":"https://avatars.githubusercontent.com/u/1194128?v=3","gravatar_id":"","url":"https://api.github.com/users/jmank88","html_url":"https://github.com/jmank88","followers_url":"https://api.github.com/users/jmank88/followers","following_url":"https://api.github.com/users/jmank88/following{/other_user}","gists_url":"https://api.github.com/users/jmank88/gists{/gist_id}","starred_url":"https://api.github.com/users/jmank88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmank88/subscriptions","organizations_url":"https://api.github.com/users/jmank88/orgs","repos_url":"https://api.github.com/users/jmank88/repos","events_url":"https://api.github.com/users/jmank88/events{/privacy}","received_events_url":"https://api.github.com/users/jmank88/received_events","type":"User","site_admin":false},"body":"Checking for a decimal point isn't sufficient here. Verifying only numeric digits (save for a sign) seems efficient, but there may be a more readable or robust solution (perhaps piggy backing on Atoi?).\r\n\r\nThere's a lot of different ways to perform this test, and document what is happening. Happy to play with it if this doesn't feel right.","created_at":"2015-10-23T16:54:34Z","updated_at":"2015-10-27T00:13:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6b608fd9f70e72ff6297c5283c2b9b4ddda0ba7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/2906/commits","review_comments_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/2906/comments","review_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/2906/comments","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/62ceedae66b641c71992f4ddd961b827f049ee40","head":{"label":"jmank88:floats_ints","ref":"floats_ints","sha":"62ceedae66b641c71992f4ddd961b827f049ee40","user":{"login":"jmank88","id":1194128,"avatar_url":"https://avatars.githubusercontent.com/u/1194128?v=3","gravatar_id":"","url":"https://api.github.com/users/jmank88","html_url":"https://github.com/jmank88","followers_url":"https://api.github.com/users/jmank88/followers","following_url":"https://api.github.com/users/jmank88/following{/other_user}","gists_url":"https://api.github.com/users/jmank88/gists{/gist_id}","starred_url":"https://api.github.com/users/jmank88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmank88/subscriptions","organizations_url":"https://api.github.com/users/jmank88/orgs","repos_url":"https://api.github.com/users/jmank88/repos","events_url":"https://api.github.com/users/jmank88/events{/privacy}","received_events_url":"https://api.github.com/users/jmank88/received_events","type":"User","site_admin":false},"repo":{"id":31437527,"name":"cockroach","full_name":"jmank88/cockroach","owner":{"login":"jmank88","id":1194128,"avatar_url":"https://avatars.githubusercontent.com/u/1194128?v=3","gravatar_id":"","url":"https://api.github.com/users/jmank88","html_url":"https://github.com/jmank88","followers_url":"https://api.github.com/users/jmank88/followers","following_url":"https://api.github.com/users/jmank88/following{/other_user}","gists_url":"https://api.github.com/users/jmank88/gists{/gist_id}","starred_url":"https://api.github.com/users/jmank88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmank88/subscriptions","organizations_url":"https://api.github.com/users/jmank88/orgs","repos_url":"https://api.github.com/users/jmank88/repos","events_url":"https://api.github.com/users/jmank88/events{/privacy}","received_events_url":"https://api.github.com/users/jmank88/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmank88/cockroach","description":"A Scalable, Geo-Replicated, Transactional Datastore","fork":true,"url":"https://api.github.com/repos/jmank88/cockroach","forks_url":"https://api.github.com/repos/jmank88/cockroach/forks","keys_url":"https://api.github.com/repos/jmank88/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmank88/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmank88/cockroach/teams","hooks_url":"https://api.github.com/repos/jmank88/cockroach/hooks","issue_events_url":"https://api.github.com/repos/jmank88/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/jmank88/cockroach/events","assignees_url":"https://api.github.com/repos/jmank88/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/jmank88/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/jmank88/cockroach/tags","blobs_url":"https://api.github.com/repos/jmank88/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmank88/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmank88/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmank88/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmank88/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/jmank88/cockroach/languages","stargazers_url":"https://api.github.com/repos/jmank88/cockroach/stargazers","contributors_url":"https://api.github.com/repos/jmank88/cockroach/contributors","subscribers_url":"https://api.github.com/repos/jmank88/cockroach/subscribers","subscription_url":"https://api.github.com/repos/jmank88/cockroach/subscription","commits_url":"https://api.github.com/repos/jmank88/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmank88/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmank88/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmank88/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmank88/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/jmank88/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmank88/cockroach/merges","archive_url":"https://api.github.com/repos/jmank88/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmank88/cockroach/downloads","issues_url":"https://api.github.com/repos/jmank88/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/jmank88/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/jmank88/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/jmank88/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmank88/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/jmank88/cockroach/releases{/id}","created_at":"2015-02-27T20:22:32Z","updated_at":"2015-10-22T04:45:39Z","pushed_at":"2015-10-26T23:09:53Z","git_url":"git://github.com/jmank88/cockroach.git","ssh_url":"git@github.com:jmank88/cockroach.git","clone_url":"https://github.com/jmank88/cockroach.git","svn_url":"https://github.com/jmank88/cockroach","homepage":null,"size":42719,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"cockroachdb:master","ref":"master","sha":"4cd7bed032eaf4b9dc39e16a420c5a9c719912aa","user":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":16563587,"name":"cockroach","full_name":"cockroachdb/cockroach","owner":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockroachdb/cockroach","description":"A Scalable, Geo-Replicated, Transactional Datastore","fork":false,"url":"https://api.github.com/repos/cockroachdb/cockroach","forks_url":"https://api.github.com/repos/cockroachdb/cockroach/forks","keys_url":"https://api.github.com/repos/cockroachdb/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/cockroach/teams","hooks_url":"https://api.github.com/repos/cockroachdb/cockroach/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/cockroach/events","assignees_url":"https://api.github.com/repos/cockroachdb/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/cockroach/tags","blobs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/cockroach/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/cockroach/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/cockroach/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/cockroach/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/cockroach/subscription","commits_url":"https://api.github.com/repos/cockroachdb/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockroachdb/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/cockroach/merges","archive_url":"https://api.github.com/repos/cockroachdb/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/cockroach/downloads","issues_url":"https://api.github.com/repos/cockroachdb/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/cockroach/releases{/id}","created_at":"2014-02-06T00:18:47Z","updated_at":"2015-10-26T19:49:47Z","pushed_at":"2015-10-26T23:10:57Z","git_url":"git://github.com/cockroachdb/cockroach.git","ssh_url":"git@github.com:cockroachdb/cockroach.git","clone_url":"https://github.com/cockroachdb/cockroach.git","svn_url":"https://github.com/cockroachdb/cockroach","homepage":null,"size":70006,"stargazers_count":5495,"watchers_count":5495,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":461,"mirror_url":null,"open_issues_count":190,"forks":461,"open_issues":190,"watchers":5495,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/2906"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/2906"},"issue":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/2906"},"comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/2906/comments"},"review_comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/2906/comments"},"review_comment":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/2906/commits"},"statuses":{"href":"https://api.github.com/repos/cockroachdb/cockroach/statuses/62ceedae66b641c71992f4ddd961b827f049ee40"}}}}