{"action":"reopened","number":11139,"pull_request":{"url":"https://api.github.com/repos/tgstation/-tg-station/pulls/11139","id":42025462,"html_url":"https://github.com/tgstation/-tg-station/pull/11139","diff_url":"https://github.com/tgstation/-tg-station/pull/11139.diff","patch_url":"https://github.com/tgstation/-tg-station/pull/11139.patch","issue_url":"https://api.github.com/repos/tgstation/-tg-station/issues/11139","number":11139,"state":"open","locked":false,"title":"VV and VV Mass Modify now accept variables when editing a string","user":{"login":"RemieRichards","id":4043781,"avatar_url":"https://avatars.githubusercontent.com/u/4043781?v=3","gravatar_id":"","url":"https://api.github.com/users/RemieRichards","html_url":"https://github.com/RemieRichards","followers_url":"https://api.github.com/users/RemieRichards/followers","following_url":"https://api.github.com/users/RemieRichards/following{/other_user}","gists_url":"https://api.github.com/users/RemieRichards/gists{/gist_id}","starred_url":"https://api.github.com/users/RemieRichards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RemieRichards/subscriptions","organizations_url":"https://api.github.com/users/RemieRichards/orgs","repos_url":"https://api.github.com/users/RemieRichards/repos","events_url":"https://api.github.com/users/RemieRichards/events{/privacy}","received_events_url":"https://api.github.com/users/RemieRichards/received_events","type":"User","site_admin":false},"body":"## Feature\r\n* When modifying a variable that is a string, you can now embed other variables in that string by surrounding the variable names with square brackets, eg (Pseudo code):\r\n```\r\nreal_name = \"Remie\"\r\nname = \"Unknown\"\r\nname = [real_name]\r\nname = \"Remie\"\r\n```\r\n* When modifying a list element that is text, you may also embed variables\r\n* When modifying an associative list that's keys or elements are text, you may embed variables in the keys AND the elements\r\n* When adding a new text variable to a list you can also embed variables\r\n* When mass modifying a variable that is a string you can now embed other variables in that string by surrounding the variable names with square brackets. When doing this as a Mass Modify, you are asked whether the variables will all be fetched from the source datum (Meaning all instances get the same value) or whether they're all uniquely fetched from each instance\r\n\r\n## Disclaimer\r\n<B>The only variables that can be embedded in strings are the variables on the object you are currently VVing, which makes sense, but I just thought I'd make it clear</B>\r\n\r\n## Code\r\n* adds ```string2listofvars()``` which converts a string containing ```\"[var_name]s like this and [stuff]\"``` into a list of those variable names ```list(\"var_name\",\"stuff\")```\r\n* adds calls for ```string2listofvars()``` in the modify vars procs, and appropriate requests for user input.\r\n* adds an atom argument to ```mod_list_add_ass()``` so that it TOO can use the variable embedding in strings feature, the atom is always the same atom that you VV'd","created_at":"2015-08-10T14:25:56Z","updated_at":"2015-08-13T14:35:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22824c6bb4c55723c7b725ffd65edbcd10f26356","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tgstation/-tg-station/pulls/11139/commits","review_comments_url":"https://api.github.com/repos/tgstation/-tg-station/pulls/11139/comments","review_comment_url":"https://api.github.com/repos/tgstation/-tg-station/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tgstation/-tg-station/issues/11139/comments","statuses_url":"https://api.github.com/repos/tgstation/-tg-station/statuses/9ca1f2f262e0562ff9fefdfc53f2b4473c9d0dca","head":{"label":"RemieRichards:Varsception","ref":"Varsception","sha":"9ca1f2f262e0562ff9fefdfc53f2b4473c9d0dca","user":{"login":"RemieRichards","id":4043781,"avatar_url":"https://avatars.githubusercontent.com/u/4043781?v=3","gravatar_id":"","url":"https://api.github.com/users/RemieRichards","html_url":"https://github.com/RemieRichards","followers_url":"https://api.github.com/users/RemieRichards/followers","following_url":"https://api.github.com/users/RemieRichards/following{/other_user}","gists_url":"https://api.github.com/users/RemieRichards/gists{/gist_id}","starred_url":"https://api.github.com/users/RemieRichards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RemieRichards/subscriptions","organizations_url":"https://api.github.com/users/RemieRichards/orgs","repos_url":"https://api.github.com/users/RemieRichards/repos","events_url":"https://api.github.com/users/RemieRichards/events{/privacy}","received_events_url":"https://api.github.com/users/RemieRichards/received_events","type":"User","site_admin":false},"repo":{"id":12466296,"name":"-tg-station","full_name":"RemieRichards/-tg-station","owner":{"login":"RemieRichards","id":4043781,"avatar_url":"https://avatars.githubusercontent.com/u/4043781?v=3","gravatar_id":"","url":"https://api.github.com/users/RemieRichards","html_url":"https://github.com/RemieRichards","followers_url":"https://api.github.com/users/RemieRichards/followers","following_url":"https://api.github.com/users/RemieRichards/following{/other_user}","gists_url":"https://api.github.com/users/RemieRichards/gists{/gist_id}","starred_url":"https://api.github.com/users/RemieRichards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RemieRichards/subscriptions","organizations_url":"https://api.github.com/users/RemieRichards/orgs","repos_url":"https://api.github.com/users/RemieRichards/repos","events_url":"https://api.github.com/users/RemieRichards/events{/privacy}","received_events_url":"https://api.github.com/users/RemieRichards/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RemieRichards/-tg-station","description":"/tg/'s SS13 branch","fork":true,"url":"https://api.github.com/repos/RemieRichards/-tg-station","forks_url":"https://api.github.com/repos/RemieRichards/-tg-station/forks","keys_url":"https://api.github.com/repos/RemieRichards/-tg-station/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RemieRichards/-tg-station/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RemieRichards/-tg-station/teams","hooks_url":"https://api.github.com/repos/RemieRichards/-tg-station/hooks","issue_events_url":"https://api.github.com/repos/RemieRichards/-tg-station/issues/events{/number}","events_url":"https://api.github.com/repos/RemieRichards/-tg-station/events","assignees_url":"https://api.github.com/repos/RemieRichards/-tg-station/assignees{/user}","branches_url":"https://api.github.com/repos/RemieRichards/-tg-station/branches{/branch}","tags_url":"https://api.github.com/repos/RemieRichards/-tg-station/tags","blobs_url":"https://api.github.com/repos/RemieRichards/-tg-station/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RemieRichards/-tg-station/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RemieRichards/-tg-station/git/refs{/sha}","trees_url":"https://api.github.com/repos/RemieRichards/-tg-station/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RemieRichards/-tg-station/statuses/{sha}","languages_url":"https://api.github.com/repos/RemieRichards/-tg-station/languages","stargazers_url":"https://api.github.com/repos/RemieRichards/-tg-station/stargazers","contributors_url":"https://api.github.com/repos/RemieRichards/-tg-station/contributors","subscribers_url":"https://api.github.com/repos/RemieRichards/-tg-station/subscribers","subscription_url":"https://api.github.com/repos/RemieRichards/-tg-station/subscription","commits_url":"https://api.github.com/repos/RemieRichards/-tg-station/commits{/sha}","git_commits_url":"https://api.github.com/repos/RemieRichards/-tg-station/git/commits{/sha}","comments_url":"https://api.github.com/repos/RemieRichards/-tg-station/comments{/number}","issue_comment_url":"https://api.github.com/repos/RemieRichards/-tg-station/issues/comments{/number}","contents_url":"https://api.github.com/repos/RemieRichards/-tg-station/contents/{+path}","compare_url":"https://api.github.com/repos/RemieRichards/-tg-station/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RemieRichards/-tg-station/merges","archive_url":"https://api.github.com/repos/RemieRichards/-tg-station/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RemieRichards/-tg-station/downloads","issues_url":"https://api.github.com/repos/RemieRichards/-tg-station/issues{/number}","pulls_url":"https://api.github.com/repos/RemieRichards/-tg-station/pulls{/number}","milestones_url":"https://api.github.com/repos/RemieRichards/-tg-station/milestones{/number}","notifications_url":"https://api.github.com/repos/RemieRichards/-tg-station/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RemieRichards/-tg-station/labels{/name}","releases_url":"https://api.github.com/repos/RemieRichards/-tg-station/releases{/id}","created_at":"2013-08-29T17:14:29Z","updated_at":"2014-06-19T15:13:34Z","pushed_at":"2015-08-12T10:00:25Z","git_url":"git://github.com/RemieRichards/-tg-station.git","ssh_url":"git@github.com:RemieRichards/-tg-station.git","clone_url":"https://github.com/RemieRichards/-tg-station.git","svn_url":"https://github.com/RemieRichards/-tg-station","homepage":"","size":533372,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"tgstation:master","ref":"master","sha":"fcbd841b606d02213bd3472c2d3c14c76740d584","user":{"login":"tgstation","id":1363778,"avatar_url":"https://avatars.githubusercontent.com/u/1363778?v=3","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"repo":{"id":3234987,"name":"-tg-station","full_name":"tgstation/-tg-station","owner":{"login":"tgstation","id":1363778,"avatar_url":"https://avatars.githubusercontent.com/u/1363778?v=3","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tgstation/-tg-station","description":"the /tg/station branch of SS13","fork":false,"url":"https://api.github.com/repos/tgstation/-tg-station","forks_url":"https://api.github.com/repos/tgstation/-tg-station/forks","keys_url":"https://api.github.com/repos/tgstation/-tg-station/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tgstation/-tg-station/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tgstation/-tg-station/teams","hooks_url":"https://api.github.com/repos/tgstation/-tg-station/hooks","issue_events_url":"https://api.github.com/repos/tgstation/-tg-station/issues/events{/number}","events_url":"https://api.github.com/repos/tgstation/-tg-station/events","assignees_url":"https://api.github.com/repos/tgstation/-tg-station/assignees{/user}","branches_url":"https://api.github.com/repos/tgstation/-tg-station/branches{/branch}","tags_url":"https://api.github.com/repos/tgstation/-tg-station/tags","blobs_url":"https://api.github.com/repos/tgstation/-tg-station/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tgstation/-tg-station/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tgstation/-tg-station/git/refs{/sha}","trees_url":"https://api.github.com/repos/tgstation/-tg-station/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tgstation/-tg-station/statuses/{sha}","languages_url":"https://api.github.com/repos/tgstation/-tg-station/languages","stargazers_url":"https://api.github.com/repos/tgstation/-tg-station/stargazers","contributors_url":"https://api.github.com/repos/tgstation/-tg-station/contributors","subscribers_url":"https://api.github.com/repos/tgstation/-tg-station/subscribers","subscription_url":"https://api.github.com/repos/tgstation/-tg-station/subscription","commits_url":"https://api.github.com/repos/tgstation/-tg-station/commits{/sha}","git_commits_url":"https://api.github.com/repos/tgstation/-tg-station/git/commits{/sha}","comments_url":"https://api.github.com/repos/tgstation/-tg-station/comments{/number}","issue_comment_url":"https://api.github.com/repos/tgstation/-tg-station/issues/comments{/number}","contents_url":"https://api.github.com/repos/tgstation/-tg-station/contents/{+path}","compare_url":"https://api.github.com/repos/tgstation/-tg-station/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tgstation/-tg-station/merges","archive_url":"https://api.github.com/repos/tgstation/-tg-station/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tgstation/-tg-station/downloads","issues_url":"https://api.github.com/repos/tgstation/-tg-station/issues{/number}","pulls_url":"https://api.github.com/repos/tgstation/-tg-station/pulls{/number}","milestones_url":"https://api.github.com/repos/tgstation/-tg-station/milestones{/number}","notifications_url":"https://api.github.com/repos/tgstation/-tg-station/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tgstation/-tg-station/labels{/name}","releases_url":"https://api.github.com/repos/tgstation/-tg-station/releases{/id}","created_at":"2012-01-21T17:32:47Z","updated_at":"2015-08-12T12:38:00Z","pushed_at":"2015-08-13T14:33:54Z","git_url":"git://github.com/tgstation/-tg-station.git","ssh_url":"git@github.com:tgstation/-tg-station.git","clone_url":"https://github.com/tgstation/-tg-station.git","svn_url":"https://github.com/tgstation/-tg-station","homepage":"http://www.tgstation13.org/","size":737041,"stargazers_count":235,"watchers_count":235,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":809,"mirror_url":null,"open_issues_count":816,"forks":809,"open_issues":816,"watchers":235,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tgstation/-tg-station/pulls/11139"},"html":{"href":"https://github.com/tgstation/-tg-station/pull/11139"},"issue":{"href":"https://api.github.com/repos/tgstation/-tg-station/issues/11139"},"comments":{"href":"https://api.github.com/repos/tgstation/-tg-station/issues/11139/comments"},"review_comments":{"href":"https://api.github.com/repos/tgstation/-tg-station/pulls/11139/comments"},"review_comment":{"href":"https://api.github.com/repos/tgstation/-tg-station/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tgstation/-tg-station/pulls/11139/commits"},"statuses":{"href":"https://api.github.com/repos/tgstation/-tg-station/statuses/9ca1f2f262e0562ff9fefdfc53f2b4473c9d0dca"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":171,"deletions":12,"changed_files":4}}