{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/26352038","id":26352038,"diff_hunk":"@@ -0,0 +1,47 @@\n+﻿// Copyright (c) Microsoft.  All Rights Reserved.  Licensed under the Apache License, Version 2.0.  See License.txt in the project root for license information.\n+\n+using System;\n+using System.Threading;\n+using System.Threading.Tasks;\n+using Microsoft.CodeAnalysis.Host;\n+using Microsoft.CodeAnalysis.Internal.Log;\n+using Roslyn.Utilities;\n+\n+namespace Microsoft.CodeAnalysis\n+{\n+    /// <summary>\n+    /// A text source that keeps the text version cached.\n+    /// </summary>\n+    internal class CachedVersionTextSource : ValueSource<TextAndVersion>, ITextVersionable","path":"src/Workspaces/Core/Portable/Workspace/Solution/CachedVersionTextSource.cs","position":15,"original_position":15,"commit_id":"1d41666ef97a7f1b824ed8a58391a292894665f6","original_commit_id":"1d41666ef97a7f1b824ed8a58391a292894665f6","user":{"login":"mattwar","id":3387305,"avatar_url":"https://avatars.githubusercontent.com/u/3387305?v=3","gravatar_id":"","url":"https://api.github.com/users/mattwar","html_url":"https://github.com/mattwar","followers_url":"https://api.github.com/users/mattwar/followers","following_url":"https://api.github.com/users/mattwar/following{/other_user}","gists_url":"https://api.github.com/users/mattwar/gists{/gist_id}","starred_url":"https://api.github.com/users/mattwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattwar/subscriptions","organizations_url":"https://api.github.com/users/mattwar/orgs","repos_url":"https://api.github.com/users/mattwar/repos","events_url":"https://api.github.com/users/mattwar/events{/privacy}","received_events_url":"https://api.github.com/users/mattwar/received_events","type":"User","site_admin":false},"body":"No because you then need to add async methods to the API of TextAndVersion, which is a public API, and all consumers have to be changed to use the async API.","created_at":"2015-03-12T22:50:25Z","updated_at":"2015-03-12T22:50:25Z","html_url":"https://github.com/dotnet/roslyn/pull/1236#discussion_r26352038","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/1236","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/26352038"},"html":{"href":"https://github.com/dotnet/roslyn/pull/1236#discussion_r26352038"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/1236"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/1236","id":31085120,"html_url":"https://github.com/dotnet/roslyn/pull/1236","diff_url":"https://github.com/dotnet/roslyn/pull/1236.diff","patch_url":"https://github.com/dotnet/roslyn/pull/1236.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/1236","number":1236,"state":"open","locked":false,"title":"Allow text version to be freely accessible on updated documents ","user":{"login":"mattwar","id":3387305,"avatar_url":"https://avatars.githubusercontent.com/u/3387305?v=3","gravatar_id":"","url":"https://api.github.com/users/mattwar","html_url":"https://github.com/mattwar","followers_url":"https://api.github.com/users/mattwar/followers","following_url":"https://api.github.com/users/mattwar/following{/other_user}","gists_url":"https://api.github.com/users/mattwar/gists{/gist_id}","starred_url":"https://api.github.com/users/mattwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattwar/subscriptions","organizations_url":"https://api.github.com/users/mattwar/orgs","repos_url":"https://api.github.com/users/mattwar/repos","events_url":"https://api.github.com/users/mattwar/events{/privacy}","received_events_url":"https://api.github.com/users/mattwar/received_events","type":"User","site_admin":false},"body":"Possibly fixes #1157 \r\n\r\n@heejaechang, @jaredpar, @Pilchie  please take a look.\r\n\r\nThis does not solve the problem about the text being recreated each time it is requested.","created_at":"2015-03-12T22:41:08Z","updated_at":"2015-03-12T22:50:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ef9e29ce938bcdec843d99ce3993611690eacc4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/1236/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/1236/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/1236/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/1d41666ef97a7f1b824ed8a58391a292894665f6","head":{"label":"mattwar:TextVersion","ref":"TextVersion","sha":"1d41666ef97a7f1b824ed8a58391a292894665f6","user":{"login":"mattwar","id":3387305,"avatar_url":"https://avatars.githubusercontent.com/u/3387305?v=3","gravatar_id":"","url":"https://api.github.com/users/mattwar","html_url":"https://github.com/mattwar","followers_url":"https://api.github.com/users/mattwar/followers","following_url":"https://api.github.com/users/mattwar/following{/other_user}","gists_url":"https://api.github.com/users/mattwar/gists{/gist_id}","starred_url":"https://api.github.com/users/mattwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattwar/subscriptions","organizations_url":"https://api.github.com/users/mattwar/orgs","repos_url":"https://api.github.com/users/mattwar/repos","events_url":"https://api.github.com/users/mattwar/events{/privacy}","received_events_url":"https://api.github.com/users/mattwar/received_events","type":"User","site_admin":false},"repo":{"id":30200787,"name":"roslyn","full_name":"mattwar/roslyn","owner":{"login":"mattwar","id":3387305,"avatar_url":"https://avatars.githubusercontent.com/u/3387305?v=3","gravatar_id":"","url":"https://api.github.com/users/mattwar","html_url":"https://github.com/mattwar","followers_url":"https://api.github.com/users/mattwar/followers","following_url":"https://api.github.com/users/mattwar/following{/other_user}","gists_url":"https://api.github.com/users/mattwar/gists{/gist_id}","starred_url":"https://api.github.com/users/mattwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattwar/subscriptions","organizations_url":"https://api.github.com/users/mattwar/orgs","repos_url":"https://api.github.com/users/mattwar/repos","events_url":"https://api.github.com/users/mattwar/events{/privacy}","received_events_url":"https://api.github.com/users/mattwar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattwar/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/mattwar/roslyn","forks_url":"https://api.github.com/repos/mattwar/roslyn/forks","keys_url":"https://api.github.com/repos/mattwar/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattwar/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattwar/roslyn/teams","hooks_url":"https://api.github.com/repos/mattwar/roslyn/hooks","issue_events_url":"https://api.github.com/repos/mattwar/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/mattwar/roslyn/events","assignees_url":"https://api.github.com/repos/mattwar/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/mattwar/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/mattwar/roslyn/tags","blobs_url":"https://api.github.com/repos/mattwar/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattwar/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattwar/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattwar/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattwar/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/mattwar/roslyn/languages","stargazers_url":"https://api.github.com/repos/mattwar/roslyn/stargazers","contributors_url":"https://api.github.com/repos/mattwar/roslyn/contributors","subscribers_url":"https://api.github.com/repos/mattwar/roslyn/subscribers","subscription_url":"https://api.github.com/repos/mattwar/roslyn/subscription","commits_url":"https://api.github.com/repos/mattwar/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattwar/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattwar/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattwar/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattwar/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/mattwar/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattwar/roslyn/merges","archive_url":"https://api.github.com/repos/mattwar/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattwar/roslyn/downloads","issues_url":"https://api.github.com/repos/mattwar/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/mattwar/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/mattwar/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/mattwar/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattwar/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/mattwar/roslyn/releases{/id}","created_at":"2015-02-02T18:12:54Z","updated_at":"2015-03-09T18:34:27Z","pushed_at":"2015-03-12T22:39:06Z","git_url":"git://github.com/mattwar/roslyn.git","ssh_url":"git@github.com:mattwar/roslyn.git","clone_url":"https://github.com/mattwar/roslyn.git","svn_url":"https://github.com/mattwar/roslyn","homepage":"","size":55340,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"ea99e5723da7e886ce7278a7879e0d69a2bea77a","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","created_at":"2015-01-11T02:39:03Z","updated_at":"2015-03-12T22:28:06Z","pushed_at":"2015-03-12T21:08:22Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":82488,"stargazers_count":1463,"watchers_count":1463,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":302,"mirror_url":null,"open_issues_count":496,"forks":302,"open_issues":496,"watchers":1463,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/1236"},"html":{"href":"https://github.com/dotnet/roslyn/pull/1236"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/1236"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/1236/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/1236/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/1236/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/1d41666ef97a7f1b824ed8a58391a292894665f6"}}}}