{"action":"created","issue":{"url":"https://api.github.com/repos/primer/primer/issues/19","labels_url":"https://api.github.com/repos/primer/primer/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/primer/primer/issues/19/comments","events_url":"https://api.github.com/repos/primer/primer/issues/19/events","html_url":"https://github.com/primer/primer/pull/19","id":63872635,"number":19,"title":"Rudimentary refactor of flashes","user":{"login":"lachlanjc","id":5074763,"avatar_url":"https://avatars.githubusercontent.com/u/5074763?v=3","gravatar_id":"","url":"https://api.github.com/users/lachlanjc","html_url":"https://github.com/lachlanjc","followers_url":"https://api.github.com/users/lachlanjc/followers","following_url":"https://api.github.com/users/lachlanjc/following{/other_user}","gists_url":"https://api.github.com/users/lachlanjc/gists{/gist_id}","starred_url":"https://api.github.com/users/lachlanjc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lachlanjc/subscriptions","organizations_url":"https://api.github.com/users/lachlanjc/orgs","repos_url":"https://api.github.com/users/lachlanjc/repos","events_url":"https://api.github.com/users/lachlanjc/events{/privacy}","received_events_url":"https://api.github.com/users/lachlanjc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/primer/primer/milestones/3","html_url":"https://github.com/primer/primer/milestones/v3.0.0","labels_url":"https://api.github.com/repos/primer/primer/milestones/3/labels","id":1049711,"number":3,"title":"v3.0.0","description":null,"creator":{"login":"mdo","id":98681,"avatar_url":"https://avatars.githubusercontent.com/u/98681?v=3","gravatar_id":"","url":"https://api.github.com/users/mdo","html_url":"https://github.com/mdo","followers_url":"https://api.github.com/users/mdo/followers","following_url":"https://api.github.com/users/mdo/following{/other_user}","gists_url":"https://api.github.com/users/mdo/gists{/gist_id}","starred_url":"https://api.github.com/users/mdo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdo/subscriptions","organizations_url":"https://api.github.com/users/mdo/orgs","repos_url":"https://api.github.com/users/mdo/repos","events_url":"https://api.github.com/users/mdo/events{/privacy}","received_events_url":"https://api.github.com/users/mdo/received_events","type":"User","site_admin":true},"open_issues":4,"closed_issues":0,"state":"open","created_at":"2015-04-02T02:40:17Z","updated_at":"2015-05-11T19:55:43Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2015-03-24T01:16:45Z","updated_at":"2015-06-16T01:35:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/primer/primer/pulls/19","html_url":"https://github.com/primer/primer/pull/19","diff_url":"https://github.com/primer/primer/pull/19.diff","patch_url":"https://github.com/primer/primer/pull/19.patch"},"body":"The code for alerts was a bit messy and repetitive, so I’ve done a rudimentary refactor along with improvements to the documentation.\r\n\r\nA few changes:\r\n- I’ve removed the `.flash-with-icon` class in favor of just styling a `.octicon` directly inside the flash. Several declarations cut (no negative margins needed).\r\n- I’ve removed the global flashes in favor of `.flash-sm`. The global flashes before were doubling the selector count and had an inconsistent design.\r\n- I’ve removed `.flash-action` in favor of just plain `.btn` selectors. There may be some debate about this, but without any documentation I didn’t see any other elements besides buttons that might go there.\r\n- I’ve removed `.flash-title` entirely. Having a header in a flash seemed rather rude and unnecessary, and there was no documentation mentioning them. Again, there may some debate here.\r\n\r\n**Stats:** (more detail in `css/.primer-stats.md`)\r\nSelectors: 582 => 570\r\nDeclarations: 1003 => 994"},"comment":{"url":"https://api.github.com/repos/primer/primer/issues/comments/112255882","html_url":"https://github.com/primer/primer/pull/19#issuecomment-112255882","issue_url":"https://api.github.com/repos/primer/primer/issues/19","id":112255882,"user":{"login":"lachlanjc","id":5074763,"avatar_url":"https://avatars.githubusercontent.com/u/5074763?v=3","gravatar_id":"","url":"https://api.github.com/users/lachlanjc","html_url":"https://github.com/lachlanjc","followers_url":"https://api.github.com/users/lachlanjc/followers","following_url":"https://api.github.com/users/lachlanjc/following{/other_user}","gists_url":"https://api.github.com/users/lachlanjc/gists{/gist_id}","starred_url":"https://api.github.com/users/lachlanjc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lachlanjc/subscriptions","organizations_url":"https://api.github.com/users/lachlanjc/orgs","repos_url":"https://api.github.com/users/lachlanjc/repos","events_url":"https://api.github.com/users/lachlanjc/events{/privacy}","received_events_url":"https://api.github.com/users/lachlanjc/received_events","type":"User","site_admin":false},"created_at":"2015-06-16T01:35:56Z","updated_at":"2015-06-16T01:35:56Z","body":"@mdo Any updates on this? It’s been two months now, just wondering if this is still good. There are conflicts now, though."}}