{"action":"created","issue":{"url":"https://api.github.com/repos/galaxyproject/planemo/issues/186","labels_url":"https://api.github.com/repos/galaxyproject/planemo/issues/186/labels{/name}","comments_url":"https://api.github.com/repos/galaxyproject/planemo/issues/186/comments","events_url":"https://api.github.com/repos/galaxyproject/planemo/issues/186/events","html_url":"https://github.com/galaxyproject/planemo/pull/186","id":73999844,"number":186,"title":"Avoid ambigous destination value in test case...","user":{"login":"peterjc","id":63959,"avatar_url":"https://avatars.githubusercontent.com/u/63959?v=3","gravatar_id":"","url":"https://api.github.com/users/peterjc","html_url":"https://github.com/peterjc","followers_url":"https://api.github.com/users/peterjc/followers","following_url":"https://api.github.com/users/peterjc/following{/other_user}","gists_url":"https://api.github.com/users/peterjc/gists{/gist_id}","starred_url":"https://api.github.com/users/peterjc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterjc/subscriptions","organizations_url":"https://api.github.com/users/peterjc/orgs","repos_url":"https://api.github.com/users/peterjc/repos","events_url":"https://api.github.com/users/peterjc/events{/privacy}","received_events_url":"https://api.github.com/users/peterjc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-05-07T14:07:02Z","updated_at":"2015-05-07T14:11:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/galaxyproject/planemo/pulls/186","html_url":"https://github.com/galaxyproject/planemo/pull/186","diff_url":"https://github.com/galaxyproject/planemo/pull/186.diff","patch_url":"https://github.com/galaxyproject/planemo/pull/186.patch"},"body":"Suggestion: If the ``source`` has any wildcards (or is a folder with an implicit wildcard), then ``destination`` must be a directory given with trailing slash (otherwise error).\r\n\r\nThe include source of \"../shared_files/extra_test_data/**\" would only find \"../shared_files/extra_test_data/extra_test_file.txt\" which after strip_components 3 gives \"extra_test_file.txt\"\r\n\r\nQuestion: did the \".shed.yml\" destination of \"test-data\" mean call this file \"test-data\" [sic] or use \"test-data/extra_test_file.txt\" instead? Why?\r\n\r\nWhat if the include source glob matches multiple files? Then might expect destination must be a folder - since alternative means trying to map multiple input files to one in the tar-ball/\r\n\r\nUsing destination \"test-data/\" seem unambiguous and preferable.\r\n\r\n(I found this issue during re-factoring while working on #180)"},"comment":{"url":"https://api.github.com/repos/galaxyproject/planemo/issues/comments/99881630","html_url":"https://github.com/galaxyproject/planemo/pull/186#issuecomment-99881630","issue_url":"https://api.github.com/repos/galaxyproject/planemo/issues/186","id":99881630,"user":{"login":"jmchilton","id":216771,"avatar_url":"https://avatars.githubusercontent.com/u/216771?v=3","gravatar_id":"","url":"https://api.github.com/users/jmchilton","html_url":"https://github.com/jmchilton","followers_url":"https://api.github.com/users/jmchilton/followers","following_url":"https://api.github.com/users/jmchilton/following{/other_user}","gists_url":"https://api.github.com/users/jmchilton/gists{/gist_id}","starred_url":"https://api.github.com/users/jmchilton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmchilton/subscriptions","organizations_url":"https://api.github.com/users/jmchilton/orgs","repos_url":"https://api.github.com/users/jmchilton/repos","events_url":"https://api.github.com/users/jmchilton/events{/privacy}","received_events_url":"https://api.github.com/users/jmchilton/received_events","type":"User","site_admin":false},"created_at":"2015-05-07T14:11:29Z","updated_at":"2015-05-07T14:11:29Z","body":"Okay - I can live with that - what you are proposing seems like a tighter, more reasonable spec. We should make sure shed_lint provides a good description of the problem though."}}