{"action":"created","issue":{"url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/5509","labels_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/5509/labels{/name}","comments_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/5509/comments","events_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/5509/events","html_url":"https://github.com/HabitRPG/habitrpg/pull/5509","id":91559937,"number":5509,"title":"allow public guild list to have links to guilds for previewing without joining","user":{"login":"Alys","id":1495809,"avatar_url":"https://avatars.githubusercontent.com/u/1495809?v=3","gravatar_id":"","url":"https://api.github.com/users/Alys","html_url":"https://github.com/Alys","followers_url":"https://api.github.com/users/Alys/followers","following_url":"https://api.github.com/users/Alys/following{/other_user}","gists_url":"https://api.github.com/users/Alys/gists{/gist_id}","starred_url":"https://api.github.com/users/Alys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alys/subscriptions","organizations_url":"https://api.github.com/users/Alys/orgs","repos_url":"https://api.github.com/users/Alys/repos","events_url":"https://api.github.com/users/Alys/events{/privacy}","received_events_url":"https://api.github.com/users/Alys/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":17,"created_at":"2015-06-28T06:11:25Z","updated_at":"2015-07-01T03:51:15Z","closed_at":"2015-07-01T03:40:41Z","pull_request":{"url":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/5509","html_url":"https://github.com/HabitRPG/habitrpg/pull/5509","diff_url":"https://github.com/HabitRPG/habitrpg/pull/5509.diff","patch_url":"https://github.com/HabitRPG/habitrpg/pull/5509.patch"},"body":"Don't merge without approval. Pinging @lemoness \r\n\r\nThis PR adjusts the [index page of PUBLIC guilds](https://habitrpg.com/#/options/groups/guilds/public) so that each guild name is a link to the guild. Private guilds are NOT affected.\r\n\r\nThis allows you to view a public guild's chat and challenges without joining the guild. I suspect this might be controversial so the rest of this comment is a description of why I think it's good. There's a screenshot of the list page at the bottom. \r\n\r\nHaving direct, non-join links from the guild list page significantly speeds up the process of deciding which guilds to join. \r\n\r\n**At the moment on the production site, to view a guild that you might be interested in, you have to:**\r\n* click its join button from the guild list page\r\n* wait for a sync \r\n* wait for the page to reload\r\n\r\nThen if you decide you don't want to be in the guild:\r\n* click leave \r\n* wait for another sync \r\n* wait for another reload, and then if you want to view more guilds:\r\n* find your previous place in the guild list (requires a lot of scrolling or a new search).\r\n\r\n**With this PR, the process is just:**\r\n* click on the guild's name, \r\n* wait for a sync (no reload)\r\n\r\nThen if you decide you don't want to be in the guild:\r\n* click your browser's back button (instantaneous, no sync nor reload), and you're back to your previous place in the guild list (no scrolling or searching, although that might be browser-dependent; it works in Chrome).\r\n\r\nWith this PR, the only time you have to wait for a reload is if you decide to join the guild, and even after that you can click back to instantly get to your previous page in the guild list.\r\n\r\nThis PR also allows you to have more control over your own behaviour in following guild chat. Instead of being tempted to stop work and read chat every time there's a notification, you can avoid joining the guild and only read its chat once a day, or once every few days (that's already possible if you bookmark the guild's URL, but links from the guild list page make it easier).\r\n\r\nThe disadvantage of this PR is that people can view a guild without being a member, but I don't think that's a significant disadvantage at all. You can already do that if someone gives you a link to the guild, or if you join once and copy the link and then leave, or if you use the API to get data about the guild. Also, for most guilds it's not possible to see all the guild members so the guild leader and other members aren't disadvantaged by not seeing the names of people who are reading chat without being members.\r\n\r\nThis does also allow you to join a challenge without being a member of a guild (ref https://github.com/HabitRPG/habitrpg/issues/5168 for why this might be considered bad), but, again, you can already do that.\r\n\r\n**Screenshot - the only visible difference is the blue colour for the guilds' names:**\r\n\r\n![screen shot 2015-06-28 at 4 07 26 pm](https://cloud.githubusercontent.com/assets/1495809/8395361/ddc33e12-1daf-11e5-8be5-5181a096c5dc.png)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/comments/117427200","html_url":"https://github.com/HabitRPG/habitrpg/pull/5509#issuecomment-117427200","issue_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/5509","id":117427200,"user":{"login":"Alys","id":1495809,"avatar_url":"https://avatars.githubusercontent.com/u/1495809?v=3","gravatar_id":"","url":"https://api.github.com/users/Alys","html_url":"https://github.com/Alys","followers_url":"https://api.github.com/users/Alys/followers","following_url":"https://api.github.com/users/Alys/following{/other_user}","gists_url":"https://api.github.com/users/Alys/gists{/gist_id}","starred_url":"https://api.github.com/users/Alys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alys/subscriptions","organizations_url":"https://api.github.com/users/Alys/orgs","repos_url":"https://api.github.com/users/Alys/repos","events_url":"https://api.github.com/users/Alys/events{/privacy}","received_events_url":"https://api.github.com/users/Alys/received_events","type":"User","site_admin":false},"created_at":"2015-07-01T03:51:15Z","updated_at":"2015-07-01T03:51:15Z","body":"My preference for the default is to keep the current behaviour - all users can post to a guild unless the guild leader chooses to lock it down. I think that's a more open and friendly option, and better for usability."}}