{"action":"created","issue":{"url":"https://api.github.com/repos/hapijs/boom/issues/58","labels_url":"https://api.github.com/repos/hapijs/boom/issues/58/labels{/name}","comments_url":"https://api.github.com/repos/hapijs/boom/issues/58/comments","events_url":"https://api.github.com/repos/hapijs/boom/issues/58/events","html_url":"https://github.com/hapijs/boom/pull/58","id":76123953,"number":58,"title":"Making Boom more Browserify friendly","user":{"login":"abritinthebay","id":492797,"avatar_url":"https://avatars.githubusercontent.com/u/492797?v=3","gravatar_id":"","url":"https://api.github.com/users/abritinthebay","html_url":"https://github.com/abritinthebay","followers_url":"https://api.github.com/users/abritinthebay/followers","following_url":"https://api.github.com/users/abritinthebay/following{/other_user}","gists_url":"https://api.github.com/users/abritinthebay/gists{/gist_id}","starred_url":"https://api.github.com/users/abritinthebay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abritinthebay/subscriptions","organizations_url":"https://api.github.com/users/abritinthebay/orgs","repos_url":"https://api.github.com/users/abritinthebay/repos","events_url":"https://api.github.com/users/abritinthebay/events{/privacy}","received_events_url":"https://api.github.com/users/abritinthebay/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/hapijs/boom/labels/discussion","name":"discussion","color":"d4c5f9"},{"url":"https://api.github.com/repos/hapijs/boom/labels/enhancement","name":"enhancement","color":"207de5"}],"state":"open","locked":false,"assignee":{"login":"arb","id":1591483,"avatar_url":"https://avatars.githubusercontent.com/u/1591483?v=3","gravatar_id":"","url":"https://api.github.com/users/arb","html_url":"https://github.com/arb","followers_url":"https://api.github.com/users/arb/followers","following_url":"https://api.github.com/users/arb/following{/other_user}","gists_url":"https://api.github.com/users/arb/gists{/gist_id}","starred_url":"https://api.github.com/users/arb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arb/subscriptions","organizations_url":"https://api.github.com/users/arb/orgs","repos_url":"https://api.github.com/users/arb/repos","events_url":"https://api.github.com/users/arb/events{/privacy}","received_events_url":"https://api.github.com/users/arb/received_events","type":"User","site_admin":false},"milestone":null,"comments":16,"created_at":"2015-05-13T21:09:34Z","updated_at":"2015-05-14T21:44:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hapijs/boom/pulls/58","html_url":"https://github.com/hapijs/boom/pull/58","diff_url":"https://github.com/hapijs/boom/pull/58.diff","patch_url":"https://github.com/hapijs/boom/pull/58.patch"},"body":"#### What's this PR do?\r\nIt adds a MUCH smaller Browserify friendly alternative to pulling in the entire HTTP lib just for the status codes. This isn't a problem in Node but it's a huge lib to shim when running isomorphic apps.\r\n\r\n#### Where should the reviewer start?\r\nIf you're happy with the construction (it's just the status-code array, as that's all that is used) then it only affects Browserify - node usage is unaffected. Very low impact for most applications.\r\n\r\n#### How should this be manually tested?\r\nTry importing the code with Browserify - the file size for the resulting file will be much smaller.\r\n\r\n#### Any background context you want to provide?\r\nI've written a Hapi compatible router for an isomorphic application - it required using Call, which uses Boom and Hoek - both have a lot of bloat for browsers (that isn't an issue on the server at all). \r\nThis is an attempt to make the whole package more friendly upstream rather than maintaining a permanent fork.\r\n\r\nIt will also benefit other users potentially (it's a great lib!) and if there is no plan to use anything other than the status codes perhaps it could be folded into the non-browser side of the lib eventually."},"comment":{"url":"https://api.github.com/repos/hapijs/boom/issues/comments/102178739","html_url":"https://github.com/hapijs/boom/pull/58#issuecomment-102178739","issue_url":"https://api.github.com/repos/hapijs/boom/issues/58","id":102178739,"user":{"login":"Marsup","id":796194,"avatar_url":"https://avatars.githubusercontent.com/u/796194?v=3","gravatar_id":"","url":"https://api.github.com/users/Marsup","html_url":"https://github.com/Marsup","followers_url":"https://api.github.com/users/Marsup/followers","following_url":"https://api.github.com/users/Marsup/following{/other_user}","gists_url":"https://api.github.com/users/Marsup/gists{/gist_id}","starred_url":"https://api.github.com/users/Marsup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Marsup/subscriptions","organizations_url":"https://api.github.com/users/Marsup/orgs","repos_url":"https://api.github.com/users/Marsup/repos","events_url":"https://api.github.com/users/Marsup/events{/privacy}","received_events_url":"https://api.github.com/users/Marsup/received_events","type":"User","site_admin":false},"created_at":"2015-05-14T21:44:52Z","updated_at":"2015-05-14T21:44:52Z","body":"Doesn't work which way ? I did on-the-fly modifications of libs through AST parsing (in the browserify bundle), this one is a piece of cake."}}