{"action":"created","comment":{"url":"https://api.github.com/repos/embox/embox/pulls/comments/31334205","id":31334205,"diff_hunk":"@@ -197,16 +201,18 @@ static void e1000_rx(struct net_device *dev) {\n \t\t\tskb = rx_skbs[cur];\n \t\t\tassert (skb);\n \n-\t\t\trx_skbs[cur]= skb_alloc(ETH_FRAME_LEN);\n+\t\t\trx_skbs[cur] = skb_alloc(E1000_MAX_RX_LEN);\n \t\t\tif (rx_skbs[cur] == NULL)\n \t\t\t\tpanic(\"Can't allocate rx_skbs %d\", cur);\n \t\t\trx_descs[cur].buffer_address = (uint32_t) rx_skbs[cur]->mac.raw;\n \n-\n+\t\t\tlen = rx_descs[cur].length - E1000_RX_CHECKSUM_LEN;\n+\t\t\tskb = skb_realloc(len, skb);\n+\t\t\tif (!skb) {\n+\t\t\t\tpanic(\"Can't reallocate rx_skb\");","path":"src/drivers/net/e1000.c","position":39,"original_position":39,"commit_id":"2c5112e4178a54fe5e9fb9d0190419f570d8f757","original_commit_id":"2c5112e4178a54fe5e9fb9d0190419f570d8f757","user":{"login":"abusalimov","id":530396,"avatar_url":"https://avatars.githubusercontent.com/u/530396?v=3","gravatar_id":"","url":"https://api.github.com/users/abusalimov","html_url":"https://github.com/abusalimov","followers_url":"https://api.github.com/users/abusalimov/followers","following_url":"https://api.github.com/users/abusalimov/following{/other_user}","gists_url":"https://api.github.com/users/abusalimov/gists{/gist_id}","starred_url":"https://api.github.com/users/abusalimov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abusalimov/subscriptions","organizations_url":"https://api.github.com/users/abusalimov/orgs","repos_url":"https://api.github.com/users/abusalimov/repos","events_url":"https://api.github.com/users/abusalimov/events{/privacy}","received_events_url":"https://api.github.com/users/abusalimov/received_events","type":"User","site_admin":false},"body":"That's weird anyway. I.e. instead of dropping the packet, we just drop the system? :)","created_at":"2015-05-29T15:20:18Z","updated_at":"2015-05-29T15:20:18Z","html_url":"https://github.com/embox/embox/pull/762#discussion_r31334205","pull_request_url":"https://api.github.com/repos/embox/embox/pulls/762","_links":{"self":{"href":"https://api.github.com/repos/embox/embox/pulls/comments/31334205"},"html":{"href":"https://github.com/embox/embox/pull/762#discussion_r31334205"},"pull_request":{"href":"https://api.github.com/repos/embox/embox/pulls/762"}}},"pull_request":{"url":"https://api.github.com/repos/embox/embox/pulls/762","id":36513747,"html_url":"https://github.com/embox/embox/pull/762","diff_url":"https://github.com/embox/embox/pull/762.diff","patch_url":"https://github.com/embox/embox/pull/762.patch","issue_url":"https://api.github.com/repos/embox/embox/issues/762","number":762,"state":"open","locked":false,"title":"e1000: Fix e1000 big packet receive","user":{"login":"AntonKozlov","id":919084,"avatar_url":"https://avatars.githubusercontent.com/u/919084?v=3","gravatar_id":"","url":"https://api.github.com/users/AntonKozlov","html_url":"https://github.com/AntonKozlov","followers_url":"https://api.github.com/users/AntonKozlov/followers","following_url":"https://api.github.com/users/AntonKozlov/following{/other_user}","gists_url":"https://api.github.com/users/AntonKozlov/gists{/gist_id}","starred_url":"https://api.github.com/users/AntonKozlov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AntonKozlov/subscriptions","organizations_url":"https://api.github.com/users/AntonKozlov/orgs","repos_url":"https://api.github.com/users/AntonKozlov/repos","events_url":"https://api.github.com/users/AntonKozlov/events{/privacy}","received_events_url":"https://api.github.com/users/AntonKozlov/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-05-29T14:59:48Z","updated_at":"2015-05-29T15:20:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd5239cc3b25cb129f2b9cb989dce558d18ab90d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/embox/embox/pulls/762/commits","review_comments_url":"https://api.github.com/repos/embox/embox/pulls/762/comments","review_comment_url":"https://api.github.com/repos/embox/embox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/embox/embox/issues/762/comments","statuses_url":"https://api.github.com/repos/embox/embox/statuses/2c5112e4178a54fe5e9fb9d0190419f570d8f757","head":{"label":"embox:e1000-fix-big-rx","ref":"e1000-fix-big-rx","sha":"2c5112e4178a54fe5e9fb9d0190419f570d8f757","user":{"login":"embox","id":9039916,"avatar_url":"https://avatars.githubusercontent.com/u/9039916?v=3","gravatar_id":"","url":"https://api.github.com/users/embox","html_url":"https://github.com/embox","followers_url":"https://api.github.com/users/embox/followers","following_url":"https://api.github.com/users/embox/following{/other_user}","gists_url":"https://api.github.com/users/embox/gists{/gist_id}","starred_url":"https://api.github.com/users/embox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/embox/subscriptions","organizations_url":"https://api.github.com/users/embox/orgs","repos_url":"https://api.github.com/users/embox/repos","events_url":"https://api.github.com/users/embox/events{/privacy}","received_events_url":"https://api.github.com/users/embox/received_events","type":"Organization","site_admin":false},"repo":{"id":33078138,"name":"embox","full_name":"embox/embox","owner":{"login":"embox","id":9039916,"avatar_url":"https://avatars.githubusercontent.com/u/9039916?v=3","gravatar_id":"","url":"https://api.github.com/users/embox","html_url":"https://github.com/embox","followers_url":"https://api.github.com/users/embox/followers","following_url":"https://api.github.com/users/embox/following{/other_user}","gists_url":"https://api.github.com/users/embox/gists{/gist_id}","starred_url":"https://api.github.com/users/embox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/embox/subscriptions","organizations_url":"https://api.github.com/users/embox/orgs","repos_url":"https://api.github.com/users/embox/repos","events_url":"https://api.github.com/users/embox/events{/privacy}","received_events_url":"https://api.github.com/users/embox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/embox/embox","description":"The OS Kernel","fork":false,"url":"https://api.github.com/repos/embox/embox","forks_url":"https://api.github.com/repos/embox/embox/forks","keys_url":"https://api.github.com/repos/embox/embox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/embox/embox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/embox/embox/teams","hooks_url":"https://api.github.com/repos/embox/embox/hooks","issue_events_url":"https://api.github.com/repos/embox/embox/issues/events{/number}","events_url":"https://api.github.com/repos/embox/embox/events","assignees_url":"https://api.github.com/repos/embox/embox/assignees{/user}","branches_url":"https://api.github.com/repos/embox/embox/branches{/branch}","tags_url":"https://api.github.com/repos/embox/embox/tags","blobs_url":"https://api.github.com/repos/embox/embox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/embox/embox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/embox/embox/git/refs{/sha}","trees_url":"https://api.github.com/repos/embox/embox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/embox/embox/statuses/{sha}","languages_url":"https://api.github.com/repos/embox/embox/languages","stargazers_url":"https://api.github.com/repos/embox/embox/stargazers","contributors_url":"https://api.github.com/repos/embox/embox/contributors","subscribers_url":"https://api.github.com/repos/embox/embox/subscribers","subscription_url":"https://api.github.com/repos/embox/embox/subscription","commits_url":"https://api.github.com/repos/embox/embox/commits{/sha}","git_commits_url":"https://api.github.com/repos/embox/embox/git/commits{/sha}","comments_url":"https://api.github.com/repos/embox/embox/comments{/number}","issue_comment_url":"https://api.github.com/repos/embox/embox/issues/comments{/number}","contents_url":"https://api.github.com/repos/embox/embox/contents/{+path}","compare_url":"https://api.github.com/repos/embox/embox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/embox/embox/merges","archive_url":"https://api.github.com/repos/embox/embox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/embox/embox/downloads","issues_url":"https://api.github.com/repos/embox/embox/issues{/number}","pulls_url":"https://api.github.com/repos/embox/embox/pulls{/number}","milestones_url":"https://api.github.com/repos/embox/embox/milestones{/number}","notifications_url":"https://api.github.com/repos/embox/embox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/embox/embox/labels{/name}","releases_url":"https://api.github.com/repos/embox/embox/releases{/id}","created_at":"2015-03-29T15:27:48Z","updated_at":"2015-05-28T21:43:36Z","pushed_at":"2015-05-29T15:09:56Z","git_url":"git://github.com/embox/embox.git","ssh_url":"git@github.com:embox/embox.git","clone_url":"https://github.com/embox/embox.git","svn_url":"https://github.com/embox/embox","homepage":"","size":32108,"stargazers_count":44,"watchers_count":44,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":78,"forks":11,"open_issues":78,"watchers":44,"default_branch":"master"}},"base":{"label":"embox:master","ref":"master","sha":"e3739c3e589b59cf551f58ff516a2e55de41476f","user":{"login":"embox","id":9039916,"avatar_url":"https://avatars.githubusercontent.com/u/9039916?v=3","gravatar_id":"","url":"https://api.github.com/users/embox","html_url":"https://github.com/embox","followers_url":"https://api.github.com/users/embox/followers","following_url":"https://api.github.com/users/embox/following{/other_user}","gists_url":"https://api.github.com/users/embox/gists{/gist_id}","starred_url":"https://api.github.com/users/embox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/embox/subscriptions","organizations_url":"https://api.github.com/users/embox/orgs","repos_url":"https://api.github.com/users/embox/repos","events_url":"https://api.github.com/users/embox/events{/privacy}","received_events_url":"https://api.github.com/users/embox/received_events","type":"Organization","site_admin":false},"repo":{"id":33078138,"name":"embox","full_name":"embox/embox","owner":{"login":"embox","id":9039916,"avatar_url":"https://avatars.githubusercontent.com/u/9039916?v=3","gravatar_id":"","url":"https://api.github.com/users/embox","html_url":"https://github.com/embox","followers_url":"https://api.github.com/users/embox/followers","following_url":"https://api.github.com/users/embox/following{/other_user}","gists_url":"https://api.github.com/users/embox/gists{/gist_id}","starred_url":"https://api.github.com/users/embox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/embox/subscriptions","organizations_url":"https://api.github.com/users/embox/orgs","repos_url":"https://api.github.com/users/embox/repos","events_url":"https://api.github.com/users/embox/events{/privacy}","received_events_url":"https://api.github.com/users/embox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/embox/embox","description":"The OS Kernel","fork":false,"url":"https://api.github.com/repos/embox/embox","forks_url":"https://api.github.com/repos/embox/embox/forks","keys_url":"https://api.github.com/repos/embox/embox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/embox/embox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/embox/embox/teams","hooks_url":"https://api.github.com/repos/embox/embox/hooks","issue_events_url":"https://api.github.com/repos/embox/embox/issues/events{/number}","events_url":"https://api.github.com/repos/embox/embox/events","assignees_url":"https://api.github.com/repos/embox/embox/assignees{/user}","branches_url":"https://api.github.com/repos/embox/embox/branches{/branch}","tags_url":"https://api.github.com/repos/embox/embox/tags","blobs_url":"https://api.github.com/repos/embox/embox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/embox/embox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/embox/embox/git/refs{/sha}","trees_url":"https://api.github.com/repos/embox/embox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/embox/embox/statuses/{sha}","languages_url":"https://api.github.com/repos/embox/embox/languages","stargazers_url":"https://api.github.com/repos/embox/embox/stargazers","contributors_url":"https://api.github.com/repos/embox/embox/contributors","subscribers_url":"https://api.github.com/repos/embox/embox/subscribers","subscription_url":"https://api.github.com/repos/embox/embox/subscription","commits_url":"https://api.github.com/repos/embox/embox/commits{/sha}","git_commits_url":"https://api.github.com/repos/embox/embox/git/commits{/sha}","comments_url":"https://api.github.com/repos/embox/embox/comments{/number}","issue_comment_url":"https://api.github.com/repos/embox/embox/issues/comments{/number}","contents_url":"https://api.github.com/repos/embox/embox/contents/{+path}","compare_url":"https://api.github.com/repos/embox/embox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/embox/embox/merges","archive_url":"https://api.github.com/repos/embox/embox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/embox/embox/downloads","issues_url":"https://api.github.com/repos/embox/embox/issues{/number}","pulls_url":"https://api.github.com/repos/embox/embox/pulls{/number}","milestones_url":"https://api.github.com/repos/embox/embox/milestones{/number}","notifications_url":"https://api.github.com/repos/embox/embox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/embox/embox/labels{/name}","releases_url":"https://api.github.com/repos/embox/embox/releases{/id}","created_at":"2015-03-29T15:27:48Z","updated_at":"2015-05-28T21:43:36Z","pushed_at":"2015-05-29T15:09:56Z","git_url":"git://github.com/embox/embox.git","ssh_url":"git@github.com:embox/embox.git","clone_url":"https://github.com/embox/embox.git","svn_url":"https://github.com/embox/embox","homepage":"","size":32108,"stargazers_count":44,"watchers_count":44,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":78,"forks":11,"open_issues":78,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/embox/embox/pulls/762"},"html":{"href":"https://github.com/embox/embox/pull/762"},"issue":{"href":"https://api.github.com/repos/embox/embox/issues/762"},"comments":{"href":"https://api.github.com/repos/embox/embox/issues/762/comments"},"review_comments":{"href":"https://api.github.com/repos/embox/embox/pulls/762/comments"},"review_comment":{"href":"https://api.github.com/repos/embox/embox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/embox/embox/pulls/762/commits"},"statuses":{"href":"https://api.github.com/repos/embox/embox/statuses/2c5112e4178a54fe5e9fb9d0190419f570d8f757"}}}}