{"action":"created","comment":{"url":"https://api.github.com/repos/guardian/facia-tool/pulls/comments/44256544","id":44256544,"diff_hunk":"@@ -42,8 +45,8 @@ trait PanDomainAuthActions extends AuthActions with Results {\n \n   override lazy val domain: String = Configuration.faciatool.pandomainDomain\n   override lazy val system: String = Configuration.faciatool.pandomainService\n+  override def awsCredentialsProvider  = new AWSCredentialsProviderChain(\n+    new STSAssumeRoleSessionCredentialsProvider(Configuration.faciatool.pandomainRoleArn, \"workflow\")","path":"facia-tool/app/auth/PanDomainAuthActions.scala","position":26,"original_position":26,"commit_id":"5a776e411250a4ca985053e9a4d2762570efd2a0","original_commit_id":"5a776e411250a4ca985053e9a4d2762570efd2a0","user":{"login":"piuccio","id":680284,"avatar_url":"https://avatars.githubusercontent.com/u/680284?v=3","gravatar_id":"","url":"https://api.github.com/users/piuccio","html_url":"https://github.com/piuccio","followers_url":"https://api.github.com/users/piuccio/followers","following_url":"https://api.github.com/users/piuccio/following{/other_user}","gists_url":"https://api.github.com/users/piuccio/gists{/gist_id}","starred_url":"https://api.github.com/users/piuccio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piuccio/subscriptions","organizations_url":"https://api.github.com/users/piuccio/orgs","repos_url":"https://api.github.com/users/piuccio/repos","events_url":"https://api.github.com/users/piuccio/events{/privacy}","received_events_url":"https://api.github.com/users/piuccio/received_events","type":"User","site_admin":false},"body":"this file probably conflicts with master, once resolved, I think `workflow` should be renamed as `fronts`.","created_at":"2015-11-09T09:51:41Z","updated_at":"2015-11-09T09:51:41Z","html_url":"https://github.com/guardian/facia-tool/pull/57#discussion_r44256544","pull_request_url":"https://api.github.com/repos/guardian/facia-tool/pulls/57","_links":{"self":{"href":"https://api.github.com/repos/guardian/facia-tool/pulls/comments/44256544"},"html":{"href":"https://github.com/guardian/facia-tool/pull/57#discussion_r44256544"},"pull_request":{"href":"https://api.github.com/repos/guardian/facia-tool/pulls/57"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/facia-tool/pulls/57","id":49983088,"html_url":"https://github.com/guardian/facia-tool/pull/57","diff_url":"https://github.com/guardian/facia-tool/pull/57.diff","patch_url":"https://github.com/guardian/facia-tool/pull/57.patch","issue_url":"https://api.github.com/repos/guardian/facia-tool/issues/57","number":57,"state":"open","locked":false,"title":"Use sts assume role to access panda bucket","user":{"login":"lindseydew","id":1202622,"avatar_url":"https://avatars.githubusercontent.com/u/1202622?v=3","gravatar_id":"","url":"https://api.github.com/users/lindseydew","html_url":"https://github.com/lindseydew","followers_url":"https://api.github.com/users/lindseydew/followers","following_url":"https://api.github.com/users/lindseydew/following{/other_user}","gists_url":"https://api.github.com/users/lindseydew/gists{/gist_id}","starred_url":"https://api.github.com/users/lindseydew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lindseydew/subscriptions","organizations_url":"https://api.github.com/users/lindseydew/orgs","repos_url":"https://api.github.com/users/lindseydew/repos","events_url":"https://api.github.com/users/lindseydew/events{/privacy}","received_events_url":"https://api.github.com/users/lindseydew/received_events","type":"User","site_admin":false},"body":"Following the retro action this makes the fronts tool access the panda bucket using assume role, so we can deprecate the specific bucket policy.\r\n\r\ncc @piuccio @jamespamplin @sihil ","created_at":"2015-11-06T17:45:00Z","updated_at":"2015-11-09T09:51:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guardian/facia-tool/pulls/57/commits","review_comments_url":"https://api.github.com/repos/guardian/facia-tool/pulls/57/comments","review_comment_url":"https://api.github.com/repos/guardian/facia-tool/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/facia-tool/issues/57/comments","statuses_url":"https://api.github.com/repos/guardian/facia-tool/statuses/5a776e411250a4ca985053e9a4d2762570efd2a0","head":{"label":"guardian:ld-add-sts-assume-role","ref":"ld-add-sts-assume-role","sha":"5a776e411250a4ca985053e9a4d2762570efd2a0","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":40353770,"name":"facia-tool","full_name":"guardian/facia-tool","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/facia-tool","description":"Guardian front pages editor","fork":false,"url":"https://api.github.com/repos/guardian/facia-tool","forks_url":"https://api.github.com/repos/guardian/facia-tool/forks","keys_url":"https://api.github.com/repos/guardian/facia-tool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/facia-tool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/facia-tool/teams","hooks_url":"https://api.github.com/repos/guardian/facia-tool/hooks","issue_events_url":"https://api.github.com/repos/guardian/facia-tool/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/facia-tool/events","assignees_url":"https://api.github.com/repos/guardian/facia-tool/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/facia-tool/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/facia-tool/tags","blobs_url":"https://api.github.com/repos/guardian/facia-tool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/facia-tool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/facia-tool/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/facia-tool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/facia-tool/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/facia-tool/languages","stargazers_url":"https://api.github.com/repos/guardian/facia-tool/stargazers","contributors_url":"https://api.github.com/repos/guardian/facia-tool/contributors","subscribers_url":"https://api.github.com/repos/guardian/facia-tool/subscribers","subscription_url":"https://api.github.com/repos/guardian/facia-tool/subscription","commits_url":"https://api.github.com/repos/guardian/facia-tool/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/facia-tool/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/facia-tool/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/facia-tool/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/facia-tool/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/facia-tool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/facia-tool/merges","archive_url":"https://api.github.com/repos/guardian/facia-tool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/facia-tool/downloads","issues_url":"https://api.github.com/repos/guardian/facia-tool/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/facia-tool/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/facia-tool/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/facia-tool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/facia-tool/labels{/name}","releases_url":"https://api.github.com/repos/guardian/facia-tool/releases{/id}","created_at":"2015-08-07T09:54:57Z","updated_at":"2015-10-19T10:50:15Z","pushed_at":"2015-11-06T18:29:47Z","git_url":"git://github.com/guardian/facia-tool.git","ssh_url":"git@github.com:guardian/facia-tool.git","clone_url":"https://github.com/guardian/facia-tool.git","svn_url":"https://github.com/guardian/facia-tool","homepage":null,"size":361972,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":1,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"3df94d2418e36e162fe0850a8aa45509b96215b0","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":40353770,"name":"facia-tool","full_name":"guardian/facia-tool","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/facia-tool","description":"Guardian front pages editor","fork":false,"url":"https://api.github.com/repos/guardian/facia-tool","forks_url":"https://api.github.com/repos/guardian/facia-tool/forks","keys_url":"https://api.github.com/repos/guardian/facia-tool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/facia-tool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/facia-tool/teams","hooks_url":"https://api.github.com/repos/guardian/facia-tool/hooks","issue_events_url":"https://api.github.com/repos/guardian/facia-tool/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/facia-tool/events","assignees_url":"https://api.github.com/repos/guardian/facia-tool/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/facia-tool/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/facia-tool/tags","blobs_url":"https://api.github.com/repos/guardian/facia-tool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/facia-tool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/facia-tool/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/facia-tool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/facia-tool/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/facia-tool/languages","stargazers_url":"https://api.github.com/repos/guardian/facia-tool/stargazers","contributors_url":"https://api.github.com/repos/guardian/facia-tool/contributors","subscribers_url":"https://api.github.com/repos/guardian/facia-tool/subscribers","subscription_url":"https://api.github.com/repos/guardian/facia-tool/subscription","commits_url":"https://api.github.com/repos/guardian/facia-tool/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/facia-tool/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/facia-tool/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/facia-tool/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/facia-tool/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/facia-tool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/facia-tool/merges","archive_url":"https://api.github.com/repos/guardian/facia-tool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/facia-tool/downloads","issues_url":"https://api.github.com/repos/guardian/facia-tool/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/facia-tool/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/facia-tool/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/facia-tool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/facia-tool/labels{/name}","releases_url":"https://api.github.com/repos/guardian/facia-tool/releases{/id}","created_at":"2015-08-07T09:54:57Z","updated_at":"2015-10-19T10:50:15Z","pushed_at":"2015-11-06T18:29:47Z","git_url":"git://github.com/guardian/facia-tool.git","ssh_url":"git@github.com:guardian/facia-tool.git","clone_url":"https://github.com/guardian/facia-tool.git","svn_url":"https://github.com/guardian/facia-tool","homepage":null,"size":361972,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/facia-tool/pulls/57"},"html":{"href":"https://github.com/guardian/facia-tool/pull/57"},"issue":{"href":"https://api.github.com/repos/guardian/facia-tool/issues/57"},"comments":{"href":"https://api.github.com/repos/guardian/facia-tool/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/facia-tool/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/facia-tool/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/facia-tool/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/facia-tool/statuses/5a776e411250a4ca985053e9a4d2762570efd2a0"}}}}