{"action":"created","comment":{"url":"https://api.github.com/repos/sympy/sympy/pulls/comments/32886564","id":32886564,"diff_hunk":"@@ -32,7 +32,7 @@ assumptions about objects in expr. Valid values include:\n     * Q.integer(x) & Q.positive(x)\n     * etc.\n \n-Q is a class in sympy.assumptions holding known predicates.\n+Q is an instance of QClass in sympy.assumptions.ask holding known predicates.","path":"doc/src/modules/assumptions/index.rst","position":5,"original_position":5,"commit_id":"e8554a5c9f245b456cee76d09f517ab739cd48c1","original_commit_id":"e8554a5c9f245b456cee76d09f517ab739cd48c1","user":{"login":"toolforger","id":915906,"avatar_url":"https://avatars.githubusercontent.com/u/915906?v=3","gravatar_id":"","url":"https://api.github.com/users/toolforger","html_url":"https://github.com/toolforger","followers_url":"https://api.github.com/users/toolforger/followers","following_url":"https://api.github.com/users/toolforger/following{/other_user}","gists_url":"https://api.github.com/users/toolforger/gists{/gist_id}","starred_url":"https://api.github.com/users/toolforger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toolforger/subscriptions","organizations_url":"https://api.github.com/users/toolforger/orgs","repos_url":"https://api.github.com/users/toolforger/repos","events_url":"https://api.github.com/users/toolforger/events{/privacy}","received_events_url":"https://api.github.com/users/toolforger/received_events","type":"User","site_admin":false},"body":"I don't know what `QClass` does, so I can't recommend a name. It should reflect what an object of that class is good for, so `FooClass` is almost always a bad name, that's all I know.\r\n`Keys` is often too generic. Unless objects of that type are really just arbitrary keys and nothing else, that is.\r\nBTW I suspect that users aren't supposed to instantiate objects of class `Q`; if that is correct, it should be documented as `Q is a singleton object`. Also, if users aren't supposed to import it from `sympy.assumptions` but from `sympy`, the reference to the package should be removed; this is user-facing documentation, and what's where is an implementation detail (and we do reorganize packages after all).","created_at":"2015-06-20T18:06:37Z","updated_at":"2015-06-20T18:06:37Z","html_url":"https://github.com/sympy/sympy/pull/9475#discussion_r32886564","pull_request_url":"https://api.github.com/repos/sympy/sympy/pulls/9475","_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments/32886564"},"html":{"href":"https://github.com/sympy/sympy/pull/9475#discussion_r32886564"},"pull_request":{"href":"https://api.github.com/repos/sympy/sympy/pulls/9475"}}},"pull_request":{"url":"https://api.github.com/repos/sympy/sympy/pulls/9475","id":37021509,"html_url":"https://github.com/sympy/sympy/pull/9475","diff_url":"https://github.com/sympy/sympy/pull/9475.diff","patch_url":"https://github.com/sympy/sympy/pull/9475.patch","issue_url":"https://api.github.com/repos/sympy/sympy/issues/9475","number":9475,"state":"open","locked":false,"title":"Documenting new assumptions","user":{"login":"debugger22","id":2821646,"avatar_url":"https://avatars.githubusercontent.com/u/2821646?v=3","gravatar_id":"","url":"https://api.github.com/users/debugger22","html_url":"https://github.com/debugger22","followers_url":"https://api.github.com/users/debugger22/followers","following_url":"https://api.github.com/users/debugger22/following{/other_user}","gists_url":"https://api.github.com/users/debugger22/gists{/gist_id}","starred_url":"https://api.github.com/users/debugger22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/debugger22/subscriptions","organizations_url":"https://api.github.com/users/debugger22/orgs","repos_url":"https://api.github.com/users/debugger22/repos","events_url":"https://api.github.com/users/debugger22/events{/privacy}","received_events_url":"https://api.github.com/users/debugger22/received_events","type":"User","site_admin":false},"body":"I've changed the way predicates are documented here https://github.com/sympy/sympy/pull/2538. Changing the predicates to `@classproperty` has broken a lot of things, I'm looking into that.\r\n\r\nMost of the documentations are taken from https://github.com/sympy/sympy/pull/2538 and `core/assumptions.py`.","created_at":"2015-06-05T11:07:52Z","updated_at":"2015-06-20T18:06:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5b51af90f1251e226cb3fe932a8451d707a4674","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sympy/sympy/pulls/9475/commits","review_comments_url":"https://api.github.com/repos/sympy/sympy/pulls/9475/comments","review_comment_url":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sympy/sympy/issues/9475/comments","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/e8554a5c9f245b456cee76d09f517ab739cd48c1","head":{"label":"debugger22:doc-new-assump","ref":"doc-new-assump","sha":"e8554a5c9f245b456cee76d09f517ab739cd48c1","user":{"login":"debugger22","id":2821646,"avatar_url":"https://avatars.githubusercontent.com/u/2821646?v=3","gravatar_id":"","url":"https://api.github.com/users/debugger22","html_url":"https://github.com/debugger22","followers_url":"https://api.github.com/users/debugger22/followers","following_url":"https://api.github.com/users/debugger22/following{/other_user}","gists_url":"https://api.github.com/users/debugger22/gists{/gist_id}","starred_url":"https://api.github.com/users/debugger22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/debugger22/subscriptions","organizations_url":"https://api.github.com/users/debugger22/orgs","repos_url":"https://api.github.com/users/debugger22/repos","events_url":"https://api.github.com/users/debugger22/events{/privacy}","received_events_url":"https://api.github.com/users/debugger22/received_events","type":"User","site_admin":false},"repo":{"id":17359802,"name":"sympy","full_name":"debugger22/sympy","owner":{"login":"debugger22","id":2821646,"avatar_url":"https://avatars.githubusercontent.com/u/2821646?v=3","gravatar_id":"","url":"https://api.github.com/users/debugger22","html_url":"https://github.com/debugger22","followers_url":"https://api.github.com/users/debugger22/followers","following_url":"https://api.github.com/users/debugger22/following{/other_user}","gists_url":"https://api.github.com/users/debugger22/gists{/gist_id}","starred_url":"https://api.github.com/users/debugger22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/debugger22/subscriptions","organizations_url":"https://api.github.com/users/debugger22/orgs","repos_url":"https://api.github.com/users/debugger22/repos","events_url":"https://api.github.com/users/debugger22/events{/privacy}","received_events_url":"https://api.github.com/users/debugger22/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/debugger22/sympy","description":"A computer algebra system written in pure Python","fork":true,"url":"https://api.github.com/repos/debugger22/sympy","forks_url":"https://api.github.com/repos/debugger22/sympy/forks","keys_url":"https://api.github.com/repos/debugger22/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/debugger22/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/debugger22/sympy/teams","hooks_url":"https://api.github.com/repos/debugger22/sympy/hooks","issue_events_url":"https://api.github.com/repos/debugger22/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/debugger22/sympy/events","assignees_url":"https://api.github.com/repos/debugger22/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/debugger22/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/debugger22/sympy/tags","blobs_url":"https://api.github.com/repos/debugger22/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/debugger22/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/debugger22/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/debugger22/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/debugger22/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/debugger22/sympy/languages","stargazers_url":"https://api.github.com/repos/debugger22/sympy/stargazers","contributors_url":"https://api.github.com/repos/debugger22/sympy/contributors","subscribers_url":"https://api.github.com/repos/debugger22/sympy/subscribers","subscription_url":"https://api.github.com/repos/debugger22/sympy/subscription","commits_url":"https://api.github.com/repos/debugger22/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/debugger22/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/debugger22/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/debugger22/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/debugger22/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/debugger22/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/debugger22/sympy/merges","archive_url":"https://api.github.com/repos/debugger22/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/debugger22/sympy/downloads","issues_url":"https://api.github.com/repos/debugger22/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/debugger22/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/debugger22/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/debugger22/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/debugger22/sympy/labels{/name}","releases_url":"https://api.github.com/repos/debugger22/sympy/releases{/id}","created_at":"2014-03-03T08:33:45Z","updated_at":"2015-04-23T02:12:12Z","pushed_at":"2015-06-14T16:36:54Z","git_url":"git://github.com/debugger22/sympy.git","ssh_url":"git@github.com:debugger22/sympy.git","clone_url":"https://github.com/debugger22/sympy.git","svn_url":"https://github.com/debugger22/sympy","homepage":"http://sympy.org/","size":71711,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sympy:master","ref":"master","sha":"6f3ef90a6951af7ca7b2742e5f5ea735d06bea43","user":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=3","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"repo":{"id":640534,"name":"sympy","full_name":"sympy/sympy","owner":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=3","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sympy/sympy","description":"A computer algebra system written in pure Python","fork":false,"url":"https://api.github.com/repos/sympy/sympy","forks_url":"https://api.github.com/repos/sympy/sympy/forks","keys_url":"https://api.github.com/repos/sympy/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sympy/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sympy/sympy/teams","hooks_url":"https://api.github.com/repos/sympy/sympy/hooks","issue_events_url":"https://api.github.com/repos/sympy/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/sympy/sympy/events","assignees_url":"https://api.github.com/repos/sympy/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/sympy/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/sympy/sympy/tags","blobs_url":"https://api.github.com/repos/sympy/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sympy/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sympy/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sympy/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/sympy/sympy/languages","stargazers_url":"https://api.github.com/repos/sympy/sympy/stargazers","contributors_url":"https://api.github.com/repos/sympy/sympy/contributors","subscribers_url":"https://api.github.com/repos/sympy/sympy/subscribers","subscription_url":"https://api.github.com/repos/sympy/sympy/subscription","commits_url":"https://api.github.com/repos/sympy/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sympy/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sympy/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sympy/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sympy/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/sympy/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sympy/sympy/merges","archive_url":"https://api.github.com/repos/sympy/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sympy/sympy/downloads","issues_url":"https://api.github.com/repos/sympy/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/sympy/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/sympy/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/sympy/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sympy/sympy/labels{/name}","releases_url":"https://api.github.com/repos/sympy/sympy/releases{/id}","created_at":"2010-04-30T20:37:14Z","updated_at":"2015-06-20T10:00:38Z","pushed_at":"2015-06-20T16:13:42Z","git_url":"git://github.com/sympy/sympy.git","ssh_url":"git@github.com:sympy/sympy.git","clone_url":"https://github.com/sympy/sympy.git","svn_url":"https://github.com/sympy/sympy","homepage":"http://sympy.org/","size":149075,"stargazers_count":2189,"watchers_count":2189,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1082,"mirror_url":null,"open_issues_count":1918,"forks":1082,"open_issues":1918,"watchers":2189,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/9475"},"html":{"href":"https://github.com/sympy/sympy/pull/9475"},"issue":{"href":"https://api.github.com/repos/sympy/sympy/issues/9475"},"comments":{"href":"https://api.github.com/repos/sympy/sympy/issues/9475/comments"},"review_comments":{"href":"https://api.github.com/repos/sympy/sympy/pulls/9475/comments"},"review_comment":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sympy/sympy/pulls/9475/commits"},"statuses":{"href":"https://api.github.com/repos/sympy/sympy/statuses/e8554a5c9f245b456cee76d09f517ab739cd48c1"}}}}