{"action":"opened","number":108,"pull_request":{"url":"https://api.github.com/repos/domchristie/to-markdown/pulls/108","id":44283690,"html_url":"https://github.com/domchristie/to-markdown/pull/108","diff_url":"https://github.com/domchristie/to-markdown/pull/108.diff","patch_url":"https://github.com/domchristie/to-markdown/pull/108.patch","issue_url":"https://api.github.com/repos/domchristie/to-markdown/issues/108","number":108,"state":"open","locked":false,"title":"Fixes for IE8 (when run alongside an ES5-shim) and IE9 (HTML with doctype)","user":{"login":"apjones6","id":2539219,"avatar_url":"https://avatars.githubusercontent.com/u/2539219?v=3","gravatar_id":"","url":"https://api.github.com/users/apjones6","html_url":"https://github.com/apjones6","followers_url":"https://api.github.com/users/apjones6/followers","following_url":"https://api.github.com/users/apjones6/following{/other_user}","gists_url":"https://api.github.com/users/apjones6/gists{/gist_id}","starred_url":"https://api.github.com/users/apjones6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apjones6/subscriptions","organizations_url":"https://api.github.com/users/apjones6/orgs","repos_url":"https://api.github.com/users/apjones6/repos","events_url":"https://api.github.com/users/apjones6/events{/privacy}","received_events_url":"https://api.github.com/users/apjones6/received_events","type":"User","site_admin":false},"body":"The purpose of this pull request is primarily to fix an issue using this library in IE8. We had a fork with our changes, but I'm hoping it was worth tidying and looking to include into the main development branch (see: https://github.com/Reffyy/to-markdown/commit/f8f47c3599a96543bd91324ee27cdc34c6bfdeb5).\r\n\r\nRather than adding a dependency of the es5-shim library we use, I have instead looked to resolve issues we encountered while running alongside one. This way clients can include that dependency if IE8 compatibility is valuable, without any significant overhead to other clients (I hope). I have added to the readme a note about using es5-shim >= 3.0.2 (I tested various versions).\r\n\r\nWhile implementing this fix I noticed an issue entering complete HTML (including doctype) in IE9 (emulated in IE11). It's not a use case I use, but I assume it's going to be in use by clients. I have attempted to also work around this issue, though there may well be improvements that can be done here.\r\n\r\nAll of my changes are at points where the code was previously failing (according to my testing), so I hope on that basis there should be no fallout to existing working functionality. Please correct me if not. The tests continue to pass as far as I can tell, though I cannot run them in IE8. I tried adding the shim with mixed success; I'm unfamiliar with QUnit.","created_at":"2015-09-05T14:17:54Z","updated_at":"2015-09-05T14:17:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/domchristie/to-markdown/pulls/108/commits","review_comments_url":"https://api.github.com/repos/domchristie/to-markdown/pulls/108/comments","review_comment_url":"https://api.github.com/repos/domchristie/to-markdown/pulls/comments{/number}","comments_url":"https://api.github.com/repos/domchristie/to-markdown/issues/108/comments","statuses_url":"https://api.github.com/repos/domchristie/to-markdown/statuses/3ac4c8a3090f5403cdf771d19dbe15f67e348284","head":{"label":"apjones6:feature/ie8","ref":"feature/ie8","sha":"3ac4c8a3090f5403cdf771d19dbe15f67e348284","user":{"login":"apjones6","id":2539219,"avatar_url":"https://avatars.githubusercontent.com/u/2539219?v=3","gravatar_id":"","url":"https://api.github.com/users/apjones6","html_url":"https://github.com/apjones6","followers_url":"https://api.github.com/users/apjones6/followers","following_url":"https://api.github.com/users/apjones6/following{/other_user}","gists_url":"https://api.github.com/users/apjones6/gists{/gist_id}","starred_url":"https://api.github.com/users/apjones6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apjones6/subscriptions","organizations_url":"https://api.github.com/users/apjones6/orgs","repos_url":"https://api.github.com/users/apjones6/repos","events_url":"https://api.github.com/users/apjones6/events{/privacy}","received_events_url":"https://api.github.com/users/apjones6/received_events","type":"User","site_admin":false},"repo":{"id":41955382,"name":"to-markdown","full_name":"apjones6/to-markdown","owner":{"login":"apjones6","id":2539219,"avatar_url":"https://avatars.githubusercontent.com/u/2539219?v=3","gravatar_id":"","url":"https://api.github.com/users/apjones6","html_url":"https://github.com/apjones6","followers_url":"https://api.github.com/users/apjones6/followers","following_url":"https://api.github.com/users/apjones6/following{/other_user}","gists_url":"https://api.github.com/users/apjones6/gists{/gist_id}","starred_url":"https://api.github.com/users/apjones6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apjones6/subscriptions","organizations_url":"https://api.github.com/users/apjones6/orgs","repos_url":"https://api.github.com/users/apjones6/repos","events_url":"https://api.github.com/users/apjones6/events{/privacy}","received_events_url":"https://api.github.com/users/apjones6/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/apjones6/to-markdown","description":"An HTML to Markdown converter written in JavaScript","fork":true,"url":"https://api.github.com/repos/apjones6/to-markdown","forks_url":"https://api.github.com/repos/apjones6/to-markdown/forks","keys_url":"https://api.github.com/repos/apjones6/to-markdown/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apjones6/to-markdown/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apjones6/to-markdown/teams","hooks_url":"https://api.github.com/repos/apjones6/to-markdown/hooks","issue_events_url":"https://api.github.com/repos/apjones6/to-markdown/issues/events{/number}","events_url":"https://api.github.com/repos/apjones6/to-markdown/events","assignees_url":"https://api.github.com/repos/apjones6/to-markdown/assignees{/user}","branches_url":"https://api.github.com/repos/apjones6/to-markdown/branches{/branch}","tags_url":"https://api.github.com/repos/apjones6/to-markdown/tags","blobs_url":"https://api.github.com/repos/apjones6/to-markdown/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apjones6/to-markdown/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apjones6/to-markdown/git/refs{/sha}","trees_url":"https://api.github.com/repos/apjones6/to-markdown/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apjones6/to-markdown/statuses/{sha}","languages_url":"https://api.github.com/repos/apjones6/to-markdown/languages","stargazers_url":"https://api.github.com/repos/apjones6/to-markdown/stargazers","contributors_url":"https://api.github.com/repos/apjones6/to-markdown/contributors","subscribers_url":"https://api.github.com/repos/apjones6/to-markdown/subscribers","subscription_url":"https://api.github.com/repos/apjones6/to-markdown/subscription","commits_url":"https://api.github.com/repos/apjones6/to-markdown/commits{/sha}","git_commits_url":"https://api.github.com/repos/apjones6/to-markdown/git/commits{/sha}","comments_url":"https://api.github.com/repos/apjones6/to-markdown/comments{/number}","issue_comment_url":"https://api.github.com/repos/apjones6/to-markdown/issues/comments{/number}","contents_url":"https://api.github.com/repos/apjones6/to-markdown/contents/{+path}","compare_url":"https://api.github.com/repos/apjones6/to-markdown/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apjones6/to-markdown/merges","archive_url":"https://api.github.com/repos/apjones6/to-markdown/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apjones6/to-markdown/downloads","issues_url":"https://api.github.com/repos/apjones6/to-markdown/issues{/number}","pulls_url":"https://api.github.com/repos/apjones6/to-markdown/pulls{/number}","milestones_url":"https://api.github.com/repos/apjones6/to-markdown/milestones{/number}","notifications_url":"https://api.github.com/repos/apjones6/to-markdown/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apjones6/to-markdown/labels{/name}","releases_url":"https://api.github.com/repos/apjones6/to-markdown/releases{/id}","created_at":"2015-09-05T09:14:14Z","updated_at":"2015-09-05T09:14:14Z","pushed_at":"2015-09-05T13:56:24Z","git_url":"git://github.com/apjones6/to-markdown.git","ssh_url":"git@github.com:apjones6/to-markdown.git","clone_url":"https://github.com/apjones6/to-markdown.git","svn_url":"https://github.com/apjones6/to-markdown","homepage":"http://domchristie.github.io/to-markdown","size":1075,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"domchristie:master","ref":"master","sha":"50d28867bb05019ca20ec2803460f058dd0d950a","user":{"login":"domchristie","id":111734,"avatar_url":"https://avatars.githubusercontent.com/u/111734?v=3","gravatar_id":"","url":"https://api.github.com/users/domchristie","html_url":"https://github.com/domchristie","followers_url":"https://api.github.com/users/domchristie/followers","following_url":"https://api.github.com/users/domchristie/following{/other_user}","gists_url":"https://api.github.com/users/domchristie/gists{/gist_id}","starred_url":"https://api.github.com/users/domchristie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domchristie/subscriptions","organizations_url":"https://api.github.com/users/domchristie/orgs","repos_url":"https://api.github.com/users/domchristie/repos","events_url":"https://api.github.com/users/domchristie/events{/privacy}","received_events_url":"https://api.github.com/users/domchristie/received_events","type":"User","site_admin":false},"repo":{"id":2630230,"name":"to-markdown","full_name":"domchristie/to-markdown","owner":{"login":"domchristie","id":111734,"avatar_url":"https://avatars.githubusercontent.com/u/111734?v=3","gravatar_id":"","url":"https://api.github.com/users/domchristie","html_url":"https://github.com/domchristie","followers_url":"https://api.github.com/users/domchristie/followers","following_url":"https://api.github.com/users/domchristie/following{/other_user}","gists_url":"https://api.github.com/users/domchristie/gists{/gist_id}","starred_url":"https://api.github.com/users/domchristie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domchristie/subscriptions","organizations_url":"https://api.github.com/users/domchristie/orgs","repos_url":"https://api.github.com/users/domchristie/repos","events_url":"https://api.github.com/users/domchristie/events{/privacy}","received_events_url":"https://api.github.com/users/domchristie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/domchristie/to-markdown","description":"An HTML to Markdown converter written in JavaScript","fork":false,"url":"https://api.github.com/repos/domchristie/to-markdown","forks_url":"https://api.github.com/repos/domchristie/to-markdown/forks","keys_url":"https://api.github.com/repos/domchristie/to-markdown/keys{/key_id}","collaborators_url":"https://api.github.com/repos/domchristie/to-markdown/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/domchristie/to-markdown/teams","hooks_url":"https://api.github.com/repos/domchristie/to-markdown/hooks","issue_events_url":"https://api.github.com/repos/domchristie/to-markdown/issues/events{/number}","events_url":"https://api.github.com/repos/domchristie/to-markdown/events","assignees_url":"https://api.github.com/repos/domchristie/to-markdown/assignees{/user}","branches_url":"https://api.github.com/repos/domchristie/to-markdown/branches{/branch}","tags_url":"https://api.github.com/repos/domchristie/to-markdown/tags","blobs_url":"https://api.github.com/repos/domchristie/to-markdown/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/domchristie/to-markdown/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/domchristie/to-markdown/git/refs{/sha}","trees_url":"https://api.github.com/repos/domchristie/to-markdown/git/trees{/sha}","statuses_url":"https://api.github.com/repos/domchristie/to-markdown/statuses/{sha}","languages_url":"https://api.github.com/repos/domchristie/to-markdown/languages","stargazers_url":"https://api.github.com/repos/domchristie/to-markdown/stargazers","contributors_url":"https://api.github.com/repos/domchristie/to-markdown/contributors","subscribers_url":"https://api.github.com/repos/domchristie/to-markdown/subscribers","subscription_url":"https://api.github.com/repos/domchristie/to-markdown/subscription","commits_url":"https://api.github.com/repos/domchristie/to-markdown/commits{/sha}","git_commits_url":"https://api.github.com/repos/domchristie/to-markdown/git/commits{/sha}","comments_url":"https://api.github.com/repos/domchristie/to-markdown/comments{/number}","issue_comment_url":"https://api.github.com/repos/domchristie/to-markdown/issues/comments{/number}","contents_url":"https://api.github.com/repos/domchristie/to-markdown/contents/{+path}","compare_url":"https://api.github.com/repos/domchristie/to-markdown/compare/{base}...{head}","merges_url":"https://api.github.com/repos/domchristie/to-markdown/merges","archive_url":"https://api.github.com/repos/domchristie/to-markdown/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/domchristie/to-markdown/downloads","issues_url":"https://api.github.com/repos/domchristie/to-markdown/issues{/number}","pulls_url":"https://api.github.com/repos/domchristie/to-markdown/pulls{/number}","milestones_url":"https://api.github.com/repos/domchristie/to-markdown/milestones{/number}","notifications_url":"https://api.github.com/repos/domchristie/to-markdown/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/domchristie/to-markdown/labels{/name}","releases_url":"https://api.github.com/repos/domchristie/to-markdown/releases{/id}","created_at":"2011-10-23T10:35:39Z","updated_at":"2015-09-05T13:19:11Z","pushed_at":"2015-08-18T15:43:54Z","git_url":"git://github.com/domchristie/to-markdown.git","ssh_url":"git@github.com:domchristie/to-markdown.git","clone_url":"https://github.com/domchristie/to-markdown.git","svn_url":"https://github.com/domchristie/to-markdown","homepage":"http://domchristie.github.io/to-markdown","size":2027,"stargazers_count":1200,"watchers_count":1200,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":202,"mirror_url":null,"open_issues_count":13,"forks":202,"open_issues":13,"watchers":1200,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/domchristie/to-markdown/pulls/108"},"html":{"href":"https://github.com/domchristie/to-markdown/pull/108"},"issue":{"href":"https://api.github.com/repos/domchristie/to-markdown/issues/108"},"comments":{"href":"https://api.github.com/repos/domchristie/to-markdown/issues/108/comments"},"review_comments":{"href":"https://api.github.com/repos/domchristie/to-markdown/pulls/108/comments"},"review_comment":{"href":"https://api.github.com/repos/domchristie/to-markdown/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/domchristie/to-markdown/pulls/108/commits"},"statuses":{"href":"https://api.github.com/repos/domchristie/to-markdown/statuses/3ac4c8a3090f5403cdf771d19dbe15f67e348284"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":48,"deletions":4,"changed_files":3}}