{"action":"created","comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/34956797","id":34956797,"diff_hunk":"@@ -63,22 +64,20 @@ static mutex_t rerr_mutex;\n \n struct netaddr na_mcast;\n kernel_pid_t aodvv2_if_id;\n-ipv6_addr_t aodvv2_prefix;\n+ng_ipv6_addr_t aodvv2_prefix;\n int aodvv2_prefix_len;\n \n-void aodv_init(void)\n+void aodv_init(kernel_pid_t interface)\n {\n     AODV_DEBUG(\"%s()\\n\", __func__);\n \n-    /* init this thread's IPC msg queue (TODO: do I need to do this?) */\n+    /* init this thread's IPC msg queue */\n     msg_t msgq[RCV_MSG_Q_SIZE];\n     msg_init_queue(msgq, sizeof msgq);\n \n-    /* TODO: set & handle prefix and prefix_len properly (consider AODVV2_RIOT_PREFIXLEN!) */\n-    aodvv2_prefix_len = 0;\n-    /* TODO: set if_id properly (as param of aodv_init) */\n-    aodvv2_if_id = 0;\n-    net_if_set_src_address_mode(aodvv2_if_id, NET_IF_TRANS_ADDR_M_SHORT);\n+    aodvv2_prefix_len = sizeof(ng_ipv6_addr_t);","path":"sys/net/routing/aodvv2/aodv.c","position":52,"original_position":52,"commit_id":"461bfb4761b60fb20c4072d7ed14cc06e29aa7a9","original_commit_id":"461bfb4761b60fb20c4072d7ed14cc06e29aa7a9","user":{"login":"authmillenon","id":675644,"avatar_url":"https://avatars.githubusercontent.com/u/675644?v=3","gravatar_id":"","url":"https://api.github.com/users/authmillenon","html_url":"https://github.com/authmillenon","followers_url":"https://api.github.com/users/authmillenon/followers","following_url":"https://api.github.com/users/authmillenon/following{/other_user}","gists_url":"https://api.github.com/users/authmillenon/gists{/gist_id}","starred_url":"https://api.github.com/users/authmillenon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/authmillenon/subscriptions","organizations_url":"https://api.github.com/users/authmillenon/orgs","repos_url":"https://api.github.com/users/authmillenon/repos","events_url":"https://api.github.com/users/authmillenon/events{/privacy}","received_events_url":"https://api.github.com/users/authmillenon/received_events","type":"User","site_admin":false},"body":"You sure about that? Usually the prefix length is 64.","created_at":"2015-07-19T09:55:01Z","updated_at":"2015-07-19T09:55:01Z","html_url":"https://github.com/RIOT-OS/RIOT/pull/3445#discussion_r34956797","pull_request_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3445","_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/34956797"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/3445#discussion_r34956797"},"pull_request":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3445"}}},"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3445","id":40304795,"html_url":"https://github.com/RIOT-OS/RIOT/pull/3445","diff_url":"https://github.com/RIOT-OS/RIOT/pull/3445.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/3445.patch","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/3445","number":3445,"state":"open","locked":false,"title":"aodvv2: port to new network stack","user":{"login":"Lotterleben","id":581552,"avatar_url":"https://avatars.githubusercontent.com/u/581552?v=3","gravatar_id":"","url":"https://api.github.com/users/Lotterleben","html_url":"https://github.com/Lotterleben","followers_url":"https://api.github.com/users/Lotterleben/followers","following_url":"https://api.github.com/users/Lotterleben/following{/other_user}","gists_url":"https://api.github.com/users/Lotterleben/gists{/gist_id}","starred_url":"https://api.github.com/users/Lotterleben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lotterleben/subscriptions","organizations_url":"https://api.github.com/users/Lotterleben/orgs","repos_url":"https://api.github.com/users/Lotterleben/repos","events_url":"https://api.github.com/users/Lotterleben/events{/privacy}","received_events_url":"https://api.github.com/users/Lotterleben/received_events","type":"User","site_admin":false},"body":"This PR makes AODVv2 ng ready. :) Also, AODVv2 must now be configured to serve a specific interface. ","created_at":"2015-07-19T07:56:31Z","updated_at":"2015-07-19T09:55:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc7847188c5a56d74434dbb8c2ea932679214f4b","assignee":{"login":"authmillenon","id":675644,"avatar_url":"https://avatars.githubusercontent.com/u/675644?v=3","gravatar_id":"","url":"https://api.github.com/users/authmillenon","html_url":"https://github.com/authmillenon","followers_url":"https://api.github.com/users/authmillenon/followers","following_url":"https://api.github.com/users/authmillenon/following{/other_user}","gists_url":"https://api.github.com/users/authmillenon/gists{/gist_id}","starred_url":"https://api.github.com/users/authmillenon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/authmillenon/subscriptions","organizations_url":"https://api.github.com/users/authmillenon/orgs","repos_url":"https://api.github.com/users/authmillenon/repos","events_url":"https://api.github.com/users/authmillenon/events{/privacy}","received_events_url":"https://api.github.com/users/authmillenon/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3445/commits","review_comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3445/comments","review_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/3445/comments","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/461bfb4761b60fb20c4072d7ed14cc06e29aa7a9","head":{"label":"Lotterleben:aodvv2_ng_port","ref":"aodvv2_ng_port","sha":"461bfb4761b60fb20c4072d7ed14cc06e29aa7a9","user":{"login":"Lotterleben","id":581552,"avatar_url":"https://avatars.githubusercontent.com/u/581552?v=3","gravatar_id":"","url":"https://api.github.com/users/Lotterleben","html_url":"https://github.com/Lotterleben","followers_url":"https://api.github.com/users/Lotterleben/followers","following_url":"https://api.github.com/users/Lotterleben/following{/other_user}","gists_url":"https://api.github.com/users/Lotterleben/gists{/gist_id}","starred_url":"https://api.github.com/users/Lotterleben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lotterleben/subscriptions","organizations_url":"https://api.github.com/users/Lotterleben/orgs","repos_url":"https://api.github.com/users/Lotterleben/repos","events_url":"https://api.github.com/users/Lotterleben/events{/privacy}","received_events_url":"https://api.github.com/users/Lotterleben/received_events","type":"User","site_admin":false},"repo":{"id":16456544,"name":"RIOT","full_name":"Lotterleben/RIOT","owner":{"login":"Lotterleben","id":581552,"avatar_url":"https://avatars.githubusercontent.com/u/581552?v=3","gravatar_id":"","url":"https://api.github.com/users/Lotterleben","html_url":"https://github.com/Lotterleben","followers_url":"https://api.github.com/users/Lotterleben/followers","following_url":"https://api.github.com/users/Lotterleben/following{/other_user}","gists_url":"https://api.github.com/users/Lotterleben/gists{/gist_id}","starred_url":"https://api.github.com/users/Lotterleben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lotterleben/subscriptions","organizations_url":"https://api.github.com/users/Lotterleben/orgs","repos_url":"https://api.github.com/users/Lotterleben/repos","events_url":"https://api.github.com/users/Lotterleben/events{/privacy}","received_events_url":"https://api.github.com/users/Lotterleben/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Lotterleben/RIOT","description":"RIOT -  The friendly OS for IoT","fork":true,"url":"https://api.github.com/repos/Lotterleben/RIOT","forks_url":"https://api.github.com/repos/Lotterleben/RIOT/forks","keys_url":"https://api.github.com/repos/Lotterleben/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lotterleben/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lotterleben/RIOT/teams","hooks_url":"https://api.github.com/repos/Lotterleben/RIOT/hooks","issue_events_url":"https://api.github.com/repos/Lotterleben/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/Lotterleben/RIOT/events","assignees_url":"https://api.github.com/repos/Lotterleben/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/Lotterleben/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/Lotterleben/RIOT/tags","blobs_url":"https://api.github.com/repos/Lotterleben/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lotterleben/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lotterleben/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lotterleben/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lotterleben/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/Lotterleben/RIOT/languages","stargazers_url":"https://api.github.com/repos/Lotterleben/RIOT/stargazers","contributors_url":"https://api.github.com/repos/Lotterleben/RIOT/contributors","subscribers_url":"https://api.github.com/repos/Lotterleben/RIOT/subscribers","subscription_url":"https://api.github.com/repos/Lotterleben/RIOT/subscription","commits_url":"https://api.github.com/repos/Lotterleben/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lotterleben/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lotterleben/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lotterleben/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lotterleben/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/Lotterleben/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lotterleben/RIOT/merges","archive_url":"https://api.github.com/repos/Lotterleben/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lotterleben/RIOT/downloads","issues_url":"https://api.github.com/repos/Lotterleben/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/Lotterleben/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/Lotterleben/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/Lotterleben/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lotterleben/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/Lotterleben/RIOT/releases{/id}","created_at":"2014-02-02T15:06:09Z","updated_at":"2015-06-22T20:26:14Z","pushed_at":"2015-07-19T08:37:32Z","git_url":"git://github.com/Lotterleben/RIOT.git","ssh_url":"git@github.com:Lotterleben/RIOT.git","clone_url":"https://github.com/Lotterleben/RIOT.git","svn_url":"https://github.com/Lotterleben/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":20092,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"RIOT-OS:master","ref":"master","sha":"06da6939331a1de96e10230087e7ade7a14790ed","user":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars.githubusercontent.com/u/3079480?v=3","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"repo":{"id":7370241,"name":"RIOT","full_name":"RIOT-OS/RIOT","owner":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars.githubusercontent.com/u/3079480?v=3","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RIOT-OS/RIOT","description":"RIOT -  The friendly OS for IoT","fork":false,"url":"https://api.github.com/repos/RIOT-OS/RIOT","forks_url":"https://api.github.com/repos/RIOT-OS/RIOT/forks","keys_url":"https://api.github.com/repos/RIOT-OS/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIOT-OS/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIOT-OS/RIOT/teams","hooks_url":"https://api.github.com/repos/RIOT-OS/RIOT/hooks","issue_events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/events","assignees_url":"https://api.github.com/repos/RIOT-OS/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/RIOT-OS/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/tags","blobs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/RIOT-OS/RIOT/languages","stargazers_url":"https://api.github.com/repos/RIOT-OS/RIOT/stargazers","contributors_url":"https://api.github.com/repos/RIOT-OS/RIOT/contributors","subscribers_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscribers","subscription_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscription","commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/RIOT-OS/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/RIOT-OS/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIOT-OS/RIOT/merges","archive_url":"https://api.github.com/repos/RIOT-OS/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIOT-OS/RIOT/downloads","issues_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/RIOT-OS/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/RIOT-OS/RIOT/releases{/id}","created_at":"2012-12-29T20:38:40Z","updated_at":"2015-07-16T08:07:39Z","pushed_at":"2015-07-19T09:25:41Z","git_url":"git://github.com/RIOT-OS/RIOT.git","ssh_url":"git@github.com:RIOT-OS/RIOT.git","clone_url":"https://github.com/RIOT-OS/RIOT.git","svn_url":"https://github.com/RIOT-OS/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":121258,"stargazers_count":439,"watchers_count":439,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":340,"mirror_url":null,"open_issues_count":384,"forks":340,"open_issues":384,"watchers":439,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3445"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/3445"},"issue":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/3445"},"comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/3445/comments"},"review_comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3445/comments"},"review_comment":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3445/commits"},"statuses":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/461bfb4761b60fb20c4072d7ed14cc06e29aa7a9"}}}}