{"action":"created","comment":{"url":"https://api.github.com/repos/onefinestay/nameko/pulls/comments/29416199","id":29416199,"diff_hunk":"@@ -93,6 +93,7 @@ def start(self):\n     def stop(self):\n         self._is_accepting = False\n         self._gt.kill()\n+        self._sock.close()","path":"nameko/web/server.py","position":4,"original_position":4,"commit_id":"fffac4b3712276cd6dcd7d16f06ae946970e9f96","original_commit_id":"fffac4b3712276cd6dcd7d16f06ae946970e9f96","user":{"login":"davidszotten","id":412005,"avatar_url":"https://avatars.githubusercontent.com/u/412005?v=3","gravatar_id":"","url":"https://api.github.com/users/davidszotten","html_url":"https://github.com/davidszotten","followers_url":"https://api.github.com/users/davidszotten/followers","following_url":"https://api.github.com/users/davidszotten/following{/other_user}","gists_url":"https://api.github.com/users/davidszotten/gists{/gist_id}","starred_url":"https://api.github.com/users/davidszotten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidszotten/subscriptions","organizations_url":"https://api.github.com/users/davidszotten/orgs","repos_url":"https://api.github.com/users/davidszotten/repos","events_url":"https://api.github.com/users/davidszotten/events{/privacy}","received_events_url":"https://api.github.com/users/davidszotten/received_events","type":"User","site_admin":false},"body":"this is the listening socket, right? so calls in-flight can still finish and send responses?","created_at":"2015-04-30T09:48:30Z","updated_at":"2015-04-30T09:48:30Z","html_url":"https://github.com/onefinestay/nameko/pull/250#discussion_r29416199","pull_request_url":"https://api.github.com/repos/onefinestay/nameko/pulls/250","_links":{"self":{"href":"https://api.github.com/repos/onefinestay/nameko/pulls/comments/29416199"},"html":{"href":"https://github.com/onefinestay/nameko/pull/250#discussion_r29416199"},"pull_request":{"href":"https://api.github.com/repos/onefinestay/nameko/pulls/250"}}},"pull_request":{"url":"https://api.github.com/repos/onefinestay/nameko/pulls/250","id":34369835,"html_url":"https://github.com/onefinestay/nameko/pull/250","diff_url":"https://github.com/onefinestay/nameko/pull/250.diff","patch_url":"https://github.com/onefinestay/nameko/pull/250.patch","issue_url":"https://api.github.com/repos/onefinestay/nameko/issues/250","number":250,"state":"open","locked":false,"title":"Fix examples","user":{"login":"mattbennett","id":107611,"avatar_url":"https://avatars.githubusercontent.com/u/107611?v=3","gravatar_id":"","url":"https://api.github.com/users/mattbennett","html_url":"https://github.com/mattbennett","followers_url":"https://api.github.com/users/mattbennett/followers","following_url":"https://api.github.com/users/mattbennett/following{/other_user}","gists_url":"https://api.github.com/users/mattbennett/gists{/gist_id}","starred_url":"https://api.github.com/users/mattbennett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattbennett/subscriptions","organizations_url":"https://api.github.com/users/mattbennett/orgs","repos_url":"https://api.github.com/users/mattbennett/repos","events_url":"https://api.github.com/users/mattbennett/events{/privacy}","received_events_url":"https://api.github.com/users/mattbennett/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-04-29T14:42:39Z","updated_at":"2015-04-30T09:48:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8876b3e88a4b0b5a230814af40447a62195ace84","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/onefinestay/nameko/pulls/250/commits","review_comments_url":"https://api.github.com/repos/onefinestay/nameko/pulls/250/comments","review_comment_url":"https://api.github.com/repos/onefinestay/nameko/pulls/comments{/number}","comments_url":"https://api.github.com/repos/onefinestay/nameko/issues/250/comments","statuses_url":"https://api.github.com/repos/onefinestay/nameko/statuses/fffac4b3712276cd6dcd7d16f06ae946970e9f96","head":{"label":"onefinestay:fix-examples","ref":"fix-examples","sha":"fffac4b3712276cd6dcd7d16f06ae946970e9f96","user":{"login":"onefinestay","id":634153,"avatar_url":"https://avatars.githubusercontent.com/u/634153?v=3","gravatar_id":"","url":"https://api.github.com/users/onefinestay","html_url":"https://github.com/onefinestay","followers_url":"https://api.github.com/users/onefinestay/followers","following_url":"https://api.github.com/users/onefinestay/following{/other_user}","gists_url":"https://api.github.com/users/onefinestay/gists{/gist_id}","starred_url":"https://api.github.com/users/onefinestay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onefinestay/subscriptions","organizations_url":"https://api.github.com/users/onefinestay/orgs","repos_url":"https://api.github.com/users/onefinestay/repos","events_url":"https://api.github.com/users/onefinestay/events{/privacy}","received_events_url":"https://api.github.com/users/onefinestay/received_events","type":"Organization","site_admin":false},"repo":{"id":8431589,"name":"nameko","full_name":"onefinestay/nameko","owner":{"login":"onefinestay","id":634153,"avatar_url":"https://avatars.githubusercontent.com/u/634153?v=3","gravatar_id":"","url":"https://api.github.com/users/onefinestay","html_url":"https://github.com/onefinestay","followers_url":"https://api.github.com/users/onefinestay/followers","following_url":"https://api.github.com/users/onefinestay/following{/other_user}","gists_url":"https://api.github.com/users/onefinestay/gists{/gist_id}","starred_url":"https://api.github.com/users/onefinestay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onefinestay/subscriptions","organizations_url":"https://api.github.com/users/onefinestay/orgs","repos_url":"https://api.github.com/users/onefinestay/repos","events_url":"https://api.github.com/users/onefinestay/events{/privacy}","received_events_url":"https://api.github.com/users/onefinestay/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/onefinestay/nameko","description":"Python framework for building microservices","fork":false,"url":"https://api.github.com/repos/onefinestay/nameko","forks_url":"https://api.github.com/repos/onefinestay/nameko/forks","keys_url":"https://api.github.com/repos/onefinestay/nameko/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onefinestay/nameko/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onefinestay/nameko/teams","hooks_url":"https://api.github.com/repos/onefinestay/nameko/hooks","issue_events_url":"https://api.github.com/repos/onefinestay/nameko/issues/events{/number}","events_url":"https://api.github.com/repos/onefinestay/nameko/events","assignees_url":"https://api.github.com/repos/onefinestay/nameko/assignees{/user}","branches_url":"https://api.github.com/repos/onefinestay/nameko/branches{/branch}","tags_url":"https://api.github.com/repos/onefinestay/nameko/tags","blobs_url":"https://api.github.com/repos/onefinestay/nameko/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onefinestay/nameko/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onefinestay/nameko/git/refs{/sha}","trees_url":"https://api.github.com/repos/onefinestay/nameko/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onefinestay/nameko/statuses/{sha}","languages_url":"https://api.github.com/repos/onefinestay/nameko/languages","stargazers_url":"https://api.github.com/repos/onefinestay/nameko/stargazers","contributors_url":"https://api.github.com/repos/onefinestay/nameko/contributors","subscribers_url":"https://api.github.com/repos/onefinestay/nameko/subscribers","subscription_url":"https://api.github.com/repos/onefinestay/nameko/subscription","commits_url":"https://api.github.com/repos/onefinestay/nameko/commits{/sha}","git_commits_url":"https://api.github.com/repos/onefinestay/nameko/git/commits{/sha}","comments_url":"https://api.github.com/repos/onefinestay/nameko/comments{/number}","issue_comment_url":"https://api.github.com/repos/onefinestay/nameko/issues/comments{/number}","contents_url":"https://api.github.com/repos/onefinestay/nameko/contents/{+path}","compare_url":"https://api.github.com/repos/onefinestay/nameko/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onefinestay/nameko/merges","archive_url":"https://api.github.com/repos/onefinestay/nameko/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onefinestay/nameko/downloads","issues_url":"https://api.github.com/repos/onefinestay/nameko/issues{/number}","pulls_url":"https://api.github.com/repos/onefinestay/nameko/pulls{/number}","milestones_url":"https://api.github.com/repos/onefinestay/nameko/milestones{/number}","notifications_url":"https://api.github.com/repos/onefinestay/nameko/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onefinestay/nameko/labels{/name}","releases_url":"https://api.github.com/repos/onefinestay/nameko/releases{/id}","created_at":"2013-02-26T11:59:08Z","updated_at":"2015-04-30T08:40:38Z","pushed_at":"2015-04-29T14:42:41Z","git_url":"git://github.com/onefinestay/nameko.git","ssh_url":"git@github.com:onefinestay/nameko.git","clone_url":"https://github.com/onefinestay/nameko.git","svn_url":"https://github.com/onefinestay/nameko","homepage":"https://nameko.readthedocs.org","size":6043,"stargazers_count":433,"watchers_count":433,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":22,"forks":21,"open_issues":22,"watchers":433,"default_branch":"master"}},"base":{"label":"onefinestay:master","ref":"master","sha":"62157c82fa884f3ebe4952005307f10e8e14ae6f","user":{"login":"onefinestay","id":634153,"avatar_url":"https://avatars.githubusercontent.com/u/634153?v=3","gravatar_id":"","url":"https://api.github.com/users/onefinestay","html_url":"https://github.com/onefinestay","followers_url":"https://api.github.com/users/onefinestay/followers","following_url":"https://api.github.com/users/onefinestay/following{/other_user}","gists_url":"https://api.github.com/users/onefinestay/gists{/gist_id}","starred_url":"https://api.github.com/users/onefinestay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onefinestay/subscriptions","organizations_url":"https://api.github.com/users/onefinestay/orgs","repos_url":"https://api.github.com/users/onefinestay/repos","events_url":"https://api.github.com/users/onefinestay/events{/privacy}","received_events_url":"https://api.github.com/users/onefinestay/received_events","type":"Organization","site_admin":false},"repo":{"id":8431589,"name":"nameko","full_name":"onefinestay/nameko","owner":{"login":"onefinestay","id":634153,"avatar_url":"https://avatars.githubusercontent.com/u/634153?v=3","gravatar_id":"","url":"https://api.github.com/users/onefinestay","html_url":"https://github.com/onefinestay","followers_url":"https://api.github.com/users/onefinestay/followers","following_url":"https://api.github.com/users/onefinestay/following{/other_user}","gists_url":"https://api.github.com/users/onefinestay/gists{/gist_id}","starred_url":"https://api.github.com/users/onefinestay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onefinestay/subscriptions","organizations_url":"https://api.github.com/users/onefinestay/orgs","repos_url":"https://api.github.com/users/onefinestay/repos","events_url":"https://api.github.com/users/onefinestay/events{/privacy}","received_events_url":"https://api.github.com/users/onefinestay/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/onefinestay/nameko","description":"Python framework for building microservices","fork":false,"url":"https://api.github.com/repos/onefinestay/nameko","forks_url":"https://api.github.com/repos/onefinestay/nameko/forks","keys_url":"https://api.github.com/repos/onefinestay/nameko/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onefinestay/nameko/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onefinestay/nameko/teams","hooks_url":"https://api.github.com/repos/onefinestay/nameko/hooks","issue_events_url":"https://api.github.com/repos/onefinestay/nameko/issues/events{/number}","events_url":"https://api.github.com/repos/onefinestay/nameko/events","assignees_url":"https://api.github.com/repos/onefinestay/nameko/assignees{/user}","branches_url":"https://api.github.com/repos/onefinestay/nameko/branches{/branch}","tags_url":"https://api.github.com/repos/onefinestay/nameko/tags","blobs_url":"https://api.github.com/repos/onefinestay/nameko/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onefinestay/nameko/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onefinestay/nameko/git/refs{/sha}","trees_url":"https://api.github.com/repos/onefinestay/nameko/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onefinestay/nameko/statuses/{sha}","languages_url":"https://api.github.com/repos/onefinestay/nameko/languages","stargazers_url":"https://api.github.com/repos/onefinestay/nameko/stargazers","contributors_url":"https://api.github.com/repos/onefinestay/nameko/contributors","subscribers_url":"https://api.github.com/repos/onefinestay/nameko/subscribers","subscription_url":"https://api.github.com/repos/onefinestay/nameko/subscription","commits_url":"https://api.github.com/repos/onefinestay/nameko/commits{/sha}","git_commits_url":"https://api.github.com/repos/onefinestay/nameko/git/commits{/sha}","comments_url":"https://api.github.com/repos/onefinestay/nameko/comments{/number}","issue_comment_url":"https://api.github.com/repos/onefinestay/nameko/issues/comments{/number}","contents_url":"https://api.github.com/repos/onefinestay/nameko/contents/{+path}","compare_url":"https://api.github.com/repos/onefinestay/nameko/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onefinestay/nameko/merges","archive_url":"https://api.github.com/repos/onefinestay/nameko/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onefinestay/nameko/downloads","issues_url":"https://api.github.com/repos/onefinestay/nameko/issues{/number}","pulls_url":"https://api.github.com/repos/onefinestay/nameko/pulls{/number}","milestones_url":"https://api.github.com/repos/onefinestay/nameko/milestones{/number}","notifications_url":"https://api.github.com/repos/onefinestay/nameko/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onefinestay/nameko/labels{/name}","releases_url":"https://api.github.com/repos/onefinestay/nameko/releases{/id}","created_at":"2013-02-26T11:59:08Z","updated_at":"2015-04-30T08:40:38Z","pushed_at":"2015-04-29T14:42:41Z","git_url":"git://github.com/onefinestay/nameko.git","ssh_url":"git@github.com:onefinestay/nameko.git","clone_url":"https://github.com/onefinestay/nameko.git","svn_url":"https://github.com/onefinestay/nameko","homepage":"https://nameko.readthedocs.org","size":6043,"stargazers_count":433,"watchers_count":433,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":22,"forks":21,"open_issues":22,"watchers":433,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/onefinestay/nameko/pulls/250"},"html":{"href":"https://github.com/onefinestay/nameko/pull/250"},"issue":{"href":"https://api.github.com/repos/onefinestay/nameko/issues/250"},"comments":{"href":"https://api.github.com/repos/onefinestay/nameko/issues/250/comments"},"review_comments":{"href":"https://api.github.com/repos/onefinestay/nameko/pulls/250/comments"},"review_comment":{"href":"https://api.github.com/repos/onefinestay/nameko/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/onefinestay/nameko/pulls/250/commits"},"statuses":{"href":"https://api.github.com/repos/onefinestay/nameko/statuses/fffac4b3712276cd6dcd7d16f06ae946970e9f96"}}}}