{"action":"created","comment":{"url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/pulls/comments/37659438","id":37659438,"diff_hunk":"@@ -0,0 +1,97 @@\n+﻿using System;\n+using System.Collections.Generic;\n+using System.IO;\n+using System.IO.Pipes;\n+using System.Linq;\n+using System.Text;\n+using System.Threading.Tasks;\n+\n+namespace xunit.runner.worker\n+{\n+    internal abstract class Connection : IDisposable\n+    {\n+        private bool _closed;\n+\n+        internal abstract Stream Stream { get; }\n+\n+        internal abstract void WaitForClientConnect();\n+        internal abstract void WaitForClientDone();\n+\n+        protected virtual void DisposeCore()\n+        {\n+\n+        }\n+\n+        private void Dispose()","path":"xunit.runner.worker/Connection.cs","position":25,"original_position":25,"commit_id":"0eaf76ca81df8fcabd45d015fe0aee463617df6f","original_commit_id":"0eaf76ca81df8fcabd45d015fe0aee463617df6f","user":{"login":"jaredpar","id":146967,"avatar_url":"https://avatars.githubusercontent.com/u/146967?v=3","gravatar_id":"","url":"https://api.github.com/users/jaredpar","html_url":"https://github.com/jaredpar","followers_url":"https://api.github.com/users/jaredpar/followers","following_url":"https://api.github.com/users/jaredpar/following{/other_user}","gists_url":"https://api.github.com/users/jaredpar/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredpar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredpar/subscriptions","organizations_url":"https://api.github.com/users/jaredpar/orgs","repos_url":"https://api.github.com/users/jaredpar/repos","events_url":"https://api.github.com/users/jaredpar/events{/privacy}","received_events_url":"https://api.github.com/users/jaredpar/received_events","type":"User","site_admin":false},"body":"Sure I can make that public. ","created_at":"2015-08-21T17:52:14Z","updated_at":"2015-08-21T17:52:14Z","html_url":"https://github.com/Pilchie/xunit.runner.wpf/pull/19#discussion_r37659438","pull_request_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/pulls/comments/37659438"},"html":{"href":"https://github.com/Pilchie/xunit.runner.wpf/pull/19#discussion_r37659438"},"pull_request":{"href":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/pulls/19","id":42868947,"html_url":"https://github.com/Pilchie/xunit.runner.wpf/pull/19","diff_url":"https://github.com/Pilchie/xunit.runner.wpf/pull/19.diff","patch_url":"https://github.com/Pilchie/xunit.runner.wpf/pull/19.patch","issue_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/issues/19","number":19,"state":"open","locked":false,"title":"Move discover and execution to a remote process","user":{"login":"jaredpar","id":146967,"avatar_url":"https://avatars.githubusercontent.com/u/146967?v=3","gravatar_id":"","url":"https://api.github.com/users/jaredpar","html_url":"https://github.com/jaredpar","followers_url":"https://api.github.com/users/jaredpar/followers","following_url":"https://api.github.com/users/jaredpar/following{/other_user}","gists_url":"https://api.github.com/users/jaredpar/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredpar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredpar/subscriptions","organizations_url":"https://api.github.com/users/jaredpar/orgs","repos_url":"https://api.github.com/users/jaredpar/repos","events_url":"https://api.github.com/users/jaredpar/events{/privacy}","received_events_url":"https://api.github.com/users/jaredpar/received_events","type":"User","site_admin":false},"body":"This moves the discover and execution actions into a remote process (communicating over named pipes).  I've been able to multi-run several applications using this latest code.\r\n\r\nThere is still a lot of work to do here:\r\n\r\n- Discovery should be made non-blocking in the same way run is \r\n- Discovery should be cancellable\r\n- The named pipe strategy should be reviewed with someone more familiar with named pipes\r\n\r\nOverall though this works and puts us closer to a state where we can begin using this.  \r\n\r\ncloses #4 ","created_at":"2015-08-19T21:55:06Z","updated_at":"2015-08-21T17:52:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8440dfb980f1ab318ec31fcf90e5be3c2093494","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/pulls/19/commits","review_comments_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/pulls/19/comments","review_comment_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/issues/19/comments","statuses_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/statuses/0eaf76ca81df8fcabd45d015fe0aee463617df6f","head":{"label":"Pilchie:remote","ref":"remote","sha":"0eaf76ca81df8fcabd45d015fe0aee463617df6f","user":{"login":"Pilchie","id":312835,"avatar_url":"https://avatars.githubusercontent.com/u/312835?v=3","gravatar_id":"","url":"https://api.github.com/users/Pilchie","html_url":"https://github.com/Pilchie","followers_url":"https://api.github.com/users/Pilchie/followers","following_url":"https://api.github.com/users/Pilchie/following{/other_user}","gists_url":"https://api.github.com/users/Pilchie/gists{/gist_id}","starred_url":"https://api.github.com/users/Pilchie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pilchie/subscriptions","organizations_url":"https://api.github.com/users/Pilchie/orgs","repos_url":"https://api.github.com/users/Pilchie/repos","events_url":"https://api.github.com/users/Pilchie/events{/privacy}","received_events_url":"https://api.github.com/users/Pilchie/received_events","type":"User","site_admin":false},"repo":{"id":40424774,"name":"xunit.runner.wpf","full_name":"Pilchie/xunit.runner.wpf","owner":{"login":"Pilchie","id":312835,"avatar_url":"https://avatars.githubusercontent.com/u/312835?v=3","gravatar_id":"","url":"https://api.github.com/users/Pilchie","html_url":"https://github.com/Pilchie","followers_url":"https://api.github.com/users/Pilchie/followers","following_url":"https://api.github.com/users/Pilchie/following{/other_user}","gists_url":"https://api.github.com/users/Pilchie/gists{/gist_id}","starred_url":"https://api.github.com/users/Pilchie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pilchie/subscriptions","organizations_url":"https://api.github.com/users/Pilchie/orgs","repos_url":"https://api.github.com/users/Pilchie/repos","events_url":"https://api.github.com/users/Pilchie/events{/privacy}","received_events_url":"https://api.github.com/users/Pilchie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Pilchie/xunit.runner.wpf","description":"XUnit Gui written in WPF","fork":false,"url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf","forks_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/forks","keys_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/teams","hooks_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/hooks","issue_events_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/issues/events{/number}","events_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/events","assignees_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/assignees{/user}","branches_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/branches{/branch}","tags_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/tags","blobs_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/git/refs{/sha}","trees_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/statuses/{sha}","languages_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/languages","stargazers_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/stargazers","contributors_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/contributors","subscribers_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/subscribers","subscription_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/subscription","commits_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/commits{/sha}","git_commits_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/git/commits{/sha}","comments_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/comments{/number}","issue_comment_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/issues/comments{/number}","contents_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/contents/{+path}","compare_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/merges","archive_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/downloads","issues_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/issues{/number}","pulls_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/pulls{/number}","milestones_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/milestones{/number}","notifications_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/labels{/name}","releases_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/releases{/id}","created_at":"2015-08-09T04:02:26Z","updated_at":"2015-08-09T04:02:41Z","pushed_at":"2015-08-20T22:54:18Z","git_url":"git://github.com/Pilchie/xunit.runner.wpf.git","ssh_url":"git@github.com:Pilchie/xunit.runner.wpf.git","clone_url":"https://github.com/Pilchie/xunit.runner.wpf.git","svn_url":"https://github.com/Pilchie/xunit.runner.wpf","homepage":null,"size":293,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":14,"forks":3,"open_issues":14,"watchers":0,"default_branch":"master"}},"base":{"label":"Pilchie:master","ref":"master","sha":"cd16b674bcf98bfe14e879a71a739a3cb2e7d1b2","user":{"login":"Pilchie","id":312835,"avatar_url":"https://avatars.githubusercontent.com/u/312835?v=3","gravatar_id":"","url":"https://api.github.com/users/Pilchie","html_url":"https://github.com/Pilchie","followers_url":"https://api.github.com/users/Pilchie/followers","following_url":"https://api.github.com/users/Pilchie/following{/other_user}","gists_url":"https://api.github.com/users/Pilchie/gists{/gist_id}","starred_url":"https://api.github.com/users/Pilchie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pilchie/subscriptions","organizations_url":"https://api.github.com/users/Pilchie/orgs","repos_url":"https://api.github.com/users/Pilchie/repos","events_url":"https://api.github.com/users/Pilchie/events{/privacy}","received_events_url":"https://api.github.com/users/Pilchie/received_events","type":"User","site_admin":false},"repo":{"id":40424774,"name":"xunit.runner.wpf","full_name":"Pilchie/xunit.runner.wpf","owner":{"login":"Pilchie","id":312835,"avatar_url":"https://avatars.githubusercontent.com/u/312835?v=3","gravatar_id":"","url":"https://api.github.com/users/Pilchie","html_url":"https://github.com/Pilchie","followers_url":"https://api.github.com/users/Pilchie/followers","following_url":"https://api.github.com/users/Pilchie/following{/other_user}","gists_url":"https://api.github.com/users/Pilchie/gists{/gist_id}","starred_url":"https://api.github.com/users/Pilchie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pilchie/subscriptions","organizations_url":"https://api.github.com/users/Pilchie/orgs","repos_url":"https://api.github.com/users/Pilchie/repos","events_url":"https://api.github.com/users/Pilchie/events{/privacy}","received_events_url":"https://api.github.com/users/Pilchie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Pilchie/xunit.runner.wpf","description":"XUnit Gui written in WPF","fork":false,"url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf","forks_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/forks","keys_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/teams","hooks_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/hooks","issue_events_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/issues/events{/number}","events_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/events","assignees_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/assignees{/user}","branches_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/branches{/branch}","tags_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/tags","blobs_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/git/refs{/sha}","trees_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/statuses/{sha}","languages_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/languages","stargazers_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/stargazers","contributors_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/contributors","subscribers_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/subscribers","subscription_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/subscription","commits_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/commits{/sha}","git_commits_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/git/commits{/sha}","comments_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/comments{/number}","issue_comment_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/issues/comments{/number}","contents_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/contents/{+path}","compare_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/merges","archive_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/downloads","issues_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/issues{/number}","pulls_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/pulls{/number}","milestones_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/milestones{/number}","notifications_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/labels{/name}","releases_url":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/releases{/id}","created_at":"2015-08-09T04:02:26Z","updated_at":"2015-08-09T04:02:41Z","pushed_at":"2015-08-20T22:54:18Z","git_url":"git://github.com/Pilchie/xunit.runner.wpf.git","ssh_url":"git@github.com:Pilchie/xunit.runner.wpf.git","clone_url":"https://github.com/Pilchie/xunit.runner.wpf.git","svn_url":"https://github.com/Pilchie/xunit.runner.wpf","homepage":null,"size":293,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":14,"forks":3,"open_issues":14,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/pulls/19"},"html":{"href":"https://github.com/Pilchie/xunit.runner.wpf/pull/19"},"issue":{"href":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/issues/19"},"comments":{"href":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/Pilchie/xunit.runner.wpf/statuses/0eaf76ca81df8fcabd45d015fe0aee463617df6f"}}}}