{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/pdf.js/issues/6672","labels_url":"https://api.github.com/repos/mozilla/pdf.js/issues/6672/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/pdf.js/issues/6672/comments","events_url":"https://api.github.com/repos/mozilla/pdf.js/issues/6672/events","html_url":"https://github.com/mozilla/pdf.js/pull/6672","id":118225432,"number":6672,"title":"Refactor annotation flags code","user":{"login":"timvandermeij","id":1993262,"avatar_url":"https://avatars.githubusercontent.com/u/1993262?v=3","gravatar_id":"","url":"https://api.github.com/users/timvandermeij","html_url":"https://github.com/timvandermeij","followers_url":"https://api.github.com/users/timvandermeij/followers","following_url":"https://api.github.com/users/timvandermeij/following{/other_user}","gists_url":"https://api.github.com/users/timvandermeij/gists{/gist_id}","starred_url":"https://api.github.com/users/timvandermeij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timvandermeij/subscriptions","organizations_url":"https://api.github.com/users/timvandermeij/orgs","repos_url":"https://api.github.com/users/timvandermeij/repos","events_url":"https://api.github.com/users/timvandermeij/events{/privacy}","received_events_url":"https://api.github.com/users/timvandermeij/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mozilla/pdf.js/labels/4-annotations","name":"4-annotations","color":"DDDDDD"}],"state":"open","locked":false,"assignee":{"login":"Snuffleupagus","id":2692120,"avatar_url":"https://avatars.githubusercontent.com/u/2692120?v=3","gravatar_id":"","url":"https://api.github.com/users/Snuffleupagus","html_url":"https://github.com/Snuffleupagus","followers_url":"https://api.github.com/users/Snuffleupagus/followers","following_url":"https://api.github.com/users/Snuffleupagus/following{/other_user}","gists_url":"https://api.github.com/users/Snuffleupagus/gists{/gist_id}","starred_url":"https://api.github.com/users/Snuffleupagus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Snuffleupagus/subscriptions","organizations_url":"https://api.github.com/users/Snuffleupagus/orgs","repos_url":"https://api.github.com/users/Snuffleupagus/repos","events_url":"https://api.github.com/users/Snuffleupagus/events{/privacy}","received_events_url":"https://api.github.com/users/Snuffleupagus/received_events","type":"User","site_admin":false},"milestone":null,"comments":7,"created_at":"2015-11-21T22:37:42Z","updated_at":"2015-11-22T00:25:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/pdf.js/pulls/6672","html_url":"https://github.com/mozilla/pdf.js/pull/6672","diff_url":"https://github.com/mozilla/pdf.js/pull/6672.diff","patch_url":"https://github.com/mozilla/pdf.js/pull/6672.patch"},"body":"This patch makes it possible to set and get all possible flags that the PDF specification defines. Even though we do not support all possible annotation types and not all possible annotation flags yet, this general framework makes it easy to access all flags for each annotation such that annotation type implementations can use this information.\r\n\r\nWe add constants for all possible annotation flags such that we do not need to hardcode the flags in the code anymore. The `isViewable()` and `isPrintable()` methods are now easier to read. Additionally, unit tests have been added to ensure correct behavior.\r\n\r\nThis is another part of #5218.\r\n\r\nI have tested this patch, both with displaying and with printing, with a corpus of 23 PDF files with different annotation types and annotation flags in them and observed no difference with the current master."},"comment":{"url":"https://api.github.com/repos/mozilla/pdf.js/issues/comments/158693925","html_url":"https://github.com/mozilla/pdf.js/pull/6672#issuecomment-158693925","issue_url":"https://api.github.com/repos/mozilla/pdf.js/issues/6672","id":158693925,"user":{"login":"pdfjsbot","id":1036361,"avatar_url":"https://avatars.githubusercontent.com/u/1036361?v=3","gravatar_id":"","url":"https://api.github.com/users/pdfjsbot","html_url":"https://github.com/pdfjsbot","followers_url":"https://api.github.com/users/pdfjsbot/followers","following_url":"https://api.github.com/users/pdfjsbot/following{/other_user}","gists_url":"https://api.github.com/users/pdfjsbot/gists{/gist_id}","starred_url":"https://api.github.com/users/pdfjsbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdfjsbot/subscriptions","organizations_url":"https://api.github.com/users/pdfjsbot/orgs","repos_url":"https://api.github.com/users/pdfjsbot/repos","events_url":"https://api.github.com/users/pdfjsbot/events{/privacy}","received_events_url":"https://api.github.com/users/pdfjsbot/received_events","type":"User","site_admin":false},"created_at":"2015-11-22T00:25:32Z","updated_at":"2015-11-22T00:25:32Z","body":"#### From: Bot.io (Linux)\n\n----\n\n# Received\n\nCommand **cmd_test** from @timvandermeij received. Current queue size: 0\n\nLive output at: http://107.21.233.14:8877/588c1e0133bbfa1/output.txt"}}