{"action":"created","issue":{"url":"https://api.github.com/repos/DFHack/dfhack/issues/758","labels_url":"https://api.github.com/repos/DFHack/dfhack/issues/758/labels{/name}","comments_url":"https://api.github.com/repos/DFHack/dfhack/issues/758/comments","events_url":"https://api.github.com/repos/DFHack/dfhack/issues/758/events","html_url":"https://github.com/DFHack/dfhack/pull/758","id":118537110,"number":758,"title":"Re-enable GCC 5 compilation for OSX and Linux; updated build-osx.sh script","user":{"login":"TheBloke","id":784313,"avatar_url":"https://avatars.githubusercontent.com/u/784313?v=3","gravatar_id":"","url":"https://api.github.com/users/TheBloke","html_url":"https://github.com/TheBloke","followers_url":"https://api.github.com/users/TheBloke/followers","following_url":"https://api.github.com/users/TheBloke/following{/other_user}","gists_url":"https://api.github.com/users/TheBloke/gists{/gist_id}","starred_url":"https://api.github.com/users/TheBloke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheBloke/subscriptions","organizations_url":"https://api.github.com/users/TheBloke/orgs","repos_url":"https://api.github.com/users/TheBloke/repos","events_url":"https://api.github.com/users/TheBloke/events{/privacy}","received_events_url":"https://api.github.com/users/TheBloke/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-24T06:00:33Z","updated_at":"2015-11-24T11:38:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/DFHack/dfhack/pulls/758","html_url":"https://github.com/DFHack/dfhack/pull/758","diff_url":"https://github.com/DFHack/dfhack/pull/758.diff","patch_url":"https://github.com/DFHack/dfhack/pull/758.patch"},"body":"Apologies that these are A) on Develop, and B) two unrelated commits in a single Pull.  I'm still having git issues - this time, it merged my local branches into origin/develop when I pushed, for no reason I can yet understand.\r\n\r\nCommit 1:\r\n\r\nRe-enable GCC 5 compilation for OSX and Linux, passing -D_GLIBCXX_USE_CXX11_ABI=0 to disable new C++11 name mangling and remain compatible with DF.\r\n\r\nCommit 2:\r\nOSX build script (build-osx.sh) - multiple improvements:\r\n  Can specify -gcc X to change GCC version from default of 4.5.\r\n  Can specify -par Y to give a -jY parallel build flag to make.\r\n  Various error checks: existence of executables, output dir, etc.\r\n  Improved Bash syntax, especially for Lua patching (now a valid .sh file).\r\n  Times the overall build time and outputs this to stdout.\r\n  If GCC version is not default, print reminder about installing libstdc++.\r\n"},"comment":{"url":"https://api.github.com/repos/DFHack/dfhack/issues/comments/159239629","html_url":"https://github.com/DFHack/dfhack/pull/758#issuecomment-159239629","issue_url":"https://api.github.com/repos/DFHack/dfhack/issues/758","id":159239629,"user":{"login":"lethosor","id":3719547,"avatar_url":"https://avatars.githubusercontent.com/u/3719547?v=3","gravatar_id":"","url":"https://api.github.com/users/lethosor","html_url":"https://github.com/lethosor","followers_url":"https://api.github.com/users/lethosor/followers","following_url":"https://api.github.com/users/lethosor/following{/other_user}","gists_url":"https://api.github.com/users/lethosor/gists{/gist_id}","starred_url":"https://api.github.com/users/lethosor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lethosor/subscriptions","organizations_url":"https://api.github.com/users/lethosor/orgs","repos_url":"https://api.github.com/users/lethosor/repos","events_url":"https://api.github.com/users/lethosor/events{/privacy}","received_events_url":"https://api.github.com/users/lethosor/received_events","type":"User","site_admin":false},"created_at":"2015-11-24T11:38:45Z","updated_at":"2015-11-24T11:38:45Z","body":"I think the lua patch is no longer necessary on 10.6 (check to see if there's a strnlen implementation in LuaTypes.cpp)."}}