{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react/issues/4323","labels_url":"https://api.github.com/repos/facebook/react/issues/4323/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react/issues/4323/comments","events_url":"https://api.github.com/repos/facebook/react/issues/4323/events","html_url":"https://github.com/facebook/react/issues/4323","id":94100600,"number":4323,"title":"Checksum inserted incorrectly for self-closing root tags","user":{"login":"zpao","id":8445,"avatar_url":"https://avatars.githubusercontent.com/u/8445?v=3","gravatar_id":"","url":"https://api.github.com/users/zpao","html_url":"https://github.com/zpao","followers_url":"https://api.github.com/users/zpao/followers","following_url":"https://api.github.com/users/zpao/following{/other_user}","gists_url":"https://api.github.com/users/zpao/gists{/gist_id}","starred_url":"https://api.github.com/users/zpao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zpao/subscriptions","organizations_url":"https://api.github.com/users/zpao/orgs","repos_url":"https://api.github.com/users/zpao/repos","events_url":"https://api.github.com/users/zpao/events{/privacy}","received_events_url":"https://api.github.com/users/zpao/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/react/labels/Component:%20DOM%20(general%20issues)","name":"Component: DOM (general issues)","color":"bfd4f2"},{"url":"https://api.github.com/repos/facebook/react/labels/good%20first%20bug","name":"good first bug","color":"009800"},{"url":"https://api.github.com/repos/facebook/react/labels/Type:%20Bug","name":"Type: Bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/facebook/react/milestones/13","html_url":"https://github.com/facebook/react/milestones/0.14","labels_url":"https://api.github.com/repos/facebook/react/milestones/13/labels","id":1035426,"number":13,"title":"0.14","description":null,"creator":{"login":"spicyj","id":6820,"avatar_url":"https://avatars.githubusercontent.com/u/6820?v=3","gravatar_id":"","url":"https://api.github.com/users/spicyj","html_url":"https://github.com/spicyj","followers_url":"https://api.github.com/users/spicyj/followers","following_url":"https://api.github.com/users/spicyj/following{/other_user}","gists_url":"https://api.github.com/users/spicyj/gists{/gist_id}","starred_url":"https://api.github.com/users/spicyj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spicyj/subscriptions","organizations_url":"https://api.github.com/users/spicyj/orgs","repos_url":"https://api.github.com/users/spicyj/repos","events_url":"https://api.github.com/users/spicyj/events{/privacy}","received_events_url":"https://api.github.com/users/spicyj/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":6,"state":"open","created_at":"2015-03-23T23:33:55Z","updated_at":"2015-07-09T17:04:54Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2015-07-09T16:55:35Z","updated_at":"2015-07-09T19:07:03Z","closed_at":null,"body":"This came up while diagnosing #4321 - https://github.com/facebook/react/issues/4321#issuecomment-120064258\r\n\r\nThis is because we just look for the closing `>` when adding the checksum.\r\n\r\n```\r\n> ReactDOM.renderToString(React.createElement('img'))\r\n'<img data-reactid=\".yxoueqje2o\"/ data-react-checksum=\"-951841932\">'\r\n> ReactDOM.renderToString(React.createElement('div', null, React.createElement('img')))\r\n'<div data-reactid=\".2d7dcluvuv4\" data-react-checksum=\"-890562330\"><img data-reactid=\".2d7dcluvuv4.0\"/></div>'\r\n```"},"comment":{"url":"https://api.github.com/repos/facebook/react/issues/comments/120110696","html_url":"https://github.com/facebook/react/issues/4323#issuecomment-120110696","issue_url":"https://api.github.com/repos/facebook/react/issues/4323","id":120110696,"user":{"login":"vramana","id":3112509,"avatar_url":"https://avatars.githubusercontent.com/u/3112509?v=3","gravatar_id":"","url":"https://api.github.com/users/vramana","html_url":"https://github.com/vramana","followers_url":"https://api.github.com/users/vramana/followers","following_url":"https://api.github.com/users/vramana/following{/other_user}","gists_url":"https://api.github.com/users/vramana/gists{/gist_id}","starred_url":"https://api.github.com/users/vramana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vramana/subscriptions","organizations_url":"https://api.github.com/users/vramana/orgs","repos_url":"https://api.github.com/users/vramana/repos","events_url":"https://api.github.com/users/vramana/events{/privacy}","received_events_url":"https://api.github.com/users/vramana/received_events","type":"User","site_admin":false},"created_at":"2015-07-09T19:07:03Z","updated_at":"2015-07-09T19:07:03Z","body":"@zpao Is checking the only index of char `<` is 0 in the markup sufficient to determine whether the tag is self closing tag? I can't think of any corner cases. If so changing the `addChecksumToMarkup` [here](https://github.com/facebook/react/blob/master/src/renderers/dom/server/ReactMarkupChecksum.js#L23) based on that should suffice right ?"}}