{"action":"created","issue":{"url":"https://api.github.com/repos/schmie/test/issues/43","labels_url":"https://api.github.com/repos/schmie/test/issues/43/labels{/name}","comments_url":"https://api.github.com/repos/schmie/test/issues/43/comments","events_url":"https://api.github.com/repos/schmie/test/issues/43/events","html_url":"https://github.com/schmie/test/issues/43","id":90430947,"number":43,"title":"Merge non-newtonian branch in","user":{"login":"schmie","id":6473158,"avatar_url":"https://avatars.githubusercontent.com/u/6473158?v=3","gravatar_id":"","url":"https://api.github.com/users/schmie","html_url":"https://github.com/schmie","followers_url":"https://api.github.com/users/schmie/followers","following_url":"https://api.github.com/users/schmie/following{/other_user}","gists_url":"https://api.github.com/users/schmie/gists{/gist_id}","starred_url":"https://api.github.com/users/schmie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmie/subscriptions","organizations_url":"https://api.github.com/users/schmie/orgs","repos_url":"https://api.github.com/users/schmie/repos","events_url":"https://api.github.com/users/schmie/events{/privacy}","received_events_url":"https://api.github.com/users/schmie/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/schmie/test/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/schmie/test/labels/P:%20major","name":"P: major","color":"f6f6f6"}],"state":"open","locked":false,"assignee":{"login":"schmie","id":6473158,"avatar_url":"https://avatars.githubusercontent.com/u/6473158?v=3","gravatar_id":"","url":"https://api.github.com/users/schmie","html_url":"https://github.com/schmie","followers_url":"https://api.github.com/users/schmie/followers","following_url":"https://api.github.com/users/schmie/following{/other_user}","gists_url":"https://api.github.com/users/schmie/gists{/gist_id}","starred_url":"https://api.github.com/users/schmie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmie/subscriptions","organizations_url":"https://api.github.com/users/schmie/orgs","repos_url":"https://api.github.com/users/schmie/repos","events_url":"https://api.github.com/users/schmie/events{/privacy}","received_events_url":"https://api.github.com/users/schmie/received_events","type":"User","site_admin":false},"milestone":null,"comments":4,"created_at":"2015-06-23T16:20:57Z","updated_at":"2015-06-23T16:21:05Z","closed_at":null,"body":"**Reported by miguel on 26 Sep 2011 08:46 UTC**\nThe patch attached implements support for non-newtonian fluid dynamics in HemeLB (some people would say just generalised newtonian). Briefly, it allows for viscosity to be dynamically calculated on a per site basis based on local shear-rate values. \r\n\r\nThis involved the development of three main components:\r\n * A shear-rate calculator in `D3Q15`.\r\n * 3 non-newtonian rheology models. That is, three different expressions for viscosity as a function of shear-rate.\r\n * A new collision operator (`LBGKNN`) that allows for different values of the relaxation time at each lattice site.\r\n\r\nThe developments are described in a bit more detail in the pdf attached.\r\n\r\nRegarding the code developed, there are a few things that may look a bit `HemeLB` unusual:\r\n * In the `rheology_models` folder, I've used explicit instantiation to split templated classes into .h and .cc files. There are pros and cons for doing this, just an idea we may want to adopt.\r\n * In `LBGKNN.cc`, I used a few `assert()` statements to check preconditions, bounds, etc. I think this helps finding bugs quicker. In production, one can disable them by defining the `NDEBUG` preprocessor macro.\r\n * Naming conventions: while developing this, my understanding of naming conventions has changed slightly, so one could say that it is all over the place. I'm going to open a ticket to discuss it and create a wiki page with clear guidelines.\r\n"},"comment":{"url":"https://api.github.com/repos/schmie/test/issues/comments/114561756","html_url":"https://github.com/schmie/test/issues/43#issuecomment-114561756","issue_url":"https://api.github.com/repos/schmie/test/issues/43","id":114561756,"user":{"login":"schmie","id":6473158,"avatar_url":"https://avatars.githubusercontent.com/u/6473158?v=3","gravatar_id":"","url":"https://api.github.com/users/schmie","html_url":"https://github.com/schmie","followers_url":"https://api.github.com/users/schmie/followers","following_url":"https://api.github.com/users/schmie/following{/other_user}","gists_url":"https://api.github.com/users/schmie/gists{/gist_id}","starred_url":"https://api.github.com/users/schmie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmie/subscriptions","organizations_url":"https://api.github.com/users/schmie/orgs","repos_url":"https://api.github.com/users/schmie/repos","events_url":"https://api.github.com/users/schmie/events{/privacy}","received_events_url":"https://api.github.com/users/schmie/received_events","type":"User","site_admin":false},"created_at":"2015-06-23T16:21:05Z","updated_at":"2015-06-23T16:21:05Z","body":"**Modified by hywel on 26 Sep 2011 11:06 UTC**"}}