{"push_id":887708721,"size":164,"distinct_size":164,"ref":"refs/heads/master","head":"72b92e817281ddc74e587295fcaa5422cdca01f8","before":"32a8cd961eec840f31e6d60948756070d188c2b4","commits":[{"sha":"7a191ffe44b9a0f08489b95cfb58f18ac8c641d6","author":{"email":"4df7f3dad182da66af235a1249daf95d26b3dee6@gmail.com","name":"Genadi Samokovarov"},"message":"Fix improper value types used to instantiate a Template in AV::NullResolver\n\nWhile trying to provide a reproducible test for #17008 I stumbled on\nthis one. Seems to be quite an old piece of code, but its definitely\nuseful in situations like the reproducible test cases like the one\nabove.","distinct":true,"url":"https://api.github.com/repos/sblackstone/rails/commits/7a191ffe44b9a0f08489b95cfb58f18ac8c641d6"},{"sha":"ff5fcf65ec1f5963e5168786277eb4437c065524","author":{"email":"c3923186c4c9da9c766af46f22a325cd4677020a@new-bamboo.co.uk","name":"Claudio Ortolina"},"message":"ActionMailer::Base can unregister interceptor(s).\n\nOne or multiple mail interceptors can be unregistered using\n`ActionMailer::Base.unregister_interceptors` or\n`ActionMailer::Base.unregister_interceptor`.\n\nFor preview interceptors, it's possible to use\n`ActionMailer::Base.unregister_preview_interceptors` or\n`ActionMailer::Base.unregister_preview_interceptor`.\n\nRefactors logic to constantize a string/symbol into separate method.","distinct":true,"url":"https://api.github.com/repos/sblackstone/rails/commits/ff5fcf65ec1f5963e5168786277eb4437c065524"},{"sha":"7f546318d56b75bafb798d0c178578600fd6939e","author":{"email":"abdcd2c4ada949d12f7edc8405bc52b22e425520@gmail.com","name":"Sergey Alekseev"},"message":"write a test for `#form_data?`\n\nThe initial attempt was to remove the method at all in\nhttps://github.com/sergey-alekseev/rails/commit/4926aa68c98673e7be88a2d2b57d72dc490bc71c.\n\nThe method overrides Rack's `#form_data?`\nhttps://github.com/rack/rack/blob/6f8808d4201e68e4bd780441b3b7bb3ee6d1f43e/lib/rack/request.rb#L172-L184.\nWhich may have some incorrect implementation actually. `type.nil?` isn't possible I suppose. I'll check.","distinct":true,"url":"https://api.github.com/repos/sblackstone/rails/commits/7f546318d56b75bafb798d0c178578600fd6939e"},{"sha":"a2a51913305ac59340928b0293faaa436678af50","author":{"email":"9cc14171df459567aec0d77752ddc819d01613eb@gmail.com","name":"Ronak Jangir"},"message":"Removed Mocha from Action View","distinct":true,"url":"https://api.github.com/repos/sblackstone/rails/commits/a2a51913305ac59340928b0293faaa436678af50"},{"sha":"5e4f82a5f39054b27232fbf0840496ab5ddb06a7","author":{"email":"46f1a0bd5592a2f9244ca321b129902a06b53e03@obduk.com","name":"Owen Davies"},"message":"Remove newlines from start of logs\n\nCurrently if using a single line logger, this causes the time stamp and\nlog message to be on separate lines which is not common to how most\nother logging works.","distinct":true,"url":"https://api.github.com/repos/sblackstone/rails/commits/5e4f82a5f39054b27232fbf0840496ab5ddb06a7"},{"sha":"e71cfc109dd2204efe35f1ffa927bdc08bd9999b","author":{"email":"c34d78e05aa7c1846d8eae9be95a1a462dcb2ae0@gmail.com","name":"hnatt"},"message":"Reduce code duplication in ActionMailer::Base#register_observer and #register_interceptor","distinct":true,"url":"https://api.github.com/repos/sblackstone/rails/commits/e71cfc109dd2204efe35f1ffa927bdc08bd9999b"},{"sha":"8c566b9a94c99ef218a0778310ab8ffc306aff1d","author":{"email":"c34d78e05aa7c1846d8eae9be95a1a462dcb2ae0@gmail.com","name":"hnatt"},"message":"Refactor ActionMailer::Base#collect_responses","distinct":true,"url":"https://api.github.com/repos/sblackstone/rails/commits/8c566b9a94c99ef218a0778310ab8ffc306aff1d"},{"sha":"04f1ce7950cb75407eff10bad6df6aa6414df197","author":{"email":"c34d78e05aa7c1846d8eae9be95a1a462dcb2ae0@gmail.com","name":"hnatt"},"message":"Refactor out defaults handling from ActionMailer::Base#mail","distinct":true,"url":"https://api.github.com/repos/sblackstone/rails/commits/04f1ce7950cb75407eff10bad6df6aa6414df197"},{"sha":"79b6a4bbc4d8a209363c33df79caeea462f6dde6","author":{"email":"c34d78e05aa7c1846d8eae9be95a1a462dcb2ae0@gmail.com","name":"hnatt"},"message":"Use attr_internal in ActionMailer::Base#mail instead of local var for message","distinct":true,"url":"https://api.github.com/repos/sblackstone/rails/commits/79b6a4bbc4d8a209363c33df79caeea462f6dde6"},{"sha":"4b65e5058e726af9ae02e2e0a65e6b5e1a1628ec","author":{"email":"c34d78e05aa7c1846d8eae9be95a1a462dcb2ae0@gmail.com","name":"hnatt"},"message":"Refactor out headers to message assignment from ActionMailer::Base#mail","distinct":true,"url":"https://api.github.com/repos/sblackstone/rails/commits/4b65e5058e726af9ae02e2e0a65e6b5e1a1628ec"},{"sha":"c26abb86915c64fdf6a80aed27f48e16491d51d6","author":{"email":"c34d78e05aa7c1846d8eae9be95a1a462dcb2ae0@gmail.com","name":"hnatt"},"message":"Fix indentation in ActionMailer::Base#collect_responses_from_templates","distinct":true,"url":"https://api.github.com/repos/sblackstone/rails/commits/c26abb86915c64fdf6a80aed27f48e16491d51d6"},{"sha":"e6e056c2c141ec94eb8e79a30ee766f77fdaf30d","author":{"email":"a027184a55211cd23e3f3094f1fdc728df5e0500@pololu.com","name":"Paul Grayson"},"message":"In url_for, never append ? when the query string is empty anyway.\nIt used to behave like this:\n\n    url_for(controller: 'x', action: 'y', q: {})\n    # -> \"/x/y?\"\n\nWe previously avoided empty query strings in most cases by removing\nnil values, then checking whether params was empty.  But as you can\nsee above, even non-empty params can yield an empty query string.  So\nI changed the code to just directly check whether the query string\nended up empty.\n\n(To make everything more consistent, the \"removing nil values\"\nfunctionality should probably move to ActionPack's Hash#to_query, the\nplace where empty hashes and arrays get removed.  However, this would\nchange a lot more behavior.)","distinct":true,"url":"https://api.github.com/repos/sblackstone/rails/commits/e6e056c2c141ec94eb8e79a30ee766f77fdaf30d"},{"sha":"2a55a6d2e518662d0f213cfe8c81b2eea66b5323","author":{"email":"c34d78e05aa7c1846d8eae9be95a1a462dcb2ae0@gmail.com","name":"hnatt"},"message":"Pass message as argument to ActionMailer::Base#assign_headers_to_message","distinct":true,"url":"https://api.github.com/repos/sblackstone/rails/commits/2a55a6d2e518662d0f213cfe8c81b2eea66b5323"},{"sha":"baaf3769ff179248353ced0c60495c349a912fe1","author":{"email":"c34d78e05aa7c1846d8eae9be95a1a462dcb2ae0@gmail.com","name":"hnatt"},"message":"Don't mutate headers in ActionMailer::Base#collect_responses_from_templates","distinct":true,"url":"https://api.github.com/repos/sblackstone/rails/commits/baaf3769ff179248353ced0c60495c349a912fe1"},{"sha":"1be276beb4761caeb211443a4c2e7f4482b94ebc","author":{"email":"c34d78e05aa7c1846d8eae9be95a1a462dcb2ae0@gmail.com","name":"hnatt"},"message":"Rename ActionMailer::Base#class_from_value -> observer_class_for","distinct":true,"url":"https://api.github.com/repos/sblackstone/rails/commits/1be276beb4761caeb211443a4c2e7f4482b94ebc"},{"sha":"85f7d955f31209605cccd4cca64be93eec9782f1","author":{"email":"a8982b90417ea23143fc49f8fbc13d4745795134@gmail.com","name":"Thomas Walpole"},"message":"Update and fix forbidden attributes tests\nAdd AC::Parameters tests for WhereChain#not","distinct":true,"url":"https://api.github.com/repos/sblackstone/rails/commits/85f7d955f31209605cccd4cca64be93eec9782f1"},{"sha":"08689a2d1f0165f353f62ef4626e87fe841ec735","author":{"email":"be8758dc4a66004612e74b567a662d4f1fbf4c2e@gmail.com","name":"Tijmen Brommet"},"message":"Add text template for source code\n\nWhen a request is made with AJAX and an error occurs, Rails will render\na text-template for the exception instead of the HTML error page\n(#11960).\n\nThe `.text.erb` variant of the `_source` template is currently missing,\ncausing HTML to be rendered in the response. This commit adds the text\ntemplate.\n\nTo keep the page scannable we only only show the first three source\nextracts.\n\nRelated to #14745.\n\nBefore:\n\n```\n~/testing-exceptions  ᐅ curl 'http://localhost:3000/' -H\n'X-Requested-With: XMLHttpRequest'\nRuntimeError in PostsController#index\n\n    <div class=\"source \" id=\"frame-source-0\">\n      <div class=\"info\">\n        Extracted source (around line <strong>#3</strong>):\n      </div>\n      <div class=\"data\">\n        <table cellpadding=\"0\" cellspacing=\"0\" class=\"lines\">\n          <tr>\n```\n\nAfter:\n\n```\n~/testing-exceptions  ᐅ curl 'http://localhost:3000/' -H\n'X-Requested-With: XMLHttpRequest'\nRuntimeError in PostsController#index\n\nExtracted source (around line #3):\n\n*3     raise\n```","distinct":true,"url":"https://api.github.com/repos/sblackstone/rails/commits/08689a2d1f0165f353f62ef4626e87fe841ec735"},{"sha":"fc88e4a5c317830686e3160bb4ba95e49c681b12","author":{"email":"bca6f4261a19f75277fe4325de3272d15492eb61@gmail.com","name":"Ryuta Kamizono"},"message":"Not passing `native_database_types` to `TableDefinition`\n\nThe `native_database_types` only used in `TableDefinition` for look up\nthe default `:limit` option. But this is duplicated process with\n`type_to_sql`. Passing `native_database_types` is not needed.","distinct":true,"url":"https://api.github.com/repos/sblackstone/rails/commits/fc88e4a5c317830686e3160bb4ba95e49c681b12"},{"sha":"dbb970fa8e0fe5120bd7c5968a33f10cd77fff6f","author":{"email":"16356534c1589fe78070f5640bedf8614007153c@gmail.com","name":"yuuji.yaginuma"},"message":"don't package test files in plugin gemspec\n\nIn rails engine, there is a dummy application under test,\nthe size of the test file is increased.\n\nHowever, there is no need test files for most users,\nI think it good to have so as not included by default.","distinct":true,"url":"https://api.github.com/repos/sblackstone/rails/commits/dbb970fa8e0fe5120bd7c5968a33f10cd77fff6f"},{"sha":"3fccecb87b04cd550713ebf5d735c2a6dbccb4a1","author":{"email":"33fe9ec992969d84918d06f97932218179191f75@alliants.com","name":"the-undefined"},"message":"[ci skip] add `controller:` argument to routing.md\n\nPassing a `Symbol` to the `to:` argument for a `get` route requires a `controller` argument to also be defined.\nThe documentation is missing the `controller:` argument, which leaving out raises a routing exception:\n\n```ruby\nget 'profile', to: :show\n```\n\n```\n$ rake routes\nArgumentError: Missing :controller key on routes definition, please check your routes.\n```\n\nAdding the `controller:` argument maps the route correctly:\n\n```ruby\nget 'profile', to: :show, controller: 'users'\n```\n```\n$ rake routes\nprofile GET    /profile(.:format)  users#show\n```","distinct":true,"url":"https://api.github.com/repos/sblackstone/rails/commits/3fccecb87b04cd550713ebf5d735c2a6dbccb4a1"}]}