{"action":"created","comment":{"url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/24704607","id":24704607,"diff_hunk":"@@ -3,22 +3,33 @@ class NameCollisionError < RuntimeError; end\n class Robot\n   attr_accessor :name\n \n-  @@registry\n-\n-  def initialize(args = {})\n-    @@registry ||= []\n-    @name_generator = args[:name_generator]\n+  def generate_char \n+    ('A'..'Z').to_a.sample\n+  end\n+  \n+  def generate_num\n+    rand(10) \n+  end\n \n+  def name_generator\n     if @name_generator\n       @name = @name_generator.call\n     else\n-      generate_char = -> { ('A'..'Z').to_a.sample }\n-      generate_num = -> { rand(10) }\n+      @name = \"#{generate_char}#{generate_char}#{generate_num}#{generate_num}#{generate_num}\"\n+    end\n+  end\n \n-      @name = \"#{generate_char.call}#{generate_char.call}#{generate_num.call}#{generate_num.call}#{generate_num.call}\"\n+  def is_error?\n+    if !(@name =~ /[[:alpha:]]{2}[[:digit:]]{3}/) || @@registry.include?(name)\n+      raise NameCollisionError, 'There was a problem generating the robot name!'\n     end\n+  end\n \n-    raise NameCollisionError, 'There was a problem generating the robot name!' if !(name =~ /[[:alpha:]]{2}[[:digit:]]{3}/) || @@registry.include?(name)\n+  def initialize(args = {})\n+    @@registry ||= []\n+    @name_generator = args[:name_generator]\n+    @name = name_generator \n+    is_error?\n     @@registry << @name","path":"robot_name/robot_name.rb","position":40,"original_position":40,"commit_id":"f2b5dc5de4eec4ff99f9b3fda7f4c538c1fa8782","original_commit_id":"f2b5dc5de4eec4ff99f9b3fda7f4c538c1fa8782","user":{"login":"ashtonthomas","id":53977,"avatar_url":"https://avatars.githubusercontent.com/u/53977?v=3","gravatar_id":"","url":"https://api.github.com/users/ashtonthomas","html_url":"https://github.com/ashtonthomas","followers_url":"https://api.github.com/users/ashtonthomas/followers","following_url":"https://api.github.com/users/ashtonthomas/following{/other_user}","gists_url":"https://api.github.com/users/ashtonthomas/gists{/gist_id}","starred_url":"https://api.github.com/users/ashtonthomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashtonthomas/subscriptions","organizations_url":"https://api.github.com/users/ashtonthomas/orgs","repos_url":"https://api.github.com/users/ashtonthomas/repos","events_url":"https://api.github.com/users/ashtonthomas/events{/privacy}","received_events_url":"https://api.github.com/users/ashtonthomas/received_events","type":"User","site_admin":false},"body":"this should probably go into the name generator method as well","created_at":"2015-02-13T23:01:55Z","updated_at":"2015-02-13T23:01:55Z","html_url":"https://github.com/jmmastey/level_up_exercises/pull/505#discussion_r24704607","pull_request_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/505","_links":{"self":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/24704607"},"html":{"href":"https://github.com/jmmastey/level_up_exercises/pull/505#discussion_r24704607"},"pull_request":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/505"}}},"pull_request":{"url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/505","id":29221354,"html_url":"https://github.com/jmmastey/level_up_exercises/pull/505","diff_url":"https://github.com/jmmastey/level_up_exercises/pull/505.diff","patch_url":"https://github.com/jmmastey/level_up_exercises/pull/505.patch","issue_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/505","number":505,"state":"open","locked":false,"title":"Refactored code for readability","user":{"login":"theundeadmonk","id":7609117,"avatar_url":"https://avatars.githubusercontent.com/u/7609117?v=3","gravatar_id":"","url":"https://api.github.com/users/theundeadmonk","html_url":"https://github.com/theundeadmonk","followers_url":"https://api.github.com/users/theundeadmonk/followers","following_url":"https://api.github.com/users/theundeadmonk/following{/other_user}","gists_url":"https://api.github.com/users/theundeadmonk/gists{/gist_id}","starred_url":"https://api.github.com/users/theundeadmonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theundeadmonk/subscriptions","organizations_url":"https://api.github.com/users/theundeadmonk/orgs","repos_url":"https://api.github.com/users/theundeadmonk/repos","events_url":"https://api.github.com/users/theundeadmonk/events{/privacy}","received_events_url":"https://api.github.com/users/theundeadmonk/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-02-12T22:11:09Z","updated_at":"2015-02-13T23:01:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d436d92b61c6a6e1ee91e9c191339dbb098fc6cb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/505/commits","review_comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/505/comments","review_comment_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/505/comments","statuses_url":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/f2b5dc5de4eec4ff99f9b3fda7f4c538c1fa8782","head":{"label":"theundeadmonk:robot","ref":"robot","sha":"f2b5dc5de4eec4ff99f9b3fda7f4c538c1fa8782","user":{"login":"theundeadmonk","id":7609117,"avatar_url":"https://avatars.githubusercontent.com/u/7609117?v=3","gravatar_id":"","url":"https://api.github.com/users/theundeadmonk","html_url":"https://github.com/theundeadmonk","followers_url":"https://api.github.com/users/theundeadmonk/followers","following_url":"https://api.github.com/users/theundeadmonk/following{/other_user}","gists_url":"https://api.github.com/users/theundeadmonk/gists{/gist_id}","starred_url":"https://api.github.com/users/theundeadmonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theundeadmonk/subscriptions","organizations_url":"https://api.github.com/users/theundeadmonk/orgs","repos_url":"https://api.github.com/users/theundeadmonk/repos","events_url":"https://api.github.com/users/theundeadmonk/events{/privacy}","received_events_url":"https://api.github.com/users/theundeadmonk/received_events","type":"User","site_admin":false},"repo":{"id":30712640,"name":"level_up_exercises","full_name":"theundeadmonk/level_up_exercises","owner":{"login":"theundeadmonk","id":7609117,"avatar_url":"https://avatars.githubusercontent.com/u/7609117?v=3","gravatar_id":"","url":"https://api.github.com/users/theundeadmonk","html_url":"https://github.com/theundeadmonk","followers_url":"https://api.github.com/users/theundeadmonk/followers","following_url":"https://api.github.com/users/theundeadmonk/following{/other_user}","gists_url":"https://api.github.com/users/theundeadmonk/gists{/gist_id}","starred_url":"https://api.github.com/users/theundeadmonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theundeadmonk/subscriptions","organizations_url":"https://api.github.com/users/theundeadmonk/orgs","repos_url":"https://api.github.com/users/theundeadmonk/repos","events_url":"https://api.github.com/users/theundeadmonk/events{/privacy}","received_events_url":"https://api.github.com/users/theundeadmonk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/theundeadmonk/level_up_exercises","description":"A series of code-related assignments to challenge starting engineers","fork":true,"url":"https://api.github.com/repos/theundeadmonk/level_up_exercises","forks_url":"https://api.github.com/repos/theundeadmonk/level_up_exercises/forks","keys_url":"https://api.github.com/repos/theundeadmonk/level_up_exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theundeadmonk/level_up_exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theundeadmonk/level_up_exercises/teams","hooks_url":"https://api.github.com/repos/theundeadmonk/level_up_exercises/hooks","issue_events_url":"https://api.github.com/repos/theundeadmonk/level_up_exercises/issues/events{/number}","events_url":"https://api.github.com/repos/theundeadmonk/level_up_exercises/events","assignees_url":"https://api.github.com/repos/theundeadmonk/level_up_exercises/assignees{/user}","branches_url":"https://api.github.com/repos/theundeadmonk/level_up_exercises/branches{/branch}","tags_url":"https://api.github.com/repos/theundeadmonk/level_up_exercises/tags","blobs_url":"https://api.github.com/repos/theundeadmonk/level_up_exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theundeadmonk/level_up_exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theundeadmonk/level_up_exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/theundeadmonk/level_up_exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theundeadmonk/level_up_exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/theundeadmonk/level_up_exercises/languages","stargazers_url":"https://api.github.com/repos/theundeadmonk/level_up_exercises/stargazers","contributors_url":"https://api.github.com/repos/theundeadmonk/level_up_exercises/contributors","subscribers_url":"https://api.github.com/repos/theundeadmonk/level_up_exercises/subscribers","subscription_url":"https://api.github.com/repos/theundeadmonk/level_up_exercises/subscription","commits_url":"https://api.github.com/repos/theundeadmonk/level_up_exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/theundeadmonk/level_up_exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/theundeadmonk/level_up_exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/theundeadmonk/level_up_exercises/issues/comments/{number}","contents_url":"https://api.github.com/repos/theundeadmonk/level_up_exercises/contents/{+path}","compare_url":"https://api.github.com/repos/theundeadmonk/level_up_exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theundeadmonk/level_up_exercises/merges","archive_url":"https://api.github.com/repos/theundeadmonk/level_up_exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theundeadmonk/level_up_exercises/downloads","issues_url":"https://api.github.com/repos/theundeadmonk/level_up_exercises/issues{/number}","pulls_url":"https://api.github.com/repos/theundeadmonk/level_up_exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/theundeadmonk/level_up_exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/theundeadmonk/level_up_exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theundeadmonk/level_up_exercises/labels{/name}","releases_url":"https://api.github.com/repos/theundeadmonk/level_up_exercises/releases{/id}","created_at":"2015-02-12T16:50:26Z","updated_at":"2015-02-12T16:50:26Z","pushed_at":"2015-02-13T17:57:34Z","git_url":"git://github.com/theundeadmonk/level_up_exercises.git","ssh_url":"git@github.com:theundeadmonk/level_up_exercises.git","clone_url":"https://github.com/theundeadmonk/level_up_exercises.git","svn_url":"https://github.com/theundeadmonk/level_up_exercises","homepage":"http://leveluprails.herokuapp.com","size":120749,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jmmastey:master","ref":"master","sha":"f208d381f275b417df72d3cdf6562ceb443bfd3a","user":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=3","gravatar_id":"","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"repo":{"id":20705648,"name":"level_up_exercises","full_name":"jmmastey/level_up_exercises","owner":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=3","gravatar_id":"","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmmastey/level_up_exercises","description":"A series of code-related assignments to challenge starting engineers","fork":false,"url":"https://api.github.com/repos/jmmastey/level_up_exercises","forks_url":"https://api.github.com/repos/jmmastey/level_up_exercises/forks","keys_url":"https://api.github.com/repos/jmmastey/level_up_exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmmastey/level_up_exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmmastey/level_up_exercises/teams","hooks_url":"https://api.github.com/repos/jmmastey/level_up_exercises/hooks","issue_events_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/events{/number}","events_url":"https://api.github.com/repos/jmmastey/level_up_exercises/events","assignees_url":"https://api.github.com/repos/jmmastey/level_up_exercises/assignees{/user}","branches_url":"https://api.github.com/repos/jmmastey/level_up_exercises/branches{/branch}","tags_url":"https://api.github.com/repos/jmmastey/level_up_exercises/tags","blobs_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/jmmastey/level_up_exercises/languages","stargazers_url":"https://api.github.com/repos/jmmastey/level_up_exercises/stargazers","contributors_url":"https://api.github.com/repos/jmmastey/level_up_exercises/contributors","subscribers_url":"https://api.github.com/repos/jmmastey/level_up_exercises/subscribers","subscription_url":"https://api.github.com/repos/jmmastey/level_up_exercises/subscription","commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/comments/{number}","contents_url":"https://api.github.com/repos/jmmastey/level_up_exercises/contents/{+path}","compare_url":"https://api.github.com/repos/jmmastey/level_up_exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmmastey/level_up_exercises/merges","archive_url":"https://api.github.com/repos/jmmastey/level_up_exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmmastey/level_up_exercises/downloads","issues_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues{/number}","pulls_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/jmmastey/level_up_exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/jmmastey/level_up_exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmmastey/level_up_exercises/labels{/name}","releases_url":"https://api.github.com/repos/jmmastey/level_up_exercises/releases{/id}","created_at":"2014-06-10T23:42:24Z","updated_at":"2015-01-23T17:55:29Z","pushed_at":"2015-01-23T17:55:29Z","git_url":"git://github.com/jmmastey/level_up_exercises.git","ssh_url":"git@github.com:jmmastey/level_up_exercises.git","clone_url":"https://github.com/jmmastey/level_up_exercises.git","svn_url":"https://github.com/jmmastey/level_up_exercises","homepage":"http://leveluprails.herokuapp.com","size":120749,"stargazers_count":14,"watchers_count":14,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":71,"mirror_url":null,"open_issues_count":6,"forks":71,"open_issues":6,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/505"},"html":{"href":"https://github.com/jmmastey/level_up_exercises/pull/505"},"issue":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/505"},"comments":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/505/comments"},"review_comments":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/505/comments"},"review_comment":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/505/commits"},"statuses":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/f2b5dc5de4eec4ff99f9b3fda7f4c538c1fa8782"}}}}