{"action":"created","issue":{"url":"https://api.github.com/repos/tomkr/embedr/issues/81","labels_url":"https://api.github.com/repos/tomkr/embedr/issues/81/labels{/name}","comments_url":"https://api.github.com/repos/tomkr/embedr/issues/81/comments","events_url":"https://api.github.com/repos/tomkr/embedr/issues/81/events","html_url":"https://github.com/tomkr/embedr/issues/81","id":110409730,"number":81,"title":"Different viewer options for display in embedded images iframe","user":{"login":"mzeinstra","id":5627431,"avatar_url":"https://avatars.githubusercontent.com/u/5627431?v=3","gravatar_id":"","url":"https://api.github.com/users/mzeinstra","html_url":"https://github.com/mzeinstra","followers_url":"https://api.github.com/users/mzeinstra/followers","following_url":"https://api.github.com/users/mzeinstra/following{/other_user}","gists_url":"https://api.github.com/users/mzeinstra/gists{/gist_id}","starred_url":"https://api.github.com/users/mzeinstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzeinstra/subscriptions","organizations_url":"https://api.github.com/users/mzeinstra/orgs","repos_url":"https://api.github.com/users/mzeinstra/repos","events_url":"https://api.github.com/users/mzeinstra/events{/privacy}","received_events_url":"https://api.github.com/users/mzeinstra/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/tomkr/embedr/milestones/5","html_url":"https://github.com/tomkr/embedr/milestones/v1","labels_url":"https://api.github.com/repos/tomkr/embedr/milestones/5/labels","id":1363383,"number":5,"title":"v1","description":"This Milestone contains all tickets for the first version of Embedr.eu","creator":{"login":"mzeinstra","id":5627431,"avatar_url":"https://avatars.githubusercontent.com/u/5627431?v=3","gravatar_id":"","url":"https://api.github.com/users/mzeinstra","html_url":"https://github.com/mzeinstra","followers_url":"https://api.github.com/users/mzeinstra/followers","following_url":"https://api.github.com/users/mzeinstra/following{/other_user}","gists_url":"https://api.github.com/users/mzeinstra/gists{/gist_id}","starred_url":"https://api.github.com/users/mzeinstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzeinstra/subscriptions","organizations_url":"https://api.github.com/users/mzeinstra/orgs","repos_url":"https://api.github.com/users/mzeinstra/repos","events_url":"https://api.github.com/users/mzeinstra/events{/privacy}","received_events_url":"https://api.github.com/users/mzeinstra/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":26,"state":"open","created_at":"2015-10-19T09:02:11Z","updated_at":"2015-11-02T09:57:25Z","due_on":"2015-11-02T23:00:00Z","closed_at":null},"comments":0,"created_at":"2015-10-08T09:43:14Z","updated_at":"2015-11-03T20:31:03Z","closed_at":null,"body":"Currently the display of embedded images on sites that are not on embedr.eu display all options that are available on embedr.eu\r\n\r\nWe want to change that. As embedded images usually don't have access to the full screen its interaction is flawed.\r\n\r\nWe want to reduce this functionality to only the zoom buttons and a button for embed. pressing this last button would bring the user to the embedr.eu website of the image.\r\n\r\n![pasted image at 2015_10_09 04_57 pm](https://cloud.githubusercontent.com/assets/5627431/10877366/dcde8ade-8145-11e5-9c65-2378794b639c.png)\r\n\r\nI foresee a couple of ways to solve this.\r\n\r\n1. automatically detect when the iframe is not embedded on embedr.eu\r\nThis is costly and probably has some security risks for the end-user\r\n\r\n2. use a GET variable to communicate which set-up to use. \r\nI prefer this one, use a negative variable for external embedding. i.e. do something like  http://media.embedr.eu/Rijksmuseum_SK-C-5?f=1 for embedding within embedr.eu and\r\nhttp://media.embedr.eu/Rijksmuseum_SK-C-5 for embedding on external platforms. This keeps the url cleaner for external use and makes the default the version with less functionality."},"comment":{"url":"https://api.github.com/repos/tomkr/embedr/issues/comments/153477948","html_url":"https://github.com/tomkr/embedr/issues/81#issuecomment-153477948","issue_url":"https://api.github.com/repos/tomkr/embedr/issues/81","id":153477948,"user":{"login":"tomkr","id":445647,"avatar_url":"https://avatars.githubusercontent.com/u/445647?v=3","gravatar_id":"","url":"https://api.github.com/users/tomkr","html_url":"https://github.com/tomkr","followers_url":"https://api.github.com/users/tomkr/followers","following_url":"https://api.github.com/users/tomkr/following{/other_user}","gists_url":"https://api.github.com/users/tomkr/gists{/gist_id}","starred_url":"https://api.github.com/users/tomkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomkr/subscriptions","organizations_url":"https://api.github.com/users/tomkr/orgs","repos_url":"https://api.github.com/users/tomkr/repos","events_url":"https://api.github.com/users/tomkr/events{/privacy}","received_events_url":"https://api.github.com/users/tomkr/received_events","type":"User","site_admin":false},"created_at":"2015-11-03T20:31:03Z","updated_at":"2015-11-03T20:31:03Z","body":"This seems to be related to #85. It's a bit clearer to me now. So if I understand correctly the following needs to change:\r\n\r\n* [ ] The current viewer has to be shown when a GET-parameter is set.\r\n* [ ] Without the GET-parameter the viewer has to only show zoom-in and zoom-out buttons.\r\n* [ ] Without the GET-parameter the viewer gets an embed-button that is simply a hyperlink the the full viewer on the embedr.eu page.\r\n\r\nSince this requires a lot of changes to the media.embedr.eu page, I think it may be smart to move the javascript and css files for the viewer to the embedr.eu server. That way they can be changed without further PRs. So an additional requirement:\r\n\r\n* [ ] Serve static assets for viewer from embedr.eu.\r\n\r\nAgreed?"}}