{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/smarthome/pulls/comments/39164076","id":39164076,"diff_hunk":"@@ -162,8 +162,12 @@ public void statusUpdated(final Thing thing, ThingStatusInfo thingStatus) {\n                 Bridge bridge = (Bridge) thing;\n                 for (Thing bridgeThing : bridge.getThings()) {\n                     if (thingStatus.getStatus() == ThingStatus.ONLINE) {\n-                        ThingStatusInfo statusInfo = ThingStatusInfoBuilder.create(ThingStatus.ONLINE).build();\n-                        setThingStatus(bridgeThing, statusInfo);\n+                    \tThingStatusInfo bridgeThingStatus = bridgeThing.getStatusInfo(); \n+                    \tif (bridgeThingStatus.getStatus() == ThingStatus.ONLINE || ","path":"bundles/core/org.eclipse.smarthome.core.thing/src/main/java/org/eclipse/smarthome/core/thing/internal/ThingManager.java","position":null,"original_position":7,"commit_id":"dcad83163f4f5f75715b1e5fe2a29ab8d75bca99","original_commit_id":"3c7cec5698fb94fda84759b6a5b7f52da8c548d3","user":{"login":"marcelrv","id":5871213,"avatar_url":"https://avatars.githubusercontent.com/u/5871213?v=3","gravatar_id":"","url":"https://api.github.com/users/marcelrv","html_url":"https://github.com/marcelrv","followers_url":"https://api.github.com/users/marcelrv/followers","following_url":"https://api.github.com/users/marcelrv/following{/other_user}","gists_url":"https://api.github.com/users/marcelrv/gists{/gist_id}","starred_url":"https://api.github.com/users/marcelrv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcelrv/subscriptions","organizations_url":"https://api.github.com/users/marcelrv/orgs","repos_url":"https://api.github.com/users/marcelrv/repos","events_url":"https://api.github.com/users/marcelrv/events{/privacy}","received_events_url":"https://api.github.com/users/marcelrv/received_events","type":"User","site_admin":false},"body":"perfect, then I remove it, as I interpreted that in a way that these\nupdates were wanted.\n\n2015-09-10 13:16 GMT+02:00 Kai Kreuzer <notifications@github.com>:\n\n> In\n> bundles/core/org.eclipse.smarthome.core.thing/src/main/java/org/eclipse/smarthome/core/thing/internal/ThingManager.java\n> <https://github.com/eclipse/smarthome/pull/442#discussion_r39148506>:\n>\n> > @@ -162,8 +162,12 @@ public void statusUpdated(final Thing thing, ThingStatusInfo thingStatus) {\n> >                  Bridge bridge = (Bridge) thing;\n> >                  for (Thing bridgeThing : bridge.getThings()) {\n> >                      if (thingStatus.getStatus() == ThingStatus.ONLINE) {\n> > -                        ThingStatusInfo statusInfo = ThingStatusInfoBuilder.create(ThingStatus.ONLINE).build();\n> > -                        setThingStatus(bridgeThing, statusInfo);\n> > +                    \tThingStatusInfo bridgeThingStatus = bridgeThing.getStatusInfo();\n> > +                    \tif (bridgeThingStatus.getStatus() == ThingStatus.ONLINE ||\n>\n> FTR, @marcelrv <https://github.com/marcelrv> is referring to my comment openhab/openhab2#357\n> (comment)\n> <https://github.com/openhab/openhab2/pull/357#discussion_r38522344>.\n> But this was not about setting statuses for child devices of a bridge, but\n> about setting the bridge status itself.\n> In the case here, we are iterating over all child devices and I agree that\n> it does not make sense to send an ONLINE status if they are already ONLINE,\n> since we do not even know at this place whether this is true or not.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/eclipse/smarthome/pull/442/files#r39148506>.\n>\n","created_at":"2015-09-10T14:12:23Z","updated_at":"2015-09-10T14:12:23Z","html_url":"https://github.com/eclipse/smarthome/pull/442#discussion_r39164076","pull_request_url":"https://api.github.com/repos/eclipse/smarthome/pulls/442","_links":{"self":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/comments/39164076"},"html":{"href":"https://github.com/eclipse/smarthome/pull/442#discussion_r39164076"},"pull_request":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/442"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/smarthome/pulls/442","id":44577433,"html_url":"https://github.com/eclipse/smarthome/pull/442","diff_url":"https://github.com/eclipse/smarthome/pull/442.diff","patch_url":"https://github.com/eclipse/smarthome/pull/442.patch","issue_url":"https://api.github.com/repos/eclipse/smarthome/issues/442","number":442,"state":"open","locked":false,"title":"fix wrong status update for bridge child things","user":{"login":"marcelrv","id":5871213,"avatar_url":"https://avatars.githubusercontent.com/u/5871213?v=3","gravatar_id":"","url":"https://api.github.com/users/marcelrv","html_url":"https://github.com/marcelrv","followers_url":"https://api.github.com/users/marcelrv/followers","following_url":"https://api.github.com/users/marcelrv/following{/other_user}","gists_url":"https://api.github.com/users/marcelrv/gists{/gist_id}","starred_url":"https://api.github.com/users/marcelrv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcelrv/subscriptions","organizations_url":"https://api.github.com/users/marcelrv/orgs","repos_url":"https://api.github.com/users/marcelrv/repos","events_url":"https://api.github.com/users/marcelrv/events{/privacy}","received_events_url":"https://api.github.com/users/marcelrv/received_events","type":"User","site_admin":false},"body":"Addressing issue\r\nhttps://bugs.eclipse.org/bugs/show_bug.cgi?id=465480","created_at":"2015-09-09T17:23:09Z","updated_at":"2015-09-10T14:12:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d288893e4cdb6bd2f555b92010c5073f455824b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/smarthome/pulls/442/commits","review_comments_url":"https://api.github.com/repos/eclipse/smarthome/pulls/442/comments","review_comment_url":"https://api.github.com/repos/eclipse/smarthome/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/smarthome/issues/442/comments","statuses_url":"https://api.github.com/repos/eclipse/smarthome/statuses/dcad83163f4f5f75715b1e5fe2a29ab8d75bca99","head":{"label":"marcelrv:ChildStatusupdate","ref":"ChildStatusupdate","sha":"dcad83163f4f5f75715b1e5fe2a29ab8d75bca99","user":{"login":"marcelrv","id":5871213,"avatar_url":"https://avatars.githubusercontent.com/u/5871213?v=3","gravatar_id":"","url":"https://api.github.com/users/marcelrv","html_url":"https://github.com/marcelrv","followers_url":"https://api.github.com/users/marcelrv/followers","following_url":"https://api.github.com/users/marcelrv/following{/other_user}","gists_url":"https://api.github.com/users/marcelrv/gists{/gist_id}","starred_url":"https://api.github.com/users/marcelrv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcelrv/subscriptions","organizations_url":"https://api.github.com/users/marcelrv/orgs","repos_url":"https://api.github.com/users/marcelrv/repos","events_url":"https://api.github.com/users/marcelrv/events{/privacy}","received_events_url":"https://api.github.com/users/marcelrv/received_events","type":"User","site_admin":false},"repo":{"id":22030802,"name":"smarthome","full_name":"marcelrv/smarthome","owner":{"login":"marcelrv","id":5871213,"avatar_url":"https://avatars.githubusercontent.com/u/5871213?v=3","gravatar_id":"","url":"https://api.github.com/users/marcelrv","html_url":"https://github.com/marcelrv","followers_url":"https://api.github.com/users/marcelrv/followers","following_url":"https://api.github.com/users/marcelrv/following{/other_user}","gists_url":"https://api.github.com/users/marcelrv/gists{/gist_id}","starred_url":"https://api.github.com/users/marcelrv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcelrv/subscriptions","organizations_url":"https://api.github.com/users/marcelrv/orgs","repos_url":"https://api.github.com/users/marcelrv/repos","events_url":"https://api.github.com/users/marcelrv/events{/privacy}","received_events_url":"https://api.github.com/users/marcelrv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marcelrv/smarthome","description":"Eclipse SmartHome project","fork":true,"url":"https://api.github.com/repos/marcelrv/smarthome","forks_url":"https://api.github.com/repos/marcelrv/smarthome/forks","keys_url":"https://api.github.com/repos/marcelrv/smarthome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marcelrv/smarthome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marcelrv/smarthome/teams","hooks_url":"https://api.github.com/repos/marcelrv/smarthome/hooks","issue_events_url":"https://api.github.com/repos/marcelrv/smarthome/issues/events{/number}","events_url":"https://api.github.com/repos/marcelrv/smarthome/events","assignees_url":"https://api.github.com/repos/marcelrv/smarthome/assignees{/user}","branches_url":"https://api.github.com/repos/marcelrv/smarthome/branches{/branch}","tags_url":"https://api.github.com/repos/marcelrv/smarthome/tags","blobs_url":"https://api.github.com/repos/marcelrv/smarthome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marcelrv/smarthome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marcelrv/smarthome/git/refs{/sha}","trees_url":"https://api.github.com/repos/marcelrv/smarthome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marcelrv/smarthome/statuses/{sha}","languages_url":"https://api.github.com/repos/marcelrv/smarthome/languages","stargazers_url":"https://api.github.com/repos/marcelrv/smarthome/stargazers","contributors_url":"https://api.github.com/repos/marcelrv/smarthome/contributors","subscribers_url":"https://api.github.com/repos/marcelrv/smarthome/subscribers","subscription_url":"https://api.github.com/repos/marcelrv/smarthome/subscription","commits_url":"https://api.github.com/repos/marcelrv/smarthome/commits{/sha}","git_commits_url":"https://api.github.com/repos/marcelrv/smarthome/git/commits{/sha}","comments_url":"https://api.github.com/repos/marcelrv/smarthome/comments{/number}","issue_comment_url":"https://api.github.com/repos/marcelrv/smarthome/issues/comments{/number}","contents_url":"https://api.github.com/repos/marcelrv/smarthome/contents/{+path}","compare_url":"https://api.github.com/repos/marcelrv/smarthome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marcelrv/smarthome/merges","archive_url":"https://api.github.com/repos/marcelrv/smarthome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marcelrv/smarthome/downloads","issues_url":"https://api.github.com/repos/marcelrv/smarthome/issues{/number}","pulls_url":"https://api.github.com/repos/marcelrv/smarthome/pulls{/number}","milestones_url":"https://api.github.com/repos/marcelrv/smarthome/milestones{/number}","notifications_url":"https://api.github.com/repos/marcelrv/smarthome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marcelrv/smarthome/labels{/name}","releases_url":"https://api.github.com/repos/marcelrv/smarthome/releases{/id}","created_at":"2014-07-20T10:17:03Z","updated_at":"2015-04-29T06:54:54Z","pushed_at":"2015-09-10T14:10:16Z","git_url":"git://github.com/marcelrv/smarthome.git","ssh_url":"git@github.com:marcelrv/smarthome.git","clone_url":"https://github.com/marcelrv/smarthome.git","svn_url":"https://github.com/marcelrv/smarthome","homepage":null,"size":10975,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"0d426400591e1aeca0bc8269c07418375fc49529","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":15778981,"name":"smarthome","full_name":"eclipse/smarthome","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/smarthome","description":"Eclipse SmartHome project","fork":false,"url":"https://api.github.com/repos/eclipse/smarthome","forks_url":"https://api.github.com/repos/eclipse/smarthome/forks","keys_url":"https://api.github.com/repos/eclipse/smarthome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/smarthome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/smarthome/teams","hooks_url":"https://api.github.com/repos/eclipse/smarthome/hooks","issue_events_url":"https://api.github.com/repos/eclipse/smarthome/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/smarthome/events","assignees_url":"https://api.github.com/repos/eclipse/smarthome/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/smarthome/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/smarthome/tags","blobs_url":"https://api.github.com/repos/eclipse/smarthome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/smarthome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/smarthome/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/smarthome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/smarthome/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/smarthome/languages","stargazers_url":"https://api.github.com/repos/eclipse/smarthome/stargazers","contributors_url":"https://api.github.com/repos/eclipse/smarthome/contributors","subscribers_url":"https://api.github.com/repos/eclipse/smarthome/subscribers","subscription_url":"https://api.github.com/repos/eclipse/smarthome/subscription","commits_url":"https://api.github.com/repos/eclipse/smarthome/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/smarthome/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/smarthome/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/smarthome/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/smarthome/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/smarthome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/smarthome/merges","archive_url":"https://api.github.com/repos/eclipse/smarthome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/smarthome/downloads","issues_url":"https://api.github.com/repos/eclipse/smarthome/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/smarthome/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/smarthome/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/smarthome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/smarthome/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/smarthome/releases{/id}","created_at":"2014-01-09T20:47:19Z","updated_at":"2015-09-08T02:00:30Z","pushed_at":"2015-09-10T14:10:16Z","git_url":"git://github.com/eclipse/smarthome.git","ssh_url":"git@github.com:eclipse/smarthome.git","clone_url":"https://github.com/eclipse/smarthome.git","svn_url":"https://github.com/eclipse/smarthome","homepage":null,"size":20714,"stargazers_count":179,"watchers_count":179,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":176,"mirror_url":null,"open_issues_count":10,"forks":176,"open_issues":10,"watchers":179,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/442"},"html":{"href":"https://github.com/eclipse/smarthome/pull/442"},"issue":{"href":"https://api.github.com/repos/eclipse/smarthome/issues/442"},"comments":{"href":"https://api.github.com/repos/eclipse/smarthome/issues/442/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/442/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/442/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/smarthome/statuses/dcad83163f4f5f75715b1e5fe2a29ab8d75bca99"}}}}