{"action":"created","issue":{"url":"https://api.github.com/repos/loadfive/Knwl.js/issues/67","labels_url":"https://api.github.com/repos/loadfive/Knwl.js/issues/67/labels{/name}","comments_url":"https://api.github.com/repos/loadfive/Knwl.js/issues/67/comments","events_url":"https://api.github.com/repos/loadfive/Knwl.js/issues/67/events","html_url":"https://github.com/loadfive/Knwl.js/pull/67","id":85326581,"number":67,"title":"Node.js Support","user":{"login":"marshall007","id":877936,"avatar_url":"https://avatars.githubusercontent.com/u/877936?v=3","gravatar_id":"","url":"https://api.github.com/users/marshall007","html_url":"https://github.com/marshall007","followers_url":"https://api.github.com/users/marshall007/followers","following_url":"https://api.github.com/users/marshall007/following{/other_user}","gists_url":"https://api.github.com/users/marshall007/gists{/gist_id}","starred_url":"https://api.github.com/users/marshall007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marshall007/subscriptions","organizations_url":"https://api.github.com/users/marshall007/orgs","repos_url":"https://api.github.com/users/marshall007/repos","events_url":"https://api.github.com/users/marshall007/events{/privacy}","received_events_url":"https://api.github.com/users/marshall007/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-06-04T23:28:21Z","updated_at":"2015-06-05T03:59:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/loadfive/Knwl.js/pulls/67","html_url":"https://github.com/loadfive/Knwl.js/pull/67","diff_url":"https://github.com/loadfive/Knwl.js/pull/67.diff","patch_url":"https://github.com/loadfive/Knwl.js/pull/67.patch"},"body":"Sorry for the massive PR, but it was difficult to break this up into small pieces.\r\n\r\n#### Changes\r\n\r\n- Refactored each plugin into it's own module (no longer modifies globals)\r\n- Added test and build scripts (use `npm test` and `npm build` respectively)\r\n- Added Node.js support while maintaining browser support (using `browserify`)\r\n  - Running `npm build` writes the browser bundle to `./dist/knwl.js`\r\n- Running tests no longer requires globally installed npm packages\r\n- Plugins are now registered explicitly using `knwl.register(name, definition)`\r\n  - All default plugins are automatically registered for you\r\n- Renamed `knwl.parserList` to `knwl.plugins`\r\n\r\n#### Todo\r\n\r\n- Update docs to reflect these changes.\r\n- Make sure everything in the demo still works as expected.\r\n\r\nLet me know if you have any issues with what I've done here. I'm happy to update this PR."},"comment":{"url":"https://api.github.com/repos/loadfive/Knwl.js/issues/comments/109156037","html_url":"https://github.com/loadfive/Knwl.js/pull/67#issuecomment-109156037","issue_url":"https://api.github.com/repos/loadfive/Knwl.js/issues/67","id":109156037,"user":{"login":"loadfive","id":5818776,"avatar_url":"https://avatars.githubusercontent.com/u/5818776?v=3","gravatar_id":"","url":"https://api.github.com/users/loadfive","html_url":"https://github.com/loadfive","followers_url":"https://api.github.com/users/loadfive/followers","following_url":"https://api.github.com/users/loadfive/following{/other_user}","gists_url":"https://api.github.com/users/loadfive/gists{/gist_id}","starred_url":"https://api.github.com/users/loadfive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loadfive/subscriptions","organizations_url":"https://api.github.com/users/loadfive/orgs","repos_url":"https://api.github.com/users/loadfive/repos","events_url":"https://api.github.com/users/loadfive/events{/privacy}","received_events_url":"https://api.github.com/users/loadfive/received_events","type":"User","site_admin":false},"created_at":"2015-06-05T03:59:06Z","updated_at":"2015-06-05T03:59:06Z","body":"After running ```npm install```, the command ```npm test``` runs without errors. Sorry for that overlook. :-)\r\n\r\nOne down, but even after running ```npm install```, ```npm build``` fails to create the directory ```./dist``` if does not exist. If the directory does exist, it still seems to fail to create any files within.\r\n\r\n"}}