{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/build-tooltool/pulls/comments/27124161","id":27124161,"diff_hunk":"@@ -64,8 +73,36 @@ def setUp(self):\n             self.record_list.append(record)\n \n \n+class BaseManifestTest(BaseFileRecordTest):\n+\n+    def setUp(self):\n+        BaseFileRecordTest.setUp(self)\n+        self.sample_manifest = tooltool.Manifest([self.test_record])\n+        self.sample_manifest_file = 'manifest.tt'\n+        self.test_dir = 'test-dir'","path":"test_tooltool.py","position":55,"original_position":55,"commit_id":"d3f1ececaf5c96603168def921d8dad4931301de","original_commit_id":"d3f1ececaf5c96603168def921d8dad4931301de","user":{"login":"rail","id":42865,"avatar_url":"https://avatars.githubusercontent.com/u/42865?v=3","gravatar_id":"","url":"https://api.github.com/users/rail","html_url":"https://github.com/rail","followers_url":"https://api.github.com/users/rail/followers","following_url":"https://api.github.com/users/rail/following{/other_user}","gists_url":"https://api.github.com/users/rail/gists{/gist_id}","starred_url":"https://api.github.com/users/rail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rail/subscriptions","organizations_url":"https://api.github.com/users/rail/orgs","repos_url":"https://api.github.com/users/rail/repos","events_url":"https://api.github.com/users/rail/events{/privacy}","received_events_url":"https://api.github.com/users/rail/received_events","type":"User","site_admin":false},"body":"Maybe use a temporary directory instead? tempfile.mkdtemp(dir=\"/dev/shm\") (if available) would use ramdisk! :)","created_at":"2015-03-25T14:20:33Z","updated_at":"2015-03-25T14:20:33Z","html_url":"https://github.com/mozilla/build-tooltool/pull/6#discussion_r27124161","pull_request_url":"https://api.github.com/repos/mozilla/build-tooltool/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/mozilla/build-tooltool/pulls/comments/27124161"},"html":{"href":"https://github.com/mozilla/build-tooltool/pull/6#discussion_r27124161"},"pull_request":{"href":"https://api.github.com/repos/mozilla/build-tooltool/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/build-tooltool/pulls/6","id":31525699,"html_url":"https://github.com/mozilla/build-tooltool/pull/6","diff_url":"https://github.com/mozilla/build-tooltool/pull/6.diff","patch_url":"https://github.com/mozilla/build-tooltool/pull/6.patch","issue_url":"https://api.github.com/repos/mozilla/build-tooltool/issues/6","number":6,"state":"open","locked":false,"title":"Test and clean up the client","user":{"login":"djmitche","id":28673,"avatar_url":"https://avatars.githubusercontent.com/u/28673?v=3","gravatar_id":"","url":"https://api.github.com/users/djmitche","html_url":"https://github.com/djmitche","followers_url":"https://api.github.com/users/djmitche/followers","following_url":"https://api.github.com/users/djmitche/following{/other_user}","gists_url":"https://api.github.com/users/djmitche/gists{/gist_id}","starred_url":"https://api.github.com/users/djmitche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djmitche/subscriptions","organizations_url":"https://api.github.com/users/djmitche/orgs","repos_url":"https://api.github.com/users/djmitche/repos","events_url":"https://api.github.com/users/djmitche/events{/privacy}","received_events_url":"https://api.github.com/users/djmitche/received_events","type":"User","site_admin":false},"body":"This gets tooltool.py to 100% coverage.\r\n\r\nWell, sort of -- the bits that are both hard to test and destined for the bitbucket with the ongoing rewrite are tagged with 'pragma: no cover'.\r\n\r\nThis also includes a bunch of bug fixes and minor refactors in tooltool.py:\r\n\r\n * fail on any path info in filenames, regardless of platform\r\n * `repr` the size as an integer, not a string\r\n * fix manifest comparison to compare sorted manifests\r\n * don't try to sort manifests while manipulating them\r\n * don't attempt to re-validate files in `add_files`, as they may not be in the cwd and thus validation will fail\r\n * return false from `untar_file` if the xz untar operation fails\r\n * remove fetched temp files if they fail verification\r\n * simplify `purge`\r\n * refactor cli implementation to ease testing\r\n * indicate that only sha512 algorithm is supported","created_at":"2015-03-19T14:04:06Z","updated_at":"2015-03-25T14:20:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2eb7e73ccc5412d839a875d44bc5263a42f26ff7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/build-tooltool/pulls/6/commits","review_comments_url":"https://api.github.com/repos/mozilla/build-tooltool/pulls/6/comments","review_comment_url":"https://api.github.com/repos/mozilla/build-tooltool/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/build-tooltool/issues/6/comments","statuses_url":"https://api.github.com/repos/mozilla/build-tooltool/statuses/d3f1ececaf5c96603168def921d8dad4931301de","head":{"label":"djmitche:client-cleanup","ref":"client-cleanup","sha":"d3f1ececaf5c96603168def921d8dad4931301de","user":{"login":"djmitche","id":28673,"avatar_url":"https://avatars.githubusercontent.com/u/28673?v=3","gravatar_id":"","url":"https://api.github.com/users/djmitche","html_url":"https://github.com/djmitche","followers_url":"https://api.github.com/users/djmitche/followers","following_url":"https://api.github.com/users/djmitche/following{/other_user}","gists_url":"https://api.github.com/users/djmitche/gists{/gist_id}","starred_url":"https://api.github.com/users/djmitche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djmitche/subscriptions","organizations_url":"https://api.github.com/users/djmitche/orgs","repos_url":"https://api.github.com/users/djmitche/repos","events_url":"https://api.github.com/users/djmitche/events{/privacy}","received_events_url":"https://api.github.com/users/djmitche/received_events","type":"User","site_admin":false},"repo":{"id":31431158,"name":"build-tooltool","full_name":"djmitche/build-tooltool","owner":{"login":"djmitche","id":28673,"avatar_url":"https://avatars.githubusercontent.com/u/28673?v=3","gravatar_id":"","url":"https://api.github.com/users/djmitche","html_url":"https://github.com/djmitche","followers_url":"https://api.github.com/users/djmitche/followers","following_url":"https://api.github.com/users/djmitche/following{/other_user}","gists_url":"https://api.github.com/users/djmitche/gists{/gist_id}","starred_url":"https://api.github.com/users/djmitche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djmitche/subscriptions","organizations_url":"https://api.github.com/users/djmitche/orgs","repos_url":"https://api.github.com/users/djmitche/repos","events_url":"https://api.github.com/users/djmitche/events{/privacy}","received_events_url":"https://api.github.com/users/djmitche/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/djmitche/build-tooltool","description":"A tool for fetching binary artifacts for builds and tests","fork":true,"url":"https://api.github.com/repos/djmitche/build-tooltool","forks_url":"https://api.github.com/repos/djmitche/build-tooltool/forks","keys_url":"https://api.github.com/repos/djmitche/build-tooltool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/djmitche/build-tooltool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/djmitche/build-tooltool/teams","hooks_url":"https://api.github.com/repos/djmitche/build-tooltool/hooks","issue_events_url":"https://api.github.com/repos/djmitche/build-tooltool/issues/events{/number}","events_url":"https://api.github.com/repos/djmitche/build-tooltool/events","assignees_url":"https://api.github.com/repos/djmitche/build-tooltool/assignees{/user}","branches_url":"https://api.github.com/repos/djmitche/build-tooltool/branches{/branch}","tags_url":"https://api.github.com/repos/djmitche/build-tooltool/tags","blobs_url":"https://api.github.com/repos/djmitche/build-tooltool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/djmitche/build-tooltool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/djmitche/build-tooltool/git/refs{/sha}","trees_url":"https://api.github.com/repos/djmitche/build-tooltool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/djmitche/build-tooltool/statuses/{sha}","languages_url":"https://api.github.com/repos/djmitche/build-tooltool/languages","stargazers_url":"https://api.github.com/repos/djmitche/build-tooltool/stargazers","contributors_url":"https://api.github.com/repos/djmitche/build-tooltool/contributors","subscribers_url":"https://api.github.com/repos/djmitche/build-tooltool/subscribers","subscription_url":"https://api.github.com/repos/djmitche/build-tooltool/subscription","commits_url":"https://api.github.com/repos/djmitche/build-tooltool/commits{/sha}","git_commits_url":"https://api.github.com/repos/djmitche/build-tooltool/git/commits{/sha}","comments_url":"https://api.github.com/repos/djmitche/build-tooltool/comments{/number}","issue_comment_url":"https://api.github.com/repos/djmitche/build-tooltool/issues/comments{/number}","contents_url":"https://api.github.com/repos/djmitche/build-tooltool/contents/{+path}","compare_url":"https://api.github.com/repos/djmitche/build-tooltool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/djmitche/build-tooltool/merges","archive_url":"https://api.github.com/repos/djmitche/build-tooltool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/djmitche/build-tooltool/downloads","issues_url":"https://api.github.com/repos/djmitche/build-tooltool/issues{/number}","pulls_url":"https://api.github.com/repos/djmitche/build-tooltool/pulls{/number}","milestones_url":"https://api.github.com/repos/djmitche/build-tooltool/milestones{/number}","notifications_url":"https://api.github.com/repos/djmitche/build-tooltool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/djmitche/build-tooltool/labels{/name}","releases_url":"https://api.github.com/repos/djmitche/build-tooltool/releases{/id}","created_at":"2015-02-27T17:37:51Z","updated_at":"2015-03-10T01:34:30Z","pushed_at":"2015-03-25T13:33:17Z","git_url":"git://github.com/djmitche/build-tooltool.git","ssh_url":"git@github.com:djmitche/build-tooltool.git","clone_url":"https://github.com/djmitche/build-tooltool.git","svn_url":"https://github.com/djmitche/build-tooltool","homepage":"","size":481,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"bf2dac4d4c4d57f3a75d60591920c97a6a7c97a7","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":9241734,"name":"build-tooltool","full_name":"mozilla/build-tooltool","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/build-tooltool","description":"A tool for fetching binary artifacts for builds and tests","fork":true,"url":"https://api.github.com/repos/mozilla/build-tooltool","forks_url":"https://api.github.com/repos/mozilla/build-tooltool/forks","keys_url":"https://api.github.com/repos/mozilla/build-tooltool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/build-tooltool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/build-tooltool/teams","hooks_url":"https://api.github.com/repos/mozilla/build-tooltool/hooks","issue_events_url":"https://api.github.com/repos/mozilla/build-tooltool/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/build-tooltool/events","assignees_url":"https://api.github.com/repos/mozilla/build-tooltool/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/build-tooltool/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/build-tooltool/tags","blobs_url":"https://api.github.com/repos/mozilla/build-tooltool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/build-tooltool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/build-tooltool/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/build-tooltool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/build-tooltool/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/build-tooltool/languages","stargazers_url":"https://api.github.com/repos/mozilla/build-tooltool/stargazers","contributors_url":"https://api.github.com/repos/mozilla/build-tooltool/contributors","subscribers_url":"https://api.github.com/repos/mozilla/build-tooltool/subscribers","subscription_url":"https://api.github.com/repos/mozilla/build-tooltool/subscription","commits_url":"https://api.github.com/repos/mozilla/build-tooltool/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/build-tooltool/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/build-tooltool/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/build-tooltool/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/build-tooltool/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/build-tooltool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/build-tooltool/merges","archive_url":"https://api.github.com/repos/mozilla/build-tooltool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/build-tooltool/downloads","issues_url":"https://api.github.com/repos/mozilla/build-tooltool/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/build-tooltool/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/build-tooltool/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/build-tooltool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/build-tooltool/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/build-tooltool/releases{/id}","created_at":"2013-04-05T13:27:29Z","updated_at":"2015-03-24T18:28:07Z","pushed_at":"2015-03-25T00:57:16Z","git_url":"git://github.com/mozilla/build-tooltool.git","ssh_url":"git@github.com:mozilla/build-tooltool.git","clone_url":"https://github.com/mozilla/build-tooltool.git","svn_url":"https://github.com/mozilla/build-tooltool","homepage":"","size":501,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/build-tooltool/pulls/6"},"html":{"href":"https://github.com/mozilla/build-tooltool/pull/6"},"issue":{"href":"https://api.github.com/repos/mozilla/build-tooltool/issues/6"},"comments":{"href":"https://api.github.com/repos/mozilla/build-tooltool/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/build-tooltool/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/build-tooltool/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/build-tooltool/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/build-tooltool/statuses/d3f1ececaf5c96603168def921d8dad4931301de"}}}}