{"action":"closed","issue":{"url":"https://api.github.com/repos/pinax/pinax-stripe/issues/193","labels_url":"https://api.github.com/repos/pinax/pinax-stripe/issues/193/labels{/name}","comments_url":"https://api.github.com/repos/pinax/pinax-stripe/issues/193/comments","events_url":"https://api.github.com/repos/pinax/pinax-stripe/issues/193/events","html_url":"https://github.com/pinax/pinax-stripe/issues/193","id":118433958,"number":193,"title":"Refactor Tests","user":{"login":"paltman","id":1192,"avatar_url":"https://avatars.githubusercontent.com/u/1192?v=3","gravatar_id":"","url":"https://api.github.com/users/paltman","html_url":"https://github.com/paltman","followers_url":"https://api.github.com/users/paltman/followers","following_url":"https://api.github.com/users/paltman/following{/other_user}","gists_url":"https://api.github.com/users/paltman/gists{/gist_id}","starred_url":"https://api.github.com/users/paltman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paltman/subscriptions","organizations_url":"https://api.github.com/users/paltman/orgs","repos_url":"https://api.github.com/users/paltman/repos","events_url":"https://api.github.com/users/paltman/events{/privacy}","received_events_url":"https://api.github.com/users/paltman/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-11-23T17:44:46Z","updated_at":"2015-11-28T04:55:13Z","closed_at":"2015-11-28T04:55:13Z","body":"The state of tests are a bit of a mess and hard to follow. I'm concerned about maintenance and there are some \"test smells\". There are tests requiring way too much setup which therefore require a lot of test data to maintain and/or have too much mocking and reliance on behavior verification instead of the more pure state verification style of testing.\r\n\r\nThis could indicate that the APIs are poorly designed and I put them on the table for overhaul (even given that I just did a massive overhaul). This needs to be done before we cut a 2.0 release as I want to leave the door open for changing APIs around.\r\n\r\nFor now, I'm going to focus on getting more complete coverage first, and then take a step back and review things holistically but I wanted to log this issue as way to welcome review and feedback of the work going on with `master` specifically with the tests and mocking and API design in `pinax.stripe.actions.*`.\r\n\r\n"}}