{"action":"created","issue":{"url":"https://api.github.com/repos/tleunen/brfs-htmlmin/issues/2","labels_url":"https://api.github.com/repos/tleunen/brfs-htmlmin/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/tleunen/brfs-htmlmin/issues/2/comments","events_url":"https://api.github.com/repos/tleunen/brfs-htmlmin/issues/2/events","html_url":"https://github.com/tleunen/brfs-htmlmin/pull/2","id":95688862,"number":2,"title":"support for regular expressions in package.json config","user":{"login":"stryju","id":25367,"avatar_url":"https://avatars.githubusercontent.com/u/25367?v=3","gravatar_id":"","url":"https://api.github.com/users/stryju","html_url":"https://github.com/stryju","followers_url":"https://api.github.com/users/stryju/followers","following_url":"https://api.github.com/users/stryju/following{/other_user}","gists_url":"https://api.github.com/users/stryju/gists{/gist_id}","starred_url":"https://api.github.com/users/stryju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stryju/subscriptions","organizations_url":"https://api.github.com/users/stryju/orgs","repos_url":"https://api.github.com/users/stryju/repos","events_url":"https://api.github.com/users/stryju/events{/privacy}","received_events_url":"https://api.github.com/users/stryju/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-07-17T16:08:29Z","updated_at":"2015-07-22T00:03:44Z","closed_at":"2015-07-18T22:11:19Z","pull_request":{"url":"https://api.github.com/repos/tleunen/brfs-htmlmin/pulls/2","html_url":"https://github.com/tleunen/brfs-htmlmin/pull/2","diff_url":"https://github.com/tleunen/brfs-htmlmin/pull/2.diff","patch_url":"https://github.com/tleunen/brfs-htmlmin/pull/2.patch"},"body":"one of the features of `browserify` is being be able to provide the config for transforms in `package.json`\r\n\r\nnow, some of the options in `html-minifier` *require* regular expressions:\r\n- `ignoreCustomComments`\r\n- `customAttrAssign`\r\n- `customAttrSurround`\r\n- `customAttrCollapse`\r\n\r\nand to be able to leverage that power of `browserify`, aforementioned in package.json need to be strings\r\n\r\nthis PR converts those options as `RegExp`, if needed\r\n\r\nso my `package.json` could look like:\r\n\r\n```json\r\n{\r\n  \"browserify\": {\r\n    \"transform\": [\r\n      [\r\n        \"brfs-htmlmin\",\r\n        {\r\n          \"minify\": {\r\n            \"removeEmptyAttributes\": false,\r\n            \"customAttrCollapse\": \"^ng\\\\-.+\"\r\n          }\r\n        }\r\n      ]\r\n    ]\r\n  }\r\n}\r\n```\r\n\r\n---\r\n\r\nalso, bumped `html-minifier` to 0.7.2"},"comment":{"url":"https://api.github.com/repos/tleunen/brfs-htmlmin/issues/comments/123513099","html_url":"https://github.com/tleunen/brfs-htmlmin/pull/2#issuecomment-123513099","issue_url":"https://api.github.com/repos/tleunen/brfs-htmlmin/issues/2","id":123513099,"user":{"login":"tleunen","id":1972567,"avatar_url":"https://avatars.githubusercontent.com/u/1972567?v=3","gravatar_id":"","url":"https://api.github.com/users/tleunen","html_url":"https://github.com/tleunen","followers_url":"https://api.github.com/users/tleunen/followers","following_url":"https://api.github.com/users/tleunen/following{/other_user}","gists_url":"https://api.github.com/users/tleunen/gists{/gist_id}","starred_url":"https://api.github.com/users/tleunen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tleunen/subscriptions","organizations_url":"https://api.github.com/users/tleunen/orgs","repos_url":"https://api.github.com/users/tleunen/repos","events_url":"https://api.github.com/users/tleunen/events{/privacy}","received_events_url":"https://api.github.com/users/tleunen/received_events","type":"User","site_admin":false},"created_at":"2015-07-22T00:03:44Z","updated_at":"2015-07-22T00:03:44Z","body":"hmm.. Feel free to send a PR for that, but I'm not sure we need to specify that in this repo since it's something specific to html-minifier. There's already a mention to check the options on that repo."}}