{"action":"created","issue":{"url":"https://api.github.com/repos/Lukasa/hyper/issues/164","labels_url":"https://api.github.com/repos/Lukasa/hyper/issues/164/labels{/name}","comments_url":"https://api.github.com/repos/Lukasa/hyper/issues/164/comments","events_url":"https://api.github.com/repos/Lukasa/hyper/issues/164/events","html_url":"https://github.com/Lukasa/hyper/pull/164","id":103981480,"number":164,"title":"Add proxy support","user":{"login":"fredthomsen","id":880064,"avatar_url":"https://avatars.githubusercontent.com/u/880064?v=3","gravatar_id":"","url":"https://api.github.com/users/fredthomsen","html_url":"https://github.com/fredthomsen","followers_url":"https://api.github.com/users/fredthomsen/followers","following_url":"https://api.github.com/users/fredthomsen/following{/other_user}","gists_url":"https://api.github.com/users/fredthomsen/gists{/gist_id}","starred_url":"https://api.github.com/users/fredthomsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredthomsen/subscriptions","organizations_url":"https://api.github.com/users/fredthomsen/orgs","repos_url":"https://api.github.com/users/fredthomsen/repos","events_url":"https://api.github.com/users/fredthomsen/events{/privacy}","received_events_url":"https://api.github.com/users/fredthomsen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-08-31T04:08:46Z","updated_at":"2015-09-17T08:07:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Lukasa/hyper/pulls/164","html_url":"https://github.com/Lukasa/hyper/pull/164","diff_url":"https://github.com/Lukasa/hyper/pull/164.diff","patch_url":"https://github.com/Lukasa/hyper/pull/164.patch"},"body":"Just making sure I am on the right track. Test cases are coming."},"comment":{"url":"https://api.github.com/repos/Lukasa/hyper/issues/comments/140998593","html_url":"https://github.com/Lukasa/hyper/pull/164#issuecomment-140998593","issue_url":"https://api.github.com/repos/Lukasa/hyper/issues/164","id":140998593,"user":{"login":"Lukasa","id":1382556,"avatar_url":"https://avatars.githubusercontent.com/u/1382556?v=3","gravatar_id":"","url":"https://api.github.com/users/Lukasa","html_url":"https://github.com/Lukasa","followers_url":"https://api.github.com/users/Lukasa/followers","following_url":"https://api.github.com/users/Lukasa/following{/other_user}","gists_url":"https://api.github.com/users/Lukasa/gists{/gist_id}","starred_url":"https://api.github.com/users/Lukasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lukasa/subscriptions","organizations_url":"https://api.github.com/users/Lukasa/orgs","repos_url":"https://api.github.com/users/Lukasa/repos","events_url":"https://api.github.com/users/Lukasa/events{/privacy}","received_events_url":"https://api.github.com/users/Lukasa/received_events","type":"User","site_admin":false},"created_at":"2015-09-17T08:07:00Z","updated_at":"2015-09-17T08:07:00Z","body":"I think the test is overcomplicated. I don't think we need to run something that amounts to an actual proxy: we just need to run something that knows it is pretending to be a proxy. What we really want to test is that, when we set up proxy values, we connect to the right place and then that we format the data correctly. This doesn't require a (fragile) socket proxy, just requires the \"server\" side of the connection to look for some slightly different stuff."}}