{"action":"created","comment":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/comments/30838637","id":30838637,"diff_hunk":"@@ -76,7 +78,8 @@ function ($scope, $modalInstance, caskFocusManager, Widget) {\n       });\n       $scope.currentBoard.addWidget(widgets);\n     } else {\n-      $scope.model.color = classes[(generateHash($scope.model.metric.name) * 13) % classes.length];\n+      $scope.model.settings = {};\n+      $scope.model.settings.color = classes[(generateHash($scope.model.metric.name) * 13) % classes.length];","path":"cdap-ui/app/features/dashboard/controllers/addwdgt-ctrl.js","position":17,"original_position":17,"commit_id":"be63d32b2a49f4d790a4f87c618c94a17cdfb9c6","original_commit_id":"be63d32b2a49f4d790a4f87c618c94a17cdfb9c6","user":{"login":"elfenheart","id":4398643,"avatar_url":"https://avatars.githubusercontent.com/u/4398643?v=3","gravatar_id":"","url":"https://api.github.com/users/elfenheart","html_url":"https://github.com/elfenheart","followers_url":"https://api.github.com/users/elfenheart/followers","following_url":"https://api.github.com/users/elfenheart/following{/other_user}","gists_url":"https://api.github.com/users/elfenheart/gists{/gist_id}","starred_url":"https://api.github.com/users/elfenheart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elfenheart/subscriptions","organizations_url":"https://api.github.com/users/elfenheart/orgs","repos_url":"https://api.github.com/users/elfenheart/repos","events_url":"https://api.github.com/users/elfenheart/events{/privacy}","received_events_url":"https://api.github.com/users/elfenheart/received_events","type":"User","site_admin":false},"body":"Same comment as before","created_at":"2015-05-21T19:35:15Z","updated_at":"2015-05-21T19:35:15Z","html_url":"https://github.com/caskdata/cdap/pull/2707#discussion_r30838637","pull_request_url":"https://api.github.com/repos/caskdata/cdap/pulls/2707","_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments/30838637"},"html":{"href":"https://github.com/caskdata/cdap/pull/2707#discussion_r30838637"},"pull_request":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/2707"}}},"pull_request":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/2707","id":35566378,"html_url":"https://github.com/caskdata/cdap/pull/2707","diff_url":"https://github.com/caskdata/cdap/pull/2707.diff","patch_url":"https://github.com/caskdata/cdap/pull/2707.patch","issue_url":"https://api.github.com/repos/caskdata/cdap/issues/2707","number":2707,"state":"open","locked":false,"title":"Fix/ui widget organization","user":{"login":"ajainarayanan","id":1452845,"avatar_url":"https://avatars.githubusercontent.com/u/1452845?v=3","gravatar_id":"","url":"https://api.github.com/users/ajainarayanan","html_url":"https://github.com/ajainarayanan","followers_url":"https://api.github.com/users/ajainarayanan/followers","following_url":"https://api.github.com/users/ajainarayanan/following{/other_user}","gists_url":"https://api.github.com/users/ajainarayanan/gists{/gist_id}","starred_url":"https://api.github.com/users/ajainarayanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajainarayanan/subscriptions","organizations_url":"https://api.github.com/users/ajainarayanan/orgs","repos_url":"https://api.github.com/users/ajainarayanan/repos","events_url":"https://api.github.com/users/ajainarayanan/events{/privacy}","received_events_url":"https://api.github.com/users/ajainarayanan/received_events","type":"User","site_admin":false},"body":"- Re-organizes code to separate out service layer and utility layer and controller\r\n- Reduces size of Widget factory (Should have only additive things, say managing metrics, add or remove them, like a settings for the underlying chart)\r\n- Creates a ChartsHelper factory to group all utility function required for constructing query and post-processing data received from backend.\r\n- The aim of the above two changes is to do post-processing of data in one place (rather than at Widget Factory and C3WidgetController and in Charts directive) and try to reduce #of watchers used by dashboard.\r\n- Temporarily Modify C3 library to avoid listening on Window.resize (which gets called like a 256 times on each resize :smile: ) There is an associated PR already open (https://github.com/masayuki0812/c3/pull/860). Once this is merged we can remove this and directly fetch from bower.","created_at":"2015-05-16T06:07:25Z","updated_at":"2015-05-21T19:35:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc92c1805e17c1069fa28a08563227e0707ee3d8","assignee":null,"milestone":{"url":"https://api.github.com/repos/caskdata/cdap/milestones/6","html_url":"https://github.com/caskdata/cdap/milestones/3.1.0","labels_url":"https://api.github.com/repos/caskdata/cdap/milestones/6/labels","id":1099347,"number":6,"title":"3.1.0","description":null,"creator":{"login":"jwang47","id":1084704,"avatar_url":"https://avatars.githubusercontent.com/u/1084704?v=3","gravatar_id":"","url":"https://api.github.com/users/jwang47","html_url":"https://github.com/jwang47","followers_url":"https://api.github.com/users/jwang47/followers","following_url":"https://api.github.com/users/jwang47/following{/other_user}","gists_url":"https://api.github.com/users/jwang47/gists{/gist_id}","starred_url":"https://api.github.com/users/jwang47/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwang47/subscriptions","organizations_url":"https://api.github.com/users/jwang47/orgs","repos_url":"https://api.github.com/users/jwang47/repos","events_url":"https://api.github.com/users/jwang47/events{/privacy}","received_events_url":"https://api.github.com/users/jwang47/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":9,"state":"open","created_at":"2015-05-06T23:17:15Z","updated_at":"2015-05-20T22:48:46Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/caskdata/cdap/pulls/2707/commits","review_comments_url":"https://api.github.com/repos/caskdata/cdap/pulls/2707/comments","review_comment_url":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caskdata/cdap/issues/2707/comments","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/be63d32b2a49f4d790a4f87c618c94a17cdfb9c6","head":{"label":"caskdata:fix/ui-widget-organization","ref":"fix/ui-widget-organization","sha":"be63d32b2a49f4d790a4f87c618c94a17cdfb9c6","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","created_at":"2014-08-02T09:00:10Z","updated_at":"2015-05-16T23:27:39Z","pushed_at":"2015-05-21T19:28:34Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"http://cdap.io","size":876499,"stargazers_count":47,"watchers_count":47,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":18,"mirror_url":null,"open_issues_count":15,"forks":18,"open_issues":15,"watchers":47,"default_branch":"develop"}},"base":{"label":"caskdata:feature/ui-gridster","ref":"feature/ui-gridster","sha":"0c07623e7a1eb03a66ed96ea1f2b8940b3211c3e","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","created_at":"2014-08-02T09:00:10Z","updated_at":"2015-05-16T23:27:39Z","pushed_at":"2015-05-21T19:28:34Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"http://cdap.io","size":876499,"stargazers_count":47,"watchers_count":47,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":18,"mirror_url":null,"open_issues_count":15,"forks":18,"open_issues":15,"watchers":47,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/2707"},"html":{"href":"https://github.com/caskdata/cdap/pull/2707"},"issue":{"href":"https://api.github.com/repos/caskdata/cdap/issues/2707"},"comments":{"href":"https://api.github.com/repos/caskdata/cdap/issues/2707/comments"},"review_comments":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/2707/comments"},"review_comment":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/2707/commits"},"statuses":{"href":"https://api.github.com/repos/caskdata/cdap/statuses/be63d32b2a49f4d790a4f87c618c94a17cdfb9c6"}}}}