{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/26809012","id":26809012,"diff_hunk":"@@ -297,7 +300,24 @@ func (r *Session) PutV2ImageManifest(ep *Endpoint, imageName, tagName string, ma\n \t\treturn \"\", utils.NewHTTPRequestError(fmt.Sprintf(\"Server error: %d trying to push %s:%s manifest\", res.StatusCode, imageName, tagName), res)\n \t}\n \n-\treturn res.Header.Get(DockerDigestHeader), nil\n+\thdrDigest, err := digest.ParseDigest(res.Header.Get(DockerDigestHeader))","path":"registry/session_v2.go","position":54,"original_position":54,"commit_id":"ebd1c760343bb4ebe6e48721f748db8cf180b39c","original_commit_id":"ebd1c760343bb4ebe6e48721f748db8cf180b39c","user":{"login":"jlhawn","id":1441929,"avatar_url":"https://avatars.githubusercontent.com/u/1441929?v=3","gravatar_id":"","url":"https://api.github.com/users/jlhawn","html_url":"https://github.com/jlhawn","followers_url":"https://api.github.com/users/jlhawn/followers","following_url":"https://api.github.com/users/jlhawn/following{/other_user}","gists_url":"https://api.github.com/users/jlhawn/gists{/gist_id}","starred_url":"https://api.github.com/users/jlhawn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlhawn/subscriptions","organizations_url":"https://api.github.com/users/jlhawn/orgs","repos_url":"https://api.github.com/users/jlhawn/repos","events_url":"https://api.github.com/users/jlhawn/events{/privacy}","received_events_url":"https://api.github.com/users/jlhawn/received_events","type":"User","site_admin":false},"body":"then makes sure that docker got the same digest as the registry.","created_at":"2015-03-19T23:47:11Z","updated_at":"2015-03-19T23:47:11Z","html_url":"https://github.com/docker/docker/pull/11457#discussion_r26809012","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/11457","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/26809012"},"html":{"href":"https://github.com/docker/docker/pull/11457#discussion_r26809012"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/11457"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/11457","id":31404233,"html_url":"https://github.com/docker/docker/pull/11457","diff_url":"https://github.com/docker/docker/pull/11457.diff","patch_url":"https://github.com/docker/docker/pull/11457.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/11457","number":11457,"state":"open","locked":false,"title":"Add verification of image manifest digests on v2 push/pull","user":{"login":"jlhawn","id":1441929,"avatar_url":"https://avatars.githubusercontent.com/u/1441929?v=3","gravatar_id":"","url":"https://api.github.com/users/jlhawn","html_url":"https://github.com/jlhawn","followers_url":"https://api.github.com/users/jlhawn/followers","following_url":"https://api.github.com/users/jlhawn/following{/other_user}","gists_url":"https://api.github.com/users/jlhawn/gists{/gist_id}","starred_url":"https://api.github.com/users/jlhawn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlhawn/subscriptions","organizations_url":"https://api.github.com/users/jlhawn/orgs","repos_url":"https://api.github.com/users/jlhawn/repos","events_url":"https://api.github.com/users/jlhawn/events{/privacy}","received_events_url":"https://api.github.com/users/jlhawn/received_events","type":"User","site_admin":false},"body":"~~Depends on https://github.com/docker/docker/pull/11271~~","created_at":"2015-03-18T06:47:34Z","updated_at":"2015-03-19T23:47:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bc8d55feaacb593b2d9c260783248707ba96d259","assignee":null,"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/37","html_url":"https://github.com/docker/docker/milestones/1.6.0","labels_url":"https://api.github.com/repos/docker/docker/milestones/37/labels","id":952335,"number":37,"title":"1.6.0","description":"","creator":{"login":"crosbymichael","id":749551,"avatar_url":"https://avatars.githubusercontent.com/u/749551?v=3","gravatar_id":"","url":"https://api.github.com/users/crosbymichael","html_url":"https://github.com/crosbymichael","followers_url":"https://api.github.com/users/crosbymichael/followers","following_url":"https://api.github.com/users/crosbymichael/following{/other_user}","gists_url":"https://api.github.com/users/crosbymichael/gists{/gist_id}","starred_url":"https://api.github.com/users/crosbymichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosbymichael/subscriptions","organizations_url":"https://api.github.com/users/crosbymichael/orgs","repos_url":"https://api.github.com/users/crosbymichael/repos","events_url":"https://api.github.com/users/crosbymichael/events{/privacy}","received_events_url":"https://api.github.com/users/crosbymichael/received_events","type":"User","site_admin":false},"open_issues":27,"closed_issues":56,"state":"open","created_at":"2015-01-26T23:40:13Z","updated_at":"2015-03-19T23:12:18Z","due_on":"2015-03-23T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/docker/docker/pulls/11457/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/11457/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/11457/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/ebd1c760343bb4ebe6e48721f748db8cf180b39c","head":{"label":"jlhawn:pull_by_digest_verify","ref":"pull_by_digest_verify","sha":"ebd1c760343bb4ebe6e48721f748db8cf180b39c","user":{"login":"jlhawn","id":1441929,"avatar_url":"https://avatars.githubusercontent.com/u/1441929?v=3","gravatar_id":"","url":"https://api.github.com/users/jlhawn","html_url":"https://github.com/jlhawn","followers_url":"https://api.github.com/users/jlhawn/followers","following_url":"https://api.github.com/users/jlhawn/following{/other_user}","gists_url":"https://api.github.com/users/jlhawn/gists{/gist_id}","starred_url":"https://api.github.com/users/jlhawn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlhawn/subscriptions","organizations_url":"https://api.github.com/users/jlhawn/orgs","repos_url":"https://api.github.com/users/jlhawn/repos","events_url":"https://api.github.com/users/jlhawn/events{/privacy}","received_events_url":"https://api.github.com/users/jlhawn/received_events","type":"User","site_admin":false},"repo":{"id":14341765,"name":"docker","full_name":"jlhawn/docker","owner":{"login":"jlhawn","id":1441929,"avatar_url":"https://avatars.githubusercontent.com/u/1441929?v=3","gravatar_id":"","url":"https://api.github.com/users/jlhawn","html_url":"https://github.com/jlhawn","followers_url":"https://api.github.com/users/jlhawn/followers","following_url":"https://api.github.com/users/jlhawn/following{/other_user}","gists_url":"https://api.github.com/users/jlhawn/gists{/gist_id}","starred_url":"https://api.github.com/users/jlhawn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlhawn/subscriptions","organizations_url":"https://api.github.com/users/jlhawn/orgs","repos_url":"https://api.github.com/users/jlhawn/repos","events_url":"https://api.github.com/users/jlhawn/events{/privacy}","received_events_url":"https://api.github.com/users/jlhawn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jlhawn/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/jlhawn/docker","forks_url":"https://api.github.com/repos/jlhawn/docker/forks","keys_url":"https://api.github.com/repos/jlhawn/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jlhawn/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jlhawn/docker/teams","hooks_url":"https://api.github.com/repos/jlhawn/docker/hooks","issue_events_url":"https://api.github.com/repos/jlhawn/docker/issues/events{/number}","events_url":"https://api.github.com/repos/jlhawn/docker/events","assignees_url":"https://api.github.com/repos/jlhawn/docker/assignees{/user}","branches_url":"https://api.github.com/repos/jlhawn/docker/branches{/branch}","tags_url":"https://api.github.com/repos/jlhawn/docker/tags","blobs_url":"https://api.github.com/repos/jlhawn/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jlhawn/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jlhawn/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/jlhawn/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jlhawn/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/jlhawn/docker/languages","stargazers_url":"https://api.github.com/repos/jlhawn/docker/stargazers","contributors_url":"https://api.github.com/repos/jlhawn/docker/contributors","subscribers_url":"https://api.github.com/repos/jlhawn/docker/subscribers","subscription_url":"https://api.github.com/repos/jlhawn/docker/subscription","commits_url":"https://api.github.com/repos/jlhawn/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/jlhawn/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/jlhawn/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/jlhawn/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/jlhawn/docker/contents/{+path}","compare_url":"https://api.github.com/repos/jlhawn/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jlhawn/docker/merges","archive_url":"https://api.github.com/repos/jlhawn/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jlhawn/docker/downloads","issues_url":"https://api.github.com/repos/jlhawn/docker/issues{/number}","pulls_url":"https://api.github.com/repos/jlhawn/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/jlhawn/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/jlhawn/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jlhawn/docker/labels{/name}","releases_url":"https://api.github.com/repos/jlhawn/docker/releases{/id}","created_at":"2013-11-12T18:50:12Z","updated_at":"2015-03-10T19:50:36Z","pushed_at":"2015-03-19T22:32:52Z","git_url":"git://github.com/jlhawn/docker.git","ssh_url":"git@github.com:jlhawn/docker.git","clone_url":"https://github.com/jlhawn/docker.git","svn_url":"https://github.com/jlhawn/docker","homepage":"http://www.docker.io","size":46802,"stargazers_count":5,"watchers_count":5,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":5,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"455a272aef4e109ce57c20f9ea224e4d4b32ece7","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-03-19T23:25:11Z","pushed_at":"2015-03-19T23:30:26Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":154519,"stargazers_count":19976,"watchers_count":19976,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4203,"mirror_url":null,"open_issues_count":796,"forks":4203,"open_issues":796,"watchers":19976,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/11457"},"html":{"href":"https://github.com/docker/docker/pull/11457"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/11457"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/11457/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/11457/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/11457/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/ebd1c760343bb4ebe6e48721f748db8cf180b39c"}}}}