{"action":"created","comment":{"url":"https://api.github.com/repos/lotus/helpers/pulls/comments/35570009","id":35570009,"diff_hunk":"@@ -6,6 +6,20 @@ module HtmlHelper\n       # @since 0.1.0\n       # @api private\n       class EmptyHtmlNode\n+        # List of attributes that get special treatment when rendering.\n+        # @see http://www.w3.org/html/wg/drafts/html/master/infrastructure.html#boolean-attribute\n+        # @since 0.2.?","path":"lib/lotus/helpers/html_helper/empty_html_node.rb","position":6,"original_position":6,"commit_id":"3110fad715ded015ae8f9664ab8caae4609c1751","original_commit_id":"3110fad715ded015ae8f9664ab8caae4609c1751","user":{"login":"joneslee85","id":135605,"avatar_url":"https://avatars.githubusercontent.com/u/135605?v=3","gravatar_id":"","url":"https://api.github.com/users/joneslee85","html_url":"https://github.com/joneslee85","followers_url":"https://api.github.com/users/joneslee85/followers","following_url":"https://api.github.com/users/joneslee85/following{/other_user}","gists_url":"https://api.github.com/users/joneslee85/gists{/gist_id}","starred_url":"https://api.github.com/users/joneslee85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joneslee85/subscriptions","organizations_url":"https://api.github.com/users/joneslee85/orgs","repos_url":"https://api.github.com/users/joneslee85/repos","events_url":"https://api.github.com/users/joneslee85/events{/privacy}","received_events_url":"https://api.github.com/users/joneslee85/received_events","type":"User","site_admin":false},"body":"please leave it as x.x.x for us","created_at":"2015-07-27T18:34:35Z","updated_at":"2015-07-27T18:34:35Z","html_url":"https://github.com/lotus/helpers/pull/26#discussion_r35570009","pull_request_url":"https://api.github.com/repos/lotus/helpers/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/lotus/helpers/pulls/comments/35570009"},"html":{"href":"https://github.com/lotus/helpers/pull/26#discussion_r35570009"},"pull_request":{"href":"https://api.github.com/repos/lotus/helpers/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/lotus/helpers/pulls/26","id":40898533,"html_url":"https://github.com/lotus/helpers/pull/26","diff_url":"https://github.com/lotus/helpers/pull/26.diff","patch_url":"https://github.com/lotus/helpers/pull/26.patch","issue_url":"https://api.github.com/repos/lotus/helpers/issues/26","number":26,"state":"open","locked":false,"title":"Added support for boolean attributes.","user":{"login":"pascalbetz","id":16653,"avatar_url":"https://avatars.githubusercontent.com/u/16653?v=3","gravatar_id":"","url":"https://api.github.com/users/pascalbetz","html_url":"https://github.com/pascalbetz","followers_url":"https://api.github.com/users/pascalbetz/followers","following_url":"https://api.github.com/users/pascalbetz/following{/other_user}","gists_url":"https://api.github.com/users/pascalbetz/gists{/gist_id}","starred_url":"https://api.github.com/users/pascalbetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pascalbetz/subscriptions","organizations_url":"https://api.github.com/users/pascalbetz/orgs","repos_url":"https://api.github.com/users/pascalbetz/repos","events_url":"https://api.github.com/users/pascalbetz/events{/privacy}","received_events_url":"https://api.github.com/users/pascalbetz/received_events","type":"User","site_admin":false},"body":"Boolean attributes are rendered differently than normal attributes.\r\nIf its value is _false_ then the whole attribute is omitted.\r\nIf its value is _true_ then the attribute is rendered with its name as the value.\r\n\r\n+ added special handling of boolean attributes\r\n+ added tests\r\n! fixed existing tests that checked for „true“ values in rendered boolean attributes","created_at":"2015-07-27T12:37:24Z","updated_at":"2015-07-27T18:34:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00173b32699c0bf111ad1c9b15eed9acec07f65a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lotus/helpers/pulls/26/commits","review_comments_url":"https://api.github.com/repos/lotus/helpers/pulls/26/comments","review_comment_url":"https://api.github.com/repos/lotus/helpers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lotus/helpers/issues/26/comments","statuses_url":"https://api.github.com/repos/lotus/helpers/statuses/3110fad715ded015ae8f9664ab8caae4609c1751","head":{"label":"pascalbetz:issue-23","ref":"issue-23","sha":"3110fad715ded015ae8f9664ab8caae4609c1751","user":{"login":"pascalbetz","id":16653,"avatar_url":"https://avatars.githubusercontent.com/u/16653?v=3","gravatar_id":"","url":"https://api.github.com/users/pascalbetz","html_url":"https://github.com/pascalbetz","followers_url":"https://api.github.com/users/pascalbetz/followers","following_url":"https://api.github.com/users/pascalbetz/following{/other_user}","gists_url":"https://api.github.com/users/pascalbetz/gists{/gist_id}","starred_url":"https://api.github.com/users/pascalbetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pascalbetz/subscriptions","organizations_url":"https://api.github.com/users/pascalbetz/orgs","repos_url":"https://api.github.com/users/pascalbetz/repos","events_url":"https://api.github.com/users/pascalbetz/events{/privacy}","received_events_url":"https://api.github.com/users/pascalbetz/received_events","type":"User","site_admin":false},"repo":{"id":39732640,"name":"lotus-helpers","full_name":"pascalbetz/lotus-helpers","owner":{"login":"pascalbetz","id":16653,"avatar_url":"https://avatars.githubusercontent.com/u/16653?v=3","gravatar_id":"","url":"https://api.github.com/users/pascalbetz","html_url":"https://github.com/pascalbetz","followers_url":"https://api.github.com/users/pascalbetz/followers","following_url":"https://api.github.com/users/pascalbetz/following{/other_user}","gists_url":"https://api.github.com/users/pascalbetz/gists{/gist_id}","starred_url":"https://api.github.com/users/pascalbetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pascalbetz/subscriptions","organizations_url":"https://api.github.com/users/pascalbetz/orgs","repos_url":"https://api.github.com/users/pascalbetz/repos","events_url":"https://api.github.com/users/pascalbetz/events{/privacy}","received_events_url":"https://api.github.com/users/pascalbetz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pascalbetz/lotus-helpers","description":"View helpers for Ruby applications","fork":true,"url":"https://api.github.com/repos/pascalbetz/lotus-helpers","forks_url":"https://api.github.com/repos/pascalbetz/lotus-helpers/forks","keys_url":"https://api.github.com/repos/pascalbetz/lotus-helpers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pascalbetz/lotus-helpers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pascalbetz/lotus-helpers/teams","hooks_url":"https://api.github.com/repos/pascalbetz/lotus-helpers/hooks","issue_events_url":"https://api.github.com/repos/pascalbetz/lotus-helpers/issues/events{/number}","events_url":"https://api.github.com/repos/pascalbetz/lotus-helpers/events","assignees_url":"https://api.github.com/repos/pascalbetz/lotus-helpers/assignees{/user}","branches_url":"https://api.github.com/repos/pascalbetz/lotus-helpers/branches{/branch}","tags_url":"https://api.github.com/repos/pascalbetz/lotus-helpers/tags","blobs_url":"https://api.github.com/repos/pascalbetz/lotus-helpers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pascalbetz/lotus-helpers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pascalbetz/lotus-helpers/git/refs{/sha}","trees_url":"https://api.github.com/repos/pascalbetz/lotus-helpers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pascalbetz/lotus-helpers/statuses/{sha}","languages_url":"https://api.github.com/repos/pascalbetz/lotus-helpers/languages","stargazers_url":"https://api.github.com/repos/pascalbetz/lotus-helpers/stargazers","contributors_url":"https://api.github.com/repos/pascalbetz/lotus-helpers/contributors","subscribers_url":"https://api.github.com/repos/pascalbetz/lotus-helpers/subscribers","subscription_url":"https://api.github.com/repos/pascalbetz/lotus-helpers/subscription","commits_url":"https://api.github.com/repos/pascalbetz/lotus-helpers/commits{/sha}","git_commits_url":"https://api.github.com/repos/pascalbetz/lotus-helpers/git/commits{/sha}","comments_url":"https://api.github.com/repos/pascalbetz/lotus-helpers/comments{/number}","issue_comment_url":"https://api.github.com/repos/pascalbetz/lotus-helpers/issues/comments{/number}","contents_url":"https://api.github.com/repos/pascalbetz/lotus-helpers/contents/{+path}","compare_url":"https://api.github.com/repos/pascalbetz/lotus-helpers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pascalbetz/lotus-helpers/merges","archive_url":"https://api.github.com/repos/pascalbetz/lotus-helpers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pascalbetz/lotus-helpers/downloads","issues_url":"https://api.github.com/repos/pascalbetz/lotus-helpers/issues{/number}","pulls_url":"https://api.github.com/repos/pascalbetz/lotus-helpers/pulls{/number}","milestones_url":"https://api.github.com/repos/pascalbetz/lotus-helpers/milestones{/number}","notifications_url":"https://api.github.com/repos/pascalbetz/lotus-helpers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pascalbetz/lotus-helpers/labels{/name}","releases_url":"https://api.github.com/repos/pascalbetz/lotus-helpers/releases{/id}","created_at":"2015-07-26T16:35:10Z","updated_at":"2015-07-26T16:35:24Z","pushed_at":"2015-07-27T18:29:51Z","git_url":"git://github.com/pascalbetz/lotus-helpers.git","ssh_url":"git@github.com:pascalbetz/lotus-helpers.git","clone_url":"https://github.com/pascalbetz/lotus-helpers.git","svn_url":"https://github.com/pascalbetz/lotus-helpers","homepage":"http://lotusrb.org","size":510,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lotus:master","ref":"master","sha":"ec60edd8e79ec502e1bd19487aad9d160799d4ed","user":{"login":"lotus","id":3210273,"avatar_url":"https://avatars.githubusercontent.com/u/3210273?v=3","gravatar_id":"","url":"https://api.github.com/users/lotus","html_url":"https://github.com/lotus","followers_url":"https://api.github.com/users/lotus/followers","following_url":"https://api.github.com/users/lotus/following{/other_user}","gists_url":"https://api.github.com/users/lotus/gists{/gist_id}","starred_url":"https://api.github.com/users/lotus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lotus/subscriptions","organizations_url":"https://api.github.com/users/lotus/orgs","repos_url":"https://api.github.com/users/lotus/repos","events_url":"https://api.github.com/users/lotus/events{/privacy}","received_events_url":"https://api.github.com/users/lotus/received_events","type":"Organization","site_admin":false},"repo":{"id":19746688,"name":"helpers","full_name":"lotus/helpers","owner":{"login":"lotus","id":3210273,"avatar_url":"https://avatars.githubusercontent.com/u/3210273?v=3","gravatar_id":"","url":"https://api.github.com/users/lotus","html_url":"https://github.com/lotus","followers_url":"https://api.github.com/users/lotus/followers","following_url":"https://api.github.com/users/lotus/following{/other_user}","gists_url":"https://api.github.com/users/lotus/gists{/gist_id}","starred_url":"https://api.github.com/users/lotus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lotus/subscriptions","organizations_url":"https://api.github.com/users/lotus/orgs","repos_url":"https://api.github.com/users/lotus/repos","events_url":"https://api.github.com/users/lotus/events{/privacy}","received_events_url":"https://api.github.com/users/lotus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lotus/helpers","description":"View helpers for Ruby applications","fork":false,"url":"https://api.github.com/repos/lotus/helpers","forks_url":"https://api.github.com/repos/lotus/helpers/forks","keys_url":"https://api.github.com/repos/lotus/helpers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lotus/helpers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lotus/helpers/teams","hooks_url":"https://api.github.com/repos/lotus/helpers/hooks","issue_events_url":"https://api.github.com/repos/lotus/helpers/issues/events{/number}","events_url":"https://api.github.com/repos/lotus/helpers/events","assignees_url":"https://api.github.com/repos/lotus/helpers/assignees{/user}","branches_url":"https://api.github.com/repos/lotus/helpers/branches{/branch}","tags_url":"https://api.github.com/repos/lotus/helpers/tags","blobs_url":"https://api.github.com/repos/lotus/helpers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lotus/helpers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lotus/helpers/git/refs{/sha}","trees_url":"https://api.github.com/repos/lotus/helpers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lotus/helpers/statuses/{sha}","languages_url":"https://api.github.com/repos/lotus/helpers/languages","stargazers_url":"https://api.github.com/repos/lotus/helpers/stargazers","contributors_url":"https://api.github.com/repos/lotus/helpers/contributors","subscribers_url":"https://api.github.com/repos/lotus/helpers/subscribers","subscription_url":"https://api.github.com/repos/lotus/helpers/subscription","commits_url":"https://api.github.com/repos/lotus/helpers/commits{/sha}","git_commits_url":"https://api.github.com/repos/lotus/helpers/git/commits{/sha}","comments_url":"https://api.github.com/repos/lotus/helpers/comments{/number}","issue_comment_url":"https://api.github.com/repos/lotus/helpers/issues/comments{/number}","contents_url":"https://api.github.com/repos/lotus/helpers/contents/{+path}","compare_url":"https://api.github.com/repos/lotus/helpers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lotus/helpers/merges","archive_url":"https://api.github.com/repos/lotus/helpers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lotus/helpers/downloads","issues_url":"https://api.github.com/repos/lotus/helpers/issues{/number}","pulls_url":"https://api.github.com/repos/lotus/helpers/pulls{/number}","milestones_url":"https://api.github.com/repos/lotus/helpers/milestones{/number}","notifications_url":"https://api.github.com/repos/lotus/helpers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lotus/helpers/labels{/name}","releases_url":"https://api.github.com/repos/lotus/helpers/releases{/id}","created_at":"2014-05-13T16:26:00Z","updated_at":"2015-07-26T19:55:50Z","pushed_at":"2015-07-27T18:31:11Z","git_url":"git://github.com/lotus/helpers.git","ssh_url":"git@github.com:lotus/helpers.git","clone_url":"https://github.com/lotus/helpers.git","svn_url":"https://github.com/lotus/helpers","homepage":"http://lotusrb.org","size":510,"stargazers_count":32,"watchers_count":32,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":4,"forks":25,"open_issues":4,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lotus/helpers/pulls/26"},"html":{"href":"https://github.com/lotus/helpers/pull/26"},"issue":{"href":"https://api.github.com/repos/lotus/helpers/issues/26"},"comments":{"href":"https://api.github.com/repos/lotus/helpers/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/lotus/helpers/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/lotus/helpers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lotus/helpers/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/lotus/helpers/statuses/3110fad715ded015ae8f9664ab8caae4609c1751"}}}}