{"action":"created","issue":{"url":"https://api.github.com/repos/musescore/MuseScore/issues/2199","labels_url":"https://api.github.com/repos/musescore/MuseScore/issues/2199/labels{/name}","comments_url":"https://api.github.com/repos/musescore/MuseScore/issues/2199/comments","events_url":"https://api.github.com/repos/musescore/MuseScore/issues/2199/events","html_url":"https://github.com/musescore/MuseScore/pull/2199","id":103956568,"number":2199,"title":"74906 hairpin text","user":{"login":"MarcSabatella","id":1799936,"avatar_url":"https://avatars.githubusercontent.com/u/1799936?v=3","gravatar_id":"","url":"https://api.github.com/users/MarcSabatella","html_url":"https://github.com/MarcSabatella","followers_url":"https://api.github.com/users/MarcSabatella/followers","following_url":"https://api.github.com/users/MarcSabatella/following{/other_user}","gists_url":"https://api.github.com/users/MarcSabatella/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcSabatella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcSabatella/subscriptions","organizations_url":"https://api.github.com/users/MarcSabatella/orgs","repos_url":"https://api.github.com/users/MarcSabatella/repos","events_url":"https://api.github.com/users/MarcSabatella/events{/privacy}","received_events_url":"https://api.github.com/users/MarcSabatella/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-08-30T22:08:46Z","updated_at":"2015-09-02T15:31:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/musescore/MuseScore/pulls/2199","html_url":"https://github.com/musescore/MuseScore/pull/2199","diff_url":"https://github.com/musescore/MuseScore/pull/2199.diff","patch_url":"https://github.com/musescore/MuseScore/pull/2199.patch"},"body":"Two usability enhancements for the new textline hairpins:\r\n\r\n1) prepopulate the begin text for ordinary (non-textline) hairpins (even though it won't be displayed by default) so it is all ready to go if you change it into a textline hairpin via the Inspector\r\n\r\n2) adjust vertical position of the textline hairpin by 0.5sp to better align visually with the corresponding ordinary hairpin\r\n\r\nThe second of these is a bit of a hack, but one designed to correct for something done for 2.0 that was itself a bit of a hack.  The current default position of the ordinary hairpin (a general style setting) was chosen to make the vertical center of the hairpin align with a the vertical center of a dynamic marking at the default position (a text style setting).  These two defaults happen to differ by 0.5sp, because dynamics align to baseline but ordinary hairpins align to the vertical center (the tip) and moving the latter up by 0.5sp made it hit the vertical center of the dynamic with the default fonts.\r\n\r\nWe *could* add a new style parameter for the vertical position for the textline hairpin (also one to set the line style) and use this instead of the ordinary hairpin default position.  We could also revisit the default style settings and how we interpret the hairpin vertical position - making it specify the baseline position rather than the tip position, and adjust older scores accordingly."},"comment":{"url":"https://api.github.com/repos/musescore/MuseScore/issues/comments/137134457","html_url":"https://github.com/musescore/MuseScore/pull/2199#issuecomment-137134457","issue_url":"https://api.github.com/repos/musescore/MuseScore/issues/2199","id":137134457,"user":{"login":"MarcSabatella","id":1799936,"avatar_url":"https://avatars.githubusercontent.com/u/1799936?v=3","gravatar_id":"","url":"https://api.github.com/users/MarcSabatella","html_url":"https://github.com/MarcSabatella","followers_url":"https://api.github.com/users/MarcSabatella/followers","following_url":"https://api.github.com/users/MarcSabatella/following{/other_user}","gists_url":"https://api.github.com/users/MarcSabatella/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcSabatella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcSabatella/subscriptions","organizations_url":"https://api.github.com/users/MarcSabatella/orgs","repos_url":"https://api.github.com/users/MarcSabatella/repos","events_url":"https://api.github.com/users/MarcSabatella/events{/privacy}","received_events_url":"https://api.github.com/users/MarcSabatella/received_events","type":"User","site_admin":false},"created_at":"2015-09-02T15:31:38Z","updated_at":"2015-09-02T15:31:38Z","body":"Updated to add the continue text, also fixed a glitch where score text style was not being honored for hairpins added via double click (I just needed to add hairpins to the list of spanners covered by the style rebase code in cmdAddSpanner).  So now if you set your hairpin text style to 10pt, you'll get what you want.  Also I squashed the commits."}}