{"action":"created","comment":{"url":"https://api.github.com/repos/percolate/dripconfig/pulls/comments/41456850","id":41456850,"diff_hunk":"@@ -82,16 +83,33 @@ class StatsdConfig(SchemaBasedTrigger):\n         'statsd': {\n             Required('host'): basestring,\n             Required('port', default=8125): Coerce(int),\n+            Optional('sample_rate', default=1): Coerce(int),\n+            Optional('disabled', default=False): bool,\n         },\n     })\n \n     def configure(self, configuration):\n+        \"\"\"\n+        If statsd is missing from the config, the emission of","path":"dripconfig/builtins.py","position":36,"original_position":36,"commit_id":"c897a5a517afdcea8202b907ecbf6b6dbd54455f","original_commit_id":"3beb9c4aa10db191a93d974f2f16074280286373","user":{"login":"lapointexavier","id":176277,"avatar_url":"https://avatars.githubusercontent.com/u/176277?v=3","gravatar_id":"","url":"https://api.github.com/users/lapointexavier","html_url":"https://github.com/lapointexavier","followers_url":"https://api.github.com/users/lapointexavier/followers","following_url":"https://api.github.com/users/lapointexavier/following{/other_user}","gists_url":"https://api.github.com/users/lapointexavier/gists{/gist_id}","starred_url":"https://api.github.com/users/lapointexavier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lapointexavier/subscriptions","organizations_url":"https://api.github.com/users/lapointexavier/orgs","repos_url":"https://api.github.com/users/lapointexavier/repos","events_url":"https://api.github.com/users/lapointexavier/events{/privacy}","received_events_url":"https://api.github.com/users/lapointexavier/received_events","type":"User","site_admin":false},"body":"Cool","created_at":"2015-10-07T22:35:24Z","updated_at":"2015-10-07T22:35:24Z","html_url":"https://github.com/percolate/dripconfig/pull/4#discussion_r41456850","pull_request_url":"https://api.github.com/repos/percolate/dripconfig/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/percolate/dripconfig/pulls/comments/41456850"},"html":{"href":"https://github.com/percolate/dripconfig/pull/4#discussion_r41456850"},"pull_request":{"href":"https://api.github.com/repos/percolate/dripconfig/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/percolate/dripconfig/pulls/4","id":47086893,"html_url":"https://github.com/percolate/dripconfig/pull/4","diff_url":"https://github.com/percolate/dripconfig/pull/4.diff","patch_url":"https://github.com/percolate/dripconfig/pull/4.patch","issue_url":"https://api.github.com/repos/percolate/dripconfig/issues/4","number":4,"state":"open","locked":false,"title":"Make statsd optional for all services","user":{"login":"lapointexavier","id":176277,"avatar_url":"https://avatars.githubusercontent.com/u/176277?v=3","gravatar_id":"","url":"https://api.github.com/users/lapointexavier","html_url":"https://github.com/lapointexavier","followers_url":"https://api.github.com/users/lapointexavier/followers","following_url":"https://api.github.com/users/lapointexavier/following{/other_user}","gists_url":"https://api.github.com/users/lapointexavier/gists{/gist_id}","starred_url":"https://api.github.com/users/lapointexavier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lapointexavier/subscriptions","organizations_url":"https://api.github.com/users/lapointexavier/orgs","repos_url":"https://api.github.com/users/lapointexavier/repos","events_url":"https://api.github.com/users/lapointexavier/events{/privacy}","received_events_url":"https://api.github.com/users/lapointexavier/received_events","type":"User","site_admin":false},"body":"https://app.asana.com/0/32572848394828/46326836696759\r\n\r\nAdded some missing defaults (all optional), and disables the emission of data if statsd is missing from the config section, or explicitly disabled.\r\n\r\n## QA\r\n- [ ] unittests sufficient? ","created_at":"2015-10-07T21:49:34Z","updated_at":"2015-10-07T22:35:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b8dd56c95ef561cd640adcdf5605829a3479083a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/percolate/dripconfig/pulls/4/commits","review_comments_url":"https://api.github.com/repos/percolate/dripconfig/pulls/4/comments","review_comment_url":"https://api.github.com/repos/percolate/dripconfig/pulls/comments{/number}","comments_url":"https://api.github.com/repos/percolate/dripconfig/issues/4/comments","statuses_url":"https://api.github.com/repos/percolate/dripconfig/statuses/c897a5a517afdcea8202b907ecbf6b6dbd54455f","head":{"label":"percolate:make_statsd_optional","ref":"make_statsd_optional","sha":"c897a5a517afdcea8202b907ecbf6b6dbd54455f","user":{"login":"percolate","id":625648,"avatar_url":"https://avatars.githubusercontent.com/u/625648?v=3","gravatar_id":"","url":"https://api.github.com/users/percolate","html_url":"https://github.com/percolate","followers_url":"https://api.github.com/users/percolate/followers","following_url":"https://api.github.com/users/percolate/following{/other_user}","gists_url":"https://api.github.com/users/percolate/gists{/gist_id}","starred_url":"https://api.github.com/users/percolate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percolate/subscriptions","organizations_url":"https://api.github.com/users/percolate/orgs","repos_url":"https://api.github.com/users/percolate/repos","events_url":"https://api.github.com/users/percolate/events{/privacy}","received_events_url":"https://api.github.com/users/percolate/received_events","type":"Organization","site_admin":false},"repo":{"id":14153140,"name":"dripconfig","full_name":"percolate/dripconfig","owner":{"login":"percolate","id":625648,"avatar_url":"https://avatars.githubusercontent.com/u/625648?v=3","gravatar_id":"","url":"https://api.github.com/users/percolate","html_url":"https://github.com/percolate","followers_url":"https://api.github.com/users/percolate/followers","following_url":"https://api.github.com/users/percolate/following{/other_user}","gists_url":"https://api.github.com/users/percolate/gists{/gist_id}","starred_url":"https://api.github.com/users/percolate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percolate/subscriptions","organizations_url":"https://api.github.com/users/percolate/orgs","repos_url":"https://api.github.com/users/percolate/repos","events_url":"https://api.github.com/users/percolate/events{/privacy}","received_events_url":"https://api.github.com/users/percolate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/percolate/dripconfig","description":"A tool for doing configuration nicely","fork":false,"url":"https://api.github.com/repos/percolate/dripconfig","forks_url":"https://api.github.com/repos/percolate/dripconfig/forks","keys_url":"https://api.github.com/repos/percolate/dripconfig/keys{/key_id}","collaborators_url":"https://api.github.com/repos/percolate/dripconfig/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/percolate/dripconfig/teams","hooks_url":"https://api.github.com/repos/percolate/dripconfig/hooks","issue_events_url":"https://api.github.com/repos/percolate/dripconfig/issues/events{/number}","events_url":"https://api.github.com/repos/percolate/dripconfig/events","assignees_url":"https://api.github.com/repos/percolate/dripconfig/assignees{/user}","branches_url":"https://api.github.com/repos/percolate/dripconfig/branches{/branch}","tags_url":"https://api.github.com/repos/percolate/dripconfig/tags","blobs_url":"https://api.github.com/repos/percolate/dripconfig/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/percolate/dripconfig/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/percolate/dripconfig/git/refs{/sha}","trees_url":"https://api.github.com/repos/percolate/dripconfig/git/trees{/sha}","statuses_url":"https://api.github.com/repos/percolate/dripconfig/statuses/{sha}","languages_url":"https://api.github.com/repos/percolate/dripconfig/languages","stargazers_url":"https://api.github.com/repos/percolate/dripconfig/stargazers","contributors_url":"https://api.github.com/repos/percolate/dripconfig/contributors","subscribers_url":"https://api.github.com/repos/percolate/dripconfig/subscribers","subscription_url":"https://api.github.com/repos/percolate/dripconfig/subscription","commits_url":"https://api.github.com/repos/percolate/dripconfig/commits{/sha}","git_commits_url":"https://api.github.com/repos/percolate/dripconfig/git/commits{/sha}","comments_url":"https://api.github.com/repos/percolate/dripconfig/comments{/number}","issue_comment_url":"https://api.github.com/repos/percolate/dripconfig/issues/comments{/number}","contents_url":"https://api.github.com/repos/percolate/dripconfig/contents/{+path}","compare_url":"https://api.github.com/repos/percolate/dripconfig/compare/{base}...{head}","merges_url":"https://api.github.com/repos/percolate/dripconfig/merges","archive_url":"https://api.github.com/repos/percolate/dripconfig/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/percolate/dripconfig/downloads","issues_url":"https://api.github.com/repos/percolate/dripconfig/issues{/number}","pulls_url":"https://api.github.com/repos/percolate/dripconfig/pulls{/number}","milestones_url":"https://api.github.com/repos/percolate/dripconfig/milestones{/number}","notifications_url":"https://api.github.com/repos/percolate/dripconfig/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/percolate/dripconfig/labels{/name}","releases_url":"https://api.github.com/repos/percolate/dripconfig/releases{/id}","created_at":"2013-11-05T20:26:28Z","updated_at":"2014-11-07T13:20:52Z","pushed_at":"2015-10-07T22:28:31Z","git_url":"git://github.com/percolate/dripconfig.git","ssh_url":"git@github.com:percolate/dripconfig.git","clone_url":"https://github.com/percolate/dripconfig.git","svn_url":"https://github.com/percolate/dripconfig","homepage":null,"size":185,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"percolate:master","ref":"master","sha":"8bb98feb5ec4b7473ac58da024434375118a2b7c","user":{"login":"percolate","id":625648,"avatar_url":"https://avatars.githubusercontent.com/u/625648?v=3","gravatar_id":"","url":"https://api.github.com/users/percolate","html_url":"https://github.com/percolate","followers_url":"https://api.github.com/users/percolate/followers","following_url":"https://api.github.com/users/percolate/following{/other_user}","gists_url":"https://api.github.com/users/percolate/gists{/gist_id}","starred_url":"https://api.github.com/users/percolate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percolate/subscriptions","organizations_url":"https://api.github.com/users/percolate/orgs","repos_url":"https://api.github.com/users/percolate/repos","events_url":"https://api.github.com/users/percolate/events{/privacy}","received_events_url":"https://api.github.com/users/percolate/received_events","type":"Organization","site_admin":false},"repo":{"id":14153140,"name":"dripconfig","full_name":"percolate/dripconfig","owner":{"login":"percolate","id":625648,"avatar_url":"https://avatars.githubusercontent.com/u/625648?v=3","gravatar_id":"","url":"https://api.github.com/users/percolate","html_url":"https://github.com/percolate","followers_url":"https://api.github.com/users/percolate/followers","following_url":"https://api.github.com/users/percolate/following{/other_user}","gists_url":"https://api.github.com/users/percolate/gists{/gist_id}","starred_url":"https://api.github.com/users/percolate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percolate/subscriptions","organizations_url":"https://api.github.com/users/percolate/orgs","repos_url":"https://api.github.com/users/percolate/repos","events_url":"https://api.github.com/users/percolate/events{/privacy}","received_events_url":"https://api.github.com/users/percolate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/percolate/dripconfig","description":"A tool for doing configuration nicely","fork":false,"url":"https://api.github.com/repos/percolate/dripconfig","forks_url":"https://api.github.com/repos/percolate/dripconfig/forks","keys_url":"https://api.github.com/repos/percolate/dripconfig/keys{/key_id}","collaborators_url":"https://api.github.com/repos/percolate/dripconfig/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/percolate/dripconfig/teams","hooks_url":"https://api.github.com/repos/percolate/dripconfig/hooks","issue_events_url":"https://api.github.com/repos/percolate/dripconfig/issues/events{/number}","events_url":"https://api.github.com/repos/percolate/dripconfig/events","assignees_url":"https://api.github.com/repos/percolate/dripconfig/assignees{/user}","branches_url":"https://api.github.com/repos/percolate/dripconfig/branches{/branch}","tags_url":"https://api.github.com/repos/percolate/dripconfig/tags","blobs_url":"https://api.github.com/repos/percolate/dripconfig/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/percolate/dripconfig/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/percolate/dripconfig/git/refs{/sha}","trees_url":"https://api.github.com/repos/percolate/dripconfig/git/trees{/sha}","statuses_url":"https://api.github.com/repos/percolate/dripconfig/statuses/{sha}","languages_url":"https://api.github.com/repos/percolate/dripconfig/languages","stargazers_url":"https://api.github.com/repos/percolate/dripconfig/stargazers","contributors_url":"https://api.github.com/repos/percolate/dripconfig/contributors","subscribers_url":"https://api.github.com/repos/percolate/dripconfig/subscribers","subscription_url":"https://api.github.com/repos/percolate/dripconfig/subscription","commits_url":"https://api.github.com/repos/percolate/dripconfig/commits{/sha}","git_commits_url":"https://api.github.com/repos/percolate/dripconfig/git/commits{/sha}","comments_url":"https://api.github.com/repos/percolate/dripconfig/comments{/number}","issue_comment_url":"https://api.github.com/repos/percolate/dripconfig/issues/comments{/number}","contents_url":"https://api.github.com/repos/percolate/dripconfig/contents/{+path}","compare_url":"https://api.github.com/repos/percolate/dripconfig/compare/{base}...{head}","merges_url":"https://api.github.com/repos/percolate/dripconfig/merges","archive_url":"https://api.github.com/repos/percolate/dripconfig/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/percolate/dripconfig/downloads","issues_url":"https://api.github.com/repos/percolate/dripconfig/issues{/number}","pulls_url":"https://api.github.com/repos/percolate/dripconfig/pulls{/number}","milestones_url":"https://api.github.com/repos/percolate/dripconfig/milestones{/number}","notifications_url":"https://api.github.com/repos/percolate/dripconfig/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/percolate/dripconfig/labels{/name}","releases_url":"https://api.github.com/repos/percolate/dripconfig/releases{/id}","created_at":"2013-11-05T20:26:28Z","updated_at":"2014-11-07T13:20:52Z","pushed_at":"2015-10-07T22:28:31Z","git_url":"git://github.com/percolate/dripconfig.git","ssh_url":"git@github.com:percolate/dripconfig.git","clone_url":"https://github.com/percolate/dripconfig.git","svn_url":"https://github.com/percolate/dripconfig","homepage":null,"size":185,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/percolate/dripconfig/pulls/4"},"html":{"href":"https://github.com/percolate/dripconfig/pull/4"},"issue":{"href":"https://api.github.com/repos/percolate/dripconfig/issues/4"},"comments":{"href":"https://api.github.com/repos/percolate/dripconfig/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/percolate/dripconfig/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/percolate/dripconfig/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/percolate/dripconfig/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/percolate/dripconfig/statuses/c897a5a517afdcea8202b907ecbf6b6dbd54455f"}}}}