{"action":"created","comment":{"url":"https://api.github.com/repos/4teamwork/izug.ticketbox/pulls/comments/28124698","id":28124698,"diff_hunk":"@@ -63,6 +65,7 @@\n         'ftw.tabbedview',\n         'ftw.table',\n         'ftw.upgrade',\n+        'ftw.zipexport',","path":"setup.py","position":13,"original_position":13,"commit_id":"99eaeabeed9cae5a3a8a2a9846e37fa19d7f313e","original_commit_id":"99eaeabeed9cae5a3a8a2a9846e37fa19d7f313e","user":{"login":"jone","id":7469,"avatar_url":"https://avatars.githubusercontent.com/u/7469?v=3","gravatar_id":"","url":"https://api.github.com/users/jone","html_url":"https://github.com/jone","followers_url":"https://api.github.com/users/jone/followers","following_url":"https://api.github.com/users/jone/following{/other_user}","gists_url":"https://api.github.com/users/jone/gists{/gist_id}","starred_url":"https://api.github.com/users/jone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jone/subscriptions","organizations_url":"https://api.github.com/users/jone/orgs","repos_url":"https://api.github.com/users/jone/repos","events_url":"https://api.github.com/users/jone/events{/privacy}","received_events_url":"https://api.github.com/users/jone/received_events","type":"User","site_admin":false},"body":"I'd prefer the ticketbox to not depend on `ftw.zipexport`; zipexport should only be optional.\r\nBy using the ZCML-condition ( ``<configure zcml:condition=\"installed ftw.zipexport\">``) this already works partially, but the ``export.py`` contains not only the zip export adapter but also the regular export.\r\n\r\nI'd do this:\r\n- Remove the dependency here\r\n- Move the zip export adapter into a separate ``zipexport`` module, which should be the only place importing from ``ftw.zipexport``\r\n- Still use the ZCML condition\r\n- Declare an ``extras_require``, e.g. ``zip=['ftw.zipexport']``, so that it is visible that the ticketbox supports zips (and it could be installed with ``izug.ticketbox [zip]``.","created_at":"2015-04-10T06:32:04Z","updated_at":"2015-04-10T06:32:04Z","html_url":"https://github.com/4teamwork/izug.ticketbox/pull/63#discussion_r28124698","pull_request_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/pulls/63","_links":{"self":{"href":"https://api.github.com/repos/4teamwork/izug.ticketbox/pulls/comments/28124698"},"html":{"href":"https://github.com/4teamwork/izug.ticketbox/pull/63#discussion_r28124698"},"pull_request":{"href":"https://api.github.com/repos/4teamwork/izug.ticketbox/pulls/63"}}},"pull_request":{"url":"https://api.github.com/repos/4teamwork/izug.ticketbox/pulls/63","id":32954403,"html_url":"https://github.com/4teamwork/izug.ticketbox/pull/63","diff_url":"https://github.com/4teamwork/izug.ticketbox/pull/63.diff","patch_url":"https://github.com/4teamwork/izug.ticketbox/pull/63.patch","issue_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/issues/63","number":63,"state":"open","locked":false,"title":"Add support for ftw.zipexport.","user":{"login":"mbaechtold","id":28220,"avatar_url":"https://avatars.githubusercontent.com/u/28220?v=3","gravatar_id":"","url":"https://api.github.com/users/mbaechtold","html_url":"https://github.com/mbaechtold","followers_url":"https://api.github.com/users/mbaechtold/followers","following_url":"https://api.github.com/users/mbaechtold/following{/other_user}","gists_url":"https://api.github.com/users/mbaechtold/gists{/gist_id}","starred_url":"https://api.github.com/users/mbaechtold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbaechtold/subscriptions","organizations_url":"https://api.github.com/users/mbaechtold/orgs","repos_url":"https://api.github.com/users/mbaechtold/repos","events_url":"https://api.github.com/users/mbaechtold/events{/privacy}","received_events_url":"https://api.github.com/users/mbaechtold/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-04-09T13:17:27Z","updated_at":"2015-04-10T06:32:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7eb19efffb5e6de953663c8e45d0906a8744d67b","assignee":{"login":"jone","id":7469,"avatar_url":"https://avatars.githubusercontent.com/u/7469?v=3","gravatar_id":"","url":"https://api.github.com/users/jone","html_url":"https://github.com/jone","followers_url":"https://api.github.com/users/jone/followers","following_url":"https://api.github.com/users/jone/following{/other_user}","gists_url":"https://api.github.com/users/jone/gists{/gist_id}","starred_url":"https://api.github.com/users/jone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jone/subscriptions","organizations_url":"https://api.github.com/users/jone/orgs","repos_url":"https://api.github.com/users/jone/repos","events_url":"https://api.github.com/users/jone/events{/privacy}","received_events_url":"https://api.github.com/users/jone/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/pulls/63/commits","review_comments_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/pulls/63/comments","review_comment_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/issues/63/comments","statuses_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/statuses/99eaeabeed9cae5a3a8a2a9846e37fa19d7f313e","head":{"label":"4teamwork:mba/add-zip-export","ref":"mba/add-zip-export","sha":"99eaeabeed9cae5a3a8a2a9846e37fa19d7f313e","user":{"login":"4teamwork","id":681821,"avatar_url":"https://avatars.githubusercontent.com/u/681821?v=3","gravatar_id":"","url":"https://api.github.com/users/4teamwork","html_url":"https://github.com/4teamwork","followers_url":"https://api.github.com/users/4teamwork/followers","following_url":"https://api.github.com/users/4teamwork/following{/other_user}","gists_url":"https://api.github.com/users/4teamwork/gists{/gist_id}","starred_url":"https://api.github.com/users/4teamwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4teamwork/subscriptions","organizations_url":"https://api.github.com/users/4teamwork/orgs","repos_url":"https://api.github.com/users/4teamwork/repos","events_url":"https://api.github.com/users/4teamwork/events{/privacy}","received_events_url":"https://api.github.com/users/4teamwork/received_events","type":"Organization","site_admin":false},"repo":{"id":2915319,"name":"izug.ticketbox","full_name":"4teamwork/izug.ticketbox","owner":{"login":"4teamwork","id":681821,"avatar_url":"https://avatars.githubusercontent.com/u/681821?v=3","gravatar_id":"","url":"https://api.github.com/users/4teamwork","html_url":"https://github.com/4teamwork","followers_url":"https://api.github.com/users/4teamwork/followers","following_url":"https://api.github.com/users/4teamwork/following{/other_user}","gists_url":"https://api.github.com/users/4teamwork/gists{/gist_id}","starred_url":"https://api.github.com/users/4teamwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4teamwork/subscriptions","organizations_url":"https://api.github.com/users/4teamwork/orgs","repos_url":"https://api.github.com/users/4teamwork/repos","events_url":"https://api.github.com/users/4teamwork/events{/privacy}","received_events_url":"https://api.github.com/users/4teamwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/4teamwork/izug.ticketbox","description":"A tracker-like task management system.","fork":false,"url":"https://api.github.com/repos/4teamwork/izug.ticketbox","forks_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/forks","keys_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/teams","hooks_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/hooks","issue_events_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/issues/events{/number}","events_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/events","assignees_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/assignees{/user}","branches_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/branches{/branch}","tags_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/tags","blobs_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/statuses/{sha}","languages_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/languages","stargazers_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/stargazers","contributors_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/contributors","subscribers_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/subscribers","subscription_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/subscription","commits_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/contents/{+path}","compare_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/merges","archive_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/downloads","issues_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/issues{/number}","pulls_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/pulls{/number}","milestones_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/milestones{/number}","notifications_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/labels{/name}","releases_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/releases{/id}","created_at":"2011-12-05T08:55:53Z","updated_at":"2014-12-04T16:33:09Z","pushed_at":"2015-04-09T13:17:27Z","git_url":"git://github.com/4teamwork/izug.ticketbox.git","ssh_url":"git@github.com:4teamwork/izug.ticketbox.git","clone_url":"https://github.com/4teamwork/izug.ticketbox.git","svn_url":"https://github.com/4teamwork/izug.ticketbox","homepage":"","size":1876,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"4teamwork:master","ref":"master","sha":"3004f92e14a919b0aef4509c208d1a39eacc2490","user":{"login":"4teamwork","id":681821,"avatar_url":"https://avatars.githubusercontent.com/u/681821?v=3","gravatar_id":"","url":"https://api.github.com/users/4teamwork","html_url":"https://github.com/4teamwork","followers_url":"https://api.github.com/users/4teamwork/followers","following_url":"https://api.github.com/users/4teamwork/following{/other_user}","gists_url":"https://api.github.com/users/4teamwork/gists{/gist_id}","starred_url":"https://api.github.com/users/4teamwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4teamwork/subscriptions","organizations_url":"https://api.github.com/users/4teamwork/orgs","repos_url":"https://api.github.com/users/4teamwork/repos","events_url":"https://api.github.com/users/4teamwork/events{/privacy}","received_events_url":"https://api.github.com/users/4teamwork/received_events","type":"Organization","site_admin":false},"repo":{"id":2915319,"name":"izug.ticketbox","full_name":"4teamwork/izug.ticketbox","owner":{"login":"4teamwork","id":681821,"avatar_url":"https://avatars.githubusercontent.com/u/681821?v=3","gravatar_id":"","url":"https://api.github.com/users/4teamwork","html_url":"https://github.com/4teamwork","followers_url":"https://api.github.com/users/4teamwork/followers","following_url":"https://api.github.com/users/4teamwork/following{/other_user}","gists_url":"https://api.github.com/users/4teamwork/gists{/gist_id}","starred_url":"https://api.github.com/users/4teamwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4teamwork/subscriptions","organizations_url":"https://api.github.com/users/4teamwork/orgs","repos_url":"https://api.github.com/users/4teamwork/repos","events_url":"https://api.github.com/users/4teamwork/events{/privacy}","received_events_url":"https://api.github.com/users/4teamwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/4teamwork/izug.ticketbox","description":"A tracker-like task management system.","fork":false,"url":"https://api.github.com/repos/4teamwork/izug.ticketbox","forks_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/forks","keys_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/teams","hooks_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/hooks","issue_events_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/issues/events{/number}","events_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/events","assignees_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/assignees{/user}","branches_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/branches{/branch}","tags_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/tags","blobs_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/statuses/{sha}","languages_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/languages","stargazers_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/stargazers","contributors_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/contributors","subscribers_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/subscribers","subscription_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/subscription","commits_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/contents/{+path}","compare_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/merges","archive_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/downloads","issues_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/issues{/number}","pulls_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/pulls{/number}","milestones_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/milestones{/number}","notifications_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/labels{/name}","releases_url":"https://api.github.com/repos/4teamwork/izug.ticketbox/releases{/id}","created_at":"2011-12-05T08:55:53Z","updated_at":"2014-12-04T16:33:09Z","pushed_at":"2015-04-09T13:17:27Z","git_url":"git://github.com/4teamwork/izug.ticketbox.git","ssh_url":"git@github.com:4teamwork/izug.ticketbox.git","clone_url":"https://github.com/4teamwork/izug.ticketbox.git","svn_url":"https://github.com/4teamwork/izug.ticketbox","homepage":"","size":1876,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/4teamwork/izug.ticketbox/pulls/63"},"html":{"href":"https://github.com/4teamwork/izug.ticketbox/pull/63"},"issue":{"href":"https://api.github.com/repos/4teamwork/izug.ticketbox/issues/63"},"comments":{"href":"https://api.github.com/repos/4teamwork/izug.ticketbox/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/4teamwork/izug.ticketbox/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/4teamwork/izug.ticketbox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/4teamwork/izug.ticketbox/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/4teamwork/izug.ticketbox/statuses/99eaeabeed9cae5a3a8a2a9846e37fa19d7f313e"}}}}