{"action":"created","issue":{"url":"https://api.github.com/repos/zendframework/zf2/issues/7251","labels_url":"https://api.github.com/repos/zendframework/zf2/issues/7251/labels{/name}","comments_url":"https://api.github.com/repos/zendframework/zf2/issues/7251/comments","events_url":"https://api.github.com/repos/zendframework/zf2/issues/7251/events","html_url":"https://github.com/zendframework/zf2/pull/7251","id":58653568,"number":7251,"title":"Fixed tests for quoteValue() methods in all Platform classes","user":{"login":"hschletz","id":1310065,"avatar_url":"https://avatars.githubusercontent.com/u/1310065?v=3","gravatar_id":"","url":"https://api.github.com/users/hschletz","html_url":"https://github.com/hschletz","followers_url":"https://api.github.com/users/hschletz/followers","following_url":"https://api.github.com/users/hschletz/following{/other_user}","gists_url":"https://api.github.com/users/hschletz/gists{/gist_id}","starred_url":"https://api.github.com/users/hschletz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hschletz/subscriptions","organizations_url":"https://api.github.com/users/hschletz/orgs","repos_url":"https://api.github.com/users/hschletz/repos","events_url":"https://api.github.com/users/hschletz/events{/privacy}","received_events_url":"https://api.github.com/users/hschletz/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/zendframework/zf2/labels/awaiting%20author%20updates","name":"awaiting author updates","color":"e11d21"},{"url":"https://api.github.com/repos/zendframework/zf2/labels/Db","name":"Db","color":"008000"},{"url":"https://api.github.com/repos/zendframework/zf2/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/zendframework/zf2/milestones/26","html_url":"https://github.com/zendframework/zf2/milestones/2.4.0","labels_url":"https://api.github.com/repos/zendframework/zf2/milestones/26/labels","id":593244,"number":26,"title":"2.4.0","description":null,"creator":{"login":"weierophinney","id":25943,"avatar_url":"https://avatars.githubusercontent.com/u/25943?v=3","gravatar_id":"","url":"https://api.github.com/users/weierophinney","html_url":"https://github.com/weierophinney","followers_url":"https://api.github.com/users/weierophinney/followers","following_url":"https://api.github.com/users/weierophinney/following{/other_user}","gists_url":"https://api.github.com/users/weierophinney/gists{/gist_id}","starred_url":"https://api.github.com/users/weierophinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weierophinney/subscriptions","organizations_url":"https://api.github.com/users/weierophinney/orgs","repos_url":"https://api.github.com/users/weierophinney/repos","events_url":"https://api.github.com/users/weierophinney/events{/privacy}","received_events_url":"https://api.github.com/users/weierophinney/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":283,"state":"open","created_at":"2014-03-10T21:38:11Z","updated_at":"2015-03-18T16:38:28Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2015-02-23T21:42:51Z","updated_at":"2015-03-18T16:44:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zendframework/zf2/pulls/7251","html_url":"https://github.com/zendframework/zf2/pull/7251","diff_url":"https://github.com/zendframework/zf2/pull/7251.diff","patch_url":"https://github.com/zendframework/zf2/pull/7251.patch"},"body":"The tests for quoteValue() are incomplete. When quoteValue() raises an E_USER_NOTICE, PHPUnit converts it to an exception which is tested. The tests try to check the return value, but neither the return value generating code nor the assertion are executed. The tests pass, but only the error message is effectively tested.\r\n\r\nI split the tests: One test checks the exception as usual, but the return value is discarded (It would be NULL anyway within a PHPUnit environment - in other context a value would be returned, but that is difficult to test). I also tightened the exception type check from PHPUnit_Framework_Error to PHPUnit_Framework_Error_Notice.\r\n\r\nThe other test executes quoteValue() with error suppression so that the return value can be checked. Since quoteValue() and quoteTrustedValue() are implemented separately, I added the full set of test values to the test."},"comment":{"url":"https://api.github.com/repos/zendframework/zf2/issues/comments/83052934","html_url":"https://github.com/zendframework/zf2/pull/7251#issuecomment-83052934","issue_url":"https://api.github.com/repos/zendframework/zf2/issues/7251","id":83052934,"user":{"login":"weierophinney","id":25943,"avatar_url":"https://avatars.githubusercontent.com/u/25943?v=3","gravatar_id":"","url":"https://api.github.com/users/weierophinney","html_url":"https://github.com/weierophinney","followers_url":"https://api.github.com/users/weierophinney/followers","following_url":"https://api.github.com/users/weierophinney/following{/other_user}","gists_url":"https://api.github.com/users/weierophinney/gists{/gist_id}","starred_url":"https://api.github.com/users/weierophinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weierophinney/subscriptions","organizations_url":"https://api.github.com/users/weierophinney/orgs","repos_url":"https://api.github.com/users/weierophinney/repos","events_url":"https://api.github.com/users/weierophinney/events{/privacy}","received_events_url":"https://api.github.com/users/weierophinney/received_events","type":"User","site_admin":false},"created_at":"2015-03-18T16:44:04Z","updated_at":"2015-03-18T16:44:04Z","body":"@hschletz Can you please rebase against develop, so  I can merge? I need that done by tomorrow, 19 March 2015; otherwise, we'll have to review after the 2.4 release."}}