{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/36973377","id":36973377,"diff_hunk":"@@ -43,6 +43,7 @@\n \tprivate Socket socket;\n \tprivate static final int CONNECTION_TIMEOUT_TIME = 0;\n \tprivate static final int CONNECTION_RETRY_SLEEP = 1000;\n+\tprotected long retrys;","path":"flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/SocketTextStreamFunction.java","position":4,"original_position":4,"commit_id":"3728849250dde690e5ebc7fa0847121e6d216bd8","original_commit_id":"3728849250dde690e5ebc7fa0847121e6d216bd8","user":{"login":"mxm","id":837221,"avatar_url":"https://avatars.githubusercontent.com/u/837221?v=3","gravatar_id":"","url":"https://api.github.com/users/mxm","html_url":"https://github.com/mxm","followers_url":"https://api.github.com/users/mxm/followers","following_url":"https://api.github.com/users/mxm/following{/other_user}","gists_url":"https://api.github.com/users/mxm/gists{/gist_id}","starred_url":"https://api.github.com/users/mxm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxm/subscriptions","organizations_url":"https://api.github.com/users/mxm/orgs","repos_url":"https://api.github.com/users/mxm/repos","events_url":"https://api.github.com/users/mxm/events{/privacy}","received_events_url":"https://api.github.com/users/mxm/received_events","type":"User","site_admin":false},"body":"Sorry, minor thing but it should be `retries`.","created_at":"2015-08-13T13:29:17Z","updated_at":"2015-08-13T13:29:17Z","html_url":"https://github.com/apache/flink/pull/992#discussion_r36973377","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/992","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/36973377"},"html":{"href":"https://github.com/apache/flink/pull/992#discussion_r36973377"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/992"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/992","id":41766129,"html_url":"https://github.com/apache/flink/pull/992","diff_url":"https://github.com/apache/flink/pull/992.diff","patch_url":"https://github.com/apache/flink/pull/992.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/992","number":992,"state":"open","locked":false,"title":"[FLINK-2490][FIX]Remove the retryForever check in function streamFrom…","user":{"login":"HuangWHWHW","id":13193847,"avatar_url":"https://avatars.githubusercontent.com/u/13193847?v=3","gravatar_id":"","url":"https://api.github.com/users/HuangWHWHW","html_url":"https://github.com/HuangWHWHW","followers_url":"https://api.github.com/users/HuangWHWHW/followers","following_url":"https://api.github.com/users/HuangWHWHW/following{/other_user}","gists_url":"https://api.github.com/users/HuangWHWHW/gists{/gist_id}","starred_url":"https://api.github.com/users/HuangWHWHW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HuangWHWHW/subscriptions","organizations_url":"https://api.github.com/users/HuangWHWHW/orgs","repos_url":"https://api.github.com/users/HuangWHWHW/repos","events_url":"https://api.github.com/users/HuangWHWHW/events{/privacy}","received_events_url":"https://api.github.com/users/HuangWHWHW/received_events","type":"User","site_admin":false},"body":"In the class SocketTextStreamFunction, the var retryForever only  be set in  the line \"this.retryForever = maxRetry < 0;\"(SocketTextStreamFunction.java:54).\r\nWhen the program executes this “while (retry < maxRetry && !success) ” it means the maxRetry > 0 and the retryForever will always be false.\r\nSo it`s unnecessary to judge whether retryForever be false.","created_at":"2015-08-06T09:07:07Z","updated_at":"2015-08-13T13:29:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4d6da2417b4ef0ae410640c1b56f6d51ee56f7b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/992/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/992/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/992/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/3728849250dde690e5ebc7fa0847121e6d216bd8","head":{"label":"HuangWHWHW:FLINK-2490","ref":"FLINK-2490","sha":"3728849250dde690e5ebc7fa0847121e6d216bd8","user":{"login":"HuangWHWHW","id":13193847,"avatar_url":"https://avatars.githubusercontent.com/u/13193847?v=3","gravatar_id":"","url":"https://api.github.com/users/HuangWHWHW","html_url":"https://github.com/HuangWHWHW","followers_url":"https://api.github.com/users/HuangWHWHW/followers","following_url":"https://api.github.com/users/HuangWHWHW/following{/other_user}","gists_url":"https://api.github.com/users/HuangWHWHW/gists{/gist_id}","starred_url":"https://api.github.com/users/HuangWHWHW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HuangWHWHW/subscriptions","organizations_url":"https://api.github.com/users/HuangWHWHW/orgs","repos_url":"https://api.github.com/users/HuangWHWHW/repos","events_url":"https://api.github.com/users/HuangWHWHW/events{/privacy}","received_events_url":"https://api.github.com/users/HuangWHWHW/received_events","type":"User","site_admin":false},"repo":{"id":38603893,"name":"flink","full_name":"HuangWHWHW/flink","owner":{"login":"HuangWHWHW","id":13193847,"avatar_url":"https://avatars.githubusercontent.com/u/13193847?v=3","gravatar_id":"","url":"https://api.github.com/users/HuangWHWHW","html_url":"https://github.com/HuangWHWHW","followers_url":"https://api.github.com/users/HuangWHWHW/followers","following_url":"https://api.github.com/users/HuangWHWHW/following{/other_user}","gists_url":"https://api.github.com/users/HuangWHWHW/gists{/gist_id}","starred_url":"https://api.github.com/users/HuangWHWHW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HuangWHWHW/subscriptions","organizations_url":"https://api.github.com/users/HuangWHWHW/orgs","repos_url":"https://api.github.com/users/HuangWHWHW/repos","events_url":"https://api.github.com/users/HuangWHWHW/events{/privacy}","received_events_url":"https://api.github.com/users/HuangWHWHW/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HuangWHWHW/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/HuangWHWHW/flink","forks_url":"https://api.github.com/repos/HuangWHWHW/flink/forks","keys_url":"https://api.github.com/repos/HuangWHWHW/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HuangWHWHW/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HuangWHWHW/flink/teams","hooks_url":"https://api.github.com/repos/HuangWHWHW/flink/hooks","issue_events_url":"https://api.github.com/repos/HuangWHWHW/flink/issues/events{/number}","events_url":"https://api.github.com/repos/HuangWHWHW/flink/events","assignees_url":"https://api.github.com/repos/HuangWHWHW/flink/assignees{/user}","branches_url":"https://api.github.com/repos/HuangWHWHW/flink/branches{/branch}","tags_url":"https://api.github.com/repos/HuangWHWHW/flink/tags","blobs_url":"https://api.github.com/repos/HuangWHWHW/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HuangWHWHW/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HuangWHWHW/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/HuangWHWHW/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HuangWHWHW/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/HuangWHWHW/flink/languages","stargazers_url":"https://api.github.com/repos/HuangWHWHW/flink/stargazers","contributors_url":"https://api.github.com/repos/HuangWHWHW/flink/contributors","subscribers_url":"https://api.github.com/repos/HuangWHWHW/flink/subscribers","subscription_url":"https://api.github.com/repos/HuangWHWHW/flink/subscription","commits_url":"https://api.github.com/repos/HuangWHWHW/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/HuangWHWHW/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/HuangWHWHW/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/HuangWHWHW/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/HuangWHWHW/flink/contents/{+path}","compare_url":"https://api.github.com/repos/HuangWHWHW/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HuangWHWHW/flink/merges","archive_url":"https://api.github.com/repos/HuangWHWHW/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HuangWHWHW/flink/downloads","issues_url":"https://api.github.com/repos/HuangWHWHW/flink/issues{/number}","pulls_url":"https://api.github.com/repos/HuangWHWHW/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/HuangWHWHW/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/HuangWHWHW/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HuangWHWHW/flink/labels{/name}","releases_url":"https://api.github.com/repos/HuangWHWHW/flink/releases{/id}","created_at":"2015-07-06T07:25:09Z","updated_at":"2015-07-06T07:25:20Z","pushed_at":"2015-08-13T13:05:13Z","git_url":"git://github.com/HuangWHWHW/flink.git","ssh_url":"git@github.com:HuangWHWHW/flink.git","clone_url":"https://github.com/HuangWHWHW/flink.git","svn_url":"https://github.com/HuangWHWHW/flink","homepage":null,"size":56094,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"925ac1f76bb84986764495407049a77552169d84","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"name":"flink","full_name":"apache/flink","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/flink","description":"Mirror of Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","created_at":"2014-06-07T07:00:10Z","updated_at":"2015-08-13T00:33:43Z","pushed_at":"2015-08-13T13:05:13Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":null,"size":2591498,"stargazers_count":559,"watchers_count":559,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":367,"mirror_url":"git://git.apache.org/incubator-flink.git","open_issues_count":72,"forks":367,"open_issues":72,"watchers":559,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/992"},"html":{"href":"https://github.com/apache/flink/pull/992"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/992"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/992/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/992/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/992/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/3728849250dde690e5ebc7fa0847121e6d216bd8"}}}}