{"action":"created","issue":{"url":"https://api.github.com/repos/strands-project/strands_qsr_lib/issues/84","labels_url":"https://api.github.com/repos/strands-project/strands_qsr_lib/issues/84/labels{/name}","comments_url":"https://api.github.com/repos/strands-project/strands_qsr_lib/issues/84/comments","events_url":"https://api.github.com/repos/strands-project/strands_qsr_lib/issues/84/events","html_url":"https://github.com/strands-project/strands_qsr_lib/issues/84","id":99406881,"number":84,"title":"[QSRlib] request_qsrs not thread safe","user":{"login":"cdondrup","id":4293484,"avatar_url":"https://avatars.githubusercontent.com/u/4293484?v=3","gravatar_id":"","url":"https://api.github.com/users/cdondrup","html_url":"https://github.com/cdondrup","followers_url":"https://api.github.com/users/cdondrup/followers","following_url":"https://api.github.com/users/cdondrup/following{/other_user}","gists_url":"https://api.github.com/users/cdondrup/gists{/gist_id}","starred_url":"https://api.github.com/users/cdondrup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdondrup/subscriptions","organizations_url":"https://api.github.com/users/cdondrup/orgs","repos_url":"https://api.github.com/users/cdondrup/repos","events_url":"https://api.github.com/users/cdondrup/events{/privacy}","received_events_url":"https://api.github.com/users/cdondrup/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/strands-project/strands_qsr_lib/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/strands-project/strands_qsr_lib/labels/question","name":"question","color":"cc317c"}],"state":"open","locked":false,"assignee":{"login":"yianni","id":167472,"avatar_url":"https://avatars.githubusercontent.com/u/167472?v=3","gravatar_id":"","url":"https://api.github.com/users/yianni","html_url":"https://github.com/yianni","followers_url":"https://api.github.com/users/yianni/followers","following_url":"https://api.github.com/users/yianni/following{/other_user}","gists_url":"https://api.github.com/users/yianni/gists{/gist_id}","starred_url":"https://api.github.com/users/yianni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yianni/subscriptions","organizations_url":"https://api.github.com/users/yianni/orgs","repos_url":"https://api.github.com/users/yianni/repos","events_url":"https://api.github.com/users/yianni/events{/privacy}","received_events_url":"https://api.github.com/users/yianni/received_events","type":"User","site_admin":false},"milestone":null,"comments":8,"created_at":"2015-08-06T10:40:34Z","updated_at":"2015-08-06T10:58:47Z","closed_at":null,"body":"When requesting qsrs from multiple programmes at the same time, [the reset command](https://github.com/strands-project/strands_qsr_lib/blob/master/qsr_lib/src/qsrlib/qsrlib.py#L161-L165) is not thread safe and sets the request message to `None`. What is that good for in the first place? The [values are always overridden](https://github.com/strands-project/strands_qsr_lib/blob/master/qsr_lib/src/qsrlib/qsrlib.py#L147-L148) when the function is called anyway. @yianni is this used for anything or can I just remove that all together? If so, I can fix that together with #83 "},"comment":{"url":"https://api.github.com/repos/strands-project/strands_qsr_lib/issues/comments/128326901","html_url":"https://github.com/strands-project/strands_qsr_lib/issues/84#issuecomment-128326901","issue_url":"https://api.github.com/repos/strands-project/strands_qsr_lib/issues/84","id":128326901,"user":{"login":"yianni","id":167472,"avatar_url":"https://avatars.githubusercontent.com/u/167472?v=3","gravatar_id":"","url":"https://api.github.com/users/yianni","html_url":"https://github.com/yianni","followers_url":"https://api.github.com/users/yianni/followers","following_url":"https://api.github.com/users/yianni/following{/other_user}","gists_url":"https://api.github.com/users/yianni/gists{/gist_id}","starred_url":"https://api.github.com/users/yianni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yianni/subscriptions","organizations_url":"https://api.github.com/users/yianni/orgs","repos_url":"https://api.github.com/users/yianni/repos","events_url":"https://api.github.com/users/yianni/events{/privacy}","received_events_url":"https://api.github.com/users/yianni/received_events","type":"User","site_admin":false},"created_at":"2015-08-06T10:58:47Z","updated_at":"2015-08-06T10:58:47Z","body":"> But I don't need the member variable at all then, do I? I can just remove self.timestamp_request_received and self.request_message and the garbage collection should take care of that. Shouldn't it?\r\n\r\n1min. Need to look in more detail."}}