{"action":"created","issue":{"url":"https://api.github.com/repos/mrdoob/three.js/issues/7636","labels_url":"https://api.github.com/repos/mrdoob/three.js/issues/7636/labels{/name}","comments_url":"https://api.github.com/repos/mrdoob/three.js/issues/7636/comments","events_url":"https://api.github.com/repos/mrdoob/three.js/issues/7636/events","html_url":"https://github.com/mrdoob/three.js/issues/7636","id":117702609,"number":7636,"title":"examples unit adjustment","user":{"login":"GGAlanSmithee","id":11805103,"avatar_url":"https://avatars.githubusercontent.com/u/11805103?v=3","gravatar_id":"","url":"https://api.github.com/users/GGAlanSmithee","html_url":"https://github.com/GGAlanSmithee","followers_url":"https://api.github.com/users/GGAlanSmithee/followers","following_url":"https://api.github.com/users/GGAlanSmithee/following{/other_user}","gists_url":"https://api.github.com/users/GGAlanSmithee/gists{/gist_id}","starred_url":"https://api.github.com/users/GGAlanSmithee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GGAlanSmithee/subscriptions","organizations_url":"https://api.github.com/users/GGAlanSmithee/orgs","repos_url":"https://api.github.com/users/GGAlanSmithee/repos","events_url":"https://api.github.com/users/GGAlanSmithee/events{/privacy}","received_events_url":"https://api.github.com/users/GGAlanSmithee/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mrdoob/three.js/labels/Enhancement","name":"Enhancement","color":"deffdb"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-11-18T23:03:54Z","updated_at":"2015-11-23T18:38:51Z","closed_at":null,"body":"This issue is for tracking the conversion of sizes used in the examples (as discussed in #7609) and for me to ask questions about it :)\r\n\r\nThe work is going on here https://github.com/GGAlanSmithee/three.js/tree/examples-unit-adjustment. You can see how it's going in `track.txt` in the root.\r\n\r\nI am trying to get the sizes of the geometries in the examples as close to reality as possible where 1 three.js unit = 1 meter (without breaking anything). In cases where the example does not map to reality (for example displays an arbitary cube), I try to get as close to 1 three.js unit as possible for consistency and to get users looking at the examples used to use three.js with those kind of scales.\r\n\r\nI am a bit unsure about the cases where a model is loaded. Some of them are somewhat large (canvas_lights_pointlights for example) and not close to reality, should I scale them down then to try to get it as close to reality as possible or leave size as is when loaded?\r\n\r\nI am only changing size / scale atm. I do not know if there needs to be further changes done to textures or renderer to take advantage of the new shader model? if so please tell me what (maybe should be another PR though). I would also appreciate if someone would give a quick look at the examples I've converted so far just to see that I'm not doing something crazy."},"comment":{"url":"https://api.github.com/repos/mrdoob/three.js/issues/comments/159023064","html_url":"https://github.com/mrdoob/three.js/issues/7636#issuecomment-159023064","issue_url":"https://api.github.com/repos/mrdoob/three.js/issues/7636","id":159023064,"user":{"login":"GGAlanSmithee","id":11805103,"avatar_url":"https://avatars.githubusercontent.com/u/11805103?v=3","gravatar_id":"","url":"https://api.github.com/users/GGAlanSmithee","html_url":"https://github.com/GGAlanSmithee","followers_url":"https://api.github.com/users/GGAlanSmithee/followers","following_url":"https://api.github.com/users/GGAlanSmithee/following{/other_user}","gists_url":"https://api.github.com/users/GGAlanSmithee/gists{/gist_id}","starred_url":"https://api.github.com/users/GGAlanSmithee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GGAlanSmithee/subscriptions","organizations_url":"https://api.github.com/users/GGAlanSmithee/orgs","repos_url":"https://api.github.com/users/GGAlanSmithee/repos","events_url":"https://api.github.com/users/GGAlanSmithee/events{/privacy}","received_events_url":"https://api.github.com/users/GGAlanSmithee/received_events","type":"User","site_admin":false},"created_at":"2015-11-23T18:38:51Z","updated_at":"2015-11-23T18:38:51Z","body":"OK.\r\n\r\nI want to focus on converting the units in this issue / PR to be. Might be better if someone with a bit of insight in the animation API fixed this. If not, I can try when done with this."}}