{"action":"created","comment":{"url":"https://api.github.com/repos/cea-sec/miasm/pulls/comments/26922783","id":26922783,"diff_hunk":"@@ -605,15 +650,12 @@ class DependencyGraph_NoMemory(DependencyGraph):\n     - Soundness: all results are corrects\n     - Completeness: all possible solutions are founds\n     \"\"\"\n+    def __init__(self, ira):\n+        super(DependencyGraph_NoMemory, self).__init__(ira)\n+        self.cb_follow = [follow_simp_expr, follow_nomem_cst]\n \n-    def _resolve_depNode(self, depnode):\n-        \"\"\"Compute and return the dependencies involved by @depnode\"\"\"\n-        # Get inital elements\n-        result = super(DependencyGraph_NoMemory, self)._resolve_depNode(depnode)\n-\n-        # If @depnode depends on a memory element, give up\n-        for node in result:\n-            if isinstance(node.element, m2_expr.ExprMem):\n-                return set()\n-\n-        return result\n+class DependencyGraph_NoCall_NoMemory(DependencyGraph):","path":"miasm2/analysis/depgraph.py","position":129,"original_position":129,"commit_id":"da3bb7dfdefa29059c50d00bcfd01c2ff91544f6","original_commit_id":"da3bb7dfdefa29059c50d00bcfd01c2ff91544f6","user":{"login":"commial","id":4194483,"avatar_url":"https://avatars.githubusercontent.com/u/4194483?v=3","gravatar_id":"","url":"https://api.github.com/users/commial","html_url":"https://github.com/commial","followers_url":"https://api.github.com/users/commial/followers","following_url":"https://api.github.com/users/commial/following{/other_user}","gists_url":"https://api.github.com/users/commial/gists{/gist_id}","starred_url":"https://api.github.com/users/commial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commial/subscriptions","organizations_url":"https://api.github.com/users/commial/orgs","repos_url":"https://api.github.com/users/commial/repos","events_url":"https://api.github.com/users/commial/events{/privacy}","received_events_url":"https://api.github.com/users/commial/received_events","type":"User","site_admin":false},"body":"To avoid defining `n!` class for each callbacks possibility, a metaclass could be a solution. That is to say, a class generator which take in input the callback to use, or with more abstraction, the element to handle (`follow_call`, `follow_mem`, ...).","created_at":"2015-03-23T09:36:39Z","updated_at":"2015-03-23T09:36:39Z","html_url":"https://github.com/cea-sec/miasm/pull/123#discussion_r26922783","pull_request_url":"https://api.github.com/repos/cea-sec/miasm/pulls/123","_links":{"self":{"href":"https://api.github.com/repos/cea-sec/miasm/pulls/comments/26922783"},"html":{"href":"https://github.com/cea-sec/miasm/pull/123#discussion_r26922783"},"pull_request":{"href":"https://api.github.com/repos/cea-sec/miasm/pulls/123"}}},"pull_request":{"url":"https://api.github.com/repos/cea-sec/miasm/pulls/123","id":31661988,"html_url":"https://github.com/cea-sec/miasm/pull/123","diff_url":"https://github.com/cea-sec/miasm/pull/123.diff","patch_url":"https://github.com/cea-sec/miasm/pull/123.patch","issue_url":"https://api.github.com/repos/cea-sec/miasm/issues/123","number":123,"state":"open","locked":false,"title":"Depgraph filter","user":{"login":"serpilliere","id":9433661,"avatar_url":"https://avatars.githubusercontent.com/u/9433661?v=3","gravatar_id":"","url":"https://api.github.com/users/serpilliere","html_url":"https://github.com/serpilliere","followers_url":"https://api.github.com/users/serpilliere/followers","following_url":"https://api.github.com/users/serpilliere/following{/other_user}","gists_url":"https://api.github.com/users/serpilliere/gists{/gist_id}","starred_url":"https://api.github.com/users/serpilliere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serpilliere/subscriptions","organizations_url":"https://api.github.com/users/serpilliere/orgs","repos_url":"https://api.github.com/users/serpilliere/repos","events_url":"https://api.github.com/users/serpilliere/events{/privacy}","received_events_url":"https://api.github.com/users/serpilliere/received_events","type":"User","site_admin":false},"body":"Support callback to filter depnode to follow.\r\nUpdate IDA/Depgraph to support `NoCallNoMem` depgraph.","created_at":"2015-03-21T00:16:17Z","updated_at":"2015-03-23T09:36:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f28c9978780dc1324ae41b052d6bf7b7ef556369","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cea-sec/miasm/pulls/123/commits","review_comments_url":"https://api.github.com/repos/cea-sec/miasm/pulls/123/comments","review_comment_url":"https://api.github.com/repos/cea-sec/miasm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cea-sec/miasm/issues/123/comments","statuses_url":"https://api.github.com/repos/cea-sec/miasm/statuses/da3bb7dfdefa29059c50d00bcfd01c2ff91544f6","head":{"label":"serpilliere:depgraph_filter","ref":"depgraph_filter","sha":"da3bb7dfdefa29059c50d00bcfd01c2ff91544f6","user":{"login":"serpilliere","id":9433661,"avatar_url":"https://avatars.githubusercontent.com/u/9433661?v=3","gravatar_id":"","url":"https://api.github.com/users/serpilliere","html_url":"https://github.com/serpilliere","followers_url":"https://api.github.com/users/serpilliere/followers","following_url":"https://api.github.com/users/serpilliere/following{/other_user}","gists_url":"https://api.github.com/users/serpilliere/gists{/gist_id}","starred_url":"https://api.github.com/users/serpilliere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serpilliere/subscriptions","organizations_url":"https://api.github.com/users/serpilliere/orgs","repos_url":"https://api.github.com/users/serpilliere/repos","events_url":"https://api.github.com/users/serpilliere/events{/privacy}","received_events_url":"https://api.github.com/users/serpilliere/received_events","type":"User","site_admin":false},"repo":{"id":27075008,"name":"miasm","full_name":"serpilliere/miasm","owner":{"login":"serpilliere","id":9433661,"avatar_url":"https://avatars.githubusercontent.com/u/9433661?v=3","gravatar_id":"","url":"https://api.github.com/users/serpilliere","html_url":"https://github.com/serpilliere","followers_url":"https://api.github.com/users/serpilliere/followers","following_url":"https://api.github.com/users/serpilliere/following{/other_user}","gists_url":"https://api.github.com/users/serpilliere/gists{/gist_id}","starred_url":"https://api.github.com/users/serpilliere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serpilliere/subscriptions","organizations_url":"https://api.github.com/users/serpilliere/orgs","repos_url":"https://api.github.com/users/serpilliere/repos","events_url":"https://api.github.com/users/serpilliere/events{/privacy}","received_events_url":"https://api.github.com/users/serpilliere/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/serpilliere/miasm","description":"Reverse engineering framework in Python","fork":true,"url":"https://api.github.com/repos/serpilliere/miasm","forks_url":"https://api.github.com/repos/serpilliere/miasm/forks","keys_url":"https://api.github.com/repos/serpilliere/miasm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serpilliere/miasm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serpilliere/miasm/teams","hooks_url":"https://api.github.com/repos/serpilliere/miasm/hooks","issue_events_url":"https://api.github.com/repos/serpilliere/miasm/issues/events{/number}","events_url":"https://api.github.com/repos/serpilliere/miasm/events","assignees_url":"https://api.github.com/repos/serpilliere/miasm/assignees{/user}","branches_url":"https://api.github.com/repos/serpilliere/miasm/branches{/branch}","tags_url":"https://api.github.com/repos/serpilliere/miasm/tags","blobs_url":"https://api.github.com/repos/serpilliere/miasm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serpilliere/miasm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serpilliere/miasm/git/refs{/sha}","trees_url":"https://api.github.com/repos/serpilliere/miasm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serpilliere/miasm/statuses/{sha}","languages_url":"https://api.github.com/repos/serpilliere/miasm/languages","stargazers_url":"https://api.github.com/repos/serpilliere/miasm/stargazers","contributors_url":"https://api.github.com/repos/serpilliere/miasm/contributors","subscribers_url":"https://api.github.com/repos/serpilliere/miasm/subscribers","subscription_url":"https://api.github.com/repos/serpilliere/miasm/subscription","commits_url":"https://api.github.com/repos/serpilliere/miasm/commits{/sha}","git_commits_url":"https://api.github.com/repos/serpilliere/miasm/git/commits{/sha}","comments_url":"https://api.github.com/repos/serpilliere/miasm/comments{/number}","issue_comment_url":"https://api.github.com/repos/serpilliere/miasm/issues/comments{/number}","contents_url":"https://api.github.com/repos/serpilliere/miasm/contents/{+path}","compare_url":"https://api.github.com/repos/serpilliere/miasm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serpilliere/miasm/merges","archive_url":"https://api.github.com/repos/serpilliere/miasm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serpilliere/miasm/downloads","issues_url":"https://api.github.com/repos/serpilliere/miasm/issues{/number}","pulls_url":"https://api.github.com/repos/serpilliere/miasm/pulls{/number}","milestones_url":"https://api.github.com/repos/serpilliere/miasm/milestones{/number}","notifications_url":"https://api.github.com/repos/serpilliere/miasm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serpilliere/miasm/labels{/name}","releases_url":"https://api.github.com/repos/serpilliere/miasm/releases{/id}","created_at":"2014-11-24T12:31:26Z","updated_at":"2015-03-20T20:17:51Z","pushed_at":"2015-03-21T00:07:39Z","git_url":"git://github.com/serpilliere/miasm.git","ssh_url":"git@github.com:serpilliere/miasm.git","clone_url":"https://github.com/serpilliere/miasm.git","svn_url":"https://github.com/serpilliere/miasm","homepage":null,"size":10822,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"cea-sec:master","ref":"master","sha":"4170c27df9e0e27cc60a74137b294b41982ed44c","user":{"login":"cea-sec","id":5071925,"avatar_url":"https://avatars.githubusercontent.com/u/5071925?v=3","gravatar_id":"","url":"https://api.github.com/users/cea-sec","html_url":"https://github.com/cea-sec","followers_url":"https://api.github.com/users/cea-sec/followers","following_url":"https://api.github.com/users/cea-sec/following{/other_user}","gists_url":"https://api.github.com/users/cea-sec/gists{/gist_id}","starred_url":"https://api.github.com/users/cea-sec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cea-sec/subscriptions","organizations_url":"https://api.github.com/users/cea-sec/orgs","repos_url":"https://api.github.com/users/cea-sec/repos","events_url":"https://api.github.com/users/cea-sec/events{/privacy}","received_events_url":"https://api.github.com/users/cea-sec/received_events","type":"Organization","site_admin":false},"repo":{"id":25875083,"name":"miasm","full_name":"cea-sec/miasm","owner":{"login":"cea-sec","id":5071925,"avatar_url":"https://avatars.githubusercontent.com/u/5071925?v=3","gravatar_id":"","url":"https://api.github.com/users/cea-sec","html_url":"https://github.com/cea-sec","followers_url":"https://api.github.com/users/cea-sec/followers","following_url":"https://api.github.com/users/cea-sec/following{/other_user}","gists_url":"https://api.github.com/users/cea-sec/gists{/gist_id}","starred_url":"https://api.github.com/users/cea-sec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cea-sec/subscriptions","organizations_url":"https://api.github.com/users/cea-sec/orgs","repos_url":"https://api.github.com/users/cea-sec/repos","events_url":"https://api.github.com/users/cea-sec/events{/privacy}","received_events_url":"https://api.github.com/users/cea-sec/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cea-sec/miasm","description":"Reverse engineering framework in Python","fork":false,"url":"https://api.github.com/repos/cea-sec/miasm","forks_url":"https://api.github.com/repos/cea-sec/miasm/forks","keys_url":"https://api.github.com/repos/cea-sec/miasm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cea-sec/miasm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cea-sec/miasm/teams","hooks_url":"https://api.github.com/repos/cea-sec/miasm/hooks","issue_events_url":"https://api.github.com/repos/cea-sec/miasm/issues/events{/number}","events_url":"https://api.github.com/repos/cea-sec/miasm/events","assignees_url":"https://api.github.com/repos/cea-sec/miasm/assignees{/user}","branches_url":"https://api.github.com/repos/cea-sec/miasm/branches{/branch}","tags_url":"https://api.github.com/repos/cea-sec/miasm/tags","blobs_url":"https://api.github.com/repos/cea-sec/miasm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cea-sec/miasm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cea-sec/miasm/git/refs{/sha}","trees_url":"https://api.github.com/repos/cea-sec/miasm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cea-sec/miasm/statuses/{sha}","languages_url":"https://api.github.com/repos/cea-sec/miasm/languages","stargazers_url":"https://api.github.com/repos/cea-sec/miasm/stargazers","contributors_url":"https://api.github.com/repos/cea-sec/miasm/contributors","subscribers_url":"https://api.github.com/repos/cea-sec/miasm/subscribers","subscription_url":"https://api.github.com/repos/cea-sec/miasm/subscription","commits_url":"https://api.github.com/repos/cea-sec/miasm/commits{/sha}","git_commits_url":"https://api.github.com/repos/cea-sec/miasm/git/commits{/sha}","comments_url":"https://api.github.com/repos/cea-sec/miasm/comments{/number}","issue_comment_url":"https://api.github.com/repos/cea-sec/miasm/issues/comments{/number}","contents_url":"https://api.github.com/repos/cea-sec/miasm/contents/{+path}","compare_url":"https://api.github.com/repos/cea-sec/miasm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cea-sec/miasm/merges","archive_url":"https://api.github.com/repos/cea-sec/miasm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cea-sec/miasm/downloads","issues_url":"https://api.github.com/repos/cea-sec/miasm/issues{/number}","pulls_url":"https://api.github.com/repos/cea-sec/miasm/pulls{/number}","milestones_url":"https://api.github.com/repos/cea-sec/miasm/milestones{/number}","notifications_url":"https://api.github.com/repos/cea-sec/miasm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cea-sec/miasm/labels{/name}","releases_url":"https://api.github.com/repos/cea-sec/miasm/releases{/id}","created_at":"2014-10-28T15:05:47Z","updated_at":"2015-03-23T09:20:09Z","pushed_at":"2015-03-23T09:20:08Z","git_url":"git://github.com/cea-sec/miasm.git","ssh_url":"git@github.com:cea-sec/miasm.git","clone_url":"https://github.com/cea-sec/miasm.git","svn_url":"https://github.com/cea-sec/miasm","homepage":null,"size":11755,"stargazers_count":327,"watchers_count":327,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":10,"forks":38,"open_issues":10,"watchers":327,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cea-sec/miasm/pulls/123"},"html":{"href":"https://github.com/cea-sec/miasm/pull/123"},"issue":{"href":"https://api.github.com/repos/cea-sec/miasm/issues/123"},"comments":{"href":"https://api.github.com/repos/cea-sec/miasm/issues/123/comments"},"review_comments":{"href":"https://api.github.com/repos/cea-sec/miasm/pulls/123/comments"},"review_comment":{"href":"https://api.github.com/repos/cea-sec/miasm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cea-sec/miasm/pulls/123/commits"},"statuses":{"href":"https://api.github.com/repos/cea-sec/miasm/statuses/da3bb7dfdefa29059c50d00bcfd01c2ff91544f6"}}}}