{"action":"created","comment":{"url":"https://api.github.com/repos/pulp/pulp/pulls/comments/27805415","id":27805415,"diff_hunk":"@@ -295,6 +295,10 @@\n # certfile: The absolute path to the PEM encoded certificate used for authentication to the message\n #     bus. The default value is '/etc/pki/pulp/qpid/client.crt'.\n #\n+# broker_login_method: Select the login method used to connect to the broker. This should be left\n+#     unset (use the broker default) except in special cases (e.g. do SSL client certificate\n+#     authentication. For RabbitMQ with SSL client certificates, this needs to be 'EXTERNAL'.","path":"server/etc/pulp/server.conf","position":6,"original_position":6,"commit_id":"679dde7945ff6e13bf9e7ec6209c90e2948612ff","original_commit_id":"679dde7945ff6e13bf9e7ec6209c90e2948612ff","user":{"login":"bmbouter","id":180319,"avatar_url":"https://avatars.githubusercontent.com/u/180319?v=3","gravatar_id":"","url":"https://api.github.com/users/bmbouter","html_url":"https://github.com/bmbouter","followers_url":"https://api.github.com/users/bmbouter/followers","following_url":"https://api.github.com/users/bmbouter/following{/other_user}","gists_url":"https://api.github.com/users/bmbouter/gists{/gist_id}","starred_url":"https://api.github.com/users/bmbouter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmbouter/subscriptions","organizations_url":"https://api.github.com/users/bmbouter/orgs","repos_url":"https://api.github.com/users/bmbouter/repos","events_url":"https://api.github.com/users/bmbouter/events{/privacy}","received_events_url":"https://api.github.com/users/bmbouter/received_events","type":"User","site_admin":false},"body":"s/authentication/authentication)./","created_at":"2015-04-06T15:47:30Z","updated_at":"2015-04-06T15:47:30Z","html_url":"https://github.com/pulp/pulp/pull/1767#discussion_r27805415","pull_request_url":"https://api.github.com/repos/pulp/pulp/pulls/1767","_links":{"self":{"href":"https://api.github.com/repos/pulp/pulp/pulls/comments/27805415"},"html":{"href":"https://github.com/pulp/pulp/pull/1767#discussion_r27805415"},"pull_request":{"href":"https://api.github.com/repos/pulp/pulp/pulls/1767"}}},"pull_request":{"url":"https://api.github.com/repos/pulp/pulp/pulls/1767","id":32660648,"html_url":"https://github.com/pulp/pulp/pull/1767","diff_url":"https://github.com/pulp/pulp/pull/1767.diff","patch_url":"https://github.com/pulp/pulp/pull/1767.patch","issue_url":"https://api.github.com/repos/pulp/pulp/issues/1767","number":1767,"state":"open","locked":false,"title":"Allow setting the broker_login_method.","user":{"login":"hgschmie","id":39495,"avatar_url":"https://avatars.githubusercontent.com/u/39495?v=3","gravatar_id":"","url":"https://api.github.com/users/hgschmie","html_url":"https://github.com/hgschmie","followers_url":"https://api.github.com/users/hgschmie/followers","following_url":"https://api.github.com/users/hgschmie/following{/other_user}","gists_url":"https://api.github.com/users/hgschmie/gists{/gist_id}","starred_url":"https://api.github.com/users/hgschmie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hgschmie/subscriptions","organizations_url":"https://api.github.com/users/hgschmie/orgs","repos_url":"https://api.github.com/users/hgschmie/repos","events_url":"https://api.github.com/users/hgschmie/events{/privacy}","received_events_url":"https://api.github.com/users/hgschmie/received_events","type":"User","site_admin":false},"body":"When using RabbitMQ with SSL client certificates, it is necessary to use\r\nthe rabbitmq_auth_mechanism_ssl which uses the common_name (CN) of the\r\nclient certificate as user name and then use SASL EXTERNAL to have\r\nRabbitMQ pick up the configuration.\r\n\r\nUnfortunately, by default, pulp only supports the default (AMQPLAIN)\r\nauthentication and it can not be configured.\r\n\r\nThis change adds a new configuration parameter to the tasks section\r\nwhich allows setting the requested authentication mechanism through the\r\ncelery BROKER_LOGIN_METHOD configuration setting.\r\n\r\nThis allows using RabbitMQ with strict SSL client certificates:\r\n\r\n```erlang\r\n[\r\n  {rabbit, [\r\n    {ssl_listeners, [5671]},\r\n    {auth_mechanisms, ['EXTERNAL']},\r\n    {ssl_options, [\r\n      {cacertfile,           '.../cacertfile'},\r\n      {certfile,             '.../cert.crt'},\r\n      {keyfile,              '.../cert.key'},\r\n      {verify,               verify_peer},\r\n      {fail_if_no_peer_cert, true}\r\n    ]},\r\n    {ssl_cert_login_from,  common_name}]\r\n  }\r\n].\r\n```\r\n\r\nand adding the CN values from the client certificates as users to RabbitMQ.","created_at":"2015-04-06T03:47:07Z","updated_at":"2015-04-06T15:47:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f7ff19b5a0cbe70121c90b8a7c15ba47720fe1d","assignee":{"login":"bmbouter","id":180319,"avatar_url":"https://avatars.githubusercontent.com/u/180319?v=3","gravatar_id":"","url":"https://api.github.com/users/bmbouter","html_url":"https://github.com/bmbouter","followers_url":"https://api.github.com/users/bmbouter/followers","following_url":"https://api.github.com/users/bmbouter/following{/other_user}","gists_url":"https://api.github.com/users/bmbouter/gists{/gist_id}","starred_url":"https://api.github.com/users/bmbouter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmbouter/subscriptions","organizations_url":"https://api.github.com/users/bmbouter/orgs","repos_url":"https://api.github.com/users/bmbouter/repos","events_url":"https://api.github.com/users/bmbouter/events{/privacy}","received_events_url":"https://api.github.com/users/bmbouter/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/pulp/pulp/pulls/1767/commits","review_comments_url":"https://api.github.com/repos/pulp/pulp/pulls/1767/comments","review_comment_url":"https://api.github.com/repos/pulp/pulp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pulp/pulp/issues/1767/comments","statuses_url":"https://api.github.com/repos/pulp/pulp/statuses/679dde7945ff6e13bf9e7ec6209c90e2948612ff","head":{"label":"hgschmie:2.6-dev","ref":"2.6-dev","sha":"679dde7945ff6e13bf9e7ec6209c90e2948612ff","user":{"login":"hgschmie","id":39495,"avatar_url":"https://avatars.githubusercontent.com/u/39495?v=3","gravatar_id":"","url":"https://api.github.com/users/hgschmie","html_url":"https://github.com/hgschmie","followers_url":"https://api.github.com/users/hgschmie/followers","following_url":"https://api.github.com/users/hgschmie/following{/other_user}","gists_url":"https://api.github.com/users/hgschmie/gists{/gist_id}","starred_url":"https://api.github.com/users/hgschmie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hgschmie/subscriptions","organizations_url":"https://api.github.com/users/hgschmie/orgs","repos_url":"https://api.github.com/users/hgschmie/repos","events_url":"https://api.github.com/users/hgschmie/events{/privacy}","received_events_url":"https://api.github.com/users/hgschmie/received_events","type":"User","site_admin":false},"repo":{"id":33460191,"name":"pulp","full_name":"hgschmie/pulp","owner":{"login":"hgschmie","id":39495,"avatar_url":"https://avatars.githubusercontent.com/u/39495?v=3","gravatar_id":"","url":"https://api.github.com/users/hgschmie","html_url":"https://github.com/hgschmie","followers_url":"https://api.github.com/users/hgschmie/followers","following_url":"https://api.github.com/users/hgschmie/following{/other_user}","gists_url":"https://api.github.com/users/hgschmie/gists{/gist_id}","starred_url":"https://api.github.com/users/hgschmie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hgschmie/subscriptions","organizations_url":"https://api.github.com/users/hgschmie/orgs","repos_url":"https://api.github.com/users/hgschmie/repos","events_url":"https://api.github.com/users/hgschmie/events{/privacy}","received_events_url":"https://api.github.com/users/hgschmie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hgschmie/pulp","description":"Repository for Pulp platform code, including the server and base admin and consumer clients","fork":true,"url":"https://api.github.com/repos/hgschmie/pulp","forks_url":"https://api.github.com/repos/hgschmie/pulp/forks","keys_url":"https://api.github.com/repos/hgschmie/pulp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hgschmie/pulp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hgschmie/pulp/teams","hooks_url":"https://api.github.com/repos/hgschmie/pulp/hooks","issue_events_url":"https://api.github.com/repos/hgschmie/pulp/issues/events{/number}","events_url":"https://api.github.com/repos/hgschmie/pulp/events","assignees_url":"https://api.github.com/repos/hgschmie/pulp/assignees{/user}","branches_url":"https://api.github.com/repos/hgschmie/pulp/branches{/branch}","tags_url":"https://api.github.com/repos/hgschmie/pulp/tags","blobs_url":"https://api.github.com/repos/hgschmie/pulp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hgschmie/pulp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hgschmie/pulp/git/refs{/sha}","trees_url":"https://api.github.com/repos/hgschmie/pulp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hgschmie/pulp/statuses/{sha}","languages_url":"https://api.github.com/repos/hgschmie/pulp/languages","stargazers_url":"https://api.github.com/repos/hgschmie/pulp/stargazers","contributors_url":"https://api.github.com/repos/hgschmie/pulp/contributors","subscribers_url":"https://api.github.com/repos/hgschmie/pulp/subscribers","subscription_url":"https://api.github.com/repos/hgschmie/pulp/subscription","commits_url":"https://api.github.com/repos/hgschmie/pulp/commits{/sha}","git_commits_url":"https://api.github.com/repos/hgschmie/pulp/git/commits{/sha}","comments_url":"https://api.github.com/repos/hgschmie/pulp/comments{/number}","issue_comment_url":"https://api.github.com/repos/hgschmie/pulp/issues/comments{/number}","contents_url":"https://api.github.com/repos/hgschmie/pulp/contents/{+path}","compare_url":"https://api.github.com/repos/hgschmie/pulp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hgschmie/pulp/merges","archive_url":"https://api.github.com/repos/hgschmie/pulp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hgschmie/pulp/downloads","issues_url":"https://api.github.com/repos/hgschmie/pulp/issues{/number}","pulls_url":"https://api.github.com/repos/hgschmie/pulp/pulls{/number}","milestones_url":"https://api.github.com/repos/hgschmie/pulp/milestones{/number}","notifications_url":"https://api.github.com/repos/hgschmie/pulp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hgschmie/pulp/labels{/name}","releases_url":"https://api.github.com/repos/hgschmie/pulp/releases{/id}","created_at":"2015-04-06T00:34:55Z","updated_at":"2015-04-06T00:35:00Z","pushed_at":"2015-04-06T03:46:23Z","git_url":"git://github.com/hgschmie/pulp.git","ssh_url":"git@github.com:hgschmie/pulp.git","clone_url":"https://github.com/hgschmie/pulp.git","svn_url":"https://github.com/hgschmie/pulp","homepage":"","size":205450,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pulp:2.6-dev","ref":"2.6-dev","sha":"3004fa52a1d5d05504954a17e27af960622d7913","user":{"login":"pulp","id":2103606,"avatar_url":"https://avatars.githubusercontent.com/u/2103606?v=3","gravatar_id":"","url":"https://api.github.com/users/pulp","html_url":"https://github.com/pulp","followers_url":"https://api.github.com/users/pulp/followers","following_url":"https://api.github.com/users/pulp/following{/other_user}","gists_url":"https://api.github.com/users/pulp/gists{/gist_id}","starred_url":"https://api.github.com/users/pulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulp/subscriptions","organizations_url":"https://api.github.com/users/pulp/orgs","repos_url":"https://api.github.com/users/pulp/repos","events_url":"https://api.github.com/users/pulp/events{/privacy}","received_events_url":"https://api.github.com/users/pulp/received_events","type":"Organization","site_admin":false},"repo":{"id":5314652,"name":"pulp","full_name":"pulp/pulp","owner":{"login":"pulp","id":2103606,"avatar_url":"https://avatars.githubusercontent.com/u/2103606?v=3","gravatar_id":"","url":"https://api.github.com/users/pulp","html_url":"https://github.com/pulp","followers_url":"https://api.github.com/users/pulp/followers","following_url":"https://api.github.com/users/pulp/following{/other_user}","gists_url":"https://api.github.com/users/pulp/gists{/gist_id}","starred_url":"https://api.github.com/users/pulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulp/subscriptions","organizations_url":"https://api.github.com/users/pulp/orgs","repos_url":"https://api.github.com/users/pulp/repos","events_url":"https://api.github.com/users/pulp/events{/privacy}","received_events_url":"https://api.github.com/users/pulp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pulp/pulp","description":"Repository for Pulp platform code, including the server and base admin and consumer clients","fork":false,"url":"https://api.github.com/repos/pulp/pulp","forks_url":"https://api.github.com/repos/pulp/pulp/forks","keys_url":"https://api.github.com/repos/pulp/pulp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pulp/pulp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pulp/pulp/teams","hooks_url":"https://api.github.com/repos/pulp/pulp/hooks","issue_events_url":"https://api.github.com/repos/pulp/pulp/issues/events{/number}","events_url":"https://api.github.com/repos/pulp/pulp/events","assignees_url":"https://api.github.com/repos/pulp/pulp/assignees{/user}","branches_url":"https://api.github.com/repos/pulp/pulp/branches{/branch}","tags_url":"https://api.github.com/repos/pulp/pulp/tags","blobs_url":"https://api.github.com/repos/pulp/pulp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pulp/pulp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pulp/pulp/git/refs{/sha}","trees_url":"https://api.github.com/repos/pulp/pulp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pulp/pulp/statuses/{sha}","languages_url":"https://api.github.com/repos/pulp/pulp/languages","stargazers_url":"https://api.github.com/repos/pulp/pulp/stargazers","contributors_url":"https://api.github.com/repos/pulp/pulp/contributors","subscribers_url":"https://api.github.com/repos/pulp/pulp/subscribers","subscription_url":"https://api.github.com/repos/pulp/pulp/subscription","commits_url":"https://api.github.com/repos/pulp/pulp/commits{/sha}","git_commits_url":"https://api.github.com/repos/pulp/pulp/git/commits{/sha}","comments_url":"https://api.github.com/repos/pulp/pulp/comments{/number}","issue_comment_url":"https://api.github.com/repos/pulp/pulp/issues/comments{/number}","contents_url":"https://api.github.com/repos/pulp/pulp/contents/{+path}","compare_url":"https://api.github.com/repos/pulp/pulp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pulp/pulp/merges","archive_url":"https://api.github.com/repos/pulp/pulp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pulp/pulp/downloads","issues_url":"https://api.github.com/repos/pulp/pulp/issues{/number}","pulls_url":"https://api.github.com/repos/pulp/pulp/pulls{/number}","milestones_url":"https://api.github.com/repos/pulp/pulp/milestones{/number}","notifications_url":"https://api.github.com/repos/pulp/pulp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pulp/pulp/labels{/name}","releases_url":"https://api.github.com/repos/pulp/pulp/releases{/id}","created_at":"2012-08-06T13:49:20Z","updated_at":"2015-04-06T14:47:31Z","pushed_at":"2015-04-06T14:47:31Z","git_url":"git://github.com/pulp/pulp.git","ssh_url":"git@github.com:pulp/pulp.git","clone_url":"https://github.com/pulp/pulp.git","svn_url":"https://github.com/pulp/pulp","homepage":"","size":205450,"stargazers_count":190,"watchers_count":190,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":77,"mirror_url":null,"open_issues_count":14,"forks":77,"open_issues":14,"watchers":190,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pulp/pulp/pulls/1767"},"html":{"href":"https://github.com/pulp/pulp/pull/1767"},"issue":{"href":"https://api.github.com/repos/pulp/pulp/issues/1767"},"comments":{"href":"https://api.github.com/repos/pulp/pulp/issues/1767/comments"},"review_comments":{"href":"https://api.github.com/repos/pulp/pulp/pulls/1767/comments"},"review_comment":{"href":"https://api.github.com/repos/pulp/pulp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pulp/pulp/pulls/1767/commits"},"statuses":{"href":"https://api.github.com/repos/pulp/pulp/statuses/679dde7945ff6e13bf9e7ec6209c90e2948612ff"}}}}