{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/22700971","id":22700971,"diff_hunk":"@@ -36,12 +36,20 @@ MINION_SCOPES=\"\"\n POLL_SLEEP_INTERVAL=3\n PORTAL_NET=\"10.0.0.0/16\"\n \n-# Optional: Install node monitoring.\n-ENABLE_NODE_MONITORING=true\n-\n # Optional: Install node logging\n-ENABLE_NODE_LOGGING=true\n+ENABLE_NODE_LOGGING=false\n LOGGING_DESTINATION=elasticsearch # options: elasticsearch, gcp\n+\n+# Optional: When set to true, Elasticsearch and Kibana will be setup as part of the cluster bring up.\n+ENABLE_CLUSTER_LOGGING=false\n+if [[ \"${ENABLE_NODE_LOGGING-}\" == \"true\" ]]; then\n+  if [[ \"${LOGGING_DESTINATION-}\" == \"elasticsearch\" ]]; then\n+    if [[ \"${ENABLE_CLUSTER_LOGGING-}\" == \"true\" ]]; then","path":"cluster/aws/config-default.sh","position":16,"original_position":16,"commit_id":"958893e7d625806aae7ebd8c7af5e437d65728f9","original_commit_id":"958893e7d625806aae7ebd8c7af5e437d65728f9","user":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"body":"Do you really need all the logic, or can you just set the variable, or even just set it and comment the line out?","created_at":"2015-01-09T04:21:49Z","updated_at":"2015-01-09T04:21:49Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/3292#discussion_r22700971","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/3292","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/22700971"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/3292#discussion_r22700971"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/3292"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/3292","id":26995533,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/3292","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/3292.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/3292.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/3292","number":3292,"state":"open","locked":false,"title":"Launch Elasticsearch and Kibana automatically","user":{"login":"satnam6502","id":6164339,"avatar_url":"https://avatars.githubusercontent.com/u/6164339?v=3","gravatar_id":"","url":"https://api.github.com/users/satnam6502","html_url":"https://github.com/satnam6502","followers_url":"https://api.github.com/users/satnam6502/followers","following_url":"https://api.github.com/users/satnam6502/following{/other_user}","gists_url":"https://api.github.com/users/satnam6502/gists{/gist_id}","starred_url":"https://api.github.com/users/satnam6502/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satnam6502/subscriptions","organizations_url":"https://api.github.com/users/satnam6502/orgs","repos_url":"https://api.github.com/users/satnam6502/repos","events_url":"https://api.github.com/users/satnam6502/events{/privacy}","received_events_url":"https://api.github.com/users/satnam6502/received_events","type":"User","site_admin":false},"body":"This PR changes our setup to automatically launch an Elasticsearch pod for ingesting logs and a Kibana pod for viewing logs when logging with Fluentd to Elasticsearch is selected. The URLs for Elasticsearch and the Kibana dashboard are reported at cluster creation time:\r\n```\r\n.. setting up Fluentd to Elasticsearch logging with Kibana viewer\r\nCreated [https://www.googleapis.com/compute/v1/projects/kubernetes-elk/global/firewalls/fluentd-elasticsearch-logging].\r\nNAME                          NETWORK SRC_RANGES RULES                      SRC_TAGS TARGET_TAGS\r\nfluentd-elasticsearch-logging default 0.0.0.0/0  tcp:5601,tcp:9200,tcp:9300          kubernetes-minion\r\n\r\nCluster logs are ingested into Elasticsearch running at http://130.211.126.68:9200\r\nKibana logging dashboard will be available at http://23.236.59.213:5601\r\n```\r\n\r\nI have also changed the names of the Elasticsearch and Kibana pods and services (adding -logging) to avoid any name clashes with other instances of Elasticsearch in the cluster.","created_at":"2015-01-07T23:08:15Z","updated_at":"2015-01-09T04:21:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0896ef295c2d836f955df14e4239db2eefbfe648","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/3292/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/3292/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/{number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/3292/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/958893e7d625806aae7ebd8c7af5e437d65728f9","head":{"label":"satnam6502:es-kibana","ref":"es-kibana","sha":"958893e7d625806aae7ebd8c7af5e437d65728f9","user":{"login":"satnam6502","id":6164339,"avatar_url":"https://avatars.githubusercontent.com/u/6164339?v=3","gravatar_id":"","url":"https://api.github.com/users/satnam6502","html_url":"https://github.com/satnam6502","followers_url":"https://api.github.com/users/satnam6502/followers","following_url":"https://api.github.com/users/satnam6502/following{/other_user}","gists_url":"https://api.github.com/users/satnam6502/gists{/gist_id}","starred_url":"https://api.github.com/users/satnam6502/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satnam6502/subscriptions","organizations_url":"https://api.github.com/users/satnam6502/orgs","repos_url":"https://api.github.com/users/satnam6502/repos","events_url":"https://api.github.com/users/satnam6502/events{/privacy}","received_events_url":"https://api.github.com/users/satnam6502/received_events","type":"User","site_admin":false},"repo":{"id":23904068,"name":"kubernetes","full_name":"satnam6502/kubernetes","owner":{"login":"satnam6502","id":6164339,"avatar_url":"https://avatars.githubusercontent.com/u/6164339?v=3","gravatar_id":"","url":"https://api.github.com/users/satnam6502","html_url":"https://github.com/satnam6502","followers_url":"https://api.github.com/users/satnam6502/followers","following_url":"https://api.github.com/users/satnam6502/following{/other_user}","gists_url":"https://api.github.com/users/satnam6502/gists{/gist_id}","starred_url":"https://api.github.com/users/satnam6502/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satnam6502/subscriptions","organizations_url":"https://api.github.com/users/satnam6502/orgs","repos_url":"https://api.github.com/users/satnam6502/repos","events_url":"https://api.github.com/users/satnam6502/events{/privacy}","received_events_url":"https://api.github.com/users/satnam6502/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/satnam6502/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/satnam6502/kubernetes","forks_url":"https://api.github.com/repos/satnam6502/kubernetes/forks","keys_url":"https://api.github.com/repos/satnam6502/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/satnam6502/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/satnam6502/kubernetes/teams","hooks_url":"https://api.github.com/repos/satnam6502/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/satnam6502/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/satnam6502/kubernetes/events","assignees_url":"https://api.github.com/repos/satnam6502/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/satnam6502/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/satnam6502/kubernetes/tags","blobs_url":"https://api.github.com/repos/satnam6502/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/satnam6502/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/satnam6502/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/satnam6502/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/satnam6502/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/satnam6502/kubernetes/languages","stargazers_url":"https://api.github.com/repos/satnam6502/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/satnam6502/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/satnam6502/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/satnam6502/kubernetes/subscription","commits_url":"https://api.github.com/repos/satnam6502/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/satnam6502/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/satnam6502/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/satnam6502/kubernetes/issues/comments/{number}","contents_url":"https://api.github.com/repos/satnam6502/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/satnam6502/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/satnam6502/kubernetes/merges","archive_url":"https://api.github.com/repos/satnam6502/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/satnam6502/kubernetes/downloads","issues_url":"https://api.github.com/repos/satnam6502/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/satnam6502/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/satnam6502/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/satnam6502/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/satnam6502/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/satnam6502/kubernetes/releases{/id}","created_at":"2014-09-11T04:27:10Z","updated_at":"2014-12-16T18:24:26Z","pushed_at":"2015-01-09T02:29:23Z","git_url":"git://github.com/satnam6502/kubernetes.git","ssh_url":"git@github.com:satnam6502/kubernetes.git","clone_url":"https://github.com/satnam6502/kubernetes.git","svn_url":"https://github.com/satnam6502/kubernetes","homepage":null,"size":23197,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"d2f84797936e2e20cdc7d82d6a51e06a9091e6a1","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments/{number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-01-09T04:14:26Z","pushed_at":"2015-01-09T03:53:34Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":null,"size":51655,"stargazers_count":5681,"watchers_count":5681,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":902,"mirror_url":null,"open_issues_count":538,"forks":902,"open_issues":538,"watchers":5681,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/3292"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/3292"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/3292"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/3292/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/3292/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/3292/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/958893e7d625806aae7ebd8c7af5e437d65728f9"}}}}