{"action":"created","comment":{"url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/comments/48138816","id":48138816,"diff_hunk":"@@ -66,7 +65,7 @@\n  * @author Emmanuel Bernard\n  * @author Hardy Ferentschik\n  */\n-public class LuceneHSQuery extends AbstractHSQuery implements HSQuery, Serializable {","path":"engine/src/main/java/org/hibernate/search/query/engine/impl/LuceneHSQuery.java","position":12,"original_position":12,"commit_id":"50d40139c83e2f3d819b83fe86d41f9c25599ffe","original_commit_id":"50d40139c83e2f3d819b83fe86d41f9c25599ffe","user":{"login":"gustavonalle","id":440989,"avatar_url":"https://avatars.githubusercontent.com/u/440989?v=3","gravatar_id":"","url":"https://api.github.com/users/gustavonalle","html_url":"https://github.com/gustavonalle","followers_url":"https://api.github.com/users/gustavonalle/followers","following_url":"https://api.github.com/users/gustavonalle/following{/other_user}","gists_url":"https://api.github.com/users/gustavonalle/gists{/gist_id}","starred_url":"https://api.github.com/users/gustavonalle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gustavonalle/subscriptions","organizations_url":"https://api.github.com/users/gustavonalle/orgs","repos_url":"https://api.github.com/users/gustavonalle/repos","events_url":"https://api.github.com/users/gustavonalle/events{/privacy}","received_events_url":"https://api.github.com/users/gustavonalle/received_events","type":"User","site_admin":false},"body":"> In practice, it's LuceneHSQuery which you need to be serializable, right?\r\n \r\nYep, that's the one causing trouble, although I haven't tested yet with ```ElasticSearchHSQueryImpl``` so I though it'd make sense for both to be Serializable","created_at":"2015-12-21T11:48:40Z","updated_at":"2015-12-21T11:48:40Z","html_url":"https://github.com/hibernate/hibernate-search/pull/964#discussion_r48138816","pull_request_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/964","_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/comments/48138816"},"html":{"href":"https://github.com/hibernate/hibernate-search/pull/964#discussion_r48138816"},"pull_request":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/964"}}},"pull_request":{"url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/964","id":54093405,"html_url":"https://github.com/hibernate/hibernate-search/pull/964","diff_url":"https://github.com/hibernate/hibernate-search/pull/964.diff","patch_url":"https://github.com/hibernate/hibernate-search/pull/964.patch","issue_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/964","number":964,"state":"open","locked":false,"title":"HSEARCH-2073 LuceneHSQuery cannot be deserialized","user":{"login":"gustavonalle","id":440989,"avatar_url":"https://avatars.githubusercontent.com/u/440989?v=3","gravatar_id":"","url":"https://api.github.com/users/gustavonalle","html_url":"https://github.com/gustavonalle","followers_url":"https://api.github.com/users/gustavonalle/followers","following_url":"https://api.github.com/users/gustavonalle/following{/other_user}","gists_url":"https://api.github.com/users/gustavonalle/gists{/gist_id}","starred_url":"https://api.github.com/users/gustavonalle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gustavonalle/subscriptions","organizations_url":"https://api.github.com/users/gustavonalle/orgs","repos_url":"https://api.github.com/users/gustavonalle/repos","events_url":"https://api.github.com/users/gustavonalle/events{/privacy}","received_events_url":"https://api.github.com/users/gustavonalle/received_events","type":"User","site_admin":false},"body":"https://hibernate.atlassian.net/browse/HSEARCH-2073","created_at":"2015-12-18T11:40:45Z","updated_at":"2015-12-21T11:48:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e80c8136a3cb60601cd4be868bcd95f8eb37bbba","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/964/commits","review_comments_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/964/comments","review_comment_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/964/comments","statuses_url":"https://api.github.com/repos/hibernate/hibernate-search/statuses/50d40139c83e2f3d819b83fe86d41f9c25599ffe","head":{"label":"gustavonalle:query_serialization","ref":"query_serialization","sha":"50d40139c83e2f3d819b83fe86d41f9c25599ffe","user":{"login":"gustavonalle","id":440989,"avatar_url":"https://avatars.githubusercontent.com/u/440989?v=3","gravatar_id":"","url":"https://api.github.com/users/gustavonalle","html_url":"https://github.com/gustavonalle","followers_url":"https://api.github.com/users/gustavonalle/followers","following_url":"https://api.github.com/users/gustavonalle/following{/other_user}","gists_url":"https://api.github.com/users/gustavonalle/gists{/gist_id}","starred_url":"https://api.github.com/users/gustavonalle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gustavonalle/subscriptions","organizations_url":"https://api.github.com/users/gustavonalle/orgs","repos_url":"https://api.github.com/users/gustavonalle/repos","events_url":"https://api.github.com/users/gustavonalle/events{/privacy}","received_events_url":"https://api.github.com/users/gustavonalle/received_events","type":"User","site_admin":false},"repo":{"id":990384,"name":"hibernate-search","full_name":"gustavonalle/hibernate-search","owner":{"login":"gustavonalle","id":440989,"avatar_url":"https://avatars.githubusercontent.com/u/440989?v=3","gravatar_id":"","url":"https://api.github.com/users/gustavonalle","html_url":"https://github.com/gustavonalle","followers_url":"https://api.github.com/users/gustavonalle/followers","following_url":"https://api.github.com/users/gustavonalle/following{/other_user}","gists_url":"https://api.github.com/users/gustavonalle/gists{/gist_id}","starred_url":"https://api.github.com/users/gustavonalle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gustavonalle/subscriptions","organizations_url":"https://api.github.com/users/gustavonalle/orgs","repos_url":"https://api.github.com/users/gustavonalle/repos","events_url":"https://api.github.com/users/gustavonalle/events{/privacy}","received_events_url":"https://api.github.com/users/gustavonalle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gustavonalle/hibernate-search","description":"Hibernate Search: full-text search for domain model","fork":true,"url":"https://api.github.com/repos/gustavonalle/hibernate-search","forks_url":"https://api.github.com/repos/gustavonalle/hibernate-search/forks","keys_url":"https://api.github.com/repos/gustavonalle/hibernate-search/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gustavonalle/hibernate-search/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gustavonalle/hibernate-search/teams","hooks_url":"https://api.github.com/repos/gustavonalle/hibernate-search/hooks","issue_events_url":"https://api.github.com/repos/gustavonalle/hibernate-search/issues/events{/number}","events_url":"https://api.github.com/repos/gustavonalle/hibernate-search/events","assignees_url":"https://api.github.com/repos/gustavonalle/hibernate-search/assignees{/user}","branches_url":"https://api.github.com/repos/gustavonalle/hibernate-search/branches{/branch}","tags_url":"https://api.github.com/repos/gustavonalle/hibernate-search/tags","blobs_url":"https://api.github.com/repos/gustavonalle/hibernate-search/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gustavonalle/hibernate-search/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gustavonalle/hibernate-search/git/refs{/sha}","trees_url":"https://api.github.com/repos/gustavonalle/hibernate-search/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gustavonalle/hibernate-search/statuses/{sha}","languages_url":"https://api.github.com/repos/gustavonalle/hibernate-search/languages","stargazers_url":"https://api.github.com/repos/gustavonalle/hibernate-search/stargazers","contributors_url":"https://api.github.com/repos/gustavonalle/hibernate-search/contributors","subscribers_url":"https://api.github.com/repos/gustavonalle/hibernate-search/subscribers","subscription_url":"https://api.github.com/repos/gustavonalle/hibernate-search/subscription","commits_url":"https://api.github.com/repos/gustavonalle/hibernate-search/commits{/sha}","git_commits_url":"https://api.github.com/repos/gustavonalle/hibernate-search/git/commits{/sha}","comments_url":"https://api.github.com/repos/gustavonalle/hibernate-search/comments{/number}","issue_comment_url":"https://api.github.com/repos/gustavonalle/hibernate-search/issues/comments{/number}","contents_url":"https://api.github.com/repos/gustavonalle/hibernate-search/contents/{+path}","compare_url":"https://api.github.com/repos/gustavonalle/hibernate-search/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gustavonalle/hibernate-search/merges","archive_url":"https://api.github.com/repos/gustavonalle/hibernate-search/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gustavonalle/hibernate-search/downloads","issues_url":"https://api.github.com/repos/gustavonalle/hibernate-search/issues{/number}","pulls_url":"https://api.github.com/repos/gustavonalle/hibernate-search/pulls{/number}","milestones_url":"https://api.github.com/repos/gustavonalle/hibernate-search/milestones{/number}","notifications_url":"https://api.github.com/repos/gustavonalle/hibernate-search/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gustavonalle/hibernate-search/labels{/name}","releases_url":"https://api.github.com/repos/gustavonalle/hibernate-search/releases{/id}","created_at":"2010-10-15T16:35:41Z","updated_at":"2015-03-10T17:41:23Z","pushed_at":"2015-12-18T11:40:01Z","git_url":"git://github.com/gustavonalle/hibernate-search.git","ssh_url":"git@github.com:gustavonalle/hibernate-search.git","clone_url":"https://github.com/gustavonalle/hibernate-search.git","svn_url":"https://github.com/gustavonalle/hibernate-search","homepage":"http://search.hibernate.org","size":43491,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hibernate:master","ref":"master","sha":"f613db94cae7c4256c3266187ac7e61dfec87b77","user":{"login":"hibernate","id":348262,"avatar_url":"https://avatars.githubusercontent.com/u/348262?v=3","gravatar_id":"","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"repo":{"id":990281,"name":"hibernate-search","full_name":"hibernate/hibernate-search","owner":{"login":"hibernate","id":348262,"avatar_url":"https://avatars.githubusercontent.com/u/348262?v=3","gravatar_id":"","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hibernate/hibernate-search","description":"Hibernate Search: full-text search for domain model","fork":false,"url":"https://api.github.com/repos/hibernate/hibernate-search","forks_url":"https://api.github.com/repos/hibernate/hibernate-search/forks","keys_url":"https://api.github.com/repos/hibernate/hibernate-search/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hibernate/hibernate-search/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hibernate/hibernate-search/teams","hooks_url":"https://api.github.com/repos/hibernate/hibernate-search/hooks","issue_events_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/events{/number}","events_url":"https://api.github.com/repos/hibernate/hibernate-search/events","assignees_url":"https://api.github.com/repos/hibernate/hibernate-search/assignees{/user}","branches_url":"https://api.github.com/repos/hibernate/hibernate-search/branches{/branch}","tags_url":"https://api.github.com/repos/hibernate/hibernate-search/tags","blobs_url":"https://api.github.com/repos/hibernate/hibernate-search/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hibernate/hibernate-search/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hibernate/hibernate-search/git/refs{/sha}","trees_url":"https://api.github.com/repos/hibernate/hibernate-search/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hibernate/hibernate-search/statuses/{sha}","languages_url":"https://api.github.com/repos/hibernate/hibernate-search/languages","stargazers_url":"https://api.github.com/repos/hibernate/hibernate-search/stargazers","contributors_url":"https://api.github.com/repos/hibernate/hibernate-search/contributors","subscribers_url":"https://api.github.com/repos/hibernate/hibernate-search/subscribers","subscription_url":"https://api.github.com/repos/hibernate/hibernate-search/subscription","commits_url":"https://api.github.com/repos/hibernate/hibernate-search/commits{/sha}","git_commits_url":"https://api.github.com/repos/hibernate/hibernate-search/git/commits{/sha}","comments_url":"https://api.github.com/repos/hibernate/hibernate-search/comments{/number}","issue_comment_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/comments{/number}","contents_url":"https://api.github.com/repos/hibernate/hibernate-search/contents/{+path}","compare_url":"https://api.github.com/repos/hibernate/hibernate-search/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hibernate/hibernate-search/merges","archive_url":"https://api.github.com/repos/hibernate/hibernate-search/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hibernate/hibernate-search/downloads","issues_url":"https://api.github.com/repos/hibernate/hibernate-search/issues{/number}","pulls_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls{/number}","milestones_url":"https://api.github.com/repos/hibernate/hibernate-search/milestones{/number}","notifications_url":"https://api.github.com/repos/hibernate/hibernate-search/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hibernate/hibernate-search/labels{/name}","releases_url":"https://api.github.com/repos/hibernate/hibernate-search/releases{/id}","created_at":"2010-10-15T15:55:09Z","updated_at":"2015-12-20T08:20:57Z","pushed_at":"2015-12-21T11:41:09Z","git_url":"git://github.com/hibernate/hibernate-search.git","ssh_url":"git@github.com:hibernate/hibernate-search.git","clone_url":"https://github.com/hibernate/hibernate-search.git","svn_url":"https://github.com/hibernate/hibernate-search","homepage":"http://search.hibernate.org","size":50836,"stargazers_count":165,"watchers_count":165,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":113,"mirror_url":null,"open_issues_count":9,"forks":113,"open_issues":9,"watchers":165,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/964"},"html":{"href":"https://github.com/hibernate/hibernate-search/pull/964"},"issue":{"href":"https://api.github.com/repos/hibernate/hibernate-search/issues/964"},"comments":{"href":"https://api.github.com/repos/hibernate/hibernate-search/issues/964/comments"},"review_comments":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/964/comments"},"review_comment":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/964/commits"},"statuses":{"href":"https://api.github.com/repos/hibernate/hibernate-search/statuses/50d40139c83e2f3d819b83fe86d41f9c25599ffe"}}}}