{"action":"created","issue":{"url":"https://api.github.com/repos/chrismccord/sync/issues/198","labels_url":"https://api.github.com/repos/chrismccord/sync/issues/198/labels{/name}","comments_url":"https://api.github.com/repos/chrismccord/sync/issues/198/comments","events_url":"https://api.github.com/repos/chrismccord/sync/issues/198/events","html_url":"https://github.com/chrismccord/sync/issues/198","id":96236734,"number":198,"title":"Google recognising IDs in generated JavaScript as URLs","user":{"login":"henare","id":48945,"avatar_url":"https://avatars.githubusercontent.com/u/48945?v=3","gravatar_id":"","url":"https://api.github.com/users/henare","html_url":"https://github.com/henare","followers_url":"https://api.github.com/users/henare/followers","following_url":"https://api.github.com/users/henare/following{/other_user}","gists_url":"https://api.github.com/users/henare/gists{/gist_id}","starred_url":"https://api.github.com/users/henare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henare/subscriptions","organizations_url":"https://api.github.com/users/henare/orgs","repos_url":"https://api.github.com/users/henare/repos","events_url":"https://api.github.com/users/henare/events{/privacy}","received_events_url":"https://api.github.com/users/henare/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-21T06:06:17Z","updated_at":"2015-07-21T16:56:39Z","closed_at":null,"body":"Thank you for this Gem! We use it on morph.io and noticed that Google Webmaster Tools was finding a lot of URLs it couldn't crawl: https://github.com/openaustralia/morph/issues/745\r\n\r\nIt turns out that because of the preceeding `/` in things like the `authToken` in the generated JavaScript, Google thinks they might be URLs so it tries to crawl them. Is it feasible to change this (maybe just removing the leading `/`)?\r\n\r\nIf the answer is no it's not a major problem (it doesn't impact your site's ranking) and I'll happily contribute a note to the README so it doesn't confuse other people."},"comment":{"url":"https://api.github.com/repos/chrismccord/sync/issues/comments/123401738","html_url":"https://github.com/chrismccord/sync/issues/198#issuecomment-123401738","issue_url":"https://api.github.com/repos/chrismccord/sync/issues/198","id":123401738,"user":{"login":"ajb","id":1270317,"avatar_url":"https://avatars.githubusercontent.com/u/1270317?v=3","gravatar_id":"","url":"https://api.github.com/users/ajb","html_url":"https://github.com/ajb","followers_url":"https://api.github.com/users/ajb/followers","following_url":"https://api.github.com/users/ajb/following{/other_user}","gists_url":"https://api.github.com/users/ajb/gists{/gist_id}","starred_url":"https://api.github.com/users/ajb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajb/subscriptions","organizations_url":"https://api.github.com/users/ajb/orgs","repos_url":"https://api.github.com/users/ajb/repos","events_url":"https://api.github.com/users/ajb/events{/privacy}","received_events_url":"https://api.github.com/users/ajb/received_events","type":"User","site_admin":false},"created_at":"2015-07-21T16:56:39Z","updated_at":"2015-07-21T16:56:39Z","body":"Hey @henare, thanks for opening the issue. It looks like Faye requires channel names to start with the `/`: http://faye.jcoglan.com/browser/subscribing.html\r\n\r\nHere's where we're generating the channel name in our lib. I didn't write that code, but it looks pretty deliberate: https://github.com/chrismccord/sync/blob/6ff1f7e5a167947daf8be46b5f3cee21e2d038b9/lib/sync/clients/faye.rb#L24\r\n\r\nWe could try appending the `/` via javascript, instead of adding it to the `data-*` attribute? But it seems like a lot of work for something that [you can safely ignore](https://support.google.com/webmasters/answer/2409439?ctx=MCE&ctx=NF)."}}