{"action":"created","comment":{"url":"https://api.github.com/repos/apache/couchdb-couch/pulls/comments/41581691","id":41581691,"diff_hunk":"@@ -38,10 +38,15 @@ try_compile(Proc, FunctionType, FunctionName, FunctionSource) ->\n     try\n         proc_prompt(Proc, [<<\"add_fun\">>, FunctionSource]),\n         ok\n-    catch {compilation_error, E} ->\n-        Fmt = \"Compilation of the ~s function in the '~s' view failed: ~s\",\n-        Msg = io_lib:format(Fmt, [FunctionType, FunctionName, E]),\n-        throw({compilation_error, Msg})\n+    catch\n+        {compilation_error, E} ->\n+            Fmt = \"Compilation of the ~s function in the '~s' view failed: ~s\",\n+            Msg = io_lib:format(Fmt, [FunctionType, FunctionName, E]),\n+            throw({compilation_error, Msg});\n+        {os_process_error, {exit_status,PErr}} ->","path":"src/couch_query_servers.erl","position":13,"original_position":13,"commit_id":"1b09af3326d69786ee2054ff63f9ba295d9f29b4","original_commit_id":"1b09af3326d69786ee2054ff63f9ba295d9f29b4","user":{"login":"rnewson","id":47223,"avatar_url":"https://avatars.githubusercontent.com/u/47223?v=3","gravatar_id":"","url":"https://api.github.com/users/rnewson","html_url":"https://github.com/rnewson","followers_url":"https://api.github.com/users/rnewson/followers","following_url":"https://api.github.com/users/rnewson/following{/other_user}","gists_url":"https://api.github.com/users/rnewson/gists{/gist_id}","starred_url":"https://api.github.com/users/rnewson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnewson/subscriptions","organizations_url":"https://api.github.com/users/rnewson/orgs","repos_url":"https://api.github.com/users/rnewson/repos","events_url":"https://api.github.com/users/rnewson/events{/privacy}","received_events_url":"https://api.github.com/users/rnewson/received_events","type":"User","site_admin":false},"body":"and a better name? `ExitCode`, say.","created_at":"2015-10-08T23:16:39Z","updated_at":"2015-10-08T23:16:39Z","html_url":"https://github.com/apache/couchdb-couch/pull/117#discussion_r41581691","pull_request_url":"https://api.github.com/repos/apache/couchdb-couch/pulls/117","_links":{"self":{"href":"https://api.github.com/repos/apache/couchdb-couch/pulls/comments/41581691"},"html":{"href":"https://github.com/apache/couchdb-couch/pull/117#discussion_r41581691"},"pull_request":{"href":"https://api.github.com/repos/apache/couchdb-couch/pulls/117"}}},"pull_request":{"url":"https://api.github.com/repos/apache/couchdb-couch/pulls/117","id":47195101,"html_url":"https://github.com/apache/couchdb-couch/pull/117","diff_url":"https://github.com/apache/couchdb-couch/pull/117.diff","patch_url":"https://github.com/apache/couchdb-couch/pull/117.patch","issue_url":"https://api.github.com/repos/apache/couchdb-couch/issues/117","number":117,"state":"open","locked":false,"title":"Handle view server crashing during test compile of view functions.","user":{"login":"nickva","id":211822,"avatar_url":"https://avatars.githubusercontent.com/u/211822?v=3","gravatar_id":"","url":"https://api.github.com/users/nickva","html_url":"https://github.com/nickva","followers_url":"https://api.github.com/users/nickva/followers","following_url":"https://api.github.com/users/nickva/following{/other_user}","gists_url":"https://api.github.com/users/nickva/gists{/gist_id}","starred_url":"https://api.github.com/users/nickva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickva/subscriptions","organizations_url":"https://api.github.com/users/nickva/orgs","repos_url":"https://api.github.com/users/nickva/repos","events_url":"https://api.github.com/users/nickva/events{/privacy}","received_events_url":"https://api.github.com/users/nickva/received_events","type":"User","site_admin":false},"body":"Due to how libmozjs185 library is compiled on Ubuntu 12.04, given\r\ninvalid JS code, it will not return with expected error result:\r\n\r\n [\"error\",\"compilation_error\",...]\r\n\r\nbut will crash. Otherwise library seems functional --  it passes\r\nall other mrview tests.\r\n\r\nHandle this crash in try_compile() function as a compilation\r\nfailure. Error message contains the exit status of the view process\r\nto help debugging.","created_at":"2015-10-08T19:24:13Z","updated_at":"2015-10-08T23:16:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8cbe4c0ed7042df1518462a8bb59d6a3d5e3da08","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/couchdb-couch/pulls/117/commits","review_comments_url":"https://api.github.com/repos/apache/couchdb-couch/pulls/117/comments","review_comment_url":"https://api.github.com/repos/apache/couchdb-couch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/couchdb-couch/issues/117/comments","statuses_url":"https://api.github.com/repos/apache/couchdb-couch/statuses/1b09af3326d69786ee2054ff63f9ba295d9f29b4","head":{"label":"cloudant:handle-view-server-crash-on-ubuntu1204","ref":"handle-view-server-crash-on-ubuntu1204","sha":"1b09af3326d69786ee2054ff63f9ba295d9f29b4","user":{"login":"cloudant","id":44642,"avatar_url":"https://avatars.githubusercontent.com/u/44642?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudant","html_url":"https://github.com/cloudant","followers_url":"https://api.github.com/users/cloudant/followers","following_url":"https://api.github.com/users/cloudant/following{/other_user}","gists_url":"https://api.github.com/users/cloudant/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudant/subscriptions","organizations_url":"https://api.github.com/users/cloudant/orgs","repos_url":"https://api.github.com/users/cloudant/repos","events_url":"https://api.github.com/users/cloudant/events{/privacy}","received_events_url":"https://api.github.com/users/cloudant/received_events","type":"Organization","site_admin":false},"repo":{"id":30254957,"name":"couchdb-couch","full_name":"cloudant/couchdb-couch","owner":{"login":"cloudant","id":44642,"avatar_url":"https://avatars.githubusercontent.com/u/44642?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudant","html_url":"https://github.com/cloudant","followers_url":"https://api.github.com/users/cloudant/followers","following_url":"https://api.github.com/users/cloudant/following{/other_user}","gists_url":"https://api.github.com/users/cloudant/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudant/subscriptions","organizations_url":"https://api.github.com/users/cloudant/orgs","repos_url":"https://api.github.com/users/cloudant/repos","events_url":"https://api.github.com/users/cloudant/events{/privacy}","received_events_url":"https://api.github.com/users/cloudant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudant/couchdb-couch","description":"Mirror of Apache CouchDB","fork":true,"url":"https://api.github.com/repos/cloudant/couchdb-couch","forks_url":"https://api.github.com/repos/cloudant/couchdb-couch/forks","keys_url":"https://api.github.com/repos/cloudant/couchdb-couch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudant/couchdb-couch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudant/couchdb-couch/teams","hooks_url":"https://api.github.com/repos/cloudant/couchdb-couch/hooks","issue_events_url":"https://api.github.com/repos/cloudant/couchdb-couch/issues/events{/number}","events_url":"https://api.github.com/repos/cloudant/couchdb-couch/events","assignees_url":"https://api.github.com/repos/cloudant/couchdb-couch/assignees{/user}","branches_url":"https://api.github.com/repos/cloudant/couchdb-couch/branches{/branch}","tags_url":"https://api.github.com/repos/cloudant/couchdb-couch/tags","blobs_url":"https://api.github.com/repos/cloudant/couchdb-couch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudant/couchdb-couch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudant/couchdb-couch/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudant/couchdb-couch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudant/couchdb-couch/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudant/couchdb-couch/languages","stargazers_url":"https://api.github.com/repos/cloudant/couchdb-couch/stargazers","contributors_url":"https://api.github.com/repos/cloudant/couchdb-couch/contributors","subscribers_url":"https://api.github.com/repos/cloudant/couchdb-couch/subscribers","subscription_url":"https://api.github.com/repos/cloudant/couchdb-couch/subscription","commits_url":"https://api.github.com/repos/cloudant/couchdb-couch/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudant/couchdb-couch/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudant/couchdb-couch/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudant/couchdb-couch/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudant/couchdb-couch/contents/{+path}","compare_url":"https://api.github.com/repos/cloudant/couchdb-couch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudant/couchdb-couch/merges","archive_url":"https://api.github.com/repos/cloudant/couchdb-couch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudant/couchdb-couch/downloads","issues_url":"https://api.github.com/repos/cloudant/couchdb-couch/issues{/number}","pulls_url":"https://api.github.com/repos/cloudant/couchdb-couch/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudant/couchdb-couch/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudant/couchdb-couch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudant/couchdb-couch/labels{/name}","releases_url":"https://api.github.com/repos/cloudant/couchdb-couch/releases{/id}","created_at":"2015-02-03T17:22:52Z","updated_at":"2015-05-07T13:23:50Z","pushed_at":"2015-10-08T19:23:30Z","git_url":"git://github.com/cloudant/couchdb-couch.git","ssh_url":"git@github.com:cloudant/couchdb-couch.git","clone_url":"https://github.com/cloudant/couchdb-couch.git","svn_url":"https://github.com/cloudant/couchdb-couch","homepage":null,"size":3138,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"33bc0608602f100527d1e00d8b3dbedf938647dd","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":15993607,"name":"couchdb-couch","full_name":"apache/couchdb-couch","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/couchdb-couch","description":"Mirror of Apache CouchDB","fork":false,"url":"https://api.github.com/repos/apache/couchdb-couch","forks_url":"https://api.github.com/repos/apache/couchdb-couch/forks","keys_url":"https://api.github.com/repos/apache/couchdb-couch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/couchdb-couch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/couchdb-couch/teams","hooks_url":"https://api.github.com/repos/apache/couchdb-couch/hooks","issue_events_url":"https://api.github.com/repos/apache/couchdb-couch/issues/events{/number}","events_url":"https://api.github.com/repos/apache/couchdb-couch/events","assignees_url":"https://api.github.com/repos/apache/couchdb-couch/assignees{/user}","branches_url":"https://api.github.com/repos/apache/couchdb-couch/branches{/branch}","tags_url":"https://api.github.com/repos/apache/couchdb-couch/tags","blobs_url":"https://api.github.com/repos/apache/couchdb-couch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/couchdb-couch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/couchdb-couch/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/couchdb-couch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/couchdb-couch/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/couchdb-couch/languages","stargazers_url":"https://api.github.com/repos/apache/couchdb-couch/stargazers","contributors_url":"https://api.github.com/repos/apache/couchdb-couch/contributors","subscribers_url":"https://api.github.com/repos/apache/couchdb-couch/subscribers","subscription_url":"https://api.github.com/repos/apache/couchdb-couch/subscription","commits_url":"https://api.github.com/repos/apache/couchdb-couch/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/couchdb-couch/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/couchdb-couch/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/couchdb-couch/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/couchdb-couch/contents/{+path}","compare_url":"https://api.github.com/repos/apache/couchdb-couch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/couchdb-couch/merges","archive_url":"https://api.github.com/repos/apache/couchdb-couch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/couchdb-couch/downloads","issues_url":"https://api.github.com/repos/apache/couchdb-couch/issues{/number}","pulls_url":"https://api.github.com/repos/apache/couchdb-couch/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/couchdb-couch/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/couchdb-couch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/couchdb-couch/labels{/name}","releases_url":"https://api.github.com/repos/apache/couchdb-couch/releases{/id}","created_at":"2014-01-17T08:00:08Z","updated_at":"2015-09-23T14:29:49Z","pushed_at":"2015-10-08T19:24:14Z","git_url":"git://github.com/apache/couchdb-couch.git","ssh_url":"git@github.com:apache/couchdb-couch.git","clone_url":"https://github.com/apache/couchdb-couch.git","svn_url":"https://github.com/apache/couchdb-couch","homepage":null,"size":4947,"stargazers_count":23,"watchers_count":23,"language":"Erlang","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":33,"mirror_url":"git://git.apache.org/couchdb-couch.git","open_issues_count":18,"forks":33,"open_issues":18,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/couchdb-couch/pulls/117"},"html":{"href":"https://github.com/apache/couchdb-couch/pull/117"},"issue":{"href":"https://api.github.com/repos/apache/couchdb-couch/issues/117"},"comments":{"href":"https://api.github.com/repos/apache/couchdb-couch/issues/117/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/couchdb-couch/pulls/117/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/couchdb-couch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/couchdb-couch/pulls/117/commits"},"statuses":{"href":"https://api.github.com/repos/apache/couchdb-couch/statuses/1b09af3326d69786ee2054ff63f9ba295d9f29b4"}}}}