{"action":"created","issue":{"url":"https://api.github.com/repos/twitter/twemproxy/issues/324","labels_url":"https://api.github.com/repos/twitter/twemproxy/issues/324/labels{/name}","comments_url":"https://api.github.com/repos/twitter/twemproxy/issues/324/comments","events_url":"https://api.github.com/repos/twitter/twemproxy/issues/324/events","html_url":"https://github.com/twitter/twemproxy/pull/324","id":59514557,"number":324,"title":"twemproxy work with redis-sentinel","user":{"login":"andyqzb","id":3446014,"avatar_url":"https://avatars.githubusercontent.com/u/3446014?v=3","gravatar_id":"","url":"https://api.github.com/users/andyqzb","html_url":"https://github.com/andyqzb","followers_url":"https://api.github.com/users/andyqzb/followers","following_url":"https://api.github.com/users/andyqzb/following{/other_user}","gists_url":"https://api.github.com/users/andyqzb/gists{/gist_id}","starred_url":"https://api.github.com/users/andyqzb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyqzb/subscriptions","organizations_url":"https://api.github.com/users/andyqzb/orgs","repos_url":"https://api.github.com/users/andyqzb/repos","events_url":"https://api.github.com/users/andyqzb/events{/privacy}","received_events_url":"https://api.github.com/users/andyqzb/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":25,"created_at":"2015-03-02T17:37:39Z","updated_at":"2015-07-17T00:06:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/twitter/twemproxy/pulls/324","html_url":"https://github.com/twitter/twemproxy/pull/324","diff_url":"https://github.com/twitter/twemproxy/pull/324.diff","patch_url":"https://github.com/twitter/twemproxy/pull/324.patch"},"body":"Hi, @manjuraj @idning , I made a patch for twemproxy to let it work with redis-sentinel.\r\nThis patch is implemented as the design mentioned in issue 297.\r\n\r\nIn addition, I add keepalive to the sentinel pub/sub connection. Because sentinel pub/sub connection don't have heartbeat, we must add keepalive to check if the connection is dead. The implemention of nc_set_keepalive is copied from redis.\r\n\r\nYou can configure a server_pool like sigma in conf/nutcracker.yml to use this feature.\r\n\r\nI hope to hear your feedback about this patch."},"comment":{"url":"https://api.github.com/repos/twitter/twemproxy/issues/comments/122134299","html_url":"https://github.com/twitter/twemproxy/pull/324#issuecomment-122134299","issue_url":"https://api.github.com/repos/twitter/twemproxy/issues/324","id":122134299,"user":{"login":"mishan","id":788577,"avatar_url":"https://avatars.githubusercontent.com/u/788577?v=3","gravatar_id":"","url":"https://api.github.com/users/mishan","html_url":"https://github.com/mishan","followers_url":"https://api.github.com/users/mishan/followers","following_url":"https://api.github.com/users/mishan/following{/other_user}","gists_url":"https://api.github.com/users/mishan/gists{/gist_id}","starred_url":"https://api.github.com/users/mishan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mishan/subscriptions","organizations_url":"https://api.github.com/users/mishan/orgs","repos_url":"https://api.github.com/users/mishan/repos","events_url":"https://api.github.com/users/mishan/events{/privacy}","received_events_url":"https://api.github.com/users/mishan/received_events","type":"User","site_admin":false},"created_at":"2015-07-17T00:06:59Z","updated_at":"2015-07-17T00:06:59Z","body":"Well it's happily running on production handling requests from an application to a Redis \"cluster\" (not Redis Cluster) doing 1MB/s -- tests on dev/stage I've done were pretty good. I haven't had a chance to do failover tests under production load yet, that's next."}}