{"action":"created","issue":{"url":"https://api.github.com/repos/theforeman/foreman-docker/issues/108","labels_url":"https://api.github.com/repos/theforeman/foreman-docker/issues/108/labels{/name}","comments_url":"https://api.github.com/repos/theforeman/foreman-docker/issues/108/comments","events_url":"https://api.github.com/repos/theforeman/foreman-docker/issues/108/events","html_url":"https://github.com/theforeman/foreman-docker/pull/108","id":67276175,"number":108,"title":"Fixes #7865 - Adds support for configuring dns during container creation","user":{"login":"dragonfly9517","id":5465412,"avatar_url":"https://avatars.githubusercontent.com/u/5465412?v=3","gravatar_id":"","url":"https://api.github.com/users/dragonfly9517","html_url":"https://github.com/dragonfly9517","followers_url":"https://api.github.com/users/dragonfly9517/followers","following_url":"https://api.github.com/users/dragonfly9517/following{/other_user}","gists_url":"https://api.github.com/users/dragonfly9517/gists{/gist_id}","starred_url":"https://api.github.com/users/dragonfly9517/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dragonfly9517/subscriptions","organizations_url":"https://api.github.com/users/dragonfly9517/orgs","repos_url":"https://api.github.com/users/dragonfly9517/repos","events_url":"https://api.github.com/users/dragonfly9517/events{/privacy}","received_events_url":"https://api.github.com/users/dragonfly9517/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/theforeman/foreman-docker/labels/Needs%20testing","name":"Needs testing","color":"fbca04"},{"url":"https://api.github.com/repos/theforeman/foreman-docker/labels/Not%20yet%20reviewed","name":"Not yet reviewed","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-04-09T04:07:17Z","updated_at":"2015-04-09T21:06:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman-docker/pulls/108","html_url":"https://github.com/theforeman/foreman-docker/pull/108","diff_url":"https://github.com/theforeman/foreman-docker/pull/108.diff","patch_url":"https://github.com/theforeman/foreman-docker/pull/108.patch"},"body":"Please review this commit which adds support for configuring DNS.\r\n\r\nThis can be merged **without** upgrading `Fog`. \r\nI am accessing the DNS entries by accessing it through the collection of all `attributes` that come bundled with `@container.in_fog` (pretty much the same way `config_env` is being accessed). After my pull request to `Fog` gets through, we would be able to access `:dns` variables using something like `@container.in_fog.dns` instead of `@container.in_fog.attributes['host_config_dns']`\r\n\r\nI am still struggling with the tests. I will write the tests and push a new commit on this pull request soon. "},"comment":{"url":"https://api.github.com/repos/theforeman/foreman-docker/issues/comments/91356211","html_url":"https://github.com/theforeman/foreman-docker/pull/108#issuecomment-91356211","issue_url":"https://api.github.com/repos/theforeman/foreman-docker/issues/108","id":91356211,"user":{"login":"dragonfly9517","id":5465412,"avatar_url":"https://avatars.githubusercontent.com/u/5465412?v=3","gravatar_id":"","url":"https://api.github.com/users/dragonfly9517","html_url":"https://github.com/dragonfly9517","followers_url":"https://api.github.com/users/dragonfly9517/followers","following_url":"https://api.github.com/users/dragonfly9517/following{/other_user}","gists_url":"https://api.github.com/users/dragonfly9517/gists{/gist_id}","starred_url":"https://api.github.com/users/dragonfly9517/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dragonfly9517/subscriptions","organizations_url":"https://api.github.com/users/dragonfly9517/orgs","repos_url":"https://api.github.com/users/dragonfly9517/repos","events_url":"https://api.github.com/users/dragonfly9517/events{/privacy}","received_events_url":"https://api.github.com/users/dragonfly9517/received_events","type":"User","site_admin":false},"created_at":"2015-04-09T21:06:24Z","updated_at":"2015-04-09T21:06:24Z","body":"The tests pass now, and I also managed to write a test to check if the Dns configuration is respected. I check if the Wizard remembers to render previously configured DNS values, and then in the end I check if the parametrized version of the container contains the DNS information in the way Docker API expects. \r\n\r\nLet me know if this will work."}}