{"action":"created","issue":{"url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/1821","labels_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/1821/labels{/name}","comments_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/1821/comments","events_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/1821/events","html_url":"https://github.com/buttonmen-dev/buttonmen/pull/1821","id":118219039,"number":1821,"title":"Made page titles consistent, modified favicon while in monitor mode","user":{"login":"dwvanstone","id":6751265,"avatar_url":"https://avatars.githubusercontent.com/u/6751265?v=3","gravatar_id":"","url":"https://api.github.com/users/dwvanstone","html_url":"https://github.com/dwvanstone","followers_url":"https://api.github.com/users/dwvanstone/followers","following_url":"https://api.github.com/users/dwvanstone/following{/other_user}","gists_url":"https://api.github.com/users/dwvanstone/gists{/gist_id}","starred_url":"https://api.github.com/users/dwvanstone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwvanstone/subscriptions","organizations_url":"https://api.github.com/users/dwvanstone/orgs","repos_url":"https://api.github.com/users/dwvanstone/repos","events_url":"https://api.github.com/users/dwvanstone/events{/privacy}","received_events_url":"https://api.github.com/users/dwvanstone/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/buttonmen-dev/buttonmen/labels/incomplete","name":"incomplete","color":"eb6420"}],"state":"open","locked":false,"assignee":{"login":"cgolubi1","id":2898207,"avatar_url":"https://avatars.githubusercontent.com/u/2898207?v=3","gravatar_id":"","url":"https://api.github.com/users/cgolubi1","html_url":"https://github.com/cgolubi1","followers_url":"https://api.github.com/users/cgolubi1/followers","following_url":"https://api.github.com/users/cgolubi1/following{/other_user}","gists_url":"https://api.github.com/users/cgolubi1/gists{/gist_id}","starred_url":"https://api.github.com/users/cgolubi1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgolubi1/subscriptions","organizations_url":"https://api.github.com/users/cgolubi1/orgs","repos_url":"https://api.github.com/users/cgolubi1/repos","events_url":"https://api.github.com/users/cgolubi1/events{/privacy}","received_events_url":"https://api.github.com/users/cgolubi1/received_events","type":"User","site_admin":false},"milestone":null,"comments":25,"created_at":"2015-11-21T20:28:24Z","updated_at":"2015-12-07T14:56:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/1821","html_url":"https://github.com/buttonmen-dev/buttonmen/pull/1821","diff_url":"https://github.com/buttonmen-dev/buttonmen/pull/1821.diff","patch_url":"https://github.com/buttonmen-dev/buttonmen/pull/1821.patch"},"body":"Fixes #1806. Fixes #1125. Fixes #1684.\r\n\r\nhttp://jenkins.buttonweavers.com:8080/job/buttonmen-dwvanstone/21/\r\n\r\nFor #1806:\r\n\r\nAll page titles have the subpage (or the identifying part of the subpage) in the front of the title. For instance, \"Preferences - Button Men Online\", For specific buttons, profiles, forum threads, etc.,  the specific name will be in the page title. (e.g., a button page: \"Spite - Button Men Online\"; a profile page \"boilerbrown - Button Men Online\")\r\n\r\nNote that sometimes the HTML page was changed to have the simple title of \"Button Men Online\". (Such as buttons.html) In these cases the JS is expected to change the title. I found it less visually jarring to have the title change from \"Button Men Online\" to \"Spite - Button Men Online\" than from \"Buttons - Button Men Online\" to \"Spite - Button Men Online\". \r\n\r\nThe overview page title now has the number of active games as part of the page title. (\"(2) Button Men Online\") The number in parentheses is set to be the sum of open games waiting your move plus the number of games waiting to be accepted by you. It does not include games that have finished and are waiting to be dismissed or games that you're waiting for others to accept. I think this matches the games that the \"Redirect to waiting games when in Monitor mode\" option would take you to.\r\n\r\nFor #1125:\r\n\r\nThe favicon will change to favicon_monitor.ico if the user is in monitor mode on the overview page. (The favicon_monitor.ico represents \"I'm in monitor mode\".) If the user has pinned the page (where only the favicon shows), they will notice the favicon change only if they have the redirect option on in the monitor mode.\r\n\r\nIf the redirect option is on in the monitor mode, the page title will be visibly different -- it will either go to the game page (\"Game # ...\") or to a forum thread page (\"UBFC 64 - ...\"). If the redirect option is off, the user will observe a difference in the title of the overview page when a game is ready to be played. (\"(2) Button Men Online\")\r\n\r\nFor #1684:\r\n\r\nThe page title now has the forum thread name. This won't help the user who has pinned the page (since only the favicon will appear). But this is at least an improvement for everyone else!"},"comment":{"url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/comments/162547824","html_url":"https://github.com/buttonmen-dev/buttonmen/pull/1821#issuecomment-162547824","issue_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/1821","id":162547824,"user":{"login":"AdmiralJota","id":5848173,"avatar_url":"https://avatars.githubusercontent.com/u/5848173?v=3","gravatar_id":"","url":"https://api.github.com/users/AdmiralJota","html_url":"https://github.com/AdmiralJota","followers_url":"https://api.github.com/users/AdmiralJota/followers","following_url":"https://api.github.com/users/AdmiralJota/following{/other_user}","gists_url":"https://api.github.com/users/AdmiralJota/gists{/gist_id}","starred_url":"https://api.github.com/users/AdmiralJota/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdmiralJota/subscriptions","organizations_url":"https://api.github.com/users/AdmiralJota/orgs","repos_url":"https://api.github.com/users/AdmiralJota/repos","events_url":"https://api.github.com/users/AdmiralJota/events{/privacy}","received_events_url":"https://api.github.com/users/AdmiralJota/received_events","type":"User","site_admin":false},"created_at":"2015-12-07T14:56:23Z","updated_at":"2015-12-07T14:56:23Z","body":"For the Overview game count, maybe format it a little more similarly to the other titles?\r\n\r\n    (3 games waiting) - Button Men Online\r\n\r\nYou'd still see the number first on the tab, but the full title at the top of the page wouldn't be context-free anymore (and, as a bonus, it'd be more consistent with other pages on the site)."}}