{"action":"created","issue":{"url":"https://api.github.com/repos/thibaudgg/video_info/issues/68","labels_url":"https://api.github.com/repos/thibaudgg/video_info/issues/68/labels{/name}","comments_url":"https://api.github.com/repos/thibaudgg/video_info/issues/68/comments","events_url":"https://api.github.com/repos/thibaudgg/video_info/issues/68/events","html_url":"https://github.com/thibaudgg/video_info/pull/68","id":74801026,"number":68,"title":"Youtube fixes (everything except '#available?')","user":{"login":"vheuken","id":735512,"avatar_url":"https://avatars.githubusercontent.com/u/735512?v=3","gravatar_id":"","url":"https://api.github.com/users/vheuken","html_url":"https://github.com/vheuken","followers_url":"https://api.github.com/users/vheuken/followers","following_url":"https://api.github.com/users/vheuken/following{/other_user}","gists_url":"https://api.github.com/users/vheuken/gists{/gist_id}","starred_url":"https://api.github.com/users/vheuken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vheuken/subscriptions","organizations_url":"https://api.github.com/users/vheuken/orgs","repos_url":"https://api.github.com/users/vheuken/repos","events_url":"https://api.github.com/users/vheuken/events{/privacy}","received_events_url":"https://api.github.com/users/vheuken/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":34,"created_at":"2015-05-10T01:23:57Z","updated_at":"2015-05-17T10:33:00Z","closed_at":"2015-05-14T19:47:59Z","pull_request":{"url":"https://api.github.com/repos/thibaudgg/video_info/pulls/68","html_url":"https://github.com/thibaudgg/video_info/pull/68","diff_url":"https://github.com/thibaudgg/video_info/pull/68.diff","patch_url":"https://github.com/thibaudgg/video_info/pull/68.patch"},"body":"I merged in the changes from @bonf's repository linked in #66. All I did was remove some commented out code, fix a few specs, and implemented VideoInfo.provider_api_keys hash.\r\n\r\nAll of the Youtube specs pass except '#available?', which, as far as I can tell, has something to do with SSL (thanks for that, Google...). I messed around with it for half an hour but couldn't get it to pass. \r\n\r\nAlso, I didn't touch YoutubePlaylist yet. I think I'll be able to get to that sometime in the next few days if nobody else does.\r\n\r\nThis should merge cleanly with my other PR, #67 \r\n\r\nAlso, I left my API key in youtube_spec.rb \r\nYou should generate your own, set it as an environment variable in Travis, and access it with ENV or something."},"comment":{"url":"https://api.github.com/repos/thibaudgg/video_info/issues/comments/102780350","html_url":"https://github.com/thibaudgg/video_info/pull/68#issuecomment-102780350","issue_url":"https://api.github.com/repos/thibaudgg/video_info/issues/68","id":102780350,"user":{"login":"Calamari","id":149719,"avatar_url":"https://avatars.githubusercontent.com/u/149719?v=3","gravatar_id":"","url":"https://api.github.com/users/Calamari","html_url":"https://github.com/Calamari","followers_url":"https://api.github.com/users/Calamari/followers","following_url":"https://api.github.com/users/Calamari/following{/other_user}","gists_url":"https://api.github.com/users/Calamari/gists{/gist_id}","starred_url":"https://api.github.com/users/Calamari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Calamari/subscriptions","organizations_url":"https://api.github.com/users/Calamari/orgs","repos_url":"https://api.github.com/users/Calamari/repos","events_url":"https://api.github.com/users/Calamari/events{/privacy}","received_events_url":"https://api.github.com/users/Calamari/received_events","type":"User","site_admin":false},"created_at":"2015-05-17T10:33:00Z","updated_at":"2015-05-17T10:33:00Z","body":"I'm not quite sure, if the view_count parsed from the DOM is such a great idea. Can imagine that, this will break very easily.\r\nSo this would also make for a good argument to have the API version as well. Because this is a better promise for stability. Don't know about the stability of the micro formats. So keeping both would make sense in my eyes."}}