{"action":"created","issue":{"url":"https://api.github.com/repos/ScalaConsultants/reactive-rabbit/issues/13","labels_url":"https://api.github.com/repos/ScalaConsultants/reactive-rabbit/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/ScalaConsultants/reactive-rabbit/issues/13/comments","events_url":"https://api.github.com/repos/ScalaConsultants/reactive-rabbit/issues/13/events","html_url":"https://github.com/ScalaConsultants/reactive-rabbit/issues/13","id":79629177,"number":13,"title":"Ability to ACK messages downstream from Source","user":{"login":"zackangelo","id":688990,"avatar_url":"https://avatars.githubusercontent.com/u/688990?v=3","gravatar_id":"","url":"https://api.github.com/users/zackangelo","html_url":"https://github.com/zackangelo","followers_url":"https://api.github.com/users/zackangelo/followers","following_url":"https://api.github.com/users/zackangelo/following{/other_user}","gists_url":"https://api.github.com/users/zackangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/zackangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zackangelo/subscriptions","organizations_url":"https://api.github.com/users/zackangelo/orgs","repos_url":"https://api.github.com/users/zackangelo/repos","events_url":"https://api.github.com/users/zackangelo/events{/privacy}","received_events_url":"https://api.github.com/users/zackangelo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2015-05-22T22:06:18Z","updated_at":"2015-05-28T19:26:32Z","closed_at":null,"body":"Currently, messages seem to be auto-ACKed after they are pulled off the queue and submitted downstream (https://github.com/ScalaConsultants/reactive-rabbit/blob/master/src/main/scala/io/scalac/amqp/impl/QueueSubscription.scala#L39). \r\n\r\nHave you given any thought to incorporating a way to ACK messages after they've been fully processed by the stream? If it's something you think would be worthwhile and you have some ideas on how to implement, I can take a crack at a PR. "},"comment":{"url":"https://api.github.com/repos/ScalaConsultants/reactive-rabbit/issues/comments/106572467","html_url":"https://github.com/ScalaConsultants/reactive-rabbit/issues/13#issuecomment-106572467","issue_url":"https://api.github.com/repos/ScalaConsultants/reactive-rabbit/issues/13","id":106572467,"user":{"login":"vrabeux","id":1539818,"avatar_url":"https://avatars.githubusercontent.com/u/1539818?v=3","gravatar_id":"","url":"https://api.github.com/users/vrabeux","html_url":"https://github.com/vrabeux","followers_url":"https://api.github.com/users/vrabeux/followers","following_url":"https://api.github.com/users/vrabeux/following{/other_user}","gists_url":"https://api.github.com/users/vrabeux/gists{/gist_id}","starred_url":"https://api.github.com/users/vrabeux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrabeux/subscriptions","organizations_url":"https://api.github.com/users/vrabeux/orgs","repos_url":"https://api.github.com/users/vrabeux/repos","events_url":"https://api.github.com/users/vrabeux/events{/privacy}","received_events_url":"https://api.github.com/users/vrabeux/received_events","type":"User","site_admin":false},"created_at":"2015-05-28T19:26:32Z","updated_at":"2015-05-28T19:26:32Z","body":"Ok I am confused here. Didn't you say that :  \r\n> Messages are always acknowledged one-by-one after delivery to the stream.\r\n\r\nIs it : \r\n1 ) --\r\n   * ACK \r\n   * Send message down the stream \r\n2 ) --\r\n   * Send message down the stream \r\n   * ACK\r\n\r\nIf it is 2, then I definitively have an issue on my side. If it is 1, then the flowing flow :\r\n* ACK \r\n* Send message down the stream \r\n* => [CRASH]\r\n\r\nDoes not work in my use case as messages are not re-queued. \r\n\r\n\r\n\r\n\r\n\r\n\r\n"}}