{"action":"closed","number":46,"pull_request":{"url":"https://api.github.com/repos/wikimedia/service-runner/pulls/46","id":44495473,"html_url":"https://github.com/wikimedia/service-runner/pull/46","diff_url":"https://github.com/wikimedia/service-runner/pull/46.diff","patch_url":"https://github.com/wikimedia/service-runner/pull/46.patch","issue_url":"https://api.github.com/repos/wikimedia/service-runner/issues/46","number":46,"state":"closed","locked":false,"title":"Don't discard most logging info in logger","user":{"login":"gwicke","id":1225898,"avatar_url":"https://avatars.githubusercontent.com/u/1225898?v=3","gravatar_id":"","url":"https://api.github.com/users/gwicke","html_url":"https://github.com/gwicke","followers_url":"https://api.github.com/users/gwicke/followers","following_url":"https://api.github.com/users/gwicke/following{/other_user}","gists_url":"https://api.github.com/users/gwicke/gists{/gist_id}","starred_url":"https://api.github.com/users/gwicke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwicke/subscriptions","organizations_url":"https://api.github.com/users/gwicke/orgs","repos_url":"https://api.github.com/users/gwicke/repos","events_url":"https://api.github.com/users/gwicke/events{/privacy}","received_events_url":"https://api.github.com/users/gwicke/received_events","type":"User","site_admin":false},"body":"bff5450 changed the logic to only log a wrapped error instance & drop all\r\nother information on the floor. This is problematic, as this means that\r\ndetails like internal requests don't make it into the logs, greatly\r\ncomplicating debugging.\r\n\r\nThis patch restores the previous behavior of logging all provided information,\r\nbut also makes sure that the msg parameter is provided as a positional\r\nparameter to bunyan.","created_at":"2015-09-08T23:30:54Z","updated_at":"2015-09-09T07:52:10Z","closed_at":"2015-09-09T07:52:10Z","merged_at":"2015-09-09T07:52:10Z","merge_commit_sha":"5e1974a43cdc523d421f26554be0d194f5575e87","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wikimedia/service-runner/pulls/46/commits","review_comments_url":"https://api.github.com/repos/wikimedia/service-runner/pulls/46/comments","review_comment_url":"https://api.github.com/repos/wikimedia/service-runner/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wikimedia/service-runner/issues/46/comments","statuses_url":"https://api.github.com/repos/wikimedia/service-runner/statuses/02cc581140ebb227a513464c8e3f345eed0f3d8d","head":{"label":"gwicke:fix_logging","ref":"fix_logging","sha":"02cc581140ebb227a513464c8e3f345eed0f3d8d","user":{"login":"gwicke","id":1225898,"avatar_url":"https://avatars.githubusercontent.com/u/1225898?v=3","gravatar_id":"","url":"https://api.github.com/users/gwicke","html_url":"https://github.com/gwicke","followers_url":"https://api.github.com/users/gwicke/followers","following_url":"https://api.github.com/users/gwicke/following{/other_user}","gists_url":"https://api.github.com/users/gwicke/gists{/gist_id}","starred_url":"https://api.github.com/users/gwicke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwicke/subscriptions","organizations_url":"https://api.github.com/users/gwicke/orgs","repos_url":"https://api.github.com/users/gwicke/repos","events_url":"https://api.github.com/users/gwicke/events{/privacy}","received_events_url":"https://api.github.com/users/gwicke/received_events","type":"User","site_admin":false},"repo":{"id":30805564,"name":"service-runner","full_name":"gwicke/service-runner","owner":{"login":"gwicke","id":1225898,"avatar_url":"https://avatars.githubusercontent.com/u/1225898?v=3","gravatar_id":"","url":"https://api.github.com/users/gwicke","html_url":"https://github.com/gwicke","followers_url":"https://api.github.com/users/gwicke/followers","following_url":"https://api.github.com/users/gwicke/following{/other_user}","gists_url":"https://api.github.com/users/gwicke/gists{/gist_id}","starred_url":"https://api.github.com/users/gwicke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwicke/subscriptions","organizations_url":"https://api.github.com/users/gwicke/orgs","repos_url":"https://api.github.com/users/gwicke/repos","events_url":"https://api.github.com/users/gwicke/events{/privacy}","received_events_url":"https://api.github.com/users/gwicke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gwicke/service-runner","description":"Generic nodejs service supervisor","fork":true,"url":"https://api.github.com/repos/gwicke/service-runner","forks_url":"https://api.github.com/repos/gwicke/service-runner/forks","keys_url":"https://api.github.com/repos/gwicke/service-runner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gwicke/service-runner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gwicke/service-runner/teams","hooks_url":"https://api.github.com/repos/gwicke/service-runner/hooks","issue_events_url":"https://api.github.com/repos/gwicke/service-runner/issues/events{/number}","events_url":"https://api.github.com/repos/gwicke/service-runner/events","assignees_url":"https://api.github.com/repos/gwicke/service-runner/assignees{/user}","branches_url":"https://api.github.com/repos/gwicke/service-runner/branches{/branch}","tags_url":"https://api.github.com/repos/gwicke/service-runner/tags","blobs_url":"https://api.github.com/repos/gwicke/service-runner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gwicke/service-runner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gwicke/service-runner/git/refs{/sha}","trees_url":"https://api.github.com/repos/gwicke/service-runner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gwicke/service-runner/statuses/{sha}","languages_url":"https://api.github.com/repos/gwicke/service-runner/languages","stargazers_url":"https://api.github.com/repos/gwicke/service-runner/stargazers","contributors_url":"https://api.github.com/repos/gwicke/service-runner/contributors","subscribers_url":"https://api.github.com/repos/gwicke/service-runner/subscribers","subscription_url":"https://api.github.com/repos/gwicke/service-runner/subscription","commits_url":"https://api.github.com/repos/gwicke/service-runner/commits{/sha}","git_commits_url":"https://api.github.com/repos/gwicke/service-runner/git/commits{/sha}","comments_url":"https://api.github.com/repos/gwicke/service-runner/comments{/number}","issue_comment_url":"https://api.github.com/repos/gwicke/service-runner/issues/comments{/number}","contents_url":"https://api.github.com/repos/gwicke/service-runner/contents/{+path}","compare_url":"https://api.github.com/repos/gwicke/service-runner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gwicke/service-runner/merges","archive_url":"https://api.github.com/repos/gwicke/service-runner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gwicke/service-runner/downloads","issues_url":"https://api.github.com/repos/gwicke/service-runner/issues{/number}","pulls_url":"https://api.github.com/repos/gwicke/service-runner/pulls{/number}","milestones_url":"https://api.github.com/repos/gwicke/service-runner/milestones{/number}","notifications_url":"https://api.github.com/repos/gwicke/service-runner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gwicke/service-runner/labels{/name}","releases_url":"https://api.github.com/repos/gwicke/service-runner/releases{/id}","created_at":"2015-02-14T18:59:50Z","updated_at":"2015-04-09T14:43:41Z","pushed_at":"2015-09-08T23:31:41Z","git_url":"git://github.com/gwicke/service-runner.git","ssh_url":"git@github.com:gwicke/service-runner.git","clone_url":"https://github.com/gwicke/service-runner.git","svn_url":"https://github.com/gwicke/service-runner","homepage":null,"size":351,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wikimedia:master","ref":"master","sha":"ad47cbfc1c2b0f6f76c21fd1eb1d3e624842dff1","user":{"login":"wikimedia","id":56668,"avatar_url":"https://avatars.githubusercontent.com/u/56668?v=3","gravatar_id":"","url":"https://api.github.com/users/wikimedia","html_url":"https://github.com/wikimedia","followers_url":"https://api.github.com/users/wikimedia/followers","following_url":"https://api.github.com/users/wikimedia/following{/other_user}","gists_url":"https://api.github.com/users/wikimedia/gists{/gist_id}","starred_url":"https://api.github.com/users/wikimedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikimedia/subscriptions","organizations_url":"https://api.github.com/users/wikimedia/orgs","repos_url":"https://api.github.com/users/wikimedia/repos","events_url":"https://api.github.com/users/wikimedia/events{/privacy}","received_events_url":"https://api.github.com/users/wikimedia/received_events","type":"Organization","site_admin":false},"repo":{"id":30805535,"name":"service-runner","full_name":"wikimedia/service-runner","owner":{"login":"wikimedia","id":56668,"avatar_url":"https://avatars.githubusercontent.com/u/56668?v=3","gravatar_id":"","url":"https://api.github.com/users/wikimedia","html_url":"https://github.com/wikimedia","followers_url":"https://api.github.com/users/wikimedia/followers","following_url":"https://api.github.com/users/wikimedia/following{/other_user}","gists_url":"https://api.github.com/users/wikimedia/gists{/gist_id}","starred_url":"https://api.github.com/users/wikimedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikimedia/subscriptions","organizations_url":"https://api.github.com/users/wikimedia/orgs","repos_url":"https://api.github.com/users/wikimedia/repos","events_url":"https://api.github.com/users/wikimedia/events{/privacy}","received_events_url":"https://api.github.com/users/wikimedia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wikimedia/service-runner","description":"Generic nodejs service supervisor","fork":false,"url":"https://api.github.com/repos/wikimedia/service-runner","forks_url":"https://api.github.com/repos/wikimedia/service-runner/forks","keys_url":"https://api.github.com/repos/wikimedia/service-runner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wikimedia/service-runner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wikimedia/service-runner/teams","hooks_url":"https://api.github.com/repos/wikimedia/service-runner/hooks","issue_events_url":"https://api.github.com/repos/wikimedia/service-runner/issues/events{/number}","events_url":"https://api.github.com/repos/wikimedia/service-runner/events","assignees_url":"https://api.github.com/repos/wikimedia/service-runner/assignees{/user}","branches_url":"https://api.github.com/repos/wikimedia/service-runner/branches{/branch}","tags_url":"https://api.github.com/repos/wikimedia/service-runner/tags","blobs_url":"https://api.github.com/repos/wikimedia/service-runner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wikimedia/service-runner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wikimedia/service-runner/git/refs{/sha}","trees_url":"https://api.github.com/repos/wikimedia/service-runner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wikimedia/service-runner/statuses/{sha}","languages_url":"https://api.github.com/repos/wikimedia/service-runner/languages","stargazers_url":"https://api.github.com/repos/wikimedia/service-runner/stargazers","contributors_url":"https://api.github.com/repos/wikimedia/service-runner/contributors","subscribers_url":"https://api.github.com/repos/wikimedia/service-runner/subscribers","subscription_url":"https://api.github.com/repos/wikimedia/service-runner/subscription","commits_url":"https://api.github.com/repos/wikimedia/service-runner/commits{/sha}","git_commits_url":"https://api.github.com/repos/wikimedia/service-runner/git/commits{/sha}","comments_url":"https://api.github.com/repos/wikimedia/service-runner/comments{/number}","issue_comment_url":"https://api.github.com/repos/wikimedia/service-runner/issues/comments{/number}","contents_url":"https://api.github.com/repos/wikimedia/service-runner/contents/{+path}","compare_url":"https://api.github.com/repos/wikimedia/service-runner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wikimedia/service-runner/merges","archive_url":"https://api.github.com/repos/wikimedia/service-runner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wikimedia/service-runner/downloads","issues_url":"https://api.github.com/repos/wikimedia/service-runner/issues{/number}","pulls_url":"https://api.github.com/repos/wikimedia/service-runner/pulls{/number}","milestones_url":"https://api.github.com/repos/wikimedia/service-runner/milestones{/number}","notifications_url":"https://api.github.com/repos/wikimedia/service-runner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wikimedia/service-runner/labels{/name}","releases_url":"https://api.github.com/repos/wikimedia/service-runner/releases{/id}","created_at":"2015-02-14T18:58:54Z","updated_at":"2015-04-20T19:36:10Z","pushed_at":"2015-09-09T07:52:10Z","git_url":"git://github.com/wikimedia/service-runner.git","ssh_url":"git@github.com:wikimedia/service-runner.git","clone_url":"https://github.com/wikimedia/service-runner.git","svn_url":"https://github.com/wikimedia/service-runner","homepage":null,"size":573,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":2,"forks":7,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wikimedia/service-runner/pulls/46"},"html":{"href":"https://github.com/wikimedia/service-runner/pull/46"},"issue":{"href":"https://api.github.com/repos/wikimedia/service-runner/issues/46"},"comments":{"href":"https://api.github.com/repos/wikimedia/service-runner/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/wikimedia/service-runner/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/wikimedia/service-runner/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wikimedia/service-runner/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/wikimedia/service-runner/statuses/02cc581140ebb227a513464c8e3f345eed0f3d8d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"d00rman","id":10210173,"avatar_url":"https://avatars.githubusercontent.com/u/10210173?v=3","gravatar_id":"","url":"https://api.github.com/users/d00rman","html_url":"https://github.com/d00rman","followers_url":"https://api.github.com/users/d00rman/followers","following_url":"https://api.github.com/users/d00rman/following{/other_user}","gists_url":"https://api.github.com/users/d00rman/gists{/gist_id}","starred_url":"https://api.github.com/users/d00rman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d00rman/subscriptions","organizations_url":"https://api.github.com/users/d00rman/orgs","repos_url":"https://api.github.com/users/d00rman/repos","events_url":"https://api.github.com/users/d00rman/events{/privacy}","received_events_url":"https://api.github.com/users/d00rman/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":2,"additions":7,"deletions":14,"changed_files":2}}