{"action":"created","comment":{"url":"https://api.github.com/repos/enthought/mayavi/pulls/comments/34673221","id":34673221,"diff_hunk":"@@ -808,7 +816,7 @@ def _create_control(self, parent):\n \n         self._interactor.initialize()\n         self._interactor.render()\n-        self.light_manager = light_manager.LightManager(self)\n+        self.light_manager = light_manager.LightManager(weakref.proxy(self))","path":"tvtk/pyface/tvtk_scene.py","position":null,"original_position":27,"commit_id":"75bf6b982a2561994eeda232c9832ac7d509602e","original_commit_id":"007b62ae19e9ca6c79c5db99ab0d8d5048425f95","user":{"login":"itziakos","id":403930,"avatar_url":"https://avatars.githubusercontent.com/u/403930?v=3","gravatar_id":"","url":"https://api.github.com/users/itziakos","html_url":"https://github.com/itziakos","followers_url":"https://api.github.com/users/itziakos/followers","following_url":"https://api.github.com/users/itziakos/following{/other_user}","gists_url":"https://api.github.com/users/itziakos/gists{/gist_id}","starred_url":"https://api.github.com/users/itziakos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itziakos/subscriptions","organizations_url":"https://api.github.com/users/itziakos/orgs","repos_url":"https://api.github.com/users/itziakos/repos","events_url":"https://api.github.com/users/itziakos/events{/privacy}","received_events_url":"https://api.github.com/users/itziakos/received_events","type":"User","site_admin":false},"body":"Probably, but you where right that the cycle could cause problems","created_at":"2015-07-15T12:41:05Z","updated_at":"2015-07-15T12:41:05Z","html_url":"https://github.com/enthought/mayavi/pull/218#discussion_r34673221","pull_request_url":"https://api.github.com/repos/enthought/mayavi/pulls/218","_links":{"self":{"href":"https://api.github.com/repos/enthought/mayavi/pulls/comments/34673221"},"html":{"href":"https://github.com/enthought/mayavi/pull/218#discussion_r34673221"},"pull_request":{"href":"https://api.github.com/repos/enthought/mayavi/pulls/218"}}},"pull_request":{"url":"https://api.github.com/repos/enthought/mayavi/pulls/218","id":40015387,"html_url":"https://github.com/enthought/mayavi/pull/218","diff_url":"https://github.com/enthought/mayavi/pull/218.diff","patch_url":"https://github.com/enthought/mayavi/pull/218.patch","issue_url":"https://api.github.com/repos/enthought/mayavi/issues/218","number":218,"state":"open","locked":false,"title":"Fix memory leaks bug","user":{"login":"itziakos","id":403930,"avatar_url":"https://avatars.githubusercontent.com/u/403930?v=3","gravatar_id":"","url":"https://api.github.com/users/itziakos","html_url":"https://github.com/itziakos","followers_url":"https://api.github.com/users/itziakos/followers","following_url":"https://api.github.com/users/itziakos/following{/other_user}","gists_url":"https://api.github.com/users/itziakos/gists{/gist_id}","starred_url":"https://api.github.com/users/itziakos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itziakos/subscriptions","organizations_url":"https://api.github.com/users/itziakos/orgs","repos_url":"https://api.github.com/users/itziakos/repos","events_url":"https://api.github.com/users/itziakos/events{/privacy}","received_events_url":"https://api.github.com/users/itziakos/received_events","type":"User","site_admin":false},"body":"This PR updates #212 \r\n\r\nIn more detail:\r\n- The test for the `TVTKScene` is reworked. \r\n- A separate tests is provided for the pyface based tvtk `Scene`. This test will use the default ets toolkit and currently will be skipped on `wx` (see #216)\r\n","created_at":"2015-07-15T12:08:20Z","updated_at":"2015-07-15T12:41:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6e83899e02314cd2e7c1fc2f7bcbcf103ae3ce0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/enthought/mayavi/pulls/218/commits","review_comments_url":"https://api.github.com/repos/enthought/mayavi/pulls/218/comments","review_comment_url":"https://api.github.com/repos/enthought/mayavi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/enthought/mayavi/issues/218/comments","statuses_url":"https://api.github.com/repos/enthought/mayavi/statuses/75bf6b982a2561994eeda232c9832ac7d509602e","head":{"label":"enthought:fix-memory-leaks-bug","ref":"fix-memory-leaks-bug","sha":"75bf6b982a2561994eeda232c9832ac7d509602e","user":{"login":"enthought","id":539651,"avatar_url":"https://avatars.githubusercontent.com/u/539651?v=3","gravatar_id":"","url":"https://api.github.com/users/enthought","html_url":"https://github.com/enthought","followers_url":"https://api.github.com/users/enthought/followers","following_url":"https://api.github.com/users/enthought/following{/other_user}","gists_url":"https://api.github.com/users/enthought/gists{/gist_id}","starred_url":"https://api.github.com/users/enthought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enthought/subscriptions","organizations_url":"https://api.github.com/users/enthought/orgs","repos_url":"https://api.github.com/users/enthought/repos","events_url":"https://api.github.com/users/enthought/events{/privacy}","received_events_url":"https://api.github.com/users/enthought/received_events","type":"Organization","site_admin":false},"repo":{"id":1288547,"name":"mayavi","full_name":"enthought/mayavi","owner":{"login":"enthought","id":539651,"avatar_url":"https://avatars.githubusercontent.com/u/539651?v=3","gravatar_id":"","url":"https://api.github.com/users/enthought","html_url":"https://github.com/enthought","followers_url":"https://api.github.com/users/enthought/followers","following_url":"https://api.github.com/users/enthought/following{/other_user}","gists_url":"https://api.github.com/users/enthought/gists{/gist_id}","starred_url":"https://api.github.com/users/enthought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enthought/subscriptions","organizations_url":"https://api.github.com/users/enthought/orgs","repos_url":"https://api.github.com/users/enthought/repos","events_url":"https://api.github.com/users/enthought/events{/privacy}","received_events_url":"https://api.github.com/users/enthought/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enthought/mayavi","description":"","fork":false,"url":"https://api.github.com/repos/enthought/mayavi","forks_url":"https://api.github.com/repos/enthought/mayavi/forks","keys_url":"https://api.github.com/repos/enthought/mayavi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enthought/mayavi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enthought/mayavi/teams","hooks_url":"https://api.github.com/repos/enthought/mayavi/hooks","issue_events_url":"https://api.github.com/repos/enthought/mayavi/issues/events{/number}","events_url":"https://api.github.com/repos/enthought/mayavi/events","assignees_url":"https://api.github.com/repos/enthought/mayavi/assignees{/user}","branches_url":"https://api.github.com/repos/enthought/mayavi/branches{/branch}","tags_url":"https://api.github.com/repos/enthought/mayavi/tags","blobs_url":"https://api.github.com/repos/enthought/mayavi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enthought/mayavi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enthought/mayavi/git/refs{/sha}","trees_url":"https://api.github.com/repos/enthought/mayavi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enthought/mayavi/statuses/{sha}","languages_url":"https://api.github.com/repos/enthought/mayavi/languages","stargazers_url":"https://api.github.com/repos/enthought/mayavi/stargazers","contributors_url":"https://api.github.com/repos/enthought/mayavi/contributors","subscribers_url":"https://api.github.com/repos/enthought/mayavi/subscribers","subscription_url":"https://api.github.com/repos/enthought/mayavi/subscription","commits_url":"https://api.github.com/repos/enthought/mayavi/commits{/sha}","git_commits_url":"https://api.github.com/repos/enthought/mayavi/git/commits{/sha}","comments_url":"https://api.github.com/repos/enthought/mayavi/comments{/number}","issue_comment_url":"https://api.github.com/repos/enthought/mayavi/issues/comments{/number}","contents_url":"https://api.github.com/repos/enthought/mayavi/contents/{+path}","compare_url":"https://api.github.com/repos/enthought/mayavi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enthought/mayavi/merges","archive_url":"https://api.github.com/repos/enthought/mayavi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enthought/mayavi/downloads","issues_url":"https://api.github.com/repos/enthought/mayavi/issues{/number}","pulls_url":"https://api.github.com/repos/enthought/mayavi/pulls{/number}","milestones_url":"https://api.github.com/repos/enthought/mayavi/milestones{/number}","notifications_url":"https://api.github.com/repos/enthought/mayavi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enthought/mayavi/labels{/name}","releases_url":"https://api.github.com/repos/enthought/mayavi/releases{/id}","created_at":"2011-01-24T17:48:00Z","updated_at":"2015-07-14T21:41:55Z","pushed_at":"2015-07-15T12:28:11Z","git_url":"git://github.com/enthought/mayavi.git","ssh_url":"git@github.com:enthought/mayavi.git","clone_url":"https://github.com/enthought/mayavi.git","svn_url":"https://github.com/enthought/mayavi","homepage":"","size":79130,"stargazers_count":185,"watchers_count":185,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":62,"mirror_url":null,"open_issues_count":104,"forks":62,"open_issues":104,"watchers":185,"default_branch":"master"}},"base":{"label":"enthought:master","ref":"master","sha":"72c4ae1780b2509d10f49a181aeed0e6e62f8ad7","user":{"login":"enthought","id":539651,"avatar_url":"https://avatars.githubusercontent.com/u/539651?v=3","gravatar_id":"","url":"https://api.github.com/users/enthought","html_url":"https://github.com/enthought","followers_url":"https://api.github.com/users/enthought/followers","following_url":"https://api.github.com/users/enthought/following{/other_user}","gists_url":"https://api.github.com/users/enthought/gists{/gist_id}","starred_url":"https://api.github.com/users/enthought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enthought/subscriptions","organizations_url":"https://api.github.com/users/enthought/orgs","repos_url":"https://api.github.com/users/enthought/repos","events_url":"https://api.github.com/users/enthought/events{/privacy}","received_events_url":"https://api.github.com/users/enthought/received_events","type":"Organization","site_admin":false},"repo":{"id":1288547,"name":"mayavi","full_name":"enthought/mayavi","owner":{"login":"enthought","id":539651,"avatar_url":"https://avatars.githubusercontent.com/u/539651?v=3","gravatar_id":"","url":"https://api.github.com/users/enthought","html_url":"https://github.com/enthought","followers_url":"https://api.github.com/users/enthought/followers","following_url":"https://api.github.com/users/enthought/following{/other_user}","gists_url":"https://api.github.com/users/enthought/gists{/gist_id}","starred_url":"https://api.github.com/users/enthought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enthought/subscriptions","organizations_url":"https://api.github.com/users/enthought/orgs","repos_url":"https://api.github.com/users/enthought/repos","events_url":"https://api.github.com/users/enthought/events{/privacy}","received_events_url":"https://api.github.com/users/enthought/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enthought/mayavi","description":"","fork":false,"url":"https://api.github.com/repos/enthought/mayavi","forks_url":"https://api.github.com/repos/enthought/mayavi/forks","keys_url":"https://api.github.com/repos/enthought/mayavi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enthought/mayavi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enthought/mayavi/teams","hooks_url":"https://api.github.com/repos/enthought/mayavi/hooks","issue_events_url":"https://api.github.com/repos/enthought/mayavi/issues/events{/number}","events_url":"https://api.github.com/repos/enthought/mayavi/events","assignees_url":"https://api.github.com/repos/enthought/mayavi/assignees{/user}","branches_url":"https://api.github.com/repos/enthought/mayavi/branches{/branch}","tags_url":"https://api.github.com/repos/enthought/mayavi/tags","blobs_url":"https://api.github.com/repos/enthought/mayavi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enthought/mayavi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enthought/mayavi/git/refs{/sha}","trees_url":"https://api.github.com/repos/enthought/mayavi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enthought/mayavi/statuses/{sha}","languages_url":"https://api.github.com/repos/enthought/mayavi/languages","stargazers_url":"https://api.github.com/repos/enthought/mayavi/stargazers","contributors_url":"https://api.github.com/repos/enthought/mayavi/contributors","subscribers_url":"https://api.github.com/repos/enthought/mayavi/subscribers","subscription_url":"https://api.github.com/repos/enthought/mayavi/subscription","commits_url":"https://api.github.com/repos/enthought/mayavi/commits{/sha}","git_commits_url":"https://api.github.com/repos/enthought/mayavi/git/commits{/sha}","comments_url":"https://api.github.com/repos/enthought/mayavi/comments{/number}","issue_comment_url":"https://api.github.com/repos/enthought/mayavi/issues/comments{/number}","contents_url":"https://api.github.com/repos/enthought/mayavi/contents/{+path}","compare_url":"https://api.github.com/repos/enthought/mayavi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enthought/mayavi/merges","archive_url":"https://api.github.com/repos/enthought/mayavi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enthought/mayavi/downloads","issues_url":"https://api.github.com/repos/enthought/mayavi/issues{/number}","pulls_url":"https://api.github.com/repos/enthought/mayavi/pulls{/number}","milestones_url":"https://api.github.com/repos/enthought/mayavi/milestones{/number}","notifications_url":"https://api.github.com/repos/enthought/mayavi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enthought/mayavi/labels{/name}","releases_url":"https://api.github.com/repos/enthought/mayavi/releases{/id}","created_at":"2011-01-24T17:48:00Z","updated_at":"2015-07-14T21:41:55Z","pushed_at":"2015-07-15T12:28:11Z","git_url":"git://github.com/enthought/mayavi.git","ssh_url":"git@github.com:enthought/mayavi.git","clone_url":"https://github.com/enthought/mayavi.git","svn_url":"https://github.com/enthought/mayavi","homepage":"","size":79130,"stargazers_count":185,"watchers_count":185,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":62,"mirror_url":null,"open_issues_count":104,"forks":62,"open_issues":104,"watchers":185,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/enthought/mayavi/pulls/218"},"html":{"href":"https://github.com/enthought/mayavi/pull/218"},"issue":{"href":"https://api.github.com/repos/enthought/mayavi/issues/218"},"comments":{"href":"https://api.github.com/repos/enthought/mayavi/issues/218/comments"},"review_comments":{"href":"https://api.github.com/repos/enthought/mayavi/pulls/218/comments"},"review_comment":{"href":"https://api.github.com/repos/enthought/mayavi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/enthought/mayavi/pulls/218/commits"},"statuses":{"href":"https://api.github.com/repos/enthought/mayavi/statuses/75bf6b982a2561994eeda232c9832ac7d509602e"}}}}