{"action":"created","issue":{"url":"https://api.github.com/repos/alphagov/smart-answers/issues/1648","labels_url":"https://api.github.com/repos/alphagov/smart-answers/issues/1648/labels{/name}","comments_url":"https://api.github.com/repos/alphagov/smart-answers/issues/1648/comments","events_url":"https://api.github.com/repos/alphagov/smart-answers/issues/1648/events","html_url":"https://github.com/alphagov/smart-answers/pull/1648","id":78481438,"number":1648,"title":"Use outcome templates for student finance calculator","user":{"login":"chrisroos","id":6556,"avatar_url":"https://avatars.githubusercontent.com/u/6556?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisroos","html_url":"https://github.com/chrisroos","followers_url":"https://api.github.com/users/chrisroos/followers","following_url":"https://api.github.com/users/chrisroos/following{/other_user}","gists_url":"https://api.github.com/users/chrisroos/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisroos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisroos/subscriptions","organizations_url":"https://api.github.com/users/chrisroos/orgs","repos_url":"https://api.github.com/users/chrisroos/repos","events_url":"https://api.github.com/users/chrisroos/events{/privacy}","received_events_url":"https://api.github.com/users/chrisroos/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-05-20T11:12:49Z","updated_at":"2015-05-20T14:22:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/alphagov/smart-answers/pulls/1648","html_url":"https://github.com/alphagov/smart-answers/pull/1648","diff_url":"https://github.com/alphagov/smart-answers/pull/1648.diff","patch_url":"https://github.com/alphagov/smart-answers/pull/1648.patch"},"body":"This builds upon the work discussed in #1577.\r\n\r\nIt replaces the traditional `PhraseList` outcomes in the student-finance-calculator with ERB templates.\r\n\r\nI've checked the output of the ERB templates using the regression tests in #1642 and am confident that they're identical.\r\n\r\nYou'll notice that we've removed a number of assertions that were checking things about the PhraseLists, and therefore the logic around what gets displayed in outcomes. The removal of these assertions means that we've lost some test coverage. This reduction in test coverage is one of our main motivations for wanting to add the regression tests in #1642.\r\n\r\nAre people still happy to make the switch to ERB templates, and does anyone have any thoughts about how we might test the logic in the templates if we don't end up adding the proposed regression tests?\r\n"},"comment":{"url":"https://api.github.com/repos/alphagov/smart-answers/issues/comments/103903971","html_url":"https://github.com/alphagov/smart-answers/pull/1648#issuecomment-103903971","issue_url":"https://api.github.com/repos/alphagov/smart-answers/issues/1648","id":103903971,"user":{"login":"floehopper","id":3169,"avatar_url":"https://avatars.githubusercontent.com/u/3169?v=3","gravatar_id":"","url":"https://api.github.com/users/floehopper","html_url":"https://github.com/floehopper","followers_url":"https://api.github.com/users/floehopper/followers","following_url":"https://api.github.com/users/floehopper/following{/other_user}","gists_url":"https://api.github.com/users/floehopper/gists{/gist_id}","starred_url":"https://api.github.com/users/floehopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floehopper/subscriptions","organizations_url":"https://api.github.com/users/floehopper/orgs","repos_url":"https://api.github.com/users/floehopper/repos","events_url":"https://api.github.com/users/floehopper/events{/privacy}","received_events_url":"https://api.github.com/users/floehopper/received_events","type":"User","site_admin":false},"created_at":"2015-05-20T14:22:49Z","updated_at":"2015-05-20T14:22:49Z","body":"LGTM. As we've discussed previously, it would be good to have a partial template mechanism to remove some of the duplication from the new outcome templates."}}