{"action":"closed","number":113,"pull_request":{"url":"https://api.github.com/repos/guysoft/OctoPi/pulls/113","id":37693190,"html_url":"https://github.com/guysoft/OctoPi/pull/113","diff_url":"https://github.com/guysoft/OctoPi/pull/113.diff","patch_url":"https://github.com/guysoft/OctoPi/pull/113.patch","issue_url":"https://api.github.com/repos/guysoft/OctoPi/issues/113","number":113,"state":"closed","locked":false,"title":"Fixes webcamDaemon for Logitech C170","user":{"login":"foosel","id":83657,"avatar_url":"https://avatars.githubusercontent.com/u/83657?v=3","gravatar_id":"","url":"https://api.github.com/users/foosel","html_url":"https://github.com/foosel","followers_url":"https://api.github.com/users/foosel/followers","following_url":"https://api.github.com/users/foosel/following{/other_user}","gists_url":"https://api.github.com/users/foosel/gists{/gist_id}","starred_url":"https://api.github.com/users/foosel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foosel/subscriptions","organizations_url":"https://api.github.com/users/foosel/orgs","repos_url":"https://api.github.com/users/foosel/repos","events_url":"https://api.github.com/users/foosel/events{/privacy}","received_events_url":"https://api.github.com/users/foosel/received_events","type":"User","site_admin":false},"body":"For whatever reason using the -f parameter with that specific camera\r\nmodel causes it to just not output any image. mjpgstreamer will start\r\nup just fine and not log an error or anything, the camera will appear\r\nto start up too, but when connecting to the webcam stream nothing will\r\nbe displayed at all. Just removing the -f parameter in this case fixes\r\nit completely.\r\n\r\nThis patch adds a new check to the webcamDaemon when starting up a\r\nUSB webcam which checks the webcams USB vid and pid against a list\r\nof webcams known not to work with -f (right now that's just the C170,\r\nbut more can be added easily by the user through the new\r\nadditional_brokenfps_usb_devices option in /boot/octopi.txt) and if\r\na match is found strips the -f parameter from the camera options.\r\n\r\nThis is the only way I found I could make a C170 work. It would\r\nprobably be cleaner to try to debug what's going wrong in mjpgstreamer\r\nthere, but since that might as well be a problem with the chipset\r\ndriver of the C170, this is a workaround that should at least\r\nyield a picture at a default frame rate.","created_at":"2015-06-15T13:51:19Z","updated_at":"2015-06-19T17:43:44Z","closed_at":"2015-06-19T17:43:44Z","merged_at":null,"merge_commit_sha":"64f58751899fd545f4f426fdf51fb1187bf6ada5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guysoft/OctoPi/pulls/113/commits","review_comments_url":"https://api.github.com/repos/guysoft/OctoPi/pulls/113/comments","review_comment_url":"https://api.github.com/repos/guysoft/OctoPi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guysoft/OctoPi/issues/113/comments","statuses_url":"https://api.github.com/repos/guysoft/OctoPi/statuses/775fe18c060027ead5ab31bd5de2934481ef01a6","head":{"label":"foosel:fix/logitechC170","ref":"fix/logitechC170","sha":"775fe18c060027ead5ab31bd5de2934481ef01a6","user":{"login":"foosel","id":83657,"avatar_url":"https://avatars.githubusercontent.com/u/83657?v=3","gravatar_id":"","url":"https://api.github.com/users/foosel","html_url":"https://github.com/foosel","followers_url":"https://api.github.com/users/foosel/followers","following_url":"https://api.github.com/users/foosel/following{/other_user}","gists_url":"https://api.github.com/users/foosel/gists{/gist_id}","starred_url":"https://api.github.com/users/foosel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foosel/subscriptions","organizations_url":"https://api.github.com/users/foosel/orgs","repos_url":"https://api.github.com/users/foosel/repos","events_url":"https://api.github.com/users/foosel/events{/privacy}","received_events_url":"https://api.github.com/users/foosel/received_events","type":"User","site_admin":false},"repo":{"id":12033554,"name":"OctoPi","full_name":"foosel/OctoPi","owner":{"login":"foosel","id":83657,"avatar_url":"https://avatars.githubusercontent.com/u/83657?v=3","gravatar_id":"","url":"https://api.github.com/users/foosel","html_url":"https://github.com/foosel","followers_url":"https://api.github.com/users/foosel/followers","following_url":"https://api.github.com/users/foosel/following{/other_user}","gists_url":"https://api.github.com/users/foosel/gists{/gist_id}","starred_url":"https://api.github.com/users/foosel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foosel/subscriptions","organizations_url":"https://api.github.com/users/foosel/orgs","repos_url":"https://api.github.com/users/foosel/repos","events_url":"https://api.github.com/users/foosel/events{/privacy}","received_events_url":"https://api.github.com/users/foosel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/foosel/OctoPi","description":"Scripts to build OctoPi, a Raspberry PI distro for controlling 3d printers over the web","fork":true,"url":"https://api.github.com/repos/foosel/OctoPi","forks_url":"https://api.github.com/repos/foosel/OctoPi/forks","keys_url":"https://api.github.com/repos/foosel/OctoPi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/foosel/OctoPi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/foosel/OctoPi/teams","hooks_url":"https://api.github.com/repos/foosel/OctoPi/hooks","issue_events_url":"https://api.github.com/repos/foosel/OctoPi/issues/events{/number}","events_url":"https://api.github.com/repos/foosel/OctoPi/events","assignees_url":"https://api.github.com/repos/foosel/OctoPi/assignees{/user}","branches_url":"https://api.github.com/repos/foosel/OctoPi/branches{/branch}","tags_url":"https://api.github.com/repos/foosel/OctoPi/tags","blobs_url":"https://api.github.com/repos/foosel/OctoPi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/foosel/OctoPi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/foosel/OctoPi/git/refs{/sha}","trees_url":"https://api.github.com/repos/foosel/OctoPi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/foosel/OctoPi/statuses/{sha}","languages_url":"https://api.github.com/repos/foosel/OctoPi/languages","stargazers_url":"https://api.github.com/repos/foosel/OctoPi/stargazers","contributors_url":"https://api.github.com/repos/foosel/OctoPi/contributors","subscribers_url":"https://api.github.com/repos/foosel/OctoPi/subscribers","subscription_url":"https://api.github.com/repos/foosel/OctoPi/subscription","commits_url":"https://api.github.com/repos/foosel/OctoPi/commits{/sha}","git_commits_url":"https://api.github.com/repos/foosel/OctoPi/git/commits{/sha}","comments_url":"https://api.github.com/repos/foosel/OctoPi/comments{/number}","issue_comment_url":"https://api.github.com/repos/foosel/OctoPi/issues/comments{/number}","contents_url":"https://api.github.com/repos/foosel/OctoPi/contents/{+path}","compare_url":"https://api.github.com/repos/foosel/OctoPi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/foosel/OctoPi/merges","archive_url":"https://api.github.com/repos/foosel/OctoPi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/foosel/OctoPi/downloads","issues_url":"https://api.github.com/repos/foosel/OctoPi/issues{/number}","pulls_url":"https://api.github.com/repos/foosel/OctoPi/pulls{/number}","milestones_url":"https://api.github.com/repos/foosel/OctoPi/milestones{/number}","notifications_url":"https://api.github.com/repos/foosel/OctoPi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/foosel/OctoPi/labels{/name}","releases_url":"https://api.github.com/repos/foosel/OctoPi/releases{/id}","created_at":"2013-08-11T08:58:01Z","updated_at":"2015-04-11T09:54:02Z","pushed_at":"2015-06-19T17:43:28Z","git_url":"git://github.com/foosel/OctoPi.git","ssh_url":"git@github.com:foosel/OctoPi.git","clone_url":"https://github.com/foosel/OctoPi.git","svn_url":"https://github.com/foosel/OctoPi","homepage":null,"size":688,"stargazers_count":6,"watchers_count":6,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":6,"default_branch":"devel"}},"base":{"label":"guysoft:devel","ref":"devel","sha":"0ffe937f537b46885294fd2f34192f177071af3b","user":{"login":"guysoft","id":325670,"avatar_url":"https://avatars.githubusercontent.com/u/325670?v=3","gravatar_id":"","url":"https://api.github.com/users/guysoft","html_url":"https://github.com/guysoft","followers_url":"https://api.github.com/users/guysoft/followers","following_url":"https://api.github.com/users/guysoft/following{/other_user}","gists_url":"https://api.github.com/users/guysoft/gists{/gist_id}","starred_url":"https://api.github.com/users/guysoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guysoft/subscriptions","organizations_url":"https://api.github.com/users/guysoft/orgs","repos_url":"https://api.github.com/users/guysoft/repos","events_url":"https://api.github.com/users/guysoft/events{/privacy}","received_events_url":"https://api.github.com/users/guysoft/received_events","type":"User","site_admin":false},"repo":{"id":11174413,"name":"OctoPi","full_name":"guysoft/OctoPi","owner":{"login":"guysoft","id":325670,"avatar_url":"https://avatars.githubusercontent.com/u/325670?v=3","gravatar_id":"","url":"https://api.github.com/users/guysoft","html_url":"https://github.com/guysoft","followers_url":"https://api.github.com/users/guysoft/followers","following_url":"https://api.github.com/users/guysoft/following{/other_user}","gists_url":"https://api.github.com/users/guysoft/gists{/gist_id}","starred_url":"https://api.github.com/users/guysoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guysoft/subscriptions","organizations_url":"https://api.github.com/users/guysoft/orgs","repos_url":"https://api.github.com/users/guysoft/repos","events_url":"https://api.github.com/users/guysoft/events{/privacy}","received_events_url":"https://api.github.com/users/guysoft/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/guysoft/OctoPi","description":"Scripts to build OctoPi, a Raspberry PI distro for controlling 3D printers over the web","fork":false,"url":"https://api.github.com/repos/guysoft/OctoPi","forks_url":"https://api.github.com/repos/guysoft/OctoPi/forks","keys_url":"https://api.github.com/repos/guysoft/OctoPi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guysoft/OctoPi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guysoft/OctoPi/teams","hooks_url":"https://api.github.com/repos/guysoft/OctoPi/hooks","issue_events_url":"https://api.github.com/repos/guysoft/OctoPi/issues/events{/number}","events_url":"https://api.github.com/repos/guysoft/OctoPi/events","assignees_url":"https://api.github.com/repos/guysoft/OctoPi/assignees{/user}","branches_url":"https://api.github.com/repos/guysoft/OctoPi/branches{/branch}","tags_url":"https://api.github.com/repos/guysoft/OctoPi/tags","blobs_url":"https://api.github.com/repos/guysoft/OctoPi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guysoft/OctoPi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guysoft/OctoPi/git/refs{/sha}","trees_url":"https://api.github.com/repos/guysoft/OctoPi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guysoft/OctoPi/statuses/{sha}","languages_url":"https://api.github.com/repos/guysoft/OctoPi/languages","stargazers_url":"https://api.github.com/repos/guysoft/OctoPi/stargazers","contributors_url":"https://api.github.com/repos/guysoft/OctoPi/contributors","subscribers_url":"https://api.github.com/repos/guysoft/OctoPi/subscribers","subscription_url":"https://api.github.com/repos/guysoft/OctoPi/subscription","commits_url":"https://api.github.com/repos/guysoft/OctoPi/commits{/sha}","git_commits_url":"https://api.github.com/repos/guysoft/OctoPi/git/commits{/sha}","comments_url":"https://api.github.com/repos/guysoft/OctoPi/comments{/number}","issue_comment_url":"https://api.github.com/repos/guysoft/OctoPi/issues/comments{/number}","contents_url":"https://api.github.com/repos/guysoft/OctoPi/contents/{+path}","compare_url":"https://api.github.com/repos/guysoft/OctoPi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guysoft/OctoPi/merges","archive_url":"https://api.github.com/repos/guysoft/OctoPi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guysoft/OctoPi/downloads","issues_url":"https://api.github.com/repos/guysoft/OctoPi/issues{/number}","pulls_url":"https://api.github.com/repos/guysoft/OctoPi/pulls{/number}","milestones_url":"https://api.github.com/repos/guysoft/OctoPi/milestones{/number}","notifications_url":"https://api.github.com/repos/guysoft/OctoPi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guysoft/OctoPi/labels{/name}","releases_url":"https://api.github.com/repos/guysoft/OctoPi/releases{/id}","created_at":"2013-07-04T10:57:56Z","updated_at":"2015-06-17T22:25:53Z","pushed_at":"2015-06-19T17:38:36Z","git_url":"git://github.com/guysoft/OctoPi.git","ssh_url":"git@github.com:guysoft/OctoPi.git","clone_url":"https://github.com/guysoft/OctoPi.git","svn_url":"https://github.com/guysoft/OctoPi","homepage":"","size":1393,"stargazers_count":208,"watchers_count":208,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":59,"mirror_url":null,"open_issues_count":28,"forks":59,"open_issues":28,"watchers":208,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/guysoft/OctoPi/pulls/113"},"html":{"href":"https://github.com/guysoft/OctoPi/pull/113"},"issue":{"href":"https://api.github.com/repos/guysoft/OctoPi/issues/113"},"comments":{"href":"https://api.github.com/repos/guysoft/OctoPi/issues/113/comments"},"review_comments":{"href":"https://api.github.com/repos/guysoft/OctoPi/pulls/113/comments"},"review_comment":{"href":"https://api.github.com/repos/guysoft/OctoPi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guysoft/OctoPi/pulls/113/commits"},"statuses":{"href":"https://api.github.com/repos/guysoft/OctoPi/statuses/775fe18c060027ead5ab31bd5de2934481ef01a6"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":4,"review_comments":0,"commits":1,"additions":57,"deletions":1,"changed_files":2}}