{"action":"created","comment":{"url":"https://api.github.com/repos/YaleSTC/reservations/pulls/comments/48317376","id":48317376,"diff_hunk":"@@ -129,5 +149,8 @@\n       end\n       it_behaves_like 'access denied'\n     end\n+    context 'GET hide' do","path":"spec/controllers/announcements_controller_spec.rb","position":38,"original_position":38,"commit_id":"1924e0b989b9508cfd4c4067fba5a5654c97335b","original_commit_id":"1924e0b989b9508cfd4c4067fba5a5654c97335b","user":{"login":"orenyk","id":901808,"avatar_url":"https://avatars.githubusercontent.com/u/901808?v=3","gravatar_id":"","url":"https://api.github.com/users/orenyk","html_url":"https://github.com/orenyk","followers_url":"https://api.github.com/users/orenyk/followers","following_url":"https://api.github.com/users/orenyk/following{/other_user}","gists_url":"https://api.github.com/users/orenyk/gists{/gist_id}","starred_url":"https://api.github.com/users/orenyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orenyk/subscriptions","organizations_url":"https://api.github.com/users/orenyk/orgs","repos_url":"https://api.github.com/users/orenyk/repos","events_url":"https://api.github.com/users/orenyk/events{/privacy}","received_events_url":"https://api.github.com/users/orenyk/received_events","type":"User","site_admin":false},"body":"Note that this test only checks for patrons (see line 123 above), not all user roles. That's why it didn't catch the others. We should probably write tests for all roles... as this is a common problem I'm going to open a new issue to write an RSpec helper to deal with it.","created_at":"2015-12-23T02:03:46Z","updated_at":"2015-12-23T02:03:46Z","html_url":"https://github.com/YaleSTC/reservations/pull/1350#discussion_r48317376","pull_request_url":"https://api.github.com/repos/YaleSTC/reservations/pulls/1350","_links":{"self":{"href":"https://api.github.com/repos/YaleSTC/reservations/pulls/comments/48317376"},"html":{"href":"https://github.com/YaleSTC/reservations/pull/1350#discussion_r48317376"},"pull_request":{"href":"https://api.github.com/repos/YaleSTC/reservations/pulls/1350"}}},"pull_request":{"url":"https://api.github.com/repos/YaleSTC/reservations/pulls/1350","id":50201066,"html_url":"https://github.com/YaleSTC/reservations/pull/1350","diff_url":"https://github.com/YaleSTC/reservations/pull/1350.diff","patch_url":"https://github.com/YaleSTC/reservations/pull/1350.patch","issue_url":"https://api.github.com/repos/YaleSTC/reservations/issues/1350","number":1350,"state":"open","locked":false,"title":"[1339] hide announcement","user":{"login":"alex-kogan","id":10825030,"avatar_url":"https://avatars.githubusercontent.com/u/10825030?v=3","gravatar_id":"","url":"https://api.github.com/users/alex-kogan","html_url":"https://github.com/alex-kogan","followers_url":"https://api.github.com/users/alex-kogan/followers","following_url":"https://api.github.com/users/alex-kogan/following{/other_user}","gists_url":"https://api.github.com/users/alex-kogan/gists{/gist_id}","starred_url":"https://api.github.com/users/alex-kogan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex-kogan/subscriptions","organizations_url":"https://api.github.com/users/alex-kogan/orgs","repos_url":"https://api.github.com/users/alex-kogan/repos","events_url":"https://api.github.com/users/alex-kogan/events{/privacy}","received_events_url":"https://api.github.com/users/alex-kogan/received_events","type":"User","site_admin":false},"body":"Resolves #1339 on `master`","created_at":"2015-11-10T01:00:16Z","updated_at":"2015-12-23T02:03:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6fb2ef1348ec37ff6627b3d456795cbcf2ff2ff1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/YaleSTC/reservations/pulls/1350/commits","review_comments_url":"https://api.github.com/repos/YaleSTC/reservations/pulls/1350/comments","review_comment_url":"https://api.github.com/repos/YaleSTC/reservations/pulls/comments{/number}","comments_url":"https://api.github.com/repos/YaleSTC/reservations/issues/1350/comments","statuses_url":"https://api.github.com/repos/YaleSTC/reservations/statuses/1924e0b989b9508cfd4c4067fba5a5654c97335b","head":{"label":"YaleSTC:1339_hide_announcement","ref":"1339_hide_announcement","sha":"1924e0b989b9508cfd4c4067fba5a5654c97335b","user":{"login":"YaleSTC","id":106094,"avatar_url":"https://avatars.githubusercontent.com/u/106094?v=3","gravatar_id":"","url":"https://api.github.com/users/YaleSTC","html_url":"https://github.com/YaleSTC","followers_url":"https://api.github.com/users/YaleSTC/followers","following_url":"https://api.github.com/users/YaleSTC/following{/other_user}","gists_url":"https://api.github.com/users/YaleSTC/gists{/gist_id}","starred_url":"https://api.github.com/users/YaleSTC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YaleSTC/subscriptions","organizations_url":"https://api.github.com/users/YaleSTC/orgs","repos_url":"https://api.github.com/users/YaleSTC/repos","events_url":"https://api.github.com/users/YaleSTC/events{/privacy}","received_events_url":"https://api.github.com/users/YaleSTC/received_events","type":"Organization","site_admin":false},"repo":{"id":345280,"name":"reservations","full_name":"YaleSTC/reservations","owner":{"login":"YaleSTC","id":106094,"avatar_url":"https://avatars.githubusercontent.com/u/106094?v=3","gravatar_id":"","url":"https://api.github.com/users/YaleSTC","html_url":"https://github.com/YaleSTC","followers_url":"https://api.github.com/users/YaleSTC/followers","following_url":"https://api.github.com/users/YaleSTC/following{/other_user}","gists_url":"https://api.github.com/users/YaleSTC/gists{/gist_id}","starred_url":"https://api.github.com/users/YaleSTC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YaleSTC/subscriptions","organizations_url":"https://api.github.com/users/YaleSTC/orgs","repos_url":"https://api.github.com/users/YaleSTC/repos","events_url":"https://api.github.com/users/YaleSTC/events{/privacy}","received_events_url":"https://api.github.com/users/YaleSTC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/YaleSTC/reservations","description":"Manage equipment loans & reservations. Who can borrow what, for how long?","fork":false,"url":"https://api.github.com/repos/YaleSTC/reservations","forks_url":"https://api.github.com/repos/YaleSTC/reservations/forks","keys_url":"https://api.github.com/repos/YaleSTC/reservations/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YaleSTC/reservations/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YaleSTC/reservations/teams","hooks_url":"https://api.github.com/repos/YaleSTC/reservations/hooks","issue_events_url":"https://api.github.com/repos/YaleSTC/reservations/issues/events{/number}","events_url":"https://api.github.com/repos/YaleSTC/reservations/events","assignees_url":"https://api.github.com/repos/YaleSTC/reservations/assignees{/user}","branches_url":"https://api.github.com/repos/YaleSTC/reservations/branches{/branch}","tags_url":"https://api.github.com/repos/YaleSTC/reservations/tags","blobs_url":"https://api.github.com/repos/YaleSTC/reservations/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YaleSTC/reservations/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YaleSTC/reservations/git/refs{/sha}","trees_url":"https://api.github.com/repos/YaleSTC/reservations/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YaleSTC/reservations/statuses/{sha}","languages_url":"https://api.github.com/repos/YaleSTC/reservations/languages","stargazers_url":"https://api.github.com/repos/YaleSTC/reservations/stargazers","contributors_url":"https://api.github.com/repos/YaleSTC/reservations/contributors","subscribers_url":"https://api.github.com/repos/YaleSTC/reservations/subscribers","subscription_url":"https://api.github.com/repos/YaleSTC/reservations/subscription","commits_url":"https://api.github.com/repos/YaleSTC/reservations/commits{/sha}","git_commits_url":"https://api.github.com/repos/YaleSTC/reservations/git/commits{/sha}","comments_url":"https://api.github.com/repos/YaleSTC/reservations/comments{/number}","issue_comment_url":"https://api.github.com/repos/YaleSTC/reservations/issues/comments{/number}","contents_url":"https://api.github.com/repos/YaleSTC/reservations/contents/{+path}","compare_url":"https://api.github.com/repos/YaleSTC/reservations/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YaleSTC/reservations/merges","archive_url":"https://api.github.com/repos/YaleSTC/reservations/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YaleSTC/reservations/downloads","issues_url":"https://api.github.com/repos/YaleSTC/reservations/issues{/number}","pulls_url":"https://api.github.com/repos/YaleSTC/reservations/pulls{/number}","milestones_url":"https://api.github.com/repos/YaleSTC/reservations/milestones{/number}","notifications_url":"https://api.github.com/repos/YaleSTC/reservations/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YaleSTC/reservations/labels{/name}","releases_url":"https://api.github.com/repos/YaleSTC/reservations/releases{/id}","created_at":"2009-10-21T21:08:00Z","updated_at":"2015-11-28T09:10:15Z","pushed_at":"2015-12-23T01:25:24Z","git_url":"git://github.com/YaleSTC/reservations.git","ssh_url":"git@github.com:YaleSTC/reservations.git","clone_url":"https://github.com/YaleSTC/reservations.git","svn_url":"https://github.com/YaleSTC/reservations","homepage":"yalestc.github.io/reservations","size":52814,"stargazers_count":59,"watchers_count":59,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":29,"mirror_url":null,"open_issues_count":144,"forks":29,"open_issues":144,"watchers":59,"default_branch":"master"}},"base":{"label":"YaleSTC:master","ref":"master","sha":"50cb671115f607a32e1d7770bea9d810cba87a80","user":{"login":"YaleSTC","id":106094,"avatar_url":"https://avatars.githubusercontent.com/u/106094?v=3","gravatar_id":"","url":"https://api.github.com/users/YaleSTC","html_url":"https://github.com/YaleSTC","followers_url":"https://api.github.com/users/YaleSTC/followers","following_url":"https://api.github.com/users/YaleSTC/following{/other_user}","gists_url":"https://api.github.com/users/YaleSTC/gists{/gist_id}","starred_url":"https://api.github.com/users/YaleSTC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YaleSTC/subscriptions","organizations_url":"https://api.github.com/users/YaleSTC/orgs","repos_url":"https://api.github.com/users/YaleSTC/repos","events_url":"https://api.github.com/users/YaleSTC/events{/privacy}","received_events_url":"https://api.github.com/users/YaleSTC/received_events","type":"Organization","site_admin":false},"repo":{"id":345280,"name":"reservations","full_name":"YaleSTC/reservations","owner":{"login":"YaleSTC","id":106094,"avatar_url":"https://avatars.githubusercontent.com/u/106094?v=3","gravatar_id":"","url":"https://api.github.com/users/YaleSTC","html_url":"https://github.com/YaleSTC","followers_url":"https://api.github.com/users/YaleSTC/followers","following_url":"https://api.github.com/users/YaleSTC/following{/other_user}","gists_url":"https://api.github.com/users/YaleSTC/gists{/gist_id}","starred_url":"https://api.github.com/users/YaleSTC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YaleSTC/subscriptions","organizations_url":"https://api.github.com/users/YaleSTC/orgs","repos_url":"https://api.github.com/users/YaleSTC/repos","events_url":"https://api.github.com/users/YaleSTC/events{/privacy}","received_events_url":"https://api.github.com/users/YaleSTC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/YaleSTC/reservations","description":"Manage equipment loans & reservations. Who can borrow what, for how long?","fork":false,"url":"https://api.github.com/repos/YaleSTC/reservations","forks_url":"https://api.github.com/repos/YaleSTC/reservations/forks","keys_url":"https://api.github.com/repos/YaleSTC/reservations/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YaleSTC/reservations/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YaleSTC/reservations/teams","hooks_url":"https://api.github.com/repos/YaleSTC/reservations/hooks","issue_events_url":"https://api.github.com/repos/YaleSTC/reservations/issues/events{/number}","events_url":"https://api.github.com/repos/YaleSTC/reservations/events","assignees_url":"https://api.github.com/repos/YaleSTC/reservations/assignees{/user}","branches_url":"https://api.github.com/repos/YaleSTC/reservations/branches{/branch}","tags_url":"https://api.github.com/repos/YaleSTC/reservations/tags","blobs_url":"https://api.github.com/repos/YaleSTC/reservations/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YaleSTC/reservations/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YaleSTC/reservations/git/refs{/sha}","trees_url":"https://api.github.com/repos/YaleSTC/reservations/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YaleSTC/reservations/statuses/{sha}","languages_url":"https://api.github.com/repos/YaleSTC/reservations/languages","stargazers_url":"https://api.github.com/repos/YaleSTC/reservations/stargazers","contributors_url":"https://api.github.com/repos/YaleSTC/reservations/contributors","subscribers_url":"https://api.github.com/repos/YaleSTC/reservations/subscribers","subscription_url":"https://api.github.com/repos/YaleSTC/reservations/subscription","commits_url":"https://api.github.com/repos/YaleSTC/reservations/commits{/sha}","git_commits_url":"https://api.github.com/repos/YaleSTC/reservations/git/commits{/sha}","comments_url":"https://api.github.com/repos/YaleSTC/reservations/comments{/number}","issue_comment_url":"https://api.github.com/repos/YaleSTC/reservations/issues/comments{/number}","contents_url":"https://api.github.com/repos/YaleSTC/reservations/contents/{+path}","compare_url":"https://api.github.com/repos/YaleSTC/reservations/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YaleSTC/reservations/merges","archive_url":"https://api.github.com/repos/YaleSTC/reservations/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YaleSTC/reservations/downloads","issues_url":"https://api.github.com/repos/YaleSTC/reservations/issues{/number}","pulls_url":"https://api.github.com/repos/YaleSTC/reservations/pulls{/number}","milestones_url":"https://api.github.com/repos/YaleSTC/reservations/milestones{/number}","notifications_url":"https://api.github.com/repos/YaleSTC/reservations/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YaleSTC/reservations/labels{/name}","releases_url":"https://api.github.com/repos/YaleSTC/reservations/releases{/id}","created_at":"2009-10-21T21:08:00Z","updated_at":"2015-11-28T09:10:15Z","pushed_at":"2015-12-23T01:25:24Z","git_url":"git://github.com/YaleSTC/reservations.git","ssh_url":"git@github.com:YaleSTC/reservations.git","clone_url":"https://github.com/YaleSTC/reservations.git","svn_url":"https://github.com/YaleSTC/reservations","homepage":"yalestc.github.io/reservations","size":52814,"stargazers_count":59,"watchers_count":59,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":29,"mirror_url":null,"open_issues_count":144,"forks":29,"open_issues":144,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/YaleSTC/reservations/pulls/1350"},"html":{"href":"https://github.com/YaleSTC/reservations/pull/1350"},"issue":{"href":"https://api.github.com/repos/YaleSTC/reservations/issues/1350"},"comments":{"href":"https://api.github.com/repos/YaleSTC/reservations/issues/1350/comments"},"review_comments":{"href":"https://api.github.com/repos/YaleSTC/reservations/pulls/1350/comments"},"review_comment":{"href":"https://api.github.com/repos/YaleSTC/reservations/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/YaleSTC/reservations/pulls/1350/commits"},"statuses":{"href":"https://api.github.com/repos/YaleSTC/reservations/statuses/1924e0b989b9508cfd4c4067fba5a5654c97335b"}}}}