{"action":"created","issue":{"url":"https://api.github.com/repos/codice/ddf/issues/255","labels_url":"https://api.github.com/repos/codice/ddf/issues/255/labels{/name}","comments_url":"https://api.github.com/repos/codice/ddf/issues/255/comments","events_url":"https://api.github.com/repos/codice/ddf/issues/255/events","html_url":"https://github.com/codice/ddf/pull/255","id":111482423,"number":255,"title":"DDF-1519 created IdP that satisfies most of the SAML 2 Web SSO profile","user":{"login":"stustison","id":4391679,"avatar_url":"https://avatars.githubusercontent.com/u/4391679?v=3","gravatar_id":"","url":"https://api.github.com/users/stustison","html_url":"https://github.com/stustison","followers_url":"https://api.github.com/users/stustison/followers","following_url":"https://api.github.com/users/stustison/following{/other_user}","gists_url":"https://api.github.com/users/stustison/gists{/gist_id}","starred_url":"https://api.github.com/users/stustison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stustison/subscriptions","organizations_url":"https://api.github.com/users/stustison/orgs","repos_url":"https://api.github.com/users/stustison/repos","events_url":"https://api.github.com/users/stustison/events{/privacy}","received_events_url":"https://api.github.com/users/stustison/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-10-14T20:10:57Z","updated_at":"2015-10-20T18:11:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/255","html_url":"https://github.com/codice/ddf/pull/255","diff_url":"https://github.com/codice/ddf/pull/255.diff","patch_url":"https://github.com/codice/ddf/pull/255.patch"},"body":"Still verifying some things, but getting this out early for review.\r\n\r\nJust want to note right off the bat, however, that there will be some tickets to resolve some of the technical debt that this adds, namely: unit tests, itests, and refactoring the IdpEndpoint itself to clean up the code. Feel free to comment on any ways that you'd like to see IdpEndpoint cleaned up, and it will be added to that ticket.\r\n\r\n@pklinef @lessarderic @coyotesqrl @djblue @vinamartin @brendan-hofmann\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/codice/ddf/255)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/codice/ddf/issues/comments/149651311","html_url":"https://github.com/codice/ddf/pull/255#issuecomment-149651311","issue_url":"https://api.github.com/repos/codice/ddf/issues/255","id":149651311,"user":{"login":"lessarderic","id":11377558,"avatar_url":"https://avatars.githubusercontent.com/u/11377558?v=3","gravatar_id":"","url":"https://api.github.com/users/lessarderic","html_url":"https://github.com/lessarderic","followers_url":"https://api.github.com/users/lessarderic/followers","following_url":"https://api.github.com/users/lessarderic/following{/other_user}","gists_url":"https://api.github.com/users/lessarderic/gists{/gist_id}","starred_url":"https://api.github.com/users/lessarderic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lessarderic/subscriptions","organizations_url":"https://api.github.com/users/lessarderic/orgs","repos_url":"https://api.github.com/users/lessarderic/repos","events_url":"https://api.github.com/users/lessarderic/events{/privacy}","received_events_url":"https://api.github.com/users/lessarderic/received_events","type":"User","site_admin":false},"created_at":"2015-10-20T18:11:23Z","updated_at":"2015-10-20T18:11:23Z","body":"\n\n\n\n\n\n\n\n<sup>**[platform/security/idp/security-idp-server/src/main/java/org/codice/ddf/security/idp/server/Idp.java, line 32 \\[r2\\]](https://reviewable.io:443/reviews/codice/ddf/255#-K0byYEWSvaJYb-5zCtt-r2-32)** ([raw file](https://github.com/codice/ddf/blob/6530b45a6ff570165a83c845eea551c0913e32b6/platform/security/idp/security-idp-server/src/main/java/org/codice/ddf/security/idp/server/Idp.java#L32)):</sup>\nI personally like interfaces :-)\n<!-- Reviewable comment -K15Re22dni7CMcJbvWy:1262421794 -->\n\n---\n\n\nComments from the [review on Reviewable.io](https://reviewable.io:443/reviews/codice/ddf/255)\n<!-- Sent from Reviewable.io -->\n"}}