{"action":"closed","number":18,"pull_request":{"url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/pulls/18","id":45864209,"html_url":"https://github.com/4teamwork/ftw.sliderblock/pull/18","diff_url":"https://github.com/4teamwork/ftw.sliderblock/pull/18.diff","patch_url":"https://github.com/4teamwork/ftw.sliderblock/pull/18.patch","issue_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/issues/18","number":18,"state":"closed","locked":false,"title":"Remove title from link and add alttext to image","user":{"login":"elioschmutz","id":557005,"avatar_url":"https://avatars.githubusercontent.com/u/557005?v=3","gravatar_id":"","url":"https://api.github.com/users/elioschmutz","html_url":"https://github.com/elioschmutz","followers_url":"https://api.github.com/users/elioschmutz/followers","following_url":"https://api.github.com/users/elioschmutz/following{/other_user}","gists_url":"https://api.github.com/users/elioschmutz/gists{/gist_id}","starred_url":"https://api.github.com/users/elioschmutz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elioschmutz/subscriptions","organizations_url":"https://api.github.com/users/elioschmutz/orgs","repos_url":"https://api.github.com/users/elioschmutz/repos","events_url":"https://api.github.com/users/elioschmutz/events{/privacy}","received_events_url":"https://api.github.com/users/elioschmutz/received_events","type":"User","site_admin":false},"body":"@maethu \r\n\r\nThe implementation was like this:\r\n\r\n- Add the description of a pane as image alt-text if no link exists\r\n- Add no image alt-text if a link exists.\r\n- Add pane-description as link-title if a link exists \r\n\r\nThe new implementation is:\r\n\r\n- Add no title attribute on the link\r\n- Add always the pane-description as alt-text to the image-tag\r\n\r\nWhy?\r\n\r\n- Accessibility reasons.\r\n\r\nIf we have a link with an image inside, the image should have always an alt text.\r\nThe title attribute of the link will be ignored from the screen-reader.","created_at":"2015-09-24T06:44:45Z","updated_at":"2015-09-24T07:20:35Z","closed_at":"2015-09-24T07:20:33Z","merged_at":"2015-09-24T07:20:33Z","merge_commit_sha":"1a413150d06ea822e9b2c92330097bb0b9784504","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/pulls/18/commits","review_comments_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/pulls/18/comments","review_comment_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/pulls/comments{/number}","comments_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/issues/18/comments","statuses_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/statuses/c06d15ea2b23080dd5d1c55aa998aae3590e20bc","head":{"label":"4teamwork:es-678-alt-text-for-images","ref":"es-678-alt-text-for-images","sha":"c06d15ea2b23080dd5d1c55aa998aae3590e20bc","user":{"login":"4teamwork","id":681821,"avatar_url":"https://avatars.githubusercontent.com/u/681821?v=3","gravatar_id":"","url":"https://api.github.com/users/4teamwork","html_url":"https://github.com/4teamwork","followers_url":"https://api.github.com/users/4teamwork/followers","following_url":"https://api.github.com/users/4teamwork/following{/other_user}","gists_url":"https://api.github.com/users/4teamwork/gists{/gist_id}","starred_url":"https://api.github.com/users/4teamwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4teamwork/subscriptions","organizations_url":"https://api.github.com/users/4teamwork/orgs","repos_url":"https://api.github.com/users/4teamwork/repos","events_url":"https://api.github.com/users/4teamwork/events{/privacy}","received_events_url":"https://api.github.com/users/4teamwork/received_events","type":"Organization","site_admin":false},"repo":{"id":37849207,"name":"ftw.sliderblock","full_name":"4teamwork/ftw.sliderblock","owner":{"login":"4teamwork","id":681821,"avatar_url":"https://avatars.githubusercontent.com/u/681821?v=3","gravatar_id":"","url":"https://api.github.com/users/4teamwork","html_url":"https://github.com/4teamwork","followers_url":"https://api.github.com/users/4teamwork/followers","following_url":"https://api.github.com/users/4teamwork/following{/other_user}","gists_url":"https://api.github.com/users/4teamwork/gists{/gist_id}","starred_url":"https://api.github.com/users/4teamwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4teamwork/subscriptions","organizations_url":"https://api.github.com/users/4teamwork/orgs","repos_url":"https://api.github.com/users/4teamwork/repos","events_url":"https://api.github.com/users/4teamwork/events{/privacy}","received_events_url":"https://api.github.com/users/4teamwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/4teamwork/ftw.sliderblock","description":"","fork":false,"url":"https://api.github.com/repos/4teamwork/ftw.sliderblock","forks_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/forks","keys_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/teams","hooks_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/hooks","issue_events_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/issues/events{/number}","events_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/events","assignees_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/assignees{/user}","branches_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/branches{/branch}","tags_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/tags","blobs_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/git/refs{/sha}","trees_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/statuses/{sha}","languages_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/languages","stargazers_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/stargazers","contributors_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/contributors","subscribers_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/subscribers","subscription_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/subscription","commits_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/commits{/sha}","git_commits_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/git/commits{/sha}","comments_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/comments{/number}","issue_comment_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/issues/comments{/number}","contents_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/contents/{+path}","compare_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/merges","archive_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/downloads","issues_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/issues{/number}","pulls_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/pulls{/number}","milestones_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/milestones{/number}","notifications_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/labels{/name}","releases_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/releases{/id}","created_at":"2015-06-22T10:22:27Z","updated_at":"2015-06-26T06:21:04Z","pushed_at":"2015-09-24T07:20:35Z","git_url":"git://github.com/4teamwork/ftw.sliderblock.git","ssh_url":"git@github.com:4teamwork/ftw.sliderblock.git","clone_url":"https://github.com/4teamwork/ftw.sliderblock.git","svn_url":"https://github.com/4teamwork/ftw.sliderblock","homepage":null,"size":356,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"4teamwork:master","ref":"master","sha":"e1f4e68179bf03c416bded55a81e8e10c4ff8997","user":{"login":"4teamwork","id":681821,"avatar_url":"https://avatars.githubusercontent.com/u/681821?v=3","gravatar_id":"","url":"https://api.github.com/users/4teamwork","html_url":"https://github.com/4teamwork","followers_url":"https://api.github.com/users/4teamwork/followers","following_url":"https://api.github.com/users/4teamwork/following{/other_user}","gists_url":"https://api.github.com/users/4teamwork/gists{/gist_id}","starred_url":"https://api.github.com/users/4teamwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4teamwork/subscriptions","organizations_url":"https://api.github.com/users/4teamwork/orgs","repos_url":"https://api.github.com/users/4teamwork/repos","events_url":"https://api.github.com/users/4teamwork/events{/privacy}","received_events_url":"https://api.github.com/users/4teamwork/received_events","type":"Organization","site_admin":false},"repo":{"id":37849207,"name":"ftw.sliderblock","full_name":"4teamwork/ftw.sliderblock","owner":{"login":"4teamwork","id":681821,"avatar_url":"https://avatars.githubusercontent.com/u/681821?v=3","gravatar_id":"","url":"https://api.github.com/users/4teamwork","html_url":"https://github.com/4teamwork","followers_url":"https://api.github.com/users/4teamwork/followers","following_url":"https://api.github.com/users/4teamwork/following{/other_user}","gists_url":"https://api.github.com/users/4teamwork/gists{/gist_id}","starred_url":"https://api.github.com/users/4teamwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4teamwork/subscriptions","organizations_url":"https://api.github.com/users/4teamwork/orgs","repos_url":"https://api.github.com/users/4teamwork/repos","events_url":"https://api.github.com/users/4teamwork/events{/privacy}","received_events_url":"https://api.github.com/users/4teamwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/4teamwork/ftw.sliderblock","description":"","fork":false,"url":"https://api.github.com/repos/4teamwork/ftw.sliderblock","forks_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/forks","keys_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/teams","hooks_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/hooks","issue_events_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/issues/events{/number}","events_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/events","assignees_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/assignees{/user}","branches_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/branches{/branch}","tags_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/tags","blobs_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/git/refs{/sha}","trees_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/statuses/{sha}","languages_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/languages","stargazers_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/stargazers","contributors_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/contributors","subscribers_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/subscribers","subscription_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/subscription","commits_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/commits{/sha}","git_commits_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/git/commits{/sha}","comments_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/comments{/number}","issue_comment_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/issues/comments{/number}","contents_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/contents/{+path}","compare_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/merges","archive_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/downloads","issues_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/issues{/number}","pulls_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/pulls{/number}","milestones_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/milestones{/number}","notifications_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/labels{/name}","releases_url":"https://api.github.com/repos/4teamwork/ftw.sliderblock/releases{/id}","created_at":"2015-06-22T10:22:27Z","updated_at":"2015-06-26T06:21:04Z","pushed_at":"2015-09-24T07:20:35Z","git_url":"git://github.com/4teamwork/ftw.sliderblock.git","ssh_url":"git@github.com:4teamwork/ftw.sliderblock.git","clone_url":"https://github.com/4teamwork/ftw.sliderblock.git","svn_url":"https://github.com/4teamwork/ftw.sliderblock","homepage":null,"size":356,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/4teamwork/ftw.sliderblock/pulls/18"},"html":{"href":"https://github.com/4teamwork/ftw.sliderblock/pull/18"},"issue":{"href":"https://api.github.com/repos/4teamwork/ftw.sliderblock/issues/18"},"comments":{"href":"https://api.github.com/repos/4teamwork/ftw.sliderblock/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/4teamwork/ftw.sliderblock/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/4teamwork/ftw.sliderblock/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/4teamwork/ftw.sliderblock/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/4teamwork/ftw.sliderblock/statuses/c06d15ea2b23080dd5d1c55aa998aae3590e20bc"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jone","id":7469,"avatar_url":"https://avatars.githubusercontent.com/u/7469?v=3","gravatar_id":"","url":"https://api.github.com/users/jone","html_url":"https://github.com/jone","followers_url":"https://api.github.com/users/jone/followers","following_url":"https://api.github.com/users/jone/following{/other_user}","gists_url":"https://api.github.com/users/jone/gists{/gist_id}","starred_url":"https://api.github.com/users/jone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jone/subscriptions","organizations_url":"https://api.github.com/users/jone/orgs","repos_url":"https://api.github.com/users/jone/repos","events_url":"https://api.github.com/users/jone/events{/privacy}","received_events_url":"https://api.github.com/users/jone/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":2,"deletions":3,"changed_files":1}}