{"action":"created","comment":{"url":"https://api.github.com/repos/cbeust/testng/pulls/comments/26495065","id":26495065,"diff_hunk":"@@ -30,7 +30,7 @@\n   private static String[] s_testClassPaths;\n \n   /** The additional class loaders to find classes in. */\n-  private static final List<ClassLoader> m_classLoaders = new Vector<ClassLoader>();\n+  private static final List<ClassLoader> m_classLoaders = new Vector<>();","path":"src/main/java/org/testng/internal/PackageUtils.java","position":5,"original_position":5,"commit_id":"84a155a8aefdfa32796b3dfed8964bdf4bd097f4","original_commit_id":"84a155a8aefdfa32796b3dfed8964bdf4bd097f4","user":{"login":"kullfar","id":736714,"avatar_url":"https://avatars.githubusercontent.com/u/736714?v=3","gravatar_id":"","url":"https://api.github.com/users/kullfar","html_url":"https://github.com/kullfar","followers_url":"https://api.github.com/users/kullfar/followers","following_url":"https://api.github.com/users/kullfar/following{/other_user}","gists_url":"https://api.github.com/users/kullfar/gists{/gist_id}","starred_url":"https://api.github.com/users/kullfar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kullfar/subscriptions","organizations_url":"https://api.github.com/users/kullfar/orgs","repos_url":"https://api.github.com/users/kullfar/repos","events_url":"https://api.github.com/users/kullfar/events{/privacy}","received_events_url":"https://api.github.com/users/kullfar/received_events","type":"User","site_admin":false},"body":"java 7 sugar","created_at":"2015-03-16T15:30:35Z","updated_at":"2015-03-16T15:30:35Z","html_url":"https://github.com/cbeust/testng/pull/618#discussion_r26495065","pull_request_url":"https://api.github.com/repos/cbeust/testng/pulls/618","_links":{"self":{"href":"https://api.github.com/repos/cbeust/testng/pulls/comments/26495065"},"html":{"href":"https://github.com/cbeust/testng/pull/618#discussion_r26495065"},"pull_request":{"href":"https://api.github.com/repos/cbeust/testng/pulls/618"}}},"pull_request":{"url":"https://api.github.com/repos/cbeust/testng/pulls/618","id":31253686,"html_url":"https://github.com/cbeust/testng/pull/618","diff_url":"https://github.com/cbeust/testng/pull/618.diff","patch_url":"https://github.com/cbeust/testng/pull/618.patch","issue_url":"https://api.github.com/repos/cbeust/testng/issues/618","number":618,"state":"open","locked":false,"title":"fix jar scanning for <packages> element in testng.xml suite description ...","user":{"login":"kullfar","id":736714,"avatar_url":"https://avatars.githubusercontent.com/u/736714?v=3","gravatar_id":"","url":"https://api.github.com/users/kullfar","html_url":"https://github.com/kullfar","followers_url":"https://api.github.com/users/kullfar/followers","following_url":"https://api.github.com/users/kullfar/following{/other_user}","gists_url":"https://api.github.com/users/kullfar/gists{/gist_id}","starred_url":"https://api.github.com/users/kullfar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kullfar/subscriptions","organizations_url":"https://api.github.com/users/kullfar/orgs","repos_url":"https://api.github.com/users/kullfar/repos","events_url":"https://api.github.com/users/kullfar/events{/privacy}","received_events_url":"https://api.github.com/users/kullfar/received_events","type":"User","site_admin":false},"body":"...(do not include subpackages if not recursive)\r\n\r\nFor the moment, xml suite descriptions like this\r\n```\r\n<!DOCTYPE suite SYSTEM \"http://testng.org/testng-1.0.dtd\" >\r\n<suite name=\"example\" verbose=\"1\" parallel=\"classes\" thread-count=\"4\">\r\n    <test name=\"example2\">\r\n        <groups>\r\n            <run>\r\n                <!--<include  />-->\r\n            </run>\r\n        </groups>\r\n\r\n        <packages>\r\n            <package name=\"com.example.tests\"/>\r\n        </packages>\r\n    </test>\r\n</suite>\r\n\r\n```\r\n\r\nwill cause\r\n``` mvn test -Dsurefire.suiteXmlFiles=testng.xml ```\r\nto run only com.example.tests.*.class test not recursive. it's OK\r\nand\r\n``` java -cp ... org.testng.TestNG -testjar target/example-1.0.jar -xmlpathinjar testng.xml ```\r\nwill cause to run ALL test, including subpackages.\r\n\r\nthis pull request will fix it.\r\n","created_at":"2015-03-16T15:29:21Z","updated_at":"2015-03-16T15:30:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ab6002ba0d2224f87e9d3f873071a1d6106d17b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cbeust/testng/pulls/618/commits","review_comments_url":"https://api.github.com/repos/cbeust/testng/pulls/618/comments","review_comment_url":"https://api.github.com/repos/cbeust/testng/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cbeust/testng/issues/618/comments","statuses_url":"https://api.github.com/repos/cbeust/testng/statuses/84a155a8aefdfa32796b3dfed8964bdf4bd097f4","head":{"label":"kullfar:master","ref":"master","sha":"84a155a8aefdfa32796b3dfed8964bdf4bd097f4","user":{"login":"kullfar","id":736714,"avatar_url":"https://avatars.githubusercontent.com/u/736714?v=3","gravatar_id":"","url":"https://api.github.com/users/kullfar","html_url":"https://github.com/kullfar","followers_url":"https://api.github.com/users/kullfar/followers","following_url":"https://api.github.com/users/kullfar/following{/other_user}","gists_url":"https://api.github.com/users/kullfar/gists{/gist_id}","starred_url":"https://api.github.com/users/kullfar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kullfar/subscriptions","organizations_url":"https://api.github.com/users/kullfar/orgs","repos_url":"https://api.github.com/users/kullfar/repos","events_url":"https://api.github.com/users/kullfar/events{/privacy}","received_events_url":"https://api.github.com/users/kullfar/received_events","type":"User","site_admin":false},"repo":{"id":32324759,"name":"testng","full_name":"kullfar/testng","owner":{"login":"kullfar","id":736714,"avatar_url":"https://avatars.githubusercontent.com/u/736714?v=3","gravatar_id":"","url":"https://api.github.com/users/kullfar","html_url":"https://github.com/kullfar","followers_url":"https://api.github.com/users/kullfar/followers","following_url":"https://api.github.com/users/kullfar/following{/other_user}","gists_url":"https://api.github.com/users/kullfar/gists{/gist_id}","starred_url":"https://api.github.com/users/kullfar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kullfar/subscriptions","organizations_url":"https://api.github.com/users/kullfar/orgs","repos_url":"https://api.github.com/users/kullfar/repos","events_url":"https://api.github.com/users/kullfar/events{/privacy}","received_events_url":"https://api.github.com/users/kullfar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kullfar/testng","description":"TestNG testing framework","fork":true,"url":"https://api.github.com/repos/kullfar/testng","forks_url":"https://api.github.com/repos/kullfar/testng/forks","keys_url":"https://api.github.com/repos/kullfar/testng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kullfar/testng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kullfar/testng/teams","hooks_url":"https://api.github.com/repos/kullfar/testng/hooks","issue_events_url":"https://api.github.com/repos/kullfar/testng/issues/events{/number}","events_url":"https://api.github.com/repos/kullfar/testng/events","assignees_url":"https://api.github.com/repos/kullfar/testng/assignees{/user}","branches_url":"https://api.github.com/repos/kullfar/testng/branches{/branch}","tags_url":"https://api.github.com/repos/kullfar/testng/tags","blobs_url":"https://api.github.com/repos/kullfar/testng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kullfar/testng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kullfar/testng/git/refs{/sha}","trees_url":"https://api.github.com/repos/kullfar/testng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kullfar/testng/statuses/{sha}","languages_url":"https://api.github.com/repos/kullfar/testng/languages","stargazers_url":"https://api.github.com/repos/kullfar/testng/stargazers","contributors_url":"https://api.github.com/repos/kullfar/testng/contributors","subscribers_url":"https://api.github.com/repos/kullfar/testng/subscribers","subscription_url":"https://api.github.com/repos/kullfar/testng/subscription","commits_url":"https://api.github.com/repos/kullfar/testng/commits{/sha}","git_commits_url":"https://api.github.com/repos/kullfar/testng/git/commits{/sha}","comments_url":"https://api.github.com/repos/kullfar/testng/comments{/number}","issue_comment_url":"https://api.github.com/repos/kullfar/testng/issues/comments{/number}","contents_url":"https://api.github.com/repos/kullfar/testng/contents/{+path}","compare_url":"https://api.github.com/repos/kullfar/testng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kullfar/testng/merges","archive_url":"https://api.github.com/repos/kullfar/testng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kullfar/testng/downloads","issues_url":"https://api.github.com/repos/kullfar/testng/issues{/number}","pulls_url":"https://api.github.com/repos/kullfar/testng/pulls{/number}","milestones_url":"https://api.github.com/repos/kullfar/testng/milestones{/number}","notifications_url":"https://api.github.com/repos/kullfar/testng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kullfar/testng/labels{/name}","releases_url":"https://api.github.com/repos/kullfar/testng/releases{/id}","created_at":"2015-03-16T12:55:37Z","updated_at":"2015-03-16T15:22:57Z","pushed_at":"2015-03-16T15:22:57Z","git_url":"git://github.com/kullfar/testng.git","ssh_url":"git@github.com:kullfar/testng.git","clone_url":"https://github.com/kullfar/testng.git","svn_url":"https://github.com/kullfar/testng","homepage":"http://testng.org","size":27844,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cbeust:master","ref":"master","sha":"a0deae2b7f7f7815c68aaa31fca8c0be562ad297","user":{"login":"cbeust","id":92322,"avatar_url":"https://avatars.githubusercontent.com/u/92322?v=3","gravatar_id":"","url":"https://api.github.com/users/cbeust","html_url":"https://github.com/cbeust","followers_url":"https://api.github.com/users/cbeust/followers","following_url":"https://api.github.com/users/cbeust/following{/other_user}","gists_url":"https://api.github.com/users/cbeust/gists{/gist_id}","starred_url":"https://api.github.com/users/cbeust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbeust/subscriptions","organizations_url":"https://api.github.com/users/cbeust/orgs","repos_url":"https://api.github.com/users/cbeust/repos","events_url":"https://api.github.com/users/cbeust/events{/privacy}","received_events_url":"https://api.github.com/users/cbeust/received_events","type":"User","site_admin":false},"repo":{"id":745749,"name":"testng","full_name":"cbeust/testng","owner":{"login":"cbeust","id":92322,"avatar_url":"https://avatars.githubusercontent.com/u/92322?v=3","gravatar_id":"","url":"https://api.github.com/users/cbeust","html_url":"https://github.com/cbeust","followers_url":"https://api.github.com/users/cbeust/followers","following_url":"https://api.github.com/users/cbeust/following{/other_user}","gists_url":"https://api.github.com/users/cbeust/gists{/gist_id}","starred_url":"https://api.github.com/users/cbeust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbeust/subscriptions","organizations_url":"https://api.github.com/users/cbeust/orgs","repos_url":"https://api.github.com/users/cbeust/repos","events_url":"https://api.github.com/users/cbeust/events{/privacy}","received_events_url":"https://api.github.com/users/cbeust/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cbeust/testng","description":"TestNG testing framework","fork":false,"url":"https://api.github.com/repos/cbeust/testng","forks_url":"https://api.github.com/repos/cbeust/testng/forks","keys_url":"https://api.github.com/repos/cbeust/testng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cbeust/testng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cbeust/testng/teams","hooks_url":"https://api.github.com/repos/cbeust/testng/hooks","issue_events_url":"https://api.github.com/repos/cbeust/testng/issues/events{/number}","events_url":"https://api.github.com/repos/cbeust/testng/events","assignees_url":"https://api.github.com/repos/cbeust/testng/assignees{/user}","branches_url":"https://api.github.com/repos/cbeust/testng/branches{/branch}","tags_url":"https://api.github.com/repos/cbeust/testng/tags","blobs_url":"https://api.github.com/repos/cbeust/testng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cbeust/testng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cbeust/testng/git/refs{/sha}","trees_url":"https://api.github.com/repos/cbeust/testng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cbeust/testng/statuses/{sha}","languages_url":"https://api.github.com/repos/cbeust/testng/languages","stargazers_url":"https://api.github.com/repos/cbeust/testng/stargazers","contributors_url":"https://api.github.com/repos/cbeust/testng/contributors","subscribers_url":"https://api.github.com/repos/cbeust/testng/subscribers","subscription_url":"https://api.github.com/repos/cbeust/testng/subscription","commits_url":"https://api.github.com/repos/cbeust/testng/commits{/sha}","git_commits_url":"https://api.github.com/repos/cbeust/testng/git/commits{/sha}","comments_url":"https://api.github.com/repos/cbeust/testng/comments{/number}","issue_comment_url":"https://api.github.com/repos/cbeust/testng/issues/comments{/number}","contents_url":"https://api.github.com/repos/cbeust/testng/contents/{+path}","compare_url":"https://api.github.com/repos/cbeust/testng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cbeust/testng/merges","archive_url":"https://api.github.com/repos/cbeust/testng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cbeust/testng/downloads","issues_url":"https://api.github.com/repos/cbeust/testng/issues{/number}","pulls_url":"https://api.github.com/repos/cbeust/testng/pulls{/number}","milestones_url":"https://api.github.com/repos/cbeust/testng/milestones{/number}","notifications_url":"https://api.github.com/repos/cbeust/testng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cbeust/testng/labels{/name}","releases_url":"https://api.github.com/repos/cbeust/testng/releases{/id}","created_at":"2010-06-28T23:10:17Z","updated_at":"2015-03-16T03:49:18Z","pushed_at":"2015-03-12T16:52:37Z","git_url":"git://github.com/cbeust/testng.git","ssh_url":"git@github.com:cbeust/testng.git","clone_url":"https://github.com/cbeust/testng.git","svn_url":"https://github.com/cbeust/testng","homepage":"http://testng.org","size":27844,"stargazers_count":426,"watchers_count":426,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":315,"mirror_url":null,"open_issues_count":307,"forks":315,"open_issues":307,"watchers":426,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cbeust/testng/pulls/618"},"html":{"href":"https://github.com/cbeust/testng/pull/618"},"issue":{"href":"https://api.github.com/repos/cbeust/testng/issues/618"},"comments":{"href":"https://api.github.com/repos/cbeust/testng/issues/618/comments"},"review_comments":{"href":"https://api.github.com/repos/cbeust/testng/pulls/618/comments"},"review_comment":{"href":"https://api.github.com/repos/cbeust/testng/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cbeust/testng/pulls/618/commits"},"statuses":{"href":"https://api.github.com/repos/cbeust/testng/statuses/84a155a8aefdfa32796b3dfed8964bdf4bd097f4"}}}}