{"action":"created","comment":{"url":"https://api.github.com/repos/akka/akka/pulls/comments/34562850","id":34562850,"diff_hunk":"@@ -13,83 +16,88 @@ import MediaTypes._\n import HttpCharsets._\n \n class ContentNegotiationSpec extends FreeSpec with Matchers {\n-\n   \"Content Negotiation should work properly for requests with header(s)\" - {\n \n-    \"(without headers)\" in test { accept ⇒\n-      accept(`text/plain`) should select(`text/plain`, `UTF-8`)\n+    \"(without headers)\" test { accept ⇒\n+      //accept(`text/plain`) should select(`text/plain`, `UTF-8`)\n       accept(`text/plain` withCharset `UTF-16`) should select(`text/plain`, `UTF-16`)\n     }\n \n-    \"Accept: */*\" in test { accept ⇒\n+    \"Accept: */*\" test { accept ⇒\n       accept(`text/plain`) should select(`text/plain`, `UTF-8`)\n       accept(`text/plain` withCharset `UTF-16`) should select(`text/plain`, `UTF-16`)\n     }\n \n-    \"Accept: */*;q=.8\" in test { accept ⇒\n+    \"Accept: */*;q=.8\" test { accept ⇒\n       accept(`text/plain`) should select(`text/plain`, `UTF-8`)\n       accept(`text/plain` withCharset `UTF-16`) should select(`text/plain`, `UTF-16`)\n     }\n \n-    \"Accept: text/*\" in test { accept ⇒\n+    \"Accept: text/*\" test { accept ⇒\n       accept(`text/plain`) should select(`text/plain`, `UTF-8`)\n       accept(`text/xml` withCharset `UTF-16`) should select(`text/xml`, `UTF-16`)\n       accept(`audio/ogg`) should reject\n     }\n \n-    \"Accept: text/*;q=.8\" in test { accept ⇒\n+    \"Accept: text/*;q=.8\" test { accept ⇒\n       accept(`text/plain`) should select(`text/plain`, `UTF-8`)\n       accept(`text/xml` withCharset `UTF-16`) should select(`text/xml`, `UTF-16`)\n       accept(`audio/ogg`) should reject\n     }\n \n-    \"Accept: text/*;q=0\" in test { accept ⇒\n+    \"Accept: text/*;q=0\" test { accept ⇒\n       accept(`text/plain`) should reject\n       accept(`text/xml` withCharset `UTF-16`) should reject\n       accept(`audio/ogg`) should reject\n     }\n \n-    \"Accept-Charset: UTF-16\" in test { accept ⇒\n+    \"Accept-Charset: UTF-16\" test { accept ⇒\n+      accept(`text/plain`) should select(`text/plain`, `UTF-16`)\n+      accept(`text/plain` withCharset `UTF-8`) should reject\n+    }\n+\n+    \"manually created Accept-Charset: UTF-16\" in testHeaders(headers.`Accept-Charset`(Vector(HttpCharsets.`UTF-16`.toRange))) { accept ⇒\n       accept(`text/plain`) should select(`text/plain`, `UTF-16`)\n       accept(`text/plain` withCharset `UTF-8`) should reject\n     }\n \n-    \"Accept-Charset: UTF-16, UTF-8\" in test { accept ⇒\n+    \"Accept-Charset: UTF-16, UTF-8\" test { accept ⇒\n       accept(`text/plain`) should select(`text/plain`, `UTF-8`)\n       accept(`text/plain` withCharset `UTF-16`) should select(`text/plain`, `UTF-16`)\n     }\n \n-    \"Accept-Charset: UTF-8;q=.2, UTF-16\" in test { accept ⇒\n+    \"Accept-Charset: UTF-8;q=.2, UTF-16\" test { accept ⇒\n       accept(`text/plain`) should select(`text/plain`, `UTF-16`)\n       accept(`text/plain` withCharset `UTF-8`) should select(`text/plain`, `UTF-8`)\n     }\n \n-    \"Accept-Charset: UTF-8;q=.2\" in test { accept ⇒\n-      accept(`text/plain`) should select(`text/plain`, `ISO-8859-1`)\n+    \"Accept-Charset: UTF-8;q=.2\" test { accept ⇒\n+      // FIXME: which rule would enforce that behavior?\n+      // accept(`text/plain`) should select(`text/plain`, `ISO-8859-1`)","path":"akka-http-tests/src/test/scala/akka/http/scaladsl/marshalling/ContentNegotiationSpec.scala","position":84,"original_position":84,"commit_id":"07b4077fa29d0cc7cc127176f50d3dd20a87417b","original_commit_id":"07b4077fa29d0cc7cc127176f50d3dd20a87417b","user":{"login":"jrudolph","id":9868,"avatar_url":"https://avatars.githubusercontent.com/u/9868?v=3","gravatar_id":"","url":"https://api.github.com/users/jrudolph","html_url":"https://github.com/jrudolph","followers_url":"https://api.github.com/users/jrudolph/followers","following_url":"https://api.github.com/users/jrudolph/following{/other_user}","gists_url":"https://api.github.com/users/jrudolph/gists{/gist_id}","starred_url":"https://api.github.com/users/jrudolph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrudolph/subscriptions","organizations_url":"https://api.github.com/users/jrudolph/orgs","repos_url":"https://api.github.com/users/jrudolph/repos","events_url":"https://api.github.com/users/jrudolph/events{/privacy}","received_events_url":"https://api.github.com/users/jrudolph/received_events","type":"User","site_admin":false},"body":"Hmm, but it still makes no sense as choosing an explicit charset should always take that one, right?","created_at":"2015-07-14T12:35:02Z","updated_at":"2015-07-14T12:35:02Z","html_url":"https://github.com/akka/akka/pull/17987#discussion_r34562850","pull_request_url":"https://api.github.com/repos/akka/akka/pulls/17987","_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/comments/34562850"},"html":{"href":"https://github.com/akka/akka/pull/17987#discussion_r34562850"},"pull_request":{"href":"https://api.github.com/repos/akka/akka/pulls/17987"}}},"pull_request":{"url":"https://api.github.com/repos/akka/akka/pulls/17987","id":39905190,"html_url":"https://github.com/akka/akka/pull/17987","diff_url":"https://github.com/akka/akka/pull/17987.diff","patch_url":"https://github.com/akka/akka/pull/17987.patch","issue_url":"https://api.github.com/repos/akka/akka/issues/17987","number":17987,"state":"open","locked":false,"title":"ContentNegotiation fixes (and breakage)","user":{"login":"jrudolph","id":9868,"avatar_url":"https://avatars.githubusercontent.com/u/9868?v=3","gravatar_id":"","url":"https://api.github.com/users/jrudolph","html_url":"https://github.com/jrudolph","followers_url":"https://api.github.com/users/jrudolph/followers","following_url":"https://api.github.com/users/jrudolph/following{/other_user}","gists_url":"https://api.github.com/users/jrudolph/gists{/gist_id}","starred_url":"https://api.github.com/users/jrudolph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrudolph/subscriptions","organizations_url":"https://api.github.com/users/jrudolph/orgs","repos_url":"https://api.github.com/users/jrudolph/repos","events_url":"https://api.github.com/users/jrudolph/events{/privacy}","received_events_url":"https://api.github.com/users/jrudolph/received_events","type":"User","site_admin":false},"body":"Fixes #17985. Only fixes the \"not run tests part\" from #17984.\r\n\r\n/cc @sirthias, @2beaucoup","created_at":"2015-07-14T11:12:53Z","updated_at":"2015-07-14T12:35:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54e6aa1c96985d8a5d39af66706752224f6f3fee","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/akka/akka/pulls/17987/commits","review_comments_url":"https://api.github.com/repos/akka/akka/pulls/17987/comments","review_comment_url":"https://api.github.com/repos/akka/akka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akka/akka/issues/17987/comments","statuses_url":"https://api.github.com/repos/akka/akka/statuses/07b4077fa29d0cc7cc127176f50d3dd20a87417b","head":{"label":"spray:w/17984-enable-content-negotiation-tests","ref":"w/17984-enable-content-negotiation-tests","sha":"07b4077fa29d0cc7cc127176f50d3dd20a87417b","user":{"login":"spray","id":688516,"avatar_url":"https://avatars.githubusercontent.com/u/688516?v=3","gravatar_id":"","url":"https://api.github.com/users/spray","html_url":"https://github.com/spray","followers_url":"https://api.github.com/users/spray/followers","following_url":"https://api.github.com/users/spray/following{/other_user}","gists_url":"https://api.github.com/users/spray/gists{/gist_id}","starred_url":"https://api.github.com/users/spray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spray/subscriptions","organizations_url":"https://api.github.com/users/spray/orgs","repos_url":"https://api.github.com/users/spray/repos","events_url":"https://api.github.com/users/spray/events{/privacy}","received_events_url":"https://api.github.com/users/spray/received_events","type":"Organization","site_admin":false},"repo":{"id":3809985,"name":"akka","full_name":"spray/akka","owner":{"login":"spray","id":688516,"avatar_url":"https://avatars.githubusercontent.com/u/688516?v=3","gravatar_id":"","url":"https://api.github.com/users/spray","html_url":"https://github.com/spray","followers_url":"https://api.github.com/users/spray/followers","following_url":"https://api.github.com/users/spray/following{/other_user}","gists_url":"https://api.github.com/users/spray/gists{/gist_id}","starred_url":"https://api.github.com/users/spray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spray/subscriptions","organizations_url":"https://api.github.com/users/spray/orgs","repos_url":"https://api.github.com/users/spray/repos","events_url":"https://api.github.com/users/spray/events{/privacy}","received_events_url":"https://api.github.com/users/spray/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spray/akka","description":"Akka Project","fork":true,"url":"https://api.github.com/repos/spray/akka","forks_url":"https://api.github.com/repos/spray/akka/forks","keys_url":"https://api.github.com/repos/spray/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spray/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spray/akka/teams","hooks_url":"https://api.github.com/repos/spray/akka/hooks","issue_events_url":"https://api.github.com/repos/spray/akka/issues/events{/number}","events_url":"https://api.github.com/repos/spray/akka/events","assignees_url":"https://api.github.com/repos/spray/akka/assignees{/user}","branches_url":"https://api.github.com/repos/spray/akka/branches{/branch}","tags_url":"https://api.github.com/repos/spray/akka/tags","blobs_url":"https://api.github.com/repos/spray/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spray/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spray/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/spray/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spray/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/spray/akka/languages","stargazers_url":"https://api.github.com/repos/spray/akka/stargazers","contributors_url":"https://api.github.com/repos/spray/akka/contributors","subscribers_url":"https://api.github.com/repos/spray/akka/subscribers","subscription_url":"https://api.github.com/repos/spray/akka/subscription","commits_url":"https://api.github.com/repos/spray/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/spray/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/spray/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/spray/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/spray/akka/contents/{+path}","compare_url":"https://api.github.com/repos/spray/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spray/akka/merges","archive_url":"https://api.github.com/repos/spray/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spray/akka/downloads","issues_url":"https://api.github.com/repos/spray/akka/issues{/number}","pulls_url":"https://api.github.com/repos/spray/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/spray/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/spray/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spray/akka/labels{/name}","releases_url":"https://api.github.com/repos/spray/akka/releases{/id}","created_at":"2012-03-23T15:57:31Z","updated_at":"2015-06-16T22:36:06Z","pushed_at":"2015-07-14T12:15:36Z","git_url":"git://github.com/spray/akka.git","ssh_url":"git@github.com:spray/akka.git","clone_url":"https://github.com/spray/akka.git","svn_url":"https://github.com/spray/akka","homepage":"http://akka.io","size":160072,"stargazers_count":7,"watchers_count":7,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":7,"default_branch":"master"}},"base":{"label":"akka:release-2.3-dev","ref":"release-2.3-dev","sha":"9bc85f1048e74c67e62789f13e37bce4b30e8bfc","user":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":130013,"name":"akka","full_name":"akka/akka","owner":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akka/akka","description":"Akka Project","fork":false,"url":"https://api.github.com/repos/akka/akka","forks_url":"https://api.github.com/repos/akka/akka/forks","keys_url":"https://api.github.com/repos/akka/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka/teams","hooks_url":"https://api.github.com/repos/akka/akka/hooks","issue_events_url":"https://api.github.com/repos/akka/akka/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka/events","assignees_url":"https://api.github.com/repos/akka/akka/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka/tags","blobs_url":"https://api.github.com/repos/akka/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka/languages","stargazers_url":"https://api.github.com/repos/akka/akka/stargazers","contributors_url":"https://api.github.com/repos/akka/akka/contributors","subscribers_url":"https://api.github.com/repos/akka/akka/subscribers","subscription_url":"https://api.github.com/repos/akka/akka/subscription","commits_url":"https://api.github.com/repos/akka/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/akka/akka/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka/merges","archive_url":"https://api.github.com/repos/akka/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka/downloads","issues_url":"https://api.github.com/repos/akka/akka/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka/releases{/id}","created_at":"2009-02-16T12:51:54Z","updated_at":"2015-07-14T10:26:03Z","pushed_at":"2015-07-14T12:15:40Z","git_url":"git://github.com/akka/akka.git","ssh_url":"git@github.com:akka/akka.git","clone_url":"https://github.com/akka/akka.git","svn_url":"https://github.com/akka/akka","homepage":"http://akka.io","size":263855,"stargazers_count":4213,"watchers_count":4213,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1227,"mirror_url":null,"open_issues_count":673,"forks":1227,"open_issues":673,"watchers":4213,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/17987"},"html":{"href":"https://github.com/akka/akka/pull/17987"},"issue":{"href":"https://api.github.com/repos/akka/akka/issues/17987"},"comments":{"href":"https://api.github.com/repos/akka/akka/issues/17987/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/akka/pulls/17987/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/akka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akka/akka/pulls/17987/commits"},"statuses":{"href":"https://api.github.com/repos/akka/akka/statuses/07b4077fa29d0cc7cc127176f50d3dd20a87417b"}}}}