{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/5059","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/5059/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/5059/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/5059/events","html_url":"https://github.com/ManageIQ/manageiq/pull/5059","id":112970774,"number":5059,"title":"count_only is now a mandatary parameter of `x_get_tree_...` methods","user":{"login":"DNNX","id":447953,"avatar_url":"https://avatars.githubusercontent.com/u/447953?v=3","gravatar_id":"","url":"https://api.github.com/users/DNNX","html_url":"https://github.com/DNNX","followers_url":"https://api.github.com/users/DNNX/followers","following_url":"https://api.github.com/users/DNNX/following{/other_user}","gists_url":"https://api.github.com/users/DNNX/gists{/gist_id}","starred_url":"https://api.github.com/users/DNNX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DNNX/subscriptions","organizations_url":"https://api.github.com/users/DNNX/orgs","repos_url":"https://api.github.com/users/DNNX/repos","events_url":"https://api.github.com/users/DNNX/events{/privacy}","received_events_url":"https://api.github.com/users/DNNX/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/refactoring","name":"refactoring","color":"fbca04"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/ui","name":"ui","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-10-23T07:57:04Z","updated_at":"2015-10-23T14:21:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5059","html_url":"https://github.com/ManageIQ/manageiq/pull/5059","diff_url":"https://github.com/ManageIQ/manageiq/pull/5059.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/5059.patch"},"body":"@martinpovolny please have a look. I made `count_only` and `parents` required parameters, as we discussed here https://github.com/ManageIQ/manageiq/pull/5000#issuecomment-150202571 .\r\n\r\nSorry this PR is so huge, but it's kinda hard to break it into smaller pieces :(\r\n\r\nIn most cases I was able to get rid of passing `options` to `x_get_tree_...` methods and they now require just one or two properly named parameters, but there are still ugly pieces. Take a look at `x_get_tree_custom_kids`, for example. There are two dozens or so implementations of it. Some of them require `parent`, `count_only` and `leaf`. Others use `parent`, `count_only` and `type`. Many of them just use `parent` and `count_only`. One of them just wants `count_only`. This leads to the necessity to pass `parent`, `count_only` and raw `options` hash. In most cases `_options` is ignored, but 7 implementations use it to extract either `:leaf` or `:type` key.\r\n\r\nAnyway, please take a look and say what you think."},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/150588250","html_url":"https://github.com/ManageIQ/manageiq/pull/5059#issuecomment-150588250","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/5059","id":150588250,"user":{"login":"DNNX","id":447953,"avatar_url":"https://avatars.githubusercontent.com/u/447953?v=3","gravatar_id":"","url":"https://api.github.com/users/DNNX","html_url":"https://github.com/DNNX","followers_url":"https://api.github.com/users/DNNX/followers","following_url":"https://api.github.com/users/DNNX/following{/other_user}","gists_url":"https://api.github.com/users/DNNX/gists{/gist_id}","starred_url":"https://api.github.com/users/DNNX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DNNX/subscriptions","organizations_url":"https://api.github.com/users/DNNX/orgs","repos_url":"https://api.github.com/users/DNNX/repos","events_url":"https://api.github.com/users/DNNX/events{/privacy}","received_events_url":"https://api.github.com/users/DNNX/received_events","type":"User","site_admin":false},"created_at":"2015-10-23T14:21:39Z","updated_at":"2015-10-23T14:21:39Z","body":"Oh sorry, I overlooked it. I was expecting an email notification in case of test failures, but I haven't got any. I'm having a look now."}}