{"action":"created","issue":{"url":"https://api.github.com/repos/Cardshifter/HTML-Client/issues/108","labels_url":"https://api.github.com/repos/Cardshifter/HTML-Client/issues/108/labels{/name}","comments_url":"https://api.github.com/repos/Cardshifter/HTML-Client/issues/108/comments","events_url":"https://api.github.com/repos/Cardshifter/HTML-Client/issues/108/events","html_url":"https://github.com/Cardshifter/HTML-Client/issues/108","id":108242727,"number":108,"title":"Two big problems: unit testing and controllers","user":{"login":"SirPython","id":8549957,"avatar_url":"https://avatars.githubusercontent.com/u/8549957?v=3","gravatar_id":"","url":"https://api.github.com/users/SirPython","html_url":"https://github.com/SirPython","followers_url":"https://api.github.com/users/SirPython/followers","following_url":"https://api.github.com/users/SirPython/following{/other_user}","gists_url":"https://api.github.com/users/SirPython/gists{/gist_id}","starred_url":"https://api.github.com/users/SirPython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SirPython/subscriptions","organizations_url":"https://api.github.com/users/SirPython/orgs","repos_url":"https://api.github.com/users/SirPython/repos","events_url":"https://api.github.com/users/SirPython/events{/privacy}","received_events_url":"https://api.github.com/users/SirPython/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Cardshifter/HTML-Client/labels/question","name":"question","color":"cc317c"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-09-25T00:55:09Z","updated_at":"2015-09-25T08:17:51Z","closed_at":null,"body":"Right now, I see two large problems with this client:\r\n\r\n- We don't have unit testing.\r\n- Our controllers are holding too much logic (they need to be refactored into smaller ones)\r\n\r\nWhich one is more of a problem? Which one should we work on fixing first?"},"comment":{"url":"https://api.github.com/repos/Cardshifter/HTML-Client/issues/comments/143156713","html_url":"https://github.com/Cardshifter/HTML-Client/issues/108#issuecomment-143156713","issue_url":"https://api.github.com/repos/Cardshifter/HTML-Client/issues/108","id":143156713,"user":{"login":"danpantry","id":2939173,"avatar_url":"https://avatars.githubusercontent.com/u/2939173?v=3","gravatar_id":"","url":"https://api.github.com/users/danpantry","html_url":"https://github.com/danpantry","followers_url":"https://api.github.com/users/danpantry/followers","following_url":"https://api.github.com/users/danpantry/following{/other_user}","gists_url":"https://api.github.com/users/danpantry/gists{/gist_id}","starred_url":"https://api.github.com/users/danpantry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danpantry/subscriptions","organizations_url":"https://api.github.com/users/danpantry/orgs","repos_url":"https://api.github.com/users/danpantry/repos","events_url":"https://api.github.com/users/danpantry/events{/privacy}","received_events_url":"https://api.github.com/users/danpantry/received_events","type":"User","site_admin":false},"created_at":"2015-09-25T08:17:51Z","updated_at":"2015-09-25T08:17:51Z","body":"I vote for refactoring out the functionality while writing tests for that functionality, a bit at a time, in small bites. Don't try and refactor the entire controller at once."}}