{"action":"created","comment":{"url":"https://api.github.com/repos/statgen/locuszoom/pulls/comments/48351245","id":48351245,"diff_hunk":"@@ -11,11 +11,11 @@\n   <link rel=\"stylesheet\" type=\"text/css\" href=\"assets/css/locuszoom.css\"/>\n \n   <script type=\"text/javascript\">\n-    LocusZoom.DefaultDataSources = {\n-        position: new LocusZoom.Data.AssociationSource(\"http://portaldev.sph.umich.edu/api_internal_dev/v1/single/\"),\n-        ld: new LocusZoom.Data.LDSource(\"http://portaldev.sph.umich.edu/api_internal_dev/v1/pair/LD/\"),\n-        gene: new LocusZoom.Data.GeneSource(\"http://portaldev.sph.umich.edu/api_internal_dev/v1/annotation/genes/\")\n-    };\n+    var apiBase = \"http://portaldev.sph.umich.edu/api_internal_dev/v1/\";\n+    var ds = new LocusZoom.DataSources();\n+\tds.addSource(\"base\", [\"AssociationLZ\", {url:apiBase + \"single/\", params: {analysis: 3}}]);","path":"demo.html","position":11,"original_position":11,"commit_id":"d51fae0dd293d5b7c78d161811b87acc3aaada70","original_commit_id":"d51fae0dd293d5b7c78d161811b87acc3aaada70","user":{"login":"Frencil","id":143358,"avatar_url":"https://avatars.githubusercontent.com/u/143358?v=3","gravatar_id":"","url":"https://api.github.com/users/Frencil","html_url":"https://github.com/Frencil","followers_url":"https://api.github.com/users/Frencil/followers","following_url":"https://api.github.com/users/Frencil/following{/other_user}","gists_url":"https://api.github.com/users/Frencil/gists{/gist_id}","starred_url":"https://api.github.com/users/Frencil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Frencil/subscriptions","organizations_url":"https://api.github.com/users/Frencil/orgs","repos_url":"https://api.github.com/users/Frencil/repos","events_url":"https://api.github.com/users/Frencil/events{/privacy}","received_events_url":"https://api.github.com/users/Frencil/received_events","type":"User","site_admin":false},"body":"So unlike \"LD\" and \"Gene\" the positions/base/associations datasource/datalayer/panel seem to have a lot of names. Well, not that many. And naming things is one of the [two hard things](http://martinfowler.com/bliki/TwoHardThings.html). But does it feel like there's any convergence on a common name here? Quite probably all the names in play are totally legit for how they're used. Suffice it to say when I named that one panel the `PositionsPanel` I wasn't sure if it was the best name, and I'm still not. So if there is a more globally-applicable name for the main stuff rising above the rest I'd be happy to help apply it more globally.","created_at":"2015-12-23T15:04:14Z","updated_at":"2015-12-23T15:04:14Z","html_url":"https://github.com/statgen/locuszoom/pull/7#discussion_r48351245","pull_request_url":"https://api.github.com/repos/statgen/locuszoom/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/statgen/locuszoom/pulls/comments/48351245"},"html":{"href":"https://github.com/statgen/locuszoom/pull/7#discussion_r48351245"},"pull_request":{"href":"https://api.github.com/repos/statgen/locuszoom/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/statgen/locuszoom/pulls/7","id":54304627,"html_url":"https://github.com/statgen/locuszoom/pull/7","diff_url":"https://github.com/statgen/locuszoom/pull/7.diff","patch_url":"https://github.com/statgen/locuszoom/pull/7.patch","issue_url":"https://api.github.com/repos/statgen/locuszoom/issues/7","number":7,"state":"open","locked":false,"title":"Datainit","user":{"login":"MrFlick","id":7140684,"avatar_url":"https://avatars.githubusercontent.com/u/7140684?v=3","gravatar_id":"","url":"https://api.github.com/users/MrFlick","html_url":"https://github.com/MrFlick","followers_url":"https://api.github.com/users/MrFlick/followers","following_url":"https://api.github.com/users/MrFlick/following{/other_user}","gists_url":"https://api.github.com/users/MrFlick/gists{/gist_id}","starred_url":"https://api.github.com/users/MrFlick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrFlick/subscriptions","organizations_url":"https://api.github.com/users/MrFlick/orgs","repos_url":"https://api.github.com/users/MrFlick/repos","events_url":"https://api.github.com/users/MrFlick/events{/privacy}","received_events_url":"https://api.github.com/users/MrFlick/received_events","type":"User","site_admin":false},"body":"These changes update the interaction for specifying API data endpoints that are consumed by the data. This introduces a new LocusZoom.DataSources() object that allows for adding namespace/datasource pairs either though chainable .addSource() calls, or through an object literal syntax via .setSource() or via a JSON string.\r\n\r\nThis also updates the initialization methods populate() and populateAll(). These should be the primary means of create LZ objects. They have more broad support for D3 selectors and have separate paramters for data sources, plot layout, and initial state (though the later two are not yet implemented).","created_at":"2015-12-21T21:23:38Z","updated_at":"2015-12-23T15:04:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aba6d39fa6986b95557ced09127e38960574d469","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/statgen/locuszoom/pulls/7/commits","review_comments_url":"https://api.github.com/repos/statgen/locuszoom/pulls/7/comments","review_comment_url":"https://api.github.com/repos/statgen/locuszoom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/statgen/locuszoom/issues/7/comments","statuses_url":"https://api.github.com/repos/statgen/locuszoom/statuses/d51fae0dd293d5b7c78d161811b87acc3aaada70","head":{"label":"statgen:datainit","ref":"datainit","sha":"d51fae0dd293d5b7c78d161811b87acc3aaada70","user":{"login":"statgen","id":651584,"avatar_url":"https://avatars.githubusercontent.com/u/651584?v=3","gravatar_id":"","url":"https://api.github.com/users/statgen","html_url":"https://github.com/statgen","followers_url":"https://api.github.com/users/statgen/followers","following_url":"https://api.github.com/users/statgen/following{/other_user}","gists_url":"https://api.github.com/users/statgen/gists{/gist_id}","starred_url":"https://api.github.com/users/statgen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/statgen/subscriptions","organizations_url":"https://api.github.com/users/statgen/orgs","repos_url":"https://api.github.com/users/statgen/repos","events_url":"https://api.github.com/users/statgen/events{/privacy}","received_events_url":"https://api.github.com/users/statgen/received_events","type":"Organization","site_admin":false},"repo":{"id":41318680,"name":"locuszoom","full_name":"statgen/locuszoom","owner":{"login":"statgen","id":651584,"avatar_url":"https://avatars.githubusercontent.com/u/651584?v=3","gravatar_id":"","url":"https://api.github.com/users/statgen","html_url":"https://github.com/statgen","followers_url":"https://api.github.com/users/statgen/followers","following_url":"https://api.github.com/users/statgen/following{/other_user}","gists_url":"https://api.github.com/users/statgen/gists{/gist_id}","starred_url":"https://api.github.com/users/statgen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/statgen/subscriptions","organizations_url":"https://api.github.com/users/statgen/orgs","repos_url":"https://api.github.com/users/statgen/repos","events_url":"https://api.github.com/users/statgen/events{/privacy}","received_events_url":"https://api.github.com/users/statgen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/statgen/locuszoom","description":"A Javascript/d3 embeddable plugin for interactively visualizing statistical genetic data from customizable sources.","fork":false,"url":"https://api.github.com/repos/statgen/locuszoom","forks_url":"https://api.github.com/repos/statgen/locuszoom/forks","keys_url":"https://api.github.com/repos/statgen/locuszoom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/statgen/locuszoom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/statgen/locuszoom/teams","hooks_url":"https://api.github.com/repos/statgen/locuszoom/hooks","issue_events_url":"https://api.github.com/repos/statgen/locuszoom/issues/events{/number}","events_url":"https://api.github.com/repos/statgen/locuszoom/events","assignees_url":"https://api.github.com/repos/statgen/locuszoom/assignees{/user}","branches_url":"https://api.github.com/repos/statgen/locuszoom/branches{/branch}","tags_url":"https://api.github.com/repos/statgen/locuszoom/tags","blobs_url":"https://api.github.com/repos/statgen/locuszoom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/statgen/locuszoom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/statgen/locuszoom/git/refs{/sha}","trees_url":"https://api.github.com/repos/statgen/locuszoom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/statgen/locuszoom/statuses/{sha}","languages_url":"https://api.github.com/repos/statgen/locuszoom/languages","stargazers_url":"https://api.github.com/repos/statgen/locuszoom/stargazers","contributors_url":"https://api.github.com/repos/statgen/locuszoom/contributors","subscribers_url":"https://api.github.com/repos/statgen/locuszoom/subscribers","subscription_url":"https://api.github.com/repos/statgen/locuszoom/subscription","commits_url":"https://api.github.com/repos/statgen/locuszoom/commits{/sha}","git_commits_url":"https://api.github.com/repos/statgen/locuszoom/git/commits{/sha}","comments_url":"https://api.github.com/repos/statgen/locuszoom/comments{/number}","issue_comment_url":"https://api.github.com/repos/statgen/locuszoom/issues/comments{/number}","contents_url":"https://api.github.com/repos/statgen/locuszoom/contents/{+path}","compare_url":"https://api.github.com/repos/statgen/locuszoom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/statgen/locuszoom/merges","archive_url":"https://api.github.com/repos/statgen/locuszoom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/statgen/locuszoom/downloads","issues_url":"https://api.github.com/repos/statgen/locuszoom/issues{/number}","pulls_url":"https://api.github.com/repos/statgen/locuszoom/pulls{/number}","milestones_url":"https://api.github.com/repos/statgen/locuszoom/milestones{/number}","notifications_url":"https://api.github.com/repos/statgen/locuszoom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/statgen/locuszoom/labels{/name}","releases_url":"https://api.github.com/repos/statgen/locuszoom/releases{/id}","created_at":"2015-08-24T18:01:44Z","updated_at":"2015-12-22T21:30:29Z","pushed_at":"2015-12-22T21:45:46Z","git_url":"git://github.com/statgen/locuszoom.git","ssh_url":"git@github.com:statgen/locuszoom.git","clone_url":"https://github.com/statgen/locuszoom.git","svn_url":"https://github.com/statgen/locuszoom","homepage":"","size":335,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"statgen:master","ref":"master","sha":"b6ea0a28a2fe605b3d9eb12214eec9fbde060c1c","user":{"login":"statgen","id":651584,"avatar_url":"https://avatars.githubusercontent.com/u/651584?v=3","gravatar_id":"","url":"https://api.github.com/users/statgen","html_url":"https://github.com/statgen","followers_url":"https://api.github.com/users/statgen/followers","following_url":"https://api.github.com/users/statgen/following{/other_user}","gists_url":"https://api.github.com/users/statgen/gists{/gist_id}","starred_url":"https://api.github.com/users/statgen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/statgen/subscriptions","organizations_url":"https://api.github.com/users/statgen/orgs","repos_url":"https://api.github.com/users/statgen/repos","events_url":"https://api.github.com/users/statgen/events{/privacy}","received_events_url":"https://api.github.com/users/statgen/received_events","type":"Organization","site_admin":false},"repo":{"id":41318680,"name":"locuszoom","full_name":"statgen/locuszoom","owner":{"login":"statgen","id":651584,"avatar_url":"https://avatars.githubusercontent.com/u/651584?v=3","gravatar_id":"","url":"https://api.github.com/users/statgen","html_url":"https://github.com/statgen","followers_url":"https://api.github.com/users/statgen/followers","following_url":"https://api.github.com/users/statgen/following{/other_user}","gists_url":"https://api.github.com/users/statgen/gists{/gist_id}","starred_url":"https://api.github.com/users/statgen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/statgen/subscriptions","organizations_url":"https://api.github.com/users/statgen/orgs","repos_url":"https://api.github.com/users/statgen/repos","events_url":"https://api.github.com/users/statgen/events{/privacy}","received_events_url":"https://api.github.com/users/statgen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/statgen/locuszoom","description":"A Javascript/d3 embeddable plugin for interactively visualizing statistical genetic data from customizable sources.","fork":false,"url":"https://api.github.com/repos/statgen/locuszoom","forks_url":"https://api.github.com/repos/statgen/locuszoom/forks","keys_url":"https://api.github.com/repos/statgen/locuszoom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/statgen/locuszoom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/statgen/locuszoom/teams","hooks_url":"https://api.github.com/repos/statgen/locuszoom/hooks","issue_events_url":"https://api.github.com/repos/statgen/locuszoom/issues/events{/number}","events_url":"https://api.github.com/repos/statgen/locuszoom/events","assignees_url":"https://api.github.com/repos/statgen/locuszoom/assignees{/user}","branches_url":"https://api.github.com/repos/statgen/locuszoom/branches{/branch}","tags_url":"https://api.github.com/repos/statgen/locuszoom/tags","blobs_url":"https://api.github.com/repos/statgen/locuszoom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/statgen/locuszoom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/statgen/locuszoom/git/refs{/sha}","trees_url":"https://api.github.com/repos/statgen/locuszoom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/statgen/locuszoom/statuses/{sha}","languages_url":"https://api.github.com/repos/statgen/locuszoom/languages","stargazers_url":"https://api.github.com/repos/statgen/locuszoom/stargazers","contributors_url":"https://api.github.com/repos/statgen/locuszoom/contributors","subscribers_url":"https://api.github.com/repos/statgen/locuszoom/subscribers","subscription_url":"https://api.github.com/repos/statgen/locuszoom/subscription","commits_url":"https://api.github.com/repos/statgen/locuszoom/commits{/sha}","git_commits_url":"https://api.github.com/repos/statgen/locuszoom/git/commits{/sha}","comments_url":"https://api.github.com/repos/statgen/locuszoom/comments{/number}","issue_comment_url":"https://api.github.com/repos/statgen/locuszoom/issues/comments{/number}","contents_url":"https://api.github.com/repos/statgen/locuszoom/contents/{+path}","compare_url":"https://api.github.com/repos/statgen/locuszoom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/statgen/locuszoom/merges","archive_url":"https://api.github.com/repos/statgen/locuszoom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/statgen/locuszoom/downloads","issues_url":"https://api.github.com/repos/statgen/locuszoom/issues{/number}","pulls_url":"https://api.github.com/repos/statgen/locuszoom/pulls{/number}","milestones_url":"https://api.github.com/repos/statgen/locuszoom/milestones{/number}","notifications_url":"https://api.github.com/repos/statgen/locuszoom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/statgen/locuszoom/labels{/name}","releases_url":"https://api.github.com/repos/statgen/locuszoom/releases{/id}","created_at":"2015-08-24T18:01:44Z","updated_at":"2015-12-22T21:30:29Z","pushed_at":"2015-12-22T21:45:46Z","git_url":"git://github.com/statgen/locuszoom.git","ssh_url":"git@github.com:statgen/locuszoom.git","clone_url":"https://github.com/statgen/locuszoom.git","svn_url":"https://github.com/statgen/locuszoom","homepage":"","size":335,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/statgen/locuszoom/pulls/7"},"html":{"href":"https://github.com/statgen/locuszoom/pull/7"},"issue":{"href":"https://api.github.com/repos/statgen/locuszoom/issues/7"},"comments":{"href":"https://api.github.com/repos/statgen/locuszoom/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/statgen/locuszoom/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/statgen/locuszoom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/statgen/locuszoom/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/statgen/locuszoom/statuses/d51fae0dd293d5b7c78d161811b87acc3aaada70"}}}}