{"action":"closed","number":229,"pull_request":{"url":"https://api.github.com/repos/sculpin/sculpin/pulls/229","id":33229673,"html_url":"https://github.com/sculpin/sculpin/pull/229","diff_url":"https://github.com/sculpin/sculpin/pull/229.diff","patch_url":"https://github.com/sculpin/sculpin/pull/229.patch","issue_url":"https://api.github.com/repos/sculpin/sculpin/issues/229","number":229,"state":"closed","locked":false,"title":"Fix ArrayAccess setter for \"set\"-Prefixed methods in ProxySourceItem","user":{"login":"bcremer","id":55820,"avatar_url":"https://avatars.githubusercontent.com/u/55820?v=3","gravatar_id":"","url":"https://api.github.com/users/bcremer","html_url":"https://github.com/bcremer","followers_url":"https://api.github.com/users/bcremer/followers","following_url":"https://api.github.com/users/bcremer/following{/other_user}","gists_url":"https://api.github.com/users/bcremer/gists{/gist_id}","starred_url":"https://api.github.com/users/bcremer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcremer/subscriptions","organizations_url":"https://api.github.com/users/bcremer/orgs","repos_url":"https://api.github.com/users/bcremer/repos","events_url":"https://api.github.com/users/bcremer/events{/privacy}","received_events_url":"https://api.github.com/users/bcremer/received_events","type":"User","site_admin":false},"body":"`$proxy->offsetSet('foo', 'bar')` or `$proxy['foo'] = 'bar'` should call `$proxy->setFoo('bar')` if method `setFoo()` exists in the `ProxySourceItem`.\r\n\r\nI am not sure if the magic `set*` implementation in `offsetSet` is desired after all.\r\n\r\n1. This issue exists since Jan 5 2014 introduced here: https://github.com/sculpin/sculpin/commit/b5009c51512623456d782bcebbdb3d2f23270406#diff-93bd9bcccd85a4cb1252ac59d0f9c947R114\r\n2. `offsetGet` does not not check for `get*` methods\r\n\r\n","created_at":"2015-04-14T06:32:14Z","updated_at":"2015-04-14T07:47:45Z","closed_at":"2015-04-14T07:47:45Z","merged_at":"2015-04-14T07:47:45Z","merge_commit_sha":"698b7f12d034804251a59131f01885c5cbc959d5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sculpin/sculpin/pulls/229/commits","review_comments_url":"https://api.github.com/repos/sculpin/sculpin/pulls/229/comments","review_comment_url":"https://api.github.com/repos/sculpin/sculpin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sculpin/sculpin/issues/229/comments","statuses_url":"https://api.github.com/repos/sculpin/sculpin/statuses/498d6dd47d8d3018dd99e864d0ff7817b29fe15d","head":{"label":"bcremer:patch-2","ref":"patch-2","sha":"498d6dd47d8d3018dd99e864d0ff7817b29fe15d","user":{"login":"bcremer","id":55820,"avatar_url":"https://avatars.githubusercontent.com/u/55820?v=3","gravatar_id":"","url":"https://api.github.com/users/bcremer","html_url":"https://github.com/bcremer","followers_url":"https://api.github.com/users/bcremer/followers","following_url":"https://api.github.com/users/bcremer/following{/other_user}","gists_url":"https://api.github.com/users/bcremer/gists{/gist_id}","starred_url":"https://api.github.com/users/bcremer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcremer/subscriptions","organizations_url":"https://api.github.com/users/bcremer/orgs","repos_url":"https://api.github.com/users/bcremer/repos","events_url":"https://api.github.com/users/bcremer/events{/privacy}","received_events_url":"https://api.github.com/users/bcremer/received_events","type":"User","site_admin":false},"repo":{"id":33913554,"name":"sculpin","full_name":"bcremer/sculpin","owner":{"login":"bcremer","id":55820,"avatar_url":"https://avatars.githubusercontent.com/u/55820?v=3","gravatar_id":"","url":"https://api.github.com/users/bcremer","html_url":"https://github.com/bcremer","followers_url":"https://api.github.com/users/bcremer/followers","following_url":"https://api.github.com/users/bcremer/following{/other_user}","gists_url":"https://api.github.com/users/bcremer/gists{/gist_id}","starred_url":"https://api.github.com/users/bcremer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcremer/subscriptions","organizations_url":"https://api.github.com/users/bcremer/orgs","repos_url":"https://api.github.com/users/bcremer/repos","events_url":"https://api.github.com/users/bcremer/events{/privacy}","received_events_url":"https://api.github.com/users/bcremer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bcremer/sculpin","description":"Sculpin — Static Site Generator","fork":true,"url":"https://api.github.com/repos/bcremer/sculpin","forks_url":"https://api.github.com/repos/bcremer/sculpin/forks","keys_url":"https://api.github.com/repos/bcremer/sculpin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bcremer/sculpin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bcremer/sculpin/teams","hooks_url":"https://api.github.com/repos/bcremer/sculpin/hooks","issue_events_url":"https://api.github.com/repos/bcremer/sculpin/issues/events{/number}","events_url":"https://api.github.com/repos/bcremer/sculpin/events","assignees_url":"https://api.github.com/repos/bcremer/sculpin/assignees{/user}","branches_url":"https://api.github.com/repos/bcremer/sculpin/branches{/branch}","tags_url":"https://api.github.com/repos/bcremer/sculpin/tags","blobs_url":"https://api.github.com/repos/bcremer/sculpin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bcremer/sculpin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bcremer/sculpin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bcremer/sculpin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bcremer/sculpin/statuses/{sha}","languages_url":"https://api.github.com/repos/bcremer/sculpin/languages","stargazers_url":"https://api.github.com/repos/bcremer/sculpin/stargazers","contributors_url":"https://api.github.com/repos/bcremer/sculpin/contributors","subscribers_url":"https://api.github.com/repos/bcremer/sculpin/subscribers","subscription_url":"https://api.github.com/repos/bcremer/sculpin/subscription","commits_url":"https://api.github.com/repos/bcremer/sculpin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bcremer/sculpin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bcremer/sculpin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bcremer/sculpin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bcremer/sculpin/contents/{+path}","compare_url":"https://api.github.com/repos/bcremer/sculpin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bcremer/sculpin/merges","archive_url":"https://api.github.com/repos/bcremer/sculpin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bcremer/sculpin/downloads","issues_url":"https://api.github.com/repos/bcremer/sculpin/issues{/number}","pulls_url":"https://api.github.com/repos/bcremer/sculpin/pulls{/number}","milestones_url":"https://api.github.com/repos/bcremer/sculpin/milestones{/number}","notifications_url":"https://api.github.com/repos/bcremer/sculpin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bcremer/sculpin/labels{/name}","releases_url":"https://api.github.com/repos/bcremer/sculpin/releases{/id}","created_at":"2015-04-14T05:56:52Z","updated_at":"2015-04-14T05:56:52Z","pushed_at":"2015-04-14T06:27:22Z","git_url":"git://github.com/bcremer/sculpin.git","ssh_url":"git@github.com:bcremer/sculpin.git","clone_url":"https://github.com/bcremer/sculpin.git","svn_url":"https://github.com/bcremer/sculpin","homepage":"https://sculpin.io","size":2191,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sculpin:master","ref":"master","sha":"60c69756221c6961a8da8633d3959afcb6cb8b0f","user":{"login":"sculpin","id":1389812,"avatar_url":"https://avatars.githubusercontent.com/u/1389812?v=3","gravatar_id":"","url":"https://api.github.com/users/sculpin","html_url":"https://github.com/sculpin","followers_url":"https://api.github.com/users/sculpin/followers","following_url":"https://api.github.com/users/sculpin/following{/other_user}","gists_url":"https://api.github.com/users/sculpin/gists{/gist_id}","starred_url":"https://api.github.com/users/sculpin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sculpin/subscriptions","organizations_url":"https://api.github.com/users/sculpin/orgs","repos_url":"https://api.github.com/users/sculpin/repos","events_url":"https://api.github.com/users/sculpin/events{/privacy}","received_events_url":"https://api.github.com/users/sculpin/received_events","type":"Organization","site_admin":false},"repo":{"id":3024954,"name":"sculpin","full_name":"sculpin/sculpin","owner":{"login":"sculpin","id":1389812,"avatar_url":"https://avatars.githubusercontent.com/u/1389812?v=3","gravatar_id":"","url":"https://api.github.com/users/sculpin","html_url":"https://github.com/sculpin","followers_url":"https://api.github.com/users/sculpin/followers","following_url":"https://api.github.com/users/sculpin/following{/other_user}","gists_url":"https://api.github.com/users/sculpin/gists{/gist_id}","starred_url":"https://api.github.com/users/sculpin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sculpin/subscriptions","organizations_url":"https://api.github.com/users/sculpin/orgs","repos_url":"https://api.github.com/users/sculpin/repos","events_url":"https://api.github.com/users/sculpin/events{/privacy}","received_events_url":"https://api.github.com/users/sculpin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sculpin/sculpin","description":"Sculpin — Static Site Generator","fork":false,"url":"https://api.github.com/repos/sculpin/sculpin","forks_url":"https://api.github.com/repos/sculpin/sculpin/forks","keys_url":"https://api.github.com/repos/sculpin/sculpin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sculpin/sculpin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sculpin/sculpin/teams","hooks_url":"https://api.github.com/repos/sculpin/sculpin/hooks","issue_events_url":"https://api.github.com/repos/sculpin/sculpin/issues/events{/number}","events_url":"https://api.github.com/repos/sculpin/sculpin/events","assignees_url":"https://api.github.com/repos/sculpin/sculpin/assignees{/user}","branches_url":"https://api.github.com/repos/sculpin/sculpin/branches{/branch}","tags_url":"https://api.github.com/repos/sculpin/sculpin/tags","blobs_url":"https://api.github.com/repos/sculpin/sculpin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sculpin/sculpin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sculpin/sculpin/git/refs{/sha}","trees_url":"https://api.github.com/repos/sculpin/sculpin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sculpin/sculpin/statuses/{sha}","languages_url":"https://api.github.com/repos/sculpin/sculpin/languages","stargazers_url":"https://api.github.com/repos/sculpin/sculpin/stargazers","contributors_url":"https://api.github.com/repos/sculpin/sculpin/contributors","subscribers_url":"https://api.github.com/repos/sculpin/sculpin/subscribers","subscription_url":"https://api.github.com/repos/sculpin/sculpin/subscription","commits_url":"https://api.github.com/repos/sculpin/sculpin/commits{/sha}","git_commits_url":"https://api.github.com/repos/sculpin/sculpin/git/commits{/sha}","comments_url":"https://api.github.com/repos/sculpin/sculpin/comments{/number}","issue_comment_url":"https://api.github.com/repos/sculpin/sculpin/issues/comments{/number}","contents_url":"https://api.github.com/repos/sculpin/sculpin/contents/{+path}","compare_url":"https://api.github.com/repos/sculpin/sculpin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sculpin/sculpin/merges","archive_url":"https://api.github.com/repos/sculpin/sculpin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sculpin/sculpin/downloads","issues_url":"https://api.github.com/repos/sculpin/sculpin/issues{/number}","pulls_url":"https://api.github.com/repos/sculpin/sculpin/pulls{/number}","milestones_url":"https://api.github.com/repos/sculpin/sculpin/milestones{/number}","notifications_url":"https://api.github.com/repos/sculpin/sculpin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sculpin/sculpin/labels{/name}","releases_url":"https://api.github.com/repos/sculpin/sculpin/releases{/id}","created_at":"2011-12-21T05:45:31Z","updated_at":"2015-04-14T07:47:46Z","pushed_at":"2015-04-14T07:47:46Z","git_url":"git://github.com/sculpin/sculpin.git","ssh_url":"git@github.com:sculpin/sculpin.git","clone_url":"https://github.com/sculpin/sculpin.git","svn_url":"https://github.com/sculpin/sculpin","homepage":"https://sculpin.io","size":2191,"stargazers_count":676,"watchers_count":676,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":95,"mirror_url":null,"open_issues_count":65,"forks":95,"open_issues":65,"watchers":676,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sculpin/sculpin/pulls/229"},"html":{"href":"https://github.com/sculpin/sculpin/pull/229"},"issue":{"href":"https://api.github.com/repos/sculpin/sculpin/issues/229"},"comments":{"href":"https://api.github.com/repos/sculpin/sculpin/issues/229/comments"},"review_comments":{"href":"https://api.github.com/repos/sculpin/sculpin/pulls/229/comments"},"review_comment":{"href":"https://api.github.com/repos/sculpin/sculpin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sculpin/sculpin/pulls/229/commits"},"statuses":{"href":"https://api.github.com/repos/sculpin/sculpin/statuses/498d6dd47d8d3018dd99e864d0ff7817b29fe15d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"davedevelopment","id":61351,"avatar_url":"https://avatars.githubusercontent.com/u/61351?v=3","gravatar_id":"","url":"https://api.github.com/users/davedevelopment","html_url":"https://github.com/davedevelopment","followers_url":"https://api.github.com/users/davedevelopment/followers","following_url":"https://api.github.com/users/davedevelopment/following{/other_user}","gists_url":"https://api.github.com/users/davedevelopment/gists{/gist_id}","starred_url":"https://api.github.com/users/davedevelopment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davedevelopment/subscriptions","organizations_url":"https://api.github.com/users/davedevelopment/orgs","repos_url":"https://api.github.com/users/davedevelopment/repos","events_url":"https://api.github.com/users/davedevelopment/events{/privacy}","received_events_url":"https://api.github.com/users/davedevelopment/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}