{"action":"created","comment":{"url":"https://api.github.com/repos/openlayers/ol3/pulls/comments/44425695","id":44425695,"diff_hunk":"@@ -230,6 +230,18 @@ ol.structs.LRUCache.prototype.pop = function() {\n  * @param {string} key Key.\n  * @param {T} value Value.\n  */\n+ol.structs.LRUCache.prototype.replace = function(key, value) {\n+  var entry = this.entries_[key];\n+  goog.asserts.assert(entry !== undefined, 'an entry exists for key %s', key);\n+  this.get(key);","path":"src/ol/structs/lrucache.js","position":7,"original_position":7,"commit_id":"1b62cf4e994bb92332b6a32709cfa6045d0fc0c9","original_commit_id":"1b62cf4e994bb92332b6a32709cfa6045d0fc0c9","user":{"login":"elemoine","id":76594,"avatar_url":"https://avatars.githubusercontent.com/u/76594?v=3","gravatar_id":"","url":"https://api.github.com/users/elemoine","html_url":"https://github.com/elemoine","followers_url":"https://api.github.com/users/elemoine/followers","following_url":"https://api.github.com/users/elemoine/following{/other_user}","gists_url":"https://api.github.com/users/elemoine/gists{/gist_id}","starred_url":"https://api.github.com/users/elemoine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elemoine/subscriptions","organizations_url":"https://api.github.com/users/elemoine/orgs","repos_url":"https://api.github.com/users/elemoine/repos","events_url":"https://api.github.com/users/elemoine/events{/privacy}","received_events_url":"https://api.github.com/users/elemoine/received_events","type":"User","site_admin":false},"body":"`get` updates the LRU structure (`oldest`, `newest`, etc.).\r\n\r\nMaybe this would be better:\r\n\r\n```js\r\nol.structs.LRUCache.prototype.replace = function(key, value) {\r\n  this.get(key);  // update `newest_`\r\n  this.entries_[key] = value;\r\n};\r\n```","created_at":"2015-11-10T16:12:20Z","updated_at":"2015-11-10T16:12:20Z","html_url":"https://github.com/openlayers/ol3/pull/4389#discussion_r44425695","pull_request_url":"https://api.github.com/repos/openlayers/ol3/pulls/4389","_links":{"self":{"href":"https://api.github.com/repos/openlayers/ol3/pulls/comments/44425695"},"html":{"href":"https://github.com/openlayers/ol3/pull/4389#discussion_r44425695"},"pull_request":{"href":"https://api.github.com/repos/openlayers/ol3/pulls/4389"}}},"pull_request":{"url":"https://api.github.com/repos/openlayers/ol3/pulls/4389","id":49971085,"html_url":"https://github.com/openlayers/ol3/pull/4389","diff_url":"https://github.com/openlayers/ol3/pull/4389.diff","patch_url":"https://github.com/openlayers/ol3/pull/4389.patch","issue_url":"https://api.github.com/repos/openlayers/ol3/issues/4389","number":4389,"state":"open","locked":false,"title":"Smooth transitions on parameter changes","user":{"login":"elemoine","id":76594,"avatar_url":"https://avatars.githubusercontent.com/u/76594?v=3","gravatar_id":"","url":"https://api.github.com/users/elemoine","html_url":"https://github.com/elemoine","followers_url":"https://api.github.com/users/elemoine/followers","following_url":"https://api.github.com/users/elemoine/following{/other_user}","gists_url":"https://api.github.com/users/elemoine/gists{/gist_id}","starred_url":"https://api.github.com/users/elemoine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elemoine/subscriptions","organizations_url":"https://api.github.com/users/elemoine/orgs","repos_url":"https://api.github.com/users/elemoine/repos","events_url":"https://api.github.com/users/elemoine/events{/privacy}","received_events_url":"https://api.github.com/users/elemoine/received_events","type":"User","site_admin":false},"body":"This PR is an alternative to https://github.com/openlayers/ol3/pull/3660 created by @thomasmoelhave. The code includes code and suggestions from @thomasmoelhave.\r\n\r\nThe code is not ready for review yet. I need to review it myself and add unit tests.","created_at":"2015-11-06T16:03:53Z","updated_at":"2015-11-10T16:12:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a4ff19843f252e65e2558c59a6a577b86d4b4ff","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openlayers/ol3/pulls/4389/commits","review_comments_url":"https://api.github.com/repos/openlayers/ol3/pulls/4389/comments","review_comment_url":"https://api.github.com/repos/openlayers/ol3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openlayers/ol3/issues/4389/comments","statuses_url":"https://api.github.com/repos/openlayers/ol3/statuses/1b62cf4e994bb92332b6a32709cfa6045d0fc0c9","head":{"label":"elemoine:dynamic-params","ref":"dynamic-params","sha":"1b62cf4e994bb92332b6a32709cfa6045d0fc0c9","user":{"login":"elemoine","id":76594,"avatar_url":"https://avatars.githubusercontent.com/u/76594?v=3","gravatar_id":"","url":"https://api.github.com/users/elemoine","html_url":"https://github.com/elemoine","followers_url":"https://api.github.com/users/elemoine/followers","following_url":"https://api.github.com/users/elemoine/following{/other_user}","gists_url":"https://api.github.com/users/elemoine/gists{/gist_id}","starred_url":"https://api.github.com/users/elemoine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elemoine/subscriptions","organizations_url":"https://api.github.com/users/elemoine/orgs","repos_url":"https://api.github.com/users/elemoine/repos","events_url":"https://api.github.com/users/elemoine/events{/privacy}","received_events_url":"https://api.github.com/users/elemoine/received_events","type":"User","site_admin":false},"repo":{"id":4775811,"name":"ol3","full_name":"elemoine/ol3","owner":{"login":"elemoine","id":76594,"avatar_url":"https://avatars.githubusercontent.com/u/76594?v=3","gravatar_id":"","url":"https://api.github.com/users/elemoine","html_url":"https://github.com/elemoine","followers_url":"https://api.github.com/users/elemoine/followers","following_url":"https://api.github.com/users/elemoine/following{/other_user}","gists_url":"https://api.github.com/users/elemoine/gists{/gist_id}","starred_url":"https://api.github.com/users/elemoine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elemoine/subscriptions","organizations_url":"https://api.github.com/users/elemoine/orgs","repos_url":"https://api.github.com/users/elemoine/repos","events_url":"https://api.github.com/users/elemoine/events{/privacy}","received_events_url":"https://api.github.com/users/elemoine/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/elemoine/ol3","description":"OpenLayers 3","fork":true,"url":"https://api.github.com/repos/elemoine/ol3","forks_url":"https://api.github.com/repos/elemoine/ol3/forks","keys_url":"https://api.github.com/repos/elemoine/ol3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elemoine/ol3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elemoine/ol3/teams","hooks_url":"https://api.github.com/repos/elemoine/ol3/hooks","issue_events_url":"https://api.github.com/repos/elemoine/ol3/issues/events{/number}","events_url":"https://api.github.com/repos/elemoine/ol3/events","assignees_url":"https://api.github.com/repos/elemoine/ol3/assignees{/user}","branches_url":"https://api.github.com/repos/elemoine/ol3/branches{/branch}","tags_url":"https://api.github.com/repos/elemoine/ol3/tags","blobs_url":"https://api.github.com/repos/elemoine/ol3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elemoine/ol3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elemoine/ol3/git/refs{/sha}","trees_url":"https://api.github.com/repos/elemoine/ol3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elemoine/ol3/statuses/{sha}","languages_url":"https://api.github.com/repos/elemoine/ol3/languages","stargazers_url":"https://api.github.com/repos/elemoine/ol3/stargazers","contributors_url":"https://api.github.com/repos/elemoine/ol3/contributors","subscribers_url":"https://api.github.com/repos/elemoine/ol3/subscribers","subscription_url":"https://api.github.com/repos/elemoine/ol3/subscription","commits_url":"https://api.github.com/repos/elemoine/ol3/commits{/sha}","git_commits_url":"https://api.github.com/repos/elemoine/ol3/git/commits{/sha}","comments_url":"https://api.github.com/repos/elemoine/ol3/comments{/number}","issue_comment_url":"https://api.github.com/repos/elemoine/ol3/issues/comments{/number}","contents_url":"https://api.github.com/repos/elemoine/ol3/contents/{+path}","compare_url":"https://api.github.com/repos/elemoine/ol3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elemoine/ol3/merges","archive_url":"https://api.github.com/repos/elemoine/ol3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elemoine/ol3/downloads","issues_url":"https://api.github.com/repos/elemoine/ol3/issues{/number}","pulls_url":"https://api.github.com/repos/elemoine/ol3/pulls{/number}","milestones_url":"https://api.github.com/repos/elemoine/ol3/milestones{/number}","notifications_url":"https://api.github.com/repos/elemoine/ol3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elemoine/ol3/labels{/name}","releases_url":"https://api.github.com/repos/elemoine/ol3/releases{/id}","created_at":"2012-06-24T22:15:17Z","updated_at":"2015-02-02T15:49:28Z","pushed_at":"2015-11-09T16:03:29Z","git_url":"git://github.com/elemoine/ol3.git","ssh_url":"git@github.com:elemoine/ol3.git","clone_url":"https://github.com/elemoine/ol3.git","svn_url":"https://github.com/elemoine/ol3","homepage":null,"size":53421,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openlayers:master","ref":"master","sha":"bfbb802b85d5855b5f5f7255a39af1d723a6a286","user":{"login":"openlayers","id":240579,"avatar_url":"https://avatars.githubusercontent.com/u/240579?v=3","gravatar_id":"","url":"https://api.github.com/users/openlayers","html_url":"https://github.com/openlayers","followers_url":"https://api.github.com/users/openlayers/followers","following_url":"https://api.github.com/users/openlayers/following{/other_user}","gists_url":"https://api.github.com/users/openlayers/gists{/gist_id}","starred_url":"https://api.github.com/users/openlayers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openlayers/subscriptions","organizations_url":"https://api.github.com/users/openlayers/orgs","repos_url":"https://api.github.com/users/openlayers/repos","events_url":"https://api.github.com/users/openlayers/events{/privacy}","received_events_url":"https://api.github.com/users/openlayers/received_events","type":"Organization","site_admin":false},"repo":{"id":4723248,"name":"ol3","full_name":"openlayers/ol3","owner":{"login":"openlayers","id":240579,"avatar_url":"https://avatars.githubusercontent.com/u/240579?v=3","gravatar_id":"","url":"https://api.github.com/users/openlayers","html_url":"https://github.com/openlayers","followers_url":"https://api.github.com/users/openlayers/followers","following_url":"https://api.github.com/users/openlayers/following{/other_user}","gists_url":"https://api.github.com/users/openlayers/gists{/gist_id}","starred_url":"https://api.github.com/users/openlayers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openlayers/subscriptions","organizations_url":"https://api.github.com/users/openlayers/orgs","repos_url":"https://api.github.com/users/openlayers/repos","events_url":"https://api.github.com/users/openlayers/events{/privacy}","received_events_url":"https://api.github.com/users/openlayers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openlayers/ol3","description":"OpenLayers 3","fork":false,"url":"https://api.github.com/repos/openlayers/ol3","forks_url":"https://api.github.com/repos/openlayers/ol3/forks","keys_url":"https://api.github.com/repos/openlayers/ol3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openlayers/ol3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openlayers/ol3/teams","hooks_url":"https://api.github.com/repos/openlayers/ol3/hooks","issue_events_url":"https://api.github.com/repos/openlayers/ol3/issues/events{/number}","events_url":"https://api.github.com/repos/openlayers/ol3/events","assignees_url":"https://api.github.com/repos/openlayers/ol3/assignees{/user}","branches_url":"https://api.github.com/repos/openlayers/ol3/branches{/branch}","tags_url":"https://api.github.com/repos/openlayers/ol3/tags","blobs_url":"https://api.github.com/repos/openlayers/ol3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openlayers/ol3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openlayers/ol3/git/refs{/sha}","trees_url":"https://api.github.com/repos/openlayers/ol3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openlayers/ol3/statuses/{sha}","languages_url":"https://api.github.com/repos/openlayers/ol3/languages","stargazers_url":"https://api.github.com/repos/openlayers/ol3/stargazers","contributors_url":"https://api.github.com/repos/openlayers/ol3/contributors","subscribers_url":"https://api.github.com/repos/openlayers/ol3/subscribers","subscription_url":"https://api.github.com/repos/openlayers/ol3/subscription","commits_url":"https://api.github.com/repos/openlayers/ol3/commits{/sha}","git_commits_url":"https://api.github.com/repos/openlayers/ol3/git/commits{/sha}","comments_url":"https://api.github.com/repos/openlayers/ol3/comments{/number}","issue_comment_url":"https://api.github.com/repos/openlayers/ol3/issues/comments{/number}","contents_url":"https://api.github.com/repos/openlayers/ol3/contents/{+path}","compare_url":"https://api.github.com/repos/openlayers/ol3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openlayers/ol3/merges","archive_url":"https://api.github.com/repos/openlayers/ol3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openlayers/ol3/downloads","issues_url":"https://api.github.com/repos/openlayers/ol3/issues{/number}","pulls_url":"https://api.github.com/repos/openlayers/ol3/pulls{/number}","milestones_url":"https://api.github.com/repos/openlayers/ol3/milestones{/number}","notifications_url":"https://api.github.com/repos/openlayers/ol3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openlayers/ol3/labels{/name}","releases_url":"https://api.github.com/repos/openlayers/ol3/releases{/id}","created_at":"2012-06-20T06:53:59Z","updated_at":"2015-11-10T12:24:20Z","pushed_at":"2015-11-10T15:47:58Z","git_url":"git://github.com/openlayers/ol3.git","ssh_url":"git@github.com:openlayers/ol3.git","clone_url":"https://github.com/openlayers/ol3.git","svn_url":"https://github.com/openlayers/ol3","homepage":"http://openlayers.org","size":102469,"stargazers_count":1477,"watchers_count":1477,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":839,"mirror_url":null,"open_issues_count":379,"forks":839,"open_issues":379,"watchers":1477,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openlayers/ol3/pulls/4389"},"html":{"href":"https://github.com/openlayers/ol3/pull/4389"},"issue":{"href":"https://api.github.com/repos/openlayers/ol3/issues/4389"},"comments":{"href":"https://api.github.com/repos/openlayers/ol3/issues/4389/comments"},"review_comments":{"href":"https://api.github.com/repos/openlayers/ol3/pulls/4389/comments"},"review_comment":{"href":"https://api.github.com/repos/openlayers/ol3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openlayers/ol3/pulls/4389/commits"},"statuses":{"href":"https://api.github.com/repos/openlayers/ol3/statuses/1b62cf4e994bb92332b6a32709cfa6045d0fc0c9"}}}}