{"action":"created","issue":{"url":"https://api.github.com/repos/phetsims/chipper/issues/364","labels_url":"https://api.github.com/repos/phetsims/chipper/issues/364/labels{/name}","comments_url":"https://api.github.com/repos/phetsims/chipper/issues/364/comments","events_url":"https://api.github.com/repos/phetsims/chipper/issues/364/events","html_url":"https://github.com/phetsims/chipper/issues/364","id":108063495,"number":364,"title":"[build-server] addToRosetta with changed English sim title","user":{"login":"jonathanolson","id":480878,"avatar_url":"https://avatars.githubusercontent.com/u/480878?v=3","gravatar_id":"","url":"https://api.github.com/users/jonathanolson","html_url":"https://github.com/jonathanolson","followers_url":"https://api.github.com/users/jonathanolson/followers","following_url":"https://api.github.com/users/jonathanolson/following{/other_user}","gists_url":"https://api.github.com/users/jonathanolson/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanolson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanolson/subscriptions","organizations_url":"https://api.github.com/users/jonathanolson/orgs","repos_url":"https://api.github.com/users/jonathanolson/repos","events_url":"https://api.github.com/users/jonathanolson/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanolson/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/phetsims/chipper/labels/review","name":"review","color":"0052cc"}],"state":"open","locked":false,"assignee":{"login":"aaronsamuel137","id":3193912,"avatar_url":"https://avatars.githubusercontent.com/u/3193912?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronsamuel137","html_url":"https://github.com/aaronsamuel137","followers_url":"https://api.github.com/users/aaronsamuel137/followers","following_url":"https://api.github.com/users/aaronsamuel137/following{/other_user}","gists_url":"https://api.github.com/users/aaronsamuel137/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronsamuel137/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronsamuel137/subscriptions","organizations_url":"https://api.github.com/users/aaronsamuel137/orgs","repos_url":"https://api.github.com/users/aaronsamuel137/repos","events_url":"https://api.github.com/users/aaronsamuel137/events{/privacy}","received_events_url":"https://api.github.com/users/aaronsamuel137/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-09-24T05:56:31Z","updated_at":"2015-09-25T17:01:58Z","closed_at":null,"body":"Not sure how much of an issue it would be, but if a published sim has a slight change to its English title, the build-server won't update rosetta's simInfoArray.json (since the entry for the sim already exists).\r\n\r\nIs this worth a fix?\r\n\r\nReview: https://github.com/phetsims/chipper/issues/141"},"comment":{"url":"https://api.github.com/repos/phetsims/chipper/issues/comments/143283848","html_url":"https://github.com/phetsims/chipper/issues/364#issuecomment-143283848","issue_url":"https://api.github.com/repos/phetsims/chipper/issues/364","id":143283848,"user":{"login":"aaronsamuel137","id":3193912,"avatar_url":"https://avatars.githubusercontent.com/u/3193912?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronsamuel137","html_url":"https://github.com/aaronsamuel137","followers_url":"https://api.github.com/users/aaronsamuel137/followers","following_url":"https://api.github.com/users/aaronsamuel137/following{/other_user}","gists_url":"https://api.github.com/users/aaronsamuel137/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronsamuel137/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronsamuel137/subscriptions","organizations_url":"https://api.github.com/users/aaronsamuel137/orgs","repos_url":"https://api.github.com/users/aaronsamuel137/repos","events_url":"https://api.github.com/users/aaronsamuel137/events{/privacy}","received_events_url":"https://api.github.com/users/aaronsamuel137/received_events","type":"User","site_admin":false},"created_at":"2015-09-25T17:01:58Z","updated_at":"2015-09-25T17:01:58Z","body":"I think changes to the English title will actually create updates. Here is the code:\r\n\r\n```js\r\n        var newSim = true;\r\n        for ( var i = 0; i < data.length; i++ ) {\r\n          var simInfoObject = data[ i ];\r\n          if ( simInfoObject.projectName && simInfoObject.projectName === simName ) {\r\n            simInfoObject.simTitle = simTitle;\r\n            simInfoObject.testUrl = testUrl;\r\n            newSim = false;\r\n          }\r\n        }\r\n        if ( newSim ) {\r\n          data.push( {\r\n            simTitle: simTitle,\r\n            projectName: simName,\r\n            testUrl: testUrl\r\n          } );\r\n        }\r\n```\r\n\r\nThe title and url are updated every time if the sim already exists in the array. Does that seem right to you or is there something I am missing here?"}}