{"action":"created","comment":{"url":"https://api.github.com/repos/pydata/pandas/pulls/comments/41087838","id":41087838,"diff_hunk":"@@ -321,11 +320,11 @@ def isnullobj(ndarray[object] arr):\n     cdef ndarray[uint8_t] result\n \n     n = len(arr)\n-    result = np.zeros(n, dtype=np.uint8)\n+    result = np.empty(n, dtype=np.uint8)\n     for i from 0 <= i < n:\n         val = arr[i]\n-        result[i] = val is NaT or _checknull(val)\n-    return result.view(np.bool_)\n+        result[i] = _check_all_nulls(val)\n+    return result.view(dtype=np.bool_)\n ","path":"pandas/lib.pyx","position":31,"original_position":31,"commit_id":"97a5c6afab20987eeb406cab42ad8ef3f438093c","original_commit_id":"97a5c6afab20987eeb406cab42ad8ef3f438093c","user":{"login":"kawochen","id":10709573,"avatar_url":"https://avatars.githubusercontent.com/u/10709573?v=3","gravatar_id":"","url":"https://api.github.com/users/kawochen","html_url":"https://github.com/kawochen","followers_url":"https://api.github.com/users/kawochen/followers","following_url":"https://api.github.com/users/kawochen/following{/other_user}","gists_url":"https://api.github.com/users/kawochen/gists{/gist_id}","starred_url":"https://api.github.com/users/kawochen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kawochen/subscriptions","organizations_url":"https://api.github.com/users/kawochen/orgs","repos_url":"https://api.github.com/users/kawochen/repos","events_url":"https://api.github.com/users/kawochen/events{/privacy}","received_events_url":"https://api.github.com/users/kawochen/received_events","type":"User","site_admin":false},"body":"you mean the `_check_all_nulls`?  Only object arrays hit this path so I thought it'd be safe to have the most generic version of `checknull` here?\r\n\r\nFor the `dtype` thing, I forgot to remove it after some experiment, but will remove it in the next update. ","created_at":"2015-10-03T14:57:54Z","updated_at":"2015-10-03T14:57:54Z","html_url":"https://github.com/pydata/pandas/pull/11212#discussion_r41087838","pull_request_url":"https://api.github.com/repos/pydata/pandas/pulls/11212","_links":{"self":{"href":"https://api.github.com/repos/pydata/pandas/pulls/comments/41087838"},"html":{"href":"https://github.com/pydata/pandas/pull/11212#discussion_r41087838"},"pull_request":{"href":"https://api.github.com/repos/pydata/pandas/pulls/11212"}}},"pull_request":{"url":"https://api.github.com/repos/pydata/pandas/pulls/11212","id":46469630,"html_url":"https://github.com/pydata/pandas/pull/11212","diff_url":"https://github.com/pydata/pandas/pull/11212.diff","patch_url":"https://github.com/pydata/pandas/pull/11212.patch","issue_url":"https://api.github.com/repos/pydata/pandas/issues/11212","number":11212,"state":"open","locked":false,"title":"BUG: GH11206 where pd.isnull did not consider numpy NaT null","user":{"login":"kawochen","id":10709573,"avatar_url":"https://avatars.githubusercontent.com/u/10709573?v=3","gravatar_id":"","url":"https://api.github.com/users/kawochen","html_url":"https://github.com/kawochen","followers_url":"https://api.github.com/users/kawochen/followers","following_url":"https://api.github.com/users/kawochen/following{/other_user}","gists_url":"https://api.github.com/users/kawochen/gists{/gist_id}","starred_url":"https://api.github.com/users/kawochen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kawochen/subscriptions","organizations_url":"https://api.github.com/users/kawochen/orgs","repos_url":"https://api.github.com/users/kawochen/repos","events_url":"https://api.github.com/users/kawochen/events{/privacy}","received_events_url":"https://api.github.com/users/kawochen/received_events","type":"User","site_admin":false},"body":"closes #11206","created_at":"2015-09-30T23:23:51Z","updated_at":"2015-10-03T14:57:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1282683f19f78eddf887cf813fdbe17a16b71f7e","assignee":null,"milestone":{"url":"https://api.github.com/repos/pydata/pandas/milestones/37","html_url":"https://github.com/pydata/pandas/milestones/0.17.1","labels_url":"https://api.github.com/repos/pydata/pandas/milestones/37/labels","id":1299459,"number":37,"title":"0.17.1","description":"after 0.17.0 of course!","creator":{"login":"jreback","id":953992,"avatar_url":"https://avatars.githubusercontent.com/u/953992?v=3","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"open_issues":28,"closed_issues":0,"state":"open","created_at":"2015-09-10T14:30:44Z","updated_at":"2015-10-02T22:03:20Z","due_on":"2015-11-14T05:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/pydata/pandas/pulls/11212/commits","review_comments_url":"https://api.github.com/repos/pydata/pandas/pulls/11212/comments","review_comment_url":"https://api.github.com/repos/pydata/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pydata/pandas/issues/11212/comments","statuses_url":"https://api.github.com/repos/pydata/pandas/statuses/97a5c6afab20987eeb406cab42ad8ef3f438093c","head":{"label":"kawochen:BUG-FIX-11206","ref":"BUG-FIX-11206","sha":"97a5c6afab20987eeb406cab42ad8ef3f438093c","user":{"login":"kawochen","id":10709573,"avatar_url":"https://avatars.githubusercontent.com/u/10709573?v=3","gravatar_id":"","url":"https://api.github.com/users/kawochen","html_url":"https://github.com/kawochen","followers_url":"https://api.github.com/users/kawochen/followers","following_url":"https://api.github.com/users/kawochen/following{/other_user}","gists_url":"https://api.github.com/users/kawochen/gists{/gist_id}","starred_url":"https://api.github.com/users/kawochen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kawochen/subscriptions","organizations_url":"https://api.github.com/users/kawochen/orgs","repos_url":"https://api.github.com/users/kawochen/repos","events_url":"https://api.github.com/users/kawochen/events{/privacy}","received_events_url":"https://api.github.com/users/kawochen/received_events","type":"User","site_admin":false},"repo":{"id":36695544,"name":"pandas","full_name":"kawochen/pandas","owner":{"login":"kawochen","id":10709573,"avatar_url":"https://avatars.githubusercontent.com/u/10709573?v=3","gravatar_id":"","url":"https://api.github.com/users/kawochen","html_url":"https://github.com/kawochen","followers_url":"https://api.github.com/users/kawochen/followers","following_url":"https://api.github.com/users/kawochen/following{/other_user}","gists_url":"https://api.github.com/users/kawochen/gists{/gist_id}","starred_url":"https://api.github.com/users/kawochen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kawochen/subscriptions","organizations_url":"https://api.github.com/users/kawochen/orgs","repos_url":"https://api.github.com/users/kawochen/repos","events_url":"https://api.github.com/users/kawochen/events{/privacy}","received_events_url":"https://api.github.com/users/kawochen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kawochen/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/kawochen/pandas","forks_url":"https://api.github.com/repos/kawochen/pandas/forks","keys_url":"https://api.github.com/repos/kawochen/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kawochen/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kawochen/pandas/teams","hooks_url":"https://api.github.com/repos/kawochen/pandas/hooks","issue_events_url":"https://api.github.com/repos/kawochen/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/kawochen/pandas/events","assignees_url":"https://api.github.com/repos/kawochen/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/kawochen/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/kawochen/pandas/tags","blobs_url":"https://api.github.com/repos/kawochen/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kawochen/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kawochen/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/kawochen/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kawochen/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/kawochen/pandas/languages","stargazers_url":"https://api.github.com/repos/kawochen/pandas/stargazers","contributors_url":"https://api.github.com/repos/kawochen/pandas/contributors","subscribers_url":"https://api.github.com/repos/kawochen/pandas/subscribers","subscription_url":"https://api.github.com/repos/kawochen/pandas/subscription","commits_url":"https://api.github.com/repos/kawochen/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/kawochen/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/kawochen/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/kawochen/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/kawochen/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/kawochen/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kawochen/pandas/merges","archive_url":"https://api.github.com/repos/kawochen/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kawochen/pandas/downloads","issues_url":"https://api.github.com/repos/kawochen/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/kawochen/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/kawochen/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/kawochen/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kawochen/pandas/labels{/name}","releases_url":"https://api.github.com/repos/kawochen/pandas/releases{/id}","created_at":"2015-06-01T23:39:36Z","updated_at":"2015-06-08T14:16:34Z","pushed_at":"2015-10-03T04:01:57Z","git_url":"git://github.com/kawochen/pandas.git","ssh_url":"git@github.com:kawochen/pandas.git","clone_url":"https://github.com/kawochen/pandas.git","svn_url":"https://github.com/kawochen/pandas","homepage":"http://pandas.pydata.org","size":65169,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"pydata:master","ref":"master","sha":"1b421e743d9304af74fb4f375dbb0b96e67524e9","user":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?v=3","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"name":"pandas","full_name":"pydata/pandas","owner":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?v=3","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pydata/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pydata/pandas","forks_url":"https://api.github.com/repos/pydata/pandas/forks","keys_url":"https://api.github.com/repos/pydata/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pydata/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pydata/pandas/teams","hooks_url":"https://api.github.com/repos/pydata/pandas/hooks","issue_events_url":"https://api.github.com/repos/pydata/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pydata/pandas/events","assignees_url":"https://api.github.com/repos/pydata/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pydata/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pydata/pandas/tags","blobs_url":"https://api.github.com/repos/pydata/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pydata/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pydata/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pydata/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pydata/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pydata/pandas/languages","stargazers_url":"https://api.github.com/repos/pydata/pandas/stargazers","contributors_url":"https://api.github.com/repos/pydata/pandas/contributors","subscribers_url":"https://api.github.com/repos/pydata/pandas/subscribers","subscription_url":"https://api.github.com/repos/pydata/pandas/subscription","commits_url":"https://api.github.com/repos/pydata/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pydata/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pydata/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pydata/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pydata/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pydata/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pydata/pandas/merges","archive_url":"https://api.github.com/repos/pydata/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pydata/pandas/downloads","issues_url":"https://api.github.com/repos/pydata/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pydata/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pydata/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pydata/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pydata/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pydata/pandas/releases{/id}","created_at":"2010-08-24T01:37:33Z","updated_at":"2015-10-03T04:56:19Z","pushed_at":"2015-10-03T14:56:20Z","git_url":"git://github.com/pydata/pandas.git","ssh_url":"git@github.com:pydata/pandas.git","clone_url":"https://github.com/pydata/pandas.git","svn_url":"https://github.com/pydata/pandas","homepage":"http://pandas.pydata.org","size":161081,"stargazers_count":5039,"watchers_count":5039,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1954,"mirror_url":null,"open_issues_count":1490,"forks":1954,"open_issues":1490,"watchers":5039,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pydata/pandas/pulls/11212"},"html":{"href":"https://github.com/pydata/pandas/pull/11212"},"issue":{"href":"https://api.github.com/repos/pydata/pandas/issues/11212"},"comments":{"href":"https://api.github.com/repos/pydata/pandas/issues/11212/comments"},"review_comments":{"href":"https://api.github.com/repos/pydata/pandas/pulls/11212/comments"},"review_comment":{"href":"https://api.github.com/repos/pydata/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pydata/pandas/pulls/11212/commits"},"statuses":{"href":"https://api.github.com/repos/pydata/pandas/statuses/97a5c6afab20987eeb406cab42ad8ef3f438093c"}}}}