{"action":"created","issue":{"url":"https://api.github.com/repos/holidayextras/generator-ui-component/issues/6","labels_url":"https://api.github.com/repos/holidayextras/generator-ui-component/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/holidayextras/generator-ui-component/issues/6/comments","events_url":"https://api.github.com/repos/holidayextras/generator-ui-component/issues/6/events","html_url":"https://github.com/holidayextras/generator-ui-component/pull/6","id":67140646,"number":6,"title":"UXUI-195 add reactify to browserify.transform field","user":{"login":"jackdcrawford","id":1485654,"avatar_url":"https://avatars.githubusercontent.com/u/1485654?v=3","gravatar_id":"","url":"https://api.github.com/users/jackdcrawford","html_url":"https://github.com/jackdcrawford","followers_url":"https://api.github.com/users/jackdcrawford/followers","following_url":"https://api.github.com/users/jackdcrawford/following{/other_user}","gists_url":"https://api.github.com/users/jackdcrawford/gists{/gist_id}","starred_url":"https://api.github.com/users/jackdcrawford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackdcrawford/subscriptions","organizations_url":"https://api.github.com/users/jackdcrawford/orgs","repos_url":"https://api.github.com/users/jackdcrawford/repos","events_url":"https://api.github.com/users/jackdcrawford/events{/privacy}","received_events_url":"https://api.github.com/users/jackdcrawford/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-04-08T14:18:35Z","updated_at":"2015-04-09T07:20:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/holidayextras/generator-ui-component/pulls/6","html_url":"https://github.com/holidayextras/generator-ui-component/pull/6","diff_url":"https://github.com/holidayextras/generator-ui-component/pull/6.diff","patch_url":"https://github.com/holidayextras/generator-ui-component/pull/6.patch"},"body":"#### What does this PR do?\r\nAdds `reactify` as a [browserify.transform](https://github.com/substack/browserify-handbook#browserifytransform-field) field so that generated modules are also transformed when included as a dependency (e.g. in the `ui-toolkit`).\r\n\r\n#### What unit or integration tests does this PR have?\r\nN/A\r\n\r\n#### What selenium tests does this PR have?\r\nN/A\r\n\r\n#### How should a developer review this?\r\nCheck the code & then run the manual testing steps below\r\n\r\n#### How should this be manually tested?\r\n1. Switch to this branch\r\n2. `npm install`\r\n3. `npm install -g .` to globally install this generator\r\n4. Create a test directory somewhere on your machine & change to that directory\r\n5. `yo ui-component` & fill out the prompts with `test`\r\n6. Open the generated `package.json`, you should see:\r\n```json\r\n\"browserify\": {\r\n  \"transform\": [\"reactify\"]\r\n},\r\n```\r\n\r\n#### Any background context you want to provide?\r\nThis removes the requirement of globally transforming all dependencies (which has exceeded the ulimit on some machines). \r\n\r\n#### What are the relevant tickets?\r\n[UXUI-195](https://holidayextras.jira.com/browse/UXUI-195)\r\n\r\n#### Screenshots (if appropriate)\r\nN/A\r\n\r\n#### What gif best describes how you feel about this work?\r\n![lulz](http://tclhost.com/Jtbm4Yj.gif)\r\n\r\n---\r\n#### Quality checklist (for PR author to complete BEFORE code review):\r\n- [x] I've checked there is appropriate unit test coverage.\r\n- [x] I've checked there is appropriate selenium test coverage.\r\n- [x] I've included regression tests for any bug fixes.\r\n- [x] I've updated documentation with any changes to procedures.\r\n- [x] I've tested this on mobile Android, Safari, Chrome for any visual changes.\r\n- [x] I've tested this on desktop IE9/10/11, Firefox, Chrome for any visual changes.\r\n- [x] I've checked any significant visual changes with a member of the UX/UI pod.\r\n- [x] I've checked this work against the requirements of the Jira.\r\n- [x] I've added and updated translations for all supported languages\r\n- [x] I've informed those who need to know of any unforeseen impact of this work (database migrations, deployment procedure changes).\r\n- [x] I am ready for this to be code reviewed, merged and tested.\r\n- [x] I've thought about writing a blog post about this\r\n\r\n#### IP or Developer Review:\r\n- [x] I agree with the assumptions made in the quality checklist.\r\n- [x] I’ve witnessed the work behaving as expected.\r\n- [x] I’ve run all the tests locally and they pass.\r\n- [x] +1 from me!\r\n\r\n#### Software Engineer or Developer review:\r\n- [ ] I agree with the assumptions made in the quality checklist.\r\n- [ ] I’ve witnessed the work behaving as expected.\r\n- [ ] I’ve run all the tests locally and they pass.\r\n- [ ] I’ve checked for appropriate test coverage.\r\n- [ ] I’ve checked for coding anti-patterns.\r\n- [ ] I've checked this work against the requirements of the Jira.\r\n- [ ] +1 from me!\r\n\r\n#### Software Engineer or project guru review:\r\n- [x] I agree with the assumptions made in the quality checklist.\r\n- [x] I’ve witnessed the work behaving as expected.\r\n- [x] I’ve run all the tests locally and they pass.\r\n- [x] I’ve checked for appropriate test coverage.\r\n- [x] I’ve checked for coding anti-patterns.\r\n- [x] I don’t believe this work introduces unnecessary technical debt.\r\n- [x] +1 from me!"},"comment":{"url":"https://api.github.com/repos/holidayextras/generator-ui-component/issues/comments/91134122","html_url":"https://github.com/holidayextras/generator-ui-component/pull/6#issuecomment-91134122","issue_url":"https://api.github.com/repos/holidayextras/generator-ui-component/issues/6","id":91134122,"user":{"login":"michaelcarter","id":1911741,"avatar_url":"https://avatars.githubusercontent.com/u/1911741?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelcarter","html_url":"https://github.com/michaelcarter","followers_url":"https://api.github.com/users/michaelcarter/followers","following_url":"https://api.github.com/users/michaelcarter/following{/other_user}","gists_url":"https://api.github.com/users/michaelcarter/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelcarter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelcarter/subscriptions","organizations_url":"https://api.github.com/users/michaelcarter/orgs","repos_url":"https://api.github.com/users/michaelcarter/repos","events_url":"https://api.github.com/users/michaelcarter/events{/privacy}","received_events_url":"https://api.github.com/users/michaelcarter/received_events","type":"User","site_admin":false},"created_at":"2015-04-09T07:20:41Z","updated_at":"2015-04-09T07:20:41Z","body":"Taking SE/Dev"}}