{"action":"created","comment":{"url":"https://api.github.com/repos/jupyter/notebook/pulls/comments/43055974","id":43055974,"diff_hunk":"@@ -193,20 +193,35 @@ define(function(require){\n                 env.notebook.extend_marked(1);\n             }\n         },\n-        'cut-cell' : {\n+        'cut-selected-cell' : {\n             icon: 'fa-cut',\n             help_index : 'ee',\n             handler : function (env) {\n                 var index = env.notebook.get_selected_index();\n-                env.notebook.cut_cell();\n+                env.notebook.cut_selected_cell();\n                 env.notebook.select(index);\n             }\n         },\n-        'copy-cell' : {\n+        'cut-marked-cell' : {","path":"notebook/static/notebook/js/actions.js","position":16,"original_position":16,"commit_id":"602a5f9f174b08e2d3fc3fffc86333e66d6ea3b0","original_commit_id":"602a5f9f174b08e2d3fc3fffc86333e66d6ea3b0","user":{"login":"jdfreder","id":3292874,"avatar_url":"https://avatars.githubusercontent.com/u/3292874?v=3","gravatar_id":"","url":"https://api.github.com/users/jdfreder","html_url":"https://github.com/jdfreder","followers_url":"https://api.github.com/users/jdfreder/followers","following_url":"https://api.github.com/users/jdfreder/following{/other_user}","gists_url":"https://api.github.com/users/jdfreder/gists{/gist_id}","starred_url":"https://api.github.com/users/jdfreder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdfreder/subscriptions","organizations_url":"https://api.github.com/users/jdfreder/orgs","repos_url":"https://api.github.com/users/jdfreder/repos","events_url":"https://api.github.com/users/jdfreder/events{/privacy}","received_events_url":"https://api.github.com/users/jdfreder/received_events","type":"User","site_admin":false},"body":"When talking about marked, it can be plural, so I'd `cut-marked-cells`","created_at":"2015-10-26T21:29:47Z","updated_at":"2015-10-26T21:29:47Z","html_url":"https://github.com/jupyter/notebook/pull/667#discussion_r43055974","pull_request_url":"https://api.github.com/repos/jupyter/notebook/pulls/667","_links":{"self":{"href":"https://api.github.com/repos/jupyter/notebook/pulls/comments/43055974"},"html":{"href":"https://github.com/jupyter/notebook/pull/667#discussion_r43055974"},"pull_request":{"href":"https://api.github.com/repos/jupyter/notebook/pulls/667"}}},"pull_request":{"url":"https://api.github.com/repos/jupyter/notebook/pulls/667","id":48785307,"html_url":"https://github.com/jupyter/notebook/pull/667","diff_url":"https://github.com/jupyter/notebook/pull/667.diff","patch_url":"https://github.com/jupyter/notebook/pull/667.patch","issue_url":"https://api.github.com/repos/jupyter/notebook/issues/667","number":667,"state":"open","locked":false,"title":"Don't break user keyboard shortcut.","user":{"login":"Carreau","id":335567,"avatar_url":"https://avatars.githubusercontent.com/u/335567?v=3","gravatar_id":"","url":"https://api.github.com/users/Carreau","html_url":"https://github.com/Carreau","followers_url":"https://api.github.com/users/Carreau/followers","following_url":"https://api.github.com/users/Carreau/following{/other_user}","gists_url":"https://api.github.com/users/Carreau/gists{/gist_id}","starred_url":"https://api.github.com/users/Carreau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carreau/subscriptions","organizations_url":"https://api.github.com/users/Carreau/orgs","repos_url":"https://api.github.com/users/Carreau/repos","events_url":"https://api.github.com/users/Carreau/events{/privacy}","received_events_url":"https://api.github.com/users/Carreau/received_events","type":"User","site_admin":false},"body":"Do differentiate copy/cup/delete selected from marked cells.\r\n\r\nBind the keyboard shortcut to the **old** behavior.\r\n\r\nThis does not prevent us from rebinding later, but at least make things\r\nexplicit.\r\n\r\nPing @ellisonbg, @jhamrick , @jdfreder\r\n\r\n\r\nWe cannot in default action sometime act on selected, sometime on marked. \r\nI still think that the marked/selected distinction is wrong, and that default action should at least always act on selection. \r\n\r\n\r\nTodo:\r\n   - [ ] test more\r\n   - [x] check for cut.\r\n   - [x] robustsness of `-marked-` to nothing selected.\r\n   - copy \r\n     - [x] menu\r\n     - [x] shortcut \r\n     - [x] 2 actions\r\n     - [x] backward compatible function alias\r\n     - [x] menubar button\r\n   - cut\r\n     - [x] menu\r\n     - [x] shortcut \r\n     - [x] 2 actions\r\n     - [x] backward compatible function alias \r\n     - [x] menubar button\r\n   - delete\r\n     - [x] menu\r\n     - [x] shortcut\r\n     - [x] 2 actions\r\n     - [x] backward compatible function alias\r\n     - ~~[ ] menubar button~~ not in menubar\r\n\r\n\r\nTo respond to @ellisonbg why shoud copy/delete be different than other action : \r\n\r\nRight now copy/delete (and cut as cut is copy+delete) are the **only** actions that have heuristic to sometime act on selection and sometime act on marked cell. \r\n\r\nSo there are no reason to behave differently, hence they shoudl not have this heuristic. ","created_at":"2015-10-26T19:25:53Z","updated_at":"2015-10-26T21:29:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4595c66056dd1e1071cb797330c676889d1d3bb5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jupyter/notebook/pulls/667/commits","review_comments_url":"https://api.github.com/repos/jupyter/notebook/pulls/667/comments","review_comment_url":"https://api.github.com/repos/jupyter/notebook/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jupyter/notebook/issues/667/comments","statuses_url":"https://api.github.com/repos/jupyter/notebook/statuses/602a5f9f174b08e2d3fc3fffc86333e66d6ea3b0","head":{"label":"Carreau:actions-on-selected","ref":"actions-on-selected","sha":"602a5f9f174b08e2d3fc3fffc86333e66d6ea3b0","user":{"login":"Carreau","id":335567,"avatar_url":"https://avatars.githubusercontent.com/u/335567?v=3","gravatar_id":"","url":"https://api.github.com/users/Carreau","html_url":"https://github.com/Carreau","followers_url":"https://api.github.com/users/Carreau/followers","following_url":"https://api.github.com/users/Carreau/following{/other_user}","gists_url":"https://api.github.com/users/Carreau/gists{/gist_id}","starred_url":"https://api.github.com/users/Carreau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carreau/subscriptions","organizations_url":"https://api.github.com/users/Carreau/orgs","repos_url":"https://api.github.com/users/Carreau/repos","events_url":"https://api.github.com/users/Carreau/events{/privacy}","received_events_url":"https://api.github.com/users/Carreau/received_events","type":"User","site_admin":false},"repo":{"id":33886074,"name":"jupyter_notebook","full_name":"Carreau/jupyter_notebook","owner":{"login":"Carreau","id":335567,"avatar_url":"https://avatars.githubusercontent.com/u/335567?v=3","gravatar_id":"","url":"https://api.github.com/users/Carreau","html_url":"https://github.com/Carreau","followers_url":"https://api.github.com/users/Carreau/followers","following_url":"https://api.github.com/users/Carreau/following{/other_user}","gists_url":"https://api.github.com/users/Carreau/gists{/gist_id}","starred_url":"https://api.github.com/users/Carreau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carreau/subscriptions","organizations_url":"https://api.github.com/users/Carreau/orgs","repos_url":"https://api.github.com/users/Carreau/repos","events_url":"https://api.github.com/users/Carreau/events{/privacy}","received_events_url":"https://api.github.com/users/Carreau/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Carreau/jupyter_notebook","description":"Jupyter Interactive Notebook","fork":true,"url":"https://api.github.com/repos/Carreau/jupyter_notebook","forks_url":"https://api.github.com/repos/Carreau/jupyter_notebook/forks","keys_url":"https://api.github.com/repos/Carreau/jupyter_notebook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Carreau/jupyter_notebook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Carreau/jupyter_notebook/teams","hooks_url":"https://api.github.com/repos/Carreau/jupyter_notebook/hooks","issue_events_url":"https://api.github.com/repos/Carreau/jupyter_notebook/issues/events{/number}","events_url":"https://api.github.com/repos/Carreau/jupyter_notebook/events","assignees_url":"https://api.github.com/repos/Carreau/jupyter_notebook/assignees{/user}","branches_url":"https://api.github.com/repos/Carreau/jupyter_notebook/branches{/branch}","tags_url":"https://api.github.com/repos/Carreau/jupyter_notebook/tags","blobs_url":"https://api.github.com/repos/Carreau/jupyter_notebook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Carreau/jupyter_notebook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Carreau/jupyter_notebook/git/refs{/sha}","trees_url":"https://api.github.com/repos/Carreau/jupyter_notebook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Carreau/jupyter_notebook/statuses/{sha}","languages_url":"https://api.github.com/repos/Carreau/jupyter_notebook/languages","stargazers_url":"https://api.github.com/repos/Carreau/jupyter_notebook/stargazers","contributors_url":"https://api.github.com/repos/Carreau/jupyter_notebook/contributors","subscribers_url":"https://api.github.com/repos/Carreau/jupyter_notebook/subscribers","subscription_url":"https://api.github.com/repos/Carreau/jupyter_notebook/subscription","commits_url":"https://api.github.com/repos/Carreau/jupyter_notebook/commits{/sha}","git_commits_url":"https://api.github.com/repos/Carreau/jupyter_notebook/git/commits{/sha}","comments_url":"https://api.github.com/repos/Carreau/jupyter_notebook/comments{/number}","issue_comment_url":"https://api.github.com/repos/Carreau/jupyter_notebook/issues/comments{/number}","contents_url":"https://api.github.com/repos/Carreau/jupyter_notebook/contents/{+path}","compare_url":"https://api.github.com/repos/Carreau/jupyter_notebook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Carreau/jupyter_notebook/merges","archive_url":"https://api.github.com/repos/Carreau/jupyter_notebook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Carreau/jupyter_notebook/downloads","issues_url":"https://api.github.com/repos/Carreau/jupyter_notebook/issues{/number}","pulls_url":"https://api.github.com/repos/Carreau/jupyter_notebook/pulls{/number}","milestones_url":"https://api.github.com/repos/Carreau/jupyter_notebook/milestones{/number}","notifications_url":"https://api.github.com/repos/Carreau/jupyter_notebook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Carreau/jupyter_notebook/labels{/name}","releases_url":"https://api.github.com/repos/Carreau/jupyter_notebook/releases{/id}","created_at":"2015-04-13T18:29:15Z","updated_at":"2015-04-13T18:29:17Z","pushed_at":"2015-10-26T21:16:43Z","git_url":"git://github.com/Carreau/jupyter_notebook.git","ssh_url":"git@github.com:Carreau/jupyter_notebook.git","clone_url":"https://github.com/Carreau/jupyter_notebook.git","svn_url":"https://github.com/Carreau/jupyter_notebook","homepage":null,"size":17532,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jupyter:master","ref":"master","sha":"553a9ce46f7454b71be3918c4aee8426f0ec66a3","user":{"login":"jupyter","id":7388996,"avatar_url":"https://avatars.githubusercontent.com/u/7388996?v=3","gravatar_id":"","url":"https://api.github.com/users/jupyter","html_url":"https://github.com/jupyter","followers_url":"https://api.github.com/users/jupyter/followers","following_url":"https://api.github.com/users/jupyter/following{/other_user}","gists_url":"https://api.github.com/users/jupyter/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyter/subscriptions","organizations_url":"https://api.github.com/users/jupyter/orgs","repos_url":"https://api.github.com/users/jupyter/repos","events_url":"https://api.github.com/users/jupyter/events{/privacy}","received_events_url":"https://api.github.com/users/jupyter/received_events","type":"Organization","site_admin":false},"repo":{"id":33653601,"name":"notebook","full_name":"jupyter/notebook","owner":{"login":"jupyter","id":7388996,"avatar_url":"https://avatars.githubusercontent.com/u/7388996?v=3","gravatar_id":"","url":"https://api.github.com/users/jupyter","html_url":"https://github.com/jupyter","followers_url":"https://api.github.com/users/jupyter/followers","following_url":"https://api.github.com/users/jupyter/following{/other_user}","gists_url":"https://api.github.com/users/jupyter/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyter/subscriptions","organizations_url":"https://api.github.com/users/jupyter/orgs","repos_url":"https://api.github.com/users/jupyter/repos","events_url":"https://api.github.com/users/jupyter/events{/privacy}","received_events_url":"https://api.github.com/users/jupyter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jupyter/notebook","description":"Jupyter Interactive Notebook","fork":false,"url":"https://api.github.com/repos/jupyter/notebook","forks_url":"https://api.github.com/repos/jupyter/notebook/forks","keys_url":"https://api.github.com/repos/jupyter/notebook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jupyter/notebook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jupyter/notebook/teams","hooks_url":"https://api.github.com/repos/jupyter/notebook/hooks","issue_events_url":"https://api.github.com/repos/jupyter/notebook/issues/events{/number}","events_url":"https://api.github.com/repos/jupyter/notebook/events","assignees_url":"https://api.github.com/repos/jupyter/notebook/assignees{/user}","branches_url":"https://api.github.com/repos/jupyter/notebook/branches{/branch}","tags_url":"https://api.github.com/repos/jupyter/notebook/tags","blobs_url":"https://api.github.com/repos/jupyter/notebook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jupyter/notebook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jupyter/notebook/git/refs{/sha}","trees_url":"https://api.github.com/repos/jupyter/notebook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jupyter/notebook/statuses/{sha}","languages_url":"https://api.github.com/repos/jupyter/notebook/languages","stargazers_url":"https://api.github.com/repos/jupyter/notebook/stargazers","contributors_url":"https://api.github.com/repos/jupyter/notebook/contributors","subscribers_url":"https://api.github.com/repos/jupyter/notebook/subscribers","subscription_url":"https://api.github.com/repos/jupyter/notebook/subscription","commits_url":"https://api.github.com/repos/jupyter/notebook/commits{/sha}","git_commits_url":"https://api.github.com/repos/jupyter/notebook/git/commits{/sha}","comments_url":"https://api.github.com/repos/jupyter/notebook/comments{/number}","issue_comment_url":"https://api.github.com/repos/jupyter/notebook/issues/comments{/number}","contents_url":"https://api.github.com/repos/jupyter/notebook/contents/{+path}","compare_url":"https://api.github.com/repos/jupyter/notebook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jupyter/notebook/merges","archive_url":"https://api.github.com/repos/jupyter/notebook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jupyter/notebook/downloads","issues_url":"https://api.github.com/repos/jupyter/notebook/issues{/number}","pulls_url":"https://api.github.com/repos/jupyter/notebook/pulls{/number}","milestones_url":"https://api.github.com/repos/jupyter/notebook/milestones{/number}","notifications_url":"https://api.github.com/repos/jupyter/notebook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jupyter/notebook/labels{/name}","releases_url":"https://api.github.com/repos/jupyter/notebook/releases{/id}","created_at":"2015-04-09T06:58:03Z","updated_at":"2015-10-26T20:55:55Z","pushed_at":"2015-10-26T21:17:34Z","git_url":"git://github.com/jupyter/notebook.git","ssh_url":"git@github.com:jupyter/notebook.git","clone_url":"https://github.com/jupyter/notebook.git","svn_url":"https://github.com/jupyter/notebook","homepage":"http://jupyter-notebook.readthedocs.org/","size":23428,"stargazers_count":449,"watchers_count":449,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":136,"mirror_url":null,"open_issues_count":127,"forks":136,"open_issues":127,"watchers":449,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jupyter/notebook/pulls/667"},"html":{"href":"https://github.com/jupyter/notebook/pull/667"},"issue":{"href":"https://api.github.com/repos/jupyter/notebook/issues/667"},"comments":{"href":"https://api.github.com/repos/jupyter/notebook/issues/667/comments"},"review_comments":{"href":"https://api.github.com/repos/jupyter/notebook/pulls/667/comments"},"review_comment":{"href":"https://api.github.com/repos/jupyter/notebook/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jupyter/notebook/pulls/667/commits"},"statuses":{"href":"https://api.github.com/repos/jupyter/notebook/statuses/602a5f9f174b08e2d3fc3fffc86333e66d6ea3b0"}}}}