{"action":"created","issue":{"url":"https://api.github.com/repos/luvit/luvit/issues/732","labels_url":"https://api.github.com/repos/luvit/luvit/issues/732/labels{/name}","comments_url":"https://api.github.com/repos/luvit/luvit/issues/732/comments","events_url":"https://api.github.com/repos/luvit/luvit/issues/732/events","html_url":"https://github.com/luvit/luvit/pull/732","id":75128874,"number":732,"title":"Connection upgrade support","user":{"login":"sousoux","id":2202742,"avatar_url":"https://avatars.githubusercontent.com/u/2202742?v=3","gravatar_id":"","url":"https://api.github.com/users/sousoux","html_url":"https://github.com/sousoux","followers_url":"https://api.github.com/users/sousoux/followers","following_url":"https://api.github.com/users/sousoux/following{/other_user}","gists_url":"https://api.github.com/users/sousoux/gists{/gist_id}","starred_url":"https://api.github.com/users/sousoux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sousoux/subscriptions","organizations_url":"https://api.github.com/users/sousoux/orgs","repos_url":"https://api.github.com/users/sousoux/repos","events_url":"https://api.github.com/users/sousoux/events{/privacy}","received_events_url":"https://api.github.com/users/sousoux/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-11T08:00:23Z","updated_at":"2015-05-11T16:05:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/luvit/luvit/pulls/732","html_url":"https://github.com/luvit/luvit/pull/732","diff_url":"https://github.com/luvit/luvit/pull/732.diff","patch_url":"https://github.com/luvit/luvit/pull/732.patch"},"body":"Hi. I added connection upgrade support in http and as a result found a few other little things in ReadableStream and Socket. The only one that I'm not too sure about is the socket resume call to _read(0) which seems absolutely necessary to get things started again but is clearly not correct. Would love a different way of getting the same effect."},"comment":{"url":"https://api.github.com/repos/luvit/luvit/issues/comments/100959889","html_url":"https://github.com/luvit/luvit/pull/732#issuecomment-100959889","issue_url":"https://api.github.com/repos/luvit/luvit/issues/732","id":100959889,"user":{"login":"creationix","id":89353,"avatar_url":"https://avatars.githubusercontent.com/u/89353?v=3","gravatar_id":"","url":"https://api.github.com/users/creationix","html_url":"https://github.com/creationix","followers_url":"https://api.github.com/users/creationix/followers","following_url":"https://api.github.com/users/creationix/following{/other_user}","gists_url":"https://api.github.com/users/creationix/gists{/gist_id}","starred_url":"https://api.github.com/users/creationix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/creationix/subscriptions","organizations_url":"https://api.github.com/users/creationix/orgs","repos_url":"https://api.github.com/users/creationix/repos","events_url":"https://api.github.com/users/creationix/events{/privacy}","received_events_url":"https://api.github.com/users/creationix/received_events","type":"User","site_admin":false},"created_at":"2015-05-11T16:05:27Z","updated_at":"2015-05-11T16:05:27Z","body":"Thanks for working on this.  I never had the motivation to port node's websocket API since I feel it was flawed in design.\r\n\r\nJust out of curiosity, have you seen how I handle websockets in my coroutine based libraries?  Weblit (a web framework) now has websocket support https://github.com/creationix/weblit.  Weblit is structured somewhat like express.js in that different layers of \"middlewares\" handle requests and responses in turn.  The websocket handler is part of this system instead of a separate `upgrade` event like in node.  This means that http auth, cookies, logging, etc all apply to websocket requests the same as all other http requests."}}