{"action":"created","issue":{"url":"https://api.github.com/repos/hazelcast/hazelcast/issues/4430","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/4430/labels{/name}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/4430/comments","events_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/4430/events","html_url":"https://github.com/hazelcast/hazelcast/pull/4430","id":54693842,"number":4430,"title":"Minor Response Packet Handler cleanup","user":{"login":"pveentjer","id":105243,"avatar_url":"https://avatars.githubusercontent.com/u/105243?v=3","gravatar_id":"","url":"https://api.github.com/users/pveentjer","html_url":"https://github.com/pveentjer","followers_url":"https://api.github.com/users/pveentjer/followers","following_url":"https://api.github.com/users/pveentjer/following{/other_user}","gists_url":"https://api.github.com/users/pveentjer/gists{/gist_id}","starred_url":"https://api.github.com/users/pveentjer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pveentjer/subscriptions","organizations_url":"https://api.github.com/users/pveentjer/orgs","repos_url":"https://api.github.com/users/pveentjer/repos","events_url":"https://api.github.com/users/pveentjer/events{/privacy}","received_events_url":"https://api.github.com/users/pveentjer/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/hazelcast/hazelcast/labels/Team%3A+Core","name":"Team: Core","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/55","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/55/labels","id":819785,"number":55,"title":"3.5","description":null,"creator":{"login":"sancar","id":570462,"avatar_url":"https://avatars.githubusercontent.com/u/570462?v=3","gravatar_id":"","url":"https://api.github.com/users/sancar","html_url":"https://github.com/sancar","followers_url":"https://api.github.com/users/sancar/followers","following_url":"https://api.github.com/users/sancar/following{/other_user}","gists_url":"https://api.github.com/users/sancar/gists{/gist_id}","starred_url":"https://api.github.com/users/sancar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sancar/subscriptions","organizations_url":"https://api.github.com/users/sancar/orgs","repos_url":"https://api.github.com/users/sancar/repos","events_url":"https://api.github.com/users/sancar/events{/privacy}","received_events_url":"https://api.github.com/users/sancar/received_events","type":"User","site_admin":false},"open_issues":83,"closed_issues":48,"state":"open","created_at":"2014-10-09T13:04:53Z","updated_at":"2015-01-19T09:42:28Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2015-01-18T11:37:54Z","updated_at":"2015-01-19T11:52:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/4430","html_url":"https://github.com/hazelcast/hazelcast/pull/4430","diff_url":"https://github.com/hazelcast/hazelcast/pull/4430.diff","patch_url":"https://github.com/hazelcast/hazelcast/pull/4430.patch"},"body":"Renamed BacicResponseHandler to BasicPacketResponseHandler to prevent name confusing since we already have ResponseHandler for different purpose.\r\n\r\nBasicOperationScheduler ResponseThread is now explicitly making use of Packet; code was too generic for no reason. The queue was for packets, but there was still an unwanted check done for non packets from that queue."},"comment":{"url":"https://api.github.com/repos/hazelcast/hazelcast/issues/comments/70482004","html_url":"https://github.com/hazelcast/hazelcast/pull/4430#issuecomment-70482004","issue_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/4430","id":70482004,"user":{"login":"sancar","id":570462,"avatar_url":"https://avatars.githubusercontent.com/u/570462?v=3","gravatar_id":"","url":"https://api.github.com/users/sancar","html_url":"https://github.com/sancar","followers_url":"https://api.github.com/users/sancar/followers","following_url":"https://api.github.com/users/sancar/following{/other_user}","gists_url":"https://api.github.com/users/sancar/gists{/gist_id}","starred_url":"https://api.github.com/users/sancar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sancar/subscriptions","organizations_url":"https://api.github.com/users/sancar/orgs","repos_url":"https://api.github.com/users/sancar/repos","events_url":"https://api.github.com/users/sancar/events{/privacy}","received_events_url":"https://api.github.com/users/sancar/received_events","type":"User","site_admin":false},"created_at":"2015-01-19T11:52:09Z","updated_at":"2015-01-19T11:52:09Z","body":"My comments are not related to this pr but rather more general concern.\r\n\r\nThis ResponseThread seems awkward. Its process method is called directly. The thread itself waiting on a workingQueue that nobody putting anything into. It seems that packet deserialization is done in IO thread. Are we ok with these? "}}