{"action":"created","comment":{"url":"https://api.github.com/repos/vert-x3/vertx-jgroups/pulls/comments/41376524","id":41376524,"diff_hunk":"@@ -80,13 +79,16 @@ public DefaultRpcExecutorService(RpcDispatcher dispatcher) {\n     try {\n       NotifyingFuture<RspList<T>> notifyingFuture = this.<T>execute(action, options);\n       notifyingFuture.setListener((future) -> {\n-        try {\n-          RspList<T> rspList = future.get();\n-          T result = futureDone(rspList);\n-          handler.handle(Future.succeededFuture(result));\n-        } catch (Exception e) {\n-          handler.handle(Future.failedFuture(e));\n-        }\n+        vertx.executeBlocking(","path":"src/main/java/io/vertx/java/spi/cluster/impl/jgroups/services/DefaultRpcExecutorService.java","position":36,"original_position":36,"commit_id":"db54ce70d46c89c4c8e5397d59080156480ed66d","original_commit_id":"db54ce70d46c89c4c8e5397d59080156480ed66d","user":{"login":"fmarinelli","id":790571,"avatar_url":"https://avatars.githubusercontent.com/u/790571?v=3","gravatar_id":"","url":"https://api.github.com/users/fmarinelli","html_url":"https://github.com/fmarinelli","followers_url":"https://api.github.com/users/fmarinelli/followers","following_url":"https://api.github.com/users/fmarinelli/following{/other_user}","gists_url":"https://api.github.com/users/fmarinelli/gists{/gist_id}","starred_url":"https://api.github.com/users/fmarinelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmarinelli/subscriptions","organizations_url":"https://api.github.com/users/fmarinelli/orgs","repos_url":"https://api.github.com/users/fmarinelli/repos","events_url":"https://api.github.com/users/fmarinelli/events{/privacy}","received_events_url":"https://api.github.com/users/fmarinelli/received_events","type":"User","site_admin":false},"body":"to execute the callback in vertx threads\n\n> On 07 ott 2015, at 12:04, Tim Fox <notifications@github.com> wrote:\n> \n> In src/main/java/io/vertx/java/spi/cluster/impl/jgroups/services/DefaultRpcExecutorService.java:\n> \n> > @@ -80,13 +79,16 @@ public DefaultRpcExecutorService(RpcDispatcher dispatcher) {\n> >      try {\n> >        NotifyingFuture<RspList<T>> notifyingFuture = this.<T>execute(action, options);\n> >        notifyingFuture.setListener((future) -> {\n> > -        try {\n> > -          RspList<T> rspList = future.get();\n> > -          T result = futureDone(rspList);\n> > -          handler.handle(Future.succeededFuture(result));\n> > -        } catch (Exception e) {\n> > -          handler.handle(Future.failedFuture(e));\n> > -        }\n> > +        vertx.executeBlocking(\n> I don't understand this - isn't the whole point of a future listener that it's not called until the result is ready? So why use executeBlocking for the get()?\n> \n> —\n> Reply to this email directly or view it on GitHub.\n> \n","created_at":"2015-10-07T10:56:05Z","updated_at":"2015-10-07T10:56:05Z","html_url":"https://github.com/vert-x3/vertx-jgroups/pull/16#discussion_r41376524","pull_request_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/vert-x3/vertx-jgroups/pulls/comments/41376524"},"html":{"href":"https://github.com/vert-x3/vertx-jgroups/pull/16#discussion_r41376524"},"pull_request":{"href":"https://api.github.com/repos/vert-x3/vertx-jgroups/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/vert-x3/vertx-jgroups/pulls/16","id":47005708,"html_url":"https://github.com/vert-x3/vertx-jgroups/pull/16","diff_url":"https://github.com/vert-x3/vertx-jgroups/pull/16.diff","patch_url":"https://github.com/vert-x3/vertx-jgroups/pull/16.patch","issue_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/issues/16","number":16,"state":"open","locked":false,"title":"wrapped in vertx thread model","user":{"login":"fmarinelli","id":790571,"avatar_url":"https://avatars.githubusercontent.com/u/790571?v=3","gravatar_id":"","url":"https://api.github.com/users/fmarinelli","html_url":"https://github.com/fmarinelli","followers_url":"https://api.github.com/users/fmarinelli/followers","following_url":"https://api.github.com/users/fmarinelli/following{/other_user}","gists_url":"https://api.github.com/users/fmarinelli/gists{/gist_id}","starred_url":"https://api.github.com/users/fmarinelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmarinelli/subscriptions","organizations_url":"https://api.github.com/users/fmarinelli/orgs","repos_url":"https://api.github.com/users/fmarinelli/repos","events_url":"https://api.github.com/users/fmarinelli/events{/privacy}","received_events_url":"https://api.github.com/users/fmarinelli/received_events","type":"User","site_admin":false},"body":"Now it's possible to execute tests with check threads on","created_at":"2015-10-07T09:40:22Z","updated_at":"2015-10-07T10:56:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e893253f21bc201c2c650439c6085bc19595f2b2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/pulls/16/commits","review_comments_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/pulls/16/comments","review_comment_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/issues/16/comments","statuses_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/statuses/db54ce70d46c89c4c8e5397d59080156480ed66d","head":{"label":"vert-x3:vertx_thread_model","ref":"vertx_thread_model","sha":"db54ce70d46c89c4c8e5397d59080156480ed66d","user":{"login":"vert-x3","id":8124623,"avatar_url":"https://avatars.githubusercontent.com/u/8124623?v=3","gravatar_id":"","url":"https://api.github.com/users/vert-x3","html_url":"https://github.com/vert-x3","followers_url":"https://api.github.com/users/vert-x3/followers","following_url":"https://api.github.com/users/vert-x3/following{/other_user}","gists_url":"https://api.github.com/users/vert-x3/gists{/gist_id}","starred_url":"https://api.github.com/users/vert-x3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vert-x3/subscriptions","organizations_url":"https://api.github.com/users/vert-x3/orgs","repos_url":"https://api.github.com/users/vert-x3/repos","events_url":"https://api.github.com/users/vert-x3/events{/privacy}","received_events_url":"https://api.github.com/users/vert-x3/received_events","type":"Organization","site_admin":false},"repo":{"id":30292189,"name":"vertx-jgroups","full_name":"vert-x3/vertx-jgroups","owner":{"login":"vert-x3","id":8124623,"avatar_url":"https://avatars.githubusercontent.com/u/8124623?v=3","gravatar_id":"","url":"https://api.github.com/users/vert-x3","html_url":"https://github.com/vert-x3","followers_url":"https://api.github.com/users/vert-x3/followers","following_url":"https://api.github.com/users/vert-x3/following{/other_user}","gists_url":"https://api.github.com/users/vert-x3/gists{/gist_id}","starred_url":"https://api.github.com/users/vert-x3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vert-x3/subscriptions","organizations_url":"https://api.github.com/users/vert-x3/orgs","repos_url":"https://api.github.com/users/vert-x3/repos","events_url":"https://api.github.com/users/vert-x3/events{/privacy}","received_events_url":"https://api.github.com/users/vert-x3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vert-x3/vertx-jgroups","description":"JGroups based cluster manager implementation","fork":false,"url":"https://api.github.com/repos/vert-x3/vertx-jgroups","forks_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/forks","keys_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/teams","hooks_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/hooks","issue_events_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/issues/events{/number}","events_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/events","assignees_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/assignees{/user}","branches_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/branches{/branch}","tags_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/tags","blobs_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/git/refs{/sha}","trees_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/statuses/{sha}","languages_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/languages","stargazers_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/stargazers","contributors_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/contributors","subscribers_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/subscribers","subscription_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/subscription","commits_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/commits{/sha}","git_commits_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/git/commits{/sha}","comments_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/comments{/number}","issue_comment_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/issues/comments{/number}","contents_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/contents/{+path}","compare_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/merges","archive_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/downloads","issues_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/issues{/number}","pulls_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/pulls{/number}","milestones_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/milestones{/number}","notifications_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/labels{/name}","releases_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/releases{/id}","created_at":"2015-02-04T09:53:10Z","updated_at":"2015-05-01T15:29:10Z","pushed_at":"2015-10-07T09:40:22Z","git_url":"git://github.com/vert-x3/vertx-jgroups.git","ssh_url":"git@github.com:vert-x3/vertx-jgroups.git","clone_url":"https://github.com/vert-x3/vertx-jgroups.git","svn_url":"https://github.com/vert-x3/vertx-jgroups","homepage":null,"size":561,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"vert-x3:master","ref":"master","sha":"7a6db0555c4a780ede399911387c728b06355794","user":{"login":"vert-x3","id":8124623,"avatar_url":"https://avatars.githubusercontent.com/u/8124623?v=3","gravatar_id":"","url":"https://api.github.com/users/vert-x3","html_url":"https://github.com/vert-x3","followers_url":"https://api.github.com/users/vert-x3/followers","following_url":"https://api.github.com/users/vert-x3/following{/other_user}","gists_url":"https://api.github.com/users/vert-x3/gists{/gist_id}","starred_url":"https://api.github.com/users/vert-x3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vert-x3/subscriptions","organizations_url":"https://api.github.com/users/vert-x3/orgs","repos_url":"https://api.github.com/users/vert-x3/repos","events_url":"https://api.github.com/users/vert-x3/events{/privacy}","received_events_url":"https://api.github.com/users/vert-x3/received_events","type":"Organization","site_admin":false},"repo":{"id":30292189,"name":"vertx-jgroups","full_name":"vert-x3/vertx-jgroups","owner":{"login":"vert-x3","id":8124623,"avatar_url":"https://avatars.githubusercontent.com/u/8124623?v=3","gravatar_id":"","url":"https://api.github.com/users/vert-x3","html_url":"https://github.com/vert-x3","followers_url":"https://api.github.com/users/vert-x3/followers","following_url":"https://api.github.com/users/vert-x3/following{/other_user}","gists_url":"https://api.github.com/users/vert-x3/gists{/gist_id}","starred_url":"https://api.github.com/users/vert-x3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vert-x3/subscriptions","organizations_url":"https://api.github.com/users/vert-x3/orgs","repos_url":"https://api.github.com/users/vert-x3/repos","events_url":"https://api.github.com/users/vert-x3/events{/privacy}","received_events_url":"https://api.github.com/users/vert-x3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vert-x3/vertx-jgroups","description":"JGroups based cluster manager implementation","fork":false,"url":"https://api.github.com/repos/vert-x3/vertx-jgroups","forks_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/forks","keys_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/teams","hooks_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/hooks","issue_events_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/issues/events{/number}","events_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/events","assignees_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/assignees{/user}","branches_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/branches{/branch}","tags_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/tags","blobs_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/git/refs{/sha}","trees_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/statuses/{sha}","languages_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/languages","stargazers_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/stargazers","contributors_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/contributors","subscribers_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/subscribers","subscription_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/subscription","commits_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/commits{/sha}","git_commits_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/git/commits{/sha}","comments_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/comments{/number}","issue_comment_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/issues/comments{/number}","contents_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/contents/{+path}","compare_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/merges","archive_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/downloads","issues_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/issues{/number}","pulls_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/pulls{/number}","milestones_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/milestones{/number}","notifications_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/labels{/name}","releases_url":"https://api.github.com/repos/vert-x3/vertx-jgroups/releases{/id}","created_at":"2015-02-04T09:53:10Z","updated_at":"2015-05-01T15:29:10Z","pushed_at":"2015-10-07T09:40:22Z","git_url":"git://github.com/vert-x3/vertx-jgroups.git","ssh_url":"git@github.com:vert-x3/vertx-jgroups.git","clone_url":"https://github.com/vert-x3/vertx-jgroups.git","svn_url":"https://github.com/vert-x3/vertx-jgroups","homepage":null,"size":561,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vert-x3/vertx-jgroups/pulls/16"},"html":{"href":"https://github.com/vert-x3/vertx-jgroups/pull/16"},"issue":{"href":"https://api.github.com/repos/vert-x3/vertx-jgroups/issues/16"},"comments":{"href":"https://api.github.com/repos/vert-x3/vertx-jgroups/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/vert-x3/vertx-jgroups/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/vert-x3/vertx-jgroups/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vert-x3/vertx-jgroups/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/vert-x3/vertx-jgroups/statuses/db54ce70d46c89c4c8e5397d59080156480ed66d"}}}}