{"action":"closed","number":5279,"pull_request":{"url":"https://api.github.com/repos/numpy/numpy/pulls/5279","id":24417714,"html_url":"https://github.com/numpy/numpy/pull/5279","diff_url":"https://github.com/numpy/numpy/pull/5279.diff","patch_url":"https://github.com/numpy/numpy/pull/5279.patch","issue_url":"https://api.github.com/repos/numpy/numpy/issues/5279","number":5279,"state":"closed","locked":false,"title":"BUG: astype is broken for structured arrays with different byte orders","user":{"login":"dranjan","id":404832,"avatar_url":"https://avatars.githubusercontent.com/u/404832?v=3","gravatar_id":"","url":"https://api.github.com/users/dranjan","html_url":"https://github.com/dranjan","followers_url":"https://api.github.com/users/dranjan/followers","following_url":"https://api.github.com/users/dranjan/following{/other_user}","gists_url":"https://api.github.com/users/dranjan/gists{/gist_id}","starred_url":"https://api.github.com/users/dranjan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dranjan/subscriptions","organizations_url":"https://api.github.com/users/dranjan/orgs","repos_url":"https://api.github.com/users/dranjan/repos","events_url":"https://api.github.com/users/dranjan/events{/privacy}","received_events_url":"https://api.github.com/users/dranjan/received_events","type":"User","site_admin":false},"body":"The offending commit is c53b0e4, which introduced two regressions:\r\n- using `astype` to cast a structured array to one with a different byte order no longer works;\r\n- comparing structured-array dtypes can give incorrect results if the two dtypes have different byte orders.\r\n\r\nThis pull request should fix both.\r\n\r\nOne thing I wasn't sure about is reordering struct fields.  In my implementation, the `equiv`, `same_kind`, and `safe` rules are now allowed to reorder fields.  If that isn't desired, though, it's a pretty easy change.","created_at":"2014-11-14T02:47:29Z","updated_at":"2015-01-22T18:28:15Z","closed_at":"2015-01-22T18:28:15Z","merged_at":null,"merge_commit_sha":"7f7f114cd80f6bf0dd82d4d8d394bcf26aeaf1f4","assignee":null,"milestone":{"url":"https://api.github.com/repos/numpy/numpy/milestones/33","labels_url":"https://api.github.com/repos/numpy/numpy/milestones/33/labels","id":884170,"number":33,"title":"1.9.2","description":"","creator":{"login":"cournape","id":25111,"avatar_url":"https://avatars.githubusercontent.com/u/25111?v=3","gravatar_id":"","url":"https://api.github.com/users/cournape","html_url":"https://github.com/cournape","followers_url":"https://api.github.com/users/cournape/followers","following_url":"https://api.github.com/users/cournape/following{/other_user}","gists_url":"https://api.github.com/users/cournape/gists{/gist_id}","starred_url":"https://api.github.com/users/cournape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cournape/subscriptions","organizations_url":"https://api.github.com/users/cournape/orgs","repos_url":"https://api.github.com/users/cournape/repos","events_url":"https://api.github.com/users/cournape/events{/privacy}","received_events_url":"https://api.github.com/users/cournape/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":3,"state":"open","created_at":"2014-11-29T10:27:56Z","updated_at":"2015-01-22T18:28:15Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/numpy/numpy/pulls/5279/commits","review_comments_url":"https://api.github.com/repos/numpy/numpy/pulls/5279/comments","review_comment_url":"https://api.github.com/repos/numpy/numpy/pulls/comments/{number}","comments_url":"https://api.github.com/repos/numpy/numpy/issues/5279/comments","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/31e16bb6f97ae49a70b16ca9399a13999edd6c4b","head":{"label":"dranjan:bugfix-structured-byteswap","ref":"bugfix-structured-byteswap","sha":"31e16bb6f97ae49a70b16ca9399a13999edd6c4b","user":{"login":"dranjan","id":404832,"avatar_url":"https://avatars.githubusercontent.com/u/404832?v=3","gravatar_id":"","url":"https://api.github.com/users/dranjan","html_url":"https://github.com/dranjan","followers_url":"https://api.github.com/users/dranjan/followers","following_url":"https://api.github.com/users/dranjan/following{/other_user}","gists_url":"https://api.github.com/users/dranjan/gists{/gist_id}","starred_url":"https://api.github.com/users/dranjan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dranjan/subscriptions","organizations_url":"https://api.github.com/users/dranjan/orgs","repos_url":"https://api.github.com/users/dranjan/repos","events_url":"https://api.github.com/users/dranjan/events{/privacy}","received_events_url":"https://api.github.com/users/dranjan/received_events","type":"User","site_admin":false},"repo":{"id":26618547,"name":"numpy","full_name":"dranjan/numpy","owner":{"login":"dranjan","id":404832,"avatar_url":"https://avatars.githubusercontent.com/u/404832?v=3","gravatar_id":"","url":"https://api.github.com/users/dranjan","html_url":"https://github.com/dranjan","followers_url":"https://api.github.com/users/dranjan/followers","following_url":"https://api.github.com/users/dranjan/following{/other_user}","gists_url":"https://api.github.com/users/dranjan/gists{/gist_id}","starred_url":"https://api.github.com/users/dranjan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dranjan/subscriptions","organizations_url":"https://api.github.com/users/dranjan/orgs","repos_url":"https://api.github.com/users/dranjan/repos","events_url":"https://api.github.com/users/dranjan/events{/privacy}","received_events_url":"https://api.github.com/users/dranjan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dranjan/numpy","description":"Numpy main repository","fork":true,"url":"https://api.github.com/repos/dranjan/numpy","forks_url":"https://api.github.com/repos/dranjan/numpy/forks","keys_url":"https://api.github.com/repos/dranjan/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dranjan/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dranjan/numpy/teams","hooks_url":"https://api.github.com/repos/dranjan/numpy/hooks","issue_events_url":"https://api.github.com/repos/dranjan/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/dranjan/numpy/events","assignees_url":"https://api.github.com/repos/dranjan/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/dranjan/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/dranjan/numpy/tags","blobs_url":"https://api.github.com/repos/dranjan/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dranjan/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dranjan/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/dranjan/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dranjan/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/dranjan/numpy/languages","stargazers_url":"https://api.github.com/repos/dranjan/numpy/stargazers","contributors_url":"https://api.github.com/repos/dranjan/numpy/contributors","subscribers_url":"https://api.github.com/repos/dranjan/numpy/subscribers","subscription_url":"https://api.github.com/repos/dranjan/numpy/subscription","commits_url":"https://api.github.com/repos/dranjan/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/dranjan/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/dranjan/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/dranjan/numpy/issues/comments/{number}","contents_url":"https://api.github.com/repos/dranjan/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/dranjan/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dranjan/numpy/merges","archive_url":"https://api.github.com/repos/dranjan/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dranjan/numpy/downloads","issues_url":"https://api.github.com/repos/dranjan/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/dranjan/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/dranjan/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/dranjan/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dranjan/numpy/labels{/name}","releases_url":"https://api.github.com/repos/dranjan/numpy/releases{/id}","created_at":"2014-11-14T02:31:22Z","updated_at":"2014-11-14T02:31:27Z","pushed_at":"2014-12-07T05:36:36Z","git_url":"git://github.com/dranjan/numpy.git","ssh_url":"git@github.com:dranjan/numpy.git","clone_url":"https://github.com/dranjan/numpy.git","svn_url":"https://github.com/dranjan/numpy","homepage":"http://www.numpy.org/","size":36168,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"numpy:master","ref":"master","sha":"f14d5e1e520e9f598abf9881d50d403a24bd258c","user":{"login":"numpy","id":288276,"avatar_url":"https://avatars.githubusercontent.com/u/288276?v=3","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"repo":{"id":908607,"name":"numpy","full_name":"numpy/numpy","owner":{"login":"numpy","id":288276,"avatar_url":"https://avatars.githubusercontent.com/u/288276?v=3","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/numpy/numpy","description":"Numpy main repository","fork":false,"url":"https://api.github.com/repos/numpy/numpy","forks_url":"https://api.github.com/repos/numpy/numpy/forks","keys_url":"https://api.github.com/repos/numpy/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/numpy/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/numpy/numpy/teams","hooks_url":"https://api.github.com/repos/numpy/numpy/hooks","issue_events_url":"https://api.github.com/repos/numpy/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/numpy/numpy/events","assignees_url":"https://api.github.com/repos/numpy/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/numpy/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/numpy/numpy/tags","blobs_url":"https://api.github.com/repos/numpy/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/numpy/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/numpy/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/numpy/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/numpy/numpy/languages","stargazers_url":"https://api.github.com/repos/numpy/numpy/stargazers","contributors_url":"https://api.github.com/repos/numpy/numpy/contributors","subscribers_url":"https://api.github.com/repos/numpy/numpy/subscribers","subscription_url":"https://api.github.com/repos/numpy/numpy/subscription","commits_url":"https://api.github.com/repos/numpy/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/numpy/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/numpy/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/numpy/numpy/issues/comments/{number}","contents_url":"https://api.github.com/repos/numpy/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/numpy/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/numpy/numpy/merges","archive_url":"https://api.github.com/repos/numpy/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/numpy/numpy/downloads","issues_url":"https://api.github.com/repos/numpy/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/numpy/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/numpy/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/numpy/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/numpy/numpy/labels{/name}","releases_url":"https://api.github.com/repos/numpy/numpy/releases{/id}","created_at":"2010-09-13T23:02:39Z","updated_at":"2015-01-22T17:10:04Z","pushed_at":"2015-01-21T22:26:02Z","git_url":"git://github.com/numpy/numpy.git","ssh_url":"git@github.com:numpy/numpy.git","clone_url":"https://github.com/numpy/numpy.git","svn_url":"https://github.com/numpy/numpy","homepage":"http://www.numpy.org/","size":61671,"stargazers_count":1691,"watchers_count":1691,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":829,"mirror_url":null,"open_issues_count":778,"forks":829,"open_issues":778,"watchers":1691,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/5279"},"html":{"href":"https://github.com/numpy/numpy/pull/5279"},"issue":{"href":"https://api.github.com/repos/numpy/numpy/issues/5279"},"comments":{"href":"https://api.github.com/repos/numpy/numpy/issues/5279/comments"},"review_comments":{"href":"https://api.github.com/repos/numpy/numpy/pulls/5279/comments"},"review_comment":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/numpy/numpy/pulls/5279/commits"},"statuses":{"href":"https://api.github.com/repos/numpy/numpy/statuses/31e16bb6f97ae49a70b16ca9399a13999edd6c4b"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":5,"review_comments":10,"commits":8,"additions":139,"deletions":29,"changed_files":3}}