{"action":"created","comment":{"url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/pulls/comments/45928866","id":45928866,"diff_hunk":"@@ -23,59 +21,31 @@\n LOG = logging.getLogger(__name__)\n \n \n-def _ovs_vsctl(args, timeout=timeout):\n+def _ovs_vsctl(args, timeout=30):\n     full_args = ['ovs-vsctl', '--timeout=%s' % timeout] + args\n     try:\n         return processutils.execute(*full_args, run_as_root=True)\n     except Exception as e:\n         LOG.error(_LE(\"Unable to execute %(cmd)s. Exception: %(exception)s\"),\n                   {'cmd': full_args, 'exception': e})\n-        raise exception.AgentError(method=full_args)\n+        raise e.AgentError(method=full_args)\n \n \n-def create_ovs_vif_port(bridge, dev, iface_id, mac, instance_id, mtu,\n-                        timeout=timeout):\n-    _ovs_vsctl(['--', '--if-exists', 'del-port', dev, '--',\n-                'add-port', bridge, dev,\n-                '--', 'set', 'Interface', dev,\n-                'external-ids:iface-id=%s' % iface_id,\n-                'external-ids:iface-status=active',\n-                'external-ids:attached-mac=%s' % mac,\n-                'external-ids:vm-uuid=%s' % instance_id],\n-                timeout=timeout)\n-    _set_device_mtu(dev, mtu)","path":"vif_plug_vhostuser/linux_net.py","position":37,"original_position":37,"commit_id":"8ac30ce32b3e0bae5d2d8f1edc9d64ac2871608e","original_commit_id":"8ac30ce32b3e0bae5d2d8f1edc9d64ac2871608e","user":{"login":"SeanMooney","id":2063887,"avatar_url":"https://avatars.githubusercontent.com/u/2063887?v=3","gravatar_id":"","url":"https://api.github.com/users/SeanMooney","html_url":"https://github.com/SeanMooney","followers_url":"https://api.github.com/users/SeanMooney/followers","following_url":"https://api.github.com/users/SeanMooney/following{/other_user}","gists_url":"https://api.github.com/users/SeanMooney/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanMooney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanMooney/subscriptions","organizations_url":"https://api.github.com/users/SeanMooney/orgs","repos_url":"https://api.github.com/users/SeanMooney/repos","events_url":"https://api.github.com/users/SeanMooney/events{/privacy}","received_events_url":"https://api.github.com/users/SeanMooney/received_events","type":"User","site_admin":false},"body":"when using vhost user you cannont set the mtu from the host.","created_at":"2015-11-25T22:58:28Z","updated_at":"2015-11-25T22:58:28Z","html_url":"https://github.com/jaypipes/vif_plug_vhostuser/pull/1#discussion_r45928866","pull_request_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/pulls/comments/45928866"},"html":{"href":"https://github.com/jaypipes/vif_plug_vhostuser/pull/1#discussion_r45928866"},"pull_request":{"href":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/pulls/1","id":51848022,"html_url":"https://github.com/jaypipes/vif_plug_vhostuser/pull/1","diff_url":"https://github.com/jaypipes/vif_plug_vhostuser/pull/1.diff","patch_url":"https://github.com/jaypipes/vif_plug_vhostuser/pull/1.patch","issue_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/issues/1","number":1,"state":"closed","locked":false,"title":"fixes pep8, imports missing modules and resolves logic error","user":{"login":"SeanMooney","id":2063887,"avatar_url":"https://avatars.githubusercontent.com/u/2063887?v=3","gravatar_id":"","url":"https://api.github.com/users/SeanMooney","html_url":"https://github.com/SeanMooney","followers_url":"https://api.github.com/users/SeanMooney/followers","following_url":"https://api.github.com/users/SeanMooney/following{/other_user}","gists_url":"https://api.github.com/users/SeanMooney/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanMooney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanMooney/subscriptions","organizations_url":"https://api.github.com/users/SeanMooney/orgs","repos_url":"https://api.github.com/users/SeanMooney/repos","events_url":"https://api.github.com/users/SeanMooney/events{/privacy}","received_events_url":"https://api.github.com/users/SeanMooney/received_events","type":"User","site_admin":false},"body":"-this change fixes pep8 so that the tox test pass.\r\n-this change fixes module imports to enable pep8 to pass.\r\n-this change fixes the VhostuserPlugin to invoke\r\n create_ovs_vif_port when vhostuser_ovs_plug instead of\r\n ovs_hybrid_plug\r\n-this chage moves exporting the entry point to the setup.cfg\r\n to enable tox to run.\r\n-this change update the requirement.txt to include the os_vif\r\n libary via a git include as it is not available in pip.","created_at":"2015-11-25T21:28:03Z","updated_at":"2015-11-25T22:58:28Z","closed_at":"2015-11-25T22:09:42Z","merged_at":"2015-11-25T22:09:42Z","merge_commit_sha":"a288c6570ae4aadf4731ebc401e28e484a631fa6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/pulls/1/commits","review_comments_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/pulls/1/comments","review_comment_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/issues/1/comments","statuses_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/statuses/8ac30ce32b3e0bae5d2d8f1edc9d64ac2871608e","head":{"label":"SeanMooney:fix-tox-and-vhost_user-issues","ref":"fix-tox-and-vhost_user-issues","sha":"8ac30ce32b3e0bae5d2d8f1edc9d64ac2871608e","user":{"login":"SeanMooney","id":2063887,"avatar_url":"https://avatars.githubusercontent.com/u/2063887?v=3","gravatar_id":"","url":"https://api.github.com/users/SeanMooney","html_url":"https://github.com/SeanMooney","followers_url":"https://api.github.com/users/SeanMooney/followers","following_url":"https://api.github.com/users/SeanMooney/following{/other_user}","gists_url":"https://api.github.com/users/SeanMooney/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanMooney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanMooney/subscriptions","organizations_url":"https://api.github.com/users/SeanMooney/orgs","repos_url":"https://api.github.com/users/SeanMooney/repos","events_url":"https://api.github.com/users/SeanMooney/events{/privacy}","received_events_url":"https://api.github.com/users/SeanMooney/received_events","type":"User","site_admin":false},"repo":{"id":46788224,"name":"vif_plug_vhostuser","full_name":"SeanMooney/vif_plug_vhostuser","owner":{"login":"SeanMooney","id":2063887,"avatar_url":"https://avatars.githubusercontent.com/u/2063887?v=3","gravatar_id":"","url":"https://api.github.com/users/SeanMooney","html_url":"https://github.com/SeanMooney","followers_url":"https://api.github.com/users/SeanMooney/followers","following_url":"https://api.github.com/users/SeanMooney/following{/other_user}","gists_url":"https://api.github.com/users/SeanMooney/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanMooney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanMooney/subscriptions","organizations_url":"https://api.github.com/users/SeanMooney/orgs","repos_url":"https://api.github.com/users/SeanMooney/repos","events_url":"https://api.github.com/users/SeanMooney/events{/privacy}","received_events_url":"https://api.github.com/users/SeanMooney/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SeanMooney/vif_plug_vhostuser","description":"os-vif plugin and library for VIFs that use QEMU's vhost-user device type","fork":true,"url":"https://api.github.com/repos/SeanMooney/vif_plug_vhostuser","forks_url":"https://api.github.com/repos/SeanMooney/vif_plug_vhostuser/forks","keys_url":"https://api.github.com/repos/SeanMooney/vif_plug_vhostuser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SeanMooney/vif_plug_vhostuser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SeanMooney/vif_plug_vhostuser/teams","hooks_url":"https://api.github.com/repos/SeanMooney/vif_plug_vhostuser/hooks","issue_events_url":"https://api.github.com/repos/SeanMooney/vif_plug_vhostuser/issues/events{/number}","events_url":"https://api.github.com/repos/SeanMooney/vif_plug_vhostuser/events","assignees_url":"https://api.github.com/repos/SeanMooney/vif_plug_vhostuser/assignees{/user}","branches_url":"https://api.github.com/repos/SeanMooney/vif_plug_vhostuser/branches{/branch}","tags_url":"https://api.github.com/repos/SeanMooney/vif_plug_vhostuser/tags","blobs_url":"https://api.github.com/repos/SeanMooney/vif_plug_vhostuser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SeanMooney/vif_plug_vhostuser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SeanMooney/vif_plug_vhostuser/git/refs{/sha}","trees_url":"https://api.github.com/repos/SeanMooney/vif_plug_vhostuser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SeanMooney/vif_plug_vhostuser/statuses/{sha}","languages_url":"https://api.github.com/repos/SeanMooney/vif_plug_vhostuser/languages","stargazers_url":"https://api.github.com/repos/SeanMooney/vif_plug_vhostuser/stargazers","contributors_url":"https://api.github.com/repos/SeanMooney/vif_plug_vhostuser/contributors","subscribers_url":"https://api.github.com/repos/SeanMooney/vif_plug_vhostuser/subscribers","subscription_url":"https://api.github.com/repos/SeanMooney/vif_plug_vhostuser/subscription","commits_url":"https://api.github.com/repos/SeanMooney/vif_plug_vhostuser/commits{/sha}","git_commits_url":"https://api.github.com/repos/SeanMooney/vif_plug_vhostuser/git/commits{/sha}","comments_url":"https://api.github.com/repos/SeanMooney/vif_plug_vhostuser/comments{/number}","issue_comment_url":"https://api.github.com/repos/SeanMooney/vif_plug_vhostuser/issues/comments{/number}","contents_url":"https://api.github.com/repos/SeanMooney/vif_plug_vhostuser/contents/{+path}","compare_url":"https://api.github.com/repos/SeanMooney/vif_plug_vhostuser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SeanMooney/vif_plug_vhostuser/merges","archive_url":"https://api.github.com/repos/SeanMooney/vif_plug_vhostuser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SeanMooney/vif_plug_vhostuser/downloads","issues_url":"https://api.github.com/repos/SeanMooney/vif_plug_vhostuser/issues{/number}","pulls_url":"https://api.github.com/repos/SeanMooney/vif_plug_vhostuser/pulls{/number}","milestones_url":"https://api.github.com/repos/SeanMooney/vif_plug_vhostuser/milestones{/number}","notifications_url":"https://api.github.com/repos/SeanMooney/vif_plug_vhostuser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SeanMooney/vif_plug_vhostuser/labels{/name}","releases_url":"https://api.github.com/repos/SeanMooney/vif_plug_vhostuser/releases{/id}","created_at":"2015-11-24T11:44:39Z","updated_at":"2015-11-24T11:44:40Z","pushed_at":"2015-11-25T21:23:31Z","git_url":"git://github.com/SeanMooney/vif_plug_vhostuser.git","ssh_url":"git@github.com:SeanMooney/vif_plug_vhostuser.git","clone_url":"https://github.com/SeanMooney/vif_plug_vhostuser.git","svn_url":"https://github.com/SeanMooney/vif_plug_vhostuser","homepage":null,"size":15,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jaypipes:master","ref":"master","sha":"da2384f8ee1996f4ee09cceb3d7360e2a6cec01b","user":{"login":"jaypipes","id":265023,"avatar_url":"https://avatars.githubusercontent.com/u/265023?v=3","gravatar_id":"","url":"https://api.github.com/users/jaypipes","html_url":"https://github.com/jaypipes","followers_url":"https://api.github.com/users/jaypipes/followers","following_url":"https://api.github.com/users/jaypipes/following{/other_user}","gists_url":"https://api.github.com/users/jaypipes/gists{/gist_id}","starred_url":"https://api.github.com/users/jaypipes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaypipes/subscriptions","organizations_url":"https://api.github.com/users/jaypipes/orgs","repos_url":"https://api.github.com/users/jaypipes/repos","events_url":"https://api.github.com/users/jaypipes/events{/privacy}","received_events_url":"https://api.github.com/users/jaypipes/received_events","type":"User","site_admin":false},"repo":{"id":46075180,"name":"vif_plug_vhostuser","full_name":"jaypipes/vif_plug_vhostuser","owner":{"login":"jaypipes","id":265023,"avatar_url":"https://avatars.githubusercontent.com/u/265023?v=3","gravatar_id":"","url":"https://api.github.com/users/jaypipes","html_url":"https://github.com/jaypipes","followers_url":"https://api.github.com/users/jaypipes/followers","following_url":"https://api.github.com/users/jaypipes/following{/other_user}","gists_url":"https://api.github.com/users/jaypipes/gists{/gist_id}","starred_url":"https://api.github.com/users/jaypipes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaypipes/subscriptions","organizations_url":"https://api.github.com/users/jaypipes/orgs","repos_url":"https://api.github.com/users/jaypipes/repos","events_url":"https://api.github.com/users/jaypipes/events{/privacy}","received_events_url":"https://api.github.com/users/jaypipes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jaypipes/vif_plug_vhostuser","description":"os-vif plugin and library for VIFs that use QEMU's vhost-user device type","fork":false,"url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser","forks_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/forks","keys_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/teams","hooks_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/hooks","issue_events_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/issues/events{/number}","events_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/events","assignees_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/assignees{/user}","branches_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/branches{/branch}","tags_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/tags","blobs_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/statuses/{sha}","languages_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/languages","stargazers_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/stargazers","contributors_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/contributors","subscribers_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/subscribers","subscription_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/subscription","commits_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/contents/{+path}","compare_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/merges","archive_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/downloads","issues_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/issues{/number}","pulls_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/pulls{/number}","milestones_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/milestones{/number}","notifications_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/labels{/name}","releases_url":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/releases{/id}","created_at":"2015-11-12T19:16:26Z","updated_at":"2015-11-12T19:16:36Z","pushed_at":"2015-11-25T22:09:42Z","git_url":"git://github.com/jaypipes/vif_plug_vhostuser.git","ssh_url":"git@github.com:jaypipes/vif_plug_vhostuser.git","clone_url":"https://github.com/jaypipes/vif_plug_vhostuser.git","svn_url":"https://github.com/jaypipes/vif_plug_vhostuser","homepage":null,"size":15,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/pulls/1"},"html":{"href":"https://github.com/jaypipes/vif_plug_vhostuser/pull/1"},"issue":{"href":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/issues/1"},"comments":{"href":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/jaypipes/vif_plug_vhostuser/statuses/8ac30ce32b3e0bae5d2d8f1edc9d64ac2871608e"}}}}