{"action":"created","comment":{"url":"https://api.github.com/repos/aces/Loris/pulls/comments/29785885","id":29785885,"diff_hunk":"@@ -200,7 +205,12 @@ class NDB_Form_user_accounts extends NDB_Form\n \n         ///get the value for additional_user_info flag\n         $config =& NDB_Config::singleton();\n-        $additional_user_info = $config->getSetting('additional_user_info');\n+        try {","path":"modules/user_accounts/php/NDB_Form_user_accounts.class.inc","position":19,"original_position":19,"commit_id":"c0b9bee48f428a50c3ae852ccadb2742b253e630","original_commit_id":"c0b9bee48f428a50c3ae852ccadb2742b253e630","user":{"login":"driusan","id":498329,"avatar_url":"https://avatars.githubusercontent.com/u/498329?v=3","gravatar_id":"","url":"https://api.github.com/users/driusan","html_url":"https://github.com/driusan","followers_url":"https://api.github.com/users/driusan/followers","following_url":"https://api.github.com/users/driusan/following{/other_user}","gists_url":"https://api.github.com/users/driusan/gists{/gist_id}","starred_url":"https://api.github.com/users/driusan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/driusan/subscriptions","organizations_url":"https://api.github.com/users/driusan/orgs","repos_url":"https://api.github.com/users/driusan/repos","events_url":"https://api.github.com/users/driusan/events{/privacy}","received_events_url":"https://api.github.com/users/driusan/received_events","type":"User","site_admin":false},"body":"This shouldn't have a try/catch block.. if the setting is missing, it needs to be added to the schema.","created_at":"2015-05-06T18:15:27Z","updated_at":"2015-05-06T18:15:27Z","html_url":"https://github.com/aces/Loris/pull/1090#discussion_r29785885","pull_request_url":"https://api.github.com/repos/aces/Loris/pulls/1090","_links":{"self":{"href":"https://api.github.com/repos/aces/Loris/pulls/comments/29785885"},"html":{"href":"https://github.com/aces/Loris/pull/1090#discussion_r29785885"},"pull_request":{"href":"https://api.github.com/repos/aces/Loris/pulls/1090"}}},"pull_request":{"url":"https://api.github.com/repos/aces/Loris/pulls/1090","id":34377470,"html_url":"https://github.com/aces/Loris/pull/1090","diff_url":"https://github.com/aces/Loris/pull/1090.diff","patch_url":"https://github.com/aces/Loris/pull/1090.patch","issue_url":"https://api.github.com/repos/aces/Loris/issues/1090","number":1090,"state":"open","locked":false,"title":"This fixes a lot of issues with the User Account/My Preferences/Add User page","user":{"login":"nicolasbrossard","id":6844033,"avatar_url":"https://avatars.githubusercontent.com/u/6844033?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolasbrossard","html_url":"https://github.com/nicolasbrossard","followers_url":"https://api.github.com/users/nicolasbrossard/followers","following_url":"https://api.github.com/users/nicolasbrossard/following{/other_user}","gists_url":"https://api.github.com/users/nicolasbrossard/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolasbrossard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolasbrossard/subscriptions","organizations_url":"https://api.github.com/users/nicolasbrossard/orgs","repos_url":"https://api.github.com/users/nicolasbrossard/repos","events_url":"https://api.github.com/users/nicolasbrossard/events{/privacy}","received_events_url":"https://api.github.com/users/nicolasbrossard/received_events","type":"User","site_admin":false},"body":"Namely:\r\n\r\n   - Required fields could be missing and the form could be saved anyway\r\n   - Password validation did not work\r\n   - Email uniqueness check was buggy\r\n   - Focus is now transferred to the first invalid field\r\n   - Generate new Password could be checked even though Send email was not.","created_at":"2015-04-29T15:54:09Z","updated_at":"2015-05-06T18:15:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a721a3465fa7cd52190725da0f217f0bc4f96cfa","assignee":{"login":"tedstrauss","id":930560,"avatar_url":"https://avatars.githubusercontent.com/u/930560?v=3","gravatar_id":"","url":"https://api.github.com/users/tedstrauss","html_url":"https://github.com/tedstrauss","followers_url":"https://api.github.com/users/tedstrauss/followers","following_url":"https://api.github.com/users/tedstrauss/following{/other_user}","gists_url":"https://api.github.com/users/tedstrauss/gists{/gist_id}","starred_url":"https://api.github.com/users/tedstrauss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tedstrauss/subscriptions","organizations_url":"https://api.github.com/users/tedstrauss/orgs","repos_url":"https://api.github.com/users/tedstrauss/repos","events_url":"https://api.github.com/users/tedstrauss/events{/privacy}","received_events_url":"https://api.github.com/users/tedstrauss/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/aces/Loris/milestones/2","html_url":"https://github.com/aces/Loris/milestones/15.04","labels_url":"https://api.github.com/repos/aces/Loris/milestones/2/labels","id":906132,"number":2,"title":"15.04","description":"The upcoming 15.04 Loris release","creator":{"login":"driusan","id":498329,"avatar_url":"https://avatars.githubusercontent.com/u/498329?v=3","gravatar_id":"","url":"https://api.github.com/users/driusan","html_url":"https://github.com/driusan","followers_url":"https://api.github.com/users/driusan/followers","following_url":"https://api.github.com/users/driusan/following{/other_user}","gists_url":"https://api.github.com/users/driusan/gists{/gist_id}","starred_url":"https://api.github.com/users/driusan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/driusan/subscriptions","organizations_url":"https://api.github.com/users/driusan/orgs","repos_url":"https://api.github.com/users/driusan/repos","events_url":"https://api.github.com/users/driusan/events{/privacy}","received_events_url":"https://api.github.com/users/driusan/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":189,"state":"open","created_at":"2014-12-16T20:47:35Z","updated_at":"2015-05-06T17:42:13Z","due_on":"2015-04-25T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/aces/Loris/pulls/1090/commits","review_comments_url":"https://api.github.com/repos/aces/Loris/pulls/1090/comments","review_comment_url":"https://api.github.com/repos/aces/Loris/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aces/Loris/issues/1090/comments","statuses_url":"https://api.github.com/repos/aces/Loris/statuses/c0b9bee48f428a50c3ae852ccadb2742b253e630","head":{"label":"nicolasbrossard:fix_user_account","ref":"fix_user_account","sha":"c0b9bee48f428a50c3ae852ccadb2742b253e630","user":{"login":"nicolasbrossard","id":6844033,"avatar_url":"https://avatars.githubusercontent.com/u/6844033?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolasbrossard","html_url":"https://github.com/nicolasbrossard","followers_url":"https://api.github.com/users/nicolasbrossard/followers","following_url":"https://api.github.com/users/nicolasbrossard/following{/other_user}","gists_url":"https://api.github.com/users/nicolasbrossard/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolasbrossard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolasbrossard/subscriptions","organizations_url":"https://api.github.com/users/nicolasbrossard/orgs","repos_url":"https://api.github.com/users/nicolasbrossard/repos","events_url":"https://api.github.com/users/nicolasbrossard/events{/privacy}","received_events_url":"https://api.github.com/users/nicolasbrossard/received_events","type":"User","site_admin":false},"repo":{"id":26454023,"name":"Loris","full_name":"nicolasbrossard/Loris","owner":{"login":"nicolasbrossard","id":6844033,"avatar_url":"https://avatars.githubusercontent.com/u/6844033?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolasbrossard","html_url":"https://github.com/nicolasbrossard","followers_url":"https://api.github.com/users/nicolasbrossard/followers","following_url":"https://api.github.com/users/nicolasbrossard/following{/other_user}","gists_url":"https://api.github.com/users/nicolasbrossard/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolasbrossard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolasbrossard/subscriptions","organizations_url":"https://api.github.com/users/nicolasbrossard/orgs","repos_url":"https://api.github.com/users/nicolasbrossard/repos","events_url":"https://api.github.com/users/nicolasbrossard/events{/privacy}","received_events_url":"https://api.github.com/users/nicolasbrossard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nicolasbrossard/Loris","description":"LORIS (Longitudinal Online Research and Imaging System) is a web-accessible database solution for neuroimaging.","fork":true,"url":"https://api.github.com/repos/nicolasbrossard/Loris","forks_url":"https://api.github.com/repos/nicolasbrossard/Loris/forks","keys_url":"https://api.github.com/repos/nicolasbrossard/Loris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nicolasbrossard/Loris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nicolasbrossard/Loris/teams","hooks_url":"https://api.github.com/repos/nicolasbrossard/Loris/hooks","issue_events_url":"https://api.github.com/repos/nicolasbrossard/Loris/issues/events{/number}","events_url":"https://api.github.com/repos/nicolasbrossard/Loris/events","assignees_url":"https://api.github.com/repos/nicolasbrossard/Loris/assignees{/user}","branches_url":"https://api.github.com/repos/nicolasbrossard/Loris/branches{/branch}","tags_url":"https://api.github.com/repos/nicolasbrossard/Loris/tags","blobs_url":"https://api.github.com/repos/nicolasbrossard/Loris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nicolasbrossard/Loris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nicolasbrossard/Loris/git/refs{/sha}","trees_url":"https://api.github.com/repos/nicolasbrossard/Loris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nicolasbrossard/Loris/statuses/{sha}","languages_url":"https://api.github.com/repos/nicolasbrossard/Loris/languages","stargazers_url":"https://api.github.com/repos/nicolasbrossard/Loris/stargazers","contributors_url":"https://api.github.com/repos/nicolasbrossard/Loris/contributors","subscribers_url":"https://api.github.com/repos/nicolasbrossard/Loris/subscribers","subscription_url":"https://api.github.com/repos/nicolasbrossard/Loris/subscription","commits_url":"https://api.github.com/repos/nicolasbrossard/Loris/commits{/sha}","git_commits_url":"https://api.github.com/repos/nicolasbrossard/Loris/git/commits{/sha}","comments_url":"https://api.github.com/repos/nicolasbrossard/Loris/comments{/number}","issue_comment_url":"https://api.github.com/repos/nicolasbrossard/Loris/issues/comments{/number}","contents_url":"https://api.github.com/repos/nicolasbrossard/Loris/contents/{+path}","compare_url":"https://api.github.com/repos/nicolasbrossard/Loris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nicolasbrossard/Loris/merges","archive_url":"https://api.github.com/repos/nicolasbrossard/Loris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nicolasbrossard/Loris/downloads","issues_url":"https://api.github.com/repos/nicolasbrossard/Loris/issues{/number}","pulls_url":"https://api.github.com/repos/nicolasbrossard/Loris/pulls{/number}","milestones_url":"https://api.github.com/repos/nicolasbrossard/Loris/milestones{/number}","notifications_url":"https://api.github.com/repos/nicolasbrossard/Loris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nicolasbrossard/Loris/labels{/name}","releases_url":"https://api.github.com/repos/nicolasbrossard/Loris/releases{/id}","created_at":"2014-11-10T20:23:24Z","updated_at":"2014-11-04T16:24:43Z","pushed_at":"2015-05-05T20:31:03Z","git_url":"git://github.com/nicolasbrossard/Loris.git","ssh_url":"git@github.com:nicolasbrossard/Loris.git","clone_url":"https://github.com/nicolasbrossard/Loris.git","svn_url":"https://github.com/nicolasbrossard/Loris","homepage":"","size":56816,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aces:master","ref":"master","sha":"213449a434bf008d73b2723c4aca015e01e68aa3","user":{"login":"aces","id":472868,"avatar_url":"https://avatars.githubusercontent.com/u/472868?v=3","gravatar_id":"","url":"https://api.github.com/users/aces","html_url":"https://github.com/aces","followers_url":"https://api.github.com/users/aces/followers","following_url":"https://api.github.com/users/aces/following{/other_user}","gists_url":"https://api.github.com/users/aces/gists{/gist_id}","starred_url":"https://api.github.com/users/aces/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aces/subscriptions","organizations_url":"https://api.github.com/users/aces/orgs","repos_url":"https://api.github.com/users/aces/repos","events_url":"https://api.github.com/users/aces/events{/privacy}","received_events_url":"https://api.github.com/users/aces/received_events","type":"Organization","site_admin":false},"repo":{"id":1125630,"name":"Loris","full_name":"aces/Loris","owner":{"login":"aces","id":472868,"avatar_url":"https://avatars.githubusercontent.com/u/472868?v=3","gravatar_id":"","url":"https://api.github.com/users/aces","html_url":"https://github.com/aces","followers_url":"https://api.github.com/users/aces/followers","following_url":"https://api.github.com/users/aces/following{/other_user}","gists_url":"https://api.github.com/users/aces/gists{/gist_id}","starred_url":"https://api.github.com/users/aces/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aces/subscriptions","organizations_url":"https://api.github.com/users/aces/orgs","repos_url":"https://api.github.com/users/aces/repos","events_url":"https://api.github.com/users/aces/events{/privacy}","received_events_url":"https://api.github.com/users/aces/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aces/Loris","description":"LORIS is a web-accessible database solution for longitudinal multi-site studies.","fork":false,"url":"https://api.github.com/repos/aces/Loris","forks_url":"https://api.github.com/repos/aces/Loris/forks","keys_url":"https://api.github.com/repos/aces/Loris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aces/Loris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aces/Loris/teams","hooks_url":"https://api.github.com/repos/aces/Loris/hooks","issue_events_url":"https://api.github.com/repos/aces/Loris/issues/events{/number}","events_url":"https://api.github.com/repos/aces/Loris/events","assignees_url":"https://api.github.com/repos/aces/Loris/assignees{/user}","branches_url":"https://api.github.com/repos/aces/Loris/branches{/branch}","tags_url":"https://api.github.com/repos/aces/Loris/tags","blobs_url":"https://api.github.com/repos/aces/Loris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aces/Loris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aces/Loris/git/refs{/sha}","trees_url":"https://api.github.com/repos/aces/Loris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aces/Loris/statuses/{sha}","languages_url":"https://api.github.com/repos/aces/Loris/languages","stargazers_url":"https://api.github.com/repos/aces/Loris/stargazers","contributors_url":"https://api.github.com/repos/aces/Loris/contributors","subscribers_url":"https://api.github.com/repos/aces/Loris/subscribers","subscription_url":"https://api.github.com/repos/aces/Loris/subscription","commits_url":"https://api.github.com/repos/aces/Loris/commits{/sha}","git_commits_url":"https://api.github.com/repos/aces/Loris/git/commits{/sha}","comments_url":"https://api.github.com/repos/aces/Loris/comments{/number}","issue_comment_url":"https://api.github.com/repos/aces/Loris/issues/comments{/number}","contents_url":"https://api.github.com/repos/aces/Loris/contents/{+path}","compare_url":"https://api.github.com/repos/aces/Loris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aces/Loris/merges","archive_url":"https://api.github.com/repos/aces/Loris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aces/Loris/downloads","issues_url":"https://api.github.com/repos/aces/Loris/issues{/number}","pulls_url":"https://api.github.com/repos/aces/Loris/pulls{/number}","milestones_url":"https://api.github.com/repos/aces/Loris/milestones{/number}","notifications_url":"https://api.github.com/repos/aces/Loris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aces/Loris/labels{/name}","releases_url":"https://api.github.com/repos/aces/Loris/releases{/id}","created_at":"2010-11-30T14:57:57Z","updated_at":"2015-05-06T17:55:03Z","pushed_at":"2015-05-06T17:55:03Z","git_url":"git://github.com/aces/Loris.git","ssh_url":"git@github.com:aces/Loris.git","clone_url":"https://github.com/aces/Loris.git","svn_url":"https://github.com/aces/Loris","homepage":"","size":66120,"stargazers_count":22,"watchers_count":22,"language":"Smarty","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":21,"forks":23,"open_issues":21,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aces/Loris/pulls/1090"},"html":{"href":"https://github.com/aces/Loris/pull/1090"},"issue":{"href":"https://api.github.com/repos/aces/Loris/issues/1090"},"comments":{"href":"https://api.github.com/repos/aces/Loris/issues/1090/comments"},"review_comments":{"href":"https://api.github.com/repos/aces/Loris/pulls/1090/comments"},"review_comment":{"href":"https://api.github.com/repos/aces/Loris/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aces/Loris/pulls/1090/commits"},"statuses":{"href":"https://api.github.com/repos/aces/Loris/statuses/c0b9bee48f428a50c3ae852ccadb2742b253e630"}}}}