{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/29820069","id":29820069,"diff_hunk":"@@ -185,14 +185,31 @@ private bool ApplyForceLinesOperation(AdjustNewLinesOperation operation, int pai\n                 return true;\n             }\n \n+            private int getIndentation(int pairIndex, TriviaData triviaInfo)","path":"src/Workspaces/Core/Portable/Formatting/Engine/AbstractFormatEngine.OperationApplier.cs","position":14,"original_position":14,"commit_id":"43362e0bf0fcabbdba6dcf9148a2a14f2d1235fd","original_commit_id":"43362e0bf0fcabbdba6dcf9148a2a14f2d1235fd","user":{"login":"heejaechang","id":1333179,"avatar_url":"https://avatars.githubusercontent.com/u/1333179?v=3","gravatar_id":"","url":"https://api.github.com/users/heejaechang","html_url":"https://github.com/heejaechang","followers_url":"https://api.github.com/users/heejaechang/followers","following_url":"https://api.github.com/users/heejaechang/following{/other_user}","gists_url":"https://api.github.com/users/heejaechang/gists{/gist_id}","starred_url":"https://api.github.com/users/heejaechang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heejaechang/subscriptions","organizations_url":"https://api.github.com/users/heejaechang/orgs","repos_url":"https://api.github.com/users/heejaechang/repos","events_url":"https://api.github.com/users/heejaechang/events{/privacy}","received_events_url":"https://api.github.com/users/heejaechang/received_events","type":"User","site_admin":false},"body":"@basoundr I dont believe this is right way to do it. format engine should not know about smart indentation.\r\n\r\nrather than this, change smart indenter's specific formatting rules to return null for all indentation operation. and make NewLineOperation to always return null. that will make no new line to happen.","created_at":"2015-05-07T02:18:46Z","updated_at":"2015-05-07T02:18:46Z","html_url":"https://github.com/dotnet/roslyn/pull/2521#discussion_r29820069","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/2521","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/29820069"},"html":{"href":"https://github.com/dotnet/roslyn/pull/2521#discussion_r29820069"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2521"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/2521","id":34745084,"html_url":"https://github.com/dotnet/roslyn/pull/2521","diff_url":"https://github.com/dotnet/roslyn/pull/2521.diff","patch_url":"https://github.com/dotnet/roslyn/pull/2521.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/2521","number":2521,"state":"open","locked":false,"title":"FormatEngine honors IndentationStyle during LineOp","user":{"login":"basoundr","id":10550513,"avatar_url":"https://avatars.githubusercontent.com/u/10550513?v=3","gravatar_id":"","url":"https://api.github.com/users/basoundr","html_url":"https://github.com/basoundr","followers_url":"https://api.github.com/users/basoundr/followers","following_url":"https://api.github.com/users/basoundr/following{/other_user}","gists_url":"https://api.github.com/users/basoundr/gists{/gist_id}","starred_url":"https://api.github.com/users/basoundr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basoundr/subscriptions","organizations_url":"https://api.github.com/users/basoundr/orgs","repos_url":"https://api.github.com/users/basoundr/repos","events_url":"https://api.github.com/users/basoundr/events{/privacy}","received_events_url":"https://api.github.com/users/basoundr/received_events","type":"User","site_admin":false},"body":"Fix #2509 FormatEngine should honor the user selected IndentationStyle\r\noption while performing Line Operation","created_at":"2015-05-05T17:01:25Z","updated_at":"2015-05-07T02:18:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d58b9ecedfa221f55dad710963a6f85150ff744f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/2521/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/2521/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/2521/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/43362e0bf0fcabbdba6dcf9148a2a14f2d1235fd","head":{"label":"basoundr:fix2509PreserverIndentation","ref":"fix2509PreserverIndentation","sha":"43362e0bf0fcabbdba6dcf9148a2a14f2d1235fd","user":{"login":"basoundr","id":10550513,"avatar_url":"https://avatars.githubusercontent.com/u/10550513?v=3","gravatar_id":"","url":"https://api.github.com/users/basoundr","html_url":"https://github.com/basoundr","followers_url":"https://api.github.com/users/basoundr/followers","following_url":"https://api.github.com/users/basoundr/following{/other_user}","gists_url":"https://api.github.com/users/basoundr/gists{/gist_id}","starred_url":"https://api.github.com/users/basoundr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basoundr/subscriptions","organizations_url":"https://api.github.com/users/basoundr/orgs","repos_url":"https://api.github.com/users/basoundr/repos","events_url":"https://api.github.com/users/basoundr/events{/privacy}","received_events_url":"https://api.github.com/users/basoundr/received_events","type":"User","site_admin":false},"repo":{"id":30552118,"name":"roslyn","full_name":"basoundr/roslyn","owner":{"login":"basoundr","id":10550513,"avatar_url":"https://avatars.githubusercontent.com/u/10550513?v=3","gravatar_id":"","url":"https://api.github.com/users/basoundr","html_url":"https://github.com/basoundr","followers_url":"https://api.github.com/users/basoundr/followers","following_url":"https://api.github.com/users/basoundr/following{/other_user}","gists_url":"https://api.github.com/users/basoundr/gists{/gist_id}","starred_url":"https://api.github.com/users/basoundr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basoundr/subscriptions","organizations_url":"https://api.github.com/users/basoundr/orgs","repos_url":"https://api.github.com/users/basoundr/repos","events_url":"https://api.github.com/users/basoundr/events{/privacy}","received_events_url":"https://api.github.com/users/basoundr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/basoundr/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/basoundr/roslyn","forks_url":"https://api.github.com/repos/basoundr/roslyn/forks","keys_url":"https://api.github.com/repos/basoundr/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/basoundr/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/basoundr/roslyn/teams","hooks_url":"https://api.github.com/repos/basoundr/roslyn/hooks","issue_events_url":"https://api.github.com/repos/basoundr/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/basoundr/roslyn/events","assignees_url":"https://api.github.com/repos/basoundr/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/basoundr/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/basoundr/roslyn/tags","blobs_url":"https://api.github.com/repos/basoundr/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/basoundr/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/basoundr/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/basoundr/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/basoundr/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/basoundr/roslyn/languages","stargazers_url":"https://api.github.com/repos/basoundr/roslyn/stargazers","contributors_url":"https://api.github.com/repos/basoundr/roslyn/contributors","subscribers_url":"https://api.github.com/repos/basoundr/roslyn/subscribers","subscription_url":"https://api.github.com/repos/basoundr/roslyn/subscription","commits_url":"https://api.github.com/repos/basoundr/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/basoundr/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/basoundr/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/basoundr/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/basoundr/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/basoundr/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/basoundr/roslyn/merges","archive_url":"https://api.github.com/repos/basoundr/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/basoundr/roslyn/downloads","issues_url":"https://api.github.com/repos/basoundr/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/basoundr/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/basoundr/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/basoundr/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/basoundr/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/basoundr/roslyn/releases{/id}","created_at":"2015-02-09T18:50:00Z","updated_at":"2015-04-29T00:39:24Z","pushed_at":"2015-05-07T00:34:57Z","git_url":"git://github.com/basoundr/roslyn.git","ssh_url":"git@github.com:basoundr/roslyn.git","clone_url":"https://github.com/basoundr/roslyn.git","svn_url":"https://github.com/basoundr/roslyn","homepage":"","size":69635,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"6e10d458905a2c9b49d39e70277fc38cfb07f8b3","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","created_at":"2015-01-11T02:39:03Z","updated_at":"2015-05-07T02:10:58Z","pushed_at":"2015-05-07T00:53:05Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":126408,"stargazers_count":2209,"watchers_count":2209,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":465,"mirror_url":null,"open_issues_count":780,"forks":465,"open_issues":780,"watchers":2209,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2521"},"html":{"href":"https://github.com/dotnet/roslyn/pull/2521"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/2521"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/2521/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2521/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2521/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/43362e0bf0fcabbdba6dcf9148a2a14f2d1235fd"}}}}