{"action":"created","comment":{"url":"https://api.github.com/repos/PistonDevelopers/hematite_server/pulls/comments/26264119","id":26264119,"diff_hunk":"@@ -467,7 +467,8 @@ pub mod login {\n     pub mod clientbound { packets! {\n         // 0x00 => Disconnect { reason: Chat }\n         0x01 => EncryptionRequest { server_id: String, pubkey: Arr<Var<i32>, u8>, verify_token: Arr<Var<i32>, u8> }\n-        // 0x02 => LoginSuccess { uuid: Uuid, username: String; impl Protocol for LoginSuccess { ... } } // NOTE: uuid field is encoded as a string!\n+        // NOTE: uuid field is encoded as a string!\n+        0x02 => LoginSuccess { uuid: String, username: String }","path":"src/packet.rs","position":6,"original_position":6,"commit_id":"67c1fd97b204fe24acef5cddcb4a347dec682673","original_commit_id":"63dc4930c15815fb4b688a48fcab19dda9147852","user":{"login":"fenhl","id":641386,"avatar_url":"https://avatars.githubusercontent.com/u/641386?v=3","gravatar_id":"","url":"https://api.github.com/users/fenhl","html_url":"https://github.com/fenhl","followers_url":"https://api.github.com/users/fenhl/followers","following_url":"https://api.github.com/users/fenhl/following{/other_user}","gists_url":"https://api.github.com/users/fenhl/gists{/gist_id}","starred_url":"https://api.github.com/users/fenhl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fenhl/subscriptions","organizations_url":"https://api.github.com/users/fenhl/orgs","repos_url":"https://api.github.com/users/fenhl/repos","events_url":"https://api.github.com/users/fenhl/events{/privacy}","received_events_url":"https://api.github.com/users/fenhl/received_events","type":"User","site_admin":false},"body":"And as I pointed out, this doesn't need to be a custom packet if we can [add a UuidString type](https://www.irccloud.com/pastebin/tpCJMXqh/uuidstring.rs) instead.","created_at":"2015-03-11T22:48:58Z","updated_at":"2015-03-11T22:48:58Z","html_url":"https://github.com/PistonDevelopers/hematite_server/pull/40#discussion_r26264119","pull_request_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/PistonDevelopers/hematite_server/pulls/comments/26264119"},"html":{"href":"https://github.com/PistonDevelopers/hematite_server/pull/40#discussion_r26264119"},"pull_request":{"href":"https://api.github.com/repos/PistonDevelopers/hematite_server/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/PistonDevelopers/hematite_server/pulls/40","id":30864452,"html_url":"https://github.com/PistonDevelopers/hematite_server/pull/40","diff_url":"https://github.com/PistonDevelopers/hematite_server/pull/40.diff","patch_url":"https://github.com/PistonDevelopers/hematite_server/pull/40.patch","issue_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/issues/40","number":40,"state":"open","locked":false,"title":"Basic server features working (ping+login)","user":{"login":"toqueteos","id":699969,"avatar_url":"https://avatars.githubusercontent.com/u/699969?v=3","gravatar_id":"","url":"https://api.github.com/users/toqueteos","html_url":"https://github.com/toqueteos","followers_url":"https://api.github.com/users/toqueteos/followers","following_url":"https://api.github.com/users/toqueteos/following{/other_user}","gists_url":"https://api.github.com/users/toqueteos/gists{/gist_id}","starred_url":"https://api.github.com/users/toqueteos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toqueteos/subscriptions","organizations_url":"https://api.github.com/users/toqueteos/orgs","repos_url":"https://api.github.com/users/toqueteos/repos","events_url":"https://api.github.com/users/toqueteos/events{/privacy}","received_events_url":"https://api.github.com/users/toqueteos/received_events","type":"User","site_admin":false},"body":"**DO NOT MERGE THIS.**\r\n\r\nJust here for discussion.","created_at":"2015-03-10T16:01:29Z","updated_at":"2015-03-11T22:48:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb2a47a41eb513c80d43270453feda1bf4778f51","assignee":null,"milestone":{"url":"https://api.github.com/repos/PistonDevelopers/hematite_server/milestones/2","html_url":"https://github.com/PistonDevelopers/hematite_server/milestones/MC%201.8.3","labels_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/milestones/2/labels","id":998942,"number":2,"title":"MC 1.8.3","description":"hematite_server works as a drop-in replacement for MC vanilla server.","creator":{"login":"toqueteos","id":699969,"avatar_url":"https://avatars.githubusercontent.com/u/699969?v=3","gravatar_id":"","url":"https://api.github.com/users/toqueteos","html_url":"https://github.com/toqueteos","followers_url":"https://api.github.com/users/toqueteos/followers","following_url":"https://api.github.com/users/toqueteos/following{/other_user}","gists_url":"https://api.github.com/users/toqueteos/gists{/gist_id}","starred_url":"https://api.github.com/users/toqueteos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toqueteos/subscriptions","organizations_url":"https://api.github.com/users/toqueteos/orgs","repos_url":"https://api.github.com/users/toqueteos/repos","events_url":"https://api.github.com/users/toqueteos/events{/privacy}","received_events_url":"https://api.github.com/users/toqueteos/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":0,"state":"open","created_at":"2015-02-27T15:15:47Z","updated_at":"2015-03-11T18:02:40Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/pulls/40/commits","review_comments_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/pulls/40/comments","review_comment_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/issues/40/comments","statuses_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/statuses/67c1fd97b204fe24acef5cddcb4a347dec682673","head":{"label":"toqueteos:newio-server","ref":"newio-server","sha":"67c1fd97b204fe24acef5cddcb4a347dec682673","user":{"login":"toqueteos","id":699969,"avatar_url":"https://avatars.githubusercontent.com/u/699969?v=3","gravatar_id":"","url":"https://api.github.com/users/toqueteos","html_url":"https://github.com/toqueteos","followers_url":"https://api.github.com/users/toqueteos/followers","following_url":"https://api.github.com/users/toqueteos/following{/other_user}","gists_url":"https://api.github.com/users/toqueteos/gists{/gist_id}","starred_url":"https://api.github.com/users/toqueteos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toqueteos/subscriptions","organizations_url":"https://api.github.com/users/toqueteos/orgs","repos_url":"https://api.github.com/users/toqueteos/repos","events_url":"https://api.github.com/users/toqueteos/events{/privacy}","received_events_url":"https://api.github.com/users/toqueteos/received_events","type":"User","site_admin":false},"repo":{"id":30893661,"name":"hematite_server","full_name":"toqueteos/hematite_server","owner":{"login":"toqueteos","id":699969,"avatar_url":"https://avatars.githubusercontent.com/u/699969?v=3","gravatar_id":"","url":"https://api.github.com/users/toqueteos","html_url":"https://github.com/toqueteos","followers_url":"https://api.github.com/users/toqueteos/followers","following_url":"https://api.github.com/users/toqueteos/following{/other_user}","gists_url":"https://api.github.com/users/toqueteos/gists{/gist_id}","starred_url":"https://api.github.com/users/toqueteos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toqueteos/subscriptions","organizations_url":"https://api.github.com/users/toqueteos/orgs","repos_url":"https://api.github.com/users/toqueteos/repos","events_url":"https://api.github.com/users/toqueteos/events{/privacy}","received_events_url":"https://api.github.com/users/toqueteos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/toqueteos/hematite_server","description":"A Minecraft server clone","fork":true,"url":"https://api.github.com/repos/toqueteos/hematite_server","forks_url":"https://api.github.com/repos/toqueteos/hematite_server/forks","keys_url":"https://api.github.com/repos/toqueteos/hematite_server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toqueteos/hematite_server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toqueteos/hematite_server/teams","hooks_url":"https://api.github.com/repos/toqueteos/hematite_server/hooks","issue_events_url":"https://api.github.com/repos/toqueteos/hematite_server/issues/events{/number}","events_url":"https://api.github.com/repos/toqueteos/hematite_server/events","assignees_url":"https://api.github.com/repos/toqueteos/hematite_server/assignees{/user}","branches_url":"https://api.github.com/repos/toqueteos/hematite_server/branches{/branch}","tags_url":"https://api.github.com/repos/toqueteos/hematite_server/tags","blobs_url":"https://api.github.com/repos/toqueteos/hematite_server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toqueteos/hematite_server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toqueteos/hematite_server/git/refs{/sha}","trees_url":"https://api.github.com/repos/toqueteos/hematite_server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toqueteos/hematite_server/statuses/{sha}","languages_url":"https://api.github.com/repos/toqueteos/hematite_server/languages","stargazers_url":"https://api.github.com/repos/toqueteos/hematite_server/stargazers","contributors_url":"https://api.github.com/repos/toqueteos/hematite_server/contributors","subscribers_url":"https://api.github.com/repos/toqueteos/hematite_server/subscribers","subscription_url":"https://api.github.com/repos/toqueteos/hematite_server/subscription","commits_url":"https://api.github.com/repos/toqueteos/hematite_server/commits{/sha}","git_commits_url":"https://api.github.com/repos/toqueteos/hematite_server/git/commits{/sha}","comments_url":"https://api.github.com/repos/toqueteos/hematite_server/comments{/number}","issue_comment_url":"https://api.github.com/repos/toqueteos/hematite_server/issues/comments{/number}","contents_url":"https://api.github.com/repos/toqueteos/hematite_server/contents/{+path}","compare_url":"https://api.github.com/repos/toqueteos/hematite_server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toqueteos/hematite_server/merges","archive_url":"https://api.github.com/repos/toqueteos/hematite_server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toqueteos/hematite_server/downloads","issues_url":"https://api.github.com/repos/toqueteos/hematite_server/issues{/number}","pulls_url":"https://api.github.com/repos/toqueteos/hematite_server/pulls{/number}","milestones_url":"https://api.github.com/repos/toqueteos/hematite_server/milestones{/number}","notifications_url":"https://api.github.com/repos/toqueteos/hematite_server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toqueteos/hematite_server/labels{/name}","releases_url":"https://api.github.com/repos/toqueteos/hematite_server/releases{/id}","created_at":"2015-02-16T23:23:08Z","updated_at":"2015-03-10T15:54:55Z","pushed_at":"2015-03-11T20:02:28Z","git_url":"git://github.com/toqueteos/hematite_server.git","ssh_url":"git@github.com:toqueteos/hematite_server.git","clone_url":"https://github.com/toqueteos/hematite_server.git","svn_url":"https://github.com/toqueteos/hematite_server","homepage":null,"size":367,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PistonDevelopers:master","ref":"master","sha":"3c50c80b0d3f60f5cc9514ee8476655914c7a1f0","user":{"login":"PistonDevelopers","id":7623406,"avatar_url":"https://avatars.githubusercontent.com/u/7623406?v=3","gravatar_id":"","url":"https://api.github.com/users/PistonDevelopers","html_url":"https://github.com/PistonDevelopers","followers_url":"https://api.github.com/users/PistonDevelopers/followers","following_url":"https://api.github.com/users/PistonDevelopers/following{/other_user}","gists_url":"https://api.github.com/users/PistonDevelopers/gists{/gist_id}","starred_url":"https://api.github.com/users/PistonDevelopers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PistonDevelopers/subscriptions","organizations_url":"https://api.github.com/users/PistonDevelopers/orgs","repos_url":"https://api.github.com/users/PistonDevelopers/repos","events_url":"https://api.github.com/users/PistonDevelopers/events{/privacy}","received_events_url":"https://api.github.com/users/PistonDevelopers/received_events","type":"Organization","site_admin":false},"repo":{"id":29402029,"name":"hematite_server","full_name":"PistonDevelopers/hematite_server","owner":{"login":"PistonDevelopers","id":7623406,"avatar_url":"https://avatars.githubusercontent.com/u/7623406?v=3","gravatar_id":"","url":"https://api.github.com/users/PistonDevelopers","html_url":"https://github.com/PistonDevelopers","followers_url":"https://api.github.com/users/PistonDevelopers/followers","following_url":"https://api.github.com/users/PistonDevelopers/following{/other_user}","gists_url":"https://api.github.com/users/PistonDevelopers/gists{/gist_id}","starred_url":"https://api.github.com/users/PistonDevelopers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PistonDevelopers/subscriptions","organizations_url":"https://api.github.com/users/PistonDevelopers/orgs","repos_url":"https://api.github.com/users/PistonDevelopers/repos","events_url":"https://api.github.com/users/PistonDevelopers/events{/privacy}","received_events_url":"https://api.github.com/users/PistonDevelopers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PistonDevelopers/hematite_server","description":"A Minecraft server clone","fork":false,"url":"https://api.github.com/repos/PistonDevelopers/hematite_server","forks_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/forks","keys_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/teams","hooks_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/hooks","issue_events_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/issues/events{/number}","events_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/events","assignees_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/assignees{/user}","branches_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/branches{/branch}","tags_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/tags","blobs_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/git/refs{/sha}","trees_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/statuses/{sha}","languages_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/languages","stargazers_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/stargazers","contributors_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/contributors","subscribers_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/subscribers","subscription_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/subscription","commits_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/commits{/sha}","git_commits_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/git/commits{/sha}","comments_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/comments{/number}","issue_comment_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/issues/comments{/number}","contents_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/contents/{+path}","compare_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/merges","archive_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/downloads","issues_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/issues{/number}","pulls_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/pulls{/number}","milestones_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/milestones{/number}","notifications_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/labels{/name}","releases_url":"https://api.github.com/repos/PistonDevelopers/hematite_server/releases{/id}","created_at":"2015-01-17T19:02:55Z","updated_at":"2015-03-11T13:35:45Z","pushed_at":"2015-03-11T13:35:45Z","git_url":"git://github.com/PistonDevelopers/hematite_server.git","ssh_url":"git@github.com:PistonDevelopers/hematite_server.git","clone_url":"https://github.com/PistonDevelopers/hematite_server.git","svn_url":"https://github.com/PistonDevelopers/hematite_server","homepage":null,"size":652,"stargazers_count":11,"watchers_count":11,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":13,"forks":5,"open_issues":13,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PistonDevelopers/hematite_server/pulls/40"},"html":{"href":"https://github.com/PistonDevelopers/hematite_server/pull/40"},"issue":{"href":"https://api.github.com/repos/PistonDevelopers/hematite_server/issues/40"},"comments":{"href":"https://api.github.com/repos/PistonDevelopers/hematite_server/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/PistonDevelopers/hematite_server/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/PistonDevelopers/hematite_server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PistonDevelopers/hematite_server/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/PistonDevelopers/hematite_server/statuses/67c1fd97b204fe24acef5cddcb4a347dec682673"}}}}