{"action":"closed","number":26419,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/26419","id":38071935,"html_url":"https://github.com/rust-lang/rust/pull/26419","diff_url":"https://github.com/rust-lang/rust/pull/26419.diff","patch_url":"https://github.com/rust-lang/rust/pull/26419.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/26419","number":26419,"state":"closed","locked":false,"title":"Add proper parenting to ast_map","user":{"login":"nrc","id":762626,"avatar_url":"https://avatars.githubusercontent.com/u/762626?v=3","gravatar_id":"","url":"https://api.github.com/users/nrc","html_url":"https://github.com/nrc","followers_url":"https://api.github.com/users/nrc/followers","following_url":"https://api.github.com/users/nrc/following{/other_user}","gists_url":"https://api.github.com/users/nrc/gists{/gist_id}","starred_url":"https://api.github.com/users/nrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrc/subscriptions","organizations_url":"https://api.github.com/users/nrc/orgs","repos_url":"https://api.github.com/users/nrc/repos","events_url":"https://api.github.com/users/nrc/events{/privacy}","received_events_url":"https://api.github.com/users/nrc/received_events","type":"User","site_admin":false},"body":"This adds the parent node in the AST to the ast_map as well as the current, poorly defined parent which is roughly the parent item. Since this just rounds every ast_map entry to 128 bits, it shouldn't use any more memory (because they *should* be padded to that amount), at least on 64bit systems. The alternative is to only store the parent node and to calculate the parent item. But we need the parent item fairly frequently and I am wary about calculating it on the fly. I think go and use this information for save-analysis.\r\n\r\ncc @Manishearth, @rust-lang/compiler","created_at":"2015-06-19T02:25:35Z","updated_at":"2015-06-29T06:38:04Z","closed_at":"2015-06-29T06:38:04Z","merged_at":null,"merge_commit_sha":"c60cf075bf7a5be1f9be24cc995eb02e605a0d49","assignee":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars.githubusercontent.com/u/155238?v=3","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/26419/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/26419/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/26419/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/48be228ef351ee60bf1026160d904d748b43d962","head":{"label":"nrc:map-parent","ref":"map-parent","sha":"48be228ef351ee60bf1026160d904d748b43d962","user":{"login":"nrc","id":762626,"avatar_url":"https://avatars.githubusercontent.com/u/762626?v=3","gravatar_id":"","url":"https://api.github.com/users/nrc","html_url":"https://github.com/nrc","followers_url":"https://api.github.com/users/nrc/followers","following_url":"https://api.github.com/users/nrc/following{/other_user}","gists_url":"https://api.github.com/users/nrc/gists{/gist_id}","starred_url":"https://api.github.com/users/nrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrc/subscriptions","organizations_url":"https://api.github.com/users/nrc/orgs","repos_url":"https://api.github.com/users/nrc/repos","events_url":"https://api.github.com/users/nrc/events{/privacy}","received_events_url":"https://api.github.com/users/nrc/received_events","type":"User","site_admin":false},"repo":{"id":11998169,"name":"rust","full_name":"nrc/rust","owner":{"login":"nrc","id":762626,"avatar_url":"https://avatars.githubusercontent.com/u/762626?v=3","gravatar_id":"","url":"https://api.github.com/users/nrc","html_url":"https://github.com/nrc","followers_url":"https://api.github.com/users/nrc/followers","following_url":"https://api.github.com/users/nrc/following{/other_user}","gists_url":"https://api.github.com/users/nrc/gists{/gist_id}","starred_url":"https://api.github.com/users/nrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrc/subscriptions","organizations_url":"https://api.github.com/users/nrc/orgs","repos_url":"https://api.github.com/users/nrc/repos","events_url":"https://api.github.com/users/nrc/events{/privacy}","received_events_url":"https://api.github.com/users/nrc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nrc/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/nrc/rust","forks_url":"https://api.github.com/repos/nrc/rust/forks","keys_url":"https://api.github.com/repos/nrc/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nrc/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nrc/rust/teams","hooks_url":"https://api.github.com/repos/nrc/rust/hooks","issue_events_url":"https://api.github.com/repos/nrc/rust/issues/events{/number}","events_url":"https://api.github.com/repos/nrc/rust/events","assignees_url":"https://api.github.com/repos/nrc/rust/assignees{/user}","branches_url":"https://api.github.com/repos/nrc/rust/branches{/branch}","tags_url":"https://api.github.com/repos/nrc/rust/tags","blobs_url":"https://api.github.com/repos/nrc/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nrc/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nrc/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/nrc/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nrc/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/nrc/rust/languages","stargazers_url":"https://api.github.com/repos/nrc/rust/stargazers","contributors_url":"https://api.github.com/repos/nrc/rust/contributors","subscribers_url":"https://api.github.com/repos/nrc/rust/subscribers","subscription_url":"https://api.github.com/repos/nrc/rust/subscription","commits_url":"https://api.github.com/repos/nrc/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/nrc/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/nrc/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/nrc/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/nrc/rust/contents/{+path}","compare_url":"https://api.github.com/repos/nrc/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nrc/rust/merges","archive_url":"https://api.github.com/repos/nrc/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nrc/rust/downloads","issues_url":"https://api.github.com/repos/nrc/rust/issues{/number}","pulls_url":"https://api.github.com/repos/nrc/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/nrc/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/nrc/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nrc/rust/labels{/name}","releases_url":"https://api.github.com/repos/nrc/rust/releases{/id}","created_at":"2013-08-09T10:00:46Z","updated_at":"2015-04-23T20:46:35Z","pushed_at":"2015-06-23T06:09:26Z","git_url":"git://github.com/nrc/rust.git","ssh_url":"git@github.com:nrc/rust.git","clone_url":"https://github.com/nrc/rust.git","svn_url":"https://github.com/nrc/rust","homepage":"http://www.rust-lang.org","size":306528,"stargazers_count":1,"watchers_count":1,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"2f5683913c9815d9f12494784747f79b0f3b3066","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2015-06-29T05:18:21Z","pushed_at":"2015-06-29T05:37:49Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":636402,"stargazers_count":12404,"watchers_count":12404,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2383,"mirror_url":null,"open_issues_count":2135,"forks":2383,"open_issues":2135,"watchers":12404,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/26419"},"html":{"href":"https://github.com/rust-lang/rust/pull/26419"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/26419"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/26419/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/26419/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/26419/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/48be228ef351ee60bf1026160d904d748b43d962"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":6,"review_comments":0,"commits":2,"additions":170,"deletions":75,"changed_files":2}}