{"action":"created","comment":{"url":"https://api.github.com/repos/wpengine/hgv/pulls/comments/35120109","id":35120109,"diff_hunk":"@@ -1,6 +1,6 @@\n server {\n \tlisten          80;\n-\tserver_name     {% for i in domain %}{{ i }} {% endfor %};\n+\tserver_name     {% for i in domain %}{{ i }} {{ \"~^%s\\d+\\.\\d+\\.\\d+\\.\\d+\\.xip\\.io$\"|format(i|replace(\".dev\",\".\")|replace(\".\",\"\\.\")) }} {% endfor %};","path":"provisioning/roles/listener/templates/etc/nginx/wordpress.conf","position":null,"original_position":4,"commit_id":"362aec266a2771cab3434e5704ff3e3064dd178b","original_commit_id":"7599d8c36f80fe0ca75860a4c18a5d901152ae45","user":{"login":"zamoose","id":862531,"avatar_url":"https://avatars.githubusercontent.com/u/862531?v=3","gravatar_id":"","url":"https://api.github.com/users/zamoose","html_url":"https://github.com/zamoose","followers_url":"https://api.github.com/users/zamoose/followers","following_url":"https://api.github.com/users/zamoose/following{/other_user}","gists_url":"https://api.github.com/users/zamoose/gists{/gist_id}","starred_url":"https://api.github.com/users/zamoose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zamoose/subscriptions","organizations_url":"https://api.github.com/users/zamoose/orgs","repos_url":"https://api.github.com/users/zamoose/repos","events_url":"https://api.github.com/users/zamoose/events{/privacy}","received_events_url":"https://api.github.com/users/zamoose/received_events","type":"User","site_admin":false},"body":"Ahh, missed the updated commit. Yeah, that looks good. The `\\d` patterns will match any IP address octets, correct? \r\n\r\nI think there may be a missing `\\.` between the `%s` and the first `\\d`...\r\n\r\n`nslookup php.hgv.dev10.0.0.1.xip.io` results in\r\n\r\n```\r\nwinston:~ zamoose$ nslookup php.hgv.dev10.0.1.1.xip.io\r\nServer:\t\t10.0.0.1\r\nAddress:\t10.0.0.1#53\r\n\r\nNon-authoritative answer:\r\nName:\tphp.hgv.dev10.0.1.1.xip.io\r\nAddress: 1.0.0.0\r\n\r\nwinston:~ zamoose$\r\n```","created_at":"2015-07-21T16:03:11Z","updated_at":"2015-07-21T16:03:11Z","html_url":"https://github.com/wpengine/hgv/pull/199#discussion_r35120109","pull_request_url":"https://api.github.com/repos/wpengine/hgv/pulls/199","_links":{"self":{"href":"https://api.github.com/repos/wpengine/hgv/pulls/comments/35120109"},"html":{"href":"https://github.com/wpengine/hgv/pull/199#discussion_r35120109"},"pull_request":{"href":"https://api.github.com/repos/wpengine/hgv/pulls/199"}}},"pull_request":{"url":"https://api.github.com/repos/wpengine/hgv/pulls/199","id":40404245,"html_url":"https://github.com/wpengine/hgv/pull/199","diff_url":"https://github.com/wpengine/hgv/pull/199.diff","patch_url":"https://github.com/wpengine/hgv/pull/199.patch","issue_url":"https://api.github.com/repos/wpengine/hgv/issues/199","number":199,"state":"open","locked":false,"title":"Add support for xip.io service","user":{"login":"JPry","id":871924,"avatar_url":"https://avatars.githubusercontent.com/u/871924?v=3","gravatar_id":"","url":"https://api.github.com/users/JPry","html_url":"https://github.com/JPry","followers_url":"https://api.github.com/users/JPry/followers","following_url":"https://api.github.com/users/JPry/following{/other_user}","gists_url":"https://api.github.com/users/JPry/gists{/gist_id}","starred_url":"https://api.github.com/users/JPry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JPry/subscriptions","organizations_url":"https://api.github.com/users/JPry/orgs","repos_url":"https://api.github.com/users/JPry/repos","events_url":"https://api.github.com/users/JPry/events{/privacy}","received_events_url":"https://api.github.com/users/JPry/received_events","type":"User","site_admin":false},"body":"- [ ] @markkelnar\r\n- [ ] @ericmann\r\n\r\nVVV [recently](https://github.com/Varying-Vagrant-Vagrants/VVV/pull/449) added support for the [Xip.io](http://xip.io) service. This is extremely useful when attempting to access local development sites from other devices on the same network.\r\n\r\nTo test this change, do the following:\r\n\r\n* Check out the `xipio` branch from [my repo](http://github.com/JPry/hgv).\r\n* Create a file located in `~/.vagrant.d/Vagrantfile` with the following content:\r\n```\r\n# -*- mode: ruby -*-\r\n# vi: set ft=ruby :\r\n\r\nVagrant.configure(2) do |config|\r\n  # Set up with a Public network\r\n  config.vm.network :public_network\r\nend\r\n```\r\n* Run `vagrant reload --provision`\r\n* SSH to the vagrant, and determine the public IP address using `ifconfig`. My experience indicates that the `eth1` interface normally has the public IP, but your results may vary.\r\n* Connect to one of the default sites, adding `.<ip address>.xip.io` to the end of the domain name. In my testing, my IP was `192.168.1.22`, so the domain ended up being `php.hgv.dev.192.168.1.22.xip.io`.\r\n\r\nIf all goes well, you should see a WordPress site and be able to login and click around normally.","created_at":"2015-07-20T22:25:18Z","updated_at":"2015-07-21T16:03:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"889e4c351929e7c38bdfecd1e28b180730c16a77","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wpengine/hgv/pulls/199/commits","review_comments_url":"https://api.github.com/repos/wpengine/hgv/pulls/199/comments","review_comment_url":"https://api.github.com/repos/wpengine/hgv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wpengine/hgv/issues/199/comments","statuses_url":"https://api.github.com/repos/wpengine/hgv/statuses/362aec266a2771cab3434e5704ff3e3064dd178b","head":{"label":"JPry:xipio","ref":"xipio","sha":"362aec266a2771cab3434e5704ff3e3064dd178b","user":{"login":"JPry","id":871924,"avatar_url":"https://avatars.githubusercontent.com/u/871924?v=3","gravatar_id":"","url":"https://api.github.com/users/JPry","html_url":"https://github.com/JPry","followers_url":"https://api.github.com/users/JPry/followers","following_url":"https://api.github.com/users/JPry/following{/other_user}","gists_url":"https://api.github.com/users/JPry/gists{/gist_id}","starred_url":"https://api.github.com/users/JPry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JPry/subscriptions","organizations_url":"https://api.github.com/users/JPry/orgs","repos_url":"https://api.github.com/users/JPry/repos","events_url":"https://api.github.com/users/JPry/events{/privacy}","received_events_url":"https://api.github.com/users/JPry/received_events","type":"User","site_admin":false},"repo":{"id":29262304,"name":"hgv","full_name":"JPry/hgv","owner":{"login":"JPry","id":871924,"avatar_url":"https://avatars.githubusercontent.com/u/871924?v=3","gravatar_id":"","url":"https://api.github.com/users/JPry","html_url":"https://github.com/JPry","followers_url":"https://api.github.com/users/JPry/followers","following_url":"https://api.github.com/users/JPry/following{/other_user}","gists_url":"https://api.github.com/users/JPry/gists{/gist_id}","starred_url":"https://api.github.com/users/JPry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JPry/subscriptions","organizations_url":"https://api.github.com/users/JPry/orgs","repos_url":"https://api.github.com/users/JPry/repos","events_url":"https://api.github.com/users/JPry/events{/privacy}","received_events_url":"https://api.github.com/users/JPry/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JPry/hgv","description":"WP Engine's Mercury vagrant environment","fork":true,"url":"https://api.github.com/repos/JPry/hgv","forks_url":"https://api.github.com/repos/JPry/hgv/forks","keys_url":"https://api.github.com/repos/JPry/hgv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JPry/hgv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JPry/hgv/teams","hooks_url":"https://api.github.com/repos/JPry/hgv/hooks","issue_events_url":"https://api.github.com/repos/JPry/hgv/issues/events{/number}","events_url":"https://api.github.com/repos/JPry/hgv/events","assignees_url":"https://api.github.com/repos/JPry/hgv/assignees{/user}","branches_url":"https://api.github.com/repos/JPry/hgv/branches{/branch}","tags_url":"https://api.github.com/repos/JPry/hgv/tags","blobs_url":"https://api.github.com/repos/JPry/hgv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JPry/hgv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JPry/hgv/git/refs{/sha}","trees_url":"https://api.github.com/repos/JPry/hgv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JPry/hgv/statuses/{sha}","languages_url":"https://api.github.com/repos/JPry/hgv/languages","stargazers_url":"https://api.github.com/repos/JPry/hgv/stargazers","contributors_url":"https://api.github.com/repos/JPry/hgv/contributors","subscribers_url":"https://api.github.com/repos/JPry/hgv/subscribers","subscription_url":"https://api.github.com/repos/JPry/hgv/subscription","commits_url":"https://api.github.com/repos/JPry/hgv/commits{/sha}","git_commits_url":"https://api.github.com/repos/JPry/hgv/git/commits{/sha}","comments_url":"https://api.github.com/repos/JPry/hgv/comments{/number}","issue_comment_url":"https://api.github.com/repos/JPry/hgv/issues/comments{/number}","contents_url":"https://api.github.com/repos/JPry/hgv/contents/{+path}","compare_url":"https://api.github.com/repos/JPry/hgv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JPry/hgv/merges","archive_url":"https://api.github.com/repos/JPry/hgv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JPry/hgv/downloads","issues_url":"https://api.github.com/repos/JPry/hgv/issues{/number}","pulls_url":"https://api.github.com/repos/JPry/hgv/pulls{/number}","milestones_url":"https://api.github.com/repos/JPry/hgv/milestones{/number}","notifications_url":"https://api.github.com/repos/JPry/hgv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JPry/hgv/labels{/name}","releases_url":"https://api.github.com/repos/JPry/hgv/releases{/id}","created_at":"2015-01-14T19:44:06Z","updated_at":"2015-01-14T19:44:06Z","pushed_at":"2015-07-21T13:10:12Z","git_url":"git://github.com/JPry/hgv.git","ssh_url":"git@github.com:JPry/hgv.git","clone_url":"https://github.com/JPry/hgv.git","svn_url":"https://github.com/JPry/hgv","homepage":"http://wpengine.com/mercury","size":478,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wpengine:develop","ref":"develop","sha":"177cd6ba791051342150e1c7c6149556af4c3bfd","user":{"login":"wpengine","id":749191,"avatar_url":"https://avatars.githubusercontent.com/u/749191?v=3","gravatar_id":"","url":"https://api.github.com/users/wpengine","html_url":"https://github.com/wpengine","followers_url":"https://api.github.com/users/wpengine/followers","following_url":"https://api.github.com/users/wpengine/following{/other_user}","gists_url":"https://api.github.com/users/wpengine/gists{/gist_id}","starred_url":"https://api.github.com/users/wpengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wpengine/subscriptions","organizations_url":"https://api.github.com/users/wpengine/orgs","repos_url":"https://api.github.com/users/wpengine/repos","events_url":"https://api.github.com/users/wpengine/events{/privacy}","received_events_url":"https://api.github.com/users/wpengine/received_events","type":"Organization","site_admin":false},"repo":{"id":28054492,"name":"hgv","full_name":"wpengine/hgv","owner":{"login":"wpengine","id":749191,"avatar_url":"https://avatars.githubusercontent.com/u/749191?v=3","gravatar_id":"","url":"https://api.github.com/users/wpengine","html_url":"https://github.com/wpengine","followers_url":"https://api.github.com/users/wpengine/followers","following_url":"https://api.github.com/users/wpengine/following{/other_user}","gists_url":"https://api.github.com/users/wpengine/gists{/gist_id}","starred_url":"https://api.github.com/users/wpengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wpengine/subscriptions","organizations_url":"https://api.github.com/users/wpengine/orgs","repos_url":"https://api.github.com/users/wpengine/repos","events_url":"https://api.github.com/users/wpengine/events{/privacy}","received_events_url":"https://api.github.com/users/wpengine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wpengine/hgv","description":"WP Engine's Mercury vagrant environment","fork":false,"url":"https://api.github.com/repos/wpengine/hgv","forks_url":"https://api.github.com/repos/wpengine/hgv/forks","keys_url":"https://api.github.com/repos/wpengine/hgv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wpengine/hgv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wpengine/hgv/teams","hooks_url":"https://api.github.com/repos/wpengine/hgv/hooks","issue_events_url":"https://api.github.com/repos/wpengine/hgv/issues/events{/number}","events_url":"https://api.github.com/repos/wpengine/hgv/events","assignees_url":"https://api.github.com/repos/wpengine/hgv/assignees{/user}","branches_url":"https://api.github.com/repos/wpengine/hgv/branches{/branch}","tags_url":"https://api.github.com/repos/wpengine/hgv/tags","blobs_url":"https://api.github.com/repos/wpengine/hgv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wpengine/hgv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wpengine/hgv/git/refs{/sha}","trees_url":"https://api.github.com/repos/wpengine/hgv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wpengine/hgv/statuses/{sha}","languages_url":"https://api.github.com/repos/wpengine/hgv/languages","stargazers_url":"https://api.github.com/repos/wpengine/hgv/stargazers","contributors_url":"https://api.github.com/repos/wpengine/hgv/contributors","subscribers_url":"https://api.github.com/repos/wpengine/hgv/subscribers","subscription_url":"https://api.github.com/repos/wpengine/hgv/subscription","commits_url":"https://api.github.com/repos/wpengine/hgv/commits{/sha}","git_commits_url":"https://api.github.com/repos/wpengine/hgv/git/commits{/sha}","comments_url":"https://api.github.com/repos/wpengine/hgv/comments{/number}","issue_comment_url":"https://api.github.com/repos/wpengine/hgv/issues/comments{/number}","contents_url":"https://api.github.com/repos/wpengine/hgv/contents/{+path}","compare_url":"https://api.github.com/repos/wpengine/hgv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wpengine/hgv/merges","archive_url":"https://api.github.com/repos/wpengine/hgv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wpengine/hgv/downloads","issues_url":"https://api.github.com/repos/wpengine/hgv/issues{/number}","pulls_url":"https://api.github.com/repos/wpengine/hgv/pulls{/number}","milestones_url":"https://api.github.com/repos/wpengine/hgv/milestones{/number}","notifications_url":"https://api.github.com/repos/wpengine/hgv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wpengine/hgv/labels{/name}","releases_url":"https://api.github.com/repos/wpengine/hgv/releases{/id}","created_at":"2014-12-15T20:22:40Z","updated_at":"2015-07-20T23:41:41Z","pushed_at":"2015-07-21T13:10:12Z","git_url":"git://github.com/wpengine/hgv.git","ssh_url":"git@github.com:wpengine/hgv.git","clone_url":"https://github.com/wpengine/hgv.git","svn_url":"https://github.com/wpengine/hgv","homepage":"http://wpengine.com/mercury","size":1602,"stargazers_count":205,"watchers_count":205,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":32,"forks":35,"open_issues":32,"watchers":205,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wpengine/hgv/pulls/199"},"html":{"href":"https://github.com/wpengine/hgv/pull/199"},"issue":{"href":"https://api.github.com/repos/wpengine/hgv/issues/199"},"comments":{"href":"https://api.github.com/repos/wpengine/hgv/issues/199/comments"},"review_comments":{"href":"https://api.github.com/repos/wpengine/hgv/pulls/199/comments"},"review_comment":{"href":"https://api.github.com/repos/wpengine/hgv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wpengine/hgv/pulls/199/commits"},"statuses":{"href":"https://api.github.com/repos/wpengine/hgv/statuses/362aec266a2771cab3434e5704ff3e3064dd178b"}}}}