{"action":"created","comment":{"url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/pulls/comments/47551218","id":47551218,"diff_hunk":"@@ -125,43 +143,45 @@ module.exports.validateBucket = function(s3, ui) {\n  */\n module.exports.uploadDirectory = function(s3, ui, dir, options) {\n   var prependPath = s3.config.prependPath || '';\n-  var timeOut = s3.config.timeOut || 0;\n-  var maxRetries = s3.config.maxRetries || 1;\n-\n-  return fileTool.readDirectory(dir)\n-    .then(function(files) {\n-\n-      var bucketPath =  !!prependPath ?\n-                        s3.config.params.Bucket + '/' + prependPath :\n-                        s3.config.params.Bucket;\n-\n-      ui.pleasantProgress.start(chalk.green('Uploading files to ') +\n-        bucketPath, chalk.green('.'));\n-\n-      var promise = Promise.resolve();\n-\n-      files.forEach(function(file) {\n-        var filePath = path.join(prependPath, file.path);\n-\n-        var params = buildFileParameters(file.fullPath, {\n-          Key: filePath,\n-          ContentLength: file.stat.size\n-        });\n-\n-        promise = promise.then(\n-          module.exports.uploadFile(s3, ui, file.fullPath, params)\n-        ).then(function() {\n-\n-        });\n+  //var timeOut = s3.config.timeOut || 0;\n+  //var maxRetries = s3.config.maxRetries || 1;","path":"lib/utils/s3-tool.js","position":107,"original_position":107,"commit_id":"cab4d309d21d51eeb9e123d75e07050a1460484a","original_commit_id":"cab4d309d21d51eeb9e123d75e07050a1460484a","user":{"login":"joebartels","id":1977709,"avatar_url":"https://avatars.githubusercontent.com/u/1977709?v=3","gravatar_id":"","url":"https://api.github.com/users/joebartels","html_url":"https://github.com/joebartels","followers_url":"https://api.github.com/users/joebartels/followers","following_url":"https://api.github.com/users/joebartels/following{/other_user}","gists_url":"https://api.github.com/users/joebartels/gists{/gist_id}","starred_url":"https://api.github.com/users/joebartels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joebartels/subscriptions","organizations_url":"https://api.github.com/users/joebartels/orgs","repos_url":"https://api.github.com/users/joebartels/repos","events_url":"https://api.github.com/users/joebartels/events{/privacy}","received_events_url":"https://api.github.com/users/joebartels/received_events","type":"User","site_admin":false},"body":"should acknowledge `s3.config.maxRetries` to avoid infinitely trying a file.","created_at":"2015-12-14T20:13:23Z","updated_at":"2015-12-14T20:13:23Z","html_url":"https://github.com/Vestorly/ember-cli-s3-sync/pull/28#discussion_r47551218","pull_request_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/pulls/comments/47551218"},"html":{"href":"https://github.com/Vestorly/ember-cli-s3-sync/pull/28#discussion_r47551218"},"pull_request":{"href":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/pulls/28","id":48872779,"html_url":"https://github.com/Vestorly/ember-cli-s3-sync/pull/28","diff_url":"https://github.com/Vestorly/ember-cli-s3-sync/pull/28.diff","patch_url":"https://github.com/Vestorly/ember-cli-s3-sync/pull/28.patch","issue_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/issues/28","number":28,"state":"open","locked":false,"title":"recover from unsuccessful file uploads ","user":{"login":"smashweaver","id":68107,"avatar_url":"https://avatars.githubusercontent.com/u/68107?v=3","gravatar_id":"","url":"https://api.github.com/users/smashweaver","html_url":"https://github.com/smashweaver","followers_url":"https://api.github.com/users/smashweaver/followers","following_url":"https://api.github.com/users/smashweaver/following{/other_user}","gists_url":"https://api.github.com/users/smashweaver/gists{/gist_id}","starred_url":"https://api.github.com/users/smashweaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smashweaver/subscriptions","organizations_url":"https://api.github.com/users/smashweaver/orgs","repos_url":"https://api.github.com/users/smashweaver/repos","events_url":"https://api.github.com/users/smashweaver/events{/privacy}","received_events_url":"https://api.github.com/users/smashweaver/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-27T13:51:46Z","updated_at":"2015-12-14T20:13:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"71830edd5c5cb73eec5fa59edfeb5db13b16edb7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/pulls/28/commits","review_comments_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/pulls/28/comments","review_comment_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/issues/28/comments","statuses_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/statuses/cab4d309d21d51eeb9e123d75e07050a1460484a","head":{"label":"smashweaver:master","ref":"master","sha":"cab4d309d21d51eeb9e123d75e07050a1460484a","user":{"login":"smashweaver","id":68107,"avatar_url":"https://avatars.githubusercontent.com/u/68107?v=3","gravatar_id":"","url":"https://api.github.com/users/smashweaver","html_url":"https://github.com/smashweaver","followers_url":"https://api.github.com/users/smashweaver/followers","following_url":"https://api.github.com/users/smashweaver/following{/other_user}","gists_url":"https://api.github.com/users/smashweaver/gists{/gist_id}","starred_url":"https://api.github.com/users/smashweaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smashweaver/subscriptions","organizations_url":"https://api.github.com/users/smashweaver/orgs","repos_url":"https://api.github.com/users/smashweaver/repos","events_url":"https://api.github.com/users/smashweaver/events{/privacy}","received_events_url":"https://api.github.com/users/smashweaver/received_events","type":"User","site_admin":false},"repo":{"id":44965243,"name":"ember-cli-s3-sync","full_name":"smashweaver/ember-cli-s3-sync","owner":{"login":"smashweaver","id":68107,"avatar_url":"https://avatars.githubusercontent.com/u/68107?v=3","gravatar_id":"","url":"https://api.github.com/users/smashweaver","html_url":"https://github.com/smashweaver","followers_url":"https://api.github.com/users/smashweaver/followers","following_url":"https://api.github.com/users/smashweaver/following{/other_user}","gists_url":"https://api.github.com/users/smashweaver/gists{/gist_id}","starred_url":"https://api.github.com/users/smashweaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smashweaver/subscriptions","organizations_url":"https://api.github.com/users/smashweaver/orgs","repos_url":"https://api.github.com/users/smashweaver/repos","events_url":"https://api.github.com/users/smashweaver/events{/privacy}","received_events_url":"https://api.github.com/users/smashweaver/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smashweaver/ember-cli-s3-sync","description":"A customizable tool for deploying your Ember app to Amazon's S3.","fork":true,"url":"https://api.github.com/repos/smashweaver/ember-cli-s3-sync","forks_url":"https://api.github.com/repos/smashweaver/ember-cli-s3-sync/forks","keys_url":"https://api.github.com/repos/smashweaver/ember-cli-s3-sync/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smashweaver/ember-cli-s3-sync/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smashweaver/ember-cli-s3-sync/teams","hooks_url":"https://api.github.com/repos/smashweaver/ember-cli-s3-sync/hooks","issue_events_url":"https://api.github.com/repos/smashweaver/ember-cli-s3-sync/issues/events{/number}","events_url":"https://api.github.com/repos/smashweaver/ember-cli-s3-sync/events","assignees_url":"https://api.github.com/repos/smashweaver/ember-cli-s3-sync/assignees{/user}","branches_url":"https://api.github.com/repos/smashweaver/ember-cli-s3-sync/branches{/branch}","tags_url":"https://api.github.com/repos/smashweaver/ember-cli-s3-sync/tags","blobs_url":"https://api.github.com/repos/smashweaver/ember-cli-s3-sync/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smashweaver/ember-cli-s3-sync/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smashweaver/ember-cli-s3-sync/git/refs{/sha}","trees_url":"https://api.github.com/repos/smashweaver/ember-cli-s3-sync/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smashweaver/ember-cli-s3-sync/statuses/{sha}","languages_url":"https://api.github.com/repos/smashweaver/ember-cli-s3-sync/languages","stargazers_url":"https://api.github.com/repos/smashweaver/ember-cli-s3-sync/stargazers","contributors_url":"https://api.github.com/repos/smashweaver/ember-cli-s3-sync/contributors","subscribers_url":"https://api.github.com/repos/smashweaver/ember-cli-s3-sync/subscribers","subscription_url":"https://api.github.com/repos/smashweaver/ember-cli-s3-sync/subscription","commits_url":"https://api.github.com/repos/smashweaver/ember-cli-s3-sync/commits{/sha}","git_commits_url":"https://api.github.com/repos/smashweaver/ember-cli-s3-sync/git/commits{/sha}","comments_url":"https://api.github.com/repos/smashweaver/ember-cli-s3-sync/comments{/number}","issue_comment_url":"https://api.github.com/repos/smashweaver/ember-cli-s3-sync/issues/comments{/number}","contents_url":"https://api.github.com/repos/smashweaver/ember-cli-s3-sync/contents/{+path}","compare_url":"https://api.github.com/repos/smashweaver/ember-cli-s3-sync/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smashweaver/ember-cli-s3-sync/merges","archive_url":"https://api.github.com/repos/smashweaver/ember-cli-s3-sync/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smashweaver/ember-cli-s3-sync/downloads","issues_url":"https://api.github.com/repos/smashweaver/ember-cli-s3-sync/issues{/number}","pulls_url":"https://api.github.com/repos/smashweaver/ember-cli-s3-sync/pulls{/number}","milestones_url":"https://api.github.com/repos/smashweaver/ember-cli-s3-sync/milestones{/number}","notifications_url":"https://api.github.com/repos/smashweaver/ember-cli-s3-sync/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smashweaver/ember-cli-s3-sync/labels{/name}","releases_url":"https://api.github.com/repos/smashweaver/ember-cli-s3-sync/releases{/id}","created_at":"2015-10-26T11:51:51Z","updated_at":"2015-10-26T11:51:52Z","pushed_at":"2015-12-09T11:32:07Z","git_url":"git://github.com/smashweaver/ember-cli-s3-sync.git","ssh_url":"git@github.com:smashweaver/ember-cli-s3-sync.git","clone_url":"https://github.com/smashweaver/ember-cli-s3-sync.git","svn_url":"https://github.com/smashweaver/ember-cli-s3-sync","homepage":"http://vestorly.github.io/","size":101,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Vestorly:master","ref":"master","sha":"c7b1fe6304ab43964dbc634c72b7551b36d1ddea","user":{"login":"Vestorly","id":1341524,"avatar_url":"https://avatars.githubusercontent.com/u/1341524?v=3","gravatar_id":"","url":"https://api.github.com/users/Vestorly","html_url":"https://github.com/Vestorly","followers_url":"https://api.github.com/users/Vestorly/followers","following_url":"https://api.github.com/users/Vestorly/following{/other_user}","gists_url":"https://api.github.com/users/Vestorly/gists{/gist_id}","starred_url":"https://api.github.com/users/Vestorly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vestorly/subscriptions","organizations_url":"https://api.github.com/users/Vestorly/orgs","repos_url":"https://api.github.com/users/Vestorly/repos","events_url":"https://api.github.com/users/Vestorly/events{/privacy}","received_events_url":"https://api.github.com/users/Vestorly/received_events","type":"Organization","site_admin":false},"repo":{"id":25476544,"name":"ember-cli-s3-sync","full_name":"Vestorly/ember-cli-s3-sync","owner":{"login":"Vestorly","id":1341524,"avatar_url":"https://avatars.githubusercontent.com/u/1341524?v=3","gravatar_id":"","url":"https://api.github.com/users/Vestorly","html_url":"https://github.com/Vestorly","followers_url":"https://api.github.com/users/Vestorly/followers","following_url":"https://api.github.com/users/Vestorly/following{/other_user}","gists_url":"https://api.github.com/users/Vestorly/gists{/gist_id}","starred_url":"https://api.github.com/users/Vestorly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vestorly/subscriptions","organizations_url":"https://api.github.com/users/Vestorly/orgs","repos_url":"https://api.github.com/users/Vestorly/repos","events_url":"https://api.github.com/users/Vestorly/events{/privacy}","received_events_url":"https://api.github.com/users/Vestorly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Vestorly/ember-cli-s3-sync","description":"A customizable tool for deploying your Ember app to Amazon's S3.","fork":false,"url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync","forks_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/forks","keys_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/teams","hooks_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/hooks","issue_events_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/issues/events{/number}","events_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/events","assignees_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/assignees{/user}","branches_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/branches{/branch}","tags_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/tags","blobs_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/git/refs{/sha}","trees_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/statuses/{sha}","languages_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/languages","stargazers_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/stargazers","contributors_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/contributors","subscribers_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/subscribers","subscription_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/subscription","commits_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/commits{/sha}","git_commits_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/git/commits{/sha}","comments_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/comments{/number}","issue_comment_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/issues/comments{/number}","contents_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/contents/{+path}","compare_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/merges","archive_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/downloads","issues_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/issues{/number}","pulls_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/pulls{/number}","milestones_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/milestones{/number}","notifications_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/labels{/name}","releases_url":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/releases{/id}","created_at":"2014-10-20T16:55:23Z","updated_at":"2015-11-05T23:44:22Z","pushed_at":"2015-12-09T11:32:08Z","git_url":"git://github.com/Vestorly/ember-cli-s3-sync.git","ssh_url":"git@github.com:Vestorly/ember-cli-s3-sync.git","clone_url":"https://github.com/Vestorly/ember-cli-s3-sync.git","svn_url":"https://github.com/Vestorly/ember-cli-s3-sync","homepage":"http://vestorly.github.io/","size":101,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":6,"forks":4,"open_issues":6,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/pulls/28"},"html":{"href":"https://github.com/Vestorly/ember-cli-s3-sync/pull/28"},"issue":{"href":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/issues/28"},"comments":{"href":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/Vestorly/ember-cli-s3-sync/statuses/cab4d309d21d51eeb9e123d75e07050a1460484a"}}}}