{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/45072137","id":45072137,"diff_hunk":"@@ -247,6 +248,14 @@ ports:\n \n This rule maintains the invariant that all JSON/YAML keys are fields in API objects. The only exceptions are pure maps in the API (currently, labels, selectors, annotations, data), as opposed to sets of subobjects.\n \n+#### Primitive types\n+\n+* Avoid floating-point values as much as possible, and never use them in spec. Floating-point values cannot be reliably round-tripped (encoded and re-decoded) without changing, and have varying precision and representations across languages and architectures.\n+* Do not use unsigned integers. Similarly, not all languages (e.g., Javascript) support unsigned integers.\n+* int64 is converted to float by Javascript and some other languages, so they also need to be accepted as strings.","path":"docs/devel/api-conventions.md","position":16,"original_position":16,"commit_id":"0141c531136ca679c497200bd27b96b25650742d","original_commit_id":"0141c531136ca679c497200bd27b96b25650742d","user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"body":"all numbers are converted to float64 by [...], so any number which is expected to exceed that (specifically int values > 53 bits) should be serialized and accepted as strings","created_at":"2015-11-17T15:22:44Z","updated_at":"2015-11-17T15:22:44Z","html_url":"https://github.com/kubernetes/kubernetes/pull/17377#discussion_r45072137","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17377","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/45072137"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/17377#discussion_r45072137"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17377"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17377","id":50959491,"html_url":"https://github.com/kubernetes/kubernetes/pull/17377","diff_url":"https://github.com/kubernetes/kubernetes/pull/17377.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/17377.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/17377","number":17377,"state":"open","locked":false,"title":"Add conventions about primitive types.","user":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-11-17T15:19:43Z","updated_at":"2015-11-17T15:22:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e0b11482ebb9da068b327249d146d2582ab650f","assignee":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17377/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17377/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/17377/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/0141c531136ca679c497200bd27b96b25650742d","head":{"label":"bgrant0607:docfix2","ref":"docfix2","sha":"0141c531136ca679c497200bd27b96b25650742d","user":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"repo":{"id":23933470,"name":"kubernetes","full_name":"bgrant0607/kubernetes","owner":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bgrant0607/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/bgrant0607/kubernetes","forks_url":"https://api.github.com/repos/bgrant0607/kubernetes/forks","keys_url":"https://api.github.com/repos/bgrant0607/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bgrant0607/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bgrant0607/kubernetes/teams","hooks_url":"https://api.github.com/repos/bgrant0607/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/bgrant0607/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/bgrant0607/kubernetes/events","assignees_url":"https://api.github.com/repos/bgrant0607/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/bgrant0607/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/bgrant0607/kubernetes/tags","blobs_url":"https://api.github.com/repos/bgrant0607/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bgrant0607/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bgrant0607/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/bgrant0607/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bgrant0607/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/bgrant0607/kubernetes/languages","stargazers_url":"https://api.github.com/repos/bgrant0607/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/bgrant0607/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/bgrant0607/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/bgrant0607/kubernetes/subscription","commits_url":"https://api.github.com/repos/bgrant0607/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/bgrant0607/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/bgrant0607/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/bgrant0607/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/bgrant0607/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/bgrant0607/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bgrant0607/kubernetes/merges","archive_url":"https://api.github.com/repos/bgrant0607/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bgrant0607/kubernetes/downloads","issues_url":"https://api.github.com/repos/bgrant0607/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/bgrant0607/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/bgrant0607/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/bgrant0607/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bgrant0607/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/bgrant0607/kubernetes/releases{/id}","created_at":"2014-09-11T19:55:59Z","updated_at":"2015-11-01T20:45:38Z","pushed_at":"2015-11-17T15:19:09Z","git_url":"git://github.com/bgrant0607/kubernetes.git","ssh_url":"git@github.com:bgrant0607/kubernetes.git","clone_url":"https://github.com/bgrant0607/kubernetes.git","svn_url":"https://github.com/bgrant0607/kubernetes","homepage":null,"size":136158,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"cd236c32c8746439f96cd1c3e126f60f1f06372b","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-11-17T14:36:49Z","pushed_at":"2015-11-17T15:19:44Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":286687,"stargazers_count":11303,"watchers_count":11303,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2979,"mirror_url":null,"open_issues_count":2321,"forks":2979,"open_issues":2321,"watchers":11303,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17377"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/17377"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/17377"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/17377/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17377/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17377/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/0141c531136ca679c497200bd27b96b25650742d"}}}}