{"action":"created","issue":{"url":"https://api.github.com/repos/sysown/proxysql-0.2/issues/306","labels_url":"https://api.github.com/repos/sysown/proxysql-0.2/issues/306/labels{/name}","comments_url":"https://api.github.com/repos/sysown/proxysql-0.2/issues/306/comments","events_url":"https://api.github.com/repos/sysown/proxysql-0.2/issues/306/events","html_url":"https://github.com/sysown/proxysql-0.2/issues/306","id":92044480,"number":306,"title":"Make test credentials configurable","user":{"login":"aismail","id":82345,"avatar_url":"https://avatars.githubusercontent.com/u/82345?v=3","gravatar_id":"","url":"https://api.github.com/users/aismail","html_url":"https://github.com/aismail","followers_url":"https://api.github.com/users/aismail/followers","following_url":"https://api.github.com/users/aismail/following{/other_user}","gists_url":"https://api.github.com/users/aismail/gists{/gist_id}","starred_url":"https://api.github.com/users/aismail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aismail/subscriptions","organizations_url":"https://api.github.com/users/aismail/orgs","repos_url":"https://api.github.com/users/aismail/repos","events_url":"https://api.github.com/users/aismail/events{/privacy}","received_events_url":"https://api.github.com/users/aismail/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-30T09:43:38Z","updated_at":"2015-07-07T08:48:04Z","closed_at":"2015-07-07T08:48:04Z","body":"## Why\r\n\r\nRight now, tests contain hardcoded credentials, including the proxysql e-mail address from which the notifications are being sent. Hardcoded credentials and variables are bad because it's hard to modify them and sometimes even a security risk if they are stored in the repo.\r\n\r\n## What\r\n* [x] all hardcoded variables are extracted in a configuration file, and that configuration file is used throughout the code\r\n* [x] a sample configuration file with most options (which are not security-senstive) is created\r\n* [x] ProxySQL e-mail address password is changed and relayed to @renecannao \r\n\r\n## Notes\r\nMake sure that tests are still working correctly after implementing this test-wide change!\r\n"},"comment":{"url":"https://api.github.com/repos/sysown/proxysql-0.2/issues/comments/119125742","html_url":"https://github.com/sysown/proxysql-0.2/issues/306#issuecomment-119125742","issue_url":"https://api.github.com/repos/sysown/proxysql-0.2/issues/306","id":119125742,"user":{"login":"aismail","id":82345,"avatar_url":"https://avatars.githubusercontent.com/u/82345?v=3","gravatar_id":"","url":"https://api.github.com/users/aismail","html_url":"https://github.com/aismail","followers_url":"https://api.github.com/users/aismail/followers","following_url":"https://api.github.com/users/aismail/following{/other_user}","gists_url":"https://api.github.com/users/aismail/gists{/gist_id}","starred_url":"https://api.github.com/users/aismail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aismail/subscriptions","organizations_url":"https://api.github.com/users/aismail/orgs","repos_url":"https://api.github.com/users/aismail/repos","events_url":"https://api.github.com/users/aismail/events{/privacy}","received_events_url":"https://api.github.com/users/aismail/received_events","type":"User","site_admin":false},"created_at":"2015-07-07T08:48:04Z","updated_at":"2015-07-07T08:48:04Z","body":"Finished this in https://github.com/sysown/proxysql-0.2/pull/308"}}