{"action":"created","issue":{"url":"https://api.github.com/repos/rvagg/nan/issues/246","labels_url":"https://api.github.com/repos/rvagg/nan/issues/246/labels{/name}","comments_url":"https://api.github.com/repos/rvagg/nan/issues/246/comments","events_url":"https://api.github.com/repos/rvagg/nan/issues/246/events","html_url":"https://github.com/rvagg/nan/issues/246","id":54706093,"number":246,"title":"NanNew<v8::String>(char) compiler warning help","user":{"login":"mathiask88","id":4368785,"avatar_url":"https://avatars.githubusercontent.com/u/4368785?v=3","gravatar_id":"","url":"https://api.github.com/users/mathiask88","html_url":"https://github.com/mathiask88","followers_url":"https://api.github.com/users/mathiask88/followers","following_url":"https://api.github.com/users/mathiask88/following{/other_user}","gists_url":"https://api.github.com/users/mathiask88/gists{/gist_id}","starred_url":"https://api.github.com/users/mathiask88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathiask88/subscriptions","organizations_url":"https://api.github.com/users/mathiask88/orgs","repos_url":"https://api.github.com/users/mathiask88/repos","events_url":"https://api.github.com/users/mathiask88/events{/privacy}","received_events_url":"https://api.github.com/users/mathiask88/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-01-18T19:00:30Z","updated_at":"2015-01-19T08:32:37Z","closed_at":null,"body":"Hi,\r\n\r\nI need some help understanding the warning AppVeyor/MSVC is complaining about:\r\n```\r\n..\\src\\node_snap7_client.cpp(909): warning C4344: behavior change: use of explicit template arguments results in call to 'v8::Local<T> NanNew<v8::String,char*>(A0)' [C:\\projects\\node-snap7\\build\\node_snap7.vcxproj]\r\n          with\r\n          [\r\n              T=v8::String,\r\n              A0=char *\r\n          ]\r\n          but the regular function 'v8::Local<T> NanNew(const char *)' is a better match\r\n          with\r\n          [\r\n              T=v8::String\r\n          ]\r\n          if you expect 'v8::Local<T> NanNew(const char *)' to be called then you need to make it an explicit specialization\r\n          with\r\n          [\r\n              T=v8::String\r\n          ]\r\n```\r\n\r\nLine 909 is ```NanNew<v8::String>(BlockInfo->CodeDate));``` where ```BlockInfo->CodeDate``` is a ```char[11] *```."},"comment":{"url":"https://api.github.com/repos/rvagg/nan/issues/comments/70459980","html_url":"https://github.com/rvagg/nan/issues/246#issuecomment-70459980","issue_url":"https://api.github.com/repos/rvagg/nan/issues/246","id":70459980,"user":{"login":"mathiask88","id":4368785,"avatar_url":"https://avatars.githubusercontent.com/u/4368785?v=3","gravatar_id":"","url":"https://api.github.com/users/mathiask88","html_url":"https://github.com/mathiask88","followers_url":"https://api.github.com/users/mathiask88/followers","following_url":"https://api.github.com/users/mathiask88/following{/other_user}","gists_url":"https://api.github.com/users/mathiask88/gists{/gist_id}","starred_url":"https://api.github.com/users/mathiask88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathiask88/subscriptions","organizations_url":"https://api.github.com/users/mathiask88/orgs","repos_url":"https://api.github.com/users/mathiask88/repos","events_url":"https://api.github.com/users/mathiask88/events{/privacy}","received_events_url":"https://api.github.com/users/mathiask88/received_events","type":"User","site_admin":false},"created_at":"2015-01-19T08:32:37Z","updated_at":"2015-01-19T08:32:37Z","body":">>I need some help understanding the warning [...] MSVC is complaining about\r\n\r\n>Hehe... you're not alone. I need that on a t-shirt.\r\n\r\n:grin:\r\n\r\n>>But why is AppVeyor throwing the warnings and my VS not?\r\n\r\n>Good question. I have no idea. Are you using the exact same commands on your desktop? Like: Opening the project file in VS might trigger different behavior than calling node-gyp on the command line. On the other hand this is a level 1 warning. So, no... no clue... :-/\r\n\r\nYes I triggered the build with ```node-gyp configure build``` in the command promt. True, this warning is level 1 and the compiler is set to /W3. So no idea where the difference comes from. Maybe the MsBuild version differs after all.\r\n\r\nThanks for your explanation!"}}