{"action":"created","issue":{"url":"https://api.github.com/repos/dillbyrne/random-agent-spoofer/issues/151","labels_url":"https://api.github.com/repos/dillbyrne/random-agent-spoofer/issues/151/labels{/name}","comments_url":"https://api.github.com/repos/dillbyrne/random-agent-spoofer/issues/151/comments","events_url":"https://api.github.com/repos/dillbyrne/random-agent-spoofer/issues/151/events","html_url":"https://github.com/dillbyrne/random-agent-spoofer/issues/151","id":59428829,"number":151,"title":"RAS overrides firefox preferences without any user input.","user":{"login":"Gizzah","id":11262979,"avatar_url":"https://avatars.githubusercontent.com/u/11262979?v=3","gravatar_id":"","url":"https://api.github.com/users/Gizzah","html_url":"https://github.com/Gizzah","followers_url":"https://api.github.com/users/Gizzah/followers","following_url":"https://api.github.com/users/Gizzah/following{/other_user}","gists_url":"https://api.github.com/users/Gizzah/gists{/gist_id}","starred_url":"https://api.github.com/users/Gizzah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gizzah/subscriptions","organizations_url":"https://api.github.com/users/Gizzah/orgs","repos_url":"https://api.github.com/users/Gizzah/repos","events_url":"https://api.github.com/users/Gizzah/events{/privacy}","received_events_url":"https://api.github.com/users/Gizzah/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dillbyrne/random-agent-spoofer/labels/duplicate","name":"duplicate","color":"fbca04"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-02T01:27:04Z","updated_at":"2015-03-05T20:57:49Z","closed_at":"2015-03-05T20:57:49Z","body":"I noticed a strange and unnecessary behaviour. The settings \"Disable browsing and download history\" and \"Use standard font set\" are working as intended, but it's fairly easy to get the desired effect in the firefox preferences without using RAS. In the case of setting custom fonts, it's actually the more desirable way, because you can decide which fonts to use, RAS only offers the standard font set.\r\n\r\nThe problem is that RAS ignores the settings in the firefox preferences after it get disabled and enabled again and overrides them without any warning. If you disable the standard font set option in RAS and use the firefox preferences to choose your own custom font by unchecking the \"Allow pages to choose their own fonts, instead of my selections above\" option, you will notice that RAS overrides your selection as soon as you restart it, thus allowing pages to use their own fonts again.\r\n\r\nThis is entirely unnecessary, the add-on shouldn't override user preferences when a RAS feature is disabled. I don't know if these two options are the only ones where this happens, but a disabled feature shouldn't interfere with user settings. "},"comment":{"url":"https://api.github.com/repos/dillbyrne/random-agent-spoofer/issues/comments/77450124","html_url":"https://github.com/dillbyrne/random-agent-spoofer/issues/151#issuecomment-77450124","issue_url":"https://api.github.com/repos/dillbyrne/random-agent-spoofer/issues/151","id":77450124,"user":{"login":"dillbyrne","id":2903711,"avatar_url":"https://avatars.githubusercontent.com/u/2903711?v=3","gravatar_id":"","url":"https://api.github.com/users/dillbyrne","html_url":"https://github.com/dillbyrne","followers_url":"https://api.github.com/users/dillbyrne/followers","following_url":"https://api.github.com/users/dillbyrne/following{/other_user}","gists_url":"https://api.github.com/users/dillbyrne/gists{/gist_id}","starred_url":"https://api.github.com/users/dillbyrne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dillbyrne/subscriptions","organizations_url":"https://api.github.com/users/dillbyrne/orgs","repos_url":"https://api.github.com/users/dillbyrne/repos","events_url":"https://api.github.com/users/dillbyrne/events{/privacy}","received_events_url":"https://api.github.com/users/dillbyrne/received_events","type":"User","site_admin":false},"created_at":"2015-03-05T20:57:49Z","updated_at":"2015-03-05T20:57:49Z","body":"Hello @Gizzah \r\n\r\nSome background on this.\r\n\r\nWhen I designed RAS I wanted a quick way to enable/disable all the options applied by the addon. As such I implemented a toggle system which kept track of the choices for each preference while the addon state was toggled off.\r\n\r\n The meant restoring the changes made by RAS to a working state while the addon was disabled but still keeping track of the options selected to reapply when it was enabled. To be sure the disabled state worked all the preferences except the ones storing the states were reset to their defaults. This ensured a guaranteed working state when the addon was disabled. \r\n\r\nWhen the addon was  re/enabled RAS applied the preferences stored in the intermediary state to the ones that were reset to default. So that is why RAS would overwrite preferences when it has been toggled on or off.\r\n\r\nSince many users find this confusing or  undesirable I have removed the toggle based system with my latest [commit](https://github.com/dillbyrne/random-agent-spoofer/commit/4d34659565b1274e77d3b8edd153fc7f8ad76df2). See  the last comment #27 for more details . As such I will now close this issue.  "}}