{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/30430751","id":30430751,"diff_hunk":"@@ -27,12 +27,13 @@ import java.util.concurrent.atomic.{AtomicReference, AtomicBoolean, AtomicIntege\n import java.util.UUID.randomUUID\n \n import scala.collection.{Map, Set}\n-import scala.collection.JavaConversions._\n import scala.collection.generic.Growable\n+import scala.collection.JavaConversions._","path":"core/src/main/scala/org/apache/spark/SparkContext.scala","position":6,"original_position":6,"commit_id":"c0de3364bb62b9a4f4bd99c6b6f0f8a97e48ab17","original_commit_id":"c0de3364bb62b9a4f4bd99c6b6f0f8a97e48ab17","user":{"login":"harishreedharan","id":1481194,"avatar_url":"https://avatars.githubusercontent.com/u/1481194?v=3","gravatar_id":"","url":"https://api.github.com/users/harishreedharan","html_url":"https://github.com/harishreedharan","followers_url":"https://api.github.com/users/harishreedharan/followers","following_url":"https://api.github.com/users/harishreedharan/following{/other_user}","gists_url":"https://api.github.com/users/harishreedharan/gists{/gist_id}","starred_url":"https://api.github.com/users/harishreedharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harishreedharan/subscriptions","organizations_url":"https://api.github.com/users/harishreedharan/orgs","repos_url":"https://api.github.com/users/harishreedharan/repos","events_url":"https://api.github.com/users/harishreedharan/events{/privacy}","received_events_url":"https://api.github.com/users/harishreedharan/received_events","type":"User","site_admin":false},"body":"hmm, this is sorted correctly no (with the change)? Do we do case-based too?","created_at":"2015-05-15T18:00:12Z","updated_at":"2015-05-15T18:00:12Z","html_url":"https://github.com/apache/spark/pull/6166#discussion_r30430751","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/6166","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/30430751"},"html":{"href":"https://github.com/apache/spark/pull/6166#discussion_r30430751"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/6166"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/6166","id":35480346,"html_url":"https://github.com/apache/spark/pull/6166","diff_url":"https://github.com/apache/spark/pull/6166.diff","patch_url":"https://github.com/apache/spark/pull/6166.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/6166","number":6166,"state":"open","locked":false,"title":"[SPARK-7657][YARN] Add driver logs links in application UI, in cluster mode.","user":{"login":"harishreedharan","id":1481194,"avatar_url":"https://avatars.githubusercontent.com/u/1481194?v=3","gravatar_id":"","url":"https://api.github.com/users/harishreedharan","html_url":"https://github.com/harishreedharan","followers_url":"https://api.github.com/users/harishreedharan/followers","following_url":"https://api.github.com/users/harishreedharan/following{/other_user}","gists_url":"https://api.github.com/users/harishreedharan/gists{/gist_id}","starred_url":"https://api.github.com/users/harishreedharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harishreedharan/subscriptions","organizations_url":"https://api.github.com/users/harishreedharan/orgs","repos_url":"https://api.github.com/users/harishreedharan/repos","events_url":"https://api.github.com/users/harishreedharan/events{/privacy}","received_events_url":"https://api.github.com/users/harishreedharan/received_events","type":"User","site_admin":false},"body":"The idea is to get the links to the logs in AM and then when the SparkContext starts up - send out a fake `SparkListenerExecutorAdded` event with the executorId as `driver` and the actual links to the logs. This ends up showing the actual links.\r\n\r\nThis PR adds new environment variables that can be set by any cluster manager before starting the driver. These environment variables must begin with `spark.driver.log.` followed by the name of the log type, with its value being the URL that will be show in the UI/history server. For example, YARN AM's stderr would be reported as: `spark.driver.log.stderr` etc. In YARN mode, this and `spark.driver.log.stdout` are added.\r\n\r\n![amlinks](https://cloud.githubusercontent.com/assets/1481194/7645832/ecd36804-fa6f-11e4-9994-bccc423179fd.png)\r\n","created_at":"2015-05-15T02:32:37Z","updated_at":"2015-05-15T18:00:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d3b45b838293eeb1c980b8ae700633989f4d32df","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/6166/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/6166/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/6166/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/c0de3364bb62b9a4f4bd99c6b6f0f8a97e48ab17","head":{"label":"harishreedharan:am-log-link","ref":"am-log-link","sha":"c0de3364bb62b9a4f4bd99c6b6f0f8a97e48ab17","user":{"login":"harishreedharan","id":1481194,"avatar_url":"https://avatars.githubusercontent.com/u/1481194?v=3","gravatar_id":"","url":"https://api.github.com/users/harishreedharan","html_url":"https://github.com/harishreedharan","followers_url":"https://api.github.com/users/harishreedharan/followers","following_url":"https://api.github.com/users/harishreedharan/following{/other_user}","gists_url":"https://api.github.com/users/harishreedharan/gists{/gist_id}","starred_url":"https://api.github.com/users/harishreedharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harishreedharan/subscriptions","organizations_url":"https://api.github.com/users/harishreedharan/orgs","repos_url":"https://api.github.com/users/harishreedharan/repos","events_url":"https://api.github.com/users/harishreedharan/events{/privacy}","received_events_url":"https://api.github.com/users/harishreedharan/received_events","type":"User","site_admin":false},"repo":{"id":18419952,"name":"spark","full_name":"harishreedharan/spark","owner":{"login":"harishreedharan","id":1481194,"avatar_url":"https://avatars.githubusercontent.com/u/1481194?v=3","gravatar_id":"","url":"https://api.github.com/users/harishreedharan","html_url":"https://github.com/harishreedharan","followers_url":"https://api.github.com/users/harishreedharan/followers","following_url":"https://api.github.com/users/harishreedharan/following{/other_user}","gists_url":"https://api.github.com/users/harishreedharan/gists{/gist_id}","starred_url":"https://api.github.com/users/harishreedharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harishreedharan/subscriptions","organizations_url":"https://api.github.com/users/harishreedharan/orgs","repos_url":"https://api.github.com/users/harishreedharan/repos","events_url":"https://api.github.com/users/harishreedharan/events{/privacy}","received_events_url":"https://api.github.com/users/harishreedharan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/harishreedharan/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/harishreedharan/spark","forks_url":"https://api.github.com/repos/harishreedharan/spark/forks","keys_url":"https://api.github.com/repos/harishreedharan/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harishreedharan/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harishreedharan/spark/teams","hooks_url":"https://api.github.com/repos/harishreedharan/spark/hooks","issue_events_url":"https://api.github.com/repos/harishreedharan/spark/issues/events{/number}","events_url":"https://api.github.com/repos/harishreedharan/spark/events","assignees_url":"https://api.github.com/repos/harishreedharan/spark/assignees{/user}","branches_url":"https://api.github.com/repos/harishreedharan/spark/branches{/branch}","tags_url":"https://api.github.com/repos/harishreedharan/spark/tags","blobs_url":"https://api.github.com/repos/harishreedharan/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harishreedharan/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harishreedharan/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/harishreedharan/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harishreedharan/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/harishreedharan/spark/languages","stargazers_url":"https://api.github.com/repos/harishreedharan/spark/stargazers","contributors_url":"https://api.github.com/repos/harishreedharan/spark/contributors","subscribers_url":"https://api.github.com/repos/harishreedharan/spark/subscribers","subscription_url":"https://api.github.com/repos/harishreedharan/spark/subscription","commits_url":"https://api.github.com/repos/harishreedharan/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/harishreedharan/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/harishreedharan/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/harishreedharan/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/harishreedharan/spark/contents/{+path}","compare_url":"https://api.github.com/repos/harishreedharan/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harishreedharan/spark/merges","archive_url":"https://api.github.com/repos/harishreedharan/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harishreedharan/spark/downloads","issues_url":"https://api.github.com/repos/harishreedharan/spark/issues{/number}","pulls_url":"https://api.github.com/repos/harishreedharan/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/harishreedharan/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/harishreedharan/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harishreedharan/spark/labels{/name}","releases_url":"https://api.github.com/repos/harishreedharan/spark/releases{/id}","created_at":"2014-04-03T22:17:22Z","updated_at":"2014-07-10T22:11:34Z","pushed_at":"2015-05-15T16:07:57Z","git_url":"git://github.com/harishreedharan/spark.git","ssh_url":"git@github.com:harishreedharan/spark.git","clone_url":"https://github.com/harishreedharan/spark.git","svn_url":"https://github.com/harishreedharan/spark","homepage":null,"size":101417,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"48fc38f5844f6c12bf440f2990b6d7f1630fafac","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-05-15T16:55:32Z","pushed_at":"2015-05-15T17:55:45Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1655814,"stargazers_count":3982,"watchers_count":3982,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3498,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":321,"forks":3498,"open_issues":321,"watchers":3982,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/6166"},"html":{"href":"https://github.com/apache/spark/pull/6166"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/6166"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/6166/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/6166/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/6166/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/c0de3364bb62b9a4f4bd99c6b6f0f8a97e48ab17"}}}}