{"action":"created","issue":{"url":"https://api.github.com/repos/Dolibarr/dolibarr/issues/3962","labels_url":"https://api.github.com/repos/Dolibarr/dolibarr/issues/3962/labels{/name}","comments_url":"https://api.github.com/repos/Dolibarr/dolibarr/issues/3962/comments","events_url":"https://api.github.com/repos/Dolibarr/dolibarr/issues/3962/events","html_url":"https://github.com/Dolibarr/dolibarr/issues/3962","id":116388714,"number":3962,"title":"Removing not usefull library","user":{"login":"eldy","id":883887,"avatar_url":"https://avatars.githubusercontent.com/u/883887?v=3","gravatar_id":"","url":"https://api.github.com/users/eldy","html_url":"https://github.com/eldy","followers_url":"https://api.github.com/users/eldy/followers","following_url":"https://api.github.com/users/eldy/following{/other_user}","gists_url":"https://api.github.com/users/eldy/gists{/gist_id}","starred_url":"https://api.github.com/users/eldy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eldy/subscriptions","organizations_url":"https://api.github.com/users/eldy/orgs","repos_url":"https://api.github.com/users/eldy/repos","events_url":"https://api.github.com/users/eldy/events{/privacy}","received_events_url":"https://api.github.com/users/eldy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-11-11T18:03:07Z","updated_at":"2015-11-26T18:54:12Z","closed_at":null,"body":"I am fighting against inclusion of external libraries that does not provide real thing.\r\nIt create dependencies and are time consuming when we check compatibilities test or feature tests when we upgrade them. Sometime, they are just deprecated, so we should n include libraries if it is not need to have dolibarr working.\r\nThis is the case for fire-php library. 200 ko added for a feature user will never see. \r\nYou will say \"so why adding phpchrome\". \r\nGoal is to have in standard dolibarr a solution to provide support for users that are online, ask help, and have no access to their log. I could add phpchrome firephp. I choosed phpchrome because lib was just a very small file versus 200ko for fire-php. And for a \"last chance\" feature to provide support, having 1 solution is enough, even if it is not the fist choice of integrator. Dolibarr is en ERP not a developer toolkit.\r\n\r\nI think if a developper or integrator need this feature, he can install its library itself. It is same for raven.\r\nIt is a good think to know we a dolibarr compatible with such a feature but i don't think we shoul have it by default into code. Risk is to see developers of module to use the embeded library when this library is not required by dolibarr so may be removed surely at the first compatibility problem (and this occurs frequently). Best solution is just to not have them into core and why not having them as an external module \"Tools for integrator or support services\".\r\n\r\nI notice @rdoursenaud of this issue.\r\n\r\nI will so probably close this issue by removing the folowing library soon:\r\nfirephp, raven, raven-js\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Dolibarr/dolibarr/issues/comments/159976920","html_url":"https://github.com/Dolibarr/dolibarr/issues/3962#issuecomment-159976920","issue_url":"https://api.github.com/repos/Dolibarr/dolibarr/issues/3962","id":159976920,"user":{"login":"rdoursenaud","id":1210367,"avatar_url":"https://avatars.githubusercontent.com/u/1210367?v=3","gravatar_id":"","url":"https://api.github.com/users/rdoursenaud","html_url":"https://github.com/rdoursenaud","followers_url":"https://api.github.com/users/rdoursenaud/followers","following_url":"https://api.github.com/users/rdoursenaud/following{/other_user}","gists_url":"https://api.github.com/users/rdoursenaud/gists{/gist_id}","starred_url":"https://api.github.com/users/rdoursenaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdoursenaud/subscriptions","organizations_url":"https://api.github.com/users/rdoursenaud/orgs","repos_url":"https://api.github.com/users/rdoursenaud/repos","events_url":"https://api.github.com/users/rdoursenaud/events{/privacy}","received_events_url":"https://api.github.com/users/rdoursenaud/received_events","type":"User","site_admin":false},"created_at":"2015-11-26T18:54:12Z","updated_at":"2015-11-26T18:54:12Z","body":"It's always a pleasure discussing with you. It's just like pissing into the wind!\r\nRegardless of any of my comments, this has been done at 4f3196edf2a04ff4db9d252f789ffa2e47c55fab"}}