{"action":"created","issue":{"url":"https://api.github.com/repos/wagn/wagn/issues/334","labels_url":"https://api.github.com/repos/wagn/wagn/issues/334/labels{/name}","comments_url":"https://api.github.com/repos/wagn/wagn/issues/334/comments","events_url":"https://api.github.com/repos/wagn/wagn/issues/334/events","html_url":"https://github.com/wagn/wagn/pull/334","id":58493966,"number":334,"title":"moved decko::engine stuff into wagn","user":{"login":"ethn","id":21904,"avatar_url":"https://avatars.githubusercontent.com/u/21904?v=3","gravatar_id":"","url":"https://api.github.com/users/ethn","html_url":"https://github.com/ethn","followers_url":"https://api.github.com/users/ethn/followers","following_url":"https://api.github.com/users/ethn/following{/other_user}","gists_url":"https://api.github.com/users/ethn/gists{/gist_id}","starred_url":"https://api.github.com/users/ethn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethn/subscriptions","organizations_url":"https://api.github.com/users/ethn/orgs","repos_url":"https://api.github.com/users/ethn/repos","events_url":"https://api.github.com/users/ethn/events{/privacy}","received_events_url":"https://api.github.com/users/ethn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-02-22T07:24:17Z","updated_at":"2015-02-22T15:48:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/wagn/wagn/pulls/334","html_url":"https://github.com/wagn/wagn/pull/334","diff_url":"https://github.com/wagn/wagn/pull/334.diff","patch_url":"https://github.com/wagn/wagn/pull/334.patch"},"body":"This is an attempt to move most of the core wagn functionality from decko-rails and back into the wagn gem, but preserving Gerry's engine reorganization.\r\n\r\nIf we go with this model, decko-rails is going to be super thin. The idea is that decko-rails can be made to generate engine classes that inherit from the same engine class (currently Wagn::Engine, soon Decko::Engine again) that standard wagn apps use to mount their routes.\r\n\r\n(In other words, it's basically what Gerry did before, but it refines decko-rails to be little more than an installation utility.)\r\n\r\nStill more cleanup to do, but I hope this clarifies some of the recent architectural conversations.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/wagn/wagn/issues/comments/75441370","html_url":"https://github.com/wagn/wagn/pull/334#issuecomment-75441370","issue_url":"https://api.github.com/repos/wagn/wagn/issues/334","id":75441370,"user":{"login":"ethn","id":21904,"avatar_url":"https://avatars.githubusercontent.com/u/21904?v=3","gravatar_id":"","url":"https://api.github.com/users/ethn","html_url":"https://github.com/ethn","followers_url":"https://api.github.com/users/ethn/followers","following_url":"https://api.github.com/users/ethn/following{/other_user}","gists_url":"https://api.github.com/users/ethn/gists{/gist_id}","starred_url":"https://api.github.com/users/ethn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethn/subscriptions","organizations_url":"https://api.github.com/users/ethn/orgs","repos_url":"https://api.github.com/users/ethn/repos","events_url":"https://api.github.com/users/ethn/events{/privacy}","received_events_url":"https://api.github.com/users/ethn/received_events","type":"User","site_admin":false},"created_at":"2015-02-22T15:48:13Z","updated_at":"2015-02-22T15:48:13Z","body":"> And, are you putting gem-assets with decko-rails, gem-wise?\r\n\r\nThere's basically nothing in decko-rails now.  wagn no longer depends on it.  it's just a palette ready for whatever adaptations are needed to get engine decks working.\r\n\r\nI should have said this more explicitly, but your engine organization is awesome.  I just think the base classes belong in the wagn/decko gem.  What I did yesterday was generally very easy because you had already done the heavy lifting.\r\n\r\nIt's possible that some day Decko will not use Rails at all.  We likely would no longer have the railsy organization of engines and routes and so forth.  If that happens, then decko-rails will need to create these kinds of classes and use them to connect to Decko/Cards with more use of connector code.\r\n\r\nBut so long as Decko *is* railsy, it makes perfect sense for us to split out our controller/route handling into a separate engine and make it available for use/inheritance by decko-rails.  To me this is largely about what we're committing to.  I'd say we're making a very strong commitment to keeping things such that decko can be used as an engine in a rails context.  We're making no such commitment to decko depending upon rails gems directly."}}