{"action":"created","comment":{"url":"https://api.github.com/repos/buildbot/buildbot/pulls/comments/26098930","id":26098930,"diff_hunk":"@@ -311,6 +312,16 @@ def _convert_nonzero_to_failure(res,\n             \"utility to handle the result of getProcessOutputAndValue\"\n             (stdout, stderr, code) = res\n             if code != 0:\n+                if code == 128:\n+                    # 128 is the error code git returns when things are\n+                    # wrong on its end\n+                    error_message = ('RuntimeError: command %s %s in %s on '\n+                                    'repourl %s failed with exit code %d: %s'\n+                                    % (command, args, path, self.repourl,\n+                                       code, stderr)).strip()\n+                    sys.stderr.write(error_message)\n+                    sys.stderr.flush()\n+                    sys.exit(1)","path":"master/buildbot/changes/gitpoller.py","position":21,"original_position":21,"commit_id":"02cc6fbd69a4e208904908a89db03e412db9087a","original_commit_id":"02cc6fbd69a4e208904908a89db03e412db9087a","user":{"login":"prasoon2211","id":2565248,"avatar_url":"https://avatars.githubusercontent.com/u/2565248?v=3","gravatar_id":"","url":"https://api.github.com/users/prasoon2211","html_url":"https://github.com/prasoon2211","followers_url":"https://api.github.com/users/prasoon2211/followers","following_url":"https://api.github.com/users/prasoon2211/following{/other_user}","gists_url":"https://api.github.com/users/prasoon2211/gists{/gist_id}","starred_url":"https://api.github.com/users/prasoon2211/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prasoon2211/subscriptions","organizations_url":"https://api.github.com/users/prasoon2211/orgs","repos_url":"https://api.github.com/users/prasoon2211/repos","events_url":"https://api.github.com/users/prasoon2211/events{/privacy}","received_events_url":"https://api.github.com/users/prasoon2211/received_events","type":"User","site_admin":false},"body":"@tardyp Hmm yes. So, if there are other change sources, then master should stay running. Okay then, I'll log the error and retry the poller with a timeout.","created_at":"2015-03-10T04:58:36Z","updated_at":"2015-03-10T04:58:36Z","html_url":"https://github.com/buildbot/buildbot/pull/1578#discussion_r26098930","pull_request_url":"https://api.github.com/repos/buildbot/buildbot/pulls/1578","_links":{"self":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/comments/26098930"},"html":{"href":"https://github.com/buildbot/buildbot/pull/1578#discussion_r26098930"},"pull_request":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/1578"}}},"pull_request":{"url":"https://api.github.com/repos/buildbot/buildbot/pulls/1578","id":30703631,"html_url":"https://github.com/buildbot/buildbot/pull/1578","diff_url":"https://github.com/buildbot/buildbot/pull/1578.diff","patch_url":"https://github.com/buildbot/buildbot/pull/1578.patch","issue_url":"https://api.github.com/repos/buildbot/buildbot/issues/1578","number":1578,"state":"open","locked":false,"title":"Issue 2464: Makes GitPoller show small error message and not a full traceback.","user":{"login":"prasoon2211","id":2565248,"avatar_url":"https://avatars.githubusercontent.com/u/2565248?v=3","gravatar_id":"","url":"https://api.github.com/users/prasoon2211","html_url":"https://github.com/prasoon2211","followers_url":"https://api.github.com/users/prasoon2211/followers","following_url":"https://api.github.com/users/prasoon2211/following{/other_user}","gists_url":"https://api.github.com/users/prasoon2211/gists{/gist_id}","starred_url":"https://api.github.com/users/prasoon2211/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prasoon2211/subscriptions","organizations_url":"https://api.github.com/users/prasoon2211/orgs","repos_url":"https://api.github.com/users/prasoon2211/repos","events_url":"https://api.github.com/users/prasoon2211/events{/privacy}","received_events_url":"https://api.github.com/users/prasoon2211/received_events","type":"User","site_admin":false},"body":"Ref: [Issue 2464](http://trac.buildbot.net/ticket/2464)\r\n\r\nWhen the error occurs on Git's end, we should not show the full taceback to the users (since it's not a problem with buildbot). This PR takes the Exception's error message and pushes it to stderr. ","created_at":"2015-03-07T14:44:56Z","updated_at":"2015-03-10T04:58:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d5066b97d6ca7332998e6762584323346935ffa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/buildbot/buildbot/pulls/1578/commits","review_comments_url":"https://api.github.com/repos/buildbot/buildbot/pulls/1578/comments","review_comment_url":"https://api.github.com/repos/buildbot/buildbot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/buildbot/buildbot/issues/1578/comments","statuses_url":"https://api.github.com/repos/buildbot/buildbot/statuses/02cc6fbd69a4e208904908a89db03e412db9087a","head":{"label":"prasoon2211:gitpoller_issue2464","ref":"gitpoller_issue2464","sha":"02cc6fbd69a4e208904908a89db03e412db9087a","user":{"login":"prasoon2211","id":2565248,"avatar_url":"https://avatars.githubusercontent.com/u/2565248?v=3","gravatar_id":"","url":"https://api.github.com/users/prasoon2211","html_url":"https://github.com/prasoon2211","followers_url":"https://api.github.com/users/prasoon2211/followers","following_url":"https://api.github.com/users/prasoon2211/following{/other_user}","gists_url":"https://api.github.com/users/prasoon2211/gists{/gist_id}","starred_url":"https://api.github.com/users/prasoon2211/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prasoon2211/subscriptions","organizations_url":"https://api.github.com/users/prasoon2211/orgs","repos_url":"https://api.github.com/users/prasoon2211/repos","events_url":"https://api.github.com/users/prasoon2211/events{/privacy}","received_events_url":"https://api.github.com/users/prasoon2211/received_events","type":"User","site_admin":false},"repo":{"id":31753664,"name":"buildbot","full_name":"prasoon2211/buildbot","owner":{"login":"prasoon2211","id":2565248,"avatar_url":"https://avatars.githubusercontent.com/u/2565248?v=3","gravatar_id":"","url":"https://api.github.com/users/prasoon2211","html_url":"https://github.com/prasoon2211","followers_url":"https://api.github.com/users/prasoon2211/followers","following_url":"https://api.github.com/users/prasoon2211/following{/other_user}","gists_url":"https://api.github.com/users/prasoon2211/gists{/gist_id}","starred_url":"https://api.github.com/users/prasoon2211/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prasoon2211/subscriptions","organizations_url":"https://api.github.com/users/prasoon2211/orgs","repos_url":"https://api.github.com/users/prasoon2211/repos","events_url":"https://api.github.com/users/prasoon2211/events{/privacy}","received_events_url":"https://api.github.com/users/prasoon2211/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/prasoon2211/buildbot","description":"Python-based continuous integration testing framework; send pull requests for your patches!","fork":true,"url":"https://api.github.com/repos/prasoon2211/buildbot","forks_url":"https://api.github.com/repos/prasoon2211/buildbot/forks","keys_url":"https://api.github.com/repos/prasoon2211/buildbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prasoon2211/buildbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prasoon2211/buildbot/teams","hooks_url":"https://api.github.com/repos/prasoon2211/buildbot/hooks","issue_events_url":"https://api.github.com/repos/prasoon2211/buildbot/issues/events{/number}","events_url":"https://api.github.com/repos/prasoon2211/buildbot/events","assignees_url":"https://api.github.com/repos/prasoon2211/buildbot/assignees{/user}","branches_url":"https://api.github.com/repos/prasoon2211/buildbot/branches{/branch}","tags_url":"https://api.github.com/repos/prasoon2211/buildbot/tags","blobs_url":"https://api.github.com/repos/prasoon2211/buildbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prasoon2211/buildbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prasoon2211/buildbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/prasoon2211/buildbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prasoon2211/buildbot/statuses/{sha}","languages_url":"https://api.github.com/repos/prasoon2211/buildbot/languages","stargazers_url":"https://api.github.com/repos/prasoon2211/buildbot/stargazers","contributors_url":"https://api.github.com/repos/prasoon2211/buildbot/contributors","subscribers_url":"https://api.github.com/repos/prasoon2211/buildbot/subscribers","subscription_url":"https://api.github.com/repos/prasoon2211/buildbot/subscription","commits_url":"https://api.github.com/repos/prasoon2211/buildbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/prasoon2211/buildbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/prasoon2211/buildbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/prasoon2211/buildbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/prasoon2211/buildbot/contents/{+path}","compare_url":"https://api.github.com/repos/prasoon2211/buildbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prasoon2211/buildbot/merges","archive_url":"https://api.github.com/repos/prasoon2211/buildbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prasoon2211/buildbot/downloads","issues_url":"https://api.github.com/repos/prasoon2211/buildbot/issues{/number}","pulls_url":"https://api.github.com/repos/prasoon2211/buildbot/pulls{/number}","milestones_url":"https://api.github.com/repos/prasoon2211/buildbot/milestones{/number}","notifications_url":"https://api.github.com/repos/prasoon2211/buildbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prasoon2211/buildbot/labels{/name}","releases_url":"https://api.github.com/repos/prasoon2211/buildbot/releases{/id}","created_at":"2015-03-06T05:11:29Z","updated_at":"2015-03-06T05:11:33Z","pushed_at":"2015-03-07T14:42:22Z","git_url":"git://github.com/prasoon2211/buildbot.git","ssh_url":"git@github.com:prasoon2211/buildbot.git","clone_url":"https://github.com/prasoon2211/buildbot.git","svn_url":"https://github.com/prasoon2211/buildbot","homepage":"http://buildbot.net","size":49915,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"buildbot:master","ref":"master","sha":"05653d18c7a47e75865201e129933ed4394117d6","user":{"login":"buildbot","id":324515,"avatar_url":"https://avatars.githubusercontent.com/u/324515?v=3","gravatar_id":"","url":"https://api.github.com/users/buildbot","html_url":"https://github.com/buildbot","followers_url":"https://api.github.com/users/buildbot/followers","following_url":"https://api.github.com/users/buildbot/following{/other_user}","gists_url":"https://api.github.com/users/buildbot/gists{/gist_id}","starred_url":"https://api.github.com/users/buildbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildbot/subscriptions","organizations_url":"https://api.github.com/users/buildbot/orgs","repos_url":"https://api.github.com/users/buildbot/repos","events_url":"https://api.github.com/users/buildbot/events{/privacy}","received_events_url":"https://api.github.com/users/buildbot/received_events","type":"Organization","site_admin":false},"repo":{"id":760165,"name":"buildbot","full_name":"buildbot/buildbot","owner":{"login":"buildbot","id":324515,"avatar_url":"https://avatars.githubusercontent.com/u/324515?v=3","gravatar_id":"","url":"https://api.github.com/users/buildbot","html_url":"https://github.com/buildbot","followers_url":"https://api.github.com/users/buildbot/followers","following_url":"https://api.github.com/users/buildbot/following{/other_user}","gists_url":"https://api.github.com/users/buildbot/gists{/gist_id}","starred_url":"https://api.github.com/users/buildbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildbot/subscriptions","organizations_url":"https://api.github.com/users/buildbot/orgs","repos_url":"https://api.github.com/users/buildbot/repos","events_url":"https://api.github.com/users/buildbot/events{/privacy}","received_events_url":"https://api.github.com/users/buildbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/buildbot/buildbot","description":"Python-based continuous integration testing framework; send pull requests for your patches!","fork":false,"url":"https://api.github.com/repos/buildbot/buildbot","forks_url":"https://api.github.com/repos/buildbot/buildbot/forks","keys_url":"https://api.github.com/repos/buildbot/buildbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buildbot/buildbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buildbot/buildbot/teams","hooks_url":"https://api.github.com/repos/buildbot/buildbot/hooks","issue_events_url":"https://api.github.com/repos/buildbot/buildbot/issues/events{/number}","events_url":"https://api.github.com/repos/buildbot/buildbot/events","assignees_url":"https://api.github.com/repos/buildbot/buildbot/assignees{/user}","branches_url":"https://api.github.com/repos/buildbot/buildbot/branches{/branch}","tags_url":"https://api.github.com/repos/buildbot/buildbot/tags","blobs_url":"https://api.github.com/repos/buildbot/buildbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buildbot/buildbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buildbot/buildbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/buildbot/buildbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buildbot/buildbot/statuses/{sha}","languages_url":"https://api.github.com/repos/buildbot/buildbot/languages","stargazers_url":"https://api.github.com/repos/buildbot/buildbot/stargazers","contributors_url":"https://api.github.com/repos/buildbot/buildbot/contributors","subscribers_url":"https://api.github.com/repos/buildbot/buildbot/subscribers","subscription_url":"https://api.github.com/repos/buildbot/buildbot/subscription","commits_url":"https://api.github.com/repos/buildbot/buildbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/buildbot/buildbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/buildbot/buildbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/buildbot/buildbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/buildbot/buildbot/contents/{+path}","compare_url":"https://api.github.com/repos/buildbot/buildbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buildbot/buildbot/merges","archive_url":"https://api.github.com/repos/buildbot/buildbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buildbot/buildbot/downloads","issues_url":"https://api.github.com/repos/buildbot/buildbot/issues{/number}","pulls_url":"https://api.github.com/repos/buildbot/buildbot/pulls{/number}","milestones_url":"https://api.github.com/repos/buildbot/buildbot/milestones{/number}","notifications_url":"https://api.github.com/repos/buildbot/buildbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buildbot/buildbot/labels{/name}","releases_url":"https://api.github.com/repos/buildbot/buildbot/releases{/id}","created_at":"2010-07-06T17:56:53Z","updated_at":"2015-03-09T22:38:06Z","pushed_at":"2015-03-08T20:13:28Z","git_url":"git://github.com/buildbot/buildbot.git","ssh_url":"git@github.com:buildbot/buildbot.git","clone_url":"https://github.com/buildbot/buildbot.git","svn_url":"https://github.com/buildbot/buildbot","homepage":"http://buildbot.net","size":49915,"stargazers_count":1418,"watchers_count":1418,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":667,"mirror_url":null,"open_issues_count":19,"forks":667,"open_issues":19,"watchers":1418,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/1578"},"html":{"href":"https://github.com/buildbot/buildbot/pull/1578"},"issue":{"href":"https://api.github.com/repos/buildbot/buildbot/issues/1578"},"comments":{"href":"https://api.github.com/repos/buildbot/buildbot/issues/1578/comments"},"review_comments":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/1578/comments"},"review_comment":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/1578/commits"},"statuses":{"href":"https://api.github.com/repos/buildbot/buildbot/statuses/02cc6fbd69a4e208904908a89db03e412db9087a"}}}}