{"action":"created","issue":{"url":"https://api.github.com/repos/sunpy/sunpy/issues/1067","labels_url":"https://api.github.com/repos/sunpy/sunpy/issues/1067/labels{/name}","comments_url":"https://api.github.com/repos/sunpy/sunpy/issues/1067/comments","events_url":"https://api.github.com/repos/sunpy/sunpy/issues/1067/events","html_url":"https://github.com/sunpy/sunpy/pull/1067","id":35795792,"number":1067,"title":"[Review]: Functions to calculate GOES radiative losses","user":{"login":"DanRyanIrish","id":6806704,"avatar_url":"https://avatars.githubusercontent.com/u/6806704?v=3","gravatar_id":"","url":"https://api.github.com/users/DanRyanIrish","html_url":"https://github.com/DanRyanIrish","followers_url":"https://api.github.com/users/DanRyanIrish/followers","following_url":"https://api.github.com/users/DanRyanIrish/following{/other_user}","gists_url":"https://api.github.com/users/DanRyanIrish/gists{/gist_id}","starred_url":"https://api.github.com/users/DanRyanIrish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanRyanIrish/subscriptions","organizations_url":"https://api.github.com/users/DanRyanIrish/orgs","repos_url":"https://api.github.com/users/DanRyanIrish/repos","events_url":"https://api.github.com/users/DanRyanIrish/events{/privacy}","received_events_url":"https://api.github.com/users/DanRyanIrish/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/sunpy/sunpy/labels/[Review]","name":"[Review]","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":24,"created_at":"2014-06-16T13:28:14Z","updated_at":"2015-02-02T17:31:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sunpy/sunpy/pulls/1067","html_url":"https://github.com/sunpy/sunpy/pull/1067","diff_url":"https://github.com/sunpy/sunpy/pull/1067.diff","patch_url":"https://github.com/sunpy/sunpy/pull/1067.patch"},"body":"Hi guys,\r\n    Here is the next batch of software for analysing GOES data in sunpy.  This PR includes functions to calculate the radiative losses from the GOES-observed plasma, calc_rad_loss(), and the X-ray luminosity in the wavelength ranges of the two GOES channels, goes_lx().  There are also two functions which allows these properties to be calculated and inserted directly into and GOESLightCurve object, rad_loss_rate() and xray_luminosity, respectively.\r\n\r\nLet me know what you guys think.  For instance, there is probably a better place than goes.py to put _time_steps(), which calculates the time differences between successive measurement times.  I'm also not sure if the assert statements in my units tests are the most efficient.  \r\n\r\nHowever, all the function give the correct results.  If the functionality proposed here can be merged, sunpy could allow you to do all the analysis of GOES data that is possible in SSW which I think would be a great step forward."},"comment":{"url":"https://api.github.com/repos/sunpy/sunpy/issues/comments/72499265","html_url":"https://github.com/sunpy/sunpy/pull/1067#issuecomment-72499265","issue_url":"https://api.github.com/repos/sunpy/sunpy/issues/1067","id":72499265,"user":{"login":"ayshih","id":991759,"avatar_url":"https://avatars.githubusercontent.com/u/991759?v=3","gravatar_id":"","url":"https://api.github.com/users/ayshih","html_url":"https://github.com/ayshih","followers_url":"https://api.github.com/users/ayshih/followers","following_url":"https://api.github.com/users/ayshih/following{/other_user}","gists_url":"https://api.github.com/users/ayshih/gists{/gist_id}","starred_url":"https://api.github.com/users/ayshih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayshih/subscriptions","organizations_url":"https://api.github.com/users/ayshih/orgs","repos_url":"https://api.github.com/users/ayshih/repos","events_url":"https://api.github.com/users/ayshih/events{/privacy}","received_events_url":"https://api.github.com/users/ayshih/received_events","type":"User","site_admin":false},"created_at":"2015-02-02T17:31:33Z","updated_at":"2015-02-02T17:31:33Z","body":"@dpshelio gave :+1: in chat, so merging"}}