{"action":"opened","number":10,"pull_request":{"url":"https://api.github.com/repos/mono/referencesource/pulls/10","id":31871846,"html_url":"https://github.com/mono/referencesource/pull/10","diff_url":"https://github.com/mono/referencesource/pull/10.diff","patch_url":"https://github.com/mono/referencesource/pull/10.patch","issue_url":"https://api.github.com/repos/mono/referencesource/issues/10","number":10,"state":"open","locked":false,"title":"[corlib] Fix DateTime regression on ARM","user":{"login":"akoeplinger","id":1376924,"avatar_url":"https://avatars.githubusercontent.com/u/1376924?v=3","gravatar_id":"","url":"https://api.github.com/users/akoeplinger","html_url":"https://github.com/akoeplinger","followers_url":"https://api.github.com/users/akoeplinger/followers","following_url":"https://api.github.com/users/akoeplinger/following{/other_user}","gists_url":"https://api.github.com/users/akoeplinger/gists{/gist_id}","starred_url":"https://api.github.com/users/akoeplinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akoeplinger/subscriptions","organizations_url":"https://api.github.com/users/akoeplinger/orgs","repos_url":"https://api.github.com/users/akoeplinger/repos","events_url":"https://api.github.com/users/akoeplinger/events{/privacy}","received_events_url":"https://api.github.com/users/akoeplinger/received_events","type":"User","site_admin":false},"body":"This is the same issue as in https://github.com/mono/referencesource/pull/7,\r\ni.e. there's an overflow when casting a too large value from double->long\r\nand the referencesource implementation relies on this being a large negative\r\nvalue in order for the ArgumentOutOfRangeException to be properly thrown.\r\n\r\nAs Mono's runtime on ARM in this case returns -1, the exception isn't thrown.\r\n\r\nThe fix is to introduce an explicit overflow check, catch an eventual\r\nOverflowException and raise the proper exception instead. This can be JIT'd\r\nto better code than checking if the value fits into long every time.\r\n\r\nIt fixes a couple of DateTime unit tests that currently fail on ARM.","created_at":"2015-03-24T21:28:14Z","updated_at":"2015-03-24T21:28:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mono/referencesource/pulls/10/commits","review_comments_url":"https://api.github.com/repos/mono/referencesource/pulls/10/comments","review_comment_url":"https://api.github.com/repos/mono/referencesource/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mono/referencesource/issues/10/comments","statuses_url":"https://api.github.com/repos/mono/referencesource/statuses/252fee4d4407358b18762b5e25baa6eafe04935e","head":{"label":"akoeplinger:fix-datetime-overflow2","ref":"fix-datetime-overflow2","sha":"252fee4d4407358b18762b5e25baa6eafe04935e","user":{"login":"akoeplinger","id":1376924,"avatar_url":"https://avatars.githubusercontent.com/u/1376924?v=3","gravatar_id":"","url":"https://api.github.com/users/akoeplinger","html_url":"https://github.com/akoeplinger","followers_url":"https://api.github.com/users/akoeplinger/followers","following_url":"https://api.github.com/users/akoeplinger/following{/other_user}","gists_url":"https://api.github.com/users/akoeplinger/gists{/gist_id}","starred_url":"https://api.github.com/users/akoeplinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akoeplinger/subscriptions","organizations_url":"https://api.github.com/users/akoeplinger/orgs","repos_url":"https://api.github.com/users/akoeplinger/repos","events_url":"https://api.github.com/users/akoeplinger/events{/privacy}","received_events_url":"https://api.github.com/users/akoeplinger/received_events","type":"User","site_admin":false},"repo":{"id":27308658,"name":"referencesource","full_name":"akoeplinger/referencesource","owner":{"login":"akoeplinger","id":1376924,"avatar_url":"https://avatars.githubusercontent.com/u/1376924?v=3","gravatar_id":"","url":"https://api.github.com/users/akoeplinger","html_url":"https://github.com/akoeplinger","followers_url":"https://api.github.com/users/akoeplinger/followers","following_url":"https://api.github.com/users/akoeplinger/following{/other_user}","gists_url":"https://api.github.com/users/akoeplinger/gists{/gist_id}","starred_url":"https://api.github.com/users/akoeplinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akoeplinger/subscriptions","organizations_url":"https://api.github.com/users/akoeplinger/orgs","repos_url":"https://api.github.com/users/akoeplinger/repos","events_url":"https://api.github.com/users/akoeplinger/events{/privacy}","received_events_url":"https://api.github.com/users/akoeplinger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akoeplinger/referencesource","description":"Source from the Microsoft .NET Reference Source that represent a subset of the .NET Framework","fork":true,"url":"https://api.github.com/repos/akoeplinger/referencesource","forks_url":"https://api.github.com/repos/akoeplinger/referencesource/forks","keys_url":"https://api.github.com/repos/akoeplinger/referencesource/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akoeplinger/referencesource/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akoeplinger/referencesource/teams","hooks_url":"https://api.github.com/repos/akoeplinger/referencesource/hooks","issue_events_url":"https://api.github.com/repos/akoeplinger/referencesource/issues/events{/number}","events_url":"https://api.github.com/repos/akoeplinger/referencesource/events","assignees_url":"https://api.github.com/repos/akoeplinger/referencesource/assignees{/user}","branches_url":"https://api.github.com/repos/akoeplinger/referencesource/branches{/branch}","tags_url":"https://api.github.com/repos/akoeplinger/referencesource/tags","blobs_url":"https://api.github.com/repos/akoeplinger/referencesource/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akoeplinger/referencesource/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akoeplinger/referencesource/git/refs{/sha}","trees_url":"https://api.github.com/repos/akoeplinger/referencesource/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akoeplinger/referencesource/statuses/{sha}","languages_url":"https://api.github.com/repos/akoeplinger/referencesource/languages","stargazers_url":"https://api.github.com/repos/akoeplinger/referencesource/stargazers","contributors_url":"https://api.github.com/repos/akoeplinger/referencesource/contributors","subscribers_url":"https://api.github.com/repos/akoeplinger/referencesource/subscribers","subscription_url":"https://api.github.com/repos/akoeplinger/referencesource/subscription","commits_url":"https://api.github.com/repos/akoeplinger/referencesource/commits{/sha}","git_commits_url":"https://api.github.com/repos/akoeplinger/referencesource/git/commits{/sha}","comments_url":"https://api.github.com/repos/akoeplinger/referencesource/comments{/number}","issue_comment_url":"https://api.github.com/repos/akoeplinger/referencesource/issues/comments{/number}","contents_url":"https://api.github.com/repos/akoeplinger/referencesource/contents/{+path}","compare_url":"https://api.github.com/repos/akoeplinger/referencesource/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akoeplinger/referencesource/merges","archive_url":"https://api.github.com/repos/akoeplinger/referencesource/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akoeplinger/referencesource/downloads","issues_url":"https://api.github.com/repos/akoeplinger/referencesource/issues{/number}","pulls_url":"https://api.github.com/repos/akoeplinger/referencesource/pulls{/number}","milestones_url":"https://api.github.com/repos/akoeplinger/referencesource/milestones{/number}","notifications_url":"https://api.github.com/repos/akoeplinger/referencesource/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akoeplinger/referencesource/labels{/name}","releases_url":"https://api.github.com/repos/akoeplinger/referencesource/releases{/id}","created_at":"2014-11-29T16:56:51Z","updated_at":"2014-11-29T17:01:08Z","pushed_at":"2015-03-24T21:02:35Z","git_url":"git://github.com/akoeplinger/referencesource.git","ssh_url":"git@github.com:akoeplinger/referencesource.git","clone_url":"https://github.com/akoeplinger/referencesource.git","svn_url":"https://github.com/akoeplinger/referencesource","homepage":"http://referencesource.microsoft.com/","size":26395,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"mono"}},"base":{"label":"mono:mono","ref":"mono","sha":"0620a67c7f64ac1401fddac92f6b37e0d61f0439","user":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"repo":{"id":26882522,"name":"referencesource","full_name":"mono/referencesource","owner":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mono/referencesource","description":"Source from the Microsoft .NET Reference Source that represent a subset of the .NET Framework","fork":true,"url":"https://api.github.com/repos/mono/referencesource","forks_url":"https://api.github.com/repos/mono/referencesource/forks","keys_url":"https://api.github.com/repos/mono/referencesource/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mono/referencesource/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mono/referencesource/teams","hooks_url":"https://api.github.com/repos/mono/referencesource/hooks","issue_events_url":"https://api.github.com/repos/mono/referencesource/issues/events{/number}","events_url":"https://api.github.com/repos/mono/referencesource/events","assignees_url":"https://api.github.com/repos/mono/referencesource/assignees{/user}","branches_url":"https://api.github.com/repos/mono/referencesource/branches{/branch}","tags_url":"https://api.github.com/repos/mono/referencesource/tags","blobs_url":"https://api.github.com/repos/mono/referencesource/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mono/referencesource/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mono/referencesource/git/refs{/sha}","trees_url":"https://api.github.com/repos/mono/referencesource/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mono/referencesource/statuses/{sha}","languages_url":"https://api.github.com/repos/mono/referencesource/languages","stargazers_url":"https://api.github.com/repos/mono/referencesource/stargazers","contributors_url":"https://api.github.com/repos/mono/referencesource/contributors","subscribers_url":"https://api.github.com/repos/mono/referencesource/subscribers","subscription_url":"https://api.github.com/repos/mono/referencesource/subscription","commits_url":"https://api.github.com/repos/mono/referencesource/commits{/sha}","git_commits_url":"https://api.github.com/repos/mono/referencesource/git/commits{/sha}","comments_url":"https://api.github.com/repos/mono/referencesource/comments{/number}","issue_comment_url":"https://api.github.com/repos/mono/referencesource/issues/comments{/number}","contents_url":"https://api.github.com/repos/mono/referencesource/contents/{+path}","compare_url":"https://api.github.com/repos/mono/referencesource/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mono/referencesource/merges","archive_url":"https://api.github.com/repos/mono/referencesource/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mono/referencesource/downloads","issues_url":"https://api.github.com/repos/mono/referencesource/issues{/number}","pulls_url":"https://api.github.com/repos/mono/referencesource/pulls{/number}","milestones_url":"https://api.github.com/repos/mono/referencesource/milestones{/number}","notifications_url":"https://api.github.com/repos/mono/referencesource/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mono/referencesource/labels{/name}","releases_url":"https://api.github.com/repos/mono/referencesource/releases{/id}","created_at":"2014-11-19T21:29:16Z","updated_at":"2015-03-24T09:00:54Z","pushed_at":"2015-03-24T21:28:15Z","git_url":"git://github.com/mono/referencesource.git","ssh_url":"git@github.com:mono/referencesource.git","clone_url":"https://github.com/mono/referencesource.git","svn_url":"https://github.com/mono/referencesource","homepage":"http://referencesource.microsoft.com/","size":28225,"stargazers_count":4,"watchers_count":4,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":2,"forks":8,"open_issues":2,"watchers":4,"default_branch":"mono"}},"_links":{"self":{"href":"https://api.github.com/repos/mono/referencesource/pulls/10"},"html":{"href":"https://github.com/mono/referencesource/pull/10"},"issue":{"href":"https://api.github.com/repos/mono/referencesource/issues/10"},"comments":{"href":"https://api.github.com/repos/mono/referencesource/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/mono/referencesource/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/mono/referencesource/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mono/referencesource/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/mono/referencesource/statuses/252fee4d4407358b18762b5e25baa6eafe04935e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":6,"deletions":1,"changed_files":1}}