{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/42522928","id":42522928,"diff_hunk":"@@ -0,0 +1,21 @@\n+﻿// Copyright (c) Microsoft. All rights reserved.\n+// Licensed under the MIT license. See LICENSE file in the project root for full license information.\n+\n+namespace System.Net.NetworkInformation\n+{\n+    // OSX implementation of NetworkChange\n+    public class NetworkChange\n+    {\n+        static public event NetworkAddressChangedEventHandler NetworkAddressChanged\n+        {\n+            add\n+            {\n+                throw new NotImplementedException();\n+            }\n+            remove\n+            {\n+                throw new NotImplementedException();","path":"src/System.Net.NetworkInformation/src/System/Net/NetworkInformation/NetworkAddressChange.OSX.cs","position":17,"original_position":17,"commit_id":"8e0f1c61634d031c447b6491ee894d8b6efb320e","original_commit_id":"8e0f1c61634d031c447b6491ee894d8b6efb320e","user":{"login":"mellinoe","id":8918977,"avatar_url":"https://avatars.githubusercontent.com/u/8918977?v=3","gravatar_id":"","url":"https://api.github.com/users/mellinoe","html_url":"https://github.com/mellinoe","followers_url":"https://api.github.com/users/mellinoe/followers","following_url":"https://api.github.com/users/mellinoe/following{/other_user}","gists_url":"https://api.github.com/users/mellinoe/gists{/gist_id}","starred_url":"https://api.github.com/users/mellinoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellinoe/subscriptions","organizations_url":"https://api.github.com/users/mellinoe/orgs","repos_url":"https://api.github.com/users/mellinoe/repos","events_url":"https://api.github.com/users/mellinoe/events{/privacy}","received_events_url":"https://api.github.com/users/mellinoe/received_events","type":"User","site_admin":false},"body":"I know these can be implemented, but I won't have time to finish them before Wednesday (most likely). We need to use some OSX-specific functions which will take a bit of time to get familiar with. I'm mainly using \"NotImplementedException\" to mean \"not yet implemented but I know how\", and \"PlatformNotSupportedException\" to mean \"I couldn't find a way to implement this at all\"","created_at":"2015-10-20T17:01:23Z","updated_at":"2015-10-20T17:01:23Z","html_url":"https://github.com/dotnet/corefx/pull/3951#discussion_r42522928","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/3951","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/42522928"},"html":{"href":"https://github.com/dotnet/corefx/pull/3951#discussion_r42522928"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/3951"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/3951","id":48031067,"html_url":"https://github.com/dotnet/corefx/pull/3951","diff_url":"https://github.com/dotnet/corefx/pull/3951.diff","patch_url":"https://github.com/dotnet/corefx/pull/3951.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/3951","number":3951,"state":"open","locked":false,"title":"Complete x-plat implementations of NetworkInformation","user":{"login":"mellinoe","id":8918977,"avatar_url":"https://avatars.githubusercontent.com/u/8918977?v=3","gravatar_id":"","url":"https://api.github.com/users/mellinoe","html_url":"https://github.com/mellinoe","followers_url":"https://api.github.com/users/mellinoe/followers","following_url":"https://api.github.com/users/mellinoe/following{/other_user}","gists_url":"https://api.github.com/users/mellinoe/gists{/gist_id}","starred_url":"https://api.github.com/users/mellinoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellinoe/subscriptions","organizations_url":"https://api.github.com/users/mellinoe/orgs","repos_url":"https://api.github.com/users/mellinoe/repos","events_url":"https://api.github.com/users/mellinoe/events{/privacy}","received_events_url":"https://api.github.com/users/mellinoe/received_events","type":"User","site_admin":false},"body":"This brings all of my pending changes into the corefx dev/ni-xplat branch. At this point, all of the members in this library are either implemented or throw a PlatformNotSupportedException. The only exception for this is NetworkChange.NetworkAddressChanged, which is implemented on Linux, but not yet on OSX. The implementation for that looks like it will be fairly complicated, so I am going to try to get everything else checked in before attempting it.\r\n\r\nBefore moving all of this into corefx/master, I'll try to address any pending cleanup and refactoring that reviewers recomnmend. The goal is to get the code here into corefx/master by our Wednesday feature deadline. After that, and before RC1 releases, I will make do some additional code cleanup and add more test validation to the library; to the string parsing logic in particular.","created_at":"2015-10-19T04:46:00Z","updated_at":"2015-10-20T17:01:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6518a3fd831774ab871a77f9ca6a852b0809843a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/3951/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/3951/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/3951/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/8e0f1c61634d031c447b6491ee894d8b6efb320e","head":{"label":"mellinoe:dev/ni-xplat","ref":"dev/ni-xplat","sha":"8e0f1c61634d031c447b6491ee894d8b6efb320e","user":{"login":"mellinoe","id":8918977,"avatar_url":"https://avatars.githubusercontent.com/u/8918977?v=3","gravatar_id":"","url":"https://api.github.com/users/mellinoe","html_url":"https://github.com/mellinoe","followers_url":"https://api.github.com/users/mellinoe/followers","following_url":"https://api.github.com/users/mellinoe/following{/other_user}","gists_url":"https://api.github.com/users/mellinoe/gists{/gist_id}","starred_url":"https://api.github.com/users/mellinoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellinoe/subscriptions","organizations_url":"https://api.github.com/users/mellinoe/orgs","repos_url":"https://api.github.com/users/mellinoe/repos","events_url":"https://api.github.com/users/mellinoe/events{/privacy}","received_events_url":"https://api.github.com/users/mellinoe/received_events","type":"User","site_admin":false},"repo":{"id":26655317,"name":"corefx","full_name":"mellinoe/corefx","owner":{"login":"mellinoe","id":8918977,"avatar_url":"https://avatars.githubusercontent.com/u/8918977?v=3","gravatar_id":"","url":"https://api.github.com/users/mellinoe","html_url":"https://github.com/mellinoe","followers_url":"https://api.github.com/users/mellinoe/followers","following_url":"https://api.github.com/users/mellinoe/following{/other_user}","gists_url":"https://api.github.com/users/mellinoe/gists{/gist_id}","starred_url":"https://api.github.com/users/mellinoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellinoe/subscriptions","organizations_url":"https://api.github.com/users/mellinoe/orgs","repos_url":"https://api.github.com/users/mellinoe/repos","events_url":"https://api.github.com/users/mellinoe/events{/privacy}","received_events_url":"https://api.github.com/users/mellinoe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mellinoe/corefx","description":"This repository contains the foundational libraries that make up the .NET Core development stack.","fork":true,"url":"https://api.github.com/repos/mellinoe/corefx","forks_url":"https://api.github.com/repos/mellinoe/corefx/forks","keys_url":"https://api.github.com/repos/mellinoe/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mellinoe/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mellinoe/corefx/teams","hooks_url":"https://api.github.com/repos/mellinoe/corefx/hooks","issue_events_url":"https://api.github.com/repos/mellinoe/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/mellinoe/corefx/events","assignees_url":"https://api.github.com/repos/mellinoe/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/mellinoe/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/mellinoe/corefx/tags","blobs_url":"https://api.github.com/repos/mellinoe/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mellinoe/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mellinoe/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/mellinoe/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mellinoe/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/mellinoe/corefx/languages","stargazers_url":"https://api.github.com/repos/mellinoe/corefx/stargazers","contributors_url":"https://api.github.com/repos/mellinoe/corefx/contributors","subscribers_url":"https://api.github.com/repos/mellinoe/corefx/subscribers","subscription_url":"https://api.github.com/repos/mellinoe/corefx/subscription","commits_url":"https://api.github.com/repos/mellinoe/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/mellinoe/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/mellinoe/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/mellinoe/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/mellinoe/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/mellinoe/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mellinoe/corefx/merges","archive_url":"https://api.github.com/repos/mellinoe/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mellinoe/corefx/downloads","issues_url":"https://api.github.com/repos/mellinoe/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/mellinoe/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/mellinoe/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/mellinoe/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mellinoe/corefx/labels{/name}","releases_url":"https://api.github.com/repos/mellinoe/corefx/releases{/id}","created_at":"2014-11-14T20:04:38Z","updated_at":"2014-11-14T20:07:32Z","pushed_at":"2015-10-19T23:39:46Z","git_url":"git://github.com/mellinoe/corefx.git","ssh_url":"git@github.com:mellinoe/corefx.git","clone_url":"https://github.com/mellinoe/corefx.git","svn_url":"https://github.com/mellinoe/corefx","homepage":"","size":35836,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:dev/ni-xplat","ref":"dev/ni-xplat","sha":"225fd88af024ee33f66b277d28688d0b04a442a6","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","created_at":"2014-11-06T23:42:48Z","updated_at":"2015-10-20T08:13:21Z","pushed_at":"2015-10-20T16:54:46Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/core/","size":83222,"stargazers_count":8467,"watchers_count":8467,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1851,"mirror_url":null,"open_issues_count":653,"forks":1851,"open_issues":653,"watchers":8467,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/3951"},"html":{"href":"https://github.com/dotnet/corefx/pull/3951"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/3951"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/3951/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/3951/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/3951/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/8e0f1c61634d031c447b6491ee894d8b6efb320e"}}}}