{"action":"closed","number":63,"pull_request":{"url":"https://api.github.com/repos/18F/openFEC-web-app/pulls/63","id":31343612,"html_url":"https://github.com/18F/openFEC-web-app/pull/63","diff_url":"https://github.com/18F/openFEC-web-app/pull/63.diff","patch_url":"https://github.com/18F/openFEC-web-app/pull/63.patch","issue_url":"https://api.github.com/repos/18F/openFEC-web-app/issues/63","number":63,"state":"closed","locked":false,"title":"Making web app Cloud Foundry-ready and creating deploy script","user":{"login":"theresaanna","id":126935,"avatar_url":"https://avatars.githubusercontent.com/u/126935?v=3","gravatar_id":"","url":"https://api.github.com/users/theresaanna","html_url":"https://github.com/theresaanna","followers_url":"https://api.github.com/users/theresaanna/followers","following_url":"https://api.github.com/users/theresaanna/following{/other_user}","gists_url":"https://api.github.com/users/theresaanna/gists{/gist_id}","starred_url":"https://api.github.com/users/theresaanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theresaanna/subscriptions","organizations_url":"https://api.github.com/users/theresaanna/orgs","repos_url":"https://api.github.com/users/theresaanna/repos","events_url":"https://api.github.com/users/theresaanna/events{/privacy}","received_events_url":"https://api.github.com/users/theresaanna/received_events","type":"User","site_admin":false},"body":"**So that you don't break your local**, you will need to define the HTTP username and password as environment vars `FEC_WEB_USERNAME` and `FEC_WEB_PASSWORD`. Locally, you can set these to whatever you want.\r\n\r\nlocal_config.py is no longer needed or supported. Set environment variables if necessary for debug, api location, port and host. You don't need to, though, because the app sets defaults.\r\n\r\nDefaults:\r\ndebug = False\r\napi_location = http://localhost:5000\r\nhost = 0.0.0.0\r\nport = 3000\r\nusername and password that should be used for deploy are the ones currently used for the staging site.\r\n\r\nEnvironment vars (app var = environment var):\r\nport = VCAP_APP_PORT\r\ndebug = FEC_WEB_DEBUG\r\napi_location = FEC_WEB_API_URL\r\nhost = FEC_WEB_HOST\r\nusername = FEC_WEB_USERNAME\r\npassword = FEC_WEB_PASSWORD\r\n\r\nIf you want to deploy to Cloud Foundry, use `deploy.sh`, which builds JS and pushes to CF. It takes four args: CF space, CF app, HTTP auth username and password. \r\n\r\nNotes:\r\n- I'm not happy with the debug var handling, but its the best I could come up with given that CF can only receive a string, not a boolean value.\r\n- I know the default clause in setting the API location in the deploy script will cause the API requests to be unsuccessful. I think this is ok for now until we actually have a prod API. These are the only boxes we're deploying to.","created_at":"2015-03-17T15:08:12Z","updated_at":"2015-03-19T17:44:11Z","closed_at":"2015-03-19T17:44:11Z","merged_at":"2015-03-19T17:44:11Z","merge_commit_sha":"c1aff56d9f9bc4ff6006794a1d22f9cd2a613fcd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/18F/openFEC-web-app/pulls/63/commits","review_comments_url":"https://api.github.com/repos/18F/openFEC-web-app/pulls/63/comments","review_comment_url":"https://api.github.com/repos/18F/openFEC-web-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/18F/openFEC-web-app/issues/63/comments","statuses_url":"https://api.github.com/repos/18F/openFEC-web-app/statuses/8ec840996e2e8e4d12d5015ea2b82f302d8522b4","head":{"label":"18F:cf-config","ref":"cf-config","sha":"8ec840996e2e8e4d12d5015ea2b82f302d8522b4","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":25273785,"name":"openFEC-web-app","full_name":"18F/openFEC-web-app","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/openFEC-web-app","description":"Server- and client-side web application for the OpenFEC data site.","fork":false,"url":"https://api.github.com/repos/18F/openFEC-web-app","forks_url":"https://api.github.com/repos/18F/openFEC-web-app/forks","keys_url":"https://api.github.com/repos/18F/openFEC-web-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/openFEC-web-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/openFEC-web-app/teams","hooks_url":"https://api.github.com/repos/18F/openFEC-web-app/hooks","issue_events_url":"https://api.github.com/repos/18F/openFEC-web-app/issues/events{/number}","events_url":"https://api.github.com/repos/18F/openFEC-web-app/events","assignees_url":"https://api.github.com/repos/18F/openFEC-web-app/assignees{/user}","branches_url":"https://api.github.com/repos/18F/openFEC-web-app/branches{/branch}","tags_url":"https://api.github.com/repos/18F/openFEC-web-app/tags","blobs_url":"https://api.github.com/repos/18F/openFEC-web-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/openFEC-web-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/openFEC-web-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/openFEC-web-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/openFEC-web-app/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/openFEC-web-app/languages","stargazers_url":"https://api.github.com/repos/18F/openFEC-web-app/stargazers","contributors_url":"https://api.github.com/repos/18F/openFEC-web-app/contributors","subscribers_url":"https://api.github.com/repos/18F/openFEC-web-app/subscribers","subscription_url":"https://api.github.com/repos/18F/openFEC-web-app/subscription","commits_url":"https://api.github.com/repos/18F/openFEC-web-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/openFEC-web-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/openFEC-web-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/openFEC-web-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/openFEC-web-app/contents/{+path}","compare_url":"https://api.github.com/repos/18F/openFEC-web-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/openFEC-web-app/merges","archive_url":"https://api.github.com/repos/18F/openFEC-web-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/openFEC-web-app/downloads","issues_url":"https://api.github.com/repos/18F/openFEC-web-app/issues{/number}","pulls_url":"https://api.github.com/repos/18F/openFEC-web-app/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/openFEC-web-app/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/openFEC-web-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/openFEC-web-app/labels{/name}","releases_url":"https://api.github.com/repos/18F/openFEC-web-app/releases{/id}","created_at":"2014-10-15T21:12:32Z","updated_at":"2015-03-19T17:44:11Z","pushed_at":"2015-03-19T17:44:11Z","git_url":"git://github.com/18F/openFEC-web-app.git","ssh_url":"git@github.com:18F/openFEC-web-app.git","clone_url":"https://github.com/18F/openFEC-web-app.git","svn_url":"https://github.com/18F/openFEC-web-app","homepage":"","size":8286,"stargazers_count":6,"watchers_count":6,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":6,"default_branch":"master"}},"base":{"label":"18F:master","ref":"master","sha":"77f9b9ad104425c6306d09ddde4db2e1d02e7bbb","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":25273785,"name":"openFEC-web-app","full_name":"18F/openFEC-web-app","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/openFEC-web-app","description":"Server- and client-side web application for the OpenFEC data site.","fork":false,"url":"https://api.github.com/repos/18F/openFEC-web-app","forks_url":"https://api.github.com/repos/18F/openFEC-web-app/forks","keys_url":"https://api.github.com/repos/18F/openFEC-web-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/openFEC-web-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/openFEC-web-app/teams","hooks_url":"https://api.github.com/repos/18F/openFEC-web-app/hooks","issue_events_url":"https://api.github.com/repos/18F/openFEC-web-app/issues/events{/number}","events_url":"https://api.github.com/repos/18F/openFEC-web-app/events","assignees_url":"https://api.github.com/repos/18F/openFEC-web-app/assignees{/user}","branches_url":"https://api.github.com/repos/18F/openFEC-web-app/branches{/branch}","tags_url":"https://api.github.com/repos/18F/openFEC-web-app/tags","blobs_url":"https://api.github.com/repos/18F/openFEC-web-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/openFEC-web-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/openFEC-web-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/openFEC-web-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/openFEC-web-app/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/openFEC-web-app/languages","stargazers_url":"https://api.github.com/repos/18F/openFEC-web-app/stargazers","contributors_url":"https://api.github.com/repos/18F/openFEC-web-app/contributors","subscribers_url":"https://api.github.com/repos/18F/openFEC-web-app/subscribers","subscription_url":"https://api.github.com/repos/18F/openFEC-web-app/subscription","commits_url":"https://api.github.com/repos/18F/openFEC-web-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/openFEC-web-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/openFEC-web-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/openFEC-web-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/openFEC-web-app/contents/{+path}","compare_url":"https://api.github.com/repos/18F/openFEC-web-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/openFEC-web-app/merges","archive_url":"https://api.github.com/repos/18F/openFEC-web-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/openFEC-web-app/downloads","issues_url":"https://api.github.com/repos/18F/openFEC-web-app/issues{/number}","pulls_url":"https://api.github.com/repos/18F/openFEC-web-app/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/openFEC-web-app/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/openFEC-web-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/openFEC-web-app/labels{/name}","releases_url":"https://api.github.com/repos/18F/openFEC-web-app/releases{/id}","created_at":"2014-10-15T21:12:32Z","updated_at":"2015-03-19T17:44:11Z","pushed_at":"2015-03-19T17:44:11Z","git_url":"git://github.com/18F/openFEC-web-app.git","ssh_url":"git@github.com:18F/openFEC-web-app.git","clone_url":"https://github.com/18F/openFEC-web-app.git","svn_url":"https://github.com/18F/openFEC-web-app","homepage":"","size":8286,"stargazers_count":6,"watchers_count":6,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/18F/openFEC-web-app/pulls/63"},"html":{"href":"https://github.com/18F/openFEC-web-app/pull/63"},"issue":{"href":"https://api.github.com/repos/18F/openFEC-web-app/issues/63"},"comments":{"href":"https://api.github.com/repos/18F/openFEC-web-app/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/18F/openFEC-web-app/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/18F/openFEC-web-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/18F/openFEC-web-app/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/18F/openFEC-web-app/statuses/8ec840996e2e8e4d12d5015ea2b82f302d8522b4"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"cmc333333","id":326918,"avatar_url":"https://avatars.githubusercontent.com/u/326918?v=3","gravatar_id":"","url":"https://api.github.com/users/cmc333333","html_url":"https://github.com/cmc333333","followers_url":"https://api.github.com/users/cmc333333/followers","following_url":"https://api.github.com/users/cmc333333/following{/other_user}","gists_url":"https://api.github.com/users/cmc333333/gists{/gist_id}","starred_url":"https://api.github.com/users/cmc333333/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmc333333/subscriptions","organizations_url":"https://api.github.com/users/cmc333333/orgs","repos_url":"https://api.github.com/users/cmc333333/repos","events_url":"https://api.github.com/users/cmc333333/events{/privacy}","received_events_url":"https://api.github.com/users/cmc333333/received_events","type":"User","site_admin":false},"comments":2,"review_comments":5,"commits":11,"additions":74,"deletions":8,"changed_files":8}}