{"action":"created","comment":{"url":"https://api.github.com/repos/ember-cli/core-object/pulls/comments/23899354","id":23899354,"diff_hunk":"@@ -1,7 +1,16 @@\n-function giveMethodSuper(target, fn) {\n+function giveMethodSuper(superclass, name, fn) {\n+  var superFn = superclass[name];\n+\n+  if (typeof superFn !== 'function') {\n+    superFn = function() {};\n+  }\n+\n+  // jgwhite: Compatibility hack to allow `this._super.foo`\n+  superFn[name] = superFn;","path":"lib/assign-properties.js","position":10,"original_position":10,"commit_id":"f5e10352434748575e568fbb26540387ce7fae56","original_commit_id":"f5e10352434748575e568fbb26540387ce7fae56","user":{"login":"stefanpenner","id":1377,"avatar_url":"https://avatars.githubusercontent.com/u/1377?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanpenner","html_url":"https://github.com/stefanpenner","followers_url":"https://api.github.com/users/stefanpenner/followers","following_url":"https://api.github.com/users/stefanpenner/following{/other_user}","gists_url":"https://api.github.com/users/stefanpenner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanpenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanpenner/subscriptions","organizations_url":"https://api.github.com/users/stefanpenner/orgs","repos_url":"https://api.github.com/users/stefanpenner/repos","events_url":"https://api.github.com/users/stefanpenner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanpenner/received_events","type":"User","site_admin":false},"body":"its a bummer proxies don't really work everywhere, or we code use a proxy to add deprecation calls for when people use this....","created_at":"2015-02-01T17:47:23Z","updated_at":"2015-02-01T17:47:23Z","html_url":"https://github.com/ember-cli/core-object/pull/17#discussion_r23899354","pull_request_url":"https://api.github.com/repos/ember-cli/core-object/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/ember-cli/core-object/pulls/comments/23899354"},"html":{"href":"https://github.com/ember-cli/core-object/pull/17#discussion_r23899354"},"pull_request":{"href":"https://api.github.com/repos/ember-cli/core-object/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/ember-cli/core-object/pulls/17","id":28432543,"html_url":"https://github.com/ember-cli/core-object/pull/17","diff_url":"https://github.com/ember-cli/core-object/pull/17.diff","patch_url":"https://github.com/ember-cli/core-object/pull/17.patch","issue_url":"https://api.github.com/repos/ember-cli/core-object/issues/17","number":17,"state":"open","locked":false,"title":"Support `this._super.foo`","user":{"login":"jgwhite","id":34030,"avatar_url":"https://avatars.githubusercontent.com/u/34030?v=3","gravatar_id":"","url":"https://api.github.com/users/jgwhite","html_url":"https://github.com/jgwhite","followers_url":"https://api.github.com/users/jgwhite/followers","following_url":"https://api.github.com/users/jgwhite/following{/other_user}","gists_url":"https://api.github.com/users/jgwhite/gists{/gist_id}","starred_url":"https://api.github.com/users/jgwhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgwhite/subscriptions","organizations_url":"https://api.github.com/users/jgwhite/orgs","repos_url":"https://api.github.com/users/jgwhite/repos","events_url":"https://api.github.com/users/jgwhite/events{/privacy}","received_events_url":"https://api.github.com/users/jgwhite/received_events","type":"User","site_admin":false},"body":"Adds an interim hack to maintain compatibility with `this._super.foo`.","created_at":"2015-02-01T15:36:23Z","updated_at":"2015-02-01T17:47:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b728f946ffb0663a0b8d6def4c0d29d3ac5fd0f7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ember-cli/core-object/pulls/17/commits","review_comments_url":"https://api.github.com/repos/ember-cli/core-object/pulls/17/comments","review_comment_url":"https://api.github.com/repos/ember-cli/core-object/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ember-cli/core-object/issues/17/comments","statuses_url":"https://api.github.com/repos/ember-cli/core-object/statuses/f5e10352434748575e568fbb26540387ce7fae56","head":{"label":"jgwhite:super-transition","ref":"super-transition","sha":"f5e10352434748575e568fbb26540387ce7fae56","user":{"login":"jgwhite","id":34030,"avatar_url":"https://avatars.githubusercontent.com/u/34030?v=3","gravatar_id":"","url":"https://api.github.com/users/jgwhite","html_url":"https://github.com/jgwhite","followers_url":"https://api.github.com/users/jgwhite/followers","following_url":"https://api.github.com/users/jgwhite/following{/other_user}","gists_url":"https://api.github.com/users/jgwhite/gists{/gist_id}","starred_url":"https://api.github.com/users/jgwhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgwhite/subscriptions","organizations_url":"https://api.github.com/users/jgwhite/orgs","repos_url":"https://api.github.com/users/jgwhite/repos","events_url":"https://api.github.com/users/jgwhite/events{/privacy}","received_events_url":"https://api.github.com/users/jgwhite/received_events","type":"User","site_admin":false},"repo":{"id":29791944,"name":"core-object","full_name":"jgwhite/core-object","owner":{"login":"jgwhite","id":34030,"avatar_url":"https://avatars.githubusercontent.com/u/34030?v=3","gravatar_id":"","url":"https://api.github.com/users/jgwhite","html_url":"https://github.com/jgwhite","followers_url":"https://api.github.com/users/jgwhite/followers","following_url":"https://api.github.com/users/jgwhite/following{/other_user}","gists_url":"https://api.github.com/users/jgwhite/gists{/gist_id}","starred_url":"https://api.github.com/users/jgwhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgwhite/subscriptions","organizations_url":"https://api.github.com/users/jgwhite/orgs","repos_url":"https://api.github.com/users/jgwhite/repos","events_url":"https://api.github.com/users/jgwhite/events{/privacy}","received_events_url":"https://api.github.com/users/jgwhite/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jgwhite/core-object","description":"","fork":true,"url":"https://api.github.com/repos/jgwhite/core-object","forks_url":"https://api.github.com/repos/jgwhite/core-object/forks","keys_url":"https://api.github.com/repos/jgwhite/core-object/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jgwhite/core-object/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jgwhite/core-object/teams","hooks_url":"https://api.github.com/repos/jgwhite/core-object/hooks","issue_events_url":"https://api.github.com/repos/jgwhite/core-object/issues/events{/number}","events_url":"https://api.github.com/repos/jgwhite/core-object/events","assignees_url":"https://api.github.com/repos/jgwhite/core-object/assignees{/user}","branches_url":"https://api.github.com/repos/jgwhite/core-object/branches{/branch}","tags_url":"https://api.github.com/repos/jgwhite/core-object/tags","blobs_url":"https://api.github.com/repos/jgwhite/core-object/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jgwhite/core-object/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jgwhite/core-object/git/refs{/sha}","trees_url":"https://api.github.com/repos/jgwhite/core-object/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jgwhite/core-object/statuses/{sha}","languages_url":"https://api.github.com/repos/jgwhite/core-object/languages","stargazers_url":"https://api.github.com/repos/jgwhite/core-object/stargazers","contributors_url":"https://api.github.com/repos/jgwhite/core-object/contributors","subscribers_url":"https://api.github.com/repos/jgwhite/core-object/subscribers","subscription_url":"https://api.github.com/repos/jgwhite/core-object/subscription","commits_url":"https://api.github.com/repos/jgwhite/core-object/commits{/sha}","git_commits_url":"https://api.github.com/repos/jgwhite/core-object/git/commits{/sha}","comments_url":"https://api.github.com/repos/jgwhite/core-object/comments{/number}","issue_comment_url":"https://api.github.com/repos/jgwhite/core-object/issues/comments/{number}","contents_url":"https://api.github.com/repos/jgwhite/core-object/contents/{+path}","compare_url":"https://api.github.com/repos/jgwhite/core-object/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jgwhite/core-object/merges","archive_url":"https://api.github.com/repos/jgwhite/core-object/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jgwhite/core-object/downloads","issues_url":"https://api.github.com/repos/jgwhite/core-object/issues{/number}","pulls_url":"https://api.github.com/repos/jgwhite/core-object/pulls{/number}","milestones_url":"https://api.github.com/repos/jgwhite/core-object/milestones{/number}","notifications_url":"https://api.github.com/repos/jgwhite/core-object/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jgwhite/core-object/labels{/name}","releases_url":"https://api.github.com/repos/jgwhite/core-object/releases{/id}","created_at":"2015-01-24T21:15:50Z","updated_at":"2015-01-24T21:15:51Z","pushed_at":"2015-02-01T15:35:08Z","git_url":"git://github.com/jgwhite/core-object.git","ssh_url":"git@github.com:jgwhite/core-object.git","clone_url":"https://github.com/jgwhite/core-object.git","svn_url":"https://github.com/jgwhite/core-object","homepage":null,"size":125,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ember-cli:master","ref":"master","sha":"da8f632e20f97db88ffc1499c494d832c4dd7135","user":{"login":"ember-cli","id":10262982,"avatar_url":"https://avatars.githubusercontent.com/u/10262982?v=3","gravatar_id":"","url":"https://api.github.com/users/ember-cli","html_url":"https://github.com/ember-cli","followers_url":"https://api.github.com/users/ember-cli/followers","following_url":"https://api.github.com/users/ember-cli/following{/other_user}","gists_url":"https://api.github.com/users/ember-cli/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-cli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-cli/subscriptions","organizations_url":"https://api.github.com/users/ember-cli/orgs","repos_url":"https://api.github.com/users/ember-cli/repos","events_url":"https://api.github.com/users/ember-cli/events{/privacy}","received_events_url":"https://api.github.com/users/ember-cli/received_events","type":"Organization","site_admin":false},"repo":{"id":20825020,"name":"core-object","full_name":"ember-cli/core-object","owner":{"login":"ember-cli","id":10262982,"avatar_url":"https://avatars.githubusercontent.com/u/10262982?v=3","gravatar_id":"","url":"https://api.github.com/users/ember-cli","html_url":"https://github.com/ember-cli","followers_url":"https://api.github.com/users/ember-cli/followers","following_url":"https://api.github.com/users/ember-cli/following{/other_user}","gists_url":"https://api.github.com/users/ember-cli/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-cli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-cli/subscriptions","organizations_url":"https://api.github.com/users/ember-cli/orgs","repos_url":"https://api.github.com/users/ember-cli/repos","events_url":"https://api.github.com/users/ember-cli/events{/privacy}","received_events_url":"https://api.github.com/users/ember-cli/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ember-cli/core-object","description":"","fork":false,"url":"https://api.github.com/repos/ember-cli/core-object","forks_url":"https://api.github.com/repos/ember-cli/core-object/forks","keys_url":"https://api.github.com/repos/ember-cli/core-object/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ember-cli/core-object/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ember-cli/core-object/teams","hooks_url":"https://api.github.com/repos/ember-cli/core-object/hooks","issue_events_url":"https://api.github.com/repos/ember-cli/core-object/issues/events{/number}","events_url":"https://api.github.com/repos/ember-cli/core-object/events","assignees_url":"https://api.github.com/repos/ember-cli/core-object/assignees{/user}","branches_url":"https://api.github.com/repos/ember-cli/core-object/branches{/branch}","tags_url":"https://api.github.com/repos/ember-cli/core-object/tags","blobs_url":"https://api.github.com/repos/ember-cli/core-object/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ember-cli/core-object/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ember-cli/core-object/git/refs{/sha}","trees_url":"https://api.github.com/repos/ember-cli/core-object/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ember-cli/core-object/statuses/{sha}","languages_url":"https://api.github.com/repos/ember-cli/core-object/languages","stargazers_url":"https://api.github.com/repos/ember-cli/core-object/stargazers","contributors_url":"https://api.github.com/repos/ember-cli/core-object/contributors","subscribers_url":"https://api.github.com/repos/ember-cli/core-object/subscribers","subscription_url":"https://api.github.com/repos/ember-cli/core-object/subscription","commits_url":"https://api.github.com/repos/ember-cli/core-object/commits{/sha}","git_commits_url":"https://api.github.com/repos/ember-cli/core-object/git/commits{/sha}","comments_url":"https://api.github.com/repos/ember-cli/core-object/comments{/number}","issue_comment_url":"https://api.github.com/repos/ember-cli/core-object/issues/comments/{number}","contents_url":"https://api.github.com/repos/ember-cli/core-object/contents/{+path}","compare_url":"https://api.github.com/repos/ember-cli/core-object/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ember-cli/core-object/merges","archive_url":"https://api.github.com/repos/ember-cli/core-object/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ember-cli/core-object/downloads","issues_url":"https://api.github.com/repos/ember-cli/core-object/issues{/number}","pulls_url":"https://api.github.com/repos/ember-cli/core-object/pulls{/number}","milestones_url":"https://api.github.com/repos/ember-cli/core-object/milestones{/number}","notifications_url":"https://api.github.com/repos/ember-cli/core-object/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ember-cli/core-object/labels{/name}","releases_url":"https://api.github.com/repos/ember-cli/core-object/releases{/id}","created_at":"2014-06-14T04:28:53Z","updated_at":"2015-01-21T04:12:20Z","pushed_at":"2015-01-21T04:12:21Z","git_url":"git://github.com/ember-cli/core-object.git","ssh_url":"git@github.com:ember-cli/core-object.git","clone_url":"https://github.com/ember-cli/core-object.git","svn_url":"https://github.com/ember-cli/core-object","homepage":null,"size":351,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ember-cli/core-object/pulls/17"},"html":{"href":"https://github.com/ember-cli/core-object/pull/17"},"issue":{"href":"https://api.github.com/repos/ember-cli/core-object/issues/17"},"comments":{"href":"https://api.github.com/repos/ember-cli/core-object/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/ember-cli/core-object/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/ember-cli/core-object/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ember-cli/core-object/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/ember-cli/core-object/statuses/f5e10352434748575e568fbb26540387ce7fae56"}}}}