{"action":"opened","issue":{"url":"https://api.github.com/repos/sIKE23/Mage-Wars/issues/220","labels_url":"https://api.github.com/repos/sIKE23/Mage-Wars/issues/220/labels{/name}","comments_url":"https://api.github.com/repos/sIKE23/Mage-Wars/issues/220/comments","events_url":"https://api.github.com/repos/sIKE23/Mage-Wars/issues/220/events","html_url":"https://github.com/sIKE23/Mage-Wars/issues/220","id":75407270,"number":220,"title":"Mage Wars Arena and Academy","user":{"login":"sIKE23","id":5695175,"avatar_url":"https://avatars.githubusercontent.com/u/5695175?v=3","gravatar_id":"","url":"https://api.github.com/users/sIKE23","html_url":"https://github.com/sIKE23","followers_url":"https://api.github.com/users/sIKE23/followers","following_url":"https://api.github.com/users/sIKE23/following{/other_user}","gists_url":"https://api.github.com/users/sIKE23/gists{/gist_id}","starred_url":"https://api.github.com/users/sIKE23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sIKE23/subscriptions","organizations_url":"https://api.github.com/users/sIKE23/orgs","repos_url":"https://api.github.com/users/sIKE23/repos","events_url":"https://api.github.com/users/sIKE23/events{/privacy}","received_events_url":"https://api.github.com/users/sIKE23/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/sIKE23/Mage-Wars/labels/Question","name":"Question","color":"cc317c"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-05-12T00:35:58Z","updated_at":"2015-05-12T00:35:58Z","closed_at":null,"body":"So I see a bit of a challenge with how to handle these two games. On one hand they are separate games but on the other hand the cards (and therefore logic and associated game logic) will be (mostly?) forward compatible from Academy to Arena.\r\n\r\nWith this in mind I have been trying to work out in my mind at least how we should handle both games.\r\n\r\nFirst question are both of you @ACG8 and @Kharhaz interesting in being devs on the Academy side?\r\n\r\nThe next thoughts are more free form and what I got from my ongoing attempt at the Academy module. \r\n\r\n* We should try to keep code that is cross compatible between the games as much as possible\r\n* That means we will need to think about on how we should handle code that is not useful for both Academy and Arena, my thoughts are these include OnTableLoad, OnGameStart, OnDeckLoad(maybe), how initiative is handled, phases/turns/reset(maybe?)\r\n* Brine recommends that the games (if they are different OCTGN game modules) have different GUIDs for the set data which means when we fix a single set data issue on one side we have to do it on the other side (at least for the Academy cards)\r\n* With the above thoughts in mind:\r\n\r\n1. Common to both games\r\n   * common.py\r\n   * attacks.py\r\n   * textfunctions.py\r\n   * attachcards.py  $$\r\n2. Academy only\r\n   * academy.py\r\n3. Arena only\r\n   * arena.py\r\n\r\n$$ - will this work? canAttach and canBind are the only functions that I am not sure about. Maybe in each respective game.py file we setGlobalVariable(\"GameType\", \"Arena\" or \"Academy\") and then code in common, attacks and attachcards could have an if on \"GameType\" if need be?\r\n\r\nThis leaves the other biggie I have in mind, the SpellDictionary, how do we handle that with both games?\r\n\r\nOther thoughts and input on these topics are highly desired by me.....\r\n\r\n\r\n"}}