{"action":"created","issue":{"url":"https://api.github.com/repos/ashwin47/Net-Neutral/issues/1","labels_url":"https://api.github.com/repos/ashwin47/Net-Neutral/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/ashwin47/Net-Neutral/issues/1/comments","events_url":"https://api.github.com/repos/ashwin47/Net-Neutral/issues/1/events","html_url":"https://github.com/ashwin47/Net-Neutral/pull/1","id":109184355,"number":1,"title":"Fixed various problems with repo","user":{"login":"rhnvrm","id":952036,"avatar_url":"https://avatars.githubusercontent.com/u/952036?v=3","gravatar_id":"","url":"https://api.github.com/users/rhnvrm","html_url":"https://github.com/rhnvrm","followers_url":"https://api.github.com/users/rhnvrm/followers","following_url":"https://api.github.com/users/rhnvrm/following{/other_user}","gists_url":"https://api.github.com/users/rhnvrm/gists{/gist_id}","starred_url":"https://api.github.com/users/rhnvrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhnvrm/subscriptions","organizations_url":"https://api.github.com/users/rhnvrm/orgs","repos_url":"https://api.github.com/users/rhnvrm/repos","events_url":"https://api.github.com/users/rhnvrm/events{/privacy}","received_events_url":"https://api.github.com/users/rhnvrm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-09-30T21:35:33Z","updated_at":"2015-10-01T08:56:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ashwin47/Net-Neutral/pulls/1","html_url":"https://github.com/ashwin47/Net-Neutral/pull/1","diff_url":"https://github.com/ashwin47/Net-Neutral/pull/1.diff","patch_url":"https://github.com/ashwin47/Net-Neutral/pull/1.patch"},"body":"Hi\r\n\r\nI found some problems with the repo and have fixed them. Here is the summary of my changes:\r\n1. Removed your credentials from the history by using filter-branch\r\n2. Added the missing facebook_start.php which you probably removed yourself earlier but broke the project for cloners. So have added a `cred.php` file in which you can store your credentials and added a note in the readme. It is safely put in gitignore and will not be pushed.\r\n3. You had added files to gitignore but it had not been applied so had to fix untracked files.\r\n\r\nThe changes hopefully should be safe to merge.\r\n\r\nRegards\r\nRohan"},"comment":{"url":"https://api.github.com/repos/ashwin47/Net-Neutral/issues/comments/144661245","html_url":"https://github.com/ashwin47/Net-Neutral/pull/1#issuecomment-144661245","issue_url":"https://api.github.com/repos/ashwin47/Net-Neutral/issues/1","id":144661245,"user":{"login":"rhnvrm","id":952036,"avatar_url":"https://avatars.githubusercontent.com/u/952036?v=3","gravatar_id":"","url":"https://api.github.com/users/rhnvrm","html_url":"https://github.com/rhnvrm","followers_url":"https://api.github.com/users/rhnvrm/followers","following_url":"https://api.github.com/users/rhnvrm/following{/other_user}","gists_url":"https://api.github.com/users/rhnvrm/gists{/gist_id}","starred_url":"https://api.github.com/users/rhnvrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhnvrm/subscriptions","organizations_url":"https://api.github.com/users/rhnvrm/orgs","repos_url":"https://api.github.com/users/rhnvrm/repos","events_url":"https://api.github.com/users/rhnvrm/events{/privacy}","received_events_url":"https://api.github.com/users/rhnvrm/received_events","type":"User","site_admin":false},"created_at":"2015-10-01T08:56:51Z","updated_at":"2015-10-01T08:56:51Z","body":"Somewhat, it wont appear in that but someone has put that tree's link on reddit and hundreds have probably seen it. I have run filter-branch so as to mistakenly not put your credentials again in my fork. This was the link of that tree posted on reddit: https://github.com/ashwin47/Net-Neutral/blob/f53d7c432920d36f2d342c7c7673de4ad0df887d/facebook_start.php\r\n\r\nIt would be better that you just reset your secret key from fb developer dashboard. It's true that there is probably no way to abuse it (because Facebook always checks origin URL, too) however you should not share it...\r\n\r\nThe main thing in my pull request is the way you handle your credentials. You have removed the file `facebook_start.php` which broke the project for anyone who wants to contribute to the project by cloning it/pulling it. So I have added a new file called `cred.php` in which you can store those credentials and not push them to the repo(added to .gitignore). You can see the git diff here: https://github.com/ashwin47/Net-Neutral/pull/1/files\r\n\r\nIf you want to test this, clone https://github.com/rhnvrm/Net-Neutral and run a `php -S localhost:8080` in the directory. Otherwise, I have already tested this on my system and hope this helps your project.\r\n\r\nRegards\r\nRohan\r\n"}}