{"action":"created","issue":{"url":"https://api.github.com/repos/whatwg/dom/issues/114","labels_url":"https://api.github.com/repos/whatwg/dom/issues/114/labels{/name}","comments_url":"https://api.github.com/repos/whatwg/dom/issues/114/comments","events_url":"https://api.github.com/repos/whatwg/dom/issues/114/events","html_url":"https://github.com/whatwg/dom/pull/114","id":118169889,"number":114,"title":"Change DOMTokenList's add() return value.","user":{"login":"yoavweiss","id":786187,"avatar_url":"https://avatars.githubusercontent.com/u/786187?v=3","gravatar_id":"","url":"https://api.github.com/users/yoavweiss","html_url":"https://github.com/yoavweiss","followers_url":"https://api.github.com/users/yoavweiss/followers","following_url":"https://api.github.com/users/yoavweiss/following{/other_user}","gists_url":"https://api.github.com/users/yoavweiss/gists{/gist_id}","starred_url":"https://api.github.com/users/yoavweiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoavweiss/subscriptions","organizations_url":"https://api.github.com/users/yoavweiss/orgs","repos_url":"https://api.github.com/users/yoavweiss/repos","events_url":"https://api.github.com/users/yoavweiss/events{/privacy}","received_events_url":"https://api.github.com/users/yoavweiss/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":28,"created_at":"2015-11-21T04:31:01Z","updated_at":"2015-11-26T13:47:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/whatwg/dom/pulls/114","html_url":"https://github.com/whatwg/dom/pull/114","diff_url":"https://github.com/whatwg/dom/pull/114.diff","patch_url":"https://github.com/whatwg/dom/pull/114.patch"},"body":"As [suggested](https://github.com/whatwg/dom/issues/111#issuecomment-158411312) by @bzbarsky:\r\n\r\nChange the return value of add() to have three states: \"supported\", \"not\r\nsupported\" and \"no supported tokens\".\r\n\r\nThe \"validation steps\" algorithm return values also change accordingly.\r\n\r\n/cc @foolip @zcorpan @annevk "},"comment":{"url":"https://api.github.com/repos/whatwg/dom/issues/comments/159920017","html_url":"https://github.com/whatwg/dom/pull/114#issuecomment-159920017","issue_url":"https://api.github.com/repos/whatwg/dom/issues/114","id":159920017,"user":{"login":"domenic","id":617481,"avatar_url":"https://avatars.githubusercontent.com/u/617481?v=3","gravatar_id":"","url":"https://api.github.com/users/domenic","html_url":"https://github.com/domenic","followers_url":"https://api.github.com/users/domenic/followers","following_url":"https://api.github.com/users/domenic/following{/other_user}","gists_url":"https://api.github.com/users/domenic/gists{/gist_id}","starred_url":"https://api.github.com/users/domenic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domenic/subscriptions","organizations_url":"https://api.github.com/users/domenic/orgs","repos_url":"https://api.github.com/users/domenic/repos","events_url":"https://api.github.com/users/domenic/events{/privacy}","received_events_url":"https://api.github.com/users/domenic/received_events","type":"User","site_admin":false},"created_at":"2015-11-26T13:47:14Z","updated_at":"2015-11-26T13:47:14Z","body":"> We cannot pretend to predict the future, so some kind of a feature detection for having supported tokens is needed. Either a new interface, or a hasSupportedTokens attribute and a supports method on DOMTokenList (I think I prefer the attribute and method approach).\r\n\r\nThis just seems wrong. No feature detection for having supported tokens is needed. We can easily decide which DOMTokenLists have supported tokens once and for all and never have to worry about \"feature detection for having supported tokens\"."}}