{"action":"created","comment":{"url":"https://api.github.com/repos/cakephp/cakephp/pulls/comments/23843191","id":23843191,"diff_hunk":"@@ -556,9 +573,13 @@ protected function _processRules($field, ValidationSet $rules, $data, $newRecord\n                 continue;\n             }\n \n-            $errors[$name] = $message;\n             if (is_string($result)) {\n                 $errors[$name] = $result;\n+            } elseif ($this->_useI18n) {\n+                $args = $rule->get('pass');\n+                $errors[$name] = __d($this->_validationDomain, $name, $this->_translateArgs($args));","path":"src/Validation/Validator.php","position":57,"original_position":57,"commit_id":"88267861fbcae6db4dcea0d8f7d4c633e8d5c8b0","original_commit_id":"88267861fbcae6db4dcea0d8f7d4c633e8d5c8b0","user":{"login":"lorenzo","id":37621,"avatar_url":"https://avatars.githubusercontent.com/u/37621?v=3","gravatar_id":"","url":"https://api.github.com/users/lorenzo","html_url":"https://github.com/lorenzo","followers_url":"https://api.github.com/users/lorenzo/followers","following_url":"https://api.github.com/users/lorenzo/following{/other_user}","gists_url":"https://api.github.com/users/lorenzo/gists{/gist_id}","starred_url":"https://api.github.com/users/lorenzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorenzo/subscriptions","organizations_url":"https://api.github.com/users/lorenzo/orgs","repos_url":"https://api.github.com/users/lorenzo/repos","events_url":"https://api.github.com/users/lorenzo/events{/privacy}","received_events_url":"https://api.github.com/users/lorenzo/received_events","type":"User","site_admin":false},"body":"@ADmad What are the messages that you see repeated the most?","created_at":"2015-01-30T13:55:00Z","updated_at":"2015-01-30T13:55:00Z","html_url":"https://github.com/cakephp/cakephp/pull/5780#discussion_r23843191","pull_request_url":"https://api.github.com/repos/cakephp/cakephp/pulls/5780","_links":{"self":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/comments/23843191"},"html":{"href":"https://github.com/cakephp/cakephp/pull/5780#discussion_r23843191"},"pull_request":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/5780"}}},"pull_request":{"url":"https://api.github.com/repos/cakephp/cakephp/pulls/5780","id":28277543,"html_url":"https://github.com/cakephp/cakephp/pull/5780","diff_url":"https://github.com/cakephp/cakephp/pull/5780.diff","patch_url":"https://github.com/cakephp/cakephp/pull/5780.patch","issue_url":"https://api.github.com/repos/cakephp/cakephp/issues/5780","number":5780,"state":"open","locked":false,"title":"3.0  - WIP - Validation error messages","user":{"login":"ADmad","id":142658,"avatar_url":"https://avatars.githubusercontent.com/u/142658?v=3","gravatar_id":"","url":"https://api.github.com/users/ADmad","html_url":"https://github.com/ADmad","followers_url":"https://api.github.com/users/ADmad/followers","following_url":"https://api.github.com/users/ADmad/following{/other_user}","gists_url":"https://api.github.com/users/ADmad/gists{/gist_id}","starred_url":"https://api.github.com/users/ADmad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ADmad/subscriptions","organizations_url":"https://api.github.com/users/ADmad/orgs","repos_url":"https://api.github.com/users/ADmad/repos","events_url":"https://api.github.com/users/ADmad/events{/privacy}","received_events_url":"https://api.github.com/users/ADmad/received_events","type":"User","site_admin":false},"body":"Which this patch when a message is not set for a rule, the rule name is returned as message. Also the name and rule's arguments are translated as it's done in 2.x.\r\n\r\nThis is still WIP. Tests need to be added, also instead of using default domain ideally the translation domain should be configurable as in 2.x.","created_at":"2015-01-29T13:16:14Z","updated_at":"2015-01-30T13:55:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d63470a1168726773fc03e4a71733a5368639d7a","assignee":null,"milestone":{"url":"https://api.github.com/repos/cakephp/cakephp/milestones/7","labels_url":"https://api.github.com/repos/cakephp/cakephp/milestones/7/labels","id":453043,"number":7,"title":"3.0.0","description":"New major release that breaks compatibility with 2.x\r\n\r\n- PHP5.4.19+\r\n- New ORM & behaviors.\r\n- Improved Routing\r\n- PSR-0 and composer support.\r\n- Simpler configuration and bootstrapping.\r\n- Improved configuration handling.\r\n- Improved bake.\r\n\r\nSee [the roadmap](http://github.com/cakephp/cakephp/wiki/3.0-roadmap) for more details.","creator":{"login":"lh-import","id":5175817,"avatar_url":"https://avatars.githubusercontent.com/u/5175817?v=3","gravatar_id":"","url":"https://api.github.com/users/lh-import","html_url":"https://github.com/lh-import","followers_url":"https://api.github.com/users/lh-import/followers","following_url":"https://api.github.com/users/lh-import/following{/other_user}","gists_url":"https://api.github.com/users/lh-import/gists{/gist_id}","starred_url":"https://api.github.com/users/lh-import/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lh-import/subscriptions","organizations_url":"https://api.github.com/users/lh-import/orgs","repos_url":"https://api.github.com/users/lh-import/repos","events_url":"https://api.github.com/users/lh-import/events{/privacy}","received_events_url":"https://api.github.com/users/lh-import/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":2231,"state":"open","created_at":"2013-10-11T20:56:23Z","updated_at":"2015-01-30T09:11:56Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cakephp/cakephp/pulls/5780/commits","review_comments_url":"https://api.github.com/repos/cakephp/cakephp/pulls/5780/comments","review_comment_url":"https://api.github.com/repos/cakephp/cakephp/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cakephp/cakephp/issues/5780/comments","statuses_url":"https://api.github.com/repos/cakephp/cakephp/statuses/88267861fbcae6db4dcea0d8f7d4c633e8d5c8b0","head":{"label":"ADmad:3.0-validator","ref":"3.0-validator","sha":"88267861fbcae6db4dcea0d8f7d4c633e8d5c8b0","user":{"login":"ADmad","id":142658,"avatar_url":"https://avatars.githubusercontent.com/u/142658?v=3","gravatar_id":"","url":"https://api.github.com/users/ADmad","html_url":"https://github.com/ADmad","followers_url":"https://api.github.com/users/ADmad/followers","following_url":"https://api.github.com/users/ADmad/following{/other_user}","gists_url":"https://api.github.com/users/ADmad/gists{/gist_id}","starred_url":"https://api.github.com/users/ADmad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ADmad/subscriptions","organizations_url":"https://api.github.com/users/ADmad/orgs","repos_url":"https://api.github.com/users/ADmad/repos","events_url":"https://api.github.com/users/ADmad/events{/privacy}","received_events_url":"https://api.github.com/users/ADmad/received_events","type":"User","site_admin":false},"repo":{"id":1198215,"name":"cakephp","full_name":"ADmad/cakephp","owner":{"login":"ADmad","id":142658,"avatar_url":"https://avatars.githubusercontent.com/u/142658?v=3","gravatar_id":"","url":"https://api.github.com/users/ADmad","html_url":"https://github.com/ADmad","followers_url":"https://api.github.com/users/ADmad/followers","following_url":"https://api.github.com/users/ADmad/following{/other_user}","gists_url":"https://api.github.com/users/ADmad/gists{/gist_id}","starred_url":"https://api.github.com/users/ADmad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ADmad/subscriptions","organizations_url":"https://api.github.com/users/ADmad/orgs","repos_url":"https://api.github.com/users/ADmad/repos","events_url":"https://api.github.com/users/ADmad/events{/privacy}","received_events_url":"https://api.github.com/users/ADmad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ADmad/cakephp","description":"CakePHP: The Rapid Development Framework for PHP - Official Repository","fork":true,"url":"https://api.github.com/repos/ADmad/cakephp","forks_url":"https://api.github.com/repos/ADmad/cakephp/forks","keys_url":"https://api.github.com/repos/ADmad/cakephp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ADmad/cakephp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ADmad/cakephp/teams","hooks_url":"https://api.github.com/repos/ADmad/cakephp/hooks","issue_events_url":"https://api.github.com/repos/ADmad/cakephp/issues/events{/number}","events_url":"https://api.github.com/repos/ADmad/cakephp/events","assignees_url":"https://api.github.com/repos/ADmad/cakephp/assignees{/user}","branches_url":"https://api.github.com/repos/ADmad/cakephp/branches{/branch}","tags_url":"https://api.github.com/repos/ADmad/cakephp/tags","blobs_url":"https://api.github.com/repos/ADmad/cakephp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ADmad/cakephp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ADmad/cakephp/git/refs{/sha}","trees_url":"https://api.github.com/repos/ADmad/cakephp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ADmad/cakephp/statuses/{sha}","languages_url":"https://api.github.com/repos/ADmad/cakephp/languages","stargazers_url":"https://api.github.com/repos/ADmad/cakephp/stargazers","contributors_url":"https://api.github.com/repos/ADmad/cakephp/contributors","subscribers_url":"https://api.github.com/repos/ADmad/cakephp/subscribers","subscription_url":"https://api.github.com/repos/ADmad/cakephp/subscription","commits_url":"https://api.github.com/repos/ADmad/cakephp/commits{/sha}","git_commits_url":"https://api.github.com/repos/ADmad/cakephp/git/commits{/sha}","comments_url":"https://api.github.com/repos/ADmad/cakephp/comments{/number}","issue_comment_url":"https://api.github.com/repos/ADmad/cakephp/issues/comments/{number}","contents_url":"https://api.github.com/repos/ADmad/cakephp/contents/{+path}","compare_url":"https://api.github.com/repos/ADmad/cakephp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ADmad/cakephp/merges","archive_url":"https://api.github.com/repos/ADmad/cakephp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ADmad/cakephp/downloads","issues_url":"https://api.github.com/repos/ADmad/cakephp/issues{/number}","pulls_url":"https://api.github.com/repos/ADmad/cakephp/pulls{/number}","milestones_url":"https://api.github.com/repos/ADmad/cakephp/milestones{/number}","notifications_url":"https://api.github.com/repos/ADmad/cakephp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ADmad/cakephp/labels{/name}","releases_url":"https://api.github.com/repos/ADmad/cakephp/releases{/id}","created_at":"2010-12-26T06:44:37Z","updated_at":"2015-01-26T19:38:30Z","pushed_at":"2015-01-29T18:12:36Z","git_url":"git://github.com/ADmad/cakephp.git","ssh_url":"git@github.com:ADmad/cakephp.git","clone_url":"https://github.com/ADmad/cakephp.git","svn_url":"https://github.com/ADmad/cakephp","homepage":"http://cakephp.org","size":68560,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"3.0"}},"base":{"label":"cakephp:3.0","ref":"3.0","sha":"86025b3e779f662b1abec467e03ebe0ca27d726f","user":{"login":"cakephp","id":23666,"avatar_url":"https://avatars.githubusercontent.com/u/23666?v=3","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"repo":{"id":656494,"name":"cakephp","full_name":"cakephp/cakephp","owner":{"login":"cakephp","id":23666,"avatar_url":"https://avatars.githubusercontent.com/u/23666?v=3","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cakephp/cakephp","description":"CakePHP: The Rapid Development Framework for PHP - Official Repository","fork":false,"url":"https://api.github.com/repos/cakephp/cakephp","forks_url":"https://api.github.com/repos/cakephp/cakephp/forks","keys_url":"https://api.github.com/repos/cakephp/cakephp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cakephp/cakephp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cakephp/cakephp/teams","hooks_url":"https://api.github.com/repos/cakephp/cakephp/hooks","issue_events_url":"https://api.github.com/repos/cakephp/cakephp/issues/events{/number}","events_url":"https://api.github.com/repos/cakephp/cakephp/events","assignees_url":"https://api.github.com/repos/cakephp/cakephp/assignees{/user}","branches_url":"https://api.github.com/repos/cakephp/cakephp/branches{/branch}","tags_url":"https://api.github.com/repos/cakephp/cakephp/tags","blobs_url":"https://api.github.com/repos/cakephp/cakephp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cakephp/cakephp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cakephp/cakephp/git/refs{/sha}","trees_url":"https://api.github.com/repos/cakephp/cakephp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cakephp/cakephp/statuses/{sha}","languages_url":"https://api.github.com/repos/cakephp/cakephp/languages","stargazers_url":"https://api.github.com/repos/cakephp/cakephp/stargazers","contributors_url":"https://api.github.com/repos/cakephp/cakephp/contributors","subscribers_url":"https://api.github.com/repos/cakephp/cakephp/subscribers","subscription_url":"https://api.github.com/repos/cakephp/cakephp/subscription","commits_url":"https://api.github.com/repos/cakephp/cakephp/commits{/sha}","git_commits_url":"https://api.github.com/repos/cakephp/cakephp/git/commits{/sha}","comments_url":"https://api.github.com/repos/cakephp/cakephp/comments{/number}","issue_comment_url":"https://api.github.com/repos/cakephp/cakephp/issues/comments/{number}","contents_url":"https://api.github.com/repos/cakephp/cakephp/contents/{+path}","compare_url":"https://api.github.com/repos/cakephp/cakephp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cakephp/cakephp/merges","archive_url":"https://api.github.com/repos/cakephp/cakephp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cakephp/cakephp/downloads","issues_url":"https://api.github.com/repos/cakephp/cakephp/issues{/number}","pulls_url":"https://api.github.com/repos/cakephp/cakephp/pulls{/number}","milestones_url":"https://api.github.com/repos/cakephp/cakephp/milestones{/number}","notifications_url":"https://api.github.com/repos/cakephp/cakephp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cakephp/cakephp/labels{/name}","releases_url":"https://api.github.com/repos/cakephp/cakephp/releases{/id}","created_at":"2010-05-08T14:38:22Z","updated_at":"2015-01-30T13:34:25Z","pushed_at":"2015-01-30T09:11:58Z","git_url":"git://github.com/cakephp/cakephp.git","ssh_url":"git@github.com:cakephp/cakephp.git","clone_url":"https://github.com/cakephp/cakephp.git","svn_url":"https://github.com/cakephp/cakephp","homepage":"http://cakephp.org","size":149560,"stargazers_count":5462,"watchers_count":5462,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2415,"mirror_url":null,"open_issues_count":114,"forks":2415,"open_issues":114,"watchers":5462,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/5780"},"html":{"href":"https://github.com/cakephp/cakephp/pull/5780"},"issue":{"href":"https://api.github.com/repos/cakephp/cakephp/issues/5780"},"comments":{"href":"https://api.github.com/repos/cakephp/cakephp/issues/5780/comments"},"review_comments":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/5780/comments"},"review_comment":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/5780/commits"},"statuses":{"href":"https://api.github.com/repos/cakephp/cakephp/statuses/88267861fbcae6db4dcea0d8f7d4c633e8d5c8b0"}}}}