{"action":"created","issue":{"url":"https://api.github.com/repos/edx/edx-platform/issues/10988","labels_url":"https://api.github.com/repos/edx/edx-platform/issues/10988/labels{/name}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/10988/comments","events_url":"https://api.github.com/repos/edx/edx-platform/issues/10988/events","html_url":"https://github.com/edx/edx-platform/pull/10988","id":122208424,"number":10988,"title":"SOL-1493: Web Certificates: Platform Branding integration","user":{"login":"saleem-latif","id":7114956,"avatar_url":"https://avatars.githubusercontent.com/u/7114956?v=3","gravatar_id":"","url":"https://api.github.com/users/saleem-latif","html_url":"https://github.com/saleem-latif","followers_url":"https://api.github.com/users/saleem-latif/followers","following_url":"https://api.github.com/users/saleem-latif/following{/other_user}","gists_url":"https://api.github.com/users/saleem-latif/gists{/gist_id}","starred_url":"https://api.github.com/users/saleem-latif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saleem-latif/subscriptions","organizations_url":"https://api.github.com/users/saleem-latif/orgs","repos_url":"https://api.github.com/users/saleem-latif/repos","events_url":"https://api.github.com/users/saleem-latif/events{/privacy}","received_events_url":"https://api.github.com/users/saleem-latif/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-12-15T07:12:46Z","updated_at":"2015-12-18T13:20:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/10988","html_url":"https://github.com/edx/edx-platform/pull/10988","diff_url":"https://github.com/edx/edx-platform/pull/10988.diff","patch_url":"https://github.com/edx/edx-platform/pull/10988.patch"},"body":"Hi @ziafazal , @asadiqbal08 ,\r\n\r\nKindly review this PR, it contains changes for [SOL-1493](https://openedx.atlassian.net/browse/SOL-1493).\r\n\r\n__Description of [SOL-1493](https://openedx.atlassian.net/browse/SOL-1493):__\r\n\r\nAs a result of the recent root-cause analysis (RCA) of the broken logo image for edX web certificates, we would like to integrate the branding feature of the platform into this area of the system.\r\nFor example, the `logo_url` parameter is currently configured via the __CertificateHTMLViewConfiguration__ model. We would like to first check to see if a logo definition is provided in the branding configuration via `branding._init_.get_logo_url()`.\r\n\r\nThere are other branding elements to incorporate into the view context as well, such as the URLs for the privacy policy and terms of service. Accessors for these values can be found in various parts of `lms/djangoapps/branding`. It may be useful to provide integration points in the api.py module for specific operations in order to access/test these values/cases individually.\r\nAs with the `logo_url` parameter, we should continue to provide an override capability at the certificate level for all of these values, either via ConfigurationModel or another available mechanism, such as the course-level override field (JSON) available in the Advanced Settings screen.\r\n\r\ncc: @mattdrayer \r\n"},"comment":{"url":"https://api.github.com/repos/edx/edx-platform/issues/comments/165775958","html_url":"https://github.com/edx/edx-platform/pull/10988#issuecomment-165775958","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/10988","id":165775958,"user":{"login":"saleem-latif","id":7114956,"avatar_url":"https://avatars.githubusercontent.com/u/7114956?v=3","gravatar_id":"","url":"https://api.github.com/users/saleem-latif","html_url":"https://github.com/saleem-latif","followers_url":"https://api.github.com/users/saleem-latif/followers","following_url":"https://api.github.com/users/saleem-latif/following{/other_user}","gists_url":"https://api.github.com/users/saleem-latif/gists{/gist_id}","starred_url":"https://api.github.com/users/saleem-latif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saleem-latif/subscriptions","organizations_url":"https://api.github.com/users/saleem-latif/orgs","repos_url":"https://api.github.com/users/saleem-latif/repos","events_url":"https://api.github.com/users/saleem-latif/events{/privacy}","received_events_url":"https://api.github.com/users/saleem-latif/received_events","type":"User","site_admin":false},"created_at":"2015-12-18T13:20:38Z","updated_at":"2015-12-18T13:20:38Z","body":"jenkins run all"}}