{"action":"created","comment":{"url":"https://api.github.com/repos/chris-pearce/scally/pulls/comments/29090071","id":29090071,"diff_hunk":"@@ -114,6 +114,8 @@\n \n @import \"bower_components/scally/core/functions/string-replace\";\n \n+@import \"core/functions/strip-unit\";","path":"style.scss","position":4,"original_position":4,"commit_id":"0b3f2a0f68a62a22ed1e465cb27e3f248d0dec3b","original_commit_id":"0b3f2a0f68a62a22ed1e465cb27e3f248d0dec3b","user":{"login":"stowball","id":853552,"avatar_url":"https://avatars.githubusercontent.com/u/853552?v=3","gravatar_id":"","url":"https://api.github.com/users/stowball","html_url":"https://github.com/stowball","followers_url":"https://api.github.com/users/stowball/followers","following_url":"https://api.github.com/users/stowball/following{/other_user}","gists_url":"https://api.github.com/users/stowball/gists{/gist_id}","starred_url":"https://api.github.com/users/stowball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stowball/subscriptions","organizations_url":"https://api.github.com/users/stowball/orgs","repos_url":"https://api.github.com/users/stowball/repos","events_url":"https://api.github.com/users/stowball/events{/privacy}","received_events_url":"https://api.github.com/users/stowball/received_events","type":"User","site_admin":false},"body":"Ah crap, sorry. It was at this point that I noticed th e font bug and got distracted, and forgot to fix the path :(","created_at":"2015-04-24T22:10:13Z","updated_at":"2015-04-24T22:10:13Z","html_url":"https://github.com/chris-pearce/scally/pull/105#discussion_r29090071","pull_request_url":"https://api.github.com/repos/chris-pearce/scally/pulls/105","_links":{"self":{"href":"https://api.github.com/repos/chris-pearce/scally/pulls/comments/29090071"},"html":{"href":"https://github.com/chris-pearce/scally/pull/105#discussion_r29090071"},"pull_request":{"href":"https://api.github.com/repos/chris-pearce/scally/pulls/105"}}},"pull_request":{"url":"https://api.github.com/repos/chris-pearce/scally/pulls/105","id":34085169,"html_url":"https://github.com/chris-pearce/scally/pull/105","diff_url":"https://github.com/chris-pearce/scally/pull/105.diff","patch_url":"https://github.com/chris-pearce/scally/pull/105.patch","issue_url":"https://api.github.com/repos/chris-pearce/scally/issues/105","number":105,"state":"open","locked":false,"title":"Strip units on passed in values to em/rem functions & mixins. Fixes #80","user":{"login":"stowball","id":853552,"avatar_url":"https://avatars.githubusercontent.com/u/853552?v=3","gravatar_id":"","url":"https://api.github.com/users/stowball","html_url":"https://github.com/stowball","followers_url":"https://api.github.com/users/stowball/followers","following_url":"https://api.github.com/users/stowball/following{/other_user}","gists_url":"https://api.github.com/users/stowball/gists{/gist_id}","starred_url":"https://api.github.com/users/stowball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stowball/subscriptions","organizations_url":"https://api.github.com/users/stowball/orgs","repos_url":"https://api.github.com/users/stowball/repos","events_url":"https://api.github.com/users/stowball/events{/privacy}","received_events_url":"https://api.github.com/users/stowball/received_events","type":"User","site_admin":false},"body":"I've implemented `strip-units` to make these functions and mixins more robust. It also makes it less annoying when you have to change from raw px values to a function or mixin.\r\n\r\nAs v2 of Scally is no longer using `rem`s on things like `border` and `box-shadow`, it makes it inconsistent that for these properties you have to type `px` values, but for `em` and `rem` functions, you have to use unitless.\r\n\r\nAt CM, I encountered this where I set variables for `width`s, and then @chris-pearce asked me to convert them to `rem`s. At first I just wrapped them in a `to-rem()` function, but that errored, so had to change my values.\r\n\r\nWith this PR, a user can mix and match or use whatever they prefer.","created_at":"2015-04-24T20:52:54Z","updated_at":"2015-04-24T22:10:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2116b7a960331cd5e02637c2ea21bb683ad33b7c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/chris-pearce/scally/pulls/105/commits","review_comments_url":"https://api.github.com/repos/chris-pearce/scally/pulls/105/comments","review_comment_url":"https://api.github.com/repos/chris-pearce/scally/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chris-pearce/scally/issues/105/comments","statuses_url":"https://api.github.com/repos/chris-pearce/scally/statuses/0b3f2a0f68a62a22ed1e465cb27e3f248d0dec3b","head":{"label":"stowball:strip-unit","ref":"strip-unit","sha":"0b3f2a0f68a62a22ed1e465cb27e3f248d0dec3b","user":{"login":"stowball","id":853552,"avatar_url":"https://avatars.githubusercontent.com/u/853552?v=3","gravatar_id":"","url":"https://api.github.com/users/stowball","html_url":"https://github.com/stowball","followers_url":"https://api.github.com/users/stowball/followers","following_url":"https://api.github.com/users/stowball/following{/other_user}","gists_url":"https://api.github.com/users/stowball/gists{/gist_id}","starred_url":"https://api.github.com/users/stowball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stowball/subscriptions","organizations_url":"https://api.github.com/users/stowball/orgs","repos_url":"https://api.github.com/users/stowball/repos","events_url":"https://api.github.com/users/stowball/events{/privacy}","received_events_url":"https://api.github.com/users/stowball/received_events","type":"User","site_admin":false},"repo":{"id":32665516,"name":"scally","full_name":"stowball/scally","owner":{"login":"stowball","id":853552,"avatar_url":"https://avatars.githubusercontent.com/u/853552?v=3","gravatar_id":"","url":"https://api.github.com/users/stowball","html_url":"https://github.com/stowball","followers_url":"https://api.github.com/users/stowball/followers","following_url":"https://api.github.com/users/stowball/following{/other_user}","gists_url":"https://api.github.com/users/stowball/gists{/gist_id}","starred_url":"https://api.github.com/users/stowball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stowball/subscriptions","organizations_url":"https://api.github.com/users/stowball/orgs","repos_url":"https://api.github.com/users/stowball/repos","events_url":"https://api.github.com/users/stowball/events{/privacy}","received_events_url":"https://api.github.com/users/stowball/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stowball/scally","description":"Scally is a Sass-based, BEM, OOCSS, responsive ready, CSS framework that provides you with a solid foundation for building reusable UI's quickly","fork":true,"url":"https://api.github.com/repos/stowball/scally","forks_url":"https://api.github.com/repos/stowball/scally/forks","keys_url":"https://api.github.com/repos/stowball/scally/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stowball/scally/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stowball/scally/teams","hooks_url":"https://api.github.com/repos/stowball/scally/hooks","issue_events_url":"https://api.github.com/repos/stowball/scally/issues/events{/number}","events_url":"https://api.github.com/repos/stowball/scally/events","assignees_url":"https://api.github.com/repos/stowball/scally/assignees{/user}","branches_url":"https://api.github.com/repos/stowball/scally/branches{/branch}","tags_url":"https://api.github.com/repos/stowball/scally/tags","blobs_url":"https://api.github.com/repos/stowball/scally/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stowball/scally/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stowball/scally/git/refs{/sha}","trees_url":"https://api.github.com/repos/stowball/scally/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stowball/scally/statuses/{sha}","languages_url":"https://api.github.com/repos/stowball/scally/languages","stargazers_url":"https://api.github.com/repos/stowball/scally/stargazers","contributors_url":"https://api.github.com/repos/stowball/scally/contributors","subscribers_url":"https://api.github.com/repos/stowball/scally/subscribers","subscription_url":"https://api.github.com/repos/stowball/scally/subscription","commits_url":"https://api.github.com/repos/stowball/scally/commits{/sha}","git_commits_url":"https://api.github.com/repos/stowball/scally/git/commits{/sha}","comments_url":"https://api.github.com/repos/stowball/scally/comments{/number}","issue_comment_url":"https://api.github.com/repos/stowball/scally/issues/comments{/number}","contents_url":"https://api.github.com/repos/stowball/scally/contents/{+path}","compare_url":"https://api.github.com/repos/stowball/scally/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stowball/scally/merges","archive_url":"https://api.github.com/repos/stowball/scally/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stowball/scally/downloads","issues_url":"https://api.github.com/repos/stowball/scally/issues{/number}","pulls_url":"https://api.github.com/repos/stowball/scally/pulls{/number}","milestones_url":"https://api.github.com/repos/stowball/scally/milestones{/number}","notifications_url":"https://api.github.com/repos/stowball/scally/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stowball/scally/labels{/name}","releases_url":"https://api.github.com/repos/stowball/scally/releases{/id}","created_at":"2015-03-22T06:52:16Z","updated_at":"2015-04-24T11:44:50Z","pushed_at":"2015-04-24T20:49:03Z","git_url":"git://github.com/stowball/scally.git","ssh_url":"git@github.com:stowball/scally.git","clone_url":"https://github.com/stowball/scally.git","svn_url":"https://github.com/stowball/scally","homepage":"https://twitter.com/scally_fw","size":941,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chris-pearce:master","ref":"master","sha":"48aa15904d5fae3346f2ff3ab9a3471a598f3f37","user":{"login":"chris-pearce","id":1342772,"avatar_url":"https://avatars.githubusercontent.com/u/1342772?v=3","gravatar_id":"","url":"https://api.github.com/users/chris-pearce","html_url":"https://github.com/chris-pearce","followers_url":"https://api.github.com/users/chris-pearce/followers","following_url":"https://api.github.com/users/chris-pearce/following{/other_user}","gists_url":"https://api.github.com/users/chris-pearce/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-pearce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-pearce/subscriptions","organizations_url":"https://api.github.com/users/chris-pearce/orgs","repos_url":"https://api.github.com/users/chris-pearce/repos","events_url":"https://api.github.com/users/chris-pearce/events{/privacy}","received_events_url":"https://api.github.com/users/chris-pearce/received_events","type":"User","site_admin":false},"repo":{"id":28907616,"name":"scally","full_name":"chris-pearce/scally","owner":{"login":"chris-pearce","id":1342772,"avatar_url":"https://avatars.githubusercontent.com/u/1342772?v=3","gravatar_id":"","url":"https://api.github.com/users/chris-pearce","html_url":"https://github.com/chris-pearce","followers_url":"https://api.github.com/users/chris-pearce/followers","following_url":"https://api.github.com/users/chris-pearce/following{/other_user}","gists_url":"https://api.github.com/users/chris-pearce/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-pearce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-pearce/subscriptions","organizations_url":"https://api.github.com/users/chris-pearce/orgs","repos_url":"https://api.github.com/users/chris-pearce/repos","events_url":"https://api.github.com/users/chris-pearce/events{/privacy}","received_events_url":"https://api.github.com/users/chris-pearce/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chris-pearce/scally","description":"Scally is a Sass-based, BEM, OOCSS, responsive ready, CSS framework that provides you with a solid foundation for building reusable UI's quickly","fork":false,"url":"https://api.github.com/repos/chris-pearce/scally","forks_url":"https://api.github.com/repos/chris-pearce/scally/forks","keys_url":"https://api.github.com/repos/chris-pearce/scally/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chris-pearce/scally/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chris-pearce/scally/teams","hooks_url":"https://api.github.com/repos/chris-pearce/scally/hooks","issue_events_url":"https://api.github.com/repos/chris-pearce/scally/issues/events{/number}","events_url":"https://api.github.com/repos/chris-pearce/scally/events","assignees_url":"https://api.github.com/repos/chris-pearce/scally/assignees{/user}","branches_url":"https://api.github.com/repos/chris-pearce/scally/branches{/branch}","tags_url":"https://api.github.com/repos/chris-pearce/scally/tags","blobs_url":"https://api.github.com/repos/chris-pearce/scally/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chris-pearce/scally/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chris-pearce/scally/git/refs{/sha}","trees_url":"https://api.github.com/repos/chris-pearce/scally/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chris-pearce/scally/statuses/{sha}","languages_url":"https://api.github.com/repos/chris-pearce/scally/languages","stargazers_url":"https://api.github.com/repos/chris-pearce/scally/stargazers","contributors_url":"https://api.github.com/repos/chris-pearce/scally/contributors","subscribers_url":"https://api.github.com/repos/chris-pearce/scally/subscribers","subscription_url":"https://api.github.com/repos/chris-pearce/scally/subscription","commits_url":"https://api.github.com/repos/chris-pearce/scally/commits{/sha}","git_commits_url":"https://api.github.com/repos/chris-pearce/scally/git/commits{/sha}","comments_url":"https://api.github.com/repos/chris-pearce/scally/comments{/number}","issue_comment_url":"https://api.github.com/repos/chris-pearce/scally/issues/comments{/number}","contents_url":"https://api.github.com/repos/chris-pearce/scally/contents/{+path}","compare_url":"https://api.github.com/repos/chris-pearce/scally/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chris-pearce/scally/merges","archive_url":"https://api.github.com/repos/chris-pearce/scally/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chris-pearce/scally/downloads","issues_url":"https://api.github.com/repos/chris-pearce/scally/issues{/number}","pulls_url":"https://api.github.com/repos/chris-pearce/scally/pulls{/number}","milestones_url":"https://api.github.com/repos/chris-pearce/scally/milestones{/number}","notifications_url":"https://api.github.com/repos/chris-pearce/scally/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chris-pearce/scally/labels{/name}","releases_url":"https://api.github.com/repos/chris-pearce/scally/releases{/id}","created_at":"2015-01-07T09:21:58Z","updated_at":"2015-04-24T21:54:34Z","pushed_at":"2015-04-24T21:54:33Z","git_url":"git://github.com/chris-pearce/scally.git","ssh_url":"git@github.com:chris-pearce/scally.git","clone_url":"https://github.com/chris-pearce/scally.git","svn_url":"https://github.com/chris-pearce/scally","homepage":"https://twitter.com/scally_fw","size":2010,"stargazers_count":42,"watchers_count":42,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":30,"forks":5,"open_issues":30,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chris-pearce/scally/pulls/105"},"html":{"href":"https://github.com/chris-pearce/scally/pull/105"},"issue":{"href":"https://api.github.com/repos/chris-pearce/scally/issues/105"},"comments":{"href":"https://api.github.com/repos/chris-pearce/scally/issues/105/comments"},"review_comments":{"href":"https://api.github.com/repos/chris-pearce/scally/pulls/105/comments"},"review_comment":{"href":"https://api.github.com/repos/chris-pearce/scally/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chris-pearce/scally/pulls/105/commits"},"statuses":{"href":"https://api.github.com/repos/chris-pearce/scally/statuses/0b3f2a0f68a62a22ed1e465cb27e3f248d0dec3b"}}}}