{"action":"created","comment":{"url":"https://api.github.com/repos/square/p2/pulls/comments/40572480","id":40572480,"diff_hunk":"@@ -0,0 +1,32 @@\n+package rcstore\n+\n+import (\n+\t\"github.com/square/p2/pkg/labels\"\n+\t\"github.com/square/p2/pkg/pods\"\n+\t\"github.com/square/p2/pkg/rc/fields\"\n+)\n+\n+// Store represents an interface for persisting replication controllers to Consul,\n+// as well as restoring replication controllers from Consul.\n+type Store interface {\n+\t// Create creates a replication controller with the specified manifest and selectors.\n+\t// The node selector is used to determine what nodes the replication controller may schedule on.\n+\t// The pod label set is:\n+\t// 1) applied to every pod the replication controller schedules,\n+\t// 2) used (in addition to replication controller ID) to determine what pods are already scheduled.","path":"pkg/kp/rcstore/store.go","position":16,"original_position":16,"commit_id":"694882ca5cd51e0d3dd9340eb0d14ef274eba66e","original_commit_id":"34710b2dce66aa765f875725affff55da94a2e3d","user":{"login":"anthonybishopric","id":540783,"avatar_url":"https://avatars.githubusercontent.com/u/540783?v=3","gravatar_id":"","url":"https://api.github.com/users/anthonybishopric","html_url":"https://github.com/anthonybishopric","followers_url":"https://api.github.com/users/anthonybishopric/followers","following_url":"https://api.github.com/users/anthonybishopric/following{/other_user}","gists_url":"https://api.github.com/users/anthonybishopric/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonybishopric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonybishopric/subscriptions","organizations_url":"https://api.github.com/users/anthonybishopric/orgs","repos_url":"https://api.github.com/users/anthonybishopric/repos","events_url":"https://api.github.com/users/anthonybishopric/events{/privacy}","received_events_url":"https://api.github.com/users/anthonybishopric/received_events","type":"User","site_admin":false},"body":"Good question. Given that users can submit additional labels and selectors for replication controllers, it seems easy to implement totally distinct controllers on top of overlapping controllers. Harder to go the other way if the RC requires its own ID always be present in the selector. @bwester @mpuncel what do you think?","created_at":"2015-09-28T16:24:00Z","updated_at":"2015-09-28T16:24:00Z","html_url":"https://github.com/square/p2/pull/247#discussion_r40572480","pull_request_url":"https://api.github.com/repos/square/p2/pulls/247","_links":{"self":{"href":"https://api.github.com/repos/square/p2/pulls/comments/40572480"},"html":{"href":"https://github.com/square/p2/pull/247#discussion_r40572480"},"pull_request":{"href":"https://api.github.com/repos/square/p2/pulls/247"}}},"pull_request":{"url":"https://api.github.com/repos/square/p2/pulls/247","id":44824949,"html_url":"https://github.com/square/p2/pull/247","diff_url":"https://github.com/square/p2/pull/247.diff","patch_url":"https://github.com/square/p2/pull/247.patch","issue_url":"https://api.github.com/repos/square/p2/issues/247","number":247,"state":"open","locked":false,"title":"Add replication controller interface, implementation, and tests","user":{"login":"petertseng","id":346181,"avatar_url":"https://avatars.githubusercontent.com/u/346181?v=3","gravatar_id":"","url":"https://api.github.com/users/petertseng","html_url":"https://github.com/petertseng","followers_url":"https://api.github.com/users/petertseng/followers","following_url":"https://api.github.com/users/petertseng/following{/other_user}","gists_url":"https://api.github.com/users/petertseng/gists{/gist_id}","starred_url":"https://api.github.com/users/petertseng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petertseng/subscriptions","organizations_url":"https://api.github.com/users/petertseng/orgs","repos_url":"https://api.github.com/users/petertseng/repos","events_url":"https://api.github.com/users/petertseng/events{/privacy}","received_events_url":"https://api.github.com/users/petertseng/received_events","type":"User","site_admin":false},"body":"Includes an rcstore (replication controller store) for storing replication controllers. Currently rcstore only has a fake implementation (in memory, for tests) - a Consul-backed implementation will come in a later PR.\r\n\r\nReplication Controller functionality is complete and includes tests.","created_at":"2015-09-11T20:23:04Z","updated_at":"2015-09-28T16:24:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2daadc566d88b7a3995e147743ef7f6c986c9a3b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/square/p2/pulls/247/commits","review_comments_url":"https://api.github.com/repos/square/p2/pulls/247/comments","review_comment_url":"https://api.github.com/repos/square/p2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/square/p2/issues/247/comments","statuses_url":"https://api.github.com/repos/square/p2/statuses/694882ca5cd51e0d3dd9340eb0d14ef274eba66e","head":{"label":"petertseng:rc","ref":"rc","sha":"694882ca5cd51e0d3dd9340eb0d14ef274eba66e","user":{"login":"petertseng","id":346181,"avatar_url":"https://avatars.githubusercontent.com/u/346181?v=3","gravatar_id":"","url":"https://api.github.com/users/petertseng","html_url":"https://github.com/petertseng","followers_url":"https://api.github.com/users/petertseng/followers","following_url":"https://api.github.com/users/petertseng/following{/other_user}","gists_url":"https://api.github.com/users/petertseng/gists{/gist_id}","starred_url":"https://api.github.com/users/petertseng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petertseng/subscriptions","organizations_url":"https://api.github.com/users/petertseng/orgs","repos_url":"https://api.github.com/users/petertseng/repos","events_url":"https://api.github.com/users/petertseng/events{/privacy}","received_events_url":"https://api.github.com/users/petertseng/received_events","type":"User","site_admin":false},"repo":{"id":38632684,"name":"p2","full_name":"petertseng/p2","owner":{"login":"petertseng","id":346181,"avatar_url":"https://avatars.githubusercontent.com/u/346181?v=3","gravatar_id":"","url":"https://api.github.com/users/petertseng","html_url":"https://github.com/petertseng","followers_url":"https://api.github.com/users/petertseng/followers","following_url":"https://api.github.com/users/petertseng/following{/other_user}","gists_url":"https://api.github.com/users/petertseng/gists{/gist_id}","starred_url":"https://api.github.com/users/petertseng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petertseng/subscriptions","organizations_url":"https://api.github.com/users/petertseng/orgs","repos_url":"https://api.github.com/users/petertseng/repos","events_url":"https://api.github.com/users/petertseng/events{/privacy}","received_events_url":"https://api.github.com/users/petertseng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/petertseng/p2","description":"Platypus Platform: Tools for Scalable Deployment","fork":true,"url":"https://api.github.com/repos/petertseng/p2","forks_url":"https://api.github.com/repos/petertseng/p2/forks","keys_url":"https://api.github.com/repos/petertseng/p2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/petertseng/p2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/petertseng/p2/teams","hooks_url":"https://api.github.com/repos/petertseng/p2/hooks","issue_events_url":"https://api.github.com/repos/petertseng/p2/issues/events{/number}","events_url":"https://api.github.com/repos/petertseng/p2/events","assignees_url":"https://api.github.com/repos/petertseng/p2/assignees{/user}","branches_url":"https://api.github.com/repos/petertseng/p2/branches{/branch}","tags_url":"https://api.github.com/repos/petertseng/p2/tags","blobs_url":"https://api.github.com/repos/petertseng/p2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/petertseng/p2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/petertseng/p2/git/refs{/sha}","trees_url":"https://api.github.com/repos/petertseng/p2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/petertseng/p2/statuses/{sha}","languages_url":"https://api.github.com/repos/petertseng/p2/languages","stargazers_url":"https://api.github.com/repos/petertseng/p2/stargazers","contributors_url":"https://api.github.com/repos/petertseng/p2/contributors","subscribers_url":"https://api.github.com/repos/petertseng/p2/subscribers","subscription_url":"https://api.github.com/repos/petertseng/p2/subscription","commits_url":"https://api.github.com/repos/petertseng/p2/commits{/sha}","git_commits_url":"https://api.github.com/repos/petertseng/p2/git/commits{/sha}","comments_url":"https://api.github.com/repos/petertseng/p2/comments{/number}","issue_comment_url":"https://api.github.com/repos/petertseng/p2/issues/comments{/number}","contents_url":"https://api.github.com/repos/petertseng/p2/contents/{+path}","compare_url":"https://api.github.com/repos/petertseng/p2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/petertseng/p2/merges","archive_url":"https://api.github.com/repos/petertseng/p2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/petertseng/p2/downloads","issues_url":"https://api.github.com/repos/petertseng/p2/issues{/number}","pulls_url":"https://api.github.com/repos/petertseng/p2/pulls{/number}","milestones_url":"https://api.github.com/repos/petertseng/p2/milestones{/number}","notifications_url":"https://api.github.com/repos/petertseng/p2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/petertseng/p2/labels{/name}","releases_url":"https://api.github.com/repos/petertseng/p2/releases{/id}","created_at":"2015-07-06T16:51:15Z","updated_at":"2015-07-06T16:51:15Z","pushed_at":"2015-09-26T01:25:01Z","git_url":"git://github.com/petertseng/p2.git","ssh_url":"git@github.com:petertseng/p2.git","clone_url":"https://github.com/petertseng/p2.git","svn_url":"https://github.com/petertseng/p2","homepage":"","size":28201,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"square:master","ref":"master","sha":"31ba82f19d1c363db1433db2d072f5389d6b0bbd","user":{"login":"square","id":82592,"avatar_url":"https://avatars.githubusercontent.com/u/82592?v=3","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"repo":{"id":25320424,"name":"p2","full_name":"square/p2","owner":{"login":"square","id":82592,"avatar_url":"https://avatars.githubusercontent.com/u/82592?v=3","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/square/p2","description":"Platypus Platform: Tools for Scalable Deployment","fork":false,"url":"https://api.github.com/repos/square/p2","forks_url":"https://api.github.com/repos/square/p2/forks","keys_url":"https://api.github.com/repos/square/p2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/square/p2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/square/p2/teams","hooks_url":"https://api.github.com/repos/square/p2/hooks","issue_events_url":"https://api.github.com/repos/square/p2/issues/events{/number}","events_url":"https://api.github.com/repos/square/p2/events","assignees_url":"https://api.github.com/repos/square/p2/assignees{/user}","branches_url":"https://api.github.com/repos/square/p2/branches{/branch}","tags_url":"https://api.github.com/repos/square/p2/tags","blobs_url":"https://api.github.com/repos/square/p2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/square/p2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/square/p2/git/refs{/sha}","trees_url":"https://api.github.com/repos/square/p2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/square/p2/statuses/{sha}","languages_url":"https://api.github.com/repos/square/p2/languages","stargazers_url":"https://api.github.com/repos/square/p2/stargazers","contributors_url":"https://api.github.com/repos/square/p2/contributors","subscribers_url":"https://api.github.com/repos/square/p2/subscribers","subscription_url":"https://api.github.com/repos/square/p2/subscription","commits_url":"https://api.github.com/repos/square/p2/commits{/sha}","git_commits_url":"https://api.github.com/repos/square/p2/git/commits{/sha}","comments_url":"https://api.github.com/repos/square/p2/comments{/number}","issue_comment_url":"https://api.github.com/repos/square/p2/issues/comments{/number}","contents_url":"https://api.github.com/repos/square/p2/contents/{+path}","compare_url":"https://api.github.com/repos/square/p2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/square/p2/merges","archive_url":"https://api.github.com/repos/square/p2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/square/p2/downloads","issues_url":"https://api.github.com/repos/square/p2/issues{/number}","pulls_url":"https://api.github.com/repos/square/p2/pulls{/number}","milestones_url":"https://api.github.com/repos/square/p2/milestones{/number}","notifications_url":"https://api.github.com/repos/square/p2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/square/p2/labels{/name}","releases_url":"https://api.github.com/repos/square/p2/releases{/id}","created_at":"2014-10-16T20:31:12Z","updated_at":"2015-09-22T11:47:05Z","pushed_at":"2015-09-26T01:21:41Z","git_url":"git://github.com/square/p2.git","ssh_url":"git@github.com:square/p2.git","clone_url":"https://github.com/square/p2.git","svn_url":"https://github.com/square/p2","homepage":"","size":33016,"stargazers_count":62,"watchers_count":62,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":5,"forks":12,"open_issues":5,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/square/p2/pulls/247"},"html":{"href":"https://github.com/square/p2/pull/247"},"issue":{"href":"https://api.github.com/repos/square/p2/issues/247"},"comments":{"href":"https://api.github.com/repos/square/p2/issues/247/comments"},"review_comments":{"href":"https://api.github.com/repos/square/p2/pulls/247/comments"},"review_comment":{"href":"https://api.github.com/repos/square/p2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/square/p2/pulls/247/commits"},"statuses":{"href":"https://api.github.com/repos/square/p2/statuses/694882ca5cd51e0d3dd9340eb0d14ef274eba66e"}}}}