{"action":"created","issue":{"url":"https://api.github.com/repos/ministryofjustice/money-to-prisoners-cashbook/issues/30","labels_url":"https://api.github.com/repos/ministryofjustice/money-to-prisoners-cashbook/issues/30/labels{/name}","comments_url":"https://api.github.com/repos/ministryofjustice/money-to-prisoners-cashbook/issues/30/comments","events_url":"https://api.github.com/repos/ministryofjustice/money-to-prisoners-cashbook/issues/30/events","html_url":"https://github.com/ministryofjustice/money-to-prisoners-cashbook/pull/30","id":94895299,"number":30,"title":"Add linting helper and fix existing linting issues","user":{"login":"SteveMarshall","id":2210,"avatar_url":"https://avatars.githubusercontent.com/u/2210?v=3","gravatar_id":"","url":"https://api.github.com/users/SteveMarshall","html_url":"https://github.com/SteveMarshall","followers_url":"https://api.github.com/users/SteveMarshall/followers","following_url":"https://api.github.com/users/SteveMarshall/following{/other_user}","gists_url":"https://api.github.com/users/SteveMarshall/gists{/gist_id}","starred_url":"https://api.github.com/users/SteveMarshall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SteveMarshall/subscriptions","organizations_url":"https://api.github.com/users/SteveMarshall/orgs","repos_url":"https://api.github.com/users/SteveMarshall/repos","events_url":"https://api.github.com/users/SteveMarshall/events{/privacy}","received_events_url":"https://api.github.com/users/SteveMarshall/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-07-14T08:36:53Z","updated_at":"2015-07-14T14:16:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ministryofjustice/money-to-prisoners-cashbook/pulls/30","html_url":"https://github.com/ministryofjustice/money-to-prisoners-cashbook/pull/30","diff_url":"https://github.com/ministryofjustice/money-to-prisoners-cashbook/pull/30.diff","patch_url":"https://github.com/ministryofjustice/money-to-prisoners-cashbook/pull/30.patch"},"body":"We need an easy way of checking that our code matches [pep8](https://www.python.org/dev/peps/pep-0008/) (Python's style guide). This adds `make lint` for that purpose, and fixes existing linting errors.\r\n\r\nIt's probably worth reviewing this one commit at a time. Once it's merged to master, I'll look at linting in Jenkins."},"comment":{"url":"https://api.github.com/repos/ministryofjustice/money-to-prisoners-cashbook/issues/comments/121250707","html_url":"https://github.com/ministryofjustice/money-to-prisoners-cashbook/pull/30#issuecomment-121250707","issue_url":"https://api.github.com/repos/ministryofjustice/money-to-prisoners-cashbook/issues/30","id":121250707,"user":{"login":"marcofucci","id":178865,"avatar_url":"https://avatars.githubusercontent.com/u/178865?v=3","gravatar_id":"","url":"https://api.github.com/users/marcofucci","html_url":"https://github.com/marcofucci","followers_url":"https://api.github.com/users/marcofucci/followers","following_url":"https://api.github.com/users/marcofucci/following{/other_user}","gists_url":"https://api.github.com/users/marcofucci/gists{/gist_id}","starred_url":"https://api.github.com/users/marcofucci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcofucci/subscriptions","organizations_url":"https://api.github.com/users/marcofucci/orgs","repos_url":"https://api.github.com/users/marcofucci/repos","events_url":"https://api.github.com/users/marcofucci/events{/privacy}","received_events_url":"https://api.github.com/users/marcofucci/received_events","type":"User","site_admin":false},"created_at":"2015-07-14T14:16:35Z","updated_at":"2015-07-14T14:16:35Z","body":"@SteveMarshall that's because most of the changes are related to the line length.\r\nWe could talk about it for hours and still don't agree, I'm the only dev at the moment and I would very much like long lines but I guess you have made your decision so don't want to spend more time on this.\r\n\r\nRe. the E128, I'd rather add it to the `setup.cfg` for the future and, if you want, fix the urlpatterns deprecation. I really don't want to keep the urlpatterns like that, it looks terrible.\r\n\r\nI'll add the other Es and Ws to the ignore setting when we need in the future. "}}