{"comment":{"url":"https://api.github.com/repos/s9y/Serendipity/comments/11610814","html_url":"https://github.com/s9y/Serendipity/commit/2a63e351a558a5b05e37a473e101f46d416f8218#commitcomment-11610814","id":11610814,"user":{"login":"onli","id":900380,"avatar_url":"https://avatars.githubusercontent.com/u/900380?v=3","gravatar_id":"","url":"https://api.github.com/users/onli","html_url":"https://github.com/onli","followers_url":"https://api.github.com/users/onli/followers","following_url":"https://api.github.com/users/onli/following{/other_user}","gists_url":"https://api.github.com/users/onli/gists{/gist_id}","starred_url":"https://api.github.com/users/onli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onli/subscriptions","organizations_url":"https://api.github.com/users/onli/orgs","repos_url":"https://api.github.com/users/onli/repos","events_url":"https://api.github.com/users/onli/events{/privacy}","received_events_url":"https://api.github.com/users/onli/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"2a63e351a558a5b05e37a473e101f46d416f8218","created_at":"2015-06-10T13:06:43Z","updated_at":"2015-06-10T13:06:43Z","body":"Then why is this in one commit, if it fixes three different things? I don't even want to play the stopper of changes, but that is making it hard. \r\n\r\nA) Already fixed via the none option\r\nB) Yeah, would be ok to do, but not with the workaround. That belongs in the upgrader, if it needs to be done at all (what is the fallback of getTemplate-file if it finds nothing? It should be the string entered). \r\nC) Already fixed in master\r\n\r\nEach one should be its own commit, and that way I could've seen the merit of B) easier. Because to give templates the chance to overwrite the default image is a good thing to do."}}