{"action":"created","comment":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/37832605","id":37832605,"diff_hunk":"@@ -35,12 +36,19 @@ public override void Init(Manifest m, Dictionary<string, string> info)\n \t\t\tif (r == null)\n \t\t\t\treturn;\n \n-\t\t\tmessages = info[\"Text\"].Split(',');\n-\t\t\tsheet = new Sheet(Platform.ResolvePath(info[\"Image\"]));\n-\t\t\tlogo = new Sprite(sheet, new Rectangle(0, 0, 256, 256), TextureChannel.Alpha);\n-\t\t\tstripe = new Sprite(sheet, new Rectangle(256, 0, 256, 256), TextureChannel.Alpha);\n-\t\t\tstripeRect = new Rectangle(0, r.Resolution.Height / 2 - 128, r.Resolution.Width, 256);\n-\t\t\tlogoPos = new float2(r.Resolution.Width / 2 - 128, r.Resolution.Height / 2 - 128);\n+\t\t\tif (!info.ContainsKey(\"Text\"))\n+\t\t\t\tmessages = defaultMessage.Split(',');","path":"OpenRA.Mods.Common/LoadScreens/LogoStripeLoadScreen.cs","position":19,"original_position":19,"commit_id":"1ed177b58c1669ddf68f28b5afb8f2cafb6abca8","original_commit_id":"1ed177b58c1669ddf68f28b5afb8f2cafb6abca8","user":{"login":"Mailaender","id":756669,"avatar_url":"https://avatars.githubusercontent.com/u/756669?v=3","gravatar_id":"","url":"https://api.github.com/users/Mailaender","html_url":"https://github.com/Mailaender","followers_url":"https://api.github.com/users/Mailaender/followers","following_url":"https://api.github.com/users/Mailaender/following{/other_user}","gists_url":"https://api.github.com/users/Mailaender/gists{/gist_id}","starred_url":"https://api.github.com/users/Mailaender/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mailaender/subscriptions","organizations_url":"https://api.github.com/users/Mailaender/orgs","repos_url":"https://api.github.com/users/Mailaender/repos","events_url":"https://api.github.com/users/Mailaender/events{/privacy}","received_events_url":"https://api.github.com/users/Mailaender/received_events","type":"User","site_admin":false},"body":"and then do `messages = defaultMessage` which is less of a hack.","created_at":"2015-08-25T04:53:18Z","updated_at":"2015-08-25T04:53:18Z","html_url":"https://github.com/OpenRA/OpenRA/pull/9143#discussion_r37832605","pull_request_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9143","_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/37832605"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/9143#discussion_r37832605"},"pull_request":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9143"}}},"pull_request":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9143","id":43124474,"html_url":"https://github.com/OpenRA/OpenRA/pull/9143","diff_url":"https://github.com/OpenRA/OpenRA/pull/9143.diff","patch_url":"https://github.com/OpenRA/OpenRA/pull/9143.patch","issue_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/9143","number":9143,"state":"open","locked":false,"title":"LoadScreen: Do not crash when Image or Text is not defined.","user":{"login":"LipkeGu","id":2057932,"avatar_url":"https://avatars.githubusercontent.com/u/2057932?v=3","gravatar_id":"","url":"https://api.github.com/users/LipkeGu","html_url":"https://github.com/LipkeGu","followers_url":"https://api.github.com/users/LipkeGu/followers","following_url":"https://api.github.com/users/LipkeGu/following{/other_user}","gists_url":"https://api.github.com/users/LipkeGu/gists{/gist_id}","starred_url":"https://api.github.com/users/LipkeGu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LipkeGu/subscriptions","organizations_url":"https://api.github.com/users/LipkeGu/orgs","repos_url":"https://api.github.com/users/LipkeGu/repos","events_url":"https://api.github.com/users/LipkeGu/events{/privacy}","received_events_url":"https://api.github.com/users/LipkeGu/received_events","type":"User","site_admin":false},"body":"This crash can be reproduced without this PR by commenting out the loading image entry and loading text entry in mod.yaml. In this case the Pr adds a fallback loading message.\r\n\r\nIMO In this unexpected case it is better to display ```Loading...``` instead of crashing the game.","created_at":"2015-08-23T16:56:00Z","updated_at":"2015-08-25T04:53:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ccb68a51f8a4d879a37ad7cfb0265343e058cfa2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9143/commits","review_comments_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9143/comments","review_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/9143/comments","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/1ed177b58c1669ddf68f28b5afb8f2cafb6abca8","head":{"label":"LipkeGu:mod_loadscreen_crash","ref":"mod_loadscreen_crash","sha":"1ed177b58c1669ddf68f28b5afb8f2cafb6abca8","user":{"login":"LipkeGu","id":2057932,"avatar_url":"https://avatars.githubusercontent.com/u/2057932?v=3","gravatar_id":"","url":"https://api.github.com/users/LipkeGu","html_url":"https://github.com/LipkeGu","followers_url":"https://api.github.com/users/LipkeGu/followers","following_url":"https://api.github.com/users/LipkeGu/following{/other_user}","gists_url":"https://api.github.com/users/LipkeGu/gists{/gist_id}","starred_url":"https://api.github.com/users/LipkeGu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LipkeGu/subscriptions","organizations_url":"https://api.github.com/users/LipkeGu/orgs","repos_url":"https://api.github.com/users/LipkeGu/repos","events_url":"https://api.github.com/users/LipkeGu/events{/privacy}","received_events_url":"https://api.github.com/users/LipkeGu/received_events","type":"User","site_admin":false},"repo":{"id":24847217,"name":"OpenRA","full_name":"LipkeGu/OpenRA","owner":{"login":"LipkeGu","id":2057932,"avatar_url":"https://avatars.githubusercontent.com/u/2057932?v=3","gravatar_id":"","url":"https://api.github.com/users/LipkeGu","html_url":"https://github.com/LipkeGu","followers_url":"https://api.github.com/users/LipkeGu/followers","following_url":"https://api.github.com/users/LipkeGu/following{/other_user}","gists_url":"https://api.github.com/users/LipkeGu/gists{/gist_id}","starred_url":"https://api.github.com/users/LipkeGu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LipkeGu/subscriptions","organizations_url":"https://api.github.com/users/LipkeGu/orgs","repos_url":"https://api.github.com/users/LipkeGu/repos","events_url":"https://api.github.com/users/LipkeGu/events{/privacy}","received_events_url":"https://api.github.com/users/LipkeGu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LipkeGu/OpenRA","description":"An open-source implementation of the Command & Conquer: Red Alert engine using .NET/Mono and OpenGL. Runs on Windows, Linux and Mac OS X.","fork":true,"url":"https://api.github.com/repos/LipkeGu/OpenRA","forks_url":"https://api.github.com/repos/LipkeGu/OpenRA/forks","keys_url":"https://api.github.com/repos/LipkeGu/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LipkeGu/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LipkeGu/OpenRA/teams","hooks_url":"https://api.github.com/repos/LipkeGu/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/LipkeGu/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/LipkeGu/OpenRA/events","assignees_url":"https://api.github.com/repos/LipkeGu/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/LipkeGu/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/LipkeGu/OpenRA/tags","blobs_url":"https://api.github.com/repos/LipkeGu/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LipkeGu/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LipkeGu/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/LipkeGu/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LipkeGu/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/LipkeGu/OpenRA/languages","stargazers_url":"https://api.github.com/repos/LipkeGu/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/LipkeGu/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/LipkeGu/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/LipkeGu/OpenRA/subscription","commits_url":"https://api.github.com/repos/LipkeGu/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/LipkeGu/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/LipkeGu/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/LipkeGu/OpenRA/issues/comments{/number}","contents_url":"https://api.github.com/repos/LipkeGu/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/LipkeGu/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LipkeGu/OpenRA/merges","archive_url":"https://api.github.com/repos/LipkeGu/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LipkeGu/OpenRA/downloads","issues_url":"https://api.github.com/repos/LipkeGu/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/LipkeGu/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/LipkeGu/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/LipkeGu/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LipkeGu/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/LipkeGu/OpenRA/releases{/id}","created_at":"2014-10-06T13:36:37Z","updated_at":"2015-02-24T14:27:26Z","pushed_at":"2015-08-24T14:27:21Z","git_url":"git://github.com/LipkeGu/OpenRA.git","ssh_url":"git@github.com:LipkeGu/OpenRA.git","clone_url":"https://github.com/LipkeGu/OpenRA.git","svn_url":"https://github.com/LipkeGu/OpenRA","homepage":"http://www.openra.net","size":91543,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"bleed"}},"base":{"label":"OpenRA:bleed","ref":"bleed","sha":"bec209085b876634ad65d71830bf47faae94e498","user":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars.githubusercontent.com/u/409046?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"repo":{"id":959908,"name":"OpenRA","full_name":"OpenRA/OpenRA","owner":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars.githubusercontent.com/u/409046?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenRA/OpenRA","description":"Open Source real-time strategy game engine for early Westwood games such as Command & Conquer: Red Alert written in C# using SDL and OpenGL. Runs on Windows, Linux, *BSD and Mac OS X.","fork":false,"url":"https://api.github.com/repos/OpenRA/OpenRA","forks_url":"https://api.github.com/repos/OpenRA/OpenRA/forks","keys_url":"https://api.github.com/repos/OpenRA/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenRA/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenRA/OpenRA/teams","hooks_url":"https://api.github.com/repos/OpenRA/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/OpenRA/OpenRA/events","assignees_url":"https://api.github.com/repos/OpenRA/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/OpenRA/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/OpenRA/OpenRA/tags","blobs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenRA/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenRA/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenRA/OpenRA/languages","stargazers_url":"https://api.github.com/repos/OpenRA/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/OpenRA/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/OpenRA/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/OpenRA/OpenRA/subscription","commits_url":"https://api.github.com/repos/OpenRA/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenRA/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenRA/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/OpenRA/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenRA/OpenRA/merges","archive_url":"https://api.github.com/repos/OpenRA/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenRA/OpenRA/downloads","issues_url":"https://api.github.com/repos/OpenRA/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenRA/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenRA/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenRA/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/OpenRA/OpenRA/releases{/id}","created_at":"2010-10-04T07:38:05Z","updated_at":"2015-08-24T16:09:31Z","pushed_at":"2015-08-25T03:24:09Z","git_url":"git://github.com/OpenRA/OpenRA.git","ssh_url":"git@github.com:OpenRA/OpenRA.git","clone_url":"https://github.com/OpenRA/OpenRA.git","svn_url":"https://github.com/OpenRA/OpenRA","homepage":"http://www.openra.net","size":186225,"stargazers_count":2100,"watchers_count":2100,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":755,"mirror_url":null,"open_issues_count":853,"forks":755,"open_issues":853,"watchers":2100,"default_branch":"bleed"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9143"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/9143"},"issue":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/9143"},"comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/9143/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9143/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9143/commits"},"statuses":{"href":"https://api.github.com/repos/OpenRA/OpenRA/statuses/1ed177b58c1669ddf68f28b5afb8f2cafb6abca8"}}}}