{"action":"closed","number":253,"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/253","id":26096261,"html_url":"https://github.com/dotnet/corefx/pull/253","diff_url":"https://github.com/dotnet/corefx/pull/253.diff","patch_url":"https://github.com/dotnet/corefx/pull/253.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/253","number":253,"state":"closed","locked":false,"title":"Fix GetGroup never returning EmptyGroup","user":{"login":"alfaproject","id":60164,"avatar_url":"https://avatars.githubusercontent.com/u/60164?v=3","gravatar_id":"","url":"https://api.github.com/users/alfaproject","html_url":"https://github.com/alfaproject","followers_url":"https://api.github.com/users/alfaproject/followers","following_url":"https://api.github.com/users/alfaproject/following{/other_user}","gists_url":"https://api.github.com/users/alfaproject/gists{/gist_id}","starred_url":"https://api.github.com/users/alfaproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfaproject/subscriptions","organizations_url":"https://api.github.com/users/alfaproject/orgs","repos_url":"https://api.github.com/users/alfaproject/repos","events_url":"https://api.github.com/users/alfaproject/events{/privacy}","received_events_url":"https://api.github.com/users/alfaproject/received_events","type":"User","site_admin":false},"body":"This is a very obvious bug:\r\n_captureMap probably used to be a hashtable and the code was not properly refactored.\r\n\r\nI took the opportunity to redo the method using the Dictionary equivalent logic.\r\n\r\nNot adding unit tests for this, because the unit test project seems to be missing, and I'm not sure if you guys are going to add it or not, so let me know how to proceed.","created_at":"2014-12-15T19:54:41Z","updated_at":"2015-02-19T07:05:03Z","closed_at":"2015-02-19T07:05:03Z","merged_at":null,"merge_commit_sha":"031e2cab3df662da390841e7df727655aa7296b3","assignee":{"login":"Priya91","id":7853870,"avatar_url":"https://avatars.githubusercontent.com/u/7853870?v=3","gravatar_id":"","url":"https://api.github.com/users/Priya91","html_url":"https://github.com/Priya91","followers_url":"https://api.github.com/users/Priya91/followers","following_url":"https://api.github.com/users/Priya91/following{/other_user}","gists_url":"https://api.github.com/users/Priya91/gists{/gist_id}","starred_url":"https://api.github.com/users/Priya91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Priya91/subscriptions","organizations_url":"https://api.github.com/users/Priya91/orgs","repos_url":"https://api.github.com/users/Priya91/repos","events_url":"https://api.github.com/users/Priya91/events{/privacy}","received_events_url":"https://api.github.com/users/Priya91/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/253/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/253/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/253/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/bbeadf12c0605531f6c7cdf2b49975d783732653","head":{"label":"alfaproject:regex_getgroup","ref":"regex_getgroup","sha":"bbeadf12c0605531f6c7cdf2b49975d783732653","user":{"login":"alfaproject","id":60164,"avatar_url":"https://avatars.githubusercontent.com/u/60164?v=3","gravatar_id":"","url":"https://api.github.com/users/alfaproject","html_url":"https://github.com/alfaproject","followers_url":"https://api.github.com/users/alfaproject/followers","following_url":"https://api.github.com/users/alfaproject/following{/other_user}","gists_url":"https://api.github.com/users/alfaproject/gists{/gist_id}","starred_url":"https://api.github.com/users/alfaproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfaproject/subscriptions","organizations_url":"https://api.github.com/users/alfaproject/orgs","repos_url":"https://api.github.com/users/alfaproject/repos","events_url":"https://api.github.com/users/alfaproject/events{/privacy}","received_events_url":"https://api.github.com/users/alfaproject/received_events","type":"User","site_admin":false},"repo":{"id":27431630,"name":"dotnet-corefx","full_name":"alfaproject/dotnet-corefx","owner":{"login":"alfaproject","id":60164,"avatar_url":"https://avatars.githubusercontent.com/u/60164?v=3","gravatar_id":"","url":"https://api.github.com/users/alfaproject","html_url":"https://github.com/alfaproject","followers_url":"https://api.github.com/users/alfaproject/followers","following_url":"https://api.github.com/users/alfaproject/following{/other_user}","gists_url":"https://api.github.com/users/alfaproject/gists{/gist_id}","starred_url":"https://api.github.com/users/alfaproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfaproject/subscriptions","organizations_url":"https://api.github.com/users/alfaproject/orgs","repos_url":"https://api.github.com/users/alfaproject/repos","events_url":"https://api.github.com/users/alfaproject/events{/privacy}","received_events_url":"https://api.github.com/users/alfaproject/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alfaproject/dotnet-corefx","description":"This repository contains the foundational libraries that make up the .NET Core development stack.","fork":true,"url":"https://api.github.com/repos/alfaproject/dotnet-corefx","forks_url":"https://api.github.com/repos/alfaproject/dotnet-corefx/forks","keys_url":"https://api.github.com/repos/alfaproject/dotnet-corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alfaproject/dotnet-corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alfaproject/dotnet-corefx/teams","hooks_url":"https://api.github.com/repos/alfaproject/dotnet-corefx/hooks","issue_events_url":"https://api.github.com/repos/alfaproject/dotnet-corefx/issues/events{/number}","events_url":"https://api.github.com/repos/alfaproject/dotnet-corefx/events","assignees_url":"https://api.github.com/repos/alfaproject/dotnet-corefx/assignees{/user}","branches_url":"https://api.github.com/repos/alfaproject/dotnet-corefx/branches{/branch}","tags_url":"https://api.github.com/repos/alfaproject/dotnet-corefx/tags","blobs_url":"https://api.github.com/repos/alfaproject/dotnet-corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alfaproject/dotnet-corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alfaproject/dotnet-corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/alfaproject/dotnet-corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alfaproject/dotnet-corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/alfaproject/dotnet-corefx/languages","stargazers_url":"https://api.github.com/repos/alfaproject/dotnet-corefx/stargazers","contributors_url":"https://api.github.com/repos/alfaproject/dotnet-corefx/contributors","subscribers_url":"https://api.github.com/repos/alfaproject/dotnet-corefx/subscribers","subscription_url":"https://api.github.com/repos/alfaproject/dotnet-corefx/subscription","commits_url":"https://api.github.com/repos/alfaproject/dotnet-corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/alfaproject/dotnet-corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/alfaproject/dotnet-corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/alfaproject/dotnet-corefx/issues/comments/{number}","contents_url":"https://api.github.com/repos/alfaproject/dotnet-corefx/contents/{+path}","compare_url":"https://api.github.com/repos/alfaproject/dotnet-corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alfaproject/dotnet-corefx/merges","archive_url":"https://api.github.com/repos/alfaproject/dotnet-corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alfaproject/dotnet-corefx/downloads","issues_url":"https://api.github.com/repos/alfaproject/dotnet-corefx/issues{/number}","pulls_url":"https://api.github.com/repos/alfaproject/dotnet-corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/alfaproject/dotnet-corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/alfaproject/dotnet-corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alfaproject/dotnet-corefx/labels{/name}","releases_url":"https://api.github.com/repos/alfaproject/dotnet-corefx/releases{/id}","created_at":"2014-12-02T12:31:08Z","updated_at":"2015-01-22T21:25:00Z","pushed_at":"2015-01-22T21:27:09Z","git_url":"git://github.com/alfaproject/dotnet-corefx.git","ssh_url":"git@github.com:alfaproject/dotnet-corefx.git","clone_url":"https://github.com/alfaproject/dotnet-corefx.git","svn_url":"https://github.com/alfaproject/dotnet-corefx","homepage":"","size":6549,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"44af35e5e5352129efbb57fbcaf988411e5efe88","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the foundational libraries that make up the .NET Core development stack.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments/{number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","created_at":"2014-11-06T23:42:48Z","updated_at":"2015-02-19T07:01:08Z","pushed_at":"2015-02-19T07:01:08Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"","size":22149,"stargazers_count":6994,"watchers_count":6994,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1271,"mirror_url":null,"open_issues_count":235,"forks":1271,"open_issues":235,"watchers":6994,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/253"},"html":{"href":"https://github.com/dotnet/corefx/pull/253"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/253"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/253/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/253/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/253/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/bbeadf12c0605531f6c7cdf2b49975d783732653"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":28,"review_comments":6,"commits":2,"additions":29,"deletions":14,"changed_files":4}}