{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/1473","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/1473/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/1473/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/1473/events","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/issues/1473","id":44115504,"number":1473,"title":"Test all api versions","user":{"login":"lavalamp","id":647318,"avatar_url":"https://avatars.githubusercontent.com/u/647318?v=3","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels/area/hosting","name":"area/hosting","color":"0052cc"},{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels/area/reliability","name":"area/reliability","color":"a10d01"},{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels/area/test","name":"area/test","color":"fad8c7"},{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels/priority/P2","name":"priority/P2","color":"fbca04"},{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels/team/master","name":"team/master","color":"d2b48c"},{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels/team/testing","name":"team/testing","color":"d2b48c"}],"state":"closed","locked":false,"assignee":{"login":"nikhiljindal","id":10199099,"avatar_url":"https://avatars.githubusercontent.com/u/10199099?v=3","gravatar_id":"","url":"https://api.github.com/users/nikhiljindal","html_url":"https://github.com/nikhiljindal","followers_url":"https://api.github.com/users/nikhiljindal/followers","following_url":"https://api.github.com/users/nikhiljindal/following{/other_user}","gists_url":"https://api.github.com/users/nikhiljindal/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhiljindal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhiljindal/subscriptions","organizations_url":"https://api.github.com/users/nikhiljindal/orgs","repos_url":"https://api.github.com/users/nikhiljindal/repos","events_url":"https://api.github.com/users/nikhiljindal/events{/privacy}","received_events_url":"https://api.github.com/users/nikhiljindal/received_events","type":"User","site_admin":false},"milestone":null,"comments":9,"created_at":"2014-09-26T23:27:22Z","updated_at":"2015-03-25T21:13:04Z","closed_at":"2015-03-25T21:13:04Z","body":"We need to make our tests parameterized for api version, e.g., via a command-line flag. Then we need to make hack/test-go.sh run our tests once for each version we support.\r\n\r\nAd-hoc testing of different versions is going to be error prone and repeat a bunch of logic unnecessarily.\r\n\r\nConcrete steps:\r\n\r\na. Make an api/test library\r\nb. It defines a command-line flag\r\nc. It defines a Codec, etc (like the api/latest package) which is set based off of the command line flag\r\nd. Tests everywhere are changed to import this library and use its Codec.\r\ne. The testing script runs tests once for each version."},"comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments/86220084","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/issues/1473#issuecomment-86220084","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/1473","id":86220084,"user":{"login":"nikhiljindal","id":10199099,"avatar_url":"https://avatars.githubusercontent.com/u/10199099?v=3","gravatar_id":"","url":"https://api.github.com/users/nikhiljindal","html_url":"https://github.com/nikhiljindal","followers_url":"https://api.github.com/users/nikhiljindal/followers","following_url":"https://api.github.com/users/nikhiljindal/following{/other_user}","gists_url":"https://api.github.com/users/nikhiljindal/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhiljindal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhiljindal/subscriptions","organizations_url":"https://api.github.com/users/nikhiljindal/orgs","repos_url":"https://api.github.com/users/nikhiljindal/repos","events_url":"https://api.github.com/users/nikhiljindal/events{/privacy}","received_events_url":"https://api.github.com/users/nikhiljindal/received_events","type":"User","site_admin":false},"created_at":"2015-03-25T21:13:04Z","updated_at":"2015-03-25T21:13:04Z","body":"Fixed by https://github.com/GoogleCloudPlatform/kubernetes/pull/5687.\r\nWe will now test both the versions in test-go and test-integration when run locally.\r\nOn travis, we will test \"v1beta1\" with go 1.4 and \"v1beta3\" with go 1.3.\r\nYou can change the versions being tested using KUBE_TEST_API_VERSIONS env variable."}}