{"action":"closed","number":3,"pull_request":{"url":"https://api.github.com/repos/gfeiden/starspot/pulls/3","id":37348987,"html_url":"https://github.com/gfeiden/starspot/pull/3","diff_url":"https://github.com/gfeiden/starspot/pull/3.diff","patch_url":"https://github.com/gfeiden/starspot/pull/3.patch","issue_url":"https://api.github.com/repos/gfeiden/starspot/issues/3","number":3,"state":"closed","locked":false,"title":"Optimization and calculations of magnitudes for spotted isochrones.","user":{"login":"schristophe","id":12143303,"avatar_url":"https://avatars.githubusercontent.com/u/12143303?v=3","gravatar_id":"","url":"https://api.github.com/users/schristophe","html_url":"https://github.com/schristophe","followers_url":"https://api.github.com/users/schristophe/followers","following_url":"https://api.github.com/users/schristophe/following{/other_user}","gists_url":"https://api.github.com/users/schristophe/gists{/gist_id}","starred_url":"https://api.github.com/users/schristophe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schristophe/subscriptions","organizations_url":"https://api.github.com/users/schristophe/orgs","repos_url":"https://api.github.com/users/schristophe/repos","events_url":"https://api.github.com/users/schristophe/events{/privacy}","received_events_url":"https://api.github.com/users/schristophe/received_events","type":"User","site_admin":false},"body":"I optimized the code and fixed calculations of magnitudes for spotted stars by adding a new function which add fluxes and return the corresponding magnitude.\r\nI also tried to make the code clearer by adding white spaces and comments or writing constants in capital letters.\r\nFinally, the code is now treating the case of completely dark spots correctly (pi=0). It still raises a invalid flag (because of log10(0)) for rho=1, i.e. when stars are entirely covered by spots.","created_at":"2015-06-10T11:33:30Z","updated_at":"2015-06-10T11:56:35Z","closed_at":"2015-06-10T11:56:35Z","merged_at":"2015-06-10T11:56:35Z","merge_commit_sha":"11753a4551dd8a1d7cacfa688ae2a7a4201e79a1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gfeiden/starspot/pulls/3/commits","review_comments_url":"https://api.github.com/repos/gfeiden/starspot/pulls/3/comments","review_comment_url":"https://api.github.com/repos/gfeiden/starspot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gfeiden/starspot/issues/3/comments","statuses_url":"https://api.github.com/repos/gfeiden/starspot/statuses/c68278cd10d1fcf8c8286e6be0d25c58beac82a6","head":{"label":"schristophe:master","ref":"master","sha":"c68278cd10d1fcf8c8286e6be0d25c58beac82a6","user":{"login":"schristophe","id":12143303,"avatar_url":"https://avatars.githubusercontent.com/u/12143303?v=3","gravatar_id":"","url":"https://api.github.com/users/schristophe","html_url":"https://github.com/schristophe","followers_url":"https://api.github.com/users/schristophe/followers","following_url":"https://api.github.com/users/schristophe/following{/other_user}","gists_url":"https://api.github.com/users/schristophe/gists{/gist_id}","starred_url":"https://api.github.com/users/schristophe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schristophe/subscriptions","organizations_url":"https://api.github.com/users/schristophe/orgs","repos_url":"https://api.github.com/users/schristophe/repos","events_url":"https://api.github.com/users/schristophe/events{/privacy}","received_events_url":"https://api.github.com/users/schristophe/received_events","type":"User","site_admin":false},"repo":{"id":35097022,"name":"starspot","full_name":"schristophe/starspot","owner":{"login":"schristophe","id":12143303,"avatar_url":"https://avatars.githubusercontent.com/u/12143303?v=3","gravatar_id":"","url":"https://api.github.com/users/schristophe","html_url":"https://github.com/schristophe","followers_url":"https://api.github.com/users/schristophe/followers","following_url":"https://api.github.com/users/schristophe/following{/other_user}","gists_url":"https://api.github.com/users/schristophe/gists{/gist_id}","starred_url":"https://api.github.com/users/schristophe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schristophe/subscriptions","organizations_url":"https://api.github.com/users/schristophe/orgs","repos_url":"https://api.github.com/users/schristophe/repos","events_url":"https://api.github.com/users/schristophe/events{/privacy}","received_events_url":"https://api.github.com/users/schristophe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/schristophe/starspot","description":"Scripts and data associated with starspot investigations","fork":true,"url":"https://api.github.com/repos/schristophe/starspot","forks_url":"https://api.github.com/repos/schristophe/starspot/forks","keys_url":"https://api.github.com/repos/schristophe/starspot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/schristophe/starspot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/schristophe/starspot/teams","hooks_url":"https://api.github.com/repos/schristophe/starspot/hooks","issue_events_url":"https://api.github.com/repos/schristophe/starspot/issues/events{/number}","events_url":"https://api.github.com/repos/schristophe/starspot/events","assignees_url":"https://api.github.com/repos/schristophe/starspot/assignees{/user}","branches_url":"https://api.github.com/repos/schristophe/starspot/branches{/branch}","tags_url":"https://api.github.com/repos/schristophe/starspot/tags","blobs_url":"https://api.github.com/repos/schristophe/starspot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/schristophe/starspot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/schristophe/starspot/git/refs{/sha}","trees_url":"https://api.github.com/repos/schristophe/starspot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/schristophe/starspot/statuses/{sha}","languages_url":"https://api.github.com/repos/schristophe/starspot/languages","stargazers_url":"https://api.github.com/repos/schristophe/starspot/stargazers","contributors_url":"https://api.github.com/repos/schristophe/starspot/contributors","subscribers_url":"https://api.github.com/repos/schristophe/starspot/subscribers","subscription_url":"https://api.github.com/repos/schristophe/starspot/subscription","commits_url":"https://api.github.com/repos/schristophe/starspot/commits{/sha}","git_commits_url":"https://api.github.com/repos/schristophe/starspot/git/commits{/sha}","comments_url":"https://api.github.com/repos/schristophe/starspot/comments{/number}","issue_comment_url":"https://api.github.com/repos/schristophe/starspot/issues/comments{/number}","contents_url":"https://api.github.com/repos/schristophe/starspot/contents/{+path}","compare_url":"https://api.github.com/repos/schristophe/starspot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/schristophe/starspot/merges","archive_url":"https://api.github.com/repos/schristophe/starspot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/schristophe/starspot/downloads","issues_url":"https://api.github.com/repos/schristophe/starspot/issues{/number}","pulls_url":"https://api.github.com/repos/schristophe/starspot/pulls{/number}","milestones_url":"https://api.github.com/repos/schristophe/starspot/milestones{/number}","notifications_url":"https://api.github.com/repos/schristophe/starspot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/schristophe/starspot/labels{/name}","releases_url":"https://api.github.com/repos/schristophe/starspot/releases{/id}","created_at":"2015-05-05T12:10:08Z","updated_at":"2015-05-26T09:08:20Z","pushed_at":"2015-06-10T10:44:25Z","git_url":"git://github.com/schristophe/starspot.git","ssh_url":"git@github.com:schristophe/starspot.git","clone_url":"https://github.com/schristophe/starspot.git","svn_url":"https://github.com/schristophe/starspot","homepage":null,"size":4461,"stargazers_count":0,"watchers_count":0,"language":"FORTRAN","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gfeiden:master","ref":"master","sha":"88891687e5c845e725771e0142d1f4a32c5e1f6b","user":{"login":"gfeiden","id":3239184,"avatar_url":"https://avatars.githubusercontent.com/u/3239184?v=3","gravatar_id":"","url":"https://api.github.com/users/gfeiden","html_url":"https://github.com/gfeiden","followers_url":"https://api.github.com/users/gfeiden/followers","following_url":"https://api.github.com/users/gfeiden/following{/other_user}","gists_url":"https://api.github.com/users/gfeiden/gists{/gist_id}","starred_url":"https://api.github.com/users/gfeiden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfeiden/subscriptions","organizations_url":"https://api.github.com/users/gfeiden/orgs","repos_url":"https://api.github.com/users/gfeiden/repos","events_url":"https://api.github.com/users/gfeiden/events{/privacy}","received_events_url":"https://api.github.com/users/gfeiden/received_events","type":"User","site_admin":false},"repo":{"id":33859616,"name":"starspot","full_name":"gfeiden/starspot","owner":{"login":"gfeiden","id":3239184,"avatar_url":"https://avatars.githubusercontent.com/u/3239184?v=3","gravatar_id":"","url":"https://api.github.com/users/gfeiden","html_url":"https://github.com/gfeiden","followers_url":"https://api.github.com/users/gfeiden/followers","following_url":"https://api.github.com/users/gfeiden/following{/other_user}","gists_url":"https://api.github.com/users/gfeiden/gists{/gist_id}","starred_url":"https://api.github.com/users/gfeiden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfeiden/subscriptions","organizations_url":"https://api.github.com/users/gfeiden/orgs","repos_url":"https://api.github.com/users/gfeiden/repos","events_url":"https://api.github.com/users/gfeiden/events{/privacy}","received_events_url":"https://api.github.com/users/gfeiden/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gfeiden/starspot","description":"Scripts and data associated with starspot investigations","fork":false,"url":"https://api.github.com/repos/gfeiden/starspot","forks_url":"https://api.github.com/repos/gfeiden/starspot/forks","keys_url":"https://api.github.com/repos/gfeiden/starspot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gfeiden/starspot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gfeiden/starspot/teams","hooks_url":"https://api.github.com/repos/gfeiden/starspot/hooks","issue_events_url":"https://api.github.com/repos/gfeiden/starspot/issues/events{/number}","events_url":"https://api.github.com/repos/gfeiden/starspot/events","assignees_url":"https://api.github.com/repos/gfeiden/starspot/assignees{/user}","branches_url":"https://api.github.com/repos/gfeiden/starspot/branches{/branch}","tags_url":"https://api.github.com/repos/gfeiden/starspot/tags","blobs_url":"https://api.github.com/repos/gfeiden/starspot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gfeiden/starspot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gfeiden/starspot/git/refs{/sha}","trees_url":"https://api.github.com/repos/gfeiden/starspot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gfeiden/starspot/statuses/{sha}","languages_url":"https://api.github.com/repos/gfeiden/starspot/languages","stargazers_url":"https://api.github.com/repos/gfeiden/starspot/stargazers","contributors_url":"https://api.github.com/repos/gfeiden/starspot/contributors","subscribers_url":"https://api.github.com/repos/gfeiden/starspot/subscribers","subscription_url":"https://api.github.com/repos/gfeiden/starspot/subscription","commits_url":"https://api.github.com/repos/gfeiden/starspot/commits{/sha}","git_commits_url":"https://api.github.com/repos/gfeiden/starspot/git/commits{/sha}","comments_url":"https://api.github.com/repos/gfeiden/starspot/comments{/number}","issue_comment_url":"https://api.github.com/repos/gfeiden/starspot/issues/comments{/number}","contents_url":"https://api.github.com/repos/gfeiden/starspot/contents/{+path}","compare_url":"https://api.github.com/repos/gfeiden/starspot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gfeiden/starspot/merges","archive_url":"https://api.github.com/repos/gfeiden/starspot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gfeiden/starspot/downloads","issues_url":"https://api.github.com/repos/gfeiden/starspot/issues{/number}","pulls_url":"https://api.github.com/repos/gfeiden/starspot/pulls{/number}","milestones_url":"https://api.github.com/repos/gfeiden/starspot/milestones{/number}","notifications_url":"https://api.github.com/repos/gfeiden/starspot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gfeiden/starspot/labels{/name}","releases_url":"https://api.github.com/repos/gfeiden/starspot/releases{/id}","created_at":"2015-04-13T09:27:31Z","updated_at":"2015-05-21T16:22:28Z","pushed_at":"2015-06-10T11:56:36Z","git_url":"git://github.com/gfeiden/starspot.git","ssh_url":"git@github.com:gfeiden/starspot.git","clone_url":"https://github.com/gfeiden/starspot.git","svn_url":"https://github.com/gfeiden/starspot","homepage":null,"size":4581,"stargazers_count":0,"watchers_count":0,"language":"FORTRAN","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gfeiden/starspot/pulls/3"},"html":{"href":"https://github.com/gfeiden/starspot/pull/3"},"issue":{"href":"https://api.github.com/repos/gfeiden/starspot/issues/3"},"comments":{"href":"https://api.github.com/repos/gfeiden/starspot/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/gfeiden/starspot/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/gfeiden/starspot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gfeiden/starspot/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/gfeiden/starspot/statuses/c68278cd10d1fcf8c8286e6be0d25c58beac82a6"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"gfeiden","id":3239184,"avatar_url":"https://avatars.githubusercontent.com/u/3239184?v=3","gravatar_id":"","url":"https://api.github.com/users/gfeiden","html_url":"https://github.com/gfeiden","followers_url":"https://api.github.com/users/gfeiden/followers","following_url":"https://api.github.com/users/gfeiden/following{/other_user}","gists_url":"https://api.github.com/users/gfeiden/gists{/gist_id}","starred_url":"https://api.github.com/users/gfeiden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfeiden/subscriptions","organizations_url":"https://api.github.com/users/gfeiden/orgs","repos_url":"https://api.github.com/users/gfeiden/repos","events_url":"https://api.github.com/users/gfeiden/events{/privacy}","received_events_url":"https://api.github.com/users/gfeiden/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":9,"additions":160,"deletions":139,"changed_files":2}}