{"action":"created","comment":{"url":"https://api.github.com/repos/atom/electron/pulls/comments/29489653","id":29489653,"diff_hunk":"@@ -548,6 +559,58 @@ void WebContents::SetAllowTransparency(bool allow) {\n   }\n }\n \n+content::ServiceWorkerContext* WebContents::GetServiceWorkerContext() {\n+  auto context = web_contents()->GetBrowserContext();\n+  auto site_instance = web_contents()->GetSiteInstance();\n+  if (!context && !site_instance)\n+    return nullptr;\n+\n+  content::StoragePartition* storage_partition =\n+    content::BrowserContext::GetStoragePartition(\n+      context, site_instance);\n+\n+  DCHECK(storage_partition);\n+\n+  return storage_partition->GetServiceWorkerContext();\n+}\n+\n+void WebContents::HasServiceWorker(mate::Arguments* args) {\n+  GURL url;\n+  base::Callback<void(bool)> callback;\n+\n+  if (!(args->Length() == 2 && args->GetNext(&url)","path":"atom/browser/api/atom_api_web_contents.cc","position":50,"original_position":50,"commit_id":"c03beb5de18f26f88bc49c7c9f9d4c0c4714e060","original_commit_id":"c03beb5de18f26f88bc49c7c9f9d4c0c4714e060","user":{"login":"zcbenz","id":639601,"avatar_url":"https://avatars.githubusercontent.com/u/639601?v=3","gravatar_id":"","url":"https://api.github.com/users/zcbenz","html_url":"https://github.com/zcbenz","followers_url":"https://api.github.com/users/zcbenz/followers","following_url":"https://api.github.com/users/zcbenz/following{/other_user}","gists_url":"https://api.github.com/users/zcbenz/gists{/gist_id}","starred_url":"https://api.github.com/users/zcbenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcbenz/subscriptions","organizations_url":"https://api.github.com/users/zcbenz/orgs","repos_url":"https://api.github.com/users/zcbenz/repos","events_url":"https://api.github.com/users/zcbenz/events{/privacy}","received_events_url":"https://api.github.com/users/zcbenz/received_events","type":"User","site_admin":true},"body":"You don't need to parse arguments manually, put them in the definition of `WebContents::HasServiceWorker` and conversion will be handled automatically.","created_at":"2015-05-01T04:54:29Z","updated_at":"2015-05-01T04:54:29Z","html_url":"https://github.com/atom/electron/pull/1535#discussion_r29489653","pull_request_url":"https://api.github.com/repos/atom/electron/pulls/1535","_links":{"self":{"href":"https://api.github.com/repos/atom/electron/pulls/comments/29489653"},"html":{"href":"https://github.com/atom/electron/pull/1535#discussion_r29489653"},"pull_request":{"href":"https://api.github.com/repos/atom/electron/pulls/1535"}}},"pull_request":{"url":"https://api.github.com/repos/atom/electron/pulls/1535","id":34458474,"html_url":"https://github.com/atom/electron/pull/1535","diff_url":"https://github.com/atom/electron/pull/1535.diff","patch_url":"https://github.com/atom/electron/pull/1535.patch","issue_url":"https://api.github.com/repos/atom/electron/issues/1535","number":1535,"state":"open","locked":false,"title":"webContents: adding serviceworker helper utilities","user":{"login":"deepak1556","id":964386,"avatar_url":"https://avatars.githubusercontent.com/u/964386?v=3","gravatar_id":"","url":"https://api.github.com/users/deepak1556","html_url":"https://github.com/deepak1556","followers_url":"https://api.github.com/users/deepak1556/followers","following_url":"https://api.github.com/users/deepak1556/following{/other_user}","gists_url":"https://api.github.com/users/deepak1556/gists{/gist_id}","starred_url":"https://api.github.com/users/deepak1556/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepak1556/subscriptions","organizations_url":"https://api.github.com/users/deepak1556/orgs","repos_url":"https://api.github.com/users/deepak1556/repos","events_url":"https://api.github.com/users/deepak1556/events{/privacy}","received_events_url":"https://api.github.com/users/deepak1556/received_events","type":"User","site_admin":false},"body":"Related #1331 \r\n\r\n- [x] Add unregister helper\r\n- [ ] Add tests","created_at":"2015-04-30T13:19:33Z","updated_at":"2015-05-01T04:54:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e0092748af941b96ba11a5a22de8d86e5edeb636","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/atom/electron/pulls/1535/commits","review_comments_url":"https://api.github.com/repos/atom/electron/pulls/1535/comments","review_comment_url":"https://api.github.com/repos/atom/electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atom/electron/issues/1535/comments","statuses_url":"https://api.github.com/repos/atom/electron/statuses/c03beb5de18f26f88bc49c7c9f9d4c0c4714e060","head":{"label":"deepak1556:contents_patch","ref":"contents_patch","sha":"c03beb5de18f26f88bc49c7c9f9d4c0c4714e060","user":{"login":"deepak1556","id":964386,"avatar_url":"https://avatars.githubusercontent.com/u/964386?v=3","gravatar_id":"","url":"https://api.github.com/users/deepak1556","html_url":"https://github.com/deepak1556","followers_url":"https://api.github.com/users/deepak1556/followers","following_url":"https://api.github.com/users/deepak1556/following{/other_user}","gists_url":"https://api.github.com/users/deepak1556/gists{/gist_id}","starred_url":"https://api.github.com/users/deepak1556/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepak1556/subscriptions","organizations_url":"https://api.github.com/users/deepak1556/orgs","repos_url":"https://api.github.com/users/deepak1556/repos","events_url":"https://api.github.com/users/deepak1556/events{/privacy}","received_events_url":"https://api.github.com/users/deepak1556/received_events","type":"User","site_admin":false},"repo":{"id":19500833,"name":"atom-shell","full_name":"deepak1556/atom-shell","owner":{"login":"deepak1556","id":964386,"avatar_url":"https://avatars.githubusercontent.com/u/964386?v=3","gravatar_id":"","url":"https://api.github.com/users/deepak1556","html_url":"https://github.com/deepak1556","followers_url":"https://api.github.com/users/deepak1556/followers","following_url":"https://api.github.com/users/deepak1556/following{/other_user}","gists_url":"https://api.github.com/users/deepak1556/gists{/gist_id}","starred_url":"https://api.github.com/users/deepak1556/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepak1556/subscriptions","organizations_url":"https://api.github.com/users/deepak1556/orgs","repos_url":"https://api.github.com/users/deepak1556/repos","events_url":"https://api.github.com/users/deepak1556/events{/privacy}","received_events_url":"https://api.github.com/users/deepak1556/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/deepak1556/atom-shell","description":"Cross-platform desktop application shell","fork":true,"url":"https://api.github.com/repos/deepak1556/atom-shell","forks_url":"https://api.github.com/repos/deepak1556/atom-shell/forks","keys_url":"https://api.github.com/repos/deepak1556/atom-shell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deepak1556/atom-shell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deepak1556/atom-shell/teams","hooks_url":"https://api.github.com/repos/deepak1556/atom-shell/hooks","issue_events_url":"https://api.github.com/repos/deepak1556/atom-shell/issues/events{/number}","events_url":"https://api.github.com/repos/deepak1556/atom-shell/events","assignees_url":"https://api.github.com/repos/deepak1556/atom-shell/assignees{/user}","branches_url":"https://api.github.com/repos/deepak1556/atom-shell/branches{/branch}","tags_url":"https://api.github.com/repos/deepak1556/atom-shell/tags","blobs_url":"https://api.github.com/repos/deepak1556/atom-shell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deepak1556/atom-shell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deepak1556/atom-shell/git/refs{/sha}","trees_url":"https://api.github.com/repos/deepak1556/atom-shell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deepak1556/atom-shell/statuses/{sha}","languages_url":"https://api.github.com/repos/deepak1556/atom-shell/languages","stargazers_url":"https://api.github.com/repos/deepak1556/atom-shell/stargazers","contributors_url":"https://api.github.com/repos/deepak1556/atom-shell/contributors","subscribers_url":"https://api.github.com/repos/deepak1556/atom-shell/subscribers","subscription_url":"https://api.github.com/repos/deepak1556/atom-shell/subscription","commits_url":"https://api.github.com/repos/deepak1556/atom-shell/commits{/sha}","git_commits_url":"https://api.github.com/repos/deepak1556/atom-shell/git/commits{/sha}","comments_url":"https://api.github.com/repos/deepak1556/atom-shell/comments{/number}","issue_comment_url":"https://api.github.com/repos/deepak1556/atom-shell/issues/comments{/number}","contents_url":"https://api.github.com/repos/deepak1556/atom-shell/contents/{+path}","compare_url":"https://api.github.com/repos/deepak1556/atom-shell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deepak1556/atom-shell/merges","archive_url":"https://api.github.com/repos/deepak1556/atom-shell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deepak1556/atom-shell/downloads","issues_url":"https://api.github.com/repos/deepak1556/atom-shell/issues{/number}","pulls_url":"https://api.github.com/repos/deepak1556/atom-shell/pulls{/number}","milestones_url":"https://api.github.com/repos/deepak1556/atom-shell/milestones{/number}","notifications_url":"https://api.github.com/repos/deepak1556/atom-shell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deepak1556/atom-shell/labels{/name}","releases_url":"https://api.github.com/repos/deepak1556/atom-shell/releases{/id}","created_at":"2014-05-06T15:58:25Z","updated_at":"2015-03-10T06:12:17Z","pushed_at":"2015-04-30T16:24:53Z","git_url":"git://github.com/deepak1556/atom-shell.git","ssh_url":"git@github.com:deepak1556/atom-shell.git","clone_url":"https://github.com/deepak1556/atom-shell.git","svn_url":"https://github.com/deepak1556/atom-shell","homepage":"","size":8269,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"atom:master","ref":"master","sha":"c54eca8dff3fb7a3be4b440434119efda7d40efb","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"name":"electron","full_name":"atom/electron","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/electron","description":"Build cross platform desktop apps with web technologies","fork":false,"url":"https://api.github.com/repos/atom/electron","forks_url":"https://api.github.com/repos/atom/electron/forks","keys_url":"https://api.github.com/repos/atom/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/electron/teams","hooks_url":"https://api.github.com/repos/atom/electron/hooks","issue_events_url":"https://api.github.com/repos/atom/electron/issues/events{/number}","events_url":"https://api.github.com/repos/atom/electron/events","assignees_url":"https://api.github.com/repos/atom/electron/assignees{/user}","branches_url":"https://api.github.com/repos/atom/electron/branches{/branch}","tags_url":"https://api.github.com/repos/atom/electron/tags","blobs_url":"https://api.github.com/repos/atom/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/electron/languages","stargazers_url":"https://api.github.com/repos/atom/electron/stargazers","contributors_url":"https://api.github.com/repos/atom/electron/contributors","subscribers_url":"https://api.github.com/repos/atom/electron/subscribers","subscription_url":"https://api.github.com/repos/atom/electron/subscription","commits_url":"https://api.github.com/repos/atom/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/electron/contents/{+path}","compare_url":"https://api.github.com/repos/atom/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/electron/merges","archive_url":"https://api.github.com/repos/atom/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/electron/downloads","issues_url":"https://api.github.com/repos/atom/electron/issues{/number}","pulls_url":"https://api.github.com/repos/atom/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/electron/labels{/name}","releases_url":"https://api.github.com/repos/atom/electron/releases{/id}","created_at":"2013-04-12T01:47:36Z","updated_at":"2015-05-01T04:48:56Z","pushed_at":"2015-05-01T04:48:55Z","git_url":"git://github.com/atom/electron.git","ssh_url":"git@github.com:atom/electron.git","clone_url":"https://github.com/atom/electron.git","svn_url":"https://github.com/atom/electron","homepage":"http://electron.atom.io","size":20917,"stargazers_count":9330,"watchers_count":9330,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":657,"mirror_url":null,"open_issues_count":155,"forks":657,"open_issues":155,"watchers":9330,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atom/electron/pulls/1535"},"html":{"href":"https://github.com/atom/electron/pull/1535"},"issue":{"href":"https://api.github.com/repos/atom/electron/issues/1535"},"comments":{"href":"https://api.github.com/repos/atom/electron/issues/1535/comments"},"review_comments":{"href":"https://api.github.com/repos/atom/electron/pulls/1535/comments"},"review_comment":{"href":"https://api.github.com/repos/atom/electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atom/electron/pulls/1535/commits"},"statuses":{"href":"https://api.github.com/repos/atom/electron/statuses/c03beb5de18f26f88bc49c7c9f9d4c0c4714e060"}}}}