{"action":"created","issue":{"url":"https://api.github.com/repos/geotools/geotools/issues/959","labels_url":"https://api.github.com/repos/geotools/geotools/issues/959/labels{/name}","comments_url":"https://api.github.com/repos/geotools/geotools/issues/959/comments","events_url":"https://api.github.com/repos/geotools/geotools/issues/959/events","html_url":"https://github.com/geotools/geotools/pull/959","id":106045365,"number":959,"title":"unhandled exceptions","user":{"login":"waooog","id":5086957,"avatar_url":"https://avatars.githubusercontent.com/u/5086957?v=3","gravatar_id":"","url":"https://api.github.com/users/waooog","html_url":"https://github.com/waooog","followers_url":"https://api.github.com/users/waooog/followers","following_url":"https://api.github.com/users/waooog/following{/other_user}","gists_url":"https://api.github.com/users/waooog/gists{/gist_id}","starred_url":"https://api.github.com/users/waooog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waooog/subscriptions","organizations_url":"https://api.github.com/users/waooog/orgs","repos_url":"https://api.github.com/users/waooog/repos","events_url":"https://api.github.com/users/waooog/events{/privacy}","received_events_url":"https://api.github.com/users/waooog/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-09-11T16:23:58Z","updated_at":"2015-09-12T19:37:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/geotools/geotools/pulls/959","html_url":"https://github.com/geotools/geotools/pull/959","diff_url":"https://github.com/geotools/geotools/pull/959.diff","patch_url":"https://github.com/geotools/geotools/pull/959.patch"},"body":"Two unhandled exceptions are reported by our automatic tool, details are as follows:\r\n\r\nIn method dispose() of class AbstractGridCoverageWriter ( geotools-master\\modules\\library\\coverage\\src\\main\\java\\org\\geotools\\coverage\\grid\\io\\AbstractGridCoverageWriter.java)\r\nThe catch block caught an IOException, while without further actions, to fix this, we need add more code to handle this.\r\n             dispose(){\r\n              ...\r\n              try {\r\n\t\toutStream.flush();\t\t\t\r\n\t} catch (IOException e) {\r\n         ...\r\n}\r\n\r\nAnother case is in method getQueryInfo() of class ArcSDEQuery (geotools-master\\modules\\plugin\\arcsde\\datastore\\src\\main\\java\\org\\geotools\\arcsde\\data\\ArcSDEQuery.java)\r\n\r\nThe catch block caught an NullPointerException, while without further actions, to fix this, we need add more code to handle this.\r\ngetQueryInfo(){\r\n...\r\ntry {\r\n     byClause = definitionQuery.getByClause();\r\n } catch (NullPointerException e) {\r\n     // no-op \r\n  }\r\n...\r\n}\r\nThese two cases are reported by our automatic tool, they might be two unhandled exceptions, I report them, could some of you double check them? Thanks."},"comment":{"url":"https://api.github.com/repos/geotools/geotools/issues/comments/139812818","html_url":"https://github.com/geotools/geotools/pull/959#issuecomment-139812818","issue_url":"https://api.github.com/repos/geotools/geotools/issues/959","id":139812818,"user":{"login":"waooog","id":5086957,"avatar_url":"https://avatars.githubusercontent.com/u/5086957?v=3","gravatar_id":"","url":"https://api.github.com/users/waooog","html_url":"https://github.com/waooog","followers_url":"https://api.github.com/users/waooog/followers","following_url":"https://api.github.com/users/waooog/following{/other_user}","gists_url":"https://api.github.com/users/waooog/gists{/gist_id}","starred_url":"https://api.github.com/users/waooog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waooog/subscriptions","organizations_url":"https://api.github.com/users/waooog/orgs","repos_url":"https://api.github.com/users/waooog/repos","events_url":"https://api.github.com/users/waooog/events{/privacy}","received_events_url":"https://api.github.com/users/waooog/received_events","type":"User","site_admin":false},"created_at":"2015-09-12T19:37:50Z","updated_at":"2015-09-12T19:37:50Z","body":"Hi aaime, \r\nI just found that I have not modified related code snippets to create new branchs, so a new pull request will also wrap a lot of other commits, and  I reopen this request again. \r\nThese odd/buggy code snippets are reported by my on-going automatic code analysis tool, your responses to the results definitely will help me improve the tool :). Thanks."}}