{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/folly/issues/287","labels_url":"https://api.github.com/repos/facebook/folly/issues/287/labels{/name}","comments_url":"https://api.github.com/repos/facebook/folly/issues/287/comments","events_url":"https://api.github.com/repos/facebook/folly/issues/287/events","html_url":"https://github.com/facebook/folly/pull/287","id":97164043,"number":287,"title":"The core of the Windows port","user":{"login":"Orvid","id":709247,"avatar_url":"https://avatars.githubusercontent.com/u/709247?v=3","gravatar_id":"","url":"https://api.github.com/users/Orvid","html_url":"https://github.com/Orvid","followers_url":"https://api.github.com/users/Orvid/followers","following_url":"https://api.github.com/users/Orvid/following{/other_user}","gists_url":"https://api.github.com/users/Orvid/gists{/gist_id}","starred_url":"https://api.github.com/users/Orvid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Orvid/subscriptions","organizations_url":"https://api.github.com/users/Orvid/orgs","repos_url":"https://api.github.com/users/Orvid/repos","events_url":"https://api.github.com/users/Orvid/events{/privacy}","received_events_url":"https://api.github.com/users/Orvid/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/folly/labels/CLA%20Signed","name":"CLA Signed","color":"009900"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-24T22:53:15Z","updated_at":"2015-07-29T22:40:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/folly/pulls/287","html_url":"https://github.com/facebook/folly/pull/287","diff_url":"https://github.com/facebook/folly/pull/287.diff","patch_url":"https://github.com/facebook/folly/pull/287.patch"},"body":"This is as small as I can make it. I have stripped out every other small change, which have been submitted as 43 separate PRs.\r\nThis adds the core files, `CPortability.cpp`, `FilePortability.cpp`, `FilePortability.h`, `SocketPortability.cpp`, `SocketPortability.h`, and `WindowsPortability.h`, which make up the entirety of the portability interface for Windows.\r\nThe vast majority of the files this touches are files in which the `#include`s are changing. The only files with modifications other than `#include`s are:\r\n```\r\nCPortability.h\r\nFileUtil.cpp\r\nMakefile.am\r\nSocketAddress.cpp\r\nSocketAddress.h\r\nio/async/AsyncServerSocket.cpp\r\nio/async/AsyncSocket.cpp\r\nio/async/AsyncUDPSocket.cpp\r\n```\r\nAll other modifications, except for the new files, are purely changing which headers are included.\r\n\r\nHopefully I've managed to make this significantly more reviewable than it originally was."},"comment":{"url":"https://api.github.com/repos/facebook/folly/issues/comments/126117760","html_url":"https://github.com/facebook/folly/pull/287#issuecomment-126117760","issue_url":"https://api.github.com/repos/facebook/folly/issues/287","id":126117760,"user":{"login":"Orvid","id":709247,"avatar_url":"https://avatars.githubusercontent.com/u/709247?v=3","gravatar_id":"","url":"https://api.github.com/users/Orvid","html_url":"https://github.com/Orvid","followers_url":"https://api.github.com/users/Orvid/followers","following_url":"https://api.github.com/users/Orvid/following{/other_user}","gists_url":"https://api.github.com/users/Orvid/gists{/gist_id}","starred_url":"https://api.github.com/users/Orvid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Orvid/subscriptions","organizations_url":"https://api.github.com/users/Orvid/orgs","repos_url":"https://api.github.com/users/Orvid/repos","events_url":"https://api.github.com/users/Orvid/events{/privacy}","received_events_url":"https://api.github.com/users/Orvid/received_events","type":"User","site_admin":false},"created_at":"2015-07-29T22:40:21Z","updated_at":"2015-07-29T22:40:21Z","body":"See #235 for the reason why only a couple of places have annotations."}}