{"action":"created","issue":{"url":"https://api.github.com/repos/jhcepas/ete/issues/88","labels_url":"https://api.github.com/repos/jhcepas/ete/issues/88/labels{/name}","comments_url":"https://api.github.com/repos/jhcepas/ete/issues/88/comments","events_url":"https://api.github.com/repos/jhcepas/ete/issues/88/events","html_url":"https://github.com/jhcepas/ete/pull/88","id":41636253,"number":88,"title":"Python3 support","user":{"login":"khughitt","id":125001,"avatar_url":"https://avatars.githubusercontent.com/u/125001?v=3","gravatar_id":"","url":"https://api.github.com/users/khughitt","html_url":"https://github.com/khughitt","followers_url":"https://api.github.com/users/khughitt/followers","following_url":"https://api.github.com/users/khughitt/following{/other_user}","gists_url":"https://api.github.com/users/khughitt/gists{/gist_id}","starred_url":"https://api.github.com/users/khughitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khughitt/subscriptions","organizations_url":"https://api.github.com/users/khughitt/orgs","repos_url":"https://api.github.com/users/khughitt/repos","events_url":"https://api.github.com/users/khughitt/events{/privacy}","received_events_url":"https://api.github.com/users/khughitt/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2014-09-01T13:12:03Z","updated_at":"2015-05-02T08:52:25Z","closed_at":"2015-05-02T08:52:25Z","pull_request":{"url":"https://api.github.com/repos/jhcepas/ete/pulls/88","html_url":"https://github.com/jhcepas/ete/pull/88","diff_url":"https://github.com/jhcepas/ete/pull/88.diff","patch_url":"https://github.com/jhcepas/ete/pull/88.patch"},"body":"Fixes issue #63, adding initial support for Python 3.\r\n\r\nTook a bit longer than expected, but I think things are in pretty good shape now.\r\n\r\nSome things to note:\r\n\r\n- All 30/30 of the base tests formerly in `test_all.py` pass with Python 2 and 3.\r\n- Versions tested are: 2.7.8 and 3.4.1.\r\n- The test structure has been modified some to make it easier to test with both versions of Python. Instead of running `test_all.py`, you can now do `python setup.py test` and `python2 setup.py test`. (See https://pythonhosted.org/setuptools/setuptools.html#test-build-package-and-run-a-unittest-suite for more information).\r\n- I tried also testing on Python 2.5 and 2.6, but those versions did not appear to work in the original codebase and seemed to be no longer supported? It may be worth explicitly requiring Python 2.7+.\r\n- It looks like the `MySQLdb` adapter is no longer being updated, so it may be worth looking into alternatives for the future if this is an important component. More info:\r\n  - https://pypi.python.org/pypi/MySQL-python/1.2.4\r\n  - http://stackoverflow.com/questions/384471/mysql-db-lib-for-python-3-x\r\n  - https://wiki.python.org/moin/MySQL\r\n- I started looking into the tests that were not run as part of `test_all.py`, namely the XML parsers and phylomeDB3 connectors, but they seem to be different enough from the rest of the tests that I thought it would be good to push these through first and make sure everything is working before considering the optional functionality. Also, this might be a good chance for someone else to tackle some aspects of the porting :)\r\n\r\nFinally, although all of the tests are passing and everything appears to be working fine, I did not do any systematic testing of the functionality that is not covered by the unit tests. It would probably be a good idea to spend some time testing other functionality out that you think may have been missed, and adding unit tests if any issues pop up."},"comment":{"url":"https://api.github.com/repos/jhcepas/ete/issues/comments/98336077","html_url":"https://github.com/jhcepas/ete/pull/88#issuecomment-98336077","issue_url":"https://api.github.com/repos/jhcepas/ete/issues/88","id":98336077,"user":{"login":"jhcepas","id":163658,"avatar_url":"https://avatars.githubusercontent.com/u/163658?v=3","gravatar_id":"","url":"https://api.github.com/users/jhcepas","html_url":"https://github.com/jhcepas","followers_url":"https://api.github.com/users/jhcepas/followers","following_url":"https://api.github.com/users/jhcepas/following{/other_user}","gists_url":"https://api.github.com/users/jhcepas/gists{/gist_id}","starred_url":"https://api.github.com/users/jhcepas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhcepas/subscriptions","organizations_url":"https://api.github.com/users/jhcepas/orgs","repos_url":"https://api.github.com/users/jhcepas/repos","events_url":"https://api.github.com/users/jhcepas/events{/privacy}","received_events_url":"https://api.github.com/users/jhcepas/received_events","type":"User","site_admin":false},"created_at":"2015-05-02T08:52:25Z","updated_at":"2015-05-02T08:52:25Z","body":"@khughitt no problem! Thanks for your help"}}