{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/45278778","id":45278778,"diff_hunk":"@@ -83,7 +86,8 @@ func NewCmdRun(f *cmdutil.Factory, cmdIn io.Reader, cmdOut, cmdErr io.Writer) *c\n }\n \n func addRunFlags(cmd *cobra.Command) {\n-\tcmd.Flags().String(\"generator\", \"\", \"The name of the API generator to use.  Default is 'run/v1' if --restart=Always, otherwise the default is 'run-pod/v1'.\")\n+\t// TODO: Change the default to \"deployment/v1beta1\" when deployment reaches beta (#15313)","path":"pkg/kubectl/cmd/run.go","position":36,"original_position":36,"commit_id":"a3d0ea80b894ebf9cb61a3e5d5abdc352c6c5208","original_commit_id":"a3d0ea80b894ebf9cb61a3e5d5abdc352c6c5208","user":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"body":"ok","created_at":"2015-11-18T23:40:09Z","updated_at":"2015-11-18T23:40:09Z","html_url":"https://github.com/kubernetes/kubernetes/pull/17195#discussion_r45278778","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17195","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/45278778"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/17195#discussion_r45278778"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17195"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17195","id":50592800,"html_url":"https://github.com/kubernetes/kubernetes/pull/17195","diff_url":"https://github.com/kubernetes/kubernetes/pull/17195.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/17195.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/17195","number":17195,"state":"open","locked":false,"title":"kubectl run to produce deployment and job","user":{"login":"janetkuo","id":4876867,"avatar_url":"https://avatars.githubusercontent.com/u/4876867?v=3","gravatar_id":"","url":"https://api.github.com/users/janetkuo","html_url":"https://github.com/janetkuo","followers_url":"https://api.github.com/users/janetkuo/followers","following_url":"https://api.github.com/users/janetkuo/following{/other_user}","gists_url":"https://api.github.com/users/janetkuo/gists{/gist_id}","starred_url":"https://api.github.com/users/janetkuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janetkuo/subscriptions","organizations_url":"https://api.github.com/users/janetkuo/orgs","repos_url":"https://api.github.com/users/janetkuo/repos","events_url":"https://api.github.com/users/janetkuo/events{/privacy}","received_events_url":"https://api.github.com/users/janetkuo/received_events","type":"User","site_admin":false},"body":"Fixes #14954. \r\n\r\n- Implement generators for deployment (`deployment/v1beta1`) and job (`job/v1beta1`). \r\n- Make `kubectl run` default to produce rcs and jobs (instead of rcs and pods). Will replace rcs with deployments once Deployment reaches beta in the future (not in this PR). \r\n- If `--restart=Always`, a rc will be generated; otherwise a job will be generated. \r\n\r\nTODO:\r\n- [x] finish job/deployment related flags and help text (for kubectl run cmd)\r\n- [x] finish job/deployment fields (for generator)\r\n- [x] add tests\r\n\r\n@kubernetes/kubectl @nikhiljindal @ironcladlou ","created_at":"2015-11-13T01:15:35Z","updated_at":"2015-11-18T23:40:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c5035e62cd86a53769d06bc8d5197c92b1b81256","assignee":{"login":"deads2k","id":8225098,"avatar_url":"https://avatars.githubusercontent.com/u/8225098?v=3","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/16","html_url":"https://github.com/kubernetes/kubernetes/milestones/v1.2-candidate","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/16/labels","id":1278500,"number":16,"title":"v1.2-candidate","description":"Things to consider for next minor release.","creator":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"open_issues":217,"closed_issues":22,"state":"open","created_at":"2015-08-29T03:54:34Z","updated_at":"2015-11-18T21:44:31Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17195/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17195/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/17195/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/a3d0ea80b894ebf9cb61a3e5d5abdc352c6c5208","head":{"label":"janetkuo:kubectl-run-deployment-job","ref":"kubectl-run-deployment-job","sha":"a3d0ea80b894ebf9cb61a3e5d5abdc352c6c5208","user":{"login":"janetkuo","id":4876867,"avatar_url":"https://avatars.githubusercontent.com/u/4876867?v=3","gravatar_id":"","url":"https://api.github.com/users/janetkuo","html_url":"https://github.com/janetkuo","followers_url":"https://api.github.com/users/janetkuo/followers","following_url":"https://api.github.com/users/janetkuo/following{/other_user}","gists_url":"https://api.github.com/users/janetkuo/gists{/gist_id}","starred_url":"https://api.github.com/users/janetkuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janetkuo/subscriptions","organizations_url":"https://api.github.com/users/janetkuo/orgs","repos_url":"https://api.github.com/users/janetkuo/repos","events_url":"https://api.github.com/users/janetkuo/events{/privacy}","received_events_url":"https://api.github.com/users/janetkuo/received_events","type":"User","site_admin":false},"repo":{"id":37748937,"name":"kubernetes","full_name":"janetkuo/kubernetes","owner":{"login":"janetkuo","id":4876867,"avatar_url":"https://avatars.githubusercontent.com/u/4876867?v=3","gravatar_id":"","url":"https://api.github.com/users/janetkuo","html_url":"https://github.com/janetkuo","followers_url":"https://api.github.com/users/janetkuo/followers","following_url":"https://api.github.com/users/janetkuo/following{/other_user}","gists_url":"https://api.github.com/users/janetkuo/gists{/gist_id}","starred_url":"https://api.github.com/users/janetkuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janetkuo/subscriptions","organizations_url":"https://api.github.com/users/janetkuo/orgs","repos_url":"https://api.github.com/users/janetkuo/repos","events_url":"https://api.github.com/users/janetkuo/events{/privacy}","received_events_url":"https://api.github.com/users/janetkuo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/janetkuo/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/janetkuo/kubernetes","forks_url":"https://api.github.com/repos/janetkuo/kubernetes/forks","keys_url":"https://api.github.com/repos/janetkuo/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/janetkuo/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/janetkuo/kubernetes/teams","hooks_url":"https://api.github.com/repos/janetkuo/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/janetkuo/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/janetkuo/kubernetes/events","assignees_url":"https://api.github.com/repos/janetkuo/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/janetkuo/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/janetkuo/kubernetes/tags","blobs_url":"https://api.github.com/repos/janetkuo/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/janetkuo/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/janetkuo/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/janetkuo/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/janetkuo/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/janetkuo/kubernetes/languages","stargazers_url":"https://api.github.com/repos/janetkuo/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/janetkuo/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/janetkuo/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/janetkuo/kubernetes/subscription","commits_url":"https://api.github.com/repos/janetkuo/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/janetkuo/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/janetkuo/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/janetkuo/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/janetkuo/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/janetkuo/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/janetkuo/kubernetes/merges","archive_url":"https://api.github.com/repos/janetkuo/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/janetkuo/kubernetes/downloads","issues_url":"https://api.github.com/repos/janetkuo/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/janetkuo/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/janetkuo/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/janetkuo/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/janetkuo/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/janetkuo/kubernetes/releases{/id}","created_at":"2015-06-19T22:29:18Z","updated_at":"2015-06-19T22:29:25Z","pushed_at":"2015-11-18T23:36:42Z","git_url":"git://github.com/janetkuo/kubernetes.git","ssh_url":"git@github.com:janetkuo/kubernetes.git","clone_url":"https://github.com/janetkuo/kubernetes.git","svn_url":"https://github.com/janetkuo/kubernetes","homepage":"http://kubernetes.io","size":137507,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"0ed6432ff7cf8383a99c0f7524099d1ed929bcbd","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-11-18T23:11:03Z","pushed_at":"2015-11-18T23:36:44Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":287894,"stargazers_count":11326,"watchers_count":11326,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2997,"mirror_url":null,"open_issues_count":2354,"forks":2997,"open_issues":2354,"watchers":11326,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17195"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/17195"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/17195"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/17195/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17195/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17195/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/a3d0ea80b894ebf9cb61a3e5d5abdc352c6c5208"}}}}