{"action":"created","issue":{"url":"https://api.github.com/repos/autumnai/collenchyma/issues/10","labels_url":"https://api.github.com/repos/autumnai/collenchyma/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/autumnai/collenchyma/issues/10/comments","events_url":"https://api.github.com/repos/autumnai/collenchyma/issues/10/events","html_url":"https://github.com/autumnai/collenchyma/pull/10","id":119699079,"number":10,"title":"Move to stable","user":{"login":"skade","id":47542,"avatar_url":"https://avatars.githubusercontent.com/u/47542?v=3","gravatar_id":"","url":"https://api.github.com/users/skade","html_url":"https://github.com/skade","followers_url":"https://api.github.com/users/skade/followers","following_url":"https://api.github.com/users/skade/following{/other_user}","gists_url":"https://api.github.com/users/skade/gists{/gist_id}","starred_url":"https://api.github.com/users/skade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skade/subscriptions","organizations_url":"https://api.github.com/users/skade/orgs","repos_url":"https://api.github.com/users/skade/repos","events_url":"https://api.github.com/users/skade/events{/privacy}","received_events_url":"https://api.github.com/users/skade/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-12-01T11:39:04Z","updated_at":"2015-12-02T15:51:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/autumnai/collenchyma/pulls/10","html_url":"https://github.com/autumnai/collenchyma/pull/10","diff_url":"https://github.com/autumnai/collenchyma/pull/10.diff","patch_url":"https://github.com/autumnai/collenchyma/pull/10.patch"},"body":"This PR removes unnecessary use of feature flags that bar using Rust on stable([1])([2]) compilers.\r\n\r\nReasons being:\r\n* associated consts (Tracking issue: https://github.com/rust-lang/rust/issues/29646) are currently buggy and can be replaced by an fn in that case.\r\n* associated_type_defaults can be removed without breakage\r\n* unboxed_closures can be removed without breakage\r\n* StaticMutex has an uncertain future (https://github.com/rust-lang/rust/issues/27717) and can be emulated in that case by using `lazy_static!` (correct me if I'm wrong)\r\n\r\nFinally, I must admit that I didn't get the test suite running quickly.\r\n\r\n([1]) Outstanding: this doesn't _quite_ work on stable yet, as some APIs in use are currently making their way through beta, so they are not feature gated, but also not available in 1.4.0. 1.5.0 beta works and as 1.5.0 is 2 weeks away, this is probably not worth the effort.\r\n([2]) rblas is not on stable yet, see https://github.com/mikkyang/rust-blas/pull/12 for that. You can use that version of rust-blas by checking it out from my https://github.com/skade/rust-blas/ and dropping the following `.cargo/config` in your repository:\r\n\r\n```\r\npaths = [\"/path/to/rblas/checkout\"]\r\n```"},"comment":{"url":"https://api.github.com/repos/autumnai/collenchyma/issues/comments/161341555","html_url":"https://github.com/autumnai/collenchyma/pull/10#issuecomment-161341555","issue_url":"https://api.github.com/repos/autumnai/collenchyma/issues/10","id":161341555,"user":{"login":"skade","id":47542,"avatar_url":"https://avatars.githubusercontent.com/u/47542?v=3","gravatar_id":"","url":"https://api.github.com/users/skade","html_url":"https://github.com/skade","followers_url":"https://api.github.com/users/skade/followers","following_url":"https://api.github.com/users/skade/following{/other_user}","gists_url":"https://api.github.com/users/skade/gists{/gist_id}","starred_url":"https://api.github.com/users/skade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skade/subscriptions","organizations_url":"https://api.github.com/users/skade/orgs","repos_url":"https://api.github.com/users/skade/repos","events_url":"https://api.github.com/users/skade/events{/privacy}","received_events_url":"https://api.github.com/users/skade/received_events","type":"User","site_admin":false},"created_at":"2015-12-02T15:51:24Z","updated_at":"2015-12-02T15:51:24Z","body":"https://github.com/mikkyang/rust-blas/pull/12#issuecomment-161337587 rblas is now on 0.0.11, I added the changed cargo-file."}}