{"action":"created","comment":{"url":"https://api.github.com/repos/appc/spec/pulls/comments/34064548","id":34064548,"diff_hunk":"@@ -163,9 +163,11 @@ JSON Schema for the Pod Manifest, conforming to [RFC4627](https://tools.ietf.org\n     * **annotations** (list of objects, optional) arbitrary metadata appended to the app. The annotation objects must have a *name* key that has a value that is restricted to the [AC Name](types.md#ac-name-type) formatting and *value* key that is an arbitrary string). Annotation names must be unique within the list. These will be merged with annotations provided by the image manifest when queried via the metadata service; values in this list take precedence over those in the image manifest.\n * **volumes** (list of objects, optional) list of volumes which will be mounted into each application's filesystem\n     * **name** (string, required) used to map the volume to an app's mountPoint at runtime. (restricted to the [AC Name](types.md#ac-name-type) formatting)\n-    * **kind** (string, required) either \"empty\" or \"host\". \"empty\" fulfills a mount point by ensuring the path exists (i.e., writes go to the app's chroot). \"host\" fulfills a mount point with a bind mount from a **source**.\n+    * **readOnly** (boolean, optional, defaults to \"false\" if unsupplied) whether or not the volume will be mounted read only.\n+    * **kind** (string, required) either:\n+        * **empty** - creates an empty directory on the host and bind mounts it into the container. All containers in the pod share the mount, and the lifetime of the volume is equal to the lifetime of the pod (i.e. the directory on the host machine is removed when the pod exits)","path":"spec/pods.md","position":7,"original_position":7,"commit_id":"487fcd7821555920565fade45ca21fb51d088bcb","original_commit_id":"487fcd7821555920565fade45ca21fb51d088bcb","user":{"login":"jonboulle","id":2601015,"avatar_url":"https://avatars.githubusercontent.com/u/2601015?v=3","gravatar_id":"","url":"https://api.github.com/users/jonboulle","html_url":"https://github.com/jonboulle","followers_url":"https://api.github.com/users/jonboulle/followers","following_url":"https://api.github.com/users/jonboulle/following{/other_user}","gists_url":"https://api.github.com/users/jonboulle/gists{/gist_id}","starred_url":"https://api.github.com/users/jonboulle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonboulle/subscriptions","organizations_url":"https://api.github.com/users/jonboulle/orgs","repos_url":"https://api.github.com/users/jonboulle/repos","events_url":"https://api.github.com/users/jonboulle/events{/privacy}","received_events_url":"https://api.github.com/users/jonboulle/received_events","type":"User","site_admin":false},"body":"> (i.e. the directory on the host machine is removed when the pod exits)\r\n\r\nThis makes me a little uneasy. How about \"the directory on the host machine is removed when the pod's filesystem is garbage collected\"","created_at":"2015-07-07T17:13:13Z","updated_at":"2015-07-07T17:13:13Z","html_url":"https://github.com/appc/spec/pull/449#discussion_r34064548","pull_request_url":"https://api.github.com/repos/appc/spec/pulls/449","_links":{"self":{"href":"https://api.github.com/repos/appc/spec/pulls/comments/34064548"},"html":{"href":"https://github.com/appc/spec/pull/449#discussion_r34064548"},"pull_request":{"href":"https://api.github.com/repos/appc/spec/pulls/449"}}},"pull_request":{"url":"https://api.github.com/repos/appc/spec/pulls/449","id":37987789,"html_url":"https://github.com/appc/spec/pull/449","diff_url":"https://github.com/appc/spec/pull/449.diff","patch_url":"https://github.com/appc/spec/pull/449.patch","issue_url":"https://api.github.com/repos/appc/spec/issues/449","number":449,"state":"open","locked":false,"title":"spec pods: Clarify empty volume kind","user":{"login":"kibra","id":728648,"avatar_url":"https://avatars.githubusercontent.com/u/728648?v=3","gravatar_id":"","url":"https://api.github.com/users/kibra","html_url":"https://github.com/kibra","followers_url":"https://api.github.com/users/kibra/followers","following_url":"https://api.github.com/users/kibra/following{/other_user}","gists_url":"https://api.github.com/users/kibra/gists{/gist_id}","starred_url":"https://api.github.com/users/kibra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kibra/subscriptions","organizations_url":"https://api.github.com/users/kibra/orgs","repos_url":"https://api.github.com/users/kibra/repos","events_url":"https://api.github.com/users/kibra/events{/privacy}","received_events_url":"https://api.github.com/users/kibra/received_events","type":"User","site_admin":false},"body":"The spec for the \"empty\" volume kind is unclear. See https://github.com/appc/spec/issues/183 for the issue/discussion around this.\r\n\r\n**Note:** My change proposes the rather strong spec of: `lifetime of the empty volume == lifetime of the pod` \r\nI feel that this makes the use case of \"empty\" more clear than specifying `lifetime of the empty volume >= lifetime of the pod` as was suggested in https://github.com/appc/spec/issues/183#issuecomment-98582304 However, I don't have a strong opinion around this, and would be happy to change what I wrote.","created_at":"2015-06-18T09:37:58Z","updated_at":"2015-07-07T17:13:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f2a9fcc28e5090fcd530c355a5d44d36b254232","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/appc/spec/pulls/449/commits","review_comments_url":"https://api.github.com/repos/appc/spec/pulls/449/comments","review_comment_url":"https://api.github.com/repos/appc/spec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appc/spec/issues/449/comments","statuses_url":"https://api.github.com/repos/appc/spec/statuses/487fcd7821555920565fade45ca21fb51d088bcb","head":{"label":"kibra:clearify_empty_volume","ref":"clearify_empty_volume","sha":"487fcd7821555920565fade45ca21fb51d088bcb","user":{"login":"kibra","id":728648,"avatar_url":"https://avatars.githubusercontent.com/u/728648?v=3","gravatar_id":"","url":"https://api.github.com/users/kibra","html_url":"https://github.com/kibra","followers_url":"https://api.github.com/users/kibra/followers","following_url":"https://api.github.com/users/kibra/following{/other_user}","gists_url":"https://api.github.com/users/kibra/gists{/gist_id}","starred_url":"https://api.github.com/users/kibra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kibra/subscriptions","organizations_url":"https://api.github.com/users/kibra/orgs","repos_url":"https://api.github.com/users/kibra/repos","events_url":"https://api.github.com/users/kibra/events{/privacy}","received_events_url":"https://api.github.com/users/kibra/received_events","type":"User","site_admin":false},"repo":{"id":37042411,"name":"spec","full_name":"kibra/spec","owner":{"login":"kibra","id":728648,"avatar_url":"https://avatars.githubusercontent.com/u/728648?v=3","gravatar_id":"","url":"https://api.github.com/users/kibra","html_url":"https://github.com/kibra","followers_url":"https://api.github.com/users/kibra/followers","following_url":"https://api.github.com/users/kibra/following{/other_user}","gists_url":"https://api.github.com/users/kibra/gists{/gist_id}","starred_url":"https://api.github.com/users/kibra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kibra/subscriptions","organizations_url":"https://api.github.com/users/kibra/orgs","repos_url":"https://api.github.com/users/kibra/repos","events_url":"https://api.github.com/users/kibra/events{/privacy}","received_events_url":"https://api.github.com/users/kibra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kibra/spec","description":"App Container Specification and Tooling","fork":true,"url":"https://api.github.com/repos/kibra/spec","forks_url":"https://api.github.com/repos/kibra/spec/forks","keys_url":"https://api.github.com/repos/kibra/spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kibra/spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kibra/spec/teams","hooks_url":"https://api.github.com/repos/kibra/spec/hooks","issue_events_url":"https://api.github.com/repos/kibra/spec/issues/events{/number}","events_url":"https://api.github.com/repos/kibra/spec/events","assignees_url":"https://api.github.com/repos/kibra/spec/assignees{/user}","branches_url":"https://api.github.com/repos/kibra/spec/branches{/branch}","tags_url":"https://api.github.com/repos/kibra/spec/tags","blobs_url":"https://api.github.com/repos/kibra/spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kibra/spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kibra/spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/kibra/spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kibra/spec/statuses/{sha}","languages_url":"https://api.github.com/repos/kibra/spec/languages","stargazers_url":"https://api.github.com/repos/kibra/spec/stargazers","contributors_url":"https://api.github.com/repos/kibra/spec/contributors","subscribers_url":"https://api.github.com/repos/kibra/spec/subscribers","subscription_url":"https://api.github.com/repos/kibra/spec/subscription","commits_url":"https://api.github.com/repos/kibra/spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/kibra/spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/kibra/spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/kibra/spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/kibra/spec/contents/{+path}","compare_url":"https://api.github.com/repos/kibra/spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kibra/spec/merges","archive_url":"https://api.github.com/repos/kibra/spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kibra/spec/downloads","issues_url":"https://api.github.com/repos/kibra/spec/issues{/number}","pulls_url":"https://api.github.com/repos/kibra/spec/pulls{/number}","milestones_url":"https://api.github.com/repos/kibra/spec/milestones{/number}","notifications_url":"https://api.github.com/repos/kibra/spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kibra/spec/labels{/name}","releases_url":"https://api.github.com/repos/kibra/spec/releases{/id}","created_at":"2015-06-08T02:44:25Z","updated_at":"2015-06-08T02:44:26Z","pushed_at":"2015-06-20T06:21:03Z","git_url":"git://github.com/kibra/spec.git","ssh_url":"git@github.com:kibra/spec.git","clone_url":"https://github.com/kibra/spec.git","svn_url":"https://github.com/kibra/spec","homepage":null,"size":1108,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appc:master","ref":"master","sha":"014be79f140f05deca98487be81b96c1d2567eb4","user":{"login":"appc","id":10080092,"avatar_url":"https://avatars.githubusercontent.com/u/10080092?v=3","gravatar_id":"","url":"https://api.github.com/users/appc","html_url":"https://github.com/appc","followers_url":"https://api.github.com/users/appc/followers","following_url":"https://api.github.com/users/appc/following{/other_user}","gists_url":"https://api.github.com/users/appc/gists{/gist_id}","starred_url":"https://api.github.com/users/appc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appc/subscriptions","organizations_url":"https://api.github.com/users/appc/orgs","repos_url":"https://api.github.com/users/appc/repos","events_url":"https://api.github.com/users/appc/events{/privacy}","received_events_url":"https://api.github.com/users/appc/received_events","type":"Organization","site_admin":false},"repo":{"id":27782596,"name":"spec","full_name":"appc/spec","owner":{"login":"appc","id":10080092,"avatar_url":"https://avatars.githubusercontent.com/u/10080092?v=3","gravatar_id":"","url":"https://api.github.com/users/appc","html_url":"https://github.com/appc","followers_url":"https://api.github.com/users/appc/followers","following_url":"https://api.github.com/users/appc/following{/other_user}","gists_url":"https://api.github.com/users/appc/gists{/gist_id}","starred_url":"https://api.github.com/users/appc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appc/subscriptions","organizations_url":"https://api.github.com/users/appc/orgs","repos_url":"https://api.github.com/users/appc/repos","events_url":"https://api.github.com/users/appc/events{/privacy}","received_events_url":"https://api.github.com/users/appc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appc/spec","description":"App Container Specification and Tooling","fork":false,"url":"https://api.github.com/repos/appc/spec","forks_url":"https://api.github.com/repos/appc/spec/forks","keys_url":"https://api.github.com/repos/appc/spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appc/spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appc/spec/teams","hooks_url":"https://api.github.com/repos/appc/spec/hooks","issue_events_url":"https://api.github.com/repos/appc/spec/issues/events{/number}","events_url":"https://api.github.com/repos/appc/spec/events","assignees_url":"https://api.github.com/repos/appc/spec/assignees{/user}","branches_url":"https://api.github.com/repos/appc/spec/branches{/branch}","tags_url":"https://api.github.com/repos/appc/spec/tags","blobs_url":"https://api.github.com/repos/appc/spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appc/spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appc/spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/appc/spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appc/spec/statuses/{sha}","languages_url":"https://api.github.com/repos/appc/spec/languages","stargazers_url":"https://api.github.com/repos/appc/spec/stargazers","contributors_url":"https://api.github.com/repos/appc/spec/contributors","subscribers_url":"https://api.github.com/repos/appc/spec/subscribers","subscription_url":"https://api.github.com/repos/appc/spec/subscription","commits_url":"https://api.github.com/repos/appc/spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/appc/spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/appc/spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/appc/spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/appc/spec/contents/{+path}","compare_url":"https://api.github.com/repos/appc/spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appc/spec/merges","archive_url":"https://api.github.com/repos/appc/spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appc/spec/downloads","issues_url":"https://api.github.com/repos/appc/spec/issues{/number}","pulls_url":"https://api.github.com/repos/appc/spec/pulls{/number}","milestones_url":"https://api.github.com/repos/appc/spec/milestones{/number}","notifications_url":"https://api.github.com/repos/appc/spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appc/spec/labels{/name}","releases_url":"https://api.github.com/repos/appc/spec/releases{/id}","created_at":"2014-12-09T19:17:54Z","updated_at":"2015-07-07T02:46:09Z","pushed_at":"2015-07-06T15:01:18Z","git_url":"git://github.com/appc/spec.git","ssh_url":"git@github.com:appc/spec.git","clone_url":"https://github.com/appc/spec.git","svn_url":"https://github.com/appc/spec","homepage":null,"size":3086,"stargazers_count":707,"watchers_count":707,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":95,"mirror_url":null,"open_issues_count":98,"forks":95,"open_issues":98,"watchers":707,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appc/spec/pulls/449"},"html":{"href":"https://github.com/appc/spec/pull/449"},"issue":{"href":"https://api.github.com/repos/appc/spec/issues/449"},"comments":{"href":"https://api.github.com/repos/appc/spec/issues/449/comments"},"review_comments":{"href":"https://api.github.com/repos/appc/spec/pulls/449/comments"},"review_comment":{"href":"https://api.github.com/repos/appc/spec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appc/spec/pulls/449/commits"},"statuses":{"href":"https://api.github.com/repos/appc/spec/statuses/487fcd7821555920565fade45ca21fb51d088bcb"}}}}