{"action":"opened","number":1779,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/1779","id":33498523,"html_url":"https://github.com/openshift/origin/pull/1779","diff_url":"https://github.com/openshift/origin/pull/1779.diff","patch_url":"https://github.com/openshift/origin/pull/1779.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/1779","number":1779,"state":"open","locked":false,"title":"default certificate support","user":{"login":"pweil-","id":5230419,"avatar_url":"https://avatars.githubusercontent.com/u/5230419?v=3","gravatar_id":"","url":"https://api.github.com/users/pweil-","html_url":"https://github.com/pweil-","followers_url":"https://api.github.com/users/pweil-/followers","following_url":"https://api.github.com/users/pweil-/following{/other_user}","gists_url":"https://api.github.com/users/pweil-/gists{/gist_id}","starred_url":"https://api.github.com/users/pweil-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pweil-/subscriptions","organizations_url":"https://api.github.com/users/pweil-/orgs","repos_url":"https://api.github.com/users/pweil-/repos","events_url":"https://api.github.com/users/pweil-/events{/privacy}","received_events_url":"https://api.github.com/users/pweil-/received_events","type":"User","site_admin":false},"body":"This pr contains the ability to specify a default certificate for a router in order to support wild card certificates.\r\n\r\nIncluded:\r\n\r\n1.  new command flag for the router `--default-cert=/path/to/file`\r\n1.  haproxy template update that uses the `crt` directive to add the default cert if available.  It will still use the dummy pem file in the non-sni backend if no default cert is found.  In the SNI end it will resort to the configured directory\r\n1.  refactor of the template since we are passing more than just routes as the data.  There is now a wrapper object with `DefaultCertificate` and `State`\r\n1.  the shard is now passed to validation.  If validation sees that there are no certificates set for edge/reencrypt termination it will see if the host ends in the DNS shard configuration\r\n\r\nIssue: for updates we don't allocate the shard.   Right now I short circuit for a nil shard so an error condition exists for an update where tls is removed, term is still set to edge/reencrypt.  I assume at some point we'll want to store the shard configuration somewhere and be able to retrieve it via an annotation on the route.\r\n\r\nIf this looks good I'll wrap up the unit tests tomorrow.\r\n\r\n@ramr @rajatchopra @smarterclayton PTAL","created_at":"2015-04-16T22:19:55Z","updated_at":"2015-04-16T22:19:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/1779/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/1779/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/1779/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/de5657fabdc296de2393903d631da182c78ab62b","head":{"label":"pweil-:router-wildcard-cert","ref":"router-wildcard-cert","sha":"de5657fabdc296de2393903d631da182c78ab62b","user":{"login":"pweil-","id":5230419,"avatar_url":"https://avatars.githubusercontent.com/u/5230419?v=3","gravatar_id":"","url":"https://api.github.com/users/pweil-","html_url":"https://github.com/pweil-","followers_url":"https://api.github.com/users/pweil-/followers","following_url":"https://api.github.com/users/pweil-/following{/other_user}","gists_url":"https://api.github.com/users/pweil-/gists{/gist_id}","starred_url":"https://api.github.com/users/pweil-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pweil-/subscriptions","organizations_url":"https://api.github.com/users/pweil-/orgs","repos_url":"https://api.github.com/users/pweil-/repos","events_url":"https://api.github.com/users/pweil-/events{/privacy}","received_events_url":"https://api.github.com/users/pweil-/received_events","type":"User","site_admin":false},"repo":{"id":24119315,"name":"origin","full_name":"pweil-/origin","owner":{"login":"pweil-","id":5230419,"avatar_url":"https://avatars.githubusercontent.com/u/5230419?v=3","gravatar_id":"","url":"https://api.github.com/users/pweil-","html_url":"https://github.com/pweil-","followers_url":"https://api.github.com/users/pweil-/followers","following_url":"https://api.github.com/users/pweil-/following{/other_user}","gists_url":"https://api.github.com/users/pweil-/gists{/gist_id}","starred_url":"https://api.github.com/users/pweil-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pweil-/subscriptions","organizations_url":"https://api.github.com/users/pweil-/orgs","repos_url":"https://api.github.com/users/pweil-/repos","events_url":"https://api.github.com/users/pweil-/events{/privacy}","received_events_url":"https://api.github.com/users/pweil-/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pweil-/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/pweil-/origin","forks_url":"https://api.github.com/repos/pweil-/origin/forks","keys_url":"https://api.github.com/repos/pweil-/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pweil-/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pweil-/origin/teams","hooks_url":"https://api.github.com/repos/pweil-/origin/hooks","issue_events_url":"https://api.github.com/repos/pweil-/origin/issues/events{/number}","events_url":"https://api.github.com/repos/pweil-/origin/events","assignees_url":"https://api.github.com/repos/pweil-/origin/assignees{/user}","branches_url":"https://api.github.com/repos/pweil-/origin/branches{/branch}","tags_url":"https://api.github.com/repos/pweil-/origin/tags","blobs_url":"https://api.github.com/repos/pweil-/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pweil-/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pweil-/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/pweil-/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pweil-/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/pweil-/origin/languages","stargazers_url":"https://api.github.com/repos/pweil-/origin/stargazers","contributors_url":"https://api.github.com/repos/pweil-/origin/contributors","subscribers_url":"https://api.github.com/repos/pweil-/origin/subscribers","subscription_url":"https://api.github.com/repos/pweil-/origin/subscription","commits_url":"https://api.github.com/repos/pweil-/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/pweil-/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/pweil-/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/pweil-/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/pweil-/origin/contents/{+path}","compare_url":"https://api.github.com/repos/pweil-/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pweil-/origin/merges","archive_url":"https://api.github.com/repos/pweil-/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pweil-/origin/downloads","issues_url":"https://api.github.com/repos/pweil-/origin/issues{/number}","pulls_url":"https://api.github.com/repos/pweil-/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/pweil-/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/pweil-/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pweil-/origin/labels{/name}","releases_url":"https://api.github.com/repos/pweil-/origin/releases{/id}","created_at":"2014-09-16T21:53:06Z","updated_at":"2015-04-16T12:43:35Z","pushed_at":"2015-04-16T22:14:34Z","git_url":"git://github.com/pweil-/origin.git","ssh_url":"git@github.com:pweil-/origin.git","clone_url":"https://github.com/pweil-/origin.git","svn_url":"https://github.com/pweil-/origin","homepage":"https://openshift.github.io","size":80567,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"7965c0ae51b1e1a38f000c4d9ec80405d1740b1c","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2015-04-16T21:29:25Z","pushed_at":"2015-04-16T22:19:55Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":121347,"stargazers_count":372,"watchers_count":372,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":186,"mirror_url":null,"open_issues_count":191,"forks":186,"open_issues":191,"watchers":372,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/1779"},"html":{"href":"https://github.com/openshift/origin/pull/1779"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/1779"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/1779/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/1779/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/1779/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/de5657fabdc296de2393903d631da182c78ab62b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":126,"deletions":38,"changed_files":9}}