{"action":"created","issue":{"url":"https://api.github.com/repos/firegento/firegento-magesetup/issues/194","labels_url":"https://api.github.com/repos/firegento/firegento-magesetup/issues/194/labels{/name}","comments_url":"https://api.github.com/repos/firegento/firegento-magesetup/issues/194/comments","events_url":"https://api.github.com/repos/firegento/firegento-magesetup/issues/194/events","html_url":"https://github.com/firegento/firegento-magesetup/issues/194","id":103497006,"number":194,"title":"No tax info for bundle products - intentionally?","user":{"login":"infabo","id":3999104,"avatar_url":"https://avatars.githubusercontent.com/u/3999104?v=3","gravatar_id":"","url":"https://api.github.com/users/infabo","html_url":"https://github.com/infabo","followers_url":"https://api.github.com/users/infabo/followers","following_url":"https://api.github.com/users/infabo/following{/other_user}","gists_url":"https://api.github.com/users/infabo/gists{/gist_id}","starred_url":"https://api.github.com/users/infabo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infabo/subscriptions","organizations_url":"https://api.github.com/users/infabo/orgs","repos_url":"https://api.github.com/users/infabo/repos","events_url":"https://api.github.com/users/infabo/events{/privacy}","received_events_url":"https://api.github.com/users/infabo/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/firegento/firegento-magesetup/labels/question","name":"question","color":"cc317c"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-08-27T12:26:36Z","updated_at":"2015-11-12T21:24:50Z","closed_at":null,"body":"In class FireGento_MageSetup_Block_Bundle_Catalog_Product_Price the following method does return an empty tax-rate if the product type is of type \"bundle\".\r\nIs this by design or should it rather be \"grouped\"? By Magento default bundle-products do have a tax_class_id, therefore it should be possible (IMHO) to calculate the tax_rate for bundles.\r\nI'm a bit confused.\r\n\r\nhttps://github.com/firegento/firegento-magesetup/blob/master/src/app/code/community/FireGento/MageSetup/Block/Bundle/Catalog/Product/Price.php#L79\r\n\r\n```\r\n /**\r\n     * Retrieves formatted string of tax rate for user output\r\n     *\r\n     * @return string Formatted Tax Rate for the given locale\r\n     */\r\n    public function getFormattedTaxRate()\r\n    {\r\n        if ($this->getTaxRate() === null\r\n            || $this->getProduct()->getTypeId() == 'bundle'\r\n        ) {\r\n            return '';\r\n        }\r\n\r\n        $locale = Mage::app()->getLocale()->getLocaleCode();\r\n        $taxRate = Zend_Locale_Format::toFloat($this->getTaxRate(), array('locale' => $locale));\r\n\r\n        return $this->__('%s%%', $taxRate);\r\n    }\r\n```\r\n\r\nCould someone enlighten me? :)"},"comment":{"url":"https://api.github.com/repos/firegento/firegento-magesetup/issues/comments/156239784","html_url":"https://github.com/firegento/firegento-magesetup/issues/194#issuecomment-156239784","issue_url":"https://api.github.com/repos/firegento/firegento-magesetup/issues/194","id":156239784,"user":{"login":"Schrank","id":379680,"avatar_url":"https://avatars.githubusercontent.com/u/379680?v=3","gravatar_id":"","url":"https://api.github.com/users/Schrank","html_url":"https://github.com/Schrank","followers_url":"https://api.github.com/users/Schrank/followers","following_url":"https://api.github.com/users/Schrank/following{/other_user}","gists_url":"https://api.github.com/users/Schrank/gists{/gist_id}","starred_url":"https://api.github.com/users/Schrank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Schrank/subscriptions","organizations_url":"https://api.github.com/users/Schrank/orgs","repos_url":"https://api.github.com/users/Schrank/repos","events_url":"https://api.github.com/users/Schrank/events{/privacy}","received_events_url":"https://api.github.com/users/Schrank/received_events","type":"User","site_admin":false},"created_at":"2015-11-12T21:24:50Z","updated_at":"2015-11-12T21:24:50Z","body":"Maybe I'm too dumb, but how to configure a fixed tax class on a bundle product?"}}