{"action":"created","comment":{"url":"https://api.github.com/repos/sctplab/rfc4960bis/pulls/comments/40905312","id":40905312,"diff_hunk":"@@ -695,6 +695,46 @@ expiration.</t>\n </section>\n </section>\n \n+<section title='Order of Adjustments of partial_bytes_acked and cwnd'>\n+<!-- The correction is in accordance with RFC 3465, Section 2.1 -->\n+<section title='Description of the Problem'>\n+<t>Section 7.2.2 of <xref target=\"RFC4960\"/> is unclear about the order \n+of adjustments applied to partial_bytes_acked and cwnd in the Congestion\n+Avoidance phase.</t>\n+</section>\n+<section title='Text Changes to the Document'>\n+<figure>\n+<artwork>\n+---------\n+Old text: (Section 7.2.2)\n+---------\n+\n+o  When partial_bytes_acked is equal to or greater than cwnd and\n+   before the arrival of the SACK the sender had cwnd or more bytes\n+   of data outstanding (i.e., before arrival of the SACK, flightsize\n+   was greater than or equal to cwnd), increase cwnd by MTU, and\n+   reset partial_bytes_acked to (partial_bytes_acked - cwnd).\n+\n+---------\n+New text: (Section 7.2.2)\n+---------\n+\n+o  When partial_bytes_acked is equal to or greater than cwnd and\n+   before the arrival of the SACK the sender had cwnd or more bytes\n+   of data outstanding (i.e., before arrival of the SACK, flightsize\n+   was greater than or equal to cwnd), partial_bytes_acked is reset\n+   to (partial_bytes_acked - cwnd). Next, cwnd is increased by MTU\n+   with the limitation that the cwnd shall not be increased by more\n+   than one MTU per RTT.","path":"draft-tuexen-tsvwg-rfc4960-errata.xml","position":34,"original_position":34,"commit_id":"7d8f792d12de301e72ee99d69d009b1160abc0ee","original_commit_id":"7d8f792d12de301e72ee99d69d009b1160abc0ee","user":{"login":"MaximProshin","id":13518722,"avatar_url":"https://avatars.githubusercontent.com/u/13518722?v=3","gravatar_id":"","url":"https://api.github.com/users/MaximProshin","html_url":"https://github.com/MaximProshin","followers_url":"https://api.github.com/users/MaximProshin/followers","following_url":"https://api.github.com/users/MaximProshin/following{/other_user}","gists_url":"https://api.github.com/users/MaximProshin/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximProshin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximProshin/subscriptions","organizations_url":"https://api.github.com/users/MaximProshin/orgs","repos_url":"https://api.github.com/users/MaximProshin/repos","events_url":"https://api.github.com/users/MaximProshin/events{/privacy}","received_events_url":"https://api.github.com/users/MaximProshin/received_events","type":"User","site_admin":false},"body":"Yes, it is caused by high pba. \r\nI think the most obvious use case is when flightsize and cwnd were high and then the loss was detected so that cwnd became low. After that, arrival of SACKs could increase cwnd more often than once per RTT. \r\nAnother use case is when pba was increased on a low traffic rate but cwnd was not.\r\nIt is important to state that SCTP MUST NOT increase cwnd by more than 1 MTU per RTT. I believe TCP RFC(s) state the same.\r\nRegarding pba, I think it is still better to decrease it by cwnd every time it becomes equal or greater than cwnd but I need to think more about it (the opposite argument may be that the same is not done by SCTP when SACK acknowledges new data but flightsize is less than cwnd).","created_at":"2015-10-01T12:02:10Z","updated_at":"2015-10-01T12:02:10Z","html_url":"https://github.com/sctplab/rfc4960bis/pull/28#discussion_r40905312","pull_request_url":"https://api.github.com/repos/sctplab/rfc4960bis/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/sctplab/rfc4960bis/pulls/comments/40905312"},"html":{"href":"https://github.com/sctplab/rfc4960bis/pull/28#discussion_r40905312"},"pull_request":{"href":"https://api.github.com/repos/sctplab/rfc4960bis/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/sctplab/rfc4960bis/pulls/28","id":46412902,"html_url":"https://github.com/sctplab/rfc4960bis/pull/28","diff_url":"https://github.com/sctplab/rfc4960bis/pull/28.diff","patch_url":"https://github.com/sctplab/rfc4960bis/pull/28.patch","issue_url":"https://api.github.com/repos/sctplab/rfc4960bis/issues/28","number":28,"state":"open","locked":false,"title":"Added text for issue 9","user":{"login":"MaximProshin","id":13518722,"avatar_url":"https://avatars.githubusercontent.com/u/13518722?v=3","gravatar_id":"","url":"https://api.github.com/users/MaximProshin","html_url":"https://github.com/MaximProshin","followers_url":"https://api.github.com/users/MaximProshin/followers","following_url":"https://api.github.com/users/MaximProshin/following{/other_user}","gists_url":"https://api.github.com/users/MaximProshin/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximProshin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximProshin/subscriptions","organizations_url":"https://api.github.com/users/MaximProshin/orgs","repos_url":"https://api.github.com/users/MaximProshin/repos","events_url":"https://api.github.com/users/MaximProshin/events{/privacy}","received_events_url":"https://api.github.com/users/MaximProshin/received_events","type":"User","site_admin":false},"body":"The part about cwnd increase at most one MTU per RTT is not described. Perhaps it is not ok and we should either describe it here in the same section or separately. ","created_at":"2015-09-30T14:59:16Z","updated_at":"2015-10-01T12:02:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3144bdc69b599f2022bc4f0efa34ff22dd821425","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sctplab/rfc4960bis/pulls/28/commits","review_comments_url":"https://api.github.com/repos/sctplab/rfc4960bis/pulls/28/comments","review_comment_url":"https://api.github.com/repos/sctplab/rfc4960bis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sctplab/rfc4960bis/issues/28/comments","statuses_url":"https://api.github.com/repos/sctplab/rfc4960bis/statuses/7d8f792d12de301e72ee99d69d009b1160abc0ee","head":{"label":"MaximProshin:issue9-order-of-pba-and-cwnd-adjustment","ref":"issue9-order-of-pba-and-cwnd-adjustment","sha":"7d8f792d12de301e72ee99d69d009b1160abc0ee","user":{"login":"MaximProshin","id":13518722,"avatar_url":"https://avatars.githubusercontent.com/u/13518722?v=3","gravatar_id":"","url":"https://api.github.com/users/MaximProshin","html_url":"https://github.com/MaximProshin","followers_url":"https://api.github.com/users/MaximProshin/followers","following_url":"https://api.github.com/users/MaximProshin/following{/other_user}","gists_url":"https://api.github.com/users/MaximProshin/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximProshin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximProshin/subscriptions","organizations_url":"https://api.github.com/users/MaximProshin/orgs","repos_url":"https://api.github.com/users/MaximProshin/repos","events_url":"https://api.github.com/users/MaximProshin/events{/privacy}","received_events_url":"https://api.github.com/users/MaximProshin/received_events","type":"User","site_admin":false},"repo":{"id":41693211,"name":"rfc4960bis","full_name":"MaximProshin/rfc4960bis","owner":{"login":"MaximProshin","id":13518722,"avatar_url":"https://avatars.githubusercontent.com/u/13518722?v=3","gravatar_id":"","url":"https://api.github.com/users/MaximProshin","html_url":"https://github.com/MaximProshin","followers_url":"https://api.github.com/users/MaximProshin/followers","following_url":"https://api.github.com/users/MaximProshin/following{/other_user}","gists_url":"https://api.github.com/users/MaximProshin/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximProshin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximProshin/subscriptions","organizations_url":"https://api.github.com/users/MaximProshin/orgs","repos_url":"https://api.github.com/users/MaximProshin/repos","events_url":"https://api.github.com/users/MaximProshin/events{/privacy}","received_events_url":"https://api.github.com/users/MaximProshin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MaximProshin/rfc4960bis","description":"Contains stuff the RFC4960bis","fork":true,"url":"https://api.github.com/repos/MaximProshin/rfc4960bis","forks_url":"https://api.github.com/repos/MaximProshin/rfc4960bis/forks","keys_url":"https://api.github.com/repos/MaximProshin/rfc4960bis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MaximProshin/rfc4960bis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MaximProshin/rfc4960bis/teams","hooks_url":"https://api.github.com/repos/MaximProshin/rfc4960bis/hooks","issue_events_url":"https://api.github.com/repos/MaximProshin/rfc4960bis/issues/events{/number}","events_url":"https://api.github.com/repos/MaximProshin/rfc4960bis/events","assignees_url":"https://api.github.com/repos/MaximProshin/rfc4960bis/assignees{/user}","branches_url":"https://api.github.com/repos/MaximProshin/rfc4960bis/branches{/branch}","tags_url":"https://api.github.com/repos/MaximProshin/rfc4960bis/tags","blobs_url":"https://api.github.com/repos/MaximProshin/rfc4960bis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MaximProshin/rfc4960bis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MaximProshin/rfc4960bis/git/refs{/sha}","trees_url":"https://api.github.com/repos/MaximProshin/rfc4960bis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MaximProshin/rfc4960bis/statuses/{sha}","languages_url":"https://api.github.com/repos/MaximProshin/rfc4960bis/languages","stargazers_url":"https://api.github.com/repos/MaximProshin/rfc4960bis/stargazers","contributors_url":"https://api.github.com/repos/MaximProshin/rfc4960bis/contributors","subscribers_url":"https://api.github.com/repos/MaximProshin/rfc4960bis/subscribers","subscription_url":"https://api.github.com/repos/MaximProshin/rfc4960bis/subscription","commits_url":"https://api.github.com/repos/MaximProshin/rfc4960bis/commits{/sha}","git_commits_url":"https://api.github.com/repos/MaximProshin/rfc4960bis/git/commits{/sha}","comments_url":"https://api.github.com/repos/MaximProshin/rfc4960bis/comments{/number}","issue_comment_url":"https://api.github.com/repos/MaximProshin/rfc4960bis/issues/comments{/number}","contents_url":"https://api.github.com/repos/MaximProshin/rfc4960bis/contents/{+path}","compare_url":"https://api.github.com/repos/MaximProshin/rfc4960bis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MaximProshin/rfc4960bis/merges","archive_url":"https://api.github.com/repos/MaximProshin/rfc4960bis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MaximProshin/rfc4960bis/downloads","issues_url":"https://api.github.com/repos/MaximProshin/rfc4960bis/issues{/number}","pulls_url":"https://api.github.com/repos/MaximProshin/rfc4960bis/pulls{/number}","milestones_url":"https://api.github.com/repos/MaximProshin/rfc4960bis/milestones{/number}","notifications_url":"https://api.github.com/repos/MaximProshin/rfc4960bis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MaximProshin/rfc4960bis/labels{/name}","releases_url":"https://api.github.com/repos/MaximProshin/rfc4960bis/releases{/id}","created_at":"2015-08-31T18:32:27Z","updated_at":"2015-07-27T09:14:42Z","pushed_at":"2015-09-30T14:54:35Z","git_url":"git://github.com/MaximProshin/rfc4960bis.git","ssh_url":"git@github.com:MaximProshin/rfc4960bis.git","clone_url":"https://github.com/MaximProshin/rfc4960bis.git","svn_url":"https://github.com/MaximProshin/rfc4960bis","homepage":"","size":94,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sctplab:master","ref":"master","sha":"45a7b054f0679e68b0feb593719796f95878aaca","user":{"login":"sctplab","id":13391169,"avatar_url":"https://avatars.githubusercontent.com/u/13391169?v=3","gravatar_id":"","url":"https://api.github.com/users/sctplab","html_url":"https://github.com/sctplab","followers_url":"https://api.github.com/users/sctplab/followers","following_url":"https://api.github.com/users/sctplab/following{/other_user}","gists_url":"https://api.github.com/users/sctplab/gists{/gist_id}","starred_url":"https://api.github.com/users/sctplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sctplab/subscriptions","organizations_url":"https://api.github.com/users/sctplab/orgs","repos_url":"https://api.github.com/users/sctplab/repos","events_url":"https://api.github.com/users/sctplab/events{/privacy}","received_events_url":"https://api.github.com/users/sctplab/received_events","type":"Organization","site_admin":false},"repo":{"id":39290569,"name":"rfc4960bis","full_name":"sctplab/rfc4960bis","owner":{"login":"sctplab","id":13391169,"avatar_url":"https://avatars.githubusercontent.com/u/13391169?v=3","gravatar_id":"","url":"https://api.github.com/users/sctplab","html_url":"https://github.com/sctplab","followers_url":"https://api.github.com/users/sctplab/followers","following_url":"https://api.github.com/users/sctplab/following{/other_user}","gists_url":"https://api.github.com/users/sctplab/gists{/gist_id}","starred_url":"https://api.github.com/users/sctplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sctplab/subscriptions","organizations_url":"https://api.github.com/users/sctplab/orgs","repos_url":"https://api.github.com/users/sctplab/repos","events_url":"https://api.github.com/users/sctplab/events{/privacy}","received_events_url":"https://api.github.com/users/sctplab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sctplab/rfc4960bis","description":"Contains stuff the RFC4960bis","fork":false,"url":"https://api.github.com/repos/sctplab/rfc4960bis","forks_url":"https://api.github.com/repos/sctplab/rfc4960bis/forks","keys_url":"https://api.github.com/repos/sctplab/rfc4960bis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sctplab/rfc4960bis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sctplab/rfc4960bis/teams","hooks_url":"https://api.github.com/repos/sctplab/rfc4960bis/hooks","issue_events_url":"https://api.github.com/repos/sctplab/rfc4960bis/issues/events{/number}","events_url":"https://api.github.com/repos/sctplab/rfc4960bis/events","assignees_url":"https://api.github.com/repos/sctplab/rfc4960bis/assignees{/user}","branches_url":"https://api.github.com/repos/sctplab/rfc4960bis/branches{/branch}","tags_url":"https://api.github.com/repos/sctplab/rfc4960bis/tags","blobs_url":"https://api.github.com/repos/sctplab/rfc4960bis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sctplab/rfc4960bis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sctplab/rfc4960bis/git/refs{/sha}","trees_url":"https://api.github.com/repos/sctplab/rfc4960bis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sctplab/rfc4960bis/statuses/{sha}","languages_url":"https://api.github.com/repos/sctplab/rfc4960bis/languages","stargazers_url":"https://api.github.com/repos/sctplab/rfc4960bis/stargazers","contributors_url":"https://api.github.com/repos/sctplab/rfc4960bis/contributors","subscribers_url":"https://api.github.com/repos/sctplab/rfc4960bis/subscribers","subscription_url":"https://api.github.com/repos/sctplab/rfc4960bis/subscription","commits_url":"https://api.github.com/repos/sctplab/rfc4960bis/commits{/sha}","git_commits_url":"https://api.github.com/repos/sctplab/rfc4960bis/git/commits{/sha}","comments_url":"https://api.github.com/repos/sctplab/rfc4960bis/comments{/number}","issue_comment_url":"https://api.github.com/repos/sctplab/rfc4960bis/issues/comments{/number}","contents_url":"https://api.github.com/repos/sctplab/rfc4960bis/contents/{+path}","compare_url":"https://api.github.com/repos/sctplab/rfc4960bis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sctplab/rfc4960bis/merges","archive_url":"https://api.github.com/repos/sctplab/rfc4960bis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sctplab/rfc4960bis/downloads","issues_url":"https://api.github.com/repos/sctplab/rfc4960bis/issues{/number}","pulls_url":"https://api.github.com/repos/sctplab/rfc4960bis/pulls{/number}","milestones_url":"https://api.github.com/repos/sctplab/rfc4960bis/milestones{/number}","notifications_url":"https://api.github.com/repos/sctplab/rfc4960bis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sctplab/rfc4960bis/labels{/name}","releases_url":"https://api.github.com/repos/sctplab/rfc4960bis/releases{/id}","created_at":"2015-07-18T07:31:27Z","updated_at":"2015-07-27T09:14:42Z","pushed_at":"2015-09-30T14:59:16Z","git_url":"git://github.com/sctplab/rfc4960bis.git","ssh_url":"git@github.com:sctplab/rfc4960bis.git","clone_url":"https://github.com/sctplab/rfc4960bis.git","svn_url":"https://github.com/sctplab/rfc4960bis","homepage":"","size":144,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":26,"forks":1,"open_issues":26,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sctplab/rfc4960bis/pulls/28"},"html":{"href":"https://github.com/sctplab/rfc4960bis/pull/28"},"issue":{"href":"https://api.github.com/repos/sctplab/rfc4960bis/issues/28"},"comments":{"href":"https://api.github.com/repos/sctplab/rfc4960bis/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/sctplab/rfc4960bis/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/sctplab/rfc4960bis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sctplab/rfc4960bis/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/sctplab/rfc4960bis/statuses/7d8f792d12de301e72ee99d69d009b1160abc0ee"}}}}