{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/30759713","id":30759713,"diff_hunk":"@@ -63,6 +63,9 @@ public function block($messages, $type = null, $style = null, $prefix = ' ', $pa\n         $messages = array_values((array) $messages);","path":"src/Symfony/Component/Console/Style/SymfonyStyle.php","position":1,"original_position":1,"commit_id":"098fdd99f89eeaca96f6a28c977b5ed7bd247e3c","original_commit_id":"098fdd99f89eeaca96f6a28c977b5ed7bd247e3c","user":{"login":"nicolas-grekas","id":243674,"avatar_url":"https://avatars.githubusercontent.com/u/243674?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"body":"I suggest replacing this strange code and the patch below with:\r\n`$messages = is_array($messages) ? array_values($messages) : array($messages);`\r\n","created_at":"2015-05-20T23:17:41Z","updated_at":"2015-05-20T23:17:41Z","html_url":"https://github.com/symfony/symfony/pull/14654#discussion_r30759713","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/14654","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/30759713"},"html":{"href":"https://github.com/symfony/symfony/pull/14654#discussion_r30759713"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/14654"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/14654","id":35568668,"html_url":"https://github.com/symfony/symfony/pull/14654","diff_url":"https://github.com/symfony/symfony/pull/14654.diff","patch_url":"https://github.com/symfony/symfony/pull/14654.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/14654","number":14654,"state":"open","locked":false,"title":"[Console] SymfonyStyle : fix blocks failed when $messages is null","user":{"login":"ogizanagi","id":2211145,"avatar_url":"https://avatars.githubusercontent.com/u/2211145?v=3","gravatar_id":"","url":"https://api.github.com/users/ogizanagi","html_url":"https://github.com/ogizanagi","followers_url":"https://api.github.com/users/ogizanagi/followers","following_url":"https://api.github.com/users/ogizanagi/following{/other_user}","gists_url":"https://api.github.com/users/ogizanagi/gists{/gist_id}","starred_url":"https://api.github.com/users/ogizanagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogizanagi/subscriptions","organizations_url":"https://api.github.com/users/ogizanagi/orgs","repos_url":"https://api.github.com/users/ogizanagi/repos","events_url":"https://api.github.com/users/ogizanagi/events{/privacy}","received_events_url":"https://api.github.com/users/ogizanagi/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | yes\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | -\r\n| License       | MIT\r\n| Doc PR        | -\r\n\r\nUsing `SymfonyStyle:block` method with `null` as first argument failed, where most of other methods accepting both string and array arguments will simply output an empty string.\r\n\r\nAt first I wanted to output nothing, or even throw a proper exception. But then I realized how behaves other methods like text or write.\r\n\r\nI encountered this issue while executing a console application, in non-interactive mode, that asks questions (without default value) and prints the result immediately using a note block:\r\n```php\r\n$output->note($output->choice('Choice question', array('choice 1', 'choice 2'));\r\n```\r\n![screenshot 2015-05-16 a 11 42 47](https://cloud.githubusercontent.com/assets/2211145/7665616/ba5f343c-fbc0-11e4-811d-6b109aaa8d27.PNG)\r\n","created_at":"2015-05-16T09:45:37Z","updated_at":"2015-05-20T23:17:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a0131b2023ade6c94a803ac92d58f060e60b768","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/14654/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/14654/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/14654/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/098fdd99f89eeaca96f6a28c977b5ed7bd247e3c","head":{"label":"ogizanagi:sf_style_blocks_null_value","ref":"sf_style_blocks_null_value","sha":"098fdd99f89eeaca96f6a28c977b5ed7bd247e3c","user":{"login":"ogizanagi","id":2211145,"avatar_url":"https://avatars.githubusercontent.com/u/2211145?v=3","gravatar_id":"","url":"https://api.github.com/users/ogizanagi","html_url":"https://github.com/ogizanagi","followers_url":"https://api.github.com/users/ogizanagi/followers","following_url":"https://api.github.com/users/ogizanagi/following{/other_user}","gists_url":"https://api.github.com/users/ogizanagi/gists{/gist_id}","starred_url":"https://api.github.com/users/ogizanagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogizanagi/subscriptions","organizations_url":"https://api.github.com/users/ogizanagi/orgs","repos_url":"https://api.github.com/users/ogizanagi/repos","events_url":"https://api.github.com/users/ogizanagi/events{/privacy}","received_events_url":"https://api.github.com/users/ogizanagi/received_events","type":"User","site_admin":false},"repo":{"id":13498527,"name":"symfony","full_name":"ogizanagi/symfony","owner":{"login":"ogizanagi","id":2211145,"avatar_url":"https://avatars.githubusercontent.com/u/2211145?v=3","gravatar_id":"","url":"https://api.github.com/users/ogizanagi","html_url":"https://github.com/ogizanagi","followers_url":"https://api.github.com/users/ogizanagi/followers","following_url":"https://api.github.com/users/ogizanagi/following{/other_user}","gists_url":"https://api.github.com/users/ogizanagi/gists{/gist_id}","starred_url":"https://api.github.com/users/ogizanagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogizanagi/subscriptions","organizations_url":"https://api.github.com/users/ogizanagi/orgs","repos_url":"https://api.github.com/users/ogizanagi/repos","events_url":"https://api.github.com/users/ogizanagi/events{/privacy}","received_events_url":"https://api.github.com/users/ogizanagi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ogizanagi/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/ogizanagi/symfony","forks_url":"https://api.github.com/repos/ogizanagi/symfony/forks","keys_url":"https://api.github.com/repos/ogizanagi/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ogizanagi/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ogizanagi/symfony/teams","hooks_url":"https://api.github.com/repos/ogizanagi/symfony/hooks","issue_events_url":"https://api.github.com/repos/ogizanagi/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/ogizanagi/symfony/events","assignees_url":"https://api.github.com/repos/ogizanagi/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/ogizanagi/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/ogizanagi/symfony/tags","blobs_url":"https://api.github.com/repos/ogizanagi/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ogizanagi/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ogizanagi/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/ogizanagi/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ogizanagi/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/ogizanagi/symfony/languages","stargazers_url":"https://api.github.com/repos/ogizanagi/symfony/stargazers","contributors_url":"https://api.github.com/repos/ogizanagi/symfony/contributors","subscribers_url":"https://api.github.com/repos/ogizanagi/symfony/subscribers","subscription_url":"https://api.github.com/repos/ogizanagi/symfony/subscription","commits_url":"https://api.github.com/repos/ogizanagi/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/ogizanagi/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/ogizanagi/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/ogizanagi/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/ogizanagi/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/ogizanagi/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ogizanagi/symfony/merges","archive_url":"https://api.github.com/repos/ogizanagi/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ogizanagi/symfony/downloads","issues_url":"https://api.github.com/repos/ogizanagi/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/ogizanagi/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/ogizanagi/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/ogizanagi/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ogizanagi/symfony/labels{/name}","releases_url":"https://api.github.com/repos/ogizanagi/symfony/releases{/id}","created_at":"2013-10-11T12:37:26Z","updated_at":"2014-03-11T15:28:37Z","pushed_at":"2015-05-20T08:27:10Z","git_url":"git://github.com/ogizanagi/symfony.git","ssh_url":"git@github.com:ogizanagi/symfony.git","clone_url":"https://github.com/ogizanagi/symfony.git","svn_url":"https://github.com/ogizanagi/symfony","homepage":"symfony.com","size":56358,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"ticket_9272"}},"base":{"label":"symfony:2.7","ref":"2.7","sha":"abd9b72fbba2aa8108a1d6f5646e99690e932685","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","created_at":"2010-01-04T14:21:21Z","updated_at":"2015-05-20T21:53:56Z","pushed_at":"2015-05-20T20:40:04Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":341313,"stargazers_count":10199,"watchers_count":10199,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4035,"mirror_url":null,"open_issues_count":820,"forks":4035,"open_issues":820,"watchers":10199,"default_branch":"2.7"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/14654"},"html":{"href":"https://github.com/symfony/symfony/pull/14654"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/14654"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/14654/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/14654/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/14654/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/098fdd99f89eeaca96f6a28c977b5ed7bd247e3c"}}}}