{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/36366017","id":36366017,"diff_hunk":"@@ -86,6 +89,14 @@ func (daemon *Daemon) getInspectData(container *Container) (*types.ContainerJSON\n \treturn contJSONBase, nil\n }\n \n+// ContainerExecInspect returns low-level information about the exec\n+// command. An error is returned if the exec cannot be found.\n+//\n+// golnit complains exported method ContainerExecInspect returns\n+// unexported type *daemon.execConfig, which can be annoying to use\n+//\n+// not sure what to do about the return value, perhaps we should\n+// export execConfig","path":"daemon/inspect.go","position":39,"original_position":39,"commit_id":"ef22f252f96e73159dce8f0006dd069aa7ec0112","original_commit_id":"ef22f252f96e73159dce8f0006dd069aa7ec0112","user":{"login":"aaronlehmann","id":10601430,"avatar_url":"https://avatars.githubusercontent.com/u/10601430?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronlehmann","html_url":"https://github.com/aaronlehmann","followers_url":"https://api.github.com/users/aaronlehmann/followers","following_url":"https://api.github.com/users/aaronlehmann/following{/other_user}","gists_url":"https://api.github.com/users/aaronlehmann/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronlehmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronlehmann/subscriptions","organizations_url":"https://api.github.com/users/aaronlehmann/orgs","repos_url":"https://api.github.com/users/aaronlehmann/repos","events_url":"https://api.github.com/users/aaronlehmann/events{/privacy}","received_events_url":"https://api.github.com/users/aaronlehmann/received_events","type":"User","site_admin":false},"body":"Pleaes export execConfig. Since it's returned by an exported function, the type should also be exported.","created_at":"2015-08-05T23:12:55Z","updated_at":"2015-08-05T23:12:55Z","html_url":"https://github.com/docker/docker/pull/15310#discussion_r36366017","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/15310","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/36366017"},"html":{"href":"https://github.com/docker/docker/pull/15310#discussion_r36366017"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/15310"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/15310","id":41626261,"html_url":"https://github.com/docker/docker/pull/15310","diff_url":"https://github.com/docker/docker/pull/15310.diff","patch_url":"https://github.com/docker/docker/pull/15310.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/15310","number":15310,"state":"open","locked":false,"title":"golint fixes for daemon/ package","user":{"login":"MHBauer","id":13337345,"avatar_url":"https://avatars.githubusercontent.com/u/13337345?v=3","gravatar_id":"","url":"https://api.github.com/users/MHBauer","html_url":"https://github.com/MHBauer","followers_url":"https://api.github.com/users/MHBauer/followers","following_url":"https://api.github.com/users/MHBauer/following{/other_user}","gists_url":"https://api.github.com/users/MHBauer/gists{/gist_id}","starred_url":"https://api.github.com/users/MHBauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MHBauer/subscriptions","organizations_url":"https://api.github.com/users/MHBauer/orgs","repos_url":"https://api.github.com/users/MHBauer/repos","events_url":"https://api.github.com/users/MHBauer/events{/privacy}","received_events_url":"https://api.github.com/users/MHBauer/received_events","type":"User","site_admin":false},"body":"One linter advice yet:\r\n`daemon/inspect.go:100:56: exported method ContainerExecInspect returns unexported type *daemon.execConfig, which can be annoying to use`\r\nSuggestions for addressing it?\r\n\r\nThere are a surprising (to me) amount of things that became non-exported.\r\n\r\nThere some comments with \"perhaps\" in them that  I was not sure if I should take action on.\r\n\r\nThere are some renames with *Locking because all the functions did was add locking around an existing unexported function.\r\n\r\nSome of the comments need work as to the exact details.\r\n\r\nA partial history of individual commits can be found in my forked repo in the \"split-commits\" branch.\r\n\r\nfor #14756","created_at":"2015-08-04T22:42:26Z","updated_at":"2015-08-05T23:12:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"145591c3e59eaacd487246225b20e797dcfed71f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/15310/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/15310/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/15310/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/ef22f252f96e73159dce8f0006dd069aa7ec0112","head":{"label":"MHBauer:demon-lint-squash","ref":"demon-lint-squash","sha":"ef22f252f96e73159dce8f0006dd069aa7ec0112","user":{"login":"MHBauer","id":13337345,"avatar_url":"https://avatars.githubusercontent.com/u/13337345?v=3","gravatar_id":"","url":"https://api.github.com/users/MHBauer","html_url":"https://github.com/MHBauer","followers_url":"https://api.github.com/users/MHBauer/followers","following_url":"https://api.github.com/users/MHBauer/following{/other_user}","gists_url":"https://api.github.com/users/MHBauer/gists{/gist_id}","starred_url":"https://api.github.com/users/MHBauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MHBauer/subscriptions","organizations_url":"https://api.github.com/users/MHBauer/orgs","repos_url":"https://api.github.com/users/MHBauer/repos","events_url":"https://api.github.com/users/MHBauer/events{/privacy}","received_events_url":"https://api.github.com/users/MHBauer/received_events","type":"User","site_admin":false},"repo":{"id":39091680,"name":"docker","full_name":"MHBauer/docker","owner":{"login":"MHBauer","id":13337345,"avatar_url":"https://avatars.githubusercontent.com/u/13337345?v=3","gravatar_id":"","url":"https://api.github.com/users/MHBauer","html_url":"https://github.com/MHBauer","followers_url":"https://api.github.com/users/MHBauer/followers","following_url":"https://api.github.com/users/MHBauer/following{/other_user}","gists_url":"https://api.github.com/users/MHBauer/gists{/gist_id}","starred_url":"https://api.github.com/users/MHBauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MHBauer/subscriptions","organizations_url":"https://api.github.com/users/MHBauer/orgs","repos_url":"https://api.github.com/users/MHBauer/repos","events_url":"https://api.github.com/users/MHBauer/events{/privacy}","received_events_url":"https://api.github.com/users/MHBauer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MHBauer/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/MHBauer/docker","forks_url":"https://api.github.com/repos/MHBauer/docker/forks","keys_url":"https://api.github.com/repos/MHBauer/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MHBauer/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MHBauer/docker/teams","hooks_url":"https://api.github.com/repos/MHBauer/docker/hooks","issue_events_url":"https://api.github.com/repos/MHBauer/docker/issues/events{/number}","events_url":"https://api.github.com/repos/MHBauer/docker/events","assignees_url":"https://api.github.com/repos/MHBauer/docker/assignees{/user}","branches_url":"https://api.github.com/repos/MHBauer/docker/branches{/branch}","tags_url":"https://api.github.com/repos/MHBauer/docker/tags","blobs_url":"https://api.github.com/repos/MHBauer/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MHBauer/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MHBauer/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/MHBauer/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MHBauer/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/MHBauer/docker/languages","stargazers_url":"https://api.github.com/repos/MHBauer/docker/stargazers","contributors_url":"https://api.github.com/repos/MHBauer/docker/contributors","subscribers_url":"https://api.github.com/repos/MHBauer/docker/subscribers","subscription_url":"https://api.github.com/repos/MHBauer/docker/subscription","commits_url":"https://api.github.com/repos/MHBauer/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/MHBauer/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/MHBauer/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/MHBauer/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/MHBauer/docker/contents/{+path}","compare_url":"https://api.github.com/repos/MHBauer/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MHBauer/docker/merges","archive_url":"https://api.github.com/repos/MHBauer/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MHBauer/docker/downloads","issues_url":"https://api.github.com/repos/MHBauer/docker/issues{/number}","pulls_url":"https://api.github.com/repos/MHBauer/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/MHBauer/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/MHBauer/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MHBauer/docker/labels{/name}","releases_url":"https://api.github.com/repos/MHBauer/docker/releases{/id}","created_at":"2015-07-14T18:02:26Z","updated_at":"2015-07-14T18:02:34Z","pushed_at":"2015-08-05T21:31:52Z","git_url":"git://github.com/MHBauer/docker.git","ssh_url":"git@github.com:MHBauer/docker.git","clone_url":"https://github.com/MHBauer/docker.git","svn_url":"https://github.com/MHBauer/docker","homepage":"http://www.docker.com","size":65101,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"565535073f4ad879bbd15b0af81a70c6e6379501","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-08-05T22:37:15Z","pushed_at":"2015-08-05T22:59:06Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":235991,"stargazers_count":23767,"watchers_count":23767,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6000,"mirror_url":null,"open_issues_count":1051,"forks":6000,"open_issues":1051,"watchers":23767,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/15310"},"html":{"href":"https://github.com/docker/docker/pull/15310"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/15310"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/15310/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/15310/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/15310/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/ef22f252f96e73159dce8f0006dd069aa7ec0112"}}}}