{"action":"created","issue":{"url":"https://api.github.com/repos/Element-Research/rnn/issues/55","labels_url":"https://api.github.com/repos/Element-Research/rnn/issues/55/labels{/name}","comments_url":"https://api.github.com/repos/Element-Research/rnn/issues/55/comments","events_url":"https://api.github.com/repos/Element-Research/rnn/issues/55/events","html_url":"https://github.com/Element-Research/rnn/pull/55","id":117609321,"number":55,"title":"Add example of coupled encoder and decoder","user":{"login":"douwekiela","id":6024930,"avatar_url":"https://avatars.githubusercontent.com/u/6024930?v=3","gravatar_id":"","url":"https://api.github.com/users/douwekiela","html_url":"https://github.com/douwekiela","followers_url":"https://api.github.com/users/douwekiela/followers","following_url":"https://api.github.com/users/douwekiela/following{/other_user}","gists_url":"https://api.github.com/users/douwekiela/gists{/gist_id}","starred_url":"https://api.github.com/users/douwekiela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/douwekiela/subscriptions","organizations_url":"https://api.github.com/users/douwekiela/orgs","repos_url":"https://api.github.com/users/douwekiela/repos","events_url":"https://api.github.com/users/douwekiela/events{/privacy}","received_events_url":"https://api.github.com/users/douwekiela/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-18T15:21:03Z","updated_at":"2015-11-18T20:34:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Element-Research/rnn/pulls/55","html_url":"https://github.com/Element-Research/rnn/pull/55","diff_url":"https://github.com/Element-Research/rnn/pull/55.diff","patch_url":"https://github.com/Element-Research/rnn/pull/55.patch"},"body":"As discussed, here's a PR for the coupled encoder-decoder example.\r\n\r\nI think it would be cleaner if we can modify `LSTM.lua` to store `self.gradCells[step-1]` separately if `step-1 == 0` (https://github.com/Element-Research/rnn/blob/master/LSTM.lua#L255). If you like I can submit a separate PR for that."},"comment":{"url":"https://api.github.com/repos/Element-Research/rnn/issues/comments/157855072","html_url":"https://github.com/Element-Research/rnn/pull/55#issuecomment-157855072","issue_url":"https://api.github.com/repos/Element-Research/rnn/issues/55","id":157855072,"user":{"login":"nicholas-leonard","id":3520613,"avatar_url":"https://avatars.githubusercontent.com/u/3520613?v=3","gravatar_id":"","url":"https://api.github.com/users/nicholas-leonard","html_url":"https://github.com/nicholas-leonard","followers_url":"https://api.github.com/users/nicholas-leonard/followers","following_url":"https://api.github.com/users/nicholas-leonard/following{/other_user}","gists_url":"https://api.github.com/users/nicholas-leonard/gists{/gist_id}","starred_url":"https://api.github.com/users/nicholas-leonard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicholas-leonard/subscriptions","organizations_url":"https://api.github.com/users/nicholas-leonard/orgs","repos_url":"https://api.github.com/users/nicholas-leonard/repos","events_url":"https://api.github.com/users/nicholas-leonard/events{/privacy}","received_events_url":"https://api.github.com/users/nicholas-leonard/received_events","type":"User","site_admin":false},"created_at":"2015-11-18T20:34:48Z","updated_at":"2015-11-18T20:34:48Z","body":"@douwekiela As it is, the commit isn't registered to your github account, which means this commit wouldn't register you among the rnn contributors. To fix this, you should generate ssh keys for your account and clone your fork using the git prefix instead of https. Then submit a new PR.\r\n\r\nOtherwise, yeah you could save the earliest gradCells separately. You could include that change in this PR."}}