{"action":"closed","number":938,"pull_request":{"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/938","id":47459267,"html_url":"https://github.com/WikiWatershed/model-my-watershed/pull/938","diff_url":"https://github.com/WikiWatershed/model-my-watershed/pull/938.diff","patch_url":"https://github.com/WikiWatershed/model-my-watershed/pull/938.patch","issue_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/938","number":938,"state":"closed","locked":false,"title":"Fix sliders in Internet Explorer","user":{"login":"rajadain","id":1430060,"avatar_url":"https://avatars.githubusercontent.com/u/1430060?v=3","gravatar_id":"","url":"https://api.github.com/users/rajadain","html_url":"https://github.com/rajadain","followers_url":"https://api.github.com/users/rajadain/followers","following_url":"https://api.github.com/users/rajadain/following{/other_user}","gists_url":"https://api.github.com/users/rajadain/gists{/gist_id}","starred_url":"https://api.github.com/users/rajadain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajadain/subscriptions","organizations_url":"https://api.github.com/users/rajadain/orgs","repos_url":"https://api.github.com/users/rajadain/repos","events_url":"https://api.github.com/users/rajadain/events{/privacy}","received_events_url":"https://api.github.com/users/rajadain/received_events","type":"User","site_admin":false},"body":"## Overview\r\n\r\nThe invisibility of the sliders in Internet Explorer was caused by its inability to automatically determine their width. By giving them, or their containers, explicit widths, we ensure that the sliders are always visible.\r\n\r\nIn addition, their behavior was different because IE doesn't trigger `input` event when the slider is being dragged, but instead triggers `change` continuously. This is different from Firefox, Chrome and Safari, which trigger `input` when dragging the slider, and `change` when the user stops dragging.\r\n\r\nPreviously we would only update the UI on the `input` event to preview the value selected by the user. Unfortunately, since IE never fires it, the UI would not update even when the user stopped dragging. This edit ensures that the UI is updated with the final value.\r\n\r\nThe actual fetching of the results is debounced, so even though we are firing a lot more `change` events than were originally expected, there are no more network requests and performance is quite consistent.\r\n\r\n## Testing Instructions\r\n\r\nCreate a project, and proceed to the Model view. Test the sliders. Go to the Compare view. Test the sliders.\r\n\r\nTest in IE, but also in other browsers to ensure that the expected behavior hasn't changed.\r\n\r\n## Demo\r\n\r\nChrome 45 on Mac:\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1430060/10436654/d3d3c3d8-70f5-11e5-98bd-6233c812ff68.png)\r\n\r\nSafari 9 on Mac:\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1430060/10436672/e42526e6-70f5-11e5-89a8-6a4edd7d2e3f.png)\r\n\r\nFirefox 41 on Mac:\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1430060/10436689/00812ad8-70f6-11e5-8cda-fe12730a1885.png)\r\n\r\nIE 11 on Windows:\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1430060/10436698/10ea9de6-70f6-11e5-9e8b-03376ea582c5.png)\r\n\r\nFirefox 41 on Windows:\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1430060/10436743/46dbba98-70f6-11e5-8495-70dccfcb8ee0.png)\r\n\r\n## Notes\r\n\r\nI can't get the opacity slider to actually change the opacity of the coverage layer in either IE or Firefox. These observations should probably be made into a new issue.\r\n\r\nConnects #913 ","created_at":"2015-10-12T20:10:10Z","updated_at":"2015-10-13T14:48:14Z","closed_at":"2015-10-13T14:48:14Z","merged_at":"2015-10-13T14:48:13Z","merge_commit_sha":"924de965411286e30e1b7c8e5cf1e206ee0d6d33","assignee":{"login":"rajadain","id":1430060,"avatar_url":"https://avatars.githubusercontent.com/u/1430060?v=3","gravatar_id":"","url":"https://api.github.com/users/rajadain","html_url":"https://github.com/rajadain","followers_url":"https://api.github.com/users/rajadain/followers","following_url":"https://api.github.com/users/rajadain/following{/other_user}","gists_url":"https://api.github.com/users/rajadain/gists{/gist_id}","starred_url":"https://api.github.com/users/rajadain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajadain/subscriptions","organizations_url":"https://api.github.com/users/rajadain/orgs","repos_url":"https://api.github.com/users/rajadain/repos","events_url":"https://api.github.com/users/rajadain/events{/privacy}","received_events_url":"https://api.github.com/users/rajadain/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/938/commits","review_comments_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/938/comments","review_comment_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/938/comments","statuses_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/statuses/456bc10de490fe6cb252038c5491c7de9b043de6","head":{"label":"rajadain:bug/ie-sliders","ref":"bug/ie-sliders","sha":"456bc10de490fe6cb252038c5491c7de9b043de6","user":{"login":"rajadain","id":1430060,"avatar_url":"https://avatars.githubusercontent.com/u/1430060?v=3","gravatar_id":"","url":"https://api.github.com/users/rajadain","html_url":"https://github.com/rajadain","followers_url":"https://api.github.com/users/rajadain/followers","following_url":"https://api.github.com/users/rajadain/following{/other_user}","gists_url":"https://api.github.com/users/rajadain/gists{/gist_id}","starred_url":"https://api.github.com/users/rajadain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajadain/subscriptions","organizations_url":"https://api.github.com/users/rajadain/orgs","repos_url":"https://api.github.com/users/rajadain/repos","events_url":"https://api.github.com/users/rajadain/events{/privacy}","received_events_url":"https://api.github.com/users/rajadain/received_events","type":"User","site_admin":false},"repo":{"id":36075102,"name":"model-my-watershed","full_name":"rajadain/model-my-watershed","owner":{"login":"rajadain","id":1430060,"avatar_url":"https://avatars.githubusercontent.com/u/1430060?v=3","gravatar_id":"","url":"https://api.github.com/users/rajadain","html_url":"https://github.com/rajadain","followers_url":"https://api.github.com/users/rajadain/followers","following_url":"https://api.github.com/users/rajadain/following{/other_user}","gists_url":"https://api.github.com/users/rajadain/gists{/gist_id}","starred_url":"https://api.github.com/users/rajadain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajadain/subscriptions","organizations_url":"https://api.github.com/users/rajadain/orgs","repos_url":"https://api.github.com/users/rajadain/repos","events_url":"https://api.github.com/users/rajadain/events{/privacy}","received_events_url":"https://api.github.com/users/rajadain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rajadain/model-my-watershed","description":"The web application front end for Model My Watershed.","fork":true,"url":"https://api.github.com/repos/rajadain/model-my-watershed","forks_url":"https://api.github.com/repos/rajadain/model-my-watershed/forks","keys_url":"https://api.github.com/repos/rajadain/model-my-watershed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rajadain/model-my-watershed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rajadain/model-my-watershed/teams","hooks_url":"https://api.github.com/repos/rajadain/model-my-watershed/hooks","issue_events_url":"https://api.github.com/repos/rajadain/model-my-watershed/issues/events{/number}","events_url":"https://api.github.com/repos/rajadain/model-my-watershed/events","assignees_url":"https://api.github.com/repos/rajadain/model-my-watershed/assignees{/user}","branches_url":"https://api.github.com/repos/rajadain/model-my-watershed/branches{/branch}","tags_url":"https://api.github.com/repos/rajadain/model-my-watershed/tags","blobs_url":"https://api.github.com/repos/rajadain/model-my-watershed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rajadain/model-my-watershed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rajadain/model-my-watershed/git/refs{/sha}","trees_url":"https://api.github.com/repos/rajadain/model-my-watershed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rajadain/model-my-watershed/statuses/{sha}","languages_url":"https://api.github.com/repos/rajadain/model-my-watershed/languages","stargazers_url":"https://api.github.com/repos/rajadain/model-my-watershed/stargazers","contributors_url":"https://api.github.com/repos/rajadain/model-my-watershed/contributors","subscribers_url":"https://api.github.com/repos/rajadain/model-my-watershed/subscribers","subscription_url":"https://api.github.com/repos/rajadain/model-my-watershed/subscription","commits_url":"https://api.github.com/repos/rajadain/model-my-watershed/commits{/sha}","git_commits_url":"https://api.github.com/repos/rajadain/model-my-watershed/git/commits{/sha}","comments_url":"https://api.github.com/repos/rajadain/model-my-watershed/comments{/number}","issue_comment_url":"https://api.github.com/repos/rajadain/model-my-watershed/issues/comments{/number}","contents_url":"https://api.github.com/repos/rajadain/model-my-watershed/contents/{+path}","compare_url":"https://api.github.com/repos/rajadain/model-my-watershed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rajadain/model-my-watershed/merges","archive_url":"https://api.github.com/repos/rajadain/model-my-watershed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rajadain/model-my-watershed/downloads","issues_url":"https://api.github.com/repos/rajadain/model-my-watershed/issues{/number}","pulls_url":"https://api.github.com/repos/rajadain/model-my-watershed/pulls{/number}","milestones_url":"https://api.github.com/repos/rajadain/model-my-watershed/milestones{/number}","notifications_url":"https://api.github.com/repos/rajadain/model-my-watershed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rajadain/model-my-watershed/labels{/name}","releases_url":"https://api.github.com/repos/rajadain/model-my-watershed/releases{/id}","created_at":"2015-05-22T13:58:22Z","updated_at":"2015-06-11T19:30:05Z","pushed_at":"2015-10-12T22:02:30Z","git_url":"git://github.com/rajadain/model-my-watershed.git","ssh_url":"git@github.com:rajadain/model-my-watershed.git","clone_url":"https://github.com/rajadain/model-my-watershed.git","svn_url":"https://github.com/rajadain/model-my-watershed","homepage":null,"size":16528,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"WikiWatershed:develop","ref":"develop","sha":"13ff68067f9c44c250ac85592bef5fe0d56d7525","user":{"login":"WikiWatershed","id":8520008,"avatar_url":"https://avatars.githubusercontent.com/u/8520008?v=3","gravatar_id":"","url":"https://api.github.com/users/WikiWatershed","html_url":"https://github.com/WikiWatershed","followers_url":"https://api.github.com/users/WikiWatershed/followers","following_url":"https://api.github.com/users/WikiWatershed/following{/other_user}","gists_url":"https://api.github.com/users/WikiWatershed/gists{/gist_id}","starred_url":"https://api.github.com/users/WikiWatershed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WikiWatershed/subscriptions","organizations_url":"https://api.github.com/users/WikiWatershed/orgs","repos_url":"https://api.github.com/users/WikiWatershed/repos","events_url":"https://api.github.com/users/WikiWatershed/events{/privacy}","received_events_url":"https://api.github.com/users/WikiWatershed/received_events","type":"Organization","site_admin":false},"repo":{"id":32742922,"name":"model-my-watershed","full_name":"WikiWatershed/model-my-watershed","owner":{"login":"WikiWatershed","id":8520008,"avatar_url":"https://avatars.githubusercontent.com/u/8520008?v=3","gravatar_id":"","url":"https://api.github.com/users/WikiWatershed","html_url":"https://github.com/WikiWatershed","followers_url":"https://api.github.com/users/WikiWatershed/followers","following_url":"https://api.github.com/users/WikiWatershed/following{/other_user}","gists_url":"https://api.github.com/users/WikiWatershed/gists{/gist_id}","starred_url":"https://api.github.com/users/WikiWatershed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WikiWatershed/subscriptions","organizations_url":"https://api.github.com/users/WikiWatershed/orgs","repos_url":"https://api.github.com/users/WikiWatershed/repos","events_url":"https://api.github.com/users/WikiWatershed/events{/privacy}","received_events_url":"https://api.github.com/users/WikiWatershed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WikiWatershed/model-my-watershed","description":"The web application front end for Model My Watershed.","fork":false,"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed","forks_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/forks","keys_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/teams","hooks_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/hooks","issue_events_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/events{/number}","events_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/events","assignees_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/assignees{/user}","branches_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/branches{/branch}","tags_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/tags","blobs_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/git/refs{/sha}","trees_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/statuses/{sha}","languages_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/languages","stargazers_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/stargazers","contributors_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/contributors","subscribers_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/subscribers","subscription_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/subscription","commits_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/commits{/sha}","git_commits_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/git/commits{/sha}","comments_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/comments{/number}","issue_comment_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/comments{/number}","contents_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/contents/{+path}","compare_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/merges","archive_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/downloads","issues_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues{/number}","pulls_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls{/number}","milestones_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/milestones{/number}","notifications_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/labels{/name}","releases_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/releases{/id}","created_at":"2015-03-23T16:02:55Z","updated_at":"2015-10-11T22:49:42Z","pushed_at":"2015-10-13T14:48:14Z","git_url":"git://github.com/WikiWatershed/model-my-watershed.git","ssh_url":"git@github.com:WikiWatershed/model-my-watershed.git","clone_url":"https://github.com/WikiWatershed/model-my-watershed.git","svn_url":"https://github.com/WikiWatershed/model-my-watershed","homepage":null,"size":19895,"stargazers_count":3,"watchers_count":3,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":134,"forks":12,"open_issues":134,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/938"},"html":{"href":"https://github.com/WikiWatershed/model-my-watershed/pull/938"},"issue":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/938"},"comments":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/938/comments"},"review_comments":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/938/comments"},"review_comment":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/938/commits"},"statuses":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/statuses/456bc10de490fe6cb252038c5491c7de9b043de6"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"rajadain","id":1430060,"avatar_url":"https://avatars.githubusercontent.com/u/1430060?v=3","gravatar_id":"","url":"https://api.github.com/users/rajadain","html_url":"https://github.com/rajadain","followers_url":"https://api.github.com/users/rajadain/followers","following_url":"https://api.github.com/users/rajadain/following{/other_user}","gists_url":"https://api.github.com/users/rajadain/gists{/gist_id}","starred_url":"https://api.github.com/users/rajadain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajadain/subscriptions","organizations_url":"https://api.github.com/users/rajadain/orgs","repos_url":"https://api.github.com/users/rajadain/repos","events_url":"https://api.github.com/users/rajadain/events{/privacy}","received_events_url":"https://api.github.com/users/rajadain/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":2,"additions":11,"deletions":2,"changed_files":4}}