{"action":"created","comment":{"url":"https://api.github.com/repos/akka/akka/pulls/comments/28763978","id":28763978,"diff_hunk":"@@ -127,18 +129,21 @@ class GraphBalanceSpec extends AkkaSpec {\n       val numElementsForSink = 10000\n       val outputs = Sink.fold[Int, Int](0)(_ + _)\n \n-      val (r1, r2, r3) = FlowGraph.closed(outputs, outputs, outputs)(Tuple3.apply) { implicit b ⇒\n+      val results = FlowGraph.closed(outputs, outputs, outputs)(List(_, _, _)) { implicit b ⇒\n         (o1, o2, o3) ⇒\n           val balance = b.add(Balance[Int](3, waitForAllDownstreams = true))\n           Source.repeat(1).take(numElementsForSink * 3) ~> balance.in\n-          balance.out(0) ~> o1.inlet\n-          balance.out(1) ~> o2.inlet\n-          balance.out(2) ~> o3.inlet\n+          balance.out(0) ~> o1\n+          balance.out(1) ~> o2\n+          balance.out(2) ~> o3\n       }.run()\n \n-      Await.result(r1, 3.seconds) should be(numElementsForSink +- 2000)\n-      Await.result(r2, 3.seconds) should be(numElementsForSink +- 2000)\n-      Await.result(r3, 3.seconds) should be(numElementsForSink +- 2000)\n+      import system.dispatcher\n+      val sum = Future.sequence(results).map { res ⇒\n+        res should not contain 0","path":"akka-stream-tests/src/test/scala/akka/stream/scaladsl/GraphBalanceSpec.scala","position":74,"original_position":74,"commit_id":"50fb15f07d701c0309539c4a6f54b3bf8111e37f","original_commit_id":"50fb15f07d701c0309539c4a6f54b3bf8111e37f","user":{"login":"2m","id":422086,"avatar_url":"https://avatars.githubusercontent.com/u/422086?v=3","gravatar_id":"","url":"https://api.github.com/users/2m","html_url":"https://github.com/2m","followers_url":"https://api.github.com/users/2m/followers","following_url":"https://api.github.com/users/2m/following{/other_user}","gists_url":"https://api.github.com/users/2m/gists{/gist_id}","starred_url":"https://api.github.com/users/2m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2m/subscriptions","organizations_url":"https://api.github.com/users/2m/orgs","repos_url":"https://api.github.com/users/2m/repos","events_url":"https://api.github.com/users/2m/events{/privacy}","received_events_url":"https://api.github.com/users/2m/received_events","type":"User","site_admin":false},"body":"> do we think > 0 elements is good enough check to verify \"fairly balance between three outputs\" ?\r\n\r\nI am not sure if any other larger arbitrary number is better, as it increases the chance of this testcase failing.","created_at":"2015-04-21T09:50:49Z","updated_at":"2015-04-21T09:50:49Z","html_url":"https://github.com/akka/akka/pull/17241#discussion_r28763978","pull_request_url":"https://api.github.com/repos/akka/akka/pulls/17241","_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/comments/28763978"},"html":{"href":"https://github.com/akka/akka/pull/17241#discussion_r28763978"},"pull_request":{"href":"https://api.github.com/repos/akka/akka/pulls/17241"}}},"pull_request":{"url":"https://api.github.com/repos/akka/akka/pulls/17241","id":33741313,"html_url":"https://github.com/akka/akka/pull/17241","diff_url":"https://github.com/akka/akka/pull/17241.diff","patch_url":"https://github.com/akka/akka/pull/17241.patch","issue_url":"https://api.github.com/repos/akka/akka/issues/17241","number":17241,"state":"open","locked":false,"title":"=str #17176 do not check for arbitrary conditions that depends on thread scheduling","user":{"login":"2m","id":422086,"avatar_url":"https://avatars.githubusercontent.com/u/422086?v=3","gravatar_id":"","url":"https://api.github.com/users/2m","html_url":"https://github.com/2m","followers_url":"https://api.github.com/users/2m/followers","following_url":"https://api.github.com/users/2m/following{/other_user}","gists_url":"https://api.github.com/users/2m/gists{/gist_id}","starred_url":"https://api.github.com/users/2m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2m/subscriptions","organizations_url":"https://api.github.com/users/2m/orgs","repos_url":"https://api.github.com/users/2m/repos","events_url":"https://api.github.com/users/2m/events{/privacy}","received_events_url":"https://api.github.com/users/2m/received_events","type":"User","site_admin":false},"body":"Checking for at least one landed element across balanced sinks should be enough.\r\n\r\nReferences #17176","created_at":"2015-04-21T09:02:33Z","updated_at":"2015-04-21T09:50:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9375faf9003cb7fc5144721b2904c61c9b9ecd01","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/akka/akka/pulls/17241/commits","review_comments_url":"https://api.github.com/repos/akka/akka/pulls/17241/comments","review_comment_url":"https://api.github.com/repos/akka/akka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akka/akka/issues/17241/comments","statuses_url":"https://api.github.com/repos/akka/akka/statuses/50fb15f07d701c0309539c4a6f54b3bf8111e37f","head":{"label":"2m:wip-graphbalancespec-robustify","ref":"wip-graphbalancespec-robustify","sha":"50fb15f07d701c0309539c4a6f54b3bf8111e37f","user":{"login":"2m","id":422086,"avatar_url":"https://avatars.githubusercontent.com/u/422086?v=3","gravatar_id":"","url":"https://api.github.com/users/2m","html_url":"https://github.com/2m","followers_url":"https://api.github.com/users/2m/followers","following_url":"https://api.github.com/users/2m/following{/other_user}","gists_url":"https://api.github.com/users/2m/gists{/gist_id}","starred_url":"https://api.github.com/users/2m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2m/subscriptions","organizations_url":"https://api.github.com/users/2m/orgs","repos_url":"https://api.github.com/users/2m/repos","events_url":"https://api.github.com/users/2m/events{/privacy}","received_events_url":"https://api.github.com/users/2m/received_events","type":"User","site_admin":false},"repo":{"id":18794399,"name":"akka","full_name":"2m/akka","owner":{"login":"2m","id":422086,"avatar_url":"https://avatars.githubusercontent.com/u/422086?v=3","gravatar_id":"","url":"https://api.github.com/users/2m","html_url":"https://github.com/2m","followers_url":"https://api.github.com/users/2m/followers","following_url":"https://api.github.com/users/2m/following{/other_user}","gists_url":"https://api.github.com/users/2m/gists{/gist_id}","starred_url":"https://api.github.com/users/2m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2m/subscriptions","organizations_url":"https://api.github.com/users/2m/orgs","repos_url":"https://api.github.com/users/2m/repos","events_url":"https://api.github.com/users/2m/events{/privacy}","received_events_url":"https://api.github.com/users/2m/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/2m/akka","description":"Akka Project","fork":true,"url":"https://api.github.com/repos/2m/akka","forks_url":"https://api.github.com/repos/2m/akka/forks","keys_url":"https://api.github.com/repos/2m/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/2m/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/2m/akka/teams","hooks_url":"https://api.github.com/repos/2m/akka/hooks","issue_events_url":"https://api.github.com/repos/2m/akka/issues/events{/number}","events_url":"https://api.github.com/repos/2m/akka/events","assignees_url":"https://api.github.com/repos/2m/akka/assignees{/user}","branches_url":"https://api.github.com/repos/2m/akka/branches{/branch}","tags_url":"https://api.github.com/repos/2m/akka/tags","blobs_url":"https://api.github.com/repos/2m/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/2m/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/2m/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/2m/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/2m/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/2m/akka/languages","stargazers_url":"https://api.github.com/repos/2m/akka/stargazers","contributors_url":"https://api.github.com/repos/2m/akka/contributors","subscribers_url":"https://api.github.com/repos/2m/akka/subscribers","subscription_url":"https://api.github.com/repos/2m/akka/subscription","commits_url":"https://api.github.com/repos/2m/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/2m/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/2m/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/2m/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/2m/akka/contents/{+path}","compare_url":"https://api.github.com/repos/2m/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/2m/akka/merges","archive_url":"https://api.github.com/repos/2m/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/2m/akka/downloads","issues_url":"https://api.github.com/repos/2m/akka/issues{/number}","pulls_url":"https://api.github.com/repos/2m/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/2m/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/2m/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/2m/akka/labels{/name}","releases_url":"https://api.github.com/repos/2m/akka/releases{/id}","created_at":"2014-04-15T09:23:35Z","updated_at":"2015-02-04T11:32:40Z","pushed_at":"2015-04-21T09:01:33Z","git_url":"git://github.com/2m/akka.git","ssh_url":"git@github.com:2m/akka.git","clone_url":"https://github.com/2m/akka.git","svn_url":"https://github.com/2m/akka","homepage":"http://akka.io","size":158656,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"akka:release-2.3-dev","ref":"release-2.3-dev","sha":"7fe9f2e4ad9b5a2f722d6a70957f819566f959aa","user":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":130013,"name":"akka","full_name":"akka/akka","owner":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akka/akka","description":"Akka Project","fork":false,"url":"https://api.github.com/repos/akka/akka","forks_url":"https://api.github.com/repos/akka/akka/forks","keys_url":"https://api.github.com/repos/akka/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka/teams","hooks_url":"https://api.github.com/repos/akka/akka/hooks","issue_events_url":"https://api.github.com/repos/akka/akka/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka/events","assignees_url":"https://api.github.com/repos/akka/akka/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka/tags","blobs_url":"https://api.github.com/repos/akka/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka/languages","stargazers_url":"https://api.github.com/repos/akka/akka/stargazers","contributors_url":"https://api.github.com/repos/akka/akka/contributors","subscribers_url":"https://api.github.com/repos/akka/akka/subscribers","subscription_url":"https://api.github.com/repos/akka/akka/subscription","commits_url":"https://api.github.com/repos/akka/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/akka/akka/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka/merges","archive_url":"https://api.github.com/repos/akka/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka/downloads","issues_url":"https://api.github.com/repos/akka/akka/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka/releases{/id}","created_at":"2009-02-16T12:51:54Z","updated_at":"2015-04-21T09:30:12Z","pushed_at":"2015-04-21T09:46:50Z","git_url":"git://github.com/akka/akka.git","ssh_url":"git@github.com:akka/akka.git","clone_url":"https://github.com/akka/akka.git","svn_url":"https://github.com/akka/akka","homepage":"http://akka.io","size":247114,"stargazers_count":3839,"watchers_count":3839,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1097,"mirror_url":null,"open_issues_count":638,"forks":1097,"open_issues":638,"watchers":3839,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/17241"},"html":{"href":"https://github.com/akka/akka/pull/17241"},"issue":{"href":"https://api.github.com/repos/akka/akka/issues/17241"},"comments":{"href":"https://api.github.com/repos/akka/akka/issues/17241/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/akka/pulls/17241/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/akka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akka/akka/pulls/17241/commits"},"statuses":{"href":"https://api.github.com/repos/akka/akka/statuses/50fb15f07d701c0309539c4a6f54b3bf8111e37f"}}}}