{"action":"opened","number":5,"pull_request":{"url":"https://api.github.com/repos/Voxer/lb_pool/pulls/5","id":27007372,"html_url":"https://github.com/Voxer/lb_pool/pull/5","diff_url":"https://github.com/Voxer/lb_pool/pull/5.diff","patch_url":"https://github.com/Voxer/lb_pool/pull/5.patch","issue_url":"https://api.github.com/repos/Voxer/lb_pool/issues/5","number":5,"state":"open","locked":false,"title":"Pinger makes request to null ping_path if endpoint removed while error p...","user":{"login":"jwolski","id":16902,"avatar_url":"https://avatars.githubusercontent.com/u/16902?v=3","gravatar_id":"","url":"https://api.github.com/users/jwolski","html_url":"https://github.com/jwolski","followers_url":"https://api.github.com/users/jwolski/followers","following_url":"https://api.github.com/users/jwolski/following{/other_user}","gists_url":"https://api.github.com/users/jwolski/gists{/gist_id}","starred_url":"https://api.github.com/users/jwolski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwolski/subscriptions","organizations_url":"https://api.github.com/users/jwolski/orgs","repos_url":"https://api.github.com/users/jwolski/repos","events_url":"https://api.github.com/users/jwolski/events{/privacy}","received_events_url":"https://api.github.com/users/jwolski/received_events","type":"User","site_admin":false},"body":"...ing is in-flight\r\n\r\nThere's a tricky edge case here when `remove_endpoint()` is invoked on the pool while a soon-to-error-out pinger request is in-flight. Removing an endpoint from the pool `close()`s the `PoolEndpoint` and nulls out the `ping_path`. However, in that time, a pinger could have been started. If the pingers request were to error out it'll cause a subsequent `ping()` within the pinger to the root (\"/\") endpoint of your HTTP server. Most of the time this likely goes unnoticed in production environments.\r\n\r\nIt took a bit of weasling to reproduce in a test case, but if you take the new check out of the `make_request()` function, the assertion will fail.","created_at":"2015-01-08T04:44:51Z","updated_at":"2015-01-08T04:44:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Voxer/lb_pool/pulls/5/commits","review_comments_url":"https://api.github.com/repos/Voxer/lb_pool/pulls/5/comments","review_comment_url":"https://api.github.com/repos/Voxer/lb_pool/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Voxer/lb_pool/issues/5/comments","statuses_url":"https://api.github.com/repos/Voxer/lb_pool/statuses/30bde311de302b1247d33973a9231c1f04aee69a","head":{"label":"jwolski:stop-pinger","ref":"stop-pinger","sha":"30bde311de302b1247d33973a9231c1f04aee69a","user":{"login":"jwolski","id":16902,"avatar_url":"https://avatars.githubusercontent.com/u/16902?v=3","gravatar_id":"","url":"https://api.github.com/users/jwolski","html_url":"https://github.com/jwolski","followers_url":"https://api.github.com/users/jwolski/followers","following_url":"https://api.github.com/users/jwolski/following{/other_user}","gists_url":"https://api.github.com/users/jwolski/gists{/gist_id}","starred_url":"https://api.github.com/users/jwolski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwolski/subscriptions","organizations_url":"https://api.github.com/users/jwolski/orgs","repos_url":"https://api.github.com/users/jwolski/repos","events_url":"https://api.github.com/users/jwolski/events{/privacy}","received_events_url":"https://api.github.com/users/jwolski/received_events","type":"User","site_admin":false},"repo":{"id":28946125,"name":"lb_pool","full_name":"jwolski/lb_pool","owner":{"login":"jwolski","id":16902,"avatar_url":"https://avatars.githubusercontent.com/u/16902?v=3","gravatar_id":"","url":"https://api.github.com/users/jwolski","html_url":"https://github.com/jwolski","followers_url":"https://api.github.com/users/jwolski/followers","following_url":"https://api.github.com/users/jwolski/following{/other_user}","gists_url":"https://api.github.com/users/jwolski/gists{/gist_id}","starred_url":"https://api.github.com/users/jwolski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwolski/subscriptions","organizations_url":"https://api.github.com/users/jwolski/orgs","repos_url":"https://api.github.com/users/jwolski/repos","events_url":"https://api.github.com/users/jwolski/events{/privacy}","received_events_url":"https://api.github.com/users/jwolski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jwolski/lb_pool","description":"HTTP client load balancer with retries","fork":true,"url":"https://api.github.com/repos/jwolski/lb_pool","forks_url":"https://api.github.com/repos/jwolski/lb_pool/forks","keys_url":"https://api.github.com/repos/jwolski/lb_pool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jwolski/lb_pool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jwolski/lb_pool/teams","hooks_url":"https://api.github.com/repos/jwolski/lb_pool/hooks","issue_events_url":"https://api.github.com/repos/jwolski/lb_pool/issues/events{/number}","events_url":"https://api.github.com/repos/jwolski/lb_pool/events","assignees_url":"https://api.github.com/repos/jwolski/lb_pool/assignees{/user}","branches_url":"https://api.github.com/repos/jwolski/lb_pool/branches{/branch}","tags_url":"https://api.github.com/repos/jwolski/lb_pool/tags","blobs_url":"https://api.github.com/repos/jwolski/lb_pool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jwolski/lb_pool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jwolski/lb_pool/git/refs{/sha}","trees_url":"https://api.github.com/repos/jwolski/lb_pool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jwolski/lb_pool/statuses/{sha}","languages_url":"https://api.github.com/repos/jwolski/lb_pool/languages","stargazers_url":"https://api.github.com/repos/jwolski/lb_pool/stargazers","contributors_url":"https://api.github.com/repos/jwolski/lb_pool/contributors","subscribers_url":"https://api.github.com/repos/jwolski/lb_pool/subscribers","subscription_url":"https://api.github.com/repos/jwolski/lb_pool/subscription","commits_url":"https://api.github.com/repos/jwolski/lb_pool/commits{/sha}","git_commits_url":"https://api.github.com/repos/jwolski/lb_pool/git/commits{/sha}","comments_url":"https://api.github.com/repos/jwolski/lb_pool/comments{/number}","issue_comment_url":"https://api.github.com/repos/jwolski/lb_pool/issues/comments/{number}","contents_url":"https://api.github.com/repos/jwolski/lb_pool/contents/{+path}","compare_url":"https://api.github.com/repos/jwolski/lb_pool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jwolski/lb_pool/merges","archive_url":"https://api.github.com/repos/jwolski/lb_pool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jwolski/lb_pool/downloads","issues_url":"https://api.github.com/repos/jwolski/lb_pool/issues{/number}","pulls_url":"https://api.github.com/repos/jwolski/lb_pool/pulls{/number}","milestones_url":"https://api.github.com/repos/jwolski/lb_pool/milestones{/number}","notifications_url":"https://api.github.com/repos/jwolski/lb_pool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jwolski/lb_pool/labels{/name}","releases_url":"https://api.github.com/repos/jwolski/lb_pool/releases{/id}","created_at":"2015-01-08T03:05:42Z","updated_at":"2015-01-08T03:05:43Z","pushed_at":"2015-01-08T04:38:16Z","git_url":"git://github.com/jwolski/lb_pool.git","ssh_url":"git@github.com:jwolski/lb_pool.git","clone_url":"https://github.com/jwolski/lb_pool.git","svn_url":"https://github.com/jwolski/lb_pool","homepage":null,"size":227,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Voxer:master","ref":"master","sha":"b126cf3e247acbf9324dc854db5107f462ea38fc","user":{"login":"Voxer","id":1320338,"avatar_url":"https://avatars.githubusercontent.com/u/1320338?v=3","gravatar_id":"","url":"https://api.github.com/users/Voxer","html_url":"https://github.com/Voxer","followers_url":"https://api.github.com/users/Voxer/followers","following_url":"https://api.github.com/users/Voxer/following{/other_user}","gists_url":"https://api.github.com/users/Voxer/gists{/gist_id}","starred_url":"https://api.github.com/users/Voxer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Voxer/subscriptions","organizations_url":"https://api.github.com/users/Voxer/orgs","repos_url":"https://api.github.com/users/Voxer/repos","events_url":"https://api.github.com/users/Voxer/events{/privacy}","received_events_url":"https://api.github.com/users/Voxer/received_events","type":"Organization","site_admin":false},"repo":{"id":13332691,"name":"lb_pool","full_name":"Voxer/lb_pool","owner":{"login":"Voxer","id":1320338,"avatar_url":"https://avatars.githubusercontent.com/u/1320338?v=3","gravatar_id":"","url":"https://api.github.com/users/Voxer","html_url":"https://github.com/Voxer","followers_url":"https://api.github.com/users/Voxer/followers","following_url":"https://api.github.com/users/Voxer/following{/other_user}","gists_url":"https://api.github.com/users/Voxer/gists{/gist_id}","starred_url":"https://api.github.com/users/Voxer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Voxer/subscriptions","organizations_url":"https://api.github.com/users/Voxer/orgs","repos_url":"https://api.github.com/users/Voxer/repos","events_url":"https://api.github.com/users/Voxer/events{/privacy}","received_events_url":"https://api.github.com/users/Voxer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Voxer/lb_pool","description":"HTTP client load balancer with retries","fork":false,"url":"https://api.github.com/repos/Voxer/lb_pool","forks_url":"https://api.github.com/repos/Voxer/lb_pool/forks","keys_url":"https://api.github.com/repos/Voxer/lb_pool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Voxer/lb_pool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Voxer/lb_pool/teams","hooks_url":"https://api.github.com/repos/Voxer/lb_pool/hooks","issue_events_url":"https://api.github.com/repos/Voxer/lb_pool/issues/events{/number}","events_url":"https://api.github.com/repos/Voxer/lb_pool/events","assignees_url":"https://api.github.com/repos/Voxer/lb_pool/assignees{/user}","branches_url":"https://api.github.com/repos/Voxer/lb_pool/branches{/branch}","tags_url":"https://api.github.com/repos/Voxer/lb_pool/tags","blobs_url":"https://api.github.com/repos/Voxer/lb_pool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Voxer/lb_pool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Voxer/lb_pool/git/refs{/sha}","trees_url":"https://api.github.com/repos/Voxer/lb_pool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Voxer/lb_pool/statuses/{sha}","languages_url":"https://api.github.com/repos/Voxer/lb_pool/languages","stargazers_url":"https://api.github.com/repos/Voxer/lb_pool/stargazers","contributors_url":"https://api.github.com/repos/Voxer/lb_pool/contributors","subscribers_url":"https://api.github.com/repos/Voxer/lb_pool/subscribers","subscription_url":"https://api.github.com/repos/Voxer/lb_pool/subscription","commits_url":"https://api.github.com/repos/Voxer/lb_pool/commits{/sha}","git_commits_url":"https://api.github.com/repos/Voxer/lb_pool/git/commits{/sha}","comments_url":"https://api.github.com/repos/Voxer/lb_pool/comments{/number}","issue_comment_url":"https://api.github.com/repos/Voxer/lb_pool/issues/comments/{number}","contents_url":"https://api.github.com/repos/Voxer/lb_pool/contents/{+path}","compare_url":"https://api.github.com/repos/Voxer/lb_pool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Voxer/lb_pool/merges","archive_url":"https://api.github.com/repos/Voxer/lb_pool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Voxer/lb_pool/downloads","issues_url":"https://api.github.com/repos/Voxer/lb_pool/issues{/number}","pulls_url":"https://api.github.com/repos/Voxer/lb_pool/pulls{/number}","milestones_url":"https://api.github.com/repos/Voxer/lb_pool/milestones{/number}","notifications_url":"https://api.github.com/repos/Voxer/lb_pool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Voxer/lb_pool/labels{/name}","releases_url":"https://api.github.com/repos/Voxer/lb_pool/releases{/id}","created_at":"2013-10-04T19:20:48Z","updated_at":"2014-11-24T07:42:41Z","pushed_at":"2014-10-28T16:33:23Z","git_url":"git://github.com/Voxer/lb_pool.git","ssh_url":"git@github.com:Voxer/lb_pool.git","clone_url":"https://github.com/Voxer/lb_pool.git","svn_url":"https://github.com/Voxer/lb_pool","homepage":null,"size":402,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Voxer/lb_pool/pulls/5"},"html":{"href":"https://github.com/Voxer/lb_pool/pull/5"},"issue":{"href":"https://api.github.com/repos/Voxer/lb_pool/issues/5"},"comments":{"href":"https://api.github.com/repos/Voxer/lb_pool/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/Voxer/lb_pool/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/Voxer/lb_pool/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Voxer/lb_pool/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/Voxer/lb_pool/statuses/30bde311de302b1247d33973a9231c1f04aee69a"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":27,"deletions":0,"changed_files":3}}