{"action":"closed","number":4692,"pull_request":{"url":"https://api.github.com/repos/scala/scala/pulls/4692","id":42699875,"html_url":"https://github.com/scala/scala/pull/4692","diff_url":"https://github.com/scala/scala/pull/4692.diff","patch_url":"https://github.com/scala/scala/pull/4692.patch","issue_url":"https://api.github.com/repos/scala/scala/issues/4692","number":4692,"state":"closed","locked":false,"title":"SI-6636 Fix macro expansion in toolboxes","user":{"login":"JanBessai","id":1640797,"avatar_url":"https://avatars.githubusercontent.com/u/1640797?v=3","gravatar_id":"","url":"https://api.github.com/users/JanBessai","html_url":"https://github.com/JanBessai","followers_url":"https://api.github.com/users/JanBessai/followers","following_url":"https://api.github.com/users/JanBessai/following{/other_user}","gists_url":"https://api.github.com/users/JanBessai/gists{/gist_id}","starred_url":"https://api.github.com/users/JanBessai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JanBessai/subscriptions","organizations_url":"https://api.github.com/users/JanBessai/orgs","repos_url":"https://api.github.com/users/JanBessai/repos","events_url":"https://api.github.com/users/JanBessai/events{/privacy}","received_events_url":"https://api.github.com/users/JanBessai/received_events","type":"User","site_admin":false},"body":"~~Macro expansion is now based on a configurable parent class loader instead of the fixed default one. Custom expansion class paths are still respected, because `findMacroClassLoader` will create a fresh `ScalaClassLoader`.~~\r\n\r\n`ReflectGlobal` ~~uses the above mechanism~~ overrides `findMacroClassLoader` to provide macro expansion with its rootClassLoader. This way `ToolBox` can expand runtime defined macros.\r\n\r\nA test and some commenting for `findMacroClassLoader` are included.\r\n","created_at":"2015-08-18T13:44:59Z","updated_at":"2015-08-31T17:59:57Z","closed_at":"2015-08-31T17:59:57Z","merged_at":"2015-08-31T17:59:57Z","merge_commit_sha":"badf2b02cca1be26c7b3e4b2bea2ce2c8e7c46a8","assignee":{"login":"adriaanm","id":91083,"avatar_url":"https://avatars.githubusercontent.com/u/91083?v=3","gravatar_id":"","url":"https://api.github.com/users/adriaanm","html_url":"https://github.com/adriaanm","followers_url":"https://api.github.com/users/adriaanm/followers","following_url":"https://api.github.com/users/adriaanm/following{/other_user}","gists_url":"https://api.github.com/users/adriaanm/gists{/gist_id}","starred_url":"https://api.github.com/users/adriaanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriaanm/subscriptions","organizations_url":"https://api.github.com/users/adriaanm/orgs","repos_url":"https://api.github.com/users/adriaanm/repos","events_url":"https://api.github.com/users/adriaanm/events{/privacy}","received_events_url":"https://api.github.com/users/adriaanm/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/scala/scala/milestones/49","html_url":"https://github.com/scala/scala/milestones/2.11.8","labels_url":"https://api.github.com/repos/scala/scala/milestones/49/labels","id":1169165,"number":49,"title":"2.11.8","description":"Merge to 2.11.x.\r\n","creator":{"login":"SethTisue","id":161079,"avatar_url":"https://avatars.githubusercontent.com/u/161079?v=3","gravatar_id":"","url":"https://api.github.com/users/SethTisue","html_url":"https://github.com/SethTisue","followers_url":"https://api.github.com/users/SethTisue/followers","following_url":"https://api.github.com/users/SethTisue/following{/other_user}","gists_url":"https://api.github.com/users/SethTisue/gists{/gist_id}","starred_url":"https://api.github.com/users/SethTisue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SethTisue/subscriptions","organizations_url":"https://api.github.com/users/SethTisue/orgs","repos_url":"https://api.github.com/users/SethTisue/repos","events_url":"https://api.github.com/users/SethTisue/events{/privacy}","received_events_url":"https://api.github.com/users/SethTisue/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":75,"state":"open","created_at":"2015-06-17T19:08:28Z","updated_at":"2015-08-31T17:59:57Z","due_on":"2015-09-21T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/scala/scala/pulls/4692/commits","review_comments_url":"https://api.github.com/repos/scala/scala/pulls/4692/comments","review_comment_url":"https://api.github.com/repos/scala/scala/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scala/scala/issues/4692/comments","statuses_url":"https://api.github.com/repos/scala/scala/statuses/43d3eec9fd3656b8ed0746a25c0a1ce0e9e74353","head":{"label":"JanBessai:Fix-SI-6636","ref":"Fix-SI-6636","sha":"43d3eec9fd3656b8ed0746a25c0a1ce0e9e74353","user":{"login":"JanBessai","id":1640797,"avatar_url":"https://avatars.githubusercontent.com/u/1640797?v=3","gravatar_id":"","url":"https://api.github.com/users/JanBessai","html_url":"https://github.com/JanBessai","followers_url":"https://api.github.com/users/JanBessai/followers","following_url":"https://api.github.com/users/JanBessai/following{/other_user}","gists_url":"https://api.github.com/users/JanBessai/gists{/gist_id}","starred_url":"https://api.github.com/users/JanBessai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JanBessai/subscriptions","organizations_url":"https://api.github.com/users/JanBessai/orgs","repos_url":"https://api.github.com/users/JanBessai/repos","events_url":"https://api.github.com/users/JanBessai/events{/privacy}","received_events_url":"https://api.github.com/users/JanBessai/received_events","type":"User","site_admin":false},"repo":{"id":28901826,"name":"scala","full_name":"JanBessai/scala","owner":{"login":"JanBessai","id":1640797,"avatar_url":"https://avatars.githubusercontent.com/u/1640797?v=3","gravatar_id":"","url":"https://api.github.com/users/JanBessai","html_url":"https://github.com/JanBessai","followers_url":"https://api.github.com/users/JanBessai/followers","following_url":"https://api.github.com/users/JanBessai/following{/other_user}","gists_url":"https://api.github.com/users/JanBessai/gists{/gist_id}","starred_url":"https://api.github.com/users/JanBessai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JanBessai/subscriptions","organizations_url":"https://api.github.com/users/JanBessai/orgs","repos_url":"https://api.github.com/users/JanBessai/repos","events_url":"https://api.github.com/users/JanBessai/events{/privacy}","received_events_url":"https://api.github.com/users/JanBessai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JanBessai/scala","description":"The Scala programming language","fork":true,"url":"https://api.github.com/repos/JanBessai/scala","forks_url":"https://api.github.com/repos/JanBessai/scala/forks","keys_url":"https://api.github.com/repos/JanBessai/scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JanBessai/scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JanBessai/scala/teams","hooks_url":"https://api.github.com/repos/JanBessai/scala/hooks","issue_events_url":"https://api.github.com/repos/JanBessai/scala/issues/events{/number}","events_url":"https://api.github.com/repos/JanBessai/scala/events","assignees_url":"https://api.github.com/repos/JanBessai/scala/assignees{/user}","branches_url":"https://api.github.com/repos/JanBessai/scala/branches{/branch}","tags_url":"https://api.github.com/repos/JanBessai/scala/tags","blobs_url":"https://api.github.com/repos/JanBessai/scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JanBessai/scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JanBessai/scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/JanBessai/scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JanBessai/scala/statuses/{sha}","languages_url":"https://api.github.com/repos/JanBessai/scala/languages","stargazers_url":"https://api.github.com/repos/JanBessai/scala/stargazers","contributors_url":"https://api.github.com/repos/JanBessai/scala/contributors","subscribers_url":"https://api.github.com/repos/JanBessai/scala/subscribers","subscription_url":"https://api.github.com/repos/JanBessai/scala/subscription","commits_url":"https://api.github.com/repos/JanBessai/scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/JanBessai/scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/JanBessai/scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/JanBessai/scala/issues/comments{/number}","contents_url":"https://api.github.com/repos/JanBessai/scala/contents/{+path}","compare_url":"https://api.github.com/repos/JanBessai/scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JanBessai/scala/merges","archive_url":"https://api.github.com/repos/JanBessai/scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JanBessai/scala/downloads","issues_url":"https://api.github.com/repos/JanBessai/scala/issues{/number}","pulls_url":"https://api.github.com/repos/JanBessai/scala/pulls{/number}","milestones_url":"https://api.github.com/repos/JanBessai/scala/milestones{/number}","notifications_url":"https://api.github.com/repos/JanBessai/scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JanBessai/scala/labels{/name}","releases_url":"https://api.github.com/repos/JanBessai/scala/releases{/id}","created_at":"2015-01-07T06:31:19Z","updated_at":"2015-01-07T06:31:33Z","pushed_at":"2015-08-27T16:22:26Z","git_url":"git://github.com/JanBessai/scala.git","ssh_url":"git@github.com:JanBessai/scala.git","clone_url":"https://github.com/JanBessai/scala.git","svn_url":"https://github.com/JanBessai/scala","homepage":"http://www.scala-lang.org/","size":83915,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"2.11.x"}},"base":{"label":"scala:2.11.x","ref":"2.11.x","sha":"f8a6d21a490090bac20b0753c46b91ca2b335049","user":{"login":"scala","id":57059,"avatar_url":"https://avatars.githubusercontent.com/u/57059?v=3","gravatar_id":"","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"repo":{"id":2888818,"name":"scala","full_name":"scala/scala","owner":{"login":"scala","id":57059,"avatar_url":"https://avatars.githubusercontent.com/u/57059?v=3","gravatar_id":"","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scala/scala","description":"The Scala programming language","fork":false,"url":"https://api.github.com/repos/scala/scala","forks_url":"https://api.github.com/repos/scala/scala/forks","keys_url":"https://api.github.com/repos/scala/scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scala/scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scala/scala/teams","hooks_url":"https://api.github.com/repos/scala/scala/hooks","issue_events_url":"https://api.github.com/repos/scala/scala/issues/events{/number}","events_url":"https://api.github.com/repos/scala/scala/events","assignees_url":"https://api.github.com/repos/scala/scala/assignees{/user}","branches_url":"https://api.github.com/repos/scala/scala/branches{/branch}","tags_url":"https://api.github.com/repos/scala/scala/tags","blobs_url":"https://api.github.com/repos/scala/scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scala/scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scala/scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/scala/scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scala/scala/statuses/{sha}","languages_url":"https://api.github.com/repos/scala/scala/languages","stargazers_url":"https://api.github.com/repos/scala/scala/stargazers","contributors_url":"https://api.github.com/repos/scala/scala/contributors","subscribers_url":"https://api.github.com/repos/scala/scala/subscribers","subscription_url":"https://api.github.com/repos/scala/scala/subscription","commits_url":"https://api.github.com/repos/scala/scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/scala/scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/scala/scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/scala/scala/issues/comments{/number}","contents_url":"https://api.github.com/repos/scala/scala/contents/{+path}","compare_url":"https://api.github.com/repos/scala/scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scala/scala/merges","archive_url":"https://api.github.com/repos/scala/scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scala/scala/downloads","issues_url":"https://api.github.com/repos/scala/scala/issues{/number}","pulls_url":"https://api.github.com/repos/scala/scala/pulls{/number}","milestones_url":"https://api.github.com/repos/scala/scala/milestones{/number}","notifications_url":"https://api.github.com/repos/scala/scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scala/scala/labels{/name}","releases_url":"https://api.github.com/repos/scala/scala/releases{/id}","created_at":"2011-12-01T05:02:34Z","updated_at":"2015-08-31T16:47:09Z","pushed_at":"2015-08-31T17:59:57Z","git_url":"git://github.com/scala/scala.git","ssh_url":"git@github.com:scala/scala.git","clone_url":"https://github.com/scala/scala.git","svn_url":"https://github.com/scala/scala","homepage":"http://www.scala-lang.org/","size":194211,"stargazers_count":4709,"watchers_count":4709,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1203,"mirror_url":null,"open_issues_count":33,"forks":1203,"open_issues":33,"watchers":4709,"default_branch":"2.11.x"}},"_links":{"self":{"href":"https://api.github.com/repos/scala/scala/pulls/4692"},"html":{"href":"https://github.com/scala/scala/pull/4692"},"issue":{"href":"https://api.github.com/repos/scala/scala/issues/4692"},"comments":{"href":"https://api.github.com/repos/scala/scala/issues/4692/comments"},"review_comments":{"href":"https://api.github.com/repos/scala/scala/pulls/4692/comments"},"review_comment":{"href":"https://api.github.com/repos/scala/scala/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scala/scala/pulls/4692/commits"},"statuses":{"href":"https://api.github.com/repos/scala/scala/statuses/43d3eec9fd3656b8ed0746a25c0a1ce0e9e74353"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"adriaanm","id":91083,"avatar_url":"https://avatars.githubusercontent.com/u/91083?v=3","gravatar_id":"","url":"https://api.github.com/users/adriaanm","html_url":"https://github.com/adriaanm","followers_url":"https://api.github.com/users/adriaanm/followers","following_url":"https://api.github.com/users/adriaanm/following{/other_user}","gists_url":"https://api.github.com/users/adriaanm/gists{/gist_id}","starred_url":"https://api.github.com/users/adriaanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriaanm/subscriptions","organizations_url":"https://api.github.com/users/adriaanm/orgs","repos_url":"https://api.github.com/users/adriaanm/repos","events_url":"https://api.github.com/users/adriaanm/events{/privacy}","received_events_url":"https://api.github.com/users/adriaanm/received_events","type":"User","site_admin":false},"comments":5,"review_comments":6,"commits":1,"additions":47,"deletions":0,"changed_files":4}}