{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/35393121","id":35393121,"diff_hunk":"@@ -0,0 +1,62 @@\n+import {isPresent, BaseException} from 'angular2/src/facade/lang';\n+import {List, Map} from 'angular2/src/facade/collection';\n+\n+import {ElementSchemaEntry} from './element_schema_entry';\n+\n+export class ElementSchemaRegistry {\n+  hasProperty(elName: string, propName: string): boolean { return true; }\n+\n+  getMappedPropName(elName: string, propName: string): string { return propName; }\n+}\n+\n+export class SchemaRegistryError extends BaseException {\n+  constructor(public message) { super(); }","path":"modules/angular2/src/render/dom/schema/element_schema_registry.ts","position":13,"original_position":13,"commit_id":"e3039841e1807919c72190c29c9ccc2879478a55","original_commit_id":"e3039841e1807919c72190c29c9ccc2879478a55","user":{"login":"mhevery","id":111951,"avatar_url":"https://avatars.githubusercontent.com/u/111951?v=3","gravatar_id":"","url":"https://api.github.com/users/mhevery","html_url":"https://github.com/mhevery","followers_url":"https://api.github.com/users/mhevery/followers","following_url":"https://api.github.com/users/mhevery/following{/other_user}","gists_url":"https://api.github.com/users/mhevery/gists{/gist_id}","starred_url":"https://api.github.com/users/mhevery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhevery/subscriptions","organizations_url":"https://api.github.com/users/mhevery/orgs","repos_url":"https://api.github.com/users/mhevery/repos","events_url":"https://api.github.com/users/mhevery/events{/privacy}","received_events_url":"https://api.github.com/users/mhevery/received_events","type":"User","site_admin":false},"body":"Doesn't `BaseException` take string? `super(message)`?","created_at":"2015-07-24T03:24:50Z","updated_at":"2015-07-24T03:24:50Z","html_url":"https://github.com/angular/angular/pull/3225#discussion_r35393121","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/3225","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/35393121"},"html":{"href":"https://github.com/angular/angular/pull/3225#discussion_r35393121"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/3225"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/3225","id":40682716,"html_url":"https://github.com/angular/angular/pull/3225","diff_url":"https://github.com/angular/angular/pull/3225.diff","patch_url":"https://github.com/angular/angular/pull/3225.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/3225","number":3225,"state":"open","locked":false,"title":"feat(compiler): add schema support for elements","user":{"login":"pkozlowski-opensource","id":973550,"avatar_url":"https://avatars.githubusercontent.com/u/973550?v=3","gravatar_id":"","url":"https://api.github.com/users/pkozlowski-opensource","html_url":"https://github.com/pkozlowski-opensource","followers_url":"https://api.github.com/users/pkozlowski-opensource/followers","following_url":"https://api.github.com/users/pkozlowski-opensource/following{/other_user}","gists_url":"https://api.github.com/users/pkozlowski-opensource/gists{/gist_id}","starred_url":"https://api.github.com/users/pkozlowski-opensource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkozlowski-opensource/subscriptions","organizations_url":"https://api.github.com/users/pkozlowski-opensource/orgs","repos_url":"https://api.github.com/users/pkozlowski-opensource/repos","events_url":"https://api.github.com/users/pkozlowski-opensource/events{/privacy}","received_events_url":"https://api.github.com/users/pkozlowski-opensource/received_events","type":"User","site_admin":false},"body":"This PR adds all the infrastructure for schema support (#2014), without plugging it into the existing compiler (as we need to have hand-crafted schema for Dart).\r\n\r\nHere the basic info about the design / reasoning:\r\n* schema is \"global\" since all the default HTML elements and web components are \"global\", so repeating the same info in each and every @View would be cumbersome\r\n* There are 2 main interfaces: \r\n   * `ElementSchemaRegistry` - \"knows\" schema for all the elements in the entire system and handles \"extends\"\r\n   * `ElementSchemaEntry` - \"knows\" schema for one element type\r\n\r\n```javascript\r\nexport class ElementSchemaRegistry {\r\n  hasProperty(elName: string, propName: string): boolean { return true; }\r\n\r\n  getMappedPropName(elName: string, propName: string): string { return propName; }\r\n}\r\n```\r\n\r\n```javascript\r\nexport interface ElementSchemaEntry {\r\n  getTagName(): string;\r\n  extendsElement(): string;\r\n  hasProperty(propName: string): boolean;\r\n  getMappedPropName(propName: string): string;\r\n}\r\n```\r\n\r\nCurrently there are 2 implementations of the `ElementSchemaEntry`: \"static\" (hand-written) and \"reflective\" (to be used on the JS side). One registry can combine entries of any types.\r\n\r\n@mhevery @tbosch could you please review? I would also like to discuss how we could plug this into the existing compiler (reflective impl will work in JS but will fail in Dart and we need to decide who / when should to hand-craft schema for Dart)","created_at":"2015-07-23T15:11:43Z","updated_at":"2015-07-24T03:24:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc08b82b4e78b5ca7e38af99eb8e4b906db41a32","assignee":{"login":"mhevery","id":111951,"avatar_url":"https://avatars.githubusercontent.com/u/111951?v=3","gravatar_id":"","url":"https://api.github.com/users/mhevery","html_url":"https://github.com/mhevery","followers_url":"https://api.github.com/users/mhevery/followers","following_url":"https://api.github.com/users/mhevery/following{/other_user}","gists_url":"https://api.github.com/users/mhevery/gists{/gist_id}","starred_url":"https://api.github.com/users/mhevery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhevery/subscriptions","organizations_url":"https://api.github.com/users/mhevery/orgs","repos_url":"https://api.github.com/users/mhevery/repos","events_url":"https://api.github.com/users/mhevery/events{/privacy}","received_events_url":"https://api.github.com/users/mhevery/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/angular/angular/milestones/41","html_url":"https://github.com/angular/angular/milestones/alpha-33","labels_url":"https://api.github.com/repos/angular/angular/milestones/41/labels","id":1205895,"number":41,"title":"alpha-33","description":"Current milestone.  Work on all issues to complete by Monday July 27 @ 8am PT; sync internal/external by July 29 EOD.","creator":{"login":"naomiblack","id":2286589,"avatar_url":"https://avatars.githubusercontent.com/u/2286589?v=3","gravatar_id":"","url":"https://api.github.com/users/naomiblack","html_url":"https://github.com/naomiblack","followers_url":"https://api.github.com/users/naomiblack/followers","following_url":"https://api.github.com/users/naomiblack/following{/other_user}","gists_url":"https://api.github.com/users/naomiblack/gists{/gist_id}","starred_url":"https://api.github.com/users/naomiblack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naomiblack/subscriptions","organizations_url":"https://api.github.com/users/naomiblack/orgs","repos_url":"https://api.github.com/users/naomiblack/repos","events_url":"https://api.github.com/users/naomiblack/events{/privacy}","received_events_url":"https://api.github.com/users/naomiblack/received_events","type":"User","site_admin":false},"open_issues":44,"closed_issues":24,"state":"open","created_at":"2015-07-13T20:39:21Z","updated_at":"2015-07-24T02:29:55Z","due_on":"2015-07-27T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/angular/angular/pulls/3225/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/3225/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/3225/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/e3039841e1807919c72190c29c9ccc2879478a55","head":{"label":"pkozlowski-opensource:schema_registry","ref":"schema_registry","sha":"e3039841e1807919c72190c29c9ccc2879478a55","user":{"login":"pkozlowski-opensource","id":973550,"avatar_url":"https://avatars.githubusercontent.com/u/973550?v=3","gravatar_id":"","url":"https://api.github.com/users/pkozlowski-opensource","html_url":"https://github.com/pkozlowski-opensource","followers_url":"https://api.github.com/users/pkozlowski-opensource/followers","following_url":"https://api.github.com/users/pkozlowski-opensource/following{/other_user}","gists_url":"https://api.github.com/users/pkozlowski-opensource/gists{/gist_id}","starred_url":"https://api.github.com/users/pkozlowski-opensource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkozlowski-opensource/subscriptions","organizations_url":"https://api.github.com/users/pkozlowski-opensource/orgs","repos_url":"https://api.github.com/users/pkozlowski-opensource/repos","events_url":"https://api.github.com/users/pkozlowski-opensource/events{/privacy}","received_events_url":"https://api.github.com/users/pkozlowski-opensource/received_events","type":"User","site_admin":false},"repo":{"id":28565710,"name":"angular","full_name":"pkozlowski-opensource/angular","owner":{"login":"pkozlowski-opensource","id":973550,"avatar_url":"https://avatars.githubusercontent.com/u/973550?v=3","gravatar_id":"","url":"https://api.github.com/users/pkozlowski-opensource","html_url":"https://github.com/pkozlowski-opensource","followers_url":"https://api.github.com/users/pkozlowski-opensource/followers","following_url":"https://api.github.com/users/pkozlowski-opensource/following{/other_user}","gists_url":"https://api.github.com/users/pkozlowski-opensource/gists{/gist_id}","starred_url":"https://api.github.com/users/pkozlowski-opensource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkozlowski-opensource/subscriptions","organizations_url":"https://api.github.com/users/pkozlowski-opensource/orgs","repos_url":"https://api.github.com/users/pkozlowski-opensource/repos","events_url":"https://api.github.com/users/pkozlowski-opensource/events{/privacy}","received_events_url":"https://api.github.com/users/pkozlowski-opensource/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pkozlowski-opensource/angular","description":"","fork":true,"url":"https://api.github.com/repos/pkozlowski-opensource/angular","forks_url":"https://api.github.com/repos/pkozlowski-opensource/angular/forks","keys_url":"https://api.github.com/repos/pkozlowski-opensource/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pkozlowski-opensource/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pkozlowski-opensource/angular/teams","hooks_url":"https://api.github.com/repos/pkozlowski-opensource/angular/hooks","issue_events_url":"https://api.github.com/repos/pkozlowski-opensource/angular/issues/events{/number}","events_url":"https://api.github.com/repos/pkozlowski-opensource/angular/events","assignees_url":"https://api.github.com/repos/pkozlowski-opensource/angular/assignees{/user}","branches_url":"https://api.github.com/repos/pkozlowski-opensource/angular/branches{/branch}","tags_url":"https://api.github.com/repos/pkozlowski-opensource/angular/tags","blobs_url":"https://api.github.com/repos/pkozlowski-opensource/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pkozlowski-opensource/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pkozlowski-opensource/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/pkozlowski-opensource/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pkozlowski-opensource/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/pkozlowski-opensource/angular/languages","stargazers_url":"https://api.github.com/repos/pkozlowski-opensource/angular/stargazers","contributors_url":"https://api.github.com/repos/pkozlowski-opensource/angular/contributors","subscribers_url":"https://api.github.com/repos/pkozlowski-opensource/angular/subscribers","subscription_url":"https://api.github.com/repos/pkozlowski-opensource/angular/subscription","commits_url":"https://api.github.com/repos/pkozlowski-opensource/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/pkozlowski-opensource/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/pkozlowski-opensource/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/pkozlowski-opensource/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/pkozlowski-opensource/angular/contents/{+path}","compare_url":"https://api.github.com/repos/pkozlowski-opensource/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pkozlowski-opensource/angular/merges","archive_url":"https://api.github.com/repos/pkozlowski-opensource/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pkozlowski-opensource/angular/downloads","issues_url":"https://api.github.com/repos/pkozlowski-opensource/angular/issues{/number}","pulls_url":"https://api.github.com/repos/pkozlowski-opensource/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/pkozlowski-opensource/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/pkozlowski-opensource/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pkozlowski-opensource/angular/labels{/name}","releases_url":"https://api.github.com/repos/pkozlowski-opensource/angular/releases{/id}","created_at":"2014-12-28T16:05:25Z","updated_at":"2015-06-16T12:14:56Z","pushed_at":"2015-07-23T15:49:57Z","git_url":"git://github.com/pkozlowski-opensource/angular.git","ssh_url":"git@github.com:pkozlowski-opensource/angular.git","clone_url":"https://github.com/pkozlowski-opensource/angular.git","svn_url":"https://github.com/pkozlowski-opensource/angular","homepage":null,"size":11047,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"09226cdd756302c70a93bdee11f2587dbb2b23d3","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","created_at":"2014-09-18T16:12:01Z","updated_at":"2015-07-24T02:54:05Z","pushed_at":"2015-07-24T02:22:06Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":37189,"stargazers_count":4379,"watchers_count":4379,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1146,"mirror_url":null,"open_issues_count":396,"forks":1146,"open_issues":396,"watchers":4379,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/3225"},"html":{"href":"https://github.com/angular/angular/pull/3225"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/3225"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/3225/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/3225/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/3225/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/e3039841e1807919c72190c29c9ccc2879478a55"}}}}