{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/24290155","id":24290155,"diff_hunk":"@@ -42,25 +40,33 @@ object MQTTPublisher {\n     StreamingExamples.setStreamingLogLevels()\n \n     val Seq(brokerUrl, topic) = args.toSeq\n+    \n+    var client: MqttClient = null\n \n     try {\n-      var peristance:MqttClientPersistence =new MqttDefaultFilePersistence(\"/tmp\")\n-      client = new MqttClient(brokerUrl, MqttClient.generateClientId(), peristance)\n+      val persistence = new MemoryPersistence()\n+      client = new MqttClient(brokerUrl, MqttClient.generateClientId(), persistence)\n+\n+      client.connect()\n+\n+      val msgtopic  = client.getTopic(topic)\n+      val msgContent = \"hello mqtt demo for spark streaming\"\n+      val message = new MqttMessage(msgContent.getBytes(\"utf-8\"))\n+\n+      while (true) {\n+        try {\n+          msgtopic.publish(message)\n+          println(\"Published data. topic: %s; Message: %s\".format(msgtopic.getName(), message))\n+        } catch {\n+          case e: MqttException if e.getReasonCode == MqttException.REASON_CODE_MAX_INFLIGHT =>\n+          Thread.sleep(10) // wait for Spark streaming to consume something from the message queue\n+        }  \n+      }      \n     } catch {\n       case e: MqttException => println(\"Exception Caught: \" + e)\n+    } finally {\n+      client.disconnect()","path":"examples/src/main/scala/org/apache/spark/examples/streaming/MQTTWordCount.scala","position":51,"original_position":51,"commit_id":"cd57029ff66c5a741581facd4e08db8c9744edb4","original_commit_id":"cd57029ff66c5a741581facd4e08db8c9744edb4","user":{"login":"srowen","id":822522,"avatar_url":"https://avatars.githubusercontent.com/u/822522?v=3","gravatar_id":"","url":"https://api.github.com/users/srowen","html_url":"https://github.com/srowen","followers_url":"https://api.github.com/users/srowen/followers","following_url":"https://api.github.com/users/srowen/following{/other_user}","gists_url":"https://api.github.com/users/srowen/gists{/gist_id}","starred_url":"https://api.github.com/users/srowen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srowen/subscriptions","organizations_url":"https://api.github.com/users/srowen/orgs","repos_url":"https://api.github.com/users/srowen/repos","events_url":"https://api.github.com/users/srowen/events{/privacy}","received_events_url":"https://api.github.com/users/srowen/received_events","type":"User","site_admin":false},"body":"This should be guarded with a check for `null` I think? this will fail if the constructor above throws an exception.","created_at":"2015-02-07T15:39:23Z","updated_at":"2015-02-07T15:39:23Z","html_url":"https://github.com/apache/spark/pull/4178#discussion_r24290155","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/4178","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/24290155"},"html":{"href":"https://github.com/apache/spark/pull/4178#discussion_r24290155"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/4178"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/4178","id":27914327,"html_url":"https://github.com/apache/spark/pull/4178","diff_url":"https://github.com/apache/spark/pull/4178.diff","patch_url":"https://github.com/apache/spark/pull/4178.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/4178","number":4178,"state":"open","locked":false,"title":"[Minor][streaming][MQTT streaming] some trivial fixes","user":{"login":"prabeesh","id":1409505,"avatar_url":"https://avatars.githubusercontent.com/u/1409505?v=3","gravatar_id":"","url":"https://api.github.com/users/prabeesh","html_url":"https://github.com/prabeesh","followers_url":"https://api.github.com/users/prabeesh/followers","following_url":"https://api.github.com/users/prabeesh/following{/other_user}","gists_url":"https://api.github.com/users/prabeesh/gists{/gist_id}","starred_url":"https://api.github.com/users/prabeesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prabeesh/subscriptions","organizations_url":"https://api.github.com/users/prabeesh/orgs","repos_url":"https://api.github.com/users/prabeesh/repos","events_url":"https://api.github.com/users/prabeesh/events{/privacy}","received_events_url":"https://api.github.com/users/prabeesh/received_events","type":"User","site_admin":false},"body":"modified to adhere to accepted coding standards as pointed by @tdas in PR #3844","created_at":"2015-01-23T10:33:40Z","updated_at":"2015-02-07T15:39:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1a351081a79b88db607f0d14d29cce8a8cb053d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/4178/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/4178/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments/{number}","comments_url":"https://api.github.com/repos/apache/spark/issues/4178/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/cd57029ff66c5a741581facd4e08db8c9744edb4","head":{"label":"prabeesh:master","ref":"master","sha":"cd57029ff66c5a741581facd4e08db8c9744edb4","user":{"login":"prabeesh","id":1409505,"avatar_url":"https://avatars.githubusercontent.com/u/1409505?v=3","gravatar_id":"","url":"https://api.github.com/users/prabeesh","html_url":"https://github.com/prabeesh","followers_url":"https://api.github.com/users/prabeesh/followers","following_url":"https://api.github.com/users/prabeesh/following{/other_user}","gists_url":"https://api.github.com/users/prabeesh/gists{/gist_id}","starred_url":"https://api.github.com/users/prabeesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prabeesh/subscriptions","organizations_url":"https://api.github.com/users/prabeesh/orgs","repos_url":"https://api.github.com/users/prabeesh/repos","events_url":"https://api.github.com/users/prabeesh/events{/privacy}","received_events_url":"https://api.github.com/users/prabeesh/received_events","type":"User","site_admin":false},"repo":{"id":28911430,"name":"spark","full_name":"prabeesh/spark","owner":{"login":"prabeesh","id":1409505,"avatar_url":"https://avatars.githubusercontent.com/u/1409505?v=3","gravatar_id":"","url":"https://api.github.com/users/prabeesh","html_url":"https://github.com/prabeesh","followers_url":"https://api.github.com/users/prabeesh/followers","following_url":"https://api.github.com/users/prabeesh/following{/other_user}","gists_url":"https://api.github.com/users/prabeesh/gists{/gist_id}","starred_url":"https://api.github.com/users/prabeesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prabeesh/subscriptions","organizations_url":"https://api.github.com/users/prabeesh/orgs","repos_url":"https://api.github.com/users/prabeesh/repos","events_url":"https://api.github.com/users/prabeesh/events{/privacy}","received_events_url":"https://api.github.com/users/prabeesh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/prabeesh/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/prabeesh/spark","forks_url":"https://api.github.com/repos/prabeesh/spark/forks","keys_url":"https://api.github.com/repos/prabeesh/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prabeesh/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prabeesh/spark/teams","hooks_url":"https://api.github.com/repos/prabeesh/spark/hooks","issue_events_url":"https://api.github.com/repos/prabeesh/spark/issues/events{/number}","events_url":"https://api.github.com/repos/prabeesh/spark/events","assignees_url":"https://api.github.com/repos/prabeesh/spark/assignees{/user}","branches_url":"https://api.github.com/repos/prabeesh/spark/branches{/branch}","tags_url":"https://api.github.com/repos/prabeesh/spark/tags","blobs_url":"https://api.github.com/repos/prabeesh/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prabeesh/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prabeesh/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/prabeesh/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prabeesh/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/prabeesh/spark/languages","stargazers_url":"https://api.github.com/repos/prabeesh/spark/stargazers","contributors_url":"https://api.github.com/repos/prabeesh/spark/contributors","subscribers_url":"https://api.github.com/repos/prabeesh/spark/subscribers","subscription_url":"https://api.github.com/repos/prabeesh/spark/subscription","commits_url":"https://api.github.com/repos/prabeesh/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/prabeesh/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/prabeesh/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/prabeesh/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/prabeesh/spark/contents/{+path}","compare_url":"https://api.github.com/repos/prabeesh/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prabeesh/spark/merges","archive_url":"https://api.github.com/repos/prabeesh/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prabeesh/spark/downloads","issues_url":"https://api.github.com/repos/prabeesh/spark/issues{/number}","pulls_url":"https://api.github.com/repos/prabeesh/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/prabeesh/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/prabeesh/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prabeesh/spark/labels{/name}","releases_url":"https://api.github.com/repos/prabeesh/spark/releases{/id}","created_at":"2015-01-07T11:19:23Z","updated_at":"2015-02-06T05:30:10Z","pushed_at":"2015-02-06T05:30:09Z","git_url":"git://github.com/prabeesh/spark.git","ssh_url":"git@github.com:prabeesh/spark.git","clone_url":"https://github.com/prabeesh/spark.git","svn_url":"https://github.com/prabeesh/spark","homepage":null,"size":90080,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"6d3b7cbee82b72c695447c13f9f73bcc594b2caf","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-02-07T14:06:39Z","pushed_at":"2015-02-07T08:15:00Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1238850,"stargazers_count":2814,"watchers_count":2814,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2457,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":284,"forks":2457,"open_issues":284,"watchers":2814,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/4178"},"html":{"href":"https://github.com/apache/spark/pull/4178"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/4178"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/4178/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/4178/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/4178/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/cd57029ff66c5a741581facd4e08db8c9744edb4"}}}}