{"action":"created","issue":{"url":"https://api.github.com/repos/aquynh/capstone/issues/494","labels_url":"https://api.github.com/repos/aquynh/capstone/issues/494/labels{/name}","comments_url":"https://api.github.com/repos/aquynh/capstone/issues/494/comments","events_url":"https://api.github.com/repos/aquynh/capstone/issues/494/events","html_url":"https://github.com/aquynh/capstone/issues/494","id":109666688,"number":494,"title":"issues of M68k","user":{"login":"aquynh","id":5965536,"avatar_url":"https://avatars.githubusercontent.com/u/5965536?v=3","gravatar_id":"","url":"https://api.github.com/users/aquynh","html_url":"https://github.com/aquynh","followers_url":"https://api.github.com/users/aquynh/followers","following_url":"https://api.github.com/users/aquynh/following{/other_user}","gists_url":"https://api.github.com/users/aquynh/gists{/gist_id}","starred_url":"https://api.github.com/users/aquynh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aquynh/subscriptions","organizations_url":"https://api.github.com/users/aquynh/orgs","repos_url":"https://api.github.com/users/aquynh/repos","events_url":"https://api.github.com/users/aquynh/events{/privacy}","received_events_url":"https://api.github.com/users/aquynh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":53,"created_at":"2015-10-04T06:47:29Z","updated_at":"2015-10-06T03:42:31Z","closed_at":null,"body":"attention: @emoon & @nplanel \r\n\r\ni fixed some problems with M68K code here https://github.com/aquynh/capstone/commit/ac63d5b9951e0f94c117232a74874a3ff36a7eec. one notable issue: we should declare variables in the beginning of the functions or blocks to make C99 compilers happy (example is older MSVC compilers)\r\n\r\nanother major issue is: we cannot declare static variables like https://github.com/aquynh/capstone/blob/m68k/arch/M68K/M68KDisassembler.c#L63 or https://github.com/aquynh/capstone/blob/m68k/arch/M68K/M68Kdasm.c#L194. The problem will show when 2 instances of M68K engines run at the same time, and in this case these instances will share the same static data leading to a mess.\r\n\r\nTo solve this problem, please see how other archs passing around variables via function arguments (such as *MCInst*). In some special cases, if there is no better choice, it is possible to store these variables into struct **MCInst** (https://github.com/aquynh/capstone/blob/m68k/MCInst.h#L92) or **cs_struct** (https://github.com/aquynh/capstone/blob/m68k/cs_priv.h#L51)"},"comment":{"url":"https://api.github.com/repos/aquynh/capstone/issues/comments/145734320","html_url":"https://github.com/aquynh/capstone/issues/494#issuecomment-145734320","issue_url":"https://api.github.com/repos/aquynh/capstone/issues/494","id":145734320,"user":{"login":"nplanel","id":334425,"avatar_url":"https://avatars.githubusercontent.com/u/334425?v=3","gravatar_id":"","url":"https://api.github.com/users/nplanel","html_url":"https://github.com/nplanel","followers_url":"https://api.github.com/users/nplanel/followers","following_url":"https://api.github.com/users/nplanel/following{/other_user}","gists_url":"https://api.github.com/users/nplanel/gists{/gist_id}","starred_url":"https://api.github.com/users/nplanel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nplanel/subscriptions","organizations_url":"https://api.github.com/users/nplanel/orgs","repos_url":"https://api.github.com/users/nplanel/repos","events_url":"https://api.github.com/users/nplanel/events{/privacy}","received_events_url":"https://api.github.com/users/nplanel/received_events","type":"User","site_admin":false},"created_at":"2015-10-06T03:42:31Z","updated_at":"2015-10-06T03:42:31Z","body":"Hahaha, an old one, yeah from the beginning I catch that python and c output must output the same due to regression testing ... I will patch that later."}}