{"action":"created","issue":{"url":"https://api.github.com/repos/OpenRC/openrc/issues/39","labels_url":"https://api.github.com/repos/OpenRC/openrc/issues/39/labels{/name}","comments_url":"https://api.github.com/repos/OpenRC/openrc/issues/39/comments","events_url":"https://api.github.com/repos/OpenRC/openrc/issues/39/events","html_url":"https://github.com/OpenRC/openrc/issues/39","id":59393889,"number":39,"title":"Clean up rc-cgroup.sh for clarity","user":{"login":"tokiclover","id":905988,"avatar_url":"https://avatars.githubusercontent.com/u/905988?v=3","gravatar_id":"","url":"https://api.github.com/users/tokiclover","html_url":"https://github.com/tokiclover","followers_url":"https://api.github.com/users/tokiclover/followers","following_url":"https://api.github.com/users/tokiclover/following{/other_user}","gists_url":"https://api.github.com/users/tokiclover/gists{/gist_id}","starred_url":"https://api.github.com/users/tokiclover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tokiclover/subscriptions","organizations_url":"https://api.github.com/users/tokiclover/orgs","repos_url":"https://api.github.com/users/tokiclover/repos","events_url":"https://api.github.com/users/tokiclover/events{/privacy}","received_events_url":"https://api.github.com/users/tokiclover/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-01T12:19:10Z","updated_at":"2015-03-01T18:02:37Z","closed_at":null,"body":"Please, consider this patch in an attempt to clean up rc-cgroup.sh. I've just took a look the other day because I needed to make quick similar file for [Supervision-Scripts][1] and had a hard time going trough it because of poor coding style (somewhat confused at times) and bad variable naming scheme.\r\n\r\nI suggest as well:\r\n    * Renaming cgroup_cleanup() to cgroup_del_service() or cgroup_remove_service() to get more consistency on helpers naming (in par with cgroup_add_service()). This is not done in the current iteration because it would require patching runscripts.sh.\r\n    * Use an environment variable--(e.g.) RC_CGROUP_NAME--for the use of 'openrc' group (name.)\r\n\r\nThanks.\r\n\r\n(I am opening a bug request because I don't want to clone OpenRC and submit pull requests. Too much has to be done for that end. Moreover, upstream *can* or *could* completely ignore it--too much work and troubles for nothing. No thanks, Sir!)\r\n\r\nNOTE: This is a copy of [bug][2] request.\r\n\r\n[1]: https://github.com/tokiclover/supervision-scripts\r\n[2]: https://bugs.gentoo.org/show_bug.cgi?id=541792"},"comment":{"url":"https://api.github.com/repos/OpenRC/openrc/issues/comments/76621430","html_url":"https://github.com/OpenRC/openrc/issues/39#issuecomment-76621430","issue_url":"https://api.github.com/repos/OpenRC/openrc/issues/39","id":76621430,"user":{"login":"qnikst","id":170227,"avatar_url":"https://avatars.githubusercontent.com/u/170227?v=3","gravatar_id":"","url":"https://api.github.com/users/qnikst","html_url":"https://github.com/qnikst","followers_url":"https://api.github.com/users/qnikst/followers","following_url":"https://api.github.com/users/qnikst/following{/other_user}","gists_url":"https://api.github.com/users/qnikst/gists{/gist_id}","starred_url":"https://api.github.com/users/qnikst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qnikst/subscriptions","organizations_url":"https://api.github.com/users/qnikst/orgs","repos_url":"https://api.github.com/users/qnikst/repos","events_url":"https://api.github.com/users/qnikst/events{/privacy}","received_events_url":"https://api.github.com/users/qnikst/received_events","type":"User","site_admin":false},"created_at":"2015-03-01T18:02:37Z","updated_at":"2015-03-01T18:02:37Z","body":"I'm open for changes here. One bad thing is that 'croup_cleanup' is a part of public API, I.e. could be used by users, that have scripts that depends on it. So I'll try to check all stuff here and write my plan to improve things here, so you can say if you are OK with that."}}