{"action":"created","comment":{"url":"https://api.github.com/repos/assimp/assimp/pulls/comments/29542347","id":29542347,"diff_hunk":"@@ -514,12 +514,16 @@ void XFileExporter::WriteMesh(aiMesh* mesh)\n \n std::string XFileExporter::toXFileString(aiString &name)\n {\n-\tstd::string str = std::string(name.C_Str());\n-\tstd::replace(str.begin(), str.end(), '<', '_');\n-\tstd::replace(str.begin(), str.end(), '>', '_');\n-\tstd::replace(str.begin(), str.end(), '{', '_');\n-\tstd::replace(str.begin(), str.end(), '}', '_');\n-\tstd::replace(str.begin(), str.end(), '$', '_');\n+\tstd::string pref = \"NN_\"; // node name prefix to prevent unexpected start of string","path":"code/XFileExporter.cpp","position":64,"original_position":30,"commit_id":"2dde962f0d4851eb13092e061df70139b33fa357","original_commit_id":"148207a07309feab55da7fd5d644c3078bbd83c6","user":{"login":"acgessler","id":908209,"avatar_url":"https://avatars.githubusercontent.com/u/908209?v=3","gravatar_id":"","url":"https://api.github.com/users/acgessler","html_url":"https://github.com/acgessler","followers_url":"https://api.github.com/users/acgessler/followers","following_url":"https://api.github.com/users/acgessler/following{/other_user}","gists_url":"https://api.github.com/users/acgessler/gists{/gist_id}","starred_url":"https://api.github.com/users/acgessler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acgessler/subscriptions","organizations_url":"https://api.github.com/users/acgessler/orgs","repos_url":"https://api.github.com/users/acgessler/repos","events_url":"https://api.github.com/users/acgessler/events{/privacy}","received_events_url":"https://api.github.com/users/acgessler/received_events","type":"User","site_admin":false},"body":"Please doublecheck. If assimp's x importer is able to read it with a leading underscore and there is no other importer who can't then we should allow it.\r\n\r\nOtherwise, please add the prefix only if the name begins with an underscore.","created_at":"2015-05-02T00:13:07Z","updated_at":"2015-05-02T00:13:07Z","html_url":"https://github.com/assimp/assimp/pull/549#discussion_r29542347","pull_request_url":"https://api.github.com/repos/assimp/assimp/pulls/549","_links":{"self":{"href":"https://api.github.com/repos/assimp/assimp/pulls/comments/29542347"},"html":{"href":"https://github.com/assimp/assimp/pull/549#discussion_r29542347"},"pull_request":{"href":"https://api.github.com/repos/assimp/assimp/pulls/549"}}},"pull_request":{"url":"https://api.github.com/repos/assimp/assimp/pulls/549","id":34568403,"html_url":"https://github.com/assimp/assimp/pull/549","diff_url":"https://github.com/assimp/assimp/pull/549.diff","patch_url":"https://github.com/assimp/assimp/pull/549.patch","issue_url":"https://api.github.com/repos/assimp/assimp/issues/549","number":549,"state":"open","locked":false,"title":"Step (stp) Exporter","user":{"login":"Madrich","id":7753260,"avatar_url":"https://avatars.githubusercontent.com/u/7753260?v=3","gravatar_id":"","url":"https://api.github.com/users/Madrich","html_url":"https://github.com/Madrich","followers_url":"https://api.github.com/users/Madrich/followers","following_url":"https://api.github.com/users/Madrich/following{/other_user}","gists_url":"https://api.github.com/users/Madrich/gists{/gist_id}","starred_url":"https://api.github.com/users/Madrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Madrich/subscriptions","organizations_url":"https://api.github.com/users/Madrich/orgs","repos_url":"https://api.github.com/users/Madrich/repos","events_url":"https://api.github.com/users/Madrich/events{/privacy}","received_events_url":"https://api.github.com/users/Madrich/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-05-01T21:19:37Z","updated_at":"2015-05-02T00:13:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e75073f8b723128f6c3642907e70dd676c4afd09","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/assimp/assimp/pulls/549/commits","review_comments_url":"https://api.github.com/repos/assimp/assimp/pulls/549/comments","review_comment_url":"https://api.github.com/repos/assimp/assimp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/assimp/assimp/issues/549/comments","statuses_url":"https://api.github.com/repos/assimp/assimp/statuses/2dde962f0d4851eb13092e061df70139b33fa357","head":{"label":"Madrich:master","ref":"master","sha":"2dde962f0d4851eb13092e061df70139b33fa357","user":{"login":"Madrich","id":7753260,"avatar_url":"https://avatars.githubusercontent.com/u/7753260?v=3","gravatar_id":"","url":"https://api.github.com/users/Madrich","html_url":"https://github.com/Madrich","followers_url":"https://api.github.com/users/Madrich/followers","following_url":"https://api.github.com/users/Madrich/following{/other_user}","gists_url":"https://api.github.com/users/Madrich/gists{/gist_id}","starred_url":"https://api.github.com/users/Madrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Madrich/subscriptions","organizations_url":"https://api.github.com/users/Madrich/orgs","repos_url":"https://api.github.com/users/Madrich/repos","events_url":"https://api.github.com/users/Madrich/events{/privacy}","received_events_url":"https://api.github.com/users/Madrich/received_events","type":"User","site_admin":false},"repo":{"id":20352472,"name":"assimp","full_name":"Madrich/assimp","owner":{"login":"Madrich","id":7753260,"avatar_url":"https://avatars.githubusercontent.com/u/7753260?v=3","gravatar_id":"","url":"https://api.github.com/users/Madrich","html_url":"https://github.com/Madrich","followers_url":"https://api.github.com/users/Madrich/followers","following_url":"https://api.github.com/users/Madrich/following{/other_user}","gists_url":"https://api.github.com/users/Madrich/gists{/gist_id}","starred_url":"https://api.github.com/users/Madrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Madrich/subscriptions","organizations_url":"https://api.github.com/users/Madrich/orgs","repos_url":"https://api.github.com/users/Madrich/repos","events_url":"https://api.github.com/users/Madrich/events{/privacy}","received_events_url":"https://api.github.com/users/Madrich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Madrich/assimp","description":"Official Open Asset Import Library Repository. Loads more than thirty 3D file formats into one unified and clean data structure. ","fork":true,"url":"https://api.github.com/repos/Madrich/assimp","forks_url":"https://api.github.com/repos/Madrich/assimp/forks","keys_url":"https://api.github.com/repos/Madrich/assimp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Madrich/assimp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Madrich/assimp/teams","hooks_url":"https://api.github.com/repos/Madrich/assimp/hooks","issue_events_url":"https://api.github.com/repos/Madrich/assimp/issues/events{/number}","events_url":"https://api.github.com/repos/Madrich/assimp/events","assignees_url":"https://api.github.com/repos/Madrich/assimp/assignees{/user}","branches_url":"https://api.github.com/repos/Madrich/assimp/branches{/branch}","tags_url":"https://api.github.com/repos/Madrich/assimp/tags","blobs_url":"https://api.github.com/repos/Madrich/assimp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Madrich/assimp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Madrich/assimp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Madrich/assimp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Madrich/assimp/statuses/{sha}","languages_url":"https://api.github.com/repos/Madrich/assimp/languages","stargazers_url":"https://api.github.com/repos/Madrich/assimp/stargazers","contributors_url":"https://api.github.com/repos/Madrich/assimp/contributors","subscribers_url":"https://api.github.com/repos/Madrich/assimp/subscribers","subscription_url":"https://api.github.com/repos/Madrich/assimp/subscription","commits_url":"https://api.github.com/repos/Madrich/assimp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Madrich/assimp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Madrich/assimp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Madrich/assimp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Madrich/assimp/contents/{+path}","compare_url":"https://api.github.com/repos/Madrich/assimp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Madrich/assimp/merges","archive_url":"https://api.github.com/repos/Madrich/assimp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Madrich/assimp/downloads","issues_url":"https://api.github.com/repos/Madrich/assimp/issues{/number}","pulls_url":"https://api.github.com/repos/Madrich/assimp/pulls{/number}","milestones_url":"https://api.github.com/repos/Madrich/assimp/milestones{/number}","notifications_url":"https://api.github.com/repos/Madrich/assimp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Madrich/assimp/labels{/name}","releases_url":"https://api.github.com/repos/Madrich/assimp/releases{/id}","created_at":"2014-05-31T08:51:30Z","updated_at":"2015-05-01T23:56:46Z","pushed_at":"2015-05-01T23:56:45Z","git_url":"git://github.com/Madrich/assimp.git","ssh_url":"git@github.com:Madrich/assimp.git","clone_url":"https://github.com/Madrich/assimp.git","svn_url":"https://github.com/Madrich/assimp","homepage":"http://assimp.sf.net","size":70234,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"assimp:master","ref":"master","sha":"93bb63fdb40d9682e60ca97b0eda4951a552c742","user":{"login":"assimp","id":265533,"avatar_url":"https://avatars.githubusercontent.com/u/265533?v=3","gravatar_id":"","url":"https://api.github.com/users/assimp","html_url":"https://github.com/assimp","followers_url":"https://api.github.com/users/assimp/followers","following_url":"https://api.github.com/users/assimp/following{/other_user}","gists_url":"https://api.github.com/users/assimp/gists{/gist_id}","starred_url":"https://api.github.com/users/assimp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assimp/subscriptions","organizations_url":"https://api.github.com/users/assimp/orgs","repos_url":"https://api.github.com/users/assimp/repos","events_url":"https://api.github.com/users/assimp/events{/privacy}","received_events_url":"https://api.github.com/users/assimp/received_events","type":"Organization","site_admin":false},"repo":{"id":648332,"name":"assimp","full_name":"assimp/assimp","owner":{"login":"assimp","id":265533,"avatar_url":"https://avatars.githubusercontent.com/u/265533?v=3","gravatar_id":"","url":"https://api.github.com/users/assimp","html_url":"https://github.com/assimp","followers_url":"https://api.github.com/users/assimp/followers","following_url":"https://api.github.com/users/assimp/following{/other_user}","gists_url":"https://api.github.com/users/assimp/gists{/gist_id}","starred_url":"https://api.github.com/users/assimp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assimp/subscriptions","organizations_url":"https://api.github.com/users/assimp/orgs","repos_url":"https://api.github.com/users/assimp/repos","events_url":"https://api.github.com/users/assimp/events{/privacy}","received_events_url":"https://api.github.com/users/assimp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/assimp/assimp","description":"Official Open Asset Import Library Repository. Loads 40+ 3D file formats into one unified and clean data structure. ","fork":false,"url":"https://api.github.com/repos/assimp/assimp","forks_url":"https://api.github.com/repos/assimp/assimp/forks","keys_url":"https://api.github.com/repos/assimp/assimp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/assimp/assimp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/assimp/assimp/teams","hooks_url":"https://api.github.com/repos/assimp/assimp/hooks","issue_events_url":"https://api.github.com/repos/assimp/assimp/issues/events{/number}","events_url":"https://api.github.com/repos/assimp/assimp/events","assignees_url":"https://api.github.com/repos/assimp/assimp/assignees{/user}","branches_url":"https://api.github.com/repos/assimp/assimp/branches{/branch}","tags_url":"https://api.github.com/repos/assimp/assimp/tags","blobs_url":"https://api.github.com/repos/assimp/assimp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/assimp/assimp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/assimp/assimp/git/refs{/sha}","trees_url":"https://api.github.com/repos/assimp/assimp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/assimp/assimp/statuses/{sha}","languages_url":"https://api.github.com/repos/assimp/assimp/languages","stargazers_url":"https://api.github.com/repos/assimp/assimp/stargazers","contributors_url":"https://api.github.com/repos/assimp/assimp/contributors","subscribers_url":"https://api.github.com/repos/assimp/assimp/subscribers","subscription_url":"https://api.github.com/repos/assimp/assimp/subscription","commits_url":"https://api.github.com/repos/assimp/assimp/commits{/sha}","git_commits_url":"https://api.github.com/repos/assimp/assimp/git/commits{/sha}","comments_url":"https://api.github.com/repos/assimp/assimp/comments{/number}","issue_comment_url":"https://api.github.com/repos/assimp/assimp/issues/comments{/number}","contents_url":"https://api.github.com/repos/assimp/assimp/contents/{+path}","compare_url":"https://api.github.com/repos/assimp/assimp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/assimp/assimp/merges","archive_url":"https://api.github.com/repos/assimp/assimp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/assimp/assimp/downloads","issues_url":"https://api.github.com/repos/assimp/assimp/issues{/number}","pulls_url":"https://api.github.com/repos/assimp/assimp/pulls{/number}","milestones_url":"https://api.github.com/repos/assimp/assimp/milestones{/number}","notifications_url":"https://api.github.com/repos/assimp/assimp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/assimp/assimp/labels{/name}","releases_url":"https://api.github.com/repos/assimp/assimp/releases{/id}","created_at":"2010-05-05T12:53:45Z","updated_at":"2015-05-01T23:30:53Z","pushed_at":"2015-05-01T23:56:46Z","git_url":"git://github.com/assimp/assimp.git","ssh_url":"git@github.com:assimp/assimp.git","clone_url":"https://github.com/assimp/assimp.git","svn_url":"https://github.com/assimp/assimp","homepage":"http://assimp.sf.net","size":96291,"stargazers_count":720,"watchers_count":720,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":326,"mirror_url":null,"open_issues_count":128,"forks":326,"open_issues":128,"watchers":720,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/assimp/assimp/pulls/549"},"html":{"href":"https://github.com/assimp/assimp/pull/549"},"issue":{"href":"https://api.github.com/repos/assimp/assimp/issues/549"},"comments":{"href":"https://api.github.com/repos/assimp/assimp/issues/549/comments"},"review_comments":{"href":"https://api.github.com/repos/assimp/assimp/pulls/549/comments"},"review_comment":{"href":"https://api.github.com/repos/assimp/assimp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/assimp/assimp/pulls/549/commits"},"statuses":{"href":"https://api.github.com/repos/assimp/assimp/statuses/2dde962f0d4851eb13092e061df70139b33fa357"}}}}