{"action":"created","comment":{"url":"https://api.github.com/repos/MinecraftForge/FML/pulls/comments/22718299","id":22718299,"diff_hunk":"@@ -191,13 +191,8 @@ public static Block registerBlock(Block block, Class<? extends ItemBlock> itemcl\n      */\n     public static Block registerBlock(Block block, Class<? extends ItemBlock> itemclass, String name, Object... itemCtorArgs)\n     {\n-        if (Loader.instance().isInState(LoaderState.CONSTRUCTING))\n-        {\n-            FMLLog.warning(\"The mod %s is attempting to register a block whilst it it being constructed. This is bad modding practice - please use a proper mod lifecycle event.\", Loader.instance().activeModContainer());\n-        }\n         try\n         {\n-            assert block != null : \"registerBlock: block cannot be null\";","path":"src/main/java/net/minecraftforge/fml/common/registry/GameRegistry.java","position":36,"original_position":28,"commit_id":"a1d924d4ebf2d33c62f513e2e4c8fc06fc6a6f60","original_commit_id":"b23647d2447934d2452f8f83e61b6a048a0427b3","user":{"login":"diesieben07","id":1915984,"avatar_url":"https://avatars.githubusercontent.com/u/1915984?v=3","gravatar_id":"","url":"https://api.github.com/users/diesieben07","html_url":"https://github.com/diesieben07","followers_url":"https://api.github.com/users/diesieben07/followers","following_url":"https://api.github.com/users/diesieben07/following{/other_user}","gists_url":"https://api.github.com/users/diesieben07/gists{/gist_id}","starred_url":"https://api.github.com/users/diesieben07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diesieben07/subscriptions","organizations_url":"https://api.github.com/users/diesieben07/orgs","repos_url":"https://api.github.com/users/diesieben07/repos","events_url":"https://api.github.com/users/diesieben07/events{/privacy}","received_events_url":"https://api.github.com/users/diesieben07/received_events","type":"User","site_admin":false},"body":"Happy now? :)","created_at":"2015-01-09T14:35:50Z","updated_at":"2015-01-09T14:35:50Z","html_url":"https://github.com/MinecraftForge/FML/pull/586#discussion_r22718299","pull_request_url":"https://api.github.com/repos/MinecraftForge/FML/pulls/586","_links":{"self":{"href":"https://api.github.com/repos/MinecraftForge/FML/pulls/comments/22718299"},"html":{"href":"https://github.com/MinecraftForge/FML/pull/586#discussion_r22718299"},"pull_request":{"href":"https://api.github.com/repos/MinecraftForge/FML/pulls/586"}}},"pull_request":{"url":"https://api.github.com/repos/MinecraftForge/FML/pulls/586","id":27100560,"html_url":"https://github.com/MinecraftForge/FML/pull/586","diff_url":"https://github.com/MinecraftForge/FML/pull/586.diff","patch_url":"https://github.com/MinecraftForge/FML/pull/586.patch","issue_url":"https://api.github.com/repos/MinecraftForge/FML/issues/586","number":586,"state":"open","locked":false,"title":"Provide alternative implementation for registerBlock without reflection","user":{"login":"diesieben07","id":1915984,"avatar_url":"https://avatars.githubusercontent.com/u/1915984?v=3","gravatar_id":"","url":"https://api.github.com/users/diesieben07","html_url":"https://github.com/diesieben07","followers_url":"https://api.github.com/users/diesieben07/followers","following_url":"https://api.github.com/users/diesieben07/following{/other_user}","gists_url":"https://api.github.com/users/diesieben07/gists{/gist_id}","starred_url":"https://api.github.com/users/diesieben07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diesieben07/subscriptions","organizations_url":"https://api.github.com/users/diesieben07/orgs","repos_url":"https://api.github.com/users/diesieben07/repos","events_url":"https://api.github.com/users/diesieben07/events{/privacy}","received_events_url":"https://api.github.com/users/diesieben07/received_events","type":"User","site_admin":false},"body":"Like #509 but targeted at 1.8 and without all the reflection.","created_at":"2015-01-09T13:47:27Z","updated_at":"2015-01-09T14:35:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"38de76915f4f93b6cb5b5f896c6999c1b91bbf94","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MinecraftForge/FML/pulls/586/commits","review_comments_url":"https://api.github.com/repos/MinecraftForge/FML/pulls/586/comments","review_comment_url":"https://api.github.com/repos/MinecraftForge/FML/pulls/comments/{number}","comments_url":"https://api.github.com/repos/MinecraftForge/FML/issues/586/comments","statuses_url":"https://api.github.com/repos/MinecraftForge/FML/statuses/a1d924d4ebf2d33c62f513e2e4c8fc06fc6a6f60","head":{"label":"diesieben07:itemblock-impr","ref":"itemblock-impr","sha":"a1d924d4ebf2d33c62f513e2e4c8fc06fc6a6f60","user":{"login":"diesieben07","id":1915984,"avatar_url":"https://avatars.githubusercontent.com/u/1915984?v=3","gravatar_id":"","url":"https://api.github.com/users/diesieben07","html_url":"https://github.com/diesieben07","followers_url":"https://api.github.com/users/diesieben07/followers","following_url":"https://api.github.com/users/diesieben07/following{/other_user}","gists_url":"https://api.github.com/users/diesieben07/gists{/gist_id}","starred_url":"https://api.github.com/users/diesieben07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diesieben07/subscriptions","organizations_url":"https://api.github.com/users/diesieben07/orgs","repos_url":"https://api.github.com/users/diesieben07/repos","events_url":"https://api.github.com/users/diesieben07/events{/privacy}","received_events_url":"https://api.github.com/users/diesieben07/received_events","type":"User","site_admin":false},"repo":{"id":8299282,"name":"FML","full_name":"diesieben07/FML","owner":{"login":"diesieben07","id":1915984,"avatar_url":"https://avatars.githubusercontent.com/u/1915984?v=3","gravatar_id":"","url":"https://api.github.com/users/diesieben07","html_url":"https://github.com/diesieben07","followers_url":"https://api.github.com/users/diesieben07/followers","following_url":"https://api.github.com/users/diesieben07/following{/other_user}","gists_url":"https://api.github.com/users/diesieben07/gists{/gist_id}","starred_url":"https://api.github.com/users/diesieben07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diesieben07/subscriptions","organizations_url":"https://api.github.com/users/diesieben07/orgs","repos_url":"https://api.github.com/users/diesieben07/repos","events_url":"https://api.github.com/users/diesieben07/events{/privacy}","received_events_url":"https://api.github.com/users/diesieben07/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/diesieben07/FML","description":"The Forge Mod Loader - an opensource replacement mod loader for minecraft","fork":true,"url":"https://api.github.com/repos/diesieben07/FML","forks_url":"https://api.github.com/repos/diesieben07/FML/forks","keys_url":"https://api.github.com/repos/diesieben07/FML/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diesieben07/FML/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diesieben07/FML/teams","hooks_url":"https://api.github.com/repos/diesieben07/FML/hooks","issue_events_url":"https://api.github.com/repos/diesieben07/FML/issues/events{/number}","events_url":"https://api.github.com/repos/diesieben07/FML/events","assignees_url":"https://api.github.com/repos/diesieben07/FML/assignees{/user}","branches_url":"https://api.github.com/repos/diesieben07/FML/branches{/branch}","tags_url":"https://api.github.com/repos/diesieben07/FML/tags","blobs_url":"https://api.github.com/repos/diesieben07/FML/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diesieben07/FML/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diesieben07/FML/git/refs{/sha}","trees_url":"https://api.github.com/repos/diesieben07/FML/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diesieben07/FML/statuses/{sha}","languages_url":"https://api.github.com/repos/diesieben07/FML/languages","stargazers_url":"https://api.github.com/repos/diesieben07/FML/stargazers","contributors_url":"https://api.github.com/repos/diesieben07/FML/contributors","subscribers_url":"https://api.github.com/repos/diesieben07/FML/subscribers","subscription_url":"https://api.github.com/repos/diesieben07/FML/subscription","commits_url":"https://api.github.com/repos/diesieben07/FML/commits{/sha}","git_commits_url":"https://api.github.com/repos/diesieben07/FML/git/commits{/sha}","comments_url":"https://api.github.com/repos/diesieben07/FML/comments{/number}","issue_comment_url":"https://api.github.com/repos/diesieben07/FML/issues/comments/{number}","contents_url":"https://api.github.com/repos/diesieben07/FML/contents/{+path}","compare_url":"https://api.github.com/repos/diesieben07/FML/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diesieben07/FML/merges","archive_url":"https://api.github.com/repos/diesieben07/FML/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diesieben07/FML/downloads","issues_url":"https://api.github.com/repos/diesieben07/FML/issues{/number}","pulls_url":"https://api.github.com/repos/diesieben07/FML/pulls{/number}","milestones_url":"https://api.github.com/repos/diesieben07/FML/milestones{/number}","notifications_url":"https://api.github.com/repos/diesieben07/FML/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diesieben07/FML/labels{/name}","releases_url":"https://api.github.com/repos/diesieben07/FML/releases{/id}","created_at":"2013-02-19T20:57:05Z","updated_at":"2014-08-31T22:28:54Z","pushed_at":"2015-01-09T14:35:07Z","git_url":"git://github.com/diesieben07/FML.git","ssh_url":"git@github.com:diesieben07/FML.git","clone_url":"https://github.com/diesieben07/FML.git","svn_url":"https://github.com/diesieben07/FML","homepage":"","size":20496,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MinecraftForge:1.8","ref":"1.8","sha":"b0e44e427e8397e09dd1ddd5306a5d9da0f27145","user":{"login":"MinecraftForge","id":1390178,"avatar_url":"https://avatars.githubusercontent.com/u/1390178?v=3","gravatar_id":"","url":"https://api.github.com/users/MinecraftForge","html_url":"https://github.com/MinecraftForge","followers_url":"https://api.github.com/users/MinecraftForge/followers","following_url":"https://api.github.com/users/MinecraftForge/following{/other_user}","gists_url":"https://api.github.com/users/MinecraftForge/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecraftForge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecraftForge/subscriptions","organizations_url":"https://api.github.com/users/MinecraftForge/orgs","repos_url":"https://api.github.com/users/MinecraftForge/repos","events_url":"https://api.github.com/users/MinecraftForge/events{/privacy}","received_events_url":"https://api.github.com/users/MinecraftForge/received_events","type":"Organization","site_admin":false},"repo":{"id":3857240,"name":"FML","full_name":"MinecraftForge/FML","owner":{"login":"MinecraftForge","id":1390178,"avatar_url":"https://avatars.githubusercontent.com/u/1390178?v=3","gravatar_id":"","url":"https://api.github.com/users/MinecraftForge","html_url":"https://github.com/MinecraftForge","followers_url":"https://api.github.com/users/MinecraftForge/followers","following_url":"https://api.github.com/users/MinecraftForge/following{/other_user}","gists_url":"https://api.github.com/users/MinecraftForge/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecraftForge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecraftForge/subscriptions","organizations_url":"https://api.github.com/users/MinecraftForge/orgs","repos_url":"https://api.github.com/users/MinecraftForge/repos","events_url":"https://api.github.com/users/MinecraftForge/events{/privacy}","received_events_url":"https://api.github.com/users/MinecraftForge/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MinecraftForge/FML","description":"The Forge Mod Loader - an opensource replacement mod loader for minecraft","fork":false,"url":"https://api.github.com/repos/MinecraftForge/FML","forks_url":"https://api.github.com/repos/MinecraftForge/FML/forks","keys_url":"https://api.github.com/repos/MinecraftForge/FML/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MinecraftForge/FML/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MinecraftForge/FML/teams","hooks_url":"https://api.github.com/repos/MinecraftForge/FML/hooks","issue_events_url":"https://api.github.com/repos/MinecraftForge/FML/issues/events{/number}","events_url":"https://api.github.com/repos/MinecraftForge/FML/events","assignees_url":"https://api.github.com/repos/MinecraftForge/FML/assignees{/user}","branches_url":"https://api.github.com/repos/MinecraftForge/FML/branches{/branch}","tags_url":"https://api.github.com/repos/MinecraftForge/FML/tags","blobs_url":"https://api.github.com/repos/MinecraftForge/FML/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MinecraftForge/FML/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MinecraftForge/FML/git/refs{/sha}","trees_url":"https://api.github.com/repos/MinecraftForge/FML/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MinecraftForge/FML/statuses/{sha}","languages_url":"https://api.github.com/repos/MinecraftForge/FML/languages","stargazers_url":"https://api.github.com/repos/MinecraftForge/FML/stargazers","contributors_url":"https://api.github.com/repos/MinecraftForge/FML/contributors","subscribers_url":"https://api.github.com/repos/MinecraftForge/FML/subscribers","subscription_url":"https://api.github.com/repos/MinecraftForge/FML/subscription","commits_url":"https://api.github.com/repos/MinecraftForge/FML/commits{/sha}","git_commits_url":"https://api.github.com/repos/MinecraftForge/FML/git/commits{/sha}","comments_url":"https://api.github.com/repos/MinecraftForge/FML/comments{/number}","issue_comment_url":"https://api.github.com/repos/MinecraftForge/FML/issues/comments/{number}","contents_url":"https://api.github.com/repos/MinecraftForge/FML/contents/{+path}","compare_url":"https://api.github.com/repos/MinecraftForge/FML/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MinecraftForge/FML/merges","archive_url":"https://api.github.com/repos/MinecraftForge/FML/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MinecraftForge/FML/downloads","issues_url":"https://api.github.com/repos/MinecraftForge/FML/issues{/number}","pulls_url":"https://api.github.com/repos/MinecraftForge/FML/pulls{/number}","milestones_url":"https://api.github.com/repos/MinecraftForge/FML/milestones{/number}","notifications_url":"https://api.github.com/repos/MinecraftForge/FML/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MinecraftForge/FML/labels{/name}","releases_url":"https://api.github.com/repos/MinecraftForge/FML/releases{/id}","created_at":"2012-03-28T16:50:53Z","updated_at":"2015-01-03T04:24:48Z","pushed_at":"2014-12-23T22:15:42Z","git_url":"git://github.com/MinecraftForge/FML.git","ssh_url":"git@github.com:MinecraftForge/FML.git","clone_url":"https://github.com/MinecraftForge/FML.git","svn_url":"https://github.com/MinecraftForge/FML","homepage":"","size":25482,"stargazers_count":378,"watchers_count":378,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":225,"mirror_url":null,"open_issues_count":42,"forks":225,"open_issues":42,"watchers":378,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MinecraftForge/FML/pulls/586"},"html":{"href":"https://github.com/MinecraftForge/FML/pull/586"},"issue":{"href":"https://api.github.com/repos/MinecraftForge/FML/issues/586"},"comments":{"href":"https://api.github.com/repos/MinecraftForge/FML/issues/586/comments"},"review_comments":{"href":"https://api.github.com/repos/MinecraftForge/FML/pulls/586/comments"},"review_comment":{"href":"https://api.github.com/repos/MinecraftForge/FML/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/MinecraftForge/FML/pulls/586/commits"},"statuses":{"href":"https://api.github.com/repos/MinecraftForge/FML/statuses/a1d924d4ebf2d33c62f513e2e4c8fc06fc6a6f60"}}}}