{"action":"created","comment":{"url":"https://api.github.com/repos/awslabs/s2n/pulls/comments/34067330","id":34067330,"diff_hunk":"@@ -27,4 +29,4 @@ libtests2n.so: ${OBJS}\n \t${CC} ${CFLAGS} -shared ${LDFLAGS} -o libtests2n.so ${OBJS}\n \n libtests2n.dylib: ${OBJS}\n-\ttest ! -f /usr/lib/libSystem.dylib || libtool ${LDFLAGS} -dynamic -o libtests2n.dylib ${OBJS}\n+\t${CC} ${ARCHFLAGS} ${LDFLAGS} -dynamiclib -o libtests2n.dylib ${OBJS}","path":"tests/testlib/Makefile","position":19,"original_position":19,"commit_id":"7cb970332bec389fa352b90b7baa9daa0a2cbccd","original_commit_id":"7cb970332bec389fa352b90b7baa9daa0a2cbccd","user":{"login":"colmmacc","id":172568,"avatar_url":"https://avatars.githubusercontent.com/u/172568?v=3","gravatar_id":"","url":"https://api.github.com/users/colmmacc","html_url":"https://github.com/colmmacc","followers_url":"https://api.github.com/users/colmmacc/followers","following_url":"https://api.github.com/users/colmmacc/following{/other_user}","gists_url":"https://api.github.com/users/colmmacc/gists{/gist_id}","starred_url":"https://api.github.com/users/colmmacc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colmmacc/subscriptions","organizations_url":"https://api.github.com/users/colmmacc/orgs","repos_url":"https://api.github.com/users/colmmacc/repos","events_url":"https://api.github.com/users/colmmacc/events{/privacy}","received_events_url":"https://api.github.com/users/colmmacc/received_events","type":"User","site_admin":false},"body":"I don't think so, I've never seen it elsewhere. The test is a check for \"are we on OS X\". Any other check would work too, maybe uname? ","created_at":"2015-07-07T17:37:17Z","updated_at":"2015-07-07T17:37:17Z","html_url":"https://github.com/awslabs/s2n/pull/102#discussion_r34067330","pull_request_url":"https://api.github.com/repos/awslabs/s2n/pulls/102","_links":{"self":{"href":"https://api.github.com/repos/awslabs/s2n/pulls/comments/34067330"},"html":{"href":"https://github.com/awslabs/s2n/pull/102#discussion_r34067330"},"pull_request":{"href":"https://api.github.com/repos/awslabs/s2n/pulls/102"}}},"pull_request":{"url":"https://api.github.com/repos/awslabs/s2n/pulls/102","id":38944601,"html_url":"https://github.com/awslabs/s2n/pull/102","diff_url":"https://github.com/awslabs/s2n/pull/102.diff","patch_url":"https://github.com/awslabs/s2n/pull/102.patch","issue_url":"https://api.github.com/repos/awslabs/s2n/issues/102","number":102,"state":"open","locked":false,"title":"Bug/osx universal","user":{"login":"nobu","id":16700,"avatar_url":"https://avatars.githubusercontent.com/u/16700?v=3","gravatar_id":"","url":"https://api.github.com/users/nobu","html_url":"https://github.com/nobu","followers_url":"https://api.github.com/users/nobu/followers","following_url":"https://api.github.com/users/nobu/following{/other_user}","gists_url":"https://api.github.com/users/nobu/gists{/gist_id}","starred_url":"https://api.github.com/users/nobu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nobu/subscriptions","organizations_url":"https://api.github.com/users/nobu/orgs","repos_url":"https://api.github.com/users/nobu/repos","events_url":"https://api.github.com/users/nobu/events{/privacy}","received_events_url":"https://api.github.com/users/nobu/received_events","type":"User","site_admin":false},"body":"To allow build OSX universal binaries:\r\n\r\n~~~\r\nmake ARCHFLAGS='-arch x86_64 -arch i386'\r\n~~~\r\n\r\nand to use installed libcrypto:\r\n\r\n~~~\r\nmake CRYPTO_LIBS='-L/usr/local/lib -lcrypto'\r\n~~~","created_at":"2015-07-01T03:06:13Z","updated_at":"2015-07-07T17:37:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"04f59ed92d9bb15c244cdc2f3a3e2882e6d8bc42","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/awslabs/s2n/pulls/102/commits","review_comments_url":"https://api.github.com/repos/awslabs/s2n/pulls/102/comments","review_comment_url":"https://api.github.com/repos/awslabs/s2n/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awslabs/s2n/issues/102/comments","statuses_url":"https://api.github.com/repos/awslabs/s2n/statuses/7cb970332bec389fa352b90b7baa9daa0a2cbccd","head":{"label":"nobu:bug/osx-universal","ref":"bug/osx-universal","sha":"7cb970332bec389fa352b90b7baa9daa0a2cbccd","user":{"login":"nobu","id":16700,"avatar_url":"https://avatars.githubusercontent.com/u/16700?v=3","gravatar_id":"","url":"https://api.github.com/users/nobu","html_url":"https://github.com/nobu","followers_url":"https://api.github.com/users/nobu/followers","following_url":"https://api.github.com/users/nobu/following{/other_user}","gists_url":"https://api.github.com/users/nobu/gists{/gist_id}","starred_url":"https://api.github.com/users/nobu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nobu/subscriptions","organizations_url":"https://api.github.com/users/nobu/orgs","repos_url":"https://api.github.com/users/nobu/repos","events_url":"https://api.github.com/users/nobu/events{/privacy}","received_events_url":"https://api.github.com/users/nobu/received_events","type":"User","site_admin":false},"repo":{"id":38343410,"name":"s2n","full_name":"nobu/s2n","owner":{"login":"nobu","id":16700,"avatar_url":"https://avatars.githubusercontent.com/u/16700?v=3","gravatar_id":"","url":"https://api.github.com/users/nobu","html_url":"https://github.com/nobu","followers_url":"https://api.github.com/users/nobu/followers","following_url":"https://api.github.com/users/nobu/following{/other_user}","gists_url":"https://api.github.com/users/nobu/gists{/gist_id}","starred_url":"https://api.github.com/users/nobu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nobu/subscriptions","organizations_url":"https://api.github.com/users/nobu/orgs","repos_url":"https://api.github.com/users/nobu/repos","events_url":"https://api.github.com/users/nobu/events{/privacy}","received_events_url":"https://api.github.com/users/nobu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nobu/s2n","description":"s2n : an implementation of the TLS/SSL protocols","fork":true,"url":"https://api.github.com/repos/nobu/s2n","forks_url":"https://api.github.com/repos/nobu/s2n/forks","keys_url":"https://api.github.com/repos/nobu/s2n/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nobu/s2n/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nobu/s2n/teams","hooks_url":"https://api.github.com/repos/nobu/s2n/hooks","issue_events_url":"https://api.github.com/repos/nobu/s2n/issues/events{/number}","events_url":"https://api.github.com/repos/nobu/s2n/events","assignees_url":"https://api.github.com/repos/nobu/s2n/assignees{/user}","branches_url":"https://api.github.com/repos/nobu/s2n/branches{/branch}","tags_url":"https://api.github.com/repos/nobu/s2n/tags","blobs_url":"https://api.github.com/repos/nobu/s2n/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nobu/s2n/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nobu/s2n/git/refs{/sha}","trees_url":"https://api.github.com/repos/nobu/s2n/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nobu/s2n/statuses/{sha}","languages_url":"https://api.github.com/repos/nobu/s2n/languages","stargazers_url":"https://api.github.com/repos/nobu/s2n/stargazers","contributors_url":"https://api.github.com/repos/nobu/s2n/contributors","subscribers_url":"https://api.github.com/repos/nobu/s2n/subscribers","subscription_url":"https://api.github.com/repos/nobu/s2n/subscription","commits_url":"https://api.github.com/repos/nobu/s2n/commits{/sha}","git_commits_url":"https://api.github.com/repos/nobu/s2n/git/commits{/sha}","comments_url":"https://api.github.com/repos/nobu/s2n/comments{/number}","issue_comment_url":"https://api.github.com/repos/nobu/s2n/issues/comments{/number}","contents_url":"https://api.github.com/repos/nobu/s2n/contents/{+path}","compare_url":"https://api.github.com/repos/nobu/s2n/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nobu/s2n/merges","archive_url":"https://api.github.com/repos/nobu/s2n/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nobu/s2n/downloads","issues_url":"https://api.github.com/repos/nobu/s2n/issues{/number}","pulls_url":"https://api.github.com/repos/nobu/s2n/pulls{/number}","milestones_url":"https://api.github.com/repos/nobu/s2n/milestones{/number}","notifications_url":"https://api.github.com/repos/nobu/s2n/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nobu/s2n/labels{/name}","releases_url":"https://api.github.com/repos/nobu/s2n/releases{/id}","created_at":"2015-07-01T01:56:37Z","updated_at":"2015-07-01T01:56:37Z","pushed_at":"2015-07-01T03:03:32Z","git_url":"git://github.com/nobu/s2n.git","ssh_url":"git@github.com:nobu/s2n.git","clone_url":"https://github.com/nobu/s2n.git","svn_url":"https://github.com/nobu/s2n","homepage":"","size":1062,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"awslabs:master","ref":"master","sha":"4f7d3e65ac3b10518a5718b8ac592969bae7616c","user":{"login":"awslabs","id":3299148,"avatar_url":"https://avatars.githubusercontent.com/u/3299148?v=3","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":21287076,"name":"s2n","full_name":"awslabs/s2n","owner":{"login":"awslabs","id":3299148,"avatar_url":"https://avatars.githubusercontent.com/u/3299148?v=3","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/awslabs/s2n","description":"s2n : an implementation of the TLS/SSL protocols","fork":false,"url":"https://api.github.com/repos/awslabs/s2n","forks_url":"https://api.github.com/repos/awslabs/s2n/forks","keys_url":"https://api.github.com/repos/awslabs/s2n/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awslabs/s2n/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awslabs/s2n/teams","hooks_url":"https://api.github.com/repos/awslabs/s2n/hooks","issue_events_url":"https://api.github.com/repos/awslabs/s2n/issues/events{/number}","events_url":"https://api.github.com/repos/awslabs/s2n/events","assignees_url":"https://api.github.com/repos/awslabs/s2n/assignees{/user}","branches_url":"https://api.github.com/repos/awslabs/s2n/branches{/branch}","tags_url":"https://api.github.com/repos/awslabs/s2n/tags","blobs_url":"https://api.github.com/repos/awslabs/s2n/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awslabs/s2n/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awslabs/s2n/git/refs{/sha}","trees_url":"https://api.github.com/repos/awslabs/s2n/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awslabs/s2n/statuses/{sha}","languages_url":"https://api.github.com/repos/awslabs/s2n/languages","stargazers_url":"https://api.github.com/repos/awslabs/s2n/stargazers","contributors_url":"https://api.github.com/repos/awslabs/s2n/contributors","subscribers_url":"https://api.github.com/repos/awslabs/s2n/subscribers","subscription_url":"https://api.github.com/repos/awslabs/s2n/subscription","commits_url":"https://api.github.com/repos/awslabs/s2n/commits{/sha}","git_commits_url":"https://api.github.com/repos/awslabs/s2n/git/commits{/sha}","comments_url":"https://api.github.com/repos/awslabs/s2n/comments{/number}","issue_comment_url":"https://api.github.com/repos/awslabs/s2n/issues/comments{/number}","contents_url":"https://api.github.com/repos/awslabs/s2n/contents/{+path}","compare_url":"https://api.github.com/repos/awslabs/s2n/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awslabs/s2n/merges","archive_url":"https://api.github.com/repos/awslabs/s2n/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awslabs/s2n/downloads","issues_url":"https://api.github.com/repos/awslabs/s2n/issues{/number}","pulls_url":"https://api.github.com/repos/awslabs/s2n/pulls{/number}","milestones_url":"https://api.github.com/repos/awslabs/s2n/milestones{/number}","notifications_url":"https://api.github.com/repos/awslabs/s2n/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awslabs/s2n/labels{/name}","releases_url":"https://api.github.com/repos/awslabs/s2n/releases{/id}","created_at":"2014-06-27T19:37:59Z","updated_at":"2015-07-07T17:28:00Z","pushed_at":"2015-07-07T16:44:56Z","git_url":"git://github.com/awslabs/s2n.git","ssh_url":"git@github.com:awslabs/s2n.git","clone_url":"https://github.com/awslabs/s2n.git","svn_url":"https://github.com/awslabs/s2n","homepage":"","size":2522,"stargazers_count":1817,"watchers_count":1817,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":137,"mirror_url":null,"open_issues_count":29,"forks":137,"open_issues":29,"watchers":1817,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/awslabs/s2n/pulls/102"},"html":{"href":"https://github.com/awslabs/s2n/pull/102"},"issue":{"href":"https://api.github.com/repos/awslabs/s2n/issues/102"},"comments":{"href":"https://api.github.com/repos/awslabs/s2n/issues/102/comments"},"review_comments":{"href":"https://api.github.com/repos/awslabs/s2n/pulls/102/comments"},"review_comment":{"href":"https://api.github.com/repos/awslabs/s2n/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awslabs/s2n/pulls/102/commits"},"statuses":{"href":"https://api.github.com/repos/awslabs/s2n/statuses/7cb970332bec389fa352b90b7baa9daa0a2cbccd"}}}}