{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-reef/issues/602","labels_url":"https://api.github.com/repos/apache/incubator-reef/issues/602/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-reef/issues/602/comments","events_url":"https://api.github.com/repos/apache/incubator-reef/issues/602/events","html_url":"https://github.com/apache/incubator-reef/pull/602","id":114215059,"number":602,"title":"[REEF-892] Add javadocs and remove redundant modifiers in Wake","user":{"login":"dongjoon-hyun","id":9700541,"avatar_url":"https://avatars.githubusercontent.com/u/9700541?v=3","gravatar_id":"","url":"https://api.github.com/users/dongjoon-hyun","html_url":"https://github.com/dongjoon-hyun","followers_url":"https://api.github.com/users/dongjoon-hyun/followers","following_url":"https://api.github.com/users/dongjoon-hyun/following{/other_user}","gists_url":"https://api.github.com/users/dongjoon-hyun/gists{/gist_id}","starred_url":"https://api.github.com/users/dongjoon-hyun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dongjoon-hyun/subscriptions","organizations_url":"https://api.github.com/users/dongjoon-hyun/orgs","repos_url":"https://api.github.com/users/dongjoon-hyun/repos","events_url":"https://api.github.com/users/dongjoon-hyun/events{/privacy}","received_events_url":"https://api.github.com/users/dongjoon-hyun/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-10-30T07:09:47Z","updated_at":"2015-10-30T23:33:02Z","closed_at":"2015-10-30T18:45:33Z","pull_request":{"url":"https://api.github.com/repos/apache/incubator-reef/pulls/602","html_url":"https://github.com/apache/incubator-reef/pull/602","diff_url":"https://github.com/apache/incubator-reef/pull/602.diff","patch_url":"https://github.com/apache/incubator-reef/pull/602.patch"},"body":"This PR:\r\n  * Adds javadocs in Wake\r\n  * Removes redundant `public` in inner classes of `Clock` interface.\r\n  * Replace a few statemes to use diamond expressions\r\n  * Remove a few comment-out codes\r\n\r\nJIRA:\r\n  [REEF-892](https://issues.apache.org/jira/browse/REEF-892)\r\n\r\nPull request:\r\n  This closes #"},"comment":{"url":"https://api.github.com/repos/apache/incubator-reef/issues/comments/152673587","html_url":"https://github.com/apache/incubator-reef/pull/602#issuecomment-152673587","issue_url":"https://api.github.com/repos/apache/incubator-reef/issues/602","id":152673587,"user":{"login":"tcNickolas","id":10113024,"avatar_url":"https://avatars.githubusercontent.com/u/10113024?v=3","gravatar_id":"","url":"https://api.github.com/users/tcNickolas","html_url":"https://github.com/tcNickolas","followers_url":"https://api.github.com/users/tcNickolas/followers","following_url":"https://api.github.com/users/tcNickolas/following{/other_user}","gists_url":"https://api.github.com/users/tcNickolas/gists{/gist_id}","starred_url":"https://api.github.com/users/tcNickolas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcNickolas/subscriptions","organizations_url":"https://api.github.com/users/tcNickolas/orgs","repos_url":"https://api.github.com/users/tcNickolas/repos","events_url":"https://api.github.com/users/tcNickolas/events{/privacy}","received_events_url":"https://api.github.com/users/tcNickolas/received_events","type":"User","site_admin":false},"created_at":"2015-10-30T23:33:01Z","updated_at":"2015-10-30T23:33:01Z","body":"Checkstyle in general is enabled for modules which don't have `maven-checkstyle-plugin` in their pom.xml. Its configuration is inherited from `reef-project`'s pom file. Just try to violate some check from standard set of checks, for example, add a line over 120 characters long to one of the files in Wake, and it will dutifully fail build due to checkstyle violation. However, there might be some weird configuration issue related to use of check which is not part of standard checks set.\r\n\r\nI don't really like cloning checkstyle settings for each combination of issues we've fixed, as this makes adding new checks harder. I hope to be able to triage some more TODOs next week. For Wake project, we need to summon @bgchun to help triage https://issues.apache.org/jira/browse/REEF-535."}}