{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/scripts/pulls/comments/31473547","id":31473547,"diff_hunk":"@@ -945,9 +966,19 @@ EOF\n }\n \n _write_ova_bundle() {\n-    vmdk-convert ${VM_DST_IMG} ${VM_TMP_DIR}/vm.vmdk\n-    ( cd $(_dst_dir) && mkova.sh $(_dst_name) ${VM_TMP_DIR}/vm.vmdk ${BUILD_LIBRARY_DIR}/template.ovf)\n-    VM_GENERATED_FILES+=$(_dst_dir)/$(_dst_name \".ova\")\n+    local mf=\"$(_dst_name \".mf\")\"\n+    local vmdk=\"$(basename ${VM_DST_IMG})\"\n+    local ovf=$(_dst_name \".ovf\")\n+\n+    vmdk-convert \"${VM_DST_IMG}\" \"${VM_TMP_DIR}/${vmdk}\"","path":"build_library/vm_image_util.sh","position":91,"original_position":91,"commit_id":"e76c69380352a4636bddc02195cc4ce3229c0f76","original_commit_id":"e76c69380352a4636bddc02195cc4ce3229c0f76","user":{"login":"marineam","id":153640,"avatar_url":"https://avatars.githubusercontent.com/u/153640?v=3","gravatar_id":"","url":"https://api.github.com/users/marineam","html_url":"https://github.com/marineam","followers_url":"https://api.github.com/users/marineam/followers","following_url":"https://api.github.com/users/marineam/following{/other_user}","gists_url":"https://api.github.com/users/marineam/gists{/gist_id}","starred_url":"https://api.github.com/users/marineam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marineam/subscriptions","organizations_url":"https://api.github.com/users/marineam/orgs","repos_url":"https://api.github.com/users/marineam/repos","events_url":"https://api.github.com/users/marineam/events{/privacy}","received_events_url":"https://api.github.com/users/marineam/received_events","type":"User","site_admin":false},"body":"once `....DISK_FORMAT=vmdk_stream` is set turn this line into a `ln`","created_at":"2015-06-01T21:39:57Z","updated_at":"2015-06-01T21:39:57Z","html_url":"https://github.com/coreos/scripts/pull/413#discussion_r31473547","pull_request_url":"https://api.github.com/repos/coreos/scripts/pulls/413","_links":{"self":{"href":"https://api.github.com/repos/coreos/scripts/pulls/comments/31473547"},"html":{"href":"https://github.com/coreos/scripts/pull/413#discussion_r31473547"},"pull_request":{"href":"https://api.github.com/repos/coreos/scripts/pulls/413"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/scripts/pulls/413","id":36261332,"html_url":"https://github.com/coreos/scripts/pull/413","diff_url":"https://github.com/coreos/scripts/pull/413.diff","patch_url":"https://github.com/coreos/scripts/pull/413.patch","issue_url":"https://api.github.com/repos/coreos/scripts/issues/413","number":413,"state":"open","locked":false,"title":"build_library: various VMware improvements","user":{"login":"crawford","id":368848,"avatar_url":"https://avatars.githubusercontent.com/u/368848?v=3","gravatar_id":"","url":"https://api.github.com/users/crawford","html_url":"https://github.com/crawford","followers_url":"https://api.github.com/users/crawford/followers","following_url":"https://api.github.com/users/crawford/following{/other_user}","gists_url":"https://api.github.com/users/crawford/gists{/gist_id}","starred_url":"https://api.github.com/users/crawford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crawford/subscriptions","organizations_url":"https://api.github.com/users/crawford/orgs","repos_url":"https://api.github.com/users/crawford/repos","events_url":"https://api.github.com/users/crawford/events{/privacy}","received_events_url":"https://api.github.com/users/crawford/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-05-27T01:22:04Z","updated_at":"2015-06-01T21:39:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee474e05375bebd3921e737244bd37041613f851","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/coreos/scripts/pulls/413/commits","review_comments_url":"https://api.github.com/repos/coreos/scripts/pulls/413/comments","review_comment_url":"https://api.github.com/repos/coreos/scripts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/scripts/issues/413/comments","statuses_url":"https://api.github.com/repos/coreos/scripts/statuses/e76c69380352a4636bddc02195cc4ce3229c0f76","head":{"label":"crawford:vmx","ref":"vmx","sha":"e76c69380352a4636bddc02195cc4ce3229c0f76","user":{"login":"crawford","id":368848,"avatar_url":"https://avatars.githubusercontent.com/u/368848?v=3","gravatar_id":"","url":"https://api.github.com/users/crawford","html_url":"https://github.com/crawford","followers_url":"https://api.github.com/users/crawford/followers","following_url":"https://api.github.com/users/crawford/following{/other_user}","gists_url":"https://api.github.com/users/crawford/gists{/gist_id}","starred_url":"https://api.github.com/users/crawford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crawford/subscriptions","organizations_url":"https://api.github.com/users/crawford/orgs","repos_url":"https://api.github.com/users/crawford/repos","events_url":"https://api.github.com/users/crawford/events{/privacy}","received_events_url":"https://api.github.com/users/crawford/received_events","type":"User","site_admin":false},"repo":{"id":18581356,"name":"scripts","full_name":"crawford/scripts","owner":{"login":"crawford","id":368848,"avatar_url":"https://avatars.githubusercontent.com/u/368848?v=3","gravatar_id":"","url":"https://api.github.com/users/crawford","html_url":"https://github.com/crawford","followers_url":"https://api.github.com/users/crawford/followers","following_url":"https://api.github.com/users/crawford/following{/other_user}","gists_url":"https://api.github.com/users/crawford/gists{/gist_id}","starred_url":"https://api.github.com/users/crawford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crawford/subscriptions","organizations_url":"https://api.github.com/users/crawford/orgs","repos_url":"https://api.github.com/users/crawford/repos","events_url":"https://api.github.com/users/crawford/events{/privacy}","received_events_url":"https://api.github.com/users/crawford/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/crawford/scripts","description":"Build and maintenance scripts for CoreOS","fork":true,"url":"https://api.github.com/repos/crawford/scripts","forks_url":"https://api.github.com/repos/crawford/scripts/forks","keys_url":"https://api.github.com/repos/crawford/scripts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crawford/scripts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crawford/scripts/teams","hooks_url":"https://api.github.com/repos/crawford/scripts/hooks","issue_events_url":"https://api.github.com/repos/crawford/scripts/issues/events{/number}","events_url":"https://api.github.com/repos/crawford/scripts/events","assignees_url":"https://api.github.com/repos/crawford/scripts/assignees{/user}","branches_url":"https://api.github.com/repos/crawford/scripts/branches{/branch}","tags_url":"https://api.github.com/repos/crawford/scripts/tags","blobs_url":"https://api.github.com/repos/crawford/scripts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crawford/scripts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crawford/scripts/git/refs{/sha}","trees_url":"https://api.github.com/repos/crawford/scripts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crawford/scripts/statuses/{sha}","languages_url":"https://api.github.com/repos/crawford/scripts/languages","stargazers_url":"https://api.github.com/repos/crawford/scripts/stargazers","contributors_url":"https://api.github.com/repos/crawford/scripts/contributors","subscribers_url":"https://api.github.com/repos/crawford/scripts/subscribers","subscription_url":"https://api.github.com/repos/crawford/scripts/subscription","commits_url":"https://api.github.com/repos/crawford/scripts/commits{/sha}","git_commits_url":"https://api.github.com/repos/crawford/scripts/git/commits{/sha}","comments_url":"https://api.github.com/repos/crawford/scripts/comments{/number}","issue_comment_url":"https://api.github.com/repos/crawford/scripts/issues/comments{/number}","contents_url":"https://api.github.com/repos/crawford/scripts/contents/{+path}","compare_url":"https://api.github.com/repos/crawford/scripts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crawford/scripts/merges","archive_url":"https://api.github.com/repos/crawford/scripts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crawford/scripts/downloads","issues_url":"https://api.github.com/repos/crawford/scripts/issues{/number}","pulls_url":"https://api.github.com/repos/crawford/scripts/pulls{/number}","milestones_url":"https://api.github.com/repos/crawford/scripts/milestones{/number}","notifications_url":"https://api.github.com/repos/crawford/scripts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crawford/scripts/labels{/name}","releases_url":"https://api.github.com/repos/crawford/scripts/releases{/id}","created_at":"2014-04-09T01:40:05Z","updated_at":"2014-06-19T21:13:20Z","pushed_at":"2015-05-27T17:50:25Z","git_url":"git://github.com/crawford/scripts.git","ssh_url":"git@github.com:crawford/scripts.git","clone_url":"https://github.com/crawford/scripts.git","svn_url":"https://github.com/crawford/scripts","homepage":"http://coreos.com/docs/sdk/","size":8106,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"219a325b7a181fd260a8e2d34ba06dd9b4ae6b06","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":8488880,"name":"scripts","full_name":"coreos/scripts","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/scripts","description":"Build and maintenance scripts for CoreOS","fork":false,"url":"https://api.github.com/repos/coreos/scripts","forks_url":"https://api.github.com/repos/coreos/scripts/forks","keys_url":"https://api.github.com/repos/coreos/scripts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/scripts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/scripts/teams","hooks_url":"https://api.github.com/repos/coreos/scripts/hooks","issue_events_url":"https://api.github.com/repos/coreos/scripts/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/scripts/events","assignees_url":"https://api.github.com/repos/coreos/scripts/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/scripts/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/scripts/tags","blobs_url":"https://api.github.com/repos/coreos/scripts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/scripts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/scripts/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/scripts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/scripts/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/scripts/languages","stargazers_url":"https://api.github.com/repos/coreos/scripts/stargazers","contributors_url":"https://api.github.com/repos/coreos/scripts/contributors","subscribers_url":"https://api.github.com/repos/coreos/scripts/subscribers","subscription_url":"https://api.github.com/repos/coreos/scripts/subscription","commits_url":"https://api.github.com/repos/coreos/scripts/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/scripts/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/scripts/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/scripts/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/scripts/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/scripts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/scripts/merges","archive_url":"https://api.github.com/repos/coreos/scripts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/scripts/downloads","issues_url":"https://api.github.com/repos/coreos/scripts/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/scripts/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/scripts/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/scripts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/scripts/labels{/name}","releases_url":"https://api.github.com/repos/coreos/scripts/releases{/id}","created_at":"2013-02-28T21:45:57Z","updated_at":"2015-05-20T18:56:59Z","pushed_at":"2015-05-28T00:36:21Z","git_url":"git://github.com/coreos/scripts.git","ssh_url":"git@github.com:coreos/scripts.git","clone_url":"https://github.com/coreos/scripts.git","svn_url":"https://github.com/coreos/scripts","homepage":"http://coreos.com/docs/sdk/","size":10351,"stargazers_count":50,"watchers_count":50,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":53,"mirror_url":null,"open_issues_count":6,"forks":53,"open_issues":6,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/scripts/pulls/413"},"html":{"href":"https://github.com/coreos/scripts/pull/413"},"issue":{"href":"https://api.github.com/repos/coreos/scripts/issues/413"},"comments":{"href":"https://api.github.com/repos/coreos/scripts/issues/413/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/scripts/pulls/413/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/scripts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/scripts/pulls/413/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/scripts/statuses/e76c69380352a4636bddc02195cc4ce3229c0f76"}}}}