{"action":"created","issue":{"url":"https://api.github.com/repos/palantir/tslint/issues/601","labels_url":"https://api.github.com/repos/palantir/tslint/issues/601/labels{/name}","comments_url":"https://api.github.com/repos/palantir/tslint/issues/601/comments","events_url":"https://api.github.com/repos/palantir/tslint/issues/601/events","html_url":"https://github.com/palantir/tslint/pull/601","id":102794978,"number":601,"title":"Fix for no-internal-module rule","user":{"login":"vmmitev","id":1255804,"avatar_url":"https://avatars.githubusercontent.com/u/1255804?v=3","gravatar_id":"","url":"https://api.github.com/users/vmmitev","html_url":"https://github.com/vmmitev","followers_url":"https://api.github.com/users/vmmitev/followers","following_url":"https://api.github.com/users/vmmitev/following{/other_user}","gists_url":"https://api.github.com/users/vmmitev/gists{/gist_id}","starred_url":"https://api.github.com/users/vmmitev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmmitev/subscriptions","organizations_url":"https://api.github.com/users/vmmitev/orgs","repos_url":"https://api.github.com/users/vmmitev/repos","events_url":"https://api.github.com/users/vmmitev/events{/privacy}","received_events_url":"https://api.github.com/users/vmmitev/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/palantir/tslint/labels/PR:%20Needs%20Revision","name":"PR: Needs Revision","color":"FBEA92"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":16,"created_at":"2015-08-24T13:38:18Z","updated_at":"2015-08-31T21:47:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/palantir/tslint/pulls/601","html_url":"https://github.com/palantir/tslint/pull/601","diff_url":"https://github.com/palantir/tslint/pull/601.diff","patch_url":"https://github.com/palantir/tslint/pull/601.patch"},"body":"Fix proposal for issue #600 \r\n\r\n**Personal note:** I think the better approach to fixing this issue is to have the nodes representing the nested sub-paths in the namespace have the correct flag type `ts.NodeFlags.Namespace` instead of having to recurse for their parent which has it. Currently they have `ts.NodeFlags.Export` as their `flags` property's value. However, I wanted to limit the fix to the rule's definition file, and think this is the best solution without having to tamper into the node walker internals."},"comment":{"url":"https://api.github.com/repos/palantir/tslint/issues/comments/136510465","html_url":"https://github.com/palantir/tslint/pull/601#issuecomment-136510465","issue_url":"https://api.github.com/repos/palantir/tslint/issues/601","id":136510465,"user":{"login":"adidahiya","id":723999,"avatar_url":"https://avatars.githubusercontent.com/u/723999?v=3","gravatar_id":"","url":"https://api.github.com/users/adidahiya","html_url":"https://github.com/adidahiya","followers_url":"https://api.github.com/users/adidahiya/followers","following_url":"https://api.github.com/users/adidahiya/following{/other_user}","gists_url":"https://api.github.com/users/adidahiya/gists{/gist_id}","starred_url":"https://api.github.com/users/adidahiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adidahiya/subscriptions","organizations_url":"https://api.github.com/users/adidahiya/orgs","repos_url":"https://api.github.com/users/adidahiya/repos","events_url":"https://api.github.com/users/adidahiya/events{/privacy}","received_events_url":"https://api.github.com/users/adidahiya/received_events","type":"User","site_admin":false},"created_at":"2015-08-31T21:47:01Z","updated_at":"2015-08-31T21:47:01Z","body":"thanks for asking. I'd prefer a cleaner history, so please rebase on master and try to make this just 1 commit. you can start a new PR if that's easier for you"}}