{"push_id":799174758,"size":17,"distinct_size":15,"ref":"refs/heads/override-email-problems","head":"6b81b18ebf77f1c1b306e5ee5cfc502b16174786","before":"15fd89c0450d62e71c832476efcdef79cfc871a9","commits":[{"sha":"88d70c3db8637f0204d322074d5bf5c44767cd79","author":{"email":"09fda5260b7a9d52f2f61df887c9701d5c23b7e1@gmail.com","name":"Evangelos Giataganas"},"message":"Fix deprecated class methods\n\nAccording to http://ruby-doc.org/core-2.2.0/File.html#method-c-exists-3F \nthe method `exists?` is deprecated method and `exist?` should\nbe used in its place.","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/88d70c3db8637f0204d322074d5bf5c44767cd79"},{"sha":"74147a4dac3ca309212b164298a9be5b7185fa5f","author":{"email":"05b1f356646c24bf1765f6f1b65aea3bde7247e1@bitrecursive.com","name":"Dan Palmer"},"message":"Merge pull request #303 from ministryofjustice/fix-deprecated-class-methods\n\nFix deprecated class methods","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/74147a4dac3ca309212b164298a9be5b7185fa5f"},{"sha":"d6218817b821f00b43c4bf0e2aba75d96f75d1c2","author":{"email":"53237635563790ddc44f8cd7fa42a8eb8693bfdf@gmail.com","name":"Paul Battley"},"message":"Make email validation independent of model\n\nRails-style validation isn't enough for what we want to do, which is to\nbe able to tell whether certain aspects of invalidity can be overridden.\nInstead of shoehorning this in, we'll make the EmailValidator a\nseparate object that can be interrogated by the Visitor model. In\naddition, we need to change the Feedback model, which also uses email\nvalidation.","distinct":true,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/d6218817b821f00b43c4bf0e2aba75d96f75d1c2"},{"sha":"cf6831cc5eea3315d02898e99fd497a37ce07c8b","author":{"email":"53237635563790ddc44f8cd7fa42a8eb8693bfdf@gmail.com","name":"Paul Battley"},"message":"Allow visitor to override spam/bounced email\n\nThis adds a checkbox to the visitor form to allow the visitor to force\nacceptance of an email address that was reported by Sendgrid to have\nbounced or been marked as spam. The checkbox is only displayed if\nvalidation fails for one of these two reasons.","distinct":true,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/cf6831cc5eea3315d02898e99fd497a37ce07c8b"},{"sha":"2ff080258d6e4007c655b1b339f476c49d7333e1","author":{"email":"53237635563790ddc44f8cd7fa42a8eb8693bfdf@gmail.com","name":"Paul Battley"},"message":"Only show override box on Sendgrid error","distinct":true,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/2ff080258d6e4007c655b1b339f476c49d7333e1"},{"sha":"db2e509b47b75c952a1bc2251057eceff743e1a5","author":{"email":"53237635563790ddc44f8cd7fa42a8eb8693bfdf@gmail.com","name":"Paul Battley"},"message":"Make EmailValidator say whether reset is needed","distinct":true,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/db2e509b47b75c952a1bc2251057eceff743e1a5"},{"sha":"5dca75e295de986685b95f2c227a89b733d20af8","author":{"email":"53237635563790ddc44f8cd7fa42a8eb8693bfdf@gmail.com","name":"Paul Battley"},"message":"Avoid parsing email address more than once\n\nCatching this exception to appears to be inevitable in the case of the\nMail library, but let's make sure we only do it once.","distinct":true,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/5dca75e295de986685b95f2c227a89b733d20af8"},{"sha":"95b153de3ab6b5dbcebb2438547a99b0ed2df5ea","author":{"email":"53237635563790ddc44f8cd7fa42a8eb8693bfdf@gmail.com","name":"Paul Battley"},"message":"Update email error copy to work in both contexts\n\nThey are formed into sentences at the top of the page by appending to\nthe field name, but are displayed alone after the label on the actual\nfields.","distinct":true,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/95b153de3ab6b5dbcebb2438547a99b0ed2df5ea"},{"sha":"7485781b815e5824170bf7440aab08a40cc803a9","author":{"email":"53237635563790ddc44f8cd7fa42a8eb8693bfdf@gmail.com","name":"Paul Battley"},"message":"Show CSS and JS in save_and_open_page\n\nAssuming that you have a development server running on localhost:3000,\nusing save_and_open_page in a Capybara spec will now show a page with\nall the assets loaded.","distinct":true,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/7485781b815e5824170bf7440aab08a40cc803a9"},{"sha":"f5e436f2fdfee1febc27f5465ac1bf321bc4bcbb","author":{"email":"53237635563790ddc44f8cd7fa42a8eb8693bfdf@gmail.com","name":"Paul Battley"},"message":"Use basic Ruby modules to share methods\n\nThe methods in FeaturesHelper are not shared examples, so this was both\nunnecessary and misleading.","distinct":true,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/f5e436f2fdfee1febc27f5465ac1bf321bc4bcbb"},{"sha":"9888aad3941a76c1f6a650230b0b2250263c5d99","author":{"email":"53237635563790ddc44f8cd7fa42a8eb8693bfdf@gmail.com","name":"Paul Battley"},"message":"Extract and elaborate spam override spec","distinct":true,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/9888aad3941a76c1f6a650230b0b2250263c5d99"},{"sha":"3ac85a449a59437fcaab2ed8182139fb34f3b2b9","author":{"email":"53237635563790ddc44f8cd7fa42a8eb8693bfdf@gmail.com","name":"Paul Battley"},"message":"Add end-to-end bounce override spec","distinct":true,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/3ac85a449a59437fcaab2ed8182139fb34f3b2b9"},{"sha":"564ebe139ff5361ccdf2f629fd331c53843efbda","author":{"email":"53237635563790ddc44f8cd7fa42a8eb8693bfdf@gmail.com","name":"Paul Battley"},"message":"Address Rubocop violations\n\nI believe that constructions like\n\n    def foo?\n      @foo\n    end\n\nought to be valid (see https://github.com/bbatsov/rubocop/issues/2140)\nand have altered the configuration accordingly.","distinct":true,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/564ebe139ff5361ccdf2f629fd331c53843efbda"},{"sha":"dd9caa5b9113b23a59d63212ab5fd84b8df5020d","author":{"email":"05b1f356646c24bf1765f6f1b65aea3bde7247e1@bitrecursive.com","name":"Dan Palmer"},"message":"Replace usage of SendgridHelper with SendgridApi\n\nSendgridHelper has since been removed from the application.\n\nSee commit: b71ae7253e5fdf0","distinct":true,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/dd9caa5b9113b23a59d63212ab5fd84b8df5020d"},{"sha":"678f372a937e1af6b16411aac9bc12b089b35af3","author":{"email":"05b1f356646c24bf1765f6f1b65aea3bde7247e1@bitrecursive.com","name":"Dan Palmer"},"message":"Add removal of email's from spam & bounce lists\n\nMakes use of Sendgrid Toolkits deletion feature which underneath uses\nSengrids WEB AI endpoints.\n\nBoth of these methods are required in order for a user to override the\ndefault spam and bounce checks if they believe ther email address ahs\nbeen flagged in the past.\n\nThe toolkit raises an exception when no email address is found in the\nspam or bounce list - we dont want to treat this as exceptional\ncircumstance as it will cause the delivery mechanism(background job i.e\nSidekiq) to fail and retry. Any other errors which might occur such as\nAPI Errors or parsing errors we expect to escalate to the job level thus\nfailing the job an allowing it to be retried.","distinct":true,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/678f372a937e1af6b16411aac9bc12b089b35af3"},{"sha":"b7ce5784caacbf6d051bfa534c1b23d95513b4b4","author":{"email":"05b1f356646c24bf1765f6f1b65aea3bde7247e1@bitrecursive.com","name":"Dan Palmer"},"message":"Use RSpec `describe` for specific method contexts","distinct":true,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/b7ce5784caacbf6d051bfa534c1b23d95513b4b4"},{"sha":"6b81b18ebf77f1c1b306e5ee5cfc502b16174786","author":{"email":"05b1f356646c24bf1765f6f1b65aea3bde7247e1@bitrecursive.com","name":"Dan Palmer"},"message":"Extract common boilerplate for Sendgrid Api calls","distinct":true,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/6b81b18ebf77f1c1b306e5ee5cfc502b16174786"}]}