{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/46704251","id":46704251,"diff_hunk":"@@ -17,6 +17,13 @@\n     - node\n     - .config_managed\n \n+  - fail:\n+      msg: \"Both openshift_master_session_auth_secrets and openshift_master_session_encryption_secrets must be provided if either variable is set\"\n+    when: (openshift_master_session_auth_secrets is defined and openshift_master_session_encryption_secrets is not defined) or (openshift_master_session_encryption_secrets is defined and openshift_master_session_auth_secrets is not defined)\n+  - fail:\n+      msg: \"openshift_master_session_auth_secrets and openshift_master_encryption_secrets must be equal length\"\n+    when: (openshift_master_session_auth_secrets is defined and openshift_master_session_encryption_secrets is defined) and (openshift_master_session_auth_secrets | length != openshift_master_session_encryption_secrets | length)","path":"playbooks/common/openshift-master/config.yml","position":9,"original_position":9,"commit_id":"e544bfcc4c3f63531a72d6673ddedfc0708fb8dd","original_commit_id":"e544bfcc4c3f63531a72d6673ddedfc0708fb8dd","user":{"login":"abutcher","id":47003,"avatar_url":"https://avatars.githubusercontent.com/u/47003?v=3","gravatar_id":"","url":"https://api.github.com/users/abutcher","html_url":"https://github.com/abutcher","followers_url":"https://api.github.com/users/abutcher/followers","following_url":"https://api.github.com/users/abutcher/following{/other_user}","gists_url":"https://api.github.com/users/abutcher/gists{/gist_id}","starred_url":"https://api.github.com/users/abutcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abutcher/subscriptions","organizations_url":"https://api.github.com/users/abutcher/orgs","repos_url":"https://api.github.com/users/abutcher/repos","events_url":"https://api.github.com/users/abutcher/events{/privacy}","received_events_url":"https://api.github.com/users/abutcher/received_events","type":"User","site_admin":false},"body":"@detiber Kk, seems like checks would need to be in both then","created_at":"2015-12-04T17:00:01Z","updated_at":"2015-12-04T17:00:01Z","html_url":"https://github.com/openshift/openshift-ansible/pull/1018#discussion_r46704251","pull_request_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1018","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/46704251"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/1018#discussion_r46704251"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1018"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1018","id":52597443,"html_url":"https://github.com/openshift/openshift-ansible/pull/1018","diff_url":"https://github.com/openshift/openshift-ansible/pull/1018.diff","patch_url":"https://github.com/openshift/openshift-ansible/pull/1018.patch","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/1018","number":1018,"state":"open","locked":false,"title":"WIP: Clean up idempotency issues with session secrets.","user":{"login":"abutcher","id":47003,"avatar_url":"https://avatars.githubusercontent.com/u/47003?v=3","gravatar_id":"","url":"https://api.github.com/users/abutcher","html_url":"https://github.com/abutcher","followers_url":"https://api.github.com/users/abutcher/followers","following_url":"https://api.github.com/users/abutcher/following{/other_user}","gists_url":"https://api.github.com/users/abutcher/gists{/gist_id}","starred_url":"https://api.github.com/users/abutcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abutcher/subscriptions","organizations_url":"https://api.github.com/users/abutcher/orgs","repos_url":"https://api.github.com/users/abutcher/repos","events_url":"https://api.github.com/users/abutcher/events{/privacy}","received_events_url":"https://api.github.com/users/abutcher/received_events","type":"User","site_admin":false},"body":"* Generate session secrets if they were not passed in and were not found on the first master.\r\n* Use those everywhere else.\r\n\r\nFixes at least part of #953 ","created_at":"2015-12-03T21:47:24Z","updated_at":"2015-12-04T17:00:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68adeb0a57509a1209e482ce52fe33ee1f2031a6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1018/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1018/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/1018/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/e544bfcc4c3f63531a72d6673ddedfc0708fb8dd","head":{"label":"abutcher:secrets","ref":"secrets","sha":"e544bfcc4c3f63531a72d6673ddedfc0708fb8dd","user":{"login":"abutcher","id":47003,"avatar_url":"https://avatars.githubusercontent.com/u/47003?v=3","gravatar_id":"","url":"https://api.github.com/users/abutcher","html_url":"https://github.com/abutcher","followers_url":"https://api.github.com/users/abutcher/followers","following_url":"https://api.github.com/users/abutcher/following{/other_user}","gists_url":"https://api.github.com/users/abutcher/gists{/gist_id}","starred_url":"https://api.github.com/users/abutcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abutcher/subscriptions","organizations_url":"https://api.github.com/users/abutcher/orgs","repos_url":"https://api.github.com/users/abutcher/repos","events_url":"https://api.github.com/users/abutcher/events{/privacy}","received_events_url":"https://api.github.com/users/abutcher/received_events","type":"User","site_admin":false},"repo":{"id":40020725,"name":"openshift-ansible","full_name":"abutcher/openshift-ansible","owner":{"login":"abutcher","id":47003,"avatar_url":"https://avatars.githubusercontent.com/u/47003?v=3","gravatar_id":"","url":"https://api.github.com/users/abutcher","html_url":"https://github.com/abutcher","followers_url":"https://api.github.com/users/abutcher/followers","following_url":"https://api.github.com/users/abutcher/following{/other_user}","gists_url":"https://api.github.com/users/abutcher/gists{/gist_id}","starred_url":"https://api.github.com/users/abutcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abutcher/subscriptions","organizations_url":"https://api.github.com/users/abutcher/orgs","repos_url":"https://api.github.com/users/abutcher/repos","events_url":"https://api.github.com/users/abutcher/events{/privacy}","received_events_url":"https://api.github.com/users/abutcher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abutcher/openshift-ansible","description":"OpenShift Ansible Code","fork":true,"url":"https://api.github.com/repos/abutcher/openshift-ansible","forks_url":"https://api.github.com/repos/abutcher/openshift-ansible/forks","keys_url":"https://api.github.com/repos/abutcher/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abutcher/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abutcher/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/abutcher/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/abutcher/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/abutcher/openshift-ansible/events","assignees_url":"https://api.github.com/repos/abutcher/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/abutcher/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/abutcher/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/abutcher/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abutcher/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abutcher/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/abutcher/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abutcher/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/abutcher/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/abutcher/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/abutcher/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/abutcher/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/abutcher/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/abutcher/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/abutcher/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/abutcher/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/abutcher/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/abutcher/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/abutcher/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abutcher/openshift-ansible/merges","archive_url":"https://api.github.com/repos/abutcher/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abutcher/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/abutcher/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/abutcher/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/abutcher/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/abutcher/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abutcher/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/abutcher/openshift-ansible/releases{/id}","created_at":"2015-07-31T19:07:31Z","updated_at":"2015-07-31T19:07:33Z","pushed_at":"2015-12-04T16:37:52Z","git_url":"git://github.com/abutcher/openshift-ansible.git","ssh_url":"git@github.com:abutcher/openshift-ansible.git","clone_url":"https://github.com/abutcher/openshift-ansible.git","svn_url":"https://github.com/abutcher/openshift-ansible","homepage":"","size":2295,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"64d40b71f3b52b69999831a7d6e13916ec5ad1cd","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":24109199,"name":"openshift-ansible","full_name":"openshift/openshift-ansible","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-ansible","description":"OpenShift Ansible Code","fork":false,"url":"https://api.github.com/repos/openshift/openshift-ansible","forks_url":"https://api.github.com/repos/openshift/openshift-ansible/forks","keys_url":"https://api.github.com/repos/openshift/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-ansible/events","assignees_url":"https://api.github.com/repos/openshift/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-ansible/merges","archive_url":"https://api.github.com/repos/openshift/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-ansible/releases{/id}","created_at":"2014-09-16T17:07:51Z","updated_at":"2015-12-03T15:03:56Z","pushed_at":"2015-12-04T16:48:33Z","git_url":"git://github.com/openshift/openshift-ansible.git","ssh_url":"git@github.com:openshift/openshift-ansible.git","clone_url":"https://github.com/openshift/openshift-ansible.git","svn_url":"https://github.com/openshift/openshift-ansible","homepage":"install.openshift.com","size":3174,"stargazers_count":94,"watchers_count":94,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":173,"mirror_url":null,"open_issues_count":163,"forks":173,"open_issues":163,"watchers":94,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1018"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/1018"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/1018"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/1018/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1018/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1018/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-ansible/statuses/e544bfcc4c3f63531a72d6673ddedfc0708fb8dd"}}}}