{"action":"closed","number":920,"pull_request":{"url":"https://api.github.com/repos/opal/opal/pulls/920","id":37109193,"html_url":"https://github.com/opal/opal/pull/920","diff_url":"https://github.com/opal/opal/pull/920.diff","patch_url":"https://github.com/opal/opal/pull/920.patch","issue_url":"https://api.github.com/repos/opal/opal/issues/920","number":920,"state":"closed","locked":false,"title":"Using ruby/rubyspec for RubySpec","user":{"login":"eregon","id":168854,"avatar_url":"https://avatars.githubusercontent.com/u/168854?v=3","gravatar_id":"","url":"https://api.github.com/users/eregon","html_url":"https://github.com/eregon","followers_url":"https://api.github.com/users/eregon/followers","following_url":"https://api.github.com/users/eregon/following{/other_user}","gists_url":"https://api.github.com/users/eregon/gists{/gist_id}","starred_url":"https://api.github.com/users/eregon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eregon/subscriptions","organizations_url":"https://api.github.com/users/eregon/orgs","repos_url":"https://api.github.com/users/eregon/repos","events_url":"https://api.github.com/users/eregon/events{/privacy}","received_events_url":"https://api.github.com/users/eregon/received_events","type":"User","site_admin":false},"body":"Hello,\r\n\r\nHere is a quick PR to discuss about using ruby/rubyspec directly, if that is what the Opal team wants.\r\nThis is not ready for merging as there are new failures due to new specs.\r\n\r\nUsing git submodule provides a very good isolation between specs and the rest, but also makes the process to change specs a bit rigid.\r\nIf changes to rubyspec are done mostly by a few people (@elia and @vais from what I saw), one solution is to allow these people to push directly to ruby/rubyspec for straightforward changes (and PR if not).\r\n\r\nAnother solution is to have a copy of rubyspec in the opal repository (with git subtree or manually) and integrate these changes upstream from time to time. This is more complex and messy but useful if many different people contribute directly to the specs.\r\n\r\nWhat do you think?\r\n\r\nP.S.: There are quite a few new failures due to new specs, do you have an automated way to tag them or is it done manually?","created_at":"2015-06-07T16:23:10Z","updated_at":"2015-06-09T05:07:23Z","closed_at":"2015-06-09T05:07:23Z","merged_at":null,"merge_commit_sha":"bb54b0507be3d7d6e90b28393bb4eb4efd9b86de","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opal/opal/pulls/920/commits","review_comments_url":"https://api.github.com/repos/opal/opal/pulls/920/comments","review_comment_url":"https://api.github.com/repos/opal/opal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opal/opal/issues/920/comments","statuses_url":"https://api.github.com/repos/opal/opal/statuses/f63eb1d88b2b9c7bc9ccca4dd02e87dee5fc0bfd","head":{"label":"eregon:use_ruby_rubyspec","ref":"use_ruby_rubyspec","sha":"f63eb1d88b2b9c7bc9ccca4dd02e87dee5fc0bfd","user":{"login":"eregon","id":168854,"avatar_url":"https://avatars.githubusercontent.com/u/168854?v=3","gravatar_id":"","url":"https://api.github.com/users/eregon","html_url":"https://github.com/eregon","followers_url":"https://api.github.com/users/eregon/followers","following_url":"https://api.github.com/users/eregon/following{/other_user}","gists_url":"https://api.github.com/users/eregon/gists{/gist_id}","starred_url":"https://api.github.com/users/eregon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eregon/subscriptions","organizations_url":"https://api.github.com/users/eregon/orgs","repos_url":"https://api.github.com/users/eregon/repos","events_url":"https://api.github.com/users/eregon/events{/privacy}","received_events_url":"https://api.github.com/users/eregon/received_events","type":"User","site_admin":false},"repo":{"id":36991184,"name":"opal","full_name":"eregon/opal","owner":{"login":"eregon","id":168854,"avatar_url":"https://avatars.githubusercontent.com/u/168854?v=3","gravatar_id":"","url":"https://api.github.com/users/eregon","html_url":"https://github.com/eregon","followers_url":"https://api.github.com/users/eregon/followers","following_url":"https://api.github.com/users/eregon/following{/other_user}","gists_url":"https://api.github.com/users/eregon/gists{/gist_id}","starred_url":"https://api.github.com/users/eregon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eregon/subscriptions","organizations_url":"https://api.github.com/users/eregon/orgs","repos_url":"https://api.github.com/users/eregon/repos","events_url":"https://api.github.com/users/eregon/events{/privacy}","received_events_url":"https://api.github.com/users/eregon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eregon/opal","description":"Ruby to Javascript compiler","fork":true,"url":"https://api.github.com/repos/eregon/opal","forks_url":"https://api.github.com/repos/eregon/opal/forks","keys_url":"https://api.github.com/repos/eregon/opal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eregon/opal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eregon/opal/teams","hooks_url":"https://api.github.com/repos/eregon/opal/hooks","issue_events_url":"https://api.github.com/repos/eregon/opal/issues/events{/number}","events_url":"https://api.github.com/repos/eregon/opal/events","assignees_url":"https://api.github.com/repos/eregon/opal/assignees{/user}","branches_url":"https://api.github.com/repos/eregon/opal/branches{/branch}","tags_url":"https://api.github.com/repos/eregon/opal/tags","blobs_url":"https://api.github.com/repos/eregon/opal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eregon/opal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eregon/opal/git/refs{/sha}","trees_url":"https://api.github.com/repos/eregon/opal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eregon/opal/statuses/{sha}","languages_url":"https://api.github.com/repos/eregon/opal/languages","stargazers_url":"https://api.github.com/repos/eregon/opal/stargazers","contributors_url":"https://api.github.com/repos/eregon/opal/contributors","subscribers_url":"https://api.github.com/repos/eregon/opal/subscribers","subscription_url":"https://api.github.com/repos/eregon/opal/subscription","commits_url":"https://api.github.com/repos/eregon/opal/commits{/sha}","git_commits_url":"https://api.github.com/repos/eregon/opal/git/commits{/sha}","comments_url":"https://api.github.com/repos/eregon/opal/comments{/number}","issue_comment_url":"https://api.github.com/repos/eregon/opal/issues/comments{/number}","contents_url":"https://api.github.com/repos/eregon/opal/contents/{+path}","compare_url":"https://api.github.com/repos/eregon/opal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eregon/opal/merges","archive_url":"https://api.github.com/repos/eregon/opal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eregon/opal/downloads","issues_url":"https://api.github.com/repos/eregon/opal/issues{/number}","pulls_url":"https://api.github.com/repos/eregon/opal/pulls{/number}","milestones_url":"https://api.github.com/repos/eregon/opal/milestones{/number}","notifications_url":"https://api.github.com/repos/eregon/opal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eregon/opal/labels{/name}","releases_url":"https://api.github.com/repos/eregon/opal/releases{/id}","created_at":"2015-06-06T18:44:13Z","updated_at":"2015-06-06T18:44:16Z","pushed_at":"2015-06-08T08:50:49Z","git_url":"git://github.com/eregon/opal.git","ssh_url":"git@github.com:eregon/opal.git","clone_url":"https://github.com/eregon/opal.git","svn_url":"https://github.com/eregon/opal","homepage":"http://opalrb.org","size":9634,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opal:master","ref":"master","sha":"e1fc9014acb96f02eafbc2eb8761b169e8924191","user":{"login":"opal","id":842643,"avatar_url":"https://avatars.githubusercontent.com/u/842643?v=3","gravatar_id":"","url":"https://api.github.com/users/opal","html_url":"https://github.com/opal","followers_url":"https://api.github.com/users/opal/followers","following_url":"https://api.github.com/users/opal/following{/other_user}","gists_url":"https://api.github.com/users/opal/gists{/gist_id}","starred_url":"https://api.github.com/users/opal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opal/subscriptions","organizations_url":"https://api.github.com/users/opal/orgs","repos_url":"https://api.github.com/users/opal/repos","events_url":"https://api.github.com/users/opal/events{/privacy}","received_events_url":"https://api.github.com/users/opal/received_events","type":"Organization","site_admin":false},"repo":{"id":184366,"name":"opal","full_name":"opal/opal","owner":{"login":"opal","id":842643,"avatar_url":"https://avatars.githubusercontent.com/u/842643?v=3","gravatar_id":"","url":"https://api.github.com/users/opal","html_url":"https://github.com/opal","followers_url":"https://api.github.com/users/opal/followers","following_url":"https://api.github.com/users/opal/following{/other_user}","gists_url":"https://api.github.com/users/opal/gists{/gist_id}","starred_url":"https://api.github.com/users/opal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opal/subscriptions","organizations_url":"https://api.github.com/users/opal/orgs","repos_url":"https://api.github.com/users/opal/repos","events_url":"https://api.github.com/users/opal/events{/privacy}","received_events_url":"https://api.github.com/users/opal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opal/opal","description":"Ruby to Javascript compiler","fork":false,"url":"https://api.github.com/repos/opal/opal","forks_url":"https://api.github.com/repos/opal/opal/forks","keys_url":"https://api.github.com/repos/opal/opal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opal/opal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opal/opal/teams","hooks_url":"https://api.github.com/repos/opal/opal/hooks","issue_events_url":"https://api.github.com/repos/opal/opal/issues/events{/number}","events_url":"https://api.github.com/repos/opal/opal/events","assignees_url":"https://api.github.com/repos/opal/opal/assignees{/user}","branches_url":"https://api.github.com/repos/opal/opal/branches{/branch}","tags_url":"https://api.github.com/repos/opal/opal/tags","blobs_url":"https://api.github.com/repos/opal/opal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opal/opal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opal/opal/git/refs{/sha}","trees_url":"https://api.github.com/repos/opal/opal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opal/opal/statuses/{sha}","languages_url":"https://api.github.com/repos/opal/opal/languages","stargazers_url":"https://api.github.com/repos/opal/opal/stargazers","contributors_url":"https://api.github.com/repos/opal/opal/contributors","subscribers_url":"https://api.github.com/repos/opal/opal/subscribers","subscription_url":"https://api.github.com/repos/opal/opal/subscription","commits_url":"https://api.github.com/repos/opal/opal/commits{/sha}","git_commits_url":"https://api.github.com/repos/opal/opal/git/commits{/sha}","comments_url":"https://api.github.com/repos/opal/opal/comments{/number}","issue_comment_url":"https://api.github.com/repos/opal/opal/issues/comments{/number}","contents_url":"https://api.github.com/repos/opal/opal/contents/{+path}","compare_url":"https://api.github.com/repos/opal/opal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opal/opal/merges","archive_url":"https://api.github.com/repos/opal/opal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opal/opal/downloads","issues_url":"https://api.github.com/repos/opal/opal/issues{/number}","pulls_url":"https://api.github.com/repos/opal/opal/pulls{/number}","milestones_url":"https://api.github.com/repos/opal/opal/milestones{/number}","notifications_url":"https://api.github.com/repos/opal/opal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opal/opal/labels{/name}","releases_url":"https://api.github.com/repos/opal/opal/releases{/id}","created_at":"2009-04-24T08:53:34Z","updated_at":"2015-06-09T01:49:38Z","pushed_at":"2015-06-09T04:59:56Z","git_url":"git://github.com/opal/opal.git","ssh_url":"git@github.com:opal/opal.git","clone_url":"https://github.com/opal/opal.git","svn_url":"https://github.com/opal/opal","homepage":"http://opalrb.org","size":20673,"stargazers_count":2550,"watchers_count":2550,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":159,"mirror_url":null,"open_issues_count":112,"forks":159,"open_issues":112,"watchers":2550,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opal/opal/pulls/920"},"html":{"href":"https://github.com/opal/opal/pull/920"},"issue":{"href":"https://api.github.com/repos/opal/opal/issues/920"},"comments":{"href":"https://api.github.com/repos/opal/opal/issues/920/comments"},"review_comments":{"href":"https://api.github.com/repos/opal/opal/pulls/920/comments"},"review_comment":{"href":"https://api.github.com/repos/opal/opal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opal/opal/pulls/920/commits"},"statuses":{"href":"https://api.github.com/repos/opal/opal/statuses/f63eb1d88b2b9c7bc9ccca4dd02e87dee5fc0bfd"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":7,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":2}}