{"action":"created","comment":{"url":"https://api.github.com/repos/bolt/bolt/pulls/comments/31153885","id":31153885,"diff_hunk":"@@ -4,7 +4,7 @@\n use Symfony\\Component\\HttpFoundation\\Request;\n \n /**\n- * Zone constants class to define whic part of the Bolt site that a request is\n+ * Zone constants class to define which part of the Bolt site that a request is\n  * relative to.","path":"src/Controller/Zone.php","position":6,"original_position":6,"commit_id":"4579340e5c1f707a6a0c1b2257efd19ea1400a19","original_commit_id":"4579340e5c1f707a6a0c1b2257efd19ea1400a19","user":{"login":"GawainLynch","id":1427081,"avatar_url":"https://avatars.githubusercontent.com/u/1427081?v=3","gravatar_id":"","url":"https://api.github.com/users/GawainLynch","html_url":"https://github.com/GawainLynch","followers_url":"https://api.github.com/users/GawainLynch/followers","following_url":"https://api.github.com/users/GawainLynch/following{/other_user}","gists_url":"https://api.github.com/users/GawainLynch/gists{/gist_id}","starred_url":"https://api.github.com/users/GawainLynch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GawainLynch/subscriptions","organizations_url":"https://api.github.com/users/GawainLynch/orgs","repos_url":"https://api.github.com/users/GawainLynch/repos","events_url":"https://api.github.com/users/GawainLynch/events{/privacy}","received_events_url":"https://api.github.com/users/GawainLynch/received_events","type":"User","site_admin":false},"body":"Why add the 'h'?","created_at":"2015-05-27T16:41:40Z","updated_at":"2015-05-27T16:41:40Z","html_url":"https://github.com/bolt/bolt/pull/3584#discussion_r31153885","pull_request_url":"https://api.github.com/repos/bolt/bolt/pulls/3584","_links":{"self":{"href":"https://api.github.com/repos/bolt/bolt/pulls/comments/31153885"},"html":{"href":"https://github.com/bolt/bolt/pull/3584#discussion_r31153885"},"pull_request":{"href":"https://api.github.com/repos/bolt/bolt/pulls/3584"}}},"pull_request":{"url":"https://api.github.com/repos/bolt/bolt/pulls/3584","id":36314751,"html_url":"https://github.com/bolt/bolt/pull/3584","diff_url":"https://github.com/bolt/bolt/pull/3584.diff","patch_url":"https://github.com/bolt/bolt/pull/3584.patch","issue_url":"https://api.github.com/repos/bolt/bolt/issues/3584","number":3584,"state":"open","locked":false,"title":"Deprecate Config::getWhichEnd","user":{"login":"CarsonF","id":932566,"avatar_url":"https://avatars.githubusercontent.com/u/932566?v=3","gravatar_id":"","url":"https://api.github.com/users/CarsonF","html_url":"https://github.com/CarsonF","followers_url":"https://api.github.com/users/CarsonF/followers","following_url":"https://api.github.com/users/CarsonF/following{/other_user}","gists_url":"https://api.github.com/users/CarsonF/gists{/gist_id}","starred_url":"https://api.github.com/users/CarsonF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CarsonF/subscriptions","organizations_url":"https://api.github.com/users/CarsonF/orgs","repos_url":"https://api.github.com/users/CarsonF/repos","events_url":"https://api.github.com/users/CarsonF/events{/privacy}","received_events_url":"https://api.github.com/users/CarsonF/received_events","type":"User","site_admin":false},"body":"Updated Config::getWhichEnd to use ZoneGuesser and deprecated it.\nAlso, deprecated `$app['end']`, but there is no way to note that other than the comment.\n\nI tried to document a clear way foward for those trying to use it.\n\nNote: _cli_ is not a Zone, because this doesn't really make sense. It is a simple check and completely unrelated to Request.\n\nConfig::getTwigPath is next :gun:","created_at":"2015-05-27T15:16:12Z","updated_at":"2015-05-27T16:41:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e39339b19f80519791f7a22e95c30ef791b82220","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bolt/bolt/pulls/3584/commits","review_comments_url":"https://api.github.com/repos/bolt/bolt/pulls/3584/comments","review_comment_url":"https://api.github.com/repos/bolt/bolt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bolt/bolt/issues/3584/comments","statuses_url":"https://api.github.com/repos/bolt/bolt/statuses/4579340e5c1f707a6a0c1b2257efd19ea1400a19","head":{"label":"CarsonF:config-get-which-end","ref":"config-get-which-end","sha":"4579340e5c1f707a6a0c1b2257efd19ea1400a19","user":{"login":"CarsonF","id":932566,"avatar_url":"https://avatars.githubusercontent.com/u/932566?v=3","gravatar_id":"","url":"https://api.github.com/users/CarsonF","html_url":"https://github.com/CarsonF","followers_url":"https://api.github.com/users/CarsonF/followers","following_url":"https://api.github.com/users/CarsonF/following{/other_user}","gists_url":"https://api.github.com/users/CarsonF/gists{/gist_id}","starred_url":"https://api.github.com/users/CarsonF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CarsonF/subscriptions","organizations_url":"https://api.github.com/users/CarsonF/orgs","repos_url":"https://api.github.com/users/CarsonF/repos","events_url":"https://api.github.com/users/CarsonF/events{/privacy}","received_events_url":"https://api.github.com/users/CarsonF/received_events","type":"User","site_admin":false},"repo":{"id":34294575,"name":"bolt","full_name":"CarsonF/bolt","owner":{"login":"CarsonF","id":932566,"avatar_url":"https://avatars.githubusercontent.com/u/932566?v=3","gravatar_id":"","url":"https://api.github.com/users/CarsonF","html_url":"https://github.com/CarsonF","followers_url":"https://api.github.com/users/CarsonF/followers","following_url":"https://api.github.com/users/CarsonF/following{/other_user}","gists_url":"https://api.github.com/users/CarsonF/gists{/gist_id}","starred_url":"https://api.github.com/users/CarsonF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CarsonF/subscriptions","organizations_url":"https://api.github.com/users/CarsonF/orgs","repos_url":"https://api.github.com/users/CarsonF/repos","events_url":"https://api.github.com/users/CarsonF/events{/privacy}","received_events_url":"https://api.github.com/users/CarsonF/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CarsonF/bolt","description":"Bolt is a simple CMS written in PHP. It is based on Silex and Symfony components, uses Twig and either SQLite, MySQL or PostgreSQL.","fork":true,"url":"https://api.github.com/repos/CarsonF/bolt","forks_url":"https://api.github.com/repos/CarsonF/bolt/forks","keys_url":"https://api.github.com/repos/CarsonF/bolt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CarsonF/bolt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CarsonF/bolt/teams","hooks_url":"https://api.github.com/repos/CarsonF/bolt/hooks","issue_events_url":"https://api.github.com/repos/CarsonF/bolt/issues/events{/number}","events_url":"https://api.github.com/repos/CarsonF/bolt/events","assignees_url":"https://api.github.com/repos/CarsonF/bolt/assignees{/user}","branches_url":"https://api.github.com/repos/CarsonF/bolt/branches{/branch}","tags_url":"https://api.github.com/repos/CarsonF/bolt/tags","blobs_url":"https://api.github.com/repos/CarsonF/bolt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CarsonF/bolt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CarsonF/bolt/git/refs{/sha}","trees_url":"https://api.github.com/repos/CarsonF/bolt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CarsonF/bolt/statuses/{sha}","languages_url":"https://api.github.com/repos/CarsonF/bolt/languages","stargazers_url":"https://api.github.com/repos/CarsonF/bolt/stargazers","contributors_url":"https://api.github.com/repos/CarsonF/bolt/contributors","subscribers_url":"https://api.github.com/repos/CarsonF/bolt/subscribers","subscription_url":"https://api.github.com/repos/CarsonF/bolt/subscription","commits_url":"https://api.github.com/repos/CarsonF/bolt/commits{/sha}","git_commits_url":"https://api.github.com/repos/CarsonF/bolt/git/commits{/sha}","comments_url":"https://api.github.com/repos/CarsonF/bolt/comments{/number}","issue_comment_url":"https://api.github.com/repos/CarsonF/bolt/issues/comments{/number}","contents_url":"https://api.github.com/repos/CarsonF/bolt/contents/{+path}","compare_url":"https://api.github.com/repos/CarsonF/bolt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CarsonF/bolt/merges","archive_url":"https://api.github.com/repos/CarsonF/bolt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CarsonF/bolt/downloads","issues_url":"https://api.github.com/repos/CarsonF/bolt/issues{/number}","pulls_url":"https://api.github.com/repos/CarsonF/bolt/pulls{/number}","milestones_url":"https://api.github.com/repos/CarsonF/bolt/milestones{/number}","notifications_url":"https://api.github.com/repos/CarsonF/bolt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CarsonF/bolt/labels{/name}","releases_url":"https://api.github.com/repos/CarsonF/bolt/releases{/id}","created_at":"2015-04-21T00:35:25Z","updated_at":"2015-04-21T00:35:28Z","pushed_at":"2015-05-27T15:16:12Z","git_url":"git://github.com/CarsonF/bolt.git","ssh_url":"git@github.com:CarsonF/bolt.git","clone_url":"https://github.com/CarsonF/bolt.git","svn_url":"https://github.com/CarsonF/bolt","homepage":"","size":44569,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bolt:master","ref":"master","sha":"0cdffe04496cbeb6b71165ff84bf4ac0c73b2774","user":{"login":"bolt","id":3869752,"avatar_url":"https://avatars.githubusercontent.com/u/3869752?v=3","gravatar_id":"","url":"https://api.github.com/users/bolt","html_url":"https://github.com/bolt","followers_url":"https://api.github.com/users/bolt/followers","following_url":"https://api.github.com/users/bolt/following{/other_user}","gists_url":"https://api.github.com/users/bolt/gists{/gist_id}","starred_url":"https://api.github.com/users/bolt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bolt/subscriptions","organizations_url":"https://api.github.com/users/bolt/orgs","repos_url":"https://api.github.com/users/bolt/repos","events_url":"https://api.github.com/users/bolt/events{/privacy}","received_events_url":"https://api.github.com/users/bolt/received_events","type":"Organization","site_admin":false},"repo":{"id":4665416,"name":"bolt","full_name":"bolt/bolt","owner":{"login":"bolt","id":3869752,"avatar_url":"https://avatars.githubusercontent.com/u/3869752?v=3","gravatar_id":"","url":"https://api.github.com/users/bolt","html_url":"https://github.com/bolt","followers_url":"https://api.github.com/users/bolt/followers","following_url":"https://api.github.com/users/bolt/following{/other_user}","gists_url":"https://api.github.com/users/bolt/gists{/gist_id}","starred_url":"https://api.github.com/users/bolt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bolt/subscriptions","organizations_url":"https://api.github.com/users/bolt/orgs","repos_url":"https://api.github.com/users/bolt/repos","events_url":"https://api.github.com/users/bolt/events{/privacy}","received_events_url":"https://api.github.com/users/bolt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bolt/bolt","description":"Bolt is a simple CMS written in PHP. It is based on Silex and Symfony components, uses Twig and either SQLite, MySQL or PostgreSQL.","fork":false,"url":"https://api.github.com/repos/bolt/bolt","forks_url":"https://api.github.com/repos/bolt/bolt/forks","keys_url":"https://api.github.com/repos/bolt/bolt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bolt/bolt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bolt/bolt/teams","hooks_url":"https://api.github.com/repos/bolt/bolt/hooks","issue_events_url":"https://api.github.com/repos/bolt/bolt/issues/events{/number}","events_url":"https://api.github.com/repos/bolt/bolt/events","assignees_url":"https://api.github.com/repos/bolt/bolt/assignees{/user}","branches_url":"https://api.github.com/repos/bolt/bolt/branches{/branch}","tags_url":"https://api.github.com/repos/bolt/bolt/tags","blobs_url":"https://api.github.com/repos/bolt/bolt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bolt/bolt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bolt/bolt/git/refs{/sha}","trees_url":"https://api.github.com/repos/bolt/bolt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bolt/bolt/statuses/{sha}","languages_url":"https://api.github.com/repos/bolt/bolt/languages","stargazers_url":"https://api.github.com/repos/bolt/bolt/stargazers","contributors_url":"https://api.github.com/repos/bolt/bolt/contributors","subscribers_url":"https://api.github.com/repos/bolt/bolt/subscribers","subscription_url":"https://api.github.com/repos/bolt/bolt/subscription","commits_url":"https://api.github.com/repos/bolt/bolt/commits{/sha}","git_commits_url":"https://api.github.com/repos/bolt/bolt/git/commits{/sha}","comments_url":"https://api.github.com/repos/bolt/bolt/comments{/number}","issue_comment_url":"https://api.github.com/repos/bolt/bolt/issues/comments{/number}","contents_url":"https://api.github.com/repos/bolt/bolt/contents/{+path}","compare_url":"https://api.github.com/repos/bolt/bolt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bolt/bolt/merges","archive_url":"https://api.github.com/repos/bolt/bolt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bolt/bolt/downloads","issues_url":"https://api.github.com/repos/bolt/bolt/issues{/number}","pulls_url":"https://api.github.com/repos/bolt/bolt/pulls{/number}","milestones_url":"https://api.github.com/repos/bolt/bolt/milestones{/number}","notifications_url":"https://api.github.com/repos/bolt/bolt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bolt/bolt/labels{/name}","releases_url":"https://api.github.com/repos/bolt/bolt/releases{/id}","created_at":"2012-06-14T16:07:54Z","updated_at":"2015-05-26T20:25:31Z","pushed_at":"2015-05-27T15:16:13Z","git_url":"git://github.com/bolt/bolt.git","ssh_url":"git@github.com:bolt/bolt.git","clone_url":"https://github.com/bolt/bolt.git","svn_url":"https://github.com/bolt/bolt","homepage":"","size":70428,"stargazers_count":2011,"watchers_count":2011,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":472,"mirror_url":null,"open_issues_count":121,"forks":472,"open_issues":121,"watchers":2011,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bolt/bolt/pulls/3584"},"html":{"href":"https://github.com/bolt/bolt/pull/3584"},"issue":{"href":"https://api.github.com/repos/bolt/bolt/issues/3584"},"comments":{"href":"https://api.github.com/repos/bolt/bolt/issues/3584/comments"},"review_comments":{"href":"https://api.github.com/repos/bolt/bolt/pulls/3584/comments"},"review_comment":{"href":"https://api.github.com/repos/bolt/bolt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bolt/bolt/pulls/3584/commits"},"statuses":{"href":"https://api.github.com/repos/bolt/bolt/statuses/4579340e5c1f707a6a0c1b2257efd19ea1400a19"}}}}