{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4264","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4264/labels{/name}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4264/comments","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4264/events","html_url":"https://github.com/scikit-learn/scikit-learn/pull/4264","id":58011120,"number":4264,"title":"ENH: Allow metric specification for Isomap.","user":{"login":"chebee7i","id":326005,"avatar_url":"https://avatars.githubusercontent.com/u/326005?v=3","gravatar_id":"","url":"https://api.github.com/users/chebee7i","html_url":"https://github.com/chebee7i","followers_url":"https://api.github.com/users/chebee7i/followers","following_url":"https://api.github.com/users/chebee7i/following{/other_user}","gists_url":"https://api.github.com/users/chebee7i/gists{/gist_id}","starred_url":"https://api.github.com/users/chebee7i/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chebee7i/subscriptions","organizations_url":"https://api.github.com/users/chebee7i/orgs","repos_url":"https://api.github.com/users/chebee7i/repos","events_url":"https://api.github.com/users/chebee7i/events{/privacy}","received_events_url":"https://api.github.com/users/chebee7i/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-02-18T01:21:41Z","updated_at":"2015-02-18T17:59:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4264","html_url":"https://github.com/scikit-learn/scikit-learn/pull/4264","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/4264.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/4264.patch"},"body":"This PR adds `metric` and `metric_params` options to `Isomap` which allows users to specify a metric, other than the standard Euclidean metric, to use with Isomap. I opt'd not to carry over the `p` parameter---it seems a bit awkward, especially since it is only useful when the metric is `'minkowski'`. Besides, users can still pass it in via `metric_params={'p': 1}`.\r\n\r\n@jakevdp Is this all that needs to be done to make Isomap \"metric aware\"? I wasn't quite sure how to test this either.  I thought of adapting the first test `test_isomap_simple_grid`, but I don't think we can expect that result for non-Euclidean metrics.  \r\n"},"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/74913441","html_url":"https://github.com/scikit-learn/scikit-learn/pull/4264#issuecomment-74913441","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4264","id":74913441,"user":{"login":"chebee7i","id":326005,"avatar_url":"https://avatars.githubusercontent.com/u/326005?v=3","gravatar_id":"","url":"https://api.github.com/users/chebee7i","html_url":"https://github.com/chebee7i","followers_url":"https://api.github.com/users/chebee7i/followers","following_url":"https://api.github.com/users/chebee7i/following{/other_user}","gists_url":"https://api.github.com/users/chebee7i/gists{/gist_id}","starred_url":"https://api.github.com/users/chebee7i/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chebee7i/subscriptions","organizations_url":"https://api.github.com/users/chebee7i/orgs","repos_url":"https://api.github.com/users/chebee7i/repos","events_url":"https://api.github.com/users/chebee7i/events{/privacy}","received_events_url":"https://api.github.com/users/chebee7i/received_events","type":"User","site_admin":false},"created_at":"2015-02-18T17:59:44Z","updated_at":"2015-02-18T17:59:44Z","body":"@agramfort Yes, I'd like to do that, but I was looking for input on what it should be. The existing tests already serve as smoke tests, since they use the metric 'euclidean'."}}