{"action":"opened","number":2370,"pull_request":{"url":"https://api.github.com/repos/xapi-project/xen-api/pulls/2370","id":43285197,"html_url":"https://github.com/xapi-project/xen-api/pull/2370","diff_url":"https://github.com/xapi-project/xen-api/pull/2370.diff","patch_url":"https://github.com/xapi-project/xen-api/pull/2370.patch","issue_url":"https://api.github.com/repos/xapi-project/xen-api/issues/2370","number":2370,"state":"open","locked":false,"title":"CA-180531: Throw `Backend_error` instead of `Server_error` in SM","user":{"login":"djs55","id":198586,"avatar_url":"https://avatars.githubusercontent.com/u/198586?v=3","gravatar_id":"","url":"https://api.github.com/users/djs55","html_url":"https://github.com/djs55","followers_url":"https://api.github.com/users/djs55/followers","following_url":"https://api.github.com/users/djs55/following{/other_user}","gists_url":"https://api.github.com/users/djs55/gists{/gist_id}","starred_url":"https://api.github.com/users/djs55/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djs55/subscriptions","organizations_url":"https://api.github.com/users/djs55/orgs","repos_url":"https://api.github.com/users/djs55/repos","events_url":"https://api.github.com/users/djs55/events{/privacy}","received_events_url":"https://api.github.com/users/djs55/received_events","type":"User","site_admin":false},"body":"The low-level SM code can only throw exceptions declared in the\r\n`Storage_interface` module; everything else is converted into an\r\n`Internal_error`. In particular the code must throw `Backend_error`\r\ninstead of `Server_error` directly to avoid unnecessary wrapping.\r\n\r\nThis fixes `xe sr-probe` which relies on the error message not\r\nbeing wrapped.\r\n\r\nSigned-off-by: David Scott <dave.scott@eu.citrix.com>","created_at":"2015-08-25T13:27:03Z","updated_at":"2015-08-25T13:27:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xapi-project/xen-api/pulls/2370/commits","review_comments_url":"https://api.github.com/repos/xapi-project/xen-api/pulls/2370/comments","review_comment_url":"https://api.github.com/repos/xapi-project/xen-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xapi-project/xen-api/issues/2370/comments","statuses_url":"https://api.github.com/repos/xapi-project/xen-api/statuses/7c34aeec5582deffbee022a6e0714f800019a71e","head":{"label":"djs55:CA-180531","ref":"CA-180531","sha":"7c34aeec5582deffbee022a6e0714f800019a71e","user":{"login":"djs55","id":198586,"avatar_url":"https://avatars.githubusercontent.com/u/198586?v=3","gravatar_id":"","url":"https://api.github.com/users/djs55","html_url":"https://github.com/djs55","followers_url":"https://api.github.com/users/djs55/followers","following_url":"https://api.github.com/users/djs55/following{/other_user}","gists_url":"https://api.github.com/users/djs55/gists{/gist_id}","starred_url":"https://api.github.com/users/djs55/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djs55/subscriptions","organizations_url":"https://api.github.com/users/djs55/orgs","repos_url":"https://api.github.com/users/djs55/repos","events_url":"https://api.github.com/users/djs55/events{/privacy}","received_events_url":"https://api.github.com/users/djs55/received_events","type":"User","site_admin":false},"repo":{"id":1325746,"name":"xen-api","full_name":"djs55/xen-api","owner":{"login":"djs55","id":198586,"avatar_url":"https://avatars.githubusercontent.com/u/198586?v=3","gravatar_id":"","url":"https://api.github.com/users/djs55","html_url":"https://github.com/djs55","followers_url":"https://api.github.com/users/djs55/followers","following_url":"https://api.github.com/users/djs55/following{/other_user}","gists_url":"https://api.github.com/users/djs55/gists{/gist_id}","starred_url":"https://api.github.com/users/djs55/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djs55/subscriptions","organizations_url":"https://api.github.com/users/djs55/orgs","repos_url":"https://api.github.com/users/djs55/repos","events_url":"https://api.github.com/users/djs55/events{/privacy}","received_events_url":"https://api.github.com/users/djs55/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/djs55/xen-api","description":"XCP xen-api","fork":true,"url":"https://api.github.com/repos/djs55/xen-api","forks_url":"https://api.github.com/repos/djs55/xen-api/forks","keys_url":"https://api.github.com/repos/djs55/xen-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/djs55/xen-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/djs55/xen-api/teams","hooks_url":"https://api.github.com/repos/djs55/xen-api/hooks","issue_events_url":"https://api.github.com/repos/djs55/xen-api/issues/events{/number}","events_url":"https://api.github.com/repos/djs55/xen-api/events","assignees_url":"https://api.github.com/repos/djs55/xen-api/assignees{/user}","branches_url":"https://api.github.com/repos/djs55/xen-api/branches{/branch}","tags_url":"https://api.github.com/repos/djs55/xen-api/tags","blobs_url":"https://api.github.com/repos/djs55/xen-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/djs55/xen-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/djs55/xen-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/djs55/xen-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/djs55/xen-api/statuses/{sha}","languages_url":"https://api.github.com/repos/djs55/xen-api/languages","stargazers_url":"https://api.github.com/repos/djs55/xen-api/stargazers","contributors_url":"https://api.github.com/repos/djs55/xen-api/contributors","subscribers_url":"https://api.github.com/repos/djs55/xen-api/subscribers","subscription_url":"https://api.github.com/repos/djs55/xen-api/subscription","commits_url":"https://api.github.com/repos/djs55/xen-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/djs55/xen-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/djs55/xen-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/djs55/xen-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/djs55/xen-api/contents/{+path}","compare_url":"https://api.github.com/repos/djs55/xen-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/djs55/xen-api/merges","archive_url":"https://api.github.com/repos/djs55/xen-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/djs55/xen-api/downloads","issues_url":"https://api.github.com/repos/djs55/xen-api/issues{/number}","pulls_url":"https://api.github.com/repos/djs55/xen-api/pulls{/number}","milestones_url":"https://api.github.com/repos/djs55/xen-api/milestones{/number}","notifications_url":"https://api.github.com/repos/djs55/xen-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/djs55/xen-api/labels{/name}","releases_url":"https://api.github.com/repos/djs55/xen-api/releases{/id}","created_at":"2011-02-03T21:11:05Z","updated_at":"2015-04-19T12:25:34Z","pushed_at":"2015-08-25T13:26:38Z","git_url":"git://github.com/djs55/xen-api.git","ssh_url":"git@github.com:djs55/xen-api.git","clone_url":"https://github.com/djs55/xen-api.git","svn_url":"https://github.com/djs55/xen-api","homepage":"","size":28564,"stargazers_count":4,"watchers_count":4,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"xapi-project:master","ref":"master","sha":"08a3a7fb434ff310f07047dc9a8213a371470129","user":{"login":"xapi-project","id":317268,"avatar_url":"https://avatars.githubusercontent.com/u/317268?v=3","gravatar_id":"","url":"https://api.github.com/users/xapi-project","html_url":"https://github.com/xapi-project","followers_url":"https://api.github.com/users/xapi-project/followers","following_url":"https://api.github.com/users/xapi-project/following{/other_user}","gists_url":"https://api.github.com/users/xapi-project/gists{/gist_id}","starred_url":"https://api.github.com/users/xapi-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapi-project/subscriptions","organizations_url":"https://api.github.com/users/xapi-project/orgs","repos_url":"https://api.github.com/users/xapi-project/repos","events_url":"https://api.github.com/users/xapi-project/events{/privacy}","received_events_url":"https://api.github.com/users/xapi-project/received_events","type":"Organization","site_admin":false},"repo":{"id":960233,"name":"xen-api","full_name":"xapi-project/xen-api","owner":{"login":"xapi-project","id":317268,"avatar_url":"https://avatars.githubusercontent.com/u/317268?v=3","gravatar_id":"","url":"https://api.github.com/users/xapi-project","html_url":"https://github.com/xapi-project","followers_url":"https://api.github.com/users/xapi-project/followers","following_url":"https://api.github.com/users/xapi-project/following{/other_user}","gists_url":"https://api.github.com/users/xapi-project/gists{/gist_id}","starred_url":"https://api.github.com/users/xapi-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapi-project/subscriptions","organizations_url":"https://api.github.com/users/xapi-project/orgs","repos_url":"https://api.github.com/users/xapi-project/repos","events_url":"https://api.github.com/users/xapi-project/events{/privacy}","received_events_url":"https://api.github.com/users/xapi-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xapi-project/xen-api","description":"The Xapi Project's XenAPI Server","fork":false,"url":"https://api.github.com/repos/xapi-project/xen-api","forks_url":"https://api.github.com/repos/xapi-project/xen-api/forks","keys_url":"https://api.github.com/repos/xapi-project/xen-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xapi-project/xen-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xapi-project/xen-api/teams","hooks_url":"https://api.github.com/repos/xapi-project/xen-api/hooks","issue_events_url":"https://api.github.com/repos/xapi-project/xen-api/issues/events{/number}","events_url":"https://api.github.com/repos/xapi-project/xen-api/events","assignees_url":"https://api.github.com/repos/xapi-project/xen-api/assignees{/user}","branches_url":"https://api.github.com/repos/xapi-project/xen-api/branches{/branch}","tags_url":"https://api.github.com/repos/xapi-project/xen-api/tags","blobs_url":"https://api.github.com/repos/xapi-project/xen-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xapi-project/xen-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xapi-project/xen-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/xapi-project/xen-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xapi-project/xen-api/statuses/{sha}","languages_url":"https://api.github.com/repos/xapi-project/xen-api/languages","stargazers_url":"https://api.github.com/repos/xapi-project/xen-api/stargazers","contributors_url":"https://api.github.com/repos/xapi-project/xen-api/contributors","subscribers_url":"https://api.github.com/repos/xapi-project/xen-api/subscribers","subscription_url":"https://api.github.com/repos/xapi-project/xen-api/subscription","commits_url":"https://api.github.com/repos/xapi-project/xen-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/xapi-project/xen-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/xapi-project/xen-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/xapi-project/xen-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/xapi-project/xen-api/contents/{+path}","compare_url":"https://api.github.com/repos/xapi-project/xen-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xapi-project/xen-api/merges","archive_url":"https://api.github.com/repos/xapi-project/xen-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xapi-project/xen-api/downloads","issues_url":"https://api.github.com/repos/xapi-project/xen-api/issues{/number}","pulls_url":"https://api.github.com/repos/xapi-project/xen-api/pulls{/number}","milestones_url":"https://api.github.com/repos/xapi-project/xen-api/milestones{/number}","notifications_url":"https://api.github.com/repos/xapi-project/xen-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xapi-project/xen-api/labels{/name}","releases_url":"https://api.github.com/repos/xapi-project/xen-api/releases{/id}","created_at":"2010-10-04T10:52:57Z","updated_at":"2015-08-18T13:09:12Z","pushed_at":"2015-08-25T12:48:01Z","git_url":"git://github.com/xapi-project/xen-api.git","ssh_url":"git@github.com:xapi-project/xen-api.git","clone_url":"https://github.com/xapi-project/xen-api.git","svn_url":"https://github.com/xapi-project/xen-api","homepage":"http://xenproject.org/developers/teams/xapi.html","size":40634,"stargazers_count":186,"watchers_count":186,"language":"OCaml","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":136,"mirror_url":null,"open_issues_count":28,"forks":136,"open_issues":28,"watchers":186,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/2370"},"html":{"href":"https://github.com/xapi-project/xen-api/pull/2370"},"issue":{"href":"https://api.github.com/repos/xapi-project/xen-api/issues/2370"},"comments":{"href":"https://api.github.com/repos/xapi-project/xen-api/issues/2370/comments"},"review_comments":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/2370/comments"},"review_comment":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/2370/commits"},"statuses":{"href":"https://api.github.com/repos/xapi-project/xen-api/statuses/7c34aeec5582deffbee022a6e0714f800019a71e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":12,"deletions":12,"changed_files":1}}