{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/specialist-frontend/pulls/comments/23857124","id":23857124,"diff_hunk":"@@ -0,0 +1,14 @@\n+Feature: Document viewing\n+  As a specialist member of the public","path":"features/document-viewing.feature","position":2,"original_position":2,"commit_id":"466d917bd673b3ed53af8de509d94da5bc10479b","original_commit_id":"466d917bd673b3ed53af8de509d94da5bc10479b","user":{"login":"evilstreak","id":74812,"avatar_url":"https://avatars.githubusercontent.com/u/74812?v=3","gravatar_id":"","url":"https://api.github.com/users/evilstreak","html_url":"https://github.com/evilstreak","followers_url":"https://api.github.com/users/evilstreak/followers","following_url":"https://api.github.com/users/evilstreak/following{/other_user}","gists_url":"https://api.github.com/users/evilstreak/gists{/gist_id}","starred_url":"https://api.github.com/users/evilstreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evilstreak/subscriptions","organizations_url":"https://api.github.com/users/evilstreak/orgs","repos_url":"https://api.github.com/users/evilstreak/repos","events_url":"https://api.github.com/users/evilstreak/events{/privacy}","received_events_url":"https://api.github.com/users/evilstreak/received_events","type":"User","site_admin":false},"body":"Since you're changing it, this is as good a time as any to update it. We've generally been referring to users with specialist needs rather than specialist users. So \"As a member of the public with specialist needs\"","created_at":"2015-01-30T17:27:42Z","updated_at":"2015-01-30T17:27:42Z","html_url":"https://github.com/alphagov/specialist-frontend/pull/81#discussion_r23857124","pull_request_url":"https://api.github.com/repos/alphagov/specialist-frontend/pulls/81","_links":{"self":{"href":"https://api.github.com/repos/alphagov/specialist-frontend/pulls/comments/23857124"},"html":{"href":"https://github.com/alphagov/specialist-frontend/pull/81#discussion_r23857124"},"pull_request":{"href":"https://api.github.com/repos/alphagov/specialist-frontend/pulls/81"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/specialist-frontend/pulls/81","id":28372371,"html_url":"https://github.com/alphagov/specialist-frontend/pull/81","diff_url":"https://github.com/alphagov/specialist-frontend/pull/81.diff","patch_url":"https://github.com/alphagov/specialist-frontend/pull/81.patch","issue_url":"https://api.github.com/repos/alphagov/specialist-frontend/issues/81","number":81,"state":"open","locked":false,"title":"DO NOT MERGE Use Finder for metadata","user":{"login":"tommyp","id":449004,"avatar_url":"https://avatars.githubusercontent.com/u/449004?v=3","gravatar_id":"","url":"https://api.github.com/users/tommyp","html_url":"https://github.com/tommyp","followers_url":"https://api.github.com/users/tommyp/followers","following_url":"https://api.github.com/users/tommyp/following{/other_user}","gists_url":"https://api.github.com/users/tommyp/gists{/gist_id}","starred_url":"https://api.github.com/users/tommyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tommyp/subscriptions","organizations_url":"https://api.github.com/users/tommyp/orgs","repos_url":"https://api.github.com/users/tommyp/repos","events_url":"https://api.github.com/users/tommyp/events{/privacy}","received_events_url":"https://api.github.com/users/tommyp/received_events","type":"User","site_admin":false},"body":"As we now store all the Facets in the ContentStore, we can remove all of the code in this App for specifying each Document format. \r\n\r\nThe commits go as follows:\r\n- removing Presenters for each format\r\n- removing tests for each format\r\n- expose the Facets and the format name from the Finder model\r\n- add a new `DocumentPresenter` class which we pass the Finder into class to get the format name and the facets of the Finder. These then describe all the Metadata that a document format may have. We then use the keys of these facets to define methods which call `document.details.#{method}`. We also use these facets to get a hash of the `extra_date_metadata`, `filterable_metadata` and `extra_metadata`.\r\n- refactor `SpecialistDocumentsController` to get the Finder content_item from the first part of the path. We then pass this into the DocumentPresenter to use. This allows us to get rid of all the code checking the slug and initialising a format Presenter class.\r\n\r\n","created_at":"2015-01-30T16:12:55Z","updated_at":"2015-01-30T17:27:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"87bf84df1e1d22bd2850a6b77023bdc8e204f82b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/specialist-frontend/pulls/81/commits","review_comments_url":"https://api.github.com/repos/alphagov/specialist-frontend/pulls/81/comments","review_comment_url":"https://api.github.com/repos/alphagov/specialist-frontend/pulls/comments/{number}","comments_url":"https://api.github.com/repos/alphagov/specialist-frontend/issues/81/comments","statuses_url":"https://api.github.com/repos/alphagov/specialist-frontend/statuses/466d917bd673b3ed53af8de509d94da5bc10479b","head":{"label":"alphagov:use-finder-for-metadata","ref":"use-finder-for-metadata","sha":"466d917bd673b3ed53af8de509d94da5bc10479b","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":16176203,"name":"specialist-frontend","full_name":"alphagov/specialist-frontend","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/specialist-frontend","description":"","fork":false,"url":"https://api.github.com/repos/alphagov/specialist-frontend","forks_url":"https://api.github.com/repos/alphagov/specialist-frontend/forks","keys_url":"https://api.github.com/repos/alphagov/specialist-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/specialist-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/specialist-frontend/teams","hooks_url":"https://api.github.com/repos/alphagov/specialist-frontend/hooks","issue_events_url":"https://api.github.com/repos/alphagov/specialist-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/specialist-frontend/events","assignees_url":"https://api.github.com/repos/alphagov/specialist-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/specialist-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/specialist-frontend/tags","blobs_url":"https://api.github.com/repos/alphagov/specialist-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/specialist-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/specialist-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/specialist-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/specialist-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/specialist-frontend/languages","stargazers_url":"https://api.github.com/repos/alphagov/specialist-frontend/stargazers","contributors_url":"https://api.github.com/repos/alphagov/specialist-frontend/contributors","subscribers_url":"https://api.github.com/repos/alphagov/specialist-frontend/subscribers","subscription_url":"https://api.github.com/repos/alphagov/specialist-frontend/subscription","commits_url":"https://api.github.com/repos/alphagov/specialist-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/specialist-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/specialist-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/specialist-frontend/issues/comments/{number}","contents_url":"https://api.github.com/repos/alphagov/specialist-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/specialist-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/specialist-frontend/merges","archive_url":"https://api.github.com/repos/alphagov/specialist-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/specialist-frontend/downloads","issues_url":"https://api.github.com/repos/alphagov/specialist-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/specialist-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/specialist-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/specialist-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/specialist-frontend/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/specialist-frontend/releases{/id}","created_at":"2014-01-23T15:21:59Z","updated_at":"2015-01-28T09:36:22Z","pushed_at":"2015-01-30T16:03:32Z","git_url":"git://github.com/alphagov/specialist-frontend.git","ssh_url":"git@github.com:alphagov/specialist-frontend.git","clone_url":"https://github.com/alphagov/specialist-frontend.git","svn_url":"https://github.com/alphagov/specialist-frontend","homepage":null,"size":2338,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"ced4e62e97d68bd797ae35b1b2279e6fd36156e9","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":16176203,"name":"specialist-frontend","full_name":"alphagov/specialist-frontend","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/specialist-frontend","description":"","fork":false,"url":"https://api.github.com/repos/alphagov/specialist-frontend","forks_url":"https://api.github.com/repos/alphagov/specialist-frontend/forks","keys_url":"https://api.github.com/repos/alphagov/specialist-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/specialist-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/specialist-frontend/teams","hooks_url":"https://api.github.com/repos/alphagov/specialist-frontend/hooks","issue_events_url":"https://api.github.com/repos/alphagov/specialist-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/specialist-frontend/events","assignees_url":"https://api.github.com/repos/alphagov/specialist-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/specialist-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/specialist-frontend/tags","blobs_url":"https://api.github.com/repos/alphagov/specialist-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/specialist-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/specialist-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/specialist-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/specialist-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/specialist-frontend/languages","stargazers_url":"https://api.github.com/repos/alphagov/specialist-frontend/stargazers","contributors_url":"https://api.github.com/repos/alphagov/specialist-frontend/contributors","subscribers_url":"https://api.github.com/repos/alphagov/specialist-frontend/subscribers","subscription_url":"https://api.github.com/repos/alphagov/specialist-frontend/subscription","commits_url":"https://api.github.com/repos/alphagov/specialist-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/specialist-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/specialist-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/specialist-frontend/issues/comments/{number}","contents_url":"https://api.github.com/repos/alphagov/specialist-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/specialist-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/specialist-frontend/merges","archive_url":"https://api.github.com/repos/alphagov/specialist-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/specialist-frontend/downloads","issues_url":"https://api.github.com/repos/alphagov/specialist-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/specialist-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/specialist-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/specialist-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/specialist-frontend/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/specialist-frontend/releases{/id}","created_at":"2014-01-23T15:21:59Z","updated_at":"2015-01-28T09:36:22Z","pushed_at":"2015-01-30T16:03:32Z","git_url":"git://github.com/alphagov/specialist-frontend.git","ssh_url":"git@github.com:alphagov/specialist-frontend.git","clone_url":"https://github.com/alphagov/specialist-frontend.git","svn_url":"https://github.com/alphagov/specialist-frontend","homepage":null,"size":2338,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/specialist-frontend/pulls/81"},"html":{"href":"https://github.com/alphagov/specialist-frontend/pull/81"},"issue":{"href":"https://api.github.com/repos/alphagov/specialist-frontend/issues/81"},"comments":{"href":"https://api.github.com/repos/alphagov/specialist-frontend/issues/81/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/specialist-frontend/pulls/81/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/specialist-frontend/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/alphagov/specialist-frontend/pulls/81/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/specialist-frontend/statuses/466d917bd673b3ed53af8de509d94da5bc10479b"}}}}