{"action":"created","issue":{"url":"https://api.github.com/repos/geoadmin/mf-geoadmin3/issues/2440","labels_url":"https://api.github.com/repos/geoadmin/mf-geoadmin3/issues/2440/labels{/name}","comments_url":"https://api.github.com/repos/geoadmin/mf-geoadmin3/issues/2440/comments","events_url":"https://api.github.com/repos/geoadmin/mf-geoadmin3/issues/2440/events","html_url":"https://github.com/geoadmin/mf-geoadmin3/pull/2440","id":89606816,"number":2440,"title":"Use background layers provided by the current topic","user":{"login":"Jenselme","id":6643536,"avatar_url":"https://avatars.githubusercontent.com/u/6643536?v=3","gravatar_id":"","url":"https://api.github.com/users/Jenselme","html_url":"https://github.com/Jenselme","followers_url":"https://api.github.com/users/Jenselme/followers","following_url":"https://api.github.com/users/Jenselme/following{/other_user}","gists_url":"https://api.github.com/users/Jenselme/gists{/gist_id}","starred_url":"https://api.github.com/users/Jenselme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jenselme/subscriptions","organizations_url":"https://api.github.com/users/Jenselme/orgs","repos_url":"https://api.github.com/users/Jenselme/repos","events_url":"https://api.github.com/users/Jenselme/events{/privacy}","received_events_url":"https://api.github.com/users/Jenselme/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-06-19T16:33:56Z","updated_at":"2015-06-20T10:43:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/geoadmin/mf-geoadmin3/pulls/2440","html_url":"https://github.com/geoadmin/mf-geoadmin3/pull/2440","diff_url":"https://github.com/geoadmin/mf-geoadmin3/pull/2440.diff","patch_url":"https://github.com/geoadmin/mf-geoadmin3/pull/2440.patch"},"body":"- Choice of background layers is not hard coded\r\n- Topics without background layers don't create an error\r\n- Add a signal which is broadcasted when layers are loaded. Necessary to know when we can access the list of background layers."},"comment":{"url":"https://api.github.com/repos/geoadmin/mf-geoadmin3/issues/comments/113744909","html_url":"https://github.com/geoadmin/mf-geoadmin3/pull/2440#issuecomment-113744909","issue_url":"https://api.github.com/repos/geoadmin/mf-geoadmin3/issues/2440","id":113744909,"user":{"login":"davidoesch","id":4577727,"avatar_url":"https://avatars.githubusercontent.com/u/4577727?v=3","gravatar_id":"","url":"https://api.github.com/users/davidoesch","html_url":"https://github.com/davidoesch","followers_url":"https://api.github.com/users/davidoesch/followers","following_url":"https://api.github.com/users/davidoesch/following{/other_user}","gists_url":"https://api.github.com/users/davidoesch/gists{/gist_id}","starred_url":"https://api.github.com/users/davidoesch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidoesch/subscriptions","organizations_url":"https://api.github.com/users/davidoesch/orgs","repos_url":"https://api.github.com/users/davidoesch/repos","events_url":"https://api.github.com/users/davidoesch/events{/privacy}","received_events_url":"https://api.github.com/users/davidoesch/received_events","type":"User","site_admin":false},"created_at":"2015-06-20T10:43:45Z","updated_at":"2015-06-20T10:43:45Z","body":"1) changing the bg order dependent on topic is hard to understand . As discussed previously in the UI session - we keep it as.\n\nOn Sat, Jun 20, 2015 at 12:35 PM, Cédric Moullet <notifications@github.com>\nwrote:\n\n> Thanks for this PR.\n> Here some points to discuss:\n> 1. @davidoesch this change reimplements the dynamic loading of the topic list from the catalog (it was hardcoded since it's always the same....). This implies that the order of the bg layer is topic dependent. The swissimage is not always the same. What do you think of this ?\n> 2. @Jenselme Could you explain me how you plan to use it ? Since the css is almost hardcoded (swissimage, pixelkarte), how will you add other bg layers ?\n> 3. Unit tests are failing. Will need to be fixed if we want to merge it.\n> ---\n> Reply to this email directly or view it on GitHub:\n> https://github.com/geoadmin/mf-geoadmin3/pull/2440#issuecomment-113742918"}}