{"action":"created","comment":{"url":"https://api.github.com/repos/paulrenenichols/html-games/pulls/comments/37782508","id":37782508,"diff_hunk":"@@ -215,7 +220,18 @@ gulp.task('build-frontend-games-html', ['clean-frontend'], function () {\n \n gulp.task('build-frontend-js-vendor', ['clean-frontend'], function () {\n   \n-  return gulp.src(buildConfig.frontend.js.vendor.src)\n+  var b = browserify({\n+    entries: buildConfig.frontend.js.vendor.src,\n+    debug: true\n+  });\n+\n+  return b.bundle()\n+    .pipe(source(buildConfig.frontend.js.vendor.src))","path":"gulpfile.js","position":34,"original_position":34,"commit_id":"4f91c63f17abee29f85a2825a29e9fbd06702aa1","original_commit_id":"4f91c63f17abee29f85a2825a29e9fbd06702aa1","user":{"login":"paulrenenichols","id":2683933,"avatar_url":"https://avatars.githubusercontent.com/u/2683933?v=3","gravatar_id":"","url":"https://api.github.com/users/paulrenenichols","html_url":"https://github.com/paulrenenichols","followers_url":"https://api.github.com/users/paulrenenichols/followers","following_url":"https://api.github.com/users/paulrenenichols/following{/other_user}","gists_url":"https://api.github.com/users/paulrenenichols/gists{/gist_id}","starred_url":"https://api.github.com/users/paulrenenichols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulrenenichols/subscriptions","organizations_url":"https://api.github.com/users/paulrenenichols/orgs","repos_url":"https://api.github.com/users/paulrenenichols/repos","events_url":"https://api.github.com/users/paulrenenichols/events{/privacy}","received_events_url":"https://api.github.com/users/paulrenenichols/received_events","type":"User","site_admin":false},"body":"It looks like this `source` function here defines what the name of the output file will be.\r\n\r\nThis seems to work:\r\n```javascript\r\ngulp.task('build-frontend-js-vendor', ['clean-frontend'], function () {\r\n  \r\n  var b = browserify({\r\n    entries: buildConfig.frontend.js.vendor.src,\r\n    debug: true\r\n  });\r\n\r\n  return b.bundle()\r\n    .pipe(source('vendor.js'))\r\n    .pipe(buffer())\r\n    .pipe(sourcemaps.init({loadMaps: true}))\r\n      .on('error', util.log)\r\n    .pipe(sourcemaps.write('./'))\r\n    .pipe(gulp.dest(buildConfig.frontend.js.vendor.dest));\r\n\r\n});\r\n```\r\n\r\nAlso, I want to keep `uglify` out for now, but when put it in, we need to make it optional, so that we can build with full unminified source for debugging.","created_at":"2015-08-24T18:10:46Z","updated_at":"2015-08-24T18:10:46Z","html_url":"https://github.com/paulrenenichols/html-games/pull/1#discussion_r37782508","pull_request_url":"https://api.github.com/repos/paulrenenichols/html-games/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/paulrenenichols/html-games/pulls/comments/37782508"},"html":{"href":"https://github.com/paulrenenichols/html-games/pull/1#discussion_r37782508"},"pull_request":{"href":"https://api.github.com/repos/paulrenenichols/html-games/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/paulrenenichols/html-games/pulls/1","id":43131388,"html_url":"https://github.com/paulrenenichols/html-games/pull/1","diff_url":"https://github.com/paulrenenichols/html-games/pull/1.diff","patch_url":"https://github.com/paulrenenichols/html-games/pull/1.patch","issue_url":"https://api.github.com/repos/paulrenenichols/html-games/issues/1","number":1,"state":"open","locked":false,"title":"Browserify test","user":{"login":"greybubble","id":3664508,"avatar_url":"https://avatars.githubusercontent.com/u/3664508?v=3","gravatar_id":"","url":"https://api.github.com/users/greybubble","html_url":"https://github.com/greybubble","followers_url":"https://api.github.com/users/greybubble/followers","following_url":"https://api.github.com/users/greybubble/following{/other_user}","gists_url":"https://api.github.com/users/greybubble/gists{/gist_id}","starred_url":"https://api.github.com/users/greybubble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greybubble/subscriptions","organizations_url":"https://api.github.com/users/greybubble/orgs","repos_url":"https://api.github.com/users/greybubble/repos","events_url":"https://api.github.com/users/greybubble/events{/privacy}","received_events_url":"https://api.github.com/users/greybubble/received_events","type":"User","site_admin":false},"body":"I added browserify and I have a test for using it in gulp.","created_at":"2015-08-23T23:53:17Z","updated_at":"2015-08-24T18:10:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e8e296d2d2c6af2d7a9cc22cbf3d9c265a8b98a","assignee":{"login":"paulrenenichols","id":2683933,"avatar_url":"https://avatars.githubusercontent.com/u/2683933?v=3","gravatar_id":"","url":"https://api.github.com/users/paulrenenichols","html_url":"https://github.com/paulrenenichols","followers_url":"https://api.github.com/users/paulrenenichols/followers","following_url":"https://api.github.com/users/paulrenenichols/following{/other_user}","gists_url":"https://api.github.com/users/paulrenenichols/gists{/gist_id}","starred_url":"https://api.github.com/users/paulrenenichols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulrenenichols/subscriptions","organizations_url":"https://api.github.com/users/paulrenenichols/orgs","repos_url":"https://api.github.com/users/paulrenenichols/repos","events_url":"https://api.github.com/users/paulrenenichols/events{/privacy}","received_events_url":"https://api.github.com/users/paulrenenichols/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/paulrenenichols/html-games/pulls/1/commits","review_comments_url":"https://api.github.com/repos/paulrenenichols/html-games/pulls/1/comments","review_comment_url":"https://api.github.com/repos/paulrenenichols/html-games/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paulrenenichols/html-games/issues/1/comments","statuses_url":"https://api.github.com/repos/paulrenenichols/html-games/statuses/4f91c63f17abee29f85a2825a29e9fbd06702aa1","head":{"label":"paulrenenichols:browserify-test","ref":"browserify-test","sha":"4f91c63f17abee29f85a2825a29e9fbd06702aa1","user":{"login":"paulrenenichols","id":2683933,"avatar_url":"https://avatars.githubusercontent.com/u/2683933?v=3","gravatar_id":"","url":"https://api.github.com/users/paulrenenichols","html_url":"https://github.com/paulrenenichols","followers_url":"https://api.github.com/users/paulrenenichols/followers","following_url":"https://api.github.com/users/paulrenenichols/following{/other_user}","gists_url":"https://api.github.com/users/paulrenenichols/gists{/gist_id}","starred_url":"https://api.github.com/users/paulrenenichols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulrenenichols/subscriptions","organizations_url":"https://api.github.com/users/paulrenenichols/orgs","repos_url":"https://api.github.com/users/paulrenenichols/repos","events_url":"https://api.github.com/users/paulrenenichols/events{/privacy}","received_events_url":"https://api.github.com/users/paulrenenichols/received_events","type":"User","site_admin":false},"repo":{"id":40790697,"name":"html-games","full_name":"paulrenenichols/html-games","owner":{"login":"paulrenenichols","id":2683933,"avatar_url":"https://avatars.githubusercontent.com/u/2683933?v=3","gravatar_id":"","url":"https://api.github.com/users/paulrenenichols","html_url":"https://github.com/paulrenenichols","followers_url":"https://api.github.com/users/paulrenenichols/followers","following_url":"https://api.github.com/users/paulrenenichols/following{/other_user}","gists_url":"https://api.github.com/users/paulrenenichols/gists{/gist_id}","starred_url":"https://api.github.com/users/paulrenenichols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulrenenichols/subscriptions","organizations_url":"https://api.github.com/users/paulrenenichols/orgs","repos_url":"https://api.github.com/users/paulrenenichols/repos","events_url":"https://api.github.com/users/paulrenenichols/events{/privacy}","received_events_url":"https://api.github.com/users/paulrenenichols/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paulrenenichols/html-games","description":"Everything you need to build an HTML Game","fork":false,"url":"https://api.github.com/repos/paulrenenichols/html-games","forks_url":"https://api.github.com/repos/paulrenenichols/html-games/forks","keys_url":"https://api.github.com/repos/paulrenenichols/html-games/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paulrenenichols/html-games/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paulrenenichols/html-games/teams","hooks_url":"https://api.github.com/repos/paulrenenichols/html-games/hooks","issue_events_url":"https://api.github.com/repos/paulrenenichols/html-games/issues/events{/number}","events_url":"https://api.github.com/repos/paulrenenichols/html-games/events","assignees_url":"https://api.github.com/repos/paulrenenichols/html-games/assignees{/user}","branches_url":"https://api.github.com/repos/paulrenenichols/html-games/branches{/branch}","tags_url":"https://api.github.com/repos/paulrenenichols/html-games/tags","blobs_url":"https://api.github.com/repos/paulrenenichols/html-games/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paulrenenichols/html-games/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paulrenenichols/html-games/git/refs{/sha}","trees_url":"https://api.github.com/repos/paulrenenichols/html-games/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paulrenenichols/html-games/statuses/{sha}","languages_url":"https://api.github.com/repos/paulrenenichols/html-games/languages","stargazers_url":"https://api.github.com/repos/paulrenenichols/html-games/stargazers","contributors_url":"https://api.github.com/repos/paulrenenichols/html-games/contributors","subscribers_url":"https://api.github.com/repos/paulrenenichols/html-games/subscribers","subscription_url":"https://api.github.com/repos/paulrenenichols/html-games/subscription","commits_url":"https://api.github.com/repos/paulrenenichols/html-games/commits{/sha}","git_commits_url":"https://api.github.com/repos/paulrenenichols/html-games/git/commits{/sha}","comments_url":"https://api.github.com/repos/paulrenenichols/html-games/comments{/number}","issue_comment_url":"https://api.github.com/repos/paulrenenichols/html-games/issues/comments{/number}","contents_url":"https://api.github.com/repos/paulrenenichols/html-games/contents/{+path}","compare_url":"https://api.github.com/repos/paulrenenichols/html-games/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paulrenenichols/html-games/merges","archive_url":"https://api.github.com/repos/paulrenenichols/html-games/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paulrenenichols/html-games/downloads","issues_url":"https://api.github.com/repos/paulrenenichols/html-games/issues{/number}","pulls_url":"https://api.github.com/repos/paulrenenichols/html-games/pulls{/number}","milestones_url":"https://api.github.com/repos/paulrenenichols/html-games/milestones{/number}","notifications_url":"https://api.github.com/repos/paulrenenichols/html-games/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paulrenenichols/html-games/labels{/name}","releases_url":"https://api.github.com/repos/paulrenenichols/html-games/releases{/id}","created_at":"2015-08-15T23:09:51Z","updated_at":"2015-08-23T22:07:12Z","pushed_at":"2015-08-23T23:53:17Z","git_url":"git://github.com/paulrenenichols/html-games.git","ssh_url":"git@github.com:paulrenenichols/html-games.git","clone_url":"https://github.com/paulrenenichols/html-games.git","svn_url":"https://github.com/paulrenenichols/html-games","homepage":null,"size":407,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"paulrenenichols:master","ref":"master","sha":"e2919c8e220736866f66c41b5afba3525ae5db4b","user":{"login":"paulrenenichols","id":2683933,"avatar_url":"https://avatars.githubusercontent.com/u/2683933?v=3","gravatar_id":"","url":"https://api.github.com/users/paulrenenichols","html_url":"https://github.com/paulrenenichols","followers_url":"https://api.github.com/users/paulrenenichols/followers","following_url":"https://api.github.com/users/paulrenenichols/following{/other_user}","gists_url":"https://api.github.com/users/paulrenenichols/gists{/gist_id}","starred_url":"https://api.github.com/users/paulrenenichols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulrenenichols/subscriptions","organizations_url":"https://api.github.com/users/paulrenenichols/orgs","repos_url":"https://api.github.com/users/paulrenenichols/repos","events_url":"https://api.github.com/users/paulrenenichols/events{/privacy}","received_events_url":"https://api.github.com/users/paulrenenichols/received_events","type":"User","site_admin":false},"repo":{"id":40790697,"name":"html-games","full_name":"paulrenenichols/html-games","owner":{"login":"paulrenenichols","id":2683933,"avatar_url":"https://avatars.githubusercontent.com/u/2683933?v=3","gravatar_id":"","url":"https://api.github.com/users/paulrenenichols","html_url":"https://github.com/paulrenenichols","followers_url":"https://api.github.com/users/paulrenenichols/followers","following_url":"https://api.github.com/users/paulrenenichols/following{/other_user}","gists_url":"https://api.github.com/users/paulrenenichols/gists{/gist_id}","starred_url":"https://api.github.com/users/paulrenenichols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulrenenichols/subscriptions","organizations_url":"https://api.github.com/users/paulrenenichols/orgs","repos_url":"https://api.github.com/users/paulrenenichols/repos","events_url":"https://api.github.com/users/paulrenenichols/events{/privacy}","received_events_url":"https://api.github.com/users/paulrenenichols/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paulrenenichols/html-games","description":"Everything you need to build an HTML Game","fork":false,"url":"https://api.github.com/repos/paulrenenichols/html-games","forks_url":"https://api.github.com/repos/paulrenenichols/html-games/forks","keys_url":"https://api.github.com/repos/paulrenenichols/html-games/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paulrenenichols/html-games/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paulrenenichols/html-games/teams","hooks_url":"https://api.github.com/repos/paulrenenichols/html-games/hooks","issue_events_url":"https://api.github.com/repos/paulrenenichols/html-games/issues/events{/number}","events_url":"https://api.github.com/repos/paulrenenichols/html-games/events","assignees_url":"https://api.github.com/repos/paulrenenichols/html-games/assignees{/user}","branches_url":"https://api.github.com/repos/paulrenenichols/html-games/branches{/branch}","tags_url":"https://api.github.com/repos/paulrenenichols/html-games/tags","blobs_url":"https://api.github.com/repos/paulrenenichols/html-games/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paulrenenichols/html-games/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paulrenenichols/html-games/git/refs{/sha}","trees_url":"https://api.github.com/repos/paulrenenichols/html-games/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paulrenenichols/html-games/statuses/{sha}","languages_url":"https://api.github.com/repos/paulrenenichols/html-games/languages","stargazers_url":"https://api.github.com/repos/paulrenenichols/html-games/stargazers","contributors_url":"https://api.github.com/repos/paulrenenichols/html-games/contributors","subscribers_url":"https://api.github.com/repos/paulrenenichols/html-games/subscribers","subscription_url":"https://api.github.com/repos/paulrenenichols/html-games/subscription","commits_url":"https://api.github.com/repos/paulrenenichols/html-games/commits{/sha}","git_commits_url":"https://api.github.com/repos/paulrenenichols/html-games/git/commits{/sha}","comments_url":"https://api.github.com/repos/paulrenenichols/html-games/comments{/number}","issue_comment_url":"https://api.github.com/repos/paulrenenichols/html-games/issues/comments{/number}","contents_url":"https://api.github.com/repos/paulrenenichols/html-games/contents/{+path}","compare_url":"https://api.github.com/repos/paulrenenichols/html-games/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paulrenenichols/html-games/merges","archive_url":"https://api.github.com/repos/paulrenenichols/html-games/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paulrenenichols/html-games/downloads","issues_url":"https://api.github.com/repos/paulrenenichols/html-games/issues{/number}","pulls_url":"https://api.github.com/repos/paulrenenichols/html-games/pulls{/number}","milestones_url":"https://api.github.com/repos/paulrenenichols/html-games/milestones{/number}","notifications_url":"https://api.github.com/repos/paulrenenichols/html-games/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paulrenenichols/html-games/labels{/name}","releases_url":"https://api.github.com/repos/paulrenenichols/html-games/releases{/id}","created_at":"2015-08-15T23:09:51Z","updated_at":"2015-08-23T22:07:12Z","pushed_at":"2015-08-23T23:53:17Z","git_url":"git://github.com/paulrenenichols/html-games.git","ssh_url":"git@github.com:paulrenenichols/html-games.git","clone_url":"https://github.com/paulrenenichols/html-games.git","svn_url":"https://github.com/paulrenenichols/html-games","homepage":null,"size":407,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paulrenenichols/html-games/pulls/1"},"html":{"href":"https://github.com/paulrenenichols/html-games/pull/1"},"issue":{"href":"https://api.github.com/repos/paulrenenichols/html-games/issues/1"},"comments":{"href":"https://api.github.com/repos/paulrenenichols/html-games/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/paulrenenichols/html-games/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/paulrenenichols/html-games/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paulrenenichols/html-games/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/paulrenenichols/html-games/statuses/4f91c63f17abee29f85a2825a29e9fbd06702aa1"}}}}