{"action":"closed","number":630,"pull_request":{"url":"https://api.github.com/repos/autotest/tp-libvirt/pulls/630","id":43003792,"html_url":"https://github.com/autotest/tp-libvirt/pull/630","diff_url":"https://github.com/autotest/tp-libvirt/pull/630.diff","patch_url":"https://github.com/autotest/tp-libvirt/pull/630.patch","issue_url":"https://api.github.com/repos/autotest/tp-libvirt/issues/630","number":630,"state":"closed","locked":false,"title":"macvtap: fix ping failure for passthrough case","user":{"login":"PandaWei","id":5038445,"avatar_url":"https://avatars.githubusercontent.com/u/5038445?v=3","gravatar_id":"","url":"https://api.github.com/users/PandaWei","html_url":"https://github.com/PandaWei","followers_url":"https://api.github.com/users/PandaWei/followers","following_url":"https://api.github.com/users/PandaWei/following{/other_user}","gists_url":"https://api.github.com/users/PandaWei/gists{/gist_id}","starred_url":"https://api.github.com/users/PandaWei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PandaWei/subscriptions","organizations_url":"https://api.github.com/users/PandaWei/orgs","repos_url":"https://api.github.com/users/PandaWei/repos","events_url":"https://api.github.com/users/PandaWei/events{/privacy}","received_events_url":"https://api.github.com/users/PandaWei/received_events","type":"User","site_admin":false},"body":"1) The macvtap NIC ifcfg-file that created by RemoteFile.add()\r\ndoesn't includes newline char '\\n', which leads to ifup fails,\r\nat the end, ping the remote server also fails. As following,\r\n\r\n[root@atest-guest ~]# cat /etc/redhat-release\r\nRed Hat Enterprise Linux Server release 7.2 Beta (Maipo)\r\n[root@atest-guest ~]# cat /etc/sysconfig/network-scripts/ifcfg-eth1\r\nDEVICE=eth1\r\nHWADDR=52:54:00:5b:96:02\r\nONBOOT=yes\r\nBOOTPROTO=static\r\nIPADDR=193.168.236.112[root@atest-guest ~]#\r\n[root@atest-guest ~]# ifup eth1\r\nCould not load file '/etc/sysconfig/network-scripts/ifcfg-eth1'\r\nCould not load file '/etc/sysconfig/network-scripts/ifcfg-eth1'\r\n\r\n*Fix it by adding newline char to the end of ifcfg-eth1.\r\n\r\n[root@atest-guest ~]# cat /etc/sysconfig/network-scripts/ifcfg-eth1\r\nDEVICE=eth1\r\nHWADDR=52:54:00:5b:96:02\r\nONBOOT=yes\r\nBOOTPROTO=static\r\nIPADDR=193.168.236.112\r\n[root@atest-guest ~]# ifup eth1\r\n[root@atest-guest ~]# ifconfig -a\r\neth1: flags=4163<UP,BROADCAST,RUNNING,MULTICAST>  mtu 1500\r\n  inet 193.168.236.112  netmask 255.255.255.0 broadcast 193.168.236.255\r\n  inet6 fe80::5054:ff:fe51:fca3  prefixlen 64 scopeid  0x20<link>\r\n  ... skip ...\r\n\r\n2) checking the result of ifdown and ifup.\r\n\r\nSigned-off-by: Wei,Jiangang <weijg.fnst@cn.fujitsu.com>","created_at":"2015-08-21T04:43:32Z","updated_at":"2015-09-25T01:36:45Z","closed_at":"2015-09-25T01:36:45Z","merged_at":"2015-09-25T01:36:45Z","merge_commit_sha":"3413df1bc241b3f4c4634d4370391b4b6129ad7f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/autotest/tp-libvirt/pulls/630/commits","review_comments_url":"https://api.github.com/repos/autotest/tp-libvirt/pulls/630/comments","review_comment_url":"https://api.github.com/repos/autotest/tp-libvirt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/autotest/tp-libvirt/issues/630/comments","statuses_url":"https://api.github.com/repos/autotest/tp-libvirt/statuses/7c8ffd4ee9b1d4fe5e0bb61feef405b14574d9fe","head":{"label":"PandaWei:macvtap","ref":"macvtap","sha":"7c8ffd4ee9b1d4fe5e0bb61feef405b14574d9fe","user":{"login":"PandaWei","id":5038445,"avatar_url":"https://avatars.githubusercontent.com/u/5038445?v=3","gravatar_id":"","url":"https://api.github.com/users/PandaWei","html_url":"https://github.com/PandaWei","followers_url":"https://api.github.com/users/PandaWei/followers","following_url":"https://api.github.com/users/PandaWei/following{/other_user}","gists_url":"https://api.github.com/users/PandaWei/gists{/gist_id}","starred_url":"https://api.github.com/users/PandaWei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PandaWei/subscriptions","organizations_url":"https://api.github.com/users/PandaWei/orgs","repos_url":"https://api.github.com/users/PandaWei/repos","events_url":"https://api.github.com/users/PandaWei/events{/privacy}","received_events_url":"https://api.github.com/users/PandaWei/received_events","type":"User","site_admin":false},"repo":{"id":24629786,"name":"tp-libvirt","full_name":"PandaWei/tp-libvirt","owner":{"login":"PandaWei","id":5038445,"avatar_url":"https://avatars.githubusercontent.com/u/5038445?v=3","gravatar_id":"","url":"https://api.github.com/users/PandaWei","html_url":"https://github.com/PandaWei","followers_url":"https://api.github.com/users/PandaWei/followers","following_url":"https://api.github.com/users/PandaWei/following{/other_user}","gists_url":"https://api.github.com/users/PandaWei/gists{/gist_id}","starred_url":"https://api.github.com/users/PandaWei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PandaWei/subscriptions","organizations_url":"https://api.github.com/users/PandaWei/orgs","repos_url":"https://api.github.com/users/PandaWei/repos","events_url":"https://api.github.com/users/PandaWei/events{/privacy}","received_events_url":"https://api.github.com/users/PandaWei/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PandaWei/tp-libvirt","description":"Test Provider for Libvirt and related virtualization backends","fork":true,"url":"https://api.github.com/repos/PandaWei/tp-libvirt","forks_url":"https://api.github.com/repos/PandaWei/tp-libvirt/forks","keys_url":"https://api.github.com/repos/PandaWei/tp-libvirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PandaWei/tp-libvirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PandaWei/tp-libvirt/teams","hooks_url":"https://api.github.com/repos/PandaWei/tp-libvirt/hooks","issue_events_url":"https://api.github.com/repos/PandaWei/tp-libvirt/issues/events{/number}","events_url":"https://api.github.com/repos/PandaWei/tp-libvirt/events","assignees_url":"https://api.github.com/repos/PandaWei/tp-libvirt/assignees{/user}","branches_url":"https://api.github.com/repos/PandaWei/tp-libvirt/branches{/branch}","tags_url":"https://api.github.com/repos/PandaWei/tp-libvirt/tags","blobs_url":"https://api.github.com/repos/PandaWei/tp-libvirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PandaWei/tp-libvirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PandaWei/tp-libvirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/PandaWei/tp-libvirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PandaWei/tp-libvirt/statuses/{sha}","languages_url":"https://api.github.com/repos/PandaWei/tp-libvirt/languages","stargazers_url":"https://api.github.com/repos/PandaWei/tp-libvirt/stargazers","contributors_url":"https://api.github.com/repos/PandaWei/tp-libvirt/contributors","subscribers_url":"https://api.github.com/repos/PandaWei/tp-libvirt/subscribers","subscription_url":"https://api.github.com/repos/PandaWei/tp-libvirt/subscription","commits_url":"https://api.github.com/repos/PandaWei/tp-libvirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/PandaWei/tp-libvirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/PandaWei/tp-libvirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/PandaWei/tp-libvirt/issues/comments{/number}","contents_url":"https://api.github.com/repos/PandaWei/tp-libvirt/contents/{+path}","compare_url":"https://api.github.com/repos/PandaWei/tp-libvirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PandaWei/tp-libvirt/merges","archive_url":"https://api.github.com/repos/PandaWei/tp-libvirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PandaWei/tp-libvirt/downloads","issues_url":"https://api.github.com/repos/PandaWei/tp-libvirt/issues{/number}","pulls_url":"https://api.github.com/repos/PandaWei/tp-libvirt/pulls{/number}","milestones_url":"https://api.github.com/repos/PandaWei/tp-libvirt/milestones{/number}","notifications_url":"https://api.github.com/repos/PandaWei/tp-libvirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PandaWei/tp-libvirt/labels{/name}","releases_url":"https://api.github.com/repos/PandaWei/tp-libvirt/releases{/id}","created_at":"2014-09-30T08:06:04Z","updated_at":"2014-11-28T04:48:07Z","pushed_at":"2015-09-17T05:48:20Z","git_url":"git://github.com/PandaWei/tp-libvirt.git","ssh_url":"git@github.com:PandaWei/tp-libvirt.git","clone_url":"https://github.com/PandaWei/tp-libvirt.git","svn_url":"https://github.com/PandaWei/tp-libvirt","homepage":null,"size":10404,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"autotest:master","ref":"master","sha":"55400cdf86e677ba77922abb17bf503f89a991c3","user":{"login":"autotest","id":472856,"avatar_url":"https://avatars.githubusercontent.com/u/472856?v=3","gravatar_id":"","url":"https://api.github.com/users/autotest","html_url":"https://github.com/autotest","followers_url":"https://api.github.com/users/autotest/followers","following_url":"https://api.github.com/users/autotest/following{/other_user}","gists_url":"https://api.github.com/users/autotest/gists{/gist_id}","starred_url":"https://api.github.com/users/autotest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autotest/subscriptions","organizations_url":"https://api.github.com/users/autotest/orgs","repos_url":"https://api.github.com/users/autotest/repos","events_url":"https://api.github.com/users/autotest/events{/privacy}","received_events_url":"https://api.github.com/users/autotest/received_events","type":"Organization","site_admin":false},"repo":{"id":16180517,"name":"tp-libvirt","full_name":"autotest/tp-libvirt","owner":{"login":"autotest","id":472856,"avatar_url":"https://avatars.githubusercontent.com/u/472856?v=3","gravatar_id":"","url":"https://api.github.com/users/autotest","html_url":"https://github.com/autotest","followers_url":"https://api.github.com/users/autotest/followers","following_url":"https://api.github.com/users/autotest/following{/other_user}","gists_url":"https://api.github.com/users/autotest/gists{/gist_id}","starred_url":"https://api.github.com/users/autotest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autotest/subscriptions","organizations_url":"https://api.github.com/users/autotest/orgs","repos_url":"https://api.github.com/users/autotest/repos","events_url":"https://api.github.com/users/autotest/events{/privacy}","received_events_url":"https://api.github.com/users/autotest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/autotest/tp-libvirt","description":"Test Provider for Libvirt and related virtualization backends","fork":false,"url":"https://api.github.com/repos/autotest/tp-libvirt","forks_url":"https://api.github.com/repos/autotest/tp-libvirt/forks","keys_url":"https://api.github.com/repos/autotest/tp-libvirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/autotest/tp-libvirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/autotest/tp-libvirt/teams","hooks_url":"https://api.github.com/repos/autotest/tp-libvirt/hooks","issue_events_url":"https://api.github.com/repos/autotest/tp-libvirt/issues/events{/number}","events_url":"https://api.github.com/repos/autotest/tp-libvirt/events","assignees_url":"https://api.github.com/repos/autotest/tp-libvirt/assignees{/user}","branches_url":"https://api.github.com/repos/autotest/tp-libvirt/branches{/branch}","tags_url":"https://api.github.com/repos/autotest/tp-libvirt/tags","blobs_url":"https://api.github.com/repos/autotest/tp-libvirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/autotest/tp-libvirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/autotest/tp-libvirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/autotest/tp-libvirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/autotest/tp-libvirt/statuses/{sha}","languages_url":"https://api.github.com/repos/autotest/tp-libvirt/languages","stargazers_url":"https://api.github.com/repos/autotest/tp-libvirt/stargazers","contributors_url":"https://api.github.com/repos/autotest/tp-libvirt/contributors","subscribers_url":"https://api.github.com/repos/autotest/tp-libvirt/subscribers","subscription_url":"https://api.github.com/repos/autotest/tp-libvirt/subscription","commits_url":"https://api.github.com/repos/autotest/tp-libvirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/autotest/tp-libvirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/autotest/tp-libvirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/autotest/tp-libvirt/issues/comments{/number}","contents_url":"https://api.github.com/repos/autotest/tp-libvirt/contents/{+path}","compare_url":"https://api.github.com/repos/autotest/tp-libvirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/autotest/tp-libvirt/merges","archive_url":"https://api.github.com/repos/autotest/tp-libvirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/autotest/tp-libvirt/downloads","issues_url":"https://api.github.com/repos/autotest/tp-libvirt/issues{/number}","pulls_url":"https://api.github.com/repos/autotest/tp-libvirt/pulls{/number}","milestones_url":"https://api.github.com/repos/autotest/tp-libvirt/milestones{/number}","notifications_url":"https://api.github.com/repos/autotest/tp-libvirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/autotest/tp-libvirt/labels{/name}","releases_url":"https://api.github.com/repos/autotest/tp-libvirt/releases{/id}","created_at":"2014-01-23T17:58:18Z","updated_at":"2015-07-30T04:48:35Z","pushed_at":"2015-09-25T01:36:45Z","git_url":"git://github.com/autotest/tp-libvirt.git","ssh_url":"git@github.com:autotest/tp-libvirt.git","clone_url":"https://github.com/autotest/tp-libvirt.git","svn_url":"https://github.com/autotest/tp-libvirt","homepage":null,"size":16310,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":47,"forks":46,"open_issues":47,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/autotest/tp-libvirt/pulls/630"},"html":{"href":"https://github.com/autotest/tp-libvirt/pull/630"},"issue":{"href":"https://api.github.com/repos/autotest/tp-libvirt/issues/630"},"comments":{"href":"https://api.github.com/repos/autotest/tp-libvirt/issues/630/comments"},"review_comments":{"href":"https://api.github.com/repos/autotest/tp-libvirt/pulls/630/comments"},"review_comment":{"href":"https://api.github.com/repos/autotest/tp-libvirt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/autotest/tp-libvirt/pulls/630/commits"},"statuses":{"href":"https://api.github.com/repos/autotest/tp-libvirt/statuses/7c8ffd4ee9b1d4fe5e0bb61feef405b14574d9fe"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"PandaWei","id":5038445,"avatar_url":"https://avatars.githubusercontent.com/u/5038445?v=3","gravatar_id":"","url":"https://api.github.com/users/PandaWei","html_url":"https://github.com/PandaWei","followers_url":"https://api.github.com/users/PandaWei/followers","following_url":"https://api.github.com/users/PandaWei/following{/other_user}","gists_url":"https://api.github.com/users/PandaWei/gists{/gist_id}","starred_url":"https://api.github.com/users/PandaWei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PandaWei/subscriptions","organizations_url":"https://api.github.com/users/PandaWei/orgs","repos_url":"https://api.github.com/users/PandaWei/repos","events_url":"https://api.github.com/users/PandaWei/events{/privacy}","received_events_url":"https://api.github.com/users/PandaWei/received_events","type":"User","site_admin":false},"comments":7,"review_comments":0,"commits":1,"additions":3,"deletions":3,"changed_files":1}}