{"action":"created","issue":{"url":"https://api.github.com/repos/sakaiproject/sakai/issues/530","labels_url":"https://api.github.com/repos/sakaiproject/sakai/issues/530/labels{/name}","comments_url":"https://api.github.com/repos/sakaiproject/sakai/issues/530/comments","events_url":"https://api.github.com/repos/sakaiproject/sakai/issues/530/events","html_url":"https://github.com/sakaiproject/sakai/pull/530","id":77630273,"number":530,"title":"SAK-21872: Citations copy/duplicate doesn't work as expected.","user":{"login":"nicholaswilson100","id":7457681,"avatar_url":"https://avatars.githubusercontent.com/u/7457681?v=3","gravatar_id":"","url":"https://api.github.com/users/nicholaswilson100","html_url":"https://github.com/nicholaswilson100","followers_url":"https://api.github.com/users/nicholaswilson100/followers","following_url":"https://api.github.com/users/nicholaswilson100/following{/other_user}","gists_url":"https://api.github.com/users/nicholaswilson100/gists{/gist_id}","starred_url":"https://api.github.com/users/nicholaswilson100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicholaswilson100/subscriptions","organizations_url":"https://api.github.com/users/nicholaswilson100/orgs","repos_url":"https://api.github.com/users/nicholaswilson100/repos","events_url":"https://api.github.com/users/nicholaswilson100/events{/privacy}","received_events_url":"https://api.github.com/users/nicholaswilson100/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-18T12:02:38Z","updated_at":"2015-05-19T22:57:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sakaiproject/sakai/pulls/530","html_url":"https://github.com/sakaiproject/sakai/pull/530","diff_url":"https://github.com/sakaiproject/sakai/pull/530.diff","patch_url":"https://github.com/sakaiproject/sakai/pull/530.patch"},"body":"The problem with copying/duplicating a reading list is that BaseCitationService.set(BasicCitationCollection) is called from both checkForUpdates() (which  reloads the BaseCitationCollection fresh from the database) and also from copy(BasicCitationCollection) (which is supposed to genuinely copy a BaseCitationCollection in the database). But set(BasicCitationCollection) never saves any new CITATION_CITATIONs because the citations are always explicitly set to temporary=false, i.e., they are already saved in the db (line 3223).\r\n\r\nThis change passes through 'temporary=true' to the set(BasicCitationCollection) method when it is called from the copy(BasicCitationCollection) method (and therefore saves CITATION_CITATIONs) and 'temporary=false' otherwise.\r\n"},"comment":{"url":"https://api.github.com/repos/sakaiproject/sakai/issues/comments/103691309","html_url":"https://github.com/sakaiproject/sakai/pull/530#issuecomment-103691309","issue_url":"https://api.github.com/repos/sakaiproject/sakai/issues/530","id":103691309,"user":{"login":"ottenhoff","id":810505,"avatar_url":"https://avatars.githubusercontent.com/u/810505?v=3","gravatar_id":"","url":"https://api.github.com/users/ottenhoff","html_url":"https://github.com/ottenhoff","followers_url":"https://api.github.com/users/ottenhoff/followers","following_url":"https://api.github.com/users/ottenhoff/following{/other_user}","gists_url":"https://api.github.com/users/ottenhoff/gists{/gist_id}","starred_url":"https://api.github.com/users/ottenhoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ottenhoff/subscriptions","organizations_url":"https://api.github.com/users/ottenhoff/orgs","repos_url":"https://api.github.com/users/ottenhoff/repos","events_url":"https://api.github.com/users/ottenhoff/events{/privacy}","received_events_url":"https://api.github.com/users/ottenhoff/received_events","type":"User","site_admin":false},"created_at":"2015-05-19T22:57:17Z","updated_at":"2015-05-19T22:57:17Z","body":"Ok, LGTM"}}