{"action":"closed","number":23,"pull_request":{"url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/pulls/23","id":33964385,"html_url":"https://github.com/adonespitogo/angular-base64-upload/pull/23","diff_url":"https://github.com/adonespitogo/angular-base64-upload/pull/23.diff","patch_url":"https://github.com/adonespitogo/angular-base64-upload/pull/23.patch","issue_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/issues/23","number":23,"state":"closed","locked":false,"title":"Reimplemented image preview as directive","user":{"login":"drola","id":1074328,"avatar_url":"https://avatars.githubusercontent.com/u/1074328?v=3","gravatar_id":"","url":"https://api.github.com/users/drola","html_url":"https://github.com/drola","followers_url":"https://api.github.com/users/drola/followers","following_url":"https://api.github.com/users/drola/following{/other_user}","gists_url":"https://api.github.com/users/drola/gists{/gist_id}","starred_url":"https://api.github.com/users/drola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drola/subscriptions","organizations_url":"https://api.github.com/users/drola/orgs","repos_url":"https://api.github.com/users/drola/repos","events_url":"https://api.github.com/users/drola/events{/privacy}","received_events_url":"https://api.github.com/users/drola/received_events","type":"User","site_admin":false},"body":"I reimplemented image preview as a directive because `ngModel.$setViewValue()` seemed to remove `dataURI()` function from the object.\r\n\r\nImage preview is now a separate directive `baseSixtyFourImage`. Additionally it supports `base-sixty-four-image-placeholder` attribute. That attribute should contain the path to a place-holder image.\r\n\r\nI also fixed `_assemble_data_uri()` which used to prepend `image/` to MIME type. That was unnecessary because `fileObject.filetype` already contains full MIME type, for example `image/jpeg`.","created_at":"2015-04-23T15:04:36Z","updated_at":"2015-04-23T15:31:39Z","closed_at":"2015-04-23T15:31:39Z","merged_at":"2015-04-23T15:31:39Z","merge_commit_sha":"3b1efe94daed772bc6acedb443d255077de574a3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/pulls/23/commits","review_comments_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/pulls/23/comments","review_comment_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/pulls/comments{/number}","comments_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/issues/23/comments","statuses_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/statuses/75207d2b02aabe6e5c92389acc0b174ee3bc9ca7","head":{"label":"drola:master","ref":"master","sha":"75207d2b02aabe6e5c92389acc0b174ee3bc9ca7","user":{"login":"drola","id":1074328,"avatar_url":"https://avatars.githubusercontent.com/u/1074328?v=3","gravatar_id":"","url":"https://api.github.com/users/drola","html_url":"https://github.com/drola","followers_url":"https://api.github.com/users/drola/followers","following_url":"https://api.github.com/users/drola/following{/other_user}","gists_url":"https://api.github.com/users/drola/gists{/gist_id}","starred_url":"https://api.github.com/users/drola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drola/subscriptions","organizations_url":"https://api.github.com/users/drola/orgs","repos_url":"https://api.github.com/users/drola/repos","events_url":"https://api.github.com/users/drola/events{/privacy}","received_events_url":"https://api.github.com/users/drola/received_events","type":"User","site_admin":false},"repo":{"id":34457344,"name":"angular-base64-upload","full_name":"drola/angular-base64-upload","owner":{"login":"drola","id":1074328,"avatar_url":"https://avatars.githubusercontent.com/u/1074328?v=3","gravatar_id":"","url":"https://api.github.com/users/drola","html_url":"https://github.com/drola","followers_url":"https://api.github.com/users/drola/followers","following_url":"https://api.github.com/users/drola/following{/other_user}","gists_url":"https://api.github.com/users/drola/gists{/gist_id}","starred_url":"https://api.github.com/users/drola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drola/subscriptions","organizations_url":"https://api.github.com/users/drola/orgs","repos_url":"https://api.github.com/users/drola/repos","events_url":"https://api.github.com/users/drola/events{/privacy}","received_events_url":"https://api.github.com/users/drola/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drola/angular-base64-upload","description":"Angular directive for uploading base64-encoded files that you can pass along with the resource model.","fork":true,"url":"https://api.github.com/repos/drola/angular-base64-upload","forks_url":"https://api.github.com/repos/drola/angular-base64-upload/forks","keys_url":"https://api.github.com/repos/drola/angular-base64-upload/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drola/angular-base64-upload/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drola/angular-base64-upload/teams","hooks_url":"https://api.github.com/repos/drola/angular-base64-upload/hooks","issue_events_url":"https://api.github.com/repos/drola/angular-base64-upload/issues/events{/number}","events_url":"https://api.github.com/repos/drola/angular-base64-upload/events","assignees_url":"https://api.github.com/repos/drola/angular-base64-upload/assignees{/user}","branches_url":"https://api.github.com/repos/drola/angular-base64-upload/branches{/branch}","tags_url":"https://api.github.com/repos/drola/angular-base64-upload/tags","blobs_url":"https://api.github.com/repos/drola/angular-base64-upload/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drola/angular-base64-upload/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drola/angular-base64-upload/git/refs{/sha}","trees_url":"https://api.github.com/repos/drola/angular-base64-upload/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drola/angular-base64-upload/statuses/{sha}","languages_url":"https://api.github.com/repos/drola/angular-base64-upload/languages","stargazers_url":"https://api.github.com/repos/drola/angular-base64-upload/stargazers","contributors_url":"https://api.github.com/repos/drola/angular-base64-upload/contributors","subscribers_url":"https://api.github.com/repos/drola/angular-base64-upload/subscribers","subscription_url":"https://api.github.com/repos/drola/angular-base64-upload/subscription","commits_url":"https://api.github.com/repos/drola/angular-base64-upload/commits{/sha}","git_commits_url":"https://api.github.com/repos/drola/angular-base64-upload/git/commits{/sha}","comments_url":"https://api.github.com/repos/drola/angular-base64-upload/comments{/number}","issue_comment_url":"https://api.github.com/repos/drola/angular-base64-upload/issues/comments{/number}","contents_url":"https://api.github.com/repos/drola/angular-base64-upload/contents/{+path}","compare_url":"https://api.github.com/repos/drola/angular-base64-upload/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drola/angular-base64-upload/merges","archive_url":"https://api.github.com/repos/drola/angular-base64-upload/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drola/angular-base64-upload/downloads","issues_url":"https://api.github.com/repos/drola/angular-base64-upload/issues{/number}","pulls_url":"https://api.github.com/repos/drola/angular-base64-upload/pulls{/number}","milestones_url":"https://api.github.com/repos/drola/angular-base64-upload/milestones{/number}","notifications_url":"https://api.github.com/repos/drola/angular-base64-upload/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drola/angular-base64-upload/labels{/name}","releases_url":"https://api.github.com/repos/drola/angular-base64-upload/releases{/id}","created_at":"2015-04-23T13:18:44Z","updated_at":"2015-04-23T13:45:38Z","pushed_at":"2015-04-23T13:45:38Z","git_url":"git://github.com/drola/angular-base64-upload.git","ssh_url":"git@github.com:drola/angular-base64-upload.git","clone_url":"https://github.com/drola/angular-base64-upload.git","svn_url":"https://github.com/drola/angular-base64-upload","homepage":null,"size":418,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"adonespitogo:master","ref":"master","sha":"355adb5c40f76a85ac31fe7d6e27dfcfd82985ad","user":{"login":"adonespitogo","id":3839684,"avatar_url":"https://avatars.githubusercontent.com/u/3839684?v=3","gravatar_id":"","url":"https://api.github.com/users/adonespitogo","html_url":"https://github.com/adonespitogo","followers_url":"https://api.github.com/users/adonespitogo/followers","following_url":"https://api.github.com/users/adonespitogo/following{/other_user}","gists_url":"https://api.github.com/users/adonespitogo/gists{/gist_id}","starred_url":"https://api.github.com/users/adonespitogo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adonespitogo/subscriptions","organizations_url":"https://api.github.com/users/adonespitogo/orgs","repos_url":"https://api.github.com/users/adonespitogo/repos","events_url":"https://api.github.com/users/adonespitogo/events{/privacy}","received_events_url":"https://api.github.com/users/adonespitogo/received_events","type":"User","site_admin":false},"repo":{"id":22988762,"name":"angular-base64-upload","full_name":"adonespitogo/angular-base64-upload","owner":{"login":"adonespitogo","id":3839684,"avatar_url":"https://avatars.githubusercontent.com/u/3839684?v=3","gravatar_id":"","url":"https://api.github.com/users/adonespitogo","html_url":"https://github.com/adonespitogo","followers_url":"https://api.github.com/users/adonespitogo/followers","following_url":"https://api.github.com/users/adonespitogo/following{/other_user}","gists_url":"https://api.github.com/users/adonespitogo/gists{/gist_id}","starred_url":"https://api.github.com/users/adonespitogo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adonespitogo/subscriptions","organizations_url":"https://api.github.com/users/adonespitogo/orgs","repos_url":"https://api.github.com/users/adonespitogo/repos","events_url":"https://api.github.com/users/adonespitogo/events{/privacy}","received_events_url":"https://api.github.com/users/adonespitogo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adonespitogo/angular-base64-upload","description":"Angular directive for uploading base64-encoded files that you can pass along with the resource model.","fork":false,"url":"https://api.github.com/repos/adonespitogo/angular-base64-upload","forks_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/forks","keys_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/teams","hooks_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/hooks","issue_events_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/issues/events{/number}","events_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/events","assignees_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/assignees{/user}","branches_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/branches{/branch}","tags_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/tags","blobs_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/git/refs{/sha}","trees_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/statuses/{sha}","languages_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/languages","stargazers_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/stargazers","contributors_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/contributors","subscribers_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/subscribers","subscription_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/subscription","commits_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/commits{/sha}","git_commits_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/git/commits{/sha}","comments_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/comments{/number}","issue_comment_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/issues/comments{/number}","contents_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/contents/{+path}","compare_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/merges","archive_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/downloads","issues_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/issues{/number}","pulls_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/pulls{/number}","milestones_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/milestones{/number}","notifications_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/labels{/name}","releases_url":"https://api.github.com/repos/adonespitogo/angular-base64-upload/releases{/id}","created_at":"2014-08-15T12:22:20Z","updated_at":"2015-04-22T22:01:51Z","pushed_at":"2015-04-23T15:31:39Z","git_url":"git://github.com/adonespitogo/angular-base64-upload.git","ssh_url":"git@github.com:adonespitogo/angular-base64-upload.git","clone_url":"https://github.com/adonespitogo/angular-base64-upload.git","svn_url":"https://github.com/adonespitogo/angular-base64-upload","homepage":null,"size":418,"stargazers_count":48,"watchers_count":48,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":3,"forks":21,"open_issues":3,"watchers":48,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/adonespitogo/angular-base64-upload/pulls/23"},"html":{"href":"https://github.com/adonespitogo/angular-base64-upload/pull/23"},"issue":{"href":"https://api.github.com/repos/adonespitogo/angular-base64-upload/issues/23"},"comments":{"href":"https://api.github.com/repos/adonespitogo/angular-base64-upload/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/adonespitogo/angular-base64-upload/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/adonespitogo/angular-base64-upload/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/adonespitogo/angular-base64-upload/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/adonespitogo/angular-base64-upload/statuses/75207d2b02aabe6e5c92389acc0b174ee3bc9ca7"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"adonespitogo","id":3839684,"avatar_url":"https://avatars.githubusercontent.com/u/3839684?v=3","gravatar_id":"","url":"https://api.github.com/users/adonespitogo","html_url":"https://github.com/adonespitogo","followers_url":"https://api.github.com/users/adonespitogo/followers","following_url":"https://api.github.com/users/adonespitogo/following{/other_user}","gists_url":"https://api.github.com/users/adonespitogo/gists{/gist_id}","starred_url":"https://api.github.com/users/adonespitogo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adonespitogo/subscriptions","organizations_url":"https://api.github.com/users/adonespitogo/orgs","repos_url":"https://api.github.com/users/adonespitogo/repos","events_url":"https://api.github.com/users/adonespitogo/events{/privacy}","received_events_url":"https://api.github.com/users/adonespitogo/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":51,"deletions":17,"changed_files":6}}