{"action":"closed","number":1787,"pull_request":{"url":"https://api.github.com/repos/pfsense/pfsense/pulls/1787","id":40866094,"html_url":"https://github.com/pfsense/pfsense/pull/1787","diff_url":"https://github.com/pfsense/pfsense/pull/1787.diff","patch_url":"https://github.com/pfsense/pfsense/pull/1787.patch","issue_url":"https://api.github.com/repos/pfsense/pfsense/issues/1787","number":1787,"state":"closed","locked":false,"title":"Pkg related cleanups and fixes","user":{"login":"k-paulius","id":11000060,"avatar_url":"https://avatars.githubusercontent.com/u/11000060?v=3","gravatar_id":"","url":"https://api.github.com/users/k-paulius","html_url":"https://github.com/k-paulius","followers_url":"https://api.github.com/users/k-paulius/followers","following_url":"https://api.github.com/users/k-paulius/following{/other_user}","gists_url":"https://api.github.com/users/k-paulius/gists{/gist_id}","starred_url":"https://api.github.com/users/k-paulius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k-paulius/subscriptions","organizations_url":"https://api.github.com/users/k-paulius/orgs","repos_url":"https://api.github.com/users/k-paulius/repos","events_url":"https://api.github.com/users/k-paulius/events{/privacy}","received_events_url":"https://api.github.com/users/k-paulius/received_events","type":"User","site_admin":false},"body":"Removing some unused variables and initializing variables that are not being initialized. Also fixing issue with default value assignment. The code was only checking if $a_pkg[$id] existed instead of $a_pkg[$id][$fieldname] before assigning value when loading the form. This caused default value to never be displayed for any new fields added to the package xml.","created_at":"2015-07-27T02:36:37Z","updated_at":"2015-09-21T19:10:12Z","closed_at":"2015-09-21T19:10:12Z","merged_at":"2015-09-21T19:10:12Z","merge_commit_sha":"c4044e67cd7f40b888c5b602f7a2367a991d1b8c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pfsense/pfsense/pulls/1787/commits","review_comments_url":"https://api.github.com/repos/pfsense/pfsense/pulls/1787/comments","review_comment_url":"https://api.github.com/repos/pfsense/pfsense/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pfsense/pfsense/issues/1787/comments","statuses_url":"https://api.github.com/repos/pfsense/pfsense/statuses/8141416fb2dab0349a938eeaa2563253b489dfe7","head":{"label":"k-paulius:patch-pkg-1","ref":"patch-pkg-1","sha":"8141416fb2dab0349a938eeaa2563253b489dfe7","user":{"login":"k-paulius","id":11000060,"avatar_url":"https://avatars.githubusercontent.com/u/11000060?v=3","gravatar_id":"","url":"https://api.github.com/users/k-paulius","html_url":"https://github.com/k-paulius","followers_url":"https://api.github.com/users/k-paulius/followers","following_url":"https://api.github.com/users/k-paulius/following{/other_user}","gists_url":"https://api.github.com/users/k-paulius/gists{/gist_id}","starred_url":"https://api.github.com/users/k-paulius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k-paulius/subscriptions","organizations_url":"https://api.github.com/users/k-paulius/orgs","repos_url":"https://api.github.com/users/k-paulius/repos","events_url":"https://api.github.com/users/k-paulius/events{/privacy}","received_events_url":"https://api.github.com/users/k-paulius/received_events","type":"User","site_admin":false},"repo":{"id":30817194,"name":"pfsense","full_name":"k-paulius/pfsense","owner":{"login":"k-paulius","id":11000060,"avatar_url":"https://avatars.githubusercontent.com/u/11000060?v=3","gravatar_id":"","url":"https://api.github.com/users/k-paulius","html_url":"https://github.com/k-paulius","followers_url":"https://api.github.com/users/k-paulius/followers","following_url":"https://api.github.com/users/k-paulius/following{/other_user}","gists_url":"https://api.github.com/users/k-paulius/gists{/gist_id}","starred_url":"https://api.github.com/users/k-paulius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k-paulius/subscriptions","organizations_url":"https://api.github.com/users/k-paulius/orgs","repos_url":"https://api.github.com/users/k-paulius/repos","events_url":"https://api.github.com/users/k-paulius/events{/privacy}","received_events_url":"https://api.github.com/users/k-paulius/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/k-paulius/pfsense","description":"Main repository for pfSense","fork":true,"url":"https://api.github.com/repos/k-paulius/pfsense","forks_url":"https://api.github.com/repos/k-paulius/pfsense/forks","keys_url":"https://api.github.com/repos/k-paulius/pfsense/keys{/key_id}","collaborators_url":"https://api.github.com/repos/k-paulius/pfsense/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/k-paulius/pfsense/teams","hooks_url":"https://api.github.com/repos/k-paulius/pfsense/hooks","issue_events_url":"https://api.github.com/repos/k-paulius/pfsense/issues/events{/number}","events_url":"https://api.github.com/repos/k-paulius/pfsense/events","assignees_url":"https://api.github.com/repos/k-paulius/pfsense/assignees{/user}","branches_url":"https://api.github.com/repos/k-paulius/pfsense/branches{/branch}","tags_url":"https://api.github.com/repos/k-paulius/pfsense/tags","blobs_url":"https://api.github.com/repos/k-paulius/pfsense/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/k-paulius/pfsense/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/k-paulius/pfsense/git/refs{/sha}","trees_url":"https://api.github.com/repos/k-paulius/pfsense/git/trees{/sha}","statuses_url":"https://api.github.com/repos/k-paulius/pfsense/statuses/{sha}","languages_url":"https://api.github.com/repos/k-paulius/pfsense/languages","stargazers_url":"https://api.github.com/repos/k-paulius/pfsense/stargazers","contributors_url":"https://api.github.com/repos/k-paulius/pfsense/contributors","subscribers_url":"https://api.github.com/repos/k-paulius/pfsense/subscribers","subscription_url":"https://api.github.com/repos/k-paulius/pfsense/subscription","commits_url":"https://api.github.com/repos/k-paulius/pfsense/commits{/sha}","git_commits_url":"https://api.github.com/repos/k-paulius/pfsense/git/commits{/sha}","comments_url":"https://api.github.com/repos/k-paulius/pfsense/comments{/number}","issue_comment_url":"https://api.github.com/repos/k-paulius/pfsense/issues/comments{/number}","contents_url":"https://api.github.com/repos/k-paulius/pfsense/contents/{+path}","compare_url":"https://api.github.com/repos/k-paulius/pfsense/compare/{base}...{head}","merges_url":"https://api.github.com/repos/k-paulius/pfsense/merges","archive_url":"https://api.github.com/repos/k-paulius/pfsense/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/k-paulius/pfsense/downloads","issues_url":"https://api.github.com/repos/k-paulius/pfsense/issues{/number}","pulls_url":"https://api.github.com/repos/k-paulius/pfsense/pulls{/number}","milestones_url":"https://api.github.com/repos/k-paulius/pfsense/milestones{/number}","notifications_url":"https://api.github.com/repos/k-paulius/pfsense/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/k-paulius/pfsense/labels{/name}","releases_url":"https://api.github.com/repos/k-paulius/pfsense/releases{/id}","created_at":"2015-02-15T03:54:49Z","updated_at":"2015-03-31T03:14:40Z","pushed_at":"2015-09-12T01:49:50Z","git_url":"git://github.com/k-paulius/pfsense.git","ssh_url":"git@github.com:k-paulius/pfsense.git","clone_url":"https://github.com/k-paulius/pfsense.git","svn_url":"https://github.com/k-paulius/pfsense","homepage":"http://www.pfsense.org","size":69088,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pfsense:master","ref":"master","sha":"a34e980753ec72d71c91c98a28c08b20caa30535","user":{"login":"pfsense","id":3716965,"avatar_url":"https://avatars.githubusercontent.com/u/3716965?v=3","gravatar_id":"","url":"https://api.github.com/users/pfsense","html_url":"https://github.com/pfsense","followers_url":"https://api.github.com/users/pfsense/followers","following_url":"https://api.github.com/users/pfsense/following{/other_user}","gists_url":"https://api.github.com/users/pfsense/gists{/gist_id}","starred_url":"https://api.github.com/users/pfsense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfsense/subscriptions","organizations_url":"https://api.github.com/users/pfsense/orgs","repos_url":"https://api.github.com/users/pfsense/repos","events_url":"https://api.github.com/users/pfsense/events{/privacy}","received_events_url":"https://api.github.com/users/pfsense/received_events","type":"Organization","site_admin":false},"repo":{"id":1740040,"name":"pfsense","full_name":"pfsense/pfsense","owner":{"login":"pfsense","id":3716965,"avatar_url":"https://avatars.githubusercontent.com/u/3716965?v=3","gravatar_id":"","url":"https://api.github.com/users/pfsense","html_url":"https://github.com/pfsense","followers_url":"https://api.github.com/users/pfsense/followers","following_url":"https://api.github.com/users/pfsense/following{/other_user}","gists_url":"https://api.github.com/users/pfsense/gists{/gist_id}","starred_url":"https://api.github.com/users/pfsense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfsense/subscriptions","organizations_url":"https://api.github.com/users/pfsense/orgs","repos_url":"https://api.github.com/users/pfsense/repos","events_url":"https://api.github.com/users/pfsense/events{/privacy}","received_events_url":"https://api.github.com/users/pfsense/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pfsense/pfsense","description":"Main repository for pfSense","fork":false,"url":"https://api.github.com/repos/pfsense/pfsense","forks_url":"https://api.github.com/repos/pfsense/pfsense/forks","keys_url":"https://api.github.com/repos/pfsense/pfsense/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pfsense/pfsense/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pfsense/pfsense/teams","hooks_url":"https://api.github.com/repos/pfsense/pfsense/hooks","issue_events_url":"https://api.github.com/repos/pfsense/pfsense/issues/events{/number}","events_url":"https://api.github.com/repos/pfsense/pfsense/events","assignees_url":"https://api.github.com/repos/pfsense/pfsense/assignees{/user}","branches_url":"https://api.github.com/repos/pfsense/pfsense/branches{/branch}","tags_url":"https://api.github.com/repos/pfsense/pfsense/tags","blobs_url":"https://api.github.com/repos/pfsense/pfsense/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pfsense/pfsense/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pfsense/pfsense/git/refs{/sha}","trees_url":"https://api.github.com/repos/pfsense/pfsense/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pfsense/pfsense/statuses/{sha}","languages_url":"https://api.github.com/repos/pfsense/pfsense/languages","stargazers_url":"https://api.github.com/repos/pfsense/pfsense/stargazers","contributors_url":"https://api.github.com/repos/pfsense/pfsense/contributors","subscribers_url":"https://api.github.com/repos/pfsense/pfsense/subscribers","subscription_url":"https://api.github.com/repos/pfsense/pfsense/subscription","commits_url":"https://api.github.com/repos/pfsense/pfsense/commits{/sha}","git_commits_url":"https://api.github.com/repos/pfsense/pfsense/git/commits{/sha}","comments_url":"https://api.github.com/repos/pfsense/pfsense/comments{/number}","issue_comment_url":"https://api.github.com/repos/pfsense/pfsense/issues/comments{/number}","contents_url":"https://api.github.com/repos/pfsense/pfsense/contents/{+path}","compare_url":"https://api.github.com/repos/pfsense/pfsense/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pfsense/pfsense/merges","archive_url":"https://api.github.com/repos/pfsense/pfsense/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pfsense/pfsense/downloads","issues_url":"https://api.github.com/repos/pfsense/pfsense/issues{/number}","pulls_url":"https://api.github.com/repos/pfsense/pfsense/pulls{/number}","milestones_url":"https://api.github.com/repos/pfsense/pfsense/milestones{/number}","notifications_url":"https://api.github.com/repos/pfsense/pfsense/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pfsense/pfsense/labels{/name}","releases_url":"https://api.github.com/repos/pfsense/pfsense/releases{/id}","created_at":"2011-05-12T19:44:21Z","updated_at":"2015-09-21T09:27:02Z","pushed_at":"2015-09-21T19:10:10Z","git_url":"git://github.com/pfsense/pfsense.git","ssh_url":"git@github.com:pfsense/pfsense.git","clone_url":"https://github.com/pfsense/pfsense.git","svn_url":"https://github.com/pfsense/pfsense","homepage":"http://www.pfsense.org","size":104568,"stargazers_count":659,"watchers_count":659,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":411,"mirror_url":null,"open_issues_count":60,"forks":411,"open_issues":60,"watchers":659,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pfsense/pfsense/pulls/1787"},"html":{"href":"https://github.com/pfsense/pfsense/pull/1787"},"issue":{"href":"https://api.github.com/repos/pfsense/pfsense/issues/1787"},"comments":{"href":"https://api.github.com/repos/pfsense/pfsense/issues/1787/comments"},"review_comments":{"href":"https://api.github.com/repos/pfsense/pfsense/pulls/1787/comments"},"review_comment":{"href":"https://api.github.com/repos/pfsense/pfsense/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pfsense/pfsense/pulls/1787/commits"},"statuses":{"href":"https://api.github.com/repos/pfsense/pfsense/statuses/8141416fb2dab0349a938eeaa2563253b489dfe7"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"pfSense-git-updates","id":7121082,"avatar_url":"https://avatars.githubusercontent.com/u/7121082?v=3","gravatar_id":"","url":"https://api.github.com/users/pfSense-git-updates","html_url":"https://github.com/pfSense-git-updates","followers_url":"https://api.github.com/users/pfSense-git-updates/followers","following_url":"https://api.github.com/users/pfSense-git-updates/following{/other_user}","gists_url":"https://api.github.com/users/pfSense-git-updates/gists{/gist_id}","starred_url":"https://api.github.com/users/pfSense-git-updates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfSense-git-updates/subscriptions","organizations_url":"https://api.github.com/users/pfSense-git-updates/orgs","repos_url":"https://api.github.com/users/pfSense-git-updates/repos","events_url":"https://api.github.com/users/pfSense-git-updates/events{/privacy}","received_events_url":"https://api.github.com/users/pfSense-git-updates/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":6,"additions":11,"deletions":30,"changed_files":2}}