{"action":"closed","number":380,"pull_request":{"url":"https://api.github.com/repos/maidsafe/crust/pulls/380","id":48969896,"html_url":"https://github.com/maidsafe/crust/pull/380","diff_url":"https://github.com/maidsafe/crust/pull/380.diff","patch_url":"https://github.com/maidsafe/crust/pull/380.patch","issue_url":"https://api.github.com/repos/maidsafe/crust/issues/380","number":380,"state":"closed","locked":false,"title":"Fix file handling","user":{"login":"canndrew","id":5555066,"avatar_url":"https://avatars.githubusercontent.com/u/5555066?v=3","gravatar_id":"","url":"https://api.github.com/users/canndrew","html_url":"https://github.com/canndrew","followers_url":"https://api.github.com/users/canndrew/followers","following_url":"https://api.github.com/users/canndrew/following{/other_user}","gists_url":"https://api.github.com/users/canndrew/gists{/gist_id}","starred_url":"https://api.github.com/users/canndrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canndrew/subscriptions","organizations_url":"https://api.github.com/users/canndrew/orgs","repos_url":"https://api.github.com/users/canndrew/repos","events_url":"https://api.github.com/users/canndrew/events{/privacy}","received_events_url":"https://api.github.com/users/canndrew/received_events","type":"User","site_admin":false},"body":"This PR:\r\n* gets rid of the `abort`s in file handling code\r\n* gets rid of the meaningless `NotSet` error variant\r\n* fixes/simplifies a test\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/maidsafe/crust/380)\n<!-- Reviewable:end -->\n","created_at":"2015-10-28T06:42:41Z","updated_at":"2015-12-28T21:26:30Z","closed_at":"2015-12-28T21:26:30Z","merged_at":null,"merge_commit_sha":"85988614474666889d9dbe214ebb2b9223676a62","assignee":{"login":"vinipsmaker","id":865914,"avatar_url":"https://avatars.githubusercontent.com/u/865914?v=3","gravatar_id":"","url":"https://api.github.com/users/vinipsmaker","html_url":"https://github.com/vinipsmaker","followers_url":"https://api.github.com/users/vinipsmaker/followers","following_url":"https://api.github.com/users/vinipsmaker/following{/other_user}","gists_url":"https://api.github.com/users/vinipsmaker/gists{/gist_id}","starred_url":"https://api.github.com/users/vinipsmaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinipsmaker/subscriptions","organizations_url":"https://api.github.com/users/vinipsmaker/orgs","repos_url":"https://api.github.com/users/vinipsmaker/repos","events_url":"https://api.github.com/users/vinipsmaker/events{/privacy}","received_events_url":"https://api.github.com/users/vinipsmaker/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/maidsafe/crust/pulls/380/commits","review_comments_url":"https://api.github.com/repos/maidsafe/crust/pulls/380/comments","review_comment_url":"https://api.github.com/repos/maidsafe/crust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/maidsafe/crust/issues/380/comments","statuses_url":"https://api.github.com/repos/maidsafe/crust/statuses/d35f01b2ad154cb6ad04bd48bd3ef18cae66e52d","head":{"label":"canndrew:fix-file-handlign","ref":"fix-file-handlign","sha":"d35f01b2ad154cb6ad04bd48bd3ef18cae66e52d","user":{"login":"canndrew","id":5555066,"avatar_url":"https://avatars.githubusercontent.com/u/5555066?v=3","gravatar_id":"","url":"https://api.github.com/users/canndrew","html_url":"https://github.com/canndrew","followers_url":"https://api.github.com/users/canndrew/followers","following_url":"https://api.github.com/users/canndrew/following{/other_user}","gists_url":"https://api.github.com/users/canndrew/gists{/gist_id}","starred_url":"https://api.github.com/users/canndrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canndrew/subscriptions","organizations_url":"https://api.github.com/users/canndrew/orgs","repos_url":"https://api.github.com/users/canndrew/repos","events_url":"https://api.github.com/users/canndrew/events{/privacy}","received_events_url":"https://api.github.com/users/canndrew/received_events","type":"User","site_admin":false},"repo":{"id":43108948,"name":"crust","full_name":"canndrew/crust","owner":{"login":"canndrew","id":5555066,"avatar_url":"https://avatars.githubusercontent.com/u/5555066?v=3","gravatar_id":"","url":"https://api.github.com/users/canndrew","html_url":"https://github.com/canndrew","followers_url":"https://api.github.com/users/canndrew/followers","following_url":"https://api.github.com/users/canndrew/following{/other_user}","gists_url":"https://api.github.com/users/canndrew/gists{/gist_id}","starred_url":"https://api.github.com/users/canndrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canndrew/subscriptions","organizations_url":"https://api.github.com/users/canndrew/orgs","repos_url":"https://api.github.com/users/canndrew/repos","events_url":"https://api.github.com/users/canndrew/events{/privacy}","received_events_url":"https://api.github.com/users/canndrew/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/canndrew/crust","description":"Reliable p2p network connections in Rust with NAT traversal. One of the most needed libraries for any server-less / decentralised projects","fork":true,"url":"https://api.github.com/repos/canndrew/crust","forks_url":"https://api.github.com/repos/canndrew/crust/forks","keys_url":"https://api.github.com/repos/canndrew/crust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/canndrew/crust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/canndrew/crust/teams","hooks_url":"https://api.github.com/repos/canndrew/crust/hooks","issue_events_url":"https://api.github.com/repos/canndrew/crust/issues/events{/number}","events_url":"https://api.github.com/repos/canndrew/crust/events","assignees_url":"https://api.github.com/repos/canndrew/crust/assignees{/user}","branches_url":"https://api.github.com/repos/canndrew/crust/branches{/branch}","tags_url":"https://api.github.com/repos/canndrew/crust/tags","blobs_url":"https://api.github.com/repos/canndrew/crust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/canndrew/crust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/canndrew/crust/git/refs{/sha}","trees_url":"https://api.github.com/repos/canndrew/crust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/canndrew/crust/statuses/{sha}","languages_url":"https://api.github.com/repos/canndrew/crust/languages","stargazers_url":"https://api.github.com/repos/canndrew/crust/stargazers","contributors_url":"https://api.github.com/repos/canndrew/crust/contributors","subscribers_url":"https://api.github.com/repos/canndrew/crust/subscribers","subscription_url":"https://api.github.com/repos/canndrew/crust/subscription","commits_url":"https://api.github.com/repos/canndrew/crust/commits{/sha}","git_commits_url":"https://api.github.com/repos/canndrew/crust/git/commits{/sha}","comments_url":"https://api.github.com/repos/canndrew/crust/comments{/number}","issue_comment_url":"https://api.github.com/repos/canndrew/crust/issues/comments{/number}","contents_url":"https://api.github.com/repos/canndrew/crust/contents/{+path}","compare_url":"https://api.github.com/repos/canndrew/crust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/canndrew/crust/merges","archive_url":"https://api.github.com/repos/canndrew/crust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/canndrew/crust/downloads","issues_url":"https://api.github.com/repos/canndrew/crust/issues{/number}","pulls_url":"https://api.github.com/repos/canndrew/crust/pulls{/number}","milestones_url":"https://api.github.com/repos/canndrew/crust/milestones{/number}","notifications_url":"https://api.github.com/repos/canndrew/crust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/canndrew/crust/labels{/name}","releases_url":"https://api.github.com/repos/canndrew/crust/releases{/id}","created_at":"2015-09-25T04:04:21Z","updated_at":"2015-09-25T04:04:25Z","pushed_at":"2015-12-23T03:32:14Z","git_url":"git://github.com/canndrew/crust.git","ssh_url":"git@github.com:canndrew/crust.git","clone_url":"https://github.com/canndrew/crust.git","svn_url":"https://github.com/canndrew/crust","homepage":null,"size":21806,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"maidsafe:master","ref":"master","sha":"6e5a38b232fcb560d11968b6fa6f94e2799c0565","user":{"login":"maidsafe","id":536423,"avatar_url":"https://avatars.githubusercontent.com/u/536423?v=3","gravatar_id":"","url":"https://api.github.com/users/maidsafe","html_url":"https://github.com/maidsafe","followers_url":"https://api.github.com/users/maidsafe/followers","following_url":"https://api.github.com/users/maidsafe/following{/other_user}","gists_url":"https://api.github.com/users/maidsafe/gists{/gist_id}","starred_url":"https://api.github.com/users/maidsafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maidsafe/subscriptions","organizations_url":"https://api.github.com/users/maidsafe/orgs","repos_url":"https://api.github.com/users/maidsafe/repos","events_url":"https://api.github.com/users/maidsafe/events{/privacy}","received_events_url":"https://api.github.com/users/maidsafe/received_events","type":"Organization","site_admin":false},"repo":{"id":33324427,"name":"crust","full_name":"maidsafe/crust","owner":{"login":"maidsafe","id":536423,"avatar_url":"https://avatars.githubusercontent.com/u/536423?v=3","gravatar_id":"","url":"https://api.github.com/users/maidsafe","html_url":"https://github.com/maidsafe","followers_url":"https://api.github.com/users/maidsafe/followers","following_url":"https://api.github.com/users/maidsafe/following{/other_user}","gists_url":"https://api.github.com/users/maidsafe/gists{/gist_id}","starred_url":"https://api.github.com/users/maidsafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maidsafe/subscriptions","organizations_url":"https://api.github.com/users/maidsafe/orgs","repos_url":"https://api.github.com/users/maidsafe/repos","events_url":"https://api.github.com/users/maidsafe/events{/privacy}","received_events_url":"https://api.github.com/users/maidsafe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/maidsafe/crust","description":"Reliable p2p network connections in Rust with NAT traversal. One of the most needed libraries for any server-less / decentralised projects","fork":false,"url":"https://api.github.com/repos/maidsafe/crust","forks_url":"https://api.github.com/repos/maidsafe/crust/forks","keys_url":"https://api.github.com/repos/maidsafe/crust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maidsafe/crust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maidsafe/crust/teams","hooks_url":"https://api.github.com/repos/maidsafe/crust/hooks","issue_events_url":"https://api.github.com/repos/maidsafe/crust/issues/events{/number}","events_url":"https://api.github.com/repos/maidsafe/crust/events","assignees_url":"https://api.github.com/repos/maidsafe/crust/assignees{/user}","branches_url":"https://api.github.com/repos/maidsafe/crust/branches{/branch}","tags_url":"https://api.github.com/repos/maidsafe/crust/tags","blobs_url":"https://api.github.com/repos/maidsafe/crust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maidsafe/crust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maidsafe/crust/git/refs{/sha}","trees_url":"https://api.github.com/repos/maidsafe/crust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maidsafe/crust/statuses/{sha}","languages_url":"https://api.github.com/repos/maidsafe/crust/languages","stargazers_url":"https://api.github.com/repos/maidsafe/crust/stargazers","contributors_url":"https://api.github.com/repos/maidsafe/crust/contributors","subscribers_url":"https://api.github.com/repos/maidsafe/crust/subscribers","subscription_url":"https://api.github.com/repos/maidsafe/crust/subscription","commits_url":"https://api.github.com/repos/maidsafe/crust/commits{/sha}","git_commits_url":"https://api.github.com/repos/maidsafe/crust/git/commits{/sha}","comments_url":"https://api.github.com/repos/maidsafe/crust/comments{/number}","issue_comment_url":"https://api.github.com/repos/maidsafe/crust/issues/comments{/number}","contents_url":"https://api.github.com/repos/maidsafe/crust/contents/{+path}","compare_url":"https://api.github.com/repos/maidsafe/crust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maidsafe/crust/merges","archive_url":"https://api.github.com/repos/maidsafe/crust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maidsafe/crust/downloads","issues_url":"https://api.github.com/repos/maidsafe/crust/issues{/number}","pulls_url":"https://api.github.com/repos/maidsafe/crust/pulls{/number}","milestones_url":"https://api.github.com/repos/maidsafe/crust/milestones{/number}","notifications_url":"https://api.github.com/repos/maidsafe/crust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maidsafe/crust/labels{/name}","releases_url":"https://api.github.com/repos/maidsafe/crust/releases{/id}","created_at":"2015-04-02T18:16:59Z","updated_at":"2015-12-25T12:44:37Z","pushed_at":"2015-12-28T20:40:23Z","git_url":"git://github.com/maidsafe/crust.git","ssh_url":"git@github.com:maidsafe/crust.git","clone_url":"https://github.com/maidsafe/crust.git","svn_url":"https://github.com/maidsafe/crust","homepage":null,"size":37367,"stargazers_count":234,"watchers_count":234,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":45,"mirror_url":null,"open_issues_count":26,"forks":45,"open_issues":26,"watchers":234,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/maidsafe/crust/pulls/380"},"html":{"href":"https://github.com/maidsafe/crust/pull/380"},"issue":{"href":"https://api.github.com/repos/maidsafe/crust/issues/380"},"comments":{"href":"https://api.github.com/repos/maidsafe/crust/issues/380/comments"},"review_comments":{"href":"https://api.github.com/repos/maidsafe/crust/pulls/380/comments"},"review_comment":{"href":"https://api.github.com/repos/maidsafe/crust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/maidsafe/crust/pulls/380/commits"},"statuses":{"href":"https://api.github.com/repos/maidsafe/crust/statuses/d35f01b2ad154cb6ad04bd48bd3ef18cae66e52d"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":7,"review_comments":0,"commits":3,"additions":107,"deletions":102,"changed_files":2}}