{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/logstash/pulls/comments/32635534","id":32635534,"diff_hunk":"@@ -0,0 +1,50 @@\n+module LogStash::Util::JavaVersion\n+  # Print a warning if we're on a bad version of java\n+  def self.warn_on_bad_java_version\n+    if self.bad_java_version?(self.version)\n+      STDERR.puts(\"!!! Please upgrade your java version, the current version '#{self.version}' may cause problems. We recommend a minimum version of 1.7.0_51\")\n+    end\n+  end\n+\n+  # Check to see if this is a recommended java version, print a warning to stdout if this is a bad version\n+  # Returns the current java version\n+  def self.version\n+    return nil if RUBY_ENGINE != \"jruby\"","path":"lib/logstash/util/java_version.rb","position":12,"original_position":12,"commit_id":"c2acf660caa751b7cc7e43c8c3dc4b687254ca8c","original_commit_id":"c2acf660caa751b7cc7e43c8c3dc4b687254ca8c","user":{"login":"andrewvc","id":131427,"avatar_url":"https://avatars.githubusercontent.com/u/131427?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"body":"ah, nice.","created_at":"2015-06-17T14:58:04Z","updated_at":"2015-06-17T14:58:04Z","html_url":"https://github.com/elastic/logstash/pull/3452#discussion_r32635534","pull_request_url":"https://api.github.com/repos/elastic/logstash/pulls/3452","_links":{"self":{"href":"https://api.github.com/repos/elastic/logstash/pulls/comments/32635534"},"html":{"href":"https://github.com/elastic/logstash/pull/3452#discussion_r32635534"},"pull_request":{"href":"https://api.github.com/repos/elastic/logstash/pulls/3452"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/logstash/pulls/3452","id":37848546,"html_url":"https://github.com/elastic/logstash/pull/3452","diff_url":"https://github.com/elastic/logstash/pull/3452.diff","patch_url":"https://github.com/elastic/logstash/pull/3452.patch","issue_url":"https://api.github.com/repos/elastic/logstash/issues/3452","number":3452,"state":"open","locked":false,"title":"Warn on java version","user":{"login":"andrewvc","id":131427,"avatar_url":"https://avatars.githubusercontent.com/u/131427?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"body":"Fixes #2547 . @jordansissel is STDERR.puts the best place to put this? I wasn't sure if we should force a message like this to stdout, or if it should use regular logging mechanisms. Sometimes regular logging is ignored by users. ","created_at":"2015-06-16T22:25:11Z","updated_at":"2015-06-17T14:58:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a238b07d76c232a46653762c89ad8999b3fbfc9b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/elastic/logstash/pulls/3452/commits","review_comments_url":"https://api.github.com/repos/elastic/logstash/pulls/3452/comments","review_comment_url":"https://api.github.com/repos/elastic/logstash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/logstash/issues/3452/comments","statuses_url":"https://api.github.com/repos/elastic/logstash/statuses/c2acf660caa751b7cc7e43c8c3dc4b687254ca8c","head":{"label":"andrewvc:warn-on-java-version","ref":"warn-on-java-version","sha":"c2acf660caa751b7cc7e43c8c3dc4b687254ca8c","user":{"login":"andrewvc","id":131427,"avatar_url":"https://avatars.githubusercontent.com/u/131427?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"repo":{"id":37559198,"name":"logstash","full_name":"andrewvc/logstash","owner":{"login":"andrewvc","id":131427,"avatar_url":"https://avatars.githubusercontent.com/u/131427?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewvc/logstash","description":"logstash - transport and process your logs, events, or other data","fork":true,"url":"https://api.github.com/repos/andrewvc/logstash","forks_url":"https://api.github.com/repos/andrewvc/logstash/forks","keys_url":"https://api.github.com/repos/andrewvc/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewvc/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewvc/logstash/teams","hooks_url":"https://api.github.com/repos/andrewvc/logstash/hooks","issue_events_url":"https://api.github.com/repos/andrewvc/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/andrewvc/logstash/events","assignees_url":"https://api.github.com/repos/andrewvc/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/andrewvc/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/andrewvc/logstash/tags","blobs_url":"https://api.github.com/repos/andrewvc/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewvc/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewvc/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewvc/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewvc/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewvc/logstash/languages","stargazers_url":"https://api.github.com/repos/andrewvc/logstash/stargazers","contributors_url":"https://api.github.com/repos/andrewvc/logstash/contributors","subscribers_url":"https://api.github.com/repos/andrewvc/logstash/subscribers","subscription_url":"https://api.github.com/repos/andrewvc/logstash/subscription","commits_url":"https://api.github.com/repos/andrewvc/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewvc/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewvc/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewvc/logstash/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewvc/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/andrewvc/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewvc/logstash/merges","archive_url":"https://api.github.com/repos/andrewvc/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewvc/logstash/downloads","issues_url":"https://api.github.com/repos/andrewvc/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/andrewvc/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewvc/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewvc/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewvc/logstash/labels{/name}","releases_url":"https://api.github.com/repos/andrewvc/logstash/releases{/id}","created_at":"2015-06-16T22:23:09Z","updated_at":"2015-06-16T22:23:11Z","pushed_at":"2015-06-17T14:55:29Z","git_url":"git://github.com/andrewvc/logstash.git","ssh_url":"git@github.com:andrewvc/logstash.git","clone_url":"https://github.com/andrewvc/logstash.git","svn_url":"https://github.com/andrewvc/logstash","homepage":"https://www.elastic.co/products/logstash","size":91430,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"4677f0a54b38054e876170f6d8ad6835830fce7f","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":1090311,"name":"logstash","full_name":"elastic/logstash","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/logstash","description":"logstash - transport and process your logs, events, or other data","fork":false,"url":"https://api.github.com/repos/elastic/logstash","forks_url":"https://api.github.com/repos/elastic/logstash/forks","keys_url":"https://api.github.com/repos/elastic/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/logstash/teams","hooks_url":"https://api.github.com/repos/elastic/logstash/hooks","issue_events_url":"https://api.github.com/repos/elastic/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/logstash/events","assignees_url":"https://api.github.com/repos/elastic/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/logstash/tags","blobs_url":"https://api.github.com/repos/elastic/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/logstash/languages","stargazers_url":"https://api.github.com/repos/elastic/logstash/stargazers","contributors_url":"https://api.github.com/repos/elastic/logstash/contributors","subscribers_url":"https://api.github.com/repos/elastic/logstash/subscribers","subscription_url":"https://api.github.com/repos/elastic/logstash/subscription","commits_url":"https://api.github.com/repos/elastic/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/logstash/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/logstash/merges","archive_url":"https://api.github.com/repos/elastic/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/logstash/downloads","issues_url":"https://api.github.com/repos/elastic/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/logstash/labels{/name}","releases_url":"https://api.github.com/repos/elastic/logstash/releases{/id}","created_at":"2010-11-18T01:31:50Z","updated_at":"2015-06-17T10:24:10Z","pushed_at":"2015-06-17T14:55:30Z","git_url":"git://github.com/elastic/logstash.git","ssh_url":"git@github.com:elastic/logstash.git","clone_url":"https://github.com/elastic/logstash.git","svn_url":"https://github.com/elastic/logstash","homepage":"https://www.elastic.co/products/logstash","size":91430,"stargazers_count":4356,"watchers_count":4356,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1467,"mirror_url":null,"open_issues_count":483,"forks":1467,"open_issues":483,"watchers":4356,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/logstash/pulls/3452"},"html":{"href":"https://github.com/elastic/logstash/pull/3452"},"issue":{"href":"https://api.github.com/repos/elastic/logstash/issues/3452"},"comments":{"href":"https://api.github.com/repos/elastic/logstash/issues/3452/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/logstash/pulls/3452/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/logstash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/logstash/pulls/3452/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/logstash/statuses/c2acf660caa751b7cc7e43c8c3dc4b687254ca8c"}}}}