{"action":"created","issue":{"url":"https://api.github.com/repos/osuosl/timesync-node/issues/165","labels_url":"https://api.github.com/repos/osuosl/timesync-node/issues/165/labels{/name}","comments_url":"https://api.github.com/repos/osuosl/timesync-node/issues/165/comments","events_url":"https://api.github.com/repos/osuosl/timesync-node/issues/165/events","html_url":"https://github.com/osuosl/timesync-node/pull/165","id":105922097,"number":165,"title":"add ldap support","user":{"login":"tschuy","id":6532435,"avatar_url":"https://avatars.githubusercontent.com/u/6532435?v=3","gravatar_id":"","url":"https://api.github.com/users/tschuy","html_url":"https://github.com/tschuy","followers_url":"https://api.github.com/users/tschuy/followers","following_url":"https://api.github.com/users/tschuy/following{/other_user}","gists_url":"https://api.github.com/users/tschuy/gists{/gist_id}","starred_url":"https://api.github.com/users/tschuy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschuy/subscriptions","organizations_url":"https://api.github.com/users/tschuy/orgs","repos_url":"https://api.github.com/users/tschuy/repos","events_url":"https://api.github.com/users/tschuy/events{/privacy}","received_events_url":"https://api.github.com/users/tschuy/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/osuosl/timesync-node/labels/Ready%20for%20Review","name":"Ready for Review","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-09-11T00:07:47Z","updated_at":"2015-09-14T21:46:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/osuosl/timesync-node/pulls/165","html_url":"https://github.com/osuosl/timesync-node/pull/165","diff_url":"https://github.com/osuosl/timesync-node/pull/165.diff","patch_url":"https://github.com/osuosl/timesync-node/pull/165.patch"},"body":"This PR is for discussion of LDAP login and its implementation. Currently, there are a few critical things:\r\n\r\n~~1. We have no way to automatically test this. I'm not putting my ldap password in the tests and neither should you!~~\r\n3. It increases setup complexity about 10x over by introducing four new env variables, at least one of which MUST be set. \r\n\r\nShould we change ``TIMESYNC_LOCAL`` to something more like ``TIMESYNC_DISABLE_LOCAL``, and make password auth default?\r\n\r\n~~I'd also like to refactor my use of passport into something like ``app.authenticatedPost(`` that handles all of the authentication nonsense itself.~~"},"comment":{"url":"https://api.github.com/repos/osuosl/timesync-node/issues/comments/140214511","html_url":"https://github.com/osuosl/timesync-node/pull/165#issuecomment-140214511","issue_url":"https://api.github.com/repos/osuosl/timesync-node/issues/165","id":140214511,"user":{"login":"tschuy","id":6532435,"avatar_url":"https://avatars.githubusercontent.com/u/6532435?v=3","gravatar_id":"","url":"https://api.github.com/users/tschuy","html_url":"https://github.com/tschuy","followers_url":"https://api.github.com/users/tschuy/followers","following_url":"https://api.github.com/users/tschuy/following{/other_user}","gists_url":"https://api.github.com/users/tschuy/gists{/gist_id}","starred_url":"https://api.github.com/users/tschuy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschuy/subscriptions","organizations_url":"https://api.github.com/users/tschuy/orgs","repos_url":"https://api.github.com/users/tschuy/repos","events_url":"https://api.github.com/users/tschuy/events{/privacy}","received_events_url":"https://api.github.com/users/tschuy/received_events","type":"User","site_admin":false},"created_at":"2015-09-14T21:46:03Z","updated_at":"2015-09-14T21:46:03Z","body":"Crazy awful idea: we could do file permissions do -- ``local == 1``, ``ldap == 2``, ``google == 4``, etc. Then we can set ``TIMESYNC_AUTH_MODULES`` to ``1``, ``3``, ``4``, ``7``, etc along with their relevant other vars!"}}