{"action":"created","issue":{"url":"https://api.github.com/repos/xunit/xunit/issues/616","labels_url":"https://api.github.com/repos/xunit/xunit/issues/616/labels{/name}","comments_url":"https://api.github.com/repos/xunit/xunit/issues/616/comments","events_url":"https://api.github.com/repos/xunit/xunit/issues/616/events","html_url":"https://github.com/xunit/xunit/issues/616","id":110312629,"number":616,"title":"tests failing when comparing exception messages in non-EN-environments","user":{"login":"jongleur1983","id":2063360,"avatar_url":"https://avatars.githubusercontent.com/u/2063360?v=3","gravatar_id":"","url":"https://api.github.com/users/jongleur1983","html_url":"https://github.com/jongleur1983","followers_url":"https://api.github.com/users/jongleur1983/followers","following_url":"https://api.github.com/users/jongleur1983/following{/other_user}","gists_url":"https://api.github.com/users/jongleur1983/gists{/gist_id}","starred_url":"https://api.github.com/users/jongleur1983/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jongleur1983/subscriptions","organizations_url":"https://api.github.com/users/jongleur1983/orgs","repos_url":"https://api.github.com/users/jongleur1983/repos","events_url":"https://api.github.com/users/jongleur1983/events{/privacy}","received_events_url":"https://api.github.com/users/jongleur1983/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-10-07T20:46:04Z","updated_at":"2015-10-19T19:10:21Z","closed_at":null,"body":"to be precise I refer to the tests testing xunit itself, not to the way xunit works.\r\n\r\n30 of those fail for me as they assert to have the \"correct\" exception message.\r\nThe comparison performed here makes the assumption that any exception message is thrown in English, while in some (e.g. my) setup .NET obviously throws localized exception messages instead \r\n\r\nAn example from test.core.test.xunit.execution.TestCollectionOrderer.TestCaseOrdererWhichThrowsLogsMessageAndDoesNotReorderTests:\r\n\r\n    Xunit.Sdk.StartsWithExceptionAssert.StartsWith() Failure:\r\n    Expected: Test collection orderer 'TestAssemblyRunnerTests+TestCollectionOrderer+ThrowingOrderer' threw 'System.DivideByZeroException' during ordering: Attempted to divide by zero.\r\n    Actual:   Test collection orderer 'TestAssemblyRunnerTests+TestCollectionOrderer+ThrowingOrderer' threw 'System.DivideByZeroException' during ordering: Es wurde versucht, durch 0 zu teilen."},"comment":{"url":"https://api.github.com/repos/xunit/xunit/issues/comments/149315943","html_url":"https://github.com/xunit/xunit/issues/616#issuecomment-149315943","issue_url":"https://api.github.com/repos/xunit/xunit/issues/616","id":149315943,"user":{"login":"jongleur1983","id":2063360,"avatar_url":"https://avatars.githubusercontent.com/u/2063360?v=3","gravatar_id":"","url":"https://api.github.com/users/jongleur1983","html_url":"https://github.com/jongleur1983","followers_url":"https://api.github.com/users/jongleur1983/followers","following_url":"https://api.github.com/users/jongleur1983/following{/other_user}","gists_url":"https://api.github.com/users/jongleur1983/gists{/gist_id}","starred_url":"https://api.github.com/users/jongleur1983/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jongleur1983/subscriptions","organizations_url":"https://api.github.com/users/jongleur1983/orgs","repos_url":"https://api.github.com/users/jongleur1983/repos","events_url":"https://api.github.com/users/jongleur1983/events{/privacy}","received_events_url":"https://api.github.com/users/jongleur1983/received_events","type":"User","site_admin":false},"created_at":"2015-10-19T19:10:21Z","updated_at":"2015-10-19T19:10:21Z","body":"for the remaining tests the case is slightly more complicated.\r\nThe exception message depends on the UICulture of the thread throwing it.\r\nAll tests still failing in non-en(-us?) environments throw the (expected) exceptions in some other thread than the one of the test method itself.\r\n\r\nTo fix that it would be necessary to enforce the culture in these threads as far as I know yet."}}