{"action":"created","comment":{"url":"https://api.github.com/repos/broadinstitute/vault-api/pulls/comments/30360485","id":30360485,"diff_hunk":"@@ -1,34 +1,16 @@\n package org.broadinstitute.dsde.vault\n \n import akka.actor.{ActorSystem, Props}\n-import akka.io.IO\n-import akka.pattern.ask\n-import akka.util.Timeout\n+import org.broadinstitute.dsde.vault.common.util.ServerInitializer\n import org.slf4j.LoggerFactory\n-import spray.can.Http\n-\n-import scala.concurrent.duration._\n \n object VaultApp {\n \n   // we need an ActorSystem to host our application in\n   implicit val system = ActorSystem(\"vault-api\")\n-\n-  // create and start our service actor\n-  val service = system.actorOf(Props[VaultServiceActor], \"vault-api-service\")\n-\n-  implicit val timeout = Timeout(5.seconds)\n-\n   lazy val log = LoggerFactory.getLogger(getClass)\n-\n   def main(args: Array[String]) {\n     log.info(\"Vault instance starting.\")\n-    start()\n-  }\n-\n-  def start(): Unit = {\n-    // start a new HTTP server on configuration port with our service actor as the handler\n-    IO(Http) ? Http.Bind(service, VaultConfig.HttpConfig.interface, VaultConfig.HttpConfig.port)\n+    ServerInitializer.startWebServiceActors(Props[VaultServiceActor],VaultConfig.HttpConfig.interface,VaultConfig.HttpConfig.port,VaultConfig.HttpConfig.timeout,system)","path":"src/main/scala/org/broadinstitute/dsde/vault/VaultApp.scala","position":33,"original_position":33,"commit_id":"8e37ed31131b035a13e88e7e2891eff31f524cf6","original_commit_id":"8e37ed31131b035a13e88e7e2891eff31f524cf6","user":{"login":"kshakir","id":791985,"avatar_url":"https://avatars.githubusercontent.com/u/791985?v=3","gravatar_id":"","url":"https://api.github.com/users/kshakir","html_url":"https://github.com/kshakir","followers_url":"https://api.github.com/users/kshakir/followers","following_url":"https://api.github.com/users/kshakir/following{/other_user}","gists_url":"https://api.github.com/users/kshakir/gists{/gist_id}","starred_url":"https://api.github.com/users/kshakir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kshakir/subscriptions","organizations_url":"https://api.github.com/users/kshakir/orgs","repos_url":"https://api.github.com/users/kshakir/repos","events_url":"https://api.github.com/users/kshakir/events{/privacy}","received_events_url":"https://api.github.com/users/kshakir/received_events","type":"User","site_admin":false},"body":"Pleaseaddspacestothisline. :trollface: \r\n\r\n`⌥⌘L` in IntelilJ should do it in one keystroke.","created_at":"2015-05-14T20:42:30Z","updated_at":"2015-05-14T20:42:30Z","html_url":"https://github.com/broadinstitute/vault-api/pull/56#discussion_r30360485","pull_request_url":"https://api.github.com/repos/broadinstitute/vault-api/pulls/56","_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/vault-api/pulls/comments/30360485"},"html":{"href":"https://github.com/broadinstitute/vault-api/pull/56#discussion_r30360485"},"pull_request":{"href":"https://api.github.com/repos/broadinstitute/vault-api/pulls/56"}}},"pull_request":{"url":"https://api.github.com/repos/broadinstitute/vault-api/pulls/56","id":35451291,"html_url":"https://github.com/broadinstitute/vault-api/pull/56","diff_url":"https://github.com/broadinstitute/vault-api/pull/56.diff","patch_url":"https://github.com/broadinstitute/vault-api/pull/56.patch","issue_url":"https://api.github.com/repos/broadinstitute/vault-api/issues/56","number":56,"state":"open","locked":false,"title":"Feature/dsdev 1909 binding failures","user":{"login":"ssaucedo","id":11859587,"avatar_url":"https://avatars.githubusercontent.com/u/11859587?v=3","gravatar_id":"","url":"https://api.github.com/users/ssaucedo","html_url":"https://github.com/ssaucedo","followers_url":"https://api.github.com/users/ssaucedo/followers","following_url":"https://api.github.com/users/ssaucedo/following{/other_user}","gists_url":"https://api.github.com/users/ssaucedo/gists{/gist_id}","starred_url":"https://api.github.com/users/ssaucedo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssaucedo/subscriptions","organizations_url":"https://api.github.com/users/ssaucedo/orgs","repos_url":"https://api.github.com/users/ssaucedo/repos","events_url":"https://api.github.com/users/ssaucedo/events{/privacy}","received_events_url":"https://api.github.com/users/ssaucedo/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-05-14T19:05:06Z","updated_at":"2015-05-14T20:42:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c479d7989259dae5346abbcf87ef1bff562479ed","assignee":{"login":"kshakir","id":791985,"avatar_url":"https://avatars.githubusercontent.com/u/791985?v=3","gravatar_id":"","url":"https://api.github.com/users/kshakir","html_url":"https://github.com/kshakir","followers_url":"https://api.github.com/users/kshakir/followers","following_url":"https://api.github.com/users/kshakir/following{/other_user}","gists_url":"https://api.github.com/users/kshakir/gists{/gist_id}","starred_url":"https://api.github.com/users/kshakir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kshakir/subscriptions","organizations_url":"https://api.github.com/users/kshakir/orgs","repos_url":"https://api.github.com/users/kshakir/repos","events_url":"https://api.github.com/users/kshakir/events{/privacy}","received_events_url":"https://api.github.com/users/kshakir/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/broadinstitute/vault-api/pulls/56/commits","review_comments_url":"https://api.github.com/repos/broadinstitute/vault-api/pulls/56/comments","review_comment_url":"https://api.github.com/repos/broadinstitute/vault-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/broadinstitute/vault-api/issues/56/comments","statuses_url":"https://api.github.com/repos/broadinstitute/vault-api/statuses/8e37ed31131b035a13e88e7e2891eff31f524cf6","head":{"label":"broadinstitute:feature/DSDEV-1909BindingFailures","ref":"feature/DSDEV-1909BindingFailures","sha":"8e37ed31131b035a13e88e7e2891eff31f524cf6","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":30926361,"name":"vault-api","full_name":"broadinstitute/vault-api","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/vault-api","description":"Vault Orchestration Service","fork":false,"url":"https://api.github.com/repos/broadinstitute/vault-api","forks_url":"https://api.github.com/repos/broadinstitute/vault-api/forks","keys_url":"https://api.github.com/repos/broadinstitute/vault-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/vault-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/vault-api/teams","hooks_url":"https://api.github.com/repos/broadinstitute/vault-api/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/vault-api/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/vault-api/events","assignees_url":"https://api.github.com/repos/broadinstitute/vault-api/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/vault-api/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/vault-api/tags","blobs_url":"https://api.github.com/repos/broadinstitute/vault-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/vault-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/vault-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/vault-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/vault-api/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/vault-api/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/vault-api/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/vault-api/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/vault-api/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/vault-api/subscription","commits_url":"https://api.github.com/repos/broadinstitute/vault-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/vault-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/vault-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/vault-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/vault-api/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/vault-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/vault-api/merges","archive_url":"https://api.github.com/repos/broadinstitute/vault-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/vault-api/downloads","issues_url":"https://api.github.com/repos/broadinstitute/vault-api/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/vault-api/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/vault-api/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/vault-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/vault-api/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/vault-api/releases{/id}","created_at":"2015-02-17T16:41:31Z","updated_at":"2015-05-08T18:30:44Z","pushed_at":"2015-05-14T20:34:19Z","git_url":"git://github.com/broadinstitute/vault-api.git","ssh_url":"git@github.com:broadinstitute/vault-api.git","clone_url":"https://github.com/broadinstitute/vault-api.git","svn_url":"https://github.com/broadinstitute/vault-api","homepage":null,"size":2165,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"develop"}},"base":{"label":"broadinstitute:develop","ref":"develop","sha":"2132d0ed855e3e12a6b5562bb7b8b0338412154f","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":30926361,"name":"vault-api","full_name":"broadinstitute/vault-api","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/vault-api","description":"Vault Orchestration Service","fork":false,"url":"https://api.github.com/repos/broadinstitute/vault-api","forks_url":"https://api.github.com/repos/broadinstitute/vault-api/forks","keys_url":"https://api.github.com/repos/broadinstitute/vault-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/vault-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/vault-api/teams","hooks_url":"https://api.github.com/repos/broadinstitute/vault-api/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/vault-api/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/vault-api/events","assignees_url":"https://api.github.com/repos/broadinstitute/vault-api/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/vault-api/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/vault-api/tags","blobs_url":"https://api.github.com/repos/broadinstitute/vault-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/vault-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/vault-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/vault-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/vault-api/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/vault-api/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/vault-api/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/vault-api/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/vault-api/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/vault-api/subscription","commits_url":"https://api.github.com/repos/broadinstitute/vault-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/vault-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/vault-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/vault-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/vault-api/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/vault-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/vault-api/merges","archive_url":"https://api.github.com/repos/broadinstitute/vault-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/vault-api/downloads","issues_url":"https://api.github.com/repos/broadinstitute/vault-api/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/vault-api/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/vault-api/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/vault-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/vault-api/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/vault-api/releases{/id}","created_at":"2015-02-17T16:41:31Z","updated_at":"2015-05-08T18:30:44Z","pushed_at":"2015-05-14T20:34:19Z","git_url":"git://github.com/broadinstitute/vault-api.git","ssh_url":"git@github.com:broadinstitute/vault-api.git","clone_url":"https://github.com/broadinstitute/vault-api.git","svn_url":"https://github.com/broadinstitute/vault-api","homepage":null,"size":2165,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/vault-api/pulls/56"},"html":{"href":"https://github.com/broadinstitute/vault-api/pull/56"},"issue":{"href":"https://api.github.com/repos/broadinstitute/vault-api/issues/56"},"comments":{"href":"https://api.github.com/repos/broadinstitute/vault-api/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/broadinstitute/vault-api/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/broadinstitute/vault-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/broadinstitute/vault-api/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/broadinstitute/vault-api/statuses/8e37ed31131b035a13e88e7e2891eff31f524cf6"}}}}