{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/fireplace/pulls/comments/27250574","id":27250574,"diff_hunk":"@@ -0,0 +1,26 @@\n+/*\n+    Error codes and their associated messages.\n+*/\n+define('error_messages', ['core/l10n'], function(l10n) {\n+    'use strict';\n+    var gettext = l10n.gettext;\n+\n+    return {","path":"src/media/js/error_messages.js","position":8,"original_position":8,"commit_id":"00333932fe4ff7aa2cf24982df0d823316a94063","original_commit_id":"00333932fe4ff7aa2cf24982df0d823316a94063","user":{"login":"spasovski","id":391260,"avatar_url":"https://avatars.githubusercontent.com/u/391260?v=3","gravatar_id":"","url":"https://api.github.com/users/spasovski","html_url":"https://github.com/spasovski","followers_url":"https://api.github.com/users/spasovski/followers","following_url":"https://api.github.com/users/spasovski/following{/other_user}","gists_url":"https://api.github.com/users/spasovski/gists{/gist_id}","starred_url":"https://api.github.com/users/spasovski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spasovski/subscriptions","organizations_url":"https://api.github.com/users/spasovski/orgs","repos_url":"https://api.github.com/users/spasovski/repos","events_url":"https://api.github.com/users/spasovski/events{/privacy}","received_events_url":"https://api.github.com/users/spasovski/received_events","type":"User","site_admin":false},"body":"I like the personal touch of specific error messages but would be also OK with 'item_missing': 'We had trouble loading the details of this item...'","created_at":"2015-03-26T20:06:13Z","updated_at":"2015-03-26T20:06:13Z","html_url":"https://github.com/mozilla/fireplace/pull/1065#discussion_r27250574","pull_request_url":"https://api.github.com/repos/mozilla/fireplace/pulls/1065","_links":{"self":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/comments/27250574"},"html":{"href":"https://github.com/mozilla/fireplace/pull/1065#discussion_r27250574"},"pull_request":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/1065"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/fireplace/pulls/1065","id":30776706,"html_url":"https://github.com/mozilla/fireplace/pull/1065","diff_url":"https://github.com/mozilla/fireplace/pull/1065.diff","patch_url":"https://github.com/mozilla/fireplace/pull/1065.patch","issue_url":"https://api.github.com/repos/mozilla/fireplace/issues/1065","number":1065,"state":"open","locked":false,"title":"error page layout fixups","user":{"login":"spasovski","id":391260,"avatar_url":"https://avatars.githubusercontent.com/u/391260?v=3","gravatar_id":"","url":"https://api.github.com/users/spasovski","html_url":"https://github.com/spasovski","followers_url":"https://api.github.com/users/spasovski/followers","following_url":"https://api.github.com/users/spasovski/following{/other_user}","gists_url":"https://api.github.com/users/spasovski/gists{/gist_id}","starred_url":"https://api.github.com/users/spasovski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spasovski/subscriptions","organizations_url":"https://api.github.com/users/spasovski/orgs","repos_url":"https://api.github.com/users/spasovski/repos","events_url":"https://api.github.com/users/spasovski/events{/privacy}","received_events_url":"https://api.github.com/users/spasovski/received_events","type":"User","site_admin":false},"body":"I couldn't find any issues with this locally but the `#page` min-height obviously affects every page so we should be watchful. This is based on a vidyo chat I had with Phil where we wanted desktop pages to have a certain minimum height when little to no content was available.\r\n\r\nsample before:\r\n\r\n![](http://i.imgur.com/mkGCTon.png)\r\n\r\nsample after:\r\n\r\n![](http://i.imgur.com/FEF3mBw.png)\r\n","created_at":"2015-03-09T16:33:20Z","updated_at":"2015-03-26T20:06:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5672fa4a5a7334ff4dc41385b59f50170e4a5940","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/fireplace/pulls/1065/commits","review_comments_url":"https://api.github.com/repos/mozilla/fireplace/pulls/1065/comments","review_comment_url":"https://api.github.com/repos/mozilla/fireplace/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/fireplace/issues/1065/comments","statuses_url":"https://api.github.com/repos/mozilla/fireplace/statuses/00333932fe4ff7aa2cf24982df0d823316a94063","head":{"label":"spasovski:spaceconcept","ref":"spaceconcept","sha":"00333932fe4ff7aa2cf24982df0d823316a94063","user":{"login":"spasovski","id":391260,"avatar_url":"https://avatars.githubusercontent.com/u/391260?v=3","gravatar_id":"","url":"https://api.github.com/users/spasovski","html_url":"https://github.com/spasovski","followers_url":"https://api.github.com/users/spasovski/followers","following_url":"https://api.github.com/users/spasovski/following{/other_user}","gists_url":"https://api.github.com/users/spasovski/gists{/gist_id}","starred_url":"https://api.github.com/users/spasovski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spasovski/subscriptions","organizations_url":"https://api.github.com/users/spasovski/orgs","repos_url":"https://api.github.com/users/spasovski/repos","events_url":"https://api.github.com/users/spasovski/events{/privacy}","received_events_url":"https://api.github.com/users/spasovski/received_events","type":"User","site_admin":false},"repo":{"id":8148475,"name":"fireplace","full_name":"spasovski/fireplace","owner":{"login":"spasovski","id":391260,"avatar_url":"https://avatars.githubusercontent.com/u/391260?v=3","gravatar_id":"","url":"https://api.github.com/users/spasovski","html_url":"https://github.com/spasovski","followers_url":"https://api.github.com/users/spasovski/followers","following_url":"https://api.github.com/users/spasovski/following{/other_user}","gists_url":"https://api.github.com/users/spasovski/gists{/gist_id}","starred_url":"https://api.github.com/users/spasovski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spasovski/subscriptions","organizations_url":"https://api.github.com/users/spasovski/orgs","repos_url":"https://api.github.com/users/spasovski/repos","events_url":"https://api.github.com/users/spasovski/events{/privacy}","received_events_url":"https://api.github.com/users/spasovski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spasovski/fireplace","description":"A clandestine operation to make @krupa happy","fork":true,"url":"https://api.github.com/repos/spasovski/fireplace","forks_url":"https://api.github.com/repos/spasovski/fireplace/forks","keys_url":"https://api.github.com/repos/spasovski/fireplace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spasovski/fireplace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spasovski/fireplace/teams","hooks_url":"https://api.github.com/repos/spasovski/fireplace/hooks","issue_events_url":"https://api.github.com/repos/spasovski/fireplace/issues/events{/number}","events_url":"https://api.github.com/repos/spasovski/fireplace/events","assignees_url":"https://api.github.com/repos/spasovski/fireplace/assignees{/user}","branches_url":"https://api.github.com/repos/spasovski/fireplace/branches{/branch}","tags_url":"https://api.github.com/repos/spasovski/fireplace/tags","blobs_url":"https://api.github.com/repos/spasovski/fireplace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spasovski/fireplace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spasovski/fireplace/git/refs{/sha}","trees_url":"https://api.github.com/repos/spasovski/fireplace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spasovski/fireplace/statuses/{sha}","languages_url":"https://api.github.com/repos/spasovski/fireplace/languages","stargazers_url":"https://api.github.com/repos/spasovski/fireplace/stargazers","contributors_url":"https://api.github.com/repos/spasovski/fireplace/contributors","subscribers_url":"https://api.github.com/repos/spasovski/fireplace/subscribers","subscription_url":"https://api.github.com/repos/spasovski/fireplace/subscription","commits_url":"https://api.github.com/repos/spasovski/fireplace/commits{/sha}","git_commits_url":"https://api.github.com/repos/spasovski/fireplace/git/commits{/sha}","comments_url":"https://api.github.com/repos/spasovski/fireplace/comments{/number}","issue_comment_url":"https://api.github.com/repos/spasovski/fireplace/issues/comments{/number}","contents_url":"https://api.github.com/repos/spasovski/fireplace/contents/{+path}","compare_url":"https://api.github.com/repos/spasovski/fireplace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spasovski/fireplace/merges","archive_url":"https://api.github.com/repos/spasovski/fireplace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spasovski/fireplace/downloads","issues_url":"https://api.github.com/repos/spasovski/fireplace/issues{/number}","pulls_url":"https://api.github.com/repos/spasovski/fireplace/pulls{/number}","milestones_url":"https://api.github.com/repos/spasovski/fireplace/milestones{/number}","notifications_url":"https://api.github.com/repos/spasovski/fireplace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spasovski/fireplace/labels{/name}","releases_url":"https://api.github.com/repos/spasovski/fireplace/releases{/id}","created_at":"2013-02-11T22:39:14Z","updated_at":"2014-11-24T19:16:27Z","pushed_at":"2015-03-26T19:56:45Z","git_url":"git://github.com/spasovski/fireplace.git","ssh_url":"git@github.com:spasovski/fireplace.git","clone_url":"https://github.com/spasovski/fireplace.git","svn_url":"https://github.com/spasovski/fireplace","homepage":"https://marketplace.firefox.com/","size":26626,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"013b1831f4694c83f4c8e66382400194ddca8489","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":8046076,"name":"fireplace","full_name":"mozilla/fireplace","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fireplace","description":"Frontend for the Firefox Marketplace","fork":false,"url":"https://api.github.com/repos/mozilla/fireplace","forks_url":"https://api.github.com/repos/mozilla/fireplace/forks","keys_url":"https://api.github.com/repos/mozilla/fireplace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fireplace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fireplace/teams","hooks_url":"https://api.github.com/repos/mozilla/fireplace/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fireplace/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fireplace/events","assignees_url":"https://api.github.com/repos/mozilla/fireplace/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fireplace/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fireplace/tags","blobs_url":"https://api.github.com/repos/mozilla/fireplace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fireplace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fireplace/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fireplace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fireplace/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fireplace/languages","stargazers_url":"https://api.github.com/repos/mozilla/fireplace/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fireplace/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fireplace/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fireplace/subscription","commits_url":"https://api.github.com/repos/mozilla/fireplace/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fireplace/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fireplace/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fireplace/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/fireplace/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fireplace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fireplace/merges","archive_url":"https://api.github.com/repos/mozilla/fireplace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fireplace/downloads","issues_url":"https://api.github.com/repos/mozilla/fireplace/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fireplace/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fireplace/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fireplace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fireplace/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fireplace/releases{/id}","created_at":"2013-02-06T06:41:06Z","updated_at":"2015-03-26T14:40:15Z","pushed_at":"2015-03-26T19:57:01Z","git_url":"git://github.com/mozilla/fireplace.git","ssh_url":"git@github.com:mozilla/fireplace.git","clone_url":"https://github.com/mozilla/fireplace.git","svn_url":"https://github.com/mozilla/fireplace","homepage":"https://marketplace.firefox.com/","size":90768,"stargazers_count":58,"watchers_count":58,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":99,"mirror_url":null,"open_issues_count":4,"forks":99,"open_issues":4,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/1065"},"html":{"href":"https://github.com/mozilla/fireplace/pull/1065"},"issue":{"href":"https://api.github.com/repos/mozilla/fireplace/issues/1065"},"comments":{"href":"https://api.github.com/repos/mozilla/fireplace/issues/1065/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/1065/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/1065/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/fireplace/statuses/00333932fe4ff7aa2cf24982df0d823316a94063"}}}}