{"comment":{"url":"https://api.github.com/repos/SUSE/spacewalk-testsuite-base/comments/9765115","html_url":"https://github.com/SUSE/spacewalk-testsuite-base/commit/352b6b1ac83b54679c785dbf273e3af4f1712586#commitcomment-9765115","id":9765115,"user":{"login":"dmacvicar","id":15332,"avatar_url":"https://avatars.githubusercontent.com/u/15332?v=3","gravatar_id":"","url":"https://api.github.com/users/dmacvicar","html_url":"https://github.com/dmacvicar","followers_url":"https://api.github.com/users/dmacvicar/followers","following_url":"https://api.github.com/users/dmacvicar/following{/other_user}","gists_url":"https://api.github.com/users/dmacvicar/gists{/gist_id}","starred_url":"https://api.github.com/users/dmacvicar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmacvicar/subscriptions","organizations_url":"https://api.github.com/users/dmacvicar/orgs","repos_url":"https://api.github.com/users/dmacvicar/repos","events_url":"https://api.github.com/users/dmacvicar/events{/privacy}","received_events_url":"https://api.github.com/users/dmacvicar/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"352b6b1ac83b54679c785dbf273e3af4f1712586","created_at":"2015-02-16T16:23:22Z","updated_at":"2015-02-16T16:23:22Z","body":"I am not convinced about this. I agree with changing the concatenation to #{}, but...\r\n\r\n* Do we want to keep that Ouch and that exception caching? The whole logic is convoluted there already.\r\n\r\nIf you look where it is used, it catches the exception to return a boolean. Where it is called it gets the boolean, and if it is false it fails. Fail is just an alias to raise!!!\r\n\r\nSo why not just let the exception emerge and leave the logging of it to cucumber to the proper log?\r\n\r\n"}}