{"action":"created","comment":{"url":"https://api.github.com/repos/google/material-design-lite/pulls/comments/38801932","id":38801932,"diff_hunk":"@@ -87,20 +87,21 @@ window.componentHandler = (function() {\n    * Searches existing DOM for elements of our component type and upgrades them\n    * if they have not already been upgraded.\n    *\n-   * @param {String=} optJsClass the programatic name of the element class we\n+   * @param {string=} optJsClass the programatic name of the element class we\n    * need to create a new instance of.\n-   * @param {String=} optCssClass the name of the CSS class elements of this\n+   * @param {string=} optCssClass the name of the CSS class elements of this\n    * type will have.\n    */\n   function upgradeDomInternal(optJsClass, optCssClass) {\n-    if (optJsClass === undefined && optCssClass === undefined) {\n+    if (typeof optJsClass === 'undefined' &&","path":"src/mdlComponentHandler.js","position":52,"original_position":52,"commit_id":"023c693402729db1319e22914cd0ef57b464422c","original_commit_id":"023c693402729db1319e22914cd0ef57b464422c","user":{"login":"samthor","id":119184,"avatar_url":"https://avatars.githubusercontent.com/u/119184?v=3","gravatar_id":"","url":"https://api.github.com/users/samthor","html_url":"https://github.com/samthor","followers_url":"https://api.github.com/users/samthor/followers","following_url":"https://api.github.com/users/samthor/following{/other_user}","gists_url":"https://api.github.com/users/samthor/gists{/gist_id}","starred_url":"https://api.github.com/users/samthor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samthor/subscriptions","organizations_url":"https://api.github.com/users/samthor/orgs","repos_url":"https://api.github.com/users/samthor/repos","events_url":"https://api.github.com/users/samthor/events{/privacy}","received_events_url":"https://api.github.com/users/samthor/received_events","type":"User","site_admin":false},"body":"I've no strong opinions on this vs the `=== undefined` check, although I haven't read the style guide on this bit lately.","created_at":"2015-09-04T23:14:44Z","updated_at":"2015-09-04T23:14:44Z","html_url":"https://github.com/google/material-design-lite/pull/1551#discussion_r38801932","pull_request_url":"https://api.github.com/repos/google/material-design-lite/pulls/1551","_links":{"self":{"href":"https://api.github.com/repos/google/material-design-lite/pulls/comments/38801932"},"html":{"href":"https://github.com/google/material-design-lite/pull/1551#discussion_r38801932"},"pull_request":{"href":"https://api.github.com/repos/google/material-design-lite/pulls/1551"}}},"pull_request":{"url":"https://api.github.com/repos/google/material-design-lite/pulls/1551","id":44218330,"html_url":"https://github.com/google/material-design-lite/pull/1551","diff_url":"https://github.com/google/material-design-lite/pull/1551.diff","patch_url":"https://github.com/google/material-design-lite/pull/1551.patch","issue_url":"https://api.github.com/repos/google/material-design-lite/issues/1551","number":1551,"state":"open","locked":false,"title":"Closure fixes","user":{"login":"sgomes","id":409615,"avatar_url":"https://avatars.githubusercontent.com/u/409615?v=3","gravatar_id":"","url":"https://api.github.com/users/sgomes","html_url":"https://github.com/sgomes","followers_url":"https://api.github.com/users/sgomes/followers","following_url":"https://api.github.com/users/sgomes/following{/other_user}","gists_url":"https://api.github.com/users/sgomes/gists{/gist_id}","starred_url":"https://api.github.com/users/sgomes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgomes/subscriptions","organizations_url":"https://api.github.com/users/sgomes/orgs","repos_url":"https://api.github.com/users/sgomes/repos","events_url":"https://api.github.com/users/sgomes/events{/privacy}","received_events_url":"https://api.github.com/users/sgomes/received_events","type":"User","site_admin":false},"body":"This PR updates the codebase to play better with the Closure compiler and JSDoc.\r\nIt also tweaks the JSCS config, updates the JSCS version and adds a custom linting rule, all in to enforce checks a bit better.\r\n\r\nThis PR shouldn't break BC.\r\n\r\n@addyosmani @samthor PTAL!","created_at":"2015-09-04T13:36:06Z","updated_at":"2015-09-04T23:14:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03a992d69bac08f8ea0bb9832352cb35caebd461","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/material-design-lite/pulls/1551/commits","review_comments_url":"https://api.github.com/repos/google/material-design-lite/pulls/1551/comments","review_comment_url":"https://api.github.com/repos/google/material-design-lite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/material-design-lite/issues/1551/comments","statuses_url":"https://api.github.com/repos/google/material-design-lite/statuses/023c693402729db1319e22914cd0ef57b464422c","head":{"label":"google:closure-fixes","ref":"closure-fixes","sha":"023c693402729db1319e22914cd0ef57b464422c","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":29268051,"name":"material-design-lite","full_name":"google/material-design-lite","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/material-design-lite","description":"Material Design Lite Components in HTML/CSS/JS","fork":false,"url":"https://api.github.com/repos/google/material-design-lite","forks_url":"https://api.github.com/repos/google/material-design-lite/forks","keys_url":"https://api.github.com/repos/google/material-design-lite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/material-design-lite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/material-design-lite/teams","hooks_url":"https://api.github.com/repos/google/material-design-lite/hooks","issue_events_url":"https://api.github.com/repos/google/material-design-lite/issues/events{/number}","events_url":"https://api.github.com/repos/google/material-design-lite/events","assignees_url":"https://api.github.com/repos/google/material-design-lite/assignees{/user}","branches_url":"https://api.github.com/repos/google/material-design-lite/branches{/branch}","tags_url":"https://api.github.com/repos/google/material-design-lite/tags","blobs_url":"https://api.github.com/repos/google/material-design-lite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/material-design-lite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/material-design-lite/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/material-design-lite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/material-design-lite/statuses/{sha}","languages_url":"https://api.github.com/repos/google/material-design-lite/languages","stargazers_url":"https://api.github.com/repos/google/material-design-lite/stargazers","contributors_url":"https://api.github.com/repos/google/material-design-lite/contributors","subscribers_url":"https://api.github.com/repos/google/material-design-lite/subscribers","subscription_url":"https://api.github.com/repos/google/material-design-lite/subscription","commits_url":"https://api.github.com/repos/google/material-design-lite/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/material-design-lite/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/material-design-lite/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/material-design-lite/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/material-design-lite/contents/{+path}","compare_url":"https://api.github.com/repos/google/material-design-lite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/material-design-lite/merges","archive_url":"https://api.github.com/repos/google/material-design-lite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/material-design-lite/downloads","issues_url":"https://api.github.com/repos/google/material-design-lite/issues{/number}","pulls_url":"https://api.github.com/repos/google/material-design-lite/pulls{/number}","milestones_url":"https://api.github.com/repos/google/material-design-lite/milestones{/number}","notifications_url":"https://api.github.com/repos/google/material-design-lite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/material-design-lite/labels{/name}","releases_url":"https://api.github.com/repos/google/material-design-lite/releases{/id}","created_at":"2015-01-14T22:01:33Z","updated_at":"2015-09-04T21:52:00Z","pushed_at":"2015-09-04T13:36:06Z","git_url":"git://github.com/google/material-design-lite.git","ssh_url":"git@github.com:google/material-design-lite.git","clone_url":"https://github.com/google/material-design-lite.git","svn_url":"https://github.com/google/material-design-lite","homepage":"http://getmdl.io","size":59736,"stargazers_count":14242,"watchers_count":14242,"language":"CSS","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":1780,"mirror_url":null,"open_issues_count":290,"forks":1780,"open_issues":290,"watchers":14242,"default_branch":"master"}},"base":{"label":"google:mdl-1.0","ref":"mdl-1.0","sha":"d3e54055714417134826612deace1eaeb5ad760d","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":29268051,"name":"material-design-lite","full_name":"google/material-design-lite","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/material-design-lite","description":"Material Design Lite Components in HTML/CSS/JS","fork":false,"url":"https://api.github.com/repos/google/material-design-lite","forks_url":"https://api.github.com/repos/google/material-design-lite/forks","keys_url":"https://api.github.com/repos/google/material-design-lite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/material-design-lite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/material-design-lite/teams","hooks_url":"https://api.github.com/repos/google/material-design-lite/hooks","issue_events_url":"https://api.github.com/repos/google/material-design-lite/issues/events{/number}","events_url":"https://api.github.com/repos/google/material-design-lite/events","assignees_url":"https://api.github.com/repos/google/material-design-lite/assignees{/user}","branches_url":"https://api.github.com/repos/google/material-design-lite/branches{/branch}","tags_url":"https://api.github.com/repos/google/material-design-lite/tags","blobs_url":"https://api.github.com/repos/google/material-design-lite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/material-design-lite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/material-design-lite/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/material-design-lite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/material-design-lite/statuses/{sha}","languages_url":"https://api.github.com/repos/google/material-design-lite/languages","stargazers_url":"https://api.github.com/repos/google/material-design-lite/stargazers","contributors_url":"https://api.github.com/repos/google/material-design-lite/contributors","subscribers_url":"https://api.github.com/repos/google/material-design-lite/subscribers","subscription_url":"https://api.github.com/repos/google/material-design-lite/subscription","commits_url":"https://api.github.com/repos/google/material-design-lite/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/material-design-lite/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/material-design-lite/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/material-design-lite/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/material-design-lite/contents/{+path}","compare_url":"https://api.github.com/repos/google/material-design-lite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/material-design-lite/merges","archive_url":"https://api.github.com/repos/google/material-design-lite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/material-design-lite/downloads","issues_url":"https://api.github.com/repos/google/material-design-lite/issues{/number}","pulls_url":"https://api.github.com/repos/google/material-design-lite/pulls{/number}","milestones_url":"https://api.github.com/repos/google/material-design-lite/milestones{/number}","notifications_url":"https://api.github.com/repos/google/material-design-lite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/material-design-lite/labels{/name}","releases_url":"https://api.github.com/repos/google/material-design-lite/releases{/id}","created_at":"2015-01-14T22:01:33Z","updated_at":"2015-09-04T21:52:00Z","pushed_at":"2015-09-04T13:36:06Z","git_url":"git://github.com/google/material-design-lite.git","ssh_url":"git@github.com:google/material-design-lite.git","clone_url":"https://github.com/google/material-design-lite.git","svn_url":"https://github.com/google/material-design-lite","homepage":"http://getmdl.io","size":59736,"stargazers_count":14242,"watchers_count":14242,"language":"CSS","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":1780,"mirror_url":null,"open_issues_count":290,"forks":1780,"open_issues":290,"watchers":14242,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/material-design-lite/pulls/1551"},"html":{"href":"https://github.com/google/material-design-lite/pull/1551"},"issue":{"href":"https://api.github.com/repos/google/material-design-lite/issues/1551"},"comments":{"href":"https://api.github.com/repos/google/material-design-lite/issues/1551/comments"},"review_comments":{"href":"https://api.github.com/repos/google/material-design-lite/pulls/1551/comments"},"review_comment":{"href":"https://api.github.com/repos/google/material-design-lite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/material-design-lite/pulls/1551/commits"},"statuses":{"href":"https://api.github.com/repos/google/material-design-lite/statuses/023c693402729db1319e22914cd0ef57b464422c"}}}}