{"action":"created","issue":{"url":"https://api.github.com/repos/kern/minitest-reporters/issues/161","labels_url":"https://api.github.com/repos/kern/minitest-reporters/issues/161/labels{/name}","comments_url":"https://api.github.com/repos/kern/minitest-reporters/issues/161/comments","events_url":"https://api.github.com/repos/kern/minitest-reporters/issues/161/events","html_url":"https://github.com/kern/minitest-reporters/pull/161","id":87651702,"number":161,"title":"add an option to JUnitReporter to write the output to a single xml file","user":{"login":"andruby","id":10639,"avatar_url":"https://avatars.githubusercontent.com/u/10639?v=3","gravatar_id":"","url":"https://api.github.com/users/andruby","html_url":"https://github.com/andruby","followers_url":"https://api.github.com/users/andruby/followers","following_url":"https://api.github.com/users/andruby/following{/other_user}","gists_url":"https://api.github.com/users/andruby/gists{/gist_id}","starred_url":"https://api.github.com/users/andruby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andruby/subscriptions","organizations_url":"https://api.github.com/users/andruby/orgs","repos_url":"https://api.github.com/users/andruby/repos","events_url":"https://api.github.com/users/andruby/events{/privacy}","received_events_url":"https://api.github.com/users/andruby/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-06-12T08:14:44Z","updated_at":"2015-08-31T09:16:43Z","closed_at":"2015-08-31T09:15:56Z","pull_request":{"url":"https://api.github.com/repos/kern/minitest-reporters/pulls/161","html_url":"https://github.com/kern/minitest-reporters/pull/161","diff_url":"https://github.com/kern/minitest-reporters/pull/161.diff","patch_url":"https://github.com/kern/minitest-reporters/pull/161.patch"},"body":"With this Pull Request, you can initialize the JUnitReporter to write its output to a single xml file instead of one xml file per test suite. This can be useful to simplify or speed up CI parsing.\r\n\r\neg:\r\n```ruby\r\nrequire \"minitest/reporters\"\r\nMinitest::Reporters.use! Minitest::Reporters::JUnitReporter.new('reports/path', single_file: true)\r\n```\r\n\r\nIn the process I also changed the position `empty = true` argument to a keyword argument.\r\n\r\n* What do you think would be an appropriate name for the option flag? \r\n* Is it ok to use keyword arguments? Or should I rewrite it to use a ruby 1.9 style options hash?"},"comment":{"url":"https://api.github.com/repos/kern/minitest-reporters/issues/comments/136310313","html_url":"https://github.com/kern/minitest-reporters/pull/161#issuecomment-136310313","issue_url":"https://api.github.com/repos/kern/minitest-reporters/issues/161","id":136310313,"user":{"login":"os97673","id":450628,"avatar_url":"https://avatars.githubusercontent.com/u/450628?v=3","gravatar_id":"","url":"https://api.github.com/users/os97673","html_url":"https://github.com/os97673","followers_url":"https://api.github.com/users/os97673/followers","following_url":"https://api.github.com/users/os97673/following{/other_user}","gists_url":"https://api.github.com/users/os97673/gists{/gist_id}","starred_url":"https://api.github.com/users/os97673/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os97673/subscriptions","organizations_url":"https://api.github.com/users/os97673/orgs","repos_url":"https://api.github.com/users/os97673/repos","events_url":"https://api.github.com/users/os97673/events{/privacy}","received_events_url":"https://api.github.com/users/os97673/received_events","type":"User","site_admin":false},"created_at":"2015-08-31T09:16:43Z","updated_at":"2015-08-31T09:16:43Z","body":"Thank you for the contribution.  I've merged the PR but perhaps you would add some documentation to the class about the new option (so others would know about it ;)"}}