{"push_id":819304798,"size":3,"distinct_size":3,"ref":"refs/heads/UpdateVtkMRMLDoubleArrayNode","head":"f8c3262ea2559489bdde9d33f859525f8096f234","before":"21e49ad1c7244b42c42bb17b0dba25ec14975850","commits":[{"sha":"4e69c73e7326d81e67babec5cc890e6d68181299","author":{"email":"043990a2a235690854ee2001661452aae0ae4276@kitware.com","name":"Alexis Girault"},"message":"ENH: Add test for vtkMRMLDoubleArrayNode set/get methods","distinct":true,"url":"https://api.github.com/repos/agirault/Slicer/commits/4e69c73e7326d81e67babec5cc890e6d68181299"},{"sha":"5d7397aff3ba19071f67f7cb1aba850938f681e0","author":{"email":"043990a2a235690854ee2001661452aae0ae4276@kitware.com","name":"Alexis Girault"},"message":"BUG: Fix support for missing labels in vtkMRMLDoubleArrayStorage reader\n\nThe reader in vtkMRMLDoubleArrayStorage was always setting the\nfirst line of values in the .mcsv file as labels. If the stored\nvtkMRMLDoubleArray had not labels set, then the retrieved double\narray labels would be set to the first line of numerical values,\nassociated with the first data point. This resulted in a missing\ndata point as well as shifted indices for all remaining points,\nand incorrect labels.\n\nThe correction this commit offers is to write the line '# nolabels'\nin the file if labels exist. If the reader finds this line, it will\nset the first line of values as the first data point, instead of\nsetting it as label values.\n\nExamples :\n\nHere are three examples with (u,v,w) as labels, (12.1,425.577,-454)\nfor the first data point, and (8.79633e+09,0,-1) for the second one:\n\n(1) New writer: vtkMRMLDoubleArrayNode with labels\n\n   # measurement file filename.mcsv\n   u,v,w\n   12.1,425.577,-454\n   8.79633e+09,0,-1\n\n(2) New writer: vtkMRMLDoubleArrayNode with no labels set\n\n   # measurement file filename.mcsv\n   # nolabels\n   12.1,425.577,-454\n   8.79633e+09,0,-1\n\n(3) Old writer: vtkMRMLDoubleArrayNode with labels\n\n   # measurement file filename.mcsv\n   # columns = x,y,yerr\n   u,v,w\n   12.1,425.577,-454\n   8.79633e+09,0,-1\n\n(4) Old writer: vtkMRMLDoubleArrayNode with no labels set\n\n   # measurement file filename.mcsv\n   # columns = x,y,yerr\n   12.1,425.577,-454\n   8.79633e+09,0,-1\n\nObservations :\n\nThe line '# columns = x,y,yerr' was hardcoded in the former writer\nand had no meaning related to the actual double array node labels.","distinct":true,"url":"https://api.github.com/repos/agirault/Slicer/commits/5d7397aff3ba19071f67f7cb1aba850938f681e0"},{"sha":"f8c3262ea2559489bdde9d33f859525f8096f234","author":{"email":"043990a2a235690854ee2001661452aae0ae4276@kitware.com","name":"Alexis Girault"},"message":"ENH: Add test for vtkMRMLDoubleArrayStorageNode reader/writer\n\nTests the new writer/reader as well as the reader given the\nold writter convention which was assuming labels were always set.","distinct":true,"url":"https://api.github.com/repos/agirault/Slicer/commits/f8c3262ea2559489bdde9d33f859525f8096f234"}]}