{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/HashtagMC/JblogS/pulls/1","id":51684669,"html_url":"https://github.com/HashtagMC/JblogS/pull/1","diff_url":"https://github.com/HashtagMC/JblogS/pull/1.diff","patch_url":"https://github.com/HashtagMC/JblogS/pull/1.patch","issue_url":"https://api.github.com/repos/HashtagMC/JblogS/issues/1","number":1,"state":"closed","locked":false,"title":"Cleaned up the project","user":{"login":"bambuschop","id":9309710,"avatar_url":"https://avatars.githubusercontent.com/u/9309710?v=3","gravatar_id":"","url":"https://api.github.com/users/bambuschop","html_url":"https://github.com/bambuschop","followers_url":"https://api.github.com/users/bambuschop/followers","following_url":"https://api.github.com/users/bambuschop/following{/other_user}","gists_url":"https://api.github.com/users/bambuschop/gists{/gist_id}","starred_url":"https://api.github.com/users/bambuschop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bambuschop/subscriptions","organizations_url":"https://api.github.com/users/bambuschop/orgs","repos_url":"https://api.github.com/users/bambuschop/repos","events_url":"https://api.github.com/users/bambuschop/events{/privacy}","received_events_url":"https://api.github.com/users/bambuschop/received_events","type":"User","site_admin":false},"body":"Found the JblogS project in the minecraft.de forum and decided to take a look at it. Found some things in the files that weren't necessary or could be done a little bit different to speed up the page. Here's a list of what I changed:\r\n\r\n- moved all JS scripts to the end of the body\r\n  - the blog works fine with including everything at the bottom. While I understand that without jQuery or Pagedown the blog wont show anything it might be better to write a little JS script that displays an error message in case jQuery or Pagedown can't be loaded. When including both in the head the page will keep on loading in case of an error and the user gets no response whatsoever.\r\n\r\n- moved all JS files into own \"js\" folder and CSS files into own \"css\" folder to get some kind of structure in the project\r\n  - having all files flying around somewhere in the project root makes it unecessarily hard to understand what is going on. Having JS files in a \"js\" folder or CSS files in a \"css\" folder cleans up the project with very little effort.\r\n\r\n- added indent to all files\r\n  - it is way easier to read the files with indents.\r\n\r\n- added classes to all attributes with inline css\r\n  - see next point to understand why. ;)\r\n\r\n- moved inline css to own css file\r\n  - while inline css can be useful to quickly test some things it is considered bad practice. In the JblogS example it wont hurt, however it isn't that much harder to write an extra css file where everything is nicely structured.\r\n\r\n- removed sample.html, index.html from \"example\" is enough to show how JblogS works\r\n  - the sample.html does more or less the same thing as the index.html from the example folder. So why bother having both instead of just using the index.html?\r\n\r\n- fixed lorem ipsum generator links (missing http://)\r\n  - (loremipsum.de) will link to <yourdomain>/loremipsum.de and not to http://loremipsum.de\r\n\r\n- renamed \"JblogS Settings.js\" to \"JblogS_Settings.js\" to avoid potential problems\r\n  - spaces in file names? I wouldn't use them. ;)\r\n\r\n- updated README.md to reflect changes\r\n\r\n\r\n#### why did I do that?\r\nI was bored. ;)\r\n\r\nTo see that everything is working with the changes you can take a look [here](http://bamb.at/jblogs/).","created_at":"2015-11-24T16:42:31Z","updated_at":"2015-12-28T14:03:53Z","closed_at":"2015-12-28T14:03:53Z","merged_at":"2015-12-28T14:03:53Z","merge_commit_sha":"b4f00b8c957028dbd09a68bd8861a87e8a0170f2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/HashtagMC/JblogS/pulls/1/commits","review_comments_url":"https://api.github.com/repos/HashtagMC/JblogS/pulls/1/comments","review_comment_url":"https://api.github.com/repos/HashtagMC/JblogS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HashtagMC/JblogS/issues/1/comments","statuses_url":"https://api.github.com/repos/HashtagMC/JblogS/statuses/08ef0e45ba47a359a58609ba6900cf1fd6ce604b","head":{"label":"bambuschop:master","ref":"master","sha":"08ef0e45ba47a359a58609ba6900cf1fd6ce604b","user":{"login":"bambuschop","id":9309710,"avatar_url":"https://avatars.githubusercontent.com/u/9309710?v=3","gravatar_id":"","url":"https://api.github.com/users/bambuschop","html_url":"https://github.com/bambuschop","followers_url":"https://api.github.com/users/bambuschop/followers","following_url":"https://api.github.com/users/bambuschop/following{/other_user}","gists_url":"https://api.github.com/users/bambuschop/gists{/gist_id}","starred_url":"https://api.github.com/users/bambuschop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bambuschop/subscriptions","organizations_url":"https://api.github.com/users/bambuschop/orgs","repos_url":"https://api.github.com/users/bambuschop/repos","events_url":"https://api.github.com/users/bambuschop/events{/privacy}","received_events_url":"https://api.github.com/users/bambuschop/received_events","type":"User","site_admin":false},"repo":{"id":46801199,"name":"JblogS","full_name":"bambuschop/JblogS","owner":{"login":"bambuschop","id":9309710,"avatar_url":"https://avatars.githubusercontent.com/u/9309710?v=3","gravatar_id":"","url":"https://api.github.com/users/bambuschop","html_url":"https://github.com/bambuschop","followers_url":"https://api.github.com/users/bambuschop/followers","following_url":"https://api.github.com/users/bambuschop/following{/other_user}","gists_url":"https://api.github.com/users/bambuschop/gists{/gist_id}","starred_url":"https://api.github.com/users/bambuschop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bambuschop/subscriptions","organizations_url":"https://api.github.com/users/bambuschop/orgs","repos_url":"https://api.github.com/users/bambuschop/repos","events_url":"https://api.github.com/users/bambuschop/events{/privacy}","received_events_url":"https://api.github.com/users/bambuschop/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bambuschop/JblogS","description":"JblogS is a javascript-based blog system.","fork":true,"url":"https://api.github.com/repos/bambuschop/JblogS","forks_url":"https://api.github.com/repos/bambuschop/JblogS/forks","keys_url":"https://api.github.com/repos/bambuschop/JblogS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bambuschop/JblogS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bambuschop/JblogS/teams","hooks_url":"https://api.github.com/repos/bambuschop/JblogS/hooks","issue_events_url":"https://api.github.com/repos/bambuschop/JblogS/issues/events{/number}","events_url":"https://api.github.com/repos/bambuschop/JblogS/events","assignees_url":"https://api.github.com/repos/bambuschop/JblogS/assignees{/user}","branches_url":"https://api.github.com/repos/bambuschop/JblogS/branches{/branch}","tags_url":"https://api.github.com/repos/bambuschop/JblogS/tags","blobs_url":"https://api.github.com/repos/bambuschop/JblogS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bambuschop/JblogS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bambuschop/JblogS/git/refs{/sha}","trees_url":"https://api.github.com/repos/bambuschop/JblogS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bambuschop/JblogS/statuses/{sha}","languages_url":"https://api.github.com/repos/bambuschop/JblogS/languages","stargazers_url":"https://api.github.com/repos/bambuschop/JblogS/stargazers","contributors_url":"https://api.github.com/repos/bambuschop/JblogS/contributors","subscribers_url":"https://api.github.com/repos/bambuschop/JblogS/subscribers","subscription_url":"https://api.github.com/repos/bambuschop/JblogS/subscription","commits_url":"https://api.github.com/repos/bambuschop/JblogS/commits{/sha}","git_commits_url":"https://api.github.com/repos/bambuschop/JblogS/git/commits{/sha}","comments_url":"https://api.github.com/repos/bambuschop/JblogS/comments{/number}","issue_comment_url":"https://api.github.com/repos/bambuschop/JblogS/issues/comments{/number}","contents_url":"https://api.github.com/repos/bambuschop/JblogS/contents/{+path}","compare_url":"https://api.github.com/repos/bambuschop/JblogS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bambuschop/JblogS/merges","archive_url":"https://api.github.com/repos/bambuschop/JblogS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bambuschop/JblogS/downloads","issues_url":"https://api.github.com/repos/bambuschop/JblogS/issues{/number}","pulls_url":"https://api.github.com/repos/bambuschop/JblogS/pulls{/number}","milestones_url":"https://api.github.com/repos/bambuschop/JblogS/milestones{/number}","notifications_url":"https://api.github.com/repos/bambuschop/JblogS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bambuschop/JblogS/labels{/name}","releases_url":"https://api.github.com/repos/bambuschop/JblogS/releases{/id}","created_at":"2015-11-24T15:41:01Z","updated_at":"2015-11-24T15:41:02Z","pushed_at":"2015-11-24T16:26:00Z","git_url":"git://github.com/bambuschop/JblogS.git","ssh_url":"git@github.com:bambuschop/JblogS.git","clone_url":"https://github.com/bambuschop/JblogS.git","svn_url":"https://github.com/bambuschop/JblogS","homepage":"http://hashtag.neocities.org/JblogS","size":27,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HashtagMC:master","ref":"master","sha":"584cdb3a64512c301403d8bef620cca3fe0064a2","user":{"login":"HashtagMC","id":13611718,"avatar_url":"https://avatars.githubusercontent.com/u/13611718?v=3","gravatar_id":"","url":"https://api.github.com/users/HashtagMC","html_url":"https://github.com/HashtagMC","followers_url":"https://api.github.com/users/HashtagMC/followers","following_url":"https://api.github.com/users/HashtagMC/following{/other_user}","gists_url":"https://api.github.com/users/HashtagMC/gists{/gist_id}","starred_url":"https://api.github.com/users/HashtagMC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HashtagMC/subscriptions","organizations_url":"https://api.github.com/users/HashtagMC/orgs","repos_url":"https://api.github.com/users/HashtagMC/repos","events_url":"https://api.github.com/users/HashtagMC/events{/privacy}","received_events_url":"https://api.github.com/users/HashtagMC/received_events","type":"User","site_admin":false},"repo":{"id":40083407,"name":"JblogS","full_name":"HashtagMC/JblogS","owner":{"login":"HashtagMC","id":13611718,"avatar_url":"https://avatars.githubusercontent.com/u/13611718?v=3","gravatar_id":"","url":"https://api.github.com/users/HashtagMC","html_url":"https://github.com/HashtagMC","followers_url":"https://api.github.com/users/HashtagMC/followers","following_url":"https://api.github.com/users/HashtagMC/following{/other_user}","gists_url":"https://api.github.com/users/HashtagMC/gists{/gist_id}","starred_url":"https://api.github.com/users/HashtagMC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HashtagMC/subscriptions","organizations_url":"https://api.github.com/users/HashtagMC/orgs","repos_url":"https://api.github.com/users/HashtagMC/repos","events_url":"https://api.github.com/users/HashtagMC/events{/privacy}","received_events_url":"https://api.github.com/users/HashtagMC/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HashtagMC/JblogS","description":"JblogS is a javascript-based blog system.","fork":false,"url":"https://api.github.com/repos/HashtagMC/JblogS","forks_url":"https://api.github.com/repos/HashtagMC/JblogS/forks","keys_url":"https://api.github.com/repos/HashtagMC/JblogS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HashtagMC/JblogS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HashtagMC/JblogS/teams","hooks_url":"https://api.github.com/repos/HashtagMC/JblogS/hooks","issue_events_url":"https://api.github.com/repos/HashtagMC/JblogS/issues/events{/number}","events_url":"https://api.github.com/repos/HashtagMC/JblogS/events","assignees_url":"https://api.github.com/repos/HashtagMC/JblogS/assignees{/user}","branches_url":"https://api.github.com/repos/HashtagMC/JblogS/branches{/branch}","tags_url":"https://api.github.com/repos/HashtagMC/JblogS/tags","blobs_url":"https://api.github.com/repos/HashtagMC/JblogS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HashtagMC/JblogS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HashtagMC/JblogS/git/refs{/sha}","trees_url":"https://api.github.com/repos/HashtagMC/JblogS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HashtagMC/JblogS/statuses/{sha}","languages_url":"https://api.github.com/repos/HashtagMC/JblogS/languages","stargazers_url":"https://api.github.com/repos/HashtagMC/JblogS/stargazers","contributors_url":"https://api.github.com/repos/HashtagMC/JblogS/contributors","subscribers_url":"https://api.github.com/repos/HashtagMC/JblogS/subscribers","subscription_url":"https://api.github.com/repos/HashtagMC/JblogS/subscription","commits_url":"https://api.github.com/repos/HashtagMC/JblogS/commits{/sha}","git_commits_url":"https://api.github.com/repos/HashtagMC/JblogS/git/commits{/sha}","comments_url":"https://api.github.com/repos/HashtagMC/JblogS/comments{/number}","issue_comment_url":"https://api.github.com/repos/HashtagMC/JblogS/issues/comments{/number}","contents_url":"https://api.github.com/repos/HashtagMC/JblogS/contents/{+path}","compare_url":"https://api.github.com/repos/HashtagMC/JblogS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HashtagMC/JblogS/merges","archive_url":"https://api.github.com/repos/HashtagMC/JblogS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HashtagMC/JblogS/downloads","issues_url":"https://api.github.com/repos/HashtagMC/JblogS/issues{/number}","pulls_url":"https://api.github.com/repos/HashtagMC/JblogS/pulls{/number}","milestones_url":"https://api.github.com/repos/HashtagMC/JblogS/milestones{/number}","notifications_url":"https://api.github.com/repos/HashtagMC/JblogS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HashtagMC/JblogS/labels{/name}","releases_url":"https://api.github.com/repos/HashtagMC/JblogS/releases{/id}","created_at":"2015-08-02T15:18:20Z","updated_at":"2015-09-25T18:02:13Z","pushed_at":"2015-12-28T14:03:53Z","git_url":"git://github.com/HashtagMC/JblogS.git","ssh_url":"git@github.com:HashtagMC/JblogS.git","clone_url":"https://github.com/HashtagMC/JblogS.git","svn_url":"https://github.com/HashtagMC/JblogS","homepage":"http://hashtag.neocities.org/JblogS","size":204,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HashtagMC/JblogS/pulls/1"},"html":{"href":"https://github.com/HashtagMC/JblogS/pull/1"},"issue":{"href":"https://api.github.com/repos/HashtagMC/JblogS/issues/1"},"comments":{"href":"https://api.github.com/repos/HashtagMC/JblogS/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/HashtagMC/JblogS/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/HashtagMC/JblogS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HashtagMC/JblogS/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/HashtagMC/JblogS/statuses/08ef0e45ba47a359a58609ba6900cf1fd6ce604b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"HashtagMC","id":13611718,"avatar_url":"https://avatars.githubusercontent.com/u/13611718?v=3","gravatar_id":"","url":"https://api.github.com/users/HashtagMC","html_url":"https://github.com/HashtagMC","followers_url":"https://api.github.com/users/HashtagMC/followers","following_url":"https://api.github.com/users/HashtagMC/following{/other_user}","gists_url":"https://api.github.com/users/HashtagMC/gists{/gist_id}","starred_url":"https://api.github.com/users/HashtagMC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HashtagMC/subscriptions","organizations_url":"https://api.github.com/users/HashtagMC/orgs","repos_url":"https://api.github.com/users/HashtagMC/repos","events_url":"https://api.github.com/users/HashtagMC/events{/privacy}","received_events_url":"https://api.github.com/users/HashtagMC/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":177,"deletions":175,"changed_files":15}}