{"action":"closed","number":30,"pull_request":{"url":"https://api.github.com/repos/glyptodon/guacamole-server/pulls/30","id":29870371,"html_url":"https://github.com/glyptodon/guacamole-server/pull/30","diff_url":"https://github.com/glyptodon/guacamole-server/pull/30.diff","patch_url":"https://github.com/glyptodon/guacamole-server/pull/30.patch","issue_url":"https://api.github.com/repos/glyptodon/guacamole-server/issues/30","number":30,"state":"closed","locked":false,"title":"GUAC-1095: Free any existing bitmap data prior to overwriting the bitmap data pointer.","user":{"login":"mike-jumper","id":4632905,"avatar_url":"https://avatars.githubusercontent.com/u/4632905?v=3","gravatar_id":"","url":"https://api.github.com/users/mike-jumper","html_url":"https://github.com/mike-jumper","followers_url":"https://api.github.com/users/mike-jumper/followers","following_url":"https://api.github.com/users/mike-jumper/following{/other_user}","gists_url":"https://api.github.com/users/mike-jumper/gists{/gist_id}","starred_url":"https://api.github.com/users/mike-jumper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike-jumper/subscriptions","organizations_url":"https://api.github.com/users/mike-jumper/orgs","repos_url":"https://api.github.com/users/mike-jumper/repos","events_url":"https://api.github.com/users/mike-jumper/events{/privacy}","received_events_url":"https://api.github.com/users/mike-jumper/received_events","type":"User","site_admin":false},"body":"When FreeRDP receives a bitmap update from the RDP server, it calls a supplied decompression function to handle decompression and assign the resulting data to the ```bitmap->data``` pointer. FreeRDP will also occasionally reuse past bitmap cache entries. This is all fine.\r\n\r\nUnfortunately, the bitmap free function supplied by the implementation is only invoked *after* decompression. This will properly result in implementation-specific data being freed, but since the decompression function *must* assign to ```bitmap->data``` by definition, a memory leak will result if that decompression function does not also free anything already in ```bitmap->data```.","created_at":"2015-02-24T04:32:40Z","updated_at":"2015-02-24T05:05:41Z","closed_at":"2015-02-24T05:05:41Z","merged_at":"2015-02-24T05:05:41Z","merge_commit_sha":"6e31af7a524725f406bf49563c43c49a6257f05e","assignee":{"login":"jmuehlner","id":4633119,"avatar_url":"https://avatars.githubusercontent.com/u/4633119?v=3","gravatar_id":"","url":"https://api.github.com/users/jmuehlner","html_url":"https://github.com/jmuehlner","followers_url":"https://api.github.com/users/jmuehlner/followers","following_url":"https://api.github.com/users/jmuehlner/following{/other_user}","gists_url":"https://api.github.com/users/jmuehlner/gists{/gist_id}","starred_url":"https://api.github.com/users/jmuehlner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmuehlner/subscriptions","organizations_url":"https://api.github.com/users/jmuehlner/orgs","repos_url":"https://api.github.com/users/jmuehlner/repos","events_url":"https://api.github.com/users/jmuehlner/events{/privacy}","received_events_url":"https://api.github.com/users/jmuehlner/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/glyptodon/guacamole-server/pulls/30/commits","review_comments_url":"https://api.github.com/repos/glyptodon/guacamole-server/pulls/30/comments","review_comment_url":"https://api.github.com/repos/glyptodon/guacamole-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/glyptodon/guacamole-server/issues/30/comments","statuses_url":"https://api.github.com/repos/glyptodon/guacamole-server/statuses/001b8188e843ad0b1c5e45267a1d713bf5634bd0","head":{"label":"glyptodon:bitmap-memory-leak","ref":"bitmap-memory-leak","sha":"001b8188e843ad0b1c5e45267a1d713bf5634bd0","user":{"login":"glyptodon","id":4632960,"avatar_url":"https://avatars.githubusercontent.com/u/4632960?v=3","gravatar_id":"","url":"https://api.github.com/users/glyptodon","html_url":"https://github.com/glyptodon","followers_url":"https://api.github.com/users/glyptodon/followers","following_url":"https://api.github.com/users/glyptodon/following{/other_user}","gists_url":"https://api.github.com/users/glyptodon/gists{/gist_id}","starred_url":"https://api.github.com/users/glyptodon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glyptodon/subscriptions","organizations_url":"https://api.github.com/users/glyptodon/orgs","repos_url":"https://api.github.com/users/glyptodon/repos","events_url":"https://api.github.com/users/glyptodon/events{/privacy}","received_events_url":"https://api.github.com/users/glyptodon/received_events","type":"Organization","site_admin":false},"repo":{"id":10532458,"name":"guacamole-server","full_name":"glyptodon/guacamole-server","owner":{"login":"glyptodon","id":4632960,"avatar_url":"https://avatars.githubusercontent.com/u/4632960?v=3","gravatar_id":"","url":"https://api.github.com/users/glyptodon","html_url":"https://github.com/glyptodon","followers_url":"https://api.github.com/users/glyptodon/followers","following_url":"https://api.github.com/users/glyptodon/following{/other_user}","gists_url":"https://api.github.com/users/glyptodon/gists{/gist_id}","starred_url":"https://api.github.com/users/glyptodon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glyptodon/subscriptions","organizations_url":"https://api.github.com/users/glyptodon/orgs","repos_url":"https://api.github.com/users/glyptodon/repos","events_url":"https://api.github.com/users/glyptodon/events{/privacy}","received_events_url":"https://api.github.com/users/glyptodon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/glyptodon/guacamole-server","description":"The server-side, native components that form the Guacamole proxy.","fork":false,"url":"https://api.github.com/repos/glyptodon/guacamole-server","forks_url":"https://api.github.com/repos/glyptodon/guacamole-server/forks","keys_url":"https://api.github.com/repos/glyptodon/guacamole-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/glyptodon/guacamole-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/glyptodon/guacamole-server/teams","hooks_url":"https://api.github.com/repos/glyptodon/guacamole-server/hooks","issue_events_url":"https://api.github.com/repos/glyptodon/guacamole-server/issues/events{/number}","events_url":"https://api.github.com/repos/glyptodon/guacamole-server/events","assignees_url":"https://api.github.com/repos/glyptodon/guacamole-server/assignees{/user}","branches_url":"https://api.github.com/repos/glyptodon/guacamole-server/branches{/branch}","tags_url":"https://api.github.com/repos/glyptodon/guacamole-server/tags","blobs_url":"https://api.github.com/repos/glyptodon/guacamole-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/glyptodon/guacamole-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/glyptodon/guacamole-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/glyptodon/guacamole-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/glyptodon/guacamole-server/statuses/{sha}","languages_url":"https://api.github.com/repos/glyptodon/guacamole-server/languages","stargazers_url":"https://api.github.com/repos/glyptodon/guacamole-server/stargazers","contributors_url":"https://api.github.com/repos/glyptodon/guacamole-server/contributors","subscribers_url":"https://api.github.com/repos/glyptodon/guacamole-server/subscribers","subscription_url":"https://api.github.com/repos/glyptodon/guacamole-server/subscription","commits_url":"https://api.github.com/repos/glyptodon/guacamole-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/glyptodon/guacamole-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/glyptodon/guacamole-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/glyptodon/guacamole-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/glyptodon/guacamole-server/contents/{+path}","compare_url":"https://api.github.com/repos/glyptodon/guacamole-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/glyptodon/guacamole-server/merges","archive_url":"https://api.github.com/repos/glyptodon/guacamole-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/glyptodon/guacamole-server/downloads","issues_url":"https://api.github.com/repos/glyptodon/guacamole-server/issues{/number}","pulls_url":"https://api.github.com/repos/glyptodon/guacamole-server/pulls{/number}","milestones_url":"https://api.github.com/repos/glyptodon/guacamole-server/milestones{/number}","notifications_url":"https://api.github.com/repos/glyptodon/guacamole-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/glyptodon/guacamole-server/labels{/name}","releases_url":"https://api.github.com/repos/glyptodon/guacamole-server/releases{/id}","created_at":"2013-06-06T17:40:59Z","updated_at":"2015-02-23T14:30:22Z","pushed_at":"2015-02-24T05:05:41Z","git_url":"git://github.com/glyptodon/guacamole-server.git","ssh_url":"git@github.com:glyptodon/guacamole-server.git","clone_url":"https://github.com/glyptodon/guacamole-server.git","svn_url":"https://github.com/glyptodon/guacamole-server","homepage":"http://guac-dev.org/","size":6978,"stargazers_count":529,"watchers_count":529,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":63,"mirror_url":null,"open_issues_count":3,"forks":63,"open_issues":3,"watchers":529,"default_branch":"master"}},"base":{"label":"glyptodon:master","ref":"master","sha":"b1d678829228cd0b58eeb765dbef6a6ef7ea68d5","user":{"login":"glyptodon","id":4632960,"avatar_url":"https://avatars.githubusercontent.com/u/4632960?v=3","gravatar_id":"","url":"https://api.github.com/users/glyptodon","html_url":"https://github.com/glyptodon","followers_url":"https://api.github.com/users/glyptodon/followers","following_url":"https://api.github.com/users/glyptodon/following{/other_user}","gists_url":"https://api.github.com/users/glyptodon/gists{/gist_id}","starred_url":"https://api.github.com/users/glyptodon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glyptodon/subscriptions","organizations_url":"https://api.github.com/users/glyptodon/orgs","repos_url":"https://api.github.com/users/glyptodon/repos","events_url":"https://api.github.com/users/glyptodon/events{/privacy}","received_events_url":"https://api.github.com/users/glyptodon/received_events","type":"Organization","site_admin":false},"repo":{"id":10532458,"name":"guacamole-server","full_name":"glyptodon/guacamole-server","owner":{"login":"glyptodon","id":4632960,"avatar_url":"https://avatars.githubusercontent.com/u/4632960?v=3","gravatar_id":"","url":"https://api.github.com/users/glyptodon","html_url":"https://github.com/glyptodon","followers_url":"https://api.github.com/users/glyptodon/followers","following_url":"https://api.github.com/users/glyptodon/following{/other_user}","gists_url":"https://api.github.com/users/glyptodon/gists{/gist_id}","starred_url":"https://api.github.com/users/glyptodon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glyptodon/subscriptions","organizations_url":"https://api.github.com/users/glyptodon/orgs","repos_url":"https://api.github.com/users/glyptodon/repos","events_url":"https://api.github.com/users/glyptodon/events{/privacy}","received_events_url":"https://api.github.com/users/glyptodon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/glyptodon/guacamole-server","description":"The server-side, native components that form the Guacamole proxy.","fork":false,"url":"https://api.github.com/repos/glyptodon/guacamole-server","forks_url":"https://api.github.com/repos/glyptodon/guacamole-server/forks","keys_url":"https://api.github.com/repos/glyptodon/guacamole-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/glyptodon/guacamole-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/glyptodon/guacamole-server/teams","hooks_url":"https://api.github.com/repos/glyptodon/guacamole-server/hooks","issue_events_url":"https://api.github.com/repos/glyptodon/guacamole-server/issues/events{/number}","events_url":"https://api.github.com/repos/glyptodon/guacamole-server/events","assignees_url":"https://api.github.com/repos/glyptodon/guacamole-server/assignees{/user}","branches_url":"https://api.github.com/repos/glyptodon/guacamole-server/branches{/branch}","tags_url":"https://api.github.com/repos/glyptodon/guacamole-server/tags","blobs_url":"https://api.github.com/repos/glyptodon/guacamole-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/glyptodon/guacamole-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/glyptodon/guacamole-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/glyptodon/guacamole-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/glyptodon/guacamole-server/statuses/{sha}","languages_url":"https://api.github.com/repos/glyptodon/guacamole-server/languages","stargazers_url":"https://api.github.com/repos/glyptodon/guacamole-server/stargazers","contributors_url":"https://api.github.com/repos/glyptodon/guacamole-server/contributors","subscribers_url":"https://api.github.com/repos/glyptodon/guacamole-server/subscribers","subscription_url":"https://api.github.com/repos/glyptodon/guacamole-server/subscription","commits_url":"https://api.github.com/repos/glyptodon/guacamole-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/glyptodon/guacamole-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/glyptodon/guacamole-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/glyptodon/guacamole-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/glyptodon/guacamole-server/contents/{+path}","compare_url":"https://api.github.com/repos/glyptodon/guacamole-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/glyptodon/guacamole-server/merges","archive_url":"https://api.github.com/repos/glyptodon/guacamole-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/glyptodon/guacamole-server/downloads","issues_url":"https://api.github.com/repos/glyptodon/guacamole-server/issues{/number}","pulls_url":"https://api.github.com/repos/glyptodon/guacamole-server/pulls{/number}","milestones_url":"https://api.github.com/repos/glyptodon/guacamole-server/milestones{/number}","notifications_url":"https://api.github.com/repos/glyptodon/guacamole-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/glyptodon/guacamole-server/labels{/name}","releases_url":"https://api.github.com/repos/glyptodon/guacamole-server/releases{/id}","created_at":"2013-06-06T17:40:59Z","updated_at":"2015-02-23T14:30:22Z","pushed_at":"2015-02-24T05:05:41Z","git_url":"git://github.com/glyptodon/guacamole-server.git","ssh_url":"git@github.com:glyptodon/guacamole-server.git","clone_url":"https://github.com/glyptodon/guacamole-server.git","svn_url":"https://github.com/glyptodon/guacamole-server","homepage":"http://guac-dev.org/","size":6978,"stargazers_count":529,"watchers_count":529,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":63,"mirror_url":null,"open_issues_count":3,"forks":63,"open_issues":3,"watchers":529,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/glyptodon/guacamole-server/pulls/30"},"html":{"href":"https://github.com/glyptodon/guacamole-server/pull/30"},"issue":{"href":"https://api.github.com/repos/glyptodon/guacamole-server/issues/30"},"comments":{"href":"https://api.github.com/repos/glyptodon/guacamole-server/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/glyptodon/guacamole-server/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/glyptodon/guacamole-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/glyptodon/guacamole-server/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/glyptodon/guacamole-server/statuses/001b8188e843ad0b1c5e45267a1d713bf5634bd0"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jmuehlner","id":4633119,"avatar_url":"https://avatars.githubusercontent.com/u/4633119?v=3","gravatar_id":"","url":"https://api.github.com/users/jmuehlner","html_url":"https://github.com/jmuehlner","followers_url":"https://api.github.com/users/jmuehlner/followers","following_url":"https://api.github.com/users/jmuehlner/following{/other_user}","gists_url":"https://api.github.com/users/jmuehlner/gists{/gist_id}","starred_url":"https://api.github.com/users/jmuehlner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmuehlner/subscriptions","organizations_url":"https://api.github.com/users/jmuehlner/orgs","repos_url":"https://api.github.com/users/jmuehlner/repos","events_url":"https://api.github.com/users/jmuehlner/events{/privacy}","received_events_url":"https://api.github.com/users/jmuehlner/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":9,"deletions":0,"changed_files":1}}