{"action":"created","comment":{"url":"https://api.github.com/repos/kyleshay/DIM/pulls/comments/36596364","id":36596364,"diff_hunk":"@@ -110,15 +111,21 @@\n       }\n \n       filterFn = function(item) {\n-        return (_.reduce(tempFns, function(memo, fn) {\n-          return memo || fn(item);\n-        }, false));\n+        var checks = 0;\n+        _.each(filters, function(filter){\n+          if(item.hasOwnProperty([filter.predicate])){","path":"app/scripts/shell/dimSearchFilter.directive.js","position":26,"original_position":26,"commit_id":"d7be200a6335c29e0d03be2b48fd91c98bfd090b","original_commit_id":"d7be200a6335c29e0d03be2b48fd91c98bfd090b","user":{"login":"SunburnedGoose","id":984608,"avatar_url":"https://avatars.githubusercontent.com/u/984608?v=3","gravatar_id":"","url":"https://api.github.com/users/SunburnedGoose","html_url":"https://github.com/SunburnedGoose","followers_url":"https://api.github.com/users/SunburnedGoose/followers","following_url":"https://api.github.com/users/SunburnedGoose/following{/other_user}","gists_url":"https://api.github.com/users/SunburnedGoose/gists{/gist_id}","starred_url":"https://api.github.com/users/SunburnedGoose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SunburnedGoose/subscriptions","organizations_url":"https://api.github.com/users/SunburnedGoose/orgs","repos_url":"https://api.github.com/users/SunburnedGoose/repos","events_url":"https://api.github.com/users/SunburnedGoose/events{/privacy}","received_events_url":"https://api.github.com/users/SunburnedGoose/received_events","type":"User","site_admin":false},"body":"Where is the check on the tempFns?  Those functions need to be executed to determine if an item should be visible.  A simple property check isn't sufficient for things like incomplete.  You'll have to test the item.","created_at":"2015-08-10T00:54:33Z","updated_at":"2015-08-10T00:54:33Z","html_url":"https://github.com/kyleshay/DIM/pull/191#discussion_r36596364","pull_request_url":"https://api.github.com/repos/kyleshay/DIM/pulls/191","_links":{"self":{"href":"https://api.github.com/repos/kyleshay/DIM/pulls/comments/36596364"},"html":{"href":"https://github.com/kyleshay/DIM/pull/191#discussion_r36596364"},"pull_request":{"href":"https://api.github.com/repos/kyleshay/DIM/pulls/191"}}},"pull_request":{"url":"https://api.github.com/repos/kyleshay/DIM/pulls/191","id":41954916,"html_url":"https://github.com/kyleshay/DIM/pull/191","diff_url":"https://github.com/kyleshay/DIM/pull/191.diff","patch_url":"https://github.com/kyleshay/DIM/pull/191.patch","issue_url":"https://api.github.com/repos/kyleshay/DIM/issues/191","number":191,"state":"open","locked":false,"title":"Fixed issue #186, search by multiple params","user":{"login":"flameofzion","id":3309839,"avatar_url":"https://avatars.githubusercontent.com/u/3309839?v=3","gravatar_id":"","url":"https://api.github.com/users/flameofzion","html_url":"https://github.com/flameofzion","followers_url":"https://api.github.com/users/flameofzion/followers","following_url":"https://api.github.com/users/flameofzion/following{/other_user}","gists_url":"https://api.github.com/users/flameofzion/gists{/gist_id}","starred_url":"https://api.github.com/users/flameofzion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flameofzion/subscriptions","organizations_url":"https://api.github.com/users/flameofzion/orgs","repos_url":"https://api.github.com/users/flameofzion/repos","events_url":"https://api.github.com/users/flameofzion/events{/privacy}","received_events_url":"https://api.github.com/users/flameofzion/received_events","type":"User","site_admin":false},"body":"Not quite as elegant as the previous solution, but it works as far as I can tell. Haven't done any performance testing either. But it didn't seem to bad when I was testing it. I had to change a couple of the names in the filterFns and filterTrans arrays to coincide with the item object. ","created_at":"2015-08-08T14:30:15Z","updated_at":"2015-08-10T00:54:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"300cc019b5edda814c67abaa31840db310b74caa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kyleshay/DIM/pulls/191/commits","review_comments_url":"https://api.github.com/repos/kyleshay/DIM/pulls/191/comments","review_comment_url":"https://api.github.com/repos/kyleshay/DIM/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kyleshay/DIM/issues/191/comments","statuses_url":"https://api.github.com/repos/kyleshay/DIM/statuses/d7be200a6335c29e0d03be2b48fd91c98bfd090b","head":{"label":"flameofzion:master","ref":"master","sha":"d7be200a6335c29e0d03be2b48fd91c98bfd090b","user":{"login":"flameofzion","id":3309839,"avatar_url":"https://avatars.githubusercontent.com/u/3309839?v=3","gravatar_id":"","url":"https://api.github.com/users/flameofzion","html_url":"https://github.com/flameofzion","followers_url":"https://api.github.com/users/flameofzion/followers","following_url":"https://api.github.com/users/flameofzion/following{/other_user}","gists_url":"https://api.github.com/users/flameofzion/gists{/gist_id}","starred_url":"https://api.github.com/users/flameofzion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flameofzion/subscriptions","organizations_url":"https://api.github.com/users/flameofzion/orgs","repos_url":"https://api.github.com/users/flameofzion/repos","events_url":"https://api.github.com/users/flameofzion/events{/privacy}","received_events_url":"https://api.github.com/users/flameofzion/received_events","type":"User","site_admin":false},"repo":{"id":40284866,"name":"DIM","full_name":"flameofzion/DIM","owner":{"login":"flameofzion","id":3309839,"avatar_url":"https://avatars.githubusercontent.com/u/3309839?v=3","gravatar_id":"","url":"https://api.github.com/users/flameofzion","html_url":"https://github.com/flameofzion","followers_url":"https://api.github.com/users/flameofzion/followers","following_url":"https://api.github.com/users/flameofzion/following{/other_user}","gists_url":"https://api.github.com/users/flameofzion/gists{/gist_id}","starred_url":"https://api.github.com/users/flameofzion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flameofzion/subscriptions","organizations_url":"https://api.github.com/users/flameofzion/orgs","repos_url":"https://api.github.com/users/flameofzion/repos","events_url":"https://api.github.com/users/flameofzion/events{/privacy}","received_events_url":"https://api.github.com/users/flameofzion/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/flameofzion/DIM","description":"Destiny Item Manager","fork":true,"url":"https://api.github.com/repos/flameofzion/DIM","forks_url":"https://api.github.com/repos/flameofzion/DIM/forks","keys_url":"https://api.github.com/repos/flameofzion/DIM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flameofzion/DIM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flameofzion/DIM/teams","hooks_url":"https://api.github.com/repos/flameofzion/DIM/hooks","issue_events_url":"https://api.github.com/repos/flameofzion/DIM/issues/events{/number}","events_url":"https://api.github.com/repos/flameofzion/DIM/events","assignees_url":"https://api.github.com/repos/flameofzion/DIM/assignees{/user}","branches_url":"https://api.github.com/repos/flameofzion/DIM/branches{/branch}","tags_url":"https://api.github.com/repos/flameofzion/DIM/tags","blobs_url":"https://api.github.com/repos/flameofzion/DIM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flameofzion/DIM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flameofzion/DIM/git/refs{/sha}","trees_url":"https://api.github.com/repos/flameofzion/DIM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flameofzion/DIM/statuses/{sha}","languages_url":"https://api.github.com/repos/flameofzion/DIM/languages","stargazers_url":"https://api.github.com/repos/flameofzion/DIM/stargazers","contributors_url":"https://api.github.com/repos/flameofzion/DIM/contributors","subscribers_url":"https://api.github.com/repos/flameofzion/DIM/subscribers","subscription_url":"https://api.github.com/repos/flameofzion/DIM/subscription","commits_url":"https://api.github.com/repos/flameofzion/DIM/commits{/sha}","git_commits_url":"https://api.github.com/repos/flameofzion/DIM/git/commits{/sha}","comments_url":"https://api.github.com/repos/flameofzion/DIM/comments{/number}","issue_comment_url":"https://api.github.com/repos/flameofzion/DIM/issues/comments{/number}","contents_url":"https://api.github.com/repos/flameofzion/DIM/contents/{+path}","compare_url":"https://api.github.com/repos/flameofzion/DIM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flameofzion/DIM/merges","archive_url":"https://api.github.com/repos/flameofzion/DIM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flameofzion/DIM/downloads","issues_url":"https://api.github.com/repos/flameofzion/DIM/issues{/number}","pulls_url":"https://api.github.com/repos/flameofzion/DIM/pulls{/number}","milestones_url":"https://api.github.com/repos/flameofzion/DIM/milestones{/number}","notifications_url":"https://api.github.com/repos/flameofzion/DIM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flameofzion/DIM/labels{/name}","releases_url":"https://api.github.com/repos/flameofzion/DIM/releases{/id}","created_at":"2015-08-06T04:45:55Z","updated_at":"2015-08-06T04:45:57Z","pushed_at":"2015-08-08T14:26:00Z","git_url":"git://github.com/flameofzion/DIM.git","ssh_url":"git@github.com:flameofzion/DIM.git","clone_url":"https://github.com/flameofzion/DIM.git","svn_url":"https://github.com/flameofzion/DIM","homepage":"https://chrome.google.com/webstore/detail/destiny-item-manager/apghicjnekejhfancbkahkhdckhdagna","size":48506,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kyleshay:dev","ref":"dev","sha":"f6526870be1d41b812739568a98113e6f2345d56","user":{"login":"kyleshay","id":424158,"avatar_url":"https://avatars.githubusercontent.com/u/424158?v=3","gravatar_id":"","url":"https://api.github.com/users/kyleshay","html_url":"https://github.com/kyleshay","followers_url":"https://api.github.com/users/kyleshay/followers","following_url":"https://api.github.com/users/kyleshay/following{/other_user}","gists_url":"https://api.github.com/users/kyleshay/gists{/gist_id}","starred_url":"https://api.github.com/users/kyleshay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyleshay/subscriptions","organizations_url":"https://api.github.com/users/kyleshay/orgs","repos_url":"https://api.github.com/users/kyleshay/repos","events_url":"https://api.github.com/users/kyleshay/events{/privacy}","received_events_url":"https://api.github.com/users/kyleshay/received_events","type":"User","site_admin":false},"repo":{"id":31681575,"name":"DIM","full_name":"kyleshay/DIM","owner":{"login":"kyleshay","id":424158,"avatar_url":"https://avatars.githubusercontent.com/u/424158?v=3","gravatar_id":"","url":"https://api.github.com/users/kyleshay","html_url":"https://github.com/kyleshay","followers_url":"https://api.github.com/users/kyleshay/followers","following_url":"https://api.github.com/users/kyleshay/following{/other_user}","gists_url":"https://api.github.com/users/kyleshay/gists{/gist_id}","starred_url":"https://api.github.com/users/kyleshay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyleshay/subscriptions","organizations_url":"https://api.github.com/users/kyleshay/orgs","repos_url":"https://api.github.com/users/kyleshay/repos","events_url":"https://api.github.com/users/kyleshay/events{/privacy}","received_events_url":"https://api.github.com/users/kyleshay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kyleshay/DIM","description":"Destiny Item Manager","fork":false,"url":"https://api.github.com/repos/kyleshay/DIM","forks_url":"https://api.github.com/repos/kyleshay/DIM/forks","keys_url":"https://api.github.com/repos/kyleshay/DIM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kyleshay/DIM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kyleshay/DIM/teams","hooks_url":"https://api.github.com/repos/kyleshay/DIM/hooks","issue_events_url":"https://api.github.com/repos/kyleshay/DIM/issues/events{/number}","events_url":"https://api.github.com/repos/kyleshay/DIM/events","assignees_url":"https://api.github.com/repos/kyleshay/DIM/assignees{/user}","branches_url":"https://api.github.com/repos/kyleshay/DIM/branches{/branch}","tags_url":"https://api.github.com/repos/kyleshay/DIM/tags","blobs_url":"https://api.github.com/repos/kyleshay/DIM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kyleshay/DIM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kyleshay/DIM/git/refs{/sha}","trees_url":"https://api.github.com/repos/kyleshay/DIM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kyleshay/DIM/statuses/{sha}","languages_url":"https://api.github.com/repos/kyleshay/DIM/languages","stargazers_url":"https://api.github.com/repos/kyleshay/DIM/stargazers","contributors_url":"https://api.github.com/repos/kyleshay/DIM/contributors","subscribers_url":"https://api.github.com/repos/kyleshay/DIM/subscribers","subscription_url":"https://api.github.com/repos/kyleshay/DIM/subscription","commits_url":"https://api.github.com/repos/kyleshay/DIM/commits{/sha}","git_commits_url":"https://api.github.com/repos/kyleshay/DIM/git/commits{/sha}","comments_url":"https://api.github.com/repos/kyleshay/DIM/comments{/number}","issue_comment_url":"https://api.github.com/repos/kyleshay/DIM/issues/comments{/number}","contents_url":"https://api.github.com/repos/kyleshay/DIM/contents/{+path}","compare_url":"https://api.github.com/repos/kyleshay/DIM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kyleshay/DIM/merges","archive_url":"https://api.github.com/repos/kyleshay/DIM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kyleshay/DIM/downloads","issues_url":"https://api.github.com/repos/kyleshay/DIM/issues{/number}","pulls_url":"https://api.github.com/repos/kyleshay/DIM/pulls{/number}","milestones_url":"https://api.github.com/repos/kyleshay/DIM/milestones{/number}","notifications_url":"https://api.github.com/repos/kyleshay/DIM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kyleshay/DIM/labels{/name}","releases_url":"https://api.github.com/repos/kyleshay/DIM/releases{/id}","created_at":"2015-03-04T21:46:50Z","updated_at":"2015-08-09T04:03:28Z","pushed_at":"2015-08-08T14:30:15Z","git_url":"git://github.com/kyleshay/DIM.git","ssh_url":"git@github.com:kyleshay/DIM.git","clone_url":"https://github.com/kyleshay/DIM.git","svn_url":"https://github.com/kyleshay/DIM","homepage":"https://chrome.google.com/webstore/detail/destiny-item-manager/apghicjnekejhfancbkahkhdckhdagna","size":48506,"stargazers_count":193,"watchers_count":193,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":107,"mirror_url":null,"open_issues_count":64,"forks":107,"open_issues":64,"watchers":193,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kyleshay/DIM/pulls/191"},"html":{"href":"https://github.com/kyleshay/DIM/pull/191"},"issue":{"href":"https://api.github.com/repos/kyleshay/DIM/issues/191"},"comments":{"href":"https://api.github.com/repos/kyleshay/DIM/issues/191/comments"},"review_comments":{"href":"https://api.github.com/repos/kyleshay/DIM/pulls/191/comments"},"review_comment":{"href":"https://api.github.com/repos/kyleshay/DIM/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kyleshay/DIM/pulls/191/commits"},"statuses":{"href":"https://api.github.com/repos/kyleshay/DIM/statuses/d7be200a6335c29e0d03be2b48fd91c98bfd090b"}}}}