{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/css-layout/issues/139","labels_url":"https://api.github.com/repos/facebook/css-layout/issues/139/labels{/name}","comments_url":"https://api.github.com/repos/facebook/css-layout/issues/139/comments","events_url":"https://api.github.com/repos/facebook/css-layout/issues/139/events","html_url":"https://github.com/facebook/css-layout/pull/139","id":109784863,"number":139,"title":"Eslint - enforces many more rules.","user":{"login":"ColinEberhardt","id":1098110,"avatar_url":"https://avatars.githubusercontent.com/u/1098110?v=3","gravatar_id":"","url":"https://api.github.com/users/ColinEberhardt","html_url":"https://github.com/ColinEberhardt","followers_url":"https://api.github.com/users/ColinEberhardt/followers","following_url":"https://api.github.com/users/ColinEberhardt/following{/other_user}","gists_url":"https://api.github.com/users/ColinEberhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/ColinEberhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ColinEberhardt/subscriptions","organizations_url":"https://api.github.com/users/ColinEberhardt/orgs","repos_url":"https://api.github.com/users/ColinEberhardt/repos","events_url":"https://api.github.com/users/ColinEberhardt/events{/privacy}","received_events_url":"https://api.github.com/users/ColinEberhardt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-10-05T12:23:25Z","updated_at":"2015-10-07T20:53:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/css-layout/pulls/139","html_url":"https://github.com/facebook/css-layout/pull/139","diff_url":"https://github.com/facebook/css-layout/pull/139.diff","patch_url":"https://github.com/facebook/css-layout/pull/139.patch"},"body":"Based on the review comments I saw for #138 I thought the linting rules could do with being 'tightened up'.\r\n\r\nI checked the `.eslintrc` and found that the only thing being checked was the quotes style, and that was only being applied to `Layout.js`!\r\n\r\nI've auto-configured ESLint based on the existing codebase, then added a few rules that I think are most important. Let me know what you think."},"comment":{"url":"https://api.github.com/repos/facebook/css-layout/issues/comments/146324710","html_url":"https://github.com/facebook/css-layout/pull/139#issuecomment-146324710","issue_url":"https://api.github.com/repos/facebook/css-layout/issues/139","id":146324710,"user":{"login":"ColinEberhardt","id":1098110,"avatar_url":"https://avatars.githubusercontent.com/u/1098110?v=3","gravatar_id":"","url":"https://api.github.com/users/ColinEberhardt","html_url":"https://github.com/ColinEberhardt","followers_url":"https://api.github.com/users/ColinEberhardt/followers","following_url":"https://api.github.com/users/ColinEberhardt/following{/other_user}","gists_url":"https://api.github.com/users/ColinEberhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/ColinEberhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ColinEberhardt/subscriptions","organizations_url":"https://api.github.com/users/ColinEberhardt/orgs","repos_url":"https://api.github.com/users/ColinEberhardt/repos","events_url":"https://api.github.com/users/ColinEberhardt/events{/privacy}","received_events_url":"https://api.github.com/users/ColinEberhardt/received_events","type":"User","site_admin":false},"created_at":"2015-10-07T20:53:29Z","updated_at":"2015-10-07T20:53:29Z","body":"@spicyj thanks for the heads up, didn't realise there was a centralised lint configuration. I've updated the PR to use the `fbjs-scripts` eslint configuration and fixed all errors / warnings."}}