{"action":"opened","number":12623,"pull_request":{"url":"https://api.github.com/repos/modxcms/revolution/pulls/12623","id":43880640,"html_url":"https://github.com/modxcms/revolution/pull/12623","diff_url":"https://github.com/modxcms/revolution/pull/12623.diff","patch_url":"https://github.com/modxcms/revolution/pull/12623.patch","issue_url":"https://api.github.com/repos/modxcms/revolution/issues/12623","number":12623,"state":"open","locked":false,"title":"Revert handling output of OnBeforeWebLogin and OnBeforeManagerLogin","user":{"login":"theboxer","id":845220,"avatar_url":"https://avatars.githubusercontent.com/u/845220?v=3","gravatar_id":"","url":"https://api.github.com/users/theboxer","html_url":"https://github.com/theboxer","followers_url":"https://api.github.com/users/theboxer/followers","following_url":"https://api.github.com/users/theboxer/following{/other_user}","gists_url":"https://api.github.com/users/theboxer/gists{/gist_id}","starred_url":"https://api.github.com/users/theboxer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theboxer/subscriptions","organizations_url":"https://api.github.com/users/theboxer/orgs","repos_url":"https://api.github.com/users/theboxer/repos","events_url":"https://api.github.com/users/theboxer/events{/privacy}","received_events_url":"https://api.github.com/users/theboxer/received_events","type":"User","site_admin":false},"body":"### What does it do ?\r\nRevert handling output of OnBeforeWebLogin and OnBeforeManagerLogin events\r\n\r\n### Why is it needed ?\r\nIn 2.4.0 returning true results as an error because different method is used for handling the output which uses `empty` as a method for checking the plugin's output. This reverts back the checking for `$output !== true`\r\n\r\n### Related issue(s)/PR(s)\r\nResolves #12595","created_at":"2015-09-01T14:16:59Z","updated_at":"2015-09-01T14:16:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":{"url":"https://api.github.com/repos/modxcms/revolution/milestones/65","html_url":"https://github.com/modxcms/revolution/milestones/v2.4.1-pl","labels_url":"https://api.github.com/repos/modxcms/revolution/milestones/65/labels","id":1264188,"number":65,"title":"v2.4.1-pl","description":"","creator":{"login":"Mark-H","id":312944,"avatar_url":"https://avatars.githubusercontent.com/u/312944?v=3","gravatar_id":"","url":"https://api.github.com/users/Mark-H","html_url":"https://github.com/Mark-H","followers_url":"https://api.github.com/users/Mark-H/followers","following_url":"https://api.github.com/users/Mark-H/following{/other_user}","gists_url":"https://api.github.com/users/Mark-H/gists{/gist_id}","starred_url":"https://api.github.com/users/Mark-H/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mark-H/subscriptions","organizations_url":"https://api.github.com/users/Mark-H/orgs","repos_url":"https://api.github.com/users/Mark-H/repos","events_url":"https://api.github.com/users/Mark-H/events{/privacy}","received_events_url":"https://api.github.com/users/Mark-H/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":0,"state":"open","created_at":"2015-08-20T10:10:26Z","updated_at":"2015-09-01T14:16:59Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/modxcms/revolution/pulls/12623/commits","review_comments_url":"https://api.github.com/repos/modxcms/revolution/pulls/12623/comments","review_comment_url":"https://api.github.com/repos/modxcms/revolution/pulls/comments{/number}","comments_url":"https://api.github.com/repos/modxcms/revolution/issues/12623/comments","statuses_url":"https://api.github.com/repos/modxcms/revolution/statuses/050170720e9e1de61ed19b864519a3d525493495","head":{"label":"theboxer:fix-login-event-output","ref":"fix-login-event-output","sha":"050170720e9e1de61ed19b864519a3d525493495","user":{"login":"theboxer","id":845220,"avatar_url":"https://avatars.githubusercontent.com/u/845220?v=3","gravatar_id":"","url":"https://api.github.com/users/theboxer","html_url":"https://github.com/theboxer","followers_url":"https://api.github.com/users/theboxer/followers","following_url":"https://api.github.com/users/theboxer/following{/other_user}","gists_url":"https://api.github.com/users/theboxer/gists{/gist_id}","starred_url":"https://api.github.com/users/theboxer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theboxer/subscriptions","organizations_url":"https://api.github.com/users/theboxer/orgs","repos_url":"https://api.github.com/users/theboxer/repos","events_url":"https://api.github.com/users/theboxer/events{/privacy}","received_events_url":"https://api.github.com/users/theboxer/received_events","type":"User","site_admin":false},"repo":{"id":9368689,"name":"revolution","full_name":"theboxer/revolution","owner":{"login":"theboxer","id":845220,"avatar_url":"https://avatars.githubusercontent.com/u/845220?v=3","gravatar_id":"","url":"https://api.github.com/users/theboxer","html_url":"https://github.com/theboxer","followers_url":"https://api.github.com/users/theboxer/followers","following_url":"https://api.github.com/users/theboxer/following{/other_user}","gists_url":"https://api.github.com/users/theboxer/gists{/gist_id}","starred_url":"https://api.github.com/users/theboxer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theboxer/subscriptions","organizations_url":"https://api.github.com/users/theboxer/orgs","repos_url":"https://api.github.com/users/theboxer/repos","events_url":"https://api.github.com/users/theboxer/events{/privacy}","received_events_url":"https://api.github.com/users/theboxer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/theboxer/revolution","description":"MODx Revolution - Content Application Platform","fork":true,"url":"https://api.github.com/repos/theboxer/revolution","forks_url":"https://api.github.com/repos/theboxer/revolution/forks","keys_url":"https://api.github.com/repos/theboxer/revolution/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theboxer/revolution/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theboxer/revolution/teams","hooks_url":"https://api.github.com/repos/theboxer/revolution/hooks","issue_events_url":"https://api.github.com/repos/theboxer/revolution/issues/events{/number}","events_url":"https://api.github.com/repos/theboxer/revolution/events","assignees_url":"https://api.github.com/repos/theboxer/revolution/assignees{/user}","branches_url":"https://api.github.com/repos/theboxer/revolution/branches{/branch}","tags_url":"https://api.github.com/repos/theboxer/revolution/tags","blobs_url":"https://api.github.com/repos/theboxer/revolution/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theboxer/revolution/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theboxer/revolution/git/refs{/sha}","trees_url":"https://api.github.com/repos/theboxer/revolution/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theboxer/revolution/statuses/{sha}","languages_url":"https://api.github.com/repos/theboxer/revolution/languages","stargazers_url":"https://api.github.com/repos/theboxer/revolution/stargazers","contributors_url":"https://api.github.com/repos/theboxer/revolution/contributors","subscribers_url":"https://api.github.com/repos/theboxer/revolution/subscribers","subscription_url":"https://api.github.com/repos/theboxer/revolution/subscription","commits_url":"https://api.github.com/repos/theboxer/revolution/commits{/sha}","git_commits_url":"https://api.github.com/repos/theboxer/revolution/git/commits{/sha}","comments_url":"https://api.github.com/repos/theboxer/revolution/comments{/number}","issue_comment_url":"https://api.github.com/repos/theboxer/revolution/issues/comments{/number}","contents_url":"https://api.github.com/repos/theboxer/revolution/contents/{+path}","compare_url":"https://api.github.com/repos/theboxer/revolution/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theboxer/revolution/merges","archive_url":"https://api.github.com/repos/theboxer/revolution/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theboxer/revolution/downloads","issues_url":"https://api.github.com/repos/theboxer/revolution/issues{/number}","pulls_url":"https://api.github.com/repos/theboxer/revolution/pulls{/number}","milestones_url":"https://api.github.com/repos/theboxer/revolution/milestones{/number}","notifications_url":"https://api.github.com/repos/theboxer/revolution/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theboxer/revolution/labels{/name}","releases_url":"https://api.github.com/repos/theboxer/revolution/releases{/id}","created_at":"2013-04-11T11:29:14Z","updated_at":"2014-07-01T15:26:35Z","pushed_at":"2015-09-01T14:14:40Z","git_url":"git://github.com/theboxer/revolution.git","ssh_url":"git@github.com:theboxer/revolution.git","clone_url":"https://github.com/theboxer/revolution.git","svn_url":"https://github.com/theboxer/revolution","homepage":"http://rtfm.modx.com/display/revolution20","size":42549,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":0,"default_branch":"develop"}},"base":{"label":"modxcms:2.4.x","ref":"2.4.x","sha":"330020a20f81d1614925c370fd407d85fef6abd1","user":{"login":"modxcms","id":232723,"avatar_url":"https://avatars.githubusercontent.com/u/232723?v=3","gravatar_id":"","url":"https://api.github.com/users/modxcms","html_url":"https://github.com/modxcms","followers_url":"https://api.github.com/users/modxcms/followers","following_url":"https://api.github.com/users/modxcms/following{/other_user}","gists_url":"https://api.github.com/users/modxcms/gists{/gist_id}","starred_url":"https://api.github.com/users/modxcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modxcms/subscriptions","organizations_url":"https://api.github.com/users/modxcms/orgs","repos_url":"https://api.github.com/users/modxcms/repos","events_url":"https://api.github.com/users/modxcms/events{/privacy}","received_events_url":"https://api.github.com/users/modxcms/received_events","type":"Organization","site_admin":false},"repo":{"id":806201,"name":"revolution","full_name":"modxcms/revolution","owner":{"login":"modxcms","id":232723,"avatar_url":"https://avatars.githubusercontent.com/u/232723?v=3","gravatar_id":"","url":"https://api.github.com/users/modxcms","html_url":"https://github.com/modxcms","followers_url":"https://api.github.com/users/modxcms/followers","following_url":"https://api.github.com/users/modxcms/following{/other_user}","gists_url":"https://api.github.com/users/modxcms/gists{/gist_id}","starred_url":"https://api.github.com/users/modxcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modxcms/subscriptions","organizations_url":"https://api.github.com/users/modxcms/orgs","repos_url":"https://api.github.com/users/modxcms/repos","events_url":"https://api.github.com/users/modxcms/events{/privacy}","received_events_url":"https://api.github.com/users/modxcms/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/modxcms/revolution","description":"MODX Revolution - Content Application Platform","fork":false,"url":"https://api.github.com/repos/modxcms/revolution","forks_url":"https://api.github.com/repos/modxcms/revolution/forks","keys_url":"https://api.github.com/repos/modxcms/revolution/keys{/key_id}","collaborators_url":"https://api.github.com/repos/modxcms/revolution/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/modxcms/revolution/teams","hooks_url":"https://api.github.com/repos/modxcms/revolution/hooks","issue_events_url":"https://api.github.com/repos/modxcms/revolution/issues/events{/number}","events_url":"https://api.github.com/repos/modxcms/revolution/events","assignees_url":"https://api.github.com/repos/modxcms/revolution/assignees{/user}","branches_url":"https://api.github.com/repos/modxcms/revolution/branches{/branch}","tags_url":"https://api.github.com/repos/modxcms/revolution/tags","blobs_url":"https://api.github.com/repos/modxcms/revolution/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/modxcms/revolution/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/modxcms/revolution/git/refs{/sha}","trees_url":"https://api.github.com/repos/modxcms/revolution/git/trees{/sha}","statuses_url":"https://api.github.com/repos/modxcms/revolution/statuses/{sha}","languages_url":"https://api.github.com/repos/modxcms/revolution/languages","stargazers_url":"https://api.github.com/repos/modxcms/revolution/stargazers","contributors_url":"https://api.github.com/repos/modxcms/revolution/contributors","subscribers_url":"https://api.github.com/repos/modxcms/revolution/subscribers","subscription_url":"https://api.github.com/repos/modxcms/revolution/subscription","commits_url":"https://api.github.com/repos/modxcms/revolution/commits{/sha}","git_commits_url":"https://api.github.com/repos/modxcms/revolution/git/commits{/sha}","comments_url":"https://api.github.com/repos/modxcms/revolution/comments{/number}","issue_comment_url":"https://api.github.com/repos/modxcms/revolution/issues/comments{/number}","contents_url":"https://api.github.com/repos/modxcms/revolution/contents/{+path}","compare_url":"https://api.github.com/repos/modxcms/revolution/compare/{base}...{head}","merges_url":"https://api.github.com/repos/modxcms/revolution/merges","archive_url":"https://api.github.com/repos/modxcms/revolution/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/modxcms/revolution/downloads","issues_url":"https://api.github.com/repos/modxcms/revolution/issues{/number}","pulls_url":"https://api.github.com/repos/modxcms/revolution/pulls{/number}","milestones_url":"https://api.github.com/repos/modxcms/revolution/milestones{/number}","notifications_url":"https://api.github.com/repos/modxcms/revolution/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/modxcms/revolution/labels{/name}","releases_url":"https://api.github.com/repos/modxcms/revolution/releases{/id}","created_at":"2010-07-29T21:03:57Z","updated_at":"2015-09-01T11:42:33Z","pushed_at":"2015-09-01T13:42:11Z","git_url":"git://github.com/modxcms/revolution.git","ssh_url":"git@github.com:modxcms/revolution.git","clone_url":"https://github.com/modxcms/revolution.git","svn_url":"https://github.com/modxcms/revolution","homepage":"http://rtfm.modx.com/revolution/2.x/","size":81280,"stargazers_count":695,"watchers_count":695,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":357,"mirror_url":null,"open_issues_count":915,"forks":357,"open_issues":915,"watchers":695,"default_branch":"2.x"}},"_links":{"self":{"href":"https://api.github.com/repos/modxcms/revolution/pulls/12623"},"html":{"href":"https://github.com/modxcms/revolution/pull/12623"},"issue":{"href":"https://api.github.com/repos/modxcms/revolution/issues/12623"},"comments":{"href":"https://api.github.com/repos/modxcms/revolution/issues/12623/comments"},"review_comments":{"href":"https://api.github.com/repos/modxcms/revolution/pulls/12623/comments"},"review_comment":{"href":"https://api.github.com/repos/modxcms/revolution/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/modxcms/revolution/pulls/12623/commits"},"statuses":{"href":"https://api.github.com/repos/modxcms/revolution/statuses/050170720e9e1de61ed19b864519a3d525493495"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":9,"deletions":2,"changed_files":1}}