{"action":"created","issue":{"url":"https://api.github.com/repos/ceph/ceph/issues/5395","labels_url":"https://api.github.com/repos/ceph/ceph/issues/5395/labels{/name}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/5395/comments","events_url":"https://api.github.com/repos/ceph/ceph/issues/5395/events","html_url":"https://github.com/ceph/ceph/pull/5395","id":97888097,"number":5395,"title":"common/syncfs: fall back to sync(2) if syncfs(2) not available","user":{"login":"tchaikov","id":59071,"avatar_url":"https://avatars.githubusercontent.com/u/59071?v=3","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ceph/ceph/labels/bug%20fix","name":"bug fix","color":"e11d21"},{"url":"https://api.github.com/repos/ceph/ceph/labels/common","name":"common","color":"006b75"},{"url":"https://api.github.com/repos/ceph/ceph/labels/needs-qa","name":"needs-qa","color":"fad8c7"}],"state":"open","locked":false,"assignee":{"login":"dachary","id":433594,"avatar_url":"https://avatars.githubusercontent.com/u/433594?v=3","gravatar_id":"","url":"https://api.github.com/users/dachary","html_url":"https://github.com/dachary","followers_url":"https://api.github.com/users/dachary/followers","following_url":"https://api.github.com/users/dachary/following{/other_user}","gists_url":"https://api.github.com/users/dachary/gists{/gist_id}","starred_url":"https://api.github.com/users/dachary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dachary/subscriptions","organizations_url":"https://api.github.com/users/dachary/orgs","repos_url":"https://api.github.com/users/dachary/repos","events_url":"https://api.github.com/users/dachary/events{/privacy}","received_events_url":"https://api.github.com/users/dachary/received_events","type":"User","site_admin":false},"milestone":null,"comments":6,"created_at":"2015-07-29T08:46:33Z","updated_at":"2015-07-30T17:04:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/5395","html_url":"https://github.com/ceph/ceph/pull/5395","diff_url":"https://github.com/ceph/ceph/pull/5395.diff","patch_url":"https://github.com/ceph/ceph/pull/5395.patch"},"body":"Fixes: #12512, http://tracker.ceph.com/issues/12512\r\nSigned-off-by: Kefu Chai <kchai@redhat.com>"},"comment":{"url":"https://api.github.com/repos/ceph/ceph/issues/comments/126402994","html_url":"https://github.com/ceph/ceph/pull/5395#issuecomment-126402994","issue_url":"https://api.github.com/repos/ceph/ceph/issues/5395","id":126402994,"user":{"login":"tchaikov","id":59071,"avatar_url":"https://avatars.githubusercontent.com/u/59071?v=3","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"created_at":"2015-07-30T17:04:55Z","updated_at":"2015-07-30T17:04:55Z","body":"> I'm surprised we weren't doing it before?\r\n\r\n@liewegas we do test for this feature in `GenericFileStoreBackend::detect_features()`, but just prints the test result with ` dout(0)` without keeping it around. when `GenericFileStoreBackend::syncfs()` is called, we simply trust the macro defined in the building environment.\r\n\r\n@dachary  sorry, i forgot to put the test result here:\r\n\r\nbefore this change\r\n---\r\nhttp://149.202.175.39:8081/ubuntu-2015-07-29_04:25:24-rados-master---basic-openstack/5/\r\n\r\n\r\nafter this change\r\n---\r\nhttp://149.202.175.39:8081/ubuntu-2015-07-30_02:52:03-rados-wip-12512---basic-openstack/58/"}}