{"action":"created","issue":{"url":"https://api.github.com/repos/GitbookIO/nuts/issues/18","labels_url":"https://api.github.com/repos/GitbookIO/nuts/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/GitbookIO/nuts/issues/18/comments","events_url":"https://api.github.com/repos/GitbookIO/nuts/issues/18/events","html_url":"https://github.com/GitbookIO/nuts/issues/18","id":120066674,"number":18,"title":"Squirrel.Windows receives unexpected response from RELEASES request, throws Exception ","user":{"login":"rbkreisberg","id":773041,"avatar_url":"https://avatars.githubusercontent.com/u/773041?v=3","gravatar_id":"","url":"https://api.github.com/users/rbkreisberg","html_url":"https://github.com/rbkreisberg","followers_url":"https://api.github.com/users/rbkreisberg/followers","following_url":"https://api.github.com/users/rbkreisberg/following{/other_user}","gists_url":"https://api.github.com/users/rbkreisberg/gists{/gist_id}","starred_url":"https://api.github.com/users/rbkreisberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbkreisberg/subscriptions","organizations_url":"https://api.github.com/users/rbkreisberg/orgs","repos_url":"https://api.github.com/users/rbkreisberg/repos","events_url":"https://api.github.com/users/rbkreisberg/events{/privacy}","received_events_url":"https://api.github.com/users/rbkreisberg/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-12-03T00:27:35Z","updated_at":"2015-12-14T20:56:51Z","closed_at":"2015-12-14T20:56:51Z","body":"**edited**\r\n\r\nI think this line needs to be removed:\r\nhttps://github.com/GitbookIO/nuts/blob/master/lib/index.js#L214\r\n\r\nStarting with a update check in Squirrel Windows:\r\nhttps://github.com/Squirrel/Squirrel.Windows/blob/1ed86dbc6f4cf3adb7d111986b28203c5178a27e/src/Update/Program.cs#L240\r\n\r\nAs the response to a request to /update/:platform/:version, Squirrel.Windows expects to get a list of releases if the response has a success status code.  I believe that the 204 that nuts sends back qualifies as a \"Success Code\".\r\n\r\nhttps://github.com/Squirrel/Squirrel.Windows/blob/d6f83880ee6ebf068f1f2325c6f97255a237678c/src/Squirrel/UpdateManager.Factory.cs#L70\r\n\r\nSquirrel.Windows probably takes the empty result and has tags the release to apply as the latest known version ( as a fallback)\r\n\r\nhttps://github.com/Squirrel/Squirrel.Windows/blob/237cf945e492d1fcad678eb5522fe3565db4960e/src/Squirrel/UpdateInfo.cs#L78\r\n\r\nSquirrel then requests the RELEASES file for the latest known version:\r\nhttps://github.com/Squirrel/Squirrel.Windows/blob/d6f83880ee6ebf068f1f2325c6f97255a237678c/src/Squirrel/UpdateManager.CheckForUpdates.cs#L76\r\n\r\nand receives another 204 with no response body:\r\nhttps://github.com/GitbookIO/nuts/blob/master/lib/index.js#L214\r\n\r\nthe result is that Squirrel throws an Exception from the empty response:\r\nhttps://github.com/Squirrel/Squirrel.Windows/blob/d6f83880ee6ebf068f1f2325c6f97255a237678c/src/Squirrel/UpdateManager.CheckForUpdates.cs#L124\r\n"},"comment":{"url":"https://api.github.com/repos/GitbookIO/nuts/issues/comments/164556956","html_url":"https://github.com/GitbookIO/nuts/issues/18#issuecomment-164556956","issue_url":"https://api.github.com/repos/GitbookIO/nuts/issues/18","id":164556956,"user":{"login":"SamyPesse","id":845425,"avatar_url":"https://avatars.githubusercontent.com/u/845425?v=3","gravatar_id":"","url":"https://api.github.com/users/SamyPesse","html_url":"https://github.com/SamyPesse","followers_url":"https://api.github.com/users/SamyPesse/followers","following_url":"https://api.github.com/users/SamyPesse/following{/other_user}","gists_url":"https://api.github.com/users/SamyPesse/gists{/gist_id}","starred_url":"https://api.github.com/users/SamyPesse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamyPesse/subscriptions","organizations_url":"https://api.github.com/users/SamyPesse/orgs","repos_url":"https://api.github.com/users/SamyPesse/repos","events_url":"https://api.github.com/users/SamyPesse/events{/privacy}","received_events_url":"https://api.github.com/users/SamyPesse/received_events","type":"User","site_admin":false},"created_at":"2015-12-14T20:56:51Z","updated_at":"2015-12-14T20:56:51Z","body":"Fixed by #19"}}