{"action":"created","comment":{"url":"https://api.github.com/repos/nim-lang/Nim/pulls/comments/32963295","id":32963295,"diff_hunk":"@@ -1,7 +1,49 @@\n-The git stuff\n+The Git stuff\n =============\n \n-`Guide by github, scroll down a bit <https://guides.github.com/activities/contributing-to-open-source/>`_\n+General commit rules\n+--------------------\n+\n+1. All changes introduced by the commit (diff lines) must be related to the\n+   subject of the commit.\n+\n+   If you change some other unrelated to the subject parts of the file, because\n+   your editor reformatted automatically the code or whatever different reason,\n+   this should be excluded from the commit.\n+\n+   *Tip:* Never commit everything as is using ``git commit -a``, but review\n+   carefully your changes with ``git add -p``.\n+\n+2. Changes should not introduce any trailing whitespace.","path":"contributing.rst","position":19,"original_position":19,"commit_id":"b55ac9255fdb11dbf27221a181dda682fd287b7b","original_commit_id":"b55ac9255fdb11dbf27221a181dda682fd287b7b","user":{"login":"nanoant","id":103067,"avatar_url":"https://avatars.githubusercontent.com/u/103067?v=3","gravatar_id":"","url":"https://api.github.com/users/nanoant","html_url":"https://github.com/nanoant","followers_url":"https://api.github.com/users/nanoant/followers","following_url":"https://api.github.com/users/nanoant/following{/other_user}","gists_url":"https://api.github.com/users/nanoant/gists{/gist_id}","starred_url":"https://api.github.com/users/nanoant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nanoant/subscriptions","organizations_url":"https://api.github.com/users/nanoant/orgs","repos_url":"https://api.github.com/users/nanoant/repos","events_url":"https://api.github.com/users/nanoant/events{/privacy}","received_events_url":"https://api.github.com/users/nanoant/received_events","type":"User","site_admin":false},"body":"Git attributes AFAIK solve line-endings problem, but not trailing whitespace. We may advertise to trim it via some favorite editor settings.","created_at":"2015-06-22T17:57:03Z","updated_at":"2015-06-22T17:57:03Z","html_url":"https://github.com/nim-lang/Nim/pull/2966#discussion_r32963295","pull_request_url":"https://api.github.com/repos/nim-lang/Nim/pulls/2966","_links":{"self":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/comments/32963295"},"html":{"href":"https://github.com/nim-lang/Nim/pull/2966#discussion_r32963295"},"pull_request":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/2966"}}},"pull_request":{"url":"https://api.github.com/repos/nim-lang/Nim/pulls/2966","id":38182784,"html_url":"https://github.com/nim-lang/Nim/pull/2966","diff_url":"https://github.com/nim-lang/Nim/pull/2966.diff","patch_url":"https://github.com/nim-lang/Nim/pull/2966.patch","issue_url":"https://api.github.com/repos/nim-lang/Nim/issues/2966","number":2966,"state":"open","locked":false,"title":"Contributing: Introduce some general commit rules","user":{"login":"nanoant","id":103067,"avatar_url":"https://avatars.githubusercontent.com/u/103067?v=3","gravatar_id":"","url":"https://api.github.com/users/nanoant","html_url":"https://github.com/nanoant","followers_url":"https://api.github.com/users/nanoant/followers","following_url":"https://api.github.com/users/nanoant/following{/other_user}","gists_url":"https://api.github.com/users/nanoant/gists{/gist_id}","starred_url":"https://api.github.com/users/nanoant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nanoant/subscriptions","organizations_url":"https://api.github.com/users/nanoant/orgs","repos_url":"https://api.github.com/users/nanoant/repos","events_url":"https://api.github.com/users/nanoant/events{/privacy}","received_events_url":"https://api.github.com/users/nanoant/received_events","type":"User","site_admin":false},"body":"Due some latest changes that introduced some substantial noise in the project\r\nhistory I hereby propose some general commit rules that have proven to work in\r\nmany other projects.\r\n\r\nBoth contributors and maintainers (accepting PRs) are obliged to follow this\r\nrules, for sake of the Nim project and good collaboration.","created_at":"2015-06-21T11:18:33Z","updated_at":"2015-06-22T17:57:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e695623677d3b65785dbc51eecd07cf50c970a44","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nim-lang/Nim/pulls/2966/commits","review_comments_url":"https://api.github.com/repos/nim-lang/Nim/pulls/2966/comments","review_comment_url":"https://api.github.com/repos/nim-lang/Nim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nim-lang/Nim/issues/2966/comments","statuses_url":"https://api.github.com/repos/nim-lang/Nim/statuses/b55ac9255fdb11dbf27221a181dda682fd287b7b","head":{"label":"nanoant:patch/commit-rules","ref":"patch/commit-rules","sha":"b55ac9255fdb11dbf27221a181dda682fd287b7b","user":{"login":"nanoant","id":103067,"avatar_url":"https://avatars.githubusercontent.com/u/103067?v=3","gravatar_id":"","url":"https://api.github.com/users/nanoant","html_url":"https://github.com/nanoant","followers_url":"https://api.github.com/users/nanoant/followers","following_url":"https://api.github.com/users/nanoant/following{/other_user}","gists_url":"https://api.github.com/users/nanoant/gists{/gist_id}","starred_url":"https://api.github.com/users/nanoant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nanoant/subscriptions","organizations_url":"https://api.github.com/users/nanoant/orgs","repos_url":"https://api.github.com/users/nanoant/repos","events_url":"https://api.github.com/users/nanoant/events{/privacy}","received_events_url":"https://api.github.com/users/nanoant/received_events","type":"User","site_admin":false},"repo":{"id":33945864,"name":"Nim","full_name":"nanoant/Nim","owner":{"login":"nanoant","id":103067,"avatar_url":"https://avatars.githubusercontent.com/u/103067?v=3","gravatar_id":"","url":"https://api.github.com/users/nanoant","html_url":"https://github.com/nanoant","followers_url":"https://api.github.com/users/nanoant/followers","following_url":"https://api.github.com/users/nanoant/following{/other_user}","gists_url":"https://api.github.com/users/nanoant/gists{/gist_id}","starred_url":"https://api.github.com/users/nanoant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nanoant/subscriptions","organizations_url":"https://api.github.com/users/nanoant/orgs","repos_url":"https://api.github.com/users/nanoant/repos","events_url":"https://api.github.com/users/nanoant/events{/privacy}","received_events_url":"https://api.github.com/users/nanoant/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nanoant/Nim","description":"Nim (formerly known as \"Nimrod\") is a compiled, garbage-collected systems programming language which has an excellent productivity/performance ratio. Nim's design focuses on efficiency, expressiveness, elegance (in the order of priority).","fork":true,"url":"https://api.github.com/repos/nanoant/Nim","forks_url":"https://api.github.com/repos/nanoant/Nim/forks","keys_url":"https://api.github.com/repos/nanoant/Nim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nanoant/Nim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nanoant/Nim/teams","hooks_url":"https://api.github.com/repos/nanoant/Nim/hooks","issue_events_url":"https://api.github.com/repos/nanoant/Nim/issues/events{/number}","events_url":"https://api.github.com/repos/nanoant/Nim/events","assignees_url":"https://api.github.com/repos/nanoant/Nim/assignees{/user}","branches_url":"https://api.github.com/repos/nanoant/Nim/branches{/branch}","tags_url":"https://api.github.com/repos/nanoant/Nim/tags","blobs_url":"https://api.github.com/repos/nanoant/Nim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nanoant/Nim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nanoant/Nim/git/refs{/sha}","trees_url":"https://api.github.com/repos/nanoant/Nim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nanoant/Nim/statuses/{sha}","languages_url":"https://api.github.com/repos/nanoant/Nim/languages","stargazers_url":"https://api.github.com/repos/nanoant/Nim/stargazers","contributors_url":"https://api.github.com/repos/nanoant/Nim/contributors","subscribers_url":"https://api.github.com/repos/nanoant/Nim/subscribers","subscription_url":"https://api.github.com/repos/nanoant/Nim/subscription","commits_url":"https://api.github.com/repos/nanoant/Nim/commits{/sha}","git_commits_url":"https://api.github.com/repos/nanoant/Nim/git/commits{/sha}","comments_url":"https://api.github.com/repos/nanoant/Nim/comments{/number}","issue_comment_url":"https://api.github.com/repos/nanoant/Nim/issues/comments{/number}","contents_url":"https://api.github.com/repos/nanoant/Nim/contents/{+path}","compare_url":"https://api.github.com/repos/nanoant/Nim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nanoant/Nim/merges","archive_url":"https://api.github.com/repos/nanoant/Nim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nanoant/Nim/downloads","issues_url":"https://api.github.com/repos/nanoant/Nim/issues{/number}","pulls_url":"https://api.github.com/repos/nanoant/Nim/pulls{/number}","milestones_url":"https://api.github.com/repos/nanoant/Nim/milestones{/number}","notifications_url":"https://api.github.com/repos/nanoant/Nim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nanoant/Nim/labels{/name}","releases_url":"https://api.github.com/repos/nanoant/Nim/releases{/id}","created_at":"2015-04-14T17:16:04Z","updated_at":"2015-04-14T17:16:08Z","pushed_at":"2015-06-22T17:17:21Z","git_url":"git://github.com/nanoant/Nim.git","ssh_url":"git@github.com:nanoant/Nim.git","clone_url":"https://github.com/nanoant/Nim.git","svn_url":"https://github.com/nanoant/Nim","homepage":"http://nim-lang.org/","size":39111,"stargazers_count":0,"watchers_count":0,"language":"Nimrod","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"nim-lang:devel","ref":"devel","sha":"37677636bc919c4a8fab25fedbcf917dcf177d98","user":{"login":"nim-lang","id":603863,"avatar_url":"https://avatars.githubusercontent.com/u/603863?v=3","gravatar_id":"","url":"https://api.github.com/users/nim-lang","html_url":"https://github.com/nim-lang","followers_url":"https://api.github.com/users/nim-lang/followers","following_url":"https://api.github.com/users/nim-lang/following{/other_user}","gists_url":"https://api.github.com/users/nim-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/nim-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nim-lang/subscriptions","organizations_url":"https://api.github.com/users/nim-lang/orgs","repos_url":"https://api.github.com/users/nim-lang/repos","events_url":"https://api.github.com/users/nim-lang/events{/privacy}","received_events_url":"https://api.github.com/users/nim-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":842037,"name":"Nim","full_name":"nim-lang/Nim","owner":{"login":"nim-lang","id":603863,"avatar_url":"https://avatars.githubusercontent.com/u/603863?v=3","gravatar_id":"","url":"https://api.github.com/users/nim-lang","html_url":"https://github.com/nim-lang","followers_url":"https://api.github.com/users/nim-lang/followers","following_url":"https://api.github.com/users/nim-lang/following{/other_user}","gists_url":"https://api.github.com/users/nim-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/nim-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nim-lang/subscriptions","organizations_url":"https://api.github.com/users/nim-lang/orgs","repos_url":"https://api.github.com/users/nim-lang/repos","events_url":"https://api.github.com/users/nim-lang/events{/privacy}","received_events_url":"https://api.github.com/users/nim-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nim-lang/Nim","description":"Nim (formerly known as \"Nimrod\") is a compiled, garbage-collected systems programming language which has an excellent productivity/performance ratio. Nim's design focuses on efficiency, expressiveness, elegance (in the order of priority).","fork":false,"url":"https://api.github.com/repos/nim-lang/Nim","forks_url":"https://api.github.com/repos/nim-lang/Nim/forks","keys_url":"https://api.github.com/repos/nim-lang/Nim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nim-lang/Nim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nim-lang/Nim/teams","hooks_url":"https://api.github.com/repos/nim-lang/Nim/hooks","issue_events_url":"https://api.github.com/repos/nim-lang/Nim/issues/events{/number}","events_url":"https://api.github.com/repos/nim-lang/Nim/events","assignees_url":"https://api.github.com/repos/nim-lang/Nim/assignees{/user}","branches_url":"https://api.github.com/repos/nim-lang/Nim/branches{/branch}","tags_url":"https://api.github.com/repos/nim-lang/Nim/tags","blobs_url":"https://api.github.com/repos/nim-lang/Nim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nim-lang/Nim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nim-lang/Nim/git/refs{/sha}","trees_url":"https://api.github.com/repos/nim-lang/Nim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nim-lang/Nim/statuses/{sha}","languages_url":"https://api.github.com/repos/nim-lang/Nim/languages","stargazers_url":"https://api.github.com/repos/nim-lang/Nim/stargazers","contributors_url":"https://api.github.com/repos/nim-lang/Nim/contributors","subscribers_url":"https://api.github.com/repos/nim-lang/Nim/subscribers","subscription_url":"https://api.github.com/repos/nim-lang/Nim/subscription","commits_url":"https://api.github.com/repos/nim-lang/Nim/commits{/sha}","git_commits_url":"https://api.github.com/repos/nim-lang/Nim/git/commits{/sha}","comments_url":"https://api.github.com/repos/nim-lang/Nim/comments{/number}","issue_comment_url":"https://api.github.com/repos/nim-lang/Nim/issues/comments{/number}","contents_url":"https://api.github.com/repos/nim-lang/Nim/contents/{+path}","compare_url":"https://api.github.com/repos/nim-lang/Nim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nim-lang/Nim/merges","archive_url":"https://api.github.com/repos/nim-lang/Nim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nim-lang/Nim/downloads","issues_url":"https://api.github.com/repos/nim-lang/Nim/issues{/number}","pulls_url":"https://api.github.com/repos/nim-lang/Nim/pulls{/number}","milestones_url":"https://api.github.com/repos/nim-lang/Nim/milestones{/number}","notifications_url":"https://api.github.com/repos/nim-lang/Nim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nim-lang/Nim/labels{/name}","releases_url":"https://api.github.com/repos/nim-lang/Nim/releases{/id}","created_at":"2010-08-16T20:38:58Z","updated_at":"2015-06-22T16:06:05Z","pushed_at":"2015-06-22T17:17:22Z","git_url":"git://github.com/nim-lang/Nim.git","ssh_url":"git@github.com:nim-lang/Nim.git","clone_url":"https://github.com/nim-lang/Nim.git","svn_url":"https://github.com/nim-lang/Nim","homepage":"http://nim-lang.org/","size":352068,"stargazers_count":2142,"watchers_count":2142,"language":"Nimrod","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":281,"mirror_url":null,"open_issues_count":554,"forks":281,"open_issues":554,"watchers":2142,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/2966"},"html":{"href":"https://github.com/nim-lang/Nim/pull/2966"},"issue":{"href":"https://api.github.com/repos/nim-lang/Nim/issues/2966"},"comments":{"href":"https://api.github.com/repos/nim-lang/Nim/issues/2966/comments"},"review_comments":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/2966/comments"},"review_comment":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/2966/commits"},"statuses":{"href":"https://api.github.com/repos/nim-lang/Nim/statuses/b55ac9255fdb11dbf27221a181dda682fd287b7b"}}}}