{"action":"closed","number":1898,"pull_request":{"url":"https://api.github.com/repos/enyojs/moonstone/pulls/1898","id":27004671,"html_url":"https://github.com/enyojs/moonstone/pull/1898","diff_url":"https://github.com/enyojs/moonstone/pull/1898.diff","patch_url":"https://github.com/enyojs/moonstone/pull/1898.patch","issue_url":"https://api.github.com/repos/enyojs/moonstone/issues/1898","number":1898,"state":"closed","locked":false,"title":"ENYO-763: Account for transformational rounding issues in scroller thumb.","user":{"login":"aarontam","id":463191,"avatar_url":"https://avatars.githubusercontent.com/u/463191?v=3","gravatar_id":"","url":"https://api.github.com/users/aarontam","html_url":"https://github.com/aarontam","followers_url":"https://api.github.com/users/aarontam/followers","following_url":"https://api.github.com/users/aarontam/following{/other_user}","gists_url":"https://api.github.com/users/aarontam/gists{/gist_id}","starred_url":"https://api.github.com/users/aarontam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aarontam/subscriptions","organizations_url":"https://api.github.com/users/aarontam/orgs","repos_url":"https://api.github.com/users/aarontam/repos","events_url":"https://api.github.com/users/aarontam/events{/privacy}","received_events_url":"https://api.github.com/users/aarontam/received_events","type":"User","site_admin":false},"body":"### Issue\r\nThe size of the scroller thumb can be incorrectly transformed when its non-transformed measurements consist of fractional pixels. This can cause the visual appearance of the scroller thumb to either appear too small or too large.\r\n\r\n### Fix\r\nThis is another case of the web engine utilizing the rounded value of an element's measurement when applying transforms. To circumvent this, we set the value of the to-be-transformed dimension (width or height) to its rounded value at render time, so that subsequent computations will align with the value that the transformation will ultimately utilize. Additionally, we preemptively scale several pixel values to their appropriate values via `moon.riScale`. Note that simply retrieving and utilizing the actual, fractional values in the `generateMatrix` function (using `getBoundingClientRect` instead of `offsetHeight` and `offsetWidth`) to generate the transformation matrix is not sufficient as the rounded value will be utilized when the transformation is applied.\r\n\r\nEnyo-DCO-1.1-Signed-off-by: Aaron Tam <aaron.tam@lge.com>","created_at":"2015-01-08T03:00:37Z","updated_at":"2015-01-14T03:02:52Z","closed_at":"2015-01-14T03:02:52Z","merged_at":null,"merge_commit_sha":"dd49c9023000e2ed9fff21cf28d8196a1a672095","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/enyojs/moonstone/pulls/1898/commits","review_comments_url":"https://api.github.com/repos/enyojs/moonstone/pulls/1898/comments","review_comment_url":"https://api.github.com/repos/enyojs/moonstone/pulls/comments/{number}","comments_url":"https://api.github.com/repos/enyojs/moonstone/issues/1898/comments","statuses_url":"https://api.github.com/repos/enyojs/moonstone/statuses/a2f0441f489fda7fb38c96b395ca34ace48961d8","head":{"label":"enyojs:ENYO-763-aarontam","ref":"ENYO-763-aarontam","sha":"a2f0441f489fda7fb38c96b395ca34ace48961d8","user":{"login":"enyojs","id":1266337,"avatar_url":"https://avatars.githubusercontent.com/u/1266337?v=3","gravatar_id":"","url":"https://api.github.com/users/enyojs","html_url":"https://github.com/enyojs","followers_url":"https://api.github.com/users/enyojs/followers","following_url":"https://api.github.com/users/enyojs/following{/other_user}","gists_url":"https://api.github.com/users/enyojs/gists{/gist_id}","starred_url":"https://api.github.com/users/enyojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enyojs/subscriptions","organizations_url":"https://api.github.com/users/enyojs/orgs","repos_url":"https://api.github.com/users/enyojs/repos","events_url":"https://api.github.com/users/enyojs/events{/privacy}","received_events_url":"https://api.github.com/users/enyojs/received_events","type":"Organization","site_admin":false},"repo":{"id":7251076,"name":"moonstone","full_name":"enyojs/moonstone","owner":{"login":"enyojs","id":1266337,"avatar_url":"https://avatars.githubusercontent.com/u/1266337?v=3","gravatar_id":"","url":"https://api.github.com/users/enyojs","html_url":"https://github.com/enyojs","followers_url":"https://api.github.com/users/enyojs/followers","following_url":"https://api.github.com/users/enyojs/following{/other_user}","gists_url":"https://api.github.com/users/enyojs/gists{/gist_id}","starred_url":"https://api.github.com/users/enyojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enyojs/subscriptions","organizations_url":"https://api.github.com/users/enyojs/orgs","repos_url":"https://api.github.com/users/enyojs/repos","events_url":"https://api.github.com/users/enyojs/events{/privacy}","received_events_url":"https://api.github.com/users/enyojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enyojs/moonstone","description":"Moonstone UI library for TV user interfaces.","fork":false,"url":"https://api.github.com/repos/enyojs/moonstone","forks_url":"https://api.github.com/repos/enyojs/moonstone/forks","keys_url":"https://api.github.com/repos/enyojs/moonstone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enyojs/moonstone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enyojs/moonstone/teams","hooks_url":"https://api.github.com/repos/enyojs/moonstone/hooks","issue_events_url":"https://api.github.com/repos/enyojs/moonstone/issues/events{/number}","events_url":"https://api.github.com/repos/enyojs/moonstone/events","assignees_url":"https://api.github.com/repos/enyojs/moonstone/assignees{/user}","branches_url":"https://api.github.com/repos/enyojs/moonstone/branches{/branch}","tags_url":"https://api.github.com/repos/enyojs/moonstone/tags","blobs_url":"https://api.github.com/repos/enyojs/moonstone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enyojs/moonstone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enyojs/moonstone/git/refs{/sha}","trees_url":"https://api.github.com/repos/enyojs/moonstone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enyojs/moonstone/statuses/{sha}","languages_url":"https://api.github.com/repos/enyojs/moonstone/languages","stargazers_url":"https://api.github.com/repos/enyojs/moonstone/stargazers","contributors_url":"https://api.github.com/repos/enyojs/moonstone/contributors","subscribers_url":"https://api.github.com/repos/enyojs/moonstone/subscribers","subscription_url":"https://api.github.com/repos/enyojs/moonstone/subscription","commits_url":"https://api.github.com/repos/enyojs/moonstone/commits{/sha}","git_commits_url":"https://api.github.com/repos/enyojs/moonstone/git/commits{/sha}","comments_url":"https://api.github.com/repos/enyojs/moonstone/comments{/number}","issue_comment_url":"https://api.github.com/repos/enyojs/moonstone/issues/comments/{number}","contents_url":"https://api.github.com/repos/enyojs/moonstone/contents/{+path}","compare_url":"https://api.github.com/repos/enyojs/moonstone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enyojs/moonstone/merges","archive_url":"https://api.github.com/repos/enyojs/moonstone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enyojs/moonstone/downloads","issues_url":"https://api.github.com/repos/enyojs/moonstone/issues{/number}","pulls_url":"https://api.github.com/repos/enyojs/moonstone/pulls{/number}","milestones_url":"https://api.github.com/repos/enyojs/moonstone/milestones{/number}","notifications_url":"https://api.github.com/repos/enyojs/moonstone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enyojs/moonstone/labels{/name}","releases_url":"https://api.github.com/repos/enyojs/moonstone/releases{/id}","created_at":"2012-12-20T02:41:05Z","updated_at":"2015-01-13T22:43:44Z","pushed_at":"2015-01-14T02:59:03Z","git_url":"git://github.com/enyojs/moonstone.git","ssh_url":"git@github.com:enyojs/moonstone.git","clone_url":"https://github.com/enyojs/moonstone.git","svn_url":"https://github.com/enyojs/moonstone","homepage":"","size":84600,"stargazers_count":29,"watchers_count":29,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":13,"forks":8,"open_issues":13,"watchers":29,"default_branch":"master"}},"base":{"label":"enyojs:2.5-gordon","ref":"2.5-gordon","sha":"59c9fcd4017b4993ba5b0cba21cfd05f18ae6908","user":{"login":"enyojs","id":1266337,"avatar_url":"https://avatars.githubusercontent.com/u/1266337?v=3","gravatar_id":"","url":"https://api.github.com/users/enyojs","html_url":"https://github.com/enyojs","followers_url":"https://api.github.com/users/enyojs/followers","following_url":"https://api.github.com/users/enyojs/following{/other_user}","gists_url":"https://api.github.com/users/enyojs/gists{/gist_id}","starred_url":"https://api.github.com/users/enyojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enyojs/subscriptions","organizations_url":"https://api.github.com/users/enyojs/orgs","repos_url":"https://api.github.com/users/enyojs/repos","events_url":"https://api.github.com/users/enyojs/events{/privacy}","received_events_url":"https://api.github.com/users/enyojs/received_events","type":"Organization","site_admin":false},"repo":{"id":7251076,"name":"moonstone","full_name":"enyojs/moonstone","owner":{"login":"enyojs","id":1266337,"avatar_url":"https://avatars.githubusercontent.com/u/1266337?v=3","gravatar_id":"","url":"https://api.github.com/users/enyojs","html_url":"https://github.com/enyojs","followers_url":"https://api.github.com/users/enyojs/followers","following_url":"https://api.github.com/users/enyojs/following{/other_user}","gists_url":"https://api.github.com/users/enyojs/gists{/gist_id}","starred_url":"https://api.github.com/users/enyojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enyojs/subscriptions","organizations_url":"https://api.github.com/users/enyojs/orgs","repos_url":"https://api.github.com/users/enyojs/repos","events_url":"https://api.github.com/users/enyojs/events{/privacy}","received_events_url":"https://api.github.com/users/enyojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enyojs/moonstone","description":"Moonstone UI library for TV user interfaces.","fork":false,"url":"https://api.github.com/repos/enyojs/moonstone","forks_url":"https://api.github.com/repos/enyojs/moonstone/forks","keys_url":"https://api.github.com/repos/enyojs/moonstone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enyojs/moonstone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enyojs/moonstone/teams","hooks_url":"https://api.github.com/repos/enyojs/moonstone/hooks","issue_events_url":"https://api.github.com/repos/enyojs/moonstone/issues/events{/number}","events_url":"https://api.github.com/repos/enyojs/moonstone/events","assignees_url":"https://api.github.com/repos/enyojs/moonstone/assignees{/user}","branches_url":"https://api.github.com/repos/enyojs/moonstone/branches{/branch}","tags_url":"https://api.github.com/repos/enyojs/moonstone/tags","blobs_url":"https://api.github.com/repos/enyojs/moonstone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enyojs/moonstone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enyojs/moonstone/git/refs{/sha}","trees_url":"https://api.github.com/repos/enyojs/moonstone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enyojs/moonstone/statuses/{sha}","languages_url":"https://api.github.com/repos/enyojs/moonstone/languages","stargazers_url":"https://api.github.com/repos/enyojs/moonstone/stargazers","contributors_url":"https://api.github.com/repos/enyojs/moonstone/contributors","subscribers_url":"https://api.github.com/repos/enyojs/moonstone/subscribers","subscription_url":"https://api.github.com/repos/enyojs/moonstone/subscription","commits_url":"https://api.github.com/repos/enyojs/moonstone/commits{/sha}","git_commits_url":"https://api.github.com/repos/enyojs/moonstone/git/commits{/sha}","comments_url":"https://api.github.com/repos/enyojs/moonstone/comments{/number}","issue_comment_url":"https://api.github.com/repos/enyojs/moonstone/issues/comments/{number}","contents_url":"https://api.github.com/repos/enyojs/moonstone/contents/{+path}","compare_url":"https://api.github.com/repos/enyojs/moonstone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enyojs/moonstone/merges","archive_url":"https://api.github.com/repos/enyojs/moonstone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enyojs/moonstone/downloads","issues_url":"https://api.github.com/repos/enyojs/moonstone/issues{/number}","pulls_url":"https://api.github.com/repos/enyojs/moonstone/pulls{/number}","milestones_url":"https://api.github.com/repos/enyojs/moonstone/milestones{/number}","notifications_url":"https://api.github.com/repos/enyojs/moonstone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enyojs/moonstone/labels{/name}","releases_url":"https://api.github.com/repos/enyojs/moonstone/releases{/id}","created_at":"2012-12-20T02:41:05Z","updated_at":"2015-01-13T22:43:44Z","pushed_at":"2015-01-14T02:59:03Z","git_url":"git://github.com/enyojs/moonstone.git","ssh_url":"git@github.com:enyojs/moonstone.git","clone_url":"https://github.com/enyojs/moonstone.git","svn_url":"https://github.com/enyojs/moonstone","homepage":"","size":84600,"stargazers_count":29,"watchers_count":29,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":13,"forks":8,"open_issues":13,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/enyojs/moonstone/pulls/1898"},"html":{"href":"https://github.com/enyojs/moonstone/pull/1898"},"issue":{"href":"https://api.github.com/repos/enyojs/moonstone/issues/1898"},"comments":{"href":"https://api.github.com/repos/enyojs/moonstone/issues/1898/comments"},"review_comments":{"href":"https://api.github.com/repos/enyojs/moonstone/pulls/1898/comments"},"review_comment":{"href":"https://api.github.com/repos/enyojs/moonstone/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/enyojs/moonstone/pulls/1898/commits"},"statuses":{"href":"https://api.github.com/repos/enyojs/moonstone/statuses/a2f0441f489fda7fb38c96b395ca34ace48961d8"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":2,"commits":2,"additions":19,"deletions":0,"changed_files":1}}