{"action":"created","comment":{"url":"https://api.github.com/repos/spree/spree/pulls/comments/24396494","id":24396494,"diff_hunk":"@@ -49,6 +49,8 @@ $(document).ready(function() {\n               $('#order_bill_address_attributes_state_id').select2(\"val\", billAddress.state_id);\n             });\n           });\n+\n+          $(\".js-change-customer-bill-address-alert\").show();","path":"backend/app/assets/javascripts/spree/backend/checkouts/edit.js","position":5,"original_position":5,"commit_id":"b25b4492e8d87a03838fea2387d9592d0ced0dcd","original_commit_id":"b25b4492e8d87a03838fea2387d9592d0ced0dcd","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Mixed double and single quotes.","created_at":"2015-02-10T08:47:26Z","updated_at":"2015-02-10T08:47:26Z","html_url":"https://github.com/spree/spree/pull/6001#discussion_r24396494","pull_request_url":"https://api.github.com/repos/spree/spree/pulls/6001","_links":{"self":{"href":"https://api.github.com/repos/spree/spree/pulls/comments/24396494"},"html":{"href":"https://github.com/spree/spree/pull/6001#discussion_r24396494"},"pull_request":{"href":"https://api.github.com/repos/spree/spree/pulls/6001"}}},"pull_request":{"url":"https://api.github.com/repos/spree/spree/pulls/6001","id":28626522,"html_url":"https://github.com/spree/spree/pull/6001","diff_url":"https://github.com/spree/spree/pull/6001.diff","patch_url":"https://github.com/spree/spree/pull/6001.patch","issue_url":"https://api.github.com/repos/spree/spree/issues/6001","number":6001,"state":"open","locked":false,"title":"Attach address to shipment","user":{"login":"reinaris","id":106335,"avatar_url":"https://avatars.githubusercontent.com/u/106335?v=3","gravatar_id":"","url":"https://api.github.com/users/reinaris","html_url":"https://github.com/reinaris","followers_url":"https://api.github.com/users/reinaris/followers","following_url":"https://api.github.com/users/reinaris/following{/other_user}","gists_url":"https://api.github.com/users/reinaris/gists{/gist_id}","starred_url":"https://api.github.com/users/reinaris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reinaris/subscriptions","organizations_url":"https://api.github.com/users/reinaris/orgs","repos_url":"https://api.github.com/users/reinaris/repos","events_url":"https://api.github.com/users/reinaris/events{/privacy}","received_events_url":"https://api.github.com/users/reinaris/received_events","type":"User","site_admin":false},"body":"Currently a shipment address is stored on the order.\r\nI'm working on this feature where you can change the address per shipment.\r\n\r\nThe address is still stored on the order by default, but now you can supply a new address to a single shipment. Very useful if you have multiple shipments.\r\n\r\nThe best way to explain is with screenshots:\r\n\r\n## Change address feature on the order/shipment page\r\n![screen_shot_2015-02-04_at_09_54_34](https://cloud.githubusercontent.com/assets/106335/6038408/addcca0a-ac54-11e4-8648-7c0a78541c14.png)\r\n\r\n## Supply a new address modal\r\n![screen_shot_2015-02-04_at_09_55_23](https://cloud.githubusercontent.com/assets/106335/6038412/b1da9524-ac54-11e4-9edf-0e9052594aec.png)\r\n\r\n## A different address for each shipment\r\n![screen_shot_2015-02-04_at_09_55_50](https://cloud.githubusercontent.com/assets/106335/6038419/c3adf1d8-ac54-11e4-9a2b-6617c6da5cad.png)\r\n\r\nIt still needs:\r\n1) Specs\r\n\r\nWhile working on this feature a couple of things came up to discuss:\r\n1) Why not store the address to a shipment by default\r\n2) In this version (0.1) I only made it possible to add a new address to a shipment. But it should be nicer to also be able to change the current address. I din't took this approach because it is not clear that you're editing the order address (if you didn't created a new address for a shipment first).\r\n3) In general I think we need to think about the order.ship_address comparing to saving the address to a shipment.\r\n\r\nI think even this current PR is very usable, but it needs some discussion for the future.\r\n\r\nLet me know what you think about this!","created_at":"2015-02-04T10:13:21Z","updated_at":"2015-02-10T08:47:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a78ea25ed1263528e133832a8921849421b556c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spree/spree/pulls/6001/commits","review_comments_url":"https://api.github.com/repos/spree/spree/pulls/6001/comments","review_comment_url":"https://api.github.com/repos/spree/spree/pulls/comments/{number}","comments_url":"https://api.github.com/repos/spree/spree/issues/6001/comments","statuses_url":"https://api.github.com/repos/spree/spree/statuses/b25b4492e8d87a03838fea2387d9592d0ced0dcd","head":{"label":"reinaris:attach-address-to-shipment","ref":"attach-address-to-shipment","sha":"b25b4492e8d87a03838fea2387d9592d0ced0dcd","user":{"login":"reinaris","id":106335,"avatar_url":"https://avatars.githubusercontent.com/u/106335?v=3","gravatar_id":"","url":"https://api.github.com/users/reinaris","html_url":"https://github.com/reinaris","followers_url":"https://api.github.com/users/reinaris/followers","following_url":"https://api.github.com/users/reinaris/following{/other_user}","gists_url":"https://api.github.com/users/reinaris/gists{/gist_id}","starred_url":"https://api.github.com/users/reinaris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reinaris/subscriptions","organizations_url":"https://api.github.com/users/reinaris/orgs","repos_url":"https://api.github.com/users/reinaris/repos","events_url":"https://api.github.com/users/reinaris/events{/privacy}","received_events_url":"https://api.github.com/users/reinaris/received_events","type":"User","site_admin":false},"repo":{"id":28029807,"name":"spree","full_name":"reinaris/spree","owner":{"login":"reinaris","id":106335,"avatar_url":"https://avatars.githubusercontent.com/u/106335?v=3","gravatar_id":"","url":"https://api.github.com/users/reinaris","html_url":"https://github.com/reinaris","followers_url":"https://api.github.com/users/reinaris/followers","following_url":"https://api.github.com/users/reinaris/following{/other_user}","gists_url":"https://api.github.com/users/reinaris/gists{/gist_id}","starred_url":"https://api.github.com/users/reinaris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reinaris/subscriptions","organizations_url":"https://api.github.com/users/reinaris/orgs","repos_url":"https://api.github.com/users/reinaris/repos","events_url":"https://api.github.com/users/reinaris/events{/privacy}","received_events_url":"https://api.github.com/users/reinaris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/reinaris/spree","description":"Spree is a complete open source e-commerce solution for Ruby on Rails.","fork":true,"url":"https://api.github.com/repos/reinaris/spree","forks_url":"https://api.github.com/repos/reinaris/spree/forks","keys_url":"https://api.github.com/repos/reinaris/spree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reinaris/spree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reinaris/spree/teams","hooks_url":"https://api.github.com/repos/reinaris/spree/hooks","issue_events_url":"https://api.github.com/repos/reinaris/spree/issues/events{/number}","events_url":"https://api.github.com/repos/reinaris/spree/events","assignees_url":"https://api.github.com/repos/reinaris/spree/assignees{/user}","branches_url":"https://api.github.com/repos/reinaris/spree/branches{/branch}","tags_url":"https://api.github.com/repos/reinaris/spree/tags","blobs_url":"https://api.github.com/repos/reinaris/spree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reinaris/spree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reinaris/spree/git/refs{/sha}","trees_url":"https://api.github.com/repos/reinaris/spree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reinaris/spree/statuses/{sha}","languages_url":"https://api.github.com/repos/reinaris/spree/languages","stargazers_url":"https://api.github.com/repos/reinaris/spree/stargazers","contributors_url":"https://api.github.com/repos/reinaris/spree/contributors","subscribers_url":"https://api.github.com/repos/reinaris/spree/subscribers","subscription_url":"https://api.github.com/repos/reinaris/spree/subscription","commits_url":"https://api.github.com/repos/reinaris/spree/commits{/sha}","git_commits_url":"https://api.github.com/repos/reinaris/spree/git/commits{/sha}","comments_url":"https://api.github.com/repos/reinaris/spree/comments{/number}","issue_comment_url":"https://api.github.com/repos/reinaris/spree/issues/comments/{number}","contents_url":"https://api.github.com/repos/reinaris/spree/contents/{+path}","compare_url":"https://api.github.com/repos/reinaris/spree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reinaris/spree/merges","archive_url":"https://api.github.com/repos/reinaris/spree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reinaris/spree/downloads","issues_url":"https://api.github.com/repos/reinaris/spree/issues{/number}","pulls_url":"https://api.github.com/repos/reinaris/spree/pulls{/number}","milestones_url":"https://api.github.com/repos/reinaris/spree/milestones{/number}","notifications_url":"https://api.github.com/repos/reinaris/spree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reinaris/spree/labels{/name}","releases_url":"https://api.github.com/repos/reinaris/spree/releases{/id}","created_at":"2014-12-15T09:34:12Z","updated_at":"2015-02-10T08:47:19Z","pushed_at":"2015-02-10T08:47:18Z","git_url":"git://github.com/reinaris/spree.git","ssh_url":"git@github.com:reinaris/spree.git","clone_url":"https://github.com/reinaris/spree.git","svn_url":"https://github.com/reinaris/spree","homepage":"http://spreecommerce.com","size":72476,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spree:master","ref":"master","sha":"1e9fdecde4a62f2b6eb775d37c28c0a7fef2ae47","user":{"login":"spree","id":56702,"avatar_url":"https://avatars.githubusercontent.com/u/56702?v=3","gravatar_id":"","url":"https://api.github.com/users/spree","html_url":"https://github.com/spree","followers_url":"https://api.github.com/users/spree/followers","following_url":"https://api.github.com/users/spree/following{/other_user}","gists_url":"https://api.github.com/users/spree/gists{/gist_id}","starred_url":"https://api.github.com/users/spree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spree/subscriptions","organizations_url":"https://api.github.com/users/spree/orgs","repos_url":"https://api.github.com/users/spree/repos","events_url":"https://api.github.com/users/spree/events{/privacy}","received_events_url":"https://api.github.com/users/spree/received_events","type":"Organization","site_admin":false},"repo":{"id":3314,"name":"spree","full_name":"spree/spree","owner":{"login":"spree","id":56702,"avatar_url":"https://avatars.githubusercontent.com/u/56702?v=3","gravatar_id":"","url":"https://api.github.com/users/spree","html_url":"https://github.com/spree","followers_url":"https://api.github.com/users/spree/followers","following_url":"https://api.github.com/users/spree/following{/other_user}","gists_url":"https://api.github.com/users/spree/gists{/gist_id}","starred_url":"https://api.github.com/users/spree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spree/subscriptions","organizations_url":"https://api.github.com/users/spree/orgs","repos_url":"https://api.github.com/users/spree/repos","events_url":"https://api.github.com/users/spree/events{/privacy}","received_events_url":"https://api.github.com/users/spree/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spree/spree","description":"Spree is a complete open source e-commerce solution for Ruby on Rails.","fork":false,"url":"https://api.github.com/repos/spree/spree","forks_url":"https://api.github.com/repos/spree/spree/forks","keys_url":"https://api.github.com/repos/spree/spree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spree/spree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spree/spree/teams","hooks_url":"https://api.github.com/repos/spree/spree/hooks","issue_events_url":"https://api.github.com/repos/spree/spree/issues/events{/number}","events_url":"https://api.github.com/repos/spree/spree/events","assignees_url":"https://api.github.com/repos/spree/spree/assignees{/user}","branches_url":"https://api.github.com/repos/spree/spree/branches{/branch}","tags_url":"https://api.github.com/repos/spree/spree/tags","blobs_url":"https://api.github.com/repos/spree/spree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spree/spree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spree/spree/git/refs{/sha}","trees_url":"https://api.github.com/repos/spree/spree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spree/spree/statuses/{sha}","languages_url":"https://api.github.com/repos/spree/spree/languages","stargazers_url":"https://api.github.com/repos/spree/spree/stargazers","contributors_url":"https://api.github.com/repos/spree/spree/contributors","subscribers_url":"https://api.github.com/repos/spree/spree/subscribers","subscription_url":"https://api.github.com/repos/spree/spree/subscription","commits_url":"https://api.github.com/repos/spree/spree/commits{/sha}","git_commits_url":"https://api.github.com/repos/spree/spree/git/commits{/sha}","comments_url":"https://api.github.com/repos/spree/spree/comments{/number}","issue_comment_url":"https://api.github.com/repos/spree/spree/issues/comments/{number}","contents_url":"https://api.github.com/repos/spree/spree/contents/{+path}","compare_url":"https://api.github.com/repos/spree/spree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spree/spree/merges","archive_url":"https://api.github.com/repos/spree/spree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spree/spree/downloads","issues_url":"https://api.github.com/repos/spree/spree/issues{/number}","pulls_url":"https://api.github.com/repos/spree/spree/pulls{/number}","milestones_url":"https://api.github.com/repos/spree/spree/milestones{/number}","notifications_url":"https://api.github.com/repos/spree/spree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spree/spree/labels{/name}","releases_url":"https://api.github.com/repos/spree/spree/releases{/id}","created_at":"2008-03-10T14:45:35Z","updated_at":"2015-02-10T05:56:07Z","pushed_at":"2015-02-10T05:56:07Z","git_url":"git://github.com/spree/spree.git","ssh_url":"git@github.com:spree/spree.git","clone_url":"https://github.com/spree/spree.git","svn_url":"https://github.com/spree/spree","homepage":"http://spreecommerce.com","size":129945,"stargazers_count":5929,"watchers_count":5929,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2769,"mirror_url":null,"open_issues_count":85,"forks":2769,"open_issues":85,"watchers":5929,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spree/spree/pulls/6001"},"html":{"href":"https://github.com/spree/spree/pull/6001"},"issue":{"href":"https://api.github.com/repos/spree/spree/issues/6001"},"comments":{"href":"https://api.github.com/repos/spree/spree/issues/6001/comments"},"review_comments":{"href":"https://api.github.com/repos/spree/spree/pulls/6001/comments"},"review_comment":{"href":"https://api.github.com/repos/spree/spree/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/spree/spree/pulls/6001/commits"},"statuses":{"href":"https://api.github.com/repos/spree/spree/statuses/b25b4492e8d87a03838fea2387d9592d0ced0dcd"}}}}