{"action":"created","comment":{"url":"https://api.github.com/repos/Theano/Theano/pulls/comments/23111719","id":23111719,"diff_hunk":"@@ -6,10 +6,8 @@\n import theano\n import theano.tensor as T\n \n-\n-\n def test_graph_opt_caching():\n-    opt_db_file = theano.config.compiledir+'/optimized_graphs.pkl'\n+    opt_db_file = theano.config.compiledir+'/*.pkl'\n     os.system('rm %s'%opt_db_file)","path":"theano/gof/tests/test_graph_opt_caching.py","position":15,"original_position":15,"commit_id":"5d3f3512e6ef94a6c04a7f174830e716a9c8080e","original_commit_id":"5d3f3512e6ef94a6c04a7f174830e716a9c8080e","user":{"login":"nouiz","id":180987,"avatar_url":"https://avatars.githubusercontent.com/u/180987?v=3","gravatar_id":"","url":"https://api.github.com/users/nouiz","html_url":"https://github.com/nouiz","followers_url":"https://api.github.com/users/nouiz/followers","following_url":"https://api.github.com/users/nouiz/following{/other_user}","gists_url":"https://api.github.com/users/nouiz/gists{/gist_id}","starred_url":"https://api.github.com/users/nouiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nouiz/subscriptions","organizations_url":"https://api.github.com/users/nouiz/orgs","repos_url":"https://api.github.com/users/nouiz/repos","events_url":"https://api.github.com/users/nouiz/events{/privacy}","received_events_url":"https://api.github.com/users/nouiz/received_events","type":"User","site_admin":false},"body":"We can't change the compiledir during the execution.\r\n\r\nOn Fri, Jan 16, 2015 at 10:56 AM, abergeron <notifications@github.com>\r\nwrote:\r\n\r\n> In theano/gof/tests/test_graph_opt_caching.py\r\n> <https://github.com/Theano/Theano/pull/2299#discussion-diff-23101020>:\r\n>\r\n> >  def test_graph_opt_caching():\r\n> > -    opt_db_file = theano.config.compiledir+'/optimized_graphs.pkl'\r\n> > +    opt_db_file = theano.config.compiledir+'/*.pkl'\r\n> >      os.system('rm %s'%opt_db_file)\r\n>\r\n> You should write setup() and teardown() methods that change the default\r\n> compiledir (perhaps to a subdir of the current one) and make sure to remove\r\n> it after. This way you can isolate the test from the rest of the run.\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub\r\n> <https://github.com/Theano/Theano/pull/2299/files#r23101020>.\r\n>","created_at":"2015-01-16T21:45:03Z","updated_at":"2015-01-16T21:45:03Z","html_url":"https://github.com/Theano/Theano/pull/2299#discussion_r23111719","pull_request_url":"https://api.github.com/repos/Theano/Theano/pulls/2299","_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments/23111719"},"html":{"href":"https://github.com/Theano/Theano/pull/2299#discussion_r23111719"},"pull_request":{"href":"https://api.github.com/repos/Theano/Theano/pulls/2299"}}},"pull_request":{"url":"https://api.github.com/repos/Theano/Theano/pulls/2299","id":25035747,"html_url":"https://github.com/Theano/Theano/pull/2299","diff_url":"https://github.com/Theano/Theano/pull/2299.diff","patch_url":"https://github.com/Theano/Theano/pull/2299.patch","issue_url":"https://api.github.com/repos/Theano/Theano/issues/2299","number":2299,"state":"open","locked":false,"title":"debug push for tests on graph cache db","user":{"login":"yaoli","id":1051367,"avatar_url":"https://avatars.githubusercontent.com/u/1051367?v=3","gravatar_id":"","url":"https://api.github.com/users/yaoli","html_url":"https://github.com/yaoli","followers_url":"https://api.github.com/users/yaoli/followers","following_url":"https://api.github.com/users/yaoli/following{/other_user}","gists_url":"https://api.github.com/users/yaoli/gists{/gist_id}","starred_url":"https://api.github.com/users/yaoli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaoli/subscriptions","organizations_url":"https://api.github.com/users/yaoli/orgs","repos_url":"https://api.github.com/users/yaoli/repos","events_url":"https://api.github.com/users/yaoli/events{/privacy}","received_events_url":"https://api.github.com/users/yaoli/received_events","type":"User","site_admin":false},"body":"added a timestamp to the cached opt graph db.\r\nTurn on the config.cache_optimizations to run a through test now.","created_at":"2014-11-25T19:58:37Z","updated_at":"2015-01-16T21:45:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ded7d7128c41d336a9a6f88dd031edd2e6bfb592","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Theano/Theano/pulls/2299/commits","review_comments_url":"https://api.github.com/repos/Theano/Theano/pulls/2299/comments","review_comment_url":"https://api.github.com/repos/Theano/Theano/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Theano/Theano/issues/2299/comments","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/5d3f3512e6ef94a6c04a7f174830e716a9c8080e","head":{"label":"yaoli:cache_opt","ref":"cache_opt","sha":"5d3f3512e6ef94a6c04a7f174830e716a9c8080e","user":{"login":"yaoli","id":1051367,"avatar_url":"https://avatars.githubusercontent.com/u/1051367?v=3","gravatar_id":"","url":"https://api.github.com/users/yaoli","html_url":"https://github.com/yaoli","followers_url":"https://api.github.com/users/yaoli/followers","following_url":"https://api.github.com/users/yaoli/following{/other_user}","gists_url":"https://api.github.com/users/yaoli/gists{/gist_id}","starred_url":"https://api.github.com/users/yaoli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaoli/subscriptions","organizations_url":"https://api.github.com/users/yaoli/orgs","repos_url":"https://api.github.com/users/yaoli/repos","events_url":"https://api.github.com/users/yaoli/events{/privacy}","received_events_url":"https://api.github.com/users/yaoli/received_events","type":"User","site_admin":false},"repo":{"id":2617809,"name":"Theano","full_name":"yaoli/Theano","owner":{"login":"yaoli","id":1051367,"avatar_url":"https://avatars.githubusercontent.com/u/1051367?v=3","gravatar_id":"","url":"https://api.github.com/users/yaoli","html_url":"https://github.com/yaoli","followers_url":"https://api.github.com/users/yaoli/followers","following_url":"https://api.github.com/users/yaoli/following{/other_user}","gists_url":"https://api.github.com/users/yaoli/gists{/gist_id}","starred_url":"https://api.github.com/users/yaoli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaoli/subscriptions","organizations_url":"https://api.github.com/users/yaoli/orgs","repos_url":"https://api.github.com/users/yaoli/repos","events_url":"https://api.github.com/users/yaoli/events{/privacy}","received_events_url":"https://api.github.com/users/yaoli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yaoli/Theano","description":"Optimizing GPU-meta-programming code generating array oriented optimizing math compiler in Python","fork":true,"url":"https://api.github.com/repos/yaoli/Theano","forks_url":"https://api.github.com/repos/yaoli/Theano/forks","keys_url":"https://api.github.com/repos/yaoli/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yaoli/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yaoli/Theano/teams","hooks_url":"https://api.github.com/repos/yaoli/Theano/hooks","issue_events_url":"https://api.github.com/repos/yaoli/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/yaoli/Theano/events","assignees_url":"https://api.github.com/repos/yaoli/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/yaoli/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/yaoli/Theano/tags","blobs_url":"https://api.github.com/repos/yaoli/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yaoli/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yaoli/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/yaoli/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yaoli/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/yaoli/Theano/languages","stargazers_url":"https://api.github.com/repos/yaoli/Theano/stargazers","contributors_url":"https://api.github.com/repos/yaoli/Theano/contributors","subscribers_url":"https://api.github.com/repos/yaoli/Theano/subscribers","subscription_url":"https://api.github.com/repos/yaoli/Theano/subscription","commits_url":"https://api.github.com/repos/yaoli/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/yaoli/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/yaoli/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/yaoli/Theano/issues/comments/{number}","contents_url":"https://api.github.com/repos/yaoli/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/yaoli/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yaoli/Theano/merges","archive_url":"https://api.github.com/repos/yaoli/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yaoli/Theano/downloads","issues_url":"https://api.github.com/repos/yaoli/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/yaoli/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/yaoli/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/yaoli/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yaoli/Theano/labels{/name}","releases_url":"https://api.github.com/repos/yaoli/Theano/releases{/id}","created_at":"2011-10-21T03:02:45Z","updated_at":"2014-06-10T01:04:33Z","pushed_at":"2014-12-17T23:08:40Z","git_url":"git://github.com/yaoli/Theano.git","ssh_url":"git@github.com:yaoli/Theano.git","clone_url":"https://github.com/yaoli/Theano.git","svn_url":"https://github.com/yaoli/Theano","homepage":"http://www.deeplearning.net/software/theano","size":23004,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"Theano:master","ref":"master","sha":"aef67878f7227249d4775cb1c9275debe8c1aab0","user":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"repo":{"id":2183193,"name":"Theano","full_name":"Theano/Theano","owner":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Theano/Theano","description":"Theano is a Python library that allows you to define, optimize, and evaluate mathematical expressions involving multi-dimensional arrays efficiently. It can use GPUs and perform efficient symbolic differentiation.","fork":false,"url":"https://api.github.com/repos/Theano/Theano","forks_url":"https://api.github.com/repos/Theano/Theano/forks","keys_url":"https://api.github.com/repos/Theano/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Theano/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Theano/Theano/teams","hooks_url":"https://api.github.com/repos/Theano/Theano/hooks","issue_events_url":"https://api.github.com/repos/Theano/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/Theano/Theano/events","assignees_url":"https://api.github.com/repos/Theano/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/Theano/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/Theano/Theano/tags","blobs_url":"https://api.github.com/repos/Theano/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Theano/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Theano/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/Theano/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/Theano/Theano/languages","stargazers_url":"https://api.github.com/repos/Theano/Theano/stargazers","contributors_url":"https://api.github.com/repos/Theano/Theano/contributors","subscribers_url":"https://api.github.com/repos/Theano/Theano/subscribers","subscription_url":"https://api.github.com/repos/Theano/Theano/subscription","commits_url":"https://api.github.com/repos/Theano/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/Theano/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/Theano/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/Theano/Theano/issues/comments/{number}","contents_url":"https://api.github.com/repos/Theano/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/Theano/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Theano/Theano/merges","archive_url":"https://api.github.com/repos/Theano/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Theano/Theano/downloads","issues_url":"https://api.github.com/repos/Theano/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/Theano/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/Theano/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/Theano/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Theano/Theano/labels{/name}","releases_url":"https://api.github.com/repos/Theano/Theano/releases{/id}","created_at":"2011-08-10T03:48:06Z","updated_at":"2015-01-16T14:48:33Z","pushed_at":"2015-01-16T14:48:33Z","git_url":"git://github.com/Theano/Theano.git","ssh_url":"git@github.com:Theano/Theano.git","clone_url":"https://github.com/Theano/Theano.git","svn_url":"https://github.com/Theano/Theano","homepage":"http://www.deeplearning.net/software/theano","size":35983,"stargazers_count":1067,"watchers_count":1067,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":395,"mirror_url":null,"open_issues_count":316,"forks":395,"open_issues":316,"watchers":1067,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/2299"},"html":{"href":"https://github.com/Theano/Theano/pull/2299"},"issue":{"href":"https://api.github.com/repos/Theano/Theano/issues/2299"},"comments":{"href":"https://api.github.com/repos/Theano/Theano/issues/2299/comments"},"review_comments":{"href":"https://api.github.com/repos/Theano/Theano/pulls/2299/comments"},"review_comment":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Theano/Theano/pulls/2299/commits"},"statuses":{"href":"https://api.github.com/repos/Theano/Theano/statuses/5d3f3512e6ef94a6c04a7f174830e716a9c8080e"}}}}