{"action":"created","issue":{"url":"https://api.github.com/repos/cantino/huginn/issues/832","labels_url":"https://api.github.com/repos/cantino/huginn/issues/832/labels{/name}","comments_url":"https://api.github.com/repos/cantino/huginn/issues/832/comments","events_url":"https://api.github.com/repos/cantino/huginn/issues/832/events","html_url":"https://github.com/cantino/huginn/issues/832","id":82145349,"number":832,"title":"Should validation of agent config go thru JSON Schema?","user":{"login":"spdustin","id":1342542,"avatar_url":"https://avatars.githubusercontent.com/u/1342542?v=3","gravatar_id":"","url":"https://api.github.com/users/spdustin","html_url":"https://github.com/spdustin","followers_url":"https://api.github.com/users/spdustin/followers","following_url":"https://api.github.com/users/spdustin/following{/other_user}","gists_url":"https://api.github.com/users/spdustin/gists{/gist_id}","starred_url":"https://api.github.com/users/spdustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spdustin/subscriptions","organizations_url":"https://api.github.com/users/spdustin/orgs","repos_url":"https://api.github.com/users/spdustin/repos","events_url":"https://api.github.com/users/spdustin/events{/privacy}","received_events_url":"https://api.github.com/users/spdustin/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2015-05-28T22:08:49Z","updated_at":"2015-09-01T20:57:32Z","closed_at":"2015-09-01T20:57:32Z","body":"I've been giving some thought to how Huginn currently checks that an agent's config is valid, and it seems like it's too fragile, and would require over-work to validate common scenarios (since there's no agreed-upon validation methodology). JSON Schema seems like a good fit to validate agent configuration, and may enable a GUI-based config for agents that supply a JSON Schema for their config options.\r\n\r\nThoughts?"},"comment":{"url":"https://api.github.com/repos/cantino/huginn/issues/comments/136859621","html_url":"https://github.com/cantino/huginn/issues/832#issuecomment-136859621","issue_url":"https://api.github.com/repos/cantino/huginn/issues/832","id":136859621,"user":{"login":"spdustin","id":1342542,"avatar_url":"https://avatars.githubusercontent.com/u/1342542?v=3","gravatar_id":"","url":"https://api.github.com/users/spdustin","html_url":"https://github.com/spdustin","followers_url":"https://api.github.com/users/spdustin/followers","following_url":"https://api.github.com/users/spdustin/following{/other_user}","gists_url":"https://api.github.com/users/spdustin/gists{/gist_id}","starred_url":"https://api.github.com/users/spdustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spdustin/subscriptions","organizations_url":"https://api.github.com/users/spdustin/orgs","repos_url":"https://api.github.com/users/spdustin/repos","events_url":"https://api.github.com/users/spdustin/events{/privacy}","received_events_url":"https://api.github.com/users/spdustin/received_events","type":"User","site_admin":false},"created_at":"2015-09-01T20:57:32Z","updated_at":"2015-09-01T20:57:32Z","body":"I've started a new branch locally (haven't pushed it) that will do all this. When it's ready for testing, you can let me know if you still don't think it's worth it. ;) JSONSchema is definitely growing as a standard, and I think it'd go well with the modularization of agents-as-gems to include a JSONSchema and a rake task to generate tests for an agent that includes a JSONSchema automatically. I've also played around with nicer-looking forms using that other project as a baseline. It's a big patch I'd be contributing, for sure, but I think there are big payoffs to doing it. :) I won't be upset if it doesn't get merged, I'm certainly going to use it here!\r\n\r\nI'll close this issue for now, and will open a PR when I have something to test out."}}