{"action":"created","comment":{"url":"https://api.github.com/repos/hunner/puppet-hiera/pulls/comments/25918536","id":25918536,"diff_hunk":"@@ -19,8 +19,17 @@\n     $datadir    = '/etc/puppetlabs/puppet/hieradata'\n     $owner      = 'pe-puppet'\n     $group      = 'pe-puppet'\n-    $provider   = 'pe_gem'\n     $confdir    = '/etc/puppetlabs/puppet'\n+    if $::puppetversion =~ /3.7/ {\n+      $provider = 'pe_puppetserver_gem'\n+      # 3.7 also needs /opt/puppet/bin/eyaml\n+      exec { 'install pe_gem':","path":"manifests/params.pp","position":9,"original_position":9,"commit_id":"89cd0c82d12a9b3c6d47d1ddbd08ce1c7c31ddd3","original_commit_id":"89cd0c82d12a9b3c6d47d1ddbd08ce1c7c31ddd3","user":{"login":"hunner","id":91972,"avatar_url":"https://avatars.githubusercontent.com/u/91972?v=3","gravatar_id":"","url":"https://api.github.com/users/hunner","html_url":"https://github.com/hunner","followers_url":"https://api.github.com/users/hunner/followers","following_url":"https://api.github.com/users/hunner/following{/other_user}","gists_url":"https://api.github.com/users/hunner/gists{/gist_id}","starred_url":"https://api.github.com/users/hunner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hunner/subscriptions","organizations_url":"https://api.github.com/users/hunner/orgs","repos_url":"https://api.github.com/users/hunner/repos","events_url":"https://api.github.com/users/hunner/events{/privacy}","received_events_url":"https://api.github.com/users/hunner/received_events","type":"User","site_admin":false},"body":"Besides, I still don't know what to do about the pe-puppetserver restart bit","created_at":"2015-03-06T01:11:45Z","updated_at":"2015-03-06T01:11:45Z","html_url":"https://github.com/hunner/puppet-hiera/pull/45#discussion_r25918536","pull_request_url":"https://api.github.com/repos/hunner/puppet-hiera/pulls/45","_links":{"self":{"href":"https://api.github.com/repos/hunner/puppet-hiera/pulls/comments/25918536"},"html":{"href":"https://github.com/hunner/puppet-hiera/pull/45#discussion_r25918536"},"pull_request":{"href":"https://api.github.com/repos/hunner/puppet-hiera/pulls/45"}}},"pull_request":{"url":"https://api.github.com/repos/hunner/puppet-hiera/pulls/45","id":26407871,"html_url":"https://github.com/hunner/puppet-hiera/pull/45","diff_url":"https://github.com/hunner/puppet-hiera/pull/45.diff","patch_url":"https://github.com/hunner/puppet-hiera/pull/45.patch","issue_url":"https://api.github.com/repos/hunner/puppet-hiera/issues/45","number":45,"state":"open","locked":false,"title":"Fix 37 prov","user":{"login":"terrimonster","id":1200550,"avatar_url":"https://avatars.githubusercontent.com/u/1200550?v=3","gravatar_id":"","url":"https://api.github.com/users/terrimonster","html_url":"https://github.com/terrimonster","followers_url":"https://api.github.com/users/terrimonster/followers","following_url":"https://api.github.com/users/terrimonster/following{/other_user}","gists_url":"https://api.github.com/users/terrimonster/gists{/gist_id}","starred_url":"https://api.github.com/users/terrimonster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terrimonster/subscriptions","organizations_url":"https://api.github.com/users/terrimonster/orgs","repos_url":"https://api.github.com/users/terrimonster/repos","events_url":"https://api.github.com/users/terrimonster/events{/privacy}","received_events_url":"https://api.github.com/users/terrimonster/received_events","type":"User","site_admin":false},"body":"This adds pe_puppetserver_gem to the provider for PE 3.7 in params, for hiera-eyaml installation. I do have a bit of a conundrum as a fresh install doesn't work until pe-puppetserver is restarted. BUT restarting pe-puppetserver in code could cause cascading failures for end users due to JVM startup time. Does anyone have thoughts on this? Should we just leave this out for now and just add documentation that JVM needs to be restarted? Or do we wait for things down the line that will fix this issue?","created_at":"2014-12-20T00:12:53Z","updated_at":"2015-03-06T01:11:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"073be8433701af539c55b30fa2ce20ae6e11b381","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hunner/puppet-hiera/pulls/45/commits","review_comments_url":"https://api.github.com/repos/hunner/puppet-hiera/pulls/45/comments","review_comment_url":"https://api.github.com/repos/hunner/puppet-hiera/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hunner/puppet-hiera/issues/45/comments","statuses_url":"https://api.github.com/repos/hunner/puppet-hiera/statuses/89cd0c82d12a9b3c6d47d1ddbd08ce1c7c31ddd3","head":{"label":"terrimonster:fix_37_prov","ref":"fix_37_prov","sha":"89cd0c82d12a9b3c6d47d1ddbd08ce1c7c31ddd3","user":{"login":"terrimonster","id":1200550,"avatar_url":"https://avatars.githubusercontent.com/u/1200550?v=3","gravatar_id":"","url":"https://api.github.com/users/terrimonster","html_url":"https://github.com/terrimonster","followers_url":"https://api.github.com/users/terrimonster/followers","following_url":"https://api.github.com/users/terrimonster/following{/other_user}","gists_url":"https://api.github.com/users/terrimonster/gists{/gist_id}","starred_url":"https://api.github.com/users/terrimonster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terrimonster/subscriptions","organizations_url":"https://api.github.com/users/terrimonster/orgs","repos_url":"https://api.github.com/users/terrimonster/repos","events_url":"https://api.github.com/users/terrimonster/events{/privacy}","received_events_url":"https://api.github.com/users/terrimonster/received_events","type":"User","site_admin":false},"repo":{"id":22219031,"name":"puppet-hiera","full_name":"terrimonster/puppet-hiera","owner":{"login":"terrimonster","id":1200550,"avatar_url":"https://avatars.githubusercontent.com/u/1200550?v=3","gravatar_id":"","url":"https://api.github.com/users/terrimonster","html_url":"https://github.com/terrimonster","followers_url":"https://api.github.com/users/terrimonster/followers","following_url":"https://api.github.com/users/terrimonster/following{/other_user}","gists_url":"https://api.github.com/users/terrimonster/gists{/gist_id}","starred_url":"https://api.github.com/users/terrimonster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terrimonster/subscriptions","organizations_url":"https://api.github.com/users/terrimonster/orgs","repos_url":"https://api.github.com/users/terrimonster/repos","events_url":"https://api.github.com/users/terrimonster/events{/privacy}","received_events_url":"https://api.github.com/users/terrimonster/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/terrimonster/puppet-hiera","description":"Hiera hierarchy module for templating `hiera.yaml`","fork":true,"url":"https://api.github.com/repos/terrimonster/puppet-hiera","forks_url":"https://api.github.com/repos/terrimonster/puppet-hiera/forks","keys_url":"https://api.github.com/repos/terrimonster/puppet-hiera/keys{/key_id}","collaborators_url":"https://api.github.com/repos/terrimonster/puppet-hiera/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/terrimonster/puppet-hiera/teams","hooks_url":"https://api.github.com/repos/terrimonster/puppet-hiera/hooks","issue_events_url":"https://api.github.com/repos/terrimonster/puppet-hiera/issues/events{/number}","events_url":"https://api.github.com/repos/terrimonster/puppet-hiera/events","assignees_url":"https://api.github.com/repos/terrimonster/puppet-hiera/assignees{/user}","branches_url":"https://api.github.com/repos/terrimonster/puppet-hiera/branches{/branch}","tags_url":"https://api.github.com/repos/terrimonster/puppet-hiera/tags","blobs_url":"https://api.github.com/repos/terrimonster/puppet-hiera/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/terrimonster/puppet-hiera/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/terrimonster/puppet-hiera/git/refs{/sha}","trees_url":"https://api.github.com/repos/terrimonster/puppet-hiera/git/trees{/sha}","statuses_url":"https://api.github.com/repos/terrimonster/puppet-hiera/statuses/{sha}","languages_url":"https://api.github.com/repos/terrimonster/puppet-hiera/languages","stargazers_url":"https://api.github.com/repos/terrimonster/puppet-hiera/stargazers","contributors_url":"https://api.github.com/repos/terrimonster/puppet-hiera/contributors","subscribers_url":"https://api.github.com/repos/terrimonster/puppet-hiera/subscribers","subscription_url":"https://api.github.com/repos/terrimonster/puppet-hiera/subscription","commits_url":"https://api.github.com/repos/terrimonster/puppet-hiera/commits{/sha}","git_commits_url":"https://api.github.com/repos/terrimonster/puppet-hiera/git/commits{/sha}","comments_url":"https://api.github.com/repos/terrimonster/puppet-hiera/comments{/number}","issue_comment_url":"https://api.github.com/repos/terrimonster/puppet-hiera/issues/comments{/number}","contents_url":"https://api.github.com/repos/terrimonster/puppet-hiera/contents/{+path}","compare_url":"https://api.github.com/repos/terrimonster/puppet-hiera/compare/{base}...{head}","merges_url":"https://api.github.com/repos/terrimonster/puppet-hiera/merges","archive_url":"https://api.github.com/repos/terrimonster/puppet-hiera/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/terrimonster/puppet-hiera/downloads","issues_url":"https://api.github.com/repos/terrimonster/puppet-hiera/issues{/number}","pulls_url":"https://api.github.com/repos/terrimonster/puppet-hiera/pulls{/number}","milestones_url":"https://api.github.com/repos/terrimonster/puppet-hiera/milestones{/number}","notifications_url":"https://api.github.com/repos/terrimonster/puppet-hiera/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/terrimonster/puppet-hiera/labels{/name}","releases_url":"https://api.github.com/repos/terrimonster/puppet-hiera/releases{/id}","created_at":"2014-07-24T15:47:24Z","updated_at":"2015-02-10T20:08:30Z","pushed_at":"2015-02-10T20:08:30Z","git_url":"git://github.com/terrimonster/puppet-hiera.git","ssh_url":"git@github.com:terrimonster/puppet-hiera.git","clone_url":"https://github.com/terrimonster/puppet-hiera.git","svn_url":"https://github.com/terrimonster/puppet-hiera","homepage":null,"size":180,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hunner:master","ref":"master","sha":"b728196e810534b78ab5206dcee7183c80227e69","user":{"login":"hunner","id":91972,"avatar_url":"https://avatars.githubusercontent.com/u/91972?v=3","gravatar_id":"","url":"https://api.github.com/users/hunner","html_url":"https://github.com/hunner","followers_url":"https://api.github.com/users/hunner/followers","following_url":"https://api.github.com/users/hunner/following{/other_user}","gists_url":"https://api.github.com/users/hunner/gists{/gist_id}","starred_url":"https://api.github.com/users/hunner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hunner/subscriptions","organizations_url":"https://api.github.com/users/hunner/orgs","repos_url":"https://api.github.com/users/hunner/repos","events_url":"https://api.github.com/users/hunner/events{/privacy}","received_events_url":"https://api.github.com/users/hunner/received_events","type":"User","site_admin":false},"repo":{"id":5417020,"name":"puppet-hiera","full_name":"hunner/puppet-hiera","owner":{"login":"hunner","id":91972,"avatar_url":"https://avatars.githubusercontent.com/u/91972?v=3","gravatar_id":"","url":"https://api.github.com/users/hunner","html_url":"https://github.com/hunner","followers_url":"https://api.github.com/users/hunner/followers","following_url":"https://api.github.com/users/hunner/following{/other_user}","gists_url":"https://api.github.com/users/hunner/gists{/gist_id}","starred_url":"https://api.github.com/users/hunner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hunner/subscriptions","organizations_url":"https://api.github.com/users/hunner/orgs","repos_url":"https://api.github.com/users/hunner/repos","events_url":"https://api.github.com/users/hunner/events{/privacy}","received_events_url":"https://api.github.com/users/hunner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hunner/puppet-hiera","description":"Hiera hierarchy module for templating `hiera.yaml`","fork":false,"url":"https://api.github.com/repos/hunner/puppet-hiera","forks_url":"https://api.github.com/repos/hunner/puppet-hiera/forks","keys_url":"https://api.github.com/repos/hunner/puppet-hiera/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hunner/puppet-hiera/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hunner/puppet-hiera/teams","hooks_url":"https://api.github.com/repos/hunner/puppet-hiera/hooks","issue_events_url":"https://api.github.com/repos/hunner/puppet-hiera/issues/events{/number}","events_url":"https://api.github.com/repos/hunner/puppet-hiera/events","assignees_url":"https://api.github.com/repos/hunner/puppet-hiera/assignees{/user}","branches_url":"https://api.github.com/repos/hunner/puppet-hiera/branches{/branch}","tags_url":"https://api.github.com/repos/hunner/puppet-hiera/tags","blobs_url":"https://api.github.com/repos/hunner/puppet-hiera/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hunner/puppet-hiera/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hunner/puppet-hiera/git/refs{/sha}","trees_url":"https://api.github.com/repos/hunner/puppet-hiera/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hunner/puppet-hiera/statuses/{sha}","languages_url":"https://api.github.com/repos/hunner/puppet-hiera/languages","stargazers_url":"https://api.github.com/repos/hunner/puppet-hiera/stargazers","contributors_url":"https://api.github.com/repos/hunner/puppet-hiera/contributors","subscribers_url":"https://api.github.com/repos/hunner/puppet-hiera/subscribers","subscription_url":"https://api.github.com/repos/hunner/puppet-hiera/subscription","commits_url":"https://api.github.com/repos/hunner/puppet-hiera/commits{/sha}","git_commits_url":"https://api.github.com/repos/hunner/puppet-hiera/git/commits{/sha}","comments_url":"https://api.github.com/repos/hunner/puppet-hiera/comments{/number}","issue_comment_url":"https://api.github.com/repos/hunner/puppet-hiera/issues/comments{/number}","contents_url":"https://api.github.com/repos/hunner/puppet-hiera/contents/{+path}","compare_url":"https://api.github.com/repos/hunner/puppet-hiera/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hunner/puppet-hiera/merges","archive_url":"https://api.github.com/repos/hunner/puppet-hiera/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hunner/puppet-hiera/downloads","issues_url":"https://api.github.com/repos/hunner/puppet-hiera/issues{/number}","pulls_url":"https://api.github.com/repos/hunner/puppet-hiera/pulls{/number}","milestones_url":"https://api.github.com/repos/hunner/puppet-hiera/milestones{/number}","notifications_url":"https://api.github.com/repos/hunner/puppet-hiera/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hunner/puppet-hiera/labels{/name}","releases_url":"https://api.github.com/repos/hunner/puppet-hiera/releases{/id}","created_at":"2012-08-14T18:47:18Z","updated_at":"2015-03-06T01:07:31Z","pushed_at":"2015-03-06T01:07:33Z","git_url":"git://github.com/hunner/puppet-hiera.git","ssh_url":"git@github.com:hunner/puppet-hiera.git","clone_url":"https://github.com/hunner/puppet-hiera.git","svn_url":"https://github.com/hunner/puppet-hiera","homepage":null,"size":687,"stargazers_count":7,"watchers_count":7,"language":"Puppet","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":10,"forks":34,"open_issues":10,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hunner/puppet-hiera/pulls/45"},"html":{"href":"https://github.com/hunner/puppet-hiera/pull/45"},"issue":{"href":"https://api.github.com/repos/hunner/puppet-hiera/issues/45"},"comments":{"href":"https://api.github.com/repos/hunner/puppet-hiera/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/hunner/puppet-hiera/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/hunner/puppet-hiera/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hunner/puppet-hiera/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/hunner/puppet-hiera/statuses/89cd0c82d12a9b3c6d47d1ddbd08ce1c7c31ddd3"}}}}