{"action":"created","issue":{"url":"https://api.github.com/repos/squarefeet/ShaderParticleEngine/issues/75","labels_url":"https://api.github.com/repos/squarefeet/ShaderParticleEngine/issues/75/labels{/name}","comments_url":"https://api.github.com/repos/squarefeet/ShaderParticleEngine/issues/75/comments","events_url":"https://api.github.com/repos/squarefeet/ShaderParticleEngine/issues/75/events","html_url":"https://github.com/squarefeet/ShaderParticleEngine/issues/75","id":103980845,"number":75,"title":"compatibility with upcoming R72 of three.js","user":{"login":"vincent-courtalon","id":12761431,"avatar_url":"https://avatars.githubusercontent.com/u/12761431?v=3","gravatar_id":"","url":"https://api.github.com/users/vincent-courtalon","html_url":"https://github.com/vincent-courtalon","followers_url":"https://api.github.com/users/vincent-courtalon/followers","following_url":"https://api.github.com/users/vincent-courtalon/following{/other_user}","gists_url":"https://api.github.com/users/vincent-courtalon/gists{/gist_id}","starred_url":"https://api.github.com/users/vincent-courtalon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vincent-courtalon/subscriptions","organizations_url":"https://api.github.com/users/vincent-courtalon/orgs","repos_url":"https://api.github.com/users/vincent-courtalon/repos","events_url":"https://api.github.com/users/vincent-courtalon/events{/privacy}","received_events_url":"https://api.github.com/users/vincent-courtalon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":21,"created_at":"2015-08-31T03:59:45Z","updated_at":"2015-10-07T21:47:57Z","closed_at":null,"body":"Hello, i am not sure if it is really a bug or just a temporary change from R72 dev version of three.js, but using the shaderParticleEngine with it does not work for me (it works with r71 of three.js)\r\nit makes a webgl warning \"WARNING: Attribute 0 is disabled. This has signficant performance penalty\" on chrome, and the particles are not visible...\r\n\r\nif you have any idea of a quick fix (some suggestion i found was using index0AttributeName on material)? I will try later to pinpoint at what commit of three.js it happen.\r\n\r\nand thank you for this project, it is a really fast particle engine!"},"comment":{"url":"https://api.github.com/repos/squarefeet/ShaderParticleEngine/issues/comments/146342789","html_url":"https://github.com/squarefeet/ShaderParticleEngine/issues/75#issuecomment-146342789","issue_url":"https://api.github.com/repos/squarefeet/ShaderParticleEngine/issues/75","id":146342789,"user":{"login":"squarefeet","id":1072296,"avatar_url":"https://avatars.githubusercontent.com/u/1072296?v=3","gravatar_id":"","url":"https://api.github.com/users/squarefeet","html_url":"https://github.com/squarefeet","followers_url":"https://api.github.com/users/squarefeet/followers","following_url":"https://api.github.com/users/squarefeet/following{/other_user}","gists_url":"https://api.github.com/users/squarefeet/gists{/gist_id}","starred_url":"https://api.github.com/users/squarefeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squarefeet/subscriptions","organizations_url":"https://api.github.com/users/squarefeet/orgs","repos_url":"https://api.github.com/users/squarefeet/repos","events_url":"https://api.github.com/users/squarefeet/events{/privacy}","received_events_url":"https://api.github.com/users/squarefeet/received_events","type":"User","site_admin":false},"created_at":"2015-10-07T21:47:57Z","updated_at":"2015-10-07T21:47:57Z","body":"Throwing this out there for opinions:\r\n\r\nWould people using this lib be bothered if I slightly changed the way emitter properties were set? \r\n\r\nCurrent way:\r\n\r\n```\r\nvar emitter = new SPE.Emitter( {\r\n    sizeStart: 1,\r\n    sizeMiddle: 10,\r\n    sizeEnd: 5,\r\n    // etc.\r\n} );\r\n```\r\n\r\nPotential new way:\r\n\r\n```\r\nvar emitter = new SPE.Emitter( {\r\n    size: {\r\n        start: 1,\r\n        middle: 10,\r\n        end: 5\r\n    },\r\n    // etc., same structure for other props such as `opacity` and `angle`\r\n} );\r\n\r\n// Or:\r\nvar emitter = new SPE.Emitter( {\r\n    size: new SPE.ValueOverLifetime( 1, 10, 5, ... ), // Allows for more than three values\r\n    // etc., same structure for other props such as `opacity` and `angle`\r\n} );\r\n```\r\n\r\nNothing's set-in-stone yet (as I've not started attacking this bit), so willing to go with general consensus here, and maybe support both options to allow backward compatibility.\r\n\r\nDo let me know!"}}