{"action":"created","comment":{"url":"https://api.github.com/repos/kframework/k/pulls/comments/48037535","id":48037535,"diff_hunk":"@@ -494,43 +522,51 @@ semantics of thread spawning will be defined shortly.  However,\n interestingly, the other concurrency constructs keep their semantics\n from SIMPLE unchanged. */\n \n-  rule (<thread>... <k>.</k> <holds>H</holds> <id>T</id> ...</thread> => .)\n+  // TODO(KORE): ..Bag should be . throughout this definition #1772\n+  rule `<thread>... <k>.K</k> <holds>H</holds> <id>T</id> ...</thread> => .Bag`\n+  /*\n+  rule `<thread>... <k>.</k> <holds>H</holds> <id>T</id> ...</thread> => .`\n+  */\n        <busy> Busy => Busy -Set keys(H) </busy>\n        <terminated>... .Set => SetItem(T) ...</terminated>\n \n-  rule <k> join T:Int; => . ...</k>\n+  rule <k> join T:Int; => .K ...</k>\n        <terminated>... SetItem(T) ...</terminated>\n \n-  rule <k> acquire V:Val; => . ...</k>\n+  rule <k> acquire V:Val; => .K ...</k>\n        <holds>... .Map => V |-> 0 ...</holds>\n-       <busy> Busy (.Set => SetItem(V)) </busy>\n+       <busy> Busy `.Set => SetItem(V)` </busy>\n     when (notBool(V in Busy:Set))  [acquire]\n \n-  rule <k> acquire V; => . ...</k>\n+  rule <k> acquire V; => .K ...</k>\n        <holds>... V:Val |-> (N:Int => N +Int 1) ...</holds>\n \n-  rule <k> release V:Val; => . ...</k>\n+  rule <k> release V:Val; => .K ...</k>\n        <holds>... V |-> (N => N:Int -Int 1) ...</holds>\n     when N >Int 0\n \n-  rule <k> release V; => . ...</k> <holds>... V:Val |-> 0 => .Map ...</holds>\n+  rule <k> release V; => .K ...</k> <holds>... V:Val |-> 0 => .Map ...</holds>\n        <busy>... SetItem(V) => .Set ...</busy>\n \n-  rule <k> rendezvous V:Val; => . ...</k>\n-       <k> rendezvous V; => . ...</k>  [rendezvous]\n+  rule <k> rendezvous V:Val; => .K ...</k>\n+       <k> rendezvous V; => .K ...</k>  [rendezvous]\n \n //@ \\subsection{Unchanged auxiliary operations from untyped SIMPLE}\n \n   syntax Stmts ::= mkDecls(Ids,Vals)  [function]\n-  rule mkDecls((X:Id, Xs:Ids), (V:Val, Vs:Vals)) => var X=V; mkDecls(Xs,Vs)\n+  rule mkDecls(`X:Id, Xs:Ids`, `V:Val, Vs:Vals`) => var X=V; mkDecls(Xs,Vs)\n   rule mkDecls(.Ids,.Vals) => {}\n \n+  // TODO(KORE): clarify sort inferences #1803\n+  syntax Exp ::= lookup(Int)\n+  /*\n   syntax KItem ::= lookup(Int)\n+  */\n   rule <k> lookup(L) => V ...</k> <store>... L |-> V:Val ...</store>  [lookup]\n \n   syntax KItem ::= env(Map)\n-  rule <k> env(Env) => . ...</k>  <env> _ => Env </env>  [structural]\n-  rule (env(_) => .) ~> env(_)  [structural]\n+  rule <k> env(Env) => .K ...</k>  <env> _ => Env </env>  [structural]\n+  rule `env(_) => .K` ~> env(_)  [structural]","path":"k-distribution/tutorial/2_languages/2_kool/1_untyped/kool-untyped.k","position":258,"original_position":258,"commit_id":"3b389f1450b447977774263833ef5895796e9eb4","original_commit_id":"3b389f1450b447977774263833ef5895796e9eb4","user":{"login":"grosu","id":3733729,"avatar_url":"https://avatars.githubusercontent.com/u/3733729?v=3","gravatar_id":"","url":"https://api.github.com/users/grosu","html_url":"https://github.com/grosu","followers_url":"https://api.github.com/users/grosu/followers","following_url":"https://api.github.com/users/grosu/following{/other_user}","gists_url":"https://api.github.com/users/grosu/gists{/gist_id}","starred_url":"https://api.github.com/users/grosu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grosu/subscriptions","organizations_url":"https://api.github.com/users/grosu/orgs","repos_url":"https://api.github.com/users/grosu/repos","events_url":"https://api.github.com/users/grosu/events{/privacy}","received_events_url":"https://api.github.com/users/grosu/received_events","type":"User","site_admin":false},"body":"Hm, how can we make sure that the second rule above applies before the first one?\r\nProbably we'll deal with this using strategies, eventually.  For now, let's not worry about it. because we had that problem there before, too.  Can you @daejunpark just add a TODO comment?","created_at":"2015-12-18T15:45:50Z","updated_at":"2015-12-18T15:45:50Z","html_url":"https://github.com/kframework/k/pull/1925#discussion_r48037535","pull_request_url":"https://api.github.com/repos/kframework/k/pulls/1925","_links":{"self":{"href":"https://api.github.com/repos/kframework/k/pulls/comments/48037535"},"html":{"href":"https://github.com/kframework/k/pull/1925#discussion_r48037535"},"pull_request":{"href":"https://api.github.com/repos/kframework/k/pulls/1925"}}},"pull_request":{"url":"https://api.github.com/repos/kframework/k/pulls/1925","id":54045721,"html_url":"https://github.com/kframework/k/pull/1925","diff_url":"https://github.com/kframework/k/pull/1925.diff","patch_url":"https://github.com/kframework/k/pull/1925.patch","issue_url":"https://api.github.com/repos/kframework/k/issues/1925","number":1925,"state":"open","locked":false,"title":"tutorial-kool","user":{"login":"daejunpark","id":5491770,"avatar_url":"https://avatars.githubusercontent.com/u/5491770?v=3","gravatar_id":"","url":"https://api.github.com/users/daejunpark","html_url":"https://github.com/daejunpark","followers_url":"https://api.github.com/users/daejunpark/followers","following_url":"https://api.github.com/users/daejunpark/following{/other_user}","gists_url":"https://api.github.com/users/daejunpark/gists{/gist_id}","starred_url":"https://api.github.com/users/daejunpark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daejunpark/subscriptions","organizations_url":"https://api.github.com/users/daejunpark/orgs","repos_url":"https://api.github.com/users/daejunpark/repos","events_url":"https://api.github.com/users/daejunpark/events{/privacy}","received_events_url":"https://api.github.com/users/daejunpark/received_events","type":"User","site_admin":false},"body":"@grosu Please review the final changes made into KOOL.\r\n\r\nNOTE: This is an artificial pull request for the review purpose only. You can leave comments in the same way we did for a normal pull request, but should NOT merge it into master.","created_at":"2015-12-17T23:18:44Z","updated_at":"2015-12-18T15:45:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50961269efbcccebc458b67c2391bc22d3383444","assignee":{"login":"grosu","id":3733729,"avatar_url":"https://avatars.githubusercontent.com/u/3733729?v=3","gravatar_id":"","url":"https://api.github.com/users/grosu","html_url":"https://github.com/grosu","followers_url":"https://api.github.com/users/grosu/followers","following_url":"https://api.github.com/users/grosu/following{/other_user}","gists_url":"https://api.github.com/users/grosu/gists{/gist_id}","starred_url":"https://api.github.com/users/grosu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grosu/subscriptions","organizations_url":"https://api.github.com/users/grosu/orgs","repos_url":"https://api.github.com/users/grosu/repos","events_url":"https://api.github.com/users/grosu/events{/privacy}","received_events_url":"https://api.github.com/users/grosu/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/kframework/k/milestones/12","html_url":"https://github.com/kframework/k/milestones/4.0%20beta","labels_url":"https://api.github.com/repos/kframework/k/milestones/12/labels","id":1435572,"number":12,"title":"4.0 beta","description":"","creator":{"login":"cos","id":37514,"avatar_url":"https://avatars.githubusercontent.com/u/37514?v=3","gravatar_id":"","url":"https://api.github.com/users/cos","html_url":"https://github.com/cos","followers_url":"https://api.github.com/users/cos/followers","following_url":"https://api.github.com/users/cos/following{/other_user}","gists_url":"https://api.github.com/users/cos/gists{/gist_id}","starred_url":"https://api.github.com/users/cos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cos/subscriptions","organizations_url":"https://api.github.com/users/cos/orgs","repos_url":"https://api.github.com/users/cos/repos","events_url":"https://api.github.com/users/cos/events{/privacy}","received_events_url":"https://api.github.com/users/cos/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":1,"state":"open","created_at":"2015-11-30T16:25:24Z","updated_at":"2015-12-18T15:36:10Z","due_on":"2015-12-22T06:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/kframework/k/pulls/1925/commits","review_comments_url":"https://api.github.com/repos/kframework/k/pulls/1925/comments","review_comment_url":"https://api.github.com/repos/kframework/k/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kframework/k/issues/1925/comments","statuses_url":"https://api.github.com/repos/kframework/k/statuses/3b389f1450b447977774263833ef5895796e9eb4","head":{"label":"kframework:tutorial-kool","ref":"tutorial-kool","sha":"3b389f1450b447977774263833ef5895796e9eb4","user":{"login":"kframework","id":5104335,"avatar_url":"https://avatars.githubusercontent.com/u/5104335?v=3","gravatar_id":"","url":"https://api.github.com/users/kframework","html_url":"https://github.com/kframework","followers_url":"https://api.github.com/users/kframework/followers","following_url":"https://api.github.com/users/kframework/following{/other_user}","gists_url":"https://api.github.com/users/kframework/gists{/gist_id}","starred_url":"https://api.github.com/users/kframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kframework/subscriptions","organizations_url":"https://api.github.com/users/kframework/orgs","repos_url":"https://api.github.com/users/kframework/repos","events_url":"https://api.github.com/users/kframework/events{/privacy}","received_events_url":"https://api.github.com/users/kframework/received_events","type":"Organization","site_admin":false},"repo":{"id":11711223,"name":"k","full_name":"kframework/k","owner":{"login":"kframework","id":5104335,"avatar_url":"https://avatars.githubusercontent.com/u/5104335?v=3","gravatar_id":"","url":"https://api.github.com/users/kframework","html_url":"https://github.com/kframework","followers_url":"https://api.github.com/users/kframework/followers","following_url":"https://api.github.com/users/kframework/following{/other_user}","gists_url":"https://api.github.com/users/kframework/gists{/gist_id}","starred_url":"https://api.github.com/users/kframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kframework/subscriptions","organizations_url":"https://api.github.com/users/kframework/orgs","repos_url":"https://api.github.com/users/kframework/repos","events_url":"https://api.github.com/users/kframework/events{/privacy}","received_events_url":"https://api.github.com/users/kframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kframework/k","description":"The K tools","fork":false,"url":"https://api.github.com/repos/kframework/k","forks_url":"https://api.github.com/repos/kframework/k/forks","keys_url":"https://api.github.com/repos/kframework/k/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kframework/k/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kframework/k/teams","hooks_url":"https://api.github.com/repos/kframework/k/hooks","issue_events_url":"https://api.github.com/repos/kframework/k/issues/events{/number}","events_url":"https://api.github.com/repos/kframework/k/events","assignees_url":"https://api.github.com/repos/kframework/k/assignees{/user}","branches_url":"https://api.github.com/repos/kframework/k/branches{/branch}","tags_url":"https://api.github.com/repos/kframework/k/tags","blobs_url":"https://api.github.com/repos/kframework/k/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kframework/k/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kframework/k/git/refs{/sha}","trees_url":"https://api.github.com/repos/kframework/k/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kframework/k/statuses/{sha}","languages_url":"https://api.github.com/repos/kframework/k/languages","stargazers_url":"https://api.github.com/repos/kframework/k/stargazers","contributors_url":"https://api.github.com/repos/kframework/k/contributors","subscribers_url":"https://api.github.com/repos/kframework/k/subscribers","subscription_url":"https://api.github.com/repos/kframework/k/subscription","commits_url":"https://api.github.com/repos/kframework/k/commits{/sha}","git_commits_url":"https://api.github.com/repos/kframework/k/git/commits{/sha}","comments_url":"https://api.github.com/repos/kframework/k/comments{/number}","issue_comment_url":"https://api.github.com/repos/kframework/k/issues/comments{/number}","contents_url":"https://api.github.com/repos/kframework/k/contents/{+path}","compare_url":"https://api.github.com/repos/kframework/k/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kframework/k/merges","archive_url":"https://api.github.com/repos/kframework/k/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kframework/k/downloads","issues_url":"https://api.github.com/repos/kframework/k/issues{/number}","pulls_url":"https://api.github.com/repos/kframework/k/pulls{/number}","milestones_url":"https://api.github.com/repos/kframework/k/milestones{/number}","notifications_url":"https://api.github.com/repos/kframework/k/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kframework/k/labels{/name}","releases_url":"https://api.github.com/repos/kframework/k/releases{/id}","created_at":"2013-07-27T21:22:53Z","updated_at":"2015-12-17T03:44:24Z","pushed_at":"2015-12-17T23:18:44Z","git_url":"git://github.com/kframework/k.git","ssh_url":"git@github.com:kframework/k.git","clone_url":"https://github.com/kframework/k.git","svn_url":"https://github.com/kframework/k","homepage":"kframework.org","size":272075,"stargazers_count":74,"watchers_count":74,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":260,"forks":54,"open_issues":260,"watchers":74,"default_branch":"master"}},"base":{"label":"kframework:tutorial-base-kool","ref":"tutorial-base-kool","sha":"c82d9c333b3541201edd4d7a6ccfef99ca51181b","user":{"login":"kframework","id":5104335,"avatar_url":"https://avatars.githubusercontent.com/u/5104335?v=3","gravatar_id":"","url":"https://api.github.com/users/kframework","html_url":"https://github.com/kframework","followers_url":"https://api.github.com/users/kframework/followers","following_url":"https://api.github.com/users/kframework/following{/other_user}","gists_url":"https://api.github.com/users/kframework/gists{/gist_id}","starred_url":"https://api.github.com/users/kframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kframework/subscriptions","organizations_url":"https://api.github.com/users/kframework/orgs","repos_url":"https://api.github.com/users/kframework/repos","events_url":"https://api.github.com/users/kframework/events{/privacy}","received_events_url":"https://api.github.com/users/kframework/received_events","type":"Organization","site_admin":false},"repo":{"id":11711223,"name":"k","full_name":"kframework/k","owner":{"login":"kframework","id":5104335,"avatar_url":"https://avatars.githubusercontent.com/u/5104335?v=3","gravatar_id":"","url":"https://api.github.com/users/kframework","html_url":"https://github.com/kframework","followers_url":"https://api.github.com/users/kframework/followers","following_url":"https://api.github.com/users/kframework/following{/other_user}","gists_url":"https://api.github.com/users/kframework/gists{/gist_id}","starred_url":"https://api.github.com/users/kframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kframework/subscriptions","organizations_url":"https://api.github.com/users/kframework/orgs","repos_url":"https://api.github.com/users/kframework/repos","events_url":"https://api.github.com/users/kframework/events{/privacy}","received_events_url":"https://api.github.com/users/kframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kframework/k","description":"The K tools","fork":false,"url":"https://api.github.com/repos/kframework/k","forks_url":"https://api.github.com/repos/kframework/k/forks","keys_url":"https://api.github.com/repos/kframework/k/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kframework/k/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kframework/k/teams","hooks_url":"https://api.github.com/repos/kframework/k/hooks","issue_events_url":"https://api.github.com/repos/kframework/k/issues/events{/number}","events_url":"https://api.github.com/repos/kframework/k/events","assignees_url":"https://api.github.com/repos/kframework/k/assignees{/user}","branches_url":"https://api.github.com/repos/kframework/k/branches{/branch}","tags_url":"https://api.github.com/repos/kframework/k/tags","blobs_url":"https://api.github.com/repos/kframework/k/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kframework/k/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kframework/k/git/refs{/sha}","trees_url":"https://api.github.com/repos/kframework/k/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kframework/k/statuses/{sha}","languages_url":"https://api.github.com/repos/kframework/k/languages","stargazers_url":"https://api.github.com/repos/kframework/k/stargazers","contributors_url":"https://api.github.com/repos/kframework/k/contributors","subscribers_url":"https://api.github.com/repos/kframework/k/subscribers","subscription_url":"https://api.github.com/repos/kframework/k/subscription","commits_url":"https://api.github.com/repos/kframework/k/commits{/sha}","git_commits_url":"https://api.github.com/repos/kframework/k/git/commits{/sha}","comments_url":"https://api.github.com/repos/kframework/k/comments{/number}","issue_comment_url":"https://api.github.com/repos/kframework/k/issues/comments{/number}","contents_url":"https://api.github.com/repos/kframework/k/contents/{+path}","compare_url":"https://api.github.com/repos/kframework/k/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kframework/k/merges","archive_url":"https://api.github.com/repos/kframework/k/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kframework/k/downloads","issues_url":"https://api.github.com/repos/kframework/k/issues{/number}","pulls_url":"https://api.github.com/repos/kframework/k/pulls{/number}","milestones_url":"https://api.github.com/repos/kframework/k/milestones{/number}","notifications_url":"https://api.github.com/repos/kframework/k/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kframework/k/labels{/name}","releases_url":"https://api.github.com/repos/kframework/k/releases{/id}","created_at":"2013-07-27T21:22:53Z","updated_at":"2015-12-17T03:44:24Z","pushed_at":"2015-12-17T23:18:44Z","git_url":"git://github.com/kframework/k.git","ssh_url":"git@github.com:kframework/k.git","clone_url":"https://github.com/kframework/k.git","svn_url":"https://github.com/kframework/k","homepage":"kframework.org","size":272075,"stargazers_count":74,"watchers_count":74,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":260,"forks":54,"open_issues":260,"watchers":74,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kframework/k/pulls/1925"},"html":{"href":"https://github.com/kframework/k/pull/1925"},"issue":{"href":"https://api.github.com/repos/kframework/k/issues/1925"},"comments":{"href":"https://api.github.com/repos/kframework/k/issues/1925/comments"},"review_comments":{"href":"https://api.github.com/repos/kframework/k/pulls/1925/comments"},"review_comment":{"href":"https://api.github.com/repos/kframework/k/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kframework/k/pulls/1925/commits"},"statuses":{"href":"https://api.github.com/repos/kframework/k/statuses/3b389f1450b447977774263833ef5895796e9eb4"}}}}