{"action":"created","issue":{"url":"https://api.github.com/repos/sillsdev/flexbridge/issues/64","labels_url":"https://api.github.com/repos/sillsdev/flexbridge/issues/64/labels{/name}","comments_url":"https://api.github.com/repos/sillsdev/flexbridge/issues/64/comments","events_url":"https://api.github.com/repos/sillsdev/flexbridge/issues/64/events","html_url":"https://github.com/sillsdev/flexbridge/pull/64","id":117148775,"number":64,"title":"Move project splitting/unifying code in separate library","user":{"login":"ermshiperete","id":181336,"avatar_url":"https://avatars.githubusercontent.com/u/181336?v=3","gravatar_id":"","url":"https://api.github.com/users/ermshiperete","html_url":"https://github.com/ermshiperete","followers_url":"https://api.github.com/users/ermshiperete/followers","following_url":"https://api.github.com/users/ermshiperete/following{/other_user}","gists_url":"https://api.github.com/users/ermshiperete/gists{/gist_id}","starred_url":"https://api.github.com/users/ermshiperete/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ermshiperete/subscriptions","organizations_url":"https://api.github.com/users/ermshiperete/orgs","repos_url":"https://api.github.com/users/ermshiperete/repos","events_url":"https://api.github.com/users/ermshiperete/events{/privacy}","received_events_url":"https://api.github.com/users/ermshiperete/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-16T15:28:46Z","updated_at":"2015-11-18T19:06:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sillsdev/flexbridge/pulls/64","html_url":"https://github.com/sillsdev/flexbridge/pull/64","diff_url":"https://github.com/sillsdev/flexbridge/pull/64.diff","patch_url":"https://github.com/sillsdev/flexbridge/pull/64.patch"},"body":"These changes require a change in Chorus (https://github.com/sillsdev/chorus/pull/79). They are necessary to have a library that doesn't have any UI so that it can be used in LanguageForge S/R.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/sillsdev/flexbridge/64)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/sillsdev/flexbridge/issues/comments/157824572","html_url":"https://github.com/sillsdev/flexbridge/pull/64#issuecomment-157824572","issue_url":"https://api.github.com/repos/sillsdev/flexbridge/issues/64","id":157824572,"user":{"login":"regnrand","id":639605,"avatar_url":"https://avatars.githubusercontent.com/u/639605?v=3","gravatar_id":"","url":"https://api.github.com/users/regnrand","html_url":"https://github.com/regnrand","followers_url":"https://api.github.com/users/regnrand/followers","following_url":"https://api.github.com/users/regnrand/following{/other_user}","gists_url":"https://api.github.com/users/regnrand/gists{/gist_id}","starred_url":"https://api.github.com/users/regnrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/regnrand/subscriptions","organizations_url":"https://api.github.com/users/regnrand/orgs","repos_url":"https://api.github.com/users/regnrand/repos","events_url":"https://api.github.com/users/regnrand/events{/privacy}","received_events_url":"https://api.github.com/users/regnrand/received_events","type":"User","site_admin":false},"created_at":"2015-11-18T19:06:27Z","updated_at":"2015-11-18T19:06:27Z","body":"\n\n\n\nReviewed 375 of 376 files at r1.\nReview status: 215 of 216 files reviewed at latest revision, 8 unresolved discussions.\n\n---\n\n_[src/FLEx-ChorusPlugin/FLEx-ChorusPlugin.csproj, line 201 \\[r1\\]](https://reviewable.io:443/reviews/sillsdev/flexbridge/64#-K3QQlPdQ8osWHgkhFLA:-K3QQlPdQ8osWHgkhFLB:1593378051) ([raw file](https://github.com/sillsdev/flexbridge/blob/a19113f8673b698783b6de3a3bb3dbe61fa1f441/src/FLEx-ChorusPlugin/FLEx-ChorusPlugin.csproj#L201)):_\nSeems like the trend is to make the two gecko references not be OS-specific. With that in mind, I never really understood why FB needed the gecko stuff at all.\n\n---\n\n_[src/LibFLExBridge-ChorusPlugin/FLExProjectSplitter.cs, line 39 \\[r1\\]](https://reviewable.io:443/reviews/sillsdev/flexbridge/64#-K3Qn-IvbYgVvDzE9ipv:-K3Qn-IvbYgVvDzE9ipw:-1486935153) ([raw file](https://github.com/sillsdev/flexbridge/blob/a19113f8673b698783b6de3a3bb3dbe61fa1f441/src/LibFLExBridge-ChorusPlugin/FLExProjectSplitter.cs#L39)):_\nDoes all of this really need to be public?\n\n---\n\n_[src/LibFLExBridge-ChorusPlugin/FLExProjectUnifier.cs, line 38 \\[r1\\]](https://reviewable.io:443/reviews/sillsdev/flexbridge/64#-K3Qmizu9sC6JX8jeBIy:-K3Qmizu9sC6JX8jeBIz:-1486935153) ([raw file](https://github.com/sillsdev/flexbridge/blob/a19113f8673b698783b6de3a3bb3dbe61fa1f441/src/LibFLExBridge-ChorusPlugin/FLExProjectUnifier.cs#L38)):_\nDoes all of this really need to be public?\n\n---\n\n_[src/LibFLExBridge-ChorusPlugin/Handling/UnknownFileTypeHandlerStrategy.cs, line 17 \\[r1\\]](https://reviewable.io:443/reviews/sillsdev/flexbridge/64#-K3QfTg8b5XRIy4zYKoH:-K3QfTg8b5XRIy4zYKoI:-492061491) ([raw file](https://github.com/sillsdev/flexbridge/blob/a19113f8673b698783b6de3a3bb3dbe61fa1f441/src/LibFLExBridge-ChorusPlugin/Handling/UnknownFileTypeHandlerStrategy.cs#L17)):_\nMaybe add a comment about why this one does not use the 'typeof(IFieldWorksFileHandler) business. cf. code that imports UnknownFileTypeHandlerStrategy and all other IFieldWorksFileHandler impls.\n\n---\n\n_[src/LibFLExBridge-ChorusPlugin/Infrastructure/FieldWorksProjectServices.cs, line 15 \\[r1\\]](https://reviewable.io:443/reviews/sillsdev/flexbridge/64#-K3Qe_aFOXGQejnJSEUL:-K3Qe_aFOXGQejnJSEUM:-1844688748) ([raw file](https://github.com/sillsdev/flexbridge/blob/a19113f8673b698783b6de3a3bb3dbe61fa1f441/src/LibFLExBridge-ChorusPlugin/Infrastructure/FieldWorksProjectServices.cs#L15)):_\nDoes this need to be public?\n\n---\n\n_[src/LibFLExBridge-ChorusPlugin/Properties/Resources.resx, line 1 \\[r1\\]](https://reviewable.io:443/reviews/sillsdev/flexbridge/64#-K3QdUHTiBJe_us-YMEb:-K3QdUHTiBJe_us-YMEc:127469211) ([raw file](https://github.com/sillsdev/flexbridge/blob/a19113f8673b698783b6de3a3bb3dbe61fa1f441/src/LibFLExBridge-ChorusPlugin/Properties/Resources.resx#L1)):_\nAren't many/most of these strings shown via the UI, which this lib version doesn't allow?\n\n---\n\n_[src/LibFLExBridge-ChorusPluginTests/FieldWorksTestServices.cs, line 20 \\[r1\\]](https://reviewable.io:443/reviews/sillsdev/flexbridge/64#-K3Qc8Ci9wi4HnY7RVup:-K3Qc8Ci9wi4HnY7RVuq:-1699657842) ([raw file](https://github.com/sillsdev/flexbridge/blob/a19113f8673b698783b6de3a3bb3dbe61fa1f441/src/LibFLExBridge-ChorusPluginTests/FieldWorksTestServices.cs#L20)):_\nDoes all of this need to be public? If the regular FB tests need to access this, it can be granted access to internals, no?\n\n---\n\n_[src/LibTriboroughBridge-ChorusPlugin/Infrastructure/UpdateBranchHelper.cs, line 11 \\[r1\\]](https://reviewable.io:443/reviews/sillsdev/flexbridge/64#-K3QVKwy4rxo65QZoMva:-K3QVKwy4rxo65QZoMvb:-919599957) ([raw file](https://github.com/sillsdev/flexbridge/blob/a19113f8673b698783b6de3a3bb3dbe61fa1f441/src/LibTriboroughBridge-ChorusPlugin/Infrastructure/UpdateBranchHelper.cs#L11)):_\nCan you add a class comment and comments to all public stuff? The FB system has never been picky about this, but they are nice to have.\n\nBTW, nice job of refactoring this chunk of code. Thx.\n\n---\n\n\n_Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/sillsdev/flexbridge/64)_\n<!-- Sent from Reviewable.io -->\n"}}