{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/23460690","id":23460690,"diff_hunk":"@@ -0,0 +1,105 @@\n+/* global PlayerView */\n+\n+'use strict';\n+\n+require('/js/ui/views/player_view.js');\n+require('/shared/js/l10n.js');\n+\n+suite('Star Rating Bar Accessibility Test', function () {\n+\n+    var pv,\n+    ratings;\n+\n+    suiteSetup(function () {\n+       ","path":"apps/music/test/unit/player_view_test.js","position":null,"original_position":14,"commit_id":"932bb647a1f730072ecdbcc07a09c822af106e2b","original_commit_id":"2f67f8cd928f9fdcf92a63a8f90fb36041a63235","user":{"login":"yzen","id":561275,"avatar_url":"https://avatars.githubusercontent.com/u/561275?v=3","gravatar_id":"","url":"https://api.github.com/users/yzen","html_url":"https://github.com/yzen","followers_url":"https://api.github.com/users/yzen/followers","following_url":"https://api.github.com/users/yzen/following{/other_user}","gists_url":"https://api.github.com/users/yzen/gists{/gist_id}","starred_url":"https://api.github.com/users/yzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yzen/subscriptions","organizations_url":"https://api.github.com/users/yzen/orgs","repos_url":"https://api.github.com/users/yzen/repos","events_url":"https://api.github.com/users/yzen/events{/privacy}","received_events_url":"https://api.github.com/users/yzen/received_events","type":"User","site_admin":false},"body":"The empty lines are not an issue. You can be liberate with them. But they should not contain spaces in them. the only reason i spotted was that my editor (Sublime) highlights them and automatically removes (with Trailing Spaces add on). So for example on line 14 (which is fine to have empty) there are 7 spaces in the beginning of the line that need to be removed. The rest of the lines I mentioned have the same issue.","created_at":"2015-01-23T16:26:04Z","updated_at":"2015-01-23T16:26:04Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/27263#discussion_r23460690","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27263","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/23460690"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/27263#discussion_r23460690"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27263"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27263","id":27077770,"html_url":"https://github.com/mozilla-b2g/gaia/pull/27263","diff_url":"https://github.com/mozilla-b2g/gaia/pull/27263.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/27263.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/27263","number":27263,"state":"open","locked":false,"title":"Bug1069630 - Improved accessibility for rating/share bars","user":{"login":"FunkTron","id":1269536,"avatar_url":"https://avatars.githubusercontent.com/u/1269536?v=3","gravatar_id":"","url":"https://api.github.com/users/FunkTron","html_url":"https://github.com/FunkTron","followers_url":"https://api.github.com/users/FunkTron/followers","following_url":"https://api.github.com/users/FunkTron/following{/other_user}","gists_url":"https://api.github.com/users/FunkTron/gists{/gist_id}","starred_url":"https://api.github.com/users/FunkTron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FunkTron/subscriptions","organizations_url":"https://api.github.com/users/FunkTron/orgs","repos_url":"https://api.github.com/users/FunkTron/repos","events_url":"https://api.github.com/users/FunkTron/events{/privacy}","received_events_url":"https://api.github.com/users/FunkTron/received_events","type":"User","site_admin":false},"body":"Added appropriate aria labels in English localization file, identified ARIA roles in the HTML, updated visibility settings in CSS to account for off-screen objects, and updated js to account for dynamic ARIA settings","created_at":"2015-01-09T03:12:06Z","updated_at":"2015-01-23T16:26:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1adb6c7282b25e556909188f4390df7d56e33fc6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27263/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27263/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/27263/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/932bb647a1f730072ecdbcc07a09c822af106e2b","head":{"label":"FunkTron:Bug1069630","ref":"Bug1069630","sha":"932bb647a1f730072ecdbcc07a09c822af106e2b","user":{"login":"FunkTron","id":1269536,"avatar_url":"https://avatars.githubusercontent.com/u/1269536?v=3","gravatar_id":"","url":"https://api.github.com/users/FunkTron","html_url":"https://github.com/FunkTron","followers_url":"https://api.github.com/users/FunkTron/followers","following_url":"https://api.github.com/users/FunkTron/following{/other_user}","gists_url":"https://api.github.com/users/FunkTron/gists{/gist_id}","starred_url":"https://api.github.com/users/FunkTron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FunkTron/subscriptions","organizations_url":"https://api.github.com/users/FunkTron/orgs","repos_url":"https://api.github.com/users/FunkTron/repos","events_url":"https://api.github.com/users/FunkTron/events{/privacy}","received_events_url":"https://api.github.com/users/FunkTron/received_events","type":"User","site_admin":false},"repo":{"id":28671746,"name":"gaia","full_name":"FunkTron/gaia","owner":{"login":"FunkTron","id":1269536,"avatar_url":"https://avatars.githubusercontent.com/u/1269536?v=3","gravatar_id":"","url":"https://api.github.com/users/FunkTron","html_url":"https://github.com/FunkTron","followers_url":"https://api.github.com/users/FunkTron/followers","following_url":"https://api.github.com/users/FunkTron/following{/other_user}","gists_url":"https://api.github.com/users/FunkTron/gists{/gist_id}","starred_url":"https://api.github.com/users/FunkTron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FunkTron/subscriptions","organizations_url":"https://api.github.com/users/FunkTron/orgs","repos_url":"https://api.github.com/users/FunkTron/repos","events_url":"https://api.github.com/users/FunkTron/events{/privacy}","received_events_url":"https://api.github.com/users/FunkTron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/FunkTron/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","fork":true,"url":"https://api.github.com/repos/FunkTron/gaia","forks_url":"https://api.github.com/repos/FunkTron/gaia/forks","keys_url":"https://api.github.com/repos/FunkTron/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FunkTron/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FunkTron/gaia/teams","hooks_url":"https://api.github.com/repos/FunkTron/gaia/hooks","issue_events_url":"https://api.github.com/repos/FunkTron/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/FunkTron/gaia/events","assignees_url":"https://api.github.com/repos/FunkTron/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/FunkTron/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/FunkTron/gaia/tags","blobs_url":"https://api.github.com/repos/FunkTron/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FunkTron/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FunkTron/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/FunkTron/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FunkTron/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/FunkTron/gaia/languages","stargazers_url":"https://api.github.com/repos/FunkTron/gaia/stargazers","contributors_url":"https://api.github.com/repos/FunkTron/gaia/contributors","subscribers_url":"https://api.github.com/repos/FunkTron/gaia/subscribers","subscription_url":"https://api.github.com/repos/FunkTron/gaia/subscription","commits_url":"https://api.github.com/repos/FunkTron/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/FunkTron/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/FunkTron/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/FunkTron/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/FunkTron/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/FunkTron/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FunkTron/gaia/merges","archive_url":"https://api.github.com/repos/FunkTron/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FunkTron/gaia/downloads","issues_url":"https://api.github.com/repos/FunkTron/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/FunkTron/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/FunkTron/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/FunkTron/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FunkTron/gaia/labels{/name}","releases_url":"https://api.github.com/repos/FunkTron/gaia/releases{/id}","created_at":"2014-12-31T17:57:36Z","updated_at":"2015-01-23T16:11:53Z","pushed_at":"2015-01-23T16:12:34Z","git_url":"git://github.com/FunkTron/gaia.git","ssh_url":"git@github.com:FunkTron/gaia.git","clone_url":"https://github.com/FunkTron/gaia.git","svn_url":"https://github.com/FunkTron/gaia","homepage":"https://wiki.mozilla.org/B2G","size":851666,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"008417477c649b46dbb97aedc2741a5d4c8e37ac","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2015-01-23T16:24:38Z","pushed_at":"2015-01-23T16:24:37Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1386168,"stargazers_count":1854,"watchers_count":1854,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2171,"mirror_url":null,"open_issues_count":842,"forks":2171,"open_issues":842,"watchers":1854,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27263"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/27263"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/27263"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/27263/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27263/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27263/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/932bb647a1f730072ecdbcc07a09c822af106e2b"}}}}