{"action":"opened","number":178,"pull_request":{"url":"https://api.github.com/repos/opencog/atomspace/pulls/178","id":41249892,"html_url":"https://github.com/opencog/atomspace/pull/178","diff_url":"https://github.com/opencog/atomspace/pull/178.diff","patch_url":"https://github.com/opencog/atomspace/pull/178.patch","issue_url":"https://api.github.com/repos/opencog/atomspace/issues/178","number":178,"state":"open","locked":false,"title":"Fix finding starter_term when clause is a Node (#75)","user":{"login":"jswiergo","id":2552224,"avatar_url":"https://avatars.githubusercontent.com/u/2552224?v=3","gravatar_id":"","url":"https://api.github.com/users/jswiergo","html_url":"https://github.com/jswiergo","followers_url":"https://api.github.com/users/jswiergo/followers","following_url":"https://api.github.com/users/jswiergo/following{/other_user}","gists_url":"https://api.github.com/users/jswiergo/gists{/gist_id}","starred_url":"https://api.github.com/users/jswiergo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jswiergo/subscriptions","organizations_url":"https://api.github.com/users/jswiergo/orgs","repos_url":"https://api.github.com/users/jswiergo/repos","events_url":"https://api.github.com/users/jswiergo/events{/privacy}","received_events_url":"https://api.github.com/users/jswiergo/received_events","type":"User","site_admin":false},"body":"This is continuation of #168 which @linas merged already just while I was writing this message.\r\n\r\n@williampma: The _starter_term should not be passed UNDEFINED to PatternMatchEngine in my opinion. It does not make sense for me. Why do I need to ask PME to match UNDEFINED clause/term when it is obvious that the answer is \"it matches nothing and there is nothing to search\". That is why I added protection in PME but not assertion.\r\n\r\nI have checked your suggestion deeper and found out that the only case when the starter becomes\r\nUNDEFINED is for clauses being simple nodes. InitiateSearchCB::find_starter was missing that case.\r\nI think this was wrong. It should just find the node as starter and pass it down to PME. It is justified\r\nbecause then PME calls PatternMatchCallback::match_node and this callback has a chance to accept the node or not. So I have added a fix to find_starter method in this commit.\r\n","created_at":"2015-07-30T15:50:05Z","updated_at":"2015-07-30T15:50:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opencog/atomspace/pulls/178/commits","review_comments_url":"https://api.github.com/repos/opencog/atomspace/pulls/178/comments","review_comment_url":"https://api.github.com/repos/opencog/atomspace/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencog/atomspace/issues/178/comments","statuses_url":"https://api.github.com/repos/opencog/atomspace/statuses/020a151af08b8fdad9b9081e5b7bd119a98fd92e","head":{"label":"jswiergo:sl_crash_2","ref":"sl_crash_2","sha":"020a151af08b8fdad9b9081e5b7bd119a98fd92e","user":{"login":"jswiergo","id":2552224,"avatar_url":"https://avatars.githubusercontent.com/u/2552224?v=3","gravatar_id":"","url":"https://api.github.com/users/jswiergo","html_url":"https://github.com/jswiergo","followers_url":"https://api.github.com/users/jswiergo/followers","following_url":"https://api.github.com/users/jswiergo/following{/other_user}","gists_url":"https://api.github.com/users/jswiergo/gists{/gist_id}","starred_url":"https://api.github.com/users/jswiergo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jswiergo/subscriptions","organizations_url":"https://api.github.com/users/jswiergo/orgs","repos_url":"https://api.github.com/users/jswiergo/repos","events_url":"https://api.github.com/users/jswiergo/events{/privacy}","received_events_url":"https://api.github.com/users/jswiergo/received_events","type":"User","site_admin":false},"repo":{"id":37784524,"name":"atomspace","full_name":"jswiergo/atomspace","owner":{"login":"jswiergo","id":2552224,"avatar_url":"https://avatars.githubusercontent.com/u/2552224?v=3","gravatar_id":"","url":"https://api.github.com/users/jswiergo","html_url":"https://github.com/jswiergo","followers_url":"https://api.github.com/users/jswiergo/followers","following_url":"https://api.github.com/users/jswiergo/following{/other_user}","gists_url":"https://api.github.com/users/jswiergo/gists{/gist_id}","starred_url":"https://api.github.com/users/jswiergo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jswiergo/subscriptions","organizations_url":"https://api.github.com/users/jswiergo/orgs","repos_url":"https://api.github.com/users/jswiergo/repos","events_url":"https://api.github.com/users/jswiergo/events{/privacy}","received_events_url":"https://api.github.com/users/jswiergo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jswiergo/atomspace","description":"The OpenCog hypergraph database and logic (reasoning) engine","fork":true,"url":"https://api.github.com/repos/jswiergo/atomspace","forks_url":"https://api.github.com/repos/jswiergo/atomspace/forks","keys_url":"https://api.github.com/repos/jswiergo/atomspace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jswiergo/atomspace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jswiergo/atomspace/teams","hooks_url":"https://api.github.com/repos/jswiergo/atomspace/hooks","issue_events_url":"https://api.github.com/repos/jswiergo/atomspace/issues/events{/number}","events_url":"https://api.github.com/repos/jswiergo/atomspace/events","assignees_url":"https://api.github.com/repos/jswiergo/atomspace/assignees{/user}","branches_url":"https://api.github.com/repos/jswiergo/atomspace/branches{/branch}","tags_url":"https://api.github.com/repos/jswiergo/atomspace/tags","blobs_url":"https://api.github.com/repos/jswiergo/atomspace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jswiergo/atomspace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jswiergo/atomspace/git/refs{/sha}","trees_url":"https://api.github.com/repos/jswiergo/atomspace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jswiergo/atomspace/statuses/{sha}","languages_url":"https://api.github.com/repos/jswiergo/atomspace/languages","stargazers_url":"https://api.github.com/repos/jswiergo/atomspace/stargazers","contributors_url":"https://api.github.com/repos/jswiergo/atomspace/contributors","subscribers_url":"https://api.github.com/repos/jswiergo/atomspace/subscribers","subscription_url":"https://api.github.com/repos/jswiergo/atomspace/subscription","commits_url":"https://api.github.com/repos/jswiergo/atomspace/commits{/sha}","git_commits_url":"https://api.github.com/repos/jswiergo/atomspace/git/commits{/sha}","comments_url":"https://api.github.com/repos/jswiergo/atomspace/comments{/number}","issue_comment_url":"https://api.github.com/repos/jswiergo/atomspace/issues/comments{/number}","contents_url":"https://api.github.com/repos/jswiergo/atomspace/contents/{+path}","compare_url":"https://api.github.com/repos/jswiergo/atomspace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jswiergo/atomspace/merges","archive_url":"https://api.github.com/repos/jswiergo/atomspace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jswiergo/atomspace/downloads","issues_url":"https://api.github.com/repos/jswiergo/atomspace/issues{/number}","pulls_url":"https://api.github.com/repos/jswiergo/atomspace/pulls{/number}","milestones_url":"https://api.github.com/repos/jswiergo/atomspace/milestones{/number}","notifications_url":"https://api.github.com/repos/jswiergo/atomspace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jswiergo/atomspace/labels{/name}","releases_url":"https://api.github.com/repos/jswiergo/atomspace/releases{/id}","created_at":"2015-06-20T20:19:04Z","updated_at":"2015-06-20T20:19:07Z","pushed_at":"2015-07-30T15:45:49Z","git_url":"git://github.com/jswiergo/atomspace.git","ssh_url":"git@github.com:jswiergo/atomspace.git","clone_url":"https://github.com/jswiergo/atomspace.git","svn_url":"https://github.com/jswiergo/atomspace","homepage":"","size":139686,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opencog:master","ref":"master","sha":"7941969c9842131668493b4c7456550622568876","user":{"login":"opencog","id":2109913,"avatar_url":"https://avatars.githubusercontent.com/u/2109913?v=3","gravatar_id":"","url":"https://api.github.com/users/opencog","html_url":"https://github.com/opencog","followers_url":"https://api.github.com/users/opencog/followers","following_url":"https://api.github.com/users/opencog/following{/other_user}","gists_url":"https://api.github.com/users/opencog/gists{/gist_id}","starred_url":"https://api.github.com/users/opencog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencog/subscriptions","organizations_url":"https://api.github.com/users/opencog/orgs","repos_url":"https://api.github.com/users/opencog/repos","events_url":"https://api.github.com/users/opencog/events{/privacy}","received_events_url":"https://api.github.com/users/opencog/received_events","type":"Organization","site_admin":false},"repo":{"id":34678084,"name":"atomspace","full_name":"opencog/atomspace","owner":{"login":"opencog","id":2109913,"avatar_url":"https://avatars.githubusercontent.com/u/2109913?v=3","gravatar_id":"","url":"https://api.github.com/users/opencog","html_url":"https://github.com/opencog","followers_url":"https://api.github.com/users/opencog/followers","following_url":"https://api.github.com/users/opencog/following{/other_user}","gists_url":"https://api.github.com/users/opencog/gists{/gist_id}","starred_url":"https://api.github.com/users/opencog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencog/subscriptions","organizations_url":"https://api.github.com/users/opencog/orgs","repos_url":"https://api.github.com/users/opencog/repos","events_url":"https://api.github.com/users/opencog/events{/privacy}","received_events_url":"https://api.github.com/users/opencog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opencog/atomspace","description":"The OpenCog hypergraph database and logic (reasoning) engine","fork":false,"url":"https://api.github.com/repos/opencog/atomspace","forks_url":"https://api.github.com/repos/opencog/atomspace/forks","keys_url":"https://api.github.com/repos/opencog/atomspace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencog/atomspace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencog/atomspace/teams","hooks_url":"https://api.github.com/repos/opencog/atomspace/hooks","issue_events_url":"https://api.github.com/repos/opencog/atomspace/issues/events{/number}","events_url":"https://api.github.com/repos/opencog/atomspace/events","assignees_url":"https://api.github.com/repos/opencog/atomspace/assignees{/user}","branches_url":"https://api.github.com/repos/opencog/atomspace/branches{/branch}","tags_url":"https://api.github.com/repos/opencog/atomspace/tags","blobs_url":"https://api.github.com/repos/opencog/atomspace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencog/atomspace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencog/atomspace/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencog/atomspace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencog/atomspace/statuses/{sha}","languages_url":"https://api.github.com/repos/opencog/atomspace/languages","stargazers_url":"https://api.github.com/repos/opencog/atomspace/stargazers","contributors_url":"https://api.github.com/repos/opencog/atomspace/contributors","subscribers_url":"https://api.github.com/repos/opencog/atomspace/subscribers","subscription_url":"https://api.github.com/repos/opencog/atomspace/subscription","commits_url":"https://api.github.com/repos/opencog/atomspace/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencog/atomspace/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencog/atomspace/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencog/atomspace/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencog/atomspace/contents/{+path}","compare_url":"https://api.github.com/repos/opencog/atomspace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencog/atomspace/merges","archive_url":"https://api.github.com/repos/opencog/atomspace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencog/atomspace/downloads","issues_url":"https://api.github.com/repos/opencog/atomspace/issues{/number}","pulls_url":"https://api.github.com/repos/opencog/atomspace/pulls{/number}","milestones_url":"https://api.github.com/repos/opencog/atomspace/milestones{/number}","notifications_url":"https://api.github.com/repos/opencog/atomspace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencog/atomspace/labels{/name}","releases_url":"https://api.github.com/repos/opencog/atomspace/releases{/id}","created_at":"2015-04-27T16:32:57Z","updated_at":"2015-07-03T22:05:36Z","pushed_at":"2015-07-30T15:39:48Z","git_url":"git://github.com/opencog/atomspace.git","ssh_url":"git@github.com:opencog/atomspace.git","clone_url":"https://github.com/opencog/atomspace.git","svn_url":"https://github.com/opencog/atomspace","homepage":"","size":150132,"stargazers_count":13,"watchers_count":13,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":33,"forks":23,"open_issues":33,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencog/atomspace/pulls/178"},"html":{"href":"https://github.com/opencog/atomspace/pull/178"},"issue":{"href":"https://api.github.com/repos/opencog/atomspace/issues/178"},"comments":{"href":"https://api.github.com/repos/opencog/atomspace/issues/178/comments"},"review_comments":{"href":"https://api.github.com/repos/opencog/atomspace/pulls/178/comments"},"review_comment":{"href":"https://api.github.com/repos/opencog/atomspace/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencog/atomspace/pulls/178/commits"},"statuses":{"href":"https://api.github.com/repos/opencog/atomspace/statuses/020a151af08b8fdad9b9081e5b7bd119a98fd92e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":25,"deletions":3,"changed_files":2}}