{"action":"created","issue":{"url":"https://api.github.com/repos/nasa/openmctweb/issues/371","labels_url":"https://api.github.com/repos/nasa/openmctweb/issues/371/labels{/name}","comments_url":"https://api.github.com/repos/nasa/openmctweb/issues/371/comments","events_url":"https://api.github.com/repos/nasa/openmctweb/issues/371/events","html_url":"https://github.com/nasa/openmctweb/pull/371","id":120299741,"number":371,"title":"#338 [Copy] Copying an object with telemetry from the data dictionary results in a number of unknown objects in copied tree","user":{"login":"akhenry","id":4215777,"avatar_url":"https://avatars.githubusercontent.com/u/4215777?v=3","gravatar_id":"","url":"https://api.github.com/users/akhenry","html_url":"https://github.com/akhenry","followers_url":"https://api.github.com/users/akhenry/followers","following_url":"https://api.github.com/users/akhenry/following{/other_user}","gists_url":"https://api.github.com/users/akhenry/gists{/gist_id}","starred_url":"https://api.github.com/users/akhenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhenry/subscriptions","organizations_url":"https://api.github.com/users/akhenry/orgs","repos_url":"https://api.github.com/users/akhenry/repos","events_url":"https://api.github.com/users/akhenry/events{/privacy}","received_events_url":"https://api.github.com/users/akhenry/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"VWoeltjen","id":1685764,"avatar_url":"https://avatars.githubusercontent.com/u/1685764?v=3","gravatar_id":"","url":"https://api.github.com/users/VWoeltjen","html_url":"https://github.com/VWoeltjen","followers_url":"https://api.github.com/users/VWoeltjen/followers","following_url":"https://api.github.com/users/VWoeltjen/following{/other_user}","gists_url":"https://api.github.com/users/VWoeltjen/gists{/gist_id}","starred_url":"https://api.github.com/users/VWoeltjen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VWoeltjen/subscriptions","organizations_url":"https://api.github.com/users/VWoeltjen/orgs","repos_url":"https://api.github.com/users/VWoeltjen/repos","events_url":"https://api.github.com/users/VWoeltjen/events{/privacy}","received_events_url":"https://api.github.com/users/VWoeltjen/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2015-12-03T23:53:22Z","updated_at":"2015-12-04T17:46:30Z","closed_at":"2015-12-04T17:46:25Z","pull_request":{"url":"https://api.github.com/repos/nasa/openmctweb/pulls/371","html_url":"https://github.com/nasa/openmctweb/pull/371","diff_url":"https://github.com/nasa/openmctweb/pull/371.diff","patch_url":"https://github.com/nasa/openmctweb/pull/371.patch"},"body":"Summary of changes:\r\n* Created a new creation policy category and instance that returns true if tested object hasFeature('creation')`\r\n* Modified the `CopyService` to use the persistence space of the copy target, not the object being copied\r\n* Modified the CreateActionProvider to use new CreationPolicy\r\n* Modified the `CopyService` to use the CreationPolicy to check whether a new object or a link should be created for the type of the object being copied.\r\n* Added tests for CreationPolicy\r\n* Added a new test case to test that duplication of non-createable types creates links (addresses https://github.com/nasa/openmctweb/issues/338#issuecomment-159353004 )\r\n* Some minor refactoring of CopyService and CopyTask. Would suggest that use of instantiationCapability actually allows for more fundamental re-architecture of CopyTask that could significantly reduce LOC, but I'll leave this for a future release.\r\n\r\n### Author Checklist\r\n\r\n1. Changes address original issue? __Y__\r\n2. Unit tests included and/or updated with changes? __Y__\r\n3. Command line build passes? __Y__\r\n4. Expect to pass code review? __Y__"},"comment":{"url":"https://api.github.com/repos/nasa/openmctweb/issues/comments/162032761","html_url":"https://github.com/nasa/openmctweb/pull/371#issuecomment-162032761","issue_url":"https://api.github.com/repos/nasa/openmctweb/issues/371","id":162032761,"user":{"login":"VWoeltjen","id":1685764,"avatar_url":"https://avatars.githubusercontent.com/u/1685764?v=3","gravatar_id":"","url":"https://api.github.com/users/VWoeltjen","html_url":"https://github.com/VWoeltjen","followers_url":"https://api.github.com/users/VWoeltjen/followers","following_url":"https://api.github.com/users/VWoeltjen/following{/other_user}","gists_url":"https://api.github.com/users/VWoeltjen/gists{/gist_id}","starred_url":"https://api.github.com/users/VWoeltjen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VWoeltjen/subscriptions","organizations_url":"https://api.github.com/users/VWoeltjen/orgs","repos_url":"https://api.github.com/users/VWoeltjen/repos","events_url":"https://api.github.com/users/VWoeltjen/events{/privacy}","received_events_url":"https://api.github.com/users/VWoeltjen/received_events","type":"User","site_admin":false},"created_at":"2015-12-04T17:46:30Z","updated_at":"2015-12-04T17:46:30Z","body":"### Reviewer Checklist\r\n\r\n1. Changes appear to address issue? Y\r\n2. Appropriate unit tests included? Y\r\n3. Code style and in-line documentation are appropriate? Y\r\n4. Commit messages meet standards? Y\r\n"}}