{"action":"created","issue":{"url":"https://api.github.com/repos/twilio/twilio-ruby/issues/148","labels_url":"https://api.github.com/repos/twilio/twilio-ruby/issues/148/labels{/name}","comments_url":"https://api.github.com/repos/twilio/twilio-ruby/issues/148/comments","events_url":"https://api.github.com/repos/twilio/twilio-ruby/issues/148/events","html_url":"https://github.com/twilio/twilio-ruby/pull/148","id":69473789,"number":148,"title":"Stops rescuing Exception, rescues StandardError instead.","user":{"login":"philnash","id":31462,"avatar_url":"https://avatars.githubusercontent.com/u/31462?v=3","gravatar_id":"","url":"https://api.github.com/users/philnash","html_url":"https://github.com/philnash","followers_url":"https://api.github.com/users/philnash/followers","following_url":"https://api.github.com/users/philnash/following{/other_user}","gists_url":"https://api.github.com/users/philnash/gists{/gist_id}","starred_url":"https://api.github.com/users/philnash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philnash/subscriptions","organizations_url":"https://api.github.com/users/philnash/orgs","repos_url":"https://api.github.com/users/philnash/repos","events_url":"https://api.github.com/users/philnash/events{/privacy}","received_events_url":"https://api.github.com/users/philnash/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-19T23:10:37Z","updated_at":"2015-04-20T15:46:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/twilio/twilio-ruby/pulls/148","html_url":"https://github.com/twilio/twilio-ruby/pull/148","diff_url":"https://github.com/twilio/twilio-ruby/pull/148.diff","patch_url":"https://github.com/twilio/twilio-ruby/pull/148.patch"},"body":"[You shouldn't rescue `Exception` in Ruby](http://daniel.fone.net.nz/blog/2013/05/28/why-you-should-never-rescue-exception-in-ruby/). It will rescue `NoMemoryError` and `Interrupt` and others you don't really want to rescue from in this case. `StandardError`, which is the default when just using `rescue`, is better, but ideally this would rescue specific errors that we want to rescue from. Perhaps looking at [Faraday's list of errors](https://github.com/lostisland/faraday/blob/1d71fcab65d0baa0e8abeb26d819856f7d29356d/lib/faraday/adapter/net_http.rb#L12-L24) or [this suggestion from Tammer Saleh](http://tammersaleh.com/posts/rescuing-net-http-exceptions/) would be better. The least we can do is stop rescuing `Exception` though."},"comment":{"url":"https://api.github.com/repos/twilio/twilio-ruby/issues/comments/94489060","html_url":"https://github.com/twilio/twilio-ruby/pull/148#issuecomment-94489060","issue_url":"https://api.github.com/repos/twilio/twilio-ruby/issues/148","id":94489060,"user":{"login":"skimbrel","id":484269,"avatar_url":"https://avatars.githubusercontent.com/u/484269?v=3","gravatar_id":"","url":"https://api.github.com/users/skimbrel","html_url":"https://github.com/skimbrel","followers_url":"https://api.github.com/users/skimbrel/followers","following_url":"https://api.github.com/users/skimbrel/following{/other_user}","gists_url":"https://api.github.com/users/skimbrel/gists{/gist_id}","starred_url":"https://api.github.com/users/skimbrel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skimbrel/subscriptions","organizations_url":"https://api.github.com/users/skimbrel/orgs","repos_url":"https://api.github.com/users/skimbrel/repos","events_url":"https://api.github.com/users/skimbrel/events{/privacy}","received_events_url":"https://api.github.com/users/skimbrel/received_events","type":"User","site_admin":false},"created_at":"2015-04-20T15:46:04Z","updated_at":"2015-04-20T15:46:04Z","body":"+1"}}