{"action":"closed","number":4816,"pull_request":{"url":"https://api.github.com/repos/ember-cli/ember-cli/pulls/4816","id":44496597,"html_url":"https://github.com/ember-cli/ember-cli/pull/4816","diff_url":"https://github.com/ember-cli/ember-cli/pull/4816.diff","patch_url":"https://github.com/ember-cli/ember-cli/pull/4816.patch","issue_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/4816","number":4816,"state":"closed","locked":false,"title":"[ENHANCEMENT] Allow OS to choose ephemeral port if --test-port=0","user":{"login":"williamsbdev","id":2402655,"avatar_url":"https://avatars.githubusercontent.com/u/2402655?v=3","gravatar_id":"","url":"https://api.github.com/users/williamsbdev","html_url":"https://github.com/williamsbdev","followers_url":"https://api.github.com/users/williamsbdev/followers","following_url":"https://api.github.com/users/williamsbdev/following{/other_user}","gists_url":"https://api.github.com/users/williamsbdev/gists{/gist_id}","starred_url":"https://api.github.com/users/williamsbdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williamsbdev/subscriptions","organizations_url":"https://api.github.com/users/williamsbdev/orgs","repos_url":"https://api.github.com/users/williamsbdev/repos","events_url":"https://api.github.com/users/williamsbdev/events{/privacy}","received_events_url":"https://api.github.com/users/williamsbdev/received_events","type":"User","site_admin":false},"body":"We ran into this problem on our CI server as we have many ember project build running at the same time and colliding on the default port. We started getting tricky by trying to bind to a port prior to running the tests but then we still ended up with weird race conditions. If we are allowed to pass 0, the OS will choose an open port at the time of test execution. We were unable to set the `--test-port=0` as the check in the `TestCommand` was a simple truthy check that would fail if it was set to `0`. With the modification to check if it is an int, we will be able to pass 0 through.","created_at":"2015-09-08T23:49:00Z","updated_at":"2015-09-13T03:05:07Z","closed_at":"2015-09-13T03:05:07Z","merged_at":"2015-09-13T03:05:07Z","merge_commit_sha":"1998854ec90e298d7b5c12eaa5659d6d9ef1a5d4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ember-cli/ember-cli/pulls/4816/commits","review_comments_url":"https://api.github.com/repos/ember-cli/ember-cli/pulls/4816/comments","review_comment_url":"https://api.github.com/repos/ember-cli/ember-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/4816/comments","statuses_url":"https://api.github.com/repos/ember-cli/ember-cli/statuses/d508e7e85c1762cfc315299506b7f2597ae3a075","head":{"label":"williamsbdev:master","ref":"master","sha":"d508e7e85c1762cfc315299506b7f2597ae3a075","user":{"login":"williamsbdev","id":2402655,"avatar_url":"https://avatars.githubusercontent.com/u/2402655?v=3","gravatar_id":"","url":"https://api.github.com/users/williamsbdev","html_url":"https://github.com/williamsbdev","followers_url":"https://api.github.com/users/williamsbdev/followers","following_url":"https://api.github.com/users/williamsbdev/following{/other_user}","gists_url":"https://api.github.com/users/williamsbdev/gists{/gist_id}","starred_url":"https://api.github.com/users/williamsbdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williamsbdev/subscriptions","organizations_url":"https://api.github.com/users/williamsbdev/orgs","repos_url":"https://api.github.com/users/williamsbdev/repos","events_url":"https://api.github.com/users/williamsbdev/events{/privacy}","received_events_url":"https://api.github.com/users/williamsbdev/received_events","type":"User","site_admin":false},"repo":{"id":31836615,"name":"ember-cli","full_name":"williamsbdev/ember-cli","owner":{"login":"williamsbdev","id":2402655,"avatar_url":"https://avatars.githubusercontent.com/u/2402655?v=3","gravatar_id":"","url":"https://api.github.com/users/williamsbdev","html_url":"https://github.com/williamsbdev","followers_url":"https://api.github.com/users/williamsbdev/followers","following_url":"https://api.github.com/users/williamsbdev/following{/other_user}","gists_url":"https://api.github.com/users/williamsbdev/gists{/gist_id}","starred_url":"https://api.github.com/users/williamsbdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williamsbdev/subscriptions","organizations_url":"https://api.github.com/users/williamsbdev/orgs","repos_url":"https://api.github.com/users/williamsbdev/repos","events_url":"https://api.github.com/users/williamsbdev/events{/privacy}","received_events_url":"https://api.github.com/users/williamsbdev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/williamsbdev/ember-cli","description":"","fork":true,"url":"https://api.github.com/repos/williamsbdev/ember-cli","forks_url":"https://api.github.com/repos/williamsbdev/ember-cli/forks","keys_url":"https://api.github.com/repos/williamsbdev/ember-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/williamsbdev/ember-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/williamsbdev/ember-cli/teams","hooks_url":"https://api.github.com/repos/williamsbdev/ember-cli/hooks","issue_events_url":"https://api.github.com/repos/williamsbdev/ember-cli/issues/events{/number}","events_url":"https://api.github.com/repos/williamsbdev/ember-cli/events","assignees_url":"https://api.github.com/repos/williamsbdev/ember-cli/assignees{/user}","branches_url":"https://api.github.com/repos/williamsbdev/ember-cli/branches{/branch}","tags_url":"https://api.github.com/repos/williamsbdev/ember-cli/tags","blobs_url":"https://api.github.com/repos/williamsbdev/ember-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/williamsbdev/ember-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/williamsbdev/ember-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/williamsbdev/ember-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/williamsbdev/ember-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/williamsbdev/ember-cli/languages","stargazers_url":"https://api.github.com/repos/williamsbdev/ember-cli/stargazers","contributors_url":"https://api.github.com/repos/williamsbdev/ember-cli/contributors","subscribers_url":"https://api.github.com/repos/williamsbdev/ember-cli/subscribers","subscription_url":"https://api.github.com/repos/williamsbdev/ember-cli/subscription","commits_url":"https://api.github.com/repos/williamsbdev/ember-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/williamsbdev/ember-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/williamsbdev/ember-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/williamsbdev/ember-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/williamsbdev/ember-cli/contents/{+path}","compare_url":"https://api.github.com/repos/williamsbdev/ember-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/williamsbdev/ember-cli/merges","archive_url":"https://api.github.com/repos/williamsbdev/ember-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/williamsbdev/ember-cli/downloads","issues_url":"https://api.github.com/repos/williamsbdev/ember-cli/issues{/number}","pulls_url":"https://api.github.com/repos/williamsbdev/ember-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/williamsbdev/ember-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/williamsbdev/ember-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/williamsbdev/ember-cli/labels{/name}","releases_url":"https://api.github.com/repos/williamsbdev/ember-cli/releases{/id}","created_at":"2015-03-08T03:10:41Z","updated_at":"2015-03-08T03:25:32Z","pushed_at":"2015-09-11T02:56:37Z","git_url":"git://github.com/williamsbdev/ember-cli.git","ssh_url":"git@github.com:williamsbdev/ember-cli.git","clone_url":"https://github.com/williamsbdev/ember-cli.git","svn_url":"https://github.com/williamsbdev/ember-cli","homepage":"http://www.ember-cli.com/","size":8114,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ember-cli:master","ref":"master","sha":"5e5d767411e6a3b3aeeb68a22103ee4c790ddad6","user":{"login":"ember-cli","id":10262982,"avatar_url":"https://avatars.githubusercontent.com/u/10262982?v=3","gravatar_id":"","url":"https://api.github.com/users/ember-cli","html_url":"https://github.com/ember-cli","followers_url":"https://api.github.com/users/ember-cli/followers","following_url":"https://api.github.com/users/ember-cli/following{/other_user}","gists_url":"https://api.github.com/users/ember-cli/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-cli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-cli/subscriptions","organizations_url":"https://api.github.com/users/ember-cli/orgs","repos_url":"https://api.github.com/users/ember-cli/repos","events_url":"https://api.github.com/users/ember-cli/events{/privacy}","received_events_url":"https://api.github.com/users/ember-cli/received_events","type":"Organization","site_admin":false},"repo":{"id":14089735,"name":"ember-cli","full_name":"ember-cli/ember-cli","owner":{"login":"ember-cli","id":10262982,"avatar_url":"https://avatars.githubusercontent.com/u/10262982?v=3","gravatar_id":"","url":"https://api.github.com/users/ember-cli","html_url":"https://github.com/ember-cli","followers_url":"https://api.github.com/users/ember-cli/followers","following_url":"https://api.github.com/users/ember-cli/following{/other_user}","gists_url":"https://api.github.com/users/ember-cli/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-cli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-cli/subscriptions","organizations_url":"https://api.github.com/users/ember-cli/orgs","repos_url":"https://api.github.com/users/ember-cli/repos","events_url":"https://api.github.com/users/ember-cli/events{/privacy}","received_events_url":"https://api.github.com/users/ember-cli/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ember-cli/ember-cli","description":"","fork":false,"url":"https://api.github.com/repos/ember-cli/ember-cli","forks_url":"https://api.github.com/repos/ember-cli/ember-cli/forks","keys_url":"https://api.github.com/repos/ember-cli/ember-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ember-cli/ember-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ember-cli/ember-cli/teams","hooks_url":"https://api.github.com/repos/ember-cli/ember-cli/hooks","issue_events_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/events{/number}","events_url":"https://api.github.com/repos/ember-cli/ember-cli/events","assignees_url":"https://api.github.com/repos/ember-cli/ember-cli/assignees{/user}","branches_url":"https://api.github.com/repos/ember-cli/ember-cli/branches{/branch}","tags_url":"https://api.github.com/repos/ember-cli/ember-cli/tags","blobs_url":"https://api.github.com/repos/ember-cli/ember-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ember-cli/ember-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ember-cli/ember-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/ember-cli/ember-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ember-cli/ember-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/ember-cli/ember-cli/languages","stargazers_url":"https://api.github.com/repos/ember-cli/ember-cli/stargazers","contributors_url":"https://api.github.com/repos/ember-cli/ember-cli/contributors","subscribers_url":"https://api.github.com/repos/ember-cli/ember-cli/subscribers","subscription_url":"https://api.github.com/repos/ember-cli/ember-cli/subscription","commits_url":"https://api.github.com/repos/ember-cli/ember-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/ember-cli/ember-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/ember-cli/ember-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/ember-cli/ember-cli/contents/{+path}","compare_url":"https://api.github.com/repos/ember-cli/ember-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ember-cli/ember-cli/merges","archive_url":"https://api.github.com/repos/ember-cli/ember-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ember-cli/ember-cli/downloads","issues_url":"https://api.github.com/repos/ember-cli/ember-cli/issues{/number}","pulls_url":"https://api.github.com/repos/ember-cli/ember-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/ember-cli/ember-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/ember-cli/ember-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ember-cli/ember-cli/labels{/name}","releases_url":"https://api.github.com/repos/ember-cli/ember-cli/releases{/id}","created_at":"2013-11-03T17:34:43Z","updated_at":"2015-09-11T19:47:56Z","pushed_at":"2015-09-13T03:05:07Z","git_url":"git://github.com/ember-cli/ember-cli.git","ssh_url":"git@github.com:ember-cli/ember-cli.git","clone_url":"https://github.com/ember-cli/ember-cli.git","svn_url":"https://github.com/ember-cli/ember-cli","homepage":"http://www.ember-cli.com/","size":28987,"stargazers_count":2518,"watchers_count":2518,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":720,"mirror_url":null,"open_issues_count":318,"forks":720,"open_issues":318,"watchers":2518,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ember-cli/ember-cli/pulls/4816"},"html":{"href":"https://github.com/ember-cli/ember-cli/pull/4816"},"issue":{"href":"https://api.github.com/repos/ember-cli/ember-cli/issues/4816"},"comments":{"href":"https://api.github.com/repos/ember-cli/ember-cli/issues/4816/comments"},"review_comments":{"href":"https://api.github.com/repos/ember-cli/ember-cli/pulls/4816/comments"},"review_comment":{"href":"https://api.github.com/repos/ember-cli/ember-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ember-cli/ember-cli/pulls/4816/commits"},"statuses":{"href":"https://api.github.com/repos/ember-cli/ember-cli/statuses/d508e7e85c1762cfc315299506b7f2597ae3a075"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"stefanpenner","id":1377,"avatar_url":"https://avatars.githubusercontent.com/u/1377?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanpenner","html_url":"https://github.com/stefanpenner","followers_url":"https://api.github.com/users/stefanpenner/followers","following_url":"https://api.github.com/users/stefanpenner/following{/other_user}","gists_url":"https://api.github.com/users/stefanpenner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanpenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanpenner/subscriptions","organizations_url":"https://api.github.com/users/stefanpenner/orgs","repos_url":"https://api.github.com/users/stefanpenner/repos","events_url":"https://api.github.com/users/stefanpenner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanpenner/received_events","type":"User","site_admin":false},"comments":8,"review_comments":0,"commits":2,"additions":29,"deletions":5,"changed_files":4}}