{"action":"created","issue":{"url":"https://api.github.com/repos/pydata/pandas/issues/10070","labels_url":"https://api.github.com/repos/pydata/pandas/issues/10070/labels{/name}","comments_url":"https://api.github.com/repos/pydata/pandas/issues/10070/comments","events_url":"https://api.github.com/repos/pydata/pandas/issues/10070/events","html_url":"https://github.com/pydata/pandas/pull/10070","id":73677577,"number":10070,"title":"BUG make take_nd support readonly arrays","user":{"login":"ogrisel","id":89061,"avatar_url":"https://avatars.githubusercontent.com/u/89061?v=3","gravatar_id":"","url":"https://api.github.com/users/ogrisel","html_url":"https://github.com/ogrisel","followers_url":"https://api.github.com/users/ogrisel/followers","following_url":"https://api.github.com/users/ogrisel/following{/other_user}","gists_url":"https://api.github.com/users/ogrisel/gists{/gist_id}","starred_url":"https://api.github.com/users/ogrisel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogrisel/subscriptions","organizations_url":"https://api.github.com/users/ogrisel/orgs","repos_url":"https://api.github.com/users/ogrisel/repos","events_url":"https://api.github.com/users/ogrisel/events{/privacy}","received_events_url":"https://api.github.com/users/ogrisel/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/pydata/pandas/labels/Indexing","name":"Indexing","color":"0b02e1"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/pydata/pandas/milestones/29","html_url":"https://github.com/pydata/pandas/milestones/0.16.1","labels_url":"https://api.github.com/repos/pydata/pandas/milestones/29/labels","id":816810,"number":29,"title":"0.16.1","description":"after 0.16.0 of course!","creator":{"login":"jreback","id":953992,"avatar_url":"https://avatars.githubusercontent.com/u/953992?v=3","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":200,"state":"open","created_at":"2014-10-07T14:39:07Z","updated_at":"2015-05-07T00:20:22Z","due_on":"2015-05-08T04:00:00Z","closed_at":null},"comments":7,"created_at":"2015-05-06T16:57:21Z","updated_at":"2015-05-07T06:51:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pydata/pandas/pulls/10070","html_url":"https://github.com/pydata/pandas/pull/10070","diff_url":"https://github.com/pydata/pandas/pull/10070.diff","patch_url":"https://github.com/pydata/pandas/pull/10070.patch"},"body":"This is a tentative fix for #10043. I have not run any benchmark yet. I think we should do that before considering merging this PR. Any recommended way to do it?"},"comment":{"url":"https://api.github.com/repos/pydata/pandas/issues/comments/99746630","html_url":"https://github.com/pydata/pandas/pull/10070#issuecomment-99746630","issue_url":"https://api.github.com/repos/pydata/pandas/issues/10070","id":99746630,"user":{"login":"ogrisel","id":89061,"avatar_url":"https://avatars.githubusercontent.com/u/89061?v=3","gravatar_id":"","url":"https://api.github.com/users/ogrisel","html_url":"https://github.com/ogrisel","followers_url":"https://api.github.com/users/ogrisel/followers","following_url":"https://api.github.com/users/ogrisel/following{/other_user}","gists_url":"https://api.github.com/users/ogrisel/gists{/gist_id}","starred_url":"https://api.github.com/users/ogrisel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogrisel/subscriptions","organizations_url":"https://api.github.com/users/ogrisel/orgs","repos_url":"https://api.github.com/users/ogrisel/repos","events_url":"https://api.github.com/users/ogrisel/events{/privacy}","received_events_url":"https://api.github.com/users/ogrisel/received_events","type":"User","site_admin":false},"created_at":"2015-05-07T06:51:06Z","updated_at":"2015-05-07T06:51:06Z","body":"Great! But before merging you might want to consider @richardhansen's comment at https://github.com/pydata/pandas/issues/10043#issuecomment-99659064. We should check whether this alternative solution can work on read-only `np.memmap` instances.\r\n\r\n> FYI I tried to change this to general 2 separate cython function and disambiguate at a higher level, but then I had to fix more stuff....so this is a nice work-around.\r\n\r\nI tried that as well initially but rolled back my changes why I saw the amount of code to edit on the Python side."}}