{"action":"created","comment":{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/comments/25170126","id":25170126,"diff_hunk":"@@ -1814,13 +1813,29 @@ client createSession(String userName, String password, String hostName,\n \t{\n \t\tthis.encrypted = encrypted;\n \t\tclient secureClient = null;\n+\t\t\n \t\ttry {\n \t\t    // client must be cleaned up by caller.\n-\t\t\tif (port > 0) secureClient = new client(hostName, port);\n-\t\t\telse secureClient = new client(hostName);\n-\t\t\tsecureClient.setAgent(agentName);\n-\t\t\tServiceFactoryPrx entryEncrypted\n-\t\t\t    = secureClient.createSession(userName, password);\n+\t\t    if (port > 0) secureClient = new client(hostName, port);\n+\t\t    else secureClient = new client(hostName);\n+\t\t    secureClient.setAgent(agentName);\n+\t\t    ServiceFactoryPrx entryEncrypted;\n+\t\t    boolean session = true;\n+\t\t    try {\n+\t\t        //Check if it is a session first\n+\t\t        ServiceFactoryPrx guestSession = secureClient.createSession(\"guest\", \"guest\");","path":"components/insight/SRC/org/openmicroscopy/shoola/env/data/OMEROGateway.java","position":48,"original_position":48,"commit_id":"29c1bf604ed95f3d80ee86756edc568c9049bed2","original_commit_id":"29c1bf604ed95f3d80ee86756edc568c9049bed2","user":{"login":"aleksandra-tarkowska","id":1065155,"avatar_url":"https://avatars.githubusercontent.com/u/1065155?v=3","gravatar_id":"","url":"https://api.github.com/users/aleksandra-tarkowska","html_url":"https://github.com/aleksandra-tarkowska","followers_url":"https://api.github.com/users/aleksandra-tarkowska/followers","following_url":"https://api.github.com/users/aleksandra-tarkowska/following{/other_user}","gists_url":"https://api.github.com/users/aleksandra-tarkowska/gists{/gist_id}","starred_url":"https://api.github.com/users/aleksandra-tarkowska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleksandra-tarkowska/subscriptions","organizations_url":"https://api.github.com/users/aleksandra-tarkowska/orgs","repos_url":"https://api.github.com/users/aleksandra-tarkowska/repos","events_url":"https://api.github.com/users/aleksandra-tarkowska/events{/privacy}","received_events_url":"https://api.github.com/users/aleksandra-tarkowska/received_events","type":"User","site_admin":false},"body":"isn't better to use ```getAdminService().getSecurityRoles()```","created_at":"2015-02-23T15:06:31Z","updated_at":"2015-02-23T15:06:31Z","html_url":"https://github.com/openmicroscopy/openmicroscopy/pull/3506#discussion_r25170126","pull_request_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/3506","_links":{"self":{"href":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/comments/25170126"},"html":{"href":"https://github.com/openmicroscopy/openmicroscopy/pull/3506#discussion_r25170126"},"pull_request":{"href":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/3506"}}},"pull_request":{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/3506","id":29612360,"html_url":"https://github.com/openmicroscopy/openmicroscopy/pull/3506","diff_url":"https://github.com/openmicroscopy/openmicroscopy/pull/3506.diff","patch_url":"https://github.com/openmicroscopy/openmicroscopy/pull/3506.patch","issue_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/3506","number":3506,"state":"open","locked":false,"title":"Connect with session ID","user":{"login":"jburel","id":1022396,"avatar_url":"https://avatars.githubusercontent.com/u/1022396?v=3","gravatar_id":"","url":"https://api.github.com/users/jburel","html_url":"https://github.com/jburel","followers_url":"https://api.github.com/users/jburel/followers","following_url":"https://api.github.com/users/jburel/following{/other_user}","gists_url":"https://api.github.com/users/jburel/gists{/gist_id}","starred_url":"https://api.github.com/users/jburel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jburel/subscriptions","organizations_url":"https://api.github.com/users/jburel/orgs","repos_url":"https://api.github.com/users/jburel/repos","events_url":"https://api.github.com/users/jburel/events{/privacy}","received_events_url":"https://api.github.com/users/jburel/received_events","type":"User","site_admin":false},"body":"Allow to connect using session id.\r\nA way to test the PR\r\n * Run code in eclipse for example and print out the session ID\r\n * launch the application\r\n * Copy and paste this id in user field, password can be anything but not empty\r\n * Click connect.\r\n\r\nNote: I might go for empty password @gusferguson what do you think? ","created_at":"2015-02-19T13:50:19Z","updated_at":"2015-02-23T15:06:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8c33f9a35d4629b1afd75477f26d217628787f4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/3506/commits","review_comments_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/3506/comments","review_comment_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/3506/comments","statuses_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/statuses/29c1bf604ed95f3d80ee86756edc568c9049bed2","head":{"label":"jburel:login-with-session","ref":"login-with-session","sha":"29c1bf604ed95f3d80ee86756edc568c9049bed2","user":{"login":"jburel","id":1022396,"avatar_url":"https://avatars.githubusercontent.com/u/1022396?v=3","gravatar_id":"","url":"https://api.github.com/users/jburel","html_url":"https://github.com/jburel","followers_url":"https://api.github.com/users/jburel/followers","following_url":"https://api.github.com/users/jburel/following{/other_user}","gists_url":"https://api.github.com/users/jburel/gists{/gist_id}","starred_url":"https://api.github.com/users/jburel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jburel/subscriptions","organizations_url":"https://api.github.com/users/jburel/orgs","repos_url":"https://api.github.com/users/jburel/repos","events_url":"https://api.github.com/users/jburel/events{/privacy}","received_events_url":"https://api.github.com/users/jburel/received_events","type":"User","site_admin":false},"repo":{"id":2315069,"name":"openmicroscopy","full_name":"jburel/openmicroscopy","owner":{"login":"jburel","id":1022396,"avatar_url":"https://avatars.githubusercontent.com/u/1022396?v=3","gravatar_id":"","url":"https://api.github.com/users/jburel","html_url":"https://github.com/jburel","followers_url":"https://api.github.com/users/jburel/followers","following_url":"https://api.github.com/users/jburel/following{/other_user}","gists_url":"https://api.github.com/users/jburel/gists{/gist_id}","starred_url":"https://api.github.com/users/jburel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jburel/subscriptions","organizations_url":"https://api.github.com/users/jburel/orgs","repos_url":"https://api.github.com/users/jburel/repos","events_url":"https://api.github.com/users/jburel/events{/privacy}","received_events_url":"https://api.github.com/users/jburel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jburel/openmicroscopy","description":"OME (Open Microscopy Environment) develops open-source software and data format standards for the storage and manipulation of biological light microscopy data. A joint project between universities, research establishments and industry in Europe and the USA, OME has over 20 active researchers with strong links to the microscopy community. Funded by private and public research grants, OME has been a major force on the international microscopy stage since 2000.","fork":true,"url":"https://api.github.com/repos/jburel/openmicroscopy","forks_url":"https://api.github.com/repos/jburel/openmicroscopy/forks","keys_url":"https://api.github.com/repos/jburel/openmicroscopy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jburel/openmicroscopy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jburel/openmicroscopy/teams","hooks_url":"https://api.github.com/repos/jburel/openmicroscopy/hooks","issue_events_url":"https://api.github.com/repos/jburel/openmicroscopy/issues/events{/number}","events_url":"https://api.github.com/repos/jburel/openmicroscopy/events","assignees_url":"https://api.github.com/repos/jburel/openmicroscopy/assignees{/user}","branches_url":"https://api.github.com/repos/jburel/openmicroscopy/branches{/branch}","tags_url":"https://api.github.com/repos/jburel/openmicroscopy/tags","blobs_url":"https://api.github.com/repos/jburel/openmicroscopy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jburel/openmicroscopy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jburel/openmicroscopy/git/refs{/sha}","trees_url":"https://api.github.com/repos/jburel/openmicroscopy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jburel/openmicroscopy/statuses/{sha}","languages_url":"https://api.github.com/repos/jburel/openmicroscopy/languages","stargazers_url":"https://api.github.com/repos/jburel/openmicroscopy/stargazers","contributors_url":"https://api.github.com/repos/jburel/openmicroscopy/contributors","subscribers_url":"https://api.github.com/repos/jburel/openmicroscopy/subscribers","subscription_url":"https://api.github.com/repos/jburel/openmicroscopy/subscription","commits_url":"https://api.github.com/repos/jburel/openmicroscopy/commits{/sha}","git_commits_url":"https://api.github.com/repos/jburel/openmicroscopy/git/commits{/sha}","comments_url":"https://api.github.com/repos/jburel/openmicroscopy/comments{/number}","issue_comment_url":"https://api.github.com/repos/jburel/openmicroscopy/issues/comments{/number}","contents_url":"https://api.github.com/repos/jburel/openmicroscopy/contents/{+path}","compare_url":"https://api.github.com/repos/jburel/openmicroscopy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jburel/openmicroscopy/merges","archive_url":"https://api.github.com/repos/jburel/openmicroscopy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jburel/openmicroscopy/downloads","issues_url":"https://api.github.com/repos/jburel/openmicroscopy/issues{/number}","pulls_url":"https://api.github.com/repos/jburel/openmicroscopy/pulls{/number}","milestones_url":"https://api.github.com/repos/jburel/openmicroscopy/milestones{/number}","notifications_url":"https://api.github.com/repos/jburel/openmicroscopy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jburel/openmicroscopy/labels{/name}","releases_url":"https://api.github.com/repos/jburel/openmicroscopy/releases{/id}","created_at":"2011-09-02T16:40:24Z","updated_at":"2014-09-11T03:18:41Z","pushed_at":"2015-02-23T14:28:22Z","git_url":"git://github.com/jburel/openmicroscopy.git","ssh_url":"git@github.com:jburel/openmicroscopy.git","clone_url":"https://github.com/jburel/openmicroscopy.git","svn_url":"https://github.com/jburel/openmicroscopy","homepage":"http://www.openmicroscopy.org","size":2098987,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":5,"default_branch":"codepro-audit"}},"base":{"label":"openmicroscopy:develop","ref":"develop","sha":"2b78e19c9ef31936f36939b4f9efa330700a49a0","user":{"login":"openmicroscopy","id":975861,"avatar_url":"https://avatars.githubusercontent.com/u/975861?v=3","gravatar_id":"","url":"https://api.github.com/users/openmicroscopy","html_url":"https://github.com/openmicroscopy","followers_url":"https://api.github.com/users/openmicroscopy/followers","following_url":"https://api.github.com/users/openmicroscopy/following{/other_user}","gists_url":"https://api.github.com/users/openmicroscopy/gists{/gist_id}","starred_url":"https://api.github.com/users/openmicroscopy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmicroscopy/subscriptions","organizations_url":"https://api.github.com/users/openmicroscopy/orgs","repos_url":"https://api.github.com/users/openmicroscopy/repos","events_url":"https://api.github.com/users/openmicroscopy/events{/privacy}","received_events_url":"https://api.github.com/users/openmicroscopy/received_events","type":"Organization","site_admin":false},"repo":{"id":2228226,"name":"openmicroscopy","full_name":"openmicroscopy/openmicroscopy","owner":{"login":"openmicroscopy","id":975861,"avatar_url":"https://avatars.githubusercontent.com/u/975861?v=3","gravatar_id":"","url":"https://api.github.com/users/openmicroscopy","html_url":"https://github.com/openmicroscopy","followers_url":"https://api.github.com/users/openmicroscopy/followers","following_url":"https://api.github.com/users/openmicroscopy/following{/other_user}","gists_url":"https://api.github.com/users/openmicroscopy/gists{/gist_id}","starred_url":"https://api.github.com/users/openmicroscopy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmicroscopy/subscriptions","organizations_url":"https://api.github.com/users/openmicroscopy/orgs","repos_url":"https://api.github.com/users/openmicroscopy/repos","events_url":"https://api.github.com/users/openmicroscopy/events{/privacy}","received_events_url":"https://api.github.com/users/openmicroscopy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openmicroscopy/openmicroscopy","description":"OME (Open Microscopy Environment) develops open-source software and data format standards for the storage and manipulation of biological light microscopy data. A joint project between universities, research establishments and industry in Europe and the USA, OME has over 20 active researchers with strong links to the microscopy community. Funded by private and public research grants, OME has been a major force on the international microscopy stage since 2000.","fork":false,"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy","forks_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/forks","keys_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/teams","hooks_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/hooks","issue_events_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/events{/number}","events_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/events","assignees_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/assignees{/user}","branches_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/branches{/branch}","tags_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/tags","blobs_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/git/refs{/sha}","trees_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/statuses/{sha}","languages_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/languages","stargazers_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/stargazers","contributors_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/contributors","subscribers_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/subscribers","subscription_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/subscription","commits_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/commits{/sha}","git_commits_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/git/commits{/sha}","comments_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/comments{/number}","issue_comment_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/comments{/number}","contents_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/contents/{+path}","compare_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/merges","archive_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/downloads","issues_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues{/number}","pulls_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls{/number}","milestones_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/milestones{/number}","notifications_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/labels{/name}","releases_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/releases{/id}","created_at":"2011-08-18T14:26:02Z","updated_at":"2015-02-23T10:42:01Z","pushed_at":"2015-02-23T10:41:46Z","git_url":"git://github.com/openmicroscopy/openmicroscopy.git","ssh_url":"git@github.com:openmicroscopy/openmicroscopy.git","clone_url":"https://github.com/openmicroscopy/openmicroscopy.git","svn_url":"https://github.com/openmicroscopy/openmicroscopy","homepage":"http://www.openmicroscopy.org","size":2148839,"stargazers_count":65,"watchers_count":65,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"open_issues_count":39,"forks":63,"open_issues":39,"watchers":65,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/3506"},"html":{"href":"https://github.com/openmicroscopy/openmicroscopy/pull/3506"},"issue":{"href":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/3506"},"comments":{"href":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/3506/comments"},"review_comments":{"href":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/3506/comments"},"review_comment":{"href":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/3506/commits"},"statuses":{"href":"https://api.github.com/repos/openmicroscopy/openmicroscopy/statuses/29c1bf604ed95f3d80ee86756edc568c9049bed2"}}}}