{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/jetpack/issues/2040","labels_url":"https://api.github.com/repos/Automattic/jetpack/issues/2040/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/jetpack/issues/2040/comments","events_url":"https://api.github.com/repos/Automattic/jetpack/issues/2040/events","html_url":"https://github.com/Automattic/jetpack/pull/2040","id":71611546,"number":2040,"title":"Notes: Stop depending on `jquery.spin` so that `wp-admin/network` loads ...","user":{"login":"dmsnell","id":5431237,"avatar_url":"https://avatars.githubusercontent.com/u/5431237?v=3","gravatar_id":"","url":"https://api.github.com/users/dmsnell","html_url":"https://github.com/dmsnell","followers_url":"https://api.github.com/users/dmsnell/followers","following_url":"https://api.github.com/users/dmsnell/following{/other_user}","gists_url":"https://api.github.com/users/dmsnell/gists{/gist_id}","starred_url":"https://api.github.com/users/dmsnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmsnell/subscriptions","organizations_url":"https://api.github.com/users/dmsnell/orgs","repos_url":"https://api.github.com/users/dmsnell/repos","events_url":"https://api.github.com/users/dmsnell/events{/privacy}","received_events_url":"https://api.github.com/users/dmsnell/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Automattic/jetpack/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/Automattic/jetpack/labels/in%20progress","name":"in progress","color":"ededed"},{"url":"https://api.github.com/repos/Automattic/jetpack/labels/Notifications","name":"Notifications","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/Automattic/jetpack/milestones/16","html_url":"https://github.com/Automattic/jetpack/milestones/3.6","labels_url":"https://api.github.com/repos/Automattic/jetpack/milestones/16/labels","id":955017,"number":16,"title":"3.6","description":"","creator":{"login":"jeherve","id":426388,"avatar_url":"https://avatars.githubusercontent.com/u/426388?v=3","gravatar_id":"","url":"https://api.github.com/users/jeherve","html_url":"https://github.com/jeherve","followers_url":"https://api.github.com/users/jeherve/followers","following_url":"https://api.github.com/users/jeherve/following{/other_user}","gists_url":"https://api.github.com/users/jeherve/gists{/gist_id}","starred_url":"https://api.github.com/users/jeherve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeherve/subscriptions","organizations_url":"https://api.github.com/users/jeherve/orgs","repos_url":"https://api.github.com/users/jeherve/repos","events_url":"https://api.github.com/users/jeherve/events{/privacy}","received_events_url":"https://api.github.com/users/jeherve/received_events","type":"User","site_admin":false},"open_issues":161,"closed_issues":29,"state":"open","created_at":"2015-01-28T15:04:56Z","updated_at":"2015-04-29T18:16:28Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2015-04-28T14:52:26Z","updated_at":"2015-04-30T01:49:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Automattic/jetpack/pulls/2040","html_url":"https://github.com/Automattic/jetpack/pull/2040","diff_url":"https://github.com/Automattic/jetpack/pull/2040.diff","patch_url":"https://github.com/Automattic/jetpack/pull/2040.patch"},"body":"...the notes properly\r\n\r\nIssue #718\r\n\r\nThe notifications panel wasn't loading on `wp-admin/network` pages. This was apparently\r\ndue to a conflict between `jquery.spin` and some other library. Removing this library\r\nfrom the list of dependencies for `notes-common-v2.js` allowed it to load.\r\n\r\nStrangely enough, the spinner functionality didn't stop when I removed the dependency.\r\nThe library still appears to be loading from another request.\r\n\r\nWere this to cause any bad side effects, it could be limited to only impacting the\r\nnetwork admin with a simple conditional `is_network_admin()`"},"comment":{"url":"https://api.github.com/repos/Automattic/jetpack/issues/comments/97631410","html_url":"https://github.com/Automattic/jetpack/pull/2040#issuecomment-97631410","issue_url":"https://api.github.com/repos/Automattic/jetpack/issues/2040","id":97631410,"user":{"login":"dmsnell","id":5431237,"avatar_url":"https://avatars.githubusercontent.com/u/5431237?v=3","gravatar_id":"","url":"https://api.github.com/users/dmsnell","html_url":"https://github.com/dmsnell","followers_url":"https://api.github.com/users/dmsnell/followers","following_url":"https://api.github.com/users/dmsnell/following{/other_user}","gists_url":"https://api.github.com/users/dmsnell/gists{/gist_id}","starred_url":"https://api.github.com/users/dmsnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmsnell/subscriptions","organizations_url":"https://api.github.com/users/dmsnell/orgs","repos_url":"https://api.github.com/users/dmsnell/repos","events_url":"https://api.github.com/users/dmsnell/events{/privacy}","received_events_url":"https://api.github.com/users/dmsnell/received_events","type":"User","site_admin":false},"created_at":"2015-04-30T01:49:41Z","updated_at":"2015-04-30T01:49:41Z","body":"The `jquery.spin.js` file doesn't seem to be loading in any tests I have been running. There's no place in `notes.php` that enqueues it either."}}