{"action":"created","issue":{"url":"https://api.github.com/repos/mixxxdj/mixxx/issues/645","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/645/labels{/name}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/645/comments","events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/645/events","html_url":"https://github.com/mixxxdj/mixxx/pull/645","id":94592878,"number":645,"title":"KnobComposed masked ring","user":{"login":"ferranpujolcamins","id":6429775,"avatar_url":"https://avatars.githubusercontent.com/u/6429775?v=3","gravatar_id":"","url":"https://api.github.com/users/ferranpujolcamins","html_url":"https://github.com/ferranpujolcamins","followers_url":"https://api.github.com/users/ferranpujolcamins/followers","following_url":"https://api.github.com/users/ferranpujolcamins/following{/other_user}","gists_url":"https://api.github.com/users/ferranpujolcamins/gists{/gist_id}","starred_url":"https://api.github.com/users/ferranpujolcamins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferranpujolcamins/subscriptions","organizations_url":"https://api.github.com/users/ferranpujolcamins/orgs","repos_url":"https://api.github.com/users/ferranpujolcamins/repos","events_url":"https://api.github.com/users/ferranpujolcamins/events{/privacy}","received_events_url":"https://api.github.com/users/ferranpujolcamins/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":31,"created_at":"2015-07-12T19:30:29Z","updated_at":"2015-09-26T09:29:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/645","html_url":"https://github.com/mixxxdj/mixxx/pull/645","diff_url":"https://github.com/mixxxdj/mixxx/pull/645.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/645.patch"},"body":" Added support for a new \"Ring\" pixmap in WKnobComposed that is automatically masked.\r\n\r\nA new \"Ring\" pixmap is added to WKnobComposed. It is automatically masked between MinAngle and MaxAngle as the knob is turned.\r\n\r\nThe BackPath pixmap is drawn on top of the new \"Ring\" pixmap. This allows the background to cast shadows to the ring.\r\n\r\nThe new \"Centered\" tag makes the ring totally masked at 12 o'clock position and makes it \"sweep-in\" as the knob is turned from there.\r\n\r\nThe new \"RingMaskXOffset\" and \"RingMaskYOffset\" should be used in case the Ring pixmap is not exactly centered in the middle of the canvas. They are relative to the center of the canvas.\r\n\r\nThe last commit is just to show the changes in action, it should be reverted before merging this PR. The new knobs are a bit ugly, I made them quickly. Don't judge this PR for their looks :)\r\nLateNight probably needs a new set of knobs that integrate the ring well, if this PR is accepted, I'll make a new one with better knobs for LateNight."},"comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments/143414709","html_url":"https://github.com/mixxxdj/mixxx/pull/645#issuecomment-143414709","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/645","id":143414709,"user":{"login":"daschuer","id":1777442,"avatar_url":"https://avatars.githubusercontent.com/u/1777442?v=3","gravatar_id":"","url":"https://api.github.com/users/daschuer","html_url":"https://github.com/daschuer","followers_url":"https://api.github.com/users/daschuer/followers","following_url":"https://api.github.com/users/daschuer/following{/other_user}","gists_url":"https://api.github.com/users/daschuer/gists{/gist_id}","starred_url":"https://api.github.com/users/daschuer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daschuer/subscriptions","organizations_url":"https://api.github.com/users/daschuer/orgs","repos_url":"https://api.github.com/users/daschuer/repos","events_url":"https://api.github.com/users/daschuer/events{/privacy}","received_events_url":"https://api.github.com/users/daschuer/received_events","type":"User","site_admin":false},"created_at":"2015-09-26T09:29:28Z","updated_at":"2015-09-26T09:29:28Z","body":"Don't forget to add your new cpp files to build/depends.py"}}