{"action":"closed","number":43,"pull_request":{"url":"https://api.github.com/repos/xaque208/puppet-bacula/pulls/43","id":44582202,"html_url":"https://github.com/xaque208/puppet-bacula/pull/43","diff_url":"https://github.com/xaque208/puppet-bacula/pull/43.diff","patch_url":"https://github.com/xaque208/puppet-bacula/pull/43.patch","issue_url":"https://api.github.com/repos/xaque208/puppet-bacula/issues/43","number":43,"state":"closed","locked":false,"title":"Two feature enhancements and three small fixes","user":{"login":"ManfredP","id":10049974,"avatar_url":"https://avatars.githubusercontent.com/u/10049974?v=3","gravatar_id":"","url":"https://api.github.com/users/ManfredP","html_url":"https://github.com/ManfredP","followers_url":"https://api.github.com/users/ManfredP/followers","following_url":"https://api.github.com/users/ManfredP/following{/other_user}","gists_url":"https://api.github.com/users/ManfredP/gists{/gist_id}","starred_url":"https://api.github.com/users/ManfredP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManfredP/subscriptions","organizations_url":"https://api.github.com/users/ManfredP/orgs","repos_url":"https://api.github.com/users/ManfredP/repos","events_url":"https://api.github.com/users/ManfredP/events{/privacy}","received_events_url":"https://api.github.com/users/ManfredP/received_events","type":"User","site_admin":false},"body":"Hi,\r\nthis module work's now great on my RHEL servers, but there were 3 minor issues I fixed:\r\n+ `Ctype` and `Collate` of the database was set to `UTF-8`, the bacula database create script sets it to `C`. I'm not a database expert, but I think `C` makes more sense with `SQL_ASCII` encoding.\r\n+ There was a missing dependency in one file resource in the storage class.\r\n+ The `RestoreFile` job had the `Default` schedule and failed every night.\r\n\r\nI also added two features:\r\n+ I have to use fileset options like `wild` multiple times, so I added support for arrays as values of the options hash.\r\n+ I need two restore jobs with different output directories, one for the usual file restore while the os is running, and one fore bare metal recovery. So I made `Where` configurable in the job type. I also did this for `Messages` because after changing `Where` it was the last static parameter in the template.\r\n\r\nI testet all of these changes in my environment and found no issues. I also did compatibility tests to make sure existing installations will have no problems with this changes.","created_at":"2015-09-09T18:12:33Z","updated_at":"2015-09-15T20:37:29Z","closed_at":"2015-09-15T20:37:29Z","merged_at":"2015-09-15T20:37:29Z","merge_commit_sha":"3e66bb68c8aa2203dd23729f71fde28077f4ad7e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xaque208/puppet-bacula/pulls/43/commits","review_comments_url":"https://api.github.com/repos/xaque208/puppet-bacula/pulls/43/comments","review_comment_url":"https://api.github.com/repos/xaque208/puppet-bacula/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xaque208/puppet-bacula/issues/43/comments","statuses_url":"https://api.github.com/repos/xaque208/puppet-bacula/statuses/2dd39c48637c727d380e8ab7cbaa5380c5fdb1d2","head":{"label":"ManfredP:pullreq2","ref":"pullreq2","sha":"2dd39c48637c727d380e8ab7cbaa5380c5fdb1d2","user":{"login":"ManfredP","id":10049974,"avatar_url":"https://avatars.githubusercontent.com/u/10049974?v=3","gravatar_id":"","url":"https://api.github.com/users/ManfredP","html_url":"https://github.com/ManfredP","followers_url":"https://api.github.com/users/ManfredP/followers","following_url":"https://api.github.com/users/ManfredP/following{/other_user}","gists_url":"https://api.github.com/users/ManfredP/gists{/gist_id}","starred_url":"https://api.github.com/users/ManfredP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManfredP/subscriptions","organizations_url":"https://api.github.com/users/ManfredP/orgs","repos_url":"https://api.github.com/users/ManfredP/repos","events_url":"https://api.github.com/users/ManfredP/events{/privacy}","received_events_url":"https://api.github.com/users/ManfredP/received_events","type":"User","site_admin":false},"repo":{"id":40908136,"name":"puppet-bacula","full_name":"ManfredP/puppet-bacula","owner":{"login":"ManfredP","id":10049974,"avatar_url":"https://avatars.githubusercontent.com/u/10049974?v=3","gravatar_id":"","url":"https://api.github.com/users/ManfredP","html_url":"https://github.com/ManfredP","followers_url":"https://api.github.com/users/ManfredP/followers","following_url":"https://api.github.com/users/ManfredP/following{/other_user}","gists_url":"https://api.github.com/users/ManfredP/gists{/gist_id}","starred_url":"https://api.github.com/users/ManfredP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManfredP/subscriptions","organizations_url":"https://api.github.com/users/ManfredP/orgs","repos_url":"https://api.github.com/users/ManfredP/repos","events_url":"https://api.github.com/users/ManfredP/events{/privacy}","received_events_url":"https://api.github.com/users/ManfredP/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ManfredP/puppet-bacula","description":"A bacula module stolen from the Puppet Labs Operations team","fork":true,"url":"https://api.github.com/repos/ManfredP/puppet-bacula","forks_url":"https://api.github.com/repos/ManfredP/puppet-bacula/forks","keys_url":"https://api.github.com/repos/ManfredP/puppet-bacula/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManfredP/puppet-bacula/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManfredP/puppet-bacula/teams","hooks_url":"https://api.github.com/repos/ManfredP/puppet-bacula/hooks","issue_events_url":"https://api.github.com/repos/ManfredP/puppet-bacula/issues/events{/number}","events_url":"https://api.github.com/repos/ManfredP/puppet-bacula/events","assignees_url":"https://api.github.com/repos/ManfredP/puppet-bacula/assignees{/user}","branches_url":"https://api.github.com/repos/ManfredP/puppet-bacula/branches{/branch}","tags_url":"https://api.github.com/repos/ManfredP/puppet-bacula/tags","blobs_url":"https://api.github.com/repos/ManfredP/puppet-bacula/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManfredP/puppet-bacula/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManfredP/puppet-bacula/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManfredP/puppet-bacula/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManfredP/puppet-bacula/statuses/{sha}","languages_url":"https://api.github.com/repos/ManfredP/puppet-bacula/languages","stargazers_url":"https://api.github.com/repos/ManfredP/puppet-bacula/stargazers","contributors_url":"https://api.github.com/repos/ManfredP/puppet-bacula/contributors","subscribers_url":"https://api.github.com/repos/ManfredP/puppet-bacula/subscribers","subscription_url":"https://api.github.com/repos/ManfredP/puppet-bacula/subscription","commits_url":"https://api.github.com/repos/ManfredP/puppet-bacula/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManfredP/puppet-bacula/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManfredP/puppet-bacula/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManfredP/puppet-bacula/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManfredP/puppet-bacula/contents/{+path}","compare_url":"https://api.github.com/repos/ManfredP/puppet-bacula/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManfredP/puppet-bacula/merges","archive_url":"https://api.github.com/repos/ManfredP/puppet-bacula/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManfredP/puppet-bacula/downloads","issues_url":"https://api.github.com/repos/ManfredP/puppet-bacula/issues{/number}","pulls_url":"https://api.github.com/repos/ManfredP/puppet-bacula/pulls{/number}","milestones_url":"https://api.github.com/repos/ManfredP/puppet-bacula/milestones{/number}","notifications_url":"https://api.github.com/repos/ManfredP/puppet-bacula/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManfredP/puppet-bacula/labels{/name}","releases_url":"https://api.github.com/repos/ManfredP/puppet-bacula/releases{/id}","created_at":"2015-08-17T15:58:31Z","updated_at":"2015-08-17T15:58:32Z","pushed_at":"2015-09-10T17:40:41Z","git_url":"git://github.com/ManfredP/puppet-bacula.git","ssh_url":"git@github.com:ManfredP/puppet-bacula.git","clone_url":"https://github.com/ManfredP/puppet-bacula.git","svn_url":"https://github.com/ManfredP/puppet-bacula","homepage":null,"size":3779,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xaque208:master","ref":"master","sha":"75ada644d8e6b29c897f4b3eb38a01e3527055aa","user":{"login":"xaque208","id":334176,"avatar_url":"https://avatars.githubusercontent.com/u/334176?v=3","gravatar_id":"","url":"https://api.github.com/users/xaque208","html_url":"https://github.com/xaque208","followers_url":"https://api.github.com/users/xaque208/followers","following_url":"https://api.github.com/users/xaque208/following{/other_user}","gists_url":"https://api.github.com/users/xaque208/gists{/gist_id}","starred_url":"https://api.github.com/users/xaque208/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xaque208/subscriptions","organizations_url":"https://api.github.com/users/xaque208/orgs","repos_url":"https://api.github.com/users/xaque208/repos","events_url":"https://api.github.com/users/xaque208/events{/privacy}","received_events_url":"https://api.github.com/users/xaque208/received_events","type":"User","site_admin":false},"repo":{"id":23807067,"name":"puppet-bacula","full_name":"xaque208/puppet-bacula","owner":{"login":"xaque208","id":334176,"avatar_url":"https://avatars.githubusercontent.com/u/334176?v=3","gravatar_id":"","url":"https://api.github.com/users/xaque208","html_url":"https://github.com/xaque208","followers_url":"https://api.github.com/users/xaque208/followers","following_url":"https://api.github.com/users/xaque208/following{/other_user}","gists_url":"https://api.github.com/users/xaque208/gists{/gist_id}","starred_url":"https://api.github.com/users/xaque208/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xaque208/subscriptions","organizations_url":"https://api.github.com/users/xaque208/orgs","repos_url":"https://api.github.com/users/xaque208/repos","events_url":"https://api.github.com/users/xaque208/events{/privacy}","received_events_url":"https://api.github.com/users/xaque208/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xaque208/puppet-bacula","description":"A bacula module stolen from the Puppet Labs Operations team","fork":false,"url":"https://api.github.com/repos/xaque208/puppet-bacula","forks_url":"https://api.github.com/repos/xaque208/puppet-bacula/forks","keys_url":"https://api.github.com/repos/xaque208/puppet-bacula/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xaque208/puppet-bacula/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xaque208/puppet-bacula/teams","hooks_url":"https://api.github.com/repos/xaque208/puppet-bacula/hooks","issue_events_url":"https://api.github.com/repos/xaque208/puppet-bacula/issues/events{/number}","events_url":"https://api.github.com/repos/xaque208/puppet-bacula/events","assignees_url":"https://api.github.com/repos/xaque208/puppet-bacula/assignees{/user}","branches_url":"https://api.github.com/repos/xaque208/puppet-bacula/branches{/branch}","tags_url":"https://api.github.com/repos/xaque208/puppet-bacula/tags","blobs_url":"https://api.github.com/repos/xaque208/puppet-bacula/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xaque208/puppet-bacula/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xaque208/puppet-bacula/git/refs{/sha}","trees_url":"https://api.github.com/repos/xaque208/puppet-bacula/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xaque208/puppet-bacula/statuses/{sha}","languages_url":"https://api.github.com/repos/xaque208/puppet-bacula/languages","stargazers_url":"https://api.github.com/repos/xaque208/puppet-bacula/stargazers","contributors_url":"https://api.github.com/repos/xaque208/puppet-bacula/contributors","subscribers_url":"https://api.github.com/repos/xaque208/puppet-bacula/subscribers","subscription_url":"https://api.github.com/repos/xaque208/puppet-bacula/subscription","commits_url":"https://api.github.com/repos/xaque208/puppet-bacula/commits{/sha}","git_commits_url":"https://api.github.com/repos/xaque208/puppet-bacula/git/commits{/sha}","comments_url":"https://api.github.com/repos/xaque208/puppet-bacula/comments{/number}","issue_comment_url":"https://api.github.com/repos/xaque208/puppet-bacula/issues/comments{/number}","contents_url":"https://api.github.com/repos/xaque208/puppet-bacula/contents/{+path}","compare_url":"https://api.github.com/repos/xaque208/puppet-bacula/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xaque208/puppet-bacula/merges","archive_url":"https://api.github.com/repos/xaque208/puppet-bacula/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xaque208/puppet-bacula/downloads","issues_url":"https://api.github.com/repos/xaque208/puppet-bacula/issues{/number}","pulls_url":"https://api.github.com/repos/xaque208/puppet-bacula/pulls{/number}","milestones_url":"https://api.github.com/repos/xaque208/puppet-bacula/milestones{/number}","notifications_url":"https://api.github.com/repos/xaque208/puppet-bacula/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xaque208/puppet-bacula/labels{/name}","releases_url":"https://api.github.com/repos/xaque208/puppet-bacula/releases{/id}","created_at":"2014-09-08T20:29:25Z","updated_at":"2015-08-03T03:59:27Z","pushed_at":"2015-09-15T20:37:29Z","git_url":"git://github.com/xaque208/puppet-bacula.git","ssh_url":"git@github.com:xaque208/puppet-bacula.git","clone_url":"https://github.com/xaque208/puppet-bacula.git","svn_url":"https://github.com/xaque208/puppet-bacula","homepage":null,"size":4333,"stargazers_count":4,"watchers_count":4,"language":"Puppet","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xaque208/puppet-bacula/pulls/43"},"html":{"href":"https://github.com/xaque208/puppet-bacula/pull/43"},"issue":{"href":"https://api.github.com/repos/xaque208/puppet-bacula/issues/43"},"comments":{"href":"https://api.github.com/repos/xaque208/puppet-bacula/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/xaque208/puppet-bacula/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/xaque208/puppet-bacula/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xaque208/puppet-bacula/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/xaque208/puppet-bacula/statuses/2dd39c48637c727d380e8ab7cbaa5380c5fdb1d2"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"xaque208","id":334176,"avatar_url":"https://avatars.githubusercontent.com/u/334176?v=3","gravatar_id":"","url":"https://api.github.com/users/xaque208","html_url":"https://github.com/xaque208","followers_url":"https://api.github.com/users/xaque208/followers","following_url":"https://api.github.com/users/xaque208/following{/other_user}","gists_url":"https://api.github.com/users/xaque208/gists{/gist_id}","starred_url":"https://api.github.com/users/xaque208/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xaque208/subscriptions","organizations_url":"https://api.github.com/users/xaque208/orgs","repos_url":"https://api.github.com/users/xaque208/repos","events_url":"https://api.github.com/users/xaque208/events{/privacy}","received_events_url":"https://api.github.com/users/xaque208/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":7,"additions":43,"deletions":4,"changed_files":7}}