{"action":"created","issue":{"url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/4406","labels_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/4406/labels{/name}","comments_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/4406/comments","events_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/4406/events","html_url":"https://github.com/qbittorrent/qBittorrent/issues/4406","id":122768278,"number":4406,"title":"3.4.0 displaying (seeded for ...) when task is incomplete, ","user":{"login":"chrishirst","id":3680285,"avatar_url":"https://avatars.githubusercontent.com/u/3680285?v=3","gravatar_id":"","url":"https://api.github.com/users/chrishirst","html_url":"https://github.com/chrishirst","followers_url":"https://api.github.com/users/chrishirst/followers","following_url":"https://api.github.com/users/chrishirst/following{/other_user}","gists_url":"https://api.github.com/users/chrishirst/gists{/gist_id}","starred_url":"https://api.github.com/users/chrishirst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrishirst/subscriptions","organizations_url":"https://api.github.com/users/chrishirst/orgs","repos_url":"https://api.github.com/users/chrishirst/repos","events_url":"https://api.github.com/users/chrishirst/events{/privacy}","received_events_url":"https://api.github.com/users/chrishirst/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-12-17T16:18:49Z","updated_at":"2015-12-27T17:04:49Z","closed_at":null,"body":"in the GUI  \"Time Active\" column \r\n![incomplete-seeding](https://cloud.githubusercontent.com/assets/3680285/11874680/e2a34930-a4d8-11e5-84b7-266a404d06f9.png)\r\n\r\nProperties panel shows the correct time active only.\r\n\r\nNo unselected payload parts.\r\nShare ratio limiting is NOT selected "},"comment":{"url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/comments/167426375","html_url":"https://github.com/qbittorrent/qBittorrent/issues/4406#issuecomment-167426375","issue_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/4406","id":167426375,"user":{"login":"naikel","id":7663686,"avatar_url":"https://avatars.githubusercontent.com/u/7663686?v=3","gravatar_id":"","url":"https://api.github.com/users/naikel","html_url":"https://github.com/naikel","followers_url":"https://api.github.com/users/naikel/followers","following_url":"https://api.github.com/users/naikel/following{/other_user}","gists_url":"https://api.github.com/users/naikel/gists{/gist_id}","starred_url":"https://api.github.com/users/naikel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naikel/subscriptions","organizations_url":"https://api.github.com/users/naikel/orgs","repos_url":"https://api.github.com/users/naikel/repos","events_url":"https://api.github.com/users/naikel/events{/privacy}","received_events_url":"https://api.github.com/users/naikel/received_events","type":"User","site_admin":false},"created_at":"2015-12-27T17:04:49Z","updated_at":"2015-12-27T17:04:49Z","body":"There's a difference between when to display \"seeded for\" in the transfer list and in the properties widget. The transfer list compares seeding_time > 0 and the properties widget compares if isSeed() is true.  That's why is not consistent between the transfer list and the properties widget.\r\n\r\nNow we have to find out why seeding_time can be > 0 in a torrent that is not a seed.  It had to became a seed for a while to increase the seeding_time.  \r\n\r\nAre you using libtorrent 1.0.7?  I'm pretty sure that's not reproducible in 1.0.6.\r\n\r\nLibtorrent 1.0.6:\r\n```C++\r\nif (is_seed()) m_seeding_time += seconds_since_last_tick;\r\n```\r\n\r\nLibtorrent 1.0.7\r\n```C++\r\n\t\tif (m_became_seed < seconds && is_seed())\r\n\t\t{\r\n\t\t\tint lost_seconds = seconds - m_became_seed;\r\n\t\t\tm_seeding_time += lost_seconds;\r\n\t\t}\r\n\t\tm_became_seed = clamped_subtract(m_became_seed, seconds);\r\n```\r\n\r\nWhat? m_became_seed is assigned after it is validated?\r\n\r\nI never trusted 1.0.7 that's why I never upgraded my libtorrent and my qBittorrent works perfectly with no bugs."}}