{"action":"created","comment":{"url":"https://api.github.com/repos/9prady9/MeshIO/pulls/comments/47120795","id":47120795,"diff_hunk":"@@ -52,41 +93,85 @@ class Vec2 {\n     }\n \n     bool operator==(const Vec2& other) {\n-        return ((x == other.x) && (y == other.y));\n+        return ((elements[0] == other.X()) && (elements[1] == other.Y()));\n     }\n+\n+  private:\n+    T elements[2];\n };\n \n template<class T>\n-class Vec3 {\n+class Vec3 : public VecBase<T> {\n   public:\n-    T x,y,z;\n+    typedef T *iterator;\n+    typedef const T *const_iterator;\n+\n+    Vec3(T pX, T pY, T pZ) : elements{pX, pY, pZ} {}\n+    Vec3() : Vec3({static_cast<T>(0), static_cast<T>(0), static_cast<T>(0)}) {}","path":"include/meshio/vectors.hpp","position":119,"original_position":119,"commit_id":"0bb29a2297ef01c23dafed4cc8f077f41b3dd97a","original_commit_id":"0bb29a2297ef01c23dafed4cc8f077f41b3dd97a","user":{"login":"9prady9","id":3270458,"avatar_url":"https://avatars.githubusercontent.com/u/3270458?v=3","gravatar_id":"","url":"https://api.github.com/users/9prady9","html_url":"https://github.com/9prady9","followers_url":"https://api.github.com/users/9prady9/followers","following_url":"https://api.github.com/users/9prady9/following{/other_user}","gists_url":"https://api.github.com/users/9prady9/gists{/gist_id}","starred_url":"https://api.github.com/users/9prady9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9prady9/subscriptions","organizations_url":"https://api.github.com/users/9prady9/orgs","repos_url":"https://api.github.com/users/9prady9/repos","events_url":"https://api.github.com/users/9prady9/events{/privacy}","received_events_url":"https://api.github.com/users/9prady9/received_events","type":"User","site_admin":false},"body":"I think we need to add the --std=c++11 or something like for gcc to use C++11 features. May be that is the reason.","created_at":"2015-12-09T17:12:31Z","updated_at":"2015-12-09T17:12:31Z","html_url":"https://github.com/9prady9/MeshIO/pull/29#discussion_r47120795","pull_request_url":"https://api.github.com/repos/9prady9/MeshIO/pulls/29","_links":{"self":{"href":"https://api.github.com/repos/9prady9/MeshIO/pulls/comments/47120795"},"html":{"href":"https://github.com/9prady9/MeshIO/pull/29#discussion_r47120795"},"pull_request":{"href":"https://api.github.com/repos/9prady9/MeshIO/pulls/29"}}},"pull_request":{"url":"https://api.github.com/repos/9prady9/MeshIO/pulls/29","id":52808517,"html_url":"https://github.com/9prady9/MeshIO/pull/29","diff_url":"https://github.com/9prady9/MeshIO/pull/29.diff","patch_url":"https://github.com/9prady9/MeshIO/pull/29.patch","issue_url":"https://api.github.com/repos/9prady9/MeshIO/issues/29","number":29,"state":"open","locked":false,"title":"Read/write OBJ","user":{"login":"acrlakshman","id":2924807,"avatar_url":"https://avatars.githubusercontent.com/u/2924807?v=3","gravatar_id":"","url":"https://api.github.com/users/acrlakshman","html_url":"https://github.com/acrlakshman","followers_url":"https://api.github.com/users/acrlakshman/followers","following_url":"https://api.github.com/users/acrlakshman/following{/other_user}","gists_url":"https://api.github.com/users/acrlakshman/gists{/gist_id}","starred_url":"https://api.github.com/users/acrlakshman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acrlakshman/subscriptions","organizations_url":"https://api.github.com/users/acrlakshman/orgs","repos_url":"https://api.github.com/users/acrlakshman/repos","events_url":"https://api.github.com/users/acrlakshman/events{/privacy}","received_events_url":"https://api.github.com/users/acrlakshman/received_events","type":"User","site_admin":false},"body":"* referencing #25, #26\r\n* Rewrote some basic datastructures [e.g. GeometryData].\r\n* Read function for OBJ format completed with the help of tinyobjloader.\r\n* Minor cleanups.\r\n* Rewrote some components to adhere to Google C++ style guide.\r\n* write function in progress (WIP).\r\n* Submitting this patch to receive any comments while WIP.\r\n\r\nSigned-off-by: Lakshman Anumolu <acrlakshman@gmail.com>","created_at":"2015-12-07T06:03:26Z","updated_at":"2015-12-09T17:12:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c4fa4967922a2644f8273ca9b6ddbe223b6c8f5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/9prady9/MeshIO/pulls/29/commits","review_comments_url":"https://api.github.com/repos/9prady9/MeshIO/pulls/29/comments","review_comment_url":"https://api.github.com/repos/9prady9/MeshIO/pulls/comments{/number}","comments_url":"https://api.github.com/repos/9prady9/MeshIO/issues/29/comments","statuses_url":"https://api.github.com/repos/9prady9/MeshIO/statuses/0bb29a2297ef01c23dafed4cc8f077f41b3dd97a","head":{"label":"acrlakshman:read_write_OBJ","ref":"read_write_OBJ","sha":"0bb29a2297ef01c23dafed4cc8f077f41b3dd97a","user":{"login":"acrlakshman","id":2924807,"avatar_url":"https://avatars.githubusercontent.com/u/2924807?v=3","gravatar_id":"","url":"https://api.github.com/users/acrlakshman","html_url":"https://github.com/acrlakshman","followers_url":"https://api.github.com/users/acrlakshman/followers","following_url":"https://api.github.com/users/acrlakshman/following{/other_user}","gists_url":"https://api.github.com/users/acrlakshman/gists{/gist_id}","starred_url":"https://api.github.com/users/acrlakshman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acrlakshman/subscriptions","organizations_url":"https://api.github.com/users/acrlakshman/orgs","repos_url":"https://api.github.com/users/acrlakshman/repos","events_url":"https://api.github.com/users/acrlakshman/events{/privacy}","received_events_url":"https://api.github.com/users/acrlakshman/received_events","type":"User","site_admin":false},"repo":{"id":38583572,"name":"MeshIO","full_name":"acrlakshman/MeshIO","owner":{"login":"acrlakshman","id":2924807,"avatar_url":"https://avatars.githubusercontent.com/u/2924807?v=3","gravatar_id":"","url":"https://api.github.com/users/acrlakshman","html_url":"https://github.com/acrlakshman","followers_url":"https://api.github.com/users/acrlakshman/followers","following_url":"https://api.github.com/users/acrlakshman/following{/other_user}","gists_url":"https://api.github.com/users/acrlakshman/gists{/gist_id}","starred_url":"https://api.github.com/users/acrlakshman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acrlakshman/subscriptions","organizations_url":"https://api.github.com/users/acrlakshman/orgs","repos_url":"https://api.github.com/users/acrlakshman/repos","events_url":"https://api.github.com/users/acrlakshman/events{/privacy}","received_events_url":"https://api.github.com/users/acrlakshman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/acrlakshman/MeshIO","description":"Header only library to read/write polygonal meshes.","fork":true,"url":"https://api.github.com/repos/acrlakshman/MeshIO","forks_url":"https://api.github.com/repos/acrlakshman/MeshIO/forks","keys_url":"https://api.github.com/repos/acrlakshman/MeshIO/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acrlakshman/MeshIO/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acrlakshman/MeshIO/teams","hooks_url":"https://api.github.com/repos/acrlakshman/MeshIO/hooks","issue_events_url":"https://api.github.com/repos/acrlakshman/MeshIO/issues/events{/number}","events_url":"https://api.github.com/repos/acrlakshman/MeshIO/events","assignees_url":"https://api.github.com/repos/acrlakshman/MeshIO/assignees{/user}","branches_url":"https://api.github.com/repos/acrlakshman/MeshIO/branches{/branch}","tags_url":"https://api.github.com/repos/acrlakshman/MeshIO/tags","blobs_url":"https://api.github.com/repos/acrlakshman/MeshIO/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acrlakshman/MeshIO/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acrlakshman/MeshIO/git/refs{/sha}","trees_url":"https://api.github.com/repos/acrlakshman/MeshIO/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acrlakshman/MeshIO/statuses/{sha}","languages_url":"https://api.github.com/repos/acrlakshman/MeshIO/languages","stargazers_url":"https://api.github.com/repos/acrlakshman/MeshIO/stargazers","contributors_url":"https://api.github.com/repos/acrlakshman/MeshIO/contributors","subscribers_url":"https://api.github.com/repos/acrlakshman/MeshIO/subscribers","subscription_url":"https://api.github.com/repos/acrlakshman/MeshIO/subscription","commits_url":"https://api.github.com/repos/acrlakshman/MeshIO/commits{/sha}","git_commits_url":"https://api.github.com/repos/acrlakshman/MeshIO/git/commits{/sha}","comments_url":"https://api.github.com/repos/acrlakshman/MeshIO/comments{/number}","issue_comment_url":"https://api.github.com/repos/acrlakshman/MeshIO/issues/comments{/number}","contents_url":"https://api.github.com/repos/acrlakshman/MeshIO/contents/{+path}","compare_url":"https://api.github.com/repos/acrlakshman/MeshIO/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acrlakshman/MeshIO/merges","archive_url":"https://api.github.com/repos/acrlakshman/MeshIO/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acrlakshman/MeshIO/downloads","issues_url":"https://api.github.com/repos/acrlakshman/MeshIO/issues{/number}","pulls_url":"https://api.github.com/repos/acrlakshman/MeshIO/pulls{/number}","milestones_url":"https://api.github.com/repos/acrlakshman/MeshIO/milestones{/number}","notifications_url":"https://api.github.com/repos/acrlakshman/MeshIO/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acrlakshman/MeshIO/labels{/name}","releases_url":"https://api.github.com/repos/acrlakshman/MeshIO/releases{/id}","created_at":"2015-07-05T20:50:05Z","updated_at":"2015-07-05T20:50:05Z","pushed_at":"2015-12-09T06:15:45Z","git_url":"git://github.com/acrlakshman/MeshIO.git","ssh_url":"git@github.com:acrlakshman/MeshIO.git","clone_url":"https://github.com/acrlakshman/MeshIO.git","svn_url":"https://github.com/acrlakshman/MeshIO","homepage":"","size":6061,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"9prady9:master","ref":"master","sha":"806f0b2a3e82d7abb108de424f0776a0c94e3f96","user":{"login":"9prady9","id":3270458,"avatar_url":"https://avatars.githubusercontent.com/u/3270458?v=3","gravatar_id":"","url":"https://api.github.com/users/9prady9","html_url":"https://github.com/9prady9","followers_url":"https://api.github.com/users/9prady9/followers","following_url":"https://api.github.com/users/9prady9/following{/other_user}","gists_url":"https://api.github.com/users/9prady9/gists{/gist_id}","starred_url":"https://api.github.com/users/9prady9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9prady9/subscriptions","organizations_url":"https://api.github.com/users/9prady9/orgs","repos_url":"https://api.github.com/users/9prady9/repos","events_url":"https://api.github.com/users/9prady9/events{/privacy}","received_events_url":"https://api.github.com/users/9prady9/received_events","type":"User","site_admin":false},"repo":{"id":37236095,"name":"MeshIO","full_name":"9prady9/MeshIO","owner":{"login":"9prady9","id":3270458,"avatar_url":"https://avatars.githubusercontent.com/u/3270458?v=3","gravatar_id":"","url":"https://api.github.com/users/9prady9","html_url":"https://github.com/9prady9","followers_url":"https://api.github.com/users/9prady9/followers","following_url":"https://api.github.com/users/9prady9/following{/other_user}","gists_url":"https://api.github.com/users/9prady9/gists{/gist_id}","starred_url":"https://api.github.com/users/9prady9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9prady9/subscriptions","organizations_url":"https://api.github.com/users/9prady9/orgs","repos_url":"https://api.github.com/users/9prady9/repos","events_url":"https://api.github.com/users/9prady9/events{/privacy}","received_events_url":"https://api.github.com/users/9prady9/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/9prady9/MeshIO","description":"Header only library to read/write polygonal meshes.","fork":false,"url":"https://api.github.com/repos/9prady9/MeshIO","forks_url":"https://api.github.com/repos/9prady9/MeshIO/forks","keys_url":"https://api.github.com/repos/9prady9/MeshIO/keys{/key_id}","collaborators_url":"https://api.github.com/repos/9prady9/MeshIO/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/9prady9/MeshIO/teams","hooks_url":"https://api.github.com/repos/9prady9/MeshIO/hooks","issue_events_url":"https://api.github.com/repos/9prady9/MeshIO/issues/events{/number}","events_url":"https://api.github.com/repos/9prady9/MeshIO/events","assignees_url":"https://api.github.com/repos/9prady9/MeshIO/assignees{/user}","branches_url":"https://api.github.com/repos/9prady9/MeshIO/branches{/branch}","tags_url":"https://api.github.com/repos/9prady9/MeshIO/tags","blobs_url":"https://api.github.com/repos/9prady9/MeshIO/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/9prady9/MeshIO/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/9prady9/MeshIO/git/refs{/sha}","trees_url":"https://api.github.com/repos/9prady9/MeshIO/git/trees{/sha}","statuses_url":"https://api.github.com/repos/9prady9/MeshIO/statuses/{sha}","languages_url":"https://api.github.com/repos/9prady9/MeshIO/languages","stargazers_url":"https://api.github.com/repos/9prady9/MeshIO/stargazers","contributors_url":"https://api.github.com/repos/9prady9/MeshIO/contributors","subscribers_url":"https://api.github.com/repos/9prady9/MeshIO/subscribers","subscription_url":"https://api.github.com/repos/9prady9/MeshIO/subscription","commits_url":"https://api.github.com/repos/9prady9/MeshIO/commits{/sha}","git_commits_url":"https://api.github.com/repos/9prady9/MeshIO/git/commits{/sha}","comments_url":"https://api.github.com/repos/9prady9/MeshIO/comments{/number}","issue_comment_url":"https://api.github.com/repos/9prady9/MeshIO/issues/comments{/number}","contents_url":"https://api.github.com/repos/9prady9/MeshIO/contents/{+path}","compare_url":"https://api.github.com/repos/9prady9/MeshIO/compare/{base}...{head}","merges_url":"https://api.github.com/repos/9prady9/MeshIO/merges","archive_url":"https://api.github.com/repos/9prady9/MeshIO/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/9prady9/MeshIO/downloads","issues_url":"https://api.github.com/repos/9prady9/MeshIO/issues{/number}","pulls_url":"https://api.github.com/repos/9prady9/MeshIO/pulls{/number}","milestones_url":"https://api.github.com/repos/9prady9/MeshIO/milestones{/number}","notifications_url":"https://api.github.com/repos/9prady9/MeshIO/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/9prady9/MeshIO/labels{/name}","releases_url":"https://api.github.com/repos/9prady9/MeshIO/releases{/id}","created_at":"2015-06-11T03:01:01Z","updated_at":"2015-09-29T20:39:13Z","pushed_at":"2015-12-09T06:15:46Z","git_url":"git://github.com/9prady9/MeshIO.git","ssh_url":"git@github.com:9prady9/MeshIO.git","clone_url":"https://github.com/9prady9/MeshIO.git","svn_url":"https://github.com/9prady9/MeshIO","homepage":"","size":6326,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/9prady9/MeshIO/pulls/29"},"html":{"href":"https://github.com/9prady9/MeshIO/pull/29"},"issue":{"href":"https://api.github.com/repos/9prady9/MeshIO/issues/29"},"comments":{"href":"https://api.github.com/repos/9prady9/MeshIO/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/9prady9/MeshIO/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/9prady9/MeshIO/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/9prady9/MeshIO/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/9prady9/MeshIO/statuses/0bb29a2297ef01c23dafed4cc8f077f41b3dd97a"}}}}