{"action":"created","comment":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/34440931","id":34440931,"diff_hunk":"@@ -5524,17 +5524,36 @@ static bool matchOption(unsigned & cur, unsigned max, const char * buffer, unsig\n IHqlExpression * extractCppBodyAttrs(unsigned lenBuffer, const char * buffer)\n {\n     OwnedHqlExpr attrs;\n+    bool isInComment = false;\n     unsigned prev = '\\n';\n+\n     for (unsigned i=0; i < lenBuffer; i++)\n     {\n         char next = buffer[i];\n         switch (next)\n         {\n+        case '*':\n+            if ( '/' == prev )","path":"ecl/hql/hqlutil.cpp","position":13,"original_position":13,"commit_id":"dad342710c06025d3f3b517231f81fdabf60854b","original_commit_id":"dad342710c06025d3f3b517231f81fdabf60854b","user":{"login":"richardkchapman","id":900820,"avatar_url":"https://avatars.githubusercontent.com/u/900820?v=3","gravatar_id":"","url":"https://api.github.com/users/richardkchapman","html_url":"https://github.com/richardkchapman","followers_url":"https://api.github.com/users/richardkchapman/followers","following_url":"https://api.github.com/users/richardkchapman/following{/other_user}","gists_url":"https://api.github.com/users/richardkchapman/gists{/gist_id}","starred_url":"https://api.github.com/users/richardkchapman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardkchapman/subscriptions","organizations_url":"https://api.github.com/users/richardkchapman/orgs","repos_url":"https://api.github.com/users/richardkchapman/repos","events_url":"https://api.github.com/users/richardkchapman/events{/privacy}","received_events_url":"https://api.github.com/users/richardkchapman/received_events","type":"User","site_admin":false},"body":"Minor: we do not normally put spaces after the ( or before the ) in an if condition.","created_at":"2015-07-13T08:14:40Z","updated_at":"2015-07-13T08:14:40Z","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7551#discussion_r34440931","pull_request_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7551","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/34440931"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/7551#discussion_r34440931"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7551"}}},"pull_request":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7551","id":39748249,"html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7551","diff_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7551.diff","patch_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7551.patch","issue_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7551","number":7551,"state":"open","locked":false,"title":"HPCC-13445 Commented out #option libraries not ignored","user":{"login":"shamser","id":11410590,"avatar_url":"https://avatars.githubusercontent.com/u/11410590?v=3","gravatar_id":"","url":"https://api.github.com/users/shamser","html_url":"https://github.com/shamser","followers_url":"https://api.github.com/users/shamser/followers","following_url":"https://api.github.com/users/shamser/following{/other_user}","gists_url":"https://api.github.com/users/shamser/gists{/gist_id}","starred_url":"https://api.github.com/users/shamser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shamser/subscriptions","organizations_url":"https://api.github.com/users/shamser/orgs","repos_url":"https://api.github.com/users/shamser/repos","events_url":"https://api.github.com/users/shamser/events{/privacy}","received_events_url":"https://api.github.com/users/shamser/received_events","type":"User","site_admin":false},"body":"Any #option used in commented out code ignored.","created_at":"2015-07-11T16:22:42Z","updated_at":"2015-07-13T08:14:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d89d9eceaacf3c8238171d059e919a465efa6145","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7551/commits","review_comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7551/comments","review_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7551/comments","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/dad342710c06025d3f3b517231f81fdabf60854b","head":{"label":"shamser:issue13445","ref":"issue13445","sha":"dad342710c06025d3f3b517231f81fdabf60854b","user":{"login":"shamser","id":11410590,"avatar_url":"https://avatars.githubusercontent.com/u/11410590?v=3","gravatar_id":"","url":"https://api.github.com/users/shamser","html_url":"https://github.com/shamser","followers_url":"https://api.github.com/users/shamser/followers","following_url":"https://api.github.com/users/shamser/following{/other_user}","gists_url":"https://api.github.com/users/shamser/gists{/gist_id}","starred_url":"https://api.github.com/users/shamser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shamser/subscriptions","organizations_url":"https://api.github.com/users/shamser/orgs","repos_url":"https://api.github.com/users/shamser/repos","events_url":"https://api.github.com/users/shamser/events{/privacy}","received_events_url":"https://api.github.com/users/shamser/received_events","type":"User","site_admin":false},"repo":{"id":32939247,"name":"HPCC-Platform","full_name":"shamser/HPCC-Platform","owner":{"login":"shamser","id":11410590,"avatar_url":"https://avatars.githubusercontent.com/u/11410590?v=3","gravatar_id":"","url":"https://api.github.com/users/shamser","html_url":"https://github.com/shamser","followers_url":"https://api.github.com/users/shamser/followers","following_url":"https://api.github.com/users/shamser/following{/other_user}","gists_url":"https://api.github.com/users/shamser/gists{/gist_id}","starred_url":"https://api.github.com/users/shamser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shamser/subscriptions","organizations_url":"https://api.github.com/users/shamser/orgs","repos_url":"https://api.github.com/users/shamser/repos","events_url":"https://api.github.com/users/shamser/events{/privacy}","received_events_url":"https://api.github.com/users/shamser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shamser/HPCC-Platform","description":"IMPORTANT - Issue tracking has been migrated to JIRA - use your github ID and password reset mechanism to log in","fork":true,"url":"https://api.github.com/repos/shamser/HPCC-Platform","forks_url":"https://api.github.com/repos/shamser/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/shamser/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shamser/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shamser/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/shamser/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/shamser/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/shamser/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/shamser/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/shamser/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/shamser/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/shamser/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shamser/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shamser/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/shamser/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shamser/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/shamser/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/shamser/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/shamser/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/shamser/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/shamser/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/shamser/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/shamser/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/shamser/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/shamser/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/shamser/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/shamser/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shamser/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/shamser/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shamser/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/shamser/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/shamser/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/shamser/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/shamser/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shamser/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/shamser/HPCC-Platform/releases{/id}","created_at":"2015-03-26T16:34:05Z","updated_at":"2015-03-26T16:34:22Z","pushed_at":"2015-07-11T16:21:41Z","git_url":"git://github.com/shamser/HPCC-Platform.git","ssh_url":"git@github.com:shamser/HPCC-Platform.git","clone_url":"https://github.com/shamser/HPCC-Platform.git","svn_url":"https://github.com/shamser/HPCC-Platform","homepage":"track.hpccsystems.com","size":293698,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hpcc-systems:master","ref":"master","sha":"5967c5d92f54fe0cfb7ab4fa77103a5dc754fd11","user":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":2030681,"name":"HPCC-Platform","full_name":"hpcc-systems/HPCC-Platform","owner":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcc-systems/HPCC-Platform","description":"IMPORTANT - Issue tracking has been migrated to JIRA - use your github ID and password reset mechanism to log in","fork":false,"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform","forks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/releases{/id}","created_at":"2011-07-11T14:29:51Z","updated_at":"2015-07-12T17:42:50Z","pushed_at":"2015-07-11T16:22:42Z","git_url":"git://github.com/hpcc-systems/HPCC-Platform.git","ssh_url":"git@github.com:hpcc-systems/HPCC-Platform.git","clone_url":"https://github.com/hpcc-systems/HPCC-Platform.git","svn_url":"https://github.com/hpcc-systems/HPCC-Platform","homepage":"track.hpccsystems.com","size":337609,"stargazers_count":251,"watchers_count":251,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":117,"mirror_url":null,"open_issues_count":429,"forks":117,"open_issues":429,"watchers":251,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7551"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/7551"},"issue":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7551"},"comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7551/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7551/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7551/commits"},"statuses":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/dad342710c06025d3f3b517231f81fdabf60854b"}}}}