{"action":"created","issue":{"url":"https://api.github.com/repos/oscar-stack/vagrant-hosts/issues/49","labels_url":"https://api.github.com/repos/oscar-stack/vagrant-hosts/issues/49/labels{/name}","comments_url":"https://api.github.com/repos/oscar-stack/vagrant-hosts/issues/49/comments","events_url":"https://api.github.com/repos/oscar-stack/vagrant-hosts/issues/49/events","html_url":"https://github.com/oscar-stack/vagrant-hosts/pull/49","id":89617448,"number":49,"title":"Support fqdn-named Windows Vagrant machines","user":{"login":"reidmv","id":100142,"avatar_url":"https://avatars.githubusercontent.com/u/100142?v=3","gravatar_id":"","url":"https://api.github.com/users/reidmv","html_url":"https://github.com/reidmv","followers_url":"https://api.github.com/users/reidmv/followers","following_url":"https://api.github.com/users/reidmv/following{/other_user}","gists_url":"https://api.github.com/users/reidmv/gists{/gist_id}","starred_url":"https://api.github.com/users/reidmv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reidmv/subscriptions","organizations_url":"https://api.github.com/users/reidmv/orgs","repos_url":"https://api.github.com/users/reidmv/repos","events_url":"https://api.github.com/users/reidmv/events{/privacy}","received_events_url":"https://api.github.com/users/reidmv/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-06-19T17:24:18Z","updated_at":"2015-07-07T22:56:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/oscar-stack/vagrant-hosts/pulls/49","html_url":"https://github.com/oscar-stack/vagrant-hosts/pull/49","diff_url":"https://github.com/oscar-stack/vagrant-hosts/pull/49.diff","patch_url":"https://github.com/oscar-stack/vagrant-hosts/pull/49.patch"},"body":"Windows machine names cannot contain special characters and cannot be longer than 15 characters in length. However, it's reasonable to define Vagrant machines named by FQDN rather than windows-compliant short name.\r\n\r\nThis commit modifies the Windows change_hostname method to sanitize the vagrant machine name before attempting to change the name in the guest OS. It does so by converting illegal characters to \"-\", and if the name is too long truncating at the first illegal character.\r\n\r\nThe effective result of this should be that if a vagrant Windows machine has a name such as `win1.longdomain.evenlonger.net`, the vagrant-hosts provisioner will assign the guest OS the machine name `win1`."},"comment":{"url":"https://api.github.com/repos/oscar-stack/vagrant-hosts/issues/comments/119367433","html_url":"https://github.com/oscar-stack/vagrant-hosts/pull/49#issuecomment-119367433","issue_url":"https://api.github.com/repos/oscar-stack/vagrant-hosts/issues/49","id":119367433,"user":{"login":"adrienthebo","id":172194,"avatar_url":"https://avatars.githubusercontent.com/u/172194?v=3","gravatar_id":"","url":"https://api.github.com/users/adrienthebo","html_url":"https://github.com/adrienthebo","followers_url":"https://api.github.com/users/adrienthebo/followers","following_url":"https://api.github.com/users/adrienthebo/following{/other_user}","gists_url":"https://api.github.com/users/adrienthebo/gists{/gist_id}","starred_url":"https://api.github.com/users/adrienthebo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrienthebo/subscriptions","organizations_url":"https://api.github.com/users/adrienthebo/orgs","repos_url":"https://api.github.com/users/adrienthebo/repos","events_url":"https://api.github.com/users/adrienthebo/events{/privacy}","received_events_url":"https://api.github.com/users/adrienthebo/received_events","type":"User","site_admin":false},"created_at":"2015-07-07T22:56:41Z","updated_at":"2015-07-07T22:56:41Z","body":"@reidmv given that you're an owner on the project, I think you have the right to add features as you see fit :) If you want technical review then that's fine, but you have the authority to go with this wherever you like."}}