{"action":"created","issue":{"url":"https://api.github.com/repos/Southbank-Centre/OpenEvent/issues/37","labels_url":"https://api.github.com/repos/Southbank-Centre/OpenEvent/issues/37/labels{/name}","comments_url":"https://api.github.com/repos/Southbank-Centre/OpenEvent/issues/37/comments","events_url":"https://api.github.com/repos/Southbank-Centre/OpenEvent/issues/37/events","html_url":"https://github.com/Southbank-Centre/OpenEvent/pull/37","id":86101705,"number":37,"title":"95252412 api documentation","user":{"login":"samueljmurray","id":4062874,"avatar_url":"https://avatars.githubusercontent.com/u/4062874?v=3","gravatar_id":"","url":"https://api.github.com/users/samueljmurray","html_url":"https://github.com/samueljmurray","followers_url":"https://api.github.com/users/samueljmurray/followers","following_url":"https://api.github.com/users/samueljmurray/following{/other_user}","gists_url":"https://api.github.com/users/samueljmurray/gists{/gist_id}","starred_url":"https://api.github.com/users/samueljmurray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samueljmurray/subscriptions","organizations_url":"https://api.github.com/users/samueljmurray/orgs","repos_url":"https://api.github.com/users/samueljmurray/repos","events_url":"https://api.github.com/users/samueljmurray/events{/privacy}","received_events_url":"https://api.github.com/users/samueljmurray/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"jorgelopezlago","id":889030,"avatar_url":"https://avatars.githubusercontent.com/u/889030?v=3","gravatar_id":"","url":"https://api.github.com/users/jorgelopezlago","html_url":"https://github.com/jorgelopezlago","followers_url":"https://api.github.com/users/jorgelopezlago/followers","following_url":"https://api.github.com/users/jorgelopezlago/following{/other_user}","gists_url":"https://api.github.com/users/jorgelopezlago/gists{/gist_id}","starred_url":"https://api.github.com/users/jorgelopezlago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorgelopezlago/subscriptions","organizations_url":"https://api.github.com/users/jorgelopezlago/orgs","repos_url":"https://api.github.com/users/jorgelopezlago/repos","events_url":"https://api.github.com/users/jorgelopezlago/events{/privacy}","received_events_url":"https://api.github.com/users/jorgelopezlago/received_events","type":"User","site_admin":false},"milestone":null,"comments":5,"created_at":"2015-06-08T09:29:40Z","updated_at":"2015-06-08T12:47:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Southbank-Centre/OpenEvent/pulls/37","html_url":"https://github.com/Southbank-Centre/OpenEvent/pull/37","diff_url":"https://github.com/Southbank-Centre/OpenEvent/pull/37.diff","patch_url":"https://github.com/Southbank-Centre/OpenEvent/pull/37.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/Southbank-Centre/OpenEvent/issues/comments/109981027","html_url":"https://github.com/Southbank-Centre/OpenEvent/pull/37#issuecomment-109981027","issue_url":"https://api.github.com/repos/Southbank-Centre/OpenEvent/issues/37","id":109981027,"user":{"login":"samueljmurray","id":4062874,"avatar_url":"https://avatars.githubusercontent.com/u/4062874?v=3","gravatar_id":"","url":"https://api.github.com/users/samueljmurray","html_url":"https://github.com/samueljmurray","followers_url":"https://api.github.com/users/samueljmurray/followers","following_url":"https://api.github.com/users/samueljmurray/following{/other_user}","gists_url":"https://api.github.com/users/samueljmurray/gists{/gist_id}","starred_url":"https://api.github.com/users/samueljmurray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samueljmurray/subscriptions","organizations_url":"https://api.github.com/users/samueljmurray/orgs","repos_url":"https://api.github.com/users/samueljmurray/repos","events_url":"https://api.github.com/users/samueljmurray/events{/privacy}","received_events_url":"https://api.github.com/users/samueljmurray/received_events","type":"User","site_admin":false},"created_at":"2015-06-08T12:47:19Z","updated_at":"2015-06-08T12:47:19Z","body":"@jorgelopezlago @tassosk-cogapp I've made some changes:\r\n\r\nI've added the extra documentation you mentioned Jorge\r\n\r\n*\"The function builds and alters the $page array, but some of the output could be extracted to blocks to give more flexibility and overriding possibilities to the module\"*\r\n--> Yes it could but I think we should leave that for a future improvement\r\n\r\n*\"What are the possible values valid for $format? Are those strings? Can they be upper case?\"*\r\n--> These are strings, uppercase or lowercase is fine. Once we made more data formats available (XML, RDF etc.) links to view the documentation for those endpoints will appear at the top of the page, linking to /api/doc/xml, /api/doc/rdf etc.\r\n\r\n*\"Make sure the string manipulation for 'schema:' treatment agrees with the mapping main module\"*\r\n--> I've removed this now that the API schema mapping doesn't include 'schema:' in the property names\r\n\r\nI've also removed the permissions from the page because I think you're both right that it is a security issue. Showing it just for the drupal root user I don't think adds any value - they can view permissions on the permissions page."}}