{"action":"created","comment":{"url":"https://api.github.com/repos/4teamwork/ftw.subsite/pulls/comments/48263791","id":48263791,"diff_hunk":"@@ -85,7 +85,32 @@\n         name=\"FromEmail\",\n         widget=atapi.StringWidget(\n             label=_(u'label_fromemail', default=u'Email Senderaddress'),\n-            description=_(u'help_fromname', default=u'')))\n+            description=_(u'help_fromname', default=u''))),\n+\n+    atapi.TextField(\n+        name='webstatsAnalyticsSnippet',\n+        schemata='subsite',\n+        default_content_type='text/html',\n+        allowable_content_types=('text/html',),\n+        validators=('isTidyHtmlWithCleanup', ),","path":"ftw/subsite/content/subsite.py","position":12,"original_position":12,"commit_id":"ff2a9b9adf27bb7cd5921656effc8f78058979c6","original_commit_id":"ff2a9b9adf27bb7cd5921656effc8f78058979c6","user":{"login":"jone","id":7469,"avatar_url":"https://avatars.githubusercontent.com/u/7469?v=3","gravatar_id":"","url":"https://api.github.com/users/jone","html_url":"https://github.com/jone","followers_url":"https://api.github.com/users/jone/followers","following_url":"https://api.github.com/users/jone/following{/other_user}","gists_url":"https://api.github.com/users/jone/gists{/gist_id}","starred_url":"https://api.github.com/users/jone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jone/subscriptions","organizations_url":"https://api.github.com/users/jone/orgs","repos_url":"https://api.github.com/users/jone/repos","events_url":"https://api.github.com/users/jone/events{/privacy}","received_events_url":"https://api.github.com/users/jone/received_events","type":"User","site_admin":false},"body":"No, we should not allow `script`-tags, as this would introduce a security problem.\r\nI think we need to treat this HTML differently: we have to trust the user (as it is done in the default site configuration too).\r\nI propose to protect the field with a custom permission, so that only managers can do that by default. This reduces the group of attackable users.","created_at":"2015-12-22T15:31:38Z","updated_at":"2015-12-22T15:31:38Z","html_url":"https://github.com/4teamwork/ftw.subsite/pull/67#discussion_r48263791","pull_request_url":"https://api.github.com/repos/4teamwork/ftw.subsite/pulls/67","_links":{"self":{"href":"https://api.github.com/repos/4teamwork/ftw.subsite/pulls/comments/48263791"},"html":{"href":"https://github.com/4teamwork/ftw.subsite/pull/67#discussion_r48263791"},"pull_request":{"href":"https://api.github.com/repos/4teamwork/ftw.subsite/pulls/67"}}},"pull_request":{"url":"https://api.github.com/repos/4teamwork/ftw.subsite/pulls/67","id":53562263,"html_url":"https://github.com/4teamwork/ftw.subsite/pull/67","diff_url":"https://github.com/4teamwork/ftw.subsite/pull/67.diff","patch_url":"https://github.com/4teamwork/ftw.subsite/pull/67.patch","issue_url":"https://api.github.com/repos/4teamwork/ftw.subsite/issues/67","number":67,"state":"open","locked":false,"title":"Add new field for custom webstats analytics snippets per subsite.","user":{"login":"mbaechtold","id":28220,"avatar_url":"https://avatars.githubusercontent.com/u/28220?v=3","gravatar_id":"","url":"https://api.github.com/users/mbaechtold","html_url":"https://github.com/mbaechtold","followers_url":"https://api.github.com/users/mbaechtold/followers","following_url":"https://api.github.com/users/mbaechtold/following{/other_user}","gists_url":"https://api.github.com/users/mbaechtold/gists{/gist_id}","starred_url":"https://api.github.com/users/mbaechtold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbaechtold/subscriptions","organizations_url":"https://api.github.com/users/mbaechtold/orgs","repos_url":"https://api.github.com/users/mbaechtold/repos","events_url":"https://api.github.com/users/mbaechtold/events{/privacy}","received_events_url":"https://api.github.com/users/mbaechtold/received_events","type":"User","site_admin":false},"body":"This will allow to configure a webstats tracking code for each subsite.","created_at":"2015-12-14T13:09:24Z","updated_at":"2015-12-22T15:31:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a8ff4aa3683034b734ed3cbf0715ce7c8901cdd","assignee":{"login":"maethu","id":437933,"avatar_url":"https://avatars.githubusercontent.com/u/437933?v=3","gravatar_id":"","url":"https://api.github.com/users/maethu","html_url":"https://github.com/maethu","followers_url":"https://api.github.com/users/maethu/followers","following_url":"https://api.github.com/users/maethu/following{/other_user}","gists_url":"https://api.github.com/users/maethu/gists{/gist_id}","starred_url":"https://api.github.com/users/maethu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maethu/subscriptions","organizations_url":"https://api.github.com/users/maethu/orgs","repos_url":"https://api.github.com/users/maethu/repos","events_url":"https://api.github.com/users/maethu/events{/privacy}","received_events_url":"https://api.github.com/users/maethu/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/4teamwork/ftw.subsite/pulls/67/commits","review_comments_url":"https://api.github.com/repos/4teamwork/ftw.subsite/pulls/67/comments","review_comment_url":"https://api.github.com/repos/4teamwork/ftw.subsite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/4teamwork/ftw.subsite/issues/67/comments","statuses_url":"https://api.github.com/repos/4teamwork/ftw.subsite/statuses/ff2a9b9adf27bb7cd5921656effc8f78058979c6","head":{"label":"4teamwork:mba/custom-google-analytics-script","ref":"mba/custom-google-analytics-script","sha":"ff2a9b9adf27bb7cd5921656effc8f78058979c6","user":{"login":"4teamwork","id":681821,"avatar_url":"https://avatars.githubusercontent.com/u/681821?v=3","gravatar_id":"","url":"https://api.github.com/users/4teamwork","html_url":"https://github.com/4teamwork","followers_url":"https://api.github.com/users/4teamwork/followers","following_url":"https://api.github.com/users/4teamwork/following{/other_user}","gists_url":"https://api.github.com/users/4teamwork/gists{/gist_id}","starred_url":"https://api.github.com/users/4teamwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4teamwork/subscriptions","organizations_url":"https://api.github.com/users/4teamwork/orgs","repos_url":"https://api.github.com/users/4teamwork/repos","events_url":"https://api.github.com/users/4teamwork/events{/privacy}","received_events_url":"https://api.github.com/users/4teamwork/received_events","type":"Organization","site_admin":false},"repo":{"id":6455300,"name":"ftw.subsite","full_name":"4teamwork/ftw.subsite","owner":{"login":"4teamwork","id":681821,"avatar_url":"https://avatars.githubusercontent.com/u/681821?v=3","gravatar_id":"","url":"https://api.github.com/users/4teamwork","html_url":"https://github.com/4teamwork","followers_url":"https://api.github.com/users/4teamwork/followers","following_url":"https://api.github.com/users/4teamwork/following{/other_user}","gists_url":"https://api.github.com/users/4teamwork/gists{/gist_id}","starred_url":"https://api.github.com/users/4teamwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4teamwork/subscriptions","organizations_url":"https://api.github.com/users/4teamwork/orgs","repos_url":"https://api.github.com/users/4teamwork/repos","events_url":"https://api.github.com/users/4teamwork/events{/privacy}","received_events_url":"https://api.github.com/users/4teamwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/4teamwork/ftw.subsite","description":"Adds a Subsite functionality to Plone.","fork":false,"url":"https://api.github.com/repos/4teamwork/ftw.subsite","forks_url":"https://api.github.com/repos/4teamwork/ftw.subsite/forks","keys_url":"https://api.github.com/repos/4teamwork/ftw.subsite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/4teamwork/ftw.subsite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/4teamwork/ftw.subsite/teams","hooks_url":"https://api.github.com/repos/4teamwork/ftw.subsite/hooks","issue_events_url":"https://api.github.com/repos/4teamwork/ftw.subsite/issues/events{/number}","events_url":"https://api.github.com/repos/4teamwork/ftw.subsite/events","assignees_url":"https://api.github.com/repos/4teamwork/ftw.subsite/assignees{/user}","branches_url":"https://api.github.com/repos/4teamwork/ftw.subsite/branches{/branch}","tags_url":"https://api.github.com/repos/4teamwork/ftw.subsite/tags","blobs_url":"https://api.github.com/repos/4teamwork/ftw.subsite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/4teamwork/ftw.subsite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/4teamwork/ftw.subsite/git/refs{/sha}","trees_url":"https://api.github.com/repos/4teamwork/ftw.subsite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/4teamwork/ftw.subsite/statuses/{sha}","languages_url":"https://api.github.com/repos/4teamwork/ftw.subsite/languages","stargazers_url":"https://api.github.com/repos/4teamwork/ftw.subsite/stargazers","contributors_url":"https://api.github.com/repos/4teamwork/ftw.subsite/contributors","subscribers_url":"https://api.github.com/repos/4teamwork/ftw.subsite/subscribers","subscription_url":"https://api.github.com/repos/4teamwork/ftw.subsite/subscription","commits_url":"https://api.github.com/repos/4teamwork/ftw.subsite/commits{/sha}","git_commits_url":"https://api.github.com/repos/4teamwork/ftw.subsite/git/commits{/sha}","comments_url":"https://api.github.com/repos/4teamwork/ftw.subsite/comments{/number}","issue_comment_url":"https://api.github.com/repos/4teamwork/ftw.subsite/issues/comments{/number}","contents_url":"https://api.github.com/repos/4teamwork/ftw.subsite/contents/{+path}","compare_url":"https://api.github.com/repos/4teamwork/ftw.subsite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/4teamwork/ftw.subsite/merges","archive_url":"https://api.github.com/repos/4teamwork/ftw.subsite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/4teamwork/ftw.subsite/downloads","issues_url":"https://api.github.com/repos/4teamwork/ftw.subsite/issues{/number}","pulls_url":"https://api.github.com/repos/4teamwork/ftw.subsite/pulls{/number}","milestones_url":"https://api.github.com/repos/4teamwork/ftw.subsite/milestones{/number}","notifications_url":"https://api.github.com/repos/4teamwork/ftw.subsite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/4teamwork/ftw.subsite/labels{/name}","releases_url":"https://api.github.com/repos/4teamwork/ftw.subsite/releases{/id}","created_at":"2012-10-30T10:12:31Z","updated_at":"2015-05-08T10:15:56Z","pushed_at":"2015-12-15T08:57:51Z","git_url":"git://github.com/4teamwork/ftw.subsite.git","ssh_url":"git@github.com:4teamwork/ftw.subsite.git","clone_url":"https://github.com/4teamwork/ftw.subsite.git","svn_url":"https://github.com/4teamwork/ftw.subsite","homepage":"","size":263,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":7,"forks":2,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"4teamwork:1.x","ref":"1.x","sha":"700b25bcab8b37326a2eddd69c0e967b794505f7","user":{"login":"4teamwork","id":681821,"avatar_url":"https://avatars.githubusercontent.com/u/681821?v=3","gravatar_id":"","url":"https://api.github.com/users/4teamwork","html_url":"https://github.com/4teamwork","followers_url":"https://api.github.com/users/4teamwork/followers","following_url":"https://api.github.com/users/4teamwork/following{/other_user}","gists_url":"https://api.github.com/users/4teamwork/gists{/gist_id}","starred_url":"https://api.github.com/users/4teamwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4teamwork/subscriptions","organizations_url":"https://api.github.com/users/4teamwork/orgs","repos_url":"https://api.github.com/users/4teamwork/repos","events_url":"https://api.github.com/users/4teamwork/events{/privacy}","received_events_url":"https://api.github.com/users/4teamwork/received_events","type":"Organization","site_admin":false},"repo":{"id":6455300,"name":"ftw.subsite","full_name":"4teamwork/ftw.subsite","owner":{"login":"4teamwork","id":681821,"avatar_url":"https://avatars.githubusercontent.com/u/681821?v=3","gravatar_id":"","url":"https://api.github.com/users/4teamwork","html_url":"https://github.com/4teamwork","followers_url":"https://api.github.com/users/4teamwork/followers","following_url":"https://api.github.com/users/4teamwork/following{/other_user}","gists_url":"https://api.github.com/users/4teamwork/gists{/gist_id}","starred_url":"https://api.github.com/users/4teamwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4teamwork/subscriptions","organizations_url":"https://api.github.com/users/4teamwork/orgs","repos_url":"https://api.github.com/users/4teamwork/repos","events_url":"https://api.github.com/users/4teamwork/events{/privacy}","received_events_url":"https://api.github.com/users/4teamwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/4teamwork/ftw.subsite","description":"Adds a Subsite functionality to Plone.","fork":false,"url":"https://api.github.com/repos/4teamwork/ftw.subsite","forks_url":"https://api.github.com/repos/4teamwork/ftw.subsite/forks","keys_url":"https://api.github.com/repos/4teamwork/ftw.subsite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/4teamwork/ftw.subsite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/4teamwork/ftw.subsite/teams","hooks_url":"https://api.github.com/repos/4teamwork/ftw.subsite/hooks","issue_events_url":"https://api.github.com/repos/4teamwork/ftw.subsite/issues/events{/number}","events_url":"https://api.github.com/repos/4teamwork/ftw.subsite/events","assignees_url":"https://api.github.com/repos/4teamwork/ftw.subsite/assignees{/user}","branches_url":"https://api.github.com/repos/4teamwork/ftw.subsite/branches{/branch}","tags_url":"https://api.github.com/repos/4teamwork/ftw.subsite/tags","blobs_url":"https://api.github.com/repos/4teamwork/ftw.subsite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/4teamwork/ftw.subsite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/4teamwork/ftw.subsite/git/refs{/sha}","trees_url":"https://api.github.com/repos/4teamwork/ftw.subsite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/4teamwork/ftw.subsite/statuses/{sha}","languages_url":"https://api.github.com/repos/4teamwork/ftw.subsite/languages","stargazers_url":"https://api.github.com/repos/4teamwork/ftw.subsite/stargazers","contributors_url":"https://api.github.com/repos/4teamwork/ftw.subsite/contributors","subscribers_url":"https://api.github.com/repos/4teamwork/ftw.subsite/subscribers","subscription_url":"https://api.github.com/repos/4teamwork/ftw.subsite/subscription","commits_url":"https://api.github.com/repos/4teamwork/ftw.subsite/commits{/sha}","git_commits_url":"https://api.github.com/repos/4teamwork/ftw.subsite/git/commits{/sha}","comments_url":"https://api.github.com/repos/4teamwork/ftw.subsite/comments{/number}","issue_comment_url":"https://api.github.com/repos/4teamwork/ftw.subsite/issues/comments{/number}","contents_url":"https://api.github.com/repos/4teamwork/ftw.subsite/contents/{+path}","compare_url":"https://api.github.com/repos/4teamwork/ftw.subsite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/4teamwork/ftw.subsite/merges","archive_url":"https://api.github.com/repos/4teamwork/ftw.subsite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/4teamwork/ftw.subsite/downloads","issues_url":"https://api.github.com/repos/4teamwork/ftw.subsite/issues{/number}","pulls_url":"https://api.github.com/repos/4teamwork/ftw.subsite/pulls{/number}","milestones_url":"https://api.github.com/repos/4teamwork/ftw.subsite/milestones{/number}","notifications_url":"https://api.github.com/repos/4teamwork/ftw.subsite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/4teamwork/ftw.subsite/labels{/name}","releases_url":"https://api.github.com/repos/4teamwork/ftw.subsite/releases{/id}","created_at":"2012-10-30T10:12:31Z","updated_at":"2015-05-08T10:15:56Z","pushed_at":"2015-12-15T08:57:51Z","git_url":"git://github.com/4teamwork/ftw.subsite.git","ssh_url":"git@github.com:4teamwork/ftw.subsite.git","clone_url":"https://github.com/4teamwork/ftw.subsite.git","svn_url":"https://github.com/4teamwork/ftw.subsite","homepage":"","size":263,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":7,"forks":2,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/4teamwork/ftw.subsite/pulls/67"},"html":{"href":"https://github.com/4teamwork/ftw.subsite/pull/67"},"issue":{"href":"https://api.github.com/repos/4teamwork/ftw.subsite/issues/67"},"comments":{"href":"https://api.github.com/repos/4teamwork/ftw.subsite/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/4teamwork/ftw.subsite/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/4teamwork/ftw.subsite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/4teamwork/ftw.subsite/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/4teamwork/ftw.subsite/statuses/ff2a9b9adf27bb7cd5921656effc8f78058979c6"}}}}