{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/orleans/pulls/comments/38348773","id":38348773,"diff_hunk":"@@ -415,7 +460,14 @@ internal GlobalConfiguration()\n             ExpectedClusterSizeConfigValue = new ConfigValue<int>(DEFAULT_LIVENESS_EXPECTED_CLUSTER_SIZE, true);\n             ServiceId = Guid.Empty;\n             DeploymentId = Environment.UserName;\n-            DataConnectionString = \"\";\n+\n+            DataConnectionStringForLiveness = \"\";\n+            // Assume the ado invariant is for sql server storage if not explicitly specified\n+            AdoInvariantForLiveness = AdoNetInvariants.InvariantNameSqlServer;","path":"src/Orleans/Configuration/GlobalConfiguration.cs","position":143,"original_position":143,"commit_id":"b177491784885f83da9c5622d48898250b9cbbd5","original_commit_id":"b177491784885f83da9c5622d48898250b9cbbd5","user":{"login":"veikkoeeva","id":5158694,"avatar_url":"https://avatars.githubusercontent.com/u/5158694?v=3","gravatar_id":"","url":"https://api.github.com/users/veikkoeeva","html_url":"https://github.com/veikkoeeva","followers_url":"https://api.github.com/users/veikkoeeva/followers","following_url":"https://api.github.com/users/veikkoeeva/following{/other_user}","gists_url":"https://api.github.com/users/veikkoeeva/gists{/gist_id}","starred_url":"https://api.github.com/users/veikkoeeva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/veikkoeeva/subscriptions","organizations_url":"https://api.github.com/users/veikkoeeva/orgs","repos_url":"https://api.github.com/users/veikkoeeva/repos","events_url":"https://api.github.com/users/veikkoeeva/events{/privacy}","received_events_url":"https://api.github.com/users/veikkoeeva/received_events","type":"User","site_admin":false},"body":"I guess this is just a matter of how to solve this case. Some ideas:\r\n* If provider invariant is not given in the provider, use the default (SQL Server).\r\n* Hard-code the string \"System.Data.SqlClient\" to Orleans core to be used if nothing is provided in configuration.\r\n* Leave ``AdoNetInvariants`` to core and move other things outside, or perhaps split it in some fashion.\r\n\r\nThis is a problem to solve right now, but something to think about when moving ADO.NET system store code outside of core like Azure and ZooKeeper ones. I'm a bit tedious with this, but hopefully makes easier for \"outsiders\" to follow. :)","created_at":"2015-08-31T19:22:56Z","updated_at":"2015-08-31T19:22:56Z","html_url":"https://github.com/dotnet/orleans/pull/750#discussion_r38348773","pull_request_url":"https://api.github.com/repos/dotnet/orleans/pulls/750","_links":{"self":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/comments/38348773"},"html":{"href":"https://github.com/dotnet/orleans/pull/750#discussion_r38348773"},"pull_request":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/750"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/orleans/pulls/750","id":43760671,"html_url":"https://github.com/dotnet/orleans/pull/750","diff_url":"https://github.com/dotnet/orleans/pull/750.diff","patch_url":"https://github.com/dotnet/orleans/pull/750.patch","issue_url":"https://api.github.com/repos/dotnet/orleans/issues/750","number":750,"state":"open","locked":false,"title":"adding ado invariant to config and separating membership and reminders connection string","user":{"login":"shayhatsor","id":12084632,"avatar_url":"https://avatars.githubusercontent.com/u/12084632?v=3","gravatar_id":"","url":"https://api.github.com/users/shayhatsor","html_url":"https://github.com/shayhatsor","followers_url":"https://api.github.com/users/shayhatsor/followers","following_url":"https://api.github.com/users/shayhatsor/following{/other_user}","gists_url":"https://api.github.com/users/shayhatsor/gists{/gist_id}","starred_url":"https://api.github.com/users/shayhatsor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shayhatsor/subscriptions","organizations_url":"https://api.github.com/users/shayhatsor/orgs","repos_url":"https://api.github.com/users/shayhatsor/repos","events_url":"https://api.github.com/users/shayhatsor/events{/privacy}","received_events_url":"https://api.github.com/users/shayhatsor/received_events","type":"User","site_admin":false},"body":"This also solves #569.\r\nI'm currently testing this PR. while I am, I wanted to get your input on my solution. \r\nMain changes :\r\n* Kept the current defaults (SQL server as the default invariant name)\r\n* Kept the current behavior when reading config from xml\r\n* Changes in **GlobalConfiguration**\r\n * Removed DataConnectionString\r\n * Added DataConnectionStringForLiveness & AdoInvariantForLiveness\r\n * Added DataConnectionStringForReminders & AdoInvariantForReminders","created_at":"2015-08-31T12:47:43Z","updated_at":"2015-08-31T19:22:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea354c07d293453d6292053e2093808aab7be9ae","assignee":{"login":"gabikliot","id":10171207,"avatar_url":"https://avatars.githubusercontent.com/u/10171207?v=3","gravatar_id":"","url":"https://api.github.com/users/gabikliot","html_url":"https://github.com/gabikliot","followers_url":"https://api.github.com/users/gabikliot/followers","following_url":"https://api.github.com/users/gabikliot/following{/other_user}","gists_url":"https://api.github.com/users/gabikliot/gists{/gist_id}","starred_url":"https://api.github.com/users/gabikliot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabikliot/subscriptions","organizations_url":"https://api.github.com/users/gabikliot/orgs","repos_url":"https://api.github.com/users/gabikliot/repos","events_url":"https://api.github.com/users/gabikliot/events{/privacy}","received_events_url":"https://api.github.com/users/gabikliot/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/orleans/pulls/750/commits","review_comments_url":"https://api.github.com/repos/dotnet/orleans/pulls/750/comments","review_comment_url":"https://api.github.com/repos/dotnet/orleans/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/orleans/issues/750/comments","statuses_url":"https://api.github.com/repos/dotnet/orleans/statuses/b177491784885f83da9c5622d48898250b9cbbd5","head":{"label":"shayhatsor:master","ref":"master","sha":"b177491784885f83da9c5622d48898250b9cbbd5","user":{"login":"shayhatsor","id":12084632,"avatar_url":"https://avatars.githubusercontent.com/u/12084632?v=3","gravatar_id":"","url":"https://api.github.com/users/shayhatsor","html_url":"https://github.com/shayhatsor","followers_url":"https://api.github.com/users/shayhatsor/followers","following_url":"https://api.github.com/users/shayhatsor/following{/other_user}","gists_url":"https://api.github.com/users/shayhatsor/gists{/gist_id}","starred_url":"https://api.github.com/users/shayhatsor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shayhatsor/subscriptions","organizations_url":"https://api.github.com/users/shayhatsor/orgs","repos_url":"https://api.github.com/users/shayhatsor/repos","events_url":"https://api.github.com/users/shayhatsor/events{/privacy}","received_events_url":"https://api.github.com/users/shayhatsor/received_events","type":"User","site_admin":false},"repo":{"id":36598230,"name":"orleans","full_name":"shayhatsor/orleans","owner":{"login":"shayhatsor","id":12084632,"avatar_url":"https://avatars.githubusercontent.com/u/12084632?v=3","gravatar_id":"","url":"https://api.github.com/users/shayhatsor","html_url":"https://github.com/shayhatsor","followers_url":"https://api.github.com/users/shayhatsor/followers","following_url":"https://api.github.com/users/shayhatsor/following{/other_user}","gists_url":"https://api.github.com/users/shayhatsor/gists{/gist_id}","starred_url":"https://api.github.com/users/shayhatsor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shayhatsor/subscriptions","organizations_url":"https://api.github.com/users/shayhatsor/orgs","repos_url":"https://api.github.com/users/shayhatsor/repos","events_url":"https://api.github.com/users/shayhatsor/events{/privacy}","received_events_url":"https://api.github.com/users/shayhatsor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shayhatsor/orleans","description":"Orleans - Distributed Virtual Actor Model","fork":true,"url":"https://api.github.com/repos/shayhatsor/orleans","forks_url":"https://api.github.com/repos/shayhatsor/orleans/forks","keys_url":"https://api.github.com/repos/shayhatsor/orleans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shayhatsor/orleans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shayhatsor/orleans/teams","hooks_url":"https://api.github.com/repos/shayhatsor/orleans/hooks","issue_events_url":"https://api.github.com/repos/shayhatsor/orleans/issues/events{/number}","events_url":"https://api.github.com/repos/shayhatsor/orleans/events","assignees_url":"https://api.github.com/repos/shayhatsor/orleans/assignees{/user}","branches_url":"https://api.github.com/repos/shayhatsor/orleans/branches{/branch}","tags_url":"https://api.github.com/repos/shayhatsor/orleans/tags","blobs_url":"https://api.github.com/repos/shayhatsor/orleans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shayhatsor/orleans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shayhatsor/orleans/git/refs{/sha}","trees_url":"https://api.github.com/repos/shayhatsor/orleans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shayhatsor/orleans/statuses/{sha}","languages_url":"https://api.github.com/repos/shayhatsor/orleans/languages","stargazers_url":"https://api.github.com/repos/shayhatsor/orleans/stargazers","contributors_url":"https://api.github.com/repos/shayhatsor/orleans/contributors","subscribers_url":"https://api.github.com/repos/shayhatsor/orleans/subscribers","subscription_url":"https://api.github.com/repos/shayhatsor/orleans/subscription","commits_url":"https://api.github.com/repos/shayhatsor/orleans/commits{/sha}","git_commits_url":"https://api.github.com/repos/shayhatsor/orleans/git/commits{/sha}","comments_url":"https://api.github.com/repos/shayhatsor/orleans/comments{/number}","issue_comment_url":"https://api.github.com/repos/shayhatsor/orleans/issues/comments{/number}","contents_url":"https://api.github.com/repos/shayhatsor/orleans/contents/{+path}","compare_url":"https://api.github.com/repos/shayhatsor/orleans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shayhatsor/orleans/merges","archive_url":"https://api.github.com/repos/shayhatsor/orleans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shayhatsor/orleans/downloads","issues_url":"https://api.github.com/repos/shayhatsor/orleans/issues{/number}","pulls_url":"https://api.github.com/repos/shayhatsor/orleans/pulls{/number}","milestones_url":"https://api.github.com/repos/shayhatsor/orleans/milestones{/number}","notifications_url":"https://api.github.com/repos/shayhatsor/orleans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shayhatsor/orleans/labels{/name}","releases_url":"https://api.github.com/repos/shayhatsor/orleans/releases{/id}","created_at":"2015-05-31T10:30:59Z","updated_at":"2015-05-31T10:31:01Z","pushed_at":"2015-08-31T14:07:47Z","git_url":"git://github.com/shayhatsor/orleans.git","ssh_url":"git@github.com:shayhatsor/orleans.git","clone_url":"https://github.com/shayhatsor/orleans.git","svn_url":"https://github.com/shayhatsor/orleans","homepage":"http://dotnet.github.io/orleans","size":9357,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"52e153ced30ecd794627fa51c1e6ba13f6e44cac","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":28232663,"name":"orleans","full_name":"dotnet/orleans","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/orleans","description":"Orleans - Distributed Virtual Actor Model","fork":false,"url":"https://api.github.com/repos/dotnet/orleans","forks_url":"https://api.github.com/repos/dotnet/orleans/forks","keys_url":"https://api.github.com/repos/dotnet/orleans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/orleans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/orleans/teams","hooks_url":"https://api.github.com/repos/dotnet/orleans/hooks","issue_events_url":"https://api.github.com/repos/dotnet/orleans/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/orleans/events","assignees_url":"https://api.github.com/repos/dotnet/orleans/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/orleans/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/orleans/tags","blobs_url":"https://api.github.com/repos/dotnet/orleans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/orleans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/orleans/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/orleans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/orleans/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/orleans/languages","stargazers_url":"https://api.github.com/repos/dotnet/orleans/stargazers","contributors_url":"https://api.github.com/repos/dotnet/orleans/contributors","subscribers_url":"https://api.github.com/repos/dotnet/orleans/subscribers","subscription_url":"https://api.github.com/repos/dotnet/orleans/subscription","commits_url":"https://api.github.com/repos/dotnet/orleans/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/orleans/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/orleans/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/orleans/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/orleans/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/orleans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/orleans/merges","archive_url":"https://api.github.com/repos/dotnet/orleans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/orleans/downloads","issues_url":"https://api.github.com/repos/dotnet/orleans/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/orleans/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/orleans/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/orleans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/orleans/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/orleans/releases{/id}","created_at":"2014-12-19T14:32:50Z","updated_at":"2015-08-29T00:58:46Z","pushed_at":"2015-08-31T14:07:47Z","git_url":"git://github.com/dotnet/orleans.git","ssh_url":"git@github.com:dotnet/orleans.git","clone_url":"https://github.com/dotnet/orleans.git","svn_url":"https://github.com/dotnet/orleans","homepage":"http://dotnet.github.io/orleans","size":31759,"stargazers_count":1108,"watchers_count":1108,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":246,"mirror_url":null,"open_issues_count":77,"forks":246,"open_issues":77,"watchers":1108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/750"},"html":{"href":"https://github.com/dotnet/orleans/pull/750"},"issue":{"href":"https://api.github.com/repos/dotnet/orleans/issues/750"},"comments":{"href":"https://api.github.com/repos/dotnet/orleans/issues/750/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/750/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/750/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/orleans/statuses/b177491784885f83da9c5622d48898250b9cbbd5"}}}}