{"action":"created","issue":{"url":"https://api.github.com/repos/dberesford/exiv2node/issues/40","labels_url":"https://api.github.com/repos/dberesford/exiv2node/issues/40/labels{/name}","comments_url":"https://api.github.com/repos/dberesford/exiv2node/issues/40/comments","events_url":"https://api.github.com/repos/dberesford/exiv2node/issues/40/events","html_url":"https://github.com/dberesford/exiv2node/pull/40","id":111099146,"number":40,"title":"Fix the OS X build","user":{"login":"drewish","id":68750,"avatar_url":"https://avatars.githubusercontent.com/u/68750?v=3","gravatar_id":"","url":"https://api.github.com/users/drewish","html_url":"https://github.com/drewish","followers_url":"https://api.github.com/users/drewish/followers","following_url":"https://api.github.com/users/drewish/following{/other_user}","gists_url":"https://api.github.com/users/drewish/gists{/gist_id}","starred_url":"https://api.github.com/users/drewish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewish/subscriptions","organizations_url":"https://api.github.com/users/drewish/orgs","repos_url":"https://api.github.com/users/drewish/repos","events_url":"https://api.github.com/users/drewish/events{/privacy}","received_events_url":"https://api.github.com/users/drewish/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-13T03:59:33Z","updated_at":"2015-10-13T07:21:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dberesford/exiv2node/pulls/40","html_url":"https://github.com/dberesford/exiv2node/pull/40","diff_url":"https://github.com/dberesford/exiv2node/pull/40.diff","patch_url":"https://github.com/dberesford/exiv2node/pull/40.patch"},"body":"The only thing that the `cflags` setting is being used for is passing in the includes. Those should technically go in the `include_dirs`. Moving these should fix the build issues some folks have been experiencing on El Capitan https://github.com/dberesford/exiv2node/issues/39.\r\n\r\nWhile I was in here I noticed that what we've got `ldflags` duplicates what is already in `libraries` so I'm removing it."},"comment":{"url":"https://api.github.com/repos/dberesford/exiv2node/issues/comments/147627606","html_url":"https://github.com/dberesford/exiv2node/pull/40#issuecomment-147627606","issue_url":"https://api.github.com/repos/dberesford/exiv2node/issues/40","id":147627606,"user":{"login":"dberesford","id":602445,"avatar_url":"https://avatars.githubusercontent.com/u/602445?v=3","gravatar_id":"","url":"https://api.github.com/users/dberesford","html_url":"https://github.com/dberesford","followers_url":"https://api.github.com/users/dberesford/followers","following_url":"https://api.github.com/users/dberesford/following{/other_user}","gists_url":"https://api.github.com/users/dberesford/gists{/gist_id}","starred_url":"https://api.github.com/users/dberesford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dberesford/subscriptions","organizations_url":"https://api.github.com/users/dberesford/orgs","repos_url":"https://api.github.com/users/dberesford/repos","events_url":"https://api.github.com/users/dberesford/events{/privacy}","received_events_url":"https://api.github.com/users/dberesford/received_events","type":"User","site_admin":false},"created_at":"2015-10-13T07:21:19Z","updated_at":"2015-10-13T07:21:19Z","body":"LGTM - nice work @drewish - and thanks also @rayshan :-)"}}