{"action":"closed","number":90,"pull_request":{"url":"https://api.github.com/repos/cfpb/retirement/pulls/90","id":41715880,"html_url":"https://github.com/cfpb/retirement/pull/90","diff_url":"https://github.com/cfpb/retirement/pull/90.diff","patch_url":"https://github.com/cfpb/retirement/pull/90.patch","issue_url":"https://api.github.com/repos/cfpb/retirement/issues/90","number":90,"state":"closed","locked":false,"title":"Disable autocomplete for DOB and salary inputs","user":{"login":"niqjohnson","id":1862695,"avatar_url":"https://avatars.githubusercontent.com/u/1862695?v=3","gravatar_id":"","url":"https://api.github.com/users/niqjohnson","html_url":"https://github.com/niqjohnson","followers_url":"https://api.github.com/users/niqjohnson/followers","following_url":"https://api.github.com/users/niqjohnson/following{/other_user}","gists_url":"https://api.github.com/users/niqjohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/niqjohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niqjohnson/subscriptions","organizations_url":"https://api.github.com/users/niqjohnson/orgs","repos_url":"https://api.github.com/users/niqjohnson/repos","events_url":"https://api.github.com/users/niqjohnson/events{/privacy}","received_events_url":"https://api.github.com/users/niqjohnson/received_events","type":"User","site_admin":false},"body":"Disable autocapitalize, autocomplete, autocorrect, and spellcheck for DOB and salary inputs. This change is mostly to prevent cases where autocompleting any of the fields prevents the \"Get your estimate\" button from becoming active.\r\n\r\n## Additions\r\n\r\n- Add `autocapitalize`, `autocomplete`, `autocorrect`, and `spellcheck` attributes to the DOB and salary inputs\r\n\r\n## Testing\r\n\r\n- Tested in Chrome, Safari, and my iPhone 6. The only way to enter data into the DOB and salary fields is now to type with whatever keyboard your device is using (well, other than copying and pasting, but I'm not even going there). That's important because the form is listening to `keyup` events to see if all the fields are completed and the \"Get your estimate\" button can be turned on; autocompleting a field doesn't fire a `keyup`.\r\n- Can someone with an Android phone test this out to make sure you can't autocomplete any of the fields?\r\n\r\n## Review\r\n\r\n- @marteki\r\n- @mistergone\r\n- anyone else with a touch device who wants to check this out\r\n\r\n## Checklist\r\n\r\n* [x] Changes are limited to a single goal (no scope creep)\r\n* [x] Code can be automatically merged (no conflicts)\r\n* [x] Code follows the standards laid out in the [front end playbook](https://github.com/cfpb/front-end)\r\n* [x] Visually tested in supported browsers and devices ","created_at":"2015-08-05T19:23:05Z","updated_at":"2015-08-07T18:15:58Z","closed_at":"2015-08-07T18:15:57Z","merged_at":"2015-08-07T18:15:57Z","merge_commit_sha":"8fc892566cbc576e48cc66cee0a6d072688ce102","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cfpb/retirement/pulls/90/commits","review_comments_url":"https://api.github.com/repos/cfpb/retirement/pulls/90/comments","review_comment_url":"https://api.github.com/repos/cfpb/retirement/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cfpb/retirement/issues/90/comments","statuses_url":"https://api.github.com/repos/cfpb/retirement/statuses/ede7afae20f45bf1cd77ac82e4026bc0beb03aa7","head":{"label":"cfpb:disable-autocomplete","ref":"disable-autocomplete","sha":"ede7afae20f45bf1cd77ac82e4026bc0beb03aa7","user":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"repo":{"id":31082299,"name":"retirement","full_name":"cfpb/retirement","owner":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cfpb/retirement","description":"Helping Americans make choices about retirement","fork":false,"url":"https://api.github.com/repos/cfpb/retirement","forks_url":"https://api.github.com/repos/cfpb/retirement/forks","keys_url":"https://api.github.com/repos/cfpb/retirement/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfpb/retirement/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfpb/retirement/teams","hooks_url":"https://api.github.com/repos/cfpb/retirement/hooks","issue_events_url":"https://api.github.com/repos/cfpb/retirement/issues/events{/number}","events_url":"https://api.github.com/repos/cfpb/retirement/events","assignees_url":"https://api.github.com/repos/cfpb/retirement/assignees{/user}","branches_url":"https://api.github.com/repos/cfpb/retirement/branches{/branch}","tags_url":"https://api.github.com/repos/cfpb/retirement/tags","blobs_url":"https://api.github.com/repos/cfpb/retirement/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfpb/retirement/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfpb/retirement/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfpb/retirement/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfpb/retirement/statuses/{sha}","languages_url":"https://api.github.com/repos/cfpb/retirement/languages","stargazers_url":"https://api.github.com/repos/cfpb/retirement/stargazers","contributors_url":"https://api.github.com/repos/cfpb/retirement/contributors","subscribers_url":"https://api.github.com/repos/cfpb/retirement/subscribers","subscription_url":"https://api.github.com/repos/cfpb/retirement/subscription","commits_url":"https://api.github.com/repos/cfpb/retirement/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfpb/retirement/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfpb/retirement/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfpb/retirement/issues/comments{/number}","contents_url":"https://api.github.com/repos/cfpb/retirement/contents/{+path}","compare_url":"https://api.github.com/repos/cfpb/retirement/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfpb/retirement/merges","archive_url":"https://api.github.com/repos/cfpb/retirement/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfpb/retirement/downloads","issues_url":"https://api.github.com/repos/cfpb/retirement/issues{/number}","pulls_url":"https://api.github.com/repos/cfpb/retirement/pulls{/number}","milestones_url":"https://api.github.com/repos/cfpb/retirement/milestones{/number}","notifications_url":"https://api.github.com/repos/cfpb/retirement/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfpb/retirement/labels{/name}","releases_url":"https://api.github.com/repos/cfpb/retirement/releases{/id}","created_at":"2015-02-20T19:53:05Z","updated_at":"2015-07-11T17:52:24Z","pushed_at":"2015-08-07T18:15:57Z","git_url":"git://github.com/cfpb/retirement.git","ssh_url":"git@github.com:cfpb/retirement.git","clone_url":"https://github.com/cfpb/retirement.git","svn_url":"https://github.com/cfpb/retirement","homepage":"","size":2883,"stargazers_count":6,"watchers_count":6,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":3,"forks":17,"open_issues":3,"watchers":6,"default_branch":"master"}},"base":{"label":"cfpb:master","ref":"master","sha":"d16a5483d00dd36cdd21e2863d49d8d13cb7126c","user":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"repo":{"id":31082299,"name":"retirement","full_name":"cfpb/retirement","owner":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cfpb/retirement","description":"Helping Americans make choices about retirement","fork":false,"url":"https://api.github.com/repos/cfpb/retirement","forks_url":"https://api.github.com/repos/cfpb/retirement/forks","keys_url":"https://api.github.com/repos/cfpb/retirement/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfpb/retirement/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfpb/retirement/teams","hooks_url":"https://api.github.com/repos/cfpb/retirement/hooks","issue_events_url":"https://api.github.com/repos/cfpb/retirement/issues/events{/number}","events_url":"https://api.github.com/repos/cfpb/retirement/events","assignees_url":"https://api.github.com/repos/cfpb/retirement/assignees{/user}","branches_url":"https://api.github.com/repos/cfpb/retirement/branches{/branch}","tags_url":"https://api.github.com/repos/cfpb/retirement/tags","blobs_url":"https://api.github.com/repos/cfpb/retirement/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfpb/retirement/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfpb/retirement/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfpb/retirement/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfpb/retirement/statuses/{sha}","languages_url":"https://api.github.com/repos/cfpb/retirement/languages","stargazers_url":"https://api.github.com/repos/cfpb/retirement/stargazers","contributors_url":"https://api.github.com/repos/cfpb/retirement/contributors","subscribers_url":"https://api.github.com/repos/cfpb/retirement/subscribers","subscription_url":"https://api.github.com/repos/cfpb/retirement/subscription","commits_url":"https://api.github.com/repos/cfpb/retirement/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfpb/retirement/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfpb/retirement/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfpb/retirement/issues/comments{/number}","contents_url":"https://api.github.com/repos/cfpb/retirement/contents/{+path}","compare_url":"https://api.github.com/repos/cfpb/retirement/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfpb/retirement/merges","archive_url":"https://api.github.com/repos/cfpb/retirement/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfpb/retirement/downloads","issues_url":"https://api.github.com/repos/cfpb/retirement/issues{/number}","pulls_url":"https://api.github.com/repos/cfpb/retirement/pulls{/number}","milestones_url":"https://api.github.com/repos/cfpb/retirement/milestones{/number}","notifications_url":"https://api.github.com/repos/cfpb/retirement/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfpb/retirement/labels{/name}","releases_url":"https://api.github.com/repos/cfpb/retirement/releases{/id}","created_at":"2015-02-20T19:53:05Z","updated_at":"2015-07-11T17:52:24Z","pushed_at":"2015-08-07T18:15:57Z","git_url":"git://github.com/cfpb/retirement.git","ssh_url":"git@github.com:cfpb/retirement.git","clone_url":"https://github.com/cfpb/retirement.git","svn_url":"https://github.com/cfpb/retirement","homepage":"","size":2883,"stargazers_count":6,"watchers_count":6,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":3,"forks":17,"open_issues":3,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cfpb/retirement/pulls/90"},"html":{"href":"https://github.com/cfpb/retirement/pull/90"},"issue":{"href":"https://api.github.com/repos/cfpb/retirement/issues/90"},"comments":{"href":"https://api.github.com/repos/cfpb/retirement/issues/90/comments"},"review_comments":{"href":"https://api.github.com/repos/cfpb/retirement/pulls/90/comments"},"review_comment":{"href":"https://api.github.com/repos/cfpb/retirement/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cfpb/retirement/pulls/90/commits"},"statuses":{"href":"https://api.github.com/repos/cfpb/retirement/statuses/ede7afae20f45bf1cd77ac82e4026bc0beb03aa7"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"niqjohnson","id":1862695,"avatar_url":"https://avatars.githubusercontent.com/u/1862695?v=3","gravatar_id":"","url":"https://api.github.com/users/niqjohnson","html_url":"https://github.com/niqjohnson","followers_url":"https://api.github.com/users/niqjohnson/followers","following_url":"https://api.github.com/users/niqjohnson/following{/other_user}","gists_url":"https://api.github.com/users/niqjohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/niqjohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niqjohnson/subscriptions","organizations_url":"https://api.github.com/users/niqjohnson/orgs","repos_url":"https://api.github.com/users/niqjohnson/repos","events_url":"https://api.github.com/users/niqjohnson/events{/privacy}","received_events_url":"https://api.github.com/users/niqjohnson/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":24,"deletions":24,"changed_files":1}}