{"action":"created","issue":{"url":"https://api.github.com/repos/django/django/issues/5282","labels_url":"https://api.github.com/repos/django/django/issues/5282/labels{/name}","comments_url":"https://api.github.com/repos/django/django/issues/5282/comments","events_url":"https://api.github.com/repos/django/django/issues/5282/events","html_url":"https://github.com/django/django/pull/5282","id":106203183,"number":5282,"title":"Fixed connection.queries on SQLite.","user":{"login":"aaugustin","id":788910,"avatar_url":"https://avatars.githubusercontent.com/u/788910?v=3","gravatar_id":"","url":"https://api.github.com/users/aaugustin","html_url":"https://github.com/aaugustin","followers_url":"https://api.github.com/users/aaugustin/followers","following_url":"https://api.github.com/users/aaugustin/following{/other_user}","gists_url":"https://api.github.com/users/aaugustin/gists{/gist_id}","starred_url":"https://api.github.com/users/aaugustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaugustin/subscriptions","organizations_url":"https://api.github.com/users/aaugustin/orgs","repos_url":"https://api.github.com/users/aaugustin/repos","events_url":"https://api.github.com/users/aaugustin/events{/privacy}","received_events_url":"https://api.github.com/users/aaugustin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-13T07:33:01Z","updated_at":"2015-09-13T07:43:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/django/django/pulls/5282","html_url":"https://github.com/django/django/pull/5282","diff_url":"https://github.com/django/django/pull/5282.diff","patch_url":"https://github.com/django/django/pull/5282.patch"},"body":"Refs #14091."},"comment":{"url":"https://api.github.com/repos/django/django/issues/comments/139849284","html_url":"https://github.com/django/django/pull/5282#issuecomment-139849284","issue_url":"https://api.github.com/repos/django/django/issues/5282","id":139849284,"user":{"login":"aaugustin","id":788910,"avatar_url":"https://avatars.githubusercontent.com/u/788910?v=3","gravatar_id":"","url":"https://api.github.com/users/aaugustin","html_url":"https://github.com/aaugustin","followers_url":"https://api.github.com/users/aaugustin/followers","following_url":"https://api.github.com/users/aaugustin/following{/other_user}","gists_url":"https://api.github.com/users/aaugustin/gists{/gist_id}","starred_url":"https://api.github.com/users/aaugustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaugustin/subscriptions","organizations_url":"https://api.github.com/users/aaugustin/orgs","repos_url":"https://api.github.com/users/aaugustin/repos","events_url":"https://api.github.com/users/aaugustin/events{/privacy}","received_events_url":"https://api.github.com/users/aaugustin/received_events","type":"User","site_admin":false},"created_at":"2015-09-13T07:43:08Z","updated_at":"2015-09-13T07:43:08Z","body":"Alex and Jacob rejected that approach when I first submitted it on [ticket 14091](https://code.djangoproject.com/ticket/14091).\r\n\r\nI still believe it would be a good thing for beginners who are learning with SQLite. We shouldn't inflict manual substitution of parameters in SQL on them just because they haven't figured out how to install a database server yet.\r\n\r\nThe implementation won't score points for elegance but I don't see anything wrong with it. The point of abstinence-only education about building SQL with string interpolation is to avoid substituting unescaped parameters in SQL. We're writing a framework to handle this sort of mess so our users don't have to. \r\n\r\nHere I'm asking the database to escape parameters. That's the safest approach I can think of. It doesn't suffer from the problems of PHP's `mysql_escape_string`, a reimplementation that doesn't handle all cases correctly."}}