{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/source-map/pulls/comments/35960773","id":35960773,"diff_hunk":"@@ -305,10 +305,20 @@ define(function (require, exports, module) {\n       throw new Error('Unsupported version: ' + version);\n     }\n \n-    // Some source maps produce relative source paths like \"./foo.js\" instead of\n-    // \"foo.js\".  Normalize these first so that future comparisons will succeed.\n-    // See bugzil.la/1090768.\n-    sources = sources.map(util.normalize);\n+    sources = sources\n+      // Some source maps produce relative source paths like \"./foo.js\" instead of\n+      // \"foo.js\".  Normalize these first so that future comparisons will succeed.\n+      // See bugzil.la/1090768.\n+      .map(util.normalize)\n+      // Always ensure that absolute sources are internally stored relative to\n+      // the source root, if the source root is absolute. Not doing this would\n+      // be particularly problematic when the source root is a prefix of the\n+      // source (valid, but why??). See github issue #199 and bugzil.la/1188982.\n+      .map(function (source) {\n+        return sourceRoot && sourceRoot.charAt(0) === '/' && source.charAt(0) === '/'","path":"lib/source-map/source-map-consumer.js","position":18,"original_position":18,"commit_id":"bb389320ad2530530ffb5923d2016b033275f966","original_commit_id":"bb389320ad2530530ffb5923d2016b033275f966","user":{"login":"fitzgen","id":74571,"avatar_url":"https://avatars.githubusercontent.com/u/74571?v=3","gravatar_id":"","url":"https://api.github.com/users/fitzgen","html_url":"https://github.com/fitzgen","followers_url":"https://api.github.com/users/fitzgen/followers","following_url":"https://api.github.com/users/fitzgen/following{/other_user}","gists_url":"https://api.github.com/users/fitzgen/gists{/gist_id}","starred_url":"https://api.github.com/users/fitzgen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fitzgen/subscriptions","organizations_url":"https://api.github.com/users/fitzgen/orgs","repos_url":"https://api.github.com/users/fitzgen/repos","events_url":"https://api.github.com/users/fitzgen/events{/privacy}","received_events_url":"https://api.github.com/users/fitzgen/received_events","type":"User","site_admin":false},"body":"I got halfway through writing a comment about why I didn't think so, but then unconvinced myself and finally realized that we should just add test coverage for more edge cases here...","created_at":"2015-07-31T09:57:10Z","updated_at":"2015-07-31T09:57:10Z","html_url":"https://github.com/mozilla/source-map/pull/199#discussion_r35960773","pull_request_url":"https://api.github.com/repos/mozilla/source-map/pulls/199","_links":{"self":{"href":"https://api.github.com/repos/mozilla/source-map/pulls/comments/35960773"},"html":{"href":"https://github.com/mozilla/source-map/pull/199#discussion_r35960773"},"pull_request":{"href":"https://api.github.com/repos/mozilla/source-map/pulls/199"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/source-map/pulls/199","id":41173284,"html_url":"https://github.com/mozilla/source-map/pull/199","diff_url":"https://github.com/mozilla/source-map/pull/199.diff","patch_url":"https://github.com/mozilla/source-map/pull/199.patch","issue_url":"https://api.github.com/repos/mozilla/source-map/issues/199","number":199,"state":"open","locked":false,"title":"Bug in getting embedded source contents","user":{"login":"fitzgen","id":74571,"avatar_url":"https://avatars.githubusercontent.com/u/74571?v=3","gravatar_id":"","url":"https://api.github.com/users/fitzgen","html_url":"https://github.com/fitzgen","followers_url":"https://api.github.com/users/fitzgen/followers","following_url":"https://api.github.com/users/fitzgen/following{/other_user}","gists_url":"https://api.github.com/users/fitzgen/gists{/gist_id}","starred_url":"https://api.github.com/users/fitzgen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fitzgen/subscriptions","organizations_url":"https://api.github.com/users/fitzgen/orgs","repos_url":"https://api.github.com/users/fitzgen/repos","events_url":"https://api.github.com/users/fitzgen/events{/privacy}","received_events_url":"https://api.github.com/users/fitzgen/received_events","type":"User","site_admin":false},"body":"This is just a failing test case right now. Haven't dug into it yet.\r\n\r\nSee also https://bugzilla.mozilla.org/show_bug.cgi?id=1188697","created_at":"2015-07-29T21:17:28Z","updated_at":"2015-07-31T09:57:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"abf2e2ccea89fea1ad7df61baba8f6f6153668fa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/source-map/pulls/199/commits","review_comments_url":"https://api.github.com/repos/mozilla/source-map/pulls/199/comments","review_comment_url":"https://api.github.com/repos/mozilla/source-map/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/source-map/issues/199/comments","statuses_url":"https://api.github.com/repos/mozilla/source-map/statuses/bb389320ad2530530ffb5923d2016b033275f966","head":{"label":"fitzgen:source-content-bug","ref":"source-content-bug","sha":"bb389320ad2530530ffb5923d2016b033275f966","user":{"login":"fitzgen","id":74571,"avatar_url":"https://avatars.githubusercontent.com/u/74571?v=3","gravatar_id":"","url":"https://api.github.com/users/fitzgen","html_url":"https://github.com/fitzgen","followers_url":"https://api.github.com/users/fitzgen/followers","following_url":"https://api.github.com/users/fitzgen/following{/other_user}","gists_url":"https://api.github.com/users/fitzgen/gists{/gist_id}","starred_url":"https://api.github.com/users/fitzgen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fitzgen/subscriptions","organizations_url":"https://api.github.com/users/fitzgen/orgs","repos_url":"https://api.github.com/users/fitzgen/repos","events_url":"https://api.github.com/users/fitzgen/events{/privacy}","received_events_url":"https://api.github.com/users/fitzgen/received_events","type":"User","site_admin":false},"repo":{"id":2684241,"name":"source-map","full_name":"fitzgen/source-map","owner":{"login":"fitzgen","id":74571,"avatar_url":"https://avatars.githubusercontent.com/u/74571?v=3","gravatar_id":"","url":"https://api.github.com/users/fitzgen","html_url":"https://github.com/fitzgen","followers_url":"https://api.github.com/users/fitzgen/followers","following_url":"https://api.github.com/users/fitzgen/following{/other_user}","gists_url":"https://api.github.com/users/fitzgen/gists{/gist_id}","starred_url":"https://api.github.com/users/fitzgen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fitzgen/subscriptions","organizations_url":"https://api.github.com/users/fitzgen/orgs","repos_url":"https://api.github.com/users/fitzgen/repos","events_url":"https://api.github.com/users/fitzgen/events{/privacy}","received_events_url":"https://api.github.com/users/fitzgen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fitzgen/source-map","description":"Generate and consume source maps.","fork":true,"url":"https://api.github.com/repos/fitzgen/source-map","forks_url":"https://api.github.com/repos/fitzgen/source-map/forks","keys_url":"https://api.github.com/repos/fitzgen/source-map/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fitzgen/source-map/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fitzgen/source-map/teams","hooks_url":"https://api.github.com/repos/fitzgen/source-map/hooks","issue_events_url":"https://api.github.com/repos/fitzgen/source-map/issues/events{/number}","events_url":"https://api.github.com/repos/fitzgen/source-map/events","assignees_url":"https://api.github.com/repos/fitzgen/source-map/assignees{/user}","branches_url":"https://api.github.com/repos/fitzgen/source-map/branches{/branch}","tags_url":"https://api.github.com/repos/fitzgen/source-map/tags","blobs_url":"https://api.github.com/repos/fitzgen/source-map/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fitzgen/source-map/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fitzgen/source-map/git/refs{/sha}","trees_url":"https://api.github.com/repos/fitzgen/source-map/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fitzgen/source-map/statuses/{sha}","languages_url":"https://api.github.com/repos/fitzgen/source-map/languages","stargazers_url":"https://api.github.com/repos/fitzgen/source-map/stargazers","contributors_url":"https://api.github.com/repos/fitzgen/source-map/contributors","subscribers_url":"https://api.github.com/repos/fitzgen/source-map/subscribers","subscription_url":"https://api.github.com/repos/fitzgen/source-map/subscription","commits_url":"https://api.github.com/repos/fitzgen/source-map/commits{/sha}","git_commits_url":"https://api.github.com/repos/fitzgen/source-map/git/commits{/sha}","comments_url":"https://api.github.com/repos/fitzgen/source-map/comments{/number}","issue_comment_url":"https://api.github.com/repos/fitzgen/source-map/issues/comments{/number}","contents_url":"https://api.github.com/repos/fitzgen/source-map/contents/{+path}","compare_url":"https://api.github.com/repos/fitzgen/source-map/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fitzgen/source-map/merges","archive_url":"https://api.github.com/repos/fitzgen/source-map/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fitzgen/source-map/downloads","issues_url":"https://api.github.com/repos/fitzgen/source-map/issues{/number}","pulls_url":"https://api.github.com/repos/fitzgen/source-map/pulls{/number}","milestones_url":"https://api.github.com/repos/fitzgen/source-map/milestones{/number}","notifications_url":"https://api.github.com/repos/fitzgen/source-map/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fitzgen/source-map/labels{/name}","releases_url":"https://api.github.com/repos/fitzgen/source-map/releases{/id}","created_at":"2011-10-31T22:51:30Z","updated_at":"2015-07-25T05:52:05Z","pushed_at":"2015-07-29T21:59:45Z","git_url":"git://github.com/fitzgen/source-map.git","ssh_url":"git@github.com:fitzgen/source-map.git","clone_url":"https://github.com/fitzgen/source-map.git","svn_url":"https://github.com/fitzgen/source-map","homepage":"","size":3135,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":7,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"c3bfecb8359019b70654c35bfac31f42ed41bf93","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":2014930,"name":"source-map","full_name":"mozilla/source-map","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/source-map","description":"Parse and consume source maps.","fork":false,"url":"https://api.github.com/repos/mozilla/source-map","forks_url":"https://api.github.com/repos/mozilla/source-map/forks","keys_url":"https://api.github.com/repos/mozilla/source-map/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/source-map/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/source-map/teams","hooks_url":"https://api.github.com/repos/mozilla/source-map/hooks","issue_events_url":"https://api.github.com/repos/mozilla/source-map/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/source-map/events","assignees_url":"https://api.github.com/repos/mozilla/source-map/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/source-map/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/source-map/tags","blobs_url":"https://api.github.com/repos/mozilla/source-map/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/source-map/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/source-map/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/source-map/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/source-map/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/source-map/languages","stargazers_url":"https://api.github.com/repos/mozilla/source-map/stargazers","contributors_url":"https://api.github.com/repos/mozilla/source-map/contributors","subscribers_url":"https://api.github.com/repos/mozilla/source-map/subscribers","subscription_url":"https://api.github.com/repos/mozilla/source-map/subscription","commits_url":"https://api.github.com/repos/mozilla/source-map/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/source-map/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/source-map/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/source-map/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/source-map/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/source-map/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/source-map/merges","archive_url":"https://api.github.com/repos/mozilla/source-map/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/source-map/downloads","issues_url":"https://api.github.com/repos/mozilla/source-map/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/source-map/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/source-map/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/source-map/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/source-map/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/source-map/releases{/id}","created_at":"2011-07-07T22:07:39Z","updated_at":"2015-07-31T08:28:27Z","pushed_at":"2015-07-30T16:09:43Z","git_url":"git://github.com/mozilla/source-map.git","ssh_url":"git@github.com:mozilla/source-map.git","clone_url":"https://github.com/mozilla/source-map.git","svn_url":"https://github.com/mozilla/source-map","homepage":"https://wiki.mozilla.org/DevTools","size":3670,"stargazers_count":618,"watchers_count":618,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":101,"mirror_url":null,"open_issues_count":20,"forks":101,"open_issues":20,"watchers":618,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/source-map/pulls/199"},"html":{"href":"https://github.com/mozilla/source-map/pull/199"},"issue":{"href":"https://api.github.com/repos/mozilla/source-map/issues/199"},"comments":{"href":"https://api.github.com/repos/mozilla/source-map/issues/199/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/source-map/pulls/199/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/source-map/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/source-map/pulls/199/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/source-map/statuses/bb389320ad2530530ffb5923d2016b033275f966"}}}}