{"action":"opened","number":97,"pull_request":{"url":"https://api.github.com/repos/rails/actioncable/pulls/97","id":47912412,"html_url":"https://github.com/rails/actioncable/pull/97","diff_url":"https://github.com/rails/actioncable/pull/97.diff","patch_url":"https://github.com/rails/actioncable/pull/97.patch","issue_url":"https://api.github.com/repos/rails/actioncable/issues/97","number":97,"state":"open","locked":false,"title":"Speed up tests be calling EM.run_deferred_callbacks instead of setting a timer","user":{"login":"lsylvester","id":191128,"avatar_url":"https://avatars.githubusercontent.com/u/191128?v=3","gravatar_id":"","url":"https://api.github.com/users/lsylvester","html_url":"https://github.com/lsylvester","followers_url":"https://api.github.com/users/lsylvester/followers","following_url":"https://api.github.com/users/lsylvester/following{/other_user}","gists_url":"https://api.github.com/users/lsylvester/gists{/gist_id}","starred_url":"https://api.github.com/users/lsylvester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsylvester/subscriptions","organizations_url":"https://api.github.com/users/lsylvester/orgs","repos_url":"https://api.github.com/users/lsylvester/repos","events_url":"https://api.github.com/users/lsylvester/events{/privacy}","received_events_url":"https://api.github.com/users/lsylvester/received_events","type":"User","site_admin":false},"body":"The `run_in_eventmachine` test helper method is setting a 0.1 second timer to stop the event machine loop. This causes each test that requires an event machine loop to wait for 0.1 second regardless of how long the test takes to process.\r\n\r\nThis changes that to call `EM.run_deferred_callbacks`, which immediatly process pending actions in the event loop and then is able to exit the event loop without doing any waiting.\r\n\r\nBefore this change, running tests produced\r\n\r\n    Finished in 2.957857s, 15.8899 runs/s, 27.7228 assertions/s.\r\n\r\nAfter, the tests get\r\n\r\n    Finished in 0.065942s, 712.7514 runs/s, 1243.5237 assertions/s.","created_at":"2015-10-16T13:47:46Z","updated_at":"2015-10-16T13:47:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rails/actioncable/pulls/97/commits","review_comments_url":"https://api.github.com/repos/rails/actioncable/pulls/97/comments","review_comment_url":"https://api.github.com/repos/rails/actioncable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/actioncable/issues/97/comments","statuses_url":"https://api.github.com/repos/rails/actioncable/statuses/5efd82dbe5307982c1eac3ada7a2478993fd59be","head":{"label":"lsylvester:speed-up-tests","ref":"speed-up-tests","sha":"5efd82dbe5307982c1eac3ada7a2478993fd59be","user":{"login":"lsylvester","id":191128,"avatar_url":"https://avatars.githubusercontent.com/u/191128?v=3","gravatar_id":"","url":"https://api.github.com/users/lsylvester","html_url":"https://github.com/lsylvester","followers_url":"https://api.github.com/users/lsylvester/followers","following_url":"https://api.github.com/users/lsylvester/following{/other_user}","gists_url":"https://api.github.com/users/lsylvester/gists{/gist_id}","starred_url":"https://api.github.com/users/lsylvester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsylvester/subscriptions","organizations_url":"https://api.github.com/users/lsylvester/orgs","repos_url":"https://api.github.com/users/lsylvester/repos","events_url":"https://api.github.com/users/lsylvester/events{/privacy}","received_events_url":"https://api.github.com/users/lsylvester/received_events","type":"User","site_admin":false},"repo":{"id":38786299,"name":"actioncable","full_name":"lsylvester/actioncable","owner":{"login":"lsylvester","id":191128,"avatar_url":"https://avatars.githubusercontent.com/u/191128?v=3","gravatar_id":"","url":"https://api.github.com/users/lsylvester","html_url":"https://github.com/lsylvester","followers_url":"https://api.github.com/users/lsylvester/followers","following_url":"https://api.github.com/users/lsylvester/following{/other_user}","gists_url":"https://api.github.com/users/lsylvester/gists{/gist_id}","starred_url":"https://api.github.com/users/lsylvester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsylvester/subscriptions","organizations_url":"https://api.github.com/users/lsylvester/orgs","repos_url":"https://api.github.com/users/lsylvester/repos","events_url":"https://api.github.com/users/lsylvester/events{/privacy}","received_events_url":"https://api.github.com/users/lsylvester/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lsylvester/actioncable","description":"Framework for real-time communication over websockets","fork":true,"url":"https://api.github.com/repos/lsylvester/actioncable","forks_url":"https://api.github.com/repos/lsylvester/actioncable/forks","keys_url":"https://api.github.com/repos/lsylvester/actioncable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsylvester/actioncable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsylvester/actioncable/teams","hooks_url":"https://api.github.com/repos/lsylvester/actioncable/hooks","issue_events_url":"https://api.github.com/repos/lsylvester/actioncable/issues/events{/number}","events_url":"https://api.github.com/repos/lsylvester/actioncable/events","assignees_url":"https://api.github.com/repos/lsylvester/actioncable/assignees{/user}","branches_url":"https://api.github.com/repos/lsylvester/actioncable/branches{/branch}","tags_url":"https://api.github.com/repos/lsylvester/actioncable/tags","blobs_url":"https://api.github.com/repos/lsylvester/actioncable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsylvester/actioncable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsylvester/actioncable/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsylvester/actioncable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsylvester/actioncable/statuses/{sha}","languages_url":"https://api.github.com/repos/lsylvester/actioncable/languages","stargazers_url":"https://api.github.com/repos/lsylvester/actioncable/stargazers","contributors_url":"https://api.github.com/repos/lsylvester/actioncable/contributors","subscribers_url":"https://api.github.com/repos/lsylvester/actioncable/subscribers","subscription_url":"https://api.github.com/repos/lsylvester/actioncable/subscription","commits_url":"https://api.github.com/repos/lsylvester/actioncable/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsylvester/actioncable/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsylvester/actioncable/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsylvester/actioncable/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsylvester/actioncable/contents/{+path}","compare_url":"https://api.github.com/repos/lsylvester/actioncable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsylvester/actioncable/merges","archive_url":"https://api.github.com/repos/lsylvester/actioncable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsylvester/actioncable/downloads","issues_url":"https://api.github.com/repos/lsylvester/actioncable/issues{/number}","pulls_url":"https://api.github.com/repos/lsylvester/actioncable/pulls{/number}","milestones_url":"https://api.github.com/repos/lsylvester/actioncable/milestones{/number}","notifications_url":"https://api.github.com/repos/lsylvester/actioncable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsylvester/actioncable/labels{/name}","releases_url":"https://api.github.com/repos/lsylvester/actioncable/releases{/id}","created_at":"2015-07-08T23:55:17Z","updated_at":"2015-07-08T23:55:18Z","pushed_at":"2015-10-16T13:46:19Z","git_url":"git://github.com/lsylvester/actioncable.git","ssh_url":"git@github.com:lsylvester/actioncable.git","clone_url":"https://github.com/lsylvester/actioncable.git","svn_url":"https://github.com/lsylvester/actioncable","homepage":null,"size":418,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"e456d734f70de3dfb245c2d2e3ce9c7e22ebdb71","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":29253597,"name":"actioncable","full_name":"rails/actioncable","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/actioncable","description":"Framework for real-time communication over websockets","fork":false,"url":"https://api.github.com/repos/rails/actioncable","forks_url":"https://api.github.com/repos/rails/actioncable/forks","keys_url":"https://api.github.com/repos/rails/actioncable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/actioncable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/actioncable/teams","hooks_url":"https://api.github.com/repos/rails/actioncable/hooks","issue_events_url":"https://api.github.com/repos/rails/actioncable/issues/events{/number}","events_url":"https://api.github.com/repos/rails/actioncable/events","assignees_url":"https://api.github.com/repos/rails/actioncable/assignees{/user}","branches_url":"https://api.github.com/repos/rails/actioncable/branches{/branch}","tags_url":"https://api.github.com/repos/rails/actioncable/tags","blobs_url":"https://api.github.com/repos/rails/actioncable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/actioncable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/actioncable/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/actioncable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/actioncable/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/actioncable/languages","stargazers_url":"https://api.github.com/repos/rails/actioncable/stargazers","contributors_url":"https://api.github.com/repos/rails/actioncable/contributors","subscribers_url":"https://api.github.com/repos/rails/actioncable/subscribers","subscription_url":"https://api.github.com/repos/rails/actioncable/subscription","commits_url":"https://api.github.com/repos/rails/actioncable/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/actioncable/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/actioncable/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/actioncable/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/actioncable/contents/{+path}","compare_url":"https://api.github.com/repos/rails/actioncable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/actioncable/merges","archive_url":"https://api.github.com/repos/rails/actioncable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/actioncable/downloads","issues_url":"https://api.github.com/repos/rails/actioncable/issues{/number}","pulls_url":"https://api.github.com/repos/rails/actioncable/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/actioncable/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/actioncable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/actioncable/labels{/name}","releases_url":"https://api.github.com/repos/rails/actioncable/releases{/id}","created_at":"2015-01-14T16:27:07Z","updated_at":"2015-10-16T08:53:15Z","pushed_at":"2015-10-16T06:32:48Z","git_url":"git://github.com/rails/actioncable.git","ssh_url":"git@github.com:rails/actioncable.git","clone_url":"https://github.com/rails/actioncable.git","svn_url":"https://github.com/rails/actioncable","homepage":null,"size":1187,"stargazers_count":955,"watchers_count":955,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":76,"mirror_url":null,"open_issues_count":30,"forks":76,"open_issues":30,"watchers":955,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/actioncable/pulls/97"},"html":{"href":"https://github.com/rails/actioncable/pull/97"},"issue":{"href":"https://api.github.com/repos/rails/actioncable/issues/97"},"comments":{"href":"https://api.github.com/repos/rails/actioncable/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/actioncable/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/actioncable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/actioncable/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/rails/actioncable/statuses/5efd82dbe5307982c1eac3ada7a2478993fd59be"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":1,"changed_files":1}}