{"action":"created","comment":{"url":"https://api.github.com/repos/mila-udem/blocks/pulls/comments/30859624","id":30859624,"diff_hunk":"@@ -100,6 +99,7 @@ def test_integer_sequence_generator():\n     Such sequence generators can be used to e.g. model language.\n \n     \"\"\"\n+    floatX = theano.config.floatX","path":"tests/bricks/test_sequence_generators.py","position":21,"original_position":21,"commit_id":"75780544f2e2b14f2cca4b06d2797c3fd69cc1b1","original_commit_id":"75780544f2e2b14f2cca4b06d2797c3fd69cc1b1","user":{"login":"vdumoulin","id":2034067,"avatar_url":"https://avatars.githubusercontent.com/u/2034067?v=3","gravatar_id":"","url":"https://api.github.com/users/vdumoulin","html_url":"https://github.com/vdumoulin","followers_url":"https://api.github.com/users/vdumoulin/followers","following_url":"https://api.github.com/users/vdumoulin/following{/other_user}","gists_url":"https://api.github.com/users/vdumoulin/gists{/gist_id}","starred_url":"https://api.github.com/users/vdumoulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdumoulin/subscriptions","organizations_url":"https://api.github.com/users/vdumoulin/orgs","repos_url":"https://api.github.com/users/vdumoulin/repos","events_url":"https://api.github.com/users/vdumoulin/events{/privacy}","received_events_url":"https://api.github.com/users/vdumoulin/received_events","type":"User","site_admin":false},"body":"Same question.","created_at":"2015-05-21T23:50:02Z","updated_at":"2015-05-21T23:50:02Z","html_url":"https://github.com/mila-udem/blocks/pull/657#discussion_r30859624","pull_request_url":"https://api.github.com/repos/mila-udem/blocks/pulls/657","_links":{"self":{"href":"https://api.github.com/repos/mila-udem/blocks/pulls/comments/30859624"},"html":{"href":"https://github.com/mila-udem/blocks/pull/657#discussion_r30859624"},"pull_request":{"href":"https://api.github.com/repos/mila-udem/blocks/pulls/657"}}},"pull_request":{"url":"https://api.github.com/repos/mila-udem/blocks/pulls/657","id":35984461,"html_url":"https://github.com/mila-udem/blocks/pull/657","diff_url":"https://github.com/mila-udem/blocks/pull/657.diff","patch_url":"https://github.com/mila-udem/blocks/pull/657.patch","issue_url":"https://api.github.com/repos/mila-udem/blocks/issues/657","number":657,"state":"open","locked":false,"title":"Remove dangerous local aliasing of floatX.","user":{"login":"dwf","id":60206,"avatar_url":"https://avatars.githubusercontent.com/u/60206?v=3","gravatar_id":"","url":"https://api.github.com/users/dwf","html_url":"https://github.com/dwf","followers_url":"https://api.github.com/users/dwf/followers","following_url":"https://api.github.com/users/dwf/following{/other_user}","gists_url":"https://api.github.com/users/dwf/gists{/gist_id}","starred_url":"https://api.github.com/users/dwf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwf/subscriptions","organizations_url":"https://api.github.com/users/dwf/orgs","repos_url":"https://api.github.com/users/dwf/repos","events_url":"https://api.github.com/users/dwf/events{/privacy}","received_events_url":"https://api.github.com/users/dwf/received_events","type":"User","site_admin":false},"body":"Aliasing floatX at the module level has the side effect of incorrect behavior if floatX is ever changed at runtime as @lamblin once pointed out to me (one more instance removed in #656).\r\n\r\ncc @rizar @dmitriy-serdyuk","created_at":"2015-05-21T22:29:38Z","updated_at":"2015-05-21T23:50:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af3f4c2699672996146955967443e02f8e6f9dde","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mila-udem/blocks/pulls/657/commits","review_comments_url":"https://api.github.com/repos/mila-udem/blocks/pulls/657/comments","review_comment_url":"https://api.github.com/repos/mila-udem/blocks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mila-udem/blocks/issues/657/comments","statuses_url":"https://api.github.com/repos/mila-udem/blocks/statuses/75780544f2e2b14f2cca4b06d2797c3fd69cc1b1","head":{"label":"dwf:floatx_local","ref":"floatx_local","sha":"75780544f2e2b14f2cca4b06d2797c3fd69cc1b1","user":{"login":"dwf","id":60206,"avatar_url":"https://avatars.githubusercontent.com/u/60206?v=3","gravatar_id":"","url":"https://api.github.com/users/dwf","html_url":"https://github.com/dwf","followers_url":"https://api.github.com/users/dwf/followers","following_url":"https://api.github.com/users/dwf/following{/other_user}","gists_url":"https://api.github.com/users/dwf/gists{/gist_id}","starred_url":"https://api.github.com/users/dwf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwf/subscriptions","organizations_url":"https://api.github.com/users/dwf/orgs","repos_url":"https://api.github.com/users/dwf/repos","events_url":"https://api.github.com/users/dwf/events{/privacy}","received_events_url":"https://api.github.com/users/dwf/received_events","type":"User","site_admin":false},"repo":{"id":28125354,"name":"blocks","full_name":"dwf/blocks","owner":{"login":"dwf","id":60206,"avatar_url":"https://avatars.githubusercontent.com/u/60206?v=3","gravatar_id":"","url":"https://api.github.com/users/dwf","html_url":"https://github.com/dwf","followers_url":"https://api.github.com/users/dwf/followers","following_url":"https://api.github.com/users/dwf/following{/other_user}","gists_url":"https://api.github.com/users/dwf/gists{/gist_id}","starred_url":"https://api.github.com/users/dwf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwf/subscriptions","organizations_url":"https://api.github.com/users/dwf/orgs","repos_url":"https://api.github.com/users/dwf/repos","events_url":"https://api.github.com/users/dwf/events{/privacy}","received_events_url":"https://api.github.com/users/dwf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dwf/blocks","description":"","fork":true,"url":"https://api.github.com/repos/dwf/blocks","forks_url":"https://api.github.com/repos/dwf/blocks/forks","keys_url":"https://api.github.com/repos/dwf/blocks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dwf/blocks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dwf/blocks/teams","hooks_url":"https://api.github.com/repos/dwf/blocks/hooks","issue_events_url":"https://api.github.com/repos/dwf/blocks/issues/events{/number}","events_url":"https://api.github.com/repos/dwf/blocks/events","assignees_url":"https://api.github.com/repos/dwf/blocks/assignees{/user}","branches_url":"https://api.github.com/repos/dwf/blocks/branches{/branch}","tags_url":"https://api.github.com/repos/dwf/blocks/tags","blobs_url":"https://api.github.com/repos/dwf/blocks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dwf/blocks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dwf/blocks/git/refs{/sha}","trees_url":"https://api.github.com/repos/dwf/blocks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dwf/blocks/statuses/{sha}","languages_url":"https://api.github.com/repos/dwf/blocks/languages","stargazers_url":"https://api.github.com/repos/dwf/blocks/stargazers","contributors_url":"https://api.github.com/repos/dwf/blocks/contributors","subscribers_url":"https://api.github.com/repos/dwf/blocks/subscribers","subscription_url":"https://api.github.com/repos/dwf/blocks/subscription","commits_url":"https://api.github.com/repos/dwf/blocks/commits{/sha}","git_commits_url":"https://api.github.com/repos/dwf/blocks/git/commits{/sha}","comments_url":"https://api.github.com/repos/dwf/blocks/comments{/number}","issue_comment_url":"https://api.github.com/repos/dwf/blocks/issues/comments{/number}","contents_url":"https://api.github.com/repos/dwf/blocks/contents/{+path}","compare_url":"https://api.github.com/repos/dwf/blocks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dwf/blocks/merges","archive_url":"https://api.github.com/repos/dwf/blocks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dwf/blocks/downloads","issues_url":"https://api.github.com/repos/dwf/blocks/issues{/number}","pulls_url":"https://api.github.com/repos/dwf/blocks/pulls{/number}","milestones_url":"https://api.github.com/repos/dwf/blocks/milestones{/number}","notifications_url":"https://api.github.com/repos/dwf/blocks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dwf/blocks/labels{/name}","releases_url":"https://api.github.com/repos/dwf/blocks/releases{/id}","created_at":"2014-12-17T06:56:35Z","updated_at":"2015-03-13T19:51:16Z","pushed_at":"2015-05-21T23:47:27Z","git_url":"git://github.com/dwf/blocks.git","ssh_url":"git@github.com:dwf/blocks.git","clone_url":"https://github.com/dwf/blocks.git","svn_url":"https://github.com/dwf/blocks","homepage":null,"size":3513,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mila-udem:master","ref":"master","sha":"9163b934dbc79ecdab823fca9f71f82ccfd33523","user":{"login":"mila-udem","id":11724251,"avatar_url":"https://avatars.githubusercontent.com/u/11724251?v=3","gravatar_id":"","url":"https://api.github.com/users/mila-udem","html_url":"https://github.com/mila-udem","followers_url":"https://api.github.com/users/mila-udem/followers","following_url":"https://api.github.com/users/mila-udem/following{/other_user}","gists_url":"https://api.github.com/users/mila-udem/gists{/gist_id}","starred_url":"https://api.github.com/users/mila-udem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mila-udem/subscriptions","organizations_url":"https://api.github.com/users/mila-udem/orgs","repos_url":"https://api.github.com/users/mila-udem/repos","events_url":"https://api.github.com/users/mila-udem/events{/privacy}","received_events_url":"https://api.github.com/users/mila-udem/received_events","type":"Organization","site_admin":false},"repo":{"id":24829371,"name":"blocks","full_name":"mila-udem/blocks","owner":{"login":"mila-udem","id":11724251,"avatar_url":"https://avatars.githubusercontent.com/u/11724251?v=3","gravatar_id":"","url":"https://api.github.com/users/mila-udem","html_url":"https://github.com/mila-udem","followers_url":"https://api.github.com/users/mila-udem/followers","following_url":"https://api.github.com/users/mila-udem/following{/other_user}","gists_url":"https://api.github.com/users/mila-udem/gists{/gist_id}","starred_url":"https://api.github.com/users/mila-udem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mila-udem/subscriptions","organizations_url":"https://api.github.com/users/mila-udem/orgs","repos_url":"https://api.github.com/users/mila-udem/repos","events_url":"https://api.github.com/users/mila-udem/events{/privacy}","received_events_url":"https://api.github.com/users/mila-udem/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mila-udem/blocks","description":"A Theano framework for building and training neural networks","fork":false,"url":"https://api.github.com/repos/mila-udem/blocks","forks_url":"https://api.github.com/repos/mila-udem/blocks/forks","keys_url":"https://api.github.com/repos/mila-udem/blocks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mila-udem/blocks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mila-udem/blocks/teams","hooks_url":"https://api.github.com/repos/mila-udem/blocks/hooks","issue_events_url":"https://api.github.com/repos/mila-udem/blocks/issues/events{/number}","events_url":"https://api.github.com/repos/mila-udem/blocks/events","assignees_url":"https://api.github.com/repos/mila-udem/blocks/assignees{/user}","branches_url":"https://api.github.com/repos/mila-udem/blocks/branches{/branch}","tags_url":"https://api.github.com/repos/mila-udem/blocks/tags","blobs_url":"https://api.github.com/repos/mila-udem/blocks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mila-udem/blocks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mila-udem/blocks/git/refs{/sha}","trees_url":"https://api.github.com/repos/mila-udem/blocks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mila-udem/blocks/statuses/{sha}","languages_url":"https://api.github.com/repos/mila-udem/blocks/languages","stargazers_url":"https://api.github.com/repos/mila-udem/blocks/stargazers","contributors_url":"https://api.github.com/repos/mila-udem/blocks/contributors","subscribers_url":"https://api.github.com/repos/mila-udem/blocks/subscribers","subscription_url":"https://api.github.com/repos/mila-udem/blocks/subscription","commits_url":"https://api.github.com/repos/mila-udem/blocks/commits{/sha}","git_commits_url":"https://api.github.com/repos/mila-udem/blocks/git/commits{/sha}","comments_url":"https://api.github.com/repos/mila-udem/blocks/comments{/number}","issue_comment_url":"https://api.github.com/repos/mila-udem/blocks/issues/comments{/number}","contents_url":"https://api.github.com/repos/mila-udem/blocks/contents/{+path}","compare_url":"https://api.github.com/repos/mila-udem/blocks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mila-udem/blocks/merges","archive_url":"https://api.github.com/repos/mila-udem/blocks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mila-udem/blocks/downloads","issues_url":"https://api.github.com/repos/mila-udem/blocks/issues{/number}","pulls_url":"https://api.github.com/repos/mila-udem/blocks/pulls{/number}","milestones_url":"https://api.github.com/repos/mila-udem/blocks/milestones{/number}","notifications_url":"https://api.github.com/repos/mila-udem/blocks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mila-udem/blocks/labels{/name}","releases_url":"https://api.github.com/repos/mila-udem/blocks/releases{/id}","created_at":"2014-10-06T00:08:32Z","updated_at":"2015-05-21T03:27:45Z","pushed_at":"2015-05-21T23:47:27Z","git_url":"git://github.com/mila-udem/blocks.git","ssh_url":"git@github.com:mila-udem/blocks.git","clone_url":"https://github.com/mila-udem/blocks.git","svn_url":"https://github.com/mila-udem/blocks","homepage":"","size":16008,"stargazers_count":230,"watchers_count":230,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":68,"mirror_url":null,"open_issues_count":108,"forks":68,"open_issues":108,"watchers":230,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mila-udem/blocks/pulls/657"},"html":{"href":"https://github.com/mila-udem/blocks/pull/657"},"issue":{"href":"https://api.github.com/repos/mila-udem/blocks/issues/657"},"comments":{"href":"https://api.github.com/repos/mila-udem/blocks/issues/657/comments"},"review_comments":{"href":"https://api.github.com/repos/mila-udem/blocks/pulls/657/comments"},"review_comment":{"href":"https://api.github.com/repos/mila-udem/blocks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mila-udem/blocks/pulls/657/commits"},"statuses":{"href":"https://api.github.com/repos/mila-udem/blocks/statuses/75780544f2e2b14f2cca4b06d2797c3fd69cc1b1"}}}}