{"action":"closed","number":4004,"pull_request":{"url":"https://api.github.com/repos/bcit-ci/CodeIgniter/pulls/4004","id":40941711,"html_url":"https://github.com/bcit-ci/CodeIgniter/pull/4004","diff_url":"https://github.com/bcit-ci/CodeIgniter/pull/4004.diff","patch_url":"https://github.com/bcit-ci/CodeIgniter/pull/4004.patch","issue_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/issues/4004","number":4004,"state":"closed","locked":false,"title":"parse_url of a valid url was returning FALSE when a colon existed in the path or query","user":{"login":"miex0r","id":716136,"avatar_url":"https://avatars.githubusercontent.com/u/716136?v=3","gravatar_id":"","url":"https://api.github.com/users/miex0r","html_url":"https://github.com/miex0r","followers_url":"https://api.github.com/users/miex0r/followers","following_url":"https://api.github.com/users/miex0r/following{/other_user}","gists_url":"https://api.github.com/users/miex0r/gists{/gist_id}","starred_url":"https://api.github.com/users/miex0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miex0r/subscriptions","organizations_url":"https://api.github.com/users/miex0r/orgs","repos_url":"https://api.github.com/users/miex0r/repos","events_url":"https://api.github.com/users/miex0r/events{/privacy}","received_events_url":"https://api.github.com/users/miex0r/received_events","type":"User","site_admin":false},"body":"MJZ: i changed this line on 7-27-15 to properly parse a url. It was erroring out if the path or query had a colon in the string. The function was assuming it's a port number following and bombed out... so i added the protocol and port to the front of the string\r\n\r\nthis string returns FALSE because the parse gets confused \"/932?numeric_filters_name[]=Number+of+Members+Holding&numeric_filters_value[]=35:69\"","created_at":"2015-07-27T19:49:45Z","updated_at":"2015-07-27T21:07:42Z","closed_at":"2015-07-27T21:07:42Z","merged_at":null,"merge_commit_sha":"e1192c412853e352eb1e542b8b301b34c4d66d62","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/pulls/4004/commits","review_comments_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/pulls/4004/comments","review_comment_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/issues/4004/comments","statuses_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/statuses/cad06ed92137ad71e3f78cbba600606353cc677a","head":{"label":"miex0r:develop","ref":"develop","sha":"cad06ed92137ad71e3f78cbba600606353cc677a","user":{"login":"miex0r","id":716136,"avatar_url":"https://avatars.githubusercontent.com/u/716136?v=3","gravatar_id":"","url":"https://api.github.com/users/miex0r","html_url":"https://github.com/miex0r","followers_url":"https://api.github.com/users/miex0r/followers","following_url":"https://api.github.com/users/miex0r/following{/other_user}","gists_url":"https://api.github.com/users/miex0r/gists{/gist_id}","starred_url":"https://api.github.com/users/miex0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miex0r/subscriptions","organizations_url":"https://api.github.com/users/miex0r/orgs","repos_url":"https://api.github.com/users/miex0r/repos","events_url":"https://api.github.com/users/miex0r/events{/privacy}","received_events_url":"https://api.github.com/users/miex0r/received_events","type":"User","site_admin":false},"repo":{"id":39794418,"name":"CodeIgniter","full_name":"miex0r/CodeIgniter","owner":{"login":"miex0r","id":716136,"avatar_url":"https://avatars.githubusercontent.com/u/716136?v=3","gravatar_id":"","url":"https://api.github.com/users/miex0r","html_url":"https://github.com/miex0r","followers_url":"https://api.github.com/users/miex0r/followers","following_url":"https://api.github.com/users/miex0r/following{/other_user}","gists_url":"https://api.github.com/users/miex0r/gists{/gist_id}","starred_url":"https://api.github.com/users/miex0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miex0r/subscriptions","organizations_url":"https://api.github.com/users/miex0r/orgs","repos_url":"https://api.github.com/users/miex0r/repos","events_url":"https://api.github.com/users/miex0r/events{/privacy}","received_events_url":"https://api.github.com/users/miex0r/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/miex0r/CodeIgniter","description":"Open Source PHP Framework (originally from EllisLab)","fork":true,"url":"https://api.github.com/repos/miex0r/CodeIgniter","forks_url":"https://api.github.com/repos/miex0r/CodeIgniter/forks","keys_url":"https://api.github.com/repos/miex0r/CodeIgniter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/miex0r/CodeIgniter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/miex0r/CodeIgniter/teams","hooks_url":"https://api.github.com/repos/miex0r/CodeIgniter/hooks","issue_events_url":"https://api.github.com/repos/miex0r/CodeIgniter/issues/events{/number}","events_url":"https://api.github.com/repos/miex0r/CodeIgniter/events","assignees_url":"https://api.github.com/repos/miex0r/CodeIgniter/assignees{/user}","branches_url":"https://api.github.com/repos/miex0r/CodeIgniter/branches{/branch}","tags_url":"https://api.github.com/repos/miex0r/CodeIgniter/tags","blobs_url":"https://api.github.com/repos/miex0r/CodeIgniter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/miex0r/CodeIgniter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/miex0r/CodeIgniter/git/refs{/sha}","trees_url":"https://api.github.com/repos/miex0r/CodeIgniter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/miex0r/CodeIgniter/statuses/{sha}","languages_url":"https://api.github.com/repos/miex0r/CodeIgniter/languages","stargazers_url":"https://api.github.com/repos/miex0r/CodeIgniter/stargazers","contributors_url":"https://api.github.com/repos/miex0r/CodeIgniter/contributors","subscribers_url":"https://api.github.com/repos/miex0r/CodeIgniter/subscribers","subscription_url":"https://api.github.com/repos/miex0r/CodeIgniter/subscription","commits_url":"https://api.github.com/repos/miex0r/CodeIgniter/commits{/sha}","git_commits_url":"https://api.github.com/repos/miex0r/CodeIgniter/git/commits{/sha}","comments_url":"https://api.github.com/repos/miex0r/CodeIgniter/comments{/number}","issue_comment_url":"https://api.github.com/repos/miex0r/CodeIgniter/issues/comments{/number}","contents_url":"https://api.github.com/repos/miex0r/CodeIgniter/contents/{+path}","compare_url":"https://api.github.com/repos/miex0r/CodeIgniter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/miex0r/CodeIgniter/merges","archive_url":"https://api.github.com/repos/miex0r/CodeIgniter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/miex0r/CodeIgniter/downloads","issues_url":"https://api.github.com/repos/miex0r/CodeIgniter/issues{/number}","pulls_url":"https://api.github.com/repos/miex0r/CodeIgniter/pulls{/number}","milestones_url":"https://api.github.com/repos/miex0r/CodeIgniter/milestones{/number}","notifications_url":"https://api.github.com/repos/miex0r/CodeIgniter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/miex0r/CodeIgniter/labels{/name}","releases_url":"https://api.github.com/repos/miex0r/CodeIgniter/releases{/id}","created_at":"2015-07-27T19:46:58Z","updated_at":"2015-07-27T19:47:02Z","pushed_at":"2015-07-27T19:48:11Z","git_url":"git://github.com/miex0r/CodeIgniter.git","ssh_url":"git@github.com:miex0r/CodeIgniter.git","clone_url":"https://github.com/miex0r/CodeIgniter.git","svn_url":"https://github.com/miex0r/CodeIgniter","homepage":"http://codeigniter.com/","size":75868,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"bcit-ci:develop","ref":"develop","sha":"d4a50bd09ee38a25010ac58b17b8db37fc1ec0cb","user":{"login":"bcit-ci","id":8863432,"avatar_url":"https://avatars.githubusercontent.com/u/8863432?v=3","gravatar_id":"","url":"https://api.github.com/users/bcit-ci","html_url":"https://github.com/bcit-ci","followers_url":"https://api.github.com/users/bcit-ci/followers","following_url":"https://api.github.com/users/bcit-ci/following{/other_user}","gists_url":"https://api.github.com/users/bcit-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/bcit-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcit-ci/subscriptions","organizations_url":"https://api.github.com/users/bcit-ci/orgs","repos_url":"https://api.github.com/users/bcit-ci/repos","events_url":"https://api.github.com/users/bcit-ci/events{/privacy}","received_events_url":"https://api.github.com/users/bcit-ci/received_events","type":"Organization","site_admin":false},"repo":{"id":2234102,"name":"CodeIgniter","full_name":"bcit-ci/CodeIgniter","owner":{"login":"bcit-ci","id":8863432,"avatar_url":"https://avatars.githubusercontent.com/u/8863432?v=3","gravatar_id":"","url":"https://api.github.com/users/bcit-ci","html_url":"https://github.com/bcit-ci","followers_url":"https://api.github.com/users/bcit-ci/followers","following_url":"https://api.github.com/users/bcit-ci/following{/other_user}","gists_url":"https://api.github.com/users/bcit-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/bcit-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcit-ci/subscriptions","organizations_url":"https://api.github.com/users/bcit-ci/orgs","repos_url":"https://api.github.com/users/bcit-ci/repos","events_url":"https://api.github.com/users/bcit-ci/events{/privacy}","received_events_url":"https://api.github.com/users/bcit-ci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bcit-ci/CodeIgniter","description":"Open Source PHP Framework (originally from EllisLab)","fork":false,"url":"https://api.github.com/repos/bcit-ci/CodeIgniter","forks_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/forks","keys_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/teams","hooks_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/hooks","issue_events_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/issues/events{/number}","events_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/events","assignees_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/assignees{/user}","branches_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/branches{/branch}","tags_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/tags","blobs_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/git/refs{/sha}","trees_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/statuses/{sha}","languages_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/languages","stargazers_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/stargazers","contributors_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/contributors","subscribers_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/subscribers","subscription_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/subscription","commits_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/commits{/sha}","git_commits_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/git/commits{/sha}","comments_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/comments{/number}","issue_comment_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/issues/comments{/number}","contents_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/contents/{+path}","compare_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/merges","archive_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/downloads","issues_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/issues{/number}","pulls_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/pulls{/number}","milestones_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/milestones{/number}","notifications_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/labels{/name}","releases_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/releases{/id}","created_at":"2011-08-19T13:34:00Z","updated_at":"2015-07-27T20:44:46Z","pushed_at":"2015-07-27T21:07:28Z","git_url":"git://github.com/bcit-ci/CodeIgniter.git","ssh_url":"git@github.com:bcit-ci/CodeIgniter.git","clone_url":"https://github.com/bcit-ci/CodeIgniter.git","svn_url":"https://github.com/bcit-ci/CodeIgniter","homepage":"http://codeigniter.com/","size":75868,"stargazers_count":10321,"watchers_count":10321,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5343,"mirror_url":null,"open_issues_count":48,"forks":5343,"open_issues":48,"watchers":10321,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/bcit-ci/CodeIgniter/pulls/4004"},"html":{"href":"https://github.com/bcit-ci/CodeIgniter/pull/4004"},"issue":{"href":"https://api.github.com/repos/bcit-ci/CodeIgniter/issues/4004"},"comments":{"href":"https://api.github.com/repos/bcit-ci/CodeIgniter/issues/4004/comments"},"review_comments":{"href":"https://api.github.com/repos/bcit-ci/CodeIgniter/pulls/4004/comments"},"review_comment":{"href":"https://api.github.com/repos/bcit-ci/CodeIgniter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bcit-ci/CodeIgniter/pulls/4004/commits"},"statuses":{"href":"https://api.github.com/repos/bcit-ci/CodeIgniter/statuses/cad06ed92137ad71e3f78cbba600606353cc677a"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}