{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/gradle-docker/pulls/comments/47000143","id":47000143,"diff_hunk":"@@ -33,34 +40,22 @@ Configuration specifying all parameters:\n         dockerfile 'Dockerfile'\n         dependsOn tasks.distTar\n         files 'file1.txt', 'file2.txt'\n-        dockerComposeTemplate 'my-template.yml'\n-        dockerComposeFile 'my-docker-compose.yml'\n     }\n \n To build a docker container, run the `docker` task. To push that container to a\n docker repository, run the `dockerPush` task.\n \n-\n-Generating docker-compose dependencies\n---------------------------------------\n-\n-The plugin provides mechanisms for managing dependencies between docker images\n-used in orchestrating `docker-compose` environments. Each project can declare\n-its dependencies on other docker images and publish an artifact advertising those\n-dependencies. The plugin uses standard Maven/Ivy machanism for declaring and\n-resolving dependencies.\n-\n-The `generateDockerCompose` task generates a `docker-compose.yml` file from\n-a user-defined template by replacing each version variable by the concrete version\n-declared by the transitive dependencies of the docker configuration.\n-\n ### Specifying dependencies on Docker images","path":"readme.md","position":50,"original_position":50,"commit_id":"165803b08bbe68c15ca045360c9d7f7000711de6","original_commit_id":"165803b08bbe68c15ca045360c9d7f7000711de6","user":{"login":"uschi2000","id":6528449,"avatar_url":"https://avatars.githubusercontent.com/u/6528449?v=3","gravatar_id":"","url":"https://api.github.com/users/uschi2000","html_url":"https://github.com/uschi2000","followers_url":"https://api.github.com/users/uschi2000/followers","following_url":"https://api.github.com/users/uschi2000/following{/other_user}","gists_url":"https://api.github.com/users/uschi2000/gists{/gist_id}","starred_url":"https://api.github.com/users/uschi2000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uschi2000/subscriptions","organizations_url":"https://api.github.com/users/uschi2000/orgs","repos_url":"https://api.github.com/users/uschi2000/repos","events_url":"https://api.github.com/users/uschi2000/events{/privacy}","received_events_url":"https://api.github.com/users/uschi2000/received_events","type":"User","site_admin":false},"body":"you need the 'docker' configuration in both cases: the 'docker' plugin uses it to publish declared dependencies, the 'docker-compose' plugin uses it to resolve declared dependencies. so yes, I think both plugins should add it.","created_at":"2015-12-08T19:22:51Z","updated_at":"2015-12-08T19:22:51Z","html_url":"https://github.com/palantir/gradle-docker/pull/15#discussion_r47000143","pull_request_url":"https://api.github.com/repos/palantir/gradle-docker/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/palantir/gradle-docker/pulls/comments/47000143"},"html":{"href":"https://github.com/palantir/gradle-docker/pull/15#discussion_r47000143"},"pull_request":{"href":"https://api.github.com/repos/palantir/gradle-docker/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/gradle-docker/pulls/15","id":52748770,"html_url":"https://github.com/palantir/gradle-docker/pull/15","diff_url":"https://github.com/palantir/gradle-docker/pull/15.diff","patch_url":"https://github.com/palantir/gradle-docker/pull/15.patch","issue_url":"https://api.github.com/repos/palantir/gradle-docker/issues/15","number":15,"state":"open","locked":false,"title":"Separate PalantirDockerPlugin and DockerComposeTemplatePlugin into tw…","user":{"login":"uschi2000","id":6528449,"avatar_url":"https://avatars.githubusercontent.com/u/6528449?v=3","gravatar_id":"","url":"https://api.github.com/users/uschi2000","html_url":"https://github.com/uschi2000","followers_url":"https://api.github.com/users/uschi2000/followers","following_url":"https://api.github.com/users/uschi2000/following{/other_user}","gists_url":"https://api.github.com/users/uschi2000/gists{/gist_id}","starred_url":"https://api.github.com/users/uschi2000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uschi2000/subscriptions","organizations_url":"https://api.github.com/users/uschi2000/orgs","repos_url":"https://api.github.com/users/uschi2000/repos","events_url":"https://api.github.com/users/uschi2000/events{/privacy}","received_events_url":"https://api.github.com/users/uschi2000/received_events","type":"User","site_admin":false},"body":"…o plugins","created_at":"2015-12-05T06:44:16Z","updated_at":"2015-12-08T19:22:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e223b88d6285943349a96e29cc872a3ea35d462","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/palantir/gradle-docker/pulls/15/commits","review_comments_url":"https://api.github.com/repos/palantir/gradle-docker/pulls/15/comments","review_comment_url":"https://api.github.com/repos/palantir/gradle-docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/gradle-docker/issues/15/comments","statuses_url":"https://api.github.com/repos/palantir/gradle-docker/statuses/165803b08bbe68c15ca045360c9d7f7000711de6","head":{"label":"palantir:feature/separate-plugins","ref":"feature/separate-plugins","sha":"165803b08bbe68c15ca045360c9d7f7000711de6","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":42682769,"name":"gradle-docker","full_name":"palantir/gradle-docker","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/gradle-docker","description":"a Gradle plugin for orchestrating docker builds and pushes.","fork":false,"url":"https://api.github.com/repos/palantir/gradle-docker","forks_url":"https://api.github.com/repos/palantir/gradle-docker/forks","keys_url":"https://api.github.com/repos/palantir/gradle-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/gradle-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/gradle-docker/teams","hooks_url":"https://api.github.com/repos/palantir/gradle-docker/hooks","issue_events_url":"https://api.github.com/repos/palantir/gradle-docker/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/gradle-docker/events","assignees_url":"https://api.github.com/repos/palantir/gradle-docker/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/gradle-docker/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/gradle-docker/tags","blobs_url":"https://api.github.com/repos/palantir/gradle-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/gradle-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/gradle-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/gradle-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/gradle-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/gradle-docker/languages","stargazers_url":"https://api.github.com/repos/palantir/gradle-docker/stargazers","contributors_url":"https://api.github.com/repos/palantir/gradle-docker/contributors","subscribers_url":"https://api.github.com/repos/palantir/gradle-docker/subscribers","subscription_url":"https://api.github.com/repos/palantir/gradle-docker/subscription","commits_url":"https://api.github.com/repos/palantir/gradle-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/gradle-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/gradle-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/gradle-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/gradle-docker/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/gradle-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/gradle-docker/merges","archive_url":"https://api.github.com/repos/palantir/gradle-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/gradle-docker/downloads","issues_url":"https://api.github.com/repos/palantir/gradle-docker/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/gradle-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/gradle-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/gradle-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/gradle-docker/labels{/name}","releases_url":"https://api.github.com/repos/palantir/gradle-docker/releases{/id}","created_at":"2015-09-17T21:24:35Z","updated_at":"2015-10-24T15:20:36Z","pushed_at":"2015-12-08T17:41:32Z","git_url":"git://github.com/palantir/gradle-docker.git","ssh_url":"git@github.com:palantir/gradle-docker.git","clone_url":"https://github.com/palantir/gradle-docker.git","svn_url":"https://github.com/palantir/gradle-docker","homepage":null,"size":88,"stargazers_count":4,"watchers_count":4,"language":"Groovy","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":4,"default_branch":"develop"}},"base":{"label":"palantir:develop","ref":"develop","sha":"3ad09901a102055cb928cc6dabbf6f623030e921","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":42682769,"name":"gradle-docker","full_name":"palantir/gradle-docker","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/gradle-docker","description":"a Gradle plugin for orchestrating docker builds and pushes.","fork":false,"url":"https://api.github.com/repos/palantir/gradle-docker","forks_url":"https://api.github.com/repos/palantir/gradle-docker/forks","keys_url":"https://api.github.com/repos/palantir/gradle-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/gradle-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/gradle-docker/teams","hooks_url":"https://api.github.com/repos/palantir/gradle-docker/hooks","issue_events_url":"https://api.github.com/repos/palantir/gradle-docker/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/gradle-docker/events","assignees_url":"https://api.github.com/repos/palantir/gradle-docker/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/gradle-docker/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/gradle-docker/tags","blobs_url":"https://api.github.com/repos/palantir/gradle-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/gradle-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/gradle-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/gradle-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/gradle-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/gradle-docker/languages","stargazers_url":"https://api.github.com/repos/palantir/gradle-docker/stargazers","contributors_url":"https://api.github.com/repos/palantir/gradle-docker/contributors","subscribers_url":"https://api.github.com/repos/palantir/gradle-docker/subscribers","subscription_url":"https://api.github.com/repos/palantir/gradle-docker/subscription","commits_url":"https://api.github.com/repos/palantir/gradle-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/gradle-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/gradle-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/gradle-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/gradle-docker/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/gradle-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/gradle-docker/merges","archive_url":"https://api.github.com/repos/palantir/gradle-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/gradle-docker/downloads","issues_url":"https://api.github.com/repos/palantir/gradle-docker/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/gradle-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/gradle-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/gradle-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/gradle-docker/labels{/name}","releases_url":"https://api.github.com/repos/palantir/gradle-docker/releases{/id}","created_at":"2015-09-17T21:24:35Z","updated_at":"2015-10-24T15:20:36Z","pushed_at":"2015-12-08T17:41:32Z","git_url":"git://github.com/palantir/gradle-docker.git","ssh_url":"git@github.com:palantir/gradle-docker.git","clone_url":"https://github.com/palantir/gradle-docker.git","svn_url":"https://github.com/palantir/gradle-docker","homepage":null,"size":88,"stargazers_count":4,"watchers_count":4,"language":"Groovy","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":4,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/gradle-docker/pulls/15"},"html":{"href":"https://github.com/palantir/gradle-docker/pull/15"},"issue":{"href":"https://api.github.com/repos/palantir/gradle-docker/issues/15"},"comments":{"href":"https://api.github.com/repos/palantir/gradle-docker/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/gradle-docker/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/gradle-docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/gradle-docker/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/gradle-docker/statuses/165803b08bbe68c15ca045360c9d7f7000711de6"}}}}