{"action":"created","comment":{"url":"https://api.github.com/repos/ndlib/honeycomb/pulls/comments/31043017","id":31043017,"diff_hunk":"@@ -8,11 +8,23 @@ class Showcase < ActiveRecord::Base\n   has_attached_file :image, restricted_characters: /[&$+,\\/:;=?@<>\\[\\]{}\\|\\\\^~%#]/\n   validates_attachment_content_type :image, content_type: /\\Aimage\\/.*\\Z/\n \n-  validates :title, :exhibit, presence: true\n+  validates :name_line_1, :exhibit, presence: true\n   validates :image, attachment_presence: true\n \n   has_paper_trail\n \n+  def slug\n+    return name_line_1","path":"app/models/showcase.rb","position":11,"original_position":11,"commit_id":"880abc8679275e0b7265e0011beb3db9960a1550","original_commit_id":"880abc8679275e0b7265e0011beb3db9960a1550","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Redundant `return` detected.","created_at":"2015-05-26T15:03:34Z","updated_at":"2015-05-26T15:03:34Z","html_url":"https://github.com/ndlib/honeycomb/pull/130#discussion_r31043017","pull_request_url":"https://api.github.com/repos/ndlib/honeycomb/pulls/130","_links":{"self":{"href":"https://api.github.com/repos/ndlib/honeycomb/pulls/comments/31043017"},"html":{"href":"https://github.com/ndlib/honeycomb/pull/130#discussion_r31043017"},"pull_request":{"href":"https://api.github.com/repos/ndlib/honeycomb/pulls/130"}}},"pull_request":{"url":"https://api.github.com/repos/ndlib/honeycomb/pulls/130","id":36211713,"html_url":"https://github.com/ndlib/honeycomb/pull/130","diff_url":"https://github.com/ndlib/honeycomb/pull/130.diff","patch_url":"https://github.com/ndlib/honeycomb/pull/130.patch","issue_url":"https://api.github.com/repos/ndlib/honeycomb/issues/130","number":130,"state":"open","locked":false,"title":"DEC-328: Further change of title->name","user":{"login":"jgondron","id":11502744,"avatar_url":"https://avatars.githubusercontent.com/u/11502744?v=3","gravatar_id":"","url":"https://api.github.com/users/jgondron","html_url":"https://github.com/jgondron","followers_url":"https://api.github.com/users/jgondron/followers","following_url":"https://api.github.com/users/jgondron/following{/other_user}","gists_url":"https://api.github.com/users/jgondron/gists{/gist_id}","starred_url":"https://api.github.com/users/jgondron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgondron/subscriptions","organizations_url":"https://api.github.com/users/jgondron/orgs","repos_url":"https://api.github.com/users/jgondron/repos","events_url":"https://api.github.com/users/jgondron/events{/privacy}","received_events_url":"https://api.github.com/users/jgondron/received_events","type":"User","site_admin":false},"body":"WHY\r\nThe name/title discrepancy between the schema and the front end is becoming more apparent as we move more things into the api. For example, V1::ItemsController.update now renders the json with errors when there are errors. The problem is that the item partial calls this field \"name\", but the errors will return \"title\" when you send a put with an invalid title. These need to match so that any client applications can properly handle the error without having to do this mapping of title->name\r\nHOW\r\nThere are various band-aidy ways we could have done this but we decided it would be best to change it all the way down to the schema for a number of reasons. So the basic process was to change the schema for each entity, then fix what broke. Additionally, I had to change a few services that relied on every object having a title field, namely the creation of urls. Prior to this change CreateBeehiveURL relied on all objects having a 'title' field for creating the slug. In some instances this field was changed to 'name' but in others it was actually changed to 'name_line_1', so it's no longer a consistent field name across all objects. I moved the decision of what to use as the slug down to the model for now and created a ticket https://jira.library.nd.edu/browse/DEC-357 to examine this as a whole.","created_at":"2015-05-26T15:03:17Z","updated_at":"2015-05-26T15:03:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06b901ed4eb261d1a94d91761ff8bea6c1c652d1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ndlib/honeycomb/pulls/130/commits","review_comments_url":"https://api.github.com/repos/ndlib/honeycomb/pulls/130/comments","review_comment_url":"https://api.github.com/repos/ndlib/honeycomb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ndlib/honeycomb/issues/130/comments","statuses_url":"https://api.github.com/repos/ndlib/honeycomb/statuses/880abc8679275e0b7265e0011beb3db9960a1550","head":{"label":"ndlib:DEC-328","ref":"DEC-328","sha":"880abc8679275e0b7265e0011beb3db9960a1550","user":{"login":"ndlib","id":160943,"avatar_url":"https://avatars.githubusercontent.com/u/160943?v=3","gravatar_id":"","url":"https://api.github.com/users/ndlib","html_url":"https://github.com/ndlib","followers_url":"https://api.github.com/users/ndlib/followers","following_url":"https://api.github.com/users/ndlib/following{/other_user}","gists_url":"https://api.github.com/users/ndlib/gists{/gist_id}","starred_url":"https://api.github.com/users/ndlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndlib/subscriptions","organizations_url":"https://api.github.com/users/ndlib/orgs","repos_url":"https://api.github.com/users/ndlib/repos","events_url":"https://api.github.com/users/ndlib/events{/privacy}","received_events_url":"https://api.github.com/users/ndlib/received_events","type":"Organization","site_admin":false},"repo":{"id":25221636,"name":"honeycomb","full_name":"ndlib/honeycomb","owner":{"login":"ndlib","id":160943,"avatar_url":"https://avatars.githubusercontent.com/u/160943?v=3","gravatar_id":"","url":"https://api.github.com/users/ndlib","html_url":"https://github.com/ndlib","followers_url":"https://api.github.com/users/ndlib/followers","following_url":"https://api.github.com/users/ndlib/following{/other_user}","gists_url":"https://api.github.com/users/ndlib/gists{/gist_id}","starred_url":"https://api.github.com/users/ndlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndlib/subscriptions","organizations_url":"https://api.github.com/users/ndlib/orgs","repos_url":"https://api.github.com/users/ndlib/repos","events_url":"https://api.github.com/users/ndlib/events{/privacy}","received_events_url":"https://api.github.com/users/ndlib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ndlib/honeycomb","description":"Honeycomb provides basic collection and item administration, as well as serialization of your collections so they can be used by external applications.","fork":false,"url":"https://api.github.com/repos/ndlib/honeycomb","forks_url":"https://api.github.com/repos/ndlib/honeycomb/forks","keys_url":"https://api.github.com/repos/ndlib/honeycomb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ndlib/honeycomb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ndlib/honeycomb/teams","hooks_url":"https://api.github.com/repos/ndlib/honeycomb/hooks","issue_events_url":"https://api.github.com/repos/ndlib/honeycomb/issues/events{/number}","events_url":"https://api.github.com/repos/ndlib/honeycomb/events","assignees_url":"https://api.github.com/repos/ndlib/honeycomb/assignees{/user}","branches_url":"https://api.github.com/repos/ndlib/honeycomb/branches{/branch}","tags_url":"https://api.github.com/repos/ndlib/honeycomb/tags","blobs_url":"https://api.github.com/repos/ndlib/honeycomb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ndlib/honeycomb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ndlib/honeycomb/git/refs{/sha}","trees_url":"https://api.github.com/repos/ndlib/honeycomb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ndlib/honeycomb/statuses/{sha}","languages_url":"https://api.github.com/repos/ndlib/honeycomb/languages","stargazers_url":"https://api.github.com/repos/ndlib/honeycomb/stargazers","contributors_url":"https://api.github.com/repos/ndlib/honeycomb/contributors","subscribers_url":"https://api.github.com/repos/ndlib/honeycomb/subscribers","subscription_url":"https://api.github.com/repos/ndlib/honeycomb/subscription","commits_url":"https://api.github.com/repos/ndlib/honeycomb/commits{/sha}","git_commits_url":"https://api.github.com/repos/ndlib/honeycomb/git/commits{/sha}","comments_url":"https://api.github.com/repos/ndlib/honeycomb/comments{/number}","issue_comment_url":"https://api.github.com/repos/ndlib/honeycomb/issues/comments{/number}","contents_url":"https://api.github.com/repos/ndlib/honeycomb/contents/{+path}","compare_url":"https://api.github.com/repos/ndlib/honeycomb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ndlib/honeycomb/merges","archive_url":"https://api.github.com/repos/ndlib/honeycomb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ndlib/honeycomb/downloads","issues_url":"https://api.github.com/repos/ndlib/honeycomb/issues{/number}","pulls_url":"https://api.github.com/repos/ndlib/honeycomb/pulls{/number}","milestones_url":"https://api.github.com/repos/ndlib/honeycomb/milestones{/number}","notifications_url":"https://api.github.com/repos/ndlib/honeycomb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ndlib/honeycomb/labels{/name}","releases_url":"https://api.github.com/repos/ndlib/honeycomb/releases{/id}","created_at":"2014-10-14T18:55:34Z","updated_at":"2015-05-08T12:21:27Z","pushed_at":"2015-05-26T15:03:18Z","git_url":"git://github.com/ndlib/honeycomb.git","ssh_url":"git@github.com:ndlib/honeycomb.git","clone_url":"https://github.com/ndlib/honeycomb.git","svn_url":"https://github.com/ndlib/honeycomb","homepage":"","size":92472,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"ndlib:master","ref":"master","sha":"104462a268b940975636dbf8351d3d45801ae23f","user":{"login":"ndlib","id":160943,"avatar_url":"https://avatars.githubusercontent.com/u/160943?v=3","gravatar_id":"","url":"https://api.github.com/users/ndlib","html_url":"https://github.com/ndlib","followers_url":"https://api.github.com/users/ndlib/followers","following_url":"https://api.github.com/users/ndlib/following{/other_user}","gists_url":"https://api.github.com/users/ndlib/gists{/gist_id}","starred_url":"https://api.github.com/users/ndlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndlib/subscriptions","organizations_url":"https://api.github.com/users/ndlib/orgs","repos_url":"https://api.github.com/users/ndlib/repos","events_url":"https://api.github.com/users/ndlib/events{/privacy}","received_events_url":"https://api.github.com/users/ndlib/received_events","type":"Organization","site_admin":false},"repo":{"id":25221636,"name":"honeycomb","full_name":"ndlib/honeycomb","owner":{"login":"ndlib","id":160943,"avatar_url":"https://avatars.githubusercontent.com/u/160943?v=3","gravatar_id":"","url":"https://api.github.com/users/ndlib","html_url":"https://github.com/ndlib","followers_url":"https://api.github.com/users/ndlib/followers","following_url":"https://api.github.com/users/ndlib/following{/other_user}","gists_url":"https://api.github.com/users/ndlib/gists{/gist_id}","starred_url":"https://api.github.com/users/ndlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndlib/subscriptions","organizations_url":"https://api.github.com/users/ndlib/orgs","repos_url":"https://api.github.com/users/ndlib/repos","events_url":"https://api.github.com/users/ndlib/events{/privacy}","received_events_url":"https://api.github.com/users/ndlib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ndlib/honeycomb","description":"Honeycomb provides basic collection and item administration, as well as serialization of your collections so they can be used by external applications.","fork":false,"url":"https://api.github.com/repos/ndlib/honeycomb","forks_url":"https://api.github.com/repos/ndlib/honeycomb/forks","keys_url":"https://api.github.com/repos/ndlib/honeycomb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ndlib/honeycomb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ndlib/honeycomb/teams","hooks_url":"https://api.github.com/repos/ndlib/honeycomb/hooks","issue_events_url":"https://api.github.com/repos/ndlib/honeycomb/issues/events{/number}","events_url":"https://api.github.com/repos/ndlib/honeycomb/events","assignees_url":"https://api.github.com/repos/ndlib/honeycomb/assignees{/user}","branches_url":"https://api.github.com/repos/ndlib/honeycomb/branches{/branch}","tags_url":"https://api.github.com/repos/ndlib/honeycomb/tags","blobs_url":"https://api.github.com/repos/ndlib/honeycomb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ndlib/honeycomb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ndlib/honeycomb/git/refs{/sha}","trees_url":"https://api.github.com/repos/ndlib/honeycomb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ndlib/honeycomb/statuses/{sha}","languages_url":"https://api.github.com/repos/ndlib/honeycomb/languages","stargazers_url":"https://api.github.com/repos/ndlib/honeycomb/stargazers","contributors_url":"https://api.github.com/repos/ndlib/honeycomb/contributors","subscribers_url":"https://api.github.com/repos/ndlib/honeycomb/subscribers","subscription_url":"https://api.github.com/repos/ndlib/honeycomb/subscription","commits_url":"https://api.github.com/repos/ndlib/honeycomb/commits{/sha}","git_commits_url":"https://api.github.com/repos/ndlib/honeycomb/git/commits{/sha}","comments_url":"https://api.github.com/repos/ndlib/honeycomb/comments{/number}","issue_comment_url":"https://api.github.com/repos/ndlib/honeycomb/issues/comments{/number}","contents_url":"https://api.github.com/repos/ndlib/honeycomb/contents/{+path}","compare_url":"https://api.github.com/repos/ndlib/honeycomb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ndlib/honeycomb/merges","archive_url":"https://api.github.com/repos/ndlib/honeycomb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ndlib/honeycomb/downloads","issues_url":"https://api.github.com/repos/ndlib/honeycomb/issues{/number}","pulls_url":"https://api.github.com/repos/ndlib/honeycomb/pulls{/number}","milestones_url":"https://api.github.com/repos/ndlib/honeycomb/milestones{/number}","notifications_url":"https://api.github.com/repos/ndlib/honeycomb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ndlib/honeycomb/labels{/name}","releases_url":"https://api.github.com/repos/ndlib/honeycomb/releases{/id}","created_at":"2014-10-14T18:55:34Z","updated_at":"2015-05-08T12:21:27Z","pushed_at":"2015-05-26T15:03:18Z","git_url":"git://github.com/ndlib/honeycomb.git","ssh_url":"git@github.com:ndlib/honeycomb.git","clone_url":"https://github.com/ndlib/honeycomb.git","svn_url":"https://github.com/ndlib/honeycomb","homepage":"","size":92472,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ndlib/honeycomb/pulls/130"},"html":{"href":"https://github.com/ndlib/honeycomb/pull/130"},"issue":{"href":"https://api.github.com/repos/ndlib/honeycomb/issues/130"},"comments":{"href":"https://api.github.com/repos/ndlib/honeycomb/issues/130/comments"},"review_comments":{"href":"https://api.github.com/repos/ndlib/honeycomb/pulls/130/comments"},"review_comment":{"href":"https://api.github.com/repos/ndlib/honeycomb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ndlib/honeycomb/pulls/130/commits"},"statuses":{"href":"https://api.github.com/repos/ndlib/honeycomb/statuses/880abc8679275e0b7265e0011beb3db9960a1550"}}}}