{"action":"created","comment":{"url":"https://api.github.com/repos/urbn/URBNAlert/pulls/comments/44059508","id":44059508,"diff_hunk":"@@ -151,18 +161,43 @@ - (instancetype)initWithAlertConfig:(URBNAlertConfig *)config alertStyler:(URBNA\n         \n         // Button Constraints\n         self.buttons = [btns copy];\n+        self.sectionCount++;\n         if (self.buttons.count == 1) {\n-            self.sectionCount++;\n             [buttonContainer addConstraints:[NSLayoutConstraint constraintsWithVisualFormat:@\"H:|-btnLeftMargin-[btnOne]-btnRightMargin-|\" options:0 metrics:metrics views:@{@\"btnOne\" : self.buttons.firstObject}]];\n             [buttonContainer addConstraints:[NSLayoutConstraint constraintsWithVisualFormat:@\"V:|-btnTopMargin-[btnOne(btnH)]-btnBottomMargin-|\" options:0 metrics:metrics views:@{@\"btnOne\" : self.buttons.firstObject}]];\n         }\n-        else if (self.buttons.count == 2) {\n-            self.sectionCount++;\n+        else if (self.buttons.count == 2 && !self.alertStyler.useVerticalLayoutForTwoButtons.boolValue) {","path":"Pod/Classes/URBNAlertView.m","position":67,"original_position":67,"commit_id":"5a214e82f8f0a19a2a304180673d31f224add4db","original_commit_id":"eac52a9c09163ff464479219b83062e3a94403b1","user":{"login":"ryang1428","id":3100539,"avatar_url":"https://avatars.githubusercontent.com/u/3100539?v=3","gravatar_id":"","url":"https://api.github.com/users/ryang1428","html_url":"https://github.com/ryang1428","followers_url":"https://api.github.com/users/ryang1428/followers","following_url":"https://api.github.com/users/ryang1428/following{/other_user}","gists_url":"https://api.github.com/users/ryang1428/gists{/gist_id}","starred_url":"https://api.github.com/users/ryang1428/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryang1428/subscriptions","organizations_url":"https://api.github.com/users/ryang1428/orgs","repos_url":"https://api.github.com/users/ryang1428/repos","events_url":"https://api.github.com/users/ryang1428/events{/privacy}","received_events_url":"https://api.github.com/users/ryang1428/received_events","type":"User","site_admin":false},"body":"after looking at this it does-- if there are 2 buttons and `self.alertStyler.useVerticalLayoutForTwoButtons` is true, it goes to the next block which adds the separators ","created_at":"2015-11-05T19:46:23Z","updated_at":"2015-11-05T19:46:23Z","html_url":"https://github.com/urbn/URBNAlert/pull/50#discussion_r44059508","pull_request_url":"https://api.github.com/repos/urbn/URBNAlert/pulls/50","_links":{"self":{"href":"https://api.github.com/repos/urbn/URBNAlert/pulls/comments/44059508"},"html":{"href":"https://github.com/urbn/URBNAlert/pull/50#discussion_r44059508"},"pull_request":{"href":"https://api.github.com/repos/urbn/URBNAlert/pulls/50"}}},"pull_request":{"url":"https://api.github.com/repos/urbn/URBNAlert/pulls/50","id":49621972,"html_url":"https://github.com/urbn/URBNAlert/pull/50","diff_url":"https://github.com/urbn/URBNAlert/pull/50.diff","patch_url":"https://github.com/urbn/URBNAlert/pull/50.patch","issue_url":"https://api.github.com/repos/urbn/URBNAlert/issues/50","number":50,"state":"open","locked":false,"title":"Vertical Layout or Multiple Buttons (from bobwhaler's PR)","user":{"login":"ryang1428","id":3100539,"avatar_url":"https://avatars.githubusercontent.com/u/3100539?v=3","gravatar_id":"","url":"https://api.github.com/users/ryang1428","html_url":"https://github.com/ryang1428","followers_url":"https://api.github.com/users/ryang1428/followers","following_url":"https://api.github.com/users/ryang1428/following{/other_user}","gists_url":"https://api.github.com/users/ryang1428/gists{/gist_id}","starred_url":"https://api.github.com/users/ryang1428/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryang1428/subscriptions","organizations_url":"https://api.github.com/users/ryang1428/orgs","repos_url":"https://api.github.com/users/ryang1428/repos","events_url":"https://api.github.com/users/ryang1428/events{/privacy}","received_events_url":"https://api.github.com/users/ryang1428/received_events","type":"User","site_admin":false},"body":"- removed topMargin property for another PR\r\n- Also, we still need to handle many buttons by placing the buttons in a scrollView, or one of the other options we talked about @jgrandelli. or, we can open up an issue for that\r\noriginal PR: \r\nhttps://github.com/urbn/URBNAlert/pull/49","created_at":"2015-11-03T22:29:42Z","updated_at":"2015-11-05T19:46:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a6d1c8b358ef366bd31a34ffc0bf9e875b34ff84","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/urbn/URBNAlert/pulls/50/commits","review_comments_url":"https://api.github.com/repos/urbn/URBNAlert/pulls/50/comments","review_comment_url":"https://api.github.com/repos/urbn/URBNAlert/pulls/comments{/number}","comments_url":"https://api.github.com/repos/urbn/URBNAlert/issues/50/comments","statuses_url":"https://api.github.com/repos/urbn/URBNAlert/statuses/5a214e82f8f0a19a2a304180673d31f224add4db","head":{"label":"urbn:VerticalButtons","ref":"VerticalButtons","sha":"5a214e82f8f0a19a2a304180673d31f224add4db","user":{"login":"urbn","id":4368103,"avatar_url":"https://avatars.githubusercontent.com/u/4368103?v=3","gravatar_id":"","url":"https://api.github.com/users/urbn","html_url":"https://github.com/urbn","followers_url":"https://api.github.com/users/urbn/followers","following_url":"https://api.github.com/users/urbn/following{/other_user}","gists_url":"https://api.github.com/users/urbn/gists{/gist_id}","starred_url":"https://api.github.com/users/urbn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urbn/subscriptions","organizations_url":"https://api.github.com/users/urbn/orgs","repos_url":"https://api.github.com/users/urbn/repos","events_url":"https://api.github.com/users/urbn/events{/privacy}","received_events_url":"https://api.github.com/users/urbn/received_events","type":"Organization","site_admin":false},"repo":{"id":31658729,"name":"URBNAlert","full_name":"urbn/URBNAlert","owner":{"login":"urbn","id":4368103,"avatar_url":"https://avatars.githubusercontent.com/u/4368103?v=3","gravatar_id":"","url":"https://api.github.com/users/urbn","html_url":"https://github.com/urbn","followers_url":"https://api.github.com/users/urbn/followers","following_url":"https://api.github.com/users/urbn/following{/other_user}","gists_url":"https://api.github.com/users/urbn/gists{/gist_id}","starred_url":"https://api.github.com/users/urbn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urbn/subscriptions","organizations_url":"https://api.github.com/users/urbn/orgs","repos_url":"https://api.github.com/users/urbn/repos","events_url":"https://api.github.com/users/urbn/events{/privacy}","received_events_url":"https://api.github.com/users/urbn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/urbn/URBNAlert","description":"","fork":false,"url":"https://api.github.com/repos/urbn/URBNAlert","forks_url":"https://api.github.com/repos/urbn/URBNAlert/forks","keys_url":"https://api.github.com/repos/urbn/URBNAlert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/urbn/URBNAlert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/urbn/URBNAlert/teams","hooks_url":"https://api.github.com/repos/urbn/URBNAlert/hooks","issue_events_url":"https://api.github.com/repos/urbn/URBNAlert/issues/events{/number}","events_url":"https://api.github.com/repos/urbn/URBNAlert/events","assignees_url":"https://api.github.com/repos/urbn/URBNAlert/assignees{/user}","branches_url":"https://api.github.com/repos/urbn/URBNAlert/branches{/branch}","tags_url":"https://api.github.com/repos/urbn/URBNAlert/tags","blobs_url":"https://api.github.com/repos/urbn/URBNAlert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/urbn/URBNAlert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/urbn/URBNAlert/git/refs{/sha}","trees_url":"https://api.github.com/repos/urbn/URBNAlert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/urbn/URBNAlert/statuses/{sha}","languages_url":"https://api.github.com/repos/urbn/URBNAlert/languages","stargazers_url":"https://api.github.com/repos/urbn/URBNAlert/stargazers","contributors_url":"https://api.github.com/repos/urbn/URBNAlert/contributors","subscribers_url":"https://api.github.com/repos/urbn/URBNAlert/subscribers","subscription_url":"https://api.github.com/repos/urbn/URBNAlert/subscription","commits_url":"https://api.github.com/repos/urbn/URBNAlert/commits{/sha}","git_commits_url":"https://api.github.com/repos/urbn/URBNAlert/git/commits{/sha}","comments_url":"https://api.github.com/repos/urbn/URBNAlert/comments{/number}","issue_comment_url":"https://api.github.com/repos/urbn/URBNAlert/issues/comments{/number}","contents_url":"https://api.github.com/repos/urbn/URBNAlert/contents/{+path}","compare_url":"https://api.github.com/repos/urbn/URBNAlert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/urbn/URBNAlert/merges","archive_url":"https://api.github.com/repos/urbn/URBNAlert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/urbn/URBNAlert/downloads","issues_url":"https://api.github.com/repos/urbn/URBNAlert/issues{/number}","pulls_url":"https://api.github.com/repos/urbn/URBNAlert/pulls{/number}","milestones_url":"https://api.github.com/repos/urbn/URBNAlert/milestones{/number}","notifications_url":"https://api.github.com/repos/urbn/URBNAlert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/urbn/URBNAlert/labels{/name}","releases_url":"https://api.github.com/repos/urbn/URBNAlert/releases{/id}","created_at":"2015-03-04T13:37:05Z","updated_at":"2015-10-14T14:35:30Z","pushed_at":"2015-11-05T18:48:21Z","git_url":"git://github.com/urbn/URBNAlert.git","ssh_url":"git@github.com:urbn/URBNAlert.git","clone_url":"https://github.com/urbn/URBNAlert.git","svn_url":"https://github.com/urbn/URBNAlert","homepage":"","size":1323,"stargazers_count":46,"watchers_count":46,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":3,"forks":10,"open_issues":3,"watchers":46,"default_branch":"master"}},"base":{"label":"urbn:master","ref":"master","sha":"13e08b7a0801456071696992aaaa7f7591a673ce","user":{"login":"urbn","id":4368103,"avatar_url":"https://avatars.githubusercontent.com/u/4368103?v=3","gravatar_id":"","url":"https://api.github.com/users/urbn","html_url":"https://github.com/urbn","followers_url":"https://api.github.com/users/urbn/followers","following_url":"https://api.github.com/users/urbn/following{/other_user}","gists_url":"https://api.github.com/users/urbn/gists{/gist_id}","starred_url":"https://api.github.com/users/urbn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urbn/subscriptions","organizations_url":"https://api.github.com/users/urbn/orgs","repos_url":"https://api.github.com/users/urbn/repos","events_url":"https://api.github.com/users/urbn/events{/privacy}","received_events_url":"https://api.github.com/users/urbn/received_events","type":"Organization","site_admin":false},"repo":{"id":31658729,"name":"URBNAlert","full_name":"urbn/URBNAlert","owner":{"login":"urbn","id":4368103,"avatar_url":"https://avatars.githubusercontent.com/u/4368103?v=3","gravatar_id":"","url":"https://api.github.com/users/urbn","html_url":"https://github.com/urbn","followers_url":"https://api.github.com/users/urbn/followers","following_url":"https://api.github.com/users/urbn/following{/other_user}","gists_url":"https://api.github.com/users/urbn/gists{/gist_id}","starred_url":"https://api.github.com/users/urbn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urbn/subscriptions","organizations_url":"https://api.github.com/users/urbn/orgs","repos_url":"https://api.github.com/users/urbn/repos","events_url":"https://api.github.com/users/urbn/events{/privacy}","received_events_url":"https://api.github.com/users/urbn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/urbn/URBNAlert","description":"","fork":false,"url":"https://api.github.com/repos/urbn/URBNAlert","forks_url":"https://api.github.com/repos/urbn/URBNAlert/forks","keys_url":"https://api.github.com/repos/urbn/URBNAlert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/urbn/URBNAlert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/urbn/URBNAlert/teams","hooks_url":"https://api.github.com/repos/urbn/URBNAlert/hooks","issue_events_url":"https://api.github.com/repos/urbn/URBNAlert/issues/events{/number}","events_url":"https://api.github.com/repos/urbn/URBNAlert/events","assignees_url":"https://api.github.com/repos/urbn/URBNAlert/assignees{/user}","branches_url":"https://api.github.com/repos/urbn/URBNAlert/branches{/branch}","tags_url":"https://api.github.com/repos/urbn/URBNAlert/tags","blobs_url":"https://api.github.com/repos/urbn/URBNAlert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/urbn/URBNAlert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/urbn/URBNAlert/git/refs{/sha}","trees_url":"https://api.github.com/repos/urbn/URBNAlert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/urbn/URBNAlert/statuses/{sha}","languages_url":"https://api.github.com/repos/urbn/URBNAlert/languages","stargazers_url":"https://api.github.com/repos/urbn/URBNAlert/stargazers","contributors_url":"https://api.github.com/repos/urbn/URBNAlert/contributors","subscribers_url":"https://api.github.com/repos/urbn/URBNAlert/subscribers","subscription_url":"https://api.github.com/repos/urbn/URBNAlert/subscription","commits_url":"https://api.github.com/repos/urbn/URBNAlert/commits{/sha}","git_commits_url":"https://api.github.com/repos/urbn/URBNAlert/git/commits{/sha}","comments_url":"https://api.github.com/repos/urbn/URBNAlert/comments{/number}","issue_comment_url":"https://api.github.com/repos/urbn/URBNAlert/issues/comments{/number}","contents_url":"https://api.github.com/repos/urbn/URBNAlert/contents/{+path}","compare_url":"https://api.github.com/repos/urbn/URBNAlert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/urbn/URBNAlert/merges","archive_url":"https://api.github.com/repos/urbn/URBNAlert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/urbn/URBNAlert/downloads","issues_url":"https://api.github.com/repos/urbn/URBNAlert/issues{/number}","pulls_url":"https://api.github.com/repos/urbn/URBNAlert/pulls{/number}","milestones_url":"https://api.github.com/repos/urbn/URBNAlert/milestones{/number}","notifications_url":"https://api.github.com/repos/urbn/URBNAlert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/urbn/URBNAlert/labels{/name}","releases_url":"https://api.github.com/repos/urbn/URBNAlert/releases{/id}","created_at":"2015-03-04T13:37:05Z","updated_at":"2015-10-14T14:35:30Z","pushed_at":"2015-11-05T18:48:21Z","git_url":"git://github.com/urbn/URBNAlert.git","ssh_url":"git@github.com:urbn/URBNAlert.git","clone_url":"https://github.com/urbn/URBNAlert.git","svn_url":"https://github.com/urbn/URBNAlert","homepage":"","size":1323,"stargazers_count":46,"watchers_count":46,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":3,"forks":10,"open_issues":3,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/urbn/URBNAlert/pulls/50"},"html":{"href":"https://github.com/urbn/URBNAlert/pull/50"},"issue":{"href":"https://api.github.com/repos/urbn/URBNAlert/issues/50"},"comments":{"href":"https://api.github.com/repos/urbn/URBNAlert/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/urbn/URBNAlert/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/urbn/URBNAlert/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/urbn/URBNAlert/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/urbn/URBNAlert/statuses/5a214e82f8f0a19a2a304180673d31f224add4db"}}}}