{"action":"created","comment":{"url":"https://api.github.com/repos/meteor-space/todos/pulls/comments/46660700","id":46660700,"diff_hunk":"@@ -6,13 +6,17 @@ Space.Object.extend(Todos, 'TodosController', {\n   ],\n \n   dependencies: {\n-    configuration: 'configuration'\n+    configuration: 'configuration',\n+    todosStore: 'Todos.TodosStore',","path":"packages/app/source/client/controllers/todos-controller.js","position":6,"original_position":6,"commit_id":"c5e426584ef76ad49a235af0110bda38f8e3eff1","original_commit_id":"5d4f2db7513ba03fe0e7e88000f7ccd91fefb4d4","user":{"login":"rhyslbw","id":303881,"avatar_url":"https://avatars.githubusercontent.com/u/303881?v=3","gravatar_id":"","url":"https://api.github.com/users/rhyslbw","html_url":"https://github.com/rhyslbw","followers_url":"https://api.github.com/users/rhyslbw/followers","following_url":"https://api.github.com/users/rhyslbw/following{/other_user}","gists_url":"https://api.github.com/users/rhyslbw/gists{/gist_id}","starred_url":"https://api.github.com/users/rhyslbw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhyslbw/subscriptions","organizations_url":"https://api.github.com/users/rhyslbw/orgs","repos_url":"https://api.github.com/users/rhyslbw/repos","events_url":"https://api.github.com/users/rhyslbw/events{/privacy}","received_events_url":"https://api.github.com/users/rhyslbw/received_events","type":"User","site_admin":false},"body":"Let's wait to hear @DominikGuzei 's take on this. For me it seems better to do this in the component, as the only real reason we need a controller is that the UI event needs to be translated to a command and should be a router type object. This goes for Donations too","created_at":"2015-12-04T08:57:22Z","updated_at":"2015-12-04T08:57:22Z","html_url":"https://github.com/meteor-space/todos/pull/5#discussion_r46660700","pull_request_url":"https://api.github.com/repos/meteor-space/todos/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/meteor-space/todos/pulls/comments/46660700"},"html":{"href":"https://github.com/meteor-space/todos/pull/5#discussion_r46660700"},"pull_request":{"href":"https://api.github.com/repos/meteor-space/todos/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/meteor-space/todos/pulls/5","id":52627674,"html_url":"https://github.com/meteor-space/todos/pull/5","diff_url":"https://github.com/meteor-space/todos/pull/5.diff","patch_url":"https://github.com/meteor-space/todos/pull/5.patch","issue_url":"https://api.github.com/repos/meteor-space/todos/issues/5","number":5,"state":"open","locked":false,"title":"Feature/managing todos","user":{"login":"darko-mijic","id":4280521,"avatar_url":"https://avatars.githubusercontent.com/u/4280521?v=3","gravatar_id":"","url":"https://api.github.com/users/darko-mijic","html_url":"https://github.com/darko-mijic","followers_url":"https://api.github.com/users/darko-mijic/followers","following_url":"https://api.github.com/users/darko-mijic/following{/other_user}","gists_url":"https://api.github.com/users/darko-mijic/gists{/gist_id}","starred_url":"https://api.github.com/users/darko-mijic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darko-mijic/subscriptions","organizations_url":"https://api.github.com/users/darko-mijic/orgs","repos_url":"https://api.github.com/users/darko-mijic/repos","events_url":"https://api.github.com/users/darko-mijic/events{/privacy}","received_events_url":"https://api.github.com/users/darko-mijic/received_events","type":"User","site_admin":false},"body":"Deleting todos, toggling all todos, editing todo titles","created_at":"2015-12-04T04:00:50Z","updated_at":"2015-12-04T08:57:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df59c8b4bc27eb2257a7efb724a132c89823b723","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/meteor-space/todos/pulls/5/commits","review_comments_url":"https://api.github.com/repos/meteor-space/todos/pulls/5/comments","review_comment_url":"https://api.github.com/repos/meteor-space/todos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/meteor-space/todos/issues/5/comments","statuses_url":"https://api.github.com/repos/meteor-space/todos/statuses/c5e426584ef76ad49a235af0110bda38f8e3eff1","head":{"label":"meteor-space:feature/managing-todos","ref":"feature/managing-todos","sha":"c5e426584ef76ad49a235af0110bda38f8e3eff1","user":{"login":"meteor-space","id":13420421,"avatar_url":"https://avatars.githubusercontent.com/u/13420421?v=3","gravatar_id":"","url":"https://api.github.com/users/meteor-space","html_url":"https://github.com/meteor-space","followers_url":"https://api.github.com/users/meteor-space/followers","following_url":"https://api.github.com/users/meteor-space/following{/other_user}","gists_url":"https://api.github.com/users/meteor-space/gists{/gist_id}","starred_url":"https://api.github.com/users/meteor-space/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meteor-space/subscriptions","organizations_url":"https://api.github.com/users/meteor-space/orgs","repos_url":"https://api.github.com/users/meteor-space/repos","events_url":"https://api.github.com/users/meteor-space/events{/privacy}","received_events_url":"https://api.github.com/users/meteor-space/received_events","type":"Organization","site_admin":false},"repo":{"id":45466313,"name":"todos","full_name":"meteor-space/todos","owner":{"login":"meteor-space","id":13420421,"avatar_url":"https://avatars.githubusercontent.com/u/13420421?v=3","gravatar_id":"","url":"https://api.github.com/users/meteor-space","html_url":"https://github.com/meteor-space","followers_url":"https://api.github.com/users/meteor-space/followers","following_url":"https://api.github.com/users/meteor-space/following{/other_user}","gists_url":"https://api.github.com/users/meteor-space/gists{/gist_id}","starred_url":"https://api.github.com/users/meteor-space/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meteor-space/subscriptions","organizations_url":"https://api.github.com/users/meteor-space/orgs","repos_url":"https://api.github.com/users/meteor-space/repos","events_url":"https://api.github.com/users/meteor-space/events{/privacy}","received_events_url":"https://api.github.com/users/meteor-space/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/meteor-space/todos","description":"Todos - demo application based on Space - Modular Application Architecture for Meteor","fork":false,"url":"https://api.github.com/repos/meteor-space/todos","forks_url":"https://api.github.com/repos/meteor-space/todos/forks","keys_url":"https://api.github.com/repos/meteor-space/todos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meteor-space/todos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meteor-space/todos/teams","hooks_url":"https://api.github.com/repos/meteor-space/todos/hooks","issue_events_url":"https://api.github.com/repos/meteor-space/todos/issues/events{/number}","events_url":"https://api.github.com/repos/meteor-space/todos/events","assignees_url":"https://api.github.com/repos/meteor-space/todos/assignees{/user}","branches_url":"https://api.github.com/repos/meteor-space/todos/branches{/branch}","tags_url":"https://api.github.com/repos/meteor-space/todos/tags","blobs_url":"https://api.github.com/repos/meteor-space/todos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meteor-space/todos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meteor-space/todos/git/refs{/sha}","trees_url":"https://api.github.com/repos/meteor-space/todos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meteor-space/todos/statuses/{sha}","languages_url":"https://api.github.com/repos/meteor-space/todos/languages","stargazers_url":"https://api.github.com/repos/meteor-space/todos/stargazers","contributors_url":"https://api.github.com/repos/meteor-space/todos/contributors","subscribers_url":"https://api.github.com/repos/meteor-space/todos/subscribers","subscription_url":"https://api.github.com/repos/meteor-space/todos/subscription","commits_url":"https://api.github.com/repos/meteor-space/todos/commits{/sha}","git_commits_url":"https://api.github.com/repos/meteor-space/todos/git/commits{/sha}","comments_url":"https://api.github.com/repos/meteor-space/todos/comments{/number}","issue_comment_url":"https://api.github.com/repos/meteor-space/todos/issues/comments{/number}","contents_url":"https://api.github.com/repos/meteor-space/todos/contents/{+path}","compare_url":"https://api.github.com/repos/meteor-space/todos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meteor-space/todos/merges","archive_url":"https://api.github.com/repos/meteor-space/todos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meteor-space/todos/downloads","issues_url":"https://api.github.com/repos/meteor-space/todos/issues{/number}","pulls_url":"https://api.github.com/repos/meteor-space/todos/pulls{/number}","milestones_url":"https://api.github.com/repos/meteor-space/todos/milestones{/number}","notifications_url":"https://api.github.com/repos/meteor-space/todos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meteor-space/todos/labels{/name}","releases_url":"https://api.github.com/repos/meteor-space/todos/releases{/id}","created_at":"2015-11-03T12:53:54Z","updated_at":"2015-11-29T03:28:30Z","pushed_at":"2015-12-04T08:32:25Z","git_url":"git://github.com/meteor-space/todos.git","ssh_url":"git@github.com:meteor-space/todos.git","clone_url":"https://github.com/meteor-space/todos.git","svn_url":"https://github.com/meteor-space/todos","homepage":null,"size":97,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"develop"}},"base":{"label":"meteor-space:develop","ref":"develop","sha":"0781a4c2d8bde6f8edc46f3fe3b0af14baaefac8","user":{"login":"meteor-space","id":13420421,"avatar_url":"https://avatars.githubusercontent.com/u/13420421?v=3","gravatar_id":"","url":"https://api.github.com/users/meteor-space","html_url":"https://github.com/meteor-space","followers_url":"https://api.github.com/users/meteor-space/followers","following_url":"https://api.github.com/users/meteor-space/following{/other_user}","gists_url":"https://api.github.com/users/meteor-space/gists{/gist_id}","starred_url":"https://api.github.com/users/meteor-space/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meteor-space/subscriptions","organizations_url":"https://api.github.com/users/meteor-space/orgs","repos_url":"https://api.github.com/users/meteor-space/repos","events_url":"https://api.github.com/users/meteor-space/events{/privacy}","received_events_url":"https://api.github.com/users/meteor-space/received_events","type":"Organization","site_admin":false},"repo":{"id":45466313,"name":"todos","full_name":"meteor-space/todos","owner":{"login":"meteor-space","id":13420421,"avatar_url":"https://avatars.githubusercontent.com/u/13420421?v=3","gravatar_id":"","url":"https://api.github.com/users/meteor-space","html_url":"https://github.com/meteor-space","followers_url":"https://api.github.com/users/meteor-space/followers","following_url":"https://api.github.com/users/meteor-space/following{/other_user}","gists_url":"https://api.github.com/users/meteor-space/gists{/gist_id}","starred_url":"https://api.github.com/users/meteor-space/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meteor-space/subscriptions","organizations_url":"https://api.github.com/users/meteor-space/orgs","repos_url":"https://api.github.com/users/meteor-space/repos","events_url":"https://api.github.com/users/meteor-space/events{/privacy}","received_events_url":"https://api.github.com/users/meteor-space/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/meteor-space/todos","description":"Todos - demo application based on Space - Modular Application Architecture for Meteor","fork":false,"url":"https://api.github.com/repos/meteor-space/todos","forks_url":"https://api.github.com/repos/meteor-space/todos/forks","keys_url":"https://api.github.com/repos/meteor-space/todos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meteor-space/todos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meteor-space/todos/teams","hooks_url":"https://api.github.com/repos/meteor-space/todos/hooks","issue_events_url":"https://api.github.com/repos/meteor-space/todos/issues/events{/number}","events_url":"https://api.github.com/repos/meteor-space/todos/events","assignees_url":"https://api.github.com/repos/meteor-space/todos/assignees{/user}","branches_url":"https://api.github.com/repos/meteor-space/todos/branches{/branch}","tags_url":"https://api.github.com/repos/meteor-space/todos/tags","blobs_url":"https://api.github.com/repos/meteor-space/todos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meteor-space/todos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meteor-space/todos/git/refs{/sha}","trees_url":"https://api.github.com/repos/meteor-space/todos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meteor-space/todos/statuses/{sha}","languages_url":"https://api.github.com/repos/meteor-space/todos/languages","stargazers_url":"https://api.github.com/repos/meteor-space/todos/stargazers","contributors_url":"https://api.github.com/repos/meteor-space/todos/contributors","subscribers_url":"https://api.github.com/repos/meteor-space/todos/subscribers","subscription_url":"https://api.github.com/repos/meteor-space/todos/subscription","commits_url":"https://api.github.com/repos/meteor-space/todos/commits{/sha}","git_commits_url":"https://api.github.com/repos/meteor-space/todos/git/commits{/sha}","comments_url":"https://api.github.com/repos/meteor-space/todos/comments{/number}","issue_comment_url":"https://api.github.com/repos/meteor-space/todos/issues/comments{/number}","contents_url":"https://api.github.com/repos/meteor-space/todos/contents/{+path}","compare_url":"https://api.github.com/repos/meteor-space/todos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meteor-space/todos/merges","archive_url":"https://api.github.com/repos/meteor-space/todos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meteor-space/todos/downloads","issues_url":"https://api.github.com/repos/meteor-space/todos/issues{/number}","pulls_url":"https://api.github.com/repos/meteor-space/todos/pulls{/number}","milestones_url":"https://api.github.com/repos/meteor-space/todos/milestones{/number}","notifications_url":"https://api.github.com/repos/meteor-space/todos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meteor-space/todos/labels{/name}","releases_url":"https://api.github.com/repos/meteor-space/todos/releases{/id}","created_at":"2015-11-03T12:53:54Z","updated_at":"2015-11-29T03:28:30Z","pushed_at":"2015-12-04T08:32:25Z","git_url":"git://github.com/meteor-space/todos.git","ssh_url":"git@github.com:meteor-space/todos.git","clone_url":"https://github.com/meteor-space/todos.git","svn_url":"https://github.com/meteor-space/todos","homepage":null,"size":97,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/meteor-space/todos/pulls/5"},"html":{"href":"https://github.com/meteor-space/todos/pull/5"},"issue":{"href":"https://api.github.com/repos/meteor-space/todos/issues/5"},"comments":{"href":"https://api.github.com/repos/meteor-space/todos/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/meteor-space/todos/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/meteor-space/todos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/meteor-space/todos/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/meteor-space/todos/statuses/c5e426584ef76ad49a235af0110bda38f8e3eff1"}}}}