{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/36659145","id":36659145,"diff_hunk":"@@ -96,7 +96,7 @@ function start_os_server {\n       --loglevel=4 \\\n       1>&2 2>\"${BASETMPDIR}/openshift.log\" &\n   else\n-    sudo env \"PATH=${PATH}\" OPENSHIFT_PROFILE=web OPENSHIFT_ON_PANIC=crash openshift start \\\n+    env \"PATH=${PATH}\" OPENSHIFT_PROFILE=web OPENSHIFT_ON_PANIC=crash openshift start \\","path":"hack/util.sh","position":5,"original_position":5,"commit_id":"c5b972b91bd8460662b7cfb420d8773ed9b292e2","original_commit_id":"c5b972b91bd8460662b7cfb420d8773ed9b292e2","user":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"body":"Sudo is required in hack/util.sh for start_os_server for the all-in-one\nbecause you need root.  We don't require running our hack scripts with\nsudo.  So we need to continue to use sudo for running a full server.\n\nOn Mon, Aug 10, 2015 at 7:49 AM, David Eads <notifications@github.com>\nwrote:\n\n> In hack/util.sh\n> <https://github.com/openshift/origin/pull/4072#discussion_r36623156>:\n>\n> > @@ -96,7 +96,7 @@ function start_os_server {\n> >        --loglevel=4 \\\n> >        1>&2 2>\"${BASETMPDIR}/openshift.log\" &\n> >    else\n> > -    sudo env \"PATH=${PATH}\" OPENSHIFT_PROFILE=web OPENSHIFT_ON_PANIC=crash openshift start \\\n> > +    env \"PATH=${PATH}\" OPENSHIFT_PROFILE=web OPENSHIFT_ON_PANIC=crash openshift start \\\n>\n> sudo is required to be able to make services work correctly, so without\n> privileged execution, the value of starting the server is severely limited.\n> I thought that @smarterclayton <https://github.com/smarterclayton> had\n> some bash insanity that got the job done.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/openshift/origin/pull/4072/files#r36623156>.\n>\n\n\n\n-- \nClayton Coleman | Lead Engineer, OpenShift\n","created_at":"2015-08-10T17:30:21Z","updated_at":"2015-08-10T17:30:21Z","html_url":"https://github.com/openshift/origin/pull/4072#discussion_r36659145","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/4072","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/36659145"},"html":{"href":"https://github.com/openshift/origin/pull/4072#discussion_r36659145"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/4072"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/4072","id":41997356,"html_url":"https://github.com/openshift/origin/pull/4072","diff_url":"https://github.com/openshift/origin/pull/4072.diff","patch_url":"https://github.com/openshift/origin/pull/4072.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/4072","number":4072,"state":"open","locked":false,"title":"kill all child processes","user":{"login":"jhadvig","id":1668218,"avatar_url":"https://avatars.githubusercontent.com/u/1668218?v=3","gravatar_id":"","url":"https://api.github.com/users/jhadvig","html_url":"https://github.com/jhadvig","followers_url":"https://api.github.com/users/jhadvig/followers","following_url":"https://api.github.com/users/jhadvig/following{/other_user}","gists_url":"https://api.github.com/users/jhadvig/gists{/gist_id}","starred_url":"https://api.github.com/users/jhadvig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhadvig/subscriptions","organizations_url":"https://api.github.com/users/jhadvig/orgs","repos_url":"https://api.github.com/users/jhadvig/repos","events_url":"https://api.github.com/users/jhadvig/events{/privacy}","received_events_url":"https://api.github.com/users/jhadvig/received_events","type":"User","site_admin":false},"body":"The OS server has to be started without sudo or else the the cleanup wont be able shut the server down, since sudo will spawn a new subshell. When trying to kill the OS server, only the subshell will be killed and the OS server will become a orphan process and then needs to be killed manually.\r\n\r\nThis fix counts with the case that we are running our tests as sudo/root\r\n@deads2k thoughts ?","created_at":"2015-08-10T08:32:39Z","updated_at":"2015-08-10T17:30:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4a6e1f194351b3769240e390b38bacfac803268","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/4072/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/4072/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/4072/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/c5b972b91bd8460662b7cfb420d8773ed9b292e2","head":{"label":"jhadvig:kill_os","ref":"kill_os","sha":"c5b972b91bd8460662b7cfb420d8773ed9b292e2","user":{"login":"jhadvig","id":1668218,"avatar_url":"https://avatars.githubusercontent.com/u/1668218?v=3","gravatar_id":"","url":"https://api.github.com/users/jhadvig","html_url":"https://github.com/jhadvig","followers_url":"https://api.github.com/users/jhadvig/followers","following_url":"https://api.github.com/users/jhadvig/following{/other_user}","gists_url":"https://api.github.com/users/jhadvig/gists{/gist_id}","starred_url":"https://api.github.com/users/jhadvig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhadvig/subscriptions","organizations_url":"https://api.github.com/users/jhadvig/orgs","repos_url":"https://api.github.com/users/jhadvig/repos","events_url":"https://api.github.com/users/jhadvig/events{/privacy}","received_events_url":"https://api.github.com/users/jhadvig/received_events","type":"User","site_admin":false},"repo":{"id":24180023,"name":"origin","full_name":"jhadvig/origin","owner":{"login":"jhadvig","id":1668218,"avatar_url":"https://avatars.githubusercontent.com/u/1668218?v=3","gravatar_id":"","url":"https://api.github.com/users/jhadvig","html_url":"https://github.com/jhadvig","followers_url":"https://api.github.com/users/jhadvig/followers","following_url":"https://api.github.com/users/jhadvig/following{/other_user}","gists_url":"https://api.github.com/users/jhadvig/gists{/gist_id}","starred_url":"https://api.github.com/users/jhadvig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhadvig/subscriptions","organizations_url":"https://api.github.com/users/jhadvig/orgs","repos_url":"https://api.github.com/users/jhadvig/repos","events_url":"https://api.github.com/users/jhadvig/events{/privacy}","received_events_url":"https://api.github.com/users/jhadvig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jhadvig/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/jhadvig/origin","forks_url":"https://api.github.com/repos/jhadvig/origin/forks","keys_url":"https://api.github.com/repos/jhadvig/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhadvig/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhadvig/origin/teams","hooks_url":"https://api.github.com/repos/jhadvig/origin/hooks","issue_events_url":"https://api.github.com/repos/jhadvig/origin/issues/events{/number}","events_url":"https://api.github.com/repos/jhadvig/origin/events","assignees_url":"https://api.github.com/repos/jhadvig/origin/assignees{/user}","branches_url":"https://api.github.com/repos/jhadvig/origin/branches{/branch}","tags_url":"https://api.github.com/repos/jhadvig/origin/tags","blobs_url":"https://api.github.com/repos/jhadvig/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhadvig/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhadvig/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhadvig/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhadvig/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/jhadvig/origin/languages","stargazers_url":"https://api.github.com/repos/jhadvig/origin/stargazers","contributors_url":"https://api.github.com/repos/jhadvig/origin/contributors","subscribers_url":"https://api.github.com/repos/jhadvig/origin/subscribers","subscription_url":"https://api.github.com/repos/jhadvig/origin/subscription","commits_url":"https://api.github.com/repos/jhadvig/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhadvig/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhadvig/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhadvig/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhadvig/origin/contents/{+path}","compare_url":"https://api.github.com/repos/jhadvig/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhadvig/origin/merges","archive_url":"https://api.github.com/repos/jhadvig/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhadvig/origin/downloads","issues_url":"https://api.github.com/repos/jhadvig/origin/issues{/number}","pulls_url":"https://api.github.com/repos/jhadvig/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/jhadvig/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/jhadvig/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhadvig/origin/labels{/name}","releases_url":"https://api.github.com/repos/jhadvig/origin/releases{/id}","created_at":"2014-09-18T08:22:36Z","updated_at":"2014-09-18T06:20:16Z","pushed_at":"2015-08-10T14:33:42Z","git_url":"git://github.com/jhadvig/origin.git","ssh_url":"git@github.com:jhadvig/origin.git","clone_url":"https://github.com/jhadvig/origin.git","svn_url":"https://github.com/jhadvig/origin","homepage":"https://openshift.github.io","size":123537,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"47a887512cf7e1f6d565697c0588979d36181256","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2015-08-10T10:38:29Z","pushed_at":"2015-08-10T17:28:44Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":200521,"stargazers_count":611,"watchers_count":611,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":345,"mirror_url":null,"open_issues_count":499,"forks":345,"open_issues":499,"watchers":611,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/4072"},"html":{"href":"https://github.com/openshift/origin/pull/4072"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/4072"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/4072/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/4072/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/4072/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/c5b972b91bd8460662b7cfb420d8773ed9b292e2"}}}}