{"action":"created","comment":{"url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/pulls/comments/25144824","id":25144824,"diff_hunk":"@@ -1,16 +1,30 @@\n #!/bin/bash\n-if [ \"$CONFIGURATION\" == \"Debug\" ]\n+# Use git commit short SHA for Debug/AdHocDistribution configuration (e.g. TestFlight)\n+if [ \"$CONFIGURATION\" == \"Debug\" -o \"$CONFIGURATION\" == \"AdHocDistribution\" ]\n then\n     # Get current git commit short SHA\n     gitCommitSHA=$(git rev-parse --short HEAD)\n     # Check if the git working copy is dirty\n-    if test -n \"$(git status --porcelain)\"\n+    if [ -n \"$(git status --porcelain)\" ]\n     then\n         # Append a plus character to the git commit short SHA to indicate dirty changes in build\n         gitCommitSHA+=\"+\"\n     fi\n-    # Set bundle build version to current git commit short SHA with dirty indicator\n+fi\n+\n+# Use git commit count for Master branch and AppStoreDistribution configuration (e.g. App Store release)\n+currentGitBranchName=$(git rev-parse --abbrev-ref HEAD)\n+if [ \"$currentGitBranchName\" == \"master\" -a \"$CONFIGURATION\" == \"AppStoreDistribution\" ]\n+then\n+    # Get current git commit count\n+    gitCommitSHA=$(git rev-list HEAD | wc -l | tr -d ' ')\n+fi\n+\n+#\n+if [ -n \"$gitCommitSHA\" ]\n+then\n+    # Set bundle build version\n     echo \"#define GIT_COMMIT_SHA $gitCommitSHA\" >> $PROJECT_TEMP_DIR/infoplist.prefix\n+    # Tell Xcode to preprocess Info.plist\n+    touch $PROJECT_DIR/Info.plist","path":"scripts/setBuildVersion.sh","position":32,"original_position":32,"commit_id":"85fb25c9de10f41f673d33c0c821854c37e9a344","original_commit_id":"85fb25c9de10f41f673d33c0c821854c37e9a344","user":{"login":"aaronbrethorst","id":2254,"avatar_url":"https://avatars.githubusercontent.com/u/2254?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronbrethorst","html_url":"https://github.com/aaronbrethorst","followers_url":"https://api.github.com/users/aaronbrethorst/followers","following_url":"https://api.github.com/users/aaronbrethorst/following{/other_user}","gists_url":"https://api.github.com/users/aaronbrethorst/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronbrethorst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronbrethorst/subscriptions","organizations_url":"https://api.github.com/users/aaronbrethorst/orgs","repos_url":"https://api.github.com/users/aaronbrethorst/repos","events_url":"https://api.github.com/users/aaronbrethorst/events{/privacy}","received_events_url":"https://api.github.com/users/aaronbrethorst/received_events","type":"User","site_admin":false},"body":"@bbodenmiller see https://github.com/OneBusAway/onebusaway-iphone/pull/259#discussion_r25144812 — the error suggests some path isn't properly escaping the space in your disk's name.","created_at":"2015-02-23T05:47:27Z","updated_at":"2015-02-23T05:47:27Z","html_url":"https://github.com/OneBusAway/onebusaway-iphone/pull/259#discussion_r25144824","pull_request_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/pulls/259","_links":{"self":{"href":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/pulls/comments/25144824"},"html":{"href":"https://github.com/OneBusAway/onebusaway-iphone/pull/259#discussion_r25144824"},"pull_request":{"href":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/pulls/259"}}},"pull_request":{"url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/pulls/259","id":12345231,"html_url":"https://github.com/OneBusAway/onebusaway-iphone/pull/259","diff_url":"https://github.com/OneBusAway/onebusaway-iphone/pull/259.diff","patch_url":"https://github.com/OneBusAway/onebusaway-iphone/pull/259.patch","issue_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/issues/259","number":259,"state":"closed","locked":false,"title":"Fixed GIT_COMMIT_SHA for TestFlight build uploads.","user":{"login":"neophit","id":498432,"avatar_url":"https://avatars.githubusercontent.com/u/498432?v=3","gravatar_id":"","url":"https://api.github.com/users/neophit","html_url":"https://github.com/neophit","followers_url":"https://api.github.com/users/neophit/followers","following_url":"https://api.github.com/users/neophit/following{/other_user}","gists_url":"https://api.github.com/users/neophit/gists{/gist_id}","starred_url":"https://api.github.com/users/neophit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neophit/subscriptions","organizations_url":"https://api.github.com/users/neophit/orgs","repos_url":"https://api.github.com/users/neophit/repos","events_url":"https://api.github.com/users/neophit/events{/privacy}","received_events_url":"https://api.github.com/users/neophit/received_events","type":"User","site_admin":false},"body":"Modified setBuildVersion.sh to work with the AdHocDistribution configuration which is used to Archive and upload builds to TestFlight.","created_at":"2014-02-08T20:56:26Z","updated_at":"2015-02-23T05:47:27Z","closed_at":"2014-02-11T20:48:30Z","merged_at":"2014-02-11T20:48:30Z","merge_commit_sha":"bf953ae795dfa14e8d11b96288b3d8575f9266af","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/pulls/259/commits","review_comments_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/pulls/259/comments","review_comment_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/issues/259/comments","statuses_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/statuses/85fb25c9de10f41f673d33c0c821854c37e9a344","head":{"label":"neophit:develop","ref":"develop","sha":"85fb25c9de10f41f673d33c0c821854c37e9a344","user":{"login":"neophit","id":498432,"avatar_url":"https://avatars.githubusercontent.com/u/498432?v=3","gravatar_id":"","url":"https://api.github.com/users/neophit","html_url":"https://github.com/neophit","followers_url":"https://api.github.com/users/neophit/followers","following_url":"https://api.github.com/users/neophit/following{/other_user}","gists_url":"https://api.github.com/users/neophit/gists{/gist_id}","starred_url":"https://api.github.com/users/neophit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neophit/subscriptions","organizations_url":"https://api.github.com/users/neophit/orgs","repos_url":"https://api.github.com/users/neophit/repos","events_url":"https://api.github.com/users/neophit/events{/privacy}","received_events_url":"https://api.github.com/users/neophit/received_events","type":"User","site_admin":false},"repo":{"id":11458229,"name":"onebusaway-iphone","full_name":"neophit/onebusaway-iphone","owner":{"login":"neophit","id":498432,"avatar_url":"https://avatars.githubusercontent.com/u/498432?v=3","gravatar_id":"","url":"https://api.github.com/users/neophit","html_url":"https://github.com/neophit","followers_url":"https://api.github.com/users/neophit/followers","following_url":"https://api.github.com/users/neophit/following{/other_user}","gists_url":"https://api.github.com/users/neophit/gists{/gist_id}","starred_url":"https://api.github.com/users/neophit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neophit/subscriptions","organizations_url":"https://api.github.com/users/neophit/orgs","repos_url":"https://api.github.com/users/neophit/repos","events_url":"https://api.github.com/users/neophit/events{/privacy}","received_events_url":"https://api.github.com/users/neophit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/neophit/onebusaway-iphone","description":"The OneBusAway iPhone app.","fork":true,"url":"https://api.github.com/repos/neophit/onebusaway-iphone","forks_url":"https://api.github.com/repos/neophit/onebusaway-iphone/forks","keys_url":"https://api.github.com/repos/neophit/onebusaway-iphone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neophit/onebusaway-iphone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neophit/onebusaway-iphone/teams","hooks_url":"https://api.github.com/repos/neophit/onebusaway-iphone/hooks","issue_events_url":"https://api.github.com/repos/neophit/onebusaway-iphone/issues/events{/number}","events_url":"https://api.github.com/repos/neophit/onebusaway-iphone/events","assignees_url":"https://api.github.com/repos/neophit/onebusaway-iphone/assignees{/user}","branches_url":"https://api.github.com/repos/neophit/onebusaway-iphone/branches{/branch}","tags_url":"https://api.github.com/repos/neophit/onebusaway-iphone/tags","blobs_url":"https://api.github.com/repos/neophit/onebusaway-iphone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neophit/onebusaway-iphone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neophit/onebusaway-iphone/git/refs{/sha}","trees_url":"https://api.github.com/repos/neophit/onebusaway-iphone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neophit/onebusaway-iphone/statuses/{sha}","languages_url":"https://api.github.com/repos/neophit/onebusaway-iphone/languages","stargazers_url":"https://api.github.com/repos/neophit/onebusaway-iphone/stargazers","contributors_url":"https://api.github.com/repos/neophit/onebusaway-iphone/contributors","subscribers_url":"https://api.github.com/repos/neophit/onebusaway-iphone/subscribers","subscription_url":"https://api.github.com/repos/neophit/onebusaway-iphone/subscription","commits_url":"https://api.github.com/repos/neophit/onebusaway-iphone/commits{/sha}","git_commits_url":"https://api.github.com/repos/neophit/onebusaway-iphone/git/commits{/sha}","comments_url":"https://api.github.com/repos/neophit/onebusaway-iphone/comments{/number}","issue_comment_url":"https://api.github.com/repos/neophit/onebusaway-iphone/issues/comments{/number}","contents_url":"https://api.github.com/repos/neophit/onebusaway-iphone/contents/{+path}","compare_url":"https://api.github.com/repos/neophit/onebusaway-iphone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neophit/onebusaway-iphone/merges","archive_url":"https://api.github.com/repos/neophit/onebusaway-iphone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neophit/onebusaway-iphone/downloads","issues_url":"https://api.github.com/repos/neophit/onebusaway-iphone/issues{/number}","pulls_url":"https://api.github.com/repos/neophit/onebusaway-iphone/pulls{/number}","milestones_url":"https://api.github.com/repos/neophit/onebusaway-iphone/milestones{/number}","notifications_url":"https://api.github.com/repos/neophit/onebusaway-iphone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neophit/onebusaway-iphone/labels{/name}","releases_url":"https://api.github.com/repos/neophit/onebusaway-iphone/releases{/id}","created_at":"2013-07-16T19:30:11Z","updated_at":"2014-02-11T20:48:30Z","pushed_at":"2014-02-08T22:20:03Z","git_url":"git://github.com/neophit/onebusaway-iphone.git","ssh_url":"git@github.com:neophit/onebusaway-iphone.git","clone_url":"https://github.com/neophit/onebusaway-iphone.git","svn_url":"https://github.com/neophit/onebusaway-iphone","homepage":"","size":10374,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OneBusAway:develop","ref":"develop","sha":"fbe5794dfd08ab0af3bdf94d67e95864668fc2af","user":{"login":"OneBusAway","id":1428806,"avatar_url":"https://avatars.githubusercontent.com/u/1428806?v=3","gravatar_id":"","url":"https://api.github.com/users/OneBusAway","html_url":"https://github.com/OneBusAway","followers_url":"https://api.github.com/users/OneBusAway/followers","following_url":"https://api.github.com/users/OneBusAway/following{/other_user}","gists_url":"https://api.github.com/users/OneBusAway/gists{/gist_id}","starred_url":"https://api.github.com/users/OneBusAway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OneBusAway/subscriptions","organizations_url":"https://api.github.com/users/OneBusAway/orgs","repos_url":"https://api.github.com/users/OneBusAway/repos","events_url":"https://api.github.com/users/OneBusAway/events{/privacy}","received_events_url":"https://api.github.com/users/OneBusAway/received_events","type":"Organization","site_admin":false},"repo":{"id":3447443,"name":"onebusaway-iphone","full_name":"OneBusAway/onebusaway-iphone","owner":{"login":"OneBusAway","id":1428806,"avatar_url":"https://avatars.githubusercontent.com/u/1428806?v=3","gravatar_id":"","url":"https://api.github.com/users/OneBusAway","html_url":"https://github.com/OneBusAway","followers_url":"https://api.github.com/users/OneBusAway/followers","following_url":"https://api.github.com/users/OneBusAway/following{/other_user}","gists_url":"https://api.github.com/users/OneBusAway/gists{/gist_id}","starred_url":"https://api.github.com/users/OneBusAway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OneBusAway/subscriptions","organizations_url":"https://api.github.com/users/OneBusAway/orgs","repos_url":"https://api.github.com/users/OneBusAway/repos","events_url":"https://api.github.com/users/OneBusAway/events{/privacy}","received_events_url":"https://api.github.com/users/OneBusAway/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OneBusAway/onebusaway-iphone","description":"The OneBusAway iPhone app.","fork":false,"url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone","forks_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/forks","keys_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/teams","hooks_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/hooks","issue_events_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/issues/events{/number}","events_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/events","assignees_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/assignees{/user}","branches_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/branches{/branch}","tags_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/tags","blobs_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/git/refs{/sha}","trees_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/statuses/{sha}","languages_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/languages","stargazers_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/stargazers","contributors_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/contributors","subscribers_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/subscribers","subscription_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/subscription","commits_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/commits{/sha}","git_commits_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/git/commits{/sha}","comments_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/comments{/number}","issue_comment_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/issues/comments{/number}","contents_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/contents/{+path}","compare_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/merges","archive_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/downloads","issues_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/issues{/number}","pulls_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/pulls{/number}","milestones_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/milestones{/number}","notifications_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/labels{/name}","releases_url":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/releases{/id}","created_at":"2012-02-15T07:17:54Z","updated_at":"2015-02-23T05:32:05Z","pushed_at":"2015-02-23T05:32:05Z","git_url":"git://github.com/OneBusAway/onebusaway-iphone.git","ssh_url":"git@github.com:OneBusAway/onebusaway-iphone.git","clone_url":"https://github.com/OneBusAway/onebusaway-iphone.git","svn_url":"https://github.com/OneBusAway/onebusaway-iphone","homepage":"","size":18899,"stargazers_count":91,"watchers_count":91,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":62,"mirror_url":null,"open_issues_count":69,"forks":62,"open_issues":69,"watchers":91,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/pulls/259"},"html":{"href":"https://github.com/OneBusAway/onebusaway-iphone/pull/259"},"issue":{"href":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/issues/259"},"comments":{"href":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/issues/259/comments"},"review_comments":{"href":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/pulls/259/comments"},"review_comment":{"href":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/pulls/259/commits"},"statuses":{"href":"https://api.github.com/repos/OneBusAway/onebusaway-iphone/statuses/85fb25c9de10f41f673d33c0c821854c37e9a344"}}}}