{"action":"created","issue":{"url":"https://api.github.com/repos/genome/diagnose_dups/issues/1","labels_url":"https://api.github.com/repos/genome/diagnose_dups/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/genome/diagnose_dups/issues/1/comments","events_url":"https://api.github.com/repos/genome/diagnose_dups/issues/1/events","html_url":"https://github.com/genome/diagnose_dups/pull/1","id":63472133,"number":1,"title":"Code review","user":{"login":"tabbott","id":463300,"avatar_url":"https://avatars.githubusercontent.com/u/463300?v=3","gravatar_id":"","url":"https://api.github.com/users/tabbott","html_url":"https://github.com/tabbott","followers_url":"https://api.github.com/users/tabbott/followers","following_url":"https://api.github.com/users/tabbott/following{/other_user}","gists_url":"https://api.github.com/users/tabbott/gists{/gist_id}","starred_url":"https://api.github.com/users/tabbott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tabbott/subscriptions","organizations_url":"https://api.github.com/users/tabbott/orgs","repos_url":"https://api.github.com/users/tabbott/repos","events_url":"https://api.github.com/users/tabbott/events{/privacy}","received_events_url":"https://api.github.com/users/tabbott/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2015-03-22T00:56:47Z","updated_at":"2015-03-22T05:28:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/genome/diagnose_dups/pulls/1","html_url":"https://github.com/genome/diagnose_dups/pull/1","diff_url":"https://github.com/genome/diagnose_dups/pull/1.diff","patch_url":"https://github.com/genome/diagnose_dups/pull/1.patch"},"body":"Some general code review:\r\n\r\nI improved performance on the cigar string -> parsed cigar array stuff by ~3.5x. I don't think it was an actual bottleneck but the code was bugging me.\r\n\r\nI also refactored the left/right offset calculation code. In general, try to write less raw loops. Use algorithms (#include algorithm) when you can. In c++11/14, you get lambdas which makes doing so even more attractive (you don't have to write a bunch of little helper functions). In c++14, you can write:\r\n\r\nreturn std::accumulate(beg, end, 0, [] (auto x, auto y) { if (want(y)) x += y; return x; });\r\n\r\nI'm off to look at the other library now."},"comment":{"url":"https://api.github.com/repos/genome/diagnose_dups/issues/comments/84524626","html_url":"https://github.com/genome/diagnose_dups/pull/1#issuecomment-84524626","issue_url":"https://api.github.com/repos/genome/diagnose_dups/issues/1","id":84524626,"user":{"login":"ernfrid","id":397990,"avatar_url":"https://avatars.githubusercontent.com/u/397990?v=3","gravatar_id":"","url":"https://api.github.com/users/ernfrid","html_url":"https://github.com/ernfrid","followers_url":"https://api.github.com/users/ernfrid/followers","following_url":"https://api.github.com/users/ernfrid/following{/other_user}","gists_url":"https://api.github.com/users/ernfrid/gists{/gist_id}","starred_url":"https://api.github.com/users/ernfrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ernfrid/subscriptions","organizations_url":"https://api.github.com/users/ernfrid/orgs","repos_url":"https://api.github.com/users/ernfrid/repos","events_url":"https://api.github.com/users/ernfrid/events{/privacy}","received_events_url":"https://api.github.com/users/ernfrid/received_events","type":"User","site_admin":false},"created_at":"2015-03-22T05:28:43Z","updated_at":"2015-03-22T05:28:43Z","body":"Yes! That was the gap in my thinking on the pass by reference."}}