{"action":"created","comment":{"url":"https://api.github.com/repos/juliangruber/reconnect-core/pulls/comments/30598301","id":30598301,"diff_hunk":"@@ -41,7 +41,11 @@ function (createConnection) {\n \n       function onError (err) {\n         con.removeListener('error', onError)\n-        emitter.emit('error', err)\n+        try\n+        {\n+          emitter.emit('error', err)\n+        }\n+        catch(e){}","path":"index.js","position":9,"original_position":9,"commit_id":"921d43e91578abb2fb2613f585c010c1939cf734","original_commit_id":"921d43e91578abb2fb2613f585c010c1939cf734","user":{"login":"juliangruber","id":10247,"avatar_url":"https://avatars.githubusercontent.com/u/10247?v=3","gravatar_id":"","url":"https://api.github.com/users/juliangruber","html_url":"https://github.com/juliangruber","followers_url":"https://api.github.com/users/juliangruber/followers","following_url":"https://api.github.com/users/juliangruber/following{/other_user}","gists_url":"https://api.github.com/users/juliangruber/gists{/gist_id}","starred_url":"https://api.github.com/users/juliangruber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliangruber/subscriptions","organizations_url":"https://api.github.com/users/juliangruber/orgs","repos_url":"https://api.github.com/users/juliangruber/repos","events_url":"https://api.github.com/users/juliangruber/events{/privacy}","received_events_url":"https://api.github.com/users/juliangruber/received_events","type":"User","site_admin":false},"body":"i won't merge this, users _need_ to listen to the `\"error\"` event. if this isn't a real error, i'd rather rename to `\"warning\"` in stead of bypassing standard node core logic.","created_at":"2015-05-19T13:30:04Z","updated_at":"2015-05-19T13:30:04Z","html_url":"https://github.com/juliangruber/reconnect-core/pull/21#discussion_r30598301","pull_request_url":"https://api.github.com/repos/juliangruber/reconnect-core/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/juliangruber/reconnect-core/pulls/comments/30598301"},"html":{"href":"https://github.com/juliangruber/reconnect-core/pull/21#discussion_r30598301"},"pull_request":{"href":"https://api.github.com/repos/juliangruber/reconnect-core/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/juliangruber/reconnect-core/pulls/21","id":35721041,"html_url":"https://github.com/juliangruber/reconnect-core/pull/21","diff_url":"https://github.com/juliangruber/reconnect-core/pull/21.diff","patch_url":"https://github.com/juliangruber/reconnect-core/pull/21.patch","issue_url":"https://api.github.com/repos/juliangruber/reconnect-core/issues/21","number":21,"state":"open","locked":false,"title":"Don't fail if 'error' event is not registered and emit error on 'fail' event","user":{"login":"piranna","id":532414,"avatar_url":"https://avatars.githubusercontent.com/u/532414?v=3","gravatar_id":"","url":"https://api.github.com/users/piranna","html_url":"https://github.com/piranna","followers_url":"https://api.github.com/users/piranna/followers","following_url":"https://api.github.com/users/piranna/following{/other_user}","gists_url":"https://api.github.com/users/piranna/gists{/gist_id}","starred_url":"https://api.github.com/users/piranna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piranna/subscriptions","organizations_url":"https://api.github.com/users/piranna/orgs","repos_url":"https://api.github.com/users/piranna/repos","events_url":"https://api.github.com/users/piranna/events{/privacy}","received_events_url":"https://api.github.com/users/piranna/received_events","type":"User","site_admin":false},"body":"This fixes problem with unregistered error event on #19 ","created_at":"2015-05-19T11:39:49Z","updated_at":"2015-05-19T13:30:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7626a56d245f616341d845052c668535585c0412","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juliangruber/reconnect-core/pulls/21/commits","review_comments_url":"https://api.github.com/repos/juliangruber/reconnect-core/pulls/21/comments","review_comment_url":"https://api.github.com/repos/juliangruber/reconnect-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juliangruber/reconnect-core/issues/21/comments","statuses_url":"https://api.github.com/repos/juliangruber/reconnect-core/statuses/921d43e91578abb2fb2613f585c010c1939cf734","head":{"label":"KurentoForks:master","ref":"master","sha":"921d43e91578abb2fb2613f585c010c1939cf734","user":{"login":"KurentoForks","id":8235241,"avatar_url":"https://avatars.githubusercontent.com/u/8235241?v=3","gravatar_id":"","url":"https://api.github.com/users/KurentoForks","html_url":"https://github.com/KurentoForks","followers_url":"https://api.github.com/users/KurentoForks/followers","following_url":"https://api.github.com/users/KurentoForks/following{/other_user}","gists_url":"https://api.github.com/users/KurentoForks/gists{/gist_id}","starred_url":"https://api.github.com/users/KurentoForks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KurentoForks/subscriptions","organizations_url":"https://api.github.com/users/KurentoForks/orgs","repos_url":"https://api.github.com/users/KurentoForks/repos","events_url":"https://api.github.com/users/KurentoForks/events{/privacy}","received_events_url":"https://api.github.com/users/KurentoForks/received_events","type":"Organization","site_admin":false},"repo":{"id":35024405,"name":"reconnect-core","full_name":"KurentoForks/reconnect-core","owner":{"login":"KurentoForks","id":8235241,"avatar_url":"https://avatars.githubusercontent.com/u/8235241?v=3","gravatar_id":"","url":"https://api.github.com/users/KurentoForks","html_url":"https://github.com/KurentoForks","followers_url":"https://api.github.com/users/KurentoForks/followers","following_url":"https://api.github.com/users/KurentoForks/following{/other_user}","gists_url":"https://api.github.com/users/KurentoForks/gists{/gist_id}","starred_url":"https://api.github.com/users/KurentoForks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KurentoForks/subscriptions","organizations_url":"https://api.github.com/users/KurentoForks/orgs","repos_url":"https://api.github.com/users/KurentoForks/repos","events_url":"https://api.github.com/users/KurentoForks/events{/privacy}","received_events_url":"https://api.github.com/users/KurentoForks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KurentoForks/reconnect-core","description":"Generic stream reconnection module.","fork":true,"url":"https://api.github.com/repos/KurentoForks/reconnect-core","forks_url":"https://api.github.com/repos/KurentoForks/reconnect-core/forks","keys_url":"https://api.github.com/repos/KurentoForks/reconnect-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KurentoForks/reconnect-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KurentoForks/reconnect-core/teams","hooks_url":"https://api.github.com/repos/KurentoForks/reconnect-core/hooks","issue_events_url":"https://api.github.com/repos/KurentoForks/reconnect-core/issues/events{/number}","events_url":"https://api.github.com/repos/KurentoForks/reconnect-core/events","assignees_url":"https://api.github.com/repos/KurentoForks/reconnect-core/assignees{/user}","branches_url":"https://api.github.com/repos/KurentoForks/reconnect-core/branches{/branch}","tags_url":"https://api.github.com/repos/KurentoForks/reconnect-core/tags","blobs_url":"https://api.github.com/repos/KurentoForks/reconnect-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KurentoForks/reconnect-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KurentoForks/reconnect-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/KurentoForks/reconnect-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KurentoForks/reconnect-core/statuses/{sha}","languages_url":"https://api.github.com/repos/KurentoForks/reconnect-core/languages","stargazers_url":"https://api.github.com/repos/KurentoForks/reconnect-core/stargazers","contributors_url":"https://api.github.com/repos/KurentoForks/reconnect-core/contributors","subscribers_url":"https://api.github.com/repos/KurentoForks/reconnect-core/subscribers","subscription_url":"https://api.github.com/repos/KurentoForks/reconnect-core/subscription","commits_url":"https://api.github.com/repos/KurentoForks/reconnect-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/KurentoForks/reconnect-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/KurentoForks/reconnect-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/KurentoForks/reconnect-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/KurentoForks/reconnect-core/contents/{+path}","compare_url":"https://api.github.com/repos/KurentoForks/reconnect-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KurentoForks/reconnect-core/merges","archive_url":"https://api.github.com/repos/KurentoForks/reconnect-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KurentoForks/reconnect-core/downloads","issues_url":"https://api.github.com/repos/KurentoForks/reconnect-core/issues{/number}","pulls_url":"https://api.github.com/repos/KurentoForks/reconnect-core/pulls{/number}","milestones_url":"https://api.github.com/repos/KurentoForks/reconnect-core/milestones{/number}","notifications_url":"https://api.github.com/repos/KurentoForks/reconnect-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KurentoForks/reconnect-core/labels{/name}","releases_url":"https://api.github.com/repos/KurentoForks/reconnect-core/releases{/id}","created_at":"2015-05-04T08:52:39Z","updated_at":"2015-05-04T08:52:40Z","pushed_at":"2015-05-19T11:37:56Z","git_url":"git://github.com/KurentoForks/reconnect-core.git","ssh_url":"git@github.com:KurentoForks/reconnect-core.git","clone_url":"https://github.com/KurentoForks/reconnect-core.git","svn_url":"https://github.com/KurentoForks/reconnect-core","homepage":null,"size":298,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juliangruber:master","ref":"master","sha":"db4556d7ae208537e6c23a4312d80e4bf0ef4f10","user":{"login":"juliangruber","id":10247,"avatar_url":"https://avatars.githubusercontent.com/u/10247?v=3","gravatar_id":"","url":"https://api.github.com/users/juliangruber","html_url":"https://github.com/juliangruber","followers_url":"https://api.github.com/users/juliangruber/followers","following_url":"https://api.github.com/users/juliangruber/following{/other_user}","gists_url":"https://api.github.com/users/juliangruber/gists{/gist_id}","starred_url":"https://api.github.com/users/juliangruber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliangruber/subscriptions","organizations_url":"https://api.github.com/users/juliangruber/orgs","repos_url":"https://api.github.com/users/juliangruber/repos","events_url":"https://api.github.com/users/juliangruber/events{/privacy}","received_events_url":"https://api.github.com/users/juliangruber/received_events","type":"User","site_admin":false},"repo":{"id":11726960,"name":"reconnect-core","full_name":"juliangruber/reconnect-core","owner":{"login":"juliangruber","id":10247,"avatar_url":"https://avatars.githubusercontent.com/u/10247?v=3","gravatar_id":"","url":"https://api.github.com/users/juliangruber","html_url":"https://github.com/juliangruber","followers_url":"https://api.github.com/users/juliangruber/followers","following_url":"https://api.github.com/users/juliangruber/following{/other_user}","gists_url":"https://api.github.com/users/juliangruber/gists{/gist_id}","starred_url":"https://api.github.com/users/juliangruber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliangruber/subscriptions","organizations_url":"https://api.github.com/users/juliangruber/orgs","repos_url":"https://api.github.com/users/juliangruber/repos","events_url":"https://api.github.com/users/juliangruber/events{/privacy}","received_events_url":"https://api.github.com/users/juliangruber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/juliangruber/reconnect-core","description":"Generic stream reconnection module.","fork":false,"url":"https://api.github.com/repos/juliangruber/reconnect-core","forks_url":"https://api.github.com/repos/juliangruber/reconnect-core/forks","keys_url":"https://api.github.com/repos/juliangruber/reconnect-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juliangruber/reconnect-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juliangruber/reconnect-core/teams","hooks_url":"https://api.github.com/repos/juliangruber/reconnect-core/hooks","issue_events_url":"https://api.github.com/repos/juliangruber/reconnect-core/issues/events{/number}","events_url":"https://api.github.com/repos/juliangruber/reconnect-core/events","assignees_url":"https://api.github.com/repos/juliangruber/reconnect-core/assignees{/user}","branches_url":"https://api.github.com/repos/juliangruber/reconnect-core/branches{/branch}","tags_url":"https://api.github.com/repos/juliangruber/reconnect-core/tags","blobs_url":"https://api.github.com/repos/juliangruber/reconnect-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juliangruber/reconnect-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juliangruber/reconnect-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/juliangruber/reconnect-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juliangruber/reconnect-core/statuses/{sha}","languages_url":"https://api.github.com/repos/juliangruber/reconnect-core/languages","stargazers_url":"https://api.github.com/repos/juliangruber/reconnect-core/stargazers","contributors_url":"https://api.github.com/repos/juliangruber/reconnect-core/contributors","subscribers_url":"https://api.github.com/repos/juliangruber/reconnect-core/subscribers","subscription_url":"https://api.github.com/repos/juliangruber/reconnect-core/subscription","commits_url":"https://api.github.com/repos/juliangruber/reconnect-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/juliangruber/reconnect-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/juliangruber/reconnect-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/juliangruber/reconnect-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/juliangruber/reconnect-core/contents/{+path}","compare_url":"https://api.github.com/repos/juliangruber/reconnect-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juliangruber/reconnect-core/merges","archive_url":"https://api.github.com/repos/juliangruber/reconnect-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juliangruber/reconnect-core/downloads","issues_url":"https://api.github.com/repos/juliangruber/reconnect-core/issues{/number}","pulls_url":"https://api.github.com/repos/juliangruber/reconnect-core/pulls{/number}","milestones_url":"https://api.github.com/repos/juliangruber/reconnect-core/milestones{/number}","notifications_url":"https://api.github.com/repos/juliangruber/reconnect-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juliangruber/reconnect-core/labels{/name}","releases_url":"https://api.github.com/repos/juliangruber/reconnect-core/releases{/id}","created_at":"2013-07-28T22:45:55Z","updated_at":"2015-05-09T23:02:24Z","pushed_at":"2015-05-19T11:39:51Z","git_url":"git://github.com/juliangruber/reconnect-core.git","ssh_url":"git@github.com:juliangruber/reconnect-core.git","clone_url":"https://github.com/juliangruber/reconnect-core.git","svn_url":"https://github.com/juliangruber/reconnect-core","homepage":null,"size":393,"stargazers_count":61,"watchers_count":61,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":3,"forks":10,"open_issues":3,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juliangruber/reconnect-core/pulls/21"},"html":{"href":"https://github.com/juliangruber/reconnect-core/pull/21"},"issue":{"href":"https://api.github.com/repos/juliangruber/reconnect-core/issues/21"},"comments":{"href":"https://api.github.com/repos/juliangruber/reconnect-core/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/juliangruber/reconnect-core/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/juliangruber/reconnect-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juliangruber/reconnect-core/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/juliangruber/reconnect-core/statuses/921d43e91578abb2fb2613f585c010c1939cf734"}}}}