{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/6227","labels_url":"https://api.github.com/repos/xbmc/xbmc/issues/6227/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/6227/comments","events_url":"https://api.github.com/repos/xbmc/xbmc/issues/6227/events","html_url":"https://github.com/xbmc/xbmc/pull/6227","id":54809559,"number":6227,"title":"[binary addons] move PVR addons to our binary addons buildsystem","user":{"login":"Montellese","id":75864,"avatar_url":"https://avatars.githubusercontent.com/u/75864?v=3","gravatar_id":"","url":"https://api.github.com/users/Montellese","html_url":"https://github.com/Montellese","followers_url":"https://api.github.com/users/Montellese/followers","following_url":"https://api.github.com/users/Montellese/following{/other_user}","gists_url":"https://api.github.com/users/Montellese/gists{/gist_id}","starred_url":"https://api.github.com/users/Montellese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Montellese/subscriptions","organizations_url":"https://api.github.com/users/Montellese/orgs","repos_url":"https://api.github.com/users/Montellese/repos","events_url":"https://api.github.com/users/Montellese/events{/privacy}","received_events_url":"https://api.github.com/users/Montellese/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/xbmc/xbmc/labels/Improvement","name":"Improvement","color":"0b02e1"},{"url":"https://api.github.com/repos/xbmc/xbmc/labels/PVR","name":"PVR","color":"e102d8"},{"url":"https://api.github.com/repos/xbmc/xbmc/labels/RFC","name":"RFC","color":"d7e102"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":365,"created_at":"2015-01-19T20:39:11Z","updated_at":"2015-02-23T09:58:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/6227","html_url":"https://github.com/xbmc/xbmc/pull/6227","diff_url":"https://github.com/xbmc/xbmc/pull/6227.diff","patch_url":"https://github.com/xbmc/xbmc/pull/6227.patch"},"body":"These commits (and all the PVR addons in my github account) are my initial take at moving PVR addons out of the xbmc-pvr-addons repository and into our binary addons buildsystem. A few notes\r\n* I've only really tested compiling as I don't have any PVR setup. I only tested the `pvr.demo` addon which lead to the first commit.\r\n* I've only tested this on WIN32\r\n* all PVR addons in my github account (see https://github.com/Montellese?tab=repositories) are based on the repositores created by and kept in sync by @notspiff so a big thank you to him.\r\n* all PVR addons depend on https://github.com/Montellese/kodi-platform which in turn depends on `tinyxml` which are added as common dependencies to all PVR addon repositories.\r\n\r\nTODOs\r\n- [x] move `kodi-platform` into kodi's depends buildsystem\r\n- [x] test building on all platforms\r\n- [ ] test every PVR addon\r\n- [x] fix detection of OpenGL/OpenGLES2 in `pvr.vdr.vnsi`\r\n- [x] `pvr.dvblink` depends on `libcurl`\r\n- [ ] `pvr.filmon` depends on `libcurl`\r\n- [x] libjansson and cppmyth includes and libs are installed into the wrong directory\r\n- [x] `pvr.iptvsimple` depends on `zlib` which is downloaded from our mirrors and built using the supplied `CMakeLists.txt`. Unfortunately it builds shared and static libs and the builtin `FindZlib.cmake` provided with cmake picks up the shared lib instead of the static lib (at least on WIN32) and I haven't found a way around that yet.\r\n- [x] sync all PVR addons to `xbmc-pvr-addons`\r\n- [x] get the dependency handling right\r\n- [x] move `kodi-platform` to xbmc's github account\r\n- [ ] move all PVR addons to xbmc's github account"},"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/75515270","html_url":"https://github.com/xbmc/xbmc/pull/6227#issuecomment-75515270","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/6227","id":75515270,"user":{"login":"opdenkamp","id":441806,"avatar_url":"https://avatars.githubusercontent.com/u/441806?v=3","gravatar_id":"","url":"https://api.github.com/users/opdenkamp","html_url":"https://github.com/opdenkamp","followers_url":"https://api.github.com/users/opdenkamp/followers","following_url":"https://api.github.com/users/opdenkamp/following{/other_user}","gists_url":"https://api.github.com/users/opdenkamp/gists{/gist_id}","starred_url":"https://api.github.com/users/opdenkamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opdenkamp/subscriptions","organizations_url":"https://api.github.com/users/opdenkamp/orgs","repos_url":"https://api.github.com/users/opdenkamp/repos","events_url":"https://api.github.com/users/opdenkamp/events{/privacy}","received_events_url":"https://api.github.com/users/opdenkamp/received_events","type":"User","site_admin":false},"created_at":"2015-02-23T09:58:59Z","updated_at":"2015-02-23T09:58:59Z","body":"that's what we already do, though we keep the patch in git and have a \nfork of the add-on.\n\nwe don't change any of the code or any of the add-on's workings, we just \nadd stubs as we've always done, and I don't see any issue with double \nstandards in that.\n\nI think it's one of the benefits of having a fork of the code at our \nend: we can keep things working without too much trouble, and have \nchanges tested by users within a day.\n\nOn 23-02-15 10:52, Arne Morten Kvarving wrote:\n> if you absolutely insist on keeping *development versions* working \n> after an\n> API bump (i don't know of a single other project which does, though they\n> generally strive to avoid API breakage) then do like any other distributor\n> of software; you *patch* what you distribute! drop a patch file into the\n> addon definition, done. this clearly marks the changes as something *you*\n> did to the code.\n>\n> no other distro require vcs access - the e.g. debian repos would fall over\n> and die if that was the case.\n>\n> consider all the shit you guys went through to avoid having modified\n> versions distributed in vanilla's name. why do you insist on doing the \n> very\n> same thing you despise to your third parties ? having double standards is\n> not exactly flattering is it. 'it is okay as long as we are the violators\n> and not the violated'.\n>\n> On Mon, Feb 23, 2015 at 10:42 AM, Lars Op den Kamp \n> <notifications@github.com\n> > wrote:\n>\n> > don't agree. we don't change anything that requires the add-on to get\n> > new code, except for stubs. if all it takes to keep an add-on working is\n> > to add some stubs and bump versions, then we should do this and not\n> > annoy users by breaking add-ons just because of a couple of lines\n> > missing and a maintainer that went away. I've done this numerous times\n> > in the last couple of years, and it's really not much work at all, c+p\n> > for most things. Updating the changelogs of add-ons is actually more\n> > work than keeping the add-on working.\n> >\n> >\n> > On 23-02-15 10:33, Jean-Luc Barrière wrote:\n> > > yes but, this is work of addon maintainer to fix changes for a new\n> > > API. If no one do it that's means addon is no longer supported and\n> > > should be removed or should change ownership if team want to keep it.\n> > > JLB\n> > >\n> > > -----Original Message-----\n> > > From: Lars Op den Kamp <notifications@github.com>\n> > > Date: Mon, 23 Feb 2015 01:05:45\n> > > To: xbmc/xbmc<xbmc@noreply.github.com>\n> > > Reply-To: xbmc/xbmc <reply@reply.github.com>\n> > > Cc: Jean-Luc Barrière<jlbarriere68@gmail.com>\n> > > Subject: Re: [xbmc] [binary addons] move PVR addons to our binary \n> addons\n> > > buildsystem (#6227)\n> > >\n> > > bit late to this week end's party with 50+ messages, but re API\n> > > changes: we've always done them for the add-ons in our repos, and we\n> > > should keep doing so. API changes generally just add new things, e.g.\n> > > a new method or a new field, and even though it's not the most joyful\n> > > work, it's very useful, as you can do the same thing within minutes\n> > > (add some stubs and bump versions) that would take a lot longer\n> > > otherwise, and all add-ons will keep functioning. add-on authors just\n> > > rebase their work onto the latest that we have to include the API\n> > > changes at their end, and then everybody is happy ;-)\n> > >\n> > > ---\n> > > Reply to this email directly or view it on GitHub:\n> > > https://github.com/xbmc/xbmc/pull/6227#issuecomment-75508774\n> > >\n> > > —\n> > > Reply to this email directly or view it on GitHub\n> > > <https://github.com/xbmc/xbmc/pull/6227#issuecomment-75511913>.\n> >\n> > >\n> >\n> > —\n> > Reply to this email directly or view it on GitHub\n> > <https://github.com/xbmc/xbmc/pull/6227#issuecomment-75512986>.\n> >\n>\n> —\n> Reply to this email directly or view it on GitHub \n> <https://github.com/xbmc/xbmc/pull/6227#issuecomment-75514360>.\n>\n\n"}}