{"action":"created","comment":{"url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/comments/45568438","id":45568438,"diff_hunk":"@@ -1198,17 +1198,17 @@ steam.start() -- spawns the effect\n \r\n \r\n //////////////////////////////////\r\n-//////SPARKELS FIREWORKS\r\n+//////SPARKLE FIREWORKS\r\n /////////////////////////////////\r\n ////////////////////////////\r\n-/obj/effects/sparkels\r\n-\tname = \"sparkel\"\r","path":"code/game/objects/effects/effect_system.dm","position":198,"original_position":198,"commit_id":"6bbea142b76b62c5e4a6186194f4c6a92ffc926b","original_commit_id":"85d651b7814745500a8813f5a63942a158bb9634","user":{"login":"Tastyfish","id":1185434,"avatar_url":"https://avatars.githubusercontent.com/u/1185434?v=3","gravatar_id":"","url":"https://api.github.com/users/Tastyfish","html_url":"https://github.com/Tastyfish","followers_url":"https://api.github.com/users/Tastyfish/followers","following_url":"https://api.github.com/users/Tastyfish/following{/other_user}","gists_url":"https://api.github.com/users/Tastyfish/gists{/gist_id}","starred_url":"https://api.github.com/users/Tastyfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tastyfish/subscriptions","organizations_url":"https://api.github.com/users/Tastyfish/orgs","repos_url":"https://api.github.com/users/Tastyfish/repos","events_url":"https://api.github.com/users/Tastyfish/events{/privacy}","received_events_url":"https://api.github.com/users/Tastyfish/received_events","type":"User","site_admin":false},"body":"Yes, all of those things. (It's an effect for one of the fireworks, if you're curious.)","created_at":"2015-11-23T01:11:22Z","updated_at":"2015-11-23T01:11:22Z","html_url":"https://github.com/ParadiseSS13/Paradise/pull/2637#discussion_r45568438","pull_request_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/2637","_links":{"self":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/comments/45568438"},"html":{"href":"https://github.com/ParadiseSS13/Paradise/pull/2637#discussion_r45568438"},"pull_request":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/2637"}}},"pull_request":{"url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/2637","id":51480645,"html_url":"https://github.com/ParadiseSS13/Paradise/pull/2637","diff_url":"https://github.com/ParadiseSS13/Paradise/pull/2637.diff","patch_url":"https://github.com/ParadiseSS13/Paradise/pull/2637.patch","issue_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/2637","number":2637,"state":"open","locked":false,"title":"Cleaned up /datum/effect/system paths & some bad path defines","user":{"login":"Tastyfish","id":1185434,"avatar_url":"https://avatars.githubusercontent.com/u/1185434?v=3","gravatar_id":"","url":"https://api.github.com/users/Tastyfish","html_url":"https://github.com/Tastyfish","followers_url":"https://api.github.com/users/Tastyfish/followers","following_url":"https://api.github.com/users/Tastyfish/following{/other_user}","gists_url":"https://api.github.com/users/Tastyfish/gists{/gist_id}","starred_url":"https://api.github.com/users/Tastyfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tastyfish/subscriptions","organizations_url":"https://api.github.com/users/Tastyfish/orgs","repos_url":"https://api.github.com/users/Tastyfish/repos","events_url":"https://api.github.com/users/Tastyfish/events{/privacy}","received_events_url":"https://api.github.com/users/Tastyfish/received_events","type":"User","site_admin":false},"body":"This seems like a lot of changes for the sake of refactoring, but the effect datums were a complete mess with the classes spread across.\r\n\r\n#### The horrible effect system paths\r\n\r\n##### Before\r\n1. `/datum/effect/system`\r\n * Had no code or vars itself.\r\n * Only contained a couple explosion effects, both of which reinvented the wheel.\r\n* `/datum/effect/effect/system`\r\n * This contained all other effects, despite the horrible path. `/datum/effect` is an empty superclass and `/datum/effect/effect` contains one proc, and the only subclass was `/datum/effect/effect/system`.\r\n* `/datum/effects/system`.\r\n * Had no code or vars itself.\r\n * Contained a `sparkel` (sic) effect, which I fixed the spelling of, which also reinvented the wheel.\r\n\r\n##### After\r\nAll of them are in `/datum/effect/system` and redundant vars removed. In a couple cases, redundant proc defintions were removed when identical.\r\n\r\n#### Couple of bad parent classes\r\n* There were also a couple of objs in `/obj/effects` instead of `/obj/effect`.\r\n\r\n#### Examine Tab Descriptions\r\n* There were 8 instances of the examine module defining descriptions for objects that didn't exist (The paths were wrong). This created 8 phantom objs that had no functionality polluting the object tree.","created_at":"2015-11-23T00:58:14Z","updated_at":"2015-11-23T01:11:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"396a90515e6dc64487055e7abd6216444f94ad8f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/2637/commits","review_comments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/2637/comments","review_comment_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/2637/comments","statuses_url":"https://api.github.com/repos/ParadiseSS13/Paradise/statuses/6bbea142b76b62c5e4a6186194f4c6a92ffc926b","head":{"label":"Tastyfish:path_cleanups","ref":"path_cleanups","sha":"6bbea142b76b62c5e4a6186194f4c6a92ffc926b","user":{"login":"Tastyfish","id":1185434,"avatar_url":"https://avatars.githubusercontent.com/u/1185434?v=3","gravatar_id":"","url":"https://api.github.com/users/Tastyfish","html_url":"https://github.com/Tastyfish","followers_url":"https://api.github.com/users/Tastyfish/followers","following_url":"https://api.github.com/users/Tastyfish/following{/other_user}","gists_url":"https://api.github.com/users/Tastyfish/gists{/gist_id}","starred_url":"https://api.github.com/users/Tastyfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tastyfish/subscriptions","organizations_url":"https://api.github.com/users/Tastyfish/orgs","repos_url":"https://api.github.com/users/Tastyfish/repos","events_url":"https://api.github.com/users/Tastyfish/events{/privacy}","received_events_url":"https://api.github.com/users/Tastyfish/received_events","type":"User","site_admin":false},"repo":{"id":44722352,"name":"Paradise","full_name":"Tastyfish/Paradise","owner":{"login":"Tastyfish","id":1185434,"avatar_url":"https://avatars.githubusercontent.com/u/1185434?v=3","gravatar_id":"","url":"https://api.github.com/users/Tastyfish","html_url":"https://github.com/Tastyfish","followers_url":"https://api.github.com/users/Tastyfish/followers","following_url":"https://api.github.com/users/Tastyfish/following{/other_user}","gists_url":"https://api.github.com/users/Tastyfish/gists{/gist_id}","starred_url":"https://api.github.com/users/Tastyfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tastyfish/subscriptions","organizations_url":"https://api.github.com/users/Tastyfish/orgs","repos_url":"https://api.github.com/users/Tastyfish/repos","events_url":"https://api.github.com/users/Tastyfish/events{/privacy}","received_events_url":"https://api.github.com/users/Tastyfish/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Tastyfish/Paradise","description":"Paradise Station's GitHub repository","fork":true,"url":"https://api.github.com/repos/Tastyfish/Paradise","forks_url":"https://api.github.com/repos/Tastyfish/Paradise/forks","keys_url":"https://api.github.com/repos/Tastyfish/Paradise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tastyfish/Paradise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tastyfish/Paradise/teams","hooks_url":"https://api.github.com/repos/Tastyfish/Paradise/hooks","issue_events_url":"https://api.github.com/repos/Tastyfish/Paradise/issues/events{/number}","events_url":"https://api.github.com/repos/Tastyfish/Paradise/events","assignees_url":"https://api.github.com/repos/Tastyfish/Paradise/assignees{/user}","branches_url":"https://api.github.com/repos/Tastyfish/Paradise/branches{/branch}","tags_url":"https://api.github.com/repos/Tastyfish/Paradise/tags","blobs_url":"https://api.github.com/repos/Tastyfish/Paradise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tastyfish/Paradise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tastyfish/Paradise/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tastyfish/Paradise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tastyfish/Paradise/statuses/{sha}","languages_url":"https://api.github.com/repos/Tastyfish/Paradise/languages","stargazers_url":"https://api.github.com/repos/Tastyfish/Paradise/stargazers","contributors_url":"https://api.github.com/repos/Tastyfish/Paradise/contributors","subscribers_url":"https://api.github.com/repos/Tastyfish/Paradise/subscribers","subscription_url":"https://api.github.com/repos/Tastyfish/Paradise/subscription","commits_url":"https://api.github.com/repos/Tastyfish/Paradise/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tastyfish/Paradise/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tastyfish/Paradise/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tastyfish/Paradise/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tastyfish/Paradise/contents/{+path}","compare_url":"https://api.github.com/repos/Tastyfish/Paradise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tastyfish/Paradise/merges","archive_url":"https://api.github.com/repos/Tastyfish/Paradise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tastyfish/Paradise/downloads","issues_url":"https://api.github.com/repos/Tastyfish/Paradise/issues{/number}","pulls_url":"https://api.github.com/repos/Tastyfish/Paradise/pulls{/number}","milestones_url":"https://api.github.com/repos/Tastyfish/Paradise/milestones{/number}","notifications_url":"https://api.github.com/repos/Tastyfish/Paradise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tastyfish/Paradise/labels{/name}","releases_url":"https://api.github.com/repos/Tastyfish/Paradise/releases{/id}","created_at":"2015-10-22T04:36:31Z","updated_at":"2015-10-22T04:37:39Z","pushed_at":"2015-11-23T01:08:41Z","git_url":"git://github.com/Tastyfish/Paradise.git","ssh_url":"git@github.com:Tastyfish/Paradise.git","clone_url":"https://github.com/Tastyfish/Paradise.git","svn_url":"https://github.com/Tastyfish/Paradise","homepage":"http://nanotrasen.se/phpBB3/index.php","size":807657,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ParadiseSS13:master","ref":"master","sha":"f44a398719cd0c654f064d85499e685f39b2da13","user":{"login":"ParadiseSS13","id":9994901,"avatar_url":"https://avatars.githubusercontent.com/u/9994901?v=3","gravatar_id":"","url":"https://api.github.com/users/ParadiseSS13","html_url":"https://github.com/ParadiseSS13","followers_url":"https://api.github.com/users/ParadiseSS13/followers","following_url":"https://api.github.com/users/ParadiseSS13/following{/other_user}","gists_url":"https://api.github.com/users/ParadiseSS13/gists{/gist_id}","starred_url":"https://api.github.com/users/ParadiseSS13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParadiseSS13/subscriptions","organizations_url":"https://api.github.com/users/ParadiseSS13/orgs","repos_url":"https://api.github.com/users/ParadiseSS13/repos","events_url":"https://api.github.com/users/ParadiseSS13/events{/privacy}","received_events_url":"https://api.github.com/users/ParadiseSS13/received_events","type":"User","site_admin":false},"repo":{"id":27286452,"name":"Paradise","full_name":"ParadiseSS13/Paradise","owner":{"login":"ParadiseSS13","id":9994901,"avatar_url":"https://avatars.githubusercontent.com/u/9994901?v=3","gravatar_id":"","url":"https://api.github.com/users/ParadiseSS13","html_url":"https://github.com/ParadiseSS13","followers_url":"https://api.github.com/users/ParadiseSS13/followers","following_url":"https://api.github.com/users/ParadiseSS13/following{/other_user}","gists_url":"https://api.github.com/users/ParadiseSS13/gists{/gist_id}","starred_url":"https://api.github.com/users/ParadiseSS13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParadiseSS13/subscriptions","organizations_url":"https://api.github.com/users/ParadiseSS13/orgs","repos_url":"https://api.github.com/users/ParadiseSS13/repos","events_url":"https://api.github.com/users/ParadiseSS13/events{/privacy}","received_events_url":"https://api.github.com/users/ParadiseSS13/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ParadiseSS13/Paradise","description":"Paradise Station's GitHub repository","fork":false,"url":"https://api.github.com/repos/ParadiseSS13/Paradise","forks_url":"https://api.github.com/repos/ParadiseSS13/Paradise/forks","keys_url":"https://api.github.com/repos/ParadiseSS13/Paradise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ParadiseSS13/Paradise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ParadiseSS13/Paradise/teams","hooks_url":"https://api.github.com/repos/ParadiseSS13/Paradise/hooks","issue_events_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/events{/number}","events_url":"https://api.github.com/repos/ParadiseSS13/Paradise/events","assignees_url":"https://api.github.com/repos/ParadiseSS13/Paradise/assignees{/user}","branches_url":"https://api.github.com/repos/ParadiseSS13/Paradise/branches{/branch}","tags_url":"https://api.github.com/repos/ParadiseSS13/Paradise/tags","blobs_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/refs{/sha}","trees_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ParadiseSS13/Paradise/statuses/{sha}","languages_url":"https://api.github.com/repos/ParadiseSS13/Paradise/languages","stargazers_url":"https://api.github.com/repos/ParadiseSS13/Paradise/stargazers","contributors_url":"https://api.github.com/repos/ParadiseSS13/Paradise/contributors","subscribers_url":"https://api.github.com/repos/ParadiseSS13/Paradise/subscribers","subscription_url":"https://api.github.com/repos/ParadiseSS13/Paradise/subscription","commits_url":"https://api.github.com/repos/ParadiseSS13/Paradise/commits{/sha}","git_commits_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/commits{/sha}","comments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/comments{/number}","issue_comment_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/comments{/number}","contents_url":"https://api.github.com/repos/ParadiseSS13/Paradise/contents/{+path}","compare_url":"https://api.github.com/repos/ParadiseSS13/Paradise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ParadiseSS13/Paradise/merges","archive_url":"https://api.github.com/repos/ParadiseSS13/Paradise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ParadiseSS13/Paradise/downloads","issues_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues{/number}","pulls_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls{/number}","milestones_url":"https://api.github.com/repos/ParadiseSS13/Paradise/milestones{/number}","notifications_url":"https://api.github.com/repos/ParadiseSS13/Paradise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ParadiseSS13/Paradise/labels{/name}","releases_url":"https://api.github.com/repos/ParadiseSS13/Paradise/releases{/id}","created_at":"2014-11-29T00:16:54Z","updated_at":"2015-11-21T15:28:16Z","pushed_at":"2015-11-23T01:08:42Z","git_url":"git://github.com/ParadiseSS13/Paradise.git","ssh_url":"git@github.com:ParadiseSS13/Paradise.git","clone_url":"https://github.com/ParadiseSS13/Paradise.git","svn_url":"https://github.com/ParadiseSS13/Paradise","homepage":"http://nanotrasen.se/phpBB3/index.php","size":823381,"stargazers_count":39,"watchers_count":39,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":113,"mirror_url":null,"open_issues_count":156,"forks":113,"open_issues":156,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/2637"},"html":{"href":"https://github.com/ParadiseSS13/Paradise/pull/2637"},"issue":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/2637"},"comments":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/2637/comments"},"review_comments":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/2637/comments"},"review_comment":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/2637/commits"},"statuses":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/statuses/6bbea142b76b62c5e4a6186194f4c6a92ffc926b"}}}}