{"action":"closed","number":49,"pull_request":{"url":"https://api.github.com/repos/mikedao/the_pivot/pulls/49","id":29066720,"html_url":"https://github.com/mikedao/the_pivot/pull/49","diff_url":"https://github.com/mikedao/the_pivot/pull/49.diff","patch_url":"https://github.com/mikedao/the_pivot/pull/49.patch","issue_url":"https://api.github.com/repos/mikedao/the_pivot/issues/49","number":49,"state":"closed","locked":false,"title":"Added simplecov closes #2","user":{"login":"mikedao","id":3011748,"avatar_url":"https://avatars.githubusercontent.com/u/3011748?v=3","gravatar_id":"","url":"https://api.github.com/users/mikedao","html_url":"https://github.com/mikedao","followers_url":"https://api.github.com/users/mikedao/followers","following_url":"https://api.github.com/users/mikedao/following{/other_user}","gists_url":"https://api.github.com/users/mikedao/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedao/subscriptions","organizations_url":"https://api.github.com/users/mikedao/orgs","repos_url":"https://api.github.com/users/mikedao/repos","events_url":"https://api.github.com/users/mikedao/events{/privacy}","received_events_url":"https://api.github.com/users/mikedao/received_events","type":"User","site_admin":false},"body":"Made appropriate changes to add Simplecov reporting to our application. Also made some improvements to code I saw while I was working on it, detailed below.\r\n\r\n* Added coverage folder to local .gitignore so we would not sync the SimpleCov reports\r\n* Added simplecov to Gemfile, also found that Gemfile had a second gem 'pry' - removed it.\r\n* Gemfile.lock was updated because I ran bundle install to ensure it was working.\r\n\r\nAll tests pass, however, I encountered errors reseeding the database. We should leave this as is and fix when seed.rb file is addressed in #41 \r\n\r\n","created_at":"2015-02-11T03:51:11Z","updated_at":"2015-02-11T05:09:10Z","closed_at":"2015-02-11T05:09:10Z","merged_at":"2015-02-11T05:09:10Z","merge_commit_sha":"fbb393822e9be259050bcbbf3c1f531606046b62","assignee":{"login":"mikedao","id":3011748,"avatar_url":"https://avatars.githubusercontent.com/u/3011748?v=3","gravatar_id":"","url":"https://api.github.com/users/mikedao","html_url":"https://github.com/mikedao","followers_url":"https://api.github.com/users/mikedao/followers","following_url":"https://api.github.com/users/mikedao/following{/other_user}","gists_url":"https://api.github.com/users/mikedao/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedao/subscriptions","organizations_url":"https://api.github.com/users/mikedao/orgs","repos_url":"https://api.github.com/users/mikedao/repos","events_url":"https://api.github.com/users/mikedao/events{/privacy}","received_events_url":"https://api.github.com/users/mikedao/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/mikedao/the_pivot/pulls/49/commits","review_comments_url":"https://api.github.com/repos/mikedao/the_pivot/pulls/49/comments","review_comment_url":"https://api.github.com/repos/mikedao/the_pivot/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mikedao/the_pivot/issues/49/comments","statuses_url":"https://api.github.com/repos/mikedao/the_pivot/statuses/060bb7f9d8d28f84bed066ad77b8fe2d74f793cd","head":{"label":"mikedao:simplecov","ref":"simplecov","sha":"060bb7f9d8d28f84bed066ad77b8fe2d74f793cd","user":{"login":"mikedao","id":3011748,"avatar_url":"https://avatars.githubusercontent.com/u/3011748?v=3","gravatar_id":"","url":"https://api.github.com/users/mikedao","html_url":"https://github.com/mikedao","followers_url":"https://api.github.com/users/mikedao/followers","following_url":"https://api.github.com/users/mikedao/following{/other_user}","gists_url":"https://api.github.com/users/mikedao/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedao/subscriptions","organizations_url":"https://api.github.com/users/mikedao/orgs","repos_url":"https://api.github.com/users/mikedao/repos","events_url":"https://api.github.com/users/mikedao/events{/privacy}","received_events_url":"https://api.github.com/users/mikedao/received_events","type":"User","site_admin":false},"repo":{"id":30558977,"name":"the_pivot","full_name":"mikedao/the_pivot","owner":{"login":"mikedao","id":3011748,"avatar_url":"https://avatars.githubusercontent.com/u/3011748?v=3","gravatar_id":"","url":"https://api.github.com/users/mikedao","html_url":"https://github.com/mikedao","followers_url":"https://api.github.com/users/mikedao/followers","following_url":"https://api.github.com/users/mikedao/following{/other_user}","gists_url":"https://api.github.com/users/mikedao/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedao/subscriptions","organizations_url":"https://api.github.com/users/mikedao/orgs","repos_url":"https://api.github.com/users/mikedao/repos","events_url":"https://api.github.com/users/mikedao/events{/privacy}","received_events_url":"https://api.github.com/users/mikedao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikedao/the_pivot","description":"","fork":false,"url":"https://api.github.com/repos/mikedao/the_pivot","forks_url":"https://api.github.com/repos/mikedao/the_pivot/forks","keys_url":"https://api.github.com/repos/mikedao/the_pivot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikedao/the_pivot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikedao/the_pivot/teams","hooks_url":"https://api.github.com/repos/mikedao/the_pivot/hooks","issue_events_url":"https://api.github.com/repos/mikedao/the_pivot/issues/events{/number}","events_url":"https://api.github.com/repos/mikedao/the_pivot/events","assignees_url":"https://api.github.com/repos/mikedao/the_pivot/assignees{/user}","branches_url":"https://api.github.com/repos/mikedao/the_pivot/branches{/branch}","tags_url":"https://api.github.com/repos/mikedao/the_pivot/tags","blobs_url":"https://api.github.com/repos/mikedao/the_pivot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikedao/the_pivot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikedao/the_pivot/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikedao/the_pivot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikedao/the_pivot/statuses/{sha}","languages_url":"https://api.github.com/repos/mikedao/the_pivot/languages","stargazers_url":"https://api.github.com/repos/mikedao/the_pivot/stargazers","contributors_url":"https://api.github.com/repos/mikedao/the_pivot/contributors","subscribers_url":"https://api.github.com/repos/mikedao/the_pivot/subscribers","subscription_url":"https://api.github.com/repos/mikedao/the_pivot/subscription","commits_url":"https://api.github.com/repos/mikedao/the_pivot/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikedao/the_pivot/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikedao/the_pivot/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikedao/the_pivot/issues/comments/{number}","contents_url":"https://api.github.com/repos/mikedao/the_pivot/contents/{+path}","compare_url":"https://api.github.com/repos/mikedao/the_pivot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikedao/the_pivot/merges","archive_url":"https://api.github.com/repos/mikedao/the_pivot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikedao/the_pivot/downloads","issues_url":"https://api.github.com/repos/mikedao/the_pivot/issues{/number}","pulls_url":"https://api.github.com/repos/mikedao/the_pivot/pulls{/number}","milestones_url":"https://api.github.com/repos/mikedao/the_pivot/milestones{/number}","notifications_url":"https://api.github.com/repos/mikedao/the_pivot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikedao/the_pivot/labels{/name}","releases_url":"https://api.github.com/repos/mikedao/the_pivot/releases{/id}","created_at":"2015-02-09T21:18:30Z","updated_at":"2015-02-10T01:00:46Z","pushed_at":"2015-02-11T05:09:10Z","git_url":"git://github.com/mikedao/the_pivot.git","ssh_url":"git@github.com:mikedao/the_pivot.git","clone_url":"https://github.com/mikedao/the_pivot.git","svn_url":"https://github.com/mikedao/the_pivot","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":45,"forks":0,"open_issues":45,"watchers":0,"default_branch":"master"}},"base":{"label":"mikedao:master","ref":"master","sha":"8d3c4f8cee9cb7c321cecda87fdc0a4c9851f8c0","user":{"login":"mikedao","id":3011748,"avatar_url":"https://avatars.githubusercontent.com/u/3011748?v=3","gravatar_id":"","url":"https://api.github.com/users/mikedao","html_url":"https://github.com/mikedao","followers_url":"https://api.github.com/users/mikedao/followers","following_url":"https://api.github.com/users/mikedao/following{/other_user}","gists_url":"https://api.github.com/users/mikedao/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedao/subscriptions","organizations_url":"https://api.github.com/users/mikedao/orgs","repos_url":"https://api.github.com/users/mikedao/repos","events_url":"https://api.github.com/users/mikedao/events{/privacy}","received_events_url":"https://api.github.com/users/mikedao/received_events","type":"User","site_admin":false},"repo":{"id":30558977,"name":"the_pivot","full_name":"mikedao/the_pivot","owner":{"login":"mikedao","id":3011748,"avatar_url":"https://avatars.githubusercontent.com/u/3011748?v=3","gravatar_id":"","url":"https://api.github.com/users/mikedao","html_url":"https://github.com/mikedao","followers_url":"https://api.github.com/users/mikedao/followers","following_url":"https://api.github.com/users/mikedao/following{/other_user}","gists_url":"https://api.github.com/users/mikedao/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedao/subscriptions","organizations_url":"https://api.github.com/users/mikedao/orgs","repos_url":"https://api.github.com/users/mikedao/repos","events_url":"https://api.github.com/users/mikedao/events{/privacy}","received_events_url":"https://api.github.com/users/mikedao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikedao/the_pivot","description":"","fork":false,"url":"https://api.github.com/repos/mikedao/the_pivot","forks_url":"https://api.github.com/repos/mikedao/the_pivot/forks","keys_url":"https://api.github.com/repos/mikedao/the_pivot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikedao/the_pivot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikedao/the_pivot/teams","hooks_url":"https://api.github.com/repos/mikedao/the_pivot/hooks","issue_events_url":"https://api.github.com/repos/mikedao/the_pivot/issues/events{/number}","events_url":"https://api.github.com/repos/mikedao/the_pivot/events","assignees_url":"https://api.github.com/repos/mikedao/the_pivot/assignees{/user}","branches_url":"https://api.github.com/repos/mikedao/the_pivot/branches{/branch}","tags_url":"https://api.github.com/repos/mikedao/the_pivot/tags","blobs_url":"https://api.github.com/repos/mikedao/the_pivot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikedao/the_pivot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikedao/the_pivot/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikedao/the_pivot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikedao/the_pivot/statuses/{sha}","languages_url":"https://api.github.com/repos/mikedao/the_pivot/languages","stargazers_url":"https://api.github.com/repos/mikedao/the_pivot/stargazers","contributors_url":"https://api.github.com/repos/mikedao/the_pivot/contributors","subscribers_url":"https://api.github.com/repos/mikedao/the_pivot/subscribers","subscription_url":"https://api.github.com/repos/mikedao/the_pivot/subscription","commits_url":"https://api.github.com/repos/mikedao/the_pivot/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikedao/the_pivot/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikedao/the_pivot/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikedao/the_pivot/issues/comments/{number}","contents_url":"https://api.github.com/repos/mikedao/the_pivot/contents/{+path}","compare_url":"https://api.github.com/repos/mikedao/the_pivot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikedao/the_pivot/merges","archive_url":"https://api.github.com/repos/mikedao/the_pivot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikedao/the_pivot/downloads","issues_url":"https://api.github.com/repos/mikedao/the_pivot/issues{/number}","pulls_url":"https://api.github.com/repos/mikedao/the_pivot/pulls{/number}","milestones_url":"https://api.github.com/repos/mikedao/the_pivot/milestones{/number}","notifications_url":"https://api.github.com/repos/mikedao/the_pivot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikedao/the_pivot/labels{/name}","releases_url":"https://api.github.com/repos/mikedao/the_pivot/releases{/id}","created_at":"2015-02-09T21:18:30Z","updated_at":"2015-02-10T01:00:46Z","pushed_at":"2015-02-11T05:09:10Z","git_url":"git://github.com/mikedao/the_pivot.git","ssh_url":"git@github.com:mikedao/the_pivot.git","clone_url":"https://github.com/mikedao/the_pivot.git","svn_url":"https://github.com/mikedao/the_pivot","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":45,"forks":0,"open_issues":45,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mikedao/the_pivot/pulls/49"},"html":{"href":"https://github.com/mikedao/the_pivot/pull/49"},"issue":{"href":"https://api.github.com/repos/mikedao/the_pivot/issues/49"},"comments":{"href":"https://api.github.com/repos/mikedao/the_pivot/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/mikedao/the_pivot/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/mikedao/the_pivot/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mikedao/the_pivot/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/mikedao/the_pivot/statuses/060bb7f9d8d28f84bed066ad77b8fe2d74f793cd"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"EmilyMB","id":8007635,"avatar_url":"https://avatars.githubusercontent.com/u/8007635?v=3","gravatar_id":"","url":"https://api.github.com/users/EmilyMB","html_url":"https://github.com/EmilyMB","followers_url":"https://api.github.com/users/EmilyMB/followers","following_url":"https://api.github.com/users/EmilyMB/following{/other_user}","gists_url":"https://api.github.com/users/EmilyMB/gists{/gist_id}","starred_url":"https://api.github.com/users/EmilyMB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EmilyMB/subscriptions","organizations_url":"https://api.github.com/users/EmilyMB/orgs","repos_url":"https://api.github.com/users/EmilyMB/repos","events_url":"https://api.github.com/users/EmilyMB/events{/privacy}","received_events_url":"https://api.github.com/users/EmilyMB/received_events","type":"User","site_admin":false},"comments":1,"review_comments":14,"commits":2,"additions":67,"deletions":48,"changed_files":8}}