{"action":"opened","number":38,"pull_request":{"url":"https://api.github.com/repos/18F/domain-scan/pulls/38","id":42455159,"html_url":"https://github.com/18F/domain-scan/pull/38","diff_url":"https://github.com/18F/domain-scan/pull/38.diff","patch_url":"https://github.com/18F/domain-scan/pull/38.patch","issue_url":"https://api.github.com/repos/18F/domain-scan/issues/38","number":38,"state":"open","locked":false,"title":"JSON comment detector for HSTS preload list parser was too broad","user":{"login":"konklone","id":4592,"avatar_url":"https://avatars.githubusercontent.com/u/4592?v=3","gravatar_id":"","url":"https://api.github.com/users/konklone","html_url":"https://github.com/konklone","followers_url":"https://api.github.com/users/konklone/followers","following_url":"https://api.github.com/users/konklone/following{/other_user}","gists_url":"https://api.github.com/users/konklone/gists{/gist_id}","starred_url":"https://api.github.com/users/konklone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/konklone/subscriptions","organizations_url":"https://api.github.com/users/konklone/orgs","repos_url":"https://api.github.com/users/konklone/repos","events_url":"https://api.github.com/users/konklone/events{/privacy}","received_events_url":"https://api.github.com/users/konklone/received_events","type":"User","site_admin":false},"body":"In a [recent HSTS preload list update](https://chromium.googlesource.com/chromium/src/+/db949c345a8c561f45a2351daa06dc9c85671e88), Google added a `report_uri` field for its pins that contained a URL:\r\n\r\n```json\r\n\"report_uri\": \"http://clients3.google.com/cert_upload_json\"\r\n```\r\n\r\nThe `//` in the URL broke the regex that stripped the Chrome preload list of comments before using Python's JSON parser. I've updated the regex to require the `//` to have occurred at the start of the line (allowing optional prefixed whitespace), which seems to have fixed the issue.\r\n\r\ncc @garrettr ","created_at":"2015-08-14T13:24:27Z","updated_at":"2015-08-14T13:24:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/18F/domain-scan/pulls/38/commits","review_comments_url":"https://api.github.com/repos/18F/domain-scan/pulls/38/comments","review_comment_url":"https://api.github.com/repos/18F/domain-scan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/18F/domain-scan/issues/38/comments","statuses_url":"https://api.github.com/repos/18F/domain-scan/statuses/28b8f3c6813f0cc38e4bd16a01c6b001973b1573","head":{"label":"18F:fix-preload-comments","ref":"fix-preload-comments","sha":"28b8f3c6813f0cc38e4bd16a01c6b001973b1573","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":27473797,"name":"domain-scan","full_name":"18F/domain-scan","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/domain-scan","description":"Scan domains for various web things, like HTTP/HTTPS configuration.","fork":false,"url":"https://api.github.com/repos/18F/domain-scan","forks_url":"https://api.github.com/repos/18F/domain-scan/forks","keys_url":"https://api.github.com/repos/18F/domain-scan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/domain-scan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/domain-scan/teams","hooks_url":"https://api.github.com/repos/18F/domain-scan/hooks","issue_events_url":"https://api.github.com/repos/18F/domain-scan/issues/events{/number}","events_url":"https://api.github.com/repos/18F/domain-scan/events","assignees_url":"https://api.github.com/repos/18F/domain-scan/assignees{/user}","branches_url":"https://api.github.com/repos/18F/domain-scan/branches{/branch}","tags_url":"https://api.github.com/repos/18F/domain-scan/tags","blobs_url":"https://api.github.com/repos/18F/domain-scan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/domain-scan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/domain-scan/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/domain-scan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/domain-scan/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/domain-scan/languages","stargazers_url":"https://api.github.com/repos/18F/domain-scan/stargazers","contributors_url":"https://api.github.com/repos/18F/domain-scan/contributors","subscribers_url":"https://api.github.com/repos/18F/domain-scan/subscribers","subscription_url":"https://api.github.com/repos/18F/domain-scan/subscription","commits_url":"https://api.github.com/repos/18F/domain-scan/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/domain-scan/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/domain-scan/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/domain-scan/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/domain-scan/contents/{+path}","compare_url":"https://api.github.com/repos/18F/domain-scan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/domain-scan/merges","archive_url":"https://api.github.com/repos/18F/domain-scan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/domain-scan/downloads","issues_url":"https://api.github.com/repos/18F/domain-scan/issues{/number}","pulls_url":"https://api.github.com/repos/18F/domain-scan/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/domain-scan/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/domain-scan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/domain-scan/labels{/name}","releases_url":"https://api.github.com/repos/18F/domain-scan/releases{/id}","created_at":"2014-12-03T06:52:17Z","updated_at":"2015-06-27T19:38:52Z","pushed_at":"2015-08-14T13:24:27Z","git_url":"git://github.com/18F/domain-scan.git","ssh_url":"git@github.com:18F/domain-scan.git","clone_url":"https://github.com/18F/domain-scan.git","svn_url":"https://github.com/18F/domain-scan","homepage":"","size":474,"stargazers_count":21,"watchers_count":21,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":6,"forks":22,"open_issues":6,"watchers":21,"default_branch":"master"}},"base":{"label":"18F:master","ref":"master","sha":"5de1a4755e36f07a8a367eaa44dbad63411de062","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":27473797,"name":"domain-scan","full_name":"18F/domain-scan","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/domain-scan","description":"Scan domains for various web things, like HTTP/HTTPS configuration.","fork":false,"url":"https://api.github.com/repos/18F/domain-scan","forks_url":"https://api.github.com/repos/18F/domain-scan/forks","keys_url":"https://api.github.com/repos/18F/domain-scan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/domain-scan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/domain-scan/teams","hooks_url":"https://api.github.com/repos/18F/domain-scan/hooks","issue_events_url":"https://api.github.com/repos/18F/domain-scan/issues/events{/number}","events_url":"https://api.github.com/repos/18F/domain-scan/events","assignees_url":"https://api.github.com/repos/18F/domain-scan/assignees{/user}","branches_url":"https://api.github.com/repos/18F/domain-scan/branches{/branch}","tags_url":"https://api.github.com/repos/18F/domain-scan/tags","blobs_url":"https://api.github.com/repos/18F/domain-scan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/domain-scan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/domain-scan/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/domain-scan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/domain-scan/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/domain-scan/languages","stargazers_url":"https://api.github.com/repos/18F/domain-scan/stargazers","contributors_url":"https://api.github.com/repos/18F/domain-scan/contributors","subscribers_url":"https://api.github.com/repos/18F/domain-scan/subscribers","subscription_url":"https://api.github.com/repos/18F/domain-scan/subscription","commits_url":"https://api.github.com/repos/18F/domain-scan/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/domain-scan/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/domain-scan/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/domain-scan/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/domain-scan/contents/{+path}","compare_url":"https://api.github.com/repos/18F/domain-scan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/domain-scan/merges","archive_url":"https://api.github.com/repos/18F/domain-scan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/domain-scan/downloads","issues_url":"https://api.github.com/repos/18F/domain-scan/issues{/number}","pulls_url":"https://api.github.com/repos/18F/domain-scan/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/domain-scan/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/domain-scan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/domain-scan/labels{/name}","releases_url":"https://api.github.com/repos/18F/domain-scan/releases{/id}","created_at":"2014-12-03T06:52:17Z","updated_at":"2015-06-27T19:38:52Z","pushed_at":"2015-08-14T13:24:27Z","git_url":"git://github.com/18F/domain-scan.git","ssh_url":"git@github.com:18F/domain-scan.git","clone_url":"https://github.com/18F/domain-scan.git","svn_url":"https://github.com/18F/domain-scan","homepage":"","size":474,"stargazers_count":21,"watchers_count":21,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":6,"forks":22,"open_issues":6,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/18F/domain-scan/pulls/38"},"html":{"href":"https://github.com/18F/domain-scan/pull/38"},"issue":{"href":"https://api.github.com/repos/18F/domain-scan/issues/38"},"comments":{"href":"https://api.github.com/repos/18F/domain-scan/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/18F/domain-scan/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/18F/domain-scan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/18F/domain-scan/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/18F/domain-scan/statuses/28b8f3c6813f0cc38e4bd16a01c6b001973b1573"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}