{"action":"created","comment":{"url":"https://api.github.com/repos/KentorIT/authservices/pulls/comments/23616422","id":23616422,"diff_hunk":"@@ -0,0 +1,65 @@\n+﻿using System;\n+using System.Collections.Generic;\n+using System.Collections.Specialized;\n+using System.Linq;\n+using System.Text;\n+using System.Threading.Tasks;\n+\n+namespace Kentor.AuthServices.Internal\n+{\n+    /// <summary>\n+    /// Class implements static methods to help parse a query string.\n+    /// </summary>\n+    public static class QueryStringHelper\n+    {\n+        /// <summary>\n+        /// Splits a query string into its key/value pairs. \n+        /// </summary>\n+        /// <param name=\"queryString\">A query string, with or without the leading '?' character.</param>\n+        /// <returns>A collecktion with the parsed keys and values.</returns>\n+        public static NameValueCollection ParseQueryString(String queryString)","path":"Kentor.AuthServices/Internal/QueryStringHelper.cs","position":20,"original_position":20,"commit_id":"366dbd1fccc31b9116331596076c5567d3598892","original_commit_id":"366dbd1fccc31b9116331596076c5567d3598892","user":{"login":"AndersAbel","id":4894558,"avatar_url":"https://avatars.githubusercontent.com/u/4894558?v=3","gravatar_id":"","url":"https://api.github.com/users/AndersAbel","html_url":"https://github.com/AndersAbel","followers_url":"https://api.github.com/users/AndersAbel/followers","following_url":"https://api.github.com/users/AndersAbel/following{/other_user}","gists_url":"https://api.github.com/users/AndersAbel/gists{/gist_id}","starred_url":"https://api.github.com/users/AndersAbel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndersAbel/subscriptions","organizations_url":"https://api.github.com/users/AndersAbel/orgs","repos_url":"https://api.github.com/users/AndersAbel/repos","events_url":"https://api.github.com/users/AndersAbel/events{/privacy}","received_events_url":"https://api.github.com/users/AndersAbel/received_events","type":"User","site_admin":false},"body":"Is the old NameValueCollection really the best type to return? Could we go with a more modern IDictionary<string, string>? What is used in Owin? Could we use the same type?","created_at":"2015-01-27T15:41:48Z","updated_at":"2015-01-27T15:41:48Z","html_url":"https://github.com/KentorIT/authservices/pull/179#discussion_r23616422","pull_request_url":"https://api.github.com/repos/KentorIT/authservices/pulls/179","_links":{"self":{"href":"https://api.github.com/repos/KentorIT/authservices/pulls/comments/23616422"},"html":{"href":"https://github.com/KentorIT/authservices/pull/179#discussion_r23616422"},"pull_request":{"href":"https://api.github.com/repos/KentorIT/authservices/pulls/179"}}},"pull_request":{"url":"https://api.github.com/repos/KentorIT/authservices/pulls/179","id":27345302,"html_url":"https://github.com/KentorIT/authservices/pull/179","diff_url":"https://github.com/KentorIT/authservices/pull/179.diff","patch_url":"https://github.com/KentorIT/authservices/pull/179.patch","issue_url":"https://api.github.com/repos/KentorIT/authservices/issues/179","number":179,"state":"open","locked":false,"title":"Proposed fix to Issue #97: Move the Saml2AuthenticationModule to an own assembly","user":{"login":"TobbeHolmstrom","id":10437275,"avatar_url":"https://avatars.githubusercontent.com/u/10437275?v=3","gravatar_id":"","url":"https://api.github.com/users/TobbeHolmstrom","html_url":"https://github.com/TobbeHolmstrom","followers_url":"https://api.github.com/users/TobbeHolmstrom/followers","following_url":"https://api.github.com/users/TobbeHolmstrom/following{/other_user}","gists_url":"https://api.github.com/users/TobbeHolmstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/TobbeHolmstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TobbeHolmstrom/subscriptions","organizations_url":"https://api.github.com/users/TobbeHolmstrom/orgs","repos_url":"https://api.github.com/users/TobbeHolmstrom/repos","events_url":"https://api.github.com/users/TobbeHolmstrom/events{/privacy}","received_events_url":"https://api.github.com/users/TobbeHolmstrom/received_events","type":"User","site_admin":false},"body":"Removed the dependency on System.Web in the core library and from the Owin assembly. Added a new module for http.  \r\n\r\nThere might be an issue with code duplication between the MVC and HTTP modules if we do not introduce a utilities assembly or something like that as some replacement methods for System.Web are repeated in both projects.\r\n\r\nThe replacement for federation config section loading is a bit rough. I will continue to look at this.","created_at":"2015-01-14T12:09:22Z","updated_at":"2015-01-27T15:41:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c98a0ce7341f5000cf44ffa0d37680e0c763221b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/KentorIT/authservices/pulls/179/commits","review_comments_url":"https://api.github.com/repos/KentorIT/authservices/pulls/179/comments","review_comment_url":"https://api.github.com/repos/KentorIT/authservices/pulls/comments/{number}","comments_url":"https://api.github.com/repos/KentorIT/authservices/issues/179/comments","statuses_url":"https://api.github.com/repos/KentorIT/authservices/statuses/366dbd1fccc31b9116331596076c5567d3598892","head":{"label":"TobbeHolmstrom:iss97","ref":"iss97","sha":"366dbd1fccc31b9116331596076c5567d3598892","user":{"login":"TobbeHolmstrom","id":10437275,"avatar_url":"https://avatars.githubusercontent.com/u/10437275?v=3","gravatar_id":"","url":"https://api.github.com/users/TobbeHolmstrom","html_url":"https://github.com/TobbeHolmstrom","followers_url":"https://api.github.com/users/TobbeHolmstrom/followers","following_url":"https://api.github.com/users/TobbeHolmstrom/following{/other_user}","gists_url":"https://api.github.com/users/TobbeHolmstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/TobbeHolmstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TobbeHolmstrom/subscriptions","organizations_url":"https://api.github.com/users/TobbeHolmstrom/orgs","repos_url":"https://api.github.com/users/TobbeHolmstrom/repos","events_url":"https://api.github.com/users/TobbeHolmstrom/events{/privacy}","received_events_url":"https://api.github.com/users/TobbeHolmstrom/received_events","type":"User","site_admin":false},"repo":{"id":28956320,"name":"authservices","full_name":"TobbeHolmstrom/authservices","owner":{"login":"TobbeHolmstrom","id":10437275,"avatar_url":"https://avatars.githubusercontent.com/u/10437275?v=3","gravatar_id":"","url":"https://api.github.com/users/TobbeHolmstrom","html_url":"https://github.com/TobbeHolmstrom","followers_url":"https://api.github.com/users/TobbeHolmstrom/followers","following_url":"https://api.github.com/users/TobbeHolmstrom/following{/other_user}","gists_url":"https://api.github.com/users/TobbeHolmstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/TobbeHolmstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TobbeHolmstrom/subscriptions","organizations_url":"https://api.github.com/users/TobbeHolmstrom/orgs","repos_url":"https://api.github.com/users/TobbeHolmstrom/repos","events_url":"https://api.github.com/users/TobbeHolmstrom/events{/privacy}","received_events_url":"https://api.github.com/users/TobbeHolmstrom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TobbeHolmstrom/authservices","description":"Saml2 Authentication services for ASP.NET","fork":true,"url":"https://api.github.com/repos/TobbeHolmstrom/authservices","forks_url":"https://api.github.com/repos/TobbeHolmstrom/authservices/forks","keys_url":"https://api.github.com/repos/TobbeHolmstrom/authservices/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TobbeHolmstrom/authservices/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TobbeHolmstrom/authservices/teams","hooks_url":"https://api.github.com/repos/TobbeHolmstrom/authservices/hooks","issue_events_url":"https://api.github.com/repos/TobbeHolmstrom/authservices/issues/events{/number}","events_url":"https://api.github.com/repos/TobbeHolmstrom/authservices/events","assignees_url":"https://api.github.com/repos/TobbeHolmstrom/authservices/assignees{/user}","branches_url":"https://api.github.com/repos/TobbeHolmstrom/authservices/branches{/branch}","tags_url":"https://api.github.com/repos/TobbeHolmstrom/authservices/tags","blobs_url":"https://api.github.com/repos/TobbeHolmstrom/authservices/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TobbeHolmstrom/authservices/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TobbeHolmstrom/authservices/git/refs{/sha}","trees_url":"https://api.github.com/repos/TobbeHolmstrom/authservices/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TobbeHolmstrom/authservices/statuses/{sha}","languages_url":"https://api.github.com/repos/TobbeHolmstrom/authservices/languages","stargazers_url":"https://api.github.com/repos/TobbeHolmstrom/authservices/stargazers","contributors_url":"https://api.github.com/repos/TobbeHolmstrom/authservices/contributors","subscribers_url":"https://api.github.com/repos/TobbeHolmstrom/authservices/subscribers","subscription_url":"https://api.github.com/repos/TobbeHolmstrom/authservices/subscription","commits_url":"https://api.github.com/repos/TobbeHolmstrom/authservices/commits{/sha}","git_commits_url":"https://api.github.com/repos/TobbeHolmstrom/authservices/git/commits{/sha}","comments_url":"https://api.github.com/repos/TobbeHolmstrom/authservices/comments{/number}","issue_comment_url":"https://api.github.com/repos/TobbeHolmstrom/authservices/issues/comments/{number}","contents_url":"https://api.github.com/repos/TobbeHolmstrom/authservices/contents/{+path}","compare_url":"https://api.github.com/repos/TobbeHolmstrom/authservices/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TobbeHolmstrom/authservices/merges","archive_url":"https://api.github.com/repos/TobbeHolmstrom/authservices/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TobbeHolmstrom/authservices/downloads","issues_url":"https://api.github.com/repos/TobbeHolmstrom/authservices/issues{/number}","pulls_url":"https://api.github.com/repos/TobbeHolmstrom/authservices/pulls{/number}","milestones_url":"https://api.github.com/repos/TobbeHolmstrom/authservices/milestones{/number}","notifications_url":"https://api.github.com/repos/TobbeHolmstrom/authservices/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TobbeHolmstrom/authservices/labels{/name}","releases_url":"https://api.github.com/repos/TobbeHolmstrom/authservices/releases{/id}","created_at":"2015-01-08T08:25:09Z","updated_at":"2015-01-19T09:16:23Z","pushed_at":"2015-01-27T13:44:28Z","git_url":"git://github.com/TobbeHolmstrom/authservices.git","ssh_url":"git@github.com:TobbeHolmstrom/authservices.git","clone_url":"https://github.com/TobbeHolmstrom/authservices.git","svn_url":"https://github.com/TobbeHolmstrom/authservices","homepage":"","size":2142,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KentorIT:master","ref":"master","sha":"1c87e07cdea42cd909c52213b390bf477a2854aa","user":{"login":"KentorIT","id":5381215,"avatar_url":"https://avatars.githubusercontent.com/u/5381215?v=3","gravatar_id":"","url":"https://api.github.com/users/KentorIT","html_url":"https://github.com/KentorIT","followers_url":"https://api.github.com/users/KentorIT/followers","following_url":"https://api.github.com/users/KentorIT/following{/other_user}","gists_url":"https://api.github.com/users/KentorIT/gists{/gist_id}","starred_url":"https://api.github.com/users/KentorIT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KentorIT/subscriptions","organizations_url":"https://api.github.com/users/KentorIT/orgs","repos_url":"https://api.github.com/users/KentorIT/repos","events_url":"https://api.github.com/users/KentorIT/events{/privacy}","received_events_url":"https://api.github.com/users/KentorIT/received_events","type":"Organization","site_admin":false},"repo":{"id":12864759,"name":"authservices","full_name":"KentorIT/authservices","owner":{"login":"KentorIT","id":5381215,"avatar_url":"https://avatars.githubusercontent.com/u/5381215?v=3","gravatar_id":"","url":"https://api.github.com/users/KentorIT","html_url":"https://github.com/KentorIT","followers_url":"https://api.github.com/users/KentorIT/followers","following_url":"https://api.github.com/users/KentorIT/following{/other_user}","gists_url":"https://api.github.com/users/KentorIT/gists{/gist_id}","starred_url":"https://api.github.com/users/KentorIT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KentorIT/subscriptions","organizations_url":"https://api.github.com/users/KentorIT/orgs","repos_url":"https://api.github.com/users/KentorIT/repos","events_url":"https://api.github.com/users/KentorIT/events{/privacy}","received_events_url":"https://api.github.com/users/KentorIT/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KentorIT/authservices","description":"Saml2 Authentication services for ASP.NET","fork":false,"url":"https://api.github.com/repos/KentorIT/authservices","forks_url":"https://api.github.com/repos/KentorIT/authservices/forks","keys_url":"https://api.github.com/repos/KentorIT/authservices/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KentorIT/authservices/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KentorIT/authservices/teams","hooks_url":"https://api.github.com/repos/KentorIT/authservices/hooks","issue_events_url":"https://api.github.com/repos/KentorIT/authservices/issues/events{/number}","events_url":"https://api.github.com/repos/KentorIT/authservices/events","assignees_url":"https://api.github.com/repos/KentorIT/authservices/assignees{/user}","branches_url":"https://api.github.com/repos/KentorIT/authservices/branches{/branch}","tags_url":"https://api.github.com/repos/KentorIT/authservices/tags","blobs_url":"https://api.github.com/repos/KentorIT/authservices/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KentorIT/authservices/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KentorIT/authservices/git/refs{/sha}","trees_url":"https://api.github.com/repos/KentorIT/authservices/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KentorIT/authservices/statuses/{sha}","languages_url":"https://api.github.com/repos/KentorIT/authservices/languages","stargazers_url":"https://api.github.com/repos/KentorIT/authservices/stargazers","contributors_url":"https://api.github.com/repos/KentorIT/authservices/contributors","subscribers_url":"https://api.github.com/repos/KentorIT/authservices/subscribers","subscription_url":"https://api.github.com/repos/KentorIT/authservices/subscription","commits_url":"https://api.github.com/repos/KentorIT/authservices/commits{/sha}","git_commits_url":"https://api.github.com/repos/KentorIT/authservices/git/commits{/sha}","comments_url":"https://api.github.com/repos/KentorIT/authservices/comments{/number}","issue_comment_url":"https://api.github.com/repos/KentorIT/authservices/issues/comments/{number}","contents_url":"https://api.github.com/repos/KentorIT/authservices/contents/{+path}","compare_url":"https://api.github.com/repos/KentorIT/authservices/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KentorIT/authservices/merges","archive_url":"https://api.github.com/repos/KentorIT/authservices/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KentorIT/authservices/downloads","issues_url":"https://api.github.com/repos/KentorIT/authservices/issues{/number}","pulls_url":"https://api.github.com/repos/KentorIT/authservices/pulls{/number}","milestones_url":"https://api.github.com/repos/KentorIT/authservices/milestones{/number}","notifications_url":"https://api.github.com/repos/KentorIT/authservices/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KentorIT/authservices/labels{/name}","releases_url":"https://api.github.com/repos/KentorIT/authservices/releases{/id}","created_at":"2013-09-16T10:36:25Z","updated_at":"2015-01-26T18:56:40Z","pushed_at":"2015-01-16T13:36:40Z","git_url":"git://github.com/KentorIT/authservices.git","ssh_url":"git@github.com:KentorIT/authservices.git","clone_url":"https://github.com/KentorIT/authservices.git","svn_url":"https://github.com/KentorIT/authservices","homepage":"","size":3525,"stargazers_count":33,"watchers_count":33,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":58,"forks":37,"open_issues":58,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KentorIT/authservices/pulls/179"},"html":{"href":"https://github.com/KentorIT/authservices/pull/179"},"issue":{"href":"https://api.github.com/repos/KentorIT/authservices/issues/179"},"comments":{"href":"https://api.github.com/repos/KentorIT/authservices/issues/179/comments"},"review_comments":{"href":"https://api.github.com/repos/KentorIT/authservices/pulls/179/comments"},"review_comment":{"href":"https://api.github.com/repos/KentorIT/authservices/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/KentorIT/authservices/pulls/179/commits"},"statuses":{"href":"https://api.github.com/repos/KentorIT/authservices/statuses/366dbd1fccc31b9116331596076c5567d3598892"}}}}