{"action":"created","issue":{"url":"https://api.github.com/repos/dimagi/commcare-hq/issues/8307","labels_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/8307/labels{/name}","comments_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/8307/comments","events_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/8307/events","html_url":"https://github.com/dimagi/commcare-hq/pull/8307","id":107814387,"number":8307,"title":"Couchforms analytics","user":{"login":"dannyroberts","id":137212,"avatar_url":"https://avatars.githubusercontent.com/u/137212?v=3","gravatar_id":"","url":"https://api.github.com/users/dannyroberts","html_url":"https://github.com/dannyroberts","followers_url":"https://api.github.com/users/dannyroberts/followers","following_url":"https://api.github.com/users/dannyroberts/following{/other_user}","gists_url":"https://api.github.com/users/dannyroberts/gists{/gist_id}","starred_url":"https://api.github.com/users/dannyroberts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannyroberts/subscriptions","organizations_url":"https://api.github.com/users/dannyroberts/orgs","repos_url":"https://api.github.com/users/dannyroberts/repos","events_url":"https://api.github.com/users/dannyroberts/events{/privacy}","received_events_url":"https://api.github.com/users/dannyroberts/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dimagi/commcare-hq/labels/No%20lint%20errors","name":"No lint errors","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-09-22T22:20:59Z","updated_at":"2015-09-24T15:10:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/8307","html_url":"https://github.com/dimagi/commcare-hq/pull/8307","diff_url":"https://github.com/dimagi/commcare-hq/pull/8307.diff","patch_url":"https://github.com/dimagi/commcare-hq/pull/8307.patch"},"body":"@czue waiting for tests\r\n\r\nThere's lots more of these to go, but probably no harm merging this in first"},"comment":{"url":"https://api.github.com/repos/dimagi/commcare-hq/issues/comments/142957599","html_url":"https://github.com/dimagi/commcare-hq/pull/8307#issuecomment-142957599","issue_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/8307","id":142957599,"user":{"login":"czue","id":66555,"avatar_url":"https://avatars.githubusercontent.com/u/66555?v=3","gravatar_id":"","url":"https://api.github.com/users/czue","html_url":"https://github.com/czue","followers_url":"https://api.github.com/users/czue/followers","following_url":"https://api.github.com/users/czue/following{/other_user}","gists_url":"https://api.github.com/users/czue/gists{/gist_id}","starred_url":"https://api.github.com/users/czue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/czue/subscriptions","organizations_url":"https://api.github.com/users/czue/orgs","repos_url":"https://api.github.com/users/czue/repos","events_url":"https://api.github.com/users/czue/events{/privacy}","received_events_url":"https://api.github.com/users/czue/received_events","type":"User","site_admin":false},"created_at":"2015-09-24T15:10:14Z","updated_at":"2015-09-24T15:10:14Z","body":"looks like a great set of changes. reviewed individual commits for structure though didn't review the functions closely. I think I'm comfortable with that level given that it was mostly moved code and that it now has test coverage too (!!). will merge assuming you agree with that sentiment.\r\n\r\none question - wanted to confirm that you were careful about the convention of `analytics` being something that is only used in reports? so like, we can now rewrite those functions on ES or sofabed with no major concerns. right?\r\n\r\nassuming yes is probably worth highlighting the convention to the wider team"}}