{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments/24947767","id":24947767,"diff_hunk":"@@ -1137,15 +1154,15 @@\n                                  :certname               certname\n                                  :report_format          report_format\n                                  :configuration_version  configuration_version\n-                                 :start_time             (to-timestamp start_time)\n-                                 :end_time               (to-timestamp end_time)\n+                                 :start_time             start_time\n+                                 :end_time               end_time\n                                  :receive_time           (to-timestamp timestamp)\n                                  :transaction_uuid       transaction_uuid\n                                  :environment_id         (ensure-environment environment)\n                                  :status_id              (ensure-status status)}))\n \n-            (apply sql/insert-records :resource_events resource-event-rows)\n-            (if update-latest-report?\n+            (apply sql/insert-records :resource_events (map (comp convert-containment-path #(assoc % :report report-hash)) resource_events))","path":"src/puppetlabs/puppetdb/scf/storage.clj","position":115,"original_position":115,"commit_id":"6010919d37c4bce85018d14e91b48cb31c58b5e8","original_commit_id":"6010919d37c4bce85018d14e91b48cb31c58b5e8","user":{"login":"senior","id":215910,"avatar_url":"https://avatars.githubusercontent.com/u/215910?v=3","gravatar_id":"","url":"https://api.github.com/users/senior","html_url":"https://github.com/senior","followers_url":"https://api.github.com/users/senior/followers","following_url":"https://api.github.com/users/senior/following{/other_user}","gists_url":"https://api.github.com/users/senior/gists{/gist_id}","starred_url":"https://api.github.com/users/senior/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/senior/subscriptions","organizations_url":"https://api.github.com/users/senior/orgs","repos_url":"https://api.github.com/users/senior/repos","events_url":"https://api.github.com/users/senior/events{/privacy}","received_events_url":"https://api.github.com/users/senior/received_events","type":"User","site_admin":false},"body":"Probably right, that line is getting a bit long","created_at":"2015-02-18T22:31:46Z","updated_at":"2015-02-18T22:31:46Z","html_url":"https://github.com/puppetlabs/puppetdb/pull/1262#discussion_r24947767","pull_request_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1262","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments/24947767"},"html":{"href":"https://github.com/puppetlabs/puppetdb/pull/1262#discussion_r24947767"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1262"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1262","id":29523451,"html_url":"https://github.com/puppetlabs/puppetdb/pull/1262","diff_url":"https://github.com/puppetlabs/puppetdb/pull/1262.diff","patch_url":"https://github.com/puppetlabs/puppetdb/pull/1262.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1262","number":1262,"state":"open","locked":false,"title":"(PDB-1241) Resource Event timestamps should be normalized before stored","user":{"login":"senior","id":215910,"avatar_url":"https://avatars.githubusercontent.com/u/215910?v=3","gravatar_id":"","url":"https://api.github.com/users/senior","html_url":"https://github.com/senior","followers_url":"https://api.github.com/users/senior/followers","following_url":"https://api.github.com/users/senior/following{/other_user}","gists_url":"https://api.github.com/users/senior/gists{/gist_id}","starred_url":"https://api.github.com/users/senior/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/senior/subscriptions","organizations_url":"https://api.github.com/users/senior/orgs","repos_url":"https://api.github.com/users/senior/repos","events_url":"https://api.github.com/users/senior/events{/privacy}","received_events_url":"https://api.github.com/users/senior/received_events","type":"User","site_admin":false},"body":"There are many ways to represent an ISO 8601 timestamp in string\r\nform. The end result is the posibility of having to two timestamps that\r\nare the same, but represented different which causes the report to hash\r\ndifferently. Although Puppet should be sending PuppetDB UTC dates, our\r\ntests were using non-UTC dates, which would cause the dates to be stored\r\nin another timezone, then converted to UTC on the way out of the\r\ndatabase which is really confusing.","created_at":"2015-02-18T13:05:08Z","updated_at":"2015-02-18T22:31:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a964ecdf3c31b4276d814257d7999961cb91fde1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1262/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1262/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments/{number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1262/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/6010919d37c4bce85018d14e91b48cb31c58b5e8","head":{"label":"senior:ticket/master/pdb-1241-resource-event-timestamps","ref":"ticket/master/pdb-1241-resource-event-timestamps","sha":"6010919d37c4bce85018d14e91b48cb31c58b5e8","user":{"login":"senior","id":215910,"avatar_url":"https://avatars.githubusercontent.com/u/215910?v=3","gravatar_id":"","url":"https://api.github.com/users/senior","html_url":"https://github.com/senior","followers_url":"https://api.github.com/users/senior/followers","following_url":"https://api.github.com/users/senior/following{/other_user}","gists_url":"https://api.github.com/users/senior/gists{/gist_id}","starred_url":"https://api.github.com/users/senior/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/senior/subscriptions","organizations_url":"https://api.github.com/users/senior/orgs","repos_url":"https://api.github.com/users/senior/repos","events_url":"https://api.github.com/users/senior/events{/privacy}","received_events_url":"https://api.github.com/users/senior/received_events","type":"User","site_admin":false},"repo":{"id":13152306,"name":"puppetdb","full_name":"senior/puppetdb","owner":{"login":"senior","id":215910,"avatar_url":"https://avatars.githubusercontent.com/u/215910?v=3","gravatar_id":"","url":"https://api.github.com/users/senior","html_url":"https://github.com/senior","followers_url":"https://api.github.com/users/senior/followers","following_url":"https://api.github.com/users/senior/following{/other_user}","gists_url":"https://api.github.com/users/senior/gists{/gist_id}","starred_url":"https://api.github.com/users/senior/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/senior/subscriptions","organizations_url":"https://api.github.com/users/senior/orgs","repos_url":"https://api.github.com/users/senior/repos","events_url":"https://api.github.com/users/senior/events{/privacy}","received_events_url":"https://api.github.com/users/senior/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/senior/puppetdb","description":"Centralized Puppet Storage","fork":true,"url":"https://api.github.com/repos/senior/puppetdb","forks_url":"https://api.github.com/repos/senior/puppetdb/forks","keys_url":"https://api.github.com/repos/senior/puppetdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/senior/puppetdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/senior/puppetdb/teams","hooks_url":"https://api.github.com/repos/senior/puppetdb/hooks","issue_events_url":"https://api.github.com/repos/senior/puppetdb/issues/events{/number}","events_url":"https://api.github.com/repos/senior/puppetdb/events","assignees_url":"https://api.github.com/repos/senior/puppetdb/assignees{/user}","branches_url":"https://api.github.com/repos/senior/puppetdb/branches{/branch}","tags_url":"https://api.github.com/repos/senior/puppetdb/tags","blobs_url":"https://api.github.com/repos/senior/puppetdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/senior/puppetdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/senior/puppetdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/senior/puppetdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/senior/puppetdb/statuses/{sha}","languages_url":"https://api.github.com/repos/senior/puppetdb/languages","stargazers_url":"https://api.github.com/repos/senior/puppetdb/stargazers","contributors_url":"https://api.github.com/repos/senior/puppetdb/contributors","subscribers_url":"https://api.github.com/repos/senior/puppetdb/subscribers","subscription_url":"https://api.github.com/repos/senior/puppetdb/subscription","commits_url":"https://api.github.com/repos/senior/puppetdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/senior/puppetdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/senior/puppetdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/senior/puppetdb/issues/comments/{number}","contents_url":"https://api.github.com/repos/senior/puppetdb/contents/{+path}","compare_url":"https://api.github.com/repos/senior/puppetdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/senior/puppetdb/merges","archive_url":"https://api.github.com/repos/senior/puppetdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/senior/puppetdb/downloads","issues_url":"https://api.github.com/repos/senior/puppetdb/issues{/number}","pulls_url":"https://api.github.com/repos/senior/puppetdb/pulls{/number}","milestones_url":"https://api.github.com/repos/senior/puppetdb/milestones{/number}","notifications_url":"https://api.github.com/repos/senior/puppetdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/senior/puppetdb/labels{/name}","releases_url":"https://api.github.com/repos/senior/puppetdb/releases{/id}","created_at":"2013-09-27T14:18:50Z","updated_at":"2014-06-21T06:15:55Z","pushed_at":"2015-02-18T20:02:29Z","git_url":"git://github.com/senior/puppetdb.git","ssh_url":"git@github.com:senior/puppetdb.git","clone_url":"https://github.com/senior/puppetdb.git","svn_url":"https://github.com/senior/puppetdb","homepage":"http://docs.puppetlabs.com/puppetdb","size":12731,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"f36b01f878c7c1f50d17301ac2289403d25b3a93","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":2193032,"name":"puppetdb","full_name":"puppetlabs/puppetdb","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetdb","description":"Centralized Puppet Storage","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetdb","forks_url":"https://api.github.com/repos/puppetlabs/puppetdb/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetdb/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetdb/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetdb/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetdb/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetdb/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetdb/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetdb/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetdb/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetdb/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetdb/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetdb/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/comments/{number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetdb/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetdb/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetdb/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetdb/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetdb/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetdb/releases{/id}","created_at":"2011-08-11T18:54:46Z","updated_at":"2015-02-18T13:40:46Z","pushed_at":"2015-02-18T13:40:45Z","git_url":"git://github.com/puppetlabs/puppetdb.git","ssh_url":"git@github.com:puppetlabs/puppetdb.git","clone_url":"https://github.com/puppetlabs/puppetdb.git","svn_url":"https://github.com/puppetlabs/puppetdb","homepage":"http://docs.puppetlabs.com/puppetdb","size":17881,"stargazers_count":152,"watchers_count":152,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":125,"mirror_url":null,"open_issues_count":5,"forks":125,"open_issues":5,"watchers":152,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1262"},"html":{"href":"https://github.com/puppetlabs/puppetdb/pull/1262"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1262"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1262/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1262/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1262/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/6010919d37c4bce85018d14e91b48cb31c58b5e8"}}}}