{"action":"created","issue":{"url":"https://api.github.com/repos/4teamwork/ftw.upgrade/issues/84","labels_url":"https://api.github.com/repos/4teamwork/ftw.upgrade/issues/84/labels{/name}","comments_url":"https://api.github.com/repos/4teamwork/ftw.upgrade/issues/84/comments","events_url":"https://api.github.com/repos/4teamwork/ftw.upgrade/issues/84/events","html_url":"https://github.com/4teamwork/ftw.upgrade/pull/84","id":103494862,"number":84,"title":"Add an afterCommitHook that notifies about the transaction having been committed","user":{"login":"lukasgraf","id":405124,"avatar_url":"https://avatars.githubusercontent.com/u/405124?v=3","gravatar_id":"","url":"https://api.github.com/users/lukasgraf","html_url":"https://github.com/lukasgraf","followers_url":"https://api.github.com/users/lukasgraf/followers","following_url":"https://api.github.com/users/lukasgraf/following{/other_user}","gists_url":"https://api.github.com/users/lukasgraf/gists{/gist_id}","starred_url":"https://api.github.com/users/lukasgraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukasgraf/subscriptions","organizations_url":"https://api.github.com/users/lukasgraf/orgs","repos_url":"https://api.github.com/users/lukasgraf/repos","events_url":"https://api.github.com/users/lukasgraf/events{/privacy}","received_events_url":"https://api.github.com/users/lukasgraf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-27T12:12:44Z","updated_at":"2015-08-27T12:17:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/4teamwork/ftw.upgrade/pulls/84","html_url":"https://github.com/4teamwork/ftw.upgrade/pull/84","diff_url":"https://github.com/4teamwork/ftw.upgrade/pull/84.diff","patch_url":"https://github.com/4teamwork/ftw.upgrade/pull/84.patch"},"body":"This PR adds an `afterCommitHook` that simply logs an info message as soon as the transaction has been committed (or aborted).\r\n\r\nThis is helpful for very long upgrades where the transaction can get quite large, and takes a while to commit. It then is hard to tell when exactly the transaction is done committing.\r\n\r\n[Hooks are not persisted across transaction boundaries](https://github.com/zopefoundation/transaction/blob/a97ce37f47f7e5813d450e931e93c8b8b4544ecd/transaction/interfaces.py#L268-L275) - so no special care has to be taken to make sure the hook is removed:\r\n\r\n> Calling a hook \"consumes\" its registration:  hook registrations do not persist across transactions.\r\n\r\n@jone @phgross @deiferni "},"comment":{"url":"https://api.github.com/repos/4teamwork/ftw.upgrade/issues/comments/135404645","html_url":"https://github.com/4teamwork/ftw.upgrade/pull/84#issuecomment-135404645","issue_url":"https://api.github.com/repos/4teamwork/ftw.upgrade/issues/84","id":135404645,"user":{"login":"phgross","id":485755,"avatar_url":"https://avatars.githubusercontent.com/u/485755?v=3","gravatar_id":"","url":"https://api.github.com/users/phgross","html_url":"https://github.com/phgross","followers_url":"https://api.github.com/users/phgross/followers","following_url":"https://api.github.com/users/phgross/following{/other_user}","gists_url":"https://api.github.com/users/phgross/gists{/gist_id}","starred_url":"https://api.github.com/users/phgross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phgross/subscriptions","organizations_url":"https://api.github.com/users/phgross/orgs","repos_url":"https://api.github.com/users/phgross/repos","events_url":"https://api.github.com/users/phgross/events{/privacy}","received_events_url":"https://api.github.com/users/phgross/received_events","type":"User","site_admin":false},"created_at":"2015-08-27T12:17:32Z","updated_at":"2015-08-27T12:17:32Z","body":":+1: "}}