{"action":"created","comment":{"url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/pulls/comments/28239404","id":28239404,"diff_hunk":"@@ -104,6 +105,55 @@ public function testTlsConfiguration()\n         $this->assertEquals($config['driver'], $this->container->getParameter('fr3d_ldap.ldap_driver.parameters'));\n     }\n \n+    public function testRoleMemberOfConfiguration()\n+    {\n+        $config = $this->getDefaultConfig();\n+        $config['user']['role']['memberOf']['dnSuffixFilter'] = 'ou=Roles,dc=example,dc=com';\n+\n+        $this->container = new ContainerBuilder();\n+        $extension = new FR3DLdapExtension();\n+\n+        $extension->load(array($config), $this->container);\n+\n+        $this->assertEquals($config['driver'], $this->container->getParameter('fr3d_ldap.ldap_driver.parameters'));\n+        $this->assertEquals($config['user'], $this->container->getParameter('fr3d_ldap.ldap_manager.parameters'));\n+    }\n+\n+    public function testRoleSearchConfiguration()\n+    {\n+        $config = $this->getDefaultConfig();\n+        $config['user']['role']['search']['baseDn'] = 'ou=Roles,dc=example,dc=com';\n+        $config['user']['role']['search']['nameAttribute'] = 'cn';\n+        $config['user']['role']['search']['userDnAttribute'] = 'member';\n+        $config['user']['role']['search']['userId'] = 'dn';\n+\n+        $this->container = new ContainerBuilder();\n+        $extension = new FR3DLdapExtension();\n+\n+        $extension->load(array($config), $this->container);\n+\n+        $this->assertEquals($config['driver'], $this->container->getParameter('fr3d_ldap.ldap_driver.parameters'));\n+        $this->assertEquals($config['user'], $this->container->getParameter('fr3d_ldap.ldap_manager.parameters'));\n+    }\n+\n+    /**\n+     * @expectedException \\Symfony\\Component\\Config\\Definition\\Exception\\InvalidConfigurationException","path":"Tests/DependencyInjection/FR3DLdapExtensionTest.php","position":47,"original_position":47,"commit_id":"6db3efc4860f8854c205d8c00402c36dc2021fa9","original_commit_id":"6db3efc4860f8854c205d8c00402c36dc2021fa9","user":{"login":"Maks3w","id":1301698,"avatar_url":"https://avatars.githubusercontent.com/u/1301698?v=3","gravatar_id":"","url":"https://api.github.com/users/Maks3w","html_url":"https://github.com/Maks3w","followers_url":"https://api.github.com/users/Maks3w/followers","following_url":"https://api.github.com/users/Maks3w/following{/other_user}","gists_url":"https://api.github.com/users/Maks3w/gists{/gist_id}","starred_url":"https://api.github.com/users/Maks3w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Maks3w/subscriptions","organizations_url":"https://api.github.com/users/Maks3w/orgs","repos_url":"https://api.github.com/users/Maks3w/repos","events_url":"https://api.github.com/users/Maks3w/events{/privacy}","received_events_url":"https://api.github.com/users/Maks3w/received_events","type":"User","site_admin":false},"body":"I preffer to use the method `setExpectedException` because is not possible to know what line is expected to throw the exception.\r\n\r\nAlso I guess assertEquals are useless in this case.","created_at":"2015-04-13T13:56:21Z","updated_at":"2015-04-13T13:56:21Z","html_url":"https://github.com/Maks3w/FR3DLdapBundle/pull/87#discussion_r28239404","pull_request_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/pulls/87","_links":{"self":{"href":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/pulls/comments/28239404"},"html":{"href":"https://github.com/Maks3w/FR3DLdapBundle/pull/87#discussion_r28239404"},"pull_request":{"href":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/pulls/87"}}},"pull_request":{"url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/pulls/87","id":33122867,"html_url":"https://github.com/Maks3w/FR3DLdapBundle/pull/87","diff_url":"https://github.com/Maks3w/FR3DLdapBundle/pull/87.diff","patch_url":"https://github.com/Maks3w/FR3DLdapBundle/pull/87.patch","issue_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/issues/87","number":87,"state":"open","locked":false,"title":"Add standalone mode and ldap role lookup","user":{"login":"Noles","id":3484086,"avatar_url":"https://avatars.githubusercontent.com/u/3484086?v=3","gravatar_id":"","url":"https://api.github.com/users/Noles","html_url":"https://github.com/Noles","followers_url":"https://api.github.com/users/Noles/followers","following_url":"https://api.github.com/users/Noles/following{/other_user}","gists_url":"https://api.github.com/users/Noles/gists{/gist_id}","starred_url":"https://api.github.com/users/Noles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Noles/subscriptions","organizations_url":"https://api.github.com/users/Noles/orgs","repos_url":"https://api.github.com/users/Noles/repos","events_url":"https://api.github.com/users/Noles/events{/privacy}","received_events_url":"https://api.github.com/users/Noles/received_events","type":"User","site_admin":false},"body":"Related and Resolve #86","created_at":"2015-04-12T17:05:33Z","updated_at":"2015-04-13T13:56:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7abb05adbb1460fcc51fc7b3a0e0c2fc4c221fe0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/pulls/87/commits","review_comments_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/pulls/87/comments","review_comment_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/issues/87/comments","statuses_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/statuses/6db3efc4860f8854c205d8c00402c36dc2021fa9","head":{"label":"Noles:upstream-2.0","ref":"upstream-2.0","sha":"6db3efc4860f8854c205d8c00402c36dc2021fa9","user":{"login":"Noles","id":3484086,"avatar_url":"https://avatars.githubusercontent.com/u/3484086?v=3","gravatar_id":"","url":"https://api.github.com/users/Noles","html_url":"https://github.com/Noles","followers_url":"https://api.github.com/users/Noles/followers","following_url":"https://api.github.com/users/Noles/following{/other_user}","gists_url":"https://api.github.com/users/Noles/gists{/gist_id}","starred_url":"https://api.github.com/users/Noles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Noles/subscriptions","organizations_url":"https://api.github.com/users/Noles/orgs","repos_url":"https://api.github.com/users/Noles/repos","events_url":"https://api.github.com/users/Noles/events{/privacy}","received_events_url":"https://api.github.com/users/Noles/received_events","type":"User","site_admin":false},"repo":{"id":33049423,"name":"FR3DLdapBundle","full_name":"Noles/FR3DLdapBundle","owner":{"login":"Noles","id":3484086,"avatar_url":"https://avatars.githubusercontent.com/u/3484086?v=3","gravatar_id":"","url":"https://api.github.com/users/Noles","html_url":"https://github.com/Noles","followers_url":"https://api.github.com/users/Noles/followers","following_url":"https://api.github.com/users/Noles/following{/other_user}","gists_url":"https://api.github.com/users/Noles/gists{/gist_id}","starred_url":"https://api.github.com/users/Noles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Noles/subscriptions","organizations_url":"https://api.github.com/users/Noles/orgs","repos_url":"https://api.github.com/users/Noles/repos","events_url":"https://api.github.com/users/Noles/events{/privacy}","received_events_url":"https://api.github.com/users/Noles/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Noles/FR3DLdapBundle","description":"This bundle integrates LDAP Authentication with any user manager (Ex: FOSUserBundle)","fork":true,"url":"https://api.github.com/repos/Noles/FR3DLdapBundle","forks_url":"https://api.github.com/repos/Noles/FR3DLdapBundle/forks","keys_url":"https://api.github.com/repos/Noles/FR3DLdapBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Noles/FR3DLdapBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Noles/FR3DLdapBundle/teams","hooks_url":"https://api.github.com/repos/Noles/FR3DLdapBundle/hooks","issue_events_url":"https://api.github.com/repos/Noles/FR3DLdapBundle/issues/events{/number}","events_url":"https://api.github.com/repos/Noles/FR3DLdapBundle/events","assignees_url":"https://api.github.com/repos/Noles/FR3DLdapBundle/assignees{/user}","branches_url":"https://api.github.com/repos/Noles/FR3DLdapBundle/branches{/branch}","tags_url":"https://api.github.com/repos/Noles/FR3DLdapBundle/tags","blobs_url":"https://api.github.com/repos/Noles/FR3DLdapBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Noles/FR3DLdapBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Noles/FR3DLdapBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/Noles/FR3DLdapBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Noles/FR3DLdapBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/Noles/FR3DLdapBundle/languages","stargazers_url":"https://api.github.com/repos/Noles/FR3DLdapBundle/stargazers","contributors_url":"https://api.github.com/repos/Noles/FR3DLdapBundle/contributors","subscribers_url":"https://api.github.com/repos/Noles/FR3DLdapBundle/subscribers","subscription_url":"https://api.github.com/repos/Noles/FR3DLdapBundle/subscription","commits_url":"https://api.github.com/repos/Noles/FR3DLdapBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/Noles/FR3DLdapBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/Noles/FR3DLdapBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/Noles/FR3DLdapBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/Noles/FR3DLdapBundle/contents/{+path}","compare_url":"https://api.github.com/repos/Noles/FR3DLdapBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Noles/FR3DLdapBundle/merges","archive_url":"https://api.github.com/repos/Noles/FR3DLdapBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Noles/FR3DLdapBundle/downloads","issues_url":"https://api.github.com/repos/Noles/FR3DLdapBundle/issues{/number}","pulls_url":"https://api.github.com/repos/Noles/FR3DLdapBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/Noles/FR3DLdapBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/Noles/FR3DLdapBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Noles/FR3DLdapBundle/labels{/name}","releases_url":"https://api.github.com/repos/Noles/FR3DLdapBundle/releases{/id}","created_at":"2015-03-28T20:39:06Z","updated_at":"2015-04-12T19:42:22Z","pushed_at":"2015-04-12T19:42:21Z","git_url":"git://github.com/Noles/FR3DLdapBundle.git","ssh_url":"git@github.com:Noles/FR3DLdapBundle.git","clone_url":"https://github.com/Noles/FR3DLdapBundle.git","svn_url":"https://github.com/Noles/FR3DLdapBundle","homepage":"","size":245,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Maks3w:2.0.x","ref":"2.0.x","sha":"8de5f7433abfbcbaee78fea2523363775f998870","user":{"login":"Maks3w","id":1301698,"avatar_url":"https://avatars.githubusercontent.com/u/1301698?v=3","gravatar_id":"","url":"https://api.github.com/users/Maks3w","html_url":"https://github.com/Maks3w","followers_url":"https://api.github.com/users/Maks3w/followers","following_url":"https://api.github.com/users/Maks3w/following{/other_user}","gists_url":"https://api.github.com/users/Maks3w/gists{/gist_id}","starred_url":"https://api.github.com/users/Maks3w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Maks3w/subscriptions","organizations_url":"https://api.github.com/users/Maks3w/orgs","repos_url":"https://api.github.com/users/Maks3w/repos","events_url":"https://api.github.com/users/Maks3w/events{/privacy}","received_events_url":"https://api.github.com/users/Maks3w/received_events","type":"User","site_admin":false},"repo":{"id":3365198,"name":"FR3DLdapBundle","full_name":"Maks3w/FR3DLdapBundle","owner":{"login":"Maks3w","id":1301698,"avatar_url":"https://avatars.githubusercontent.com/u/1301698?v=3","gravatar_id":"","url":"https://api.github.com/users/Maks3w","html_url":"https://github.com/Maks3w","followers_url":"https://api.github.com/users/Maks3w/followers","following_url":"https://api.github.com/users/Maks3w/following{/other_user}","gists_url":"https://api.github.com/users/Maks3w/gists{/gist_id}","starred_url":"https://api.github.com/users/Maks3w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Maks3w/subscriptions","organizations_url":"https://api.github.com/users/Maks3w/orgs","repos_url":"https://api.github.com/users/Maks3w/repos","events_url":"https://api.github.com/users/Maks3w/events{/privacy}","received_events_url":"https://api.github.com/users/Maks3w/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Maks3w/FR3DLdapBundle","description":"This bundle integrates LDAP Authentication with any user manager (Ex: FOSUserBundle)","fork":false,"url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle","forks_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/forks","keys_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/teams","hooks_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/hooks","issue_events_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/issues/events{/number}","events_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/events","assignees_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/assignees{/user}","branches_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/branches{/branch}","tags_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/tags","blobs_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/languages","stargazers_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/stargazers","contributors_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/contributors","subscribers_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/subscribers","subscription_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/subscription","commits_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/contents/{+path}","compare_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/merges","archive_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/downloads","issues_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/issues{/number}","pulls_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/labels{/name}","releases_url":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/releases{/id}","created_at":"2012-02-06T07:55:41Z","updated_at":"2015-04-11T17:21:36Z","pushed_at":"2015-04-12T19:30:47Z","git_url":"git://github.com/Maks3w/FR3DLdapBundle.git","ssh_url":"git@github.com:Maks3w/FR3DLdapBundle.git","clone_url":"https://github.com/Maks3w/FR3DLdapBundle.git","svn_url":"https://github.com/Maks3w/FR3DLdapBundle","homepage":"","size":569,"stargazers_count":60,"watchers_count":60,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":55,"mirror_url":null,"open_issues_count":14,"forks":55,"open_issues":14,"watchers":60,"default_branch":"2.0.x"}},"_links":{"self":{"href":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/pulls/87"},"html":{"href":"https://github.com/Maks3w/FR3DLdapBundle/pull/87"},"issue":{"href":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/issues/87"},"comments":{"href":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/issues/87/comments"},"review_comments":{"href":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/pulls/87/comments"},"review_comment":{"href":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/pulls/87/commits"},"statuses":{"href":"https://api.github.com/repos/Maks3w/FR3DLdapBundle/statuses/6db3efc4860f8854c205d8c00402c36dc2021fa9"}}}}