{"action":"created","issue":{"url":"https://api.github.com/repos/Valloric/ycmd/issues/280","labels_url":"https://api.github.com/repos/Valloric/ycmd/issues/280/labels{/name}","comments_url":"https://api.github.com/repos/Valloric/ycmd/issues/280/comments","events_url":"https://api.github.com/repos/Valloric/ycmd/issues/280/events","html_url":"https://github.com/Valloric/ycmd/pull/280","id":123159812,"number":280,"title":"[READY] Recognise ~/.tern-config in Tern completer","user":{"login":"puremourning","id":10584846,"avatar_url":"https://avatars.githubusercontent.com/u/10584846?v=3","gravatar_id":"","url":"https://api.github.com/users/puremourning","html_url":"https://github.com/puremourning","followers_url":"https://api.github.com/users/puremourning/followers","following_url":"https://api.github.com/users/puremourning/following{/other_user}","gists_url":"https://api.github.com/users/puremourning/gists{/gist_id}","starred_url":"https://api.github.com/users/puremourning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puremourning/subscriptions","organizations_url":"https://api.github.com/users/puremourning/orgs","repos_url":"https://api.github.com/users/puremourning/repos","events_url":"https://api.github.com/users/puremourning/events{/privacy}","received_events_url":"https://api.github.com/users/puremourning/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-12-20T13:29:00Z","updated_at":"2015-12-21T16:01:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Valloric/ycmd/pulls/280","html_url":"https://github.com/Valloric/ycmd/pull/280","diff_url":"https://github.com/Valloric/ycmd/pull/280.diff","patch_url":"https://github.com/Valloric/ycmd/pull/280.patch"},"body":"Fixes #277 \r\n\r\nWe simply suppress the warning if we detect a `.tern-project` or a user's `~/.tern-config`.\r\n\r\n<!-- Reviewable:start -->\r\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/valloric/ycmd/280)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/Valloric/ycmd/issues/comments/166341111","html_url":"https://github.com/Valloric/ycmd/pull/280#issuecomment-166341111","issue_url":"https://api.github.com/repos/Valloric/ycmd/issues/280","id":166341111,"user":{"login":"puremourning","id":10584846,"avatar_url":"https://avatars.githubusercontent.com/u/10584846?v=3","gravatar_id":"","url":"https://api.github.com/users/puremourning","html_url":"https://github.com/puremourning","followers_url":"https://api.github.com/users/puremourning/followers","following_url":"https://api.github.com/users/puremourning/following{/other_user}","gists_url":"https://api.github.com/users/puremourning/gists{/gist_id}","starred_url":"https://api.github.com/users/puremourning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puremourning/subscriptions","organizations_url":"https://api.github.com/users/puremourning/orgs","repos_url":"https://api.github.com/users/puremourning/repos","events_url":"https://api.github.com/users/puremourning/events{/privacy}","received_events_url":"https://api.github.com/users/puremourning/received_events","type":"User","site_admin":false},"created_at":"2015-12-21T16:01:35Z","updated_at":"2015-12-21T16:01:35Z","body":"I have applied the mocking approach for the tests.\n\n---\n\nReview status: 0 of 2 files reviewed at latest revision, 2 unresolved discussions.\n\n---\n\n*[ycmd/tests/javascript/event_notification_test.py, line 40 \\[r1\\]](https://reviewable.io:443/reviews/valloric/ycmd/280#-K60gZLF5L81TecGFUHe:-K64EC0IC6BKjfyiO6nk:-1988458546) ([raw file](https://github.com/valloric/ycmd/blob/48aadc1b32ca01ff9e375b44b5b58528e6f273b0/ycmd/tests/javascript/event_notification_test.py#L40)):*\nYeah, this is unfortunate. It was the only way I could think of to test the actual code without invasive patching.\n\n---\n\n*[ycmd/tests/javascript/event_notification_test.py, line 86 \\[r1\\]](https://reviewable.io:443/reviews/valloric/ycmd/280#-K60guGmmoEXAqzCxf2k:-K64ETPTZ0SKU0Q-AsLQ:-1883809049) ([raw file](https://github.com/valloric/ycmd/blob/48aadc1b32ca01ff9e375b44b5b58528e6f273b0/ycmd/tests/javascript/event_notification_test.py#L86)):*\nGood point. It still leads to the same amount of uncoverable code, but testing the logic is more useful than not.\n\n---\n\n\n*Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/valloric/ycmd/280#-:-K64GVefz7tG85FkC8eX:-444252651)*\n<!-- Sent from Reviewable.io -->\n"}}