{"action":"closed","number":4578,"pull_request":{"url":"https://api.github.com/repos/facebook/hhvm/pulls/4578","id":26864496,"html_url":"https://github.com/facebook/hhvm/pull/4578","diff_url":"https://github.com/facebook/hhvm/pull/4578.diff","patch_url":"https://github.com/facebook/hhvm/pull/4578.patch","issue_url":"https://api.github.com/repos/facebook/hhvm/issues/4578","number":4578,"state":"closed","locked":false,"title":"Fix segfault with exceptions in object dtors and track_errors","user":{"login":"jmarrama","id":70601,"avatar_url":"https://avatars.githubusercontent.com/u/70601?v=3","gravatar_id":"","url":"https://api.github.com/users/jmarrama","html_url":"https://github.com/jmarrama","followers_url":"https://api.github.com/users/jmarrama/followers","following_url":"https://api.github.com/users/jmarrama/following{/other_user}","gists_url":"https://api.github.com/users/jmarrama/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarrama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarrama/subscriptions","organizations_url":"https://api.github.com/users/jmarrama/orgs","repos_url":"https://api.github.com/users/jmarrama/repos","events_url":"https://api.github.com/users/jmarrama/events{/privacy}","received_events_url":"https://api.github.com/users/jmarrama/received_events","type":"User","site_admin":false},"body":"This fixes the issue tracked in #4577 where throwing an exception\r\nfrom an object destructor when the 'track_errors' ini setting is\r\non causes HHVM to segfault, due to accessing the frame pointer after\r\nit has been destroyed.","created_at":"2015-01-06T01:34:26Z","updated_at":"2015-01-07T17:07:57Z","closed_at":"2015-01-07T17:07:57Z","merged_at":null,"merge_commit_sha":"f2bf5e0ad0e4092a5c886ea4da98fc47b5fb3b6b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/hhvm/pulls/4578/commits","review_comments_url":"https://api.github.com/repos/facebook/hhvm/pulls/4578/comments","review_comment_url":"https://api.github.com/repos/facebook/hhvm/pulls/comments/{number}","comments_url":"https://api.github.com/repos/facebook/hhvm/issues/4578/comments","statuses_url":"https://api.github.com/repos/facebook/hhvm/statuses/39bc82860179d301fa9966fc5ba6c41d3326f821","head":{"label":"jmarrama:fixDtorCrash","ref":"fixDtorCrash","sha":"39bc82860179d301fa9966fc5ba6c41d3326f821","user":{"login":"jmarrama","id":70601,"avatar_url":"https://avatars.githubusercontent.com/u/70601?v=3","gravatar_id":"","url":"https://api.github.com/users/jmarrama","html_url":"https://github.com/jmarrama","followers_url":"https://api.github.com/users/jmarrama/followers","following_url":"https://api.github.com/users/jmarrama/following{/other_user}","gists_url":"https://api.github.com/users/jmarrama/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarrama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarrama/subscriptions","organizations_url":"https://api.github.com/users/jmarrama/orgs","repos_url":"https://api.github.com/users/jmarrama/repos","events_url":"https://api.github.com/users/jmarrama/events{/privacy}","received_events_url":"https://api.github.com/users/jmarrama/received_events","type":"User","site_admin":false},"repo":{"id":15691100,"name":"hhvm","full_name":"jmarrama/hhvm","owner":{"login":"jmarrama","id":70601,"avatar_url":"https://avatars.githubusercontent.com/u/70601?v=3","gravatar_id":"","url":"https://api.github.com/users/jmarrama","html_url":"https://github.com/jmarrama","followers_url":"https://api.github.com/users/jmarrama/followers","following_url":"https://api.github.com/users/jmarrama/following{/other_user}","gists_url":"https://api.github.com/users/jmarrama/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarrama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarrama/subscriptions","organizations_url":"https://api.github.com/users/jmarrama/orgs","repos_url":"https://api.github.com/users/jmarrama/repos","events_url":"https://api.github.com/users/jmarrama/events{/privacy}","received_events_url":"https://api.github.com/users/jmarrama/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmarrama/hhvm","description":"HHVM is a new open-source virtual machine designed for executing programs written in PHP. HHVM uses a just-in-time (JIT) compilation approach to achieve superior performance while maintaining the flexibility that PHP developers are accustomed to.","fork":true,"url":"https://api.github.com/repos/jmarrama/hhvm","forks_url":"https://api.github.com/repos/jmarrama/hhvm/forks","keys_url":"https://api.github.com/repos/jmarrama/hhvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmarrama/hhvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmarrama/hhvm/teams","hooks_url":"https://api.github.com/repos/jmarrama/hhvm/hooks","issue_events_url":"https://api.github.com/repos/jmarrama/hhvm/issues/events{/number}","events_url":"https://api.github.com/repos/jmarrama/hhvm/events","assignees_url":"https://api.github.com/repos/jmarrama/hhvm/assignees{/user}","branches_url":"https://api.github.com/repos/jmarrama/hhvm/branches{/branch}","tags_url":"https://api.github.com/repos/jmarrama/hhvm/tags","blobs_url":"https://api.github.com/repos/jmarrama/hhvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmarrama/hhvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmarrama/hhvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmarrama/hhvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmarrama/hhvm/statuses/{sha}","languages_url":"https://api.github.com/repos/jmarrama/hhvm/languages","stargazers_url":"https://api.github.com/repos/jmarrama/hhvm/stargazers","contributors_url":"https://api.github.com/repos/jmarrama/hhvm/contributors","subscribers_url":"https://api.github.com/repos/jmarrama/hhvm/subscribers","subscription_url":"https://api.github.com/repos/jmarrama/hhvm/subscription","commits_url":"https://api.github.com/repos/jmarrama/hhvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmarrama/hhvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmarrama/hhvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmarrama/hhvm/issues/comments/{number}","contents_url":"https://api.github.com/repos/jmarrama/hhvm/contents/{+path}","compare_url":"https://api.github.com/repos/jmarrama/hhvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmarrama/hhvm/merges","archive_url":"https://api.github.com/repos/jmarrama/hhvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmarrama/hhvm/downloads","issues_url":"https://api.github.com/repos/jmarrama/hhvm/issues{/number}","pulls_url":"https://api.github.com/repos/jmarrama/hhvm/pulls{/number}","milestones_url":"https://api.github.com/repos/jmarrama/hhvm/milestones{/number}","notifications_url":"https://api.github.com/repos/jmarrama/hhvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmarrama/hhvm/labels{/name}","releases_url":"https://api.github.com/repos/jmarrama/hhvm/releases{/id}","created_at":"2014-01-07T00:43:19Z","updated_at":"2015-01-06T00:50:12Z","pushed_at":"2015-01-06T01:34:09Z","git_url":"git://github.com/jmarrama/hhvm.git","ssh_url":"git@github.com:jmarrama/hhvm.git","clone_url":"https://github.com/jmarrama/hhvm.git","svn_url":"https://github.com/jmarrama/hhvm","homepage":"http://hhvm.com","size":186154,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"aed05cdac5e838b27a9f3165dbb0fb121f22fccb","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":455600,"name":"hhvm","full_name":"facebook/hhvm","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/hhvm","description":"A virtual machine designed for executing programs written in Hack and PHP. ","fork":false,"url":"https://api.github.com/repos/facebook/hhvm","forks_url":"https://api.github.com/repos/facebook/hhvm/forks","keys_url":"https://api.github.com/repos/facebook/hhvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/hhvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/hhvm/teams","hooks_url":"https://api.github.com/repos/facebook/hhvm/hooks","issue_events_url":"https://api.github.com/repos/facebook/hhvm/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/hhvm/events","assignees_url":"https://api.github.com/repos/facebook/hhvm/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/hhvm/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/hhvm/tags","blobs_url":"https://api.github.com/repos/facebook/hhvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/hhvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/hhvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/hhvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/hhvm/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/hhvm/languages","stargazers_url":"https://api.github.com/repos/facebook/hhvm/stargazers","contributors_url":"https://api.github.com/repos/facebook/hhvm/contributors","subscribers_url":"https://api.github.com/repos/facebook/hhvm/subscribers","subscription_url":"https://api.github.com/repos/facebook/hhvm/subscription","commits_url":"https://api.github.com/repos/facebook/hhvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/hhvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/hhvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/hhvm/issues/comments/{number}","contents_url":"https://api.github.com/repos/facebook/hhvm/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/hhvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/hhvm/merges","archive_url":"https://api.github.com/repos/facebook/hhvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/hhvm/downloads","issues_url":"https://api.github.com/repos/facebook/hhvm/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/hhvm/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/hhvm/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/hhvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/hhvm/labels{/name}","releases_url":"https://api.github.com/repos/facebook/hhvm/releases{/id}","created_at":"2010-01-02T01:17:06Z","updated_at":"2015-01-07T17:07:54Z","pushed_at":"2015-01-07T17:07:54Z","git_url":"git://github.com/facebook/hhvm.git","ssh_url":"git@github.com:facebook/hhvm.git","clone_url":"https://github.com/facebook/hhvm.git","svn_url":"https://github.com/facebook/hhvm","homepage":"http://hhvm.com","size":339624,"stargazers_count":10661,"watchers_count":10661,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":1853,"mirror_url":null,"open_issues_count":441,"forks":1853,"open_issues":441,"watchers":10661,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/hhvm/pulls/4578"},"html":{"href":"https://github.com/facebook/hhvm/pull/4578"},"issue":{"href":"https://api.github.com/repos/facebook/hhvm/issues/4578"},"comments":{"href":"https://api.github.com/repos/facebook/hhvm/issues/4578/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/hhvm/pulls/4578/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/hhvm/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/facebook/hhvm/pulls/4578/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/hhvm/statuses/39bc82860179d301fa9966fc5ba6c41d3326f821"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":18,"deletions":3,"changed_files":3}}