{"action":"created","issue":{"url":"https://api.github.com/repos/webSPELL/webSPELL/issues/221","labels_url":"https://api.github.com/repos/webSPELL/webSPELL/issues/221/labels{/name}","comments_url":"https://api.github.com/repos/webSPELL/webSPELL/issues/221/comments","events_url":"https://api.github.com/repos/webSPELL/webSPELL/issues/221/events","html_url":"https://github.com/webSPELL/webSPELL/pull/221","id":66199009,"number":221,"title":"style(index): add footer","user":{"login":"xxxrenegade","id":2109906,"avatar_url":"https://avatars.githubusercontent.com/u/2109906?v=3","gravatar_id":"","url":"https://api.github.com/users/xxxrenegade","html_url":"https://github.com/xxxrenegade","followers_url":"https://api.github.com/users/xxxrenegade/followers","following_url":"https://api.github.com/users/xxxrenegade/following{/other_user}","gists_url":"https://api.github.com/users/xxxrenegade/gists{/gist_id}","starred_url":"https://api.github.com/users/xxxrenegade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xxxrenegade/subscriptions","organizations_url":"https://api.github.com/users/xxxrenegade/orgs","repos_url":"https://api.github.com/users/xxxrenegade/repos","events_url":"https://api.github.com/users/xxxrenegade/events{/privacy}","received_events_url":"https://api.github.com/users/xxxrenegade/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/webSPELL/webSPELL/labels/review","name":"review","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-03T17:57:48Z","updated_at":"2015-04-25T21:51:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/webSPELL/webSPELL/pulls/221","html_url":"https://github.com/webSPELL/webSPELL/pull/221","diff_url":"https://github.com/webSPELL/webSPELL/pull/221.diff","patch_url":"https://github.com/webSPELL/webSPELL/pull/221.patch"},"body":"<a href='#crh-start'></a><a href='#crh-data-%7B%22processed%22%3A%20%5B%22https%3A//github.com/webSPELL/webSPELL/pull/221%23discussion_r27885683%22%2C%20%22https%3A//github.com/webSPELL/webSPELL/pull/221%23discussion_r27886425%22%2C%20%22https%3A//github.com/webSPELL/webSPELL/pull/221%23discussion_r27888186%22%2C%20%22https%3A//github.com/webSPELL/webSPELL/pull/221%23discussion_r27888676%22%2C%20%22https%3A//github.com/webSPELL/webSPELL/pull/221%23discussion_r27888912%22%2C%20%22https%3A//github.com/webSPELL/webSPELL/pull/221%23discussion_r27889729%22%2C%20%22https%3A//github.com/webSPELL/webSPELL/pull/221%23discussion_r27905484%22%2C%20%22https%3A//github.com/webSPELL/webSPELL/pull/221%23discussion_r27905778%22%5D%2C%20%22comments%22%3A%20%7B%22Pull%20df0d0cc3958b01fba5229c005bc6de37991fe41e%20index.php%207%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/webSPELL/webSPELL/pull/221%23discussion_r27885683%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Also%20this%20seem%28ed%29%20to%20be%20common%20practice%20to%20show%20of%20you%20HTML%20/%20CSS%20validity%20I%20don%27t%20see%20any%20benefit%20for%20a%20Visitor%20to%20know%20that%20kind%20of%20information.%22%2C%20%22created_at%22%3A%20%222015-04-07T14%3A59%3A32Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/498197%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/Pascalmh%22%7D%7D%2C%20%7B%22body%22%3A%20%22Bei%20einer%20richtigen%20Webseite%20macht%20es%20keinen%20Sinn%2C%20aber%20es%20geht%20ja%20hier%20um%20das%20Default%20Template%20von%20einem%20CMS%20System%20und%20dort%20geht%20es%20ja%20auch%20darum%20zu%20Pr%5Cu00e4sentieren%20wie%20sauber%20der%20Quellcode%20ist.%22%2C%20%22created_at%22%3A%20%222015-04-07T15%3A28%3A56Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/2109906%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/xxxrenegade%22%7D%7D%2C%20%7B%22body%22%3A%20%22Sowas%20kann%20man%20vielleicht%20auf%20die%20Demo-Webseite%20als%20News%20packen.%20Aber%20f%5Cu00fcr%20das%20Default-Template%20halte%20ich%20es%20ebenfalls%20f%5Cu00fcr%20unpassend.%22%2C%20%22created_at%22%3A%20%222015-04-07T15%3A31%3A07Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1415280%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/Phhere%22%7D%7D%2C%20%7B%22body%22%3A%20%22Ich%20habe%20halt%20einfach%20den%20Inhalt%20vom%20alten%20webSPELL%20Template%20genommen.%20Wenn%20kein%20Footer%20erw%5Cu00fcnscht%20ist%20dann%20schlie%5Cu00dft%20den%20Pull%20einfach.%22%2C%20%22created_at%22%3A%20%222015-04-07T15%3A39%3A03Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/2109906%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/xxxrenegade%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20index.php%3AL264-276%22%7D%2C%20%22Pull%203c72bb7ebcd70e8835e8065975f195bc4ce320e4%20_stylesheet.css%2026%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/webSPELL/webSPELL/pull/221%23discussion_r27905484%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22This%20should%20be%20done%20by%20adding%20%60.text-centered%60%20to%20the%20html%20element%22%2C%20%22created_at%22%3A%20%222015-04-07T18%3A21%3A46Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/498197%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/Pascalmh%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20_stylesheet.css%3AL1-35%22%7D%2C%20%22Pull%20df0d0cc3958b01fba5229c005bc6de37991fe41e%20_stylesheet.css%203%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/webSPELL/webSPELL/pull/221%23discussion_r27886425%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22I%20think%20this%20will%20lead%20to%20further%20problems%2C%20I%20see%20why%20you%20are%20using%20%60position%3A%20relative%60%20here%20-%20but%20I%20think%20is%20a%20big%20price%20to%20pay.%20We%20should%20focus%20on%20keeping%20the%20default%20template%20as%20clean%20and%20simple%20as%20possible%20-%20in%20a%20way%20that%20users%20can%20then%20easily%20customize%20it.%22%2C%20%22created_at%22%3A%20%222015-04-07T15%3A06%3A31Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/498197%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/Pascalmh%22%7D%7D%2C%20%7B%22body%22%3A%20%22Ich%20sehe%20da%20kein%20Problem%20drin%2C%20wenn%20man%20ein%20Design%20an%20webSPELL%20anpasst.%20Braucht%20man%20doch%20nur%20alle%20CSS%20Deklarationen%20die%20in%20den%20Men%5Cu00fcpunkt%20/%2A%20Main%20Layout%20%2A/%20fallen%20rausl%5Cu00f6schen.%20Das%20wird%20jeder%20gescheite%20Anpasser%20so%20handhaben%2C%20bzw.%20sollte%20es%20so%20handhaben.%20Dann%20macht%20es%20auch%20keinen%20unterschied%20mehr%20ob%20dort%20mit%20position%3A%20relative%3B%20gearbeitet%20wird%20oder%20nicht.%22%2C%20%22created_at%22%3A%20%222015-04-07T15%3A24%3A23Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/2109906%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/xxxrenegade%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20_stylesheet.css%3AL1-35%22%7D%2C%20%22Pull%203c72bb7ebcd70e8835e8065975f195bc4ce320e4%20_stylesheet.css%2031%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/webSPELL/webSPELL/pull/221%23discussion_r27905778%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22this%20should%20be%20done%20by%20using%20a%20row%20%2B%20column%20%60.col-xs-12%60%22%2C%20%22created_at%22%3A%20%222015-04-07T18%3A24%3A37Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/498197%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/Pascalmh%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20_stylesheet.css%3AL1-35%22%7D%7D%7D'></a>\n<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>\n- [ ] <a href='#crh-comment-Pull df0d0cc3958b01fba5229c005bc6de37991fe41e index.php 7'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/webSPELL/webSPELL/pull/221#discussion_r27885683'>File: index.php:L264-276</a></b>\n- <a href='https://github.com/Pascalmh'><img border=0 src='https://avatars.githubusercontent.com/u/498197?v=3' height=16 width=16'></a> Also this seem(ed) to be common practice to show of you HTML / CSS validity I don't see any benefit for a Visitor to know that kind of information.\n- <a href='https://github.com/xxxrenegade'><img border=0 src='https://avatars.githubusercontent.com/u/2109906?v=3' height=16 width=16'></a> Bei einer richtigen Webseite macht es keinen Sinn, aber es geht ja hier um das Default Template von einem CMS System und dort geht es ja auch darum zu Präsentieren wie sauber der Quellcode ist.\n- <a href='https://github.com/Phhere'><img border=0 src='https://avatars.githubusercontent.com/u/1415280?v=3' height=16 width=16'></a> Sowas kann man vielleicht auf die Demo-Webseite als News packen. Aber für das Default-Template halte ich es ebenfalls für unpassend.\n- <a href='https://github.com/xxxrenegade'><img border=0 src='https://avatars.githubusercontent.com/u/2109906?v=3' height=16 width=16'></a> Ich habe halt einfach den Inhalt vom alten webSPELL Template genommen. Wenn kein Footer erwünscht ist dann schließt den Pull einfach.\n- [ ] <a href='#crh-comment-Pull df0d0cc3958b01fba5229c005bc6de37991fe41e _stylesheet.css 3'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/webSPELL/webSPELL/pull/221#discussion_r27886425'>File: _stylesheet.css:L1-35</a></b>\n- <a href='https://github.com/Pascalmh'><img border=0 src='https://avatars.githubusercontent.com/u/498197?v=3' height=16 width=16'></a> I think this will lead to further problems, I see why you are using `position: relative` here - but I think is a big price to pay. We should focus on keeping the default template as clean and simple as possible - in a way that users can then easily customize it.\n- <a href='https://github.com/xxxrenegade'><img border=0 src='https://avatars.githubusercontent.com/u/2109906?v=3' height=16 width=16'></a> Ich sehe da kein Problem drin, wenn man ein Design an webSPELL anpasst. Braucht man doch nur alle CSS Deklarationen die in den Menüpunkt /* Main Layout */ fallen rauslöschen. Das wird jeder gescheite Anpasser so handhaben, bzw. sollte es so handhaben. Dann macht es auch keinen unterschied mehr ob dort mit position: relative; gearbeitet wird oder nicht.\n- [ ] <a href='#crh-comment-Pull 3c72bb7ebcd70e8835e8065975f195bc4ce320e4 _stylesheet.css 26'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/webSPELL/webSPELL/pull/221#discussion_r27905484'>File: _stylesheet.css:L1-35</a></b>\n- <a href='https://github.com/Pascalmh'><img border=0 src='https://avatars.githubusercontent.com/u/498197?v=3' height=16 width=16'></a> This should be done by adding `.text-centered` to the html element\n- [ ] <a href='#crh-comment-Pull 3c72bb7ebcd70e8835e8065975f195bc4ce320e4 _stylesheet.css 31'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/webSPELL/webSPELL/pull/221#discussion_r27905778'>File: _stylesheet.css:L1-35</a></b>\n- <a href='https://github.com/Pascalmh'><img border=0 src='https://avatars.githubusercontent.com/u/498197?v=3' height=16 width=16'></a> this should be done by using a row + column `.col-xs-12`\n\n\n<a href='https://www.codereviewhub.com/webSPELL/webSPELL/pull/221?mark_as_completed=1'><img src='http://www.codereviewhub.com/site/github-mark-as-completed.png' height=26></a>&nbsp;<a href='https://www.codereviewhub.com/webSPELL/webSPELL/pull/221?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a>&nbsp;<a href='https://github.com/webSPELL/webSPELL/pull/221'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>\n<a href='#crh-end'></a>"},"comment":{"url":"https://api.github.com/repos/webSPELL/webSPELL/issues/comments/96285093","html_url":"https://github.com/webSPELL/webSPELL/pull/221#issuecomment-96285093","issue_url":"https://api.github.com/repos/webSPELL/webSPELL/issues/221","id":96285093,"user":{"login":"xxxrenegade","id":2109906,"avatar_url":"https://avatars.githubusercontent.com/u/2109906?v=3","gravatar_id":"","url":"https://api.github.com/users/xxxrenegade","html_url":"https://github.com/xxxrenegade","followers_url":"https://api.github.com/users/xxxrenegade/followers","following_url":"https://api.github.com/users/xxxrenegade/following{/other_user}","gists_url":"https://api.github.com/users/xxxrenegade/gists{/gist_id}","starred_url":"https://api.github.com/users/xxxrenegade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xxxrenegade/subscriptions","organizations_url":"https://api.github.com/users/xxxrenegade/orgs","repos_url":"https://api.github.com/users/xxxrenegade/repos","events_url":"https://api.github.com/users/xxxrenegade/events{/privacy}","received_events_url":"https://api.github.com/users/xxxrenegade/received_events","type":"User","site_admin":false},"created_at":"2015-04-25T21:51:49Z","updated_at":"2015-04-25T21:51:49Z","body":"Ich denke dieser Pull requests kann geschlossen werden."}}