{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/5422","labels_url":"https://api.github.com/repos/dotnet/roslyn/issues/5422/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/5422/comments","events_url":"https://api.github.com/repos/dotnet/roslyn/issues/5422/events","html_url":"https://github.com/dotnet/roslyn/issues/5422","id":108031998,"number":5422,"title":"Making sure all unit tests actually run.","user":{"login":"dpoeschl","id":235241,"avatar_url":"https://avatars.githubusercontent.com/u/235241?v=3","gravatar_id":"","url":"https://api.github.com/users/dpoeschl","html_url":"https://github.com/dpoeschl","followers_url":"https://api.github.com/users/dpoeschl/followers","following_url":"https://api.github.com/users/dpoeschl/following{/other_user}","gists_url":"https://api.github.com/users/dpoeschl/gists{/gist_id}","starred_url":"https://api.github.com/users/dpoeschl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpoeschl/subscriptions","organizations_url":"https://api.github.com/users/dpoeschl/orgs","repos_url":"https://api.github.com/users/dpoeschl/repos","events_url":"https://api.github.com/users/dpoeschl/events{/privacy}","received_events_url":"https://api.github.com/users/dpoeschl/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/roslyn/labels/Area-Infrastructure","name":"Area-Infrastructure","color":"5319e7"}],"state":"open","locked":false,"assignee":{"login":"tannergooding","id":10487869,"avatar_url":"https://avatars.githubusercontent.com/u/10487869?v=3","gravatar_id":"","url":"https://api.github.com/users/tannergooding","html_url":"https://github.com/tannergooding","followers_url":"https://api.github.com/users/tannergooding/followers","following_url":"https://api.github.com/users/tannergooding/following{/other_user}","gists_url":"https://api.github.com/users/tannergooding/gists{/gist_id}","starred_url":"https://api.github.com/users/tannergooding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tannergooding/subscriptions","organizations_url":"https://api.github.com/users/tannergooding/orgs","repos_url":"https://api.github.com/users/tannergooding/repos","events_url":"https://api.github.com/users/tannergooding/events{/privacy}","received_events_url":"https://api.github.com/users/tannergooding/received_events","type":"User","site_admin":false},"milestone":null,"comments":6,"created_at":"2015-09-24T00:13:56Z","updated_at":"2015-10-19T23:42:26Z","closed_at":null,"body":"While investigating a problem with PR #5328 today with @amcasey and @jmarolf, we found that the ```AddAwaitTests``` had a ```public void Test()``` method in them, and the existence of this method causes xUnit to ignore all tests from the entire containing type, without issuing a test failure. On commandline xUnit runs, you can see a ```System.ArgumentException [FATAL]``` with the following description, but still the suite reports no failures in the end:\r\n\r\n    ```Ambiguous method named Test in type Microsoft.CodeAnalysis.Editor.CSharp.UnitTests.Diagnostics.Async.AddAwaitTests```\r\n\r\nCan we find a way of preventing this thing in the future? An analyzer that checks for ```Test()``` methods in types containing ```[Fact]``` attributed methods? Or a change to build process that makes the xUnit run more verbose and checks for the above error message?"},"comment":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/comments/149377976","html_url":"https://github.com/dotnet/roslyn/issues/5422#issuecomment-149377976","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/5422","id":149377976,"user":{"login":"amcasey","id":10508071,"avatar_url":"https://avatars.githubusercontent.com/u/10508071?v=3","gravatar_id":"","url":"https://api.github.com/users/amcasey","html_url":"https://github.com/amcasey","followers_url":"https://api.github.com/users/amcasey/followers","following_url":"https://api.github.com/users/amcasey/following{/other_user}","gists_url":"https://api.github.com/users/amcasey/gists{/gist_id}","starred_url":"https://api.github.com/users/amcasey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amcasey/subscriptions","organizations_url":"https://api.github.com/users/amcasey/orgs","repos_url":"https://api.github.com/users/amcasey/repos","events_url":"https://api.github.com/users/amcasey/events{/privacy}","received_events_url":"https://api.github.com/users/amcasey/received_events","type":"User","site_admin":false},"created_at":"2015-10-19T23:42:26Z","updated_at":"2015-10-19T23:42:26Z","body":"@dpoeschl Is there more to do here?"}}