{"action":"created","comment":{"url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/pulls/comments/36658661","id":36658661,"diff_hunk":"@@ -17,21 +17,28 @@\n   $version = 'latest'\n   $service = 'jenkins'\n   $install_from_git = false\n+  $install_from_pip = true\n+  $install_from_pkg = false\n   $git_revision     = 'master'\n   $git_url          = 'https://git.openstack.org/openstack-infra/jenkins-job-builder'\n \n   case $::osfamily {\n     'RedHat', 'Amazon': {\n-      $python_packages = [ 'python', 'python-devel', 'python-pip', 'python-argparse']\n+      $python_packages = [ 'python', 'python-devel', 'python-pip', 'python-argparse', 'PyYAML']","path":"manifests/params.pp","position":null,"original_position":12,"commit_id":"2f3dd36ac3b9ad6e41aa2e93421ab06fdad2d815","original_commit_id":"41fded8735664d0489a2c015c10c2c6bd8930f4e","user":{"login":"gregswift","id":372939,"avatar_url":"https://avatars.githubusercontent.com/u/372939?v=3","gravatar_id":"","url":"https://api.github.com/users/gregswift","html_url":"https://github.com/gregswift","followers_url":"https://api.github.com/users/gregswift/followers","following_url":"https://api.github.com/users/gregswift/following{/other_user}","gists_url":"https://api.github.com/users/gregswift/gists{/gist_id}","starred_url":"https://api.github.com/users/gregswift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregswift/subscriptions","organizations_url":"https://api.github.com/users/gregswift/orgs","repos_url":"https://api.github.com/users/gregswift/repos","events_url":"https://api.github.com/users/gregswift/events{/privacy}","received_events_url":"https://api.github.com/users/gregswift/received_events","type":"User","site_admin":false},"body":"We are installing them for all installation methods, so that should be covered.\r\n\r\nI've updated for argparse/el7 in #12 ","created_at":"2015-08-10T17:26:45Z","updated_at":"2015-08-10T17:26:45Z","html_url":"https://github.com/puppet-community/puppet-jenkins_job_builder/pull/20#discussion_r36658661","pull_request_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/pulls/comments/36658661"},"html":{"href":"https://github.com/puppet-community/puppet-jenkins_job_builder/pull/20#discussion_r36658661"},"pull_request":{"href":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/pulls/20","id":40528735,"html_url":"https://github.com/puppet-community/puppet-jenkins_job_builder/pull/20","diff_url":"https://github.com/puppet-community/puppet-jenkins_job_builder/pull/20.diff","patch_url":"https://github.com/puppet-community/puppet-jenkins_job_builder/pull/20.patch","issue_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/issues/20","number":20,"state":"open","locked":false,"title":"Allow for only using system packages","user":{"login":"gregswift","id":372939,"avatar_url":"https://avatars.githubusercontent.com/u/372939?v=3","gravatar_id":"","url":"https://api.github.com/users/gregswift","html_url":"https://github.com/gregswift","followers_url":"https://api.github.com/users/gregswift/followers","following_url":"https://api.github.com/users/gregswift/following{/other_user}","gists_url":"https://api.github.com/users/gregswift/gists{/gist_id}","starred_url":"https://api.github.com/users/gregswift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregswift/subscriptions","organizations_url":"https://api.github.com/users/gregswift/orgs","repos_url":"https://api.github.com/users/gregswift/repos","events_url":"https://api.github.com/users/gregswift/events{/privacy}","received_events_url":"https://api.github.com/users/gregswift/received_events","type":"User","site_admin":false},"body":"I am not totally sure I like this method, but I wanted to try preserving the majority of the existing api.  \r\n\r\nNow that I'm writing this I realize that it does break for someone who had $install_from_git set to false before.  Before I go back to try and figure out a better idea on that, what is the consensus on this method?\r\n\r\nAlso, I went and looked up the PyYAML package names for debian/RH worlds, and just added it to the main ensure package list.  I didnt see any reason why this was done, but doesn't mean there isnt a good reason.\r\n\r\n- [x] address not matching previous ```install_from_git = false``` behavior\r\n- [ ] needs testing updates\r\n- [ ] Overlaps with #10, #12, and #13","created_at":"2015-07-22T04:09:29Z","updated_at":"2015-08-10T17:26:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c08eee6fa207d25f0978ab4118bcfc1de6b9833","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/pulls/20/commits","review_comments_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/pulls/20/comments","review_comment_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/issues/20/comments","statuses_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/statuses/2f3dd36ac3b9ad6e41aa2e93421ab06fdad2d815","head":{"label":"gregswift:master","ref":"master","sha":"2f3dd36ac3b9ad6e41aa2e93421ab06fdad2d815","user":{"login":"gregswift","id":372939,"avatar_url":"https://avatars.githubusercontent.com/u/372939?v=3","gravatar_id":"","url":"https://api.github.com/users/gregswift","html_url":"https://github.com/gregswift","followers_url":"https://api.github.com/users/gregswift/followers","following_url":"https://api.github.com/users/gregswift/following{/other_user}","gists_url":"https://api.github.com/users/gregswift/gists{/gist_id}","starred_url":"https://api.github.com/users/gregswift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregswift/subscriptions","organizations_url":"https://api.github.com/users/gregswift/orgs","repos_url":"https://api.github.com/users/gregswift/repos","events_url":"https://api.github.com/users/gregswift/events{/privacy}","received_events_url":"https://api.github.com/users/gregswift/received_events","type":"User","site_admin":false},"repo":{"id":38318192,"name":"puppet-jenkins_job_builder","full_name":"gregswift/puppet-jenkins_job_builder","owner":{"login":"gregswift","id":372939,"avatar_url":"https://avatars.githubusercontent.com/u/372939?v=3","gravatar_id":"","url":"https://api.github.com/users/gregswift","html_url":"https://github.com/gregswift","followers_url":"https://api.github.com/users/gregswift/followers","following_url":"https://api.github.com/users/gregswift/following{/other_user}","gists_url":"https://api.github.com/users/gregswift/gists{/gist_id}","starred_url":"https://api.github.com/users/gregswift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregswift/subscriptions","organizations_url":"https://api.github.com/users/gregswift/orgs","repos_url":"https://api.github.com/users/gregswift/repos","events_url":"https://api.github.com/users/gregswift/events{/privacy}","received_events_url":"https://api.github.com/users/gregswift/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gregswift/puppet-jenkins_job_builder","description":"Puppet module to install OpenStack jenkins_job_builder","fork":true,"url":"https://api.github.com/repos/gregswift/puppet-jenkins_job_builder","forks_url":"https://api.github.com/repos/gregswift/puppet-jenkins_job_builder/forks","keys_url":"https://api.github.com/repos/gregswift/puppet-jenkins_job_builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gregswift/puppet-jenkins_job_builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gregswift/puppet-jenkins_job_builder/teams","hooks_url":"https://api.github.com/repos/gregswift/puppet-jenkins_job_builder/hooks","issue_events_url":"https://api.github.com/repos/gregswift/puppet-jenkins_job_builder/issues/events{/number}","events_url":"https://api.github.com/repos/gregswift/puppet-jenkins_job_builder/events","assignees_url":"https://api.github.com/repos/gregswift/puppet-jenkins_job_builder/assignees{/user}","branches_url":"https://api.github.com/repos/gregswift/puppet-jenkins_job_builder/branches{/branch}","tags_url":"https://api.github.com/repos/gregswift/puppet-jenkins_job_builder/tags","blobs_url":"https://api.github.com/repos/gregswift/puppet-jenkins_job_builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gregswift/puppet-jenkins_job_builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gregswift/puppet-jenkins_job_builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/gregswift/puppet-jenkins_job_builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gregswift/puppet-jenkins_job_builder/statuses/{sha}","languages_url":"https://api.github.com/repos/gregswift/puppet-jenkins_job_builder/languages","stargazers_url":"https://api.github.com/repos/gregswift/puppet-jenkins_job_builder/stargazers","contributors_url":"https://api.github.com/repos/gregswift/puppet-jenkins_job_builder/contributors","subscribers_url":"https://api.github.com/repos/gregswift/puppet-jenkins_job_builder/subscribers","subscription_url":"https://api.github.com/repos/gregswift/puppet-jenkins_job_builder/subscription","commits_url":"https://api.github.com/repos/gregswift/puppet-jenkins_job_builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/gregswift/puppet-jenkins_job_builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/gregswift/puppet-jenkins_job_builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/gregswift/puppet-jenkins_job_builder/issues/comments{/number}","contents_url":"https://api.github.com/repos/gregswift/puppet-jenkins_job_builder/contents/{+path}","compare_url":"https://api.github.com/repos/gregswift/puppet-jenkins_job_builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gregswift/puppet-jenkins_job_builder/merges","archive_url":"https://api.github.com/repos/gregswift/puppet-jenkins_job_builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gregswift/puppet-jenkins_job_builder/downloads","issues_url":"https://api.github.com/repos/gregswift/puppet-jenkins_job_builder/issues{/number}","pulls_url":"https://api.github.com/repos/gregswift/puppet-jenkins_job_builder/pulls{/number}","milestones_url":"https://api.github.com/repos/gregswift/puppet-jenkins_job_builder/milestones{/number}","notifications_url":"https://api.github.com/repos/gregswift/puppet-jenkins_job_builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gregswift/puppet-jenkins_job_builder/labels{/name}","releases_url":"https://api.github.com/repos/gregswift/puppet-jenkins_job_builder/releases{/id}","created_at":"2015-06-30T15:45:49Z","updated_at":"2015-06-30T15:45:49Z","pushed_at":"2015-08-10T17:26:18Z","git_url":"git://github.com/gregswift/puppet-jenkins_job_builder.git","ssh_url":"git@github.com:gregswift/puppet-jenkins_job_builder.git","clone_url":"https://github.com/gregswift/puppet-jenkins_job_builder.git","svn_url":"https://github.com/gregswift/puppet-jenkins_job_builder","homepage":"","size":128,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppet-community:master","ref":"master","sha":"2344ac3e37451924662e4d616211379f76990bf5","user":{"login":"puppet-community","id":8693967,"avatar_url":"https://avatars.githubusercontent.com/u/8693967?v=3","gravatar_id":"","url":"https://api.github.com/users/puppet-community","html_url":"https://github.com/puppet-community","followers_url":"https://api.github.com/users/puppet-community/followers","following_url":"https://api.github.com/users/puppet-community/following{/other_user}","gists_url":"https://api.github.com/users/puppet-community/gists{/gist_id}","starred_url":"https://api.github.com/users/puppet-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppet-community/subscriptions","organizations_url":"https://api.github.com/users/puppet-community/orgs","repos_url":"https://api.github.com/users/puppet-community/repos","events_url":"https://api.github.com/users/puppet-community/events{/privacy}","received_events_url":"https://api.github.com/users/puppet-community/received_events","type":"Organization","site_admin":false},"repo":{"id":20561092,"name":"puppet-jenkins_job_builder","full_name":"puppet-community/puppet-jenkins_job_builder","owner":{"login":"puppet-community","id":8693967,"avatar_url":"https://avatars.githubusercontent.com/u/8693967?v=3","gravatar_id":"","url":"https://api.github.com/users/puppet-community","html_url":"https://github.com/puppet-community","followers_url":"https://api.github.com/users/puppet-community/followers","following_url":"https://api.github.com/users/puppet-community/following{/other_user}","gists_url":"https://api.github.com/users/puppet-community/gists{/gist_id}","starred_url":"https://api.github.com/users/puppet-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppet-community/subscriptions","organizations_url":"https://api.github.com/users/puppet-community/orgs","repos_url":"https://api.github.com/users/puppet-community/repos","events_url":"https://api.github.com/users/puppet-community/events{/privacy}","received_events_url":"https://api.github.com/users/puppet-community/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppet-community/puppet-jenkins_job_builder","description":"Puppet module to install OpenStack jenkins_job_builder","fork":false,"url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder","forks_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/forks","keys_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/teams","hooks_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/hooks","issue_events_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/issues/events{/number}","events_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/events","assignees_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/assignees{/user}","branches_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/branches{/branch}","tags_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/tags","blobs_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/statuses/{sha}","languages_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/languages","stargazers_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/stargazers","contributors_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/contributors","subscribers_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/subscribers","subscription_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/subscription","commits_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/contents/{+path}","compare_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/merges","archive_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/downloads","issues_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/issues{/number}","pulls_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/pulls{/number}","milestones_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/milestones{/number}","notifications_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/labels{/name}","releases_url":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/releases{/id}","created_at":"2014-06-06T11:15:48Z","updated_at":"2015-05-13T09:15:55Z","pushed_at":"2015-08-10T17:26:20Z","git_url":"git://github.com/puppet-community/puppet-jenkins_job_builder.git","ssh_url":"git@github.com:puppet-community/puppet-jenkins_job_builder.git","clone_url":"https://github.com/puppet-community/puppet-jenkins_job_builder.git","svn_url":"https://github.com/puppet-community/puppet-jenkins_job_builder","homepage":"","size":397,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":7,"forks":13,"open_issues":7,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/pulls/20"},"html":{"href":"https://github.com/puppet-community/puppet-jenkins_job_builder/pull/20"},"issue":{"href":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/issues/20"},"comments":{"href":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/puppet-community/puppet-jenkins_job_builder/statuses/2f3dd36ac3b9ad6e41aa2e93421ab06fdad2d815"}}}}