{"action":"created","issue":{"url":"https://api.github.com/repos/Unvanquished/Unvanquished/issues/649","labels_url":"https://api.github.com/repos/Unvanquished/Unvanquished/issues/649/labels{/name}","comments_url":"https://api.github.com/repos/Unvanquished/Unvanquished/issues/649/comments","events_url":"https://api.github.com/repos/Unvanquished/Unvanquished/issues/649/events","html_url":"https://github.com/Unvanquished/Unvanquished/issues/649","id":59910627,"number":649,"title":"Overflow on BSP parsing (read after the lump length)","user":{"login":"illwieckz","id":2311649,"avatar_url":"https://avatars.githubusercontent.com/u/2311649?v=3","gravatar_id":"","url":"https://api.github.com/users/illwieckz","html_url":"https://github.com/illwieckz","followers_url":"https://api.github.com/users/illwieckz/followers","following_url":"https://api.github.com/users/illwieckz/following{/other_user}","gists_url":"https://api.github.com/users/illwieckz/gists{/gist_id}","starred_url":"https://api.github.com/users/illwieckz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/illwieckz/subscriptions","organizations_url":"https://api.github.com/users/illwieckz/orgs","repos_url":"https://api.github.com/users/illwieckz/repos","events_url":"https://api.github.com/users/illwieckz/events{/privacy}","received_events_url":"https://api.github.com/users/illwieckz/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Unvanquished/Unvanquished/labels/A-Gamelogic","name":"A-Gamelogic","color":"f7c6c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-03-05T06:21:44Z","updated_at":"2015-03-08T18:13:20Z","closed_at":null,"body":"If I (un)intentionally  forget to put a NULL character to terminate the Entities lump, the engine fails to load the BSP and prints a message like that:\r\n\r\n```\r\nError: SGame VM: G_ParseSpawnVars: found � when expecting { \r\n```\r\n\r\nSo it means the engine does not use the lump length to prevent reading outside the Entities lump if this one is not NULL terminated. Since there is no standard lump order, I can chose which lump I put right after the Entities lumps, so I can chose which lump the engine will read while overflowing."},"comment":{"url":"https://api.github.com/repos/Unvanquished/Unvanquished/issues/comments/77765232","html_url":"https://github.com/Unvanquished/Unvanquished/issues/649#issuecomment-77765232","issue_url":"https://api.github.com/repos/Unvanquished/Unvanquished/issues/649","id":77765232,"user":{"login":"Viech","id":3780206,"avatar_url":"https://avatars.githubusercontent.com/u/3780206?v=3","gravatar_id":"","url":"https://api.github.com/users/Viech","html_url":"https://github.com/Viech","followers_url":"https://api.github.com/users/Viech/followers","following_url":"https://api.github.com/users/Viech/following{/other_user}","gists_url":"https://api.github.com/users/Viech/gists{/gist_id}","starred_url":"https://api.github.com/users/Viech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Viech/subscriptions","organizations_url":"https://api.github.com/users/Viech/orgs","repos_url":"https://api.github.com/users/Viech/repos","events_url":"https://api.github.com/users/Viech/events{/privacy}","received_events_url":"https://api.github.com/users/Viech/received_events","type":"User","site_admin":false},"created_at":"2015-03-08T18:13:20Z","updated_at":"2015-03-08T18:13:20Z","body":"Please explain why it's important that the engine handles badly formatted BSPs differently or why they're properly formatted."}}