{"action":"opened","number":4298,"pull_request":{"url":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/4298","id":43228420,"html_url":"https://github.com/openframeworks/openFrameworks/pull/4298","diff_url":"https://github.com/openframeworks/openFrameworks/pull/4298.diff","patch_url":"https://github.com/openframeworks/openFrameworks/pull/4298.patch","issue_url":"https://api.github.com/repos/openframeworks/openFrameworks/issues/4298","number":4298,"state":"open","locked":false,"title":"fix #4282","user":{"login":"tgfrerer","id":423509,"avatar_url":"https://avatars.githubusercontent.com/u/423509?v=3","gravatar_id":"","url":"https://api.github.com/users/tgfrerer","html_url":"https://github.com/tgfrerer","followers_url":"https://api.github.com/users/tgfrerer/followers","following_url":"https://api.github.com/users/tgfrerer/following{/other_user}","gists_url":"https://api.github.com/users/tgfrerer/gists{/gist_id}","starred_url":"https://api.github.com/users/tgfrerer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgfrerer/subscriptions","organizations_url":"https://api.github.com/users/tgfrerer/orgs","repos_url":"https://api.github.com/users/tgfrerer/repos","events_url":"https://api.github.com/users/tgfrerer/events{/privacy}","received_events_url":"https://api.github.com/users/tgfrerer/received_events","type":"User","site_admin":false},"body":"* implements \"#pragma include\" parsing using stream ops to be independent of `std::regex` which is not yet implemented in gcc < 4.9. \r\n\r\n* remove raspberry pi specific shader linker error parsing until we have found the right compiler switches - it seems that the gcc version needs to be set in a -D flag in the makefiles - @arturoc could this affect the android target, too? The main thing I couldn't get my head around with the RPi error log parser is that it seemed to assume (hardcoded) that any error found must have occurred in the fragment shader - which may or may not be the case, and so the listing printed out might be for the wrong file if a compile error happened in the vertex shader for example\r\n\r\n* exclude raspberry from targets where shader compiler error logs are parsed for error line number. It might be worth checking on other linux targets whether gcc >=4.9, so that regex was properly supported. \r\n\r\nI've written a test case as a main.cpp to test the includes parser, you can find it here: https://gist.github.com/tgfrerer/61c352b8fe8d2269ede6","created_at":"2015-08-24T22:12:59Z","updated_at":"2015-08-24T22:12:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/4298/commits","review_comments_url":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/4298/comments","review_comment_url":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openframeworks/openFrameworks/issues/4298/comments","statuses_url":"https://api.github.com/repos/openframeworks/openFrameworks/statuses/13fecc5f2f7e5688dbfcfe5c948842b519aba483","head":{"label":"tgfrerer:fix-4282","ref":"fix-4282","sha":"13fecc5f2f7e5688dbfcfe5c948842b519aba483","user":{"login":"tgfrerer","id":423509,"avatar_url":"https://avatars.githubusercontent.com/u/423509?v=3","gravatar_id":"","url":"https://api.github.com/users/tgfrerer","html_url":"https://github.com/tgfrerer","followers_url":"https://api.github.com/users/tgfrerer/followers","following_url":"https://api.github.com/users/tgfrerer/following{/other_user}","gists_url":"https://api.github.com/users/tgfrerer/gists{/gist_id}","starred_url":"https://api.github.com/users/tgfrerer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgfrerer/subscriptions","organizations_url":"https://api.github.com/users/tgfrerer/orgs","repos_url":"https://api.github.com/users/tgfrerer/repos","events_url":"https://api.github.com/users/tgfrerer/events{/privacy}","received_events_url":"https://api.github.com/users/tgfrerer/received_events","type":"User","site_admin":false},"repo":{"id":4151696,"name":"openFrameworks","full_name":"tgfrerer/openFrameworks","owner":{"login":"tgfrerer","id":423509,"avatar_url":"https://avatars.githubusercontent.com/u/423509?v=3","gravatar_id":"","url":"https://api.github.com/users/tgfrerer","html_url":"https://github.com/tgfrerer","followers_url":"https://api.github.com/users/tgfrerer/followers","following_url":"https://api.github.com/users/tgfrerer/following{/other_user}","gists_url":"https://api.github.com/users/tgfrerer/gists{/gist_id}","starred_url":"https://api.github.com/users/tgfrerer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgfrerer/subscriptions","organizations_url":"https://api.github.com/users/tgfrerer/orgs","repos_url":"https://api.github.com/users/tgfrerer/repos","events_url":"https://api.github.com/users/tgfrerer/events{/privacy}","received_events_url":"https://api.github.com/users/tgfrerer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tgfrerer/openFrameworks","description":"OpenFrameworks is a cross platform open source toolkit for creative coding in C++.","fork":true,"url":"https://api.github.com/repos/tgfrerer/openFrameworks","forks_url":"https://api.github.com/repos/tgfrerer/openFrameworks/forks","keys_url":"https://api.github.com/repos/tgfrerer/openFrameworks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tgfrerer/openFrameworks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tgfrerer/openFrameworks/teams","hooks_url":"https://api.github.com/repos/tgfrerer/openFrameworks/hooks","issue_events_url":"https://api.github.com/repos/tgfrerer/openFrameworks/issues/events{/number}","events_url":"https://api.github.com/repos/tgfrerer/openFrameworks/events","assignees_url":"https://api.github.com/repos/tgfrerer/openFrameworks/assignees{/user}","branches_url":"https://api.github.com/repos/tgfrerer/openFrameworks/branches{/branch}","tags_url":"https://api.github.com/repos/tgfrerer/openFrameworks/tags","blobs_url":"https://api.github.com/repos/tgfrerer/openFrameworks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tgfrerer/openFrameworks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tgfrerer/openFrameworks/git/refs{/sha}","trees_url":"https://api.github.com/repos/tgfrerer/openFrameworks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tgfrerer/openFrameworks/statuses/{sha}","languages_url":"https://api.github.com/repos/tgfrerer/openFrameworks/languages","stargazers_url":"https://api.github.com/repos/tgfrerer/openFrameworks/stargazers","contributors_url":"https://api.github.com/repos/tgfrerer/openFrameworks/contributors","subscribers_url":"https://api.github.com/repos/tgfrerer/openFrameworks/subscribers","subscription_url":"https://api.github.com/repos/tgfrerer/openFrameworks/subscription","commits_url":"https://api.github.com/repos/tgfrerer/openFrameworks/commits{/sha}","git_commits_url":"https://api.github.com/repos/tgfrerer/openFrameworks/git/commits{/sha}","comments_url":"https://api.github.com/repos/tgfrerer/openFrameworks/comments{/number}","issue_comment_url":"https://api.github.com/repos/tgfrerer/openFrameworks/issues/comments{/number}","contents_url":"https://api.github.com/repos/tgfrerer/openFrameworks/contents/{+path}","compare_url":"https://api.github.com/repos/tgfrerer/openFrameworks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tgfrerer/openFrameworks/merges","archive_url":"https://api.github.com/repos/tgfrerer/openFrameworks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tgfrerer/openFrameworks/downloads","issues_url":"https://api.github.com/repos/tgfrerer/openFrameworks/issues{/number}","pulls_url":"https://api.github.com/repos/tgfrerer/openFrameworks/pulls{/number}","milestones_url":"https://api.github.com/repos/tgfrerer/openFrameworks/milestones{/number}","notifications_url":"https://api.github.com/repos/tgfrerer/openFrameworks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tgfrerer/openFrameworks/labels{/name}","releases_url":"https://api.github.com/repos/tgfrerer/openFrameworks/releases{/id}","created_at":"2012-04-26T20:07:55Z","updated_at":"2014-05-08T14:00:07Z","pushed_at":"2015-08-24T21:54:24Z","git_url":"git://github.com/tgfrerer/openFrameworks.git","ssh_url":"git@github.com:tgfrerer/openFrameworks.git","clone_url":"https://github.com/tgfrerer/openFrameworks.git","svn_url":"https://github.com/tgfrerer/openFrameworks","homepage":"http://openframeworks.cc","size":1486599,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"openframeworks:master","ref":"master","sha":"f7dfebd88db8ce145579eed383b1748de3afe171","user":{"login":"openframeworks","id":142866,"avatar_url":"https://avatars.githubusercontent.com/u/142866?v=3","gravatar_id":"","url":"https://api.github.com/users/openframeworks","html_url":"https://github.com/openframeworks","followers_url":"https://api.github.com/users/openframeworks/followers","following_url":"https://api.github.com/users/openframeworks/following{/other_user}","gists_url":"https://api.github.com/users/openframeworks/gists{/gist_id}","starred_url":"https://api.github.com/users/openframeworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openframeworks/subscriptions","organizations_url":"https://api.github.com/users/openframeworks/orgs","repos_url":"https://api.github.com/users/openframeworks/repos","events_url":"https://api.github.com/users/openframeworks/events{/privacy}","received_events_url":"https://api.github.com/users/openframeworks/received_events","type":"Organization","site_admin":false},"repo":{"id":345337,"name":"openFrameworks","full_name":"openframeworks/openFrameworks","owner":{"login":"openframeworks","id":142866,"avatar_url":"https://avatars.githubusercontent.com/u/142866?v=3","gravatar_id":"","url":"https://api.github.com/users/openframeworks","html_url":"https://github.com/openframeworks","followers_url":"https://api.github.com/users/openframeworks/followers","following_url":"https://api.github.com/users/openframeworks/following{/other_user}","gists_url":"https://api.github.com/users/openframeworks/gists{/gist_id}","starred_url":"https://api.github.com/users/openframeworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openframeworks/subscriptions","organizations_url":"https://api.github.com/users/openframeworks/orgs","repos_url":"https://api.github.com/users/openframeworks/repos","events_url":"https://api.github.com/users/openframeworks/events{/privacy}","received_events_url":"https://api.github.com/users/openframeworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openframeworks/openFrameworks","description":"OpenFrameworks is a cross platform open source toolkit for creative coding in C++.","fork":false,"url":"https://api.github.com/repos/openframeworks/openFrameworks","forks_url":"https://api.github.com/repos/openframeworks/openFrameworks/forks","keys_url":"https://api.github.com/repos/openframeworks/openFrameworks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openframeworks/openFrameworks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openframeworks/openFrameworks/teams","hooks_url":"https://api.github.com/repos/openframeworks/openFrameworks/hooks","issue_events_url":"https://api.github.com/repos/openframeworks/openFrameworks/issues/events{/number}","events_url":"https://api.github.com/repos/openframeworks/openFrameworks/events","assignees_url":"https://api.github.com/repos/openframeworks/openFrameworks/assignees{/user}","branches_url":"https://api.github.com/repos/openframeworks/openFrameworks/branches{/branch}","tags_url":"https://api.github.com/repos/openframeworks/openFrameworks/tags","blobs_url":"https://api.github.com/repos/openframeworks/openFrameworks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openframeworks/openFrameworks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openframeworks/openFrameworks/git/refs{/sha}","trees_url":"https://api.github.com/repos/openframeworks/openFrameworks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openframeworks/openFrameworks/statuses/{sha}","languages_url":"https://api.github.com/repos/openframeworks/openFrameworks/languages","stargazers_url":"https://api.github.com/repos/openframeworks/openFrameworks/stargazers","contributors_url":"https://api.github.com/repos/openframeworks/openFrameworks/contributors","subscribers_url":"https://api.github.com/repos/openframeworks/openFrameworks/subscribers","subscription_url":"https://api.github.com/repos/openframeworks/openFrameworks/subscription","commits_url":"https://api.github.com/repos/openframeworks/openFrameworks/commits{/sha}","git_commits_url":"https://api.github.com/repos/openframeworks/openFrameworks/git/commits{/sha}","comments_url":"https://api.github.com/repos/openframeworks/openFrameworks/comments{/number}","issue_comment_url":"https://api.github.com/repos/openframeworks/openFrameworks/issues/comments{/number}","contents_url":"https://api.github.com/repos/openframeworks/openFrameworks/contents/{+path}","compare_url":"https://api.github.com/repos/openframeworks/openFrameworks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openframeworks/openFrameworks/merges","archive_url":"https://api.github.com/repos/openframeworks/openFrameworks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openframeworks/openFrameworks/downloads","issues_url":"https://api.github.com/repos/openframeworks/openFrameworks/issues{/number}","pulls_url":"https://api.github.com/repos/openframeworks/openFrameworks/pulls{/number}","milestones_url":"https://api.github.com/repos/openframeworks/openFrameworks/milestones{/number}","notifications_url":"https://api.github.com/repos/openframeworks/openFrameworks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openframeworks/openFrameworks/labels{/name}","releases_url":"https://api.github.com/repos/openframeworks/openFrameworks/releases{/id}","created_at":"2009-10-21T21:55:54Z","updated_at":"2015-08-24T18:08:18Z","pushed_at":"2015-08-24T21:37:32Z","git_url":"git://github.com/openframeworks/openFrameworks.git","ssh_url":"git@github.com:openframeworks/openFrameworks.git","clone_url":"https://github.com/openframeworks/openFrameworks.git","svn_url":"https://github.com/openframeworks/openFrameworks","homepage":"http://openframeworks.cc","size":1903223,"stargazers_count":3727,"watchers_count":3727,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1357,"mirror_url":null,"open_issues_count":577,"forks":1357,"open_issues":577,"watchers":3727,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/4298"},"html":{"href":"https://github.com/openframeworks/openFrameworks/pull/4298"},"issue":{"href":"https://api.github.com/repos/openframeworks/openFrameworks/issues/4298"},"comments":{"href":"https://api.github.com/repos/openframeworks/openFrameworks/issues/4298/comments"},"review_comments":{"href":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/4298/comments"},"review_comment":{"href":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/4298/commits"},"statuses":{"href":"https://api.github.com/repos/openframeworks/openFrameworks/statuses/13fecc5f2f7e5688dbfcfe5c948842b519aba483"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":59,"deletions":29,"changed_files":1}}