{"action":"created","issue":{"url":"https://api.github.com/repos/gabesmed/ember-leaflet/issues/96","labels_url":"https://api.github.com/repos/gabesmed/ember-leaflet/issues/96/labels{/name}","comments_url":"https://api.github.com/repos/gabesmed/ember-leaflet/issues/96/comments","events_url":"https://api.github.com/repos/gabesmed/ember-leaflet/issues/96/events","html_url":"https://github.com/gabesmed/ember-leaflet/pull/96","id":58818414,"number":96,"title":"ember-cli es6 [part II]","user":{"login":"miguelcobain","id":631691,"avatar_url":"https://avatars.githubusercontent.com/u/631691?v=3","gravatar_id":"","url":"https://api.github.com/users/miguelcobain","html_url":"https://github.com/miguelcobain","followers_url":"https://api.github.com/users/miguelcobain/followers","following_url":"https://api.github.com/users/miguelcobain/following{/other_user}","gists_url":"https://api.github.com/users/miguelcobain/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelcobain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelcobain/subscriptions","organizations_url":"https://api.github.com/users/miguelcobain/orgs","repos_url":"https://api.github.com/users/miguelcobain/repos","events_url":"https://api.github.com/users/miguelcobain/events{/privacy}","received_events_url":"https://api.github.com/users/miguelcobain/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-02-24T22:48:10Z","updated_at":"2015-02-25T17:28:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gabesmed/ember-leaflet/pulls/96","html_url":"https://github.com/gabesmed/ember-leaflet/pull/96","diff_url":"https://github.com/gabesmed/ember-leaflet/pull/96.diff","patch_url":"https://github.com/gabesmed/ember-leaflet/pull/96.patch"},"body":"\r\n- [x] updated tests to conform the latest ember-cli (@twokul please fix my custom helper registration workaround)\r\n- [x] added the remaining path layers\r\n- [x] update README\r\n- [ ] port remaining tests from master\r\n- [ ] migrate source code comment docs (I didn't touch them. what will be our strategy here? A class reference is really important for Ember Leaflet since people are likely to extend our classes. Maybe this addon would be useful: https://github.com/cibernox/ember-cli-yuidoc)\r\n- [ ] is there a better way we could include leaflet **without** polluting global namespace (`L`) ?\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/gabesmed/ember-leaflet/issues/comments/76010937","html_url":"https://github.com/gabesmed/ember-leaflet/pull/96#issuecomment-76010937","issue_url":"https://api.github.com/repos/gabesmed/ember-leaflet/issues/96","id":76010937,"user":{"login":"gabesmed","id":83913,"avatar_url":"https://avatars.githubusercontent.com/u/83913?v=3","gravatar_id":"","url":"https://api.github.com/users/gabesmed","html_url":"https://github.com/gabesmed","followers_url":"https://api.github.com/users/gabesmed/followers","following_url":"https://api.github.com/users/gabesmed/following{/other_user}","gists_url":"https://api.github.com/users/gabesmed/gists{/gist_id}","starred_url":"https://api.github.com/users/gabesmed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabesmed/subscriptions","organizations_url":"https://api.github.com/users/gabesmed/orgs","repos_url":"https://api.github.com/users/gabesmed/repos","events_url":"https://api.github.com/users/gabesmed/events{/privacy}","received_events_url":"https://api.github.com/users/gabesmed/received_events","type":"User","site_admin":false},"created_at":"2015-02-25T17:28:39Z","updated_at":"2015-02-25T17:28:39Z","body":"Yeah I knowm there aren't really any good unit tests for the layers. Instead everything's a full functional test including Leaflet functionality.\r\n\r\nThe right way to do this would be to mock out the Leaflet library and the EmberLeaflet component, and just make sure the layer class makes the right function calls.\r\n\r\nBut practically, I still think we'd want a full set of functional tests to also ensure that the integration stays working, especially for when we upgrade ember versions, leaflet versions, etc.\r\n\r\nSo not sure what to do here -- if people have a lot of time, we could explore re-writing the tests. But the fastest way through the es6 module conversion I think would be keep the functional test suite as-is, and improve the test methodology after the conversion is done?"}}