{"action":"created","comment":{"url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/comments/39811287","id":39811287,"diff_hunk":"@@ -913,7 +913,35 @@ public func zip<S: SequenceType, T, Error where S.Generator.Element == SignalPro\n \treturn .empty\n }\n \n+extension SignalProducer where T: SignalProducerType, E == T.E {\n+\t/// Flattens the inner producers sent upon `producer` (into a single producer of\n+\t/// values), according to the semantics of the given strategy.\n+\t///\n+\t/// If `producer` or an active inner producer emits an error, the returned\n+\t/// producer will forward that error immediately.\n+\t///\n+\t/// `Interrupted` events on inner producers will be treated like `Completed`\n+\t/// events on inner producers.\n+\t@warn_unused_result(message=\"Did you forget to call `start` on the producer?\")\n+\tpublic func flatten(strategy: FlattenStrategy) -> SignalProducer<T.T, E> {","path":"ReactiveCocoa/Swift/SignalProducer.swift","position":14,"original_position":14,"commit_id":"dd73e90c48a2de2cf17c59f0249697b9af82a459","original_commit_id":"dd73e90c48a2de2cf17c59f0249697b9af82a459","user":{"login":"neilpa","id":42419,"avatar_url":"https://avatars.githubusercontent.com/u/42419?v=3","gravatar_id":"","url":"https://api.github.com/users/neilpa","html_url":"https://github.com/neilpa","followers_url":"https://api.github.com/users/neilpa/followers","following_url":"https://api.github.com/users/neilpa/following{/other_user}","gists_url":"https://api.github.com/users/neilpa/gists{/gist_id}","starred_url":"https://api.github.com/users/neilpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neilpa/subscriptions","organizations_url":"https://api.github.com/users/neilpa/orgs","repos_url":"https://api.github.com/users/neilpa/repos","events_url":"https://api.github.com/users/neilpa/events{/privacy}","received_events_url":"https://api.github.com/users/neilpa/received_events","type":"User","site_admin":false},"body":"If it does work, you should also be able to change `filterNil` because that was the other problem operator.","created_at":"2015-09-17T23:29:29Z","updated_at":"2015-09-17T23:29:29Z","html_url":"https://github.com/ReactiveCocoa/ReactiveCocoa/pull/2380#discussion_r39811287","pull_request_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/2380","_links":{"self":{"href":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/comments/39811287"},"html":{"href":"https://github.com/ReactiveCocoa/ReactiveCocoa/pull/2380#discussion_r39811287"},"pull_request":{"href":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/2380"}}},"pull_request":{"url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/2380","id":45353593,"html_url":"https://github.com/ReactiveCocoa/ReactiveCocoa/pull/2380","diff_url":"https://github.com/ReactiveCocoa/ReactiveCocoa/pull/2380.diff","patch_url":"https://github.com/ReactiveCocoa/ReactiveCocoa/pull/2380.patch","issue_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues/2380","number":2380,"state":"open","locked":false,"title":"Moved flatMap intro SignalProducerType extension.","user":{"login":"nikita-leonov","id":991541,"avatar_url":"https://avatars.githubusercontent.com/u/991541?v=3","gravatar_id":"","url":"https://api.github.com/users/nikita-leonov","html_url":"https://github.com/nikita-leonov","followers_url":"https://api.github.com/users/nikita-leonov/followers","following_url":"https://api.github.com/users/nikita-leonov/following{/other_user}","gists_url":"https://api.github.com/users/nikita-leonov/gists{/gist_id}","starred_url":"https://api.github.com/users/nikita-leonov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikita-leonov/subscriptions","organizations_url":"https://api.github.com/users/nikita-leonov/orgs","repos_url":"https://api.github.com/users/nikita-leonov/repos","events_url":"https://api.github.com/users/nikita-leonov/events{/privacy}","received_events_url":"https://api.github.com/users/nikita-leonov/received_events","type":"User","site_admin":false},"body":"According to @neilpa message in #2377 there was language and compiler limitations that didn't allowed this before. On a Xcode 7.0 (7A220) it complies well and all unit-tests are passing. Does it mean it can me merged in, or there is a special case that still may crash such implementation?","created_at":"2015-09-17T23:16:13Z","updated_at":"2015-09-17T23:29:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc98ee0817d8f8f778d128a0a3ad80789a2706b1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/2380/commits","review_comments_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/2380/comments","review_comment_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues/2380/comments","statuses_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/statuses/dd73e90c48a2de2cf17c59f0249697b9af82a459","head":{"label":"nikita-leonov:fix-flatMap-signalProducerType","ref":"fix-flatMap-signalProducerType","sha":"dd73e90c48a2de2cf17c59f0249697b9af82a459","user":{"login":"nikita-leonov","id":991541,"avatar_url":"https://avatars.githubusercontent.com/u/991541?v=3","gravatar_id":"","url":"https://api.github.com/users/nikita-leonov","html_url":"https://github.com/nikita-leonov","followers_url":"https://api.github.com/users/nikita-leonov/followers","following_url":"https://api.github.com/users/nikita-leonov/following{/other_user}","gists_url":"https://api.github.com/users/nikita-leonov/gists{/gist_id}","starred_url":"https://api.github.com/users/nikita-leonov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikita-leonov/subscriptions","organizations_url":"https://api.github.com/users/nikita-leonov/orgs","repos_url":"https://api.github.com/users/nikita-leonov/repos","events_url":"https://api.github.com/users/nikita-leonov/events{/privacy}","received_events_url":"https://api.github.com/users/nikita-leonov/received_events","type":"User","site_admin":false},"repo":{"id":42618010,"name":"ReactiveCocoa","full_name":"nikita-leonov/ReactiveCocoa","owner":{"login":"nikita-leonov","id":991541,"avatar_url":"https://avatars.githubusercontent.com/u/991541?v=3","gravatar_id":"","url":"https://api.github.com/users/nikita-leonov","html_url":"https://github.com/nikita-leonov","followers_url":"https://api.github.com/users/nikita-leonov/followers","following_url":"https://api.github.com/users/nikita-leonov/following{/other_user}","gists_url":"https://api.github.com/users/nikita-leonov/gists{/gist_id}","starred_url":"https://api.github.com/users/nikita-leonov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikita-leonov/subscriptions","organizations_url":"https://api.github.com/users/nikita-leonov/orgs","repos_url":"https://api.github.com/users/nikita-leonov/repos","events_url":"https://api.github.com/users/nikita-leonov/events{/privacy}","received_events_url":"https://api.github.com/users/nikita-leonov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nikita-leonov/ReactiveCocoa","description":"Streams of values over time","fork":true,"url":"https://api.github.com/repos/nikita-leonov/ReactiveCocoa","forks_url":"https://api.github.com/repos/nikita-leonov/ReactiveCocoa/forks","keys_url":"https://api.github.com/repos/nikita-leonov/ReactiveCocoa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nikita-leonov/ReactiveCocoa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nikita-leonov/ReactiveCocoa/teams","hooks_url":"https://api.github.com/repos/nikita-leonov/ReactiveCocoa/hooks","issue_events_url":"https://api.github.com/repos/nikita-leonov/ReactiveCocoa/issues/events{/number}","events_url":"https://api.github.com/repos/nikita-leonov/ReactiveCocoa/events","assignees_url":"https://api.github.com/repos/nikita-leonov/ReactiveCocoa/assignees{/user}","branches_url":"https://api.github.com/repos/nikita-leonov/ReactiveCocoa/branches{/branch}","tags_url":"https://api.github.com/repos/nikita-leonov/ReactiveCocoa/tags","blobs_url":"https://api.github.com/repos/nikita-leonov/ReactiveCocoa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nikita-leonov/ReactiveCocoa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nikita-leonov/ReactiveCocoa/git/refs{/sha}","trees_url":"https://api.github.com/repos/nikita-leonov/ReactiveCocoa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nikita-leonov/ReactiveCocoa/statuses/{sha}","languages_url":"https://api.github.com/repos/nikita-leonov/ReactiveCocoa/languages","stargazers_url":"https://api.github.com/repos/nikita-leonov/ReactiveCocoa/stargazers","contributors_url":"https://api.github.com/repos/nikita-leonov/ReactiveCocoa/contributors","subscribers_url":"https://api.github.com/repos/nikita-leonov/ReactiveCocoa/subscribers","subscription_url":"https://api.github.com/repos/nikita-leonov/ReactiveCocoa/subscription","commits_url":"https://api.github.com/repos/nikita-leonov/ReactiveCocoa/commits{/sha}","git_commits_url":"https://api.github.com/repos/nikita-leonov/ReactiveCocoa/git/commits{/sha}","comments_url":"https://api.github.com/repos/nikita-leonov/ReactiveCocoa/comments{/number}","issue_comment_url":"https://api.github.com/repos/nikita-leonov/ReactiveCocoa/issues/comments{/number}","contents_url":"https://api.github.com/repos/nikita-leonov/ReactiveCocoa/contents/{+path}","compare_url":"https://api.github.com/repos/nikita-leonov/ReactiveCocoa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nikita-leonov/ReactiveCocoa/merges","archive_url":"https://api.github.com/repos/nikita-leonov/ReactiveCocoa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nikita-leonov/ReactiveCocoa/downloads","issues_url":"https://api.github.com/repos/nikita-leonov/ReactiveCocoa/issues{/number}","pulls_url":"https://api.github.com/repos/nikita-leonov/ReactiveCocoa/pulls{/number}","milestones_url":"https://api.github.com/repos/nikita-leonov/ReactiveCocoa/milestones{/number}","notifications_url":"https://api.github.com/repos/nikita-leonov/ReactiveCocoa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nikita-leonov/ReactiveCocoa/labels{/name}","releases_url":"https://api.github.com/repos/nikita-leonov/ReactiveCocoa/releases{/id}","created_at":"2015-09-16T23:05:00Z","updated_at":"2015-09-16T23:05:03Z","pushed_at":"2015-09-17T23:14:16Z","git_url":"git://github.com/nikita-leonov/ReactiveCocoa.git","ssh_url":"git@github.com:nikita-leonov/ReactiveCocoa.git","clone_url":"https://github.com/nikita-leonov/ReactiveCocoa.git","svn_url":"https://github.com/nikita-leonov/ReactiveCocoa","homepage":"","size":29021,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ReactiveCocoa:swift2","ref":"swift2","sha":"3895941c1a79615b79b3b56fbf635bf4d1cfd2b8","user":{"login":"ReactiveCocoa","id":3422977,"avatar_url":"https://avatars.githubusercontent.com/u/3422977?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveCocoa","html_url":"https://github.com/ReactiveCocoa","followers_url":"https://api.github.com/users/ReactiveCocoa/followers","following_url":"https://api.github.com/users/ReactiveCocoa/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveCocoa/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveCocoa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveCocoa/subscriptions","organizations_url":"https://api.github.com/users/ReactiveCocoa/orgs","repos_url":"https://api.github.com/users/ReactiveCocoa/repos","events_url":"https://api.github.com/users/ReactiveCocoa/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveCocoa/received_events","type":"Organization","site_admin":false},"repo":{"id":3606624,"name":"ReactiveCocoa","full_name":"ReactiveCocoa/ReactiveCocoa","owner":{"login":"ReactiveCocoa","id":3422977,"avatar_url":"https://avatars.githubusercontent.com/u/3422977?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveCocoa","html_url":"https://github.com/ReactiveCocoa","followers_url":"https://api.github.com/users/ReactiveCocoa/followers","following_url":"https://api.github.com/users/ReactiveCocoa/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveCocoa/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveCocoa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveCocoa/subscriptions","organizations_url":"https://api.github.com/users/ReactiveCocoa/orgs","repos_url":"https://api.github.com/users/ReactiveCocoa/repos","events_url":"https://api.github.com/users/ReactiveCocoa/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveCocoa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReactiveCocoa/ReactiveCocoa","description":"Streams of values over time","fork":false,"url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa","forks_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/forks","keys_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/teams","hooks_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/hooks","issue_events_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues/events{/number}","events_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/events","assignees_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/assignees{/user}","branches_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/branches{/branch}","tags_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/tags","blobs_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/statuses/{sha}","languages_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/languages","stargazers_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/stargazers","contributors_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/contributors","subscribers_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/subscribers","subscription_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/subscription","commits_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/contents/{+path}","compare_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/merges","archive_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/downloads","issues_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues{/number}","pulls_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls{/number}","milestones_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/milestones{/number}","notifications_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/labels{/name}","releases_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/releases{/id}","created_at":"2012-03-02T22:11:24Z","updated_at":"2015-09-17T16:42:46Z","pushed_at":"2015-09-17T23:16:14Z","git_url":"git://github.com/ReactiveCocoa/ReactiveCocoa.git","ssh_url":"git@github.com:ReactiveCocoa/ReactiveCocoa.git","clone_url":"https://github.com/ReactiveCocoa/ReactiveCocoa.git","svn_url":"https://github.com/ReactiveCocoa/ReactiveCocoa","homepage":"","size":29021,"stargazers_count":10225,"watchers_count":10225,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1707,"mirror_url":null,"open_issues_count":163,"forks":1707,"open_issues":163,"watchers":10225,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/2380"},"html":{"href":"https://github.com/ReactiveCocoa/ReactiveCocoa/pull/2380"},"issue":{"href":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues/2380"},"comments":{"href":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues/2380/comments"},"review_comments":{"href":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/2380/comments"},"review_comment":{"href":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/2380/commits"},"statuses":{"href":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/statuses/dd73e90c48a2de2cf17c59f0249697b9af82a459"}}}}