{"action":"created","comment":{"url":"https://api.github.com/repos/genome/genome/pulls/comments/28691706","id":28691706,"diff_hunk":"@@ -65,3 +70,27 @@ sub name {\n sub result_class {\n     'Genome::VariantReporting::Suite::Vep::RunResult';\n }\n+\n+sub __planned_errors__ {\n+    my ($self, $params) = @_;\n+    my $version = $params->{joinx_version};\n+    my $allow_same_file = $params->{allow_same_file};\n+    return $self->SUPER::__planned_errors__($params), $self->_get_joinx_version_error($version, $allow_same_file);\n+}\n+\n+sub _get_joinx_version_error {\n+    my ($self, $version, $allow_same_file) = @_;\n+\n+    my @errors;\n+    if ($allow_same_file && (version->parse(\"v\".$version) < version->parse(\"v1.11\"))) {\n+        push @errors, UR::Object::Tag->create(\n+            type => 'error',\n+            properties => ['joinx_version'],\n+            desc => \"Provided parameter joinx_version: $version not supporting allow-same--file option, use 1.11 and above\",","path":"lib/perl/Genome/VariantReporting/Suite/Vep/Run.pm","position":32,"original_position":32,"commit_id":"52dad2e2fb6e581f246a96a1f8a481e019436779","original_commit_id":"52dad2e2fb6e581f246a96a1f8a481e019436779","user":{"login":"tmooney","id":187262,"avatar_url":"https://avatars.githubusercontent.com/u/187262?v=3","gravatar_id":"","url":"https://api.github.com/users/tmooney","html_url":"https://github.com/tmooney","followers_url":"https://api.github.com/users/tmooney/followers","following_url":"https://api.github.com/users/tmooney/following{/other_user}","gists_url":"https://api.github.com/users/tmooney/gists{/gist_id}","starred_url":"https://api.github.com/users/tmooney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmooney/subscriptions","organizations_url":"https://api.github.com/users/tmooney/orgs","repos_url":"https://api.github.com/users/tmooney/repos","events_url":"https://api.github.com/users/tmooney/events{/privacy}","received_events_url":"https://api.github.com/users/tmooney/received_events","type":"User","site_admin":false},"body":"There's an extra `-` between `same` and `file`.  (Also, `does not support the` might sound better than `not supporting` here).\r\n","created_at":"2015-04-20T14:12:26Z","updated_at":"2015-04-20T14:12:26Z","html_url":"https://github.com/genome/genome/pull/672#discussion_r28691706","pull_request_url":"https://api.github.com/repos/genome/genome/pulls/672","_links":{"self":{"href":"https://api.github.com/repos/genome/genome/pulls/comments/28691706"},"html":{"href":"https://github.com/genome/genome/pull/672#discussion_r28691706"},"pull_request":{"href":"https://api.github.com/repos/genome/genome/pulls/672"}}},"pull_request":{"url":"https://api.github.com/repos/genome/genome/pulls/672","id":33553476,"html_url":"https://github.com/genome/genome/pull/672","diff_url":"https://github.com/genome/genome/pull/672.diff","patch_url":"https://github.com/genome/genome/pull/672.patch","issue_url":"https://api.github.com/repos/genome/genome/issues/672","number":672,"state":"open","locked":false,"title":"Add gene annotations to the DoCM report and remove the trio.t test","user":{"login":"susannasiebert","id":6617192,"avatar_url":"https://avatars.githubusercontent.com/u/6617192?v=3","gravatar_id":"","url":"https://api.github.com/users/susannasiebert","html_url":"https://github.com/susannasiebert","followers_url":"https://api.github.com/users/susannasiebert/followers","following_url":"https://api.github.com/users/susannasiebert/following{/other_user}","gists_url":"https://api.github.com/users/susannasiebert/gists{/gist_id}","starred_url":"https://api.github.com/users/susannasiebert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/susannasiebert/subscriptions","organizations_url":"https://api.github.com/users/susannasiebert/orgs","repos_url":"https://api.github.com/users/susannasiebert/repos","events_url":"https://api.github.com/users/susannasiebert/events{/privacy}","received_events_url":"https://api.github.com/users/susannasiebert/received_events","type":"User","site_admin":false},"body":"The trio.t test has been superseded by the trio_main process test on jenkins which is a deployment blocking step now. ","created_at":"2015-04-17T15:13:07Z","updated_at":"2015-04-20T14:12:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"26f5c332c86449015a069962e883d43f32792012","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/genome/genome/pulls/672/commits","review_comments_url":"https://api.github.com/repos/genome/genome/pulls/672/comments","review_comment_url":"https://api.github.com/repos/genome/genome/pulls/comments{/number}","comments_url":"https://api.github.com/repos/genome/genome/issues/672/comments","statuses_url":"https://api.github.com/repos/genome/genome/statuses/52dad2e2fb6e581f246a96a1f8a481e019436779","head":{"label":"susannasiebert:variant_reporting_docm","ref":"variant_reporting_docm","sha":"52dad2e2fb6e581f246a96a1f8a481e019436779","user":{"login":"susannasiebert","id":6617192,"avatar_url":"https://avatars.githubusercontent.com/u/6617192?v=3","gravatar_id":"","url":"https://api.github.com/users/susannasiebert","html_url":"https://github.com/susannasiebert","followers_url":"https://api.github.com/users/susannasiebert/followers","following_url":"https://api.github.com/users/susannasiebert/following{/other_user}","gists_url":"https://api.github.com/users/susannasiebert/gists{/gist_id}","starred_url":"https://api.github.com/users/susannasiebert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/susannasiebert/subscriptions","organizations_url":"https://api.github.com/users/susannasiebert/orgs","repos_url":"https://api.github.com/users/susannasiebert/repos","events_url":"https://api.github.com/users/susannasiebert/events{/privacy}","received_events_url":"https://api.github.com/users/susannasiebert/received_events","type":"User","site_admin":false},"repo":{"id":23836901,"name":"genome","full_name":"susannasiebert/genome","owner":{"login":"susannasiebert","id":6617192,"avatar_url":"https://avatars.githubusercontent.com/u/6617192?v=3","gravatar_id":"","url":"https://api.github.com/users/susannasiebert","html_url":"https://github.com/susannasiebert","followers_url":"https://api.github.com/users/susannasiebert/followers","following_url":"https://api.github.com/users/susannasiebert/following{/other_user}","gists_url":"https://api.github.com/users/susannasiebert/gists{/gist_id}","starred_url":"https://api.github.com/users/susannasiebert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/susannasiebert/subscriptions","organizations_url":"https://api.github.com/users/susannasiebert/orgs","repos_url":"https://api.github.com/users/susannasiebert/repos","events_url":"https://api.github.com/users/susannasiebert/events{/privacy}","received_events_url":"https://api.github.com/users/susannasiebert/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/susannasiebert/genome","description":"","fork":true,"url":"https://api.github.com/repos/susannasiebert/genome","forks_url":"https://api.github.com/repos/susannasiebert/genome/forks","keys_url":"https://api.github.com/repos/susannasiebert/genome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/susannasiebert/genome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/susannasiebert/genome/teams","hooks_url":"https://api.github.com/repos/susannasiebert/genome/hooks","issue_events_url":"https://api.github.com/repos/susannasiebert/genome/issues/events{/number}","events_url":"https://api.github.com/repos/susannasiebert/genome/events","assignees_url":"https://api.github.com/repos/susannasiebert/genome/assignees{/user}","branches_url":"https://api.github.com/repos/susannasiebert/genome/branches{/branch}","tags_url":"https://api.github.com/repos/susannasiebert/genome/tags","blobs_url":"https://api.github.com/repos/susannasiebert/genome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/susannasiebert/genome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/susannasiebert/genome/git/refs{/sha}","trees_url":"https://api.github.com/repos/susannasiebert/genome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/susannasiebert/genome/statuses/{sha}","languages_url":"https://api.github.com/repos/susannasiebert/genome/languages","stargazers_url":"https://api.github.com/repos/susannasiebert/genome/stargazers","contributors_url":"https://api.github.com/repos/susannasiebert/genome/contributors","subscribers_url":"https://api.github.com/repos/susannasiebert/genome/subscribers","subscription_url":"https://api.github.com/repos/susannasiebert/genome/subscription","commits_url":"https://api.github.com/repos/susannasiebert/genome/commits{/sha}","git_commits_url":"https://api.github.com/repos/susannasiebert/genome/git/commits{/sha}","comments_url":"https://api.github.com/repos/susannasiebert/genome/comments{/number}","issue_comment_url":"https://api.github.com/repos/susannasiebert/genome/issues/comments{/number}","contents_url":"https://api.github.com/repos/susannasiebert/genome/contents/{+path}","compare_url":"https://api.github.com/repos/susannasiebert/genome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/susannasiebert/genome/merges","archive_url":"https://api.github.com/repos/susannasiebert/genome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/susannasiebert/genome/downloads","issues_url":"https://api.github.com/repos/susannasiebert/genome/issues{/number}","pulls_url":"https://api.github.com/repos/susannasiebert/genome/pulls{/number}","milestones_url":"https://api.github.com/repos/susannasiebert/genome/milestones{/number}","notifications_url":"https://api.github.com/repos/susannasiebert/genome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/susannasiebert/genome/labels{/name}","releases_url":"https://api.github.com/repos/susannasiebert/genome/releases{/id}","created_at":"2014-09-09T14:30:47Z","updated_at":"2014-09-10T06:51:41Z","pushed_at":"2015-04-17T15:46:43Z","git_url":"git://github.com/susannasiebert/genome.git","ssh_url":"git@github.com:susannasiebert/genome.git","clone_url":"https://github.com/susannasiebert/genome.git","svn_url":"https://github.com/susannasiebert/genome","homepage":"","size":116242,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"genome:master","ref":"master","sha":"7ad2793b1cb9d0fc522197702469ec9116406c57","user":{"login":"genome","id":318108,"avatar_url":"https://avatars.githubusercontent.com/u/318108?v=3","gravatar_id":"","url":"https://api.github.com/users/genome","html_url":"https://github.com/genome","followers_url":"https://api.github.com/users/genome/followers","following_url":"https://api.github.com/users/genome/following{/other_user}","gists_url":"https://api.github.com/users/genome/gists{/gist_id}","starred_url":"https://api.github.com/users/genome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genome/subscriptions","organizations_url":"https://api.github.com/users/genome/orgs","repos_url":"https://api.github.com/users/genome/repos","events_url":"https://api.github.com/users/genome/events{/privacy}","received_events_url":"https://api.github.com/users/genome/received_events","type":"Organization","site_admin":false},"repo":{"id":23442737,"name":"genome","full_name":"genome/genome","owner":{"login":"genome","id":318108,"avatar_url":"https://avatars.githubusercontent.com/u/318108?v=3","gravatar_id":"","url":"https://api.github.com/users/genome","html_url":"https://github.com/genome","followers_url":"https://api.github.com/users/genome/followers","following_url":"https://api.github.com/users/genome/following{/other_user}","gists_url":"https://api.github.com/users/genome/gists{/gist_id}","starred_url":"https://api.github.com/users/genome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genome/subscriptions","organizations_url":"https://api.github.com/users/genome/orgs","repos_url":"https://api.github.com/users/genome/repos","events_url":"https://api.github.com/users/genome/events{/privacy}","received_events_url":"https://api.github.com/users/genome/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/genome/genome","description":"Core modules used by the GMS","fork":false,"url":"https://api.github.com/repos/genome/genome","forks_url":"https://api.github.com/repos/genome/genome/forks","keys_url":"https://api.github.com/repos/genome/genome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/genome/genome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/genome/genome/teams","hooks_url":"https://api.github.com/repos/genome/genome/hooks","issue_events_url":"https://api.github.com/repos/genome/genome/issues/events{/number}","events_url":"https://api.github.com/repos/genome/genome/events","assignees_url":"https://api.github.com/repos/genome/genome/assignees{/user}","branches_url":"https://api.github.com/repos/genome/genome/branches{/branch}","tags_url":"https://api.github.com/repos/genome/genome/tags","blobs_url":"https://api.github.com/repos/genome/genome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/genome/genome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/genome/genome/git/refs{/sha}","trees_url":"https://api.github.com/repos/genome/genome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/genome/genome/statuses/{sha}","languages_url":"https://api.github.com/repos/genome/genome/languages","stargazers_url":"https://api.github.com/repos/genome/genome/stargazers","contributors_url":"https://api.github.com/repos/genome/genome/contributors","subscribers_url":"https://api.github.com/repos/genome/genome/subscribers","subscription_url":"https://api.github.com/repos/genome/genome/subscription","commits_url":"https://api.github.com/repos/genome/genome/commits{/sha}","git_commits_url":"https://api.github.com/repos/genome/genome/git/commits{/sha}","comments_url":"https://api.github.com/repos/genome/genome/comments{/number}","issue_comment_url":"https://api.github.com/repos/genome/genome/issues/comments{/number}","contents_url":"https://api.github.com/repos/genome/genome/contents/{+path}","compare_url":"https://api.github.com/repos/genome/genome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/genome/genome/merges","archive_url":"https://api.github.com/repos/genome/genome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/genome/genome/downloads","issues_url":"https://api.github.com/repos/genome/genome/issues{/number}","pulls_url":"https://api.github.com/repos/genome/genome/pulls{/number}","milestones_url":"https://api.github.com/repos/genome/genome/milestones{/number}","notifications_url":"https://api.github.com/repos/genome/genome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/genome/genome/labels{/name}","releases_url":"https://api.github.com/repos/genome/genome/releases{/id}","created_at":"2014-08-28T20:59:19Z","updated_at":"2015-04-20T13:47:59Z","pushed_at":"2015-04-20T13:56:28Z","git_url":"git://github.com/genome/genome.git","ssh_url":"git@github.com:genome/genome.git","clone_url":"https://github.com/genome/genome.git","svn_url":"https://github.com/genome/genome","homepage":"","size":140716,"stargazers_count":8,"watchers_count":8,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":10,"forks":36,"open_issues":10,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/genome/genome/pulls/672"},"html":{"href":"https://github.com/genome/genome/pull/672"},"issue":{"href":"https://api.github.com/repos/genome/genome/issues/672"},"comments":{"href":"https://api.github.com/repos/genome/genome/issues/672/comments"},"review_comments":{"href":"https://api.github.com/repos/genome/genome/pulls/672/comments"},"review_comment":{"href":"https://api.github.com/repos/genome/genome/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/genome/genome/pulls/672/commits"},"statuses":{"href":"https://api.github.com/repos/genome/genome/statuses/52dad2e2fb6e581f246a96a1f8a481e019436779"}}}}