{"action":"created","issue":{"url":"https://api.github.com/repos/benbaptist/minecraft-wrapper/issues/179","labels_url":"https://api.github.com/repos/benbaptist/minecraft-wrapper/issues/179/labels{/name}","comments_url":"https://api.github.com/repos/benbaptist/minecraft-wrapper/issues/179/comments","events_url":"https://api.github.com/repos/benbaptist/minecraft-wrapper/issues/179/events","html_url":"https://github.com/benbaptist/minecraft-wrapper/issues/179","id":69080270,"number":179,"title":"Problem in player.setResourcePack(self, url)","user":{"login":"hespanha","id":11984821,"avatar_url":"https://avatars.githubusercontent.com/u/11984821?v=3","gravatar_id":"","url":"https://api.github.com/users/hespanha","html_url":"https://github.com/hespanha","followers_url":"https://api.github.com/users/hespanha/followers","following_url":"https://api.github.com/users/hespanha/following{/other_user}","gists_url":"https://api.github.com/users/hespanha/gists{/gist_id}","starred_url":"https://api.github.com/users/hespanha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hespanha/subscriptions","organizations_url":"https://api.github.com/users/hespanha/orgs","repos_url":"https://api.github.com/users/hespanha/repos","events_url":"https://api.github.com/users/hespanha/events{/privacy}","received_events_url":"https://api.github.com/users/hespanha/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/benbaptist/minecraft-wrapper/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/benbaptist/minecraft-wrapper/labels/emergency","name":"emergency","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-17T06:59:22Z","updated_at":"2015-04-17T07:33:57Z","closed_at":null,"body":"The method setResourcePack() in the class Player, does not seem to work out. I believe the fix is to replace line 84 of player.py \r\n    self.client.send(0x3f, \"string|bytearray\", (\"MC|RPack\", url))\r\nby either\r\n   self.client.send(0x3f, \"string|bytearray_short\", (\"MC|RPack\", url))\r\nfor the server 1.7.10, or by\r\n   player.client.send(0x48, \"string|string\", (url,\"\")) \r\nfor the server 1.8.3.\r\n\r\nThis brings up the issue that the \"pre-1.7-mode\" variable in wrapper.properties is not quite adequate.\r\n Instead, one may need a variable \"server-version\" that can have 3 values: \"pre-1.7\", \"1.7\", and \"1.8\" "},"comment":{"url":"https://api.github.com/repos/benbaptist/minecraft-wrapper/issues/comments/93934848","html_url":"https://github.com/benbaptist/minecraft-wrapper/issues/179#issuecomment-93934848","issue_url":"https://api.github.com/repos/benbaptist/minecraft-wrapper/issues/179","id":93934848,"user":{"login":"benbaptist","id":353809,"avatar_url":"https://avatars.githubusercontent.com/u/353809?v=3","gravatar_id":"","url":"https://api.github.com/users/benbaptist","html_url":"https://github.com/benbaptist","followers_url":"https://api.github.com/users/benbaptist/followers","following_url":"https://api.github.com/users/benbaptist/following{/other_user}","gists_url":"https://api.github.com/users/benbaptist/gists{/gist_id}","starred_url":"https://api.github.com/users/benbaptist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benbaptist/subscriptions","organizations_url":"https://api.github.com/users/benbaptist/orgs","repos_url":"https://api.github.com/users/benbaptist/repos","events_url":"https://api.github.com/users/benbaptist/events{/privacy}","received_events_url":"https://api.github.com/users/benbaptist/received_events","type":"User","site_admin":false},"created_at":"2015-04-17T07:33:57Z","updated_at":"2015-04-17T07:33:57Z","body":"Ohai! \r\n\r\nYeah, I accepted pull request #178 in but it apparently never actually pulled in (I always git merge manually). As for the pre-1.7 mode thing, that setting is only used for parsing the console text. In 1.7, the console output was changed quite a bit and so I had to make a new setting to allow pre-1.7 compatibility. This setting does not affect the proxy mode in any way - it uses protocol versions and automatically switches between 1.7 and 1.8 without an issue. 1.6 doesn't matter anyways - proxy mode doesn't support it as it's far more difficult to implement and the userbase for it is probably so small that it wouldn't matter much. \r\n\r\nI'm about to push my changes, so this should be fixed! Thanks for the report."}}