{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/logstash/pulls/comments/46444591","id":46444591,"diff_hunk":"@@ -0,0 +1,65 @@\n+# encoding: utf-8\n+require \"logstash/agent\"\n+\n+module LogStash module AgentPluginManager\n+  DEFAULT_AGENT_NAME = :default\n+  class DuplicatePluginNameError < Error; end\n+\n+  REGISTRY = {}\n+\n+  # Reset plugin registry to just the default plugin\n+  def self.reset!\n+    REGISTRY.clear\n+    REGISTRY[DEFAULT_AGENT_NAME] = LogStash::Agent\n+  end\n+\n+  reset!","path":"logstash-core/lib/logstash/agent_plugin_manager.rb","position":16,"original_position":16,"commit_id":"ea179ab158d68cadabf48bd5e2db6bcd6f275089","original_commit_id":"ea179ab158d68cadabf48bd5e2db6bcd6f275089","user":{"login":"purbon","id":68540,"avatar_url":"https://avatars.githubusercontent.com/u/68540?v=3","gravatar_id":"","url":"https://api.github.com/users/purbon","html_url":"https://github.com/purbon","followers_url":"https://api.github.com/users/purbon/followers","following_url":"https://api.github.com/users/purbon/following{/other_user}","gists_url":"https://api.github.com/users/purbon/gists{/gist_id}","starred_url":"https://api.github.com/users/purbon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purbon/subscriptions","organizations_url":"https://api.github.com/users/purbon/orgs","repos_url":"https://api.github.com/users/purbon/repos","events_url":"https://api.github.com/users/purbon/events{/privacy}","received_events_url":"https://api.github.com/users/purbon/received_events","type":"User","site_admin":false},"body":"Lets discuss about it, for sure. But we should definitely not do this kind of things as then errors are very complicated to find out. So yeah, look for another person to remove the conflict, but -1 from my side to this kind of constructs. ","created_at":"2015-12-02T17:21:36Z","updated_at":"2015-12-02T17:21:36Z","html_url":"https://github.com/elastic/logstash/pull/4194#discussion_r46444591","pull_request_url":"https://api.github.com/repos/elastic/logstash/pulls/4194","_links":{"self":{"href":"https://api.github.com/repos/elastic/logstash/pulls/comments/46444591"},"html":{"href":"https://github.com/elastic/logstash/pull/4194#discussion_r46444591"},"pull_request":{"href":"https://api.github.com/repos/elastic/logstash/pulls/4194"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/logstash/pulls/4194","id":50771389,"html_url":"https://github.com/elastic/logstash/pull/4194","diff_url":"https://github.com/elastic/logstash/pull/4194.diff","patch_url":"https://github.com/elastic/logstash/pull/4194.patch","issue_url":"https://api.github.com/repos/elastic/logstash/issues/4194","number":4194,"state":"open","locked":false,"title":"Pluggable agents","user":{"login":"andrewvc","id":131427,"avatar_url":"https://avatars.githubusercontent.com/u/131427?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"body":"This builds off @jsvd 's patch #3872 to make the agent a pluggable command line class for greater extensibility. It will need to be either merged into @jsvd 's branch or rebased after his branch is merged in the future. \r\n\r\n## Notes for Reviewers\r\n\r\nThis should enable the following behaviors\r\n\r\n1. Plugin authors can create an agent plugin by creating a gem named `logstash-agent-myagent` and creating a class that looks like\r\n2. Users should be able to choose the agent they desire at startup with a new CLI flag `-a AGENTNAME`. \r\n\r\n```ruby\r\nrequire 'lib/logstash/agent_plugin_manager'\r\n  class MyLogStashAgent < LogStash::Agent\r\n    LogStash::AgentPluginManager.register(:my_logstash_agent, self)\r\n   # ...\r\nend\r\n```\r\n","created_at":"2015-11-16T04:54:30Z","updated_at":"2015-12-02T17:21:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb46daf9743834f66a05b1ef4ddbfeeb0329e61e","assignee":{"login":"purbon","id":68540,"avatar_url":"https://avatars.githubusercontent.com/u/68540?v=3","gravatar_id":"","url":"https://api.github.com/users/purbon","html_url":"https://github.com/purbon","followers_url":"https://api.github.com/users/purbon/followers","following_url":"https://api.github.com/users/purbon/following{/other_user}","gists_url":"https://api.github.com/users/purbon/gists{/gist_id}","starred_url":"https://api.github.com/users/purbon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purbon/subscriptions","organizations_url":"https://api.github.com/users/purbon/orgs","repos_url":"https://api.github.com/users/purbon/repos","events_url":"https://api.github.com/users/purbon/events{/privacy}","received_events_url":"https://api.github.com/users/purbon/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/elastic/logstash/pulls/4194/commits","review_comments_url":"https://api.github.com/repos/elastic/logstash/pulls/4194/comments","review_comment_url":"https://api.github.com/repos/elastic/logstash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/logstash/issues/4194/comments","statuses_url":"https://api.github.com/repos/elastic/logstash/statuses/ea179ab158d68cadabf48bd5e2db6bcd6f275089","head":{"label":"andrewvc:pluggable_agents","ref":"pluggable_agents","sha":"ea179ab158d68cadabf48bd5e2db6bcd6f275089","user":{"login":"andrewvc","id":131427,"avatar_url":"https://avatars.githubusercontent.com/u/131427?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"repo":{"id":37559198,"name":"logstash","full_name":"andrewvc/logstash","owner":{"login":"andrewvc","id":131427,"avatar_url":"https://avatars.githubusercontent.com/u/131427?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewvc/logstash","description":"logstash - transport and process your logs, events, or other data","fork":true,"url":"https://api.github.com/repos/andrewvc/logstash","forks_url":"https://api.github.com/repos/andrewvc/logstash/forks","keys_url":"https://api.github.com/repos/andrewvc/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewvc/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewvc/logstash/teams","hooks_url":"https://api.github.com/repos/andrewvc/logstash/hooks","issue_events_url":"https://api.github.com/repos/andrewvc/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/andrewvc/logstash/events","assignees_url":"https://api.github.com/repos/andrewvc/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/andrewvc/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/andrewvc/logstash/tags","blobs_url":"https://api.github.com/repos/andrewvc/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewvc/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewvc/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewvc/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewvc/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewvc/logstash/languages","stargazers_url":"https://api.github.com/repos/andrewvc/logstash/stargazers","contributors_url":"https://api.github.com/repos/andrewvc/logstash/contributors","subscribers_url":"https://api.github.com/repos/andrewvc/logstash/subscribers","subscription_url":"https://api.github.com/repos/andrewvc/logstash/subscription","commits_url":"https://api.github.com/repos/andrewvc/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewvc/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewvc/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewvc/logstash/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewvc/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/andrewvc/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewvc/logstash/merges","archive_url":"https://api.github.com/repos/andrewvc/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewvc/logstash/downloads","issues_url":"https://api.github.com/repos/andrewvc/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/andrewvc/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewvc/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewvc/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewvc/logstash/labels{/name}","releases_url":"https://api.github.com/repos/andrewvc/logstash/releases{/id}","created_at":"2015-06-16T22:23:09Z","updated_at":"2015-06-16T22:23:11Z","pushed_at":"2015-12-01T22:56:41Z","git_url":"git://github.com/andrewvc/logstash.git","ssh_url":"git@github.com:andrewvc/logstash.git","clone_url":"https://github.com/andrewvc/logstash.git","svn_url":"https://github.com/andrewvc/logstash","homepage":"https://www.elastic.co/products/logstash","size":75985,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"f29ac1c3083d1be411c3be8c04b5cd25a8172e1e","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":1090311,"name":"logstash","full_name":"elastic/logstash","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/logstash","description":"logstash - transport and process your logs, events, or other data","fork":false,"url":"https://api.github.com/repos/elastic/logstash","forks_url":"https://api.github.com/repos/elastic/logstash/forks","keys_url":"https://api.github.com/repos/elastic/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/logstash/teams","hooks_url":"https://api.github.com/repos/elastic/logstash/hooks","issue_events_url":"https://api.github.com/repos/elastic/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/logstash/events","assignees_url":"https://api.github.com/repos/elastic/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/logstash/tags","blobs_url":"https://api.github.com/repos/elastic/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/logstash/languages","stargazers_url":"https://api.github.com/repos/elastic/logstash/stargazers","contributors_url":"https://api.github.com/repos/elastic/logstash/contributors","subscribers_url":"https://api.github.com/repos/elastic/logstash/subscribers","subscription_url":"https://api.github.com/repos/elastic/logstash/subscription","commits_url":"https://api.github.com/repos/elastic/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/logstash/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/logstash/merges","archive_url":"https://api.github.com/repos/elastic/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/logstash/downloads","issues_url":"https://api.github.com/repos/elastic/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/logstash/labels{/name}","releases_url":"https://api.github.com/repos/elastic/logstash/releases{/id}","created_at":"2010-11-18T01:31:50Z","updated_at":"2015-12-02T16:29:38Z","pushed_at":"2015-12-02T06:21:22Z","git_url":"git://github.com/elastic/logstash.git","ssh_url":"git@github.com:elastic/logstash.git","clone_url":"https://github.com/elastic/logstash.git","svn_url":"https://github.com/elastic/logstash","homepage":"https://www.elastic.co/products/logstash","size":78112,"stargazers_count":5083,"watchers_count":5083,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1643,"mirror_url":null,"open_issues_count":693,"forks":1643,"open_issues":693,"watchers":5083,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/logstash/pulls/4194"},"html":{"href":"https://github.com/elastic/logstash/pull/4194"},"issue":{"href":"https://api.github.com/repos/elastic/logstash/issues/4194"},"comments":{"href":"https://api.github.com/repos/elastic/logstash/issues/4194/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/logstash/pulls/4194/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/logstash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/logstash/pulls/4194/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/logstash/statuses/ea179ab158d68cadabf48bd5e2db6bcd6f275089"}}}}