{"action":"created","issue":{"url":"https://api.github.com/repos/basho/lager/issues/247","labels_url":"https://api.github.com/repos/basho/lager/issues/247/labels{/name}","comments_url":"https://api.github.com/repos/basho/lager/issues/247/comments","events_url":"https://api.github.com/repos/basho/lager/issues/247/events","html_url":"https://github.com/basho/lager/pull/247","id":52252981,"number":247,"title":"make trace and stop_trace take the same arguments","user":{"login":"lrascao","id":639415,"avatar_url":"https://avatars.githubusercontent.com/u/639415?v=3","gravatar_id":"","url":"https://api.github.com/users/lrascao","html_url":"https://github.com/lrascao","followers_url":"https://api.github.com/users/lrascao/followers","following_url":"https://api.github.com/users/lrascao/following{/other_user}","gists_url":"https://api.github.com/users/lrascao/gists{/gist_id}","starred_url":"https://api.github.com/users/lrascao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrascao/subscriptions","organizations_url":"https://api.github.com/users/lrascao/orgs","repos_url":"https://api.github.com/users/lrascao/repos","events_url":"https://api.github.com/users/lrascao/events{/privacy}","received_events_url":"https://api.github.com/users/lrascao/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2014-12-17T15:30:51Z","updated_at":"2015-01-22T20:17:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/basho/lager/pulls/247","html_url":"https://github.com/basho/lager/pull/247","diff_url":"https://github.com/basho/lager/pull/247.diff","patch_url":"https://github.com/basho/lager/pull/247.patch"},"body":"starting a filtered trace is easy enough, one would expect the stop_trace to receive the same arguments.\r\nfor example, starting a trace:\r\nlager:trace(lager_console_backend, [{module, users_serv}, {function, is_client_update_available}], debug).\r\n\r\nto stop the trace, one must issue the following (non-intuitive) command:\r\nlager:stop_trace({{all,[{module,'=',users_serv},{function,'=',is_client_update_available}]},{mask,255},lager_console_backend}).\r\n\r\nwith this PR the stop_trace now becomes:\r\nlager:stop_trace(lager_console_backend, [{module, users_serv}, {function, is_client_update_available}], debug)."},"comment":{"url":"https://api.github.com/repos/basho/lager/issues/comments/71090587","html_url":"https://github.com/basho/lager/pull/247#issuecomment-71090587","issue_url":"https://api.github.com/repos/basho/lager/issues/247","id":71090587,"user":{"login":"Vagabond","id":86412,"avatar_url":"https://avatars.githubusercontent.com/u/86412?v=3","gravatar_id":"","url":"https://api.github.com/users/Vagabond","html_url":"https://github.com/Vagabond","followers_url":"https://api.github.com/users/Vagabond/followers","following_url":"https://api.github.com/users/Vagabond/following{/other_user}","gists_url":"https://api.github.com/users/Vagabond/gists{/gist_id}","starred_url":"https://api.github.com/users/Vagabond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vagabond/subscriptions","organizations_url":"https://api.github.com/users/Vagabond/orgs","repos_url":"https://api.github.com/users/Vagabond/repos","events_url":"https://api.github.com/users/Vagabond/events{/privacy}","received_events_url":"https://api.github.com/users/Vagabond/received_events","type":"User","site_admin":false},"created_at":"2015-01-22T20:17:03Z","updated_at":"2015-01-22T20:17:03Z","body":"This breaks one of the tests, it is documented that you can pass the result of start_trace into stop trace, so you should fix start_trace to return the 3-tuple. This is as simple as changing line 193 of lager.erl to return {ok, Trace0} rather than {ok, Trace}.\r\n\r\nI think this is fine once that change is made."}}