{"action":"created","comment":{"url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/comments/23718681","id":23718681,"diff_hunk":"@@ -207,7 +208,7 @@ angular.module('encore.ui.rxFloatingHeader', [])\n         // If there are other elements, wrap them. Each time\n         // it will remove the element from its current parent,\n         // and also from the `elms` array\n-        while (elms.length) {\n+        while (isNonEmptyArray) {\n             newParent.appendChild(elms[0]);\n         }","path":"src/rxFloatingHeader/rxFloatingHeader.js","position":null,"original_position":17,"commit_id":"f8b12c8264f44f69506ad9847635d97e83bd741f","original_commit_id":"1f70e8c22b61fc82fc49b8eaa595a110bdb3caca","user":{"login":"Droogans","id":1214609,"avatar_url":"https://avatars.githubusercontent.com/u/1214609?v=3","gravatar_id":"","url":"https://api.github.com/users/Droogans","html_url":"https://github.com/Droogans","followers_url":"https://api.github.com/users/Droogans/followers","following_url":"https://api.github.com/users/Droogans/following{/other_user}","gists_url":"https://api.github.com/users/Droogans/gists{/gist_id}","starred_url":"https://api.github.com/users/Droogans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Droogans/subscriptions","organizations_url":"https://api.github.com/users/Droogans/orgs","repos_url":"https://api.github.com/users/Droogans/repos","events_url":"https://api.github.com/users/Droogans/events{/privacy}","received_events_url":"https://api.github.com/users/Droogans/received_events","type":"User","site_admin":false},"body":"I see. I wasn't reading close enough, and missed this crucial line:\r\n\r\n```js\r\nvar el = (elms.length && !isGroupParent) ? elms[0] : elms;\r\n```\r\n\r\nI forgot that `el` is the primary focus of `wrapAll`, I was caught up in the details of `elms`.","created_at":"2015-01-28T20:08:44Z","updated_at":"2015-01-28T20:08:44Z","html_url":"https://github.com/rackerlabs/encore-ui/pull/757#discussion_r23718681","pull_request_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/757","_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/comments/23718681"},"html":{"href":"https://github.com/rackerlabs/encore-ui/pull/757#discussion_r23718681"},"pull_request":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/757"}}},"pull_request":{"url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/757","id":28162734,"html_url":"https://github.com/rackerlabs/encore-ui/pull/757","diff_url":"https://github.com/rackerlabs/encore-ui/pull/757.diff","patch_url":"https://github.com/rackerlabs/encore-ui/pull/757.patch","issue_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues/757","number":757,"state":"open","locked":false,"title":"fix(rxDOMHelper): Properly wrap a select node instead of its options.","user":{"login":"megalord","id":5414922,"avatar_url":"https://avatars.githubusercontent.com/u/5414922?v=3","gravatar_id":"","url":"https://api.github.com/users/megalord","html_url":"https://github.com/megalord","followers_url":"https://api.github.com/users/megalord/followers","following_url":"https://api.github.com/users/megalord/following{/other_user}","gists_url":"https://api.github.com/users/megalord/gists{/gist_id}","starred_url":"https://api.github.com/users/megalord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/megalord/subscriptions","organizations_url":"https://api.github.com/users/megalord/orgs","repos_url":"https://api.github.com/users/megalord/repos","events_url":"https://api.github.com/users/megalord/events{/privacy}","received_events_url":"https://api.github.com/users/megalord/received_events","type":"User","site_admin":false},"body":"Fixes #756 \r\nThe issue is that a `select` element has a `length` property, which returns the number of options it has.  That was causing the `wrapAll` method to thing that the element was actually an array of elements.  Further, it is possible to access a specific option by its index, e.g. `selectElement[0] === optionElement`.","created_at":"2015-01-28T02:06:32Z","updated_at":"2015-01-28T20:08:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"456c907b7b2972c327ea5937be5e259dcb168953","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/757/commits","review_comments_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/757/comments","review_comment_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues/757/comments","statuses_url":"https://api.github.com/repos/rackerlabs/encore-ui/statuses/f8b12c8264f44f69506ad9847635d97e83bd741f","head":{"label":"megalord:wrap-select-tag","ref":"wrap-select-tag","sha":"f8b12c8264f44f69506ad9847635d97e83bd741f","user":{"login":"megalord","id":5414922,"avatar_url":"https://avatars.githubusercontent.com/u/5414922?v=3","gravatar_id":"","url":"https://api.github.com/users/megalord","html_url":"https://github.com/megalord","followers_url":"https://api.github.com/users/megalord/followers","following_url":"https://api.github.com/users/megalord/following{/other_user}","gists_url":"https://api.github.com/users/megalord/gists{/gist_id}","starred_url":"https://api.github.com/users/megalord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/megalord/subscriptions","organizations_url":"https://api.github.com/users/megalord/orgs","repos_url":"https://api.github.com/users/megalord/repos","events_url":"https://api.github.com/users/megalord/events{/privacy}","received_events_url":"https://api.github.com/users/megalord/received_events","type":"User","site_admin":false},"repo":{"id":26324960,"name":"encore-ui","full_name":"megalord/encore-ui","owner":{"login":"megalord","id":5414922,"avatar_url":"https://avatars.githubusercontent.com/u/5414922?v=3","gravatar_id":"","url":"https://api.github.com/users/megalord","html_url":"https://github.com/megalord","followers_url":"https://api.github.com/users/megalord/followers","following_url":"https://api.github.com/users/megalord/following{/other_user}","gists_url":"https://api.github.com/users/megalord/gists{/gist_id}","starred_url":"https://api.github.com/users/megalord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/megalord/subscriptions","organizations_url":"https://api.github.com/users/megalord/orgs","repos_url":"https://api.github.com/users/megalord/repos","events_url":"https://api.github.com/users/megalord/events{/privacy}","received_events_url":"https://api.github.com/users/megalord/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/megalord/encore-ui","description":"UI Framework for Encore","fork":true,"url":"https://api.github.com/repos/megalord/encore-ui","forks_url":"https://api.github.com/repos/megalord/encore-ui/forks","keys_url":"https://api.github.com/repos/megalord/encore-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/megalord/encore-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/megalord/encore-ui/teams","hooks_url":"https://api.github.com/repos/megalord/encore-ui/hooks","issue_events_url":"https://api.github.com/repos/megalord/encore-ui/issues/events{/number}","events_url":"https://api.github.com/repos/megalord/encore-ui/events","assignees_url":"https://api.github.com/repos/megalord/encore-ui/assignees{/user}","branches_url":"https://api.github.com/repos/megalord/encore-ui/branches{/branch}","tags_url":"https://api.github.com/repos/megalord/encore-ui/tags","blobs_url":"https://api.github.com/repos/megalord/encore-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/megalord/encore-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/megalord/encore-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/megalord/encore-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/megalord/encore-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/megalord/encore-ui/languages","stargazers_url":"https://api.github.com/repos/megalord/encore-ui/stargazers","contributors_url":"https://api.github.com/repos/megalord/encore-ui/contributors","subscribers_url":"https://api.github.com/repos/megalord/encore-ui/subscribers","subscription_url":"https://api.github.com/repos/megalord/encore-ui/subscription","commits_url":"https://api.github.com/repos/megalord/encore-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/megalord/encore-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/megalord/encore-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/megalord/encore-ui/issues/comments/{number}","contents_url":"https://api.github.com/repos/megalord/encore-ui/contents/{+path}","compare_url":"https://api.github.com/repos/megalord/encore-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/megalord/encore-ui/merges","archive_url":"https://api.github.com/repos/megalord/encore-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/megalord/encore-ui/downloads","issues_url":"https://api.github.com/repos/megalord/encore-ui/issues{/number}","pulls_url":"https://api.github.com/repos/megalord/encore-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/megalord/encore-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/megalord/encore-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/megalord/encore-ui/labels{/name}","releases_url":"https://api.github.com/repos/megalord/encore-ui/releases{/id}","created_at":"2014-11-07T15:18:54Z","updated_at":"2015-01-27T21:02:10Z","pushed_at":"2015-01-28T19:25:52Z","git_url":"git://github.com/megalord/encore-ui.git","ssh_url":"git@github.com:megalord/encore-ui.git","clone_url":"https://github.com/megalord/encore-ui.git","svn_url":"https://github.com/megalord/encore-ui","homepage":"http://rackerlabs.github.io/encore-ui/","size":12990,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rackerlabs:master","ref":"master","sha":"b3930d07451b23aab863d688139a9169a8cfc646","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":11432401,"name":"encore-ui","full_name":"rackerlabs/encore-ui","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/encore-ui","description":"UI Framework for Encore","fork":false,"url":"https://api.github.com/repos/rackerlabs/encore-ui","forks_url":"https://api.github.com/repos/rackerlabs/encore-ui/forks","keys_url":"https://api.github.com/repos/rackerlabs/encore-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/encore-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/encore-ui/teams","hooks_url":"https://api.github.com/repos/rackerlabs/encore-ui/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/encore-ui/events","assignees_url":"https://api.github.com/repos/rackerlabs/encore-ui/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/encore-ui/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/encore-ui/tags","blobs_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/encore-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/encore-ui/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/encore-ui/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/encore-ui/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/encore-ui/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/encore-ui/subscription","commits_url":"https://api.github.com/repos/rackerlabs/encore-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/encore-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues/comments/{number}","contents_url":"https://api.github.com/repos/rackerlabs/encore-ui/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/encore-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/encore-ui/merges","archive_url":"https://api.github.com/repos/rackerlabs/encore-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/encore-ui/downloads","issues_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/encore-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/encore-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/encore-ui/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/encore-ui/releases{/id}","created_at":"2013-07-15T20:06:52Z","updated_at":"2015-01-26T17:39:12Z","pushed_at":"2015-01-28T15:52:19Z","git_url":"git://github.com/rackerlabs/encore-ui.git","ssh_url":"git@github.com:rackerlabs/encore-ui.git","clone_url":"https://github.com/rackerlabs/encore-ui.git","svn_url":"https://github.com/rackerlabs/encore-ui","homepage":"http://rackerlabs.github.io/encore-ui/","size":22304,"stargazers_count":24,"watchers_count":24,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":21,"mirror_url":null,"open_issues_count":83,"forks":21,"open_issues":83,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/757"},"html":{"href":"https://github.com/rackerlabs/encore-ui/pull/757"},"issue":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/issues/757"},"comments":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/issues/757/comments"},"review_comments":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/757/comments"},"review_comment":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/757/commits"},"statuses":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/statuses/f8b12c8264f44f69506ad9847635d97e83bd741f"}}}}