{"action":"created","issue":{"url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/issues/24","labels_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/issues/24/labels{/name}","comments_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/issues/24/comments","events_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/issues/24/events","html_url":"https://github.com/lucisgit/moodle-filter_jwplayer/pull/24","id":94038575,"number":24,"title":"filter_jwplayer:  Change div tags to span and update css to display inline (bug #3)","user":{"login":"owenbarritt","id":12510212,"avatar_url":"https://avatars.githubusercontent.com/u/12510212?v=3","gravatar_id":"","url":"https://api.github.com/users/owenbarritt","html_url":"https://github.com/owenbarritt","followers_url":"https://api.github.com/users/owenbarritt/followers","following_url":"https://api.github.com/users/owenbarritt/following{/other_user}","gists_url":"https://api.github.com/users/owenbarritt/gists{/gist_id}","starred_url":"https://api.github.com/users/owenbarritt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owenbarritt/subscriptions","organizations_url":"https://api.github.com/users/owenbarritt/orgs","repos_url":"https://api.github.com/users/owenbarritt/repos","events_url":"https://api.github.com/users/owenbarritt/events{/privacy}","received_events_url":"https://api.github.com/users/owenbarritt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-07-09T12:41:04Z","updated_at":"2015-07-09T13:04:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/pulls/24","html_url":"https://github.com/lucisgit/moodle-filter_jwplayer/pull/24","diff_url":"https://github.com/lucisgit/moodle-filter_jwplayer/pull/24.diff","patch_url":"https://github.com/lucisgit/moodle-filter_jwplayer/pull/24.patch"},"body":"I've switch the inserted div tags to span, which is more consistent with the core media filters and stops the issue of the surrounding tags being closed.\r\n\r\nAdded extra css to override the css added by the player, so it displays inline within our block.\r\n\r\nThis makes the player always centered (due to the existing text-align statement in the filter css) rather than left-aligned, but at least that's consistent with the core players."},"comment":{"url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/issues/comments/119954982","html_url":"https://github.com/lucisgit/moodle-filter_jwplayer/pull/24#issuecomment-119954982","issue_url":"https://api.github.com/repos/lucisgit/moodle-filter_jwplayer/issues/24","id":119954982,"user":{"login":"owenbarritt","id":12510212,"avatar_url":"https://avatars.githubusercontent.com/u/12510212?v=3","gravatar_id":"","url":"https://api.github.com/users/owenbarritt","html_url":"https://github.com/owenbarritt","followers_url":"https://api.github.com/users/owenbarritt/followers","following_url":"https://api.github.com/users/owenbarritt/following{/other_user}","gists_url":"https://api.github.com/users/owenbarritt/gists{/gist_id}","starred_url":"https://api.github.com/users/owenbarritt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owenbarritt/subscriptions","organizations_url":"https://api.github.com/users/owenbarritt/orgs","repos_url":"https://api.github.com/users/owenbarritt/repos","events_url":"https://api.github.com/users/owenbarritt/events{/privacy}","received_events_url":"https://api.github.com/users/owenbarritt/received_events","type":"User","site_admin":false},"created_at":"2015-07-09T13:04:56Z","updated_at":"2015-07-09T13:04:56Z","body":"It sticks it to the middle, as that's consistent with the core media filters.\r\n\r\nIt could be changed to use the inherited alignment of the parent tags by removing the existing text-align statement in styles.css, but that would be inconsistent with the way moodle handles other media."}}