{"action":"created","comment":{"url":"https://api.github.com/repos/Internet2/grouper/pulls/comments/36056675","id":36056675,"diff_hunk":"@@ -7627,5 +7633,234 @@ public boolean canHavePrivilege(Subject subject, String privilegeOrListName, boo\n     throw new RuntimeException(\"Cant find privilege: '\" + privilegeOrListName + \"'\");\r\n   \r\n   }\r\n+  \r\n+  \r\n+  private void changeDisplayProperties() {\r\n+    \r\n+    boolean alreadyChanged = false;\r\n+    \r\n+    String includeExcludeTypeName = GrouperConfig.retrieveConfig().propertyValueString(\"grouperIncludeExclude.type.name\");\r\n+    String requireGroupsTypeName = GrouperConfig.retrieveConfig().propertyValueString(\"grouperIncludeExclude.requireGroups.type.name\");\r\n+    \r\n+    for (GroupType groupType: this.getTypes(true)) {\r\n+     \r\n+      if (groupType.getName().equals(includeExcludeTypeName)) {\r\n+        DisplayProperties displayProperties = new DisplayProperties();\r\n+        changeDisplayPropertiesForIncludeExcludeType(displayProperties);\r\n+        alreadyChanged = true;\r\n+      } else if (groupType.getName().equals(requireGroupsTypeName)) {\r\n+        DisplayProperties displayProperties = new DisplayProperties();\r\n+        changeDisplayPropertiesForRequireInGroupsType(displayProperties);\r\n+        alreadyChanged = true;\r\n+      }\r\n+      \r\n+    }\r\n+    \r\n+    // addIncludeExclude type from UI - systemOfRecord group is not of type addIncludeExclude\r\n+    if (!alreadyChanged && this.getName().endsWith(systemOfRecordExtensionSuffix()) && groupExistsAsCompositeInOverallGroup()) {\r\n+        DisplayProperties displayProperties = new DisplayProperties();\r\n+        changeDisplayPropertiesForIncludeExcludeType(displayProperties);\r\n+        alreadyChanged = true;\r\n+    }\r\n+    \r\n+    // requireInGroups type from UI - systemOfRecord group is not of type requireInGroups\r\n+    if (!alreadyChanged && this.getName().endsWith(systemOfRecordExtensionSuffix()) && groupExistsAsMemberInOverallGroup()) {\r\n+      DisplayProperties displayProperties = new DisplayProperties();\r\n+      changeDisplayPropertiesForRequireInGroupsType(displayProperties);\r","path":"grouper/src/grouper/edu/internet2/middleware/grouper/Group.java","position":57,"original_position":57,"commit_id":"bd166bae75d799ac54e0785342a231f0d769e5d5","original_commit_id":"bd166bae75d799ac54e0785342a231f0d769e5d5","user":{"login":"mmoayyed","id":1205228,"avatar_url":"https://avatars.githubusercontent.com/u/1205228?v=3","gravatar_id":"","url":"https://api.github.com/users/mmoayyed","html_url":"https://github.com/mmoayyed","followers_url":"https://api.github.com/users/mmoayyed/followers","following_url":"https://api.github.com/users/mmoayyed/following{/other_user}","gists_url":"https://api.github.com/users/mmoayyed/gists{/gist_id}","starred_url":"https://api.github.com/users/mmoayyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmoayyed/subscriptions","organizations_url":"https://api.github.com/users/mmoayyed/orgs","repos_url":"https://api.github.com/users/mmoayyed/repos","events_url":"https://api.github.com/users/mmoayyed/events{/privacy}","received_events_url":"https://api.github.com/users/mmoayyed/received_events","type":"User","site_admin":false},"body":"Is this block missing ` alreadyChanged = true; `?","created_at":"2015-08-03T05:16:01Z","updated_at":"2015-08-03T05:16:01Z","html_url":"https://github.com/Internet2/grouper/pull/46#discussion_r36056675","pull_request_url":"https://api.github.com/repos/Internet2/grouper/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/Internet2/grouper/pulls/comments/36056675"},"html":{"href":"https://github.com/Internet2/grouper/pull/46#discussion_r36056675"},"pull_request":{"href":"https://api.github.com/repos/Internet2/grouper/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/Internet2/grouper/pulls/46","id":41424889,"html_url":"https://github.com/Internet2/grouper/pull/46","diff_url":"https://github.com/Internet2/grouper/pull/46.diff","patch_url":"https://github.com/Internet2/grouper/pull/46.patch","issue_url":"https://api.github.com/repos/Internet2/grouper/issues/46","number":46,"state":"open","locked":false,"title":"GRP-1091 - Change the display properties of groups from within loader…","user":{"login":"sachdeva-vivek","id":8611124,"avatar_url":"https://avatars.githubusercontent.com/u/8611124?v=3","gravatar_id":"","url":"https://api.github.com/users/sachdeva-vivek","html_url":"https://github.com/sachdeva-vivek","followers_url":"https://api.github.com/users/sachdeva-vivek/followers","following_url":"https://api.github.com/users/sachdeva-vivek/following{/other_user}","gists_url":"https://api.github.com/users/sachdeva-vivek/gists{/gist_id}","starred_url":"https://api.github.com/users/sachdeva-vivek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sachdeva-vivek/subscriptions","organizations_url":"https://api.github.com/users/sachdeva-vivek/orgs","repos_url":"https://api.github.com/users/sachdeva-vivek/repos","events_url":"https://api.github.com/users/sachdeva-vivek/events{/privacy}","received_events_url":"https://api.github.com/users/sachdeva-vivek/received_events","type":"User","site_admin":false},"body":"… for addIncludeExclude and requireInGroups. Also change the display properties for systemOfRecord groups.","created_at":"2015-08-02T21:30:08Z","updated_at":"2015-08-03T05:16:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bfb36eae09d66102d6e4d5b16ebe393c949c97c9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Internet2/grouper/pulls/46/commits","review_comments_url":"https://api.github.com/repos/Internet2/grouper/pulls/46/comments","review_comment_url":"https://api.github.com/repos/Internet2/grouper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Internet2/grouper/issues/46/comments","statuses_url":"https://api.github.com/repos/Internet2/grouper/statuses/bd166bae75d799ac54e0785342a231f0d769e5d5","head":{"label":"sachdeva-vivek:GRP-1091","ref":"GRP-1091","sha":"bd166bae75d799ac54e0785342a231f0d769e5d5","user":{"login":"sachdeva-vivek","id":8611124,"avatar_url":"https://avatars.githubusercontent.com/u/8611124?v=3","gravatar_id":"","url":"https://api.github.com/users/sachdeva-vivek","html_url":"https://github.com/sachdeva-vivek","followers_url":"https://api.github.com/users/sachdeva-vivek/followers","following_url":"https://api.github.com/users/sachdeva-vivek/following{/other_user}","gists_url":"https://api.github.com/users/sachdeva-vivek/gists{/gist_id}","starred_url":"https://api.github.com/users/sachdeva-vivek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sachdeva-vivek/subscriptions","organizations_url":"https://api.github.com/users/sachdeva-vivek/orgs","repos_url":"https://api.github.com/users/sachdeva-vivek/repos","events_url":"https://api.github.com/users/sachdeva-vivek/events{/privacy}","received_events_url":"https://api.github.com/users/sachdeva-vivek/received_events","type":"User","site_admin":false},"repo":{"id":33702003,"name":"grouper","full_name":"sachdeva-vivek/grouper","owner":{"login":"sachdeva-vivek","id":8611124,"avatar_url":"https://avatars.githubusercontent.com/u/8611124?v=3","gravatar_id":"","url":"https://api.github.com/users/sachdeva-vivek","html_url":"https://github.com/sachdeva-vivek","followers_url":"https://api.github.com/users/sachdeva-vivek/followers","following_url":"https://api.github.com/users/sachdeva-vivek/following{/other_user}","gists_url":"https://api.github.com/users/sachdeva-vivek/gists{/gist_id}","starred_url":"https://api.github.com/users/sachdeva-vivek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sachdeva-vivek/subscriptions","organizations_url":"https://api.github.com/users/sachdeva-vivek/orgs","repos_url":"https://api.github.com/users/sachdeva-vivek/repos","events_url":"https://api.github.com/users/sachdeva-vivek/events{/privacy}","received_events_url":"https://api.github.com/users/sachdeva-vivek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sachdeva-vivek/grouper","description":"","fork":true,"url":"https://api.github.com/repos/sachdeva-vivek/grouper","forks_url":"https://api.github.com/repos/sachdeva-vivek/grouper/forks","keys_url":"https://api.github.com/repos/sachdeva-vivek/grouper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sachdeva-vivek/grouper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sachdeva-vivek/grouper/teams","hooks_url":"https://api.github.com/repos/sachdeva-vivek/grouper/hooks","issue_events_url":"https://api.github.com/repos/sachdeva-vivek/grouper/issues/events{/number}","events_url":"https://api.github.com/repos/sachdeva-vivek/grouper/events","assignees_url":"https://api.github.com/repos/sachdeva-vivek/grouper/assignees{/user}","branches_url":"https://api.github.com/repos/sachdeva-vivek/grouper/branches{/branch}","tags_url":"https://api.github.com/repos/sachdeva-vivek/grouper/tags","blobs_url":"https://api.github.com/repos/sachdeva-vivek/grouper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sachdeva-vivek/grouper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sachdeva-vivek/grouper/git/refs{/sha}","trees_url":"https://api.github.com/repos/sachdeva-vivek/grouper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sachdeva-vivek/grouper/statuses/{sha}","languages_url":"https://api.github.com/repos/sachdeva-vivek/grouper/languages","stargazers_url":"https://api.github.com/repos/sachdeva-vivek/grouper/stargazers","contributors_url":"https://api.github.com/repos/sachdeva-vivek/grouper/contributors","subscribers_url":"https://api.github.com/repos/sachdeva-vivek/grouper/subscribers","subscription_url":"https://api.github.com/repos/sachdeva-vivek/grouper/subscription","commits_url":"https://api.github.com/repos/sachdeva-vivek/grouper/commits{/sha}","git_commits_url":"https://api.github.com/repos/sachdeva-vivek/grouper/git/commits{/sha}","comments_url":"https://api.github.com/repos/sachdeva-vivek/grouper/comments{/number}","issue_comment_url":"https://api.github.com/repos/sachdeva-vivek/grouper/issues/comments{/number}","contents_url":"https://api.github.com/repos/sachdeva-vivek/grouper/contents/{+path}","compare_url":"https://api.github.com/repos/sachdeva-vivek/grouper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sachdeva-vivek/grouper/merges","archive_url":"https://api.github.com/repos/sachdeva-vivek/grouper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sachdeva-vivek/grouper/downloads","issues_url":"https://api.github.com/repos/sachdeva-vivek/grouper/issues{/number}","pulls_url":"https://api.github.com/repos/sachdeva-vivek/grouper/pulls{/number}","milestones_url":"https://api.github.com/repos/sachdeva-vivek/grouper/milestones{/number}","notifications_url":"https://api.github.com/repos/sachdeva-vivek/grouper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sachdeva-vivek/grouper/labels{/name}","releases_url":"https://api.github.com/repos/sachdeva-vivek/grouper/releases{/id}","created_at":"2015-04-10T01:38:28Z","updated_at":"2015-04-10T01:39:10Z","pushed_at":"2015-08-03T05:03:32Z","git_url":"git://github.com/sachdeva-vivek/grouper.git","ssh_url":"git@github.com:sachdeva-vivek/grouper.git","clone_url":"https://github.com/sachdeva-vivek/grouper.git","svn_url":"https://github.com/sachdeva-vivek/grouper","homepage":null,"size":729376,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Internet2:GROUPER_2_2_BRANCH","ref":"GROUPER_2_2_BRANCH","sha":"16e4054aa7ac026d549af49473a592615e136ce0","user":{"login":"Internet2","id":2036427,"avatar_url":"https://avatars.githubusercontent.com/u/2036427?v=3","gravatar_id":"","url":"https://api.github.com/users/Internet2","html_url":"https://github.com/Internet2","followers_url":"https://api.github.com/users/Internet2/followers","following_url":"https://api.github.com/users/Internet2/following{/other_user}","gists_url":"https://api.github.com/users/Internet2/gists{/gist_id}","starred_url":"https://api.github.com/users/Internet2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Internet2/subscriptions","organizations_url":"https://api.github.com/users/Internet2/orgs","repos_url":"https://api.github.com/users/Internet2/repos","events_url":"https://api.github.com/users/Internet2/events{/privacy}","received_events_url":"https://api.github.com/users/Internet2/received_events","type":"Organization","site_admin":false},"repo":{"id":21910720,"name":"grouper","full_name":"Internet2/grouper","owner":{"login":"Internet2","id":2036427,"avatar_url":"https://avatars.githubusercontent.com/u/2036427?v=3","gravatar_id":"","url":"https://api.github.com/users/Internet2","html_url":"https://github.com/Internet2","followers_url":"https://api.github.com/users/Internet2/followers","following_url":"https://api.github.com/users/Internet2/following{/other_user}","gists_url":"https://api.github.com/users/Internet2/gists{/gist_id}","starred_url":"https://api.github.com/users/Internet2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Internet2/subscriptions","organizations_url":"https://api.github.com/users/Internet2/orgs","repos_url":"https://api.github.com/users/Internet2/repos","events_url":"https://api.github.com/users/Internet2/events{/privacy}","received_events_url":"https://api.github.com/users/Internet2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Internet2/grouper","description":"","fork":false,"url":"https://api.github.com/repos/Internet2/grouper","forks_url":"https://api.github.com/repos/Internet2/grouper/forks","keys_url":"https://api.github.com/repos/Internet2/grouper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Internet2/grouper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Internet2/grouper/teams","hooks_url":"https://api.github.com/repos/Internet2/grouper/hooks","issue_events_url":"https://api.github.com/repos/Internet2/grouper/issues/events{/number}","events_url":"https://api.github.com/repos/Internet2/grouper/events","assignees_url":"https://api.github.com/repos/Internet2/grouper/assignees{/user}","branches_url":"https://api.github.com/repos/Internet2/grouper/branches{/branch}","tags_url":"https://api.github.com/repos/Internet2/grouper/tags","blobs_url":"https://api.github.com/repos/Internet2/grouper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Internet2/grouper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Internet2/grouper/git/refs{/sha}","trees_url":"https://api.github.com/repos/Internet2/grouper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Internet2/grouper/statuses/{sha}","languages_url":"https://api.github.com/repos/Internet2/grouper/languages","stargazers_url":"https://api.github.com/repos/Internet2/grouper/stargazers","contributors_url":"https://api.github.com/repos/Internet2/grouper/contributors","subscribers_url":"https://api.github.com/repos/Internet2/grouper/subscribers","subscription_url":"https://api.github.com/repos/Internet2/grouper/subscription","commits_url":"https://api.github.com/repos/Internet2/grouper/commits{/sha}","git_commits_url":"https://api.github.com/repos/Internet2/grouper/git/commits{/sha}","comments_url":"https://api.github.com/repos/Internet2/grouper/comments{/number}","issue_comment_url":"https://api.github.com/repos/Internet2/grouper/issues/comments{/number}","contents_url":"https://api.github.com/repos/Internet2/grouper/contents/{+path}","compare_url":"https://api.github.com/repos/Internet2/grouper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Internet2/grouper/merges","archive_url":"https://api.github.com/repos/Internet2/grouper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Internet2/grouper/downloads","issues_url":"https://api.github.com/repos/Internet2/grouper/issues{/number}","pulls_url":"https://api.github.com/repos/Internet2/grouper/pulls{/number}","milestones_url":"https://api.github.com/repos/Internet2/grouper/milestones{/number}","notifications_url":"https://api.github.com/repos/Internet2/grouper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Internet2/grouper/labels{/name}","releases_url":"https://api.github.com/repos/Internet2/grouper/releases{/id}","created_at":"2014-07-16T17:42:37Z","updated_at":"2015-06-16T15:28:44Z","pushed_at":"2015-08-03T05:03:32Z","git_url":"git://github.com/Internet2/grouper.git","ssh_url":"git@github.com:Internet2/grouper.git","clone_url":"https://github.com/Internet2/grouper.git","svn_url":"https://github.com/Internet2/grouper","homepage":null,"size":983913,"stargazers_count":14,"watchers_count":14,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14,"mirror_url":null,"open_issues_count":3,"forks":14,"open_issues":3,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Internet2/grouper/pulls/46"},"html":{"href":"https://github.com/Internet2/grouper/pull/46"},"issue":{"href":"https://api.github.com/repos/Internet2/grouper/issues/46"},"comments":{"href":"https://api.github.com/repos/Internet2/grouper/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/Internet2/grouper/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/Internet2/grouper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Internet2/grouper/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/Internet2/grouper/statuses/bd166bae75d799ac54e0785342a231f0d769e5d5"}}}}