{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/27339431","id":27339431,"diff_hunk":"@@ -34,11 +34,15 @@ import (\n \n var _ = Describe(\"Services\", func() {\n \tvar c *client.Client\n+\t// Use these in tests.  They're unique for each test to prevent name collisions.\n+\tvar namespace0, namespace1 string\n \n \tBeforeEach(func() {\n \t\tvar err error\n \t\tc, err = loadClient()\n \t\tExpect(err).NotTo(HaveOccurred())\n+\t\tnamespace0 = \"e2e-ns-\" + dateStamp() + \"-0\"","path":"test/e2e/service.go","position":11,"original_position":11,"commit_id":"12a078571c6ef95e0f1d9470460246bdbe231172","original_commit_id":"12a078571c6ef95e0f1d9470460246bdbe231172","user":{"login":"ixdy","id":8061296,"avatar_url":"https://avatars.githubusercontent.com/u/8061296?v=3","gravatar_id":"","url":"https://api.github.com/users/ixdy","html_url":"https://github.com/ixdy","followers_url":"https://api.github.com/users/ixdy/followers","following_url":"https://api.github.com/users/ixdy/following{/other_user}","gists_url":"https://api.github.com/users/ixdy/gists{/gist_id}","starred_url":"https://api.github.com/users/ixdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ixdy/subscriptions","organizations_url":"https://api.github.com/users/ixdy/orgs","repos_url":"https://api.github.com/users/ixdy/repos","events_url":"https://api.github.com/users/ixdy/events{/privacy}","received_events_url":"https://api.github.com/users/ixdy/received_events","type":"User","site_admin":false},"body":"maybe include 'services' in the name, so we can tell where this comes from? or 'service.go' or something like that.","created_at":"2015-03-28T00:06:23Z","updated_at":"2015-03-28T00:06:23Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/6125#discussion_r27339431","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6125","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/27339431"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/6125#discussion_r27339431"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6125"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6125","id":32154512,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/6125","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/6125.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/6125.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/6125","number":6125,"state":"open","locked":false,"title":"Make service e2e tests run in timestamped namespaces.","user":{"login":"quinton-hoole","id":10390785,"avatar_url":"https://avatars.githubusercontent.com/u/10390785?v=3","gravatar_id":"","url":"https://api.github.com/users/quinton-hoole","html_url":"https://github.com/quinton-hoole","followers_url":"https://api.github.com/users/quinton-hoole/followers","following_url":"https://api.github.com/users/quinton-hoole/following{/other_user}","gists_url":"https://api.github.com/users/quinton-hoole/gists{/gist_id}","starred_url":"https://api.github.com/users/quinton-hoole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quinton-hoole/subscriptions","organizations_url":"https://api.github.com/users/quinton-hoole/orgs","repos_url":"https://api.github.com/users/quinton-hoole/repos","events_url":"https://api.github.com/users/quinton-hoole/events{/privacy}","received_events_url":"https://api.github.com/users/quinton-hoole/received_events","type":"User","site_admin":false},"body":"Make some service e2e tests run in timestamped namespaces to prevent name collisions across multiple runs.\r\n\r\nShortly I'll migrate all of the tests to their own namespaces, but right now some of the break if they don't run in api.NamespaceDefault (i.e. \"default\").  I'll fix that in a separate PR.","created_at":"2015-03-27T23:58:14Z","updated_at":"2015-03-28T00:06:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4e53b7077da71dc34e00ba482f4721e20e35a06","assignee":{"login":"zmerlynn","id":4942464,"avatar_url":"https://avatars.githubusercontent.com/u/4942464?v=3","gravatar_id":"","url":"https://api.github.com/users/zmerlynn","html_url":"https://github.com/zmerlynn","followers_url":"https://api.github.com/users/zmerlynn/followers","following_url":"https://api.github.com/users/zmerlynn/following{/other_user}","gists_url":"https://api.github.com/users/zmerlynn/gists{/gist_id}","starred_url":"https://api.github.com/users/zmerlynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmerlynn/subscriptions","organizations_url":"https://api.github.com/users/zmerlynn/orgs","repos_url":"https://api.github.com/users/zmerlynn/repos","events_url":"https://api.github.com/users/zmerlynn/events{/privacy}","received_events_url":"https://api.github.com/users/zmerlynn/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6125/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6125/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/6125/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/12a078571c6ef95e0f1d9470460246bdbe231172","head":{"label":"quinton-hoole:2015-03-27-services-e2e-namespaces","ref":"2015-03-27-services-e2e-namespaces","sha":"12a078571c6ef95e0f1d9470460246bdbe231172","user":{"login":"quinton-hoole","id":10390785,"avatar_url":"https://avatars.githubusercontent.com/u/10390785?v=3","gravatar_id":"","url":"https://api.github.com/users/quinton-hoole","html_url":"https://github.com/quinton-hoole","followers_url":"https://api.github.com/users/quinton-hoole/followers","following_url":"https://api.github.com/users/quinton-hoole/following{/other_user}","gists_url":"https://api.github.com/users/quinton-hoole/gists{/gist_id}","starred_url":"https://api.github.com/users/quinton-hoole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quinton-hoole/subscriptions","organizations_url":"https://api.github.com/users/quinton-hoole/orgs","repos_url":"https://api.github.com/users/quinton-hoole/repos","events_url":"https://api.github.com/users/quinton-hoole/events{/privacy}","received_events_url":"https://api.github.com/users/quinton-hoole/received_events","type":"User","site_admin":false},"repo":{"id":29155350,"name":"kubernetes","full_name":"quinton-hoole/kubernetes","owner":{"login":"quinton-hoole","id":10390785,"avatar_url":"https://avatars.githubusercontent.com/u/10390785?v=3","gravatar_id":"","url":"https://api.github.com/users/quinton-hoole","html_url":"https://github.com/quinton-hoole","followers_url":"https://api.github.com/users/quinton-hoole/followers","following_url":"https://api.github.com/users/quinton-hoole/following{/other_user}","gists_url":"https://api.github.com/users/quinton-hoole/gists{/gist_id}","starred_url":"https://api.github.com/users/quinton-hoole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quinton-hoole/subscriptions","organizations_url":"https://api.github.com/users/quinton-hoole/orgs","repos_url":"https://api.github.com/users/quinton-hoole/repos","events_url":"https://api.github.com/users/quinton-hoole/events{/privacy}","received_events_url":"https://api.github.com/users/quinton-hoole/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/quinton-hoole/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/quinton-hoole/kubernetes","forks_url":"https://api.github.com/repos/quinton-hoole/kubernetes/forks","keys_url":"https://api.github.com/repos/quinton-hoole/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quinton-hoole/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quinton-hoole/kubernetes/teams","hooks_url":"https://api.github.com/repos/quinton-hoole/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/quinton-hoole/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/quinton-hoole/kubernetes/events","assignees_url":"https://api.github.com/repos/quinton-hoole/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/quinton-hoole/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/quinton-hoole/kubernetes/tags","blobs_url":"https://api.github.com/repos/quinton-hoole/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quinton-hoole/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quinton-hoole/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/quinton-hoole/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quinton-hoole/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/quinton-hoole/kubernetes/languages","stargazers_url":"https://api.github.com/repos/quinton-hoole/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/quinton-hoole/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/quinton-hoole/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/quinton-hoole/kubernetes/subscription","commits_url":"https://api.github.com/repos/quinton-hoole/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/quinton-hoole/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/quinton-hoole/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/quinton-hoole/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/quinton-hoole/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/quinton-hoole/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quinton-hoole/kubernetes/merges","archive_url":"https://api.github.com/repos/quinton-hoole/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quinton-hoole/kubernetes/downloads","issues_url":"https://api.github.com/repos/quinton-hoole/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/quinton-hoole/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/quinton-hoole/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/quinton-hoole/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quinton-hoole/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/quinton-hoole/kubernetes/releases{/id}","created_at":"2015-01-12T20:28:39Z","updated_at":"2015-03-04T17:03:44Z","pushed_at":"2015-03-27T23:55:17Z","git_url":"git://github.com/quinton-hoole/kubernetes.git","ssh_url":"git@github.com:quinton-hoole/kubernetes.git","clone_url":"https://github.com/quinton-hoole/kubernetes.git","svn_url":"https://github.com/quinton-hoole/kubernetes","homepage":null,"size":36491,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"320df1d2ad97c0ea1271c84a10ce0dd19540fb8f","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-03-27T23:30:07Z","pushed_at":"2015-03-27T23:58:14Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":"http://kubernetes.io","size":117714,"stargazers_count":6777,"watchers_count":6777,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1293,"mirror_url":null,"open_issues_count":836,"forks":1293,"open_issues":836,"watchers":6777,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6125"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/6125"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/6125"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/6125/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6125/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6125/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/12a078571c6ef95e0f1d9470460246bdbe231172"}}}}