{"action":"created","issue":{"url":"https://api.github.com/repos/shopspring/decimal/issues/14","labels_url":"https://api.github.com/repos/shopspring/decimal/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/shopspring/decimal/issues/14/comments","events_url":"https://api.github.com/repos/shopspring/decimal/issues/14/events","html_url":"https://github.com/shopspring/decimal/pull/14","id":118419127,"number":14,"title":"Added support for Numeric type in db storage","user":{"login":"faide","id":494577,"avatar_url":"https://avatars.githubusercontent.com/u/494577?v=3","gravatar_id":"","url":"https://api.github.com/users/faide","html_url":"https://github.com/faide","followers_url":"https://api.github.com/users/faide/followers","following_url":"https://api.github.com/users/faide/following{/other_user}","gists_url":"https://api.github.com/users/faide/gists{/gist_id}","starred_url":"https://api.github.com/users/faide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faide/subscriptions","organizations_url":"https://api.github.com/users/faide/orgs","repos_url":"https://api.github.com/users/faide/repos","events_url":"https://api.github.com/users/faide/events{/privacy}","received_events_url":"https://api.github.com/users/faide/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-11-23T16:32:27Z","updated_at":"2015-12-03T13:47:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/shopspring/decimal/pulls/14","html_url":"https://github.com/shopspring/decimal/pull/14","diff_url":"https://github.com/shopspring/decimal/pull/14.diff","patch_url":"https://github.com/shopspring/decimal/pull/14.patch"},"body":"Hi,\r\n\r\nI would like to propose this small PR that enables to store data as Numeric in the database.\r\n\r\nI tested it with a small attached self contained program: \r\nhttps://gist.github.com/faide/3db008dced89b3872e54\r\n\r\nIf run against actual trunk it will fail, but when run against the patched version if will work as expected.\r\n\r\nI am open to discussions and/or suggestions on how to unittest this code or generally make it better :)"},"comment":{"url":"https://api.github.com/repos/shopspring/decimal/issues/comments/161644165","html_url":"https://github.com/shopspring/decimal/pull/14#issuecomment-161644165","issue_url":"https://api.github.com/repos/shopspring/decimal/issues/14","id":161644165,"user":{"login":"vadimg","id":618662,"avatar_url":"https://avatars.githubusercontent.com/u/618662?v=3","gravatar_id":"","url":"https://api.github.com/users/vadimg","html_url":"https://github.com/vadimg","followers_url":"https://api.github.com/users/vadimg/followers","following_url":"https://api.github.com/users/vadimg/following{/other_user}","gists_url":"https://api.github.com/users/vadimg/gists{/gist_id}","starred_url":"https://api.github.com/users/vadimg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadimg/subscriptions","organizations_url":"https://api.github.com/users/vadimg/orgs","repos_url":"https://api.github.com/users/vadimg/repos","events_url":"https://api.github.com/users/vadimg/events{/privacy}","received_events_url":"https://api.github.com/users/vadimg/received_events","type":"User","site_admin":false},"created_at":"2015-12-03T13:47:06Z","updated_at":"2015-12-03T13:47:06Z","body":"It's hard to add a test, because it depends on a sqlite library, which doesn't come with go. Therefore adding a sqlite test would require sqlite as a dependency... I wonder how other libraries handle this?\r\n\r\nGo's own sql library creates a mock driver: https://golang.org/src/database/sql/fakedb_test.go but unfortunately it is private."}}