{"action":"created","issue":{"url":"https://api.github.com/repos/davidsansome/python-cmake-buildsystem/issues/52","labels_url":"https://api.github.com/repos/davidsansome/python-cmake-buildsystem/issues/52/labels{/name}","comments_url":"https://api.github.com/repos/davidsansome/python-cmake-buildsystem/issues/52/comments","events_url":"https://api.github.com/repos/davidsansome/python-cmake-buildsystem/issues/52/events","html_url":"https://github.com/davidsansome/python-cmake-buildsystem/pull/52","id":90400575,"number":52,"title":"Changes to allow build of 2.7.10 both shared and static on Windows","user":{"login":"jrobcary","id":1441100,"avatar_url":"https://avatars.githubusercontent.com/u/1441100?v=3","gravatar_id":"","url":"https://api.github.com/users/jrobcary","html_url":"https://github.com/jrobcary","followers_url":"https://api.github.com/users/jrobcary/followers","following_url":"https://api.github.com/users/jrobcary/following{/other_user}","gists_url":"https://api.github.com/users/jrobcary/gists{/gist_id}","starred_url":"https://api.github.com/users/jrobcary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrobcary/subscriptions","organizations_url":"https://api.github.com/users/jrobcary/orgs","repos_url":"https://api.github.com/users/jrobcary/repos","events_url":"https://api.github.com/users/jrobcary/events{/privacy}","received_events_url":"https://api.github.com/users/jrobcary/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-06-23T14:10:50Z","updated_at":"2015-07-09T20:38:30Z","closed_at":"2015-07-09T20:11:09Z","pull_request":{"url":"https://api.github.com/repos/davidsansome/python-cmake-buildsystem/pulls/52","html_url":"https://github.com/davidsansome/python-cmake-buildsystem/pull/52","diff_url":"https://github.com/davidsansome/python-cmake-buildsystem/pull/52.diff","patch_url":"https://github.com/davidsansome/python-cmake-buildsystem/pull/52.patch"},"body":"Adding in some sources and libraries to get ssl and socketmodule to compile.\r\n\r\nAdded hashes for various versions of python.\r\n\r\n6d9e6d913b3dfd9fdf28b54f1c7030851798b84d and 05d019dcab4f1ee501db63f4654a675df7890135\r\nare reverses of each other and can be ignored.\r\n\r\nRemove some unnecessary uses of the PyAPI_FUNC macro in timefuncs.h and timemodule.c, as they were wrong and causing the shared windows build to fail."},"comment":{"url":"https://api.github.com/repos/davidsansome/python-cmake-buildsystem/issues/comments/120138357","html_url":"https://github.com/davidsansome/python-cmake-buildsystem/pull/52#issuecomment-120138357","issue_url":"https://api.github.com/repos/davidsansome/python-cmake-buildsystem/issues/52","id":120138357,"user":{"login":"jrobcary","id":1441100,"avatar_url":"https://avatars.githubusercontent.com/u/1441100?v=3","gravatar_id":"","url":"https://api.github.com/users/jrobcary","html_url":"https://github.com/jrobcary","followers_url":"https://api.github.com/users/jrobcary/followers","following_url":"https://api.github.com/users/jrobcary/following{/other_user}","gists_url":"https://api.github.com/users/jrobcary/gists{/gist_id}","starred_url":"https://api.github.com/users/jrobcary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrobcary/subscriptions","organizations_url":"https://api.github.com/users/jrobcary/orgs","repos_url":"https://api.github.com/users/jrobcary/repos","events_url":"https://api.github.com/users/jrobcary/events{/privacy}","received_events_url":"https://api.github.com/users/jrobcary/received_events","type":"User","site_admin":false},"created_at":"2015-07-09T20:38:30Z","updated_at":"2015-07-09T20:38:30Z","body":"Okay, will avoid the ctypes issue.  I will have that in one of my branches, as I need it for my\r\nown work.\r\n\r\nNext I will add one small change to get _socket builtin on Windows.  \r\n\r\nFinally, with regard to INSTALL_WINDOWS_TRADITIONAL, it is by default off, giving you the behavior you want.  But for our work on Windows we count on the Windows standard layout, which works better with Windows paths.  So I hope you could reconsider.  I'll work up a changeset that you can look at.\r\n\r\nThx..."}}