{"action":"closed","number":135,"pull_request":{"url":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/135","id":33116146,"html_url":"https://github.com/jclouds/jclouds-labs-google/pull/135","diff_url":"https://github.com/jclouds/jclouds-labs-google/pull/135.diff","patch_url":"https://github.com/jclouds/jclouds-labs-google/pull/135.patch","issue_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/issues/135","number":135,"state":"closed","locked":false,"title":"Add support for disks & ip forward during node creation","user":{"login":"yaronr","id":6322020,"avatar_url":"https://avatars.githubusercontent.com/u/6322020?v=3","gravatar_id":"","url":"https://api.github.com/users/yaronr","html_url":"https://github.com/yaronr","followers_url":"https://api.github.com/users/yaronr/followers","following_url":"https://api.github.com/users/yaronr/following{/other_user}","gists_url":"https://api.github.com/users/yaronr/gists{/gist_id}","starred_url":"https://api.github.com/users/yaronr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaronr/subscriptions","organizations_url":"https://api.github.com/users/yaronr/orgs","repos_url":"https://api.github.com/users/yaronr/repos","events_url":"https://api.github.com/users/yaronr/events{/privacy}","received_events_url":"https://api.github.com/users/yaronr/received_events","type":"User","site_admin":false},"body":"Hi\r\n\r\nThis adds support for specifying disks during node creation, either by adding specific disks to templateOptions, or by using a method called GCETemplateOptions.autoCreateDisk(..) which is useful in case multiple nodes are created using a single templateOptions.\r\nAlso added support for the canIpForward flag (defaults to false).\r\n\r\nBoth have been manually tested and verified on GCE. \r\nBoth changes are backwards compatible.\r\n\r\nI'm not sure whether unit tests are required for this change, but if so - I would need more guidance.\r\n\r\nI would like to ask for this to be added to 1.9.1, since this is a minor change with very minimal risk, and using GCE without it is impossible in my case.","created_at":"2015-04-12T07:11:52Z","updated_at":"2015-06-26T12:58:49Z","closed_at":"2015-06-26T12:58:49Z","merged_at":null,"merge_commit_sha":"dd13156ce946fc1c48ba64cb765862a42e7c974d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/135/commits","review_comments_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/135/comments","review_comment_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/issues/135/comments","statuses_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/statuses/65a65558aeed82a59fb8574ae21c106316e9605b","head":{"label":"yaronr:master","ref":"master","sha":"65a65558aeed82a59fb8574ae21c106316e9605b","user":{"login":"yaronr","id":6322020,"avatar_url":"https://avatars.githubusercontent.com/u/6322020?v=3","gravatar_id":"","url":"https://api.github.com/users/yaronr","html_url":"https://github.com/yaronr","followers_url":"https://api.github.com/users/yaronr/followers","following_url":"https://api.github.com/users/yaronr/following{/other_user}","gists_url":"https://api.github.com/users/yaronr/gists{/gist_id}","starred_url":"https://api.github.com/users/yaronr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaronr/subscriptions","organizations_url":"https://api.github.com/users/yaronr/orgs","repos_url":"https://api.github.com/users/yaronr/repos","events_url":"https://api.github.com/users/yaronr/events{/privacy}","received_events_url":"https://api.github.com/users/yaronr/received_events","type":"User","site_admin":false},"repo":{"id":32469035,"name":"jclouds-labs-google","full_name":"yaronr/jclouds-labs-google","owner":{"login":"yaronr","id":6322020,"avatar_url":"https://avatars.githubusercontent.com/u/6322020?v=3","gravatar_id":"","url":"https://api.github.com/users/yaronr","html_url":"https://github.com/yaronr","followers_url":"https://api.github.com/users/yaronr/followers","following_url":"https://api.github.com/users/yaronr/following{/other_user}","gists_url":"https://api.github.com/users/yaronr/gists{/gist_id}","starred_url":"https://api.github.com/users/yaronr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaronr/subscriptions","organizations_url":"https://api.github.com/users/yaronr/orgs","repos_url":"https://api.github.com/users/yaronr/repos","events_url":"https://api.github.com/users/yaronr/events{/privacy}","received_events_url":"https://api.github.com/users/yaronr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yaronr/jclouds-labs-google","description":"Read-only mirror of ASF Git Repo for jclouds labs-google","fork":true,"url":"https://api.github.com/repos/yaronr/jclouds-labs-google","forks_url":"https://api.github.com/repos/yaronr/jclouds-labs-google/forks","keys_url":"https://api.github.com/repos/yaronr/jclouds-labs-google/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yaronr/jclouds-labs-google/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yaronr/jclouds-labs-google/teams","hooks_url":"https://api.github.com/repos/yaronr/jclouds-labs-google/hooks","issue_events_url":"https://api.github.com/repos/yaronr/jclouds-labs-google/issues/events{/number}","events_url":"https://api.github.com/repos/yaronr/jclouds-labs-google/events","assignees_url":"https://api.github.com/repos/yaronr/jclouds-labs-google/assignees{/user}","branches_url":"https://api.github.com/repos/yaronr/jclouds-labs-google/branches{/branch}","tags_url":"https://api.github.com/repos/yaronr/jclouds-labs-google/tags","blobs_url":"https://api.github.com/repos/yaronr/jclouds-labs-google/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yaronr/jclouds-labs-google/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yaronr/jclouds-labs-google/git/refs{/sha}","trees_url":"https://api.github.com/repos/yaronr/jclouds-labs-google/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yaronr/jclouds-labs-google/statuses/{sha}","languages_url":"https://api.github.com/repos/yaronr/jclouds-labs-google/languages","stargazers_url":"https://api.github.com/repos/yaronr/jclouds-labs-google/stargazers","contributors_url":"https://api.github.com/repos/yaronr/jclouds-labs-google/contributors","subscribers_url":"https://api.github.com/repos/yaronr/jclouds-labs-google/subscribers","subscription_url":"https://api.github.com/repos/yaronr/jclouds-labs-google/subscription","commits_url":"https://api.github.com/repos/yaronr/jclouds-labs-google/commits{/sha}","git_commits_url":"https://api.github.com/repos/yaronr/jclouds-labs-google/git/commits{/sha}","comments_url":"https://api.github.com/repos/yaronr/jclouds-labs-google/comments{/number}","issue_comment_url":"https://api.github.com/repos/yaronr/jclouds-labs-google/issues/comments{/number}","contents_url":"https://api.github.com/repos/yaronr/jclouds-labs-google/contents/{+path}","compare_url":"https://api.github.com/repos/yaronr/jclouds-labs-google/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yaronr/jclouds-labs-google/merges","archive_url":"https://api.github.com/repos/yaronr/jclouds-labs-google/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yaronr/jclouds-labs-google/downloads","issues_url":"https://api.github.com/repos/yaronr/jclouds-labs-google/issues{/number}","pulls_url":"https://api.github.com/repos/yaronr/jclouds-labs-google/pulls{/number}","milestones_url":"https://api.github.com/repos/yaronr/jclouds-labs-google/milestones{/number}","notifications_url":"https://api.github.com/repos/yaronr/jclouds-labs-google/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yaronr/jclouds-labs-google/labels{/name}","releases_url":"https://api.github.com/repos/yaronr/jclouds-labs-google/releases{/id}","created_at":"2015-03-18T16:01:01Z","updated_at":"2015-04-14T07:45:32Z","pushed_at":"2015-06-21T07:52:56Z","git_url":"git://github.com/yaronr/jclouds-labs-google.git","ssh_url":"git@github.com:yaronr/jclouds-labs-google.git","clone_url":"https://github.com/yaronr/jclouds-labs-google.git","svn_url":"https://github.com/yaronr/jclouds-labs-google","homepage":null,"size":2529,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jclouds:master","ref":"master","sha":"ed4b89f302906b348e65b4e2f2cecec292d4fd5a","user":{"login":"jclouds","id":108982,"avatar_url":"https://avatars.githubusercontent.com/u/108982?v=3","gravatar_id":"","url":"https://api.github.com/users/jclouds","html_url":"https://github.com/jclouds","followers_url":"https://api.github.com/users/jclouds/followers","following_url":"https://api.github.com/users/jclouds/following{/other_user}","gists_url":"https://api.github.com/users/jclouds/gists{/gist_id}","starred_url":"https://api.github.com/users/jclouds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jclouds/subscriptions","organizations_url":"https://api.github.com/users/jclouds/orgs","repos_url":"https://api.github.com/users/jclouds/repos","events_url":"https://api.github.com/users/jclouds/events{/privacy}","received_events_url":"https://api.github.com/users/jclouds/received_events","type":"Organization","site_admin":false},"repo":{"id":10040995,"name":"jclouds-labs-google","full_name":"jclouds/jclouds-labs-google","owner":{"login":"jclouds","id":108982,"avatar_url":"https://avatars.githubusercontent.com/u/108982?v=3","gravatar_id":"","url":"https://api.github.com/users/jclouds","html_url":"https://github.com/jclouds","followers_url":"https://api.github.com/users/jclouds/followers","following_url":"https://api.github.com/users/jclouds/following{/other_user}","gists_url":"https://api.github.com/users/jclouds/gists{/gist_id}","starred_url":"https://api.github.com/users/jclouds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jclouds/subscriptions","organizations_url":"https://api.github.com/users/jclouds/orgs","repos_url":"https://api.github.com/users/jclouds/repos","events_url":"https://api.github.com/users/jclouds/events{/privacy}","received_events_url":"https://api.github.com/users/jclouds/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jclouds/jclouds-labs-google","description":"Read-only mirror of ASF Git Repo for jclouds labs-google","fork":false,"url":"https://api.github.com/repos/jclouds/jclouds-labs-google","forks_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/forks","keys_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/teams","hooks_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/hooks","issue_events_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/issues/events{/number}","events_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/events","assignees_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/assignees{/user}","branches_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/branches{/branch}","tags_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/tags","blobs_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/git/refs{/sha}","trees_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/statuses/{sha}","languages_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/languages","stargazers_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/stargazers","contributors_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/contributors","subscribers_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/subscribers","subscription_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/subscription","commits_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/commits{/sha}","git_commits_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/git/commits{/sha}","comments_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/comments{/number}","issue_comment_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/issues/comments{/number}","contents_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/contents/{+path}","compare_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/merges","archive_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/downloads","issues_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/issues{/number}","pulls_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls{/number}","milestones_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/milestones{/number}","notifications_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/labels{/name}","releases_url":"https://api.github.com/repos/jclouds/jclouds-labs-google/releases{/id}","created_at":"2013-05-13T20:48:38Z","updated_at":"2015-05-01T20:47:34Z","pushed_at":"2015-06-26T12:52:45Z","git_url":"git://github.com/jclouds/jclouds-labs-google.git","ssh_url":"git@github.com:jclouds/jclouds-labs-google.git","clone_url":"https://github.com/jclouds/jclouds-labs-google.git","svn_url":"https://github.com/jclouds/jclouds-labs-google","homepage":null,"size":4482,"stargazers_count":16,"watchers_count":16,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":1,"forks":41,"open_issues":1,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/135"},"html":{"href":"https://github.com/jclouds/jclouds-labs-google/pull/135"},"issue":{"href":"https://api.github.com/repos/jclouds/jclouds-labs-google/issues/135"},"comments":{"href":"https://api.github.com/repos/jclouds/jclouds-labs-google/issues/135/comments"},"review_comments":{"href":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/135/comments"},"review_comment":{"href":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jclouds/jclouds-labs-google/pulls/135/commits"},"statuses":{"href":"https://api.github.com/repos/jclouds/jclouds-labs-google/statuses/65a65558aeed82a59fb8574ae21c106316e9605b"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":10,"review_comments":6,"commits":11,"additions":165,"deletions":51,"changed_files":7}}