{"action":"created","issue":{"url":"https://api.github.com/repos/ipfs/go-ipld/issues/14","labels_url":"https://api.github.com/repos/ipfs/go-ipld/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/ipfs/go-ipld/issues/14/comments","events_url":"https://api.github.com/repos/ipfs/go-ipld/issues/14/events","html_url":"https://github.com/ipfs/go-ipld/issues/14","id":113321199,"number":14,"title":"Implement missing features to include IPLD in IPFS","user":{"login":"mildred","id":33804,"avatar_url":"https://avatars.githubusercontent.com/u/33804?v=3","gravatar_id":"","url":"https://api.github.com/users/mildred","html_url":"https://github.com/mildred","followers_url":"https://api.github.com/users/mildred/followers","following_url":"https://api.github.com/users/mildred/following{/other_user}","gists_url":"https://api.github.com/users/mildred/gists{/gist_id}","starred_url":"https://api.github.com/users/mildred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mildred/subscriptions","organizations_url":"https://api.github.com/users/mildred/orgs","repos_url":"https://api.github.com/users/mildred/repos","events_url":"https://api.github.com/users/mildred/events{/privacy}","received_events_url":"https://api.github.com/users/mildred/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-10-26T09:58:14Z","updated_at":"2015-10-29T17:40:12Z","closed_at":null,"body":"Perhaps we don't need to do anything, but I would think that perhaps we are missing a fes things to integrate IPLD in IPFS.\r\n\r\nIf I'm not mistaken, the go-ipld package should replace [github.com/ipfs/go-ipfs/merkledag](/ipfs/go-ipfs/tree/master/merkledag) package. Is that right ?\r\n\r\nIf so, I'd think we should modify both the old merkledag package to look a bit more like go-ipld (remove external access to struct members, rename a few things to match go-ipld function names if needed). That will also require modifying the core of ipfs.\r\n\r\nThen, we must implement any missing function (if any) in go-ipld, and make the switch.\r\n\r\nDoes that sound like a good idea ? @jbenet, anyone ?"},"comment":{"url":"https://api.github.com/repos/ipfs/go-ipld/issues/comments/152260693","html_url":"https://github.com/ipfs/go-ipld/issues/14#issuecomment-152260693","issue_url":"https://api.github.com/repos/ipfs/go-ipld/issues/14","id":152260693,"user":{"login":"whyrusleeping","id":1243164,"avatar_url":"https://avatars.githubusercontent.com/u/1243164?v=3","gravatar_id":"","url":"https://api.github.com/users/whyrusleeping","html_url":"https://github.com/whyrusleeping","followers_url":"https://api.github.com/users/whyrusleeping/followers","following_url":"https://api.github.com/users/whyrusleeping/following{/other_user}","gists_url":"https://api.github.com/users/whyrusleeping/gists{/gist_id}","starred_url":"https://api.github.com/users/whyrusleeping/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whyrusleeping/subscriptions","organizations_url":"https://api.github.com/users/whyrusleeping/orgs","repos_url":"https://api.github.com/users/whyrusleeping/repos","events_url":"https://api.github.com/users/whyrusleeping/events{/privacy}","received_events_url":"https://api.github.com/users/whyrusleeping/received_events","type":"User","site_admin":false},"created_at":"2015-10-29T17:40:12Z","updated_at":"2015-10-29T17:40:12Z","body":"I'm not super sure whats happening here, but some feedback i can provide:\r\n\r\nThe 'Node' field in the link objects is very useful, but isnt something we want serialized, its just a cache to make working on the trees easier. Removing it would be fine, but might make certain operations on dags a little slower.\r\n\r\nIn regards to moving merkledag out into its own package, gx is getting a lot nicer, i can probably try it out for extracting that package soon"}}