{"action":"created","comment":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/comments/48085856","id":48085856,"diff_hunk":"@@ -0,0 +1,72 @@\n+/*\n+ * Licensed to the University of California, Berkeley under one or more contributor license\n+ * agreements. See the NOTICE file distributed with this work for additional information regarding\n+ * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance with the License. You may obtain a\n+ * copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software distributed under the License\n+ * is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express\n+ * or implied. See the License for the specific language governing permissions and limitations under\n+ * the License.\n+ */\n+\n+package tachyon.client.file.policy;\n+\n+import java.util.List;\n+\n+import com.google.common.base.Preconditions;\n+\n+import tachyon.client.block.BlockWorkerInfo;\n+import tachyon.client.file.options.OutStreamOptions;\n+\n+/**\n+ * A policy that chooses the worker for the next block in a RR manner and skips workers that do not\n+ * have enough space. The policy returns null if no worker can be found.\n+ */\n+public final class RoundRobinPolicy implements FileWriteLocationPolicy {\n+  private final OutStreamOptions mOptions;\n+  private final List<BlockWorkerInfo> mWorkerInfoList;\n+  private int mIndex = 0;\n+\n+  /**\n+   * Creates the policy.\n+   */\n+  public RoundRobinPolicy(List<BlockWorkerInfo> workerInfoList, OutStreamOptions options) {\n+    mOptions = Preconditions.checkNotNull(options);\n+    mWorkerInfoList = Preconditions.checkNotNull(workerInfoList);\n+  }\n+\n+  @Override\n+  public String getWorkerForNextBlock(List<BlockWorkerInfo> workerInfoList) {\n+    // at most try all the workers\n+    for (int i = 0; i < mWorkerInfoList.size(); i ++) {\n+      String candidate = mWorkerInfoList.get(mIndex).getHost();\n+      BlockWorkerInfo workerInfo = findBlockWorkerInfo(workerInfoList, candidate);\n+      if (workerInfo == null || workerInfo.getCapacityBytes() - workerInfo.getUsedBytes() < mOptions\n+          .getBlockSizeBytes()) {\n+        continue;","path":"clients/unshaded/src/main/java/tachyon/client/file/policy/RoundRobinPolicy.java","position":50,"original_position":50,"commit_id":"e96246f4991dbf37dc05b20408a4e59fad4dd0aa","original_commit_id":"e96246f4991dbf37dc05b20408a4e59fad4dd0aa","user":{"login":"aaudiber","id":3455177,"avatar_url":"https://avatars.githubusercontent.com/u/3455177?v=3","gravatar_id":"","url":"https://api.github.com/users/aaudiber","html_url":"https://github.com/aaudiber","followers_url":"https://api.github.com/users/aaudiber/followers","following_url":"https://api.github.com/users/aaudiber/following{/other_user}","gists_url":"https://api.github.com/users/aaudiber/gists{/gist_id}","starred_url":"https://api.github.com/users/aaudiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaudiber/subscriptions","organizations_url":"https://api.github.com/users/aaudiber/orgs","repos_url":"https://api.github.com/users/aaudiber/repos","events_url":"https://api.github.com/users/aaudiber/events{/privacy}","received_events_url":"https://api.github.com/users/aaudiber/received_events","type":"User","site_admin":false},"body":"this never updates `mIndex`, trying the same worker again and again","created_at":"2015-12-19T01:12:43Z","updated_at":"2015-12-19T01:12:43Z","html_url":"https://github.com/amplab/tachyon/pull/2284#discussion_r48085856","pull_request_url":"https://api.github.com/repos/amplab/tachyon/pulls/2284","_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments/48085856"},"html":{"href":"https://github.com/amplab/tachyon/pull/2284#discussion_r48085856"},"pull_request":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/2284"}}},"pull_request":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/2284","id":54054352,"html_url":"https://github.com/amplab/tachyon/pull/2284","diff_url":"https://github.com/amplab/tachyon/pull/2284.diff","patch_url":"https://github.com/amplab/tachyon/pull/2284.patch","issue_url":"https://api.github.com/repos/amplab/tachyon/issues/2284","number":2284,"state":"open","locked":false,"title":"[TACHYON-845] Support pluggable location policy on client ","user":{"login":"yupeng9","id":13425258,"avatar_url":"https://avatars.githubusercontent.com/u/13425258?v=3","gravatar_id":"","url":"https://api.github.com/users/yupeng9","html_url":"https://github.com/yupeng9","followers_url":"https://api.github.com/users/yupeng9/followers","following_url":"https://api.github.com/users/yupeng9/following{/other_user}","gists_url":"https://api.github.com/users/yupeng9/gists{/gist_id}","starred_url":"https://api.github.com/users/yupeng9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yupeng9/subscriptions","organizations_url":"https://api.github.com/users/yupeng9/orgs","repos_url":"https://api.github.com/users/yupeng9/repos","events_url":"https://api.github.com/users/yupeng9/events{/privacy}","received_events_url":"https://api.github.com/users/yupeng9/received_events","type":"User","site_admin":false},"body":"https://tachyon.atlassian.net/browse/TACHYON-860?jql=text%20~%20%22location%20policy%22\r\n\r\nThis PR provides a pluggable location-policy interface on client, and some built-in policies. A policy instance is created per FileOutStream, and the stream will ask the policy for the worker to write the next block.","created_at":"2015-12-18T01:18:37Z","updated_at":"2015-12-19T01:12:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"48e3d5fd6591c11e55c488520da23540d39f7623","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/amplab/tachyon/pulls/2284/commits","review_comments_url":"https://api.github.com/repos/amplab/tachyon/pulls/2284/comments","review_comment_url":"https://api.github.com/repos/amplab/tachyon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/amplab/tachyon/issues/2284/comments","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/e96246f4991dbf37dc05b20408a4e59fad4dd0aa","head":{"label":"yupeng9:locationPolicy","ref":"locationPolicy","sha":"e96246f4991dbf37dc05b20408a4e59fad4dd0aa","user":{"login":"yupeng9","id":13425258,"avatar_url":"https://avatars.githubusercontent.com/u/13425258?v=3","gravatar_id":"","url":"https://api.github.com/users/yupeng9","html_url":"https://github.com/yupeng9","followers_url":"https://api.github.com/users/yupeng9/followers","following_url":"https://api.github.com/users/yupeng9/following{/other_user}","gists_url":"https://api.github.com/users/yupeng9/gists{/gist_id}","starred_url":"https://api.github.com/users/yupeng9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yupeng9/subscriptions","organizations_url":"https://api.github.com/users/yupeng9/orgs","repos_url":"https://api.github.com/users/yupeng9/repos","events_url":"https://api.github.com/users/yupeng9/events{/privacy}","received_events_url":"https://api.github.com/users/yupeng9/received_events","type":"User","site_admin":false},"repo":{"id":39411244,"name":"tachyon","full_name":"yupeng9/tachyon","owner":{"login":"yupeng9","id":13425258,"avatar_url":"https://avatars.githubusercontent.com/u/13425258?v=3","gravatar_id":"","url":"https://api.github.com/users/yupeng9","html_url":"https://github.com/yupeng9","followers_url":"https://api.github.com/users/yupeng9/followers","following_url":"https://api.github.com/users/yupeng9/following{/other_user}","gists_url":"https://api.github.com/users/yupeng9/gists{/gist_id}","starred_url":"https://api.github.com/users/yupeng9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yupeng9/subscriptions","organizations_url":"https://api.github.com/users/yupeng9/orgs","repos_url":"https://api.github.com/users/yupeng9/repos","events_url":"https://api.github.com/users/yupeng9/events{/privacy}","received_events_url":"https://api.github.com/users/yupeng9/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yupeng9/tachyon","description":" A Reliable Memory Centric Distributed Storage System","fork":true,"url":"https://api.github.com/repos/yupeng9/tachyon","forks_url":"https://api.github.com/repos/yupeng9/tachyon/forks","keys_url":"https://api.github.com/repos/yupeng9/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yupeng9/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yupeng9/tachyon/teams","hooks_url":"https://api.github.com/repos/yupeng9/tachyon/hooks","issue_events_url":"https://api.github.com/repos/yupeng9/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/yupeng9/tachyon/events","assignees_url":"https://api.github.com/repos/yupeng9/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/yupeng9/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/yupeng9/tachyon/tags","blobs_url":"https://api.github.com/repos/yupeng9/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yupeng9/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yupeng9/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/yupeng9/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yupeng9/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/yupeng9/tachyon/languages","stargazers_url":"https://api.github.com/repos/yupeng9/tachyon/stargazers","contributors_url":"https://api.github.com/repos/yupeng9/tachyon/contributors","subscribers_url":"https://api.github.com/repos/yupeng9/tachyon/subscribers","subscription_url":"https://api.github.com/repos/yupeng9/tachyon/subscription","commits_url":"https://api.github.com/repos/yupeng9/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/yupeng9/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/yupeng9/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/yupeng9/tachyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/yupeng9/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/yupeng9/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yupeng9/tachyon/merges","archive_url":"https://api.github.com/repos/yupeng9/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yupeng9/tachyon/downloads","issues_url":"https://api.github.com/repos/yupeng9/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/yupeng9/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/yupeng9/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/yupeng9/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yupeng9/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/yupeng9/tachyon/releases{/id}","created_at":"2015-07-20T22:20:20Z","updated_at":"2015-07-20T22:20:22Z","pushed_at":"2015-12-18T23:03:33Z","git_url":"git://github.com/yupeng9/tachyon.git","ssh_url":"git@github.com:yupeng9/tachyon.git","clone_url":"https://github.com/yupeng9/tachyon.git","svn_url":"https://github.com/yupeng9/tachyon","homepage":"http://tachyon-project.org","size":33664,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"amplab:master","ref":"master","sha":"81ea5abad6e5422e0221d5d2d4e72a6ed714175e","user":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=3","gravatar_id":"","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"name":"tachyon","full_name":"amplab/tachyon","owner":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=3","gravatar_id":"","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/amplab/tachyon","description":"Memory Centric Reliable Distributed Storage","fork":false,"url":"https://api.github.com/repos/amplab/tachyon","forks_url":"https://api.github.com/repos/amplab/tachyon/forks","keys_url":"https://api.github.com/repos/amplab/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amplab/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amplab/tachyon/teams","hooks_url":"https://api.github.com/repos/amplab/tachyon/hooks","issue_events_url":"https://api.github.com/repos/amplab/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/amplab/tachyon/events","assignees_url":"https://api.github.com/repos/amplab/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/amplab/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/amplab/tachyon/tags","blobs_url":"https://api.github.com/repos/amplab/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amplab/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amplab/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/amplab/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/amplab/tachyon/languages","stargazers_url":"https://api.github.com/repos/amplab/tachyon/stargazers","contributors_url":"https://api.github.com/repos/amplab/tachyon/contributors","subscribers_url":"https://api.github.com/repos/amplab/tachyon/subscribers","subscription_url":"https://api.github.com/repos/amplab/tachyon/subscription","commits_url":"https://api.github.com/repos/amplab/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/amplab/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/amplab/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/amplab/tachyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/amplab/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/amplab/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amplab/tachyon/merges","archive_url":"https://api.github.com/repos/amplab/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amplab/tachyon/downloads","issues_url":"https://api.github.com/repos/amplab/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/amplab/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/amplab/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/amplab/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amplab/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/amplab/tachyon/releases{/id}","created_at":"2012-12-21T17:43:46Z","updated_at":"2015-12-18T23:00:18Z","pushed_at":"2015-12-19T00:31:22Z","git_url":"git://github.com/amplab/tachyon.git","ssh_url":"git@github.com:amplab/tachyon.git","clone_url":"https://github.com/amplab/tachyon.git","svn_url":"https://github.com/amplab/tachyon","homepage":"http://tachyon-project.org","size":41753,"stargazers_count":1811,"watchers_count":1811,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":716,"mirror_url":null,"open_issues_count":27,"forks":716,"open_issues":27,"watchers":1811,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/2284"},"html":{"href":"https://github.com/amplab/tachyon/pull/2284"},"issue":{"href":"https://api.github.com/repos/amplab/tachyon/issues/2284"},"comments":{"href":"https://api.github.com/repos/amplab/tachyon/issues/2284/comments"},"review_comments":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/2284/comments"},"review_comment":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/2284/commits"},"statuses":{"href":"https://api.github.com/repos/amplab/tachyon/statuses/e96246f4991dbf37dc05b20408a4e59fad4dd0aa"}}}}