{"action":"created","issue":{"url":"https://api.github.com/repos/debrief/debrief/issues/1161","labels_url":"https://api.github.com/repos/debrief/debrief/issues/1161/labels{/name}","comments_url":"https://api.github.com/repos/debrief/debrief/issues/1161/comments","events_url":"https://api.github.com/repos/debrief/debrief/issues/1161/events","html_url":"https://github.com/debrief/debrief/issues/1161","id":65917285,"number":1161,"title":"English language property names","user":{"login":"IanMayo","id":1108513,"avatar_url":"https://avatars.githubusercontent.com/u/1108513?v=3","gravatar_id":"","url":"https://api.github.com/users/IanMayo","html_url":"https://github.com/IanMayo","followers_url":"https://api.github.com/users/IanMayo/followers","following_url":"https://api.github.com/users/IanMayo/following{/other_user}","gists_url":"https://api.github.com/users/IanMayo/gists{/gist_id}","starred_url":"https://api.github.com/users/IanMayo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IanMayo/subscriptions","organizations_url":"https://api.github.com/users/IanMayo/orgs","repos_url":"https://api.github.com/users/IanMayo/repos","events_url":"https://api.github.com/users/IanMayo/events{/privacy}","received_events_url":"https://api.github.com/users/IanMayo/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/debrief/debrief/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/debrief/debrief/labels/sys_ui","name":"sys_ui","color":"bfd4f2"}],"state":"open","locked":false,"assignee":{"login":"pecko","id":534584,"avatar_url":"https://avatars.githubusercontent.com/u/534584?v=3","gravatar_id":"","url":"https://api.github.com/users/pecko","html_url":"https://github.com/pecko","followers_url":"https://api.github.com/users/pecko/followers","following_url":"https://api.github.com/users/pecko/following{/other_user}","gists_url":"https://api.github.com/users/pecko/gists{/gist_id}","starred_url":"https://api.github.com/users/pecko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pecko/subscriptions","organizations_url":"https://api.github.com/users/pecko/orgs","repos_url":"https://api.github.com/users/pecko/repos","events_url":"https://api.github.com/users/pecko/events{/privacy}","received_events_url":"https://api.github.com/users/pecko/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/debrief/debrief/milestones/3","html_url":"https://github.com/debrief/debrief/milestones/Current","labels_url":"https://api.github.com/repos/debrief/debrief/milestones/3/labels","id":664166,"number":3,"title":"Current","description":"General issues that would benefit most users","creator":{"login":"IanMayo","id":1108513,"avatar_url":"https://avatars.githubusercontent.com/u/1108513?v=3","gravatar_id":"","url":"https://api.github.com/users/IanMayo","html_url":"https://github.com/IanMayo","followers_url":"https://api.github.com/users/IanMayo/followers","following_url":"https://api.github.com/users/IanMayo/following{/other_user}","gists_url":"https://api.github.com/users/IanMayo/gists{/gist_id}","starred_url":"https://api.github.com/users/IanMayo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IanMayo/subscriptions","organizations_url":"https://api.github.com/users/IanMayo/orgs","repos_url":"https://api.github.com/users/IanMayo/repos","events_url":"https://api.github.com/users/IanMayo/events{/privacy}","received_events_url":"https://api.github.com/users/IanMayo/received_events","type":"User","site_admin":false},"open_issues":23,"closed_issues":45,"state":"open","created_at":"2014-05-20T08:28:43Z","updated_at":"2015-05-20T14:56:36Z","due_on":null,"closed_at":null},"comments":8,"created_at":"2015-04-02T12:41:47Z","updated_at":"2015-05-21T17:36:16Z","closed_at":null,"body":"For years and years we've presented the Java Getter/Setter method names to users, both in the properties window (below), and in right-click context menus.\r\n\r\n![propertynames](https://cloud.githubusercontent.com/assets/1108513/6964031/432b4e6e-d93d-11e4-9602-34365f1e7f52.png)\r\n\r\nIt's probably time to switch to properties that use proper english language & spaces.  I propose we modify the prop() and expertProp() methods to introduce another String parameter. This String will be presented to the user.\r\n\r\nThe UI logic will use this String, not the raw property name.\r\n\r\nWe'll use mixed case, not all capitals - so \"LineThickness\" above will be represented as \"Line thickness\".\r\n\r\nEclipse will help us do this, by highlighting all instances using <ctrl-G>.  There's a chance that the methods have already been overloaded with extra String parameters - so be sure to start with the longest signatures, then work on the shortest signatures.\r\n\r\nAn example of how the properties are declared is in SensorWrapper.SensorInfo class.  The Editable methods called ultimately create PropertyDescriptor objects. I think the current implementation relies on the PropertyName to determine the read/write methods. So, I believe our code will have to use the longer PropertyDescriptor method that explicitly provides the read/write methods."},"comment":{"url":"https://api.github.com/repos/debrief/debrief/issues/comments/104366922","html_url":"https://github.com/debrief/debrief/issues/1161#issuecomment-104366922","issue_url":"https://api.github.com/repos/debrief/debrief/issues/1161","id":104366922,"user":{"login":"pecko","id":534584,"avatar_url":"https://avatars.githubusercontent.com/u/534584?v=3","gravatar_id":"","url":"https://api.github.com/users/pecko","html_url":"https://github.com/pecko","followers_url":"https://api.github.com/users/pecko/followers","following_url":"https://api.github.com/users/pecko/following{/other_user}","gists_url":"https://api.github.com/users/pecko/gists{/gist_id}","starred_url":"https://api.github.com/users/pecko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pecko/subscriptions","organizations_url":"https://api.github.com/users/pecko/orgs","repos_url":"https://api.github.com/users/pecko/repos","events_url":"https://api.github.com/users/pecko/events{/privacy}","received_events_url":"https://api.github.com/users/pecko/received_events","type":"User","site_admin":false},"created_at":"2015-05-21T17:36:16Z","updated_at":"2015-05-21T17:36:16Z","body":"The PropertyDescriptor class already has the displayName property. This property is used in the Properties view and context menu. Currently, we have the same valuse for the name and displayName property.\r\n\r\nI suggest that we create a new methods: prop(...), expertProp(...) ...as follows:\r\n\r\n- name of method will be displayProp, displayExpertProp ...\r\n- method will have one additional parameter - displayName in regard to corresponding method\r\n\r\nAfter that we just need update the EditorType class for different editable.\r\nI have created example in the  issue1161 branch. The patch in this branch (commit: https://github.com/pecko/debrief/commit/8bb77049e265e59d6d17a489f3fa1fda70f1f493) solves this issue for tracks and sensors.\r\n@IanMayo If you agree I will fix other objects.\r\n\r\nBTW\r\nI don't make compile errors because you can easily see what is changed in commit (4 classes only).\r\n\r\nScreenshot:\r\n\r\n![image](https://cloud.githubusercontent.com/assets/534584/7754924/a2d819d0-fff0-11e4-88a3-4324c8dd725a.png)\r\n"}}