{"action":"closed","number":8179,"pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/8179","id":32043896,"html_url":"https://github.com/laravel/framework/pull/8179","diff_url":"https://github.com/laravel/framework/pull/8179.diff","patch_url":"https://github.com/laravel/framework/pull/8179.patch","issue_url":"https://api.github.com/repos/laravel/framework/issues/8179","number":8179,"state":"closed","locked":false,"title":"[5.0] Routing: cache URL root and scheme per request","user":{"login":"toddbc","id":1657421,"avatar_url":"https://avatars.githubusercontent.com/u/1657421?v=3","gravatar_id":"","url":"https://api.github.com/users/toddbc","html_url":"https://github.com/toddbc","followers_url":"https://api.github.com/users/toddbc/followers","following_url":"https://api.github.com/users/toddbc/following{/other_user}","gists_url":"https://api.github.com/users/toddbc/gists{/gist_id}","starred_url":"https://api.github.com/users/toddbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toddbc/subscriptions","organizations_url":"https://api.github.com/users/toddbc/orgs","repos_url":"https://api.github.com/users/toddbc/repos","events_url":"https://api.github.com/users/toddbc/events{/privacy}","received_events_url":"https://api.github.com/users/toddbc/received_events","type":"User","site_admin":false},"body":"This cuts down on time spent determining e.g. route URLs, which can end up being a lot depending on the application (for example, lists, navigation, etc. may contain many links.)\r\n\r\nIn an application that generates about 150 total URLs on a list page, this improves runtime by over 7%.\r\n\r\nThere should be no backward compatibility impact from this change, in general usage.  If a user mutates `ServerBag`/`HeaderBag` values directly, after retrieving a URL, it could generate stale results, but this is already generally a problem in `request->getBaseUrl()`, so it would've generated partially stale results before as well.","created_at":"2015-03-26T17:59:45Z","updated_at":"2015-03-26T19:04:02Z","closed_at":"2015-03-26T19:04:02Z","merged_at":"2015-03-26T19:04:02Z","merge_commit_sha":"6844951d48e80b3c656b3cda1245fb9955a27509","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/laravel/framework/pulls/8179/commits","review_comments_url":"https://api.github.com/repos/laravel/framework/pulls/8179/comments","review_comment_url":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/laravel/framework/issues/8179/comments","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/4f5ba5c5c596604647de67ceaac9f4d10219fe7d","head":{"label":"toddbc:urlgen-cache","ref":"urlgen-cache","sha":"4f5ba5c5c596604647de67ceaac9f4d10219fe7d","user":{"login":"toddbc","id":1657421,"avatar_url":"https://avatars.githubusercontent.com/u/1657421?v=3","gravatar_id":"","url":"https://api.github.com/users/toddbc","html_url":"https://github.com/toddbc","followers_url":"https://api.github.com/users/toddbc/followers","following_url":"https://api.github.com/users/toddbc/following{/other_user}","gists_url":"https://api.github.com/users/toddbc/gists{/gist_id}","starred_url":"https://api.github.com/users/toddbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toddbc/subscriptions","organizations_url":"https://api.github.com/users/toddbc/orgs","repos_url":"https://api.github.com/users/toddbc/repos","events_url":"https://api.github.com/users/toddbc/events{/privacy}","received_events_url":"https://api.github.com/users/toddbc/received_events","type":"User","site_admin":false},"repo":{"id":32837273,"name":"laravel-framework","full_name":"toddbc/laravel-framework","owner":{"login":"toddbc","id":1657421,"avatar_url":"https://avatars.githubusercontent.com/u/1657421?v=3","gravatar_id":"","url":"https://api.github.com/users/toddbc","html_url":"https://github.com/toddbc","followers_url":"https://api.github.com/users/toddbc/followers","following_url":"https://api.github.com/users/toddbc/following{/other_user}","gists_url":"https://api.github.com/users/toddbc/gists{/gist_id}","starred_url":"https://api.github.com/users/toddbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toddbc/subscriptions","organizations_url":"https://api.github.com/users/toddbc/orgs","repos_url":"https://api.github.com/users/toddbc/repos","events_url":"https://api.github.com/users/toddbc/events{/privacy}","received_events_url":"https://api.github.com/users/toddbc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/toddbc/laravel-framework","description":"","fork":true,"url":"https://api.github.com/repos/toddbc/laravel-framework","forks_url":"https://api.github.com/repos/toddbc/laravel-framework/forks","keys_url":"https://api.github.com/repos/toddbc/laravel-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toddbc/laravel-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toddbc/laravel-framework/teams","hooks_url":"https://api.github.com/repos/toddbc/laravel-framework/hooks","issue_events_url":"https://api.github.com/repos/toddbc/laravel-framework/issues/events{/number}","events_url":"https://api.github.com/repos/toddbc/laravel-framework/events","assignees_url":"https://api.github.com/repos/toddbc/laravel-framework/assignees{/user}","branches_url":"https://api.github.com/repos/toddbc/laravel-framework/branches{/branch}","tags_url":"https://api.github.com/repos/toddbc/laravel-framework/tags","blobs_url":"https://api.github.com/repos/toddbc/laravel-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toddbc/laravel-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toddbc/laravel-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/toddbc/laravel-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toddbc/laravel-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/toddbc/laravel-framework/languages","stargazers_url":"https://api.github.com/repos/toddbc/laravel-framework/stargazers","contributors_url":"https://api.github.com/repos/toddbc/laravel-framework/contributors","subscribers_url":"https://api.github.com/repos/toddbc/laravel-framework/subscribers","subscription_url":"https://api.github.com/repos/toddbc/laravel-framework/subscription","commits_url":"https://api.github.com/repos/toddbc/laravel-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/toddbc/laravel-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/toddbc/laravel-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/toddbc/laravel-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/toddbc/laravel-framework/contents/{+path}","compare_url":"https://api.github.com/repos/toddbc/laravel-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toddbc/laravel-framework/merges","archive_url":"https://api.github.com/repos/toddbc/laravel-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toddbc/laravel-framework/downloads","issues_url":"https://api.github.com/repos/toddbc/laravel-framework/issues{/number}","pulls_url":"https://api.github.com/repos/toddbc/laravel-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/toddbc/laravel-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/toddbc/laravel-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toddbc/laravel-framework/labels{/name}","releases_url":"https://api.github.com/repos/toddbc/laravel-framework/releases{/id}","created_at":"2015-03-25T02:16:07Z","updated_at":"2015-03-25T02:26:42Z","pushed_at":"2015-03-26T18:12:20Z","git_url":"git://github.com/toddbc/laravel-framework.git","ssh_url":"git@github.com:toddbc/laravel-framework.git","clone_url":"https://github.com/toddbc/laravel-framework.git","svn_url":"https://github.com/toddbc/laravel-framework","homepage":"http://laravel.com","size":14561,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.0"}},"base":{"label":"laravel:5.0","ref":"5.0","sha":"a161e7cc440b36f783df5b17a7a612996c345abd","user":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"repo":{"id":7548986,"name":"framework","full_name":"laravel/framework","owner":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/laravel/framework","description":"","fork":false,"url":"https://api.github.com/repos/laravel/framework","forks_url":"https://api.github.com/repos/laravel/framework/forks","keys_url":"https://api.github.com/repos/laravel/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laravel/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laravel/framework/teams","hooks_url":"https://api.github.com/repos/laravel/framework/hooks","issue_events_url":"https://api.github.com/repos/laravel/framework/issues/events{/number}","events_url":"https://api.github.com/repos/laravel/framework/events","assignees_url":"https://api.github.com/repos/laravel/framework/assignees{/user}","branches_url":"https://api.github.com/repos/laravel/framework/branches{/branch}","tags_url":"https://api.github.com/repos/laravel/framework/tags","blobs_url":"https://api.github.com/repos/laravel/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laravel/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laravel/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/laravel/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/laravel/framework/languages","stargazers_url":"https://api.github.com/repos/laravel/framework/stargazers","contributors_url":"https://api.github.com/repos/laravel/framework/contributors","subscribers_url":"https://api.github.com/repos/laravel/framework/subscribers","subscription_url":"https://api.github.com/repos/laravel/framework/subscription","commits_url":"https://api.github.com/repos/laravel/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/laravel/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/laravel/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/laravel/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/laravel/framework/contents/{+path}","compare_url":"https://api.github.com/repos/laravel/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laravel/framework/merges","archive_url":"https://api.github.com/repos/laravel/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laravel/framework/downloads","issues_url":"https://api.github.com/repos/laravel/framework/issues{/number}","pulls_url":"https://api.github.com/repos/laravel/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/laravel/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/laravel/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laravel/framework/labels{/name}","releases_url":"https://api.github.com/repos/laravel/framework/releases{/id}","created_at":"2013-01-10T21:27:28Z","updated_at":"2015-03-26T19:04:01Z","pushed_at":"2015-03-26T19:04:01Z","git_url":"git://github.com/laravel/framework.git","ssh_url":"git@github.com:laravel/framework.git","clone_url":"https://github.com/laravel/framework.git","svn_url":"https://github.com/laravel/framework","homepage":"http://laravel.com","size":61412,"stargazers_count":3373,"watchers_count":3373,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1837,"mirror_url":null,"open_issues_count":94,"forks":1837,"open_issues":94,"watchers":3373,"default_branch":"5.0"}},"_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/8179"},"html":{"href":"https://github.com/laravel/framework/pull/8179"},"issue":{"href":"https://api.github.com/repos/laravel/framework/issues/8179"},"comments":{"href":"https://api.github.com/repos/laravel/framework/issues/8179/comments"},"review_comments":{"href":"https://api.github.com/repos/laravel/framework/pulls/8179/comments"},"review_comment":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/laravel/framework/pulls/8179/commits"},"statuses":{"href":"https://api.github.com/repos/laravel/framework/statuses/4f5ba5c5c596604647de67ceaac9f4d10219fe7d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"taylorotwell","id":463230,"avatar_url":"https://avatars.githubusercontent.com/u/463230?v=3","gravatar_id":"","url":"https://api.github.com/users/taylorotwell","html_url":"https://github.com/taylorotwell","followers_url":"https://api.github.com/users/taylorotwell/followers","following_url":"https://api.github.com/users/taylorotwell/following{/other_user}","gists_url":"https://api.github.com/users/taylorotwell/gists{/gist_id}","starred_url":"https://api.github.com/users/taylorotwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taylorotwell/subscriptions","organizations_url":"https://api.github.com/users/taylorotwell/orgs","repos_url":"https://api.github.com/users/taylorotwell/repos","events_url":"https://api.github.com/users/taylorotwell/events{/privacy}","received_events_url":"https://api.github.com/users/taylorotwell/received_events","type":"User","site_admin":false},"comments":0,"review_comments":3,"commits":1,"additions":31,"deletions":3,"changed_files":1}}