{"action":"created","issue":{"url":"https://api.github.com/repos/google/UIforETW/issues/25","labels_url":"https://api.github.com/repos/google/UIforETW/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/google/UIforETW/issues/25/comments","events_url":"https://api.github.com/repos/google/UIforETW/issues/25/events","html_url":"https://github.com/google/UIforETW/pull/25","id":73842055,"number":25,"title":"changed `assert`s to `ATLASSERT`s","user":{"login":"ariccio","id":2142308,"avatar_url":"https://avatars.githubusercontent.com/u/2142308?v=3","gravatar_id":"","url":"https://api.github.com/users/ariccio","html_url":"https://github.com/ariccio","followers_url":"https://api.github.com/users/ariccio/followers","following_url":"https://api.github.com/users/ariccio/following{/other_user}","gists_url":"https://api.github.com/users/ariccio/gists{/gist_id}","starred_url":"https://api.github.com/users/ariccio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariccio/subscriptions","organizations_url":"https://api.github.com/users/ariccio/orgs","repos_url":"https://api.github.com/users/ariccio/repos","events_url":"https://api.github.com/users/ariccio/events{/privacy}","received_events_url":"https://api.github.com/users/ariccio/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-05-07T04:53:16Z","updated_at":"2015-05-12T23:46:06Z","closed_at":"2015-05-11T17:10:03Z","pull_request":{"url":"https://api.github.com/repos/google/UIforETW/pulls/25","html_url":"https://github.com/google/UIforETW/pull/25","diff_url":"https://github.com/google/UIforETW/pull/25.diff","patch_url":"https://github.com/google/UIforETW/pull/25.patch"},"body":"I also inserted `_Pre_satisfies_` annotations for function and object/member function preconditions.\r\n\r\nIn `Settings.cpp`, I changed an implicit conversion of `*CSettings`/`*this` to `HWND` (via `CWnd::operator HWND`) to explicitly passing m_hWnd.\r\n\r\n\r\n`ATLASSERT` calls `_CrtDbgBreak` instead of `abort`, and is generally suited better to UI programming."},"comment":{"url":"https://api.github.com/repos/google/UIforETW/issues/comments/101461431","html_url":"https://github.com/google/UIforETW/pull/25#issuecomment-101461431","issue_url":"https://api.github.com/repos/google/UIforETW/issues/25","id":101461431,"user":{"login":"randomascii","id":10800041,"avatar_url":"https://avatars.githubusercontent.com/u/10800041?v=3","gravatar_id":"","url":"https://api.github.com/users/randomascii","html_url":"https://github.com/randomascii","followers_url":"https://api.github.com/users/randomascii/followers","following_url":"https://api.github.com/users/randomascii/following{/other_user}","gists_url":"https://api.github.com/users/randomascii/gists{/gist_id}","starred_url":"https://api.github.com/users/randomascii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randomascii/subscriptions","organizations_url":"https://api.github.com/users/randomascii/orgs","repos_url":"https://api.github.com/users/randomascii/repos","events_url":"https://api.github.com/users/randomascii/events{/privacy}","received_events_url":"https://api.github.com/users/randomascii/received_events","type":"User","site_admin":false},"created_at":"2015-05-12T23:46:06Z","updated_at":"2015-05-12T23:46:06Z","body":"Spoiler alert: it's set when the underlying window is created.\n\nOn Tue, May 12, 2015 at 4:40 PM, Alexander Riccio <notifications@github.com>\nwrote:\n\n> Sidenote:\n> MFC really goes overboard on using macro expansion to add a layer of\n> \"abstraction\" to message maps:\n> ON_BN_CLICKED(IDC_COPYSTARTUPPROFILE,\n> &CSettings::OnBnClickedCopystartupprofile) is expanded to ON_CONTROL(BN_CLICKED,\n> IDC_COPYSTARTUPPROFILE, &CSettings::OnBnClickedCopystartupprofile), which\n> is further expanded to { WM_COMMAND, (WORD)BN_CLICKED, (WORD)id,\n> (WORD)IDC_COPYSTARTUPPROFILE, AfxSigCmd_v, (static_cast< AFX_PMSG >\n> (&CSettings::OnBnClickedCopystartupprofile)) }\n>\n> ...which makes it *really fun* to try to track the usage/initialization\n> of m_hWnd\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/google/UIforETW/pull/25#issuecomment-101460723>.\n>\n\n\n\n-- \nBruce Dawson\n"}}