{"action":"created","issue":{"url":"https://api.github.com/repos/q55x8x/Peronality-Creator/issues/27","labels_url":"https://api.github.com/repos/q55x8x/Peronality-Creator/issues/27/labels{/name}","comments_url":"https://api.github.com/repos/q55x8x/Peronality-Creator/issues/27/comments","events_url":"https://api.github.com/repos/q55x8x/Peronality-Creator/issues/27/events","html_url":"https://github.com/q55x8x/Peronality-Creator/issues/27","id":103038010,"number":27,"title":"Opening lone scripts not working anymore","user":{"login":"png2","id":13354505,"avatar_url":"https://avatars.githubusercontent.com/u/13354505?v=3","gravatar_id":"","url":"https://api.github.com/users/png2","html_url":"https://github.com/png2","followers_url":"https://api.github.com/users/png2/followers","following_url":"https://api.github.com/users/png2/following{/other_user}","gists_url":"https://api.github.com/users/png2/gists{/gist_id}","starred_url":"https://api.github.com/users/png2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/png2/subscriptions","organizations_url":"https://api.github.com/users/png2/orgs","repos_url":"https://api.github.com/users/png2/repos","events_url":"https://api.github.com/users/png2/events{/privacy}","received_events_url":"https://api.github.com/users/png2/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/q55x8x/Peronality-Creator/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-08-25T14:43:48Z","updated_at":"2015-08-25T17:11:03Z","closed_at":null,"body":"I have no idea what you tried to do there since it's a lot more complex than before when you call the OpenFile function but I can't open scripts not attached to a persona anymore\r\n\r\nWhy did you separate the opening of modules and fragments?\r\nAnd why attaching the files to the persona tree? "},"comment":{"url":"https://api.github.com/repos/q55x8x/Peronality-Creator/issues/comments/134673307","html_url":"https://github.com/q55x8x/Peronality-Creator/issues/27#issuecomment-134673307","issue_url":"https://api.github.com/repos/q55x8x/Peronality-Creator/issues/27","id":134673307,"user":{"login":"png2","id":13354505,"avatar_url":"https://avatars.githubusercontent.com/u/13354505?v=3","gravatar_id":"","url":"https://api.github.com/users/png2","html_url":"https://github.com/png2","followers_url":"https://api.github.com/users/png2/followers","following_url":"https://api.github.com/users/png2/following{/other_user}","gists_url":"https://api.github.com/users/png2/gists{/gist_id}","starred_url":"https://api.github.com/users/png2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/png2/subscriptions","organizations_url":"https://api.github.com/users/png2/orgs","repos_url":"https://api.github.com/users/png2/repos","events_url":"https://api.github.com/users/png2/events{/privacy}","received_events_url":"https://api.github.com/users/png2/received_events","type":"User","site_admin":false},"created_at":"2015-08-25T17:11:03Z","updated_at":"2015-08-25T17:11:03Z","body":"I proposed a rewrite on the branch fileOpeningRework based on an object approach and by extracting all the stuff linked to the content of the tab from the main frame\r\n\r\nIf you want to add a new type of tab, you have to implement the OpenableFile abstract class (done by default by PersonaFile that is still abstract and by Script that implement the current editor)\r\n\r\nThat means that each file type contain all the stuff needed to make it work in the tab system and that the main frame doesn't care what type of file it manipulates\r\n\r\nFor now the factory that build the files is still in PersonaFile, at one point it might be a good idea to extract it in a dedicated class since not all files might be implement PersonaFile\r\n\r\nLet me know what you think of it, if you are ok with it I'll merge it in the master otherwise we can brainstorm on other implementations  "}}