{"action":"created","comment":{"url":"https://api.github.com/repos/gpbl/redux500/pulls/comments/37724892","id":37724892,"diff_hunk":"@@ -0,0 +1,16 @@\n+import { PHOTO_LOAD_REQUEST, PHOTO_LOAD_SUCCESS, PHOTO_LOAD_FAILURE } from \"../constants/ActionTypes\";\n+\n+export function getPhoto(id) {\n+  return {\n+    types: [\n+      PHOTO_LOAD_REQUEST,\n+      PHOTO_LOAD_SUCCESS,\n+      PHOTO_LOAD_FAILURE\n+    ],","path":"src/actions/photo.js","position":9,"original_position":9,"commit_id":"a4c1fad15438cb530c6323ea563365a262b31960","original_commit_id":"a4c1fad15438cb530c6323ea563365a262b31960","user":{"login":"gpbl","id":120693,"avatar_url":"https://avatars.githubusercontent.com/u/120693?v=3","gravatar_id":"","url":"https://api.github.com/users/gpbl","html_url":"https://github.com/gpbl","followers_url":"https://api.github.com/users/gpbl/followers","following_url":"https://api.github.com/users/gpbl/following{/other_user}","gists_url":"https://api.github.com/users/gpbl/gists{/gist_id}","starred_url":"https://api.github.com/users/gpbl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpbl/subscriptions","organizations_url":"https://api.github.com/users/gpbl/orgs","repos_url":"https://api.github.com/users/gpbl/repos","events_url":"https://api.github.com/users/gpbl/events{/privacy}","received_events_url":"https://api.github.com/users/gpbl/received_events","type":"User","site_admin":false},"body":"Keep in mind I didn't read anything yet about redux middlewares: but is an array here a redux convention? Couldn't we write a object: \r\n\r\n```\r\ntypes: {\r\n   onRequest: PHOTO_LOAD_REQUEST,\r\n   onSuccess: PHOTO_LOAD_SUCCESS,\r\n   onFailure: PHOTO_LOAD_FAILURE\r\n}\r\n```","created_at":"2015-08-24T07:28:29Z","updated_at":"2015-08-24T07:28:29Z","html_url":"https://github.com/gpbl/redux500/pull/17#discussion_r37724892","pull_request_url":"https://api.github.com/repos/gpbl/redux500/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/gpbl/redux500/pulls/comments/37724892"},"html":{"href":"https://github.com/gpbl/redux500/pull/17#discussion_r37724892"},"pull_request":{"href":"https://api.github.com/repos/gpbl/redux500/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/gpbl/redux500/pulls/17","id":43124066,"html_url":"https://github.com/gpbl/redux500/pull/17","diff_url":"https://github.com/gpbl/redux500/pull/17.diff","patch_url":"https://github.com/gpbl/redux500/pull/17.patch","issue_url":"https://api.github.com/repos/gpbl/redux500/issues/17","number":17,"state":"open","locked":false,"title":"Redux/photo","user":{"login":"geekyme","id":977460,"avatar_url":"https://avatars.githubusercontent.com/u/977460?v=3","gravatar_id":"","url":"https://api.github.com/users/geekyme","html_url":"https://github.com/geekyme","followers_url":"https://api.github.com/users/geekyme/followers","following_url":"https://api.github.com/users/geekyme/following{/other_user}","gists_url":"https://api.github.com/users/geekyme/gists{/gist_id}","starred_url":"https://api.github.com/users/geekyme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geekyme/subscriptions","organizations_url":"https://api.github.com/users/geekyme/orgs","repos_url":"https://api.github.com/users/geekyme/repos","events_url":"https://api.github.com/users/geekyme/events{/privacy}","received_events_url":"https://api.github.com/users/geekyme/received_events","type":"User","site_admin":false},"body":"releasing this early so you can see what i've made.\r\n\r\nWhat I've completed: \r\n- an abstraction over superagent with promises added (works like fetchr) called ApiClient\r\n- a middleware which works with the above and dispatch *_REQUEST, *_SUCCESS, *_FAILURE actions\r\n- an action creator `getPhoto` that uses ApiClient and works with the middleware\r\n\r\nNot completed:\r\n- reducer to receive the actions from `getPhoto` and update the store\r\n- connect the PhotoPage to rerender on store change\r\n- tests\r\n- readme","created_at":"2015-08-23T16:30:36Z","updated_at":"2015-08-24T07:28:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"781e6b104c95d11175f3738acd65b02bb04f5a4d","assignee":{"login":"gpbl","id":120693,"avatar_url":"https://avatars.githubusercontent.com/u/120693?v=3","gravatar_id":"","url":"https://api.github.com/users/gpbl","html_url":"https://github.com/gpbl","followers_url":"https://api.github.com/users/gpbl/followers","following_url":"https://api.github.com/users/gpbl/following{/other_user}","gists_url":"https://api.github.com/users/gpbl/gists{/gist_id}","starred_url":"https://api.github.com/users/gpbl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpbl/subscriptions","organizations_url":"https://api.github.com/users/gpbl/orgs","repos_url":"https://api.github.com/users/gpbl/repos","events_url":"https://api.github.com/users/gpbl/events{/privacy}","received_events_url":"https://api.github.com/users/gpbl/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/gpbl/redux500/pulls/17/commits","review_comments_url":"https://api.github.com/repos/gpbl/redux500/pulls/17/comments","review_comment_url":"https://api.github.com/repos/gpbl/redux500/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gpbl/redux500/issues/17/comments","statuses_url":"https://api.github.com/repos/gpbl/redux500/statuses/a4c1fad15438cb530c6323ea563365a262b31960","head":{"label":"gpbl:redux/photo","ref":"redux/photo","sha":"a4c1fad15438cb530c6323ea563365a262b31960","user":{"login":"gpbl","id":120693,"avatar_url":"https://avatars.githubusercontent.com/u/120693?v=3","gravatar_id":"","url":"https://api.github.com/users/gpbl","html_url":"https://github.com/gpbl","followers_url":"https://api.github.com/users/gpbl/followers","following_url":"https://api.github.com/users/gpbl/following{/other_user}","gists_url":"https://api.github.com/users/gpbl/gists{/gist_id}","starred_url":"https://api.github.com/users/gpbl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpbl/subscriptions","organizations_url":"https://api.github.com/users/gpbl/orgs","repos_url":"https://api.github.com/users/gpbl/repos","events_url":"https://api.github.com/users/gpbl/events{/privacy}","received_events_url":"https://api.github.com/users/gpbl/received_events","type":"User","site_admin":false},"repo":{"id":40661707,"name":"redux500","full_name":"gpbl/redux500","owner":{"login":"gpbl","id":120693,"avatar_url":"https://avatars.githubusercontent.com/u/120693?v=3","gravatar_id":"","url":"https://api.github.com/users/gpbl","html_url":"https://github.com/gpbl","followers_url":"https://api.github.com/users/gpbl/followers","following_url":"https://api.github.com/users/gpbl/following{/other_user}","gists_url":"https://api.github.com/users/gpbl/gists{/gist_id}","starred_url":"https://api.github.com/users/gpbl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpbl/subscriptions","organizations_url":"https://api.github.com/users/gpbl/orgs","repos_url":"https://api.github.com/users/gpbl/repos","events_url":"https://api.github.com/users/gpbl/events{/privacy}","received_events_url":"https://api.github.com/users/gpbl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gpbl/redux500","description":"","fork":false,"url":"https://api.github.com/repos/gpbl/redux500","forks_url":"https://api.github.com/repos/gpbl/redux500/forks","keys_url":"https://api.github.com/repos/gpbl/redux500/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gpbl/redux500/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gpbl/redux500/teams","hooks_url":"https://api.github.com/repos/gpbl/redux500/hooks","issue_events_url":"https://api.github.com/repos/gpbl/redux500/issues/events{/number}","events_url":"https://api.github.com/repos/gpbl/redux500/events","assignees_url":"https://api.github.com/repos/gpbl/redux500/assignees{/user}","branches_url":"https://api.github.com/repos/gpbl/redux500/branches{/branch}","tags_url":"https://api.github.com/repos/gpbl/redux500/tags","blobs_url":"https://api.github.com/repos/gpbl/redux500/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gpbl/redux500/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gpbl/redux500/git/refs{/sha}","trees_url":"https://api.github.com/repos/gpbl/redux500/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gpbl/redux500/statuses/{sha}","languages_url":"https://api.github.com/repos/gpbl/redux500/languages","stargazers_url":"https://api.github.com/repos/gpbl/redux500/stargazers","contributors_url":"https://api.github.com/repos/gpbl/redux500/contributors","subscribers_url":"https://api.github.com/repos/gpbl/redux500/subscribers","subscription_url":"https://api.github.com/repos/gpbl/redux500/subscription","commits_url":"https://api.github.com/repos/gpbl/redux500/commits{/sha}","git_commits_url":"https://api.github.com/repos/gpbl/redux500/git/commits{/sha}","comments_url":"https://api.github.com/repos/gpbl/redux500/comments{/number}","issue_comment_url":"https://api.github.com/repos/gpbl/redux500/issues/comments{/number}","contents_url":"https://api.github.com/repos/gpbl/redux500/contents/{+path}","compare_url":"https://api.github.com/repos/gpbl/redux500/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gpbl/redux500/merges","archive_url":"https://api.github.com/repos/gpbl/redux500/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gpbl/redux500/downloads","issues_url":"https://api.github.com/repos/gpbl/redux500/issues{/number}","pulls_url":"https://api.github.com/repos/gpbl/redux500/pulls{/number}","milestones_url":"https://api.github.com/repos/gpbl/redux500/milestones{/number}","notifications_url":"https://api.github.com/repos/gpbl/redux500/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gpbl/redux500/labels{/name}","releases_url":"https://api.github.com/repos/gpbl/redux500/releases{/id}","created_at":"2015-08-13T13:59:53Z","updated_at":"2015-08-17T10:22:55Z","pushed_at":"2015-08-24T06:23:37Z","git_url":"git://github.com/gpbl/redux500.git","ssh_url":"git@github.com:gpbl/redux500.git","clone_url":"https://github.com/gpbl/redux500.git","svn_url":"https://github.com/gpbl/redux500","homepage":null,"size":439,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":3,"default_branch":"master"}},"base":{"label":"gpbl:master","ref":"master","sha":"9fc4c164727b679426d64a0223231f194f5e9737","user":{"login":"gpbl","id":120693,"avatar_url":"https://avatars.githubusercontent.com/u/120693?v=3","gravatar_id":"","url":"https://api.github.com/users/gpbl","html_url":"https://github.com/gpbl","followers_url":"https://api.github.com/users/gpbl/followers","following_url":"https://api.github.com/users/gpbl/following{/other_user}","gists_url":"https://api.github.com/users/gpbl/gists{/gist_id}","starred_url":"https://api.github.com/users/gpbl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpbl/subscriptions","organizations_url":"https://api.github.com/users/gpbl/orgs","repos_url":"https://api.github.com/users/gpbl/repos","events_url":"https://api.github.com/users/gpbl/events{/privacy}","received_events_url":"https://api.github.com/users/gpbl/received_events","type":"User","site_admin":false},"repo":{"id":40661707,"name":"redux500","full_name":"gpbl/redux500","owner":{"login":"gpbl","id":120693,"avatar_url":"https://avatars.githubusercontent.com/u/120693?v=3","gravatar_id":"","url":"https://api.github.com/users/gpbl","html_url":"https://github.com/gpbl","followers_url":"https://api.github.com/users/gpbl/followers","following_url":"https://api.github.com/users/gpbl/following{/other_user}","gists_url":"https://api.github.com/users/gpbl/gists{/gist_id}","starred_url":"https://api.github.com/users/gpbl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpbl/subscriptions","organizations_url":"https://api.github.com/users/gpbl/orgs","repos_url":"https://api.github.com/users/gpbl/repos","events_url":"https://api.github.com/users/gpbl/events{/privacy}","received_events_url":"https://api.github.com/users/gpbl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gpbl/redux500","description":"","fork":false,"url":"https://api.github.com/repos/gpbl/redux500","forks_url":"https://api.github.com/repos/gpbl/redux500/forks","keys_url":"https://api.github.com/repos/gpbl/redux500/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gpbl/redux500/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gpbl/redux500/teams","hooks_url":"https://api.github.com/repos/gpbl/redux500/hooks","issue_events_url":"https://api.github.com/repos/gpbl/redux500/issues/events{/number}","events_url":"https://api.github.com/repos/gpbl/redux500/events","assignees_url":"https://api.github.com/repos/gpbl/redux500/assignees{/user}","branches_url":"https://api.github.com/repos/gpbl/redux500/branches{/branch}","tags_url":"https://api.github.com/repos/gpbl/redux500/tags","blobs_url":"https://api.github.com/repos/gpbl/redux500/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gpbl/redux500/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gpbl/redux500/git/refs{/sha}","trees_url":"https://api.github.com/repos/gpbl/redux500/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gpbl/redux500/statuses/{sha}","languages_url":"https://api.github.com/repos/gpbl/redux500/languages","stargazers_url":"https://api.github.com/repos/gpbl/redux500/stargazers","contributors_url":"https://api.github.com/repos/gpbl/redux500/contributors","subscribers_url":"https://api.github.com/repos/gpbl/redux500/subscribers","subscription_url":"https://api.github.com/repos/gpbl/redux500/subscription","commits_url":"https://api.github.com/repos/gpbl/redux500/commits{/sha}","git_commits_url":"https://api.github.com/repos/gpbl/redux500/git/commits{/sha}","comments_url":"https://api.github.com/repos/gpbl/redux500/comments{/number}","issue_comment_url":"https://api.github.com/repos/gpbl/redux500/issues/comments{/number}","contents_url":"https://api.github.com/repos/gpbl/redux500/contents/{+path}","compare_url":"https://api.github.com/repos/gpbl/redux500/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gpbl/redux500/merges","archive_url":"https://api.github.com/repos/gpbl/redux500/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gpbl/redux500/downloads","issues_url":"https://api.github.com/repos/gpbl/redux500/issues{/number}","pulls_url":"https://api.github.com/repos/gpbl/redux500/pulls{/number}","milestones_url":"https://api.github.com/repos/gpbl/redux500/milestones{/number}","notifications_url":"https://api.github.com/repos/gpbl/redux500/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gpbl/redux500/labels{/name}","releases_url":"https://api.github.com/repos/gpbl/redux500/releases{/id}","created_at":"2015-08-13T13:59:53Z","updated_at":"2015-08-17T10:22:55Z","pushed_at":"2015-08-24T06:23:37Z","git_url":"git://github.com/gpbl/redux500.git","ssh_url":"git@github.com:gpbl/redux500.git","clone_url":"https://github.com/gpbl/redux500.git","svn_url":"https://github.com/gpbl/redux500","homepage":null,"size":439,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gpbl/redux500/pulls/17"},"html":{"href":"https://github.com/gpbl/redux500/pull/17"},"issue":{"href":"https://api.github.com/repos/gpbl/redux500/issues/17"},"comments":{"href":"https://api.github.com/repos/gpbl/redux500/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/gpbl/redux500/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/gpbl/redux500/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gpbl/redux500/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/gpbl/redux500/statuses/a4c1fad15438cb530c6323ea563365a262b31960"}}}}