{"action":"created","comment":{"url":"https://api.github.com/repos/juju/environschema/pulls/comments/42510044","id":42510044,"diff_hunk":"@@ -99,6 +99,19 @@ type IOFiller struct {\n \t// ShowDescriptions holds whether attribute descriptions\n \t// should be printed as well as the attribute names.\n \tShowDescriptions bool\n+\n+\t// GetDefault returns the default value for the given attribute,\n+\t// which must have been coerced using the given checker.\n+\t// If there is no default, it should return (nil, \"\", nil).","path":"form/form.go","position":7,"original_position":7,"commit_id":"81394ddaf68d8c8b960bc298c7488e87f9c14828","original_commit_id":"81394ddaf68d8c8b960bc298c7488e87f9c14828","user":{"login":"mattyw","id":160718,"avatar_url":"https://avatars.githubusercontent.com/u/160718?v=3","gravatar_id":"","url":"https://api.github.com/users/mattyw","html_url":"https://github.com/mattyw","followers_url":"https://api.github.com/users/mattyw/followers","following_url":"https://api.github.com/users/mattyw/following{/other_user}","gists_url":"https://api.github.com/users/mattyw/gists{/gist_id}","starred_url":"https://api.github.com/users/mattyw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattyw/subscriptions","organizations_url":"https://api.github.com/users/mattyw/orgs","repos_url":"https://api.github.com/users/mattyw/repos","events_url":"https://api.github.com/users/mattyw/events{/privacy}","received_events_url":"https://api.github.com/users/mattyw/received_events","type":"User","site_admin":false},"body":"it should return or does return?","created_at":"2015-10-20T15:21:45Z","updated_at":"2015-10-20T15:21:45Z","html_url":"https://github.com/juju/environschema/pull/12#discussion_r42510044","pull_request_url":"https://api.github.com/repos/juju/environschema/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/juju/environschema/pulls/comments/42510044"},"html":{"href":"https://github.com/juju/environschema/pull/12#discussion_r42510044"},"pull_request":{"href":"https://api.github.com/repos/juju/environschema/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/juju/environschema/pulls/12","id":48215299,"html_url":"https://github.com/juju/environschema/pull/12","diff_url":"https://github.com/juju/environschema/pull/12.diff","patch_url":"https://github.com/juju/environschema/pull/12.patch","issue_url":"https://api.github.com/repos/juju/environschema/issues/12","number":12,"state":"open","locked":false,"title":"form: allow custom GetDefault method","user":{"login":"rogpeppe","id":66491,"avatar_url":"https://avatars.githubusercontent.com/u/66491?v=3","gravatar_id":"","url":"https://api.github.com/users/rogpeppe","html_url":"https://github.com/rogpeppe","followers_url":"https://api.github.com/users/rogpeppe/followers","following_url":"https://api.github.com/users/rogpeppe/following{/other_user}","gists_url":"https://api.github.com/users/rogpeppe/gists{/gist_id}","starred_url":"https://api.github.com/users/rogpeppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogpeppe/subscriptions","organizations_url":"https://api.github.com/users/rogpeppe/orgs","repos_url":"https://api.github.com/users/rogpeppe/repos","events_url":"https://api.github.com/users/rogpeppe/events{/privacy}","received_events_url":"https://api.github.com/users/rogpeppe/received_events","type":"User","site_admin":false},"body":"This will make it feasible to add default that come from files\r\n(and avoid printing the whole contents of the file too).\r\n","created_at":"2015-10-20T15:19:18Z","updated_at":"2015-10-20T15:21:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf683e9ed157c9ab017e1aa33ca0461e57a7792f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juju/environschema/pulls/12/commits","review_comments_url":"https://api.github.com/repos/juju/environschema/pulls/12/comments","review_comment_url":"https://api.github.com/repos/juju/environschema/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju/environschema/issues/12/comments","statuses_url":"https://api.github.com/repos/juju/environschema/statuses/81394ddaf68d8c8b960bc298c7488e87f9c14828","head":{"label":"rogpeppe:011-custom-defaults","ref":"011-custom-defaults","sha":"81394ddaf68d8c8b960bc298c7488e87f9c14828","user":{"login":"rogpeppe","id":66491,"avatar_url":"https://avatars.githubusercontent.com/u/66491?v=3","gravatar_id":"","url":"https://api.github.com/users/rogpeppe","html_url":"https://github.com/rogpeppe","followers_url":"https://api.github.com/users/rogpeppe/followers","following_url":"https://api.github.com/users/rogpeppe/following{/other_user}","gists_url":"https://api.github.com/users/rogpeppe/gists{/gist_id}","starred_url":"https://api.github.com/users/rogpeppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogpeppe/subscriptions","organizations_url":"https://api.github.com/users/rogpeppe/orgs","repos_url":"https://api.github.com/users/rogpeppe/repos","events_url":"https://api.github.com/users/rogpeppe/events{/privacy}","received_events_url":"https://api.github.com/users/rogpeppe/received_events","type":"User","site_admin":false},"repo":{"id":36725125,"name":"environschema","full_name":"rogpeppe/environschema","owner":{"login":"rogpeppe","id":66491,"avatar_url":"https://avatars.githubusercontent.com/u/66491?v=3","gravatar_id":"","url":"https://api.github.com/users/rogpeppe","html_url":"https://github.com/rogpeppe","followers_url":"https://api.github.com/users/rogpeppe/followers","following_url":"https://api.github.com/users/rogpeppe/following{/other_user}","gists_url":"https://api.github.com/users/rogpeppe/gists{/gist_id}","starred_url":"https://api.github.com/users/rogpeppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogpeppe/subscriptions","organizations_url":"https://api.github.com/users/rogpeppe/orgs","repos_url":"https://api.github.com/users/rogpeppe/repos","events_url":"https://api.github.com/users/rogpeppe/events{/privacy}","received_events_url":"https://api.github.com/users/rogpeppe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rogpeppe/environschema","description":"schema descriptions for Juju environment configurations","fork":true,"url":"https://api.github.com/repos/rogpeppe/environschema","forks_url":"https://api.github.com/repos/rogpeppe/environschema/forks","keys_url":"https://api.github.com/repos/rogpeppe/environschema/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rogpeppe/environschema/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rogpeppe/environschema/teams","hooks_url":"https://api.github.com/repos/rogpeppe/environschema/hooks","issue_events_url":"https://api.github.com/repos/rogpeppe/environschema/issues/events{/number}","events_url":"https://api.github.com/repos/rogpeppe/environschema/events","assignees_url":"https://api.github.com/repos/rogpeppe/environschema/assignees{/user}","branches_url":"https://api.github.com/repos/rogpeppe/environschema/branches{/branch}","tags_url":"https://api.github.com/repos/rogpeppe/environschema/tags","blobs_url":"https://api.github.com/repos/rogpeppe/environschema/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rogpeppe/environschema/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rogpeppe/environschema/git/refs{/sha}","trees_url":"https://api.github.com/repos/rogpeppe/environschema/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rogpeppe/environschema/statuses/{sha}","languages_url":"https://api.github.com/repos/rogpeppe/environschema/languages","stargazers_url":"https://api.github.com/repos/rogpeppe/environschema/stargazers","contributors_url":"https://api.github.com/repos/rogpeppe/environschema/contributors","subscribers_url":"https://api.github.com/repos/rogpeppe/environschema/subscribers","subscription_url":"https://api.github.com/repos/rogpeppe/environschema/subscription","commits_url":"https://api.github.com/repos/rogpeppe/environschema/commits{/sha}","git_commits_url":"https://api.github.com/repos/rogpeppe/environschema/git/commits{/sha}","comments_url":"https://api.github.com/repos/rogpeppe/environschema/comments{/number}","issue_comment_url":"https://api.github.com/repos/rogpeppe/environschema/issues/comments{/number}","contents_url":"https://api.github.com/repos/rogpeppe/environschema/contents/{+path}","compare_url":"https://api.github.com/repos/rogpeppe/environschema/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rogpeppe/environschema/merges","archive_url":"https://api.github.com/repos/rogpeppe/environschema/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rogpeppe/environschema/downloads","issues_url":"https://api.github.com/repos/rogpeppe/environschema/issues{/number}","pulls_url":"https://api.github.com/repos/rogpeppe/environschema/pulls{/number}","milestones_url":"https://api.github.com/repos/rogpeppe/environschema/milestones{/number}","notifications_url":"https://api.github.com/repos/rogpeppe/environschema/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rogpeppe/environschema/labels{/name}","releases_url":"https://api.github.com/repos/rogpeppe/environschema/releases{/id}","created_at":"2015-06-02T10:14:25Z","updated_at":"2015-06-02T10:10:40Z","pushed_at":"2015-10-20T15:18:21Z","git_url":"git://github.com/rogpeppe/environschema.git","ssh_url":"git@github.com:rogpeppe/environschema.git","clone_url":"https://github.com/rogpeppe/environschema.git","svn_url":"https://github.com/rogpeppe/environschema","homepage":null,"size":152,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v1"}},"base":{"label":"juju:v1","ref":"v1","sha":"022f132be5c369d646f26c38424fd20fe4e096af","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":36724935,"name":"environschema","full_name":"juju/environschema","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/environschema","description":"schema descriptions for Juju environment configurations","fork":false,"url":"https://api.github.com/repos/juju/environschema","forks_url":"https://api.github.com/repos/juju/environschema/forks","keys_url":"https://api.github.com/repos/juju/environschema/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/environschema/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/environschema/teams","hooks_url":"https://api.github.com/repos/juju/environschema/hooks","issue_events_url":"https://api.github.com/repos/juju/environschema/issues/events{/number}","events_url":"https://api.github.com/repos/juju/environschema/events","assignees_url":"https://api.github.com/repos/juju/environschema/assignees{/user}","branches_url":"https://api.github.com/repos/juju/environschema/branches{/branch}","tags_url":"https://api.github.com/repos/juju/environschema/tags","blobs_url":"https://api.github.com/repos/juju/environschema/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/environschema/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/environschema/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/environschema/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/environschema/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/environschema/languages","stargazers_url":"https://api.github.com/repos/juju/environschema/stargazers","contributors_url":"https://api.github.com/repos/juju/environschema/contributors","subscribers_url":"https://api.github.com/repos/juju/environschema/subscribers","subscription_url":"https://api.github.com/repos/juju/environschema/subscription","commits_url":"https://api.github.com/repos/juju/environschema/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/environschema/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/environschema/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/environschema/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/environschema/contents/{+path}","compare_url":"https://api.github.com/repos/juju/environschema/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/environschema/merges","archive_url":"https://api.github.com/repos/juju/environschema/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/environschema/downloads","issues_url":"https://api.github.com/repos/juju/environschema/issues{/number}","pulls_url":"https://api.github.com/repos/juju/environschema/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/environschema/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/environschema/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/environschema/labels{/name}","releases_url":"https://api.github.com/repos/juju/environschema/releases{/id}","created_at":"2015-06-02T10:10:40Z","updated_at":"2015-08-28T15:42:19Z","pushed_at":"2015-10-20T15:19:18Z","git_url":"git://github.com/juju/environschema.git","ssh_url":"git@github.com:juju/environschema.git","clone_url":"https://github.com/juju/environschema.git","svn_url":"https://github.com/juju/environschema","homepage":null,"size":188,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"v1"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/environschema/pulls/12"},"html":{"href":"https://github.com/juju/environschema/pull/12"},"issue":{"href":"https://api.github.com/repos/juju/environschema/issues/12"},"comments":{"href":"https://api.github.com/repos/juju/environschema/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/environschema/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/environschema/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju/environschema/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/juju/environschema/statuses/81394ddaf68d8c8b960bc298c7488e87f9c14828"}}}}