{"action":"closed","number":184,"pull_request":{"url":"https://api.github.com/repos/Netflix/karyon/pulls/184","id":28074533,"html_url":"https://github.com/Netflix/karyon/pull/184","diff_url":"https://github.com/Netflix/karyon/pull/184.diff","patch_url":"https://github.com/Netflix/karyon/pull/184.patch","issue_url":"https://api.github.com/repos/Netflix/karyon/issues/184","number":184,"state":"closed","locked":false,"title":"Extract eureka admin page/resource as a separate gradle module.","user":{"login":"tbak","id":728768,"avatar_url":"https://avatars.githubusercontent.com/u/728768?v=3","gravatar_id":"","url":"https://api.github.com/users/tbak","html_url":"https://github.com/tbak","followers_url":"https://api.github.com/users/tbak/followers","following_url":"https://api.github.com/users/tbak/following{/other_user}","gists_url":"https://api.github.com/users/tbak/gists{/gist_id}","starred_url":"https://api.github.com/users/tbak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbak/subscriptions","organizations_url":"https://api.github.com/users/tbak/orgs","repos_url":"https://api.github.com/users/tbak/repos","events_url":"https://api.github.com/users/tbak/events{/privacy}","received_events_url":"https://api.github.com/users/tbak/received_events","type":"User","site_admin":false},"body":"I have removed AdminPageResource. getInstanceHostName + its related meta field, as it is not used by current karyon2 views, and it introduces dependency on eureka. If some views need it, we would have to bring it back, but not within this module.","created_at":"2015-01-27T00:47:39Z","updated_at":"2015-01-27T06:11:26Z","closed_at":"2015-01-27T06:11:26Z","merged_at":"2015-01-27T06:11:26Z","merge_commit_sha":"88f7907719fd83a5f5cced5e4ee9acc1af2a57f5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Netflix/karyon/pulls/184/commits","review_comments_url":"https://api.github.com/repos/Netflix/karyon/pulls/184/comments","review_comment_url":"https://api.github.com/repos/Netflix/karyon/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Netflix/karyon/issues/184/comments","statuses_url":"https://api.github.com/repos/Netflix/karyon/statuses/21cde98d18413262682a33a1708499d2bef20122","head":{"label":"tbak:refactorings/eureka_web_admin","ref":"refactorings/eureka_web_admin","sha":"21cde98d18413262682a33a1708499d2bef20122","user":{"login":"tbak","id":728768,"avatar_url":"https://avatars.githubusercontent.com/u/728768?v=3","gravatar_id":"","url":"https://api.github.com/users/tbak","html_url":"https://github.com/tbak","followers_url":"https://api.github.com/users/tbak/followers","following_url":"https://api.github.com/users/tbak/following{/other_user}","gists_url":"https://api.github.com/users/tbak/gists{/gist_id}","starred_url":"https://api.github.com/users/tbak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbak/subscriptions","organizations_url":"https://api.github.com/users/tbak/orgs","repos_url":"https://api.github.com/users/tbak/repos","events_url":"https://api.github.com/users/tbak/events{/privacy}","received_events_url":"https://api.github.com/users/tbak/received_events","type":"User","site_admin":false},"repo":{"id":21867933,"name":"karyon","full_name":"tbak/karyon","owner":{"login":"tbak","id":728768,"avatar_url":"https://avatars.githubusercontent.com/u/728768?v=3","gravatar_id":"","url":"https://api.github.com/users/tbak","html_url":"https://github.com/tbak","followers_url":"https://api.github.com/users/tbak/followers","following_url":"https://api.github.com/users/tbak/following{/other_user}","gists_url":"https://api.github.com/users/tbak/gists{/gist_id}","starred_url":"https://api.github.com/users/tbak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbak/subscriptions","organizations_url":"https://api.github.com/users/tbak/orgs","repos_url":"https://api.github.com/users/tbak/repos","events_url":"https://api.github.com/users/tbak/events{/privacy}","received_events_url":"https://api.github.com/users/tbak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tbak/karyon","description":"The nucleus or the base container for Applications and Services built using the NetflixOSS ecosystem","fork":true,"url":"https://api.github.com/repos/tbak/karyon","forks_url":"https://api.github.com/repos/tbak/karyon/forks","keys_url":"https://api.github.com/repos/tbak/karyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tbak/karyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tbak/karyon/teams","hooks_url":"https://api.github.com/repos/tbak/karyon/hooks","issue_events_url":"https://api.github.com/repos/tbak/karyon/issues/events{/number}","events_url":"https://api.github.com/repos/tbak/karyon/events","assignees_url":"https://api.github.com/repos/tbak/karyon/assignees{/user}","branches_url":"https://api.github.com/repos/tbak/karyon/branches{/branch}","tags_url":"https://api.github.com/repos/tbak/karyon/tags","blobs_url":"https://api.github.com/repos/tbak/karyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tbak/karyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tbak/karyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/tbak/karyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tbak/karyon/statuses/{sha}","languages_url":"https://api.github.com/repos/tbak/karyon/languages","stargazers_url":"https://api.github.com/repos/tbak/karyon/stargazers","contributors_url":"https://api.github.com/repos/tbak/karyon/contributors","subscribers_url":"https://api.github.com/repos/tbak/karyon/subscribers","subscription_url":"https://api.github.com/repos/tbak/karyon/subscription","commits_url":"https://api.github.com/repos/tbak/karyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/tbak/karyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/tbak/karyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/tbak/karyon/issues/comments/{number}","contents_url":"https://api.github.com/repos/tbak/karyon/contents/{+path}","compare_url":"https://api.github.com/repos/tbak/karyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tbak/karyon/merges","archive_url":"https://api.github.com/repos/tbak/karyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tbak/karyon/downloads","issues_url":"https://api.github.com/repos/tbak/karyon/issues{/number}","pulls_url":"https://api.github.com/repos/tbak/karyon/pulls{/number}","milestones_url":"https://api.github.com/repos/tbak/karyon/milestones{/number}","notifications_url":"https://api.github.com/repos/tbak/karyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tbak/karyon/labels{/name}","releases_url":"https://api.github.com/repos/tbak/karyon/releases{/id}","created_at":"2014-07-15T16:53:04Z","updated_at":"2015-01-27T00:43:38Z","pushed_at":"2015-01-27T03:56:58Z","git_url":"git://github.com/tbak/karyon.git","ssh_url":"git@github.com:tbak/karyon.git","clone_url":"https://github.com/tbak/karyon.git","svn_url":"https://github.com/tbak/karyon","homepage":null,"size":1748,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Netflix:master","ref":"master","sha":"7ec679991a1a333364e67a4801a44f60525174ff","user":{"login":"Netflix","id":913567,"avatar_url":"https://avatars.githubusercontent.com/u/913567?v=3","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"repo":{"id":8059194,"name":"karyon","full_name":"Netflix/karyon","owner":{"login":"Netflix","id":913567,"avatar_url":"https://avatars.githubusercontent.com/u/913567?v=3","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Netflix/karyon","description":"The nucleus or the base container for Applications and Services built using the NetflixOSS ecosystem","fork":false,"url":"https://api.github.com/repos/Netflix/karyon","forks_url":"https://api.github.com/repos/Netflix/karyon/forks","keys_url":"https://api.github.com/repos/Netflix/karyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Netflix/karyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Netflix/karyon/teams","hooks_url":"https://api.github.com/repos/Netflix/karyon/hooks","issue_events_url":"https://api.github.com/repos/Netflix/karyon/issues/events{/number}","events_url":"https://api.github.com/repos/Netflix/karyon/events","assignees_url":"https://api.github.com/repos/Netflix/karyon/assignees{/user}","branches_url":"https://api.github.com/repos/Netflix/karyon/branches{/branch}","tags_url":"https://api.github.com/repos/Netflix/karyon/tags","blobs_url":"https://api.github.com/repos/Netflix/karyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Netflix/karyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Netflix/karyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/Netflix/karyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Netflix/karyon/statuses/{sha}","languages_url":"https://api.github.com/repos/Netflix/karyon/languages","stargazers_url":"https://api.github.com/repos/Netflix/karyon/stargazers","contributors_url":"https://api.github.com/repos/Netflix/karyon/contributors","subscribers_url":"https://api.github.com/repos/Netflix/karyon/subscribers","subscription_url":"https://api.github.com/repos/Netflix/karyon/subscription","commits_url":"https://api.github.com/repos/Netflix/karyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/Netflix/karyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/Netflix/karyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/Netflix/karyon/issues/comments/{number}","contents_url":"https://api.github.com/repos/Netflix/karyon/contents/{+path}","compare_url":"https://api.github.com/repos/Netflix/karyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Netflix/karyon/merges","archive_url":"https://api.github.com/repos/Netflix/karyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Netflix/karyon/downloads","issues_url":"https://api.github.com/repos/Netflix/karyon/issues{/number}","pulls_url":"https://api.github.com/repos/Netflix/karyon/pulls{/number}","milestones_url":"https://api.github.com/repos/Netflix/karyon/milestones{/number}","notifications_url":"https://api.github.com/repos/Netflix/karyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Netflix/karyon/labels{/name}","releases_url":"https://api.github.com/repos/Netflix/karyon/releases{/id}","created_at":"2013-02-06T20:18:55Z","updated_at":"2015-01-23T07:43:10Z","pushed_at":"2015-01-27T06:11:26Z","git_url":"git://github.com/Netflix/karyon.git","ssh_url":"git@github.com:Netflix/karyon.git","clone_url":"https://github.com/Netflix/karyon.git","svn_url":"https://github.com/Netflix/karyon","homepage":null,"size":4441,"stargazers_count":126,"watchers_count":126,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":67,"mirror_url":null,"open_issues_count":12,"forks":67,"open_issues":12,"watchers":126,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Netflix/karyon/pulls/184"},"html":{"href":"https://github.com/Netflix/karyon/pull/184"},"issue":{"href":"https://api.github.com/repos/Netflix/karyon/issues/184"},"comments":{"href":"https://api.github.com/repos/Netflix/karyon/issues/184/comments"},"review_comments":{"href":"https://api.github.com/repos/Netflix/karyon/pulls/184/comments"},"review_comment":{"href":"https://api.github.com/repos/Netflix/karyon/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Netflix/karyon/pulls/184/commits"},"statuses":{"href":"https://api.github.com/repos/Netflix/karyon/statuses/21cde98d18413262682a33a1708499d2bef20122"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tbak","id":728768,"avatar_url":"https://avatars.githubusercontent.com/u/728768?v=3","gravatar_id":"","url":"https://api.github.com/users/tbak","html_url":"https://github.com/tbak","followers_url":"https://api.github.com/users/tbak/followers","following_url":"https://api.github.com/users/tbak/following{/other_user}","gists_url":"https://api.github.com/users/tbak/gists{/gist_id}","starred_url":"https://api.github.com/users/tbak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbak/subscriptions","organizations_url":"https://api.github.com/users/tbak/orgs","repos_url":"https://api.github.com/users/tbak/repos","events_url":"https://api.github.com/users/tbak/events{/privacy}","received_events_url":"https://api.github.com/users/tbak/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":2,"additions":77,"deletions":35,"changed_files":13}}