{"action":"closed","issue":{"url":"https://api.github.com/repos/rvagg/nan/issues/294","labels_url":"https://api.github.com/repos/rvagg/nan/issues/294/labels{/name}","comments_url":"https://api.github.com/repos/rvagg/nan/issues/294/comments","events_url":"https://api.github.com/repos/rvagg/nan/issues/294/events","html_url":"https://github.com/rvagg/nan/issues/294","id":60508973,"number":294,"title":"NanThrowError is not throwing in iojs 1.5.1, node 0.12 or node 0.11","user":{"login":"stephenmathieson","id":571265,"avatar_url":"https://avatars.githubusercontent.com/u/571265?v=3","gravatar_id":"","url":"https://api.github.com/users/stephenmathieson","html_url":"https://github.com/stephenmathieson","followers_url":"https://api.github.com/users/stephenmathieson/followers","following_url":"https://api.github.com/users/stephenmathieson/following{/other_user}","gists_url":"https://api.github.com/users/stephenmathieson/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenmathieson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenmathieson/subscriptions","organizations_url":"https://api.github.com/users/stephenmathieson/orgs","repos_url":"https://api.github.com/users/stephenmathieson/repos","events_url":"https://api.github.com/users/stephenmathieson/events{/privacy}","received_events_url":"https://api.github.com/users/stephenmathieson/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-03-10T14:36:31Z","updated_at":"2015-03-10T17:55:51Z","closed_at":"2015-03-10T17:55:51Z","body":"I'm hoping I'm doing something wrong, but [this](https://gist.github.com/stephenmathieson/6593406b5d791db4345b) example works fine under node 0.10, but not 0.11, 0.12 or iojs 1.5.1.\r\n\r\n## iojs 1.5.1:\r\n\r\n```\r\n$ make test\r\nnode_modules/.bin/node-gyp rebuild\r\ngyp info it worked if it ends with ok\r\ngyp info using node-gyp@1.0.3\r\ngyp info using node@1.5.1 | darwin | x64\r\ngyp info spawn python\r\ngyp info spawn args [ '/Users/stephenmathieson/repos/github.com/stephenmathieson/wut/node_modules/node-gyp/gyp/gyp_main.py',\r\ngyp info spawn args   'binding.gyp',\r\ngyp info spawn args   '-f',\r\ngyp info spawn args   'make',\r\ngyp info spawn args   '-I',\r\ngyp info spawn args   '/Users/stephenmathieson/repos/github.com/stephenmathieson/wut/build/config.gypi',\r\ngyp info spawn args   '-I',\r\ngyp info spawn args   '/Users/stephenmathieson/repos/github.com/stephenmathieson/wut/node_modules/node-gyp/addon.gypi',\r\ngyp info spawn args   '-I',\r\ngyp info spawn args   '/Users/stephenmathieson/.node-gyp/1.5.1/common.gypi',\r\ngyp info spawn args   '-Dlibrary=shared_library',\r\ngyp info spawn args   '-Dvisibility=default',\r\ngyp info spawn args   '-Dnode_root_dir=/Users/stephenmathieson/.node-gyp/1.5.1',\r\ngyp info spawn args   '-Dmodule_root_dir=/Users/stephenmathieson/repos/github.com/stephenmathieson/wut',\r\ngyp info spawn args   '--depth=.',\r\ngyp info spawn args   '--no-parallel',\r\ngyp info spawn args   '--generator-output',\r\ngyp info spawn args   'build',\r\ngyp info spawn args   '-Goutput_dir=.' ]\r\ngyp info spawn make\r\ngyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]\r\n  CXX(target) Release/obj.target/wut/binding.o\r\n  SOLINK_MODULE(target) Release/wut.node\r\n  SOLINK_MODULE(target) Release/wut.node: Finished\r\ngyp info ok \r\nnode test\r\nhas 'foo'\r\n'foo' is not a string\r\nwe didnt throw or return???\r\n'foo' is a string\r\n```\r\n\r\n## node 0.12.0:\r\n\r\n```\r\n$ make test\r\nnode_modules/.bin/node-gyp rebuild\r\ngyp info it worked if it ends with ok\r\ngyp info using node-gyp@1.0.3\r\ngyp info using node@0.12.0 | darwin | x64\r\ngyp info spawn python\r\ngyp info spawn args [ '/Users/stephenmathieson/repos/github.com/stephenmathieson/wut/node_modules/node-gyp/gyp/gyp_main.py',\r\ngyp info spawn args   'binding.gyp',\r\ngyp info spawn args   '-f',\r\ngyp info spawn args   'make',\r\ngyp info spawn args   '-I',\r\ngyp info spawn args   '/Users/stephenmathieson/repos/github.com/stephenmathieson/wut/build/config.gypi',\r\ngyp info spawn args   '-I',\r\ngyp info spawn args   '/Users/stephenmathieson/repos/github.com/stephenmathieson/wut/node_modules/node-gyp/addon.gypi',\r\ngyp info spawn args   '-I',\r\ngyp info spawn args   '/Users/stephenmathieson/.node-gyp/0.12.0/common.gypi',\r\ngyp info spawn args   '-Dlibrary=shared_library',\r\ngyp info spawn args   '-Dvisibility=default',\r\ngyp info spawn args   '-Dnode_root_dir=/Users/stephenmathieson/.node-gyp/0.12.0',\r\ngyp info spawn args   '-Dmodule_root_dir=/Users/stephenmathieson/repos/github.com/stephenmathieson/wut',\r\ngyp info spawn args   '--depth=.',\r\ngyp info spawn args   '--no-parallel',\r\ngyp info spawn args   '--generator-output',\r\ngyp info spawn args   'build',\r\ngyp info spawn args   '-Goutput_dir=.' ]\r\ngyp info spawn make\r\ngyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]\r\n  CXX(target) Release/obj.target/wut/binding.o\r\n  SOLINK_MODULE(target) Release/wut.node\r\n  SOLINK_MODULE(target) Release/wut.node: Finished\r\ngyp info ok \r\nnode test\r\nhas 'foo'\r\n'foo' is not a string\r\nwe didnt throw or return???\r\n'foo' is a string\r\n```\r\n\r\n## node 0.11.16:\r\n\r\n```\r\n$ make test\r\nnode_modules/.bin/node-gyp rebuild\r\ngyp info it worked if it ends with ok\r\ngyp info using node-gyp@1.0.3\r\ngyp info using node@0.11.16 | darwin | x64\r\ngyp info spawn python\r\ngyp info spawn args [ '/Users/stephenmathieson/repos/github.com/stephenmathieson/wut/node_modules/node-gyp/gyp/gyp_main.py',\r\ngyp info spawn args   'binding.gyp',\r\ngyp info spawn args   '-f',\r\ngyp info spawn args   'make',\r\ngyp info spawn args   '-I',\r\ngyp info spawn args   '/Users/stephenmathieson/repos/github.com/stephenmathieson/wut/build/config.gypi',\r\ngyp info spawn args   '-I',\r\ngyp info spawn args   '/Users/stephenmathieson/repos/github.com/stephenmathieson/wut/node_modules/node-gyp/addon.gypi',\r\ngyp info spawn args   '-I',\r\ngyp info spawn args   '/Users/stephenmathieson/.node-gyp/0.11.16/common.gypi',\r\ngyp info spawn args   '-Dlibrary=shared_library',\r\ngyp info spawn args   '-Dvisibility=default',\r\ngyp info spawn args   '-Dnode_root_dir=/Users/stephenmathieson/.node-gyp/0.11.16',\r\ngyp info spawn args   '-Dmodule_root_dir=/Users/stephenmathieson/repos/github.com/stephenmathieson/wut',\r\ngyp info spawn args   '--depth=.',\r\ngyp info spawn args   '--no-parallel',\r\ngyp info spawn args   '--generator-output',\r\ngyp info spawn args   'build',\r\ngyp info spawn args   '-Goutput_dir=.' ]\r\ngyp info spawn make\r\ngyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]\r\n  CXX(target) Release/obj.target/wut/binding.o\r\n  SOLINK_MODULE(target) Release/wut.node\r\n  SOLINK_MODULE(target) Release/wut.node: Finished\r\ngyp info ok \r\nnode test\r\nhas 'foo'\r\n'foo' is not a string\r\nwe didnt throw or return???\r\n'foo' is a string\r\n```\r\n\r\n## node 0.10.36:\r\n\r\n```\r\n$ make test\r\nnode_modules/.bin/node-gyp rebuild\r\ngyp info it worked if it ends with ok\r\ngyp info using node-gyp@1.0.3\r\ngyp info using node@0.10.36 | darwin | x64\r\ngyp info spawn python\r\ngyp info spawn args [ '/Users/stephenmathieson/repos/github.com/stephenmathieson/wut/node_modules/node-gyp/gyp/gyp_main.py',\r\ngyp info spawn args   'binding.gyp',\r\ngyp info spawn args   '-f',\r\ngyp info spawn args   'make',\r\ngyp info spawn args   '-I',\r\ngyp info spawn args   '/Users/stephenmathieson/repos/github.com/stephenmathieson/wut/build/config.gypi',\r\ngyp info spawn args   '-I',\r\ngyp info spawn args   '/Users/stephenmathieson/repos/github.com/stephenmathieson/wut/node_modules/node-gyp/addon.gypi',\r\ngyp info spawn args   '-I',\r\ngyp info spawn args   '/Users/stephenmathieson/.node-gyp/0.10.36/common.gypi',\r\ngyp info spawn args   '-Dlibrary=shared_library',\r\ngyp info spawn args   '-Dvisibility=default',\r\ngyp info spawn args   '-Dnode_root_dir=/Users/stephenmathieson/.node-gyp/0.10.36',\r\ngyp info spawn args   '-Dmodule_root_dir=/Users/stephenmathieson/repos/github.com/stephenmathieson/wut',\r\ngyp info spawn args   '--depth=.',\r\ngyp info spawn args   '--no-parallel',\r\ngyp info spawn args   '--generator-output',\r\ngyp info spawn args   'build',\r\ngyp info spawn args   '-Goutput_dir=.' ]\r\ngyp info spawn make\r\ngyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]\r\n  CXX(target) Release/obj.target/wut/binding.o\r\n  SOLINK_MODULE(target) Release/wut.node\r\n  SOLINK_MODULE(target) Release/wut.node: Finished\r\ngyp info ok \r\nnode test\r\nhas 'foo'\r\n'foo' is not a string\r\nwe didnt throw or return???\r\n'foo' is a string\r\n\r\nError: foo must be a string\r\n    at Object.<anonymous> (/Users/stephenmathieson/repos/github.com/stephenmathieson/wut/test.js:2:28)\r\n    at Module._compile (module.js:456:26)\r\n    at Object.Module._extensions..js (module.js:474:10)\r\n    at Module.load (module.js:356:32)\r\n    at Function.Module._load (module.js:312:12)\r\n    at Function.Module.runMain (module.js:497:10)\r\n    at startup (node.js:119:16)\r\n    at node.js:929:3\r\nmake: *** [test] Error 8\r\n```"}}