{"action":"created","issue":{"url":"https://api.github.com/repos/eboston/Marlin/issues/1","labels_url":"https://api.github.com/repos/eboston/Marlin/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/eboston/Marlin/issues/1/comments","events_url":"https://api.github.com/repos/eboston/Marlin/issues/1/events","html_url":"https://github.com/eboston/Marlin/pull/1","id":94526671,"number":1,"title":"Rgb backlight","user":{"login":"Wackerbarth","id":505323,"avatar_url":"https://avatars.githubusercontent.com/u/505323?v=3","gravatar_id":"","url":"https://api.github.com/users/Wackerbarth","html_url":"https://github.com/Wackerbarth","followers_url":"https://api.github.com/users/Wackerbarth/followers","following_url":"https://api.github.com/users/Wackerbarth/following{/other_user}","gists_url":"https://api.github.com/users/Wackerbarth/gists{/gist_id}","starred_url":"https://api.github.com/users/Wackerbarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wackerbarth/subscriptions","organizations_url":"https://api.github.com/users/Wackerbarth/orgs","repos_url":"https://api.github.com/users/Wackerbarth/repos","events_url":"https://api.github.com/users/Wackerbarth/events{/privacy}","received_events_url":"https://api.github.com/users/Wackerbarth/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-12T02:36:31Z","updated_at":"2015-07-12T02:41:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/eboston/Marlin/pulls/1","html_url":"https://github.com/eboston/Marlin/pull/1","diff_url":"https://github.com/eboston/Marlin/pull/1.diff","patch_url":"https://github.com/eboston/Marlin/pull/1.patch"},"body":"You included RGB_Backlight.h twice.\r\n\r\nYou should also look at the BLINKM situation.  Generally, I don't like to see something included because of \"A or B\".  To me that indicates that there is really a reason, R, for the inclusion and that A->R and B->R rather than the inclusion being the direct result of either A or B."},"comment":{"url":"https://api.github.com/repos/eboston/Marlin/issues/comments/120681050","html_url":"https://github.com/eboston/Marlin/pull/1#issuecomment-120681050","issue_url":"https://api.github.com/repos/eboston/Marlin/issues/1","id":120681050,"user":{"login":"eboston","id":8252789,"avatar_url":"https://avatars.githubusercontent.com/u/8252789?v=3","gravatar_id":"","url":"https://api.github.com/users/eboston","html_url":"https://github.com/eboston","followers_url":"https://api.github.com/users/eboston/followers","following_url":"https://api.github.com/users/eboston/following{/other_user}","gists_url":"https://api.github.com/users/eboston/gists{/gist_id}","starred_url":"https://api.github.com/users/eboston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eboston/subscriptions","organizations_url":"https://api.github.com/users/eboston/orgs","repos_url":"https://api.github.com/users/eboston/repos","events_url":"https://api.github.com/users/eboston/events{/privacy}","received_events_url":"https://api.github.com/users/eboston/received_events","type":"User","site_admin":false},"created_at":"2015-07-12T02:41:27Z","updated_at":"2015-07-12T02:41:27Z","body":"Did you just merge my changes into development?  I hope not.  I wasn't \nready for it to go in.  I was just asking if what I had was along the \nline of what you had in mind.\n\nOn 7/11/2015 7:36 PM, Richard Wackerbarth wrote:\n>\n> You included RGB_Backlight.h twice.\n>\n> You should also look at the BLINKM situation. Generally, I don't like \n> to see something included because of \"A or B\". To me that indicates \n> that there is really a reason, R, for the inclusion and that A->R and \n> B->R rather than the inclusion being the direct result of either A or B.\n>\n> ------------------------------------------------------------------------\n>\n>\n>         You can view, comment on, or merge this pull request online at:\n>\n> https://github.com/eboston/Marlin/pull/1\n>\n>\n>         Commit Summary\n>\n>   * Remove STEPPER_RESET_FIX option\n>   * Add STEPPER_RESET_PIN support\n>   * Merge pull request #2417 from thinkyhead/finish_rigidboard\n>   * Added initial support for RGB backlight displays. Only M150\n>     command implemented.\n>   * Your additional configuration changes\n>\n>\n>         File Changes\n>\n>   * *M* Marlin/Conditionals.h\n>     <https://github.com/eboston/Marlin/pull/1/files#diff-0> (1)\n>   * *M* Marlin/Configuration.h\n>     <https://github.com/eboston/Marlin/pull/1/files#diff-1> (17)\n>   * *M* Marlin/Marlin_main.cpp\n>     <https://github.com/eboston/Marlin/pull/1/files#diff-2> (34)\n>   * *A* Marlin/RGBBacklight.cpp\n>     <https://github.com/eboston/Marlin/pull/1/files#diff-3> (21)\n>   * *A* Marlin/RGBBacklight.h\n>     <https://github.com/eboston/Marlin/pull/1/files#diff-4> (19)\n>   * *M* Marlin/SanityCheck.h\n>     <https://github.com/eboston/Marlin/pull/1/files#diff-5> (15)\n>   * *M* Marlin/example_configurations/RigidBot/Configuration.h\n>     <https://github.com/eboston/Marlin/pull/1/files#diff-6> (2)\n>\n>\n>         Patch Links:\n>\n>   * https://github.com/eboston/Marlin/pull/1.patch\n>   * https://github.com/eboston/Marlin/pull/1.diff\n>\n> —\n> Reply to this email directly or view it on GitHub \n> <https://github.com/eboston/Marlin/pull/1>.\n>\n\n"}}