{"action":"created","comment":{"url":"https://api.github.com/repos/docker/libcontainer/pulls/comments/35096210","id":35096210,"diff_hunk":"@@ -168,6 +168,10 @@ func mountToRootfs(m *configs.Mount, rootfs, mountLabel string) error {\n \t\t\tif err := syscall.Mount(\"\", dest, \"none\", uintptr(syscall.MS_PRIVATE), \"\"); err != nil {\n \t\t\t\treturn err\n \t\t\t}\n+\t\t} else {\n+\t\t\tif err := syscall.Mount(\"\", dest, \"none\", uintptr(syscall.MS_SLAVE), \"\"); err != nil {","path":"rootfs_linux.go","position":5,"original_position":5,"commit_id":"752b5f6e508969dc6810ba22a0b260f8642756a4","original_commit_id":"752b5f6e508969dc6810ba22a0b260f8642756a4","user":{"login":"rhatdan","id":2000835,"avatar_url":"https://avatars.githubusercontent.com/u/2000835?v=3","gravatar_id":"","url":"https://api.github.com/users/rhatdan","html_url":"https://github.com/rhatdan","followers_url":"https://api.github.com/users/rhatdan/followers","following_url":"https://api.github.com/users/rhatdan/following{/other_user}","gists_url":"https://api.github.com/users/rhatdan/gists{/gist_id}","starred_url":"https://api.github.com/users/rhatdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhatdan/subscriptions","organizations_url":"https://api.github.com/users/rhatdan/orgs","repos_url":"https://api.github.com/users/rhatdan/repos","events_url":"https://api.github.com/users/rhatdan/events{/privacy}","received_events_url":"https://api.github.com/users/rhatdan/received_events","type":"User","site_admin":false},"body":"If the mount was not specified as PRIVATE ,then we default to SLAVE.  ","created_at":"2015-07-21T12:29:35Z","updated_at":"2015-07-21T12:29:35Z","html_url":"https://github.com/docker/libcontainer/pull/623#discussion_r35096210","pull_request_url":"https://api.github.com/repos/docker/libcontainer/pulls/623","_links":{"self":{"href":"https://api.github.com/repos/docker/libcontainer/pulls/comments/35096210"},"html":{"href":"https://github.com/docker/libcontainer/pull/623#discussion_r35096210"},"pull_request":{"href":"https://api.github.com/repos/docker/libcontainer/pulls/623"}}},"pull_request":{"url":"https://api.github.com/repos/docker/libcontainer/pulls/623","id":37498615,"html_url":"https://github.com/docker/libcontainer/pull/623","diff_url":"https://github.com/docker/libcontainer/pull/623.diff","patch_url":"https://github.com/docker/libcontainer/pull/623.patch","issue_url":"https://api.github.com/repos/docker/libcontainer/issues/623","number":623,"state":"open","locked":false,"title":" Mount rootfs PRIVATE but volume mounts shared","user":{"login":"rhatdan","id":2000835,"avatar_url":"https://avatars.githubusercontent.com/u/2000835?v=3","gravatar_id":"","url":"https://api.github.com/users/rhatdan","html_url":"https://github.com/rhatdan","followers_url":"https://api.github.com/users/rhatdan/followers","following_url":"https://api.github.com/users/rhatdan/following{/other_user}","gists_url":"https://api.github.com/users/rhatdan/gists{/gist_id}","starred_url":"https://api.github.com/users/rhatdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhatdan/subscriptions","organizations_url":"https://api.github.com/users/rhatdan/orgs","repos_url":"https://api.github.com/users/rhatdan/repos","events_url":"https://api.github.com/users/rhatdan/events{/privacy}","received_events_url":"https://api.github.com/users/rhatdan/received_events","type":"User","site_admin":false},"body":"Currently we are remounting the entire OS as PRIVATE which breaks\r\nshared volume mounts. This patch only mounts the rootfs as PRIVATE\r\nwhich allows the volume mounts to be shared.\r\n\r\nDocker-DCO-1.1-Signed-off-by: Dan Walsh dwalsh@redhat.com (github: rhatdan)\r\n\r\nDocker-DCO-1.1-Signed-off-by: Dan Walsh <dwalsh@redhat.com> (github: rhatdan)","created_at":"2015-06-11T19:17:22Z","updated_at":"2015-07-21T12:29:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8540f2960e7ec7cc6d7ff00bc60d1da4d833404c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/libcontainer/pulls/623/commits","review_comments_url":"https://api.github.com/repos/docker/libcontainer/pulls/623/comments","review_comment_url":"https://api.github.com/repos/docker/libcontainer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/libcontainer/issues/623/comments","statuses_url":"https://api.github.com/repos/docker/libcontainer/statuses/752b5f6e508969dc6810ba22a0b260f8642756a4","head":{"label":"rhatdan:master","ref":"master","sha":"752b5f6e508969dc6810ba22a0b260f8642756a4","user":{"login":"rhatdan","id":2000835,"avatar_url":"https://avatars.githubusercontent.com/u/2000835?v=3","gravatar_id":"","url":"https://api.github.com/users/rhatdan","html_url":"https://github.com/rhatdan","followers_url":"https://api.github.com/users/rhatdan/followers","following_url":"https://api.github.com/users/rhatdan/following{/other_user}","gists_url":"https://api.github.com/users/rhatdan/gists{/gist_id}","starred_url":"https://api.github.com/users/rhatdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhatdan/subscriptions","organizations_url":"https://api.github.com/users/rhatdan/orgs","repos_url":"https://api.github.com/users/rhatdan/repos","events_url":"https://api.github.com/users/rhatdan/events{/privacy}","received_events_url":"https://api.github.com/users/rhatdan/received_events","type":"User","site_admin":false},"repo":{"id":21169189,"name":"libcontainer","full_name":"rhatdan/libcontainer","owner":{"login":"rhatdan","id":2000835,"avatar_url":"https://avatars.githubusercontent.com/u/2000835?v=3","gravatar_id":"","url":"https://api.github.com/users/rhatdan","html_url":"https://github.com/rhatdan","followers_url":"https://api.github.com/users/rhatdan/followers","following_url":"https://api.github.com/users/rhatdan/following{/other_user}","gists_url":"https://api.github.com/users/rhatdan/gists{/gist_id}","starred_url":"https://api.github.com/users/rhatdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhatdan/subscriptions","organizations_url":"https://api.github.com/users/rhatdan/orgs","repos_url":"https://api.github.com/users/rhatdan/repos","events_url":"https://api.github.com/users/rhatdan/events{/privacy}","received_events_url":"https://api.github.com/users/rhatdan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rhatdan/libcontainer","description":"Linux Containers","fork":true,"url":"https://api.github.com/repos/rhatdan/libcontainer","forks_url":"https://api.github.com/repos/rhatdan/libcontainer/forks","keys_url":"https://api.github.com/repos/rhatdan/libcontainer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhatdan/libcontainer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhatdan/libcontainer/teams","hooks_url":"https://api.github.com/repos/rhatdan/libcontainer/hooks","issue_events_url":"https://api.github.com/repos/rhatdan/libcontainer/issues/events{/number}","events_url":"https://api.github.com/repos/rhatdan/libcontainer/events","assignees_url":"https://api.github.com/repos/rhatdan/libcontainer/assignees{/user}","branches_url":"https://api.github.com/repos/rhatdan/libcontainer/branches{/branch}","tags_url":"https://api.github.com/repos/rhatdan/libcontainer/tags","blobs_url":"https://api.github.com/repos/rhatdan/libcontainer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhatdan/libcontainer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhatdan/libcontainer/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhatdan/libcontainer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhatdan/libcontainer/statuses/{sha}","languages_url":"https://api.github.com/repos/rhatdan/libcontainer/languages","stargazers_url":"https://api.github.com/repos/rhatdan/libcontainer/stargazers","contributors_url":"https://api.github.com/repos/rhatdan/libcontainer/contributors","subscribers_url":"https://api.github.com/repos/rhatdan/libcontainer/subscribers","subscription_url":"https://api.github.com/repos/rhatdan/libcontainer/subscription","commits_url":"https://api.github.com/repos/rhatdan/libcontainer/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhatdan/libcontainer/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhatdan/libcontainer/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhatdan/libcontainer/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhatdan/libcontainer/contents/{+path}","compare_url":"https://api.github.com/repos/rhatdan/libcontainer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhatdan/libcontainer/merges","archive_url":"https://api.github.com/repos/rhatdan/libcontainer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhatdan/libcontainer/downloads","issues_url":"https://api.github.com/repos/rhatdan/libcontainer/issues{/number}","pulls_url":"https://api.github.com/repos/rhatdan/libcontainer/pulls{/number}","milestones_url":"https://api.github.com/repos/rhatdan/libcontainer/milestones{/number}","notifications_url":"https://api.github.com/repos/rhatdan/libcontainer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhatdan/libcontainer/labels{/name}","releases_url":"https://api.github.com/repos/rhatdan/libcontainer/releases{/id}","created_at":"2014-06-24T15:06:14Z","updated_at":"2015-04-16T20:35:25Z","pushed_at":"2015-06-11T19:16:55Z","git_url":"git://github.com/rhatdan/libcontainer.git","ssh_url":"git@github.com:rhatdan/libcontainer.git","clone_url":"https://github.com/rhatdan/libcontainer.git","svn_url":"https://github.com/rhatdan/libcontainer","homepage":"http://www.docker.com/","size":2503,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"2a3954f053fb101cc5a109d728eb1b8ac5428fc7","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":15693680,"name":"libcontainer","full_name":"docker/libcontainer","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/libcontainer","description":"PROJECT MOVED TO RUNC","fork":false,"url":"https://api.github.com/repos/docker/libcontainer","forks_url":"https://api.github.com/repos/docker/libcontainer/forks","keys_url":"https://api.github.com/repos/docker/libcontainer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/libcontainer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/libcontainer/teams","hooks_url":"https://api.github.com/repos/docker/libcontainer/hooks","issue_events_url":"https://api.github.com/repos/docker/libcontainer/issues/events{/number}","events_url":"https://api.github.com/repos/docker/libcontainer/events","assignees_url":"https://api.github.com/repos/docker/libcontainer/assignees{/user}","branches_url":"https://api.github.com/repos/docker/libcontainer/branches{/branch}","tags_url":"https://api.github.com/repos/docker/libcontainer/tags","blobs_url":"https://api.github.com/repos/docker/libcontainer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/libcontainer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/libcontainer/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/libcontainer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/libcontainer/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/libcontainer/languages","stargazers_url":"https://api.github.com/repos/docker/libcontainer/stargazers","contributors_url":"https://api.github.com/repos/docker/libcontainer/contributors","subscribers_url":"https://api.github.com/repos/docker/libcontainer/subscribers","subscription_url":"https://api.github.com/repos/docker/libcontainer/subscription","commits_url":"https://api.github.com/repos/docker/libcontainer/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/libcontainer/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/libcontainer/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/libcontainer/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/libcontainer/contents/{+path}","compare_url":"https://api.github.com/repos/docker/libcontainer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/libcontainer/merges","archive_url":"https://api.github.com/repos/docker/libcontainer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/libcontainer/downloads","issues_url":"https://api.github.com/repos/docker/libcontainer/issues{/number}","pulls_url":"https://api.github.com/repos/docker/libcontainer/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/libcontainer/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/libcontainer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/libcontainer/labels{/name}","releases_url":"https://api.github.com/repos/docker/libcontainer/releases{/id}","created_at":"2014-01-07T03:05:05Z","updated_at":"2015-07-21T08:32:02Z","pushed_at":"2015-07-09T11:39:09Z","git_url":"git://github.com/docker/libcontainer.git","ssh_url":"git@github.com:docker/libcontainer.git","clone_url":"https://github.com/docker/libcontainer.git","svn_url":"https://github.com/docker/libcontainer","homepage":"https://github.com/opencontainers/runc","size":8087,"stargazers_count":841,"watchers_count":841,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":259,"mirror_url":null,"open_issues_count":31,"forks":259,"open_issues":31,"watchers":841,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/libcontainer/pulls/623"},"html":{"href":"https://github.com/docker/libcontainer/pull/623"},"issue":{"href":"https://api.github.com/repos/docker/libcontainer/issues/623"},"comments":{"href":"https://api.github.com/repos/docker/libcontainer/issues/623/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/libcontainer/pulls/623/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/libcontainer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/libcontainer/pulls/623/commits"},"statuses":{"href":"https://api.github.com/repos/docker/libcontainer/statuses/752b5f6e508969dc6810ba22a0b260f8642756a4"}}}}