{"comment":{"url":"https://api.github.com/repos/divolte/divolte-collector/comments/10618904","html_url":"https://github.com/divolte/divolte-collector/commit/5295274674312601b959f991d2242c4fecbfb63b#commitcomment-10618904","id":10618904,"user":{"login":"asnare","id":401970,"avatar_url":"https://avatars.githubusercontent.com/u/401970?v=3","gravatar_id":"","url":"https://api.github.com/users/asnare","html_url":"https://github.com/asnare","followers_url":"https://api.github.com/users/asnare/followers","following_url":"https://api.github.com/users/asnare/following{/other_user}","gists_url":"https://api.github.com/users/asnare/gists{/gist_id}","starred_url":"https://api.github.com/users/asnare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asnare/subscriptions","organizations_url":"https://api.github.com/users/asnare/orgs","repos_url":"https://api.github.com/users/asnare/repos","events_url":"https://api.github.com/users/asnare/events{/privacy}","received_events_url":"https://api.github.com/users/asnare/received_events","type":"User","site_admin":false},"position":80,"line":80,"path":"src/main/java/io/divolte/server/DivolteIdentifier.java","commit_id":"5295274674312601b959f991d2242c4fecbfb63b","created_at":"2015-04-08T08:42:19Z","updated_at":"2015-04-08T08:42:19Z","body":"This came from the old code, so I didn't think too much about it. However I just surveyed its usage:\r\n\r\n - The server will never invoke it with a `null` argument.\r\n - Some tests might, but these indicate fixture failures which should trigger test failures.\r\n\r\nWith this in mind, `null` indicates a programming error, so I'm fine with it throwing an exception instead of silently converting to `Optional.empty()`."}}