{"action":"created","issue":{"url":"https://api.github.com/repos/letsencrypt/boulder/issues/87","labels_url":"https://api.github.com/repos/letsencrypt/boulder/issues/87/labels{/name}","comments_url":"https://api.github.com/repos/letsencrypt/boulder/issues/87/comments","events_url":"https://api.github.com/repos/letsencrypt/boulder/issues/87/events","html_url":"https://github.com/letsencrypt/boulder/pull/87","id":67285553,"number":87,"title":"Fix Z computation (Dvsni challenge)","user":{"login":"rolandshoemaker","id":5080674,"avatar_url":"https://avatars.githubusercontent.com/u/5080674?v=3","gravatar_id":"","url":"https://api.github.com/users/rolandshoemaker","html_url":"https://github.com/rolandshoemaker","followers_url":"https://api.github.com/users/rolandshoemaker/followers","following_url":"https://api.github.com/users/rolandshoemaker/following{/other_user}","gists_url":"https://api.github.com/users/rolandshoemaker/gists{/gist_id}","starred_url":"https://api.github.com/users/rolandshoemaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rolandshoemaker/subscriptions","organizations_url":"https://api.github.com/users/rolandshoemaker/orgs","repos_url":"https://api.github.com/users/rolandshoemaker/repos","events_url":"https://api.github.com/users/rolandshoemaker/events{/privacy}","received_events_url":"https://api.github.com/users/rolandshoemaker/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-09T05:36:45Z","updated_at":"2015-04-09T05:39:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/letsencrypt/boulder/pulls/87","html_url":"https://github.com/letsencrypt/boulder/pull/87","diff_url":"https://github.com/letsencrypt/boulder/pull/87.diff","patch_url":"https://github.com/letsencrypt/boulder/pull/87.patch"},"body":"The `va` doesn't correctly create the variable `zName` that is used to compare with client provided SANs.  The current use of `sha256` results in `zName = 0000000000000000000000000000000000000000000000000000000000000000` (it also doesn't append the `.acme.invalid` suffix).\r\n\r\nThis very very simply switches out the previous `sha256` hash computation with `sha256.Sum256(RS)` and appends the ACME suffix using `fmt.Sprintf`.\r\n\r\n[Playground example of bug](https://play.golang.org/p/Wa8QiveU44)"},"comment":{"url":"https://api.github.com/repos/letsencrypt/boulder/issues/comments/91121099","html_url":"https://github.com/letsencrypt/boulder/pull/87#issuecomment-91121099","issue_url":"https://api.github.com/repos/letsencrypt/boulder/issues/87","id":91121099,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2015-04-09T05:39:09Z","updated_at":"2015-04-09T05:39:09Z","body":"\n[![Coverage Status](https://coveralls.io/builds/2297413/badge)](https://coveralls.io/builds/2297413)\n\nCoverage increased (+1.84%) to 33.42% when pulling **f7e3df3f6795a51dd42de2f6d54dfff6e707f2e8 on rolandshoemaker:va-fix** into **0a57f307a0671ecc32d14b697c380fac300d76f3 on letsencrypt:master**.\n"}}