{"action":"created","comment":{"url":"https://api.github.com/repos/laravel/framework/pulls/comments/44646466","id":44646466,"diff_hunk":"@@ -41,6 +43,15 @@ protected function getDefaultQueryGrammar()\n      */\n     protected function getDefaultSchemaGrammar()\n     {\n+        $version = strtolower($this->pdo->getAttribute(PDO::ATTR_SERVER_VERSION));\n+        if (","path":"src/Illuminate/Database/MySqlConnection.php","position":19,"original_position":19,"commit_id":"43e7a6ac687310c2c22bfaaa9bbeaa5574115b96","original_commit_id":"43e7a6ac687310c2c22bfaaa9bbeaa5574115b96","user":{"login":"GrahamCampbell","id":2829600,"avatar_url":"https://avatars.githubusercontent.com/u/2829600?v=3","gravatar_id":"","url":"https://api.github.com/users/GrahamCampbell","html_url":"https://github.com/GrahamCampbell","followers_url":"https://api.github.com/users/GrahamCampbell/followers","following_url":"https://api.github.com/users/GrahamCampbell/following{/other_user}","gists_url":"https://api.github.com/users/GrahamCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/GrahamCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrahamCampbell/subscriptions","organizations_url":"https://api.github.com/users/GrahamCampbell/orgs","repos_url":"https://api.github.com/users/GrahamCampbell/repos","events_url":"https://api.github.com/users/GrahamCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/GrahamCampbell/received_events","type":"User","site_admin":false},"body":"missing newline before writing if","created_at":"2015-11-12T11:24:08Z","updated_at":"2015-11-12T11:24:08Z","html_url":"https://github.com/laravel/framework/pull/10899#discussion_r44646466","pull_request_url":"https://api.github.com/repos/laravel/framework/pulls/10899","_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments/44646466"},"html":{"href":"https://github.com/laravel/framework/pull/10899#discussion_r44646466"},"pull_request":{"href":"https://api.github.com/repos/laravel/framework/pulls/10899"}}},"pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/10899","id":50487392,"html_url":"https://github.com/laravel/framework/pull/10899","diff_url":"https://github.com/laravel/framework/pull/10899.diff","patch_url":"https://github.com/laravel/framework/pull/10899.patch","issue_url":"https://api.github.com/repos/laravel/framework/issues/10899","number":10899,"state":"open","locked":false,"title":"[5.2] Implement new MySql grammar with 5.7 support","user":{"login":"rkgrep","id":2423048,"avatar_url":"https://avatars.githubusercontent.com/u/2423048?v=3","gravatar_id":"","url":"https://api.github.com/users/rkgrep","html_url":"https://github.com/rkgrep","followers_url":"https://api.github.com/users/rkgrep/followers","following_url":"https://api.github.com/users/rkgrep/following{/other_user}","gists_url":"https://api.github.com/users/rkgrep/gists{/gist_id}","starred_url":"https://api.github.com/users/rkgrep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkgrep/subscriptions","organizations_url":"https://api.github.com/users/rkgrep/orgs","repos_url":"https://api.github.com/users/rkgrep/repos","events_url":"https://api.github.com/users/rkgrep/events{/privacy}","received_events_url":"https://api.github.com/users/rkgrep/received_events","type":"User","site_admin":false},"body":"Related to #10867 \r\nChecks MySQL version and resolves proper grammar: with JSON support for 5.7+ and with `text` fallback for older.\r\n\r\nAs of MySQL forks:\r\n1. MariaDB is using other versioning system (10.0+) and currently does not support JSON - using legacy.\r\n2. Drizzle - the same (7.2+)\r\n3. Percona and WebScaleSQL - almost same versioning as MySQL","created_at":"2015-11-12T09:17:45Z","updated_at":"2015-11-12T11:24:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5592d2f777470bcb7ab9967fe5329dbce969a074","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/laravel/framework/pulls/10899/commits","review_comments_url":"https://api.github.com/repos/laravel/framework/pulls/10899/comments","review_comment_url":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/laravel/framework/issues/10899/comments","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/43e7a6ac687310c2c22bfaaa9bbeaa5574115b96","head":{"label":"rkgrep:patch-mysql-grammar","ref":"patch-mysql-grammar","sha":"43e7a6ac687310c2c22bfaaa9bbeaa5574115b96","user":{"login":"rkgrep","id":2423048,"avatar_url":"https://avatars.githubusercontent.com/u/2423048?v=3","gravatar_id":"","url":"https://api.github.com/users/rkgrep","html_url":"https://github.com/rkgrep","followers_url":"https://api.github.com/users/rkgrep/followers","following_url":"https://api.github.com/users/rkgrep/following{/other_user}","gists_url":"https://api.github.com/users/rkgrep/gists{/gist_id}","starred_url":"https://api.github.com/users/rkgrep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkgrep/subscriptions","organizations_url":"https://api.github.com/users/rkgrep/orgs","repos_url":"https://api.github.com/users/rkgrep/repos","events_url":"https://api.github.com/users/rkgrep/events{/privacy}","received_events_url":"https://api.github.com/users/rkgrep/received_events","type":"User","site_admin":false},"repo":{"id":30527323,"name":"framework","full_name":"rkgrep/framework","owner":{"login":"rkgrep","id":2423048,"avatar_url":"https://avatars.githubusercontent.com/u/2423048?v=3","gravatar_id":"","url":"https://api.github.com/users/rkgrep","html_url":"https://github.com/rkgrep","followers_url":"https://api.github.com/users/rkgrep/followers","following_url":"https://api.github.com/users/rkgrep/following{/other_user}","gists_url":"https://api.github.com/users/rkgrep/gists{/gist_id}","starred_url":"https://api.github.com/users/rkgrep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkgrep/subscriptions","organizations_url":"https://api.github.com/users/rkgrep/orgs","repos_url":"https://api.github.com/users/rkgrep/repos","events_url":"https://api.github.com/users/rkgrep/events{/privacy}","received_events_url":"https://api.github.com/users/rkgrep/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rkgrep/framework","description":"","fork":true,"url":"https://api.github.com/repos/rkgrep/framework","forks_url":"https://api.github.com/repos/rkgrep/framework/forks","keys_url":"https://api.github.com/repos/rkgrep/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rkgrep/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rkgrep/framework/teams","hooks_url":"https://api.github.com/repos/rkgrep/framework/hooks","issue_events_url":"https://api.github.com/repos/rkgrep/framework/issues/events{/number}","events_url":"https://api.github.com/repos/rkgrep/framework/events","assignees_url":"https://api.github.com/repos/rkgrep/framework/assignees{/user}","branches_url":"https://api.github.com/repos/rkgrep/framework/branches{/branch}","tags_url":"https://api.github.com/repos/rkgrep/framework/tags","blobs_url":"https://api.github.com/repos/rkgrep/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rkgrep/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rkgrep/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/rkgrep/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rkgrep/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/rkgrep/framework/languages","stargazers_url":"https://api.github.com/repos/rkgrep/framework/stargazers","contributors_url":"https://api.github.com/repos/rkgrep/framework/contributors","subscribers_url":"https://api.github.com/repos/rkgrep/framework/subscribers","subscription_url":"https://api.github.com/repos/rkgrep/framework/subscription","commits_url":"https://api.github.com/repos/rkgrep/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/rkgrep/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/rkgrep/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/rkgrep/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/rkgrep/framework/contents/{+path}","compare_url":"https://api.github.com/repos/rkgrep/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rkgrep/framework/merges","archive_url":"https://api.github.com/repos/rkgrep/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rkgrep/framework/downloads","issues_url":"https://api.github.com/repos/rkgrep/framework/issues{/number}","pulls_url":"https://api.github.com/repos/rkgrep/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/rkgrep/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/rkgrep/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rkgrep/framework/labels{/name}","releases_url":"https://api.github.com/repos/rkgrep/framework/releases{/id}","created_at":"2015-02-09T09:07:56Z","updated_at":"2015-03-23T08:09:45Z","pushed_at":"2015-11-12T11:10:07Z","git_url":"git://github.com/rkgrep/framework.git","ssh_url":"git@github.com:rkgrep/framework.git","clone_url":"https://github.com/rkgrep/framework.git","svn_url":"https://github.com/rkgrep/framework","homepage":"http://laravel.com","size":19607,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"laravel:master","ref":"master","sha":"ed87515c44495fdd1f87e5aa4d7915f922de494d","user":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"repo":{"id":7548986,"name":"framework","full_name":"laravel/framework","owner":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/laravel/framework","description":"","fork":false,"url":"https://api.github.com/repos/laravel/framework","forks_url":"https://api.github.com/repos/laravel/framework/forks","keys_url":"https://api.github.com/repos/laravel/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laravel/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laravel/framework/teams","hooks_url":"https://api.github.com/repos/laravel/framework/hooks","issue_events_url":"https://api.github.com/repos/laravel/framework/issues/events{/number}","events_url":"https://api.github.com/repos/laravel/framework/events","assignees_url":"https://api.github.com/repos/laravel/framework/assignees{/user}","branches_url":"https://api.github.com/repos/laravel/framework/branches{/branch}","tags_url":"https://api.github.com/repos/laravel/framework/tags","blobs_url":"https://api.github.com/repos/laravel/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laravel/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laravel/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/laravel/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/laravel/framework/languages","stargazers_url":"https://api.github.com/repos/laravel/framework/stargazers","contributors_url":"https://api.github.com/repos/laravel/framework/contributors","subscribers_url":"https://api.github.com/repos/laravel/framework/subscribers","subscription_url":"https://api.github.com/repos/laravel/framework/subscription","commits_url":"https://api.github.com/repos/laravel/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/laravel/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/laravel/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/laravel/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/laravel/framework/contents/{+path}","compare_url":"https://api.github.com/repos/laravel/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laravel/framework/merges","archive_url":"https://api.github.com/repos/laravel/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laravel/framework/downloads","issues_url":"https://api.github.com/repos/laravel/framework/issues{/number}","pulls_url":"https://api.github.com/repos/laravel/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/laravel/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/laravel/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laravel/framework/labels{/name}","releases_url":"https://api.github.com/repos/laravel/framework/releases{/id}","created_at":"2013-01-10T21:27:28Z","updated_at":"2015-11-12T09:08:27Z","pushed_at":"2015-11-12T11:10:08Z","git_url":"git://github.com/laravel/framework.git","ssh_url":"git@github.com:laravel/framework.git","clone_url":"https://github.com/laravel/framework.git","svn_url":"https://github.com/laravel/framework","homepage":"http://laravel.com","size":70758,"stargazers_count":4319,"watchers_count":4319,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2495,"mirror_url":null,"open_issues_count":103,"forks":2495,"open_issues":103,"watchers":4319,"default_branch":"5.1"}},"_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/10899"},"html":{"href":"https://github.com/laravel/framework/pull/10899"},"issue":{"href":"https://api.github.com/repos/laravel/framework/issues/10899"},"comments":{"href":"https://api.github.com/repos/laravel/framework/issues/10899/comments"},"review_comments":{"href":"https://api.github.com/repos/laravel/framework/pulls/10899/comments"},"review_comment":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/laravel/framework/pulls/10899/commits"},"statuses":{"href":"https://api.github.com/repos/laravel/framework/statuses/43e7a6ac687310c2c22bfaaa9bbeaa5574115b96"}}}}