{"action":"opened","number":337,"pull_request":{"url":"https://api.github.com/repos/johnpapa/angular-styleguide/pulls/337","id":31195007,"html_url":"https://github.com/johnpapa/angular-styleguide/pull/337","diff_url":"https://github.com/johnpapa/angular-styleguide/pull/337.diff","patch_url":"https://github.com/johnpapa/angular-styleguide/pull/337.patch","issue_url":"https://api.github.com/repos/johnpapa/angular-styleguide/issues/337","number":337,"state":"open","locked":false,"title":"Avoid using $ in factory and service names","user":{"login":"jbalboni","id":634932,"avatar_url":"https://avatars.githubusercontent.com/u/634932?v=3","gravatar_id":"","url":"https://api.github.com/users/jbalboni","html_url":"https://github.com/jbalboni","followers_url":"https://api.github.com/users/jbalboni/followers","following_url":"https://api.github.com/users/jbalboni/following{/other_user}","gists_url":"https://api.github.com/users/jbalboni/gists{/gist_id}","starred_url":"https://api.github.com/users/jbalboni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbalboni/subscriptions","organizations_url":"https://api.github.com/users/jbalboni/orgs","repos_url":"https://api.github.com/users/jbalboni/repos","events_url":"https://api.github.com/users/jbalboni/events{/privacy}","received_events_url":"https://api.github.com/users/jbalboni/received_events","type":"User","site_admin":false},"body":"PR to address #335. It didn't seem worth its own rule, so I added to the existing factory naming rule.","created_at":"2015-03-15T04:07:40Z","updated_at":"2015-03-15T04:07:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/johnpapa/angular-styleguide/pulls/337/commits","review_comments_url":"https://api.github.com/repos/johnpapa/angular-styleguide/pulls/337/comments","review_comment_url":"https://api.github.com/repos/johnpapa/angular-styleguide/pulls/comments{/number}","comments_url":"https://api.github.com/repos/johnpapa/angular-styleguide/issues/337/comments","statuses_url":"https://api.github.com/repos/johnpapa/angular-styleguide/statuses/c2e29db3d4e3e9482622cf9b05dc13114f0115b7","head":{"label":"jbalboni:jbalboni-service-prefix","ref":"jbalboni-service-prefix","sha":"c2e29db3d4e3e9482622cf9b05dc13114f0115b7","user":{"login":"jbalboni","id":634932,"avatar_url":"https://avatars.githubusercontent.com/u/634932?v=3","gravatar_id":"","url":"https://api.github.com/users/jbalboni","html_url":"https://github.com/jbalboni","followers_url":"https://api.github.com/users/jbalboni/followers","following_url":"https://api.github.com/users/jbalboni/following{/other_user}","gists_url":"https://api.github.com/users/jbalboni/gists{/gist_id}","starred_url":"https://api.github.com/users/jbalboni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbalboni/subscriptions","organizations_url":"https://api.github.com/users/jbalboni/orgs","repos_url":"https://api.github.com/users/jbalboni/repos","events_url":"https://api.github.com/users/jbalboni/events{/privacy}","received_events_url":"https://api.github.com/users/jbalboni/received_events","type":"User","site_admin":false},"repo":{"id":32244037,"name":"angular-styleguide","full_name":"jbalboni/angular-styleguide","owner":{"login":"jbalboni","id":634932,"avatar_url":"https://avatars.githubusercontent.com/u/634932?v=3","gravatar_id":"","url":"https://api.github.com/users/jbalboni","html_url":"https://github.com/jbalboni","followers_url":"https://api.github.com/users/jbalboni/followers","following_url":"https://api.github.com/users/jbalboni/following{/other_user}","gists_url":"https://api.github.com/users/jbalboni/gists{/gist_id}","starred_url":"https://api.github.com/users/jbalboni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbalboni/subscriptions","organizations_url":"https://api.github.com/users/jbalboni/orgs","repos_url":"https://api.github.com/users/jbalboni/repos","events_url":"https://api.github.com/users/jbalboni/events{/privacy}","received_events_url":"https://api.github.com/users/jbalboni/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jbalboni/angular-styleguide","description":"Angular Style Guide: A starting point for Angular development teams to provide consistency through good practices.","fork":true,"url":"https://api.github.com/repos/jbalboni/angular-styleguide","forks_url":"https://api.github.com/repos/jbalboni/angular-styleguide/forks","keys_url":"https://api.github.com/repos/jbalboni/angular-styleguide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbalboni/angular-styleguide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbalboni/angular-styleguide/teams","hooks_url":"https://api.github.com/repos/jbalboni/angular-styleguide/hooks","issue_events_url":"https://api.github.com/repos/jbalboni/angular-styleguide/issues/events{/number}","events_url":"https://api.github.com/repos/jbalboni/angular-styleguide/events","assignees_url":"https://api.github.com/repos/jbalboni/angular-styleguide/assignees{/user}","branches_url":"https://api.github.com/repos/jbalboni/angular-styleguide/branches{/branch}","tags_url":"https://api.github.com/repos/jbalboni/angular-styleguide/tags","blobs_url":"https://api.github.com/repos/jbalboni/angular-styleguide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbalboni/angular-styleguide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbalboni/angular-styleguide/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbalboni/angular-styleguide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbalboni/angular-styleguide/statuses/{sha}","languages_url":"https://api.github.com/repos/jbalboni/angular-styleguide/languages","stargazers_url":"https://api.github.com/repos/jbalboni/angular-styleguide/stargazers","contributors_url":"https://api.github.com/repos/jbalboni/angular-styleguide/contributors","subscribers_url":"https://api.github.com/repos/jbalboni/angular-styleguide/subscribers","subscription_url":"https://api.github.com/repos/jbalboni/angular-styleguide/subscription","commits_url":"https://api.github.com/repos/jbalboni/angular-styleguide/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbalboni/angular-styleguide/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbalboni/angular-styleguide/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbalboni/angular-styleguide/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbalboni/angular-styleguide/contents/{+path}","compare_url":"https://api.github.com/repos/jbalboni/angular-styleguide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbalboni/angular-styleguide/merges","archive_url":"https://api.github.com/repos/jbalboni/angular-styleguide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbalboni/angular-styleguide/downloads","issues_url":"https://api.github.com/repos/jbalboni/angular-styleguide/issues{/number}","pulls_url":"https://api.github.com/repos/jbalboni/angular-styleguide/pulls{/number}","milestones_url":"https://api.github.com/repos/jbalboni/angular-styleguide/milestones{/number}","notifications_url":"https://api.github.com/repos/jbalboni/angular-styleguide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbalboni/angular-styleguide/labels{/name}","releases_url":"https://api.github.com/repos/jbalboni/angular-styleguide/releases{/id}","created_at":"2015-03-15T03:53:42Z","updated_at":"2015-03-15T02:31:36Z","pushed_at":"2015-03-15T04:02:19Z","git_url":"git://github.com/jbalboni/angular-styleguide.git","ssh_url":"git@github.com:jbalboni/angular-styleguide.git","clone_url":"https://github.com/jbalboni/angular-styleguide.git","svn_url":"https://github.com/jbalboni/angular-styleguide","homepage":"http://johnpapa.net","size":5641,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"johnpapa:master","ref":"master","sha":"f430bdbbd36b70e88ef62f74d9a865617d7eef49","user":{"login":"johnpapa","id":1202528,"avatar_url":"https://avatars.githubusercontent.com/u/1202528?v=3","gravatar_id":"","url":"https://api.github.com/users/johnpapa","html_url":"https://github.com/johnpapa","followers_url":"https://api.github.com/users/johnpapa/followers","following_url":"https://api.github.com/users/johnpapa/following{/other_user}","gists_url":"https://api.github.com/users/johnpapa/gists{/gist_id}","starred_url":"https://api.github.com/users/johnpapa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnpapa/subscriptions","organizations_url":"https://api.github.com/users/johnpapa/orgs","repos_url":"https://api.github.com/users/johnpapa/repos","events_url":"https://api.github.com/users/johnpapa/events{/privacy}","received_events_url":"https://api.github.com/users/johnpapa/received_events","type":"User","site_admin":false},"repo":{"id":22362099,"name":"angular-styleguide","full_name":"johnpapa/angular-styleguide","owner":{"login":"johnpapa","id":1202528,"avatar_url":"https://avatars.githubusercontent.com/u/1202528?v=3","gravatar_id":"","url":"https://api.github.com/users/johnpapa","html_url":"https://github.com/johnpapa","followers_url":"https://api.github.com/users/johnpapa/followers","following_url":"https://api.github.com/users/johnpapa/following{/other_user}","gists_url":"https://api.github.com/users/johnpapa/gists{/gist_id}","starred_url":"https://api.github.com/users/johnpapa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnpapa/subscriptions","organizations_url":"https://api.github.com/users/johnpapa/orgs","repos_url":"https://api.github.com/users/johnpapa/repos","events_url":"https://api.github.com/users/johnpapa/events{/privacy}","received_events_url":"https://api.github.com/users/johnpapa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnpapa/angular-styleguide","description":"Angular Style Guide: A starting point for Angular development teams to provide consistency through good practices.","fork":false,"url":"https://api.github.com/repos/johnpapa/angular-styleguide","forks_url":"https://api.github.com/repos/johnpapa/angular-styleguide/forks","keys_url":"https://api.github.com/repos/johnpapa/angular-styleguide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnpapa/angular-styleguide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnpapa/angular-styleguide/teams","hooks_url":"https://api.github.com/repos/johnpapa/angular-styleguide/hooks","issue_events_url":"https://api.github.com/repos/johnpapa/angular-styleguide/issues/events{/number}","events_url":"https://api.github.com/repos/johnpapa/angular-styleguide/events","assignees_url":"https://api.github.com/repos/johnpapa/angular-styleguide/assignees{/user}","branches_url":"https://api.github.com/repos/johnpapa/angular-styleguide/branches{/branch}","tags_url":"https://api.github.com/repos/johnpapa/angular-styleguide/tags","blobs_url":"https://api.github.com/repos/johnpapa/angular-styleguide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnpapa/angular-styleguide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnpapa/angular-styleguide/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnpapa/angular-styleguide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnpapa/angular-styleguide/statuses/{sha}","languages_url":"https://api.github.com/repos/johnpapa/angular-styleguide/languages","stargazers_url":"https://api.github.com/repos/johnpapa/angular-styleguide/stargazers","contributors_url":"https://api.github.com/repos/johnpapa/angular-styleguide/contributors","subscribers_url":"https://api.github.com/repos/johnpapa/angular-styleguide/subscribers","subscription_url":"https://api.github.com/repos/johnpapa/angular-styleguide/subscription","commits_url":"https://api.github.com/repos/johnpapa/angular-styleguide/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnpapa/angular-styleguide/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnpapa/angular-styleguide/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnpapa/angular-styleguide/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnpapa/angular-styleguide/contents/{+path}","compare_url":"https://api.github.com/repos/johnpapa/angular-styleguide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnpapa/angular-styleguide/merges","archive_url":"https://api.github.com/repos/johnpapa/angular-styleguide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnpapa/angular-styleguide/downloads","issues_url":"https://api.github.com/repos/johnpapa/angular-styleguide/issues{/number}","pulls_url":"https://api.github.com/repos/johnpapa/angular-styleguide/pulls{/number}","milestones_url":"https://api.github.com/repos/johnpapa/angular-styleguide/milestones{/number}","notifications_url":"https://api.github.com/repos/johnpapa/angular-styleguide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnpapa/angular-styleguide/labels{/name}","releases_url":"https://api.github.com/repos/johnpapa/angular-styleguide/releases{/id}","created_at":"2014-07-29T00:07:51Z","updated_at":"2015-03-15T02:31:36Z","pushed_at":"2015-03-15T00:44:51Z","git_url":"git://github.com/johnpapa/angular-styleguide.git","ssh_url":"git@github.com:johnpapa/angular-styleguide.git","clone_url":"https://github.com/johnpapa/angular-styleguide.git","svn_url":"https://github.com/johnpapa/angular-styleguide","homepage":"http://johnpapa.net","size":5641,"stargazers_count":6365,"watchers_count":6365,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":793,"mirror_url":null,"open_issues_count":9,"forks":793,"open_issues":9,"watchers":6365,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/johnpapa/angular-styleguide/pulls/337"},"html":{"href":"https://github.com/johnpapa/angular-styleguide/pull/337"},"issue":{"href":"https://api.github.com/repos/johnpapa/angular-styleguide/issues/337"},"comments":{"href":"https://api.github.com/repos/johnpapa/angular-styleguide/issues/337/comments"},"review_comments":{"href":"https://api.github.com/repos/johnpapa/angular-styleguide/pulls/337/comments"},"review_comment":{"href":"https://api.github.com/repos/johnpapa/angular-styleguide/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/johnpapa/angular-styleguide/pulls/337/commits"},"statuses":{"href":"https://api.github.com/repos/johnpapa/angular-styleguide/statuses/c2e29db3d4e3e9482622cf9b05dc13114f0115b7"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":3,"deletions":1,"changed_files":1}}