{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/12783","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/12783/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/12783/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/12783/events","html_url":"https://github.com/mantidproject/mantid/pull/12783","id":86900441,"number":12783,"title":"Load separate period good frame values","user":{"login":"raquelalvarezbanos","id":8956985,"avatar_url":"https://avatars.githubusercontent.com/u/8956985?v=3","gravatar_id":"","url":"https://api.github.com/users/raquelalvarezbanos","html_url":"https://github.com/raquelalvarezbanos","followers_url":"https://api.github.com/users/raquelalvarezbanos/followers","following_url":"https://api.github.com/users/raquelalvarezbanos/following{/other_user}","gists_url":"https://api.github.com/users/raquelalvarezbanos/gists{/gist_id}","starred_url":"https://api.github.com/users/raquelalvarezbanos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raquelalvarezbanos/subscriptions","organizations_url":"https://api.github.com/users/raquelalvarezbanos/orgs","repos_url":"https://api.github.com/users/raquelalvarezbanos/repos","events_url":"https://api.github.com/users/raquelalvarezbanos/events{/privacy}","received_events_url":"https://api.github.com/users/raquelalvarezbanos/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Bugfix","name":"Bugfix","color":"eb6420"},{"url":"https://api.github.com/repos/mantidproject/mantid/labels/In%20Progress","name":"In Progress","color":"fbca04"},{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Muon","name":"Muon","color":"fef2c0"},{"url":"https://api.github.com/repos/mantidproject/mantid/labels/NeXus","name":"NeXus","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/3","html_url":"https://github.com/mantidproject/mantid/milestones/Release%203.5","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/3/labels","id":1058985,"number":3,"title":"Release 3.5","description":"This is a placeholder in git for the [trac Release 3.5 milestone](http://trac.mantidproject.org/mantid/milestone/Release%203.5)","creator":{"login":"peterfpeterson","id":404003,"avatar_url":"https://avatars.githubusercontent.com/u/404003?v=3","gravatar_id":"","url":"https://api.github.com/users/peterfpeterson","html_url":"https://github.com/peterfpeterson","followers_url":"https://api.github.com/users/peterfpeterson/followers","following_url":"https://api.github.com/users/peterfpeterson/following{/other_user}","gists_url":"https://api.github.com/users/peterfpeterson/gists{/gist_id}","starred_url":"https://api.github.com/users/peterfpeterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterfpeterson/subscriptions","organizations_url":"https://api.github.com/users/peterfpeterson/orgs","repos_url":"https://api.github.com/users/peterfpeterson/repos","events_url":"https://api.github.com/users/peterfpeterson/events{/privacy}","received_events_url":"https://api.github.com/users/peterfpeterson/received_events","type":"User","site_admin":false},"open_issues":394,"closed_issues":282,"state":"open","created_at":"2015-04-08T18:44:37Z","updated_at":"2015-06-10T13:10:45Z","due_on":"2015-10-01T04:00:00Z","closed_at":null},"comments":2,"created_at":"2015-06-10T09:18:46Z","updated_at":"2015-06-10T15:45:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/12783","html_url":"https://github.com/mantidproject/mantid/pull/12783","diff_url":"https://github.com/mantidproject/mantid/pull/12783.diff","patch_url":"https://github.com/mantidproject/mantid/pull/12783.patch"},"body":"Fixes #7820\r\n\r\nLoadMuonNexus fails to load data for good frames by period. At present the 'goodfrm' log is read from /run/instrument/beam/frames_good and it is wrong as is it a single value which is the sum of all of the periods. It should be read from /run/instrument/beam/frames_period_daq/, which contains a vector of values for each period.\r\n\r\nTester: Open MUSR00015189.nxs in Mantid. Right-click on both workspaces to show \"Sample Logs\". Check 'goodfrm', it should be 2500 in both cases. If you open the file in HDFView, these numbers should match what you see in /run/instrument/beam/frames_period_daq/."},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/110806336","html_url":"https://github.com/mantidproject/mantid/pull/12783#issuecomment-110806336","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/12783","id":110806336,"user":{"login":"raquelalvarezbanos","id":8956985,"avatar_url":"https://avatars.githubusercontent.com/u/8956985?v=3","gravatar_id":"","url":"https://api.github.com/users/raquelalvarezbanos","html_url":"https://github.com/raquelalvarezbanos","followers_url":"https://api.github.com/users/raquelalvarezbanos/followers","following_url":"https://api.github.com/users/raquelalvarezbanos/following{/other_user}","gists_url":"https://api.github.com/users/raquelalvarezbanos/gists{/gist_id}","starred_url":"https://api.github.com/users/raquelalvarezbanos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raquelalvarezbanos/subscriptions","organizations_url":"https://api.github.com/users/raquelalvarezbanos/orgs","repos_url":"https://api.github.com/users/raquelalvarezbanos/repos","events_url":"https://api.github.com/users/raquelalvarezbanos/events{/privacy}","received_events_url":"https://api.github.com/users/raquelalvarezbanos/received_events","type":"User","site_admin":false},"created_at":"2015-06-10T15:45:47Z","updated_at":"2015-06-10T15:45:47Z","body":"Yes, I know, thanks. I have solved them locally but there are some additional problems with unit tests failing on windows which I need to discuss with scientists and Freddie. The problem is that one of the files used for testing (EMU00006473.nxs) seems to have contradictory information, as the entry 'frames_good' (which is supposed to be the sum of good frames of all periods) does not match what you get from the entry 'frames_period_daq' (which is supposed to contain the information for each period separately). In this specific case, as EMU00006473 is a single period dataset, both numbers should be the same, but for some reason they are not. James Lord has also found an example of a multi period dataset (EMU00006475.nxs) where 'frames_good' is significantly smaller than the total sum of the frames in Frames_Period_DAQ. I am waiting for a response from Freddie to see how I should process the information in these files."}}