{"action":"created","issue":{"url":"https://api.github.com/repos/cask/cask/issues/326","labels_url":"https://api.github.com/repos/cask/cask/issues/326/labels{/name}","comments_url":"https://api.github.com/repos/cask/cask/issues/326/comments","events_url":"https://api.github.com/repos/cask/cask/issues/326/events","html_url":"https://github.com/cask/cask/pull/326","id":121859754,"number":326,"title":"Ci and package toolset","user":{"login":"AdrieanKhisbe","id":2601132,"avatar_url":"https://avatars.githubusercontent.com/u/2601132?v=3","gravatar_id":"","url":"https://api.github.com/users/AdrieanKhisbe","html_url":"https://github.com/AdrieanKhisbe","followers_url":"https://api.github.com/users/AdrieanKhisbe/followers","following_url":"https://api.github.com/users/AdrieanKhisbe/following{/other_user}","gists_url":"https://api.github.com/users/AdrieanKhisbe/gists{/gist_id}","starred_url":"https://api.github.com/users/AdrieanKhisbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdrieanKhisbe/subscriptions","organizations_url":"https://api.github.com/users/AdrieanKhisbe/orgs","repos_url":"https://api.github.com/users/AdrieanKhisbe/repos","events_url":"https://api.github.com/users/AdrieanKhisbe/events{/privacy}","received_events_url":"https://api.github.com/users/AdrieanKhisbe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-12-12T14:41:47Z","updated_at":"2015-12-12T14:51:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cask/cask/pulls/326","html_url":"https://github.com/cask/cask/pull/326","diff_url":"https://github.com/cask/cask/pull/326.diff","patch_url":"https://github.com/cask/cask/pull/326.patch"},"body":"Improved CI and README:\r\n\r\nhave a look here: \r\n- README: https://github.com/AdrieanKhisbe/cask/tree/ci-and-package-toolset\r\n- build: https://travis-ci.org/AdrieanKhisbe/cask/builds\r\n- coverage: https://coveralls.io/github/AdrieanKhisbe/cask\r\n\r\nWhat PR consist:\r\n- Update of travis with evm 0.7 (-> containers, evm-travis)\r\n- coverage for unit test. \r\n- ci badge to README\r\n-  some more introduction to README\r\n- scaffolded `Cask`  file now countain [cask-package-toolset](https://github.com/AdrieanKhisbe/cask-package-toolset.el), tool to help set up CI on cask project.\r\n\r\nWhat could be idealy done:\r\nadd coverage for features test, but that would require to ack around (cf https://github.com/AdrieanKhisbe/cask-package-toolset.el/blob/master/features/step-definitions/cask-package-toolset-steps.el#L7-L28)"},"comment":{"url":"https://api.github.com/repos/cask/cask/issues/comments/164159435","html_url":"https://github.com/cask/cask/pull/326#issuecomment-164159435","issue_url":"https://api.github.com/repos/cask/cask/issues/326","id":164159435,"user":{"login":"lunaryorn","id":224922,"avatar_url":"https://avatars.githubusercontent.com/u/224922?v=3","gravatar_id":"","url":"https://api.github.com/users/lunaryorn","html_url":"https://github.com/lunaryorn","followers_url":"https://api.github.com/users/lunaryorn/followers","following_url":"https://api.github.com/users/lunaryorn/following{/other_user}","gists_url":"https://api.github.com/users/lunaryorn/gists{/gist_id}","starred_url":"https://api.github.com/users/lunaryorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lunaryorn/subscriptions","organizations_url":"https://api.github.com/users/lunaryorn/orgs","repos_url":"https://api.github.com/users/lunaryorn/repos","events_url":"https://api.github.com/users/lunaryorn/events{/privacy}","received_events_url":"https://api.github.com/users/lunaryorn/received_events","type":"User","site_admin":false},"created_at":"2015-12-12T14:51:11Z","updated_at":"2015-12-12T14:51:11Z","body":"Thank you for this elaborate changeset.  I like your changes to the README, but I'm unsure about coveralls and about cask-package-toolset.\r\n\r\nWhile I'm all for the idea of measuring test coverage, I'd like to know how it measures test coverage, and how much work it'd be to integrate the feature tests which are somewhat important to us.\r\n\r\nAs for cask-package-toolset, what is it, and how does it us and our users?  I'm careful to recommend 3rd party projects in our documentation… and if it's important or useful, shouldn't we make it part of Cask itself?"}}