{"action":"created","issue":{"url":"https://api.github.com/repos/potentialventures/cocotb/issues/262","labels_url":"https://api.github.com/repos/potentialventures/cocotb/issues/262/labels{/name}","comments_url":"https://api.github.com/repos/potentialventures/cocotb/issues/262/comments","events_url":"https://api.github.com/repos/potentialventures/cocotb/issues/262/events","html_url":"https://github.com/potentialventures/cocotb/pull/262","id":95969317,"number":262,"title":"Addresses multiple issues.","user":{"login":"leftink","id":4984003,"avatar_url":"https://avatars.githubusercontent.com/u/4984003?v=3","gravatar_id":"","url":"https://api.github.com/users/leftink","html_url":"https://github.com/leftink","followers_url":"https://api.github.com/users/leftink/followers","following_url":"https://api.github.com/users/leftink/following{/other_user}","gists_url":"https://api.github.com/users/leftink/gists{/gist_id}","starred_url":"https://api.github.com/users/leftink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leftink/subscriptions","organizations_url":"https://api.github.com/users/leftink/orgs","repos_url":"https://api.github.com/users/leftink/repos","events_url":"https://api.github.com/users/leftink/events{/privacy}","received_events_url":"https://api.github.com/users/leftink/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-07-20T02:13:01Z","updated_at":"2015-07-20T16:59:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/potentialventures/cocotb/pulls/262","html_url":"https://github.com/potentialventures/cocotb/pull/262","diff_url":"https://github.com/potentialventures/cocotb/pull/262.diff","patch_url":"https://github.com/potentialventures/cocotb/pull/262.patch"},"body":"The following issues are addressed with this commit:\r\n#252, #253, #256, #257, #259, #260, #261 \r\n\r\nThese changes primarily affect the FLI interface, however, to add support for TOPLEVEL not being defined, I had a few minor changes to VPI and VHPI.  I also moved the search string for finding handles down into the interfaces so the strings could be properly built based on the interface.\r\n\r\nI have tested the FLI changes using QuestaSIM.  I don't currently have access to a simulator that will let me test the VHPI/VPI changes, but everything compiles.\r\n"},"comment":{"url":"https://api.github.com/repos/potentialventures/cocotb/issues/comments/122951269","html_url":"https://github.com/potentialventures/cocotb/pull/262#issuecomment-122951269","issue_url":"https://api.github.com/repos/potentialventures/cocotb/issues/262","id":122951269,"user":{"login":"chiggs","id":413627,"avatar_url":"https://avatars.githubusercontent.com/u/413627?v=3","gravatar_id":"","url":"https://api.github.com/users/chiggs","html_url":"https://github.com/chiggs","followers_url":"https://api.github.com/users/chiggs/followers","following_url":"https://api.github.com/users/chiggs/following{/other_user}","gists_url":"https://api.github.com/users/chiggs/gists{/gist_id}","starred_url":"https://api.github.com/users/chiggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chiggs/subscriptions","organizations_url":"https://api.github.com/users/chiggs/orgs","repos_url":"https://api.github.com/users/chiggs/repos","events_url":"https://api.github.com/users/chiggs/events{/privacy}","received_events_url":"https://api.github.com/users/chiggs/received_events","type":"User","site_admin":false},"created_at":"2015-07-20T16:59:40Z","updated_at":"2015-07-20T16:59:40Z","body":"@leftink think referencing issue numbers should still work, at least when it gets merged, but we'll have to try it.\n\nRegarding splitting the merge requests, in this case it's less straightforward. In theory git is quite good at merging so unrelated changes to the same file should be OK, but dependent changes obviously have to be grouped together."}}