{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/comments/31077919","id":31077919,"diff_hunk":"@@ -429,6 +431,9 @@ module ts {\n                 case SyntaxKind.TypeParameter:\r\n                     bindDeclaration(<Declaration>node, SymbolFlags.TypeParameter, SymbolFlags.TypeParameterExcludes, /*isBlockScopeContainer*/ false);\r\n                     break;\r\n+                case SyntaxKind.TypeGuardType:\r\n+                    bindDeclaration(<Declaration>node, (SymbolFlags.TypeGuardType | SymbolFlags.Value), SymbolFlags.TypeGuardTypeExcludes, /*isBlockScopeContainer*/ false);\r","path":"src/compiler/binder.ts","position":14,"original_position":14,"commit_id":"4a6e85b11c55b31d13c6e6e90f558a0abeb24128","original_commit_id":"4a6e85b11c55b31d13c6e6e90f558a0abeb24128","user":{"login":"mhegazy","id":8000722,"avatar_url":"https://avatars.githubusercontent.com/u/8000722?v=3","gravatar_id":"","url":"https://api.github.com/users/mhegazy","html_url":"https://github.com/mhegazy","followers_url":"https://api.github.com/users/mhegazy/followers","following_url":"https://api.github.com/users/mhegazy/following{/other_user}","gists_url":"https://api.github.com/users/mhegazy/gists{/gist_id}","starred_url":"https://api.github.com/users/mhegazy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhegazy/subscriptions","organizations_url":"https://api.github.com/users/mhegazy/orgs","repos_url":"https://api.github.com/users/mhegazy/repos","events_url":"https://api.github.com/users/mhegazy/events{/privacy}","received_events_url":"https://api.github.com/users/mhegazy/received_events","type":"User","site_admin":false},"body":"why is that even bound? it does not create a symbol.. it is not creating a new type, it is just `boolean` with additional properties.. correct?","created_at":"2015-05-26T20:46:53Z","updated_at":"2015-05-26T20:46:53Z","html_url":"https://github.com/Microsoft/TypeScript/pull/3262#discussion_r31077919","pull_request_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/3262","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/comments/31077919"},"html":{"href":"https://github.com/Microsoft/TypeScript/pull/3262#discussion_r31077919"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/3262"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/3262","id":36141483,"html_url":"https://github.com/Microsoft/TypeScript/pull/3262","diff_url":"https://github.com/Microsoft/TypeScript/pull/3262.diff","patch_url":"https://github.com/Microsoft/TypeScript/pull/3262.patch","issue_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/3262","number":3262,"state":"open","locked":false,"title":"Custom type guard function","user":{"login":"tinganho","id":1324476,"avatar_url":"https://avatars.githubusercontent.com/u/1324476?v=3","gravatar_id":"","url":"https://api.github.com/users/tinganho","html_url":"https://github.com/tinganho","followers_url":"https://api.github.com/users/tinganho/followers","following_url":"https://api.github.com/users/tinganho/following{/other_user}","gists_url":"https://api.github.com/users/tinganho/gists{/gist_id}","starred_url":"https://api.github.com/users/tinganho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinganho/subscriptions","organizations_url":"https://api.github.com/users/tinganho/orgs","repos_url":"https://api.github.com/users/tinganho/repos","events_url":"https://api.github.com/users/tinganho/events{/privacy}","received_events_url":"https://api.github.com/users/tinganho/received_events","type":"User","site_admin":false},"body":"Implements only the function part of #1007. I thought it was best to have some early feedback first before I implement the class method part. So that I know I'm on the same page.\r\n\r\nI consider the type guard type as a new type. Pls. check my tests for all specifications right now. I'm not sure if it's according to your specs. So would be good to have feedback on that.\r\n\r\nAnother question I have is if I should ban declaring type guard types on non-function-like declarations? I haven't implemented this ban yet. Example:\r\n```typescript\r\nvar a: t is item //Error\r\n```","created_at":"2015-05-25T14:03:58Z","updated_at":"2015-05-26T20:46:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89f599ef062080f70fdc55a344a12c6cb5f544c8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/3262/commits","review_comments_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/3262/comments","review_comment_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/3262/comments","statuses_url":"https://api.github.com/repos/Microsoft/TypeScript/statuses/4a6e85b11c55b31d13c6e6e90f558a0abeb24128","head":{"label":"tinganho:customTypeGuard2","ref":"customTypeGuard2","sha":"4a6e85b11c55b31d13c6e6e90f558a0abeb24128","user":{"login":"tinganho","id":1324476,"avatar_url":"https://avatars.githubusercontent.com/u/1324476?v=3","gravatar_id":"","url":"https://api.github.com/users/tinganho","html_url":"https://github.com/tinganho","followers_url":"https://api.github.com/users/tinganho/followers","following_url":"https://api.github.com/users/tinganho/following{/other_user}","gists_url":"https://api.github.com/users/tinganho/gists{/gist_id}","starred_url":"https://api.github.com/users/tinganho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinganho/subscriptions","organizations_url":"https://api.github.com/users/tinganho/orgs","repos_url":"https://api.github.com/users/tinganho/repos","events_url":"https://api.github.com/users/tinganho/events{/privacy}","received_events_url":"https://api.github.com/users/tinganho/received_events","type":"User","site_admin":false},"repo":{"id":31378465,"name":"TypeScript","full_name":"tinganho/TypeScript","owner":{"login":"tinganho","id":1324476,"avatar_url":"https://avatars.githubusercontent.com/u/1324476?v=3","gravatar_id":"","url":"https://api.github.com/users/tinganho","html_url":"https://github.com/tinganho","followers_url":"https://api.github.com/users/tinganho/followers","following_url":"https://api.github.com/users/tinganho/following{/other_user}","gists_url":"https://api.github.com/users/tinganho/gists{/gist_id}","starred_url":"https://api.github.com/users/tinganho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinganho/subscriptions","organizations_url":"https://api.github.com/users/tinganho/orgs","repos_url":"https://api.github.com/users/tinganho/repos","events_url":"https://api.github.com/users/tinganho/events{/privacy}","received_events_url":"https://api.github.com/users/tinganho/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tinganho/TypeScript","description":"TypeScript is a superset of JavaScript that compiles to clean JavaScript output.","fork":true,"url":"https://api.github.com/repos/tinganho/TypeScript","forks_url":"https://api.github.com/repos/tinganho/TypeScript/forks","keys_url":"https://api.github.com/repos/tinganho/TypeScript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tinganho/TypeScript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tinganho/TypeScript/teams","hooks_url":"https://api.github.com/repos/tinganho/TypeScript/hooks","issue_events_url":"https://api.github.com/repos/tinganho/TypeScript/issues/events{/number}","events_url":"https://api.github.com/repos/tinganho/TypeScript/events","assignees_url":"https://api.github.com/repos/tinganho/TypeScript/assignees{/user}","branches_url":"https://api.github.com/repos/tinganho/TypeScript/branches{/branch}","tags_url":"https://api.github.com/repos/tinganho/TypeScript/tags","blobs_url":"https://api.github.com/repos/tinganho/TypeScript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tinganho/TypeScript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tinganho/TypeScript/git/refs{/sha}","trees_url":"https://api.github.com/repos/tinganho/TypeScript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tinganho/TypeScript/statuses/{sha}","languages_url":"https://api.github.com/repos/tinganho/TypeScript/languages","stargazers_url":"https://api.github.com/repos/tinganho/TypeScript/stargazers","contributors_url":"https://api.github.com/repos/tinganho/TypeScript/contributors","subscribers_url":"https://api.github.com/repos/tinganho/TypeScript/subscribers","subscription_url":"https://api.github.com/repos/tinganho/TypeScript/subscription","commits_url":"https://api.github.com/repos/tinganho/TypeScript/commits{/sha}","git_commits_url":"https://api.github.com/repos/tinganho/TypeScript/git/commits{/sha}","comments_url":"https://api.github.com/repos/tinganho/TypeScript/comments{/number}","issue_comment_url":"https://api.github.com/repos/tinganho/TypeScript/issues/comments{/number}","contents_url":"https://api.github.com/repos/tinganho/TypeScript/contents/{+path}","compare_url":"https://api.github.com/repos/tinganho/TypeScript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tinganho/TypeScript/merges","archive_url":"https://api.github.com/repos/tinganho/TypeScript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tinganho/TypeScript/downloads","issues_url":"https://api.github.com/repos/tinganho/TypeScript/issues{/number}","pulls_url":"https://api.github.com/repos/tinganho/TypeScript/pulls{/number}","milestones_url":"https://api.github.com/repos/tinganho/TypeScript/milestones{/number}","notifications_url":"https://api.github.com/repos/tinganho/TypeScript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tinganho/TypeScript/labels{/name}","releases_url":"https://api.github.com/repos/tinganho/TypeScript/releases{/id}","created_at":"2015-02-26T17:12:03Z","updated_at":"2015-05-05T06:48:45Z","pushed_at":"2015-05-25T15:09:59Z","git_url":"git://github.com/tinganho/TypeScript.git","ssh_url":"git@github.com:tinganho/TypeScript.git","clone_url":"https://github.com/tinganho/TypeScript.git","svn_url":"https://github.com/tinganho/TypeScript","homepage":"http://www.typescriptlang.org","size":153948,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"cc078653be56d38d84ffd4010e2d208eb3596ba0","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":20929025,"name":"TypeScript","full_name":"Microsoft/TypeScript","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/TypeScript","description":"TypeScript is a superset of JavaScript that compiles to clean JavaScript output.","fork":false,"url":"https://api.github.com/repos/Microsoft/TypeScript","forks_url":"https://api.github.com/repos/Microsoft/TypeScript/forks","keys_url":"https://api.github.com/repos/Microsoft/TypeScript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/TypeScript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/TypeScript/teams","hooks_url":"https://api.github.com/repos/Microsoft/TypeScript/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/TypeScript/events","assignees_url":"https://api.github.com/repos/Microsoft/TypeScript/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/TypeScript/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/TypeScript/tags","blobs_url":"https://api.github.com/repos/Microsoft/TypeScript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/TypeScript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/TypeScript/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/TypeScript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/TypeScript/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/TypeScript/languages","stargazers_url":"https://api.github.com/repos/Microsoft/TypeScript/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/TypeScript/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/TypeScript/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/TypeScript/subscription","commits_url":"https://api.github.com/repos/Microsoft/TypeScript/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/TypeScript/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/TypeScript/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/TypeScript/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/TypeScript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/TypeScript/merges","archive_url":"https://api.github.com/repos/Microsoft/TypeScript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/TypeScript/downloads","issues_url":"https://api.github.com/repos/Microsoft/TypeScript/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/TypeScript/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/TypeScript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/TypeScript/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/TypeScript/releases{/id}","created_at":"2014-06-17T15:28:39Z","updated_at":"2015-05-26T20:43:40Z","pushed_at":"2015-05-26T20:08:50Z","git_url":"git://github.com/Microsoft/TypeScript.git","ssh_url":"git@github.com:Microsoft/TypeScript.git","clone_url":"https://github.com/Microsoft/TypeScript.git","svn_url":"https://github.com/Microsoft/TypeScript","homepage":"http://www.typescriptlang.org","size":832496,"stargazers_count":5312,"watchers_count":5312,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":563,"mirror_url":null,"open_issues_count":635,"forks":563,"open_issues":635,"watchers":5312,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/3262"},"html":{"href":"https://github.com/Microsoft/TypeScript/pull/3262"},"issue":{"href":"https://api.github.com/repos/Microsoft/TypeScript/issues/3262"},"comments":{"href":"https://api.github.com/repos/Microsoft/TypeScript/issues/3262/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/3262/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/3262/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/TypeScript/statuses/4a6e85b11c55b31d13c6e6e90f558a0abeb24128"}}}}