{"push_id":834344910,"size":1,"distinct_size":1,"ref":"refs/heads/fix-profile-prec","head":"160c4473aa68e735ee22482eaab10715d30c6446","before":"2d010e21521c909aa72ee93cea661cebeeb70bae","commits":[{"sha":"160c4473aa68e735ee22482eaab10715d30c6446","author":{"email":"93f8bb0eb2c659b85694486c41717eaf0fe23cd4@jamesls.com","name":"James Saryerwinnie"},"message":"Profile should override env var creds\n\nUnless the profile and creds are both specified\nas env vars.\n\nIn order to fix this regression, I had to make a\nsmall change to session.  This makes the 'profile'\nconfig var less special cased than it was previously.\n\nNow, we always check the _session_instance_vars for\na profile, and simple use _profile as a placeholder\nfor the cached lookup value of 'profile'.\n\nThe only place this gets weird is we need to scope\ndown our call to \".get_config_variable\" in the\ncredential provider creation to only check the\nsession instance variables for a profile to determine\nwhether or not we need to add the EnvProvider to our\nlookup chain.\n\nOne of the reasons this regressed is we didn't have\nsufficient functional tests to cover this behavior.\nI've added functional tests that ensure that regardless\nof internals, we won't regress on this in the future.\n\nThere will also be a pull request to the AWS CLI\nto verify this behavior to ensure the CLI doesn't regress\non this behavior.\n\nFixes #663.","distinct":true,"url":"https://api.github.com/repos/jamesls/botocore/commits/160c4473aa68e735ee22482eaab10715d30c6446"}]}