{"action":"created","issue":{"url":"https://api.github.com/repos/akka/akka/issues/19060","labels_url":"https://api.github.com/repos/akka/akka/issues/19060/labels{/name}","comments_url":"https://api.github.com/repos/akka/akka/issues/19060/comments","events_url":"https://api.github.com/repos/akka/akka/issues/19060/events","html_url":"https://github.com/akka/akka/pull/19060","id":119717336,"number":19060,"title":"[WIP] =htc #19050 reusable http blueprint: attribute injected rem-addr","user":{"login":"ktoso","id":120979,"avatar_url":"https://avatars.githubusercontent.com/u/120979?v=3","gravatar_id":"","url":"https://api.github.com/users/ktoso","html_url":"https://github.com/ktoso","followers_url":"https://api.github.com/users/ktoso/followers","following_url":"https://api.github.com/users/ktoso/following{/other_user}","gists_url":"https://api.github.com/users/ktoso/gists{/gist_id}","starred_url":"https://api.github.com/users/ktoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktoso/subscriptions","organizations_url":"https://api.github.com/users/ktoso/orgs","repos_url":"https://api.github.com/users/ktoso/repos","events_url":"https://api.github.com/users/ktoso/events{/privacy}","received_events_url":"https://api.github.com/users/ktoso/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/akka/akka/labels/needs-attention","name":"needs-attention","color":"e10c02"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-12-01T13:31:33Z","updated_at":"2015-12-03T21:43:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/akka/akka/pulls/19060","html_url":"https://github.com/akka/akka/pull/19060","diff_url":"https://github.com/akka/akka/pull/19060.diff","patch_url":"https://github.com/akka/akka/pull/19060.patch"},"body":"Moves the remote address injection to Attributes, which allows that part of the HTTP blueprint to become reusable. Need to decide if/how we expose this stage. May be useful enough to include on FlowOps I think actually.\r\n\r\nAddresses point two of: https://github.com/akka/akka/issues/19050"},"comment":{"url":"https://api.github.com/repos/akka/akka/issues/comments/161793411","html_url":"https://github.com/akka/akka/pull/19060#issuecomment-161793411","issue_url":"https://api.github.com/repos/akka/akka/issues/19060","id":161793411,"user":{"login":"viktorklang","id":10871,"avatar_url":"https://avatars.githubusercontent.com/u/10871?v=3","gravatar_id":"","url":"https://api.github.com/users/viktorklang","html_url":"https://github.com/viktorklang","followers_url":"https://api.github.com/users/viktorklang/followers","following_url":"https://api.github.com/users/viktorklang/following{/other_user}","gists_url":"https://api.github.com/users/viktorklang/gists{/gist_id}","starred_url":"https://api.github.com/users/viktorklang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viktorklang/subscriptions","organizations_url":"https://api.github.com/users/viktorklang/orgs","repos_url":"https://api.github.com/users/viktorklang/repos","events_url":"https://api.github.com/users/viktorklang/events{/privacy}","received_events_url":"https://api.github.com/users/viktorklang/received_events","type":"User","site_admin":false},"created_at":"2015-12-03T21:43:07Z","updated_at":"2015-12-03T21:43:07Z","body":"The \"hack part\", to me, is that it is a *hidden* parameter, which is very\nmuch easy to forget or not know—i.e. how do I know which hidden attributes\napply to X where is is some Graph[_]? It's similar to using ThreadLocals to\npass parameters to methods rather than using method parameters.\n\n> the attributes give inputs for the materialization process, they\nconfigure the materializer and the stages\n\nIf the attributes to not apply to all stages, how do I know which ones\napply at which point, and does my code silently break if my graph subtly\nchanges?\n"}}