{"action":"created","comment":{"url":"https://api.github.com/repos/socrata/soda-fountain/pulls/comments/27930545","id":27930545,"diff_hunk":"@@ -53,10 +54,17 @@ case class Suggest(datasetDao: DatasetDAO, columnDao: ColumnDAO,\n     }\n   }\n \n+  // f(dataset name, copy num, column name, text) => spandex uri to get\n   def go(req: HttpRequest, resp: HttpServletResponse,\n          resourceName: ResourceName, columnName: ColumnName, text: String,\n          f: (String, Long, String, String) => URI): Unit = {\n-    // f(dataset name, copy num, column name, text)\n+    val (ds, cn, col) = internalContext(resp, resourceName, columnName).get","path":"soda-fountain-lib/src/main/scala/com/socrata/soda/server/resources/Suggest.scala","position":42,"original_position":42,"commit_id":"e67d6f81c5f06d5af1965f8abb94e1c9a4f494b0","original_commit_id":"e67d6f81c5f06d5af1965f8abb94e1c9a4f494b0","user":{"login":"urmilan","id":6767006,"avatar_url":"https://avatars.githubusercontent.com/u/6767006?v=3","gravatar_id":"","url":"https://api.github.com/users/urmilan","html_url":"https://github.com/urmilan","followers_url":"https://api.github.com/users/urmilan/followers","following_url":"https://api.github.com/users/urmilan/following{/other_user}","gists_url":"https://api.github.com/users/urmilan/gists{/gist_id}","starred_url":"https://api.github.com/users/urmilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urmilan/subscriptions","organizations_url":"https://api.github.com/users/urmilan/orgs","repos_url":"https://api.github.com/users/urmilan/repos","events_url":"https://api.github.com/users/urmilan/events{/privacy}","received_events_url":"https://api.github.com/users/urmilan/received_events","type":"User","site_admin":false},"body":"The tests only call `internalContext` and not `go`, which is probably overwriting the response code when the `NoSuchElementException` is thrown.","created_at":"2015-04-07T23:16:28Z","updated_at":"2015-04-07T23:16:28Z","html_url":"https://github.com/socrata/soda-fountain/pull/99#discussion_r27930545","pull_request_url":"https://api.github.com/repos/socrata/soda-fountain/pulls/99","_links":{"self":{"href":"https://api.github.com/repos/socrata/soda-fountain/pulls/comments/27930545"},"html":{"href":"https://github.com/socrata/soda-fountain/pull/99#discussion_r27930545"},"pull_request":{"href":"https://api.github.com/repos/socrata/soda-fountain/pulls/99"}}},"pull_request":{"url":"https://api.github.com/repos/socrata/soda-fountain/pulls/99","id":32810325,"html_url":"https://github.com/socrata/soda-fountain/pull/99","diff_url":"https://github.com/socrata/soda-fountain/pull/99.diff","patch_url":"https://github.com/socrata/soda-fountain/pull/99.patch","issue_url":"https://api.github.com/repos/socrata/soda-fountain/issues/99","number":99,"state":"open","locked":false,"title":"Suggest Tests","user":{"login":"sokrahta","id":9438863,"avatar_url":"https://avatars.githubusercontent.com/u/9438863?v=3","gravatar_id":"","url":"https://api.github.com/users/sokrahta","html_url":"https://github.com/sokrahta","followers_url":"https://api.github.com/users/sokrahta/followers","following_url":"https://api.github.com/users/sokrahta/following{/other_user}","gists_url":"https://api.github.com/users/sokrahta/gists{/gist_id}","starred_url":"https://api.github.com/users/sokrahta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sokrahta/subscriptions","organizations_url":"https://api.github.com/users/sokrahta/orgs","repos_url":"https://api.github.com/users/sokrahta/repos","events_url":"https://api.github.com/users/sokrahta/events{/privacy}","received_events_url":"https://api.github.com/users/sokrahta/received_events","type":"User","site_admin":false},"body":"WORK IN PROGRESS - NOT READY FOR MERGE \r\n\r\nfinish test suite for soda-fountain suggest resource\r\n\r\n<!-- Reviewable:start -->\r\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/socrata/soda-fountain/99)\r\n<!-- Reviewable:end -->\r\n","created_at":"2015-04-07T22:02:49Z","updated_at":"2015-04-07T23:16:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4a6a5b7219a713d01be52a90a92dd2040807146","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/socrata/soda-fountain/pulls/99/commits","review_comments_url":"https://api.github.com/repos/socrata/soda-fountain/pulls/99/comments","review_comment_url":"https://api.github.com/repos/socrata/soda-fountain/pulls/comments{/number}","comments_url":"https://api.github.com/repos/socrata/soda-fountain/issues/99/comments","statuses_url":"https://api.github.com/repos/socrata/soda-fountain/statuses/e67d6f81c5f06d5af1965f8abb94e1c9a4f494b0","head":{"label":"socrata:timeout","ref":"timeout","sha":"e67d6f81c5f06d5af1965f8abb94e1c9a4f494b0","user":{"login":"socrata","id":57695,"avatar_url":"https://avatars.githubusercontent.com/u/57695?v=3","gravatar_id":"","url":"https://api.github.com/users/socrata","html_url":"https://github.com/socrata","followers_url":"https://api.github.com/users/socrata/followers","following_url":"https://api.github.com/users/socrata/following{/other_user}","gists_url":"https://api.github.com/users/socrata/gists{/gist_id}","starred_url":"https://api.github.com/users/socrata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socrata/subscriptions","organizations_url":"https://api.github.com/users/socrata/orgs","repos_url":"https://api.github.com/users/socrata/repos","events_url":"https://api.github.com/users/socrata/events{/privacy}","received_events_url":"https://api.github.com/users/socrata/received_events","type":"Organization","site_admin":false},"repo":{"id":9224525,"name":"soda-fountain","full_name":"socrata/soda-fountain","owner":{"login":"socrata","id":57695,"avatar_url":"https://avatars.githubusercontent.com/u/57695?v=3","gravatar_id":"","url":"https://api.github.com/users/socrata","html_url":"https://github.com/socrata","followers_url":"https://api.github.com/users/socrata/followers","following_url":"https://api.github.com/users/socrata/following{/other_user}","gists_url":"https://api.github.com/users/socrata/gists{/gist_id}","starred_url":"https://api.github.com/users/socrata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socrata/subscriptions","organizations_url":"https://api.github.com/users/socrata/orgs","repos_url":"https://api.github.com/users/socrata/repos","events_url":"https://api.github.com/users/socrata/events{/privacy}","received_events_url":"https://api.github.com/users/socrata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/socrata/soda-fountain","description":"Server for the Socrata Open Data API","fork":false,"url":"https://api.github.com/repos/socrata/soda-fountain","forks_url":"https://api.github.com/repos/socrata/soda-fountain/forks","keys_url":"https://api.github.com/repos/socrata/soda-fountain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/socrata/soda-fountain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/socrata/soda-fountain/teams","hooks_url":"https://api.github.com/repos/socrata/soda-fountain/hooks","issue_events_url":"https://api.github.com/repos/socrata/soda-fountain/issues/events{/number}","events_url":"https://api.github.com/repos/socrata/soda-fountain/events","assignees_url":"https://api.github.com/repos/socrata/soda-fountain/assignees{/user}","branches_url":"https://api.github.com/repos/socrata/soda-fountain/branches{/branch}","tags_url":"https://api.github.com/repos/socrata/soda-fountain/tags","blobs_url":"https://api.github.com/repos/socrata/soda-fountain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/socrata/soda-fountain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/socrata/soda-fountain/git/refs{/sha}","trees_url":"https://api.github.com/repos/socrata/soda-fountain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/socrata/soda-fountain/statuses/{sha}","languages_url":"https://api.github.com/repos/socrata/soda-fountain/languages","stargazers_url":"https://api.github.com/repos/socrata/soda-fountain/stargazers","contributors_url":"https://api.github.com/repos/socrata/soda-fountain/contributors","subscribers_url":"https://api.github.com/repos/socrata/soda-fountain/subscribers","subscription_url":"https://api.github.com/repos/socrata/soda-fountain/subscription","commits_url":"https://api.github.com/repos/socrata/soda-fountain/commits{/sha}","git_commits_url":"https://api.github.com/repos/socrata/soda-fountain/git/commits{/sha}","comments_url":"https://api.github.com/repos/socrata/soda-fountain/comments{/number}","issue_comment_url":"https://api.github.com/repos/socrata/soda-fountain/issues/comments{/number}","contents_url":"https://api.github.com/repos/socrata/soda-fountain/contents/{+path}","compare_url":"https://api.github.com/repos/socrata/soda-fountain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/socrata/soda-fountain/merges","archive_url":"https://api.github.com/repos/socrata/soda-fountain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/socrata/soda-fountain/downloads","issues_url":"https://api.github.com/repos/socrata/soda-fountain/issues{/number}","pulls_url":"https://api.github.com/repos/socrata/soda-fountain/pulls{/number}","milestones_url":"https://api.github.com/repos/socrata/soda-fountain/milestones{/number}","notifications_url":"https://api.github.com/repos/socrata/soda-fountain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/socrata/soda-fountain/labels{/name}","releases_url":"https://api.github.com/repos/socrata/soda-fountain/releases{/id}","created_at":"2013-04-04T18:13:02Z","updated_at":"2015-04-07T22:45:08Z","pushed_at":"2015-04-07T22:45:08Z","git_url":"git://github.com/socrata/soda-fountain.git","ssh_url":"git@github.com:socrata/soda-fountain.git","clone_url":"https://github.com/socrata/soda-fountain.git","svn_url":"https://github.com/socrata/soda-fountain","homepage":null,"size":3731,"stargazers_count":8,"watchers_count":8,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":8,"default_branch":"master"}},"base":{"label":"socrata:master","ref":"master","sha":"ffe5aba03513ea9f68a045e101737e1ca39025dc","user":{"login":"socrata","id":57695,"avatar_url":"https://avatars.githubusercontent.com/u/57695?v=3","gravatar_id":"","url":"https://api.github.com/users/socrata","html_url":"https://github.com/socrata","followers_url":"https://api.github.com/users/socrata/followers","following_url":"https://api.github.com/users/socrata/following{/other_user}","gists_url":"https://api.github.com/users/socrata/gists{/gist_id}","starred_url":"https://api.github.com/users/socrata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socrata/subscriptions","organizations_url":"https://api.github.com/users/socrata/orgs","repos_url":"https://api.github.com/users/socrata/repos","events_url":"https://api.github.com/users/socrata/events{/privacy}","received_events_url":"https://api.github.com/users/socrata/received_events","type":"Organization","site_admin":false},"repo":{"id":9224525,"name":"soda-fountain","full_name":"socrata/soda-fountain","owner":{"login":"socrata","id":57695,"avatar_url":"https://avatars.githubusercontent.com/u/57695?v=3","gravatar_id":"","url":"https://api.github.com/users/socrata","html_url":"https://github.com/socrata","followers_url":"https://api.github.com/users/socrata/followers","following_url":"https://api.github.com/users/socrata/following{/other_user}","gists_url":"https://api.github.com/users/socrata/gists{/gist_id}","starred_url":"https://api.github.com/users/socrata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socrata/subscriptions","organizations_url":"https://api.github.com/users/socrata/orgs","repos_url":"https://api.github.com/users/socrata/repos","events_url":"https://api.github.com/users/socrata/events{/privacy}","received_events_url":"https://api.github.com/users/socrata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/socrata/soda-fountain","description":"Server for the Socrata Open Data API","fork":false,"url":"https://api.github.com/repos/socrata/soda-fountain","forks_url":"https://api.github.com/repos/socrata/soda-fountain/forks","keys_url":"https://api.github.com/repos/socrata/soda-fountain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/socrata/soda-fountain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/socrata/soda-fountain/teams","hooks_url":"https://api.github.com/repos/socrata/soda-fountain/hooks","issue_events_url":"https://api.github.com/repos/socrata/soda-fountain/issues/events{/number}","events_url":"https://api.github.com/repos/socrata/soda-fountain/events","assignees_url":"https://api.github.com/repos/socrata/soda-fountain/assignees{/user}","branches_url":"https://api.github.com/repos/socrata/soda-fountain/branches{/branch}","tags_url":"https://api.github.com/repos/socrata/soda-fountain/tags","blobs_url":"https://api.github.com/repos/socrata/soda-fountain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/socrata/soda-fountain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/socrata/soda-fountain/git/refs{/sha}","trees_url":"https://api.github.com/repos/socrata/soda-fountain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/socrata/soda-fountain/statuses/{sha}","languages_url":"https://api.github.com/repos/socrata/soda-fountain/languages","stargazers_url":"https://api.github.com/repos/socrata/soda-fountain/stargazers","contributors_url":"https://api.github.com/repos/socrata/soda-fountain/contributors","subscribers_url":"https://api.github.com/repos/socrata/soda-fountain/subscribers","subscription_url":"https://api.github.com/repos/socrata/soda-fountain/subscription","commits_url":"https://api.github.com/repos/socrata/soda-fountain/commits{/sha}","git_commits_url":"https://api.github.com/repos/socrata/soda-fountain/git/commits{/sha}","comments_url":"https://api.github.com/repos/socrata/soda-fountain/comments{/number}","issue_comment_url":"https://api.github.com/repos/socrata/soda-fountain/issues/comments{/number}","contents_url":"https://api.github.com/repos/socrata/soda-fountain/contents/{+path}","compare_url":"https://api.github.com/repos/socrata/soda-fountain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/socrata/soda-fountain/merges","archive_url":"https://api.github.com/repos/socrata/soda-fountain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/socrata/soda-fountain/downloads","issues_url":"https://api.github.com/repos/socrata/soda-fountain/issues{/number}","pulls_url":"https://api.github.com/repos/socrata/soda-fountain/pulls{/number}","milestones_url":"https://api.github.com/repos/socrata/soda-fountain/milestones{/number}","notifications_url":"https://api.github.com/repos/socrata/soda-fountain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/socrata/soda-fountain/labels{/name}","releases_url":"https://api.github.com/repos/socrata/soda-fountain/releases{/id}","created_at":"2013-04-04T18:13:02Z","updated_at":"2015-04-07T22:45:08Z","pushed_at":"2015-04-07T22:45:08Z","git_url":"git://github.com/socrata/soda-fountain.git","ssh_url":"git@github.com:socrata/soda-fountain.git","clone_url":"https://github.com/socrata/soda-fountain.git","svn_url":"https://github.com/socrata/soda-fountain","homepage":null,"size":3731,"stargazers_count":8,"watchers_count":8,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/socrata/soda-fountain/pulls/99"},"html":{"href":"https://github.com/socrata/soda-fountain/pull/99"},"issue":{"href":"https://api.github.com/repos/socrata/soda-fountain/issues/99"},"comments":{"href":"https://api.github.com/repos/socrata/soda-fountain/issues/99/comments"},"review_comments":{"href":"https://api.github.com/repos/socrata/soda-fountain/pulls/99/comments"},"review_comment":{"href":"https://api.github.com/repos/socrata/soda-fountain/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/socrata/soda-fountain/pulls/99/commits"},"statuses":{"href":"https://api.github.com/repos/socrata/soda-fountain/statuses/e67d6f81c5f06d5af1965f8abb94e1c9a4f494b0"}}}}