{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/342","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/342/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/342/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/342/events","html_url":"https://github.com/cockroachdb/cockroach/pull/342","id":58452561,"number":342,"title":"clean up cockroach-dev Docker build","user":{"login":"tschottdorf","id":5076964,"avatar_url":"https://avatars.githubusercontent.com/u/5076964?v=3","gravatar_id":"","url":"https://api.github.com/users/tschottdorf","html_url":"https://github.com/tschottdorf","followers_url":"https://api.github.com/users/tschottdorf/followers","following_url":"https://api.github.com/users/tschottdorf/following{/other_user}","gists_url":"https://api.github.com/users/tschottdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/tschottdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschottdorf/subscriptions","organizations_url":"https://api.github.com/users/tschottdorf/orgs","repos_url":"https://api.github.com/users/tschottdorf/repos","events_url":"https://api.github.com/users/tschottdorf/events{/privacy}","received_events_url":"https://api.github.com/users/tschottdorf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-02-21T09:43:34Z","updated_at":"2015-02-21T13:01:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/342","html_url":"https://github.com/cockroachdb/cockroach/pull/342","diff_url":"https://github.com/cockroachdb/cockroach/pull/342.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/342.patch"},"body":"- remove the submodule update when building cockroach-dev;\r\n  we're not rebuilding RocksDB anyways, so there's no point\r\n  in changing the sources at this point.\r\n- add some files to .dockerignore which tend to break the cache\r\n  and are not required inside the container\r\n- fix cache-breaking in build-docker-dev.sh (caused by Dockerfile\r\n  templating) - since this is called a bunch of times during tests,\r\n  this should shave a good amount of seconds off those runs\r\n- run `make acceptance` again when deploying through CircleCI,\r\n  using the deploy container."},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/75370621","html_url":"https://github.com/cockroachdb/cockroach/pull/342#issuecomment-75370621","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/342","id":75370621,"user":{"login":"spencerkimball","id":6147149,"avatar_url":"https://avatars.githubusercontent.com/u/6147149?v=3","gravatar_id":"","url":"https://api.github.com/users/spencerkimball","html_url":"https://github.com/spencerkimball","followers_url":"https://api.github.com/users/spencerkimball/followers","following_url":"https://api.github.com/users/spencerkimball/following{/other_user}","gists_url":"https://api.github.com/users/spencerkimball/gists{/gist_id}","starred_url":"https://api.github.com/users/spencerkimball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spencerkimball/subscriptions","organizations_url":"https://api.github.com/users/spencerkimball/orgs","repos_url":"https://api.github.com/users/spencerkimball/repos","events_url":"https://api.github.com/users/spencerkimball/events{/privacy}","received_events_url":"https://api.github.com/users/spencerkimball/received_events","type":"User","site_admin":false},"created_at":"2015-02-21T13:01:59Z","updated_at":"2015-02-21T13:01:59Z","body":"Does this mean we run make acceptance twice?\r\n\r\nLGTM"}}