{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/27075006","id":27075006,"diff_hunk":"@@ -207,4 +208,28 @@ private function addTwigOptions(ArrayNodeDefinition $rootNode)\n             ->end()\n         ;\n     }\n+\n+    private function addTwigFormatOptions(ArrayNodeDefinition $rootNode)\n+    {\n+        $rootNode\n+            ->children()\n+                ->arrayNode('date')\n+                    ->addDefaultsIfNotSet()\n+                    ->children()\n+                        ->scalarNode('format')->defaultNull()->end()\n+                        ->scalarNode('interval_format')->defaultNull()->end()","path":"src/Symfony/Bundle/TwigBundle/DependencyInjection/Configuration.php","position":21,"original_position":21,"commit_id":"58c1ff5c97738dea257dc39abadac0d7c19895a1","original_commit_id":"58c1ff5c97738dea257dc39abadac0d7c19895a1","user":{"login":"xabbuh","id":1957048,"avatar_url":"https://avatars.githubusercontent.com/u/1957048?v=3","gravatar_id":"","url":"https://api.github.com/users/xabbuh","html_url":"https://github.com/xabbuh","followers_url":"https://api.github.com/users/xabbuh/followers","following_url":"https://api.github.com/users/xabbuh/following{/other_user}","gists_url":"https://api.github.com/users/xabbuh/gists{/gist_id}","starred_url":"https://api.github.com/users/xabbuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xabbuh/subscriptions","organizations_url":"https://api.github.com/users/xabbuh/orgs","repos_url":"https://api.github.com/users/xabbuh/repos","events_url":"https://api.github.com/users/xabbuh/events{/privacy}","received_events_url":"https://api.github.com/users/xabbuh/received_events","type":"User","site_admin":false},"body":"Imho using `null` here makes more sense since then the default format is not modified [when calling setDateFormat()](https://github.com/twigphp/Twig/blob/1.x/lib/Twig/Extension/Core.php#L52-54) in the configurator.","created_at":"2015-03-24T21:26:23Z","updated_at":"2015-03-24T21:26:23Z","html_url":"https://github.com/symfony/symfony/pull/13554#discussion_r27075006","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/13554","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/27075006"},"html":{"href":"https://github.com/symfony/symfony/pull/13554#discussion_r27075006"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/13554"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/13554","id":28346569,"html_url":"https://github.com/symfony/symfony/pull/13554","diff_url":"https://github.com/symfony/symfony/pull/13554.diff","patch_url":"https://github.com/symfony/symfony/pull/13554.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/13554","number":13554,"state":"open","locked":false,"title":"[TwigBundle] make date formats and number formats configurable","user":{"login":"xabbuh","id":1957048,"avatar_url":"https://avatars.githubusercontent.com/u/1957048?v=3","gravatar_id":"","url":"https://api.github.com/users/xabbuh","html_url":"https://github.com/xabbuh","followers_url":"https://api.github.com/users/xabbuh/followers","following_url":"https://api.github.com/users/xabbuh/following{/other_user}","gists_url":"https://api.github.com/users/xabbuh/gists{/gist_id}","starred_url":"https://api.github.com/users/xabbuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xabbuh/subscriptions","organizations_url":"https://api.github.com/users/xabbuh/orgs","repos_url":"https://api.github.com/users/xabbuh/repos","events_url":"https://api.github.com/users/xabbuh/events{/privacy}","received_events_url":"https://api.github.com/users/xabbuh/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | #13552\r\n| License       | MIT\r\n| Doc PR        | TODO\r\n\r\nThis adds new Twig configuration options that make it possible to\r\nconfigure the format of both numbers and dates as well as timezones\r\nwithout the need to write custom code.\r\n\r\nFor example, using the new configuration options can look like this:\r\n\r\n```yaml\r\ntwig:\r\n    date:\r\n        format: d.m.Y, H:i:s\r\n        interval_format: %%d days\r\n        timezone: Europe/Berlin\r\n    number_format:\r\n        decimals: 2\r\n        decimal_point: ,\r\n        thousands_separator: .\r\n```","created_at":"2015-01-30T08:59:43Z","updated_at":"2015-03-24T21:26:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab3a13c63309b7c89ee09fc237dbd94ab8cf4946","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/13554/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/13554/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/13554/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/58c1ff5c97738dea257dc39abadac0d7c19895a1","head":{"label":"xabbuh:issue-13552","ref":"issue-13552","sha":"58c1ff5c97738dea257dc39abadac0d7c19895a1","user":{"login":"xabbuh","id":1957048,"avatar_url":"https://avatars.githubusercontent.com/u/1957048?v=3","gravatar_id":"","url":"https://api.github.com/users/xabbuh","html_url":"https://github.com/xabbuh","followers_url":"https://api.github.com/users/xabbuh/followers","following_url":"https://api.github.com/users/xabbuh/following{/other_user}","gists_url":"https://api.github.com/users/xabbuh/gists{/gist_id}","starred_url":"https://api.github.com/users/xabbuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xabbuh/subscriptions","organizations_url":"https://api.github.com/users/xabbuh/orgs","repos_url":"https://api.github.com/users/xabbuh/repos","events_url":"https://api.github.com/users/xabbuh/events{/privacy}","received_events_url":"https://api.github.com/users/xabbuh/received_events","type":"User","site_admin":false},"repo":{"id":9551743,"name":"symfony","full_name":"xabbuh/symfony","owner":{"login":"xabbuh","id":1957048,"avatar_url":"https://avatars.githubusercontent.com/u/1957048?v=3","gravatar_id":"","url":"https://api.github.com/users/xabbuh","html_url":"https://github.com/xabbuh","followers_url":"https://api.github.com/users/xabbuh/followers","following_url":"https://api.github.com/users/xabbuh/following{/other_user}","gists_url":"https://api.github.com/users/xabbuh/gists{/gist_id}","starred_url":"https://api.github.com/users/xabbuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xabbuh/subscriptions","organizations_url":"https://api.github.com/users/xabbuh/orgs","repos_url":"https://api.github.com/users/xabbuh/repos","events_url":"https://api.github.com/users/xabbuh/events{/privacy}","received_events_url":"https://api.github.com/users/xabbuh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xabbuh/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/xabbuh/symfony","forks_url":"https://api.github.com/repos/xabbuh/symfony/forks","keys_url":"https://api.github.com/repos/xabbuh/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xabbuh/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xabbuh/symfony/teams","hooks_url":"https://api.github.com/repos/xabbuh/symfony/hooks","issue_events_url":"https://api.github.com/repos/xabbuh/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/xabbuh/symfony/events","assignees_url":"https://api.github.com/repos/xabbuh/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/xabbuh/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/xabbuh/symfony/tags","blobs_url":"https://api.github.com/repos/xabbuh/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xabbuh/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xabbuh/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/xabbuh/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xabbuh/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/xabbuh/symfony/languages","stargazers_url":"https://api.github.com/repos/xabbuh/symfony/stargazers","contributors_url":"https://api.github.com/repos/xabbuh/symfony/contributors","subscribers_url":"https://api.github.com/repos/xabbuh/symfony/subscribers","subscription_url":"https://api.github.com/repos/xabbuh/symfony/subscription","commits_url":"https://api.github.com/repos/xabbuh/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/xabbuh/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/xabbuh/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/xabbuh/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/xabbuh/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/xabbuh/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xabbuh/symfony/merges","archive_url":"https://api.github.com/repos/xabbuh/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xabbuh/symfony/downloads","issues_url":"https://api.github.com/repos/xabbuh/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/xabbuh/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/xabbuh/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/xabbuh/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xabbuh/symfony/labels{/name}","releases_url":"https://api.github.com/repos/xabbuh/symfony/releases{/id}","created_at":"2013-04-19T18:23:15Z","updated_at":"2014-07-05T08:26:55Z","pushed_at":"2015-03-24T18:21:20Z","git_url":"git://github.com/xabbuh/symfony.git","ssh_url":"git@github.com:xabbuh/symfony.git","clone_url":"https://github.com/xabbuh/symfony.git","svn_url":"https://github.com/xabbuh/symfony","homepage":"symfony.com","size":51907,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:2.7","ref":"2.7","sha":"e25b751eb005de9b3e89e810b32775ae81800218","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","created_at":"2010-01-04T14:21:21Z","updated_at":"2015-03-24T17:40:47Z","pushed_at":"2015-03-24T20:39:56Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":209145,"stargazers_count":9875,"watchers_count":9875,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":3865,"mirror_url":null,"open_issues_count":770,"forks":3865,"open_issues":770,"watchers":9875,"default_branch":"2.7"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/13554"},"html":{"href":"https://github.com/symfony/symfony/pull/13554"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/13554"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/13554/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/13554/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/13554/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/58c1ff5c97738dea257dc39abadac0d7c19895a1"}}}}