{"action":"created","comment":{"url":"https://api.github.com/repos/nupic-community/comportex/pulls/comments/38168143","id":38168143,"diff_hunk":"@@ -9,18 +9,18 @@\n \n \n (deftest encode-decode-test\n-  (let [e (enc/category-encoder 10 [:a :b :c])]\n-    (is (= :a (:value (first (p/decode e (frequencies (p/encode e :a)) 1)))))\n+  (let [e (enc/category-encoder [10] [:a :b :c])]\n+    (is (= :a (:value (first (p/dcode e (frequencies (p/encode e :a)) 1)))))","path":"test/org/nfrac/comportex/encoders_test.cljc","position":7,"original_position":7,"commit_id":"18c493d58e176f670aaf1305fe6729cc437fbd1d","original_commit_id":"18c493d58e176f670aaf1305fe6729cc437fbd1d","user":{"login":"mrcslws","id":364113,"avatar_url":"https://avatars.githubusercontent.com/u/364113?v=3","gravatar_id":"","url":"https://api.github.com/users/mrcslws","html_url":"https://github.com/mrcslws","followers_url":"https://api.github.com/users/mrcslws/followers","following_url":"https://api.github.com/users/mrcslws/following{/other_user}","gists_url":"https://api.github.com/users/mrcslws/gists{/gist_id}","starred_url":"https://api.github.com/users/mrcslws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrcslws/subscriptions","organizations_url":"https://api.github.com/users/mrcslws/orgs","repos_url":"https://api.github.com/users/mrcslws/repos","events_url":"https://api.github.com/users/mrcslws/events{/privacy}","received_events_url":"https://api.github.com/users/mrcslws/received_events","type":"User","site_admin":false},"body":"Typo: \"dcode\"","created_at":"2015-08-28T03:07:12Z","updated_at":"2015-08-28T03:07:12Z","html_url":"https://github.com/nupic-community/comportex/pull/27#discussion_r38168143","pull_request_url":"https://api.github.com/repos/nupic-community/comportex/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/nupic-community/comportex/pulls/comments/38168143"},"html":{"href":"https://github.com/nupic-community/comportex/pull/27#discussion_r38168143"},"pull_request":{"href":"https://api.github.com/repos/nupic-community/comportex/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/nupic-community/comportex/pulls/27","id":43520022,"html_url":"https://github.com/nupic-community/comportex/pull/27","diff_url":"https://github.com/nupic-community/comportex/pull/27.diff","patch_url":"https://github.com/nupic-community/comportex/pull/27.patch","issue_url":"https://api.github.com/repos/nupic-community/comportex/issues/27","number":27,"state":"open","locked":false,"title":"decompose encoders into serializable sensors","user":{"login":"floybix","id":181807,"avatar_url":"https://avatars.githubusercontent.com/u/181807?v=3","gravatar_id":"","url":"https://api.github.com/users/floybix","html_url":"https://github.com/floybix","followers_url":"https://api.github.com/users/floybix/followers","following_url":"https://api.github.com/users/floybix/following{/other_user}","gists_url":"https://api.github.com/users/floybix/gists{/gist_id}","starred_url":"https://api.github.com/users/floybix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floybix/subscriptions","organizations_url":"https://api.github.com/users/floybix/orgs","repos_url":"https://api.github.com/users/floybix/repos","events_url":"https://api.github.com/users/floybix/events{/privacy}","received_events_url":"https://api.github.com/users/floybix/received_events","type":"User","site_admin":false},"body":"Fixes #19 \r\n\r\nSensors are defined as `[selector encoder]`. Both selectors and encoders are serializable; so HTM models should now be fully serializable.\r\n\r\nThis requires changes to all user code to define sensors. The argument list of `regions-in-series` has changed.\r\n\r\nIs it too confusing to have \"sensors\" as well as \"senses\" (the stateful output of sensors)?\r\n\r\nWhat about htm-export ... thinking we might need a general export protocol to clear out any caches (e.g. encoder caches) and compress the model - e.g. removing the reverse index in SynapseGraphs which can be rebuilt (\"import\" protocol?)...","created_at":"2015-08-27T13:57:40Z","updated_at":"2015-08-28T03:07:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"555856884e00cb2199c3ecd867d2de5f644d1750","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nupic-community/comportex/pulls/27/commits","review_comments_url":"https://api.github.com/repos/nupic-community/comportex/pulls/27/comments","review_comment_url":"https://api.github.com/repos/nupic-community/comportex/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nupic-community/comportex/issues/27/comments","statuses_url":"https://api.github.com/repos/nupic-community/comportex/statuses/18c493d58e176f670aaf1305fe6729cc437fbd1d","head":{"label":"floybix:encoders-redesign","ref":"encoders-redesign","sha":"18c493d58e176f670aaf1305fe6729cc437fbd1d","user":{"login":"floybix","id":181807,"avatar_url":"https://avatars.githubusercontent.com/u/181807?v=3","gravatar_id":"","url":"https://api.github.com/users/floybix","html_url":"https://github.com/floybix","followers_url":"https://api.github.com/users/floybix/followers","following_url":"https://api.github.com/users/floybix/following{/other_user}","gists_url":"https://api.github.com/users/floybix/gists{/gist_id}","starred_url":"https://api.github.com/users/floybix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floybix/subscriptions","organizations_url":"https://api.github.com/users/floybix/orgs","repos_url":"https://api.github.com/users/floybix/repos","events_url":"https://api.github.com/users/floybix/events{/privacy}","received_events_url":"https://api.github.com/users/floybix/received_events","type":"User","site_admin":false},"repo":{"id":41309283,"name":"comportex","full_name":"floybix/comportex","owner":{"login":"floybix","id":181807,"avatar_url":"https://avatars.githubusercontent.com/u/181807?v=3","gravatar_id":"","url":"https://api.github.com/users/floybix","html_url":"https://github.com/floybix","followers_url":"https://api.github.com/users/floybix/followers","following_url":"https://api.github.com/users/floybix/following{/other_user}","gists_url":"https://api.github.com/users/floybix/gists{/gist_id}","starred_url":"https://api.github.com/users/floybix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floybix/subscriptions","organizations_url":"https://api.github.com/users/floybix/orgs","repos_url":"https://api.github.com/users/floybix/repos","events_url":"https://api.github.com/users/floybix/events{/privacy}","received_events_url":"https://api.github.com/users/floybix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/floybix/comportex","description":"Functionally composable cortex, an implementation of Hierarchical Temporal Memory","fork":true,"url":"https://api.github.com/repos/floybix/comportex","forks_url":"https://api.github.com/repos/floybix/comportex/forks","keys_url":"https://api.github.com/repos/floybix/comportex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/floybix/comportex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/floybix/comportex/teams","hooks_url":"https://api.github.com/repos/floybix/comportex/hooks","issue_events_url":"https://api.github.com/repos/floybix/comportex/issues/events{/number}","events_url":"https://api.github.com/repos/floybix/comportex/events","assignees_url":"https://api.github.com/repos/floybix/comportex/assignees{/user}","branches_url":"https://api.github.com/repos/floybix/comportex/branches{/branch}","tags_url":"https://api.github.com/repos/floybix/comportex/tags","blobs_url":"https://api.github.com/repos/floybix/comportex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/floybix/comportex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/floybix/comportex/git/refs{/sha}","trees_url":"https://api.github.com/repos/floybix/comportex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/floybix/comportex/statuses/{sha}","languages_url":"https://api.github.com/repos/floybix/comportex/languages","stargazers_url":"https://api.github.com/repos/floybix/comportex/stargazers","contributors_url":"https://api.github.com/repos/floybix/comportex/contributors","subscribers_url":"https://api.github.com/repos/floybix/comportex/subscribers","subscription_url":"https://api.github.com/repos/floybix/comportex/subscription","commits_url":"https://api.github.com/repos/floybix/comportex/commits{/sha}","git_commits_url":"https://api.github.com/repos/floybix/comportex/git/commits{/sha}","comments_url":"https://api.github.com/repos/floybix/comportex/comments{/number}","issue_comment_url":"https://api.github.com/repos/floybix/comportex/issues/comments{/number}","contents_url":"https://api.github.com/repos/floybix/comportex/contents/{+path}","compare_url":"https://api.github.com/repos/floybix/comportex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/floybix/comportex/merges","archive_url":"https://api.github.com/repos/floybix/comportex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/floybix/comportex/downloads","issues_url":"https://api.github.com/repos/floybix/comportex/issues{/number}","pulls_url":"https://api.github.com/repos/floybix/comportex/pulls{/number}","milestones_url":"https://api.github.com/repos/floybix/comportex/milestones{/number}","notifications_url":"https://api.github.com/repos/floybix/comportex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/floybix/comportex/labels{/name}","releases_url":"https://api.github.com/repos/floybix/comportex/releases{/id}","created_at":"2015-08-24T14:54:44Z","updated_at":"2015-08-24T14:54:44Z","pushed_at":"2015-08-27T13:51:10Z","git_url":"git://github.com/floybix/comportex.git","ssh_url":"git@github.com:floybix/comportex.git","clone_url":"https://github.com/floybix/comportex.git","svn_url":"https://github.com/floybix/comportex","homepage":null,"size":995,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nupic-community:master","ref":"master","sha":"ee240268bdc4270bd880535fd889d2afe79076c6","user":{"login":"nupic-community","id":8866221,"avatar_url":"https://avatars.githubusercontent.com/u/8866221?v=3","gravatar_id":"","url":"https://api.github.com/users/nupic-community","html_url":"https://github.com/nupic-community","followers_url":"https://api.github.com/users/nupic-community/followers","following_url":"https://api.github.com/users/nupic-community/following{/other_user}","gists_url":"https://api.github.com/users/nupic-community/gists{/gist_id}","starred_url":"https://api.github.com/users/nupic-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nupic-community/subscriptions","organizations_url":"https://api.github.com/users/nupic-community/orgs","repos_url":"https://api.github.com/users/nupic-community/repos","events_url":"https://api.github.com/users/nupic-community/events{/privacy}","received_events_url":"https://api.github.com/users/nupic-community/received_events","type":"Organization","site_admin":false},"repo":{"id":18231782,"name":"comportex","full_name":"nupic-community/comportex","owner":{"login":"nupic-community","id":8866221,"avatar_url":"https://avatars.githubusercontent.com/u/8866221?v=3","gravatar_id":"","url":"https://api.github.com/users/nupic-community","html_url":"https://github.com/nupic-community","followers_url":"https://api.github.com/users/nupic-community/followers","following_url":"https://api.github.com/users/nupic-community/following{/other_user}","gists_url":"https://api.github.com/users/nupic-community/gists{/gist_id}","starred_url":"https://api.github.com/users/nupic-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nupic-community/subscriptions","organizations_url":"https://api.github.com/users/nupic-community/orgs","repos_url":"https://api.github.com/users/nupic-community/repos","events_url":"https://api.github.com/users/nupic-community/events{/privacy}","received_events_url":"https://api.github.com/users/nupic-community/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nupic-community/comportex","description":"Functionally composable cortex, an implementation of Hierarchical Temporal Memory","fork":false,"url":"https://api.github.com/repos/nupic-community/comportex","forks_url":"https://api.github.com/repos/nupic-community/comportex/forks","keys_url":"https://api.github.com/repos/nupic-community/comportex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nupic-community/comportex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nupic-community/comportex/teams","hooks_url":"https://api.github.com/repos/nupic-community/comportex/hooks","issue_events_url":"https://api.github.com/repos/nupic-community/comportex/issues/events{/number}","events_url":"https://api.github.com/repos/nupic-community/comportex/events","assignees_url":"https://api.github.com/repos/nupic-community/comportex/assignees{/user}","branches_url":"https://api.github.com/repos/nupic-community/comportex/branches{/branch}","tags_url":"https://api.github.com/repos/nupic-community/comportex/tags","blobs_url":"https://api.github.com/repos/nupic-community/comportex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nupic-community/comportex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nupic-community/comportex/git/refs{/sha}","trees_url":"https://api.github.com/repos/nupic-community/comportex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nupic-community/comportex/statuses/{sha}","languages_url":"https://api.github.com/repos/nupic-community/comportex/languages","stargazers_url":"https://api.github.com/repos/nupic-community/comportex/stargazers","contributors_url":"https://api.github.com/repos/nupic-community/comportex/contributors","subscribers_url":"https://api.github.com/repos/nupic-community/comportex/subscribers","subscription_url":"https://api.github.com/repos/nupic-community/comportex/subscription","commits_url":"https://api.github.com/repos/nupic-community/comportex/commits{/sha}","git_commits_url":"https://api.github.com/repos/nupic-community/comportex/git/commits{/sha}","comments_url":"https://api.github.com/repos/nupic-community/comportex/comments{/number}","issue_comment_url":"https://api.github.com/repos/nupic-community/comportex/issues/comments{/number}","contents_url":"https://api.github.com/repos/nupic-community/comportex/contents/{+path}","compare_url":"https://api.github.com/repos/nupic-community/comportex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nupic-community/comportex/merges","archive_url":"https://api.github.com/repos/nupic-community/comportex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nupic-community/comportex/downloads","issues_url":"https://api.github.com/repos/nupic-community/comportex/issues{/number}","pulls_url":"https://api.github.com/repos/nupic-community/comportex/pulls{/number}","milestones_url":"https://api.github.com/repos/nupic-community/comportex/milestones{/number}","notifications_url":"https://api.github.com/repos/nupic-community/comportex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nupic-community/comportex/labels{/name}","releases_url":"https://api.github.com/repos/nupic-community/comportex/releases{/id}","created_at":"2014-03-29T01:39:05Z","updated_at":"2015-08-15T19:17:45Z","pushed_at":"2015-08-27T13:57:40Z","git_url":"git://github.com/nupic-community/comportex.git","ssh_url":"git@github.com:nupic-community/comportex.git","clone_url":"https://github.com/nupic-community/comportex.git","svn_url":"https://github.com/nupic-community/comportex","homepage":null,"size":1678,"stargazers_count":61,"watchers_count":61,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"open_issues_count":10,"forks":10,"open_issues":10,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nupic-community/comportex/pulls/27"},"html":{"href":"https://github.com/nupic-community/comportex/pull/27"},"issue":{"href":"https://api.github.com/repos/nupic-community/comportex/issues/27"},"comments":{"href":"https://api.github.com/repos/nupic-community/comportex/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/nupic-community/comportex/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/nupic-community/comportex/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nupic-community/comportex/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/nupic-community/comportex/statuses/18c493d58e176f670aaf1305fe6729cc437fbd1d"}}}}