{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/pulls/comments/36204408","id":36204408,"diff_hunk":"@@ -10,6 +10,10 @@ maxCacheEntries = 2000000\n mruSymbolStateFile = /tmp/snappy-mru-symbols.json\n maxMRUSymbolsPersist = 10\n \n+[DiskCache]\n+cachePath = /tmp/snappy/cache\n+maxCacheFiles = 50","path":"sample-linux.ini","position":6,"original_position":6,"commit_id":"ac8e6324ddf1ea452b077f5eaa8675fcdad4f64c","original_commit_id":"ac8e6324ddf1ea452b077f5eaa8675fcdad4f64c","user":{"login":"vdjeric","id":1521786,"avatar_url":"https://avatars.githubusercontent.com/u/1521786?v=3","gravatar_id":"","url":"https://api.github.com/users/vdjeric","html_url":"https://github.com/vdjeric","followers_url":"https://api.github.com/users/vdjeric/followers","following_url":"https://api.github.com/users/vdjeric/following{/other_user}","gists_url":"https://api.github.com/users/vdjeric/gists{/gist_id}","starred_url":"https://api.github.com/users/vdjeric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdjeric/subscriptions","organizations_url":"https://api.github.com/users/vdjeric/orgs","repos_url":"https://api.github.com/users/vdjeric/repos","events_url":"https://api.github.com/users/vdjeric/events{/privacy}","received_events_url":"https://api.github.com/users/vdjeric/received_events","type":"User","site_admin":false},"body":"do you mean the raw .sym files are 15MB? How big are XULs after only the relevant lines are pickled?","created_at":"2015-08-04T15:48:15Z","updated_at":"2015-08-04T15:48:15Z","html_url":"https://github.com/mozilla/Snappy-Symbolication-Server/pull/9#discussion_r36204408","pull_request_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/pulls/comments/36204408"},"html":{"href":"https://github.com/mozilla/Snappy-Symbolication-Server/pull/9#discussion_r36204408"},"pull_request":{"href":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/pulls/9","id":40808431,"html_url":"https://github.com/mozilla/Snappy-Symbolication-Server/pull/9","diff_url":"https://github.com/mozilla/Snappy-Symbolication-Server/pull/9.diff","patch_url":"https://github.com/mozilla/Snappy-Symbolication-Server/pull/9.patch","issue_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/issues/9","number":9,"state":"open","locked":false,"title":"Implement on disk symbol file cache.","user":{"login":"walac","id":611309,"avatar_url":"https://avatars.githubusercontent.com/u/611309?v=3","gravatar_id":"","url":"https://api.github.com/users/walac","html_url":"https://github.com/walac","followers_url":"https://api.github.com/users/walac/followers","following_url":"https://api.github.com/users/walac/following{/other_user}","gists_url":"https://api.github.com/users/walac/gists{/gist_id}","starred_url":"https://api.github.com/users/walac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walac/subscriptions","organizations_url":"https://api.github.com/users/walac/orgs","repos_url":"https://api.github.com/users/walac/repos","events_url":"https://api.github.com/users/walac/events{/privacy}","received_events_url":"https://api.github.com/users/walac/received_events","type":"User","site_admin":false},"body":"Add support for on disk symbol file cache. The cache is done through the pickle module. We maintain a list of the least recently used symbol files. When we reach the quota limit, we start to remove the symbol files until our disk usage fits inside the quota.\r\n\r\nr? @vdjeric ","created_at":"2015-07-24T19:37:56Z","updated_at":"2015-08-04T15:48:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67e7e44349ea763032fbce6f5a77a291e25cad2e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/pulls/9/commits","review_comments_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/pulls/9/comments","review_comment_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/issues/9/comments","statuses_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/statuses/ac8e6324ddf1ea452b077f5eaa8675fcdad4f64c","head":{"label":"walac:master","ref":"master","sha":"ac8e6324ddf1ea452b077f5eaa8675fcdad4f64c","user":{"login":"walac","id":611309,"avatar_url":"https://avatars.githubusercontent.com/u/611309?v=3","gravatar_id":"","url":"https://api.github.com/users/walac","html_url":"https://github.com/walac","followers_url":"https://api.github.com/users/walac/followers","following_url":"https://api.github.com/users/walac/following{/other_user}","gists_url":"https://api.github.com/users/walac/gists{/gist_id}","starred_url":"https://api.github.com/users/walac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walac/subscriptions","organizations_url":"https://api.github.com/users/walac/orgs","repos_url":"https://api.github.com/users/walac/repos","events_url":"https://api.github.com/users/walac/events{/privacy}","received_events_url":"https://api.github.com/users/walac/received_events","type":"User","site_admin":false},"repo":{"id":38648836,"name":"Snappy-Symbolication-Server","full_name":"walac/Snappy-Symbolication-Server","owner":{"login":"walac","id":611309,"avatar_url":"https://avatars.githubusercontent.com/u/611309?v=3","gravatar_id":"","url":"https://api.github.com/users/walac","html_url":"https://github.com/walac","followers_url":"https://api.github.com/users/walac/followers","following_url":"https://api.github.com/users/walac/following{/other_user}","gists_url":"https://api.github.com/users/walac/gists{/gist_id}","starred_url":"https://api.github.com/users/walac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walac/subscriptions","organizations_url":"https://api.github.com/users/walac/orgs","repos_url":"https://api.github.com/users/walac/repos","events_url":"https://api.github.com/users/walac/events{/privacy}","received_events_url":"https://api.github.com/users/walac/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/walac/Snappy-Symbolication-Server","description":"","fork":true,"url":"https://api.github.com/repos/walac/Snappy-Symbolication-Server","forks_url":"https://api.github.com/repos/walac/Snappy-Symbolication-Server/forks","keys_url":"https://api.github.com/repos/walac/Snappy-Symbolication-Server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/walac/Snappy-Symbolication-Server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/walac/Snappy-Symbolication-Server/teams","hooks_url":"https://api.github.com/repos/walac/Snappy-Symbolication-Server/hooks","issue_events_url":"https://api.github.com/repos/walac/Snappy-Symbolication-Server/issues/events{/number}","events_url":"https://api.github.com/repos/walac/Snappy-Symbolication-Server/events","assignees_url":"https://api.github.com/repos/walac/Snappy-Symbolication-Server/assignees{/user}","branches_url":"https://api.github.com/repos/walac/Snappy-Symbolication-Server/branches{/branch}","tags_url":"https://api.github.com/repos/walac/Snappy-Symbolication-Server/tags","blobs_url":"https://api.github.com/repos/walac/Snappy-Symbolication-Server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/walac/Snappy-Symbolication-Server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/walac/Snappy-Symbolication-Server/git/refs{/sha}","trees_url":"https://api.github.com/repos/walac/Snappy-Symbolication-Server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/walac/Snappy-Symbolication-Server/statuses/{sha}","languages_url":"https://api.github.com/repos/walac/Snappy-Symbolication-Server/languages","stargazers_url":"https://api.github.com/repos/walac/Snappy-Symbolication-Server/stargazers","contributors_url":"https://api.github.com/repos/walac/Snappy-Symbolication-Server/contributors","subscribers_url":"https://api.github.com/repos/walac/Snappy-Symbolication-Server/subscribers","subscription_url":"https://api.github.com/repos/walac/Snappy-Symbolication-Server/subscription","commits_url":"https://api.github.com/repos/walac/Snappy-Symbolication-Server/commits{/sha}","git_commits_url":"https://api.github.com/repos/walac/Snappy-Symbolication-Server/git/commits{/sha}","comments_url":"https://api.github.com/repos/walac/Snappy-Symbolication-Server/comments{/number}","issue_comment_url":"https://api.github.com/repos/walac/Snappy-Symbolication-Server/issues/comments{/number}","contents_url":"https://api.github.com/repos/walac/Snappy-Symbolication-Server/contents/{+path}","compare_url":"https://api.github.com/repos/walac/Snappy-Symbolication-Server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/walac/Snappy-Symbolication-Server/merges","archive_url":"https://api.github.com/repos/walac/Snappy-Symbolication-Server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/walac/Snappy-Symbolication-Server/downloads","issues_url":"https://api.github.com/repos/walac/Snappy-Symbolication-Server/issues{/number}","pulls_url":"https://api.github.com/repos/walac/Snappy-Symbolication-Server/pulls{/number}","milestones_url":"https://api.github.com/repos/walac/Snappy-Symbolication-Server/milestones{/number}","notifications_url":"https://api.github.com/repos/walac/Snappy-Symbolication-Server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/walac/Snappy-Symbolication-Server/labels{/name}","releases_url":"https://api.github.com/repos/walac/Snappy-Symbolication-Server/releases{/id}","created_at":"2015-07-06T22:03:59Z","updated_at":"2015-07-06T22:04:00Z","pushed_at":"2015-07-29T17:40:56Z","git_url":"git://github.com/walac/Snappy-Symbolication-Server.git","ssh_url":"git@github.com:walac/Snappy-Symbolication-Server.git","clone_url":"https://github.com/walac/Snappy-Symbolication-Server.git","svn_url":"https://github.com/walac/Snappy-Symbolication-Server","homepage":"https://wiki.mozilla.org/Snappy_Symbolication_Server","size":245,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"841544ebef5167f1eebe266491d5c59185f1f875","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":30043650,"name":"Snappy-Symbolication-Server","full_name":"mozilla/Snappy-Symbolication-Server","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/Snappy-Symbolication-Server","description":"","fork":true,"url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server","forks_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/forks","keys_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/teams","hooks_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/hooks","issue_events_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/events","assignees_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/tags","blobs_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/languages","stargazers_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/stargazers","contributors_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/contributors","subscribers_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/subscribers","subscription_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/subscription","commits_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/merges","archive_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/downloads","issues_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/releases{/id}","created_at":"2015-01-29T22:05:44Z","updated_at":"2015-02-26T17:30:31Z","pushed_at":"2015-07-29T17:40:56Z","git_url":"git://github.com/mozilla/Snappy-Symbolication-Server.git","ssh_url":"git@github.com:mozilla/Snappy-Symbolication-Server.git","clone_url":"https://github.com/mozilla/Snappy-Symbolication-Server.git","svn_url":"https://github.com/mozilla/Snappy-Symbolication-Server","homepage":"https://wiki.mozilla.org/Snappy_Symbolication_Server","size":437,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/pulls/9"},"html":{"href":"https://github.com/mozilla/Snappy-Symbolication-Server/pull/9"},"issue":{"href":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/issues/9"},"comments":{"href":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/Snappy-Symbolication-Server/statuses/ac8e6324ddf1ea452b077f5eaa8675fcdad4f64c"}}}}