{"action":"created","issue":{"url":"https://api.github.com/repos/UV-CDAT/uvcmetrics/issues/97","labels_url":"https://api.github.com/repos/UV-CDAT/uvcmetrics/issues/97/labels{/name}","comments_url":"https://api.github.com/repos/UV-CDAT/uvcmetrics/issues/97/comments","events_url":"https://api.github.com/repos/UV-CDAT/uvcmetrics/issues/97/events","html_url":"https://github.com/UV-CDAT/uvcmetrics/issues/97","id":59859465,"number":97,"title":"climos button","user":{"login":"painter1","id":2799665,"avatar_url":"https://avatars.githubusercontent.com/u/2799665?v=3","gravatar_id":"","url":"https://api.github.com/users/painter1","html_url":"https://github.com/painter1","followers_url":"https://api.github.com/users/painter1/followers","following_url":"https://api.github.com/users/painter1/following{/other_user}","gists_url":"https://api.github.com/users/painter1/gists{/gist_id}","starred_url":"https://api.github.com/users/painter1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/painter1/subscriptions","organizations_url":"https://api.github.com/users/painter1/orgs","repos_url":"https://api.github.com/users/painter1/repos","events_url":"https://api.github.com/users/painter1/events{/privacy}","received_events_url":"https://api.github.com/users/painter1/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/UV-CDAT/uvcmetrics/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/UV-CDAT/uvcmetrics/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/UV-CDAT/uvcmetrics/labels/GUI","name":"GUI","color":"bfe5bf"}],"state":"open","locked":false,"assignee":{"login":"isubsmith","id":5223761,"avatar_url":"https://avatars.githubusercontent.com/u/5223761?v=3","gravatar_id":"","url":"https://api.github.com/users/isubsmith","html_url":"https://github.com/isubsmith","followers_url":"https://api.github.com/users/isubsmith/followers","following_url":"https://api.github.com/users/isubsmith/following{/other_user}","gists_url":"https://api.github.com/users/isubsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/isubsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isubsmith/subscriptions","organizations_url":"https://api.github.com/users/isubsmith/orgs","repos_url":"https://api.github.com/users/isubsmith/repos","events_url":"https://api.github.com/users/isubsmith/events{/privacy}","received_events_url":"https://api.github.com/users/isubsmith/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-03-04T20:49:06Z","updated_at":"2015-03-05T13:53:59Z","closed_at":null,"body":"The new \"climos\" button needs some more work, as I would expect of any new feature, especially when added in a hurry.\r\n\r\nMost important, it doesn't work well under this normal usage pattern:\r\n1. Click on \"Set Path\"\r\n2. Browse for the model data directory, deciding what to do as you go.  Take note of what files have been chosen.\r\n3. Click on the \"Climos\" button.\r\nThe problem seems to be that clicking on the \"Climos\" button doesn't initiate any action.  Rather, it is seen only when the data directory is chosen.\r\n\r\nFurthermore, if you try to re-select a directory because the \"Climos\" button had been incorrectly checked, then \"untitled\" gets added on to the path, making it incorrect.\r\n\r\nFinally, the button is not needed for atmosphere diagnostics.  So it actually should be invisible or greyed-out in that situation.\r\n\r\nIn future work on this, it may be worth taking advantage of the fact that we can usually automatically detect whether data is climatologies."},"comment":{"url":"https://api.github.com/repos/UV-CDAT/uvcmetrics/issues/comments/77366779","html_url":"https://github.com/UV-CDAT/uvcmetrics/issues/97#issuecomment-77366779","issue_url":"https://api.github.com/repos/UV-CDAT/uvcmetrics/issues/97","id":77366779,"user":{"login":"isubsmith","id":5223761,"avatar_url":"https://avatars.githubusercontent.com/u/5223761?v=3","gravatar_id":"","url":"https://api.github.com/users/isubsmith","html_url":"https://github.com/isubsmith","followers_url":"https://api.github.com/users/isubsmith/followers","following_url":"https://api.github.com/users/isubsmith/following{/other_user}","gists_url":"https://api.github.com/users/isubsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/isubsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isubsmith/subscriptions","organizations_url":"https://api.github.com/users/isubsmith/orgs","repos_url":"https://api.github.com/users/isubsmith/repos","events_url":"https://api.github.com/users/isubsmith/events{/privacy}","received_events_url":"https://api.github.com/users/isubsmith/received_events","type":"User","site_admin":false},"created_at":"2015-03-05T13:53:59Z","updated_at":"2015-03-05T13:53:59Z","body":"All the climos button is doing is toggling the state of the �climos� field for that particular �model� in the Options object. There is one print to tell the state of it when you initially select a dataset (primarily for initial verification) but the DS1/2climosChanged() functions do not print anything. However, I verified the code is there and works as intended when passed to diagnostics calls. Should I add a print to the climosChanged() functions to make it clear that something changed?\n\nI�m not able to recreate the �untitled gets added to the path� part. Can you provide the exact actions that caused that and I�ll investigate.\n\n\n\n\nBrian Smith\nsmithbe@ornl.gov<mailto:smithbe@ornl.gov>\n\n\n\nOn Mar 4, 2015, at 3:49 PM, Jeffrey Painter <notifications@github.com<mailto:notifications@github.com>> wrote:\n\n\nThe new \"climos\" button needs some more work, as I would expect of any new feature, especially when added in a hurry.\n\nMost important, it doesn't work well under this normal usage pattern:\n1. Click on \"Set Path\"\n2. Browse for the model data directory, deciding what to do as you go. Take note of what files have been chosen.\n3. Click on the \"Climos\" button.\nThe problem seems to be that clicking on the \"Climos\" button doesn't initiate any action. Rather, it is seen only when the data directory is chosen.\n\nFurthermore, if you try to re-select a directory because the \"Climos\" button had been incorrectly checked, then \"untitled\" gets added on to the path, making it incorrect.\n\nFinally, the button is not needed for atmosphere diagnostics. So it actually should be invisible or greyed-out in that situation.\n\nIn future work on this, it may be worth taking advantage of the fact that we can usually automatically detect whether data is climatologies.\n\n�\nReply to this email directly or view it on GitHub<https://github.com/UV-CDAT/uvcmetrics/issues/97>.\n\n"}}