{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/46125129","id":46125129,"diff_hunk":"@@ -72,17 +40,17 @@ let\n       ${cfg.extraSeatDefaults}\n     '';\n \n-  gtkGreeterConf = writeText \"lightdm-gtk-greeter.conf\"\n-    ''\n-    [greeter]\n-    theme-name = Adwaita\n-    icon-theme-name = Adwaita\n-    background = ${cfg.background}\n-    '';\n-\n in\n {\n+  # Note: the order in which lightdm greeter modules are imported\n+  # here determines the default: later modules (if enable) are\n+  # preferred.","path":"nixos/modules/services/x11/display-managers/lightdm.nix","position":55,"original_position":55,"commit_id":"52c7b27c7270cdc60cc169584892e26d8b018d96","original_commit_id":"52c7b27c7270cdc60cc169584892e26d8b018d96","user":{"login":"ocharles","id":20878,"avatar_url":"https://avatars.githubusercontent.com/u/20878?v=3","gravatar_id":"","url":"https://api.github.com/users/ocharles","html_url":"https://github.com/ocharles","followers_url":"https://api.github.com/users/ocharles/followers","following_url":"https://api.github.com/users/ocharles/following{/other_user}","gists_url":"https://api.github.com/users/ocharles/gists{/gist_id}","starred_url":"https://api.github.com/users/ocharles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocharles/subscriptions","organizations_url":"https://api.github.com/users/ocharles/orgs","repos_url":"https://api.github.com/users/ocharles/repos","events_url":"https://api.github.com/users/ocharles/events{/privacy}","received_events_url":"https://api.github.com/users/ocharles/received_events","type":"User","site_admin":false},"body":"I don't quite understand how this comment applies. If I also had a Qt greeter then I would have to explicitly disable the Gtk greeter in order to use the Qt one, right?","created_at":"2015-11-30T10:06:05Z","updated_at":"2015-11-30T10:06:05Z","html_url":"https://github.com/NixOS/nixpkgs/pull/11336#discussion_r46125129","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/11336","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/46125129"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/11336#discussion_r46125129"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/11336"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/11336","id":52049839,"html_url":"https://github.com/NixOS/nixpkgs/pull/11336","diff_url":"https://github.com/NixOS/nixpkgs/pull/11336.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/11336.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/11336","number":11336,"state":"open","locked":false,"title":"lightdm module: Extract greeter configuration and add theme options","user":{"login":"TimoMeijer","id":1517813,"avatar_url":"https://avatars.githubusercontent.com/u/1517813?v=3","gravatar_id":"","url":"https://api.github.com/users/TimoMeijer","html_url":"https://github.com/TimoMeijer","followers_url":"https://api.github.com/users/TimoMeijer/followers","following_url":"https://api.github.com/users/TimoMeijer/following{/other_user}","gists_url":"https://api.github.com/users/TimoMeijer/gists{/gist_id}","starred_url":"https://api.github.com/users/TimoMeijer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimoMeijer/subscriptions","organizations_url":"https://api.github.com/users/TimoMeijer/orgs","repos_url":"https://api.github.com/users/TimoMeijer/repos","events_url":"https://api.github.com/users/TimoMeijer/events{/privacy}","received_events_url":"https://api.github.com/users/TimoMeijer/received_events","type":"User","site_admin":false},"body":"I've extracted the configuration for the lightdm-gtk-greeter, to potentially allow for future greeters, and making configuring them more structured.\r\n\r\nI've also added options to being able to configure the theme of this greeter, without reimplementing the whole greeter wrapper.\r\n\r\nThis is my first pull request to this repository, so any feedback is welcome.","created_at":"2015-11-28T22:28:32Z","updated_at":"2015-11-30T10:06:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c8d0cc4e45ff79a2d1cf5963947bcd8d191a527","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/11336/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/11336/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/11336/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/52c7b27c7270cdc60cc169584892e26d8b018d96","head":{"label":"TimoMeijer:fix/nixos-modules-lightdm","ref":"fix/nixos-modules-lightdm","sha":"52c7b27c7270cdc60cc169584892e26d8b018d96","user":{"login":"TimoMeijer","id":1517813,"avatar_url":"https://avatars.githubusercontent.com/u/1517813?v=3","gravatar_id":"","url":"https://api.github.com/users/TimoMeijer","html_url":"https://github.com/TimoMeijer","followers_url":"https://api.github.com/users/TimoMeijer/followers","following_url":"https://api.github.com/users/TimoMeijer/following{/other_user}","gists_url":"https://api.github.com/users/TimoMeijer/gists{/gist_id}","starred_url":"https://api.github.com/users/TimoMeijer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimoMeijer/subscriptions","organizations_url":"https://api.github.com/users/TimoMeijer/orgs","repos_url":"https://api.github.com/users/TimoMeijer/repos","events_url":"https://api.github.com/users/TimoMeijer/events{/privacy}","received_events_url":"https://api.github.com/users/TimoMeijer/received_events","type":"User","site_admin":false},"repo":{"id":46172395,"name":"nixpkgs","full_name":"TimoMeijer/nixpkgs","owner":{"login":"TimoMeijer","id":1517813,"avatar_url":"https://avatars.githubusercontent.com/u/1517813?v=3","gravatar_id":"","url":"https://api.github.com/users/TimoMeijer","html_url":"https://github.com/TimoMeijer","followers_url":"https://api.github.com/users/TimoMeijer/followers","following_url":"https://api.github.com/users/TimoMeijer/following{/other_user}","gists_url":"https://api.github.com/users/TimoMeijer/gists{/gist_id}","starred_url":"https://api.github.com/users/TimoMeijer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimoMeijer/subscriptions","organizations_url":"https://api.github.com/users/TimoMeijer/orgs","repos_url":"https://api.github.com/users/TimoMeijer/repos","events_url":"https://api.github.com/users/TimoMeijer/events{/privacy}","received_events_url":"https://api.github.com/users/TimoMeijer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TimoMeijer/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/TimoMeijer/nixpkgs","forks_url":"https://api.github.com/repos/TimoMeijer/nixpkgs/forks","keys_url":"https://api.github.com/repos/TimoMeijer/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TimoMeijer/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TimoMeijer/nixpkgs/teams","hooks_url":"https://api.github.com/repos/TimoMeijer/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/TimoMeijer/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/TimoMeijer/nixpkgs/events","assignees_url":"https://api.github.com/repos/TimoMeijer/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/TimoMeijer/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/TimoMeijer/nixpkgs/tags","blobs_url":"https://api.github.com/repos/TimoMeijer/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TimoMeijer/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TimoMeijer/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/TimoMeijer/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TimoMeijer/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/TimoMeijer/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/TimoMeijer/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/TimoMeijer/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/TimoMeijer/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/TimoMeijer/nixpkgs/subscription","commits_url":"https://api.github.com/repos/TimoMeijer/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/TimoMeijer/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/TimoMeijer/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/TimoMeijer/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/TimoMeijer/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/TimoMeijer/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TimoMeijer/nixpkgs/merges","archive_url":"https://api.github.com/repos/TimoMeijer/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TimoMeijer/nixpkgs/downloads","issues_url":"https://api.github.com/repos/TimoMeijer/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/TimoMeijer/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/TimoMeijer/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/TimoMeijer/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TimoMeijer/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/TimoMeijer/nixpkgs/releases{/id}","created_at":"2015-11-14T11:39:50Z","updated_at":"2015-11-14T11:40:43Z","pushed_at":"2015-11-28T14:13:57Z","git_url":"git://github.com/TimoMeijer/nixpkgs.git","ssh_url":"git@github.com:TimoMeijer/nixpkgs.git","clone_url":"https://github.com/TimoMeijer/nixpkgs.git","svn_url":"https://github.com/TimoMeijer/nixpkgs","homepage":null,"size":267673,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"fcc876c3f5c54f5e4207bcc9319f4772b21206a8","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","created_at":"2012-06-04T02:49:46Z","updated_at":"2015-11-30T08:38:47Z","pushed_at":"2015-11-30T09:53:14Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":302057,"stargazers_count":851,"watchers_count":851,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1139,"mirror_url":null,"open_issues_count":1084,"forks":1139,"open_issues":1084,"watchers":851,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/11336"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/11336"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/11336"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/11336/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/11336/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/11336/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/52c7b27c7270cdc60cc169584892e26d8b018d96"}}}}