{"action":"created","issue":{"url":"https://api.github.com/repos/pesco/dnp3/issues/12","labels_url":"https://api.github.com/repos/pesco/dnp3/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/pesco/dnp3/issues/12/comments","events_url":"https://api.github.com/repos/pesco/dnp3/issues/12/events","html_url":"https://github.com/pesco/dnp3/issues/12","id":120479465,"number":12,"title":"DNP3_Callbacks.app_invalid always seems to return error code  == 0","user":{"login":"jadamcrain","id":305813,"avatar_url":"https://avatars.githubusercontent.com/u/305813?v=3","gravatar_id":"","url":"https://api.github.com/users/jadamcrain","html_url":"https://github.com/jadamcrain","followers_url":"https://api.github.com/users/jadamcrain/followers","following_url":"https://api.github.com/users/jadamcrain/following{/other_user}","gists_url":"https://api.github.com/users/jadamcrain/gists{/gist_id}","starred_url":"https://api.github.com/users/jadamcrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jadamcrain/subscriptions","organizations_url":"https://api.github.com/users/jadamcrain/orgs","repos_url":"https://api.github.com/users/jadamcrain/repos","events_url":"https://api.github.com/users/jadamcrain/events{/privacy}","received_events_url":"https://api.github.com/users/jadamcrain/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"pesco","id":136234,"avatar_url":"https://avatars.githubusercontent.com/u/136234?v=3","gravatar_id":"","url":"https://api.github.com/users/pesco","html_url":"https://github.com/pesco","followers_url":"https://api.github.com/users/pesco/followers","following_url":"https://api.github.com/users/pesco/following{/other_user}","gists_url":"https://api.github.com/users/pesco/gists{/gist_id}","starred_url":"https://api.github.com/users/pesco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pesco/subscriptions","organizations_url":"https://api.github.com/users/pesco/orgs","repos_url":"https://api.github.com/users/pesco/repos","events_url":"https://api.github.com/users/pesco/events{/privacy}","received_events_url":"https://api.github.com/users/pesco/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2015-12-04T20:25:59Z","updated_at":"2015-12-09T16:26:59Z","closed_at":"2015-12-09T16:26:59Z","body":"transport data of \"C0 C0 FF\" I would expect to return FUNC_NOT_SUPPORTED, but I always seem to get zero regardless of the application layer violation.\r\n\r\nexample log from proxy:\r\n\r\n```\r\n2015-12-04 12:20:13,566 INFO  [default] Connected to 127.0.0.1:20001\r\n2015-12-04 12:20:13,566 INFO  [default]  <-s- primary frame from master 1 to 10: UNCONFIRMED_USER_DATA: C0 C0 FF\r\n2015-12-04 12:20:13,566 ERROR [default] DNP3 parser error: 0 (Unknown parse error)\r\n2015-12-04 12:20:13,566 INFO  [default] session terminated b/c: parser plugin actively rejected input\r\n```"},"comment":{"url":"https://api.github.com/repos/pesco/dnp3/issues/comments/163314518","html_url":"https://github.com/pesco/dnp3/issues/12#issuecomment-163314518","issue_url":"https://api.github.com/repos/pesco/dnp3/issues/12","id":163314518,"user":{"login":"pesco","id":136234,"avatar_url":"https://avatars.githubusercontent.com/u/136234?v=3","gravatar_id":"","url":"https://api.github.com/users/pesco","html_url":"https://github.com/pesco","followers_url":"https://api.github.com/users/pesco/followers","following_url":"https://api.github.com/users/pesco/following{/other_user}","gists_url":"https://api.github.com/users/pesco/gists{/gist_id}","starred_url":"https://api.github.com/users/pesco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pesco/subscriptions","organizations_url":"https://api.github.com/users/pesco/orgs","repos_url":"https://api.github.com/users/pesco/repos","events_url":"https://api.github.com/users/pesco/events{/privacy}","received_events_url":"https://api.github.com/users/pesco/received_events","type":"User","site_admin":false},"created_at":"2015-12-09T16:26:59Z","updated_at":"2015-12-09T16:26:59Z","body":"Good catch, this is a bug that only affects the combined `dnp3_p_fragment` parser that is used by the dissector. It fails to combine error results from its constituents `dnp3_p_request` and `dnp3_p_response` correctly.\r\n\r\nI really want that error handling out of the parser...\r\n\r\n8ddf614"}}