{"action":"created","comment":{"url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/pulls/comments/46717259","id":46717259,"diff_hunk":"@@ -386,6 +380,18 @@ public bool IsValidValue(Schema schema, GraphType type, object input)\n \n             if (type is ObjectGraphType || type is InputObjectGraphType)\n             {\n+                if (input is KeyValuePair<string, object>)","path":"src/GraphQL/Execution/DocumentExecuter.cs","position":51,"original_position":51,"commit_id":"4e57f2193a85507081ce454b16e25aa91a1c5bc6","original_commit_id":"4e57f2193a85507081ce454b16e25aa91a1c5bc6","user":{"login":"tlil87","id":5948145,"avatar_url":"https://avatars.githubusercontent.com/u/5948145?v=3","gravatar_id":"","url":"https://api.github.com/users/tlil87","html_url":"https://github.com/tlil87","followers_url":"https://api.github.com/users/tlil87/followers","following_url":"https://api.github.com/users/tlil87/following{/other_user}","gists_url":"https://api.github.com/users/tlil87/gists{/gist_id}","starred_url":"https://api.github.com/users/tlil87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlil87/subscriptions","organizations_url":"https://api.github.com/users/tlil87/orgs","repos_url":"https://api.github.com/users/tlil87/repos","events_url":"https://api.github.com/users/tlil87/events{/privacy}","received_events_url":"https://api.github.com/users/tlil87/received_events","type":"User","site_admin":false},"body":"Actually, I moved this out already (and into the input processor), so this is not needed. Will remove.","created_at":"2015-12-04T18:53:58Z","updated_at":"2015-12-04T18:53:58Z","html_url":"https://github.com/graphql-dotnet/graphql-dotnet/pull/32#discussion_r46717259","pull_request_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/pulls/32","_links":{"self":{"href":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/pulls/comments/46717259"},"html":{"href":"https://github.com/graphql-dotnet/graphql-dotnet/pull/32#discussion_r46717259"},"pull_request":{"href":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/pulls/32","id":52362064,"html_url":"https://github.com/graphql-dotnet/graphql-dotnet/pull/32","diff_url":"https://github.com/graphql-dotnet/graphql-dotnet/pull/32.diff","patch_url":"https://github.com/graphql-dotnet/graphql-dotnet/pull/32.patch","issue_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/issues/32","number":32,"state":"open","locked":false,"title":"Improved input handling and fixes","user":{"login":"tlil87","id":5948145,"avatar_url":"https://avatars.githubusercontent.com/u/5948145?v=3","gravatar_id":"","url":"https://api.github.com/users/tlil87","html_url":"https://github.com/tlil87","followers_url":"https://api.github.com/users/tlil87/followers","following_url":"https://api.github.com/users/tlil87/following{/other_user}","gists_url":"https://api.github.com/users/tlil87/gists{/gist_id}","starred_url":"https://api.github.com/users/tlil87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlil87/subscriptions","organizations_url":"https://api.github.com/users/tlil87/orgs","repos_url":"https://api.github.com/users/tlil87/repos","events_url":"https://api.github.com/users/tlil87/events{/privacy}","received_events_url":"https://api.github.com/users/tlil87/received_events","type":"User","site_admin":false},"body":"* When reporting on null values for non-null types, we're now referencing the actual field name.\r\n* Resolve variables in arguments / input objects properly.\r\n* Report the type upon failure in `GetVariableValue()`.\r\n* ~~Downgraded Antlr 4 to non-prerelease version (currently, building a NuGet package and using that in prod has not been possible due to the prerelease dependency on Antlr 4 and a strict policy in our prod environment).~~","created_at":"2015-12-02T07:29:01Z","updated_at":"2015-12-04T18:53:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3415327272bbb469b4c79dc907f3e48700dc8a48","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/pulls/32/commits","review_comments_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/pulls/32/comments","review_comment_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/issues/32/comments","statuses_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/statuses/4e57f2193a85507081ce454b16e25aa91a1c5bc6","head":{"label":"hudl:ImprovedInputHandlingAndFixes","ref":"ImprovedInputHandlingAndFixes","sha":"4e57f2193a85507081ce454b16e25aa91a1c5bc6","user":{"login":"hudl","id":123340,"avatar_url":"https://avatars.githubusercontent.com/u/123340?v=3","gravatar_id":"","url":"https://api.github.com/users/hudl","html_url":"https://github.com/hudl","followers_url":"https://api.github.com/users/hudl/followers","following_url":"https://api.github.com/users/hudl/following{/other_user}","gists_url":"https://api.github.com/users/hudl/gists{/gist_id}","starred_url":"https://api.github.com/users/hudl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hudl/subscriptions","organizations_url":"https://api.github.com/users/hudl/orgs","repos_url":"https://api.github.com/users/hudl/repos","events_url":"https://api.github.com/users/hudl/events{/privacy}","received_events_url":"https://api.github.com/users/hudl/received_events","type":"Organization","site_admin":false},"repo":{"id":45131597,"name":"graphql-dotnet","full_name":"hudl/graphql-dotnet","owner":{"login":"hudl","id":123340,"avatar_url":"https://avatars.githubusercontent.com/u/123340?v=3","gravatar_id":"","url":"https://api.github.com/users/hudl","html_url":"https://github.com/hudl","followers_url":"https://api.github.com/users/hudl/followers","following_url":"https://api.github.com/users/hudl/following{/other_user}","gists_url":"https://api.github.com/users/hudl/gists{/gist_id}","starred_url":"https://api.github.com/users/hudl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hudl/subscriptions","organizations_url":"https://api.github.com/users/hudl/orgs","repos_url":"https://api.github.com/users/hudl/repos","events_url":"https://api.github.com/users/hudl/events{/privacy}","received_events_url":"https://api.github.com/users/hudl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hudl/graphql-dotnet","description":"GraphQL for .NET","fork":true,"url":"https://api.github.com/repos/hudl/graphql-dotnet","forks_url":"https://api.github.com/repos/hudl/graphql-dotnet/forks","keys_url":"https://api.github.com/repos/hudl/graphql-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hudl/graphql-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hudl/graphql-dotnet/teams","hooks_url":"https://api.github.com/repos/hudl/graphql-dotnet/hooks","issue_events_url":"https://api.github.com/repos/hudl/graphql-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/hudl/graphql-dotnet/events","assignees_url":"https://api.github.com/repos/hudl/graphql-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/hudl/graphql-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/hudl/graphql-dotnet/tags","blobs_url":"https://api.github.com/repos/hudl/graphql-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hudl/graphql-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hudl/graphql-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/hudl/graphql-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hudl/graphql-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/hudl/graphql-dotnet/languages","stargazers_url":"https://api.github.com/repos/hudl/graphql-dotnet/stargazers","contributors_url":"https://api.github.com/repos/hudl/graphql-dotnet/contributors","subscribers_url":"https://api.github.com/repos/hudl/graphql-dotnet/subscribers","subscription_url":"https://api.github.com/repos/hudl/graphql-dotnet/subscription","commits_url":"https://api.github.com/repos/hudl/graphql-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/hudl/graphql-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/hudl/graphql-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/hudl/graphql-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/hudl/graphql-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/hudl/graphql-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hudl/graphql-dotnet/merges","archive_url":"https://api.github.com/repos/hudl/graphql-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hudl/graphql-dotnet/downloads","issues_url":"https://api.github.com/repos/hudl/graphql-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/hudl/graphql-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/hudl/graphql-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/hudl/graphql-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hudl/graphql-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/hudl/graphql-dotnet/releases{/id}","created_at":"2015-10-28T17:56:10Z","updated_at":"2015-10-28T17:56:11Z","pushed_at":"2015-12-04T18:14:14Z","git_url":"git://github.com/hudl/graphql-dotnet.git","ssh_url":"git@github.com:hudl/graphql-dotnet.git","clone_url":"https://github.com/hudl/graphql-dotnet.git","svn_url":"https://github.com/hudl/graphql-dotnet","homepage":"","size":577,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"graphql-dotnet:master","ref":"master","sha":"991d5534f9850fd6e8907806a26183cfb50c98b6","user":{"login":"graphql-dotnet","id":13958777,"avatar_url":"https://avatars.githubusercontent.com/u/13958777?v=3","gravatar_id":"","url":"https://api.github.com/users/graphql-dotnet","html_url":"https://github.com/graphql-dotnet","followers_url":"https://api.github.com/users/graphql-dotnet/followers","following_url":"https://api.github.com/users/graphql-dotnet/following{/other_user}","gists_url":"https://api.github.com/users/graphql-dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/graphql-dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphql-dotnet/subscriptions","organizations_url":"https://api.github.com/users/graphql-dotnet/orgs","repos_url":"https://api.github.com/users/graphql-dotnet/repos","events_url":"https://api.github.com/users/graphql-dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/graphql-dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":38632468,"name":"graphql-dotnet","full_name":"graphql-dotnet/graphql-dotnet","owner":{"login":"graphql-dotnet","id":13958777,"avatar_url":"https://avatars.githubusercontent.com/u/13958777?v=3","gravatar_id":"","url":"https://api.github.com/users/graphql-dotnet","html_url":"https://github.com/graphql-dotnet","followers_url":"https://api.github.com/users/graphql-dotnet/followers","following_url":"https://api.github.com/users/graphql-dotnet/following{/other_user}","gists_url":"https://api.github.com/users/graphql-dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/graphql-dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphql-dotnet/subscriptions","organizations_url":"https://api.github.com/users/graphql-dotnet/orgs","repos_url":"https://api.github.com/users/graphql-dotnet/repos","events_url":"https://api.github.com/users/graphql-dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/graphql-dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/graphql-dotnet/graphql-dotnet","description":"GraphQL for .NET","fork":false,"url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet","forks_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/forks","keys_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/teams","hooks_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/hooks","issue_events_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/events","assignees_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/tags","blobs_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/languages","stargazers_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/stargazers","contributors_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/contributors","subscribers_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/subscribers","subscription_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/subscription","commits_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/merges","archive_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/downloads","issues_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/releases{/id}","created_at":"2015-07-06T16:47:15Z","updated_at":"2015-12-04T14:28:44Z","pushed_at":"2015-12-04T18:14:15Z","git_url":"git://github.com/graphql-dotnet/graphql-dotnet.git","ssh_url":"git@github.com:graphql-dotnet/graphql-dotnet.git","clone_url":"https://github.com/graphql-dotnet/graphql-dotnet.git","svn_url":"https://github.com/graphql-dotnet/graphql-dotnet","homepage":"","size":569,"stargazers_count":122,"watchers_count":122,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":12,"forks":27,"open_issues":12,"watchers":122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/pulls/32"},"html":{"href":"https://github.com/graphql-dotnet/graphql-dotnet/pull/32"},"issue":{"href":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/issues/32"},"comments":{"href":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/statuses/4e57f2193a85507081ce454b16e25aa91a1c5bc6"}}}}