{"action":"created","comment":{"url":"https://api.github.com/repos/ramda/ramda/pulls/comments/45553778","id":45553778,"diff_hunk":"@@ -36,12 +36,12 @@ module.exports = _curry2(/* globals Set */ typeof Set === 'undefined' ?\n   } :\n   function uniqBySet(fn, list) {\n     var set           = new Set(),\n-        applied       = [], appliedItem, item,\n-        prevSetSize   = 0,  newSetSize,\n-        result        = [],\n-        nullExists    = false,\n-        negZeroExists = false,\n-        idx           = 0;\n+      applied       = [], appliedItem, item,\n+      prevSetSize   = 0,  newSetSize,\n+      result        = [],\n+      nullExists    = false,\n+      negZeroExists = false,\n+      idx           = 0;","path":"src/uniqBy.js","position":15,"original_position":15,"commit_id":"fd289618747131546c143b672cb52d497c7a4ee1","original_commit_id":"fd289618747131546c143b672cb52d497c7a4ee1","user":{"login":"scott-christopher","id":8951601,"avatar_url":"https://avatars.githubusercontent.com/u/8951601?v=3","gravatar_id":"","url":"https://api.github.com/users/scott-christopher","html_url":"https://github.com/scott-christopher","followers_url":"https://api.github.com/users/scott-christopher/followers","following_url":"https://api.github.com/users/scott-christopher/following{/other_user}","gists_url":"https://api.github.com/users/scott-christopher/gists{/gist_id}","starred_url":"https://api.github.com/users/scott-christopher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scott-christopher/subscriptions","organizations_url":"https://api.github.com/users/scott-christopher/orgs","repos_url":"https://api.github.com/users/scott-christopher/repos","events_url":"https://api.github.com/users/scott-christopher/events{/privacy}","received_events_url":"https://api.github.com/users/scott-christopher/received_events","type":"User","site_admin":false},"body":"The `=` here either needs realigning or the extra whitespace used for alignment should be removed.","created_at":"2015-11-22T02:43:49Z","updated_at":"2015-11-22T02:43:49Z","html_url":"https://github.com/ramda/ramda/pull/1529#discussion_r45553778","pull_request_url":"https://api.github.com/repos/ramda/ramda/pulls/1529","_links":{"self":{"href":"https://api.github.com/repos/ramda/ramda/pulls/comments/45553778"},"html":{"href":"https://github.com/ramda/ramda/pull/1529#discussion_r45553778"},"pull_request":{"href":"https://api.github.com/repos/ramda/ramda/pulls/1529"}}},"pull_request":{"url":"https://api.github.com/repos/ramda/ramda/pulls/1529","id":51452693,"html_url":"https://github.com/ramda/ramda/pull/1529","diff_url":"https://github.com/ramda/ramda/pull/1529.diff","patch_url":"https://github.com/ramda/ramda/pull/1529.patch","issue_url":"https://api.github.com/repos/ramda/ramda/issues/1529","number":1529,"state":"open","locked":false,"title":"RFC: switch to eslint","user":{"login":"gilligan","id":27668,"avatar_url":"https://avatars.githubusercontent.com/u/27668?v=3","gravatar_id":"","url":"https://api.github.com/users/gilligan","html_url":"https://github.com/gilligan","followers_url":"https://api.github.com/users/gilligan/followers","following_url":"https://api.github.com/users/gilligan/following{/other_user}","gists_url":"https://api.github.com/users/gilligan/gists{/gist_id}","starred_url":"https://api.github.com/users/gilligan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gilligan/subscriptions","organizations_url":"https://api.github.com/users/gilligan/orgs","repos_url":"https://api.github.com/users/gilligan/repos","events_url":"https://api.github.com/users/gilligan/events{/privacy}","received_events_url":"https://api.github.com/users/gilligan/received_events","type":"User","site_admin":false},"body":"### what\r\nAs mentioned on gitter I would like to replace `jshint` and `jscs` with `eslint`. \r\n\r\n### why\r\neslint is flexible and powerful enough to replace the functionality of both tools. Even if rules beyond current capabilities might be required at some point there is a nice plugin architecture which would allow for custom rules. Apart from that jshint is somewhat archaic.\r\n\r\n### status\r\nI started off by creating an `.eslintrc` with https://www.npmjs.com/package/polyjuice and continued to fine tune manually. Further manual tweakings were required. I had to do some consistency fixes to get everything error-free. I will provide more detail later on.\r\n\r\nThere is far more that could be configured but obviously I could not just decide that on my own in this PR. For now I'd like to hear what everyone thinks about using eslint and if I should invest more time into this.","created_at":"2015-11-21T23:09:14Z","updated_at":"2015-11-22T02:43:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e54a7d61839e3ba594ae1f8a329153a779dfbfe8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ramda/ramda/pulls/1529/commits","review_comments_url":"https://api.github.com/repos/ramda/ramda/pulls/1529/comments","review_comment_url":"https://api.github.com/repos/ramda/ramda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ramda/ramda/issues/1529/comments","statuses_url":"https://api.github.com/repos/ramda/ramda/statuses/fd289618747131546c143b672cb52d497c7a4ee1","head":{"label":"gilligan:use-eslint","ref":"use-eslint","sha":"fd289618747131546c143b672cb52d497c7a4ee1","user":{"login":"gilligan","id":27668,"avatar_url":"https://avatars.githubusercontent.com/u/27668?v=3","gravatar_id":"","url":"https://api.github.com/users/gilligan","html_url":"https://github.com/gilligan","followers_url":"https://api.github.com/users/gilligan/followers","following_url":"https://api.github.com/users/gilligan/following{/other_user}","gists_url":"https://api.github.com/users/gilligan/gists{/gist_id}","starred_url":"https://api.github.com/users/gilligan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gilligan/subscriptions","organizations_url":"https://api.github.com/users/gilligan/orgs","repos_url":"https://api.github.com/users/gilligan/repos","events_url":"https://api.github.com/users/gilligan/events{/privacy}","received_events_url":"https://api.github.com/users/gilligan/received_events","type":"User","site_admin":false},"repo":{"id":44607489,"name":"ramda","full_name":"gilligan/ramda","owner":{"login":"gilligan","id":27668,"avatar_url":"https://avatars.githubusercontent.com/u/27668?v=3","gravatar_id":"","url":"https://api.github.com/users/gilligan","html_url":"https://github.com/gilligan","followers_url":"https://api.github.com/users/gilligan/followers","following_url":"https://api.github.com/users/gilligan/following{/other_user}","gists_url":"https://api.github.com/users/gilligan/gists{/gist_id}","starred_url":"https://api.github.com/users/gilligan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gilligan/subscriptions","organizations_url":"https://api.github.com/users/gilligan/orgs","repos_url":"https://api.github.com/users/gilligan/repos","events_url":"https://api.github.com/users/gilligan/events{/privacy}","received_events_url":"https://api.github.com/users/gilligan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gilligan/ramda","description":":ram: Practical functional Javascript","fork":true,"url":"https://api.github.com/repos/gilligan/ramda","forks_url":"https://api.github.com/repos/gilligan/ramda/forks","keys_url":"https://api.github.com/repos/gilligan/ramda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gilligan/ramda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gilligan/ramda/teams","hooks_url":"https://api.github.com/repos/gilligan/ramda/hooks","issue_events_url":"https://api.github.com/repos/gilligan/ramda/issues/events{/number}","events_url":"https://api.github.com/repos/gilligan/ramda/events","assignees_url":"https://api.github.com/repos/gilligan/ramda/assignees{/user}","branches_url":"https://api.github.com/repos/gilligan/ramda/branches{/branch}","tags_url":"https://api.github.com/repos/gilligan/ramda/tags","blobs_url":"https://api.github.com/repos/gilligan/ramda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gilligan/ramda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gilligan/ramda/git/refs{/sha}","trees_url":"https://api.github.com/repos/gilligan/ramda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gilligan/ramda/statuses/{sha}","languages_url":"https://api.github.com/repos/gilligan/ramda/languages","stargazers_url":"https://api.github.com/repos/gilligan/ramda/stargazers","contributors_url":"https://api.github.com/repos/gilligan/ramda/contributors","subscribers_url":"https://api.github.com/repos/gilligan/ramda/subscribers","subscription_url":"https://api.github.com/repos/gilligan/ramda/subscription","commits_url":"https://api.github.com/repos/gilligan/ramda/commits{/sha}","git_commits_url":"https://api.github.com/repos/gilligan/ramda/git/commits{/sha}","comments_url":"https://api.github.com/repos/gilligan/ramda/comments{/number}","issue_comment_url":"https://api.github.com/repos/gilligan/ramda/issues/comments{/number}","contents_url":"https://api.github.com/repos/gilligan/ramda/contents/{+path}","compare_url":"https://api.github.com/repos/gilligan/ramda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gilligan/ramda/merges","archive_url":"https://api.github.com/repos/gilligan/ramda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gilligan/ramda/downloads","issues_url":"https://api.github.com/repos/gilligan/ramda/issues{/number}","pulls_url":"https://api.github.com/repos/gilligan/ramda/pulls{/number}","milestones_url":"https://api.github.com/repos/gilligan/ramda/milestones{/number}","notifications_url":"https://api.github.com/repos/gilligan/ramda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gilligan/ramda/labels{/name}","releases_url":"https://api.github.com/repos/gilligan/ramda/releases{/id}","created_at":"2015-10-20T13:18:18Z","updated_at":"2015-10-20T13:18:20Z","pushed_at":"2015-11-21T23:00:38Z","git_url":"git://github.com/gilligan/ramda.git","ssh_url":"git@github.com:gilligan/ramda.git","clone_url":"https://github.com/gilligan/ramda.git","svn_url":"https://github.com/gilligan/ramda","homepage":"http://ramdajs.com","size":5131,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ramda:master","ref":"master","sha":"dfda81be01c5d9f1f92808739ef55f3db9200409","user":{"login":"ramda","id":5298359,"avatar_url":"https://avatars.githubusercontent.com/u/5298359?v=3","gravatar_id":"","url":"https://api.github.com/users/ramda","html_url":"https://github.com/ramda","followers_url":"https://api.github.com/users/ramda/followers","following_url":"https://api.github.com/users/ramda/following{/other_user}","gists_url":"https://api.github.com/users/ramda/gists{/gist_id}","starred_url":"https://api.github.com/users/ramda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramda/subscriptions","organizations_url":"https://api.github.com/users/ramda/orgs","repos_url":"https://api.github.com/users/ramda/repos","events_url":"https://api.github.com/users/ramda/events{/privacy}","received_events_url":"https://api.github.com/users/ramda/received_events","type":"Organization","site_admin":false},"repo":{"id":10851820,"name":"ramda","full_name":"ramda/ramda","owner":{"login":"ramda","id":5298359,"avatar_url":"https://avatars.githubusercontent.com/u/5298359?v=3","gravatar_id":"","url":"https://api.github.com/users/ramda","html_url":"https://github.com/ramda","followers_url":"https://api.github.com/users/ramda/followers","following_url":"https://api.github.com/users/ramda/following{/other_user}","gists_url":"https://api.github.com/users/ramda/gists{/gist_id}","starred_url":"https://api.github.com/users/ramda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramda/subscriptions","organizations_url":"https://api.github.com/users/ramda/orgs","repos_url":"https://api.github.com/users/ramda/repos","events_url":"https://api.github.com/users/ramda/events{/privacy}","received_events_url":"https://api.github.com/users/ramda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ramda/ramda","description":":ram: Practical functional Javascript","fork":false,"url":"https://api.github.com/repos/ramda/ramda","forks_url":"https://api.github.com/repos/ramda/ramda/forks","keys_url":"https://api.github.com/repos/ramda/ramda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ramda/ramda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ramda/ramda/teams","hooks_url":"https://api.github.com/repos/ramda/ramda/hooks","issue_events_url":"https://api.github.com/repos/ramda/ramda/issues/events{/number}","events_url":"https://api.github.com/repos/ramda/ramda/events","assignees_url":"https://api.github.com/repos/ramda/ramda/assignees{/user}","branches_url":"https://api.github.com/repos/ramda/ramda/branches{/branch}","tags_url":"https://api.github.com/repos/ramda/ramda/tags","blobs_url":"https://api.github.com/repos/ramda/ramda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ramda/ramda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ramda/ramda/git/refs{/sha}","trees_url":"https://api.github.com/repos/ramda/ramda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ramda/ramda/statuses/{sha}","languages_url":"https://api.github.com/repos/ramda/ramda/languages","stargazers_url":"https://api.github.com/repos/ramda/ramda/stargazers","contributors_url":"https://api.github.com/repos/ramda/ramda/contributors","subscribers_url":"https://api.github.com/repos/ramda/ramda/subscribers","subscription_url":"https://api.github.com/repos/ramda/ramda/subscription","commits_url":"https://api.github.com/repos/ramda/ramda/commits{/sha}","git_commits_url":"https://api.github.com/repos/ramda/ramda/git/commits{/sha}","comments_url":"https://api.github.com/repos/ramda/ramda/comments{/number}","issue_comment_url":"https://api.github.com/repos/ramda/ramda/issues/comments{/number}","contents_url":"https://api.github.com/repos/ramda/ramda/contents/{+path}","compare_url":"https://api.github.com/repos/ramda/ramda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ramda/ramda/merges","archive_url":"https://api.github.com/repos/ramda/ramda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ramda/ramda/downloads","issues_url":"https://api.github.com/repos/ramda/ramda/issues{/number}","pulls_url":"https://api.github.com/repos/ramda/ramda/pulls{/number}","milestones_url":"https://api.github.com/repos/ramda/ramda/milestones{/number}","notifications_url":"https://api.github.com/repos/ramda/ramda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ramda/ramda/labels{/name}","releases_url":"https://api.github.com/repos/ramda/ramda/releases{/id}","created_at":"2013-06-21T20:32:35Z","updated_at":"2015-11-22T00:08:52Z","pushed_at":"2015-11-22T00:38:43Z","git_url":"git://github.com/ramda/ramda.git","ssh_url":"git@github.com:ramda/ramda.git","clone_url":"https://github.com/ramda/ramda.git","svn_url":"https://github.com/ramda/ramda","homepage":"http://ramdajs.com","size":6395,"stargazers_count":3181,"watchers_count":3181,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":235,"mirror_url":null,"open_issues_count":86,"forks":235,"open_issues":86,"watchers":3181,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ramda/ramda/pulls/1529"},"html":{"href":"https://github.com/ramda/ramda/pull/1529"},"issue":{"href":"https://api.github.com/repos/ramda/ramda/issues/1529"},"comments":{"href":"https://api.github.com/repos/ramda/ramda/issues/1529/comments"},"review_comments":{"href":"https://api.github.com/repos/ramda/ramda/pulls/1529/comments"},"review_comment":{"href":"https://api.github.com/repos/ramda/ramda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ramda/ramda/pulls/1529/commits"},"statuses":{"href":"https://api.github.com/repos/ramda/ramda/statuses/fd289618747131546c143b672cb52d497c7a4ee1"}}}}