{"action":"created","issue":{"url":"https://api.github.com/repos/ReactiveX/RxJS/issues/463","labels_url":"https://api.github.com/repos/ReactiveX/RxJS/issues/463/labels{/name}","comments_url":"https://api.github.com/repos/ReactiveX/RxJS/issues/463/comments","events_url":"https://api.github.com/repos/ReactiveX/RxJS/issues/463/events","html_url":"https://github.com/ReactiveX/RxJS/pull/463","id":109854106,"number":463,"title":"chore(TestScheduler): add asserts for unsubscriptions","user":{"login":"staltz","id":90512,"avatar_url":"https://avatars.githubusercontent.com/u/90512?v=3","gravatar_id":"","url":"https://api.github.com/users/staltz","html_url":"https://github.com/staltz","followers_url":"https://api.github.com/users/staltz/followers","following_url":"https://api.github.com/users/staltz/following{/other_user}","gists_url":"https://api.github.com/users/staltz/gists{/gist_id}","starred_url":"https://api.github.com/users/staltz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staltz/subscriptions","organizations_url":"https://api.github.com/users/staltz/orgs","repos_url":"https://api.github.com/users/staltz/repos","events_url":"https://api.github.com/users/staltz/events{/privacy}","received_events_url":"https://api.github.com/users/staltz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-05T18:09:55Z","updated_at":"2015-10-05T18:20:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ReactiveX/RxJS/pulls/463","html_url":"https://github.com/ReactiveX/RxJS/pull/463","diff_url":"https://github.com/ReactiveX/RxJS/pull/463.diff","patch_url":"https://github.com/ReactiveX/RxJS/pull/463.patch"},"body":"Add `expectSubscription(coldOrHotTestObservable.subscriptions).toBe(unsubs)` feature to test utilities. Create multiple test utility classes such as ColdObservable, HotObservable, SubscriptionLog, TestMessage, etc. Also fix minor issues with VirtualTimeScheduler and Subject. Subject._subscribe() was taking an Observer, but its parent Observable._subscribe() was taking a Subscriber, so this commit changes Subject._subscribe() to take a Subscriber as well. This facilitates usage in HotObservable, for example.\r\n\r\nResolves issue #428."},"comment":{"url":"https://api.github.com/repos/ReactiveX/RxJS/issues/comments/145621704","html_url":"https://github.com/ReactiveX/RxJS/pull/463#issuecomment-145621704","issue_url":"https://api.github.com/repos/ReactiveX/RxJS/issues/463","id":145621704,"user":{"login":"staltz","id":90512,"avatar_url":"https://avatars.githubusercontent.com/u/90512?v=3","gravatar_id":"","url":"https://api.github.com/users/staltz","html_url":"https://github.com/staltz","followers_url":"https://api.github.com/users/staltz/followers","following_url":"https://api.github.com/users/staltz/following{/other_user}","gists_url":"https://api.github.com/users/staltz/gists{/gist_id}","starred_url":"https://api.github.com/users/staltz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staltz/subscriptions","organizations_url":"https://api.github.com/users/staltz/orgs","repos_url":"https://api.github.com/users/staltz/repos","events_url":"https://api.github.com/users/staltz/events{/privacy}","received_events_url":"https://api.github.com/users/staltz/received_events","type":"User","site_admin":false},"created_at":"2015-10-05T18:20:50Z","updated_at":"2015-10-05T18:20:50Z","body":"Woops, something that came to mind right now, which I completely forgot to add, were tests for TestScheduler.expectSubscriptions itself."}}