{"action":"created","comment":{"url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/comments/29875791","id":29875791,"diff_hunk":"@@ -303,6 +352,23 @@ func addDir(n *core.IpfsNode, dir files.File, out chan interface{}, progress boo\n \treturn tree, nil\n }\n \n+func checkForLocalIgnorePatterns(dir string, ignoreFilePatterns []ignore.GitIgnore) []ignore.GitIgnore {\n+\tvar ignorePathname string\n+\tif dir == \".\" {\n+\t\tignorePathname = \".ipfsignore\"\n+\t} else {\n+\t\tignorePathname = path.Join(dir, \".ipfsignore\")","path":"core/commands/add.go","position":148,"original_position":148,"commit_id":"efae6b1fc70f41ae04115d7d6770192a504b3425","original_commit_id":"efae6b1fc70f41ae04115d7d6770192a504b3425","user":{"login":"gatesvp","id":319590,"avatar_url":"https://avatars.githubusercontent.com/u/319590?v=3","gravatar_id":"","url":"https://api.github.com/users/gatesvp","html_url":"https://github.com/gatesvp","followers_url":"https://api.github.com/users/gatesvp/followers","following_url":"https://api.github.com/users/gatesvp/following{/other_user}","gists_url":"https://api.github.com/users/gatesvp/gists{/gist_id}","starred_url":"https://api.github.com/users/gatesvp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gatesvp/subscriptions","organizations_url":"https://api.github.com/users/gatesvp/orgs","repos_url":"https://api.github.com/users/gatesvp/repos","events_url":"https://api.github.com/users/gatesvp/events{/privacy}","received_events_url":"https://api.github.com/users/gatesvp/received_events","type":"User","site_admin":false},"body":"I think you are right, that line was written before I had the folder level recursion working correctly. The check inside of `Run` should now cover this case.","created_at":"2015-05-07T17:37:25Z","updated_at":"2015-05-07T17:37:25Z","html_url":"https://github.com/ipfs/go-ipfs/pull/1204#discussion_r29875791","pull_request_url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/1204","_links":{"self":{"href":"https://api.github.com/repos/ipfs/go-ipfs/pulls/comments/29875791"},"html":{"href":"https://github.com/ipfs/go-ipfs/pull/1204#discussion_r29875791"},"pull_request":{"href":"https://api.github.com/repos/ipfs/go-ipfs/pulls/1204"}}},"pull_request":{"url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/1204","id":34883216,"html_url":"https://github.com/ipfs/go-ipfs/pull/1204","diff_url":"https://github.com/ipfs/go-ipfs/pull/1204.diff","patch_url":"https://github.com/ipfs/go-ipfs/pull/1204.patch","issue_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/1204","number":1204,"state":"open","locked":false,"title":"Add support for `.ipfsignore` and hidden files","user":{"login":"gatesvp","id":319590,"avatar_url":"https://avatars.githubusercontent.com/u/319590?v=3","gravatar_id":"","url":"https://api.github.com/users/gatesvp","html_url":"https://github.com/gatesvp","followers_url":"https://api.github.com/users/gatesvp/followers","following_url":"https://api.github.com/users/gatesvp/following{/other_user}","gists_url":"https://api.github.com/users/gatesvp/gists{/gist_id}","starred_url":"https://api.github.com/users/gatesvp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gatesvp/subscriptions","organizations_url":"https://api.github.com/users/gatesvp/orgs","repos_url":"https://api.github.com/users/gatesvp/repos","events_url":"https://api.github.com/users/gatesvp/events{/privacy}","received_events_url":"https://api.github.com/users/gatesvp/received_events","type":"User","site_admin":false},"body":"Resolution for #653 ","created_at":"2015-05-07T04:55:23Z","updated_at":"2015-05-07T17:37:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e7796f2345b6a09398fe495a45284a4cc2fe348","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/1204/commits","review_comments_url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/1204/comments","review_comment_url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/1204/comments","statuses_url":"https://api.github.com/repos/ipfs/go-ipfs/statuses/efae6b1fc70f41ae04115d7d6770192a504b3425","head":{"label":"gatesvp:master","ref":"master","sha":"efae6b1fc70f41ae04115d7d6770192a504b3425","user":{"login":"gatesvp","id":319590,"avatar_url":"https://avatars.githubusercontent.com/u/319590?v=3","gravatar_id":"","url":"https://api.github.com/users/gatesvp","html_url":"https://github.com/gatesvp","followers_url":"https://api.github.com/users/gatesvp/followers","following_url":"https://api.github.com/users/gatesvp/following{/other_user}","gists_url":"https://api.github.com/users/gatesvp/gists{/gist_id}","starred_url":"https://api.github.com/users/gatesvp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gatesvp/subscriptions","organizations_url":"https://api.github.com/users/gatesvp/orgs","repos_url":"https://api.github.com/users/gatesvp/repos","events_url":"https://api.github.com/users/gatesvp/events{/privacy}","received_events_url":"https://api.github.com/users/gatesvp/received_events","type":"User","site_admin":false},"repo":{"id":23377578,"name":"go-ipfs","full_name":"gatesvp/go-ipfs","owner":{"login":"gatesvp","id":319590,"avatar_url":"https://avatars.githubusercontent.com/u/319590?v=3","gravatar_id":"","url":"https://api.github.com/users/gatesvp","html_url":"https://github.com/gatesvp","followers_url":"https://api.github.com/users/gatesvp/followers","following_url":"https://api.github.com/users/gatesvp/following{/other_user}","gists_url":"https://api.github.com/users/gatesvp/gists{/gist_id}","starred_url":"https://api.github.com/users/gatesvp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gatesvp/subscriptions","organizations_url":"https://api.github.com/users/gatesvp/orgs","repos_url":"https://api.github.com/users/gatesvp/repos","events_url":"https://api.github.com/users/gatesvp/events{/privacy}","received_events_url":"https://api.github.com/users/gatesvp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gatesvp/go-ipfs","description":"ipfs implementation in go","fork":true,"url":"https://api.github.com/repos/gatesvp/go-ipfs","forks_url":"https://api.github.com/repos/gatesvp/go-ipfs/forks","keys_url":"https://api.github.com/repos/gatesvp/go-ipfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gatesvp/go-ipfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gatesvp/go-ipfs/teams","hooks_url":"https://api.github.com/repos/gatesvp/go-ipfs/hooks","issue_events_url":"https://api.github.com/repos/gatesvp/go-ipfs/issues/events{/number}","events_url":"https://api.github.com/repos/gatesvp/go-ipfs/events","assignees_url":"https://api.github.com/repos/gatesvp/go-ipfs/assignees{/user}","branches_url":"https://api.github.com/repos/gatesvp/go-ipfs/branches{/branch}","tags_url":"https://api.github.com/repos/gatesvp/go-ipfs/tags","blobs_url":"https://api.github.com/repos/gatesvp/go-ipfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gatesvp/go-ipfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gatesvp/go-ipfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/gatesvp/go-ipfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gatesvp/go-ipfs/statuses/{sha}","languages_url":"https://api.github.com/repos/gatesvp/go-ipfs/languages","stargazers_url":"https://api.github.com/repos/gatesvp/go-ipfs/stargazers","contributors_url":"https://api.github.com/repos/gatesvp/go-ipfs/contributors","subscribers_url":"https://api.github.com/repos/gatesvp/go-ipfs/subscribers","subscription_url":"https://api.github.com/repos/gatesvp/go-ipfs/subscription","commits_url":"https://api.github.com/repos/gatesvp/go-ipfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/gatesvp/go-ipfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/gatesvp/go-ipfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/gatesvp/go-ipfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/gatesvp/go-ipfs/contents/{+path}","compare_url":"https://api.github.com/repos/gatesvp/go-ipfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gatesvp/go-ipfs/merges","archive_url":"https://api.github.com/repos/gatesvp/go-ipfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gatesvp/go-ipfs/downloads","issues_url":"https://api.github.com/repos/gatesvp/go-ipfs/issues{/number}","pulls_url":"https://api.github.com/repos/gatesvp/go-ipfs/pulls{/number}","milestones_url":"https://api.github.com/repos/gatesvp/go-ipfs/milestones{/number}","notifications_url":"https://api.github.com/repos/gatesvp/go-ipfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gatesvp/go-ipfs/labels{/name}","releases_url":"https://api.github.com/repos/gatesvp/go-ipfs/releases{/id}","created_at":"2014-08-27T05:11:22Z","updated_at":"2015-05-07T04:46:55Z","pushed_at":"2015-05-07T04:49:38Z","git_url":"git://github.com/gatesvp/go-ipfs.git","ssh_url":"git@github.com:gatesvp/go-ipfs.git","clone_url":"https://github.com/gatesvp/go-ipfs.git","svn_url":"https://github.com/gatesvp/go-ipfs","homepage":"http://ipfs.io/","size":16173,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ipfs:master","ref":"master","sha":"0d521ff2889b4df7da8e049954c7ee06a5244945","user":{"login":"ipfs","id":10536621,"avatar_url":"https://avatars.githubusercontent.com/u/10536621?v=3","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"repo":{"id":21233191,"name":"go-ipfs","full_name":"ipfs/go-ipfs","owner":{"login":"ipfs","id":10536621,"avatar_url":"https://avatars.githubusercontent.com/u/10536621?v=3","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ipfs/go-ipfs","description":"ipfs implementation in go","fork":false,"url":"https://api.github.com/repos/ipfs/go-ipfs","forks_url":"https://api.github.com/repos/ipfs/go-ipfs/forks","keys_url":"https://api.github.com/repos/ipfs/go-ipfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipfs/go-ipfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipfs/go-ipfs/teams","hooks_url":"https://api.github.com/repos/ipfs/go-ipfs/hooks","issue_events_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/events{/number}","events_url":"https://api.github.com/repos/ipfs/go-ipfs/events","assignees_url":"https://api.github.com/repos/ipfs/go-ipfs/assignees{/user}","branches_url":"https://api.github.com/repos/ipfs/go-ipfs/branches{/branch}","tags_url":"https://api.github.com/repos/ipfs/go-ipfs/tags","blobs_url":"https://api.github.com/repos/ipfs/go-ipfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipfs/go-ipfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipfs/go-ipfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipfs/go-ipfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipfs/go-ipfs/statuses/{sha}","languages_url":"https://api.github.com/repos/ipfs/go-ipfs/languages","stargazers_url":"https://api.github.com/repos/ipfs/go-ipfs/stargazers","contributors_url":"https://api.github.com/repos/ipfs/go-ipfs/contributors","subscribers_url":"https://api.github.com/repos/ipfs/go-ipfs/subscribers","subscription_url":"https://api.github.com/repos/ipfs/go-ipfs/subscription","commits_url":"https://api.github.com/repos/ipfs/go-ipfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipfs/go-ipfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipfs/go-ipfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipfs/go-ipfs/contents/{+path}","compare_url":"https://api.github.com/repos/ipfs/go-ipfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipfs/go-ipfs/merges","archive_url":"https://api.github.com/repos/ipfs/go-ipfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipfs/go-ipfs/downloads","issues_url":"https://api.github.com/repos/ipfs/go-ipfs/issues{/number}","pulls_url":"https://api.github.com/repos/ipfs/go-ipfs/pulls{/number}","milestones_url":"https://api.github.com/repos/ipfs/go-ipfs/milestones{/number}","notifications_url":"https://api.github.com/repos/ipfs/go-ipfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipfs/go-ipfs/labels{/name}","releases_url":"https://api.github.com/repos/ipfs/go-ipfs/releases{/id}","created_at":"2014-06-26T08:14:34Z","updated_at":"2015-05-07T06:49:53Z","pushed_at":"2015-05-07T14:39:41Z","git_url":"git://github.com/ipfs/go-ipfs.git","ssh_url":"git@github.com:ipfs/go-ipfs.git","clone_url":"https://github.com/ipfs/go-ipfs.git","svn_url":"https://github.com/ipfs/go-ipfs","homepage":"https://github.com/ipfs/ipfs","size":35845,"stargazers_count":523,"watchers_count":523,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":87,"mirror_url":null,"open_issues_count":222,"forks":87,"open_issues":222,"watchers":523,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ipfs/go-ipfs/pulls/1204"},"html":{"href":"https://github.com/ipfs/go-ipfs/pull/1204"},"issue":{"href":"https://api.github.com/repos/ipfs/go-ipfs/issues/1204"},"comments":{"href":"https://api.github.com/repos/ipfs/go-ipfs/issues/1204/comments"},"review_comments":{"href":"https://api.github.com/repos/ipfs/go-ipfs/pulls/1204/comments"},"review_comment":{"href":"https://api.github.com/repos/ipfs/go-ipfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ipfs/go-ipfs/pulls/1204/commits"},"statuses":{"href":"https://api.github.com/repos/ipfs/go-ipfs/statuses/efae6b1fc70f41ae04115d7d6770192a504b3425"}}}}