{"action":"opened","number":1711,"pull_request":{"url":"https://api.github.com/repos/puphpet/puphpet/pulls/1711","id":37572461,"html_url":"https://github.com/puphpet/puphpet/pull/1711","diff_url":"https://github.com/puphpet/puphpet/pull/1711.diff","patch_url":"https://github.com/puphpet/puphpet/pull/1711.patch","issue_url":"https://api.github.com/repos/puphpet/puphpet/issues/1711","number":1711,"state":"open","locked":false,"title":"added ability to use public network without static ip","user":{"login":"Phpanos","id":890995,"avatar_url":"https://avatars.githubusercontent.com/u/890995?v=3","gravatar_id":"","url":"https://api.github.com/users/Phpanos","html_url":"https://github.com/Phpanos","followers_url":"https://api.github.com/users/Phpanos/followers","following_url":"https://api.github.com/users/Phpanos/following{/other_user}","gists_url":"https://api.github.com/users/Phpanos/gists{/gist_id}","starred_url":"https://api.github.com/users/Phpanos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Phpanos/subscriptions","organizations_url":"https://api.github.com/users/Phpanos/orgs","repos_url":"https://api.github.com/users/Phpanos/repos","events_url":"https://api.github.com/users/Phpanos/events{/privacy}","received_events_url":"https://api.github.com/users/Phpanos/received_events","type":"User","site_admin":false},"body":"At first I had a problem with getting public network to work which this code at line 17 solves:\r\n`config.vm.network 'public_network'`\r\nLater on I added an if statement to check if 1 was set as a value for the public_network variable in config.yaml.\r\n\r\npublic_network: '1' - if you want to enable public network\r\npublic_network: '192.168.33.10' - to enable public network AND set a static ip\r\n\r\nI'm no ruby programmer and I cannot understand why this isn't working. My code does solves it for me and also adds the option to opt out the static ip setting and still have a public network.","created_at":"2015-06-12T15:00:57Z","updated_at":"2015-06-12T15:00:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puphpet/puphpet/pulls/1711/commits","review_comments_url":"https://api.github.com/repos/puphpet/puphpet/pulls/1711/comments","review_comment_url":"https://api.github.com/repos/puphpet/puphpet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puphpet/puphpet/issues/1711/comments","statuses_url":"https://api.github.com/repos/puphpet/puphpet/statuses/40e704bcabc9bc7537ebaf19a510ce4bf7975c45","head":{"label":"Phpanos:master","ref":"master","sha":"40e704bcabc9bc7537ebaf19a510ce4bf7975c45","user":{"login":"Phpanos","id":890995,"avatar_url":"https://avatars.githubusercontent.com/u/890995?v=3","gravatar_id":"","url":"https://api.github.com/users/Phpanos","html_url":"https://github.com/Phpanos","followers_url":"https://api.github.com/users/Phpanos/followers","following_url":"https://api.github.com/users/Phpanos/following{/other_user}","gists_url":"https://api.github.com/users/Phpanos/gists{/gist_id}","starred_url":"https://api.github.com/users/Phpanos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Phpanos/subscriptions","organizations_url":"https://api.github.com/users/Phpanos/orgs","repos_url":"https://api.github.com/users/Phpanos/repos","events_url":"https://api.github.com/users/Phpanos/events{/privacy}","received_events_url":"https://api.github.com/users/Phpanos/received_events","type":"User","site_admin":false},"repo":{"id":37318064,"name":"puphpet","full_name":"Phpanos/puphpet","owner":{"login":"Phpanos","id":890995,"avatar_url":"https://avatars.githubusercontent.com/u/890995?v=3","gravatar_id":"","url":"https://api.github.com/users/Phpanos","html_url":"https://github.com/Phpanos","followers_url":"https://api.github.com/users/Phpanos/followers","following_url":"https://api.github.com/users/Phpanos/following{/other_user}","gists_url":"https://api.github.com/users/Phpanos/gists{/gist_id}","starred_url":"https://api.github.com/users/Phpanos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Phpanos/subscriptions","organizations_url":"https://api.github.com/users/Phpanos/orgs","repos_url":"https://api.github.com/users/Phpanos/repos","events_url":"https://api.github.com/users/Phpanos/events{/privacy}","received_events_url":"https://api.github.com/users/Phpanos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Phpanos/puphpet","description":"Vagrant/Puppet GUI","fork":true,"url":"https://api.github.com/repos/Phpanos/puphpet","forks_url":"https://api.github.com/repos/Phpanos/puphpet/forks","keys_url":"https://api.github.com/repos/Phpanos/puphpet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Phpanos/puphpet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Phpanos/puphpet/teams","hooks_url":"https://api.github.com/repos/Phpanos/puphpet/hooks","issue_events_url":"https://api.github.com/repos/Phpanos/puphpet/issues/events{/number}","events_url":"https://api.github.com/repos/Phpanos/puphpet/events","assignees_url":"https://api.github.com/repos/Phpanos/puphpet/assignees{/user}","branches_url":"https://api.github.com/repos/Phpanos/puphpet/branches{/branch}","tags_url":"https://api.github.com/repos/Phpanos/puphpet/tags","blobs_url":"https://api.github.com/repos/Phpanos/puphpet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Phpanos/puphpet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Phpanos/puphpet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Phpanos/puphpet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Phpanos/puphpet/statuses/{sha}","languages_url":"https://api.github.com/repos/Phpanos/puphpet/languages","stargazers_url":"https://api.github.com/repos/Phpanos/puphpet/stargazers","contributors_url":"https://api.github.com/repos/Phpanos/puphpet/contributors","subscribers_url":"https://api.github.com/repos/Phpanos/puphpet/subscribers","subscription_url":"https://api.github.com/repos/Phpanos/puphpet/subscription","commits_url":"https://api.github.com/repos/Phpanos/puphpet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Phpanos/puphpet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Phpanos/puphpet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Phpanos/puphpet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Phpanos/puphpet/contents/{+path}","compare_url":"https://api.github.com/repos/Phpanos/puphpet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Phpanos/puphpet/merges","archive_url":"https://api.github.com/repos/Phpanos/puphpet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Phpanos/puphpet/downloads","issues_url":"https://api.github.com/repos/Phpanos/puphpet/issues{/number}","pulls_url":"https://api.github.com/repos/Phpanos/puphpet/pulls{/number}","milestones_url":"https://api.github.com/repos/Phpanos/puphpet/milestones{/number}","notifications_url":"https://api.github.com/repos/Phpanos/puphpet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Phpanos/puphpet/labels{/name}","releases_url":"https://api.github.com/repos/Phpanos/puphpet/releases{/id}","created_at":"2015-06-12T11:19:51Z","updated_at":"2015-06-12T11:19:52Z","pushed_at":"2015-06-12T14:53:23Z","git_url":"git://github.com/Phpanos/puphpet.git","ssh_url":"git@github.com:Phpanos/puphpet.git","clone_url":"https://github.com/Phpanos/puphpet.git","svn_url":"https://github.com/Phpanos/puphpet","homepage":null,"size":17400,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puphpet:master","ref":"master","sha":"304e4fe95fa999f23863c5c91d5a100987ce4ce8","user":{"login":"puphpet","id":4490619,"avatar_url":"https://avatars.githubusercontent.com/u/4490619?v=3","gravatar_id":"","url":"https://api.github.com/users/puphpet","html_url":"https://github.com/puphpet","followers_url":"https://api.github.com/users/puphpet/followers","following_url":"https://api.github.com/users/puphpet/following{/other_user}","gists_url":"https://api.github.com/users/puphpet/gists{/gist_id}","starred_url":"https://api.github.com/users/puphpet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puphpet/subscriptions","organizations_url":"https://api.github.com/users/puphpet/orgs","repos_url":"https://api.github.com/users/puphpet/repos","events_url":"https://api.github.com/users/puphpet/events{/privacy}","received_events_url":"https://api.github.com/users/puphpet/received_events","type":"Organization","site_admin":false},"repo":{"id":9726245,"name":"puphpet","full_name":"puphpet/puphpet","owner":{"login":"puphpet","id":4490619,"avatar_url":"https://avatars.githubusercontent.com/u/4490619?v=3","gravatar_id":"","url":"https://api.github.com/users/puphpet","html_url":"https://github.com/puphpet","followers_url":"https://api.github.com/users/puphpet/followers","following_url":"https://api.github.com/users/puphpet/following{/other_user}","gists_url":"https://api.github.com/users/puphpet/gists{/gist_id}","starred_url":"https://api.github.com/users/puphpet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puphpet/subscriptions","organizations_url":"https://api.github.com/users/puphpet/orgs","repos_url":"https://api.github.com/users/puphpet/repos","events_url":"https://api.github.com/users/puphpet/events{/privacy}","received_events_url":"https://api.github.com/users/puphpet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puphpet/puphpet","description":"Vagrant/Puppet GUI","fork":false,"url":"https://api.github.com/repos/puphpet/puphpet","forks_url":"https://api.github.com/repos/puphpet/puphpet/forks","keys_url":"https://api.github.com/repos/puphpet/puphpet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puphpet/puphpet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puphpet/puphpet/teams","hooks_url":"https://api.github.com/repos/puphpet/puphpet/hooks","issue_events_url":"https://api.github.com/repos/puphpet/puphpet/issues/events{/number}","events_url":"https://api.github.com/repos/puphpet/puphpet/events","assignees_url":"https://api.github.com/repos/puphpet/puphpet/assignees{/user}","branches_url":"https://api.github.com/repos/puphpet/puphpet/branches{/branch}","tags_url":"https://api.github.com/repos/puphpet/puphpet/tags","blobs_url":"https://api.github.com/repos/puphpet/puphpet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puphpet/puphpet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puphpet/puphpet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puphpet/puphpet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puphpet/puphpet/statuses/{sha}","languages_url":"https://api.github.com/repos/puphpet/puphpet/languages","stargazers_url":"https://api.github.com/repos/puphpet/puphpet/stargazers","contributors_url":"https://api.github.com/repos/puphpet/puphpet/contributors","subscribers_url":"https://api.github.com/repos/puphpet/puphpet/subscribers","subscription_url":"https://api.github.com/repos/puphpet/puphpet/subscription","commits_url":"https://api.github.com/repos/puphpet/puphpet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puphpet/puphpet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puphpet/puphpet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puphpet/puphpet/issues/comments{/number}","contents_url":"https://api.github.com/repos/puphpet/puphpet/contents/{+path}","compare_url":"https://api.github.com/repos/puphpet/puphpet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puphpet/puphpet/merges","archive_url":"https://api.github.com/repos/puphpet/puphpet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puphpet/puphpet/downloads","issues_url":"https://api.github.com/repos/puphpet/puphpet/issues{/number}","pulls_url":"https://api.github.com/repos/puphpet/puphpet/pulls{/number}","milestones_url":"https://api.github.com/repos/puphpet/puphpet/milestones{/number}","notifications_url":"https://api.github.com/repos/puphpet/puphpet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puphpet/puphpet/labels{/name}","releases_url":"https://api.github.com/repos/puphpet/puphpet/releases{/id}","created_at":"2013-04-28T06:18:02Z","updated_at":"2015-06-12T14:49:24Z","pushed_at":"2015-06-09T14:27:52Z","git_url":"git://github.com/puphpet/puphpet.git","ssh_url":"git@github.com:puphpet/puphpet.git","clone_url":"https://github.com/puphpet/puphpet.git","svn_url":"https://github.com/puphpet/puphpet","homepage":null,"size":17400,"stargazers_count":2927,"watchers_count":2927,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":551,"mirror_url":null,"open_issues_count":99,"forks":551,"open_issues":99,"watchers":2927,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puphpet/puphpet/pulls/1711"},"html":{"href":"https://github.com/puphpet/puphpet/pull/1711"},"issue":{"href":"https://api.github.com/repos/puphpet/puphpet/issues/1711"},"comments":{"href":"https://api.github.com/repos/puphpet/puphpet/issues/1711/comments"},"review_comments":{"href":"https://api.github.com/repos/puphpet/puphpet/pulls/1711/comments"},"review_comment":{"href":"https://api.github.com/repos/puphpet/puphpet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puphpet/puphpet/pulls/1711/commits"},"statuses":{"href":"https://api.github.com/repos/puphpet/puphpet/statuses/40e704bcabc9bc7537ebaf19a510ce4bf7975c45"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":1,"changed_files":1}}