{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/29529944","id":29529944,"diff_hunk":"@@ -31,7 +31,9 @@\n     setTimingShapedCutsFlags  = cms.bool(True),\n     setTimingTrustFlags       = cms.bool(False), # timing flags currently only implemented for HF\n     setPulseShapeFlags        = cms.bool(True),\n-    setNegativeFlags          = cms.bool(True), # only in HBHE","path":"RecoLocalCalo/HcalRecProducers/python/HcalHitReconstructor_hbhe_cfi.py","position":4,"original_position":4,"commit_id":"4c6c7ec4c8aeb564b4a9b86c318575b9317f737d","original_commit_id":"4c6c7ec4c8aeb564b4a9b86c318575b9317f737d","user":{"login":"slava77","id":4676718,"avatar_url":"https://avatars.githubusercontent.com/u/4676718?v=3","gravatar_id":"","url":"https://api.github.com/users/slava77","html_url":"https://github.com/slava77","followers_url":"https://api.github.com/users/slava77/followers","following_url":"https://api.github.com/users/slava77/following{/other_user}","gists_url":"https://api.github.com/users/slava77/gists{/gist_id}","starred_url":"https://api.github.com/users/slava77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slava77/subscriptions","organizations_url":"https://api.github.com/users/slava77/orgs","repos_url":"https://api.github.com/users/slava77/repos","events_url":"https://api.github.com/users/slava77/events{/privacy}","received_events_url":"https://api.github.com/users/slava77/received_events","type":"User","site_admin":false},"body":"I meant to keep the setNegativeFlags uncommented and set the value to False.","created_at":"2015-05-01T20:12:18Z","updated_at":"2015-05-01T20:12:18Z","html_url":"https://github.com/cms-sw/cmssw/pull/8923#discussion_r29529944","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/8923","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/29529944"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/8923#discussion_r29529944"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/8923"}}},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/8923","id":34421370,"html_url":"https://github.com/cms-sw/cmssw/pull/8923","diff_url":"https://github.com/cms-sw/cmssw/pull/8923.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/8923.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/8923","number":8923,"state":"open","locked":false,"title":"Updated implementation of the HCAL negative energy filter","user":{"login":"igv4321","id":5552377,"avatar_url":"https://avatars.githubusercontent.com/u/5552377?v=3","gravatar_id":"","url":"https://api.github.com/users/igv4321","html_url":"https://github.com/igv4321","followers_url":"https://api.github.com/users/igv4321/followers","following_url":"https://api.github.com/users/igv4321/following{/other_user}","gists_url":"https://api.github.com/users/igv4321/gists{/gist_id}","starred_url":"https://api.github.com/users/igv4321/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igv4321/subscriptions","organizations_url":"https://api.github.com/users/igv4321/orgs","repos_url":"https://api.github.com/users/igv4321/repos","events_url":"https://api.github.com/users/igv4321/events{/privacy}","received_events_url":"https://api.github.com/users/igv4321/received_events","type":"User","site_admin":false},"body":"The filter is disabled for now, pending DropBox support for HBHENegativeEFilter objects.\r\n\r\nAlso, added a few forgotten \"delete\" statements to the HcalHitReconstructor destructor.\r\n","created_at":"2015-04-30T01:22:15Z","updated_at":"2015-05-01T20:12:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a385a2b3c900b0ea8670bba22a1e72e3fd670d9d","assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/51","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_7_5_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/51/labels","id":982516,"number":51,"title":"Next CMSSW_7_5_X","description":"","creator":{"login":"nclopezo","id":1944922,"avatar_url":"https://avatars.githubusercontent.com/u/1944922?v=3","gravatar_id":"","url":"https://api.github.com/users/nclopezo","html_url":"https://github.com/nclopezo","followers_url":"https://api.github.com/users/nclopezo/followers","following_url":"https://api.github.com/users/nclopezo/following{/other_user}","gists_url":"https://api.github.com/users/nclopezo/gists{/gist_id}","starred_url":"https://api.github.com/users/nclopezo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nclopezo/subscriptions","organizations_url":"https://api.github.com/users/nclopezo/orgs","repos_url":"https://api.github.com/users/nclopezo/repos","events_url":"https://api.github.com/users/nclopezo/events{/privacy}","received_events_url":"https://api.github.com/users/nclopezo/received_events","type":"User","site_admin":false},"open_issues":47,"closed_issues":486,"state":"open","created_at":"2015-02-17T08:21:25Z","updated_at":"2015-05-01T15:41:21Z","due_on":"2015-03-02T23:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/8923/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/8923/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/8923/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/4c6c7ec4c8aeb564b4a9b86c318575b9317f737d","head":{"label":"igv4321:negative-energy-filter-fix","ref":"negative-energy-filter-fix","sha":"4c6c7ec4c8aeb564b4a9b86c318575b9317f737d","user":{"login":"igv4321","id":5552377,"avatar_url":"https://avatars.githubusercontent.com/u/5552377?v=3","gravatar_id":"","url":"https://api.github.com/users/igv4321","html_url":"https://github.com/igv4321","followers_url":"https://api.github.com/users/igv4321/followers","following_url":"https://api.github.com/users/igv4321/following{/other_user}","gists_url":"https://api.github.com/users/igv4321/gists{/gist_id}","starred_url":"https://api.github.com/users/igv4321/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igv4321/subscriptions","organizations_url":"https://api.github.com/users/igv4321/orgs","repos_url":"https://api.github.com/users/igv4321/repos","events_url":"https://api.github.com/users/igv4321/events{/privacy}","received_events_url":"https://api.github.com/users/igv4321/received_events","type":"User","site_admin":false},"repo":{"id":18013692,"name":"cmssw","full_name":"igv4321/cmssw","owner":{"login":"igv4321","id":5552377,"avatar_url":"https://avatars.githubusercontent.com/u/5552377?v=3","gravatar_id":"","url":"https://api.github.com/users/igv4321","html_url":"https://github.com/igv4321","followers_url":"https://api.github.com/users/igv4321/followers","following_url":"https://api.github.com/users/igv4321/following{/other_user}","gists_url":"https://api.github.com/users/igv4321/gists{/gist_id}","starred_url":"https://api.github.com/users/igv4321/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igv4321/subscriptions","organizations_url":"https://api.github.com/users/igv4321/orgs","repos_url":"https://api.github.com/users/igv4321/repos","events_url":"https://api.github.com/users/igv4321/events{/privacy}","received_events_url":"https://api.github.com/users/igv4321/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/igv4321/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/igv4321/cmssw","forks_url":"https://api.github.com/repos/igv4321/cmssw/forks","keys_url":"https://api.github.com/repos/igv4321/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/igv4321/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/igv4321/cmssw/teams","hooks_url":"https://api.github.com/repos/igv4321/cmssw/hooks","issue_events_url":"https://api.github.com/repos/igv4321/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/igv4321/cmssw/events","assignees_url":"https://api.github.com/repos/igv4321/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/igv4321/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/igv4321/cmssw/tags","blobs_url":"https://api.github.com/repos/igv4321/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/igv4321/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/igv4321/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/igv4321/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/igv4321/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/igv4321/cmssw/languages","stargazers_url":"https://api.github.com/repos/igv4321/cmssw/stargazers","contributors_url":"https://api.github.com/repos/igv4321/cmssw/contributors","subscribers_url":"https://api.github.com/repos/igv4321/cmssw/subscribers","subscription_url":"https://api.github.com/repos/igv4321/cmssw/subscription","commits_url":"https://api.github.com/repos/igv4321/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/igv4321/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/igv4321/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/igv4321/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/igv4321/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/igv4321/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/igv4321/cmssw/merges","archive_url":"https://api.github.com/repos/igv4321/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/igv4321/cmssw/downloads","issues_url":"https://api.github.com/repos/igv4321/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/igv4321/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/igv4321/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/igv4321/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/igv4321/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/igv4321/cmssw/releases{/id}","created_at":"2014-03-22T16:11:12Z","updated_at":"2014-05-20T07:41:30Z","pushed_at":"2015-04-30T01:14:08Z","git_url":"git://github.com/igv4321/cmssw.git","ssh_url":"git@github.com:igv4321/cmssw.git","clone_url":"https://github.com/igv4321/cmssw.git","svn_url":"https://github.com/igv4321/cmssw","homepage":"cms-sw.github.io/cmssw","size":727727,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CMSSW_7_1_X"}},"base":{"label":"cms-sw:CMSSW_7_5_X","ref":"CMSSW_7_5_X","sha":"5b69297b9e4bc93821d3033e6c26e06c5fcd7a17","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","created_at":"2013-06-26T14:09:07Z","updated_at":"2015-05-01T17:07:53Z","pushed_at":"2015-05-01T17:06:22Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":968391,"stargazers_count":226,"watchers_count":226,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1373,"mirror_url":null,"open_issues_count":125,"forks":1373,"open_issues":125,"watchers":226,"default_branch":"CMSSW_7_5_X"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/8923"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/8923"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/8923"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/8923/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/8923/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/8923/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/4c6c7ec4c8aeb564b4a9b86c318575b9317f737d"}}}}