{"action":"created","issue":{"url":"https://api.github.com/repos/firstandthird/load-grunt-config/issues/129","labels_url":"https://api.github.com/repos/firstandthird/load-grunt-config/issues/129/labels{/name}","comments_url":"https://api.github.com/repos/firstandthird/load-grunt-config/issues/129/comments","events_url":"https://api.github.com/repos/firstandthird/load-grunt-config/issues/129/events","html_url":"https://github.com/firstandthird/load-grunt-config/pull/129","id":92742404,"number":129,"title":"[suggestion] use config-extend instead of _.merge by default","user":{"login":"jrit","id":1255823,"avatar_url":"https://avatars.githubusercontent.com/u/1255823?v=3","gravatar_id":"","url":"https://api.github.com/users/jrit","html_url":"https://github.com/jrit","followers_url":"https://api.github.com/users/jrit/followers","following_url":"https://api.github.com/users/jrit/following{/other_user}","gists_url":"https://api.github.com/users/jrit/gists{/gist_id}","starred_url":"https://api.github.com/users/jrit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrit/subscriptions","organizations_url":"https://api.github.com/users/jrit/orgs","repos_url":"https://api.github.com/users/jrit/repos","events_url":"https://api.github.com/users/jrit/events{/privacy}","received_events_url":"https://api.github.com/users/jrit/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-07-02T21:44:35Z","updated_at":"2015-07-18T21:02:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/firstandthird/load-grunt-config/pulls/129","html_url":"https://github.com/firstandthird/load-grunt-config/pull/129","diff_url":"https://github.com/firstandthird/load-grunt-config/pull/129.diff","patch_url":"https://github.com/firstandthird/load-grunt-config/pull/129.patch"},"body":"It took me a while today to figure out that when arrays were extended by `_.merge` they were basically replaced positionally. So, if I had one array for `src` that had 5 files in it and tried to replace it via `overrideConfig` with a task that had a `src` with 1 file, it ended up replacing the first item in `src` and keeping the other 4, when really the whole `src` array should have been replaced.\r\n\r\nI fixed this locally using `mergeFunction` but feel like the default behavior should be changed since right now I don't think it is doing what most people would expect it to do out of the box.\r\n\r\nThis update didn't break any tests, because there are no tests covering this situation. This is a minor behavioral change though so it should probably be a minor version bump if merged. If you'd be in favor of merging I can try and update the tests to cover this and prevent reversion."},"comment":{"url":"https://api.github.com/repos/firstandthird/load-grunt-config/issues/comments/122596969","html_url":"https://github.com/firstandthird/load-grunt-config/pull/129#issuecomment-122596969","issue_url":"https://api.github.com/repos/firstandthird/load-grunt-config/issues/129","id":122596969,"user":{"login":"jrit","id":1255823,"avatar_url":"https://avatars.githubusercontent.com/u/1255823?v=3","gravatar_id":"","url":"https://api.github.com/users/jrit","html_url":"https://github.com/jrit","followers_url":"https://api.github.com/users/jrit/followers","following_url":"https://api.github.com/users/jrit/following{/other_user}","gists_url":"https://api.github.com/users/jrit/gists{/gist_id}","starred_url":"https://api.github.com/users/jrit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrit/subscriptions","organizations_url":"https://api.github.com/users/jrit/orgs","repos_url":"https://api.github.com/users/jrit/repos","events_url":"https://api.github.com/users/jrit/events{/privacy}","received_events_url":"https://api.github.com/users/jrit/received_events","type":"User","site_admin":false},"created_at":"2015-07-18T21:02:35Z","updated_at":"2015-07-18T21:02:35Z","body":"I can include such a perf test as part of test updates if you have some useful metric in mind. I feel like including 50 tasks with a bunch of nested values would be enough, but what do you think?"}}