{"action":"created","comment":{"url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/pulls/comments/30129081","id":30129081,"diff_hunk":"@@ -711,6 +714,21 @@ - (void)resetContentViewScale\n     self.contentViewContainer.frame = frame;\n }\n \n+- (void)performInitialAppearanceTransitionCallsForControllerIfRequired:(UIViewController *)controller {\n+    if (controller.childViewControllers.count > 0) {\n+        [controller beginAppearanceTransition:YES animated:NO];\n+        [controller endAppearanceTransition];\n+        /**\n+         *  Must perform the disappear appearance transition in the next runloop\n+         *  otherwise iOS relaises that it doesn't need to calculate anything.","path":"RESideMenu/RESideMenuController.m","position":20,"original_position":20,"commit_id":"0797d5d19e80fc0d9dd6118f06fbffd54e2e9345","original_commit_id":"0797d5d19e80fc0d9dd6118f06fbffd54e2e9345","user":{"login":"dhardiman","id":272213,"avatar_url":"https://avatars.githubusercontent.com/u/272213?v=3","gravatar_id":"","url":"https://api.github.com/users/dhardiman","html_url":"https://github.com/dhardiman","followers_url":"https://api.github.com/users/dhardiman/followers","following_url":"https://api.github.com/users/dhardiman/following{/other_user}","gists_url":"https://api.github.com/users/dhardiman/gists{/gist_id}","starred_url":"https://api.github.com/users/dhardiman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhardiman/subscriptions","organizations_url":"https://api.github.com/users/dhardiman/orgs","repos_url":"https://api.github.com/users/dhardiman/repos","events_url":"https://api.github.com/users/dhardiman/events{/privacy}","received_events_url":"https://api.github.com/users/dhardiman/received_events","type":"User","site_admin":false},"body":"My sister used to work for relais.","created_at":"2015-05-12T12:42:26Z","updated_at":"2015-05-12T12:42:26Z","html_url":"https://github.com/OrdnanceSurvey/RESideMenu/pull/4#discussion_r30129081","pull_request_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/pulls/comments/30129081"},"html":{"href":"https://github.com/OrdnanceSurvey/RESideMenu/pull/4#discussion_r30129081"},"pull_request":{"href":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/pulls/4","id":35217573,"html_url":"https://github.com/OrdnanceSurvey/RESideMenu/pull/4","diff_url":"https://github.com/OrdnanceSurvey/RESideMenu/pull/4.diff","patch_url":"https://github.com/OrdnanceSurvey/RESideMenu/pull/4.patch","issue_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/issues/4","number":4,"state":"open","locked":false,"title":"Appearance glitch fix","user":{"login":"steveanthony","id":1941854,"avatar_url":"https://avatars.githubusercontent.com/u/1941854?v=3","gravatar_id":"","url":"https://api.github.com/users/steveanthony","html_url":"https://github.com/steveanthony","followers_url":"https://api.github.com/users/steveanthony/followers","following_url":"https://api.github.com/users/steveanthony/following{/other_user}","gists_url":"https://api.github.com/users/steveanthony/gists{/gist_id}","starred_url":"https://api.github.com/users/steveanthony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveanthony/subscriptions","organizations_url":"https://api.github.com/users/steveanthony/orgs","repos_url":"https://api.github.com/users/steveanthony/repos","events_url":"https://api.github.com/users/steveanthony/events{/privacy}","received_events_url":"https://api.github.com/users/steveanthony/received_events","type":"User","site_admin":false},"body":"You may have noticed when opening the side menu for the first time in OS Maps that the table appears to jump downwards when the \"open menu\" animation completes. This is because when it first appears, our navigation controller has not passed the height of its navigation bar to the `topLayoutGuide` of our side menu view controller, so our table is laid out with no top content inset set. When the animation finishes, the layout guide has been configured, and the table view is redrawn correctly, with the first row appearing 64 points down the screen so that it doesn't underlap the navigation bar.\r\nThe change in this PR checks the menu view controllers to see if they contain child view controllers. If they do, then they will likely benefit from having the layout guide environment configured before they are first displayed to the user. As such, we send the appearance transition begin / end messages to the controllers to force them to configure the environment. Once this has been done, then the first time a menu is shown to the user, it renders correctly.","created_at":"2015-05-12T11:39:36Z","updated_at":"2015-05-12T12:42:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"876a14732dadbfcc62f694a25c9ca0248c5053a8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/pulls/4/commits","review_comments_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/pulls/4/comments","review_comment_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/issues/4/comments","statuses_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/statuses/0797d5d19e80fc0d9dd6118f06fbffd54e2e9345","head":{"label":"OrdnanceSurvey:appearance_glitch_fix","ref":"appearance_glitch_fix","sha":"0797d5d19e80fc0d9dd6118f06fbffd54e2e9345","user":{"login":"OrdnanceSurvey","id":2436924,"avatar_url":"https://avatars.githubusercontent.com/u/2436924?v=3","gravatar_id":"","url":"https://api.github.com/users/OrdnanceSurvey","html_url":"https://github.com/OrdnanceSurvey","followers_url":"https://api.github.com/users/OrdnanceSurvey/followers","following_url":"https://api.github.com/users/OrdnanceSurvey/following{/other_user}","gists_url":"https://api.github.com/users/OrdnanceSurvey/gists{/gist_id}","starred_url":"https://api.github.com/users/OrdnanceSurvey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrdnanceSurvey/subscriptions","organizations_url":"https://api.github.com/users/OrdnanceSurvey/orgs","repos_url":"https://api.github.com/users/OrdnanceSurvey/repos","events_url":"https://api.github.com/users/OrdnanceSurvey/events{/privacy}","received_events_url":"https://api.github.com/users/OrdnanceSurvey/received_events","type":"Organization","site_admin":false},"repo":{"id":28906810,"name":"RESideMenu","full_name":"OrdnanceSurvey/RESideMenu","owner":{"login":"OrdnanceSurvey","id":2436924,"avatar_url":"https://avatars.githubusercontent.com/u/2436924?v=3","gravatar_id":"","url":"https://api.github.com/users/OrdnanceSurvey","html_url":"https://github.com/OrdnanceSurvey","followers_url":"https://api.github.com/users/OrdnanceSurvey/followers","following_url":"https://api.github.com/users/OrdnanceSurvey/following{/other_user}","gists_url":"https://api.github.com/users/OrdnanceSurvey/gists{/gist_id}","starred_url":"https://api.github.com/users/OrdnanceSurvey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrdnanceSurvey/subscriptions","organizations_url":"https://api.github.com/users/OrdnanceSurvey/orgs","repos_url":"https://api.github.com/users/OrdnanceSurvey/repos","events_url":"https://api.github.com/users/OrdnanceSurvey/events{/privacy}","received_events_url":"https://api.github.com/users/OrdnanceSurvey/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OrdnanceSurvey/RESideMenu","description":"iOS 7/8 style side menu with parallax effect.","fork":true,"url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu","forks_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/forks","keys_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/teams","hooks_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/hooks","issue_events_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/issues/events{/number}","events_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/events","assignees_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/assignees{/user}","branches_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/branches{/branch}","tags_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/tags","blobs_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/git/refs{/sha}","trees_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/statuses/{sha}","languages_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/languages","stargazers_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/stargazers","contributors_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/contributors","subscribers_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/subscribers","subscription_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/subscription","commits_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/commits{/sha}","git_commits_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/git/commits{/sha}","comments_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/comments{/number}","issue_comment_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/issues/comments{/number}","contents_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/contents/{+path}","compare_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/merges","archive_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/downloads","issues_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/issues{/number}","pulls_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/pulls{/number}","milestones_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/milestones{/number}","notifications_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/labels{/name}","releases_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/releases{/id}","created_at":"2015-01-07T09:00:00Z","updated_at":"2015-03-25T16:19:16Z","pushed_at":"2015-05-12T12:41:02Z","git_url":"git://github.com/OrdnanceSurvey/RESideMenu.git","ssh_url":"git@github.com:OrdnanceSurvey/RESideMenu.git","clone_url":"https://github.com/OrdnanceSurvey/RESideMenu.git","svn_url":"https://github.com/OrdnanceSurvey/RESideMenu","homepage":"","size":9030,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"OrdnanceSurvey:master","ref":"master","sha":"575ba0d608f5b4b0909475f8397bef4f4fed6508","user":{"login":"OrdnanceSurvey","id":2436924,"avatar_url":"https://avatars.githubusercontent.com/u/2436924?v=3","gravatar_id":"","url":"https://api.github.com/users/OrdnanceSurvey","html_url":"https://github.com/OrdnanceSurvey","followers_url":"https://api.github.com/users/OrdnanceSurvey/followers","following_url":"https://api.github.com/users/OrdnanceSurvey/following{/other_user}","gists_url":"https://api.github.com/users/OrdnanceSurvey/gists{/gist_id}","starred_url":"https://api.github.com/users/OrdnanceSurvey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrdnanceSurvey/subscriptions","organizations_url":"https://api.github.com/users/OrdnanceSurvey/orgs","repos_url":"https://api.github.com/users/OrdnanceSurvey/repos","events_url":"https://api.github.com/users/OrdnanceSurvey/events{/privacy}","received_events_url":"https://api.github.com/users/OrdnanceSurvey/received_events","type":"Organization","site_admin":false},"repo":{"id":28906810,"name":"RESideMenu","full_name":"OrdnanceSurvey/RESideMenu","owner":{"login":"OrdnanceSurvey","id":2436924,"avatar_url":"https://avatars.githubusercontent.com/u/2436924?v=3","gravatar_id":"","url":"https://api.github.com/users/OrdnanceSurvey","html_url":"https://github.com/OrdnanceSurvey","followers_url":"https://api.github.com/users/OrdnanceSurvey/followers","following_url":"https://api.github.com/users/OrdnanceSurvey/following{/other_user}","gists_url":"https://api.github.com/users/OrdnanceSurvey/gists{/gist_id}","starred_url":"https://api.github.com/users/OrdnanceSurvey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrdnanceSurvey/subscriptions","organizations_url":"https://api.github.com/users/OrdnanceSurvey/orgs","repos_url":"https://api.github.com/users/OrdnanceSurvey/repos","events_url":"https://api.github.com/users/OrdnanceSurvey/events{/privacy}","received_events_url":"https://api.github.com/users/OrdnanceSurvey/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OrdnanceSurvey/RESideMenu","description":"iOS 7/8 style side menu with parallax effect.","fork":true,"url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu","forks_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/forks","keys_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/teams","hooks_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/hooks","issue_events_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/issues/events{/number}","events_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/events","assignees_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/assignees{/user}","branches_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/branches{/branch}","tags_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/tags","blobs_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/git/refs{/sha}","trees_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/statuses/{sha}","languages_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/languages","stargazers_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/stargazers","contributors_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/contributors","subscribers_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/subscribers","subscription_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/subscription","commits_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/commits{/sha}","git_commits_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/git/commits{/sha}","comments_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/comments{/number}","issue_comment_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/issues/comments{/number}","contents_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/contents/{+path}","compare_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/merges","archive_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/downloads","issues_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/issues{/number}","pulls_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/pulls{/number}","milestones_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/milestones{/number}","notifications_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/labels{/name}","releases_url":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/releases{/id}","created_at":"2015-01-07T09:00:00Z","updated_at":"2015-03-25T16:19:16Z","pushed_at":"2015-05-12T12:41:02Z","git_url":"git://github.com/OrdnanceSurvey/RESideMenu.git","ssh_url":"git@github.com:OrdnanceSurvey/RESideMenu.git","clone_url":"https://github.com/OrdnanceSurvey/RESideMenu.git","svn_url":"https://github.com/OrdnanceSurvey/RESideMenu","homepage":"","size":9030,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/pulls/4"},"html":{"href":"https://github.com/OrdnanceSurvey/RESideMenu/pull/4"},"issue":{"href":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/issues/4"},"comments":{"href":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/OrdnanceSurvey/RESideMenu/statuses/0797d5d19e80fc0d9dd6118f06fbffd54e2e9345"}}}}