{"action":"created","issue":{"url":"https://api.github.com/repos/VoltDB/voltdb/issues/2868","labels_url":"https://api.github.com/repos/VoltDB/voltdb/issues/2868/labels{/name}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/issues/2868/comments","events_url":"https://api.github.com/repos/VoltDB/voltdb/issues/2868/events","html_url":"https://github.com/VoltDB/voltdb/pull/2868","id":109569689,"number":2868,"title":"Introduce the Google S2 library to the EE.","user":{"login":"BillWhite","id":924098,"avatar_url":"https://avatars.githubusercontent.com/u/924098?v=3","gravatar_id":"","url":"https://api.github.com/users/BillWhite","html_url":"https://github.com/BillWhite","followers_url":"https://api.github.com/users/BillWhite/followers","following_url":"https://api.github.com/users/BillWhite/following{/other_user}","gists_url":"https://api.github.com/users/BillWhite/gists{/gist_id}","starred_url":"https://api.github.com/users/BillWhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BillWhite/subscriptions","organizations_url":"https://api.github.com/users/BillWhite/orgs","repos_url":"https://api.github.com/users/BillWhite/repos","events_url":"https://api.github.com/users/BillWhite/events{/privacy}","received_events_url":"https://api.github.com/users/BillWhite/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-02T20:49:27Z","updated_at":"2015-10-05T14:14:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/VoltDB/voltdb/pulls/2868","html_url":"https://github.com/VoltDB/voltdb/pull/2868","diff_url":"https://github.com/VoltDB/voltdb/pull/2868.diff","patch_url":"https://github.com/VoltDB/voltdb/pull/2868.patch"},"body":"Most of the files in this changeset are the Google Test, Google Mock and Google S2 libraries.\r\nThe bulk of the changes to VoltDB files are in build.py and buildtools.py.  There are also some\r\nsmall changes in c++ files, but only a handful, and not significant changes.\r\n\r\n1. Added the sources to the Google S2 library to the EE.\r\n2. Made build.py and buildtools.py generate makefiles that call cmake and then make.\r\n3. Removed \"using namespace std\" in voltdbipc.cpp.  It causes misinterpretation of\r\n   the symbol \"bind\", and is unnecessary anyway.\r\n4. Add a phony call to an S2 function in geofunctions.cpp, to verify linking.\r\n5. The S2 include files are installed into obj/${build}/include/s2geo.  The\r\n   library is installed into obj/${build}/lib/libs2geo.a.\r\n6. Added the sources to google test and google mock.  The first is needed\r\n   to make the s2 tests.\r\n"},"comment":{"url":"https://api.github.com/repos/VoltDB/voltdb/issues/comments/145542210","html_url":"https://github.com/VoltDB/voltdb/pull/2868#issuecomment-145542210","issue_url":"https://api.github.com/repos/VoltDB/voltdb/issues/2868","id":145542210,"user":{"login":"BillWhite","id":924098,"avatar_url":"https://avatars.githubusercontent.com/u/924098?v=3","gravatar_id":"","url":"https://api.github.com/users/BillWhite","html_url":"https://github.com/BillWhite","followers_url":"https://api.github.com/users/BillWhite/followers","following_url":"https://api.github.com/users/BillWhite/following{/other_user}","gists_url":"https://api.github.com/users/BillWhite/gists{/gist_id}","starred_url":"https://api.github.com/users/BillWhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BillWhite/subscriptions","organizations_url":"https://api.github.com/users/BillWhite/orgs","repos_url":"https://api.github.com/users/BillWhite/repos","events_url":"https://api.github.com/users/BillWhite/events{/privacy}","received_events_url":"https://api.github.com/users/BillWhite/received_events","type":"User","site_admin":false},"created_at":"2015-10-05T14:14:15Z","updated_at":"2015-10-05T14:14:15Z","body":"I created ENG-9178 to help me remember to update the README.thirdparty file.\r\n"}}