{"action":"created","issue":{"url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/issues/1246","labels_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/issues/1246/labels{/name}","comments_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/issues/1246/comments","events_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/issues/1246/events","html_url":"https://github.com/SubtitleEdit/subtitleedit/pull/1246","id":105042220,"number":1246,"title":"Improve accuracy of spectrogram","user":{"login":"jdpurcell","id":6741660,"avatar_url":"https://avatars.githubusercontent.com/u/6741660?v=3","gravatar_id":"","url":"https://api.github.com/users/jdpurcell","html_url":"https://github.com/jdpurcell","followers_url":"https://api.github.com/users/jdpurcell/followers","following_url":"https://api.github.com/users/jdpurcell/following{/other_user}","gists_url":"https://api.github.com/users/jdpurcell/gists{/gist_id}","starred_url":"https://api.github.com/users/jdpurcell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdpurcell/subscriptions","organizations_url":"https://api.github.com/users/jdpurcell/orgs","repos_url":"https://api.github.com/users/jdpurcell/repos","events_url":"https://api.github.com/users/jdpurcell/events{/privacy}","received_events_url":"https://api.github.com/users/jdpurcell/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-05T18:31:00Z","updated_at":"2015-09-06T07:09:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/pulls/1246","html_url":"https://github.com/SubtitleEdit/subtitleedit/pull/1246","diff_url":"https://github.com/SubtitleEdit/subtitleedit/pull/1246.diff","patch_url":"https://github.com/SubtitleEdit/subtitleedit/pull/1246.patch"},"body":"The original spectrogram code applied a window function to each segment, but didn't do any overlapping to compensate for the signal loss near the edges. I've fixed that and the result is more peasant/accurate looking spectrogram images.\r\n\r\nAlso includes:\r\n* Clean up some unused fields in Info.xml (I did leave one unnecessary field however so that older versions can still read files generated by the new version).\r\n* Fixes to allow for FFT sizes other than 256 (not that it will actually be used, but just for the sake of correctness).\r\n* Save out GIF in a separate thread. For this reason, the code is yet again faster even though it's doing a bit more work with the overlapping."},"comment":{"url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/issues/comments/138048888","html_url":"https://github.com/SubtitleEdit/subtitleedit/pull/1246#issuecomment-138048888","issue_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/issues/1246","id":138048888,"user":{"login":"niksedk","id":1261331,"avatar_url":"https://avatars.githubusercontent.com/u/1261331?v=3","gravatar_id":"","url":"https://api.github.com/users/niksedk","html_url":"https://github.com/niksedk","followers_url":"https://api.github.com/users/niksedk/followers","following_url":"https://api.github.com/users/niksedk/following{/other_user}","gists_url":"https://api.github.com/users/niksedk/gists{/gist_id}","starred_url":"https://api.github.com/users/niksedk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niksedk/subscriptions","organizations_url":"https://api.github.com/users/niksedk/orgs","repos_url":"https://api.github.com/users/niksedk/repos","events_url":"https://api.github.com/users/niksedk/events{/privacy}","received_events_url":"https://api.github.com/users/niksedk/received_events","type":"User","site_admin":false},"created_at":"2015-09-06T07:09:02Z","updated_at":"2015-09-06T07:09:02Z","body":"Sorry, I've changed a bit in AudioVisualizer too - could you rebase?"}}