{"action":"created","comment":{"url":"https://api.github.com/repos/geotools/geotools/pulls/comments/43570133","id":43570133,"diff_hunk":"@@ -520,6 +520,29 @@ public void testFidFilter() throws Exception {\n         ds.dispose();\n     }\n     \n+    @Test\n+    public void testGeometryFilter() throws Exception {\n+        File shpFile = copyShapefiles(STREAM);\n+        URL url = shpFile.toURI().toURL();\n+        ShapefileDataStore ds = new ShapefileDataStore(url);\n+        SimpleFeatureSource featureSource = ds.getFeatureSource();\n+        SimpleFeatureCollection features;// = featureSource.getFeatures();\n+        \n+\n+        \n+        GeometryFactory geometryFactory = new GeometryFactory();\n+        Coordinate coordinate = new Coordinate(-99.0,38.0);\n+        Point p = geometryFactory.createPoint(coordinate);\n+        FilterFactory2 ff = CommonFactoryFinder.getFilterFactory2(null);\n+        final Filter testFilter = ff.intersects(ff.literal(p), ff.property(\"the_geom\"));\n+        System.out.println(testFilter);","path":"modules/plugin/shapefile/src/test/java/org/geotools/data/shapefile/ShapefileDataStoreTest.java","position":19,"original_position":19,"commit_id":"15675660fa8a3d2f3597212c55d83dd7f08ec16e","original_commit_id":"15675660fa8a3d2f3597212c55d83dd7f08ec16e","user":{"login":"aaime","id":325433,"avatar_url":"https://avatars.githubusercontent.com/u/325433?v=3","gravatar_id":"","url":"https://api.github.com/users/aaime","html_url":"https://github.com/aaime","followers_url":"https://api.github.com/users/aaime/followers","following_url":"https://api.github.com/users/aaime/following{/other_user}","gists_url":"https://api.github.com/users/aaime/gists{/gist_id}","starred_url":"https://api.github.com/users/aaime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaime/subscriptions","organizations_url":"https://api.github.com/users/aaime/orgs","repos_url":"https://api.github.com/users/aaime/repos","events_url":"https://api.github.com/users/aaime/events{/privacy}","received_events_url":"https://api.github.com/users/aaime/received_events","type":"User","site_admin":false},"body":"No system.out in tests please (I use the too, but try to remember to comment them out before committing)","created_at":"2015-10-31T09:55:09Z","updated_at":"2015-10-31T09:55:09Z","html_url":"https://github.com/geotools/geotools/pull/1025#discussion_r43570133","pull_request_url":"https://api.github.com/repos/geotools/geotools/pulls/1025","_links":{"self":{"href":"https://api.github.com/repos/geotools/geotools/pulls/comments/43570133"},"html":{"href":"https://github.com/geotools/geotools/pull/1025#discussion_r43570133"},"pull_request":{"href":"https://api.github.com/repos/geotools/geotools/pulls/1025"}}},"pull_request":{"url":"https://api.github.com/repos/geotools/geotools/pulls/1025","id":49135887,"html_url":"https://github.com/geotools/geotools/pull/1025","diff_url":"https://github.com/geotools/geotools/pull/1025.diff","patch_url":"https://github.com/geotools/geotools/pull/1025.patch","issue_url":"https://api.github.com/repos/geotools/geotools/issues/1025","number":1025,"state":"open","locked":false,"title":"fix for ShapefileReader NPE [GEOT-5262]","user":{"login":"ianturton","id":122529,"avatar_url":"https://avatars.githubusercontent.com/u/122529?v=3","gravatar_id":"","url":"https://api.github.com/users/ianturton","html_url":"https://github.com/ianturton","followers_url":"https://api.github.com/users/ianturton/followers","following_url":"https://api.github.com/users/ianturton/following{/other_user}","gists_url":"https://api.github.com/users/ianturton/gists{/gist_id}","starred_url":"https://api.github.com/users/ianturton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianturton/subscriptions","organizations_url":"https://api.github.com/users/ianturton/orgs","repos_url":"https://api.github.com/users/ianturton/repos","events_url":"https://api.github.com/users/ianturton/events{/privacy}","received_events_url":"https://api.github.com/users/ianturton/received_events","type":"User","site_admin":false},"body":"Fix issue with null bounding box for some filters in ShapefileReader. See https://osgeo-org.atlassian.net/projects/GEOT/issues/GEOT-5262","created_at":"2015-10-29T13:02:19Z","updated_at":"2015-10-31T09:55:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d78b30a5273f19f4c2cc90f98fdc167981d42d7","assignee":{"login":"aaime","id":325433,"avatar_url":"https://avatars.githubusercontent.com/u/325433?v=3","gravatar_id":"","url":"https://api.github.com/users/aaime","html_url":"https://github.com/aaime","followers_url":"https://api.github.com/users/aaime/followers","following_url":"https://api.github.com/users/aaime/following{/other_user}","gists_url":"https://api.github.com/users/aaime/gists{/gist_id}","starred_url":"https://api.github.com/users/aaime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaime/subscriptions","organizations_url":"https://api.github.com/users/aaime/orgs","repos_url":"https://api.github.com/users/aaime/repos","events_url":"https://api.github.com/users/aaime/events{/privacy}","received_events_url":"https://api.github.com/users/aaime/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/geotools/geotools/pulls/1025/commits","review_comments_url":"https://api.github.com/repos/geotools/geotools/pulls/1025/comments","review_comment_url":"https://api.github.com/repos/geotools/geotools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/geotools/geotools/issues/1025/comments","statuses_url":"https://api.github.com/repos/geotools/geotools/statuses/15675660fa8a3d2f3597212c55d83dd7f08ec16e","head":{"label":"ianturton:GEOT-5262","ref":"GEOT-5262","sha":"15675660fa8a3d2f3597212c55d83dd7f08ec16e","user":{"login":"ianturton","id":122529,"avatar_url":"https://avatars.githubusercontent.com/u/122529?v=3","gravatar_id":"","url":"https://api.github.com/users/ianturton","html_url":"https://github.com/ianturton","followers_url":"https://api.github.com/users/ianturton/followers","following_url":"https://api.github.com/users/ianturton/following{/other_user}","gists_url":"https://api.github.com/users/ianturton/gists{/gist_id}","starred_url":"https://api.github.com/users/ianturton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianturton/subscriptions","organizations_url":"https://api.github.com/users/ianturton/orgs","repos_url":"https://api.github.com/users/ianturton/repos","events_url":"https://api.github.com/users/ianturton/events{/privacy}","received_events_url":"https://api.github.com/users/ianturton/received_events","type":"User","site_admin":false},"repo":{"id":17866824,"name":"geotools","full_name":"ianturton/geotools","owner":{"login":"ianturton","id":122529,"avatar_url":"https://avatars.githubusercontent.com/u/122529?v=3","gravatar_id":"","url":"https://api.github.com/users/ianturton","html_url":"https://github.com/ianturton","followers_url":"https://api.github.com/users/ianturton/followers","following_url":"https://api.github.com/users/ianturton/following{/other_user}","gists_url":"https://api.github.com/users/ianturton/gists{/gist_id}","starred_url":"https://api.github.com/users/ianturton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianturton/subscriptions","organizations_url":"https://api.github.com/users/ianturton/orgs","repos_url":"https://api.github.com/users/ianturton/repos","events_url":"https://api.github.com/users/ianturton/events{/privacy}","received_events_url":"https://api.github.com/users/ianturton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ianturton/geotools","description":"Official GeoTools repository","fork":true,"url":"https://api.github.com/repos/ianturton/geotools","forks_url":"https://api.github.com/repos/ianturton/geotools/forks","keys_url":"https://api.github.com/repos/ianturton/geotools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ianturton/geotools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ianturton/geotools/teams","hooks_url":"https://api.github.com/repos/ianturton/geotools/hooks","issue_events_url":"https://api.github.com/repos/ianturton/geotools/issues/events{/number}","events_url":"https://api.github.com/repos/ianturton/geotools/events","assignees_url":"https://api.github.com/repos/ianturton/geotools/assignees{/user}","branches_url":"https://api.github.com/repos/ianturton/geotools/branches{/branch}","tags_url":"https://api.github.com/repos/ianturton/geotools/tags","blobs_url":"https://api.github.com/repos/ianturton/geotools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ianturton/geotools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ianturton/geotools/git/refs{/sha}","trees_url":"https://api.github.com/repos/ianturton/geotools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ianturton/geotools/statuses/{sha}","languages_url":"https://api.github.com/repos/ianturton/geotools/languages","stargazers_url":"https://api.github.com/repos/ianturton/geotools/stargazers","contributors_url":"https://api.github.com/repos/ianturton/geotools/contributors","subscribers_url":"https://api.github.com/repos/ianturton/geotools/subscribers","subscription_url":"https://api.github.com/repos/ianturton/geotools/subscription","commits_url":"https://api.github.com/repos/ianturton/geotools/commits{/sha}","git_commits_url":"https://api.github.com/repos/ianturton/geotools/git/commits{/sha}","comments_url":"https://api.github.com/repos/ianturton/geotools/comments{/number}","issue_comment_url":"https://api.github.com/repos/ianturton/geotools/issues/comments{/number}","contents_url":"https://api.github.com/repos/ianturton/geotools/contents/{+path}","compare_url":"https://api.github.com/repos/ianturton/geotools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ianturton/geotools/merges","archive_url":"https://api.github.com/repos/ianturton/geotools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ianturton/geotools/downloads","issues_url":"https://api.github.com/repos/ianturton/geotools/issues{/number}","pulls_url":"https://api.github.com/repos/ianturton/geotools/pulls{/number}","milestones_url":"https://api.github.com/repos/ianturton/geotools/milestones{/number}","notifications_url":"https://api.github.com/repos/ianturton/geotools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ianturton/geotools/labels{/name}","releases_url":"https://api.github.com/repos/ianturton/geotools/releases{/id}","created_at":"2014-03-18T13:32:30Z","updated_at":"2015-05-02T16:50:57Z","pushed_at":"2015-10-29T13:38:15Z","git_url":"git://github.com/ianturton/geotools.git","ssh_url":"git@github.com:ianturton/geotools.git","clone_url":"https://github.com/ianturton/geotools.git","svn_url":"https://github.com/ianturton/geotools","homepage":"http://geotools.org","size":110942,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"geotools:master","ref":"master","sha":"e6677fc5685f11f44677c2739f44c6da96e8dc67","user":{"login":"geotools","id":1187031,"avatar_url":"https://avatars.githubusercontent.com/u/1187031?v=3","gravatar_id":"","url":"https://api.github.com/users/geotools","html_url":"https://github.com/geotools","followers_url":"https://api.github.com/users/geotools/followers","following_url":"https://api.github.com/users/geotools/following{/other_user}","gists_url":"https://api.github.com/users/geotools/gists{/gist_id}","starred_url":"https://api.github.com/users/geotools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geotools/subscriptions","organizations_url":"https://api.github.com/users/geotools/orgs","repos_url":"https://api.github.com/users/geotools/repos","events_url":"https://api.github.com/users/geotools/events{/privacy}","received_events_url":"https://api.github.com/users/geotools/received_events","type":"Organization","site_admin":false},"repo":{"id":2752522,"name":"geotools","full_name":"geotools/geotools","owner":{"login":"geotools","id":1187031,"avatar_url":"https://avatars.githubusercontent.com/u/1187031?v=3","gravatar_id":"","url":"https://api.github.com/users/geotools","html_url":"https://github.com/geotools","followers_url":"https://api.github.com/users/geotools/followers","following_url":"https://api.github.com/users/geotools/following{/other_user}","gists_url":"https://api.github.com/users/geotools/gists{/gist_id}","starred_url":"https://api.github.com/users/geotools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geotools/subscriptions","organizations_url":"https://api.github.com/users/geotools/orgs","repos_url":"https://api.github.com/users/geotools/repos","events_url":"https://api.github.com/users/geotools/events{/privacy}","received_events_url":"https://api.github.com/users/geotools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geotools/geotools","description":"Official GeoTools repository","fork":false,"url":"https://api.github.com/repos/geotools/geotools","forks_url":"https://api.github.com/repos/geotools/geotools/forks","keys_url":"https://api.github.com/repos/geotools/geotools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geotools/geotools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geotools/geotools/teams","hooks_url":"https://api.github.com/repos/geotools/geotools/hooks","issue_events_url":"https://api.github.com/repos/geotools/geotools/issues/events{/number}","events_url":"https://api.github.com/repos/geotools/geotools/events","assignees_url":"https://api.github.com/repos/geotools/geotools/assignees{/user}","branches_url":"https://api.github.com/repos/geotools/geotools/branches{/branch}","tags_url":"https://api.github.com/repos/geotools/geotools/tags","blobs_url":"https://api.github.com/repos/geotools/geotools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geotools/geotools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geotools/geotools/git/refs{/sha}","trees_url":"https://api.github.com/repos/geotools/geotools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geotools/geotools/statuses/{sha}","languages_url":"https://api.github.com/repos/geotools/geotools/languages","stargazers_url":"https://api.github.com/repos/geotools/geotools/stargazers","contributors_url":"https://api.github.com/repos/geotools/geotools/contributors","subscribers_url":"https://api.github.com/repos/geotools/geotools/subscribers","subscription_url":"https://api.github.com/repos/geotools/geotools/subscription","commits_url":"https://api.github.com/repos/geotools/geotools/commits{/sha}","git_commits_url":"https://api.github.com/repos/geotools/geotools/git/commits{/sha}","comments_url":"https://api.github.com/repos/geotools/geotools/comments{/number}","issue_comment_url":"https://api.github.com/repos/geotools/geotools/issues/comments{/number}","contents_url":"https://api.github.com/repos/geotools/geotools/contents/{+path}","compare_url":"https://api.github.com/repos/geotools/geotools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geotools/geotools/merges","archive_url":"https://api.github.com/repos/geotools/geotools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geotools/geotools/downloads","issues_url":"https://api.github.com/repos/geotools/geotools/issues{/number}","pulls_url":"https://api.github.com/repos/geotools/geotools/pulls{/number}","milestones_url":"https://api.github.com/repos/geotools/geotools/milestones{/number}","notifications_url":"https://api.github.com/repos/geotools/geotools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geotools/geotools/labels{/name}","releases_url":"https://api.github.com/repos/geotools/geotools/releases{/id}","created_at":"2011-11-10T23:22:12Z","updated_at":"2015-10-29T14:02:28Z","pushed_at":"2015-10-30T18:45:04Z","git_url":"git://github.com/geotools/geotools.git","ssh_url":"git@github.com:geotools/geotools.git","clone_url":"https://github.com/geotools/geotools.git","svn_url":"https://github.com/geotools/geotools","homepage":"http://geotools.org","size":259334,"stargazers_count":232,"watchers_count":232,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":363,"mirror_url":null,"open_issues_count":19,"forks":363,"open_issues":19,"watchers":232,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geotools/geotools/pulls/1025"},"html":{"href":"https://github.com/geotools/geotools/pull/1025"},"issue":{"href":"https://api.github.com/repos/geotools/geotools/issues/1025"},"comments":{"href":"https://api.github.com/repos/geotools/geotools/issues/1025/comments"},"review_comments":{"href":"https://api.github.com/repos/geotools/geotools/pulls/1025/comments"},"review_comment":{"href":"https://api.github.com/repos/geotools/geotools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/geotools/geotools/pulls/1025/commits"},"statuses":{"href":"https://api.github.com/repos/geotools/geotools/statuses/15675660fa8a3d2f3597212c55d83dd7f08ec16e"}}}}