{"action":"created","issue":{"url":"https://api.github.com/repos/concrete5/concrete5-legacy/issues/1927","labels_url":"https://api.github.com/repos/concrete5/concrete5-legacy/issues/1927/labels{/name}","comments_url":"https://api.github.com/repos/concrete5/concrete5-legacy/issues/1927/comments","events_url":"https://api.github.com/repos/concrete5/concrete5-legacy/issues/1927/events","html_url":"https://github.com/concrete5/concrete5-legacy/pull/1927","id":115569708,"number":1927,"title":"Php7 fixes","user":{"login":"Remo","id":129864,"avatar_url":"https://avatars.githubusercontent.com/u/129864?v=3","gravatar_id":"","url":"https://api.github.com/users/Remo","html_url":"https://github.com/Remo","followers_url":"https://api.github.com/users/Remo/followers","following_url":"https://api.github.com/users/Remo/following{/other_user}","gists_url":"https://api.github.com/users/Remo/gists{/gist_id}","starred_url":"https://api.github.com/users/Remo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Remo/subscriptions","organizations_url":"https://api.github.com/users/Remo/orgs","repos_url":"https://api.github.com/users/Remo/repos","events_url":"https://api.github.com/users/Remo/events{/privacy}","received_events_url":"https://api.github.com/users/Remo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-06T19:20:29Z","updated_at":"2015-11-12T13:13:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/concrete5/concrete5-legacy/pulls/1927","html_url":"https://github.com/concrete5/concrete5-legacy/pull/1927","diff_url":"https://github.com/concrete5/concrete5-legacy/pull/1927.diff","patch_url":"https://github.com/concrete5/concrete5-legacy/pull/1927.patch"},"body":"replaces #1917\r\n\r\nuse at your own risk! Those changes aren't made the proper way, this is merely a preview and not recommended for production! See comments by Korvin over here https://github.com/concrete5/concrete5-legacy/pull/1917#issuecomment-155906027\r\n\r\n- [x] Fix https://github.com/concrete5/concrete5-legacy/pull/1564/files#r44568992\r\n- [ ] Fix warnings the proper way"},"comment":{"url":"https://api.github.com/repos/concrete5/concrete5-legacy/issues/comments/156099552","html_url":"https://github.com/concrete5/concrete5-legacy/pull/1927#issuecomment-156099552","issue_url":"https://api.github.com/repos/concrete5/concrete5-legacy/issues/1927","id":156099552,"user":{"login":"Remo","id":129864,"avatar_url":"https://avatars.githubusercontent.com/u/129864?v=3","gravatar_id":"","url":"https://api.github.com/users/Remo","html_url":"https://github.com/Remo","followers_url":"https://api.github.com/users/Remo/followers","following_url":"https://api.github.com/users/Remo/following{/other_user}","gists_url":"https://api.github.com/users/Remo/gists{/gist_id}","starred_url":"https://api.github.com/users/Remo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Remo/subscriptions","organizations_url":"https://api.github.com/users/Remo/orgs","repos_url":"https://api.github.com/users/Remo/repos","events_url":"https://api.github.com/users/Remo/events{/privacy}","received_events_url":"https://api.github.com/users/Remo/received_events","type":"User","site_admin":false},"created_at":"2015-11-12T13:13:43Z","updated_at":"2015-11-12T13:13:43Z","body":"I had a quick look at what would be required to keep warnings on. Right at the first page I see 4 warnings:\r\n\r\n```\r\nWarning: Declaration of Concrete5_Model_Page::add(CollectionType $ct, $data) should be compatible with Concrete5_Model_Collection::add($data) \r\nWarning: Declaration of Concrete5_Model_Page::duplicate($nc, $preserveUserID = false) should be compatible with Concrete5_Model_Collection::duplicate()\r\nWarning: Declaration of Concrete5_Model_CollectionAttributeKey::getList() should be compatible with Concrete5_Model_AttributeKey::getList($akCategoryHandle, $filters = Array)\r\nWarning: Declaration of Concrete5_Model_CollectionAttributeKey::add($at, $args, $pkg = false) should be compatible with Concrete5_Model_AttributeKey::add($akCategoryHandle, $type, $args, $pkg = false)\r\n```\r\n\r\nWe could use dynamic arguments and then check which one have a value and do the magic. Super ugly.. We could remove some of the methods in the parent class or rename them, but that will most likely break a few things.\r\n\r\nIf anyone has a better suggestion, please let me know!"}}