{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/pulls/comments/36630658","id":36630658,"diff_hunk":"@@ -877,10 +877,10 @@ def filter_to_check(filter_name,filter_value,filter_exist)\n end\n \n Then /I am on a page with '(.*)' in search summary text$/ do |value|\n+  find(:xpath, \"//*[@class='search-summary']/em[1]\").text().should == normalize_whitespace(value)","path":"features/step_definitions/journey_test_steps.rb","position":4,"original_position":4,"commit_id":"f14a3fabd23bf89ce5e983946b1bb82cfddf33e1","original_commit_id":"f14a3fabd23bf89ce5e983946b1bb82cfddf33e1","user":{"login":"allait","id":246664,"avatar_url":"https://avatars.githubusercontent.com/u/246664?v=3","gravatar_id":"","url":"https://api.github.com/users/allait","html_url":"https://github.com/allait","followers_url":"https://api.github.com/users/allait/followers","following_url":"https://api.github.com/users/allait/following{/other_user}","gists_url":"https://api.github.com/users/allait/gists{/gist_id}","starred_url":"https://api.github.com/users/allait/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allait/subscriptions","organizations_url":"https://api.github.com/users/allait/orgs","repos_url":"https://api.github.com/users/allait/repos","events_url":"https://api.github.com/users/allait/events{/privacy}","received_events_url":"https://api.github.com/users/allait/received_events","type":"User","site_admin":false},"body":"There's an explanation in the commit message. It's not the first time we run into this, but I don't think a comment with \"find should be the first check\" in this step would help with similar issues in others (i.e. it won't be any more noticeable than a commit message)","created_at":"2015-08-10T13:35:38Z","updated_at":"2015-08-10T13:35:38Z","html_url":"https://github.com/alphagov/digitalmarketplace-functional-tests/pull/49#discussion_r36630658","pull_request_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/pulls/49","_links":{"self":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/pulls/comments/36630658"},"html":{"href":"https://github.com/alphagov/digitalmarketplace-functional-tests/pull/49#discussion_r36630658"},"pull_request":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/pulls/49","id":42005117,"html_url":"https://github.com/alphagov/digitalmarketplace-functional-tests/pull/49","diff_url":"https://github.com/alphagov/digitalmarketplace-functional-tests/pull/49.diff","patch_url":"https://github.com/alphagov/digitalmarketplace-functional-tests/pull/49.patch","issue_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/issues/49","number":49,"state":"open","locked":false,"title":"Fix smoke tests race condition on summary text check","user":{"login":"allait","id":246664,"avatar_url":"https://avatars.githubusercontent.com/u/246664?v=3","gravatar_id":"","url":"https://api.github.com/users/allait","html_url":"https://github.com/allait","followers_url":"https://api.github.com/users/allait/followers","following_url":"https://api.github.com/users/allait/following{/other_user}","gists_url":"https://api.github.com/users/allait/gists{/gist_id}","starred_url":"https://api.github.com/users/allait/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allait/subscriptions","organizations_url":"https://api.github.com/users/allait/orgs","repos_url":"https://api.github.com/users/allait/repos","events_url":"https://api.github.com/users/allait/events{/privacy}","received_events_url":"https://api.github.com/users/allait/received_events","type":"User","site_admin":false},"body":"Capybara current_url access doesn't wait for page to load, so the\r\nURL comparison can fail due to page load timing issues.\r\n\r\nUsing `find` blocks the step until the element is present on a page,\r\nat which point the page was loaded and the `current_url` should be\r\nup to date.","created_at":"2015-08-10T10:16:11Z","updated_at":"2015-08-10T13:35:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe25ee547b15a2843c159c561549c82ee04f050b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/pulls/49/commits","review_comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/pulls/49/comments","review_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/issues/49/comments","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/statuses/f14a3fabd23bf89ce5e983946b1bb82cfddf33e1","head":{"label":"alphagov:fix-smoke-test-summary-timing","ref":"fix-smoke-test-summary-timing","sha":"f14a3fabd23bf89ce5e983946b1bb82cfddf33e1","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":31654958,"name":"digitalmarketplace-functional-tests","full_name":"alphagov/digitalmarketplace-functional-tests","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/digitalmarketplace-functional-tests","description":"BDD tests for the digital marketplace suite of applications.","fork":false,"url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests","forks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/forks","keys_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/teams","hooks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/hooks","issue_events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/events","assignees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/tags","blobs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/languages","stargazers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/stargazers","contributors_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/contributors","subscribers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/subscribers","subscription_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/subscription","commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/merges","archive_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/downloads","issues_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/releases{/id}","created_at":"2015-03-04T12:04:09Z","updated_at":"2015-04-24T08:57:33Z","pushed_at":"2015-08-10T11:02:00Z","git_url":"git://github.com/alphagov/digitalmarketplace-functional-tests.git","ssh_url":"git@github.com:alphagov/digitalmarketplace-functional-tests.git","clone_url":"https://github.com/alphagov/digitalmarketplace-functional-tests.git","svn_url":"https://github.com/alphagov/digitalmarketplace-functional-tests","homepage":null,"size":776,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"83006c672f212ce4a4341e97c9cd0aff4daadd86","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":31654958,"name":"digitalmarketplace-functional-tests","full_name":"alphagov/digitalmarketplace-functional-tests","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/digitalmarketplace-functional-tests","description":"BDD tests for the digital marketplace suite of applications.","fork":false,"url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests","forks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/forks","keys_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/teams","hooks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/hooks","issue_events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/events","assignees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/tags","blobs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/languages","stargazers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/stargazers","contributors_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/contributors","subscribers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/subscribers","subscription_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/subscription","commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/merges","archive_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/downloads","issues_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/releases{/id}","created_at":"2015-03-04T12:04:09Z","updated_at":"2015-04-24T08:57:33Z","pushed_at":"2015-08-10T11:02:00Z","git_url":"git://github.com/alphagov/digitalmarketplace-functional-tests.git","ssh_url":"git@github.com:alphagov/digitalmarketplace-functional-tests.git","clone_url":"https://github.com/alphagov/digitalmarketplace-functional-tests.git","svn_url":"https://github.com/alphagov/digitalmarketplace-functional-tests","homepage":null,"size":776,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/pulls/49"},"html":{"href":"https://github.com/alphagov/digitalmarketplace-functional-tests/pull/49"},"issue":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/issues/49"},"comments":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-functional-tests/statuses/f14a3fabd23bf89ce5e983946b1bb82cfddf33e1"}}}}