{"action":"created","comment":{"url":"https://api.github.com/repos/benoitc/gunicorn/pulls/comments/34917578","id":34917578,"diff_hunk":"@@ -424,7 +425,7 @@ def murder_workers(self):\n         \"\"\"\n         if not self.timeout:\n             return\n-        workers = list(self.WORKERS.items())\n+        workers = list(self.WORKERS.items() + self.DYING_WORKERS.items())","path":"gunicorn/arbiter.py","position":null,"original_position":22,"commit_id":"dd02dca05428087a37eb08d0d4a7d3bcabd82ff5","original_commit_id":"e5307a4b9473c473dd42fe32b1fc69b3f23ad000","user":{"login":"erydo","id":447615,"avatar_url":"https://avatars.githubusercontent.com/u/447615?v=3","gravatar_id":"","url":"https://api.github.com/users/erydo","html_url":"https://github.com/erydo","followers_url":"https://api.github.com/users/erydo/followers","following_url":"https://api.github.com/users/erydo/following{/other_user}","gists_url":"https://api.github.com/users/erydo/gists{/gist_id}","starred_url":"https://api.github.com/users/erydo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erydo/subscriptions","organizations_url":"https://api.github.com/users/erydo/orgs","repos_url":"https://api.github.com/users/erydo/repos","events_url":"https://api.github.com/users/erydo/events{/privacy}","received_events_url":"https://api.github.com/users/erydo/received_events","type":"User","site_admin":false},"body":"Fixed, thank you!","created_at":"2015-07-17T18:27:52Z","updated_at":"2015-07-17T18:27:52Z","html_url":"https://github.com/benoitc/gunicorn/pull/1084#discussion_r34917578","pull_request_url":"https://api.github.com/repos/benoitc/gunicorn/pulls/1084","_links":{"self":{"href":"https://api.github.com/repos/benoitc/gunicorn/pulls/comments/34917578"},"html":{"href":"https://github.com/benoitc/gunicorn/pull/1084#discussion_r34917578"},"pull_request":{"href":"https://api.github.com/repos/benoitc/gunicorn/pulls/1084"}}},"pull_request":{"url":"https://api.github.com/repos/benoitc/gunicorn/pulls/1084","id":39860294,"html_url":"https://github.com/benoitc/gunicorn/pull/1084","diff_url":"https://github.com/benoitc/gunicorn/pull/1084.diff","patch_url":"https://github.com/benoitc/gunicorn/pull/1084.patch","issue_url":"https://api.github.com/repos/benoitc/gunicorn/issues/1084","number":1084,"state":"open","locked":false,"title":"Remove dead workers immediately after killing.","user":{"login":"erydo","id":447615,"avatar_url":"https://avatars.githubusercontent.com/u/447615?v=3","gravatar_id":"","url":"https://api.github.com/users/erydo","html_url":"https://github.com/erydo","followers_url":"https://api.github.com/users/erydo/followers","following_url":"https://api.github.com/users/erydo/following{/other_user}","gists_url":"https://api.github.com/users/erydo/gists{/gist_id}","starred_url":"https://api.github.com/users/erydo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erydo/subscriptions","organizations_url":"https://api.github.com/users/erydo/orgs","repos_url":"https://api.github.com/users/erydo/repos","events_url":"https://api.github.com/users/erydo/events{/privacy}","received_events_url":"https://api.github.com/users/erydo/received_events","type":"User","site_admin":false},"body":"This also organizes the shared \"worker cleanup\" operations like closing `worker.tmp` and calling `self.cfg.worker_exit`.\r\n\r\nThis means that `self.WORKERS` will always be updated after spawning/killing, and may only be out of sync due to unknown dead processes (handled in `reap_workers`).\r\n\r\nThis was done based on conversation in #1078. The original suggestion was to maintain a dead worker list ~~but I believe that this is a little simpler and accomplishes the same thing.~~ and I eventually came to the same conclusion.","created_at":"2015-07-13T21:46:20Z","updated_at":"2015-07-17T18:27:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b57fa1b9ce2f89b59c279347baeeaa36abb2b78","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/benoitc/gunicorn/pulls/1084/commits","review_comments_url":"https://api.github.com/repos/benoitc/gunicorn/pulls/1084/comments","review_comment_url":"https://api.github.com/repos/benoitc/gunicorn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/benoitc/gunicorn/issues/1084/comments","statuses_url":"https://api.github.com/repos/benoitc/gunicorn/statuses/dd02dca05428087a37eb08d0d4a7d3bcabd82ff5","head":{"label":"preo:cleanup-async-reaping","ref":"cleanup-async-reaping","sha":"dd02dca05428087a37eb08d0d4a7d3bcabd82ff5","user":{"login":"preo","id":1356550,"avatar_url":"https://avatars.githubusercontent.com/u/1356550?v=3","gravatar_id":"","url":"https://api.github.com/users/preo","html_url":"https://github.com/preo","followers_url":"https://api.github.com/users/preo/followers","following_url":"https://api.github.com/users/preo/following{/other_user}","gists_url":"https://api.github.com/users/preo/gists{/gist_id}","starred_url":"https://api.github.com/users/preo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/preo/subscriptions","organizations_url":"https://api.github.com/users/preo/orgs","repos_url":"https://api.github.com/users/preo/repos","events_url":"https://api.github.com/users/preo/events{/privacy}","received_events_url":"https://api.github.com/users/preo/received_events","type":"Organization","site_admin":false},"repo":{"id":38970855,"name":"gunicorn","full_name":"preo/gunicorn","owner":{"login":"preo","id":1356550,"avatar_url":"https://avatars.githubusercontent.com/u/1356550?v=3","gravatar_id":"","url":"https://api.github.com/users/preo","html_url":"https://github.com/preo","followers_url":"https://api.github.com/users/preo/followers","following_url":"https://api.github.com/users/preo/following{/other_user}","gists_url":"https://api.github.com/users/preo/gists{/gist_id}","starred_url":"https://api.github.com/users/preo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/preo/subscriptions","organizations_url":"https://api.github.com/users/preo/orgs","repos_url":"https://api.github.com/users/preo/repos","events_url":"https://api.github.com/users/preo/events{/privacy}","received_events_url":"https://api.github.com/users/preo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/preo/gunicorn","description":"gunicorn 'Green Unicorn' is a WSGI HTTP Server for UNIX, fast clients and sleepy applications.","fork":true,"url":"https://api.github.com/repos/preo/gunicorn","forks_url":"https://api.github.com/repos/preo/gunicorn/forks","keys_url":"https://api.github.com/repos/preo/gunicorn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/preo/gunicorn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/preo/gunicorn/teams","hooks_url":"https://api.github.com/repos/preo/gunicorn/hooks","issue_events_url":"https://api.github.com/repos/preo/gunicorn/issues/events{/number}","events_url":"https://api.github.com/repos/preo/gunicorn/events","assignees_url":"https://api.github.com/repos/preo/gunicorn/assignees{/user}","branches_url":"https://api.github.com/repos/preo/gunicorn/branches{/branch}","tags_url":"https://api.github.com/repos/preo/gunicorn/tags","blobs_url":"https://api.github.com/repos/preo/gunicorn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/preo/gunicorn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/preo/gunicorn/git/refs{/sha}","trees_url":"https://api.github.com/repos/preo/gunicorn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/preo/gunicorn/statuses/{sha}","languages_url":"https://api.github.com/repos/preo/gunicorn/languages","stargazers_url":"https://api.github.com/repos/preo/gunicorn/stargazers","contributors_url":"https://api.github.com/repos/preo/gunicorn/contributors","subscribers_url":"https://api.github.com/repos/preo/gunicorn/subscribers","subscription_url":"https://api.github.com/repos/preo/gunicorn/subscription","commits_url":"https://api.github.com/repos/preo/gunicorn/commits{/sha}","git_commits_url":"https://api.github.com/repos/preo/gunicorn/git/commits{/sha}","comments_url":"https://api.github.com/repos/preo/gunicorn/comments{/number}","issue_comment_url":"https://api.github.com/repos/preo/gunicorn/issues/comments{/number}","contents_url":"https://api.github.com/repos/preo/gunicorn/contents/{+path}","compare_url":"https://api.github.com/repos/preo/gunicorn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/preo/gunicorn/merges","archive_url":"https://api.github.com/repos/preo/gunicorn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/preo/gunicorn/downloads","issues_url":"https://api.github.com/repos/preo/gunicorn/issues{/number}","pulls_url":"https://api.github.com/repos/preo/gunicorn/pulls{/number}","milestones_url":"https://api.github.com/repos/preo/gunicorn/milestones{/number}","notifications_url":"https://api.github.com/repos/preo/gunicorn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/preo/gunicorn/labels{/name}","releases_url":"https://api.github.com/repos/preo/gunicorn/releases{/id}","created_at":"2015-07-12T17:28:56Z","updated_at":"2015-07-12T17:28:57Z","pushed_at":"2015-07-17T18:27:48Z","git_url":"git://github.com/preo/gunicorn.git","ssh_url":"git@github.com:preo/gunicorn.git","clone_url":"https://github.com/preo/gunicorn.git","svn_url":"https://github.com/preo/gunicorn","homepage":"http://www.gunicorn.org","size":4644,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"benoitc:master","ref":"master","sha":"97428ed08311a433b335adc5611e5d2c040e6fa2","user":{"login":"benoitc","id":14498,"avatar_url":"https://avatars.githubusercontent.com/u/14498?v=3","gravatar_id":"","url":"https://api.github.com/users/benoitc","html_url":"https://github.com/benoitc","followers_url":"https://api.github.com/users/benoitc/followers","following_url":"https://api.github.com/users/benoitc/following{/other_user}","gists_url":"https://api.github.com/users/benoitc/gists{/gist_id}","starred_url":"https://api.github.com/users/benoitc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benoitc/subscriptions","organizations_url":"https://api.github.com/users/benoitc/orgs","repos_url":"https://api.github.com/users/benoitc/repos","events_url":"https://api.github.com/users/benoitc/events{/privacy}","received_events_url":"https://api.github.com/users/benoitc/received_events","type":"User","site_admin":false},"repo":{"id":390510,"name":"gunicorn","full_name":"benoitc/gunicorn","owner":{"login":"benoitc","id":14498,"avatar_url":"https://avatars.githubusercontent.com/u/14498?v=3","gravatar_id":"","url":"https://api.github.com/users/benoitc","html_url":"https://github.com/benoitc","followers_url":"https://api.github.com/users/benoitc/followers","following_url":"https://api.github.com/users/benoitc/following{/other_user}","gists_url":"https://api.github.com/users/benoitc/gists{/gist_id}","starred_url":"https://api.github.com/users/benoitc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benoitc/subscriptions","organizations_url":"https://api.github.com/users/benoitc/orgs","repos_url":"https://api.github.com/users/benoitc/repos","events_url":"https://api.github.com/users/benoitc/events{/privacy}","received_events_url":"https://api.github.com/users/benoitc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benoitc/gunicorn","description":"gunicorn 'Green Unicorn' is a WSGI HTTP Server for UNIX, fast clients and sleepy applications.","fork":false,"url":"https://api.github.com/repos/benoitc/gunicorn","forks_url":"https://api.github.com/repos/benoitc/gunicorn/forks","keys_url":"https://api.github.com/repos/benoitc/gunicorn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benoitc/gunicorn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benoitc/gunicorn/teams","hooks_url":"https://api.github.com/repos/benoitc/gunicorn/hooks","issue_events_url":"https://api.github.com/repos/benoitc/gunicorn/issues/events{/number}","events_url":"https://api.github.com/repos/benoitc/gunicorn/events","assignees_url":"https://api.github.com/repos/benoitc/gunicorn/assignees{/user}","branches_url":"https://api.github.com/repos/benoitc/gunicorn/branches{/branch}","tags_url":"https://api.github.com/repos/benoitc/gunicorn/tags","blobs_url":"https://api.github.com/repos/benoitc/gunicorn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benoitc/gunicorn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benoitc/gunicorn/git/refs{/sha}","trees_url":"https://api.github.com/repos/benoitc/gunicorn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benoitc/gunicorn/statuses/{sha}","languages_url":"https://api.github.com/repos/benoitc/gunicorn/languages","stargazers_url":"https://api.github.com/repos/benoitc/gunicorn/stargazers","contributors_url":"https://api.github.com/repos/benoitc/gunicorn/contributors","subscribers_url":"https://api.github.com/repos/benoitc/gunicorn/subscribers","subscription_url":"https://api.github.com/repos/benoitc/gunicorn/subscription","commits_url":"https://api.github.com/repos/benoitc/gunicorn/commits{/sha}","git_commits_url":"https://api.github.com/repos/benoitc/gunicorn/git/commits{/sha}","comments_url":"https://api.github.com/repos/benoitc/gunicorn/comments{/number}","issue_comment_url":"https://api.github.com/repos/benoitc/gunicorn/issues/comments{/number}","contents_url":"https://api.github.com/repos/benoitc/gunicorn/contents/{+path}","compare_url":"https://api.github.com/repos/benoitc/gunicorn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benoitc/gunicorn/merges","archive_url":"https://api.github.com/repos/benoitc/gunicorn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benoitc/gunicorn/downloads","issues_url":"https://api.github.com/repos/benoitc/gunicorn/issues{/number}","pulls_url":"https://api.github.com/repos/benoitc/gunicorn/pulls{/number}","milestones_url":"https://api.github.com/repos/benoitc/gunicorn/milestones{/number}","notifications_url":"https://api.github.com/repos/benoitc/gunicorn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benoitc/gunicorn/labels{/name}","releases_url":"https://api.github.com/repos/benoitc/gunicorn/releases{/id}","created_at":"2009-11-30T18:18:08Z","updated_at":"2015-07-17T14:08:02Z","pushed_at":"2015-07-17T18:27:50Z","git_url":"git://github.com/benoitc/gunicorn.git","ssh_url":"git@github.com:benoitc/gunicorn.git","clone_url":"https://github.com/benoitc/gunicorn.git","svn_url":"https://github.com/benoitc/gunicorn","homepage":"http://www.gunicorn.org","size":10678,"stargazers_count":2449,"watchers_count":2449,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":505,"mirror_url":null,"open_issues_count":83,"forks":505,"open_issues":83,"watchers":2449,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/benoitc/gunicorn/pulls/1084"},"html":{"href":"https://github.com/benoitc/gunicorn/pull/1084"},"issue":{"href":"https://api.github.com/repos/benoitc/gunicorn/issues/1084"},"comments":{"href":"https://api.github.com/repos/benoitc/gunicorn/issues/1084/comments"},"review_comments":{"href":"https://api.github.com/repos/benoitc/gunicorn/pulls/1084/comments"},"review_comment":{"href":"https://api.github.com/repos/benoitc/gunicorn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/benoitc/gunicorn/pulls/1084/commits"},"statuses":{"href":"https://api.github.com/repos/benoitc/gunicorn/statuses/dd02dca05428087a37eb08d0d4a7d3bcabd82ff5"}}}}