{"action":"created","comment":{"url":"https://api.github.com/repos/bloomberg/brisket/pulls/comments/23715372","id":23715372,"diff_hunk":"@@ -3,18 +3,21 @@\n var ClientRenderer = {\n \n     render: function(layout, view, requestId) {\n-        var title = view.getTitle ? view.getTitle() : null;\n-        layout.setTitle(title);\n+        var shouldRenderTitle = requestId !== 1;\n \n-        var shouldRenderMetaTags = requestId === 1 || layout.updateMetatagsOnClientRender;\n+        if (shouldRenderTitle) {\n+            var title = view.getTitle ? view.getTitle() : null;\n+            layout.renderTitle(title);\n+        }\n+\n+        var shouldRenderMetaTags = requestId !== 1 && layout.updateMetatagsOnClientRender;","path":"lib/client/ClientRenderer.js","position":14,"original_position":14,"commit_id":"14ad83cd3af37e3e550f97738120a47fdd5636d6","original_commit_id":"cd57e9c811f8478580ef8bacd36235568920a064","user":{"login":"ericherdzik","id":4305370,"avatar_url":"https://avatars.githubusercontent.com/u/4305370?v=3","gravatar_id":"","url":"https://api.github.com/users/ericherdzik","html_url":"https://github.com/ericherdzik","followers_url":"https://api.github.com/users/ericherdzik/followers","following_url":"https://api.github.com/users/ericherdzik/following{/other_user}","gists_url":"https://api.github.com/users/ericherdzik/gists{/gist_id}","starred_url":"https://api.github.com/users/ericherdzik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericherdzik/subscriptions","organizations_url":"https://api.github.com/users/ericherdzik/orgs","repos_url":"https://api.github.com/users/ericherdzik/repos","events_url":"https://api.github.com/users/ericherdzik/events{/privacy}","received_events_url":"https://api.github.com/users/ericherdzik/received_events","type":"User","site_admin":false},"body":"What was here before was very incorrect. We should NEVER re-render the metatags on initial page load. The server takes care of that for us.","created_at":"2015-01-28T19:31:36Z","updated_at":"2015-01-28T19:31:36Z","html_url":"https://github.com/bloomberg/brisket/pull/84#discussion_r23715372","pull_request_url":"https://api.github.com/repos/bloomberg/brisket/pulls/84","_links":{"self":{"href":"https://api.github.com/repos/bloomberg/brisket/pulls/comments/23715372"},"html":{"href":"https://github.com/bloomberg/brisket/pull/84#discussion_r23715372"},"pull_request":{"href":"https://api.github.com/repos/bloomberg/brisket/pulls/84"}}},"pull_request":{"url":"https://api.github.com/repos/bloomberg/brisket/pulls/84","id":28221441,"html_url":"https://github.com/bloomberg/brisket/pull/84","diff_url":"https://github.com/bloomberg/brisket/pull/84.diff","patch_url":"https://github.com/bloomberg/brisket/pull/84.patch","issue_url":"https://api.github.com/repos/bloomberg/brisket/issues/84","number":84,"state":"open","locked":false,"title":"CPU optimization for rendering metatags","user":{"login":"ericherdzik","id":4305370,"avatar_url":"https://avatars.githubusercontent.com/u/4305370?v=3","gravatar_id":"","url":"https://api.github.com/users/ericherdzik","html_url":"https://github.com/ericherdzik","followers_url":"https://api.github.com/users/ericherdzik/followers","following_url":"https://api.github.com/users/ericherdzik/following{/other_user}","gists_url":"https://api.github.com/users/ericherdzik/gists{/gist_id}","starred_url":"https://api.github.com/users/ericherdzik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericherdzik/subscriptions","organizations_url":"https://api.github.com/users/ericherdzik/orgs","repos_url":"https://api.github.com/users/ericherdzik/repos","events_url":"https://api.github.com/users/ericherdzik/events{/privacy}","received_events_url":"https://api.github.com/users/ericherdzik/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-01-28T19:24:11Z","updated_at":"2015-01-28T19:31:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97bcc8ccda7c3213a9031b3499df26865a7ada81","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bloomberg/brisket/pulls/84/commits","review_comments_url":"https://api.github.com/repos/bloomberg/brisket/pulls/84/comments","review_comment_url":"https://api.github.com/repos/bloomberg/brisket/pulls/comments/{number}","comments_url":"https://api.github.com/repos/bloomberg/brisket/issues/84/comments","statuses_url":"https://api.github.com/repos/bloomberg/brisket/statuses/14ad83cd3af37e3e550f97738120a47fdd5636d6","head":{"label":"ericherdzik:optimize/metatags","ref":"optimize/metatags","sha":"14ad83cd3af37e3e550f97738120a47fdd5636d6","user":{"login":"ericherdzik","id":4305370,"avatar_url":"https://avatars.githubusercontent.com/u/4305370?v=3","gravatar_id":"","url":"https://api.github.com/users/ericherdzik","html_url":"https://github.com/ericherdzik","followers_url":"https://api.github.com/users/ericherdzik/followers","following_url":"https://api.github.com/users/ericherdzik/following{/other_user}","gists_url":"https://api.github.com/users/ericherdzik/gists{/gist_id}","starred_url":"https://api.github.com/users/ericherdzik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericherdzik/subscriptions","organizations_url":"https://api.github.com/users/ericherdzik/orgs","repos_url":"https://api.github.com/users/ericherdzik/repos","events_url":"https://api.github.com/users/ericherdzik/events{/privacy}","received_events_url":"https://api.github.com/users/ericherdzik/received_events","type":"User","site_admin":false},"repo":{"id":24739524,"name":"brisket","full_name":"ericherdzik/brisket","owner":{"login":"ericherdzik","id":4305370,"avatar_url":"https://avatars.githubusercontent.com/u/4305370?v=3","gravatar_id":"","url":"https://api.github.com/users/ericherdzik","html_url":"https://github.com/ericherdzik","followers_url":"https://api.github.com/users/ericherdzik/followers","following_url":"https://api.github.com/users/ericherdzik/following{/other_user}","gists_url":"https://api.github.com/users/ericherdzik/gists{/gist_id}","starred_url":"https://api.github.com/users/ericherdzik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericherdzik/subscriptions","organizations_url":"https://api.github.com/users/ericherdzik/orgs","repos_url":"https://api.github.com/users/ericherdzik/repos","events_url":"https://api.github.com/users/ericherdzik/events{/privacy}","received_events_url":"https://api.github.com/users/ericherdzik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericherdzik/brisket","description":"Bloomberg's Brisket JavaScript application framework","fork":true,"url":"https://api.github.com/repos/ericherdzik/brisket","forks_url":"https://api.github.com/repos/ericherdzik/brisket/forks","keys_url":"https://api.github.com/repos/ericherdzik/brisket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericherdzik/brisket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericherdzik/brisket/teams","hooks_url":"https://api.github.com/repos/ericherdzik/brisket/hooks","issue_events_url":"https://api.github.com/repos/ericherdzik/brisket/issues/events{/number}","events_url":"https://api.github.com/repos/ericherdzik/brisket/events","assignees_url":"https://api.github.com/repos/ericherdzik/brisket/assignees{/user}","branches_url":"https://api.github.com/repos/ericherdzik/brisket/branches{/branch}","tags_url":"https://api.github.com/repos/ericherdzik/brisket/tags","blobs_url":"https://api.github.com/repos/ericherdzik/brisket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericherdzik/brisket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericherdzik/brisket/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericherdzik/brisket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericherdzik/brisket/statuses/{sha}","languages_url":"https://api.github.com/repos/ericherdzik/brisket/languages","stargazers_url":"https://api.github.com/repos/ericherdzik/brisket/stargazers","contributors_url":"https://api.github.com/repos/ericherdzik/brisket/contributors","subscribers_url":"https://api.github.com/repos/ericherdzik/brisket/subscribers","subscription_url":"https://api.github.com/repos/ericherdzik/brisket/subscription","commits_url":"https://api.github.com/repos/ericherdzik/brisket/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericherdzik/brisket/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericherdzik/brisket/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericherdzik/brisket/issues/comments/{number}","contents_url":"https://api.github.com/repos/ericherdzik/brisket/contents/{+path}","compare_url":"https://api.github.com/repos/ericherdzik/brisket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericherdzik/brisket/merges","archive_url":"https://api.github.com/repos/ericherdzik/brisket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericherdzik/brisket/downloads","issues_url":"https://api.github.com/repos/ericherdzik/brisket/issues{/number}","pulls_url":"https://api.github.com/repos/ericherdzik/brisket/pulls{/number}","milestones_url":"https://api.github.com/repos/ericherdzik/brisket/milestones{/number}","notifications_url":"https://api.github.com/repos/ericherdzik/brisket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericherdzik/brisket/labels{/name}","releases_url":"https://api.github.com/repos/ericherdzik/brisket/releases{/id}","created_at":"2014-10-02T22:44:12Z","updated_at":"2014-10-07T18:28:25Z","pushed_at":"2015-01-28T19:30:27Z","git_url":"git://github.com/ericherdzik/brisket.git","ssh_url":"git@github.com:ericherdzik/brisket.git","clone_url":"https://github.com/ericherdzik/brisket.git","svn_url":"https://github.com/ericherdzik/brisket","homepage":"","size":340,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bloomberg:master","ref":"master","sha":"5a198875b057c5aee10182ba09fa1a8dd23e0c4c","user":{"login":"bloomberg","id":1416818,"avatar_url":"https://avatars.githubusercontent.com/u/1416818?v=3","gravatar_id":"","url":"https://api.github.com/users/bloomberg","html_url":"https://github.com/bloomberg","followers_url":"https://api.github.com/users/bloomberg/followers","following_url":"https://api.github.com/users/bloomberg/following{/other_user}","gists_url":"https://api.github.com/users/bloomberg/gists{/gist_id}","starred_url":"https://api.github.com/users/bloomberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bloomberg/subscriptions","organizations_url":"https://api.github.com/users/bloomberg/orgs","repos_url":"https://api.github.com/users/bloomberg/repos","events_url":"https://api.github.com/users/bloomberg/events{/privacy}","received_events_url":"https://api.github.com/users/bloomberg/received_events","type":"Organization","site_admin":false},"repo":{"id":24653948,"name":"brisket","full_name":"bloomberg/brisket","owner":{"login":"bloomberg","id":1416818,"avatar_url":"https://avatars.githubusercontent.com/u/1416818?v=3","gravatar_id":"","url":"https://api.github.com/users/bloomberg","html_url":"https://github.com/bloomberg","followers_url":"https://api.github.com/users/bloomberg/followers","following_url":"https://api.github.com/users/bloomberg/following{/other_user}","gists_url":"https://api.github.com/users/bloomberg/gists{/gist_id}","starred_url":"https://api.github.com/users/bloomberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bloomberg/subscriptions","organizations_url":"https://api.github.com/users/bloomberg/orgs","repos_url":"https://api.github.com/users/bloomberg/repos","events_url":"https://api.github.com/users/bloomberg/events{/privacy}","received_events_url":"https://api.github.com/users/bloomberg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bloomberg/brisket","description":"Bloomberg's Brisket JavaScript application framework","fork":false,"url":"https://api.github.com/repos/bloomberg/brisket","forks_url":"https://api.github.com/repos/bloomberg/brisket/forks","keys_url":"https://api.github.com/repos/bloomberg/brisket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bloomberg/brisket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bloomberg/brisket/teams","hooks_url":"https://api.github.com/repos/bloomberg/brisket/hooks","issue_events_url":"https://api.github.com/repos/bloomberg/brisket/issues/events{/number}","events_url":"https://api.github.com/repos/bloomberg/brisket/events","assignees_url":"https://api.github.com/repos/bloomberg/brisket/assignees{/user}","branches_url":"https://api.github.com/repos/bloomberg/brisket/branches{/branch}","tags_url":"https://api.github.com/repos/bloomberg/brisket/tags","blobs_url":"https://api.github.com/repos/bloomberg/brisket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bloomberg/brisket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bloomberg/brisket/git/refs{/sha}","trees_url":"https://api.github.com/repos/bloomberg/brisket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bloomberg/brisket/statuses/{sha}","languages_url":"https://api.github.com/repos/bloomberg/brisket/languages","stargazers_url":"https://api.github.com/repos/bloomberg/brisket/stargazers","contributors_url":"https://api.github.com/repos/bloomberg/brisket/contributors","subscribers_url":"https://api.github.com/repos/bloomberg/brisket/subscribers","subscription_url":"https://api.github.com/repos/bloomberg/brisket/subscription","commits_url":"https://api.github.com/repos/bloomberg/brisket/commits{/sha}","git_commits_url":"https://api.github.com/repos/bloomberg/brisket/git/commits{/sha}","comments_url":"https://api.github.com/repos/bloomberg/brisket/comments{/number}","issue_comment_url":"https://api.github.com/repos/bloomberg/brisket/issues/comments/{number}","contents_url":"https://api.github.com/repos/bloomberg/brisket/contents/{+path}","compare_url":"https://api.github.com/repos/bloomberg/brisket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bloomberg/brisket/merges","archive_url":"https://api.github.com/repos/bloomberg/brisket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bloomberg/brisket/downloads","issues_url":"https://api.github.com/repos/bloomberg/brisket/issues{/number}","pulls_url":"https://api.github.com/repos/bloomberg/brisket/pulls{/number}","milestones_url":"https://api.github.com/repos/bloomberg/brisket/milestones{/number}","notifications_url":"https://api.github.com/repos/bloomberg/brisket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bloomberg/brisket/labels{/name}","releases_url":"https://api.github.com/repos/bloomberg/brisket/releases{/id}","created_at":"2014-09-30T20:17:08Z","updated_at":"2015-01-28T11:38:31Z","pushed_at":"2015-01-27T17:45:22Z","git_url":"git://github.com/bloomberg/brisket.git","ssh_url":"git@github.com:bloomberg/brisket.git","clone_url":"https://github.com/bloomberg/brisket.git","svn_url":"https://github.com/bloomberg/brisket","homepage":"","size":1141,"stargazers_count":100,"watchers_count":100,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":15,"forks":23,"open_issues":15,"watchers":100,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bloomberg/brisket/pulls/84"},"html":{"href":"https://github.com/bloomberg/brisket/pull/84"},"issue":{"href":"https://api.github.com/repos/bloomberg/brisket/issues/84"},"comments":{"href":"https://api.github.com/repos/bloomberg/brisket/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/bloomberg/brisket/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/bloomberg/brisket/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/bloomberg/brisket/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/bloomberg/brisket/statuses/14ad83cd3af37e3e550f97738120a47fdd5636d6"}}}}