{"action":"created","comment":{"url":"https://api.github.com/repos/prometheus/mysqld_exporter/pulls/comments/31381036","id":31381036,"diff_hunk":"@@ -52,6 +63,56 @@ func NewMySQLExporter(dsn string) *Exporter {\n \t\t\tHelp:      \"The last scrape error status.\",\n \t\t}),\n \t\tmetrics: map[string]prometheus.Gauge{},\n+\t\tcommands: prometheus.NewCounterVec(prometheus.CounterOpts{\n+\t\t\tNamespace: namespace,\n+\t\t\tName:      \"commands_total\",\n+\t\t\tHelp:      \"Number of executed mysql commands.\",\n+\t\t}, []string{\"command\"}),\n+\t\tconnection_errors: prometheus.NewCounterVec(prometheus.CounterOpts{\n+\t\t\tNamespace: namespace,\n+\t\t\tName:      \"connection_errors_total\",","path":"mysqld_exporter.go","position":46,"original_position":46,"commit_id":"a0c56ba832b2919cdbbe3b130ba5cd33602c836e","original_commit_id":"a0c56ba832b2919cdbbe3b130ba5cd33602c836e","user":{"login":"brian-brazil","id":7115638,"avatar_url":"https://avatars.githubusercontent.com/u/7115638?v=3","gravatar_id":"","url":"https://api.github.com/users/brian-brazil","html_url":"https://github.com/brian-brazil","followers_url":"https://api.github.com/users/brian-brazil/followers","following_url":"https://api.github.com/users/brian-brazil/following{/other_user}","gists_url":"https://api.github.com/users/brian-brazil/gists{/gist_id}","starred_url":"https://api.github.com/users/brian-brazil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brian-brazil/subscriptions","organizations_url":"https://api.github.com/users/brian-brazil/orgs","repos_url":"https://api.github.com/users/brian-brazil/repos","events_url":"https://api.github.com/users/brian-brazil/events{/privacy}","received_events_url":"https://api.github.com/users/brian-brazil/received_events","type":"User","site_admin":false},"body":"Thanks, that seems fine then.","created_at":"2015-05-30T14:15:22Z","updated_at":"2015-05-30T14:15:22Z","html_url":"https://github.com/prometheus/mysqld_exporter/pull/4#discussion_r31381036","pull_request_url":"https://api.github.com/repos/prometheus/mysqld_exporter/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/prometheus/mysqld_exporter/pulls/comments/31381036"},"html":{"href":"https://github.com/prometheus/mysqld_exporter/pull/4#discussion_r31381036"},"pull_request":{"href":"https://api.github.com/repos/prometheus/mysqld_exporter/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/prometheus/mysqld_exporter/pulls/4","id":34715344,"html_url":"https://github.com/prometheus/mysqld_exporter/pull/4","diff_url":"https://github.com/prometheus/mysqld_exporter/pull/4.diff","patch_url":"https://github.com/prometheus/mysqld_exporter/pull/4.patch","issue_url":"https://api.github.com/repos/prometheus/mysqld_exporter/issues/4","number":4,"state":"open","locked":false,"title":"Moved all mysql commands to mysql_commands_total and use Untyped for all other metrics.","user":{"login":"siavashs","id":113189,"avatar_url":"https://avatars.githubusercontent.com/u/113189?v=3","gravatar_id":"","url":"https://api.github.com/users/siavashs","html_url":"https://github.com/siavashs","followers_url":"https://api.github.com/users/siavashs/followers","following_url":"https://api.github.com/users/siavashs/following{/other_user}","gists_url":"https://api.github.com/users/siavashs/gists{/gist_id}","starred_url":"https://api.github.com/users/siavashs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siavashs/subscriptions","organizations_url":"https://api.github.com/users/siavashs/orgs","repos_url":"https://api.github.com/users/siavashs/repos","events_url":"https://api.github.com/users/siavashs/events{/privacy}","received_events_url":"https://api.github.com/users/siavashs/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-05-05T11:27:28Z","updated_at":"2015-05-30T14:15:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb5c2639e20a1e5d794fa4c34a6286d39ff239ac","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/prometheus/mysqld_exporter/pulls/4/commits","review_comments_url":"https://api.github.com/repos/prometheus/mysqld_exporter/pulls/4/comments","review_comment_url":"https://api.github.com/repos/prometheus/mysqld_exporter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prometheus/mysqld_exporter/issues/4/comments","statuses_url":"https://api.github.com/repos/prometheus/mysqld_exporter/statuses/a0c56ba832b2919cdbbe3b130ba5cd33602c836e","head":{"label":"siavashs:commands","ref":"commands","sha":"a0c56ba832b2919cdbbe3b130ba5cd33602c836e","user":{"login":"siavashs","id":113189,"avatar_url":"https://avatars.githubusercontent.com/u/113189?v=3","gravatar_id":"","url":"https://api.github.com/users/siavashs","html_url":"https://github.com/siavashs","followers_url":"https://api.github.com/users/siavashs/followers","following_url":"https://api.github.com/users/siavashs/following{/other_user}","gists_url":"https://api.github.com/users/siavashs/gists{/gist_id}","starred_url":"https://api.github.com/users/siavashs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siavashs/subscriptions","organizations_url":"https://api.github.com/users/siavashs/orgs","repos_url":"https://api.github.com/users/siavashs/repos","events_url":"https://api.github.com/users/siavashs/events{/privacy}","received_events_url":"https://api.github.com/users/siavashs/received_events","type":"User","site_admin":false},"repo":{"id":35082286,"name":"mysqld_exporter","full_name":"siavashs/mysqld_exporter","owner":{"login":"siavashs","id":113189,"avatar_url":"https://avatars.githubusercontent.com/u/113189?v=3","gravatar_id":"","url":"https://api.github.com/users/siavashs","html_url":"https://github.com/siavashs","followers_url":"https://api.github.com/users/siavashs/followers","following_url":"https://api.github.com/users/siavashs/following{/other_user}","gists_url":"https://api.github.com/users/siavashs/gists{/gist_id}","starred_url":"https://api.github.com/users/siavashs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siavashs/subscriptions","organizations_url":"https://api.github.com/users/siavashs/orgs","repos_url":"https://api.github.com/users/siavashs/repos","events_url":"https://api.github.com/users/siavashs/events{/privacy}","received_events_url":"https://api.github.com/users/siavashs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/siavashs/mysqld_exporter","description":"Exporter for MySQL server metrics","fork":true,"url":"https://api.github.com/repos/siavashs/mysqld_exporter","forks_url":"https://api.github.com/repos/siavashs/mysqld_exporter/forks","keys_url":"https://api.github.com/repos/siavashs/mysqld_exporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/siavashs/mysqld_exporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/siavashs/mysqld_exporter/teams","hooks_url":"https://api.github.com/repos/siavashs/mysqld_exporter/hooks","issue_events_url":"https://api.github.com/repos/siavashs/mysqld_exporter/issues/events{/number}","events_url":"https://api.github.com/repos/siavashs/mysqld_exporter/events","assignees_url":"https://api.github.com/repos/siavashs/mysqld_exporter/assignees{/user}","branches_url":"https://api.github.com/repos/siavashs/mysqld_exporter/branches{/branch}","tags_url":"https://api.github.com/repos/siavashs/mysqld_exporter/tags","blobs_url":"https://api.github.com/repos/siavashs/mysqld_exporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/siavashs/mysqld_exporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/siavashs/mysqld_exporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/siavashs/mysqld_exporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/siavashs/mysqld_exporter/statuses/{sha}","languages_url":"https://api.github.com/repos/siavashs/mysqld_exporter/languages","stargazers_url":"https://api.github.com/repos/siavashs/mysqld_exporter/stargazers","contributors_url":"https://api.github.com/repos/siavashs/mysqld_exporter/contributors","subscribers_url":"https://api.github.com/repos/siavashs/mysqld_exporter/subscribers","subscription_url":"https://api.github.com/repos/siavashs/mysqld_exporter/subscription","commits_url":"https://api.github.com/repos/siavashs/mysqld_exporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/siavashs/mysqld_exporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/siavashs/mysqld_exporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/siavashs/mysqld_exporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/siavashs/mysqld_exporter/contents/{+path}","compare_url":"https://api.github.com/repos/siavashs/mysqld_exporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/siavashs/mysqld_exporter/merges","archive_url":"https://api.github.com/repos/siavashs/mysqld_exporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/siavashs/mysqld_exporter/downloads","issues_url":"https://api.github.com/repos/siavashs/mysqld_exporter/issues{/number}","pulls_url":"https://api.github.com/repos/siavashs/mysqld_exporter/pulls{/number}","milestones_url":"https://api.github.com/repos/siavashs/mysqld_exporter/milestones{/number}","notifications_url":"https://api.github.com/repos/siavashs/mysqld_exporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/siavashs/mysqld_exporter/labels{/name}","releases_url":"https://api.github.com/repos/siavashs/mysqld_exporter/releases{/id}","created_at":"2015-05-05T06:34:28Z","updated_at":"2015-05-05T06:34:28Z","pushed_at":"2015-05-29T15:07:05Z","git_url":"git://github.com/siavashs/mysqld_exporter.git","ssh_url":"git@github.com:siavashs/mysqld_exporter.git","clone_url":"https://github.com/siavashs/mysqld_exporter.git","svn_url":"https://github.com/siavashs/mysqld_exporter","homepage":"http://prometheus.io/","size":98,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prometheus:master","ref":"master","sha":"5c4263a389f9642dd836748398bbfd54eef7187d","user":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"repo":{"id":32075541,"name":"mysqld_exporter","full_name":"prometheus/mysqld_exporter","owner":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prometheus/mysqld_exporter","description":"Exporter for MySQL server metrics","fork":false,"url":"https://api.github.com/repos/prometheus/mysqld_exporter","forks_url":"https://api.github.com/repos/prometheus/mysqld_exporter/forks","keys_url":"https://api.github.com/repos/prometheus/mysqld_exporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prometheus/mysqld_exporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prometheus/mysqld_exporter/teams","hooks_url":"https://api.github.com/repos/prometheus/mysqld_exporter/hooks","issue_events_url":"https://api.github.com/repos/prometheus/mysqld_exporter/issues/events{/number}","events_url":"https://api.github.com/repos/prometheus/mysqld_exporter/events","assignees_url":"https://api.github.com/repos/prometheus/mysqld_exporter/assignees{/user}","branches_url":"https://api.github.com/repos/prometheus/mysqld_exporter/branches{/branch}","tags_url":"https://api.github.com/repos/prometheus/mysqld_exporter/tags","blobs_url":"https://api.github.com/repos/prometheus/mysqld_exporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prometheus/mysqld_exporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prometheus/mysqld_exporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/prometheus/mysqld_exporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prometheus/mysqld_exporter/statuses/{sha}","languages_url":"https://api.github.com/repos/prometheus/mysqld_exporter/languages","stargazers_url":"https://api.github.com/repos/prometheus/mysqld_exporter/stargazers","contributors_url":"https://api.github.com/repos/prometheus/mysqld_exporter/contributors","subscribers_url":"https://api.github.com/repos/prometheus/mysqld_exporter/subscribers","subscription_url":"https://api.github.com/repos/prometheus/mysqld_exporter/subscription","commits_url":"https://api.github.com/repos/prometheus/mysqld_exporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/prometheus/mysqld_exporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/prometheus/mysqld_exporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/prometheus/mysqld_exporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/prometheus/mysqld_exporter/contents/{+path}","compare_url":"https://api.github.com/repos/prometheus/mysqld_exporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prometheus/mysqld_exporter/merges","archive_url":"https://api.github.com/repos/prometheus/mysqld_exporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prometheus/mysqld_exporter/downloads","issues_url":"https://api.github.com/repos/prometheus/mysqld_exporter/issues{/number}","pulls_url":"https://api.github.com/repos/prometheus/mysqld_exporter/pulls{/number}","milestones_url":"https://api.github.com/repos/prometheus/mysqld_exporter/milestones{/number}","notifications_url":"https://api.github.com/repos/prometheus/mysqld_exporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prometheus/mysqld_exporter/labels{/name}","releases_url":"https://api.github.com/repos/prometheus/mysqld_exporter/releases{/id}","created_at":"2015-03-12T12:23:48Z","updated_at":"2015-05-05T10:37:20Z","pushed_at":"2015-05-29T23:02:19Z","git_url":"git://github.com/prometheus/mysqld_exporter.git","ssh_url":"git@github.com:prometheus/mysqld_exporter.git","clone_url":"https://github.com/prometheus/mysqld_exporter.git","svn_url":"https://github.com/prometheus/mysqld_exporter","homepage":"http://prometheus.io/","size":331,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prometheus/mysqld_exporter/pulls/4"},"html":{"href":"https://github.com/prometheus/mysqld_exporter/pull/4"},"issue":{"href":"https://api.github.com/repos/prometheus/mysqld_exporter/issues/4"},"comments":{"href":"https://api.github.com/repos/prometheus/mysqld_exporter/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/prometheus/mysqld_exporter/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/prometheus/mysqld_exporter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prometheus/mysqld_exporter/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/prometheus/mysqld_exporter/statuses/a0c56ba832b2919cdbbe3b130ba5cd33602c836e"}}}}