{"action":"created","issue":{"url":"https://api.github.com/repos/acemod/ACE3/issues/1092","labels_url":"https://api.github.com/repos/acemod/ACE3/issues/1092/labels{/name}","comments_url":"https://api.github.com/repos/acemod/ACE3/issues/1092/comments","events_url":"https://api.github.com/repos/acemod/ACE3/issues/1092/events","html_url":"https://github.com/acemod/ACE3/pull/1092","id":74843758,"number":1092,"title":"ACE_time variables for accurate purposeful time use","user":{"login":"jaynus","id":2880909,"avatar_url":"https://avatars.githubusercontent.com/u/2880909?v=3","gravatar_id":"","url":"https://api.github.com/users/jaynus","html_url":"https://github.com/jaynus","followers_url":"https://api.github.com/users/jaynus/followers","following_url":"https://api.github.com/users/jaynus/following{/other_user}","gists_url":"https://api.github.com/users/jaynus/gists{/gist_id}","starred_url":"https://api.github.com/users/jaynus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaynus/subscriptions","organizations_url":"https://api.github.com/users/jaynus/orgs","repos_url":"https://api.github.com/users/jaynus/repos","events_url":"https://api.github.com/users/jaynus/events{/privacy}","received_events_url":"https://api.github.com/users/jaynus/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/acemod/ACE3/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":{"login":"esteldunedain","id":7674951,"avatar_url":"https://avatars.githubusercontent.com/u/7674951?v=3","gravatar_id":"","url":"https://api.github.com/users/esteldunedain","html_url":"https://github.com/esteldunedain","followers_url":"https://api.github.com/users/esteldunedain/followers","following_url":"https://api.github.com/users/esteldunedain/following{/other_user}","gists_url":"https://api.github.com/users/esteldunedain/gists{/gist_id}","starred_url":"https://api.github.com/users/esteldunedain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esteldunedain/subscriptions","organizations_url":"https://api.github.com/users/esteldunedain/orgs","repos_url":"https://api.github.com/users/esteldunedain/repos","events_url":"https://api.github.com/users/esteldunedain/events{/privacy}","received_events_url":"https://api.github.com/users/esteldunedain/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/acemod/ACE3/milestones/3","html_url":"https://github.com/acemod/ACE3/milestones/3.1.0","labels_url":"https://api.github.com/repos/acemod/ACE3/milestones/3/labels","id":959656,"number":3,"title":"3.1.0","description":"","creator":{"login":"esteldunedain","id":7674951,"avatar_url":"https://avatars.githubusercontent.com/u/7674951?v=3","gravatar_id":"","url":"https://api.github.com/users/esteldunedain","html_url":"https://github.com/esteldunedain","followers_url":"https://api.github.com/users/esteldunedain/followers","following_url":"https://api.github.com/users/esteldunedain/following{/other_user}","gists_url":"https://api.github.com/users/esteldunedain/gists{/gist_id}","starred_url":"https://api.github.com/users/esteldunedain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esteldunedain/subscriptions","organizations_url":"https://api.github.com/users/esteldunedain/orgs","repos_url":"https://api.github.com/users/esteldunedain/repos","events_url":"https://api.github.com/users/esteldunedain/events{/privacy}","received_events_url":"https://api.github.com/users/esteldunedain/received_events","type":"User","site_admin":false},"open_issues":90,"closed_issues":25,"state":"open","created_at":"2015-01-31T19:41:24Z","updated_at":"2015-05-10T11:45:20Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2015-05-10T05:57:14Z","updated_at":"2015-05-10T13:48:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/acemod/ACE3/pulls/1092","html_url":"https://github.com/acemod/ACE3/pull/1092","diff_url":"https://github.com/acemod/ACE3/pull/1092.diff","patch_url":"https://github.com/acemod/ACE3/pull/1092.patch"},"body":"There was discussion recently about the fact we use 'time' everywhere in our PFH's so they detect game pausing and support saved games.\r\n\r\nHowever, time is unreliable on slow machines (< 20fps) - so we *should* be using diag_tickTime for PFH functionality.\r\n\r\nThis provides the following global variables for a hybrid approach of this:\r\nACE_time = diag_tickTime accuracy, except it does not advance when the game is paused. It will also obviously save and continue forward in a saved game, so supports them as well.\r\nACE_realTime = diag_tickTime\r\nACE_gameTime = time\r\nACE_virtualTime = diag_tickTime accuracy, except taking accTime into account.\r\nACE_virtualGameTime = time, except takes accTime into account.\r\nACE_virtualPausedTime = the amount of diag_tickTime time that was paused, except accTime is taken into account. WHO THE FUCK WOULD NEED THIS!? I'm sure someone will.\r\nACE_pausedTime = the amount of time the game has been paused in total. \r\n\r\nACE_paused = true/false, whether the game is currently paused.\r\n\r\nThese would have a seperate PR, which would *replace all uses of time with ACE_time!!!!!!!*\r\n\r\nCompletes #1091"},"comment":{"url":"https://api.github.com/repos/acemod/ACE3/issues/comments/100644304","html_url":"https://github.com/acemod/ACE3/pull/1092#issuecomment-100644304","issue_url":"https://api.github.com/repos/acemod/ACE3/issues/1092","id":100644304,"user":{"login":"esteldunedain","id":7674951,"avatar_url":"https://avatars.githubusercontent.com/u/7674951?v=3","gravatar_id":"","url":"https://api.github.com/users/esteldunedain","html_url":"https://github.com/esteldunedain","followers_url":"https://api.github.com/users/esteldunedain/followers","following_url":"https://api.github.com/users/esteldunedain/following{/other_user}","gists_url":"https://api.github.com/users/esteldunedain/gists{/gist_id}","starred_url":"https://api.github.com/users/esteldunedain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esteldunedain/subscriptions","organizations_url":"https://api.github.com/users/esteldunedain/orgs","repos_url":"https://api.github.com/users/esteldunedain/repos","events_url":"https://api.github.com/users/esteldunedain/events{/privacy}","received_events_url":"https://api.github.com/users/esteldunedain/received_events","type":"User","site_admin":false},"created_at":"2015-05-10T13:48:55Z","updated_at":"2015-05-10T13:48:55Z","body":"Excellent! I like the approach. I'm just not so convinced about the names of the variables as per the comment above. \r\n\r\nSide comment: would it make sense to advance ACE_time during the frame too? e.g., on a draw eh, etc, onEachFrame, etc. I really don't see why, but I'm just asking if someone does."}}