{"action":"created","issue":{"url":"https://api.github.com/repos/99designs/http-signatures-php/issues/9","labels_url":"https://api.github.com/repos/99designs/http-signatures-php/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/99designs/http-signatures-php/issues/9/comments","events_url":"https://api.github.com/repos/99designs/http-signatures-php/issues/9/events","html_url":"https://github.com/99designs/http-signatures-php/issues/9","id":106883279,"number":9,"title":"Consider PSR-7 Request instead of Symfony Request.","user":{"login":"pda","id":15759,"avatar_url":"https://avatars.githubusercontent.com/u/15759?v=3","gravatar_id":"","url":"https://api.github.com/users/pda","html_url":"https://github.com/pda","followers_url":"https://api.github.com/users/pda/followers","following_url":"https://api.github.com/users/pda/following{/other_user}","gists_url":"https://api.github.com/users/pda/gists{/gist_id}","starred_url":"https://api.github.com/users/pda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pda/subscriptions","organizations_url":"https://api.github.com/users/pda/orgs","repos_url":"https://api.github.com/users/pda/repos","events_url":"https://api.github.com/users/pda/events{/privacy}","received_events_url":"https://api.github.com/users/pda/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-16T23:16:32Z","updated_at":"2015-10-07T12:25:36Z","closed_at":null,"body":"@mtibben says:\r\n\r\n> @pda: you may want to consider using PSR7 Request rather than Symfony Requests for that lib\r\n\r\nhttp://www.php-fig.org/psr/psr-7/\r\n\r\nThat PSR-7 page describes a `Psr\\Http\\Message\\RequestInterface`. Maybe worth noting it also says:\r\n\r\n> An HTTP client MUST ignore the values of `Uri::getPath()` and `Uri::getQuery()`, and instead use the value returned by `getRequestTarget()`, which defaults to concatenating these two values.\r\n\r\n---\r\n\r\nAlso, I regret not wrapping whatever request object in a locally-defined interface, making issues like https://github.com/99designs/http-signatures-php/pull/8 much harder to solve. So a breaking change version of this library would probably introduce a new `Message` interface with a `SymfonyReqestMessage` and `PSR7RequestMessage` implementation."},"comment":{"url":"https://api.github.com/repos/99designs/http-signatures-php/issues/comments/146180854","html_url":"https://github.com/99designs/http-signatures-php/issues/9#issuecomment-146180854","issue_url":"https://api.github.com/repos/99designs/http-signatures-php/issues/9","id":146180854,"user":{"login":"vinkla","id":499192,"avatar_url":"https://avatars.githubusercontent.com/u/499192?v=3","gravatar_id":"","url":"https://api.github.com/users/vinkla","html_url":"https://github.com/vinkla","followers_url":"https://api.github.com/users/vinkla/followers","following_url":"https://api.github.com/users/vinkla/following{/other_user}","gists_url":"https://api.github.com/users/vinkla/gists{/gist_id}","starred_url":"https://api.github.com/users/vinkla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinkla/subscriptions","organizations_url":"https://api.github.com/users/vinkla/orgs","repos_url":"https://api.github.com/users/vinkla/repos","events_url":"https://api.github.com/users/vinkla/events{/privacy}","received_events_url":"https://api.github.com/users/vinkla/received_events","type":"User","site_admin":false},"created_at":"2015-10-07T12:25:36Z","updated_at":"2015-10-07T12:25:36Z","body":":+1: "}}