{"action":"created","issue":{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/4257","labels_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/4257/labels{/name}","comments_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/4257/comments","events_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/4257/events","html_url":"https://github.com/openmicroscopy/openmicroscopy/pull/4257","id":111161904,"number":4257,"title":"Right panel general panes","user":{"login":"will-moore","id":900055,"avatar_url":"https://avatars.githubusercontent.com/u/900055?v=3","gravatar_id":"","url":"https://api.github.com/users/will-moore","html_url":"https://github.com/will-moore","followers_url":"https://api.github.com/users/will-moore/followers","following_url":"https://api.github.com/users/will-moore/following{/other_user}","gists_url":"https://api.github.com/users/will-moore/gists{/gist_id}","starred_url":"https://api.github.com/users/will-moore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/will-moore/subscriptions","organizations_url":"https://api.github.com/users/will-moore/orgs","repos_url":"https://api.github.com/users/will-moore/repos","events_url":"https://api.github.com/users/will-moore/events{/privacy}","received_events_url":"https://api.github.com/users/will-moore/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/labels/develop","name":"develop","color":"02e10c"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-13T11:36:34Z","updated_at":"2015-10-14T13:25:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/4257","html_url":"https://github.com/openmicroscopy/openmicroscopy/pull/4257","diff_url":"https://github.com/openmicroscopy/openmicroscopy/pull/4257.diff","patch_url":"https://github.com/openmicroscopy/openmicroscopy/pull/4257.patch"},"body":"This is the first part of the right panel update from https://docs.google.com/document/d/1C__ZB0uyX3295Fop-k-fcQIL53NaKrZcuZ3N0OBDMb0/edit#\r\n\r\nIn this PR we simply split the main \"General\" tab content into separate collapsible panes.\r\nWe don't yet change how data is loaded or provide annotation counts in the pane headers.\r\n\r\nTo test:\r\n - Browse P/D/I S/P/W and check that panel looks OK and tabs expand when clicked and contain correct data (maybe compare with viewing same data in Insight)\r\n - Filter Annotations by user and check this still works as expected\r\n\r\nSome differences with mock-ups:\r\n - I've kept ```Image ID``` and ```Owner``` above each other, with the \"Show All\" selector to the right. I think this looks neater than having them on the same row. @gusferguson Do you think the \"Show All\" selector really needs a label, or will a tooltip be sufficient? I think a label might just be unnecessary clutter.\r\n - The mockups sometimes use plural E.g. \"Tags\" and \"Attachments\" and sometimes not \"Rating\" and \"Other\". It probably makes sense to always use the plural \"Ratings\" and \"Others\"?\r\n - I think that \"Others\" should go after \"Ratings\" since \"Others\" is really 'Anything not listed above'. Also, Rating is likely to be a smaller tab than Others, so expanding Rating will not make Others fly off the screen but Others (when expanded) could be big enough to make Rating disappear (I think this is the reason we have Comments last).\r\n\r\nI think we should maybe have \"Image Details\" open by default?\r\nThis would minimise the change for users, is a small amount of key info and is never too big to hide other tabs (just means that we have less empty space when panel first loads).\r\n\r\nFuture PRs will handle:\r\n - Remembering which panel you had open\r\n - Adding Annotation counts to panel headers\r\n - Loading data only for open tabs\r\n\r\n![screen shot 2015-10-13 at 12 18 42](https://cloud.githubusercontent.com/assets/900055/10453532/d39de65a-71a4-11e5-85f7-d9d002b2f3ce.png)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/comments/148048453","html_url":"https://github.com/openmicroscopy/openmicroscopy/pull/4257#issuecomment-148048453","issue_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/4257","id":148048453,"user":{"login":"gusferguson","id":1552703,"avatar_url":"https://avatars.githubusercontent.com/u/1552703?v=3","gravatar_id":"","url":"https://api.github.com/users/gusferguson","html_url":"https://github.com/gusferguson","followers_url":"https://api.github.com/users/gusferguson/followers","following_url":"https://api.github.com/users/gusferguson/following{/other_user}","gists_url":"https://api.github.com/users/gusferguson/gists{/gist_id}","starred_url":"https://api.github.com/users/gusferguson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gusferguson/subscriptions","organizations_url":"https://api.github.com/users/gusferguson/orgs","repos_url":"https://api.github.com/users/gusferguson/repos","events_url":"https://api.github.com/users/gusferguson/events{/privacy}","received_events_url":"https://api.github.com/users/gusferguson/received_events","type":"User","site_admin":false},"created_at":"2015-10-14T13:25:52Z","updated_at":"2015-10-14T13:25:52Z","body":"@will-moore \r\n\r\nTesting:\r\n\r\n- Browse P/D/I S/P/W and check that panel looks OK and tabs expand when clicked and contain correct data (maybe compare with viewing same data in Insight)\r\n-- behaves as expected\r\n\r\n- Filter Annotations by user and check this still works as expected\r\n-- behaves as expected - could not see issue described by @jburel above\r\n\r\nSome differences with mock-ups:\r\n\r\n- I've kept Image ID and Owner above each other, with the \"Show All\" selector to the right. I think this looks neater than having them on the same row.\r\n-- this is fine by me\r\n\r\n- @gusferguson Do you think the \"Show All\" selector really needs a label, or will a tooltip be sufficient? I think a label might just be unnecessary clutter.\r\n-- I think no label and tooltip should be fine - don’t even know if it is used much.\r\n\r\n- The mockups sometimes use plural E.g. \"Tags\" and \"Attachments\" and sometimes not \"Rating\" and \"Other\". It probably makes sense to always use the plural \"Ratings\" and \"Others\"?\r\n-- agreed - probably just typos on my part\r\n\r\n- I think that \"Others\" should go after \"Ratings\" since \"Others\" is really 'Anything not listed above'. Also, Rating is likely to be a smaller tab than Others, so expanding Rating will not make Others fly off the screen but Others (when expanded) could be big enough to make Rating disappear (I think this is the reason we have Comments last).\r\n-- fine by me\r\n\r\n- I think we should maybe have \"Image Details\" open by default?\r\nThis would minimise the change for users, is a small amount of key info and is never too big to hide other tabs (just means that we have less empty space when panel first loads).\r\n-- agreed this would minimise the “shock” of the change for users and then we can always have it closed later if we find space is at a premium - a lot of this is really future-proofing at this stage, so happy with that.\r\n\r\nGood to merge from my POV.\r\nAwaits thrashing by @pwalczysko !"}}