{"action":"created","issue":{"url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/2390","labels_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/2390/labels{/name}","comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/2390/comments","events_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/2390/events","html_url":"https://github.com/ethereum/cpp-ethereum/pull/2390","id":93229192,"number":2390,"title":"FixedHash::bloomPart() bugfix: out of range","user":{"login":"gluk256","id":9915581,"avatar_url":"https://avatars.githubusercontent.com/u/9915581?v=3","gravatar_id":"","url":"https://api.github.com/users/gluk256","html_url":"https://github.com/gluk256","followers_url":"https://api.github.com/users/gluk256/followers","following_url":"https://api.github.com/users/gluk256/following{/other_user}","gists_url":"https://api.github.com/users/gluk256/gists{/gist_id}","starred_url":"https://api.github.com/users/gluk256/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gluk256/subscriptions","organizations_url":"https://api.github.com/users/gluk256/orgs","repos_url":"https://api.github.com/users/gluk256/repos","events_url":"https://api.github.com/users/gluk256/events{/privacy}","received_events_url":"https://api.github.com/users/gluk256/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ethereum/cpp-ethereum/labels/looksgood","name":"looksgood","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-07-06T09:11:20Z","updated_at":"2015-07-06T10:27:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/2390","html_url":"https://github.com/ethereum/cpp-ethereum/pull/2390","diff_url":"https://github.com/ethereum/cpp-ethereum/pull/2390.diff","patch_url":"https://github.com/ethereum/cpp-ethereum/pull/2390.patch"},"body":"In case of Whisper (P=3, M=64) variable ++p would be incremented 192 times and go out of range. If we substituted (*p) with (m_data[x]), then std::array would have thrown exception. But in our case there was no warning and the program would execute normally. \r\nI did not do it now, because I prefer compile-time assert to run-time."},"comment":{"url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/comments/118803402","html_url":"https://github.com/ethereum/cpp-ethereum/pull/2390#issuecomment-118803402","issue_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/2390","id":118803402,"user":{"login":"LefterisJP","id":1658405,"avatar_url":"https://avatars.githubusercontent.com/u/1658405?v=3","gravatar_id":"","url":"https://api.github.com/users/LefterisJP","html_url":"https://github.com/LefterisJP","followers_url":"https://api.github.com/users/LefterisJP/followers","following_url":"https://api.github.com/users/LefterisJP/following{/other_user}","gists_url":"https://api.github.com/users/LefterisJP/gists{/gist_id}","starred_url":"https://api.github.com/users/LefterisJP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LefterisJP/subscriptions","organizations_url":"https://api.github.com/users/LefterisJP/orgs","repos_url":"https://api.github.com/users/LefterisJP/repos","events_url":"https://api.github.com/users/LefterisJP/events{/privacy}","received_events_url":"https://api.github.com/users/LefterisJP/received_events","type":"User","site_admin":false},"created_at":"2015-07-06T10:27:13Z","updated_at":"2015-07-06T10:27:13Z","body":"adding some unit tests for this would also be nice"}}