{"action":"created","issue":{"url":"https://api.github.com/repos/btobolaski/terraform-provider-linode/issues/1","labels_url":"https://api.github.com/repos/btobolaski/terraform-provider-linode/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/btobolaski/terraform-provider-linode/issues/1/comments","events_url":"https://api.github.com/repos/btobolaski/terraform-provider-linode/issues/1/events","html_url":"https://github.com/btobolaski/terraform-provider-linode/pull/1","id":110805122,"number":1,"title":"Add features","user":{"login":"bdwyertech","id":2973273,"avatar_url":"https://avatars.githubusercontent.com/u/2973273?v=3","gravatar_id":"","url":"https://api.github.com/users/bdwyertech","html_url":"https://github.com/bdwyertech","followers_url":"https://api.github.com/users/bdwyertech/followers","following_url":"https://api.github.com/users/bdwyertech/following{/other_user}","gists_url":"https://api.github.com/users/bdwyertech/gists{/gist_id}","starred_url":"https://api.github.com/users/bdwyertech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdwyertech/subscriptions","organizations_url":"https://api.github.com/users/bdwyertech/orgs","repos_url":"https://api.github.com/users/bdwyertech/repos","events_url":"https://api.github.com/users/bdwyertech/events{/privacy}","received_events_url":"https://api.github.com/users/bdwyertech/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-10-10T16:51:53Z","updated_at":"2015-10-23T19:05:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/btobolaski/terraform-provider-linode/pulls/1","html_url":"https://github.com/btobolaski/terraform-provider-linode/pull/1","diff_url":"https://github.com/btobolaski/terraform-provider-linode/pull/1.diff","patch_url":"https://github.com/btobolaski/terraform-provider-linode/pull/1.patch"},"body":"- Support resizing Linodes\r\n- Support expanding the root volume upon upsize of a Linode\r\n- Added values to show a Linode's storage capacity based on its Linode plan size (`plan_storage`) and the total size of all a Linodes volumes (`plan_storage_utilized`)\r\n- Support using an `imageID` instead of only the `imageName` for deployment\r\n- Adjusted disk naming behavior to account for Linode 50 character `diskName` limitation\r\n- Allow configuration of Linode swap size\r\n- Added/updated tests and documentation"},"comment":{"url":"https://api.github.com/repos/btobolaski/terraform-provider-linode/issues/comments/150665259","html_url":"https://github.com/btobolaski/terraform-provider-linode/pull/1#issuecomment-150665259","issue_url":"https://api.github.com/repos/btobolaski/terraform-provider-linode/issues/1","id":150665259,"user":{"login":"btobolaski","id":363694,"avatar_url":"https://avatars.githubusercontent.com/u/363694?v=3","gravatar_id":"","url":"https://api.github.com/users/btobolaski","html_url":"https://github.com/btobolaski","followers_url":"https://api.github.com/users/btobolaski/followers","following_url":"https://api.github.com/users/btobolaski/following{/other_user}","gists_url":"https://api.github.com/users/btobolaski/gists{/gist_id}","starred_url":"https://api.github.com/users/btobolaski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btobolaski/subscriptions","organizations_url":"https://api.github.com/users/btobolaski/orgs","repos_url":"https://api.github.com/users/btobolaski/repos","events_url":"https://api.github.com/users/btobolaski/events{/privacy}","received_events_url":"https://api.github.com/users/btobolaski/received_events","type":"User","site_admin":false},"created_at":"2015-10-23T19:05:56Z","updated_at":"2015-10-23T19:05:56Z","body":"This looks really good. I really appreciate that you took the time to make sure that resources wouldn't need to be recreated after updating.\r\n\r\nI like a lot of the changes that you've made but, I'm a little hesitant to add the ability to resize instances into the provider. One issue that I have with it is that it only works well when increasing in size. You can downsize but, that requires shrinking the disk which is probably unsafe to do automatically. My second issue with it is a compound issue: terraform doesn't have anyway to include a warning about what is going to happen and resizing takes quite a while. Going by the comments in the code, resizing a 16gb instance can take between 7 and 19 hours. Personally, I've never seen a resize take that long but, there is probably a reason that Linode states those numbers as baselines. Having a server be unavailable for that amount of time could be very damaging. Imagine a user that isn't aware of this, that decides to resize their database server. Depending on the size of the starting instance, it could be days before their database is available again. To me, this doesn't seem like the sort of thing that I'd want to happen automatically."}}