{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/28245009","id":28245009,"diff_hunk":"@@ -45,5 +43,15 @@ func New(quiet bool) *SysInfo {\n \t} else {\n \t\tsysInfo.AppArmor = true\n \t}\n+\n+\t// Check if Devices cgroup is mounted, it is hard requirement for container security.\n+\tif _, err := cgroups.FindCgroupMountpoint(\"devices\"); err != nil {\n+\t\tif cgroups.IsNotFound(err) {","path":"pkg/sysinfo/sysinfo.go","position":28,"original_position":28,"commit_id":"a814fb66463aa0d3de5b5734d1a37d9a5d0d9398","original_commit_id":"a814fb66463aa0d3de5b5734d1a37d9a5d0d9398","user":{"login":"cpuguy83","id":799078,"avatar_url":"https://avatars.githubusercontent.com/u/799078?v=3","gravatar_id":"","url":"https://api.github.com/users/cpuguy83","html_url":"https://github.com/cpuguy83","followers_url":"https://api.github.com/users/cpuguy83/followers","following_url":"https://api.github.com/users/cpuguy83/following{/other_user}","gists_url":"https://api.github.com/users/cpuguy83/gists{/gist_id}","starred_url":"https://api.github.com/users/cpuguy83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpuguy83/subscriptions","organizations_url":"https://api.github.com/users/cpuguy83/orgs","repos_url":"https://api.github.com/users/cpuguy83/repos","events_url":"https://api.github.com/users/cpuguy83/events{/privacy}","received_events_url":"https://api.github.com/users/cpuguy83/received_events","type":"User","site_admin":false},"body":"perhaps since these are both Fatals, just do `log.Fatalf(\"error mounting devices cgroup: %v\", err)` and remove the else.","created_at":"2015-04-13T14:56:24Z","updated_at":"2015-04-13T14:56:24Z","html_url":"https://github.com/docker/docker/pull/11882#discussion_r28245009","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/11882","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/28245009"},"html":{"href":"https://github.com/docker/docker/pull/11882#discussion_r28245009"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/11882"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/11882","id":32162021,"html_url":"https://github.com/docker/docker/pull/11882","diff_url":"https://github.com/docker/docker/pull/11882.diff","patch_url":"https://github.com/docker/docker/pull/11882.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/11882","number":11882,"state":"open","locked":false,"title":"add devices cgroup check as hard requirement","user":{"login":"hqhq","id":6415670,"avatar_url":"https://avatars.githubusercontent.com/u/6415670?v=3","gravatar_id":"","url":"https://api.github.com/users/hqhq","html_url":"https://github.com/hqhq","followers_url":"https://api.github.com/users/hqhq/followers","following_url":"https://api.github.com/users/hqhq/following{/other_user}","gists_url":"https://api.github.com/users/hqhq/gists{/gist_id}","starred_url":"https://api.github.com/users/hqhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hqhq/subscriptions","organizations_url":"https://api.github.com/users/hqhq/orgs","repos_url":"https://api.github.com/users/hqhq/repos","events_url":"https://api.github.com/users/hqhq/events{/privacy}","received_events_url":"https://api.github.com/users/hqhq/received_events","type":"User","site_admin":false},"body":"Devices cgroup is required for container security,  because without it a container will have unrestricted access to device nodes, libcontainer will take that as a hard requirement, we should warn users if they happen to have this umounted.","created_at":"2015-03-28T09:39:37Z","updated_at":"2015-04-13T14:56:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab76219634fdb5ea863f1a73f48e2e1c9b2afb2f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/11882/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/11882/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/11882/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/a814fb66463aa0d3de5b5734d1a37d9a5d0d9398","head":{"label":"hqhq:hq_warn_device_cg","ref":"hq_warn_device_cg","sha":"a814fb66463aa0d3de5b5734d1a37d9a5d0d9398","user":{"login":"hqhq","id":6415670,"avatar_url":"https://avatars.githubusercontent.com/u/6415670?v=3","gravatar_id":"","url":"https://api.github.com/users/hqhq","html_url":"https://github.com/hqhq","followers_url":"https://api.github.com/users/hqhq/followers","following_url":"https://api.github.com/users/hqhq/following{/other_user}","gists_url":"https://api.github.com/users/hqhq/gists{/gist_id}","starred_url":"https://api.github.com/users/hqhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hqhq/subscriptions","organizations_url":"https://api.github.com/users/hqhq/orgs","repos_url":"https://api.github.com/users/hqhq/repos","events_url":"https://api.github.com/users/hqhq/events{/privacy}","received_events_url":"https://api.github.com/users/hqhq/received_events","type":"User","site_admin":false},"repo":{"id":23826530,"name":"docker","full_name":"hqhq/docker","owner":{"login":"hqhq","id":6415670,"avatar_url":"https://avatars.githubusercontent.com/u/6415670?v=3","gravatar_id":"","url":"https://api.github.com/users/hqhq","html_url":"https://github.com/hqhq","followers_url":"https://api.github.com/users/hqhq/followers","following_url":"https://api.github.com/users/hqhq/following{/other_user}","gists_url":"https://api.github.com/users/hqhq/gists{/gist_id}","starred_url":"https://api.github.com/users/hqhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hqhq/subscriptions","organizations_url":"https://api.github.com/users/hqhq/orgs","repos_url":"https://api.github.com/users/hqhq/repos","events_url":"https://api.github.com/users/hqhq/events{/privacy}","received_events_url":"https://api.github.com/users/hqhq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hqhq/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/hqhq/docker","forks_url":"https://api.github.com/repos/hqhq/docker/forks","keys_url":"https://api.github.com/repos/hqhq/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hqhq/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hqhq/docker/teams","hooks_url":"https://api.github.com/repos/hqhq/docker/hooks","issue_events_url":"https://api.github.com/repos/hqhq/docker/issues/events{/number}","events_url":"https://api.github.com/repos/hqhq/docker/events","assignees_url":"https://api.github.com/repos/hqhq/docker/assignees{/user}","branches_url":"https://api.github.com/repos/hqhq/docker/branches{/branch}","tags_url":"https://api.github.com/repos/hqhq/docker/tags","blobs_url":"https://api.github.com/repos/hqhq/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hqhq/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hqhq/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/hqhq/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hqhq/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/hqhq/docker/languages","stargazers_url":"https://api.github.com/repos/hqhq/docker/stargazers","contributors_url":"https://api.github.com/repos/hqhq/docker/contributors","subscribers_url":"https://api.github.com/repos/hqhq/docker/subscribers","subscription_url":"https://api.github.com/repos/hqhq/docker/subscription","commits_url":"https://api.github.com/repos/hqhq/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/hqhq/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/hqhq/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/hqhq/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/hqhq/docker/contents/{+path}","compare_url":"https://api.github.com/repos/hqhq/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hqhq/docker/merges","archive_url":"https://api.github.com/repos/hqhq/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hqhq/docker/downloads","issues_url":"https://api.github.com/repos/hqhq/docker/issues{/number}","pulls_url":"https://api.github.com/repos/hqhq/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/hqhq/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/hqhq/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hqhq/docker/labels{/name}","releases_url":"https://api.github.com/repos/hqhq/docker/releases{/id}","created_at":"2014-09-09T09:03:12Z","updated_at":"2015-03-24T08:26:55Z","pushed_at":"2015-04-13T09:22:15Z","git_url":"git://github.com/hqhq/docker.git","ssh_url":"git@github.com:hqhq/docker.git","clone_url":"https://github.com/hqhq/docker.git","svn_url":"https://github.com/hqhq/docker","homepage":"http://www.docker.com","size":48884,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"9ede3f9fc13ac9c27282afdb44590b55f955cc9c","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-04-13T14:44:48Z","pushed_at":"2015-04-13T14:47:20Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":175795,"stargazers_count":20768,"watchers_count":20768,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4734,"mirror_url":null,"open_issues_count":917,"forks":4734,"open_issues":917,"watchers":20768,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/11882"},"html":{"href":"https://github.com/docker/docker/pull/11882"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/11882"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/11882/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/11882/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/11882/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/a814fb66463aa0d3de5b5734d1a37d9a5d0d9398"}}}}