{"action":"created","comment":{"url":"https://api.github.com/repos/scala-js/scala-js/pulls/comments/29202749","id":29202749,"diff_hunk":"@@ -23,18 +21,32 @@ trait PrepJSExports { this: PrepJSInterop =>\n \n   import scala.reflect.internal.Flags\n \n-  /** Whether the given symbol has a visibility that allows exporting */\n-  def hasLegalExportVisibility(sym: Symbol): Boolean =\n-    sym.isPublic || sym.isProtected && !sym.isProtectedLocal\n-\n+  case class ExportInfo(\n+      jsName: String,\n+      pos: Position,\n+      isNamed: Boolean,\n+      ignoreInvalid: Boolean\n+  ) extends jsInterop.ExportInfo\n+\n+  /** Generate the exporter for the given DefDef\n+   *\n+   *  If this DefDef is a constructor, it registered to be exported by\n+   *  GenJSCode instead and no trees are returned.","path":"compiler/src/main/scala/org/scalajs/core/compiler/PrepJSExports.scala","position":29,"original_position":29,"commit_id":"74e125c47cd39ef1e70d5283de43dba5b479324c","original_commit_id":"74e125c47cd39ef1e70d5283de43dba5b479324c","user":{"login":"gzm0","id":1140323,"avatar_url":"https://avatars.githubusercontent.com/u/1140323?v=3","gravatar_id":"","url":"https://api.github.com/users/gzm0","html_url":"https://github.com/gzm0","followers_url":"https://api.github.com/users/gzm0/followers","following_url":"https://api.github.com/users/gzm0/following{/other_user}","gists_url":"https://api.github.com/users/gzm0/gists{/gist_id}","starred_url":"https://api.github.com/users/gzm0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gzm0/subscriptions","organizations_url":"https://api.github.com/users/gzm0/orgs","repos_url":"https://api.github.com/users/gzm0/repos","events_url":"https://api.github.com/users/gzm0/events{/privacy}","received_events_url":"https://api.github.com/users/gzm0/received_events","type":"User","site_admin":false},"body":"Should be \"it is registered\"","created_at":"2015-04-27T23:34:55Z","updated_at":"2015-04-27T23:34:55Z","html_url":"https://github.com/scala-js/scala-js/pull/1616#discussion_r29202749","pull_request_url":"https://api.github.com/repos/scala-js/scala-js/pulls/1616","_links":{"self":{"href":"https://api.github.com/repos/scala-js/scala-js/pulls/comments/29202749"},"html":{"href":"https://github.com/scala-js/scala-js/pull/1616#discussion_r29202749"},"pull_request":{"href":"https://api.github.com/repos/scala-js/scala-js/pulls/1616"}}},"pull_request":{"url":"https://api.github.com/repos/scala-js/scala-js/pulls/1616","id":34119535,"html_url":"https://github.com/scala-js/scala-js/pull/1616","diff_url":"https://github.com/scala-js/scala-js/pull/1616.diff","patch_url":"https://github.com/scala-js/scala-js/pull/1616.patch","issue_url":"https://api.github.com/repos/scala-js/scala-js/issues/1616","number":1616,"state":"open","locked":false,"title":"Option to ignore invalid descendants in @JSExportDescendent{Classes,Objects}","user":{"login":"gzm0","id":1140323,"avatar_url":"https://avatars.githubusercontent.com/u/1140323?v=3","gravatar_id":"","url":"https://api.github.com/users/gzm0","html_url":"https://github.com/gzm0","followers_url":"https://api.github.com/users/gzm0/followers","following_url":"https://api.github.com/users/gzm0/following{/other_user}","gists_url":"https://api.github.com/users/gzm0/gists{/gist_id}","starred_url":"https://api.github.com/users/gzm0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gzm0/subscriptions","organizations_url":"https://api.github.com/users/gzm0/orgs","repos_url":"https://api.github.com/users/gzm0/repos","events_url":"https://api.github.com/users/gzm0/events{/privacy}","received_events_url":"https://api.github.com/users/gzm0/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-04-26T08:01:10Z","updated_at":"2015-04-27T23:34:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d79f35deb950da573a9643a0cb6f1818cccf503","assignee":{"login":"sjrd","id":535934,"avatar_url":"https://avatars.githubusercontent.com/u/535934?v=3","gravatar_id":"","url":"https://api.github.com/users/sjrd","html_url":"https://github.com/sjrd","followers_url":"https://api.github.com/users/sjrd/followers","following_url":"https://api.github.com/users/sjrd/following{/other_user}","gists_url":"https://api.github.com/users/sjrd/gists{/gist_id}","starred_url":"https://api.github.com/users/sjrd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjrd/subscriptions","organizations_url":"https://api.github.com/users/sjrd/orgs","repos_url":"https://api.github.com/users/sjrd/repos","events_url":"https://api.github.com/users/sjrd/events{/privacy}","received_events_url":"https://api.github.com/users/sjrd/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/scala-js/scala-js/pulls/1616/commits","review_comments_url":"https://api.github.com/repos/scala-js/scala-js/pulls/1616/comments","review_comment_url":"https://api.github.com/repos/scala-js/scala-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scala-js/scala-js/issues/1616/comments","statuses_url":"https://api.github.com/repos/scala-js/scala-js/statuses/74e125c47cd39ef1e70d5283de43dba5b479324c","head":{"label":"gzm0:ignore-invalid-descendants","ref":"ignore-invalid-descendants","sha":"74e125c47cd39ef1e70d5283de43dba5b479324c","user":{"login":"gzm0","id":1140323,"avatar_url":"https://avatars.githubusercontent.com/u/1140323?v=3","gravatar_id":"","url":"https://api.github.com/users/gzm0","html_url":"https://github.com/gzm0","followers_url":"https://api.github.com/users/gzm0/followers","following_url":"https://api.github.com/users/gzm0/following{/other_user}","gists_url":"https://api.github.com/users/gzm0/gists{/gist_id}","starred_url":"https://api.github.com/users/gzm0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gzm0/subscriptions","organizations_url":"https://api.github.com/users/gzm0/orgs","repos_url":"https://api.github.com/users/gzm0/repos","events_url":"https://api.github.com/users/gzm0/events{/privacy}","received_events_url":"https://api.github.com/users/gzm0/received_events","type":"User","site_admin":false},"repo":{"id":14925025,"name":"scala-js","full_name":"gzm0/scala-js","owner":{"login":"gzm0","id":1140323,"avatar_url":"https://avatars.githubusercontent.com/u/1140323?v=3","gravatar_id":"","url":"https://api.github.com/users/gzm0","html_url":"https://github.com/gzm0","followers_url":"https://api.github.com/users/gzm0/followers","following_url":"https://api.github.com/users/gzm0/following{/other_user}","gists_url":"https://api.github.com/users/gzm0/gists{/gist_id}","starred_url":"https://api.github.com/users/gzm0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gzm0/subscriptions","organizations_url":"https://api.github.com/users/gzm0/orgs","repos_url":"https://api.github.com/users/gzm0/repos","events_url":"https://api.github.com/users/gzm0/events{/privacy}","received_events_url":"https://api.github.com/users/gzm0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gzm0/scala-js","description":"Scala.js, a Scala to JavaScript compiler","fork":true,"url":"https://api.github.com/repos/gzm0/scala-js","forks_url":"https://api.github.com/repos/gzm0/scala-js/forks","keys_url":"https://api.github.com/repos/gzm0/scala-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gzm0/scala-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gzm0/scala-js/teams","hooks_url":"https://api.github.com/repos/gzm0/scala-js/hooks","issue_events_url":"https://api.github.com/repos/gzm0/scala-js/issues/events{/number}","events_url":"https://api.github.com/repos/gzm0/scala-js/events","assignees_url":"https://api.github.com/repos/gzm0/scala-js/assignees{/user}","branches_url":"https://api.github.com/repos/gzm0/scala-js/branches{/branch}","tags_url":"https://api.github.com/repos/gzm0/scala-js/tags","blobs_url":"https://api.github.com/repos/gzm0/scala-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gzm0/scala-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gzm0/scala-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/gzm0/scala-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gzm0/scala-js/statuses/{sha}","languages_url":"https://api.github.com/repos/gzm0/scala-js/languages","stargazers_url":"https://api.github.com/repos/gzm0/scala-js/stargazers","contributors_url":"https://api.github.com/repos/gzm0/scala-js/contributors","subscribers_url":"https://api.github.com/repos/gzm0/scala-js/subscribers","subscription_url":"https://api.github.com/repos/gzm0/scala-js/subscription","commits_url":"https://api.github.com/repos/gzm0/scala-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/gzm0/scala-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/gzm0/scala-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/gzm0/scala-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/gzm0/scala-js/contents/{+path}","compare_url":"https://api.github.com/repos/gzm0/scala-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gzm0/scala-js/merges","archive_url":"https://api.github.com/repos/gzm0/scala-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gzm0/scala-js/downloads","issues_url":"https://api.github.com/repos/gzm0/scala-js/issues{/number}","pulls_url":"https://api.github.com/repos/gzm0/scala-js/pulls{/number}","milestones_url":"https://api.github.com/repos/gzm0/scala-js/milestones{/number}","notifications_url":"https://api.github.com/repos/gzm0/scala-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gzm0/scala-js/labels{/name}","releases_url":"https://api.github.com/repos/gzm0/scala-js/releases{/id}","created_at":"2013-12-04T13:51:38Z","updated_at":"2015-04-25T21:52:19Z","pushed_at":"2015-04-27T02:42:05Z","git_url":"git://github.com/gzm0/scala-js.git","ssh_url":"git@github.com:gzm0/scala-js.git","clone_url":"https://github.com/gzm0/scala-js.git","svn_url":"https://github.com/gzm0/scala-js","homepage":"http://www.scala-js.org/","size":12718,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scala-js:master","ref":"master","sha":"f1f2d503992d44026bbf2df9b2dae2f809734fc2","user":{"login":"scala-js","id":6039724,"avatar_url":"https://avatars.githubusercontent.com/u/6039724?v=3","gravatar_id":"","url":"https://api.github.com/users/scala-js","html_url":"https://github.com/scala-js","followers_url":"https://api.github.com/users/scala-js/followers","following_url":"https://api.github.com/users/scala-js/following{/other_user}","gists_url":"https://api.github.com/users/scala-js/gists{/gist_id}","starred_url":"https://api.github.com/users/scala-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala-js/subscriptions","organizations_url":"https://api.github.com/users/scala-js/orgs","repos_url":"https://api.github.com/users/scala-js/repos","events_url":"https://api.github.com/users/scala-js/events{/privacy}","received_events_url":"https://api.github.com/users/scala-js/received_events","type":"Organization","site_admin":false},"repo":{"id":8272315,"name":"scala-js","full_name":"scala-js/scala-js","owner":{"login":"scala-js","id":6039724,"avatar_url":"https://avatars.githubusercontent.com/u/6039724?v=3","gravatar_id":"","url":"https://api.github.com/users/scala-js","html_url":"https://github.com/scala-js","followers_url":"https://api.github.com/users/scala-js/followers","following_url":"https://api.github.com/users/scala-js/following{/other_user}","gists_url":"https://api.github.com/users/scala-js/gists{/gist_id}","starred_url":"https://api.github.com/users/scala-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala-js/subscriptions","organizations_url":"https://api.github.com/users/scala-js/orgs","repos_url":"https://api.github.com/users/scala-js/repos","events_url":"https://api.github.com/users/scala-js/events{/privacy}","received_events_url":"https://api.github.com/users/scala-js/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scala-js/scala-js","description":"Scala.js, the Scala to JavaScript compiler","fork":false,"url":"https://api.github.com/repos/scala-js/scala-js","forks_url":"https://api.github.com/repos/scala-js/scala-js/forks","keys_url":"https://api.github.com/repos/scala-js/scala-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scala-js/scala-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scala-js/scala-js/teams","hooks_url":"https://api.github.com/repos/scala-js/scala-js/hooks","issue_events_url":"https://api.github.com/repos/scala-js/scala-js/issues/events{/number}","events_url":"https://api.github.com/repos/scala-js/scala-js/events","assignees_url":"https://api.github.com/repos/scala-js/scala-js/assignees{/user}","branches_url":"https://api.github.com/repos/scala-js/scala-js/branches{/branch}","tags_url":"https://api.github.com/repos/scala-js/scala-js/tags","blobs_url":"https://api.github.com/repos/scala-js/scala-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scala-js/scala-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scala-js/scala-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/scala-js/scala-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scala-js/scala-js/statuses/{sha}","languages_url":"https://api.github.com/repos/scala-js/scala-js/languages","stargazers_url":"https://api.github.com/repos/scala-js/scala-js/stargazers","contributors_url":"https://api.github.com/repos/scala-js/scala-js/contributors","subscribers_url":"https://api.github.com/repos/scala-js/scala-js/subscribers","subscription_url":"https://api.github.com/repos/scala-js/scala-js/subscription","commits_url":"https://api.github.com/repos/scala-js/scala-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/scala-js/scala-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/scala-js/scala-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/scala-js/scala-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/scala-js/scala-js/contents/{+path}","compare_url":"https://api.github.com/repos/scala-js/scala-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scala-js/scala-js/merges","archive_url":"https://api.github.com/repos/scala-js/scala-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scala-js/scala-js/downloads","issues_url":"https://api.github.com/repos/scala-js/scala-js/issues{/number}","pulls_url":"https://api.github.com/repos/scala-js/scala-js/pulls{/number}","milestones_url":"https://api.github.com/repos/scala-js/scala-js/milestones{/number}","notifications_url":"https://api.github.com/repos/scala-js/scala-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scala-js/scala-js/labels{/name}","releases_url":"https://api.github.com/repos/scala-js/scala-js/releases{/id}","created_at":"2013-02-18T16:33:55Z","updated_at":"2015-04-27T21:42:01Z","pushed_at":"2015-04-27T11:06:45Z","git_url":"git://github.com/scala-js/scala-js.git","ssh_url":"git@github.com:scala-js/scala-js.git","clone_url":"https://github.com/scala-js/scala-js.git","svn_url":"https://github.com/scala-js/scala-js","homepage":"http://www.scala-js.org/","size":15874,"stargazers_count":1637,"watchers_count":1637,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":133,"mirror_url":null,"open_issues_count":48,"forks":133,"open_issues":48,"watchers":1637,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scala-js/scala-js/pulls/1616"},"html":{"href":"https://github.com/scala-js/scala-js/pull/1616"},"issue":{"href":"https://api.github.com/repos/scala-js/scala-js/issues/1616"},"comments":{"href":"https://api.github.com/repos/scala-js/scala-js/issues/1616/comments"},"review_comments":{"href":"https://api.github.com/repos/scala-js/scala-js/pulls/1616/comments"},"review_comment":{"href":"https://api.github.com/repos/scala-js/scala-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scala-js/scala-js/pulls/1616/commits"},"statuses":{"href":"https://api.github.com/repos/scala-js/scala-js/statuses/74e125c47cd39ef1e70d5283de43dba5b479324c"}}}}