{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Security/pulls/comments/25908484","id":25908484,"diff_hunk":"@@ -46,9 +45,14 @@ public class OpenIdConnectAuthenticationMiddleware : AuthenticationMiddleware<Op\n         {\n             _logger = loggerFactory.CreateLogger<OpenIdConnectAuthenticationMiddleware>();\n \n+            if (string.IsNullOrEmpty(Options.SignInScheme))\n+            {\n+                Options.SignInScheme = externalOptions.Options.SignInScheme;\n+            }","path":"src/Microsoft.AspNet.Authentication.OpenIdConnect/OpenIdConnectAuthenticationMiddleware.cs","position":24,"original_position":24,"commit_id":"54f2e3a54a02e39afa40b17aaba59a94a0e8ed8d","original_commit_id":"1adf49419b3ca28daa9d94962c068b305b413872","user":{"login":"HaoK","id":6537861,"avatar_url":"https://avatars.githubusercontent.com/u/6537861?v=3","gravatar_id":"","url":"https://api.github.com/users/HaoK","html_url":"https://github.com/HaoK","followers_url":"https://api.github.com/users/HaoK/followers","following_url":"https://api.github.com/users/HaoK/following{/other_user}","gists_url":"https://api.github.com/users/HaoK/gists{/gist_id}","starred_url":"https://api.github.com/users/HaoK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HaoK/subscriptions","organizations_url":"https://api.github.com/users/HaoK/orgs","repos_url":"https://api.github.com/users/HaoK/repos","events_url":"https://api.github.com/users/HaoK/events{/privacy}","received_events_url":"https://api.github.com/users/HaoK/received_events","type":"User","site_admin":false},"body":"Okay for now lets just leave them where they are, I filed https://github.com/aspnet/Security/issues/174 to sort this out later","created_at":"2015-03-05T22:30:03Z","updated_at":"2015-03-05T22:30:03Z","html_url":"https://github.com/aspnet/Security/pull/168#discussion_r25908484","pull_request_url":"https://api.github.com/repos/aspnet/Security/pulls/168","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Security/pulls/comments/25908484"},"html":{"href":"https://github.com/aspnet/Security/pull/168#discussion_r25908484"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Security/pulls/168"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Security/pulls/168","id":30380626,"html_url":"https://github.com/aspnet/Security/pull/168","diff_url":"https://github.com/aspnet/Security/pull/168.diff","patch_url":"https://github.com/aspnet/Security/pull/168.patch","issue_url":"https://api.github.com/repos/aspnet/Security/issues/168","number":168,"state":"open","locked":false,"title":"Fix #140, #167, address a comment in #144 and rework the bearer middleware tests","user":{"login":"PinpointTownes","id":6998306,"avatar_url":"https://avatars.githubusercontent.com/u/6998306?v=3","gravatar_id":"","url":"https://api.github.com/users/PinpointTownes","html_url":"https://github.com/PinpointTownes","followers_url":"https://api.github.com/users/PinpointTownes/followers","following_url":"https://api.github.com/users/PinpointTownes/following{/other_user}","gists_url":"https://api.github.com/users/PinpointTownes/gists{/gist_id}","starred_url":"https://api.github.com/users/PinpointTownes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PinpointTownes/subscriptions","organizations_url":"https://api.github.com/users/PinpointTownes/orgs","repos_url":"https://api.github.com/users/PinpointTownes/repos","events_url":"https://api.github.com/users/PinpointTownes/events{/privacy}","received_events_url":"https://api.github.com/users/PinpointTownes/received_events","type":"User","site_admin":false},"body":"The PR is a bit noisy but I had to rework large parts of various tests, that were not really conclusive.\r\n\r\n(GitHub accidentally closed my previous PR when I rebased it (https://github.com/aspnet/Security/pull/142) so I had to re-submit it)","created_at":"2015-03-03T15:03:43Z","updated_at":"2015-03-05T22:30:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"677622b9872990563cec80b2b06337ad1aa6c072","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Security/pulls/168/commits","review_comments_url":"https://api.github.com/repos/aspnet/Security/pulls/168/comments","review_comment_url":"https://api.github.com/repos/aspnet/Security/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Security/issues/168/comments","statuses_url":"https://api.github.com/repos/aspnet/Security/statuses/54f2e3a54a02e39afa40b17aaba59a94a0e8ed8d","head":{"label":"PinpointTownes:dev","ref":"dev","sha":"54f2e3a54a02e39afa40b17aaba59a94a0e8ed8d","user":{"login":"PinpointTownes","id":6998306,"avatar_url":"https://avatars.githubusercontent.com/u/6998306?v=3","gravatar_id":"","url":"https://api.github.com/users/PinpointTownes","html_url":"https://github.com/PinpointTownes","followers_url":"https://api.github.com/users/PinpointTownes/followers","following_url":"https://api.github.com/users/PinpointTownes/following{/other_user}","gists_url":"https://api.github.com/users/PinpointTownes/gists{/gist_id}","starred_url":"https://api.github.com/users/PinpointTownes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PinpointTownes/subscriptions","organizations_url":"https://api.github.com/users/PinpointTownes/orgs","repos_url":"https://api.github.com/users/PinpointTownes/repos","events_url":"https://api.github.com/users/PinpointTownes/events{/privacy}","received_events_url":"https://api.github.com/users/PinpointTownes/received_events","type":"User","site_admin":false},"repo":{"id":30196509,"name":"Security","full_name":"PinpointTownes/Security","owner":{"login":"PinpointTownes","id":6998306,"avatar_url":"https://avatars.githubusercontent.com/u/6998306?v=3","gravatar_id":"","url":"https://api.github.com/users/PinpointTownes","html_url":"https://github.com/PinpointTownes","followers_url":"https://api.github.com/users/PinpointTownes/followers","following_url":"https://api.github.com/users/PinpointTownes/following{/other_user}","gists_url":"https://api.github.com/users/PinpointTownes/gists{/gist_id}","starred_url":"https://api.github.com/users/PinpointTownes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PinpointTownes/subscriptions","organizations_url":"https://api.github.com/users/PinpointTownes/orgs","repos_url":"https://api.github.com/users/PinpointTownes/repos","events_url":"https://api.github.com/users/PinpointTownes/events{/privacy}","received_events_url":"https://api.github.com/users/PinpointTownes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PinpointTownes/Security","description":"Middleware for security and authorization of web apps.","fork":true,"url":"https://api.github.com/repos/PinpointTownes/Security","forks_url":"https://api.github.com/repos/PinpointTownes/Security/forks","keys_url":"https://api.github.com/repos/PinpointTownes/Security/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PinpointTownes/Security/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PinpointTownes/Security/teams","hooks_url":"https://api.github.com/repos/PinpointTownes/Security/hooks","issue_events_url":"https://api.github.com/repos/PinpointTownes/Security/issues/events{/number}","events_url":"https://api.github.com/repos/PinpointTownes/Security/events","assignees_url":"https://api.github.com/repos/PinpointTownes/Security/assignees{/user}","branches_url":"https://api.github.com/repos/PinpointTownes/Security/branches{/branch}","tags_url":"https://api.github.com/repos/PinpointTownes/Security/tags","blobs_url":"https://api.github.com/repos/PinpointTownes/Security/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PinpointTownes/Security/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PinpointTownes/Security/git/refs{/sha}","trees_url":"https://api.github.com/repos/PinpointTownes/Security/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PinpointTownes/Security/statuses/{sha}","languages_url":"https://api.github.com/repos/PinpointTownes/Security/languages","stargazers_url":"https://api.github.com/repos/PinpointTownes/Security/stargazers","contributors_url":"https://api.github.com/repos/PinpointTownes/Security/contributors","subscribers_url":"https://api.github.com/repos/PinpointTownes/Security/subscribers","subscription_url":"https://api.github.com/repos/PinpointTownes/Security/subscription","commits_url":"https://api.github.com/repos/PinpointTownes/Security/commits{/sha}","git_commits_url":"https://api.github.com/repos/PinpointTownes/Security/git/commits{/sha}","comments_url":"https://api.github.com/repos/PinpointTownes/Security/comments{/number}","issue_comment_url":"https://api.github.com/repos/PinpointTownes/Security/issues/comments{/number}","contents_url":"https://api.github.com/repos/PinpointTownes/Security/contents/{+path}","compare_url":"https://api.github.com/repos/PinpointTownes/Security/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PinpointTownes/Security/merges","archive_url":"https://api.github.com/repos/PinpointTownes/Security/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PinpointTownes/Security/downloads","issues_url":"https://api.github.com/repos/PinpointTownes/Security/issues{/number}","pulls_url":"https://api.github.com/repos/PinpointTownes/Security/pulls{/number}","milestones_url":"https://api.github.com/repos/PinpointTownes/Security/milestones{/number}","notifications_url":"https://api.github.com/repos/PinpointTownes/Security/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PinpointTownes/Security/labels{/name}","releases_url":"https://api.github.com/repos/PinpointTownes/Security/releases{/id}","created_at":"2015-02-02T16:36:08Z","updated_at":"2015-03-05T19:02:00Z","pushed_at":"2015-03-05T19:01:59Z","git_url":"git://github.com/PinpointTownes/Security.git","ssh_url":"git@github.com:PinpointTownes/Security.git","clone_url":"https://github.com/PinpointTownes/Security.git","svn_url":"https://github.com/PinpointTownes/Security","homepage":"","size":747,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"08017f992ae9c408f50c6ef7f5048fc7c063bf09","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":17723699,"name":"Security","full_name":"aspnet/Security","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Security","description":"Middleware for security and authorization of web apps.","fork":false,"url":"https://api.github.com/repos/aspnet/Security","forks_url":"https://api.github.com/repos/aspnet/Security/forks","keys_url":"https://api.github.com/repos/aspnet/Security/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Security/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Security/teams","hooks_url":"https://api.github.com/repos/aspnet/Security/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Security/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Security/events","assignees_url":"https://api.github.com/repos/aspnet/Security/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Security/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Security/tags","blobs_url":"https://api.github.com/repos/aspnet/Security/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Security/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Security/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Security/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Security/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Security/languages","stargazers_url":"https://api.github.com/repos/aspnet/Security/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Security/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Security/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Security/subscription","commits_url":"https://api.github.com/repos/aspnet/Security/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Security/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Security/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Security/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Security/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Security/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Security/merges","archive_url":"https://api.github.com/repos/aspnet/Security/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Security/downloads","issues_url":"https://api.github.com/repos/aspnet/Security/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Security/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Security/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Security/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Security/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Security/releases{/id}","created_at":"2014-03-13T19:44:34Z","updated_at":"2015-03-05T07:29:22Z","pushed_at":"2015-03-05T07:29:21Z","git_url":"git://github.com/aspnet/Security.git","ssh_url":"git@github.com:aspnet/Security.git","clone_url":"https://github.com/aspnet/Security.git","svn_url":"https://github.com/aspnet/Security","homepage":"","size":3218,"stargazers_count":111,"watchers_count":111,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":47,"forks":43,"open_issues":47,"watchers":111,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Security/pulls/168"},"html":{"href":"https://github.com/aspnet/Security/pull/168"},"issue":{"href":"https://api.github.com/repos/aspnet/Security/issues/168"},"comments":{"href":"https://api.github.com/repos/aspnet/Security/issues/168/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Security/pulls/168/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Security/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Security/pulls/168/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Security/statuses/54f2e3a54a02e39afa40b17aaba59a94a0e8ed8d"}}}}