{"action":"created","comment":{"url":"https://api.github.com/repos/rancherio/cattle/pulls/comments/30764436","id":30764436,"diff_hunk":"@@ -344,17 +354,20 @@ protected ReportedInstances getInstances(Ping ping) {\n     }\n \n     protected AgentAndHost loadAgentAndHostData(ImmutablePair<Long, String> agentIdAndHostUuid) {","path":"code/iaas/ha/src/main/java/io/cattle/platform/ha/monitor/impl/PingInstancesMonitorImpl.java","position":32,"original_position":32,"commit_id":"1f2bb15223c48f4466e66c4fc48ddb9481b46603","original_commit_id":"1f2bb15223c48f4466e66c4fc48ddb9481b46603","user":{"login":"cjellick","id":2473240,"avatar_url":"https://avatars.githubusercontent.com/u/2473240?v=3","gravatar_id":"","url":"https://api.github.com/users/cjellick","html_url":"https://github.com/cjellick","followers_url":"https://api.github.com/users/cjellick/followers","following_url":"https://api.github.com/users/cjellick/following{/other_user}","gists_url":"https://api.github.com/users/cjellick/gists{/gist_id}","starred_url":"https://api.github.com/users/cjellick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjellick/subscriptions","organizations_url":"https://api.github.com/users/cjellick/orgs","repos_url":"https://api.github.com/users/cjellick/repos","events_url":"https://api.github.com/users/cjellick/events{/privacy}","received_events_url":"https://api.github.com/users/cjellick/received_events","type":"User","site_admin":false},"body":"@alena1108 It is a pair because of how the LoadingCache works. The pair is the key to its map:\r\nhttps://github.com/rancherio/cattle/pull/466/files#diff-ba9537ff87cd70d9ee6498f7391d5ea1R88\r\nand I must provide a method that will load a value based off of that key.","created_at":"2015-05-21T00:48:24Z","updated_at":"2015-05-21T00:48:24Z","html_url":"https://github.com/rancherio/cattle/pull/466#discussion_r30764436","pull_request_url":"https://api.github.com/repos/rancherio/cattle/pulls/466","_links":{"self":{"href":"https://api.github.com/repos/rancherio/cattle/pulls/comments/30764436"},"html":{"href":"https://github.com/rancherio/cattle/pull/466#discussion_r30764436"},"pull_request":{"href":"https://api.github.com/repos/rancherio/cattle/pulls/466"}}},"pull_request":{"url":"https://api.github.com/repos/rancherio/cattle/pulls/466","id":35883547,"html_url":"https://github.com/rancherio/cattle/pull/466","diff_url":"https://github.com/rancherio/cattle/pull/466.diff","patch_url":"https://github.com/rancherio/cattle/pull/466.patch","issue_url":"https://api.github.com/repos/rancherio/cattle/issues/466","number":466,"state":"open","locked":false,"title":"Handle unfound host for agent better in ping","user":{"login":"cjellick","id":2473240,"avatar_url":"https://avatars.githubusercontent.com/u/2473240?v=3","gravatar_id":"","url":"https://api.github.com/users/cjellick","html_url":"https://github.com/cjellick","followers_url":"https://api.github.com/users/cjellick/followers","following_url":"https://api.github.com/users/cjellick/following{/other_user}","gists_url":"https://api.github.com/users/cjellick/gists{/gist_id}","starred_url":"https://api.github.com/users/cjellick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjellick/subscriptions","organizations_url":"https://api.github.com/users/cjellick/orgs","repos_url":"https://api.github.com/users/cjellick/repos","events_url":"https://api.github.com/users/cjellick/events{/privacy}","received_events_url":"https://api.github.com/users/cjellick/received_events","type":"User","site_admin":false},"body":"LoadingCache doesn't allow null values. If you want to indicate that a\r\nvalue could not be found for your key, you must raise (and handle) an exception.\r\n\r\nThe returned value can be null if a ping occurs between an agent responds to an instance ping before the host has been created.","created_at":"2015-05-20T22:35:57Z","updated_at":"2015-05-21T00:48:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5816e55898c9e4ad329cb3b719e3c48ae493c03d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rancherio/cattle/pulls/466/commits","review_comments_url":"https://api.github.com/repos/rancherio/cattle/pulls/466/comments","review_comment_url":"https://api.github.com/repos/rancherio/cattle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rancherio/cattle/issues/466/comments","statuses_url":"https://api.github.com/repos/rancherio/cattle/statuses/1f2bb15223c48f4466e66c4fc48ddb9481b46603","head":{"label":"cjellick:no-host-on-ping-fix","ref":"no-host-on-ping-fix","sha":"1f2bb15223c48f4466e66c4fc48ddb9481b46603","user":{"login":"cjellick","id":2473240,"avatar_url":"https://avatars.githubusercontent.com/u/2473240?v=3","gravatar_id":"","url":"https://api.github.com/users/cjellick","html_url":"https://github.com/cjellick","followers_url":"https://api.github.com/users/cjellick/followers","following_url":"https://api.github.com/users/cjellick/following{/other_user}","gists_url":"https://api.github.com/users/cjellick/gists{/gist_id}","starred_url":"https://api.github.com/users/cjellick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjellick/subscriptions","organizations_url":"https://api.github.com/users/cjellick/orgs","repos_url":"https://api.github.com/users/cjellick/repos","events_url":"https://api.github.com/users/cjellick/events{/privacy}","received_events_url":"https://api.github.com/users/cjellick/received_events","type":"User","site_admin":false},"repo":{"id":26793817,"name":"cattle","full_name":"cjellick/cattle","owner":{"login":"cjellick","id":2473240,"avatar_url":"https://avatars.githubusercontent.com/u/2473240?v=3","gravatar_id":"","url":"https://api.github.com/users/cjellick","html_url":"https://github.com/cjellick","followers_url":"https://api.github.com/users/cjellick/followers","following_url":"https://api.github.com/users/cjellick/following{/other_user}","gists_url":"https://api.github.com/users/cjellick/gists{/gist_id}","starred_url":"https://api.github.com/users/cjellick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjellick/subscriptions","organizations_url":"https://api.github.com/users/cjellick/orgs","repos_url":"https://api.github.com/users/cjellick/repos","events_url":"https://api.github.com/users/cjellick/events{/privacy}","received_events_url":"https://api.github.com/users/cjellick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cjellick/cattle","description":"Infrastructure orchestration platform","fork":true,"url":"https://api.github.com/repos/cjellick/cattle","forks_url":"https://api.github.com/repos/cjellick/cattle/forks","keys_url":"https://api.github.com/repos/cjellick/cattle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cjellick/cattle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cjellick/cattle/teams","hooks_url":"https://api.github.com/repos/cjellick/cattle/hooks","issue_events_url":"https://api.github.com/repos/cjellick/cattle/issues/events{/number}","events_url":"https://api.github.com/repos/cjellick/cattle/events","assignees_url":"https://api.github.com/repos/cjellick/cattle/assignees{/user}","branches_url":"https://api.github.com/repos/cjellick/cattle/branches{/branch}","tags_url":"https://api.github.com/repos/cjellick/cattle/tags","blobs_url":"https://api.github.com/repos/cjellick/cattle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cjellick/cattle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cjellick/cattle/git/refs{/sha}","trees_url":"https://api.github.com/repos/cjellick/cattle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cjellick/cattle/statuses/{sha}","languages_url":"https://api.github.com/repos/cjellick/cattle/languages","stargazers_url":"https://api.github.com/repos/cjellick/cattle/stargazers","contributors_url":"https://api.github.com/repos/cjellick/cattle/contributors","subscribers_url":"https://api.github.com/repos/cjellick/cattle/subscribers","subscription_url":"https://api.github.com/repos/cjellick/cattle/subscription","commits_url":"https://api.github.com/repos/cjellick/cattle/commits{/sha}","git_commits_url":"https://api.github.com/repos/cjellick/cattle/git/commits{/sha}","comments_url":"https://api.github.com/repos/cjellick/cattle/comments{/number}","issue_comment_url":"https://api.github.com/repos/cjellick/cattle/issues/comments{/number}","contents_url":"https://api.github.com/repos/cjellick/cattle/contents/{+path}","compare_url":"https://api.github.com/repos/cjellick/cattle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cjellick/cattle/merges","archive_url":"https://api.github.com/repos/cjellick/cattle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cjellick/cattle/downloads","issues_url":"https://api.github.com/repos/cjellick/cattle/issues{/number}","pulls_url":"https://api.github.com/repos/cjellick/cattle/pulls{/number}","milestones_url":"https://api.github.com/repos/cjellick/cattle/milestones{/number}","notifications_url":"https://api.github.com/repos/cjellick/cattle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cjellick/cattle/labels{/name}","releases_url":"https://api.github.com/repos/cjellick/cattle/releases{/id}","created_at":"2014-11-18T05:41:56Z","updated_at":"2015-04-02T20:43:46Z","pushed_at":"2015-05-21T00:25:58Z","git_url":"git://github.com/cjellick/cattle.git","ssh_url":"git@github.com:cjellick/cattle.git","clone_url":"https://github.com/cjellick/cattle.git","svn_url":"https://github.com/cjellick/cattle","homepage":"","size":18594,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rancherio:master","ref":"master","sha":"6c11c887f740a825aa7264d31da5ae2507a6ad41","user":{"login":"rancherio","id":9343010,"avatar_url":"https://avatars.githubusercontent.com/u/9343010?v=3","gravatar_id":"","url":"https://api.github.com/users/rancherio","html_url":"https://github.com/rancherio","followers_url":"https://api.github.com/users/rancherio/followers","following_url":"https://api.github.com/users/rancherio/following{/other_user}","gists_url":"https://api.github.com/users/rancherio/gists{/gist_id}","starred_url":"https://api.github.com/users/rancherio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rancherio/subscriptions","organizations_url":"https://api.github.com/users/rancherio/orgs","repos_url":"https://api.github.com/users/rancherio/repos","events_url":"https://api.github.com/users/rancherio/events{/privacy}","received_events_url":"https://api.github.com/users/rancherio/received_events","type":"Organization","site_admin":false},"repo":{"id":18023059,"name":"cattle","full_name":"rancherio/cattle","owner":{"login":"rancherio","id":9343010,"avatar_url":"https://avatars.githubusercontent.com/u/9343010?v=3","gravatar_id":"","url":"https://api.github.com/users/rancherio","html_url":"https://github.com/rancherio","followers_url":"https://api.github.com/users/rancherio/followers","following_url":"https://api.github.com/users/rancherio/following{/other_user}","gists_url":"https://api.github.com/users/rancherio/gists{/gist_id}","starred_url":"https://api.github.com/users/rancherio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rancherio/subscriptions","organizations_url":"https://api.github.com/users/rancherio/orgs","repos_url":"https://api.github.com/users/rancherio/repos","events_url":"https://api.github.com/users/rancherio/events{/privacy}","received_events_url":"https://api.github.com/users/rancherio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rancherio/cattle","description":"Infrastructure orchestration platform","fork":false,"url":"https://api.github.com/repos/rancherio/cattle","forks_url":"https://api.github.com/repos/rancherio/cattle/forks","keys_url":"https://api.github.com/repos/rancherio/cattle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rancherio/cattle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rancherio/cattle/teams","hooks_url":"https://api.github.com/repos/rancherio/cattle/hooks","issue_events_url":"https://api.github.com/repos/rancherio/cattle/issues/events{/number}","events_url":"https://api.github.com/repos/rancherio/cattle/events","assignees_url":"https://api.github.com/repos/rancherio/cattle/assignees{/user}","branches_url":"https://api.github.com/repos/rancherio/cattle/branches{/branch}","tags_url":"https://api.github.com/repos/rancherio/cattle/tags","blobs_url":"https://api.github.com/repos/rancherio/cattle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rancherio/cattle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rancherio/cattle/git/refs{/sha}","trees_url":"https://api.github.com/repos/rancherio/cattle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rancherio/cattle/statuses/{sha}","languages_url":"https://api.github.com/repos/rancherio/cattle/languages","stargazers_url":"https://api.github.com/repos/rancherio/cattle/stargazers","contributors_url":"https://api.github.com/repos/rancherio/cattle/contributors","subscribers_url":"https://api.github.com/repos/rancherio/cattle/subscribers","subscription_url":"https://api.github.com/repos/rancherio/cattle/subscription","commits_url":"https://api.github.com/repos/rancherio/cattle/commits{/sha}","git_commits_url":"https://api.github.com/repos/rancherio/cattle/git/commits{/sha}","comments_url":"https://api.github.com/repos/rancherio/cattle/comments{/number}","issue_comment_url":"https://api.github.com/repos/rancherio/cattle/issues/comments{/number}","contents_url":"https://api.github.com/repos/rancherio/cattle/contents/{+path}","compare_url":"https://api.github.com/repos/rancherio/cattle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rancherio/cattle/merges","archive_url":"https://api.github.com/repos/rancherio/cattle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rancherio/cattle/downloads","issues_url":"https://api.github.com/repos/rancherio/cattle/issues{/number}","pulls_url":"https://api.github.com/repos/rancherio/cattle/pulls{/number}","milestones_url":"https://api.github.com/repos/rancherio/cattle/milestones{/number}","notifications_url":"https://api.github.com/repos/rancherio/cattle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rancherio/cattle/labels{/name}","releases_url":"https://api.github.com/repos/rancherio/cattle/releases{/id}","created_at":"2014-03-23T00:19:52Z","updated_at":"2015-05-20T23:38:15Z","pushed_at":"2015-05-21T00:25:59Z","git_url":"git://github.com/rancherio/cattle.git","ssh_url":"git@github.com:rancherio/cattle.git","clone_url":"https://github.com/rancherio/cattle.git","svn_url":"https://github.com/rancherio/cattle","homepage":"","size":26860,"stargazers_count":136,"watchers_count":136,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":91,"forks":31,"open_issues":91,"watchers":136,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rancherio/cattle/pulls/466"},"html":{"href":"https://github.com/rancherio/cattle/pull/466"},"issue":{"href":"https://api.github.com/repos/rancherio/cattle/issues/466"},"comments":{"href":"https://api.github.com/repos/rancherio/cattle/issues/466/comments"},"review_comments":{"href":"https://api.github.com/repos/rancherio/cattle/pulls/466/comments"},"review_comment":{"href":"https://api.github.com/repos/rancherio/cattle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rancherio/cattle/pulls/466/commits"},"statuses":{"href":"https://api.github.com/repos/rancherio/cattle/statuses/1f2bb15223c48f4466e66c4fc48ddb9481b46603"}}}}