{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/deployment-manager/pulls/comments/45532383","id":45532383,"diff_hunk":"@@ -0,0 +1,6 @@\n+imports:","path":"templates/spark/v1/spark.yaml","position":1,"original_position":1,"commit_id":"14995d278e71e86b118f87ad20bba08a93fc321a","original_commit_id":"14995d278e71e86b118f87ad20bba08a93fc321a","user":{"login":"zmerlynn","id":4942464,"avatar_url":"https://avatars.githubusercontent.com/u/4942464?v=3","gravatar_id":"","url":"https://api.github.com/users/zmerlynn","html_url":"https://github.com/zmerlynn","followers_url":"https://api.github.com/users/zmerlynn/followers","following_url":"https://api.github.com/users/zmerlynn/following{/other_user}","gists_url":"https://api.github.com/users/zmerlynn/gists{/gist_id}","starred_url":"https://api.github.com/users/zmerlynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmerlynn/subscriptions","organizations_url":"https://api.github.com/users/zmerlynn/orgs","repos_url":"https://api.github.com/users/zmerlynn/repos","events_url":"https://api.github.com/users/zmerlynn/events{/privacy}","received_events_url":"https://api.github.com/users/zmerlynn/received_events","type":"User","site_admin":false},"body":"Althought then I think you get into even more annoyance of not having a local registry, because you end up launching this file as `example.yaml`, and have one of those things running around, which is weird.","created_at":"2015-11-20T23:29:06Z","updated_at":"2015-11-20T23:29:06Z","html_url":"https://github.com/kubernetes/deployment-manager/pull/117#discussion_r45532383","pull_request_url":"https://api.github.com/repos/kubernetes/deployment-manager/pulls/117","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/deployment-manager/pulls/comments/45532383"},"html":{"href":"https://github.com/kubernetes/deployment-manager/pull/117#discussion_r45532383"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/deployment-manager/pulls/117"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/deployment-manager/pulls/117","id":51387510,"html_url":"https://github.com/kubernetes/deployment-manager/pull/117","diff_url":"https://github.com/kubernetes/deployment-manager/pull/117.diff","patch_url":"https://github.com/kubernetes/deployment-manager/pull/117.patch","issue_url":"https://api.github.com/repos/kubernetes/deployment-manager/issues/117","number":117,"state":"open","locked":false,"title":"Spark: Add DM template for Spark","user":{"login":"zmerlynn","id":4942464,"avatar_url":"https://avatars.githubusercontent.com/u/4942464?v=3","gravatar_id":"","url":"https://api.github.com/users/zmerlynn","html_url":"https://github.com/zmerlynn","followers_url":"https://api.github.com/users/zmerlynn/followers","following_url":"https://api.github.com/users/zmerlynn/following{/other_user}","gists_url":"https://api.github.com/users/zmerlynn/gists{/gist_id}","starred_url":"https://api.github.com/users/zmerlynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmerlynn/subscriptions","organizations_url":"https://api.github.com/users/zmerlynn/orgs","repos_url":"https://api.github.com/users/zmerlynn/repos","events_url":"https://api.github.com/users/zmerlynn/events{/privacy}","received_events_url":"https://api.github.com/users/zmerlynn/received_events","type":"User","site_admin":false},"body":"This is a first-cut template based on https://github.com/kubernetes/kubernetes/tree/master/examples/spark with minor templating. As I iterate on that example to add PDs, etc. (which will add much more variance), I'll iterate here, too.\r\n\r\nSome minor friction here:\r\n* What is the type \"version\"? For an app, does it make more sense to use the semver of the app stack version, since at the end of the day, the use is going to deploy this as `dm deploy spark:v1` or `dm deploy spark:v1.5.1-p.1` and the latter might make more sense (especially if `update` works sanely). (I think this question might be different for base types than for types/templates that are really \"packages\".) (BTW, there's a Zeppelin version here, too, but it's pretty intimately tied to the Spark version as well.)\r\n* #71 is an example of why I think #25 needs to get resolved soon. I can't actually modify base types without a local type registry. If there were shorthanded types that could actually resolve to a local registry in my git repo as well, this would work, and I could resolve the TODO in this PR. As it is, I chose a different path than @LeendersR, and I'll eventually submit follow-on PRs to iterate on the base-types. (Or not, because I'm trying to decide if I like that base type for this case.)","created_at":"2015-11-20T17:57:36Z","updated_at":"2015-11-20T23:29:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf65417b6bdbcf6115b7c9af4a1593f86c134dc0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/deployment-manager/pulls/117/commits","review_comments_url":"https://api.github.com/repos/kubernetes/deployment-manager/pulls/117/comments","review_comment_url":"https://api.github.com/repos/kubernetes/deployment-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/deployment-manager/issues/117/comments","statuses_url":"https://api.github.com/repos/kubernetes/deployment-manager/statuses/14995d278e71e86b118f87ad20bba08a93fc321a","head":{"label":"zmerlynn:spark","ref":"spark","sha":"14995d278e71e86b118f87ad20bba08a93fc321a","user":{"login":"zmerlynn","id":4942464,"avatar_url":"https://avatars.githubusercontent.com/u/4942464?v=3","gravatar_id":"","url":"https://api.github.com/users/zmerlynn","html_url":"https://github.com/zmerlynn","followers_url":"https://api.github.com/users/zmerlynn/followers","following_url":"https://api.github.com/users/zmerlynn/following{/other_user}","gists_url":"https://api.github.com/users/zmerlynn/gists{/gist_id}","starred_url":"https://api.github.com/users/zmerlynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmerlynn/subscriptions","organizations_url":"https://api.github.com/users/zmerlynn/orgs","repos_url":"https://api.github.com/users/zmerlynn/repos","events_url":"https://api.github.com/users/zmerlynn/events{/privacy}","received_events_url":"https://api.github.com/users/zmerlynn/received_events","type":"User","site_admin":false},"repo":{"id":46577097,"name":"deployment-manager","full_name":"zmerlynn/deployment-manager","owner":{"login":"zmerlynn","id":4942464,"avatar_url":"https://avatars.githubusercontent.com/u/4942464?v=3","gravatar_id":"","url":"https://api.github.com/users/zmerlynn","html_url":"https://github.com/zmerlynn","followers_url":"https://api.github.com/users/zmerlynn/followers","following_url":"https://api.github.com/users/zmerlynn/following{/other_user}","gists_url":"https://api.github.com/users/zmerlynn/gists{/gist_id}","starred_url":"https://api.github.com/users/zmerlynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmerlynn/subscriptions","organizations_url":"https://api.github.com/users/zmerlynn/orgs","repos_url":"https://api.github.com/users/zmerlynn/repos","events_url":"https://api.github.com/users/zmerlynn/events{/privacy}","received_events_url":"https://api.github.com/users/zmerlynn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zmerlynn/deployment-manager","description":"Deployment Manager on Kubernetes","fork":true,"url":"https://api.github.com/repos/zmerlynn/deployment-manager","forks_url":"https://api.github.com/repos/zmerlynn/deployment-manager/forks","keys_url":"https://api.github.com/repos/zmerlynn/deployment-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zmerlynn/deployment-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zmerlynn/deployment-manager/teams","hooks_url":"https://api.github.com/repos/zmerlynn/deployment-manager/hooks","issue_events_url":"https://api.github.com/repos/zmerlynn/deployment-manager/issues/events{/number}","events_url":"https://api.github.com/repos/zmerlynn/deployment-manager/events","assignees_url":"https://api.github.com/repos/zmerlynn/deployment-manager/assignees{/user}","branches_url":"https://api.github.com/repos/zmerlynn/deployment-manager/branches{/branch}","tags_url":"https://api.github.com/repos/zmerlynn/deployment-manager/tags","blobs_url":"https://api.github.com/repos/zmerlynn/deployment-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zmerlynn/deployment-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zmerlynn/deployment-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/zmerlynn/deployment-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zmerlynn/deployment-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/zmerlynn/deployment-manager/languages","stargazers_url":"https://api.github.com/repos/zmerlynn/deployment-manager/stargazers","contributors_url":"https://api.github.com/repos/zmerlynn/deployment-manager/contributors","subscribers_url":"https://api.github.com/repos/zmerlynn/deployment-manager/subscribers","subscription_url":"https://api.github.com/repos/zmerlynn/deployment-manager/subscription","commits_url":"https://api.github.com/repos/zmerlynn/deployment-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/zmerlynn/deployment-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/zmerlynn/deployment-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/zmerlynn/deployment-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/zmerlynn/deployment-manager/contents/{+path}","compare_url":"https://api.github.com/repos/zmerlynn/deployment-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zmerlynn/deployment-manager/merges","archive_url":"https://api.github.com/repos/zmerlynn/deployment-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zmerlynn/deployment-manager/downloads","issues_url":"https://api.github.com/repos/zmerlynn/deployment-manager/issues{/number}","pulls_url":"https://api.github.com/repos/zmerlynn/deployment-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/zmerlynn/deployment-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/zmerlynn/deployment-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zmerlynn/deployment-manager/labels{/name}","releases_url":"https://api.github.com/repos/zmerlynn/deployment-manager/releases{/id}","created_at":"2015-11-20T17:37:27Z","updated_at":"2015-11-20T17:37:28Z","pushed_at":"2015-11-20T17:40:19Z","git_url":"git://github.com/zmerlynn/deployment-manager.git","ssh_url":"git@github.com:zmerlynn/deployment-manager.git","clone_url":"https://github.com/zmerlynn/deployment-manager.git","svn_url":"https://github.com/zmerlynn/deployment-manager","homepage":null,"size":235,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"14c5adb33442e807924a3c1ff7885011d10186e3","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":43723161,"name":"deployment-manager","full_name":"kubernetes/deployment-manager","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/deployment-manager","description":"Deployment Manager on Kubernetes","fork":false,"url":"https://api.github.com/repos/kubernetes/deployment-manager","forks_url":"https://api.github.com/repos/kubernetes/deployment-manager/forks","keys_url":"https://api.github.com/repos/kubernetes/deployment-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/deployment-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/deployment-manager/teams","hooks_url":"https://api.github.com/repos/kubernetes/deployment-manager/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/deployment-manager/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/deployment-manager/events","assignees_url":"https://api.github.com/repos/kubernetes/deployment-manager/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/deployment-manager/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/deployment-manager/tags","blobs_url":"https://api.github.com/repos/kubernetes/deployment-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/deployment-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/deployment-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/deployment-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/deployment-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/deployment-manager/languages","stargazers_url":"https://api.github.com/repos/kubernetes/deployment-manager/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/deployment-manager/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/deployment-manager/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/deployment-manager/subscription","commits_url":"https://api.github.com/repos/kubernetes/deployment-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/deployment-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/deployment-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/deployment-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/deployment-manager/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/deployment-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/deployment-manager/merges","archive_url":"https://api.github.com/repos/kubernetes/deployment-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/deployment-manager/downloads","issues_url":"https://api.github.com/repos/kubernetes/deployment-manager/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/deployment-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/deployment-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/deployment-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/deployment-manager/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/deployment-manager/releases{/id}","created_at":"2015-10-06T01:07:32Z","updated_at":"2015-11-20T15:03:30Z","pushed_at":"2015-11-20T22:10:41Z","git_url":"git://github.com/kubernetes/deployment-manager.git","ssh_url":"git@github.com:kubernetes/deployment-manager.git","clone_url":"https://github.com/kubernetes/deployment-manager.git","svn_url":"https://github.com/kubernetes/deployment-manager","homepage":null,"size":5498,"stargazers_count":41,"watchers_count":41,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":40,"forks":13,"open_issues":40,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/deployment-manager/pulls/117"},"html":{"href":"https://github.com/kubernetes/deployment-manager/pull/117"},"issue":{"href":"https://api.github.com/repos/kubernetes/deployment-manager/issues/117"},"comments":{"href":"https://api.github.com/repos/kubernetes/deployment-manager/issues/117/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/deployment-manager/pulls/117/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/deployment-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/deployment-manager/pulls/117/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/deployment-manager/statuses/14995d278e71e86b118f87ad20bba08a93fc321a"}}}}