{"action":"created","issue":{"url":"https://api.github.com/repos/ipfs/node-ipfs-api/issues/81","labels_url":"https://api.github.com/repos/ipfs/node-ipfs-api/issues/81/labels{/name}","comments_url":"https://api.github.com/repos/ipfs/node-ipfs-api/issues/81/comments","events_url":"https://api.github.com/repos/ipfs/node-ipfs-api/issues/81/events","html_url":"https://github.com/ipfs/node-ipfs-api/pull/81","id":112685146,"number":81,"title":"Make solid tests for node-ipfs-api","user":{"login":"diasdavid","id":1211152,"avatar_url":"https://avatars.githubusercontent.com/u/1211152?v=3","gravatar_id":"","url":"https://api.github.com/users/diasdavid","html_url":"https://github.com/diasdavid","followers_url":"https://api.github.com/users/diasdavid/followers","following_url":"https://api.github.com/users/diasdavid/following{/other_user}","gists_url":"https://api.github.com/users/diasdavid/gists{/gist_id}","starred_url":"https://api.github.com/users/diasdavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diasdavid/subscriptions","organizations_url":"https://api.github.com/users/diasdavid/orgs","repos_url":"https://api.github.com/users/diasdavid/repos","events_url":"https://api.github.com/users/diasdavid/events{/privacy}","received_events_url":"https://api.github.com/users/diasdavid/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ipfs/node-ipfs-api/labels/help%20wanted","name":"help wanted","color":"159818"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":22,"created_at":"2015-10-21T21:40:32Z","updated_at":"2015-10-28T20:34:50Z","closed_at":"2015-10-28T20:19:20Z","pull_request":{"url":"https://api.github.com/repos/ipfs/node-ipfs-api/pulls/81","html_url":"https://github.com/ipfs/node-ipfs-api/pull/81","diff_url":"https://github.com/ipfs/node-ipfs-api/pull/81.diff","patch_url":"https://github.com/ipfs/node-ipfs-api/pull/81.patch"},"body":"This endeavour was started and pushed forward by @Dignifiedquire and @VictorBjelkholm (<3 ref: https://github.com/ipfs/node-ipfs-api/pull/78 https://github.com/ipfs/node-ipfs-api/pull/77), but we welcome anyone who wants to contribute.\r\n\r\nGoal: Have a complete test suit for node-ipfs-api that test both in Node.js and in the Browser.\r\nStretch goal: Have code coverage checking\r\n\r\nThis PR will be focused on making tests for IPFS version 0.3.7 (version 0.3.8 will require an update on the request-api.js parser)\r\n\r\nHistorically, we have had problems because tests are using the global network to perform the DHT queries, this makes testing slow and somewhat unreliable. Tests should their own IPFS cluster, for testing against the global network, we must have _integration_ tests, but that can be the next step.\r\n\r\n### API\r\n\r\n\r\n- [x] before tests run\r\n - [x] start 3 disposable IPFS nodes, connect them in a triangle (needs: https://github.com/ipfs/node-ipfsd-ctl/issues/24 https://github.com/ipfs/node-ipfsd-ctl/pull/25)\r\n- [x] .send\r\n  - [x] node.js\r\n  - [x] browser\r\n- [ ] .add\r\n  - [ ] .add a file\r\n    - [x] node.js\r\n    - [ ] browser\r\n  - [ ] .add a buffer\r\n    - [x] node.js\r\n    - [ ] browser\r\n  - [ ] .add a path\r\n    - [x] node.js\r\n    - [ ] browser\r\n  - [ ] .add a folder (nested)\r\n    - [x] node.js\r\n    - [ ] browser\r\n- [ ] .cat\r\n  - [x] node.js\r\n  - [ ] browser\r\n- [ ] .ls\r\n  - [x] node.js\r\n  - [ ] browser\r\n- [ ] .config\r\n  - [ ] .config.get\r\n    - [x] node.js\r\n    - [ ] browser\r\n  - [ ] .config.set\r\n    - [x] node.js\r\n    - [ ] browser\r\n  - [ ] .config.show\r\n    - [x] node.js\r\n    - [ ] browser\r\n  - [ ] .config.replace\r\n    - [x] node.js\r\n    - [ ] browser\r\n- [ ] ~~.update~~ (Currently disabled, wait for version 0.4.0 release)\r\n- [ ] .version\r\n  - [x] node.js\r\n  - [ ] browser\r\n- [ ] .commands\r\n  - [x] node.js\r\n  - [ ] browser\r\n- [ ] ~~.mount~~ (Requires FUSE, not practical for testing in node-ipfs-api)\r\n- [ ] .diag\r\n  - [ ] .diag.net\r\n    - [x] node.js\r\n    - [ ] browser\r\n- [ ] .block\r\n  - [ ] .block.get\r\n    - [x] node.js\r\n    - [ ] browser\r\n  - [ ] .block.put\r\n    - [x] node.js\r\n    - [ ] browser\r\n- [ ] .object\r\n  - [ ] .object.get\r\n    - [x] node.js\r\n    - [ ] browser\r\n  - [ ] .object.put\r\n    - [x] node.js\r\n    - [ ] browser\r\n  - [ ] .object.data\r\n    - [x] node.js\r\n    - [ ] browser\r\n  - [ ] .object.stat\r\n    - [x] node.js\r\n    - [ ] browser\r\n  - [ ] .object.links\r\n    - [x] node.js\r\n    - [ ] browser\r\n- [ ] .swarm\r\n  - [ ] .swarm.peers\r\n    - [x] node.js\r\n    - [ ] browser\r\n  - [ ] .swarm.connect\r\n    - [x] node.js\r\n    - [ ] browser\r\n- [ ] .ping\r\n  - [x] node.js\r\n  - [ ] browser\r\n- [ ] .id\r\n  - [x] node.js\r\n  - [ ] browser\r\n- [ ] .pin\r\n  - [ ] .pin.add\r\n    - [x] node.js\r\n    - [ ] browser\r\n  - [ ] .pin.remove\r\n    - [x] node.js\r\n    - [ ] browser\r\n  - [ ] .pin.list\r\n    - [x] node.js\r\n    - [ ] browser\r\n- [x] ~~.gateway~~ this doesn't exist anymore on the http api\r\n  - [x] ~~.gateway.enable~~\r\n  - [x] ~~.gateway.disable~~\r\n- [ ] log\r\n  - [ ] log.tail (needs 0.3.9 ndjson stuff)\r\n- [ ] .name\r\n  - [ ] .name.publish\r\n    - [x] node.js\r\n    - [ ] browser\r\n  - [ ] .name.resolve\r\n    - [x] node.js\r\n    - [ ] browser\r\n- [ ] .Buffer (do we still need to expose Buffer? Node.js now uses TypedArrays, so it shouldn't be necessary)\r\n  - [ ] node.js\r\n  - [ ] browser\r\n- [ ] .refs\r\n  - [ ] .refs.local\r\n    - [x] node.js\r\n    - [ ] browser\r\n- [ ] .dht\r\n  - [ ] .dht.findprovs\r\n    - [x] node.js\r\n    - [ ] browser\r\n  - [ ] .dht.get\r\n    - [x] node.js\r\n    - [ ] browser\r\n  - [ ] .dht.put\r\n    - [x] node.js\r\n    - [ ] browser"},"comment":{"url":"https://api.github.com/repos/ipfs/node-ipfs-api/issues/comments/151982602","html_url":"https://github.com/ipfs/node-ipfs-api/pull/81#issuecomment-151982602","issue_url":"https://api.github.com/repos/ipfs/node-ipfs-api/issues/81","id":151982602,"user":{"login":"VictorBjelkholm","id":459764,"avatar_url":"https://avatars.githubusercontent.com/u/459764?v=3","gravatar_id":"","url":"https://api.github.com/users/VictorBjelkholm","html_url":"https://github.com/VictorBjelkholm","followers_url":"https://api.github.com/users/VictorBjelkholm/followers","following_url":"https://api.github.com/users/VictorBjelkholm/following{/other_user}","gists_url":"https://api.github.com/users/VictorBjelkholm/gists{/gist_id}","starred_url":"https://api.github.com/users/VictorBjelkholm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VictorBjelkholm/subscriptions","organizations_url":"https://api.github.com/users/VictorBjelkholm/orgs","repos_url":"https://api.github.com/users/VictorBjelkholm/repos","events_url":"https://api.github.com/users/VictorBjelkholm/events{/privacy}","received_events_url":"https://api.github.com/users/VictorBjelkholm/received_events","type":"User","site_admin":false},"created_at":"2015-10-28T20:34:50Z","updated_at":"2015-10-28T20:34:50Z","body":"Finally! Great job @Dignifiedquire @diasdavid 👍👍🏻👍🏻👍🏻👍🏻👍🏻"}}