{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/26918876","id":26918876,"diff_hunk":"@@ -28,6 +29,8 @@ var BookmarkEditor = {\n     this.cancelButton = document.getElementById('cancel-button');\n     this.saveButton = document.getElementById('done-button');\n     this.appInstallationSection = document.getElementById('app-installation');\n+    this.appIcon = document.getElementById('app-icon');","path":"apps/bookmark/js/bookmark_editor.js","position":12,"original_position":12,"commit_id":"efab1ca0cfca24cc441c982d8665cd30292832c9","original_commit_id":"efab1ca0cfca24cc441c982d8665cd30292832c9","user":{"login":"crdlc","id":1722741,"avatar_url":"https://avatars.githubusercontent.com/u/1722741?v=3","gravatar_id":"","url":"https://api.github.com/users/crdlc","html_url":"https://github.com/crdlc","followers_url":"https://api.github.com/users/crdlc/followers","following_url":"https://api.github.com/users/crdlc/following{/other_user}","gists_url":"https://api.github.com/users/crdlc/gists{/gist_id}","starred_url":"https://api.github.com/users/crdlc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crdlc/subscriptions","organizations_url":"https://api.github.com/users/crdlc/orgs","repos_url":"https://api.github.com/users/crdlc/repos","events_url":"https://api.github.com/users/crdlc/events{/privacy}","received_events_url":"https://api.github.com/users/crdlc/received_events","type":"User","site_admin":false},"body":"Up to you, although I would mote these vars to https://github.com/mozilla-b2g/gaia/pull/29024/files#diff-32abdeb6061956598cbede801aa9bc1aR86 and https://github.com/mozilla-b2g/gaia/pull/29024/files#diff-32abdeb6061956598cbede801aa9bc1aR91 respectively ","created_at":"2015-03-23T08:14:20Z","updated_at":"2015-03-23T08:14:20Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/29024#discussion_r26918876","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/29024","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/26918876"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/29024#discussion_r26918876"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/29024"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/29024","id":31651809,"html_url":"https://github.com/mozilla-b2g/gaia/pull/29024","diff_url":"https://github.com/mozilla-b2g/gaia/pull/29024.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/29024.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/29024","number":29024,"state":"open","locked":false,"title":"Bug 1134795 - Show icon when installing web app from web page","user":{"login":"benfrancis","id":552417,"avatar_url":"https://avatars.githubusercontent.com/u/552417?v=3","gravatar_id":"","url":"https://api.github.com/users/benfrancis","html_url":"https://github.com/benfrancis","followers_url":"https://api.github.com/users/benfrancis/followers","following_url":"https://api.github.com/users/benfrancis/following{/other_user}","gists_url":"https://api.github.com/users/benfrancis/gists{/gist_id}","starred_url":"https://api.github.com/users/benfrancis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benfrancis/subscriptions","organizations_url":"https://api.github.com/users/benfrancis/orgs","repos_url":"https://api.github.com/users/benfrancis/repos","events_url":"https://api.github.com/users/benfrancis/events{/privacy}","received_events_url":"https://api.github.com/users/benfrancis/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-03-20T21:04:55Z","updated_at":"2015-03-23T08:14:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"075907a1e6ac752a7f76475e786d43e0448de6ef","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/29024/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/29024/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/29024/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/efab1ca0cfca24cc441c982d8665cd30292832c9","head":{"label":"benfrancis:1134795","ref":"1134795","sha":"efab1ca0cfca24cc441c982d8665cd30292832c9","user":{"login":"benfrancis","id":552417,"avatar_url":"https://avatars.githubusercontent.com/u/552417?v=3","gravatar_id":"","url":"https://api.github.com/users/benfrancis","html_url":"https://github.com/benfrancis","followers_url":"https://api.github.com/users/benfrancis/followers","following_url":"https://api.github.com/users/benfrancis/following{/other_user}","gists_url":"https://api.github.com/users/benfrancis/gists{/gist_id}","starred_url":"https://api.github.com/users/benfrancis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benfrancis/subscriptions","organizations_url":"https://api.github.com/users/benfrancis/orgs","repos_url":"https://api.github.com/users/benfrancis/repos","events_url":"https://api.github.com/users/benfrancis/events{/privacy}","received_events_url":"https://api.github.com/users/benfrancis/received_events","type":"User","site_admin":false},"repo":{"id":4042685,"name":"gaia","full_name":"benfrancis/gaia","owner":{"login":"benfrancis","id":552417,"avatar_url":"https://avatars.githubusercontent.com/u/552417?v=3","gravatar_id":"","url":"https://api.github.com/users/benfrancis","html_url":"https://github.com/benfrancis","followers_url":"https://api.github.com/users/benfrancis/followers","following_url":"https://api.github.com/users/benfrancis/following{/other_user}","gists_url":"https://api.github.com/users/benfrancis/gists{/gist_id}","starred_url":"https://api.github.com/users/benfrancis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benfrancis/subscriptions","organizations_url":"https://api.github.com/users/benfrancis/orgs","repos_url":"https://api.github.com/users/benfrancis/repos","events_url":"https://api.github.com/users/benfrancis/events{/privacy}","received_events_url":"https://api.github.com/users/benfrancis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benfrancis/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project","fork":true,"url":"https://api.github.com/repos/benfrancis/gaia","forks_url":"https://api.github.com/repos/benfrancis/gaia/forks","keys_url":"https://api.github.com/repos/benfrancis/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benfrancis/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benfrancis/gaia/teams","hooks_url":"https://api.github.com/repos/benfrancis/gaia/hooks","issue_events_url":"https://api.github.com/repos/benfrancis/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/benfrancis/gaia/events","assignees_url":"https://api.github.com/repos/benfrancis/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/benfrancis/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/benfrancis/gaia/tags","blobs_url":"https://api.github.com/repos/benfrancis/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benfrancis/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benfrancis/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/benfrancis/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benfrancis/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/benfrancis/gaia/languages","stargazers_url":"https://api.github.com/repos/benfrancis/gaia/stargazers","contributors_url":"https://api.github.com/repos/benfrancis/gaia/contributors","subscribers_url":"https://api.github.com/repos/benfrancis/gaia/subscribers","subscription_url":"https://api.github.com/repos/benfrancis/gaia/subscription","commits_url":"https://api.github.com/repos/benfrancis/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/benfrancis/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/benfrancis/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/benfrancis/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/benfrancis/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/benfrancis/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benfrancis/gaia/merges","archive_url":"https://api.github.com/repos/benfrancis/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benfrancis/gaia/downloads","issues_url":"https://api.github.com/repos/benfrancis/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/benfrancis/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/benfrancis/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/benfrancis/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benfrancis/gaia/labels{/name}","releases_url":"https://api.github.com/repos/benfrancis/gaia/releases{/id}","created_at":"2012-04-16T16:14:35Z","updated_at":"2014-06-21T03:34:19Z","pushed_at":"2015-03-20T21:28:56Z","git_url":"git://github.com/benfrancis/gaia.git","ssh_url":"git@github.com:benfrancis/gaia.git","clone_url":"https://github.com/benfrancis/gaia.git","svn_url":"https://github.com/benfrancis/gaia","homepage":"https://wiki.mozilla.org/B2G","size":877287,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"56655b33580020e18b18d78e3ebcbd177452c603","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2015-03-23T05:52:34Z","pushed_at":"2015-03-23T08:02:02Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1465530,"stargazers_count":1897,"watchers_count":1897,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2262,"mirror_url":null,"open_issues_count":929,"forks":2262,"open_issues":929,"watchers":1897,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/29024"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/29024"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/29024"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/29024/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/29024/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/29024/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/efab1ca0cfca24cc441c982d8665cd30292832c9"}}}}