{"action":"created","comment":{"url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/pulls/comments/23345741","id":23345741,"diff_hunk":"@@ -19,6 +23,9 @@ public static void inject(Context context, Object target) {\n     @Override\n     public void onCreate() {\n         super.onCreate();\n+\n+        TwitterAuthConfig authConfig = new TwitterAuthConfig(BuildConfig.TWITTER_API_KEY, BuildConfig.TWITTER_API_SECRET);\n+        Fabric.with(this, new Crashlytics(), new Twitter(authConfig));","path":"mobile/src/main/java/com/truckmuncher/truckmuncher/App.java","position":20,"original_position":20,"commit_id":"1a5421b7126098fa256af04c54d5d67aa8d90185","original_commit_id":"1a5421b7126098fa256af04c54d5d67aa8d90185","user":{"login":"MariusVolkhart","id":1709517,"avatar_url":"https://avatars.githubusercontent.com/u/1709517?v=3","gravatar_id":"","url":"https://api.github.com/users/MariusVolkhart","html_url":"https://github.com/MariusVolkhart","followers_url":"https://api.github.com/users/MariusVolkhart/followers","following_url":"https://api.github.com/users/MariusVolkhart/following{/other_user}","gists_url":"https://api.github.com/users/MariusVolkhart/gists{/gist_id}","starred_url":"https://api.github.com/users/MariusVolkhart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MariusVolkhart/subscriptions","organizations_url":"https://api.github.com/users/MariusVolkhart/orgs","repos_url":"https://api.github.com/users/MariusVolkhart/repos","events_url":"https://api.github.com/users/MariusVolkhart/events{/privacy}","received_events_url":"https://api.github.com/users/MariusVolkhart/received_events","type":"User","site_admin":false},"body":"I have some concerns about this.\r\n\r\n1. Wouldn't this make crashlytics run in debug mode as well? The old Crashlytics didn't \"ignore\" things in debug, but we definitely don't want them reported. That was why it was in the `if...else` in `LoggerStarter`.\r\n2. The reason for crash logging to be initialized in `LoggerStarter` is b/c if the content provider is accessed through a `Context` which is not ours (like if we export our data), then our Application does not get launched so crashes would not get reported to us. `LoggerStarter` is initialized in the content provider, which circumvents this limitation.\r\n3. Does this create a Twitter singleton that we keep around for the lifetime of our app? If so, that seems like a waste of memory since we only use it for the login stuff and even then only for vendors who actually use twitter.","created_at":"2015-01-22T00:00:20Z","updated_at":"2015-01-22T00:00:20Z","html_url":"https://github.com/TruckMuncher/TruckMuncher-Android/pull/49#discussion_r23345741","pull_request_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/pulls/49","_links":{"self":{"href":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/pulls/comments/23345741"},"html":{"href":"https://github.com/TruckMuncher/TruckMuncher-Android/pull/49#discussion_r23345741"},"pull_request":{"href":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/pulls/49","id":27785923,"html_url":"https://github.com/TruckMuncher/TruckMuncher-Android/pull/49","diff_url":"https://github.com/TruckMuncher/TruckMuncher-Android/pull/49.diff","patch_url":"https://github.com/TruckMuncher/TruckMuncher-Android/pull/49.patch","issue_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/issues/49","number":49,"state":"open","locked":false,"title":"Login styling","user":{"login":"nockertsb","id":6709225,"avatar_url":"https://avatars.githubusercontent.com/u/6709225?v=3","gravatar_id":"","url":"https://api.github.com/users/nockertsb","html_url":"https://github.com/nockertsb","followers_url":"https://api.github.com/users/nockertsb/followers","following_url":"https://api.github.com/users/nockertsb/following{/other_user}","gists_url":"https://api.github.com/users/nockertsb/gists{/gist_id}","starred_url":"https://api.github.com/users/nockertsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nockertsb/subscriptions","organizations_url":"https://api.github.com/users/nockertsb/orgs","repos_url":"https://api.github.com/users/nockertsb/repos","events_url":"https://api.github.com/users/nockertsb/events{/privacy}","received_events_url":"https://api.github.com/users/nockertsb/received_events","type":"User","site_admin":false},"body":"This PR addresses a few different things.\r\n* The issue that I was seeing with the Twitter login was just an issue with the format string we were using for twitter auth tokens, so that is fixed now\r\n* Styling of the login screen to include the TruckMuncher logo and better Facebook/Twitter buttons\r\n* Migrating away from the AndroidSocialNetworks library\r\n\r\nI didn't actually remove the AndroidSocialNetworks library yet, but in the process of styling the login screen, I switched to using the buttons from the official Twitter/Facebook SDKs. We should be able to remove the AndroidSocialNetworks module entirely without too much additional effort.","created_at":"2015-01-21T19:10:47Z","updated_at":"2015-01-22T00:00:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30104db3079d312916e275d01660d195ceaf35cc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/pulls/49/commits","review_comments_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/pulls/49/comments","review_comment_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/pulls/comments/{number}","comments_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/issues/49/comments","statuses_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/statuses/1a5421b7126098fa256af04c54d5d67aa8d90185","head":{"label":"TruckMuncher:loginStyling","ref":"loginStyling","sha":"1a5421b7126098fa256af04c54d5d67aa8d90185","user":{"login":"TruckMuncher","id":8795986,"avatar_url":"https://avatars.githubusercontent.com/u/8795986?v=3","gravatar_id":"","url":"https://api.github.com/users/TruckMuncher","html_url":"https://github.com/TruckMuncher","followers_url":"https://api.github.com/users/TruckMuncher/followers","following_url":"https://api.github.com/users/TruckMuncher/following{/other_user}","gists_url":"https://api.github.com/users/TruckMuncher/gists{/gist_id}","starred_url":"https://api.github.com/users/TruckMuncher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TruckMuncher/subscriptions","organizations_url":"https://api.github.com/users/TruckMuncher/orgs","repos_url":"https://api.github.com/users/TruckMuncher/repos","events_url":"https://api.github.com/users/TruckMuncher/events{/privacy}","received_events_url":"https://api.github.com/users/TruckMuncher/received_events","type":"Organization","site_admin":false},"repo":{"id":23932027,"name":"TruckMuncher-Android","full_name":"TruckMuncher/TruckMuncher-Android","owner":{"login":"TruckMuncher","id":8795986,"avatar_url":"https://avatars.githubusercontent.com/u/8795986?v=3","gravatar_id":"","url":"https://api.github.com/users/TruckMuncher","html_url":"https://github.com/TruckMuncher","followers_url":"https://api.github.com/users/TruckMuncher/followers","following_url":"https://api.github.com/users/TruckMuncher/following{/other_user}","gists_url":"https://api.github.com/users/TruckMuncher/gists{/gist_id}","starred_url":"https://api.github.com/users/TruckMuncher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TruckMuncher/subscriptions","organizations_url":"https://api.github.com/users/TruckMuncher/orgs","repos_url":"https://api.github.com/users/TruckMuncher/repos","events_url":"https://api.github.com/users/TruckMuncher/events{/privacy}","received_events_url":"https://api.github.com/users/TruckMuncher/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TruckMuncher/TruckMuncher-Android","description":"Android application for Milwaukee food trucks","fork":false,"url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android","forks_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/forks","keys_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/teams","hooks_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/hooks","issue_events_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/issues/events{/number}","events_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/events","assignees_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/assignees{/user}","branches_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/branches{/branch}","tags_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/tags","blobs_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/languages","stargazers_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/stargazers","contributors_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/contributors","subscribers_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/subscribers","subscription_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/subscription","commits_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/issues/comments/{number}","contents_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/contents/{+path}","compare_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/merges","archive_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/downloads","issues_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/issues{/number}","pulls_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/labels{/name}","releases_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/releases{/id}","created_at":"2014-09-11T19:11:25Z","updated_at":"2015-01-21T23:38:47Z","pushed_at":"2015-01-21T23:42:07Z","git_url":"git://github.com/TruckMuncher/TruckMuncher-Android.git","ssh_url":"git@github.com:TruckMuncher/TruckMuncher-Android.git","clone_url":"https://github.com/TruckMuncher/TruckMuncher-Android.git","svn_url":"https://github.com/TruckMuncher/TruckMuncher-Android","homepage":null,"size":5276,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"TruckMuncher:master","ref":"master","sha":"9d0865fa9f0dbb7d681633a39c9806cd320b6ee1","user":{"login":"TruckMuncher","id":8795986,"avatar_url":"https://avatars.githubusercontent.com/u/8795986?v=3","gravatar_id":"","url":"https://api.github.com/users/TruckMuncher","html_url":"https://github.com/TruckMuncher","followers_url":"https://api.github.com/users/TruckMuncher/followers","following_url":"https://api.github.com/users/TruckMuncher/following{/other_user}","gists_url":"https://api.github.com/users/TruckMuncher/gists{/gist_id}","starred_url":"https://api.github.com/users/TruckMuncher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TruckMuncher/subscriptions","organizations_url":"https://api.github.com/users/TruckMuncher/orgs","repos_url":"https://api.github.com/users/TruckMuncher/repos","events_url":"https://api.github.com/users/TruckMuncher/events{/privacy}","received_events_url":"https://api.github.com/users/TruckMuncher/received_events","type":"Organization","site_admin":false},"repo":{"id":23932027,"name":"TruckMuncher-Android","full_name":"TruckMuncher/TruckMuncher-Android","owner":{"login":"TruckMuncher","id":8795986,"avatar_url":"https://avatars.githubusercontent.com/u/8795986?v=3","gravatar_id":"","url":"https://api.github.com/users/TruckMuncher","html_url":"https://github.com/TruckMuncher","followers_url":"https://api.github.com/users/TruckMuncher/followers","following_url":"https://api.github.com/users/TruckMuncher/following{/other_user}","gists_url":"https://api.github.com/users/TruckMuncher/gists{/gist_id}","starred_url":"https://api.github.com/users/TruckMuncher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TruckMuncher/subscriptions","organizations_url":"https://api.github.com/users/TruckMuncher/orgs","repos_url":"https://api.github.com/users/TruckMuncher/repos","events_url":"https://api.github.com/users/TruckMuncher/events{/privacy}","received_events_url":"https://api.github.com/users/TruckMuncher/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TruckMuncher/TruckMuncher-Android","description":"Android application for Milwaukee food trucks","fork":false,"url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android","forks_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/forks","keys_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/teams","hooks_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/hooks","issue_events_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/issues/events{/number}","events_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/events","assignees_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/assignees{/user}","branches_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/branches{/branch}","tags_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/tags","blobs_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/languages","stargazers_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/stargazers","contributors_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/contributors","subscribers_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/subscribers","subscription_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/subscription","commits_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/issues/comments/{number}","contents_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/contents/{+path}","compare_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/merges","archive_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/downloads","issues_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/issues{/number}","pulls_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/labels{/name}","releases_url":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/releases{/id}","created_at":"2014-09-11T19:11:25Z","updated_at":"2015-01-21T23:38:47Z","pushed_at":"2015-01-21T23:42:07Z","git_url":"git://github.com/TruckMuncher/TruckMuncher-Android.git","ssh_url":"git@github.com:TruckMuncher/TruckMuncher-Android.git","clone_url":"https://github.com/TruckMuncher/TruckMuncher-Android.git","svn_url":"https://github.com/TruckMuncher/TruckMuncher-Android","homepage":null,"size":5276,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/pulls/49"},"html":{"href":"https://github.com/TruckMuncher/TruckMuncher-Android/pull/49"},"issue":{"href":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/issues/49"},"comments":{"href":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/TruckMuncher/TruckMuncher-Android/statuses/1a5421b7126098fa256af04c54d5d67aa8d90185"}}}}