{"action":"created","comment":{"url":"https://api.github.com/repos/npm/newww/pulls/comments/27082861","id":27082861,"diff_hunk":"@@ -4,14 +4,12 @@ var\n     os      = require('os'),\n     emitter;\n \n-module.exports = function constructEmitter(options)\n+var metrics = module.exports = function constructEmitter()\n {\n     if (emitter) return emitter;\n \n-    assert(options, 'you must pass an options object to constructEmitter()');\n-\n     emitter = new Emitter({\n-        uri: options.collector.uri,\n+        uri: 'udp://localhost:3333',","path":"adapters/metrics.js","position":13,"original_position":13,"commit_id":"6edd25b32f805eafb80318df55e6e0314cf83f94","original_commit_id":"6edd25b32f805eafb80318df55e6e0314cf83f94","user":{"login":"rockbot","id":954269,"avatar_url":"https://avatars.githubusercontent.com/u/954269?v=3","gravatar_id":"","url":"https://api.github.com/users/rockbot","html_url":"https://github.com/rockbot","followers_url":"https://api.github.com/users/rockbot/followers","following_url":"https://api.github.com/users/rockbot/following{/other_user}","gists_url":"https://api.github.com/users/rockbot/gists{/gist_id}","starred_url":"https://api.github.com/users/rockbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rockbot/subscriptions","organizations_url":"https://api.github.com/users/rockbot/orgs","repos_url":"https://api.github.com/users/rockbot/repos","events_url":"https://api.github.com/users/rockbot/events{/privacy}","received_events_url":"https://api.github.com/users/rockbot/received_events","type":"User","site_admin":false},"body":"why isn't this an environment variable? if not an environment variable, then I think it would be better to have it at the top of the file, as here it looks rather magic number-y.","created_at":"2015-03-24T23:13:30Z","updated_at":"2015-03-24T23:13:30Z","html_url":"https://github.com/npm/newww/pull/758#discussion_r27082861","pull_request_url":"https://api.github.com/repos/npm/newww/pulls/758","_links":{"self":{"href":"https://api.github.com/repos/npm/newww/pulls/comments/27082861"},"html":{"href":"https://github.com/npm/newww/pull/758#discussion_r27082861"},"pull_request":{"href":"https://api.github.com/repos/npm/newww/pulls/758"}}},"pull_request":{"url":"https://api.github.com/repos/npm/newww/pulls/758","id":31591841,"html_url":"https://github.com/npm/newww/pull/758","diff_url":"https://github.com/npm/newww/pull/758.diff","patch_url":"https://github.com/npm/newww/pull/758.patch","issue_url":"https://api.github.com/repos/npm/newww/issues/758","number":758,"state":"open","locked":false,"title":"environment-only config","user":{"login":"zeke","id":2289,"avatar_url":"https://avatars.githubusercontent.com/u/2289?v=3","gravatar_id":"","url":"https://api.github.com/users/zeke","html_url":"https://github.com/zeke","followers_url":"https://api.github.com/users/zeke/followers","following_url":"https://api.github.com/users/zeke/following{/other_user}","gists_url":"https://api.github.com/users/zeke/gists{/gist_id}","starred_url":"https://api.github.com/users/zeke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeke/subscriptions","organizations_url":"https://api.github.com/users/zeke/orgs","repos_url":"https://api.github.com/users/zeke/repos","events_url":"https://api.github.com/users/zeke/events{/privacy}","received_events_url":"https://api.github.com/users/zeke/received_events","type":"User","site_admin":false},"body":"Break config apart. Still a few references to `config.foo.bar` in the codebase that need to be removed, but we're getting close!\r\n\r\nThe configuration that DOESN'T change between environments moves into the files that need it.\r\n\r\nThe configuration that DOES change between environments is moving to environment variables. `.env.example` represents everything that is required.\r\n","created_at":"2015-03-20T06:50:51Z","updated_at":"2015-03-24T23:13:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"115268b1c6281f52980ba872675b2a9968cab311","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/npm/newww/pulls/758/commits","review_comments_url":"https://api.github.com/repos/npm/newww/pulls/758/comments","review_comment_url":"https://api.github.com/repos/npm/newww/pulls/comments{/number}","comments_url":"https://api.github.com/repos/npm/newww/issues/758/comments","statuses_url":"https://api.github.com/repos/npm/newww/statuses/6edd25b32f805eafb80318df55e6e0314cf83f94","head":{"label":"npm:config-cleanup","ref":"config-cleanup","sha":"6edd25b32f805eafb80318df55e6e0314cf83f94","user":{"login":"npm","id":6078720,"avatar_url":"https://avatars.githubusercontent.com/u/6078720?v=3","gravatar_id":"","url":"https://api.github.com/users/npm","html_url":"https://github.com/npm","followers_url":"https://api.github.com/users/npm/followers","following_url":"https://api.github.com/users/npm/following{/other_user}","gists_url":"https://api.github.com/users/npm/gists{/gist_id}","starred_url":"https://api.github.com/users/npm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npm/subscriptions","organizations_url":"https://api.github.com/users/npm/orgs","repos_url":"https://api.github.com/users/npm/repos","events_url":"https://api.github.com/users/npm/events{/privacy}","received_events_url":"https://api.github.com/users/npm/received_events","type":"Organization","site_admin":false},"repo":{"id":19872239,"name":"newww","full_name":"npm/newww","owner":{"login":"npm","id":6078720,"avatar_url":"https://avatars.githubusercontent.com/u/6078720?v=3","gravatar_id":"","url":"https://api.github.com/users/npm","html_url":"https://github.com/npm","followers_url":"https://api.github.com/users/npm/followers","following_url":"https://api.github.com/users/npm/following{/other_user}","gists_url":"https://api.github.com/users/npm/gists{/gist_id}","starred_url":"https://api.github.com/users/npm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npm/subscriptions","organizations_url":"https://api.github.com/users/npm/orgs","repos_url":"https://api.github.com/users/npm/repos","events_url":"https://api.github.com/users/npm/events{/privacy}","received_events_url":"https://api.github.com/users/npm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/npm/newww","description":"The npm website","fork":false,"url":"https://api.github.com/repos/npm/newww","forks_url":"https://api.github.com/repos/npm/newww/forks","keys_url":"https://api.github.com/repos/npm/newww/keys{/key_id}","collaborators_url":"https://api.github.com/repos/npm/newww/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/npm/newww/teams","hooks_url":"https://api.github.com/repos/npm/newww/hooks","issue_events_url":"https://api.github.com/repos/npm/newww/issues/events{/number}","events_url":"https://api.github.com/repos/npm/newww/events","assignees_url":"https://api.github.com/repos/npm/newww/assignees{/user}","branches_url":"https://api.github.com/repos/npm/newww/branches{/branch}","tags_url":"https://api.github.com/repos/npm/newww/tags","blobs_url":"https://api.github.com/repos/npm/newww/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/npm/newww/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/npm/newww/git/refs{/sha}","trees_url":"https://api.github.com/repos/npm/newww/git/trees{/sha}","statuses_url":"https://api.github.com/repos/npm/newww/statuses/{sha}","languages_url":"https://api.github.com/repos/npm/newww/languages","stargazers_url":"https://api.github.com/repos/npm/newww/stargazers","contributors_url":"https://api.github.com/repos/npm/newww/contributors","subscribers_url":"https://api.github.com/repos/npm/newww/subscribers","subscription_url":"https://api.github.com/repos/npm/newww/subscription","commits_url":"https://api.github.com/repos/npm/newww/commits{/sha}","git_commits_url":"https://api.github.com/repos/npm/newww/git/commits{/sha}","comments_url":"https://api.github.com/repos/npm/newww/comments{/number}","issue_comment_url":"https://api.github.com/repos/npm/newww/issues/comments{/number}","contents_url":"https://api.github.com/repos/npm/newww/contents/{+path}","compare_url":"https://api.github.com/repos/npm/newww/compare/{base}...{head}","merges_url":"https://api.github.com/repos/npm/newww/merges","archive_url":"https://api.github.com/repos/npm/newww/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/npm/newww/downloads","issues_url":"https://api.github.com/repos/npm/newww/issues{/number}","pulls_url":"https://api.github.com/repos/npm/newww/pulls{/number}","milestones_url":"https://api.github.com/repos/npm/newww/milestones{/number}","notifications_url":"https://api.github.com/repos/npm/newww/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/npm/newww/labels{/name}","releases_url":"https://api.github.com/repos/npm/newww/releases{/id}","created_at":"2014-05-16T22:12:47Z","updated_at":"2015-03-24T18:42:01Z","pushed_at":"2015-03-24T22:37:15Z","git_url":"git://github.com/npm/newww.git","ssh_url":"git@github.com:npm/newww.git","clone_url":"https://github.com/npm/newww.git","svn_url":"https://github.com/npm/newww","homepage":"http://npmjs.com","size":12665,"stargazers_count":274,"watchers_count":274,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":85,"mirror_url":null,"open_issues_count":123,"forks":85,"open_issues":123,"watchers":274,"default_branch":"master"}},"base":{"label":"npm:r2","ref":"r2","sha":"e628329feb2252d17459fcc5000c806288acb948","user":{"login":"npm","id":6078720,"avatar_url":"https://avatars.githubusercontent.com/u/6078720?v=3","gravatar_id":"","url":"https://api.github.com/users/npm","html_url":"https://github.com/npm","followers_url":"https://api.github.com/users/npm/followers","following_url":"https://api.github.com/users/npm/following{/other_user}","gists_url":"https://api.github.com/users/npm/gists{/gist_id}","starred_url":"https://api.github.com/users/npm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npm/subscriptions","organizations_url":"https://api.github.com/users/npm/orgs","repos_url":"https://api.github.com/users/npm/repos","events_url":"https://api.github.com/users/npm/events{/privacy}","received_events_url":"https://api.github.com/users/npm/received_events","type":"Organization","site_admin":false},"repo":{"id":19872239,"name":"newww","full_name":"npm/newww","owner":{"login":"npm","id":6078720,"avatar_url":"https://avatars.githubusercontent.com/u/6078720?v=3","gravatar_id":"","url":"https://api.github.com/users/npm","html_url":"https://github.com/npm","followers_url":"https://api.github.com/users/npm/followers","following_url":"https://api.github.com/users/npm/following{/other_user}","gists_url":"https://api.github.com/users/npm/gists{/gist_id}","starred_url":"https://api.github.com/users/npm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npm/subscriptions","organizations_url":"https://api.github.com/users/npm/orgs","repos_url":"https://api.github.com/users/npm/repos","events_url":"https://api.github.com/users/npm/events{/privacy}","received_events_url":"https://api.github.com/users/npm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/npm/newww","description":"The npm website","fork":false,"url":"https://api.github.com/repos/npm/newww","forks_url":"https://api.github.com/repos/npm/newww/forks","keys_url":"https://api.github.com/repos/npm/newww/keys{/key_id}","collaborators_url":"https://api.github.com/repos/npm/newww/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/npm/newww/teams","hooks_url":"https://api.github.com/repos/npm/newww/hooks","issue_events_url":"https://api.github.com/repos/npm/newww/issues/events{/number}","events_url":"https://api.github.com/repos/npm/newww/events","assignees_url":"https://api.github.com/repos/npm/newww/assignees{/user}","branches_url":"https://api.github.com/repos/npm/newww/branches{/branch}","tags_url":"https://api.github.com/repos/npm/newww/tags","blobs_url":"https://api.github.com/repos/npm/newww/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/npm/newww/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/npm/newww/git/refs{/sha}","trees_url":"https://api.github.com/repos/npm/newww/git/trees{/sha}","statuses_url":"https://api.github.com/repos/npm/newww/statuses/{sha}","languages_url":"https://api.github.com/repos/npm/newww/languages","stargazers_url":"https://api.github.com/repos/npm/newww/stargazers","contributors_url":"https://api.github.com/repos/npm/newww/contributors","subscribers_url":"https://api.github.com/repos/npm/newww/subscribers","subscription_url":"https://api.github.com/repos/npm/newww/subscription","commits_url":"https://api.github.com/repos/npm/newww/commits{/sha}","git_commits_url":"https://api.github.com/repos/npm/newww/git/commits{/sha}","comments_url":"https://api.github.com/repos/npm/newww/comments{/number}","issue_comment_url":"https://api.github.com/repos/npm/newww/issues/comments{/number}","contents_url":"https://api.github.com/repos/npm/newww/contents/{+path}","compare_url":"https://api.github.com/repos/npm/newww/compare/{base}...{head}","merges_url":"https://api.github.com/repos/npm/newww/merges","archive_url":"https://api.github.com/repos/npm/newww/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/npm/newww/downloads","issues_url":"https://api.github.com/repos/npm/newww/issues{/number}","pulls_url":"https://api.github.com/repos/npm/newww/pulls{/number}","milestones_url":"https://api.github.com/repos/npm/newww/milestones{/number}","notifications_url":"https://api.github.com/repos/npm/newww/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/npm/newww/labels{/name}","releases_url":"https://api.github.com/repos/npm/newww/releases{/id}","created_at":"2014-05-16T22:12:47Z","updated_at":"2015-03-24T18:42:01Z","pushed_at":"2015-03-24T22:37:15Z","git_url":"git://github.com/npm/newww.git","ssh_url":"git@github.com:npm/newww.git","clone_url":"https://github.com/npm/newww.git","svn_url":"https://github.com/npm/newww","homepage":"http://npmjs.com","size":12665,"stargazers_count":274,"watchers_count":274,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":85,"mirror_url":null,"open_issues_count":123,"forks":85,"open_issues":123,"watchers":274,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/npm/newww/pulls/758"},"html":{"href":"https://github.com/npm/newww/pull/758"},"issue":{"href":"https://api.github.com/repos/npm/newww/issues/758"},"comments":{"href":"https://api.github.com/repos/npm/newww/issues/758/comments"},"review_comments":{"href":"https://api.github.com/repos/npm/newww/pulls/758/comments"},"review_comment":{"href":"https://api.github.com/repos/npm/newww/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/npm/newww/pulls/758/commits"},"statuses":{"href":"https://api.github.com/repos/npm/newww/statuses/6edd25b32f805eafb80318df55e6e0314cf83f94"}}}}