{"action":"created","comment":{"url":"https://api.github.com/repos/pulp/pulp/pulls/comments/24109714","id":24109714,"diff_hunk":"@@ -507,3 +514,5 @@ def cleanup_old_worker(*args, **kwargs):\n     \"\"\"\n     name = kwargs['sender'].hostname\n     _delete_worker(name, normal_shutdown=True)\n+    # Recreate a new working directory for worker that is starting now\n+    common_utils.create_worker_working_directory(name)","path":"server/pulp/server/async/tasks.py","position":53,"original_position":53,"commit_id":"a106a93ad04ecec7f13db4f1892eb37d1b8e07df","original_commit_id":"a106a93ad04ecec7f13db4f1892eb37d1b8e07df","user":{"login":"dkliban","id":294339,"avatar_url":"https://avatars.githubusercontent.com/u/294339?v=3","gravatar_id":"","url":"https://api.github.com/users/dkliban","html_url":"https://github.com/dkliban","followers_url":"https://api.github.com/users/dkliban/followers","following_url":"https://api.github.com/users/dkliban/following{/other_user}","gists_url":"https://api.github.com/users/dkliban/gists{/gist_id}","starred_url":"https://api.github.com/users/dkliban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkliban/subscriptions","organizations_url":"https://api.github.com/users/dkliban/orgs","repos_url":"https://api.github.com/users/dkliban/repos","events_url":"https://api.github.com/users/dkliban/events{/privacy}","received_events_url":"https://api.github.com/users/dkliban/received_events","type":"User","site_admin":false},"body":"@beav cleanup_old_worker has a decorator that connects it to a worker_init signal.  This method is run when a worker starts.  ","created_at":"2015-02-04T19:10:00Z","updated_at":"2015-02-04T19:10:00Z","html_url":"https://github.com/pulp/pulp/pull/1460#discussion_r24109714","pull_request_url":"https://api.github.com/repos/pulp/pulp/pulls/1460","_links":{"self":{"href":"https://api.github.com/repos/pulp/pulp/pulls/comments/24109714"},"html":{"href":"https://github.com/pulp/pulp/pull/1460#discussion_r24109714"},"pull_request":{"href":"https://api.github.com/repos/pulp/pulp/pulls/1460"}}},"pull_request":{"url":"https://api.github.com/repos/pulp/pulp/pulls/1460","id":26527043,"html_url":"https://github.com/pulp/pulp/pull/1460","diff_url":"https://github.com/pulp/pulp/pull/1460.diff","patch_url":"https://github.com/pulp/pulp/pull/1460.patch","issue_url":"https://api.github.com/repos/pulp/pulp/issues/1460","number":1460,"state":"open","locked":false,"title":"Working directories for tasks","user":{"login":"dkliban","id":294339,"avatar_url":"https://avatars.githubusercontent.com/u/294339?v=3","gravatar_id":"","url":"https://api.github.com/users/dkliban","html_url":"https://github.com/dkliban","followers_url":"https://api.github.com/users/dkliban/followers","following_url":"https://api.github.com/users/dkliban/following{/other_user}","gists_url":"https://api.github.com/users/dkliban/gists{/gist_id}","starred_url":"https://api.github.com/users/dkliban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkliban/subscriptions","organizations_url":"https://api.github.com/users/dkliban/orgs","repos_url":"https://api.github.com/users/dkliban/repos","events_url":"https://api.github.com/users/dkliban/events{/privacy}","received_events_url":"https://api.github.com/users/dkliban/received_events","type":"User","site_admin":false},"body":"This PR introduces a 'working_directory' config in /etc/pulp/server.conf in the [server] section. This is the path where each pulp worker can expect to have a directory with it's name.  Inside that worker's directory, each task will be able to create working directory for that task.   \r\n\r\nTake note of the changes in server/pulp/server/managers/repo/cud.py.  I decided to remove this code because we no longer expect to have to clean up repository working directories outside of tasks.  Let me know if I am misunderstanding something.  \r\n\r\nStill a work in progress because the spec file needs to be modified to create /var/cache/pulp and then tested with SELinux.","created_at":"2014-12-23T19:15:35Z","updated_at":"2015-02-04T19:10:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa90c5a15c128b71efc514d053ef2c538b772cc3","assignee":{"login":"beav","id":563254,"avatar_url":"https://avatars.githubusercontent.com/u/563254?v=3","gravatar_id":"","url":"https://api.github.com/users/beav","html_url":"https://github.com/beav","followers_url":"https://api.github.com/users/beav/followers","following_url":"https://api.github.com/users/beav/following{/other_user}","gists_url":"https://api.github.com/users/beav/gists{/gist_id}","starred_url":"https://api.github.com/users/beav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beav/subscriptions","organizations_url":"https://api.github.com/users/beav/orgs","repos_url":"https://api.github.com/users/beav/repos","events_url":"https://api.github.com/users/beav/events{/privacy}","received_events_url":"https://api.github.com/users/beav/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/pulp/pulp/pulls/1460/commits","review_comments_url":"https://api.github.com/repos/pulp/pulp/pulls/1460/comments","review_comment_url":"https://api.github.com/repos/pulp/pulp/pulls/comments/{number}","comments_url":"https://api.github.com/repos/pulp/pulp/issues/1460/comments","statuses_url":"https://api.github.com/repos/pulp/pulp/statuses/a106a93ad04ecec7f13db4f1892eb37d1b8e07df","head":{"label":"dkliban:new-working-dir","ref":"new-working-dir","sha":"a106a93ad04ecec7f13db4f1892eb37d1b8e07df","user":{"login":"dkliban","id":294339,"avatar_url":"https://avatars.githubusercontent.com/u/294339?v=3","gravatar_id":"","url":"https://api.github.com/users/dkliban","html_url":"https://github.com/dkliban","followers_url":"https://api.github.com/users/dkliban/followers","following_url":"https://api.github.com/users/dkliban/following{/other_user}","gists_url":"https://api.github.com/users/dkliban/gists{/gist_id}","starred_url":"https://api.github.com/users/dkliban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkliban/subscriptions","organizations_url":"https://api.github.com/users/dkliban/orgs","repos_url":"https://api.github.com/users/dkliban/repos","events_url":"https://api.github.com/users/dkliban/events{/privacy}","received_events_url":"https://api.github.com/users/dkliban/received_events","type":"User","site_admin":false},"repo":{"id":25177116,"name":"pulp","full_name":"dkliban/pulp","owner":{"login":"dkliban","id":294339,"avatar_url":"https://avatars.githubusercontent.com/u/294339?v=3","gravatar_id":"","url":"https://api.github.com/users/dkliban","html_url":"https://github.com/dkliban","followers_url":"https://api.github.com/users/dkliban/followers","following_url":"https://api.github.com/users/dkliban/following{/other_user}","gists_url":"https://api.github.com/users/dkliban/gists{/gist_id}","starred_url":"https://api.github.com/users/dkliban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkliban/subscriptions","organizations_url":"https://api.github.com/users/dkliban/orgs","repos_url":"https://api.github.com/users/dkliban/repos","events_url":"https://api.github.com/users/dkliban/events{/privacy}","received_events_url":"https://api.github.com/users/dkliban/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dkliban/pulp","description":"Repository for Pulp platform code, including the server and base admin and consumer clients","fork":true,"url":"https://api.github.com/repos/dkliban/pulp","forks_url":"https://api.github.com/repos/dkliban/pulp/forks","keys_url":"https://api.github.com/repos/dkliban/pulp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dkliban/pulp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dkliban/pulp/teams","hooks_url":"https://api.github.com/repos/dkliban/pulp/hooks","issue_events_url":"https://api.github.com/repos/dkliban/pulp/issues/events{/number}","events_url":"https://api.github.com/repos/dkliban/pulp/events","assignees_url":"https://api.github.com/repos/dkliban/pulp/assignees{/user}","branches_url":"https://api.github.com/repos/dkliban/pulp/branches{/branch}","tags_url":"https://api.github.com/repos/dkliban/pulp/tags","blobs_url":"https://api.github.com/repos/dkliban/pulp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dkliban/pulp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dkliban/pulp/git/refs{/sha}","trees_url":"https://api.github.com/repos/dkliban/pulp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dkliban/pulp/statuses/{sha}","languages_url":"https://api.github.com/repos/dkliban/pulp/languages","stargazers_url":"https://api.github.com/repos/dkliban/pulp/stargazers","contributors_url":"https://api.github.com/repos/dkliban/pulp/contributors","subscribers_url":"https://api.github.com/repos/dkliban/pulp/subscribers","subscription_url":"https://api.github.com/repos/dkliban/pulp/subscription","commits_url":"https://api.github.com/repos/dkliban/pulp/commits{/sha}","git_commits_url":"https://api.github.com/repos/dkliban/pulp/git/commits{/sha}","comments_url":"https://api.github.com/repos/dkliban/pulp/comments{/number}","issue_comment_url":"https://api.github.com/repos/dkliban/pulp/issues/comments/{number}","contents_url":"https://api.github.com/repos/dkliban/pulp/contents/{+path}","compare_url":"https://api.github.com/repos/dkliban/pulp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dkliban/pulp/merges","archive_url":"https://api.github.com/repos/dkliban/pulp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dkliban/pulp/downloads","issues_url":"https://api.github.com/repos/dkliban/pulp/issues{/number}","pulls_url":"https://api.github.com/repos/dkliban/pulp/pulls{/number}","milestones_url":"https://api.github.com/repos/dkliban/pulp/milestones{/number}","notifications_url":"https://api.github.com/repos/dkliban/pulp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dkliban/pulp/labels{/name}","releases_url":"https://api.github.com/repos/dkliban/pulp/releases{/id}","created_at":"2014-10-13T20:47:13Z","updated_at":"2014-10-12T16:36:45Z","pushed_at":"2015-02-04T16:39:47Z","git_url":"git://github.com/dkliban/pulp.git","ssh_url":"git@github.com:dkliban/pulp.git","clone_url":"https://github.com/dkliban/pulp.git","svn_url":"https://github.com/dkliban/pulp","homepage":"","size":79763,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pulp:master","ref":"master","sha":"b16b9dd81f85e9ae26e6ce8015e7c1335d0665f1","user":{"login":"pulp","id":2103606,"avatar_url":"https://avatars.githubusercontent.com/u/2103606?v=3","gravatar_id":"","url":"https://api.github.com/users/pulp","html_url":"https://github.com/pulp","followers_url":"https://api.github.com/users/pulp/followers","following_url":"https://api.github.com/users/pulp/following{/other_user}","gists_url":"https://api.github.com/users/pulp/gists{/gist_id}","starred_url":"https://api.github.com/users/pulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulp/subscriptions","organizations_url":"https://api.github.com/users/pulp/orgs","repos_url":"https://api.github.com/users/pulp/repos","events_url":"https://api.github.com/users/pulp/events{/privacy}","received_events_url":"https://api.github.com/users/pulp/received_events","type":"Organization","site_admin":false},"repo":{"id":5314652,"name":"pulp","full_name":"pulp/pulp","owner":{"login":"pulp","id":2103606,"avatar_url":"https://avatars.githubusercontent.com/u/2103606?v=3","gravatar_id":"","url":"https://api.github.com/users/pulp","html_url":"https://github.com/pulp","followers_url":"https://api.github.com/users/pulp/followers","following_url":"https://api.github.com/users/pulp/following{/other_user}","gists_url":"https://api.github.com/users/pulp/gists{/gist_id}","starred_url":"https://api.github.com/users/pulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulp/subscriptions","organizations_url":"https://api.github.com/users/pulp/orgs","repos_url":"https://api.github.com/users/pulp/repos","events_url":"https://api.github.com/users/pulp/events{/privacy}","received_events_url":"https://api.github.com/users/pulp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pulp/pulp","description":"Repository for Pulp platform code, including the server and base admin and consumer clients","fork":false,"url":"https://api.github.com/repos/pulp/pulp","forks_url":"https://api.github.com/repos/pulp/pulp/forks","keys_url":"https://api.github.com/repos/pulp/pulp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pulp/pulp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pulp/pulp/teams","hooks_url":"https://api.github.com/repos/pulp/pulp/hooks","issue_events_url":"https://api.github.com/repos/pulp/pulp/issues/events{/number}","events_url":"https://api.github.com/repos/pulp/pulp/events","assignees_url":"https://api.github.com/repos/pulp/pulp/assignees{/user}","branches_url":"https://api.github.com/repos/pulp/pulp/branches{/branch}","tags_url":"https://api.github.com/repos/pulp/pulp/tags","blobs_url":"https://api.github.com/repos/pulp/pulp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pulp/pulp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pulp/pulp/git/refs{/sha}","trees_url":"https://api.github.com/repos/pulp/pulp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pulp/pulp/statuses/{sha}","languages_url":"https://api.github.com/repos/pulp/pulp/languages","stargazers_url":"https://api.github.com/repos/pulp/pulp/stargazers","contributors_url":"https://api.github.com/repos/pulp/pulp/contributors","subscribers_url":"https://api.github.com/repos/pulp/pulp/subscribers","subscription_url":"https://api.github.com/repos/pulp/pulp/subscription","commits_url":"https://api.github.com/repos/pulp/pulp/commits{/sha}","git_commits_url":"https://api.github.com/repos/pulp/pulp/git/commits{/sha}","comments_url":"https://api.github.com/repos/pulp/pulp/comments{/number}","issue_comment_url":"https://api.github.com/repos/pulp/pulp/issues/comments/{number}","contents_url":"https://api.github.com/repos/pulp/pulp/contents/{+path}","compare_url":"https://api.github.com/repos/pulp/pulp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pulp/pulp/merges","archive_url":"https://api.github.com/repos/pulp/pulp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pulp/pulp/downloads","issues_url":"https://api.github.com/repos/pulp/pulp/issues{/number}","pulls_url":"https://api.github.com/repos/pulp/pulp/pulls{/number}","milestones_url":"https://api.github.com/repos/pulp/pulp/milestones{/number}","notifications_url":"https://api.github.com/repos/pulp/pulp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pulp/pulp/labels{/name}","releases_url":"https://api.github.com/repos/pulp/pulp/releases{/id}","created_at":"2012-08-06T13:49:20Z","updated_at":"2015-02-04T17:36:58Z","pushed_at":"2015-02-04T17:36:54Z","git_url":"git://github.com/pulp/pulp.git","ssh_url":"git@github.com:pulp/pulp.git","clone_url":"https://github.com/pulp/pulp.git","svn_url":"https://github.com/pulp/pulp","homepage":"","size":200641,"stargazers_count":178,"watchers_count":178,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":76,"mirror_url":null,"open_issues_count":32,"forks":76,"open_issues":32,"watchers":178,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pulp/pulp/pulls/1460"},"html":{"href":"https://github.com/pulp/pulp/pull/1460"},"issue":{"href":"https://api.github.com/repos/pulp/pulp/issues/1460"},"comments":{"href":"https://api.github.com/repos/pulp/pulp/issues/1460/comments"},"review_comments":{"href":"https://api.github.com/repos/pulp/pulp/pulls/1460/comments"},"review_comment":{"href":"https://api.github.com/repos/pulp/pulp/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/pulp/pulp/pulls/1460/commits"},"statuses":{"href":"https://api.github.com/repos/pulp/pulp/statuses/a106a93ad04ecec7f13db4f1892eb37d1b8e07df"}}}}