{"action":"opened","number":32,"pull_request":{"url":"https://api.github.com/repos/zorkian/marshal/pulls/32","id":51416211,"html_url":"https://github.com/zorkian/marshal/pull/32","diff_url":"https://github.com/zorkian/marshal/pull/32.diff","patch_url":"https://github.com/zorkian/marshal/pull/32.patch","issue_url":"https://api.github.com/repos/zorkian/marshal/issues/32","number":32,"state":"open","locked":false,"title":"Commit Upon Terminating Consumer","user":{"login":"basharal","id":8130707,"avatar_url":"https://avatars.githubusercontent.com/u/8130707?v=3","gravatar_id":"","url":"https://api.github.com/users/basharal","html_url":"https://github.com/basharal","followers_url":"https://api.github.com/users/basharal/followers","following_url":"https://api.github.com/users/basharal/following{/other_user}","gists_url":"https://api.github.com/users/basharal/gists{/gist_id}","starred_url":"https://api.github.com/users/basharal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basharal/subscriptions","organizations_url":"https://api.github.com/users/basharal/orgs","repos_url":"https://api.github.com/users/basharal/repos","events_url":"https://api.github.com/users/basharal/events{/privacy}","received_events_url":"https://api.github.com/users/basharal/received_events","type":"User","site_admin":false},"body":"We need to update the currrent offset during both heartbeats and\r\nwhen we terminate. That way we can commit the offsets back to Kafka.\r\nThis changes does that. It also includes a breaking change to the API\r\nby changing Terminate to have an extra flag that indicates whether we\r\nshould release the partition or just commit the offsets without releasing\r\nthe partition. It should be noted that we will need to update some\r\ndependent code once this is checked-in internally.\r\n\r\nAdded tests for the new code and made sure things pass.","created_at":"2015-11-20T22:21:50Z","updated_at":"2015-11-20T22:21:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zorkian/marshal/pulls/32/commits","review_comments_url":"https://api.github.com/repos/zorkian/marshal/pulls/32/comments","review_comment_url":"https://api.github.com/repos/zorkian/marshal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zorkian/marshal/issues/32/comments","statuses_url":"https://api.github.com/repos/zorkian/marshal/statuses/1cfb6d31b73522241211fb57e6a910e36944fc08","head":{"label":"basharal:fixes","ref":"fixes","sha":"1cfb6d31b73522241211fb57e6a910e36944fc08","user":{"login":"basharal","id":8130707,"avatar_url":"https://avatars.githubusercontent.com/u/8130707?v=3","gravatar_id":"","url":"https://api.github.com/users/basharal","html_url":"https://github.com/basharal","followers_url":"https://api.github.com/users/basharal/followers","following_url":"https://api.github.com/users/basharal/following{/other_user}","gists_url":"https://api.github.com/users/basharal/gists{/gist_id}","starred_url":"https://api.github.com/users/basharal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basharal/subscriptions","organizations_url":"https://api.github.com/users/basharal/orgs","repos_url":"https://api.github.com/users/basharal/repos","events_url":"https://api.github.com/users/basharal/events{/privacy}","received_events_url":"https://api.github.com/users/basharal/received_events","type":"User","site_admin":false},"repo":{"id":46528036,"name":"marshal","full_name":"basharal/marshal","owner":{"login":"basharal","id":8130707,"avatar_url":"https://avatars.githubusercontent.com/u/8130707?v=3","gravatar_id":"","url":"https://api.github.com/users/basharal","html_url":"https://github.com/basharal","followers_url":"https://api.github.com/users/basharal/followers","following_url":"https://api.github.com/users/basharal/following{/other_user}","gists_url":"https://api.github.com/users/basharal/gists{/gist_id}","starred_url":"https://api.github.com/users/basharal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basharal/subscriptions","organizations_url":"https://api.github.com/users/basharal/orgs","repos_url":"https://api.github.com/users/basharal/repos","events_url":"https://api.github.com/users/basharal/events{/privacy}","received_events_url":"https://api.github.com/users/basharal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/basharal/marshal","description":"A Kafka consumer coordination library for Go.","fork":true,"url":"https://api.github.com/repos/basharal/marshal","forks_url":"https://api.github.com/repos/basharal/marshal/forks","keys_url":"https://api.github.com/repos/basharal/marshal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/basharal/marshal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/basharal/marshal/teams","hooks_url":"https://api.github.com/repos/basharal/marshal/hooks","issue_events_url":"https://api.github.com/repos/basharal/marshal/issues/events{/number}","events_url":"https://api.github.com/repos/basharal/marshal/events","assignees_url":"https://api.github.com/repos/basharal/marshal/assignees{/user}","branches_url":"https://api.github.com/repos/basharal/marshal/branches{/branch}","tags_url":"https://api.github.com/repos/basharal/marshal/tags","blobs_url":"https://api.github.com/repos/basharal/marshal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/basharal/marshal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/basharal/marshal/git/refs{/sha}","trees_url":"https://api.github.com/repos/basharal/marshal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/basharal/marshal/statuses/{sha}","languages_url":"https://api.github.com/repos/basharal/marshal/languages","stargazers_url":"https://api.github.com/repos/basharal/marshal/stargazers","contributors_url":"https://api.github.com/repos/basharal/marshal/contributors","subscribers_url":"https://api.github.com/repos/basharal/marshal/subscribers","subscription_url":"https://api.github.com/repos/basharal/marshal/subscription","commits_url":"https://api.github.com/repos/basharal/marshal/commits{/sha}","git_commits_url":"https://api.github.com/repos/basharal/marshal/git/commits{/sha}","comments_url":"https://api.github.com/repos/basharal/marshal/comments{/number}","issue_comment_url":"https://api.github.com/repos/basharal/marshal/issues/comments{/number}","contents_url":"https://api.github.com/repos/basharal/marshal/contents/{+path}","compare_url":"https://api.github.com/repos/basharal/marshal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/basharal/marshal/merges","archive_url":"https://api.github.com/repos/basharal/marshal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/basharal/marshal/downloads","issues_url":"https://api.github.com/repos/basharal/marshal/issues{/number}","pulls_url":"https://api.github.com/repos/basharal/marshal/pulls{/number}","milestones_url":"https://api.github.com/repos/basharal/marshal/milestones{/number}","notifications_url":"https://api.github.com/repos/basharal/marshal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/basharal/marshal/labels{/name}","releases_url":"https://api.github.com/repos/basharal/marshal/releases{/id}","created_at":"2015-11-20T00:05:25Z","updated_at":"2015-11-20T00:05:25Z","pushed_at":"2015-11-20T22:21:00Z","git_url":"git://github.com/basharal/marshal.git","ssh_url":"git@github.com:basharal/marshal.git","clone_url":"https://github.com/basharal/marshal.git","svn_url":"https://github.com/basharal/marshal","homepage":null,"size":98,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zorkian:master","ref":"master","sha":"7731ea16092e2b48063aa9feba15fbbb0face9a0","user":{"login":"zorkian","id":361428,"avatar_url":"https://avatars.githubusercontent.com/u/361428?v=3","gravatar_id":"","url":"https://api.github.com/users/zorkian","html_url":"https://github.com/zorkian","followers_url":"https://api.github.com/users/zorkian/followers","following_url":"https://api.github.com/users/zorkian/following{/other_user}","gists_url":"https://api.github.com/users/zorkian/gists{/gist_id}","starred_url":"https://api.github.com/users/zorkian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zorkian/subscriptions","organizations_url":"https://api.github.com/users/zorkian/orgs","repos_url":"https://api.github.com/users/zorkian/repos","events_url":"https://api.github.com/users/zorkian/events{/privacy}","received_events_url":"https://api.github.com/users/zorkian/received_events","type":"User","site_admin":false},"repo":{"id":42746290,"name":"marshal","full_name":"zorkian/marshal","owner":{"login":"zorkian","id":361428,"avatar_url":"https://avatars.githubusercontent.com/u/361428?v=3","gravatar_id":"","url":"https://api.github.com/users/zorkian","html_url":"https://github.com/zorkian","followers_url":"https://api.github.com/users/zorkian/followers","following_url":"https://api.github.com/users/zorkian/following{/other_user}","gists_url":"https://api.github.com/users/zorkian/gists{/gist_id}","starred_url":"https://api.github.com/users/zorkian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zorkian/subscriptions","organizations_url":"https://api.github.com/users/zorkian/orgs","repos_url":"https://api.github.com/users/zorkian/repos","events_url":"https://api.github.com/users/zorkian/events{/privacy}","received_events_url":"https://api.github.com/users/zorkian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zorkian/marshal","description":"A Kafka consumer coordination library for Go.","fork":false,"url":"https://api.github.com/repos/zorkian/marshal","forks_url":"https://api.github.com/repos/zorkian/marshal/forks","keys_url":"https://api.github.com/repos/zorkian/marshal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zorkian/marshal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zorkian/marshal/teams","hooks_url":"https://api.github.com/repos/zorkian/marshal/hooks","issue_events_url":"https://api.github.com/repos/zorkian/marshal/issues/events{/number}","events_url":"https://api.github.com/repos/zorkian/marshal/events","assignees_url":"https://api.github.com/repos/zorkian/marshal/assignees{/user}","branches_url":"https://api.github.com/repos/zorkian/marshal/branches{/branch}","tags_url":"https://api.github.com/repos/zorkian/marshal/tags","blobs_url":"https://api.github.com/repos/zorkian/marshal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zorkian/marshal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zorkian/marshal/git/refs{/sha}","trees_url":"https://api.github.com/repos/zorkian/marshal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zorkian/marshal/statuses/{sha}","languages_url":"https://api.github.com/repos/zorkian/marshal/languages","stargazers_url":"https://api.github.com/repos/zorkian/marshal/stargazers","contributors_url":"https://api.github.com/repos/zorkian/marshal/contributors","subscribers_url":"https://api.github.com/repos/zorkian/marshal/subscribers","subscription_url":"https://api.github.com/repos/zorkian/marshal/subscription","commits_url":"https://api.github.com/repos/zorkian/marshal/commits{/sha}","git_commits_url":"https://api.github.com/repos/zorkian/marshal/git/commits{/sha}","comments_url":"https://api.github.com/repos/zorkian/marshal/comments{/number}","issue_comment_url":"https://api.github.com/repos/zorkian/marshal/issues/comments{/number}","contents_url":"https://api.github.com/repos/zorkian/marshal/contents/{+path}","compare_url":"https://api.github.com/repos/zorkian/marshal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zorkian/marshal/merges","archive_url":"https://api.github.com/repos/zorkian/marshal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zorkian/marshal/downloads","issues_url":"https://api.github.com/repos/zorkian/marshal/issues{/number}","pulls_url":"https://api.github.com/repos/zorkian/marshal/pulls{/number}","milestones_url":"https://api.github.com/repos/zorkian/marshal/milestones{/number}","notifications_url":"https://api.github.com/repos/zorkian/marshal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zorkian/marshal/labels{/name}","releases_url":"https://api.github.com/repos/zorkian/marshal/releases{/id}","created_at":"2015-09-18T20:46:14Z","updated_at":"2015-11-18T19:41:53Z","pushed_at":"2015-11-20T01:08:12Z","git_url":"git://github.com/zorkian/marshal.git","ssh_url":"git@github.com:zorkian/marshal.git","clone_url":"https://github.com/zorkian/marshal.git","svn_url":"https://github.com/zorkian/marshal","homepage":null,"size":99,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":10,"forks":2,"open_issues":10,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zorkian/marshal/pulls/32"},"html":{"href":"https://github.com/zorkian/marshal/pull/32"},"issue":{"href":"https://api.github.com/repos/zorkian/marshal/issues/32"},"comments":{"href":"https://api.github.com/repos/zorkian/marshal/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/zorkian/marshal/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/zorkian/marshal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zorkian/marshal/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/zorkian/marshal/statuses/1cfb6d31b73522241211fb57e6a910e36944fc08"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":126,"deletions":38,"changed_files":5}}