{"action":"created","issue":{"url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/issues/7","labels_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/issues/7/comments","events_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/issues/7/events","html_url":"https://github.com/DataQualityCommittee/dqc_us_rules/issues/7","id":103411662,"number":7,"title":"DQC 0004 This rule should have a tolerance of half a percent ","user":{"login":"neilapwills","id":13490426,"avatar_url":"https://avatars.githubusercontent.com/u/13490426?v=3","gravatar_id":"","url":"https://api.github.com/users/neilapwills","html_url":"https://github.com/neilapwills","followers_url":"https://api.github.com/users/neilapwills/followers","following_url":"https://api.github.com/users/neilapwills/following{/other_user}","gists_url":"https://api.github.com/users/neilapwills/gists{/gist_id}","starred_url":"https://api.github.com/users/neilapwills/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neilapwills/subscriptions","organizations_url":"https://api.github.com/users/neilapwills/orgs","repos_url":"https://api.github.com/users/neilapwills/repos","events_url":"https://api.github.com/users/neilapwills/events{/privacy}","received_events_url":"https://api.github.com/users/neilapwills/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-08-27T02:32:18Z","updated_at":"2015-08-31T18:42:37Z","closed_at":null,"body":"Reviewing the compliance description we noted:\r\n\r\ndqc_us_rules-master\\dqc_us_rules-master\\tests\\test_suite\\DQC_Testcases_2015-07-14\\DQC_Testcases_v28\\DQC_0004\\variation.xml\r\n\r\nNote \"This rule should have a tolerance of half a percent \"\r\n\r\n <description>Create a fail case when Assets is not equal to LiabilitiesAndStockholdersEquity with the same context. This rule should have a tolerance of half a percent of the value of Assets.If the difference is within this tolerance then the rule will not report.</description>\r\n\r\nIs this implemented in the reference implementation?\r\n\r\ndqc_us_rules-master\\dqc_us_rules-master\\src\\dqc_us_0004.py\r\n\r\nWe did not see the half of percent defined under:\r\nhttps://github.com/DataQualityCommittee/dqc_us_rules/blob/master/docs/DQC_US_0004/DQC_0004.md"},"comment":{"url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/issues/comments/136460354","html_url":"https://github.com/DataQualityCommittee/dqc_us_rules/issues/7#issuecomment-136460354","issue_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/issues/7","id":136460354,"user":{"login":"campbellpryde","id":12953751,"avatar_url":"https://avatars.githubusercontent.com/u/12953751?v=3","gravatar_id":"","url":"https://api.github.com/users/campbellpryde","html_url":"https://github.com/campbellpryde","followers_url":"https://api.github.com/users/campbellpryde/followers","following_url":"https://api.github.com/users/campbellpryde/following{/other_user}","gists_url":"https://api.github.com/users/campbellpryde/gists{/gist_id}","starred_url":"https://api.github.com/users/campbellpryde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/campbellpryde/subscriptions","organizations_url":"https://api.github.com/users/campbellpryde/orgs","repos_url":"https://api.github.com/users/campbellpryde/repos","events_url":"https://api.github.com/users/campbellpryde/events{/privacy}","received_events_url":"https://api.github.com/users/campbellpryde/received_events","type":"User","site_admin":false},"created_at":"2015-08-31T18:42:37Z","updated_at":"2015-08-31T18:42:37Z","body":"This should have said the following:\r\nCreate a fail case when Assets is not equal to LiabilitiesAndStockholdersEquity with the same context. This rule should take into account the tolerance of using different decimal values for the numbers being compared. If the difference is within this tolerance then the rule will not report.\r\n\r\nThis will be updated in the test suite."}}