{"action":"created","comment":{"url":"https://api.github.com/repos/dimagi/touchforms/pulls/comments/31873500","id":31873500,"diff_hunk":"@@ -75,7 +75,7 @@ def mock_query(query_function, criteria):\n             self.xform,\n             session_data=self.session_data,\n             form_context={\n-                'all_case_ids': ['legolas', 'gimli'],\n+                'all_case_ids': ['legolas', 'sauron'],","path":"touchforms/backend/test_xformplayer.py","position":5,"original_position":5,"commit_id":"546aa7c7e8452ae2566d1ef92b530d7d6f697774","original_commit_id":"de2c8c3af4647414fb532be07b509ae38f182735","user":{"login":"benrudolph","id":918514,"avatar_url":"https://avatars.githubusercontent.com/u/918514?v=3","gravatar_id":"","url":"https://api.github.com/users/benrudolph","html_url":"https://github.com/benrudolph","followers_url":"https://api.github.com/users/benrudolph/followers","following_url":"https://api.github.com/users/benrudolph/following{/other_user}","gists_url":"https://api.github.com/users/benrudolph/gists{/gist_id}","starred_url":"https://api.github.com/users/benrudolph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benrudolph/subscriptions","organizations_url":"https://api.github.com/users/benrudolph/orgs","repos_url":"https://api.github.com/users/benrudolph/repos","events_url":"https://api.github.com/users/benrudolph/events{/privacy}","received_events_url":"https://api.github.com/users/benrudolph/received_events","type":"User","site_admin":false},"body":"hmm so if i understand correctly this worked before since we went in order through the `case_ids` and since we had the case for `legolas` in the `case_model` it stopped before checking gimli. now that we sort, gimli came first and broke it since the gimli case was not included in the `form_context` and thus looked for it on HQ which obviously isn't running during the tests. i think that that's fine, especially since this is really only used so we can test other functionality. it'll just make the tests kind of brittle. if we added the `gimli` case to the `form_context` i think it might've worked (https://github.com/dimagi/touchforms/blob/0efe0ccd3030b49d1ab248127fe2c4c7077ff6b5/touchforms/backend/test_touchcare.py#L67).\r\n\r\nanyways thanks for fixing and diving into the java code. looked brutal","created_at":"2015-06-07T03:13:21Z","updated_at":"2015-06-07T03:13:21Z","html_url":"https://github.com/dimagi/touchforms/pull/130#discussion_r31873500","pull_request_url":"https://api.github.com/repos/dimagi/touchforms/pulls/130","_links":{"self":{"href":"https://api.github.com/repos/dimagi/touchforms/pulls/comments/31873500"},"html":{"href":"https://github.com/dimagi/touchforms/pull/130#discussion_r31873500"},"pull_request":{"href":"https://api.github.com/repos/dimagi/touchforms/pulls/130"}}},"pull_request":{"url":"https://api.github.com/repos/dimagi/touchforms/pulls/130","id":37048389,"html_url":"https://github.com/dimagi/touchforms/pull/130","diff_url":"https://github.com/dimagi/touchforms/pull/130.diff","patch_url":"https://github.com/dimagi/touchforms/pull/130.patch","issue_url":"https://api.github.com/repos/dimagi/touchforms/issues/130","number":130,"state":"open","locked":false,"title":"sort ids inside CaseDB","user":{"login":"czue","id":66555,"avatar_url":"https://avatars.githubusercontent.com/u/66555?v=3","gravatar_id":"","url":"https://api.github.com/users/czue","html_url":"https://github.com/czue","followers_url":"https://api.github.com/users/czue/followers","following_url":"https://api.github.com/users/czue/following{/other_user}","gists_url":"https://api.github.com/users/czue/gists{/gist_id}","starred_url":"https://api.github.com/users/czue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/czue/subscriptions","organizations_url":"https://api.github.com/users/czue/orgs","repos_url":"https://api.github.com/users/czue/repos","events_url":"https://api.github.com/users/czue/events{/privacy}","received_events_url":"https://api.github.com/users/czue/received_events","type":"User","site_admin":false},"body":"version of https://github.com/dimagi/touchforms/pull/129 that hopefully fixes tests.\r\n\r\n@dannyroberts cc @TylerSheffels ","created_at":"2015-06-05T16:39:55Z","updated_at":"2015-06-07T03:13:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a2047b0b59bf87ab605075fcb41db04f6fa1d63e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dimagi/touchforms/pulls/130/commits","review_comments_url":"https://api.github.com/repos/dimagi/touchforms/pulls/130/comments","review_comment_url":"https://api.github.com/repos/dimagi/touchforms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dimagi/touchforms/issues/130/comments","statuses_url":"https://api.github.com/repos/dimagi/touchforms/statuses/546aa7c7e8452ae2566d1ef92b530d7d6f697774","head":{"label":"dimagi:object-id-ordering","ref":"object-id-ordering","sha":"546aa7c7e8452ae2566d1ef92b530d7d6f697774","user":{"login":"dimagi","id":94514,"avatar_url":"https://avatars.githubusercontent.com/u/94514?v=3","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"repo":{"id":1330256,"name":"touchforms","full_name":"dimagi/touchforms","owner":{"login":"dimagi","id":94514,"avatar_url":"https://avatars.githubusercontent.com/u/94514?v=3","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dimagi/touchforms","description":"web-based javarosa xforms player built for touchscreen kiosks","fork":false,"url":"https://api.github.com/repos/dimagi/touchforms","forks_url":"https://api.github.com/repos/dimagi/touchforms/forks","keys_url":"https://api.github.com/repos/dimagi/touchforms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimagi/touchforms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimagi/touchforms/teams","hooks_url":"https://api.github.com/repos/dimagi/touchforms/hooks","issue_events_url":"https://api.github.com/repos/dimagi/touchforms/issues/events{/number}","events_url":"https://api.github.com/repos/dimagi/touchforms/events","assignees_url":"https://api.github.com/repos/dimagi/touchforms/assignees{/user}","branches_url":"https://api.github.com/repos/dimagi/touchforms/branches{/branch}","tags_url":"https://api.github.com/repos/dimagi/touchforms/tags","blobs_url":"https://api.github.com/repos/dimagi/touchforms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimagi/touchforms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimagi/touchforms/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimagi/touchforms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimagi/touchforms/statuses/{sha}","languages_url":"https://api.github.com/repos/dimagi/touchforms/languages","stargazers_url":"https://api.github.com/repos/dimagi/touchforms/stargazers","contributors_url":"https://api.github.com/repos/dimagi/touchforms/contributors","subscribers_url":"https://api.github.com/repos/dimagi/touchforms/subscribers","subscription_url":"https://api.github.com/repos/dimagi/touchforms/subscription","commits_url":"https://api.github.com/repos/dimagi/touchforms/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimagi/touchforms/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimagi/touchforms/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimagi/touchforms/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimagi/touchforms/contents/{+path}","compare_url":"https://api.github.com/repos/dimagi/touchforms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimagi/touchforms/merges","archive_url":"https://api.github.com/repos/dimagi/touchforms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimagi/touchforms/downloads","issues_url":"https://api.github.com/repos/dimagi/touchforms/issues{/number}","pulls_url":"https://api.github.com/repos/dimagi/touchforms/pulls{/number}","milestones_url":"https://api.github.com/repos/dimagi/touchforms/milestones{/number}","notifications_url":"https://api.github.com/repos/dimagi/touchforms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimagi/touchforms/labels{/name}","releases_url":"https://api.github.com/repos/dimagi/touchforms/releases{/id}","created_at":"2011-02-05T01:25:38Z","updated_at":"2015-05-08T15:14:19Z","pushed_at":"2015-06-07T02:47:58Z","git_url":"git://github.com/dimagi/touchforms.git","ssh_url":"git@github.com:dimagi/touchforms.git","clone_url":"https://github.com/dimagi/touchforms.git","svn_url":"https://github.com/dimagi/touchforms","homepage":"","size":25718,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":7,"forks":9,"open_issues":7,"watchers":5,"default_branch":"master"}},"base":{"label":"dimagi:master","ref":"master","sha":"c76074ad8927b62fee38ee92f218ba1300e6dd43","user":{"login":"dimagi","id":94514,"avatar_url":"https://avatars.githubusercontent.com/u/94514?v=3","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"repo":{"id":1330256,"name":"touchforms","full_name":"dimagi/touchforms","owner":{"login":"dimagi","id":94514,"avatar_url":"https://avatars.githubusercontent.com/u/94514?v=3","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dimagi/touchforms","description":"web-based javarosa xforms player built for touchscreen kiosks","fork":false,"url":"https://api.github.com/repos/dimagi/touchforms","forks_url":"https://api.github.com/repos/dimagi/touchforms/forks","keys_url":"https://api.github.com/repos/dimagi/touchforms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimagi/touchforms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimagi/touchforms/teams","hooks_url":"https://api.github.com/repos/dimagi/touchforms/hooks","issue_events_url":"https://api.github.com/repos/dimagi/touchforms/issues/events{/number}","events_url":"https://api.github.com/repos/dimagi/touchforms/events","assignees_url":"https://api.github.com/repos/dimagi/touchforms/assignees{/user}","branches_url":"https://api.github.com/repos/dimagi/touchforms/branches{/branch}","tags_url":"https://api.github.com/repos/dimagi/touchforms/tags","blobs_url":"https://api.github.com/repos/dimagi/touchforms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimagi/touchforms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimagi/touchforms/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimagi/touchforms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimagi/touchforms/statuses/{sha}","languages_url":"https://api.github.com/repos/dimagi/touchforms/languages","stargazers_url":"https://api.github.com/repos/dimagi/touchforms/stargazers","contributors_url":"https://api.github.com/repos/dimagi/touchforms/contributors","subscribers_url":"https://api.github.com/repos/dimagi/touchforms/subscribers","subscription_url":"https://api.github.com/repos/dimagi/touchforms/subscription","commits_url":"https://api.github.com/repos/dimagi/touchforms/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimagi/touchforms/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimagi/touchforms/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimagi/touchforms/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimagi/touchforms/contents/{+path}","compare_url":"https://api.github.com/repos/dimagi/touchforms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimagi/touchforms/merges","archive_url":"https://api.github.com/repos/dimagi/touchforms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimagi/touchforms/downloads","issues_url":"https://api.github.com/repos/dimagi/touchforms/issues{/number}","pulls_url":"https://api.github.com/repos/dimagi/touchforms/pulls{/number}","milestones_url":"https://api.github.com/repos/dimagi/touchforms/milestones{/number}","notifications_url":"https://api.github.com/repos/dimagi/touchforms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimagi/touchforms/labels{/name}","releases_url":"https://api.github.com/repos/dimagi/touchforms/releases{/id}","created_at":"2011-02-05T01:25:38Z","updated_at":"2015-05-08T15:14:19Z","pushed_at":"2015-06-07T02:47:58Z","git_url":"git://github.com/dimagi/touchforms.git","ssh_url":"git@github.com:dimagi/touchforms.git","clone_url":"https://github.com/dimagi/touchforms.git","svn_url":"https://github.com/dimagi/touchforms","homepage":"","size":25718,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":7,"forks":9,"open_issues":7,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dimagi/touchforms/pulls/130"},"html":{"href":"https://github.com/dimagi/touchforms/pull/130"},"issue":{"href":"https://api.github.com/repos/dimagi/touchforms/issues/130"},"comments":{"href":"https://api.github.com/repos/dimagi/touchforms/issues/130/comments"},"review_comments":{"href":"https://api.github.com/repos/dimagi/touchforms/pulls/130/comments"},"review_comment":{"href":"https://api.github.com/repos/dimagi/touchforms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dimagi/touchforms/pulls/130/commits"},"statuses":{"href":"https://api.github.com/repos/dimagi/touchforms/statuses/546aa7c7e8452ae2566d1ef92b530d7d6f697774"}}}}