{"action":"created","issue":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3212","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3212/labels{/name}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3212/comments","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3212/events","html_url":"https://github.com/dolphin-emu/dolphin/pull/3212","id":114135003,"number":3212,"title":"JIT x64: Recalculate flags after add/sub","user":{"login":"mickdermack","id":888970,"avatar_url":"https://avatars.githubusercontent.com/u/888970?v=3","gravatar_id":"","url":"https://api.github.com/users/mickdermack","html_url":"https://github.com/mickdermack","followers_url":"https://api.github.com/users/mickdermack/followers","following_url":"https://api.github.com/users/mickdermack/following{/other_user}","gists_url":"https://api.github.com/users/mickdermack/gists{/gist_id}","starred_url":"https://api.github.com/users/mickdermack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mickdermack/subscriptions","organizations_url":"https://api.github.com/users/mickdermack/orgs","repos_url":"https://api.github.com/users/mickdermack/repos","events_url":"https://api.github.com/users/mickdermack/events{/privacy}","received_events_url":"https://api.github.com/users/mickdermack/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-29T20:07:16Z","updated_at":"2015-10-29T20:17:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3212","html_url":"https://github.com/dolphin-emu/dolphin/pull/3212","diff_url":"https://github.com/dolphin-emu/dolphin/pull/3212.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/3212.patch"},"body":"The x86/x64 add and sub instructions (and a few more) can set OF, which causes merged branches to take wrong jumps. The easiest way to fix this seems to be to recalculate the flags with test afterwards.\r\nThis fixes [Issue 8787](https://bugs.dolphin-emu.org/issues/8787).\r\n\r\nI wrote some test cases for some instructions; if someone is interested, I can submit a PR at hwtests.\r\n\r\nProper emulation of PPC SO flag remains to be done, though I don't know if there is a game using it."},"comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments/152306280","html_url":"https://github.com/dolphin-emu/dolphin/pull/3212#issuecomment-152306280","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3212","id":152306280,"user":{"login":"dolphin-emu-bot","id":6899296,"avatar_url":"https://avatars.githubusercontent.com/u/6899296?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu-bot","html_url":"https://github.com/dolphin-emu-bot","followers_url":"https://api.github.com/users/dolphin-emu-bot/followers","following_url":"https://api.github.com/users/dolphin-emu-bot/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu-bot/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu-bot/orgs","repos_url":"https://api.github.com/users/dolphin-emu-bot/repos","events_url":"https://api.github.com/users/dolphin-emu-bot/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu-bot/received_events","type":"User","site_admin":false},"created_at":"2015-10-29T20:17:17Z","updated_at":"2015-10-29T20:17:17Z","body":"[FifoCI](https://fifoci.dolphin-emu.org/about/) detected that this change impacts graphical             rendering. Here are the [behavior differences](https://fifoci.dolphin-emu.org/version/0e192f928c473fb75f789e40aa20253665e63b97/)             detected by the system:\n\n* `kirby-shadows` on `ogl-lin-intel`: [diff](https://fifoci.dolphin-emu.org/compare/763949-762490/)\n* `melee-lighting` on `ogl-lin-intel`: [diff](https://fifoci.dolphin-emu.org/compare/763929-762474/)\n* `mp7-text` on `ogl-lin-intel`: [diff](https://fifoci.dolphin-emu.org/compare/763956-762483/)\n* `rs2-glass` on `ogl-lin-intel`: [diff](https://fifoci.dolphin-emu.org/compare/763934-762505/)\n* `rs2-zfreeze` on `ogl-lin-intel`: [diff](https://fifoci.dolphin-emu.org/compare/763920-762482/)\n* `ss-timestone` on `ogl-lin-intel`: [diff](https://fifoci.dolphin-emu.org/compare/763935-762504/)\n* `thps4-shadow` on `ogl-lin-intel`: [diff](https://fifoci.dolphin-emu.org/compare/763928-762477/)\n* `tsp3-pinkgrass` on `ogl-lin-intel`: [diff](https://fifoci.dolphin-emu.org/compare/763902-762488/)\n* `zww-armos` on `ogl-lin-intel`: [diff](https://fifoci.dolphin-emu.org/compare/763957-762503/)\n* `zww-water` on `ogl-lin-intel`: [diff](https://fifoci.dolphin-emu.org/compare/763937-762499/)\n\n<sub><sup>automated-fifoci-reporter</sup></sub>"}}