{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/rkt/pulls/comments/30608801","id":30608801,"diff_hunk":"@@ -0,0 +1,191 @@\n+AC_PREREQ([2.69])\n+AC_INIT([rkt], [0.1], [https://github.com/coreos/rkt/issues])\n+\n+# Sets parameters\n+\n+# RKT source distribution path\n+AC_ARG_WITH(org-path,\n+        AS_HELP_STRING([--with-org-path=PATH],\n+                [Path to rkt source distribution]),\n+        [ORG_PATH=\"$withval\"],\n+        [ORG_PATH=\"github.com/coreos\"])\n+\n+AC_SUBST(ORG_PATH)\n+\n+# STAGE1 build settings\n+\n+## STAGE1:type\n+AC_ARG_WITH(stage1,\n+        AS_HELP_STRING([--with-stage1=type],\n+                [type of stage1 build one of 'src', 'coreos', 'none']),\n+        [RKT_STAGE1_USR_FROM=\"$withval\"],\n+        [RKT_STAGE1_USR_FROM=\"coreos\"])\n+\n+case \"${RKT_STAGE1_USR_FROM}\" in\n+\tnone)\n+        AC_MSG_RESULT([stage1 build disabled])\n+\t\t;;\n+\tcoreos)\n+        AC_MSG_RESULT([stage1 will reuse coreos image])\n+        \n+        # check that some coreos-build specific binaries are here\n+        AC_CHECK_PROG([CURL],[curl],[curl])\n+        if test x\"${CURL}\" == x ; then\n+            AC_MSG_ERROR([curl not found])\n+        fi\n+\n+        AC_CHECK_PROG([GPG],[gpg],[gpg])\n+        if test x\"${GPG}\" == x ; then\n+            AC_MSG_ERROR([gpg not found])\n+        fi\n+\n+        AC_CHECK_PROG([MKTEMP],[mktemp],[mktemp])\n+        if test x\"${MKTEMP}\" == x ; then\n+            AC_MSG_ERROR([mktemp not found])\n+        fi\n+\n+        AC_CHECK_PROG([MD5SUM],[md5sum],[md5sum])\n+        if test x\"${MD5SUM}\" == x ; then\n+            AC_MSG_ERROR([md5sum not found])\n+        fi\n+\n+        AC_CHECK_PROG([CPIO],[cpio],[cpio])\n+        if test x\"${CPIO}\" == x ; then\n+            AC_MSG_ERROR([cpio not found])\n+        fi\n+\n+        AC_CHECK_PROG([GZIP],[gzip],[gzip])\n+        if test x\"${GZIP}\" == x ; then\n+            AC_MSG_ERROR([gzip not found])\n+        fi\n+\n+        AC_CHECK_PROG([UNSQUASHFS],[unsquashfs],[unsquashfs])\n+        if test x\"${UNSQUASHFS}\" == x ; then\n+            AC_MSG_ERROR([unsquashfs not found])\n+        fi\n+\n+        AC_CHECK_PROG([SORT],[sort],[sort])\n+        if test x\"${SORT}\" == x ; then\n+            AC_MSG_ERROR([sort not found])\n+        fi\n+        \n+\t\t;;\n+\tsrc)\n+        AC_MSG_RESULT([stage1 will build systemd from source])\n+\n+        # these are needed for systemd build\n+        AC_CHECK_PROG([INTLTOOLIZE],[intltoolize],[intltoolize])\n+        if test x\"${INTLTOOLIZE}\" == x ; then\n+            AC_MSG_ERROR([intltoolize not installed, apt-get install intltool])\n+        fi\n+\n+        AC_CHECK_PROG([LIBTOOLIZE],[libtoolize],[libtoolize])\n+        if test x\"${LIBTOOLIZE}\" == x ; then\n+            AC_MSG_ERROR([libtoolize not installed, apt-get install libtool])\n+        fi\n+\t\t;;\n+\t*)\n+\t\tAC_MSG_ERROR([stage1 build type '${RKT_STAGE1_USR_FROM}' unsupported])\n+esac\n+\n+AC_SUBST(RKT_STAGE1_USR_FROM)\n+\n+## STAGE1: Systemd git path\n+AC_ARG_WITH(stage1-systemd-src,\n+        AS_HELP_STRING([--with-stage1-systemd-src=git-path],\n+                [address to git repository of systemd, used in 'src' build mode]),","path":"configure.ac","position":96,"original_position":96,"commit_id":"13b16a1d683eaaf27e610294776fac33d02f74f5","original_commit_id":"13b16a1d683eaaf27e610294776fac33d02f74f5","user":{"login":"krnowak","id":96081,"avatar_url":"https://avatars.githubusercontent.com/u/96081?v=3","gravatar_id":"","url":"https://api.github.com/users/krnowak","html_url":"https://github.com/krnowak","followers_url":"https://api.github.com/users/krnowak/followers","following_url":"https://api.github.com/users/krnowak/following{/other_user}","gists_url":"https://api.github.com/users/krnowak/gists{/gist_id}","starred_url":"https://api.github.com/users/krnowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krnowak/subscriptions","organizations_url":"https://api.github.com/users/krnowak/orgs","repos_url":"https://api.github.com/users/krnowak/repos","events_url":"https://api.github.com/users/krnowak/events{/privacy}","received_events_url":"https://api.github.com/users/krnowak/received_events","type":"User","site_admin":false},"body":"Please add an information about default value in help string (see above for an example).","created_at":"2015-05-19T15:05:28Z","updated_at":"2015-05-19T15:05:28Z","html_url":"https://github.com/coreos/rkt/pull/908#discussion_r30608801","pull_request_url":"https://api.github.com/repos/coreos/rkt/pulls/908","_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments/30608801"},"html":{"href":"https://github.com/coreos/rkt/pull/908#discussion_r30608801"},"pull_request":{"href":"https://api.github.com/repos/coreos/rkt/pulls/908"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/rkt/pulls/908","id":35563846,"html_url":"https://github.com/coreos/rkt/pull/908","diff_url":"https://github.com/coreos/rkt/pull/908.diff","patch_url":"https://github.com/coreos/rkt/pull/908.patch","issue_url":"https://api.github.com/repos/coreos/rkt/issues/908","number":908,"state":"open","locked":false,"title":"stage0,stage1: autoconf-based build and dbus","user":{"login":"klizhentas","id":13717,"avatar_url":"https://avatars.githubusercontent.com/u/13717?v=3","gravatar_id":"","url":"https://api.github.com/users/klizhentas","html_url":"https://github.com/klizhentas","followers_url":"https://api.github.com/users/klizhentas/followers","following_url":"https://api.github.com/users/klizhentas/following{/other_user}","gists_url":"https://api.github.com/users/klizhentas/gists{/gist_id}","starred_url":"https://api.github.com/users/klizhentas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klizhentas/subscriptions","organizations_url":"https://api.github.com/users/klizhentas/orgs","repos_url":"https://api.github.com/users/klizhentas/repos","events_url":"https://api.github.com/users/klizhentas/events{/privacy}","received_events_url":"https://api.github.com/users/klizhentas/received_events","type":"User","site_admin":false},"body":"This commit migrates rkt build process to autoconf and make toolchain\r\nto provide the following features:\r\n\r\n* checking for prerequisites in before the build instead of build time\r\n* adds the following explicit configuration flags:\r\n\r\n```\r\n  --with-stage1=type      type of stage1 build one of 'src', 'coreos', 'none'\r\n  --with-stage1-systemd-src=git-path\r\n                          address to git repository of systemd, used in 'src'\r\n                          build mode\r\n  --with-stage1-systemd-version=version\r\n                          systemd version to build\r\n  --with-stage1-image-path\r\n                          custom stage1 image path\r\n  --with-stage1-dbus=no   turn of d-bus or not, 'yes' turns it on, 'no' turns\r\n                          it off\r\n  --with-stage1-dbus-src=git-path\r\n                          address to git repository of systemd, used in 'src'\r\n                          build mode\r\n  --with-stage1-dbus-version=version\r\n                          d-bus version to build\r\n```\r\n\r\n* adds explicit `BUILDDIR` make variable to build outside of the source tree\r\n* adds explicit `make stage0` and `make stage1` targets\r\n* adds configuration-time support for D-Bus runnning as `messagebus` user\r\n* adds makefile macros library `makelib/lib.mk` for common build operations\r\n\r\nBuild changes\r\n-------------\r\n\r\nThe build is now changed from the `./build` to 3 phase step:\r\n\r\n1. `./autogen.sh` step to regenerate configure script\r\n2. `./configure` build step to generate Makefile\r\n3. `make` build step\r\n\r\nOther changes\r\n-------------\r\n\r\n1. remove `aggregate` directory in favor of `BUILDDIR` external directory\r\n2. split `aggregate` contents into individual modules in stage1 directory","created_at":"2015-05-16T02:19:02Z","updated_at":"2015-05-19T15:05:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5502219f4dd52f66294dd7e94d52e76882d7d4f9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/coreos/rkt/pulls/908/commits","review_comments_url":"https://api.github.com/repos/coreos/rkt/pulls/908/comments","review_comment_url":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/rkt/issues/908/comments","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/13b16a1d683eaaf27e610294776fac33d02f74f5","head":{"label":"klizhentas:autoconf","ref":"autoconf","sha":"13b16a1d683eaaf27e610294776fac33d02f74f5","user":{"login":"klizhentas","id":13717,"avatar_url":"https://avatars.githubusercontent.com/u/13717?v=3","gravatar_id":"","url":"https://api.github.com/users/klizhentas","html_url":"https://github.com/klizhentas","followers_url":"https://api.github.com/users/klizhentas/followers","following_url":"https://api.github.com/users/klizhentas/following{/other_user}","gists_url":"https://api.github.com/users/klizhentas/gists{/gist_id}","starred_url":"https://api.github.com/users/klizhentas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klizhentas/subscriptions","organizations_url":"https://api.github.com/users/klizhentas/orgs","repos_url":"https://api.github.com/users/klizhentas/repos","events_url":"https://api.github.com/users/klizhentas/events{/privacy}","received_events_url":"https://api.github.com/users/klizhentas/received_events","type":"User","site_admin":false},"repo":{"id":33846292,"name":"rkt","full_name":"klizhentas/rkt","owner":{"login":"klizhentas","id":13717,"avatar_url":"https://avatars.githubusercontent.com/u/13717?v=3","gravatar_id":"","url":"https://api.github.com/users/klizhentas","html_url":"https://github.com/klizhentas","followers_url":"https://api.github.com/users/klizhentas/followers","following_url":"https://api.github.com/users/klizhentas/following{/other_user}","gists_url":"https://api.github.com/users/klizhentas/gists{/gist_id}","starred_url":"https://api.github.com/users/klizhentas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klizhentas/subscriptions","organizations_url":"https://api.github.com/users/klizhentas/orgs","repos_url":"https://api.github.com/users/klizhentas/repos","events_url":"https://api.github.com/users/klizhentas/events{/privacy}","received_events_url":"https://api.github.com/users/klizhentas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/klizhentas/rkt","description":"App Container runtime","fork":true,"url":"https://api.github.com/repos/klizhentas/rkt","forks_url":"https://api.github.com/repos/klizhentas/rkt/forks","keys_url":"https://api.github.com/repos/klizhentas/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/klizhentas/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/klizhentas/rkt/teams","hooks_url":"https://api.github.com/repos/klizhentas/rkt/hooks","issue_events_url":"https://api.github.com/repos/klizhentas/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/klizhentas/rkt/events","assignees_url":"https://api.github.com/repos/klizhentas/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/klizhentas/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/klizhentas/rkt/tags","blobs_url":"https://api.github.com/repos/klizhentas/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/klizhentas/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/klizhentas/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/klizhentas/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/klizhentas/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/klizhentas/rkt/languages","stargazers_url":"https://api.github.com/repos/klizhentas/rkt/stargazers","contributors_url":"https://api.github.com/repos/klizhentas/rkt/contributors","subscribers_url":"https://api.github.com/repos/klizhentas/rkt/subscribers","subscription_url":"https://api.github.com/repos/klizhentas/rkt/subscription","commits_url":"https://api.github.com/repos/klizhentas/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/klizhentas/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/klizhentas/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/klizhentas/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/klizhentas/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/klizhentas/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/klizhentas/rkt/merges","archive_url":"https://api.github.com/repos/klizhentas/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/klizhentas/rkt/downloads","issues_url":"https://api.github.com/repos/klizhentas/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/klizhentas/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/klizhentas/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/klizhentas/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/klizhentas/rkt/labels{/name}","releases_url":"https://api.github.com/repos/klizhentas/rkt/releases{/id}","created_at":"2015-04-13T03:41:49Z","updated_at":"2015-05-05T21:15:38Z","pushed_at":"2015-05-16T02:18:05Z","git_url":"git://github.com/klizhentas/rkt.git","ssh_url":"git@github.com:klizhentas/rkt.git","clone_url":"https://github.com/klizhentas/rkt.git","svn_url":"https://github.com/klizhentas/rkt","homepage":"","size":6024,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"ec04de715606ea737cd1b38f76cadefce28c484e","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":26509369,"name":"rkt","full_name":"coreos/rkt","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/rkt","description":"rkt is an App Container runtime for Linux","fork":false,"url":"https://api.github.com/repos/coreos/rkt","forks_url":"https://api.github.com/repos/coreos/rkt/forks","keys_url":"https://api.github.com/repos/coreos/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/rkt/teams","hooks_url":"https://api.github.com/repos/coreos/rkt/hooks","issue_events_url":"https://api.github.com/repos/coreos/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/rkt/events","assignees_url":"https://api.github.com/repos/coreos/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/rkt/tags","blobs_url":"https://api.github.com/repos/coreos/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/rkt/languages","stargazers_url":"https://api.github.com/repos/coreos/rkt/stargazers","contributors_url":"https://api.github.com/repos/coreos/rkt/contributors","subscribers_url":"https://api.github.com/repos/coreos/rkt/subscribers","subscription_url":"https://api.github.com/repos/coreos/rkt/subscription","commits_url":"https://api.github.com/repos/coreos/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/rkt/merges","archive_url":"https://api.github.com/repos/coreos/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/rkt/downloads","issues_url":"https://api.github.com/repos/coreos/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/rkt/labels{/name}","releases_url":"https://api.github.com/repos/coreos/rkt/releases{/id}","created_at":"2014-11-11T23:13:18Z","updated_at":"2015-05-19T06:06:18Z","pushed_at":"2015-05-19T14:49:29Z","git_url":"git://github.com/coreos/rkt.git","ssh_url":"git@github.com:coreos/rkt.git","clone_url":"https://github.com/coreos/rkt.git","svn_url":"https://github.com/coreos/rkt","homepage":"","size":16124,"stargazers_count":4157,"watchers_count":4157,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":312,"mirror_url":null,"open_issues_count":120,"forks":312,"open_issues":120,"watchers":4157,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/908"},"html":{"href":"https://github.com/coreos/rkt/pull/908"},"issue":{"href":"https://api.github.com/repos/coreos/rkt/issues/908"},"comments":{"href":"https://api.github.com/repos/coreos/rkt/issues/908/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/rkt/pulls/908/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/rkt/pulls/908/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/rkt/statuses/13b16a1d683eaaf27e610294776fac33d02f74f5"}}}}