{"action":"opened","number":8954,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/8954","id":53495780,"html_url":"https://github.com/servo/servo/pull/8954","diff_url":"https://github.com/servo/servo/pull/8954.diff","patch_url":"https://github.com/servo/servo/pull/8954.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/8954","number":8954,"state":"open","locked":false,"title":"Fix prototypes of interface objects","user":{"login":"nox","id":123095,"avatar_url":"https://avatars.githubusercontent.com/u/123095?v=3","gravatar_id":"","url":"https://api.github.com/users/nox","html_url":"https://github.com/nox","followers_url":"https://api.github.com/users/nox/followers","following_url":"https://api.github.com/users/nox/following{/other_user}","gists_url":"https://api.github.com/users/nox/gists{/gist_id}","starred_url":"https://api.github.com/users/nox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nox/subscriptions","organizations_url":"https://api.github.com/users/nox/orgs","repos_url":"https://api.github.com/users/nox/repos","events_url":"https://api.github.com/users/nox/events{/privacy}","received_events_url":"https://api.github.com/users/nox/received_events","type":"User","site_admin":false},"body":"Callback interface objects' (i.e. NodeFilter's) prototype is now Object instead of\r\nFunction and non-callback interface objects' their proper ancestor, starting with\r\nthe Function prototype.\r\n\r\nThe function do_create_interface_objects is removed in favour of 4 functions:\r\ncreate_callback_interface_object, create_interface_prototype_object,\r\ncreate_noncallback_interface_object and create_named_constructors.\r\n\r\nWhile this increases the amount of codegen'd code, this greatly improves the\r\nreadability of the code involved in this part of DOM, instead of having one function\r\ndoing 4 different things. We can always find a more adequate abstraction later.\r\n\r\nNativeProperties and everything related to the interface objects have been removed\r\nfrom the utils module.","created_at":"2015-12-13T08:56:04Z","updated_at":"2015-12-13T08:56:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/8954/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/8954/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/8954/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/752cad204760094c1b09cd2c25b686f45c1dadf6","head":{"label":"nox:protochain","ref":"protochain","sha":"752cad204760094c1b09cd2c25b686f45c1dadf6","user":{"login":"nox","id":123095,"avatar_url":"https://avatars.githubusercontent.com/u/123095?v=3","gravatar_id":"","url":"https://api.github.com/users/nox","html_url":"https://github.com/nox","followers_url":"https://api.github.com/users/nox/followers","following_url":"https://api.github.com/users/nox/following{/other_user}","gists_url":"https://api.github.com/users/nox/gists{/gist_id}","starred_url":"https://api.github.com/users/nox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nox/subscriptions","organizations_url":"https://api.github.com/users/nox/orgs","repos_url":"https://api.github.com/users/nox/repos","events_url":"https://api.github.com/users/nox/events{/privacy}","received_events_url":"https://api.github.com/users/nox/received_events","type":"User","site_admin":false},"repo":{"id":33321670,"name":"servo","full_name":"nox/servo","owner":{"login":"nox","id":123095,"avatar_url":"https://avatars.githubusercontent.com/u/123095?v=3","gravatar_id":"","url":"https://api.github.com/users/nox","html_url":"https://github.com/nox","followers_url":"https://api.github.com/users/nox/followers","following_url":"https://api.github.com/users/nox/following{/other_user}","gists_url":"https://api.github.com/users/nox/gists{/gist_id}","starred_url":"https://api.github.com/users/nox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nox/subscriptions","organizations_url":"https://api.github.com/users/nox/orgs","repos_url":"https://api.github.com/users/nox/repos","events_url":"https://api.github.com/users/nox/events{/privacy}","received_events_url":"https://api.github.com/users/nox/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nox/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/nox/servo","forks_url":"https://api.github.com/repos/nox/servo/forks","keys_url":"https://api.github.com/repos/nox/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nox/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nox/servo/teams","hooks_url":"https://api.github.com/repos/nox/servo/hooks","issue_events_url":"https://api.github.com/repos/nox/servo/issues/events{/number}","events_url":"https://api.github.com/repos/nox/servo/events","assignees_url":"https://api.github.com/repos/nox/servo/assignees{/user}","branches_url":"https://api.github.com/repos/nox/servo/branches{/branch}","tags_url":"https://api.github.com/repos/nox/servo/tags","blobs_url":"https://api.github.com/repos/nox/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nox/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nox/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/nox/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nox/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/nox/servo/languages","stargazers_url":"https://api.github.com/repos/nox/servo/stargazers","contributors_url":"https://api.github.com/repos/nox/servo/contributors","subscribers_url":"https://api.github.com/repos/nox/servo/subscribers","subscription_url":"https://api.github.com/repos/nox/servo/subscription","commits_url":"https://api.github.com/repos/nox/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/nox/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/nox/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/nox/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/nox/servo/contents/{+path}","compare_url":"https://api.github.com/repos/nox/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nox/servo/merges","archive_url":"https://api.github.com/repos/nox/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nox/servo/downloads","issues_url":"https://api.github.com/repos/nox/servo/issues{/number}","pulls_url":"https://api.github.com/repos/nox/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/nox/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/nox/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nox/servo/labels{/name}","releases_url":"https://api.github.com/repos/nox/servo/releases{/id}","created_at":"2015-04-02T17:16:39Z","updated_at":"2015-09-28T21:08:09Z","pushed_at":"2015-12-13T08:55:38Z","git_url":"git://github.com/nox/servo.git","ssh_url":"git@github.com:nox/servo.git","clone_url":"https://github.com/nox/servo.git","svn_url":"https://github.com/nox/servo","homepage":"","size":160855,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"8bab1cd7a4634618d18985d273c6997984919ecc","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","created_at":"2012-02-08T19:07:25Z","updated_at":"2015-12-12T19:26:45Z","pushed_at":"2015-12-13T08:25:32Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"http://servo.org/","size":185169,"stargazers_count":5336,"watchers_count":5336,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":887,"mirror_url":null,"open_issues_count":1270,"forks":887,"open_issues":1270,"watchers":5336,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/8954"},"html":{"href":"https://github.com/servo/servo/pull/8954"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/8954"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/8954/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/8954/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/8954/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/752cad204760094c1b09cd2c25b686f45c1dadf6"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":392,"deletions":698,"changed_files":9}}