{"action":"opened","number":4052,"pull_request":{"url":"https://api.github.com/repos/astropy/astropy/pulls/4052","id":41851493,"html_url":"https://github.com/astropy/astropy/pull/4052","diff_url":"https://github.com/astropy/astropy/pull/4052.diff","patch_url":"https://github.com/astropy/astropy/pull/4052.patch","issue_url":"https://api.github.com/repos/astropy/astropy/issues/4052","number":4052,"state":"open","locked":false,"title":"Handle sorting NaNs and masked values in jsviewer","user":{"login":"sargas","id":33512,"avatar_url":"https://avatars.githubusercontent.com/u/33512?v=3","gravatar_id":"","url":"https://api.github.com/users/sargas","html_url":"https://github.com/sargas","followers_url":"https://api.github.com/users/sargas/followers","following_url":"https://api.github.com/users/sargas/following{/other_user}","gists_url":"https://api.github.com/users/sargas/gists{/gist_id}","starred_url":"https://api.github.com/users/sargas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sargas/subscriptions","organizations_url":"https://api.github.com/users/sargas/orgs","repos_url":"https://api.github.com/users/sargas/repos","events_url":"https://api.github.com/users/sargas/events{/privacy}","received_events_url":"https://api.github.com/users/sargas/received_events","type":"User","site_admin":false},"body":"This is an attempt at a problem brought up on the astropy@ mailing list, and issue #2966.\n\nSpecifically, DataTable autodetects how to do the sorting, and believes columns with a 'nan' or '--' should be sorted as strings. This implementation explicitly marks any int- or float-like column as a new type of sortable column.","created_at":"2015-08-07T01:12:01Z","updated_at":"2015-08-07T01:12:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d394740b3f75022c5044899c86b7a276b3f98d4e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/astropy/astropy/pulls/4052/commits","review_comments_url":"https://api.github.com/repos/astropy/astropy/pulls/4052/comments","review_comment_url":"https://api.github.com/repos/astropy/astropy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/astropy/astropy/issues/4052/comments","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/49ef99350560f369384d1f73439c2ad09e73c076","head":{"label":"sargas:jsviewer-sort","ref":"jsviewer-sort","sha":"49ef99350560f369384d1f73439c2ad09e73c076","user":{"login":"sargas","id":33512,"avatar_url":"https://avatars.githubusercontent.com/u/33512?v=3","gravatar_id":"","url":"https://api.github.com/users/sargas","html_url":"https://github.com/sargas","followers_url":"https://api.github.com/users/sargas/followers","following_url":"https://api.github.com/users/sargas/following{/other_user}","gists_url":"https://api.github.com/users/sargas/gists{/gist_id}","starred_url":"https://api.github.com/users/sargas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sargas/subscriptions","organizations_url":"https://api.github.com/users/sargas/orgs","repos_url":"https://api.github.com/users/sargas/repos","events_url":"https://api.github.com/users/sargas/events{/privacy}","received_events_url":"https://api.github.com/users/sargas/received_events","type":"User","site_admin":false},"repo":{"id":23162106,"name":"astropy","full_name":"sargas/astropy","owner":{"login":"sargas","id":33512,"avatar_url":"https://avatars.githubusercontent.com/u/33512?v=3","gravatar_id":"","url":"https://api.github.com/users/sargas","html_url":"https://github.com/sargas","followers_url":"https://api.github.com/users/sargas/followers","following_url":"https://api.github.com/users/sargas/following{/other_user}","gists_url":"https://api.github.com/users/sargas/gists{/gist_id}","starred_url":"https://api.github.com/users/sargas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sargas/subscriptions","organizations_url":"https://api.github.com/users/sargas/orgs","repos_url":"https://api.github.com/users/sargas/repos","events_url":"https://api.github.com/users/sargas/events{/privacy}","received_events_url":"https://api.github.com/users/sargas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sargas/astropy","description":"Repository for the Astropy core package","fork":true,"url":"https://api.github.com/repos/sargas/astropy","forks_url":"https://api.github.com/repos/sargas/astropy/forks","keys_url":"https://api.github.com/repos/sargas/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sargas/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sargas/astropy/teams","hooks_url":"https://api.github.com/repos/sargas/astropy/hooks","issue_events_url":"https://api.github.com/repos/sargas/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/sargas/astropy/events","assignees_url":"https://api.github.com/repos/sargas/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/sargas/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/sargas/astropy/tags","blobs_url":"https://api.github.com/repos/sargas/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sargas/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sargas/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sargas/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sargas/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/sargas/astropy/languages","stargazers_url":"https://api.github.com/repos/sargas/astropy/stargazers","contributors_url":"https://api.github.com/repos/sargas/astropy/contributors","subscribers_url":"https://api.github.com/repos/sargas/astropy/subscribers","subscription_url":"https://api.github.com/repos/sargas/astropy/subscription","commits_url":"https://api.github.com/repos/sargas/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sargas/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sargas/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sargas/astropy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sargas/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/sargas/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sargas/astropy/merges","archive_url":"https://api.github.com/repos/sargas/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sargas/astropy/downloads","issues_url":"https://api.github.com/repos/sargas/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/sargas/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/sargas/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/sargas/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sargas/astropy/labels{/name}","releases_url":"https://api.github.com/repos/sargas/astropy/releases{/id}","created_at":"2014-08-20T19:55:40Z","updated_at":"2014-08-20T19:09:39Z","pushed_at":"2015-08-07T00:32:27Z","git_url":"git://github.com/sargas/astropy.git","ssh_url":"git@github.com:sargas/astropy.git","clone_url":"https://github.com/sargas/astropy.git","svn_url":"https://github.com/sargas/astropy","homepage":"www.astropy.org","size":31420,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"astropy:master","ref":"master","sha":"198343ba2f65b2ee59e6db0589110a065dff776d","user":{"login":"astropy","id":847984,"avatar_url":"https://avatars.githubusercontent.com/u/847984?v=3","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"repo":{"id":2081289,"name":"astropy","full_name":"astropy/astropy","owner":{"login":"astropy","id":847984,"avatar_url":"https://avatars.githubusercontent.com/u/847984?v=3","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/astropy/astropy","description":"Repository for the Astropy core package","fork":false,"url":"https://api.github.com/repos/astropy/astropy","forks_url":"https://api.github.com/repos/astropy/astropy/forks","keys_url":"https://api.github.com/repos/astropy/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astropy/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astropy/astropy/teams","hooks_url":"https://api.github.com/repos/astropy/astropy/hooks","issue_events_url":"https://api.github.com/repos/astropy/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/astropy/astropy/events","assignees_url":"https://api.github.com/repos/astropy/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/astropy/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/astropy/astropy/tags","blobs_url":"https://api.github.com/repos/astropy/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astropy/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astropy/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/astropy/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/astropy/astropy/languages","stargazers_url":"https://api.github.com/repos/astropy/astropy/stargazers","contributors_url":"https://api.github.com/repos/astropy/astropy/contributors","subscribers_url":"https://api.github.com/repos/astropy/astropy/subscribers","subscription_url":"https://api.github.com/repos/astropy/astropy/subscription","commits_url":"https://api.github.com/repos/astropy/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/astropy/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/astropy/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/astropy/astropy/issues/comments{/number}","contents_url":"https://api.github.com/repos/astropy/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/astropy/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astropy/astropy/merges","archive_url":"https://api.github.com/repos/astropy/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astropy/astropy/downloads","issues_url":"https://api.github.com/repos/astropy/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/astropy/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/astropy/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/astropy/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astropy/astropy/labels{/name}","releases_url":"https://api.github.com/repos/astropy/astropy/releases{/id}","created_at":"2011-07-21T01:33:49Z","updated_at":"2015-08-06T01:16:47Z","pushed_at":"2015-08-07T01:12:01Z","git_url":"git://github.com/astropy/astropy.git","ssh_url":"git@github.com:astropy/astropy.git","clone_url":"https://github.com/astropy/astropy.git","svn_url":"https://github.com/astropy/astropy","homepage":"www.astropy.org","size":65522,"stargazers_count":621,"watchers_count":621,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":414,"mirror_url":null,"open_issues_count":597,"forks":414,"open_issues":597,"watchers":621,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy/pulls/4052"},"html":{"href":"https://github.com/astropy/astropy/pull/4052"},"issue":{"href":"https://api.github.com/repos/astropy/astropy/issues/4052"},"comments":{"href":"https://api.github.com/repos/astropy/astropy/issues/4052/comments"},"review_comments":{"href":"https://api.github.com/repos/astropy/astropy/pulls/4052/comments"},"review_comment":{"href":"https://api.github.com/repos/astropy/astropy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/astropy/astropy/pulls/4052/commits"},"statuses":{"href":"https://api.github.com/repos/astropy/astropy/statuses/49ef99350560f369384d1f73439c2ad09e73c076"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":32,"deletions":13,"changed_files":4}}