{"action":"created","comment":{"url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/pulls/comments/42929734","id":42929734,"diff_hunk":"@@ -1,2 +1,29 @@\n # Evaluation\n \n+First we had to drop ordinal numbers once again - we found that parsing and understanding those\n+posed far too great a challenge, and it was simply not worth the additional implementation effort.\n+\n+We had to give up on limiting the number of directions they could specify with the parser - while \n+we tried to limit them to a maximum of four we couldn't seem to get the `PackratParser` to work.\n+We added this functionality with the interpreter, but it would have been nice to know while parsing.\n+\n+We got rid of a lot of our intermediate representation objects in favor of objects from\n+`picolib.semantics` because we found them to be unnecessary.\n+\n+We force them to use \"there is\" or \"there are\" (as grammatically appropriate) instead of simply\n+saying \"and Orcs towards the Shire\".  We found the additional implementation effort to ensure\n+that they do say \"there is\" or \"there are\" for the first time but not the rest be not worthwhile,\n+and we felt the grammatically correct aspect means a lot for our language (given the natural\n+language nature of our DSL).\n+","path":"evaluation.md","position":18,"original_position":18,"commit_id":"4f4111222c79ab6a9efbeb1c20dcf4bd6fffbbfc","original_commit_id":"4f4111222c79ab6a9efbeb1c20dcf4bd6fffbbfc","user":{"login":"jeansung","id":4502178,"avatar_url":"https://avatars.githubusercontent.com/u/4502178?v=3","gravatar_id":"","url":"https://api.github.com/users/jeansung","html_url":"https://github.com/jeansung","followers_url":"https://api.github.com/users/jeansung/followers","following_url":"https://api.github.com/users/jeansung/following{/other_user}","gists_url":"https://api.github.com/users/jeansung/gists{/gist_id}","starred_url":"https://api.github.com/users/jeansung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeansung/subscriptions","organizations_url":"https://api.github.com/users/jeansung/orgs","repos_url":"https://api.github.com/users/jeansung/repos","events_url":"https://api.github.com/users/jeansung/events{/privacy}","received_events_url":"https://api.github.com/users/jeansung/received_events","type":"User","site_admin":false},"body":"Yes, good choices! ","created_at":"2015-10-24T03:37:47Z","updated_at":"2015-10-24T03:37:47Z","html_url":"https://github.com/hmc-cs111-fall2015/piconot-external/pull/3#discussion_r42929734","pull_request_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/pulls/comments/42929734"},"html":{"href":"https://github.com/hmc-cs111-fall2015/piconot-external/pull/3#discussion_r42929734"},"pull_request":{"href":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/pulls/3","id":47731668,"html_url":"https://github.com/hmc-cs111-fall2015/piconot-external/pull/3","diff_url":"https://github.com/hmc-cs111-fall2015/piconot-external/pull/3.diff","patch_url":"https://github.com/hmc-cs111-fall2015/piconot-external/pull/3.patch","issue_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/issues/3","number":3,"state":"open","locked":false,"title":"Dan and Zoab's Submission","user":{"login":"ZoabKapoor","id":7916986,"avatar_url":"https://avatars.githubusercontent.com/u/7916986?v=3","gravatar_id":"","url":"https://api.github.com/users/ZoabKapoor","html_url":"https://github.com/ZoabKapoor","followers_url":"https://api.github.com/users/ZoabKapoor/followers","following_url":"https://api.github.com/users/ZoabKapoor/following{/other_user}","gists_url":"https://api.github.com/users/ZoabKapoor/gists{/gist_id}","starred_url":"https://api.github.com/users/ZoabKapoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZoabKapoor/subscriptions","organizations_url":"https://api.github.com/users/ZoabKapoor/orgs","repos_url":"https://api.github.com/users/ZoabKapoor/repos","events_url":"https://api.github.com/users/ZoabKapoor/events{/privacy}","received_events_url":"https://api.github.com/users/ZoabKapoor/received_events","type":"User","site_admin":false},"body":"I hope you like being pedantic about grammar","created_at":"2015-10-15T00:22:24Z","updated_at":"2015-10-24T03:37:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"23c2eb32e65d1aecfcd2326559cc5ae31bbe3fcf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/pulls/3/commits","review_comments_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/pulls/3/comments","review_comment_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/issues/3/comments","statuses_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/statuses/4f4111222c79ab6a9efbeb1c20dcf4bd6fffbbfc","head":{"label":"Dannnno:master","ref":"master","sha":"4f4111222c79ab6a9efbeb1c20dcf4bd6fffbbfc","user":{"login":"Dannnno","id":6121935,"avatar_url":"https://avatars.githubusercontent.com/u/6121935?v=3","gravatar_id":"","url":"https://api.github.com/users/Dannnno","html_url":"https://github.com/Dannnno","followers_url":"https://api.github.com/users/Dannnno/followers","following_url":"https://api.github.com/users/Dannnno/following{/other_user}","gists_url":"https://api.github.com/users/Dannnno/gists{/gist_id}","starred_url":"https://api.github.com/users/Dannnno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dannnno/subscriptions","organizations_url":"https://api.github.com/users/Dannnno/orgs","repos_url":"https://api.github.com/users/Dannnno/repos","events_url":"https://api.github.com/users/Dannnno/events{/privacy}","received_events_url":"https://api.github.com/users/Dannnno/received_events","type":"User","site_admin":false},"repo":{"id":44063473,"name":"piconot-external","full_name":"Dannnno/piconot-external","owner":{"login":"Dannnno","id":6121935,"avatar_url":"https://avatars.githubusercontent.com/u/6121935?v=3","gravatar_id":"","url":"https://api.github.com/users/Dannnno","html_url":"https://github.com/Dannnno","followers_url":"https://api.github.com/users/Dannnno/followers","following_url":"https://api.github.com/users/Dannnno/following{/other_user}","gists_url":"https://api.github.com/users/Dannnno/gists{/gist_id}","starred_url":"https://api.github.com/users/Dannnno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dannnno/subscriptions","organizations_url":"https://api.github.com/users/Dannnno/orgs","repos_url":"https://api.github.com/users/Dannnno/repos","events_url":"https://api.github.com/users/Dannnno/events{/privacy}","received_events_url":"https://api.github.com/users/Dannnno/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Dannnno/piconot-external","description":"External DSL implementation of piconot","fork":true,"url":"https://api.github.com/repos/Dannnno/piconot-external","forks_url":"https://api.github.com/repos/Dannnno/piconot-external/forks","keys_url":"https://api.github.com/repos/Dannnno/piconot-external/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dannnno/piconot-external/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dannnno/piconot-external/teams","hooks_url":"https://api.github.com/repos/Dannnno/piconot-external/hooks","issue_events_url":"https://api.github.com/repos/Dannnno/piconot-external/issues/events{/number}","events_url":"https://api.github.com/repos/Dannnno/piconot-external/events","assignees_url":"https://api.github.com/repos/Dannnno/piconot-external/assignees{/user}","branches_url":"https://api.github.com/repos/Dannnno/piconot-external/branches{/branch}","tags_url":"https://api.github.com/repos/Dannnno/piconot-external/tags","blobs_url":"https://api.github.com/repos/Dannnno/piconot-external/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dannnno/piconot-external/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dannnno/piconot-external/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dannnno/piconot-external/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dannnno/piconot-external/statuses/{sha}","languages_url":"https://api.github.com/repos/Dannnno/piconot-external/languages","stargazers_url":"https://api.github.com/repos/Dannnno/piconot-external/stargazers","contributors_url":"https://api.github.com/repos/Dannnno/piconot-external/contributors","subscribers_url":"https://api.github.com/repos/Dannnno/piconot-external/subscribers","subscription_url":"https://api.github.com/repos/Dannnno/piconot-external/subscription","commits_url":"https://api.github.com/repos/Dannnno/piconot-external/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dannnno/piconot-external/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dannnno/piconot-external/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dannnno/piconot-external/issues/comments{/number}","contents_url":"https://api.github.com/repos/Dannnno/piconot-external/contents/{+path}","compare_url":"https://api.github.com/repos/Dannnno/piconot-external/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dannnno/piconot-external/merges","archive_url":"https://api.github.com/repos/Dannnno/piconot-external/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dannnno/piconot-external/downloads","issues_url":"https://api.github.com/repos/Dannnno/piconot-external/issues{/number}","pulls_url":"https://api.github.com/repos/Dannnno/piconot-external/pulls{/number}","milestones_url":"https://api.github.com/repos/Dannnno/piconot-external/milestones{/number}","notifications_url":"https://api.github.com/repos/Dannnno/piconot-external/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dannnno/piconot-external/labels{/name}","releases_url":"https://api.github.com/repos/Dannnno/piconot-external/releases{/id}","created_at":"2015-10-11T18:09:15Z","updated_at":"2015-10-11T18:09:16Z","pushed_at":"2015-10-15T00:27:12Z","git_url":"git://github.com/Dannnno/piconot-external.git","ssh_url":"git@github.com:Dannnno/piconot-external.git","clone_url":"https://github.com/Dannnno/piconot-external.git","svn_url":"https://github.com/Dannnno/piconot-external","homepage":null,"size":217,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hmc-cs111-fall2015:master","ref":"master","sha":"7efb7d97af1b054364780c714c28f211113395aa","user":{"login":"hmc-cs111-fall2015","id":12563789,"avatar_url":"https://avatars.githubusercontent.com/u/12563789?v=3","gravatar_id":"","url":"https://api.github.com/users/hmc-cs111-fall2015","html_url":"https://github.com/hmc-cs111-fall2015","followers_url":"https://api.github.com/users/hmc-cs111-fall2015/followers","following_url":"https://api.github.com/users/hmc-cs111-fall2015/following{/other_user}","gists_url":"https://api.github.com/users/hmc-cs111-fall2015/gists{/gist_id}","starred_url":"https://api.github.com/users/hmc-cs111-fall2015/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmc-cs111-fall2015/subscriptions","organizations_url":"https://api.github.com/users/hmc-cs111-fall2015/orgs","repos_url":"https://api.github.com/users/hmc-cs111-fall2015/repos","events_url":"https://api.github.com/users/hmc-cs111-fall2015/events{/privacy}","received_events_url":"https://api.github.com/users/hmc-cs111-fall2015/received_events","type":"Organization","site_admin":false},"repo":{"id":43852354,"name":"piconot-external","full_name":"hmc-cs111-fall2015/piconot-external","owner":{"login":"hmc-cs111-fall2015","id":12563789,"avatar_url":"https://avatars.githubusercontent.com/u/12563789?v=3","gravatar_id":"","url":"https://api.github.com/users/hmc-cs111-fall2015","html_url":"https://github.com/hmc-cs111-fall2015","followers_url":"https://api.github.com/users/hmc-cs111-fall2015/followers","following_url":"https://api.github.com/users/hmc-cs111-fall2015/following{/other_user}","gists_url":"https://api.github.com/users/hmc-cs111-fall2015/gists{/gist_id}","starred_url":"https://api.github.com/users/hmc-cs111-fall2015/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmc-cs111-fall2015/subscriptions","organizations_url":"https://api.github.com/users/hmc-cs111-fall2015/orgs","repos_url":"https://api.github.com/users/hmc-cs111-fall2015/repos","events_url":"https://api.github.com/users/hmc-cs111-fall2015/events{/privacy}","received_events_url":"https://api.github.com/users/hmc-cs111-fall2015/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmc-cs111-fall2015/piconot-external","description":"External DSL implementation of piconot","fork":false,"url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external","forks_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/forks","keys_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/teams","hooks_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/hooks","issue_events_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/issues/events{/number}","events_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/events","assignees_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/assignees{/user}","branches_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/branches{/branch}","tags_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/tags","blobs_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/statuses/{sha}","languages_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/languages","stargazers_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/stargazers","contributors_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/contributors","subscribers_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/subscribers","subscription_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/subscription","commits_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/contents/{+path}","compare_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/merges","archive_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/downloads","issues_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/issues{/number}","pulls_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/pulls{/number}","milestones_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/milestones{/number}","notifications_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/labels{/name}","releases_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/releases{/id}","created_at":"2015-10-08T00:19:19Z","updated_at":"2015-10-08T00:34:09Z","pushed_at":"2015-10-15T06:59:26Z","git_url":"git://github.com/hmc-cs111-fall2015/piconot-external.git","ssh_url":"git@github.com:hmc-cs111-fall2015/piconot-external.git","clone_url":"https://github.com/hmc-cs111-fall2015/piconot-external.git","svn_url":"https://github.com/hmc-cs111-fall2015/piconot-external","homepage":null,"size":539,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":5,"forks":6,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/pulls/3"},"html":{"href":"https://github.com/hmc-cs111-fall2015/piconot-external/pull/3"},"issue":{"href":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/issues/3"},"comments":{"href":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/hmc-cs111-fall2015/piconot-external/statuses/4f4111222c79ab6a9efbeb1c20dcf4bd6fffbbfc"}}}}