{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/xhp-lib/issues/122","labels_url":"https://api.github.com/repos/facebook/xhp-lib/issues/122/labels{/name}","comments_url":"https://api.github.com/repos/facebook/xhp-lib/issues/122/comments","events_url":"https://api.github.com/repos/facebook/xhp-lib/issues/122/events","html_url":"https://github.com/facebook/xhp-lib/pull/122","id":60586271,"number":122,"title":"Add the XHPHelpers trait","user":{"login":"Swahvay","id":974639,"avatar_url":"https://avatars.githubusercontent.com/u/974639?v=3","gravatar_id":"","url":"https://api.github.com/users/Swahvay","html_url":"https://github.com/Swahvay","followers_url":"https://api.github.com/users/Swahvay/followers","following_url":"https://api.github.com/users/Swahvay/following{/other_user}","gists_url":"https://api.github.com/users/Swahvay/gists{/gist_id}","starred_url":"https://api.github.com/users/Swahvay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Swahvay/subscriptions","organizations_url":"https://api.github.com/users/Swahvay/orgs","repos_url":"https://api.github.com/users/Swahvay/repos","events_url":"https://api.github.com/users/Swahvay/events{/privacy}","received_events_url":"https://api.github.com/users/Swahvay/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-03-10T23:24:26Z","updated_at":"2015-03-11T19:52:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/xhp-lib/pulls/122","html_url":"https://github.com/facebook/xhp-lib/pull/122","diff_url":"https://github.com/facebook/xhp-lib/pull/122.diff","patch_url":"https://github.com/facebook/xhp-lib/pull/122.patch"},"body":"Adds some helper functions to use when dealing with HTML XHP elements. Namely, moved the ID/class helpers there, and added a bunch of transfer/copy methods."},"comment":{"url":"https://api.github.com/repos/facebook/xhp-lib/issues/comments/78357006","html_url":"https://github.com/facebook/xhp-lib/pull/122#issuecomment-78357006","issue_url":"https://api.github.com/repos/facebook/xhp-lib/issues/122","id":78357006,"user":{"login":"fredemmott","id":360927,"avatar_url":"https://avatars.githubusercontent.com/u/360927?v=3","gravatar_id":"","url":"https://api.github.com/users/fredemmott","html_url":"https://github.com/fredemmott","followers_url":"https://api.github.com/users/fredemmott/followers","following_url":"https://api.github.com/users/fredemmott/following{/other_user}","gists_url":"https://api.github.com/users/fredemmott/gists{/gist_id}","starred_url":"https://api.github.com/users/fredemmott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredemmott/subscriptions","organizations_url":"https://api.github.com/users/fredemmott/orgs","repos_url":"https://api.github.com/users/fredemmott/repos","events_url":"https://api.github.com/users/fredemmott/events{/privacy}","received_events_url":"https://api.github.com/users/fredemmott/received_events","type":"User","site_admin":false},"created_at":"2015-03-11T19:52:44Z","updated_at":"2015-03-11T19:52:44Z","body":"This doesn't pass the typechecker:\r\n\r\n```\r\nfred@hhvm-oss-bench:~/xhp-lib$ ~/hhvm/hphp/hack/bin/hh_client\r\n/home/fred/xhp-lib/src/html/XHPHelpers.php:133:28,52: Could not find method __xhpAttributeDeclaration in an object of type :xhp (Typing[4053])\r\n  /home/fred/xhp-lib/src/core/XHP.php:38:30,54: The closest thing is __xhpAttributeDeclaration but it's a static method\r\n  /home/fred/xhp-lib/src/html/XHPHelpers.php:123:5,8: This is why I think it is an object of type :xhp\r\n  /home/fred/xhp-lib/src/core/XHP.php:12:16,19: Declaration of :xhp is here\r\n/home/fred/xhp-lib/src/html/XHPHelpers.php:136:11,40: isset cannot be used in a completely type safe way and so is banned in strict mode (Typing[4016])\r\n/home/fred/xhp-lib/src/html/XHPHelpers.php:136:11,40: isset cannot be used in a completely type safe way and so is banned in strict mode (Typing[4016])\r\n/home/fred/xhp-lib/src/html/XHPHelpers.php:136:11,40: isset cannot be used in a completely type safe way and so is banned in strict mode (Typing[4016])\r\n/home/fred/xhp-lib/src/html/XHPHelpers.php:136:11,40: isset cannot be used in a completely type safe way and so is banned in strict mode (Typing[4016])\r\n/home/fred/xhp-lib/src/html/XHPHelpers.php:136:11,40: isset cannot be used in a completely type safe way and so is banned in strict mode (Typing[4016])\r\n/home/fred/xhp-lib/src/html/XHPHelpers.php:136:11,40: isset cannot be used in a completely type safe way and so is banned in strict mode (Typing[4016])\r\n/home/fred/xhp-lib/src/html/XHPHelpers.php:136:11,40: isset cannot be used in a completely type safe way and so is banned in strict mode (Typing[4016])\r\n/home/fred/xhp-lib/src/html/XHPHelpers.php:136:11,40: isset cannot be used in a completely type safe way and so is banned in strict mode (Typing[4016])\r\n/home/fred/xhp-lib/src/html/XHPHelpers.php:136:11,40: isset cannot be used in a completely type safe way and so is banned in strict mode (Typing[4016])\r\n/home/fred/xhp-lib/src/html/XHPHelpers.php:136:11,40: isset cannot be used in a completely type safe way and so is banned in strict mode (Typing[4016])\r\n/home/fred/xhp-lib/src/html/XHPHelpers.php:26:53,58: Could not find member :class in an object of type XHPHelpers (Typing[4053])\r\n  /home/fred/xhp-lib/src/html/XHPHelpers.php:26:46,50: This is why I think it is an object of type XHPHelpers\r\n  /home/fred/xhp-lib/src/html/XHPHelpers.php:18:7,16: Declaration of XHPHelpers is here\r\n/home/fred/xhp-lib/src/html/XHPHelpers.php:41:18,20: Could not find member :id in an object of type XHPHelpers (Typing[4053])\r\n  /home/fred/xhp-lib/src/html/XHPHelpers.php:41:11,15: This is why I think it is an object of type XHPHelpers\r\n  /home/fred/xhp-lib/src/html/XHPHelpers.php:18:7,16: Declaration of XHPHelpers is here\r\n```"}}