{"action":"created","comment":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/42794737","id":42794737,"diff_hunk":"@@ -73,7 +73,7 @@ public string GetCursor(World world, CPos xy, MouseInput mi)\n \t\t\telse\n \t\t\t{\n \t\t\t\tvar frozen = world.ScreenMap.FrozenActorsAt(world.RenderPlayer, mi)\n-\t\t\t\t\t.Where(a => a.Info.HasTraitInfo<ITargetableInfo>() && !a.Footprint.All(world.ShroudObscures))\n+\t\t\t\t\t.Where(a => a.Info.HasTraitInfo<ITargetableInfo>() && world.RenderPlayer.CanViewActor(a.Actor))","path":"OpenRA.Game/Orders/UnitOrderGenerator.cs","position":14,"original_position":14,"commit_id":"189acb19a9d361074c335c19bf805ebd7997669e","original_commit_id":"189acb19a9d361074c335c19bf805ebd7997669e","user":{"login":"obrakmann","id":4331210,"avatar_url":"https://avatars.githubusercontent.com/u/4331210?v=3","gravatar_id":"","url":"https://api.github.com/users/obrakmann","html_url":"https://github.com/obrakmann","followers_url":"https://api.github.com/users/obrakmann/followers","following_url":"https://api.github.com/users/obrakmann/following{/other_user}","gists_url":"https://api.github.com/users/obrakmann/gists{/gist_id}","starred_url":"https://api.github.com/users/obrakmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obrakmann/subscriptions","organizations_url":"https://api.github.com/users/obrakmann/orgs","repos_url":"https://api.github.com/users/obrakmann/repos","events_url":"https://api.github.com/users/obrakmann/events{/privacy}","received_events_url":"https://api.github.com/users/obrakmann/received_events","type":"User","site_admin":false},"body":"1. Needs a null check:\r\n```\r\nException of type `System.NullReferenceException`: Object reference not set to an instance of an object\r\n  at OpenRA.Player.CanViewActor (OpenRA.Actor a) [0x00003] in /home/oliver/devel/openra/git/OpenRA.Game/Player.cs:157 \r\n  at OpenRA.Orders.UnitOrderGenerator+<GetCursor>c__AnonStorey4.<>m__1 (OpenRA.Traits.FrozenActor a) [0x0001c] in /home/oliver/devel/openra/git/OpenRA.Game/Orders/UnitOrderGenerator.cs:76 \r\n```\r\n\r\n2. This prevents you from targeting frozen actors at all.","created_at":"2015-10-22T19:29:34Z","updated_at":"2015-10-22T19:29:34Z","html_url":"https://github.com/OpenRA/OpenRA/pull/9672#discussion_r42794737","pull_request_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9672","_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/42794737"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/9672#discussion_r42794737"},"pull_request":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9672"}}},"pull_request":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9672","id":48010780,"html_url":"https://github.com/OpenRA/OpenRA/pull/9672","diff_url":"https://github.com/OpenRA/OpenRA/pull/9672.diff","patch_url":"https://github.com/OpenRA/OpenRA/pull/9672.patch","issue_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/9672","number":9672,"state":"open","locked":false,"title":"Fix a series of visibility/targeting bugs","user":{"login":"penev92","id":7137365,"avatar_url":"https://avatars.githubusercontent.com/u/7137365?v=3","gravatar_id":"","url":"https://api.github.com/users/penev92","html_url":"https://github.com/penev92","followers_url":"https://api.github.com/users/penev92/followers","following_url":"https://api.github.com/users/penev92/following{/other_user}","gists_url":"https://api.github.com/users/penev92/gists{/gist_id}","starred_url":"https://api.github.com/users/penev92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/penev92/subscriptions","organizations_url":"https://api.github.com/users/penev92/orgs","repos_url":"https://api.github.com/users/penev92/repos","events_url":"https://api.github.com/users/penev92/events{/privacy}","received_events_url":"https://api.github.com/users/penev92/received_events","type":"User","site_admin":false},"body":"The commit messages say it all.\r\nFixes #9667 - spies were totally broken.\r\nFixes #9157 - basically nobody cared about invisibility on structures.\r\n\r\nP.S.: Also fixes #9351.","created_at":"2015-10-18T15:35:37Z","updated_at":"2015-10-22T19:29:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af52776bc8e04b6b8c814170246d13214ff574ad","assignee":null,"milestone":{"url":"https://api.github.com/repos/OpenRA/OpenRA/milestones/16","html_url":"https://github.com/OpenRA/OpenRA/milestones/Next%20release","labels_url":"https://api.github.com/repos/OpenRA/OpenRA/milestones/16/labels","id":1214438,"number":16,"title":"Next release","description":"","creator":{"login":"reaperrr","id":2857877,"avatar_url":"https://avatars.githubusercontent.com/u/2857877?v=3","gravatar_id":"","url":"https://api.github.com/users/reaperrr","html_url":"https://github.com/reaperrr","followers_url":"https://api.github.com/users/reaperrr/followers","following_url":"https://api.github.com/users/reaperrr/following{/other_user}","gists_url":"https://api.github.com/users/reaperrr/gists{/gist_id}","starred_url":"https://api.github.com/users/reaperrr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reaperrr/subscriptions","organizations_url":"https://api.github.com/users/reaperrr/orgs","repos_url":"https://api.github.com/users/reaperrr/repos","events_url":"https://api.github.com/users/reaperrr/events{/privacy}","received_events_url":"https://api.github.com/users/reaperrr/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":58,"state":"open","created_at":"2015-07-18T22:57:47Z","updated_at":"2015-10-22T17:56:57Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9672/commits","review_comments_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9672/comments","review_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/9672/comments","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/189acb19a9d361074c335c19bf805ebd7997669e","head":{"label":"penev92:fixAutoTarget","ref":"fixAutoTarget","sha":"189acb19a9d361074c335c19bf805ebd7997669e","user":{"login":"penev92","id":7137365,"avatar_url":"https://avatars.githubusercontent.com/u/7137365?v=3","gravatar_id":"","url":"https://api.github.com/users/penev92","html_url":"https://github.com/penev92","followers_url":"https://api.github.com/users/penev92/followers","following_url":"https://api.github.com/users/penev92/following{/other_user}","gists_url":"https://api.github.com/users/penev92/gists{/gist_id}","starred_url":"https://api.github.com/users/penev92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/penev92/subscriptions","organizations_url":"https://api.github.com/users/penev92/orgs","repos_url":"https://api.github.com/users/penev92/repos","events_url":"https://api.github.com/users/penev92/events{/privacy}","received_events_url":"https://api.github.com/users/penev92/received_events","type":"User","site_admin":false},"repo":{"id":24796059,"name":"OpenRA","full_name":"penev92/OpenRA","owner":{"login":"penev92","id":7137365,"avatar_url":"https://avatars.githubusercontent.com/u/7137365?v=3","gravatar_id":"","url":"https://api.github.com/users/penev92","html_url":"https://github.com/penev92","followers_url":"https://api.github.com/users/penev92/followers","following_url":"https://api.github.com/users/penev92/following{/other_user}","gists_url":"https://api.github.com/users/penev92/gists{/gist_id}","starred_url":"https://api.github.com/users/penev92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/penev92/subscriptions","organizations_url":"https://api.github.com/users/penev92/orgs","repos_url":"https://api.github.com/users/penev92/repos","events_url":"https://api.github.com/users/penev92/events{/privacy}","received_events_url":"https://api.github.com/users/penev92/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/penev92/OpenRA","description":"An open-source implementation of the Command & Conquer: Red Alert engine using .NET/Mono and OpenGL. Runs on Windows, Linux and Mac OS X.","fork":true,"url":"https://api.github.com/repos/penev92/OpenRA","forks_url":"https://api.github.com/repos/penev92/OpenRA/forks","keys_url":"https://api.github.com/repos/penev92/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/penev92/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/penev92/OpenRA/teams","hooks_url":"https://api.github.com/repos/penev92/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/penev92/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/penev92/OpenRA/events","assignees_url":"https://api.github.com/repos/penev92/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/penev92/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/penev92/OpenRA/tags","blobs_url":"https://api.github.com/repos/penev92/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/penev92/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/penev92/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/penev92/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/penev92/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/penev92/OpenRA/languages","stargazers_url":"https://api.github.com/repos/penev92/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/penev92/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/penev92/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/penev92/OpenRA/subscription","commits_url":"https://api.github.com/repos/penev92/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/penev92/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/penev92/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/penev92/OpenRA/issues/comments{/number}","contents_url":"https://api.github.com/repos/penev92/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/penev92/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/penev92/OpenRA/merges","archive_url":"https://api.github.com/repos/penev92/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/penev92/OpenRA/downloads","issues_url":"https://api.github.com/repos/penev92/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/penev92/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/penev92/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/penev92/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/penev92/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/penev92/OpenRA/releases{/id}","created_at":"2014-10-04T17:27:45Z","updated_at":"2014-10-05T20:15:38Z","pushed_at":"2015-10-22T11:30:02Z","git_url":"git://github.com/penev92/OpenRA.git","ssh_url":"git@github.com:penev92/OpenRA.git","clone_url":"https://github.com/penev92/OpenRA.git","svn_url":"https://github.com/penev92/OpenRA","homepage":"http://www.openra.net","size":100807,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"bleed"}},"base":{"label":"OpenRA:bleed","ref":"bleed","sha":"1e890a921fc30606525f542765ea3a66c0294cf3","user":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars.githubusercontent.com/u/409046?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"repo":{"id":959908,"name":"OpenRA","full_name":"OpenRA/OpenRA","owner":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars.githubusercontent.com/u/409046?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenRA/OpenRA","description":"Open Source real-time strategy game engine for early Westwood games such as Command & Conquer: Red Alert written in C# using SDL and OpenGL. Runs on Windows, Linux, *BSD and Mac OS X.","fork":false,"url":"https://api.github.com/repos/OpenRA/OpenRA","forks_url":"https://api.github.com/repos/OpenRA/OpenRA/forks","keys_url":"https://api.github.com/repos/OpenRA/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenRA/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenRA/OpenRA/teams","hooks_url":"https://api.github.com/repos/OpenRA/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/OpenRA/OpenRA/events","assignees_url":"https://api.github.com/repos/OpenRA/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/OpenRA/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/OpenRA/OpenRA/tags","blobs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenRA/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenRA/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenRA/OpenRA/languages","stargazers_url":"https://api.github.com/repos/OpenRA/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/OpenRA/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/OpenRA/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/OpenRA/OpenRA/subscription","commits_url":"https://api.github.com/repos/OpenRA/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenRA/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenRA/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/OpenRA/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenRA/OpenRA/merges","archive_url":"https://api.github.com/repos/OpenRA/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenRA/OpenRA/downloads","issues_url":"https://api.github.com/repos/OpenRA/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenRA/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenRA/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenRA/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/OpenRA/OpenRA/releases{/id}","created_at":"2010-10-04T07:38:05Z","updated_at":"2015-10-22T11:44:08Z","pushed_at":"2015-10-22T18:06:32Z","git_url":"git://github.com/OpenRA/OpenRA.git","ssh_url":"git@github.com:OpenRA/OpenRA.git","clone_url":"https://github.com/OpenRA/OpenRA.git","svn_url":"https://github.com/OpenRA/OpenRA","homepage":"http://www.openra.net","size":199937,"stargazers_count":2249,"watchers_count":2249,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":792,"mirror_url":null,"open_issues_count":965,"forks":792,"open_issues":965,"watchers":2249,"default_branch":"bleed"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9672"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/9672"},"issue":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/9672"},"comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/9672/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9672/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9672/commits"},"statuses":{"href":"https://api.github.com/repos/OpenRA/OpenRA/statuses/189acb19a9d361074c335c19bf805ebd7997669e"}}}}