{"action":"created","comment":{"url":"https://api.github.com/repos/staltz/todomvc-cycle/pulls/comments/32369528","id":32369528,"diff_hunk":"@@ -18,16 +18,19 @@ function vrenderHeader(todosData) {\n }\n \n function vrenderMainSection(todosData) {\n-  let allCompleted = todosData.list.reduce((x, y) => x && y.completed, true);\n+  let list = todosData.get('list');\n+  let allCompleted = list.every(x => x.get('completed'));\n+\n   return h('section#main', {\n-    style: {'display': todosData.list.length ? '' : 'none'}\n+    style: {'display': list.size ? '' : 'none'}\n   }, [\n     h('input#toggle-all', {\n       type: 'checkbox',\n       checked: allCompleted\n     }),\n-    h('ul#todo-list', todosData.list\n-      .filter(todosData.filterFn)\n+    h('ul#todo-list', list\n+      .filter(todosData.get('filterFn'))\n+      .toJS()","path":"src/views/todos.js","position":29,"original_position":29,"commit_id":"03f6fdd3379108f88f86360a2c49f4c62674b089","original_commit_id":"03f6fdd3379108f88f86360a2c49f4c62674b089","user":{"login":"jorin-vogel","id":738978,"avatar_url":"https://avatars.githubusercontent.com/u/738978?v=3","gravatar_id":"","url":"https://api.github.com/users/jorin-vogel","html_url":"https://github.com/jorin-vogel","followers_url":"https://api.github.com/users/jorin-vogel/followers","following_url":"https://api.github.com/users/jorin-vogel/following{/other_user}","gists_url":"https://api.github.com/users/jorin-vogel/gists{/gist_id}","starred_url":"https://api.github.com/users/jorin-vogel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorin-vogel/subscriptions","organizations_url":"https://api.github.com/users/jorin-vogel/orgs","repos_url":"https://api.github.com/users/jorin-vogel/repos","events_url":"https://api.github.com/users/jorin-vogel/events{/privacy}","received_events_url":"https://api.github.com/users/jorin-vogel/received_events","type":"User","site_admin":false},"body":"I don't know if it is better to case to JS before the map or after.\r\nDoesn't matter that much I guess. My thought was that it might be more performant this way.","created_at":"2015-06-13T10:32:23Z","updated_at":"2015-06-13T10:32:23Z","html_url":"https://github.com/staltz/todomvc-cycle/pull/9#discussion_r32369528","pull_request_url":"https://api.github.com/repos/staltz/todomvc-cycle/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/staltz/todomvc-cycle/pulls/comments/32369528"},"html":{"href":"https://github.com/staltz/todomvc-cycle/pull/9#discussion_r32369528"},"pull_request":{"href":"https://api.github.com/repos/staltz/todomvc-cycle/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/staltz/todomvc-cycle/pulls/9","id":37622807,"html_url":"https://github.com/staltz/todomvc-cycle/pull/9","diff_url":"https://github.com/staltz/todomvc-cycle/pull/9.diff","patch_url":"https://github.com/staltz/todomvc-cycle/pull/9.patch","issue_url":"https://api.github.com/repos/staltz/todomvc-cycle/issues/9","number":9,"state":"open","locked":false,"title":"Use immutable data structures","user":{"login":"jorin-vogel","id":738978,"avatar_url":"https://avatars.githubusercontent.com/u/738978?v=3","gravatar_id":"","url":"https://api.github.com/users/jorin-vogel","html_url":"https://github.com/jorin-vogel","followers_url":"https://api.github.com/users/jorin-vogel/followers","following_url":"https://api.github.com/users/jorin-vogel/following{/other_user}","gists_url":"https://api.github.com/users/jorin-vogel/gists{/gist_id}","starred_url":"https://api.github.com/users/jorin-vogel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorin-vogel/subscriptions","organizations_url":"https://api.github.com/users/jorin-vogel/orgs","repos_url":"https://api.github.com/users/jorin-vogel/repos","events_url":"https://api.github.com/users/jorin-vogel/events{/privacy}","received_events_url":"https://api.github.com/users/jorin-vogel/received_events","type":"User","site_admin":false},"body":"Thank you for sharing the concept of Cycle.js! \r\nThe architecture makes things really clear and simple. \r\nThis is my new favorite TodoMVC implementation :wink: \r\n\r\nI was playing around with immutable.js and saw the issue https://github.com/staltz/todomvc-cycle/issues/4 later. Thought I might send a pull request.\r\nFeel free to modify this, if I missed something. I'm pretty new to this technologies, so I probably don't use it all the right way yet..","created_at":"2015-06-13T10:19:12Z","updated_at":"2015-06-13T10:32:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef62308122d0ba3d73236809fbc81f7466e72a02","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/staltz/todomvc-cycle/pulls/9/commits","review_comments_url":"https://api.github.com/repos/staltz/todomvc-cycle/pulls/9/comments","review_comment_url":"https://api.github.com/repos/staltz/todomvc-cycle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/staltz/todomvc-cycle/issues/9/comments","statuses_url":"https://api.github.com/repos/staltz/todomvc-cycle/statuses/03f6fdd3379108f88f86360a2c49f4c62674b089","head":{"label":"jorin-vogel:immutable","ref":"immutable","sha":"03f6fdd3379108f88f86360a2c49f4c62674b089","user":{"login":"jorin-vogel","id":738978,"avatar_url":"https://avatars.githubusercontent.com/u/738978?v=3","gravatar_id":"","url":"https://api.github.com/users/jorin-vogel","html_url":"https://github.com/jorin-vogel","followers_url":"https://api.github.com/users/jorin-vogel/followers","following_url":"https://api.github.com/users/jorin-vogel/following{/other_user}","gists_url":"https://api.github.com/users/jorin-vogel/gists{/gist_id}","starred_url":"https://api.github.com/users/jorin-vogel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorin-vogel/subscriptions","organizations_url":"https://api.github.com/users/jorin-vogel/orgs","repos_url":"https://api.github.com/users/jorin-vogel/repos","events_url":"https://api.github.com/users/jorin-vogel/events{/privacy}","received_events_url":"https://api.github.com/users/jorin-vogel/received_events","type":"User","site_admin":false},"repo":{"id":37251768,"name":"todomvc-cycle","full_name":"jorin-vogel/todomvc-cycle","owner":{"login":"jorin-vogel","id":738978,"avatar_url":"https://avatars.githubusercontent.com/u/738978?v=3","gravatar_id":"","url":"https://api.github.com/users/jorin-vogel","html_url":"https://github.com/jorin-vogel","followers_url":"https://api.github.com/users/jorin-vogel/followers","following_url":"https://api.github.com/users/jorin-vogel/following{/other_user}","gists_url":"https://api.github.com/users/jorin-vogel/gists{/gist_id}","starred_url":"https://api.github.com/users/jorin-vogel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorin-vogel/subscriptions","organizations_url":"https://api.github.com/users/jorin-vogel/orgs","repos_url":"https://api.github.com/users/jorin-vogel/repos","events_url":"https://api.github.com/users/jorin-vogel/events{/privacy}","received_events_url":"https://api.github.com/users/jorin-vogel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jorin-vogel/todomvc-cycle","description":"TodoMVC example implemented in Cycle.js","fork":true,"url":"https://api.github.com/repos/jorin-vogel/todomvc-cycle","forks_url":"https://api.github.com/repos/jorin-vogel/todomvc-cycle/forks","keys_url":"https://api.github.com/repos/jorin-vogel/todomvc-cycle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jorin-vogel/todomvc-cycle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jorin-vogel/todomvc-cycle/teams","hooks_url":"https://api.github.com/repos/jorin-vogel/todomvc-cycle/hooks","issue_events_url":"https://api.github.com/repos/jorin-vogel/todomvc-cycle/issues/events{/number}","events_url":"https://api.github.com/repos/jorin-vogel/todomvc-cycle/events","assignees_url":"https://api.github.com/repos/jorin-vogel/todomvc-cycle/assignees{/user}","branches_url":"https://api.github.com/repos/jorin-vogel/todomvc-cycle/branches{/branch}","tags_url":"https://api.github.com/repos/jorin-vogel/todomvc-cycle/tags","blobs_url":"https://api.github.com/repos/jorin-vogel/todomvc-cycle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jorin-vogel/todomvc-cycle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jorin-vogel/todomvc-cycle/git/refs{/sha}","trees_url":"https://api.github.com/repos/jorin-vogel/todomvc-cycle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jorin-vogel/todomvc-cycle/statuses/{sha}","languages_url":"https://api.github.com/repos/jorin-vogel/todomvc-cycle/languages","stargazers_url":"https://api.github.com/repos/jorin-vogel/todomvc-cycle/stargazers","contributors_url":"https://api.github.com/repos/jorin-vogel/todomvc-cycle/contributors","subscribers_url":"https://api.github.com/repos/jorin-vogel/todomvc-cycle/subscribers","subscription_url":"https://api.github.com/repos/jorin-vogel/todomvc-cycle/subscription","commits_url":"https://api.github.com/repos/jorin-vogel/todomvc-cycle/commits{/sha}","git_commits_url":"https://api.github.com/repos/jorin-vogel/todomvc-cycle/git/commits{/sha}","comments_url":"https://api.github.com/repos/jorin-vogel/todomvc-cycle/comments{/number}","issue_comment_url":"https://api.github.com/repos/jorin-vogel/todomvc-cycle/issues/comments{/number}","contents_url":"https://api.github.com/repos/jorin-vogel/todomvc-cycle/contents/{+path}","compare_url":"https://api.github.com/repos/jorin-vogel/todomvc-cycle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jorin-vogel/todomvc-cycle/merges","archive_url":"https://api.github.com/repos/jorin-vogel/todomvc-cycle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jorin-vogel/todomvc-cycle/downloads","issues_url":"https://api.github.com/repos/jorin-vogel/todomvc-cycle/issues{/number}","pulls_url":"https://api.github.com/repos/jorin-vogel/todomvc-cycle/pulls{/number}","milestones_url":"https://api.github.com/repos/jorin-vogel/todomvc-cycle/milestones{/number}","notifications_url":"https://api.github.com/repos/jorin-vogel/todomvc-cycle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jorin-vogel/todomvc-cycle/labels{/name}","releases_url":"https://api.github.com/repos/jorin-vogel/todomvc-cycle/releases{/id}","created_at":"2015-06-11T09:26:36Z","updated_at":"2015-06-11T09:26:36Z","pushed_at":"2015-06-13T10:04:32Z","git_url":"git://github.com/jorin-vogel/todomvc-cycle.git","ssh_url":"git@github.com:jorin-vogel/todomvc-cycle.git","clone_url":"https://github.com/jorin-vogel/todomvc-cycle.git","svn_url":"https://github.com/jorin-vogel/todomvc-cycle","homepage":"http://staltz.com/todomvc-cycle","size":2076,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"staltz:master","ref":"master","sha":"f6681abcfda9a5774b2df48602d9f3a0af599a24","user":{"login":"staltz","id":90512,"avatar_url":"https://avatars.githubusercontent.com/u/90512?v=3","gravatar_id":"","url":"https://api.github.com/users/staltz","html_url":"https://github.com/staltz","followers_url":"https://api.github.com/users/staltz/followers","following_url":"https://api.github.com/users/staltz/following{/other_user}","gists_url":"https://api.github.com/users/staltz/gists{/gist_id}","starred_url":"https://api.github.com/users/staltz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staltz/subscriptions","organizations_url":"https://api.github.com/users/staltz/orgs","repos_url":"https://api.github.com/users/staltz/repos","events_url":"https://api.github.com/users/staltz/events{/privacy}","received_events_url":"https://api.github.com/users/staltz/received_events","type":"User","site_admin":false},"repo":{"id":26407151,"name":"todomvc-cycle","full_name":"staltz/todomvc-cycle","owner":{"login":"staltz","id":90512,"avatar_url":"https://avatars.githubusercontent.com/u/90512?v=3","gravatar_id":"","url":"https://api.github.com/users/staltz","html_url":"https://github.com/staltz","followers_url":"https://api.github.com/users/staltz/followers","following_url":"https://api.github.com/users/staltz/following{/other_user}","gists_url":"https://api.github.com/users/staltz/gists{/gist_id}","starred_url":"https://api.github.com/users/staltz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staltz/subscriptions","organizations_url":"https://api.github.com/users/staltz/orgs","repos_url":"https://api.github.com/users/staltz/repos","events_url":"https://api.github.com/users/staltz/events{/privacy}","received_events_url":"https://api.github.com/users/staltz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/staltz/todomvc-cycle","description":"TodoMVC example implemented in Cycle.js","fork":false,"url":"https://api.github.com/repos/staltz/todomvc-cycle","forks_url":"https://api.github.com/repos/staltz/todomvc-cycle/forks","keys_url":"https://api.github.com/repos/staltz/todomvc-cycle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/staltz/todomvc-cycle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/staltz/todomvc-cycle/teams","hooks_url":"https://api.github.com/repos/staltz/todomvc-cycle/hooks","issue_events_url":"https://api.github.com/repos/staltz/todomvc-cycle/issues/events{/number}","events_url":"https://api.github.com/repos/staltz/todomvc-cycle/events","assignees_url":"https://api.github.com/repos/staltz/todomvc-cycle/assignees{/user}","branches_url":"https://api.github.com/repos/staltz/todomvc-cycle/branches{/branch}","tags_url":"https://api.github.com/repos/staltz/todomvc-cycle/tags","blobs_url":"https://api.github.com/repos/staltz/todomvc-cycle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/staltz/todomvc-cycle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/staltz/todomvc-cycle/git/refs{/sha}","trees_url":"https://api.github.com/repos/staltz/todomvc-cycle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/staltz/todomvc-cycle/statuses/{sha}","languages_url":"https://api.github.com/repos/staltz/todomvc-cycle/languages","stargazers_url":"https://api.github.com/repos/staltz/todomvc-cycle/stargazers","contributors_url":"https://api.github.com/repos/staltz/todomvc-cycle/contributors","subscribers_url":"https://api.github.com/repos/staltz/todomvc-cycle/subscribers","subscription_url":"https://api.github.com/repos/staltz/todomvc-cycle/subscription","commits_url":"https://api.github.com/repos/staltz/todomvc-cycle/commits{/sha}","git_commits_url":"https://api.github.com/repos/staltz/todomvc-cycle/git/commits{/sha}","comments_url":"https://api.github.com/repos/staltz/todomvc-cycle/comments{/number}","issue_comment_url":"https://api.github.com/repos/staltz/todomvc-cycle/issues/comments{/number}","contents_url":"https://api.github.com/repos/staltz/todomvc-cycle/contents/{+path}","compare_url":"https://api.github.com/repos/staltz/todomvc-cycle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/staltz/todomvc-cycle/merges","archive_url":"https://api.github.com/repos/staltz/todomvc-cycle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/staltz/todomvc-cycle/downloads","issues_url":"https://api.github.com/repos/staltz/todomvc-cycle/issues{/number}","pulls_url":"https://api.github.com/repos/staltz/todomvc-cycle/pulls{/number}","milestones_url":"https://api.github.com/repos/staltz/todomvc-cycle/milestones{/number}","notifications_url":"https://api.github.com/repos/staltz/todomvc-cycle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/staltz/todomvc-cycle/labels{/name}","releases_url":"https://api.github.com/repos/staltz/todomvc-cycle/releases{/id}","created_at":"2014-11-09T19:55:18Z","updated_at":"2015-06-08T14:46:00Z","pushed_at":"2015-06-13T10:19:12Z","git_url":"git://github.com/staltz/todomvc-cycle.git","ssh_url":"git@github.com:staltz/todomvc-cycle.git","clone_url":"https://github.com/staltz/todomvc-cycle.git","svn_url":"https://github.com/staltz/todomvc-cycle","homepage":"http://staltz.com/todomvc-cycle","size":2076,"stargazers_count":46,"watchers_count":46,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"open_issues_count":2,"forks":10,"open_issues":2,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/staltz/todomvc-cycle/pulls/9"},"html":{"href":"https://github.com/staltz/todomvc-cycle/pull/9"},"issue":{"href":"https://api.github.com/repos/staltz/todomvc-cycle/issues/9"},"comments":{"href":"https://api.github.com/repos/staltz/todomvc-cycle/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/staltz/todomvc-cycle/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/staltz/todomvc-cycle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/staltz/todomvc-cycle/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/staltz/todomvc-cycle/statuses/03f6fdd3379108f88f86360a2c49f4c62674b089"}}}}