{"action":"created","comment":{"url":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/comments/42944538","id":42944538,"diff_hunk":"@@ -804,11 +805,14 @@ def create_parser(plugins, args):\n     helpful.add(\n         \"security\", \"-B\", \"--rsa-key-size\", type=int, metavar=\"N\",\n         default=flag_default(\"rsa_key_size\"), help=config_help(\"rsa_key_size\"))\n-    # TODO: resolve - assumes binary logic while client.py assumes ternary.\n     helpful.add(\n         \"security\", \"-r\", \"--redirect\", action=\"store_true\",\n         help=\"Automatically redirect all HTTP traffic to HTTPS for the newly \"\n-             \"authenticated vhost.\")\n+             \"authenticated vhost.\", dest=\"redirect\", default=None)\n+    helpful.add(\n+        \"security\", \"-n\", \"--no-redirect\", action=\"store_false\",","path":"letsencrypt/cli.py","position":19,"original_position":19,"commit_id":"b13006ce1af7b2d1f2c44d851de8d17698643c77","original_commit_id":"b13006ce1af7b2d1f2c44d851de8d17698643c77","user":{"login":"kuba","id":106176,"avatar_url":"https://avatars.githubusercontent.com/u/106176?v=3","gravatar_id":"","url":"https://api.github.com/users/kuba","html_url":"https://github.com/kuba","followers_url":"https://api.github.com/users/kuba/followers","following_url":"https://api.github.com/users/kuba/following{/other_user}","gists_url":"https://api.github.com/users/kuba/gists{/gist_id}","starred_url":"https://api.github.com/users/kuba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuba/subscriptions","organizations_url":"https://api.github.com/users/kuba/orgs","repos_url":"https://api.github.com/users/kuba/repos","events_url":"https://api.github.com/users/kuba/events{/privacy}","received_events_url":"https://api.github.com/users/kuba/received_events","type":"User","site_admin":false},"body":"I really think that \"-n\" is bad name to use here.","created_at":"2015-10-25T13:01:23Z","updated_at":"2015-10-25T13:01:23Z","html_url":"https://github.com/letsencrypt/letsencrypt/pull/1119#discussion_r42944538","pull_request_url":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/1119","_links":{"self":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/comments/42944538"},"html":{"href":"https://github.com/letsencrypt/letsencrypt/pull/1119#discussion_r42944538"},"pull_request":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/1119"}}},"pull_request":{"url":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/1119","id":48663060,"html_url":"https://github.com/letsencrypt/letsencrypt/pull/1119","diff_url":"https://github.com/letsencrypt/letsencrypt/pull/1119.diff","patch_url":"https://github.com/letsencrypt/letsencrypt/pull/1119.patch","issue_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/1119","number":1119,"state":"closed","locked":false,"title":"Fix for issue #1030","user":{"login":"xamnesiax-sx","id":10144532,"avatar_url":"https://avatars.githubusercontent.com/u/10144532?v=3","gravatar_id":"","url":"https://api.github.com/users/xamnesiax-sx","html_url":"https://github.com/xamnesiax-sx","followers_url":"https://api.github.com/users/xamnesiax-sx/followers","following_url":"https://api.github.com/users/xamnesiax-sx/following{/other_user}","gists_url":"https://api.github.com/users/xamnesiax-sx/gists{/gist_id}","starred_url":"https://api.github.com/users/xamnesiax-sx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamnesiax-sx/subscriptions","organizations_url":"https://api.github.com/users/xamnesiax-sx/orgs","repos_url":"https://api.github.com/users/xamnesiax-sx/repos","events_url":"https://api.github.com/users/xamnesiax-sx/events{/privacy}","received_events_url":"https://api.github.com/users/xamnesiax-sx/received_events","type":"User","site_admin":false},"body":"Fixes the argparse flag issue in which the '-r, --redirect' flag was set as a binary value, yet was assumed to be ternary in client.py.","created_at":"2015-10-24T19:19:36Z","updated_at":"2015-10-25T13:01:23Z","closed_at":"2015-10-24T23:23:08Z","merged_at":"2015-10-24T23:23:08Z","merge_commit_sha":"2c7c9f24031323f309b500eac85858c327bd6e9f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/1119/commits","review_comments_url":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/1119/comments","review_comment_url":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/1119/comments","statuses_url":"https://api.github.com/repos/letsencrypt/letsencrypt/statuses/b13006ce1af7b2d1f2c44d851de8d17698643c77","head":{"label":"xamnesiax-sx:xamnesiax-dev","ref":"xamnesiax-dev","sha":"b13006ce1af7b2d1f2c44d851de8d17698643c77","user":{"login":"xamnesiax-sx","id":10144532,"avatar_url":"https://avatars.githubusercontent.com/u/10144532?v=3","gravatar_id":"","url":"https://api.github.com/users/xamnesiax-sx","html_url":"https://github.com/xamnesiax-sx","followers_url":"https://api.github.com/users/xamnesiax-sx/followers","following_url":"https://api.github.com/users/xamnesiax-sx/following{/other_user}","gists_url":"https://api.github.com/users/xamnesiax-sx/gists{/gist_id}","starred_url":"https://api.github.com/users/xamnesiax-sx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamnesiax-sx/subscriptions","organizations_url":"https://api.github.com/users/xamnesiax-sx/orgs","repos_url":"https://api.github.com/users/xamnesiax-sx/repos","events_url":"https://api.github.com/users/xamnesiax-sx/events{/privacy}","received_events_url":"https://api.github.com/users/xamnesiax-sx/received_events","type":"User","site_admin":false},"repo":{"id":44869022,"name":"letsencrypt","full_name":"xamnesiax-sx/letsencrypt","owner":{"login":"xamnesiax-sx","id":10144532,"avatar_url":"https://avatars.githubusercontent.com/u/10144532?v=3","gravatar_id":"","url":"https://api.github.com/users/xamnesiax-sx","html_url":"https://github.com/xamnesiax-sx","followers_url":"https://api.github.com/users/xamnesiax-sx/followers","following_url":"https://api.github.com/users/xamnesiax-sx/following{/other_user}","gists_url":"https://api.github.com/users/xamnesiax-sx/gists{/gist_id}","starred_url":"https://api.github.com/users/xamnesiax-sx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamnesiax-sx/subscriptions","organizations_url":"https://api.github.com/users/xamnesiax-sx/orgs","repos_url":"https://api.github.com/users/xamnesiax-sx/repos","events_url":"https://api.github.com/users/xamnesiax-sx/events{/privacy}","received_events_url":"https://api.github.com/users/xamnesiax-sx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xamnesiax-sx/letsencrypt","description":"An ACME client that can obtain certs and extensibly update server configurations (currently supports Apache on .deb based systems, nginx support coming soon)","fork":true,"url":"https://api.github.com/repos/xamnesiax-sx/letsencrypt","forks_url":"https://api.github.com/repos/xamnesiax-sx/letsencrypt/forks","keys_url":"https://api.github.com/repos/xamnesiax-sx/letsencrypt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xamnesiax-sx/letsencrypt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xamnesiax-sx/letsencrypt/teams","hooks_url":"https://api.github.com/repos/xamnesiax-sx/letsencrypt/hooks","issue_events_url":"https://api.github.com/repos/xamnesiax-sx/letsencrypt/issues/events{/number}","events_url":"https://api.github.com/repos/xamnesiax-sx/letsencrypt/events","assignees_url":"https://api.github.com/repos/xamnesiax-sx/letsencrypt/assignees{/user}","branches_url":"https://api.github.com/repos/xamnesiax-sx/letsencrypt/branches{/branch}","tags_url":"https://api.github.com/repos/xamnesiax-sx/letsencrypt/tags","blobs_url":"https://api.github.com/repos/xamnesiax-sx/letsencrypt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xamnesiax-sx/letsencrypt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xamnesiax-sx/letsencrypt/git/refs{/sha}","trees_url":"https://api.github.com/repos/xamnesiax-sx/letsencrypt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xamnesiax-sx/letsencrypt/statuses/{sha}","languages_url":"https://api.github.com/repos/xamnesiax-sx/letsencrypt/languages","stargazers_url":"https://api.github.com/repos/xamnesiax-sx/letsencrypt/stargazers","contributors_url":"https://api.github.com/repos/xamnesiax-sx/letsencrypt/contributors","subscribers_url":"https://api.github.com/repos/xamnesiax-sx/letsencrypt/subscribers","subscription_url":"https://api.github.com/repos/xamnesiax-sx/letsencrypt/subscription","commits_url":"https://api.github.com/repos/xamnesiax-sx/letsencrypt/commits{/sha}","git_commits_url":"https://api.github.com/repos/xamnesiax-sx/letsencrypt/git/commits{/sha}","comments_url":"https://api.github.com/repos/xamnesiax-sx/letsencrypt/comments{/number}","issue_comment_url":"https://api.github.com/repos/xamnesiax-sx/letsencrypt/issues/comments{/number}","contents_url":"https://api.github.com/repos/xamnesiax-sx/letsencrypt/contents/{+path}","compare_url":"https://api.github.com/repos/xamnesiax-sx/letsencrypt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xamnesiax-sx/letsencrypt/merges","archive_url":"https://api.github.com/repos/xamnesiax-sx/letsencrypt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xamnesiax-sx/letsencrypt/downloads","issues_url":"https://api.github.com/repos/xamnesiax-sx/letsencrypt/issues{/number}","pulls_url":"https://api.github.com/repos/xamnesiax-sx/letsencrypt/pulls{/number}","milestones_url":"https://api.github.com/repos/xamnesiax-sx/letsencrypt/milestones{/number}","notifications_url":"https://api.github.com/repos/xamnesiax-sx/letsencrypt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xamnesiax-sx/letsencrypt/labels{/name}","releases_url":"https://api.github.com/repos/xamnesiax-sx/letsencrypt/releases{/id}","created_at":"2015-10-24T14:09:09Z","updated_at":"2015-10-24T14:09:11Z","pushed_at":"2015-10-24T23:15:19Z","git_url":"git://github.com/xamnesiax-sx/letsencrypt.git","ssh_url":"git@github.com:xamnesiax-sx/letsencrypt.git","clone_url":"https://github.com/xamnesiax-sx/letsencrypt.git","svn_url":"https://github.com/xamnesiax-sx/letsencrypt","homepage":"","size":5912,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"letsencrypt:master","ref":"master","sha":"875413492a0b65d16c165ec7fe014e35836b7c16","user":{"login":"letsencrypt","id":9289019,"avatar_url":"https://avatars.githubusercontent.com/u/9289019?v=3","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"repo":{"id":26516210,"name":"letsencrypt","full_name":"letsencrypt/letsencrypt","owner":{"login":"letsencrypt","id":9289019,"avatar_url":"https://avatars.githubusercontent.com/u/9289019?v=3","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/letsencrypt/letsencrypt","description":"An ACME client that can obtain certs and extensibly update server configurations (currently supports Apache on .deb based systems, nginx support coming soon)","fork":false,"url":"https://api.github.com/repos/letsencrypt/letsencrypt","forks_url":"https://api.github.com/repos/letsencrypt/letsencrypt/forks","keys_url":"https://api.github.com/repos/letsencrypt/letsencrypt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/letsencrypt/letsencrypt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/letsencrypt/letsencrypt/teams","hooks_url":"https://api.github.com/repos/letsencrypt/letsencrypt/hooks","issue_events_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/events{/number}","events_url":"https://api.github.com/repos/letsencrypt/letsencrypt/events","assignees_url":"https://api.github.com/repos/letsencrypt/letsencrypt/assignees{/user}","branches_url":"https://api.github.com/repos/letsencrypt/letsencrypt/branches{/branch}","tags_url":"https://api.github.com/repos/letsencrypt/letsencrypt/tags","blobs_url":"https://api.github.com/repos/letsencrypt/letsencrypt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/letsencrypt/letsencrypt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/letsencrypt/letsencrypt/git/refs{/sha}","trees_url":"https://api.github.com/repos/letsencrypt/letsencrypt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/letsencrypt/letsencrypt/statuses/{sha}","languages_url":"https://api.github.com/repos/letsencrypt/letsencrypt/languages","stargazers_url":"https://api.github.com/repos/letsencrypt/letsencrypt/stargazers","contributors_url":"https://api.github.com/repos/letsencrypt/letsencrypt/contributors","subscribers_url":"https://api.github.com/repos/letsencrypt/letsencrypt/subscribers","subscription_url":"https://api.github.com/repos/letsencrypt/letsencrypt/subscription","commits_url":"https://api.github.com/repos/letsencrypt/letsencrypt/commits{/sha}","git_commits_url":"https://api.github.com/repos/letsencrypt/letsencrypt/git/commits{/sha}","comments_url":"https://api.github.com/repos/letsencrypt/letsencrypt/comments{/number}","issue_comment_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/comments{/number}","contents_url":"https://api.github.com/repos/letsencrypt/letsencrypt/contents/{+path}","compare_url":"https://api.github.com/repos/letsencrypt/letsencrypt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/letsencrypt/letsencrypt/merges","archive_url":"https://api.github.com/repos/letsencrypt/letsencrypt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/letsencrypt/letsencrypt/downloads","issues_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues{/number}","pulls_url":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls{/number}","milestones_url":"https://api.github.com/repos/letsencrypt/letsencrypt/milestones{/number}","notifications_url":"https://api.github.com/repos/letsencrypt/letsencrypt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/letsencrypt/letsencrypt/labels{/name}","releases_url":"https://api.github.com/repos/letsencrypt/letsencrypt/releases{/id}","created_at":"2014-11-12T02:52:20Z","updated_at":"2015-10-25T12:34:34Z","pushed_at":"2015-10-25T12:35:36Z","git_url":"git://github.com/letsencrypt/letsencrypt.git","ssh_url":"git@github.com:letsencrypt/letsencrypt.git","clone_url":"https://github.com/letsencrypt/letsencrypt.git","svn_url":"https://github.com/letsencrypt/letsencrypt","homepage":"","size":17410,"stargazers_count":5308,"watchers_count":5308,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":349,"mirror_url":null,"open_issues_count":193,"forks":349,"open_issues":193,"watchers":5308,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/1119"},"html":{"href":"https://github.com/letsencrypt/letsencrypt/pull/1119"},"issue":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/1119"},"comments":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/1119/comments"},"review_comments":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/1119/comments"},"review_comment":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/1119/commits"},"statuses":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/statuses/b13006ce1af7b2d1f2c44d851de8d17698643c77"}}}}