{"action":"created","comment":{"url":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/comments/22439039","id":22439039,"diff_hunk":"@@ -24,11 +24,11 @@\n       end\n \n       it \"should have issue opened event\" do\n-        body.should have_content(\"#{user.name} opened issue ##{issue.iid}\")\n+        body.should have_content(\"#{html_escape(user.name)} opened issue ##{issue.iid}\")","path":"spec/features/atom/users_spec.rb","position":5,"original_position":5,"commit_id":"275d557d8dac828f3e88d8f418b6b05a1f42a29d","original_commit_id":"275d557d8dac828f3e88d8f418b6b05a1f42a29d","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Line is too long. [88/80]","created_at":"2015-01-04T13:05:04Z","updated_at":"2015-01-04T13:05:04Z","html_url":"https://github.com/gitlabhq/gitlabhq/pull/8534#discussion_r22439039","pull_request_url":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/8534","_links":{"self":{"href":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/comments/22439039"},"html":{"href":"https://github.com/gitlabhq/gitlabhq/pull/8534#discussion_r22439039"},"pull_request":{"href":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/8534"}}},"pull_request":{"url":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/8534","id":26794941,"html_url":"https://github.com/gitlabhq/gitlabhq/pull/8534","diff_url":"https://github.com/gitlabhq/gitlabhq/pull/8534.diff","patch_url":"https://github.com/gitlabhq/gitlabhq/pull/8534.patch","issue_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/8534","number":8534,"state":"open","locked":false,"title":"make sure the user.name is escaped","user":{"login":"jvanbaarsen","id":1362793,"avatar_url":"https://avatars.githubusercontent.com/u/1362793?v=3","gravatar_id":"","url":"https://api.github.com/users/jvanbaarsen","html_url":"https://github.com/jvanbaarsen","followers_url":"https://api.github.com/users/jvanbaarsen/followers","following_url":"https://api.github.com/users/jvanbaarsen/following{/other_user}","gists_url":"https://api.github.com/users/jvanbaarsen/gists{/gist_id}","starred_url":"https://api.github.com/users/jvanbaarsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvanbaarsen/subscriptions","organizations_url":"https://api.github.com/users/jvanbaarsen/orgs","repos_url":"https://api.github.com/users/jvanbaarsen/repos","events_url":"https://api.github.com/users/jvanbaarsen/events{/privacy}","received_events_url":"https://api.github.com/users/jvanbaarsen/received_events","type":"User","site_admin":false},"body":"**Why is this PR needed?**\r\nAt the current state the tests are not passing if the `user.name` contains an `'` (i.e.: Mister O'Donnelly). This patch fixes the issue by putting `html_escape` around the asserted values.\r\n\r\n**Related issues/PR's`\r\nIssue was found in https://github.com/gitlabhq/gitlabhq/pull/7928","created_at":"2015-01-04T13:04:59Z","updated_at":"2015-01-04T13:05:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0134eb141f545f391c6bdf04cf41cf42927bdb85","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/8534/commits","review_comments_url":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/8534/comments","review_comment_url":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/comments/{number}","comments_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/8534/comments","statuses_url":"https://api.github.com/repos/gitlabhq/gitlabhq/statuses/275d557d8dac828f3e88d8f418b6b05a1f42a29d","head":{"label":"jvanbaarsen:fix-wonky-tests","ref":"fix-wonky-tests","sha":"275d557d8dac828f3e88d8f418b6b05a1f42a29d","user":{"login":"jvanbaarsen","id":1362793,"avatar_url":"https://avatars.githubusercontent.com/u/1362793?v=3","gravatar_id":"","url":"https://api.github.com/users/jvanbaarsen","html_url":"https://github.com/jvanbaarsen","followers_url":"https://api.github.com/users/jvanbaarsen/followers","following_url":"https://api.github.com/users/jvanbaarsen/following{/other_user}","gists_url":"https://api.github.com/users/jvanbaarsen/gists{/gist_id}","starred_url":"https://api.github.com/users/jvanbaarsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvanbaarsen/subscriptions","organizations_url":"https://api.github.com/users/jvanbaarsen/orgs","repos_url":"https://api.github.com/users/jvanbaarsen/repos","events_url":"https://api.github.com/users/jvanbaarsen/events{/privacy}","received_events_url":"https://api.github.com/users/jvanbaarsen/received_events","type":"User","site_admin":false},"repo":{"id":11545535,"name":"gitlabhq","full_name":"jvanbaarsen/gitlabhq","owner":{"login":"jvanbaarsen","id":1362793,"avatar_url":"https://avatars.githubusercontent.com/u/1362793?v=3","gravatar_id":"","url":"https://api.github.com/users/jvanbaarsen","html_url":"https://github.com/jvanbaarsen","followers_url":"https://api.github.com/users/jvanbaarsen/followers","following_url":"https://api.github.com/users/jvanbaarsen/following{/other_user}","gists_url":"https://api.github.com/users/jvanbaarsen/gists{/gist_id}","starred_url":"https://api.github.com/users/jvanbaarsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvanbaarsen/subscriptions","organizations_url":"https://api.github.com/users/jvanbaarsen/orgs","repos_url":"https://api.github.com/users/jvanbaarsen/repos","events_url":"https://api.github.com/users/jvanbaarsen/events{/privacy}","received_events_url":"https://api.github.com/users/jvanbaarsen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jvanbaarsen/gitlabhq","description":"Project management and code hosting  application. Follow us on twitter @gitlabhq","fork":true,"url":"https://api.github.com/repos/jvanbaarsen/gitlabhq","forks_url":"https://api.github.com/repos/jvanbaarsen/gitlabhq/forks","keys_url":"https://api.github.com/repos/jvanbaarsen/gitlabhq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jvanbaarsen/gitlabhq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jvanbaarsen/gitlabhq/teams","hooks_url":"https://api.github.com/repos/jvanbaarsen/gitlabhq/hooks","issue_events_url":"https://api.github.com/repos/jvanbaarsen/gitlabhq/issues/events{/number}","events_url":"https://api.github.com/repos/jvanbaarsen/gitlabhq/events","assignees_url":"https://api.github.com/repos/jvanbaarsen/gitlabhq/assignees{/user}","branches_url":"https://api.github.com/repos/jvanbaarsen/gitlabhq/branches{/branch}","tags_url":"https://api.github.com/repos/jvanbaarsen/gitlabhq/tags","blobs_url":"https://api.github.com/repos/jvanbaarsen/gitlabhq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jvanbaarsen/gitlabhq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jvanbaarsen/gitlabhq/git/refs{/sha}","trees_url":"https://api.github.com/repos/jvanbaarsen/gitlabhq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jvanbaarsen/gitlabhq/statuses/{sha}","languages_url":"https://api.github.com/repos/jvanbaarsen/gitlabhq/languages","stargazers_url":"https://api.github.com/repos/jvanbaarsen/gitlabhq/stargazers","contributors_url":"https://api.github.com/repos/jvanbaarsen/gitlabhq/contributors","subscribers_url":"https://api.github.com/repos/jvanbaarsen/gitlabhq/subscribers","subscription_url":"https://api.github.com/repos/jvanbaarsen/gitlabhq/subscription","commits_url":"https://api.github.com/repos/jvanbaarsen/gitlabhq/commits{/sha}","git_commits_url":"https://api.github.com/repos/jvanbaarsen/gitlabhq/git/commits{/sha}","comments_url":"https://api.github.com/repos/jvanbaarsen/gitlabhq/comments{/number}","issue_comment_url":"https://api.github.com/repos/jvanbaarsen/gitlabhq/issues/comments/{number}","contents_url":"https://api.github.com/repos/jvanbaarsen/gitlabhq/contents/{+path}","compare_url":"https://api.github.com/repos/jvanbaarsen/gitlabhq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jvanbaarsen/gitlabhq/merges","archive_url":"https://api.github.com/repos/jvanbaarsen/gitlabhq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jvanbaarsen/gitlabhq/downloads","issues_url":"https://api.github.com/repos/jvanbaarsen/gitlabhq/issues{/number}","pulls_url":"https://api.github.com/repos/jvanbaarsen/gitlabhq/pulls{/number}","milestones_url":"https://api.github.com/repos/jvanbaarsen/gitlabhq/milestones{/number}","notifications_url":"https://api.github.com/repos/jvanbaarsen/gitlabhq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jvanbaarsen/gitlabhq/labels{/name}","releases_url":"https://api.github.com/repos/jvanbaarsen/gitlabhq/releases{/id}","created_at":"2013-07-20T10:29:16Z","updated_at":"2014-07-16T18:49:24Z","pushed_at":"2015-01-04T13:02:47Z","git_url":"git://github.com/jvanbaarsen/gitlabhq.git","ssh_url":"git@github.com:jvanbaarsen/gitlabhq.git","clone_url":"https://github.com/jvanbaarsen/gitlabhq.git","svn_url":"https://github.com/jvanbaarsen/gitlabhq","homepage":"gitlab.org","size":86508,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gitlabhq:master","ref":"master","sha":"5dbbec4612d12d00d9db6ad057044054b923817f","user":{"login":"gitlabhq","id":1086321,"avatar_url":"https://avatars.githubusercontent.com/u/1086321?v=3","gravatar_id":"","url":"https://api.github.com/users/gitlabhq","html_url":"https://github.com/gitlabhq","followers_url":"https://api.github.com/users/gitlabhq/followers","following_url":"https://api.github.com/users/gitlabhq/following{/other_user}","gists_url":"https://api.github.com/users/gitlabhq/gists{/gist_id}","starred_url":"https://api.github.com/users/gitlabhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitlabhq/subscriptions","organizations_url":"https://api.github.com/users/gitlabhq/orgs","repos_url":"https://api.github.com/users/gitlabhq/repos","events_url":"https://api.github.com/users/gitlabhq/events{/privacy}","received_events_url":"https://api.github.com/users/gitlabhq/received_events","type":"Organization","site_admin":false},"repo":{"id":2500088,"name":"gitlabhq","full_name":"gitlabhq/gitlabhq","owner":{"login":"gitlabhq","id":1086321,"avatar_url":"https://avatars.githubusercontent.com/u/1086321?v=3","gravatar_id":"","url":"https://api.github.com/users/gitlabhq","html_url":"https://github.com/gitlabhq","followers_url":"https://api.github.com/users/gitlabhq/followers","following_url":"https://api.github.com/users/gitlabhq/following{/other_user}","gists_url":"https://api.github.com/users/gitlabhq/gists{/gist_id}","starred_url":"https://api.github.com/users/gitlabhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitlabhq/subscriptions","organizations_url":"https://api.github.com/users/gitlabhq/orgs","repos_url":"https://api.github.com/users/gitlabhq/repos","events_url":"https://api.github.com/users/gitlabhq/events{/privacy}","received_events_url":"https://api.github.com/users/gitlabhq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gitlabhq/gitlabhq","description":"Open source software to collaborate on code. Follow us on twitter @gitlabhq","fork":false,"url":"https://api.github.com/repos/gitlabhq/gitlabhq","forks_url":"https://api.github.com/repos/gitlabhq/gitlabhq/forks","keys_url":"https://api.github.com/repos/gitlabhq/gitlabhq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gitlabhq/gitlabhq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gitlabhq/gitlabhq/teams","hooks_url":"https://api.github.com/repos/gitlabhq/gitlabhq/hooks","issue_events_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/events{/number}","events_url":"https://api.github.com/repos/gitlabhq/gitlabhq/events","assignees_url":"https://api.github.com/repos/gitlabhq/gitlabhq/assignees{/user}","branches_url":"https://api.github.com/repos/gitlabhq/gitlabhq/branches{/branch}","tags_url":"https://api.github.com/repos/gitlabhq/gitlabhq/tags","blobs_url":"https://api.github.com/repos/gitlabhq/gitlabhq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gitlabhq/gitlabhq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gitlabhq/gitlabhq/git/refs{/sha}","trees_url":"https://api.github.com/repos/gitlabhq/gitlabhq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gitlabhq/gitlabhq/statuses/{sha}","languages_url":"https://api.github.com/repos/gitlabhq/gitlabhq/languages","stargazers_url":"https://api.github.com/repos/gitlabhq/gitlabhq/stargazers","contributors_url":"https://api.github.com/repos/gitlabhq/gitlabhq/contributors","subscribers_url":"https://api.github.com/repos/gitlabhq/gitlabhq/subscribers","subscription_url":"https://api.github.com/repos/gitlabhq/gitlabhq/subscription","commits_url":"https://api.github.com/repos/gitlabhq/gitlabhq/commits{/sha}","git_commits_url":"https://api.github.com/repos/gitlabhq/gitlabhq/git/commits{/sha}","comments_url":"https://api.github.com/repos/gitlabhq/gitlabhq/comments{/number}","issue_comment_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/comments/{number}","contents_url":"https://api.github.com/repos/gitlabhq/gitlabhq/contents/{+path}","compare_url":"https://api.github.com/repos/gitlabhq/gitlabhq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gitlabhq/gitlabhq/merges","archive_url":"https://api.github.com/repos/gitlabhq/gitlabhq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gitlabhq/gitlabhq/downloads","issues_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues{/number}","pulls_url":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls{/number}","milestones_url":"https://api.github.com/repos/gitlabhq/gitlabhq/milestones{/number}","notifications_url":"https://api.github.com/repos/gitlabhq/gitlabhq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gitlabhq/gitlabhq/labels{/name}","releases_url":"https://api.github.com/repos/gitlabhq/gitlabhq/releases{/id}","created_at":"2011-10-02T16:25:27Z","updated_at":"2015-01-04T10:33:36Z","pushed_at":"2015-01-03T12:07:44Z","git_url":"git://github.com/gitlabhq/gitlabhq.git","ssh_url":"git@github.com:gitlabhq/gitlabhq.git","clone_url":"https://github.com/gitlabhq/gitlabhq.git","svn_url":"https://github.com/gitlabhq/gitlabhq","homepage":"https://about.gitlab.com/","size":138306,"stargazers_count":14564,"watchers_count":14564,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3822,"mirror_url":null,"open_issues_count":713,"forks":3822,"open_issues":713,"watchers":14564,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/8534"},"html":{"href":"https://github.com/gitlabhq/gitlabhq/pull/8534"},"issue":{"href":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/8534"},"comments":{"href":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/8534/comments"},"review_comments":{"href":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/8534/comments"},"review_comment":{"href":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/8534/commits"},"statuses":{"href":"https://api.github.com/repos/gitlabhq/gitlabhq/statuses/275d557d8dac828f3e88d8f418b6b05a1f42a29d"}}}}