{"action":"created","issue":{"url":"https://api.github.com/repos/chummer5a/chummer5a/issues/240","labels_url":"https://api.github.com/repos/chummer5a/chummer5a/issues/240/labels{/name}","comments_url":"https://api.github.com/repos/chummer5a/chummer5a/issues/240/comments","events_url":"https://api.github.com/repos/chummer5a/chummer5a/issues/240/events","html_url":"https://github.com/chummer5a/chummer5a/issues/240","id":89362084,"number":240,"title":"Automatically included metagenetic qualities included in Karma Spent on Positive and Negative Qualities","user":{"login":"richard-zang","id":10375620,"avatar_url":"https://avatars.githubusercontent.com/u/10375620?v=3","gravatar_id":"","url":"https://api.github.com/users/richard-zang","html_url":"https://github.com/richard-zang","followers_url":"https://api.github.com/users/richard-zang/followers","following_url":"https://api.github.com/users/richard-zang/following{/other_user}","gists_url":"https://api.github.com/users/richard-zang/gists{/gist_id}","starred_url":"https://api.github.com/users/richard-zang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richard-zang/subscriptions","organizations_url":"https://api.github.com/users/richard-zang/orgs","repos_url":"https://api.github.com/users/richard-zang/repos","events_url":"https://api.github.com/users/richard-zang/events{/privacy}","received_events_url":"https://api.github.com/users/richard-zang/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-06-18T18:21:02Z","updated_at":"2015-06-18T18:40:48Z","closed_at":null,"body":"<b>How to Reproduce:</b>\r\n1. Create a new character with Priority.\r\n2. Select a metavariant when choosing Character Priorities.\r\n3. Add a Positive Quality that costs more than 25 - Metagenetic Positive Qualities Cost\r\n4. Get message that you can't spend more than 25 karma on positive qualities.\r\n\r\nEx. Nartaki Magician has Shiva Arms. Attempting to add Focused Concentration (Rating 6) triggers message and prevents from adding.\r\n\r\nThis is an issue for any character creation mode.\r\n\r\n<b>Suspected Cause:</b>\r\nWhen mandatory metagenetic qualities are added, ContributeToLimit bool on each quality object defaults to true.\r\n\r\n<b>Suggested Fix:</b>\r\nin <b>frmPriorityMetatype.cs</b>\r\nAfter line ~1190: <code>objQuality.Create(objXmlQuality, _objCharacter, objSource, objNode, objWeapons, objWeaponNodes, strForceValue);</code>\r\nAdd: <code>objQuality.ContributeToLimit = false;</code>\r\n\r\nAfter line ~1212: <code>objQuality.Create(objXmlQuality, _objCharacter, objSource, objNode, objWeapons, objWeaponNodes, strForceValue);</code>\r\nAdd: <code>objQuality.ContributeToLimit = false;</code>\r\n\r\nThis would fix for any metavariant. You would need to add same lines to Metatype if metatypes also have associated qualities. lines ~1138 and ~1159.\r\n\r\nWe can't change the Qualities xml because the metagenetic qualities can be manually selected for other metavariants/metatypes and would therefore contribute to the karma limit."},"comment":{"url":"https://api.github.com/repos/chummer5a/chummer5a/issues/comments/113253514","html_url":"https://github.com/chummer5a/chummer5a/issues/240#issuecomment-113253514","issue_url":"https://api.github.com/repos/chummer5a/chummer5a/issues/240","id":113253514,"user":{"login":"richard-zang","id":10375620,"avatar_url":"https://avatars.githubusercontent.com/u/10375620?v=3","gravatar_id":"","url":"https://api.github.com/users/richard-zang","html_url":"https://github.com/richard-zang","followers_url":"https://api.github.com/users/richard-zang/followers","following_url":"https://api.github.com/users/richard-zang/following{/other_user}","gists_url":"https://api.github.com/users/richard-zang/gists{/gist_id}","starred_url":"https://api.github.com/users/richard-zang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richard-zang/subscriptions","organizations_url":"https://api.github.com/users/richard-zang/orgs","repos_url":"https://api.github.com/users/richard-zang/repos","events_url":"https://api.github.com/users/richard-zang/events{/privacy}","received_events_url":"https://api.github.com/users/richard-zang/received_events","type":"User","site_admin":false},"created_at":"2015-06-18T18:40:48Z","updated_at":"2015-06-18T18:40:48Z","body":"Ok cool.\r\nI'm not sure what you mean by readonly. Do you mean the mutator method shouldn't work? Because it  definitely has an effect if I try to set it."}}