{"action":"created","comment":{"url":"https://api.github.com/repos/Runnable/fs-transform/pulls/comments/30338518","id":30338518,"diff_hunk":"@@ -371,3 +352,14 @@ FsDriver.prototype.removeWorkingDirectory = function (cb) {\n FsDriver.prototype.workingDiff = function (cb) {\n   this.diff(this.root, this.working, cb);\n };\n+\n+/**\n+ * Exposes the escape method.\n+ */\n+Object.defineProperty(FsDriver, 'escape', {\n+  value: function (string) {\n+    return new FsDriver('/').escape(string);\n+  },\n+  writable: false,\n+  enumerable: true\n+});","path":"lib/fs-driver.js","position":40,"original_position":40,"commit_id":"3faf958e63f3b5e9ac47ab5bb38476c15cb929c5","original_commit_id":"3faf958e63f3b5e9ac47ab5bb38476c15cb929c5","user":{"login":"bkendall","id":160236,"avatar_url":"https://avatars.githubusercontent.com/u/160236?v=3","gravatar_id":"","url":"https://api.github.com/users/bkendall","html_url":"https://github.com/bkendall","followers_url":"https://api.github.com/users/bkendall/followers","following_url":"https://api.github.com/users/bkendall/following{/other_user}","gists_url":"https://api.github.com/users/bkendall/gists{/gist_id}","starred_url":"https://api.github.com/users/bkendall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkendall/subscriptions","organizations_url":"https://api.github.com/users/bkendall/orgs","repos_url":"https://api.github.com/users/bkendall/repos","events_url":"https://api.github.com/users/bkendall/events{/privacy}","received_events_url":"https://api.github.com/users/bkendall/received_events","type":"User","site_admin":false},"body":"I'm curious why expose `escape` like this, rather than making `escape` a class method (`FsDriver.escape`)","created_at":"2015-05-14T16:54:15Z","updated_at":"2015-05-14T16:54:15Z","html_url":"https://github.com/Runnable/fs-transform/pull/5#discussion_r30338518","pull_request_url":"https://api.github.com/repos/Runnable/fs-transform/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/Runnable/fs-transform/pulls/comments/30338518"},"html":{"href":"https://github.com/Runnable/fs-transform/pull/5#discussion_r30338518"},"pull_request":{"href":"https://api.github.com/repos/Runnable/fs-transform/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/Runnable/fs-transform/pulls/5","id":35287895,"html_url":"https://github.com/Runnable/fs-transform/pull/5","diff_url":"https://github.com/Runnable/fs-transform/pull/5.diff","patch_url":"https://github.com/Runnable/fs-transform/pull/5.patch","issue_url":"https://api.github.com/repos/Runnable/fs-transform/issues/5","number":5,"state":"open","locked":false,"title":"Robust Scripts","user":{"login":"rsandor","id":146592,"avatar_url":"https://avatars.githubusercontent.com/u/146592?v=3","gravatar_id":"","url":"https://api.github.com/users/rsandor","html_url":"https://github.com/rsandor","followers_url":"https://api.github.com/users/rsandor/followers","following_url":"https://api.github.com/users/rsandor/following{/other_user}","gists_url":"https://api.github.com/users/rsandor/gists{/gist_id}","starred_url":"https://api.github.com/users/rsandor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsandor/subscriptions","organizations_url":"https://api.github.com/users/rsandor/orgs","repos_url":"https://api.github.com/users/rsandor/repos","events_url":"https://api.github.com/users/rsandor/events{/privacy}","received_events_url":"https://api.github.com/users/rsandor/received_events","type":"User","site_admin":false},"body":"This makes the generated scripts more robust and adaptable. Here's an overview:\r\n\r\n1. Scripts are now generated directly from the rules, as opposed to from the commands run by the Transformer itself.\r\n2. The script preamble has been cleaned up and helper functions were added.\r\n3. Replace rule is now implemented fully in `sh`.\r\n4. When commands fail they use the new helper functions to provide a better understanding to the end user what went wrong.\r\n\r\nFinally, since we don't need it I completely removed line excludes from the replace rule.\r\n","created_at":"2015-05-13T01:52:54Z","updated_at":"2015-05-14T16:54:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d00c4b1d52a9d0e10cd8ab65505af464025355b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Runnable/fs-transform/pulls/5/commits","review_comments_url":"https://api.github.com/repos/Runnable/fs-transform/pulls/5/comments","review_comment_url":"https://api.github.com/repos/Runnable/fs-transform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Runnable/fs-transform/issues/5/comments","statuses_url":"https://api.github.com/repos/Runnable/fs-transform/statuses/3faf958e63f3b5e9ac47ab5bb38476c15cb929c5","head":{"label":"Runnable:rsandor/robust-scripts","ref":"rsandor/robust-scripts","sha":"3faf958e63f3b5e9ac47ab5bb38476c15cb929c5","user":{"login":"Runnable","id":2828361,"avatar_url":"https://avatars.githubusercontent.com/u/2828361?v=3","gravatar_id":"","url":"https://api.github.com/users/Runnable","html_url":"https://github.com/Runnable","followers_url":"https://api.github.com/users/Runnable/followers","following_url":"https://api.github.com/users/Runnable/following{/other_user}","gists_url":"https://api.github.com/users/Runnable/gists{/gist_id}","starred_url":"https://api.github.com/users/Runnable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Runnable/subscriptions","organizations_url":"https://api.github.com/users/Runnable/orgs","repos_url":"https://api.github.com/users/Runnable/repos","events_url":"https://api.github.com/users/Runnable/events{/privacy}","received_events_url":"https://api.github.com/users/Runnable/received_events","type":"Organization","site_admin":false},"repo":{"id":33763032,"name":"fs-transform","full_name":"Runnable/fs-transform","owner":{"login":"Runnable","id":2828361,"avatar_url":"https://avatars.githubusercontent.com/u/2828361?v=3","gravatar_id":"","url":"https://api.github.com/users/Runnable","html_url":"https://github.com/Runnable","followers_url":"https://api.github.com/users/Runnable/followers","following_url":"https://api.github.com/users/Runnable/following{/other_user}","gists_url":"https://api.github.com/users/Runnable/gists{/gist_id}","starred_url":"https://api.github.com/users/Runnable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Runnable/subscriptions","organizations_url":"https://api.github.com/users/Runnable/orgs","repos_url":"https://api.github.com/users/Runnable/repos","events_url":"https://api.github.com/users/Runnable/events{/privacy}","received_events_url":"https://api.github.com/users/Runnable/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Runnable/fs-transform","description":"Fast, rule based, file system transformations.","fork":false,"url":"https://api.github.com/repos/Runnable/fs-transform","forks_url":"https://api.github.com/repos/Runnable/fs-transform/forks","keys_url":"https://api.github.com/repos/Runnable/fs-transform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Runnable/fs-transform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Runnable/fs-transform/teams","hooks_url":"https://api.github.com/repos/Runnable/fs-transform/hooks","issue_events_url":"https://api.github.com/repos/Runnable/fs-transform/issues/events{/number}","events_url":"https://api.github.com/repos/Runnable/fs-transform/events","assignees_url":"https://api.github.com/repos/Runnable/fs-transform/assignees{/user}","branches_url":"https://api.github.com/repos/Runnable/fs-transform/branches{/branch}","tags_url":"https://api.github.com/repos/Runnable/fs-transform/tags","blobs_url":"https://api.github.com/repos/Runnable/fs-transform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Runnable/fs-transform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Runnable/fs-transform/git/refs{/sha}","trees_url":"https://api.github.com/repos/Runnable/fs-transform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Runnable/fs-transform/statuses/{sha}","languages_url":"https://api.github.com/repos/Runnable/fs-transform/languages","stargazers_url":"https://api.github.com/repos/Runnable/fs-transform/stargazers","contributors_url":"https://api.github.com/repos/Runnable/fs-transform/contributors","subscribers_url":"https://api.github.com/repos/Runnable/fs-transform/subscribers","subscription_url":"https://api.github.com/repos/Runnable/fs-transform/subscription","commits_url":"https://api.github.com/repos/Runnable/fs-transform/commits{/sha}","git_commits_url":"https://api.github.com/repos/Runnable/fs-transform/git/commits{/sha}","comments_url":"https://api.github.com/repos/Runnable/fs-transform/comments{/number}","issue_comment_url":"https://api.github.com/repos/Runnable/fs-transform/issues/comments{/number}","contents_url":"https://api.github.com/repos/Runnable/fs-transform/contents/{+path}","compare_url":"https://api.github.com/repos/Runnable/fs-transform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Runnable/fs-transform/merges","archive_url":"https://api.github.com/repos/Runnable/fs-transform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Runnable/fs-transform/downloads","issues_url":"https://api.github.com/repos/Runnable/fs-transform/issues{/number}","pulls_url":"https://api.github.com/repos/Runnable/fs-transform/pulls{/number}","milestones_url":"https://api.github.com/repos/Runnable/fs-transform/milestones{/number}","notifications_url":"https://api.github.com/repos/Runnable/fs-transform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Runnable/fs-transform/labels{/name}","releases_url":"https://api.github.com/repos/Runnable/fs-transform/releases{/id}","created_at":"2015-04-11T04:48:54Z","updated_at":"2015-04-29T23:06:08Z","pushed_at":"2015-05-13T18:55:06Z","git_url":"git://github.com/Runnable/fs-transform.git","ssh_url":"git@github.com:Runnable/fs-transform.git","clone_url":"https://github.com/Runnable/fs-transform.git","svn_url":"https://github.com/Runnable/fs-transform","homepage":null,"size":368,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"Runnable:master","ref":"master","sha":"02c5bdc67d3eb23f296f6c819a5037d991573f2b","user":{"login":"Runnable","id":2828361,"avatar_url":"https://avatars.githubusercontent.com/u/2828361?v=3","gravatar_id":"","url":"https://api.github.com/users/Runnable","html_url":"https://github.com/Runnable","followers_url":"https://api.github.com/users/Runnable/followers","following_url":"https://api.github.com/users/Runnable/following{/other_user}","gists_url":"https://api.github.com/users/Runnable/gists{/gist_id}","starred_url":"https://api.github.com/users/Runnable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Runnable/subscriptions","organizations_url":"https://api.github.com/users/Runnable/orgs","repos_url":"https://api.github.com/users/Runnable/repos","events_url":"https://api.github.com/users/Runnable/events{/privacy}","received_events_url":"https://api.github.com/users/Runnable/received_events","type":"Organization","site_admin":false},"repo":{"id":33763032,"name":"fs-transform","full_name":"Runnable/fs-transform","owner":{"login":"Runnable","id":2828361,"avatar_url":"https://avatars.githubusercontent.com/u/2828361?v=3","gravatar_id":"","url":"https://api.github.com/users/Runnable","html_url":"https://github.com/Runnable","followers_url":"https://api.github.com/users/Runnable/followers","following_url":"https://api.github.com/users/Runnable/following{/other_user}","gists_url":"https://api.github.com/users/Runnable/gists{/gist_id}","starred_url":"https://api.github.com/users/Runnable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Runnable/subscriptions","organizations_url":"https://api.github.com/users/Runnable/orgs","repos_url":"https://api.github.com/users/Runnable/repos","events_url":"https://api.github.com/users/Runnable/events{/privacy}","received_events_url":"https://api.github.com/users/Runnable/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Runnable/fs-transform","description":"Fast, rule based, file system transformations.","fork":false,"url":"https://api.github.com/repos/Runnable/fs-transform","forks_url":"https://api.github.com/repos/Runnable/fs-transform/forks","keys_url":"https://api.github.com/repos/Runnable/fs-transform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Runnable/fs-transform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Runnable/fs-transform/teams","hooks_url":"https://api.github.com/repos/Runnable/fs-transform/hooks","issue_events_url":"https://api.github.com/repos/Runnable/fs-transform/issues/events{/number}","events_url":"https://api.github.com/repos/Runnable/fs-transform/events","assignees_url":"https://api.github.com/repos/Runnable/fs-transform/assignees{/user}","branches_url":"https://api.github.com/repos/Runnable/fs-transform/branches{/branch}","tags_url":"https://api.github.com/repos/Runnable/fs-transform/tags","blobs_url":"https://api.github.com/repos/Runnable/fs-transform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Runnable/fs-transform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Runnable/fs-transform/git/refs{/sha}","trees_url":"https://api.github.com/repos/Runnable/fs-transform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Runnable/fs-transform/statuses/{sha}","languages_url":"https://api.github.com/repos/Runnable/fs-transform/languages","stargazers_url":"https://api.github.com/repos/Runnable/fs-transform/stargazers","contributors_url":"https://api.github.com/repos/Runnable/fs-transform/contributors","subscribers_url":"https://api.github.com/repos/Runnable/fs-transform/subscribers","subscription_url":"https://api.github.com/repos/Runnable/fs-transform/subscription","commits_url":"https://api.github.com/repos/Runnable/fs-transform/commits{/sha}","git_commits_url":"https://api.github.com/repos/Runnable/fs-transform/git/commits{/sha}","comments_url":"https://api.github.com/repos/Runnable/fs-transform/comments{/number}","issue_comment_url":"https://api.github.com/repos/Runnable/fs-transform/issues/comments{/number}","contents_url":"https://api.github.com/repos/Runnable/fs-transform/contents/{+path}","compare_url":"https://api.github.com/repos/Runnable/fs-transform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Runnable/fs-transform/merges","archive_url":"https://api.github.com/repos/Runnable/fs-transform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Runnable/fs-transform/downloads","issues_url":"https://api.github.com/repos/Runnable/fs-transform/issues{/number}","pulls_url":"https://api.github.com/repos/Runnable/fs-transform/pulls{/number}","milestones_url":"https://api.github.com/repos/Runnable/fs-transform/milestones{/number}","notifications_url":"https://api.github.com/repos/Runnable/fs-transform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Runnable/fs-transform/labels{/name}","releases_url":"https://api.github.com/repos/Runnable/fs-transform/releases{/id}","created_at":"2015-04-11T04:48:54Z","updated_at":"2015-04-29T23:06:08Z","pushed_at":"2015-05-13T18:55:06Z","git_url":"git://github.com/Runnable/fs-transform.git","ssh_url":"git@github.com:Runnable/fs-transform.git","clone_url":"https://github.com/Runnable/fs-transform.git","svn_url":"https://github.com/Runnable/fs-transform","homepage":null,"size":368,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Runnable/fs-transform/pulls/5"},"html":{"href":"https://github.com/Runnable/fs-transform/pull/5"},"issue":{"href":"https://api.github.com/repos/Runnable/fs-transform/issues/5"},"comments":{"href":"https://api.github.com/repos/Runnable/fs-transform/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/Runnable/fs-transform/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/Runnable/fs-transform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Runnable/fs-transform/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/Runnable/fs-transform/statuses/3faf958e63f3b5e9ac47ab5bb38476c15cb929c5"}}}}