{"action":"created","issue":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/12601","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/12601/labels{/name}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/12601/comments","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/12601/events","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/issues/12601","id":86661431,"number":12601,"title":"Water tanks on vehicles and general vehicle construction menu problem","user":{"login":"drbig","id":1252899,"avatar_url":"https://avatars.githubusercontent.com/u/1252899?v=3","gravatar_id":"","url":"https://api.github.com/users/drbig","html_url":"https://github.com/drbig","followers_url":"https://api.github.com/users/drbig/followers","following_url":"https://api.github.com/users/drbig/following{/other_user}","gists_url":"https://api.github.com/users/drbig/gists{/gist_id}","starred_url":"https://api.github.com/users/drbig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drbig/subscriptions","organizations_url":"https://api.github.com/users/drbig/orgs","repos_url":"https://api.github.com/users/drbig/repos","events_url":"https://api.github.com/users/drbig/events{/privacy}","received_events_url":"https://api.github.com/users/drbig/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-06-09T16:42:44Z","updated_at":"2015-06-09T21:40:52Z","closed_at":null,"body":"*(Based on 0.C-3666-g3faa19b)*\r\n\r\nSo we used to have only clean water tanks on vehicles, which was an arbitrary limitation, but at least the whole thing around it worked.\r\n\r\nRight now it seems we have the little, small and 'normal' (which uses 30 gallon drum specifically) variations for *dirty* water tanks, and only single option for clean water tank (the 30 gallon drum). Now the water faucet seems to work only with *clean* water tank, so the *dirty* water tanks are not much of an improvement over just storing the damn container in the vehicle (instead of grabbing the container you now have to have a rubber hose to siphon the dirty water back). Also the common metal tank seems to be inexplicably not usable at all for holding *any* kind of water.\r\n\r\nA temporary solution would be to add the *dirty* and *clean* versions for all possible water tanks (metal tank = 'normal', X gallon drum = 'large') and *then also* have two version of water faucets.\r\n\r\nUnless I'm missing some good reason where the current state makes sense...\r\n\r\n--\r\nAnd the above temporary solution brings us to another general problem with the vehicle menu: we have too many parts in a flat list that are variations of a single logical/physical item. A metal tank is a metal tank and doesn't care/limits what can be in it (even if the thing you pour in is gonna eat it: it should then get damaged progressively, but that's another matter).\r\n\r\nProposed sane solution: make part choosing a multi-level process. We already have a 'sub-menu' for choosing frame appearance, we should build on that mechanic.\r\n\r\nTwo examples:\r\n\r\n - In top-level menu you see: little metal tank, small metal tank, metal tank, 30 gallon drum\r\n - You selected small metal tank\r\n - Now you select fuel type for it: water, clean water, gasoline, diesel etc... You have selected clean water\r\n - This installs a 'small clean water tank'\r\n - You now select a vehicle faucet from the top-level menu\r\n - And it asks you for fuel type as above...\r\n\r\nIn case of fluid tanks this still keeps the mechanic where you don't need to install any piping, e.g. any X facuet will tap into all X tanks.\r\n\r\n - In the top level menu you see: door\r\n - You select it, and are presented with types: sliding, hatch, normal (outer?)...\r\n\r\nMost of the items in the list can be logically grouped together, and the multi-level menu approach leaves room for more fancy future additions (like finally being able to select a specific engine of type X out of those lying around).\r\n\r\n*Thank you for reading*\r\n\r\n<bountysource-plugin>\r\n---\r\nWant to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/21239564-water-tanks-on-vehicles-and-general-vehicle-construction-menu-problem?utm_campaign=plugin&utm_content=tracker%2F146201&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F146201&utm_medium=issues&utm_source=github).\r\n</bountysource-plugin>"},"comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments/110512381","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/issues/12601#issuecomment-110512381","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/12601","id":110512381,"user":{"login":"Rivet-the-Zombie","id":5084581,"avatar_url":"https://avatars.githubusercontent.com/u/5084581?v=3","gravatar_id":"","url":"https://api.github.com/users/Rivet-the-Zombie","html_url":"https://github.com/Rivet-the-Zombie","followers_url":"https://api.github.com/users/Rivet-the-Zombie/followers","following_url":"https://api.github.com/users/Rivet-the-Zombie/following{/other_user}","gists_url":"https://api.github.com/users/Rivet-the-Zombie/gists{/gist_id}","starred_url":"https://api.github.com/users/Rivet-the-Zombie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rivet-the-Zombie/subscriptions","organizations_url":"https://api.github.com/users/Rivet-the-Zombie/orgs","repos_url":"https://api.github.com/users/Rivet-the-Zombie/repos","events_url":"https://api.github.com/users/Rivet-the-Zombie/events{/privacy}","received_events_url":"https://api.github.com/users/Rivet-the-Zombie/received_events","type":"User","site_admin":false},"created_at":"2015-06-09T21:40:52Z","updated_at":"2015-06-09T21:40:52Z","body":">any tank accepts any input while empty, with any input it limits itself to that input. A faucet then presents a menu of what to pour. When back to empty it reverts to accepting anything.\r\n\r\nThis is a great idea."}}