{"action":"created","issue":{"url":"https://api.github.com/repos/ceph/ceph/issues/5292","labels_url":"https://api.github.com/repos/ceph/ceph/issues/5292/labels{/name}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/5292/comments","events_url":"https://api.github.com/repos/ceph/ceph/issues/5292/events","html_url":"https://github.com/ceph/ceph/pull/5292","id":96005204,"number":5292,"title":"get pools health'info have error #12402","user":{"login":"renhwztetecs","id":13412719,"avatar_url":"https://avatars.githubusercontent.com/u/13412719?v=3","gravatar_id":"","url":"https://api.github.com/users/renhwztetecs","html_url":"https://github.com/renhwztetecs","followers_url":"https://api.github.com/users/renhwztetecs/followers","following_url":"https://api.github.com/users/renhwztetecs/following{/other_user}","gists_url":"https://api.github.com/users/renhwztetecs/gists{/gist_id}","starred_url":"https://api.github.com/users/renhwztetecs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renhwztetecs/subscriptions","organizations_url":"https://api.github.com/users/renhwztetecs/orgs","repos_url":"https://api.github.com/users/renhwztetecs/repos","events_url":"https://api.github.com/users/renhwztetecs/events{/privacy}","received_events_url":"https://api.github.com/users/renhwztetecs/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-07-20T07:46:55Z","updated_at":"2015-07-20T13:48:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/5292","html_url":"https://github.com/ceph/ceph/pull/5292","diff_url":"https://github.com/ceph/ceph/pull/5292.diff","patch_url":"https://github.com/ceph/ceph/pull/5292.patch"},"body":"Fixes: http://tracker.ceph.com/issues/12402\r\nSigned-off-by: ren.huanwen@zte.com.cn\r\n\r\nfile : OSDMonitor.cc\r\nfunction: void OSDMonitor::get_pools_health(\r\nlist >& summary,\r\nlist > detail) const\r\ndescribe:\r\n......\r\n} else if (crit_threshold > 0 &&\r\nsum.num_bytes >= pool.quota_max_bytescrit_threshold) {\r\nss << \"pool '\" << pool_name\r\n<< \"' has \" << si_t(sum.num_bytes) << \" bytes\"\r\n<< \" (max \" << si_t(pool.quota_max_bytes) << \")\";\r\nstatus = HEALTH_ERR;\r\n} else if (warn_threshold > 0 &&\r\nsum.num_bytes >= pool.quota_max_bytes*warn_threshold) {\r\nss << \"pool '\" << pool_name\r\n<< \"' has \" << si_t(sum.num_bytes) << \" objects\"\r\n<< \" (max \" << si_t(pool.quota_max_bytes) << \")\";\r\nstatus = HEALTH_WARN;\r\n}\r\n......\r\n\r\ncode modification:\r\nthe \"objects\" replaced by \"bytes\"\r\n"},"comment":{"url":"https://api.github.com/repos/ceph/ceph/issues/comments/122891243","html_url":"https://github.com/ceph/ceph/pull/5292#issuecomment-122891243","issue_url":"https://api.github.com/repos/ceph/ceph/issues/5292","id":122891243,"user":{"login":"tchaikov","id":59071,"avatar_url":"https://avatars.githubusercontent.com/u/59071?v=3","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"created_at":"2015-07-20T13:48:57Z","updated_at":"2015-07-20T13:48:57Z","body":"yeah, in addition to editing the commit title, could you please \r\n\r\n- remove the merge commit. \r\n- change the \"Fixed\" line to \"Fixes: #12402\"\r\n- move the \"Fixed\" and \"Signed-off-by\" line to the end of the commit message.\r\n- be concise in your commit message body, e.g. fix the message dumped by OSDMonitor::get_pools_health(), s/objects/bytes/"}}