{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/28278175","id":28278175,"diff_hunk":"@@ -94,6 +98,14 @@ private[yarn] class YarnAllocator(\n   // Additional memory overhead.\n   protected val memoryOverhead: Int = sparkConf.getInt(\"spark.yarn.executor.memoryOverhead\",\n     math.max((MEMORY_OVERHEAD_FACTOR * executorMemory).toInt, MEMORY_OVERHEAD_MIN))\n+\n+  // Make the maximum executor failure check to be relative with respect to duration\n+  private val relativeMaxExecutorFailureCheck = ","path":"yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala","position":24,"original_position":24,"commit_id":"4750a012bcdc2cb55770f6e75c52cc1e0d6041fb","original_commit_id":"4750a012bcdc2cb55770f6e75c52cc1e0d6041fb","user":{"login":"sryza","id":654855,"avatar_url":"https://avatars.githubusercontent.com/u/654855?v=3","gravatar_id":"","url":"https://api.github.com/users/sryza","html_url":"https://github.com/sryza","followers_url":"https://api.github.com/users/sryza/followers","following_url":"https://api.github.com/users/sryza/following{/other_user}","gists_url":"https://api.github.com/users/sryza/gists{/gist_id}","starred_url":"https://api.github.com/users/sryza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sryza/subscriptions","organizations_url":"https://api.github.com/users/sryza/orgs","repos_url":"https://api.github.com/users/sryza/repos","events_url":"https://api.github.com/users/sryza/events{/privacy}","received_events_url":"https://api.github.com/users/sryza/received_events","type":"User","site_admin":false},"body":"My point was that the size of the window might not need to vary.  Are there examples that come to mind of scenarios where the ideal window size is widely different?","created_at":"2015-04-13T20:55:34Z","updated_at":"2015-04-13T20:55:34Z","html_url":"https://github.com/apache/spark/pull/5449#discussion_r28278175","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/5449","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/28278175"},"html":{"href":"https://github.com/apache/spark/pull/5449#discussion_r28278175"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/5449"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/5449","id":33026770,"html_url":"https://github.com/apache/spark/pull/5449","diff_url":"https://github.com/apache/spark/pull/5449.diff","patch_url":"https://github.com/apache/spark/pull/5449.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/5449","number":5449,"state":"open","locked":false,"title":"SPARK-6735:[YARN] Adding properties to disable maximum number of executor failure's check or to make it relative to duration","user":{"login":"twinkle-sachdeva","id":7300226,"avatar_url":"https://avatars.githubusercontent.com/u/7300226?v=3","gravatar_id":"","url":"https://api.github.com/users/twinkle-sachdeva","html_url":"https://github.com/twinkle-sachdeva","followers_url":"https://api.github.com/users/twinkle-sachdeva/followers","following_url":"https://api.github.com/users/twinkle-sachdeva/following{/other_user}","gists_url":"https://api.github.com/users/twinkle-sachdeva/gists{/gist_id}","starred_url":"https://api.github.com/users/twinkle-sachdeva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twinkle-sachdeva/subscriptions","organizations_url":"https://api.github.com/users/twinkle-sachdeva/orgs","repos_url":"https://api.github.com/users/twinkle-sachdeva/repos","events_url":"https://api.github.com/users/twinkle-sachdeva/events{/privacy}","received_events_url":"https://api.github.com/users/twinkle-sachdeva/received_events","type":"User","site_admin":false},"body":"For long running applications, user might want to disable this property or to make it relative to a duration window, so that some older failure does not cause Application to abort in long run.\r\n\r\nAdded properties 1) spark.yarn.max.executor.failures.disable: to disable maximum executor failure check 2) spark.yarn.max.executor.failures.relative: to make the maximum executor failure to be relative 3)spark.yarn.max.executor.failures.relative.window: specify relative window duration in sec , default being 600 sec","created_at":"2015-04-10T08:23:40Z","updated_at":"2015-04-13T20:55:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"193527267ceb8cc165cdfaa93d0e63e7e08d0ac9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/5449/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/5449/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/5449/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/4750a012bcdc2cb55770f6e75c52cc1e0d6041fb","head":{"label":"twinkle-sachdeva:SPARK-6735-MASTER","ref":"SPARK-6735-MASTER","sha":"4750a012bcdc2cb55770f6e75c52cc1e0d6041fb","user":{"login":"twinkle-sachdeva","id":7300226,"avatar_url":"https://avatars.githubusercontent.com/u/7300226?v=3","gravatar_id":"","url":"https://api.github.com/users/twinkle-sachdeva","html_url":"https://github.com/twinkle-sachdeva","followers_url":"https://api.github.com/users/twinkle-sachdeva/followers","following_url":"https://api.github.com/users/twinkle-sachdeva/following{/other_user}","gists_url":"https://api.github.com/users/twinkle-sachdeva/gists{/gist_id}","starred_url":"https://api.github.com/users/twinkle-sachdeva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twinkle-sachdeva/subscriptions","organizations_url":"https://api.github.com/users/twinkle-sachdeva/orgs","repos_url":"https://api.github.com/users/twinkle-sachdeva/repos","events_url":"https://api.github.com/users/twinkle-sachdeva/events{/privacy}","received_events_url":"https://api.github.com/users/twinkle-sachdeva/received_events","type":"User","site_admin":false},"repo":{"id":22202179,"name":"spark","full_name":"twinkle-sachdeva/spark","owner":{"login":"twinkle-sachdeva","id":7300226,"avatar_url":"https://avatars.githubusercontent.com/u/7300226?v=3","gravatar_id":"","url":"https://api.github.com/users/twinkle-sachdeva","html_url":"https://github.com/twinkle-sachdeva","followers_url":"https://api.github.com/users/twinkle-sachdeva/followers","following_url":"https://api.github.com/users/twinkle-sachdeva/following{/other_user}","gists_url":"https://api.github.com/users/twinkle-sachdeva/gists{/gist_id}","starred_url":"https://api.github.com/users/twinkle-sachdeva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twinkle-sachdeva/subscriptions","organizations_url":"https://api.github.com/users/twinkle-sachdeva/orgs","repos_url":"https://api.github.com/users/twinkle-sachdeva/repos","events_url":"https://api.github.com/users/twinkle-sachdeva/events{/privacy}","received_events_url":"https://api.github.com/users/twinkle-sachdeva/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/twinkle-sachdeva/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/twinkle-sachdeva/spark","forks_url":"https://api.github.com/repos/twinkle-sachdeva/spark/forks","keys_url":"https://api.github.com/repos/twinkle-sachdeva/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twinkle-sachdeva/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twinkle-sachdeva/spark/teams","hooks_url":"https://api.github.com/repos/twinkle-sachdeva/spark/hooks","issue_events_url":"https://api.github.com/repos/twinkle-sachdeva/spark/issues/events{/number}","events_url":"https://api.github.com/repos/twinkle-sachdeva/spark/events","assignees_url":"https://api.github.com/repos/twinkle-sachdeva/spark/assignees{/user}","branches_url":"https://api.github.com/repos/twinkle-sachdeva/spark/branches{/branch}","tags_url":"https://api.github.com/repos/twinkle-sachdeva/spark/tags","blobs_url":"https://api.github.com/repos/twinkle-sachdeva/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twinkle-sachdeva/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twinkle-sachdeva/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/twinkle-sachdeva/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twinkle-sachdeva/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/twinkle-sachdeva/spark/languages","stargazers_url":"https://api.github.com/repos/twinkle-sachdeva/spark/stargazers","contributors_url":"https://api.github.com/repos/twinkle-sachdeva/spark/contributors","subscribers_url":"https://api.github.com/repos/twinkle-sachdeva/spark/subscribers","subscription_url":"https://api.github.com/repos/twinkle-sachdeva/spark/subscription","commits_url":"https://api.github.com/repos/twinkle-sachdeva/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/twinkle-sachdeva/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/twinkle-sachdeva/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/twinkle-sachdeva/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/twinkle-sachdeva/spark/contents/{+path}","compare_url":"https://api.github.com/repos/twinkle-sachdeva/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twinkle-sachdeva/spark/merges","archive_url":"https://api.github.com/repos/twinkle-sachdeva/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twinkle-sachdeva/spark/downloads","issues_url":"https://api.github.com/repos/twinkle-sachdeva/spark/issues{/number}","pulls_url":"https://api.github.com/repos/twinkle-sachdeva/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/twinkle-sachdeva/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/twinkle-sachdeva/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twinkle-sachdeva/spark/labels{/name}","releases_url":"https://api.github.com/repos/twinkle-sachdeva/spark/releases{/id}","created_at":"2014-07-24T06:46:45Z","updated_at":"2014-07-24T10:12:43Z","pushed_at":"2015-04-10T08:21:55Z","git_url":"git://github.com/twinkle-sachdeva/spark.git","ssh_url":"git@github.com:twinkle-sachdeva/spark.git","clone_url":"https://github.com/twinkle-sachdeva/spark.git","svn_url":"https://github.com/twinkle-sachdeva/spark","homepage":null,"size":96226,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"3290d2d13bb4bd875aec14425c8e3766f9cc644b","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-04-13T19:33:24Z","pushed_at":"2015-04-13T20:28:41Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1506691,"stargazers_count":3587,"watchers_count":3587,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3100,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":302,"forks":3100,"open_issues":302,"watchers":3587,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/5449"},"html":{"href":"https://github.com/apache/spark/pull/5449"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/5449"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/5449/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/5449/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/5449/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/4750a012bcdc2cb55770f6e75c52cc1e0d6041fb"}}}}