{"action":"closed","number":35,"pull_request":{"url":"https://api.github.com/repos/bigmlcom/closchema/pulls/35","id":50643376,"html_url":"https://github.com/bigmlcom/closchema/pull/35","diff_url":"https://github.com/bigmlcom/closchema/pull/35.diff","patch_url":"https://github.com/bigmlcom/closchema/pull/35.patch","issue_url":"https://api.github.com/repos/bigmlcom/closchema/issues/35","number":35,"state":"closed","locked":false,"title":"Should not accept an optional property with value null (unless null type)","user":{"login":"cburgmer","id":101613,"avatar_url":"https://avatars.githubusercontent.com/u/101613?v=3","gravatar_id":"","url":"https://api.github.com/users/cburgmer","html_url":"https://github.com/cburgmer","followers_url":"https://api.github.com/users/cburgmer/followers","following_url":"https://api.github.com/users/cburgmer/following{/other_user}","gists_url":"https://api.github.com/users/cburgmer/gists{/gist_id}","starred_url":"https://api.github.com/users/cburgmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cburgmer/subscriptions","organizations_url":"https://api.github.com/users/cburgmer/orgs","repos_url":"https://api.github.com/users/cburgmer/repos","events_url":"https://api.github.com/users/cburgmer/events{/privacy}","received_events_url":"https://api.github.com/users/cburgmer/received_events","type":"User","site_admin":false},"body":"It is my understanding that null values should be invalid, unless the `null` type is allowed. This matches (failing) examples like `{\"type\": \"string\"}` with `null` on http://jsonschemalint.com/draft4/.\r\n\r\nHowever currently\r\n\r\n```clj\r\nuser=> (schema/validate {:type \"string\"} nil)\r\ntrue\r\n```\r\n\r\nThis commit changes the behaviour to disallow `null`, removing code previously allowing `null` of the property was optional (maybe as specified in an older draft?).\r\n\r\nI have only added tests for `string` and `integer` types so far.","created_at":"2015-11-13T13:57:59Z","updated_at":"2015-11-13T16:46:02Z","closed_at":"2015-11-13T16:46:02Z","merged_at":"2015-11-13T16:46:02Z","merge_commit_sha":"fde8feb9f26b65547d9acb737a9368c04f76b717","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bigmlcom/closchema/pulls/35/commits","review_comments_url":"https://api.github.com/repos/bigmlcom/closchema/pulls/35/comments","review_comment_url":"https://api.github.com/repos/bigmlcom/closchema/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bigmlcom/closchema/issues/35/comments","statuses_url":"https://api.github.com/repos/bigmlcom/closchema/statuses/b44cd6d6bdfe203628f3cba913de7d25d8fdc9ab","head":{"label":"cburgmer:nilValidation","ref":"nilValidation","sha":"b44cd6d6bdfe203628f3cba913de7d25d8fdc9ab","user":{"login":"cburgmer","id":101613,"avatar_url":"https://avatars.githubusercontent.com/u/101613?v=3","gravatar_id":"","url":"https://api.github.com/users/cburgmer","html_url":"https://github.com/cburgmer","followers_url":"https://api.github.com/users/cburgmer/followers","following_url":"https://api.github.com/users/cburgmer/following{/other_user}","gists_url":"https://api.github.com/users/cburgmer/gists{/gist_id}","starred_url":"https://api.github.com/users/cburgmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cburgmer/subscriptions","organizations_url":"https://api.github.com/users/cburgmer/orgs","repos_url":"https://api.github.com/users/cburgmer/repos","events_url":"https://api.github.com/users/cburgmer/events{/privacy}","received_events_url":"https://api.github.com/users/cburgmer/received_events","type":"User","site_admin":false},"repo":{"id":46124380,"name":"closchema","full_name":"cburgmer/closchema","owner":{"login":"cburgmer","id":101613,"avatar_url":"https://avatars.githubusercontent.com/u/101613?v=3","gravatar_id":"","url":"https://api.github.com/users/cburgmer","html_url":"https://github.com/cburgmer","followers_url":"https://api.github.com/users/cburgmer/followers","following_url":"https://api.github.com/users/cburgmer/following{/other_user}","gists_url":"https://api.github.com/users/cburgmer/gists{/gist_id}","starred_url":"https://api.github.com/users/cburgmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cburgmer/subscriptions","organizations_url":"https://api.github.com/users/cburgmer/orgs","repos_url":"https://api.github.com/users/cburgmer/repos","events_url":"https://api.github.com/users/cburgmer/events{/privacy}","received_events_url":"https://api.github.com/users/cburgmer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cburgmer/closchema","description":"clojure json schema","fork":true,"url":"https://api.github.com/repos/cburgmer/closchema","forks_url":"https://api.github.com/repos/cburgmer/closchema/forks","keys_url":"https://api.github.com/repos/cburgmer/closchema/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cburgmer/closchema/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cburgmer/closchema/teams","hooks_url":"https://api.github.com/repos/cburgmer/closchema/hooks","issue_events_url":"https://api.github.com/repos/cburgmer/closchema/issues/events{/number}","events_url":"https://api.github.com/repos/cburgmer/closchema/events","assignees_url":"https://api.github.com/repos/cburgmer/closchema/assignees{/user}","branches_url":"https://api.github.com/repos/cburgmer/closchema/branches{/branch}","tags_url":"https://api.github.com/repos/cburgmer/closchema/tags","blobs_url":"https://api.github.com/repos/cburgmer/closchema/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cburgmer/closchema/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cburgmer/closchema/git/refs{/sha}","trees_url":"https://api.github.com/repos/cburgmer/closchema/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cburgmer/closchema/statuses/{sha}","languages_url":"https://api.github.com/repos/cburgmer/closchema/languages","stargazers_url":"https://api.github.com/repos/cburgmer/closchema/stargazers","contributors_url":"https://api.github.com/repos/cburgmer/closchema/contributors","subscribers_url":"https://api.github.com/repos/cburgmer/closchema/subscribers","subscription_url":"https://api.github.com/repos/cburgmer/closchema/subscription","commits_url":"https://api.github.com/repos/cburgmer/closchema/commits{/sha}","git_commits_url":"https://api.github.com/repos/cburgmer/closchema/git/commits{/sha}","comments_url":"https://api.github.com/repos/cburgmer/closchema/comments{/number}","issue_comment_url":"https://api.github.com/repos/cburgmer/closchema/issues/comments{/number}","contents_url":"https://api.github.com/repos/cburgmer/closchema/contents/{+path}","compare_url":"https://api.github.com/repos/cburgmer/closchema/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cburgmer/closchema/merges","archive_url":"https://api.github.com/repos/cburgmer/closchema/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cburgmer/closchema/downloads","issues_url":"https://api.github.com/repos/cburgmer/closchema/issues{/number}","pulls_url":"https://api.github.com/repos/cburgmer/closchema/pulls{/number}","milestones_url":"https://api.github.com/repos/cburgmer/closchema/milestones{/number}","notifications_url":"https://api.github.com/repos/cburgmer/closchema/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cburgmer/closchema/labels{/name}","releases_url":"https://api.github.com/repos/cburgmer/closchema/releases{/id}","created_at":"2015-11-13T13:46:30Z","updated_at":"2015-11-13T13:46:30Z","pushed_at":"2015-11-13T13:49:46Z","git_url":"git://github.com/cburgmer/closchema.git","ssh_url":"git@github.com:cburgmer/closchema.git","clone_url":"https://github.com/cburgmer/closchema.git","svn_url":"https://github.com/cburgmer/closchema","homepage":"","size":321,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bigmlcom:master","ref":"master","sha":"5aea7bc6d9e77262a095f119d01e463236dc5920","user":{"login":"bigmlcom","id":702185,"avatar_url":"https://avatars.githubusercontent.com/u/702185?v=3","gravatar_id":"","url":"https://api.github.com/users/bigmlcom","html_url":"https://github.com/bigmlcom","followers_url":"https://api.github.com/users/bigmlcom/followers","following_url":"https://api.github.com/users/bigmlcom/following{/other_user}","gists_url":"https://api.github.com/users/bigmlcom/gists{/gist_id}","starred_url":"https://api.github.com/users/bigmlcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigmlcom/subscriptions","organizations_url":"https://api.github.com/users/bigmlcom/orgs","repos_url":"https://api.github.com/users/bigmlcom/repos","events_url":"https://api.github.com/users/bigmlcom/events{/privacy}","received_events_url":"https://api.github.com/users/bigmlcom/received_events","type":"Organization","site_admin":false},"repo":{"id":1891591,"name":"closchema","full_name":"bigmlcom/closchema","owner":{"login":"bigmlcom","id":702185,"avatar_url":"https://avatars.githubusercontent.com/u/702185?v=3","gravatar_id":"","url":"https://api.github.com/users/bigmlcom","html_url":"https://github.com/bigmlcom","followers_url":"https://api.github.com/users/bigmlcom/followers","following_url":"https://api.github.com/users/bigmlcom/following{/other_user}","gists_url":"https://api.github.com/users/bigmlcom/gists{/gist_id}","starred_url":"https://api.github.com/users/bigmlcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigmlcom/subscriptions","organizations_url":"https://api.github.com/users/bigmlcom/orgs","repos_url":"https://api.github.com/users/bigmlcom/repos","events_url":"https://api.github.com/users/bigmlcom/events{/privacy}","received_events_url":"https://api.github.com/users/bigmlcom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bigmlcom/closchema","description":"clojure json schema","fork":true,"url":"https://api.github.com/repos/bigmlcom/closchema","forks_url":"https://api.github.com/repos/bigmlcom/closchema/forks","keys_url":"https://api.github.com/repos/bigmlcom/closchema/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bigmlcom/closchema/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bigmlcom/closchema/teams","hooks_url":"https://api.github.com/repos/bigmlcom/closchema/hooks","issue_events_url":"https://api.github.com/repos/bigmlcom/closchema/issues/events{/number}","events_url":"https://api.github.com/repos/bigmlcom/closchema/events","assignees_url":"https://api.github.com/repos/bigmlcom/closchema/assignees{/user}","branches_url":"https://api.github.com/repos/bigmlcom/closchema/branches{/branch}","tags_url":"https://api.github.com/repos/bigmlcom/closchema/tags","blobs_url":"https://api.github.com/repos/bigmlcom/closchema/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bigmlcom/closchema/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bigmlcom/closchema/git/refs{/sha}","trees_url":"https://api.github.com/repos/bigmlcom/closchema/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bigmlcom/closchema/statuses/{sha}","languages_url":"https://api.github.com/repos/bigmlcom/closchema/languages","stargazers_url":"https://api.github.com/repos/bigmlcom/closchema/stargazers","contributors_url":"https://api.github.com/repos/bigmlcom/closchema/contributors","subscribers_url":"https://api.github.com/repos/bigmlcom/closchema/subscribers","subscription_url":"https://api.github.com/repos/bigmlcom/closchema/subscription","commits_url":"https://api.github.com/repos/bigmlcom/closchema/commits{/sha}","git_commits_url":"https://api.github.com/repos/bigmlcom/closchema/git/commits{/sha}","comments_url":"https://api.github.com/repos/bigmlcom/closchema/comments{/number}","issue_comment_url":"https://api.github.com/repos/bigmlcom/closchema/issues/comments{/number}","contents_url":"https://api.github.com/repos/bigmlcom/closchema/contents/{+path}","compare_url":"https://api.github.com/repos/bigmlcom/closchema/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bigmlcom/closchema/merges","archive_url":"https://api.github.com/repos/bigmlcom/closchema/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bigmlcom/closchema/downloads","issues_url":"https://api.github.com/repos/bigmlcom/closchema/issues{/number}","pulls_url":"https://api.github.com/repos/bigmlcom/closchema/pulls{/number}","milestones_url":"https://api.github.com/repos/bigmlcom/closchema/milestones{/number}","notifications_url":"https://api.github.com/repos/bigmlcom/closchema/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bigmlcom/closchema/labels{/name}","releases_url":"https://api.github.com/repos/bigmlcom/closchema/releases{/id}","created_at":"2011-06-13T22:54:20Z","updated_at":"2015-11-01T01:06:58Z","pushed_at":"2015-11-13T16:46:02Z","git_url":"git://github.com/bigmlcom/closchema.git","ssh_url":"git@github.com:bigmlcom/closchema.git","clone_url":"https://github.com/bigmlcom/closchema.git","svn_url":"https://github.com/bigmlcom/closchema","homepage":"","size":321,"stargazers_count":35,"watchers_count":35,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":2,"forks":14,"open_issues":2,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bigmlcom/closchema/pulls/35"},"html":{"href":"https://github.com/bigmlcom/closchema/pull/35"},"issue":{"href":"https://api.github.com/repos/bigmlcom/closchema/issues/35"},"comments":{"href":"https://api.github.com/repos/bigmlcom/closchema/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/bigmlcom/closchema/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/bigmlcom/closchema/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bigmlcom/closchema/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/bigmlcom/closchema/statuses/b44cd6d6bdfe203628f3cba913de7d25d8fdc9ab"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jaor","id":80719,"avatar_url":"https://avatars.githubusercontent.com/u/80719?v=3","gravatar_id":"","url":"https://api.github.com/users/jaor","html_url":"https://github.com/jaor","followers_url":"https://api.github.com/users/jaor/followers","following_url":"https://api.github.com/users/jaor/following{/other_user}","gists_url":"https://api.github.com/users/jaor/gists{/gist_id}","starred_url":"https://api.github.com/users/jaor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaor/subscriptions","organizations_url":"https://api.github.com/users/jaor/orgs","repos_url":"https://api.github.com/users/jaor/repos","events_url":"https://api.github.com/users/jaor/events{/privacy}","received_events_url":"https://api.github.com/users/jaor/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":13,"deletions":12,"changed_files":2}}