{"action":"created","issue":{"url":"https://api.github.com/repos/cfpb/cf-layout/issues/18","labels_url":"https://api.github.com/repos/cfpb/cf-layout/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/cfpb/cf-layout/issues/18/comments","events_url":"https://api.github.com/repos/cfpb/cf-layout/issues/18/events","html_url":"https://github.com/cfpb/cf-layout/pull/18","id":108681876,"number":18,"title":"Add heroes","user":{"login":"virginiacc","id":778171,"avatar_url":"https://avatars.githubusercontent.com/u/778171?v=3","gravatar_id":"","url":"https://api.github.com/users/virginiacc","html_url":"https://github.com/virginiacc","followers_url":"https://api.github.com/users/virginiacc/followers","following_url":"https://api.github.com/users/virginiacc/following{/other_user}","gists_url":"https://api.github.com/users/virginiacc/gists{/gist_id}","starred_url":"https://api.github.com/users/virginiacc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virginiacc/subscriptions","organizations_url":"https://api.github.com/users/virginiacc/orgs","repos_url":"https://api.github.com/users/virginiacc/repos","events_url":"https://api.github.com/users/virginiacc/events{/privacy}","received_events_url":"https://api.github.com/users/virginiacc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-09-28T15:24:31Z","updated_at":"2015-09-30T21:21:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cfpb/cf-layout/pulls/18","html_url":"https://github.com/cfpb/cf-layout/pull/18","diff_url":"https://github.com/cfpb/cf-layout/pull/18.diff","patch_url":"https://github.com/cfpb/cf-layout/pull/18.patch"},"body":"Add hero.\r\n\r\n## Additions\r\n- Adds hero\r\n\r\n## Review\r\n@Scotchester\r\n\r\n## Screenshots\r\nDefault/mobile hero:\r\n<img width=\"500\" alt=\"screen shot 2015-09-28 at 7 58 14 am\" src=\"https://cloud.githubusercontent.com/assets/778171/10139227/bfd48b8c-65b6-11e5-80fc-6f8a38834bb9.png\">\r\n\r\nHero on tablet:\r\n<img width=\"786\" alt=\"screen shot 2015-09-28 at 7 57 58 am\" src=\"https://cloud.githubusercontent.com/assets/778171/10139231/c4ec317e-65b6-11e5-9e85-bbf1b9a6ea2b.png\">\r\n\r\n\r\nHero on desktop:\r\n<img width=\"1240\" alt=\"screen shot 2015-09-28 at 7 57 36 am\" src=\"https://cloud.githubusercontent.com/assets/778171/10139234/c98cb226-65b6-11e5-9914-420bd93b92bb.png\">\r\n\r\n\r\n## Notes\r\n- Hero background image is applied to a .hero_wrapper:after pseudo element with a fixed width rather than the hero wrapper itself in order to simplify horizontal centering of the image within the space allotted for it.\r\n- In the current implementation, other wrapper classes must be applied to the `.hero_wrapper` to set its max-width and margins/padding. This adds some flexibility & reduces code repetition, but it also means that the hero code is not entirely self-contained. It might make sense to add the wrapper code directly to the `.hero_wrapper` class.\r\n\r\n## Checklist\r\n\r\n* [X] Changes are limited to a single goal (no scope creep)\r\n* [X] Code can be automatically merged (no conflicts)\r\n* [X] Code follows the standards laid out in the [front end playbook](https://github.com/cfpb/front-end)\r\n* [ ] Passes all existing automated tests\r\n* [ ] New functions include new tests\r\n* [X] New functions are documented (with a description, list of inputs, and expected output)\r\n* [ ] Placeholder code is flagged\r\n* [X] Visually tested in supported browsers and devices \r\n* [ ] Project documentation has been updated (including the \"Unreleased\" section of the CHANGELOG)"},"comment":{"url":"https://api.github.com/repos/cfpb/cf-layout/issues/comments/144546424","html_url":"https://github.com/cfpb/cf-layout/pull/18#issuecomment-144546424","issue_url":"https://api.github.com/repos/cfpb/cf-layout/issues/18","id":144546424,"user":{"login":"jimmynotjim","id":1280430,"avatar_url":"https://avatars.githubusercontent.com/u/1280430?v=3","gravatar_id":"","url":"https://api.github.com/users/jimmynotjim","html_url":"https://github.com/jimmynotjim","followers_url":"https://api.github.com/users/jimmynotjim/followers","following_url":"https://api.github.com/users/jimmynotjim/following{/other_user}","gists_url":"https://api.github.com/users/jimmynotjim/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmynotjim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmynotjim/subscriptions","organizations_url":"https://api.github.com/users/jimmynotjim/orgs","repos_url":"https://api.github.com/users/jimmynotjim/repos","events_url":"https://api.github.com/users/jimmynotjim/events{/privacy}","received_events_url":"https://api.github.com/users/jimmynotjim/received_events","type":"User","site_admin":false},"created_at":"2015-09-30T21:21:29Z","updated_at":"2015-09-30T21:21:29Z","body":"Other than the note about using min-height instead of padding to ensure the hero is tall enough (and I might be misunderstanding that chunk) LGTM"}}