{"action":"created","comment":{"url":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/comments/35484566","id":35484566,"diff_hunk":"@@ -181,6 +187,117 @@ exports.getFunctionNodeFromIIFE = function(node) {\n };\n \n /**\n+ * Returns the type of AST node or ECMAScript production in which the provided\n+ * open parenthesis token is included.\n+ *\n+ * @param {Object} token\n+ * @param {JsFile} file\n+ * @returns {String}\n+ */\n+exports.categorizeOpenParen = function(token, file) {","path":"lib/utils.js","position":28,"original_position":28,"commit_id":"ace28ea2d5a17d07e8062acb86ffaaa2083f242f","original_commit_id":"ace28ea2d5a17d07e8062acb86ffaaa2083f242f","user":{"login":"gibson042","id":1199584,"avatar_url":"https://avatars.githubusercontent.com/u/1199584?v=3","gravatar_id":"","url":"https://api.github.com/users/gibson042","html_url":"https://github.com/gibson042","followers_url":"https://api.github.com/users/gibson042/followers","following_url":"https://api.github.com/users/gibson042/following{/other_user}","gists_url":"https://api.github.com/users/gibson042/gists{/gist_id}","starred_url":"https://api.github.com/users/gibson042/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gibson042/subscriptions","organizations_url":"https://api.github.com/users/gibson042/orgs","repos_url":"https://api.github.com/users/gibson042/repos","events_url":"https://api.github.com/users/gibson042/events{/privacy}","received_events_url":"https://api.github.com/users/gibson042/received_events","type":"User","site_admin":false},"body":"Good idea. So it would be analogous to string-checker.js or tree-iterator.js?","created_at":"2015-07-25T16:39:02Z","updated_at":"2015-07-25T16:39:02Z","html_url":"https://github.com/jscs-dev/node-jscs/pull/1254#discussion_r35484566","pull_request_url":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/1254","_links":{"self":{"href":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/comments/35484566"},"html":{"href":"https://github.com/jscs-dev/node-jscs/pull/1254#discussion_r35484566"},"pull_request":{"href":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/1254"}}},"pull_request":{"url":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/1254","id":33029321,"html_url":"https://github.com/jscs-dev/node-jscs/pull/1254","diff_url":"https://github.com/jscs-dev/node-jscs/pull/1254.diff","patch_url":"https://github.com/jscs-dev/node-jscs/pull/1254.patch","issue_url":"https://api.github.com/repos/jscs-dev/node-jscs/issues/1254","number":1254,"state":"open","locked":false,"title":"[POC] New Rule: requireSpacesInsideParenthesizedExpression","user":{"login":"gibson042","id":1199584,"avatar_url":"https://avatars.githubusercontent.com/u/1199584?v=3","gravatar_id":"","url":"https://api.github.com/users/gibson042","html_url":"https://github.com/gibson042","followers_url":"https://api.github.com/users/gibson042/followers","following_url":"https://api.github.com/users/gibson042/following{/other_user}","gists_url":"https://api.github.com/users/gibson042/gists{/gist_id}","starred_url":"https://api.github.com/users/gibson042/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gibson042/subscriptions","organizations_url":"https://api.github.com/users/gibson042/orgs","repos_url":"https://api.github.com/users/gibson042/repos","events_url":"https://api.github.com/users/gibson042/events{/privacy}","received_events_url":"https://api.github.com/users/gibson042/received_events","type":"User","site_admin":false},"body":"A proof of concept for distinguishing the several parenthetical productions (statement affix, function definition parameters, function call arguments, and arbitrary expressions), inspired by https://github.com/jquery/sizzle/pull/330/files#r27985694 . This PR implements only **requireSpacesInsideParenthesizedExpression**, but if you like the concepts herein I will add **disallowSpacesInsideParenthesizedExpression** so it can merge.\r\n\r\nThe obvious next step is to introduce similar pairs for **SpacesInsideParenthesizedArguments**, **SpacesInsideParenthesizedParameters**, and **SpacesInsideParenthesizedStatement** (names subject to change, but chosen for convenient alphabetic grouping) in a pattern analogous to that embodied by the \"**SpacesInFunction**\" rules but rooted at \"**SpacesInsideParentheses**\".\r\n\r\nI believe this also relates to existing work:\r\nRef https://github.com/jscs-dev/node-jscs/pull/1069#discussion_r24805456\r\nRef gh-812\r\nRef gh-431","created_at":"2015-04-10T09:03:48Z","updated_at":"2015-07-25T16:39:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d22132decb8b7d3d2cf2d554d84e699495cf1ae","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/1254/commits","review_comments_url":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/1254/comments","review_comment_url":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jscs-dev/node-jscs/issues/1254/comments","statuses_url":"https://api.github.com/repos/jscs-dev/node-jscs/statuses/ace28ea2d5a17d07e8062acb86ffaaa2083f242f","head":{"label":"gibson042:spaces-inside-parenthesized-expression","ref":"spaces-inside-parenthesized-expression","sha":"ace28ea2d5a17d07e8062acb86ffaaa2083f242f","user":{"login":"gibson042","id":1199584,"avatar_url":"https://avatars.githubusercontent.com/u/1199584?v=3","gravatar_id":"","url":"https://api.github.com/users/gibson042","html_url":"https://github.com/gibson042","followers_url":"https://api.github.com/users/gibson042/followers","following_url":"https://api.github.com/users/gibson042/following{/other_user}","gists_url":"https://api.github.com/users/gibson042/gists{/gist_id}","starred_url":"https://api.github.com/users/gibson042/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gibson042/subscriptions","organizations_url":"https://api.github.com/users/gibson042/orgs","repos_url":"https://api.github.com/users/gibson042/repos","events_url":"https://api.github.com/users/gibson042/events{/privacy}","received_events_url":"https://api.github.com/users/gibson042/received_events","type":"User","site_admin":false},"repo":{"id":33706145,"name":"node-jscs","full_name":"gibson042/node-jscs","owner":{"login":"gibson042","id":1199584,"avatar_url":"https://avatars.githubusercontent.com/u/1199584?v=3","gravatar_id":"","url":"https://api.github.com/users/gibson042","html_url":"https://github.com/gibson042","followers_url":"https://api.github.com/users/gibson042/followers","following_url":"https://api.github.com/users/gibson042/following{/other_user}","gists_url":"https://api.github.com/users/gibson042/gists{/gist_id}","starred_url":"https://api.github.com/users/gibson042/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gibson042/subscriptions","organizations_url":"https://api.github.com/users/gibson042/orgs","repos_url":"https://api.github.com/users/gibson042/repos","events_url":"https://api.github.com/users/gibson042/events{/privacy}","received_events_url":"https://api.github.com/users/gibson042/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gibson042/node-jscs","description":"JavaScript Code Style checker","fork":true,"url":"https://api.github.com/repos/gibson042/node-jscs","forks_url":"https://api.github.com/repos/gibson042/node-jscs/forks","keys_url":"https://api.github.com/repos/gibson042/node-jscs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gibson042/node-jscs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gibson042/node-jscs/teams","hooks_url":"https://api.github.com/repos/gibson042/node-jscs/hooks","issue_events_url":"https://api.github.com/repos/gibson042/node-jscs/issues/events{/number}","events_url":"https://api.github.com/repos/gibson042/node-jscs/events","assignees_url":"https://api.github.com/repos/gibson042/node-jscs/assignees{/user}","branches_url":"https://api.github.com/repos/gibson042/node-jscs/branches{/branch}","tags_url":"https://api.github.com/repos/gibson042/node-jscs/tags","blobs_url":"https://api.github.com/repos/gibson042/node-jscs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gibson042/node-jscs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gibson042/node-jscs/git/refs{/sha}","trees_url":"https://api.github.com/repos/gibson042/node-jscs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gibson042/node-jscs/statuses/{sha}","languages_url":"https://api.github.com/repos/gibson042/node-jscs/languages","stargazers_url":"https://api.github.com/repos/gibson042/node-jscs/stargazers","contributors_url":"https://api.github.com/repos/gibson042/node-jscs/contributors","subscribers_url":"https://api.github.com/repos/gibson042/node-jscs/subscribers","subscription_url":"https://api.github.com/repos/gibson042/node-jscs/subscription","commits_url":"https://api.github.com/repos/gibson042/node-jscs/commits{/sha}","git_commits_url":"https://api.github.com/repos/gibson042/node-jscs/git/commits{/sha}","comments_url":"https://api.github.com/repos/gibson042/node-jscs/comments{/number}","issue_comment_url":"https://api.github.com/repos/gibson042/node-jscs/issues/comments{/number}","contents_url":"https://api.github.com/repos/gibson042/node-jscs/contents/{+path}","compare_url":"https://api.github.com/repos/gibson042/node-jscs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gibson042/node-jscs/merges","archive_url":"https://api.github.com/repos/gibson042/node-jscs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gibson042/node-jscs/downloads","issues_url":"https://api.github.com/repos/gibson042/node-jscs/issues{/number}","pulls_url":"https://api.github.com/repos/gibson042/node-jscs/pulls{/number}","milestones_url":"https://api.github.com/repos/gibson042/node-jscs/milestones{/number}","notifications_url":"https://api.github.com/repos/gibson042/node-jscs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gibson042/node-jscs/labels{/name}","releases_url":"https://api.github.com/repos/gibson042/node-jscs/releases{/id}","created_at":"2015-04-10T03:22:15Z","updated_at":"2015-04-10T03:22:16Z","pushed_at":"2015-07-01T14:36:16Z","git_url":"git://github.com/gibson042/node-jscs.git","ssh_url":"git@github.com:gibson042/node-jscs.git","clone_url":"https://github.com/gibson042/node-jscs.git","svn_url":"https://github.com/gibson042/node-jscs","homepage":"http://jscs.info/","size":2867,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jscs-dev:master","ref":"master","sha":"2d5745fd4d04305aece786a3339da3eeb1e60305","user":{"login":"jscs-dev","id":8018201,"avatar_url":"https://avatars.githubusercontent.com/u/8018201?v=3","gravatar_id":"","url":"https://api.github.com/users/jscs-dev","html_url":"https://github.com/jscs-dev","followers_url":"https://api.github.com/users/jscs-dev/followers","following_url":"https://api.github.com/users/jscs-dev/following{/other_user}","gists_url":"https://api.github.com/users/jscs-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/jscs-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jscs-dev/subscriptions","organizations_url":"https://api.github.com/users/jscs-dev/orgs","repos_url":"https://api.github.com/users/jscs-dev/repos","events_url":"https://api.github.com/users/jscs-dev/events{/privacy}","received_events_url":"https://api.github.com/users/jscs-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":10697582,"name":"node-jscs","full_name":"jscs-dev/node-jscs","owner":{"login":"jscs-dev","id":8018201,"avatar_url":"https://avatars.githubusercontent.com/u/8018201?v=3","gravatar_id":"","url":"https://api.github.com/users/jscs-dev","html_url":"https://github.com/jscs-dev","followers_url":"https://api.github.com/users/jscs-dev/followers","following_url":"https://api.github.com/users/jscs-dev/following{/other_user}","gists_url":"https://api.github.com/users/jscs-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/jscs-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jscs-dev/subscriptions","organizations_url":"https://api.github.com/users/jscs-dev/orgs","repos_url":"https://api.github.com/users/jscs-dev/repos","events_url":"https://api.github.com/users/jscs-dev/events{/privacy}","received_events_url":"https://api.github.com/users/jscs-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jscs-dev/node-jscs","description":"JavaScript Code Style checker","fork":false,"url":"https://api.github.com/repos/jscs-dev/node-jscs","forks_url":"https://api.github.com/repos/jscs-dev/node-jscs/forks","keys_url":"https://api.github.com/repos/jscs-dev/node-jscs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jscs-dev/node-jscs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jscs-dev/node-jscs/teams","hooks_url":"https://api.github.com/repos/jscs-dev/node-jscs/hooks","issue_events_url":"https://api.github.com/repos/jscs-dev/node-jscs/issues/events{/number}","events_url":"https://api.github.com/repos/jscs-dev/node-jscs/events","assignees_url":"https://api.github.com/repos/jscs-dev/node-jscs/assignees{/user}","branches_url":"https://api.github.com/repos/jscs-dev/node-jscs/branches{/branch}","tags_url":"https://api.github.com/repos/jscs-dev/node-jscs/tags","blobs_url":"https://api.github.com/repos/jscs-dev/node-jscs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jscs-dev/node-jscs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jscs-dev/node-jscs/git/refs{/sha}","trees_url":"https://api.github.com/repos/jscs-dev/node-jscs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jscs-dev/node-jscs/statuses/{sha}","languages_url":"https://api.github.com/repos/jscs-dev/node-jscs/languages","stargazers_url":"https://api.github.com/repos/jscs-dev/node-jscs/stargazers","contributors_url":"https://api.github.com/repos/jscs-dev/node-jscs/contributors","subscribers_url":"https://api.github.com/repos/jscs-dev/node-jscs/subscribers","subscription_url":"https://api.github.com/repos/jscs-dev/node-jscs/subscription","commits_url":"https://api.github.com/repos/jscs-dev/node-jscs/commits{/sha}","git_commits_url":"https://api.github.com/repos/jscs-dev/node-jscs/git/commits{/sha}","comments_url":"https://api.github.com/repos/jscs-dev/node-jscs/comments{/number}","issue_comment_url":"https://api.github.com/repos/jscs-dev/node-jscs/issues/comments{/number}","contents_url":"https://api.github.com/repos/jscs-dev/node-jscs/contents/{+path}","compare_url":"https://api.github.com/repos/jscs-dev/node-jscs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jscs-dev/node-jscs/merges","archive_url":"https://api.github.com/repos/jscs-dev/node-jscs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jscs-dev/node-jscs/downloads","issues_url":"https://api.github.com/repos/jscs-dev/node-jscs/issues{/number}","pulls_url":"https://api.github.com/repos/jscs-dev/node-jscs/pulls{/number}","milestones_url":"https://api.github.com/repos/jscs-dev/node-jscs/milestones{/number}","notifications_url":"https://api.github.com/repos/jscs-dev/node-jscs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jscs-dev/node-jscs/labels{/name}","releases_url":"https://api.github.com/repos/jscs-dev/node-jscs/releases{/id}","created_at":"2013-06-14T20:53:48Z","updated_at":"2015-07-25T11:06:34Z","pushed_at":"2015-07-25T12:15:26Z","git_url":"git://github.com/jscs-dev/node-jscs.git","ssh_url":"git@github.com:jscs-dev/node-jscs.git","clone_url":"https://github.com/jscs-dev/node-jscs.git","svn_url":"https://github.com/jscs-dev/node-jscs","homepage":"http://jscs.info/","size":11490,"stargazers_count":3808,"watchers_count":3808,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":373,"mirror_url":null,"open_issues_count":171,"forks":373,"open_issues":171,"watchers":3808,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/1254"},"html":{"href":"https://github.com/jscs-dev/node-jscs/pull/1254"},"issue":{"href":"https://api.github.com/repos/jscs-dev/node-jscs/issues/1254"},"comments":{"href":"https://api.github.com/repos/jscs-dev/node-jscs/issues/1254/comments"},"review_comments":{"href":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/1254/comments"},"review_comment":{"href":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/1254/commits"},"statuses":{"href":"https://api.github.com/repos/jscs-dev/node-jscs/statuses/ace28ea2d5a17d07e8062acb86ffaaa2083f242f"}}}}