{"action":"created","comment":{"url":"https://api.github.com/repos/cedricpinson/osgjs/pulls/comments/23951623","id":23951623,"diff_hunk":"@@ -1184,6 +1441,29 @@ define( [\n             return vectorsArray;\n         },\n \n+        // better precison\n+        // no far clipping artifacts.\n+        // no reason not to use.\n+        // Tightening the Precision of Perspective Rendering\n+        //http://www.geometry.caltech.edu/pubs/UD12.pdf\n+        // drop-in, just remove the one below, and rename this one\n+        makeInfiniteFrustum: function ( left, right, bottom, top, znear, zfar, result ) {","path":"sources/osg/Matrix.js","position":417,"original_position":417,"commit_id":"3f2fd9a639c4e2e2b7a72248fb192a375a442da9","original_commit_id":"3f2fd9a639c4e2e2b7a72248fb192a375a442da9","user":{"login":"cedricpinson","id":351686,"avatar_url":"https://avatars.githubusercontent.com/u/351686?v=3","gravatar_id":"","url":"https://api.github.com/users/cedricpinson","html_url":"https://github.com/cedricpinson","followers_url":"https://api.github.com/users/cedricpinson/followers","following_url":"https://api.github.com/users/cedricpinson/following{/other_user}","gists_url":"https://api.github.com/users/cedricpinson/gists{/gist_id}","starred_url":"https://api.github.com/users/cedricpinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cedricpinson/subscriptions","organizations_url":"https://api.github.com/users/cedricpinson/orgs","repos_url":"https://api.github.com/users/cedricpinson/repos","events_url":"https://api.github.com/users/cedricpinson/events{/privacy}","received_events_url":"https://api.github.com/users/cedricpinson/received_events","type":"User","site_admin":false},"body":"I would prefer to keep method start the same way, like makeFrustumInfinite or something like that, it's more convenient.","created_at":"2015-02-02T19:39:50Z","updated_at":"2015-02-02T19:39:50Z","html_url":"https://github.com/cedricpinson/osgjs/pull/237#discussion_r23951623","pull_request_url":"https://api.github.com/repos/cedricpinson/osgjs/pulls/237","_links":{"self":{"href":"https://api.github.com/repos/cedricpinson/osgjs/pulls/comments/23951623"},"html":{"href":"https://github.com/cedricpinson/osgjs/pull/237#discussion_r23951623"},"pull_request":{"href":"https://api.github.com/repos/cedricpinson/osgjs/pulls/237"}}},"pull_request":{"url":"https://api.github.com/repos/cedricpinson/osgjs/pulls/237","id":28460944,"html_url":"https://github.com/cedricpinson/osgjs/pull/237","diff_url":"https://github.com/cedricpinson/osgjs/pull/237.diff","patch_url":"https://github.com/cedricpinson/osgjs/pull/237.patch","issue_url":"https://api.github.com/repos/cedricpinson/osgjs/issues/237","number":237,"state":"open","locked":false,"title":"Feature/multifrustum","user":{"login":"Kuranes","id":128571,"avatar_url":"https://avatars.githubusercontent.com/u/128571?v=3","gravatar_id":"","url":"https://api.github.com/users/Kuranes","html_url":"https://github.com/Kuranes","followers_url":"https://api.github.com/users/Kuranes/followers","following_url":"https://api.github.com/users/Kuranes/following{/other_user}","gists_url":"https://api.github.com/users/Kuranes/gists{/gist_id}","starred_url":"https://api.github.com/users/Kuranes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kuranes/subscriptions","organizations_url":"https://api.github.com/users/Kuranes/orgs","repos_url":"https://api.github.com/users/Kuranes/repos","events_url":"https://api.github.com/users/Kuranes/events{/privacy}","received_events_url":"https://api.github.com/users/Kuranes/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-02-02T11:23:10Z","updated_at":"2015-02-02T19:39:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52827479d5c1d63c80d04f585ef408800e7b10d7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cedricpinson/osgjs/pulls/237/commits","review_comments_url":"https://api.github.com/repos/cedricpinson/osgjs/pulls/237/comments","review_comment_url":"https://api.github.com/repos/cedricpinson/osgjs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cedricpinson/osgjs/issues/237/comments","statuses_url":"https://api.github.com/repos/cedricpinson/osgjs/statuses/3f2fd9a639c4e2e2b7a72248fb192a375a442da9","head":{"label":"cedricpinson:feature/multifrustum","ref":"feature/multifrustum","sha":"3f2fd9a639c4e2e2b7a72248fb192a375a442da9","user":{"login":"cedricpinson","id":351686,"avatar_url":"https://avatars.githubusercontent.com/u/351686?v=3","gravatar_id":"","url":"https://api.github.com/users/cedricpinson","html_url":"https://github.com/cedricpinson","followers_url":"https://api.github.com/users/cedricpinson/followers","following_url":"https://api.github.com/users/cedricpinson/following{/other_user}","gists_url":"https://api.github.com/users/cedricpinson/gists{/gist_id}","starred_url":"https://api.github.com/users/cedricpinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cedricpinson/subscriptions","organizations_url":"https://api.github.com/users/cedricpinson/orgs","repos_url":"https://api.github.com/users/cedricpinson/repos","events_url":"https://api.github.com/users/cedricpinson/events{/privacy}","received_events_url":"https://api.github.com/users/cedricpinson/received_events","type":"User","site_admin":false},"repo":{"id":1675632,"name":"osgjs","full_name":"cedricpinson/osgjs","owner":{"login":"cedricpinson","id":351686,"avatar_url":"https://avatars.githubusercontent.com/u/351686?v=3","gravatar_id":"","url":"https://api.github.com/users/cedricpinson","html_url":"https://github.com/cedricpinson","followers_url":"https://api.github.com/users/cedricpinson/followers","following_url":"https://api.github.com/users/cedricpinson/following{/other_user}","gists_url":"https://api.github.com/users/cedricpinson/gists{/gist_id}","starred_url":"https://api.github.com/users/cedricpinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cedricpinson/subscriptions","organizations_url":"https://api.github.com/users/cedricpinson/orgs","repos_url":"https://api.github.com/users/cedricpinson/repos","events_url":"https://api.github.com/users/cedricpinson/events{/privacy}","received_events_url":"https://api.github.com/users/cedricpinson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cedricpinson/osgjs","description":"Javascript Implementation of OpenSceneGraph","fork":false,"url":"https://api.github.com/repos/cedricpinson/osgjs","forks_url":"https://api.github.com/repos/cedricpinson/osgjs/forks","keys_url":"https://api.github.com/repos/cedricpinson/osgjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cedricpinson/osgjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cedricpinson/osgjs/teams","hooks_url":"https://api.github.com/repos/cedricpinson/osgjs/hooks","issue_events_url":"https://api.github.com/repos/cedricpinson/osgjs/issues/events{/number}","events_url":"https://api.github.com/repos/cedricpinson/osgjs/events","assignees_url":"https://api.github.com/repos/cedricpinson/osgjs/assignees{/user}","branches_url":"https://api.github.com/repos/cedricpinson/osgjs/branches{/branch}","tags_url":"https://api.github.com/repos/cedricpinson/osgjs/tags","blobs_url":"https://api.github.com/repos/cedricpinson/osgjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cedricpinson/osgjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cedricpinson/osgjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/cedricpinson/osgjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cedricpinson/osgjs/statuses/{sha}","languages_url":"https://api.github.com/repos/cedricpinson/osgjs/languages","stargazers_url":"https://api.github.com/repos/cedricpinson/osgjs/stargazers","contributors_url":"https://api.github.com/repos/cedricpinson/osgjs/contributors","subscribers_url":"https://api.github.com/repos/cedricpinson/osgjs/subscribers","subscription_url":"https://api.github.com/repos/cedricpinson/osgjs/subscription","commits_url":"https://api.github.com/repos/cedricpinson/osgjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/cedricpinson/osgjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/cedricpinson/osgjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/cedricpinson/osgjs/issues/comments/{number}","contents_url":"https://api.github.com/repos/cedricpinson/osgjs/contents/{+path}","compare_url":"https://api.github.com/repos/cedricpinson/osgjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cedricpinson/osgjs/merges","archive_url":"https://api.github.com/repos/cedricpinson/osgjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cedricpinson/osgjs/downloads","issues_url":"https://api.github.com/repos/cedricpinson/osgjs/issues{/number}","pulls_url":"https://api.github.com/repos/cedricpinson/osgjs/pulls{/number}","milestones_url":"https://api.github.com/repos/cedricpinson/osgjs/milestones{/number}","notifications_url":"https://api.github.com/repos/cedricpinson/osgjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cedricpinson/osgjs/labels{/name}","releases_url":"https://api.github.com/repos/cedricpinson/osgjs/releases{/id}","created_at":"2011-04-28T12:36:33Z","updated_at":"2015-02-02T15:11:33Z","pushed_at":"2015-02-02T18:23:52Z","git_url":"git://github.com/cedricpinson/osgjs.git","ssh_url":"git@github.com:cedricpinson/osgjs.git","clone_url":"https://github.com/cedricpinson/osgjs.git","svn_url":"https://github.com/cedricpinson/osgjs","homepage":"http://osgjs.org","size":161324,"stargazers_count":175,"watchers_count":175,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":40,"mirror_url":null,"open_issues_count":15,"forks":40,"open_issues":15,"watchers":175,"default_branch":"develop"}},"base":{"label":"cedricpinson:develop","ref":"develop","sha":"b68c429e380276d67bd39179be3fe006d23072d4","user":{"login":"cedricpinson","id":351686,"avatar_url":"https://avatars.githubusercontent.com/u/351686?v=3","gravatar_id":"","url":"https://api.github.com/users/cedricpinson","html_url":"https://github.com/cedricpinson","followers_url":"https://api.github.com/users/cedricpinson/followers","following_url":"https://api.github.com/users/cedricpinson/following{/other_user}","gists_url":"https://api.github.com/users/cedricpinson/gists{/gist_id}","starred_url":"https://api.github.com/users/cedricpinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cedricpinson/subscriptions","organizations_url":"https://api.github.com/users/cedricpinson/orgs","repos_url":"https://api.github.com/users/cedricpinson/repos","events_url":"https://api.github.com/users/cedricpinson/events{/privacy}","received_events_url":"https://api.github.com/users/cedricpinson/received_events","type":"User","site_admin":false},"repo":{"id":1675632,"name":"osgjs","full_name":"cedricpinson/osgjs","owner":{"login":"cedricpinson","id":351686,"avatar_url":"https://avatars.githubusercontent.com/u/351686?v=3","gravatar_id":"","url":"https://api.github.com/users/cedricpinson","html_url":"https://github.com/cedricpinson","followers_url":"https://api.github.com/users/cedricpinson/followers","following_url":"https://api.github.com/users/cedricpinson/following{/other_user}","gists_url":"https://api.github.com/users/cedricpinson/gists{/gist_id}","starred_url":"https://api.github.com/users/cedricpinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cedricpinson/subscriptions","organizations_url":"https://api.github.com/users/cedricpinson/orgs","repos_url":"https://api.github.com/users/cedricpinson/repos","events_url":"https://api.github.com/users/cedricpinson/events{/privacy}","received_events_url":"https://api.github.com/users/cedricpinson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cedricpinson/osgjs","description":"Javascript Implementation of OpenSceneGraph","fork":false,"url":"https://api.github.com/repos/cedricpinson/osgjs","forks_url":"https://api.github.com/repos/cedricpinson/osgjs/forks","keys_url":"https://api.github.com/repos/cedricpinson/osgjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cedricpinson/osgjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cedricpinson/osgjs/teams","hooks_url":"https://api.github.com/repos/cedricpinson/osgjs/hooks","issue_events_url":"https://api.github.com/repos/cedricpinson/osgjs/issues/events{/number}","events_url":"https://api.github.com/repos/cedricpinson/osgjs/events","assignees_url":"https://api.github.com/repos/cedricpinson/osgjs/assignees{/user}","branches_url":"https://api.github.com/repos/cedricpinson/osgjs/branches{/branch}","tags_url":"https://api.github.com/repos/cedricpinson/osgjs/tags","blobs_url":"https://api.github.com/repos/cedricpinson/osgjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cedricpinson/osgjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cedricpinson/osgjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/cedricpinson/osgjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cedricpinson/osgjs/statuses/{sha}","languages_url":"https://api.github.com/repos/cedricpinson/osgjs/languages","stargazers_url":"https://api.github.com/repos/cedricpinson/osgjs/stargazers","contributors_url":"https://api.github.com/repos/cedricpinson/osgjs/contributors","subscribers_url":"https://api.github.com/repos/cedricpinson/osgjs/subscribers","subscription_url":"https://api.github.com/repos/cedricpinson/osgjs/subscription","commits_url":"https://api.github.com/repos/cedricpinson/osgjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/cedricpinson/osgjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/cedricpinson/osgjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/cedricpinson/osgjs/issues/comments/{number}","contents_url":"https://api.github.com/repos/cedricpinson/osgjs/contents/{+path}","compare_url":"https://api.github.com/repos/cedricpinson/osgjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cedricpinson/osgjs/merges","archive_url":"https://api.github.com/repos/cedricpinson/osgjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cedricpinson/osgjs/downloads","issues_url":"https://api.github.com/repos/cedricpinson/osgjs/issues{/number}","pulls_url":"https://api.github.com/repos/cedricpinson/osgjs/pulls{/number}","milestones_url":"https://api.github.com/repos/cedricpinson/osgjs/milestones{/number}","notifications_url":"https://api.github.com/repos/cedricpinson/osgjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cedricpinson/osgjs/labels{/name}","releases_url":"https://api.github.com/repos/cedricpinson/osgjs/releases{/id}","created_at":"2011-04-28T12:36:33Z","updated_at":"2015-02-02T15:11:33Z","pushed_at":"2015-02-02T18:23:52Z","git_url":"git://github.com/cedricpinson/osgjs.git","ssh_url":"git@github.com:cedricpinson/osgjs.git","clone_url":"https://github.com/cedricpinson/osgjs.git","svn_url":"https://github.com/cedricpinson/osgjs","homepage":"http://osgjs.org","size":161324,"stargazers_count":175,"watchers_count":175,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":40,"mirror_url":null,"open_issues_count":15,"forks":40,"open_issues":15,"watchers":175,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cedricpinson/osgjs/pulls/237"},"html":{"href":"https://github.com/cedricpinson/osgjs/pull/237"},"issue":{"href":"https://api.github.com/repos/cedricpinson/osgjs/issues/237"},"comments":{"href":"https://api.github.com/repos/cedricpinson/osgjs/issues/237/comments"},"review_comments":{"href":"https://api.github.com/repos/cedricpinson/osgjs/pulls/237/comments"},"review_comment":{"href":"https://api.github.com/repos/cedricpinson/osgjs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cedricpinson/osgjs/pulls/237/commits"},"statuses":{"href":"https://api.github.com/repos/cedricpinson/osgjs/statuses/3f2fd9a639c4e2e2b7a72248fb192a375a442da9"}}}}