{"action":"created","comment":{"url":"https://api.github.com/repos/daboesch/ROC/pulls/comments/31414550","id":31414550,"diff_hunk":"@@ -120,153 +122,150 @@ feature -- Query\n \t\t\tend\n \t\tend\n \n-\ttotal_entries : NATURAL_32\n-\t\t\t-- Returns the number of total entries/posts\n+\ttotal_entries: NATURAL_32\n+\t\t\t-- Total number of entries/posts.\n \t\tdo\n-\t\t\tResult := node_api.blogs_count.to_natural_32\n+\t\t\tResult := blog_api.blogs_count.to_natural_32\n \t\tend\n \n feature -- HTML Output\n \n-\tmain_content_html (page: CMS_RESPONSE) : STRING\n-\t\t\t-- Return the content of the page as a html string\n+\tfrozen main_content_html (page: CMS_RESPONSE): STRING\n+\t\t\t-- Content of the page as a html string.\n+\t\tdo\n+\t\t\tcreate Result.make_empty\n+\t\t\tappend_main_content_html_to (page, Result)\n+\t\tend\n+\n+\tappend_main_content_html_to (page: CMS_RESPONSE; a_output: STRING)","path":"examples/demo/modules/blog/handler/blog_handler.e","position":123,"original_position":123,"commit_id":"c871eae10e535cb38c1b535d84d7ae6b86eae63b","original_commit_id":"c871eae10e535cb38c1b535d84d7ae6b86eae63b","user":{"login":"jocelyn","id":31598,"avatar_url":"https://avatars.githubusercontent.com/u/31598?v=3","gravatar_id":"","url":"https://api.github.com/users/jocelyn","html_url":"https://github.com/jocelyn","followers_url":"https://api.github.com/users/jocelyn/followers","following_url":"https://api.github.com/users/jocelyn/following{/other_user}","gists_url":"https://api.github.com/users/jocelyn/gists{/gist_id}","starred_url":"https://api.github.com/users/jocelyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jocelyn/subscriptions","organizations_url":"https://api.github.com/users/jocelyn/orgs","repos_url":"https://api.github.com/users/jocelyn/repos","events_url":"https://api.github.com/users/jocelyn/events{/privacy}","received_events_url":"https://api.github.com/users/jocelyn/received_events","type":"User","site_admin":false},"body":"As an additional comment, \r\na_output.append (\"abc\" + a_string + \"def\")\r\nshould be replaced by \r\na_output.append (\"abc\")\r\na_output.append (a_string)\r\na_output.append (\"def\")\r\nto avoid intermediate string object creation.\r\n\r\nBUT ... sometime this is not that critical; and we favor the readability of the code.\r\n","created_at":"2015-06-01T10:31:30Z","updated_at":"2015-06-01T10:31:30Z","html_url":"https://github.com/daboesch/ROC/pull/9#discussion_r31414550","pull_request_url":"https://api.github.com/repos/daboesch/ROC/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/daboesch/ROC/pulls/comments/31414550"},"html":{"href":"https://github.com/daboesch/ROC/pull/9#discussion_r31414550"},"pull_request":{"href":"https://api.github.com/repos/daboesch/ROC/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/daboesch/ROC/pulls/9","id":36349233,"html_url":"https://github.com/daboesch/ROC/pull/9","diff_url":"https://github.com/daboesch/ROC/pull/9.diff","patch_url":"https://github.com/daboesch/ROC/pull/9.patch","issue_url":"https://api.github.com/repos/daboesch/ROC/issues/9","number":9,"state":"open","locked":false,"title":"First code review","user":{"login":"jocelyn","id":31598,"avatar_url":"https://avatars.githubusercontent.com/u/31598?v=3","gravatar_id":"","url":"https://api.github.com/users/jocelyn","html_url":"https://github.com/jocelyn","followers_url":"https://api.github.com/users/jocelyn/followers","following_url":"https://api.github.com/users/jocelyn/following{/other_user}","gists_url":"https://api.github.com/users/jocelyn/gists{/gist_id}","starred_url":"https://api.github.com/users/jocelyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jocelyn/subscriptions","organizations_url":"https://api.github.com/users/jocelyn/orgs","repos_url":"https://api.github.com/users/jocelyn/repos","events_url":"https://api.github.com/users/jocelyn/events{/privacy}","received_events_url":"https://api.github.com/users/jocelyn/received_events","type":"User","site_admin":false},"body":"Renamed node_api and node_storage by blog_api and blog_storage in related CMS_BLOG_* classes. Mainly to avoid confusion with NODE_ classes.\r\n\r\nMerged CMS_BLOG_CONFIG with CMS_BLOG_API.\r\nIn CMS_BLOG_API, prefer argument of type CMS_USER, rather than using directly user id.\r\nAdded a CMS_EDITOR_CONTENT_FORMAT for now, to be the format editable by the WYSIWYG editor.\r\nAdded CMS_MODULE.is_initialized: BOOLEAN to equip router, and module_api with expected preconditions.\r\n\r\nFixed typo, especially in log output.\r\nCorrected a few routine names such as add_authors that should not be a function according to its name.\r\nConverted various function returning html content, to procedure appending html content to an output string to minimize temporary string object creation.\r\nCosmetic: added spaces to make code easier to read, and indentation.","created_at":"2015-05-27T21:12:24Z","updated_at":"2015-06-01T10:31:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f7f27fec25cca9fcb085179b7f06de5fbe19cf4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/daboesch/ROC/pulls/9/commits","review_comments_url":"https://api.github.com/repos/daboesch/ROC/pulls/9/comments","review_comment_url":"https://api.github.com/repos/daboesch/ROC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/daboesch/ROC/issues/9/comments","statuses_url":"https://api.github.com/repos/daboesch/ROC/statuses/c871eae10e535cb38c1b535d84d7ae6b86eae63b","head":{"label":"jocelyn:blog","ref":"blog","sha":"c871eae10e535cb38c1b535d84d7ae6b86eae63b","user":{"login":"jocelyn","id":31598,"avatar_url":"https://avatars.githubusercontent.com/u/31598?v=3","gravatar_id":"","url":"https://api.github.com/users/jocelyn","html_url":"https://github.com/jocelyn","followers_url":"https://api.github.com/users/jocelyn/followers","following_url":"https://api.github.com/users/jocelyn/following{/other_user}","gists_url":"https://api.github.com/users/jocelyn/gists{/gist_id}","starred_url":"https://api.github.com/users/jocelyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jocelyn/subscriptions","organizations_url":"https://api.github.com/users/jocelyn/orgs","repos_url":"https://api.github.com/users/jocelyn/repos","events_url":"https://api.github.com/users/jocelyn/events{/privacy}","received_events_url":"https://api.github.com/users/jocelyn/received_events","type":"User","site_admin":false},"repo":{"id":24068997,"name":"ROC","full_name":"jocelyn/ROC","owner":{"login":"jocelyn","id":31598,"avatar_url":"https://avatars.githubusercontent.com/u/31598?v=3","gravatar_id":"","url":"https://api.github.com/users/jocelyn","html_url":"https://github.com/jocelyn","followers_url":"https://api.github.com/users/jocelyn/followers","following_url":"https://api.github.com/users/jocelyn/following{/other_user}","gists_url":"https://api.github.com/users/jocelyn/gists{/gist_id}","starred_url":"https://api.github.com/users/jocelyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jocelyn/subscriptions","organizations_url":"https://api.github.com/users/jocelyn/orgs","repos_url":"https://api.github.com/users/jocelyn/repos","events_url":"https://api.github.com/users/jocelyn/events{/privacy}","received_events_url":"https://api.github.com/users/jocelyn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jocelyn/ROC","description":"Rest on CMS ","fork":true,"url":"https://api.github.com/repos/jocelyn/ROC","forks_url":"https://api.github.com/repos/jocelyn/ROC/forks","keys_url":"https://api.github.com/repos/jocelyn/ROC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jocelyn/ROC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jocelyn/ROC/teams","hooks_url":"https://api.github.com/repos/jocelyn/ROC/hooks","issue_events_url":"https://api.github.com/repos/jocelyn/ROC/issues/events{/number}","events_url":"https://api.github.com/repos/jocelyn/ROC/events","assignees_url":"https://api.github.com/repos/jocelyn/ROC/assignees{/user}","branches_url":"https://api.github.com/repos/jocelyn/ROC/branches{/branch}","tags_url":"https://api.github.com/repos/jocelyn/ROC/tags","blobs_url":"https://api.github.com/repos/jocelyn/ROC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jocelyn/ROC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jocelyn/ROC/git/refs{/sha}","trees_url":"https://api.github.com/repos/jocelyn/ROC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jocelyn/ROC/statuses/{sha}","languages_url":"https://api.github.com/repos/jocelyn/ROC/languages","stargazers_url":"https://api.github.com/repos/jocelyn/ROC/stargazers","contributors_url":"https://api.github.com/repos/jocelyn/ROC/contributors","subscribers_url":"https://api.github.com/repos/jocelyn/ROC/subscribers","subscription_url":"https://api.github.com/repos/jocelyn/ROC/subscription","commits_url":"https://api.github.com/repos/jocelyn/ROC/commits{/sha}","git_commits_url":"https://api.github.com/repos/jocelyn/ROC/git/commits{/sha}","comments_url":"https://api.github.com/repos/jocelyn/ROC/comments{/number}","issue_comment_url":"https://api.github.com/repos/jocelyn/ROC/issues/comments{/number}","contents_url":"https://api.github.com/repos/jocelyn/ROC/contents/{+path}","compare_url":"https://api.github.com/repos/jocelyn/ROC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jocelyn/ROC/merges","archive_url":"https://api.github.com/repos/jocelyn/ROC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jocelyn/ROC/downloads","issues_url":"https://api.github.com/repos/jocelyn/ROC/issues{/number}","pulls_url":"https://api.github.com/repos/jocelyn/ROC/pulls{/number}","milestones_url":"https://api.github.com/repos/jocelyn/ROC/milestones{/number}","notifications_url":"https://api.github.com/repos/jocelyn/ROC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jocelyn/ROC/labels{/name}","releases_url":"https://api.github.com/repos/jocelyn/ROC/releases{/id}","created_at":"2014-09-15T18:49:42Z","updated_at":"2015-04-30T17:51:30Z","pushed_at":"2015-05-31T20:43:27Z","git_url":"git://github.com/jocelyn/ROC.git","ssh_url":"git@github.com:jocelyn/ROC.git","clone_url":"https://github.com/jocelyn/ROC.git","svn_url":"https://github.com/jocelyn/ROC","homepage":null,"size":1283,"stargazers_count":0,"watchers_count":0,"language":"Eiffel","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"daboesch:blog","ref":"blog","sha":"e35893fdb94a72018bd6cb784582b539f7b264d6","user":{"login":"daboesch","id":9678443,"avatar_url":"https://avatars.githubusercontent.com/u/9678443?v=3","gravatar_id":"","url":"https://api.github.com/users/daboesch","html_url":"https://github.com/daboesch","followers_url":"https://api.github.com/users/daboesch/followers","following_url":"https://api.github.com/users/daboesch/following{/other_user}","gists_url":"https://api.github.com/users/daboesch/gists{/gist_id}","starred_url":"https://api.github.com/users/daboesch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daboesch/subscriptions","organizations_url":"https://api.github.com/users/daboesch/orgs","repos_url":"https://api.github.com/users/daboesch/repos","events_url":"https://api.github.com/users/daboesch/events{/privacy}","received_events_url":"https://api.github.com/users/daboesch/received_events","type":"User","site_admin":false},"repo":{"id":35866945,"name":"ROC","full_name":"daboesch/ROC","owner":{"login":"daboesch","id":9678443,"avatar_url":"https://avatars.githubusercontent.com/u/9678443?v=3","gravatar_id":"","url":"https://api.github.com/users/daboesch","html_url":"https://github.com/daboesch","followers_url":"https://api.github.com/users/daboesch/followers","following_url":"https://api.github.com/users/daboesch/following{/other_user}","gists_url":"https://api.github.com/users/daboesch/gists{/gist_id}","starred_url":"https://api.github.com/users/daboesch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daboesch/subscriptions","organizations_url":"https://api.github.com/users/daboesch/orgs","repos_url":"https://api.github.com/users/daboesch/repos","events_url":"https://api.github.com/users/daboesch/events{/privacy}","received_events_url":"https://api.github.com/users/daboesch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/daboesch/ROC","description":"Rest on CMS ","fork":true,"url":"https://api.github.com/repos/daboesch/ROC","forks_url":"https://api.github.com/repos/daboesch/ROC/forks","keys_url":"https://api.github.com/repos/daboesch/ROC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daboesch/ROC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daboesch/ROC/teams","hooks_url":"https://api.github.com/repos/daboesch/ROC/hooks","issue_events_url":"https://api.github.com/repos/daboesch/ROC/issues/events{/number}","events_url":"https://api.github.com/repos/daboesch/ROC/events","assignees_url":"https://api.github.com/repos/daboesch/ROC/assignees{/user}","branches_url":"https://api.github.com/repos/daboesch/ROC/branches{/branch}","tags_url":"https://api.github.com/repos/daboesch/ROC/tags","blobs_url":"https://api.github.com/repos/daboesch/ROC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daboesch/ROC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daboesch/ROC/git/refs{/sha}","trees_url":"https://api.github.com/repos/daboesch/ROC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daboesch/ROC/statuses/{sha}","languages_url":"https://api.github.com/repos/daboesch/ROC/languages","stargazers_url":"https://api.github.com/repos/daboesch/ROC/stargazers","contributors_url":"https://api.github.com/repos/daboesch/ROC/contributors","subscribers_url":"https://api.github.com/repos/daboesch/ROC/subscribers","subscription_url":"https://api.github.com/repos/daboesch/ROC/subscription","commits_url":"https://api.github.com/repos/daboesch/ROC/commits{/sha}","git_commits_url":"https://api.github.com/repos/daboesch/ROC/git/commits{/sha}","comments_url":"https://api.github.com/repos/daboesch/ROC/comments{/number}","issue_comment_url":"https://api.github.com/repos/daboesch/ROC/issues/comments{/number}","contents_url":"https://api.github.com/repos/daboesch/ROC/contents/{+path}","compare_url":"https://api.github.com/repos/daboesch/ROC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daboesch/ROC/merges","archive_url":"https://api.github.com/repos/daboesch/ROC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daboesch/ROC/downloads","issues_url":"https://api.github.com/repos/daboesch/ROC/issues{/number}","pulls_url":"https://api.github.com/repos/daboesch/ROC/pulls{/number}","milestones_url":"https://api.github.com/repos/daboesch/ROC/milestones{/number}","notifications_url":"https://api.github.com/repos/daboesch/ROC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daboesch/ROC/labels{/name}","releases_url":"https://api.github.com/repos/daboesch/ROC/releases{/id}","created_at":"2015-05-19T07:41:33Z","updated_at":"2015-05-19T08:31:59Z","pushed_at":"2015-05-27T21:12:24Z","git_url":"git://github.com/daboesch/ROC.git","ssh_url":"git@github.com:daboesch/ROC.git","clone_url":"https://github.com/daboesch/ROC.git","svn_url":"https://github.com/daboesch/ROC","homepage":null,"size":1075,"stargazers_count":0,"watchers_count":0,"language":"Eiffel","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/daboesch/ROC/pulls/9"},"html":{"href":"https://github.com/daboesch/ROC/pull/9"},"issue":{"href":"https://api.github.com/repos/daboesch/ROC/issues/9"},"comments":{"href":"https://api.github.com/repos/daboesch/ROC/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/daboesch/ROC/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/daboesch/ROC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/daboesch/ROC/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/daboesch/ROC/statuses/c871eae10e535cb38c1b535d84d7ae6b86eae63b"}}}}