{"action":"created","comment":{"url":"https://api.github.com/repos/bem/bem-components/pulls/comments/25081058","id":25081058,"diff_hunk":"@@ -4,11 +4,22 @@ block('progressbar')(\n         return { val : this.ctx.val };\n     }),\n \n+    attrs()(function() {\n+        return {\n+            role : 'progressbar',\n+            'aria-label' : this.ctx.ariaLabel,\n+            'aria-labelledby' : this.ctx.ariaLabelledBy,\n+            'aria-valuemin' : 0,\n+            'aria-valuemax' : 100,\n+            'aria-valuenow' : this.ctx.val || 0","path":"common.blocks/progressbar/progressbar.bemhtml","position":11,"original_position":11,"commit_id":"0f59f934522b0da327c57540a88e6e8ca8f5c953","original_commit_id":"0f59f934522b0da327c57540a88e6e8ca8f5c953","user":{"login":"narqo","id":88045,"avatar_url":"https://avatars.githubusercontent.com/u/88045?v=3","gravatar_id":"","url":"https://api.github.com/users/narqo","html_url":"https://github.com/narqo","followers_url":"https://api.github.com/users/narqo/followers","following_url":"https://api.github.com/users/narqo/following{/other_user}","gists_url":"https://api.github.com/users/narqo/gists{/gist_id}","starred_url":"https://api.github.com/users/narqo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/narqo/subscriptions","organizations_url":"https://api.github.com/users/narqo/orgs","repos_url":"https://api.github.com/users/narqo/repos","events_url":"https://api.github.com/users/narqo/events{/privacy}","received_events_url":"https://api.github.com/users/narqo/received_events","type":"User","site_admin":false},"body":"According to our docs `this.ctx.val` should always [be `Number`]. In other cases you should fix js-mode above or block's JS will fail as @sipayRT have mentioned.\r\n\r\n[1]: https://en.bem.info/libs/bem-components/v2.0.0/desktop/progressbar/docs/#val","created_at":"2015-02-20T16:22:32Z","updated_at":"2015-02-20T16:22:32Z","html_url":"https://github.com/bem/bem-components/pull/1355#discussion_r25081058","pull_request_url":"https://api.github.com/repos/bem/bem-components/pulls/1355","_links":{"self":{"href":"https://api.github.com/repos/bem/bem-components/pulls/comments/25081058"},"html":{"href":"https://github.com/bem/bem-components/pull/1355#discussion_r25081058"},"pull_request":{"href":"https://api.github.com/repos/bem/bem-components/pulls/1355"}}},"pull_request":{"url":"https://api.github.com/repos/bem/bem-components/pulls/1355","id":29262015,"html_url":"https://github.com/bem/bem-components/pull/1355","diff_url":"https://github.com/bem/bem-components/pull/1355.diff","patch_url":"https://github.com/bem/bem-components/pull/1355.patch","issue_url":"https://api.github.com/repos/bem/bem-components/issues/1355","number":1355,"state":"open","locked":false,"title":"progressbar: Improve a11y","user":{"login":"hcodes","id":157520,"avatar_url":"https://avatars.githubusercontent.com/u/157520?v=3","gravatar_id":"","url":"https://api.github.com/users/hcodes","html_url":"https://github.com/hcodes","followers_url":"https://api.github.com/users/hcodes/followers","following_url":"https://api.github.com/users/hcodes/following{/other_user}","gists_url":"https://api.github.com/users/hcodes/gists{/gist_id}","starred_url":"https://api.github.com/users/hcodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hcodes/subscriptions","organizations_url":"https://api.github.com/users/hcodes/orgs","repos_url":"https://api.github.com/users/hcodes/repos","events_url":"https://api.github.com/users/hcodes/events{/privacy}","received_events_url":"https://api.github.com/users/hcodes/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-02-13T12:50:16Z","updated_at":"2015-02-20T16:22:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e554a73b76188ca190db5a72f5c143cbd5b845ea","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bem/bem-components/pulls/1355/commits","review_comments_url":"https://api.github.com/repos/bem/bem-components/pulls/1355/comments","review_comment_url":"https://api.github.com/repos/bem/bem-components/pulls/comments/{number}","comments_url":"https://api.github.com/repos/bem/bem-components/issues/1355/comments","statuses_url":"https://api.github.com/repos/bem/bem-components/statuses/0f59f934522b0da327c57540a88e6e8ca8f5c953","head":{"label":"issues/1206@v2_progressbar","ref":"issues/1206@v2_progressbar","sha":"0f59f934522b0da327c57540a88e6e8ca8f5c953","user":{"login":"bem","id":223412,"avatar_url":"https://avatars.githubusercontent.com/u/223412?v=3","gravatar_id":"","url":"https://api.github.com/users/bem","html_url":"https://github.com/bem","followers_url":"https://api.github.com/users/bem/followers","following_url":"https://api.github.com/users/bem/following{/other_user}","gists_url":"https://api.github.com/users/bem/gists{/gist_id}","starred_url":"https://api.github.com/users/bem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bem/subscriptions","organizations_url":"https://api.github.com/users/bem/orgs","repos_url":"https://api.github.com/users/bem/repos","events_url":"https://api.github.com/users/bem/events{/privacy}","received_events_url":"https://api.github.com/users/bem/received_events","type":"Organization","site_admin":false},"repo":{"id":6578551,"name":"bem-components","full_name":"bem/bem-components","owner":{"login":"bem","id":223412,"avatar_url":"https://avatars.githubusercontent.com/u/223412?v=3","gravatar_id":"","url":"https://api.github.com/users/bem","html_url":"https://github.com/bem","followers_url":"https://api.github.com/users/bem/followers","following_url":"https://api.github.com/users/bem/following{/other_user}","gists_url":"https://api.github.com/users/bem/gists{/gist_id}","starred_url":"https://api.github.com/users/bem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bem/subscriptions","organizations_url":"https://api.github.com/users/bem/orgs","repos_url":"https://api.github.com/users/bem/repos","events_url":"https://api.github.com/users/bem/events{/privacy}","received_events_url":"https://api.github.com/users/bem/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bem/bem-components","description":"Set of components for sites development","fork":false,"url":"https://api.github.com/repos/bem/bem-components","forks_url":"https://api.github.com/repos/bem/bem-components/forks","keys_url":"https://api.github.com/repos/bem/bem-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bem/bem-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bem/bem-components/teams","hooks_url":"https://api.github.com/repos/bem/bem-components/hooks","issue_events_url":"https://api.github.com/repos/bem/bem-components/issues/events{/number}","events_url":"https://api.github.com/repos/bem/bem-components/events","assignees_url":"https://api.github.com/repos/bem/bem-components/assignees{/user}","branches_url":"https://api.github.com/repos/bem/bem-components/branches{/branch}","tags_url":"https://api.github.com/repos/bem/bem-components/tags","blobs_url":"https://api.github.com/repos/bem/bem-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bem/bem-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bem/bem-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/bem/bem-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bem/bem-components/statuses/{sha}","languages_url":"https://api.github.com/repos/bem/bem-components/languages","stargazers_url":"https://api.github.com/repos/bem/bem-components/stargazers","contributors_url":"https://api.github.com/repos/bem/bem-components/contributors","subscribers_url":"https://api.github.com/repos/bem/bem-components/subscribers","subscription_url":"https://api.github.com/repos/bem/bem-components/subscription","commits_url":"https://api.github.com/repos/bem/bem-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/bem/bem-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/bem/bem-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/bem/bem-components/issues/comments/{number}","contents_url":"https://api.github.com/repos/bem/bem-components/contents/{+path}","compare_url":"https://api.github.com/repos/bem/bem-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bem/bem-components/merges","archive_url":"https://api.github.com/repos/bem/bem-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bem/bem-components/downloads","issues_url":"https://api.github.com/repos/bem/bem-components/issues{/number}","pulls_url":"https://api.github.com/repos/bem/bem-components/pulls{/number}","milestones_url":"https://api.github.com/repos/bem/bem-components/milestones{/number}","notifications_url":"https://api.github.com/repos/bem/bem-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bem/bem-components/labels{/name}","releases_url":"https://api.github.com/repos/bem/bem-components/releases{/id}","created_at":"2012-11-07T11:54:35Z","updated_at":"2015-02-20T10:43:11Z","pushed_at":"2015-02-20T11:10:19Z","git_url":"git://github.com/bem/bem-components.git","ssh_url":"git@github.com:bem/bem-components.git","clone_url":"https://github.com/bem/bem-components.git","svn_url":"https://github.com/bem/bem-components","homepage":"https://bem.info/libs/bem-components/","size":22152,"stargazers_count":69,"watchers_count":69,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":62,"forks":42,"open_issues":62,"watchers":69,"default_branch":"v2"}},"base":{"label":"v2","ref":"v2","sha":"6970f05c77d544c50bd83e01fe8befd0f65403eb","user":{"login":"bem","id":223412,"avatar_url":"https://avatars.githubusercontent.com/u/223412?v=3","gravatar_id":"","url":"https://api.github.com/users/bem","html_url":"https://github.com/bem","followers_url":"https://api.github.com/users/bem/followers","following_url":"https://api.github.com/users/bem/following{/other_user}","gists_url":"https://api.github.com/users/bem/gists{/gist_id}","starred_url":"https://api.github.com/users/bem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bem/subscriptions","organizations_url":"https://api.github.com/users/bem/orgs","repos_url":"https://api.github.com/users/bem/repos","events_url":"https://api.github.com/users/bem/events{/privacy}","received_events_url":"https://api.github.com/users/bem/received_events","type":"Organization","site_admin":false},"repo":{"id":6578551,"name":"bem-components","full_name":"bem/bem-components","owner":{"login":"bem","id":223412,"avatar_url":"https://avatars.githubusercontent.com/u/223412?v=3","gravatar_id":"","url":"https://api.github.com/users/bem","html_url":"https://github.com/bem","followers_url":"https://api.github.com/users/bem/followers","following_url":"https://api.github.com/users/bem/following{/other_user}","gists_url":"https://api.github.com/users/bem/gists{/gist_id}","starred_url":"https://api.github.com/users/bem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bem/subscriptions","organizations_url":"https://api.github.com/users/bem/orgs","repos_url":"https://api.github.com/users/bem/repos","events_url":"https://api.github.com/users/bem/events{/privacy}","received_events_url":"https://api.github.com/users/bem/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bem/bem-components","description":"Set of components for sites development","fork":false,"url":"https://api.github.com/repos/bem/bem-components","forks_url":"https://api.github.com/repos/bem/bem-components/forks","keys_url":"https://api.github.com/repos/bem/bem-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bem/bem-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bem/bem-components/teams","hooks_url":"https://api.github.com/repos/bem/bem-components/hooks","issue_events_url":"https://api.github.com/repos/bem/bem-components/issues/events{/number}","events_url":"https://api.github.com/repos/bem/bem-components/events","assignees_url":"https://api.github.com/repos/bem/bem-components/assignees{/user}","branches_url":"https://api.github.com/repos/bem/bem-components/branches{/branch}","tags_url":"https://api.github.com/repos/bem/bem-components/tags","blobs_url":"https://api.github.com/repos/bem/bem-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bem/bem-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bem/bem-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/bem/bem-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bem/bem-components/statuses/{sha}","languages_url":"https://api.github.com/repos/bem/bem-components/languages","stargazers_url":"https://api.github.com/repos/bem/bem-components/stargazers","contributors_url":"https://api.github.com/repos/bem/bem-components/contributors","subscribers_url":"https://api.github.com/repos/bem/bem-components/subscribers","subscription_url":"https://api.github.com/repos/bem/bem-components/subscription","commits_url":"https://api.github.com/repos/bem/bem-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/bem/bem-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/bem/bem-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/bem/bem-components/issues/comments/{number}","contents_url":"https://api.github.com/repos/bem/bem-components/contents/{+path}","compare_url":"https://api.github.com/repos/bem/bem-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bem/bem-components/merges","archive_url":"https://api.github.com/repos/bem/bem-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bem/bem-components/downloads","issues_url":"https://api.github.com/repos/bem/bem-components/issues{/number}","pulls_url":"https://api.github.com/repos/bem/bem-components/pulls{/number}","milestones_url":"https://api.github.com/repos/bem/bem-components/milestones{/number}","notifications_url":"https://api.github.com/repos/bem/bem-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bem/bem-components/labels{/name}","releases_url":"https://api.github.com/repos/bem/bem-components/releases{/id}","created_at":"2012-11-07T11:54:35Z","updated_at":"2015-02-20T10:43:11Z","pushed_at":"2015-02-20T11:10:19Z","git_url":"git://github.com/bem/bem-components.git","ssh_url":"git@github.com:bem/bem-components.git","clone_url":"https://github.com/bem/bem-components.git","svn_url":"https://github.com/bem/bem-components","homepage":"https://bem.info/libs/bem-components/","size":22152,"stargazers_count":69,"watchers_count":69,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":62,"forks":42,"open_issues":62,"watchers":69,"default_branch":"v2"}},"_links":{"self":{"href":"https://api.github.com/repos/bem/bem-components/pulls/1355"},"html":{"href":"https://github.com/bem/bem-components/pull/1355"},"issue":{"href":"https://api.github.com/repos/bem/bem-components/issues/1355"},"comments":{"href":"https://api.github.com/repos/bem/bem-components/issues/1355/comments"},"review_comments":{"href":"https://api.github.com/repos/bem/bem-components/pulls/1355/comments"},"review_comment":{"href":"https://api.github.com/repos/bem/bem-components/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/bem/bem-components/pulls/1355/commits"},"statuses":{"href":"https://api.github.com/repos/bem/bem-components/statuses/0f59f934522b0da327c57540a88e6e8ca8f5c953"}}}}