{"action":"created","comment":{"url":"https://api.github.com/repos/alertlogic/erlcloud/pulls/comments/39022269","id":39022269,"diff_hunk":"@@ -0,0 +1,269 @@\n+%% Amazon Route 53\n+\n+-module(erlcloud_route53).\n+\n+-export([describe_zones/0, describe_zones/3]).\n+\n+-export([describe_resource_sets/1, describe_resource_sets/4]).\n+\n+-export([describe_delegation_sets/0, describe_delegation_sets/3]).\n+\n+-include_lib(\"erlcloud/include/erlcloud.hrl\").\n+-include_lib(\"erlcloud/include/erlcloud_aws.hrl\").\n+-include_lib(\"erlcloud/include/erlcloud_route53.hrl\").\n+\n+-define(API_VERSION, \"2013-04-01\").\n+-define(DEFAULT_MAX_RECORDS, 20).\n+-define(DESCRIBE_ZONES_PATH, \"/ListHostedZonesResponse/HostedZones/HostedZone\").\n+-define(DESCRIBE_ZONE_IS_TRUNCATED, \"/ListHostedZonesResponse/IsTruncated\").\n+-define(DESCRIBE_ZONE_NEXT_MARKER, \"/ListHostedZonesResponse/NextMarker\").\n+-define(DESCRIBE_RS_PATH,\n+        \"/ListResourceRecordSetsResponse/ResourceRecordSets/ResourceRecordSet\").\n+-define(DESCRIBE_RS_IS_TRUNCATED,\n+        \"/ListResourceRecordSetsResponse/IsTruncated\").\n+-define(DESCRIBE_RS_NEXT_TYPE,\n+        \"/ListResourceRecordSetsResponse/NextRecordType\").\n+-define(DESCRIBE_RS_NEXT_NAME,\n+        \"/ListResourceRecordSetsResponse/NextRecordName\").\n+-define(DESCRIBE_RS_NEXT_ID,\n+        \"/ListResourceRecordSetsResponse/NextRecordIdentifier\").\n+-define(DESCRIBE_DS_PATH,\n+        \"/ListReusableDelegationSetsResponse/DelegationSets/DelegationSet\").\n+-define(DESCRIBE_DS_IS_TRUNCATED,\n+        \"/ListReusableDelegationSetsResponse/IsTruncated\").\n+-define(DESCRIBE_DS_NEXT_MARKER,\n+        \"/ListReusableDelegationSetsResponse/NextMarker\").\n+\n+%% --------------------------------------------------------------------\n+%% @doc Describes all zones using default config\n+%% @end\n+%% --------------------------------------------------------------------\n+-spec(describe_zones() ->\n+             {{paged, string()}, list(aws_route53_zone())} |\n+             {ok, list(aws_route53_zone())} |\n+             {error, term()}).\n+describe_zones() ->\n+    describe_zones([], ?DEFAULT_MAX_RECORDS, erlcloud_aws:default_config()).\n+\n+%% --------------------------------------------------------------------\n+%% @doc Describes all zones using passed config, limit + AWS options\n+%% @end\n+%% --------------------------------------------------------------------\n+-spec(describe_zones(Options   :: list({string(), string()}),\n+                     Limit     :: integer(),\n+                     AwsConfig :: aws_config()) ->\n+    {{paged, string()}, list(aws_route53_zone())} |\n+    {ok, list(aws_route53_zone())} |\n+    {error, term()}).\n+describe_zones(Options, Limit, Config) when is_list(Options),\n+                                            is_record(Config, aws_config),\n+                                            is_integer(Limit) ->\n+    do_describe_zones([{\"maxitems\", Limit} | Options], Config).\n+\n+%% --------------------------------------------------------------------\n+%% @doc Describes resource sets for a specific zone_id using default config\n+%% @end\n+%% --------------------------------------------------------------------\n+-spec(describe_resource_sets(ZoneId :: string()) ->\n+             {{paged, string()}, list(aws_route53_delegation_set())} |\n+             {{paged, {string(), string()}},list(aws_route53_resourceset())} |\n+             {ok, list(aws_route53_resourceset())} |\n+             {error, term()}).\n+describe_resource_sets(ZoneId) ->","path":"src/erlcloud_route53.erl","position":72,"original_position":72,"commit_id":"e712e5b79d3da421906a15de0b87545a060d7138","original_commit_id":"e712e5b79d3da421906a15de0b87545a060d7138","user":{"login":"motobob","id":5736793,"avatar_url":"https://avatars.githubusercontent.com/u/5736793?v=3","gravatar_id":"","url":"https://api.github.com/users/motobob","html_url":"https://github.com/motobob","followers_url":"https://api.github.com/users/motobob/followers","following_url":"https://api.github.com/users/motobob/following{/other_user}","gists_url":"https://api.github.com/users/motobob/gists{/gist_id}","starred_url":"https://api.github.com/users/motobob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/motobob/subscriptions","organizations_url":"https://api.github.com/users/motobob/orgs","repos_url":"https://api.github.com/users/motobob/repos","events_url":"https://api.github.com/users/motobob/events{/privacy}","received_events_url":"https://api.github.com/users/motobob/received_events","type":"User","site_admin":false},"body":"please add arity 2 API like `describe_resource_sets(ZoneId, Cfg)` for all","created_at":"2015-09-09T09:20:18Z","updated_at":"2015-09-09T09:20:18Z","html_url":"https://github.com/alertlogic/erlcloud/pull/43#discussion_r39022269","pull_request_url":"https://api.github.com/repos/alertlogic/erlcloud/pulls/43","_links":{"self":{"href":"https://api.github.com/repos/alertlogic/erlcloud/pulls/comments/39022269"},"html":{"href":"https://github.com/alertlogic/erlcloud/pull/43#discussion_r39022269"},"pull_request":{"href":"https://api.github.com/repos/alertlogic/erlcloud/pulls/43"}}},"pull_request":{"url":"https://api.github.com/repos/alertlogic/erlcloud/pulls/43","id":44525732,"html_url":"https://github.com/alertlogic/erlcloud/pull/43","diff_url":"https://github.com/alertlogic/erlcloud/pull/43.diff","patch_url":"https://github.com/alertlogic/erlcloud/pull/43.patch","issue_url":"https://api.github.com/repos/alertlogic/erlcloud/issues/43","number":43,"state":"open","locked":false,"title":"Add basic support for route 53 operations","user":{"login":"edhollandAL","id":11922660,"avatar_url":"https://avatars.githubusercontent.com/u/11922660?v=3","gravatar_id":"","url":"https://api.github.com/users/edhollandAL","html_url":"https://github.com/edhollandAL","followers_url":"https://api.github.com/users/edhollandAL/followers","following_url":"https://api.github.com/users/edhollandAL/following{/other_user}","gists_url":"https://api.github.com/users/edhollandAL/gists{/gist_id}","starred_url":"https://api.github.com/users/edhollandAL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edhollandAL/subscriptions","organizations_url":"https://api.github.com/users/edhollandAL/orgs","repos_url":"https://api.github.com/users/edhollandAL/repos","events_url":"https://api.github.com/users/edhollandAL/events{/privacy}","received_events_url":"https://api.github.com/users/edhollandAL/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-09-09T09:05:16Z","updated_at":"2015-09-09T09:20:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c3215d95d1e6c08078cad299d00af7baa1ef2a8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alertlogic/erlcloud/pulls/43/commits","review_comments_url":"https://api.github.com/repos/alertlogic/erlcloud/pulls/43/comments","review_comment_url":"https://api.github.com/repos/alertlogic/erlcloud/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alertlogic/erlcloud/issues/43/comments","statuses_url":"https://api.github.com/repos/alertlogic/erlcloud/statuses/e712e5b79d3da421906a15de0b87545a060d7138","head":{"label":"edhollandAL:add_route_53","ref":"add_route_53","sha":"e712e5b79d3da421906a15de0b87545a060d7138","user":{"login":"edhollandAL","id":11922660,"avatar_url":"https://avatars.githubusercontent.com/u/11922660?v=3","gravatar_id":"","url":"https://api.github.com/users/edhollandAL","html_url":"https://github.com/edhollandAL","followers_url":"https://api.github.com/users/edhollandAL/followers","following_url":"https://api.github.com/users/edhollandAL/following{/other_user}","gists_url":"https://api.github.com/users/edhollandAL/gists{/gist_id}","starred_url":"https://api.github.com/users/edhollandAL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edhollandAL/subscriptions","organizations_url":"https://api.github.com/users/edhollandAL/orgs","repos_url":"https://api.github.com/users/edhollandAL/repos","events_url":"https://api.github.com/users/edhollandAL/events{/privacy}","received_events_url":"https://api.github.com/users/edhollandAL/received_events","type":"User","site_admin":false},"repo":{"id":42112919,"name":"erlcloud","full_name":"edhollandAL/erlcloud","owner":{"login":"edhollandAL","id":11922660,"avatar_url":"https://avatars.githubusercontent.com/u/11922660?v=3","gravatar_id":"","url":"https://api.github.com/users/edhollandAL","html_url":"https://github.com/edhollandAL","followers_url":"https://api.github.com/users/edhollandAL/followers","following_url":"https://api.github.com/users/edhollandAL/following{/other_user}","gists_url":"https://api.github.com/users/edhollandAL/gists{/gist_id}","starred_url":"https://api.github.com/users/edhollandAL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edhollandAL/subscriptions","organizations_url":"https://api.github.com/users/edhollandAL/orgs","repos_url":"https://api.github.com/users/edhollandAL/repos","events_url":"https://api.github.com/users/edhollandAL/events{/privacy}","received_events_url":"https://api.github.com/users/edhollandAL/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edhollandAL/erlcloud","description":"Cloud Computing library for erlang (Amazon EC2, S3, SQS, SimpleDB, Mechanical Turk, ELB)","fork":true,"url":"https://api.github.com/repos/edhollandAL/erlcloud","forks_url":"https://api.github.com/repos/edhollandAL/erlcloud/forks","keys_url":"https://api.github.com/repos/edhollandAL/erlcloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edhollandAL/erlcloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edhollandAL/erlcloud/teams","hooks_url":"https://api.github.com/repos/edhollandAL/erlcloud/hooks","issue_events_url":"https://api.github.com/repos/edhollandAL/erlcloud/issues/events{/number}","events_url":"https://api.github.com/repos/edhollandAL/erlcloud/events","assignees_url":"https://api.github.com/repos/edhollandAL/erlcloud/assignees{/user}","branches_url":"https://api.github.com/repos/edhollandAL/erlcloud/branches{/branch}","tags_url":"https://api.github.com/repos/edhollandAL/erlcloud/tags","blobs_url":"https://api.github.com/repos/edhollandAL/erlcloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edhollandAL/erlcloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edhollandAL/erlcloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/edhollandAL/erlcloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edhollandAL/erlcloud/statuses/{sha}","languages_url":"https://api.github.com/repos/edhollandAL/erlcloud/languages","stargazers_url":"https://api.github.com/repos/edhollandAL/erlcloud/stargazers","contributors_url":"https://api.github.com/repos/edhollandAL/erlcloud/contributors","subscribers_url":"https://api.github.com/repos/edhollandAL/erlcloud/subscribers","subscription_url":"https://api.github.com/repos/edhollandAL/erlcloud/subscription","commits_url":"https://api.github.com/repos/edhollandAL/erlcloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/edhollandAL/erlcloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/edhollandAL/erlcloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/edhollandAL/erlcloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/edhollandAL/erlcloud/contents/{+path}","compare_url":"https://api.github.com/repos/edhollandAL/erlcloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edhollandAL/erlcloud/merges","archive_url":"https://api.github.com/repos/edhollandAL/erlcloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edhollandAL/erlcloud/downloads","issues_url":"https://api.github.com/repos/edhollandAL/erlcloud/issues{/number}","pulls_url":"https://api.github.com/repos/edhollandAL/erlcloud/pulls{/number}","milestones_url":"https://api.github.com/repos/edhollandAL/erlcloud/milestones{/number}","notifications_url":"https://api.github.com/repos/edhollandAL/erlcloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edhollandAL/erlcloud/labels{/name}","releases_url":"https://api.github.com/repos/edhollandAL/erlcloud/releases{/id}","created_at":"2015-09-08T13:12:05Z","updated_at":"2015-09-08T13:12:06Z","pushed_at":"2015-09-09T09:17:39Z","git_url":"git://github.com/edhollandAL/erlcloud.git","ssh_url":"git@github.com:edhollandAL/erlcloud.git","clone_url":"https://github.com/edhollandAL/erlcloud.git","svn_url":"https://github.com/edhollandAL/erlcloud","homepage":"","size":3386,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alertlogic:master","ref":"master","sha":"c7cdc249984f7c14ed382aea6881f396597ab094","user":{"login":"alertlogic","id":1900859,"avatar_url":"https://avatars.githubusercontent.com/u/1900859?v=3","gravatar_id":"","url":"https://api.github.com/users/alertlogic","html_url":"https://github.com/alertlogic","followers_url":"https://api.github.com/users/alertlogic/followers","following_url":"https://api.github.com/users/alertlogic/following{/other_user}","gists_url":"https://api.github.com/users/alertlogic/gists{/gist_id}","starred_url":"https://api.github.com/users/alertlogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alertlogic/subscriptions","organizations_url":"https://api.github.com/users/alertlogic/orgs","repos_url":"https://api.github.com/users/alertlogic/repos","events_url":"https://api.github.com/users/alertlogic/events{/privacy}","received_events_url":"https://api.github.com/users/alertlogic/received_events","type":"Organization","site_admin":false},"repo":{"id":34382596,"name":"erlcloud","full_name":"alertlogic/erlcloud","owner":{"login":"alertlogic","id":1900859,"avatar_url":"https://avatars.githubusercontent.com/u/1900859?v=3","gravatar_id":"","url":"https://api.github.com/users/alertlogic","html_url":"https://github.com/alertlogic","followers_url":"https://api.github.com/users/alertlogic/followers","following_url":"https://api.github.com/users/alertlogic/following{/other_user}","gists_url":"https://api.github.com/users/alertlogic/gists{/gist_id}","starred_url":"https://api.github.com/users/alertlogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alertlogic/subscriptions","organizations_url":"https://api.github.com/users/alertlogic/orgs","repos_url":"https://api.github.com/users/alertlogic/repos","events_url":"https://api.github.com/users/alertlogic/events{/privacy}","received_events_url":"https://api.github.com/users/alertlogic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alertlogic/erlcloud","description":"Cloud Computing library for erlang (Amazon EC2, S3, SQS, SimpleDB, Mechanical Turk, ELB)","fork":true,"url":"https://api.github.com/repos/alertlogic/erlcloud","forks_url":"https://api.github.com/repos/alertlogic/erlcloud/forks","keys_url":"https://api.github.com/repos/alertlogic/erlcloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alertlogic/erlcloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alertlogic/erlcloud/teams","hooks_url":"https://api.github.com/repos/alertlogic/erlcloud/hooks","issue_events_url":"https://api.github.com/repos/alertlogic/erlcloud/issues/events{/number}","events_url":"https://api.github.com/repos/alertlogic/erlcloud/events","assignees_url":"https://api.github.com/repos/alertlogic/erlcloud/assignees{/user}","branches_url":"https://api.github.com/repos/alertlogic/erlcloud/branches{/branch}","tags_url":"https://api.github.com/repos/alertlogic/erlcloud/tags","blobs_url":"https://api.github.com/repos/alertlogic/erlcloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alertlogic/erlcloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alertlogic/erlcloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/alertlogic/erlcloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alertlogic/erlcloud/statuses/{sha}","languages_url":"https://api.github.com/repos/alertlogic/erlcloud/languages","stargazers_url":"https://api.github.com/repos/alertlogic/erlcloud/stargazers","contributors_url":"https://api.github.com/repos/alertlogic/erlcloud/contributors","subscribers_url":"https://api.github.com/repos/alertlogic/erlcloud/subscribers","subscription_url":"https://api.github.com/repos/alertlogic/erlcloud/subscription","commits_url":"https://api.github.com/repos/alertlogic/erlcloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/alertlogic/erlcloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/alertlogic/erlcloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/alertlogic/erlcloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/alertlogic/erlcloud/contents/{+path}","compare_url":"https://api.github.com/repos/alertlogic/erlcloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alertlogic/erlcloud/merges","archive_url":"https://api.github.com/repos/alertlogic/erlcloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alertlogic/erlcloud/downloads","issues_url":"https://api.github.com/repos/alertlogic/erlcloud/issues{/number}","pulls_url":"https://api.github.com/repos/alertlogic/erlcloud/pulls{/number}","milestones_url":"https://api.github.com/repos/alertlogic/erlcloud/milestones{/number}","notifications_url":"https://api.github.com/repos/alertlogic/erlcloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alertlogic/erlcloud/labels{/name}","releases_url":"https://api.github.com/repos/alertlogic/erlcloud/releases{/id}","created_at":"2015-04-22T09:53:41Z","updated_at":"2015-07-14T19:35:42Z","pushed_at":"2015-09-09T09:17:40Z","git_url":"git://github.com/alertlogic/erlcloud.git","ssh_url":"git@github.com:alertlogic/erlcloud.git","clone_url":"https://github.com/alertlogic/erlcloud.git","svn_url":"https://github.com/alertlogic/erlcloud","homepage":"","size":2912,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alertlogic/erlcloud/pulls/43"},"html":{"href":"https://github.com/alertlogic/erlcloud/pull/43"},"issue":{"href":"https://api.github.com/repos/alertlogic/erlcloud/issues/43"},"comments":{"href":"https://api.github.com/repos/alertlogic/erlcloud/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/alertlogic/erlcloud/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/alertlogic/erlcloud/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alertlogic/erlcloud/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/alertlogic/erlcloud/statuses/e712e5b79d3da421906a15de0b87545a060d7138"}}}}